1 2012-05-30 Chong Yidong <cyd@gnu.org>
3 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
5 * doc.c (Fsubstitute_command_keys): Doc fix.
7 2012-05-29 Eli Zaretskii <eliz@gnu.org>
9 * search.c (search_buffer): Remove calls to
10 r_alloc_inhibit_buffer_relocation, as it is now called by
11 maybe_unify_char, which was the cause of relocation of buffer text
14 2012-05-23 Eli Zaretskii <eliz@gnu.org>
16 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
17 for the duration of call to load_charset, to avoid problems with
18 callers of maybe_unify_char that access buffer text through C
21 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
22 decrement the inhibition flag, instead of just setting or
25 2012-05-24 Ken Brown <kbrown@cornell.edu>
27 * callproc.c (Fcall_process): Restore a line that was accidentally
28 commented out in the 2011-02-13 change (bug#11547).
30 2012-05-23 Eli Zaretskii <eliz@gnu.org>
32 * lisp.h [REL_ALLOC]: Add prototypes for external functions
35 * buffer.c [REL_ALLOC]: Remove prototypes of
36 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
37 they are now on lisp.h.
39 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
41 * search.c (search_buffer): Use it to inhibit relocation of buffer
42 text while re_search_2 is doing its job, because re_search_2 is
43 passed C pointers to buffer text. (Bug#11519)
45 2012-05-21 Eli Zaretskii <eliz@gnu.org>
47 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
50 2012-05-19 Eli Zaretskii <eliz@gnu.org>
52 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
53 state after an additional call to move_it_in_display_line_to, keep
54 the values of it->max_ascent and it->max_descent found for the
56 (pos_visible_p): Revert the comparison against bottom_y to what it
57 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
60 2012-05-15 Eli Zaretskii <eliz@gnu.org>
62 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
64 2012-05-13 Eli Zaretskii <eliz@gnu.org>
66 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
67 already have overlays loaded.
68 (handle_single_display_spec): Before returning without displaying
69 fringe bitmap, synchronize the bidi iterator with the main display
70 iterator, by calling iterate_out_of_display_property.
71 (iterate_out_of_display_property): Detect buffer iteration by
72 testing that it->string is a Lisp string.
73 (get_next_display_element): When the current object is exhausted,
74 and there's something on it->stack, call set_iterator_to_next to
75 proceed with what's on the stack, instead of returning zero.
76 (set_iterator_to_next): If called at the end of a Lisp string,
77 proceed to consider_string_end without incrementing string
78 position. Don't increment display vector index past the end of
79 the display vector. (Bug#11417)
80 (pos_visible_p): Don't report a position visible when move_it_to
81 stopped at the last line of window, which happens to be scanned
82 backwards by the bidi iteration. (Bug#11464)
84 2012-05-11 Eli Zaretskii <eliz@gnu.org>
86 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
87 and right-margin display specs even if the spec is invalid or we
88 are on a TTY, and thus unable to display on the fringes. That's
89 because the text with the property will not be displayed anyway,
90 so we need to signal to the caller that this is a "replacing"
91 display spec. This fixes display when the spec is invalid or we
94 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
96 * unexaix.c (make_hdr): Fix typo in prototype.
97 This bug broke the build on AIX. Problem reported by Gilles Pion.
99 2012-05-05 Eli Zaretskii <eliz@gnu.org>
101 * w32proc.c (new_child): Force Windows to reserve only 64KB of
102 stack for each reader_thread, instead of defaulting to 8MB
103 determined by the linker. This avoids failures in creating
104 subprocesses on Windows 7, see the discussion in this thread:
105 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
107 2012-05-02 Jim Meyering <meyering@redhat.com>
109 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
111 2012-04-29 Eli Zaretskii <eliz@gnu.org>
113 * xdisp.c (pos_visible_p): If already at a newline from the
114 display string before the 'while' loop, don't walk back the glyphs
115 from it3.glyph_row. Solves assertion violation when the display
116 string begins with a newline (egg.el). (Bug#11367)
118 2012-04-24 Chong Yidong <cyd@gnu.org>
120 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
122 2012-04-23 Eli Zaretskii <eliz@gnu.org>
124 * xdisp.c (pos_visible_p): If the window start position is beyond
125 ZV, start the display from buffer beginning. Prevents assertion
126 violation in init_iterator when the minibuffer window is scrolled
129 * window.c (window_scroll_pixel_based): Likewise.
131 2012-04-23 Chong Yidong <cyd@gnu.org>
133 * keymap.c (where_is_internal): Doc fix (Bug#10872).
135 2012-04-20 Glenn Morris <rgm@gnu.org>
137 * fileio.c (Fcopy_file, Fset_file_selinux_context):
138 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
140 2012-04-20 Eli Zaretskii <eliz@gnu.org>
142 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
143 overrun array limits of glyph row's used[] array. (Bug#11288)
145 2012-04-20 Chong Yidong <cyd@gnu.org>
147 * process.c (wait_reading_process_output): If EIO occurs on a pty,
148 set the status to "failed" and ensure that sentinel is run.
150 2012-04-18 Glenn Morris <rgm@gnu.org>
152 * process.c (Fset_process_inherit_coding_system_flag)
153 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
154 (Fmake_network_process, Fmake_serial_process): Doc fix.
156 2012-04-17 Eli Zaretskii <eliz@gnu.org>
158 * xdisp.c (string_buffer_position_lim): Limit starting position to
160 (set_cursor_from_row): If called for a mode-line or header-line
161 row, return zero immediately.
162 (try_cursor_movement): If inside continuation line, don't back up
163 farther than the first row after the header line, if any. Don't
164 consider the header-line row as "partially visible", even if
165 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
167 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
169 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
171 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
173 * process.c (make_process):
174 * process.h: Add integer `gnutls_handshakes_tried' member to
177 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
178 Add convenience `GNUTLS_LOG2i' macro.
180 * gnutls.c (gnutls_log_function2i): Convenience log function.
181 (emacs_gnutls_read): Use new log functions,
182 `gnutls_handshakes_tried' process member, and
183 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
184 attempts per process (connection).
186 2012-04-09 Eli Zaretskii <eliz@gnu.org>
188 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
189 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
191 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
193 * nsterm.m (constrainFrameRect): Always constrain when there is only
194 one screen (Bug#10962).
196 2012-04-06 Eli Zaretskii <eliz@gnu.org>
198 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
199 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
200 about subtle differences between FETCH_CHAR* and STRING_CHAR*
201 macros related to unification of CJK characters. For the details,
202 see the discussion following the message here:
203 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
205 2012-04-04 Chong Yidong <cyd@gnu.org>
207 * keyboard.c (Vdelayed_warnings_list): Doc fix.
209 2012-04-01 Eli Zaretskii <eliz@gnu.org>
211 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
212 instead of alloca. (Bug#11138)
214 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
216 * w32menu.c (is_simple_dialog): Properly check lisp types.
219 2012-03-31 Eli Zaretskii <eliz@gnu.org>
221 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
222 position we get to after a call to move_it_to fails the
223 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
224 only if we wind up in a string from display property. (Bug#11063)
226 * window.c (Fdelete_other_windows_internal): Invalidate the row
227 and column information about mouse highlight, so that redisplay
228 restores it after reallocating the glyph matrices. (Bug#7464)
230 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
231 string comes from a `display' text property, use the buffer
232 position of that property as if we actually saw that position in
234 (move_it_by_lines): Remove the assertion that
235 "it->current_x == 0 && it->hpos == 0" which can be legitimately
236 violated when there's a before-string at the beginning of a line.
239 2012-03-30 Eli Zaretskii <eliz@gnu.org>
241 * xdisp.c (append_space_for_newline): If the default face was
242 remapped, use the remapped face for the appended newline.
243 (extend_face_to_end_of_line): Use the remapped default face for
244 extending the face to the end of the line.
245 (display_line): Call extend_face_to_end_of_line when the default
246 face was remapped. (Bug#11068)
248 2012-03-29 Eli Zaretskii <eliz@gnu.org>
250 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
252 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
254 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
256 2012-03-27 Glenn Morris <rgm@gnu.org>
258 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
261 2012-03-26 Kenichi Handa <handa@m17n.org>
263 * dispextern.h (struct glyph): Fix previous change. Change the
264 bit length of glyphless.ch to 25 (Bug#11082).
266 2012-03-26 Chong Yidong <cyd@gnu.org>
268 * keyboard.c (Vselection_inhibit_update_commands): New variable.
269 (command_loop_1): Use it; inhibit selection update for
270 handle-select-window too (Bug#8996).
272 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
274 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
276 2012-03-25 Kenichi Handa <handa@m17n.org>
278 * dispextern.h (struct glyph): Change the bit length of
279 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
281 2012-03-24 Eli Zaretskii <eliz@gnu.org>
283 * s/ms-w32.h (tzname): Include time.h before redirecting to
284 _tzname. Fixes the MSVC build. (Bug#9960)
286 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
288 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
291 * xterm.c (XTread_socket): Only modify handling_signal if
292 !SYNC_INPUT. (Bug#11080)
294 2012-03-23 Eli Zaretskii <eliz@gnu.org>
296 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
297 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
298 when fetching a multibyte character consumes more bytes than
299 CHAR_BYTES returns, due to unification of CJK characters in
300 string_char. (Bug#11073)
302 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
304 * process.c (wait_reading_process_output): Handle pty disconnect
305 by refraining from sending oneself a SIGCHLD (bug#10933).
307 2012-03-22 Chong Yidong <cyd@gnu.org>
309 * dispextern.h (struct it): New member string_from_prefix_prop_p.
311 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
312 Mark string as coming from a prefix property.
313 (handle_face_prop): Use default face for prefix strings (Bug#4281).
314 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
316 2012-03-21 Chong Yidong <cyd@gnu.org>
318 * xfaces.c (Vface_remapping_alist): Doc fix.
320 2012-03-20 Eli Zaretskii <eliz@gnu.org>
322 * w32proc.c (Fw32_set_console_codepage)
323 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
326 2012-03-20 Chong Yidong <cyd@gnu.org>
328 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
329 to reflect default non-nil value of redisplay-dont-pause.
331 2012-03-19 Kenichi Handa <handa@m17n.org>
333 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
334 it fit in a valid range (Bug#11003).
336 2012-03-18 Eli Zaretskii <eliz@gnu.org>
338 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
339 that is not from display property, accept the row as a "cursor
340 row" if one of the string's character has a non-nil `cursor'
341 property. Fixes cursor positioning when there are newlines in
342 overlay strings, e.g. in icomplete.el. (Bug#11035)
344 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
346 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
348 2012-03-12 Chong Yidong <cyd@gnu.org>
350 * eval.c (inhibit_lisp_code): Rename from
351 inhibit_window_configuration_change_hook; move from window.c.
353 * xfns.c (unwind_create_frame_1, Fx_create_frame):
354 * window.c (run_window_configuration_change_hook)
355 (syms_of_window): Callers changed.
357 2012-03-11 Chong Yidong <cyd@gnu.org>
359 * keymap.c (Fkey_description): Doc fix (Bug#9700).
361 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
363 2012-03-10 Chong Yidong <cyd@gnu.org>
365 * frame.c (other_visible_frames): Don't assume the selected frame
366 is visible (Bug#10955).
368 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
370 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
372 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
374 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
375 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
378 2012-03-03 Glenn Morris <rgm@gnu.org>
380 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
382 2012-03-02 Eli Zaretskii <eliz@gnu.org>
384 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
385 position past the first glyph_row that ends at ZV. (Bug#10902)
386 (redisplay_window, next_element_from_string): Fix typos in
388 (redisplay_window): Pass to move_it_vertically the margin in
389 pixels, not in screen lines.
391 2012-03-02 Glenn Morris <rgm@gnu.org>
393 * buffer.c (buffer-list-update-hook): Doc fix.
395 2012-02-29 Eli Zaretskii <eliz@gnu.org>
397 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
398 push_it before setting up the iterator for the first overlay
399 string, even if we have an empty string loaded.
400 (next_overlay_string): If there's an empty string on the iterator
401 stack, pop the stack. (Bug#10903)
403 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
405 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
406 Suggested by Stefan Monnier in
407 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
408 * alloc.c (widen_to_Lisp_Object): New static function.
409 (mark_memory): Also mark Lisp_Objects by fetching pointer words
410 and widening them to Lisp_Objects. This would work even if
411 USE_LSB_TAG is defined and wide integers are used, which might
412 happen in a future version of Emacs.
414 2012-02-25 Chong Yidong <cyd@gnu.org>
416 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
419 * xselect.c (Fx_selection_exists_p): Doc fix.
420 (x_clipboard_manager_save_all): Print an informative message
421 before saving to clipboard manager.
423 2012-02-24 Chong Yidong <cyd@gnu.org>
425 * keyboard.c (process_special_events): Handle all X selection
426 requests in kbd_buffer, not just the next one (Bug#8869).
428 2012-02-23 Chong Yidong <cyd@gnu.org>
430 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
431 call when setting menu-bar-lines and tool-bar-lines parameters.
432 (unwind_create_frame_1): New helper function.
434 * window.c (inhibit_window_configuration_change_hook): New var.
435 (run_window_configuration_change_hook): Obey it.
436 (syms_of_window): Initialize it.
438 2012-02-22 Chong Yidong <cyd@gnu.org>
440 * xterm.c (x_draw_image_relief): Add missing type check for
441 Vtool_bar_button_margin (Bug#10743).
443 2012-02-21 Chong Yidong <cyd@gnu.org>
445 * fileio.c (Vfile_name_handler_alist): Doc fix.
447 * buffer.c (Fget_file_buffer): Protect against invalid file
448 handler return value.
450 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
452 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
453 when computing $valmask.
455 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
456 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
457 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
458 It's useless in that case, and it can cause problems on hosts
459 that allocate halves of EMACS_INT values separately.
460 Reported by Dan Horák. Diagnosed by Andreas Schwab in
461 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
462 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
463 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
464 it avoids undefined behavior on hosts where shifting right by more
465 than the word width has undefined behavior.
467 2012-02-19 Chong Yidong <cyd@gnu.org>
469 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
470 (Funhandled_file_name_directory, Ffile_name_as_directory)
471 (Fdirectory_file_name, Fexpand_file_name)
472 (Fsubstitute_in_file_name): Protect against invalid file handler
473 return values (Bug#10845).
475 2012-02-18 Eli Zaretskii <eliz@gnu.org>
477 * .gdbinit (pitx): Fix incorrect references to fields of the
480 2012-02-17 Chong Yidong <cyd@gnu.org>
482 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
484 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
486 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
487 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
489 2012-02-15 Chong Yidong <cyd@gnu.org>
491 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
492 marked as special. Also, starting docstrings with * is obsolete.
494 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
496 * gnutls.c (emacs_gnutls_write): Fix last change.
498 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
500 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
503 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
505 * keymap.c (Fsingle_key_description): Handle char ranges.
507 2012-02-12 Chong Yidong <cyd@gnu.org>
509 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
510 as that creates a dangerous corner case.
512 * window.c (Fdelete_window_internal): Invalidate the mouse
513 highlight (Bug#9904).
515 2012-02-12 Glenn Morris <rgm@gnu.org>
517 * xselect.c (Fx_own_selection_internal)
518 (Fx_get_selection_internal, Fx_disown_selection_internal)
519 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
520 * nsselect.m (Fx_own_selection_internal)
521 (Fx_disown_selection_internal, Fx_selection_exists_p)
522 (Fx_selection_owner_p, Fx_get_selection_internal):
523 Sync docs and argument specs with the xselect.c versions.
525 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
527 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
529 2012-02-11 Eli Zaretskii <eliz@gnu.org>
531 * w32select.c (Fx_selection_exists_p): Sync doc string and
532 argument list with xselect.c. (Bug#10783)
534 * w16select.c (Fx_selection_exists_p): Sync doc string and
535 argument list with xselect.c. (Bug#10783)
537 2012-02-10 Glenn Morris <rgm@gnu.org>
539 * fns.c (Fsecure_hash): Doc fix.
541 2012-02-09 Kenichi Handa <handa@m17n.org>
543 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
545 2012-02-07 Chong Yidong <cyd@gnu.org>
547 * buffer.c (Fbuffer_local_variables)
548 (buffer_lisp_local_variables): Handle unbound vars correctly;
549 don't let Qunbound leak into Lisp.
551 2012-02-07 Glenn Morris <rgm@gnu.org>
553 * image.c (Fimagemagick_types): Doc fix.
555 * image.c (imagemagick-render-type): Change it from a lisp object
556 to an integer. Move the doc here from the lisp manual.
557 Treat all values not equal to 0 the same.
559 2012-02-06 Chong Yidong <cyd@gnu.org>
561 * doc.c (store_function_docstring): Avoid applying docstring of
562 alias to base function (Bug#2603).
564 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
566 * .gdbinit (pp1, pv1): Remove redundant defines.
569 2012-02-04 Chong Yidong <cyd@gnu.org>
571 * nsterm.m: Declare a global (Bug#10694).
573 2012-02-04 Eli Zaretskii <eliz@gnu.org>
575 * w32.c (get_emacs_configuration_options):
576 Include --enable-checking, if specified, in the return value.
578 2012-02-04 Martin Rudalics <rudalics@gmx.at>
580 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
581 after rounding frame sizes. (Bug#9723)
583 2012-02-04 Eli Zaretskii <eliz@gnu.org>
585 * keyboard.c (adjust_point_for_property): Don't position point
586 before BEGV. (Bug#10696)
588 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
590 Handle overflow when computing char display width (Bug#9496).
591 * character.c (char_width): Return EMACS_INT, not int.
592 (char_width, c_string_width): Check for overflow when
593 computing the width; this is possible now that individual
594 characters can have unbounded width. Problem introduced
595 by merge from Emacs 23 on 2012-01-19.
597 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
599 * dbusbind.c (Fdbus_register_method): Mention the return value
600 :ignore in the docstring.
602 2012-02-02 Glenn Morris <rgm@gnu.org>
604 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
606 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
607 Unconditionally set to t. (Bug#10673)
608 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
609 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
610 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
612 2012-02-02 Kenichi Handa <handa@m17n.org>
614 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
615 0, do not call append_composite_glyph.
617 2012-02-02 Kenichi Handa <handa@m17n.org>
619 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
621 (x_produce_glyphs): If the component of a composition is a null
622 string, set it->pixel_width to 1 to avoid zero-width glyph.
624 2012-02-01 Eli Zaretskii <eliz@gnu.org>
626 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
627 first 2 arguments are identical. This makes inserting large
628 output from a subprocess an order of magnitude faster on
629 MS-Windows, where all sbrk'ed memory is always contiguous.
631 2012-01-31 Glenn Morris <rgm@gnu.org>
633 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
634 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
635 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
637 2012-01-29 Glenn Morris <rgm@gnu.org>
639 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
641 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
643 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
645 2012-01-28 Chong Yidong <cyd@gnu.org>
647 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
649 2012-01-26 Chong Yidong <cyd@gnu.org>
651 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
653 * search.c (Fsearch_forward, Fsearch_backward): Document negative
654 repeat counts (Bug#10507).
656 2012-01-26 Glenn Morris <rgm@gnu.org>
658 * lread.c (syms_of_lread): Doc fix.
660 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
662 * coding.c (encode_designation_at_bol): Change return value to
665 2012-01-25 Chong Yidong <cyd@gnu.org>
667 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
669 2012-01-21 Chong Yidong <cyd@gnu.org>
671 * floatfns.c (Fcopysign): Make the second argument non-optional,
672 since nil is not allowed anyway.
674 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
676 * process.c (read_process_output): Use p instead of XPROCESS (proc).
677 (send_process): Likewise.
679 2012-01-19 Martin Rudalics <rudalics@gmx.at>
681 * window.c (save_window_save, Fcurrent_window_configuration)
682 (Vwindow_persistent_parameters): Do not use Qstate.
685 2012-01-19 Kenichi Handa <handa@m17n.org>
687 * character.c (char_width): New function.
688 (Fchar_width, c_string_width, lisp_string_width):
689 Use char_width (Bug#9496).
691 2012-01-16 Martin Rudalics <rudalics@gmx.at>
693 * window.c (Vwindow_persistent_parameters): New variable.
694 (Fset_window_configuration, save_window_save): Handle persistent
697 2012-01-14 Eli Zaretskii <eliz@gnu.org>
699 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
700 thrashing the stack of the thread. (Bug#9087)
702 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
704 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
706 2012-01-11 Eli Zaretskii <eliz@gnu.org>
708 * xdisp.c (rows_from_pos_range): Handle the case where the
709 highlight ends on a newline. (Bug#10464)
710 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
711 he end column for display of highlight that ends on a newline
714 2012-01-11 Glenn Morris <rgm@gnu.org>
716 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
717 from load-path also when installation-directory is nil. (Bug#10208)
719 2012-01-10 Glenn Morris <rgm@gnu.org>
721 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
723 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
724 Update template values to be closer to their typical values these days.
726 2012-01-09 Eli Zaretskii <eliz@gnu.org>
728 * xdisp.c (rows_from_pos_range): Accept additional argument
729 DISP_STRING, and accept any glyph in a row whose object is that
730 string as eligible for mouse highlight. Fixes mouse highlight of
731 display strings from overlays. (Bug#10464)
733 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
735 emacs: fix an auto-save permissions race condition (Bug#10400)
736 * fileio.c (auto_saving_dir_umask): New static var.
737 (Fmake_directory_internal): Use it.
738 (do_auto_save_make_dir): Set it, instead of invoking chmod after
739 creating the directory. The old code temporarily assigns
740 too-generous permissions to the directory.
741 (do_auto_save_eh): Clear it.
742 (Fdo_auto_save): Catch all errors, not just file errors, so
743 that the var is always cleared.
745 2012-01-07 Eli Zaretskii <eliz@gnu.org>
747 * search.c (scan_buffer): Pass character positions to
748 know_region_cache, not byte positions. (Bug#6540)
750 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
752 * w32.c (sys_rename): Report EXDEV when rename of a directory
753 fails because the target is on another logical disk. (Bug#10284)
755 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
757 * xterm.c (x_embed_request_focus): New function.
759 * xterm.h: Add prototype.
761 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
763 2012-01-05 Glenn Morris <rgm@gnu.org>
765 * emacs.c (emacs_copyright): Update short copyright year to 2012.
767 2012-01-01 Eli Zaretskii <eliz@gnu.org>
769 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
770 Load gnutls_transport_set_lowat only if GnuTLS version is below
772 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
773 GnuTLS versions below 2.11.1.
775 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
777 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
778 to the doc string advising against its use for altering the way
779 windows are scrolled.
781 2011-12-28 Kenichi Handa <handa@m17n.org>
783 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
784 coding-system ASCII compatible only when it does not produce BOM
785 on encoding (Bug#10383).
787 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
789 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
791 (create_and_show_popup_menu): Always use menu_position_func for
794 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
796 * callint.c (Fcall_interactively): Don't truncate prompt string.
798 2011-12-23 Eli Zaretskii <eliz@gnu.org>
800 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
801 property that ends at ZV, so that the bidi iteration could be
802 resumed from there (after widening). (Bug#10360)
804 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
806 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
808 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
810 * nsterm.m (x_free_frame_resources):
811 Release f->output_data.ns->miniimage.
812 (ns_index_color): Fix indentation. Do not retain
813 color_table->colors[i].
815 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
818 * nsfns.m (x_set_background_color): Assign return value from
819 ns_index_color to face-background instead of NSColor*.
820 (ns_implicitly_set_icon_type): Fix indentation.
821 Change assignment in for loop to comparison.
823 * emacs.c (ns_pool): New variable.
824 (main): Assign ns_pool.
825 (Fkill_emacs): Call ns_release_autorelease_pool.
827 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
828 autorelease fdesc, release fdAttrs and tdict.
829 (ns_get_covering_families): Release charset.
830 (ns_findfonts): Release NSFontDescriptor created with new.
831 (ns_uni_to_glyphs): Fix indentation.
832 (setString): Release attrStr before assigning new value.
834 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
836 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
838 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
839 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
841 2011-12-18 David Reitter <reitter@cmu.edu>
843 * nsterm.m (ns_term_init): Subscribe for notifications
844 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
845 to method trackingNotification in EmacsMenu.
847 * nsmenu.m (trackingMenu): New variable.
848 (trackingNotification): New method (from Aquamacs).
849 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
850 from Aquamacs (Bug#7030).
852 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
854 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
855 (symbol_to_nsstring): Fix indentation.
856 (ns_symbol_to_pb): New function.
857 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
858 (Fns_rotate_cut_buffers_internal): Remove.
859 (Fns_store_selection_internal): Rename from
860 Fns_store_cut_buffer_internal.
861 (ns_get_foreign_selection, Fx_own_selection_internal)
862 (Fx_disown_selection_internal, Fx_selection_exists_p)
863 (Fns_get_selection_internal, Fns_store_selection_internal):
864 Use ns_symbol_to_pb and check if return value is nil.
865 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
866 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
867 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
868 renamed to Sns_store_selection_internal.
869 (ns_handle_selection_request): Move code to Fx_own_selection_internal
870 and remove this function.
871 (ns_handle_selection_clear): Remove, never used.
872 (Fx_own_selection_internal): Move code from ns_handle_selection_request
875 2011-12-17 Ken Brown <kbrown@cornell.edu>
877 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
878 GID is unknown (Bug#10257).
880 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
882 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
883 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
884 which caused a build failure on GNU/Linux IA-64. This problem was
885 introduced by my 2011-10-07 patch.
887 2011-12-15 Juri Linkov <juri@jurta.org>
889 * image.c (imagemagick_error): New function. (Bug#10112)
890 (imagemagick_load_image): Comment out `MagickSetResolution' call.
891 Use `imagemagick_error' where ImageMagick functions return
893 (Fimagemagick_types): Add `Fnreverse' to return the list in the
896 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
898 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
899 fill background (Bug#8992).
901 2011-12-13 Martin Rudalics <rudalics@gmx.at>
903 * window.c (Vwindow_combination_resize)
904 (Vwindow_combination_limit): Use t instead of non-nil in
906 (Vrecenter_redisplay): Add first sentence of doc-string on
908 (Frecenter): Fix doc-string typo.
910 2011-12-11 Kenichi Handa <handa@m17n.org>
912 * coding.c (Funencodable_char_position): Pay attention to the
913 buffer text relocation (Bug#9389).
915 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
917 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
918 gtk_init (Bug#10100).
920 2011-12-10 Eli Zaretskii <eliz@gnu.org>
922 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
923 IT->string is nil. (Bug#10263)
925 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
927 * nsterm.h (x_free_frame_resources): Declare.
929 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
930 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
932 * nsterm.h (ns_get_defaults_value): Declare.
934 * nsterm.m (ns_default): Call ns_get_defaults_value.
936 2011-12-09 Eli Zaretskii <eliz@gnu.org>
938 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
941 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
943 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
944 that where the value of an _OBJC_* symbol points to is in the .bss
947 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
949 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
950 after the loop to call ccl_driver at least once (Bug#8619).
952 2011-12-08 Kenichi Handa <handa@m17n.org>
954 * ftfont.c (get_adstyle_property): Fix previous change
957 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
959 * w32.c (init_environment): If no_site_lisp, remove site-lisp
960 dirs from the default value of EMACSLOADPATH (bug#10208).
962 2011-12-07 Glenn Morris <rgm@gnu.org>
964 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
965 installation and source directories as well. (Bug#10208)
967 2011-12-06 Chong Yidong <cyd@gnu.org>
969 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
971 2011-12-06 Glenn Morris <rgm@gnu.org>
973 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
974 as an error, not just -1. (Bug#10217)
976 2011-12-05 Chong Yidong <cyd@gnu.org>
978 * keyboard.c (process_special_events): New function.
979 (swallow_events, Finput_pending_p): Use it (Bug#10195).
981 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
983 * coding.c (encode_designation_at_bol): Don't use uninitialized
984 local variable (Bug#9318).
986 2011-12-05 Kenichi Handa <handa@m17n.org>
988 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
989 return Qnil (Bug#8046, Bug#10193).
991 2011-12-05 Kenichi Handa <handa@m17n.org>
993 * coding.c (encode_designation_at_bol): New args charbuf_end and
994 dst. Return the number of produced bytes. Callers changed.
995 (coding_set_source): Return how many bytes coding->source was
997 (coding_set_destination): Return how many bytes
998 coding->destination was relocated.
999 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1000 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1002 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1004 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1005 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1008 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1010 The following changes are to fix Bug#9318.
1012 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1013 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1014 (encode_coding_iso_2022, encode_coding_sjis)
1015 (encode_coding_big5, encode_coding_charset): Use the above macros.
1017 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1019 * lisp.h (process_quit_flag): Fix external declaration.
1021 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1023 Don't macro-inline non-performance-critical code.
1024 * eval.c (process_quit_flag): New function.
1025 * lisp.h (QUIT): Use it.
1027 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1029 * nsfns.m (get_geometry_from_preferences): New function.
1030 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1032 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1034 * emacs.c (Qkill_emacs): Define.
1035 (syms_of_emacs): Initialize it.
1036 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1037 Qquit_flag to `kill-emacs' instead.
1038 (quit_throw_to_read_char): Add parameter `from_signal'.
1039 All callers changed. Call Fkill_emacs if requested and safe.
1040 * lisp.h (QUIT): Call Fkill_emacs if requested.
1042 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1044 * widget.c (update_wm_hints): Return if wmshell is null.
1045 (widget_update_wm_size_hints): New function.
1047 * widget.h (widget_update_wm_size_hints): Declare.
1049 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1050 widget_update_wm_size_hints (Bug#10104).
1052 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1054 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1055 before a newline, prepare the bidi iterator for consuming the
1056 newline, and keep the current paragraph direction. (Bug#10183)
1057 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1059 2011-12-02 Juri Linkov <juri@jurta.org>
1061 * search.c (Fword_search_regexp): New Lisp function created from
1062 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1063 (Fword_search_backward, Fword_search_forward)
1064 (Fword_search_backward_lax, Fword_search_forward_lax):
1065 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1066 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1068 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1070 * fileio.c (Finsert_file_contents): Move after-change-function call
1071 to before the "handled:" label, since all "goto handled" appear in
1072 cases where the *-change-functions have already been properly called
1075 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1077 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1078 waiting for input. (Bug#10169)
1080 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1082 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1083 verifies glyph row's hash code--we have just reallocated the
1084 glyphs, so their contents can be complete garbage. (Bug#10164)
1086 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1088 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1090 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1092 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1093 attributes are tested _before_ calling verify_row_hash, to protect
1094 against GCC re-ordering of the tests. (Bug#10164)
1096 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1098 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1100 * xterm.c (handle_one_xevent): Only set async_visible and friends
1101 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1102 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1103 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1105 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1107 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1108 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1109 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1110 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1111 All uses changed to use GCPRO1 etc.
1112 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1113 Revert to old implementation (i.e., before 2011-03-11).
1115 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1117 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1118 of scroll runs so as to avoid assigning disabled bogus rows and
1119 unnecessary graphics copy operations.
1121 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1123 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1124 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1125 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1126 (malloc, free, realloc, calloc): Redirect to e_* only when
1129 * lisp.h (GCTYPEBITS): Move before first use.
1130 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1131 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1132 this macro definition.
1134 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1137 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1139 * gtkutil.c (xg_create_frame_widgets):
1140 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1141 present with Gtk+ 2.0.
1143 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1145 * fileio.c (Finsert_file_contents): Undo previous change; see
1146 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1148 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1150 Rename locals to avoid shadowing.
1151 * fileio.c (Finsert_file_contents):
1152 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1153 * process.c (wait_reading_process_output):
1154 Rename inner 'proc' to 'p' to avoid shadowing.
1155 Indent for consistency with usual Emacs style.
1157 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1159 * xdisp.c (redisplay_window): If cursor row is not fully visible
1160 after recentering, and scroll-conservatively is set to a large
1161 number, scroll window by a few more lines to make the cursor fully
1162 visible and out of scroll-margin. (Bug#10105)
1163 (start_display): Don't move to the next line if the display should
1164 start at a newline that is part of a display vector or an overlay
1167 2011-11-24 Juri Linkov <juri@jurta.org>
1169 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1170 after the `MagickPingImage' call. (Bug#10112)
1172 2011-11-23 Chong Yidong <cyd@gnu.org>
1174 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1176 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1178 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1179 making another buffer current. (Bug#10114)
1181 2011-11-23 Glenn Morris <rgm@gnu.org>
1183 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1185 2011-11-23 Chong Yidong <cyd@gnu.org>
1187 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1188 using it (Bug#5984).
1190 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1192 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1193 and header-lines, as they don't have one computed for them.
1196 * .gdbinit (prow): Make displayed values more self-explaining.
1197 Add row's hash code.
1199 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1201 * process.c (wait_reading_process_output): Fix asynchrounous
1202 GnuTLS socket handling on some versions of the GnuTLS library.
1203 (wait_reading_process_output): Add comment and URL.
1205 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1207 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1209 2011-11-21 Chong Yidong <cyd@gnu.org>
1211 * window.c (Fnext_window, Fprevious_window): Doc fix.
1213 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1215 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1217 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1219 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1221 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1223 * window.c (Fset_window_combination_limit): Rename argument
1225 (Vwindow_combination_limit): Remove "status" from doc-string.
1227 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1229 * m/ibms390.h: Remove.
1230 * m/ibms390x.h: Don't include "ibms390.h".
1232 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1234 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1235 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1237 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1239 * casetab.c (Fset_case_table):
1240 * charset.c (Fcharset_after): Fix typos.
1242 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1244 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1245 Otherwise, valgrind does not work on some platforms.
1246 Problem reported by Andreas Schwab in
1247 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1248 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1249 is set, removing the need for VIRT_ADDRESS_VARIES.
1250 (PURE_P): Use a more-efficient implementation that needs just one
1251 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1252 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1253 to 4 (xorl, subq, cmpq, setbe).
1254 * alloc.c (pure): Always extern now, since that's the
1255 VIRT_ADDR_VARIES behavior.
1256 (PURE_POINTER_P): Use a single comparison, not two, for
1257 consistency with the new puresize.h.
1258 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1259 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1260 Remove VIRT_ADDR_VARIES no longer needed.
1262 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1264 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1265 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1266 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1267 behave as if the cursor position were at the window margin.
1269 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1270 and the cursor position is out of bounds, behave as if the cursor
1271 position were at the window margin. (Bug#10075)
1273 2011-11-18 Chong Yidong <cyd@gnu.org>
1275 * window.c (Fwindow_combination_limit): Make first argument
1276 non-optional, since it is meaningless for live windows like the
1279 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1281 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1283 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1285 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1286 (graft_intervals_into_buffer): Simplify.
1288 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1290 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1291 hash values of the two rows.
1292 (copy_row_except_pointers): Preserve the used[] arrays and the
1293 hash values of the two rows. (Bug#10035)
1294 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1296 * xdisp.c (row_hash): New function, body extracted from
1297 compute_line_metrics.
1298 (compute_line_metrics): Call row_hash, instead of computing the
1301 * dispnew.c (verify_row_hash): Call row_hash for computing the
1302 hash code of a row, instead of duplicating code from xdisp.c.
1304 * dispextern.h (row_hash): Add prototype.
1306 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1308 * frame.c (delete_frame): Don't delete the terminal when the last
1309 X frame is closed if emacs is built with GTK toolkit.
1311 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1313 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1315 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1317 * window.c (Vwindow_splits): Rename to
1318 Vwindow_combination_resize. Suggested by Juri Linkov.
1319 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1322 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1324 * nsfns.m (Fns_font_name):
1325 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1327 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1329 * window.h (window): Rename slot "nest" to "combination_limit".
1330 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1331 (Fset_window_nest): Rename to Fset_window_combination_limit.
1332 (Vwindow_nest): Rename to Vwindow_combination_limit.
1333 (recombine_windows, make_parent_window, make_window)
1334 (Fsplit_window_internal, saved_window)
1335 (Fset_window_configuration, save_window_save): Rename all
1336 occurrences of window_nest to window_combination_limit.
1338 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1340 * image.c (imagemagick_load_image): Fix typo.
1342 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1344 * xdisp.c (display_line): Move the call to
1345 highlight_trailing_whitespace before the call to
1346 compute_line_metrics, since the latter needs to see the final
1347 faces of all the glyphs to compute ROW's hash value.
1348 Fixes assertion violations in row_equal_p. (Bug#10035)
1350 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1352 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1353 just return (bug#10044).
1355 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1357 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1358 with user-defined heap size. Bump the default size of the temacs
1359 heap to 27MB, to avoid memory warning when running temacs.
1360 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1362 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1363 current_matrix and desired_matrix. (Bug#9990)
1364 (verify_row_hash) [XASSERTS]: New function.
1365 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1366 that the hash value of glyph rows is correct.
1368 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1370 * window.h (window): Remove splits slot.
1371 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1372 (Fdelete_other_windows_internal, make_parent_window)
1373 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1374 (Fset_window_configuration, save_window_save): Don't deal with
1375 split status of windows.
1376 (saved_window): Remove splits slot.
1377 (Vwindow_splits): Rewrite doc-string.
1379 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1381 * xfns.c (unwind_create_frame):
1382 * nsfns.m (unwind_create_frame):
1383 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1384 Vframe_list (Bug#9999).
1386 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1388 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1390 2011-11-11 Kenichi Handa <handa@m17n.org>
1392 * callproc.c (Fcall_process): Set the member dst_multibyte of
1395 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1397 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1398 avoid a crash (bug#9496).
1400 2011-11-09 Chong Yidong <cyd@gnu.org>
1402 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1403 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1405 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1407 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1409 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1411 Avoid some portability problems by eschewing 'extern inline' functions.
1412 The trivial performance wins aren't worth the portability hassles; see
1413 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1415 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1416 (window_box_width, window_box_left, window_box_left_offset)
1417 (window_box_right, window_box_right_offset): Undo previous change,
1418 by removing the "extern"s.
1419 * intervals.c (adjust_intervals_for_insertion)
1420 (adjust_intervals_for_deletion): Undo previous change,
1421 making these static again.
1422 (offset_intervals, temp_set_point_both, temp_set_point)
1423 (copy_intervals_to_string): No longer inline.
1424 * xdisp.c (window_text_bottom_y, window_box_width)
1425 (window_box_height, window_box_left_offset)
1426 (window_box_right_offset, window_box_left, window_box_right)
1427 (window_box): No longer inline.
1429 2011-11-08 Chong Yidong <cyd@gnu.org>
1431 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1432 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1433 Signal an error if not a live window.
1434 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1435 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1437 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1439 * lisp.h (syms_of_abbrev): Remove declaration.
1440 Reported by CHENG Gao <chenggao@royau.me>.
1442 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1444 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1445 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1446 of temacs in GUI mode.
1448 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1450 * window.h: Declare delete_all_child_windows instead of
1451 delete_all_subwindows.
1452 * window.c (Fwindow_nest, Fset_window_nest)
1453 (Fset_window_new_total, Fset_window_new_normal)
1454 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1455 (delete_all_subwindows): Rename to delete_all_child_windows.
1456 (Fdelete_other_windows_internal, Fset_window_configuration):
1457 Call delete_all_child_windows instead of delete_all_subwindows.
1458 * frame.c (delete_frame): Call delete_all_child_windows instead
1459 of delete_all_subwindows.
1461 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1463 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1464 This is also needed for porting to any host where GC_MARK_STACK is
1465 not GC_MAKE_GCPROS_NOOPS.
1466 (which_symbols): Use it.
1468 2011-11-07 Kenichi Handa <handa@m17n.org>
1470 * coding.c (coding_set_destination): Check coding->src_pos only
1471 when coding->src_object is a buffer (bug#9910).
1473 * process.c (send_process): Set the member src_multibyte of coding
1474 to 0 (bug#9911) when sending a unibyte text.
1476 * callproc.c (Fcall_process): Set the member src_multibyte of
1477 process_coding to 0 (bug#9912).
1479 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1481 * xmenu.c (cleanup_widget_value_tree): New function.
1482 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1483 calling free_menubar_widget_value_tree directly (Bug#9830).
1485 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1487 Fix some portability problems with 'inline'.
1488 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1489 (window_box_width, window_box_left, window_box_left_offset)
1490 (window_box_right, window_box_right_offset): Declare extern.
1491 Otherwise, these inline functions do not conform to C99 and
1492 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1493 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1494 * intervals.c (adjust_intervals_for_insertion)
1495 (adjust_intervals_for_deletion): Now extern, because otherwise the
1496 extern inline functions 'offset_intervals' couldn't refer to it.
1497 (static_offset_intervals): Remove.
1498 (offset_intervals): Rewrite using the old contents of
1499 static_offset_intervals. The old version didn't conform to C99
1500 because an extern inline function contained a reference to an
1501 identifier with static linkage.
1503 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1505 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1508 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1510 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1511 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1512 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1513 return Qleft_to_right.
1515 2011-11-06 Chong Yidong <cyd@gnu.org>
1517 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1518 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1519 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1520 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1521 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1522 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1523 (Fwindow_vscroll): Doc fix.
1524 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1525 argument, since it makes no sense to pass a live window and for
1526 consistency with window-child.
1528 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1530 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1533 2011-11-05 Jason Rumney <jasonr@gnu.org>
1535 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1536 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1538 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1539 bitwise arithmetic preventing use of unicode-sip and non-truetype
1542 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1544 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1547 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1548 initialization code to keep similarity to xfns.c after changes
1551 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1553 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1554 (unwind_create_frame): New function (Bug#9943).
1555 (Fx_create_frame): Restructure code to be more similar to the one in
1556 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1557 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1558 Move terminal->reference_count++ just before making the frame official
1561 * nsterm.m (x_free_frame_resources): New function.
1562 (x_destroy_window): Move code to x_free_frame_resources.
1564 * xfns.c (unwind_create_frame): Fix comment.
1565 (Fx_create_frame, x_create_tip_frame):
1566 Move terminal->reference_count++ just before making the frame
1567 official. Move initialization of image_cache_refcount and
1568 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1570 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1572 Support MSVC build with newer versions of Visual Studio.
1573 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1574 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1577 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1578 which are not supported by MSVC.
1579 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1580 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1582 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1584 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1586 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1588 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1590 Support MSVC build with newer versions of Visual Studio.
1591 * w32.c: Don't include w32api.h for MSVC.
1592 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1594 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1595 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1596 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1597 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1599 (alloca) [_MSC_VER]: Define to _alloca.
1601 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1603 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1605 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1607 * xdisp.c (note_mouse_highlight): If either of
1608 previous/next-single-property-change returns nil, treat that as
1609 the beginning or the end of the buffer. (Bug#9955)
1611 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1613 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1614 label is not null (Bug#9951).
1615 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1618 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1620 * window.c (Fwindow_body_size): Mention in the doc string that the
1621 return value is in frame's canonical units. (Bug#9949)
1623 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1625 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1627 * w32fns.c (unwind_create_frame): If needed, free the glyph
1628 matrices of the partially constructed frame. (Bug#9943)
1629 * xfns.c (unwind_create_frame): Likewise.
1631 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1633 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1634 Don't stop backward scan on the continuation glyph, even though
1635 its CHARPOS is positive.
1636 (mouse_face_from_buffer_pos, note_mouse_highlight):
1637 Rename cover_string to disp_string.
1639 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1641 * window.c (temp_output_buffer_show): Don't use
1642 Vtemp_buffer_show_specifiers.
1643 (Vtemp_buffer_show_specifiers): Remove unused variable.
1645 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1647 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1648 past the beginning of the current glyph matrix.
1650 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1652 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1653 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1654 HAVE_GTK3 (Bug#9869).
1656 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1657 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1659 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1661 * xterm.c: Declare x_handle_net_wm_state to return int.
1662 (handle_one_xevent): Check if we are iconified but don't have
1663 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1664 (get_current_wm_state): Return non-zero if not hidden,
1665 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1666 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1667 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1668 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1670 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1672 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1673 so that this new function doesn't get optimized away by a
1674 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1676 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1678 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1680 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1682 Fix the `xbytecode' command.
1683 * .gdbinit (xprintbytestr): New command.
1684 (xwhichsymbols): Rename from `which'; all callers changed.
1685 (xbytecode): Print the byte-code string as well.
1687 2011-10-29 Kim Storm <storm@cua.dk>
1689 * alloc.c (which_symbols): New function.
1691 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1693 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1696 2011-10-29 Glenn Morris <rgm@gnu.org>
1698 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1699 Not clear what it was for, and it causes various bugs. (Bug#9839)
1701 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1703 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1704 possible random value that matches one of those tested as
1705 condition to clear the mouse face.
1707 2011-10-28 Chong Yidong <cyd@gnu.org>
1709 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1711 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1713 * window.c (make_window): Initialize phys_cursor_on_p.
1715 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1717 * lisp.h (struct Lisp_Symbol): Update comments.
1719 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1721 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1723 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1725 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1726 <oslsachem@gmail.com> for helping to debug this.
1728 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1729 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1730 (g_b_init_get_glyph_outline_w): New static variables.
1731 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1732 (GetGlyphOutlineW_Proc): New typedefs.
1733 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1734 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1736 (w32font_open_internal, compute_metrics):
1737 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1738 instead of calling the "wide" APIs directly.
1740 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1742 * w32.h (syms_of_w32font): Add prototype.
1744 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1746 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1747 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1748 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1749 (Fmove_to_window_line): Doc fix.
1751 2011-10-27 Chong Yidong <cyd@gnu.org>
1753 * process.c (make_process): Set gnutls_state to NULL.
1755 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1756 non-NULL, regardless of GNUTLS_INITSTAGE.
1757 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1758 an error. Set process slots as soon as we allocate them.
1760 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1762 2011-10-27 Chong Yidong <cyd@gnu.org>
1764 * gnutls.c (emacs_gnutls_deinit): New function.
1765 Deallocate credentials structures as well as calling gnutls_deinit.
1766 (Fgnutls_deinit, Fgnutls_boot): Use it.
1768 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1769 (deactivate_process): Call emacs_gnutls_deinit.
1771 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1773 * image.c (x_create_x_image_and_pixmap):
1774 * w32.c (sys_rename, w32_delayed_load):
1775 * w32font.c (fill_in_logfont):
1776 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1778 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1780 * w32fns.c (w32_default_color_map): New function,
1781 extracted from Fw32_default_color_map.
1782 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1784 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1786 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1788 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1790 * keyboard.c (test_undefined): New function (bug#9751).
1791 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1793 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1795 * sysdep.c (init_sys_modes): Fix the check for the controlling
1796 terminal (Bug#6649).
1798 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1800 * dispextern.h (struct bidi_it): New member next_en_type.
1802 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1803 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1804 current character, check also for next_en_type being WEAK_EN.
1805 (bidi_resolve_weak): Don't enter the expensive loop if the current
1806 position is before next_en_pos. Record the bidi type of the first
1807 non-ET, non-BN character we find, in addition to its position.
1808 (bidi_level_of_next_char): Invalidate next_en_type when
1809 next_en_pos is over-stepped.
1811 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1813 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1814 * editfns.c: Rewrite current-time-zone so that it invokes
1815 the equivalent of (format-time-string "%Z") to get the time zone name.
1816 This fixes a bug when the time zone name contains characters that
1817 need converting from the system time locale to Emacs internal format.
1818 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1819 that patch fixed format-time-string to do the conversion, but
1820 I forgot to fix current-time-zone.
1821 (format_time_string): New function, containing most of
1822 what Fformat_time_string used to contain.
1823 (Fformat_time_string): Rewrite in terms of format_time_string.
1824 This doesn't change this function's behavior.
1825 (current-time-zone): Rewrite to use format_time_string.
1826 This fixes the bug reported by Michael Schierl in
1827 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1828 Jason Rumney's 2007-06-07 change worked around this bug, but
1830 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1832 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1834 * xdisp.c (start_display): If the character at POS is displayed
1835 via a display vector, reset IT->current.dpvec_index to zero.
1836 (try_window_reusing_current_matrix): If a line ends in a display
1837 vector or the next line starts in a display vector, continue
1838 redrawing the window even though the character position of
1839 start_row was reached.
1842 2011-10-18 Chong Yidong <cyd@gnu.org>
1844 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1845 with nobreak-char-display too.
1847 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1849 Fix part 3 of bug#9771.
1850 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1851 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1852 non-neutral characters if the current character is a paragraph
1853 separator (a.k.a. Newline). This avoids running the same
1854 expensive loop twice, once when we consume the preceding newline
1855 and the other time when the line actually needs to be displayed.
1856 Avoid the loop when we see neutrals on the base embedding level
1857 following a character whose directionality is the same as the
1858 paragraph's. This avoids running the expensive loop when a line
1859 ends in a long sequence of neutrals, like control characters.
1860 Add assertion against STRONG_AL type. Slightly rearrange code
1861 that determines the type of a neutral given the first non-neutral
1863 (bidi_level_of_next_char): Set next_en_pos to zero when
1864 invalidating its info.
1866 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1868 * xdisp.c (push_display_prop): Determine whether to record string
1869 or buffer position by IT->string, not by IT->method. Allow
1870 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1871 (move_it_vertically_backward): Don't look for character position
1872 immediately after the newline when in a continuation line.
1875 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1877 * window.c (coordinates_in_window): Rewrite and delabelize
1878 vertical border check. (Bug#5357) (Bug#9618)
1880 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1882 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1883 errors in XSetWindowBorder (bug#9310).
1885 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1887 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1888 avoid crash when xmalloc overrun checking is enabled.
1890 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1892 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1893 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1894 cursor motion with <left> and <right> arrow keys.
1896 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1897 some callers set that themselves.
1899 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1901 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1902 display string and the previous row comes from the same string and
1903 is empty. (Bug#9739) (Bug#9738)
1905 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1907 * doc.c (get_doc_string): Encode file name (bug#9735).
1909 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1911 * bidi.c (bidi_level_of_next_char):
1912 * xdisp.c (get_visually_first_element): Remove old incorrect
1913 comments regarding the Unicode Line Separator character.
1915 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1917 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1919 * alloc.c (Fgc_status): Do not access beyond zombies array
1920 boundary if nzombies > MAX_ZOMBIES.
1921 * alloc.c (dump_zombies): Add missing format specifier.
1923 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1925 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1926 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1928 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1929 Some packages use them to denote characters with modifiers.
1931 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1933 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1934 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1935 matching a pp-number. Rename parameter var to var1.
1937 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1939 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1941 2011-10-08 Glenn Morris <rgm@gnu.org>
1943 * callint.c (Fcall_interactively): Give a more explicit error for the
1944 'c' case with a non-character input. (Bug#8479)
1946 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1948 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1950 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1951 lines that are hscrolled on the left.
1953 * dispnew.c (buffer_posn_from_coords): Account for a possible
1954 presence of header-line. (Bug#4426)
1956 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1958 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1959 Don't advertise functionality which we discourage or doesn't work.
1961 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1963 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1964 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1965 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1966 this makes Emacs dump core during garbage collection on rare
1967 occasions. sizeof is obviously inferior to offsetof here, so
1968 stick with offsetof.
1969 (GC_POINTER_ALIGNMENT): New macro.
1970 (mark_memory): Omit 3rd (offset) arg; caller changed.
1971 Don't assume EMACS_INT alignment is the same as pointer alignment.
1973 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1975 * keyboard.c (read_key_sequence_remapped): New var.
1976 (read_key_sequence): Compute remapping in the right buffer.
1977 (command_loop_1): Use read_key_sequence's remapping directly.
1979 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1981 * dired.c (file_name_completion): Don't expand file name.
1982 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1983 before checking file name handler.
1985 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1986 they've been requested explicitly (bug#9591).
1988 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1990 * keymap.c (Fsingle_key_description): Use make_specified_string
1991 instead of build_string to build string from push_key_description.
1994 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1996 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1997 This fixes a Y2038 bug on 64-bit hosts.
1998 * buffer.c (reset_buffer):
1999 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2000 (Fclear_buffer_auto_save_failure):
2001 Use 0, not -1, to represent an unset failure time, since time_t
2002 might not be signed.
2004 Remove dependency on glibc malloc internals.
2005 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2006 Move back here from lisp.h, but with their new implementations.
2007 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2008 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2009 * charset.c (charset_table_init): New static var.
2010 (syms_of_charset): Use it instead of xmalloc. This removes a
2011 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2012 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2013 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2014 Move back to alloc.c.
2015 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2016 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2018 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2020 * nsterm.m (windowDidResize): Call x_set_window_size only when
2021 ns_in_resize is true. Otherwise set pixelwidth/height and
2022 call change_frame_size (Bug#9628).
2024 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2026 Port --enable-checking=all to Fedora 14 x86-64.
2027 * charset.c (syms_of_charset): Also account for glibc malloc's
2028 internal overhead when calculating the initial malloc maximum.
2030 Port --enable-checking=all to Fedora 14 x86.
2031 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2033 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2034 (overrun_check_realloc, overrun_check_free):
2035 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2036 That way, xmalloc returns a properly-aligned pointer even if
2037 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2038 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2039 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2040 into account when calculating the initial malloc maximum.
2041 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2042 Move here from alloc.c, so that charset.c can use it too.
2043 Properly align; the old code wasn't right for common 32-bit hosts
2044 when configured with --enable-checking=all.
2045 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2046 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2048 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2050 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2053 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2055 * xdisp.c (compute_display_string_end): If there's no display
2056 string at CHARPOS, return -1.
2058 * bidi.c (bidi_fetch_char): When compute_display_string_end
2059 returns a negative value, treat the character as a normal
2060 character not covered by a display string. (Bug#9624)
2062 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2064 * lread.c (Fread_from_string): Fix typo in docstring.
2066 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2068 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2069 newline, reseat the iterator instead of bidi-iterating there one
2070 character at a time. (Bug#9610)
2071 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2072 TO_CHARPOS if the bidi iterator is at base embedding level.
2074 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2076 * lread.c (readevalloop): Use correct code for NBSP.
2077 (read1): Likewise. (Bug#9608)
2079 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2081 * dbusbind.c (Fdbus_register_signal): When service is not
2082 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2084 2011-09-25 Glenn Morris <rgm@gnu.org>
2086 * buffer.c (truncate-lines): Doc fix.
2088 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2090 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2091 (Fset_window_next_buffers): Doc fix.
2093 2011-09-24 Glenn Morris <rgm@gnu.org>
2095 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2097 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2099 Fix minor problems found by static checking.
2100 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2101 * indent.c (Fvertical_motion): Fix == vs = typo.
2103 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2105 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2106 Default value is now t. Doc fix.
2108 * indent.c (Fvertical_motion): Compute and apply the overshoot
2109 logic when moving up, not only when moving down. Fix the
2110 confusing name and values of the it_overshoot_expected variable;
2111 logic changes accordingly. (Bug#9254) (Bug#9549)
2113 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2114 CHARPOS is covered by a display string which includes newlines.
2115 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2116 is covered by a display string with embedded newlines.
2118 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2120 * dbusbind.c (Fdbus_register_signal): Add match rule to
2121 Vdbus_registered_objects_table. (Bug#9581)
2122 (Fdbus_register_method, Vdbus_registered_objects_table):
2125 2011-09-24 Jim Meyering <meyering@redhat.com>
2127 do not ignore write error for any output size
2128 The previous change was incomplete.
2129 While it makes emacs --batch detect the vast majority of stdout
2130 write failures, errors were still ignored whenever the output size is
2131 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2132 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2133 && echo FAIL: ignored write error
2134 FAIL: ignored write error
2135 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2136 && echo FAIL: ignored write error
2137 FAIL: ignored write error
2138 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2140 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2142 * emacs.c (Fkill_emacs): In noninteractive mode exit
2143 non-successfully if a write error occurred on stdout. (Bug#9574)
2145 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2147 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2150 * dispextern.h (struct it): Update the comment documenting what
2153 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2155 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2156 a display string, extend search for cursor position to end of row.
2157 (find_row_edges): If the row ends in a newline from a display
2158 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2159 Handle the case of a display string with multiple newlines.
2160 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2161 non-empty line. Fixes confusing cursor motion with arrow keys at
2162 the beginning of a line that starts with whitespace.
2164 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2166 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2169 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2171 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2174 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2176 * xdisp.c (display_line): Record maximum and minimum buffer
2177 positions even if no glyphs were produced (e.g., by a zero-width
2178 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2179 buffer positions that will be removed from the glyph row because
2181 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2182 column is beyond frame width: don't subtract 1 "pixel" when
2183 computing width of the stretch.
2184 (reseat_at_next_visible_line_start): Undo the change made on
2185 2011-09-17 that saved paragraph information and restored it after
2186 the call to `reseat'. (Bug#9545)
2188 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2190 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2191 and turn window cursor on if cleared (Bug#9415).
2193 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2195 * search.c (boyer_moore): Take unibyte characters from pattern
2196 literally. (Bug#9458)
2198 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2200 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2202 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2204 Fix minor problem found by static checking.
2205 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2206 initialized, to pacify gcc -Wuninitialized.
2208 * fileio.c: Report proper errno when syscall falls.
2209 (Finsert_file_contents): Save and restore errno,
2210 so that report_file_error outputs the correct diagnostic.
2211 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2213 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2215 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2217 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2219 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2220 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2222 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2224 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2225 about the current paragraph and restore it after the call to reseat.
2227 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2228 (bidi_find_paragraph_start): Search back for paragraph beginning
2229 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2230 (bidi_move_to_visually_next): Only trigger paragraph-related
2231 computations when the last character is a newline or at EOB, not
2232 just any NEUTRAL_B. (Bug#9470)
2234 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2235 truncated lines if point is covered by a display string. (Bug#9524)
2237 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2239 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2240 (cons_to_x_long): New function.
2241 (lisp_data_to_selection_data): Use it. Correct the test for
2242 short-versus-long data; it was negated. Break out of vector
2243 loop, for efficiency, when a long datum is discovered.
2245 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2247 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2249 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2251 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2252 GCC PR/17406) by declaring this function with external scope.
2254 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2256 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2257 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2259 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2261 * editfns.c (Fformat): Correctly handle text properties on "%%".
2263 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2265 * xterm.c (x_draw_composite_glyph_string_foreground):
2266 * w32term.c (x_draw_composite_glyph_string_foreground):
2267 * term.c (encode_terminal_code):
2268 * composite.c (composition_update_it, get_composition_id):
2269 * xdisp.c (get_next_display_element)
2270 (fill_composite_glyph_string): Add comments about special meaning
2271 of TAB characters in a composition.
2273 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2275 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2276 This occurs when processing a multibyte format.
2277 Problem reported by Wolfgang Jenker.
2279 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2281 * xdisp.c (try_cursor_movement): Only check for exact match if
2282 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2284 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2286 Remove unused external symbols.
2287 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2288 * xdisp.c (calc_pixel_width_or_height): Now static.
2289 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2290 * indent.c (check_display_width):
2291 * w32term.c: Fix comment to match code.
2292 * xterm.c, xterm.h (x_catching_errors): Remove.
2294 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2296 * xselect.c: Use signed conversions more consistently (Bug#9498).
2297 (selection_data_to_lisp_data): Assume incoming selection data are
2298 signed integers, not unsigned. This is to be consistent with
2299 outgoing selection data, which was modified to use signed integers
2300 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2301 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2302 expects long, not unsigned long.
2304 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2306 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2307 computation of loop end. Reported by Johan Bockgård
2310 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2312 * frame.c (Fother_visible_frames_p): Function deleted.
2314 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2316 * indent.c (compute_motion): Process display vector front to back
2317 rather than the other way around. (Bug#2496)
2319 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2321 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2323 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2325 * minibuf.c (Fread_from_minibuffer): Doc fix.
2327 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2329 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2330 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2332 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2334 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2335 value for non-existent files.
2337 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2339 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2340 set its "size" to -1. This will set the modtime_size field of
2341 the corresponding buffer to -1, which is what
2342 verify-visited-file-modtime expects for files that do not exist.
2345 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2347 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2349 * lisp.h: ... from here. push_key_description is no longer
2350 defined in keyboard.c, so its declaration should not be in
2351 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2352 logically belongs with push_key_description.
2354 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2356 * buffer.h: Include <sys/types.h> instead of <time.h>.
2357 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2358 Problem reported by Herbert J. Skuhra.
2360 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2362 * xml.c (parse_region): Make the parsing work for
2363 non-comment-starting XML files again (bug#9144).
2365 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2367 * image.c (gif_load): Fix calculation of bottom and right corner.
2370 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2372 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2373 redisplay in small windows.
2375 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2377 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2379 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2381 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2382 Operate on live windows only.
2384 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2386 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2388 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2390 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2391 only under bidi iteration.
2393 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2395 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2397 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2399 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2400 Without this fix, the command to link temacs failed due to an
2401 undefined symbol __builtin_isnan. This is because
2402 /usr/include/iso/math_c99.h #defines isnan(x) to
2403 __builtin_isnan(x), but the bundled gcc, which identifies itself
2404 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2406 * floatfns.c (isnan): #undef, and then #define to a clone of
2408 (Fisnan): Always define, since it's always available now.
2409 (syms_of_floatfns): Always define isnan at the Lisp level.
2411 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2413 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2415 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2417 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2418 The previous code assumed that file offsets (off_t values) fit in
2419 EMACS_INT variables, which is not true on typical 32-bit hosts.
2420 The code messed up by falsely reporting buffer overflow in cases
2421 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2422 when "big" contains more than 2**29 bytes, even though this
2423 inserts just one byte and does not overflow the buffer.
2424 (Finsert_file_contents): Store file offsets as off_t
2425 values, not as EMACS_INT values. Check for overflow when
2426 converting between EMACS_INT and off_t. When checking for
2427 buffer overflow or for overlap, take the offsets into account.
2428 Don't use EMACS_INT for small values where int suffices.
2429 When checking for overlap, fix a typo: ZV was used where
2430 ZV_BYTE was intended.
2431 (Fwrite_region): Don't assume off_t fits into 'long'.
2432 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2434 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2436 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2438 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2440 sprintf-related integer and memory overflow issues (Bug#9412).
2442 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2443 (esprintf, exprintf, evxprintf): New functions.
2444 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2445 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2446 (modify_event_symbol): Do not assume that the length of
2447 name_alist_or_stem is safe to alloca and fits in int.
2448 (Fexecute_extended_command): Likewise for function name and binding.
2449 (Frecursion_depth): Wrap around reliably on integer overflow.
2450 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2451 since some callers pass EMACS_INT values.
2452 (Fsingle_key_description): Don't crash if symbol name contains more
2453 than MAX_ALLOCA bytes.
2454 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2455 (get_minibuffer): Arg is now EMACS_INT, not int.
2456 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2457 (esprintf, exprintf, evxprintf): New decls.
2458 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2460 * dbusbind.c (signature_cat): New function.
2461 (xd_signature, Fdbus_register_signal):
2462 Do not overrun buffer; instead, report string overflow.
2464 * dispnew.c (add_window_display_history): Don't overrun buffer.
2465 Truncate instead; this is OK since it's just a log.
2467 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2468 even if the time zone offset is outlandishly large.
2469 Don't mishandle offset == INT_MIN.
2471 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2472 when creating daemon; the previous buffer-overflow check was incorrect.
2474 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2475 which has the guts of the old verror function.
2477 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2478 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2480 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2481 (font_unparse_xlfd): Don't blindly alloca long strings.
2482 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2483 fits in int, when using sprintf. Use single snprintf to count
2484 length of string rather than counting it via multiple sprintfs;
2485 that's simpler and more reliable.
2486 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2487 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2488 sprintf, in case result does not fit in int.
2490 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2491 (fontset_from_font): Print it.
2493 * frame.c (tty_frame_count): Now printmax_t, not int.
2494 (make_terminal_frame, set_term_frame_name): Print it.
2495 (x_report_frame_params): In X, window IDs are unsigned long,
2496 not signed long, so print them as unsigned.
2497 (validate_x_resource_name): Check for implausibly long names,
2498 and don't assume name length fits in 'int'.
2499 (x_get_resource_string): Don't blindly alloca invocation name;
2500 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2503 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2504 (xg_check_special_colors, xg_set_geometry):
2505 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2507 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2508 Use esprintf, not sprintf, in case result does not fit in int.
2510 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2511 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2512 it as a large positive number.
2513 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2514 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2516 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2517 in case result does not fit in int.
2519 * print.c (float_to_string): Detect width overflow more reliably.
2520 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2521 buffer overrun. Don't assume list length fits in 'int'. Treat
2522 print length of 0 as 0, not as infinity; to be consistent with other
2523 uses of print length in this function. Don't overflow print length
2524 index. Don't assume hash table size fits in 'long', or that
2525 vectorlike size fits in 'unsigned long'.
2527 * process.c (make_process): Use printmax_t, not int, to format
2528 process-name gensyms.
2530 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2532 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2533 to avoid potential buffer overrun.
2535 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2536 if X resource line is longer than 512 bytes.
2538 * xfns.c (x_window): Make sprintf buffer a bit bigger
2539 to avoid potential buffer overrun.
2541 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2543 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2545 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2547 Integer overflow fixes for scrolling, etc.
2548 Without these, Emacs silently mishandles large integers sometimes.
2549 For example, "C-u 4294967297 M-x recenter" was treated as if
2550 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2552 * xdisp.c (try_window_id): Check Emacs fixnum range before
2553 converting to 'int'.
2555 * window.c (window_scroll_line_based, Frecenter):
2556 Check that an Emacs fixnum is in range before assigning it to 'int'.
2557 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2558 values converted from Emacs fixnums.
2559 (Frecenter): Don't wrap around a line count if it is out of 'int'
2560 range; instead, treat it as an extreme value.
2561 (Fset_window_configuration, compare_window_configurations):
2562 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2564 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2565 that can exceed INT_MAX. Check that EMACS_INT value is in range
2566 before assigning it to the (possibly-narrower) index.
2567 (match_limit): Don't assume that a fixnum can fit in 'int'.
2569 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2572 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2573 (Fvertical_motion): Don't wrap around LINES values that don't fit
2574 in 'int'. Instead, treat them as extreme values. This is good
2575 enough for windows, which can't have more than INT_MAX lines anyway.
2577 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2579 * Require libxml/parser.h to avoid compilation warning.
2581 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2583 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2584 since this reportedly can destroy thread storage.
2586 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2588 * syntax.c (find_defun_start): Update all cache variables if
2589 exiting early (Bug#9401).
2591 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2593 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2595 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2596 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2597 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2599 * term.c (tty_append_glyph): New function.
2600 (produce_stretch_glyph): Static function and its prototype deleted.
2602 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2605 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2607 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2608 when checking :margin (Bug#9390).
2609 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2610 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2611 so that the name doesn't mislead. All uses changed.
2613 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2615 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2618 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2620 * xdisp.c (move_it_to): Don't bail out early when reaching
2621 position beyond to_charpos, if we are scanning backwards.
2622 (move_it_vertically_backward): When DY == 0, make sure we get to
2623 the first character in the line after the newline.
2625 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2627 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2628 (ccl_driver): Do not generate an out-of-range pointer.
2629 (Fccl_execute_on_string): Remove unnecessary check for
2630 integer overflow, noted by Stefan Monnier in
2631 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2632 Remove a FIXME that didn't need fixing.
2633 Simplify the newly-introduced buffer reallocation code.
2635 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2637 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2639 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2641 Integer and memory overflow issues (Bug#9196).
2643 * doc.c (get_doc_string): Rework so that
2644 get_doc_string_buffer_size is the actual buffer size, rather than
2645 being 1 less than the actual buffer size; this makes xpalloc more
2648 * image.c (x_allocate_bitmap_record, cache_image):
2649 * xselect.c (Fx_register_dnd_atom):
2650 Simplify previous changes by using xpalloc.
2652 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2653 since either will do and ptrdiff_t is convenient with xpalloc.
2655 * charset.c (charset_table_size)
2656 (struct charset_sort_data.priority): Now ptrdiff_t.
2657 (charset_compare): Don't overflow if priorities differ greatly.
2658 (Fsort_charsets): Don't assume list length fits in int.
2659 Check for size-calculation overflow when allocating sort data.
2660 (syms_of_charset): Allocate an initial charset table that is
2661 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2663 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2665 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2666 The actual value is always <= INT_MAX, and leaving it unsigned made
2667 overflow checking harder.
2669 * dispextern.h (struct glyph_matrix.rows_allocated)
2670 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2671 with xpalloc. The values are still always <= INT_MAX.
2673 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2675 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2676 (SAFE_NALLOCA): New macro.
2678 * region-cache.c (struct boundary.pos, find_cache_boundary)
2679 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2680 (set_cache_region, invalidate_region_cache)
2681 (revalidate_region_cache, know_region_cache, region_cache_forward)
2682 (region_cache_backward, pp_cache):
2683 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2684 so that ptrdiff_t * can be passed to xpalloc.
2685 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2686 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2687 (pp_cache): Don't assume cache_len fits in int.
2688 * region-cache.h: Adjust extern decls to match.
2690 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2691 EMACS_INT, since either will do, for xpalloc.
2693 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2694 (xnmalloc, xnrealloc, xpalloc): New functions.
2696 * bidi.c (bidi_shelve_header_size): New constant.
2697 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2698 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2700 * bidi.c (bidi_cache_shrink):
2701 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2703 Don't update size of array until after memory allocation succeeds,
2704 because xmalloc/xrealloc may not return.
2705 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2706 now that we have proper integer overflow checking.
2707 (record_overlay_string, overlay_strings): Catch overflows when
2708 calculating size of overlay_str_buf.
2710 * callproc.c (Fcall_process): Check for size overflow when
2711 calculating size of args2.
2712 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2713 Normally we prefer signed values, but sticking with ptrdiff_t would
2714 require adding more-complicated checks.
2716 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2717 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2718 Redo buffer-overflow calculations to avoid integer overflow.
2719 Add a FIXME comment where memory seems to be over-allocated.
2721 * character.c (Fstring): Check for size-calculation overflow.
2723 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2724 unnecessary integer overflow. Check for size overflow.
2725 (encode_coding_object): Don't update size until xmalloc succeeds.
2727 * composite.c (get_composition_id): Check for overflow in glyph
2728 length calculations.
2730 Integer and memory overflow fixes for display code.
2731 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2732 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2733 (scrolling_window): Check for overflow in size calculations.
2734 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2735 Don't assume glyph table len fits in int.
2736 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2737 (row_table_size): Now ptrdiff_t, not int.
2738 (scrolling_window): Avoid overflow in size calculations.
2739 Don't update size until allocation succeeds.
2740 * fns.c (concat): Check for overflow in size calculations.
2741 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2742 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2743 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2745 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2746 (get_doc_string): Check for size calculation overflow.
2747 Don't update size until allocation succeeds.
2748 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2749 EMACS_INT, where ptrdiff_t will do.
2750 (Fsubstitute_command_keys): Check for string overflow.
2752 * editfns.c (set_time_zone_rule): Don't assume environment length
2754 (message_length): Now ptrdiff_t, not int.
2755 (Fmessage_box): Don't update size until allocation succeeds.
2756 Don't assume message length fits in int.
2757 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2759 * emacs.c (main): Do not reallocate argv, since there is a null at
2760 the end that can be overwritten, and this way there's no need to
2761 worry about size-calculation overflow.
2762 (sort_args): Check for size-calculation overflow.
2764 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2766 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2768 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2769 (x_set_scroll_bar_width, x_figure_window_size):
2770 Check for integer overflow.
2771 (x_set_alpha): Do not assume XINT fits in int.
2773 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2774 This is for the members text_lines, text_cols, total_lines, total_cols,
2775 where the system imposes an 'int' limit.
2777 * fringe.c (Fdefine_fringe_bitmap):
2778 Don't update size until alloc works.
2780 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2781 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2783 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2784 Check for size-calculation overflow.
2785 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2786 do, as we prefer signed integers.
2787 (id_to_widget.max_size, id_to_widget.used)
2788 (xg_store_widget_in_map, xg_remove_widget_from_map)
2789 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2790 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2791 Use and return ptrdiff_t, not int.
2792 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2793 * gtkutil.h: Change prototypes to match the above.
2795 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2796 are duplicate now that they've been promoted to lisp.h.
2797 (x_allocate_bitmap_record, x_alloc_image_color)
2798 (make_image_cache, cache_image, xpm_load):
2799 Don't update size until alloc is done.
2800 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2802 Check for size calculation overflow.
2803 (ct_colors_allocated_max): New constant.
2804 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2807 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2808 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2809 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2810 Use ptrdiff_t, not int, to count maps.
2811 (read_char_minibuf_menu_prompt): Check for overflow in size
2812 calculations. Don't update size until allocation succeeds.
2813 Redo calculations to avoid overflow.
2814 * keyboard.h: Change prototypes to match the above.
2816 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2818 (current_minor_maps): Check for size calculation overflow.
2819 * keymap.h: Change prototypes to match the above.
2821 * lread.c (read1, init_obarray): Don't update size until alloc done.
2823 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2824 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2826 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2827 Now ptrdiff_t, not int.
2828 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2829 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2831 * process.c (Fnetwork_interface_list): Check for overflow
2832 in size calculation.
2834 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2836 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2837 overflow. Don't bother calling xmalloc when xrealloc will do.
2839 * search.c (Freplace_match): Check for size calculation overflow.
2840 (Fset_match_data): Don't assume list lengths fit in 'int'.
2842 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2843 for command line length. Do not attempt to address one before the
2844 beginning of an array, as that's not portable.
2846 * term.c (max_frame_lines): Remove; unused.
2847 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2849 (encode_terminal_code, calculate_costs): Check for size
2850 calculation overflow.
2851 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2852 table lengths and related sizes. Don't update size until alloc
2853 done. Redo calculations to avoid overflow.
2854 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2856 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2857 subtracting pointers.
2858 (gobble_line): Check for overflow more carefully. Don't update size
2861 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2862 Don't update size until alloc done.
2863 Redo size calculations to avoid overflow.
2864 Check for size calculation overflow.
2865 (main) [DEBUG]: Fix typo in invoking tparam1.
2867 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2868 Use ptrdiff_t, not int, for sizes.
2869 (store_mode_line_noprop_char): Don't update size until alloc done.
2871 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2872 Use ptrdiff_t, not int, for sizes.
2873 (Finternal_make_lisp_face, cache_face):
2874 Check for size calculation overflow.
2875 (cache_face): Treat size calculation overflows as if they were
2876 memory exhaustion (the usual treatment), rather than aborting.
2878 * xfns.c (x_encode_text, x_set_name_internal)
2879 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2880 sizes, since they can exceed INT_MAX in size. Check for size
2881 calculation overflow.
2883 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2884 (xg_select): Check for size calculation overflow.
2885 Don't update size until alloc done.
2887 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2888 as sprintf is limited to int lengths.
2890 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2891 (X_LONG_MIN): New macros.
2892 Use them to make the following changes clearer.
2893 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2894 This change doesn't affect the value now, but it may help remind
2895 future maintainers not to raise the value too much later.
2896 (SELECTION_QUANTUM): Remove, replacing with ...
2897 (selection_quantum): ... new function, which avoids overflow.
2899 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2900 assumption that selection length fits in 'int'.
2901 (x_reply_selection_request, x_handle_selection_request)
2902 (x_get_window_property, receive_incremental_selection)
2903 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2904 (lisp_data_to_selection_data, clean_local_selection_data):
2905 Use ptrdiff_t, not int, to record length of selection.
2906 (x_reply_selection_request, x_get_window_property)
2907 (receive_incremental_selection, x_property_data_to_lisp):
2908 Redo calculations to avoid overflow.
2909 (x_reply_selection_request): When sending hint, ceiling it at
2910 X_LONG_MAX rather than relying on wraparound overflow to send
2912 (x_get_window_property, receive_incremental_selection)
2913 (lisp_data_to_selection_data, x_property_data_to_lisp):
2914 Check for size-calculation overflow.
2915 (x_get_window_property, receive_incremental_selection)
2916 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2917 Don't store size until memory allocation succeeds.
2918 (x_get_window_property): Plug memory leak on memory exhaustion.
2919 Don't double-block input; malloc is safe here. Don't assume 2**34
2920 - 4 fits in unsigned long. Add an xassert to check
2921 XGetWindowProperty overflow. Be more careful about overflow
2922 calculations, and distinguish size from memory overflow better.
2923 (receive_incremental_selection): When tracing, don't assume
2924 unsigned int is less than INT_MAX.
2925 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2926 harmful) conversions of unsigned short to int.
2927 (lisp_data_to_selection_data): Don't assume that integers
2928 in the range -65535 through -1 fit in an X unsigned short.
2929 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2930 result parameters unless successful. Rely on cons_to_unsigned
2931 to report problems with elements; the old code wasn't right anyway.
2932 (x_check_property_data): Check for int overflow; we cannot use
2933 a wider type due to X limits.
2934 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2936 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2938 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2939 (x_term_init): Check for size calculation overflow.
2940 (x_color_cells): Don't store size until memory allocation succeeds.
2941 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2942 Don't assume alloca size is less than MAX_ALLOCA.
2943 (x_term_init): Don't assume length fits in int (sprintf is limited
2946 Use ptrdiff_t for composition IDs.
2947 * character.c (lisp_string_width):
2948 * composite.c (composition_table_size, n_compositions)
2949 (get_composition_id, composition_gstring_from_id):
2950 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2951 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2952 * window.c (Frecenter):
2953 Use ptrdiff_t, not int, for composition IDs.
2954 * composite.c (get_composition_id): Check for integer overflow.
2955 * composite.h: Adjust prototypes to match the above changes.
2957 Use ptrdiff_t for hash table indexes.
2958 * category.c (hash_get_category_set):
2959 * ccl.c (ccl_driver):
2960 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2961 * coding.c (coding_system_charset_list, detect_coding_system):
2962 * coding.h (struct coding_system.id):
2963 * composite.c (get_composition_id, gstring_lookup_cache):
2964 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2965 * image.c (xpm_get_color_table_h):
2966 * lisp.h (hash_lookup, hash_put):
2967 * minibuf.c (Ftest_completion):
2968 Use ptrdiff_t for hash table indexes, not int (which is too
2969 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2970 32-bit --with-wide-int hosts).
2972 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2973 Add a FIXME comment about memory leaks.
2974 (syms_of_charset): Don't assume xmalloc returns.
2976 Don't assume that stated character widths fit in int.
2977 * character.c (Fchar_width, c_string_width, lisp_string_width):
2978 * character.h (CHAR_WIDTH):
2979 * indent.c (MULTIBYTE_BYTES_WIDTH):
2980 Use sanitize_char_width to avoid undefined and/or bad behavior
2981 with outlandish widths.
2982 * character.h (sanitize_tab_width): Rename from sanitize_width,
2983 now that we have two such functions. All uses changed.
2984 (sanitize_char_width): New inline function.
2986 Don't assume that tab-width fits in int.
2987 * character.h (sanitize_width): New inline function.
2988 (SANE_TAB_WIDTH): New macro.
2989 (ASCII_CHAR_WIDTH): Use it.
2990 * indent.c (sane_tab_width): Remove. All uses replaced by
2991 SANE_TAB_WIDTH (current_buffer).
2992 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2994 * fileio.c: Integer overflow issues with file modes.
2995 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2997 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2998 Remove unreachable code.
2999 (read_hex, load_charset_map_from_file): Check for integer overflow.
3001 * xterm.c: Don't go over XClientMessageEvent limit.
3002 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3003 (x_send_scroll_bar_event): Likewise. Check that the size does not
3004 exceed limits imposed by XClientMessageEvent, as well as the usual
3005 ptrdiff_t and size_t limits.
3007 * keyboard.c: Overflow, signedness and related fixes.
3008 (make_lispy_movement): Use same integer type in forward decl
3009 that is used in the definition.
3010 (read_key_sequence, keyremap_step):
3011 Change bufsize argument back to int, undoing my 2011-03-30 change.
3012 We prefer signed types, and int is wide enough here.
3013 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3014 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3015 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3016 length, not size_t. Use ptrdiff_t for index, not int.
3017 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3018 possibility of integer overflow.
3020 Overflow, signedness and related fixes for images.
3022 * dispextern.h (struct it.stack[0].u.image.image_id)
3023 (struct_it.image_id, struct image.id, struct image_cache.size)
3024 (struct image_cache.used, struct image_cache.ref_count):
3025 * gtkutil.c (update_frame_tool_bar):
3026 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3027 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3028 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3029 * nsmenu.m (update_frame_tool_bar):
3030 * xdisp.c (calc_pixel_width_or_height):
3031 * xfns.c (image_cache_refcount):
3032 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3033 on typical 64-bit hosts.
3035 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3036 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3037 Omit unnecessary casts to int.
3038 (parse_image_spec): Check that integers fall into 'int' range
3039 when the callers expect that.
3040 (image_ascent): Redo ascent calculation to avoid int overflow.
3041 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3042 (lookup_image): Remove unnecessary tests.
3043 (xbm_image_p): Locals are now of int, not EMACS_INT,
3044 since parse_image_check makes sure they fit into int.
3045 (png_load, gif_load, svg_load_image):
3046 Prefer int to unsigned where either will do.
3047 (tiff_handler): New function, combining the cores of the
3048 old tiff_error_handler and tiff_warning_handler.
3049 This function is rewritten to use vsnprintf and thereby avoid
3050 stack buffer overflows. It uses only the features of vsnprintf
3051 that are common to both POSIX and native Microsoft.
3052 (tiff_error_handler, tiff_warning_handler): Use it.
3053 (tiff_load, gif_load, imagemagick_load_image):
3054 Don't assume :index value fits in 'int'.
3055 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3056 (imagemagick_load_image): Check that crop parameters fit into
3057 the integer types that MagickCropImage accepts. Don't assume
3058 Vimagemagick_render_type has a nonnegative value. Don't assume
3059 size_t fits in 'long'.
3060 (gs_load): Use printmax_t to print the widest integers possible.
3061 Check for integer overflow when computing image height and width.
3063 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3065 * xdisp.c (redisplay_window): Don't force window start if point
3066 will be invisible in the resulting window. (Bug#9324)
3068 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3070 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3071 the display spec is of the form `(space ...)'.
3072 (handle_display_spec): Return the value returned by
3073 handle_single_display_spec, not just 1 or zero.
3074 (handle_single_display_spec): If the display spec is of the form
3075 `(space ...)', and specifies display in the text area, return 2
3077 (try_cursor_movement): Check for the need to scroll more
3078 accurately, and prefer exact match for point under bidi.
3079 Don't advance `row' beyond the last row of the window.
3081 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3082 into disp_prop; all users changed.
3084 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3085 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3086 for the text covered by the display property.
3088 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3090 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3091 Change return value to nil.
3092 (Frecord_buffer): Delete unused function.
3094 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3096 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3097 buffers, return left-to-right.
3098 (set_cursor_from_row): Consider candidate row a win if its glyph
3099 represents a newline and point is on that newline. Fixes cursor
3100 positioning on the newline at EOL of R2L text within L2R
3101 paragraph, and vice versa.
3102 (try_cursor_movement): Check continued rows, in addition to
3103 continuation rows. Fixes unwarranted scroll when point enters a
3104 continued line of R2L text within an L2R paragraph, or vice versa.
3105 (cursor_row_p): Consider the case of point being equal to
3106 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3107 from the end of a short line to the beginning of a continued line
3108 of R2L text within L2R paragraph.
3109 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3110 composed characters.
3112 * bidi.c (bidi_check_type): Use xassert.
3113 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3116 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3118 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3121 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3123 * nsfont.m (ns_otf_to_script): Fix typo.
3125 2011-08-22 Kenichi Handa <handa@m17n.org>
3127 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3128 extra slot even if the purpose is char-code-property-table.
3130 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3132 * xdisp.c (redisplay_window): When computing centering_position,
3133 account for the height of the header line. (Bug#8874)
3135 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3136 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3137 candidate is selected by the mouse, and that candidate has a
3138 composed character under the mouse.
3140 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3141 coordinates reported by pos-visible-in-window-p for a composed
3142 character in column zero.
3144 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3146 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3148 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3150 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3151 consider it a hit if to_charpos is anywhere in the range of the
3152 composed buffer positions.
3154 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3156 * image.c (gif_load): Don't assume that each subimage has the same
3157 dimensions as the base image. Handle disposal method that is
3158 "undefined" by the gif spec (Bug#9335).
3160 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3162 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3163 (Fcondition_case): Document `debug' symbol in error handler.
3165 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3167 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3168 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3169 from an Org mode buffer to a Speedbar frame.
3171 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3172 a composition, take its buffer position from IT->cmp_it.charpos.
3173 Fixes cursor positioning at the beginning of a line that begins
3174 with a composed character.
3176 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3178 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3179 character bidirectional type, use STRONG_L instead. Fixes crashes
3180 in a buffer produced by `describe-categories'.
3182 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3183 members before the level stack, so they would be saved and
3184 restored when copying iterator state. Fixes incorrect reordering
3185 around TABs covered by display properties.
3187 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3189 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3191 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3193 * eval.c (internal_condition_case, internal_condition_case_1)
3194 (internal_condition_case_2, internal_condition_case_n):
3195 Remove unnecessary aborts (Bug#9081).
3197 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3199 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3200 has no `load' handler, try opening the file locally. (Bug#9311)
3202 2011-08-16 Ken Brown <kbrown@cornell.edu>
3204 * gmalloc.c: Expand comment.
3206 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3208 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3209 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3211 2011-08-16 Ken Brown <kbrown@cornell.edu>
3213 Fix memory allocation problems in Cygwin build (Bug#9273).
3215 * unexcw.c ( __malloc_initialized): Declare external variable.
3216 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3218 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3220 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3222 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3224 [CYGWIN] (special_realloc): New function.
3225 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3226 requests to realloc storage in the static heap.
3228 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3230 * bidi.c (bidi_initialize): Remove unused local.
3232 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3235 * biditype.h: Remove file.
3236 * makefile.w32-in ($(BLD)/bidi.$(O)):
3237 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3239 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3241 * chartab.c: Improve commentary for the uniprop_table API.
3243 * bidi.c (bidi_paragraph_init): Support zero value of
3244 bidi_ignore_explicit_marks_for_paragraph_level.
3245 (bidi_initialize): Use uniprop_table instead of including
3246 biditype.h and bidimirror.h.
3248 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3249 coordinates of the iterator when restoring from ppos_it.
3252 2011-08-14 Kenichi Handa <handa@m17n.org>
3254 * process.c (create_process): Call setup_process_coding_systems
3255 after the pid of the process is set to -1 (Bug#8162).
3257 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3259 * xdisp.c (move_it_in_display_line_to): Don't invoke
3260 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3261 ppos_it. Fixes vertical cursor motion when line beginning is
3262 covered by an image. (Bug#9296)
3264 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3266 * nsterm.h (ns_run_ascript): Declare.
3267 (NSAPP_DATA2_RUNASSCRIPT): Define.
3269 * nsfns.m (as_script, as_result, as_status): New static variables.
3270 (ns_run_ascript): New function.
3271 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3272 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3273 the event loop. Get status from as_status (Bug#7276).
3275 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3276 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3277 the event loop (Bug#7276).
3279 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3281 * gnutls.c (QCgnutls_bootprop_priority)
3282 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3283 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3284 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3285 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3286 (QCgnutls_bootprop_verify_hostname_error)
3287 (QCgnutls_bootprop_callbacks_verify): Rename from
3288 Qgnutls_bootprop_..., all uses changed.
3290 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3293 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3295 * xfaces.c (Qframe_set_background_mode): Now static.
3296 * dispextern.h (Qframe_set_background_mode): Remove decl.
3298 * process.c (Fnetwork_interface_info): Declare local only if needed.
3300 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3302 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3303 (Fnetwork_interface_list): Allocate in increments of bytes instead
3304 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3305 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3307 (struct ifflag_def): notrailers is smart on OSX.
3308 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3309 Get hardware address with getifaddrs if available.
3311 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3313 * xdisp.c (iterate_out_of_display_property): xassert that
3314 IT->position is set to within IT->object's boundaries. Break from
3315 the loop as soon as EOB is reached; avoids infloops in redisplay
3316 when IT->position is set up wrongly due to some bug.
3317 Set IT->current to match the bidi iterator unconditionally.
3318 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3319 entry. Force push_it to save on the stack the current
3320 buffer/string position, to be restored by pop_it. Fix flags in
3321 the iterator structure wrt the object coming from a display
3322 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3323 properties. (Bug#9284)
3325 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3327 * fontset.c (fontset_get_font_group): Add proper type checks.
3330 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3332 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3333 and LC_VERSION_MIN_MACOSX.
3334 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3335 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3337 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3339 * xdisp.c (forward_to_next_line_start): Allow to use the
3340 no-display-properties-and-no-overlays under bidi display.
3341 Set disp_pos in the bidi iterator to avoid searches for display
3342 properties and overlays.
3344 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3346 * editfns.c (Fset_time_zone_rule): Document relationship with the
3349 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3350 the font entity extracted from the cache (Bug#8109).
3352 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3354 * composite.c (autocmp_chars): Don't reset point. That is done by
3355 restore_point_unwind (Bug#5984).
3357 2011-08-07 Juri Linkov <juri@jurta.org>
3359 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3360 to show the arg `TIME' instead of `TIMEVAL'.
3362 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3364 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3365 display property strides EOL and includes a newline, as in
3366 longlines-mode. (Bug#9254)
3367 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3368 word-wrap under bidirectional display. (Bug#9224)
3370 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3371 is non-zero, even if the data buffer is NULL. Fixes a crash in
3372 vertical-motion with longlines-mode. (Bug#9254)
3374 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3376 * bidi.c <bidi_cache_total_alloc>: Now static.
3377 (bidi_initialize): Initialize bidi_cache_total_alloc.
3379 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3382 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3383 amount allocated this far in `bidi_cache_total_alloc'.
3384 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3385 non-zero, only free the data buffer without restoring the cache
3386 contents. All callers changed.
3388 * dispextern.h (bidi_unshelve_cache): Update prototype.
3390 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3391 (move_it_in_display_line, move_it_to)
3392 (move_it_vertically_backward, move_it_by_lines): Replace the call
3393 to xfree to an equivalent call to bidi_unshelve_cache.
3394 (move_it_in_display_line_to): Fix logic of returning
3395 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3397 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3399 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3400 came from a string character with a `cursor' property. (Bug#9229)
3402 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3404 * Makefile.in (LIB_PTHREAD): New variable.
3405 (LIBES): Add LIB_PTHREAD (Bug#9216).
3407 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3408 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3410 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3412 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3414 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3416 * xterm.c (x_find_topmost_parent): New function.
3417 (x_set_frame_alpha): Find topmost parent window with
3418 x_find_topmost_parent and set the property there also (bug#9181).
3419 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3421 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3423 * callproc.c (Fcall_process): Avoid vfork clobbering
3424 the local vars buffer, coding_systems, current_dir.
3426 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3428 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3430 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3432 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3433 so that it is not optimized away.
3435 * xdisp.c (compute_display_string_pos): Remove unused local.
3437 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3439 Fix slow cursor motion and scrolling in large buffers with
3440 selective display, like Org Mode buffers. (Bug#9218)
3442 * dispextern.h (struct bidi_it): New member disp_prop_p.
3444 * xdisp.c: Remove one-slot cache of display string positions.
3445 (compute_display_string_pos): Accept an additional argument
3446 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3447 for a display string or property. If found, set DISP_PROP_P
3450 * bidi.c (bidi_fetch_char): Accept an additional argument
3451 DISP_PROP_P, and pass it to compute_display_string_pos.
3452 Only handle text covered by a display string if DISP_PROP_P is returned
3453 non-zero. All callers of bidi_fetch_char changed.
3455 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3457 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3459 2010-12-03 Don March <don@ohspite.net>
3461 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3462 last character M-[char] is translated to ESC [char] (bug#7541).
3464 2011-08-02 Kenichi Handa <handa@m17n.org>
3466 * lisp.h (uniprop_table): Extern it.
3468 * chartab.c (uniprop_table): Make it non-static.
3470 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3472 * xdisp.c (forward_to_next_line_start): Accept additional argument
3473 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3475 (reseat_at_next_visible_line_start): Use the bidi iterator state
3476 returned by forward_to_next_line_start to restore the state of
3477 it->bidi_it after backing up to previous newline. (Bug#9212)
3479 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3481 * regex.c (re_comp): Protoize.
3482 (re_exec): Fix return type.
3483 (regexec): Fix type of `ret'. (Bug#9203)
3485 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3487 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3488 This is needed if max-image-size is a floating-point number.
3490 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3492 * print.c (print_object): Print empty symbol as ##.
3494 * lread.c (read1): Read ## as empty symbol.
3496 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3498 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3499 setting frame foreground color (Bug#9175).
3500 (x_set_background_color): Likewise.
3502 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3503 contents (Bug#9176).
3504 (EmacsTooltip -init): Remove bezels and add shadows to
3507 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3508 or scroll bar (Bug#8470).
3510 * nsfont.m (nsfont_open): Remove assignment to voffset and
3511 unnecessary vars hshink, expand, hd, full_height, min_height.
3512 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3514 * nsterm.h (nsfont_info): Remove voffset field.
3516 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3518 Implement strike-through and overline on NextStep (Bug#8863).
3520 * nsfont.m (nsfont_open): Use underline position provided by font,
3521 instead of hard-coded value of 2.
3522 (nsfont_draw): Call ns_draw_text_decoration instead.
3524 * nsterm.h: Add declaration for ns_draw_text_decoration.
3526 * nsterm.m (ns_draw_text_decoration): New function for drawing
3527 underline, overline, and strike-through.
3528 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3529 ns_draw_text_decoration. Change treatment of cursor drawing to
3530 accommodate underlining, etc.
3532 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3534 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3537 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3539 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3540 Without this fix, if a signal arrives just after memory fills up,
3541 'malloc' might be invoked reentrantly.
3543 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3544 In other words, assume that every image size is allowed, on non-X
3545 hosts. This assumption is probably wrong, but it lets Emacs compile.
3547 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3549 * regex.c (re_iswctype): Convert return values to boolean.
3551 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3553 * xdisp.c (compute_display_string_pos): Don't use cached display
3554 string position if the buffer had its restriction changed.
3557 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3559 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3561 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3563 Integer signedness and overflow and related fixes. (Bug#9079)
3565 * bidi.c: Integer size and overflow fixes.
3566 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3567 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3568 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3569 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3570 (bidi_find_other_level_edge):
3571 Use ptrdiff_t instead of EMACS_INT where either will do.
3572 This works better on 32-bit hosts configured --with-wide-int.
3573 (bidi_cache_ensure_space): Check for size-calculation overflow.
3574 Use % rather than repeated addition, for better worst-case speed.
3575 Don't set bidi_cache_size until after xrealloc returns, because it
3577 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3578 (bidi_cache_ensure_space): Also check that the bidi cache size
3579 does not exceed that of the largest Lisp string or buffer. See Eli
3580 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3582 * alloc.c (__malloc_size_t): Remove.
3583 All uses replaced by size_t. See Andreas Schwab's note
3584 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3586 * image.c: Improve checking for integer overflow.
3587 (check_image_size): Assume that f is nonnull, since
3588 it is always nonnull in practice. This is one less thing to
3589 worry about when checking for integer overflow later.
3590 (x_check_image_size): New function, which checks for integer
3591 overflow issues inside X.
3592 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3593 This removes the need for a memory_full check.
3594 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3595 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3596 (xbm_read_bitmap_data): Change locals back to 'int', since
3597 their values must fit in 'int'.
3598 (xpm_load_image, png_load, tiff_load):
3599 Invoke x_create_x_image_and_pixmap earlier,
3600 to avoid much needless work if the image is too large.
3601 (tiff_load): Treat overly large images as if
3602 x_create_x_image_and_pixmap failed, not as malloc failures.
3603 (gs_load): Use x_check_image_size.
3605 * gtkutil.c: Omit integer casts.
3606 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3607 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3609 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3611 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3612 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3613 would wrongly return t on a 64-bit host.
3615 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3616 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3617 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3618 and therefore cause GCC to emit a bogus diagnostic in some cases.
3620 * image.c: Integer signedness and overflow and related fixes.
3621 This is not an exhaustive set of fixes, but it's time to
3622 record what I've got.
3623 (lookup_pixel_color, check_image_size): Remove redundant decls.
3624 (check_image_size): Don't assume that arbitrary EMACS_INT values
3625 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3626 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3627 (tiff_load, imagemagick_load_image):
3628 Check for overflow in size calculations.
3629 (x_create_x_image_and_pixmap): Remove unnecessary test for
3630 xmalloc returning NULL; that can't happen.
3631 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3632 (xpm_color_bucket): Use better integer hashing function.
3633 (xpm_cache_color): Don't possibly over-allocate memory.
3634 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3635 (gif_memory_source):
3636 Use ptrdiff_t, not int or size_t, to record sizes.
3637 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3638 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3639 either works, as we prefer signed integers.
3640 (tiff_read_from_memory, tiff_write_from_memory):
3641 Return tsize_t, not size_t, since that's what the TIFF API wants.
3642 (tiff_read_from_memory): Don't fail simply because the read would
3643 go past EOF; instead, return a short read.
3644 (tiff_load): Omit no-longer-needed casts.
3645 (Fimagemagick_types): Don't assume size fits into 'int'.
3647 Improve hashing quality when configured --with-wide-int.
3648 * fns.c (hash_string): New function, taken from sxhash_string.
3649 Do not discard information about ASCII character case; this
3650 discarding is no longer needed.
3651 (sxhash-string): Use it. Change sig to match it. Caller changed.
3652 * lisp.h: Declare it.
3653 * lread.c (hash_string): Remove, since we now use fns.c's version.
3654 The fns.c version returns a wider integer if --with-wide-int is
3655 specified, so this should help the quality of the hashing a bit.
3657 * emacs.c: Integer overflow minor fix.
3658 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3659 Define only if GNU_LINUX.
3660 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3662 * dispnew.c: Integer signedness and overflow fixes.
3663 Remove unnecessary forward decls, that were a maintenance hassle.
3664 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3666 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3667 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3668 (prepare_desired_row, line_draw_cost):
3669 Use int, not unsigned, where either works.
3670 (save_current_matrix, restore_current_matrix):
3671 Use ptrdiff_t, not size_t, where either works.
3672 (init_display): Check for overflow more accurately, and without
3673 relying on undefined behavior.
3675 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3676 Remove, replacing with the new symbols in lisp.h. All uses changed.
3677 * fileio.c (make_temp_name):
3678 * filelock.c (lock_file_1, lock_file):
3679 * xdisp.c (message_dolog):
3680 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3681 Use pMd etc. instead.
3682 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3683 replacing the pWIDE etc. symbols removed from editfns.c.
3685 * keyboard.h (num_input_events): Now uintmax_t.
3686 This is (very slightly) less likely to mess up due to wraparound.
3689 * buffer.c: Integer signedness fixes.
3690 (alloc_buffer_text, enlarge_buffer_text):
3691 Use ptrdiff_t rather than size_t when either will do, as we prefer
3694 * alloc.c: Integer signedness and overflow fixes.
3695 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3696 (__malloc_size_t): Default to size_t, not to int.
3697 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3698 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3699 Prefer ptrdiff_t to size_t when either would do, as we prefer
3701 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3702 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3703 Now const. Initialize with values that are in range even if char
3705 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3706 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3707 These functions do the right thing with sizes > 2**32.
3708 (check_depth): Now ptrdiff_t, not int.
3709 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3710 Adjust to new way of storing sizes. Check for size overflow bugs
3712 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3713 slightly wrong anyway, as it missed one instance of
3714 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3715 (refill_memory_reserve): Omit needless cast to size_t.
3716 (mark_object_loop_halt): Mark as externally visible.
3718 * xselect.c: Integer signedness and overflow fixes.
3719 (Fx_register_dnd_atom, x_handle_dnd_message):
3720 Use ptrdiff_t, not size_t, since we prefer signed.
3721 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3722 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3723 x_dnd_atoms_size and x_dnd_atoms_length.
3725 * doprnt.c: Prefer signed to unsigned when either works.
3727 * doprnt.c (doprnt):
3729 * xdisp.c (vmessage):
3730 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3731 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3732 prefer signed arithmetic to avoid comparison confusion.
3733 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3734 but is a bit tricky.
3736 Assume freestanding C89 headers, string.h, stdlib.h.
3737 * data.c, doprnt.c, floatfns.c, print.c:
3738 Include float.h unconditionally.
3739 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3740 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3741 * regex.c: Likewise for stddef.h, string.h.
3742 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3743 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3744 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3745 (STDC_HEADERS): Remove obsolete defines.
3746 * sysdep.c: Include limits.h unconditionally.
3748 Assume support for memcmp, memcpy, memmove, memset.
3749 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3750 * regex.c (memcmp, memcpy):
3751 Remove; we assume C89 now.
3753 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3754 (__malloc_safe_bcopy): Remove; no longer needed.
3756 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3757 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3758 well either way, and we prefer signed to unsigned.
3760 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3762 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3763 closes the connection while we're reading (bug#9182).
3765 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3767 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3768 are specified (Bug#9168).
3770 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3772 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3773 Found by GCC static checking and --with-wide-int on a 32-bit host.
3775 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3777 * xdisp.c (compute_display_string_pos): Fix logic of caching
3778 previous display string position. Initialize cached_prev_pos to
3779 -1. Fixes slow-down at the beginning of a buffer.
3781 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3783 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3784 for attrs[LFACE_FONTSET_INDEX].
3786 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3788 * xml.c (parse_region): Remove unused local
3789 that was recently introduced.
3791 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3793 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3794 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3796 * xdisp.c (move_it_in_display_line_to): Record the best matching
3797 position for TO_CHARPOS while scanning the line, and restore it on
3798 exit if none of the characters scanned was an exact match.
3799 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3800 when exact match is impossible due to invisible text, and the
3801 lines are truncated.
3803 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3805 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3808 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3810 Fix a significant slow-down of cursor motion with C-n, C-p,
3811 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3812 auto-repeat under bidi redisplay in fontified buffers.
3813 * xdisp.c (compute_stop_pos_backwards): New function.
3814 (next_element_from_buffer): Call compute_stop_pos_backwards to
3815 find a suitable prev_stop when we find ourselves before
3817 (reseat): Don't look for prev_stop, as that could mean a very long
3819 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3820 <cached_disp_overlay_modiff>: Cache for last found display string
3822 (compute_display_string_pos): Return the cached position if asked
3823 about the same buffer in the same area of character positions, and
3824 the buffer wasn't changed since the time the display string
3825 position was cached.
3827 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3829 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3830 is an integer, which is important for empty lines. (Bug#9149)
3832 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3834 * frame.c (Fmodify_frame_parameters): In tty case, update the
3835 default face if necessary (Bug#4238).
3837 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3839 * editfns.c (Fstring_to_char): No need to explain what a character
3840 is in the docstring (Bug#6576).
3842 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3844 * xml.c (parse_region): Make sure we always return a tree.
3846 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3848 * xml.c (parse_region): If a document contains only comments,
3851 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3853 * xml.c (make_dom): Return comments, too.
3855 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3858 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3859 and the surrounding thread.
3860 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3861 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3862 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3864 * s/openbsd.h (BROKEN_SIGIO): Define.
3865 * unexelf.c (unexec) [__OpenBSD__]:
3866 Don't update the .mdebug section of the Alpha COFF symbol table.
3868 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3870 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3873 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3875 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3876 This fixes some race conditions on the permissions of any newly
3879 * alloc.c (valid_pointer_p): Use pipe, not open.
3880 This fixes some permissions issues when debugging.
3882 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3883 If fchown fails to set both uid and gid, try to set just gid,
3884 as that is sometimes allowed. Adjust the file's mode to eliminate
3885 setuid or setgid bits that are inappropriate if fchown fails.
3887 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3889 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3890 to compare Lisp_Objects.
3891 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3892 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3893 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3895 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3897 * lread.c (read_integer): Unread even EOF character.
3898 (read1): Likewise. Properly record start position of symbol.
3900 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3901 symbol character follows.
3903 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3905 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3906 This works around a problem with the previous change to Fcopy_file.
3907 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3908 and without this change, GCC might complain about discarding
3909 fchown's return value.
3911 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3913 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3915 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3917 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3919 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3921 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3922 it's used from the C level.
3924 * process.c: Use the same condition for POLL_FOR_INPUT in both
3925 keyboard.c and process.c (bug#1858).
3927 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3929 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3930 (Fgnutls_boot): Use it.
3932 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3934 * doc.c (Fsubstitute_command_keys): Revert last change.
3936 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3938 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3939 quotes the next character, and doesn't affect other longer
3940 sequences (bug#8935).
3942 * lread.c (syms_of_lread): Clarify that is isn't only
3943 `eval-buffer' and `eval-defun' that's affected by
3944 `lexical-binding' (bug#8460).
3946 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3948 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3949 bidi redisplay when a line includes both an image and is truncated.
3951 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3953 Fix minor problems found by static checking.
3954 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3955 (elsz): Now a signed constant, not a size_t var. We prefer signed
3956 types to unsigned, to avoid integer comparison confusion. Without
3957 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3958 "cannot optimize loop, the loop counter may overflow", a symptom
3960 * indent.c (Fvertical_motion): Mark locals as initialized.
3961 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3963 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3965 * search.c (Fre_search_backward): Mention `case-fold-search' in
3966 all the re_search_* functions (bug#8138).
3968 * keyboard.c (Fopen_dribble_file): Document when the file is
3971 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3973 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3976 Support bidi reordering of display and overlay strings.
3977 * xdisp.c (compute_display_string_pos)
3978 (compute_display_string_end): Accept additional argument STRING.
3979 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3980 (reseat_to_string): Initialize bidi_it->string.s and
3981 bidi_it->string.schars.
3982 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3983 NULL (avoids a crash in bidi_paragraph_init).
3984 Initialize itb.string.lstring.
3985 (init_iterator): Call bidi_init_it only of a valid
3986 buffer position was specified. Initialize paragraph_embedding to
3988 (reseat_to_string): Initialize the bidi iterator.
3989 (display_string): If we need to ignore text properties of
3990 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3991 original value of -1 will not work with bidi.)
3992 (compute_display_string_pos): First arg is now struct
3993 `text_pos *'; all callers changed. Support display properties on
3995 (compute_display_string_end): Support display properties on Lisp
3997 (init_iterator, reseat_1, reseat_to_string): Initialize the
3998 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3999 when iterating on a string not from display properties).
4000 (compute_display_string_pos, compute_display_string_end):
4001 Fix calculation of the object to scan. Fixes an error when using
4003 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4004 base_level_stop; instead, set base_level_stop to BEGV.
4005 Fixes crashes in vertical-motion.
4006 (next_element_from_buffer): Improve commentary for when
4007 the iterator is before prev_stop.
4008 (init_iterator): Initialize bidi_p from the default value of
4009 bidi-display-reordering, not from buffer-local value. Use the
4010 buffer-local value only if initializing for buffer iteration.
4011 (handle_invisible_prop): Support invisible properties on strings
4012 that are being bidi-reordered.
4013 (set_iterator_to_next): Support bidi reordering of C strings and
4015 (next_element_from_string): Support bidi reordering of Lisp
4017 (handle_stop_backwards): Support Lisp strings as well.
4018 (display_string): Support display of R2L glyph rows.
4019 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4020 (init_iterator): Don't initialize it->bidi_p for strings
4022 (reseat_to_string): Initialize it->bidi_p for strings here.
4023 (next_element_from_string, next_element_from_c_string)
4024 (next_element_from_buffer): Add xassert's for correspondence
4025 between IT's object being iterated and it->bidi_it.string
4027 (face_before_or_after_it_pos): Support bidi iteration.
4028 (next_element_from_c_string): Handle the case of the first string
4029 character that is not the first one in the visual order.
4030 (get_visually_first_element): New function, refactored from common
4031 parts of next_element_from_buffer, next_element_from_string, and
4032 next_element_from_c_string.
4033 (tool_bar_lines_needed, redisplay_tool_bar)
4034 (display_menu_bar): Force left-to-right direction. Add a FIXME
4035 comment for making that be controlled by a user option.
4036 (push_it, pop_it): Save and restore the state of the
4037 bidi iterator. Save and restore the bidi_p flag.
4038 (pop_it): Iterate out of display property for string iteration as
4040 (iterate_out_of_display_property): Support iteration over strings.
4041 (handle_single_display_spec): Set up it->bidi_it for iteration
4042 over a display string, and call bidi_init_it.
4043 (handle_single_display_spec, next_overlay_string)
4044 (get_overlay_strings_1, push_display_prop): Set up the bidi
4045 iterator for displaying display or overlay strings.
4046 (forward_to_next_line_start): Don't use the shortcut if
4048 (back_to_previous_visible_line_start): If handle_display_prop
4049 pushed the iterator stack, restore the internal state of the bidi
4050 iterator by calling bidi_pop_it same number of times.
4051 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4052 and we are bidi-iterating, don't decrement the iterator position;
4053 instead, set the first_elt flag in the bidi iterator, to produce
4055 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4056 (push_display_prop): xassert that we are iterating a buffer.
4057 (push_it, pop_it): Save and restore paragraph_embedding member.
4058 (handle_single_display_spec, next_overlay_string)
4059 (get_overlay_strings_1, reseat_1, reseat_to_string)
4060 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4061 correctly. Don't assume unibyte strings are not bidi-reordered.
4062 (compute_display_string_pos)
4063 (compute_display_string_end): Fix handling the case of C string.
4064 (push_it, pop_it): Save and restore from_disp_prop_p.
4065 (handle_single_display_spec, push_display_prop): Set the
4066 from_disp_prop_p flag.
4067 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4068 (pop_it): Call iterate_out_of_display_property only if we are
4069 popping after iteration over a string that came from a display
4070 property. Fix a typo in popping stretch info. Add an assertion
4071 for verifying that the iterator position is in sync with the bidi
4073 (handle_single_display_spec, get_overlay_strings_1)
4074 (push_display_prop): Fix initialization of paragraph direction for
4075 string when that of the parent object is not yet determined.
4076 (reseat_1): Call bidi_init_it to resync the bidi
4077 iterator with IT's position. (Bug#7616)
4078 (find_row_edges): If ROW->start.pos gives position
4079 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4080 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4081 Reset the from_disp_prop_p flag.
4082 (SAVE_IT, RESTORE_IT): New macros.
4083 (pos_visible_p, face_before_or_after_it_pos)
4084 (back_to_previous_visible_line_start)
4085 (move_it_in_display_line_to, move_it_in_display_line)
4086 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4087 (try_scrolling, redisplay_window, display_line): Use them when
4088 saving a temporary copy of the iterator and restoring it back.
4089 (back_to_previous_visible_line_start, reseat_1)
4090 (init_iterator): Empty the bidi cache "stack".
4091 (move_it_in_display_line_to): If iterator ended up at
4092 EOL, but we never saw any buffer positions smaller than
4093 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4094 motion in bidi-reordered lines.
4095 (move_it_in_display_line_to): Record prev_method and prev_pos
4096 immediately before the call to set_iterator_to_next. Fixes cursor
4097 motion in bidi-reordered lines with stretch glyphs and strings
4098 displayed in margins. (Bug#8133) (Bug#8867)
4099 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4101 (pos_visible_p): Support positions in bidi-reordered lines.
4102 Save and restore bidi cache.
4104 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4105 (bidi_paragraph_info): Delete unused struct.
4106 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4107 (bidi_cache_start): New variable.
4108 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4110 (bidi_cache_fetch_state, bidi_cache_search)
4111 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4112 (bidi_cache_find, bidi_peek_at_next_level)
4113 (bidi_level_of_next_char, bidi_find_other_level_edge)
4114 (bidi_move_to_visually_next): Compare cache index with
4115 bidi_cache_start rather than with zero.
4116 (bidi_fetch_char): Accept new argument STRING; all callers
4117 changed. Support iteration over a string. Support strings with
4118 display properties. Support unibyte strings. Fix the type of
4119 `len' according to what STRING_CHAR_AND_LENGTH expects.
4120 (bidi_paragraph_init, bidi_resolve_explicit_1)
4121 (bidi_resolve_explicit, bidi_resolve_weak)
4122 (bidi_level_of_next_char, bidi_move_to_visually_next):
4123 Support iteration over a string.
4124 (bidi_set_sor_type, bidi_resolve_explicit_1)
4125 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4126 can now be zero (for strings); special values 0 and -1 were
4127 changed to -1 and -2, respectively.
4128 (bidi_char_at_pos): New function.
4129 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4130 Call it instead of FETCH_MULTIBYTE_CHAR.
4131 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4132 initialized to valid values.
4133 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4135 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4136 the test for valid cached positions. Fix the logic for looking up
4137 the sentinel state in the cache. GCPRO the Lisp string we are
4139 (bidi_push_it, bidi_pop_it): New functions.
4140 (bidi_initialize): Initialize the bidi cache start stack pointer.
4141 (bidi_cache_ensure_space): New function, refactored from part of
4142 bidi_cache_iterator_state. Don't assume the required size is just
4143 one BIDI_CACHE_CHUNK away.
4144 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4145 (bidi_count_bytes, bidi_char_at_pos): New functions.
4146 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4147 always valid if bidi_cache_idx is valid.
4148 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4149 is valid if it's going to be used.
4150 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4151 (bidi_cache_fetch_state, bidi_cache_search)
4152 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4153 (bidi_cache_iterator_state, bidi_cache_find)
4154 (bidi_find_other_level_edge, bidi_cache_start_stack):
4155 All variables related to cache indices are now EMACS_INT.
4157 * dispextern.h (struct bidi_string_data): New structure.
4158 (struct bidi_it): New member `string'. Make flag members be 1-bit
4159 fields, and put them last in the struct.
4160 (compute_display_string_pos, compute_display_string_end):
4162 (bidi_push_it, bidi_pop_it): Add prototypes.
4163 (struct iterator_stack_entry): New members bidi_p,
4164 paragraph_embedding, and from_disp_prop_p.
4165 (struct it): Member bidi_p is now a bit field 1 bit wide.
4166 (bidi_shelve_cache, bidi_unshelve_cache):
4169 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4170 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4171 and vector-like objects.
4173 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4174 cache around display iteration.
4176 * window.c (Fwindow_end, window_scroll_pixel_based)
4177 (displayed_window_lines, Frecenter): Save and restore the bidi
4178 cache around display iteration.
4180 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4182 * editfns.c (Fdelete_region): Clarify the use of the named
4183 parameters (bug#6788).
4185 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4187 * indent.c (Fvertical_motion): Set and restore w->pointm when
4188 saving and restoring the window's buffer (Bug#9006).
4190 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4192 * editfns.c (Fstring_to_char): Clarify just what is returned
4193 (bug#6576). Text by Eli Zaretskii.
4195 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4197 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4199 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4201 * buffer.c (mmap_find): Fix a typo.
4203 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4205 Fix execution of x selection hooks.
4206 * xselect.c (Qx_lost_selection_functions)
4207 (Qx_sent_selection_functions): New vars.
4208 (syms_of_xselect): DEFSYM them.
4209 (x_handle_selection_request): Pass Qx_sent_selection_functions
4210 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4211 (x_handle_selection_clear,x_clear_frame_selections):
4212 Pass Qx_lost_selection_functions rather than
4213 Vx_lost_selection_functions to Frun_hook_with_args.
4215 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4217 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4218 The old code sometimes used this field without initializing it.
4220 * alloc.c (gc_sweep): Don't read past end of array.
4221 In theory, the old code could also have corrupted Emacs internals,
4222 though it'd be very unlikely.
4224 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4226 * character.c (Fcharacterp): Don't advertise optional ignored
4227 argument. (Bug#4026)
4229 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4231 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4234 * window.c (Fset_window_start): Doc fix (bug#4199).
4235 (Fset_window_hscroll): Ditto.
4237 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4239 Fix minor new problems caught by GCC 4.6.1.
4240 * term.c (init_tty): Remove unused local.
4241 * xsettings.c (store_monospaced_changed): Define this function only
4242 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4245 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4247 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4249 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4251 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4252 are the mini-buffer and the echo area (bug#3320).
4254 * term.c (init_tty): Remove support for supdup, c10 and perq
4255 terminals, which are no longer supported (bug#1482).
4257 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4259 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4261 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4263 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4264 for non-popups (Bug#3642).
4266 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4268 * alloc.c (reset_malloc_hooks): Protoize.
4269 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4270 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4271 * cm.c (losecursor): Likewise.
4272 * data.c (fmod): Likewise.
4273 * dispnew.c (swap_glyphs_in_rows): Likewise.
4274 * emacs.c (memory_warning_signal): Likewise.
4275 * floatfns.c (float_error): Likewise.
4276 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4277 (otf_open, font_otf_capability, generate_otf_features)
4278 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4280 * image.c (pbm_read_file): Likewise.
4281 * indent.c (string_display_width): Likewise.
4282 * intervals.c (check_for_interval, search_for_interval)
4283 (inc_interval_count, count_intervals, root_interval)
4284 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4285 * lread.c (defalias): Likewise.
4286 * ralloc.c (r_alloc_check): Likewise.
4287 * regex.c (set_image_of_range_1, set_image_of_range)
4288 (regex_grow_registers): Likewise.
4289 * sysdep.c (strerror): Likewise.
4290 * termcap.c (valid_filename_p, tprint, main): Likewise.
4291 * tparam.c (main): Likewise.
4292 * unexhp9k800.c (run_time_remap, save_data_space)
4293 (update_file_ptrs, read_header, write_header, calculate_checksum)
4294 (copy_file, copy_rest, display_header): Likewise.
4295 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4297 * xdisp.c (check_it): Likewise.
4298 * xfaces.c (register_color, unregister_color, unregister_colors):
4300 * xfns.c (print_fontset_result): Likewise.
4301 * xrdb.c (member, fatal, main): Likewise.
4303 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4305 Fix minor problems found by static checking (Bug#9031).
4306 * chartab.c (char_table_set_range, map_sub_char_table):
4307 Remove unused locals.
4308 (uniprop_table): Now static.
4309 * composite.c (_work_char): Remove unused static var.
4311 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4313 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4315 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4317 * gtkutil.c (qttip_cb): Remove code without function.
4319 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4321 * w32.c (pthread_sigmask): New stub.
4323 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4325 Use pthread_sigmask, not sigprocmask (Bug#9010).
4326 sigprocmask is portable only for single-threaded applications, and
4327 Emacs can be multi-threaded when it uses GTK.
4328 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4330 * callproc.c (Fcall_process):
4331 * process.c (create_process):
4332 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4333 Use pthread_sigmask, not sigprocmask.
4335 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4337 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4338 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4341 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4343 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4344 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4345 (xg_hide_tooltip): Fix comment.
4347 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4348 in registerServicesMenuSendTypes.
4349 (validRequestorForSendType): Don't check ns_return_types.
4351 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4354 2011-07-08 Jason Rumney <jasonr@gnu.org>
4356 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4357 SH_SHOW for hidden windows (Bug#5482).
4359 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4360 frame struct members of non-existent frames (Bug#6284).
4362 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4364 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4365 variable firstTime not needed on OSX >= 10.6.
4366 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4367 >= 10.5. Use setKnobProportion, setDoubleValue.
4369 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4370 (MAC_OS_X_VERSION_10_5): Define if not defined.
4371 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4372 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4373 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4375 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4376 cString and lossyCString on OSX >= 10.4
4378 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4379 sizeToFit on OSX >= 10.2.
4381 * nsimage.m (allocInitFromFile): Don't use deprecated method
4382 bestRepresentationForDevice on OSX >= 10.6.
4384 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4387 * emacs.c: Declare unexec_init_emacs_zone.
4389 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4391 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4393 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4394 on svcsMenu (Bug#8842).
4396 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4398 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4400 * nsterm.m (QUTF8_STRING): Declare.
4401 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4402 (validRequestorForSendType): Return type is (id).
4403 Change indexOfObjectIdenticalTo to indexOfObject.
4404 Check if we have local selection before returning self (Bug#8842).
4405 (writeSelectionToPasteboard): Put local selection into paste board
4406 if we have a local selection (Bug#8842).
4407 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4409 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4410 (ns_get_local_selection): Declare.
4412 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4414 * keymap.c (describe_map_tree): Don't insert a double newline at
4415 the end of the buffer (bug#1169) and return whether we inserted
4418 * callint.c (Fcall_interactively): Change "reading args" to
4419 "providing args" to try to clarify what it does (bug#1010).
4421 2011-07-07 Kenichi Handa <handa@m17n.org>
4423 * composite.c (composition_compute_stop_pos): Ignore a static
4424 composition starting before CHARPOS (Bug#8915).
4426 * xdisp.c (handle_composition_prop): Likewise.
4428 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4430 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4433 2011-07-07 Kenichi Handa <handa@m17n.org>
4435 * character.h (unicode_category_t): New enum type.
4437 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4438 (Qchar_code_property_table): New variable.
4439 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4440 (UNIPROP_COMPRESSED_FORM_P): New macros.
4441 (char_table_ascii): Uncompress the compressed values.
4442 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4443 Uncompress the compressed values.
4444 (sub_char_table_ref_and_range): Likewise.
4445 (char_table_ref_and_range): Uncompress the compressed values.
4446 (sub_char_table_set): New arg is_uniprop. Callers changed.
4447 Uncompress the compressed values.
4448 (sub_char_table_set_range): Args changed. Callers changed.
4449 (char_table_set_range): Adjuted for the above change.
4450 (map_sub_char_table): Delete args default_val and parent. Add arg
4451 top. Give decoded values to a Lisp function.
4452 (map_char_table): Adjust for the above change. Give decoded
4453 values to a Lisp function. Gcpro more variables.
4454 (uniprop_table_uncompress)
4455 (uniprop_decode_value_run_length): New functions.
4456 (uniprop_decoder, uniprop_decoder_count): New variables.
4457 (uniprop_get_decoder, uniprop_encode_value_character)
4458 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4460 (uniprop_encoder, uniprop_encoder_count): New variables.
4461 (uniprop_get_encoder, uniprop_table)
4462 (Funicode_property_table_internal, Fget_unicode_property_internal)
4463 (Fput_unicode_property_internal): New functions.
4464 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4465 Sunicode_property_table_internal, Sget_unicode_property_internal,
4466 and Sput_unicode_property_internal. Defvar_lisp
4467 char-code-property-alist.
4469 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4470 Vunicode_category_table.
4472 * font.c (font_range): Adjust for the change of
4473 Vunicode_category_table.
4475 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4477 * m/iris4d.h: Remove file, move contents ...
4478 * s/irix6-5.h: ... here.
4480 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4482 Remove unportable assumption about struct layout (Bug#8884).
4483 * alloc.c (mark_buffer):
4484 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4485 (clone_per_buffer_values): Don't assume that
4486 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4487 This isn't true in general, and it's particularly not true
4488 if Emacs is configured with --with-wide-int.
4489 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4490 New macros, used in the buffer.c change.
4492 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4494 * xsettings.c: Use both GConf and GSettings if both are available.
4495 (store_config_changed_event): Add comment.
4496 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4497 (store_tool_bar_style_changed): New functions.
4498 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4499 (struct xsettings): Move font inside HAVE_XFT.
4500 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4501 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4502 Move inside HAVE_XFT.
4503 (something_changed_gsettingsCB): Rename from something_changedCB.
4504 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4506 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4507 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4508 (something_changed_gconfCB): Rename from something_changedCB.
4509 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4510 (parse_settings): Move check for font inside HAVE_XFT.
4511 (read_settings, apply_xft_settings): Add comment.
4512 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4513 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4514 call store_font_name_changed.
4515 (xft_settings_event): Add comment.
4516 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4517 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4518 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4519 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4520 (xsettings_initialize): Call init_gsettings last.
4521 (xsettings_get_system_font, xsettings_get_system_normal_font):
4524 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4526 Random fixes. E.g., (random) never returned negative values.
4527 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4528 subseconds part to the entropy, as that's a bit more random.
4529 Prefer signed to unsigned, since the signedness doesn't matter and
4530 in general we prefer signed. When given a limit, use a
4531 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4532 latter isn't right if USE_2_TAGS_FOR_INTS.
4533 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4534 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4536 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4538 * textprop.c (text_property_stickiness):
4539 Obey Vtext_property_default_nonsticky.
4540 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4541 * w32fns.c (syms_of_w32fns):
4542 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4544 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4546 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4547 This is more efficient than Ffile_directory_p and avoids a minor race.
4549 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4551 * buffer.c (Foverlay_put): Say what the return value is
4554 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4555 is a directory before asking whether to use the file name
4557 (barf_or_query_if_file_exists): Make the "File is a directory"
4558 error be more correct.
4560 * fns.c (Frequire): Remove the mention of the .gz files, since
4561 that's installation-specific, but keep the mention of
4562 `get-load-suffixes'.
4564 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4566 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4567 Report string overflow if the output is too long.
4569 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4571 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4572 (syms_of_gnutls): Remove duplicate DEFSYM for
4573 Qgnutls_bootprop_verify_hostname_error, an error for
4574 Qgnutls_bootprop_verify_error (which is no longer used).
4576 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4577 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4578 Also (re)move comments that are misplaced or no longer relevant.
4580 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4582 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4584 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4586 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4587 and background color parameters if they have been changed.
4589 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4591 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4593 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4595 * xsettings.c (SYSTEM_FONT): Define only when used.
4596 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4598 * keymap.c (access_keymap_1): Now static.
4600 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4602 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4603 leave any prefix arg for the up event (Bug#1586).
4605 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4607 * lread.c (syms_of_lread): Mention single symbols defined by
4608 `defvar' or `defconst' (bug#7154).
4610 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4611 (Frequire): Mention get-load-suffixes.
4613 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4615 * window.h (window): Remove clone_number slot.
4616 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4618 (make_parent_window, make_window, saved_window)
4619 (Fset_window_configuration, save_window_save): Don't deal with
4621 * buffer.c (Qclone_number): Remove declaration.
4622 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4624 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4626 Add multiple inheritance to keymaps.
4627 * keymap.c (Fmake_composed_keymap): New function.
4628 (Fset_keymap_parent): Simplify.
4629 (fix_submap_inheritance): Remove.
4630 (access_keymap_1): New function extracted from access_keymap to handle
4631 embedded parents and handle lists of maps.
4632 (access_keymap): Use it.
4633 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4634 (Fcopy_keymap): Handle embedded parents.
4635 (Fcommand_remapping, define_as_prefix): Simplify.
4636 (Fkey_binding): Simplify.
4637 (syms_of_keymap): Move minibuffer-local-completion-map,
4638 minibuffer-local-filename-completion-map,
4639 minibuffer-local-must-match-map, and
4640 minibuffer-local-filename-must-match-map to Elisp.
4641 (syms_of_keymap): Defsubr make-composed-keymap.
4642 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4643 (parse_menu_item): Trivial simplification.
4645 2011-07-01 Glenn Morris <rgm@gnu.org>
4647 * Makefile.in (SETTINGS_LIBS): Fix typo.
4649 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4651 * coding.c (Fencode_coding_string): Record the last coding system
4652 used, as the function doc string says (bug#8738).
4654 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4656 * xsettings.c (store_monospaced_changed): Take new font as arg and
4657 check for change against current_mono_font.
4658 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4659 (emacs_settings_constructor, emacs_settings_get_property)
4660 (emacs_settings_set_property, emacs_settings_class_init)
4661 (emacs_settings_init, gsettings_obj): Remove.
4662 (something_changedCB): New function for HAVE_GSETTINGS.
4663 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4664 with value as argument.
4665 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4666 g_settings_new (Bug#8967). Do not create gsettings_obj.
4667 Remove calls to g_settings_bind. Connect something_changedCB to
4670 * xgselect.c: Add defined (HAVE_GSETTINGS).
4671 (xgselect_initialize): Ditto.
4673 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4674 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4677 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4679 * eval.c (struct backtrace): Simplify and port the data structure.
4680 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4681 signed bit field, as this assumption is not portable and it makes
4682 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4683 "char debug_on_exit : 1" as this is not portable either; instead,
4684 use the portable "unsigned int debug_on_exit : 1". Remove unused
4685 member evalargs. Remove obsolete comments about cc bombing out.
4687 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4689 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4690 Let HAVE_GSETTINGS override HAVE_GCONF.
4691 (store_monospaced_changed): New function.
4692 (EMACS_SETTINGS): A new type derived from GObject to handle
4693 GSettings notifications.
4694 (emacs_settings_constructor, emacs_settings_get_property)
4695 (emacs_settings_set_property, emacs_settings_class_init):
4697 (gsettings_client, gsettings_obj): New variables.
4698 (GSETTINGS_SCHEMA): New define.
4699 (something_changedCB): Call store_monospaced_changed.
4700 (init_gsettings): New function.
4701 (xsettings_initialize): Call init_gsettings.
4702 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4705 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4708 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4710 * window.c (resize_root_window, grow_mini_window)
4711 (shrink_mini_window): Rename Qresize_root_window to
4712 Qwindow_resize_root_window and Qresize_root_window_vertically to
4713 Qwindow_resize_root_window_vertically.
4715 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4717 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4719 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4721 * makefile.w32-in: Redesign dependencies so they reflect more
4722 clearly which files are directly included by each source file,
4723 and not through other includes.
4725 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4727 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4728 (sort_overlays, overlay_strings): When an overlay's clone number
4729 matches the window's clone number process the overlay even if
4730 the overlay's window property doesn't match the current window.
4732 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4733 (Fwindow_hchild): Rename to Fwindow_left_child.
4734 (Fwindow_next): Rename to Fwindow_next_sibling.
4735 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4736 (resize_window_check): Rename to window_resize_check.
4737 (resize_window_apply): Rename to window_resize_apply.
4738 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4739 (Fdelete_other_windows_internal, resize_frame_windows)
4740 (Fsplit_window_internal, Fdelete_window_internal)
4741 (grow_mini_window, shrink_mini_window)
4742 (Fresize_mini_window_internal): Fix callers accordingly.
4744 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4746 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4747 (emacs_fixed_set_min_size): Remove.
4748 (emacs_fixed_new): Take frame as argument.
4750 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4751 (_EmacsFixedPrivate): Remove minwidth/height.
4752 Add struct frame *f.
4753 (emacs_fixed_init): Initialize priv->f.
4754 (get_parent_class, emacs_fixed_set_min_size): Remove.
4755 (emacs_fixed_new): Set priv->f to argument.
4756 (emacs_fixed_get_preferred_width)
4757 (emacs_fixed_get_preferred_height): Use min_width/height from
4758 frames size_hint to set minimum and natural (Bug#8919).
4759 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4760 and use min_width/height from frames size_hint to set
4761 min_width/height (Bug#8919).
4763 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4764 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4767 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4769 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4770 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4773 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4775 * process.c (wait_reading_process_output): Bypass select if
4776 waiting for a cell while ignoring keyboard input, and input is
4777 pending. Suggested by Jan Djärv (Bug#8869).
4779 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4781 Use gnulib's dup2 module instead of rolling our own.
4782 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4784 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4786 * dispnew.c (scrolling_window): Before scrolling, turn off a
4787 mouse-highlight in the window being scrolled.
4789 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4791 Move DEFSYM to lisp.h and use everywhere.
4793 * character.h (DEFSYM): Move declaration...
4794 * lisp.h (DEFSYM): ...here.
4800 * w32select.c: Don't include character.h.
4802 * alloc.c (syms_of_alloc):
4803 * buffer.c (syms_of_buffer):
4804 * bytecode.c (syms_of_bytecode):
4805 * callint.c (syms_of_callint):
4806 * casefiddle.c (syms_of_casefiddle):
4807 * casetab.c (init_casetab_once):
4808 * category.c (init_category_once, syms_of_category):
4809 * ccl.c (syms_of_ccl):
4810 * cmds.c (syms_of_cmds):
4811 * composite.c (syms_of_composite):
4812 * dbusbind.c (syms_of_dbusbind):
4813 * dired.c (syms_of_dired):
4814 * dispnew.c (syms_of_display):
4815 * doc.c (syms_of_doc):
4816 * editfns.c (syms_of_editfns):
4817 * emacs.c (syms_of_emacs):
4818 * eval.c (syms_of_eval):
4819 * fileio.c (syms_of_fileio):
4820 * fns.c (syms_of_fns):
4821 * frame.c (syms_of_frame):
4822 * fringe.c (syms_of_fringe):
4823 * insdel.c (syms_of_insdel):
4824 * keymap.c (syms_of_keymap):
4825 * lread.c (init_obarray, syms_of_lread):
4826 * macros.c (syms_of_macros):
4827 * msdos.c (syms_of_msdos):
4828 * print.c (syms_of_print):
4829 * process.c (syms_of_process):
4830 * search.c (syms_of_search):
4831 * sound.c (syms_of_sound):
4832 * syntax.c (init_syntax_once, syms_of_syntax):
4833 * terminal.c (syms_of_terminal):
4834 * textprop.c (syms_of_textprop):
4835 * undo.c (syms_of_undo):
4836 * w32.c (globals_of_w32):
4837 * window.c (syms_of_window):
4838 * xdisp.c (syms_of_xdisp):
4839 * xfaces.c (syms_of_xfaces):
4840 * xfns.c (syms_of_xfns):
4841 * xmenu.c (syms_of_xmenu):
4842 * xsettings.c (syms_of_xsettings):
4843 * xterm.c (syms_of_xterm): Use DEFSYM.
4845 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4847 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4849 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4851 Integer and buffer overflow fixes (Bug#8873).
4853 * print.c (printchar, strout): Check for string overflow.
4854 (PRINTPREPARE, printchar, strout):
4855 Don't set size unless allocation succeeds.
4857 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4858 for sizes. Check for string overflow more accurately.
4859 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4861 * macros.c: Integer and buffer overflow fixes.
4862 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4863 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4864 Use ptrdiff_t, not int, for sizes.
4865 Don't increment bufsize until after realloc succeeds.
4866 Check for size-calculation overflow.
4867 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4869 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4871 * lread.c: Integer overflow fixes.
4872 (read_integer): Radix is now EMACS_INT, not int,
4873 to improve quality of diagnostics for out-of-range radices.
4874 Calculate buffer size correctly for out-of-range radices.
4875 (read1): Check for integer overflow in radices, and in
4876 read-circle numbers.
4877 (read_escape): Avoid int overflow.
4878 (Fload, openp, read_buffer_size, read1)
4879 (substitute_object_recurse, read_vector, read_list, map_obarray):
4880 Use ptrdiff_t, not int, for sizes.
4881 (read1): Use EMACS_INT, not int, for sizes.
4882 Check for size overflow.
4884 * image.c (cache_image): Check for size arithmetic overflow.
4886 * lread.c: Integer overflow issues.
4887 (saved_doc_string_size, saved_doc_string_length)
4888 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4889 Now ptrdiff_t, not int.
4890 (read1): Don't assume doc string length fits in int. Check for
4891 out-of-range doc string lengths.
4892 (read_list): Don't assume file position fits in int.
4893 (read_escape): Check for hex character overflow.
4895 2011-06-22 Leo Liu <sdl.web@gmail.com>
4897 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4898 Move to minibuffer.el.
4900 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4902 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4903 The following patches are for when GLYPH_DEBUG && !XASSERT.
4904 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4905 * dispnew.c (flush_stdout):
4906 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4907 Mark as externally visible.
4908 * dispnew.c (check_window_matrix_pointers): Now static.
4909 * dispnew.c (window_to_frame_vpos):
4910 * xfns.c (unwind_create_frame):
4911 * xterm.c (x_check_font): Remove unused local.
4912 * scroll.c (CHECK_BOUNDS):
4913 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4914 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4915 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4916 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4917 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4919 (debug_method_add): Use va_list and vsprintf rather than relying
4920 on undefined behavior with wrong number of arguments.
4921 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4922 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4923 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4924 since we're not interested in debugging glyphs with old libraries.
4925 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4926 GCC 4.6.0's static checking.
4928 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4930 Integer overflow and signedness fixes (Bug#8873).
4931 A few related buffer overrun fixes, too.
4933 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4935 * dispextern.h (struct face.stipple):
4936 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4937 (x_bitmap_mask, x_allocate_bitmap_record)
4938 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4939 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4940 (x_create_bitmap_from_xpm_data):
4941 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4942 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4944 * xfaces.c (load_pixmap):
4945 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4946 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4947 (.bitmaps_last, struct x_output.icon_bitmap):
4948 Use ptrdiff_t, not int, for bitmap indexes.
4949 (x_allocate_bitmap_record): Check for size overflow.
4950 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4952 Use ptrdiff_t, not int, for overlay counts.
4953 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4954 * editfns.c (overlays_around, get_pos_property):
4955 * textprop.c (get_char_property_and_overlay):
4956 * xdisp.c (next_overlay_change, note_mouse_highlight):
4957 * xfaces.c (face_at_buffer_position):
4958 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4959 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4960 (Fnext_overlay_change, Fprevious_overlay_change)
4961 (mouse_face_overlay_overlaps, Foverlays_in):
4962 Use ptrdiff_t, not int, for sizes.
4963 (overlays_at, overlays_in): Check for size-calculation overflow.
4965 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4967 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4968 (x_session_initialize): Do not assume string length fits in int.
4970 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4971 This is unlikely, but can occur if DPI is outlandish.
4973 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4974 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4976 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4977 * xrdb.c (magic_file_p, search_magic_path):
4978 Omit last arg SUFFIX; it was always 0. All callers changed.
4979 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4981 * xfont.c (xfont_match): Avoid need for strlen.
4983 * xfns.c: Don't assume strlen fits in int.
4984 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4986 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4987 not unsigned long, as we prefer signed integers. All callers changed.
4988 Detect integer overflow in repeat count.
4989 (message_dolog): Don't assume print length fits in 39 bytes.
4990 (display_mode_element): Don't assume strlen fits in int.
4992 * termcap.c: Don't assume sizes fit in int and never overflow.
4993 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4994 (gobble_line): Check for size-calculation overflow.
4996 * minibuf.c (Fread_buffer):
4997 * lread.c (intern, intern_c_string):
4998 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4999 Don't assume string length fits in int.
5001 * keyboard.c (parse_tool_bar_item):
5002 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5004 * font.c: Don't assume string length fits in int.
5005 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5006 Use ptrdiff_t, not int.
5007 (font_intern_prop): Don't assume string length fits in int.
5008 Don't assume integer property fits in fixnum.
5009 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5011 * filelock.c: Fix some buffer overrun and integer overflow issues.
5012 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5013 Reformulate so as not to need the command string.
5014 Invoke gzip -cd rather than gunzip, as it's more portable.
5015 (lock_info_type, lock_file_1, lock_file):
5016 Don't assume pid_t and time_t fit in unsigned long.
5017 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5018 (current_lock_owner): Prefer signed type for sizes.
5019 Use memcpy, not strncpy, where memcpy is what is really wanted.
5020 Don't assume (via atoi) that time_t and pid_t fit in int.
5021 Check for time_t and/or pid_t out of range, e.g., via a network share.
5022 Don't alloca where an auto var works fine.
5024 * fileio.c: Fix some integer overflow issues.
5025 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5026 Don't assume string length fits in int.
5027 (directory_file_name): Don't assume string length fits in long.
5028 (make_temp_name): Don't assume pid fits in int, or that its print
5029 length is less than 20.
5031 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5033 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5035 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5037 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5038 We prefer signed integers, even for size calculations.
5040 * emacs.c: Don't assume string length fits in 'int'.
5041 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5042 (main): Don't invoke strlen when not needed.
5044 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5045 (XD_DEBUG_MESSAGE): Don't waste a byte.
5047 * callproc.c (getenv_internal_1, getenv_internal)
5049 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5051 * lread.c (invalid_syntax): Omit length argument.
5052 All uses changed. This doesn't fix a bug, but it simplifies the
5053 code away from its former Hollerith-constant appearance, and it's
5054 one less 'int' to worry about when looking at integer-overflow issues.
5055 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5057 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5058 This didn't break anything, but it didn't help either.
5059 It's confusing to put a bogus integer in a place where the actual
5060 value does not matter.
5061 (LIST_END_P): Remove unused macro and its bogus comment.
5062 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5064 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5065 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5067 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5068 We prefer signed types, and the value cannot exceed the EMACS_INT
5069 range anyway (because otherwise the length would not be representable).
5070 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5071 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5072 This avoids a GCC warning when WIDE_EMACS_INT.
5074 * indent.c (sane_tab_width): New function.
5075 (current_column, scan_for_column, Findent_to, position_indentation)
5076 (compute_motion): Use it. This is just for clarity.
5077 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5079 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5081 * lisp.h (lint_assume): New macro.
5082 * composite.c (composition_gstring_put_cache):
5083 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5085 * editfns.c, insdel.c:
5086 Omit unnecessary forward decls, to simplify future changes.
5088 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5090 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5092 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5093 Use much-faster test for byte-length change.
5094 Don't assume string byte-length fits in 'int'.
5095 Check that character arg fits in 'int'.
5096 (mapcar1): Declare byte as byte, for clarity.
5098 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5100 * fns.c (concat): Catch string overflow earlier.
5101 Do not rely on integer wraparound.
5103 * dispextern.h (struct it.overlay_strings_charpos)
5104 (struct it.selective): Now EMACS_INT, not int.
5105 * xdisp.c (forward_to_next_line_start)
5106 (back_to_previous_visible_line_start)
5107 (reseat_at_next_visible_line_start, next_element_from_buffer):
5108 Don't arbitrarily truncate the value of 'selective' to int.
5110 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5112 * composite.c: Don't truncate sizes to 'int'.
5113 (composition_gstring_p, composition_reseat_it)
5114 (composition_adjust_point): Use EMACS_INT, not int.
5115 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5116 not EMACS_UINT, for indexes.
5118 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5120 * buffer.c: Include <verify.h>.
5121 (struct sortvec.priority, struct sortstr.priority):
5122 Now EMACS_INT, not int.
5123 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5124 (struct sortstr.size, record_overlay_string)
5125 (struct sortstrlist.size, struct sortlist.used):
5126 Don't truncate size to int.
5127 (record_overlay_string): Check for size-calculation overflow.
5128 (init_buffer_once): Check at compile-time, not run-time.
5130 2011-06-22 Jim Meyering <meyering@redhat.com>
5132 Don't leak an XBM-image-sized buffer
5133 * image.c (xbm_load): Free the image buffer after using it.
5135 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5138 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5139 that Sun C diagnosed.
5140 * fns.c (secure_hash): Fix pointer signedness issue.
5141 * intervals.c (static_offset_intervals): New function.
5142 (offset_intervals): Use it.
5144 2011-06-21 Leo Liu <sdl.web@gmail.com>
5147 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5150 * fns.c (secure_hash): Rename from crypto_hash_function and change
5151 the first arg to accept symbols.
5152 (Fsecure_hash): New primitive.
5153 (syms_of_fns): New symbols.
5155 2011-06-20 Deniz Dogan <deniz@dogan.se>
5157 * process.c (Fset_process_buffer): Clarify return value in
5160 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5162 * dispnew.c (add_window_display_history): Use BVAR.
5164 * xdisp.c (debug_method_add): Use BVAR.
5165 (check_window_end, dump_glyph_matrix, dump_glyph)
5166 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5168 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5171 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5172 check till after the cache is created in init_frame_faces.
5174 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5176 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5178 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5180 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5181 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5182 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5184 Improve buffer-overflow checking (Bug#8873).
5185 * fileio.c (Finsert_file_contents):
5186 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5187 Remove the old (too-loose) buffer overflow checks.
5188 They weren't needed, since make_gap checks for buffer overflow.
5189 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5190 The old code merely checked for Emacs fixnum overflow, and relied
5191 on undefined (wraparound) behavior. The new code avoids undefined
5192 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5194 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5195 Tune. Don't use wider integers than needed. Don't use alloca.
5196 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5198 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5200 * insdel.c, lisp.h (buffer_overflow): New function.
5201 (insert_from_buffer_1, replace_range, replace_range_2):
5202 * insdel.c (make_gap_larger):
5203 * editfns.c (Finsert_char):
5204 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5206 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5208 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5210 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5212 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5213 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5215 * fileio.c: Don't assume EMACS_INT fits in off_t.
5216 (emacs_lseek): New static function.
5217 (Finsert_file_contents, Fwrite_region): Use it.
5218 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5220 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5222 * fns.c: Don't overflow int when computing a list length.
5223 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5224 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5225 truncation on 64-bit hosts. Check for QUIT every
5226 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5227 faster and is responsive enough.
5228 (Flength): Report an error instead of overflowing an integer.
5229 (Fsafe_length): Return a float if the value is not representable
5230 as a fixnum. This shouldn't happen except in contrived situations.
5231 (Fnthcdr, Fsort): Don't assume list length fits in int.
5232 (Fcopy_sequence): Don't assume vector length fits in int.
5234 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5235 (header_size, word_size): New constants.
5236 (allocate_vectorlike): Don't check size overflow here.
5237 (allocate_vector): Check it here instead, since this is the only
5238 caller of allocate_vectorlike that could cause overflow.
5239 Check that the new vector's length is representable as a fixnum.
5241 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5242 The previous code was bogus. For example, next_almost_prime (32)
5243 returned 39, which is undesirable as it is a multiple of 3; and
5244 next_almost_prime (24) returned 25, which is a multiple of 5 so
5245 why was the code bothering to check for multiples of 7?
5247 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5249 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5251 Variadic C functions now count arguments with ptrdiff_t.
5252 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5253 Back then I didn't know that the Emacs coding style prefers signed int.
5254 Also, in the meantime I found a few more instances where arguments
5255 were being counted with int, which may truncate counts on 64-bit
5256 machines, or EMACS_INT, which may be unnecessarily wide.
5257 * lisp.h (struct Lisp_Subr.function.aMANY)
5258 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5259 Arg counts are now ptrdiff_t, not size_t.
5260 All variadic functions and their callers changed accordingly.
5261 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5262 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5263 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5264 * callint.c (Fcall_interactively): Check arg count for overflow,
5265 to avoid potential buffer overrun. Use signed char, not 'int',
5266 for 'varies' array, so that we needn't bother to check its size
5267 calculation for overflow.
5268 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5269 * eval.c (apply_lambda):
5270 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5271 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5272 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5274 * callint.c (Fcall_interactively): Don't use index var as event count.
5276 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5277 * mem-limits.h (SIZE): Remove; no longer used.
5279 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5281 Remove unnecessary casts.
5282 * xterm.c (x_term_init):
5283 * xfns.c (x_set_border_pixel):
5284 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5285 These aren't needed now that we assume ANSI C.
5287 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5288 It's more likely to cause problems (due to unsigned overflow)
5291 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5293 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5295 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5297 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5299 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5301 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5303 GLYPH_CODE_FACE returns EMACS_INT, not int.
5304 * dispextern.h (merge_faces):
5305 * xfaces.c (merge_faces):
5306 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5307 Don't assume EMACS_INT fits in int.
5309 * character.h (CHAR_VALID_P): Remove unused parameter.
5310 * fontset.c, lisp.h, xdisp.c: All uses changed.
5312 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5314 * fns.c (concat): Minor tuning based on overflow analysis.
5315 This doesn't fix any bugs. Use int to hold character, instead
5316 of constantly refetching from Emacs object. Use XFASTINT, not
5317 XINT, for value known to be a character. Don't bother comparing
5318 a single byte to 0400, as it's always less.
5320 * floatfns.c (Fexpt):
5321 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5323 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5326 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5328 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5329 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5330 incorrectly succeed when S was a string, because 4294967386 was
5331 truncated before it was used.
5333 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5334 Otherwise, an out-of-range integer could cause undefined behavior
5337 * composite.c: Use int, not EMACS_INT, for characters.
5338 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5339 EMACS_INT, for values that are known to be in character range.
5340 This doesn't fix any bugs but is the usual style inside Emacs and
5341 may generate better code on 32-bit machines.
5343 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5344 This is for reasons similar to the recent CHAR_STRING fix.
5345 * charset.c (Fencode_char): Check that character arg is actually
5346 a character. Pass an int to ENCODE_CHAR.
5347 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5348 wider than 'int', as a compile-time check to prevent future regressions
5351 * character.c (char_string): Remove unnecessary casts.
5353 Make sure a 64-bit char is never passed to CHAR_STRING.
5354 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5355 by silently ignoring the top 32 bits, allowing some values
5356 that were far too large to be valid characters.
5357 * character.h: Include <verify.h>.
5358 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5359 arguments are no wider than unsigned, as a compile-time check
5360 to prevent future regressions in this area.
5362 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5363 (Fsubst_char_in_region):
5365 * xdisp.c (decode_mode_spec_coding):
5366 Adjust to CHAR_STRING's new requirement.
5367 * editfns.c (Finsert_char, Fsubst_char_in_region):
5368 * fns.c (concat): Check that character args are actually
5369 characters. Without this test, these functions did the wrong
5370 thing with wildly out-of-range values on 64-bit hosts.
5372 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5373 These casts should not be needed on 32-bit hosts, either.
5374 * keyboard.c (read_char):
5375 * lread.c (Fload): Remove casts to unsigned.
5377 * lisp.h (UNSIGNED_CMP): New macro.
5378 This fixes comparison bugs on 64-bit hosts.
5379 (ASCII_CHAR_P): Use it.
5380 * casefiddle.c (casify_object):
5381 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5382 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5383 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5384 * dispextern.h (FACE_FROM_ID):
5385 * keyboard.c (read_char): Use UNSIGNED_CMP.
5387 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5388 not to EMACS_INT, to avoid GCC warning.
5390 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5392 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5393 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5394 isn't needed on 32-bit machines.
5396 * buffer.c (Fgenerate_new_buffer_name):
5397 Use EMACS_INT for count, not int.
5398 (advance_to_char_boundary): Return EMACS_INT, not int.
5400 * data.c (Qcompiled_function): Now static.
5402 * window.c (window_body_lines): Now static.
5404 * image.c (gif_load): Rename local to avoid shadowing.
5406 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5407 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5408 * alloc.c (make_save_value): Integer argument is now of type
5410 (mark_object): Use ptrdiff_t, not int.
5411 * lisp.h (pD): New macro.
5412 * print.c (print_object): Use it.
5414 * alloc.c: Use EMACS_INT, not int, to count objects.
5415 (total_conses, total_markers, total_symbols, total_vector_size)
5416 (total_free_conses, total_free_markers, total_free_symbols)
5417 (total_free_floats, total_floats, total_free_intervals)
5418 (total_intervals, total_strings, total_free_strings):
5419 Now EMACS_INT, not int. All uses changed.
5420 (Fgarbage_collect): Compute overall total using a double, so that
5421 integer overflow is less likely to be a problem. Check for overflow
5422 when converting back to an integer.
5423 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5424 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5425 These were 'int' variables that could overflow on 64-bit hosts;
5426 they were never used, so remove them instead of repairing them.
5427 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5428 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5429 Previously, this ceilinged at INT_MAX, but that doesn't work on
5431 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5433 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5434 (allocate_vectorlike): Check for ptrdiff_t overflow.
5435 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5436 when a (possibly-narrower) signed value would do just as well.
5437 We prefer using signed arithmetic, to avoid comparison confusion.
5439 * alloc.c: Catch some string size overflows that we were missing.
5440 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5441 for convenience in STRING_BYTES_MAX.
5442 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5443 The definition here is exact; the one in lisp.h was approximate.
5444 (allocate_string_data): Check for string overflow. This catches
5445 some instances we weren't catching before. Also, it catches
5446 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5447 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5448 and ptrdiff_t and EMACS_INT are both 64 bits.
5450 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5451 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5452 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5454 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5456 * alloc.c (Fmake_string): Check for out-of-range init.
5458 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5460 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5462 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5464 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5465 xg_get_default_scrollbar_width.
5467 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5468 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5469 (style_changed_cb): Call update_theme_scrollbar_width and call
5470 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5471 all frames (Bug#8505).
5472 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5473 Call gtk_window_set_resizable if HAVE_GTK3.
5474 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5475 and height if HAVE_GTK3 (Bug#8505).
5476 (scroll_bar_width_for_theme): New variable.
5477 (update_theme_scrollbar_width): New function.
5478 (xg_get_default_scrollbar_width): Move code to
5479 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5480 (xg_initialize): Call update_theme_scrollbar_width.
5482 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5484 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5486 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5488 * frame.c (make_frame): Call other_buffer_safely instead of
5491 * window.c (temp_output_buffer_show): Call display_buffer with
5492 second argument Vtemp_buffer_show_specifiers and reset latter
5493 immediately after the call.
5494 (Vtemp_buffer_show_specifiers): New variable.
5495 (auto_window_vscroll_p, next_screen_context_lines)
5496 (Vscroll_preserve_screen_position): Remove leading asterisks from
5499 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5501 Fix minor problems found by GCC 4.6.0 static checking.
5502 * buffer.c (Qclone_number): Remove for now, as it's unused.
5503 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5504 (record_buffer): Remove unused local.
5505 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5506 (set_frame_buffer_list): Remove; unused.
5507 * frame.h (other_visible_frames): Remove decl.
5508 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5509 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5510 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5512 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5513 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5514 Define only if HAVE_GPM.
5515 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5516 (update_hints_inhibit): Remove; never set. All uses removed.
5517 * widgetprv.h (emacsFrameClassRec): Remove decl.
5518 * window.c (delete_deletable_window): Now returns void, since it
5519 wasn't returning anything.
5520 (compare_window_configurations): Remove unused locals.
5521 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5522 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5523 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5524 the same widths as pointers. This follows up on the 2011-05-06 patch.
5525 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5526 * xterm.h: Likewise.
5527 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5529 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5531 * makefile.w32-in: Update dependencies.
5532 (LISP_H): Add lib/intprops.h.
5534 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5536 * image.c (gif_load): Add animation frame delay to the metadata.
5537 (syms_of_image): Use DEFSYM. New symbol `delay'.
5539 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5541 * window.c (delete_deletable_window): Re-add.
5542 (Fset_window_configuration): Rewrite to handle dead buffers and
5543 consequently deletable windows.
5544 (window_tree, Fwindow_tree): Remove. Supply functionality in
5546 (compare_window_configurations): Simplify code.
5548 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5550 * image.c (imagemagick_load_image): Fix type mismatch.
5551 (Fimagemagick_types): Likewise.
5553 * window.h (replace_buffer_in_windows): Declare.
5555 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5557 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5558 Qclone_number. Remove external declaration of Qdelete_window.
5559 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5561 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5562 Run Qbuffer_list_update_hook if allowed.
5563 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5564 buffer list implementation.
5565 (other_buffer_safely): New function.
5566 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5567 calls to replace_buffer_in_windows and
5568 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5570 (record_buffer): Inhibit quitting and rewrite using quittable
5571 functions. Run Qbuffer_list_update_hook if allowed.
5572 (Frecord_buffer, Funrecord_buffer): New functions.
5573 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5574 Move switch-to-buffer to window.el.
5575 (bury-buffer): Move to window.el.
5576 (Vbuffer_list_update_hook): New variable.
5578 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5581 * window.h (resize_frame_windows): Move up in code.
5582 (Fwindow_frame): Remove EXFUN.
5583 (replace_buffer_in_all_windows): Remove prototype.
5584 (replace_buffer_in_windows_safely): Add prototype.
5586 * window.c: Declare Qdelete_window static again. Move down
5587 declaration of select_count.
5588 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5589 (Fother_window): Move to window.el.
5590 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5591 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5592 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5594 (replace_buffer_in_windows): Implement by calling
5595 Qreplace_buffer_in_windows.
5596 (replace_buffer_in_all_windows): Remove with some functionality
5597 moved into replace_buffer_in_windows_safely.
5598 (replace_buffer_in_windows_safely): New function.
5599 (select_window_norecord, select_frame_norecord): Move in front
5600 of run_window_configuration_change_hook. Remove now obsolete
5602 (Fset_window_buffer): Rewrite doc-string.
5603 Call Qrecord_window_buffer.
5604 (keys_of_window): Move binding for other-window to window.el.
5606 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5608 * dispextern.h (struct image): Replace data member, whose int_val
5609 and ptr_val fields were not used by anything, with a single
5612 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5613 (gif_clear_image, gif_load, imagemagick_load_image)
5614 (gs_clear_image, gs_load): Callers changed.
5616 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5618 * buffer.h: Include <time.h>, for time_t.
5619 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5621 Fix minor problems found by static checking.
5623 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5625 Make identifiers static if they are not used in other modules.
5626 * data.c (Qcompiled_function, Qframe, Qvector):
5627 * image.c (QimageMagick, Qsvg):
5628 * minibuf.c (Qmetadata):
5629 * window.c (resize_window_check, resize_root_window): Now static.
5630 * window.h (resize_window_check, resize_root_window): Remove decls.
5632 * window.c (window_deletion_count, delete_deletable_window):
5634 (window_body_lines): Now static.
5635 (Fdelete_other_windows_internal): Mark vars as initialized.
5636 Make sure 'resize_failed' is initialized.
5637 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5638 (resize_window_apply): Remove unused local.
5639 * window.h (delete_deletable_window): Remove decl.
5641 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5642 (imagemagick_load_image): Fix pointer signedness problem by changing
5643 last arg from unsigned char * to char *. All uses changed.
5644 Also, fix a local for similar reasons.
5645 Remove unused locals. Remove locals to avoid shadowing.
5646 (fn_rsvg_handle_free): Remove; unused.
5647 (svg_load, svg_load_image): Fix pointer signedness problem.
5648 (imagemagick_load_image): Don't use garbage pointer image_wand.
5650 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5652 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5654 * image.c (gif_load): Fix omitted cast error introduced by
5657 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5659 * window.h (resize_proportionally, orig_total_lines)
5660 (orig_top_line): Remove from window structure.
5661 (set_window_height, set_window_width, change_window_heights)
5662 (Fdelete_window): Remove prototypes.
5663 (resize_frame_windows): Remove duplicate declaration.
5665 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5667 * window.h (resize_frame_windows, resize_window_check)
5668 (delete_deletable_window, resize_root_window)
5669 (resize_frame_windows): Declare prototypes.
5671 * window.c (resize_window_apply): Make definition be "static" to
5672 match the prototype.
5674 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5676 * window.c: Remove declarations of Qwindow_size_fixed,
5677 window_min_size_1, window_min_size_2, window_min_size,
5678 size_window, window_fixed_size_p, enlarge_window, delete_window.
5679 Remove static from declaration of Qdelete_window, it's
5680 temporarily needed by Fbury_buffer.
5681 (replace_window): Don't assign orig_top_line and
5683 (Fdelete_window, delete_window): Remove. Window deletion is
5684 handled by window.el.
5685 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5686 Replace Fdelete_window calls with calls to Qdelete_window.
5687 (Fdelete_other_windows): Remove. Deleting other windows is
5688 handled by window.el.
5689 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5690 handled in window.el.
5691 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5692 Window minimum sizes are handled in window.el.
5693 (shrink_windows, size_window, set_window_height)
5694 (set_window_width, change_window_heights, window_height)
5695 (window_width, CURBEG, CURSIZE, enlarge_window)
5696 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5697 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5698 handled in window.el.
5699 (make_dummy_parent): Rename to make_parent_window and give it a
5700 second argument horflag.
5701 (make_window): Don't set resize_proportionally any more.
5702 (Fsplit_window): Remove. Windows are split in window.el.
5703 (save_restore_action, save_restore_orig_size)
5704 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5705 Resize mini windows in window.el.
5706 (grow_mini_window, shrink_mini_window): Implement by calling
5707 Qresize_root_window_vertically, resize_window_check and
5708 resize_window_apply.
5709 (saved_window, Fset_window_configuration, save_window_save):
5710 Do not handle orig_top_line, orig_total_lines, and
5711 resize_proportionally.
5712 (window_min_height, window_min_width): Move to window.el.
5713 (keys_of_window): Move bindings for delete-other-windows,
5714 split-window, delete-window and enlarge-window to window.el.
5716 * buffer.c: Temporarily extern Qdelete_window.
5717 (Fbury_buffer): Temporarily call Qdelete_window instead of
5718 Fdelete_window (Fbury_buffer will move to window.el soon).
5720 * frame.c (set_menu_bar_lines_1): Remove code handling
5721 orig_top_line and orig_total_lines.
5723 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5724 set_window_height but set heights directly.
5725 (change_frame_size_1): Use resize_frame_windows.
5727 * xdisp.c (init_xdisp): Don't use set_window_height but set
5730 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5731 Use resize_frame_windows instead of change_window_heights and run
5732 run_window_configuration_change_hook.
5734 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5735 instead of change_window_heights and run
5736 run_window_configuration_change_hook.
5738 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5740 * window.c (replace_window): Rename second argument REPLACEMENT to
5741 NEW. New third argument SETFLAG. Rewrite.
5742 (delete_window, make_dummy_parent): Call replace_window with
5744 (window_list_1): Move down in code.
5745 (run_window_configuration_change_hook): Move set_buffer part
5746 before select_frame_norecord part in order to unwind correctly.
5747 Rename count1 to count.
5748 (recombine_windows, delete_deletable_window, resize_root_window)
5749 (Fdelete_other_windows_internal)
5750 (Frun_window_configuration_change_hook, make_parent_window)
5751 (resize_window_check, resize_window_apply, Fresize_window_apply)
5752 (resize_frame_windows, Fsplit_window_internal)
5753 (Fdelete_window_internal, Fresize_mini_window_internal):
5755 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5757 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5759 * window.h (window): Add some new members to window structure -
5760 normal_lines, normal_cols, new_total, new_normal, clone_number,
5761 splits, nest, prev_buffers, next_buffers.
5762 (WINDOW_TOTAL_SIZE): Move here from window.c.
5763 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5765 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5767 (make_dummy_parent): Set new members of windows structure.
5768 (make_window): Move down in code. Handle new members of window
5770 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5771 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5772 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5773 (Fset_window_prev_buffers, Fwindow_next_buffers)
5774 (Fset_window_next_buffers, Fset_window_clone_number):
5776 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5777 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5779 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5780 Argument WINDOW can be now internal window too.
5781 (Fwindow_use_time): Move up in code.
5782 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5784 (Fset_window_configuration, saved_window)
5785 (Fcurrent_window_configuration, save_window_save): Handle new
5786 members of window structure.
5787 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5788 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5789 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5790 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5791 Qget_mru_window, Qresize_root_window,
5792 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5793 Qauto_buffer_name; staticpro them.
5795 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5797 * window.c (Fwindow_total_size, Fwindow_left_column)
5798 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5799 (Fwindow_list_1): New functions.
5800 (window_box_text_cols): Replace with window_body_cols.
5801 (Fwindow_width, Fscroll_left, Fscroll_right):
5802 Use window_body_cols instead of window_box_text_cols.
5803 (delete_window, Fset_window_configuration):
5804 Call delete_all_subwindows with window as argument.
5805 (delete_all_subwindows): Take a window as argument and not a
5807 (window_loop): Remove handling of GET_LRU_WINDOW and
5809 (Fget_lru_window, Fget_largest_window): Move to window.el.
5811 * window.h: Extern window_body_cols instead of
5812 window_box_text_cols. delete_all_subwindows now takes a
5813 Lisp_Object as argument.
5815 * indent.c (compute_motion, Fcompute_motion):
5816 Use window_body_cols instead of window_box_text_cols.
5818 * frame.c (delete_frame): Call delete_all_subwindows with root
5821 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5823 * fns.c (Fputhash): Document return value.
5825 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5827 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5829 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5831 Cons<->int and similar integer overflow fixes (Bug#8794).
5833 Check for overflow when converting integer to cons and back.
5834 * charset.c (Fdefine_charset_internal, Fdecode_char):
5835 Use cons_to_unsigned to catch overflow.
5836 (Fencode_char): Use INTEGER_TO_CONS.
5837 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5838 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5839 * data.c (long_to_cons, cons_to_long): Remove.
5840 (cons_to_unsigned, cons_to_signed): New functions.
5841 These signal an error for invalid or out-of-range values.
5842 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5843 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5844 * font.c (Ffont_variation_glyphs):
5845 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5846 * lisp.h: Include <intprops.h>.
5847 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5848 (cons_to_signed, cons_to_unsigned): New decls.
5849 (long_to_cons, cons_to_long): Remove decls.
5850 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5851 (Fprimitive_undo): Use CONS_TO_INTEGER.
5852 * xfns.c (Fx_window_property): Likewise.
5853 * xselect.c: Include <limits.h>.
5854 (x_own_selection, selection_data_to_lisp_data):
5855 Use INTEGER_TO_CONS.
5856 (x_handle_selection_request, x_handle_selection_clear)
5857 (x_get_foreign_selection, Fx_disown_selection_internal)
5858 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5859 (lisp_data_to_selection_data): Use cons_to_unsigned.
5860 (x_fill_property_data): Use cons_to_signed.
5861 Report values out of range.
5863 Check for buffer and string overflow more precisely.
5864 * buffer.h (BUF_BYTES_MAX): New macro.
5865 * lisp.h (STRING_BYTES_MAX): New macro.
5866 * alloc.c (Fmake_string):
5867 * character.c (string_escape_byte8):
5868 * coding.c (coding_alloc_by_realloc):
5869 * doprnt.c (doprnt):
5870 * editfns.c (Fformat):
5872 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5873 since they may not be the same number.
5874 * editfns.c (Finsert_char):
5875 * fileio.c (Finsert_file_contents):
5876 Likewise for BUF_BYTES_MAX.
5878 * image.c: Use ptrdiff_t, not int, for sizes.
5879 (slurp_file): Switch from int to ptrdiff_t.
5881 (slurp_file): Check that file size fits in both size_t (for
5882 malloc) and ptrdiff_t (for sanity and safety).
5884 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5885 if b->modtime has its maximal value.
5887 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5889 Don't assume time_t can fit into int.
5890 * buffer.h (struct buffer.modtime): Now time_t, not int.
5891 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5892 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5894 Minor fixes for signed vs unsigned integers.
5895 * character.h (MAYBE_UNIFY_CHAR):
5896 * charset.c (maybe_unify_char):
5897 * keyboard.c (read_char, reorder_modifiers):
5898 XINT -> XFASTINT, since the integer must be nonnegative.
5899 * ftfont.c (ftfont_spec_pattern):
5900 * keymap.c (access_keymap, silly_event_symbol_error):
5901 XUINT -> XFASTINT, since the integer must be nonnegative.
5902 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5903 since it makes no difference and we prefer signed.
5904 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5905 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5908 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5910 * window.h (Fwindow_frame): Declare.
5912 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5914 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5915 (SPARE_MEMORY): Always define.
5916 (LARGE_REQUEST): Remove.
5917 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5919 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5921 * lisp.h: Move EXFUNS for Fframe_root_window,
5922 Fframe_first_window and Fset_frame_selected_window to window.h.
5924 * window.h: Move EXFUNS for Fframe_root_window,
5925 Fframe_first_window and Fset_frame_selected_window here from
5928 * frame.c (Fwindow_frame, Fframe_first_window)
5929 (Fframe_root_window, Fframe_selected_window)
5930 (Fset_frame_selected_window): Move to window.c.
5931 (Factive_minibuffer_window): Move to minibuf.c.
5932 (Fother_visible_frames_p): New function.
5934 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5936 * window.c (decode_window, decode_any_window): Move up in code.
5937 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5938 (inhibit_frame_unsplittable): Remove unused variable.
5939 (Fwindow_buffer): Move up and rewrite doc-string.
5940 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5941 (Fwindow_prev): New functions.
5942 (Fwindow_frame): Move here from frame.c. Accept any window as
5944 (Fframe_root_window, Fframe_first_window)
5945 (Fframe_selected_window): Move here from frame.c. Accept frame
5946 or arbitrary window as argument. Update doc-strings.
5947 (Fminibuffer_window): Move up in code.
5948 (Fwindow_minibuffer_p): Move up in code and simplify.
5949 (Fset_frame_selected_window): Move here from frame.c.
5951 (Fselected_window, select_window, Fselect_window): Move up in
5952 code. Minor doc-string fixes.
5954 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5956 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5957 Do not assume that spare memory exists; that assumption is valid
5958 only if SYSTEM_MALLOC.
5959 (LARGE_REQUEST): New macro, so that the issue of large requests
5960 is separated from the issue of spare memory.
5962 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5964 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5967 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5969 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5972 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5974 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5976 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5978 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5979 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5981 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5983 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5985 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5987 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5988 (x_clipboard_manager_save): Add return value.
5989 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5991 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5992 Obey Vx_select_enable_clipboard_manager. Catch errors in
5993 x_clipboard_manager_save (Bug#8779).
5994 (Vx_select_enable_clipboard_manager): New variable.
5995 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5997 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5999 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6001 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6003 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6004 in the current matrix if keep_current_p is non-zero.
6006 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6008 * bidi.c (bidi_level_of_next_char): Fix last change.
6010 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6012 Support bidi reordering of text covered by display properties.
6014 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6015 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6016 (bidi_cache_search, bidi_cache_iterator_state)
6017 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6018 (bidi_level_of_next_char, bidi_move_to_visually_next):
6019 Support character positions inside a run of characters covered by a
6021 (bidi_paragraph_init, bidi_resolve_explicit_1)
6022 (bidi_level_of_next_char): Call bidi_fetch_char and
6023 bidi_fetch_char_advance instead of FETCH_CHAR and
6025 (bidi_init_it): Initialize new members.
6026 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6028 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6029 instead of using explicit *_CHAR codes.
6030 (bidi_resolve_explicit, bidi_resolve_weak):
6031 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6032 bidirectional text is supported only in multibyte buffers.
6033 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6034 it to initialize the frame_window_p member of struct bidi_it.
6035 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6036 (bidi_resolve_explicit, bidi_resolve_weak)
6037 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6038 bidi_it->nchars is non-positive.
6039 (bidi_level_of_next_char): Don't try to lookup the cache for the
6040 next/previous character if nothing is cached there yet, or if we
6041 were just reseat()'ed to a new position.
6043 * xdisp.c (set_cursor_from_row): Set start and stop points
6044 according to the row's direction when priming the loop that looks
6045 for the glyph on which to display cursor.
6046 (single_display_spec_intangible_p): Function deleted.
6047 (display_prop_intangible_p): Reimplement to call
6048 handle_display_spec instead of single_display_spec_intangible_p.
6049 Accept 3 additional arguments needed by handle_display_spec.
6050 This fixes incorrect cursor motion across display property with complex
6051 values: lists, `(when COND...)' forms, etc.
6052 (single_display_spec_string_p): Support property values that are
6053 lists with the argument STRING its top-level element.
6054 (display_prop_string_p): Fix the condition for processing a
6055 property that is a list to be consistent with handle_display_spec.
6056 (handle_display_spec): New function, refactored from the
6057 last portion of handle_display_prop.
6058 (compute_display_string_pos): Accept additional argument
6059 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6060 value of a `display' property is a "replacing spec".
6061 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6062 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6063 the display property, but just return a value indicating whether
6064 the display property will replace the characters it covers.
6065 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6066 frame_window_p members of struct bidi_it.
6067 (compute_display_string_pos, compute_display_string_end):
6069 (push_it): Accept second argument POSITION, where pop_it should
6070 jump to continue iteration.
6071 (reseat_1): Initialize bidi_it.disp_pos.
6073 * keyboard.c (adjust_point_for_property): Adjust the call to
6074 display_prop_intangible_p to its new signature.
6076 * dispextern.h (struct bidi_it): New member frame_window_p.
6077 (bidi_init_it): Update prototypes.
6078 (display_prop_intangible_p): Update prototype.
6079 (compute_display_string_pos, compute_display_string_end):
6081 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6084 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6086 Malloc failure behavior now depends on size of allocation.
6087 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6088 * lisp.h: Change signatures accordingly.
6089 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6090 All callers changed. (Bug#8762)
6092 * gnutls.c: Use Emacs's memory allocators.
6093 Without this change, the gnutls library would invoke malloc etc.
6094 directly, which causes problems on non-SYNC_INPUT hosts, and which
6095 runs afoul of improving memory_full behavior. (Bug#8761)
6096 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6097 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6098 xfree instead of the default malloc, realloc, free.
6099 (Fgnutls_boot): No need to check for memory allocation failure,
6100 since xmalloc does that for us.
6102 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6103 * category.c (hash_get_category_set):
6104 * ccl.c (ccl_driver):
6105 * charset.c (Fdefine_charset_internal):
6106 * charset.h (struct charset.hash_index):
6107 * composite.c (get_composition_id, gstring_lookup_cache)
6108 (composition_gstring_put_cache):
6109 * composite.h (struct composition.hash_index):
6110 * dispextern.h (struct image.hash):
6111 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6112 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6113 (hashfn_equal, hashfn_user_defined, make_hash_table)
6114 (maybe_resize_hash_table, hash_lookup, hash_put)
6115 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6116 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6117 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6118 * image.c (make_image, search_image_cache, lookup_image)
6119 (xpm_put_color_table_h):
6120 * lisp.h (struct Lisp_Hash_Table):
6121 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6122 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6123 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6124 * alloc.c (allocate_vectorlike):
6125 Check for overflow in vector size calculations.
6126 * ccl.c (ccl_driver):
6127 Check for overflow when converting EMACS_INT to int.
6128 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6129 need to be updated by these changes.
6130 * fns.c (make_hash_table, maybe_resize_hash_table):
6131 Check for integer overflow with large hash tables.
6132 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6133 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6134 (SXHASH_REDUCE): New macro.
6135 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6136 Use it instead of discarding useful hash info with large hash values.
6137 (sxhash_float): New function.
6138 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6139 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6140 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6141 Rewrite to use FIXNUM_BITS, as this simplifies things.
6142 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6143 Adjust signatures to match updated version of code.
6144 (consing_since_gc): Now EMACS_INT, since a single hash table can
6145 use more than INT_MAX bytes.
6147 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6149 Make it possible to build with GCC-4.6+ -O2 -flto.
6151 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6153 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6155 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6156 Call minibuffer-inactive-mode.
6158 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6160 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6161 Update dependencies.
6163 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6165 * data.c (init_data): Remove code for UTS, this system is not
6168 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6170 Don't force ./temacs to start in terminal mode.
6172 * frame.c (make_initial_frame): Initialize faces in all cases, not
6173 only when CANNOT_DUMP is defined.
6174 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6176 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6178 * dispnew.c (add_window_display_history): Use const for the string
6179 pointer. Remove declaration, not needed.
6181 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6183 Use 'inline', not 'INLINE'.
6184 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6185 * alloc.c, fontset.c (INLINE): Remove.
6186 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6187 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6188 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6189 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6190 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6192 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6194 Make it possible to run ./temacs.
6196 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6197 syms_of_callproc does the same thing. Remove test for
6198 "initialized", do it in the caller.
6199 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6201 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6203 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6204 (read_minibuf): Use get_minibuffer.
6205 (syms_of_minibuf): Use DEFSYM.
6206 (Qmetadata): New var.
6207 * data.c (Qbuffer): Don't make it static.
6208 (syms_of_data): Use DEFSYM.
6210 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6212 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6213 (CCL_CODE_MIN): New macro.
6215 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6217 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6219 * eval.c (Qdebug): Now static.
6220 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6221 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6222 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6224 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6226 * image.c: Various fixes to ImageMagick code comments.
6227 (Fimagemagick_types): Doc fix.
6229 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6231 Minor fixes prompted by GCC 4.6.0 warnings.
6233 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6235 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6236 (x_clipboard_manager_save_all): Move extern decl to ...
6237 * xterm.h: ... here, so that it can be checked for consistency.
6239 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6241 * xselect.c (x_clipboard_manager_save_frame)
6242 (x_clipboard_manager_save_all): New functions.
6243 (Fx_clipboard_manager_save): Lisp function deleted.
6245 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6246 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6248 * xterm.h: Update prototype.
6250 2011-05-28 William Xu <william.xwl@gmail.com>
6252 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6255 2011-05-28 Jim Meyering <meyering@redhat.com>
6257 Avoid a sign-extension bug in crypto_hash_function.
6258 * fns.c (to_uchar): Define.
6259 (crypto_hash_function): Use it to convert some newly-signed
6260 variables to unsigned, to avoid sign-extension bugs. For example,
6261 without this change, (md5 "truc") would evaluate to
6262 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6263 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6264 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6266 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6268 Integer overflow fixes.
6270 * dbusbind.c: Serial number integer overflow fixes.
6271 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6272 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6273 to hold a serial number that is too large for a fixnum.
6274 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6275 Check for serial numbers out of range. Decode any serial number
6276 that was so large that it became a float. (Bug#8722)
6278 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6279 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6280 Use XFASTINT rather than XUINT when numbers are nonnegative.
6281 (xd_append_arg, Fdbus_method_return_internal):
6282 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6283 arguments, check that Lisp number is nonnegative, rather than
6284 silently wrapping negative numbers around. (Bug#8722)
6285 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6288 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6290 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6292 ccl: Add integer overflow checks.
6293 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6294 (IN_INT_RANGE): New macros.
6295 (ccl_driver): Use them to check for integer overflow when
6296 decoding a CCL program. Many of the new checks are whether XINT (x)
6297 fits in int; it doesn't always, on 64-bit hosts. The new version
6298 doesn't catch all possible integer overflows, but it's an
6299 improvement. (Bug#8719)
6301 * alloc.c (make_event_array): Use XINT, not XUINT.
6302 There's no need for unsigned here.
6304 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6305 This follows up to the 2011-05-06 change that substituted uintptr_t
6306 for EMACS_INT. This case wasn't caught back then.
6308 Rework Fformat to avoid integer overflow issues.
6309 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6310 now (part of C89). Include <verify.h>.
6311 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6312 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6313 (Fformat): Avoid the prepass trying to compute sizes; it was only
6314 approximate and thus did not catch overflow reliably. Instead, walk
6315 through the format just once, formatting and computing sizes as we go,
6316 checking for integer overflow at every step, and allocating a larger
6317 buffer as needed. Keep track separately whether the format is
6318 multibyte. Keep only the most-recently calculated precision, rather
6319 than them all. Record whether each argument has been converted to
6320 string. Use EMACS_INT, not int, for byte and char and arg counts.
6321 Support field widths and precisions larger than INT_MAX. Avoid
6322 sprintf's undefined behavior with conversion specifications such as %#d
6323 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6324 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6325 formatting out-of-range floating point numbers with int
6328 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6330 * data.c: Avoid integer truncation in expressions involving floats.
6331 * data.c: Include <intprops.h>.
6332 (arith_driver): When there's an integer overflow in an expression
6333 involving floating point, convert the integers to floating point
6334 so that the resulting value does not suffer from catastrophic
6335 integer truncation. For example, on a 64-bit host (* 4
6336 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6337 Do not rely on undefined behavior after integer overflow.
6339 merge count_size_as_multibyte, parse_str_to_multibyte
6340 * character.c, character.h (count_size_as_multibyte):
6341 Rename from parse_str_to_multibyte; all uses changed.
6342 Check for integer overflow.
6343 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6344 since it's now a duplicate of the other. This is more of
6345 a character than a buffer op, so better that it's in character.c.
6346 * fns.c, print.c: Adjust to above changes.
6348 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6350 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6352 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6354 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6355 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6356 (x_clipboard_manager_save): Now static.
6357 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6359 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6360 (crypto_hash_function): Now static.
6361 Fix pointer signedness problems. Avoid unnecessary initializations.
6363 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6365 * termhooks.h (Vselection_alist): Make it terminal-local.
6367 * terminal.c (create_terminal): Initialize it.
6369 * xselect.c: Support for clipboard managers.
6370 (Vselection_alist): Move to termhooks.h as terminal-local var.
6371 (LOCAL_SELECTION): New macro.
6372 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6373 (symbol_to_x_atom): Remove gratuitous arg.
6374 (x_handle_selection_request, lisp_data_to_selection_data)
6375 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6376 (x_own_selection, x_get_local_selection, x_convert_selection):
6377 New arg, specifying work frame. Use terminal-local Vselection_alist.
6378 (some_frame_on_display): Delete unused function.
6379 (Fx_own_selection_internal, Fx_get_selection_internal)
6380 (Fx_disown_selection_internal, Fx_selection_owner_p)
6381 (Fx_selection_exists_p): New optional frame arg.
6382 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6383 (x_handle_selection_clear): Don't treat other terminals with the
6384 same keyboard specially. Use the terminal-local Vselection_alist.
6385 (x_clear_frame_selections): Use Frun_hook_with_args.
6387 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6389 * xterm.h: Add support for those atoms.
6391 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6393 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6394 (converted_selections, conversion_fail_tag): New global variables.
6395 (x_selection_request_lisp_error): Free the above.
6396 (x_get_local_selection): Remove unnecessary code.
6397 (x_reply_selection_request): Args changed; handle arbitrary array
6398 of converted selections stored in converted_selections.
6399 Separate the XChangeProperty and SelectionNotify steps.
6400 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6401 (x_convert_selection): New function.
6402 (x_handle_selection_event): Simplify.
6403 (x_get_foreign_selection): Don't ignore incoming requests while
6404 waiting for an answer; this will fail when we implement
6405 SAVE_TARGETS, and seems unnecessary anyway.
6406 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6407 (Vx_sent_selection_functions): Doc fix.
6409 2011-05-26 Leo Liu <sdl.web@gmail.com>
6411 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6413 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6415 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6417 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6418 for fringe update if it has periodic bitmap.
6419 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6420 and fringe_bitmap_periodic_p.
6422 * fringe.c (get_fringe_bitmap_data): New function.
6423 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6424 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6425 row. Mark glyph row for fringe update if periodicity changed.
6427 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6428 for fringe update unless it has periodic bitmap.
6430 2011-05-25 Kenichi Handa <handa@m17n.org>
6432 * xdisp.c (get_next_display_element): Set correct it->face_id for
6433 a static composition.
6435 2011-05-24 Leo Liu <sdl.web@gmail.com>
6438 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6440 * fns.c (crypto_hash_function, Fsha1): New function.
6441 (Fmd5): Use crypto_hash_function.
6442 (syms_of_fns): Add Ssha1.
6444 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6446 * gnutls.c: Remove unused macros.
6447 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6448 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6449 Remove macros that are defined and never used.
6450 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6452 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6454 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6455 (Fx_get_selection_internal): Minor cleanup.
6456 (Fx_own_selection_internal): Rename arguments for consistency with
6459 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6461 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6463 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6465 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6467 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6469 * dispnew.c (scrolling_window): Don't exclude the case that the
6470 last enabled row in the desired matrix touches the bottom boundary.
6472 2011-05-21 Glenn Morris <rgm@gnu.org>
6474 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6475 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6476 and add some more files.
6478 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6480 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6481 report_file_error introduced by the change from 2011-05-07.
6483 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6485 * systime.h (Time): Define only if emacs is defined.
6486 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6487 where the include path doesn't have X11/X.h by default. See
6488 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6490 2011-05-20 Kenichi Handa <handa@m17n.org>
6492 * composite.c (find_automatic_composition): Fix previous change.
6494 2011-05-20 Glenn Morris <rgm@gnu.org>
6496 * lisp.mk: New file, split from Makefile.in.
6497 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6498 (shortlisp): Remove.
6499 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6501 2011-05-19 Glenn Morris <rgm@gnu.org>
6503 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6504 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6505 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6506 (lisp): Set the order to that of loadup.el.
6507 (shortlisp): Make it a copy of $lisp.
6508 (SOME_MACHINE_LISP): Remove.
6509 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6510 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6512 2011-05-18 Kenichi Handa <handa@m17n.org>
6514 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6515 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6516 (find_automatic_composition): Mostly rewrite for efficiency.
6518 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6520 * makefile.w32-in: Update dependencies.
6522 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6524 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6525 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6527 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6529 Fix some integer overflow issues, such as string length overflow.
6531 * insdel.c (count_size_as_multibyte): Check for string overflow.
6533 * character.c (lisp_string_width): Check for string overflow.
6534 Use EMACS_INT, not int, for string indexes and lengths; in
6535 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6536 the resulting string length overflows an EMACS_INT; instead,
6537 report a string overflow if no precision given. When checking for
6538 precision exhaustion, use a check that cannot possibly have
6539 integer overflow. (Bug#8675)
6540 * character.h (lisp_string_width): Adjust to new signature.
6542 * alloc.c (string_overflow): New function.
6543 (Fmake_string): Use it. This doesn't change behavior, but saves
6544 a few bytes and will simplify future changes.
6545 * character.c (string_escape_byte8): Likewise.
6546 * lisp.h (string_overflow): New decl.
6548 Fixups, following up to the user-interface timestamp change.
6549 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6550 for UI timestamps, instead of unsigned long.
6551 * msdos.c (mouse_get_pos): Likewise.
6552 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6553 * w32gui.h (Time): Define by including "systime.h" rather than by
6554 declaring it ourselves. (Bug#8664)
6556 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6557 * image.c (clear_image_cache): Likewise.
6559 * term.c (term_mouse_position): Don't assume time_t wraparound.
6561 Be more systematic about user-interface timestamps.
6562 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6563 and sometimes 'EMACS_UINT', to represent these timestamps.
6564 This change causes it to use 'Time' uniformly, as that's what X uses.
6565 This makes the code easier to follow, and makes it easier to catch
6566 integer overflow bugs such as Bug#8664.
6567 * frame.c (Fmouse_position, Fmouse_pixel_position):
6568 Use Time, not unsigned long, for user-interface timestamps.
6569 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6570 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6571 * keyboard.h (last_event_timestamp): Likewise.
6572 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6573 * menu.h (xmenu_show): Likewise.
6574 * term.c (term_mouse_position): Likewise.
6575 * termhooks.h (struct input_event.timestamp): Likewise.
6576 (struct terminal.mouse_position_hook): Likewise.
6577 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6578 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6579 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6580 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6582 * menu.h, termhooks.h: Include "systime.h", for Time.
6584 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6585 Don't assume that the difference between two unsigned long values
6586 can fit into an integer. At this point, we know button_down_time
6587 <= event->timestamp, so the difference must be nonnegative, so
6588 there's no need to cast the result if double-click-time is
6589 nonnegative, as it should be; check that it's nonnegative, just in
6590 case. This bug is triggered when events are more than 2**31 ms
6591 apart (about 25 days). (Bug#8664)
6593 * xselect.c (last_event_timestamp): Remove duplicate decl.
6594 (x_own_selection): Remove needless cast to unsigned long.
6596 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6597 that always fit in int. Use a sentinel instead of a counter, to
6598 avoid a temp and to allay GCC's concerns about possible int overflow.
6599 * frame.h (struct frame): Use int for menu_bar_items_used
6600 instead of EMACS_INT, since it always fits in int.
6602 * menu.c (grow_menu_items): Check for int overflow.
6604 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6606 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6607 Before, the code was not consistent. These values cannot exceed
6608 2**31 - 1 so there's no need to make them unsigned.
6609 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6610 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6611 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6613 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6615 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6616 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6617 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6618 presumably because the widths might not match.
6620 * window.c (size_window): Avoid needless test at loop start.
6622 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6624 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6626 2011-05-12 Drew Adams <drew.adams@oracle.com>
6628 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6630 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6632 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6633 `width' to `bar_area_x' and `bar_area_width', respectively.
6634 (x_scroll_run): Take account of fringe background extension.
6636 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6637 Rename local vars `left' and `width' to `bar_area_x' and
6638 `bar_area_width', respectively.
6639 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6640 background extension.
6642 2011-05-10 Jim Meyering <meyering@redhat.com>
6644 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6646 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6648 * image.c (Finit_image_library): Return t for built-in image types,
6649 like pbm and xbm. (Bug#8640)
6651 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6653 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6655 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6657 * w32console.c (Fset_screen_color): Doc fix.
6658 (Fget_screen_color): New function.
6659 (syms_of_ntterm): Defsubr it.
6661 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6662 unlink the temporary file if Fcall_process didn't create it in the
6664 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6665 child process will be redirected to a file specified with `:file'.
6666 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6667 cue to call_process_cleanup not to close that handle.
6669 2011-05-07 Ben Key <bkey76@gmail.com>
6671 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6672 one of two shell specific rules, either bootstrap-temacs-CMD or
6673 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6674 to the previous implementation of the bootstrap-temacs rule.
6675 The bootstrap-temacs-CMD rule is similar to the previous
6676 implementation of the bootstrap-temacs rule except that it
6677 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6680 These changes, along with some changes to nt/configure.bat,
6681 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6682 earlier fix to add support for --cflags and --ldflags options
6683 that include quotes so that it works whether make uses cmd or
6686 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6688 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6689 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6691 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6692 a string. Handle both cases.
6693 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6694 (Fdbus_register_method): Use Qinvalid_function.
6696 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6698 * makefile.w32-in: Update dependencies.
6699 (LISP_H): Add inttypes.h and stdin.h.
6700 (PROCESS_H): Add unistd.h.
6702 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6704 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6705 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6707 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6709 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6711 * term.c (vfatal): Remove stray call to va_end.
6712 It's not needed and the C Standard doesn't allow it here anyway.
6714 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6715 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6717 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6720 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6722 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6724 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6726 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6728 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6730 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6731 * charset.c (Fdefine_charset_internal): Don't initialize
6732 charset.code_space[15]. The value was garbage, on hosts with
6733 32-bit int (Bug#8600).
6735 * lread.c (read_integer): Be more consistent with string-to-number.
6736 Use string_to_number to do the actual conversion; this avoids
6737 rounding errors and fixes some other screwups. Without this fix,
6738 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6739 (digit_to_number): Move earlier, for benefit of read_integer.
6740 Return -1 if the digit is out of range for the base, -2 if it is
6741 not a digit in any supported base. (Bug#8602)
6743 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6745 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6746 to match comment at start of function. This also removes a
6747 GCC warning about overflow in a 32+64-bit port.
6749 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6751 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6752 Reported by Stefan Monnier in
6753 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6754 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6755 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6757 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6758 (EMACS_UINTPTR): Likewise, with uintptr_t.
6760 * lisp.h: Prefer 64-bit EMACS_INT if available.
6761 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6762 on 32-bit hosts that have 64-bit int, so that they can access
6764 However, temporarily disable this change unless the temporary
6765 symbol WIDE_EMACS_INT is defined.
6767 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6769 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6770 This removes an assumption that EMACS_INT and long are the same
6771 width as pointers. The assumption is true for Emacs porting targets
6772 now, but we want to make other targets possible.
6773 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6774 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6775 In the rest of the code, change types of integers that hold casted
6776 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6777 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6778 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6779 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6780 No need to cast type when ORing.
6781 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6782 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6783 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6784 assume EMACS_INT is the same width as char *.
6785 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6786 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6787 Remove no-longer-needed casts.
6788 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6789 (xg_tool_bar_help_callback, xg_make_tool_item):
6790 Use EMACS_INTPTR to hold an integer
6791 that will be cast to void *; this can avoid a GCC warning
6792 if EMACS_INT is not the same width as void *.
6793 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6794 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6795 (current_message_1, set_message_1):
6796 Use a local to convert to proper width without a cast.
6797 * xmenu.c (dialog_selection_callback): Likewise.
6799 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6800 Also, don't assume VALBITS / RAND_BITS is less than 5,
6801 and don't rely on undefined behavior when shifting a 1 left into
6803 * lisp.h (get_random): Change signature to match.
6805 * lread.c (hash_string): Use size_t, not int, for hash computation.
6806 Normally we prefer signed values; but hashing is special, because
6807 it's better to use unsigned division on hash table sizes so that
6808 the remainder is nonnegative. Also, size_t is the natural width
6809 for hashing into memory. The previous code used 'int', which doesn't
6810 retain enough info to hash well into very large tables.
6811 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6813 * dbusbind.c: Don't possibly lose pointer info when converting.
6814 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6815 Use XPNTR rather than XHASH, so that the high-order bits of
6816 the pointer aren't lost when converting through void *.
6818 * eval.c (Fautoload): Don't double-shift a pointer.
6820 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6822 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6824 * gnutls.c (DEF_GNUTLS_FN):
6825 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6827 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6829 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6832 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6834 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6835 New version that can reserve upto 2GB of heap space.
6837 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6839 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6841 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6843 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6844 `gnutls_certificate_set_x509_key_file'.
6846 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6848 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6849 Update dependencies.
6851 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6853 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6854 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6855 Remove unused parameter `fildes'.
6856 * process.c (read_process_output, send_process): Don't pass it.
6858 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6860 Fix previous change: the library cache is defined in w32.c.
6861 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6862 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6864 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6866 Implement dynamic loading of GnuTLS on Windows.
6868 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6869 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6870 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6873 * gnutls.c (Qgnutls_dll): Define.
6874 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6875 (gnutls_*): Declare function pointers.
6876 (init_gnutls_functions): New function to initialize function pointers.
6877 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6878 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6879 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6880 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6881 (emacs_gnutls_write, emacs_gnutls_read)
6882 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6883 (Fgnutls_available_p): New function.
6884 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6885 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6886 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6888 * image.c: Include w32.h.
6889 (Vimage_type_cache): Delete.
6890 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6891 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6892 (w32_delayed_load): Move to w32.c.
6894 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6896 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6897 (w32_delayed_load): Move from image.c. When loading a library, record
6898 its filename in the :loaded-from property of the library id.
6899 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6900 Initialize and staticpro them.
6901 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6903 * process.c: Include lisp.h before w32.h, not after.
6904 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6905 instead of gnutls_record_check_pending.
6907 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6909 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6911 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6912 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6915 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6917 * xterm.c (x_set_frame_alpha): Do not set property on anything
6918 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6920 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6922 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6924 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6926 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6927 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6928 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6929 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6930 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6931 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6932 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6933 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6934 (Qgnutls_bootprop_callbacks_verify): Make static.
6936 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6938 * callproc.c: Indentation fixup.
6940 * sysdep.c (wait_for_termination_1): Make static.
6941 (wait_for_termination, interruptible_wait_for_termination):
6942 Move after wait_for_termination_1.
6944 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6946 * sysdep.c (interruptible_wait_for_termination): New function
6947 which is like wait_for_termination, but allows keyboard
6950 * callproc.c (Fcall_process): Add (:file "file") as an option for
6952 (Fcall_process_region): Ditto.
6954 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6956 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6957 rather than `XVECTOR (FOO)->size'.
6959 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6960 inttypes.h, as a gnulib replacement is used if it not available in
6963 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6965 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6966 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6967 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6969 * coding.c (coding_alloc_by_realloc): Error out if destination
6970 will grow beyond MOST_POSITIVE_FIXNUM.
6971 (decode_coding_emacs_mule): Abort if there isn't enough place in
6972 charbuf for the composition carryover bytes. Reserve an extra
6973 space for up to 2 characters produced in a loop.
6974 (decode_coding_iso_2022): Abort if there isn't enough place in
6975 charbuf for the composition carryover bytes.
6977 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6979 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6980 aborting when %lld or %lll format is passed.
6981 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6982 %llo or %llx format is passed. (Bug#8545)
6984 * window.c (window_scroll_line_based): Use a marker instead of
6985 simple variables to record original value of point. (Bug#7952)
6987 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6988 produced by %s or %c overflows available buffer space. (Bug#8545)
6990 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6992 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6993 (SIZE_MAX): Move defn after all includes, as they might #define it.
6995 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6997 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6999 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7001 * keyboard.c (Qdelayed_warnings_hook): Define.
7002 (command_loop_1): Run `delayed-warnings-hook'
7003 if Vdelayed_warnings_list is non-nil.
7004 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7005 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7007 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7009 * doprnt.c (doprnt): Don't return value smaller than the buffer
7010 size if the message was truncated. (Bug#8545).
7012 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7014 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7015 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7017 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7019 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7021 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7023 * makefile.w32-in: Update dependencies.
7025 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7027 Improve `doprnt' and its usage. (Bug#8545)
7028 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7029 `format_end'. Remove support for %l as a conversion specifier.
7030 Don't use xrealloc. Improve diagnostics when the %l size modifier
7031 is used. Update the commentary.
7033 * eval.c (verror): Simplify calculation of size_t.
7035 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7038 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7040 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7043 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7045 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7046 This makes this file independent of the recent pseudovector change.
7048 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7050 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7052 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7053 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7054 Remove unused local.
7055 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7057 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7058 GCC 4.6.0 optimizes based on type-based alias analysis.
7059 For example, if b is of type struct buffer * and v of type struct
7060 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7061 != &v->size, and therefore "v->size = 1; b->size = 2; return
7062 v->size;" must therefore return 1. This assumption is incorrect
7063 for Emacs, since it type-puns struct Lisp_Vector * with many other
7064 types. To fix this problem, this patch adds a new type struct
7065 vectorlike_header that documents the constraints on layout of vectors
7066 and pseudovectors, and helps optimizing compilers not get fooled
7067 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7068 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7069 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7071 (XSETPVECTYPE): Rewrite in terms of new macro.
7072 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7073 This is a bit clearer, and further avoids the possibility of
7074 undesirable aliasing.
7075 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7076 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7077 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7078 since Lisp_Subr is a special case (no "next" field).
7079 (ASIZE): Now uses header.size rather than size.
7080 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7081 to avoid the hassle of writing XVECTOR (foo)->header.size.
7082 (struct vectorlike_header): New type.
7083 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7084 object, to help avoid aliasing.
7085 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7086 (SUBRP): Likewise, since Lisp_Subr is a special case.
7087 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7088 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7089 (struct Lisp_Hash_Table): Combine first two members into a single
7090 struct vectorlike_header member. All uses of "size" and "next" members
7091 changed to be "header.size" and "header.next".
7092 * buffer.h (struct buffer): Likewise.
7093 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7094 * frame.h (struct frame): Likewise.
7095 * process.h (struct Lisp_Process): Likewise.
7096 * termhooks.h (struct terminal): Likewise.
7097 * window.c (struct save_window_data, struct saved_window): Likewise.
7098 * window.h (struct window): Likewise.
7099 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7100 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7101 * buffer.c (init_buffer_once): Likewise.
7102 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7104 * process.c (Fformat_network_address): Use local var for size,
7107 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7109 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7110 * data.c (atof): Remove decl; no longer used or needed.
7111 (digit_to_number): Move to lread.c.
7112 (Fstring_to_number): Use new string_to_number function, to be
7113 consistent with how the Lisp reader treats infinities and NaNs.
7114 Do not assume that floating-point numbers represent EMACS_INT
7115 without losing information; this is not true on most 64-bit hosts.
7116 Avoid double-rounding errors, by insisting on integers when
7117 parsing non-base-10 numbers, as the documentation specifies.
7118 * lisp.h (string_to_number): New decl, replacing ...
7119 (isfloat_string): Remove.
7120 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7121 (read1): Do not accept +. and -. as integers; this
7122 appears to have been a coding error. Similarly, do not accept
7123 strings like +-1e0 as floating point numbers. Do not report
7124 overflow for integer overflows unless the base is not 10 which
7125 means we have no simple and reliable way to continue.
7126 Break out the floating-point parsing into a new
7127 function string_to_number, so that Fstring_to_number parses
7128 floating point numbers consistently with the Lisp reader.
7129 (digit_to_number): Move here from data.c. Make it static inline.
7130 (E_CHAR, EXP_INT): Remove, replacing with ...
7131 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7132 (string_to_number): New function, replacing isfloat_string.
7133 This function checks for valid syntax and produces the resulting
7134 Lisp float number too. Rework it so that string-to-number
7135 no longer mishandles examples like "1.0e+". Use strtoumax,
7136 so that overflow for non-base-10 numbers is reported only when
7137 there's no portable and simple way to convert to floating point.
7139 * textprop.c (set_text_properties_1): Rewrite for clarity,
7140 and to avoid GCC warning about integer overflow.
7142 * intervals.h (struct interval): Use EMACS_INT for members
7143 where EMACS_UINT might cause problems. See
7144 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7145 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7146 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7148 (offset_intervals): Tell GCC not to worry about length overflow
7149 when negating a negative length.
7151 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7152 (overrun_check_free): Likewise.
7154 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7155 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7158 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7159 (gnutls_make_error): Rename local to avoid shadowing.
7160 (gnutls_emacs_global_deinit): ifdef out; not used.
7161 (Fgnutls_boot): Use const for pointer to readonly storage.
7162 Comment out unused local. Fix pointer signedness problems.
7164 * lread.c (openp): Don't stuff size_t into an 'int'.
7165 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7166 about possible signed overflow.
7168 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7169 (GDK_KEY_g): Don't define if already defined.
7170 (xg_prepare_tooltip): Avoid pointer signedness problem.
7171 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7173 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7174 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7176 * xfns.c (Fx_window_property): Simplify a bit,
7177 to make a bit faster and to avoid GCC 4.6.0 warning.
7178 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7180 * fns.c (internal_equal): Don't assume size_t fits in int.
7182 * alloc.c (compact_small_strings): Tighten assertion a little.
7184 Replace pEd with more-general pI, and fix some printf arg casts.
7185 * lisp.h (pI): New macro, generalizing old pEd macro to other
7186 conversion specifiers. For example, use "...%"pI"d..." rather
7187 than "...%"pEd"...".
7188 (pEd): Remove. All uses replaced with similar uses of pI.
7189 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7190 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7191 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7192 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7193 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7194 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7195 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7197 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7198 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7199 * print.c (safe_debug_print, print_object): Likewise.
7200 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7202 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7203 avoiding the 0 flag, which is not portable.
7204 * process.c (Fmake_network_process): Use pI to avoid cast.
7205 * region-cache.c (pp_cache): Likewise.
7206 * xdisp.c (decode_mode_spec): Likewise.
7207 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7208 behavior on 64-bit hosts with printf arg.
7209 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7210 (x_stop_queuing_selection_requests): Likewise.
7211 (x_get_window_property): Don't truncate byte count to an 'int'
7214 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7215 here, since it parses constructs like leading '-' and spaces,
7216 which are not wanted; and it overflows with large numbers.
7217 Instead, simply match F[0-9]+, which is what is wanted anyway.
7219 * alloc.c: Remove unportable assumptions about struct layout.
7220 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7221 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7222 (allocate_vectorlike, make_pure_vector): Use the new macros,
7223 plus offsetof, to remove unportable assumptions about struct layout.
7224 These assumptions hold on all porting targets that I know of, but
7225 they are not guaranteed, they're easy to remove, and removing them
7226 makes further changes easier.
7228 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7229 This doesn't fix a bug but makes the code clearer.
7230 (string_overrun_cookie): Now const. Use initializers that
7231 don't formally overflow signed char, to avoid warnings.
7232 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7233 can cause Emacs to crash when string overrun checking is enabled.
7234 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7235 multiple of sizeof (EMACS_INT); it need not be, if
7236 alignof(EMACS_INT) < sizeof (EMACS_INT).
7237 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7239 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7241 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7243 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7245 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7246 supposed to be handshaking. (Bug#8556)
7247 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7249 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7251 * lisp.h (Qdebug): List symbol.
7252 * eval.c (Qdebug): Restore global linkage.
7253 * keyboard.c (debug-on-event): New variable.
7254 (handle_user_signal): Break into debugger when debug-on-event
7255 matches the current signal symbol.
7257 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7259 * alloc.c (check_sblock, check_string_bytes)
7260 (check_string_free_list): Convert to standard C.
7262 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7264 * w32.c (emacs_gnutls_push): Fix typo.
7266 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7268 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7269 "cast to pointer from integer of different size".
7271 Improve doprnt and its use in verror. (Bug#8545)
7272 * doprnt.c (doprnt): Document the set of format control sequences
7273 supported by the function. Use SAFE_ALLOCA instead of always
7276 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7277 is one byte too soon. Don't use xrealloc; instead xfree and
7280 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7282 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7285 * gnutls.c: Renamed global_initialized to
7286 gnutls_global_initialized. Added internals for the
7287 :verify-hostname-error, :verify-error, and :verify-flags
7288 parameters of `gnutls-boot' and documented those parameters in the
7289 docstring. Start callback support.
7290 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7291 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7292 on error. Return error code.
7293 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7294 (emacs_gnutls_read): Likewise.
7295 (Fgnutls_boot): Return handshake error code.
7296 (emacs_gnutls_handle_error): New function.
7297 (wsaerror_to_errno): Likewise.
7299 * w32.h (emacs_gnutls_pull): Add prototype.
7300 (emacs_gnutls_push): Likewise.
7302 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7303 (emacs_gnutls_push): Likewise.
7305 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7307 * process.c (wait_reading_process_output): Check if GnuTLS
7308 buffered some data internally if no FDs are set for TLS
7311 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7312 (LIBS): Link to USER_LIBS.
7313 ($(BLD)/gnutls.$(0)): New target.
7315 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7317 * xdisp.c (handle_single_display_spec): Rename the
7318 display_replaced_before_p argument into display_replaced_p, to
7319 make it consistent with the commentary. Fix typos in the
7322 * textprop.c (syms_of_textprop): Remove dead code.
7323 (copy_text_properties): Delete obsolete commentary about an
7324 interface that was deleted long ago. Fix typos in the description
7327 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7328 to changes in oldXMenu/XMenu.h from 2011-04-16.
7329 <menu_help_message, prev_menu_help_message>: Constify.
7330 (IT_menu_make_room): menu->help_text is now `const char **';
7333 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7334 to changes in oldXMenu/XMenu.h from 2011-04-16.
7335 (struct XMenu): Declare `help_text' `const char **'.
7337 * xfaces.c <Qunspecified>: Make extern again.
7339 * syntax.c: Include sys/types.h before including regex.h, as
7342 * doc.c (get_doc_string): Improve the format passed to `error'.
7344 * doprnt.c (doprnt): Improve commentary.
7346 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7348 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7351 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7352 changes in globals.h immediately force recompilation.
7353 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7354 $(CURDIR)/s/ms-w32.h.
7355 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7357 * character.c (Fchar_direction): Function deleted.
7358 (syms_of_character): Don't defsubr it.
7359 <char-direction-table>: Deleted.
7361 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7363 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7364 * doprnt.c: Include limits.h.
7365 (SIZE_MAX): New macro.
7366 (doprnt): Return a size_t value. 2nd arg is now size_t.
7367 Many local variables are now size_t instead of int or unsigned.
7368 Improve overflow protection. Support `l' modifier for integer
7369 conversions. Support %l conversion. Don't assume an EMACS_INT
7370 argument for integer conversions and for %c.
7372 * lisp.h (doprnt): Restore prototype.
7374 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7377 * Makefile.in (base_obj): Add back doprnt.o.
7379 * deps.mk (doprnt.o): Add back prerequisites.
7380 (callint.o): Depend on character.h.
7382 * eval.c (internal_lisp_condition_case): Include the handler
7383 representation in the error message.
7384 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7385 when breaking from the loop.
7387 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7389 * callint.c (Fcall_interactively): When displaying error message
7390 about invalid control letter, pass the character's codepoint, not
7391 a pointer to its multibyte form. Improve display of the character
7392 in octal and display also its hex code.
7394 * character.c (char_string): Use %x to display the (unsigned)
7395 codepoint of an invalid character, to avoid displaying a bogus
7398 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7399 `error', not SYMBOL_NAME itself.
7401 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7402 character arguments to `error'.
7404 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7405 to `error' in error message about FINAL_CHAR argument. Make sure
7406 FINAL_CHAR is a character, and use %c when it is passed as
7407 argument to `error'.
7409 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7411 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7413 * w32.c: Include <time.h>.
7414 (sys_localtime): New function.
7416 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7418 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7420 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7422 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7424 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7427 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7429 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7430 gl_state.e_property when gl_state.object is Qt.
7432 * insdel.c (make_gap_larger): Remove limitation of buffer size
7435 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7437 * xdisp.c (lookup_glyphless_char_display)
7438 (produce_glyphless_glyph): Handle cons cell entry in
7439 glyphless-char-display.
7440 (Vglyphless_char_display): Document it.
7442 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7443 glyphless-char-display.
7445 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7447 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7449 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7451 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7452 definition for no-X builds.
7454 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7456 Static checks with GCC 4.6.0 and non-default toolkits.
7458 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7460 * process.c (keyboard_bit_set): Define only if SIGIO.
7461 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7462 (send_process): Repair possible setjmp clobbering.
7464 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7466 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7468 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7470 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7471 Define only if needed.
7473 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7474 by pacifying GCC about it. Maybe it's time to retire it?
7475 * xfaces.c (USG, __TIMEVAL__): Likewise.
7477 * dispextern.h (struct redisplay_interface): Rename param
7479 * termhooks.h (struct terminal): Likewise.
7480 * xterm.c (xembed_send_message): Likewise.
7482 * insdel.c (make_gap_smaller): Define only if
7483 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7485 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7488 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7489 so that we aren't warned about unused symbols.
7491 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7493 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7495 * xfns.c (x_real_positions): Mark locals as initialized.
7497 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7499 * xterm.c: Fix problems found by static analysis with other toolkits.
7500 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7501 (x_dispatch_event): Declare static if USE_GTK, and
7502 define if USE_GTK || USE_X_TOOLKIT.
7503 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7504 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7505 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7506 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7508 * xmenu.c (menu_help_callback): Pointer type fixes.
7509 Use const pointers when pointing at readonly data. Avoid pointer
7511 (FALSE): Remove unused macro.
7512 (update_frame_menubar): Remove unused decl.
7514 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7516 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7517 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7518 (single_menu_item): Rename local to avoid shadowing.
7520 * keyboard.c (make_lispy_event): Remove unused local var.
7522 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7523 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7525 * bitmaps: Change bitmaps from unsigned char back to the X11
7526 compatible char. Avoid the old compiler warnings about
7527 out-of-range initializers by using, for example, '\xab' rather
7530 * xgselect.c (xgselect_initialize): Check vs interface
7531 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7533 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7535 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7536 to read-only memory.
7538 * fns.c (vector): Remove; this old hack is no longer needed.
7540 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7542 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7544 * xrdb.c (x_load_resources): Omit unused local.
7546 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7547 (x_window): Rename locals to avoid shadowing.
7548 (USG): Use the kludged USG macro, to pacify gcc.
7550 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7551 (x_term_init): Remove local to avoid shadowing.
7553 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7555 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7556 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7558 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7560 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7562 Fix regex.c, syntax.c and friends for buffers > 2GB.
7563 * syntax.h (struct gl_state_s): Declare character position members
7566 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7568 * textprop.c (verify_interval_modification, interval_of):
7569 Declare arguments EMACS_INT.
7571 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7574 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7576 * indent.c (Fvertical_motion): Local variable it_start is now
7579 * regex.c (re_match, re_match_2, re_match_2_internal)
7580 (bcmp_translate, regcomp, regexec, print_double_string)
7581 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7582 (re_compile_pattern, re_exec): Declare arguments and local
7583 variables `size_t' and `ssize_t' and return values `regoff_t', as
7585 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7586 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7587 <compile_stack_type>: `size' and `avail' are now `size_t'.
7589 * regex.h <regoff_t>: Use ssize_t, not int.
7590 (re_search, re_search_2, re_match, re_match_2): Arguments that
7591 specify buffer/string position and length are now ssize_t and
7592 size_t. Return type is regoff_t.
7594 2011-04-16 Ben Key <bkey76@gmail.com>
7596 * nsfont.m: Fixed bugs in ns_get_family and
7597 ns_descriptor_to_entity that were caused by using free to
7598 deallocate memory blocks that were allocated by xmalloc (via
7599 xstrdup). This caused Emacs to crash when compiled with
7600 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7601 --enable-checking=xmallocoverrun). xfree is now used to
7602 deallocate these memory blocks.
7604 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7606 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7608 emacs_write: Accept and return EMACS_INT for sizes.
7609 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7611 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7612 Accept and return EMACS_INT.
7613 (emacs_gnutls_write): Return the number of bytes written on
7615 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7616 (emacs_read, emacs_write): Remove check for negative size, as the
7617 Emacs source code has been audited now.
7618 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7619 (emacs_read, emacs_write): Use it.
7620 * process.c (send_process): Adjust to the new signatures of
7621 emacs_write and emacs_gnutls_write. Do not attempt to store
7622 a byte offset into an 'int'; it might overflow.
7623 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7625 * sound.c: Don't assume sizes fit in 'int'.
7626 (struct sound_device.period_size, alsa_period_size):
7627 Return EMACS_INT, not int.
7628 (struct sound_device.write, vox_write, alsa_write):
7629 Accept EMACS_INT, not int.
7630 (wav_play, au_play): Use EMACS_INT to store sizes and to
7631 record read return values.
7633 2011-04-15 Ben Key <bkey76@gmail.com>
7635 * keyboard.c (Qundefined): Don't declare static since it is used
7637 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7638 static since they are used in nsfont.m.
7640 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7642 * process.c (Qprocessp): Don't declare static.
7643 * lisp.h (Qprocessp): Declare again.
7645 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7647 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7649 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7651 Improve C-level modularity by making more things 'static'.
7653 Don't publish debugger-only interfaces to other modules.
7654 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7655 (verify_bytepos, count_markers): Move decls to the only modules
7657 * region-cache.h (pp_cache): Likewise.
7658 * window.h (check_all_windows): Likewise.
7659 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7661 * sysdep.c (croak): Now static, if
7662 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7663 * syssignal.h (croak): Declare only if not static.
7665 * alloc.c (refill_memory_reserve): Now static if
7666 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7667 * lisp.h (refill_memory_reserve): Declare only if not static.
7669 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7670 Define only if USE_LUCID.
7672 * xrdb.c (x_customization_string, x_rm_string): Now static.
7674 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7675 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7677 * xdisp.c (draw_row_with_mouse_face): Now static.
7678 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7680 * window.h (check_all_windows): Mark externally visible.
7682 * window.c (window_deletion_count): Now static.
7684 * undo.c: Make symbols static if they're not exported.
7685 (last_undo_buffer, last_boundary_position, pending_boundary):
7688 * textprop.c (interval_insert_behind_hooks): Now static.
7689 (interval_insert_in_front_hooks): Likewise.
7691 * term.c: Make symbols static if they're not exported.
7692 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7693 (max_frame_lines, tty_set_terminal_modes):
7694 (tty_reset_terminal_modes, tty_turn_off_highlight):
7695 (get_tty_terminal): Now static.
7696 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7697 * termhooks.h (term_mouse_moveto): Do not declare if
7699 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7700 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7702 * sysdep.c: Make symbols static if they're not exported.
7703 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7705 (sigprocmask_set, full_mask): Remove; unused.
7706 (wait_debugging): Mark as visible.
7707 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7708 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7710 * syntax.c (syntax_temp): Define only if !__GNUC__.
7712 * sound.c (current_sound_device, current_sound): Now static.
7714 * search.c (searchbufs, searchbuf_head): Now static.
7716 * scroll.c (scroll_cost): Remove; unused.
7717 * dispextern.h (scroll_cost): Remove decl.
7719 * region-cache.h (pp_cache): Mark as externally visible.
7721 * process.c: Make symbols static if they're not exported.
7722 (process_tick, update_tick, create_process, chan_process):
7723 (Vprocess_alist, proc_buffered_char, datagram_access):
7724 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7725 (deactivate_process): Mark defn as static, as well as decl.
7726 * lisp.h (create_process): Remove decl.
7727 * process.h (chan_process, Vprocess_alist): Remove decls.
7729 * print.c: Make symbols static if they're not exported.
7730 (print_depth, new_backquote_output, being_printed, print_buffer):
7731 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7732 (print_interval, print_number_index, initial_stderr_stream):
7734 * lisp.h (Fprinc): Remove decl.
7735 (debug_output_compilation_hack): Mark as externally visible.
7737 * sysdep.c (croak): Move decl from here to syssignal.h.
7738 * syssignal.h (croak): Put it here, so the API can be checked when
7739 'croak' is called from dissociate_if_controlling_tty.
7741 * minibuf.c: Make symbols static if they're not exported.
7742 (minibuf_save_list, choose_minibuf_frame): Now static.
7743 * lisp.h (choose_minibuf_frame): Remove decl.
7745 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7747 * lread.c: Make symbols static if they're not exported.
7748 (read_objects, initial_obarray, oblookup_last_bucket_number):
7750 (make_symbol): Remove; unused.
7751 * lisp.h (initial_obarray, make_symbol): Remove decls.
7753 * keyboard.c: Make symbols static if they're not exported.
7754 (single_kboard, recent_keys_index, total_keys, recent_keys):
7755 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7756 (this_single_command_key_start, echoing, last_auto_save):
7757 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7758 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7759 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7760 (Vlispy_mouse_stem, double_click_count):
7762 (force_auto_save_soon): Define only if SIGDANGER.
7763 (ignore_mouse_drag_p): Now static if
7764 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7765 (print_help): Remove; unused.
7766 (stop_character, last_timer_event): Mark as externally visible.
7767 * keyboard.h (ignore_mouse_drag_p): Declare only if
7768 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7769 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7770 * lisp.h (echoing): Remove decl.
7771 (force_auto_save_soon): Declare only if SIGDANGER.
7772 * xdisp.c (redisplay_window): Simplify code, to make it more
7773 obvious that ignore_mouse_drag_p is not accessed if !defined
7774 USE_GTK && !defined HAVE_NS.
7776 * intervals.c: Make symbols static if they're not exported.
7777 (merge_properties_sticky, merge_interval_right, delete_interval):
7779 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7781 * insdel.c: Make symbols static if they're not exported.
7782 However, leave prepare_to_modify_buffer alone. It's never
7783 called from outside this function, but that appears to be a bug.
7784 (combine_after_change_list, combine_after_change_buffer):
7785 (adjust_after_replace, signal_before_change): Now static.
7786 (adjust_after_replace_noundo): Remove; unused.
7787 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7788 (signal_before_change): Remove decls.
7790 * indent.c (val_compute_motion, val_vmotion): Now static.
7792 * image.c: Make symbols static if they're not exported.
7793 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7795 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7796 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7798 * fringe.c (standard_bitmaps): Now static.
7799 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7801 * frame.c: Make symbols static if they're not exported.
7802 (x_report_frame_params, make_terminal_frame): Now static.
7803 (get_frame_param): Now static, unless HAVE_NS.
7804 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7805 (x_get_resource_string): Remove; not used.
7806 * frame.h (make_terminal_frame, x_report_frame_params):
7807 (x_get_resource_string); Remove decls.
7808 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7809 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7811 * font.c, fontset.c: Make symbols static if they're not exported.
7812 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7813 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7814 * font.c (font_close_object): Now static.
7815 * font.h (font_close_object): Remove.
7816 * fontset.c (FONTSET_OBJLIST): Remove.
7817 (free_realized_fontset) #if-0 the body, which does nothing.
7818 (face_suitable_for_char_p): #if-0, as it's never called.
7819 * fontset.h (face_suitable_for_char_p): Remove decl.
7820 * xfaces.c (face_at_string_position):
7821 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7822 since 0 is always ASCII.
7824 * fns.c (weak_hash_tables): Now static.
7826 * fileio.c: Make symbols static if they're not exported.
7827 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7828 (Vwrite_region_annotation_buffers): Now static.
7830 * eval.c: Make symbols static if they're not exported.
7831 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7832 * lisp.h (backtrace_list): Remove decl.
7834 * emacs.c: Make symbols static if they're not exported.
7835 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7836 (fatal_error_code, fatal_error_signal_hook, standard_args):
7838 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7839 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7840 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7841 * lisp.h (fatal_error_signal_hook): Remove decl.
7842 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7844 * editfns.c: Move a (normally-unused) function to its only use.
7845 * editfns.c, lisp.h (get_operating_system_release): Remove.
7846 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7847 worth the hassle of breaking this out.
7849 * xterm.c: Make symbols static if they're not exported.
7850 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7851 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7852 (x_destroy_window, x_delete_display):
7854 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7855 (x_mouse_leave): Remove; unused.
7856 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7857 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7858 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7860 (x_mouse_leave): Declare only if WINDOWSNT.
7861 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7862 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7865 * ftxfont.c: Make symbols static if they're not exported.
7866 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7868 * font.h (ftxfont_driver): Likewise.
7870 * xfns.c: Make symbols static if they're not exported.
7871 (x_last_font_name, x_display_info_for_name):
7872 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7873 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7874 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7875 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7876 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7877 (last_show_tip_args): Now static.
7878 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7879 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7880 (x_screen_planes): Remove; unused.
7881 * dispextern.h (x_screen_planes): Remove decl.
7883 * dispnew.c: Make symbols static if they're not exported.
7884 * dispextern.h (redraw_garbaged_frames, scrolling):
7885 (increment_row_positions): Remove.
7886 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7887 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7889 (redraw_garbaged_frames): Remove; unused.
7891 * xfaces.c: Make symbols static if they're not exported.
7892 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7894 * xterm.h (defined_color): Remove decls.
7895 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7896 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7897 (menu_face_changed_default, defined_color, free_realized_face):
7898 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7899 (ascii_face_of_lisp_face): Remove; unused.
7901 * xdisp.c: Make symbols static if they're not exported.
7902 * dispextern.h (scratch_glyph_row, window_box_edges):
7903 (glyph_to_pixel_coords, set_cursor_from_row):
7904 (get_next_display_element, set_iterator_to_next):
7905 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7906 (show_mouse_face): Remove decls
7907 * frame.h (message_buf_print): Likewise.
7908 * lisp.h (pop_message, set_message, check_point_in_composition):
7910 * xterm.h (set_vertical_scroll_bar): Likewise.
7911 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7912 (message_buf_print, scratch_glyph_row, displayed_buffer):
7913 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7914 (get_next_display_element, show_mouse_face, window_box_edges):
7915 (frame_to_window_pixel_xy, check_point_in_composition):
7916 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7917 (glyph_to_pixel_coords): Remove; unused.
7919 * dired.c (file_name_completion): Now static.
7921 * dbusbind.c (xd_in_read_queued_messages): Now static.
7923 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7924 * data.c (circular_list_error): Remove.
7926 * commands.h (last_point_position, last_point_position_buffer):
7927 (last_point_position_window): Remove decls.
7928 * keyboard.c: Make these variables static.
7930 * coding.h (coding, code_convert_region, encode_coding_gap):
7932 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7933 (iso_code_class, detect_coding, code_convert_region): Now static.
7934 (encode_coding_gap): Remove; unused.
7936 * chartab.c (chartab_chars, chartab_bits): Now static.
7938 * charset.h (charset_iso_8859_1): Remove decl.
7939 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7942 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7943 * ccl.c (Vccl_program_table): Now static.
7944 (check_ccl_update): Remove; unused.
7946 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7947 * category.h: ... from here.
7948 * category.c (check_category_table, set_category_set): Now static.
7950 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7951 * lisp.h: Remove these decls.
7953 * buffer.c (buffer_count): Remove unused var.
7955 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7956 so that it's not optimized away.
7957 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7958 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7959 exported only to the debugger.
7961 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7962 * atimer.h (run_all_atimers): Remove; not exported.
7964 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7965 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7966 was inaccessible from Lisp.
7967 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7968 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7970 alloc.c: Import and export fewer symbols, and remove unused items.
7971 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7973 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7974 it's not optimized away by whole-program optimization.
7975 (message_enable_multibyte, free_misc): Remove.
7976 (catchlist, handlerlist, mark_backtrace):
7977 Declare only if BYTE_MARK_STACK.
7978 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7979 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7980 (message_enable_multibyte): Remove decl.
7981 (free_misc, interval_free_list, float_block, float_block_index):
7982 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7983 (cons_free_list, last_marked_index):
7985 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7986 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7987 (mark_backtrace): Define only if BYTE_MARK_STACK.
7988 * xdisp.c (message_enable_multibyte): Now static.
7990 Declare Lisp_Object Q* variables to be 'static' if not exported.
7991 This makes it easier for human readers (and static analyzers)
7992 to see whether these variables are used from other modules.
7993 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7994 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7995 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7996 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7997 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7998 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7999 * xmenu.c, xselect.c:
8000 Declare Q* vars static if they are not used in other modules.
8001 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8002 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8003 Remove decls of unexported vars.
8004 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8006 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8008 Make Emacs functions such as Fatom 'static' by default.
8009 This makes it easier for human readers (and static analyzers)
8010 to see whether these functions can be called from other modules.
8011 DEFUN now defines a static function. To make the function external
8012 so that it can be used in other C modules, use the new macro DEFUE.
8013 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8014 (Finit_image_library):
8015 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8016 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8017 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8018 Remove decls, since these functions are now static.
8019 (Funintern, Fget_internal_run_time): New decls, since these functions
8020 were already external.
8022 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8023 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8024 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8025 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8026 * keyboard.c, keymap.c, lread.c:
8027 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8028 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8029 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8030 Mark functions with DEFUE instead of DEFUN,
8031 if they are used in other modules.
8032 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8033 decls for now-static functions.
8034 * buffer.h (Fdelete_overlay): Remove decl.
8035 * callproc.c (Fgetenv_internal): Mark as internal.
8036 * composite.c (Fremove_list_of_text_properties): Remove decl.
8037 (Fcomposition_get_gstring): New forward static decl.
8038 * composite.h (Fcomposite_get_gstring): Remove decl.
8039 * dired.c (Ffile_attributes): New forward static decl.
8040 * doc.c (Fdocumntation_property): New forward static decl.
8041 * eval.c (Ffetch_bytecode): New forward static decl.
8042 (Funintern): Remove extern decl; now in .h file where it belongs.
8043 * fileio.c (Fmake_symbolic_link): New forward static decl.
8044 * image.c (Finit_image_library): New forward static decl.
8045 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8046 * intervals.h (Fprevious_property_change):
8047 (Fremove_list_of_text_properties): Remove decls.
8048 * keyboard.c (Fthis_command_keys): Remove decl.
8049 (Fcommand_execute): New forward static decl.
8050 * keymap.c (Flookup_key): New forward static decl.
8051 (Fcopy_keymap): Now static.
8052 * keymap.h (Flookup_key): Remove decl.
8053 * process.c (Fget_process): New forward static decl.
8054 (Fprocess_datagram_address): Mark as internal.
8055 * syntax.c (Fsyntax_table_p): New forward static decl.
8056 (skip_chars): Remove duplicate decl.
8057 * textprop.c (Fprevious_property_change): New forward static decl.
8058 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8060 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8061 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8063 * editfns.c (Fformat): Remove unreachable code.
8065 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8067 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8070 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8072 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8073 when at ZV. (Bug#8487)
8075 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8077 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8079 * keyboard.c (parse_tool_bar_item): Likewise.
8080 * sound.c (sound_cleanup, alsa_close): Likewise.
8081 * termcap.c (tgetent): Likewise.
8082 * xfns.c (x_default_font_parameter): Likewise.
8083 * xsettings.c (read_and_apply_settings): Likewise.
8085 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8086 (overrun_check_free): Protoize.
8088 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8090 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8091 since callers should never pass a negative size.
8092 Change the signature to match that of plain 'read' and 'write'; see
8093 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8094 * lisp.h: Update prototypes of emacs_write and emacs_read.
8096 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8098 * xdisp.c (redisplay_window): Don't try to determine the character
8099 position of the scroll margin if the window start point w->startp
8100 is outside the buffer's accessible region. (Bug#8468)
8102 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8104 Fix write-region and its subroutines for buffers > 2GB.
8105 * fileio.c (a_write, e_write): Modify declaration of arguments and
8106 local variables to support buffers larger than 2GB.
8107 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8109 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8110 argument, local variables, and return value.
8112 * lisp.h: Update prototypes of emacs_write and emacs_read.
8114 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8116 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8118 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8120 Fix more problems found by GCC 4.6.0's static checks.
8122 * xdisp.c (vmessage): Use a better test for character truncation.
8124 * charset.c (load_charset_map): <, not <=, for optimization,
8125 and to avoid potential problems with integer overflow.
8126 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8127 * casetab.c (set_identity, shuffle): Likewise.
8128 * editfns.c (Fformat): Likewise.
8129 * syntax.c (skip_chars): Likewise.
8131 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8132 This also lets GCC 4.6.0 generate slightly better loop code.
8134 * callint.c (Fcall_interactively): <, not <=, for optimization.
8135 (Fcall_interactively): Count the number of arguments produced,
8136 not the number of arguments given. This is simpler and lets GCC
8137 4.6.0 generate slightly better code.
8139 * ftfont.c: Distingish more carefully between FcChar8 and char.
8140 The previous code passed unsigned char * to a functions like
8141 strlen and xstrcasecmp that expect char *, which does not
8142 conform to the C standard.
8143 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8144 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8145 char * when the C standard requires it.
8147 * keyboard.c (read_char): Remove unused var.
8149 * eval.c: Port to Windows vsnprintf (Bug#8435).
8151 (SIZE_MAX): Define if the headers do not.
8152 (verror): Do not give up if vsnprintf returns a negative count.
8153 Instead, grow the buffer. This ports to Windows vsnprintf, which
8154 does not conform to C99. Problem reported by Eli Zaretskii.
8155 Also, simplify the allocation scheme, by avoiding the need for
8156 calling realloc, and removing the ALLOCATED variable.
8158 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8160 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8161 But keep the doprint source code for now, as we might revamp it
8162 and use it again (Bug#8435).
8163 * lisp.h (doprnt): Remove.
8164 * Makefile.in (base_obj): Remove doprnt.o.
8165 * deps.mk (doprnt.o): Remove.
8167 error: Print 32- and 64-bit integers portably (Bug#8435).
8168 Without this change, on typical 64-bit hosts error ("...%d...", N)
8169 was used to print both 32- and 64-bit integers N, which relied on
8171 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8172 * lisp.h (error, verror): Mark as printf-like functions.
8173 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8174 Report overflow in size calculations when allocating printf buffer.
8175 Do not truncate output string at its first null byte.
8176 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8177 Truncate the output at a character boundary, since vsnprintf does not
8179 * charset.c (check_iso_charset_parameter): Convert internal
8180 character to string before calling 'error', since %c now has the
8182 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8183 overflow when computing char to be passed to 'error'. Do not
8184 pass Lisp_Object to 'error'; pass the integer instead.
8185 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8186 formatted with plain %d.
8188 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8190 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8192 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8194 * xterm.c (x_catch_errors): Remove duplicate declaration.
8196 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8198 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8200 2011-04-10 Jim Meyering <meyering@redhat.com>
8202 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8203 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8204 return ssize_t not "int", and use size_t as the buffer length.
8205 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8206 * gnutls.h: Update declarations.
8207 * process.c (read_process_output): Use ssize_t, to match.
8208 (send_process): Likewise.
8210 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8212 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8214 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8216 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8217 Use unsigned char, to match FcChar8 type definition.
8219 * xterm.c (handle_one_xevent):
8220 * xmenu.c (create_and_show_popup_menu):
8221 * xselect.c (x_decline_selection_request)
8222 (x_reply_selection_request): Avoid type-punned deref of X events.
8224 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8226 Fix some uses of `int' instead of EMACS_INT.
8227 * search.c (string_match_1, fast_string_match)
8228 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8229 (scan_buffer, find_next_newline_no_quit)
8230 (find_before_next_newline, search_command, Freplace_match)
8231 (Fmatch_data): Make some `int' variables be EMACS_INT.
8233 * xdisp.c (display_count_lines): 3rd argument and return value now
8234 EMACS_INT. All callers changed.
8235 (pint2hrstr): Last argument is now EMACS_INT.
8237 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8238 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8239 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8240 (decode_coding_utf_16, decode_coding_emacs_mule)
8241 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8242 (decode_coding_ccl, decode_coding_charset)
8243 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8244 (decode_coding_iso_2022, decode_coding_emacs_mule)
8245 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8246 <char_offset, last_offset>: Declare EMACS_INT.
8247 (encode_coding_utf_8, encode_coding_utf_16)
8248 (encode_coding_emacs_mule, encode_invocation_designation)
8249 (encode_designation_at_bol, encode_coding_iso_2022)
8250 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8251 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8253 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8254 (encode_invocation_designation): Last argument P_NCHARS is now
8256 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8257 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8259 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8262 * ccl.c (Fccl_execute_on_string): Declare some variables
8265 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8267 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8269 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8271 * process.c (Fformat_network_address): Doc fix.
8273 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8275 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8277 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8279 * keyboard.c (read_char): Call Lisp function help-form-show,
8280 instead of using internal_with_output_to_temp_buffer.
8281 (Qhelp_form_show): New var.
8282 (syms_of_keyboard): Use DEFSYM macro.
8284 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8286 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8288 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8290 * process.c (Flist_processes): Remove to Lisp.
8291 (list_processes_1): Delete.
8293 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8295 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8297 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8299 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8301 Fix more problems found by GCC 4.6.0's static checks.
8303 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8305 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8307 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8309 * xdisp.c (vmessage): Mark as a printf-like function.
8311 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8313 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8315 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8316 printf-like functions.
8317 (tiff_load): Add casts to remove these marks before passing them
8318 to system-supplied API.
8320 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8322 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8323 This avoids several warnings with gcc -Wstrict-overflow.
8324 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8325 directly, rather than having caller test rule sign. This avoids
8326 some unnecessary tests.
8327 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8328 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8329 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8331 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8332 (xfont_open): Avoid unnecessary tests.
8334 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8336 * composite.h, composite.c (composition_gstring_put_cache):
8337 Use EMACS_INT, not int, for length.
8339 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8340 breaking out part of COMPOSITION_DECODE_RULE.
8341 (COMPOSITION_DECODE_RULE): Use it.
8342 * composite.c (get_composition_id): Remove unused local vars,
8343 by using the new macro.
8345 * textprop.c (set_text_properties_1): Change while to do-while,
8346 since the condition is always true at first.
8348 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8349 (interval_deletion_adjustment): Return unsigned value.
8352 * process.c (list_processes_1, create_pty, read_process_output):
8353 (exec_sentinel): Remove vars that were set but not used.
8354 (create_pty): Remove unnecessary "volatile"s.
8355 (Fnetwork_interface_info): Avoid possibility of int overflow.
8356 (read_process_output): Do adaptive read buffering even if carryover.
8357 (read_process_output): Simplify nbytes computation if buffered.
8359 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8361 * syntax.c (scan_words): Remove var that was set but not used.
8362 (update_syntax_table): Use unsigned instead of int.
8364 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8365 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8366 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8368 * print.c (print_error_message): Avoid int overflow.
8370 * font.c (font_list_entities): Redo for clarity,
8371 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8373 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8374 (font_score): Avoid potential overflow in diff calculation.
8376 * fns.c (substring_both): Remove var that is set but not used.
8377 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8379 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8381 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8382 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8383 can always succeed if overflow has undefined behavior.
8385 * search.c (boyer_moore, wordify): Remove vars set but not used.
8386 (wordify): Omit three unnecessary tests.
8388 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8389 All callers changed. This avoids the need for an unused var.
8391 * casefiddle.c (casify_region): Remove var that is set but not used.
8393 * dired.c (file_name_completion): Remove var that is set but not used.
8395 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8397 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8398 (Finsert_file_contents): Remove unnecessary code checking fd.
8400 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8401 Check for integer overflow on size calculations.
8403 * buffer.c (Fprevious_overlay_change): Remove var that is set
8406 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8407 Remove vars that are set but not used.
8408 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8409 (timer_check_2): Mark vars as initialized.
8411 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8413 * image.c (lookup_image): Remove var that is set but not used.
8414 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8416 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8417 that are set but not used.
8419 * xfns.c (make_invisible_cursor): Don't return garbage
8420 if XCreateBitmapFromData fails (Bug#8410).
8422 * xselect.c (x_get_local_selection, x_handle_property_notify):
8423 Remove vars that are set but not used.
8425 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8426 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8428 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8429 Remove var that is set but not used.
8430 (scroll_bar_windows_size): Now size_t, not int.
8431 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8434 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8435 (map_tty_color) [!defined MSDOS]: Likewise.
8437 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8439 * coding.c: Remove vars that are set but not used.
8440 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8441 All callers changed.
8442 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8443 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8444 (decode_coding_charset): Remove vars that are set but not used.
8446 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8447 that is set but not used.
8449 * print.c (print_object): Remove var that is set but not used.
8451 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8452 The gnulib version avoids calling malloc in the usual case,
8453 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8454 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8455 * filelock.c (current_lock_owner): Likewise.
8456 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8457 * sysdep.c: Include allocator.h, careadlinkat.h.
8458 (emacs_no_realloc_allocator): New static constant.
8459 (emacs_readlink): New function.
8460 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8461 ../lib/careadlinkat.h.
8463 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8465 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8466 first non-nil return value).
8468 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8470 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8471 if not defined (Bug#8403).
8473 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8475 * xdisp.c (display_count_lines): Remove parameter `start',
8476 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8477 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8478 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8479 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8480 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8481 and thereabouts. All callers changed.
8482 (get_per_char_metric): Remove parameter `f', unused since
8483 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8485 2011-04-02 Jim Meyering <meyering@redhat.com>
8487 do not dereference NULL upon failed strdup
8488 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8489 (ns_get_family): Likewise.
8491 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8493 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8495 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8497 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8500 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8502 Add lexical binding.
8504 * window.c (Ftemp_output_buffer_show): New fun.
8505 (Fsave_window_excursion):
8506 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8508 * lread.c (lisp_file_lexically_bound_p): New function.
8509 (Fload): Bind Qlexical_binding.
8510 (readevalloop): Remove `evalfun' arg.
8511 Bind Qinternal_interpreter_environment.
8512 (Feval_buffer): Bind Qlexical_binding.
8513 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8515 (syms_of_lread): Declare `lexical-binding'.
8517 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8519 * keyboard.c (eval_dyn): New fun.
8520 (menu_item_eval_property): Use it.
8522 * image.c (parse_image_spec): Use Ffunctionp.
8524 * fns.c (concat, mapcar1): Accept byte-code-functions.
8526 * eval.c (Fsetq): Handle lexical vars.
8527 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8528 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8529 (FletX, Flet): Obey lexical binding.
8530 (Fcommandp): Handle closures.
8531 (Feval): New `lexical' arg.
8532 (eval_sub): New function extracted from Feval. Use it almost
8533 everywhere where Feval was used. Look up vars in lexical env.
8535 (Ffunctionp): Move from subr.el.
8536 (Ffuncall): Handle closures.
8537 (apply_lambda): Remove `eval_flags'.
8538 (funcall_lambda): Handle closures and new byte-code-functions.
8539 (Fspecial_variable_p): New function.
8540 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8541 but without exporting it to Lisp.
8543 * doc.c (Fdocumentation, store_function_docstring):
8544 * data.c (Finteractive_form): Handle closures.
8546 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8549 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8551 (exec_byte_code): New function extracted from Fbyte_code to handle new
8552 calling convention for byte-code-functions. Add new byte-codes.
8554 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8556 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8558 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8560 * xdisp.c (redisplay_internal): Fix prototype.
8562 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8564 * xdisp.c (SCROLL_LIMIT): New macro.
8565 (try_scrolling): Use it when setting scroll_limit.
8566 Limit scrolling to 100 screen lines.
8567 (redisplay_window): Even when falling back on "recentering",
8568 position point in the window according to scroll-conservatively,
8569 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8571 (try_scrolling): When point is above the window, allow searching
8572 as far as scroll_max, or one screenful, to compute vertical
8573 distance from PT to the scroll margin position. This prevents
8574 try_scrolling from unnecessarily failing when
8575 scroll-conservatively is set to a value slightly larger than the
8576 window height. Clean up the case of PT below the margin at bottom
8577 of window: scroll_max can no longer be INT_MAX. When aggressive
8578 scrolling is in use, don't let point enter the opposite scroll
8579 margin as result of the scroll.
8580 (syms_of_xdisp) <scroll-conservatively>: Document the
8581 threshold of 100 lines for never-recentering scrolling.
8583 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8585 * dispextern.h (move_it_by_lines):
8586 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8587 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8588 (message_log_check_duplicate): Remove parameters `prev_bol' and
8589 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8590 (redisplay_internal): Remove parameter `preserve_echo_area',
8591 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8593 * indent.c (Fvertical_motion):
8594 * window.c (window_scroll_pixel_based, Frecenter):
8595 Don't pass `need_y_p' to `move_it_by_lines'.
8597 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8599 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8600 steal a few bits to be more compact.
8601 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8602 Remove unneeded casts.
8604 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8606 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8608 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8609 binding" message (bug#7967).
8611 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8613 Fix more problems found by GCC 4.6.0's static checks.
8615 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8616 Remove unused local var.
8618 * editfns.c (Fmessage_box): Remove unused local var.
8620 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8621 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8622 Omit unused local vars.
8623 * window.c (shrink_windows): Omit unused local var.
8624 * menu.c (digest_single_submenu): Omit unused local var.
8625 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8626 Omit unused local var.
8628 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8629 Don't assume string length fits in int.
8630 (keyremap_step, read_key_sequence): Use size_t for sizes.
8631 (read_key_sequence): Don't check last_real_key_start redundantly.
8633 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8634 instead of alloca (Bug#8344).
8636 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8637 (Fbacktrace_frame): Don't assume nframes fits in int.
8639 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8641 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8644 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8646 * cm.c (calccost): Turn while-do into do-while, for clarity.
8648 * keyboard.c (syms_of_keyboard): Use the same style as later
8649 in this function when indexing through an array. This also
8650 works around GCC bug 48267.
8652 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8654 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8656 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8657 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8659 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8660 This avoids undefined behavior on integer overflow, and is a bit
8661 more convenient anyway since it is compared to a size_t variable.
8663 Variadic C functions now count arguments with size_t, not int.
8664 This avoids an unnecessary limitation on 64-bit machines, which
8665 caused (substring ...) to crash on large vectors (Bug#8344).
8666 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8667 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8668 All variadic functions and their callers changed accordingly.
8669 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8670 * data.c (arith_driver, float_arith_driver): Likewise.
8671 * editfns.c (general_insert_function): Likewise.
8672 * eval.c (struct backtrace.nargs, interactive_p)
8673 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8674 (funcall_lambda, mark_backtrace): Likewise.
8675 * fns.c (concat): Likewise.
8676 * frame.c (x_set_frame_parameters): Likewise.
8677 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8678 0 if not found, not -1. All callers changed.
8680 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8681 (stack_copy_size): Now size_t, not int.
8682 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8684 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8686 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8687 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8688 All callers changed.
8690 * lisp.h (multibyte_char_to_unibyte):
8691 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8692 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8693 * character.h (CHAR_TO_BYTE8):
8694 * cmds.c (internal_self_insert):
8695 * editfns.c (general_insert_function):
8696 * keymap.c (push_key_description):
8697 * search.c (Freplace_match):
8698 * xdisp.c (message_dolog, set_message_1): All callers changed.
8700 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8702 * keyboard.c (safe_run_hook_funcall): New function.
8703 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8704 don't set the hook to nil, but remove the offending function instead.
8705 (Qcommand_hook_internal): Remove, unused.
8706 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8707 Vcommand_hook_internal.
8709 * eval.c (enum run_hooks_condition): Remove.
8710 (funcall_nil, funcall_not): New functions.
8711 (run_hook_with_args): Call each function through a `funcall' argument.
8712 Remove `cond' argument, now redundant.
8713 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8714 (Frun_hook_with_args_until_failure): Adjust accordingly.
8715 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8717 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8719 * dispextern.h (string_buffer_position): Remove declaration.
8721 * print.c (strout): Remove parameter `multibyte', unused since
8722 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8724 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8725 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8726 All callers changed.
8728 * w32.c (_wsa_errlist): Use braces for struct initializers.
8730 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8731 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8732 All callers changed.
8733 (string_buffer_position): Likewise. Also, make static (it's never
8734 used outside xdisp.c).
8735 (cursor_row_p): Remove parameter `w', unused since
8736 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8737 (decode_mode_spec): Remove parameter `precision', introduced during
8738 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8739 All callers changed.
8741 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8743 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8745 2011-03-27 Anders Lindgren <andlind@gmail.com>
8747 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8748 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8749 (ns_update_auto_hide_menu_bar): New functions.
8750 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8751 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8752 ns_constrain_all_frames.
8753 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8754 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8756 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8758 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8760 2011-03-27 Glenn Morris <rgm@gnu.org>
8762 * syssignal.h: Replace RETSIGTYPE with void.
8763 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8764 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8765 Replace SIGTYPE with void everywhere.
8766 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8767 * s/template.h (SIGTYPE): Remove commented out definition.
8769 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8771 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8772 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8774 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8776 * w32.c (read_unc_volume): Use parameter `henum', instead of
8777 global variable `wget_enum_handle'.
8779 * keymap.c (describe_vector): Remove parameters `indices' and
8780 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8781 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8783 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8785 * keyboard.c (timer_check): Remove parameter `do_it_now',
8786 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8787 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8788 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8790 * keyboard.c (read_char):
8791 * w32menu.c (w32_menu_display_help):
8792 * xmenu.c (show_help_event, menu_help_callback):
8793 Adjust calls to `show_help_echo'.
8795 * gtkutil.c (xg_maybe_add_timer):
8796 * keyboard.c (readable_events):
8797 * process.c (wait_reading_process_output):
8798 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8800 * insdel.c (adjust_markers_gap_motion):
8801 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8802 (gap_left, gap_right): Don't call it.
8804 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8806 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8807 incurred during fontification.
8809 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8811 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8812 (DEFVAR_PER_BUFFER): Don't pass it.
8814 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8815 (scrolling_window): Don't pass it.
8817 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8819 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8821 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8823 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8824 of variables specific to SELinux and computation of `encoded_absname'.
8826 * image.c (XPutPixel): Remove unused variable `height'.
8828 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8830 * unexw32.c (get_section_info): Remove unused variable `section'.
8832 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8833 (system_process_attributes): Remove unused variable `sess'.
8834 (sys_read): Remove unused variable `err'.
8836 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8837 (w32_wnd_proc): Remove unused variable `isdead'.
8838 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8839 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8840 (x_create_tip_frame): Remove unused variable `tem'.
8842 * w32inevt.c (w32_console_read_socket):
8843 Remove unused variable `no_events'.
8845 * w32term.c (x_draw_composite_glyph_string_foreground):
8846 Remove unused variable `width'.
8848 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8850 * w32term.c (x_set_glyph_string_clipping):
8851 Don't pass uninitialized region to CombineRgn.
8853 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8855 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8856 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8857 (Fx_close_connection): Remove unused variable `i'.
8859 * w32font.c (w32font_draw): Return number of glyphs.
8860 (w32font_open_internal): Remove unused variable `i'.
8861 (w32font_driver): Add missing initializer.
8863 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8864 (fill_in_menu): Remove unused variable `items_added'.
8866 * w32term.c (last_mouse_press_frame): Remove static global variable.
8867 (w32_clip_to_row): Remove unused variable `f'.
8868 (x_delete_terminal): Remove unused variable `i'.
8870 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8871 (NOTHING): Remove unused static global variable.
8872 (uniscribe_check_otf): Remove unused variable `table'.
8873 (uniscribe_font_driver): Add missing initializers.
8875 2011-03-23 Julien Danjou <julien@danjou.info>
8877 * term.c (Fsuspend_tty, Fresume_tty):
8878 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8879 * window.c (temp_output_buffer_show):
8880 * insdel.c (signal_before_change):
8881 * frame.c (Fhandle_switch_frame):
8882 * fileio.c (Fdo_auto_save):
8883 * emacs.c (Fkill_emacs):
8884 * editfns.c (save_excursion_restore):
8885 * cmds.c (internal_self_insert):
8886 * callint.c (Fcall_interactively):
8887 * buffer.c (Fkill_all_local_variables):
8888 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8890 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8891 unconditionally since it does the check itself.
8893 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8895 Fix more problems found by GCC 4.5.2's static checks.
8897 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8898 the first time through the loop, since we know p0 < p1 then.
8899 This also avoids a gcc -Wstrict-overflow warning.
8901 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8902 leading to a memory leak, possible in functions like
8903 load_charset_map_from_file that can allocate an unbounded number
8904 of objects (Bug#8318).
8906 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8907 that could (at least in theory) be that large.
8909 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8910 This is less likely to overflow, and avoids undefined behavior if
8911 overflow does occur. All callers changed. Use strtoul to scan
8912 for the unsigned long integer.
8913 (pint2hrstr): Simplify and tune code slightly.
8914 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8916 * scroll.c (do_scrolling): Work around GCC bug 48228.
8917 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8919 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8920 This also avoids a warning with gcc -Wstrict-overflow.
8921 (validate_x_resource_name): Simplify count usage.
8922 This also avoids a warning with gcc -Wstrict-overflow.
8924 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8927 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8929 * process.c (Fmake_network_process): Use socklen_t, not int,
8930 where POSIX says socklen_t is required in portable programs.
8931 This fixes a porting bug on hosts like 64-bit HP-UX, where
8932 socklen_t is wider than int (Bug#8277).
8933 (Fmake_network_process, server_accept_connection):
8934 (wait_reading_process_output, read_process_output):
8937 * process.c: Rename or move locals to avoid shadowing.
8938 (list_processes_1, Fmake_network_process):
8939 (read_process_output_error_handler, exec_sentinel_error_handler):
8940 Rename or move locals.
8941 (Fmake_network_process): Define label "retry_connect" only if needed.
8942 (Fnetwork_interface_info): Fix pointer signedness.
8943 (process_send_signal): Add cast to avoid pointer signedness problem.
8944 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8945 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8947 Make tparam.h and terminfo.c consistent.
8948 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8949 Include tparam.h instead, since it declares them.
8950 * cm.h (PC): Remove extern decl; tparam.h now does this.
8951 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8952 * terminfo.c: Include tparam.h, to check interfaces.
8953 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8954 (tparam): Adjust signature to match interface in tparam.h;
8955 this removes some undefined behavior. Check that outstring and len
8956 are zero, which they always are with Emacs.
8957 * tparam.h (PC, BC, UP): New extern decls.
8959 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8960 (xftfont_open): Rename locals to avoid shadowing.
8962 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8963 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8964 (OTF_TAG_SYM): Omit macro if not needed.
8965 (ftfont_list): Remove unused local.
8966 (get_adstyle_property, ftfont_pattern_entity):
8967 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8968 Rename locals to avoid shadowing.
8970 * xfont.c (xfont_list_family): Mark var as initialized.
8972 * xml.c (make_dom): Now static.
8974 * composite.c (composition_compute_stop_pos): Rename local to
8976 (composition_reseat_it): Remove unused locals.
8977 (find_automatic_composition, composition_adjust_point): Likewise.
8978 (composition_update_it): Mark var as initialized.
8979 (find_automatic_composition): Mark vars as initialized,
8980 with a FIXME (Bug#8290).
8982 character.h: Rename locals to avoid shadowing.
8983 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8984 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8985 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8986 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8989 * textprop.c (property_change_between_p): Remove; unused.
8991 * intervals.c (interval_start_pos): Now static.
8993 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8995 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8996 Rename locals to avoid shadowing.
8998 * sound.c (wav_play, au_play, Fplay_sound_internal):
8999 Fix pointer signedness.
9000 (alsa_choose_format): Remove unused local var.
9001 (wav_play): Initialize a variable to 0, to prevent undefined
9002 behavior (Bug#8278).
9004 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9006 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9008 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9009 clobbering (Bug#8298).
9010 * sysdep.c (sys_subshell): Likewise.
9011 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9013 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9014 This should get cleaned up, so that child_setup has the
9015 same signature on all platforms.
9017 * callproc.c (call_process_cleanup): Now static.
9018 (relocate_fd): Rename locals to avoid shadowing.
9020 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9022 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9023 not to be necessary, and produces flickering.
9025 2011-03-20 Glenn Morris <rgm@gnu.org>
9027 * config.in: Remove file.
9029 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9031 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9032 are now in src/globals.h.
9033 (syms_of_minibuf): Remove spurious & from previous change.
9035 2011-03-20 Leo Liu <sdl.web@gmail.com>
9037 * minibuf.c (completing-read-function): New variable.
9038 (completing-read-default): Rename from completing-read.
9039 (completing-read): Call completing-read-function.
9041 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9043 * xfaces.c (Fx_load_color_file):
9044 Read color file from absolute filename (bug#8250).
9046 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9048 * makefile.w32-in: Update dependencies.
9050 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9052 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9054 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9056 Fix more problems found by GCC 4.5.2's static checks.
9058 * process.c (make_serial_process_unwind, send_process_trap):
9059 (sigchld_handler): Now static.
9061 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9062 That way, the code declares only the vars that it needs.
9063 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9064 * s/cygwin.h (PTY_ITERATION): Likewise.
9065 * s/darwin.h (PTY_ITERATION): Likewise.
9066 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9068 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9069 * process.c (allocate_pty): Don't declare stb unless it's needed.
9071 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9072 (CONSTANTLIM): Remove; unused.
9073 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9074 Define only if needed.
9076 * unexelf.c (unexec): Name an expression,
9077 to avoid gcc -Wbad-function-cast warning.
9078 Use a different way to cause a compilation error if anyone uses
9079 n rather than nn, a way that does not involve shadowing.
9080 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9082 * deps.mk (unexalpha.o): Remove; unused.
9084 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9085 * unexec.h: New file.
9086 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9087 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9089 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9090 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9091 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9092 Change as necessary to match prototype in unexec.h.
9094 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9096 (back_comment, skip_chars): Mark vars as initialized.
9098 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9099 Rename locals to avoid shadowing.
9101 * lread.c (read1): Rewrite so as not to use empty "else".
9102 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9104 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9106 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9107 warning when compiling print.c.
9109 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9110 instead of using an uninitialized var.
9111 (font_sort_entities): Mark var as initialized.
9113 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9115 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9116 pointers to constants.
9117 (font_parse_fcname): Remove unused vars.
9118 (font_delete_unmatched): Now static.
9119 (font_get_spec): Remove; unused.
9120 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9121 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9122 Rename or move locals to avoid shadowing.
9124 * fns.c (require_nesting_list, require_unwind): Now static.
9125 (Ffillarray): Rename locals to avoid shadowing.
9127 * floatfns.c (domain_error2): Define only if needed.
9128 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9130 * alloc.c (mark_backtrace): Move decl from here ...
9131 * lisp.h: ... to here, so that it can be checked.
9133 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9134 (Fdefvar): Rewrite so as not to use empty "else".
9135 (lisp_indirect_variable): Name an expression,
9136 to avoid gcc -Wbad-function-cast warning.
9137 (Fdefvar): Rename locals to avoid shadowing.
9139 * callint.c (quotify_arg, quotify_args): Now static.
9140 (Fcall_interactively): Rename locals to avoid shadowing.
9141 Use const pointer when appropriate.
9143 * lisp.h (get_system_name, get_operating_system_release):
9144 Move decls here, to check interfaces.
9145 * process.c (get_operating_system_release): Move decl to lisp.h.
9146 * xrdb.c (get_system_name): Likewise.
9147 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9148 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9149 some of which prompt warnings from gcc -Wbad-function-cast.
9150 (Fformat_time_string, Fencode_time, Finsert_char):
9151 (Ftranslate_region_internal, Fformat):
9152 Rename or remove local vars to avoid shadowing.
9153 (Ftranslate_region_internal): Mark var as initialized.
9155 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9158 * lisp.h (eassert): Check that the argument compiles, even if
9159 ENABLE_CHECKING is not defined.
9161 * data.c (Findirect_variable): Name an expression, to avoid
9162 gcc -Wbad-function-cast warning.
9163 (default_value, arithcompare, arith_driver, arith_error): Now static.
9164 (store_symval_forwarding): Rename local to avoid shadowing.
9165 (Fmake_variable_buffer_local, Fmake_local_variable):
9166 Mark variables as initialized.
9167 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9169 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9170 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9171 Rename locals to avoid shadowing.
9172 (mark_stack): Move local variables into the #ifdef region where
9174 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9175 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9177 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9178 (GC_STRING_CHARS): Remove; not used.
9179 (Fmemory_limit): Cast sbrk's returned value to char *.
9181 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9182 avoids undefined behavior in theory.
9184 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9186 Use functions, not macros, for up- and down-casing (Bug#8254).
9187 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9188 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9189 to use the following functions instead of these macros.
9190 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9191 EMACS_INT, since callers assume the returned value fits in int.
9192 (upcase1): Likewise, for UPCASE_TABLE.
9193 (uppercasep, lowercasep, upcase): New static inline functions.
9194 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9195 the race-condition problem in the old DOWNCASE.
9197 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9198 Rename locals to avoid shadowing.
9199 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9200 (regex_compile, re_search_2, re_match_2_internal):
9201 Remove unused local vars.
9202 (FREE_VAR): Rewrite so as not to use empty "else",
9203 which gcc can warn about.
9204 (regex_compile, re_match_2_internal): Mark locals as initialized.
9205 (RETALLOC_IF): Define only if needed.
9206 (WORDCHAR_P): Likewise. This one is never needed, but is used
9207 only in a comment talking about a compiler bug, so put inside
9208 the #if 0 of that comment.
9209 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9210 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9213 * search.c (boyer_moore): Rename locals to avoid shadowing.
9214 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9215 (PREV_CHAR_BOUNDARY): Likewise.
9217 * search.c (simple_search): Remove unused var.
9219 * dired.c (compile_pattern): Move decl from here ...
9220 * lisp.h: ... to here, so that it can be checked.
9221 (struct re_registers): New forward decl.
9223 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9225 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9227 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9228 Rename locals to avoid shadowing.
9229 (Fvertical_motion): Mark locals as initialized.
9231 * casefiddle.c (casify_object, casify_region): Now static.
9232 (casify_region): Mark local as initialized.
9234 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9236 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9237 New macros, so that the caller can use some names other than
9238 gcpro1, gcpro2, etc.
9239 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9241 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9242 argument, for consistency with GCPRO2_VAR, etc: it is now the
9243 prefix of the variable, not the variable itself. All uses
9245 * dired.c (directory_files_internal, file_name_completion):
9246 Rename locals to avoid shadowing.
9248 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9249 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9250 dired.c's scmp function, had undefined behavior.
9251 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9252 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9253 * buffer.h: ... to here, because these macros use current_buffer,
9254 and the new implementation with inline functions needs to have
9255 current_buffer in scope now, rather than later when the macros
9257 (downcase, upcase1): New static inline functions.
9258 (DOWNCASE, UPCASE1): Reimplement using these functions.
9259 This avoids undefined behavior in expressions like
9260 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9261 from race conditions in accessing the global variables
9262 case_temp1 and case_temp2.
9263 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9264 * lisp.h (case_temp1, case_temp2): Remove their decls.
9265 * character.h (ASCII_CHAR_P): Move from here ...
9266 * lisp.h: ... to here, so that the inline functions mentioned
9269 * dired.c (directory_files_internal_unwind): Now static.
9271 * fileio.c (file_name_as_directory, directory_file_name):
9272 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9274 (file_name_as_directory): Use const pointers when appropriate.
9275 (Fexpand_file_name): Likewise. In particular, newdir might
9276 point at constant storage, so make it a const pointer.
9277 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9278 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9280 (Fset_file_times, Finsert_file_contents, auto_save_error):
9281 Rename locals to avoid shadowing.
9283 * minibuf.c (choose_minibuf_frame_1): Now static.
9284 (Ftry_completion, Fall_completions): Rename or remove locals
9287 * marker.c (bytepos_to_charpos): Remove; unused.
9289 * lisp.h (verify_bytepos, count_markers): New decls,
9290 so that gcc does not warn that these functions aren't declared.
9292 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9293 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9294 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9295 (copy_text): Remove unused local var.
9297 * filelock.c (within_one_second): Now static.
9298 (lock_file_1): Rename local to avoid shadowing.
9300 * buffer.c (fix_overlays_before): Mark locals as initialized.
9301 (fix_start_end_in_overlays): Likewise. This function should be
9302 simplified by using pointers-to-pointers, but that's a different
9304 (switch_to_buffer_1): Now static.
9305 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9306 (report_overlay_modification): Rename locals to avoid shadowing.
9308 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9309 Fix pointer signedness issue.
9310 (sys_subshell): Mark local as volatile if checking for lint,
9311 to suppress a gcc -Wclobbered warning that does not seem to be right.
9312 (MAXPATHLEN): Define only if needed.
9314 * process.c (serial_open, serial_configure): Move decls from here ...
9315 * systty.h: ... to here, so that they can be checked.
9317 * fns.c (get_random, seed_random): Move extern decls from here ...
9318 * lisp.h: ... to here, so that they can be checked.
9320 * sysdep.c (reset_io): Now static.
9321 (wait_for_termination_signal): Remove; unused.
9323 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9324 (copy_keymap_item, append_key, push_text_char_description):
9326 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9327 (DENSE_TABLE_SIZE): Remove; unused.
9328 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9329 (describe_map_tree):
9330 Rename locals to avoid shadowing.
9332 * keyboard.c: Declare functions static if they are not used elsewhere.
9333 (echo_char, echo_dash, cmd_error, top_level_2):
9334 (poll_for_input, handle_async_input): Now static.
9335 (read_char, kbd_buffer_get_event, make_lispy_position):
9336 (make_lispy_event, make_lispy_movement, apply_modifiers):
9337 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9338 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9339 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9340 (read_key_sequence, read_char): Mark locals as initialized.
9341 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9343 * keyboard.h (make_ctrl_char): New decl.
9344 (mark_kboards): Move decl here ...
9345 * alloc.c (mark_kboards): ... from here.
9347 * lisp.h (force_auto_save_soon): New decl.
9349 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9350 (DEFINE_DUMMY_FUNCTION): New macro.
9351 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9353 (main): Add casts to avoid warnings
9354 if GCC considers string literals to be constants.
9356 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9358 * dbusbind.c: Pointer signedness fixes.
9359 (xd_signature, xd_append_arg, xd_initialize):
9360 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9361 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9362 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9363 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9365 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9366 if GCC considers string literals to be constants.
9367 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9369 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9371 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9372 (print_preprocess, print_object): New macro to fix last change.
9374 * print.c (print_preprocess): Don't forget font objects.
9376 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9378 * emacs.c (USAGE3): Doc fixes.
9380 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9382 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9385 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9387 * lisp.h (VWindow_system, Qfile_name_history):
9388 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9389 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9390 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9392 * w32select.c: Don't #include "keyboard.h".
9393 (run_protected): Add extern declaration for waiting_for_input.
9395 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9396 * w32console.c (detect_input_pending, read_input_pending)
9397 (encode_terminal_code):
9398 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9399 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9400 (w32_system_caret_y, Qfile_name_history):
9401 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9402 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9403 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9404 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9405 * w32proc.c (Qlocal, report_file_error):
9406 * w32term.c (Vwindow_system, updating_frame):
9407 * w32uniscribe.c (initialized, uniscribe_font_driver):
9408 Remove unneeded extern declarations.
9410 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9412 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9414 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9416 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9417 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9418 These macros can no longer be used for assignment.
9420 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9421 Assign struct members directly, instead of using BUF_BEGV etc.
9422 (record_buffer_markers, fetch_buffer_markers): New functions for
9423 recording and fetching special buffer markers.
9424 (set_buffer_internal_1, set_buffer_temp): Use them.
9426 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9428 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9430 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9431 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9433 * xdisp.c (hscroll_window_tree):
9434 (reconsider_clip_changes): Use PT instead of BUF_PT.
9436 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9438 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9439 $(EMACS_ROOT)/lib/intprops.h.
9441 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9443 Fix more problems found by GCC 4.5.2's static checks.
9445 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9446 to unsigned char * to avoid compiler diagnostic.
9447 (xg_free_frame_widgets): Make it clear that a local variable is
9448 needed only if USE_GTK_TOOLTIP.
9449 (gdk_window_get_screen): Make it clear that this macro is needed
9450 only if USE_GTK_TOOLTIP.
9451 (int_gtk_range_get_value): New function, which avoids a diagnostic
9452 from gcc -Wbad-function-cast.
9453 (xg_set_toolkit_scroll_bar_thumb): Use it.
9454 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9455 diagnostic from gcc -Wbad-function-cast.
9456 (get_utf8_string, xg_get_file_with_chooser):
9457 Rename locals to avoid shadowing.
9458 (create_dialog): Move locals to avoid shadowing.
9460 * xgselect.c (xg_select): Remove unused var.
9462 * image.c (four_corners_best): Mark locals as initialized.
9463 (gif_load): Initialize transparent_p to zero (Bug#8238).
9464 Mark another local as initialized.
9465 (my_png_error, my_error_exit): Mark with NO_RETURN.
9467 * image.c (clear_image_cache): Now static.
9468 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9469 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9470 (x_edge_detection): Remove unnecessary cast that
9471 gcc -Wbad-function-cast diagnoses.
9472 (gif_load): Fix pointer signedness.
9473 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9474 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9476 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9478 Improve quality of tests for time stamp overflow.
9479 For example, without this patch (encode-time 0 0 0 1 1
9480 1152921504606846976) returns the obviously-bogus value (-948597
9481 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9482 reports time overflow. See
9483 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9484 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9485 * editfns.c: Include limits.h and intprops.h.
9486 (TIME_T_MIN, TIME_T_MAX): New macros.
9487 (time_overflow): Move earlier, to before first use.
9488 (hi_time, lo_time): New functions, for an accurate test for
9490 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9491 (Fget_internal_run_time): Don't assume time_t fits in int.
9492 (make_time): Use list2 instead of Fcons twice.
9493 (Fdecode_time): More accurate test for out-of-range times.
9494 (check_tm_member): New function.
9495 (Fencode_time): Use it, to test for out-of-range times.
9496 (lisp_time_argument): Don't rely on undefined left-shift and
9497 right-shift behavior when checking for time stamp overflow.
9499 * editfns.c (time_overflow): New function, refactoring common code.
9500 (Fformat_time_string, Fdecode_time, Fencode_time):
9501 (Fcurrent_time_string): Use it.
9503 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9504 * dired.c (make_time): Move to ...
9505 * editfns.c (make_time): ... here.
9506 * systime.h: Note the move.
9508 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9510 * fringe.c (update_window_fringes): Remove unused variables.
9512 * unexmacosx.c (copy_data_segment): Also copy __got section.
9515 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9517 * termcap.c [MSDOS]: Include "msdos.h".
9518 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9519 Constify `char *' arguments and their references according to
9520 prototypes in tparam.h.
9522 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9524 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9525 Adapt all references accordingly.
9527 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9529 2011-03-11 Tom Tromey <tromey@redhat.com>
9531 * buffer.c (syms_of_buffer): Remove obsolete comment.
9533 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9535 * termhooks.h (encode_terminal_code): Declare prototype.
9537 * msdos.c (encode_terminal_code): Don't declare prototype.
9539 * term.c (encode_terminal_code): Now external again, used by
9540 w32console.c and msdos.c.
9542 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9543 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9545 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9547 Fix some minor problems found by GCC 4.5.2's static checks.
9549 * fringe.c (update_window_fringes): Mark locals as initialized
9551 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9553 * alloc.c (mark_fringe_data): Move decl from here ...
9554 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9555 to check its interface.
9556 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9558 * fontset.c (free_realized_fontset): Now static.
9559 (Fset_fontset_font): Rename local to avoid shadowing.
9560 (fontset_font): Mark local as initialized.
9561 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9563 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9565 * xselect.c (x_disown_buffer_selections): Remove; not used.
9566 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9567 (x_own_selection, Fx_disown_selection_internal): Rename locals
9569 (x_handle_dnd_message): Remove local to avoid shadowing.
9571 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9572 so that the caller can use some name other than gcpro1.
9573 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9574 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9575 (Fx_backspace_delete_keys_p):
9576 Use them to avoid shadowing, and rename vars to avoid shadowing.
9577 (x_decode_color, x_set_name, x_window): Now static.
9578 (Fx_create_frame): Add braces to silence GCC warning.
9579 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9580 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9581 Remove unused locals.
9582 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9583 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9584 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9587 * xterm.h (x_mouse_leave): New decl.
9589 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9590 Remove unused functions.
9591 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9592 (x_calc_absolute_position): Now static.
9593 (XTread_socket): Don't define label "out" unless it's used.
9594 Don't declare local "event" unless it's used.
9595 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9596 unless they are used.
9597 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9598 (x_fatal_error_signal): Remove; not used.
9599 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9600 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9601 (x_error_catcher, x_connection_closed, x_error_handler):
9602 (x_error_quitter, xembed_send_message, x_iconify_frame):
9603 (my_log_handler): Rename locals to avoid shadowing.
9604 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9605 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9607 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9608 Rename or move locals to avoid shadowing.
9609 (tty_defined_color, merge_face_heights): Now static.
9610 (free_realized_faces_for_fontset): Remove; not used.
9611 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9612 does not deduce is never used uninitialized.
9613 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9614 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9616 * terminal.c (store_terminal_param): Now static.
9618 * xmenu.c (menu_highlight_callback): Now static.
9619 (set_frame_menubar): Remove unused local.
9620 (xmenu_show): Rename parameter to avoid shadowing.
9621 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9622 since they might point to immutable storage.
9623 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9624 since it's unused otherwise.
9626 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9627 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9628 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9629 avoids a gcc -Wuninitialized diagnostic.
9630 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9631 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9632 does not deduce are never used uninitialized.
9634 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9636 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9637 * window.c (window_loop, size_window):
9638 (run_window_configuration_change_hook, enlarge_window): Likewise.
9640 * window.c (display_buffer): Now static.
9641 (size_window): Mark variables that gcc -Wuninitialized
9642 does not deduce are never used uninitialized.
9643 * window.h (check_all_windows): New decl, to forestall
9644 gcc -Wmissing-prototypes diagnostic.
9645 * dispextern.h (bidi_dump_cached_states): Likewise.
9647 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9649 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9651 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9652 and to avoid gcc -Wuninitialized warning.
9653 (load_charset_map): Mark variables that gcc -Wuninitialized
9654 does not deduce are never used uninitialized.
9655 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9657 * coding.c (coding_set_source, coding_set_destination):
9658 Use "else { /* comment */ }" rather than "else /* comment */;"
9659 for clarity, and to avoid gcc -Wempty-body warning.
9660 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9661 a block, when the outer 'i' will do.
9662 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9663 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9664 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9665 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9666 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9667 Rename locals to avoid shadowing.
9668 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9669 * coding.c (emacs_mule_char, encode_invocation_designation):
9670 Now static, since they're not used elsewhere.
9671 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9672 (decode_coding_object, encode_coding_object, detect_coding_system):
9673 (decode_coding_emacs_mule): Mark variables that gcc
9674 -Wuninitialized does not deduce are never used uninitialized.
9675 (detect_coding_iso_2022): Initialize a local variable that might
9676 be used uninitialized. Leave a FIXME because it's not clear that
9677 this initialization is needed. (Bug#8211)
9678 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9679 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9680 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9681 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9682 Remove unused macros.
9684 * category.c (hash_get_category_set): Remove unused local var.
9685 (copy_category_table): Now static, since it's not used elsewhere.
9686 * character.c (string_count_byte8): Likewise.
9688 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9689 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9691 * chartab.c (copy_sub_char_table): Now static, since it's not used
9693 (sub_char_table_ref_and_range, char_table_ref_and_range):
9694 Rename locals to avoid shadowing.
9695 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9697 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9698 (BIDI_BOB): Remove unused macro.
9700 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9701 deduce are never used uninitialized.
9702 * term.c (encode_terminal_code): Likewise.
9704 * term.c (encode_terminal_code): Now static. Remove unused local.
9706 * tparam.h: New file.
9707 * term.c, tparam.h: Include it.
9708 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9709 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9710 Move these decls to tparam.h, and make them agree with what
9711 is actually in tparam.c. The previous trick of using incompatible
9712 decls in different modules does not conform to the C standard.
9713 All callers of tparam changed to use tparam's actual API.
9714 * tparam.c (tparam1, tparam, tgoto):
9715 Use const pointers where appropriate.
9717 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9718 * cm.h (struct cm): Likewise.
9719 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9720 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9721 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9722 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9723 (turn_on_face, init_tty): Likewise.
9724 * termchar.h (struct tty_display_info): Likewise.
9726 * term.c (term_mouse_position): Rename local to avoid shadowing.
9728 * alloc.c (mark_ttys): Move decl from here ...
9729 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9731 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9733 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9735 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9737 * search.c (compile_pattern_1): Remove argument regp, unused since
9738 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9739 (compile_pattern): Don't pass it.
9741 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9743 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9744 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9746 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9748 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9750 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9751 gdk_window_get_screen, gdk_window_get_geometry,
9752 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9753 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9754 (xg_get_pixbuf_from_pixmap): New function.
9755 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9756 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9757 Call xg_get_pixbuf_from_pixmap instead of
9758 gdk_pixbuf_get_from_drawable.
9759 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9760 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9761 (xg_check_special_colors): Use GtkStyleContext and its functions
9763 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9764 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9765 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9766 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9767 Call gtk_widget_get_preferred_size.
9768 (xg_frame_resized): gdk_window_get_geometry only takes 5
9770 (xg_win_to_widget, xg_event_is_for_menubar):
9771 Call gdk_x11_window_lookup_for_display.
9772 (xg_set_widget_bg): New function.
9773 (delete_cb): New function.
9774 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9775 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9776 (xg_set_background_color): Call xg_set_widget_bg.
9777 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9778 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9779 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9780 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9782 (update_frame_tool_bar): Call gtk_widget_hide.
9783 (xg_initialize): Use GDK_KEY_g.
9785 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9787 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9789 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9790 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9791 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9793 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9795 * w32xfns.c (select_palette): Check success of RealizePalette against
9796 GDI_ERROR, not zero.
9798 See ChangeLog.11 for earlier changes.
9804 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9806 This file is part of GNU Emacs.
9808 GNU Emacs is free software: you can redistribute it and/or modify
9809 it under the terms of the GNU General Public License as published by
9810 the Free Software Foundation, either version 3 of the License, or
9811 (at your option) any later version.
9813 GNU Emacs is distributed in the hope that it will be useful,
9814 but WITHOUT ANY WARRANTY; without even the implied warranty of
9815 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9816 GNU General Public License for more details.
9818 You should have received a copy of the GNU General Public License
9819 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.