1 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3 * lread.c (lisp_file_lexically_bound_p):
4 Fix hang at ";-*-\n" (bug#11238).
6 2012-04-14 Eli Zaretskii <eliz@gnu.org>
8 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
9 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
11 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
13 * nsterm.m (constrainFrameRect): Always constrain when there is only
14 one screen (Bug#10962).
16 2012-04-13 Ken Brown <kbrown@cornell.edu>
18 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
20 2012-04-13 Reuben Thomas <rrt@sc3d.org>
22 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
24 2012-04-11 Daniel Colascione <dancol@dancol.org>
26 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
27 against is gone. It's better to use vfork now so that when Cygwin
28 gains a new, working vfork, we use it automatically (bug#10398).
30 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
32 * window.c (save_window_save): Obey window-point-insertion-type.
34 2012-04-11 Glenn Morris <rgm@gnu.org>
36 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
38 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
40 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
42 2012-04-10 "Jason S. Cornez" <jcornez@ravenpack.com> (tiny change)
44 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
45 (force_quit_count): New var.
46 (handle_interrupt): Use it.
48 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
50 * w32.c (w32_delayed_load): Record the full path of the library
51 being loaded (bug#10424).
53 2012-04-09 Glenn Morris <rgm@gnu.org>
55 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
56 not just in the obarray, before snarfing them. (Bug#11036)
58 * Makefile.in ($(leimdir)/leim-list.el):
59 Pass EMACS rather than BUILT_EMACS.
61 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
63 * process.c (make_process):
64 * process.h: Add integer `gnutls_handshakes_tried' member to
67 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
68 Add convenience `GNUTLS_LOG2i' macro.
70 * gnutls.c (gnutls_log_function2i): Convenience log function.
71 (emacs_gnutls_read): Use new log functions,
72 `gnutls_handshakes_tried' process member, and
73 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
74 attempts per process (connection).
76 2012-04-09 Chong Yidong <cyd@gnu.org>
78 * eval.c (Fuser_variable_p, user_variable_p_eh)
79 (lisp_indirect_variable): Functions deleted.
80 (Fdefvar): Caller changed.
82 * callint.c (Finteractive, Fcall_interactively):
83 * minibuf.c (Fread_variable): Callers changed.
85 2012-04-09 Eli Zaretskii <eliz@gnu.org>
87 * xdisp.c (set_cursor_from_row): If the display string appears in
88 the buffer at position that is closer to point than the position
89 after the display string, display the cursor on the first glyph of
90 the display string. Fixes cursor display when a 'display' text
91 property immediately follows invisible text. (Bug#11094)
93 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
95 composite.c: use 'double' consistently
96 * composite.c (get_composition_id): Use 'double' consistently
97 instead of converting 'float' to 'double' and vice versa; this is
98 easier to understand and avoids a GCC warning.
100 2012-04-09 Glenn Morris <rgm@gnu.org>
102 * Makefile.in: Generate leim-list with bootstrap-emacs, in
103 preparation for dumping it with emacs. (Bug#4789)
104 (leimdir): New variable.
105 ($(leimdir)/leim-list.el): New rule.
106 (emacs$(EXEEXT)): Depend on leim-list.el.
108 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
109 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
110 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
112 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
114 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
117 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
119 * xml.c (init_libxml2_functions) [WINDOWSNT]:
120 Remove unused local variable.
122 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
124 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
125 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
126 (mark_memory): Mark Lisp_Objects only if pointers might hide in
127 objects, as mark_maybe_pointer will catch them otherwise.
128 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
129 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
131 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
133 Fix typo that broke non-Windows builds.
134 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
136 2012-04-07 Eli Zaretskii <eliz@gnu.org>
138 Support building on MS-Windows with libxml2.
140 * makefile.w32-in (OBJ2): Add xml.$(O).
141 (GLOBAL_SOURCES): Add xml.c.
142 ($(BLD)/xml.$(O)): New dependency list.
144 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
145 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
146 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
147 [!WINDOWSNT]: New macros.
148 (init_libxml2_functions, libxml2_loaded_p): New functions.
149 (parse_region): Call fn_xmlCheckVersion instead of using the macro
150 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
151 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
152 Calls xmlCleanupParser only if libxml2 was loaded (or statically
154 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
155 Call init_libxml2_functions before calling libxml2 functions.
156 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
158 * emacs.c: Don't include libxml/parser.h.
159 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
160 xmlCleanupParser directly.
162 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
164 2012-04-07 Eli Zaretskii <eliz@gnu.org>
166 * indent.c (Fvertical_motion): If there is a display string at
167 point, use it.vpos to compute how many lines to backtrack after
168 move_it_to point. (Bug#11133)
170 2012-04-06 Eli Zaretskii <eliz@gnu.org>
172 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
173 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
174 about subtle differences between FETCH_CHAR* and STRING_CHAR*
175 macros related to unification of CJK characters. For the details,
176 see the discussion following the message here:
177 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
179 2012-04-04 Chong Yidong <cyd@gnu.org>
181 * keyboard.c (Vdelayed_warnings_list): Doc fix.
183 2012-04-01 Eli Zaretskii <eliz@gnu.org>
185 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
186 instead of alloca. (Bug#11138)
188 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
190 * w32menu.c (is_simple_dialog): Properly check lisp types.
193 2012-03-31 Eli Zaretskii <eliz@gnu.org>
195 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
196 position we get to after a call to move_it_to fails the
197 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
198 only if we wind up in a string from display property. (Bug#11063)
200 * window.c (Fdelete_other_windows_internal): Invalidate the row
201 and column information about mouse highlight, so that redisplay
202 restores it after reallocating the glyph matrices. (Bug#7464)
204 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
205 string comes from a `display' text property, use the buffer
206 position of that property as if we actually saw that position in
208 (move_it_by_lines): Remove the assertion that
209 "it->current_x == 0 && it->hpos == 0" which can be legitimately
210 violated when there's a before-string at the beginning of a line.
213 2012-03-30 Eli Zaretskii <eliz@gnu.org>
215 * xdisp.c (append_space_for_newline): If the default face was
216 remapped, use the remapped face for the appended newline.
217 (extend_face_to_end_of_line): Use the remapped default face for
218 extending the face to the end of the line.
219 (display_line): Call extend_face_to_end_of_line when the default
220 face was remapped. (Bug#11068)
222 2012-03-29 Eli Zaretskii <eliz@gnu.org>
224 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
226 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
228 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
230 2012-03-27 Glenn Morris <rgm@gnu.org>
232 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
235 2012-03-26 Kenichi Handa <handa@m17n.org>
237 * dispextern.h (struct glyph): Fix previous change. Change the
238 bit length of glyphless.ch to 25 (Bug#11082).
240 2012-03-26 Chong Yidong <cyd@gnu.org>
242 * keyboard.c (Vselection_inhibit_update_commands): New variable.
243 (command_loop_1): Use it; inhibit selection update for
244 handle-select-window too (Bug#8996).
246 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
248 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
250 2012-03-25 Kenichi Handa <handa@m17n.org>
252 * dispextern.h (struct glyph): Change the bit length of
253 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
255 2012-03-24 Eli Zaretskii <eliz@gnu.org>
257 * s/ms-w32.h (tzname): Include time.h before redirecting to
258 _tzname. Fixes the MSVC build. (Bug#9960)
260 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
262 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
265 * xterm.c (XTread_socket): Only modify handling_signal if
266 !SYNC_INPUT. (Bug#11080)
268 2012-03-23 Eli Zaretskii <eliz@gnu.org>
270 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
271 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
272 when fetching a multibyte character consumes more bytes than
273 CHAR_BYTES returns, due to unification of CJK characters in
274 string_char. (Bug#11073)
276 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
278 * process.c (wait_reading_process_output): Handle pty disconnect
279 by refraining from sending oneself a SIGCHLD (bug#10933).
281 2012-03-22 Chong Yidong <cyd@gnu.org>
283 * dispextern.h (struct it): New member string_from_prefix_prop_p.
285 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
286 Mark string as coming from a prefix property.
287 (handle_face_prop): Use default face for prefix strings (Bug#4281).
288 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
290 2012-03-21 Chong Yidong <cyd@gnu.org>
292 * xfaces.c (Vface_remapping_alist): Doc fix.
294 2012-03-20 Eli Zaretskii <eliz@gnu.org>
296 * w32proc.c (Fw32_set_console_codepage)
297 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
300 2012-03-20 Chong Yidong <cyd@gnu.org>
302 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
303 to reflect default non-nil value of redisplay-dont-pause.
305 2012-03-19 Kenichi Handa <handa@m17n.org>
307 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
308 it fit in a valid range (Bug#11003).
310 2012-03-18 Eli Zaretskii <eliz@gnu.org>
312 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
313 that is not from display property, accept the row as a "cursor
314 row" if one of the string's character has a non-nil `cursor'
315 property. Fixes cursor positioning when there are newlines in
316 overlay strings, e.g. in icomplete.el. (Bug#11035)
318 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
320 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
322 2012-03-12 Chong Yidong <cyd@gnu.org>
324 * eval.c (inhibit_lisp_code): Rename from
325 inhibit_window_configuration_change_hook; move from window.c.
327 * xfns.c (unwind_create_frame_1, Fx_create_frame):
328 * window.c (run_window_configuration_change_hook)
329 (syms_of_window): Callers changed.
331 2012-03-11 Chong Yidong <cyd@gnu.org>
333 * keymap.c (Fkey_description): Doc fix (Bug#9700).
335 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
337 2012-03-10 Chong Yidong <cyd@gnu.org>
339 * frame.c (other_visible_frames): Don't assume the selected frame
340 is visible (Bug#10955).
342 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
344 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
346 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
348 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
349 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
352 2012-03-03 Glenn Morris <rgm@gnu.org>
354 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
356 2012-03-02 Eli Zaretskii <eliz@gnu.org>
358 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
359 position past the first glyph_row that ends at ZV. (Bug#10902)
360 (redisplay_window, next_element_from_string): Fix typos in
362 (redisplay_window): Pass to move_it_vertically the margin in
363 pixels, not in screen lines.
365 2012-03-02 Glenn Morris <rgm@gnu.org>
367 * buffer.c (buffer-list-update-hook): Doc fix.
369 2012-02-29 Eli Zaretskii <eliz@gnu.org>
371 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
372 push_it before setting up the iterator for the first overlay
373 string, even if we have an empty string loaded.
374 (next_overlay_string): If there's an empty string on the iterator
375 stack, pop the stack. (Bug#10903)
377 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
379 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
380 Suggested by Stefan Monnier in
381 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
382 * alloc.c (widen_to_Lisp_Object): New static function.
383 (mark_memory): Also mark Lisp_Objects by fetching pointer words
384 and widening them to Lisp_Objects. This would work even if
385 USE_LSB_TAG is defined and wide integers are used, which might
386 happen in a future version of Emacs.
388 2012-02-25 Chong Yidong <cyd@gnu.org>
390 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
393 * xselect.c (Fx_selection_exists_p): Doc fix.
394 (x_clipboard_manager_save_all): Print an informative message
395 before saving to clipboard manager.
397 2012-02-24 Chong Yidong <cyd@gnu.org>
399 * keyboard.c (process_special_events): Handle all X selection
400 requests in kbd_buffer, not just the next one (Bug#8869).
402 2012-02-23 Chong Yidong <cyd@gnu.org>
404 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
405 call when setting menu-bar-lines and tool-bar-lines parameters.
406 (unwind_create_frame_1): New helper function.
408 * window.c (inhibit_window_configuration_change_hook): New var.
409 (run_window_configuration_change_hook): Obey it.
410 (syms_of_window): Initialize it.
412 2012-02-22 Chong Yidong <cyd@gnu.org>
414 * xterm.c (x_draw_image_relief): Add missing type check for
415 Vtool_bar_button_margin (Bug#10743).
417 2012-02-21 Chong Yidong <cyd@gnu.org>
419 * fileio.c (Vfile_name_handler_alist): Doc fix.
421 * buffer.c (Fget_file_buffer): Protect against invalid file
422 handler return value.
424 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
426 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
427 when computing $valmask.
429 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
430 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
431 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
432 It's useless in that case, and it can cause problems on hosts
433 that allocate halves of EMACS_INT values separately.
434 Reported by Dan Horák. Diagnosed by Andreas Schwab in
435 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
436 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
437 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
438 it avoids undefined behavior on hosts where shifting right by more
439 than the word width has undefined behavior.
441 2012-02-19 Chong Yidong <cyd@gnu.org>
443 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
444 (Funhandled_file_name_directory, Ffile_name_as_directory)
445 (Fdirectory_file_name, Fexpand_file_name)
446 (Fsubstitute_in_file_name): Protect against invalid file handler
447 return values (Bug#10845).
449 2012-02-18 Eli Zaretskii <eliz@gnu.org>
451 * .gdbinit (pitx): Fix incorrect references to fields of the
454 2012-02-17 Chong Yidong <cyd@gnu.org>
456 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
458 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
460 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
461 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
463 2012-02-15 Chong Yidong <cyd@gnu.org>
465 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
466 marked as special. Also, starting docstrings with * is obsolete.
468 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
470 * gnutls.c (emacs_gnutls_write): Fix last change.
472 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
474 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
477 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
479 * keymap.c (Fsingle_key_description): Handle char ranges.
481 2012-02-12 Chong Yidong <cyd@gnu.org>
483 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
484 as that creates a dangerous corner case.
486 * window.c (Fdelete_window_internal): Invalidate the mouse
487 highlight (Bug#9904).
489 2012-02-12 Glenn Morris <rgm@gnu.org>
491 * xselect.c (Fx_own_selection_internal)
492 (Fx_get_selection_internal, Fx_disown_selection_internal)
493 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
494 * nsselect.m (Fx_own_selection_internal)
495 (Fx_disown_selection_internal, Fx_selection_exists_p)
496 (Fx_selection_owner_p, Fx_get_selection_internal):
497 Sync docs and argument specs with the xselect.c versions.
499 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
501 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
503 2012-02-11 Eli Zaretskii <eliz@gnu.org>
505 * w32select.c (Fx_selection_exists_p): Sync doc string and
506 argument list with xselect.c. (Bug#10783)
508 * w16select.c (Fx_selection_exists_p): Sync doc string and
509 argument list with xselect.c. (Bug#10783)
511 2012-02-10 Glenn Morris <rgm@gnu.org>
513 * fns.c (Fsecure_hash): Doc fix.
515 2012-02-09 Kenichi Handa <handa@m17n.org>
517 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
519 2012-02-07 Chong Yidong <cyd@gnu.org>
521 * buffer.c (Fbuffer_local_variables)
522 (buffer_lisp_local_variables): Handle unbound vars correctly;
523 don't let Qunbound leak into Lisp.
525 2012-02-07 Glenn Morris <rgm@gnu.org>
527 * image.c (Fimagemagick_types): Doc fix.
529 * image.c (imagemagick-render-type): Change it from a lisp object
530 to an integer. Move the doc here from the lisp manual.
531 Treat all values not equal to 0 the same.
533 2012-02-06 Chong Yidong <cyd@gnu.org>
535 * doc.c (store_function_docstring): Avoid applying docstring of
536 alias to base function (Bug#2603).
538 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
540 * .gdbinit (pp1, pv1): Remove redundant defines.
543 2012-02-04 Chong Yidong <cyd@gnu.org>
545 * nsterm.m: Declare a global (Bug#10694).
547 2012-02-04 Eli Zaretskii <eliz@gnu.org>
549 * w32.c (get_emacs_configuration_options):
550 Include --enable-checking, if specified, in the return value.
552 2012-02-04 Martin Rudalics <rudalics@gmx.at>
554 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
555 after rounding frame sizes. (Bug#9723)
557 2012-02-04 Eli Zaretskii <eliz@gnu.org>
559 * keyboard.c (adjust_point_for_property): Don't position point
560 before BEGV. (Bug#10696)
562 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
564 Handle overflow when computing char display width (Bug#9496).
565 * character.c (char_width): Return EMACS_INT, not int.
566 (char_width, c_string_width): Check for overflow when
567 computing the width; this is possible now that individual
568 characters can have unbounded width. Problem introduced
569 by merge from Emacs 23 on 2012-01-19.
571 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
573 * dbusbind.c (Fdbus_register_method): Mention the return value
574 :ignore in the docstring.
576 2012-02-02 Glenn Morris <rgm@gnu.org>
578 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
580 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
581 Unconditionally set to t. (Bug#10673)
582 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
583 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
584 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
586 2012-02-02 Kenichi Handa <handa@m17n.org>
588 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
589 0, do not call append_composite_glyph.
591 2012-02-02 Kenichi Handa <handa@m17n.org>
593 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
595 (x_produce_glyphs): If the component of a composition is a null
596 string, set it->pixel_width to 1 to avoid zero-width glyph.
598 2012-02-01 Eli Zaretskii <eliz@gnu.org>
600 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
601 first 2 arguments are identical. This makes inserting large
602 output from a subprocess an order of magnitude faster on
603 MS-Windows, where all sbrk'ed memory is always contiguous.
605 2012-01-31 Glenn Morris <rgm@gnu.org>
607 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
608 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
609 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
611 2012-01-29 Glenn Morris <rgm@gnu.org>
613 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
615 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
617 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
619 2012-01-28 Chong Yidong <cyd@gnu.org>
621 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
623 2012-01-26 Chong Yidong <cyd@gnu.org>
625 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
627 * search.c (Fsearch_forward, Fsearch_backward): Document negative
628 repeat counts (Bug#10507).
630 2012-01-26 Glenn Morris <rgm@gnu.org>
632 * lread.c (syms_of_lread): Doc fix.
634 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
636 * coding.c (encode_designation_at_bol): Change return value to
639 2012-01-25 Chong Yidong <cyd@gnu.org>
641 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
643 2012-01-21 Chong Yidong <cyd@gnu.org>
645 * floatfns.c (Fcopysign): Make the second argument non-optional,
646 since nil is not allowed anyway.
648 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
650 * process.c (read_process_output): Use p instead of XPROCESS (proc).
651 (send_process): Likewise.
653 2012-01-19 Martin Rudalics <rudalics@gmx.at>
655 * window.c (save_window_save, Fcurrent_window_configuration)
656 (Vwindow_persistent_parameters): Do not use Qstate.
659 2012-01-19 Kenichi Handa <handa@m17n.org>
661 * character.c (char_width): New function.
662 (Fchar_width, c_string_width, lisp_string_width):
663 Use char_width (Bug#9496).
665 2012-01-16 Martin Rudalics <rudalics@gmx.at>
667 * window.c (Vwindow_persistent_parameters): New variable.
668 (Fset_window_configuration, save_window_save): Handle persistent
671 2012-01-14 Eli Zaretskii <eliz@gnu.org>
673 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
674 thrashing the stack of the thread. (Bug#9087)
676 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
678 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
680 2012-01-11 Eli Zaretskii <eliz@gnu.org>
682 * xdisp.c (rows_from_pos_range): Handle the case where the
683 highlight ends on a newline. (Bug#10464)
684 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
685 he end column for display of highlight that ends on a newline
688 2012-01-11 Glenn Morris <rgm@gnu.org>
690 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
691 from load-path also when installation-directory is nil. (Bug#10208)
693 2012-01-10 Glenn Morris <rgm@gnu.org>
695 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
697 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
698 Update template values to be closer to their typical values these days.
700 2012-01-09 Eli Zaretskii <eliz@gnu.org>
702 * xdisp.c (rows_from_pos_range): Accept additional argument
703 DISP_STRING, and accept any glyph in a row whose object is that
704 string as eligible for mouse highlight. Fixes mouse highlight of
705 display strings from overlays. (Bug#10464)
707 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
709 emacs: fix an auto-save permissions race condition (Bug#10400)
710 * fileio.c (auto_saving_dir_umask): New static var.
711 (Fmake_directory_internal): Use it.
712 (do_auto_save_make_dir): Set it, instead of invoking chmod after
713 creating the directory. The old code temporarily assigns
714 too-generous permissions to the directory.
715 (do_auto_save_eh): Clear it.
716 (Fdo_auto_save): Catch all errors, not just file errors, so
717 that the var is always cleared.
719 2012-01-07 Eli Zaretskii <eliz@gnu.org>
721 * search.c (scan_buffer): Pass character positions to
722 know_region_cache, not byte positions. (Bug#6540)
724 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
726 * w32.c (sys_rename): Report EXDEV when rename of a directory
727 fails because the target is on another logical disk. (Bug#10284)
729 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
731 * xterm.c (x_embed_request_focus): New function.
733 * xterm.h: Add prototype.
735 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
737 2012-01-05 Glenn Morris <rgm@gnu.org>
739 * emacs.c (emacs_copyright): Update short copyright year to 2012.
741 2012-01-01 Eli Zaretskii <eliz@gnu.org>
743 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
744 Load gnutls_transport_set_lowat only if GnuTLS version is below
746 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
747 GnuTLS versions below 2.11.1.
749 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
751 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
752 to the doc string advising against its use for altering the way
753 windows are scrolled.
755 2011-12-28 Kenichi Handa <handa@m17n.org>
757 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
758 coding-system ASCII compatible only when it does not produce BOM
759 on encoding (Bug#10383).
761 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
763 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
765 (create_and_show_popup_menu): Always use menu_position_func for
768 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
770 * callint.c (Fcall_interactively): Don't truncate prompt string.
772 2011-12-23 Eli Zaretskii <eliz@gnu.org>
774 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
775 property that ends at ZV, so that the bidi iteration could be
776 resumed from there (after widening). (Bug#10360)
778 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
780 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
782 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
784 * nsterm.m (x_free_frame_resources):
785 Release f->output_data.ns->miniimage.
786 (ns_index_color): Fix indentation. Do not retain
787 color_table->colors[i].
789 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
792 * nsfns.m (x_set_background_color): Assign return value from
793 ns_index_color to face-background instead of NSColor*.
794 (ns_implicitly_set_icon_type): Fix indentation.
795 Change assignment in for loop to comparison.
797 * emacs.c (ns_pool): New variable.
798 (main): Assign ns_pool.
799 (Fkill_emacs): Call ns_release_autorelease_pool.
801 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
802 autorelease fdesc, release fdAttrs and tdict.
803 (ns_get_covering_families): Release charset.
804 (ns_findfonts): Release NSFontDescriptor created with new.
805 (ns_uni_to_glyphs): Fix indentation.
806 (setString): Release attrStr before assigning new value.
808 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
810 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
812 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
813 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
815 2011-12-18 David Reitter <reitter@cmu.edu>
817 * nsterm.m (ns_term_init): Subscribe for notifications
818 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
819 to method trackingNotification in EmacsMenu.
821 * nsmenu.m (trackingMenu): New variable.
822 (trackingNotification): New method (from Aquamacs).
823 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
824 from Aquamacs (Bug#7030).
826 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
828 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
829 (symbol_to_nsstring): Fix indentation.
830 (ns_symbol_to_pb): New function.
831 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
832 (Fns_rotate_cut_buffers_internal): Remove.
833 (Fns_store_selection_internal): Rename from
834 Fns_store_cut_buffer_internal.
835 (ns_get_foreign_selection, Fx_own_selection_internal)
836 (Fx_disown_selection_internal, Fx_selection_exists_p)
837 (Fns_get_selection_internal, Fns_store_selection_internal):
838 Use ns_symbol_to_pb and check if return value is nil.
839 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
840 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
841 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
842 renamed to Sns_store_selection_internal.
843 (ns_handle_selection_request): Move code to Fx_own_selection_internal
844 and remove this function.
845 (ns_handle_selection_clear): Remove, never used.
846 (Fx_own_selection_internal): Move code from ns_handle_selection_request
849 2011-12-17 Ken Brown <kbrown@cornell.edu>
851 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
852 GID is unknown (Bug#10257).
854 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
856 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
857 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
858 which caused a build failure on GNU/Linux IA-64. This problem was
859 introduced by my 2011-10-07 patch.
861 2011-12-15 Juri Linkov <juri@jurta.org>
863 * image.c (imagemagick_error): New function. (Bug#10112)
864 (imagemagick_load_image): Comment out `MagickSetResolution' call.
865 Use `imagemagick_error' where ImageMagick functions return
867 (Fimagemagick_types): Add `Fnreverse' to return the list in the
870 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
872 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
873 fill background (Bug#8992).
875 2011-12-13 Martin Rudalics <rudalics@gmx.at>
877 * window.c (Vwindow_combination_resize)
878 (Vwindow_combination_limit): Use t instead of non-nil in
880 (Vrecenter_redisplay): Add first sentence of doc-string on
882 (Frecenter): Fix doc-string typo.
884 2011-12-11 Kenichi Handa <handa@m17n.org>
886 * coding.c (Funencodable_char_position): Pay attention to the
887 buffer text relocation (Bug#9389).
889 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
891 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
892 gtk_init (Bug#10100).
894 2011-12-10 Eli Zaretskii <eliz@gnu.org>
896 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
897 IT->string is nil. (Bug#10263)
899 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
901 * nsterm.h (x_free_frame_resources): Declare.
903 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
904 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
906 * nsterm.h (ns_get_defaults_value): Declare.
908 * nsterm.m (ns_default): Call ns_get_defaults_value.
910 2011-12-09 Eli Zaretskii <eliz@gnu.org>
912 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
915 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
917 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
918 that where the value of an _OBJC_* symbol points to is in the .bss
921 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
923 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
924 after the loop to call ccl_driver at least once (Bug#8619).
926 2011-12-08 Kenichi Handa <handa@m17n.org>
928 * ftfont.c (get_adstyle_property): Fix previous change
931 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
933 * w32.c (init_environment): If no_site_lisp, remove site-lisp
934 dirs from the default value of EMACSLOADPATH (bug#10208).
936 2011-12-07 Glenn Morris <rgm@gnu.org>
938 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
939 installation and source directories as well. (Bug#10208)
941 2011-12-06 Chong Yidong <cyd@gnu.org>
943 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
945 2011-12-06 Glenn Morris <rgm@gnu.org>
947 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
948 as an error, not just -1. (Bug#10217)
950 2011-12-05 Chong Yidong <cyd@gnu.org>
952 * keyboard.c (process_special_events): New function.
953 (swallow_events, Finput_pending_p): Use it (Bug#10195).
955 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
957 * coding.c (encode_designation_at_bol): Don't use uninitialized
958 local variable (Bug#9318).
960 2011-12-05 Kenichi Handa <handa@m17n.org>
962 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
963 return Qnil (Bug#8046, Bug#10193).
965 2011-12-05 Kenichi Handa <handa@m17n.org>
967 * coding.c (encode_designation_at_bol): New args charbuf_end and
968 dst. Return the number of produced bytes. Callers changed.
969 (coding_set_source): Return how many bytes coding->source was
971 (coding_set_destination): Return how many bytes
972 coding->destination was relocated.
973 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
974 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
976 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
978 * coding.c (CODING_CHAR_CHARSET_P): New macro.
979 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
982 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
984 The following changes are to fix Bug#9318.
986 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
987 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
988 (encode_coding_iso_2022, encode_coding_sjis)
989 (encode_coding_big5, encode_coding_charset): Use the above macros.
991 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
993 * lisp.h (process_quit_flag): Fix external declaration.
995 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
997 Don't macro-inline non-performance-critical code.
998 * eval.c (process_quit_flag): New function.
999 * lisp.h (QUIT): Use it.
1001 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1003 * nsfns.m (get_geometry_from_preferences): New function.
1004 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1006 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1008 * emacs.c (Qkill_emacs): Define.
1009 (syms_of_emacs): Initialize it.
1010 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1011 Qquit_flag to `kill-emacs' instead.
1012 (quit_throw_to_read_char): Add parameter `from_signal'.
1013 All callers changed. Call Fkill_emacs if requested and safe.
1014 * lisp.h (QUIT): Call Fkill_emacs if requested.
1016 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1018 * widget.c (update_wm_hints): Return if wmshell is null.
1019 (widget_update_wm_size_hints): New function.
1021 * widget.h (widget_update_wm_size_hints): Declare.
1023 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1024 widget_update_wm_size_hints (Bug#10104).
1026 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1028 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1029 before a newline, prepare the bidi iterator for consuming the
1030 newline, and keep the current paragraph direction. (Bug#10183)
1031 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1033 2011-12-02 Juri Linkov <juri@jurta.org>
1035 * search.c (Fword_search_regexp): New Lisp function created from
1036 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1037 (Fword_search_backward, Fword_search_forward)
1038 (Fword_search_backward_lax, Fword_search_forward_lax):
1039 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1040 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1042 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1044 * fileio.c (Finsert_file_contents): Move after-change-function call
1045 to before the "handled:" label, since all "goto handled" appear in
1046 cases where the *-change-functions have already been properly called
1049 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1051 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1052 waiting for input. (Bug#10169)
1054 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1056 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1057 verifies glyph row's hash code--we have just reallocated the
1058 glyphs, so their contents can be complete garbage. (Bug#10164)
1060 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1062 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1064 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1066 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1067 attributes are tested _before_ calling verify_row_hash, to protect
1068 against GCC re-ordering of the tests. (Bug#10164)
1070 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1072 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1074 * xterm.c (handle_one_xevent): Only set async_visible and friends
1075 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1076 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1077 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1079 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1081 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1082 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1083 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1084 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1085 All uses changed to use GCPRO1 etc.
1086 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1087 Revert to old implementation (i.e., before 2011-03-11).
1089 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1091 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1092 of scroll runs so as to avoid assigning disabled bogus rows and
1093 unnecessary graphics copy operations.
1095 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1097 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1098 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1099 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1100 (malloc, free, realloc, calloc): Redirect to e_* only when
1103 * lisp.h (GCTYPEBITS): Move before first use.
1104 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1105 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1106 this macro definition.
1108 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1111 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1113 * gtkutil.c (xg_create_frame_widgets):
1114 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1115 present with Gtk+ 2.0.
1117 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1119 * fileio.c (Finsert_file_contents): Undo previous change; see
1120 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1122 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1124 Rename locals to avoid shadowing.
1125 * fileio.c (Finsert_file_contents):
1126 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1127 * process.c (wait_reading_process_output):
1128 Rename inner 'proc' to 'p' to avoid shadowing.
1129 Indent for consistency with usual Emacs style.
1131 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1133 * xdisp.c (redisplay_window): If cursor row is not fully visible
1134 after recentering, and scroll-conservatively is set to a large
1135 number, scroll window by a few more lines to make the cursor fully
1136 visible and out of scroll-margin. (Bug#10105)
1137 (start_display): Don't move to the next line if the display should
1138 start at a newline that is part of a display vector or an overlay
1141 2011-11-24 Juri Linkov <juri@jurta.org>
1143 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1144 after the `MagickPingImage' call. (Bug#10112)
1146 2011-11-23 Chong Yidong <cyd@gnu.org>
1148 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1150 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1152 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1153 making another buffer current. (Bug#10114)
1155 2011-11-23 Glenn Morris <rgm@gnu.org>
1157 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1159 2011-11-23 Chong Yidong <cyd@gnu.org>
1161 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1162 using it (Bug#5984).
1164 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1166 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1167 and header-lines, as they don't have one computed for them.
1170 * .gdbinit (prow): Make displayed values more self-explaining.
1171 Add row's hash code.
1173 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1175 * process.c (wait_reading_process_output): Fix asynchrounous
1176 GnuTLS socket handling on some versions of the GnuTLS library.
1177 (wait_reading_process_output): Add comment and URL.
1179 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1181 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1183 2011-11-21 Chong Yidong <cyd@gnu.org>
1185 * window.c (Fnext_window, Fprevious_window): Doc fix.
1187 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1189 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1191 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1193 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1195 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1197 * window.c (Fset_window_combination_limit): Rename argument
1199 (Vwindow_combination_limit): Remove "status" from doc-string.
1201 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1203 * m/ibms390.h: Remove.
1204 * m/ibms390x.h: Don't include "ibms390.h".
1206 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1208 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1209 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1211 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1213 * casetab.c (Fset_case_table):
1214 * charset.c (Fcharset_after): Fix typos.
1216 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1218 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1219 Otherwise, valgrind does not work on some platforms.
1220 Problem reported by Andreas Schwab in
1221 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1222 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1223 is set, removing the need for VIRT_ADDRESS_VARIES.
1224 (PURE_P): Use a more-efficient implementation that needs just one
1225 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1226 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1227 to 4 (xorl, subq, cmpq, setbe).
1228 * alloc.c (pure): Always extern now, since that's the
1229 VIRT_ADDR_VARIES behavior.
1230 (PURE_POINTER_P): Use a single comparison, not two, for
1231 consistency with the new puresize.h.
1232 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1233 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1234 Remove VIRT_ADDR_VARIES no longer needed.
1236 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1238 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1239 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1240 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1241 behave as if the cursor position were at the window margin.
1243 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1244 and the cursor position is out of bounds, behave as if the cursor
1245 position were at the window margin. (Bug#10075)
1247 2011-11-18 Chong Yidong <cyd@gnu.org>
1249 * window.c (Fwindow_combination_limit): Make first argument
1250 non-optional, since it is meaningless for live windows like the
1253 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1255 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1257 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1259 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1260 (graft_intervals_into_buffer): Simplify.
1262 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1264 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1265 hash values of the two rows.
1266 (copy_row_except_pointers): Preserve the used[] arrays and the
1267 hash values of the two rows. (Bug#10035)
1268 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1270 * xdisp.c (row_hash): New function, body extracted from
1271 compute_line_metrics.
1272 (compute_line_metrics): Call row_hash, instead of computing the
1275 * dispnew.c (verify_row_hash): Call row_hash for computing the
1276 hash code of a row, instead of duplicating code from xdisp.c.
1278 * dispextern.h (row_hash): Add prototype.
1280 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1282 * frame.c (delete_frame): Don't delete the terminal when the last
1283 X frame is closed if emacs is built with GTK toolkit.
1285 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1287 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1289 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1291 * window.c (Vwindow_splits): Rename to
1292 Vwindow_combination_resize. Suggested by Juri Linkov.
1293 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1296 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1298 * nsfns.m (Fns_font_name):
1299 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1301 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1303 * window.h (window): Rename slot "nest" to "combination_limit".
1304 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1305 (Fset_window_nest): Rename to Fset_window_combination_limit.
1306 (Vwindow_nest): Rename to Vwindow_combination_limit.
1307 (recombine_windows, make_parent_window, make_window)
1308 (Fsplit_window_internal, saved_window)
1309 (Fset_window_configuration, save_window_save): Rename all
1310 occurrences of window_nest to window_combination_limit.
1312 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1314 * image.c (imagemagick_load_image): Fix typo.
1316 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1318 * xdisp.c (display_line): Move the call to
1319 highlight_trailing_whitespace before the call to
1320 compute_line_metrics, since the latter needs to see the final
1321 faces of all the glyphs to compute ROW's hash value.
1322 Fixes assertion violations in row_equal_p. (Bug#10035)
1324 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1326 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1327 just return (bug#10044).
1329 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1331 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1332 with user-defined heap size. Bump the default size of the temacs
1333 heap to 27MB, to avoid memory warning when running temacs.
1334 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1336 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1337 current_matrix and desired_matrix. (Bug#9990)
1338 (verify_row_hash) [XASSERTS]: New function.
1339 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1340 that the hash value of glyph rows is correct.
1342 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1344 * window.h (window): Remove splits slot.
1345 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1346 (Fdelete_other_windows_internal, make_parent_window)
1347 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1348 (Fset_window_configuration, save_window_save): Don't deal with
1349 split status of windows.
1350 (saved_window): Remove splits slot.
1351 (Vwindow_splits): Rewrite doc-string.
1353 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1355 * xfns.c (unwind_create_frame):
1356 * nsfns.m (unwind_create_frame):
1357 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1358 Vframe_list (Bug#9999).
1360 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1362 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1364 2011-11-11 Kenichi Handa <handa@m17n.org>
1366 * callproc.c (Fcall_process): Set the member dst_multibyte of
1369 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1371 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1372 avoid a crash (bug#9496).
1374 2011-11-09 Chong Yidong <cyd@gnu.org>
1376 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1377 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1379 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1381 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1383 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1385 Avoid some portability problems by eschewing 'extern inline' functions.
1386 The trivial performance wins aren't worth the portability hassles; see
1387 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1389 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1390 (window_box_width, window_box_left, window_box_left_offset)
1391 (window_box_right, window_box_right_offset): Undo previous change,
1392 by removing the "extern"s.
1393 * intervals.c (adjust_intervals_for_insertion)
1394 (adjust_intervals_for_deletion): Undo previous change,
1395 making these static again.
1396 (offset_intervals, temp_set_point_both, temp_set_point)
1397 (copy_intervals_to_string): No longer inline.
1398 * xdisp.c (window_text_bottom_y, window_box_width)
1399 (window_box_height, window_box_left_offset)
1400 (window_box_right_offset, window_box_left, window_box_right)
1401 (window_box): No longer inline.
1403 2011-11-08 Chong Yidong <cyd@gnu.org>
1405 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1406 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1407 Signal an error if not a live window.
1408 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1409 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1411 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1413 * lisp.h (syms_of_abbrev): Remove declaration.
1414 Reported by CHENG Gao <chenggao@royau.me>.
1416 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1418 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1419 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1420 of temacs in GUI mode.
1422 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1424 * window.h: Declare delete_all_child_windows instead of
1425 delete_all_subwindows.
1426 * window.c (Fwindow_nest, Fset_window_nest)
1427 (Fset_window_new_total, Fset_window_new_normal)
1428 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1429 (delete_all_subwindows): Rename to delete_all_child_windows.
1430 (Fdelete_other_windows_internal, Fset_window_configuration):
1431 Call delete_all_child_windows instead of delete_all_subwindows.
1432 * frame.c (delete_frame): Call delete_all_child_windows instead
1433 of delete_all_subwindows.
1435 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1437 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1438 This is also needed for porting to any host where GC_MARK_STACK is
1439 not GC_MAKE_GCPROS_NOOPS.
1440 (which_symbols): Use it.
1442 2011-11-07 Kenichi Handa <handa@m17n.org>
1444 * coding.c (coding_set_destination): Check coding->src_pos only
1445 when coding->src_object is a buffer (bug#9910).
1447 * process.c (send_process): Set the member src_multibyte of coding
1448 to 0 (bug#9911) when sending a unibyte text.
1450 * callproc.c (Fcall_process): Set the member src_multibyte of
1451 process_coding to 0 (bug#9912).
1453 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1455 * xmenu.c (cleanup_widget_value_tree): New function.
1456 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1457 calling free_menubar_widget_value_tree directly (Bug#9830).
1459 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1461 Fix some portability problems with 'inline'.
1462 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1463 (window_box_width, window_box_left, window_box_left_offset)
1464 (window_box_right, window_box_right_offset): Declare extern.
1465 Otherwise, these inline functions do not conform to C99 and
1466 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1467 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1468 * intervals.c (adjust_intervals_for_insertion)
1469 (adjust_intervals_for_deletion): Now extern, because otherwise the
1470 extern inline functions 'offset_intervals' couldn't refer to it.
1471 (static_offset_intervals): Remove.
1472 (offset_intervals): Rewrite using the old contents of
1473 static_offset_intervals. The old version didn't conform to C99
1474 because an extern inline function contained a reference to an
1475 identifier with static linkage.
1477 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1479 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1482 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1484 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1485 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1486 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1487 return Qleft_to_right.
1489 2011-11-06 Chong Yidong <cyd@gnu.org>
1491 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1492 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1493 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1494 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1495 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1496 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1497 (Fwindow_vscroll): Doc fix.
1498 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1499 argument, since it makes no sense to pass a live window and for
1500 consistency with window-child.
1502 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1504 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1507 2011-11-05 Jason Rumney <jasonr@gnu.org>
1509 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1510 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1512 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1513 bitwise arithmetic preventing use of unicode-sip and non-truetype
1516 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1518 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1521 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1522 initialization code to keep similarity to xfns.c after changes
1525 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1527 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1528 (unwind_create_frame): New function (Bug#9943).
1529 (Fx_create_frame): Restructure code to be more similar to the one in
1530 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1531 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1532 Move terminal->reference_count++ just before making the frame official
1535 * nsterm.m (x_free_frame_resources): New function.
1536 (x_destroy_window): Move code to x_free_frame_resources.
1538 * xfns.c (unwind_create_frame): Fix comment.
1539 (Fx_create_frame, x_create_tip_frame):
1540 Move terminal->reference_count++ just before making the frame
1541 official. Move initialization of image_cache_refcount and
1542 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1544 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1546 Support MSVC build with newer versions of Visual Studio.
1547 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1548 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1551 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1552 which are not supported by MSVC.
1553 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1554 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1556 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1558 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1560 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1562 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1564 Support MSVC build with newer versions of Visual Studio.
1565 * w32.c: Don't include w32api.h for MSVC.
1566 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1568 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1569 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1570 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1571 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1573 (alloca) [_MSC_VER]: Define to _alloca.
1575 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1577 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1579 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1581 * xdisp.c (note_mouse_highlight): If either of
1582 previous/next-single-property-change returns nil, treat that as
1583 the beginning or the end of the buffer. (Bug#9955)
1585 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1587 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1588 label is not null (Bug#9951).
1589 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1592 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1594 * window.c (Fwindow_body_size): Mention in the doc string that the
1595 return value is in frame's canonical units. (Bug#9949)
1597 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1599 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1601 * w32fns.c (unwind_create_frame): If needed, free the glyph
1602 matrices of the partially constructed frame. (Bug#9943)
1603 * xfns.c (unwind_create_frame): Likewise.
1605 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1607 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1608 Don't stop backward scan on the continuation glyph, even though
1609 its CHARPOS is positive.
1610 (mouse_face_from_buffer_pos, note_mouse_highlight):
1611 Rename cover_string to disp_string.
1613 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1615 * window.c (temp_output_buffer_show): Don't use
1616 Vtemp_buffer_show_specifiers.
1617 (Vtemp_buffer_show_specifiers): Remove unused variable.
1619 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1621 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1622 past the beginning of the current glyph matrix.
1624 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1626 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1627 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1628 HAVE_GTK3 (Bug#9869).
1630 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1631 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1633 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1635 * xterm.c: Declare x_handle_net_wm_state to return int.
1636 (handle_one_xevent): Check if we are iconified but don't have
1637 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1638 (get_current_wm_state): Return non-zero if not hidden,
1639 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1640 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1641 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1642 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1644 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1646 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1647 so that this new function doesn't get optimized away by a
1648 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1650 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1652 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1654 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1656 Fix the `xbytecode' command.
1657 * .gdbinit (xprintbytestr): New command.
1658 (xwhichsymbols): Rename from `which'; all callers changed.
1659 (xbytecode): Print the byte-code string as well.
1661 2011-10-29 Kim Storm <storm@cua.dk>
1663 * alloc.c (which_symbols): New function.
1665 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1667 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1670 2011-10-29 Glenn Morris <rgm@gnu.org>
1672 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1673 Not clear what it was for, and it causes various bugs. (Bug#9839)
1675 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1677 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1678 possible random value that matches one of those tested as
1679 condition to clear the mouse face.
1681 2011-10-28 Chong Yidong <cyd@gnu.org>
1683 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1685 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1687 * window.c (make_window): Initialize phys_cursor_on_p.
1689 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1691 * lisp.h (struct Lisp_Symbol): Update comments.
1693 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1695 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1697 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1699 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1700 <oslsachem@gmail.com> for helping to debug this.
1702 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1703 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1704 (g_b_init_get_glyph_outline_w): New static variables.
1705 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1706 (GetGlyphOutlineW_Proc): New typedefs.
1707 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1708 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1710 (w32font_open_internal, compute_metrics):
1711 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1712 instead of calling the "wide" APIs directly.
1714 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1716 * w32.h (syms_of_w32font): Add prototype.
1718 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1720 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1721 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1722 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1723 (Fmove_to_window_line): Doc fix.
1725 2011-10-27 Chong Yidong <cyd@gnu.org>
1727 * process.c (make_process): Set gnutls_state to NULL.
1729 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1730 non-NULL, regardless of GNUTLS_INITSTAGE.
1731 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1732 an error. Set process slots as soon as we allocate them.
1734 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1736 2011-10-27 Chong Yidong <cyd@gnu.org>
1738 * gnutls.c (emacs_gnutls_deinit): New function.
1739 Deallocate credentials structures as well as calling gnutls_deinit.
1740 (Fgnutls_deinit, Fgnutls_boot): Use it.
1742 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1743 (deactivate_process): Call emacs_gnutls_deinit.
1745 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1747 * image.c (x_create_x_image_and_pixmap):
1748 * w32.c (sys_rename, w32_delayed_load):
1749 * w32font.c (fill_in_logfont):
1750 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1752 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1754 * w32fns.c (w32_default_color_map): New function,
1755 extracted from Fw32_default_color_map.
1756 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1758 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1760 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1762 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1764 * keyboard.c (test_undefined): New function (bug#9751).
1765 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1767 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1769 * sysdep.c (init_sys_modes): Fix the check for the controlling
1770 terminal (Bug#6649).
1772 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1774 * dispextern.h (struct bidi_it): New member next_en_type.
1776 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1777 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1778 current character, check also for next_en_type being WEAK_EN.
1779 (bidi_resolve_weak): Don't enter the expensive loop if the current
1780 position is before next_en_pos. Record the bidi type of the first
1781 non-ET, non-BN character we find, in addition to its position.
1782 (bidi_level_of_next_char): Invalidate next_en_type when
1783 next_en_pos is over-stepped.
1785 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1787 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1788 * editfns.c: Rewrite current-time-zone so that it invokes
1789 the equivalent of (format-time-string "%Z") to get the time zone name.
1790 This fixes a bug when the time zone name contains characters that
1791 need converting from the system time locale to Emacs internal format.
1792 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1793 that patch fixed format-time-string to do the conversion, but
1794 I forgot to fix current-time-zone.
1795 (format_time_string): New function, containing most of
1796 what Fformat_time_string used to contain.
1797 (Fformat_time_string): Rewrite in terms of format_time_string.
1798 This doesn't change this function's behavior.
1799 (current-time-zone): Rewrite to use format_time_string.
1800 This fixes the bug reported by Michael Schierl in
1801 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1802 Jason Rumney's 2007-06-07 change worked around this bug, but
1804 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1806 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1808 * xdisp.c (start_display): If the character at POS is displayed
1809 via a display vector, reset IT->current.dpvec_index to zero.
1810 (try_window_reusing_current_matrix): If a line ends in a display
1811 vector or the next line starts in a display vector, continue
1812 redrawing the window even though the character position of
1813 start_row was reached.
1816 2011-10-18 Chong Yidong <cyd@gnu.org>
1818 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1819 with nobreak-char-display too.
1821 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1823 Fix part 3 of bug#9771.
1824 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1825 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1826 non-neutral characters if the current character is a paragraph
1827 separator (a.k.a. Newline). This avoids running the same
1828 expensive loop twice, once when we consume the preceding newline
1829 and the other time when the line actually needs to be displayed.
1830 Avoid the loop when we see neutrals on the base embedding level
1831 following a character whose directionality is the same as the
1832 paragraph's. This avoids running the expensive loop when a line
1833 ends in a long sequence of neutrals, like control characters.
1834 Add assertion against STRONG_AL type. Slightly rearrange code
1835 that determines the type of a neutral given the first non-neutral
1837 (bidi_level_of_next_char): Set next_en_pos to zero when
1838 invalidating its info.
1840 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1842 * xdisp.c (push_display_prop): Determine whether to record string
1843 or buffer position by IT->string, not by IT->method. Allow
1844 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1845 (move_it_vertically_backward): Don't look for character position
1846 immediately after the newline when in a continuation line.
1849 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1851 * window.c (coordinates_in_window): Rewrite and delabelize
1852 vertical border check. (Bug#5357) (Bug#9618)
1854 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1856 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1857 errors in XSetWindowBorder (bug#9310).
1859 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1861 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1862 avoid crash when xmalloc overrun checking is enabled.
1864 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1866 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1867 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1868 cursor motion with <left> and <right> arrow keys.
1870 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1871 some callers set that themselves.
1873 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1875 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1876 display string and the previous row comes from the same string and
1877 is empty. (Bug#9739) (Bug#9738)
1879 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1881 * doc.c (get_doc_string): Encode file name (bug#9735).
1883 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1885 * bidi.c (bidi_level_of_next_char):
1886 * xdisp.c (get_visually_first_element): Remove old incorrect
1887 comments regarding the Unicode Line Separator character.
1889 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1891 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1893 * alloc.c (Fgc_status): Do not access beyond zombies array
1894 boundary if nzombies > MAX_ZOMBIES.
1895 * alloc.c (dump_zombies): Add missing format specifier.
1897 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1899 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1900 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1902 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1903 Some packages use them to denote characters with modifiers.
1905 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1907 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1908 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1909 matching a pp-number. Rename parameter var to var1.
1911 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1913 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1915 2011-10-08 Glenn Morris <rgm@gnu.org>
1917 * callint.c (Fcall_interactively): Give a more explicit error for the
1918 'c' case with a non-character input. (Bug#8479)
1920 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1922 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1924 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1925 lines that are hscrolled on the left.
1927 * dispnew.c (buffer_posn_from_coords): Account for a possible
1928 presence of header-line. (Bug#4426)
1930 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1932 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1933 Don't advertise functionality which we discourage or doesn't work.
1935 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1937 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1938 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1939 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1940 this makes Emacs dump core during garbage collection on rare
1941 occasions. sizeof is obviously inferior to offsetof here, so
1942 stick with offsetof.
1943 (GC_POINTER_ALIGNMENT): New macro.
1944 (mark_memory): Omit 3rd (offset) arg; caller changed.
1945 Don't assume EMACS_INT alignment is the same as pointer alignment.
1947 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1949 * keyboard.c (read_key_sequence_remapped): New var.
1950 (read_key_sequence): Compute remapping in the right buffer.
1951 (command_loop_1): Use read_key_sequence's remapping directly.
1953 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1955 * dired.c (file_name_completion): Don't expand file name.
1956 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1957 before checking file name handler.
1959 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1960 they've been requested explicitly (bug#9591).
1962 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1964 * keymap.c (Fsingle_key_description): Use make_specified_string
1965 instead of build_string to build string from push_key_description.
1968 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1970 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1971 This fixes a Y2038 bug on 64-bit hosts.
1972 * buffer.c (reset_buffer):
1973 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1974 (Fclear_buffer_auto_save_failure):
1975 Use 0, not -1, to represent an unset failure time, since time_t
1976 might not be signed.
1978 Remove dependency on glibc malloc internals.
1979 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1980 Move back here from lisp.h, but with their new implementations.
1981 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1982 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1983 * charset.c (charset_table_init): New static var.
1984 (syms_of_charset): Use it instead of xmalloc. This removes a
1985 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1986 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1987 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1988 Move back to alloc.c.
1989 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1990 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1992 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1994 * nsterm.m (windowDidResize): Call x_set_window_size only when
1995 ns_in_resize is true. Otherwise set pixelwidth/height and
1996 call change_frame_size (Bug#9628).
1998 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2000 Port --enable-checking=all to Fedora 14 x86-64.
2001 * charset.c (syms_of_charset): Also account for glibc malloc's
2002 internal overhead when calculating the initial malloc maximum.
2004 Port --enable-checking=all to Fedora 14 x86.
2005 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2007 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2008 (overrun_check_realloc, overrun_check_free):
2009 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2010 That way, xmalloc returns a properly-aligned pointer even if
2011 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2012 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2013 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2014 into account when calculating the initial malloc maximum.
2015 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2016 Move here from alloc.c, so that charset.c can use it too.
2017 Properly align; the old code wasn't right for common 32-bit hosts
2018 when configured with --enable-checking=all.
2019 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2020 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2022 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2024 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2027 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2029 * xdisp.c (compute_display_string_end): If there's no display
2030 string at CHARPOS, return -1.
2032 * bidi.c (bidi_fetch_char): When compute_display_string_end
2033 returns a negative value, treat the character as a normal
2034 character not covered by a display string. (Bug#9624)
2036 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2038 * lread.c (Fread_from_string): Fix typo in docstring.
2040 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2042 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2043 newline, reseat the iterator instead of bidi-iterating there one
2044 character at a time. (Bug#9610)
2045 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2046 TO_CHARPOS if the bidi iterator is at base embedding level.
2048 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2050 * lread.c (readevalloop): Use correct code for NBSP.
2051 (read1): Likewise. (Bug#9608)
2053 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2055 * dbusbind.c (Fdbus_register_signal): When service is not
2056 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2058 2011-09-25 Glenn Morris <rgm@gnu.org>
2060 * buffer.c (truncate-lines): Doc fix.
2062 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2064 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2065 (Fset_window_next_buffers): Doc fix.
2067 2011-09-24 Glenn Morris <rgm@gnu.org>
2069 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2071 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2073 Fix minor problems found by static checking.
2074 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2075 * indent.c (Fvertical_motion): Fix == vs = typo.
2077 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2079 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2080 Default value is now t. Doc fix.
2082 * indent.c (Fvertical_motion): Compute and apply the overshoot
2083 logic when moving up, not only when moving down. Fix the
2084 confusing name and values of the it_overshoot_expected variable;
2085 logic changes accordingly. (Bug#9254) (Bug#9549)
2087 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2088 CHARPOS is covered by a display string which includes newlines.
2089 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2090 is covered by a display string with embedded newlines.
2092 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2094 * dbusbind.c (Fdbus_register_signal): Add match rule to
2095 Vdbus_registered_objects_table. (Bug#9581)
2096 (Fdbus_register_method, Vdbus_registered_objects_table):
2099 2011-09-24 Jim Meyering <meyering@redhat.com>
2101 do not ignore write error for any output size
2102 The previous change was incomplete.
2103 While it makes emacs --batch detect the vast majority of stdout
2104 write failures, errors were still ignored whenever the output size is
2105 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2106 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2107 && echo FAIL: ignored write error
2108 FAIL: ignored write error
2109 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2110 && echo FAIL: ignored write error
2111 FAIL: ignored write error
2112 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2114 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2116 * emacs.c (Fkill_emacs): In noninteractive mode exit
2117 non-successfully if a write error occurred on stdout. (Bug#9574)
2119 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2121 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2124 * dispextern.h (struct it): Update the comment documenting what
2127 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2129 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2130 a display string, extend search for cursor position to end of row.
2131 (find_row_edges): If the row ends in a newline from a display
2132 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2133 Handle the case of a display string with multiple newlines.
2134 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2135 non-empty line. Fixes confusing cursor motion with arrow keys at
2136 the beginning of a line that starts with whitespace.
2138 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2140 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2143 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2145 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2148 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2150 * xdisp.c (display_line): Record maximum and minimum buffer
2151 positions even if no glyphs were produced (e.g., by a zero-width
2152 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2153 buffer positions that will be removed from the glyph row because
2155 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2156 column is beyond frame width: don't subtract 1 "pixel" when
2157 computing width of the stretch.
2158 (reseat_at_next_visible_line_start): Undo the change made on
2159 2011-09-17 that saved paragraph information and restored it after
2160 the call to `reseat'. (Bug#9545)
2162 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2164 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2165 and turn window cursor on if cleared (Bug#9415).
2167 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2169 * search.c (boyer_moore): Take unibyte characters from pattern
2170 literally. (Bug#9458)
2172 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2174 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2176 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2178 Fix minor problem found by static checking.
2179 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2180 initialized, to pacify gcc -Wuninitialized.
2182 * fileio.c: Report proper errno when syscall falls.
2183 (Finsert_file_contents): Save and restore errno,
2184 so that report_file_error outputs the correct diagnostic.
2185 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2187 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2189 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2191 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2193 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2194 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2196 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2198 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2199 about the current paragraph and restore it after the call to reseat.
2201 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2202 (bidi_find_paragraph_start): Search back for paragraph beginning
2203 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2204 (bidi_move_to_visually_next): Only trigger paragraph-related
2205 computations when the last character is a newline or at EOB, not
2206 just any NEUTRAL_B. (Bug#9470)
2208 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2209 truncated lines if point is covered by a display string. (Bug#9524)
2211 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2213 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2214 (cons_to_x_long): New function.
2215 (lisp_data_to_selection_data): Use it. Correct the test for
2216 short-versus-long data; it was negated. Break out of vector
2217 loop, for efficiency, when a long datum is discovered.
2219 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2221 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2223 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2225 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2226 GCC PR/17406) by declaring this function with external scope.
2228 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2230 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2231 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2233 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2235 * editfns.c (Fformat): Correctly handle text properties on "%%".
2237 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2239 * xterm.c (x_draw_composite_glyph_string_foreground):
2240 * w32term.c (x_draw_composite_glyph_string_foreground):
2241 * term.c (encode_terminal_code):
2242 * composite.c (composition_update_it, get_composition_id):
2243 * xdisp.c (get_next_display_element)
2244 (fill_composite_glyph_string): Add comments about special meaning
2245 of TAB characters in a composition.
2247 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2249 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2250 This occurs when processing a multibyte format.
2251 Problem reported by Wolfgang Jenker.
2253 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2255 * xdisp.c (try_cursor_movement): Only check for exact match if
2256 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2258 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2260 Remove unused external symbols.
2261 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2262 * xdisp.c (calc_pixel_width_or_height): Now static.
2263 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2264 * indent.c (check_display_width):
2265 * w32term.c: Fix comment to match code.
2266 * xterm.c, xterm.h (x_catching_errors): Remove.
2268 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2270 * xselect.c: Use signed conversions more consistently (Bug#9498).
2271 (selection_data_to_lisp_data): Assume incoming selection data are
2272 signed integers, not unsigned. This is to be consistent with
2273 outgoing selection data, which was modified to use signed integers
2274 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2275 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2276 expects long, not unsigned long.
2278 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2280 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2281 computation of loop end. Reported by Johan Bockgård
2284 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2286 * frame.c (Fother_visible_frames_p): Function deleted.
2288 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2290 * indent.c (compute_motion): Process display vector front to back
2291 rather than the other way around. (Bug#2496)
2293 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2295 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2297 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2299 * minibuf.c (Fread_from_minibuffer): Doc fix.
2301 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2303 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2304 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2306 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2308 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2309 value for non-existent files.
2311 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2313 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2314 set its "size" to -1. This will set the modtime_size field of
2315 the corresponding buffer to -1, which is what
2316 verify-visited-file-modtime expects for files that do not exist.
2319 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2321 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2323 * lisp.h: ... from here. push_key_description is no longer
2324 defined in keyboard.c, so its declaration should not be in
2325 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2326 logically belongs with push_key_description.
2328 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2330 * buffer.h: Include <sys/types.h> instead of <time.h>.
2331 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2332 Problem reported by Herbert J. Skuhra.
2334 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2336 * xml.c (parse_region): Make the parsing work for
2337 non-comment-starting XML files again (bug#9144).
2339 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2341 * image.c (gif_load): Fix calculation of bottom and right corner.
2344 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2346 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2347 redisplay in small windows.
2349 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2351 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2353 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2355 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2356 Operate on live windows only.
2358 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2360 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2362 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2364 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2365 only under bidi iteration.
2367 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2369 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2371 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2373 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2374 Without this fix, the command to link temacs failed due to an
2375 undefined symbol __builtin_isnan. This is because
2376 /usr/include/iso/math_c99.h #defines isnan(x) to
2377 __builtin_isnan(x), but the bundled gcc, which identifies itself
2378 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2380 * floatfns.c (isnan): #undef, and then #define to a clone of
2382 (Fisnan): Always define, since it's always available now.
2383 (syms_of_floatfns): Always define isnan at the Lisp level.
2385 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2387 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2389 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2391 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2392 The previous code assumed that file offsets (off_t values) fit in
2393 EMACS_INT variables, which is not true on typical 32-bit hosts.
2394 The code messed up by falsely reporting buffer overflow in cases
2395 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2396 when "big" contains more than 2**29 bytes, even though this
2397 inserts just one byte and does not overflow the buffer.
2398 (Finsert_file_contents): Store file offsets as off_t
2399 values, not as EMACS_INT values. Check for overflow when
2400 converting between EMACS_INT and off_t. When checking for
2401 buffer overflow or for overlap, take the offsets into account.
2402 Don't use EMACS_INT for small values where int suffices.
2403 When checking for overlap, fix a typo: ZV was used where
2404 ZV_BYTE was intended.
2405 (Fwrite_region): Don't assume off_t fits into 'long'.
2406 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2408 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2410 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2412 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2414 sprintf-related integer and memory overflow issues (Bug#9412).
2416 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2417 (esprintf, exprintf, evxprintf): New functions.
2418 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2419 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2420 (modify_event_symbol): Do not assume that the length of
2421 name_alist_or_stem is safe to alloca and fits in int.
2422 (Fexecute_extended_command): Likewise for function name and binding.
2423 (Frecursion_depth): Wrap around reliably on integer overflow.
2424 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2425 since some callers pass EMACS_INT values.
2426 (Fsingle_key_description): Don't crash if symbol name contains more
2427 than MAX_ALLOCA bytes.
2428 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2429 (get_minibuffer): Arg is now EMACS_INT, not int.
2430 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2431 (esprintf, exprintf, evxprintf): New decls.
2432 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2434 * dbusbind.c (signature_cat): New function.
2435 (xd_signature, Fdbus_register_signal):
2436 Do not overrun buffer; instead, report string overflow.
2438 * dispnew.c (add_window_display_history): Don't overrun buffer.
2439 Truncate instead; this is OK since it's just a log.
2441 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2442 even if the time zone offset is outlandishly large.
2443 Don't mishandle offset == INT_MIN.
2445 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2446 when creating daemon; the previous buffer-overflow check was incorrect.
2448 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2449 which has the guts of the old verror function.
2451 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2452 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2454 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2455 (font_unparse_xlfd): Don't blindly alloca long strings.
2456 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2457 fits in int, when using sprintf. Use single snprintf to count
2458 length of string rather than counting it via multiple sprintfs;
2459 that's simpler and more reliable.
2460 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2461 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2462 sprintf, in case result does not fit in int.
2464 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2465 (fontset_from_font): Print it.
2467 * frame.c (tty_frame_count): Now printmax_t, not int.
2468 (make_terminal_frame, set_term_frame_name): Print it.
2469 (x_report_frame_params): In X, window IDs are unsigned long,
2470 not signed long, so print them as unsigned.
2471 (validate_x_resource_name): Check for implausibly long names,
2472 and don't assume name length fits in 'int'.
2473 (x_get_resource_string): Don't blindly alloca invocation name;
2474 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2477 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2478 (xg_check_special_colors, xg_set_geometry):
2479 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2481 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2482 Use esprintf, not sprintf, in case result does not fit in int.
2484 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2485 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2486 it as a large positive number.
2487 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2488 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2490 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2491 in case result does not fit in int.
2493 * print.c (float_to_string): Detect width overflow more reliably.
2494 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2495 buffer overrun. Don't assume list length fits in 'int'. Treat
2496 print length of 0 as 0, not as infinity; to be consistent with other
2497 uses of print length in this function. Don't overflow print length
2498 index. Don't assume hash table size fits in 'long', or that
2499 vectorlike size fits in 'unsigned long'.
2501 * process.c (make_process): Use printmax_t, not int, to format
2502 process-name gensyms.
2504 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2506 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2507 to avoid potential buffer overrun.
2509 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2510 if X resource line is longer than 512 bytes.
2512 * xfns.c (x_window): Make sprintf buffer a bit bigger
2513 to avoid potential buffer overrun.
2515 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2517 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2519 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2521 Integer overflow fixes for scrolling, etc.
2522 Without these, Emacs silently mishandles large integers sometimes.
2523 For example, "C-u 4294967297 M-x recenter" was treated as if
2524 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2526 * xdisp.c (try_window_id): Check Emacs fixnum range before
2527 converting to 'int'.
2529 * window.c (window_scroll_line_based, Frecenter):
2530 Check that an Emacs fixnum is in range before assigning it to 'int'.
2531 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2532 values converted from Emacs fixnums.
2533 (Frecenter): Don't wrap around a line count if it is out of 'int'
2534 range; instead, treat it as an extreme value.
2535 (Fset_window_configuration, compare_window_configurations):
2536 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2538 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2539 that can exceed INT_MAX. Check that EMACS_INT value is in range
2540 before assigning it to the (possibly-narrower) index.
2541 (match_limit): Don't assume that a fixnum can fit in 'int'.
2543 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2546 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2547 (Fvertical_motion): Don't wrap around LINES values that don't fit
2548 in 'int'. Instead, treat them as extreme values. This is good
2549 enough for windows, which can't have more than INT_MAX lines anyway.
2551 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2553 * Require libxml/parser.h to avoid compilation warning.
2555 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2557 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2558 since this reportedly can destroy thread storage.
2560 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2562 * syntax.c (find_defun_start): Update all cache variables if
2563 exiting early (Bug#9401).
2565 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2567 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2569 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2570 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2571 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2573 * term.c (tty_append_glyph): New function.
2574 (produce_stretch_glyph): Static function and its prototype deleted.
2576 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2579 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2581 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2582 when checking :margin (Bug#9390).
2583 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2584 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2585 so that the name doesn't mislead. All uses changed.
2587 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2589 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2592 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2594 * xdisp.c (move_it_to): Don't bail out early when reaching
2595 position beyond to_charpos, if we are scanning backwards.
2596 (move_it_vertically_backward): When DY == 0, make sure we get to
2597 the first character in the line after the newline.
2599 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2601 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2602 (ccl_driver): Do not generate an out-of-range pointer.
2603 (Fccl_execute_on_string): Remove unnecessary check for
2604 integer overflow, noted by Stefan Monnier in
2605 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2606 Remove a FIXME that didn't need fixing.
2607 Simplify the newly-introduced buffer reallocation code.
2609 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2611 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2613 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2615 Integer and memory overflow issues (Bug#9196).
2617 * doc.c (get_doc_string): Rework so that
2618 get_doc_string_buffer_size is the actual buffer size, rather than
2619 being 1 less than the actual buffer size; this makes xpalloc more
2622 * image.c (x_allocate_bitmap_record, cache_image):
2623 * xselect.c (Fx_register_dnd_atom):
2624 Simplify previous changes by using xpalloc.
2626 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2627 since either will do and ptrdiff_t is convenient with xpalloc.
2629 * charset.c (charset_table_size)
2630 (struct charset_sort_data.priority): Now ptrdiff_t.
2631 (charset_compare): Don't overflow if priorities differ greatly.
2632 (Fsort_charsets): Don't assume list length fits in int.
2633 Check for size-calculation overflow when allocating sort data.
2634 (syms_of_charset): Allocate an initial charset table that is
2635 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2637 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2639 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2640 The actual value is always <= INT_MAX, and leaving it unsigned made
2641 overflow checking harder.
2643 * dispextern.h (struct glyph_matrix.rows_allocated)
2644 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2645 with xpalloc. The values are still always <= INT_MAX.
2647 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2649 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2650 (SAFE_NALLOCA): New macro.
2652 * region-cache.c (struct boundary.pos, find_cache_boundary)
2653 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2654 (set_cache_region, invalidate_region_cache)
2655 (revalidate_region_cache, know_region_cache, region_cache_forward)
2656 (region_cache_backward, pp_cache):
2657 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2658 so that ptrdiff_t * can be passed to xpalloc.
2659 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2660 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2661 (pp_cache): Don't assume cache_len fits in int.
2662 * region-cache.h: Adjust extern decls to match.
2664 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2665 EMACS_INT, since either will do, for xpalloc.
2667 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2668 (xnmalloc, xnrealloc, xpalloc): New functions.
2670 * bidi.c (bidi_shelve_header_size): New constant.
2671 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2672 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2674 * bidi.c (bidi_cache_shrink):
2675 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2677 Don't update size of array until after memory allocation succeeds,
2678 because xmalloc/xrealloc may not return.
2679 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2680 now that we have proper integer overflow checking.
2681 (record_overlay_string, overlay_strings): Catch overflows when
2682 calculating size of overlay_str_buf.
2684 * callproc.c (Fcall_process): Check for size overflow when
2685 calculating size of args2.
2686 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2687 Normally we prefer signed values, but sticking with ptrdiff_t would
2688 require adding more-complicated checks.
2690 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2691 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2692 Redo buffer-overflow calculations to avoid integer overflow.
2693 Add a FIXME comment where memory seems to be over-allocated.
2695 * character.c (Fstring): Check for size-calculation overflow.
2697 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2698 unnecessary integer overflow. Check for size overflow.
2699 (encode_coding_object): Don't update size until xmalloc succeeds.
2701 * composite.c (get_composition_id): Check for overflow in glyph
2702 length calculations.
2704 Integer and memory overflow fixes for display code.
2705 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2706 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2707 (scrolling_window): Check for overflow in size calculations.
2708 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2709 Don't assume glyph table len fits in int.
2710 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2711 (row_table_size): Now ptrdiff_t, not int.
2712 (scrolling_window): Avoid overflow in size calculations.
2713 Don't update size until allocation succeeds.
2714 * fns.c (concat): Check for overflow in size calculations.
2715 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2716 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2717 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2719 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2720 (get_doc_string): Check for size calculation overflow.
2721 Don't update size until allocation succeeds.
2722 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2723 EMACS_INT, where ptrdiff_t will do.
2724 (Fsubstitute_command_keys): Check for string overflow.
2726 * editfns.c (set_time_zone_rule): Don't assume environment length
2728 (message_length): Now ptrdiff_t, not int.
2729 (Fmessage_box): Don't update size until allocation succeeds.
2730 Don't assume message length fits in int.
2731 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2733 * emacs.c (main): Do not reallocate argv, since there is a null at
2734 the end that can be overwritten, and this way there's no need to
2735 worry about size-calculation overflow.
2736 (sort_args): Check for size-calculation overflow.
2738 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2740 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2742 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2743 (x_set_scroll_bar_width, x_figure_window_size):
2744 Check for integer overflow.
2745 (x_set_alpha): Do not assume XINT fits in int.
2747 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2748 This is for the members text_lines, text_cols, total_lines, total_cols,
2749 where the system imposes an 'int' limit.
2751 * fringe.c (Fdefine_fringe_bitmap):
2752 Don't update size until alloc works.
2754 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2755 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2757 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2758 Check for size-calculation overflow.
2759 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2760 do, as we prefer signed integers.
2761 (id_to_widget.max_size, id_to_widget.used)
2762 (xg_store_widget_in_map, xg_remove_widget_from_map)
2763 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2764 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2765 Use and return ptrdiff_t, not int.
2766 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2767 * gtkutil.h: Change prototypes to match the above.
2769 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2770 are duplicate now that they've been promoted to lisp.h.
2771 (x_allocate_bitmap_record, x_alloc_image_color)
2772 (make_image_cache, cache_image, xpm_load):
2773 Don't update size until alloc is done.
2774 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2776 Check for size calculation overflow.
2777 (ct_colors_allocated_max): New constant.
2778 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2781 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2782 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2783 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2784 Use ptrdiff_t, not int, to count maps.
2785 (read_char_minibuf_menu_prompt): Check for overflow in size
2786 calculations. Don't update size until allocation succeeds.
2787 Redo calculations to avoid overflow.
2788 * keyboard.h: Change prototypes to match the above.
2790 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2792 (current_minor_maps): Check for size calculation overflow.
2793 * keymap.h: Change prototypes to match the above.
2795 * lread.c (read1, init_obarray): Don't update size until alloc done.
2797 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2798 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2800 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2801 Now ptrdiff_t, not int.
2802 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2803 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2805 * process.c (Fnetwork_interface_list): Check for overflow
2806 in size calculation.
2808 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2810 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2811 overflow. Don't bother calling xmalloc when xrealloc will do.
2813 * search.c (Freplace_match): Check for size calculation overflow.
2814 (Fset_match_data): Don't assume list lengths fit in 'int'.
2816 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2817 for command line length. Do not attempt to address one before the
2818 beginning of an array, as that's not portable.
2820 * term.c (max_frame_lines): Remove; unused.
2821 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2823 (encode_terminal_code, calculate_costs): Check for size
2824 calculation overflow.
2825 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2826 table lengths and related sizes. Don't update size until alloc
2827 done. Redo calculations to avoid overflow.
2828 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2830 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2831 subtracting pointers.
2832 (gobble_line): Check for overflow more carefully. Don't update size
2835 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2836 Don't update size until alloc done.
2837 Redo size calculations to avoid overflow.
2838 Check for size calculation overflow.
2839 (main) [DEBUG]: Fix typo in invoking tparam1.
2841 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2842 Use ptrdiff_t, not int, for sizes.
2843 (store_mode_line_noprop_char): Don't update size until alloc done.
2845 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2846 Use ptrdiff_t, not int, for sizes.
2847 (Finternal_make_lisp_face, cache_face):
2848 Check for size calculation overflow.
2849 (cache_face): Treat size calculation overflows as if they were
2850 memory exhaustion (the usual treatment), rather than aborting.
2852 * xfns.c (x_encode_text, x_set_name_internal)
2853 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2854 sizes, since they can exceed INT_MAX in size. Check for size
2855 calculation overflow.
2857 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2858 (xg_select): Check for size calculation overflow.
2859 Don't update size until alloc done.
2861 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2862 as sprintf is limited to int lengths.
2864 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2865 (X_LONG_MIN): New macros.
2866 Use them to make the following changes clearer.
2867 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2868 This change doesn't affect the value now, but it may help remind
2869 future maintainers not to raise the value too much later.
2870 (SELECTION_QUANTUM): Remove, replacing with ...
2871 (selection_quantum): ... new function, which avoids overflow.
2873 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2874 assumption that selection length fits in 'int'.
2875 (x_reply_selection_request, x_handle_selection_request)
2876 (x_get_window_property, receive_incremental_selection)
2877 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2878 (lisp_data_to_selection_data, clean_local_selection_data):
2879 Use ptrdiff_t, not int, to record length of selection.
2880 (x_reply_selection_request, x_get_window_property)
2881 (receive_incremental_selection, x_property_data_to_lisp):
2882 Redo calculations to avoid overflow.
2883 (x_reply_selection_request): When sending hint, ceiling it at
2884 X_LONG_MAX rather than relying on wraparound overflow to send
2886 (x_get_window_property, receive_incremental_selection)
2887 (lisp_data_to_selection_data, x_property_data_to_lisp):
2888 Check for size-calculation overflow.
2889 (x_get_window_property, receive_incremental_selection)
2890 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2891 Don't store size until memory allocation succeeds.
2892 (x_get_window_property): Plug memory leak on memory exhaustion.
2893 Don't double-block input; malloc is safe here. Don't assume 2**34
2894 - 4 fits in unsigned long. Add an xassert to check
2895 XGetWindowProperty overflow. Be more careful about overflow
2896 calculations, and distinguish size from memory overflow better.
2897 (receive_incremental_selection): When tracing, don't assume
2898 unsigned int is less than INT_MAX.
2899 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2900 harmful) conversions of unsigned short to int.
2901 (lisp_data_to_selection_data): Don't assume that integers
2902 in the range -65535 through -1 fit in an X unsigned short.
2903 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2904 result parameters unless successful. Rely on cons_to_unsigned
2905 to report problems with elements; the old code wasn't right anyway.
2906 (x_check_property_data): Check for int overflow; we cannot use
2907 a wider type due to X limits.
2908 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2910 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2912 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2913 (x_term_init): Check for size calculation overflow.
2914 (x_color_cells): Don't store size until memory allocation succeeds.
2915 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2916 Don't assume alloca size is less than MAX_ALLOCA.
2917 (x_term_init): Don't assume length fits in int (sprintf is limited
2920 Use ptrdiff_t for composition IDs.
2921 * character.c (lisp_string_width):
2922 * composite.c (composition_table_size, n_compositions)
2923 (get_composition_id, composition_gstring_from_id):
2924 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2925 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2926 * window.c (Frecenter):
2927 Use ptrdiff_t, not int, for composition IDs.
2928 * composite.c (get_composition_id): Check for integer overflow.
2929 * composite.h: Adjust prototypes to match the above changes.
2931 Use ptrdiff_t for hash table indexes.
2932 * category.c (hash_get_category_set):
2933 * ccl.c (ccl_driver):
2934 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2935 * coding.c (coding_system_charset_list, detect_coding_system):
2936 * coding.h (struct coding_system.id):
2937 * composite.c (get_composition_id, gstring_lookup_cache):
2938 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2939 * image.c (xpm_get_color_table_h):
2940 * lisp.h (hash_lookup, hash_put):
2941 * minibuf.c (Ftest_completion):
2942 Use ptrdiff_t for hash table indexes, not int (which is too
2943 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2944 32-bit --with-wide-int hosts).
2946 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2947 Add a FIXME comment about memory leaks.
2948 (syms_of_charset): Don't assume xmalloc returns.
2950 Don't assume that stated character widths fit in int.
2951 * character.c (Fchar_width, c_string_width, lisp_string_width):
2952 * character.h (CHAR_WIDTH):
2953 * indent.c (MULTIBYTE_BYTES_WIDTH):
2954 Use sanitize_char_width to avoid undefined and/or bad behavior
2955 with outlandish widths.
2956 * character.h (sanitize_tab_width): Rename from sanitize_width,
2957 now that we have two such functions. All uses changed.
2958 (sanitize_char_width): New inline function.
2960 Don't assume that tab-width fits in int.
2961 * character.h (sanitize_width): New inline function.
2962 (SANE_TAB_WIDTH): New macro.
2963 (ASCII_CHAR_WIDTH): Use it.
2964 * indent.c (sane_tab_width): Remove. All uses replaced by
2965 SANE_TAB_WIDTH (current_buffer).
2966 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2968 * fileio.c: Integer overflow issues with file modes.
2969 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2971 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2972 Remove unreachable code.
2973 (read_hex, load_charset_map_from_file): Check for integer overflow.
2975 * xterm.c: Don't go over XClientMessageEvent limit.
2976 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2977 (x_send_scroll_bar_event): Likewise. Check that the size does not
2978 exceed limits imposed by XClientMessageEvent, as well as the usual
2979 ptrdiff_t and size_t limits.
2981 * keyboard.c: Overflow, signedness and related fixes.
2982 (make_lispy_movement): Use same integer type in forward decl
2983 that is used in the definition.
2984 (read_key_sequence, keyremap_step):
2985 Change bufsize argument back to int, undoing my 2011-03-30 change.
2986 We prefer signed types, and int is wide enough here.
2987 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2988 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2989 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2990 length, not size_t. Use ptrdiff_t for index, not int.
2991 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2992 possibility of integer overflow.
2994 Overflow, signedness and related fixes for images.
2996 * dispextern.h (struct it.stack[0].u.image.image_id)
2997 (struct_it.image_id, struct image.id, struct image_cache.size)
2998 (struct image_cache.used, struct image_cache.ref_count):
2999 * gtkutil.c (update_frame_tool_bar):
3000 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3001 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3002 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3003 * nsmenu.m (update_frame_tool_bar):
3004 * xdisp.c (calc_pixel_width_or_height):
3005 * xfns.c (image_cache_refcount):
3006 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3007 on typical 64-bit hosts.
3009 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3010 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3011 Omit unnecessary casts to int.
3012 (parse_image_spec): Check that integers fall into 'int' range
3013 when the callers expect that.
3014 (image_ascent): Redo ascent calculation to avoid int overflow.
3015 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3016 (lookup_image): Remove unnecessary tests.
3017 (xbm_image_p): Locals are now of int, not EMACS_INT,
3018 since parse_image_check makes sure they fit into int.
3019 (png_load, gif_load, svg_load_image):
3020 Prefer int to unsigned where either will do.
3021 (tiff_handler): New function, combining the cores of the
3022 old tiff_error_handler and tiff_warning_handler.
3023 This function is rewritten to use vsnprintf and thereby avoid
3024 stack buffer overflows. It uses only the features of vsnprintf
3025 that are common to both POSIX and native Microsoft.
3026 (tiff_error_handler, tiff_warning_handler): Use it.
3027 (tiff_load, gif_load, imagemagick_load_image):
3028 Don't assume :index value fits in 'int'.
3029 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3030 (imagemagick_load_image): Check that crop parameters fit into
3031 the integer types that MagickCropImage accepts. Don't assume
3032 Vimagemagick_render_type has a nonnegative value. Don't assume
3033 size_t fits in 'long'.
3034 (gs_load): Use printmax_t to print the widest integers possible.
3035 Check for integer overflow when computing image height and width.
3037 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3039 * xdisp.c (redisplay_window): Don't force window start if point
3040 will be invisible in the resulting window. (Bug#9324)
3042 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3044 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3045 the display spec is of the form `(space ...)'.
3046 (handle_display_spec): Return the value returned by
3047 handle_single_display_spec, not just 1 or zero.
3048 (handle_single_display_spec): If the display spec is of the form
3049 `(space ...)', and specifies display in the text area, return 2
3051 (try_cursor_movement): Check for the need to scroll more
3052 accurately, and prefer exact match for point under bidi.
3053 Don't advance `row' beyond the last row of the window.
3055 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3056 into disp_prop; all users changed.
3058 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3059 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3060 for the text covered by the display property.
3062 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3064 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3065 Change return value to nil.
3066 (Frecord_buffer): Delete unused function.
3068 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3070 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3071 buffers, return left-to-right.
3072 (set_cursor_from_row): Consider candidate row a win if its glyph
3073 represents a newline and point is on that newline. Fixes cursor
3074 positioning on the newline at EOL of R2L text within L2R
3075 paragraph, and vice versa.
3076 (try_cursor_movement): Check continued rows, in addition to
3077 continuation rows. Fixes unwarranted scroll when point enters a
3078 continued line of R2L text within an L2R paragraph, or vice versa.
3079 (cursor_row_p): Consider the case of point being equal to
3080 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3081 from the end of a short line to the beginning of a continued line
3082 of R2L text within L2R paragraph.
3083 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3084 composed characters.
3086 * bidi.c (bidi_check_type): Use xassert.
3087 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3090 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3092 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3095 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3097 * nsfont.m (ns_otf_to_script): Fix typo.
3099 2011-08-22 Kenichi Handa <handa@m17n.org>
3101 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3102 extra slot even if the purpose is char-code-property-table.
3104 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3106 * xdisp.c (redisplay_window): When computing centering_position,
3107 account for the height of the header line. (Bug#8874)
3109 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3110 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3111 candidate is selected by the mouse, and that candidate has a
3112 composed character under the mouse.
3114 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3115 coordinates reported by pos-visible-in-window-p for a composed
3116 character in column zero.
3118 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3120 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3122 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3124 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3125 consider it a hit if to_charpos is anywhere in the range of the
3126 composed buffer positions.
3128 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3130 * image.c (gif_load): Don't assume that each subimage has the same
3131 dimensions as the base image. Handle disposal method that is
3132 "undefined" by the gif spec (Bug#9335).
3134 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3136 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3137 (Fcondition_case): Document `debug' symbol in error handler.
3139 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3141 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3142 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3143 from an Org mode buffer to a Speedbar frame.
3145 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3146 a composition, take its buffer position from IT->cmp_it.charpos.
3147 Fixes cursor positioning at the beginning of a line that begins
3148 with a composed character.
3150 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3152 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3153 character bidirectional type, use STRONG_L instead. Fixes crashes
3154 in a buffer produced by `describe-categories'.
3156 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3157 members before the level stack, so they would be saved and
3158 restored when copying iterator state. Fixes incorrect reordering
3159 around TABs covered by display properties.
3161 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3163 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3165 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3167 * eval.c (internal_condition_case, internal_condition_case_1)
3168 (internal_condition_case_2, internal_condition_case_n):
3169 Remove unnecessary aborts (Bug#9081).
3171 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3173 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3174 has no `load' handler, try opening the file locally. (Bug#9311)
3176 2011-08-16 Ken Brown <kbrown@cornell.edu>
3178 * gmalloc.c: Expand comment.
3180 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3182 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3183 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3185 2011-08-16 Ken Brown <kbrown@cornell.edu>
3187 Fix memory allocation problems in Cygwin build (Bug#9273).
3189 * unexcw.c ( __malloc_initialized): Declare external variable.
3190 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3192 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3194 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3196 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3198 [CYGWIN] (special_realloc): New function.
3199 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3200 requests to realloc storage in the static heap.
3202 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3204 * bidi.c (bidi_initialize): Remove unused local.
3206 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3209 * biditype.h: Remove file.
3210 * makefile.w32-in ($(BLD)/bidi.$(O)):
3211 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3213 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3215 * chartab.c: Improve commentary for the uniprop_table API.
3217 * bidi.c (bidi_paragraph_init): Support zero value of
3218 bidi_ignore_explicit_marks_for_paragraph_level.
3219 (bidi_initialize): Use uniprop_table instead of including
3220 biditype.h and bidimirror.h.
3222 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3223 coordinates of the iterator when restoring from ppos_it.
3226 2011-08-14 Kenichi Handa <handa@m17n.org>
3228 * process.c (create_process): Call setup_process_coding_systems
3229 after the pid of the process is set to -1 (Bug#8162).
3231 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3233 * xdisp.c (move_it_in_display_line_to): Don't invoke
3234 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3235 ppos_it. Fixes vertical cursor motion when line beginning is
3236 covered by an image. (Bug#9296)
3238 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3240 * nsterm.h (ns_run_ascript): Declare.
3241 (NSAPP_DATA2_RUNASSCRIPT): Define.
3243 * nsfns.m (as_script, as_result, as_status): New static variables.
3244 (ns_run_ascript): New function.
3245 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3246 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3247 the event loop. Get status from as_status (Bug#7276).
3249 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3250 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3251 the event loop (Bug#7276).
3253 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3255 * gnutls.c (QCgnutls_bootprop_priority)
3256 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3257 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3258 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3259 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3260 (QCgnutls_bootprop_verify_hostname_error)
3261 (QCgnutls_bootprop_callbacks_verify): Rename from
3262 Qgnutls_bootprop_..., all uses changed.
3264 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3267 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3269 * xfaces.c (Qframe_set_background_mode): Now static.
3270 * dispextern.h (Qframe_set_background_mode): Remove decl.
3272 * process.c (Fnetwork_interface_info): Declare local only if needed.
3274 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3276 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3277 (Fnetwork_interface_list): Allocate in increments of bytes instead
3278 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3279 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3281 (struct ifflag_def): notrailers is smart on OSX.
3282 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3283 Get hardware address with getifaddrs if available.
3285 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3287 * xdisp.c (iterate_out_of_display_property): xassert that
3288 IT->position is set to within IT->object's boundaries. Break from
3289 the loop as soon as EOB is reached; avoids infloops in redisplay
3290 when IT->position is set up wrongly due to some bug.
3291 Set IT->current to match the bidi iterator unconditionally.
3292 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3293 entry. Force push_it to save on the stack the current
3294 buffer/string position, to be restored by pop_it. Fix flags in
3295 the iterator structure wrt the object coming from a display
3296 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3297 properties. (Bug#9284)
3299 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3301 * fontset.c (fontset_get_font_group): Add proper type checks.
3304 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3306 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3307 and LC_VERSION_MIN_MACOSX.
3308 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3309 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3311 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3313 * xdisp.c (forward_to_next_line_start): Allow to use the
3314 no-display-properties-and-no-overlays under bidi display.
3315 Set disp_pos in the bidi iterator to avoid searches for display
3316 properties and overlays.
3318 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3320 * editfns.c (Fset_time_zone_rule): Document relationship with the
3323 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3324 the font entity extracted from the cache (Bug#8109).
3326 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3328 * composite.c (autocmp_chars): Don't reset point. That is done by
3329 restore_point_unwind (Bug#5984).
3331 2011-08-07 Juri Linkov <juri@jurta.org>
3333 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3334 to show the arg `TIME' instead of `TIMEVAL'.
3336 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3338 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3339 display property strides EOL and includes a newline, as in
3340 longlines-mode. (Bug#9254)
3341 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3342 word-wrap under bidirectional display. (Bug#9224)
3344 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3345 is non-zero, even if the data buffer is NULL. Fixes a crash in
3346 vertical-motion with longlines-mode. (Bug#9254)
3348 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3350 * bidi.c <bidi_cache_total_alloc>: Now static.
3351 (bidi_initialize): Initialize bidi_cache_total_alloc.
3353 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3356 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3357 amount allocated this far in `bidi_cache_total_alloc'.
3358 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3359 non-zero, only free the data buffer without restoring the cache
3360 contents. All callers changed.
3362 * dispextern.h (bidi_unshelve_cache): Update prototype.
3364 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3365 (move_it_in_display_line, move_it_to)
3366 (move_it_vertically_backward, move_it_by_lines): Replace the call
3367 to xfree to an equivalent call to bidi_unshelve_cache.
3368 (move_it_in_display_line_to): Fix logic of returning
3369 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3371 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3373 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3374 came from a string character with a `cursor' property. (Bug#9229)
3376 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3378 * Makefile.in (LIB_PTHREAD): New variable.
3379 (LIBES): Add LIB_PTHREAD (Bug#9216).
3381 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3382 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3384 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3386 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3388 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3390 * xterm.c (x_find_topmost_parent): New function.
3391 (x_set_frame_alpha): Find topmost parent window with
3392 x_find_topmost_parent and set the property there also (bug#9181).
3393 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3395 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3397 * callproc.c (Fcall_process): Avoid vfork clobbering
3398 the local vars buffer, coding_systems, current_dir.
3400 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3402 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3404 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3406 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3407 so that it is not optimized away.
3409 * xdisp.c (compute_display_string_pos): Remove unused local.
3411 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3413 Fix slow cursor motion and scrolling in large buffers with
3414 selective display, like Org Mode buffers. (Bug#9218)
3416 * dispextern.h (struct bidi_it): New member disp_prop_p.
3418 * xdisp.c: Remove one-slot cache of display string positions.
3419 (compute_display_string_pos): Accept an additional argument
3420 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3421 for a display string or property. If found, set DISP_PROP_P
3424 * bidi.c (bidi_fetch_char): Accept an additional argument
3425 DISP_PROP_P, and pass it to compute_display_string_pos.
3426 Only handle text covered by a display string if DISP_PROP_P is returned
3427 non-zero. All callers of bidi_fetch_char changed.
3429 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3431 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3433 2010-12-03 Don March <don@ohspite.net>
3435 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3436 last character M-[char] is translated to ESC [char] (bug#7541).
3438 2011-08-02 Kenichi Handa <handa@m17n.org>
3440 * lisp.h (uniprop_table): Extern it.
3442 * chartab.c (uniprop_table): Make it non-static.
3444 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3446 * xdisp.c (forward_to_next_line_start): Accept additional argument
3447 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3449 (reseat_at_next_visible_line_start): Use the bidi iterator state
3450 returned by forward_to_next_line_start to restore the state of
3451 it->bidi_it after backing up to previous newline. (Bug#9212)
3453 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3455 * regex.c (re_comp): Protoize.
3456 (re_exec): Fix return type.
3457 (regexec): Fix type of `ret'. (Bug#9203)
3459 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3461 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3462 This is needed if max-image-size is a floating-point number.
3464 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3466 * print.c (print_object): Print empty symbol as ##.
3468 * lread.c (read1): Read ## as empty symbol.
3470 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3472 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3473 setting frame foreground color (Bug#9175).
3474 (x_set_background_color): Likewise.
3476 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3477 contents (Bug#9176).
3478 (EmacsTooltip -init): Remove bezels and add shadows to
3481 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3482 or scroll bar (Bug#8470).
3484 * nsfont.m (nsfont_open): Remove assignment to voffset and
3485 unnecessary vars hshink, expand, hd, full_height, min_height.
3486 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3488 * nsterm.h (nsfont_info): Remove voffset field.
3490 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3492 Implement strike-through and overline on NextStep (Bug#8863).
3494 * nsfont.m (nsfont_open): Use underline position provided by font,
3495 instead of hard-coded value of 2.
3496 (nsfont_draw): Call ns_draw_text_decoration instead.
3498 * nsterm.h: Add declaration for ns_draw_text_decoration.
3500 * nsterm.m (ns_draw_text_decoration): New function for drawing
3501 underline, overline, and strike-through.
3502 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3503 ns_draw_text_decoration. Change treatment of cursor drawing to
3504 accommodate underlining, etc.
3506 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3508 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3511 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3513 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3514 Without this fix, if a signal arrives just after memory fills up,
3515 'malloc' might be invoked reentrantly.
3517 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3518 In other words, assume that every image size is allowed, on non-X
3519 hosts. This assumption is probably wrong, but it lets Emacs compile.
3521 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3523 * regex.c (re_iswctype): Convert return values to boolean.
3525 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3527 * xdisp.c (compute_display_string_pos): Don't use cached display
3528 string position if the buffer had its restriction changed.
3531 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3533 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3535 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3537 Integer signedness and overflow and related fixes. (Bug#9079)
3539 * bidi.c: Integer size and overflow fixes.
3540 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3541 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3542 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3543 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3544 (bidi_find_other_level_edge):
3545 Use ptrdiff_t instead of EMACS_INT where either will do.
3546 This works better on 32-bit hosts configured --with-wide-int.
3547 (bidi_cache_ensure_space): Check for size-calculation overflow.
3548 Use % rather than repeated addition, for better worst-case speed.
3549 Don't set bidi_cache_size until after xrealloc returns, because it
3551 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3552 (bidi_cache_ensure_space): Also check that the bidi cache size
3553 does not exceed that of the largest Lisp string or buffer. See Eli
3554 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3556 * alloc.c (__malloc_size_t): Remove.
3557 All uses replaced by size_t. See Andreas Schwab's note
3558 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3560 * image.c: Improve checking for integer overflow.
3561 (check_image_size): Assume that f is nonnull, since
3562 it is always nonnull in practice. This is one less thing to
3563 worry about when checking for integer overflow later.
3564 (x_check_image_size): New function, which checks for integer
3565 overflow issues inside X.
3566 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3567 This removes the need for a memory_full check.
3568 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3569 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3570 (xbm_read_bitmap_data): Change locals back to 'int', since
3571 their values must fit in 'int'.
3572 (xpm_load_image, png_load, tiff_load):
3573 Invoke x_create_x_image_and_pixmap earlier,
3574 to avoid much needless work if the image is too large.
3575 (tiff_load): Treat overly large images as if
3576 x_create_x_image_and_pixmap failed, not as malloc failures.
3577 (gs_load): Use x_check_image_size.
3579 * gtkutil.c: Omit integer casts.
3580 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3581 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3583 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3585 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3586 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3587 would wrongly return t on a 64-bit host.
3589 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3590 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3591 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3592 and therefore cause GCC to emit a bogus diagnostic in some cases.
3594 * image.c: Integer signedness and overflow and related fixes.
3595 This is not an exhaustive set of fixes, but it's time to
3596 record what I've got.
3597 (lookup_pixel_color, check_image_size): Remove redundant decls.
3598 (check_image_size): Don't assume that arbitrary EMACS_INT values
3599 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3600 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3601 (tiff_load, imagemagick_load_image):
3602 Check for overflow in size calculations.
3603 (x_create_x_image_and_pixmap): Remove unnecessary test for
3604 xmalloc returning NULL; that can't happen.
3605 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3606 (xpm_color_bucket): Use better integer hashing function.
3607 (xpm_cache_color): Don't possibly over-allocate memory.
3608 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3609 (gif_memory_source):
3610 Use ptrdiff_t, not int or size_t, to record sizes.
3611 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3612 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3613 either works, as we prefer signed integers.
3614 (tiff_read_from_memory, tiff_write_from_memory):
3615 Return tsize_t, not size_t, since that's what the TIFF API wants.
3616 (tiff_read_from_memory): Don't fail simply because the read would
3617 go past EOF; instead, return a short read.
3618 (tiff_load): Omit no-longer-needed casts.
3619 (Fimagemagick_types): Don't assume size fits into 'int'.
3621 Improve hashing quality when configured --with-wide-int.
3622 * fns.c (hash_string): New function, taken from sxhash_string.
3623 Do not discard information about ASCII character case; this
3624 discarding is no longer needed.
3625 (sxhash-string): Use it. Change sig to match it. Caller changed.
3626 * lisp.h: Declare it.
3627 * lread.c (hash_string): Remove, since we now use fns.c's version.
3628 The fns.c version returns a wider integer if --with-wide-int is
3629 specified, so this should help the quality of the hashing a bit.
3631 * emacs.c: Integer overflow minor fix.
3632 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3633 Define only if GNU_LINUX.
3634 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3636 * dispnew.c: Integer signedness and overflow fixes.
3637 Remove unnecessary forward decls, that were a maintenance hassle.
3638 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3640 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3641 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3642 (prepare_desired_row, line_draw_cost):
3643 Use int, not unsigned, where either works.
3644 (save_current_matrix, restore_current_matrix):
3645 Use ptrdiff_t, not size_t, where either works.
3646 (init_display): Check for overflow more accurately, and without
3647 relying on undefined behavior.
3649 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3650 Remove, replacing with the new symbols in lisp.h. All uses changed.
3651 * fileio.c (make_temp_name):
3652 * filelock.c (lock_file_1, lock_file):
3653 * xdisp.c (message_dolog):
3654 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3655 Use pMd etc. instead.
3656 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3657 replacing the pWIDE etc. symbols removed from editfns.c.
3659 * keyboard.h (num_input_events): Now uintmax_t.
3660 This is (very slightly) less likely to mess up due to wraparound.
3663 * buffer.c: Integer signedness fixes.
3664 (alloc_buffer_text, enlarge_buffer_text):
3665 Use ptrdiff_t rather than size_t when either will do, as we prefer
3668 * alloc.c: Integer signedness and overflow fixes.
3669 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3670 (__malloc_size_t): Default to size_t, not to int.
3671 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3672 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3673 Prefer ptrdiff_t to size_t when either would do, as we prefer
3675 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3676 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3677 Now const. Initialize with values that are in range even if char
3679 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3680 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3681 These functions do the right thing with sizes > 2**32.
3682 (check_depth): Now ptrdiff_t, not int.
3683 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3684 Adjust to new way of storing sizes. Check for size overflow bugs
3686 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3687 slightly wrong anyway, as it missed one instance of
3688 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3689 (refill_memory_reserve): Omit needless cast to size_t.
3690 (mark_object_loop_halt): Mark as externally visible.
3692 * xselect.c: Integer signedness and overflow fixes.
3693 (Fx_register_dnd_atom, x_handle_dnd_message):
3694 Use ptrdiff_t, not size_t, since we prefer signed.
3695 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3696 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3697 x_dnd_atoms_size and x_dnd_atoms_length.
3699 * doprnt.c: Prefer signed to unsigned when either works.
3701 * doprnt.c (doprnt):
3703 * xdisp.c (vmessage):
3704 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3705 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3706 prefer signed arithmetic to avoid comparison confusion.
3707 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3708 but is a bit tricky.
3710 Assume freestanding C89 headers, string.h, stdlib.h.
3711 * data.c, doprnt.c, floatfns.c, print.c:
3712 Include float.h unconditionally.
3713 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3714 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3715 * regex.c: Likewise for stddef.h, string.h.
3716 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3717 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3718 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3719 (STDC_HEADERS): Remove obsolete defines.
3720 * sysdep.c: Include limits.h unconditionally.
3722 Assume support for memcmp, memcpy, memmove, memset.
3723 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3724 * regex.c (memcmp, memcpy):
3725 Remove; we assume C89 now.
3727 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3728 (__malloc_safe_bcopy): Remove; no longer needed.
3730 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3731 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3732 well either way, and we prefer signed to unsigned.
3734 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3736 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3737 closes the connection while we're reading (bug#9182).
3739 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3741 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3742 are specified (Bug#9168).
3744 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3746 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3747 Found by GCC static checking and --with-wide-int on a 32-bit host.
3749 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3751 * xdisp.c (compute_display_string_pos): Fix logic of caching
3752 previous display string position. Initialize cached_prev_pos to
3753 -1. Fixes slow-down at the beginning of a buffer.
3755 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3757 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3758 for attrs[LFACE_FONTSET_INDEX].
3760 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3762 * xml.c (parse_region): Remove unused local
3763 that was recently introduced.
3765 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3767 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3768 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3770 * xdisp.c (move_it_in_display_line_to): Record the best matching
3771 position for TO_CHARPOS while scanning the line, and restore it on
3772 exit if none of the characters scanned was an exact match.
3773 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3774 when exact match is impossible due to invisible text, and the
3775 lines are truncated.
3777 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3779 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3782 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3784 Fix a significant slow-down of cursor motion with C-n, C-p,
3785 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3786 auto-repeat under bidi redisplay in fontified buffers.
3787 * xdisp.c (compute_stop_pos_backwards): New function.
3788 (next_element_from_buffer): Call compute_stop_pos_backwards to
3789 find a suitable prev_stop when we find ourselves before
3791 (reseat): Don't look for prev_stop, as that could mean a very long
3793 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3794 <cached_disp_overlay_modiff>: Cache for last found display string
3796 (compute_display_string_pos): Return the cached position if asked
3797 about the same buffer in the same area of character positions, and
3798 the buffer wasn't changed since the time the display string
3799 position was cached.
3801 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3803 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3804 is an integer, which is important for empty lines. (Bug#9149)
3806 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3808 * frame.c (Fmodify_frame_parameters): In tty case, update the
3809 default face if necessary (Bug#4238).
3811 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3813 * editfns.c (Fstring_to_char): No need to explain what a character
3814 is in the docstring (Bug#6576).
3816 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3818 * xml.c (parse_region): Make sure we always return a tree.
3820 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3822 * xml.c (parse_region): If a document contains only comments,
3825 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3827 * xml.c (make_dom): Return comments, too.
3829 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3832 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3833 and the surrounding thread.
3834 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3835 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3836 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3838 * s/openbsd.h (BROKEN_SIGIO): Define.
3839 * unexelf.c (unexec) [__OpenBSD__]:
3840 Don't update the .mdebug section of the Alpha COFF symbol table.
3842 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3844 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3847 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3849 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3850 This fixes some race conditions on the permissions of any newly
3853 * alloc.c (valid_pointer_p): Use pipe, not open.
3854 This fixes some permissions issues when debugging.
3856 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3857 If fchown fails to set both uid and gid, try to set just gid,
3858 as that is sometimes allowed. Adjust the file's mode to eliminate
3859 setuid or setgid bits that are inappropriate if fchown fails.
3861 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3863 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3864 to compare Lisp_Objects.
3865 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3866 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3867 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3869 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3871 * lread.c (read_integer): Unread even EOF character.
3872 (read1): Likewise. Properly record start position of symbol.
3874 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3875 symbol character follows.
3877 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3879 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3880 This works around a problem with the previous change to Fcopy_file.
3881 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3882 and without this change, GCC might complain about discarding
3883 fchown's return value.
3885 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3887 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3889 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3891 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3893 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3895 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3896 it's used from the C level.
3898 * process.c: Use the same condition for POLL_FOR_INPUT in both
3899 keyboard.c and process.c (bug#1858).
3901 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3903 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3904 (Fgnutls_boot): Use it.
3906 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3908 * doc.c (Fsubstitute_command_keys): Revert last change.
3910 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3912 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3913 quotes the next character, and doesn't affect other longer
3914 sequences (bug#8935).
3916 * lread.c (syms_of_lread): Clarify that is isn't only
3917 `eval-buffer' and `eval-defun' that's affected by
3918 `lexical-binding' (bug#8460).
3920 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3922 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3923 bidi redisplay when a line includes both an image and is truncated.
3925 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3927 Fix minor problems found by static checking.
3928 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3929 (elsz): Now a signed constant, not a size_t var. We prefer signed
3930 types to unsigned, to avoid integer comparison confusion. Without
3931 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3932 "cannot optimize loop, the loop counter may overflow", a symptom
3934 * indent.c (Fvertical_motion): Mark locals as initialized.
3935 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3937 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3939 * search.c (Fre_search_backward): Mention `case-fold-search' in
3940 all the re_search_* functions (bug#8138).
3942 * keyboard.c (Fopen_dribble_file): Document when the file is
3945 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3947 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3950 Support bidi reordering of display and overlay strings.
3951 * xdisp.c (compute_display_string_pos)
3952 (compute_display_string_end): Accept additional argument STRING.
3953 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3954 (reseat_to_string): Initialize bidi_it->string.s and
3955 bidi_it->string.schars.
3956 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3957 NULL (avoids a crash in bidi_paragraph_init).
3958 Initialize itb.string.lstring.
3959 (init_iterator): Call bidi_init_it only of a valid
3960 buffer position was specified. Initialize paragraph_embedding to
3962 (reseat_to_string): Initialize the bidi iterator.
3963 (display_string): If we need to ignore text properties of
3964 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3965 original value of -1 will not work with bidi.)
3966 (compute_display_string_pos): First arg is now struct
3967 `text_pos *'; all callers changed. Support display properties on
3969 (compute_display_string_end): Support display properties on Lisp
3971 (init_iterator, reseat_1, reseat_to_string): Initialize the
3972 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3973 when iterating on a string not from display properties).
3974 (compute_display_string_pos, compute_display_string_end):
3975 Fix calculation of the object to scan. Fixes an error when using
3977 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3978 base_level_stop; instead, set base_level_stop to BEGV.
3979 Fixes crashes in vertical-motion.
3980 (next_element_from_buffer): Improve commentary for when
3981 the iterator is before prev_stop.
3982 (init_iterator): Initialize bidi_p from the default value of
3983 bidi-display-reordering, not from buffer-local value. Use the
3984 buffer-local value only if initializing for buffer iteration.
3985 (handle_invisible_prop): Support invisible properties on strings
3986 that are being bidi-reordered.
3987 (set_iterator_to_next): Support bidi reordering of C strings and
3989 (next_element_from_string): Support bidi reordering of Lisp
3991 (handle_stop_backwards): Support Lisp strings as well.
3992 (display_string): Support display of R2L glyph rows.
3993 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3994 (init_iterator): Don't initialize it->bidi_p for strings
3996 (reseat_to_string): Initialize it->bidi_p for strings here.
3997 (next_element_from_string, next_element_from_c_string)
3998 (next_element_from_buffer): Add xassert's for correspondence
3999 between IT's object being iterated and it->bidi_it.string
4001 (face_before_or_after_it_pos): Support bidi iteration.
4002 (next_element_from_c_string): Handle the case of the first string
4003 character that is not the first one in the visual order.
4004 (get_visually_first_element): New function, refactored from common
4005 parts of next_element_from_buffer, next_element_from_string, and
4006 next_element_from_c_string.
4007 (tool_bar_lines_needed, redisplay_tool_bar)
4008 (display_menu_bar): Force left-to-right direction. Add a FIXME
4009 comment for making that be controlled by a user option.
4010 (push_it, pop_it): Save and restore the state of the
4011 bidi iterator. Save and restore the bidi_p flag.
4012 (pop_it): Iterate out of display property for string iteration as
4014 (iterate_out_of_display_property): Support iteration over strings.
4015 (handle_single_display_spec): Set up it->bidi_it for iteration
4016 over a display string, and call bidi_init_it.
4017 (handle_single_display_spec, next_overlay_string)
4018 (get_overlay_strings_1, push_display_prop): Set up the bidi
4019 iterator for displaying display or overlay strings.
4020 (forward_to_next_line_start): Don't use the shortcut if
4022 (back_to_previous_visible_line_start): If handle_display_prop
4023 pushed the iterator stack, restore the internal state of the bidi
4024 iterator by calling bidi_pop_it same number of times.
4025 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4026 and we are bidi-iterating, don't decrement the iterator position;
4027 instead, set the first_elt flag in the bidi iterator, to produce
4029 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4030 (push_display_prop): xassert that we are iterating a buffer.
4031 (push_it, pop_it): Save and restore paragraph_embedding member.
4032 (handle_single_display_spec, next_overlay_string)
4033 (get_overlay_strings_1, reseat_1, reseat_to_string)
4034 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4035 correctly. Don't assume unibyte strings are not bidi-reordered.
4036 (compute_display_string_pos)
4037 (compute_display_string_end): Fix handling the case of C string.
4038 (push_it, pop_it): Save and restore from_disp_prop_p.
4039 (handle_single_display_spec, push_display_prop): Set the
4040 from_disp_prop_p flag.
4041 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4042 (pop_it): Call iterate_out_of_display_property only if we are
4043 popping after iteration over a string that came from a display
4044 property. Fix a typo in popping stretch info. Add an assertion
4045 for verifying that the iterator position is in sync with the bidi
4047 (handle_single_display_spec, get_overlay_strings_1)
4048 (push_display_prop): Fix initialization of paragraph direction for
4049 string when that of the parent object is not yet determined.
4050 (reseat_1): Call bidi_init_it to resync the bidi
4051 iterator with IT's position. (Bug#7616)
4052 (find_row_edges): If ROW->start.pos gives position
4053 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4054 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4055 Reset the from_disp_prop_p flag.
4056 (SAVE_IT, RESTORE_IT): New macros.
4057 (pos_visible_p, face_before_or_after_it_pos)
4058 (back_to_previous_visible_line_start)
4059 (move_it_in_display_line_to, move_it_in_display_line)
4060 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4061 (try_scrolling, redisplay_window, display_line): Use them when
4062 saving a temporary copy of the iterator and restoring it back.
4063 (back_to_previous_visible_line_start, reseat_1)
4064 (init_iterator): Empty the bidi cache "stack".
4065 (move_it_in_display_line_to): If iterator ended up at
4066 EOL, but we never saw any buffer positions smaller than
4067 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4068 motion in bidi-reordered lines.
4069 (move_it_in_display_line_to): Record prev_method and prev_pos
4070 immediately before the call to set_iterator_to_next. Fixes cursor
4071 motion in bidi-reordered lines with stretch glyphs and strings
4072 displayed in margins. (Bug#8133) (Bug#8867)
4073 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4075 (pos_visible_p): Support positions in bidi-reordered lines.
4076 Save and restore bidi cache.
4078 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4079 (bidi_paragraph_info): Delete unused struct.
4080 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4081 (bidi_cache_start): New variable.
4082 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4084 (bidi_cache_fetch_state, bidi_cache_search)
4085 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4086 (bidi_cache_find, bidi_peek_at_next_level)
4087 (bidi_level_of_next_char, bidi_find_other_level_edge)
4088 (bidi_move_to_visually_next): Compare cache index with
4089 bidi_cache_start rather than with zero.
4090 (bidi_fetch_char): Accept new argument STRING; all callers
4091 changed. Support iteration over a string. Support strings with
4092 display properties. Support unibyte strings. Fix the type of
4093 `len' according to what STRING_CHAR_AND_LENGTH expects.
4094 (bidi_paragraph_init, bidi_resolve_explicit_1)
4095 (bidi_resolve_explicit, bidi_resolve_weak)
4096 (bidi_level_of_next_char, bidi_move_to_visually_next):
4097 Support iteration over a string.
4098 (bidi_set_sor_type, bidi_resolve_explicit_1)
4099 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4100 can now be zero (for strings); special values 0 and -1 were
4101 changed to -1 and -2, respectively.
4102 (bidi_char_at_pos): New function.
4103 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4104 Call it instead of FETCH_MULTIBYTE_CHAR.
4105 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4106 initialized to valid values.
4107 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4109 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4110 the test for valid cached positions. Fix the logic for looking up
4111 the sentinel state in the cache. GCPRO the Lisp string we are
4113 (bidi_push_it, bidi_pop_it): New functions.
4114 (bidi_initialize): Initialize the bidi cache start stack pointer.
4115 (bidi_cache_ensure_space): New function, refactored from part of
4116 bidi_cache_iterator_state. Don't assume the required size is just
4117 one BIDI_CACHE_CHUNK away.
4118 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4119 (bidi_count_bytes, bidi_char_at_pos): New functions.
4120 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4121 always valid if bidi_cache_idx is valid.
4122 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4123 is valid if it's going to be used.
4124 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4125 (bidi_cache_fetch_state, bidi_cache_search)
4126 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4127 (bidi_cache_iterator_state, bidi_cache_find)
4128 (bidi_find_other_level_edge, bidi_cache_start_stack):
4129 All variables related to cache indices are now EMACS_INT.
4131 * dispextern.h (struct bidi_string_data): New structure.
4132 (struct bidi_it): New member `string'. Make flag members be 1-bit
4133 fields, and put them last in the struct.
4134 (compute_display_string_pos, compute_display_string_end):
4136 (bidi_push_it, bidi_pop_it): Add prototypes.
4137 (struct iterator_stack_entry): New members bidi_p,
4138 paragraph_embedding, and from_disp_prop_p.
4139 (struct it): Member bidi_p is now a bit field 1 bit wide.
4140 (bidi_shelve_cache, bidi_unshelve_cache):
4143 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4144 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4145 and vector-like objects.
4147 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4148 cache around display iteration.
4150 * window.c (Fwindow_end, window_scroll_pixel_based)
4151 (displayed_window_lines, Frecenter): Save and restore the bidi
4152 cache around display iteration.
4154 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4156 * editfns.c (Fdelete_region): Clarify the use of the named
4157 parameters (bug#6788).
4159 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4161 * indent.c (Fvertical_motion): Set and restore w->pointm when
4162 saving and restoring the window's buffer (Bug#9006).
4164 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4166 * editfns.c (Fstring_to_char): Clarify just what is returned
4167 (bug#6576). Text by Eli Zaretskii.
4169 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4171 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4173 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4175 * buffer.c (mmap_find): Fix a typo.
4177 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4179 Fix execution of x selection hooks.
4180 * xselect.c (Qx_lost_selection_functions)
4181 (Qx_sent_selection_functions): New vars.
4182 (syms_of_xselect): DEFSYM them.
4183 (x_handle_selection_request): Pass Qx_sent_selection_functions
4184 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4185 (x_handle_selection_clear,x_clear_frame_selections):
4186 Pass Qx_lost_selection_functions rather than
4187 Vx_lost_selection_functions to Frun_hook_with_args.
4189 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4191 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4192 The old code sometimes used this field without initializing it.
4194 * alloc.c (gc_sweep): Don't read past end of array.
4195 In theory, the old code could also have corrupted Emacs internals,
4196 though it'd be very unlikely.
4198 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4200 * character.c (Fcharacterp): Don't advertise optional ignored
4201 argument. (Bug#4026)
4203 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4205 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4208 * window.c (Fset_window_start): Doc fix (bug#4199).
4209 (Fset_window_hscroll): Ditto.
4211 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4213 Fix minor new problems caught by GCC 4.6.1.
4214 * term.c (init_tty): Remove unused local.
4215 * xsettings.c (store_monospaced_changed): Define this function only
4216 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4219 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4221 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4223 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4225 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4226 are the mini-buffer and the echo area (bug#3320).
4228 * term.c (init_tty): Remove support for supdup, c10 and perq
4229 terminals, which are no longer supported (bug#1482).
4231 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4233 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4235 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4237 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4238 for non-popups (Bug#3642).
4240 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4242 * alloc.c (reset_malloc_hooks): Protoize.
4243 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4244 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4245 * cm.c (losecursor): Likewise.
4246 * data.c (fmod): Likewise.
4247 * dispnew.c (swap_glyphs_in_rows): Likewise.
4248 * emacs.c (memory_warning_signal): Likewise.
4249 * floatfns.c (float_error): Likewise.
4250 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4251 (otf_open, font_otf_capability, generate_otf_features)
4252 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4254 * image.c (pbm_read_file): Likewise.
4255 * indent.c (string_display_width): Likewise.
4256 * intervals.c (check_for_interval, search_for_interval)
4257 (inc_interval_count, count_intervals, root_interval)
4258 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4259 * lread.c (defalias): Likewise.
4260 * ralloc.c (r_alloc_check): Likewise.
4261 * regex.c (set_image_of_range_1, set_image_of_range)
4262 (regex_grow_registers): Likewise.
4263 * sysdep.c (strerror): Likewise.
4264 * termcap.c (valid_filename_p, tprint, main): Likewise.
4265 * tparam.c (main): Likewise.
4266 * unexhp9k800.c (run_time_remap, save_data_space)
4267 (update_file_ptrs, read_header, write_header, calculate_checksum)
4268 (copy_file, copy_rest, display_header): Likewise.
4269 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4271 * xdisp.c (check_it): Likewise.
4272 * xfaces.c (register_color, unregister_color, unregister_colors):
4274 * xfns.c (print_fontset_result): Likewise.
4275 * xrdb.c (member, fatal, main): Likewise.
4277 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4279 Fix minor problems found by static checking (Bug#9031).
4280 * chartab.c (char_table_set_range, map_sub_char_table):
4281 Remove unused locals.
4282 (uniprop_table): Now static.
4283 * composite.c (_work_char): Remove unused static var.
4285 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4287 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4289 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4291 * gtkutil.c (qttip_cb): Remove code without function.
4293 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4295 * w32.c (pthread_sigmask): New stub.
4297 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4299 Use pthread_sigmask, not sigprocmask (Bug#9010).
4300 sigprocmask is portable only for single-threaded applications, and
4301 Emacs can be multi-threaded when it uses GTK.
4302 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4304 * callproc.c (Fcall_process):
4305 * process.c (create_process):
4306 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4307 Use pthread_sigmask, not sigprocmask.
4309 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4311 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4312 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4315 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4317 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4318 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4319 (xg_hide_tooltip): Fix comment.
4321 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4322 in registerServicesMenuSendTypes.
4323 (validRequestorForSendType): Don't check ns_return_types.
4325 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4328 2011-07-08 Jason Rumney <jasonr@gnu.org>
4330 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4331 SH_SHOW for hidden windows (Bug#5482).
4333 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4334 frame struct members of non-existent frames (Bug#6284).
4336 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4338 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4339 variable firstTime not needed on OSX >= 10.6.
4340 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4341 >= 10.5. Use setKnobProportion, setDoubleValue.
4343 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4344 (MAC_OS_X_VERSION_10_5): Define if not defined.
4345 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4346 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4347 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4349 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4350 cString and lossyCString on OSX >= 10.4
4352 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4353 sizeToFit on OSX >= 10.2.
4355 * nsimage.m (allocInitFromFile): Don't use deprecated method
4356 bestRepresentationForDevice on OSX >= 10.6.
4358 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4361 * emacs.c: Declare unexec_init_emacs_zone.
4363 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4365 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4367 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4368 on svcsMenu (Bug#8842).
4370 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4372 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4374 * nsterm.m (QUTF8_STRING): Declare.
4375 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4376 (validRequestorForSendType): Return type is (id).
4377 Change indexOfObjectIdenticalTo to indexOfObject.
4378 Check if we have local selection before returning self (Bug#8842).
4379 (writeSelectionToPasteboard): Put local selection into paste board
4380 if we have a local selection (Bug#8842).
4381 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4383 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4384 (ns_get_local_selection): Declare.
4386 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4388 * keymap.c (describe_map_tree): Don't insert a double newline at
4389 the end of the buffer (bug#1169) and return whether we inserted
4392 * callint.c (Fcall_interactively): Change "reading args" to
4393 "providing args" to try to clarify what it does (bug#1010).
4395 2011-07-07 Kenichi Handa <handa@m17n.org>
4397 * composite.c (composition_compute_stop_pos): Ignore a static
4398 composition starting before CHARPOS (Bug#8915).
4400 * xdisp.c (handle_composition_prop): Likewise.
4402 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4404 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4407 2011-07-07 Kenichi Handa <handa@m17n.org>
4409 * character.h (unicode_category_t): New enum type.
4411 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4412 (Qchar_code_property_table): New variable.
4413 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4414 (UNIPROP_COMPRESSED_FORM_P): New macros.
4415 (char_table_ascii): Uncompress the compressed values.
4416 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4417 Uncompress the compressed values.
4418 (sub_char_table_ref_and_range): Likewise.
4419 (char_table_ref_and_range): Uncompress the compressed values.
4420 (sub_char_table_set): New arg is_uniprop. Callers changed.
4421 Uncompress the compressed values.
4422 (sub_char_table_set_range): Args changed. Callers changed.
4423 (char_table_set_range): Adjuted for the above change.
4424 (map_sub_char_table): Delete args default_val and parent. Add arg
4425 top. Give decoded values to a Lisp function.
4426 (map_char_table): Adjust for the above change. Give decoded
4427 values to a Lisp function. Gcpro more variables.
4428 (uniprop_table_uncompress)
4429 (uniprop_decode_value_run_length): New functions.
4430 (uniprop_decoder, uniprop_decoder_count): New variables.
4431 (uniprop_get_decoder, uniprop_encode_value_character)
4432 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4434 (uniprop_encoder, uniprop_encoder_count): New variables.
4435 (uniprop_get_encoder, uniprop_table)
4436 (Funicode_property_table_internal, Fget_unicode_property_internal)
4437 (Fput_unicode_property_internal): New functions.
4438 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4439 Sunicode_property_table_internal, Sget_unicode_property_internal,
4440 and Sput_unicode_property_internal. Defvar_lisp
4441 char-code-property-alist.
4443 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4444 Vunicode_category_table.
4446 * font.c (font_range): Adjust for the change of
4447 Vunicode_category_table.
4449 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4451 * m/iris4d.h: Remove file, move contents ...
4452 * s/irix6-5.h: ... here.
4454 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4456 Remove unportable assumption about struct layout (Bug#8884).
4457 * alloc.c (mark_buffer):
4458 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4459 (clone_per_buffer_values): Don't assume that
4460 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4461 This isn't true in general, and it's particularly not true
4462 if Emacs is configured with --with-wide-int.
4463 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4464 New macros, used in the buffer.c change.
4466 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4468 * xsettings.c: Use both GConf and GSettings if both are available.
4469 (store_config_changed_event): Add comment.
4470 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4471 (store_tool_bar_style_changed): New functions.
4472 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4473 (struct xsettings): Move font inside HAVE_XFT.
4474 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4475 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4476 Move inside HAVE_XFT.
4477 (something_changed_gsettingsCB): Rename from something_changedCB.
4478 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4480 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4481 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4482 (something_changed_gconfCB): Rename from something_changedCB.
4483 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4484 (parse_settings): Move check for font inside HAVE_XFT.
4485 (read_settings, apply_xft_settings): Add comment.
4486 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4487 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4488 call store_font_name_changed.
4489 (xft_settings_event): Add comment.
4490 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4491 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4492 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4493 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4494 (xsettings_initialize): Call init_gsettings last.
4495 (xsettings_get_system_font, xsettings_get_system_normal_font):
4498 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4500 Random fixes. E.g., (random) never returned negative values.
4501 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4502 subseconds part to the entropy, as that's a bit more random.
4503 Prefer signed to unsigned, since the signedness doesn't matter and
4504 in general we prefer signed. When given a limit, use a
4505 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4506 latter isn't right if USE_2_TAGS_FOR_INTS.
4507 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4508 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4510 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4512 * textprop.c (text_property_stickiness):
4513 Obey Vtext_property_default_nonsticky.
4514 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4515 * w32fns.c (syms_of_w32fns):
4516 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4518 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4520 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4521 This is more efficient than Ffile_directory_p and avoids a minor race.
4523 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4525 * buffer.c (Foverlay_put): Say what the return value is
4528 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4529 is a directory before asking whether to use the file name
4531 (barf_or_query_if_file_exists): Make the "File is a directory"
4532 error be more correct.
4534 * fns.c (Frequire): Remove the mention of the .gz files, since
4535 that's installation-specific, but keep the mention of
4536 `get-load-suffixes'.
4538 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4540 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4541 Report string overflow if the output is too long.
4543 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4545 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4546 (syms_of_gnutls): Remove duplicate DEFSYM for
4547 Qgnutls_bootprop_verify_hostname_error, an error for
4548 Qgnutls_bootprop_verify_error (which is no longer used).
4550 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4551 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4552 Also (re)move comments that are misplaced or no longer relevant.
4554 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4556 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4558 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4560 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4561 and background color parameters if they have been changed.
4563 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4565 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4567 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4569 * xsettings.c (SYSTEM_FONT): Define only when used.
4570 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4572 * keymap.c (access_keymap_1): Now static.
4574 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4576 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4577 leave any prefix arg for the up event (Bug#1586).
4579 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4581 * lread.c (syms_of_lread): Mention single symbols defined by
4582 `defvar' or `defconst' (bug#7154).
4584 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4585 (Frequire): Mention get-load-suffixes.
4587 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4589 * window.h (window): Remove clone_number slot.
4590 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4592 (make_parent_window, make_window, saved_window)
4593 (Fset_window_configuration, save_window_save): Don't deal with
4595 * buffer.c (Qclone_number): Remove declaration.
4596 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4598 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4600 Add multiple inheritance to keymaps.
4601 * keymap.c (Fmake_composed_keymap): New function.
4602 (Fset_keymap_parent): Simplify.
4603 (fix_submap_inheritance): Remove.
4604 (access_keymap_1): New function extracted from access_keymap to handle
4605 embedded parents and handle lists of maps.
4606 (access_keymap): Use it.
4607 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4608 (Fcopy_keymap): Handle embedded parents.
4609 (Fcommand_remapping, define_as_prefix): Simplify.
4610 (Fkey_binding): Simplify.
4611 (syms_of_keymap): Move minibuffer-local-completion-map,
4612 minibuffer-local-filename-completion-map,
4613 minibuffer-local-must-match-map, and
4614 minibuffer-local-filename-must-match-map to Elisp.
4615 (syms_of_keymap): Defsubr make-composed-keymap.
4616 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4617 (parse_menu_item): Trivial simplification.
4619 2011-07-01 Glenn Morris <rgm@gnu.org>
4621 * Makefile.in (SETTINGS_LIBS): Fix typo.
4623 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4625 * coding.c (Fencode_coding_string): Record the last coding system
4626 used, as the function doc string says (bug#8738).
4628 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4630 * xsettings.c (store_monospaced_changed): Take new font as arg and
4631 check for change against current_mono_font.
4632 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4633 (emacs_settings_constructor, emacs_settings_get_property)
4634 (emacs_settings_set_property, emacs_settings_class_init)
4635 (emacs_settings_init, gsettings_obj): Remove.
4636 (something_changedCB): New function for HAVE_GSETTINGS.
4637 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4638 with value as argument.
4639 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4640 g_settings_new (Bug#8967). Do not create gsettings_obj.
4641 Remove calls to g_settings_bind. Connect something_changedCB to
4644 * xgselect.c: Add defined (HAVE_GSETTINGS).
4645 (xgselect_initialize): Ditto.
4647 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4648 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4651 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4653 * eval.c (struct backtrace): Simplify and port the data structure.
4654 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4655 signed bit field, as this assumption is not portable and it makes
4656 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4657 "char debug_on_exit : 1" as this is not portable either; instead,
4658 use the portable "unsigned int debug_on_exit : 1". Remove unused
4659 member evalargs. Remove obsolete comments about cc bombing out.
4661 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4663 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4664 Let HAVE_GSETTINGS override HAVE_GCONF.
4665 (store_monospaced_changed): New function.
4666 (EMACS_SETTINGS): A new type derived from GObject to handle
4667 GSettings notifications.
4668 (emacs_settings_constructor, emacs_settings_get_property)
4669 (emacs_settings_set_property, emacs_settings_class_init):
4671 (gsettings_client, gsettings_obj): New variables.
4672 (GSETTINGS_SCHEMA): New define.
4673 (something_changedCB): Call store_monospaced_changed.
4674 (init_gsettings): New function.
4675 (xsettings_initialize): Call init_gsettings.
4676 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4679 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4682 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4684 * window.c (resize_root_window, grow_mini_window)
4685 (shrink_mini_window): Rename Qresize_root_window to
4686 Qwindow_resize_root_window and Qresize_root_window_vertically to
4687 Qwindow_resize_root_window_vertically.
4689 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4691 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4693 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4695 * makefile.w32-in: Redesign dependencies so they reflect more
4696 clearly which files are directly included by each source file,
4697 and not through other includes.
4699 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4701 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4702 (sort_overlays, overlay_strings): When an overlay's clone number
4703 matches the window's clone number process the overlay even if
4704 the overlay's window property doesn't match the current window.
4706 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4707 (Fwindow_hchild): Rename to Fwindow_left_child.
4708 (Fwindow_next): Rename to Fwindow_next_sibling.
4709 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4710 (resize_window_check): Rename to window_resize_check.
4711 (resize_window_apply): Rename to window_resize_apply.
4712 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4713 (Fdelete_other_windows_internal, resize_frame_windows)
4714 (Fsplit_window_internal, Fdelete_window_internal)
4715 (grow_mini_window, shrink_mini_window)
4716 (Fresize_mini_window_internal): Fix callers accordingly.
4718 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4720 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4721 (emacs_fixed_set_min_size): Remove.
4722 (emacs_fixed_new): Take frame as argument.
4724 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4725 (_EmacsFixedPrivate): Remove minwidth/height.
4726 Add struct frame *f.
4727 (emacs_fixed_init): Initialize priv->f.
4728 (get_parent_class, emacs_fixed_set_min_size): Remove.
4729 (emacs_fixed_new): Set priv->f to argument.
4730 (emacs_fixed_get_preferred_width)
4731 (emacs_fixed_get_preferred_height): Use min_width/height from
4732 frames size_hint to set minimum and natural (Bug#8919).
4733 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4734 and use min_width/height from frames size_hint to set
4735 min_width/height (Bug#8919).
4737 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4738 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4741 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4743 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4744 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4747 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4749 * process.c (wait_reading_process_output): Bypass select if
4750 waiting for a cell while ignoring keyboard input, and input is
4751 pending. Suggested by Jan Djärv (Bug#8869).
4753 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4755 Use gnulib's dup2 module instead of rolling our own.
4756 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4758 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4760 * dispnew.c (scrolling_window): Before scrolling, turn off a
4761 mouse-highlight in the window being scrolled.
4763 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4765 Move DEFSYM to lisp.h and use everywhere.
4767 * character.h (DEFSYM): Move declaration...
4768 * lisp.h (DEFSYM): ...here.
4774 * w32select.c: Don't include character.h.
4776 * alloc.c (syms_of_alloc):
4777 * buffer.c (syms_of_buffer):
4778 * bytecode.c (syms_of_bytecode):
4779 * callint.c (syms_of_callint):
4780 * casefiddle.c (syms_of_casefiddle):
4781 * casetab.c (init_casetab_once):
4782 * category.c (init_category_once, syms_of_category):
4783 * ccl.c (syms_of_ccl):
4784 * cmds.c (syms_of_cmds):
4785 * composite.c (syms_of_composite):
4786 * dbusbind.c (syms_of_dbusbind):
4787 * dired.c (syms_of_dired):
4788 * dispnew.c (syms_of_display):
4789 * doc.c (syms_of_doc):
4790 * editfns.c (syms_of_editfns):
4791 * emacs.c (syms_of_emacs):
4792 * eval.c (syms_of_eval):
4793 * fileio.c (syms_of_fileio):
4794 * fns.c (syms_of_fns):
4795 * frame.c (syms_of_frame):
4796 * fringe.c (syms_of_fringe):
4797 * insdel.c (syms_of_insdel):
4798 * keymap.c (syms_of_keymap):
4799 * lread.c (init_obarray, syms_of_lread):
4800 * macros.c (syms_of_macros):
4801 * msdos.c (syms_of_msdos):
4802 * print.c (syms_of_print):
4803 * process.c (syms_of_process):
4804 * search.c (syms_of_search):
4805 * sound.c (syms_of_sound):
4806 * syntax.c (init_syntax_once, syms_of_syntax):
4807 * terminal.c (syms_of_terminal):
4808 * textprop.c (syms_of_textprop):
4809 * undo.c (syms_of_undo):
4810 * w32.c (globals_of_w32):
4811 * window.c (syms_of_window):
4812 * xdisp.c (syms_of_xdisp):
4813 * xfaces.c (syms_of_xfaces):
4814 * xfns.c (syms_of_xfns):
4815 * xmenu.c (syms_of_xmenu):
4816 * xsettings.c (syms_of_xsettings):
4817 * xterm.c (syms_of_xterm): Use DEFSYM.
4819 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4821 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4823 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4825 Integer and buffer overflow fixes (Bug#8873).
4827 * print.c (printchar, strout): Check for string overflow.
4828 (PRINTPREPARE, printchar, strout):
4829 Don't set size unless allocation succeeds.
4831 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4832 for sizes. Check for string overflow more accurately.
4833 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4835 * macros.c: Integer and buffer overflow fixes.
4836 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4837 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4838 Use ptrdiff_t, not int, for sizes.
4839 Don't increment bufsize until after realloc succeeds.
4840 Check for size-calculation overflow.
4841 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4843 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4845 * lread.c: Integer overflow fixes.
4846 (read_integer): Radix is now EMACS_INT, not int,
4847 to improve quality of diagnostics for out-of-range radices.
4848 Calculate buffer size correctly for out-of-range radices.
4849 (read1): Check for integer overflow in radices, and in
4850 read-circle numbers.
4851 (read_escape): Avoid int overflow.
4852 (Fload, openp, read_buffer_size, read1)
4853 (substitute_object_recurse, read_vector, read_list, map_obarray):
4854 Use ptrdiff_t, not int, for sizes.
4855 (read1): Use EMACS_INT, not int, for sizes.
4856 Check for size overflow.
4858 * image.c (cache_image): Check for size arithmetic overflow.
4860 * lread.c: Integer overflow issues.
4861 (saved_doc_string_size, saved_doc_string_length)
4862 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4863 Now ptrdiff_t, not int.
4864 (read1): Don't assume doc string length fits in int. Check for
4865 out-of-range doc string lengths.
4866 (read_list): Don't assume file position fits in int.
4867 (read_escape): Check for hex character overflow.
4869 2011-06-22 Leo Liu <sdl.web@gmail.com>
4871 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4872 Move to minibuffer.el.
4874 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4876 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4877 The following patches are for when GLYPH_DEBUG && !XASSERT.
4878 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4879 * dispnew.c (flush_stdout):
4880 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4881 Mark as externally visible.
4882 * dispnew.c (check_window_matrix_pointers): Now static.
4883 * dispnew.c (window_to_frame_vpos):
4884 * xfns.c (unwind_create_frame):
4885 * xterm.c (x_check_font): Remove unused local.
4886 * scroll.c (CHECK_BOUNDS):
4887 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4888 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4889 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4890 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4891 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4893 (debug_method_add): Use va_list and vsprintf rather than relying
4894 on undefined behavior with wrong number of arguments.
4895 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4896 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4897 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4898 since we're not interested in debugging glyphs with old libraries.
4899 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4900 GCC 4.6.0's static checking.
4902 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4904 Integer overflow and signedness fixes (Bug#8873).
4905 A few related buffer overrun fixes, too.
4907 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4909 * dispextern.h (struct face.stipple):
4910 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4911 (x_bitmap_mask, x_allocate_bitmap_record)
4912 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4913 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4914 (x_create_bitmap_from_xpm_data):
4915 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4916 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4918 * xfaces.c (load_pixmap):
4919 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4920 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4921 (.bitmaps_last, struct x_output.icon_bitmap):
4922 Use ptrdiff_t, not int, for bitmap indexes.
4923 (x_allocate_bitmap_record): Check for size overflow.
4924 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4926 Use ptrdiff_t, not int, for overlay counts.
4927 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4928 * editfns.c (overlays_around, get_pos_property):
4929 * textprop.c (get_char_property_and_overlay):
4930 * xdisp.c (next_overlay_change, note_mouse_highlight):
4931 * xfaces.c (face_at_buffer_position):
4932 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4933 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4934 (Fnext_overlay_change, Fprevious_overlay_change)
4935 (mouse_face_overlay_overlaps, Foverlays_in):
4936 Use ptrdiff_t, not int, for sizes.
4937 (overlays_at, overlays_in): Check for size-calculation overflow.
4939 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4941 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4942 (x_session_initialize): Do not assume string length fits in int.
4944 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4945 This is unlikely, but can occur if DPI is outlandish.
4947 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4948 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4950 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4951 * xrdb.c (magic_file_p, search_magic_path):
4952 Omit last arg SUFFIX; it was always 0. All callers changed.
4953 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4955 * xfont.c (xfont_match): Avoid need for strlen.
4957 * xfns.c: Don't assume strlen fits in int.
4958 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4960 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4961 not unsigned long, as we prefer signed integers. All callers changed.
4962 Detect integer overflow in repeat count.
4963 (message_dolog): Don't assume print length fits in 39 bytes.
4964 (display_mode_element): Don't assume strlen fits in int.
4966 * termcap.c: Don't assume sizes fit in int and never overflow.
4967 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4968 (gobble_line): Check for size-calculation overflow.
4970 * minibuf.c (Fread_buffer):
4971 * lread.c (intern, intern_c_string):
4972 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4973 Don't assume string length fits in int.
4975 * keyboard.c (parse_tool_bar_item):
4976 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4978 * font.c: Don't assume string length fits in int.
4979 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4980 Use ptrdiff_t, not int.
4981 (font_intern_prop): Don't assume string length fits in int.
4982 Don't assume integer property fits in fixnum.
4983 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4985 * filelock.c: Fix some buffer overrun and integer overflow issues.
4986 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4987 Reformulate so as not to need the command string.
4988 Invoke gzip -cd rather than gunzip, as it's more portable.
4989 (lock_info_type, lock_file_1, lock_file):
4990 Don't assume pid_t and time_t fit in unsigned long.
4991 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4992 (current_lock_owner): Prefer signed type for sizes.
4993 Use memcpy, not strncpy, where memcpy is what is really wanted.
4994 Don't assume (via atoi) that time_t and pid_t fit in int.
4995 Check for time_t and/or pid_t out of range, e.g., via a network share.
4996 Don't alloca where an auto var works fine.
4998 * fileio.c: Fix some integer overflow issues.
4999 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5000 Don't assume string length fits in int.
5001 (directory_file_name): Don't assume string length fits in long.
5002 (make_temp_name): Don't assume pid fits in int, or that its print
5003 length is less than 20.
5005 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5007 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5009 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5011 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5012 We prefer signed integers, even for size calculations.
5014 * emacs.c: Don't assume string length fits in 'int'.
5015 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5016 (main): Don't invoke strlen when not needed.
5018 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5019 (XD_DEBUG_MESSAGE): Don't waste a byte.
5021 * callproc.c (getenv_internal_1, getenv_internal)
5023 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5025 * lread.c (invalid_syntax): Omit length argument.
5026 All uses changed. This doesn't fix a bug, but it simplifies the
5027 code away from its former Hollerith-constant appearance, and it's
5028 one less 'int' to worry about when looking at integer-overflow issues.
5029 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5031 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5032 This didn't break anything, but it didn't help either.
5033 It's confusing to put a bogus integer in a place where the actual
5034 value does not matter.
5035 (LIST_END_P): Remove unused macro and its bogus comment.
5036 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5038 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5039 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5041 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5042 We prefer signed types, and the value cannot exceed the EMACS_INT
5043 range anyway (because otherwise the length would not be representable).
5044 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5045 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5046 This avoids a GCC warning when WIDE_EMACS_INT.
5048 * indent.c (sane_tab_width): New function.
5049 (current_column, scan_for_column, Findent_to, position_indentation)
5050 (compute_motion): Use it. This is just for clarity.
5051 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5053 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5055 * lisp.h (lint_assume): New macro.
5056 * composite.c (composition_gstring_put_cache):
5057 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5059 * editfns.c, insdel.c:
5060 Omit unnecessary forward decls, to simplify future changes.
5062 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5064 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5066 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5067 Use much-faster test for byte-length change.
5068 Don't assume string byte-length fits in 'int'.
5069 Check that character arg fits in 'int'.
5070 (mapcar1): Declare byte as byte, for clarity.
5072 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5074 * fns.c (concat): Catch string overflow earlier.
5075 Do not rely on integer wraparound.
5077 * dispextern.h (struct it.overlay_strings_charpos)
5078 (struct it.selective): Now EMACS_INT, not int.
5079 * xdisp.c (forward_to_next_line_start)
5080 (back_to_previous_visible_line_start)
5081 (reseat_at_next_visible_line_start, next_element_from_buffer):
5082 Don't arbitrarily truncate the value of 'selective' to int.
5084 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5086 * composite.c: Don't truncate sizes to 'int'.
5087 (composition_gstring_p, composition_reseat_it)
5088 (composition_adjust_point): Use EMACS_INT, not int.
5089 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5090 not EMACS_UINT, for indexes.
5092 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5094 * buffer.c: Include <verify.h>.
5095 (struct sortvec.priority, struct sortstr.priority):
5096 Now EMACS_INT, not int.
5097 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5098 (struct sortstr.size, record_overlay_string)
5099 (struct sortstrlist.size, struct sortlist.used):
5100 Don't truncate size to int.
5101 (record_overlay_string): Check for size-calculation overflow.
5102 (init_buffer_once): Check at compile-time, not run-time.
5104 2011-06-22 Jim Meyering <meyering@redhat.com>
5106 Don't leak an XBM-image-sized buffer
5107 * image.c (xbm_load): Free the image buffer after using it.
5109 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5112 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5113 that Sun C diagnosed.
5114 * fns.c (secure_hash): Fix pointer signedness issue.
5115 * intervals.c (static_offset_intervals): New function.
5116 (offset_intervals): Use it.
5118 2011-06-21 Leo Liu <sdl.web@gmail.com>
5121 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5124 * fns.c (secure_hash): Rename from crypto_hash_function and change
5125 the first arg to accept symbols.
5126 (Fsecure_hash): New primitive.
5127 (syms_of_fns): New symbols.
5129 2011-06-20 Deniz Dogan <deniz@dogan.se>
5131 * process.c (Fset_process_buffer): Clarify return value in
5134 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5136 * dispnew.c (add_window_display_history): Use BVAR.
5138 * xdisp.c (debug_method_add): Use BVAR.
5139 (check_window_end, dump_glyph_matrix, dump_glyph)
5140 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5142 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5145 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5146 check till after the cache is created in init_frame_faces.
5148 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5150 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5152 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5154 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5155 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5156 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5158 Improve buffer-overflow checking (Bug#8873).
5159 * fileio.c (Finsert_file_contents):
5160 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5161 Remove the old (too-loose) buffer overflow checks.
5162 They weren't needed, since make_gap checks for buffer overflow.
5163 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5164 The old code merely checked for Emacs fixnum overflow, and relied
5165 on undefined (wraparound) behavior. The new code avoids undefined
5166 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5168 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5169 Tune. Don't use wider integers than needed. Don't use alloca.
5170 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5172 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5174 * insdel.c, lisp.h (buffer_overflow): New function.
5175 (insert_from_buffer_1, replace_range, replace_range_2):
5176 * insdel.c (make_gap_larger):
5177 * editfns.c (Finsert_char):
5178 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5180 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5182 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5184 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5186 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5187 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5189 * fileio.c: Don't assume EMACS_INT fits in off_t.
5190 (emacs_lseek): New static function.
5191 (Finsert_file_contents, Fwrite_region): Use it.
5192 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5194 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5196 * fns.c: Don't overflow int when computing a list length.
5197 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5198 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5199 truncation on 64-bit hosts. Check for QUIT every
5200 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5201 faster and is responsive enough.
5202 (Flength): Report an error instead of overflowing an integer.
5203 (Fsafe_length): Return a float if the value is not representable
5204 as a fixnum. This shouldn't happen except in contrived situations.
5205 (Fnthcdr, Fsort): Don't assume list length fits in int.
5206 (Fcopy_sequence): Don't assume vector length fits in int.
5208 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5209 (header_size, word_size): New constants.
5210 (allocate_vectorlike): Don't check size overflow here.
5211 (allocate_vector): Check it here instead, since this is the only
5212 caller of allocate_vectorlike that could cause overflow.
5213 Check that the new vector's length is representable as a fixnum.
5215 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5216 The previous code was bogus. For example, next_almost_prime (32)
5217 returned 39, which is undesirable as it is a multiple of 3; and
5218 next_almost_prime (24) returned 25, which is a multiple of 5 so
5219 why was the code bothering to check for multiples of 7?
5221 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5223 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5225 Variadic C functions now count arguments with ptrdiff_t.
5226 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5227 Back then I didn't know that the Emacs coding style prefers signed int.
5228 Also, in the meantime I found a few more instances where arguments
5229 were being counted with int, which may truncate counts on 64-bit
5230 machines, or EMACS_INT, which may be unnecessarily wide.
5231 * lisp.h (struct Lisp_Subr.function.aMANY)
5232 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5233 Arg counts are now ptrdiff_t, not size_t.
5234 All variadic functions and their callers changed accordingly.
5235 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5236 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5237 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5238 * callint.c (Fcall_interactively): Check arg count for overflow,
5239 to avoid potential buffer overrun. Use signed char, not 'int',
5240 for 'varies' array, so that we needn't bother to check its size
5241 calculation for overflow.
5242 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5243 * eval.c (apply_lambda):
5244 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5245 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5246 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5248 * callint.c (Fcall_interactively): Don't use index var as event count.
5250 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5251 * mem-limits.h (SIZE): Remove; no longer used.
5253 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5255 Remove unnecessary casts.
5256 * xterm.c (x_term_init):
5257 * xfns.c (x_set_border_pixel):
5258 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5259 These aren't needed now that we assume ANSI C.
5261 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5262 It's more likely to cause problems (due to unsigned overflow)
5265 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5267 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5269 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5271 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5273 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5275 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5277 GLYPH_CODE_FACE returns EMACS_INT, not int.
5278 * dispextern.h (merge_faces):
5279 * xfaces.c (merge_faces):
5280 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5281 Don't assume EMACS_INT fits in int.
5283 * character.h (CHAR_VALID_P): Remove unused parameter.
5284 * fontset.c, lisp.h, xdisp.c: All uses changed.
5286 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5288 * fns.c (concat): Minor tuning based on overflow analysis.
5289 This doesn't fix any bugs. Use int to hold character, instead
5290 of constantly refetching from Emacs object. Use XFASTINT, not
5291 XINT, for value known to be a character. Don't bother comparing
5292 a single byte to 0400, as it's always less.
5294 * floatfns.c (Fexpt):
5295 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5297 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5300 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5302 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5303 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5304 incorrectly succeed when S was a string, because 4294967386 was
5305 truncated before it was used.
5307 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5308 Otherwise, an out-of-range integer could cause undefined behavior
5311 * composite.c: Use int, not EMACS_INT, for characters.
5312 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5313 EMACS_INT, for values that are known to be in character range.
5314 This doesn't fix any bugs but is the usual style inside Emacs and
5315 may generate better code on 32-bit machines.
5317 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5318 This is for reasons similar to the recent CHAR_STRING fix.
5319 * charset.c (Fencode_char): Check that character arg is actually
5320 a character. Pass an int to ENCODE_CHAR.
5321 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5322 wider than 'int', as a compile-time check to prevent future regressions
5325 * character.c (char_string): Remove unnecessary casts.
5327 Make sure a 64-bit char is never passed to CHAR_STRING.
5328 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5329 by silently ignoring the top 32 bits, allowing some values
5330 that were far too large to be valid characters.
5331 * character.h: Include <verify.h>.
5332 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5333 arguments are no wider than unsigned, as a compile-time check
5334 to prevent future regressions in this area.
5336 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5337 (Fsubst_char_in_region):
5339 * xdisp.c (decode_mode_spec_coding):
5340 Adjust to CHAR_STRING's new requirement.
5341 * editfns.c (Finsert_char, Fsubst_char_in_region):
5342 * fns.c (concat): Check that character args are actually
5343 characters. Without this test, these functions did the wrong
5344 thing with wildly out-of-range values on 64-bit hosts.
5346 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5347 These casts should not be needed on 32-bit hosts, either.
5348 * keyboard.c (read_char):
5349 * lread.c (Fload): Remove casts to unsigned.
5351 * lisp.h (UNSIGNED_CMP): New macro.
5352 This fixes comparison bugs on 64-bit hosts.
5353 (ASCII_CHAR_P): Use it.
5354 * casefiddle.c (casify_object):
5355 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5356 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5357 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5358 * dispextern.h (FACE_FROM_ID):
5359 * keyboard.c (read_char): Use UNSIGNED_CMP.
5361 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5362 not to EMACS_INT, to avoid GCC warning.
5364 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5366 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5367 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5368 isn't needed on 32-bit machines.
5370 * buffer.c (Fgenerate_new_buffer_name):
5371 Use EMACS_INT for count, not int.
5372 (advance_to_char_boundary): Return EMACS_INT, not int.
5374 * data.c (Qcompiled_function): Now static.
5376 * window.c (window_body_lines): Now static.
5378 * image.c (gif_load): Rename local to avoid shadowing.
5380 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5381 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5382 * alloc.c (make_save_value): Integer argument is now of type
5384 (mark_object): Use ptrdiff_t, not int.
5385 * lisp.h (pD): New macro.
5386 * print.c (print_object): Use it.
5388 * alloc.c: Use EMACS_INT, not int, to count objects.
5389 (total_conses, total_markers, total_symbols, total_vector_size)
5390 (total_free_conses, total_free_markers, total_free_symbols)
5391 (total_free_floats, total_floats, total_free_intervals)
5392 (total_intervals, total_strings, total_free_strings):
5393 Now EMACS_INT, not int. All uses changed.
5394 (Fgarbage_collect): Compute overall total using a double, so that
5395 integer overflow is less likely to be a problem. Check for overflow
5396 when converting back to an integer.
5397 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5398 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5399 These were 'int' variables that could overflow on 64-bit hosts;
5400 they were never used, so remove them instead of repairing them.
5401 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5402 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5403 Previously, this ceilinged at INT_MAX, but that doesn't work on
5405 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5407 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5408 (allocate_vectorlike): Check for ptrdiff_t overflow.
5409 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5410 when a (possibly-narrower) signed value would do just as well.
5411 We prefer using signed arithmetic, to avoid comparison confusion.
5413 * alloc.c: Catch some string size overflows that we were missing.
5414 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5415 for convenience in STRING_BYTES_MAX.
5416 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5417 The definition here is exact; the one in lisp.h was approximate.
5418 (allocate_string_data): Check for string overflow. This catches
5419 some instances we weren't catching before. Also, it catches
5420 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5421 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5422 and ptrdiff_t and EMACS_INT are both 64 bits.
5424 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5425 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5426 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5428 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5430 * alloc.c (Fmake_string): Check for out-of-range init.
5432 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5434 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5436 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5438 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5439 xg_get_default_scrollbar_width.
5441 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5442 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5443 (style_changed_cb): Call update_theme_scrollbar_width and call
5444 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5445 all frames (Bug#8505).
5446 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5447 Call gtk_window_set_resizable if HAVE_GTK3.
5448 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5449 and height if HAVE_GTK3 (Bug#8505).
5450 (scroll_bar_width_for_theme): New variable.
5451 (update_theme_scrollbar_width): New function.
5452 (xg_get_default_scrollbar_width): Move code to
5453 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5454 (xg_initialize): Call update_theme_scrollbar_width.
5456 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5458 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5460 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5462 * frame.c (make_frame): Call other_buffer_safely instead of
5465 * window.c (temp_output_buffer_show): Call display_buffer with
5466 second argument Vtemp_buffer_show_specifiers and reset latter
5467 immediately after the call.
5468 (Vtemp_buffer_show_specifiers): New variable.
5469 (auto_window_vscroll_p, next_screen_context_lines)
5470 (Vscroll_preserve_screen_position): Remove leading asterisks from
5473 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5475 Fix minor problems found by GCC 4.6.0 static checking.
5476 * buffer.c (Qclone_number): Remove for now, as it's unused.
5477 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5478 (record_buffer): Remove unused local.
5479 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5480 (set_frame_buffer_list): Remove; unused.
5481 * frame.h (other_visible_frames): Remove decl.
5482 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5483 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5484 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5486 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5487 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5488 Define only if HAVE_GPM.
5489 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5490 (update_hints_inhibit): Remove; never set. All uses removed.
5491 * widgetprv.h (emacsFrameClassRec): Remove decl.
5492 * window.c (delete_deletable_window): Now returns void, since it
5493 wasn't returning anything.
5494 (compare_window_configurations): Remove unused locals.
5495 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5496 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5497 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5498 the same widths as pointers. This follows up on the 2011-05-06 patch.
5499 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5500 * xterm.h: Likewise.
5501 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5503 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5505 * makefile.w32-in: Update dependencies.
5506 (LISP_H): Add lib/intprops.h.
5508 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5510 * image.c (gif_load): Add animation frame delay to the metadata.
5511 (syms_of_image): Use DEFSYM. New symbol `delay'.
5513 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5515 * window.c (delete_deletable_window): Re-add.
5516 (Fset_window_configuration): Rewrite to handle dead buffers and
5517 consequently deletable windows.
5518 (window_tree, Fwindow_tree): Remove. Supply functionality in
5520 (compare_window_configurations): Simplify code.
5522 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5524 * image.c (imagemagick_load_image): Fix type mismatch.
5525 (Fimagemagick_types): Likewise.
5527 * window.h (replace_buffer_in_windows): Declare.
5529 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5531 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5532 Qclone_number. Remove external declaration of Qdelete_window.
5533 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5535 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5536 Run Qbuffer_list_update_hook if allowed.
5537 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5538 buffer list implementation.
5539 (other_buffer_safely): New function.
5540 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5541 calls to replace_buffer_in_windows and
5542 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5544 (record_buffer): Inhibit quitting and rewrite using quittable
5545 functions. Run Qbuffer_list_update_hook if allowed.
5546 (Frecord_buffer, Funrecord_buffer): New functions.
5547 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5548 Move switch-to-buffer to window.el.
5549 (bury-buffer): Move to window.el.
5550 (Vbuffer_list_update_hook): New variable.
5552 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5555 * window.h (resize_frame_windows): Move up in code.
5556 (Fwindow_frame): Remove EXFUN.
5557 (replace_buffer_in_all_windows): Remove prototype.
5558 (replace_buffer_in_windows_safely): Add prototype.
5560 * window.c: Declare Qdelete_window static again. Move down
5561 declaration of select_count.
5562 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5563 (Fother_window): Move to window.el.
5564 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5565 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5566 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5568 (replace_buffer_in_windows): Implement by calling
5569 Qreplace_buffer_in_windows.
5570 (replace_buffer_in_all_windows): Remove with some functionality
5571 moved into replace_buffer_in_windows_safely.
5572 (replace_buffer_in_windows_safely): New function.
5573 (select_window_norecord, select_frame_norecord): Move in front
5574 of run_window_configuration_change_hook. Remove now obsolete
5576 (Fset_window_buffer): Rewrite doc-string.
5577 Call Qrecord_window_buffer.
5578 (keys_of_window): Move binding for other-window to window.el.
5580 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5582 * dispextern.h (struct image): Replace data member, whose int_val
5583 and ptr_val fields were not used by anything, with a single
5586 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5587 (gif_clear_image, gif_load, imagemagick_load_image)
5588 (gs_clear_image, gs_load): Callers changed.
5590 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5592 * buffer.h: Include <time.h>, for time_t.
5593 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5595 Fix minor problems found by static checking.
5597 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5599 Make identifiers static if they are not used in other modules.
5600 * data.c (Qcompiled_function, Qframe, Qvector):
5601 * image.c (QimageMagick, Qsvg):
5602 * minibuf.c (Qmetadata):
5603 * window.c (resize_window_check, resize_root_window): Now static.
5604 * window.h (resize_window_check, resize_root_window): Remove decls.
5606 * window.c (window_deletion_count, delete_deletable_window):
5608 (window_body_lines): Now static.
5609 (Fdelete_other_windows_internal): Mark vars as initialized.
5610 Make sure 'resize_failed' is initialized.
5611 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5612 (resize_window_apply): Remove unused local.
5613 * window.h (delete_deletable_window): Remove decl.
5615 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5616 (imagemagick_load_image): Fix pointer signedness problem by changing
5617 last arg from unsigned char * to char *. All uses changed.
5618 Also, fix a local for similar reasons.
5619 Remove unused locals. Remove locals to avoid shadowing.
5620 (fn_rsvg_handle_free): Remove; unused.
5621 (svg_load, svg_load_image): Fix pointer signedness problem.
5622 (imagemagick_load_image): Don't use garbage pointer image_wand.
5624 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5626 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5628 * image.c (gif_load): Fix omitted cast error introduced by
5631 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5633 * window.h (resize_proportionally, orig_total_lines)
5634 (orig_top_line): Remove from window structure.
5635 (set_window_height, set_window_width, change_window_heights)
5636 (Fdelete_window): Remove prototypes.
5637 (resize_frame_windows): Remove duplicate declaration.
5639 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5641 * window.h (resize_frame_windows, resize_window_check)
5642 (delete_deletable_window, resize_root_window)
5643 (resize_frame_windows): Declare prototypes.
5645 * window.c (resize_window_apply): Make definition be "static" to
5646 match the prototype.
5648 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5650 * window.c: Remove declarations of Qwindow_size_fixed,
5651 window_min_size_1, window_min_size_2, window_min_size,
5652 size_window, window_fixed_size_p, enlarge_window, delete_window.
5653 Remove static from declaration of Qdelete_window, it's
5654 temporarily needed by Fbury_buffer.
5655 (replace_window): Don't assign orig_top_line and
5657 (Fdelete_window, delete_window): Remove. Window deletion is
5658 handled by window.el.
5659 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5660 Replace Fdelete_window calls with calls to Qdelete_window.
5661 (Fdelete_other_windows): Remove. Deleting other windows is
5662 handled by window.el.
5663 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5664 handled in window.el.
5665 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5666 Window minimum sizes are handled in window.el.
5667 (shrink_windows, size_window, set_window_height)
5668 (set_window_width, change_window_heights, window_height)
5669 (window_width, CURBEG, CURSIZE, enlarge_window)
5670 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5671 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5672 handled in window.el.
5673 (make_dummy_parent): Rename to make_parent_window and give it a
5674 second argument horflag.
5675 (make_window): Don't set resize_proportionally any more.
5676 (Fsplit_window): Remove. Windows are split in window.el.
5677 (save_restore_action, save_restore_orig_size)
5678 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5679 Resize mini windows in window.el.
5680 (grow_mini_window, shrink_mini_window): Implement by calling
5681 Qresize_root_window_vertically, resize_window_check and
5682 resize_window_apply.
5683 (saved_window, Fset_window_configuration, save_window_save):
5684 Do not handle orig_top_line, orig_total_lines, and
5685 resize_proportionally.
5686 (window_min_height, window_min_width): Move to window.el.
5687 (keys_of_window): Move bindings for delete-other-windows,
5688 split-window, delete-window and enlarge-window to window.el.
5690 * buffer.c: Temporarily extern Qdelete_window.
5691 (Fbury_buffer): Temporarily call Qdelete_window instead of
5692 Fdelete_window (Fbury_buffer will move to window.el soon).
5694 * frame.c (set_menu_bar_lines_1): Remove code handling
5695 orig_top_line and orig_total_lines.
5697 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5698 set_window_height but set heights directly.
5699 (change_frame_size_1): Use resize_frame_windows.
5701 * xdisp.c (init_xdisp): Don't use set_window_height but set
5704 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5705 Use resize_frame_windows instead of change_window_heights and run
5706 run_window_configuration_change_hook.
5708 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5709 instead of change_window_heights and run
5710 run_window_configuration_change_hook.
5712 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5714 * window.c (replace_window): Rename second argument REPLACEMENT to
5715 NEW. New third argument SETFLAG. Rewrite.
5716 (delete_window, make_dummy_parent): Call replace_window with
5718 (window_list_1): Move down in code.
5719 (run_window_configuration_change_hook): Move set_buffer part
5720 before select_frame_norecord part in order to unwind correctly.
5721 Rename count1 to count.
5722 (recombine_windows, delete_deletable_window, resize_root_window)
5723 (Fdelete_other_windows_internal)
5724 (Frun_window_configuration_change_hook, make_parent_window)
5725 (resize_window_check, resize_window_apply, Fresize_window_apply)
5726 (resize_frame_windows, Fsplit_window_internal)
5727 (Fdelete_window_internal, Fresize_mini_window_internal):
5729 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5731 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5733 * window.h (window): Add some new members to window structure -
5734 normal_lines, normal_cols, new_total, new_normal, clone_number,
5735 splits, nest, prev_buffers, next_buffers.
5736 (WINDOW_TOTAL_SIZE): Move here from window.c.
5737 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5739 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5741 (make_dummy_parent): Set new members of windows structure.
5742 (make_window): Move down in code. Handle new members of window
5744 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5745 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5746 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5747 (Fset_window_prev_buffers, Fwindow_next_buffers)
5748 (Fset_window_next_buffers, Fset_window_clone_number):
5750 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5751 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5753 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5754 Argument WINDOW can be now internal window too.
5755 (Fwindow_use_time): Move up in code.
5756 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5758 (Fset_window_configuration, saved_window)
5759 (Fcurrent_window_configuration, save_window_save): Handle new
5760 members of window structure.
5761 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5762 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5763 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5764 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5765 Qget_mru_window, Qresize_root_window,
5766 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5767 Qauto_buffer_name; staticpro them.
5769 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5771 * window.c (Fwindow_total_size, Fwindow_left_column)
5772 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5773 (Fwindow_list_1): New functions.
5774 (window_box_text_cols): Replace with window_body_cols.
5775 (Fwindow_width, Fscroll_left, Fscroll_right):
5776 Use window_body_cols instead of window_box_text_cols.
5777 (delete_window, Fset_window_configuration):
5778 Call delete_all_subwindows with window as argument.
5779 (delete_all_subwindows): Take a window as argument and not a
5781 (window_loop): Remove handling of GET_LRU_WINDOW and
5783 (Fget_lru_window, Fget_largest_window): Move to window.el.
5785 * window.h: Extern window_body_cols instead of
5786 window_box_text_cols. delete_all_subwindows now takes a
5787 Lisp_Object as argument.
5789 * indent.c (compute_motion, Fcompute_motion):
5790 Use window_body_cols instead of window_box_text_cols.
5792 * frame.c (delete_frame): Call delete_all_subwindows with root
5795 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5797 * fns.c (Fputhash): Document return value.
5799 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5801 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5803 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5805 Cons<->int and similar integer overflow fixes (Bug#8794).
5807 Check for overflow when converting integer to cons and back.
5808 * charset.c (Fdefine_charset_internal, Fdecode_char):
5809 Use cons_to_unsigned to catch overflow.
5810 (Fencode_char): Use INTEGER_TO_CONS.
5811 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5812 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5813 * data.c (long_to_cons, cons_to_long): Remove.
5814 (cons_to_unsigned, cons_to_signed): New functions.
5815 These signal an error for invalid or out-of-range values.
5816 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5817 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5818 * font.c (Ffont_variation_glyphs):
5819 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5820 * lisp.h: Include <intprops.h>.
5821 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5822 (cons_to_signed, cons_to_unsigned): New decls.
5823 (long_to_cons, cons_to_long): Remove decls.
5824 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5825 (Fprimitive_undo): Use CONS_TO_INTEGER.
5826 * xfns.c (Fx_window_property): Likewise.
5827 * xselect.c: Include <limits.h>.
5828 (x_own_selection, selection_data_to_lisp_data):
5829 Use INTEGER_TO_CONS.
5830 (x_handle_selection_request, x_handle_selection_clear)
5831 (x_get_foreign_selection, Fx_disown_selection_internal)
5832 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5833 (lisp_data_to_selection_data): Use cons_to_unsigned.
5834 (x_fill_property_data): Use cons_to_signed.
5835 Report values out of range.
5837 Check for buffer and string overflow more precisely.
5838 * buffer.h (BUF_BYTES_MAX): New macro.
5839 * lisp.h (STRING_BYTES_MAX): New macro.
5840 * alloc.c (Fmake_string):
5841 * character.c (string_escape_byte8):
5842 * coding.c (coding_alloc_by_realloc):
5843 * doprnt.c (doprnt):
5844 * editfns.c (Fformat):
5846 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5847 since they may not be the same number.
5848 * editfns.c (Finsert_char):
5849 * fileio.c (Finsert_file_contents):
5850 Likewise for BUF_BYTES_MAX.
5852 * image.c: Use ptrdiff_t, not int, for sizes.
5853 (slurp_file): Switch from int to ptrdiff_t.
5855 (slurp_file): Check that file size fits in both size_t (for
5856 malloc) and ptrdiff_t (for sanity and safety).
5858 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5859 if b->modtime has its maximal value.
5861 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5863 Don't assume time_t can fit into int.
5864 * buffer.h (struct buffer.modtime): Now time_t, not int.
5865 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5866 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5868 Minor fixes for signed vs unsigned integers.
5869 * character.h (MAYBE_UNIFY_CHAR):
5870 * charset.c (maybe_unify_char):
5871 * keyboard.c (read_char, reorder_modifiers):
5872 XINT -> XFASTINT, since the integer must be nonnegative.
5873 * ftfont.c (ftfont_spec_pattern):
5874 * keymap.c (access_keymap, silly_event_symbol_error):
5875 XUINT -> XFASTINT, since the integer must be nonnegative.
5876 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5877 since it makes no difference and we prefer signed.
5878 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5879 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5882 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5884 * window.h (Fwindow_frame): Declare.
5886 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5888 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5889 (SPARE_MEMORY): Always define.
5890 (LARGE_REQUEST): Remove.
5891 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5893 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5895 * lisp.h: Move EXFUNS for Fframe_root_window,
5896 Fframe_first_window and Fset_frame_selected_window to window.h.
5898 * window.h: Move EXFUNS for Fframe_root_window,
5899 Fframe_first_window and Fset_frame_selected_window here from
5902 * frame.c (Fwindow_frame, Fframe_first_window)
5903 (Fframe_root_window, Fframe_selected_window)
5904 (Fset_frame_selected_window): Move to window.c.
5905 (Factive_minibuffer_window): Move to minibuf.c.
5906 (Fother_visible_frames_p): New function.
5908 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5910 * window.c (decode_window, decode_any_window): Move up in code.
5911 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5912 (inhibit_frame_unsplittable): Remove unused variable.
5913 (Fwindow_buffer): Move up and rewrite doc-string.
5914 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5915 (Fwindow_prev): New functions.
5916 (Fwindow_frame): Move here from frame.c. Accept any window as
5918 (Fframe_root_window, Fframe_first_window)
5919 (Fframe_selected_window): Move here from frame.c. Accept frame
5920 or arbitrary window as argument. Update doc-strings.
5921 (Fminibuffer_window): Move up in code.
5922 (Fwindow_minibuffer_p): Move up in code and simplify.
5923 (Fset_frame_selected_window): Move here from frame.c.
5925 (Fselected_window, select_window, Fselect_window): Move up in
5926 code. Minor doc-string fixes.
5928 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5930 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5931 Do not assume that spare memory exists; that assumption is valid
5932 only if SYSTEM_MALLOC.
5933 (LARGE_REQUEST): New macro, so that the issue of large requests
5934 is separated from the issue of spare memory.
5936 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5938 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5941 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5943 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5946 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5948 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5950 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5952 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5953 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5955 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5957 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5959 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5961 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5962 (x_clipboard_manager_save): Add return value.
5963 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5965 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5966 Obey Vx_select_enable_clipboard_manager. Catch errors in
5967 x_clipboard_manager_save (Bug#8779).
5968 (Vx_select_enable_clipboard_manager): New variable.
5969 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5971 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5973 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5975 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5977 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5978 in the current matrix if keep_current_p is non-zero.
5980 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5982 * bidi.c (bidi_level_of_next_char): Fix last change.
5984 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5986 Support bidi reordering of text covered by display properties.
5988 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5989 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5990 (bidi_cache_search, bidi_cache_iterator_state)
5991 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5992 (bidi_level_of_next_char, bidi_move_to_visually_next):
5993 Support character positions inside a run of characters covered by a
5995 (bidi_paragraph_init, bidi_resolve_explicit_1)
5996 (bidi_level_of_next_char): Call bidi_fetch_char and
5997 bidi_fetch_char_advance instead of FETCH_CHAR and
5999 (bidi_init_it): Initialize new members.
6000 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6002 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6003 instead of using explicit *_CHAR codes.
6004 (bidi_resolve_explicit, bidi_resolve_weak):
6005 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6006 bidirectional text is supported only in multibyte buffers.
6007 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6008 it to initialize the frame_window_p member of struct bidi_it.
6009 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6010 (bidi_resolve_explicit, bidi_resolve_weak)
6011 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6012 bidi_it->nchars is non-positive.
6013 (bidi_level_of_next_char): Don't try to lookup the cache for the
6014 next/previous character if nothing is cached there yet, or if we
6015 were just reseat()'ed to a new position.
6017 * xdisp.c (set_cursor_from_row): Set start and stop points
6018 according to the row's direction when priming the loop that looks
6019 for the glyph on which to display cursor.
6020 (single_display_spec_intangible_p): Function deleted.
6021 (display_prop_intangible_p): Reimplement to call
6022 handle_display_spec instead of single_display_spec_intangible_p.
6023 Accept 3 additional arguments needed by handle_display_spec.
6024 This fixes incorrect cursor motion across display property with complex
6025 values: lists, `(when COND...)' forms, etc.
6026 (single_display_spec_string_p): Support property values that are
6027 lists with the argument STRING its top-level element.
6028 (display_prop_string_p): Fix the condition for processing a
6029 property that is a list to be consistent with handle_display_spec.
6030 (handle_display_spec): New function, refactored from the
6031 last portion of handle_display_prop.
6032 (compute_display_string_pos): Accept additional argument
6033 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6034 value of a `display' property is a "replacing spec".
6035 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6036 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6037 the display property, but just return a value indicating whether
6038 the display property will replace the characters it covers.
6039 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6040 frame_window_p members of struct bidi_it.
6041 (compute_display_string_pos, compute_display_string_end):
6043 (push_it): Accept second argument POSITION, where pop_it should
6044 jump to continue iteration.
6045 (reseat_1): Initialize bidi_it.disp_pos.
6047 * keyboard.c (adjust_point_for_property): Adjust the call to
6048 display_prop_intangible_p to its new signature.
6050 * dispextern.h (struct bidi_it): New member frame_window_p.
6051 (bidi_init_it): Update prototypes.
6052 (display_prop_intangible_p): Update prototype.
6053 (compute_display_string_pos, compute_display_string_end):
6055 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6058 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6060 Malloc failure behavior now depends on size of allocation.
6061 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6062 * lisp.h: Change signatures accordingly.
6063 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6064 All callers changed. (Bug#8762)
6066 * gnutls.c: Use Emacs's memory allocators.
6067 Without this change, the gnutls library would invoke malloc etc.
6068 directly, which causes problems on non-SYNC_INPUT hosts, and which
6069 runs afoul of improving memory_full behavior. (Bug#8761)
6070 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6071 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6072 xfree instead of the default malloc, realloc, free.
6073 (Fgnutls_boot): No need to check for memory allocation failure,
6074 since xmalloc does that for us.
6076 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6077 * category.c (hash_get_category_set):
6078 * ccl.c (ccl_driver):
6079 * charset.c (Fdefine_charset_internal):
6080 * charset.h (struct charset.hash_index):
6081 * composite.c (get_composition_id, gstring_lookup_cache)
6082 (composition_gstring_put_cache):
6083 * composite.h (struct composition.hash_index):
6084 * dispextern.h (struct image.hash):
6085 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6086 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6087 (hashfn_equal, hashfn_user_defined, make_hash_table)
6088 (maybe_resize_hash_table, hash_lookup, hash_put)
6089 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6090 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6091 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6092 * image.c (make_image, search_image_cache, lookup_image)
6093 (xpm_put_color_table_h):
6094 * lisp.h (struct Lisp_Hash_Table):
6095 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6096 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6097 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6098 * alloc.c (allocate_vectorlike):
6099 Check for overflow in vector size calculations.
6100 * ccl.c (ccl_driver):
6101 Check for overflow when converting EMACS_INT to int.
6102 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6103 need to be updated by these changes.
6104 * fns.c (make_hash_table, maybe_resize_hash_table):
6105 Check for integer overflow with large hash tables.
6106 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6107 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6108 (SXHASH_REDUCE): New macro.
6109 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6110 Use it instead of discarding useful hash info with large hash values.
6111 (sxhash_float): New function.
6112 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6113 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6114 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6115 Rewrite to use FIXNUM_BITS, as this simplifies things.
6116 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6117 Adjust signatures to match updated version of code.
6118 (consing_since_gc): Now EMACS_INT, since a single hash table can
6119 use more than INT_MAX bytes.
6121 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6123 Make it possible to build with GCC-4.6+ -O2 -flto.
6125 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6127 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6129 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6130 Call minibuffer-inactive-mode.
6132 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6134 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6135 Update dependencies.
6137 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6139 * data.c (init_data): Remove code for UTS, this system is not
6142 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6144 Don't force ./temacs to start in terminal mode.
6146 * frame.c (make_initial_frame): Initialize faces in all cases, not
6147 only when CANNOT_DUMP is defined.
6148 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6150 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6152 * dispnew.c (add_window_display_history): Use const for the string
6153 pointer. Remove declaration, not needed.
6155 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6157 Use 'inline', not 'INLINE'.
6158 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6159 * alloc.c, fontset.c (INLINE): Remove.
6160 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6161 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6162 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6163 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6164 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6166 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6168 Make it possible to run ./temacs.
6170 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6171 syms_of_callproc does the same thing. Remove test for
6172 "initialized", do it in the caller.
6173 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6175 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6177 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6178 (read_minibuf): Use get_minibuffer.
6179 (syms_of_minibuf): Use DEFSYM.
6180 (Qmetadata): New var.
6181 * data.c (Qbuffer): Don't make it static.
6182 (syms_of_data): Use DEFSYM.
6184 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6186 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6187 (CCL_CODE_MIN): New macro.
6189 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6191 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6193 * eval.c (Qdebug): Now static.
6194 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6195 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6196 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6198 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6200 * image.c: Various fixes to ImageMagick code comments.
6201 (Fimagemagick_types): Doc fix.
6203 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6205 Minor fixes prompted by GCC 4.6.0 warnings.
6207 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6209 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6210 (x_clipboard_manager_save_all): Move extern decl to ...
6211 * xterm.h: ... here, so that it can be checked for consistency.
6213 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6215 * xselect.c (x_clipboard_manager_save_frame)
6216 (x_clipboard_manager_save_all): New functions.
6217 (Fx_clipboard_manager_save): Lisp function deleted.
6219 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6220 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6222 * xterm.h: Update prototype.
6224 2011-05-28 William Xu <william.xwl@gmail.com>
6226 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6229 2011-05-28 Jim Meyering <meyering@redhat.com>
6231 Avoid a sign-extension bug in crypto_hash_function.
6232 * fns.c (to_uchar): Define.
6233 (crypto_hash_function): Use it to convert some newly-signed
6234 variables to unsigned, to avoid sign-extension bugs. For example,
6235 without this change, (md5 "truc") would evaluate to
6236 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6237 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6238 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6240 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6242 Integer overflow fixes.
6244 * dbusbind.c: Serial number integer overflow fixes.
6245 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6246 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6247 to hold a serial number that is too large for a fixnum.
6248 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6249 Check for serial numbers out of range. Decode any serial number
6250 that was so large that it became a float. (Bug#8722)
6252 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6253 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6254 Use XFASTINT rather than XUINT when numbers are nonnegative.
6255 (xd_append_arg, Fdbus_method_return_internal):
6256 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6257 arguments, check that Lisp number is nonnegative, rather than
6258 silently wrapping negative numbers around. (Bug#8722)
6259 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6262 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6264 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6266 ccl: Add integer overflow checks.
6267 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6268 (IN_INT_RANGE): New macros.
6269 (ccl_driver): Use them to check for integer overflow when
6270 decoding a CCL program. Many of the new checks are whether XINT (x)
6271 fits in int; it doesn't always, on 64-bit hosts. The new version
6272 doesn't catch all possible integer overflows, but it's an
6273 improvement. (Bug#8719)
6275 * alloc.c (make_event_array): Use XINT, not XUINT.
6276 There's no need for unsigned here.
6278 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6279 This follows up to the 2011-05-06 change that substituted uintptr_t
6280 for EMACS_INT. This case wasn't caught back then.
6282 Rework Fformat to avoid integer overflow issues.
6283 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6284 now (part of C89). Include <verify.h>.
6285 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6286 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6287 (Fformat): Avoid the prepass trying to compute sizes; it was only
6288 approximate and thus did not catch overflow reliably. Instead, walk
6289 through the format just once, formatting and computing sizes as we go,
6290 checking for integer overflow at every step, and allocating a larger
6291 buffer as needed. Keep track separately whether the format is
6292 multibyte. Keep only the most-recently calculated precision, rather
6293 than them all. Record whether each argument has been converted to
6294 string. Use EMACS_INT, not int, for byte and char and arg counts.
6295 Support field widths and precisions larger than INT_MAX. Avoid
6296 sprintf's undefined behavior with conversion specifications such as %#d
6297 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6298 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6299 formatting out-of-range floating point numbers with int
6302 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6304 * data.c: Avoid integer truncation in expressions involving floats.
6305 * data.c: Include <intprops.h>.
6306 (arith_driver): When there's an integer overflow in an expression
6307 involving floating point, convert the integers to floating point
6308 so that the resulting value does not suffer from catastrophic
6309 integer truncation. For example, on a 64-bit host (* 4
6310 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6311 Do not rely on undefined behavior after integer overflow.
6313 merge count_size_as_multibyte, parse_str_to_multibyte
6314 * character.c, character.h (count_size_as_multibyte):
6315 Rename from parse_str_to_multibyte; all uses changed.
6316 Check for integer overflow.
6317 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6318 since it's now a duplicate of the other. This is more of
6319 a character than a buffer op, so better that it's in character.c.
6320 * fns.c, print.c: Adjust to above changes.
6322 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6324 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6326 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6328 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6329 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6330 (x_clipboard_manager_save): Now static.
6331 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6333 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6334 (crypto_hash_function): Now static.
6335 Fix pointer signedness problems. Avoid unnecessary initializations.
6337 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6339 * termhooks.h (Vselection_alist): Make it terminal-local.
6341 * terminal.c (create_terminal): Initialize it.
6343 * xselect.c: Support for clipboard managers.
6344 (Vselection_alist): Move to termhooks.h as terminal-local var.
6345 (LOCAL_SELECTION): New macro.
6346 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6347 (symbol_to_x_atom): Remove gratuitous arg.
6348 (x_handle_selection_request, lisp_data_to_selection_data)
6349 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6350 (x_own_selection, x_get_local_selection, x_convert_selection):
6351 New arg, specifying work frame. Use terminal-local Vselection_alist.
6352 (some_frame_on_display): Delete unused function.
6353 (Fx_own_selection_internal, Fx_get_selection_internal)
6354 (Fx_disown_selection_internal, Fx_selection_owner_p)
6355 (Fx_selection_exists_p): New optional frame arg.
6356 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6357 (x_handle_selection_clear): Don't treat other terminals with the
6358 same keyboard specially. Use the terminal-local Vselection_alist.
6359 (x_clear_frame_selections): Use Frun_hook_with_args.
6361 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6363 * xterm.h: Add support for those atoms.
6365 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6367 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6368 (converted_selections, conversion_fail_tag): New global variables.
6369 (x_selection_request_lisp_error): Free the above.
6370 (x_get_local_selection): Remove unnecessary code.
6371 (x_reply_selection_request): Args changed; handle arbitrary array
6372 of converted selections stored in converted_selections.
6373 Separate the XChangeProperty and SelectionNotify steps.
6374 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6375 (x_convert_selection): New function.
6376 (x_handle_selection_event): Simplify.
6377 (x_get_foreign_selection): Don't ignore incoming requests while
6378 waiting for an answer; this will fail when we implement
6379 SAVE_TARGETS, and seems unnecessary anyway.
6380 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6381 (Vx_sent_selection_functions): Doc fix.
6383 2011-05-26 Leo Liu <sdl.web@gmail.com>
6385 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6387 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6389 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6391 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6392 for fringe update if it has periodic bitmap.
6393 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6394 and fringe_bitmap_periodic_p.
6396 * fringe.c (get_fringe_bitmap_data): New function.
6397 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6398 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6399 row. Mark glyph row for fringe update if periodicity changed.
6401 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6402 for fringe update unless it has periodic bitmap.
6404 2011-05-25 Kenichi Handa <handa@m17n.org>
6406 * xdisp.c (get_next_display_element): Set correct it->face_id for
6407 a static composition.
6409 2011-05-24 Leo Liu <sdl.web@gmail.com>
6412 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6414 * fns.c (crypto_hash_function, Fsha1): New function.
6415 (Fmd5): Use crypto_hash_function.
6416 (syms_of_fns): Add Ssha1.
6418 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6420 * gnutls.c: Remove unused macros.
6421 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6422 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6423 Remove macros that are defined and never used.
6424 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6426 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6428 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6429 (Fx_get_selection_internal): Minor cleanup.
6430 (Fx_own_selection_internal): Rename arguments for consistency with
6433 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6435 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6437 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6439 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6441 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6443 * dispnew.c (scrolling_window): Don't exclude the case that the
6444 last enabled row in the desired matrix touches the bottom boundary.
6446 2011-05-21 Glenn Morris <rgm@gnu.org>
6448 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6449 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6450 and add some more files.
6452 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6454 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6455 report_file_error introduced by the change from 2011-05-07.
6457 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6459 * systime.h (Time): Define only if emacs is defined.
6460 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6461 where the include path doesn't have X11/X.h by default. See
6462 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6464 2011-05-20 Kenichi Handa <handa@m17n.org>
6466 * composite.c (find_automatic_composition): Fix previous change.
6468 2011-05-20 Glenn Morris <rgm@gnu.org>
6470 * lisp.mk: New file, split from Makefile.in.
6471 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6472 (shortlisp): Remove.
6473 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6475 2011-05-19 Glenn Morris <rgm@gnu.org>
6477 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6478 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6479 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6480 (lisp): Set the order to that of loadup.el.
6481 (shortlisp): Make it a copy of $lisp.
6482 (SOME_MACHINE_LISP): Remove.
6483 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6484 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6486 2011-05-18 Kenichi Handa <handa@m17n.org>
6488 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6489 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6490 (find_automatic_composition): Mostly rewrite for efficiency.
6492 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6494 * makefile.w32-in: Update dependencies.
6496 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6498 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6499 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6501 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6503 Fix some integer overflow issues, such as string length overflow.
6505 * insdel.c (count_size_as_multibyte): Check for string overflow.
6507 * character.c (lisp_string_width): Check for string overflow.
6508 Use EMACS_INT, not int, for string indexes and lengths; in
6509 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6510 the resulting string length overflows an EMACS_INT; instead,
6511 report a string overflow if no precision given. When checking for
6512 precision exhaustion, use a check that cannot possibly have
6513 integer overflow. (Bug#8675)
6514 * character.h (lisp_string_width): Adjust to new signature.
6516 * alloc.c (string_overflow): New function.
6517 (Fmake_string): Use it. This doesn't change behavior, but saves
6518 a few bytes and will simplify future changes.
6519 * character.c (string_escape_byte8): Likewise.
6520 * lisp.h (string_overflow): New decl.
6522 Fixups, following up to the user-interface timestamp change.
6523 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6524 for UI timestamps, instead of unsigned long.
6525 * msdos.c (mouse_get_pos): Likewise.
6526 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6527 * w32gui.h (Time): Define by including "systime.h" rather than by
6528 declaring it ourselves. (Bug#8664)
6530 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6531 * image.c (clear_image_cache): Likewise.
6533 * term.c (term_mouse_position): Don't assume time_t wraparound.
6535 Be more systematic about user-interface timestamps.
6536 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6537 and sometimes 'EMACS_UINT', to represent these timestamps.
6538 This change causes it to use 'Time' uniformly, as that's what X uses.
6539 This makes the code easier to follow, and makes it easier to catch
6540 integer overflow bugs such as Bug#8664.
6541 * frame.c (Fmouse_position, Fmouse_pixel_position):
6542 Use Time, not unsigned long, for user-interface timestamps.
6543 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6544 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6545 * keyboard.h (last_event_timestamp): Likewise.
6546 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6547 * menu.h (xmenu_show): Likewise.
6548 * term.c (term_mouse_position): Likewise.
6549 * termhooks.h (struct input_event.timestamp): Likewise.
6550 (struct terminal.mouse_position_hook): Likewise.
6551 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6552 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6553 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6554 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6556 * menu.h, termhooks.h: Include "systime.h", for Time.
6558 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6559 Don't assume that the difference between two unsigned long values
6560 can fit into an integer. At this point, we know button_down_time
6561 <= event->timestamp, so the difference must be nonnegative, so
6562 there's no need to cast the result if double-click-time is
6563 nonnegative, as it should be; check that it's nonnegative, just in
6564 case. This bug is triggered when events are more than 2**31 ms
6565 apart (about 25 days). (Bug#8664)
6567 * xselect.c (last_event_timestamp): Remove duplicate decl.
6568 (x_own_selection): Remove needless cast to unsigned long.
6570 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6571 that always fit in int. Use a sentinel instead of a counter, to
6572 avoid a temp and to allay GCC's concerns about possible int overflow.
6573 * frame.h (struct frame): Use int for menu_bar_items_used
6574 instead of EMACS_INT, since it always fits in int.
6576 * menu.c (grow_menu_items): Check for int overflow.
6578 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6580 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6581 Before, the code was not consistent. These values cannot exceed
6582 2**31 - 1 so there's no need to make them unsigned.
6583 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6584 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6585 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6587 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6589 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6590 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6591 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6592 presumably because the widths might not match.
6594 * window.c (size_window): Avoid needless test at loop start.
6596 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6598 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6600 2011-05-12 Drew Adams <drew.adams@oracle.com>
6602 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6604 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6606 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6607 `width' to `bar_area_x' and `bar_area_width', respectively.
6608 (x_scroll_run): Take account of fringe background extension.
6610 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6611 Rename local vars `left' and `width' to `bar_area_x' and
6612 `bar_area_width', respectively.
6613 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6614 background extension.
6616 2011-05-10 Jim Meyering <meyering@redhat.com>
6618 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6620 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6622 * image.c (Finit_image_library): Return t for built-in image types,
6623 like pbm and xbm. (Bug#8640)
6625 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6627 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6629 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6631 * w32console.c (Fset_screen_color): Doc fix.
6632 (Fget_screen_color): New function.
6633 (syms_of_ntterm): Defsubr it.
6635 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6636 unlink the temporary file if Fcall_process didn't create it in the
6638 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6639 child process will be redirected to a file specified with `:file'.
6640 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6641 cue to call_process_cleanup not to close that handle.
6643 2011-05-07 Ben Key <bkey76@gmail.com>
6645 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6646 one of two shell specific rules, either bootstrap-temacs-CMD or
6647 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6648 to the previous implementation of the bootstrap-temacs rule.
6649 The bootstrap-temacs-CMD rule is similar to the previous
6650 implementation of the bootstrap-temacs rule except that it
6651 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6654 These changes, along with some changes to nt/configure.bat,
6655 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6656 earlier fix to add support for --cflags and --ldflags options
6657 that include quotes so that it works whether make uses cmd or
6660 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6662 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6663 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6665 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6666 a string. Handle both cases.
6667 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6668 (Fdbus_register_method): Use Qinvalid_function.
6670 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6672 * makefile.w32-in: Update dependencies.
6673 (LISP_H): Add inttypes.h and stdin.h.
6674 (PROCESS_H): Add unistd.h.
6676 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6678 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6679 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6681 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6683 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6685 * term.c (vfatal): Remove stray call to va_end.
6686 It's not needed and the C Standard doesn't allow it here anyway.
6688 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6689 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6691 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6694 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6696 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6698 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6700 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6702 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6704 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6705 * charset.c (Fdefine_charset_internal): Don't initialize
6706 charset.code_space[15]. The value was garbage, on hosts with
6707 32-bit int (Bug#8600).
6709 * lread.c (read_integer): Be more consistent with string-to-number.
6710 Use string_to_number to do the actual conversion; this avoids
6711 rounding errors and fixes some other screwups. Without this fix,
6712 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6713 (digit_to_number): Move earlier, for benefit of read_integer.
6714 Return -1 if the digit is out of range for the base, -2 if it is
6715 not a digit in any supported base. (Bug#8602)
6717 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6719 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6720 to match comment at start of function. This also removes a
6721 GCC warning about overflow in a 32+64-bit port.
6723 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6725 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6726 Reported by Stefan Monnier in
6727 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6728 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6729 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6731 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6732 (EMACS_UINTPTR): Likewise, with uintptr_t.
6734 * lisp.h: Prefer 64-bit EMACS_INT if available.
6735 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6736 on 32-bit hosts that have 64-bit int, so that they can access
6738 However, temporarily disable this change unless the temporary
6739 symbol WIDE_EMACS_INT is defined.
6741 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6743 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6744 This removes an assumption that EMACS_INT and long are the same
6745 width as pointers. The assumption is true for Emacs porting targets
6746 now, but we want to make other targets possible.
6747 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6748 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6749 In the rest of the code, change types of integers that hold casted
6750 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6751 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6752 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6753 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6754 No need to cast type when ORing.
6755 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6756 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6757 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6758 assume EMACS_INT is the same width as char *.
6759 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6760 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6761 Remove no-longer-needed casts.
6762 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6763 (xg_tool_bar_help_callback, xg_make_tool_item):
6764 Use EMACS_INTPTR to hold an integer
6765 that will be cast to void *; this can avoid a GCC warning
6766 if EMACS_INT is not the same width as void *.
6767 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6768 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6769 (current_message_1, set_message_1):
6770 Use a local to convert to proper width without a cast.
6771 * xmenu.c (dialog_selection_callback): Likewise.
6773 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6774 Also, don't assume VALBITS / RAND_BITS is less than 5,
6775 and don't rely on undefined behavior when shifting a 1 left into
6777 * lisp.h (get_random): Change signature to match.
6779 * lread.c (hash_string): Use size_t, not int, for hash computation.
6780 Normally we prefer signed values; but hashing is special, because
6781 it's better to use unsigned division on hash table sizes so that
6782 the remainder is nonnegative. Also, size_t is the natural width
6783 for hashing into memory. The previous code used 'int', which doesn't
6784 retain enough info to hash well into very large tables.
6785 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6787 * dbusbind.c: Don't possibly lose pointer info when converting.
6788 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6789 Use XPNTR rather than XHASH, so that the high-order bits of
6790 the pointer aren't lost when converting through void *.
6792 * eval.c (Fautoload): Don't double-shift a pointer.
6794 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6796 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6798 * gnutls.c (DEF_GNUTLS_FN):
6799 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6801 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6803 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6806 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6808 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6809 New version that can reserve upto 2GB of heap space.
6811 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6813 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6815 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6817 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6818 `gnutls_certificate_set_x509_key_file'.
6820 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6822 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6823 Update dependencies.
6825 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6827 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6828 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6829 Remove unused parameter `fildes'.
6830 * process.c (read_process_output, send_process): Don't pass it.
6832 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6834 Fix previous change: the library cache is defined in w32.c.
6835 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6836 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6838 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6840 Implement dynamic loading of GnuTLS on Windows.
6842 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6843 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6844 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6847 * gnutls.c (Qgnutls_dll): Define.
6848 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6849 (gnutls_*): Declare function pointers.
6850 (init_gnutls_functions): New function to initialize function pointers.
6851 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6852 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6853 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6854 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6855 (emacs_gnutls_write, emacs_gnutls_read)
6856 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6857 (Fgnutls_available_p): New function.
6858 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6859 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6860 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6862 * image.c: Include w32.h.
6863 (Vimage_type_cache): Delete.
6864 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6865 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6866 (w32_delayed_load): Move to w32.c.
6868 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6870 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6871 (w32_delayed_load): Move from image.c. When loading a library, record
6872 its filename in the :loaded-from property of the library id.
6873 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6874 Initialize and staticpro them.
6875 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6877 * process.c: Include lisp.h before w32.h, not after.
6878 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6879 instead of gnutls_record_check_pending.
6881 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6883 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6885 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6886 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6889 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6891 * xterm.c (x_set_frame_alpha): Do not set property on anything
6892 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6894 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6896 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6898 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6900 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6901 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6902 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6903 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6904 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6905 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6906 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6907 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6908 (Qgnutls_bootprop_callbacks_verify): Make static.
6910 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6912 * callproc.c: Indentation fixup.
6914 * sysdep.c (wait_for_termination_1): Make static.
6915 (wait_for_termination, interruptible_wait_for_termination):
6916 Move after wait_for_termination_1.
6918 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6920 * sysdep.c (interruptible_wait_for_termination): New function
6921 which is like wait_for_termination, but allows keyboard
6924 * callproc.c (Fcall_process): Add (:file "file") as an option for
6926 (Fcall_process_region): Ditto.
6928 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6930 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6931 rather than `XVECTOR (FOO)->size'.
6933 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6934 inttypes.h, as a gnulib replacement is used if it not available in
6937 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6939 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6940 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6941 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6943 * coding.c (coding_alloc_by_realloc): Error out if destination
6944 will grow beyond MOST_POSITIVE_FIXNUM.
6945 (decode_coding_emacs_mule): Abort if there isn't enough place in
6946 charbuf for the composition carryover bytes. Reserve an extra
6947 space for up to 2 characters produced in a loop.
6948 (decode_coding_iso_2022): Abort if there isn't enough place in
6949 charbuf for the composition carryover bytes.
6951 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6953 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6954 aborting when %lld or %lll format is passed.
6955 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6956 %llo or %llx format is passed. (Bug#8545)
6958 * window.c (window_scroll_line_based): Use a marker instead of
6959 simple variables to record original value of point. (Bug#7952)
6961 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6962 produced by %s or %c overflows available buffer space. (Bug#8545)
6964 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6966 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6967 (SIZE_MAX): Move defn after all includes, as they might #define it.
6969 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6971 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6973 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6975 * keyboard.c (Qdelayed_warnings_hook): Define.
6976 (command_loop_1): Run `delayed-warnings-hook'
6977 if Vdelayed_warnings_list is non-nil.
6978 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6979 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6981 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6983 * doprnt.c (doprnt): Don't return value smaller than the buffer
6984 size if the message was truncated. (Bug#8545).
6986 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6988 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6989 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6991 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6993 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6995 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6997 * makefile.w32-in: Update dependencies.
6999 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7001 Improve `doprnt' and its usage. (Bug#8545)
7002 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7003 `format_end'. Remove support for %l as a conversion specifier.
7004 Don't use xrealloc. Improve diagnostics when the %l size modifier
7005 is used. Update the commentary.
7007 * eval.c (verror): Simplify calculation of size_t.
7009 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7012 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7014 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7017 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7019 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7020 This makes this file independent of the recent pseudovector change.
7022 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7024 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7026 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7027 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7028 Remove unused local.
7029 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7031 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7032 GCC 4.6.0 optimizes based on type-based alias analysis.
7033 For example, if b is of type struct buffer * and v of type struct
7034 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7035 != &v->size, and therefore "v->size = 1; b->size = 2; return
7036 v->size;" must therefore return 1. This assumption is incorrect
7037 for Emacs, since it type-puns struct Lisp_Vector * with many other
7038 types. To fix this problem, this patch adds a new type struct
7039 vectorlike_header that documents the constraints on layout of vectors
7040 and pseudovectors, and helps optimizing compilers not get fooled
7041 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7042 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7043 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7045 (XSETPVECTYPE): Rewrite in terms of new macro.
7046 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7047 This is a bit clearer, and further avoids the possibility of
7048 undesirable aliasing.
7049 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7050 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7051 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7052 since Lisp_Subr is a special case (no "next" field).
7053 (ASIZE): Now uses header.size rather than size.
7054 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7055 to avoid the hassle of writing XVECTOR (foo)->header.size.
7056 (struct vectorlike_header): New type.
7057 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7058 object, to help avoid aliasing.
7059 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7060 (SUBRP): Likewise, since Lisp_Subr is a special case.
7061 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7062 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7063 (struct Lisp_Hash_Table): Combine first two members into a single
7064 struct vectorlike_header member. All uses of "size" and "next" members
7065 changed to be "header.size" and "header.next".
7066 * buffer.h (struct buffer): Likewise.
7067 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7068 * frame.h (struct frame): Likewise.
7069 * process.h (struct Lisp_Process): Likewise.
7070 * termhooks.h (struct terminal): Likewise.
7071 * window.c (struct save_window_data, struct saved_window): Likewise.
7072 * window.h (struct window): Likewise.
7073 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7074 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7075 * buffer.c (init_buffer_once): Likewise.
7076 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7078 * process.c (Fformat_network_address): Use local var for size,
7081 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7083 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7084 * data.c (atof): Remove decl; no longer used or needed.
7085 (digit_to_number): Move to lread.c.
7086 (Fstring_to_number): Use new string_to_number function, to be
7087 consistent with how the Lisp reader treats infinities and NaNs.
7088 Do not assume that floating-point numbers represent EMACS_INT
7089 without losing information; this is not true on most 64-bit hosts.
7090 Avoid double-rounding errors, by insisting on integers when
7091 parsing non-base-10 numbers, as the documentation specifies.
7092 * lisp.h (string_to_number): New decl, replacing ...
7093 (isfloat_string): Remove.
7094 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7095 (read1): Do not accept +. and -. as integers; this
7096 appears to have been a coding error. Similarly, do not accept
7097 strings like +-1e0 as floating point numbers. Do not report
7098 overflow for integer overflows unless the base is not 10 which
7099 means we have no simple and reliable way to continue.
7100 Break out the floating-point parsing into a new
7101 function string_to_number, so that Fstring_to_number parses
7102 floating point numbers consistently with the Lisp reader.
7103 (digit_to_number): Move here from data.c. Make it static inline.
7104 (E_CHAR, EXP_INT): Remove, replacing with ...
7105 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7106 (string_to_number): New function, replacing isfloat_string.
7107 This function checks for valid syntax and produces the resulting
7108 Lisp float number too. Rework it so that string-to-number
7109 no longer mishandles examples like "1.0e+". Use strtoumax,
7110 so that overflow for non-base-10 numbers is reported only when
7111 there's no portable and simple way to convert to floating point.
7113 * textprop.c (set_text_properties_1): Rewrite for clarity,
7114 and to avoid GCC warning about integer overflow.
7116 * intervals.h (struct interval): Use EMACS_INT for members
7117 where EMACS_UINT might cause problems. See
7118 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7119 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7120 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7122 (offset_intervals): Tell GCC not to worry about length overflow
7123 when negating a negative length.
7125 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7126 (overrun_check_free): Likewise.
7128 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7129 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7132 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7133 (gnutls_make_error): Rename local to avoid shadowing.
7134 (gnutls_emacs_global_deinit): ifdef out; not used.
7135 (Fgnutls_boot): Use const for pointer to readonly storage.
7136 Comment out unused local. Fix pointer signedness problems.
7138 * lread.c (openp): Don't stuff size_t into an 'int'.
7139 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7140 about possible signed overflow.
7142 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7143 (GDK_KEY_g): Don't define if already defined.
7144 (xg_prepare_tooltip): Avoid pointer signedness problem.
7145 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7147 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7148 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7150 * xfns.c (Fx_window_property): Simplify a bit,
7151 to make a bit faster and to avoid GCC 4.6.0 warning.
7152 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7154 * fns.c (internal_equal): Don't assume size_t fits in int.
7156 * alloc.c (compact_small_strings): Tighten assertion a little.
7158 Replace pEd with more-general pI, and fix some printf arg casts.
7159 * lisp.h (pI): New macro, generalizing old pEd macro to other
7160 conversion specifiers. For example, use "...%"pI"d..." rather
7161 than "...%"pEd"...".
7162 (pEd): Remove. All uses replaced with similar uses of pI.
7163 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7164 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7165 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7166 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7167 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7168 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7169 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7171 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7172 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7173 * print.c (safe_debug_print, print_object): Likewise.
7174 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7176 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7177 avoiding the 0 flag, which is not portable.
7178 * process.c (Fmake_network_process): Use pI to avoid cast.
7179 * region-cache.c (pp_cache): Likewise.
7180 * xdisp.c (decode_mode_spec): Likewise.
7181 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7182 behavior on 64-bit hosts with printf arg.
7183 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7184 (x_stop_queuing_selection_requests): Likewise.
7185 (x_get_window_property): Don't truncate byte count to an 'int'
7188 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7189 here, since it parses constructs like leading '-' and spaces,
7190 which are not wanted; and it overflows with large numbers.
7191 Instead, simply match F[0-9]+, which is what is wanted anyway.
7193 * alloc.c: Remove unportable assumptions about struct layout.
7194 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7195 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7196 (allocate_vectorlike, make_pure_vector): Use the new macros,
7197 plus offsetof, to remove unportable assumptions about struct layout.
7198 These assumptions hold on all porting targets that I know of, but
7199 they are not guaranteed, they're easy to remove, and removing them
7200 makes further changes easier.
7202 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7203 This doesn't fix a bug but makes the code clearer.
7204 (string_overrun_cookie): Now const. Use initializers that
7205 don't formally overflow signed char, to avoid warnings.
7206 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7207 can cause Emacs to crash when string overrun checking is enabled.
7208 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7209 multiple of sizeof (EMACS_INT); it need not be, if
7210 alignof(EMACS_INT) < sizeof (EMACS_INT).
7211 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7213 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7215 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7217 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7219 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7220 supposed to be handshaking. (Bug#8556)
7221 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7223 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7225 * lisp.h (Qdebug): List symbol.
7226 * eval.c (Qdebug): Restore global linkage.
7227 * keyboard.c (debug-on-event): New variable.
7228 (handle_user_signal): Break into debugger when debug-on-event
7229 matches the current signal symbol.
7231 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7233 * alloc.c (check_sblock, check_string_bytes)
7234 (check_string_free_list): Convert to standard C.
7236 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7238 * w32.c (emacs_gnutls_push): Fix typo.
7240 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7242 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7243 "cast to pointer from integer of different size".
7245 Improve doprnt and its use in verror. (Bug#8545)
7246 * doprnt.c (doprnt): Document the set of format control sequences
7247 supported by the function. Use SAFE_ALLOCA instead of always
7250 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7251 is one byte too soon. Don't use xrealloc; instead xfree and
7254 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7256 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7259 * gnutls.c: Renamed global_initialized to
7260 gnutls_global_initialized. Added internals for the
7261 :verify-hostname-error, :verify-error, and :verify-flags
7262 parameters of `gnutls-boot' and documented those parameters in the
7263 docstring. Start callback support.
7264 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7265 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7266 on error. Return error code.
7267 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7268 (emacs_gnutls_read): Likewise.
7269 (Fgnutls_boot): Return handshake error code.
7270 (emacs_gnutls_handle_error): New function.
7271 (wsaerror_to_errno): Likewise.
7273 * w32.h (emacs_gnutls_pull): Add prototype.
7274 (emacs_gnutls_push): Likewise.
7276 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7277 (emacs_gnutls_push): Likewise.
7279 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7281 * process.c (wait_reading_process_output): Check if GnuTLS
7282 buffered some data internally if no FDs are set for TLS
7285 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7286 (LIBS): Link to USER_LIBS.
7287 ($(BLD)/gnutls.$(0)): New target.
7289 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7291 * xdisp.c (handle_single_display_spec): Rename the
7292 display_replaced_before_p argument into display_replaced_p, to
7293 make it consistent with the commentary. Fix typos in the
7296 * textprop.c (syms_of_textprop): Remove dead code.
7297 (copy_text_properties): Delete obsolete commentary about an
7298 interface that was deleted long ago. Fix typos in the description
7301 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7302 to changes in oldXMenu/XMenu.h from 2011-04-16.
7303 <menu_help_message, prev_menu_help_message>: Constify.
7304 (IT_menu_make_room): menu->help_text is now `const char **';
7307 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7308 to changes in oldXMenu/XMenu.h from 2011-04-16.
7309 (struct XMenu): Declare `help_text' `const char **'.
7311 * xfaces.c <Qunspecified>: Make extern again.
7313 * syntax.c: Include sys/types.h before including regex.h, as
7316 * doc.c (get_doc_string): Improve the format passed to `error'.
7318 * doprnt.c (doprnt): Improve commentary.
7320 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7322 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7325 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7326 changes in globals.h immediately force recompilation.
7327 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7328 $(CURDIR)/s/ms-w32.h.
7329 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7331 * character.c (Fchar_direction): Function deleted.
7332 (syms_of_character): Don't defsubr it.
7333 <char-direction-table>: Deleted.
7335 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7337 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7338 * doprnt.c: Include limits.h.
7339 (SIZE_MAX): New macro.
7340 (doprnt): Return a size_t value. 2nd arg is now size_t.
7341 Many local variables are now size_t instead of int or unsigned.
7342 Improve overflow protection. Support `l' modifier for integer
7343 conversions. Support %l conversion. Don't assume an EMACS_INT
7344 argument for integer conversions and for %c.
7346 * lisp.h (doprnt): Restore prototype.
7348 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7351 * Makefile.in (base_obj): Add back doprnt.o.
7353 * deps.mk (doprnt.o): Add back prerequisites.
7354 (callint.o): Depend on character.h.
7356 * eval.c (internal_lisp_condition_case): Include the handler
7357 representation in the error message.
7358 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7359 when breaking from the loop.
7361 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7363 * callint.c (Fcall_interactively): When displaying error message
7364 about invalid control letter, pass the character's codepoint, not
7365 a pointer to its multibyte form. Improve display of the character
7366 in octal and display also its hex code.
7368 * character.c (char_string): Use %x to display the (unsigned)
7369 codepoint of an invalid character, to avoid displaying a bogus
7372 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7373 `error', not SYMBOL_NAME itself.
7375 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7376 character arguments to `error'.
7378 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7379 to `error' in error message about FINAL_CHAR argument. Make sure
7380 FINAL_CHAR is a character, and use %c when it is passed as
7381 argument to `error'.
7383 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7385 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7387 * w32.c: Include <time.h>.
7388 (sys_localtime): New function.
7390 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7392 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7394 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7396 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7398 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7401 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7403 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7404 gl_state.e_property when gl_state.object is Qt.
7406 * insdel.c (make_gap_larger): Remove limitation of buffer size
7409 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7411 * xdisp.c (lookup_glyphless_char_display)
7412 (produce_glyphless_glyph): Handle cons cell entry in
7413 glyphless-char-display.
7414 (Vglyphless_char_display): Document it.
7416 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7417 glyphless-char-display.
7419 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7421 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7423 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7425 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7426 definition for no-X builds.
7428 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7430 Static checks with GCC 4.6.0 and non-default toolkits.
7432 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7434 * process.c (keyboard_bit_set): Define only if SIGIO.
7435 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7436 (send_process): Repair possible setjmp clobbering.
7438 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7440 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7442 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7444 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7445 Define only if needed.
7447 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7448 by pacifying GCC about it. Maybe it's time to retire it?
7449 * xfaces.c (USG, __TIMEVAL__): Likewise.
7451 * dispextern.h (struct redisplay_interface): Rename param
7453 * termhooks.h (struct terminal): Likewise.
7454 * xterm.c (xembed_send_message): Likewise.
7456 * insdel.c (make_gap_smaller): Define only if
7457 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7459 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7462 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7463 so that we aren't warned about unused symbols.
7465 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7467 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7469 * xfns.c (x_real_positions): Mark locals as initialized.
7471 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7473 * xterm.c: Fix problems found by static analysis with other toolkits.
7474 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7475 (x_dispatch_event): Declare static if USE_GTK, and
7476 define if USE_GTK || USE_X_TOOLKIT.
7477 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7478 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7479 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7480 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7482 * xmenu.c (menu_help_callback): Pointer type fixes.
7483 Use const pointers when pointing at readonly data. Avoid pointer
7485 (FALSE): Remove unused macro.
7486 (update_frame_menubar): Remove unused decl.
7488 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7490 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7491 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7492 (single_menu_item): Rename local to avoid shadowing.
7494 * keyboard.c (make_lispy_event): Remove unused local var.
7496 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7497 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7499 * bitmaps: Change bitmaps from unsigned char back to the X11
7500 compatible char. Avoid the old compiler warnings about
7501 out-of-range initializers by using, for example, '\xab' rather
7504 * xgselect.c (xgselect_initialize): Check vs interface
7505 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7507 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7509 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7510 to read-only memory.
7512 * fns.c (vector): Remove; this old hack is no longer needed.
7514 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7516 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7518 * xrdb.c (x_load_resources): Omit unused local.
7520 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7521 (x_window): Rename locals to avoid shadowing.
7522 (USG): Use the kludged USG macro, to pacify gcc.
7524 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7525 (x_term_init): Remove local to avoid shadowing.
7527 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7529 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7530 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7532 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7534 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7536 Fix regex.c, syntax.c and friends for buffers > 2GB.
7537 * syntax.h (struct gl_state_s): Declare character position members
7540 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7542 * textprop.c (verify_interval_modification, interval_of):
7543 Declare arguments EMACS_INT.
7545 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7548 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7550 * indent.c (Fvertical_motion): Local variable it_start is now
7553 * regex.c (re_match, re_match_2, re_match_2_internal)
7554 (bcmp_translate, regcomp, regexec, print_double_string)
7555 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7556 (re_compile_pattern, re_exec): Declare arguments and local
7557 variables `size_t' and `ssize_t' and return values `regoff_t', as
7559 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7560 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7561 <compile_stack_type>: `size' and `avail' are now `size_t'.
7563 * regex.h <regoff_t>: Use ssize_t, not int.
7564 (re_search, re_search_2, re_match, re_match_2): Arguments that
7565 specify buffer/string position and length are now ssize_t and
7566 size_t. Return type is regoff_t.
7568 2011-04-16 Ben Key <bkey76@gmail.com>
7570 * nsfont.m: Fixed bugs in ns_get_family and
7571 ns_descriptor_to_entity that were caused by using free to
7572 deallocate memory blocks that were allocated by xmalloc (via
7573 xstrdup). This caused Emacs to crash when compiled with
7574 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7575 --enable-checking=xmallocoverrun). xfree is now used to
7576 deallocate these memory blocks.
7578 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7580 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7582 emacs_write: Accept and return EMACS_INT for sizes.
7583 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7585 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7586 Accept and return EMACS_INT.
7587 (emacs_gnutls_write): Return the number of bytes written on
7589 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7590 (emacs_read, emacs_write): Remove check for negative size, as the
7591 Emacs source code has been audited now.
7592 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7593 (emacs_read, emacs_write): Use it.
7594 * process.c (send_process): Adjust to the new signatures of
7595 emacs_write and emacs_gnutls_write. Do not attempt to store
7596 a byte offset into an 'int'; it might overflow.
7597 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7599 * sound.c: Don't assume sizes fit in 'int'.
7600 (struct sound_device.period_size, alsa_period_size):
7601 Return EMACS_INT, not int.
7602 (struct sound_device.write, vox_write, alsa_write):
7603 Accept EMACS_INT, not int.
7604 (wav_play, au_play): Use EMACS_INT to store sizes and to
7605 record read return values.
7607 2011-04-15 Ben Key <bkey76@gmail.com>
7609 * keyboard.c (Qundefined): Don't declare static since it is used
7611 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7612 static since they are used in nsfont.m.
7614 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7616 * process.c (Qprocessp): Don't declare static.
7617 * lisp.h (Qprocessp): Declare again.
7619 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7621 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7623 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7625 Improve C-level modularity by making more things 'static'.
7627 Don't publish debugger-only interfaces to other modules.
7628 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7629 (verify_bytepos, count_markers): Move decls to the only modules
7631 * region-cache.h (pp_cache): Likewise.
7632 * window.h (check_all_windows): Likewise.
7633 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7635 * sysdep.c (croak): Now static, if
7636 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7637 * syssignal.h (croak): Declare only if not static.
7639 * alloc.c (refill_memory_reserve): Now static if
7640 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7641 * lisp.h (refill_memory_reserve): Declare only if not static.
7643 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7644 Define only if USE_LUCID.
7646 * xrdb.c (x_customization_string, x_rm_string): Now static.
7648 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7649 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7651 * xdisp.c (draw_row_with_mouse_face): Now static.
7652 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7654 * window.h (check_all_windows): Mark externally visible.
7656 * window.c (window_deletion_count): Now static.
7658 * undo.c: Make symbols static if they're not exported.
7659 (last_undo_buffer, last_boundary_position, pending_boundary):
7662 * textprop.c (interval_insert_behind_hooks): Now static.
7663 (interval_insert_in_front_hooks): Likewise.
7665 * term.c: Make symbols static if they're not exported.
7666 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7667 (max_frame_lines, tty_set_terminal_modes):
7668 (tty_reset_terminal_modes, tty_turn_off_highlight):
7669 (get_tty_terminal): Now static.
7670 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7671 * termhooks.h (term_mouse_moveto): Do not declare if
7673 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7674 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7676 * sysdep.c: Make symbols static if they're not exported.
7677 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7679 (sigprocmask_set, full_mask): Remove; unused.
7680 (wait_debugging): Mark as visible.
7681 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7682 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7684 * syntax.c (syntax_temp): Define only if !__GNUC__.
7686 * sound.c (current_sound_device, current_sound): Now static.
7688 * search.c (searchbufs, searchbuf_head): Now static.
7690 * scroll.c (scroll_cost): Remove; unused.
7691 * dispextern.h (scroll_cost): Remove decl.
7693 * region-cache.h (pp_cache): Mark as externally visible.
7695 * process.c: Make symbols static if they're not exported.
7696 (process_tick, update_tick, create_process, chan_process):
7697 (Vprocess_alist, proc_buffered_char, datagram_access):
7698 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7699 (deactivate_process): Mark defn as static, as well as decl.
7700 * lisp.h (create_process): Remove decl.
7701 * process.h (chan_process, Vprocess_alist): Remove decls.
7703 * print.c: Make symbols static if they're not exported.
7704 (print_depth, new_backquote_output, being_printed, print_buffer):
7705 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7706 (print_interval, print_number_index, initial_stderr_stream):
7708 * lisp.h (Fprinc): Remove decl.
7709 (debug_output_compilation_hack): Mark as externally visible.
7711 * sysdep.c (croak): Move decl from here to syssignal.h.
7712 * syssignal.h (croak): Put it here, so the API can be checked when
7713 'croak' is called from dissociate_if_controlling_tty.
7715 * minibuf.c: Make symbols static if they're not exported.
7716 (minibuf_save_list, choose_minibuf_frame): Now static.
7717 * lisp.h (choose_minibuf_frame): Remove decl.
7719 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7721 * lread.c: Make symbols static if they're not exported.
7722 (read_objects, initial_obarray, oblookup_last_bucket_number):
7724 (make_symbol): Remove; unused.
7725 * lisp.h (initial_obarray, make_symbol): Remove decls.
7727 * keyboard.c: Make symbols static if they're not exported.
7728 (single_kboard, recent_keys_index, total_keys, recent_keys):
7729 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7730 (this_single_command_key_start, echoing, last_auto_save):
7731 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7732 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7733 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7734 (Vlispy_mouse_stem, double_click_count):
7736 (force_auto_save_soon): Define only if SIGDANGER.
7737 (ignore_mouse_drag_p): Now static if
7738 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7739 (print_help): Remove; unused.
7740 (stop_character, last_timer_event): Mark as externally visible.
7741 * keyboard.h (ignore_mouse_drag_p): Declare only if
7742 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7743 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7744 * lisp.h (echoing): Remove decl.
7745 (force_auto_save_soon): Declare only if SIGDANGER.
7746 * xdisp.c (redisplay_window): Simplify code, to make it more
7747 obvious that ignore_mouse_drag_p is not accessed if !defined
7748 USE_GTK && !defined HAVE_NS.
7750 * intervals.c: Make symbols static if they're not exported.
7751 (merge_properties_sticky, merge_interval_right, delete_interval):
7753 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7755 * insdel.c: Make symbols static if they're not exported.
7756 However, leave prepare_to_modify_buffer alone. It's never
7757 called from outside this function, but that appears to be a bug.
7758 (combine_after_change_list, combine_after_change_buffer):
7759 (adjust_after_replace, signal_before_change): Now static.
7760 (adjust_after_replace_noundo): Remove; unused.
7761 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7762 (signal_before_change): Remove decls.
7764 * indent.c (val_compute_motion, val_vmotion): Now static.
7766 * image.c: Make symbols static if they're not exported.
7767 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7769 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7770 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7772 * fringe.c (standard_bitmaps): Now static.
7773 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7775 * frame.c: Make symbols static if they're not exported.
7776 (x_report_frame_params, make_terminal_frame): Now static.
7777 (get_frame_param): Now static, unless HAVE_NS.
7778 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7779 (x_get_resource_string): Remove; not used.
7780 * frame.h (make_terminal_frame, x_report_frame_params):
7781 (x_get_resource_string); Remove decls.
7782 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7783 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7785 * font.c, fontset.c: Make symbols static if they're not exported.
7786 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7787 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7788 * font.c (font_close_object): Now static.
7789 * font.h (font_close_object): Remove.
7790 * fontset.c (FONTSET_OBJLIST): Remove.
7791 (free_realized_fontset) #if-0 the body, which does nothing.
7792 (face_suitable_for_char_p): #if-0, as it's never called.
7793 * fontset.h (face_suitable_for_char_p): Remove decl.
7794 * xfaces.c (face_at_string_position):
7795 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7796 since 0 is always ASCII.
7798 * fns.c (weak_hash_tables): Now static.
7800 * fileio.c: Make symbols static if they're not exported.
7801 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7802 (Vwrite_region_annotation_buffers): Now static.
7804 * eval.c: Make symbols static if they're not exported.
7805 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7806 * lisp.h (backtrace_list): Remove decl.
7808 * emacs.c: Make symbols static if they're not exported.
7809 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7810 (fatal_error_code, fatal_error_signal_hook, standard_args):
7812 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7813 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7814 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7815 * lisp.h (fatal_error_signal_hook): Remove decl.
7816 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7818 * editfns.c: Move a (normally-unused) function to its only use.
7819 * editfns.c, lisp.h (get_operating_system_release): Remove.
7820 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7821 worth the hassle of breaking this out.
7823 * xterm.c: Make symbols static if they're not exported.
7824 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7825 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7826 (x_destroy_window, x_delete_display):
7828 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7829 (x_mouse_leave): Remove; unused.
7830 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7831 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7832 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7834 (x_mouse_leave): Declare only if WINDOWSNT.
7835 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7836 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7839 * ftxfont.c: Make symbols static if they're not exported.
7840 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7842 * font.h (ftxfont_driver): Likewise.
7844 * xfns.c: Make symbols static if they're not exported.
7845 (x_last_font_name, x_display_info_for_name):
7846 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7847 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7848 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7849 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7850 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7851 (last_show_tip_args): Now static.
7852 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7853 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7854 (x_screen_planes): Remove; unused.
7855 * dispextern.h (x_screen_planes): Remove decl.
7857 * dispnew.c: Make symbols static if they're not exported.
7858 * dispextern.h (redraw_garbaged_frames, scrolling):
7859 (increment_row_positions): Remove.
7860 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7861 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7863 (redraw_garbaged_frames): Remove; unused.
7865 * xfaces.c: Make symbols static if they're not exported.
7866 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7868 * xterm.h (defined_color): Remove decls.
7869 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7870 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7871 (menu_face_changed_default, defined_color, free_realized_face):
7872 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7873 (ascii_face_of_lisp_face): Remove; unused.
7875 * xdisp.c: Make symbols static if they're not exported.
7876 * dispextern.h (scratch_glyph_row, window_box_edges):
7877 (glyph_to_pixel_coords, set_cursor_from_row):
7878 (get_next_display_element, set_iterator_to_next):
7879 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7880 (show_mouse_face): Remove decls
7881 * frame.h (message_buf_print): Likewise.
7882 * lisp.h (pop_message, set_message, check_point_in_composition):
7884 * xterm.h (set_vertical_scroll_bar): Likewise.
7885 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7886 (message_buf_print, scratch_glyph_row, displayed_buffer):
7887 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7888 (get_next_display_element, show_mouse_face, window_box_edges):
7889 (frame_to_window_pixel_xy, check_point_in_composition):
7890 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7891 (glyph_to_pixel_coords): Remove; unused.
7893 * dired.c (file_name_completion): Now static.
7895 * dbusbind.c (xd_in_read_queued_messages): Now static.
7897 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7898 * data.c (circular_list_error): Remove.
7900 * commands.h (last_point_position, last_point_position_buffer):
7901 (last_point_position_window): Remove decls.
7902 * keyboard.c: Make these variables static.
7904 * coding.h (coding, code_convert_region, encode_coding_gap):
7906 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7907 (iso_code_class, detect_coding, code_convert_region): Now static.
7908 (encode_coding_gap): Remove; unused.
7910 * chartab.c (chartab_chars, chartab_bits): Now static.
7912 * charset.h (charset_iso_8859_1): Remove decl.
7913 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7916 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7917 * ccl.c (Vccl_program_table): Now static.
7918 (check_ccl_update): Remove; unused.
7920 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7921 * category.h: ... from here.
7922 * category.c (check_category_table, set_category_set): Now static.
7924 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7925 * lisp.h: Remove these decls.
7927 * buffer.c (buffer_count): Remove unused var.
7929 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7930 so that it's not optimized away.
7931 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7932 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7933 exported only to the debugger.
7935 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7936 * atimer.h (run_all_atimers): Remove; not exported.
7938 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7939 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7940 was inaccessible from Lisp.
7941 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7942 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7944 alloc.c: Import and export fewer symbols, and remove unused items.
7945 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7947 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7948 it's not optimized away by whole-program optimization.
7949 (message_enable_multibyte, free_misc): Remove.
7950 (catchlist, handlerlist, mark_backtrace):
7951 Declare only if BYTE_MARK_STACK.
7952 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7953 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7954 (message_enable_multibyte): Remove decl.
7955 (free_misc, interval_free_list, float_block, float_block_index):
7956 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7957 (cons_free_list, last_marked_index):
7959 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7960 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7961 (mark_backtrace): Define only if BYTE_MARK_STACK.
7962 * xdisp.c (message_enable_multibyte): Now static.
7964 Declare Lisp_Object Q* variables to be 'static' if not exported.
7965 This makes it easier for human readers (and static analyzers)
7966 to see whether these variables are used from other modules.
7967 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7968 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7969 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7970 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7971 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7972 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7973 * xmenu.c, xselect.c:
7974 Declare Q* vars static if they are not used in other modules.
7975 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7976 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7977 Remove decls of unexported vars.
7978 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7980 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7982 Make Emacs functions such as Fatom 'static' by default.
7983 This makes it easier for human readers (and static analyzers)
7984 to see whether these functions can be called from other modules.
7985 DEFUN now defines a static function. To make the function external
7986 so that it can be used in other C modules, use the new macro DEFUE.
7987 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7988 (Finit_image_library):
7989 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7990 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7991 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7992 Remove decls, since these functions are now static.
7993 (Funintern, Fget_internal_run_time): New decls, since these functions
7994 were already external.
7996 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7997 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7998 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7999 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8000 * keyboard.c, keymap.c, lread.c:
8001 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8002 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8003 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8004 Mark functions with DEFUE instead of DEFUN,
8005 if they are used in other modules.
8006 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8007 decls for now-static functions.
8008 * buffer.h (Fdelete_overlay): Remove decl.
8009 * callproc.c (Fgetenv_internal): Mark as internal.
8010 * composite.c (Fremove_list_of_text_properties): Remove decl.
8011 (Fcomposition_get_gstring): New forward static decl.
8012 * composite.h (Fcomposite_get_gstring): Remove decl.
8013 * dired.c (Ffile_attributes): New forward static decl.
8014 * doc.c (Fdocumntation_property): New forward static decl.
8015 * eval.c (Ffetch_bytecode): New forward static decl.
8016 (Funintern): Remove extern decl; now in .h file where it belongs.
8017 * fileio.c (Fmake_symbolic_link): New forward static decl.
8018 * image.c (Finit_image_library): New forward static decl.
8019 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8020 * intervals.h (Fprevious_property_change):
8021 (Fremove_list_of_text_properties): Remove decls.
8022 * keyboard.c (Fthis_command_keys): Remove decl.
8023 (Fcommand_execute): New forward static decl.
8024 * keymap.c (Flookup_key): New forward static decl.
8025 (Fcopy_keymap): Now static.
8026 * keymap.h (Flookup_key): Remove decl.
8027 * process.c (Fget_process): New forward static decl.
8028 (Fprocess_datagram_address): Mark as internal.
8029 * syntax.c (Fsyntax_table_p): New forward static decl.
8030 (skip_chars): Remove duplicate decl.
8031 * textprop.c (Fprevious_property_change): New forward static decl.
8032 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8034 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8035 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8037 * editfns.c (Fformat): Remove unreachable code.
8039 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8041 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8044 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8046 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8047 when at ZV. (Bug#8487)
8049 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8051 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8053 * keyboard.c (parse_tool_bar_item): Likewise.
8054 * sound.c (sound_cleanup, alsa_close): Likewise.
8055 * termcap.c (tgetent): Likewise.
8056 * xfns.c (x_default_font_parameter): Likewise.
8057 * xsettings.c (read_and_apply_settings): Likewise.
8059 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8060 (overrun_check_free): Protoize.
8062 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8064 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8065 since callers should never pass a negative size.
8066 Change the signature to match that of plain 'read' and 'write'; see
8067 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8068 * lisp.h: Update prototypes of emacs_write and emacs_read.
8070 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8072 * xdisp.c (redisplay_window): Don't try to determine the character
8073 position of the scroll margin if the window start point w->startp
8074 is outside the buffer's accessible region. (Bug#8468)
8076 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8078 Fix write-region and its subroutines for buffers > 2GB.
8079 * fileio.c (a_write, e_write): Modify declaration of arguments and
8080 local variables to support buffers larger than 2GB.
8081 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8083 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8084 argument, local variables, and return value.
8086 * lisp.h: Update prototypes of emacs_write and emacs_read.
8088 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8090 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8092 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8094 Fix more problems found by GCC 4.6.0's static checks.
8096 * xdisp.c (vmessage): Use a better test for character truncation.
8098 * charset.c (load_charset_map): <, not <=, for optimization,
8099 and to avoid potential problems with integer overflow.
8100 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8101 * casetab.c (set_identity, shuffle): Likewise.
8102 * editfns.c (Fformat): Likewise.
8103 * syntax.c (skip_chars): Likewise.
8105 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8106 This also lets GCC 4.6.0 generate slightly better loop code.
8108 * callint.c (Fcall_interactively): <, not <=, for optimization.
8109 (Fcall_interactively): Count the number of arguments produced,
8110 not the number of arguments given. This is simpler and lets GCC
8111 4.6.0 generate slightly better code.
8113 * ftfont.c: Distingish more carefully between FcChar8 and char.
8114 The previous code passed unsigned char * to a functions like
8115 strlen and xstrcasecmp that expect char *, which does not
8116 conform to the C standard.
8117 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8118 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8119 char * when the C standard requires it.
8121 * keyboard.c (read_char): Remove unused var.
8123 * eval.c: Port to Windows vsnprintf (Bug#8435).
8125 (SIZE_MAX): Define if the headers do not.
8126 (verror): Do not give up if vsnprintf returns a negative count.
8127 Instead, grow the buffer. This ports to Windows vsnprintf, which
8128 does not conform to C99. Problem reported by Eli Zaretskii.
8129 Also, simplify the allocation scheme, by avoiding the need for
8130 calling realloc, and removing the ALLOCATED variable.
8132 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8134 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8135 But keep the doprint source code for now, as we might revamp it
8136 and use it again (Bug#8435).
8137 * lisp.h (doprnt): Remove.
8138 * Makefile.in (base_obj): Remove doprnt.o.
8139 * deps.mk (doprnt.o): Remove.
8141 error: Print 32- and 64-bit integers portably (Bug#8435).
8142 Without this change, on typical 64-bit hosts error ("...%d...", N)
8143 was used to print both 32- and 64-bit integers N, which relied on
8145 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8146 * lisp.h (error, verror): Mark as printf-like functions.
8147 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8148 Report overflow in size calculations when allocating printf buffer.
8149 Do not truncate output string at its first null byte.
8150 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8151 Truncate the output at a character boundary, since vsnprintf does not
8153 * charset.c (check_iso_charset_parameter): Convert internal
8154 character to string before calling 'error', since %c now has the
8156 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8157 overflow when computing char to be passed to 'error'. Do not
8158 pass Lisp_Object to 'error'; pass the integer instead.
8159 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8160 formatted with plain %d.
8162 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8164 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8166 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8168 * xterm.c (x_catch_errors): Remove duplicate declaration.
8170 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8172 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8174 2011-04-10 Jim Meyering <meyering@redhat.com>
8176 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8177 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8178 return ssize_t not "int", and use size_t as the buffer length.
8179 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8180 * gnutls.h: Update declarations.
8181 * process.c (read_process_output): Use ssize_t, to match.
8182 (send_process): Likewise.
8184 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8186 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8188 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8190 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8191 Use unsigned char, to match FcChar8 type definition.
8193 * xterm.c (handle_one_xevent):
8194 * xmenu.c (create_and_show_popup_menu):
8195 * xselect.c (x_decline_selection_request)
8196 (x_reply_selection_request): Avoid type-punned deref of X events.
8198 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8200 Fix some uses of `int' instead of EMACS_INT.
8201 * search.c (string_match_1, fast_string_match)
8202 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8203 (scan_buffer, find_next_newline_no_quit)
8204 (find_before_next_newline, search_command, Freplace_match)
8205 (Fmatch_data): Make some `int' variables be EMACS_INT.
8207 * xdisp.c (display_count_lines): 3rd argument and return value now
8208 EMACS_INT. All callers changed.
8209 (pint2hrstr): Last argument is now EMACS_INT.
8211 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8212 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8213 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8214 (decode_coding_utf_16, decode_coding_emacs_mule)
8215 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8216 (decode_coding_ccl, decode_coding_charset)
8217 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8218 (decode_coding_iso_2022, decode_coding_emacs_mule)
8219 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8220 <char_offset, last_offset>: Declare EMACS_INT.
8221 (encode_coding_utf_8, encode_coding_utf_16)
8222 (encode_coding_emacs_mule, encode_invocation_designation)
8223 (encode_designation_at_bol, encode_coding_iso_2022)
8224 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8225 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8227 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8228 (encode_invocation_designation): Last argument P_NCHARS is now
8230 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8231 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8233 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8236 * ccl.c (Fccl_execute_on_string): Declare some variables
8239 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8241 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8243 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8245 * process.c (Fformat_network_address): Doc fix.
8247 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8249 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8251 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8253 * keyboard.c (read_char): Call Lisp function help-form-show,
8254 instead of using internal_with_output_to_temp_buffer.
8255 (Qhelp_form_show): New var.
8256 (syms_of_keyboard): Use DEFSYM macro.
8258 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8260 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8262 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8264 * process.c (Flist_processes): Remove to Lisp.
8265 (list_processes_1): Delete.
8267 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8269 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8271 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8273 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8275 Fix more problems found by GCC 4.6.0's static checks.
8277 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8279 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8281 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8283 * xdisp.c (vmessage): Mark as a printf-like function.
8285 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8287 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8289 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8290 printf-like functions.
8291 (tiff_load): Add casts to remove these marks before passing them
8292 to system-supplied API.
8294 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8296 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8297 This avoids several warnings with gcc -Wstrict-overflow.
8298 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8299 directly, rather than having caller test rule sign. This avoids
8300 some unnecessary tests.
8301 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8302 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8303 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8305 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8306 (xfont_open): Avoid unnecessary tests.
8308 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8310 * composite.h, composite.c (composition_gstring_put_cache):
8311 Use EMACS_INT, not int, for length.
8313 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8314 breaking out part of COMPOSITION_DECODE_RULE.
8315 (COMPOSITION_DECODE_RULE): Use it.
8316 * composite.c (get_composition_id): Remove unused local vars,
8317 by using the new macro.
8319 * textprop.c (set_text_properties_1): Change while to do-while,
8320 since the condition is always true at first.
8322 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8323 (interval_deletion_adjustment): Return unsigned value.
8326 * process.c (list_processes_1, create_pty, read_process_output):
8327 (exec_sentinel): Remove vars that were set but not used.
8328 (create_pty): Remove unnecessary "volatile"s.
8329 (Fnetwork_interface_info): Avoid possibility of int overflow.
8330 (read_process_output): Do adaptive read buffering even if carryover.
8331 (read_process_output): Simplify nbytes computation if buffered.
8333 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8335 * syntax.c (scan_words): Remove var that was set but not used.
8336 (update_syntax_table): Use unsigned instead of int.
8338 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8339 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8340 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8342 * print.c (print_error_message): Avoid int overflow.
8344 * font.c (font_list_entities): Redo for clarity,
8345 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8347 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8348 (font_score): Avoid potential overflow in diff calculation.
8350 * fns.c (substring_both): Remove var that is set but not used.
8351 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8353 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8355 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8356 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8357 can always succeed if overflow has undefined behavior.
8359 * search.c (boyer_moore, wordify): Remove vars set but not used.
8360 (wordify): Omit three unnecessary tests.
8362 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8363 All callers changed. This avoids the need for an unused var.
8365 * casefiddle.c (casify_region): Remove var that is set but not used.
8367 * dired.c (file_name_completion): Remove var that is set but not used.
8369 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8371 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8372 (Finsert_file_contents): Remove unnecessary code checking fd.
8374 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8375 Check for integer overflow on size calculations.
8377 * buffer.c (Fprevious_overlay_change): Remove var that is set
8380 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8381 Remove vars that are set but not used.
8382 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8383 (timer_check_2): Mark vars as initialized.
8385 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8387 * image.c (lookup_image): Remove var that is set but not used.
8388 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8390 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8391 that are set but not used.
8393 * xfns.c (make_invisible_cursor): Don't return garbage
8394 if XCreateBitmapFromData fails (Bug#8410).
8396 * xselect.c (x_get_local_selection, x_handle_property_notify):
8397 Remove vars that are set but not used.
8399 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8400 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8402 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8403 Remove var that is set but not used.
8404 (scroll_bar_windows_size): Now size_t, not int.
8405 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8408 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8409 (map_tty_color) [!defined MSDOS]: Likewise.
8411 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8413 * coding.c: Remove vars that are set but not used.
8414 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8415 All callers changed.
8416 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8417 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8418 (decode_coding_charset): Remove vars that are set but not used.
8420 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8421 that is set but not used.
8423 * print.c (print_object): Remove var that is set but not used.
8425 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8426 The gnulib version avoids calling malloc in the usual case,
8427 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8428 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8429 * filelock.c (current_lock_owner): Likewise.
8430 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8431 * sysdep.c: Include allocator.h, careadlinkat.h.
8432 (emacs_no_realloc_allocator): New static constant.
8433 (emacs_readlink): New function.
8434 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8435 ../lib/careadlinkat.h.
8437 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8439 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8440 first non-nil return value).
8442 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8444 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8445 if not defined (Bug#8403).
8447 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8449 * xdisp.c (display_count_lines): Remove parameter `start',
8450 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8451 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8452 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8453 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8454 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8455 and thereabouts. All callers changed.
8456 (get_per_char_metric): Remove parameter `f', unused since
8457 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8459 2011-04-02 Jim Meyering <meyering@redhat.com>
8461 do not dereference NULL upon failed strdup
8462 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8463 (ns_get_family): Likewise.
8465 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8467 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8469 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8471 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8474 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8476 Add lexical binding.
8478 * window.c (Ftemp_output_buffer_show): New fun.
8479 (Fsave_window_excursion):
8480 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8482 * lread.c (lisp_file_lexically_bound_p): New function.
8483 (Fload): Bind Qlexical_binding.
8484 (readevalloop): Remove `evalfun' arg.
8485 Bind Qinternal_interpreter_environment.
8486 (Feval_buffer): Bind Qlexical_binding.
8487 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8489 (syms_of_lread): Declare `lexical-binding'.
8491 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8493 * keyboard.c (eval_dyn): New fun.
8494 (menu_item_eval_property): Use it.
8496 * image.c (parse_image_spec): Use Ffunctionp.
8498 * fns.c (concat, mapcar1): Accept byte-code-functions.
8500 * eval.c (Fsetq): Handle lexical vars.
8501 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8502 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8503 (FletX, Flet): Obey lexical binding.
8504 (Fcommandp): Handle closures.
8505 (Feval): New `lexical' arg.
8506 (eval_sub): New function extracted from Feval. Use it almost
8507 everywhere where Feval was used. Look up vars in lexical env.
8509 (Ffunctionp): Move from subr.el.
8510 (Ffuncall): Handle closures.
8511 (apply_lambda): Remove `eval_flags'.
8512 (funcall_lambda): Handle closures and new byte-code-functions.
8513 (Fspecial_variable_p): New function.
8514 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8515 but without exporting it to Lisp.
8517 * doc.c (Fdocumentation, store_function_docstring):
8518 * data.c (Finteractive_form): Handle closures.
8520 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8523 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8525 (exec_byte_code): New function extracted from Fbyte_code to handle new
8526 calling convention for byte-code-functions. Add new byte-codes.
8528 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8530 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8532 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8534 * xdisp.c (redisplay_internal): Fix prototype.
8536 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8538 * xdisp.c (SCROLL_LIMIT): New macro.
8539 (try_scrolling): Use it when setting scroll_limit.
8540 Limit scrolling to 100 screen lines.
8541 (redisplay_window): Even when falling back on "recentering",
8542 position point in the window according to scroll-conservatively,
8543 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8545 (try_scrolling): When point is above the window, allow searching
8546 as far as scroll_max, or one screenful, to compute vertical
8547 distance from PT to the scroll margin position. This prevents
8548 try_scrolling from unnecessarily failing when
8549 scroll-conservatively is set to a value slightly larger than the
8550 window height. Clean up the case of PT below the margin at bottom
8551 of window: scroll_max can no longer be INT_MAX. When aggressive
8552 scrolling is in use, don't let point enter the opposite scroll
8553 margin as result of the scroll.
8554 (syms_of_xdisp) <scroll-conservatively>: Document the
8555 threshold of 100 lines for never-recentering scrolling.
8557 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8559 * dispextern.h (move_it_by_lines):
8560 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8561 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8562 (message_log_check_duplicate): Remove parameters `prev_bol' and
8563 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8564 (redisplay_internal): Remove parameter `preserve_echo_area',
8565 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8567 * indent.c (Fvertical_motion):
8568 * window.c (window_scroll_pixel_based, Frecenter):
8569 Don't pass `need_y_p' to `move_it_by_lines'.
8571 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8573 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8574 steal a few bits to be more compact.
8575 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8576 Remove unneeded casts.
8578 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8580 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8582 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8583 binding" message (bug#7967).
8585 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8587 Fix more problems found by GCC 4.6.0's static checks.
8589 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8590 Remove unused local var.
8592 * editfns.c (Fmessage_box): Remove unused local var.
8594 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8595 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8596 Omit unused local vars.
8597 * window.c (shrink_windows): Omit unused local var.
8598 * menu.c (digest_single_submenu): Omit unused local var.
8599 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8600 Omit unused local var.
8602 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8603 Don't assume string length fits in int.
8604 (keyremap_step, read_key_sequence): Use size_t for sizes.
8605 (read_key_sequence): Don't check last_real_key_start redundantly.
8607 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8608 instead of alloca (Bug#8344).
8610 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8611 (Fbacktrace_frame): Don't assume nframes fits in int.
8613 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8615 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8618 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8620 * cm.c (calccost): Turn while-do into do-while, for clarity.
8622 * keyboard.c (syms_of_keyboard): Use the same style as later
8623 in this function when indexing through an array. This also
8624 works around GCC bug 48267.
8626 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8628 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8630 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8631 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8633 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8634 This avoids undefined behavior on integer overflow, and is a bit
8635 more convenient anyway since it is compared to a size_t variable.
8637 Variadic C functions now count arguments with size_t, not int.
8638 This avoids an unnecessary limitation on 64-bit machines, which
8639 caused (substring ...) to crash on large vectors (Bug#8344).
8640 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8641 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8642 All variadic functions and their callers changed accordingly.
8643 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8644 * data.c (arith_driver, float_arith_driver): Likewise.
8645 * editfns.c (general_insert_function): Likewise.
8646 * eval.c (struct backtrace.nargs, interactive_p)
8647 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8648 (funcall_lambda, mark_backtrace): Likewise.
8649 * fns.c (concat): Likewise.
8650 * frame.c (x_set_frame_parameters): Likewise.
8651 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8652 0 if not found, not -1. All callers changed.
8654 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8655 (stack_copy_size): Now size_t, not int.
8656 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8658 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8660 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8661 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8662 All callers changed.
8664 * lisp.h (multibyte_char_to_unibyte):
8665 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8666 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8667 * character.h (CHAR_TO_BYTE8):
8668 * cmds.c (internal_self_insert):
8669 * editfns.c (general_insert_function):
8670 * keymap.c (push_key_description):
8671 * search.c (Freplace_match):
8672 * xdisp.c (message_dolog, set_message_1): All callers changed.
8674 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8676 * keyboard.c (safe_run_hook_funcall): New function.
8677 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8678 don't set the hook to nil, but remove the offending function instead.
8679 (Qcommand_hook_internal): Remove, unused.
8680 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8681 Vcommand_hook_internal.
8683 * eval.c (enum run_hooks_condition): Remove.
8684 (funcall_nil, funcall_not): New functions.
8685 (run_hook_with_args): Call each function through a `funcall' argument.
8686 Remove `cond' argument, now redundant.
8687 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8688 (Frun_hook_with_args_until_failure): Adjust accordingly.
8689 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8691 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8693 * dispextern.h (string_buffer_position): Remove declaration.
8695 * print.c (strout): Remove parameter `multibyte', unused since
8696 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8698 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8699 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8700 All callers changed.
8702 * w32.c (_wsa_errlist): Use braces for struct initializers.
8704 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8705 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8706 All callers changed.
8707 (string_buffer_position): Likewise. Also, make static (it's never
8708 used outside xdisp.c).
8709 (cursor_row_p): Remove parameter `w', unused since
8710 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8711 (decode_mode_spec): Remove parameter `precision', introduced during
8712 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8713 All callers changed.
8715 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8717 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8719 2011-03-27 Anders Lindgren <andlind@gmail.com>
8721 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8722 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8723 (ns_update_auto_hide_menu_bar): New functions.
8724 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8725 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8726 ns_constrain_all_frames.
8727 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8728 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8730 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8732 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8734 2011-03-27 Glenn Morris <rgm@gnu.org>
8736 * syssignal.h: Replace RETSIGTYPE with void.
8737 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8738 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8739 Replace SIGTYPE with void everywhere.
8740 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8741 * s/template.h (SIGTYPE): Remove commented out definition.
8743 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8745 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8746 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8748 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8750 * w32.c (read_unc_volume): Use parameter `henum', instead of
8751 global variable `wget_enum_handle'.
8753 * keymap.c (describe_vector): Remove parameters `indices' and
8754 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8755 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8757 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8759 * keyboard.c (timer_check): Remove parameter `do_it_now',
8760 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8761 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8762 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8764 * keyboard.c (read_char):
8765 * w32menu.c (w32_menu_display_help):
8766 * xmenu.c (show_help_event, menu_help_callback):
8767 Adjust calls to `show_help_echo'.
8769 * gtkutil.c (xg_maybe_add_timer):
8770 * keyboard.c (readable_events):
8771 * process.c (wait_reading_process_output):
8772 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8774 * insdel.c (adjust_markers_gap_motion):
8775 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8776 (gap_left, gap_right): Don't call it.
8778 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8780 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8781 incurred during fontification.
8783 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8785 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8786 (DEFVAR_PER_BUFFER): Don't pass it.
8788 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8789 (scrolling_window): Don't pass it.
8791 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8793 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8795 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8797 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8798 of variables specific to SELinux and computation of `encoded_absname'.
8800 * image.c (XPutPixel): Remove unused variable `height'.
8802 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8804 * unexw32.c (get_section_info): Remove unused variable `section'.
8806 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8807 (system_process_attributes): Remove unused variable `sess'.
8808 (sys_read): Remove unused variable `err'.
8810 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8811 (w32_wnd_proc): Remove unused variable `isdead'.
8812 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8813 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8814 (x_create_tip_frame): Remove unused variable `tem'.
8816 * w32inevt.c (w32_console_read_socket):
8817 Remove unused variable `no_events'.
8819 * w32term.c (x_draw_composite_glyph_string_foreground):
8820 Remove unused variable `width'.
8822 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8824 * w32term.c (x_set_glyph_string_clipping):
8825 Don't pass uninitialized region to CombineRgn.
8827 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8829 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8830 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8831 (Fx_close_connection): Remove unused variable `i'.
8833 * w32font.c (w32font_draw): Return number of glyphs.
8834 (w32font_open_internal): Remove unused variable `i'.
8835 (w32font_driver): Add missing initializer.
8837 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8838 (fill_in_menu): Remove unused variable `items_added'.
8840 * w32term.c (last_mouse_press_frame): Remove static global variable.
8841 (w32_clip_to_row): Remove unused variable `f'.
8842 (x_delete_terminal): Remove unused variable `i'.
8844 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8845 (NOTHING): Remove unused static global variable.
8846 (uniscribe_check_otf): Remove unused variable `table'.
8847 (uniscribe_font_driver): Add missing initializers.
8849 2011-03-23 Julien Danjou <julien@danjou.info>
8851 * term.c (Fsuspend_tty, Fresume_tty):
8852 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8853 * window.c (temp_output_buffer_show):
8854 * insdel.c (signal_before_change):
8855 * frame.c (Fhandle_switch_frame):
8856 * fileio.c (Fdo_auto_save):
8857 * emacs.c (Fkill_emacs):
8858 * editfns.c (save_excursion_restore):
8859 * cmds.c (internal_self_insert):
8860 * callint.c (Fcall_interactively):
8861 * buffer.c (Fkill_all_local_variables):
8862 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8864 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8865 unconditionally since it does the check itself.
8867 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8869 Fix more problems found by GCC 4.5.2's static checks.
8871 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8872 the first time through the loop, since we know p0 < p1 then.
8873 This also avoids a gcc -Wstrict-overflow warning.
8875 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8876 leading to a memory leak, possible in functions like
8877 load_charset_map_from_file that can allocate an unbounded number
8878 of objects (Bug#8318).
8880 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8881 that could (at least in theory) be that large.
8883 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8884 This is less likely to overflow, and avoids undefined behavior if
8885 overflow does occur. All callers changed. Use strtoul to scan
8886 for the unsigned long integer.
8887 (pint2hrstr): Simplify and tune code slightly.
8888 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8890 * scroll.c (do_scrolling): Work around GCC bug 48228.
8891 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8893 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8894 This also avoids a warning with gcc -Wstrict-overflow.
8895 (validate_x_resource_name): Simplify count usage.
8896 This also avoids a warning with gcc -Wstrict-overflow.
8898 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8901 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8903 * process.c (Fmake_network_process): Use socklen_t, not int,
8904 where POSIX says socklen_t is required in portable programs.
8905 This fixes a porting bug on hosts like 64-bit HP-UX, where
8906 socklen_t is wider than int (Bug#8277).
8907 (Fmake_network_process, server_accept_connection):
8908 (wait_reading_process_output, read_process_output):
8911 * process.c: Rename or move locals to avoid shadowing.
8912 (list_processes_1, Fmake_network_process):
8913 (read_process_output_error_handler, exec_sentinel_error_handler):
8914 Rename or move locals.
8915 (Fmake_network_process): Define label "retry_connect" only if needed.
8916 (Fnetwork_interface_info): Fix pointer signedness.
8917 (process_send_signal): Add cast to avoid pointer signedness problem.
8918 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8919 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8921 Make tparam.h and terminfo.c consistent.
8922 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8923 Include tparam.h instead, since it declares them.
8924 * cm.h (PC): Remove extern decl; tparam.h now does this.
8925 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8926 * terminfo.c: Include tparam.h, to check interfaces.
8927 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8928 (tparam): Adjust signature to match interface in tparam.h;
8929 this removes some undefined behavior. Check that outstring and len
8930 are zero, which they always are with Emacs.
8931 * tparam.h (PC, BC, UP): New extern decls.
8933 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8934 (xftfont_open): Rename locals to avoid shadowing.
8936 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8937 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8938 (OTF_TAG_SYM): Omit macro if not needed.
8939 (ftfont_list): Remove unused local.
8940 (get_adstyle_property, ftfont_pattern_entity):
8941 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8942 Rename locals to avoid shadowing.
8944 * xfont.c (xfont_list_family): Mark var as initialized.
8946 * xml.c (make_dom): Now static.
8948 * composite.c (composition_compute_stop_pos): Rename local to
8950 (composition_reseat_it): Remove unused locals.
8951 (find_automatic_composition, composition_adjust_point): Likewise.
8952 (composition_update_it): Mark var as initialized.
8953 (find_automatic_composition): Mark vars as initialized,
8954 with a FIXME (Bug#8290).
8956 character.h: Rename locals to avoid shadowing.
8957 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8958 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8959 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8960 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8963 * textprop.c (property_change_between_p): Remove; unused.
8965 * intervals.c (interval_start_pos): Now static.
8967 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8969 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8970 Rename locals to avoid shadowing.
8972 * sound.c (wav_play, au_play, Fplay_sound_internal):
8973 Fix pointer signedness.
8974 (alsa_choose_format): Remove unused local var.
8975 (wav_play): Initialize a variable to 0, to prevent undefined
8976 behavior (Bug#8278).
8978 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8980 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8982 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8983 clobbering (Bug#8298).
8984 * sysdep.c (sys_subshell): Likewise.
8985 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8987 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8988 This should get cleaned up, so that child_setup has the
8989 same signature on all platforms.
8991 * callproc.c (call_process_cleanup): Now static.
8992 (relocate_fd): Rename locals to avoid shadowing.
8994 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8996 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8997 not to be necessary, and produces flickering.
8999 2011-03-20 Glenn Morris <rgm@gnu.org>
9001 * config.in: Remove file.
9003 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9005 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9006 are now in src/globals.h.
9007 (syms_of_minibuf): Remove spurious & from previous change.
9009 2011-03-20 Leo Liu <sdl.web@gmail.com>
9011 * minibuf.c (completing-read-function): New variable.
9012 (completing-read-default): Rename from completing-read.
9013 (completing-read): Call completing-read-function.
9015 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9017 * xfaces.c (Fx_load_color_file):
9018 Read color file from absolute filename (bug#8250).
9020 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9022 * makefile.w32-in: Update dependencies.
9024 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9026 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9028 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9030 Fix more problems found by GCC 4.5.2's static checks.
9032 * process.c (make_serial_process_unwind, send_process_trap):
9033 (sigchld_handler): Now static.
9035 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9036 That way, the code declares only the vars that it needs.
9037 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9038 * s/cygwin.h (PTY_ITERATION): Likewise.
9039 * s/darwin.h (PTY_ITERATION): Likewise.
9040 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9042 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9043 * process.c (allocate_pty): Don't declare stb unless it's needed.
9045 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9046 (CONSTANTLIM): Remove; unused.
9047 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9048 Define only if needed.
9050 * unexelf.c (unexec): Name an expression,
9051 to avoid gcc -Wbad-function-cast warning.
9052 Use a different way to cause a compilation error if anyone uses
9053 n rather than nn, a way that does not involve shadowing.
9054 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9056 * deps.mk (unexalpha.o): Remove; unused.
9058 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9059 * unexec.h: New file.
9060 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9061 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9063 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9064 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9065 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9066 Change as necessary to match prototype in unexec.h.
9068 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9070 (back_comment, skip_chars): Mark vars as initialized.
9072 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9073 Rename locals to avoid shadowing.
9075 * lread.c (read1): Rewrite so as not to use empty "else".
9076 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9078 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9080 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9081 warning when compiling print.c.
9083 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9084 instead of using an uninitialized var.
9085 (font_sort_entities): Mark var as initialized.
9087 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9089 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9090 pointers to constants.
9091 (font_parse_fcname): Remove unused vars.
9092 (font_delete_unmatched): Now static.
9093 (font_get_spec): Remove; unused.
9094 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9095 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9096 Rename or move locals to avoid shadowing.
9098 * fns.c (require_nesting_list, require_unwind): Now static.
9099 (Ffillarray): Rename locals to avoid shadowing.
9101 * floatfns.c (domain_error2): Define only if needed.
9102 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9104 * alloc.c (mark_backtrace): Move decl from here ...
9105 * lisp.h: ... to here, so that it can be checked.
9107 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9108 (Fdefvar): Rewrite so as not to use empty "else".
9109 (lisp_indirect_variable): Name an expression,
9110 to avoid gcc -Wbad-function-cast warning.
9111 (Fdefvar): Rename locals to avoid shadowing.
9113 * callint.c (quotify_arg, quotify_args): Now static.
9114 (Fcall_interactively): Rename locals to avoid shadowing.
9115 Use const pointer when appropriate.
9117 * lisp.h (get_system_name, get_operating_system_release):
9118 Move decls here, to check interfaces.
9119 * process.c (get_operating_system_release): Move decl to lisp.h.
9120 * xrdb.c (get_system_name): Likewise.
9121 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9122 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9123 some of which prompt warnings from gcc -Wbad-function-cast.
9124 (Fformat_time_string, Fencode_time, Finsert_char):
9125 (Ftranslate_region_internal, Fformat):
9126 Rename or remove local vars to avoid shadowing.
9127 (Ftranslate_region_internal): Mark var as initialized.
9129 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9132 * lisp.h (eassert): Check that the argument compiles, even if
9133 ENABLE_CHECKING is not defined.
9135 * data.c (Findirect_variable): Name an expression, to avoid
9136 gcc -Wbad-function-cast warning.
9137 (default_value, arithcompare, arith_driver, arith_error): Now static.
9138 (store_symval_forwarding): Rename local to avoid shadowing.
9139 (Fmake_variable_buffer_local, Fmake_local_variable):
9140 Mark variables as initialized.
9141 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9143 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9144 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9145 Rename locals to avoid shadowing.
9146 (mark_stack): Move local variables into the #ifdef region where
9148 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9149 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9151 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9152 (GC_STRING_CHARS): Remove; not used.
9153 (Fmemory_limit): Cast sbrk's returned value to char *.
9155 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9156 avoids undefined behavior in theory.
9158 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9160 Use functions, not macros, for up- and down-casing (Bug#8254).
9161 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9162 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9163 to use the following functions instead of these macros.
9164 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9165 EMACS_INT, since callers assume the returned value fits in int.
9166 (upcase1): Likewise, for UPCASE_TABLE.
9167 (uppercasep, lowercasep, upcase): New static inline functions.
9168 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9169 the race-condition problem in the old DOWNCASE.
9171 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9172 Rename locals to avoid shadowing.
9173 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9174 (regex_compile, re_search_2, re_match_2_internal):
9175 Remove unused local vars.
9176 (FREE_VAR): Rewrite so as not to use empty "else",
9177 which gcc can warn about.
9178 (regex_compile, re_match_2_internal): Mark locals as initialized.
9179 (RETALLOC_IF): Define only if needed.
9180 (WORDCHAR_P): Likewise. This one is never needed, but is used
9181 only in a comment talking about a compiler bug, so put inside
9182 the #if 0 of that comment.
9183 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9184 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9187 * search.c (boyer_moore): Rename locals to avoid shadowing.
9188 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9189 (PREV_CHAR_BOUNDARY): Likewise.
9191 * search.c (simple_search): Remove unused var.
9193 * dired.c (compile_pattern): Move decl from here ...
9194 * lisp.h: ... to here, so that it can be checked.
9195 (struct re_registers): New forward decl.
9197 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9199 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9201 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9202 Rename locals to avoid shadowing.
9203 (Fvertical_motion): Mark locals as initialized.
9205 * casefiddle.c (casify_object, casify_region): Now static.
9206 (casify_region): Mark local as initialized.
9208 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9210 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9211 New macros, so that the caller can use some names other than
9212 gcpro1, gcpro2, etc.
9213 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9215 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9216 argument, for consistency with GCPRO2_VAR, etc: it is now the
9217 prefix of the variable, not the variable itself. All uses
9219 * dired.c (directory_files_internal, file_name_completion):
9220 Rename locals to avoid shadowing.
9222 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9223 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9224 dired.c's scmp function, had undefined behavior.
9225 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9226 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9227 * buffer.h: ... to here, because these macros use current_buffer,
9228 and the new implementation with inline functions needs to have
9229 current_buffer in scope now, rather than later when the macros
9231 (downcase, upcase1): New static inline functions.
9232 (DOWNCASE, UPCASE1): Reimplement using these functions.
9233 This avoids undefined behavior in expressions like
9234 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9235 from race conditions in accessing the global variables
9236 case_temp1 and case_temp2.
9237 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9238 * lisp.h (case_temp1, case_temp2): Remove their decls.
9239 * character.h (ASCII_CHAR_P): Move from here ...
9240 * lisp.h: ... to here, so that the inline functions mentioned
9243 * dired.c (directory_files_internal_unwind): Now static.
9245 * fileio.c (file_name_as_directory, directory_file_name):
9246 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9248 (file_name_as_directory): Use const pointers when appropriate.
9249 (Fexpand_file_name): Likewise. In particular, newdir might
9250 point at constant storage, so make it a const pointer.
9251 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9252 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9254 (Fset_file_times, Finsert_file_contents, auto_save_error):
9255 Rename locals to avoid shadowing.
9257 * minibuf.c (choose_minibuf_frame_1): Now static.
9258 (Ftry_completion, Fall_completions): Rename or remove locals
9261 * marker.c (bytepos_to_charpos): Remove; unused.
9263 * lisp.h (verify_bytepos, count_markers): New decls,
9264 so that gcc does not warn that these functions aren't declared.
9266 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9267 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9268 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9269 (copy_text): Remove unused local var.
9271 * filelock.c (within_one_second): Now static.
9272 (lock_file_1): Rename local to avoid shadowing.
9274 * buffer.c (fix_overlays_before): Mark locals as initialized.
9275 (fix_start_end_in_overlays): Likewise. This function should be
9276 simplified by using pointers-to-pointers, but that's a different
9278 (switch_to_buffer_1): Now static.
9279 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9280 (report_overlay_modification): Rename locals to avoid shadowing.
9282 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9283 Fix pointer signedness issue.
9284 (sys_subshell): Mark local as volatile if checking for lint,
9285 to suppress a gcc -Wclobbered warning that does not seem to be right.
9286 (MAXPATHLEN): Define only if needed.
9288 * process.c (serial_open, serial_configure): Move decls from here ...
9289 * systty.h: ... to here, so that they can be checked.
9291 * fns.c (get_random, seed_random): Move extern decls from here ...
9292 * lisp.h: ... to here, so that they can be checked.
9294 * sysdep.c (reset_io): Now static.
9295 (wait_for_termination_signal): Remove; unused.
9297 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9298 (copy_keymap_item, append_key, push_text_char_description):
9300 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9301 (DENSE_TABLE_SIZE): Remove; unused.
9302 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9303 (describe_map_tree):
9304 Rename locals to avoid shadowing.
9306 * keyboard.c: Declare functions static if they are not used elsewhere.
9307 (echo_char, echo_dash, cmd_error, top_level_2):
9308 (poll_for_input, handle_async_input): Now static.
9309 (read_char, kbd_buffer_get_event, make_lispy_position):
9310 (make_lispy_event, make_lispy_movement, apply_modifiers):
9311 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9312 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9313 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9314 (read_key_sequence, read_char): Mark locals as initialized.
9315 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9317 * keyboard.h (make_ctrl_char): New decl.
9318 (mark_kboards): Move decl here ...
9319 * alloc.c (mark_kboards): ... from here.
9321 * lisp.h (force_auto_save_soon): New decl.
9323 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9324 (DEFINE_DUMMY_FUNCTION): New macro.
9325 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9327 (main): Add casts to avoid warnings
9328 if GCC considers string literals to be constants.
9330 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9332 * dbusbind.c: Pointer signedness fixes.
9333 (xd_signature, xd_append_arg, xd_initialize):
9334 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9335 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9336 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9337 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9339 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9340 if GCC considers string literals to be constants.
9341 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9343 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9345 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9346 (print_preprocess, print_object): New macro to fix last change.
9348 * print.c (print_preprocess): Don't forget font objects.
9350 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9352 * emacs.c (USAGE3): Doc fixes.
9354 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9356 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9359 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9361 * lisp.h (VWindow_system, Qfile_name_history):
9362 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9363 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9364 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9366 * w32select.c: Don't #include "keyboard.h".
9367 (run_protected): Add extern declaration for waiting_for_input.
9369 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9370 * w32console.c (detect_input_pending, read_input_pending)
9371 (encode_terminal_code):
9372 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9373 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9374 (w32_system_caret_y, Qfile_name_history):
9375 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9376 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9377 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9378 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9379 * w32proc.c (Qlocal, report_file_error):
9380 * w32term.c (Vwindow_system, updating_frame):
9381 * w32uniscribe.c (initialized, uniscribe_font_driver):
9382 Remove unneeded extern declarations.
9384 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9386 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9388 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9390 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9391 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9392 These macros can no longer be used for assignment.
9394 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9395 Assign struct members directly, instead of using BUF_BEGV etc.
9396 (record_buffer_markers, fetch_buffer_markers): New functions for
9397 recording and fetching special buffer markers.
9398 (set_buffer_internal_1, set_buffer_temp): Use them.
9400 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9402 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9404 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9405 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9407 * xdisp.c (hscroll_window_tree):
9408 (reconsider_clip_changes): Use PT instead of BUF_PT.
9410 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9412 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9413 $(EMACS_ROOT)/lib/intprops.h.
9415 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9417 Fix more problems found by GCC 4.5.2's static checks.
9419 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9420 to unsigned char * to avoid compiler diagnostic.
9421 (xg_free_frame_widgets): Make it clear that a local variable is
9422 needed only if USE_GTK_TOOLTIP.
9423 (gdk_window_get_screen): Make it clear that this macro is needed
9424 only if USE_GTK_TOOLTIP.
9425 (int_gtk_range_get_value): New function, which avoids a diagnostic
9426 from gcc -Wbad-function-cast.
9427 (xg_set_toolkit_scroll_bar_thumb): Use it.
9428 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9429 diagnostic from gcc -Wbad-function-cast.
9430 (get_utf8_string, xg_get_file_with_chooser):
9431 Rename locals to avoid shadowing.
9432 (create_dialog): Move locals to avoid shadowing.
9434 * xgselect.c (xg_select): Remove unused var.
9436 * image.c (four_corners_best): Mark locals as initialized.
9437 (gif_load): Initialize transparent_p to zero (Bug#8238).
9438 Mark another local as initialized.
9439 (my_png_error, my_error_exit): Mark with NO_RETURN.
9441 * image.c (clear_image_cache): Now static.
9442 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9443 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9444 (x_edge_detection): Remove unnecessary cast that
9445 gcc -Wbad-function-cast diagnoses.
9446 (gif_load): Fix pointer signedness.
9447 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9448 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9450 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9452 Improve quality of tests for time stamp overflow.
9453 For example, without this patch (encode-time 0 0 0 1 1
9454 1152921504606846976) returns the obviously-bogus value (-948597
9455 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9456 reports time overflow. See
9457 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9458 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9459 * editfns.c: Include limits.h and intprops.h.
9460 (TIME_T_MIN, TIME_T_MAX): New macros.
9461 (time_overflow): Move earlier, to before first use.
9462 (hi_time, lo_time): New functions, for an accurate test for
9464 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9465 (Fget_internal_run_time): Don't assume time_t fits in int.
9466 (make_time): Use list2 instead of Fcons twice.
9467 (Fdecode_time): More accurate test for out-of-range times.
9468 (check_tm_member): New function.
9469 (Fencode_time): Use it, to test for out-of-range times.
9470 (lisp_time_argument): Don't rely on undefined left-shift and
9471 right-shift behavior when checking for time stamp overflow.
9473 * editfns.c (time_overflow): New function, refactoring common code.
9474 (Fformat_time_string, Fdecode_time, Fencode_time):
9475 (Fcurrent_time_string): Use it.
9477 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9478 * dired.c (make_time): Move to ...
9479 * editfns.c (make_time): ... here.
9480 * systime.h: Note the move.
9482 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9484 * fringe.c (update_window_fringes): Remove unused variables.
9486 * unexmacosx.c (copy_data_segment): Also copy __got section.
9489 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9491 * termcap.c [MSDOS]: Include "msdos.h".
9492 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9493 Constify `char *' arguments and their references according to
9494 prototypes in tparam.h.
9496 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9498 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9499 Adapt all references accordingly.
9501 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9503 2011-03-11 Tom Tromey <tromey@redhat.com>
9505 * buffer.c (syms_of_buffer): Remove obsolete comment.
9507 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9509 * termhooks.h (encode_terminal_code): Declare prototype.
9511 * msdos.c (encode_terminal_code): Don't declare prototype.
9513 * term.c (encode_terminal_code): Now external again, used by
9514 w32console.c and msdos.c.
9516 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9517 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9519 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9521 Fix some minor problems found by GCC 4.5.2's static checks.
9523 * fringe.c (update_window_fringes): Mark locals as initialized
9525 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9527 * alloc.c (mark_fringe_data): Move decl from here ...
9528 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9529 to check its interface.
9530 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9532 * fontset.c (free_realized_fontset): Now static.
9533 (Fset_fontset_font): Rename local to avoid shadowing.
9534 (fontset_font): Mark local as initialized.
9535 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9537 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9539 * xselect.c (x_disown_buffer_selections): Remove; not used.
9540 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9541 (x_own_selection, Fx_disown_selection_internal): Rename locals
9543 (x_handle_dnd_message): Remove local to avoid shadowing.
9545 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9546 so that the caller can use some name other than gcpro1.
9547 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9548 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9549 (Fx_backspace_delete_keys_p):
9550 Use them to avoid shadowing, and rename vars to avoid shadowing.
9551 (x_decode_color, x_set_name, x_window): Now static.
9552 (Fx_create_frame): Add braces to silence GCC warning.
9553 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9554 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9555 Remove unused locals.
9556 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9557 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9558 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9561 * xterm.h (x_mouse_leave): New decl.
9563 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9564 Remove unused functions.
9565 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9566 (x_calc_absolute_position): Now static.
9567 (XTread_socket): Don't define label "out" unless it's used.
9568 Don't declare local "event" unless it's used.
9569 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9570 unless they are used.
9571 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9572 (x_fatal_error_signal): Remove; not used.
9573 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9574 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9575 (x_error_catcher, x_connection_closed, x_error_handler):
9576 (x_error_quitter, xembed_send_message, x_iconify_frame):
9577 (my_log_handler): Rename locals to avoid shadowing.
9578 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9579 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9581 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9582 Rename or move locals to avoid shadowing.
9583 (tty_defined_color, merge_face_heights): Now static.
9584 (free_realized_faces_for_fontset): Remove; not used.
9585 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9586 does not deduce is never used uninitialized.
9587 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9588 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9590 * terminal.c (store_terminal_param): Now static.
9592 * xmenu.c (menu_highlight_callback): Now static.
9593 (set_frame_menubar): Remove unused local.
9594 (xmenu_show): Rename parameter to avoid shadowing.
9595 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9596 since they might point to immutable storage.
9597 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9598 since it's unused otherwise.
9600 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9601 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9602 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9603 avoids a gcc -Wuninitialized diagnostic.
9604 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9605 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9606 does not deduce are never used uninitialized.
9608 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9610 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9611 * window.c (window_loop, size_window):
9612 (run_window_configuration_change_hook, enlarge_window): Likewise.
9614 * window.c (display_buffer): Now static.
9615 (size_window): Mark variables that gcc -Wuninitialized
9616 does not deduce are never used uninitialized.
9617 * window.h (check_all_windows): New decl, to forestall
9618 gcc -Wmissing-prototypes diagnostic.
9619 * dispextern.h (bidi_dump_cached_states): Likewise.
9621 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9623 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9625 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9626 and to avoid gcc -Wuninitialized warning.
9627 (load_charset_map): Mark variables that gcc -Wuninitialized
9628 does not deduce are never used uninitialized.
9629 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9631 * coding.c (coding_set_source, coding_set_destination):
9632 Use "else { /* comment */ }" rather than "else /* comment */;"
9633 for clarity, and to avoid gcc -Wempty-body warning.
9634 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9635 a block, when the outer 'i' will do.
9636 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9637 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9638 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9639 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9640 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9641 Rename locals to avoid shadowing.
9642 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9643 * coding.c (emacs_mule_char, encode_invocation_designation):
9644 Now static, since they're not used elsewhere.
9645 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9646 (decode_coding_object, encode_coding_object, detect_coding_system):
9647 (decode_coding_emacs_mule): Mark variables that gcc
9648 -Wuninitialized does not deduce are never used uninitialized.
9649 (detect_coding_iso_2022): Initialize a local variable that might
9650 be used uninitialized. Leave a FIXME because it's not clear that
9651 this initialization is needed. (Bug#8211)
9652 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9653 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9654 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9655 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9656 Remove unused macros.
9658 * category.c (hash_get_category_set): Remove unused local var.
9659 (copy_category_table): Now static, since it's not used elsewhere.
9660 * character.c (string_count_byte8): Likewise.
9662 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9663 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9665 * chartab.c (copy_sub_char_table): Now static, since it's not used
9667 (sub_char_table_ref_and_range, char_table_ref_and_range):
9668 Rename locals to avoid shadowing.
9669 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9671 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9672 (BIDI_BOB): Remove unused macro.
9674 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9675 deduce are never used uninitialized.
9676 * term.c (encode_terminal_code): Likewise.
9678 * term.c (encode_terminal_code): Now static. Remove unused local.
9680 * tparam.h: New file.
9681 * term.c, tparam.h: Include it.
9682 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9683 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9684 Move these decls to tparam.h, and make them agree with what
9685 is actually in tparam.c. The previous trick of using incompatible
9686 decls in different modules does not conform to the C standard.
9687 All callers of tparam changed to use tparam's actual API.
9688 * tparam.c (tparam1, tparam, tgoto):
9689 Use const pointers where appropriate.
9691 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9692 * cm.h (struct cm): Likewise.
9693 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9694 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9695 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9696 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9697 (turn_on_face, init_tty): Likewise.
9698 * termchar.h (struct tty_display_info): Likewise.
9700 * term.c (term_mouse_position): Rename local to avoid shadowing.
9702 * alloc.c (mark_ttys): Move decl from here ...
9703 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9705 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9707 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9709 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9711 * search.c (compile_pattern_1): Remove argument regp, unused since
9712 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9713 (compile_pattern): Don't pass it.
9715 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9717 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9718 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9720 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9722 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9724 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9725 gdk_window_get_screen, gdk_window_get_geometry,
9726 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9727 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9728 (xg_get_pixbuf_from_pixmap): New function.
9729 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9730 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9731 Call xg_get_pixbuf_from_pixmap instead of
9732 gdk_pixbuf_get_from_drawable.
9733 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9734 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9735 (xg_check_special_colors): Use GtkStyleContext and its functions
9737 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9738 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9739 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9740 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9741 Call gtk_widget_get_preferred_size.
9742 (xg_frame_resized): gdk_window_get_geometry only takes 5
9744 (xg_win_to_widget, xg_event_is_for_menubar):
9745 Call gdk_x11_window_lookup_for_display.
9746 (xg_set_widget_bg): New function.
9747 (delete_cb): New function.
9748 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9749 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9750 (xg_set_background_color): Call xg_set_widget_bg.
9751 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9752 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9753 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9754 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9756 (update_frame_tool_bar): Call gtk_widget_hide.
9757 (xg_initialize): Use GDK_KEY_g.
9759 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9761 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9763 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9764 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9765 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9767 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9769 * w32xfns.c (select_palette): Check success of RealizePalette against
9770 GDI_ERROR, not zero.
9772 See ChangeLog.11 for earlier changes.
9778 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9780 This file is part of GNU Emacs.
9782 GNU Emacs is free software: you can redistribute it and/or modify
9783 it under the terms of the GNU General Public License as published by
9784 the Free Software Foundation, either version 3 of the License, or
9785 (at your option) any later version.
9787 GNU Emacs is distributed in the hope that it will be useful,
9788 but WITHOUT ANY WARRANTY; without even the implied warranty of
9789 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9790 GNU General Public License for more details.
9792 You should have received a copy of the GNU General Public License
9793 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.