]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Bail out from list-processes if async subprocesses aren't available.
[gnu-emacs] / src / ChangeLog
1 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2
3 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4
5 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6
7 * keyboard.c (read_char): Call Lisp function help-form-show,
8 instead of using internal_with_output_to_temp_buffer.
9 (Qhelp_form_show): New var.
10 (syms_of_keyboard): Use DEFSYM macro.
11
12 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13
14 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
15
16 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
17
18 * process.c (Flist_processes): Removed to Lisp.
19 (list_processes_1): Deleted.
20
21 2011-04-06 Eli Zaretskii <eliz@gnu.org>
22
23 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
24
25 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
26
27 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
28
29 Fix more problems found by GCC 4.6.0's static checks.
30
31 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
32
33 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
34
35 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
36
37 * xdisp.c (vmessage): Mark as a printf-like function.
38
39 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
40
41 * sound.c (sound_warning): Don't crash if arg contains a printf format.
42
43 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
44 printf-like functions.
45 (tiff_load): Add casts to remove these marks before passing them
46 to system-supplied API.
47
48 * eval.c (Fsignal): Remove excess argument to 'fatal'.
49
50 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
51 This avoids several warnings with gcc -Wstrict-overflow.
52 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
53 directly, rather than having caller test rule sign. This avoids
54 some unnecessary tests.
55 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
56 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
57 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
58
59 * xfont.c (xfont_text_extents): Remove var that was set but not used.
60 (xfont_open): Avoid unnecessary tests.
61
62 * composite.c (composition_gstring_put_cache): Use unsigned integer.
63
64 * composite.h, composite.c (composition_gstring_put_cache):
65 Use EMACS_INT, not int, for length.
66
67 * composite.h (COMPOSITION_DECODE_REFS): New macro,
68 breaking out part of COMPOSITION_DECODE_RULE.
69 (COMPOSITION_DECODE_RULE): Use it.
70 * composite.c (get_composition_id): Remove unused local vars,
71 by using the new macro.
72
73 * textprop.c (set_text_properties_1): Change while to do-while,
74 since the condition is always true at first.
75
76 * intervals.c (graft_intervals_into_buffer): Mark var as used.
77 (interval_deletion_adjustment): Return unsigned value.
78 All uses changed.
79
80 * process.c (list_processes_1, create_pty, read_process_output):
81 (exec_sentinel): Remove vars that were set but not used.
82 (create_pty): Remove unnecessary "volatile"s.
83 (Fnetwork_interface_info): Avoid possibility of int overflow.
84 (read_process_output): Do adaptive read buffering even if carryover.
85 (read_process_output): Simplify nbytes computation if buffered.
86
87 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
88
89 * syntax.c (scan_words): Remove var that was set but not used.
90 (update_syntax_table): Use unsigned instead of int.
91
92 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
93 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
94 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
95
96 * print.c (print_error_message): Avoid int overflow.
97
98 * font.c (font_list_entities): Redo for clarity,
99 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
100
101 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
102 (font_score): Avoid potential overflow in diff calculation.
103
104 * fns.c (substring_both): Remove var that is set but not used.
105 (sxhash): Redo loop for clarity and to avoid wraparound warning.
106
107 * eval.c (funcall_lambda): Rename local to avoid shadowing.
108
109 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
110 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
111 can always succeed if overflow has undefined behavior.
112
113 * search.c (boyer_moore, wordify): Remove vars set but not used.
114 (wordify): Omit three unnecessary tests.
115
116 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
117 All callers changed. This avoids the need for an unused var.
118
119 * casefiddle.c (casify_region): Remove var that is set but not used.
120
121 * dired.c (file_name_completion): Remove var that is set but not used.
122
123 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
124
125 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
126 (Finsert_file_contents): Remove unnecessary code checking fd.
127
128 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
129 Check for integer overflow on size calculations.
130
131 * buffer.c (Fprevious_overlay_change): Remove var that is set
132 but not used.
133
134 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
135 Remove vars that are set but not used.
136 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
137 (timer_check_2): Mark vars as initialized.
138
139 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
140
141 * image.c (lookup_image): Remove var that is set but not used.
142 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
143
144 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
145 that are set but not used.
146
147 * xfns.c (make_invisible_cursor): Don't return garbage
148 if XCreateBitmapFromData fails (Bug#8410).
149
150 * xselect.c (x_get_local_selection, x_handle_property_notify):
151 Remove vars that are set but not used.
152
153 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
154 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
155
156 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
157 Remove var that is set but not used.
158 (scroll_bar_windows_size): Now size_t, not int.
159 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
160 Check for overflow.
161
162 * xfaces.c (realize_named_face): Remove vars that are set but not used.
163 (map_tty_color) [!defined MSDOS]: Likewise.
164
165 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
166
167 * coding.c: Remove vars that are set but not used.
168 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
169 All callers changed.
170 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
171 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
172 (decode_coding_charset): Remove vars that are set but not used.
173
174 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
175 that is set but not used.
176
177 * print.c (print_object): Remove var that is set but not used.
178
179 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
180 The gnulib version avoids calling malloc in the usual case,
181 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
182 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
183 * filelock.c (current_lock_owner): Likewise.
184 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
185 * sysdep.c: Include allocator.h, careadlinkat.h.
186 (emacs_no_realloc_allocator): New static constant.
187 (emacs_readlink): New function.
188 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
189 ../lib/careadlinkat.h.
190
191 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
192
193 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
194 first non-nil return value).
195
196 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
197
198 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
199 if not defined (Bug#8403).
200
201 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
202
203 * xdisp.c (display_count_lines): Remove parameter `start',
204 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
205 (get_char_face_and_encoding): Remove parameter `multibyte_p',
206 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
207 (fill_stretch_glyph_string): Remove parameters `row' and `area',
208 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
209 and thereabouts. All callers changed.
210 (get_per_char_metric): Remove parameter `f', unused since
211 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
212
213 2011-04-02 Jim Meyering <meyering@redhat.com>
214
215 do not dereference NULL upon failed strdup
216 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
217 (ns_get_family): Likewise.
218
219 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
220
221 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
222
223 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
224
225 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
226 later (Bug#8403).
227
228 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
229
230 Add lexical binding.
231
232 * window.c (Ftemp_output_buffer_show): New fun.
233 (Fsave_window_excursion):
234 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
235
236 * lread.c (lisp_file_lexically_bound_p): New function.
237 (Fload): Bind Qlexical_binding.
238 (readevalloop): Remove `evalfun' arg.
239 Bind Qinternal_interpreter_environment.
240 (Feval_buffer): Bind Qlexical_binding.
241 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
242 Mark as dynamic.
243 (syms_of_lread): Declare `lexical-binding'.
244
245 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
246
247 * keyboard.c (eval_dyn): New fun.
248 (menu_item_eval_property): Use it.
249
250 * image.c (parse_image_spec): Use Ffunctionp.
251
252 * fns.c (concat, mapcar1): Accept byte-code-functions.
253
254 * eval.c (Fsetq): Handle lexical vars.
255 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
256 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
257 (FletX, Flet): Obey lexical binding.
258 (Fcommandp): Handle closures.
259 (Feval): New `lexical' arg.
260 (eval_sub): New function extracted from Feval. Use it almost
261 everywhere where Feval was used. Look up vars in lexical env.
262 Handle closures.
263 (Ffunctionp): Move from subr.el.
264 (Ffuncall): Handle closures.
265 (apply_lambda): Remove `eval_flags'.
266 (funcall_lambda): Handle closures and new byte-code-functions.
267 (Fspecial_variable_p): New function.
268 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
269 but without exporting it to Lisp.
270
271 * doc.c (Fdocumentation, store_function_docstring):
272 * data.c (Finteractive_form): Handle closures.
273
274 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
275 interactive spec.
276
277 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
278 byte-codes.
279 (exec_byte_code): New function extracted from Fbyte_code to handle new
280 calling convention for byte-code-functions. Add new byte-codes.
281
282 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
283
284 * alloc.c (Fmake_symbol): Init new `declared_special' field.
285
286 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
287
288 * xdisp.c (redisplay_internal): Fix prototype.
289
290 2011-03-31 Eli Zaretskii <eliz@gnu.org>
291
292 * xdisp.c (SCROLL_LIMIT): New macro.
293 (try_scrolling): Use it when setting scroll_limit. Limit
294 scrolling to 100 screen lines.
295 (redisplay_window): Even when falling back on "recentering",
296 position point in the window according to scroll-conservatively,
297 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
298
299 (try_scrolling): When point is above the window, allow searching
300 as far as scroll_max, or one screenful, to compute vertical
301 distance from PT to the scroll margin position. This prevents
302 try_scrolling from unnecessarily failing when
303 scroll-conservatively is set to a value slightly larger than the
304 window height. Clean up the case of PT below the margin at bottom
305 of window: scroll_max can no longer be INT_MAX. When aggressive
306 scrolling is in use, don't let point enter the opposite scroll
307 margin as result of the scroll.
308 (syms_of_xdisp) <scroll-conservatively>: Document the
309 threshold of 100 lines for never-recentering scrolling.
310
311 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
312
313 * dispextern.h (move_it_by_lines):
314 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
315 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
316 (message_log_check_duplicate): Remove parameters `prev_bol' and
317 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
318 (redisplay_internal): Remove parameter `preserve_echo_area',
319 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
320
321 * indent.c (Fvertical_motion):
322 * window.c (window_scroll_pixel_based, Frecenter):
323 Don't pass `need_y_p' to `move_it_by_lines'.
324
325 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
326
327 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
328 steal a few bits to be more compact.
329 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
330 Remove unneeded casts.
331
332 * bytecode.c (Fbyte_code): CAR and CDR can GC.
333
334 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
335
336 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
337 binding" message (bug#7967).
338
339 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
340
341 Fix more problems found by GCC 4.6.0's static checks.
342
343 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
344 Remove unused local var.
345
346 * editfns.c (Fmessage_box): Remove unused local var.
347
348 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
349 (note_mode_line_or_margin_highlight, note_mouse_highlight):
350 Omit unused local vars.
351 * window.c (shrink_windows): Omit unused local var.
352 * menu.c (digest_single_submenu): Omit unused local var.
353 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
354 Omit unused local var.
355
356 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
357 Don't assume string length fits in int.
358 (keyremap_step, read_key_sequence): Use size_t for sizes.
359 (read_key_sequence): Don't check last_real_key_start redundantly.
360
361 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
362 instead of alloca (Bug#8344).
363
364 * eval.c (Fbacktrace): Don't assume nargs fits in int.
365 (Fbacktrace_frame): Don't assume nframes fits in int.
366
367 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
368
369 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
370 concerns.
371
372 * term.c (produce_glyphless_glyph): Remove unnecessary test.
373
374 * cm.c (calccost): Turn while-do into do-while, for clarity.
375
376 * keyboard.c (syms_of_keyboard): Use the same style as later
377 in this function when indexing through an array. This also
378 works around GCC bug 48267.
379
380 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
381
382 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
383
384 * chartab.c (sub_char_table_ref_and_range): Redo for slight
385 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
386
387 * keyboard.c, keyboard.h (num_input_events): Now size_t.
388 This avoids undefined behavior on integer overflow, and is a bit
389 more convenient anyway since it is compared to a size_t variable.
390
391 Variadic C functions now count arguments with size_t, not int.
392 This avoids an unnecessary limitation on 64-bit machines, which
393 caused (substring ...) to crash on large vectors (Bug#8344).
394 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
395 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
396 All variadic functions and their callers changed accordingly.
397 (struct gcpro.nvars): Now size_t, not int. All uses changed.
398 * data.c (arith_driver, float_arith_driver): Likewise.
399 * editfns.c (general_insert_function): Likewise.
400 * eval.c (struct backtrace.nargs, interactive_p)
401 (internal_condition_case_n, run_hook_with_args, apply_lambda)
402 (funcall_lambda, mark_backtrace): Likewise.
403 * fns.c (concat): Likewise.
404 * frame.c (x_set_frame_parameters): Likewise.
405 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
406 0 if not found, not -1. All callers changed.
407
408 * alloc.c (garbage_collect): Don't assume stack size fits in int.
409 (stack_copy_size): Now size_t, not int.
410 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
411
412 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
413
414 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
415 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
416 All callers changed.
417
418 * lisp.h (multibyte_char_to_unibyte):
419 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
420 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
421 * character.h (CHAR_TO_BYTE8):
422 * cmds.c (internal_self_insert):
423 * editfns.c (general_insert_function):
424 * keymap.c (push_key_description):
425 * search.c (Freplace_match):
426 * xdisp.c (message_dolog, set_message_1): All callers changed.
427
428 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
429
430 * keyboard.c (safe_run_hook_funcall): New function.
431 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
432 don't set the hook to nil, but remove the offending function instead.
433 (Qcommand_hook_internal): Remove, unused.
434 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
435 Vcommand_hook_internal.
436
437 * eval.c (enum run_hooks_condition): Remove.
438 (funcall_nil, funcall_not): New functions.
439 (run_hook_with_args): Call each function through a `funcall' argument.
440 Remove `cond' argument, now redundant.
441 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
442 (Frun_hook_with_args_until_failure): Adjust accordingly.
443 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
444
445 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
446
447 * dispextern.h (string_buffer_position): Remove declaration.
448
449 * print.c (strout): Remove parameter `multibyte', unused since
450 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
451
452 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
453 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
454 All callers changed.
455
456 * w32.c (_wsa_errlist): Use braces for struct initializers.
457
458 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
459 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
460 All callers changed.
461 (string_buffer_position): Likewise. Also, make static (it's never
462 used outside xdisp.c).
463 (cursor_row_p): Remove parameter `w', unused since
464 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
465 (decode_mode_spec): Remove parameter `precision', introduced during
466 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
467 All callers changed.
468
469 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
470
471 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
472
473 2011-03-27 Anders Lindgren <andlind@gmail.com>
474
475 * nsterm.m (ns_menu_bar_is_hidden): New variable.
476 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
477 (ns_update_auto_hide_menu_bar): New functions.
478 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
479 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
480 ns_constrain_all_frames.
481 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
482 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
483
484 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
485
486 * nsmenu.m (runDialogAt): Remove argument to timer_check.
487
488 2011-03-27 Glenn Morris <rgm@gnu.org>
489
490 * syssignal.h: Replace RETSIGTYPE with void.
491 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
492 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
493 Replace SIGTYPE with void everywhere.
494 * s/usg5-4-common.h (SIGTYPE): Remove definition.
495 * s/template.h (SIGTYPE): Remove commented out definition.
496
497 2011-03-26 Eli Zaretskii <eliz@gnu.org>
498
499 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
500 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
501
502 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
503
504 * w32.c (read_unc_volume): Use parameter `henum', instead of
505 global variable `wget_enum_handle'.
506
507 * keymap.c (describe_vector): Remove parameters `indices' and
508 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
509 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
510
511 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
512
513 * keyboard.c (timer_check): Remove parameter `do_it_now',
514 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
515 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
516 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
517
518 * keyboard.c (read_char):
519 * w32menu.c (w32_menu_display_help):
520 * xmenu.c (show_help_event, menu_help_callback):
521 Adjust calls to `show_help_echo'.
522
523 * gtkutil.c (xg_maybe_add_timer):
524 * keyboard.c (readable_events):
525 * process.c (wait_reading_process_output):
526 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
527
528 * insdel.c (adjust_markers_gap_motion):
529 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
530 (gap_left, gap_right): Don't call it.
531
532 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
533
534 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
535 incurred during fontification.
536
537 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
538
539 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
540 (DEFVAR_PER_BUFFER): Don't pass it.
541
542 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
543 (scrolling_window): Don't pass it.
544
545 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
546
547 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
548
549 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
550 and `suffix'.
551 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
552 of variables specific to SELinux and computation of `encoded_absname'.
553
554 * image.c (XPutPixel): Remove unused variable `height'.
555
556 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
557
558 * unexw32.c (get_section_info): Remove unused variable `section'.
559
560 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
561 (system_process_attributes): Remove unused variable `sess'.
562 (sys_read): Remove unused variable `err'.
563
564 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
565 (w32_wnd_proc): Remove unused variable `isdead'.
566 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
567 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
568 (x_create_tip_frame): Remove unused variable `tem'.
569
570 * w32inevt.c (w32_console_read_socket):
571 Remove unused variable `no_events'.
572
573 * w32term.c (x_draw_composite_glyph_string_foreground):
574 Remove unused variable `width'.
575
576 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
577
578 * w32term.c (x_set_glyph_string_clipping):
579 Don't pass uninitialized region to CombineRgn.
580
581 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
582
583 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
584 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
585 (Fx_close_connection): Remove unused variable `i'.
586
587 * w32font.c (w32font_draw): Return number of glyphs.
588 (w32font_open_internal): Remove unused variable `i'.
589 (w32font_driver): Add missing initializer.
590
591 * w32menu.c (utf8to16): Remove unused variable `utf16'.
592 (fill_in_menu): Remove unused variable `items_added'.
593
594 * w32term.c (last_mouse_press_frame): Remove static global variable.
595 (w32_clip_to_row): Remove unused variable `f'.
596 (x_delete_terminal): Remove unused variable `i'.
597
598 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
599 (NOTHING): Remove unused static global variable.
600 (uniscribe_check_otf): Remove unused variable `table'.
601 (uniscribe_font_driver): Add missing initializers.
602
603 2011-03-23 Julien Danjou <julien@danjou.info>
604
605 * term.c (Fsuspend_tty, Fresume_tty):
606 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
607 * window.c (temp_output_buffer_show):
608 * insdel.c (signal_before_change):
609 * frame.c (Fhandle_switch_frame):
610 * fileio.c (Fdo_auto_save):
611 * emacs.c (Fkill_emacs):
612 * editfns.c (save_excursion_restore):
613 * cmds.c (internal_self_insert):
614 * callint.c (Fcall_interactively):
615 * buffer.c (Fkill_all_local_variables):
616 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
617 Use Frun_hooks.
618 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
619 unconditionnaly since it does the check itself.
620
621 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
622
623 Fix more problems found by GCC 4.5.2's static checks.
624
625 * coding.c (encode_coding_raw_text): Avoid unnecessary test
626 the first time through the loop, since we know p0 < p1 then.
627 This also avoids a gcc -Wstrict-overflow warning.
628
629 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
630 leading to a memory leak, possible in functions like
631 load_charset_map_from_file that can allocate an unbounded number
632 of objects (Bug#8318).
633
634 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
635 that could (at least in theory) be that large.
636
637 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
638 This is less likely to overflow, and avoids undefined behavior if
639 overflow does occur. All callers changed. Use strtoul to scan
640 for the unsigned long integer.
641 (pint2hrstr): Simplify and tune code slightly.
642 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
643
644 * scroll.c (do_scrolling): Work around GCC bug 48228.
645 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
646
647 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
648 This also avoids a warning with gcc -Wstrict-overflow.
649 (validate_x_resource_name): Simplify count usage.
650 This also avoids a warning with gcc -Wstrict-overflow.
651
652 * fileio.c (Fcopy_file): Report error if fchown or fchmod
653 fail (Bug#8306).
654
655 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
656
657 * process.c (Fmake_network_process): Use socklen_t, not int,
658 where POSIX says socklen_t is required in portable programs.
659 This fixes a porting bug on hosts like 64-bit HP-UX, where
660 socklen_t is wider than int (Bug#8277).
661 (Fmake_network_process, server_accept_connection):
662 (wait_reading_process_output, read_process_output):
663 Likewise.
664
665 * process.c: Rename or move locals to avoid shadowing.
666 (list_processes_1, Fmake_network_process):
667 (read_process_output_error_handler, exec_sentinel_error_handler):
668 Rename or move locals.
669 (Fmake_network_process): Define label "retry_connect" only if needed.
670 (Fnetwork_interface_info): Fix pointer signedness.
671 (process_send_signal): Add cast to avoid pointer signedness problem.
672 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
673 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
674
675 Make tparam.h and terminfo.c consistent.
676 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
677 Include tparam.h instead, since it declares them.
678 * cm.h (PC): Remove extern decl; tparam.h now does this.
679 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
680 * terminfo.c: Include tparam.h, to check interfaces.
681 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
682 (tparam): Adjust signature to match interface in tparam.h;
683 this removes some undefined behavior. Check that outstring and len
684 are zero, which they always are with Emacs.
685 * tparam.h (PC, BC, UP): New extern decls.
686
687 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
688 (xftfont_open): Rename locals to avoid shadowing.
689
690 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
691 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
692 (OTF_TAG_SYM): Omit macro if not needed.
693 (ftfont_list): Remove unused local.
694 (get_adstyle_property, ftfont_pattern_entity):
695 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
696 Rename locals to avoid shadowing.
697
698 * xfont.c (xfont_list_family): Mark var as initialized.
699
700 * xml.c (make_dom): Now static.
701
702 * composite.c (composition_compute_stop_pos): Rename local to
703 avoid shadowing.
704 (composition_reseat_it): Remove unused locals.
705 (find_automatic_composition, composition_adjust_point): Likewise.
706 (composition_update_it): Mark var as initialized.
707 (find_automatic_composition): Mark vars as initialized,
708 with a FIXME (Bug#8290).
709
710 character.h: Rename locals to avoid shadowing.
711 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
712 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
713 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
714 (BUF_DEC_POS): Be more systematic about renaming local temporaries
715 to avoid shadowing.
716
717 * textprop.c (property_change_between_p): Remove; unused.
718
719 * intervals.c (interval_start_pos): Now static.
720
721 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
722
723 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
724 Rename locals to avoid shadowing.
725
726 * sound.c (wav_play, au_play, Fplay_sound_internal):
727 Fix pointer signedness.
728 (alsa_choose_format): Remove unused local var.
729 (wav_play): Initialize a variable to 0, to prevent undefined
730 behavior (Bug#8278).
731
732 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
733
734 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
735
736 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
737 clobbering (Bug#8298).
738 * sysdep.c (sys_subshell): Likewise.
739 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
740
741 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
742 This should get cleaned up, so that child_setup has the
743 same signature on all platforms.
744
745 * callproc.c (call_process_cleanup): Now static.
746 (relocate_fd): Rename locals to avoid shadowing.
747
748 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
749
750 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
751 not to be necessary, and produces flickering.
752
753 2011-03-20 Glenn Morris <rgm@gnu.org>
754
755 * config.in: Remove file.
756
757 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
758
759 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
760 are now in src/globals.h.
761 (syms_of_minibuf): Remove spurious & from previous change.
762
763 2011-03-20 Leo <sdl.web@gmail.com>
764
765 * minibuf.c (completing-read-function): New variable.
766 (completing-read-default): Rename from completing-read.
767 (completing-read): Call completing-read-function.
768
769 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
770
771 * xfaces.c (Fx_load_color_file):
772 Read color file from absolute filename (bug#8250).
773
774 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
775
776 * makefile.w32-in: Update dependencies.
777
778 2011-03-17 Eli Zaretskii <eliz@gnu.org>
779
780 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
781
782 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
783
784 Fix more problems found by GCC 4.5.2's static checks.
785
786 * process.c (make_serial_process_unwind, send_process_trap):
787 (sigchld_handler): Now static.
788
789 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
790 That way, the code declares only the vars that it needs.
791 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
792 * s/cygwin.h (PTY_ITERATION): Likewise.
793 * s/darwin.h (PTY_ITERATION): Likewise.
794 * s/gnu-linux.h (PTY_ITERATION): Likewise.
795
796 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
797 * process.c (allocate_pty): Don't declare stb unless it's needed.
798
799 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
800 (CONSTANTLIM): Remove; unused.
801 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
802 Define only if needed.
803
804 * unexelf.c (unexec): Name an expression,
805 to avoid gcc -Wbad-function-cast warning.
806 Use a different way to cause a compilation error if anyone uses
807 n rather than nn, a way that does not involve shadowing.
808 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
809
810 * deps.mk (unexalpha.o): Remove; unused.
811
812 New file unexec.h, the (simple) interface for unexec (Bug#8267).
813 * unexec.h: New file.
814 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
815 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
816 Depend on unexec.h.
817 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
818 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
819 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
820 Change as necessary to match prototype in unexec.h.
821
822 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
823 shadowing.
824 (back_comment, skip_chars): Mark vars as initialized.
825
826 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
827 Rename locals to avoid shadowing.
828
829 * lread.c (read1): Rewrite so as not to use empty "else".
830 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
831
832 * print.c (Fredirect_debugging_output): Fix pointer signedess.
833
834 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
835 warning when compiling print.c.
836
837 * font.c (font_unparse_fcname): Abort in an "impossible" situation
838 instead of using an uninitialized var.
839 (font_sort_entities): Mark var as initialized.
840
841 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
842
843 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
844 pointers to constants.
845 (font_parse_fcname): Remove unused vars.
846 (font_delete_unmatched): Now static.
847 (font_get_spec): Remove; unused.
848 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
849 (font_update_drivers, Ffont_get_glyphs, font_add_log):
850 Rename or move locals to avoid shadowing.
851
852 * fns.c (require_nesting_list, require_unwind): Now static.
853 (Ffillarray): Rename locals to avoid shadowing.
854
855 * floatfns.c (domain_error2): Define only if needed.
856 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
857
858 * alloc.c (mark_backtrace): Move decl from here ...
859 * lisp.h: ... to here, so that it can be checked.
860
861 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
862 (Fdefvar): Rewrite so as not to use empty "else".
863 (lisp_indirect_variable): Name an expression,
864 to avoid gcc -Wbad-function-cast warning.
865 (Fdefvar): Rename locals to avoid shadowing.
866
867 * callint.c (quotify_arg, quotify_args): Now static.
868 (Fcall_interactively): Rename locals to avoid shadowing.
869 Use const pointer when appropriate.
870
871 * lisp.h (get_system_name, get_operating_system_release):
872 Move decls here, to check interfaces.
873 * process.c (get_operating_system_release): Move decl to lisp.h.
874 * xrdb.c (get_system_name): Likewise.
875 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
876 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
877 some of which prompt warnings from gcc -Wbad-function-cast.
878 (Fformat_time_string, Fencode_time, Finsert_char):
879 (Ftranslate_region_internal, Fformat):
880 Rename or remove local vars to avoid shadowing.
881 (Ftranslate_region_internal): Mark var as initialized.
882
883 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
884 avoid shadowing.
885
886 * lisp.h (eassert): Check that the argument compiles, even if
887 ENABLE_CHECKING is not defined.
888
889 * data.c (Findirect_variable): Name an expression, to avoid
890 gcc -Wbad-function-cast warning.
891 (default_value, arithcompare, arith_driver, arith_error): Now static.
892 (store_symval_forwarding): Rename local to avoid shadowing.
893 (Fmake_variable_buffer_local, Fmake_local_variable):
894 Mark variables as initialized.
895 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
896
897 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
898 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
899 Rename locals to avoid shadowing.
900 (mark_stack): Move local variables into the #ifdef region where
901 they're used.
902 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
903 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
904 needed otherwise.
905 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
906 (GC_STRING_CHARS): Remove; not used.
907 (Fmemory_limit): Cast sbrk's returned value to char *.
908
909 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
910 avoids undefined behavior in theory.
911
912 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
913
914 Use functions, not macros, for up- and down-casing (Bug#8254).
915 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
916 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
917 to use the following functions instead of these macros.
918 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
919 EMACS_INT, since callers assume the returned value fits in int.
920 (upcase1): Likewise, for UPCASE_TABLE.
921 (uppercasep, lowercasep, upcase): New static inline functions.
922 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
923 the race-condition problem in the old DOWNCASE.
924
925 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
926 Rename locals to avoid shadowing.
927 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
928 (regex_compile, re_search_2, re_match_2_internal):
929 Remove unused local vars.
930 (FREE_VAR): Rewrite so as not to use empty "else",
931 which gcc can warn about.
932 (regex_compile, re_match_2_internal): Mark locals as initialized.
933 (RETALLOC_IF): Define only if needed.
934 (WORDCHAR_P): Likewise. This one is never needed, but is used
935 only in a comment talking about a compiler bug, so put inside
936 the #if 0 of that comment.
937 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
938 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
939 Remove; unused.
940
941 * search.c (boyer_moore): Rename locals to avoid shadowing.
942 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
943 (PREV_CHAR_BOUNDARY): Likewise.
944
945 * search.c (simple_search): Remove unused var.
946
947 * dired.c (compile_pattern): Move decl from here ...
948 * lisp.h: ... to here, so that it can be checked.
949 (struct re_registers): New forward decl.
950
951 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
952
953 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
954 All uses changed.
955 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
956 Rename locals to avoid shadowing.
957 (Fvertical_motion): Mark locals as initialized.
958
959 * casefiddle.c (casify_object, casify_region): Now static.
960 (casify_region): Mark local as initialized.
961
962 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
963
964 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
965 New macros, so that the caller can use some names other than
966 gcpro1, gcpro2, etc.
967 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
968 of the new macros.
969 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
970 argument, for consistency with GCPRO2_VAR, etc: it is now the
971 prefix of the variable, not the variable itself. All uses
972 changed.
973 * dired.c (directory_files_internal, file_name_completion):
974 Rename locals to avoid shadowing.
975
976 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
977 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
978 dired.c's scmp function, had undefined behavior.
979 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
980 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
981 * buffer.h: ... to here, because these macros use current_buffer,
982 and the new implementation with inline functions needs to have
983 current_buffer in scope now, rather than later when the macros
984 are used.
985 (downcase, upcase1): New static inline functions.
986 (DOWNCASE, UPCASE1): Reimplement using these functions.
987 This avoids undefined behavior in expressions like
988 DOWNCASE (x) == DOWNCASE (y), which previously suffered
989 from race conditions in accessing the global variables
990 case_temp1 and case_temp2.
991 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
992 * lisp.h (case_temp1, case_temp2): Remove their decls.
993 * character.h (ASCII_CHAR_P): Move from here ...
994 * lisp.h: ... to here, so that the inline functions mentioned
995 above can use them.
996
997 * dired.c (directory_files_internal_unwind): Now static.
998
999 * fileio.c (file_name_as_directory, directory_file_name):
1000 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1001 Now static.
1002 (file_name_as_directory): Use const pointers when appropriate.
1003 (Fexpand_file_name): Likewise. In particular, newdir might
1004 point at constant storage, so make it a const pointer.
1005 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1006 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1007 signedness issues.
1008 (Fset_file_times, Finsert_file_contents, auto_save_error):
1009 Rename locals to avoid shadowing.
1010
1011 * minibuf.c (choose_minibuf_frame_1): Now static.
1012 (Ftry_completion, Fall_completions): Rename or remove locals
1013 to avoid shadowing.
1014
1015 * marker.c (bytepos_to_charpos): Remove; unused.
1016
1017 * lisp.h (verify_bytepos, count_markers): New decls,
1018 so that gcc does not warn that these functions aren't declared.
1019
1020 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1021 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1022 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1023 (copy_text): Remove unused local var.
1024
1025 * filelock.c (within_one_second): Now static.
1026 (lock_file_1): Rename local to avoid shadowing.
1027
1028 * buffer.c (fix_overlays_before): Mark locals as initialized.
1029 (fix_start_end_in_overlays): Likewise. This function should be
1030 simplified by using pointers-to-pointers, but that's a different
1031 matter.
1032 (switch_to_buffer_1): Now static.
1033 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1034 (report_overlay_modification): Rename locals to avoid shadowing.
1035
1036 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1037 Fix pointer signedness issue.
1038 (sys_subshell): Mark local as volatile if checking for lint,
1039 to suppress a gcc -Wclobbered warning that does not seem to be right.
1040 (MAXPATHLEN): Define only if needed.
1041
1042 * process.c (serial_open, serial_configure): Move decls from here ...
1043 * systty.h: ... to here, so that they can be checked.
1044
1045 * fns.c (get_random, seed_random): Move extern decls from here ...
1046 * lisp.h: ... to here, so that they can be checked.
1047
1048 * sysdep.c (reset_io): Now static.
1049 (wait_for_termination_signal): Remove; unused.
1050
1051 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1052 (copy_keymap_item, append_key, push_text_char_description):
1053 Now static.
1054 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1055 (DENSE_TABLE_SIZE): Remove; unused.
1056 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1057 (describe_map_tree):
1058 Rename locals to avoid shadowing.
1059
1060 * keyboard.c: Declare functions static if they are not used elsewhere.
1061 (echo_char, echo_dash, cmd_error, top_level_2):
1062 (poll_for_input, handle_async_input): Now static.
1063 (read_char, kbd_buffer_get_event, make_lispy_position):
1064 (make_lispy_event, make_lispy_movement, apply_modifiers):
1065 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1066 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1067 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1068 (read_key_sequence, read_char): Mark locals as initialized.
1069 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1070
1071 * keyboard.h (make_ctrl_char): New decl.
1072 (mark_kboards): Move decl here ...
1073 * alloc.c (mark_kboards): ... from here.
1074
1075 * lisp.h (force_auto_save_soon): New decl.
1076
1077 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1078 (DEFINE_DUMMY_FUNCTION): New macro.
1079 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1080 Use it.
1081 (main): Add casts to avoid warnings
1082 if GCC considers string literals to be constants.
1083
1084 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1085
1086 * dbusbind.c: Pointer signedness fixes.
1087 (xd_signature, xd_append_arg, xd_initialize):
1088 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1089 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1090 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1091 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1092
1093 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1094 if GCC considers string literals to be constants.
1095 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1096
1097 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1098
1099 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1100 (print_preprocess, print_object): New macro to fix last change.
1101
1102 * print.c (print_preprocess): Don't forget font objects.
1103
1104 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1105
1106 * emacs.c (USAGE3): Doc fixes.
1107
1108 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1109
1110 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1111 structure.
1112
1113 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1114
1115 * lisp.h (VWindow_system, Qfile_name_history):
1116 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1117 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1118 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1119
1120 * w32select.c: Don't #include "keyboard.h".
1121 (run_protected): Add extern declaration for waiting_for_input.
1122
1123 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1124 * w32console.c (detect_input_pending, read_input_pending)
1125 (encode_terminal_code):
1126 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1127 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1128 (w32_system_caret_y, Qfile_name_history):
1129 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1130 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1131 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1132 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1133 * w32proc.c (Qlocal, report_file_error):
1134 * w32term.c (Vwindow_system, updating_frame):
1135 * w32uniscribe.c (initialized, uniscribe_font_driver):
1136 Remove unneeded extern declarations.
1137
1138 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1139
1140 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1141
1142 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1143
1144 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1145 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1146 These macros can no longer be used for assignment.
1147
1148 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1149 Assign struct members directly, instead of using BUF_BEGV etc.
1150 (record_buffer_markers, fetch_buffer_markers): New functions for
1151 recording and fetching special buffer markers.
1152 (set_buffer_internal_1, set_buffer_temp): Use them.
1153
1154 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1155
1156 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1157
1158 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1159 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1160
1161 * xdisp.c (hscroll_window_tree):
1162 (reconsider_clip_changes): Use PT instead of BUF_PT.
1163
1164 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1165
1166 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1167 $(EMACS_ROOT)/lib/intprops.h.
1168
1169 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 Fix more problems found by GCC 4.5.2's static checks.
1172
1173 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1174 to unsigned char * to avoid compiler diagnostic.
1175 (xg_free_frame_widgets): Make it clear that a local variable is
1176 needed only if USE_GTK_TOOLTIP.
1177 (gdk_window_get_screen): Make it clear that this macro is needed
1178 only if USE_GTK_TOOLTIP.
1179 (int_gtk_range_get_value): New function, which avoids a diagnostic
1180 from gcc -Wbad-function-cast.
1181 (xg_set_toolkit_scroll_bar_thumb): Use it.
1182 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1183 diagnostic from gcc -Wbad-function-cast.
1184 (get_utf8_string, xg_get_file_with_chooser):
1185 Rename locals to avoid shadowing.
1186 (create_dialog): Move locals to avoid shadowing.
1187
1188 * xgselect.c (xg_select): Remove unused var.
1189
1190 * image.c (four_corners_best): Mark locals as initialized.
1191 (gif_load): Initialize transparent_p to zero (Bug#8238).
1192 Mark another local as initialized.
1193 (my_png_error, my_error_exit): Mark with NO_RETURN.
1194
1195 * image.c (clear_image_cache): Now static.
1196 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1197 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1198 (x_edge_detection): Remove unnecessary cast that
1199 gcc -Wbad-function-cast diagnoses.
1200 (gif_load): Fix pointer signedness.
1201 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1202 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1203
1204 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1205
1206 Improve quality of tests for time stamp overflow.
1207 For example, without this patch (encode-time 0 0 0 1 1
1208 1152921504606846976) returns the obviously-bogus value (-948597
1209 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1210 reports time overflow. See
1211 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1212 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1213 * editfns.c: Include limits.h and intprops.h.
1214 (TIME_T_MIN, TIME_T_MAX): New macros.
1215 (time_overflow): Move earlier, to before first use.
1216 (hi_time, lo_time): New functions, for an accurate test for
1217 out-of-range times.
1218 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1219 (Fget_internal_run_time): Don't assume time_t fits in int.
1220 (make_time): Use list2 instead of Fcons twice.
1221 (Fdecode_time): More accurate test for out-of-range times.
1222 (check_tm_member): New function.
1223 (Fencode_time): Use it, to test for out-of-range times.
1224 (lisp_time_argument): Don't rely on undefined left-shift and
1225 right-shift behavior when checking for time stamp overflow.
1226
1227 * editfns.c (time_overflow): New function, refactoring common code.
1228 (Fformat_time_string, Fdecode_time, Fencode_time):
1229 (Fcurrent_time_string): Use it.
1230
1231 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1232 * dired.c (make_time): Move to ...
1233 * editfns.c (make_time): ... here.
1234 * systime.h: Note the move.
1235
1236 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1237
1238 * fringe.c (update_window_fringes): Remove unused variables.
1239
1240 * unexmacosx.c (copy_data_segment): Also copy __got section.
1241 (Bug#8223)
1242
1243 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1244
1245 * termcap.c [MSDOS]: Include "msdos.h".
1246 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1247 Constify `char *' arguments and their references according to
1248 prototypes in tparam.h.
1249
1250 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1251
1252 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1253 Adapt all references accordingly.
1254
1255 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1256
1257 2011-03-11 Tom Tromey <tromey@redhat.com>
1258
1259 * buffer.c (syms_of_buffer): Remove obsolete comment.
1260
1261 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1262
1263 * termhooks.h (encode_terminal_code): Declare prototype.
1264
1265 * msdos.c (encode_terminal_code): Don't declare prototype.
1266
1267 * term.c (encode_terminal_code): Now external again, used by
1268 w32console.c and msdos.c.
1269
1270 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1271 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1272
1273 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1274
1275 Fix some minor problems found by GCC 4.5.2's static checks.
1276
1277 * fringe.c (update_window_fringes): Mark locals as initialized
1278 (Bug#8227).
1279 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1280
1281 * alloc.c (mark_fringe_data): Move decl from here ...
1282 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1283 to check its interface.
1284 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1285
1286 * fontset.c (free_realized_fontset): Now static.
1287 (Fset_fontset_font): Rename local to avoid shadowing.
1288 (fontset_font): Mark local as initialized.
1289 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1290
1291 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1292
1293 * xselect.c (x_disown_buffer_selections): Remove; not used.
1294 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1295 (x_own_selection, Fx_disown_selection_internal): Rename locals
1296 to avoid shadowing.
1297 (x_handle_dnd_message): Remove local to avoid shadowing.
1298
1299 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1300 so that the caller can use some name other than gcpro1.
1301 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1302 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1303 (Fx_backspace_delete_keys_p):
1304 Use them to avoid shadowing, and rename vars to avoid shadowing.
1305 (x_decode_color, x_set_name, x_window): Now static.
1306 (Fx_create_frame): Add braces to silence GCC warning.
1307 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1308 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1309 Remove unused locals.
1310 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1311 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1312 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1313 macros.
1314
1315 * xterm.h (x_mouse_leave): New decl.
1316
1317 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1318 Remove unused functions.
1319 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1320 (x_calc_absolute_position): Now static.
1321 (XTread_socket): Don't define label "out" unless it's used.
1322 Don't declare local "event" unless it's used.
1323 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1324 unless they are used.
1325 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1326 (x_fatal_error_signal): Remove; not used.
1327 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1328 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1329 (x_error_catcher, x_connection_closed, x_error_handler):
1330 (x_error_quitter, xembed_send_message, x_iconify_frame):
1331 (my_log_handler): Rename locals to avoid shadowing.
1332 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1333 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1334
1335 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1336 Rename or move locals to avoid shadowing.
1337 (tty_defined_color, merge_face_heights): Now static.
1338 (free_realized_faces_for_fontset): Remove; not used.
1339 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1340 does not deduce is never used uninitialized.
1341 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1342 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1343
1344 * terminal.c (store_terminal_param): Now static.
1345
1346 * xmenu.c (menu_highlight_callback): Now static.
1347 (set_frame_menubar): Remove unused local.
1348 (xmenu_show): Rename parameter to avoid shadowing.
1349 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1350 since they might point to immutable storage.
1351 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1352 since it's unused otherwise.
1353
1354 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1355 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1356 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1357 avoids a gcc -Wuninitialized diagnostic.
1358 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1359 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1360 does not deduce are never used uninitialized.
1361
1362 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1363
1364 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1365 * window.c (window_loop, size_window):
1366 (run_window_configuration_change_hook, enlarge_window): Likewise.
1367
1368 * window.c (display_buffer): Now static.
1369 (size_window): Mark variables that gcc -Wuninitialized
1370 does not deduce are never used uninitialized.
1371 * window.h (check_all_windows): New decl, to forestall
1372 gcc -Wmissing-prototypes diagnostic.
1373 * dispextern.h (bidi_dump_cached_states): Likewise.
1374
1375 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1376 shadowing.
1377 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1378 Include <limits.h>.
1379 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1380 and to avoid gcc -Wuninitialized warning.
1381 (load_charset_map): Mark variables that gcc -Wuninitialized
1382 does not deduce are never used uninitialized.
1383 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1384
1385 * coding.c (coding_set_source, coding_set_destination):
1386 Use "else { /* comment */ }" rather than "else /* comment */;"
1387 for clarity, and to avoid gcc -Wempty-body warning.
1388 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1389 a block, when the outer 'i' will do.
1390 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1391 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1392 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1393 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1394 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1395 Rename locals to avoid shadowing.
1396 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1397 * coding.c (emacs_mule_char, encode_invocation_designation):
1398 Now static, since they're not used elsewhere.
1399 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1400 (decode_coding_object, encode_coding_object, detect_coding_system):
1401 (decode_coding_emacs_mule): Mark variables that gcc
1402 -Wuninitialized does not deduce are never used uninitialized.
1403 (detect_coding_iso_2022): Initialize a local variable that might
1404 be used uninitialized. Leave a FIXME because it's not clear that
1405 this initialization is needed. (Bug#8211)
1406 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1407 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1408 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1409 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1410 Remove unused macros.
1411
1412 * category.c (hash_get_category_set): Remove unused local var.
1413 (copy_category_table): Now static, since it's not used elsewhere.
1414 * character.c (string_count_byte8): Likewise.
1415
1416 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1417 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1418
1419 * chartab.c (copy_sub_char_table): Now static, since it's not used
1420 elsewhere.
1421 (sub_char_table_ref_and_range, char_table_ref_and_range):
1422 Rename locals to avoid shadowing.
1423 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1424
1425 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1426 (BIDI_BOB): Remove unused macro.
1427
1428 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1429 deduce are never used uninitialized.
1430 * term.c (encode_terminal_code): Likewise.
1431
1432 * term.c (encode_terminal_code): Now static. Remove unused local.
1433
1434 * tparam.h: New file.
1435 * term.c, tparam.h: Include it.
1436 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1437 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1438 Move these decls to tparam.h, and make them agree with what
1439 is actually in tparam.c. The previous trick of using incompatible
1440 decls in different modules does not conform to the C standard.
1441 All callers of tparam changed to use tparam's actual API.
1442 * tparam.c (tparam1, tparam, tgoto):
1443 Use const pointers where appropriate.
1444
1445 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1446 * cm.h (struct cm): Likewise.
1447 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1448 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1449 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1450 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1451 (turn_on_face, init_tty): Likewise.
1452 * termchar.h (struct tty_display_info): Likewise.
1453
1454 * term.c (term_mouse_position): Rename local to avoid shadowing.
1455
1456 * alloc.c (mark_ttys): Move decl from here ...
1457 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1458
1459 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1460
1461 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1462
1463 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1464
1465 * search.c (compile_pattern_1): Remove argument regp, unused since
1466 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1467 (compile_pattern): Don't pass it.
1468
1469 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1470
1471 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1472 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1473 for ! HAVE_GTK3.
1474 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1475
1476 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1477
1478 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1479 gdk_window_get_screen, gdk_window_get_geometry,
1480 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1481 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1482 (xg_get_pixbuf_from_pixmap): New function.
1483 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1484 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1485 Call xg_get_pixbuf_from_pixmap instead of
1486 gdk_pixbuf_get_from_drawable.
1487 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1488 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1489 (xg_check_special_colors): Use GtkStyleContext and its functions
1490 for HAVE_GTK3.
1491 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1492 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1493 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1494 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1495 Call gtk_widget_get_preferred_size.
1496 (xg_frame_resized): gdk_window_get_geometry only takes 5
1497 parameters.
1498 (xg_win_to_widget, xg_event_is_for_menubar):
1499 Call gdk_x11_window_lookup_for_display.
1500 (xg_set_widget_bg): New function.
1501 (delete_cb): New function.
1502 (xg_create_frame_widgets): connect delete-event to delete_cb.
1503 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1504 (xg_set_background_color): Call xg_set_widget_bg.
1505 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1506 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1507 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1508 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1509 if ! HAVE_GTK3.
1510 (update_frame_tool_bar): Call gtk_widget_hide.
1511 (xg_initialize): Use GDK_KEY_g.
1512
1513 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1514 if ! HAVE_GTK3
1515 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1516
1517 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1518 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1519 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1520
1521 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1522
1523 * w32xfns.c (select_palette): Check success of RealizePalette against
1524 GDI_ERROR, not zero.
1525
1526 See ChangeLog.11 for earlier changes.
1527
1528 ;; Local Variables:
1529 ;; coding: utf-8
1530 ;; End:
1531
1532 Copyright (C) 2011 Free Software Foundation, Inc.
1533
1534 This file is part of GNU Emacs.
1535
1536 GNU Emacs is free software: you can redistribute it and/or modify
1537 it under the terms of the GNU General Public License as published by
1538 the Free Software Foundation, either version 3 of the License, or
1539 (at your option) any later version.
1540
1541 GNU Emacs is distributed in the hope that it will be useful,
1542 but WITHOUT ANY WARRANTY; without even the implied warranty of
1543 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1544 GNU General Public License for more details.
1545
1546 You should have received a copy of the GNU General Public License
1547 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.