1 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
5 2012-07-29 Eli Zaretskii <eliz@gnu.org>
7 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
9 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
11 Cleanup statistics calculation in Fgarbage_collect.
12 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
13 zombies percentage calculation. Simplify elapsed time calculation.
15 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
17 Generalize marker debugging code under MARKER_DEBUG and use eassert.
18 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
19 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
20 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
21 (replace_range, replace_range_2, del_range_2): Change to eassert.
22 * marker.c (byte_char_debug_check): Adjust style.
24 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
26 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
27 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
28 long-ago-commented-out code that talks about "WIN32".
29 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
32 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
34 Use Gnulib stdalign module (Bug#9772, Bug#9960).
35 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
36 Simplify by using alignof.
37 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
38 * lisp.h: Include <stdalign.h>.
39 (GCALIGNMENT): New macro and constant.
40 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
41 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
42 (stdalign): New macro, if not already defined.
44 2012-07-28 Eli Zaretskii <eliz@gnu.org>
46 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
47 * w32inevt.c: Include w32inevt.h.
48 (w32_read_console_input): New inline function, calls either
49 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
50 w32_console_unicode_input.
51 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
52 (w32_kbd_patch_key, key_event): Use the codepage returned by
53 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
54 (key_event): use uChar.UnicodeChar only if
55 w32_console_unicode_input is non-zero.
57 * w32console.c: Include w32heap.h.
58 <w32_console_unicode_input>: New global variable.
59 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
60 family of Windows, zero otherwise.
62 * w32inevt.h: Declare w32_console_unicode_input.
64 * xdisp.c (init_iterator): Don't reference tip_frame in a build
65 --without-x. (Bug#11742)
67 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
69 Adjust GDB to reflect pvec_type changes (Bug#12036).
70 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
71 2012-07-04 changes to pseudovector representation. Problem
72 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
74 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
76 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
78 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
80 2012-07-27 Eli Zaretskii <eliz@gnu.org>
82 * alloc.c (listn): Fix the order the arguments are consed onto the
85 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
86 enumeration constants, as PURE and HEAP are too general, and clash
87 with other headers and sources, such as gmalloc.c and the
88 MS-Windows system headers. All users changed.
90 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
92 Revert last save_excursion_save and save_excursion_restore changes.
93 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
94 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
96 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
98 Fix recently-introduced typos in Windows port.
99 Reported by Martin Rudalics <rudalics@gmx.at>.
100 * w32.c (init_environment): Replace comma with semicolon.
101 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
103 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
105 Improve GDB symbol export (Bug#12036).
106 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
107 arms of an 'if', not using conditional expressions; otherwise GDB
108 complains about the types in the unevaluated arm when the argument
109 is an integer literal.
110 (xgetint): Simplify expression.
111 * alloc.c (gdb_make_enums_visible): New constant. This ports to
112 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
113 Zaretskii in <http://bugs.gnu.org/12036#13>.
114 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
115 needed now that we have gdb_make_enums_visible.
116 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
117 (enum enum_USE_LSB_TAG):
118 New enum types, packaging up enums that need to be exported to GDB.
120 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
122 Utility function to make a list from specified amount of objects.
123 * lisp.h (enum constype): New datatype.
124 (listn): New prototype.
125 * alloc.c (listn): New function.
126 (Fmemory_use_count, syms_of_alloc): Use it.
127 * buffer.c (syms_of_buffer): Likewise.
128 * callint.c (syms_of_callint): Likewise.
129 * charset.c (define_charset_internal): Likewise.
130 * coding.c (syms_of_coding): Likewise.
131 * keymap.c (syms_of_keymap): Likewise.
132 * search.c (syms_of_search): Likewise.
133 * syntax.c (syms_of_syntax): Likewise.
134 * w32.c (init_environment): Likewise.
135 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
136 * xdisp.c (syms_of_xdisp): Likewise.
137 * xfns.c (syms_of_xfns): Likewise.
139 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
141 Fast save_excursion_save and save_excursion_restore.
142 * lisp.h (struct Lisp_Excursion): New data type.
143 (PVEC_EXCURSION): New pseudovector type.
144 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
145 to deal with it. Adjust comments.
146 (init_marker, attach_marker): New prototype.
147 (unchain_marker): Adjust prototype.
148 * marker.c (attach_marker): Change to global.
149 (init_marker): New function.
150 * alloc.c (Fmake_marker, build_marker): Use it.
151 (build_marker): More easserts.
152 (mark_object): Handle struct Lisp_Excursion.
153 * editfns.c (save_excursion_save, save_excursion_restore):
154 Reimplement to use struct Lisp_Excursion. Add comments.
156 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
158 Fix export of symbols to GDB (Bug#12036).
159 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
160 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
161 emacs.c, as this is a more-suitable home. Had this been done earlier
162 the fix for 12036 would have avoided some of the problems noted in
163 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
164 would have been more obvious.
165 * emacs.c: Do not include <verify.h>; no longer needed.
166 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
167 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
168 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
169 Remove; now done in lisp.h.
170 * lisp.h (PUBLISH_TO_GDB): New macro.
171 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
172 (DATA_SEG_BITS): Use it.
173 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
174 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
175 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
176 not be usable in #if. This simplifies things.
178 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
180 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
182 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
184 Simplify export of symbols to GDB (Bug#12036).
185 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
186 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
187 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
188 Adjust to changes in lisp.h and emacs.c, by using
189 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
190 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
191 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
192 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
193 instead of gdb_valbits.
194 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
195 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
196 instead of gdb_array_mark_flag.
197 (xboolvector): Get size from $->size, not $->header.size.
198 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
199 (xreload, hook-run, hookpost-run): Remove.
200 * emacs.c: Include <verify.h>.
201 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
202 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
204 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
205 (gdb_USE_LSB_TAG): New enum constants.
206 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
207 Also define these as enum constants, so they're visible to GDB.
208 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
209 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
210 as constants, so they're visible to GDB.
211 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
212 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
213 Now enum constants, not macros, so they're visible to GDB.
214 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
215 more convenient now. All uses changed.
216 (VALMASK) [USE_LSB_TAG]: Also define in this case.
217 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
219 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
221 Explicitly free restriction data that are not needed anymore.
222 * editfns.c (save_restriction_restore): Free restriction data.
224 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
226 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
227 add argument, tune behavior, and adjust all callers.
229 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
231 Use typedef for EMACS_INT, EMACS_UINT.
232 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
233 than macros. This simplifies debugging in the usual case, since
234 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
235 and it allows expressions involving EMACS_INT casts.
236 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
238 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
240 * nsterm.m (ns_read_socket): Return early if there is a modal
243 2012-07-25 Martin Rudalics <rudalics@gmx.at>
245 * frame.c (Fredirect_frame_focus): In doc-string don't mention
246 that FOCUS-FRAME can be omitted.
248 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
250 Adjust buffer text indirection counters at the end of Fkill_buffer.
251 * buffer.c (Fkill_buffer): Adjust indirection counters when the
252 buffer is definitely dead. This should really fix an issue reported
253 by Christoph Scholtes again. (Bug#12007).
254 (init_buffer_once): Initialize indirection counters of
255 buffer_defaults and buffer_local_symbols (for sanity and safety).
257 2012-07-24 Eli Zaretskii <eliz@gnu.org>
259 * xdisp.c (init_iterator): Don't compute dimensions of truncation
260 and continuation glyphs on tooltip frames, leave them at zero.
261 Avoids continued lines in tooltips. (Bug#11832)
263 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
265 Simplify copy_overlay.
266 * buffer.c (copy_overlay): Simplify. Use build_marker.
267 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
269 2012-07-23 Eli Zaretskii <eliz@gnu.org>
271 * print.c (print_object): Don't crash when a frame's name is nil
272 or invalid. (Bug#12025)
274 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
275 it signals an error when a tooltip frame is being created.
277 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
279 Cleanup miscellaneous objects allocation and initialization.
280 * alloc.c (allocate_misc): Change to static. Add argument to
281 specify the subtype. Adjust comment and users.
282 (build_overlay): New function.
283 * buffer.c (copy_overlays, Fmake_overlay): Use it.
284 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
285 (allocate_misc): Remove prototype.
286 (build_overlay): Add prototype.
288 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
290 Swap buffer text indirection counters in Fbuffer_swap_text.
291 * buffer.c (Fbuffer_swap_text): Swap indirections too.
292 This avoids crash reported by Christoph Scholtes at
293 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
295 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
297 * nsmenu.m (Popdown_data): New struct.
298 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
300 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
301 (initWithContentRect): Make imgView and contentView non-static
302 and autorelease them. Also autorelease img and matrix (Bug#12005).
303 (dealloc): Remove (Bug#12005).
305 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
307 Adjust consing_since_gc when objects are explicitly freed.
308 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
309 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
310 (free_cons, free_misc): Subtract object size from consing_since_gc.
312 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
314 Simplify and cleanup markers positioning code.
315 * marker.c (attach_marker): More useful eassert.
316 (live_buffer, set_marker_internal): New function.
317 (Fset_marker, set_marker_restricted): Use set_marker_internal.
318 (set_marker_both, set_marker_restricted_both): Use live_buffer.
320 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
322 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
323 as it's limited by the amount of memory, not by INT_MAX.
325 2012-07-21 Eli Zaretskii <eliz@gnu.org>
327 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
328 in special-event-map. See the discussion at
329 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
332 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
333 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
334 Fabrice Popineau <fabrice.popineau@supelec.fr>.
336 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
338 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
339 (conversationIdentifier): Return value is NSInteger.
340 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
342 2012-07-21 Chong Yidong <cyd@gnu.org>
344 * window.c (decode_any_window): Signal an error if the window is
345 on a dead frame (Bug#11984).
347 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
349 Add indirection counting to speed up Fkill_buffer.
350 * buffer.h (struct buffer): New member.
351 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
352 (Fmake_indirect_buffer): Set indirection counter to -1, increment
353 base buffer indirection counter.
354 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
355 (Fkill_buffer): Adjust indirection counters as needed, don't walk
356 through buffer list if indirection counter is 0.
358 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
360 Extend the value returned by Fgarbage_collect with heap statistics.
361 * alloc.c (Qheap): New symbol.
362 (syms_of_alloc): DEFSYM it.
363 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
364 (Fmemory_free): Remove.
365 (syms_of_alloc): Don't defsubr it.
366 * buffer.c (Fcompact_buffer): Remove.
367 (syms_of_buffer): Don't defsubr it.
369 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
371 Make maybe_gc inline.
372 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
373 * lisp.h (consing_since_gc, gc_relative_threshold)
374 (memory_full_cons_threshold): Revert declaration.
375 (maybe_gc): Remove prototype, define as inline.
376 * alloc.c: Remove old commented-out code.
377 (consing_since_gc, gc_relative_threshold)
378 (memory_full_cons_threshold): Revert to global.
381 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
383 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
384 * lisp.h (build_unibyte_string): New function.
385 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
386 * sysdep.c, w32fns.c, xfns.c: Use it.
387 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
388 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
389 Adjust users accordingly.
390 * font.h (font_open_by_name): Adjust prototype.
392 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
394 Cleanup calls to Fgarbage_collect.
395 * lisp.h (maybe_gc): New prototype.
396 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
398 * alloc.c (maybe_gc): New function.
399 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
401 * bytecode.c (MAYBE_GC): Use maybe_gc.
402 * eval.c (eval_sub, Ffuncall): Likewise.
403 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
404 to avoid dependency from auto-save feature.
406 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
408 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
409 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
410 'for_each_per_buffer_object_at'.
411 All uses changed. It's better to use upper-case for macros that
412 cannot be implemented as functions, to give the reader a clue
413 that they're special.
415 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
417 * alloc.c (Fgarbage_collect): Tweak docstring.
419 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
421 Tweak the value returned from Fgarbage_collect again.
422 * alloc.c (Fgarbage_collect): New return value, as confirmed in
423 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
424 Adjust documentation.
425 (total_vector_bytes): Rename to total_vector_slots, adjust
427 (total_free_vector_bytes): Rename to total_free_vector_slots,
429 (Qstring_bytes, Qvector_slots): New symbols.
430 (syms_of_alloc): DEFSYM them.
432 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
434 Buffer compaction primitive which may be used from Lisp.
435 * buffer.c (compact_buffer, Fcompact_buffer): New function.
436 (syms_of_buffer): Register Fcompact_buffer.
437 * alloc.c (Fgarbage_collect): Use compact_buffer.
438 * buffer.h (compact_buffer): New prototype.
439 (struct buffer_text): New member.
441 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
443 New macro to iterate over all buffers, miscellaneous cleanups.
444 * lisp.h (all_buffers): Remove declaration.
445 * buffer.h (all_buffers): Add declaration, with comment.
446 (for_each_buffer): New macro.
447 * alloc.c (Fgarbage_collect, mark_object): Use it.
448 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
449 (init_buffer): Likewise.
450 * data.c (Fset_default): Likewise.
451 * coding.c (code_conversion_restore): Remove redundant check
453 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
455 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
457 Fix bug that created negative-length intervals.
458 * intervals.c (merge_interval_right, merge_interval_left):
459 Do not zero out this interval if it is absorbed by its children,
460 as this interval's total length doesn't change in that case. See
461 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
463 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
465 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
466 when invoking (make-bool-vector N t) and N is a positive
467 multiple of 8 -- the last 8 bits were mistakenly cleared.
469 Remove some struct layout assumptions in bool vectors.
470 * alloc.c (bool_header_size): New constant.
471 (header_size, word_size): Move earlier, as they're now used earlier.
472 Use 'word_size' in a few more places, where it's appropriate.
473 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
474 padding before the data member of a bool vector.
475 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
476 than doing the check by hand with an abort ().
478 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
480 * eval.c (Fdefvar): Don't check constants since we only set the var if
481 it's not yet defined anyway (bug#11904).
483 * lisp.h (last_undo_boundary): Declare new var.
484 * keyboard.c (command_loop_1): Set it.
485 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
486 were auto-added by the command loop (bug#11774).
488 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
490 * w32font.c (Qsymbol): Remove local definition.
491 (syms_of_w32font): Don't DEFSYM it.
493 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
495 Fix sweep_vectors to handle large bool vectors correctly.
496 * alloc.c (sweep_vectors): Account total_vector_bytes for
497 bool vectors larger than VBLOCK_BYTES_MAX.
499 2012-07-18 Chong Yidong <cyd@gnu.org>
501 * frame.c (x_set_frame_parameters): Revert bogus change introduced
502 in 2012-05-25 commit by Paul Eggert (Bug#11738).
504 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
506 Return more descriptive data from Fgarbage_collect.
507 Suggested by Stefan Monnier in
508 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
509 * alloc.c (bounded_number): New function.
510 (total_buffers, total_vectors): New variable.
511 (total_string_size): Rename to total_string_bytes, adjust users.
512 (total_vector_size): Rename to total_vector_bytes, adjust users.
513 (sweep_vectors): Account total_vectors and total_vector_bytes.
514 (Fgarbage_collect): New return value. Adjust documentation.
515 (gc_sweep): Account total_buffers.
516 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
517 (VECTOR_SIZE): Remove.
518 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
519 (Qinterval, Qmisc): New symbols.
520 (syms_of_data): Initialize them.
521 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
522 (Qcons, Qbuffer): New declarations.
524 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
526 * alloc.c (Fmemory_free): Account for memory-free's own storage.
527 Round up, not down. Improve doc.
529 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
531 Restore old code in allocate_string_data to avoid Faset breakage.
532 Reported by Julien Danjou <julien@danjou.info> in
533 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
534 * alloc.c (allocate_string_data): Restore old code with minor
535 adjustments, fix comment to explain this subtle issue.
537 2012-07-17 Eli Zaretskii <eliz@gnu.org>
539 Remove FILE_SYSTEM_CASE.
540 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
542 * fileio.c (FILE_SYSTEM_CASE): Don't define.
543 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
544 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
545 call-process-region passes it through expand-file-name.
547 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
549 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
551 Fix crash when creating indirect buffer (Bug#11917)
552 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
553 Don't handle unbound variables specially if non-zero.
554 (Fbuffer_local_variables): Pass zero.
555 (clone_per_buffer_values): Pass non-zero.
557 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
559 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
560 to make the loop interruptible.
562 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
564 * gnutls.c (emacs_gnutls_handshake): Only retry if
565 GNUTLS_E_INTERRUPTED.
567 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
569 Cleanup and convert miscellaneous checks to eassert.
570 * alloc.c (mark_interval): Fix comment, partially rephrase
571 old comment from intervals.h (see below).
572 * intervals.c (find_interval, adjust_intervals_for_insertion)
573 (delete_interval, adjust_intervals_for_deletion)
574 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
576 (adjust_intervals_for_insertion, make_new_interval):
577 Remove obsolete and unused code.
578 * intervals.h (struct interval): Remove obsolete comment.
579 * textprotp.c (erase_properties): Remove unused code.
580 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
581 (Fremove_list_of_text_properties): Convert to eassert.
583 2012-07-17 Chong Yidong <cyd@gnu.org>
585 * editfns.c (Finsert_char): Doc fix.
587 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
589 Fix previous change to make Fmemory_free always accurate.
590 * alloc.c (make_interval): Update total_free_intervals.
591 (make_float): Likewise for total_free_floats.
592 (free_cons, Fcons): Likewise for total_free_conses.
593 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
594 Likewise for total_free_vector_bytes.
595 (Fmake_symbol): Likewise for total_free_symbols.
596 (bytes_free): Remove.
598 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
600 Simple free memory accounting feature.
601 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
602 (sweep_vectors): Accumulate size of free vectors.
603 (Fgarbage_collect): Setup bytes_free.
604 (Fmemory_free): New function.
605 (syms_of_alloc): Register it.
607 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
609 Cleanup overlays checking.
610 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
611 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
612 eassert and OVERLAYP.
613 (sort_overlays): Change to use OVERLAYP.
615 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
617 * editfns.c (Finsert_char): Make it interactive, and make the
618 second arg optional. Copy interactive spec and docstring from
621 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
623 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
624 Unlike the other wrapped functions, fabs has an unspecified
627 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
629 * nsterm.m (keyDown): Interpret flags without left/right bits
630 as the left key (Bug#11670).
632 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
634 Remove empty and useless init functions.
635 * lisp.h (init_character_once, init_fns, init_image)
636 (init_filelock, init_sound): Remove prototype.
637 * character.c (init_character_once): Remove.
638 * filelock.c (init_filelock): Likewise.
639 * fns.c (init_fns): Likewise.
640 * image.c (init_image): Likewise.
641 * sound.c (init_sound): Likewise.
642 * emacs.c (main): Adjust accordingly.
644 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
646 * gtkutil.h: Tiny cleanups.
647 (use_old_gtk_file_dialog): Remove useless declaration.
648 (xg_uses_old_file_dialog): Add suggested const attribute.
650 2012-07-15 Eli Zaretskii <eliz@gnu.org>
652 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
653 (bidi_paragraph_init): Use it to limit search forward for a strong
654 directional character in abnormally large paragraphs full of
655 neutral or weak characters. (Bug#11943)
657 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
659 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
660 the toolbar (Bug#9451).
661 (xg_make_tool_item): Give the widget event box a transparent
664 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
666 Cleanup basic allocation variables and functions.
667 * alloc.c (ignore_warnings, init_intervals, init_float)
668 (init_cons, init_symbol, init_marker): Remove.
669 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
670 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
671 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
672 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
673 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
674 (staticidx, init_alloc_once, init_strings, free_ablock):
675 Remove redundant initialization.
676 * fns.c (init_weak_hash_tables): Remove.
677 * lisp.h (init_weak_hash_tables): Remove prototype.
679 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
681 Use zero_vector where appropriate.
682 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
684 * lisp.h (zero_vector): New declaration.
685 * font.c (null_vector): Remove.
686 (syms_of_font): Remove initialization and staticpro.
687 (font_list_entities, font_find_for_lface): Change to use zero_vector.
688 * keymap.c (Faccessible_keymaps): Likewise.
690 2012-07-15 Leo Liu <sdl.web@gmail.com>
692 * fringe.c: Fix typo in comments.
694 2012-07-14 Leo Liu <sdl.web@gmail.com>
696 * fringe.c: Add a new bitmap exclamation-mark.
698 2012-07-14 Eli Zaretskii <eliz@gnu.org>
700 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
702 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
703 (HAVE_MENUS): Don't define, defined by editing config.in with
705 (GMALLOC_INHIBIT_VALLOC): Don't define.
706 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
708 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
710 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
712 2012-07-14 Glenn Morris <rgm@gnu.org>
714 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
715 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
716 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
718 2012-07-13 Glenn Morris <rgm@gnu.org>
720 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
722 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
723 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
725 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
727 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
728 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
729 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
730 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
732 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
733 as boolean expression.
734 (x_set_window_size): Remove unused variable toolbar.
735 (ns_get_color_default, ns_mod_to_lisp): Remove.
736 (ns_mouse_position): Remove unused variables xchar and ychar.
737 (ns_compute_glyph_string_overhangs): Remove unused variable face.
738 (ns_set_vertical_scroll_bar): Remove unused variable count.
739 (ns_delete_terminal): Remove unused variable i.
740 (ns_term_init): Remove unused variables r, g and b.
741 (mouseDown): Remove unused variable window.
742 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
743 (initFrameFromEmacs): Remove unused variable vbextra.
744 (mouseEntered): Remove unused variables p and dpyinfo.
745 (mouseExited): Remove unused variables p and r.
746 (ns_define_frame_cursor, ns_clear_frame_area)
747 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
748 (menuDown): Assign [sender tag] to variable and cast the variable.
750 * nsterm.h (menuDown): Add id as type to argument sender.
751 (ns_display_info_for_name): Add Lisp_Object argument.
752 (ns_term_init): Add Lisp_Object argument.
753 (ns_map_event_to_object): Add void argument.
754 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
755 prototype with arguments and only declare if __OBJC__.
756 (nxatoms_of_nsselect): Add void argument.
757 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
758 (ns_alloc_autorelease_pool): Add void argument.
759 (ns_release_autorelease_pool): Add void* argument.
760 (ns_get_defaults_value): Add const char* argument.
762 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
763 (initFromContents): Use SSDATA where appropriate.
764 (ns_update_menubar): Add braces to ambigous if-else.
765 (initWithTitle): Put () around assignment in if statement.
766 (ns_menu_show): Remove unused variables window and keymap.
767 (update_frame_tool_bar): Remove unused variable selected_p.
768 (initWithContentRect): Remove unused variable this_cmd_name.
770 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
772 (setXBMColor): Remove unused variable len.
773 (setPixmapData): Put () around assignment in loop statement.
775 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
776 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
778 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
779 around assignment in loop statement.
780 (nsfont_open): Remove unused variable i.
781 (nsfont_open): Remove unused variable len.
782 (nsfont_draw): Remove unused variable cs.
784 * nsfns.m (x_set_icon_name, ns_set_name_internal)
785 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
786 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
787 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
788 (Fns_font_name, Fns_perform_service)
789 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
790 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
791 (ns_set_name): Remove unused variable view.
792 (x_set_menu_bar_lines): Remove unused variable olines.
793 (x_set_tool_bar_lines): Remove unused variable root_window.
794 (Fns_list_colors): Put () around assignment in while statement.
795 (Fns_perform_service): Remove unused variable len.
796 (Fns_display_usable_bounds): Remove unused variable top.
797 (syms_of_nsfns): Remove unused variable i.
799 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
802 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
804 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
805 and free it with DestroyExceptionInfo (Bug#11558).
807 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
809 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
810 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
811 Set here, not in nt/config.nt.
813 2012-07-13 Eli Zaretskii <eliz@gnu.org>
815 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
816 cursor overflow into the last glyph on display line when the right
817 fringe is off. (Bug#11832)
819 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
821 * xdisp.c (produce_special_glyphs): Now static.
822 * dispextern.h (produce_special_glyphs): Remove decl.
824 2012-07-13 Glenn Morris <rgm@gnu.org>
826 * s/bsd-common, s/cygwin.h: Remove empty files.
827 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
829 * s/usg5-4-common.h (USG, USG5):
830 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
831 * s/sol2-6.h (SOLARIS2):
832 * s/irix6-5.h (IRIX6_5):
833 * s/hpux10-20.h (USG, USG5, HPUX):
834 * s/gnu-linux.h (USG, GNU_LINUX):
835 * s/freebsd.h (BSD_SYSTEM):
836 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
837 * s/cygwin.h (CYGWIN):
838 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
839 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
841 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
843 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
845 2012-07-13 Glenn Morris <rgm@gnu.org>
847 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
849 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
851 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
852 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
854 2012-07-12 Glenn Morris <rgm@gnu.org>
856 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
858 * process.c (init_process_emacs): Rename from init_process.
859 The old name is also the name of a Mach system call.
860 * lisp.h, emacs.c: Update for this name change.
861 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
864 2012-07-12 Eli Zaretskii <eliz@gnu.org>
866 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
867 memmove call that removes glyphs covered by the left truncation
868 glyph. Improve commentary.
869 (display_line): Fix display of continuation glyphs on GUI frames
870 when the right fringe is turned off and variable-size fonts are
871 used in the window. Move the code that appends a stretch glyph to
872 produce_special_glyphs, so that it could be used for truncation
873 and continuation glyphs alike.
874 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
875 glyph of a suitably computed width, to align the special glyphs at
876 the window margin. Code moved from display_line. (Bug#11832)
878 2012-07-12 Glenn Morris <rgm@gnu.org>
880 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
882 * s/gnu-linux.h, s/hpux10-20.h:
883 Do not unconditionally define HAVE_XRMSETDATABASE.
885 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
887 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
889 Fix typos that broke OS X build.
890 Reported by Randal L. Schwartz in
891 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
892 * nsterm.m (ns_timeout): Add missing local decl.
893 (ns_get_color): snprintf -> sprintf, to fix typo.
895 2012-07-12 Glenn Morris <rgm@gnu.org>
897 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
898 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
899 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
900 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
902 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
903 Move PTY_OPEN to configure.
905 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
906 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
907 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
909 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
911 Use empty_unibyte_string where applicable.
912 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
913 * lread.c (read1): Likewise.
914 * xsettings.c (syms_of_xsettings): Likewise.
916 2012-07-12 Glenn Morris <rgm@gnu.org>
918 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
919 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
920 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
921 * s/hpux10-20.h (RUN_TIME_REMAP):
922 * s/bsd-common.h (TABDLY): Move to configure.
924 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
926 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
928 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
929 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
931 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
933 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
934 * s/template.h: Move NARROWPROTO to configure.
936 2012-07-11 Glenn Morris <rgm@gnu.org>
938 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
939 unused since 2011-01-17 change to systty.h.
941 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
942 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
943 Move HAVE_PTYS and HAVE_SOCKETS to configure.
945 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
947 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
949 2012-07-11 Glenn Morris <rgm@gnu.org>
951 * s/darwin.h, s/gnu-linux.h, s/template.h:
952 Move INTERRUPT_INPUT to configure.
954 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
956 Minor adjustments to interning code.
957 * lisp.h (intern, intern_c_string): Redefine as static inline
958 wrappers for intern_1 and intern_c_string_1, respectively.
959 (intern_1, intern_c_string_1): Rename prototypes.
960 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
962 * font.c (font_intern_prop): Likewise. Adjust comment.
963 * w32font.c (intern_font_name): Likewise.
965 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
967 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
969 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
970 of Fcar/Fcdr if possible.
971 * font.c (check_otf_features): Likewise.
972 * fontset.c (Fnew_fontset): Likewise.
973 * gnutls.c (Fgnutls_boot): Likewise.
974 * minibuf.c (read_minibuf): Likewise.
975 * msdos.c (IT_set_frame_parameters): Likewise.
976 * xmenu.c (Fx_popup_dialog): Likewise.
977 * w32menu.c (Fx_popup_dialog): Likewise.
979 2012-07-11 Glenn Morris <rgm@gnu.org>
981 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
982 since nothing has defined it on these platforms.
984 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
985 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
987 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
988 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
989 Move CLASH_DETECTION to configure.
991 * s/gnu.h: Remove file, which is now empty.
993 * s/gnu.h, s/gnu-linux.h:
994 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
996 2012-07-11 John Wiegley <johnw@newartisans.com>
998 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
999 function attribute, so we only use it if it exists in the
1002 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1004 Avoid call to strlen in fast_c_string_match_ignore_case.
1005 * search.c (fast_c_string_match_ignore_case): Change to use
1006 length argument. Adjust users accordingly.
1007 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1009 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1011 Assume mkdir, rmdir.
1012 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1013 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1016 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1019 * s/hpux10-20.h (HAVE_PERROR): Remove.
1020 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1021 Remove dummy definition, as this problem was obsolete long ago.
1024 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1026 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1028 Avoid calls to strlen in font processing functions.
1029 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1030 (font_open_by_name): Change to use length argument. Adjust
1032 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1034 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1035 Change to return ptrdiff_t.
1036 (xfont_list_pattern, xfont_match): Use length returned by
1037 xfont_decode_coding_xlfd.
1038 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1040 2012-07-11 Glenn Morris <rgm@gnu.org>
1042 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1043 Move DONT_REOPEN_PTY to configure.
1045 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1046 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1048 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1050 Remove "#define unix" that is no longer needed (Bug#11905).
1051 * s/aix4-2.h (unix): Remove; no longer needed.
1053 EMACS_TIME simplification (Bug#11875).
1054 This replaces macros (which typically do not work in GDB)
1055 with functions, typedefs and enums, making the code easier to debug.
1056 The functional style also makes code easier to read and maintain.
1057 * systime.h: Include <sys/time.h> on all hosts, not just if
1058 WINDOWSNT, since 'struct timeval' is needed in general.
1059 (EMACS_TIME): Now a typedef, not a macro.
1060 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1062 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1063 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1064 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1065 (EMACS_TIME_LE): Now functions, not macros.
1066 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1067 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1068 which are not functions. All uses rewritten to use:
1069 (make_emacs_time): New function.
1070 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1071 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1072 not functions. All uses rewritten to use the following, respectively:
1073 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1074 (add_emacs_time, sub_emacs_time): New functions.
1075 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1076 * fileio.c (Fcopy_file):
1077 * xterm.c (XTflash): Get the current time closer to when it's used.
1078 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1080 * bytecode.c (targets): Suppress -Woverride-init warnings.
1082 Simplify by avoiding confusing use of strncpy etc.
1083 * doc.c (Fsnarf_documentation):
1084 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1085 * frame.c (Fmake_terminal_frame):
1086 * gtkutil.c (get_utf8_string):
1088 * nsmenu.m (ns_update_menubar):
1089 * regex.c (regerror):
1090 Prefer memcpy to strncpy and strncat when either will do.
1091 * fileio.c (Fsubstitute_in_file_name):
1092 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1093 (menu_separator_name_p):
1094 * nsmenu.m (ns_update_menubar):
1095 Prefer memcmp to strncmp when either will do.
1096 * nsterm.m: Include <ftoastr.h>.
1098 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1099 Prefer snprintf to strncpy.
1100 * nsterm.m (ns_term_init):
1101 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1102 * nsterm.m (ns_term_init):
1103 Avoid the need for strncpy, by using build_string or
1104 make_unibyte_string directly. Use dtoastr, not snprintf.
1105 * process.c (Fmake_network_process): Diagnose service names that
1106 are too long, rather than silently truncating them or creating
1107 non-null-terminated names.
1108 (Fnetwork_interface_info): Likewise, for interface names.
1109 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1110 Prefer sprintf to strncat.
1111 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1112 Prefer vsnprintf to vsprintf + strncpy.
1114 2012-07-10 Glenn Morris <rgm@gnu.org>
1116 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1117 Clarify fallback case.
1119 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1121 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1122 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1123 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1124 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1125 where argument type is known to be a Lisp_Cons.
1127 2012-07-10 Tom Tromey <tromey@redhat.com>
1129 * bytecode.c (BYTE_CODE_THREADED): New macro.
1130 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1131 (enum byte_code_op): New type.
1132 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1133 (exec_byte_code): Use them. Use token threading when applicable.
1135 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1137 Optimize pure C strings initialization.
1138 * lisp.h (make_pure_string): Fix prototype.
1139 (build_pure_c_string): New function, defined as static inline. This
1140 provides a better opportunity to optimize away calls to strlen when
1141 the function is called with compile-time constant argument.
1142 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1143 argument, adjust users accordingly. Use build_pure_c_string where
1145 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1146 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1147 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1149 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1151 Avoid calls to strlen in miscellaneous functions.
1152 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1153 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1154 * lread.c (openp): Likewise.
1156 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1158 Avoid calls to strlen in path processing functions.
1159 * fileio.c (file_name_as_directory): Add comment. Change to add
1160 srclen argument and return the length of result. Adjust users
1162 (directory_file_name): Fix comment. Change to add srclen argument,
1163 swap 1st and 2nd arguments to obey the common convention. Adjust
1165 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1167 2012-07-10 Glenn Morris <rgm@gnu.org>
1169 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1170 Move PENDING_OUTPUT_COUNT definition to configure.
1172 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1173 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1174 * s/gnu.h (DATA_START): Move definitions to configure.
1176 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1177 We include usg5-4-common.h, which defines them both.
1179 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1180 O_RDONLY already includes it).
1182 Stop ns builds setting the EMACSLOADPATH environment variable.
1183 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1184 Now it does not set EMACSLOADPATH, just returns the load-path string.
1185 * nsterm.h: Update accordingly.
1186 * lread.c [HAVE_NS]: Include nsterm.h.
1187 (init_lread) [HAVE_NS]: Use ns_load_path.
1188 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1190 2012-07-09 Glenn Morris <rgm@gnu.org>
1192 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1193 since the included bsd-common.h does so.
1195 Stop ns builds setting the EMACSPATH environment variable.
1196 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1197 (ns_init_paths): Do not set EMACSPATH.
1198 * nsterm.h (ns_exec_path): Add it.
1199 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1202 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1204 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1206 * process.c (wait_reading_process_output): 'waitchannels' was unset
1207 when read_kbd || !NILP (wait_for_cell); fix this.
1209 Add GCC-style 'const' attribute to functions that can use it.
1210 * character.h (char_resolve_modifier_mask):
1211 * keyboard.h (make_ctrl_char):
1212 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1213 (init_character_once, next_almost_prime, init_fns, init_image)
1214 (flush_pending_output, init_sound):
1215 * mem-limits.h (start_of_data):
1216 * menu.h (finish_menu_items):
1217 Add ATTRIBUTE_CONST.
1218 * emacs.c (DEFINE_DUMMY_FUNCTION):
1219 Declare the dummy function with ATTRIBUTE_CONST.
1220 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1221 Add decls with ATTRIBUTE_CONST.
1223 Minor improvements to make_formatted_string.
1224 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1225 where int is good enough, as vsprintf returns an int.
1226 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1228 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1230 Use make_formatted_string to avoid double length calculation.
1231 * lisp.h (make_formatted_string): New prototype.
1232 * alloc.c (make_formatted_string): New function.
1233 * buffer.c (Fgenerate_new_buffer_name): Use it.
1234 * dbus.c (syms_of_dbusbind): Likewise.
1235 * editfns.c (Fcurrent_time_zone): Likewise.
1236 * filelock.c (get_boot_time): Likewise.
1237 * frame.c (make_terminal_frame, set_term_frame_name)
1238 (x_report_frame_params): Likewise.
1239 * image.c (gs_load): Likewise.
1240 * minibuf.c (get_minibuffer): Likewise.
1241 * msdos.c (dos_set_window_size): Likewise.
1242 * process.c (make_process): Likewise.
1243 * xdisp.c (ensure_echo_area_buffers): Likewise.
1244 * xsettings.c (apply_xft_settings): Likewise.
1246 2012-07-09 Glenn Morris <rgm@gnu.org>
1248 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1249 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1250 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1251 * nsterm.h (ns_etc_directory): Add it.
1252 * callproc.c [HAVE_NS]: Include nsterm.h.
1253 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1255 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1257 Move marker debugging code under MARKER_DEBUG.
1258 * marker.c (MARKER_DEBUG): Move marker debugging code under
1259 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1260 for bootstrap with --enable-checking (~3x slowdown reported
1261 by Juanma Barranquero <lekktu@gmail.com>).
1262 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1264 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1266 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1267 See <http://bugs.gnu.org/11825#29>.
1269 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1271 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1272 has no font, use the frame's font. (Bug#11813)
1273 (display_line): Add commentary about displaying truncation glyphs
1275 (produce_special_glyphs): Move here from term.c.
1277 * term.c (produce_special_glyphs): Move to xdisp.c.
1279 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1282 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1284 * xdisp.c (display_line): Avoid warning about implicit declaration
1287 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1289 * lisp.h: Remove empty conditional.
1291 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1293 * lread.c (load_path_check): Now static.
1295 Fix some minor --with-ns problems found by static checking.
1296 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1297 (x_set_font) [!HAVE_X_WINDOWS]:
1298 * image.c (xpm_load_image) [HAVE_NS]:
1299 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1300 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1301 Remove unused local.
1302 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1303 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1304 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1305 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1306 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1307 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1308 Fix pointer signedness problem.
1309 * xfaces.c (FRAME_X_FONT_TABLE):
1310 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1312 2012-07-07 Glenn Morris <rgm@gnu.org>
1314 * lread.c (load_path_check): New function, split from init_lread.
1315 (init_lread): Reorganize. Motivation:
1316 If EMACSLOADPATH is set, check/warn about that rather than the
1317 defaults, which we are not going to use. Hence we can remove
1318 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1319 Don't warn if site-lisp directories are missing.
1320 If not installed, start from a blank load-path, since
1321 PATH_LOADSEARCH refers to the eventual installation directories.
1323 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1325 Support truncation and continuation glyphs on GUI frames, when
1326 fringes are disabled. (Bug#11832)
1327 * xdisp.c (init_iterator): Get dimensions of truncation and
1328 continuation glyphs even if on GUI frames. Adjust
1329 it->last_visible_x on GUI frames when the left or right fringes,
1330 or both, are absent.
1331 (start_display, move_it_in_display_line_to): Handle the case of a
1332 GUI frame without a fringe to display continuation or truncation
1334 (insert_left_trunc_glyphs): Support GUI frames: make sure
1335 truncation glyphs overwrite enough glyphs from the current line to
1336 have sufficient space in pixels.
1337 (display_line): Support truncation and continuation glyphs on GUI
1338 frames. If some spare pixels are left on the line after inserting
1339 the truncation glyphs, fill that space with a stretch glyph of a
1340 suitably computed width.
1342 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1343 produce_glyphs, to support GUI sessions.
1345 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1347 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1349 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1351 Do not require float-time's arg to fit in time_t (Bug#11825).
1352 This works better on hosts where time_t is unsigned, and where
1353 float-time is applied to the (negative) difference between two times.
1354 * editfns.c (decode_time_components): Last arg is now double *,
1355 not int *, and means to store all the result as a double, without
1356 worrying about whether the seconds part fits in time_t.
1357 All callers changed.
1358 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1359 All callers changed.
1360 (Ffloat_time): Do not fail merely because the specified time falls
1361 outside of time_t range.
1363 2012-07-07 Glenn Morris <rgm@gnu.org>
1365 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1366 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1367 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1369 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1371 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1372 Update dependencies.
1374 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1376 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1378 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1379 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1380 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1381 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1382 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1383 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1385 * xfont.c (compare_font_names): Redo to omit the need for casts.
1387 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1389 * xfns.c (Fx_change_window_property): Doc fix.
1390 * w32fns.c (Fx_change_window_property): Doc fix.
1392 * w32fns.c (Fx_window_property): Accept the same arguments as the
1393 X Windows version. Doc fix.
1394 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1396 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1397 Eli Zaretskii <eliz@gnu.org>
1399 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1400 Windows-specific code from nt/config.nt moved here.
1401 Obsolete settings removed.
1403 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1405 * process.c: Avoid unnecessary calls to gettime.
1406 (wait_reading_process_output): Don't get the time of day
1407 when gobbling data immediately and not waiting, as there's no need
1408 for it in that case. This removes a FIXME.
1410 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1412 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1413 is defined (Bug#11768).
1415 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1417 Fix marker debugging code.
1418 * marker.c (byte_char_debug_check): Do not perform the check
1419 if buffer is not multibyte.
1420 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1421 Call byte_char_debug_check with correct arguments.
1423 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1425 Compile marker debugging code only if ENABLE_CHECKING is defined.
1426 * marker.c (byte_char_debug_check, count_markers):
1427 Use only if ENABLE_CHECKING is defined.
1428 (byte_debug_flag): Remove.
1429 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1430 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1432 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1434 Avoid code repetition in marker-related functions.
1435 * marker.c (attach_marker): New function.
1436 (Fset_marker, set_marker_restricted, set_marker_both)
1437 (set_marker_restricted_both): Use it.
1438 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1439 Consistently rename charno to charpos.
1440 (marker_position): Add eassert.
1441 (marker_byte_position): Convert to eassert.
1443 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1445 Simplify list operations in unchain_overlay and unchain_marker.
1446 * buffer.c (unchain_overlay): Simplify. Add comment.
1447 * marker.c (unchain_marker): Simplify. Fix comments.
1449 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1451 Introduce fast path for the widely used marker operation.
1452 * alloc.c (build_marker): New function.
1453 * lisp.h (build_marker): New prototype.
1454 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1455 * composite.c (autocmp_chars): Likewise.
1456 * editfns.c (buildmark): Remove.
1457 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1458 (save_restriction_save): Use build_marker.
1459 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1460 * window.c (save_window_save): Likewise.
1462 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1464 Do not use Fdelete_overlay in delete_all_overlays
1465 to avoid redundant calls to unchain_overlay.
1466 * buffer.c (drop_overlay): New function.
1467 (delete_all_overlays, Fdelete_overlay): Use it.
1468 * minibuf.c (get_minibuffer): Fix comment.
1470 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1472 Port to OpenBSD 5.1 amd64.
1473 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1474 This is needed for OpenBSD, and should be harmless on all BSD systems.
1475 Also, include <sys/sysctl.h>, as it should be available on all
1476 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1477 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1478 use p_pid member, not kp_proc.pid.
1480 2012-07-06 Glenn Morris <rgm@gnu.org>
1482 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1484 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1486 More xmalloc and related cleanup.
1487 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1488 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1489 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1490 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1491 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1492 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1493 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1494 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1495 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1497 Omit needless casts involving void * pointers and allocation.
1498 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1499 as the former is more robust if P's type is changed.
1500 Prefer xzalloc to xmalloc + memset 0.
1501 Simplify malloc-or-realloc to realloc.
1502 Don't worry about xmalloc returning a null pointer.
1503 Prefer xstrdup to xmalloc + strcpy.
1504 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1506 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1507 alloca of a constant.
1509 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1511 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1512 hscroll is larger than the line width. Fixes long and futile
1513 looping inside extend_face_to_end_of_line (on a TTY) producing
1514 glyphs that are not needed and thrown away.
1516 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1518 * marker.c (set_marker_restricted_both): Simplify by using
1521 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1523 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1525 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1527 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1528 not defined (Bug#11768).
1529 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1530 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1531 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1532 followed by gtk_box_set_homogeneous (Bug#11768).
1533 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1534 (update_theme_scrollbar_width, xg_create_scroll_bar):
1535 Use gtk_scrollbar_new (Bug#11768).
1536 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1537 (is_box_type): New function (Bug#11768).
1538 (xg_tool_item_stale_p): Call is_box_type.
1539 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1540 with default display (Bug#11768).
1542 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1544 * xdisp.c (window_hscroll_limited): New function.
1545 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1546 coordinates when window's hscroll is set to insanely large
1549 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1551 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1552 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1554 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1557 * lisp.h (xzalloc): New prototype. Omit needless casts.
1558 * alloc.c (xzalloc): New function. Omit needless casts.
1559 * charset.c: Omit needless casts. Convert all calls to
1560 xmalloc with following memset to xzalloc.
1561 * dispnew.c: Likewise.
1562 * fringe.c: Likewise.
1563 * image.c: Likewise.
1564 * sound.c: Likewise.
1566 * w32fns.c: Likewise.
1567 * w32font.c: Likewise.
1568 * w32term.c: Likewise.
1569 * xfaces.c: Likewise.
1571 * xterm.c: Likewise.
1572 * atimer.c: Omit needless casts.
1573 * buffer.c: Likewise.
1574 * callproc.c: Likewise.
1576 * coding.c: Likewise.
1577 * composite.c: Likewise.
1579 * doprnt.c: Likewise.
1580 * editfns.c: Likewise.
1581 * emacs.c: Likewise.
1583 * filelock.c: Likewise.
1585 * gtkutil.c: Likewise.
1586 * keyboard.c: Likewise.
1588 * lread.c: Likewise.
1589 * minibuf.c: Likewise.
1590 * msdos.c: Likewise.
1591 * print.c: Likewise.
1592 * process.c: Likewise.
1593 * region-cache.c: Likewise.
1594 * search.c: Likewise.
1595 * sysdep.c: Likewise.
1596 * termcap.c: Likewise.
1597 * terminal.c: Likewise.
1598 * tparam.c: Likewise.
1599 * w16select.c: Likewise.
1601 * w32reg.c: Likewise.
1602 * w32select.c: Likewise.
1603 * w32uniscribe.c: Likewise.
1604 * widget.c: Likewise.
1605 * xdisp.c: Likewise.
1606 * xmenu.c: Likewise.
1608 * xselect.c: Likewise.
1610 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1612 * fileio.c (time_error_value): Check the right error number.
1613 Problem reported by Troels Nielsen in
1614 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1616 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1618 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1619 This should be fixed in a better way; see Eli Zaretskii in
1620 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1621 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1623 * fileio.c (time_error_value): Rename from special_mtime.
1624 The old name's problems were noted by Eli Zaretskii in
1625 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1627 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1628 This variable's comment says Emacs needs at least one GDB-visible
1629 symbol of type enum pvec_type, to work around GDB problems.
1630 The symbol's value doesn't matter.
1632 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1633 that causes compilation to fail on pre-C99 compilers.
1635 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1637 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1638 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1640 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1642 * buffer.c (init_buffer_once): Fix initialization of
1643 headers for buffer_defaults and buffer_local_symbols.
1644 Reported by Juanma Barranquero <lekktu@gmail.com>.
1646 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1648 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1649 * lisp.h (enum pvec_type): Use fewer bits.
1650 (PSEUDOVECTOR_SIZE_BITS): New constant.
1651 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1652 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1653 change in pvec_type.
1654 (PSEUDOVECTOR_TYPEP): New macro.
1655 (TYPED_PSEUDOVECTORP): Use it.
1656 * fns.c (internal_equal): Adapt code to extract pvectype.
1657 * emacs.c (gdb_pvec_type): Update type.
1658 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1659 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1660 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1661 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1662 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1663 abusing vector->header.next.nbytes.
1664 (live_vector_p): Use PVEC_TYPE.
1665 (mark_object): Adapt code to extract pvectype. Use switch.
1667 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1669 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1670 Tighten new eassert a bit.
1672 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1674 Fix compilation with --enable-gcc-warnings and -O1
1676 * doprnt.c (doprnt): Change type of tem to int, initialize
1677 to avoid compiler warning. Add eassert.
1678 * search.c (simple_search): Initialize match_byte to avoid
1679 compiler warning. Add eassert.
1681 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1683 Avoid weird behavior with large horizontal scrolls.
1684 Without this change, for example, large hscroll values would
1685 mess up Emacs's display on Fedora 15 x86, presumably due to
1686 overflows in int calculations in the display code.
1687 Also, if buffers had long lines, Emacs would freeze.
1688 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1689 (set_window_hscroll): New function, containing the old guts of
1690 Fset_window_hscroll. Return the clipped value.
1691 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1692 This avoids the need to check against PTRDIFF_MAX.
1694 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1696 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1698 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1700 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1702 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1703 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1704 since GCC 4.4.6 issues a bogus warning for them.
1706 Fix bugs in file timestamp newness comparisons.
1707 * fileio.c (Ffile_newer_than_file_p):
1708 * lread.c (Fload): Use full timestamp resolution of files,
1709 not just the 1-second resolution, so that files that are only
1710 slightly newer still count as newer.
1711 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1712 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1714 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1716 * fileio.c: Improve handling of file time marker. (Bug#11852)
1717 (special_mtime): New function.
1718 (Finsert_file_contents, Fverify_visited_file_modtime):
1719 Use it to set special mtime values consistently.
1721 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1723 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1724 marker for non-existing file. (Bug#11852)
1726 2012-07-03 Glenn Morris <rgm@gnu.org>
1728 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1729 and did not make it into globals.h).
1731 2012-07-03 Tom Tromey <tromey@redhat.com>
1733 * window.c (Fset_window_margins, Fset_window_fringes)
1734 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1735 * textprop.c (Fprevious_property_change): No longer static.
1736 * syntax.c (Fsyntax_table_p): No longer static.
1737 * process.c (Fget_process, Fprocess_datagram_address): No longer
1739 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1740 * keyboard.c (Fcommand_execute): No longer static.
1742 * insdel.c (Fcombine_after_change_execute): No longer static.
1743 * image.c (Finit_image_library): No longer static.
1744 * fileio.c (Fmake_symbolic_link): No longer static.
1745 * eval.c (Ffetch_bytecode): No longer static.
1746 * editfns.c (Fuser_full_name): No longer static.
1747 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1749 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1751 * dired.c (Ffile_attributes): No longer static.
1752 * composite.c (Fcomposition_get_gstring): No longer static.
1753 * callproc.c (Fgetenv_internal): No longer static.
1755 * ccl.h: Remove EXFUNs.
1756 * buffer.h: Remove EXFUNs.
1757 * dispextern.h: Remove EXFUNs.
1758 * intervals.h: Remove EXFUNs.
1759 * fontset.h: Remove EXFUN.
1760 * font.h: Remove EXFUNs.
1761 * dosfns.c (system_process_attributes): Remove EXFUN.
1762 * keymap.h: Remove EXFUNs.
1763 * lisp.h: Remove EXFUNs.
1764 * w32term.h: Remove EXFUNs.
1765 * window.h: Remove EXFUNs.
1766 * xsettings.h: Remove EXFUN.
1767 * xterm.h: Remove EXFUN.
1769 2012-07-03 Glenn Morris <rgm@gnu.org>
1771 * lisp.h (Frandom): Make it visible to C.
1772 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1773 buffer for invisible buffers. (Bug#1229)
1775 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1777 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1778 values which aren't power of 2.
1779 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1780 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1783 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1785 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1787 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1789 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1791 * alloc.c (allocate_vector_block): Remove redundant
1792 calls to mallopt if DOUG_LEA_MALLOC is defined.
1793 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1794 avoid calls to mallopt if zero_vector is returned.
1796 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1798 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1799 is enabled, avoid dereferencing NULL current_sblock if
1802 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1804 Cleanup basic buffer management.
1805 * buffer.h (struct buffer): Change layout to use generic vector
1806 marking code. Fix some comments. Change type of 'clip_changed'
1807 to bitfield. Remove unused #ifndef old.
1808 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1809 (GET_OVERLAYS_AT): Fix indentation.
1810 (for_each_per_buffer_object_at): New macro.
1811 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1812 (Fbuffer_local_variables): Use it.
1813 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1814 * alloc.c (allocate_buffer): Adjust to match new layout of
1815 struct buffer. Fix comment.
1816 (mark_overlay): New function.
1817 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1818 Lisp area of struct buffer.
1819 (mark_object): Use it. Adjust marking of misc objects
1820 and related comments.
1822 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1824 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1825 wrapper that is not needed because the wrapped code is a no-op (zero
1826 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1827 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1829 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1831 * alloc.c (mark_buffer): Simplify. Remove prototype.
1832 (mark_object): Add comment. Reorganize marking of vector-like
1833 objects. Use CHECK_LIVE for all vector-like objects except buffers
1834 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1835 redundant calls to mark_vectorlike for bool vectors.
1837 2012-06-30 Glenn Morris <rgm@gnu.org>
1839 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1841 * epaths.in (PATH_SITELOADSEARCH): New.
1842 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1843 This is rather than relying on --enable-locallisppath elements
1844 having "site-lisp" in their names. (Bug#10208#25, 11658)
1846 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1848 * w32proc.c (sys_select): Accept and ignore one more argument.
1850 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1852 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1853 (pselect) [!MS_DOS]: Redirect to sys_select.
1855 * sysdep.c: Don't include dos.h and dosfns.h.
1857 * process.c (sys_select):
1858 * msdos.c (sys_select): Accept one more argument and ignore it.
1860 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1861 adapt data types and code to that.
1864 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1865 which clashes with the gnulib function of the same name.
1867 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1869 * font.c (font_style_to_value, font_style_symbolic)
1870 (font_prop_validate_style): Add type checks for values in
1873 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1875 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1878 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1880 * xdisp.c (try_window_id): Undo last change.
1882 * w32.c (getwd): Adjust commentary about startup_dir.
1883 (init_environment): Always call sys_access, even in non-MSVC
1884 builds. Don't chdir to the directory of the Emacs executable.
1885 This undoes code from 1997 which was justified by the need to
1886 "avoid conflicts when removing and renaming directories". But its
1887 downside was that every relative file name was being interpreted
1888 relative to the directory of the Emacs executable, which can never
1889 be TRT. In particular, it broke sys_access when called with
1890 relative file names.
1891 (sys_access): Map GetLastError to errno.
1893 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1895 * window.h (struct window): Change type of 'fringes_outside_margins'
1896 to bitfield. Fix comment. Adjust users accordingly.
1897 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1899 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1902 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1904 * gnutls.c (emacs_gnutls_handshake):
1905 Add QUIT to make the loop interruptible.
1907 2012-06-29 Glenn Morris <rgm@gnu.org>
1909 * charset.c (init_charset): Make lack of etc/charsets fatal.
1911 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1913 * editfns.c (region_limit): Fix type mismatch.
1915 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1917 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1918 undefined. Convert from xassert to eassert.
1919 * nsmenu.m: Convert from xassert to eassert.
1920 * nsterm.m: Likewise.
1922 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1924 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1926 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1928 Avoid integer overflow on scroll-left and scroll-right.
1929 * window.c (HSCROLL_MAX): New macro.
1930 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1931 overflow when requested scroll falls outside ptrdiff_t range.
1933 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1935 * window.h (struct window): Change type of 'hscroll',
1936 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1937 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1938 Adjust users accordingly.
1939 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1940 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1941 from EMACS_INT to ptrdiff_t.
1942 (make_window): Omit redundant initialization.
1944 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1946 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1948 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1950 * window.h (struct window): Change type of 'use_time' and
1951 'sequence_number' from Lisp_Object to int.
1952 * frame.c (make_frame): Adjust users accordingly.
1953 * print.c (print_object): Likewise.
1954 * window.c (select_window, Fwindow_use_time, make_parent_window)
1955 (make_window): Likewise.
1957 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1959 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1960 enabled with --enable-checking=[all,glyphs] configure option.
1961 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1962 adjust comments accordingly.
1963 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1964 undefined, adjust comments accordingly.
1965 * image.c: Likewise.
1966 * scroll.c: Likewise.
1967 * w32fns.c: Likewise.
1968 * w32term.c: Likewise.
1969 * xdisp.c: Likewise.
1970 * xfaces.c: Likewise.
1972 * xterm.c: Likewise.
1974 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1976 Generalize run-time debugging checks.
1977 * dispextern.h (XASSERTS): Remove.
1978 * fontset.c (xassert): Remove.
1979 Convert from xassert to eassert.
1980 * alloc.c: Convert from xassert to eassert.
1982 * dispnew.c: Likewise.
1984 * fringe.c: Likewise.
1985 * ftfont.c: Likewise.
1986 * gtkutil.c: Likewise.
1987 * image.c: Likewise.
1988 * keyboard.c: Likewise.
1990 * process.c: Likewise.
1991 * scroll.c: Likewise.
1992 * sound.c: Likewise.
1994 * w32console.c: Likewise.
1995 * w32fns.c: Likewise.
1996 * w32term.c: Likewise.
1997 * window.c: Likewise.
1998 * xdisp.c: Likewise.
1999 * xfaces.c: Likewise.
2001 * xselect.c: Likewise.
2002 * xterm.c: Likewise.
2004 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2006 * fns.c (maybe_resize_hash_table): Output message when growing the
2009 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2011 * alloc.c (allocate_string_data): Remove dead code.
2012 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2013 avoid GCC warning about unused macro.
2015 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2017 * alloc.c (allocate_string): Omit intervals initialization.
2018 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2019 as in make_pure_string and make_pure_c_string.
2021 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2023 * alloc.c (allocate_string): Fix last change.
2025 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2027 * alloc.c (allocate_string): Remove two redundant calls
2028 to memset, add explicit initialization where appropriate.
2030 2012-06-27 Glenn Morris <rgm@gnu.org>
2032 * lisp.mk (lisp): Remove paths.elc.
2034 2012-06-27 Chong Yidong <cyd@gnu.org>
2036 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2038 2012-06-26 John Wiegley <johnw@newartisans.com>
2040 * unexmacosx.c (copy_data_segment): Add two section names used
2041 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2043 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2044 when building with Clang.
2046 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2048 * eval.c (Fapply): Allow calling it with a single argument.
2050 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2052 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2053 _stricmp and _strnicmp.
2054 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2056 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2058 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2060 (allocate_process): Likewise for new process.
2061 (allocate_terminal): Change to use offsetof.
2062 (allocate_frame): Likewise.
2063 * frame.c (make_frame): Omit redundant initialization.
2064 * window.c (make_parent_window): Use memset.
2065 (make_window): Omit redundant initialization.
2066 * process.c (make_process): Omit redundant initialization.
2067 * terminal.c (create_terminal): Likewise.
2069 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2071 * term.c (delete_tty): Remove redundant call to memset.
2073 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2075 * alloc.c: Remove build_string.
2076 * lisp.h: Define build_string as static inline. This provides
2077 a better opportunity to optimize away calls to strlen when the
2078 function is called with compile-time constant argument.
2079 * image.c (imagemagick_error): Convert to build_string.
2080 * w32proc.c (sys_spawnve): Likewise.
2081 * xterm.c (x_term_init): Likewise.
2083 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2085 Use sprintf return value instead of invoking strlen on result.
2086 In the old days this wasn't portable, since some sprintf
2087 implementations returned char *. But they died out years ago and
2088 Emacs already assumes sprintf returns int.
2089 Similarly for float_to_string.
2090 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2091 * ccl.c (ccl_driver):
2092 * character.c (string_escape_byte8):
2093 * data.c (Fnumber_to_string):
2094 * doprnt.c (doprnt):
2095 * print.c (print_object):
2096 * xdisp.c (message_dolog):
2097 * xfns.c (syms_of_xfns):
2098 Use sprintf or float_to_string result to avoid need to call strlen.
2099 * data.c (Fnumber_to_string):
2100 Use make_unibyte_string, since the string must be ASCII.
2101 * lisp.h, print.c (float_to_string): Now returns int length.
2102 * term.c (produce_glyphless_glyph):
2103 Use sprintf result rather than recomputing it.
2105 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2106 * Makefile.in (ALL_CFLAGS):
2107 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2108 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2110 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2112 * dispextern.h (xstrcasecmp): Define to library function
2113 strcasecmp if available.
2114 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2116 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2118 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2119 Avoid comma operator.
2120 * menu.c (push_submenu_start, push_submenu_end)
2121 (push_left_right_boundary, push_menu_pane): Likewise.
2122 * msdos.c (dos_rawgetc): Likewise.
2124 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2126 * xfns.c (xic_create_fontsetname): Remove redundant calls
2129 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2131 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2132 sprintf already null-terminates its output.
2134 * xfns.c (x_window): Remove redundant cast.
2136 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2138 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2139 `const char *' to `char *' to avoid compiler warning.
2141 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2143 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2144 instead of truncating it to 63 (admittedly a generous limit).
2146 * process.c: Fix spelling and caps in comments.
2148 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2150 * emacs.c (setpgrp): Remove definition, unused.
2151 * sysdep.c (setpgrp): Remove definition, not used in this file.
2153 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2155 * makefile.w32-in: Update dependencies.
2157 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2159 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2160 (SYSTIME_H): Add nt/inc/sys/time.h.
2162 * systime.h [WINDOWSNT]: Include sys/time.h.
2164 * s/ms-w32.h (struct timespec): Definition moved from
2165 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2167 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2169 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2170 * buffer.h (buffer_slot_type_mismatch):
2171 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2172 * eval.c (unwind_to_catch):
2173 * image.c (my_png_error, my_error_exit):
2174 * keyboard.c (quit_throw_to_read_char, user_error)
2175 (Fexit_recursive_edit, Fabort_recursive_edit):
2176 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2177 (wrong_type_argument, buffer_overflow, __executable_start)
2178 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2179 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2180 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2182 (child_setup) [!DOS_NT]:
2183 * lread.c (end_of_file_error, invalid_syntax):
2184 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2185 * puresize.h (pure_write_error):
2186 * search.c (matcher_overflow):
2187 * sound.c (sound_perror, alsa_sound_perror):
2188 * sysdep.c, syssignal.h (croak):
2189 * term.c (maybe_fatal, vfatal):
2190 * textprop.c (text_read_only):
2191 * undo.c (user_error):
2192 * unexmacosx.c (unexec_error):
2193 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2194 Use _Noreturn rather than NO_RETURN.
2195 No need for separate decl merely because of _Noreturn.
2196 * sound.c (sound_warning, parse_sound):
2197 Remove unnecessary forward decls.
2199 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2201 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2202 * lisp.h (WAIT_READING_MAX): New macro.
2203 * dispnew.c (Fsleep_for, sit_for):
2204 * keyboard.c (kbd_buffer_get_event):
2205 * process.c (Faccept_process_output):
2206 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2207 This improves on the previous patch, which introduced a bug
2208 when time_t is unsigned and as wide as intmax_t.
2209 See <http://bugs.gnu.org/9000#51>.
2211 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2213 * dispnew.c (sit_for, Fsleep_for):
2214 * keyboard.c (kbd_buffer_get_event):
2215 * process.c (Faccept_process_output): Avoid compiler warnings when
2216 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2218 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2220 * makefile.w32-in: Update dependencies.
2222 * w32.c (ltime): Add return type and declare static.
2223 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2225 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2227 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2228 Privately reported by Herbert J. Skuhra.
2229 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2231 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2232 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2234 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2236 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2237 last argument of make_unibyte_string.
2239 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2240 language ID in the event parameters.
2242 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2243 event.code, not the obscure "character set ID".
2245 2012-06-23 Chong Yidong <cyd@gnu.org>
2247 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2249 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2251 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2252 * w32.c (fdutimens): New function.
2254 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2256 * s/ms-w32.h (pselect): Redirect to sys_select.
2258 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2260 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2261 in the logic of incrementing and decrementing the value of
2262 use_relocatable_buffers.
2264 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2266 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2267 Privately reported by Herbert J. Skuhra.
2268 [__FreeBSD__]: Remove "*/" typo after "#include".
2269 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2270 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2271 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2272 Don't assume EMACS_TIME and struct timeval are the same type.
2274 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2276 Support higher-resolution time stamps (Bug#9000).
2277 The time stamps are only nanosecond-resolution at the C level,
2278 since that's the best that any real-world system supports now.
2279 But they are picosecond-resolution at the Lisp level, as that's
2280 easy, and leaves room for future OS improvements.
2282 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2285 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2286 Don't get current time unless it's needed.
2288 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2289 now provides it if it's absent.
2290 (start_atimer): Port to higher-res time stamps.
2291 Check for time stamp overflow. Don't get current time more
2292 often than is needed.
2294 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2295 Include systime.h, not time.h.
2296 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2298 * dired.c: Include stat-time.h.
2299 (Ffile-attributes): File times now have higher resolution.
2301 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2302 (struct image): Timestamp now has higher resolution.
2304 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2305 has at least microseconds now. All uses removed.
2306 (update_frame, update_single_window, update_window, update_frame_1)
2307 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2309 * editfns.c (time_overflow): Now extern.
2310 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2311 (float-time, Fformat_time_string, Fcurrent_time_string)
2312 (Fcurrent_time_zone): Accept and generate higher-resolution
2314 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2315 (decode_time_components, lisp_seconds_argument): New functions.
2316 (make_time): Now static.
2317 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2318 Report an error if the time is invalid, rather than having the caller
2321 * fileio.c: Include <stat-time.h>
2322 (Fcopy_file): Copy higher-resolution time stamps.
2323 Prefer to set the time stamp via a file descriptor if that works.
2324 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2325 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2326 (Fvisited_file_modtime, Fset_visited_file_modtime):
2327 Support higher-resolution time stamps.
2329 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2331 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2333 * image.c (prepare_image_for_display, clear_image_cache)
2334 (lookup_image): Port to higer-resolution time stamps.
2336 * keyboard.c (start_polling, bind_polling_period):
2337 Check for time stamp overflow.
2338 (read_char, kbd_buffer_get_event, timer_start_idle)
2339 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2340 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2341 Port to higher-resolution time stamps. Do not assume time_t is signed.
2342 (decode_timer): New function. Timers are now vectors of length 9,
2343 not 8, to accommodate the picosecond component.
2344 (timer_check_2): Use it.
2346 * nsterm.m (select_timeout, timeval_subtract): Remove.
2347 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2348 as they're a bit more accurate and handle overflow better.
2349 (ns_select): Change prototype to be compatible with pselect.
2350 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2351 * nsterm.h (ns_select): Adjust prototype.
2353 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2354 us-resolution time stamps.
2355 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2357 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2359 * lisp.h (time_overflow): New decl.
2360 (wait_reading_process_output): First arg is now intmax_t, not int,
2361 to accommodate larger waits.
2363 * process.h (struct Lisp_Process.read_output_delay):
2364 Now counts nanoseconds, not microseconds.
2365 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2367 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2368 (wait_reading_process_output):
2369 Port to ns-resolution time stamps.
2370 (Faccept_process_output, wait_reading_process_output):
2371 Check for time stamp overflow. Do not assume time_t is signed.
2372 (select_wrapper): Remove; we now use pselect.
2373 (Fprocess_attributes): Now generates ns-resolution time stamps.
2375 * sysdep.c: Include utimens.h. Don't include utime.h
2376 or worry about struct utimbuf; gnulib does that for us now.
2377 (gettimeofday): Remove; gnulib provides a substitute.
2378 (make_timeval): New function.
2379 (set_file_times): Now sets ns-resolution time stamps.
2380 New arg FD; all uses changed.
2381 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2382 (system_process_attributes):
2383 Now returns ns-resolution time stamp. All uses changed.
2384 Check for time stamp overflow.
2386 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2387 provides a substitute now.
2389 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2390 since it guarantees struct timespec.
2391 (EMACS_TIME): Now struct timespec, so that we can support
2392 ns-resolution time stamps.
2393 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2394 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2395 (EMACS_USECS): Remove.
2396 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2397 so multiply the arg by 1000 before storing it.
2398 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2400 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2401 Port to ns-resolution time stamps.
2402 (EMACS_TIME_NEG_P): Remove; replaced by....
2403 (EMACS_TIME_SIGN): New macro.
2404 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2405 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2406 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2407 (make_timeval, make_lisp_time, decode_time_components): New decls.
2408 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2409 that it mishandled time_t overflow. You can't compare by subtracting!
2410 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2411 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2413 * term.c: Include <sys/time.h>.
2414 (timeval_to_Time): New function, for proper overflow wraparound.
2415 (term_mouse_position, term_mouse_click): Use it.
2417 * undo.c (record_first_change): Support higher-resolution time stamps
2419 (Fprimitive_undo): Use them when restoring time stamps.
2421 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2422 (w32_get_internal_run_time):
2423 Port to higher-resolution Emacs time stamps.
2424 (ltime): Now accepts single 64-bit integer, as that's more convenient
2427 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2429 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2430 for compatibility with pselect. Support ns-resolution time stamps.
2432 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2434 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2435 Check for time stamp overflow, and support ns-resolution time stamps.
2437 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2438 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2439 (timeval_subtract): Remove; no longer needed.
2440 (XTflash, XTring_bell, x_wait_for_event):
2441 Port to ns-resolution time stamps. Don't assume time_t is signed.
2443 2012-06-22 Chong Yidong <cyd@gnu.org>
2445 * xdisp.c (x_consider_frame_title): Revert last change.
2447 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2449 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2450 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2451 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2452 staticidx goes up to 1597 out of 1600 = 0x640.)
2454 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2456 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2457 Otherwise, the umask might be mistakenly 0 while handling input signals.
2459 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2461 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2463 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2465 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2466 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2467 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2468 access to `contents' member of Lisp_Vector objects with AREF and ASET
2471 2012-06-19 Chong Yidong <cyd@gnu.org>
2473 * frame.c (delete_frame): When selecting a frame on a different
2474 text terminal, do not alter the terminal's top-frame.
2476 * xdisp.c (format_mode_line_unwind_data): Record the target
2477 frame's selected window and its terminal's top-frame.
2478 (unwind_format_mode_line): Restore them.
2479 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2481 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2482 since tty frames can be explicitly named.
2483 (prepare_menu_bars): Likewise.
2485 * term.c (Ftty_top_frame): New function.
2487 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2489 Port byte-code-meter to modern targets.
2490 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2491 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2492 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2493 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2494 (METER_1, METER_2): Simplify.
2496 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2498 * data.c (Fdefalias): Return `symbol' (bug#11686).
2500 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2502 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2503 gets killed during executing of this function (Bug#11665).
2504 Try to always return Qt when the buffer has been actually killed.
2505 (Vkill_buffer_query_functions): In doc-string say that functions
2506 run by this hook should not change the current buffer.
2508 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2510 Fix recently-introduced process.c problems found by static checking.
2511 * process.c (write_queue_push, write_queue_pop, send_process):
2512 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2513 (write_queue_pop): Fix pointer signedness problem.
2514 (send_process): Remove unused local.
2516 2012-06-17 Chong Yidong <cyd@gnu.org>
2518 * xdisp.c (redisplay_internal): No need to redisplay terminal
2519 frames that are not on top.
2521 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2523 * process.c (make_process): Initialize write_queue.
2524 (write_queue_push, write_queue_pop): New functions.
2525 (send_process): Use them to maintain correct ordering of process
2528 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2530 * lisp.h (eassert): Assume C89 or later.
2531 This removes the need for CHECK.
2532 (CHECK): Remove. Its comments about always evaluating its
2533 argument were confusing, as 'eassert' typically does not evaluate
2536 * coding.c (produce_chars): Use ptrdiff_t, not int.
2538 * xterm.c (x_draw_underwave): Check for integer overflow.
2539 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2541 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2543 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2544 referenced (Bug#11583).
2546 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2548 Implement wave-style variant of underlining.
2549 * dispextern.h (face_underline_type): New enum.
2550 (face): Add field for underline type.
2551 * nsterm.m (ns_draw_underwave): New function.
2552 (ns_draw_text_decoration): Use it.
2553 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2555 (x_draw_glyph_string): Use them.
2556 * xfaces.c (Qline, Qwave): New Lisp objects.
2557 (check_lface_attrs, merge_face_ref)
2558 (Finternal_set_lisp_face_attribute, realize_x_face):
2559 Handle wave-style underline face attributes.
2560 * xterm.c (x_draw_underwave): New function.
2561 (x_draw_glyph_string): Use it.
2563 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2565 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2566 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2567 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2568 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2569 ($(BLD)/w32select.$(O)): Update dependencies.
2571 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2573 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2574 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2575 * character.c (_fetch_multibyte_char_p): Remove.
2576 * alloc.c: Include "character.h" before "buffer.h".
2578 * buffer.c: Likewise.
2579 * bytecode.c: Likewise.
2580 * callint.c: Likewise.
2581 * callproc.c: Likewise.
2582 * casefiddle.c: Likewise.
2583 * casetab.c: Likewise.
2584 * category.c: Likewise.
2586 * coding.c: Likewise.
2587 * composite.c: Likewise.
2588 * dired.c: Likewise.
2589 * dispnew.c: Likewise.
2591 * dosfns.c: Likewise.
2592 * editfns.c: Likewise.
2593 * emacs.c: Likewise.
2594 * fileio.c: Likewise.
2595 * filelock.c: Likewise.
2597 * fontset.c: Likewise.
2598 * fringe.c: Likewise.
2599 * indent.c: Likewise.
2600 * insdel.c: Likewise.
2601 * intervals.c: Likewise.
2602 * keyboard.c: Likewise.
2603 * keymap.c: Likewise.
2604 * lread.c: Likewise.
2605 * macros.c: Likewise.
2606 * marker.c: Likewise.
2607 * minibuf.c: Likewise.
2608 * nsfns.m: Likewise.
2609 * nsmenu.m: Likewise.
2610 * print.c: Likewise.
2611 * process.c: Likewise.
2612 * regex.c: Likewise.
2613 * region-cache.c: Likewise.
2614 * search.c: Likewise.
2615 * syntax.c: Likewise.
2617 * textprop.c: Likewise.
2619 * unexsol.c: Likewise.
2620 * w16select.c: Likewise.
2621 * w32fns.c: Likewise.
2622 * w32menu.c: Likewise.
2623 * window.c: Likewise.
2624 * xdisp.c: Likewise.
2626 * xmenu.c: Likewise.
2628 * xselect.c: Likewise.
2630 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2632 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2633 If all the glyphs of the glyph row came from strings, and we have no
2634 cursor positioning clues, put the cursor on the first glyph of the
2636 (handle_face_prop): Use chunk-relative overlay string index when
2637 indexing into it->string_overlays array. (Bug#11653)
2638 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2639 the rightmost. (Bug#11720)
2641 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2643 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2644 (CATEGORY_MEMBER): Enforce 1/0 value.
2645 * category.c (_temp_category_set): Remove.
2647 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2649 * window.c (Fdelete_other_windows_internal)
2650 (Fdelete_window_internal): Don't access frame's mouse highlight
2651 info of the initial frame. (Bug#11677)
2653 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2655 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2656 Assume USE_2_TAGS_FOR_INTS.
2657 (xreload): Adjust $tagmask width to match recent lisp.h change.
2659 Simplify lisp.h in minor ways that should not affect code.
2660 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2661 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2662 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2663 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2664 (INTTYPEBITS): New macro, for clarity.
2665 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2666 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2667 Simplify now that USE_LSB_TAG is always defined.
2668 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2669 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2671 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2673 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2675 2012-06-13 Glenn Morris <rgm@gnu.org>
2677 * s/bsd-common.h (BSD4_3):
2678 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2680 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2682 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2685 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2687 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2688 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2689 * alloc.c (widen_to_Lisp_Object): Remove.
2690 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2691 * frame.c (delete_frame): Remove outdated comment.
2692 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2693 USE_LISP_UNION_TYPE.
2694 (Fw32_unregister_hot_key): Likewise.
2695 (Fw32_toggle_lock_key): Likewise.
2696 * w32menu.c (add_menu_item): Likewise.
2697 (w32_menu_display_help): Use XIL instead of checking
2698 USE_LISP_UNION_TYPE.
2699 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2700 (init_heap): Likewise.
2701 * w32term.c (w32_read_socket): Update comment.
2703 2012-06-13 Glenn Morris <rgm@gnu.org>
2705 * s/usg5-4-common.h, src/s/unixware.h:
2706 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2708 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2710 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2712 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2713 * alloc.c (make_number) [!defined make_number]:
2714 Remove, as lisp.h always defines this now.
2715 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2716 (roundup_size): Verify that it is a power of 2.
2717 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2718 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2719 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2720 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2721 USE_LSB_TAG now is always defined to be either 0 or 1.
2723 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2724 code works fine either way, and efficiency is not a concern here,
2725 as the union type is for debugging, not for production.
2726 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2727 Use an inline function on all platforms when using the union type,
2728 since this is simpler and 'static inline' can be used portably
2730 (LISP_INITIALLY_ZERO): New macro.
2731 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2732 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2734 2012-06-12 Glenn Morris <rgm@gnu.org>
2736 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2738 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2740 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2741 Move BROKEN_SIGIO to configure.
2743 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2744 Move NO_TERMIO to configure.
2746 2012-06-12 Chong Yidong <cyd@gnu.org>
2748 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2749 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2750 MagickExportImagePixels is undefined.
2752 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2754 * image.c (imagemagick_load_image): Remove unused label.
2756 2012-06-11 Glenn Morris <rgm@gnu.org>
2758 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2759 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2760 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2761 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2763 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2765 * alloc.c (make_byte_code): New function.
2766 (Fmake_byte_code): Use it. Don't purify here.
2767 * lread.c (read1): Use it as well to avoid extra allocation.
2769 2012-06-11 Chong Yidong <cyd@gnu.org>
2771 * image.c (imagemagick_load_image): Implement transparency.
2773 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2775 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2776 account for preceding backslashes. (Bug#11663)
2778 2012-06-09 Chong Yidong <cyd@gnu.org>
2780 * term.c: Support italics in capable terminals (Bug#9652).
2781 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2782 (turn_on_face): Output using TS_enter_italic_mode if available.
2783 Don't handle unused blinking and alt-charset cases.
2784 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2785 and tty_alt_charset_p cases.
2786 (tty_capable_p, init_tty): Support italics.
2788 * termchar.h (struct tty_display_info): Add field for italics.
2789 Remove unused blink field.
2791 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2794 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2795 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2796 tty_alt_charset_p. Add tty_italic_p.
2798 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2800 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2801 dbus_type_is_basic if available.
2802 (xd_extract_signed, xd_extract_unsigned): Rename from
2803 extract_signed and extract_unsigned, respectively. Adapt callers.
2805 2012-06-09 Chong Yidong <cyd@gnu.org>
2807 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2809 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2812 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2814 * xdisp.c (vmessage): Treat frame message as multibyte.
2815 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2816 would generate the diagnostic "Making \302\247 buffer-local while
2819 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2821 * dispnew.c (showing_window_margins_p): Undo last change, which
2822 was done due to an inadvertent commit.
2823 (adjust_frame_glyphs_for_frame_redisplay): Do call
2824 showing_window_margins_p.
2826 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2828 * eval.c (Fmake_var_non_special): New primitive.
2829 (syms_of_eval): Defsubr it.
2830 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2832 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2834 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2835 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2837 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2839 * alloc.c (allocate_vectorlike): Fix last change.
2841 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2843 Block-based vector allocation of small vectors.
2844 * lisp.h (struct vectorlike_header): New field `nbytes',
2845 adjust comment accordingly.
2846 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2847 to denote vector blocks. Adjust users (live_vector_p,
2848 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2849 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2850 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2851 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2852 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2853 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2854 (roundup_size): New constant.
2855 (struct vector_block): New data type.
2856 (vector_blocks, vector_free_lists, zero_vector): New variables.
2857 (all_vectors): Rename to `large_vectors'.
2858 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2859 (sweep_vectors): New functions.
2860 (allocate_vectorlike): Return `zero_vector' as the only vector of
2861 0 items. Allocate new vector from block if vector size is less than
2862 or equal to VBLOCK_BYTES_MAX.
2863 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2864 (init_alloc_once): Add call to init_vectors.
2866 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2868 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2870 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2872 * doprnt.c (doprnt): Truncate multibyte char correctly.
2873 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2874 would mishandle a string argument "Xc" if X was a multibyte
2875 character of length 2: it would truncate after X's first byte
2876 rather than including all of X.
2878 2012-06-06 Chong Yidong <cyd@gnu.org>
2880 * buffer.c (word_wrap): Doc fix.
2882 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2884 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2886 2012-06-03 Glenn Morris <rgm@gnu.org>
2888 * xdisp.c (tool-bar-style): Doc fix.
2890 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2892 * Makefile.in (PAXCTL): Define.
2893 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2894 binary via PaX flags if the paxctl utility is available.
2895 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2896 Restore PaX flags to their default. (Bug#11398)
2898 2012-06-03 Chong Yidong <cyd@gnu.org>
2900 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2903 2012-06-03 Chong Yidong <cyd@gnu.org>
2905 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2906 (note_mode_line_or_margin_highlight): If there is no help echo,
2907 use mode-line-default-help-echo. Handle the case where the mouse
2908 position is past the end of the mode line string.
2910 * buffer.c (buffer_local_value_1): New function, split from
2911 Fbuffer_local_value; can return Qunbound.
2912 (Fbuffer_local_value): Use it.
2913 (Vmode_line_format): Docstring tweaks.
2915 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2917 * sysdep.c (system_process_attributes): Improve comment.
2919 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2921 * keyboard.c: Export real-this-command to Elisp.
2922 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2923 and DEFVAR it. Update all users.
2925 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2927 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2929 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2930 Convert pctcpu and pctmem to Lisp float properly.
2931 Let the compiler fold better, as 100.0/0x8000 is exact.
2933 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2935 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2938 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2940 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2942 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2944 For a 'struct window', replace some Lisp_Object fields to
2945 bitfields where appropriate, remove unused fields.
2946 * window.h (struct window): Remove unused 'last_mark_x' and
2947 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2948 change it's type from Lisp_Object to bitfield.
2949 Change type of 'force_start', 'optional_new_start',
2950 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2951 fields from Lisp_Object to bitfield. Adjust users accordingly.
2953 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2955 Pacify gcc -Wdouble-precision when using Xaw.
2956 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2957 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2958 Use 'float' consistently, rather than 'float' in most places
2959 and 'double' in a couple of places.
2961 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2963 * xdisp.c (handle_stop): Detect whether we have overlay strings
2964 loaded by testing it->current.overlay_string_index to be
2965 non-negative, instead of checking whether n_overlay_strings is
2966 positive. (Bug#11587)
2968 2012-05-31 Chong Yidong <cyd@gnu.org>
2970 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2972 * doc.c (Fsubstitute_command_keys): Doc fix.
2974 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2976 * search.c (search_buffer): Remove calls to
2977 r_alloc_inhibit_buffer_relocation, as it is now called by
2978 maybe_unify_char, which was the cause of relocation of buffer text
2981 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2983 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2984 for the duration of call to load_charset, to avoid problems with
2985 callers of maybe_unify_char that access buffer text through C
2988 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2989 decrement the inhibition flag, instead of just setting or
2992 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2994 Remove obsolete '#define static' cruft.
2995 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2996 This #undef was "temporary" in 2000; it is no longer needed
2997 now that '#define static' has gone away.
2998 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2999 (gray_bitmap_bits): Remove; no longer needed.
3000 All uses replaced with definiens.
3001 * xterm.c: Include "bitmaps/gray.xbm".
3003 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3005 Clean up __executable_start, monstartup when --enable-profiling.
3006 The following changes affect the code only when profiling.
3007 * dispnew.c (__executable_start): Rename from safe_bcopy.
3008 Define only on platforms that need it.
3009 * emacs.c: Include <sys/gmon.h> when profiling.
3010 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3011 (__executable_start): Remove decl, since lisp.h does it now.
3012 (safe_bcopy): Remove decl; no longer has that name.
3013 (main): Coalesce #if into single bit of code, for simplicity.
3014 Cast pointers to uintptr_t, since standard libraries want integers
3016 * lisp.h (__executable_start): New decl.
3018 2012-05-31 Glenn Morris <rgm@gnu.org>
3020 * image.c (Fimagemagick_types): Doc fix.
3022 2012-05-30 Jim Meyering <meyering@redhat.com>
3024 * callproc.c (Fcall_process_region): Include directory component
3025 in mkstemp error message (Bug#11586).
3027 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3029 * alloc.c, lisp.h (make_pure_vector): Now static.
3031 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3033 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3034 Move to byte-run.el.
3035 (Fautoload): Do the hash-doc more carefully.
3036 * data.c (Fdefalias): Purify definition, except for keymaps.
3037 (Qdefun): Move from eval.c.
3038 * lisp.h (Qdefun): Remove.
3039 * lread.c (read1): Tiny simplification.
3041 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3043 Do not create empty overlays with the evaporate property (Bug#9642).
3044 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3045 Bug#9642, but explicitly check that the buffer the overlay would
3046 be moved to is live and rearrange lines to make sure that errors
3047 will not put the overlay in an inconsistent state.
3048 (Fdelete_overlay): Cosmetics.
3050 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3052 * w32term.c (my_bring_window_to_top): New function.
3053 (x_raise_frame): Use handle returned by DeferWindowPos, which
3054 could be different from the original one.
3055 Call my_bring_window_to_top instead of my_set_foreground_window.
3058 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3059 by calling BringWindowToTop.
3061 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3062 (WM_EMACS_END): Increase by one.
3064 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3066 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3067 This avoids undefined behavior that might cause the eassert
3068 to not catch an out-of-range value.
3070 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3072 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3073 Update dependencies.
3075 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3077 * bidi.c (bidi_mirror_char): Fix last change.
3079 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3081 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3082 when referring to sectname field in printf format.
3084 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3086 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3087 Only r_alloc_inhibit_buffer_relocation needed to be added;
3088 the others were already declared.
3090 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3091 before checking whether it's out of range. Put the check inside
3093 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3095 2012-05-27 Ken Brown <kbrown@cornell.edu>
3097 * callproc.c (Fcall_process): Restore a line that was accidentally
3098 commented out in the 2011-02-13 change (bug#11547).
3100 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3102 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3103 defined on ralloc.c.
3105 * buffer.c [REL_ALLOC]: Remove prototypes of
3106 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3107 they are now on lisp.h.
3109 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3111 * search.c (search_buffer): Use it to inhibit relocation of buffer
3112 text while re_search_2 is doing its job, because re_search_2 is
3113 passed C pointers to buffer text. (Bug#11519)
3115 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3118 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3119 state after an additional call to move_it_in_display_line_to, keep
3120 the values of it->max_ascent and it->max_descent found for the
3122 (pos_visible_p): Revert the comparison against bottom_y to what it
3123 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3126 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3128 Fix coding-related core dumps with gcc -ftrapv.
3129 The code was computing A - B, where A and B are pointers, and B is
3130 random garbage. This can lead to core dumps on platforms that
3131 have special pointer registers, and it also leads to core dumps on
3132 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3133 A - B only when B is initialized properly.
3134 * coding.c (coding_set_source, coding_set_destination): Return void.
3135 (coding_change_source, coding_change_destinations): New functions,
3136 with the old behaviors of coding_set_source and coding_set_destination.
3137 All callers that need an offset changed to use these new functions.
3139 2012-05-26 Glenn Morris <rgm@gnu.org>
3141 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3143 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3145 Extend mouse support on W32 text-mode console.
3146 * xdisp.c (draw_row_with_mouse_face):
3147 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3149 * w32console.c: Include window.h.
3150 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3152 (initialize_w32_display): Initialize mouse-highlight data.
3154 * w32inevt.c: Include termchar.h and window.h.
3155 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3156 moves, call note_mouse_highlight. If help_echo changed, call
3157 gen_help_event to produce help-echo message in the echo area.
3158 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3161 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3163 * lread.c (read1): Simplify slightly to avoid an overflow warning
3164 with GCC 4.7.0 on x86-64.
3166 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3168 * bidi.c (bidi_mirror_char): Revert last change: an int is
3169 definitely wide enough here.
3171 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3173 Fix integer width and related bugs (Bug#9874).
3174 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3175 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3176 (string_bytes, check_sblock, allocate_string_data):
3177 (compact_small_strings, Fmake_bool_vector, make_string)
3178 (make_unibyte_string, make_multibyte_string)
3179 (make_string_from_bytes, make_specified_string)
3180 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3181 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3184 (allocate_pseudovector):
3185 Use int, not EMACS_INT, where int is wide enough.
3186 (inhibit_garbage_collection, Fgarbage_collect):
3187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3188 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3189 int might not be wide enough.
3190 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3191 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3192 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3193 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3194 (bidi_level_of_next_char, bidi_move_to_visually_next):
3195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3196 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3197 (Fkill_buffer, Fset_buffer_major_mode)
3198 (advance_to_char_boundary, Fbuffer_swap_text)
3199 (Fset_buffer_multibyte, overlays_at, overlays_in)
3200 (overlay_touches_p, struct sortvec, record_overlay_string)
3201 (overlay_strings, recenter_overlay_lists)
3202 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3203 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3204 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3205 (Foverlay_recenter, last_overlay_modification_hooks_used)
3206 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3208 (validate_region): Omit unnecessary test for b <= e,
3209 since that's guaranteed by the previous test.
3210 (adjust_overlays_for_delete): Avoid pos + length overflow.
3211 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3212 (report_overlay_modification):
3213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3214 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3215 Omit pointer cast, which isn't needed anyway, and doesn't work
3216 after the EMACS_INT -> ptrdiff_t change.
3217 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3218 * buffer.h: Adjust decls to match defn changes elsewhere.
3219 (struct buffer_text, struct buffer):
3220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3221 Use EMACS_INT, not int, where int might not be wide enough.
3222 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3223 not int, to avoid needless 32-bit limit on 64-bit hosts.
3224 (exec_byte_code): Use tighter memory-full test, one that checks
3225 for alloca overflow. Don't compute the address of the object just
3226 before an array, as that's not portable. Use EMACS_INT, not
3227 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3228 * callint.c (Fcall_interactively):
3229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3230 * callproc.c (call_process_kill, Fcall_process):
3231 Don't assume pid_t fits into an Emacs fixnum.
3232 (call_process_cleanup, Fcall_process, child_setup):
3233 Don't assume pid_t fits into int.
3234 (call_process_cleanup, Fcall_process, delete_temp_file)
3235 (Fcall_process_region):
3236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3237 (Fcall_process): Simplify handling of volatile integers.
3238 Use int, not EMACS_INT, where int will do.
3239 * casefiddle.c (casify_object, casify_region, operate_on_word)
3240 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3242 (casify_object): Avoid integer overflow when overallocating buffer.
3243 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3244 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3245 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3246 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3247 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3248 integers are now checked earlier. All uses replaced with XINT.
3250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3251 For CCL_MapSingle, check that content and value are in int range.
3252 (ccl_driver, Fregister_code_conversion_map):
3253 Check that Vcode_version_map_vector is a vector.
3254 (resolve_symbol_ccl_program): Check that vector header is in range.
3255 Always copy the vector, so that we can check its contents reliably
3256 now rather than having to recheck each instruction as it's being
3257 executed. Check that vector words fit in 'int'.
3258 (ccl_get_compiled_code, Fregister_ccl_program)
3259 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3260 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3261 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3262 contents are in range.
3263 (Fccl_execute_on_string): Check that status is in range.
3264 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3265 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3266 Accept and return EMACS_INT, not int, because callers can pass values
3268 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3269 (multibyte_chars_in_text, parse_str_as_multibyte)
3270 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3271 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3272 (string_escape_byte8, Fget_byte):
3273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3274 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3275 avoid mishandling large integers.
3276 * character.h: Adjust decls to match defn changes elsewhere.
3277 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3278 (Ffind_charset_region):
3279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3280 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3281 (load_charset_map_from_vector, Fdefine_charset_internal):
3282 Don't assume fixnum fits in int.
3283 (load_charset_map_from_vector, Fmap_charset_chars):
3284 Remove now-unnecessary CHECK_NATNUMs.
3285 (Fdefine_charset_internal): Check ranges here, more carefully.
3286 Don't rely on undefined behavior with signed left shift overflow.
3287 Don't assume unsigned int fits into fixnum, or that fixnum fits
3288 into unsigned int. Don't require max_code to be a valid fixnum;
3289 that's not true for gb10830 4-byte on a 32-bit host. Allow
3290 invalid_code to be a cons, for the same reason. Require code_offset
3291 to be a character. Avoid int overflow if max_char is close
3293 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3294 this is intended anyway and avoids some undefined behavior.
3295 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3296 INDEX_TO_CODE_POINT, as that's what it expects.
3297 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3298 * charset.h (DECODE_CHAR): Return int, not unsigned;
3299 this is what was intended anyway, and it avoids undefined behavior.
3300 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3301 integer-overflow issues.
3302 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3303 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3304 where the argument is EMACS_INT, and this behavior is not intended.
3305 * chartab.c (Fmake_char_table, Fset_char_table_range)
3306 (uniprop_get_decoder, uniprop_get_encoder):
3307 Don't assume fixnum fits in int.
3308 * cmds.c (move_point): New function, that does the gist of
3309 Fforward_char and Fbackward_char, but does so while checking
3310 for integer overflow more accurately.
3311 (Fforward_char, Fbackward_char): Use it.
3312 (Fforward_line, Fend_of_line, internal_self_insert)
3313 (internal_self_insert):
3314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3315 Fix a FIXME, by checking for integer overflow when calculating
3316 target_clm and actual_clm.
3317 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3318 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3319 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3320 (coding_alloc_by_making_gap, alloc_destination)
3321 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3322 (encode_coding_utf_16, detect_coding_emacs_mule)
3323 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3324 (detect_coding_iso_2022, decode_coding_iso_2022)
3325 (encode_invocation_designation, encode_designation_at_bol)
3326 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3327 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3328 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3329 (encode_coding_ccl, encode_coding_raw_text)
3330 (detect_coding_charset, decode_coding_charset)
3331 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3332 (produce_composition, produce_charset, produce_annotation)
3333 (decode_coding, handle_composition_annotation)
3334 (handle_charset_annotation, consume_chars, decode_coding_gap)
3335 (decode_coding_object, encode_coding_object, detect_coding_system)
3336 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3337 (code_convert_region, code_convert_string)
3338 (Fdefine_coding_system_internal)
3339 (coding_set_source, coding_set_destination):
3340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3341 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3342 (Fdefine_coding_system_internal):
3343 Don't assume fixnums fit in int.
3344 (decode_coding_gap, decode_coding_object, encode_coding_object)
3345 (Fread_coding_system, Fdetect_coding_region)
3346 (Funencodable_char_position, Fcheck_coding_systems_region)
3347 (get_translation, handle_composition_annotation, consume_chars):
3348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3349 (consume_chars): Rewrite to not calculate an address outside buffer.
3350 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3351 Don't access memory outside of the args array.
3352 (Fdefine_coding_system_internal): Check for charset-id overflow.
3353 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3354 result of ENCODE_CHAR.
3355 * coding.h: Adjust decls to match defn changes elsewhere.
3356 (struct coding_system):
3357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3358 * composite.c (get_composition_id, find_composition)
3359 (run_composition_function, update_compositions)
3360 (compose_text, composition_gstring_put_cache)
3361 (composition_gstring_p, composition_gstring_width)
3362 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3363 (composition_compute_stop_pos, composition_reseat_it)
3364 (composition_update_it, struct position_record)
3365 (find_automatic_composition, composition_adjust_point)
3366 (Fcomposition_get_gstring, Ffind_composition_internal):
3367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3368 (update_compositions):
3369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3370 * composite.h: Adjust decls to match defn changes elsewhere.
3371 (struct composition):
3372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3373 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3374 Do not attempt to compute the address of the object just before a
3375 buffer; this is not portable.
3377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3378 (Faset): Use int, not EMACS_INT, where int is wide enough.
3379 (Fstring_to_number): Don't assume fixnums fit in int.
3380 (Frem): Don't assume arg is nonnegative.
3381 * dbusbind.c (xd_append_arg): Check for integers out of range.
3382 (Fdbus_call_method): Don't overflow the timeout int.
3383 (extract_signed, extract_unsigned): New functions.
3384 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3385 (xd_get_connection_references): Return ptrdiff_t, not int.
3387 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3388 (xd_read_message_1):
3389 Use int, not unsigned, where the dbus API uses int.
3390 (Fdbus_message_internal): Don't overflow mtype.
3391 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3392 * dired.c (directory_files_internal, file_name_completion, scmp)
3393 (file_name_completion_stat):
3394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3395 (file_name_completion): Don't overflow matchcount.
3396 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3397 * dispextern.h: Adjust decls to match defn changes elsewhere.
3398 (struct text_pos, struct glyph, struct bidi_saved_info)
3399 (struct bidi_string_data, struct bidi_it, struct composition_it)
3401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3402 (struct display_pos, struct composition_it, struct it):
3403 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3404 * dispnew.c (increment_matrix_positions)
3405 (increment_row_positions, mode_line_string)
3406 (marginal_area_string):
3407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3408 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3410 (duration_to_sec_usec): New function, to check for overflow better.
3411 (Fsleep_for, sit_for): Use it.
3412 * doc.c (get_doc_string, store_function_docstring):
3413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3414 (get_doc_string, Fsnarf_documentation):
3415 Use int, not EMACS_INT, where int is wide enough.
3417 Use SAFE_ALLOCA, not alloca.
3418 Check for overflow when converting EMACS_INT to off_t.
3419 * doprnt.c (doprnt):
3420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3421 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3422 Don't assume uid_t fits into fixnum.
3423 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3424 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3425 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3426 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3427 (general_insert_function)
3428 (Finsert_char, make_buffer_string, make_buffer_string_both)
3429 (update_buffer_properties, Fbuffer_substring)
3430 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3431 (Fsubst_char_in_region, check_translation)
3432 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3433 (transpose_markers, Ftranspose_regions):
3434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3435 (clip_to_bounds): Move to lisp.h as an inline function).
3436 (Fconstrain_to_field): Don't assume integers are nonnegative.
3437 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3438 (Fsubst_char_in_region, Fsave_restriction):
3439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3440 (Femacs_pid): Don't assume pid_t fits into fixnum.
3441 (lo_time): Use int, not EMACS_INT, when int suffices.
3442 (lisp_time_argument): Check for usec out of range.
3443 (Fencode_time): Don't assume fixnum fits in int.
3444 (Fuser_login_name, Fuser_full_name): Signal an error
3445 if a uid argument is out of range, rather than relying on
3447 (Fformat_time_string): Remove now-unnecessary check.
3448 lisp_time_argument checks for out-of-range usec now.
3449 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3450 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3451 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3452 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3453 (init_cmdargs, Fdump_emacs):
3454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3455 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3456 the bottom (typically) 32 bits of the fixnum.
3457 * eval.c (specpdl_size, call_debugger):
3458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3459 (when_entered_debugger, Fbacktrace_debug):
3460 Don't assume fixnum can fit in int.
3461 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3462 the object just before a buffer; this is not portable.
3463 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3464 (grow_specpdl, unbind_to):
3465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3466 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3467 (grow_specpdl): Simplify allocation by using xpalloc.
3468 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3469 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3470 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3472 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3475 (Fcopy_file, non_regular_nbytes, read_non_regular)
3476 (Finsert_file_contents):
3477 Use int, not EMACS_INT, where int is wide enough.
3478 (READ_BUF_SIZE): Verify that it fits in int.
3479 (Finsert_file_contents): Check that counts are in proper range,
3480 rather than assuming fixnums fit into ptrdiff_t etc.
3481 Don't assume fixnums fit into int.
3482 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3483 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3484 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3485 (string_char_to_byte, string_byte_to_char)
3486 (string_make_multibyte, string_to_multibyte)
3487 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3488 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3489 (substring_both, Fdelete, internal_equal, Ffillarray)
3490 (Fclear_string, mapcar1)
3491 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3492 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3493 (larger_vector, make_hash_table, maybe_resize_hash_table)
3494 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3495 (Fmaphash, secure_hash):
3496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3497 (concat): Check for string index and length overflow.
3498 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3501 (larger_vector): New API (vec, incr_min, size_max) replaces old
3502 one (vec, new_size, init). This catches size overflow.
3503 INIT was removed because it was always Qnil.
3504 All callers changed.
3505 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3506 the upper bound on a hash table index size.
3507 (make_hash_table, maybe_resize_hash_table): Use it.
3508 (secure_hash): Computer start_byte and end_byte only after
3509 they're known to be in ptrdiff_t range.
3510 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3511 (Ffont_get_glyphs, Ffont_at):
3512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3513 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3514 (Flist_fonts, Fopen_font):
3515 Don't assume fixnum can fit in int.
3516 (check_gstring): Don't assume index can fit in int.
3517 (font_match_p): Check that fixnum is a character, not a nonnegative
3518 fixnum, since the later code needs to stuff it into an int.
3519 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3520 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3521 conversion overflow issues.
3522 (Fopen_font): Check for integer out of range.
3523 (Ffont_get_glyphs): Don't assume index can fit in int.
3524 * font.h: Adjust decls to match defn changes elsewhere.
3525 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3527 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3528 printmax_t, where ptrdiff_t is wide enough.
3529 (Finternal_char_font):
3530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3531 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3532 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3533 (Fset_frame_position, x_set_frame_parameters)
3534 (x_set_line_spacing, x_set_border_width)
3535 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3536 Check that fixnums are in proper range for system types.
3537 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3539 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3540 Use SAFE_ALLOCA_LISP, not alloca.
3541 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3542 intptr_t is wide enough.
3543 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3544 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3545 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3546 Check for fixnum out of range.
3547 * ftfont.c (ftfont_list): Don't assume index fits in int.
3548 Check that fixnums are in proper range for system types.
3549 (ftfont_shape_by_flt):
3550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3551 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3553 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3554 Check that fixnums are in proper range for system types.
3555 * gnutls.h: Adjust decls to match defn changes elsewhere.
3556 * gtkutil.c (xg_dialog_run):
3557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3558 (update_frame_tool_bar):
3559 Check that fixnums are in proper range for system types.
3560 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3561 (lookup_image): Check that fixnums are in range for system types.
3562 * indent.c (last_known_column, last_known_column_point):
3563 (current_column_bol_cache):
3564 (skip_invisible, current_column, check_display_width):
3565 (check_display_width, scan_for_column, current_column_1)
3566 (Findent_to, Fcurrent_indentation, position_indentation)
3567 (indented_beyond_p, Fmove_to_column, compute_motion):
3568 (Fcompute_motion, Fvertical_motion):
3569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3570 (last_known_column_modified): Use EMACS_INT, not int.
3571 (check_display_width):
3573 Check that fixnums and floats are in proper range for system types.
3574 (compute_motion): Don't assume index or fixnum fits in int.
3575 (compute_motion, Fcompute_motion):
3576 Use int, not EMACS_INT, when it is wide enough.
3577 (vmotion): Omit local var start_hpos that is always 0; that way
3578 we don't need to worry about overflow in expressions involving it.
3579 * indent.h: Adjust decls to match defn changes elsewhere.
3581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3582 Use int, not EMACS_INT, where int is wide enough.
3583 Remove unused members ovstring_chars_done and tab_offset;
3585 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3586 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3587 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3588 (make_gap, copy_text, insert, insert_and_inherit)
3589 (insert_before_markers, insert_before_markers_and_inherit)
3590 (insert_1, count_combining_before, count_combining_after)
3591 (insert_1_both, insert_from_string)
3592 (insert_from_string_before_markers, insert_from_string_1)
3593 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3594 (adjust_after_replace, adjust_after_insert, replace_range)
3595 (replace_range_2, del_range, del_range_1, del_range_byte)
3596 (del_range_both, del_range_2, modify_region)
3597 (prepare_to_modify_buffer, signal_before_change)
3598 (signal_after_change, Fcombine_after_change_execute):
3599 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3600 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3601 (balance_an_interval, split_interval_right, split_interval_left)
3602 (find_interval, next_interval, update_interval)
3603 (adjust_intervals_for_insertion, delete_node, delete_interval)
3604 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3605 (static_offset_intervals, offset_intervals)
3606 (merge_interval_right, merge_interval_left, make_new_interval)
3607 (graft_intervals_into_buffer, temp_set_point_both)
3608 (temp_set_point, set_point, adjust_for_invis_intang)
3609 (set_point_both, move_if_not_intangible, get_property_and_range)
3610 (get_local_map, copy_intervals, copy_intervals_to_string)
3611 (compare_string_intervals, set_intervals_multibyte_1):
3612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3613 * intervals.h: Adjust decls to match defn changes elsewhere.
3615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3616 * keyboard.c (this_command_key_count, this_single_command_key_start)
3617 (before_command_key_count, before_command_echo_length, echo_now)
3618 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3619 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3620 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3621 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3623 (last_non_minibuf_size, last_point_position, echo_truncate)
3624 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3625 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3626 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3627 (stuff_buffered_input):
3628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3629 (last_auto_save, command_loop_1, read_char):
3630 Use EMACS_INT, not int, to avoid integer overflow.
3631 (record_char): Avoid overflow in total_keys computation.
3632 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3633 * keyboard.h: Adjust decls to match defn changes elsewhere.
3634 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3635 (Fkey_description, Fdescribe_vector, Flookup_key):
3636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3637 (click_position): New function, to check that positions are in range.
3638 (Fcurrent_active_maps):
3640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3641 (Faccessible_keymaps, Fkey_description):
3642 (preferred_sequence_p):
3643 Don't assume fixnum can fit into int.
3644 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3645 Check for integer overflow in size calculations.
3646 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3647 avoid mishandling large integers.
3648 * lisp.h: Adjust decls to match defn changes elsewhere.
3649 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3650 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3651 (struct Lisp_Marker):
3652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3653 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3654 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3655 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3656 All callers changed.
3657 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3658 Assume the arg has valid form, since it always does.
3659 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3660 unsigned integer system type.
3661 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3662 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3664 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3665 (duration_to_sec_usec): New decl.
3666 * lread.c (read_from_string_index, read_from_string_index_byte)
3667 (read_from_string_limit, readchar, unreadchar, openp)
3668 (read_internal_start, read1, oblookup):
3669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3670 (Fload, readevalloop, Feval_buffer, Feval_region):
3671 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3672 (openp): Check for out-of-range argument to 'access'.
3673 (read1): Use int, not EMACS_INT, where int is wide enough.
3674 Don't assume fixnum fits into int.
3675 Fix off-by-one error that can read outside a buffer.
3676 (read_filtered_event): Use duration_to_sec_usec
3677 to do proper overflow checking on durations.
3678 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3679 in size calculation.
3680 (Fexecute_kbd_macro):
3681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3682 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3683 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3684 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3685 (set_marker_both, set_marker_restricted_both, marker_position)
3686 (marker_byte_position, Fbuffer_has_markers_at):
3687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3688 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3689 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3690 It now merely ensures that the menu is large enough, without
3691 necessarily growing it, as this avoids some integer overflow issues.
3692 All callers changed.
3693 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3695 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3696 Use SAFE_ALLOCA_LISP, not alloca.
3697 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3698 to EMACS_INT. Check that fixnums are in proper range for system types.
3699 * minibuf.c (minibuf_prompt_width, string_to_object)
3700 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3701 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3703 (get_minibuffer, read_minibuf_unwind):
3704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3705 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3706 this simplifies overflow checking. All callers changed.
3707 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3710 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3711 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3712 Check that fixnums are in proper range for system types.
3713 (Fx_create_frame, Fx_show_tip):
3714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3715 * nsfont.m (ns_findfonts, nsfont_list_family):
3716 Don't assume fixnum fits in long.
3717 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3719 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3721 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3723 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3724 (PRINTDECLARE, PRINTPREPARE):
3725 (strout, print_string):
3726 (print, print_preprocess, print_check_string_charset_prop)
3728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3730 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3731 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3732 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3733 (printchar, strout): Use xpalloc to catch size calculation overflow.
3734 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3735 (print_error_message): Use SAFE_ALLOCA, not alloca.
3736 (print_object): Use int, not EMACS_INT, where int is wide enough.
3737 (print_depth, new_backquote_output, print_number_index):
3738 Use ptrdiff_t, not int, where int might not be wide enough.
3739 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3740 (Fset_process_window_size, Fformat_network_address)
3741 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3743 Check that fixnums are in proper range for system types.
3744 (Fsignal_process): Simplify by avoiding a goto.
3745 Check for process-ids out of pid_t range rather than relying on
3747 (process_tick, update_tick): Use EMACS_INT, not int.
3748 (Fformat_network_address, read_process_output, send_process)
3749 (Fprocess_send_region, status_notify):
3750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3751 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3752 (wait_reading_process_output, read_process_output, exec_sentinel):
3753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3754 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3755 (Faccept_process_output): Use duration_to_sec_usec to do proper
3756 overflow checking on durations.
3757 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3758 Don't assume pid_t fits in int.
3759 * process.h (struct Lisp_Process): Members tick and update_tick
3760 are now of type EMACS_INT, not int.
3761 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3762 configured --with-wide-int.
3763 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3764 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3765 * search.c (looking_at_1, string_match_1):
3766 (fast_string_match, fast_c_string_match_ignore_case)
3767 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3768 (scan_newline, find_before_next_newline, search_command)
3769 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3770 (set_search_regs, wordify):
3773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3774 (string_match_1, search_buffer, set_search_regs):
3776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3777 (wordify): Check for overflow in size calculation.
3778 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3779 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3780 Check that fixnums are in proper range for system types.
3781 * sound.c (struct sound_device)
3782 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3784 (Fplay_sound_internal):
3785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3786 * syntax.c (struct lisp_parse_state, find_start_modiff)
3787 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3788 (Fparse_partial_sexp):
3789 Don't assume fixnums can fit in int.
3790 (struct lisp_parse_state, find_start_pos, find_start_value)
3791 (find_start_value_byte, find_start_begv)
3792 (update_syntax_table, char_quoted, dec_bytepos)
3793 (find_defun_start, prev_char_comend_first, back_comment):
3794 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3795 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3797 (Finternal_describe_syntax_value): Check that match_lisp is a
3798 character, not an integer, since the code stuffs it into int.
3799 (scan_words, scan_sexps_forward):
3800 Check that fixnums are in proper range for system types.
3802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3803 (scan_sexps_forward):
3804 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3805 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3806 * syntax.h: Adjust decls to match defn changes elsewhere.
3807 (struct gl_state_s):
3808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3809 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3810 MOST_POSITIVE_FIXNUM.
3811 * sysdep.c (wait_for_termination_1, wait_for_termination)
3812 (interruptible_wait_for_termination, mkdir):
3813 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3814 (emacs_read, emacs_write):
3815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3816 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3817 and double all fit in int.
3818 * term.c (set_tty_color_mode):
3819 Check that fixnums are in proper range for system types.
3820 * termhooks.h (struct input_event):
3821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3822 * textprop.c (validate_interval_range, interval_of)
3823 (Fadd_text_properties, set_text_properties_1)
3824 (Fremove_text_properties, Fremove_list_of_text_properties)
3825 (Ftext_property_any, Ftext_property_not_all)
3826 (copy_text_properties, text_property_list, extend_property_ranges)
3827 (verify_interval_modification):
3828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3829 (Fnext_single_char_property_change)
3830 (Fprevious_single_char_property_change):
3831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3832 (copy_text_properties):
3833 Check for integer overflow in index calculation.
3834 * undo.c (last_boundary_position, record_point, record_insert)
3835 (record_delete, record_marker_adjustment, record_change)
3836 (record_property_change):
3837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3838 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3840 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3841 (Fx_hide_tip, Fx_file_dialog):
3842 * w32menu.c (set_frame_menubar):
3843 Use ptrdiff_t, not int, for consistency with rest of code.
3844 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3845 (select_window, Fdelete_other_windows_internal)
3846 (window_scroll_pixel_based, window_scroll_line_based)
3847 (Frecenter, Fset_window_configuration):
3848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3849 (Fset_window_hscroll, run_window_configuration_change_hook)
3850 (set_window_buffer, temp_output_buffer_show, scroll_command)
3851 (Fscroll_other_window, Frecenter):
3852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3853 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3854 Don't assume fixnum fits in int.
3855 (Fset_window_scroll_bars):
3856 Check that fixnums are in proper range for system types.
3857 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3858 (string_pos, c_string_pos, number_of_chars, init_iterator)
3859 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3860 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3861 (compute_display_string_end, handle_face_prop)
3862 (face_before_or_after_it_pos, handle_invisible_prop)
3863 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3864 (display_prop_intangible_p, string_buffer_position_lim)
3865 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3866 (get_overlay_strings_1, get_overlay_strings)
3867 (iterate_out_of_display_property, forward_to_next_line_start)
3868 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3869 (get_next_display_element, set_iterator_to_next)
3870 (get_visually_first_element, compute_stop_pos_backwards)
3871 (handle_stop_backwards, next_element_from_buffer)
3872 (move_it_in_display_line_to, move_it_in_display_line)
3873 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3874 (add_to_log, message_dolog, message_log_check_duplicate)
3875 (message2, message2_nolog, message3, message3_nolog
3876 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3877 (current_message_1, truncate_echo_area, truncate_message_1)
3878 (set_message, set_message_1, store_mode_line_noprop)
3879 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3880 (text_outside_line_unchanged_p, check_point_in_composition)
3881 (reconsider_clip_changes)
3882 (redisplay_internal, set_cursor_from_row, try_scrolling)
3883 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3884 (redisplay_window, find_last_unchanged_at_beg_row)
3885 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3886 (trailing_whitespace_p, find_row_edges, display_line)
3887 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3888 (display_mode_element, store_mode_line_string)
3889 (pint2str, pint2hrstr, decode_mode_spec)
3890 (display_count_lines, display_string, draw_glyphs)
3891 (x_produce_glyphs, x_insert_glyphs)
3892 (rows_from_pos_range, mouse_face_from_buffer_pos)
3893 (fast_find_string_pos, mouse_face_from_string_pos)
3894 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3896 (safe_call, init_from_display_pos, handle_fontified_prop)
3897 (handle_single_display_spec, load_overlay_strings)
3898 (with_echo_area_buffer, setup_echo_area_for_printing)
3899 (display_echo_area, echo_area_display)
3900 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3901 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3902 (redisplay_window, dump_glyph_row, display_mode_line)
3903 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3904 (handle_display_spec, display_prop_string_p):
3905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3906 (handle_single_display_spec, build_desired_tool_bar_string)
3907 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3908 (get_specified_cursor_type):
3909 Check that fixnums are in proper range for system types.
3910 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3911 (Flookup_image_map):
3912 Don't assume fixnums fit in int.
3913 (compare_overlay_entries):
3914 Avoid mishandling comparisons due to subtraction overflow.
3915 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3916 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3917 (handle_tool_bar_click):
3918 Use int, not unsigned, since we prefer signed and the signedness
3919 doesn't matter here.
3920 (get_next_display_element, next_element_from_display_vector):
3921 Use int, not EMACS_INT, when int is wide enough.
3922 (start_hourglass): Use duration_to_sec_usec to do proper
3923 overflow checking on durations.
3924 * xfaces.c (Fbitmap_spec_p):
3925 Check that fixnums are in proper range for system types.
3926 (compare_fonts_by_sort_order):
3927 Avoid mishandling comparisons due to subtraction overflow.
3928 (Fx_family_fonts, realize_basic_faces):
3929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3931 Don't assume fixnum fits in int.
3932 Use SAFE_ALLOCA_LISP, not alloca.
3933 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3934 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3935 (face_at_buffer_position, face_for_overlay_string)
3936 (face_at_string_position):
3937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3938 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3939 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3941 Check that fixnums are in proper range for system types.
3942 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3943 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3945 (Fx_change_window_property): Don't assume fixnums fit in int.
3946 * xfont.c (xfont_chars_supported):
3947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3948 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3949 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3951 * xml.c (parse_region):
3952 * xrdb.c (magic_file_p):
3953 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3954 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3955 (x_get_local_selection, x_reply_selection_request)
3956 (x_handle_selection_request, wait_for_property_change):
3957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3958 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3959 short is wide enough.
3960 (x_send_client_event): Don't assume fixnum fits in int.
3961 * xterm.c (x_x_to_emacs_modifiers):
3962 Don't assume EMACS_INT overflows nicely into int.
3963 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3965 (handle_one_xevent): NATNUMP can eval its arg twice.
3966 (x_connection_closed):
3967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3968 * xterm.h: Adjust decls to match defn changes elsewhere.
3969 (struct scroll_bar): Use struct vectorlike_header
3970 rather than rolling our own approximation.
3971 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3973 2012-05-25 Glenn Morris <rgm@gnu.org>
3975 * lisp.mk (lisp): Update for more files being compiled now.
3977 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3979 * lread.c: Remove `read_pure' which makes no difference.
3980 (read_pure): Remove var.
3981 (unreadpure): Remove function.
3982 (readevalloop): Don't call read_list with -1 flag.
3983 (read1, read_vector): Don't test read_pure any more.
3984 (read_list): Simplify.
3986 * fileio.c, character.h: Minor style tweaks.
3988 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3990 * window.h (clip_changed): Remove useless declaration.
3992 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3994 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3995 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3997 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4000 This directory predates autoconf and is no longer needed nowadays.
4001 Move its few remaining bits of functionality to where they're needed.
4002 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4003 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4004 * m/template.h: Remove.
4005 * Makefile.in (M_FILE): Remove. All uses removed.
4006 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4007 * lisp.h (USE_LSB_TAG):
4008 * mem-limits.h (EXCEEDS_LISP_PTR):
4009 Use VAL_MAX, not VALBITS, in #if.
4010 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4011 (EMACS_UINT): Define unconditionally now.
4012 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4013 (BITS_PER_EMACS_INT): New constants, replacing
4014 what used to be in config.h, but not useful in #if.
4015 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4016 define them any more.
4017 (VAL_MAX): New macro.
4019 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4020 BITS_PER_EMACS_INT, in #if.
4021 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4022 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4023 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4024 * s/ms-w32.h (DATA_START):
4025 Move here from removed file m/intel386.h.
4026 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4027 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4029 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4031 Assume C89 or later.
4032 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4033 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4035 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4036 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4037 * textprop.c, tparam.c (NULL): Remove.
4038 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4039 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4040 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4041 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4042 * xterm.c (input_signal_count): Assume volatile works.
4044 2012-05-21 Ken Brown <kbrown@cornell.edu>
4046 * xgselect.c (xg_select): Fix first argument in call to 'select'
4049 2012-05-20 Ken Brown <kbrown@cornell.edu>
4051 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4052 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4054 2012-05-19 Ken Brown <kbrown@cornell.edu>
4056 * xfns.c (x_in_use): Remove `static' qualifier.
4057 * xterm.h (x_in_use): Declare.
4058 * xgselect.c: Include xterm.h.
4059 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4060 and `display_arg' (bug#9754).
4062 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4064 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4066 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4067 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4069 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4071 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4073 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4074 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4076 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4077 reference to image_cache->refcount.
4078 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4080 2012-05-17 Juri Linkov <juri@jurta.org>
4082 * search.c (Fword_search_regexp, Fword_search_backward)
4083 (Fword_search_forward, Fword_search_backward_lax)
4084 (Fword_search_forward_lax): Move functions to isearch.el
4085 (bug#10145, bug#11381).
4087 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4089 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4091 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4093 * lread.c (init_obarray): Declare Qt and Qnil as special.
4095 2012-05-14 Glenn Morris <rgm@gnu.org>
4097 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4098 Put "libexec" before "bin", for the sake of init_callproc_1.
4100 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4102 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4104 * unexaix.c: Port to more-recent AIX compilers.
4105 (report_error, report_error_1, make_hdr, copy_sym)
4106 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4107 Make arguments const char *, not char *, to avoid violations of C
4108 standard and to fix some AIX warnings reported by Gilles Pion.
4110 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4112 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4113 already have overlays loaded.
4114 (handle_single_display_spec): Before returning without displaying
4115 fringe bitmap, synchronize the bidi iterator with the main display
4116 iterator, by calling iterate_out_of_display_property.
4117 (iterate_out_of_display_property): Detect buffer iteration by
4118 testing that it->string is a Lisp string.
4119 (get_next_display_element): When the current object is exhausted,
4120 and there's something on it->stack, call set_iterator_to_next to
4121 proceed with what's on the stack, instead of returning zero.
4122 (set_iterator_to_next): If called at the end of a Lisp string,
4123 proceed to consider_string_end without incrementing string
4124 position. Don't increment display vector index past the end of
4125 the display vector. (Bug#11417)
4126 (pos_visible_p): Don't report a position visible when move_it_to
4127 stopped at the last line of window, which happens to be scanned
4128 backwards by the bidi iteration. (Bug#11464)
4130 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4132 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4133 and right-margin display specs even if the spec is invalid or we
4134 are on a TTY, and thus unable to display on the fringes.
4135 That's because the text with the property will not be displayed anyway,
4136 so we need to signal to the caller that this is a "replacing"
4137 display spec. This fixes display when the spec is invalid or we
4140 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4142 * unexaix.c (make_hdr): Fix typo in prototype.
4143 This bug broke the build on AIX. Problem reported by Gilles Pion.
4145 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4147 * keyboard.c (kbd_buffer_get_event): Read special events also in
4148 batch mode. (Bug#11415)
4150 2012-05-12 Glenn Morris <rgm@gnu.org>
4152 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4154 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4156 * lisp.mk (lisp): Add newcomment.elc.
4158 2012-05-12 Glenn Morris <rgm@gnu.org>
4160 * Makefile.in (MKDIR_P): New, set by configure.
4161 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4163 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4165 Remove unused function hourglass_started.
4166 * dispextern.h (hourglass_started):
4167 * w32fns.c (hourglass_started):
4168 * xdisp.c (hourglass_started): Remove.
4170 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4172 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4173 Update dependencies.
4175 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4177 * xgselect.c (xg_select): Put maxfds+1 into a var.
4178 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4180 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4182 2012-05-10 Dave Abrahams <dave@boostpro.com>
4184 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4185 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4187 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4189 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4190 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4191 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4192 Initialize xd_registered_buses.
4194 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4196 Untag more efficiently if USE_LSB_TAG.
4197 This is based on a proposal by YAMAMOTO Mitsuharu in
4198 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4199 For an admittedly artificial (nth 8000 longlist) benchmark on
4200 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4201 Emacs's overall text size by 1%.
4202 * lisp.h (XUNTAG): New macro.
4203 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4204 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4205 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4206 * eval.c (Fautoload):
4207 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4208 * frame.h (XFRAME): Use XUNTAG.
4210 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4211 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4212 Remove unportable assumptions about print widths of types like
4214 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4215 intptr_t when converting between pointer and integer, to avoid GCC
4216 warnings about wrong width.
4218 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4220 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4221 stack for each reader_thread, instead of defaulting to 8MB
4222 determined by the linker. This avoids failures in creating
4223 subprocesses on Windows 7, see the discussion in this thread:
4224 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4226 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4228 Fix up display of the *Minibuf-0* buffer in the mini window.
4229 * keyboard.c (read_char): Don't clear the echo area if there's no
4231 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4232 contents of *Minibuf-0*) if there's no message displayed in its stead.
4234 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4236 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4239 2012-05-06 Chong Yidong <cyd@gnu.org>
4241 * lisp.mk (lisp): Update.
4243 2012-05-05 Jim Meyering <meyering@redhat.com>
4245 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4247 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4249 * data.c (PUT_ERROR): New macro.
4250 (syms_of_data): Use it. Add new error type `user-error'.
4251 * undo.c (user_error): New function.
4252 (Fprimitive_undo): Use it.
4253 * print.c (print_error_message): Adjust print style for `user-error'.
4254 * keyboard.c (user_error): New function.
4255 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4257 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4259 Do not limit current-time-string to years 1000..9999.
4260 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4261 (Fcurrent_time_string): Support any year that is supported by the
4262 underlying localtime representation. Don't use asctime, as it
4263 has undefined behavior for years outside the range -999..9999.
4265 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4267 Fix race conditions involving setenv, gmtime, localtime, asctime.
4268 Without this fix, interrupts could mess up code that uses these
4269 nonreentrant functions, since setting TZ invalidates existing
4270 tm_zone or tzname values, and since most of these functions return
4271 pointers to static storage.
4272 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4273 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4274 Grow the critical sections to include not just invoking
4275 localtime/gmtime, but also accessing these functions' results
4276 including their tm_zone values if any, and any related TZ setting.
4277 (format_time_string): Last arg is now struct tm *, not struct tm **,
4278 so that the struct tm is saved in the critical section.
4279 All callers changed. Simplify allocation of initial buffer, partly
4280 motivated by the fact that memory allocation needs to be outside
4281 the critical section.
4283 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4285 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4286 with RESET_INTERVAL.
4288 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4289 Remove duplicated buffer name initialization.
4291 2012-05-02 Jim Meyering <jim@meyering.net>
4293 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4295 * xfns.c (x_window): Use xstrdup (Bug#11375).
4297 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4299 * xdisp.c (pos_visible_p): If already at a newline from the
4300 display string before the 'while' loop, don't walk back the glyphs
4301 from it3.glyph_row. Solves assertion violation when the display
4302 string begins with a newline (egg.el). (Bug#11367)
4304 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4306 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4309 2012-05-01 Glenn Morris <rgm@gnu.org>
4311 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4312 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4313 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4314 All were removed before 23.1.
4316 * dispnew.c: Remove HAVE_LIBNCURSES test;
4317 it is always true on relevant platforms.
4319 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4320 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4322 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4324 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4326 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4327 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4330 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4332 Do not avoid creating empty evaporating overlays (Bug#9642).
4333 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4334 That is, do not delete an evaporating overlay if it becomes
4335 empty after its bounds are adjusted to fit within its buffer.
4336 This fix caused other problems, and I'm reverting it until we get
4337 to the bottom of them.
4339 2012-04-27 Chong Yidong <cyd@gnu.org>
4341 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4343 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4345 * xdisp.c (pos_visible_p): If the window start position is beyond
4346 ZV, start the display from buffer beginning. Prevents assertion
4347 violation in init_iterator when the minibuffer window is scrolled
4350 * window.c (window_scroll_pixel_based): Likewise.
4352 2012-04-27 Chong Yidong <cyd@gnu.org>
4354 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4356 2012-04-27 Glenn Morris <rgm@gnu.org>
4358 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4359 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4361 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4363 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4364 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4366 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4368 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4369 display element, check also the underlying string or buffer
4370 character. (Bug#11341)
4372 * w32menu.c: Include w32heap.h.
4373 (add_menu_item): If the call to AppendMenuW (via
4374 unicode_append_menu) fails, disable Unicode menus only if we are
4375 running on Windows 9X/Me.
4377 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4379 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4380 (xgetint): Add missing shift for LSB tags.
4382 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4384 * keyboard.c (read_char): Don't wipe echo area for select window
4385 events: These might get delayed via `mouse-autoselect-window'
4388 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4390 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4391 manipulation of :loaded-from data.
4393 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4395 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4396 now a cons (bug#11311).
4398 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4400 Do not create empty overlays with the evaporate property (Bug#9642).
4401 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4402 if it becomes empty after its bounds are adjusted to fit within
4403 its buffer. Without this fix, in a nonempty buffer (let ((o
4404 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4405 yields an empty overlay that has the evaporate property, which is
4406 not supposed to happen.
4408 Fix minor GTK3 problems found by static checking.
4409 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4410 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4411 (struct _EmacsFixedClass, emacs_fixed_get_type):
4412 Move decls here from emacsgtkfixed.h, since they needn't be public.
4413 (emacs_fixed_get_type): Now static.
4414 (emacs_fixed_class_init): Omit unused local.
4415 (emacs_fixed_child_type): Remove; unused.
4416 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4417 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4418 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4419 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4420 (EMACS_FIXED_GET_CLASS): Remove; unused.
4421 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4423 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4424 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4426 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4428 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4429 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4430 (__malloc_size_t, __malloc_ptrdiff_t):
4431 Remove. All uses removed, replaced by the definiens if needed,
4432 since we can assume C89 or better now.
4433 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4434 (protect_malloc_state, align, get_contiguous_space)
4435 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4436 (malloc_atfork_handler_child, malloc_enable_thread)
4437 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4438 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4439 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4440 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4441 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4442 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4443 Define using prototypes, not old style.
4444 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4445 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4446 (align): Don't assume that signed integer overflow wraps around.
4447 Omit unused local var.
4448 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4449 (_free_internal_nolock, memalign, mallochook, reallochook):
4450 Omit no-longer-needed casts.
4451 (valloc): Use getpagesize, not __getpagesize.
4452 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4453 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4455 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4457 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4459 Move functions from C to Lisp. Make non-blocking method calls
4460 the default. Implement further D-Bus standard interfaces.
4462 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4463 (QCdbus_request_name_allow_replacement)
4464 (QCdbus_request_name_replace_existing)
4465 (QCdbus_request_name_do_not_queue)
4466 (QCdbus_request_name_reply_primary_owner)
4467 (QCdbus_request_name_reply_in_queue)
4468 (QCdbus_request_name_reply_exists)
4469 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4470 (QCdbus_registered_serial, QCdbus_registered_method)
4471 (QCdbus_registered_signal): New Lisp objects.
4472 (XD_DEBUG_MESSAGE): Use sizeof.
4473 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4474 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4475 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4476 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4477 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4478 (xd_signature, xd_append_arg): Allow float for integer types.
4479 (xd_get_connection_references): New function.
4480 (xd_get_connection_address): Rename from xd_initialize.
4481 Return cached address.
4482 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4483 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4485 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4486 Return number of refcounts.
4487 (Fdbus_get_unique_name): Make stronger parameter check.
4488 (Fdbus_message_internal): New defun.
4489 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4490 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4491 (Fdbus_send_signal, Fdbus_register_service)
4492 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4493 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4494 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4495 (Vdbus_compiled_version, Vdbus_runtime_version)
4496 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4497 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4498 (Vdbus_message_type_signal): New defvars.
4499 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4502 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4504 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4505 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4506 Do not assume ptrdiff_t is the same width as 'int'.
4508 * alloc.c: Handle unusual debugging option combinations.
4509 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4510 since the two debugging options are incompatible.
4511 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4513 (mem_init, mem_insert, mem_insert_fixup):
4514 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4515 (NEED_MEM_INSERT): Remove; no longer needed.
4517 2012-04-22 Leo Liu <sdl.web@gmail.com>
4519 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4521 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4523 * sysdep.c [__FreeBSD__]: Minor cleanups.
4524 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4525 Use Emacs indenting style more consistently. Avoid some casts.
4526 Use 'double' consistently rather than mixing 'float' and 'double'.
4528 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4530 * sysdep.c (list_system_processes, system_process_attributes):
4531 Add implementation for FreeBSD (Bug#5243).
4533 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4535 * lisp.mk (lisp): Update.
4537 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4539 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4540 It is never used otherwise.
4542 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4544 * print.c (print_preprocess): Only check print_depth if print-circle
4546 (print_object): Check for cycles even when print-circle is nil and
4547 print-gensym is t, but only check print_depth if print-circle is nil.
4549 2012-04-20 Chong Yidong <cyd@gnu.org>
4551 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4552 set the status to "failed" and ensure that sentinel is run.
4554 2012-04-20 Glenn Morris <rgm@gnu.org>
4556 * process.c (Fset_process_inherit_coding_system_flag)
4557 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4558 (Fmake_network_process, Fmake_serial_process): Doc fix.
4560 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4562 * xdisp.c (string_buffer_position_lim): Limit starting position to
4564 (set_cursor_from_row): If called for a mode-line or header-line
4565 row, return zero immediately.
4566 (try_cursor_movement): If inside continuation line, don't back up
4567 farther than the first row after the header line, if any.
4568 Don't consider the header-line row as "partially visible", even if
4569 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4571 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4573 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4576 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4577 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4579 configure: new option --enable-gcc-warnings (Bug#11207)
4580 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4581 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4582 (ALL_CFLAGS): Use new macros rather than old.
4583 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4584 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4585 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4586 -Wunused-result, -Wunused-variable. This should go away once
4587 the Emacs and Gnulib regex code is merged.
4588 (xmalloc, xrealloc): Now static.
4590 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4592 * dired.c (Fsystem_groups): Remove unused local.
4594 2012-04-17 Glenn Morris <rgm@gnu.org>
4596 * dired.c (Fsystem_users): Doc fix.
4598 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4600 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4601 (syms_of_dired): Add them.
4603 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4605 Fix minor alloc.c problems found by static checking.
4606 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4607 New extern decls, to avoid calling undeclared functions.
4608 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4609 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4610 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4611 (NEED_MEM_INSERT): New macro.
4612 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4613 Remove one incorrect comment and fix another.
4615 Fix minor ralloc.c problems found by static checking.
4616 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4617 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4618 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4619 (r_alloc_sbrk): Now static.
4621 Improve ralloc.c interface checking.
4622 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4623 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4624 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4625 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4626 [REL_ALLOC]: ... to here, to check interface.
4627 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4628 Remove decls. This fixes an "It stinks!".
4630 * alloc.c (which_symbols): Fix alignment issue / type clash.
4632 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4634 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4635 (struct Lisp_Misc_Any): Likewise.
4636 (struct Lisp_Free): Likewise.
4637 * alloc.c (union aligned_Lisp_Symbol): Define.
4638 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4639 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4640 (union aligned_Lisp_Misc): Define.
4641 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4642 aligned_Lisp_Misc instead of union Lisp_Misc.
4643 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4645 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4647 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4648 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4649 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4650 * s/netbsd.h, s/sol2-6.h:
4651 Remove definition of GC_MARK_STACK, since the default now works.
4652 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4653 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4654 no longer the default.
4655 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4657 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4659 * lread.c (lisp_file_lexically_bound_p):
4660 Fix hang at ";-*-\n" (bug#11238).
4662 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4664 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4665 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4667 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4669 * nsterm.m (constrainFrameRect): Always constrain when there is only
4670 one screen (Bug#10962).
4672 2012-04-13 Ken Brown <kbrown@cornell.edu>
4674 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4676 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4678 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4680 2012-04-11 Daniel Colascione <dancol@dancol.org>
4682 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4683 against is gone. It's better to use vfork now so that when Cygwin
4684 gains a new, working vfork, we use it automatically (bug#10398).
4686 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4688 * window.c (save_window_save): Obey window-point-insertion-type.
4690 2012-04-11 Glenn Morris <rgm@gnu.org>
4692 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4694 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4696 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4698 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4700 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4701 (force_quit_count): New var.
4702 (handle_interrupt): Use it.
4704 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4706 * w32.c (w32_delayed_load): Record the full path of the library
4707 being loaded (bug#10424).
4709 2012-04-09 Glenn Morris <rgm@gnu.org>
4711 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4712 not just in the obarray, before snarfing them. (Bug#11036)
4714 * Makefile.in ($(leimdir)/leim-list.el):
4715 Pass EMACS rather than BUILT_EMACS.
4717 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4719 * process.c (make_process):
4720 * process.h: Add integer `gnutls_handshakes_tried' member to
4723 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4724 Add convenience `GNUTLS_LOG2i' macro.
4726 * gnutls.c (gnutls_log_function2i): Convenience log function.
4727 (emacs_gnutls_read): Use new log functions,
4728 `gnutls_handshakes_tried' process member, and
4729 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4730 attempts per process (connection).
4732 2012-04-09 Chong Yidong <cyd@gnu.org>
4734 * eval.c (Fuser_variable_p, user_variable_p_eh)
4735 (lisp_indirect_variable): Functions deleted.
4736 (Fdefvar): Caller changed.
4738 * callint.c (Finteractive, Fcall_interactively):
4739 * minibuf.c (Fread_variable): Callers changed.
4741 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4743 * xdisp.c (set_cursor_from_row): If the display string appears in
4744 the buffer at position that is closer to point than the position
4745 after the display string, display the cursor on the first glyph of
4746 the display string. Fixes cursor display when a 'display' text
4747 property immediately follows invisible text. (Bug#11094)
4749 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4751 composite.c: use 'double' consistently
4752 * composite.c (get_composition_id): Use 'double' consistently
4753 instead of converting 'float' to 'double' and vice versa; this is
4754 easier to understand and avoids a GCC warning.
4756 2012-04-09 Glenn Morris <rgm@gnu.org>
4758 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4759 preparation for dumping it with emacs. (Bug#4789)
4760 (leimdir): New variable.
4761 ($(leimdir)/leim-list.el): New rule.
4762 (emacs$(EXEEXT)): Depend on leim-list.el.
4764 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4765 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4766 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4768 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4770 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4773 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4775 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4776 Remove unused local variable.
4778 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4780 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4781 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4782 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4783 objects, as mark_maybe_pointer will catch them otherwise.
4784 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4785 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4787 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4789 Fix typo that broke non-Windows builds.
4790 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4792 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4794 Support building on MS-Windows with libxml2.
4796 * makefile.w32-in (OBJ2): Add xml.$(O).
4797 (GLOBAL_SOURCES): Add xml.c.
4798 ($(BLD)/xml.$(O)): New dependency list.
4800 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4801 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4802 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4803 [!WINDOWSNT]: New macros.
4804 (init_libxml2_functions, libxml2_loaded_p): New functions.
4805 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4806 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4807 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4808 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4810 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4811 Call init_libxml2_functions before calling libxml2 functions.
4812 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4814 * emacs.c: Don't include libxml/parser.h.
4815 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4816 xmlCleanupParser directly.
4818 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4820 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4822 * indent.c (Fvertical_motion): If there is a display string at
4823 point, use it.vpos to compute how many lines to backtrack after
4824 move_it_to point. (Bug#11133)
4826 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4828 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4829 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4830 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4831 macros related to unification of CJK characters. For the details,
4832 see the discussion following the message here:
4833 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4835 2012-04-04 Chong Yidong <cyd@gnu.org>
4837 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4839 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4841 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4842 instead of alloca. (Bug#11138)
4844 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4846 * w32menu.c (is_simple_dialog): Properly check lisp types.
4849 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4851 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4852 position we get to after a call to move_it_to fails the
4853 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4854 only if we wind up in a string from display property. (Bug#11063)
4856 * window.c (Fdelete_other_windows_internal): Invalidate the row
4857 and column information about mouse highlight, so that redisplay
4858 restores it after reallocating the glyph matrices. (Bug#7464)
4860 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4861 string comes from a `display' text property, use the buffer
4862 position of that property as if we actually saw that position in
4864 (move_it_by_lines): Remove the assertion that
4865 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4866 violated when there's a before-string at the beginning of a line.
4869 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4871 * xdisp.c (append_space_for_newline): If the default face was
4872 remapped, use the remapped face for the appended newline.
4873 (extend_face_to_end_of_line): Use the remapped default face for
4874 extending the face to the end of the line.
4875 (display_line): Call extend_face_to_end_of_line when the default
4876 face was remapped. (Bug#11068)
4878 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4880 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4882 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4884 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4886 2012-03-27 Glenn Morris <rgm@gnu.org>
4888 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4891 2012-03-26 Kenichi Handa <handa@m17n.org>
4893 * dispextern.h (struct glyph): Fix previous change. Change the
4894 bit length of glyphless.ch to 25 (Bug#11082).
4896 2012-03-26 Chong Yidong <cyd@gnu.org>
4898 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4899 (command_loop_1): Use it; inhibit selection update for
4900 handle-select-window too (Bug#8996).
4902 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4904 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4906 2012-03-25 Kenichi Handa <handa@m17n.org>
4908 * dispextern.h (struct glyph): Change the bit length of
4909 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4911 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4913 * s/ms-w32.h (tzname): Include time.h before redirecting to
4914 _tzname. Fixes the MSVC build. (Bug#9960)
4916 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4918 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4921 * xterm.c (XTread_socket): Only modify handling_signal if
4922 !SYNC_INPUT. (Bug#11080)
4924 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4926 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4927 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4928 when fetching a multibyte character consumes more bytes than
4929 CHAR_BYTES returns, due to unification of CJK characters in
4930 string_char. (Bug#11073)
4932 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4934 * process.c (wait_reading_process_output): Handle pty disconnect
4935 by refraining from sending oneself a SIGCHLD (bug#10933).
4937 2012-03-22 Chong Yidong <cyd@gnu.org>
4939 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4941 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4942 Mark string as coming from a prefix property.
4943 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4944 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4946 2012-03-21 Chong Yidong <cyd@gnu.org>
4948 * xfaces.c (Vface_remapping_alist): Doc fix.
4950 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4952 * w32proc.c (Fw32_set_console_codepage)
4953 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4956 2012-03-20 Chong Yidong <cyd@gnu.org>
4958 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4959 to reflect default non-nil value of redisplay-dont-pause.
4961 2012-03-19 Kenichi Handa <handa@m17n.org>
4963 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4964 it fit in a valid range (Bug#11003).
4966 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4968 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4969 that is not from display property, accept the row as a "cursor
4970 row" if one of the string's character has a non-nil `cursor'
4971 property. Fixes cursor positioning when there are newlines in
4972 overlay strings, e.g. in icomplete.el. (Bug#11035)
4974 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4976 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4978 2012-03-12 Chong Yidong <cyd@gnu.org>
4980 * eval.c (inhibit_lisp_code): Rename from
4981 inhibit_window_configuration_change_hook; move from window.c.
4983 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4984 * window.c (run_window_configuration_change_hook)
4985 (syms_of_window): Callers changed.
4987 2012-03-11 Chong Yidong <cyd@gnu.org>
4989 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4991 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4993 2012-03-10 Chong Yidong <cyd@gnu.org>
4995 * frame.c (other_visible_frames): Don't assume the selected frame
4996 is visible (Bug#10955).
4998 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5000 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5002 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5004 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5005 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5008 2012-03-03 Glenn Morris <rgm@gnu.org>
5010 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5012 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5014 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5015 position past the first glyph_row that ends at ZV. (Bug#10902)
5016 (redisplay_window, next_element_from_string): Fix typos in
5018 (redisplay_window): Pass to move_it_vertically the margin in
5019 pixels, not in screen lines.
5021 2012-03-02 Glenn Morris <rgm@gnu.org>
5023 * buffer.c (buffer-list-update-hook): Doc fix.
5025 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5027 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5028 push_it before setting up the iterator for the first overlay
5029 string, even if we have an empty string loaded.
5030 (next_overlay_string): If there's an empty string on the iterator
5031 stack, pop the stack. (Bug#10903)
5033 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5035 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5036 Suggested by Stefan Monnier in
5037 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5038 * alloc.c (widen_to_Lisp_Object): New static function.
5039 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5040 and widening them to Lisp_Objects. This would work even if
5041 USE_LSB_TAG is defined and wide integers are used, which might
5042 happen in a future version of Emacs.
5044 2012-02-25 Chong Yidong <cyd@gnu.org>
5046 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5049 * xselect.c (Fx_selection_exists_p): Doc fix.
5050 (x_clipboard_manager_save_all): Print an informative message
5051 before saving to clipboard manager.
5053 2012-02-24 Chong Yidong <cyd@gnu.org>
5055 * keyboard.c (process_special_events): Handle all X selection
5056 requests in kbd_buffer, not just the next one (Bug#8869).
5058 2012-02-23 Chong Yidong <cyd@gnu.org>
5060 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5061 call when setting menu-bar-lines and tool-bar-lines parameters.
5062 (unwind_create_frame_1): New helper function.
5064 * window.c (inhibit_window_configuration_change_hook): New var.
5065 (run_window_configuration_change_hook): Obey it.
5066 (syms_of_window): Initialize it.
5068 2012-02-22 Chong Yidong <cyd@gnu.org>
5070 * xterm.c (x_draw_image_relief): Add missing type check for
5071 Vtool_bar_button_margin (Bug#10743).
5073 2012-02-21 Chong Yidong <cyd@gnu.org>
5075 * fileio.c (Vfile_name_handler_alist): Doc fix.
5077 * buffer.c (Fget_file_buffer): Protect against invalid file
5078 handler return value.
5080 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5082 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5083 when computing $valmask.
5085 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5086 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5087 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5088 It's useless in that case, and it can cause problems on hosts
5089 that allocate halves of EMACS_INT values separately.
5090 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5091 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5092 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5093 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5094 it avoids undefined behavior on hosts where shifting right by more
5095 than the word width has undefined behavior.
5097 2012-02-19 Chong Yidong <cyd@gnu.org>
5099 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5100 (Funhandled_file_name_directory, Ffile_name_as_directory)
5101 (Fdirectory_file_name, Fexpand_file_name)
5102 (Fsubstitute_in_file_name): Protect against invalid file handler
5103 return values (Bug#10845).
5105 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5107 * .gdbinit (pitx): Fix incorrect references to fields of the
5110 2012-02-17 Chong Yidong <cyd@gnu.org>
5112 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5114 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5116 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5117 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5119 2012-02-15 Chong Yidong <cyd@gnu.org>
5121 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5122 marked as special. Also, starting docstrings with * is obsolete.
5124 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5126 * gnutls.c (emacs_gnutls_write): Fix last change.
5128 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5130 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5133 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5135 * keymap.c (Fsingle_key_description): Handle char ranges.
5137 2012-02-12 Chong Yidong <cyd@gnu.org>
5139 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5140 as that creates a dangerous corner case.
5142 * window.c (Fdelete_window_internal): Invalidate the mouse
5143 highlight (Bug#9904).
5145 2012-02-12 Glenn Morris <rgm@gnu.org>
5147 * xselect.c (Fx_own_selection_internal)
5148 (Fx_get_selection_internal, Fx_disown_selection_internal)
5149 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5150 * nsselect.m (Fx_own_selection_internal)
5151 (Fx_disown_selection_internal, Fx_selection_exists_p)
5152 (Fx_selection_owner_p, Fx_get_selection_internal):
5153 Sync docs and argument specs with the xselect.c versions.
5155 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5157 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5159 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5161 * w32select.c (Fx_selection_exists_p): Sync doc string and
5162 argument list with xselect.c. (Bug#10783)
5164 * w16select.c (Fx_selection_exists_p): Sync doc string and
5165 argument list with xselect.c. (Bug#10783)
5167 2012-02-10 Glenn Morris <rgm@gnu.org>
5169 * fns.c (Fsecure_hash): Doc fix.
5171 2012-02-09 Kenichi Handa <handa@m17n.org>
5173 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5175 2012-02-07 Chong Yidong <cyd@gnu.org>
5177 * buffer.c (Fbuffer_local_variables)
5178 (buffer_lisp_local_variables): Handle unbound vars correctly;
5179 don't let Qunbound leak into Lisp.
5181 2012-02-07 Glenn Morris <rgm@gnu.org>
5183 * image.c (Fimagemagick_types): Doc fix.
5185 * image.c (imagemagick-render-type): Change it from a lisp object
5186 to an integer. Move the doc here from the lisp manual.
5187 Treat all values not equal to 0 the same.
5189 2012-02-06 Chong Yidong <cyd@gnu.org>
5191 * doc.c (store_function_docstring): Avoid applying docstring of
5192 alias to base function (Bug#2603).
5194 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5196 * .gdbinit (pp1, pv1): Remove redundant defines.
5199 2012-02-04 Chong Yidong <cyd@gnu.org>
5201 * nsterm.m: Declare a global (Bug#10694).
5203 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5205 * w32.c (get_emacs_configuration_options):
5206 Include --enable-checking, if specified, in the return value.
5208 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5210 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5211 after rounding frame sizes. (Bug#9723)
5213 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5215 * keyboard.c (adjust_point_for_property): Don't position point
5216 before BEGV. (Bug#10696)
5218 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5220 Handle overflow when computing char display width (Bug#9496).
5221 * character.c (char_width): Return EMACS_INT, not int.
5222 (char_width, c_string_width): Check for overflow when
5223 computing the width; this is possible now that individual
5224 characters can have unbounded width. Problem introduced
5225 by merge from Emacs 23 on 2012-01-19.
5227 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5229 * dbusbind.c (Fdbus_register_method): Mention the return value
5230 :ignore in the docstring.
5232 2012-02-02 Glenn Morris <rgm@gnu.org>
5234 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5236 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5237 Unconditionally set to t. (Bug#10673)
5238 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5239 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5240 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5242 2012-02-02 Kenichi Handa <handa@m17n.org>
5244 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5245 0, do not call append_composite_glyph.
5247 2012-02-02 Kenichi Handa <handa@m17n.org>
5249 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5251 (x_produce_glyphs): If the component of a composition is a null
5252 string, set it->pixel_width to 1 to avoid zero-width glyph.
5254 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5256 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5257 first 2 arguments are identical. This makes inserting large
5258 output from a subprocess an order of magnitude faster on
5259 MS-Windows, where all sbrk'ed memory is always contiguous.
5261 2012-01-31 Glenn Morris <rgm@gnu.org>
5263 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5264 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5265 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5267 2012-01-29 Glenn Morris <rgm@gnu.org>
5269 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5271 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5273 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5275 2012-01-28 Chong Yidong <cyd@gnu.org>
5277 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5279 2012-01-26 Chong Yidong <cyd@gnu.org>
5281 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5283 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5284 repeat counts (Bug#10507).
5286 2012-01-26 Glenn Morris <rgm@gnu.org>
5288 * lread.c (syms_of_lread): Doc fix.
5290 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5292 * coding.c (encode_designation_at_bol): Change return value to
5295 2012-01-25 Chong Yidong <cyd@gnu.org>
5297 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5299 2012-01-21 Chong Yidong <cyd@gnu.org>
5301 * floatfns.c (Fcopysign): Make the second argument non-optional,
5302 since nil is not allowed anyway.
5304 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5306 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5307 (send_process): Likewise.
5309 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5311 * window.c (save_window_save, Fcurrent_window_configuration)
5312 (Vwindow_persistent_parameters): Do not use Qstate.
5313 Rewrite doc-strings.
5315 2012-01-19 Kenichi Handa <handa@m17n.org>
5317 * character.c (char_width): New function.
5318 (Fchar_width, c_string_width, lisp_string_width):
5319 Use char_width (Bug#9496).
5321 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5323 * window.c (Vwindow_persistent_parameters): New variable.
5324 (Fset_window_configuration, save_window_save): Handle persistent
5327 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5329 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5330 thrashing the stack of the thread. (Bug#9087)
5332 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5334 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5336 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5338 * xdisp.c (rows_from_pos_range): Handle the case where the
5339 highlight ends on a newline. (Bug#10464)
5340 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5341 he end column for display of highlight that ends on a newline
5344 2012-01-11 Glenn Morris <rgm@gnu.org>
5346 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5347 from load-path also when installation-directory is nil. (Bug#10208)
5349 2012-01-10 Glenn Morris <rgm@gnu.org>
5351 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5353 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5354 Update template values to be closer to their typical values these days.
5356 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5358 * xdisp.c (rows_from_pos_range): Accept additional argument
5359 DISP_STRING, and accept any glyph in a row whose object is that
5360 string as eligible for mouse highlight. Fixes mouse highlight of
5361 display strings from overlays. (Bug#10464)
5363 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5365 emacs: fix an auto-save permissions race condition (Bug#10400)
5366 * fileio.c (auto_saving_dir_umask): New static var.
5367 (Fmake_directory_internal): Use it.
5368 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5369 creating the directory. The old code temporarily assigns
5370 too-generous permissions to the directory.
5371 (do_auto_save_eh): Clear it.
5372 (Fdo_auto_save): Catch all errors, not just file errors, so
5373 that the var is always cleared.
5375 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5377 * search.c (scan_buffer): Pass character positions to
5378 know_region_cache, not byte positions. (Bug#6540)
5380 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5382 * w32.c (sys_rename): Report EXDEV when rename of a directory
5383 fails because the target is on another logical disk. (Bug#10284)
5385 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5387 * xterm.c (x_embed_request_focus): New function.
5389 * xterm.h: Add prototype.
5391 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5393 2012-01-05 Glenn Morris <rgm@gnu.org>
5395 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5397 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5399 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5400 Load gnutls_transport_set_lowat only if GnuTLS version is below
5402 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5403 GnuTLS versions below 2.11.1.
5405 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5407 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5408 to the doc string advising against its use for altering the way
5409 windows are scrolled.
5411 2011-12-28 Kenichi Handa <handa@m17n.org>
5413 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5414 coding-system ASCII compatible only when it does not produce BOM
5415 on encoding (Bug#10383).
5417 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5419 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5421 (create_and_show_popup_menu): Always use menu_position_func for
5424 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5426 * callint.c (Fcall_interactively): Don't truncate prompt string.
5428 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5430 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5431 property that ends at ZV, so that the bidi iteration could be
5432 resumed from there (after widening). (Bug#10360)
5434 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5436 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5438 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5440 * nsterm.m (x_free_frame_resources):
5441 Release f->output_data.ns->miniimage.
5442 (ns_index_color): Fix indentation. Do not retain
5443 color_table->colors[i].
5445 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5448 * nsfns.m (x_set_background_color): Assign return value from
5449 ns_index_color to face-background instead of NSColor*.
5450 (ns_implicitly_set_icon_type): Fix indentation.
5451 Change assignment in for loop to comparison.
5453 * emacs.c (ns_pool): New variable.
5454 (main): Assign ns_pool.
5455 (Fkill_emacs): Call ns_release_autorelease_pool.
5457 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5458 autorelease fdesc, release fdAttrs and tdict.
5459 (ns_get_covering_families): Release charset.
5460 (ns_findfonts): Release NSFontDescriptor created with new.
5461 (ns_uni_to_glyphs): Fix indentation.
5462 (setString): Release attrStr before assigning new value.
5464 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5466 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5468 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5469 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5471 2011-12-18 David Reitter <reitter@cmu.edu>
5473 * nsterm.m (ns_term_init): Subscribe for notifications
5474 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5475 to method trackingNotification in EmacsMenu.
5477 * nsmenu.m (trackingMenu): New variable.
5478 (trackingNotification): New method (from Aquamacs).
5479 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5480 from Aquamacs (Bug#7030).
5482 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5484 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5485 (symbol_to_nsstring): Fix indentation.
5486 (ns_symbol_to_pb): New function.
5487 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5488 (Fns_rotate_cut_buffers_internal): Remove.
5489 (Fns_store_selection_internal): Rename from
5490 Fns_store_cut_buffer_internal.
5491 (ns_get_foreign_selection, Fx_own_selection_internal)
5492 (Fx_disown_selection_internal, Fx_selection_exists_p)
5493 (Fns_get_selection_internal, Fns_store_selection_internal):
5494 Use ns_symbol_to_pb and check if return value is nil.
5495 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5496 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5497 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5498 renamed to Sns_store_selection_internal.
5499 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5500 and remove this function.
5501 (ns_handle_selection_clear): Remove, never used.
5502 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5505 2011-12-17 Ken Brown <kbrown@cornell.edu>
5507 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5508 GID is unknown (Bug#10257).
5510 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5512 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5513 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5514 which caused a build failure on GNU/Linux IA-64. This problem was
5515 introduced by my 2011-10-07 patch.
5517 2011-12-15 Juri Linkov <juri@jurta.org>
5519 * image.c (imagemagick_error): New function. (Bug#10112)
5520 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5521 Use `imagemagick_error' where ImageMagick functions return
5523 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5526 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5528 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5529 fill background (Bug#8992).
5531 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5533 * window.c (Vwindow_combination_resize)
5534 (Vwindow_combination_limit): Use t instead of non-nil in
5536 (Vrecenter_redisplay): Add first sentence of doc-string on
5538 (Frecenter): Fix doc-string typo.
5540 2011-12-11 Kenichi Handa <handa@m17n.org>
5542 * coding.c (Funencodable_char_position): Pay attention to the
5543 buffer text relocation (Bug#9389).
5545 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5547 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5548 gtk_init (Bug#10100).
5550 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5552 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5553 IT->string is nil. (Bug#10263)
5555 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5557 * nsterm.h (x_free_frame_resources): Declare.
5559 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5560 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5562 * nsterm.h (ns_get_defaults_value): Declare.
5564 * nsterm.m (ns_default): Call ns_get_defaults_value.
5566 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5568 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5571 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5573 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5574 that where the value of an _OBJC_* symbol points to is in the .bss
5575 section (Bug#10240).
5577 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5579 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5580 after the loop to call ccl_driver at least once (Bug#8619).
5582 2011-12-08 Kenichi Handa <handa@m17n.org>
5584 * ftfont.c (get_adstyle_property): Fix previous change
5587 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5589 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5590 dirs from the default value of EMACSLOADPATH (bug#10208).
5592 2011-12-07 Glenn Morris <rgm@gnu.org>
5594 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5595 installation and source directories as well. (Bug#10208)
5597 2011-12-06 Chong Yidong <cyd@gnu.org>
5599 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5601 2011-12-06 Glenn Morris <rgm@gnu.org>
5603 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5604 as an error, not just -1. (Bug#10217)
5606 2011-12-05 Chong Yidong <cyd@gnu.org>
5608 * keyboard.c (process_special_events): New function.
5609 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5611 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5613 * coding.c (encode_designation_at_bol): Don't use uninitialized
5614 local variable (Bug#9318).
5616 2011-12-05 Kenichi Handa <handa@m17n.org>
5618 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5619 return Qnil (Bug#8046, Bug#10193).
5621 2011-12-05 Kenichi Handa <handa@m17n.org>
5623 * coding.c (encode_designation_at_bol): New args charbuf_end and
5624 dst. Return the number of produced bytes. Callers changed.
5625 (coding_set_source): Return how many bytes coding->source was
5627 (coding_set_destination): Return how many bytes
5628 coding->destination was relocated.
5629 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5630 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5632 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5634 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5635 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5638 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5640 The following changes are to fix Bug#9318.
5642 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5643 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5644 (encode_coding_iso_2022, encode_coding_sjis)
5645 (encode_coding_big5, encode_coding_charset): Use the above macros.
5647 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5649 * lisp.h (process_quit_flag): Fix external declaration.
5651 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5653 Don't macro-inline non-performance-critical code.
5654 * eval.c (process_quit_flag): New function.
5655 * lisp.h (QUIT): Use it.
5657 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5659 * nsfns.m (get_geometry_from_preferences): New function.
5660 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5662 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5664 * emacs.c (Qkill_emacs): Define.
5665 (syms_of_emacs): Initialize it.
5666 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5667 Qquit_flag to `kill-emacs' instead.
5668 (quit_throw_to_read_char): Add parameter `from_signal'.
5669 All callers changed. Call Fkill_emacs if requested and safe.
5670 * lisp.h (QUIT): Call Fkill_emacs if requested.
5672 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5674 * widget.c (update_wm_hints): Return if wmshell is null.
5675 (widget_update_wm_size_hints): New function.
5677 * widget.h (widget_update_wm_size_hints): Declare.
5679 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5680 widget_update_wm_size_hints (Bug#10104).
5682 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5684 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5685 before a newline, prepare the bidi iterator for consuming the
5686 newline, and keep the current paragraph direction. (Bug#10183)
5687 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5689 2011-12-02 Juri Linkov <juri@jurta.org>
5691 * search.c (Fword_search_regexp): New Lisp function created from
5692 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5693 (Fword_search_backward, Fword_search_forward)
5694 (Fword_search_backward_lax, Fword_search_forward_lax):
5695 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5696 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5698 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5700 * fileio.c (Finsert_file_contents): Move after-change-function call
5701 to before the "handled:" label, since all "goto handled" appear in
5702 cases where the *-change-functions have already been properly called
5705 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5707 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5708 waiting for input. (Bug#10169)
5710 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5712 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5713 verifies glyph row's hash code--we have just reallocated the
5714 glyphs, so their contents can be complete garbage. (Bug#10164)
5716 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5718 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5720 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5722 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5723 attributes are tested _before_ calling verify_row_hash, to protect
5724 against GCC re-ordering of the tests. (Bug#10164)
5726 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5728 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5730 * xterm.c (handle_one_xevent): Only set async_visible and friends
5731 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5732 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5733 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5735 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5737 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5738 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5739 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5740 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5741 All uses changed to use GCPRO1 etc.
5742 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5743 Revert to old implementation (i.e., before 2011-03-11).
5745 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5747 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5748 of scroll runs so as to avoid assigning disabled bogus rows and
5749 unnecessary graphics copy operations.
5751 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5753 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5754 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5755 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5756 (malloc, free, realloc, calloc): Redirect to e_* only when
5759 * lisp.h (GCTYPEBITS): Move before first use.
5760 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5761 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5762 this macro definition.
5764 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5767 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5769 * gtkutil.c (xg_create_frame_widgets):
5770 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5771 present with Gtk+ 2.0.
5773 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5775 * fileio.c (Finsert_file_contents): Undo previous change; see
5776 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5778 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5780 Rename locals to avoid shadowing.
5781 * fileio.c (Finsert_file_contents):
5782 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5783 * process.c (wait_reading_process_output):
5784 Rename inner 'proc' to 'p' to avoid shadowing.
5785 Indent for consistency with usual Emacs style.
5787 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5789 * xdisp.c (redisplay_window): If cursor row is not fully visible
5790 after recentering, and scroll-conservatively is set to a large
5791 number, scroll window by a few more lines to make the cursor fully
5792 visible and out of scroll-margin. (Bug#10105)
5793 (start_display): Don't move to the next line if the display should
5794 start at a newline that is part of a display vector or an overlay
5797 2011-11-24 Juri Linkov <juri@jurta.org>
5799 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5800 after the `MagickPingImage' call. (Bug#10112)
5802 2011-11-23 Chong Yidong <cyd@gnu.org>
5804 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5806 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5808 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5809 making another buffer current. (Bug#10114)
5811 2011-11-23 Glenn Morris <rgm@gnu.org>
5813 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5815 2011-11-23 Chong Yidong <cyd@gnu.org>
5817 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5818 using it (Bug#5984).
5820 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5822 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5823 and header-lines, as they don't have one computed for them.
5826 * .gdbinit (prow): Make displayed values more self-explaining.
5827 Add row's hash code.
5829 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5831 * process.c (wait_reading_process_output): Fix asynchrounous
5832 GnuTLS socket handling on some versions of the GnuTLS library.
5833 (wait_reading_process_output): Add comment and URL.
5835 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5837 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5839 2011-11-21 Chong Yidong <cyd@gnu.org>
5841 * window.c (Fnext_window, Fprevious_window): Doc fix.
5843 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5845 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5847 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5849 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5851 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5853 * window.c (Fset_window_combination_limit): Rename argument
5855 (Vwindow_combination_limit): Remove "status" from doc-string.
5857 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5859 * m/ibms390.h: Remove.
5860 * m/ibms390x.h: Don't include "ibms390.h".
5862 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5864 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5865 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5867 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5869 * casetab.c (Fset_case_table):
5870 * charset.c (Fcharset_after): Fix typos.
5872 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5874 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5875 Otherwise, valgrind does not work on some platforms.
5876 Problem reported by Andreas Schwab in
5877 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5878 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5879 is set, removing the need for VIRT_ADDRESS_VARIES.
5880 (PURE_P): Use a more-efficient implementation that needs just one
5881 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5882 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5883 to 4 (xorl, subq, cmpq, setbe).
5884 * alloc.c (pure): Always extern now, since that's the
5885 VIRT_ADDR_VARIES behavior.
5886 (PURE_POINTER_P): Use a single comparison, not two, for
5887 consistency with the new puresize.h.
5888 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5889 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5890 Remove VIRT_ADDR_VARIES no longer needed.
5892 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5894 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5895 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5896 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5897 behave as if the cursor position were at the window margin.
5899 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5900 and the cursor position is out of bounds, behave as if the cursor
5901 position were at the window margin. (Bug#10075)
5903 2011-11-18 Chong Yidong <cyd@gnu.org>
5905 * window.c (Fwindow_combination_limit): Make first argument
5906 non-optional, since it is meaningless for live windows like the
5909 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5911 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5913 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5915 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5916 (graft_intervals_into_buffer): Simplify.
5918 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5920 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5921 hash values of the two rows.
5922 (copy_row_except_pointers): Preserve the used[] arrays and the
5923 hash values of the two rows. (Bug#10035)
5924 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5926 * xdisp.c (row_hash): New function, body extracted from
5927 compute_line_metrics.
5928 (compute_line_metrics): Call row_hash, instead of computing the
5931 * dispnew.c (verify_row_hash): Call row_hash for computing the
5932 hash code of a row, instead of duplicating code from xdisp.c.
5934 * dispextern.h (row_hash): Add prototype.
5936 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5938 * frame.c (delete_frame): Don't delete the terminal when the last
5939 X frame is closed if emacs is built with GTK toolkit.
5941 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5943 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5945 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5947 * window.c (Vwindow_splits): Rename to
5948 Vwindow_combination_resize. Suggested by Juri Linkov.
5949 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5952 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5954 * nsfns.m (Fns_font_name):
5955 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5957 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5959 * window.h (window): Rename slot "nest" to "combination_limit".
5960 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5961 (Fset_window_nest): Rename to Fset_window_combination_limit.
5962 (Vwindow_nest): Rename to Vwindow_combination_limit.
5963 (recombine_windows, make_parent_window, make_window)
5964 (Fsplit_window_internal, saved_window)
5965 (Fset_window_configuration, save_window_save): Rename all
5966 occurrences of window_nest to window_combination_limit.
5968 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5970 * image.c (imagemagick_load_image): Fix typo.
5972 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5974 * xdisp.c (display_line): Move the call to
5975 highlight_trailing_whitespace before the call to
5976 compute_line_metrics, since the latter needs to see the final
5977 faces of all the glyphs to compute ROW's hash value.
5978 Fixes assertion violations in row_equal_p. (Bug#10035)
5980 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5982 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5983 just return (bug#10044).
5985 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5987 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5988 with user-defined heap size. Bump the default size of the temacs
5989 heap to 27MB, to avoid memory warning when running temacs.
5990 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5992 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5993 current_matrix and desired_matrix. (Bug#9990)
5994 (verify_row_hash) [XASSERTS]: New function.
5995 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5996 that the hash value of glyph rows is correct.
5998 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6000 * window.h (window): Remove splits slot.
6001 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6002 (Fdelete_other_windows_internal, make_parent_window)
6003 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6004 (Fset_window_configuration, save_window_save): Don't deal with
6005 split status of windows.
6006 (saved_window): Remove splits slot.
6007 (Vwindow_splits): Rewrite doc-string.
6009 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6011 * xfns.c (unwind_create_frame):
6012 * nsfns.m (unwind_create_frame):
6013 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6014 Vframe_list (Bug#9999).
6016 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6018 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6020 2011-11-11 Kenichi Handa <handa@m17n.org>
6022 * callproc.c (Fcall_process): Set the member dst_multibyte of
6025 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6027 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6028 avoid a crash (bug#9496).
6030 2011-11-09 Chong Yidong <cyd@gnu.org>
6032 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6033 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6035 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6037 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6039 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6041 Avoid some portability problems by eschewing 'extern inline' functions.
6042 The trivial performance wins aren't worth the portability hassles; see
6043 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6045 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6046 (window_box_width, window_box_left, window_box_left_offset)
6047 (window_box_right, window_box_right_offset): Undo previous change,
6048 by removing the "extern"s.
6049 * intervals.c (adjust_intervals_for_insertion)
6050 (adjust_intervals_for_deletion): Undo previous change,
6051 making these static again.
6052 (offset_intervals, temp_set_point_both, temp_set_point)
6053 (copy_intervals_to_string): No longer inline.
6054 * xdisp.c (window_text_bottom_y, window_box_width)
6055 (window_box_height, window_box_left_offset)
6056 (window_box_right_offset, window_box_left, window_box_right)
6057 (window_box): No longer inline.
6059 2011-11-08 Chong Yidong <cyd@gnu.org>
6061 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6062 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6063 Signal an error if not a live window.
6064 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6065 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6067 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6069 * lisp.h (syms_of_abbrev): Remove declaration.
6070 Reported by CHENG Gao <chenggao@royau.me>.
6072 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6074 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6075 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6076 of temacs in GUI mode.
6078 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6080 * window.h: Declare delete_all_child_windows instead of
6081 delete_all_subwindows.
6082 * window.c (Fwindow_nest, Fset_window_nest)
6083 (Fset_window_new_total, Fset_window_new_normal)
6084 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6085 (delete_all_subwindows): Rename to delete_all_child_windows.
6086 (Fdelete_other_windows_internal, Fset_window_configuration):
6087 Call delete_all_child_windows instead of delete_all_subwindows.
6088 * frame.c (delete_frame): Call delete_all_child_windows instead
6089 of delete_all_subwindows.
6091 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6093 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6094 This is also needed for porting to any host where GC_MARK_STACK is
6095 not GC_MAKE_GCPROS_NOOPS.
6096 (which_symbols): Use it.
6098 2011-11-07 Kenichi Handa <handa@m17n.org>
6100 * coding.c (coding_set_destination): Check coding->src_pos only
6101 when coding->src_object is a buffer (bug#9910).
6103 * process.c (send_process): Set the member src_multibyte of coding
6104 to 0 (bug#9911) when sending a unibyte text.
6106 * callproc.c (Fcall_process): Set the member src_multibyte of
6107 process_coding to 0 (bug#9912).
6109 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6111 * xmenu.c (cleanup_widget_value_tree): New function.
6112 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6113 calling free_menubar_widget_value_tree directly (Bug#9830).
6115 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6117 Fix some portability problems with 'inline'.
6118 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6119 (window_box_width, window_box_left, window_box_left_offset)
6120 (window_box_right, window_box_right_offset): Declare extern.
6121 Otherwise, these inline functions do not conform to C99 and
6122 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6123 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6124 * intervals.c (adjust_intervals_for_insertion)
6125 (adjust_intervals_for_deletion): Now extern, because otherwise the
6126 extern inline functions 'offset_intervals' couldn't refer to it.
6127 (static_offset_intervals): Remove.
6128 (offset_intervals): Rewrite using the old contents of
6129 static_offset_intervals. The old version didn't conform to C99
6130 because an extern inline function contained a reference to an
6131 identifier with static linkage.
6133 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6135 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6138 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6140 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6141 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6142 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6143 return Qleft_to_right.
6145 2011-11-06 Chong Yidong <cyd@gnu.org>
6147 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6148 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6149 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6150 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6151 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6152 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6153 (Fwindow_vscroll): Doc fix.
6154 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6155 argument, since it makes no sense to pass a live window and for
6156 consistency with window-child.
6158 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6160 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6163 2011-11-05 Jason Rumney <jasonr@gnu.org>
6165 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6166 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6168 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6169 bitwise arithmetic preventing use of unicode-sip and non-truetype
6172 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6174 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6177 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6178 initialization code to keep similarity to xfns.c after changes
6181 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6183 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6184 (unwind_create_frame): New function (Bug#9943).
6185 (Fx_create_frame): Restructure code to be more similar to the one in
6186 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6187 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6188 Move terminal->reference_count++ just before making the frame official
6191 * nsterm.m (x_free_frame_resources): New function.
6192 (x_destroy_window): Move code to x_free_frame_resources.
6194 * xfns.c (unwind_create_frame): Fix comment.
6195 (Fx_create_frame, x_create_tip_frame):
6196 Move terminal->reference_count++ just before making the frame
6197 official. Move initialization of image_cache_refcount and
6198 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6200 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6202 Support MSVC build with newer versions of Visual Studio.
6203 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6204 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6207 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6208 which are not supported by MSVC.
6209 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6210 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6212 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6214 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6216 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6218 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6220 Support MSVC build with newer versions of Visual Studio.
6221 * w32.c: Don't include w32api.h for MSVC.
6222 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6224 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6225 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6226 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6227 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6229 (alloca) [_MSC_VER]: Define to _alloca.
6231 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6233 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6235 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6237 * xdisp.c (note_mouse_highlight): If either of
6238 previous/next-single-property-change returns nil, treat that as
6239 the beginning or the end of the buffer. (Bug#9955)
6241 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6243 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6244 label is not null (Bug#9951).
6245 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6248 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6250 * window.c (Fwindow_body_size): Mention in the doc string that the
6251 return value is in frame's canonical units. (Bug#9949)
6253 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6255 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6257 * w32fns.c (unwind_create_frame): If needed, free the glyph
6258 matrices of the partially constructed frame. (Bug#9943)
6259 * xfns.c (unwind_create_frame): Likewise.
6261 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6263 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6264 Don't stop backward scan on the continuation glyph, even though
6265 its CHARPOS is positive.
6266 (mouse_face_from_buffer_pos, note_mouse_highlight):
6267 Rename cover_string to disp_string.
6269 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6271 * window.c (temp_output_buffer_show): Don't use
6272 Vtemp_buffer_show_specifiers.
6273 (Vtemp_buffer_show_specifiers): Remove unused variable.
6275 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6277 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6278 past the beginning of the current glyph matrix.
6280 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6282 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6283 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6284 HAVE_GTK3 (Bug#9869).
6286 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6287 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6289 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6291 * xterm.c: Declare x_handle_net_wm_state to return int.
6292 (handle_one_xevent): Check if we are iconified but don't have
6293 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6294 (get_current_wm_state): Return non-zero if not hidden,
6295 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6296 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6297 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6298 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6300 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6302 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6303 so that this new function doesn't get optimized away by a
6304 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6306 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6308 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6310 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6312 Fix the `xbytecode' command.
6313 * .gdbinit (xprintbytestr): New command.
6314 (xwhichsymbols): Rename from `which'; all callers changed.
6315 (xbytecode): Print the byte-code string as well.
6317 2011-10-29 Kim Storm <storm@cua.dk>
6319 * alloc.c (which_symbols): New function.
6321 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6323 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6326 2011-10-29 Glenn Morris <rgm@gnu.org>
6328 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6329 Not clear what it was for, and it causes various bugs. (Bug#9839)
6331 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6333 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6334 possible random value that matches one of those tested as
6335 condition to clear the mouse face.
6337 2011-10-28 Chong Yidong <cyd@gnu.org>
6339 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6341 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6343 * window.c (make_window): Initialize phys_cursor_on_p.
6345 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6347 * lisp.h (struct Lisp_Symbol): Update comments.
6349 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6351 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6353 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6355 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6356 <oslsachem@gmail.com> for helping to debug this.
6358 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6359 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6360 (g_b_init_get_glyph_outline_w): New static variables.
6361 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6362 (GetGlyphOutlineW_Proc): New typedefs.
6363 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6364 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6366 (w32font_open_internal, compute_metrics):
6367 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6368 instead of calling the "wide" APIs directly.
6370 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6372 * w32.h (syms_of_w32font): Add prototype.
6374 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6376 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6377 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6378 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6379 (Fmove_to_window_line): Doc fix.
6381 2011-10-27 Chong Yidong <cyd@gnu.org>
6383 * process.c (make_process): Set gnutls_state to NULL.
6385 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6386 non-NULL, regardless of GNUTLS_INITSTAGE.
6387 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6388 an error. Set process slots as soon as we allocate them.
6390 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6392 2011-10-27 Chong Yidong <cyd@gnu.org>
6394 * gnutls.c (emacs_gnutls_deinit): New function.
6395 Deallocate credentials structures as well as calling gnutls_deinit.
6396 (Fgnutls_deinit, Fgnutls_boot): Use it.
6398 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6399 (deactivate_process): Call emacs_gnutls_deinit.
6401 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6403 * image.c (x_create_x_image_and_pixmap):
6404 * w32.c (sys_rename, w32_delayed_load):
6405 * w32font.c (fill_in_logfont):
6406 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6408 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6410 * w32fns.c (w32_default_color_map): New function,
6411 extracted from Fw32_default_color_map.
6412 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6414 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6416 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6418 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6420 * keyboard.c (test_undefined): New function (bug#9751).
6421 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6423 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6425 * sysdep.c (init_sys_modes): Fix the check for the controlling
6426 terminal (Bug#6649).
6428 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6430 * dispextern.h (struct bidi_it): New member next_en_type.
6432 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6433 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6434 current character, check also for next_en_type being WEAK_EN.
6435 (bidi_resolve_weak): Don't enter the expensive loop if the current
6436 position is before next_en_pos. Record the bidi type of the first
6437 non-ET, non-BN character we find, in addition to its position.
6438 (bidi_level_of_next_char): Invalidate next_en_type when
6439 next_en_pos is over-stepped.
6441 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6443 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6444 * editfns.c: Rewrite current-time-zone so that it invokes
6445 the equivalent of (format-time-string "%Z") to get the time zone name.
6446 This fixes a bug when the time zone name contains characters that
6447 need converting from the system time locale to Emacs internal format.
6448 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6449 that patch fixed format-time-string to do the conversion, but
6450 I forgot to fix current-time-zone.
6451 (format_time_string): New function, containing most of
6452 what Fformat_time_string used to contain.
6453 (Fformat_time_string): Rewrite in terms of format_time_string.
6454 This doesn't change this function's behavior.
6455 (current-time-zone): Rewrite to use format_time_string.
6456 This fixes the bug reported by Michael Schierl in
6457 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6458 Jason Rumney's 2007-06-07 change worked around this bug, but
6460 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6462 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6464 * xdisp.c (start_display): If the character at POS is displayed
6465 via a display vector, reset IT->current.dpvec_index to zero.
6466 (try_window_reusing_current_matrix): If a line ends in a display
6467 vector or the next line starts in a display vector, continue
6468 redrawing the window even though the character position of
6469 start_row was reached.
6472 2011-10-18 Chong Yidong <cyd@gnu.org>
6474 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6475 with nobreak-char-display too.
6477 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6479 Fix part 3 of bug#9771.
6480 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6481 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6482 non-neutral characters if the current character is a paragraph
6483 separator (a.k.a. Newline). This avoids running the same
6484 expensive loop twice, once when we consume the preceding newline
6485 and the other time when the line actually needs to be displayed.
6486 Avoid the loop when we see neutrals on the base embedding level
6487 following a character whose directionality is the same as the
6488 paragraph's. This avoids running the expensive loop when a line
6489 ends in a long sequence of neutrals, like control characters.
6490 Add assertion against STRONG_AL type. Slightly rearrange code
6491 that determines the type of a neutral given the first non-neutral
6493 (bidi_level_of_next_char): Set next_en_pos to zero when
6494 invalidating its info.
6496 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6498 * xdisp.c (push_display_prop): Determine whether to record string
6499 or buffer position by IT->string, not by IT->method. Allow
6500 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6501 (move_it_vertically_backward): Don't look for character position
6502 immediately after the newline when in a continuation line.
6505 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6507 * window.c (coordinates_in_window): Rewrite and delabelize
6508 vertical border check. (Bug#5357) (Bug#9618)
6510 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6512 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6513 errors in XSetWindowBorder (bug#9310).
6515 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6517 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6518 avoid crash when xmalloc overrun checking is enabled.
6520 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6522 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6523 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6524 cursor motion with <left> and <right> arrow keys.
6526 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6527 some callers set that themselves.
6529 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6531 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6532 display string and the previous row comes from the same string and
6533 is empty. (Bug#9739) (Bug#9738)
6535 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6537 * doc.c (get_doc_string): Encode file name (bug#9735).
6539 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6541 * bidi.c (bidi_level_of_next_char):
6542 * xdisp.c (get_visually_first_element): Remove old incorrect
6543 comments regarding the Unicode Line Separator character.
6545 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6547 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6549 * alloc.c (Fgc_status): Do not access beyond zombies array
6550 boundary if nzombies > MAX_ZOMBIES.
6551 * alloc.c (dump_zombies): Add missing format specifier.
6553 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6555 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6556 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6558 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6559 Some packages use them to denote characters with modifiers.
6561 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6563 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6564 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6565 matching a pp-number. Rename parameter var to var1.
6567 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6569 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6571 2011-10-08 Glenn Morris <rgm@gnu.org>
6573 * callint.c (Fcall_interactively): Give a more explicit error for the
6574 'c' case with a non-character input. (Bug#8479)
6576 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6578 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6580 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6581 lines that are hscrolled on the left.
6583 * dispnew.c (buffer_posn_from_coords): Account for a possible
6584 presence of header-line. (Bug#4426)
6586 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6588 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6589 Don't advertise functionality which we discourage or doesn't work.
6591 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6593 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6594 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6595 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6596 this makes Emacs dump core during garbage collection on rare
6597 occasions. sizeof is obviously inferior to offsetof here, so
6598 stick with offsetof.
6599 (GC_POINTER_ALIGNMENT): New macro.
6600 (mark_memory): Omit 3rd (offset) arg; caller changed.
6601 Don't assume EMACS_INT alignment is the same as pointer alignment.
6603 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6605 * keyboard.c (read_key_sequence_remapped): New var.
6606 (read_key_sequence): Compute remapping in the right buffer.
6607 (command_loop_1): Use read_key_sequence's remapping directly.
6609 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6611 * dired.c (file_name_completion): Don't expand file name.
6612 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6613 before checking file name handler.
6615 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6616 they've been requested explicitly (bug#9591).
6618 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6620 * keymap.c (Fsingle_key_description): Use make_specified_string
6621 instead of build_string to build string from push_key_description.
6624 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6626 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6627 This fixes a Y2038 bug on 64-bit hosts.
6628 * buffer.c (reset_buffer):
6629 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6630 (Fclear_buffer_auto_save_failure):
6631 Use 0, not -1, to represent an unset failure time, since time_t
6632 might not be signed.
6634 Remove dependency on glibc malloc internals.
6635 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6636 Move back here from lisp.h, but with their new implementations.
6637 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6638 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6639 * charset.c (charset_table_init): New static var.
6640 (syms_of_charset): Use it instead of xmalloc. This removes a
6641 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6642 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6643 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6644 Move back to alloc.c.
6645 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6646 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6648 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6650 * nsterm.m (windowDidResize): Call x_set_window_size only when
6651 ns_in_resize is true. Otherwise set pixelwidth/height and
6652 call change_frame_size (Bug#9628).
6654 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6656 Port --enable-checking=all to Fedora 14 x86-64.
6657 * charset.c (syms_of_charset): Also account for glibc malloc's
6658 internal overhead when calculating the initial malloc maximum.
6660 Port --enable-checking=all to Fedora 14 x86.
6661 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6663 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6664 (overrun_check_realloc, overrun_check_free):
6665 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6666 That way, xmalloc returns a properly-aligned pointer even if
6667 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6668 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6669 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6670 into account when calculating the initial malloc maximum.
6671 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6672 Move here from alloc.c, so that charset.c can use it too.
6673 Properly align; the old code wasn't right for common 32-bit hosts
6674 when configured with --enable-checking=all.
6675 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6676 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6678 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6680 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6683 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6685 * xdisp.c (compute_display_string_end): If there's no display
6686 string at CHARPOS, return -1.
6688 * bidi.c (bidi_fetch_char): When compute_display_string_end
6689 returns a negative value, treat the character as a normal
6690 character not covered by a display string. (Bug#9624)
6692 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6694 * lread.c (Fread_from_string): Fix typo in docstring.
6696 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6698 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6699 newline, reseat the iterator instead of bidi-iterating there one
6700 character at a time. (Bug#9610)
6701 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6702 TO_CHARPOS if the bidi iterator is at base embedding level.
6704 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6706 * lread.c (readevalloop): Use correct code for NBSP.
6707 (read1): Likewise. (Bug#9608)
6709 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6711 * dbusbind.c (Fdbus_register_signal): When service is not
6712 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6714 2011-09-25 Glenn Morris <rgm@gnu.org>
6716 * buffer.c (truncate-lines): Doc fix.
6718 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6720 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6721 (Fset_window_next_buffers): Doc fix.
6723 2011-09-24 Glenn Morris <rgm@gnu.org>
6725 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6727 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6729 Fix minor problems found by static checking.
6730 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6731 * indent.c (Fvertical_motion): Fix == vs = typo.
6733 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6735 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6736 Default value is now t. Doc fix.
6738 * indent.c (Fvertical_motion): Compute and apply the overshoot
6739 logic when moving up, not only when moving down. Fix the
6740 confusing name and values of the it_overshoot_expected variable;
6741 logic changes accordingly. (Bug#9254) (Bug#9549)
6743 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6744 CHARPOS is covered by a display string which includes newlines.
6745 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6746 is covered by a display string with embedded newlines.
6748 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6750 * dbusbind.c (Fdbus_register_signal): Add match rule to
6751 Vdbus_registered_objects_table. (Bug#9581)
6752 (Fdbus_register_method, Vdbus_registered_objects_table):
6755 2011-09-24 Jim Meyering <meyering@redhat.com>
6757 do not ignore write error for any output size
6758 The previous change was incomplete.
6759 While it makes emacs --batch detect the vast majority of stdout
6760 write failures, errors were still ignored whenever the output size is
6761 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6762 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6763 && echo FAIL: ignored write error
6764 FAIL: ignored write error
6765 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6766 && echo FAIL: ignored write error
6767 FAIL: ignored write error
6768 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6770 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6772 * emacs.c (Fkill_emacs): In noninteractive mode exit
6773 non-successfully if a write error occurred on stdout. (Bug#9574)
6775 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6777 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6780 * dispextern.h (struct it): Update the comment documenting what
6783 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6785 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6786 a display string, extend search for cursor position to end of row.
6787 (find_row_edges): If the row ends in a newline from a display
6788 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6789 Handle the case of a display string with multiple newlines.
6790 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6791 non-empty line. Fixes confusing cursor motion with arrow keys at
6792 the beginning of a line that starts with whitespace.
6794 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6796 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6799 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6801 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6804 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6806 * xdisp.c (display_line): Record maximum and minimum buffer
6807 positions even if no glyphs were produced (e.g., by a zero-width
6808 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6809 buffer positions that will be removed from the glyph row because
6811 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6812 column is beyond frame width: don't subtract 1 "pixel" when
6813 computing width of the stretch.
6814 (reseat_at_next_visible_line_start): Undo the change made on
6815 2011-09-17 that saved paragraph information and restored it after
6816 the call to `reseat'. (Bug#9545)
6818 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6820 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6821 and turn window cursor on if cleared (Bug#9415).
6823 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6825 * search.c (boyer_moore): Take unibyte characters from pattern
6826 literally. (Bug#9458)
6828 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6830 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6832 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6834 Fix minor problem found by static checking.
6835 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6836 initialized, to pacify gcc -Wuninitialized.
6838 * fileio.c: Report proper errno when syscall falls.
6839 (Finsert_file_contents): Save and restore errno,
6840 so that report_file_error outputs the correct diagnostic.
6841 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6843 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6845 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6847 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6849 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6850 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6852 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6854 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6855 about the current paragraph and restore it after the call to reseat.
6857 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6858 (bidi_find_paragraph_start): Search back for paragraph beginning
6859 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6860 (bidi_move_to_visually_next): Only trigger paragraph-related
6861 computations when the last character is a newline or at EOB, not
6862 just any NEUTRAL_B. (Bug#9470)
6864 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6865 truncated lines if point is covered by a display string. (Bug#9524)
6867 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6869 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6870 (cons_to_x_long): New function.
6871 (lisp_data_to_selection_data): Use it. Correct the test for
6872 short-versus-long data; it was negated. Break out of vector
6873 loop, for efficiency, when a long datum is discovered.
6875 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6877 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6879 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6881 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6882 GCC PR/17406) by declaring this function with external scope.
6884 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6886 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6887 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6889 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6891 * editfns.c (Fformat): Correctly handle text properties on "%%".
6893 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6895 * xterm.c (x_draw_composite_glyph_string_foreground):
6896 * w32term.c (x_draw_composite_glyph_string_foreground):
6897 * term.c (encode_terminal_code):
6898 * composite.c (composition_update_it, get_composition_id):
6899 * xdisp.c (get_next_display_element)
6900 (fill_composite_glyph_string): Add comments about special meaning
6901 of TAB characters in a composition.
6903 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6905 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6906 This occurs when processing a multibyte format.
6907 Problem reported by Wolfgang Jenker.
6909 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6911 * xdisp.c (try_cursor_movement): Only check for exact match if
6912 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6914 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6916 Remove unused external symbols.
6917 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6918 * xdisp.c (calc_pixel_width_or_height): Now static.
6919 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6920 * indent.c (check_display_width):
6921 * w32term.c: Fix comment to match code.
6922 * xterm.c, xterm.h (x_catching_errors): Remove.
6924 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6926 * xselect.c: Use signed conversions more consistently (Bug#9498).
6927 (selection_data_to_lisp_data): Assume incoming selection data are
6928 signed integers, not unsigned. This is to be consistent with
6929 outgoing selection data, which was modified to use signed integers
6930 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6931 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6932 expects long, not unsigned long.
6934 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6936 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6937 computation of loop end. Reported by Johan Bockgård
6940 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6942 * frame.c (Fother_visible_frames_p): Function deleted.
6944 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6946 * indent.c (compute_motion): Process display vector front to back
6947 rather than the other way around. (Bug#2496)
6949 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6951 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6953 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6955 * minibuf.c (Fread_from_minibuffer): Doc fix.
6957 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6959 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6960 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6962 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6964 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6965 value for non-existent files.
6967 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6969 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6970 set its "size" to -1. This will set the modtime_size field of
6971 the corresponding buffer to -1, which is what
6972 verify-visited-file-modtime expects for files that do not exist.
6975 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6977 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6979 * lisp.h: ... from here. push_key_description is no longer
6980 defined in keyboard.c, so its declaration should not be in
6981 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6982 logically belongs with push_key_description.
6984 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6986 * buffer.h: Include <sys/types.h> instead of <time.h>.
6987 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6988 Problem reported by Herbert J. Skuhra.
6990 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6992 * xml.c (parse_region): Make the parsing work for
6993 non-comment-starting XML files again (bug#9144).
6995 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6997 * image.c (gif_load): Fix calculation of bottom and right corner.
7000 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7002 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7003 redisplay in small windows.
7005 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7007 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7009 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7011 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7012 Operate on live windows only.
7014 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7016 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7018 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7020 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7021 only under bidi iteration.
7023 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7025 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7027 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7029 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7030 Without this fix, the command to link temacs failed due to an
7031 undefined symbol __builtin_isnan. This is because
7032 /usr/include/iso/math_c99.h #defines isnan(x) to
7033 __builtin_isnan(x), but the bundled gcc, which identifies itself
7034 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7036 * floatfns.c (isnan): #undef, and then #define to a clone of
7038 (Fisnan): Always define, since it's always available now.
7039 (syms_of_floatfns): Always define isnan at the Lisp level.
7041 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7043 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7045 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7047 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7048 The previous code assumed that file offsets (off_t values) fit in
7049 EMACS_INT variables, which is not true on typical 32-bit hosts.
7050 The code messed up by falsely reporting buffer overflow in cases
7051 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7052 when "big" contains more than 2**29 bytes, even though this
7053 inserts just one byte and does not overflow the buffer.
7054 (Finsert_file_contents): Store file offsets as off_t
7055 values, not as EMACS_INT values. Check for overflow when
7056 converting between EMACS_INT and off_t. When checking for
7057 buffer overflow or for overlap, take the offsets into account.
7058 Don't use EMACS_INT for small values where int suffices.
7059 When checking for overlap, fix a typo: ZV was used where
7060 ZV_BYTE was intended.
7061 (Fwrite_region): Don't assume off_t fits into 'long'.
7062 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7064 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7066 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7068 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7070 sprintf-related integer and memory overflow issues (Bug#9412).
7072 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7073 (esprintf, exprintf, evxprintf): New functions.
7074 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7075 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7076 (modify_event_symbol): Do not assume that the length of
7077 name_alist_or_stem is safe to alloca and fits in int.
7078 (Fexecute_extended_command): Likewise for function name and binding.
7079 (Frecursion_depth): Wrap around reliably on integer overflow.
7080 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7081 since some callers pass EMACS_INT values.
7082 (Fsingle_key_description): Don't crash if symbol name contains more
7083 than MAX_ALLOCA bytes.
7084 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7085 (get_minibuffer): Arg is now EMACS_INT, not int.
7086 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7087 (esprintf, exprintf, evxprintf): New decls.
7088 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7090 * dbusbind.c (signature_cat): New function.
7091 (xd_signature, Fdbus_register_signal):
7092 Do not overrun buffer; instead, report string overflow.
7094 * dispnew.c (add_window_display_history): Don't overrun buffer.
7095 Truncate instead; this is OK since it's just a log.
7097 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7098 even if the time zone offset is outlandishly large.
7099 Don't mishandle offset == INT_MIN.
7101 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7102 when creating daemon; the previous buffer-overflow check was incorrect.
7104 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7105 which has the guts of the old verror function.
7107 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7108 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7110 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7111 (font_unparse_xlfd): Don't blindly alloca long strings.
7112 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7113 fits in int, when using sprintf. Use single snprintf to count
7114 length of string rather than counting it via multiple sprintfs;
7115 that's simpler and more reliable.
7116 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7117 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7118 sprintf, in case result does not fit in int.
7120 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7121 (fontset_from_font): Print it.
7123 * frame.c (tty_frame_count): Now printmax_t, not int.
7124 (make_terminal_frame, set_term_frame_name): Print it.
7125 (x_report_frame_params): In X, window IDs are unsigned long,
7126 not signed long, so print them as unsigned.
7127 (validate_x_resource_name): Check for implausibly long names,
7128 and don't assume name length fits in 'int'.
7129 (x_get_resource_string): Don't blindly alloca invocation name;
7130 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7133 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7134 (xg_check_special_colors, xg_set_geometry):
7135 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7137 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7138 Use esprintf, not sprintf, in case result does not fit in int.
7140 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7141 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7142 it as a large positive number.
7143 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7144 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7146 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7147 in case result does not fit in int.
7149 * print.c (float_to_string): Detect width overflow more reliably.
7150 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7151 buffer overrun. Don't assume list length fits in 'int'. Treat
7152 print length of 0 as 0, not as infinity; to be consistent with other
7153 uses of print length in this function. Don't overflow print length
7154 index. Don't assume hash table size fits in 'long', or that
7155 vectorlike size fits in 'unsigned long'.
7157 * process.c (make_process): Use printmax_t, not int, to format
7158 process-name gensyms.
7160 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7162 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7163 to avoid potential buffer overrun.
7165 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7166 if X resource line is longer than 512 bytes.
7168 * xfns.c (x_window): Make sprintf buffer a bit bigger
7169 to avoid potential buffer overrun.
7171 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7173 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7175 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7177 Integer overflow fixes for scrolling, etc.
7178 Without these, Emacs silently mishandles large integers sometimes.
7179 For example, "C-u 4294967297 M-x recenter" was treated as if
7180 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7182 * xdisp.c (try_window_id): Check Emacs fixnum range before
7183 converting to 'int'.
7185 * window.c (window_scroll_line_based, Frecenter):
7186 Check that an Emacs fixnum is in range before assigning it to 'int'.
7187 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7188 values converted from Emacs fixnums.
7189 (Frecenter): Don't wrap around a line count if it is out of 'int'
7190 range; instead, treat it as an extreme value.
7191 (Fset_window_configuration, compare_window_configurations):
7192 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7194 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7195 that can exceed INT_MAX. Check that EMACS_INT value is in range
7196 before assigning it to the (possibly-narrower) index.
7197 (match_limit): Don't assume that a fixnum can fit in 'int'.
7199 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7202 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7203 (Fvertical_motion): Don't wrap around LINES values that don't fit
7204 in 'int'. Instead, treat them as extreme values. This is good
7205 enough for windows, which can't have more than INT_MAX lines anyway.
7207 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7209 * Require libxml/parser.h to avoid compilation warning.
7211 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7213 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7214 since this reportedly can destroy thread storage.
7216 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7218 * syntax.c (find_defun_start): Update all cache variables if
7219 exiting early (Bug#9401).
7221 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7223 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7225 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7226 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7227 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7229 * term.c (tty_append_glyph): New function.
7230 (produce_stretch_glyph): Static function and its prototype deleted.
7232 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7235 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7237 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7238 when checking :margin (Bug#9390).
7239 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7240 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7241 so that the name doesn't mislead. All uses changed.
7243 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7245 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7248 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7250 * xdisp.c (move_it_to): Don't bail out early when reaching
7251 position beyond to_charpos, if we are scanning backwards.
7252 (move_it_vertically_backward): When DY == 0, make sure we get to
7253 the first character in the line after the newline.
7255 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7257 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7258 (ccl_driver): Do not generate an out-of-range pointer.
7259 (Fccl_execute_on_string): Remove unnecessary check for
7260 integer overflow, noted by Stefan Monnier in
7261 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7262 Remove a FIXME that didn't need fixing.
7263 Simplify the newly-introduced buffer reallocation code.
7265 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7267 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7269 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7271 Integer and memory overflow issues (Bug#9196).
7273 * doc.c (get_doc_string): Rework so that
7274 get_doc_string_buffer_size is the actual buffer size, rather than
7275 being 1 less than the actual buffer size; this makes xpalloc more
7278 * image.c (x_allocate_bitmap_record, cache_image):
7279 * xselect.c (Fx_register_dnd_atom):
7280 Simplify previous changes by using xpalloc.
7282 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7283 since either will do and ptrdiff_t is convenient with xpalloc.
7285 * charset.c (charset_table_size)
7286 (struct charset_sort_data.priority): Now ptrdiff_t.
7287 (charset_compare): Don't overflow if priorities differ greatly.
7288 (Fsort_charsets): Don't assume list length fits in int.
7289 Check for size-calculation overflow when allocating sort data.
7290 (syms_of_charset): Allocate an initial charset table that is
7291 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7293 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7295 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7296 The actual value is always <= INT_MAX, and leaving it unsigned made
7297 overflow checking harder.
7299 * dispextern.h (struct glyph_matrix.rows_allocated)
7300 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7301 with xpalloc. The values are still always <= INT_MAX.
7303 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7305 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7306 (SAFE_NALLOCA): New macro.
7308 * region-cache.c (struct boundary.pos, find_cache_boundary)
7309 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7310 (set_cache_region, invalidate_region_cache)
7311 (revalidate_region_cache, know_region_cache, region_cache_forward)
7312 (region_cache_backward, pp_cache):
7313 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7314 so that ptrdiff_t * can be passed to xpalloc.
7315 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7316 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7317 (pp_cache): Don't assume cache_len fits in int.
7318 * region-cache.h: Adjust extern decls to match.
7320 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7321 EMACS_INT, since either will do, for xpalloc.
7323 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7324 (xnmalloc, xnrealloc, xpalloc): New functions.
7326 * bidi.c (bidi_shelve_header_size): New constant.
7327 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7328 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7330 * bidi.c (bidi_cache_shrink):
7331 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7333 Don't update size of array until after memory allocation succeeds,
7334 because xmalloc/xrealloc may not return.
7335 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7336 now that we have proper integer overflow checking.
7337 (record_overlay_string, overlay_strings): Catch overflows when
7338 calculating size of overlay_str_buf.
7340 * callproc.c (Fcall_process): Check for size overflow when
7341 calculating size of args2.
7342 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7343 Normally we prefer signed values, but sticking with ptrdiff_t would
7344 require adding more-complicated checks.
7346 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7347 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7348 Redo buffer-overflow calculations to avoid integer overflow.
7349 Add a FIXME comment where memory seems to be over-allocated.
7351 * character.c (Fstring): Check for size-calculation overflow.
7353 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7354 unnecessary integer overflow. Check for size overflow.
7355 (encode_coding_object): Don't update size until xmalloc succeeds.
7357 * composite.c (get_composition_id): Check for overflow in glyph
7358 length calculations.
7360 Integer and memory overflow fixes for display code.
7361 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7362 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7363 (scrolling_window): Check for overflow in size calculations.
7364 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7365 Don't assume glyph table len fits in int.
7366 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7367 (row_table_size): Now ptrdiff_t, not int.
7368 (scrolling_window): Avoid overflow in size calculations.
7369 Don't update size until allocation succeeds.
7370 * fns.c (concat): Check for overflow in size calculations.
7371 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7372 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7373 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7375 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7376 (get_doc_string): Check for size calculation overflow.
7377 Don't update size until allocation succeeds.
7378 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7379 EMACS_INT, where ptrdiff_t will do.
7380 (Fsubstitute_command_keys): Check for string overflow.
7382 * editfns.c (set_time_zone_rule): Don't assume environment length
7384 (message_length): Now ptrdiff_t, not int.
7385 (Fmessage_box): Don't update size until allocation succeeds.
7386 Don't assume message length fits in int.
7387 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7389 * emacs.c (main): Do not reallocate argv, since there is a null at
7390 the end that can be overwritten, and this way there's no need to
7391 worry about size-calculation overflow.
7392 (sort_args): Check for size-calculation overflow.
7394 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7396 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7398 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7399 (x_set_scroll_bar_width, x_figure_window_size):
7400 Check for integer overflow.
7401 (x_set_alpha): Do not assume XINT fits in int.
7403 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7404 This is for the members text_lines, text_cols, total_lines, total_cols,
7405 where the system imposes an 'int' limit.
7407 * fringe.c (Fdefine_fringe_bitmap):
7408 Don't update size until alloc works.
7410 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7411 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7413 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7414 Check for size-calculation overflow.
7415 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7416 do, as we prefer signed integers.
7417 (id_to_widget.max_size, id_to_widget.used)
7418 (xg_store_widget_in_map, xg_remove_widget_from_map)
7419 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7420 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7421 Use and return ptrdiff_t, not int.
7422 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7423 * gtkutil.h: Change prototypes to match the above.
7425 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7426 are duplicate now that they've been promoted to lisp.h.
7427 (x_allocate_bitmap_record, x_alloc_image_color)
7428 (make_image_cache, cache_image, xpm_load):
7429 Don't update size until alloc is done.
7430 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7432 Check for size calculation overflow.
7433 (ct_colors_allocated_max): New constant.
7434 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7437 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7438 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7439 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7440 Use ptrdiff_t, not int, to count maps.
7441 (read_char_minibuf_menu_prompt): Check for overflow in size
7442 calculations. Don't update size until allocation succeeds.
7443 Redo calculations to avoid overflow.
7444 * keyboard.h: Change prototypes to match the above.
7446 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7448 (current_minor_maps): Check for size calculation overflow.
7449 * keymap.h: Change prototypes to match the above.
7451 * lread.c (read1, init_obarray): Don't update size until alloc done.
7453 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7454 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7456 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7457 Now ptrdiff_t, not int.
7458 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7459 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7461 * process.c (Fnetwork_interface_list): Check for overflow
7462 in size calculation.
7464 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7466 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7467 overflow. Don't bother calling xmalloc when xrealloc will do.
7469 * search.c (Freplace_match): Check for size calculation overflow.
7470 (Fset_match_data): Don't assume list lengths fit in 'int'.
7472 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7473 for command line length. Do not attempt to address one before the
7474 beginning of an array, as that's not portable.
7476 * term.c (max_frame_lines): Remove; unused.
7477 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7479 (encode_terminal_code, calculate_costs): Check for size
7480 calculation overflow.
7481 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7482 table lengths and related sizes. Don't update size until alloc
7483 done. Redo calculations to avoid overflow.
7484 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7486 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7487 subtracting pointers.
7488 (gobble_line): Check for overflow more carefully. Don't update size
7491 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7492 Don't update size until alloc done.
7493 Redo size calculations to avoid overflow.
7494 Check for size calculation overflow.
7495 (main) [DEBUG]: Fix typo in invoking tparam1.
7497 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7498 Use ptrdiff_t, not int, for sizes.
7499 (store_mode_line_noprop_char): Don't update size until alloc done.
7501 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7502 Use ptrdiff_t, not int, for sizes.
7503 (Finternal_make_lisp_face, cache_face):
7504 Check for size calculation overflow.
7505 (cache_face): Treat size calculation overflows as if they were
7506 memory exhaustion (the usual treatment), rather than aborting.
7508 * xfns.c (x_encode_text, x_set_name_internal)
7509 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7510 sizes, since they can exceed INT_MAX in size. Check for size
7511 calculation overflow.
7513 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7514 (xg_select): Check for size calculation overflow.
7515 Don't update size until alloc done.
7517 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7518 as sprintf is limited to int lengths.
7520 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7521 (X_LONG_MIN): New macros.
7522 Use them to make the following changes clearer.
7523 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7524 This change doesn't affect the value now, but it may help remind
7525 future maintainers not to raise the value too much later.
7526 (SELECTION_QUANTUM): Remove, replacing with ...
7527 (selection_quantum): ... new function, which avoids overflow.
7529 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7530 assumption that selection length fits in 'int'.
7531 (x_reply_selection_request, x_handle_selection_request)
7532 (x_get_window_property, receive_incremental_selection)
7533 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7534 (lisp_data_to_selection_data, clean_local_selection_data):
7535 Use ptrdiff_t, not int, to record length of selection.
7536 (x_reply_selection_request, x_get_window_property)
7537 (receive_incremental_selection, x_property_data_to_lisp):
7538 Redo calculations to avoid overflow.
7539 (x_reply_selection_request): When sending hint, ceiling it at
7540 X_LONG_MAX rather than relying on wraparound overflow to send
7542 (x_get_window_property, receive_incremental_selection)
7543 (lisp_data_to_selection_data, x_property_data_to_lisp):
7544 Check for size-calculation overflow.
7545 (x_get_window_property, receive_incremental_selection)
7546 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7547 Don't store size until memory allocation succeeds.
7548 (x_get_window_property): Plug memory leak on memory exhaustion.
7549 Don't double-block input; malloc is safe here. Don't assume 2**34
7550 - 4 fits in unsigned long. Add an xassert to check
7551 XGetWindowProperty overflow. Be more careful about overflow
7552 calculations, and distinguish size from memory overflow better.
7553 (receive_incremental_selection): When tracing, don't assume
7554 unsigned int is less than INT_MAX.
7555 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7556 harmful) conversions of unsigned short to int.
7557 (lisp_data_to_selection_data): Don't assume that integers
7558 in the range -65535 through -1 fit in an X unsigned short.
7559 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7560 result parameters unless successful. Rely on cons_to_unsigned
7561 to report problems with elements; the old code wasn't right anyway.
7562 (x_check_property_data): Check for int overflow; we cannot use
7563 a wider type due to X limits.
7564 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7566 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7568 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7569 (x_term_init): Check for size calculation overflow.
7570 (x_color_cells): Don't store size until memory allocation succeeds.
7571 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7572 Don't assume alloca size is less than MAX_ALLOCA.
7573 (x_term_init): Don't assume length fits in int (sprintf is limited
7576 Use ptrdiff_t for composition IDs.
7577 * character.c (lisp_string_width):
7578 * composite.c (composition_table_size, n_compositions)
7579 (get_composition_id, composition_gstring_from_id):
7580 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7581 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7582 * window.c (Frecenter):
7583 Use ptrdiff_t, not int, for composition IDs.
7584 * composite.c (get_composition_id): Check for integer overflow.
7585 * composite.h: Adjust prototypes to match the above changes.
7587 Use ptrdiff_t for hash table indexes.
7588 * category.c (hash_get_category_set):
7589 * ccl.c (ccl_driver):
7590 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7591 * coding.c (coding_system_charset_list, detect_coding_system):
7592 * coding.h (struct coding_system.id):
7593 * composite.c (get_composition_id, gstring_lookup_cache):
7594 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7595 * image.c (xpm_get_color_table_h):
7596 * lisp.h (hash_lookup, hash_put):
7597 * minibuf.c (Ftest_completion):
7598 Use ptrdiff_t for hash table indexes, not int (which is too
7599 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7600 32-bit --with-wide-int hosts).
7602 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7603 Add a FIXME comment about memory leaks.
7604 (syms_of_charset): Don't assume xmalloc returns.
7606 Don't assume that stated character widths fit in int.
7607 * character.c (Fchar_width, c_string_width, lisp_string_width):
7608 * character.h (CHAR_WIDTH):
7609 * indent.c (MULTIBYTE_BYTES_WIDTH):
7610 Use sanitize_char_width to avoid undefined and/or bad behavior
7611 with outlandish widths.
7612 * character.h (sanitize_tab_width): Rename from sanitize_width,
7613 now that we have two such functions. All uses changed.
7614 (sanitize_char_width): New inline function.
7616 Don't assume that tab-width fits in int.
7617 * character.h (sanitize_width): New inline function.
7618 (SANE_TAB_WIDTH): New macro.
7619 (ASCII_CHAR_WIDTH): Use it.
7620 * indent.c (sane_tab_width): Remove. All uses replaced by
7621 SANE_TAB_WIDTH (current_buffer).
7622 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7624 * fileio.c: Integer overflow issues with file modes.
7625 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7627 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7628 Remove unreachable code.
7629 (read_hex, load_charset_map_from_file): Check for integer overflow.
7631 * xterm.c: Don't go over XClientMessageEvent limit.
7632 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7633 (x_send_scroll_bar_event): Likewise. Check that the size does not
7634 exceed limits imposed by XClientMessageEvent, as well as the usual
7635 ptrdiff_t and size_t limits.
7637 * keyboard.c: Overflow, signedness and related fixes.
7638 (make_lispy_movement): Use same integer type in forward decl
7639 that is used in the definition.
7640 (read_key_sequence, keyremap_step):
7641 Change bufsize argument back to int, undoing my 2011-03-30 change.
7642 We prefer signed types, and int is wide enough here.
7643 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7644 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7645 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7646 length, not size_t. Use ptrdiff_t for index, not int.
7647 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7648 possibility of integer overflow.
7650 Overflow, signedness and related fixes for images.
7652 * dispextern.h (struct it.stack[0].u.image.image_id)
7653 (struct_it.image_id, struct image.id, struct image_cache.size)
7654 (struct image_cache.used, struct image_cache.ref_count):
7655 * gtkutil.c (update_frame_tool_bar):
7656 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7657 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7658 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7659 * nsmenu.m (update_frame_tool_bar):
7660 * xdisp.c (calc_pixel_width_or_height):
7661 * xfns.c (image_cache_refcount):
7662 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7663 on typical 64-bit hosts.
7665 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7666 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7667 Omit unnecessary casts to int.
7668 (parse_image_spec): Check that integers fall into 'int' range
7669 when the callers expect that.
7670 (image_ascent): Redo ascent calculation to avoid int overflow.
7671 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7672 (lookup_image): Remove unnecessary tests.
7673 (xbm_image_p): Locals are now of int, not EMACS_INT,
7674 since parse_image_check makes sure they fit into int.
7675 (png_load, gif_load, svg_load_image):
7676 Prefer int to unsigned where either will do.
7677 (tiff_handler): New function, combining the cores of the
7678 old tiff_error_handler and tiff_warning_handler.
7679 This function is rewritten to use vsnprintf and thereby avoid
7680 stack buffer overflows. It uses only the features of vsnprintf
7681 that are common to both POSIX and native Microsoft.
7682 (tiff_error_handler, tiff_warning_handler): Use it.
7683 (tiff_load, gif_load, imagemagick_load_image):
7684 Don't assume :index value fits in 'int'.
7685 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7686 (imagemagick_load_image): Check that crop parameters fit into
7687 the integer types that MagickCropImage accepts. Don't assume
7688 Vimagemagick_render_type has a nonnegative value. Don't assume
7689 size_t fits in 'long'.
7690 (gs_load): Use printmax_t to print the widest integers possible.
7691 Check for integer overflow when computing image height and width.
7693 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7695 * xdisp.c (redisplay_window): Don't force window start if point
7696 will be invisible in the resulting window. (Bug#9324)
7698 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7700 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7701 the display spec is of the form `(space ...)'.
7702 (handle_display_spec): Return the value returned by
7703 handle_single_display_spec, not just 1 or zero.
7704 (handle_single_display_spec): If the display spec is of the form
7705 `(space ...)', and specifies display in the text area, return 2
7707 (try_cursor_movement): Check for the need to scroll more
7708 accurately, and prefer exact match for point under bidi.
7709 Don't advance `row' beyond the last row of the window.
7711 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7712 into disp_prop; all users changed.
7714 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7715 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7716 for the text covered by the display property.
7718 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7720 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7721 Change return value to nil.
7722 (Frecord_buffer): Delete unused function.
7724 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7726 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7727 buffers, return left-to-right.
7728 (set_cursor_from_row): Consider candidate row a win if its glyph
7729 represents a newline and point is on that newline. Fixes cursor
7730 positioning on the newline at EOL of R2L text within L2R
7731 paragraph, and vice versa.
7732 (try_cursor_movement): Check continued rows, in addition to
7733 continuation rows. Fixes unwarranted scroll when point enters a
7734 continued line of R2L text within an L2R paragraph, or vice versa.
7735 (cursor_row_p): Consider the case of point being equal to
7736 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7737 from the end of a short line to the beginning of a continued line
7738 of R2L text within L2R paragraph.
7739 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7740 composed characters.
7742 * bidi.c (bidi_check_type): Use xassert.
7743 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7746 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7748 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7751 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7753 * nsfont.m (ns_otf_to_script): Fix typo.
7755 2011-08-22 Kenichi Handa <handa@m17n.org>
7757 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7758 extra slot even if the purpose is char-code-property-table.
7760 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7762 * xdisp.c (redisplay_window): When computing centering_position,
7763 account for the height of the header line. (Bug#8874)
7765 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7766 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7767 candidate is selected by the mouse, and that candidate has a
7768 composed character under the mouse.
7770 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7771 coordinates reported by pos-visible-in-window-p for a composed
7772 character in column zero.
7774 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7776 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7778 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7780 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7781 consider it a hit if to_charpos is anywhere in the range of the
7782 composed buffer positions.
7784 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7786 * image.c (gif_load): Don't assume that each subimage has the same
7787 dimensions as the base image. Handle disposal method that is
7788 "undefined" by the gif spec (Bug#9335).
7790 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7792 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7793 (Fcondition_case): Document `debug' symbol in error handler.
7795 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7797 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7798 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7799 from an Org mode buffer to a Speedbar frame.
7801 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7802 a composition, take its buffer position from IT->cmp_it.charpos.
7803 Fixes cursor positioning at the beginning of a line that begins
7804 with a composed character.
7806 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7808 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7809 character bidirectional type, use STRONG_L instead. Fixes crashes
7810 in a buffer produced by `describe-categories'.
7812 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7813 members before the level stack, so they would be saved and
7814 restored when copying iterator state. Fixes incorrect reordering
7815 around TABs covered by display properties.
7817 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7819 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7821 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7823 * eval.c (internal_condition_case, internal_condition_case_1)
7824 (internal_condition_case_2, internal_condition_case_n):
7825 Remove unnecessary aborts (Bug#9081).
7827 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7829 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7830 has no `load' handler, try opening the file locally. (Bug#9311)
7832 2011-08-16 Ken Brown <kbrown@cornell.edu>
7834 * gmalloc.c: Expand comment.
7836 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7838 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7839 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7841 2011-08-16 Ken Brown <kbrown@cornell.edu>
7843 Fix memory allocation problems in Cygwin build (Bug#9273).
7845 * unexcw.c ( __malloc_initialized): Declare external variable.
7846 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7848 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7850 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7852 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7854 [CYGWIN] (special_realloc): New function.
7855 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7856 requests to realloc storage in the static heap.
7858 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7860 * bidi.c (bidi_initialize): Remove unused local.
7862 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7865 * biditype.h: Remove file.
7866 * makefile.w32-in ($(BLD)/bidi.$(O)):
7867 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7869 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7871 * chartab.c: Improve commentary for the uniprop_table API.
7873 * bidi.c (bidi_paragraph_init): Support zero value of
7874 bidi_ignore_explicit_marks_for_paragraph_level.
7875 (bidi_initialize): Use uniprop_table instead of including
7876 biditype.h and bidimirror.h.
7878 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7879 coordinates of the iterator when restoring from ppos_it.
7882 2011-08-14 Kenichi Handa <handa@m17n.org>
7884 * process.c (create_process): Call setup_process_coding_systems
7885 after the pid of the process is set to -1 (Bug#8162).
7887 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7889 * xdisp.c (move_it_in_display_line_to): Don't invoke
7890 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7891 ppos_it. Fixes vertical cursor motion when line beginning is
7892 covered by an image. (Bug#9296)
7894 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7896 * nsterm.h (ns_run_ascript): Declare.
7897 (NSAPP_DATA2_RUNASSCRIPT): Define.
7899 * nsfns.m (as_script, as_result, as_status): New static variables.
7900 (ns_run_ascript): New function.
7901 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7902 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7903 the event loop. Get status from as_status (Bug#7276).
7905 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7906 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7907 the event loop (Bug#7276).
7909 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7911 * gnutls.c (QCgnutls_bootprop_priority)
7912 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7913 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7914 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7915 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7916 (QCgnutls_bootprop_verify_hostname_error)
7917 (QCgnutls_bootprop_callbacks_verify): Rename from
7918 Qgnutls_bootprop_..., all uses changed.
7920 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7923 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7925 * xfaces.c (Qframe_set_background_mode): Now static.
7926 * dispextern.h (Qframe_set_background_mode): Remove decl.
7928 * process.c (Fnetwork_interface_info): Declare local only if needed.
7930 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7932 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7933 (Fnetwork_interface_list): Allocate in increments of bytes instead
7934 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7935 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7937 (struct ifflag_def): notrailers is smart on OSX.
7938 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7939 Get hardware address with getifaddrs if available.
7941 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7943 * xdisp.c (iterate_out_of_display_property): xassert that
7944 IT->position is set to within IT->object's boundaries. Break from
7945 the loop as soon as EOB is reached; avoids infloops in redisplay
7946 when IT->position is set up wrongly due to some bug.
7947 Set IT->current to match the bidi iterator unconditionally.
7948 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7949 entry. Force push_it to save on the stack the current
7950 buffer/string position, to be restored by pop_it. Fix flags in
7951 the iterator structure wrt the object coming from a display
7952 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7953 properties. (Bug#9284)
7955 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7957 * fontset.c (fontset_get_font_group): Add proper type checks.
7960 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7962 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7963 and LC_VERSION_MIN_MACOSX.
7964 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7965 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7967 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7969 * xdisp.c (forward_to_next_line_start): Allow to use the
7970 no-display-properties-and-no-overlays under bidi display.
7971 Set disp_pos in the bidi iterator to avoid searches for display
7972 properties and overlays.
7974 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7976 * editfns.c (Fset_time_zone_rule): Document relationship with the
7979 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7980 the font entity extracted from the cache (Bug#8109).
7982 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7984 * composite.c (autocmp_chars): Don't reset point. That is done by
7985 restore_point_unwind (Bug#5984).
7987 2011-08-07 Juri Linkov <juri@jurta.org>
7989 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7990 to show the arg `TIME' instead of `TIMEVAL'.
7992 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7994 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7995 display property strides EOL and includes a newline, as in
7996 longlines-mode. (Bug#9254)
7997 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7998 word-wrap under bidirectional display. (Bug#9224)
8000 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8001 is non-zero, even if the data buffer is NULL. Fixes a crash in
8002 vertical-motion with longlines-mode. (Bug#9254)
8004 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8006 * bidi.c <bidi_cache_total_alloc>: Now static.
8007 (bidi_initialize): Initialize bidi_cache_total_alloc.
8009 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8012 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8013 amount allocated this far in `bidi_cache_total_alloc'.
8014 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8015 non-zero, only free the data buffer without restoring the cache
8016 contents. All callers changed.
8018 * dispextern.h (bidi_unshelve_cache): Update prototype.
8020 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8021 (move_it_in_display_line, move_it_to)
8022 (move_it_vertically_backward, move_it_by_lines): Replace the call
8023 to xfree to an equivalent call to bidi_unshelve_cache.
8024 (move_it_in_display_line_to): Fix logic of returning
8025 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8027 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8029 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8030 came from a string character with a `cursor' property. (Bug#9229)
8032 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8034 * Makefile.in (LIB_PTHREAD): New variable.
8035 (LIBES): Add LIB_PTHREAD (Bug#9216).
8037 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8038 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8040 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8042 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8044 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8046 * xterm.c (x_find_topmost_parent): New function.
8047 (x_set_frame_alpha): Find topmost parent window with
8048 x_find_topmost_parent and set the property there also (bug#9181).
8049 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8051 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8053 * callproc.c (Fcall_process): Avoid vfork clobbering
8054 the local vars buffer, coding_systems, current_dir.
8056 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8058 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8060 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8062 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8063 so that it is not optimized away.
8065 * xdisp.c (compute_display_string_pos): Remove unused local.
8067 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8069 Fix slow cursor motion and scrolling in large buffers with
8070 selective display, like Org Mode buffers. (Bug#9218)
8072 * dispextern.h (struct bidi_it): New member disp_prop_p.
8074 * xdisp.c: Remove one-slot cache of display string positions.
8075 (compute_display_string_pos): Accept an additional argument
8076 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8077 for a display string or property. If found, set DISP_PROP_P
8080 * bidi.c (bidi_fetch_char): Accept an additional argument
8081 DISP_PROP_P, and pass it to compute_display_string_pos.
8082 Only handle text covered by a display string if DISP_PROP_P is returned
8083 non-zero. All callers of bidi_fetch_char changed.
8085 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8087 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8089 2010-12-03 Don March <don@ohspite.net>
8091 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8092 last character M-[char] is translated to ESC [char] (bug#7541).
8094 2011-08-02 Kenichi Handa <handa@m17n.org>
8096 * lisp.h (uniprop_table): Extern it.
8098 * chartab.c (uniprop_table): Make it non-static.
8100 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8102 * xdisp.c (forward_to_next_line_start): Accept additional argument
8103 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8105 (reseat_at_next_visible_line_start): Use the bidi iterator state
8106 returned by forward_to_next_line_start to restore the state of
8107 it->bidi_it after backing up to previous newline. (Bug#9212)
8109 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8111 * regex.c (re_comp): Protoize.
8112 (re_exec): Fix return type.
8113 (regexec): Fix type of `ret'. (Bug#9203)
8115 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8117 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8118 This is needed if max-image-size is a floating-point number.
8120 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8122 * print.c (print_object): Print empty symbol as ##.
8124 * lread.c (read1): Read ## as empty symbol.
8126 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8128 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8129 setting frame foreground color (Bug#9175).
8130 (x_set_background_color): Likewise.
8132 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8133 contents (Bug#9176).
8134 (EmacsTooltip -init): Remove bezels and add shadows to
8137 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8138 or scroll bar (Bug#8470).
8140 * nsfont.m (nsfont_open): Remove assignment to voffset and
8141 unnecessary vars hshink, expand, hd, full_height, min_height.
8142 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8144 * nsterm.h (nsfont_info): Remove voffset field.
8146 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8148 Implement strike-through and overline on NextStep (Bug#8863).
8150 * nsfont.m (nsfont_open): Use underline position provided by font,
8151 instead of hard-coded value of 2.
8152 (nsfont_draw): Call ns_draw_text_decoration instead.
8154 * nsterm.h: Add declaration for ns_draw_text_decoration.
8156 * nsterm.m (ns_draw_text_decoration): New function for drawing
8157 underline, overline, and strike-through.
8158 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8159 ns_draw_text_decoration. Change treatment of cursor drawing to
8160 accommodate underlining, etc.
8162 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8164 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8167 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8169 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8170 Without this fix, if a signal arrives just after memory fills up,
8171 'malloc' might be invoked reentrantly.
8173 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8174 In other words, assume that every image size is allowed, on non-X
8175 hosts. This assumption is probably wrong, but it lets Emacs compile.
8177 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8179 * regex.c (re_iswctype): Convert return values to boolean.
8181 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8183 * xdisp.c (compute_display_string_pos): Don't use cached display
8184 string position if the buffer had its restriction changed.
8187 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8189 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8191 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8193 Integer signedness and overflow and related fixes. (Bug#9079)
8195 * bidi.c: Integer size and overflow fixes.
8196 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8197 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8198 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8199 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8200 (bidi_find_other_level_edge):
8201 Use ptrdiff_t instead of EMACS_INT where either will do.
8202 This works better on 32-bit hosts configured --with-wide-int.
8203 (bidi_cache_ensure_space): Check for size-calculation overflow.
8204 Use % rather than repeated addition, for better worst-case speed.
8205 Don't set bidi_cache_size until after xrealloc returns, because it
8207 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8208 (bidi_cache_ensure_space): Also check that the bidi cache size
8209 does not exceed that of the largest Lisp string or buffer. See Eli
8210 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8212 * alloc.c (__malloc_size_t): Remove.
8213 All uses replaced by size_t. See Andreas Schwab's note
8214 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8216 * image.c: Improve checking for integer overflow.
8217 (check_image_size): Assume that f is nonnull, since
8218 it is always nonnull in practice. This is one less thing to
8219 worry about when checking for integer overflow later.
8220 (x_check_image_size): New function, which checks for integer
8221 overflow issues inside X.
8222 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8223 This removes the need for a memory_full check.
8224 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8225 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8226 (xbm_read_bitmap_data): Change locals back to 'int', since
8227 their values must fit in 'int'.
8228 (xpm_load_image, png_load, tiff_load):
8229 Invoke x_create_x_image_and_pixmap earlier,
8230 to avoid much needless work if the image is too large.
8231 (tiff_load): Treat overly large images as if
8232 x_create_x_image_and_pixmap failed, not as malloc failures.
8233 (gs_load): Use x_check_image_size.
8235 * gtkutil.c: Omit integer casts.
8236 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8237 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8239 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8241 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8242 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8243 would wrongly return t on a 64-bit host.
8245 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8246 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8247 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8248 and therefore cause GCC to emit a bogus diagnostic in some cases.
8250 * image.c: Integer signedness and overflow and related fixes.
8251 This is not an exhaustive set of fixes, but it's time to
8252 record what I've got.
8253 (lookup_pixel_color, check_image_size): Remove redundant decls.
8254 (check_image_size): Don't assume that arbitrary EMACS_INT values
8255 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8256 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8257 (tiff_load, imagemagick_load_image):
8258 Check for overflow in size calculations.
8259 (x_create_x_image_and_pixmap): Remove unnecessary test for
8260 xmalloc returning NULL; that can't happen.
8261 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8262 (xpm_color_bucket): Use better integer hashing function.
8263 (xpm_cache_color): Don't possibly over-allocate memory.
8264 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8265 (gif_memory_source):
8266 Use ptrdiff_t, not int or size_t, to record sizes.
8267 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8268 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8269 either works, as we prefer signed integers.
8270 (tiff_read_from_memory, tiff_write_from_memory):
8271 Return tsize_t, not size_t, since that's what the TIFF API wants.
8272 (tiff_read_from_memory): Don't fail simply because the read would
8273 go past EOF; instead, return a short read.
8274 (tiff_load): Omit no-longer-needed casts.
8275 (Fimagemagick_types): Don't assume size fits into 'int'.
8277 Improve hashing quality when configured --with-wide-int.
8278 * fns.c (hash_string): New function, taken from sxhash_string.
8279 Do not discard information about ASCII character case; this
8280 discarding is no longer needed.
8281 (sxhash-string): Use it. Change sig to match it. Caller changed.
8282 * lisp.h: Declare it.
8283 * lread.c (hash_string): Remove, since we now use fns.c's version.
8284 The fns.c version returns a wider integer if --with-wide-int is
8285 specified, so this should help the quality of the hashing a bit.
8287 * emacs.c: Integer overflow minor fix.
8288 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8289 Define only if GNU_LINUX.
8290 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8292 * dispnew.c: Integer signedness and overflow fixes.
8293 Remove unnecessary forward decls, that were a maintenance hassle.
8294 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8296 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8297 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8298 (prepare_desired_row, line_draw_cost):
8299 Use int, not unsigned, where either works.
8300 (save_current_matrix, restore_current_matrix):
8301 Use ptrdiff_t, not size_t, where either works.
8302 (init_display): Check for overflow more accurately, and without
8303 relying on undefined behavior.
8305 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8306 Remove, replacing with the new symbols in lisp.h. All uses changed.
8307 * fileio.c (make_temp_name):
8308 * filelock.c (lock_file_1, lock_file):
8309 * xdisp.c (message_dolog):
8310 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8311 Use pMd etc. instead.
8312 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8313 replacing the pWIDE etc. symbols removed from editfns.c.
8315 * keyboard.h (num_input_events): Now uintmax_t.
8316 This is (very slightly) less likely to mess up due to wraparound.
8319 * buffer.c: Integer signedness fixes.
8320 (alloc_buffer_text, enlarge_buffer_text):
8321 Use ptrdiff_t rather than size_t when either will do, as we prefer
8324 * alloc.c: Integer signedness and overflow fixes.
8325 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8326 (__malloc_size_t): Default to size_t, not to int.
8327 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8328 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8329 Prefer ptrdiff_t to size_t when either would do, as we prefer
8331 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8332 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8333 Now const. Initialize with values that are in range even if char
8335 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8336 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8337 These functions do the right thing with sizes > 2**32.
8338 (check_depth): Now ptrdiff_t, not int.
8339 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8340 Adjust to new way of storing sizes. Check for size overflow bugs
8342 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8343 slightly wrong anyway, as it missed one instance of
8344 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8345 (refill_memory_reserve): Omit needless cast to size_t.
8346 (mark_object_loop_halt): Mark as externally visible.
8348 * xselect.c: Integer signedness and overflow fixes.
8349 (Fx_register_dnd_atom, x_handle_dnd_message):
8350 Use ptrdiff_t, not size_t, since we prefer signed.
8351 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8352 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8353 x_dnd_atoms_size and x_dnd_atoms_length.
8355 * doprnt.c: Prefer signed to unsigned when either works.
8357 * doprnt.c (doprnt):
8359 * xdisp.c (vmessage):
8360 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8361 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8362 prefer signed arithmetic to avoid comparison confusion.
8363 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8364 but is a bit tricky.
8366 Assume freestanding C89 headers, string.h, stdlib.h.
8367 * data.c, doprnt.c, floatfns.c, print.c:
8368 Include float.h unconditionally.
8369 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8370 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8371 * regex.c: Likewise for stddef.h, string.h.
8372 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8373 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8374 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8375 (STDC_HEADERS): Remove obsolete defines.
8376 * sysdep.c: Include limits.h unconditionally.
8378 Assume support for memcmp, memcpy, memmove, memset.
8379 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8380 * regex.c (memcmp, memcpy):
8381 Remove; we assume C89 now.
8383 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8384 (__malloc_safe_bcopy): Remove; no longer needed.
8386 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8387 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8388 well either way, and we prefer signed to unsigned.
8390 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8392 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8393 closes the connection while we're reading (bug#9182).
8395 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8397 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8398 are specified (Bug#9168).
8400 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8402 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8403 Found by GCC static checking and --with-wide-int on a 32-bit host.
8405 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8407 * xdisp.c (compute_display_string_pos): Fix logic of caching
8408 previous display string position. Initialize cached_prev_pos to
8409 -1. Fixes slow-down at the beginning of a buffer.
8411 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8413 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8414 for attrs[LFACE_FONTSET_INDEX].
8416 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8418 * xml.c (parse_region): Remove unused local
8419 that was recently introduced.
8421 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8423 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8424 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8426 * xdisp.c (move_it_in_display_line_to): Record the best matching
8427 position for TO_CHARPOS while scanning the line, and restore it on
8428 exit if none of the characters scanned was an exact match.
8429 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8430 when exact match is impossible due to invisible text, and the
8431 lines are truncated.
8433 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8435 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8438 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8440 Fix a significant slow-down of cursor motion with C-n, C-p,
8441 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8442 auto-repeat under bidi redisplay in fontified buffers.
8443 * xdisp.c (compute_stop_pos_backwards): New function.
8444 (next_element_from_buffer): Call compute_stop_pos_backwards to
8445 find a suitable prev_stop when we find ourselves before
8447 (reseat): Don't look for prev_stop, as that could mean a very long
8449 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8450 <cached_disp_overlay_modiff>: Cache for last found display string
8452 (compute_display_string_pos): Return the cached position if asked
8453 about the same buffer in the same area of character positions, and
8454 the buffer wasn't changed since the time the display string
8455 position was cached.
8457 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8459 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8460 is an integer, which is important for empty lines. (Bug#9149)
8462 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8464 * frame.c (Fmodify_frame_parameters): In tty case, update the
8465 default face if necessary (Bug#4238).
8467 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8469 * editfns.c (Fstring_to_char): No need to explain what a character
8470 is in the docstring (Bug#6576).
8472 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8474 * xml.c (parse_region): Make sure we always return a tree.
8476 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8478 * xml.c (parse_region): If a document contains only comments,
8481 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8483 * xml.c (make_dom): Return comments, too.
8485 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8488 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8489 and the surrounding thread.
8490 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8491 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8492 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8494 * s/openbsd.h (BROKEN_SIGIO): Define.
8495 * unexelf.c (unexec) [__OpenBSD__]:
8496 Don't update the .mdebug section of the Alpha COFF symbol table.
8498 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8500 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8503 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8505 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8506 This fixes some race conditions on the permissions of any newly
8509 * alloc.c (valid_pointer_p): Use pipe, not open.
8510 This fixes some permissions issues when debugging.
8512 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8513 If fchown fails to set both uid and gid, try to set just gid,
8514 as that is sometimes allowed. Adjust the file's mode to eliminate
8515 setuid or setgid bits that are inappropriate if fchown fails.
8517 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8519 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8520 to compare Lisp_Objects.
8521 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8522 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8523 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8525 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8527 * lread.c (read_integer): Unread even EOF character.
8528 (read1): Likewise. Properly record start position of symbol.
8530 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8531 symbol character follows.
8533 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8535 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8536 This works around a problem with the previous change to Fcopy_file.
8537 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8538 and without this change, GCC might complain about discarding
8539 fchown's return value.
8541 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8543 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8545 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8547 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8549 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8551 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8552 it's used from the C level.
8554 * process.c: Use the same condition for POLL_FOR_INPUT in both
8555 keyboard.c and process.c (bug#1858).
8557 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8559 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8560 (Fgnutls_boot): Use it.
8562 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8564 * doc.c (Fsubstitute_command_keys): Revert last change.
8566 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8568 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8569 quotes the next character, and doesn't affect other longer
8570 sequences (bug#8935).
8572 * lread.c (syms_of_lread): Clarify that is isn't only
8573 `eval-buffer' and `eval-defun' that's affected by
8574 `lexical-binding' (bug#8460).
8576 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8578 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8579 bidi redisplay when a line includes both an image and is truncated.
8581 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8583 Fix minor problems found by static checking.
8584 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8585 (elsz): Now a signed constant, not a size_t var. We prefer signed
8586 types to unsigned, to avoid integer comparison confusion. Without
8587 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8588 "cannot optimize loop, the loop counter may overflow", a symptom
8590 * indent.c (Fvertical_motion): Mark locals as initialized.
8591 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8593 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8595 * search.c (Fre_search_backward): Mention `case-fold-search' in
8596 all the re_search_* functions (bug#8138).
8598 * keyboard.c (Fopen_dribble_file): Document when the file is
8601 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8603 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8606 Support bidi reordering of display and overlay strings.
8607 * xdisp.c (compute_display_string_pos)
8608 (compute_display_string_end): Accept additional argument STRING.
8609 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8610 (reseat_to_string): Initialize bidi_it->string.s and
8611 bidi_it->string.schars.
8612 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8613 NULL (avoids a crash in bidi_paragraph_init).
8614 Initialize itb.string.lstring.
8615 (init_iterator): Call bidi_init_it only of a valid
8616 buffer position was specified. Initialize paragraph_embedding to
8618 (reseat_to_string): Initialize the bidi iterator.
8619 (display_string): If we need to ignore text properties of
8620 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8621 original value of -1 will not work with bidi.)
8622 (compute_display_string_pos): First arg is now struct
8623 `text_pos *'; all callers changed. Support display properties on
8625 (compute_display_string_end): Support display properties on Lisp
8627 (init_iterator, reseat_1, reseat_to_string): Initialize the
8628 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8629 when iterating on a string not from display properties).
8630 (compute_display_string_pos, compute_display_string_end):
8631 Fix calculation of the object to scan. Fixes an error when using
8633 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8634 base_level_stop; instead, set base_level_stop to BEGV.
8635 Fixes crashes in vertical-motion.
8636 (next_element_from_buffer): Improve commentary for when
8637 the iterator is before prev_stop.
8638 (init_iterator): Initialize bidi_p from the default value of
8639 bidi-display-reordering, not from buffer-local value. Use the
8640 buffer-local value only if initializing for buffer iteration.
8641 (handle_invisible_prop): Support invisible properties on strings
8642 that are being bidi-reordered.
8643 (set_iterator_to_next): Support bidi reordering of C strings and
8645 (next_element_from_string): Support bidi reordering of Lisp
8647 (handle_stop_backwards): Support Lisp strings as well.
8648 (display_string): Support display of R2L glyph rows.
8649 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8650 (init_iterator): Don't initialize it->bidi_p for strings
8652 (reseat_to_string): Initialize it->bidi_p for strings here.
8653 (next_element_from_string, next_element_from_c_string)
8654 (next_element_from_buffer): Add xassert's for correspondence
8655 between IT's object being iterated and it->bidi_it.string
8657 (face_before_or_after_it_pos): Support bidi iteration.
8658 (next_element_from_c_string): Handle the case of the first string
8659 character that is not the first one in the visual order.
8660 (get_visually_first_element): New function, refactored from common
8661 parts of next_element_from_buffer, next_element_from_string, and
8662 next_element_from_c_string.
8663 (tool_bar_lines_needed, redisplay_tool_bar)
8664 (display_menu_bar): Force left-to-right direction. Add a FIXME
8665 comment for making that be controlled by a user option.
8666 (push_it, pop_it): Save and restore the state of the
8667 bidi iterator. Save and restore the bidi_p flag.
8668 (pop_it): Iterate out of display property for string iteration as
8670 (iterate_out_of_display_property): Support iteration over strings.
8671 (handle_single_display_spec): Set up it->bidi_it for iteration
8672 over a display string, and call bidi_init_it.
8673 (handle_single_display_spec, next_overlay_string)
8674 (get_overlay_strings_1, push_display_prop): Set up the bidi
8675 iterator for displaying display or overlay strings.
8676 (forward_to_next_line_start): Don't use the shortcut if
8678 (back_to_previous_visible_line_start): If handle_display_prop
8679 pushed the iterator stack, restore the internal state of the bidi
8680 iterator by calling bidi_pop_it same number of times.
8681 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8682 and we are bidi-iterating, don't decrement the iterator position;
8683 instead, set the first_elt flag in the bidi iterator, to produce
8685 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8686 (push_display_prop): xassert that we are iterating a buffer.
8687 (push_it, pop_it): Save and restore paragraph_embedding member.
8688 (handle_single_display_spec, next_overlay_string)
8689 (get_overlay_strings_1, reseat_1, reseat_to_string)
8690 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8691 correctly. Don't assume unibyte strings are not bidi-reordered.
8692 (compute_display_string_pos)
8693 (compute_display_string_end): Fix handling the case of C string.
8694 (push_it, pop_it): Save and restore from_disp_prop_p.
8695 (handle_single_display_spec, push_display_prop): Set the
8696 from_disp_prop_p flag.
8697 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8698 (pop_it): Call iterate_out_of_display_property only if we are
8699 popping after iteration over a string that came from a display
8700 property. Fix a typo in popping stretch info. Add an assertion
8701 for verifying that the iterator position is in sync with the bidi
8703 (handle_single_display_spec, get_overlay_strings_1)
8704 (push_display_prop): Fix initialization of paragraph direction for
8705 string when that of the parent object is not yet determined.
8706 (reseat_1): Call bidi_init_it to resync the bidi
8707 iterator with IT's position. (Bug#7616)
8708 (find_row_edges): If ROW->start.pos gives position
8709 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8710 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8711 Reset the from_disp_prop_p flag.
8712 (SAVE_IT, RESTORE_IT): New macros.
8713 (pos_visible_p, face_before_or_after_it_pos)
8714 (back_to_previous_visible_line_start)
8715 (move_it_in_display_line_to, move_it_in_display_line)
8716 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8717 (try_scrolling, redisplay_window, display_line): Use them when
8718 saving a temporary copy of the iterator and restoring it back.
8719 (back_to_previous_visible_line_start, reseat_1)
8720 (init_iterator): Empty the bidi cache "stack".
8721 (move_it_in_display_line_to): If iterator ended up at
8722 EOL, but we never saw any buffer positions smaller than
8723 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8724 motion in bidi-reordered lines.
8725 (move_it_in_display_line_to): Record prev_method and prev_pos
8726 immediately before the call to set_iterator_to_next. Fixes cursor
8727 motion in bidi-reordered lines with stretch glyphs and strings
8728 displayed in margins. (Bug#8133) (Bug#8867)
8729 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8731 (pos_visible_p): Support positions in bidi-reordered lines.
8732 Save and restore bidi cache.
8734 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8735 (bidi_paragraph_info): Delete unused struct.
8736 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8737 (bidi_cache_start): New variable.
8738 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8740 (bidi_cache_fetch_state, bidi_cache_search)
8741 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8742 (bidi_cache_find, bidi_peek_at_next_level)
8743 (bidi_level_of_next_char, bidi_find_other_level_edge)
8744 (bidi_move_to_visually_next): Compare cache index with
8745 bidi_cache_start rather than with zero.
8746 (bidi_fetch_char): Accept new argument STRING; all callers
8747 changed. Support iteration over a string. Support strings with
8748 display properties. Support unibyte strings. Fix the type of
8749 `len' according to what STRING_CHAR_AND_LENGTH expects.
8750 (bidi_paragraph_init, bidi_resolve_explicit_1)
8751 (bidi_resolve_explicit, bidi_resolve_weak)
8752 (bidi_level_of_next_char, bidi_move_to_visually_next):
8753 Support iteration over a string.
8754 (bidi_set_sor_type, bidi_resolve_explicit_1)
8755 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8756 can now be zero (for strings); special values 0 and -1 were
8757 changed to -1 and -2, respectively.
8758 (bidi_char_at_pos): New function.
8759 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8760 Call it instead of FETCH_MULTIBYTE_CHAR.
8761 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8762 initialized to valid values.
8763 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8765 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8766 the test for valid cached positions. Fix the logic for looking up
8767 the sentinel state in the cache. GCPRO the Lisp string we are
8769 (bidi_push_it, bidi_pop_it): New functions.
8770 (bidi_initialize): Initialize the bidi cache start stack pointer.
8771 (bidi_cache_ensure_space): New function, refactored from part of
8772 bidi_cache_iterator_state. Don't assume the required size is just
8773 one BIDI_CACHE_CHUNK away.
8774 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8775 (bidi_count_bytes, bidi_char_at_pos): New functions.
8776 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8777 always valid if bidi_cache_idx is valid.
8778 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8779 is valid if it's going to be used.
8780 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8781 (bidi_cache_fetch_state, bidi_cache_search)
8782 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8783 (bidi_cache_iterator_state, bidi_cache_find)
8784 (bidi_find_other_level_edge, bidi_cache_start_stack):
8785 All variables related to cache indices are now EMACS_INT.
8787 * dispextern.h (struct bidi_string_data): New structure.
8788 (struct bidi_it): New member `string'. Make flag members be 1-bit
8789 fields, and put them last in the struct.
8790 (compute_display_string_pos, compute_display_string_end):
8792 (bidi_push_it, bidi_pop_it): Add prototypes.
8793 (struct iterator_stack_entry): New members bidi_p,
8794 paragraph_embedding, and from_disp_prop_p.
8795 (struct it): Member bidi_p is now a bit field 1 bit wide.
8796 (bidi_shelve_cache, bidi_unshelve_cache):
8799 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8800 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8801 and vector-like objects.
8803 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8804 cache around display iteration.
8806 * window.c (Fwindow_end, window_scroll_pixel_based)
8807 (displayed_window_lines, Frecenter): Save and restore the bidi
8808 cache around display iteration.
8810 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8812 * editfns.c (Fdelete_region): Clarify the use of the named
8813 parameters (bug#6788).
8815 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8817 * indent.c (Fvertical_motion): Set and restore w->pointm when
8818 saving and restoring the window's buffer (Bug#9006).
8820 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8822 * editfns.c (Fstring_to_char): Clarify just what is returned
8823 (bug#6576). Text by Eli Zaretskii.
8825 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8827 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8829 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8831 * buffer.c (mmap_find): Fix a typo.
8833 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8835 Fix execution of x selection hooks.
8836 * xselect.c (Qx_lost_selection_functions)
8837 (Qx_sent_selection_functions): New vars.
8838 (syms_of_xselect): DEFSYM them.
8839 (x_handle_selection_request): Pass Qx_sent_selection_functions
8840 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8841 (x_handle_selection_clear,x_clear_frame_selections):
8842 Pass Qx_lost_selection_functions rather than
8843 Vx_lost_selection_functions to Frun_hook_with_args.
8845 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8847 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8848 The old code sometimes used this field without initializing it.
8850 * alloc.c (gc_sweep): Don't read past end of array.
8851 In theory, the old code could also have corrupted Emacs internals,
8852 though it'd be very unlikely.
8854 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8856 * character.c (Fcharacterp): Don't advertise optional ignored
8857 argument. (Bug#4026)
8859 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8861 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8864 * window.c (Fset_window_start): Doc fix (bug#4199).
8865 (Fset_window_hscroll): Ditto.
8867 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8869 Fix minor new problems caught by GCC 4.6.1.
8870 * term.c (init_tty): Remove unused local.
8871 * xsettings.c (store_monospaced_changed): Define this function only
8872 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8875 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8877 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8879 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8881 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8882 are the mini-buffer and the echo area (bug#3320).
8884 * term.c (init_tty): Remove support for supdup, c10 and perq
8885 terminals, which are no longer supported (bug#1482).
8887 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8889 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8891 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8893 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8894 for non-popups (Bug#3642).
8896 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8898 * alloc.c (reset_malloc_hooks): Protoize.
8899 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8900 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8901 * cm.c (losecursor): Likewise.
8902 * data.c (fmod): Likewise.
8903 * dispnew.c (swap_glyphs_in_rows): Likewise.
8904 * emacs.c (memory_warning_signal): Likewise.
8905 * floatfns.c (float_error): Likewise.
8906 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8907 (otf_open, font_otf_capability, generate_otf_features)
8908 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8910 * image.c (pbm_read_file): Likewise.
8911 * indent.c (string_display_width): Likewise.
8912 * intervals.c (check_for_interval, search_for_interval)
8913 (inc_interval_count, count_intervals, root_interval)
8914 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8915 * lread.c (defalias): Likewise.
8916 * ralloc.c (r_alloc_check): Likewise.
8917 * regex.c (set_image_of_range_1, set_image_of_range)
8918 (regex_grow_registers): Likewise.
8919 * sysdep.c (strerror): Likewise.
8920 * termcap.c (valid_filename_p, tprint, main): Likewise.
8921 * tparam.c (main): Likewise.
8922 * unexhp9k800.c (run_time_remap, save_data_space)
8923 (update_file_ptrs, read_header, write_header, calculate_checksum)
8924 (copy_file, copy_rest, display_header): Likewise.
8925 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8927 * xdisp.c (check_it): Likewise.
8928 * xfaces.c (register_color, unregister_color, unregister_colors):
8930 * xfns.c (print_fontset_result): Likewise.
8931 * xrdb.c (member, fatal, main): Likewise.
8933 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8935 Fix minor problems found by static checking (Bug#9031).
8936 * chartab.c (char_table_set_range, map_sub_char_table):
8937 Remove unused locals.
8938 (uniprop_table): Now static.
8939 * composite.c (_work_char): Remove unused static var.
8941 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8943 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8945 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8947 * gtkutil.c (qttip_cb): Remove code without function.
8949 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8951 * w32.c (pthread_sigmask): New stub.
8953 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8955 Use pthread_sigmask, not sigprocmask (Bug#9010).
8956 sigprocmask is portable only for single-threaded applications, and
8957 Emacs can be multi-threaded when it uses GTK.
8958 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8960 * callproc.c (Fcall_process):
8961 * process.c (create_process):
8962 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8963 Use pthread_sigmask, not sigprocmask.
8965 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8967 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8968 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8971 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8973 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8974 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8975 (xg_hide_tooltip): Fix comment.
8977 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8978 in registerServicesMenuSendTypes.
8979 (validRequestorForSendType): Don't check ns_return_types.
8981 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8984 2011-07-08 Jason Rumney <jasonr@gnu.org>
8986 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8987 SH_SHOW for hidden windows (Bug#5482).
8989 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8990 frame struct members of non-existent frames (Bug#6284).
8992 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8994 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8995 variable firstTime not needed on OSX >= 10.6.
8996 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8997 >= 10.5. Use setKnobProportion, setDoubleValue.
8999 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9000 (MAC_OS_X_VERSION_10_5): Define if not defined.
9001 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9002 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9003 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9005 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9006 cString and lossyCString on OSX >= 10.4.
9008 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9009 sizeToFit on OSX >= 10.2.
9011 * nsimage.m (allocInitFromFile): Don't use deprecated method
9012 bestRepresentationForDevice on OSX >= 10.6.
9014 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9017 * emacs.c: Declare unexec_init_emacs_zone.
9019 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9021 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9023 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9024 on svcsMenu (Bug#8842).
9026 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9028 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9030 * nsterm.m (QUTF8_STRING): Declare.
9031 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9032 (validRequestorForSendType): Return type is (id).
9033 Change indexOfObjectIdenticalTo to indexOfObject.
9034 Check if we have local selection before returning self (Bug#8842).
9035 (writeSelectionToPasteboard): Put local selection into paste board
9036 if we have a local selection (Bug#8842).
9037 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9039 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9040 (ns_get_local_selection): Declare.
9042 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9044 * keymap.c (describe_map_tree): Don't insert a double newline at
9045 the end of the buffer (bug#1169) and return whether we inserted
9048 * callint.c (Fcall_interactively): Change "reading args" to
9049 "providing args" to try to clarify what it does (bug#1010).
9051 2011-07-07 Kenichi Handa <handa@m17n.org>
9053 * composite.c (composition_compute_stop_pos): Ignore a static
9054 composition starting before CHARPOS (Bug#8915).
9056 * xdisp.c (handle_composition_prop): Likewise.
9058 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9060 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9063 2011-07-07 Kenichi Handa <handa@m17n.org>
9065 * character.h (unicode_category_t): New enum type.
9067 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9068 (Qchar_code_property_table): New variable.
9069 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9070 (UNIPROP_COMPRESSED_FORM_P): New macros.
9071 (char_table_ascii): Uncompress the compressed values.
9072 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9073 Uncompress the compressed values.
9074 (sub_char_table_ref_and_range): Likewise.
9075 (char_table_ref_and_range): Uncompress the compressed values.
9076 (sub_char_table_set): New arg is_uniprop. Callers changed.
9077 Uncompress the compressed values.
9078 (sub_char_table_set_range): Args changed. Callers changed.
9079 (char_table_set_range): Adjuted for the above change.
9080 (map_sub_char_table): Delete args default_val and parent. Add arg
9081 top. Give decoded values to a Lisp function.
9082 (map_char_table): Adjust for the above change. Give decoded
9083 values to a Lisp function. Gcpro more variables.
9084 (uniprop_table_uncompress)
9085 (uniprop_decode_value_run_length): New functions.
9086 (uniprop_decoder, uniprop_decoder_count): New variables.
9087 (uniprop_get_decoder, uniprop_encode_value_character)
9088 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9090 (uniprop_encoder, uniprop_encoder_count): New variables.
9091 (uniprop_get_encoder, uniprop_table)
9092 (Funicode_property_table_internal, Fget_unicode_property_internal)
9093 (Fput_unicode_property_internal): New functions.
9094 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9095 Sunicode_property_table_internal, Sget_unicode_property_internal,
9096 and Sput_unicode_property_internal. Defvar_lisp
9097 char-code-property-alist.
9099 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9100 Vunicode_category_table.
9102 * font.c (font_range): Adjust for the change of
9103 Vunicode_category_table.
9105 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9107 * m/iris4d.h: Remove file, move contents ...
9108 * s/irix6-5.h: ... here.
9110 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9112 Remove unportable assumption about struct layout (Bug#8884).
9113 * alloc.c (mark_buffer):
9114 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9115 (clone_per_buffer_values): Don't assume that
9116 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9117 This isn't true in general, and it's particularly not true
9118 if Emacs is configured with --with-wide-int.
9119 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9120 New macros, used in the buffer.c change.
9122 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9124 * xsettings.c: Use both GConf and GSettings if both are available.
9125 (store_config_changed_event): Add comment.
9126 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9127 (store_tool_bar_style_changed): New functions.
9128 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9129 (struct xsettings): Move font inside HAVE_XFT.
9130 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9131 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9132 Move inside HAVE_XFT.
9133 (something_changed_gsettingsCB): Rename from something_changedCB.
9134 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9136 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9137 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9138 (something_changed_gconfCB): Rename from something_changedCB.
9139 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9140 (parse_settings): Move check for font inside HAVE_XFT.
9141 (read_settings, apply_xft_settings): Add comment.
9142 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9143 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9144 call store_font_name_changed.
9145 (xft_settings_event): Add comment.
9146 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9147 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9148 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9149 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9150 (xsettings_initialize): Call init_gsettings last.
9151 (xsettings_get_system_font, xsettings_get_system_normal_font):
9154 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9156 Random fixes. E.g., (random) never returned negative values.
9157 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9158 subseconds part to the entropy, as that's a bit more random.
9159 Prefer signed to unsigned, since the signedness doesn't matter and
9160 in general we prefer signed. When given a limit, use a
9161 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9162 latter isn't right if USE_2_TAGS_FOR_INTS.
9163 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9164 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9166 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9168 * textprop.c (text_property_stickiness):
9169 Obey Vtext_property_default_nonsticky.
9170 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9171 * w32fns.c (syms_of_w32fns):
9172 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9174 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9176 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9177 This is more efficient than Ffile_directory_p and avoids a minor race.
9179 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9181 * buffer.c (Foverlay_put): Say what the return value is
9184 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9185 is a directory before asking whether to use the file name
9187 (barf_or_query_if_file_exists): Make the "File is a directory"
9188 error be more correct.
9190 * fns.c (Frequire): Remove the mention of the .gz files, since
9191 that's installation-specific, but keep the mention of
9192 `get-load-suffixes'.
9194 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9196 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9197 Report string overflow if the output is too long.
9199 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9201 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9202 (syms_of_gnutls): Remove duplicate DEFSYM for
9203 Qgnutls_bootprop_verify_hostname_error, an error for
9204 Qgnutls_bootprop_verify_error (which is no longer used).
9206 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9207 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9208 Also (re)move comments that are misplaced or no longer relevant.
9210 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9212 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9214 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9216 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9217 and background color parameters if they have been changed.
9219 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9221 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9223 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9225 * xsettings.c (SYSTEM_FONT): Define only when used.
9226 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9228 * keymap.c (access_keymap_1): Now static.
9230 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9232 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9233 leave any prefix arg for the up event (Bug#1586).
9235 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9237 * lread.c (syms_of_lread): Mention single symbols defined by
9238 `defvar' or `defconst' (bug#7154).
9240 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9241 (Frequire): Mention get-load-suffixes.
9243 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9245 * window.h (window): Remove clone_number slot.
9246 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9248 (make_parent_window, make_window, saved_window)
9249 (Fset_window_configuration, save_window_save): Don't deal with
9251 * buffer.c (Qclone_number): Remove declaration.
9252 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9254 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9256 Add multiple inheritance to keymaps.
9257 * keymap.c (Fmake_composed_keymap): New function.
9258 (Fset_keymap_parent): Simplify.
9259 (fix_submap_inheritance): Remove.
9260 (access_keymap_1): New function extracted from access_keymap to handle
9261 embedded parents and handle lists of maps.
9262 (access_keymap): Use it.
9263 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9264 (Fcopy_keymap): Handle embedded parents.
9265 (Fcommand_remapping, define_as_prefix): Simplify.
9266 (Fkey_binding): Simplify.
9267 (syms_of_keymap): Move minibuffer-local-completion-map,
9268 minibuffer-local-filename-completion-map,
9269 minibuffer-local-must-match-map, and
9270 minibuffer-local-filename-must-match-map to Elisp.
9271 (syms_of_keymap): Defsubr make-composed-keymap.
9272 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9273 (parse_menu_item): Trivial simplification.
9275 2011-07-01 Glenn Morris <rgm@gnu.org>
9277 * Makefile.in (SETTINGS_LIBS): Fix typo.
9279 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9281 * coding.c (Fencode_coding_string): Record the last coding system
9282 used, as the function doc string says (bug#8738).
9284 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9286 * xsettings.c (store_monospaced_changed): Take new font as arg and
9287 check for change against current_mono_font.
9288 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9289 (emacs_settings_constructor, emacs_settings_get_property)
9290 (emacs_settings_set_property, emacs_settings_class_init)
9291 (emacs_settings_init, gsettings_obj): Remove.
9292 (something_changedCB): New function for HAVE_GSETTINGS.
9293 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9294 with value as argument.
9295 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9296 g_settings_new (Bug#8967). Do not create gsettings_obj.
9297 Remove calls to g_settings_bind. Connect something_changedCB to
9300 * xgselect.c: Add defined (HAVE_GSETTINGS).
9301 (xgselect_initialize): Ditto.
9303 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9304 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9307 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9309 * eval.c (struct backtrace): Simplify and port the data structure.
9310 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9311 signed bit field, as this assumption is not portable and it makes
9312 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9313 "char debug_on_exit : 1" as this is not portable either; instead,
9314 use the portable "unsigned int debug_on_exit : 1". Remove unused
9315 member evalargs. Remove obsolete comments about cc bombing out.
9317 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9319 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9320 Let HAVE_GSETTINGS override HAVE_GCONF.
9321 (store_monospaced_changed): New function.
9322 (EMACS_SETTINGS): A new type derived from GObject to handle
9323 GSettings notifications.
9324 (emacs_settings_constructor, emacs_settings_get_property)
9325 (emacs_settings_set_property, emacs_settings_class_init):
9327 (gsettings_client, gsettings_obj): New variables.
9328 (GSETTINGS_SCHEMA): New define.
9329 (something_changedCB): Call store_monospaced_changed.
9330 (init_gsettings): New function.
9331 (xsettings_initialize): Call init_gsettings.
9332 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9335 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9338 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9340 * window.c (resize_root_window, grow_mini_window)
9341 (shrink_mini_window): Rename Qresize_root_window to
9342 Qwindow_resize_root_window and Qresize_root_window_vertically to
9343 Qwindow_resize_root_window_vertically.
9345 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9347 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9349 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9351 * makefile.w32-in: Redesign dependencies so they reflect more
9352 clearly which files are directly included by each source file,
9353 and not through other includes.
9355 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9357 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9358 (sort_overlays, overlay_strings): When an overlay's clone number
9359 matches the window's clone number process the overlay even if
9360 the overlay's window property doesn't match the current window.
9362 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9363 (Fwindow_hchild): Rename to Fwindow_left_child.
9364 (Fwindow_next): Rename to Fwindow_next_sibling.
9365 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9366 (resize_window_check): Rename to window_resize_check.
9367 (resize_window_apply): Rename to window_resize_apply.
9368 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9369 (Fdelete_other_windows_internal, resize_frame_windows)
9370 (Fsplit_window_internal, Fdelete_window_internal)
9371 (grow_mini_window, shrink_mini_window)
9372 (Fresize_mini_window_internal): Fix callers accordingly.
9374 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9376 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9377 (emacs_fixed_set_min_size): Remove.
9378 (emacs_fixed_new): Take frame as argument.
9380 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9381 (_EmacsFixedPrivate): Remove minwidth/height.
9382 Add struct frame *f.
9383 (emacs_fixed_init): Initialize priv->f.
9384 (get_parent_class, emacs_fixed_set_min_size): Remove.
9385 (emacs_fixed_new): Set priv->f to argument.
9386 (emacs_fixed_get_preferred_width)
9387 (emacs_fixed_get_preferred_height): Use min_width/height from
9388 frames size_hint to set minimum and natural (Bug#8919).
9389 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9390 and use min_width/height from frames size_hint to set
9391 min_width/height (Bug#8919).
9393 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9394 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9397 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9399 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9400 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9403 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9405 * process.c (wait_reading_process_output): Bypass select if
9406 waiting for a cell while ignoring keyboard input, and input is
9407 pending. Suggested by Jan Djärv (Bug#8869).
9409 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9411 Use gnulib's dup2 module instead of rolling our own.
9412 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9414 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9416 * dispnew.c (scrolling_window): Before scrolling, turn off a
9417 mouse-highlight in the window being scrolled.
9419 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9421 Move DEFSYM to lisp.h and use everywhere.
9423 * character.h (DEFSYM): Move declaration...
9424 * lisp.h (DEFSYM): ...here.
9430 * w32select.c: Don't include character.h.
9432 * alloc.c (syms_of_alloc):
9433 * buffer.c (syms_of_buffer):
9434 * bytecode.c (syms_of_bytecode):
9435 * callint.c (syms_of_callint):
9436 * casefiddle.c (syms_of_casefiddle):
9437 * casetab.c (init_casetab_once):
9438 * category.c (init_category_once, syms_of_category):
9439 * ccl.c (syms_of_ccl):
9440 * cmds.c (syms_of_cmds):
9441 * composite.c (syms_of_composite):
9442 * dbusbind.c (syms_of_dbusbind):
9443 * dired.c (syms_of_dired):
9444 * dispnew.c (syms_of_display):
9445 * doc.c (syms_of_doc):
9446 * editfns.c (syms_of_editfns):
9447 * emacs.c (syms_of_emacs):
9448 * eval.c (syms_of_eval):
9449 * fileio.c (syms_of_fileio):
9450 * fns.c (syms_of_fns):
9451 * frame.c (syms_of_frame):
9452 * fringe.c (syms_of_fringe):
9453 * insdel.c (syms_of_insdel):
9454 * keymap.c (syms_of_keymap):
9455 * lread.c (init_obarray, syms_of_lread):
9456 * macros.c (syms_of_macros):
9457 * msdos.c (syms_of_msdos):
9458 * print.c (syms_of_print):
9459 * process.c (syms_of_process):
9460 * search.c (syms_of_search):
9461 * sound.c (syms_of_sound):
9462 * syntax.c (init_syntax_once, syms_of_syntax):
9463 * terminal.c (syms_of_terminal):
9464 * textprop.c (syms_of_textprop):
9465 * undo.c (syms_of_undo):
9466 * w32.c (globals_of_w32):
9467 * window.c (syms_of_window):
9468 * xdisp.c (syms_of_xdisp):
9469 * xfaces.c (syms_of_xfaces):
9470 * xfns.c (syms_of_xfns):
9471 * xmenu.c (syms_of_xmenu):
9472 * xsettings.c (syms_of_xsettings):
9473 * xterm.c (syms_of_xterm): Use DEFSYM.
9475 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9477 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9479 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9481 Integer and buffer overflow fixes (Bug#8873).
9483 * print.c (printchar, strout): Check for string overflow.
9484 (PRINTPREPARE, printchar, strout):
9485 Don't set size unless allocation succeeds.
9487 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9488 for sizes. Check for string overflow more accurately.
9489 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9491 * macros.c: Integer and buffer overflow fixes.
9492 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9493 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9494 Use ptrdiff_t, not int, for sizes.
9495 Don't increment bufsize until after realloc succeeds.
9496 Check for size-calculation overflow.
9497 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9499 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9501 * lread.c: Integer overflow fixes.
9502 (read_integer): Radix is now EMACS_INT, not int,
9503 to improve quality of diagnostics for out-of-range radices.
9504 Calculate buffer size correctly for out-of-range radices.
9505 (read1): Check for integer overflow in radices, and in
9506 read-circle numbers.
9507 (read_escape): Avoid int overflow.
9508 (Fload, openp, read_buffer_size, read1)
9509 (substitute_object_recurse, read_vector, read_list, map_obarray):
9510 Use ptrdiff_t, not int, for sizes.
9511 (read1): Use EMACS_INT, not int, for sizes.
9512 Check for size overflow.
9514 * image.c (cache_image): Check for size arithmetic overflow.
9516 * lread.c: Integer overflow issues.
9517 (saved_doc_string_size, saved_doc_string_length)
9518 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9519 Now ptrdiff_t, not int.
9520 (read1): Don't assume doc string length fits in int. Check for
9521 out-of-range doc string lengths.
9522 (read_list): Don't assume file position fits in int.
9523 (read_escape): Check for hex character overflow.
9525 2011-06-22 Leo Liu <sdl.web@gmail.com>
9527 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9528 Move to minibuffer.el.
9530 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9532 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9533 The following patches are for when GLYPH_DEBUG && !XASSERT.
9534 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9535 * dispnew.c (flush_stdout):
9536 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9537 Mark as externally visible.
9538 * dispnew.c (check_window_matrix_pointers): Now static.
9539 * dispnew.c (window_to_frame_vpos):
9540 * xfns.c (unwind_create_frame):
9541 * xterm.c (x_check_font): Remove unused local.
9542 * scroll.c (CHECK_BOUNDS):
9543 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9544 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9545 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9546 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9547 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9549 (debug_method_add): Use va_list and vsprintf rather than relying
9550 on undefined behavior with wrong number of arguments.
9551 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9552 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9553 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9554 since we're not interested in debugging glyphs with old libraries.
9555 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9556 GCC 4.6.0's static checking.
9558 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9560 Integer overflow and signedness fixes (Bug#8873).
9561 A few related buffer overrun fixes, too.
9563 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9565 * dispextern.h (struct face.stipple):
9566 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9567 (x_bitmap_mask, x_allocate_bitmap_record)
9568 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9569 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9570 (x_create_bitmap_from_xpm_data):
9571 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9572 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9574 * xfaces.c (load_pixmap):
9575 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9576 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9577 (.bitmaps_last, struct x_output.icon_bitmap):
9578 Use ptrdiff_t, not int, for bitmap indexes.
9579 (x_allocate_bitmap_record): Check for size overflow.
9580 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9582 Use ptrdiff_t, not int, for overlay counts.
9583 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9584 * editfns.c (overlays_around, get_pos_property):
9585 * textprop.c (get_char_property_and_overlay):
9586 * xdisp.c (next_overlay_change, note_mouse_highlight):
9587 * xfaces.c (face_at_buffer_position):
9588 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9589 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9590 (Fnext_overlay_change, Fprevious_overlay_change)
9591 (mouse_face_overlay_overlaps, Foverlays_in):
9592 Use ptrdiff_t, not int, for sizes.
9593 (overlays_at, overlays_in): Check for size-calculation overflow.
9595 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9597 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9598 (x_session_initialize): Do not assume string length fits in int.
9600 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9601 This is unlikely, but can occur if DPI is outlandish.
9603 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9604 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9606 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9607 * xrdb.c (magic_file_p, search_magic_path):
9608 Omit last arg SUFFIX; it was always 0. All callers changed.
9609 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9611 * xfont.c (xfont_match): Avoid need for strlen.
9613 * xfns.c: Don't assume strlen fits in int.
9614 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9616 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9617 not unsigned long, as we prefer signed integers. All callers changed.
9618 Detect integer overflow in repeat count.
9619 (message_dolog): Don't assume print length fits in 39 bytes.
9620 (display_mode_element): Don't assume strlen fits in int.
9622 * termcap.c: Don't assume sizes fit in int and never overflow.
9623 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9624 (gobble_line): Check for size-calculation overflow.
9626 * minibuf.c (Fread_buffer):
9627 * lread.c (intern, intern_c_string):
9628 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9629 Don't assume string length fits in int.
9631 * keyboard.c (parse_tool_bar_item):
9632 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9634 * font.c: Don't assume string length fits in int.
9635 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9636 Use ptrdiff_t, not int.
9637 (font_intern_prop): Don't assume string length fits in int.
9638 Don't assume integer property fits in fixnum.
9639 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9641 * filelock.c: Fix some buffer overrun and integer overflow issues.
9642 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9643 Reformulate so as not to need the command string.
9644 Invoke gzip -cd rather than gunzip, as it's more portable.
9645 (lock_info_type, lock_file_1, lock_file):
9646 Don't assume pid_t and time_t fit in unsigned long.
9647 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9648 (current_lock_owner): Prefer signed type for sizes.
9649 Use memcpy, not strncpy, where memcpy is what is really wanted.
9650 Don't assume (via atoi) that time_t and pid_t fit in int.
9651 Check for time_t and/or pid_t out of range, e.g., via a network share.
9652 Don't alloca where an auto var works fine.
9654 * fileio.c: Fix some integer overflow issues.
9655 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9656 Don't assume string length fits in int.
9657 (directory_file_name): Don't assume string length fits in long.
9658 (make_temp_name): Don't assume pid fits in int, or that its print
9659 length is less than 20.
9661 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9663 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9665 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9667 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9668 We prefer signed integers, even for size calculations.
9670 * emacs.c: Don't assume string length fits in 'int'.
9671 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9672 (main): Don't invoke strlen when not needed.
9674 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9675 (XD_DEBUG_MESSAGE): Don't waste a byte.
9677 * callproc.c (getenv_internal_1, getenv_internal)
9679 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9681 * lread.c (invalid_syntax): Omit length argument.
9682 All uses changed. This doesn't fix a bug, but it simplifies the
9683 code away from its former Hollerith-constant appearance, and it's
9684 one less 'int' to worry about when looking at integer-overflow issues.
9685 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9687 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9688 This didn't break anything, but it didn't help either.
9689 It's confusing to put a bogus integer in a place where the actual
9690 value does not matter.
9691 (LIST_END_P): Remove unused macro and its bogus comment.
9692 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9694 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9695 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9697 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9698 We prefer signed types, and the value cannot exceed the EMACS_INT
9699 range anyway (because otherwise the length would not be representable).
9700 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9701 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9702 This avoids a GCC warning when WIDE_EMACS_INT.
9704 * indent.c (sane_tab_width): New function.
9705 (current_column, scan_for_column, Findent_to, position_indentation)
9706 (compute_motion): Use it. This is just for clarity.
9707 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9709 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9711 * lisp.h (lint_assume): New macro.
9712 * composite.c (composition_gstring_put_cache):
9713 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9715 * editfns.c, insdel.c:
9716 Omit unnecessary forward decls, to simplify future changes.
9718 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9720 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9722 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9723 Use much-faster test for byte-length change.
9724 Don't assume string byte-length fits in 'int'.
9725 Check that character arg fits in 'int'.
9726 (mapcar1): Declare byte as byte, for clarity.
9728 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9730 * fns.c (concat): Catch string overflow earlier.
9731 Do not rely on integer wraparound.
9733 * dispextern.h (struct it.overlay_strings_charpos)
9734 (struct it.selective): Now EMACS_INT, not int.
9735 * xdisp.c (forward_to_next_line_start)
9736 (back_to_previous_visible_line_start)
9737 (reseat_at_next_visible_line_start, next_element_from_buffer):
9738 Don't arbitrarily truncate the value of 'selective' to int.
9740 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9742 * composite.c: Don't truncate sizes to 'int'.
9743 (composition_gstring_p, composition_reseat_it)
9744 (composition_adjust_point): Use EMACS_INT, not int.
9745 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9746 not EMACS_UINT, for indexes.
9748 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9750 * buffer.c: Include <verify.h>.
9751 (struct sortvec.priority, struct sortstr.priority):
9752 Now EMACS_INT, not int.
9753 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9754 (struct sortstr.size, record_overlay_string)
9755 (struct sortstrlist.size, struct sortlist.used):
9756 Don't truncate size to int.
9757 (record_overlay_string): Check for size-calculation overflow.
9758 (init_buffer_once): Check at compile-time, not run-time.
9760 2011-06-22 Jim Meyering <meyering@redhat.com>
9762 Don't leak an XBM-image-sized buffer
9763 * image.c (xbm_load): Free the image buffer after using it.
9765 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9768 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9769 that Sun C diagnosed.
9770 * fns.c (secure_hash): Fix pointer signedness issue.
9771 * intervals.c (static_offset_intervals): New function.
9772 (offset_intervals): Use it.
9774 2011-06-21 Leo Liu <sdl.web@gmail.com>
9777 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9780 * fns.c (secure_hash): Rename from crypto_hash_function and change
9781 the first arg to accept symbols.
9782 (Fsecure_hash): New primitive.
9783 (syms_of_fns): New symbols.
9785 2011-06-20 Deniz Dogan <deniz@dogan.se>
9787 * process.c (Fset_process_buffer): Clarify return value in
9790 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9792 * dispnew.c (add_window_display_history): Use BVAR.
9794 * xdisp.c (debug_method_add): Use BVAR.
9795 (check_window_end, dump_glyph_matrix, dump_glyph)
9796 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9798 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9801 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9802 check till after the cache is created in init_frame_faces.
9804 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9806 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9808 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9810 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9811 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9812 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9814 Improve buffer-overflow checking (Bug#8873).
9815 * fileio.c (Finsert_file_contents):
9816 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9817 Remove the old (too-loose) buffer overflow checks.
9818 They weren't needed, since make_gap checks for buffer overflow.
9819 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9820 The old code merely checked for Emacs fixnum overflow, and relied
9821 on undefined (wraparound) behavior. The new code avoids undefined
9822 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9824 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9825 Tune. Don't use wider integers than needed. Don't use alloca.
9826 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9828 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9830 * insdel.c, lisp.h (buffer_overflow): New function.
9831 (insert_from_buffer_1, replace_range, replace_range_2):
9832 * insdel.c (make_gap_larger):
9833 * editfns.c (Finsert_char):
9834 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9836 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9838 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9840 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9842 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9843 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9845 * fileio.c: Don't assume EMACS_INT fits in off_t.
9846 (emacs_lseek): New static function.
9847 (Finsert_file_contents, Fwrite_region): Use it.
9848 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9850 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9852 * fns.c: Don't overflow int when computing a list length.
9853 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9854 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9855 truncation on 64-bit hosts. Check for QUIT every
9856 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9857 faster and is responsive enough.
9858 (Flength): Report an error instead of overflowing an integer.
9859 (Fsafe_length): Return a float if the value is not representable
9860 as a fixnum. This shouldn't happen except in contrived situations.
9861 (Fnthcdr, Fsort): Don't assume list length fits in int.
9862 (Fcopy_sequence): Don't assume vector length fits in int.
9864 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9865 (header_size, word_size): New constants.
9866 (allocate_vectorlike): Don't check size overflow here.
9867 (allocate_vector): Check it here instead, since this is the only
9868 caller of allocate_vectorlike that could cause overflow.
9869 Check that the new vector's length is representable as a fixnum.
9871 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9872 The previous code was bogus. For example, next_almost_prime (32)
9873 returned 39, which is undesirable as it is a multiple of 3; and
9874 next_almost_prime (24) returned 25, which is a multiple of 5 so
9875 why was the code bothering to check for multiples of 7?
9877 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9879 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9881 Variadic C functions now count arguments with ptrdiff_t.
9882 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9883 Back then I didn't know that the Emacs coding style prefers signed int.
9884 Also, in the meantime I found a few more instances where arguments
9885 were being counted with int, which may truncate counts on 64-bit
9886 machines, or EMACS_INT, which may be unnecessarily wide.
9887 * lisp.h (struct Lisp_Subr.function.aMANY)
9888 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9889 Arg counts are now ptrdiff_t, not size_t.
9890 All variadic functions and their callers changed accordingly.
9891 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9892 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9893 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9894 * callint.c (Fcall_interactively): Check arg count for overflow,
9895 to avoid potential buffer overrun. Use signed char, not 'int',
9896 for 'varies' array, so that we needn't bother to check its size
9897 calculation for overflow.
9898 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9899 * eval.c (apply_lambda):
9900 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9901 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9902 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9904 * callint.c (Fcall_interactively): Don't use index var as event count.
9906 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9907 * mem-limits.h (SIZE): Remove; no longer used.
9909 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9911 Remove unnecessary casts.
9912 * xterm.c (x_term_init):
9913 * xfns.c (x_set_border_pixel):
9914 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9915 These aren't needed now that we assume ANSI C.
9917 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9918 It's more likely to cause problems (due to unsigned overflow)
9921 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9923 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9925 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9927 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9929 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9931 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9933 GLYPH_CODE_FACE returns EMACS_INT, not int.
9934 * dispextern.h (merge_faces):
9935 * xfaces.c (merge_faces):
9936 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9937 Don't assume EMACS_INT fits in int.
9939 * character.h (CHAR_VALID_P): Remove unused parameter.
9940 * fontset.c, lisp.h, xdisp.c: All uses changed.
9942 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9944 * fns.c (concat): Minor tuning based on overflow analysis.
9945 This doesn't fix any bugs. Use int to hold character, instead
9946 of constantly refetching from Emacs object. Use XFASTINT, not
9947 XINT, for value known to be a character. Don't bother comparing
9948 a single byte to 0400, as it's always less.
9950 * floatfns.c (Fexpt):
9951 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9953 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9956 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9958 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9959 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9960 incorrectly succeed when S was a string, because 4294967386 was
9961 truncated before it was used.
9963 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9964 Otherwise, an out-of-range integer could cause undefined behavior
9967 * composite.c: Use int, not EMACS_INT, for characters.
9968 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9969 EMACS_INT, for values that are known to be in character range.
9970 This doesn't fix any bugs but is the usual style inside Emacs and
9971 may generate better code on 32-bit machines.
9973 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9974 This is for reasons similar to the recent CHAR_STRING fix.
9975 * charset.c (Fencode_char): Check that character arg is actually
9976 a character. Pass an int to ENCODE_CHAR.
9977 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9978 wider than 'int', as a compile-time check to prevent future regressions
9981 * character.c (char_string): Remove unnecessary casts.
9983 Make sure a 64-bit char is never passed to CHAR_STRING.
9984 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9985 by silently ignoring the top 32 bits, allowing some values
9986 that were far too large to be valid characters.
9987 * character.h: Include <verify.h>.
9988 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9989 arguments are no wider than unsigned, as a compile-time check
9990 to prevent future regressions in this area.
9992 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9993 (Fsubst_char_in_region):
9995 * xdisp.c (decode_mode_spec_coding):
9996 Adjust to CHAR_STRING's new requirement.
9997 * editfns.c (Finsert_char, Fsubst_char_in_region):
9998 * fns.c (concat): Check that character args are actually
9999 characters. Without this test, these functions did the wrong
10000 thing with wildly out-of-range values on 64-bit hosts.
10002 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10003 These casts should not be needed on 32-bit hosts, either.
10004 * keyboard.c (read_char):
10005 * lread.c (Fload): Remove casts to unsigned.
10007 * lisp.h (UNSIGNED_CMP): New macro.
10008 This fixes comparison bugs on 64-bit hosts.
10009 (ASCII_CHAR_P): Use it.
10010 * casefiddle.c (casify_object):
10011 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10012 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10013 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10014 * dispextern.h (FACE_FROM_ID):
10015 * keyboard.c (read_char): Use UNSIGNED_CMP.
10017 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10018 not to EMACS_INT, to avoid GCC warning.
10020 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10022 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10023 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10024 isn't needed on 32-bit machines.
10026 * buffer.c (Fgenerate_new_buffer_name):
10027 Use EMACS_INT for count, not int.
10028 (advance_to_char_boundary): Return EMACS_INT, not int.
10030 * data.c (Qcompiled_function): Now static.
10032 * window.c (window_body_lines): Now static.
10034 * image.c (gif_load): Rename local to avoid shadowing.
10036 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10037 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10038 * alloc.c (make_save_value): Integer argument is now of type
10039 ptrdiff_t, not int.
10040 (mark_object): Use ptrdiff_t, not int.
10041 * lisp.h (pD): New macro.
10042 * print.c (print_object): Use it.
10044 * alloc.c: Use EMACS_INT, not int, to count objects.
10045 (total_conses, total_markers, total_symbols, total_vector_size)
10046 (total_free_conses, total_free_markers, total_free_symbols)
10047 (total_free_floats, total_floats, total_free_intervals)
10048 (total_intervals, total_strings, total_free_strings):
10049 Now EMACS_INT, not int. All uses changed.
10050 (Fgarbage_collect): Compute overall total using a double, so that
10051 integer overflow is less likely to be a problem. Check for overflow
10052 when converting back to an integer.
10053 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10054 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10055 These were 'int' variables that could overflow on 64-bit hosts;
10056 they were never used, so remove them instead of repairing them.
10057 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10058 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10059 Previously, this ceilinged at INT_MAX, but that doesn't work on
10061 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10063 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10064 (allocate_vectorlike): Check for ptrdiff_t overflow.
10065 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10066 when a (possibly-narrower) signed value would do just as well.
10067 We prefer using signed arithmetic, to avoid comparison confusion.
10069 * alloc.c: Catch some string size overflows that we were missing.
10070 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10071 for convenience in STRING_BYTES_MAX.
10072 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10073 The definition here is exact; the one in lisp.h was approximate.
10074 (allocate_string_data): Check for string overflow. This catches
10075 some instances we weren't catching before. Also, it catches
10076 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10077 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10078 and ptrdiff_t and EMACS_INT are both 64 bits.
10080 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10081 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10082 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10084 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10086 * alloc.c (Fmake_string): Check for out-of-range init.
10088 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10090 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10092 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10094 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10095 xg_get_default_scrollbar_width.
10097 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10098 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10099 (style_changed_cb): Call update_theme_scrollbar_width and call
10100 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10101 all frames (Bug#8505).
10102 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10103 Call gtk_window_set_resizable if HAVE_GTK3.
10104 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10105 and height if HAVE_GTK3 (Bug#8505).
10106 (scroll_bar_width_for_theme): New variable.
10107 (update_theme_scrollbar_width): New function.
10108 (xg_get_default_scrollbar_width): Move code to
10109 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10110 (xg_initialize): Call update_theme_scrollbar_width.
10112 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10114 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10116 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10118 * frame.c (make_frame): Call other_buffer_safely instead of
10121 * window.c (temp_output_buffer_show): Call display_buffer with
10122 second argument Vtemp_buffer_show_specifiers and reset latter
10123 immediately after the call.
10124 (Vtemp_buffer_show_specifiers): New variable.
10125 (auto_window_vscroll_p, next_screen_context_lines)
10126 (Vscroll_preserve_screen_position): Remove leading asterisks from
10129 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10131 Fix minor problems found by GCC 4.6.0 static checking.
10132 * buffer.c (Qclone_number): Remove for now, as it's unused.
10133 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10134 (record_buffer): Remove unused local.
10135 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10136 (set_frame_buffer_list): Remove; unused.
10137 * frame.h (other_visible_frames): Remove decl.
10138 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10139 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10140 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10142 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10143 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10144 Define only if HAVE_GPM.
10145 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10146 (update_hints_inhibit): Remove; never set. All uses removed.
10147 * widgetprv.h (emacsFrameClassRec): Remove decl.
10148 * window.c (delete_deletable_window): Now returns void, since it
10149 wasn't returning anything.
10150 (compare_window_configurations): Remove unused locals.
10151 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10152 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10153 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10154 the same widths as pointers. This follows up on the 2011-05-06 patch.
10155 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10156 * xterm.h: Likewise.
10157 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10159 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10161 * makefile.w32-in: Update dependencies.
10162 (LISP_H): Add lib/intprops.h.
10164 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10166 * image.c (gif_load): Add animation frame delay to the metadata.
10167 (syms_of_image): Use DEFSYM. New symbol `delay'.
10169 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10171 * window.c (delete_deletable_window): Re-add.
10172 (Fset_window_configuration): Rewrite to handle dead buffers and
10173 consequently deletable windows.
10174 (window_tree, Fwindow_tree): Remove. Supply functionality in
10176 (compare_window_configurations): Simplify code.
10178 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10180 * image.c (imagemagick_load_image): Fix type mismatch.
10181 (Fimagemagick_types): Likewise.
10183 * window.h (replace_buffer_in_windows): Declare.
10185 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10187 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10188 Qclone_number. Remove external declaration of Qdelete_window.
10189 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10191 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10192 Run Qbuffer_list_update_hook if allowed.
10193 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10194 buffer list implementation.
10195 (other_buffer_safely): New function.
10196 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10197 calls to replace_buffer_in_windows and
10198 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10200 (record_buffer): Inhibit quitting and rewrite using quittable
10201 functions. Run Qbuffer_list_update_hook if allowed.
10202 (Frecord_buffer, Funrecord_buffer): New functions.
10203 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10204 Move switch-to-buffer to window.el.
10205 (bury-buffer): Move to window.el.
10206 (Vbuffer_list_update_hook): New variable.
10208 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10211 * window.h (resize_frame_windows): Move up in code.
10212 (Fwindow_frame): Remove EXFUN.
10213 (replace_buffer_in_all_windows): Remove prototype.
10214 (replace_buffer_in_windows_safely): Add prototype.
10216 * window.c: Declare Qdelete_window static again. Move down
10217 declaration of select_count.
10218 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10219 (Fother_window): Move to window.el.
10220 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10221 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10222 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10224 (replace_buffer_in_windows): Implement by calling
10225 Qreplace_buffer_in_windows.
10226 (replace_buffer_in_all_windows): Remove with some functionality
10227 moved into replace_buffer_in_windows_safely.
10228 (replace_buffer_in_windows_safely): New function.
10229 (select_window_norecord, select_frame_norecord): Move in front
10230 of run_window_configuration_change_hook. Remove now obsolete
10232 (Fset_window_buffer): Rewrite doc-string.
10233 Call Qrecord_window_buffer.
10234 (keys_of_window): Move binding for other-window to window.el.
10236 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10238 * dispextern.h (struct image): Replace data member, whose int_val
10239 and ptr_val fields were not used by anything, with a single
10242 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10243 (gif_clear_image, gif_load, imagemagick_load_image)
10244 (gs_clear_image, gs_load): Callers changed.
10246 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10248 * buffer.h: Include <time.h>, for time_t.
10249 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10251 Fix minor problems found by static checking.
10253 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10255 Make identifiers static if they are not used in other modules.
10256 * data.c (Qcompiled_function, Qframe, Qvector):
10257 * image.c (QimageMagick, Qsvg):
10258 * minibuf.c (Qmetadata):
10259 * window.c (resize_window_check, resize_root_window): Now static.
10260 * window.h (resize_window_check, resize_root_window): Remove decls.
10262 * window.c (window_deletion_count, delete_deletable_window):
10264 (window_body_lines): Now static.
10265 (Fdelete_other_windows_internal): Mark vars as initialized.
10266 Make sure 'resize_failed' is initialized.
10267 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10268 (resize_window_apply): Remove unused local.
10269 * window.h (delete_deletable_window): Remove decl.
10271 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10272 (imagemagick_load_image): Fix pointer signedness problem by changing
10273 last arg from unsigned char * to char *. All uses changed.
10274 Also, fix a local for similar reasons.
10275 Remove unused locals. Remove locals to avoid shadowing.
10276 (fn_rsvg_handle_free): Remove; unused.
10277 (svg_load, svg_load_image): Fix pointer signedness problem.
10278 (imagemagick_load_image): Don't use garbage pointer image_wand.
10280 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10282 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10284 * image.c (gif_load): Fix omitted cast error introduced by
10287 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10289 * window.h (resize_proportionally, orig_total_lines)
10290 (orig_top_line): Remove from window structure.
10291 (set_window_height, set_window_width, change_window_heights)
10292 (Fdelete_window): Remove prototypes.
10293 (resize_frame_windows): Remove duplicate declaration.
10295 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10297 * window.h (resize_frame_windows, resize_window_check)
10298 (delete_deletable_window, resize_root_window)
10299 (resize_frame_windows): Declare prototypes.
10301 * window.c (resize_window_apply): Make definition be "static" to
10302 match the prototype.
10304 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10306 * window.c: Remove declarations of Qwindow_size_fixed,
10307 window_min_size_1, window_min_size_2, window_min_size,
10308 size_window, window_fixed_size_p, enlarge_window, delete_window.
10309 Remove static from declaration of Qdelete_window, it's
10310 temporarily needed by Fbury_buffer.
10311 (replace_window): Don't assign orig_top_line and
10313 (Fdelete_window, delete_window): Remove. Window deletion is
10314 handled by window.el.
10315 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10316 Replace Fdelete_window calls with calls to Qdelete_window.
10317 (Fdelete_other_windows): Remove. Deleting other windows is
10318 handled by window.el.
10319 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10320 handled in window.el.
10321 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10322 Window minimum sizes are handled in window.el.
10323 (shrink_windows, size_window, set_window_height)
10324 (set_window_width, change_window_heights, window_height)
10325 (window_width, CURBEG, CURSIZE, enlarge_window)
10326 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10327 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10328 handled in window.el.
10329 (make_dummy_parent): Rename to make_parent_window and give it a
10330 second argument horflag.
10331 (make_window): Don't set resize_proportionally any more.
10332 (Fsplit_window): Remove. Windows are split in window.el.
10333 (save_restore_action, save_restore_orig_size)
10334 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10335 Resize mini windows in window.el.
10336 (grow_mini_window, shrink_mini_window): Implement by calling
10337 Qresize_root_window_vertically, resize_window_check and
10338 resize_window_apply.
10339 (saved_window, Fset_window_configuration, save_window_save):
10340 Do not handle orig_top_line, orig_total_lines, and
10341 resize_proportionally.
10342 (window_min_height, window_min_width): Move to window.el.
10343 (keys_of_window): Move bindings for delete-other-windows,
10344 split-window, delete-window and enlarge-window to window.el.
10346 * buffer.c: Temporarily extern Qdelete_window.
10347 (Fbury_buffer): Temporarily call Qdelete_window instead of
10348 Fdelete_window (Fbury_buffer will move to window.el soon).
10350 * frame.c (set_menu_bar_lines_1): Remove code handling
10351 orig_top_line and orig_total_lines.
10353 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10354 set_window_height but set heights directly.
10355 (change_frame_size_1): Use resize_frame_windows.
10357 * xdisp.c (init_xdisp): Don't use set_window_height but set
10360 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10361 Use resize_frame_windows instead of change_window_heights and run
10362 run_window_configuration_change_hook.
10364 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10365 instead of change_window_heights and run
10366 run_window_configuration_change_hook.
10368 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10370 * window.c (replace_window): Rename second argument REPLACEMENT to
10371 NEW. New third argument SETFLAG. Rewrite.
10372 (delete_window, make_dummy_parent): Call replace_window with
10374 (window_list_1): Move down in code.
10375 (run_window_configuration_change_hook): Move set_buffer part
10376 before select_frame_norecord part in order to unwind correctly.
10377 Rename count1 to count.
10378 (recombine_windows, delete_deletable_window, resize_root_window)
10379 (Fdelete_other_windows_internal)
10380 (Frun_window_configuration_change_hook, make_parent_window)
10381 (resize_window_check, resize_window_apply, Fresize_window_apply)
10382 (resize_frame_windows, Fsplit_window_internal)
10383 (Fdelete_window_internal, Fresize_mini_window_internal):
10385 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10387 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10389 * window.h (window): Add some new members to window structure -
10390 normal_lines, normal_cols, new_total, new_normal, clone_number,
10391 splits, nest, prev_buffers, next_buffers.
10392 (WINDOW_TOTAL_SIZE): Move here from window.c.
10393 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10395 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10397 (make_dummy_parent): Set new members of windows structure.
10398 (make_window): Move down in code. Handle new members of window
10400 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10401 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10402 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10403 (Fset_window_prev_buffers, Fwindow_next_buffers)
10404 (Fset_window_next_buffers, Fset_window_clone_number):
10406 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10407 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10409 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10410 Argument WINDOW can be now internal window too.
10411 (Fwindow_use_time): Move up in code.
10412 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10413 Rewrite doc-string.
10414 (Fset_window_configuration, saved_window)
10415 (Fcurrent_window_configuration, save_window_save): Handle new
10416 members of window structure.
10417 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10418 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10419 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10420 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10421 Qget_mru_window, Qresize_root_window,
10422 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10423 Qauto_buffer_name; staticpro them.
10425 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10427 * window.c (Fwindow_total_size, Fwindow_left_column)
10428 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10429 (Fwindow_list_1): New functions.
10430 (window_box_text_cols): Replace with window_body_cols.
10431 (Fwindow_width, Fscroll_left, Fscroll_right):
10432 Use window_body_cols instead of window_box_text_cols.
10433 (delete_window, Fset_window_configuration):
10434 Call delete_all_subwindows with window as argument.
10435 (delete_all_subwindows): Take a window as argument and not a
10436 structure. Rewrite.
10437 (window_loop): Remove handling of GET_LRU_WINDOW and
10438 GET_LARGEST_WINDOW.
10439 (Fget_lru_window, Fget_largest_window): Move to window.el.
10441 * window.h: Extern window_body_cols instead of
10442 window_box_text_cols. delete_all_subwindows now takes a
10443 Lisp_Object as argument.
10445 * indent.c (compute_motion, Fcompute_motion):
10446 Use window_body_cols instead of window_box_text_cols.
10448 * frame.c (delete_frame): Call delete_all_subwindows with root
10449 window as argument.
10451 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10453 * fns.c (Fputhash): Document return value.
10455 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10457 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10459 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10461 Cons<->int and similar integer overflow fixes (Bug#8794).
10463 Check for overflow when converting integer to cons and back.
10464 * charset.c (Fdefine_charset_internal, Fdecode_char):
10465 Use cons_to_unsigned to catch overflow.
10466 (Fencode_char): Use INTEGER_TO_CONS.
10467 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10468 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10469 * data.c (long_to_cons, cons_to_long): Remove.
10470 (cons_to_unsigned, cons_to_signed): New functions.
10471 These signal an error for invalid or out-of-range values.
10472 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10473 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10474 * font.c (Ffont_variation_glyphs):
10475 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10476 * lisp.h: Include <intprops.h>.
10477 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10478 (cons_to_signed, cons_to_unsigned): New decls.
10479 (long_to_cons, cons_to_long): Remove decls.
10480 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10481 (Fprimitive_undo): Use CONS_TO_INTEGER.
10482 * xfns.c (Fx_window_property): Likewise.
10483 * xselect.c: Include <limits.h>.
10484 (x_own_selection, selection_data_to_lisp_data):
10485 Use INTEGER_TO_CONS.
10486 (x_handle_selection_request, x_handle_selection_clear)
10487 (x_get_foreign_selection, Fx_disown_selection_internal)
10488 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10489 (lisp_data_to_selection_data): Use cons_to_unsigned.
10490 (x_fill_property_data): Use cons_to_signed.
10491 Report values out of range.
10493 Check for buffer and string overflow more precisely.
10494 * buffer.h (BUF_BYTES_MAX): New macro.
10495 * lisp.h (STRING_BYTES_MAX): New macro.
10496 * alloc.c (Fmake_string):
10497 * character.c (string_escape_byte8):
10498 * coding.c (coding_alloc_by_realloc):
10499 * doprnt.c (doprnt):
10500 * editfns.c (Fformat):
10502 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10503 since they may not be the same number.
10504 * editfns.c (Finsert_char):
10505 * fileio.c (Finsert_file_contents):
10506 Likewise for BUF_BYTES_MAX.
10508 * image.c: Use ptrdiff_t, not int, for sizes.
10509 (slurp_file): Switch from int to ptrdiff_t.
10511 (slurp_file): Check that file size fits in both size_t (for
10512 malloc) and ptrdiff_t (for sanity and safety).
10514 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10515 if b->modtime has its maximal value.
10517 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10519 Don't assume time_t can fit into int.
10520 * buffer.h (struct buffer.modtime): Now time_t, not int.
10521 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10522 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10524 Minor fixes for signed vs unsigned integers.
10525 * character.h (MAYBE_UNIFY_CHAR):
10526 * charset.c (maybe_unify_char):
10527 * keyboard.c (read_char, reorder_modifiers):
10528 XINT -> XFASTINT, since the integer must be nonnegative.
10529 * ftfont.c (ftfont_spec_pattern):
10530 * keymap.c (access_keymap, silly_event_symbol_error):
10531 XUINT -> XFASTINT, since the integer must be nonnegative.
10532 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10533 since it makes no difference and we prefer signed.
10534 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10535 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10538 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10540 * window.h (Fwindow_frame): Declare.
10542 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10544 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10545 (SPARE_MEMORY): Always define.
10546 (LARGE_REQUEST): Remove.
10547 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10549 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10551 * lisp.h: Move EXFUNS for Fframe_root_window,
10552 Fframe_first_window and Fset_frame_selected_window to window.h.
10554 * window.h: Move EXFUNS for Fframe_root_window,
10555 Fframe_first_window and Fset_frame_selected_window here from
10558 * frame.c (Fwindow_frame, Fframe_first_window)
10559 (Fframe_root_window, Fframe_selected_window)
10560 (Fset_frame_selected_window): Move to window.c.
10561 (Factive_minibuffer_window): Move to minibuf.c.
10562 (Fother_visible_frames_p): New function.
10564 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10566 * window.c (decode_window, decode_any_window): Move up in code.
10567 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10568 (inhibit_frame_unsplittable): Remove unused variable.
10569 (Fwindow_buffer): Move up and rewrite doc-string.
10570 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10571 (Fwindow_prev): New functions.
10572 (Fwindow_frame): Move here from frame.c. Accept any window as
10574 (Fframe_root_window, Fframe_first_window)
10575 (Fframe_selected_window): Move here from frame.c. Accept frame
10576 or arbitrary window as argument. Update doc-strings.
10577 (Fminibuffer_window): Move up in code.
10578 (Fwindow_minibuffer_p): Move up in code and simplify.
10579 (Fset_frame_selected_window): Move here from frame.c.
10581 (Fselected_window, select_window, Fselect_window): Move up in
10582 code. Minor doc-string fixes.
10584 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10586 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10587 Do not assume that spare memory exists; that assumption is valid
10588 only if SYSTEM_MALLOC.
10589 (LARGE_REQUEST): New macro, so that the issue of large requests
10590 is separated from the issue of spare memory.
10592 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10594 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10597 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10599 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10602 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10604 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10606 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10608 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10609 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10611 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10613 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10615 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10617 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10618 (x_clipboard_manager_save): Add return value.
10619 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10620 New error handlers.
10621 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10622 Obey Vx_select_enable_clipboard_manager. Catch errors in
10623 x_clipboard_manager_save (Bug#8779).
10624 (Vx_select_enable_clipboard_manager): New variable.
10625 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10627 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10629 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10631 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10633 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10634 in the current matrix if keep_current_p is non-zero.
10636 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10638 * bidi.c (bidi_level_of_next_char): Fix last change.
10640 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10642 Support bidi reordering of text covered by display properties.
10644 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10645 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10646 (bidi_cache_search, bidi_cache_iterator_state)
10647 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10648 (bidi_level_of_next_char, bidi_move_to_visually_next):
10649 Support character positions inside a run of characters covered by a
10651 (bidi_paragraph_init, bidi_resolve_explicit_1)
10652 (bidi_level_of_next_char): Call bidi_fetch_char and
10653 bidi_fetch_char_advance instead of FETCH_CHAR and
10654 FETCH_CHAR_ADVANCE.
10655 (bidi_init_it): Initialize new members.
10656 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10658 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10659 instead of using explicit *_CHAR codes.
10660 (bidi_resolve_explicit, bidi_resolve_weak):
10661 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10662 bidirectional text is supported only in multibyte buffers.
10663 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10664 it to initialize the frame_window_p member of struct bidi_it.
10665 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10666 (bidi_resolve_explicit, bidi_resolve_weak)
10667 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10668 bidi_it->nchars is non-positive.
10669 (bidi_level_of_next_char): Don't try to lookup the cache for the
10670 next/previous character if nothing is cached there yet, or if we
10671 were just reseat()'ed to a new position.
10673 * xdisp.c (set_cursor_from_row): Set start and stop points
10674 according to the row's direction when priming the loop that looks
10675 for the glyph on which to display cursor.
10676 (single_display_spec_intangible_p): Function deleted.
10677 (display_prop_intangible_p): Reimplement to call
10678 handle_display_spec instead of single_display_spec_intangible_p.
10679 Accept 3 additional arguments needed by handle_display_spec.
10680 This fixes incorrect cursor motion across display property with complex
10681 values: lists, `(when COND...)' forms, etc.
10682 (single_display_spec_string_p): Support property values that are
10683 lists with the argument STRING its top-level element.
10684 (display_prop_string_p): Fix the condition for processing a
10685 property that is a list to be consistent with handle_display_spec.
10686 (handle_display_spec): New function, refactored from the
10687 last portion of handle_display_prop.
10688 (compute_display_string_pos): Accept additional argument
10689 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10690 value of a `display' property is a "replacing spec".
10691 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10692 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10693 the display property, but just return a value indicating whether
10694 the display property will replace the characters it covers.
10695 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10696 frame_window_p members of struct bidi_it.
10697 (compute_display_string_pos, compute_display_string_end):
10699 (push_it): Accept second argument POSITION, where pop_it should
10700 jump to continue iteration.
10701 (reseat_1): Initialize bidi_it.disp_pos.
10703 * keyboard.c (adjust_point_for_property): Adjust the call to
10704 display_prop_intangible_p to its new signature.
10706 * dispextern.h (struct bidi_it): New member frame_window_p.
10707 (bidi_init_it): Update prototypes.
10708 (display_prop_intangible_p): Update prototype.
10709 (compute_display_string_pos, compute_display_string_end):
10710 Declare prototypes.
10711 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10714 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10716 Malloc failure behavior now depends on size of allocation.
10717 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10718 * lisp.h: Change signatures accordingly.
10719 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10720 All callers changed. (Bug#8762)
10722 * gnutls.c: Use Emacs's memory allocators.
10723 Without this change, the gnutls library would invoke malloc etc.
10724 directly, which causes problems on non-SYNC_INPUT hosts, and which
10725 runs afoul of improving memory_full behavior. (Bug#8761)
10726 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10727 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10728 xfree instead of the default malloc, realloc, free.
10729 (Fgnutls_boot): No need to check for memory allocation failure,
10730 since xmalloc does that for us.
10732 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10733 * category.c (hash_get_category_set):
10734 * ccl.c (ccl_driver):
10735 * charset.c (Fdefine_charset_internal):
10736 * charset.h (struct charset.hash_index):
10737 * composite.c (get_composition_id, gstring_lookup_cache)
10738 (composition_gstring_put_cache):
10739 * composite.h (struct composition.hash_index):
10740 * dispextern.h (struct image.hash):
10741 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10742 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10743 (hashfn_equal, hashfn_user_defined, make_hash_table)
10744 (maybe_resize_hash_table, hash_lookup, hash_put)
10745 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10746 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10747 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10748 * image.c (make_image, search_image_cache, lookup_image)
10749 (xpm_put_color_table_h):
10750 * lisp.h (struct Lisp_Hash_Table):
10751 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10752 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10753 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10754 * alloc.c (allocate_vectorlike):
10755 Check for overflow in vector size calculations.
10756 * ccl.c (ccl_driver):
10757 Check for overflow when converting EMACS_INT to int.
10758 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10759 need to be updated by these changes.
10760 * fns.c (make_hash_table, maybe_resize_hash_table):
10761 Check for integer overflow with large hash tables.
10762 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10763 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10764 (SXHASH_REDUCE): New macro.
10765 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10766 Use it instead of discarding useful hash info with large hash values.
10767 (sxhash_float): New function.
10768 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10769 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10770 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10771 Rewrite to use FIXNUM_BITS, as this simplifies things.
10772 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10773 Adjust signatures to match updated version of code.
10774 (consing_since_gc): Now EMACS_INT, since a single hash table can
10775 use more than INT_MAX bytes.
10777 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10779 Make it possible to build with GCC-4.6+ -O2 -flto.
10781 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10783 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10785 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10786 Call minibuffer-inactive-mode.
10788 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10790 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10791 Update dependencies.
10793 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10795 * data.c (init_data): Remove code for UTS, this system is not
10798 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10800 Don't force ./temacs to start in terminal mode.
10802 * frame.c (make_initial_frame): Initialize faces in all cases, not
10803 only when CANNOT_DUMP is defined.
10804 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10806 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10808 * dispnew.c (add_window_display_history): Use const for the string
10809 pointer. Remove declaration, not needed.
10811 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10813 Use 'inline', not 'INLINE'.
10814 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10815 * alloc.c, fontset.c (INLINE): Remove.
10816 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10817 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10818 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10819 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10820 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10822 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10824 Make it possible to run ./temacs.
10826 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10827 syms_of_callproc does the same thing. Remove test for
10828 "initialized", do it in the caller.
10829 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10831 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10833 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10834 (read_minibuf): Use get_minibuffer.
10835 (syms_of_minibuf): Use DEFSYM.
10836 (Qmetadata): New var.
10837 * data.c (Qbuffer): Don't make it static.
10838 (syms_of_data): Use DEFSYM.
10840 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10842 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10843 (CCL_CODE_MIN): New macro.
10845 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10847 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10849 * eval.c (Qdebug): Now static.
10850 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10851 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10852 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10854 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10856 * image.c: Various fixes to ImageMagick code comments.
10857 (Fimagemagick_types): Doc fix.
10859 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10861 Minor fixes prompted by GCC 4.6.0 warnings.
10863 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10865 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10866 (x_clipboard_manager_save_all): Move extern decl to ...
10867 * xterm.h: ... here, so that it can be checked for consistency.
10869 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10871 * xselect.c (x_clipboard_manager_save_frame)
10872 (x_clipboard_manager_save_all): New functions.
10873 (Fx_clipboard_manager_save): Lisp function deleted.
10875 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10876 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10878 * xterm.h: Update prototype.
10880 2011-05-28 William Xu <william.xwl@gmail.com>
10882 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10883 exiting (Bug#8239).
10885 2011-05-28 Jim Meyering <meyering@redhat.com>
10887 Avoid a sign-extension bug in crypto_hash_function.
10888 * fns.c (to_uchar): Define.
10889 (crypto_hash_function): Use it to convert some newly-signed
10890 variables to unsigned, to avoid sign-extension bugs. For example,
10891 without this change, (md5 "truc") would evaluate to
10892 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10893 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10894 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10896 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10898 Integer overflow fixes.
10900 * dbusbind.c: Serial number integer overflow fixes.
10901 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10902 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10903 to hold a serial number that is too large for a fixnum.
10904 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10905 Check for serial numbers out of range. Decode any serial number
10906 that was so large that it became a float. (Bug#8722)
10908 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10909 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10910 Use XFASTINT rather than XUINT when numbers are nonnegative.
10911 (xd_append_arg, Fdbus_method_return_internal):
10912 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10913 arguments, check that Lisp number is nonnegative, rather than
10914 silently wrapping negative numbers around. (Bug#8722)
10915 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10918 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10920 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10922 ccl: Add integer overflow checks.
10923 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10924 (IN_INT_RANGE): New macros.
10925 (ccl_driver): Use them to check for integer overflow when
10926 decoding a CCL program. Many of the new checks are whether XINT (x)
10927 fits in int; it doesn't always, on 64-bit hosts. The new version
10928 doesn't catch all possible integer overflows, but it's an
10929 improvement. (Bug#8719)
10931 * alloc.c (make_event_array): Use XINT, not XUINT.
10932 There's no need for unsigned here.
10934 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10935 This follows up to the 2011-05-06 change that substituted uintptr_t
10936 for EMACS_INT. This case wasn't caught back then.
10938 Rework Fformat to avoid integer overflow issues.
10939 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10940 now (part of C89). Include <verify.h>.
10941 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10942 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10943 (Fformat): Avoid the prepass trying to compute sizes; it was only
10944 approximate and thus did not catch overflow reliably. Instead, walk
10945 through the format just once, formatting and computing sizes as we go,
10946 checking for integer overflow at every step, and allocating a larger
10947 buffer as needed. Keep track separately whether the format is
10948 multibyte. Keep only the most-recently calculated precision, rather
10949 than them all. Record whether each argument has been converted to
10950 string. Use EMACS_INT, not int, for byte and char and arg counts.
10951 Support field widths and precisions larger than INT_MAX. Avoid
10952 sprintf's undefined behavior with conversion specifications such as %#d
10953 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10954 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10955 formatting out-of-range floating point numbers with int
10956 formats. (Bug#8668)
10958 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10960 * data.c: Avoid integer truncation in expressions involving floats.
10961 * data.c: Include <intprops.h>.
10962 (arith_driver): When there's an integer overflow in an expression
10963 involving floating point, convert the integers to floating point
10964 so that the resulting value does not suffer from catastrophic
10965 integer truncation. For example, on a 64-bit host (* 4
10966 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10967 Do not rely on undefined behavior after integer overflow.
10969 merge count_size_as_multibyte, parse_str_to_multibyte
10970 * character.c, character.h (count_size_as_multibyte):
10971 Rename from parse_str_to_multibyte; all uses changed.
10972 Check for integer overflow.
10973 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10974 since it's now a duplicate of the other. This is more of
10975 a character than a buffer op, so better that it's in character.c.
10976 * fns.c, print.c: Adjust to above changes.
10978 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10980 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10982 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10984 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10985 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10986 (x_clipboard_manager_save): Now static.
10987 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10989 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10990 (crypto_hash_function): Now static.
10991 Fix pointer signedness problems. Avoid unnecessary initializations.
10993 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10995 * termhooks.h (Vselection_alist): Make it terminal-local.
10997 * terminal.c (create_terminal): Initialize it.
10999 * xselect.c: Support for clipboard managers.
11000 (Vselection_alist): Move to termhooks.h as terminal-local var.
11001 (LOCAL_SELECTION): New macro.
11002 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11003 (symbol_to_x_atom): Remove gratuitous arg.
11004 (x_handle_selection_request, lisp_data_to_selection_data)
11005 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11006 (x_own_selection, x_get_local_selection, x_convert_selection):
11007 New arg, specifying work frame. Use terminal-local Vselection_alist.
11008 (some_frame_on_display): Delete unused function.
11009 (Fx_own_selection_internal, Fx_get_selection_internal)
11010 (Fx_disown_selection_internal, Fx_selection_owner_p)
11011 (Fx_selection_exists_p): New optional frame arg.
11012 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11013 (x_handle_selection_clear): Don't treat other terminals with the
11014 same keyboard specially. Use the terminal-local Vselection_alist.
11015 (x_clear_frame_selections): Use Frun_hook_with_args.
11017 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11019 * xterm.h: Add support for those atoms.
11021 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11023 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11024 (converted_selections, conversion_fail_tag): New global variables.
11025 (x_selection_request_lisp_error): Free the above.
11026 (x_get_local_selection): Remove unnecessary code.
11027 (x_reply_selection_request): Args changed; handle arbitrary array
11028 of converted selections stored in converted_selections.
11029 Separate the XChangeProperty and SelectionNotify steps.
11030 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11031 (x_convert_selection): New function.
11032 (x_handle_selection_event): Simplify.
11033 (x_get_foreign_selection): Don't ignore incoming requests while
11034 waiting for an answer; this will fail when we implement
11035 SAVE_TARGETS, and seems unnecessary anyway.
11036 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11037 (Vx_sent_selection_functions): Doc fix.
11039 2011-05-26 Leo Liu <sdl.web@gmail.com>
11041 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11043 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11045 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11047 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11048 for fringe update if it has periodic bitmap.
11049 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11050 and fringe_bitmap_periodic_p.
11052 * fringe.c (get_fringe_bitmap_data): New function.
11053 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11054 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11055 row. Mark glyph row for fringe update if periodicity changed.
11057 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11058 for fringe update unless it has periodic bitmap.
11060 2011-05-25 Kenichi Handa <handa@m17n.org>
11062 * xdisp.c (get_next_display_element): Set correct it->face_id for
11063 a static composition.
11065 2011-05-24 Leo Liu <sdl.web@gmail.com>
11068 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11070 * fns.c (crypto_hash_function, Fsha1): New function.
11071 (Fmd5): Use crypto_hash_function.
11072 (syms_of_fns): Add Ssha1.
11074 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11076 * gnutls.c: Remove unused macros.
11077 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11078 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11079 Remove macros that are defined and never used.
11080 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11082 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11084 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11085 (Fx_get_selection_internal): Minor cleanup.
11086 (Fx_own_selection_internal): Rename arguments for consistency with
11089 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11091 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11093 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11095 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11097 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11099 * dispnew.c (scrolling_window): Don't exclude the case that the
11100 last enabled row in the desired matrix touches the bottom boundary.
11102 2011-05-21 Glenn Morris <rgm@gnu.org>
11104 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11105 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11106 and add some more files.
11108 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11110 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11111 report_file_error introduced by the change from 2011-05-07.
11113 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11115 * systime.h (Time): Define only if emacs is defined.
11116 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11117 where the include path doesn't have X11/X.h by default. See
11118 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11120 2011-05-20 Kenichi Handa <handa@m17n.org>
11122 * composite.c (find_automatic_composition): Fix previous change.
11124 2011-05-20 Glenn Morris <rgm@gnu.org>
11126 * lisp.mk: New file, split from Makefile.in.
11127 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11128 (shortlisp): Remove.
11129 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11131 2011-05-19 Glenn Morris <rgm@gnu.org>
11133 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11134 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11135 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11136 (lisp): Set the order to that of loadup.el.
11137 (shortlisp): Make it a copy of $lisp.
11138 (SOME_MACHINE_LISP): Remove.
11139 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11140 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11142 2011-05-18 Kenichi Handa <handa@m17n.org>
11144 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11145 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11146 (find_automatic_composition): Mostly rewrite for efficiency.
11148 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11150 * makefile.w32-in: Update dependencies.
11152 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11154 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11155 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11157 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11159 Fix some integer overflow issues, such as string length overflow.
11161 * insdel.c (count_size_as_multibyte): Check for string overflow.
11163 * character.c (lisp_string_width): Check for string overflow.
11164 Use EMACS_INT, not int, for string indexes and lengths; in
11165 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11166 the resulting string length overflows an EMACS_INT; instead,
11167 report a string overflow if no precision given. When checking for
11168 precision exhaustion, use a check that cannot possibly have
11169 integer overflow. (Bug#8675)
11170 * character.h (lisp_string_width): Adjust to new signature.
11172 * alloc.c (string_overflow): New function.
11173 (Fmake_string): Use it. This doesn't change behavior, but saves
11174 a few bytes and will simplify future changes.
11175 * character.c (string_escape_byte8): Likewise.
11176 * lisp.h (string_overflow): New decl.
11178 Fixups, following up to the user-interface timestamp change.
11179 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11180 for UI timestamps, instead of unsigned long.
11181 * msdos.c (mouse_get_pos): Likewise.
11182 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11183 * w32gui.h (Time): Define by including "systime.h" rather than by
11184 declaring it ourselves. (Bug#8664)
11186 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11187 * image.c (clear_image_cache): Likewise.
11189 * term.c (term_mouse_position): Don't assume time_t wraparound.
11191 Be more systematic about user-interface timestamps.
11192 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11193 and sometimes 'EMACS_UINT', to represent these timestamps.
11194 This change causes it to use 'Time' uniformly, as that's what X uses.
11195 This makes the code easier to follow, and makes it easier to catch
11196 integer overflow bugs such as Bug#8664.
11197 * frame.c (Fmouse_position, Fmouse_pixel_position):
11198 Use Time, not unsigned long, for user-interface timestamps.
11199 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11200 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11201 * keyboard.h (last_event_timestamp): Likewise.
11202 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11203 * menu.h (xmenu_show): Likewise.
11204 * term.c (term_mouse_position): Likewise.
11205 * termhooks.h (struct input_event.timestamp): Likewise.
11206 (struct terminal.mouse_position_hook): Likewise.
11207 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11208 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11209 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11210 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11211 what it was before.
11212 * menu.h, termhooks.h: Include "systime.h", for Time.
11214 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11215 Don't assume that the difference between two unsigned long values
11216 can fit into an integer. At this point, we know button_down_time
11217 <= event->timestamp, so the difference must be nonnegative, so
11218 there's no need to cast the result if double-click-time is
11219 nonnegative, as it should be; check that it's nonnegative, just in
11220 case. This bug is triggered when events are more than 2**31 ms
11221 apart (about 25 days). (Bug#8664)
11223 * xselect.c (last_event_timestamp): Remove duplicate decl.
11224 (x_own_selection): Remove needless cast to unsigned long.
11226 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11227 that always fit in int. Use a sentinel instead of a counter, to
11228 avoid a temp and to allay GCC's concerns about possible int overflow.
11229 * frame.h (struct frame): Use int for menu_bar_items_used
11230 instead of EMACS_INT, since it always fits in int.
11232 * menu.c (grow_menu_items): Check for int overflow.
11234 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11236 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11237 Before, the code was not consistent. These values cannot exceed
11238 2**31 - 1 so there's no need to make them unsigned.
11239 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11240 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11241 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11243 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11245 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11246 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11247 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11248 presumably because the widths might not match.
11250 * window.c (size_window): Avoid needless test at loop start.
11252 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11254 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11256 2011-05-12 Drew Adams <drew.adams@oracle.com>
11258 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11260 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11262 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11263 `width' to `bar_area_x' and `bar_area_width', respectively.
11264 (x_scroll_run): Take account of fringe background extension.
11266 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11267 Rename local vars `left' and `width' to `bar_area_x' and
11268 `bar_area_width', respectively.
11269 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11270 background extension.
11272 2011-05-10 Jim Meyering <meyering@redhat.com>
11274 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11276 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11278 * image.c (Finit_image_library): Return t for built-in image types,
11279 like pbm and xbm. (Bug#8640)
11281 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11283 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11285 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11287 * w32console.c (Fset_screen_color): Doc fix.
11288 (Fget_screen_color): New function.
11289 (syms_of_ntterm): Defsubr it.
11291 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11292 unlink the temporary file if Fcall_process didn't create it in the
11294 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11295 child process will be redirected to a file specified with `:file'.
11296 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11297 cue to call_process_cleanup not to close that handle.
11299 2011-05-07 Ben Key <bkey76@gmail.com>
11301 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11302 one of two shell specific rules, either bootstrap-temacs-CMD or
11303 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11304 to the previous implementation of the bootstrap-temacs rule.
11305 The bootstrap-temacs-CMD rule is similar to the previous
11306 implementation of the bootstrap-temacs rule except that it
11307 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11310 These changes, along with some changes to nt/configure.bat,
11311 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11312 earlier fix to add support for --cflags and --ldflags options
11313 that include quotes so that it works whether make uses cmd or
11316 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11318 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11319 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11321 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11322 a string. Handle both cases.
11323 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11324 (Fdbus_register_method): Use Qinvalid_function.
11326 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11328 * makefile.w32-in: Update dependencies.
11329 (LISP_H): Add inttypes.h and stdin.h.
11330 (PROCESS_H): Add unistd.h.
11332 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11334 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11335 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11337 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11339 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11341 * term.c (vfatal): Remove stray call to va_end.
11342 It's not needed and the C Standard doesn't allow it here anyway.
11344 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11345 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11347 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11350 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11352 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11354 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11356 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11358 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11360 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11361 * charset.c (Fdefine_charset_internal): Don't initialize
11362 charset.code_space[15]. The value was garbage, on hosts with
11363 32-bit int (Bug#8600).
11365 * lread.c (read_integer): Be more consistent with string-to-number.
11366 Use string_to_number to do the actual conversion; this avoids
11367 rounding errors and fixes some other screwups. Without this fix,
11368 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11369 (digit_to_number): Move earlier, for benefit of read_integer.
11370 Return -1 if the digit is out of range for the base, -2 if it is
11371 not a digit in any supported base. (Bug#8602)
11373 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11375 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11376 to match comment at start of function. This also removes a
11377 GCC warning about overflow in a 32+64-bit port.
11379 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11381 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11382 Reported by Stefan Monnier in
11383 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11384 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11385 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11387 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11388 (EMACS_UINTPTR): Likewise, with uintptr_t.
11390 * lisp.h: Prefer 64-bit EMACS_INT if available.
11391 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11392 on 32-bit hosts that have 64-bit int, so that they can access
11394 However, temporarily disable this change unless the temporary
11395 symbol WIDE_EMACS_INT is defined.
11397 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11399 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11400 This removes an assumption that EMACS_INT and long are the same
11401 width as pointers. The assumption is true for Emacs porting targets
11402 now, but we want to make other targets possible.
11403 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11404 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11405 In the rest of the code, change types of integers that hold casted
11406 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11407 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11408 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11409 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11410 No need to cast type when ORing.
11411 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11412 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11413 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11414 assume EMACS_INT is the same width as char *.
11415 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11416 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11417 Remove no-longer-needed casts.
11418 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11419 (xg_tool_bar_help_callback, xg_make_tool_item):
11420 Use EMACS_INTPTR to hold an integer
11421 that will be cast to void *; this can avoid a GCC warning
11422 if EMACS_INT is not the same width as void *.
11423 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11424 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11425 (current_message_1, set_message_1):
11426 Use a local to convert to proper width without a cast.
11427 * xmenu.c (dialog_selection_callback): Likewise.
11429 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11430 Also, don't assume VALBITS / RAND_BITS is less than 5,
11431 and don't rely on undefined behavior when shifting a 1 left into
11433 * lisp.h (get_random): Change signature to match.
11435 * lread.c (hash_string): Use size_t, not int, for hash computation.
11436 Normally we prefer signed values; but hashing is special, because
11437 it's better to use unsigned division on hash table sizes so that
11438 the remainder is nonnegative. Also, size_t is the natural width
11439 for hashing into memory. The previous code used 'int', which doesn't
11440 retain enough info to hash well into very large tables.
11441 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11443 * dbusbind.c: Don't possibly lose pointer info when converting.
11444 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11445 Use XPNTR rather than XHASH, so that the high-order bits of
11446 the pointer aren't lost when converting through void *.
11448 * eval.c (Fautoload): Don't double-shift a pointer.
11450 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11452 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11454 * gnutls.c (DEF_GNUTLS_FN):
11455 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11457 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11459 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11462 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11464 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11465 New version that can reserve upto 2GB of heap space.
11467 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11469 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11471 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11473 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11474 `gnutls_certificate_set_x509_key_file'.
11476 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11478 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11479 Update dependencies.
11481 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11483 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11484 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11485 Remove unused parameter `fildes'.
11486 * process.c (read_process_output, send_process): Don't pass it.
11488 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11490 Fix previous change: the library cache is defined in w32.c.
11491 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11492 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11494 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11496 Implement dynamic loading of GnuTLS on Windows.
11498 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11499 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11500 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11503 * gnutls.c (Qgnutls_dll): Define.
11504 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11505 (gnutls_*): Declare function pointers.
11506 (init_gnutls_functions): New function to initialize function pointers.
11507 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11508 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11509 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11510 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11511 (emacs_gnutls_write, emacs_gnutls_read)
11512 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11513 (Fgnutls_available_p): New function.
11514 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11515 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11516 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11518 * image.c: Include w32.h.
11519 (Vimage_type_cache): Delete.
11520 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11521 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11522 (w32_delayed_load): Move to w32.c.
11524 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11526 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11527 (w32_delayed_load): Move from image.c. When loading a library, record
11528 its filename in the :loaded-from property of the library id.
11529 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11530 Initialize and staticpro them.
11531 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11533 * process.c: Include lisp.h before w32.h, not after.
11534 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11535 instead of gnutls_record_check_pending.
11537 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11539 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11541 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11542 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11545 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11547 * xterm.c (x_set_frame_alpha): Do not set property on anything
11548 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11550 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11552 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11554 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11556 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11557 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11558 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11559 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11560 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11561 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11562 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11563 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11564 (Qgnutls_bootprop_callbacks_verify): Make static.
11566 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11568 * callproc.c: Indentation fixup.
11570 * sysdep.c (wait_for_termination_1): Make static.
11571 (wait_for_termination, interruptible_wait_for_termination):
11572 Move after wait_for_termination_1.
11574 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11576 * sysdep.c (interruptible_wait_for_termination): New function
11577 which is like wait_for_termination, but allows keyboard
11580 * callproc.c (Fcall_process): Add (:file "file") as an option for
11582 (Fcall_process_region): Ditto.
11584 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11586 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11587 rather than `XVECTOR (FOO)->size'.
11589 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11590 inttypes.h, as a gnulib replacement is used if it not available in
11593 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11595 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11596 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11597 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11599 * coding.c (coding_alloc_by_realloc): Error out if destination
11600 will grow beyond MOST_POSITIVE_FIXNUM.
11601 (decode_coding_emacs_mule): Abort if there isn't enough place in
11602 charbuf for the composition carryover bytes. Reserve an extra
11603 space for up to 2 characters produced in a loop.
11604 (decode_coding_iso_2022): Abort if there isn't enough place in
11605 charbuf for the composition carryover bytes.
11607 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11609 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11610 aborting when %lld or %lll format is passed.
11611 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11612 %llo or %llx format is passed. (Bug#8545)
11614 * window.c (window_scroll_line_based): Use a marker instead of
11615 simple variables to record original value of point. (Bug#7952)
11617 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11618 produced by %s or %c overflows available buffer space. (Bug#8545)
11620 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11622 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11623 (SIZE_MAX): Move defn after all includes, as they might #define it.
11625 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11627 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11629 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11631 * keyboard.c (Qdelayed_warnings_hook): Define.
11632 (command_loop_1): Run `delayed-warnings-hook'
11633 if Vdelayed_warnings_list is non-nil.
11634 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11635 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11637 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11639 * doprnt.c (doprnt): Don't return value smaller than the buffer
11640 size if the message was truncated. (Bug#8545).
11642 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11644 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11645 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11647 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11649 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11651 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11653 * makefile.w32-in: Update dependencies.
11655 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11657 Improve `doprnt' and its usage. (Bug#8545)
11658 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11659 `format_end'. Remove support for %l as a conversion specifier.
11660 Don't use xrealloc. Improve diagnostics when the %l size modifier
11661 is used. Update the commentary.
11663 * eval.c (verror): Simplify calculation of size_t.
11665 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11668 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11670 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11673 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11675 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11676 This makes this file independent of the recent pseudovector change.
11678 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11680 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11682 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11683 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11684 Remove unused local.
11685 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11687 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11688 GCC 4.6.0 optimizes based on type-based alias analysis.
11689 For example, if b is of type struct buffer * and v of type struct
11690 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11691 != &v->size, and therefore "v->size = 1; b->size = 2; return
11692 v->size;" must therefore return 1. This assumption is incorrect
11693 for Emacs, since it type-puns struct Lisp_Vector * with many other
11694 types. To fix this problem, this patch adds a new type struct
11695 vectorlike_header that documents the constraints on layout of vectors
11696 and pseudovectors, and helps optimizing compilers not get fooled
11697 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11698 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11699 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11701 (XSETPVECTYPE): Rewrite in terms of new macro.
11702 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11703 This is a bit clearer, and further avoids the possibility of
11704 undesirable aliasing.
11705 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11706 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11707 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11708 since Lisp_Subr is a special case (no "next" field).
11709 (ASIZE): Now uses header.size rather than size.
11710 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11711 to avoid the hassle of writing XVECTOR (foo)->header.size.
11712 (struct vectorlike_header): New type.
11713 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11714 object, to help avoid aliasing.
11715 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11716 (SUBRP): Likewise, since Lisp_Subr is a special case.
11717 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11718 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11719 (struct Lisp_Hash_Table): Combine first two members into a single
11720 struct vectorlike_header member. All uses of "size" and "next" members
11721 changed to be "header.size" and "header.next".
11722 * buffer.h (struct buffer): Likewise.
11723 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11724 * frame.h (struct frame): Likewise.
11725 * process.h (struct Lisp_Process): Likewise.
11726 * termhooks.h (struct terminal): Likewise.
11727 * window.c (struct save_window_data, struct saved_window): Likewise.
11728 * window.h (struct window): Likewise.
11729 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11730 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11731 * buffer.c (init_buffer_once): Likewise.
11732 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11734 * process.c (Fformat_network_address): Use local var for size,
11737 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11739 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11740 * data.c (atof): Remove decl; no longer used or needed.
11741 (digit_to_number): Move to lread.c.
11742 (Fstring_to_number): Use new string_to_number function, to be
11743 consistent with how the Lisp reader treats infinities and NaNs.
11744 Do not assume that floating-point numbers represent EMACS_INT
11745 without losing information; this is not true on most 64-bit hosts.
11746 Avoid double-rounding errors, by insisting on integers when
11747 parsing non-base-10 numbers, as the documentation specifies.
11748 * lisp.h (string_to_number): New decl, replacing ...
11749 (isfloat_string): Remove.
11750 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11751 (read1): Do not accept +. and -. as integers; this
11752 appears to have been a coding error. Similarly, do not accept
11753 strings like +-1e0 as floating point numbers. Do not report
11754 overflow for integer overflows unless the base is not 10 which
11755 means we have no simple and reliable way to continue.
11756 Break out the floating-point parsing into a new
11757 function string_to_number, so that Fstring_to_number parses
11758 floating point numbers consistently with the Lisp reader.
11759 (digit_to_number): Move here from data.c. Make it static inline.
11760 (E_CHAR, EXP_INT): Remove, replacing with ...
11761 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11762 (string_to_number): New function, replacing isfloat_string.
11763 This function checks for valid syntax and produces the resulting
11764 Lisp float number too. Rework it so that string-to-number
11765 no longer mishandles examples like "1.0e+". Use strtoumax,
11766 so that overflow for non-base-10 numbers is reported only when
11767 there's no portable and simple way to convert to floating point.
11769 * textprop.c (set_text_properties_1): Rewrite for clarity,
11770 and to avoid GCC warning about integer overflow.
11772 * intervals.h (struct interval): Use EMACS_INT for members
11773 where EMACS_UINT might cause problems. See
11774 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11775 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11776 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11778 (offset_intervals): Tell GCC not to worry about length overflow
11779 when negating a negative length.
11781 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11782 (overrun_check_free): Likewise.
11784 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11785 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11788 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11789 (gnutls_make_error): Rename local to avoid shadowing.
11790 (gnutls_emacs_global_deinit): ifdef out; not used.
11791 (Fgnutls_boot): Use const for pointer to readonly storage.
11792 Comment out unused local. Fix pointer signedness problems.
11794 * lread.c (openp): Don't stuff size_t into an 'int'.
11795 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11796 about possible signed overflow.
11798 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11799 (GDK_KEY_g): Don't define if already defined.
11800 (xg_prepare_tooltip): Avoid pointer signedness problem.
11801 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11803 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11804 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11806 * xfns.c (Fx_window_property): Simplify a bit,
11807 to make a bit faster and to avoid GCC 4.6.0 warning.
11808 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11810 * fns.c (internal_equal): Don't assume size_t fits in int.
11812 * alloc.c (compact_small_strings): Tighten assertion a little.
11814 Replace pEd with more-general pI, and fix some printf arg casts.
11815 * lisp.h (pI): New macro, generalizing old pEd macro to other
11816 conversion specifiers. For example, use "...%"pI"d..." rather
11817 than "...%"pEd"...".
11818 (pEd): Remove. All uses replaced with similar uses of pI.
11819 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11820 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11821 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11822 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11823 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11824 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11825 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11827 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11828 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11829 * print.c (safe_debug_print, print_object): Likewise.
11830 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11832 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11833 avoiding the 0 flag, which is not portable.
11834 * process.c (Fmake_network_process): Use pI to avoid cast.
11835 * region-cache.c (pp_cache): Likewise.
11836 * xdisp.c (decode_mode_spec): Likewise.
11837 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11838 behavior on 64-bit hosts with printf arg.
11839 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11840 (x_stop_queuing_selection_requests): Likewise.
11841 (x_get_window_property): Don't truncate byte count to an 'int'
11844 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11845 here, since it parses constructs like leading '-' and spaces,
11846 which are not wanted; and it overflows with large numbers.
11847 Instead, simply match F[0-9]+, which is what is wanted anyway.
11849 * alloc.c: Remove unportable assumptions about struct layout.
11850 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11851 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11852 (allocate_vectorlike, make_pure_vector): Use the new macros,
11853 plus offsetof, to remove unportable assumptions about struct layout.
11854 These assumptions hold on all porting targets that I know of, but
11855 they are not guaranteed, they're easy to remove, and removing them
11856 makes further changes easier.
11858 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11859 This doesn't fix a bug but makes the code clearer.
11860 (string_overrun_cookie): Now const. Use initializers that
11861 don't formally overflow signed char, to avoid warnings.
11862 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11863 can cause Emacs to crash when string overrun checking is enabled.
11864 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11865 multiple of sizeof (EMACS_INT); it need not be, if
11866 alignof(EMACS_INT) < sizeof (EMACS_INT).
11867 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11869 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11871 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11873 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11875 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11876 supposed to be handshaking. (Bug#8556)
11877 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11879 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11881 * lisp.h (Qdebug): List symbol.
11882 * eval.c (Qdebug): Restore global linkage.
11883 * keyboard.c (debug-on-event): New variable.
11884 (handle_user_signal): Break into debugger when debug-on-event
11885 matches the current signal symbol.
11887 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11889 * alloc.c (check_sblock, check_string_bytes)
11890 (check_string_free_list): Convert to standard C.
11892 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11894 * w32.c (emacs_gnutls_push): Fix typo.
11896 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11898 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11899 "cast to pointer from integer of different size".
11901 Improve doprnt and its use in verror. (Bug#8545)
11902 * doprnt.c (doprnt): Document the set of format control sequences
11903 supported by the function. Use SAFE_ALLOCA instead of always
11906 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11907 is one byte too soon. Don't use xrealloc; instead xfree and
11910 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11912 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11915 * gnutls.c: Renamed global_initialized to
11916 gnutls_global_initialized. Added internals for the
11917 :verify-hostname-error, :verify-error, and :verify-flags
11918 parameters of `gnutls-boot' and documented those parameters in the
11919 docstring. Start callback support.
11920 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11921 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11922 on error. Return error code.
11923 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11924 (emacs_gnutls_read): Likewise.
11925 (Fgnutls_boot): Return handshake error code.
11926 (emacs_gnutls_handle_error): New function.
11927 (wsaerror_to_errno): Likewise.
11929 * w32.h (emacs_gnutls_pull): Add prototype.
11930 (emacs_gnutls_push): Likewise.
11932 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11933 (emacs_gnutls_push): Likewise.
11935 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11937 * process.c (wait_reading_process_output): Check if GnuTLS
11938 buffered some data internally if no FDs are set for TLS
11941 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11942 (LIBS): Link to USER_LIBS.
11943 ($(BLD)/gnutls.$(0)): New target.
11945 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11947 * xdisp.c (handle_single_display_spec): Rename the
11948 display_replaced_before_p argument into display_replaced_p, to
11949 make it consistent with the commentary. Fix typos in the
11952 * textprop.c (syms_of_textprop): Remove dead code.
11953 (copy_text_properties): Delete obsolete commentary about an
11954 interface that was deleted long ago. Fix typos in the description
11957 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11958 to changes in oldXMenu/XMenu.h from 2011-04-16.
11959 <menu_help_message, prev_menu_help_message>: Constify.
11960 (IT_menu_make_room): menu->help_text is now `const char **';
11963 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11964 to changes in oldXMenu/XMenu.h from 2011-04-16.
11965 (struct XMenu): Declare `help_text' `const char **'.
11967 * xfaces.c <Qunspecified>: Make extern again.
11969 * syntax.c: Include sys/types.h before including regex.h, as
11972 * doc.c (get_doc_string): Improve the format passed to `error'.
11974 * doprnt.c (doprnt): Improve commentary.
11976 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11978 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11981 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11982 changes in globals.h immediately force recompilation.
11983 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11984 $(CURDIR)/s/ms-w32.h.
11985 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11987 * character.c (Fchar_direction): Function deleted.
11988 (syms_of_character): Don't defsubr it.
11989 <char-direction-table>: Deleted.
11991 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11993 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11994 * doprnt.c: Include limits.h.
11995 (SIZE_MAX): New macro.
11996 (doprnt): Return a size_t value. 2nd arg is now size_t.
11997 Many local variables are now size_t instead of int or unsigned.
11998 Improve overflow protection. Support `l' modifier for integer
11999 conversions. Support %l conversion. Don't assume an EMACS_INT
12000 argument for integer conversions and for %c.
12002 * lisp.h (doprnt): Restore prototype.
12004 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12005 $(SRC)/character.h.
12007 * Makefile.in (base_obj): Add back doprnt.o.
12009 * deps.mk (doprnt.o): Add back prerequisites.
12010 (callint.o): Depend on character.h.
12012 * eval.c (internal_lisp_condition_case): Include the handler
12013 representation in the error message.
12014 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12015 when breaking from the loop.
12017 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12019 * callint.c (Fcall_interactively): When displaying error message
12020 about invalid control letter, pass the character's codepoint, not
12021 a pointer to its multibyte form. Improve display of the character
12022 in octal and display also its hex code.
12024 * character.c (char_string): Use %x to display the (unsigned)
12025 codepoint of an invalid character, to avoid displaying a bogus
12028 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12029 `error', not SYMBOL_NAME itself.
12031 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12032 character arguments to `error'.
12034 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12035 to `error' in error message about FINAL_CHAR argument. Make sure
12036 FINAL_CHAR is a character, and use %c when it is passed as
12037 argument to `error'.
12039 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12041 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12043 * w32.c: Include <time.h>.
12044 (sys_localtime): New function.
12046 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12048 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12050 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12052 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12054 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12055 zombies (Bug#8467).
12057 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12059 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12060 gl_state.e_property when gl_state.object is Qt.
12062 * insdel.c (make_gap_larger): Remove limitation of buffer size
12065 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12067 * xdisp.c (lookup_glyphless_char_display)
12068 (produce_glyphless_glyph): Handle cons cell entry in
12069 glyphless-char-display.
12070 (Vglyphless_char_display): Document it.
12072 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12073 glyphless-char-display.
12075 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12077 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12079 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12081 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12082 definition for no-X builds.
12084 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12086 Static checks with GCC 4.6.0 and non-default toolkits.
12088 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12090 * process.c (keyboard_bit_set): Define only if SIGIO.
12091 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12092 (send_process): Repair possible setjmp clobbering.
12094 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12096 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12098 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12100 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12101 Define only if needed.
12103 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12104 by pacifying GCC about it. Maybe it's time to retire it?
12105 * xfaces.c (USG, __TIMEVAL__): Likewise.
12107 * dispextern.h (struct redisplay_interface): Rename param
12108 to avoid shadowing.
12109 * termhooks.h (struct terminal): Likewise.
12110 * xterm.c (xembed_send_message): Likewise.
12112 * insdel.c (make_gap_smaller): Define only if
12113 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12115 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12118 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12119 so that we aren't warned about unused symbols.
12121 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12123 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12125 * xfns.c (x_real_positions): Mark locals as initialized.
12127 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12129 * xterm.c: Fix problems found by static analysis with other toolkits.
12130 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12131 (x_dispatch_event): Declare static if USE_GTK, and
12132 define if USE_GTK || USE_X_TOOLKIT.
12133 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12134 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12135 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12136 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12138 * xmenu.c (menu_help_callback): Pointer type fixes.
12139 Use const pointers when pointing at readonly data. Avoid pointer
12140 signedness clashes.
12141 (FALSE): Remove unused macro.
12142 (update_frame_menubar): Remove unused decl.
12144 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12146 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12147 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12148 (single_menu_item): Rename local to avoid shadowing.
12150 * keyboard.c (make_lispy_event): Remove unused local var.
12152 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12153 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12155 * bitmaps: Change bitmaps from unsigned char back to the X11
12156 compatible char. Avoid the old compiler warnings about
12157 out-of-range initializers by using, for example, '\xab' rather
12160 * xgselect.c (xgselect_initialize): Check vs interface
12161 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12163 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12165 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12166 to read-only memory.
12168 * fns.c (vector): Remove; this old hack is no longer needed.
12170 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12172 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12174 * xrdb.c (x_load_resources): Omit unused local.
12176 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12177 (x_window): Rename locals to avoid shadowing.
12178 (USG): Use the kludged USG macro, to pacify gcc.
12180 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12181 (x_term_init): Remove local to avoid shadowing.
12183 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12185 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12186 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12188 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12190 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12192 Fix regex.c, syntax.c and friends for buffers > 2GB.
12193 * syntax.h (struct gl_state_s): Declare character position members
12196 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12198 * textprop.c (verify_interval_modification, interval_of):
12199 Declare arguments EMACS_INT.
12201 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12204 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12206 * indent.c (Fvertical_motion): Local variable it_start is now
12209 * regex.c (re_match, re_match_2, re_match_2_internal)
12210 (bcmp_translate, regcomp, regexec, print_double_string)
12211 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12212 (re_compile_pattern, re_exec): Declare arguments and local
12213 variables `size_t' and `ssize_t' and return values `regoff_t', as
12215 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12216 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12217 <compile_stack_type>: `size' and `avail' are now `size_t'.
12219 * regex.h <regoff_t>: Use ssize_t, not int.
12220 (re_search, re_search_2, re_match, re_match_2): Arguments that
12221 specify buffer/string position and length are now ssize_t and
12222 size_t. Return type is regoff_t.
12224 2011-04-16 Ben Key <bkey76@gmail.com>
12226 * nsfont.m: Fixed bugs in ns_get_family and
12227 ns_descriptor_to_entity that were caused by using free to
12228 deallocate memory blocks that were allocated by xmalloc (via
12229 xstrdup). This caused Emacs to crash when compiled with
12230 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12231 --enable-checking=xmallocoverrun). xfree is now used to
12232 deallocate these memory blocks.
12234 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12236 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12238 emacs_write: Accept and return EMACS_INT for sizes.
12239 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12241 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12242 Accept and return EMACS_INT.
12243 (emacs_gnutls_write): Return the number of bytes written on
12245 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12246 (emacs_read, emacs_write): Remove check for negative size, as the
12247 Emacs source code has been audited now.
12248 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12249 (emacs_read, emacs_write): Use it.
12250 * process.c (send_process): Adjust to the new signatures of
12251 emacs_write and emacs_gnutls_write. Do not attempt to store
12252 a byte offset into an 'int'; it might overflow.
12253 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12255 * sound.c: Don't assume sizes fit in 'int'.
12256 (struct sound_device.period_size, alsa_period_size):
12257 Return EMACS_INT, not int.
12258 (struct sound_device.write, vox_write, alsa_write):
12259 Accept EMACS_INT, not int.
12260 (wav_play, au_play): Use EMACS_INT to store sizes and to
12261 record read return values.
12263 2011-04-15 Ben Key <bkey76@gmail.com>
12265 * keyboard.c (Qundefined): Don't declare static since it is used
12267 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12268 static since they are used in nsfont.m.
12270 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12272 * process.c (Qprocessp): Don't declare static.
12273 * lisp.h (Qprocessp): Declare again.
12275 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12277 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12279 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12281 Improve C-level modularity by making more things 'static'.
12283 Don't publish debugger-only interfaces to other modules.
12284 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12285 (verify_bytepos, count_markers): Move decls to the only modules
12287 * region-cache.h (pp_cache): Likewise.
12288 * window.h (check_all_windows): Likewise.
12289 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12291 * sysdep.c (croak): Now static, if
12292 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12293 * syssignal.h (croak): Declare only if not static.
12295 * alloc.c (refill_memory_reserve): Now static if
12296 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12297 * lisp.h (refill_memory_reserve): Declare only if not static.
12299 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12300 Define only if USE_LUCID.
12302 * xrdb.c (x_customization_string, x_rm_string): Now static.
12304 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12305 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12307 * xdisp.c (draw_row_with_mouse_face): Now static.
12308 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12310 * window.h (check_all_windows): Mark externally visible.
12312 * window.c (window_deletion_count): Now static.
12314 * undo.c: Make symbols static if they're not exported.
12315 (last_undo_buffer, last_boundary_position, pending_boundary):
12318 * textprop.c (interval_insert_behind_hooks): Now static.
12319 (interval_insert_in_front_hooks): Likewise.
12321 * term.c: Make symbols static if they're not exported.
12322 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12323 (max_frame_lines, tty_set_terminal_modes):
12324 (tty_reset_terminal_modes, tty_turn_off_highlight):
12325 (get_tty_terminal): Now static.
12326 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12327 * termhooks.h (term_mouse_moveto): Do not declare if
12328 HAVE_WINDOW_SYSTEM.
12329 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12330 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12332 * sysdep.c: Make symbols static if they're not exported.
12333 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12335 (sigprocmask_set, full_mask): Remove; unused.
12336 (wait_debugging): Mark as visible.
12337 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12338 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12340 * syntax.c (syntax_temp): Define only if !__GNUC__.
12342 * sound.c (current_sound_device, current_sound): Now static.
12344 * search.c (searchbufs, searchbuf_head): Now static.
12346 * scroll.c (scroll_cost): Remove; unused.
12347 * dispextern.h (scroll_cost): Remove decl.
12349 * region-cache.h (pp_cache): Mark as externally visible.
12351 * process.c: Make symbols static if they're not exported.
12352 (process_tick, update_tick, create_process, chan_process):
12353 (Vprocess_alist, proc_buffered_char, datagram_access):
12354 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12355 (deactivate_process): Mark defn as static, as well as decl.
12356 * lisp.h (create_process): Remove decl.
12357 * process.h (chan_process, Vprocess_alist): Remove decls.
12359 * print.c: Make symbols static if they're not exported.
12360 (print_depth, new_backquote_output, being_printed, print_buffer):
12361 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12362 (print_interval, print_number_index, initial_stderr_stream):
12364 * lisp.h (Fprinc): Remove decl.
12365 (debug_output_compilation_hack): Mark as externally visible.
12367 * sysdep.c (croak): Move decl from here to syssignal.h.
12368 * syssignal.h (croak): Put it here, so the API can be checked when
12369 'croak' is called from dissociate_if_controlling_tty.
12371 * minibuf.c: Make symbols static if they're not exported.
12372 (minibuf_save_list, choose_minibuf_frame): Now static.
12373 * lisp.h (choose_minibuf_frame): Remove decl.
12375 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12377 * lread.c: Make symbols static if they're not exported.
12378 (read_objects, initial_obarray, oblookup_last_bucket_number):
12380 (make_symbol): Remove; unused.
12381 * lisp.h (initial_obarray, make_symbol): Remove decls.
12383 * keyboard.c: Make symbols static if they're not exported.
12384 (single_kboard, recent_keys_index, total_keys, recent_keys):
12385 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12386 (this_single_command_key_start, echoing, last_auto_save):
12387 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12388 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12389 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12390 (Vlispy_mouse_stem, double_click_count):
12392 (force_auto_save_soon): Define only if SIGDANGER.
12393 (ignore_mouse_drag_p): Now static if
12394 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12395 (print_help): Remove; unused.
12396 (stop_character, last_timer_event): Mark as externally visible.
12397 * keyboard.h (ignore_mouse_drag_p): Declare only if
12398 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12399 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12400 * lisp.h (echoing): Remove decl.
12401 (force_auto_save_soon): Declare only if SIGDANGER.
12402 * xdisp.c (redisplay_window): Simplify code, to make it more
12403 obvious that ignore_mouse_drag_p is not accessed if !defined
12404 USE_GTK && !defined HAVE_NS.
12406 * intervals.c: Make symbols static if they're not exported.
12407 (merge_properties_sticky, merge_interval_right, delete_interval):
12409 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12411 * insdel.c: Make symbols static if they're not exported.
12412 However, leave prepare_to_modify_buffer alone. It's never
12413 called from outside this function, but that appears to be a bug.
12414 (combine_after_change_list, combine_after_change_buffer):
12415 (adjust_after_replace, signal_before_change): Now static.
12416 (adjust_after_replace_noundo): Remove; unused.
12417 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12418 (signal_before_change): Remove decls.
12420 * indent.c (val_compute_motion, val_vmotion): Now static.
12422 * image.c: Make symbols static if they're not exported.
12423 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12425 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12426 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12428 * fringe.c (standard_bitmaps): Now static.
12429 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12431 * frame.c: Make symbols static if they're not exported.
12432 (x_report_frame_params, make_terminal_frame): Now static.
12433 (get_frame_param): Now static, unless HAVE_NS.
12434 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12435 (x_get_resource_string): Remove; not used.
12436 * frame.h (make_terminal_frame, x_report_frame_params):
12437 (x_get_resource_string); Remove decls.
12438 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12439 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12441 * font.c, fontset.c: Make symbols static if they're not exported.
12442 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12443 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12444 * font.c (font_close_object): Now static.
12445 * font.h (font_close_object): Remove.
12446 * fontset.c (FONTSET_OBJLIST): Remove.
12447 (free_realized_fontset) #if-0 the body, which does nothing.
12448 (face_suitable_for_char_p): #if-0, as it's never called.
12449 * fontset.h (face_suitable_for_char_p): Remove decl.
12450 * xfaces.c (face_at_string_position):
12451 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12452 since 0 is always ASCII.
12454 * fns.c (weak_hash_tables): Now static.
12456 * fileio.c: Make symbols static if they're not exported.
12457 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12458 (Vwrite_region_annotation_buffers): Now static.
12460 * eval.c: Make symbols static if they're not exported.
12461 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12462 * lisp.h (backtrace_list): Remove decl.
12464 * emacs.c: Make symbols static if they're not exported.
12465 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12466 (fatal_error_code, fatal_error_signal_hook, standard_args):
12468 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12469 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12470 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12471 * lisp.h (fatal_error_signal_hook): Remove decl.
12472 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12474 * editfns.c: Move a (normally-unused) function to its only use.
12475 * editfns.c, lisp.h (get_operating_system_release): Remove.
12476 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12477 worth the hassle of breaking this out.
12479 * xterm.c: Make symbols static if they're not exported.
12480 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12481 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12482 (x_destroy_window, x_delete_display):
12484 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12485 (x_mouse_leave): Remove; unused.
12486 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12487 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12488 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12490 (x_mouse_leave): Declare only if WINDOWSNT.
12491 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12492 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12495 * ftxfont.c: Make symbols static if they're not exported.
12496 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12498 * font.h (ftxfont_driver): Likewise.
12500 * xfns.c: Make symbols static if they're not exported.
12501 (x_last_font_name, x_display_info_for_name):
12502 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12503 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12504 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12505 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12506 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12507 (last_show_tip_args): Now static.
12508 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12509 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12510 (x_screen_planes): Remove; unused.
12511 * dispextern.h (x_screen_planes): Remove decl.
12513 * dispnew.c: Make symbols static if they're not exported.
12514 * dispextern.h (redraw_garbaged_frames, scrolling):
12515 (increment_row_positions): Remove.
12516 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12517 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12519 (redraw_garbaged_frames): Remove; unused.
12521 * xfaces.c: Make symbols static if they're not exported.
12522 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12524 * xterm.h (defined_color): Remove decls.
12525 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12526 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12527 (menu_face_changed_default, defined_color, free_realized_face):
12528 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12529 (ascii_face_of_lisp_face): Remove; unused.
12531 * xdisp.c: Make symbols static if they're not exported.
12532 * dispextern.h (scratch_glyph_row, window_box_edges):
12533 (glyph_to_pixel_coords, set_cursor_from_row):
12534 (get_next_display_element, set_iterator_to_next):
12535 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12536 (show_mouse_face): Remove decls
12537 * frame.h (message_buf_print): Likewise.
12538 * lisp.h (pop_message, set_message, check_point_in_composition):
12540 * xterm.h (set_vertical_scroll_bar): Likewise.
12541 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12542 (message_buf_print, scratch_glyph_row, displayed_buffer):
12543 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12544 (get_next_display_element, show_mouse_face, window_box_edges):
12545 (frame_to_window_pixel_xy, check_point_in_composition):
12546 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12547 (glyph_to_pixel_coords): Remove; unused.
12549 * dired.c (file_name_completion): Now static.
12551 * dbusbind.c (xd_in_read_queued_messages): Now static.
12553 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12554 * data.c (circular_list_error): Remove.
12556 * commands.h (last_point_position, last_point_position_buffer):
12557 (last_point_position_window): Remove decls.
12558 * keyboard.c: Make these variables static.
12560 * coding.h (coding, code_convert_region, encode_coding_gap):
12562 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12563 (iso_code_class, detect_coding, code_convert_region): Now static.
12564 (encode_coding_gap): Remove; unused.
12566 * chartab.c (chartab_chars, chartab_bits): Now static.
12568 * charset.h (charset_iso_8859_1): Remove decl.
12569 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12572 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12573 * ccl.c (Vccl_program_table): Now static.
12574 (check_ccl_update): Remove; unused.
12576 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12577 * category.h: ... from here.
12578 * category.c (check_category_table, set_category_set): Now static.
12580 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12581 * lisp.h: Remove these decls.
12583 * buffer.c (buffer_count): Remove unused var.
12585 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12586 so that it's not optimized away.
12587 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12588 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12589 exported only to the debugger.
12591 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12592 * atimer.h (run_all_atimers): Remove; not exported.
12594 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12595 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12596 was inaccessible from Lisp.
12597 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12598 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12600 alloc.c: Import and export fewer symbols, and remove unused items.
12601 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12603 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12604 it's not optimized away by whole-program optimization.
12605 (message_enable_multibyte, free_misc): Remove.
12606 (catchlist, handlerlist, mark_backtrace):
12607 Declare only if BYTE_MARK_STACK.
12608 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12609 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12610 (message_enable_multibyte): Remove decl.
12611 (free_misc, interval_free_list, float_block, float_block_index):
12612 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12613 (cons_free_list, last_marked_index):
12615 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12616 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12617 (mark_backtrace): Define only if BYTE_MARK_STACK.
12618 * xdisp.c (message_enable_multibyte): Now static.
12620 Declare Lisp_Object Q* variables to be 'static' if not exported.
12621 This makes it easier for human readers (and static analyzers)
12622 to see whether these variables are used from other modules.
12623 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12624 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12625 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12626 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12627 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12628 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12629 * xmenu.c, xselect.c:
12630 Declare Q* vars static if they are not used in other modules.
12631 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12632 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12633 Remove decls of unexported vars.
12634 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12636 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12638 Make Emacs functions such as Fatom 'static' by default.
12639 This makes it easier for human readers (and static analyzers)
12640 to see whether these functions can be called from other modules.
12641 DEFUN now defines a static function. To make the function external
12642 so that it can be used in other C modules, use the new macro DEFUE.
12643 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12644 (Finit_image_library):
12645 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12646 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12647 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12648 Remove decls, since these functions are now static.
12649 (Funintern, Fget_internal_run_time): New decls, since these functions
12650 were already external.
12652 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12653 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12654 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12655 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12656 * keyboard.c, keymap.c, lread.c:
12657 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12658 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12659 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12660 Mark functions with DEFUE instead of DEFUN,
12661 if they are used in other modules.
12662 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12663 decls for now-static functions.
12664 * buffer.h (Fdelete_overlay): Remove decl.
12665 * callproc.c (Fgetenv_internal): Mark as internal.
12666 * composite.c (Fremove_list_of_text_properties): Remove decl.
12667 (Fcomposition_get_gstring): New forward static decl.
12668 * composite.h (Fcomposite_get_gstring): Remove decl.
12669 * dired.c (Ffile_attributes): New forward static decl.
12670 * doc.c (Fdocumntation_property): New forward static decl.
12671 * eval.c (Ffetch_bytecode): New forward static decl.
12672 (Funintern): Remove extern decl; now in .h file where it belongs.
12673 * fileio.c (Fmake_symbolic_link): New forward static decl.
12674 * image.c (Finit_image_library): New forward static decl.
12675 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12676 * intervals.h (Fprevious_property_change):
12677 (Fremove_list_of_text_properties): Remove decls.
12678 * keyboard.c (Fthis_command_keys): Remove decl.
12679 (Fcommand_execute): New forward static decl.
12680 * keymap.c (Flookup_key): New forward static decl.
12681 (Fcopy_keymap): Now static.
12682 * keymap.h (Flookup_key): Remove decl.
12683 * process.c (Fget_process): New forward static decl.
12684 (Fprocess_datagram_address): Mark as internal.
12685 * syntax.c (Fsyntax_table_p): New forward static decl.
12686 (skip_chars): Remove duplicate decl.
12687 * textprop.c (Fprevious_property_change): New forward static decl.
12688 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12690 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12691 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12693 * editfns.c (Fformat): Remove unreachable code.
12695 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12697 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12700 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12702 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12703 when at ZV. (Bug#8487)
12705 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12707 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12709 * keyboard.c (parse_tool_bar_item): Likewise.
12710 * sound.c (sound_cleanup, alsa_close): Likewise.
12711 * termcap.c (tgetent): Likewise.
12712 * xfns.c (x_default_font_parameter): Likewise.
12713 * xsettings.c (read_and_apply_settings): Likewise.
12715 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12716 (overrun_check_free): Protoize.
12718 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12720 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12721 since callers should never pass a negative size.
12722 Change the signature to match that of plain 'read' and 'write'; see
12723 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12724 * lisp.h: Update prototypes of emacs_write and emacs_read.
12726 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12728 * xdisp.c (redisplay_window): Don't try to determine the character
12729 position of the scroll margin if the window start point w->startp
12730 is outside the buffer's accessible region. (Bug#8468)
12732 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12734 Fix write-region and its subroutines for buffers > 2GB.
12735 * fileio.c (a_write, e_write): Modify declaration of arguments and
12736 local variables to support buffers larger than 2GB.
12737 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12739 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12740 argument, local variables, and return value.
12742 * lisp.h: Update prototypes of emacs_write and emacs_read.
12744 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12746 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12748 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12750 Fix more problems found by GCC 4.6.0's static checks.
12752 * xdisp.c (vmessage): Use a better test for character truncation.
12754 * charset.c (load_charset_map): <, not <=, for optimization,
12755 and to avoid potential problems with integer overflow.
12756 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12757 * casetab.c (set_identity, shuffle): Likewise.
12758 * editfns.c (Fformat): Likewise.
12759 * syntax.c (skip_chars): Likewise.
12761 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12762 This also lets GCC 4.6.0 generate slightly better loop code.
12764 * callint.c (Fcall_interactively): <, not <=, for optimization.
12765 (Fcall_interactively): Count the number of arguments produced,
12766 not the number of arguments given. This is simpler and lets GCC
12767 4.6.0 generate slightly better code.
12769 * ftfont.c: Distingish more carefully between FcChar8 and char.
12770 The previous code passed unsigned char * to a functions like
12771 strlen and xstrcasecmp that expect char *, which does not
12772 conform to the C standard.
12773 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12774 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12775 char * when the C standard requires it.
12777 * keyboard.c (read_char): Remove unused var.
12779 * eval.c: Port to Windows vsnprintf (Bug#8435).
12780 Include <limits.h>.
12781 (SIZE_MAX): Define if the headers do not.
12782 (verror): Do not give up if vsnprintf returns a negative count.
12783 Instead, grow the buffer. This ports to Windows vsnprintf, which
12784 does not conform to C99. Problem reported by Eli Zaretskii.
12785 Also, simplify the allocation scheme, by avoiding the need for
12786 calling realloc, and removing the ALLOCATED variable.
12788 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12790 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12791 But keep the doprint source code for now, as we might revamp it
12792 and use it again (Bug#8435).
12793 * lisp.h (doprnt): Remove.
12794 * Makefile.in (base_obj): Remove doprnt.o.
12795 * deps.mk (doprnt.o): Remove.
12797 error: Print 32- and 64-bit integers portably (Bug#8435).
12798 Without this change, on typical 64-bit hosts error ("...%d...", N)
12799 was used to print both 32- and 64-bit integers N, which relied on
12800 undefined behavior.
12801 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12802 * lisp.h (error, verror): Mark as printf-like functions.
12803 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12804 Report overflow in size calculations when allocating printf buffer.
12805 Do not truncate output string at its first null byte.
12806 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12807 Truncate the output at a character boundary, since vsnprintf does not
12809 * charset.c (check_iso_charset_parameter): Convert internal
12810 character to string before calling 'error', since %c now has the
12812 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12813 overflow when computing char to be passed to 'error'. Do not
12814 pass Lisp_Object to 'error'; pass the integer instead.
12815 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12816 formatted with plain %d.
12818 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12820 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12822 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12824 * xterm.c (x_catch_errors): Remove duplicate declaration.
12826 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12828 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12830 2011-04-10 Jim Meyering <meyering@redhat.com>
12832 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12833 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12834 return ssize_t not "int", and use size_t as the buffer length.
12835 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12836 * gnutls.h: Update declarations.
12837 * process.c (read_process_output): Use ssize_t, to match.
12838 (send_process): Likewise.
12840 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12842 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12844 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12846 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12847 Use unsigned char, to match FcChar8 type definition.
12849 * xterm.c (handle_one_xevent):
12850 * xmenu.c (create_and_show_popup_menu):
12851 * xselect.c (x_decline_selection_request)
12852 (x_reply_selection_request): Avoid type-punned deref of X events.
12854 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12856 Fix some uses of `int' instead of EMACS_INT.
12857 * search.c (string_match_1, fast_string_match)
12858 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12859 (scan_buffer, find_next_newline_no_quit)
12860 (find_before_next_newline, search_command, Freplace_match)
12861 (Fmatch_data): Make some `int' variables be EMACS_INT.
12863 * xdisp.c (display_count_lines): 3rd argument and return value now
12864 EMACS_INT. All callers changed.
12865 (pint2hrstr): Last argument is now EMACS_INT.
12867 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12868 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12869 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12870 (decode_coding_utf_16, decode_coding_emacs_mule)
12871 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12872 (decode_coding_ccl, decode_coding_charset)
12873 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12874 (decode_coding_iso_2022, decode_coding_emacs_mule)
12875 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12876 <char_offset, last_offset>: Declare EMACS_INT.
12877 (encode_coding_utf_8, encode_coding_utf_16)
12878 (encode_coding_emacs_mule, encode_invocation_designation)
12879 (encode_designation_at_bol, encode_coding_iso_2022)
12880 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12881 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12883 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12884 (encode_invocation_designation): Last argument P_NCHARS is now
12886 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12887 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12889 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12892 * ccl.c (Fccl_execute_on_string): Declare some variables
12895 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12897 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12899 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12901 * process.c (Fformat_network_address): Doc fix.
12903 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12905 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12907 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12909 * keyboard.c (read_char): Call Lisp function help-form-show,
12910 instead of using internal_with_output_to_temp_buffer.
12911 (Qhelp_form_show): New var.
12912 (syms_of_keyboard): Use DEFSYM macro.
12914 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12916 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12918 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12920 * process.c (Flist_processes): Remove to Lisp.
12921 (list_processes_1): Delete.
12923 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12925 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12927 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12929 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12931 Fix more problems found by GCC 4.6.0's static checks.
12933 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12935 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12937 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12939 * xdisp.c (vmessage): Mark as a printf-like function.
12941 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12943 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12945 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12946 printf-like functions.
12947 (tiff_load): Add casts to remove these marks before passing them
12948 to system-supplied API.
12950 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12952 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12953 This avoids several warnings with gcc -Wstrict-overflow.
12954 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12955 directly, rather than having caller test rule sign. This avoids
12956 some unnecessary tests.
12957 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12958 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12959 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12961 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12962 (xfont_open): Avoid unnecessary tests.
12964 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12966 * composite.h, composite.c (composition_gstring_put_cache):
12967 Use EMACS_INT, not int, for length.
12969 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12970 breaking out part of COMPOSITION_DECODE_RULE.
12971 (COMPOSITION_DECODE_RULE): Use it.
12972 * composite.c (get_composition_id): Remove unused local vars,
12973 by using the new macro.
12975 * textprop.c (set_text_properties_1): Change while to do-while,
12976 since the condition is always true at first.
12978 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12979 (interval_deletion_adjustment): Return unsigned value.
12982 * process.c (list_processes_1, create_pty, read_process_output):
12983 (exec_sentinel): Remove vars that were set but not used.
12984 (create_pty): Remove unnecessary "volatile"s.
12985 (Fnetwork_interface_info): Avoid possibility of int overflow.
12986 (read_process_output): Do adaptive read buffering even if carryover.
12987 (read_process_output): Simplify nbytes computation if buffered.
12989 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12991 * syntax.c (scan_words): Remove var that was set but not used.
12992 (update_syntax_table): Use unsigned instead of int.
12994 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12995 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12996 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12998 * print.c (print_error_message): Avoid int overflow.
13000 * font.c (font_list_entities): Redo for clarity,
13001 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13003 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13004 (font_score): Avoid potential overflow in diff calculation.
13006 * fns.c (substring_both): Remove var that is set but not used.
13007 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13009 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13011 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13012 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13013 can always succeed if overflow has undefined behavior.
13015 * search.c (boyer_moore, wordify): Remove vars set but not used.
13016 (wordify): Omit three unnecessary tests.
13018 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13019 All callers changed. This avoids the need for an unused var.
13021 * casefiddle.c (casify_region): Remove var that is set but not used.
13023 * dired.c (file_name_completion): Remove var that is set but not used.
13025 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13027 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13028 (Finsert_file_contents): Remove unnecessary code checking fd.
13030 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13031 Check for integer overflow on size calculations.
13033 * buffer.c (Fprevious_overlay_change): Remove var that is set
13036 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13037 Remove vars that are set but not used.
13038 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13039 (timer_check_2): Mark vars as initialized.
13041 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13043 * image.c (lookup_image): Remove var that is set but not used.
13044 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13046 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13047 that are set but not used.
13049 * xfns.c (make_invisible_cursor): Don't return garbage
13050 if XCreateBitmapFromData fails (Bug#8410).
13052 * xselect.c (x_get_local_selection, x_handle_property_notify):
13053 Remove vars that are set but not used.
13055 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13056 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13058 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13059 Remove var that is set but not used.
13060 (scroll_bar_windows_size): Now size_t, not int.
13061 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13062 Check for overflow.
13064 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13065 (map_tty_color) [!defined MSDOS]: Likewise.
13067 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13069 * coding.c: Remove vars that are set but not used.
13070 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13071 All callers changed.
13072 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13073 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13074 (decode_coding_charset): Remove vars that are set but not used.
13076 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13077 that is set but not used.
13079 * print.c (print_object): Remove var that is set but not used.
13081 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13082 The gnulib version avoids calling malloc in the usual case,
13083 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13084 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13085 * filelock.c (current_lock_owner): Likewise.
13086 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13087 * sysdep.c: Include allocator.h, careadlinkat.h.
13088 (emacs_no_realloc_allocator): New static constant.
13089 (emacs_readlink): New function.
13090 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13091 ../lib/careadlinkat.h.
13093 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13095 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13096 first non-nil return value).
13098 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13100 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13101 if not defined (Bug#8403).
13103 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13105 * xdisp.c (display_count_lines): Remove parameter `start',
13106 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13107 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13108 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13109 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13110 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13111 and thereabouts. All callers changed.
13112 (get_per_char_metric): Remove parameter `f', unused since
13113 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13115 2011-04-02 Jim Meyering <meyering@redhat.com>
13117 do not dereference NULL upon failed strdup
13118 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13119 (ns_get_family): Likewise.
13121 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13123 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13125 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13127 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13130 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13132 Add lexical binding.
13134 * window.c (Ftemp_output_buffer_show): New fun.
13135 (Fsave_window_excursion):
13136 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13138 * lread.c (lisp_file_lexically_bound_p): New function.
13139 (Fload): Bind Qlexical_binding.
13140 (readevalloop): Remove `evalfun' arg.
13141 Bind Qinternal_interpreter_environment.
13142 (Feval_buffer): Bind Qlexical_binding.
13143 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13145 (syms_of_lread): Declare `lexical-binding'.
13147 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13149 * keyboard.c (eval_dyn): New fun.
13150 (menu_item_eval_property): Use it.
13152 * image.c (parse_image_spec): Use Ffunctionp.
13154 * fns.c (concat, mapcar1): Accept byte-code-functions.
13156 * eval.c (Fsetq): Handle lexical vars.
13157 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13158 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13159 (FletX, Flet): Obey lexical binding.
13160 (Fcommandp): Handle closures.
13161 (Feval): New `lexical' arg.
13162 (eval_sub): New function extracted from Feval. Use it almost
13163 everywhere where Feval was used. Look up vars in lexical env.
13165 (Ffunctionp): Move from subr.el.
13166 (Ffuncall): Handle closures.
13167 (apply_lambda): Remove `eval_flags'.
13168 (funcall_lambda): Handle closures and new byte-code-functions.
13169 (Fspecial_variable_p): New function.
13170 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13171 but without exporting it to Lisp.
13173 * doc.c (Fdocumentation, store_function_docstring):
13174 * data.c (Finteractive_form): Handle closures.
13176 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13179 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13181 (exec_byte_code): New function extracted from Fbyte_code to handle new
13182 calling convention for byte-code-functions. Add new byte-codes.
13184 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13186 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13188 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13190 * xdisp.c (redisplay_internal): Fix prototype.
13192 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13194 * xdisp.c (SCROLL_LIMIT): New macro.
13195 (try_scrolling): Use it when setting scroll_limit.
13196 Limit scrolling to 100 screen lines.
13197 (redisplay_window): Even when falling back on "recentering",
13198 position point in the window according to scroll-conservatively,
13199 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13201 (try_scrolling): When point is above the window, allow searching
13202 as far as scroll_max, or one screenful, to compute vertical
13203 distance from PT to the scroll margin position. This prevents
13204 try_scrolling from unnecessarily failing when
13205 scroll-conservatively is set to a value slightly larger than the
13206 window height. Clean up the case of PT below the margin at bottom
13207 of window: scroll_max can no longer be INT_MAX. When aggressive
13208 scrolling is in use, don't let point enter the opposite scroll
13209 margin as result of the scroll.
13210 (syms_of_xdisp) <scroll-conservatively>: Document the
13211 threshold of 100 lines for never-recentering scrolling.
13213 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13215 * dispextern.h (move_it_by_lines):
13216 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13217 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13218 (message_log_check_duplicate): Remove parameters `prev_bol' and
13219 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13220 (redisplay_internal): Remove parameter `preserve_echo_area',
13221 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13223 * indent.c (Fvertical_motion):
13224 * window.c (window_scroll_pixel_based, Frecenter):
13225 Don't pass `need_y_p' to `move_it_by_lines'.
13227 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13229 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13230 steal a few bits to be more compact.
13231 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13232 Remove unneeded casts.
13234 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13236 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13238 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13239 binding" message (bug#7967).
13241 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13243 Fix more problems found by GCC 4.6.0's static checks.
13245 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13246 Remove unused local var.
13248 * editfns.c (Fmessage_box): Remove unused local var.
13250 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13251 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13252 Omit unused local vars.
13253 * window.c (shrink_windows): Omit unused local var.
13254 * menu.c (digest_single_submenu): Omit unused local var.
13255 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13256 Omit unused local var.
13258 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13259 Don't assume string length fits in int.
13260 (keyremap_step, read_key_sequence): Use size_t for sizes.
13261 (read_key_sequence): Don't check last_real_key_start redundantly.
13263 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13264 instead of alloca (Bug#8344).
13266 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13267 (Fbacktrace_frame): Don't assume nframes fits in int.
13269 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13271 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13274 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13276 * cm.c (calccost): Turn while-do into do-while, for clarity.
13278 * keyboard.c (syms_of_keyboard): Use the same style as later
13279 in this function when indexing through an array. This also
13280 works around GCC bug 48267.
13282 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13284 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13286 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13287 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13289 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13290 This avoids undefined behavior on integer overflow, and is a bit
13291 more convenient anyway since it is compared to a size_t variable.
13293 Variadic C functions now count arguments with size_t, not int.
13294 This avoids an unnecessary limitation on 64-bit machines, which
13295 caused (substring ...) to crash on large vectors (Bug#8344).
13296 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13297 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13298 All variadic functions and their callers changed accordingly.
13299 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13300 * data.c (arith_driver, float_arith_driver): Likewise.
13301 * editfns.c (general_insert_function): Likewise.
13302 * eval.c (struct backtrace.nargs, interactive_p)
13303 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13304 (funcall_lambda, mark_backtrace): Likewise.
13305 * fns.c (concat): Likewise.
13306 * frame.c (x_set_frame_parameters): Likewise.
13307 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13308 0 if not found, not -1. All callers changed.
13310 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13311 (stack_copy_size): Now size_t, not int.
13312 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13314 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13316 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13317 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13318 All callers changed.
13320 * lisp.h (multibyte_char_to_unibyte):
13321 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13322 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13323 * character.h (CHAR_TO_BYTE8):
13324 * cmds.c (internal_self_insert):
13325 * editfns.c (general_insert_function):
13326 * keymap.c (push_key_description):
13327 * search.c (Freplace_match):
13328 * xdisp.c (message_dolog, set_message_1): All callers changed.
13330 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13332 * keyboard.c (safe_run_hook_funcall): New function.
13333 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13334 don't set the hook to nil, but remove the offending function instead.
13335 (Qcommand_hook_internal): Remove, unused.
13336 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13337 Vcommand_hook_internal.
13339 * eval.c (enum run_hooks_condition): Remove.
13340 (funcall_nil, funcall_not): New functions.
13341 (run_hook_with_args): Call each function through a `funcall' argument.
13342 Remove `cond' argument, now redundant.
13343 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13344 (Frun_hook_with_args_until_failure): Adjust accordingly.
13345 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13347 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13349 * dispextern.h (string_buffer_position): Remove declaration.
13351 * print.c (strout): Remove parameter `multibyte', unused since
13352 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13354 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13355 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13356 All callers changed.
13358 * w32.c (_wsa_errlist): Use braces for struct initializers.
13360 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13361 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13362 All callers changed.
13363 (string_buffer_position): Likewise. Also, make static (it's never
13364 used outside xdisp.c).
13365 (cursor_row_p): Remove parameter `w', unused since
13366 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13367 (decode_mode_spec): Remove parameter `precision', introduced during
13368 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13369 All callers changed.
13371 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13373 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13375 2011-03-27 Anders Lindgren <andlind@gmail.com>
13377 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13378 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13379 (ns_update_auto_hide_menu_bar): New functions.
13380 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13381 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13382 ns_constrain_all_frames.
13383 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13384 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13386 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13388 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13390 2011-03-27 Glenn Morris <rgm@gnu.org>
13392 * syssignal.h: Replace RETSIGTYPE with void.
13393 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13394 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13395 Replace SIGTYPE with void everywhere.
13396 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13397 * s/template.h (SIGTYPE): Remove commented out definition.
13399 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13401 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13402 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13404 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13406 * w32.c (read_unc_volume): Use parameter `henum', instead of
13407 global variable `wget_enum_handle'.
13409 * keymap.c (describe_vector): Remove parameters `indices' and
13410 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13411 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13413 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13415 * keyboard.c (timer_check): Remove parameter `do_it_now',
13416 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13417 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13418 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13420 * keyboard.c (read_char):
13421 * w32menu.c (w32_menu_display_help):
13422 * xmenu.c (show_help_event, menu_help_callback):
13423 Adjust calls to `show_help_echo'.
13425 * gtkutil.c (xg_maybe_add_timer):
13426 * keyboard.c (readable_events):
13427 * process.c (wait_reading_process_output):
13428 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13430 * insdel.c (adjust_markers_gap_motion):
13431 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13432 (gap_left, gap_right): Don't call it.
13434 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13436 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13437 incurred during fontification.
13439 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13441 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13442 (DEFVAR_PER_BUFFER): Don't pass it.
13444 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13445 (scrolling_window): Don't pass it.
13447 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13449 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13451 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13453 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13454 of variables specific to SELinux and computation of `encoded_absname'.
13456 * image.c (XPutPixel): Remove unused variable `height'.
13458 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13460 * unexw32.c (get_section_info): Remove unused variable `section'.
13462 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13463 (system_process_attributes): Remove unused variable `sess'.
13464 (sys_read): Remove unused variable `err'.
13466 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13467 (w32_wnd_proc): Remove unused variable `isdead'.
13468 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13469 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13470 (x_create_tip_frame): Remove unused variable `tem'.
13472 * w32inevt.c (w32_console_read_socket):
13473 Remove unused variable `no_events'.
13475 * w32term.c (x_draw_composite_glyph_string_foreground):
13476 Remove unused variable `width'.
13478 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13480 * w32term.c (x_set_glyph_string_clipping):
13481 Don't pass uninitialized region to CombineRgn.
13483 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13485 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13486 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13487 (Fx_close_connection): Remove unused variable `i'.
13489 * w32font.c (w32font_draw): Return number of glyphs.
13490 (w32font_open_internal): Remove unused variable `i'.
13491 (w32font_driver): Add missing initializer.
13493 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13494 (fill_in_menu): Remove unused variable `items_added'.
13496 * w32term.c (last_mouse_press_frame): Remove static global variable.
13497 (w32_clip_to_row): Remove unused variable `f'.
13498 (x_delete_terminal): Remove unused variable `i'.
13500 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13501 (NOTHING): Remove unused static global variable.
13502 (uniscribe_check_otf): Remove unused variable `table'.
13503 (uniscribe_font_driver): Add missing initializers.
13505 2011-03-23 Julien Danjou <julien@danjou.info>
13507 * term.c (Fsuspend_tty, Fresume_tty):
13508 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13509 * window.c (temp_output_buffer_show):
13510 * insdel.c (signal_before_change):
13511 * frame.c (Fhandle_switch_frame):
13512 * fileio.c (Fdo_auto_save):
13513 * emacs.c (Fkill_emacs):
13514 * editfns.c (save_excursion_restore):
13515 * cmds.c (internal_self_insert):
13516 * callint.c (Fcall_interactively):
13517 * buffer.c (Fkill_all_local_variables):
13518 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13520 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13521 unconditionally since it does the check itself.
13523 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13525 Fix more problems found by GCC 4.5.2's static checks.
13527 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13528 the first time through the loop, since we know p0 < p1 then.
13529 This also avoids a gcc -Wstrict-overflow warning.
13531 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13532 leading to a memory leak, possible in functions like
13533 load_charset_map_from_file that can allocate an unbounded number
13534 of objects (Bug#8318).
13536 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13537 that could (at least in theory) be that large.
13539 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13540 This is less likely to overflow, and avoids undefined behavior if
13541 overflow does occur. All callers changed. Use strtoul to scan
13542 for the unsigned long integer.
13543 (pint2hrstr): Simplify and tune code slightly.
13544 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13546 * scroll.c (do_scrolling): Work around GCC bug 48228.
13547 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13549 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13550 This also avoids a warning with gcc -Wstrict-overflow.
13551 (validate_x_resource_name): Simplify count usage.
13552 This also avoids a warning with gcc -Wstrict-overflow.
13554 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13557 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13559 * process.c (Fmake_network_process): Use socklen_t, not int,
13560 where POSIX says socklen_t is required in portable programs.
13561 This fixes a porting bug on hosts like 64-bit HP-UX, where
13562 socklen_t is wider than int (Bug#8277).
13563 (Fmake_network_process, server_accept_connection):
13564 (wait_reading_process_output, read_process_output):
13567 * process.c: Rename or move locals to avoid shadowing.
13568 (list_processes_1, Fmake_network_process):
13569 (read_process_output_error_handler, exec_sentinel_error_handler):
13570 Rename or move locals.
13571 (Fmake_network_process): Define label "retry_connect" only if needed.
13572 (Fnetwork_interface_info): Fix pointer signedness.
13573 (process_send_signal): Add cast to avoid pointer signedness problem.
13574 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13575 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13577 Make tparam.h and terminfo.c consistent.
13578 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13579 Include tparam.h instead, since it declares them.
13580 * cm.h (PC): Remove extern decl; tparam.h now does this.
13581 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13582 * terminfo.c: Include tparam.h, to check interfaces.
13583 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13584 (tparam): Adjust signature to match interface in tparam.h;
13585 this removes some undefined behavior. Check that outstring and len
13586 are zero, which they always are with Emacs.
13587 * tparam.h (PC, BC, UP): New extern decls.
13589 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13590 (xftfont_open): Rename locals to avoid shadowing.
13592 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13593 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13594 (OTF_TAG_SYM): Omit macro if not needed.
13595 (ftfont_list): Remove unused local.
13596 (get_adstyle_property, ftfont_pattern_entity):
13597 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13598 Rename locals to avoid shadowing.
13600 * xfont.c (xfont_list_family): Mark var as initialized.
13602 * xml.c (make_dom): Now static.
13604 * composite.c (composition_compute_stop_pos): Rename local to
13606 (composition_reseat_it): Remove unused locals.
13607 (find_automatic_composition, composition_adjust_point): Likewise.
13608 (composition_update_it): Mark var as initialized.
13609 (find_automatic_composition): Mark vars as initialized,
13610 with a FIXME (Bug#8290).
13612 character.h: Rename locals to avoid shadowing.
13613 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13614 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13615 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13616 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13617 to avoid shadowing.
13619 * textprop.c (property_change_between_p): Remove; unused.
13621 * intervals.c (interval_start_pos): Now static.
13623 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13625 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13626 Rename locals to avoid shadowing.
13628 * sound.c (wav_play, au_play, Fplay_sound_internal):
13629 Fix pointer signedness.
13630 (alsa_choose_format): Remove unused local var.
13631 (wav_play): Initialize a variable to 0, to prevent undefined
13632 behavior (Bug#8278).
13634 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13636 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13638 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13639 clobbering (Bug#8298).
13640 * sysdep.c (sys_subshell): Likewise.
13641 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13643 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13644 This should get cleaned up, so that child_setup has the
13645 same signature on all platforms.
13647 * callproc.c (call_process_cleanup): Now static.
13648 (relocate_fd): Rename locals to avoid shadowing.
13650 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13652 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13653 not to be necessary, and produces flickering.
13655 2011-03-20 Glenn Morris <rgm@gnu.org>
13657 * config.in: Remove file.
13659 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13661 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13662 are now in src/globals.h.
13663 (syms_of_minibuf): Remove spurious & from previous change.
13665 2011-03-20 Leo Liu <sdl.web@gmail.com>
13667 * minibuf.c (completing-read-function): New variable.
13668 (completing-read-default): Rename from completing-read.
13669 (completing-read): Call completing-read-function.
13671 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13673 * xfaces.c (Fx_load_color_file):
13674 Read color file from absolute filename (bug#8250).
13676 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13678 * makefile.w32-in: Update dependencies.
13680 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13682 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13684 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13686 Fix more problems found by GCC 4.5.2's static checks.
13688 * process.c (make_serial_process_unwind, send_process_trap):
13689 (sigchld_handler): Now static.
13691 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13692 That way, the code declares only the vars that it needs.
13693 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13694 * s/cygwin.h (PTY_ITERATION): Likewise.
13695 * s/darwin.h (PTY_ITERATION): Likewise.
13696 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13698 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13699 * process.c (allocate_pty): Don't declare stb unless it's needed.
13701 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13702 (CONSTANTLIM): Remove; unused.
13703 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13704 Define only if needed.
13706 * unexelf.c (unexec): Name an expression,
13707 to avoid gcc -Wbad-function-cast warning.
13708 Use a different way to cause a compilation error if anyone uses
13709 n rather than nn, a way that does not involve shadowing.
13710 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13712 * deps.mk (unexalpha.o): Remove; unused.
13714 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13715 * unexec.h: New file.
13716 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13717 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13718 Depend on unexec.h.
13719 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13720 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13721 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13722 Change as necessary to match prototype in unexec.h.
13724 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13726 (back_comment, skip_chars): Mark vars as initialized.
13728 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13729 Rename locals to avoid shadowing.
13731 * lread.c (read1): Rewrite so as not to use empty "else".
13732 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13734 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13736 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13737 warning when compiling print.c.
13739 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13740 instead of using an uninitialized var.
13741 (font_sort_entities): Mark var as initialized.
13743 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13745 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13746 pointers to constants.
13747 (font_parse_fcname): Remove unused vars.
13748 (font_delete_unmatched): Now static.
13749 (font_get_spec): Remove; unused.
13750 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13751 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13752 Rename or move locals to avoid shadowing.
13754 * fns.c (require_nesting_list, require_unwind): Now static.
13755 (Ffillarray): Rename locals to avoid shadowing.
13757 * floatfns.c (domain_error2): Define only if needed.
13758 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13760 * alloc.c (mark_backtrace): Move decl from here ...
13761 * lisp.h: ... to here, so that it can be checked.
13763 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13764 (Fdefvar): Rewrite so as not to use empty "else".
13765 (lisp_indirect_variable): Name an expression,
13766 to avoid gcc -Wbad-function-cast warning.
13767 (Fdefvar): Rename locals to avoid shadowing.
13769 * callint.c (quotify_arg, quotify_args): Now static.
13770 (Fcall_interactively): Rename locals to avoid shadowing.
13771 Use const pointer when appropriate.
13773 * lisp.h (get_system_name, get_operating_system_release):
13774 Move decls here, to check interfaces.
13775 * process.c (get_operating_system_release): Move decl to lisp.h.
13776 * xrdb.c (get_system_name): Likewise.
13777 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13778 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13779 some of which prompt warnings from gcc -Wbad-function-cast.
13780 (Fformat_time_string, Fencode_time, Finsert_char):
13781 (Ftranslate_region_internal, Fformat):
13782 Rename or remove local vars to avoid shadowing.
13783 (Ftranslate_region_internal): Mark var as initialized.
13785 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13788 * lisp.h (eassert): Check that the argument compiles, even if
13789 ENABLE_CHECKING is not defined.
13791 * data.c (Findirect_variable): Name an expression, to avoid
13792 gcc -Wbad-function-cast warning.
13793 (default_value, arithcompare, arith_driver, arith_error): Now static.
13794 (store_symval_forwarding): Rename local to avoid shadowing.
13795 (Fmake_variable_buffer_local, Fmake_local_variable):
13796 Mark variables as initialized.
13797 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13799 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13800 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13801 Rename locals to avoid shadowing.
13802 (mark_stack): Move local variables into the #ifdef region where
13804 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13805 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13807 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13808 (GC_STRING_CHARS): Remove; not used.
13809 (Fmemory_limit): Cast sbrk's returned value to char *.
13811 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13812 avoids undefined behavior in theory.
13814 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13816 Use functions, not macros, for up- and down-casing (Bug#8254).
13817 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13818 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13819 to use the following functions instead of these macros.
13820 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13821 EMACS_INT, since callers assume the returned value fits in int.
13822 (upcase1): Likewise, for UPCASE_TABLE.
13823 (uppercasep, lowercasep, upcase): New static inline functions.
13824 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13825 the race-condition problem in the old DOWNCASE.
13827 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13828 Rename locals to avoid shadowing.
13829 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13830 (regex_compile, re_search_2, re_match_2_internal):
13831 Remove unused local vars.
13832 (FREE_VAR): Rewrite so as not to use empty "else",
13833 which gcc can warn about.
13834 (regex_compile, re_match_2_internal): Mark locals as initialized.
13835 (RETALLOC_IF): Define only if needed.
13836 (WORDCHAR_P): Likewise. This one is never needed, but is used
13837 only in a comment talking about a compiler bug, so put inside
13838 the #if 0 of that comment.
13839 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13840 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13843 * search.c (boyer_moore): Rename locals to avoid shadowing.
13844 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13845 (PREV_CHAR_BOUNDARY): Likewise.
13847 * search.c (simple_search): Remove unused var.
13849 * dired.c (compile_pattern): Move decl from here ...
13850 * lisp.h: ... to here, so that it can be checked.
13851 (struct re_registers): New forward decl.
13853 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13855 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13857 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13858 Rename locals to avoid shadowing.
13859 (Fvertical_motion): Mark locals as initialized.
13861 * casefiddle.c (casify_object, casify_region): Now static.
13862 (casify_region): Mark local as initialized.
13864 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13866 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13867 New macros, so that the caller can use some names other than
13868 gcpro1, gcpro2, etc.
13869 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13871 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13872 argument, for consistency with GCPRO2_VAR, etc: it is now the
13873 prefix of the variable, not the variable itself. All uses
13875 * dired.c (directory_files_internal, file_name_completion):
13876 Rename locals to avoid shadowing.
13878 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13879 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13880 dired.c's scmp function, had undefined behavior.
13881 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13882 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13883 * buffer.h: ... to here, because these macros use current_buffer,
13884 and the new implementation with inline functions needs to have
13885 current_buffer in scope now, rather than later when the macros
13887 (downcase, upcase1): New static inline functions.
13888 (DOWNCASE, UPCASE1): Reimplement using these functions.
13889 This avoids undefined behavior in expressions like
13890 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13891 from race conditions in accessing the global variables
13892 case_temp1 and case_temp2.
13893 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13894 * lisp.h (case_temp1, case_temp2): Remove their decls.
13895 * character.h (ASCII_CHAR_P): Move from here ...
13896 * lisp.h: ... to here, so that the inline functions mentioned
13897 above can use them.
13899 * dired.c (directory_files_internal_unwind): Now static.
13901 * fileio.c (file_name_as_directory, directory_file_name):
13902 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13904 (file_name_as_directory): Use const pointers when appropriate.
13905 (Fexpand_file_name): Likewise. In particular, newdir might
13906 point at constant storage, so make it a const pointer.
13907 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13908 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13910 (Fset_file_times, Finsert_file_contents, auto_save_error):
13911 Rename locals to avoid shadowing.
13913 * minibuf.c (choose_minibuf_frame_1): Now static.
13914 (Ftry_completion, Fall_completions): Rename or remove locals
13915 to avoid shadowing.
13917 * marker.c (bytepos_to_charpos): Remove; unused.
13919 * lisp.h (verify_bytepos, count_markers): New decls,
13920 so that gcc does not warn that these functions aren't declared.
13922 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13923 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13924 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13925 (copy_text): Remove unused local var.
13927 * filelock.c (within_one_second): Now static.
13928 (lock_file_1): Rename local to avoid shadowing.
13930 * buffer.c (fix_overlays_before): Mark locals as initialized.
13931 (fix_start_end_in_overlays): Likewise. This function should be
13932 simplified by using pointers-to-pointers, but that's a different
13934 (switch_to_buffer_1): Now static.
13935 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13936 (report_overlay_modification): Rename locals to avoid shadowing.
13938 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13939 Fix pointer signedness issue.
13940 (sys_subshell): Mark local as volatile if checking for lint,
13941 to suppress a gcc -Wclobbered warning that does not seem to be right.
13942 (MAXPATHLEN): Define only if needed.
13944 * process.c (serial_open, serial_configure): Move decls from here ...
13945 * systty.h: ... to here, so that they can be checked.
13947 * fns.c (get_random, seed_random): Move extern decls from here ...
13948 * lisp.h: ... to here, so that they can be checked.
13950 * sysdep.c (reset_io): Now static.
13951 (wait_for_termination_signal): Remove; unused.
13953 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13954 (copy_keymap_item, append_key, push_text_char_description):
13956 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13957 (DENSE_TABLE_SIZE): Remove; unused.
13958 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13959 (describe_map_tree):
13960 Rename locals to avoid shadowing.
13962 * keyboard.c: Declare functions static if they are not used elsewhere.
13963 (echo_char, echo_dash, cmd_error, top_level_2):
13964 (poll_for_input, handle_async_input): Now static.
13965 (read_char, kbd_buffer_get_event, make_lispy_position):
13966 (make_lispy_event, make_lispy_movement, apply_modifiers):
13967 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13968 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13969 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13970 (read_key_sequence, read_char): Mark locals as initialized.
13971 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13973 * keyboard.h (make_ctrl_char): New decl.
13974 (mark_kboards): Move decl here ...
13975 * alloc.c (mark_kboards): ... from here.
13977 * lisp.h (force_auto_save_soon): New decl.
13979 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13980 (DEFINE_DUMMY_FUNCTION): New macro.
13981 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13983 (main): Add casts to avoid warnings
13984 if GCC considers string literals to be constants.
13986 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13988 * dbusbind.c: Pointer signedness fixes.
13989 (xd_signature, xd_append_arg, xd_initialize):
13990 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13991 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13992 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13993 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13995 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13996 if GCC considers string literals to be constants.
13997 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13999 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14001 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14002 (print_preprocess, print_object): New macro to fix last change.
14004 * print.c (print_preprocess): Don't forget font objects.
14006 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14008 * emacs.c (USAGE3): Doc fixes.
14010 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14012 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14015 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14017 * lisp.h (VWindow_system, Qfile_name_history):
14018 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14019 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14020 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14022 * w32select.c: Don't #include "keyboard.h".
14023 (run_protected): Add extern declaration for waiting_for_input.
14025 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14026 * w32console.c (detect_input_pending, read_input_pending)
14027 (encode_terminal_code):
14028 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14029 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14030 (w32_system_caret_y, Qfile_name_history):
14031 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14032 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14033 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14034 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14035 * w32proc.c (Qlocal, report_file_error):
14036 * w32term.c (Vwindow_system, updating_frame):
14037 * w32uniscribe.c (initialized, uniscribe_font_driver):
14038 Remove unneeded extern declarations.
14040 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14042 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14044 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14046 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14047 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14048 These macros can no longer be used for assignment.
14050 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14051 Assign struct members directly, instead of using BUF_BEGV etc.
14052 (record_buffer_markers, fetch_buffer_markers): New functions for
14053 recording and fetching special buffer markers.
14054 (set_buffer_internal_1, set_buffer_temp): Use them.
14056 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14058 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14060 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14061 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14063 * xdisp.c (hscroll_window_tree):
14064 (reconsider_clip_changes): Use PT instead of BUF_PT.
14066 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14068 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14069 $(EMACS_ROOT)/lib/intprops.h.
14071 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14073 Fix more problems found by GCC 4.5.2's static checks.
14075 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14076 to unsigned char * to avoid compiler diagnostic.
14077 (xg_free_frame_widgets): Make it clear that a local variable is
14078 needed only if USE_GTK_TOOLTIP.
14079 (gdk_window_get_screen): Make it clear that this macro is needed
14080 only if USE_GTK_TOOLTIP.
14081 (int_gtk_range_get_value): New function, which avoids a diagnostic
14082 from gcc -Wbad-function-cast.
14083 (xg_set_toolkit_scroll_bar_thumb): Use it.
14084 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14085 diagnostic from gcc -Wbad-function-cast.
14086 (get_utf8_string, xg_get_file_with_chooser):
14087 Rename locals to avoid shadowing.
14088 (create_dialog): Move locals to avoid shadowing.
14090 * xgselect.c (xg_select): Remove unused var.
14092 * image.c (four_corners_best): Mark locals as initialized.
14093 (gif_load): Initialize transparent_p to zero (Bug#8238).
14094 Mark another local as initialized.
14095 (my_png_error, my_error_exit): Mark with NO_RETURN.
14097 * image.c (clear_image_cache): Now static.
14098 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14099 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14100 (x_edge_detection): Remove unnecessary cast that
14101 gcc -Wbad-function-cast diagnoses.
14102 (gif_load): Fix pointer signedness.
14103 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14104 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14106 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14108 Improve quality of tests for time stamp overflow.
14109 For example, without this patch (encode-time 0 0 0 1 1
14110 1152921504606846976) returns the obviously-bogus value (-948597
14111 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14112 reports time overflow. See
14113 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14114 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14115 * editfns.c: Include limits.h and intprops.h.
14116 (TIME_T_MIN, TIME_T_MAX): New macros.
14117 (time_overflow): Move earlier, to before first use.
14118 (hi_time, lo_time): New functions, for an accurate test for
14119 out-of-range times.
14120 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14121 (Fget_internal_run_time): Don't assume time_t fits in int.
14122 (make_time): Use list2 instead of Fcons twice.
14123 (Fdecode_time): More accurate test for out-of-range times.
14124 (check_tm_member): New function.
14125 (Fencode_time): Use it, to test for out-of-range times.
14126 (lisp_time_argument): Don't rely on undefined left-shift and
14127 right-shift behavior when checking for time stamp overflow.
14129 * editfns.c (time_overflow): New function, refactoring common code.
14130 (Fformat_time_string, Fdecode_time, Fencode_time):
14131 (Fcurrent_time_string): Use it.
14133 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14134 * dired.c (make_time): Move to ...
14135 * editfns.c (make_time): ... here.
14136 * systime.h: Note the move.
14138 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14140 * fringe.c (update_window_fringes): Remove unused variables.
14142 * unexmacosx.c (copy_data_segment): Also copy __got section.
14145 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14147 * termcap.c [MSDOS]: Include "msdos.h".
14148 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14149 Constify `char *' arguments and their references according to
14150 prototypes in tparam.h.
14152 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14154 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14155 Adapt all references accordingly.
14157 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14159 2011-03-11 Tom Tromey <tromey@redhat.com>
14161 * buffer.c (syms_of_buffer): Remove obsolete comment.
14163 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14165 * termhooks.h (encode_terminal_code): Declare prototype.
14167 * msdos.c (encode_terminal_code): Don't declare prototype.
14169 * term.c (encode_terminal_code): Now external again, used by
14170 w32console.c and msdos.c.
14172 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14173 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14175 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14177 Fix some minor problems found by GCC 4.5.2's static checks.
14179 * fringe.c (update_window_fringes): Mark locals as initialized
14181 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14183 * alloc.c (mark_fringe_data): Move decl from here ...
14184 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14185 to check its interface.
14186 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14188 * fontset.c (free_realized_fontset): Now static.
14189 (Fset_fontset_font): Rename local to avoid shadowing.
14190 (fontset_font): Mark local as initialized.
14191 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14193 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14195 * xselect.c (x_disown_buffer_selections): Remove; not used.
14196 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14197 (x_own_selection, Fx_disown_selection_internal): Rename locals
14198 to avoid shadowing.
14199 (x_handle_dnd_message): Remove local to avoid shadowing.
14201 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14202 so that the caller can use some name other than gcpro1.
14203 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14204 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14205 (Fx_backspace_delete_keys_p):
14206 Use them to avoid shadowing, and rename vars to avoid shadowing.
14207 (x_decode_color, x_set_name, x_window): Now static.
14208 (Fx_create_frame): Add braces to silence GCC warning.
14209 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14210 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14211 Remove unused locals.
14212 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14213 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14214 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14217 * xterm.h (x_mouse_leave): New decl.
14219 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14220 Remove unused functions.
14221 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14222 (x_calc_absolute_position): Now static.
14223 (XTread_socket): Don't define label "out" unless it's used.
14224 Don't declare local "event" unless it's used.
14225 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14226 unless they are used.
14227 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14228 (x_fatal_error_signal): Remove; not used.
14229 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14230 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14231 (x_error_catcher, x_connection_closed, x_error_handler):
14232 (x_error_quitter, xembed_send_message, x_iconify_frame):
14233 (my_log_handler): Rename locals to avoid shadowing.
14234 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14235 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14237 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14238 Rename or move locals to avoid shadowing.
14239 (tty_defined_color, merge_face_heights): Now static.
14240 (free_realized_faces_for_fontset): Remove; not used.
14241 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14242 does not deduce is never used uninitialized.
14243 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14244 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14246 * terminal.c (store_terminal_param): Now static.
14248 * xmenu.c (menu_highlight_callback): Now static.
14249 (set_frame_menubar): Remove unused local.
14250 (xmenu_show): Rename parameter to avoid shadowing.
14251 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14252 since they might point to immutable storage.
14253 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14254 since it's unused otherwise.
14256 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14257 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14258 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14259 avoids a gcc -Wuninitialized diagnostic.
14260 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14261 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14262 does not deduce are never used uninitialized.
14264 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14266 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14267 * window.c (window_loop, size_window):
14268 (run_window_configuration_change_hook, enlarge_window): Likewise.
14270 * window.c (display_buffer): Now static.
14271 (size_window): Mark variables that gcc -Wuninitialized
14272 does not deduce are never used uninitialized.
14273 * window.h (check_all_windows): New decl, to forestall
14274 gcc -Wmissing-prototypes diagnostic.
14275 * dispextern.h (bidi_dump_cached_states): Likewise.
14277 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14279 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14280 Include <limits.h>.
14281 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14282 and to avoid gcc -Wuninitialized warning.
14283 (load_charset_map): Mark variables that gcc -Wuninitialized
14284 does not deduce are never used uninitialized.
14285 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14287 * coding.c (coding_set_source, coding_set_destination):
14288 Use "else { /* comment */ }" rather than "else /* comment */;"
14289 for clarity, and to avoid gcc -Wempty-body warning.
14290 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14291 a block, when the outer 'i' will do.
14292 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14293 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14294 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14295 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14296 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14297 Rename locals to avoid shadowing.
14298 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14299 * coding.c (emacs_mule_char, encode_invocation_designation):
14300 Now static, since they're not used elsewhere.
14301 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14302 (decode_coding_object, encode_coding_object, detect_coding_system):
14303 (decode_coding_emacs_mule): Mark variables that gcc
14304 -Wuninitialized does not deduce are never used uninitialized.
14305 (detect_coding_iso_2022): Initialize a local variable that might
14306 be used uninitialized. Leave a FIXME because it's not clear that
14307 this initialization is needed. (Bug#8211)
14308 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14309 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14310 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14311 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14312 Remove unused macros.
14314 * category.c (hash_get_category_set): Remove unused local var.
14315 (copy_category_table): Now static, since it's not used elsewhere.
14316 * character.c (string_count_byte8): Likewise.
14318 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14319 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14321 * chartab.c (copy_sub_char_table): Now static, since it's not used
14323 (sub_char_table_ref_and_range, char_table_ref_and_range):
14324 Rename locals to avoid shadowing.
14325 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14327 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14328 (BIDI_BOB): Remove unused macro.
14330 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14331 deduce are never used uninitialized.
14332 * term.c (encode_terminal_code): Likewise.
14334 * term.c (encode_terminal_code): Now static. Remove unused local.
14336 * tparam.h: New file.
14337 * term.c, tparam.h: Include it.
14338 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14339 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14340 Move these decls to tparam.h, and make them agree with what
14341 is actually in tparam.c. The previous trick of using incompatible
14342 decls in different modules does not conform to the C standard.
14343 All callers of tparam changed to use tparam's actual API.
14344 * tparam.c (tparam1, tparam, tgoto):
14345 Use const pointers where appropriate.
14347 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14348 * cm.h (struct cm): Likewise.
14349 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14350 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14351 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14352 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14353 (turn_on_face, init_tty): Likewise.
14354 * termchar.h (struct tty_display_info): Likewise.
14356 * term.c (term_mouse_position): Rename local to avoid shadowing.
14358 * alloc.c (mark_ttys): Move decl from here ...
14359 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14361 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14363 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14365 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14367 * search.c (compile_pattern_1): Remove argument regp, unused since
14368 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14369 (compile_pattern): Don't pass it.
14371 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14373 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14374 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14376 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14378 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14380 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14381 gdk_window_get_screen, gdk_window_get_geometry,
14382 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14383 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14384 (xg_get_pixbuf_from_pixmap): New function.
14385 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14386 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14387 Call xg_get_pixbuf_from_pixmap instead of
14388 gdk_pixbuf_get_from_drawable.
14389 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14390 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14391 (xg_check_special_colors): Use GtkStyleContext and its functions
14393 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14394 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14395 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14396 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14397 Call gtk_widget_get_preferred_size.
14398 (xg_frame_resized): gdk_window_get_geometry only takes 5
14400 (xg_win_to_widget, xg_event_is_for_menubar):
14401 Call gdk_x11_window_lookup_for_display.
14402 (xg_set_widget_bg): New function.
14403 (delete_cb): New function.
14404 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14405 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14406 (xg_set_background_color): Call xg_set_widget_bg.
14407 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14408 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14409 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14410 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14412 (update_frame_tool_bar): Call gtk_widget_hide.
14413 (xg_initialize): Use GDK_KEY_g.
14415 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14417 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14419 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14420 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14421 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14423 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14425 * w32xfns.c (select_palette): Check success of RealizePalette against
14426 GDI_ERROR, not zero.
14428 See ChangeLog.11 for earlier changes.
14430 ;; Local Variables:
14434 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14436 This file is part of GNU Emacs.
14438 GNU Emacs is free software: you can redistribute it and/or modify
14439 it under the terms of the GNU General Public License as published by
14440 the Free Software Foundation, either version 3 of the License, or
14441 (at your option) any later version.
14443 GNU Emacs is distributed in the hope that it will be useful,
14444 but WITHOUT ANY WARRANTY; without even the implied warranty of
14445 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14446 GNU General Public License for more details.
14448 You should have received a copy of the GNU General Public License
14449 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.