]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* xselect.c (Fx_get_atom_name): Avoid need for strlen.
[gnu-emacs] / src / ChangeLog
1 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4
5 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6 * xrdb.c (magic_file_p, search_magic_path):
7 Omit last arg SUFFIX; it was always 0. All callers changed.
8 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9
10 * xfont.c (xfont_match): Avoid need for strlen.
11
12 * xfns.c: Don't assume strlen fits in int.
13 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
14
15 * xdisp.c (message_log_check_duplicate): Return intmax_t,
16 not unsigned long, as we prefer signed integers. All callers changed.
17 Detect integer overflow in repeat count.
18 (message_dolog): Don't assume print length fits in 39 bytes.
19 (display_mode_element): Don't assume strlen fits in int.
20
21 * termcap.c: Don't assume sizes fit in int and never overflow.
22 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
23 (gobble_line): Check for size-calculation overflow.
24
25 * minibuf.c (Fread_buffer):
26 * lread.c (intern, intern_c_string):
27 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
28 Don't assume string length fits in int.
29
30 * keyboard.c (parse_tool_bar_item):
31 * gtkutil.c (style_changed_cb): Avoid need for strlen.
32
33 * font.c: Don't assume string length fits in int.
34 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
35 Use ptrdiff_t, not int.
36 (font_intern_prop): Don't assume string length fits in int.
37 Don't assume integer property fits in fixnum.
38 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
39
40 * filelock.c: Fix some buffer overrun and integer overflow issues.
41 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
42 Reformulate so as not to need the command string.
43 Invoke gzip -cd rather than gunzip, as it's more portable.
44 (lock_info_type, lock_file_1, lock_file):
45 Don't assume pid_t and time_t fit in unsigned long.
46 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
47 (current_lock_owner): Prefer signed type for sizes.
48 Use memcpy, not strncpy, where memcpy is what is really wanted.
49 Don't assume (via atoi) that time_t and pid_t fit in int.
50 Check for time_t and/or pid_t out of range, e.g., via a network share.
51 Don't alloca where an auto var works fine.
52
53 * fileio.c: Fix some integer overflow issues.
54 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
55 Don't assume string length fits in int.
56 (directory_file_name): Don't assume string length fits in long.
57 (make_temp_name): Don't assume pid fits in int, or that its print
58 length is less than 20.
59
60 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
61
62 * coding.c (make_subsidiaries): Don't assume string length fits in int.
63
64 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
65
66 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
67 We prefer signed integers, even for size calculations.
68
69 * emacs.c: Don't assume string length fits in 'int'.
70 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
71 (main): Don't invoke strlen when not needed.
72
73 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
74 (XD_DEBUG_MESSAGE): Don't waste a byte.
75
76 * callproc.c (getenv_internal_1, getenv_internal)
77 (Fgetenv_internal):
78 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
79
80 * lread.c (invalid_syntax): Omit length argument.
81 All uses changed. This doesn't fix a bug, but it simplifies the
82 code away from its former Hollerith-constant appearance, and it's
83 one less 'int' to worry about when looking at integer-overflow issues.
84 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
85
86 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
87 This didn't break anything, but it didn't help either.
88 It's confusing to put a bogus integer in a place where the actual
89 value does not matter.
90 (LIST_END_P): Remove unused macro and its bogus comment.
91 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
92
93 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
94 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
95 implementation.
96 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
97 We prefer signed types, and the value cannot exceed the EMACS_INT
98 range anyway (because otherwise the length would not be representable).
99 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
100 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
101 This avoids a GCC warning when WIDE_EMACS_INT.
102
103 * indent.c (sane_tab_width): New function.
104 (current_column, scan_for_column, Findent_to, position_indentation)
105 (compute_motion): Use it. This is just for clarity.
106 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
107
108 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
109
110 * lisp.h (lint_assume): New macro.
111 * composite.c (composition_gstring_put_cache):
112 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
113
114 * editfns.c, insdel.c:
115 Omit unnecessary forward decls, to simplify future changes.
116
117 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
118
119 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
120
121 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
122 Use much-faster test for byte-length change.
123 Don't assume string byte-length fits in 'int'.
124 Check that character arg fits in 'int'.
125 (mapcar1): Declare byte as byte, for clarity.
126
127 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
128
129 * fns.c (concat): Catch string overflow earlier.
130 Do not rely on integer wraparound.
131
132 * dispextern.h (struct it.overlay_strings_charpos)
133 (struct it.selective): Now EMACS_INT, not int.
134 * xdisp.c (forward_to_next_line_start)
135 (back_to_previous_visible_line_start)
136 (reseat_at_next_visible_line_start, next_element_from_buffer):
137 Don't arbitrarily truncate the value of 'selective' to int.
138
139 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
140
141 * composite.c: Don't truncate sizes to 'int'.
142 (composition_gstring_p, composition_reseat_it)
143 (composition_adjust_point): Use EMACS_INT, not int.
144 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
145 not EMACS_UINT, for indexes.
146
147 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
148
149 * buffer.c: Include <verify.h>.
150 (struct sortvec.priority, struct sortstr.priority):
151 Now EMACS_INT, not int.
152 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
153 (struct sortstr.size, record_overlay_string)
154 (struct sortstrlist.size, struct sortlist.used):
155 Don't truncate size to int.
156 (record_overlay_string): Check for size-calculation overflow.
157 (init_buffer_once): Check at compile-time, not run-time.
158
159 2011-06-20 Deniz Dogan <deniz@dogan.se>
160
161 * process.c (Fset_process_buffer): Clarify return value in
162 docstring.
163
164 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
165
166 * dispnew.c (add_window_display_history): Use BVAR.
167
168 * xdisp.c (debug_method_add): Use BVAR.
169 (check_window_end, dump_glyph_matrix, dump_glyph)
170 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
171
172 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
173 Likewise.
174
175 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
176 check till after the cache is created in init_frame_faces.
177
178 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
179
180 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
181
182 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
183
184 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
185 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
186 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
187
188 Improve buffer-overflow checking (Bug#8873).
189 * fileio.c (Finsert_file_contents):
190 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
191 Remove the old (too-loose) buffer overflow checks.
192 They weren't needed, since make_gap checks for buffer overflow.
193 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
194 The old code merely checked for Emacs fixnum overflow, and relied
195 on undefined (wraparound) behavior. The new code avoids undefined
196 behavior, and also checks for ptrdiff_t and/or size_t overflow.
197
198 * editfns.c (Finsert_char): Don't dump core with very negative counts.
199 Tune. Don't use wider integers than needed. Don't use alloca.
200 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
201
202 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
203
204 * insdel.c, lisp.h (buffer_overflow): New function.
205 (insert_from_buffer_1, replace_range, replace_range_2):
206 * insdel.c (make_gap_larger):
207 * editfns.c (Finsert_char):
208 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
209
210 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
211
212 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
213
214 Integer overflow and signedness fixes (Bug#8873).
215
216 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
217 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
218
219 * fileio.c: Don't assume EMACS_INT fits in off_t.
220 (emacs_lseek): New static function.
221 (Finsert_file_contents, Fwrite_region): Use it.
222 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
223
224 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
225
226 * fns.c: Don't overflow int when computing a list length.
227 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
228 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
229 truncation on 64-bit hosts. Check for QUIT every
230 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
231 faster and is responsive enough.
232 (Flength): Report an error instead of overflowing an integer.
233 (Fsafe_length): Return a float if the value is not representable
234 as a fixnum. This shouldn't happen except in contrived situations.
235 (Fnthcdr, Fsort): Don't assume list length fits in int.
236 (Fcopy_sequence): Don't assume vector length fits in int.
237
238 * alloc.c: Check that resized vectors' lengths fit in fixnums.
239 (header_size, word_size): New constants.
240 (allocate_vectorlike): Don't check size overflow here.
241 (allocate_vector): Check it here instead, since this is the only
242 caller of allocate_vectorlike that could cause overflow.
243 Check that the new vector's length is representable as a fixnum.
244
245 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
246 The previous code was bogus. For example, next_almost_prime (32)
247 returned 39, which is undesirable as it is a multiple of 3; and
248 next_almost_prime (24) returned 25, which is a multiple of 5 so
249 why was the code bothering to check for multiples of 7?
250
251 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
252
253 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
254
255 Variadic C functions now count arguments with ptrdiff_t.
256 This partly undoes my 2011-03-30 change, which replaced int with size_t.
257 Back then I didn't know that the Emacs coding style prefers signed int.
258 Also, in the meantime I found a few more instances where arguments
259 were being counted with int, which may truncate counts on 64-bit
260 machines, or EMACS_INT, which may be unnecessarily wide.
261 * lisp.h (struct Lisp_Subr.function.aMANY)
262 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
263 Arg counts are now ptrdiff_t, not size_t.
264 All variadic functions and their callers changed accordingly.
265 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
266 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
267 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
268 * callint.c (Fcall_interactively): Check arg count for overflow,
269 to avoid potential buffer overrun. Use signed char, not 'int',
270 for 'varies' array, so that we needn't bother to check its size
271 calculation for overflow.
272 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
273 * eval.c (apply_lambda):
274 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
275 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
276 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
277
278 * callint.c (Fcall_interactively): Don't use index var as event count.
279
280 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
281 * mem-limits.h (SIZE): Remove; no longer used.
282
283 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
284
285 Remove unnecessary casts.
286 * xterm.c (x_term_init):
287 * xfns.c (x_set_border_pixel):
288 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
289 These aren't needed now that we assume ANSI C.
290
291 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
292 It's more likely to cause problems (due to unsigned overflow)
293 than to cure them.
294
295 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
296
297 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
298
299 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
300
301 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
302
303 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
304
305 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
306
307 GLYPH_CODE_FACE returns EMACS_INT, not int.
308 * dispextern.h (merge_faces):
309 * xfaces.c (merge_faces):
310 * xdisp.c (get_next_display_element, next_element_from_display_vector):
311 Don't assume EMACS_INT fits in int.
312
313 * character.h (CHAR_VALID_P): Remove unused parameter.
314 * fontset.c, lisp.h, xdisp.c: All uses changed.
315
316 * editfns.c (Ftranslate_region_internal): Omit redundant test.
317
318 * fns.c (concat): Minor tuning based on overflow analysis.
319 This doesn't fix any bugs. Use int to hold character, instead
320 of constantly refetching from Emacs object. Use XFASTINT, not
321 XINT, for value known to be a character. Don't bother comparing
322 a single byte to 0400, as it's always less.
323
324 * floatfns.c (Fexpt):
325 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
326
327 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
328 for characters.
329
330 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
331
332 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
333 Without this fix, on a 64-bit host (aset S 0 4294967386) would
334 incorrectly succeed when S was a string, because 4294967386 was
335 truncated before it was used.
336
337 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
338 Otherwise, an out-of-range integer could cause undefined behavior
339 on a 64-bit host.
340
341 * composite.c: Use int, not EMACS_INT, for characters.
342 (fill_gstring_body, composition_compute_stop_pos): Use int, not
343 EMACS_INT, for values that are known to be in character range.
344 This doesn't fix any bugs but is the usual style inside Emacs and
345 may generate better code on 32-bit machines.
346
347 Make sure a 64-bit char is never passed to ENCODE_CHAR.
348 This is for reasons similar to the recent CHAR_STRING fix.
349 * charset.c (Fencode_char): Check that character arg is actually
350 a character. Pass an int to ENCODE_CHAR.
351 * charset.h (ENCODE_CHAR): Verify that the character argument is no
352 wider than 'int', as a compile-time check to prevent future regressions
353 in this area.
354
355 * character.c (char_string): Remove unnecessary casts.
356
357 Make sure a 64-bit char is never passed to CHAR_STRING.
358 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
359 by silently ignoring the top 32 bits, allowing some values
360 that were far too large to be valid characters.
361 * character.h: Include <verify.h>.
362 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
363 arguments are no wider than unsigned, as a compile-time check
364 to prevent future regressions in this area.
365 * data.c (Faset):
366 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
367 (Fsubst_char_in_region):
368 * fns.c (concat):
369 * xdisp.c (decode_mode_spec_coding):
370 Adjust to CHAR_STRING's new requirement.
371 * editfns.c (Finsert_char, Fsubst_char_in_region):
372 * fns.c (concat): Check that character args are actually
373 characters. Without this test, these functions did the wrong
374 thing with wildly out-of-range values on 64-bit hosts.
375
376 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
377 These casts should not be needed on 32-bit hosts, either.
378 * keyboard.c (read_char):
379 * lread.c (Fload): Remove casts to unsigned.
380
381 * lisp.h (UNSIGNED_CMP): New macro.
382 This fixes comparison bugs on 64-bit hosts.
383 (ASCII_CHAR_P): Use it.
384 * casefiddle.c (casify_object):
385 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
386 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
387 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
388 * dispextern.h (FACE_FROM_ID):
389 * keyboard.c (read_char): Use UNSIGNED_CMP.
390
391 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
392 not to EMACS_INT, to avoid GCC warning.
393
394 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
395
396 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
397 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
398 isn't needed on 32-bit machines.
399
400 * buffer.c (Fgenerate_new_buffer_name):
401 Use EMACS_INT for count, not int.
402 (advance_to_char_boundary): Return EMACS_INT, not int.
403
404 * data.c (Qcompiled_function): Now static.
405
406 * window.c (window_body_lines): Now static.
407
408 * image.c (gif_load): Rename local to avoid shadowing.
409
410 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
411 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
412 * alloc.c (make_save_value): Integer argument is now of type
413 ptrdiff_t, not int.
414 (mark_object): Use ptrdiff_t, not int.
415 * lisp.h (pD): New macro.
416 * print.c (print_object): Use it.
417
418 * alloc.c: Use EMACS_INT, not int, to count objects.
419 (total_conses, total_markers, total_symbols, total_vector_size)
420 (total_free_conses, total_free_markers, total_free_symbols)
421 (total_free_floats, total_floats, total_free_intervals)
422 (total_intervals, total_strings, total_free_strings):
423 Now EMACS_INT, not int. All uses changed.
424 (Fgarbage_collect): Compute overall total using a double, so that
425 integer overflow is less likely to be a problem. Check for overflow
426 when converting back to an integer.
427 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
428 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
429 These were 'int' variables that could overflow on 64-bit hosts;
430 they were never used, so remove them instead of repairing them.
431 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
432 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
433 Previously, this ceilinged at INT_MAX, but that doesn't work on
434 64-bit machines.
435 (allocate_pseudovector): Don't use EMACS_INT when int would do.
436
437 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
438 (allocate_vectorlike): Check for ptrdiff_t overflow.
439 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
440 when a (possibly-narrower) signed value would do just as well.
441 We prefer using signed arithmetic, to avoid comparison confusion.
442
443 * alloc.c: Catch some string size overflows that we were missing.
444 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
445 for convenience in STRING_BYTES_MAX.
446 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
447 The definition here is exact; the one in lisp.h was approximate.
448 (allocate_string_data): Check for string overflow. This catches
449 some instances we weren't catching before. Also, it catches
450 size_t overflow on (unusual) hosts where SIZE_MAX <= min
451 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
452 and ptrdiff_t and EMACS_INT are both 64 bits.
453
454 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
455 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
456 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
457
458 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
459
460 * alloc.c (Fmake_string): Check for out-of-range init.
461
462 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
463
464 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
465
466 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
467
468 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
469 xg_get_default_scrollbar_width.
470
471 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
472 (int_gtk_range_get_value): Move to the scroll bar part of the file.
473 (style_changed_cb): Call update_theme_scrollbar_width and call
474 x_set_scroll_bar_default_width and xg_frame_set_char_size for
475 all frames (Bug#8505).
476 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
477 Call gtk_window_set_resizable if HAVE_GTK3.
478 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
479 and height if HAVE_GTK3 (Bug#8505).
480 (scroll_bar_width_for_theme): New variable.
481 (update_theme_scrollbar_width): New function.
482 (xg_get_default_scrollbar_width): Move code to
483 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
484 (xg_initialize): Call update_theme_scrollbar_width.
485
486 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
487
488 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
489
490 2011-06-12 Martin Rudalics <rudalics@gmx.at>
491
492 * frame.c (make_frame): Call other_buffer_safely instead of
493 other_buffer.
494
495 * window.c (temp_output_buffer_show): Call display_buffer with
496 second argument Vtemp_buffer_show_specifiers and reset latter
497 immediately after the call.
498 (Vtemp_buffer_show_specifiers): New variable.
499 (auto_window_vscroll_p, next_screen_context_lines)
500 (Vscroll_preserve_screen_position): Remove leading asterisks from
501 doc-strings.
502
503 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
504
505 Fix minor problems found by GCC 4.6.0 static checking.
506 * buffer.c (Qclone_number): Remove for now, as it's unused.
507 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
508 (record_buffer): Remove unused local.
509 * frame.c (other_visible_frames, frame_buffer_list): Now static.
510 (set_frame_buffer_list): Remove; unused.
511 * frame.h (other_visible_frames): Remove decl.
512 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
513 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
514 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
515 if HAVE_GPM.
516 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
517 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
518 Define only if HAVE_GPM.
519 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
520 (update_hints_inhibit): Remove; never set. All uses removed.
521 * widgetprv.h (emacsFrameClassRec): Remove decl.
522 * window.c (delete_deletable_window): Now returns void, since it
523 wasn't returning anything.
524 (compare_window_configurations): Remove unused locals.
525 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
526 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
527 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
528 the same widths as pointers. This follows up on the 2011-05-06 patch.
529 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
530 * xterm.h: Likewise.
531 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
532
533 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
534
535 * makefile.w32-in: Update dependencies.
536 (LISP_H): Add lib/intprops.h.
537
538 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
539
540 * image.c (gif_load): Add animation frame delay to the metadata.
541 (syms_of_image): Use DEFSYM. New symbol `delay'.
542
543 2011-06-11 Martin Rudalics <rudalics@gmx.at>
544
545 * window.c (delete_deletable_window): Re-add.
546 (Fset_window_configuration): Rewrite to handle dead buffers and
547 consequently deletable windows.
548 (window_tree, Fwindow_tree): Remove. Supply functionality in
549 window.el.
550 (compare_window_configurations): Simplify code.
551
552 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
553
554 * image.c (imagemagick_load_image): Fix type mismatch.
555 (Fimagemagick_types): Likewise.
556
557 * window.h (replace_buffer_in_windows): Declare.
558
559 2011-06-11 Martin Rudalics <rudalics@gmx.at>
560
561 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
562 Qclone_number. Remove external declaration of Qdelete_window.
563 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
564 code.
565 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
566 Qbuffer_list_update_hook if allowed.
567 (Fother_buffer): Rewrite doc-string. Major rewrite for new
568 buffer list implementation.
569 (other_buffer_safely): New function.
570 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
571 calls to replace_buffer_in_windows and
572 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
573 if allowed.
574 (record_buffer): Inhibit quitting and rewrite using quittable
575 functions. Run Qbuffer_list_update_hook if allowed.
576 (Frecord_buffer, Funrecord_buffer): New functions.
577 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
578 switch-to-buffer to window.el.
579 (bury-buffer): Move to window.el.
580 (Vbuffer_list_update_hook): New variable.
581
582 * lisp.h (other_buffer_safely): Add prototype in buffer.c
583 section.
584
585 * window.h (resize_frame_windows): Move up in code.
586 (Fwindow_frame): Remove EXFUN.
587 (replace_buffer_in_all_windows): Remove prototype.
588 (replace_buffer_in_windows_safely): Add prototype.
589
590 * window.c: Declare Qdelete_window static again. Move down
591 declaration of select_count.
592 (Fnext_window, Fprevious_window): Rewrite doc-strings.
593 (Fother_window): Move to window.el.
594 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
595 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
596 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
597 window.el.
598 (replace_buffer_in_windows): Implement by calling
599 Qreplace_buffer_in_windows.
600 (replace_buffer_in_all_windows): Remove with some functionality
601 moved into replace_buffer_in_windows_safely.
602 (replace_buffer_in_windows_safely): New function.
603 (select_window_norecord, select_frame_norecord): Move in front
604 of run_window_configuration_change_hook. Remove now obsolete
605 declarations.
606 (Fset_window_buffer): Rewrite doc-string. Call
607 Qrecord_window_buffer.
608 (keys_of_window): Move binding for other-window to window.el.
609
610 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
611
612 * dispextern.h (struct image): Replace data member, whose int_val
613 and ptr_val fields were not used by anything, with a single
614 lisp_val object.
615
616 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
617 (gif_clear_image, gif_load, imagemagick_load_image)
618 (gs_clear_image, gs_load): Callers changed.
619
620 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
621
622 * buffer.h: Include <time.h>, for time_t.
623 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
624
625 Fix minor problems found by static checking.
626
627 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
628
629 Make identifiers static if they are not used in other modules.
630 * data.c (Qcompiled_function, Qframe, Qvector):
631 * image.c (QimageMagick, Qsvg):
632 * minibuf.c (Qmetadata):
633 * window.c (resize_window_check, resize_root_window): Now static.
634 * window.h (resize_window_check, resize_root_window): Remove decls.
635
636 * window.c (window_deletion_count, delete_deletable_window):
637 Remove; unused.
638 (window_body_lines): Now static.
639 (Fdelete_other_windows_internal): Mark vars as initialized.
640 Make sure 'resize_failed' is initialized.
641 (run_window_configuration_change_hook): Rename local to avoid shadowing.
642 (resize_window_apply): Remove unused local.
643 * window.h (delete_deletable_window): Remove decl.
644
645 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
646 (imagemagick_load_image): Fix pointer signedness problem by changing
647 last arg from unsigned char * to char *. All uses changed.
648 Also, fix a local for similar reasons.
649 Remove unused locals. Remove locals to avoid shadowing.
650 (fn_rsvg_handle_free): Remove; unused.
651 (svg_load, svg_load_image): Fix pointer signedness problem.
652 (imagemagick_load_image): Don't use garbage pointer image_wand.
653
654 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
655
656 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
657
658 * image.c (gif_load): Fix omitted cast error introduced by
659 2011-06-06 change.
660
661 2011-06-10 Martin Rudalics <rudalics@gmx.at>
662
663 * window.h (resize_proportionally, orig_total_lines)
664 (orig_top_line): Remove from window structure.
665 (set_window_height, set_window_width, change_window_heights)
666 (Fdelete_window): Remove prototypes.
667 (resize_frame_windows): Remove duplicate declaration.
668
669 2011-06-10 Eli Zaretskii <eliz@gnu.org>
670
671 * window.h (resize_frame_windows, resize_window_check)
672 (delete_deletable_window, resize_root_window)
673 (resize_frame_windows): Declare prototypes.
674
675 * window.c (resize_window_apply): Make definition be "static" to
676 match the prototype.
677
678 2011-06-10 Martin Rudalics <rudalics@gmx.at>
679
680 * window.c: Remove declarations of Qwindow_size_fixed,
681 window_min_size_1, window_min_size_2, window_min_size,
682 size_window, window_fixed_size_p, enlarge_window, delete_window.
683 Remove static from declaration of Qdelete_window, it's
684 temporarily needed by Fbury_buffer.
685 (replace_window): Don't assign orig_top_line and
686 orig_total_lines.
687 (Fdelete_window, delete_window): Remove. Window deletion is
688 handled by window.el.
689 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
690 Fdelete_window calls with calls to Qdelete_window.
691 (Fdelete_other_windows): Remove. Deleting other windows is
692 handled by window.el.
693 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
694 handled in window.el.
695 (window_min_size_2, window_min_size_1, window_min_size): Remove.
696 Window minimum sizes are handled in window.el.
697 (shrink_windows, size_window, set_window_height)
698 (set_window_width, change_window_heights, window_height)
699 (window_width, CURBEG, CURSIZE, enlarge_window)
700 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
701 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
702 handled in window.el.
703 (make_dummy_parent): Rename to make_parent_window and give it a
704 second argument horflag.
705 (make_window): Don't set resize_proportionally any more.
706 (Fsplit_window): Remove. Windows are split in window.el.
707 (save_restore_action, save_restore_orig_size)
708 (shrink_window_lowest_first, save_restore_orig_size): Remove.
709 Resize mini windows in window.el.
710 (grow_mini_window, shrink_mini_window): Implement by calling
711 Qresize_root_window_vertically, resize_window_check and
712 resize_window_apply.
713 (saved_window, Fset_window_configuration, save_window_save): Do
714 not handle orig_top_line, orig_total_lines, and
715 resize_proportionally.
716 (window_min_height, window_min_width): Move to window.el.
717 (keys_of_window): Move bindings for delete-other-windows,
718 split-window, delete-window and enlarge-window to window.el.
719
720 * buffer.c: Temporarily extern Qdelete_window.
721 (Fbury_buffer): Temporarily call Qdelete_window instead of
722 Fdelete_window (Fbury_buffer will move to window.el soon).
723
724 * frame.c (set_menu_bar_lines_1): Remove code handling
725 orig_top_line and orig_total_lines.
726
727 * dispnew.c (adjust_frame_glyphs_initially): Don't use
728 set_window_height but set heights directly.
729 (change_frame_size_1): Use resize_frame_windows.
730
731 * xdisp.c (init_xdisp): Don't use set_window_height but set
732 heights directly.
733
734 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
735 resize_frame_windows instead of change_window_heights and run
736 run_window_configuration_change_hook.
737
738 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
739 instead of change_window_heights and run
740 run_window_configuration_change_hook.
741
742 2011-06-09 Martin Rudalics <rudalics@gmx.at>
743
744 * window.c (replace_window): Rename second argument REPLACEMENT to
745 NEW. New third argument SETFLAG. Rewrite.
746 (delete_window, make_dummy_parent): Call replace_window with
747 third argument 1.
748 (window_list_1): Move down in code.
749 (run_window_configuration_change_hook): Move set_buffer part
750 before select_frame_norecord part in order to unwind correctly.
751 Rename count1 to count.
752 (recombine_windows, delete_deletable_window, resize_root_window)
753 (Fdelete_other_windows_internal)
754 (Frun_window_configuration_change_hook, make_parent_window)
755 (resize_window_check, resize_window_apply, Fresize_window_apply)
756 (resize_frame_windows, Fsplit_window_internal)
757 (Fdelete_window_internal, Fresize_mini_window_internal): New
758 functions.
759 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
760
761 2011-06-08 Martin Rudalics <rudalics@gmx.at>
762
763 * window.h (window): Add some new members to window structure -
764 normal_lines, normal_cols, new_total, new_normal, clone_number,
765 splits, nest, prev_buffers, next_buffers.
766 (WINDOW_TOTAL_SIZE): Move here from window.c.
767 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
768
769 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
770 Remove.
771 (make_dummy_parent): Set new members of windows structure.
772 (make_window): Move down in code. Handle new members of window
773 structure.
774 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
775 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
776 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
777 (Fset_window_prev_buffers, Fwindow_next_buffers)
778 (Fset_window_next_buffers, Fset_window_clone_number): New
779 functions.
780 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
781 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
782 Doc-string fixes.
783 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
784 Argument WINDOW can be now internal window too.
785 (Fwindow_use_time): Move up in code.
786 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
787 Rewrite doc-string.
788 (Fset_window_configuration, saved_window)
789 (Fcurrent_window_configuration, save_window_save): Handle new
790 members of window structure.
791 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
792 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
793 (syms_of_window): New Lisp objects Qrecord_window_buffer,
794 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
795 Qget_mru_window, Qresize_root_window,
796 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
797 Qauto_buffer_name; staticpro them.
798
799 2011-06-07 Martin Rudalics <rudalics@gmx.at>
800
801 * window.c (Fwindow_total_size, Fwindow_left_column)
802 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
803 (Fwindow_list_1): New functions.
804 (window_box_text_cols): Replace with window_body_cols.
805 (Fwindow_width, Fscroll_left, Fscroll_right): Use
806 window_body_cols instead of window_box_text_cols.
807 (delete_window, Fset_window_configuration): Call
808 delete_all_subwindows with window as argument.
809 (delete_all_subwindows): Take a window as argument and not a
810 structure. Rewrite.
811 (window_loop): Remove handling of GET_LRU_WINDOW and
812 GET_LARGEST_WINDOW.
813 (Fget_lru_window, Fget_largest_window): Move to window.el.
814
815 * window.h: Extern window_body_cols instead of
816 window_box_text_cols. delete_all_subwindows now takes a
817 Lisp_Object as argument.
818
819 * indent.c (compute_motion, Fcompute_motion): Use
820 window_body_cols instead of window_box_text_cols.
821
822 * frame.c (delete_frame): Call delete_all_subwindows with root
823 window as argument.
824
825 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
826
827 * fns.c (Fputhash): Document return value.
828
829 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
830
831 * image.c (gif_load): Implement gif89a spec "no disposal" method.
832
833 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
834
835 Cons<->int and similar integer overflow fixes (Bug#8794).
836
837 Check for overflow when converting integer to cons and back.
838 * charset.c (Fdefine_charset_internal, Fdecode_char):
839 Use cons_to_unsigned to catch overflow.
840 (Fencode_char): Use INTEGER_TO_CONS.
841 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
842 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
843 * data.c (long_to_cons, cons_to_long): Remove.
844 (cons_to_unsigned, cons_to_signed): New functions.
845 These signal an error for invalid or out-of-range values.
846 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
847 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
848 * font.c (Ffont_variation_glyphs):
849 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
850 * lisp.h: Include <intprops.h>.
851 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
852 (cons_to_signed, cons_to_unsigned): New decls.
853 (long_to_cons, cons_to_long): Remove decls.
854 * undo.c (record_first_change): Use INTEGER_TO_CONS.
855 (Fprimitive_undo): Use CONS_TO_INTEGER.
856 * xfns.c (Fx_window_property): Likewise.
857 * xselect.c: Include <limits.h>.
858 (x_own_selection, selection_data_to_lisp_data):
859 Use INTEGER_TO_CONS.
860 (x_handle_selection_request, x_handle_selection_clear)
861 (x_get_foreign_selection, Fx_disown_selection_internal)
862 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
863 (lisp_data_to_selection_data): Use cons_to_unsigned.
864 (x_fill_property_data): Use cons_to_signed.
865 Report values out of range.
866
867 Check for buffer and string overflow more precisely.
868 * buffer.h (BUF_BYTES_MAX): New macro.
869 * lisp.h (STRING_BYTES_MAX): New macro.
870 * alloc.c (Fmake_string):
871 * character.c (string_escape_byte8):
872 * coding.c (coding_alloc_by_realloc):
873 * doprnt.c (doprnt):
874 * editfns.c (Fformat):
875 * eval.c (verror):
876 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
877 since they may not be the same number.
878 * editfns.c (Finsert_char):
879 * fileio.c (Finsert_file_contents):
880 Likewise for BUF_BYTES_MAX.
881
882 * image.c: Use ptrdiff_t, not int, for sizes.
883 (slurp_file): Switch from int to ptrdiff_t.
884 All uses changed.
885 (slurp_file): Check that file size fits in both size_t (for
886 malloc) and ptrdiff_t (for sanity and safety).
887
888 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
889 if b->modtime has its maximal value.
890
891 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
892
893 Don't assume time_t can fit into int.
894 * buffer.h (struct buffer.modtime): Now time_t, not int.
895 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
896 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
897
898 Minor fixes for signed vs unsigned integers.
899 * character.h (MAYBE_UNIFY_CHAR):
900 * charset.c (maybe_unify_char):
901 * keyboard.c (read_char, reorder_modifiers):
902 XINT -> XFASTINT, since the integer must be nonnegative.
903 * ftfont.c (ftfont_spec_pattern):
904 * keymap.c (access_keymap, silly_event_symbol_error):
905 XUINT -> XFASTINT, since the integer must be nonnegative.
906 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
907 since it makes no difference and we prefer signed.
908 * keyboard.c (record_char): Use XUINT when all the neighbors do.
909 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
910 nonnegative.
911
912 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
913
914 * window.h (Fwindow_frame): Declare.
915
916 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
917
918 * alloc.c: Simplify handling of large-request failures (Bug#8800).
919 (SPARE_MEMORY): Always define.
920 (LARGE_REQUEST): Remove.
921 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
922
923 2011-06-06 Martin Rudalics <rudalics@gmx.at>
924
925 * lisp.h: Move EXFUNS for Fframe_root_window,
926 Fframe_first_window and Fset_frame_selected_window to window.h.
927
928 * window.h: Move EXFUNS for Fframe_root_window,
929 Fframe_first_window and Fset_frame_selected_window here from
930 lisp.h.
931
932 * frame.c (Fwindow_frame, Fframe_first_window)
933 (Fframe_root_window, Fframe_selected_window)
934 (Fset_frame_selected_window): Move to window.c.
935 (Factive_minibuffer_window): Move to minibuf.c.
936 (Fother_visible_frames_p): New function.
937
938 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
939
940 * window.c (decode_window, decode_any_window): Move up in code.
941 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
942 (inhibit_frame_unsplittable): Remove unused variable.
943 (Fwindow_buffer): Move up and rewrite doc-string.
944 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
945 (Fwindow_prev): New functions.
946 (Fwindow_frame): Move here from frame.c. Accept any window as
947 argument.
948 (Fframe_root_window, Fframe_first_window)
949 (Fframe_selected_window): Move here from frame.c. Accept frame
950 or arbitrary window as argument. Update doc-strings.
951 (Fminibuffer_window): Move up in code.
952 (Fwindow_minibuffer_p): Move up in code and simplify.
953 (Fset_frame_selected_window): Move here from frame.c.
954 Marginal rewrite.
955 (Fselected_window, select_window, Fselect_window): Move up in
956 code. Minor doc-string fixes.
957
958 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
959
960 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
961 Do not assume that spare memory exists; that assumption is valid
962 only if SYSTEM_MALLOC.
963 (LARGE_REQUEST): New macro, so that the issue of large requests
964 is separated from the issue of spare memory.
965
966 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
967
968 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
969 format. (Bug#8806)
970
971 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
972
973 * xfns.c (x_set_scroll_bar_default_width): Move declarations
974 before statements.
975
976 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
977
978 * gtkutil.c (xg_get_default_scrollbar_width): New function.
979
980 * gtkutil.h: Declare xg_get_default_scrollbar_width.
981
982 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
983 min width by calling x_set_scroll_bar_default_width (Bug#8505).
984
985 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
986
987 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
988
989 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
990
991 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
992 (x_clipboard_manager_save): Add return value.
993 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
994 New error handlers.
995 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
996 Obey Vx_select_enable_clipboard_manager. Catch errors in
997 x_clipboard_manager_save (Bug#8779).
998 (Vx_select_enable_clipboard_manager): New variable.
999 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1000
1001 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1002
1003 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1004
1005 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1006
1007 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1008 in the current matrix if keep_current_p is non-zero.
1009
1010 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1011
1012 * bidi.c (bidi_level_of_next_char): Fix last change.
1013
1014 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1015
1016 Support bidi reordering of text covered by display properties.
1017
1018 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1019 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1020 (bidi_cache_search, bidi_cache_iterator_state)
1021 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1022 (bidi_level_of_next_char, bidi_move_to_visually_next):
1023 Support character positions inside a run of characters covered by a
1024 display string.
1025 (bidi_paragraph_init, bidi_resolve_explicit_1)
1026 (bidi_level_of_next_char): Call bidi_fetch_char and
1027 bidi_fetch_char_advance instead of FETCH_CHAR and
1028 FETCH_CHAR_ADVANCE.
1029 (bidi_init_it): Initialize new members.
1030 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1031 definitions.
1032 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1033 instead of using explicit *_CHAR codes.
1034 (bidi_resolve_explicit, bidi_resolve_weak):
1035 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1036 bidirectional text is supported only in multibyte buffers.
1037 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1038 it to initialize the frame_window_p member of struct bidi_it.
1039 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1040 (bidi_resolve_explicit, bidi_resolve_weak)
1041 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1042 bidi_it->nchars is non-positive.
1043 (bidi_level_of_next_char): Don't try to lookup the cache for the
1044 next/previous character if nothing is cached there yet, or if we
1045 were just reseat()'ed to a new position.
1046
1047 * xdisp.c (set_cursor_from_row): Set start and stop points
1048 according to the row's direction when priming the loop that looks
1049 for the glyph on which to display cursor.
1050 (single_display_spec_intangible_p): Function deleted.
1051 (display_prop_intangible_p): Reimplement to call
1052 handle_display_spec instead of single_display_spec_intangible_p.
1053 Accept 3 additional arguments needed by handle_display_spec.
1054 This fixes incorrect cursor motion across display property with complex
1055 values: lists, `(when COND...)' forms, etc.
1056 (single_display_spec_string_p): Support property values that are
1057 lists with the argument STRING its top-level element.
1058 (display_prop_string_p): Fix the condition for processing a
1059 property that is a list to be consistent with handle_display_spec.
1060 (handle_display_spec): New function, refactored from the
1061 last portion of handle_display_prop.
1062 (compute_display_string_pos): Accept additional argument
1063 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1064 value of a `display' property is a "replacing spec".
1065 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1066 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1067 the display property, but just return a value indicating whether
1068 the display property will replace the characters it covers.
1069 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1070 frame_window_p members of struct bidi_it.
1071 (compute_display_string_pos, compute_display_string_end):
1072 New functions.
1073 (push_it): Accept second argument POSITION, where pop_it should
1074 jump to continue iteration.
1075 (reseat_1): Initialize bidi_it.disp_pos.
1076
1077 * keyboard.c (adjust_point_for_property): Adjust the call to
1078 display_prop_intangible_p to its new signature.
1079
1080 * dispextern.h (struct bidi_it): New member frame_window_p.
1081 (bidi_init_it): Update prototypes.
1082 (display_prop_intangible_p): Update prototype.
1083 (compute_display_string_pos, compute_display_string_end):
1084 Declare prototypes.
1085 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1086 EMACS_INT.
1087
1088 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1089
1090 Malloc failure behavior now depends on size of allocation.
1091 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1092 * lisp.h: Change signatures accordingly.
1093 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1094 All callers changed. (Bug#8762)
1095
1096 * gnutls.c: Use Emacs's memory allocators.
1097 Without this change, the gnutls library would invoke malloc etc.
1098 directly, which causes problems on non-SYNC_INPUT hosts, and which
1099 runs afoul of improving memory_full behavior. (Bug#8761)
1100 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1101 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1102 xfree instead of the default malloc, realloc, free.
1103 (Fgnutls_boot): No need to check for memory allocation failure,
1104 since xmalloc does that for us.
1105
1106 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1107 * category.c (hash_get_category_set):
1108 * ccl.c (ccl_driver):
1109 * charset.c (Fdefine_charset_internal):
1110 * charset.h (struct charset.hash_index):
1111 * composite.c (get_composition_id, gstring_lookup_cache)
1112 (composition_gstring_put_cache):
1113 * composite.h (struct composition.hash_index):
1114 * dispextern.h (struct image.hash):
1115 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1116 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1117 (hashfn_equal, hashfn_user_defined, make_hash_table)
1118 (maybe_resize_hash_table, hash_lookup, hash_put)
1119 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1120 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1121 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1122 * image.c (make_image, search_image_cache, lookup_image)
1123 (xpm_put_color_table_h):
1124 * lisp.h (struct Lisp_Hash_Table):
1125 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1126 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1127 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1128 * alloc.c (allocate_vectorlike):
1129 Check for overflow in vector size calculations.
1130 * ccl.c (ccl_driver):
1131 Check for overflow when converting EMACS_INT to int.
1132 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1133 need to be updated by these changes.
1134 * fns.c (make_hash_table, maybe_resize_hash_table):
1135 Check for integer overflow with large hash tables.
1136 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1137 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1138 (SXHASH_REDUCE): New macro.
1139 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1140 Use it instead of discarding useful hash info with large hash values.
1141 (sxhash_float): New function.
1142 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1143 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1144 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1145 Rewrite to use FIXNUM_BITS, as this simplifies things.
1146 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1147 Adjust signatures to match updated version of code.
1148 (consing_since_gc): Now EMACS_INT, since a single hash table can
1149 use more than INT_MAX bytes.
1150
1151 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1152
1153 Make it possible to build with GCC-4.6+ -O2 -flto.
1154
1155 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1156
1157 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1158
1159 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1160 Call minibuffer-inactive-mode.
1161
1162 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1165 Update dependencies.
1166
1167 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1168
1169 * data.c (init_data): Remove code for UTS, this system is not
1170 supported anymore.
1171
1172 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1173
1174 Don't force ./temacs to start in terminal mode.
1175
1176 * frame.c (make_initial_frame): Initialize faces in all cases, not
1177 only when CANNOT_DUMP is defined.
1178 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1179
1180 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1181
1182 * dispnew.c (add_window_display_history): Use const for the string
1183 pointer. Remove declaration, not needed.
1184
1185 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 Use 'inline', not 'INLINE'.
1188 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1189 * alloc.c, fontset.c (INLINE): Remove.
1190 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1191 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1192 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1193 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1194 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1195
1196 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1197
1198 Make it possible to run ./temacs.
1199
1200 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1201 syms_of_callproc does the same thing. Remove test for
1202 "initialized", do it in the caller.
1203 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1204
1205 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1206
1207 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1208 (read_minibuf): Use get_minibuffer.
1209 (syms_of_minibuf): Use DEFSYM.
1210 (Qmetadata): New var.
1211 * data.c (Qbuffer): Don't make it static.
1212 (syms_of_data): Use DEFSYM.
1213
1214 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1217 (CCL_CODE_MIN): New macro.
1218
1219 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1222
1223 * eval.c (Qdebug): Now static.
1224 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1225 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1226 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1227
1228 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1229
1230 * image.c: Various fixes to ImageMagick code comments.
1231 (Fimagemagick_types): Doc fix.
1232
1233 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1234
1235 Minor fixes prompted by GCC 4.6.0 warnings.
1236
1237 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1238
1239 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1240 (x_clipboard_manager_save_all): Move extern decl to ...
1241 * xterm.h: ... here, so that it can be checked for consistency.
1242
1243 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1244
1245 * xselect.c (x_clipboard_manager_save_frame)
1246 (x_clipboard_manager_save_all): New functions.
1247 (Fx_clipboard_manager_save): Lisp function deleted.
1248
1249 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1250 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1251
1252 * xterm.h: Update prototype.
1253
1254 2011-05-28 William Xu <william.xwl@gmail.com>
1255
1256 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1257 exiting (Bug#8239).
1258
1259 2011-05-28 Jim Meyering <meyering@redhat.com>
1260
1261 Avoid a sign-extension bug in crypto_hash_function.
1262 * fns.c (to_uchar): Define.
1263 (crypto_hash_function): Use it to convert some newly-signed
1264 variables to unsigned, to avoid sign-extension bugs. For example,
1265 without this change, (md5 "truc") would evaluate to
1266 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1267 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1268 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1269
1270 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 Integer overflow fixes.
1273
1274 * dbusbind.c: Serial number integer overflow fixes.
1275 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1276 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1277 to hold a serial number that is too large for a fixnum.
1278 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1279 Check for serial numbers out of range. Decode any serial number
1280 that was so large that it became a float. (Bug#8722)
1281
1282 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1283 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1284 Use XFASTINT rather than XUINT when numbers are nonnegative.
1285 (xd_append_arg, Fdbus_method_return_internal):
1286 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1287 arguments, check that Lisp number is nonnegative, rather than
1288 silently wrapping negative numbers around. (Bug#8722)
1289 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1290 (Bug#8722)
1291
1292 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1293
1294 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1295
1296 ccl: add integer overflow checks
1297 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1298 (IN_INT_RANGE): New macros.
1299 (ccl_driver): Use them to check for integer overflow when
1300 decoding a CCL program. Many of the new checks are whether XINT (x)
1301 fits in int; it doesn't always, on 64-bit hosts. The new version
1302 doesn't catch all possible integer overflows, but it's an
1303 improvement. (Bug#8719)
1304
1305 * alloc.c (make_event_array): Use XINT, not XUINT.
1306 There's no need for unsigned here.
1307
1308 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1309 This follows up to the 2011-05-06 change that substituted uintptr_t
1310 for EMACS_INT. This case wasn't caught back then.
1311
1312 Rework Fformat to avoid integer overflow issues.
1313 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1314 now (part of C89). Include <verify.h>.
1315 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1316 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1317 (Fformat): Avoid the prepass trying to compute sizes; it was only
1318 approximate and thus did not catch overflow reliably. Instead, walk
1319 through the format just once, formatting and computing sizes as we go,
1320 checking for integer overflow at every step, and allocating a larger
1321 buffer as needed. Keep track separately whether the format is
1322 multibyte. Keep only the most-recently calculated precision, rather
1323 than them all. Record whether each argument has been converted to
1324 string. Use EMACS_INT, not int, for byte and char and arg counts.
1325 Support field widths and precisions larger than INT_MAX. Avoid
1326 sprintf's undefined behavior with conversion specifications such as %#d
1327 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1328 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1329 formatting out-of-range floating point numbers with int
1330 formats. (Bug#8668)
1331
1332 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1333
1334 * data.c: Avoid integer truncation in expressions involving floats.
1335 * data.c: Include <intprops.h>.
1336 (arith_driver): When there's an integer overflow in an expression
1337 involving floating point, convert the integers to floating point
1338 so that the resulting value does not suffer from catastrophic
1339 integer truncation. For example, on a 64-bit host (* 4
1340 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1341 Do not rely on undefined behavior after integer overflow.
1342
1343 merge count_size_as_multibyte, parse_str_to_multibyte
1344 * character.c, character.h (count_size_as_multibyte):
1345 Rename from parse_str_to_multibyte; all uses changed.
1346 Check for integer overflow.
1347 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1348 since it's now a duplicate of the other. This is more of
1349 a character than a buffer op, so better that it's in character.c.
1350 * fns.c, print.c: Adjust to above changes.
1351
1352 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1353
1354 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1355
1356 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1359 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1360 (x_clipboard_manager_save): Now static.
1361 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1362
1363 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1364 (crypto_hash_function): Now static.
1365 Fix pointer signedness problems. Avoid unnecessary initializations.
1366
1367 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1368
1369 * termhooks.h (Vselection_alist): Make it terminal-local.
1370
1371 * terminal.c (create_terminal): Initialize it.
1372
1373 * xselect.c: Support for clipboard managers.
1374 (Vselection_alist): Move to termhooks.h as terminal-local var.
1375 (LOCAL_SELECTION): New macro.
1376 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1377 (symbol_to_x_atom): Remove gratuitous arg.
1378 (x_handle_selection_request, lisp_data_to_selection_data)
1379 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1380 (x_own_selection, x_get_local_selection, x_convert_selection):
1381 New arg, specifying work frame. Use terminal-local Vselection_alist.
1382 (some_frame_on_display): Delete unused function.
1383 (Fx_own_selection_internal, Fx_get_selection_internal)
1384 (Fx_disown_selection_internal, Fx_selection_owner_p)
1385 (Fx_selection_exists_p): New optional frame arg.
1386 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1387 (x_handle_selection_clear): Don't treat other terminals with the
1388 same keyboard specially. Use the terminal-local Vselection_alist.
1389 (x_clear_frame_selections): Use Frun_hook_with_args.
1390
1391 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1392
1393 * xterm.h: Add support for those atoms.
1394
1395 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1396
1397 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1398 (converted_selections, conversion_fail_tag): New global variables.
1399 (x_selection_request_lisp_error): Free the above.
1400 (x_get_local_selection): Remove unnecessary code.
1401 (x_reply_selection_request): Args changed; handle arbitrary array
1402 of converted selections stored in converted_selections.
1403 Separate the XChangeProperty and SelectionNotify steps.
1404 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1405 (x_convert_selection): New function.
1406 (x_handle_selection_event): Simplify.
1407 (x_get_foreign_selection): Don't ignore incoming requests while
1408 waiting for an answer; this will fail when we implement
1409 SAVE_TARGETS, and seems unnecessary anyway.
1410 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1411 (Vx_sent_selection_functions): Doc fix.
1412
1413 2011-05-26 Leo Liu <sdl.web@gmail.com>
1414
1415 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1416
1417 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1418
1419 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1420
1421 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1422 for fringe update if it has periodic bitmap.
1423 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1424 and fringe_bitmap_periodic_p.
1425
1426 * fringe.c (get_fringe_bitmap_data): New function.
1427 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1428 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1429 row. Mark glyph row for fringe update if periodicity changed.
1430
1431 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1432 for fringe update unless it has periodic bitmap.
1433
1434 2011-05-25 Kenichi Handa <handa@m17n.org>
1435
1436 * xdisp.c (get_next_display_element): Set correct it->face_id for
1437 a static composition.
1438
1439 2011-05-24 Leo Liu <sdl.web@gmail.com>
1440
1441 * deps.mk (fns.o):
1442 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1443
1444 * fns.c (crypto_hash_function, Fsha1): New function.
1445 (Fmd5): Use crypto_hash_function.
1446 (syms_of_fns): Add Ssha1.
1447
1448 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1449
1450 * gnutls.c: Remove unused macros.
1451 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1452 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1453 Remove macros that are defined and never used.
1454 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1455
1456 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1457
1458 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1459 (Fx_get_selection_internal): Minor cleanup.
1460 (Fx_own_selection_internal): Rename arguments for consistency with
1461 select.el.
1462
1463 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1466
1467 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1468
1469 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1470
1471 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1472
1473 * dispnew.c (scrolling_window): Don't exclude the case that the
1474 last enabled row in the desired matrix touches the bottom boundary.
1475
1476 2011-05-21 Glenn Morris <rgm@gnu.org>
1477
1478 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1479 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1480 and add some more files.
1481
1482 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1483
1484 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1485 report_file_error introduced by the change from 2011-05-07.
1486
1487 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1488
1489 * systime.h (Time): Define only if emacs is defined.
1490 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1491 where the include path doesn't have X11/X.h by default. See
1492 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1493
1494 2011-05-20 Kenichi Handa <handa@m17n.org>
1495
1496 * composite.c (find_automatic_composition): Fix previous change.
1497
1498 2011-05-20 Glenn Morris <rgm@gnu.org>
1499
1500 * lisp.mk: New file, split from Makefile.in.
1501 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1502 (shortlisp): Remove.
1503 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1504
1505 2011-05-19 Glenn Morris <rgm@gnu.org>
1506
1507 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1508 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1509 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1510 (lisp): Set the order to that of loadup.el.
1511 (shortlisp): Make it a copy of $lisp.
1512 (SOME_MACHINE_LISP): Remove.
1513 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1514 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1515
1516 2011-05-18 Kenichi Handa <handa@m17n.org>
1517
1518 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1519 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1520 (find_automatic_composition): Mostly rewrite for efficiency.
1521
1522 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1523
1524 * makefile.w32-in: Update dependencies.
1525
1526 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1527
1528 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1529 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1530
1531 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 Fix some integer overflow issues, such as string length overflow.
1534
1535 * insdel.c (count_size_as_multibyte): Check for string overflow.
1536
1537 * character.c (lisp_string_width): Check for string overflow.
1538 Use EMACS_INT, not int, for string indexes and lengths; in
1539 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1540 the resulting string length overflows an EMACS_INT; instead,
1541 report a string overflow if no precision given. When checking for
1542 precision exhaustion, use a check that cannot possibly have
1543 integer overflow. (Bug#8675)
1544 * character.h (lisp_string_width): Adjust to new signature.
1545
1546 * alloc.c (string_overflow): New function.
1547 (Fmake_string): Use it. This doesn't change behavior, but saves
1548 a few bytes and will simplify future changes.
1549 * character.c (string_escape_byte8): Likewise.
1550 * lisp.h (string_overflow): New decl.
1551
1552 Fixups, following up to the user-interface timestamp change.
1553 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1554 for UI timestamps, instead of unsigned long.
1555 * msdos.c (mouse_get_pos): Likewise.
1556 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1557 * w32gui.h (Time): Define by including "systime.h" rather than by
1558 declaring it ourselves. (Bug#8664)
1559
1560 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1561 * image.c (clear_image_cache): Likewise.
1562
1563 * term.c (term_mouse_position): Don't assume time_t wraparound.
1564
1565 Be more systematic about user-interface timestamps.
1566 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1567 and sometimes 'EMACS_UINT', to represent these timestamps.
1568 This change causes it to use 'Time' uniformly, as that's what X uses.
1569 This makes the code easier to follow, and makes it easier to catch
1570 integer overflow bugs such as Bug#8664.
1571 * frame.c (Fmouse_position, Fmouse_pixel_position):
1572 Use Time, not unsigned long, for user-interface timestamps.
1573 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1574 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1575 * keyboard.h (last_event_timestamp): Likewise.
1576 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1577 * menu.h (xmenu_show): Likewise.
1578 * term.c (term_mouse_position): Likewise.
1579 * termhooks.h (struct input_event.timestamp): Likewise.
1580 (struct terminal.mouse_position_hook): Likewise.
1581 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1582 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1583 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1584 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1585 what it was before.
1586 * menu.h, termhooks.h: Include "systime.h", for Time.
1587
1588 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1589 Don't assume that the difference between two unsigned long values
1590 can fit into an integer. At this point, we know button_down_time
1591 <= event->timestamp, so the difference must be nonnegative, so
1592 there's no need to cast the result if double-click-time is
1593 nonnegative, as it should be; check that it's nonnegative, just in
1594 case. This bug is triggered when events are more than 2**31 ms
1595 apart (about 25 days). (Bug#8664)
1596
1597 * xselect.c (last_event_timestamp): Remove duplicate decl.
1598 (x_own_selection): Remove needless cast to unsigned long.
1599
1600 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1601 that always fit in int. Use a sentinel instead of a counter, to
1602 avoid a temp and to allay GCC's concerns about possible int overflow.
1603 * frame.h (struct frame): Use int for menu_bar_items_used
1604 instead of EMACS_INT, since it always fits in int.
1605
1606 * menu.c (grow_menu_items): Check for int overflow.
1607
1608 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1609
1610 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1611 Before, the code was not consistent. These values cannot exceed
1612 2**31 - 1 so there's no need to make them unsigned.
1613 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1614 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1615 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1616 as modifiers.
1617 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1618
1619 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1620 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1621 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1622 presumably because the widths might not match.
1623
1624 * window.c (size_window): Avoid needless test at loop start.
1625
1626 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1627
1628 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1629
1630 2011-05-12 Drew Adams <drew.adams@oracle.com>
1631
1632 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1633
1634 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1635
1636 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1637 `width' to `bar_area_x' and `bar_area_width', respectively.
1638 (x_scroll_run): Take account of fringe background extension.
1639
1640 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1641 Rename local vars `left' and `width' to `bar_area_x' and
1642 `bar_area_width', respectively.
1643 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1644 background extension.
1645
1646 2011-05-10 Jim Meyering <meyering@redhat.com>
1647
1648 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1649
1650 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1651
1652 * image.c (Finit_image_library): Return t for built-in image types,
1653 like pbm and xbm. (Bug#8640)
1654
1655 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1656
1657 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1658
1659 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1660
1661 * w32console.c (Fset_screen_color): Doc fix.
1662 (Fget_screen_color): New function.
1663 (syms_of_ntterm): Defsubr it.
1664
1665 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1666 unlink the temporary file if Fcall_process didn't create it in the
1667 first place.
1668 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1669 child process will be redirected to a file specified with `:file'.
1670 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1671 cue to call_process_cleanup not to close that handle.
1672
1673 2011-05-07 Ben Key <bkey76@gmail.com>
1674
1675 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1676 one of two shell specific rules, either bootstrap-temacs-CMD or
1677 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1678 to the previous implementation of the bootstrap-temacs rule.
1679 The bootstrap-temacs-CMD rule is similar to the previous
1680 implementation of the bootstrap-temacs rule except that it
1681 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1682 variable.
1683
1684 These changes, along with some changes to nt/configure.bat,
1685 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1686 earlier fix to add support for --cflags and --ldflags options
1687 that include quotes so that it works whether make uses cmd or
1688 sh as the shell.
1689
1690 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1691
1692 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1693 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1694 is a constant.
1695 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1696 a string. Handle both cases.
1697 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1698 (Fdbus_register_method): Use Qinvalid_function.
1699
1700 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1701
1702 * makefile.w32-in: Update dependencies.
1703 (LISP_H): Add inttypes.h and stdin.h.
1704 (PROCESS_H): Add unistd.h.
1705
1706 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1707
1708 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1709 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1710
1711 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1714
1715 * term.c (vfatal): Remove stray call to va_end.
1716 It's not needed and the C Standard doesn't allow it here anyway.
1717
1718 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1719 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1720
1721 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1722 bytes.
1723
1724 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1725
1726 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1727
1728 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1729
1730 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1731
1732 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1733
1734 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1735 * charset.c (Fdefine_charset_internal): Don't initialize
1736 charset.code_space[15]. The value was garbage, on hosts with
1737 32-bit int (Bug#8600).
1738
1739 * lread.c (read_integer): Be more consistent with string-to-number.
1740 Use string_to_number to do the actual conversion; this avoids
1741 rounding errors and fixes some other screwups. Without this fix,
1742 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1743 (digit_to_number): Move earlier, for benefit of read_integer.
1744 Return -1 if the digit is out of range for the base, -2 if it is
1745 not a digit in any supported base. (Bug#8602)
1746
1747 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1748
1749 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1750 to match comment at start of function. This also removes a
1751 GCC warning about overflow in a 32+64-bit port.
1752
1753 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1754
1755 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1756 Reported by Stefan Monnier in
1757 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1758 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1759 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1760
1761 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1762 (EMACS_UINTPTR): Likewise, with uintptr_t.
1763
1764 * lisp.h: Prefer 64-bit EMACS_INT if available.
1765 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1766 on 32-bit hosts that have 64-bit int, so that they can access
1767 large files.
1768 However, temporarily disable this change unless the temporary
1769 symbol WIDE_EMACS_INT is defined.
1770
1771 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1772
1773 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1774 This removes an assumption that EMACS_INT and long are the same
1775 width as pointers. The assumption is true for Emacs porting targets
1776 now, but we want to make other targets possible.
1777 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1778 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1779 In the rest of the code, change types of integers that hold casted
1780 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1781 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1782 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1783 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1784 No need to cast type when ORing.
1785 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1786 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1787 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1788 assume EMACS_INT is the same width as char *.
1789 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1790 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1791 Remove no-longer-needed casts.
1792 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1793 (xg_tool_bar_help_callback, xg_make_tool_item):
1794 Use EMACS_INTPTR to hold an integer
1795 that will be cast to void *; this can avoid a GCC warning
1796 if EMACS_INT is not the same width as void *.
1797 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1798 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1799 (current_message_1, set_message_1):
1800 Use a local to convert to proper width without a cast.
1801 * xmenu.c (dialog_selection_callback): Likewise.
1802
1803 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1804 Also, don't assume VALBITS / RAND_BITS is less than 5,
1805 and don't rely on undefined behavior when shifting a 1 left into
1806 the sign bit.
1807 * lisp.h (get_random): Change signature to match.
1808
1809 * lread.c (hash_string): Use size_t, not int, for hash computation.
1810 Normally we prefer signed values; but hashing is special, because
1811 it's better to use unsigned division on hash table sizes so that
1812 the remainder is nonnegative. Also, size_t is the natural width
1813 for hashing into memory. The previous code used 'int', which doesn't
1814 retain enough info to hash well into very large tables.
1815 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1816
1817 * dbusbind.c: Don't possibly lose pointer info when converting.
1818 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1819 Use XPNTR rather than XHASH, so that the high-order bits of
1820 the pointer aren't lost when converting through void *.
1821
1822 * eval.c (Fautoload): Don't double-shift a pointer.
1823
1824 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1825
1826 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1827
1828 * gnutls.c (DEF_GNUTLS_FN):
1829 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1830
1831 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1832
1833 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1834 marker. (Bug#8610)
1835
1836 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1837
1838 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1839 New version that can reserve upto 2GB of heap space.
1840
1841 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1842
1843 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1844
1845 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1846
1847 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1848 `gnutls_certificate_set_x509_key_file'.
1849
1850 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1851
1852 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1853 Update dependencies.
1854
1855 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1856
1857 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1858 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1859 Remove unused parameter `fildes'.
1860 * process.c (read_process_output, send_process): Don't pass it.
1861
1862 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1863
1864 Fix previous change: the library cache is defined in w32.c.
1865 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1866 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1867
1868 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1869
1870 Implement dynamic loading of GnuTLS on Windows.
1871
1872 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1873 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1874 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1875 Declare.
1876
1877 * gnutls.c (Qgnutls_dll): Define.
1878 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1879 (gnutls_*): Declare function pointers.
1880 (init_gnutls_functions): New function to initialize function pointers.
1881 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1882 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1883 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1884 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1885 (emacs_gnutls_write, emacs_gnutls_read)
1886 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1887 (Fgnutls_available_p): New function.
1888 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1889 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1890 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1891
1892 * image.c: Include w32.h.
1893 (Vimage_type_cache): Delete.
1894 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1895 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1896 (w32_delayed_load): Move to w32.c.
1897
1898 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1899
1900 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1901 (w32_delayed_load): Move from image.c. When loading a library, record
1902 its filename in the :loaded-from property of the library id.
1903 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1904 Initialize and staticpro them.
1905 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1906
1907 * process.c: Include lisp.h before w32.h, not after.
1908 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1909 instead of gnutls_record_check_pending.
1910
1911 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1912
1913 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1914
1915 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1916 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1917 as passed in.
1918
1919 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1920
1921 * xterm.c (x_set_frame_alpha): Do not set property on anything
1922 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1923
1924 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1925
1926 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1927
1928 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1929
1930 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1931 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1932 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1933 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1934 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1935 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1936 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1937 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1938 (Qgnutls_bootprop_callbacks_verify): Make static.
1939
1940 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1941
1942 * callproc.c: Indentation fixup.
1943
1944 * sysdep.c (wait_for_termination_1): Make static.
1945 (wait_for_termination, interruptible_wait_for_termination):
1946 Move after wait_for_termination_1.
1947
1948 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1949
1950 * sysdep.c (interruptible_wait_for_termination): New function
1951 which is like wait_for_termination, but allows keyboard
1952 interruptions.
1953
1954 * callproc.c (Fcall_process): Add (:file "file") as an option for
1955 the STDOUT buffer.
1956 (Fcall_process_region): Ditto.
1957
1958 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1959
1960 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1961 rather than `XVECTOR (FOO)->size'.
1962
1963 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1964 inttypes.h, as a gnulib replacement is used if it not available in
1965 system headers.
1966
1967 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1968
1969 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1970 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1971 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1972
1973 * coding.c (coding_alloc_by_realloc): Error out if destination
1974 will grow beyond MOST_POSITIVE_FIXNUM.
1975 (decode_coding_emacs_mule): Abort if there isn't enough place in
1976 charbuf for the composition carryover bytes. Reserve an extra
1977 space for up to 2 characters produced in a loop.
1978 (decode_coding_iso_2022): Abort if there isn't enough place in
1979 charbuf for the composition carryover bytes.
1980
1981 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1982
1983 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1984 aborting when %lld or %lll format is passed.
1985 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1986 %llo or %llx format is passed. (Bug#8545)
1987
1988 * window.c (window_scroll_line_based): Use a marker instead of
1989 simple variables to record original value of point. (Bug#7952)
1990
1991 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1992 produced by %s or %c overflows available buffer space. (Bug#8545)
1993
1994 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1995
1996 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1997 (SIZE_MAX): Move defn after all includes, as they might #define it.
1998
1999 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2000
2001 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2002
2003 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2004
2005 * keyboard.c (Qdelayed_warnings_hook): Define.
2006 (command_loop_1): Run `delayed-warnings-hook'
2007 if Vdelayed_warnings_list is non-nil.
2008 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2009 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2010
2011 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2012
2013 * doprnt.c (doprnt): Don't return value smaller than the buffer
2014 size if the message was truncated. (Bug#8545).
2015
2016 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2017
2018 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2019 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2020
2021 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2022
2023 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2024
2025 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2026
2027 * makefile.w32-in: Update dependencies.
2028
2029 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2030
2031 Improve `doprnt' and its usage. (Bug#8545)
2032 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2033 `format_end'. Remove support for %l as a conversion specifier.
2034 Don't use xrealloc. Improve diagnostics when the %l size modifier
2035 is used. Update the commentary.
2036
2037 * eval.c (verror): Simplify calculation of size_t.
2038
2039 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2040 messages.
2041
2042 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2043
2044 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2045 change.
2046
2047 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2048
2049 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2050 This makes this file independent of the recent pseudovector change.
2051
2052 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2055
2056 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2057 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2058 Remove unused local.
2059 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2060
2061 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2062 GCC 4.6.0 optimizes based on type-based alias analysis.
2063 For example, if b is of type struct buffer * and v of type struct
2064 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2065 != &v->size, and therefore "v->size = 1; b->size = 2; return
2066 v->size;" must therefore return 1. This assumption is incorrect
2067 for Emacs, since it type-puns struct Lisp_Vector * with many other
2068 types. To fix this problem, this patch adds a new type struct
2069 vectorlike_header that documents the constraints on layout of vectors
2070 and pseudovectors, and helps optimizing compilers not get fooled
2071 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2072 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2073 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2074 the size member.
2075 (XSETPVECTYPE): Rewrite in terms of new macro.
2076 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2077 This is a bit clearer, and further avoids the possibility of
2078 undesirable aliasing.
2079 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2080 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2081 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2082 since Lisp_Subr is a special case (no "next" field).
2083 (ASIZE): Now uses header.size rather than size.
2084 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2085 to avoid the hassle of writing XVECTOR (foo)->header.size.
2086 (struct vectorlike_header): New type.
2087 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2088 object, to help avoid aliasing.
2089 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2090 (SUBRP): Likewise, since Lisp_Subr is a special case.
2091 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2092 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2093 (struct Lisp_Hash_Table): Combine first two members into a single
2094 struct vectorlike_header member. All uses of "size" and "next" members
2095 changed to be "header.size" and "header.next".
2096 * buffer.h (struct buffer): Likewise.
2097 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2098 * frame.h (struct frame): Likewise.
2099 * process.h (struct Lisp_Process): Likewise.
2100 * termhooks.h (struct terminal): Likewise.
2101 * window.c (struct save_window_data, struct saved_window): Likewise.
2102 * window.h (struct window): Likewise.
2103 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2104 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2105 * buffer.c (init_buffer_once): Likewise.
2106 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2107 special case.
2108 * process.c (Fformat_network_address): Use local var for size,
2109 for brevity.
2110
2111 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2112
2113 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2114 * data.c (atof): Remove decl; no longer used or needed.
2115 (digit_to_number): Move to lread.c.
2116 (Fstring_to_number): Use new string_to_number function, to be
2117 consistent with how the Lisp reader treats infinities and NaNs.
2118 Do not assume that floating-point numbers represent EMACS_INT
2119 without losing information; this is not true on most 64-bit hosts.
2120 Avoid double-rounding errors, by insisting on integers when
2121 parsing non-base-10 numbers, as the documentation specifies.
2122 * lisp.h (string_to_number): New decl, replacing ...
2123 (isfloat_string): Remove.
2124 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2125 (read1): Do not accept +. and -. as integers; this
2126 appears to have been a coding error. Similarly, do not accept
2127 strings like +-1e0 as floating point numbers. Do not report
2128 overflow for integer overflows unless the base is not 10 which
2129 means we have no simple and reliable way to continue.
2130 Break out the floating-point parsing into a new
2131 function string_to_number, so that Fstring_to_number parses
2132 floating point numbers consistently with the Lisp reader.
2133 (digit_to_number): Move here from data.c. Make it static inline.
2134 (E_CHAR, EXP_INT): Remove, replacing with ...
2135 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2136 (string_to_number): New function, replacing isfloat_string.
2137 This function checks for valid syntax and produces the resulting
2138 Lisp float number too. Rework it so that string-to-number
2139 no longer mishandles examples like "1.0e+". Use strtoumax,
2140 so that overflow for non-base-10 numbers is reported only when
2141 there's no portable and simple way to convert to floating point.
2142
2143 * textprop.c (set_text_properties_1): Rewrite for clarity,
2144 and to avoid GCC warning about integer overflow.
2145
2146 * intervals.h (struct interval): Use EMACS_INT for members
2147 where EMACS_UINT might cause problems. See
2148 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2149 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2150 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2151 All uses changed.
2152 (offset_intervals): Tell GCC not to worry about length overflow
2153 when negating a negative length.
2154
2155 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2156 (overrun_check_free): Likewise.
2157
2158 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2159 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2160 word size.
2161
2162 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2163 (gnutls_make_error): Rename local to avoid shadowing.
2164 (gnutls_emacs_global_deinit): ifdef out; not used.
2165 (Fgnutls_boot): Use const for pointer to readonly storage.
2166 Comment out unused local. Fix pointer signedness problems.
2167
2168 * lread.c (openp): Don't stuff size_t into an 'int'.
2169 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2170 about possible signed overflow.
2171
2172 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2173 (GDK_KEY_g): Don't define if already defined.
2174 (xg_prepare_tooltip): Avoid pointer signedness problem.
2175 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2176
2177 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2178 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2179
2180 * xfns.c (Fx_window_property): Simplify a bit,
2181 to make a bit faster and to avoid GCC 4.6.0 warning.
2182 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2183
2184 * fns.c (internal_equal): Don't assume size_t fits in int.
2185
2186 * alloc.c (compact_small_strings): Tighten assertion a little.
2187
2188 Replace pEd with more-general pI, and fix some printf arg casts.
2189 * lisp.h (pI): New macro, generalizing old pEd macro to other
2190 conversion specifiers. For example, use "...%"pI"d..." rather
2191 than "...%"pEd"...".
2192 (pEd): Remove. All uses replaced with similar uses of pI.
2193 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2194 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2195 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2196 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2197 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2198 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2199 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2200 64-bit hosts.
2201 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2202 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2203 * print.c (safe_debug_print, print_object): Likewise.
2204 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2205 to int.
2206 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2207 avoiding the 0 flag, which is not portable.
2208 * process.c (Fmake_network_process): Use pI to avoid cast.
2209 * region-cache.c (pp_cache): Likewise.
2210 * xdisp.c (decode_mode_spec): Likewise.
2211 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2212 behavior on 64-bit hosts with printf arg.
2213 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2214 (x_stop_queuing_selection_requests): Likewise.
2215 (x_get_window_property): Don't truncate byte count to an 'int'
2216 when tracing.
2217
2218 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2219 here, since it parses constructs like leading '-' and spaces,
2220 which are not wanted; and it overflows with large numbers.
2221 Instead, simply match F[0-9]+, which is what is wanted anyway.
2222
2223 * alloc.c: Remove unportable assumptions about struct layout.
2224 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2225 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2226 (allocate_vectorlike, make_pure_vector): Use the new macros,
2227 plus offsetof, to remove unportable assumptions about struct layout.
2228 These assumptions hold on all porting targets that I know of, but
2229 they are not guaranteed, they're easy to remove, and removing them
2230 makes further changes easier.
2231
2232 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2233 This doesn't fix a bug but makes the code clearer.
2234 (string_overrun_cookie): Now const. Use initializers that
2235 don't formally overflow signed char, to avoid warnings.
2236 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2237 can cause Emacs to crash when string overrun checking is enabled.
2238 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2239 multiple of sizeof (EMACS_INT); it need not be, if
2240 alignof(EMACS_INT) < sizeof (EMACS_INT).
2241 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2242
2243 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2244
2245 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2246
2247 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2248
2249 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2250 supposed to be handshaking. (Bug#8556)
2251 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2252
2253 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2254
2255 * lisp.h (Qdebug): List symbol.
2256 * eval.c (Qdebug): Restore global linkage.
2257 * keyboard.c (debug-on-event): New variable.
2258 (handle_user_signal): Break into debugger when debug-on-event
2259 matches the current signal symbol.
2260
2261 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2262
2263 * alloc.c (check_sblock, check_string_bytes)
2264 (check_string_free_list): Convert to standard C.
2265
2266 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2267
2268 * w32.c (emacs_gnutls_push): Fix typo.
2269
2270 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2271
2272 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2273 "cast to pointer from integer of different size".
2274
2275 Improve doprnt and its use in verror. (Bug#8545)
2276 * doprnt.c (doprnt): Document the set of format control sequences
2277 supported by the function. Use SAFE_ALLOCA instead of always
2278 using `alloca'.
2279
2280 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2281 is one byte too soon. Don't use xrealloc; instead xfree and
2282 xmalloc anew.
2283
2284 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2285
2286 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2287 callbacks stage.
2288
2289 * gnutls.c: Renamed global_initialized to
2290 gnutls_global_initialized. Added internals for the
2291 :verify-hostname-error, :verify-error, and :verify-flags
2292 parameters of `gnutls-boot' and documented those parameters in the
2293 docstring. Start callback support.
2294 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2295 unless a fatal error occured. Call gnutls_alert_send_appropriate
2296 on error. Return error code.
2297 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2298 (emacs_gnutls_read): Likewise.
2299 (Fgnutls_boot): Return handshake error code.
2300 (emacs_gnutls_handle_error): New function.
2301 (wsaerror_to_errno): Likewise.
2302
2303 * w32.h (emacs_gnutls_pull): Add prototype.
2304 (emacs_gnutls_push): Likewise.
2305
2306 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2307 (emacs_gnutls_push): Likewise.
2308
2309 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2310
2311 * process.c (wait_reading_process_output): Check if GnuTLS
2312 buffered some data internally if no FDs are set for TLS
2313 connections.
2314
2315 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2316 (LIBS): Link to USER_LIBS.
2317 ($(BLD)/gnutls.$(0)): New target.
2318
2319 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2320
2321 * xdisp.c (handle_single_display_spec): Rename the
2322 display_replaced_before_p argument into display_replaced_p, to
2323 make it consistent with the commentary. Fix typos in the
2324 commentary.
2325
2326 * textprop.c (syms_of_textprop): Remove dead code.
2327 (copy_text_properties): Delete obsolete commentary about an
2328 interface that was deleted long ago. Fix typos in the description
2329 of arguments.
2330
2331 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2332 to changes in oldXMenu/XMenu.h from 2011-04-16.
2333 <menu_help_message, prev_menu_help_message>: Constify.
2334 (IT_menu_make_room): menu->help_text is now `const char **';
2335 adjust.
2336
2337 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2338 to changes in oldXMenu/XMenu.h from 2011-04-16.
2339 (struct XMenu): Declare `help_text' `const char **'.
2340
2341 * xfaces.c <Qunspecified>: Make extern again.
2342
2343 * syntax.c: Include sys/types.h before including regex.h, as
2344 required by Posix.
2345
2346 * doc.c (get_doc_string): Improve the format passed to `error'.
2347
2348 * doprnt.c (doprnt): Improve commentary.
2349
2350 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2351
2352 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2353 them with etags.
2354
2355 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2356 changes in globals.h immediately force recompilation.
2357 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2358 $(CURDIR)/s/ms-w32.h.
2359 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2360
2361 * character.c (Fchar_direction): Function deleted.
2362 (syms_of_character): Don't defsubr it.
2363 <char-direction-table>: Deleted.
2364
2365 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2366
2367 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2368 * doprnt.c: Include limits.h.
2369 (SIZE_MAX): New macro.
2370 (doprnt): Return a size_t value. 2nd arg is now size_t.
2371 Many local variables are now size_t instead of int or unsigned.
2372 Improve overflow protection. Support `l' modifier for integer
2373 conversions. Support %l conversion. Don't assume an EMACS_INT
2374 argument for integer conversions and for %c.
2375
2376 * lisp.h (doprnt): Restore prototype.
2377
2378 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2379 $(SRC)/character.h.
2380
2381 * Makefile.in (base_obj): Add back doprnt.o.
2382
2383 * deps.mk (doprnt.o): Add back prerequisites.
2384 (callint.o): Depend on character.h.
2385
2386 * eval.c (internal_lisp_condition_case): Include the handler
2387 representation in the error message.
2388 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2389 when breaking from the loop.
2390
2391 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2392
2393 * callint.c (Fcall_interactively): When displaying error message
2394 about invalid control letter, pass the character's codepoint, not
2395 a pointer to its multibyte form. Improve display of the character
2396 in octal and display also its hex code.
2397
2398 * character.c (char_string): Use %x to display the (unsigned)
2399 codepoint of an invalid character, to avoid displaying a bogus
2400 negative value.
2401
2402 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2403 `error', not SYMBOL_NAME itself.
2404
2405 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2406 character arguments to `error'.
2407
2408 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2409 to `error' in error message about FINAL_CHAR argument. Make sure
2410 FINAL_CHAR is a character, and use %c when it is passed as
2411 argument to `error'.
2412
2413 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2414
2415 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2416
2417 * w32.c: Include <time.h>.
2418 (sys_localtime): New function.
2419
2420 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2421
2422 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2423
2424 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2425
2426 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2427
2428 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2429 zombies (Bug#8467).
2430
2431 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2432
2433 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2434 gl_state.e_property when gl_state.object is Qt.
2435
2436 * insdel.c (make_gap_larger): Remove limitation of buffer size
2437 to <= INT_MAX.
2438
2439 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2440
2441 * xdisp.c (lookup_glyphless_char_display)
2442 (produce_glyphless_glyph): Handle cons cell entry in
2443 glyphless-char-display.
2444 (Vglyphless_char_display): Document it.
2445
2446 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2447 glyphless-char-display.
2448
2449 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2450
2451 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2452
2453 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2454
2455 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2456 definition for no-X builds.
2457
2458 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 Static checks with GCC 4.6.0 and non-default toolkits.
2461
2462 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2463
2464 * process.c (keyboard_bit_set): Define only if SIGIO.
2465 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2466 (send_process): Repair possible setjmp clobbering.
2467
2468 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2469
2470 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2471
2472 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2473
2474 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2475 Define only if needed.
2476
2477 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2478 by pacifying GCC about it. Maybe it's time to retire it?
2479 * xfaces.c (USG, __TIMEVAL__): Likewise.
2480
2481 * dispextern.h (struct redisplay_interface): Rename param
2482 to avoid shadowing.
2483 * termhooks.h (struct terminal): Likewise.
2484 * xterm.c (xembed_send_message): Likewise.
2485
2486 * insdel.c (make_gap_smaller): Define only if
2487 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2488
2489 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2490 it.
2491
2492 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2493 so that we aren't warned about unused symbols.
2494
2495 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2496
2497 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2498
2499 * xfns.c (x_real_positions): Mark locals as initialized.
2500
2501 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2502
2503 * xterm.c: Fix problems found by static analysis with other toolkits.
2504 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2505 (x_dispatch_event): Declare static if USE_GTK, and
2506 define if USE_GTK || USE_X_TOOLKIT.
2507 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2508 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2509 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2510 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2511
2512 * xmenu.c (menu_help_callback): Pointer type fixes.
2513 Use const pointers when pointing at readonly data. Avoid pointer
2514 signedness clashes.
2515 (FALSE): Remove unused macro.
2516 (update_frame_menubar): Remove unused decl.
2517
2518 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2519
2520 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2521 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2522 (single_menu_item): Rename local to avoid shadowing.
2523
2524 * keyboard.c (make_lispy_event): Remove unused local var.
2525
2526 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2527 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2528
2529 * bitmaps: Change bitmaps from unsigned char back to the X11
2530 compatible char. Avoid the old compiler warnings about
2531 out-of-range initializers by using, for example, '\xab' rather
2532 than 0xab.
2533
2534 * xgselect.c (xgselect_initialize): Check vs interface
2535 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2536
2537 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2538
2539 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2540 to read-only memory.
2541
2542 * fns.c (vector): Remove; this old hack is no longer needed.
2543
2544 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2545 Remove unused var.
2546 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2547
2548 * xrdb.c (x_load_resources): Omit unused local.
2549
2550 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2551 (x_window): Rename locals to avoid shadowing.
2552 (USG): Use the kludged USG macro, to pacify gcc.
2553
2554 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2555 (x_term_init): Remove local to avoid shadowing.
2556
2557 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2558
2559 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2560 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2561
2562 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2563
2564 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2565
2566 Fix regex.c, syntax.c and friends for buffers > 2GB.
2567 * syntax.h (struct gl_state_s): Declare character position members
2568 EMACS_INT.
2569
2570 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2571
2572 * textprop.c (verify_interval_modification, interval_of):
2573 Declare arguments EMACS_INT.
2574
2575 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2576 EMACS_INT.
2577
2578 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2579
2580 * indent.c (Fvertical_motion): Local variable it_start is now
2581 EMACS_INT.
2582
2583 * regex.c (re_match, re_match_2, re_match_2_internal)
2584 (bcmp_translate, regcomp, regexec, print_double_string)
2585 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2586 (re_compile_pattern, re_exec): Declare arguments and local
2587 variables `size_t' and `ssize_t' and return values `regoff_t', as
2588 appropriate.
2589 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2590 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2591 <compile_stack_type>: `size' and `avail' are now `size_t'.
2592
2593 * regex.h <regoff_t>: Use ssize_t, not int.
2594 (re_search, re_search_2, re_match, re_match_2): Arguments that
2595 specify buffer/string position and length are now ssize_t and
2596 size_t. Return type is regoff_t.
2597
2598 2011-04-16 Ben Key <bkey76@gmail.com>
2599
2600 * nsfont.m: Fixed bugs in ns_get_family and
2601 ns_descriptor_to_entity that were caused by using free to
2602 deallocate memory blocks that were allocated by xmalloc (via
2603 xstrdup). This caused Emacs to crash when compiled with
2604 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2605 --enable-checking=xmallocoverrun). xfree is now used to
2606 deallocate these memory blocks.
2607
2608 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2611
2612 emacs_write: Accept and return EMACS_INT for sizes.
2613 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2614 et seq.
2615 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2616 Accept and return EMACS_INT.
2617 (emacs_gnutls_write): Return the number of bytes written on
2618 partial writes.
2619 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2620 (emacs_read, emacs_write): Remove check for negative size, as the
2621 Emacs source code has been audited now.
2622 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2623 (emacs_read, emacs_write): Use it.
2624 * process.c (send_process): Adjust to the new signatures of
2625 emacs_write and emacs_gnutls_write. Do not attempt to store
2626 a byte offset into an 'int'; it might overflow.
2627 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2628
2629 * sound.c: Don't assume sizes fit in 'int'.
2630 (struct sound_device.period_size, alsa_period_size):
2631 Return EMACS_INT, not int.
2632 (struct sound_device.write, vox_write, alsa_write):
2633 Accept EMACS_INT, not int.
2634 (wav_play, au_play): Use EMACS_INT to store sizes and to
2635 record read return values.
2636
2637 2011-04-15 Ben Key <bkey76@gmail.com>
2638
2639 * keyboard.c (Qundefined): Don't declare static since it is used
2640 in nsfns.m.
2641 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2642 static since they are used in nsfont.m.
2643
2644 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2645
2646 * process.c (Qprocessp): Don't declare static.
2647 * lisp.h (Qprocessp): Declare again.
2648
2649 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2650
2651 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2652
2653 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 Improve C-level modularity by making more things 'static'.
2656
2657 Don't publish debugger-only interfaces to other modules.
2658 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2659 (verify_bytepos, count_markers): Move decls to the only modules
2660 that need them.
2661 * region-cache.h (pp_cache): Likewise.
2662 * window.h (check_all_windows): Likewise.
2663 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2664
2665 * sysdep.c (croak): Now static, if
2666 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2667 * syssignal.h (croak): Declare only if not static.
2668
2669 * alloc.c (refill_memory_reserve): Now static if
2670 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2671 * lisp.h (refill_memory_reserve): Declare only if not static.
2672
2673 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2674 Define only if USE_LUCID.
2675
2676 * xrdb.c (x_customization_string, x_rm_string): Now static.
2677
2678 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2679 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2680
2681 * xdisp.c (draw_row_with_mouse_face): Now static.
2682 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2683
2684 * window.h (check_all_windows): Mark externally visible.
2685
2686 * window.c (window_deletion_count): Now static.
2687
2688 * undo.c: Make symbols static if they're not exported.
2689 (last_undo_buffer, last_boundary_position, pending_boundary):
2690 Now static.
2691
2692 * textprop.c (interval_insert_behind_hooks): Now static.
2693 (interval_insert_in_front_hooks): Likewise.
2694
2695 * term.c: Make symbols static if they're not exported.
2696 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2697 (max_frame_lines, tty_set_terminal_modes):
2698 (tty_reset_terminal_modes, tty_turn_off_highlight):
2699 (get_tty_terminal): Now static.
2700 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2701 * termhooks.h (term_mouse_moveto): Do not declare if
2702 HAVE_WINDOW_SYSTEM.
2703 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2704 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2705
2706 * sysdep.c: Make symbols static if they're not exported.
2707 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2708 Now static.
2709 (sigprocmask_set, full_mask): Remove; unused.
2710 (wait_debugging): Mark as visible.
2711 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2712 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2713
2714 * syntax.c (syntax_temp): Define only if !__GNUC__.
2715
2716 * sound.c (current_sound_device, current_sound): Now static.
2717
2718 * search.c (searchbufs, searchbuf_head): Now static.
2719
2720 * scroll.c (scroll_cost): Remove; unused.
2721 * dispextern.h (scroll_cost): Remove decl.
2722
2723 * region-cache.h (pp_cache): Mark as externally visible.
2724
2725 * process.c: Make symbols static if they're not exported.
2726 (process_tick, update_tick, create_process, chan_process):
2727 (Vprocess_alist, proc_buffered_char, datagram_access):
2728 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2729 (deactivate_process): Mark defn as static, as well as decl.
2730 * lisp.h (create_process): Remove decl.
2731 * process.h (chan_process, Vprocess_alist): Remove decls.
2732
2733 * print.c: Make symbols static if they're not exported.
2734 (print_depth, new_backquote_output, being_printed, print_buffer):
2735 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2736 (print_interval, print_number_index, initial_stderr_stream):
2737 Now static.
2738 * lisp.h (Fprinc): Remove decl.
2739 (debug_output_compilation_hack): Mark as externally visible.
2740
2741 * sysdep.c (croak): Move decl from here to syssignal.h.
2742 * syssignal.h (croak): Put it here, so the API can be checked when
2743 'croak' is called from dissociate_if_controlling_tty.
2744
2745 * minibuf.c: Make symbols static if they're not exported.
2746 (minibuf_save_list, choose_minibuf_frame): Now static.
2747 * lisp.h (choose_minibuf_frame): Remove decl.
2748
2749 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2750
2751 * lread.c: Make symbols static if they're not exported.
2752 (read_objects, initial_obarray, oblookup_last_bucket_number):
2753 Now static.
2754 (make_symbol): Remove; unused.
2755 * lisp.h (initial_obarray, make_symbol): Remove decls.
2756
2757 * keyboard.c: Make symbols static if they're not exported.
2758 (single_kboard, recent_keys_index, total_keys, recent_keys):
2759 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2760 (this_single_command_key_start, echoing, last_auto_save):
2761 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2762 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2763 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2764 (Vlispy_mouse_stem, double_click_count):
2765 Now static.
2766 (force_auto_save_soon): Define only if SIGDANGER.
2767 (ignore_mouse_drag_p): Now static if
2768 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2769 (print_help): Remove; unused.
2770 (stop_character, last_timer_event): Mark as externally visible.
2771 * keyboard.h (ignore_mouse_drag_p): Declare only if
2772 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2773 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2774 * lisp.h (echoing): Remove decl.
2775 (force_auto_save_soon): Declare only if SIGDANGER.
2776 * xdisp.c (redisplay_window): Simplify code, to make it more
2777 obvious that ignore_mouse_drag_p is not accessed if !defined
2778 USE_GTK && !defined HAVE_NS.
2779
2780 * intervals.c: Make symbols static if they're not exported.
2781 (merge_properties_sticky, merge_interval_right, delete_interval):
2782 Now static.
2783 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2784
2785 * insdel.c: Make symbols static if they're not exported.
2786 However, leave prepare_to_modify_buffer alone. It's never
2787 called from outside this function, but that appears to be a bug.
2788 (combine_after_change_list, combine_after_change_buffer):
2789 (adjust_after_replace, signal_before_change): Now static.
2790 (adjust_after_replace_noundo): Remove; unused.
2791 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2792 (signal_before_change): Remove decls.
2793
2794 * indent.c (val_compute_motion, val_vmotion): Now static.
2795
2796 * image.c: Make symbols static if they're not exported.
2797 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2798 if USE_GTK.
2799 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2800 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2801
2802 * fringe.c (standard_bitmaps): Now static.
2803 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2804
2805 * frame.c: Make symbols static if they're not exported.
2806 (x_report_frame_params, make_terminal_frame): Now static.
2807 (get_frame_param): Now static, unless HAVE_NS.
2808 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2809 (x_get_resource_string): Remove; not used.
2810 * frame.h (make_terminal_frame, x_report_frame_params):
2811 (x_get_resource_string); Remove decls.
2812 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2813 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2814
2815 * font.c, fontset.c: Make symbols static if they're not exported.
2816 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2817 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2818 * font.c (font_close_object): Now static.
2819 * font.h (font_close_object): Remove.
2820 * fontset.c (FONTSET_OBJLIST): Remove.
2821 (free_realized_fontset) #if-0 the body, which does nothing.
2822 (face_suitable_for_char_p): #if-0, as it's never called.
2823 * fontset.h (face_suitable_for_char_p): Remove decl.
2824 * xfaces.c (face_at_string_position):
2825 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2826 since 0 is always ASCII.
2827
2828 * fns.c (weak_hash_tables): Now static.
2829
2830 * fileio.c: Make symbols static if they're not exported.
2831 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2832 (Vwrite_region_annotation_buffers): Now static.
2833
2834 * eval.c: Make symbols static if they're not exported.
2835 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2836 * lisp.h (backtrace_list): Remove decl.
2837
2838 * emacs.c: Make symbols static if they're not exported.
2839 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2840 (fatal_error_code, fatal_error_signal_hook, standard_args):
2841 Now static.
2842 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2843 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2844 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2845 * lisp.h (fatal_error_signal_hook): Remove decl.
2846 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2847
2848 * editfns.c: Move a (normally-unused) function to its only use.
2849 * editfns.c, lisp.h (get_operating_system_release): Remove.
2850 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2851 worth the hassle of breaking this out.
2852
2853 * xterm.c: Make symbols static if they're not exported.
2854 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2855 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2856 (x_destroy_window, x_delete_display):
2857 Now static.
2858 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2859 (x_mouse_leave): Remove; unused.
2860 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2861 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2862 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2863 Remove decls.
2864 (x_mouse_leave): Declare only if WINDOWSNT.
2865 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2866 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2867 USE_X_TOOLKIT.
2868
2869 * ftxfont.c: Make symbols static if they're not exported.
2870 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2871 HAVE_FREETYPE.
2872 * font.h (ftxfont_driver): Likewise.
2873
2874 * xfns.c: Make symbols static if they're not exported.
2875 (x_last_font_name, x_display_info_for_name):
2876 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2877 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2878 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2879 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2880 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2881 (last_show_tip_args): Now static.
2882 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2883 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2884 (x_screen_planes): Remove; unused.
2885 * dispextern.h (x_screen_planes): Remove decl.
2886
2887 * dispnew.c: Make symbols static if they're not exported.
2888 * dispextern.h (redraw_garbaged_frames, scrolling):
2889 (increment_row_positions): Remove.
2890 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2891 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2892 Now static.
2893 (redraw_garbaged_frames): Remove; unused.
2894
2895 * xfaces.c: Make symbols static if they're not exported.
2896 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2897 Remove decls.
2898 * xterm.h (defined_color): Remove decls.
2899 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2900 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2901 (menu_face_changed_default, defined_color, free_realized_face):
2902 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2903 (ascii_face_of_lisp_face): Remove; unused.
2904
2905 * xdisp.c: Make symbols static if they're not exported.
2906 * dispextern.h (scratch_glyph_row, window_box_edges):
2907 (glyph_to_pixel_coords, set_cursor_from_row):
2908 (get_next_display_element, set_iterator_to_next):
2909 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2910 (show_mouse_face): Remove decls
2911 * frame.h (message_buf_print): Likewise.
2912 * lisp.h (pop_message, set_message, check_point_in_composition):
2913 Likewise.
2914 * xterm.h (set_vertical_scroll_bar): Likewise.
2915 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2916 (message_buf_print, scratch_glyph_row, displayed_buffer):
2917 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2918 (get_next_display_element, show_mouse_face, window_box_edges):
2919 (frame_to_window_pixel_xy, check_point_in_composition):
2920 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2921 (glyph_to_pixel_coords): Remove; unused.
2922
2923 * dired.c (file_name_completion): Now static.
2924
2925 * dbusbind.c (xd_in_read_queued_messages): Now static.
2926
2927 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2928 * data.c (circular_list_error): Remove.
2929
2930 * commands.h (last_point_position, last_point_position_buffer):
2931 (last_point_position_window): Remove decls.
2932 * keyboard.c: Make these variables static.
2933
2934 * coding.h (coding, code_convert_region, encode_coding_gap):
2935 Remove decls.
2936 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2937 (iso_code_class, detect_coding, code_convert_region): Now static.
2938 (encode_coding_gap): Remove; unused.
2939
2940 * chartab.c (chartab_chars, chartab_bits): Now static.
2941
2942 * charset.h (charset_iso_8859_1): Remove decl.
2943 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2944 Now static.
2945
2946 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2947 * ccl.c (Vccl_program_table): Now static.
2948 (check_ccl_update): Remove; unused.
2949
2950 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2951 * category.h: ... from here.
2952 * category.c (check_category_table, set_category_set): Now static.
2953
2954 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2955 * lisp.h: Remove these decls.
2956
2957 * buffer.c (buffer_count): Remove unused var.
2958
2959 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2960 so that it's not optimized away.
2961 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2962 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2963 exported only to the debugger.
2964
2965 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2966 * atimer.h (run_all_atimers): Remove; not exported.
2967
2968 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2969 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2970 was inaccessible from Lisp.
2971 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2972 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2973
2974 alloc.c: Import and export fewer symbols, and remove unused items.
2975 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2976 is defined.
2977 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2978 it's not optimized away by whole-program optimization.
2979 (message_enable_multibyte, free_misc): Remove.
2980 (catchlist, handlerlist, mark_backtrace):
2981 Declare only if BYTE_MARK_STACK.
2982 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2983 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2984 (message_enable_multibyte): Remove decl.
2985 (free_misc, interval_free_list, float_block, float_block_index):
2986 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2987 (cons_free_list, last_marked_index):
2988 Now static.
2989 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2990 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2991 (mark_backtrace): Define only if BYTE_MARK_STACK.
2992 * xdisp.c (message_enable_multibyte): Now static.
2993
2994 Declare Lisp_Object Q* variables to be 'static' if not exported.
2995 This makes it easier for human readers (and static analyzers)
2996 to see whether these variables are used from other modules.
2997 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2998 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2999 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3000 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3001 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3002 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3003 * xmenu.c, xselect.c:
3004 Declare Q* vars static if they are not used in other modules.
3005 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3006 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3007 Remove decls of unexported vars.
3008 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3009
3010 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3011
3012 Make Emacs functions such as Fatom 'static' by default.
3013 This makes it easier for human readers (and static analyzers)
3014 to see whether these functions can be called from other modules.
3015 DEFUN now defines a static function. To make the function external
3016 so that it can be used in other C modules, use the new macro DEFUE.
3017 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3018 (Finit_image_library):
3019 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3020 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3021 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3022 Remove decls, since these functions are now static.
3023 (Funintern, Fget_internal_run_time): New decls, since these functions
3024 were already external.
3025
3026 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3027 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3028 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3029 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3030 * keyboard.c, keymap.c, lread.c:
3031 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3032 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3033 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3034 Mark functions with DEFUE instead of DEFUN,
3035 if they are used in other modules.
3036 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3037 decls for now-static functions.
3038 * buffer.h (Fdelete_overlay): Remove decl.
3039 * callproc.c (Fgetenv_internal): Mark as internal.
3040 * composite.c (Fremove_list_of_text_properties): Remove decl.
3041 (Fcomposition_get_gstring): New forward static decl.
3042 * composite.h (Fcomposite_get_gstring): Remove decl.
3043 * dired.c (Ffile_attributes): New forward static decl.
3044 * doc.c (Fdocumntation_property): New forward static decl.
3045 * eval.c (Ffetch_bytecode): New forward static decl.
3046 (Funintern): Remove extern decl; now in .h file where it belongs.
3047 * fileio.c (Fmake_symbolic_link): New forward static decl.
3048 * image.c (Finit_image_library): New forward static decl.
3049 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3050 * intervals.h (Fprevious_property_change):
3051 (Fremove_list_of_text_properties): Remove decls.
3052 * keyboard.c (Fthis_command_keys): Remove decl.
3053 (Fcommand_execute): New forward static decl.
3054 * keymap.c (Flookup_key): New forward static decl.
3055 (Fcopy_keymap): Now static.
3056 * keymap.h (Flookup_key): Remove decl.
3057 * process.c (Fget_process): New forward static decl.
3058 (Fprocess_datagram_address): Mark as internal.
3059 * syntax.c (Fsyntax_table_p): New forward static decl.
3060 (skip_chars): Remove duplicate decl.
3061 * textprop.c (Fprevious_property_change): New forward static decl.
3062 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3063 Now internal.
3064 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3065 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3066
3067 * editfns.c (Fformat): Remove unreachable code.
3068
3069 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3070
3071 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3072 change. (Bug#8496)
3073
3074 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3075
3076 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3077 when at ZV. (Bug#8487)
3078
3079 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3080
3081 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3082 (Bug#8437)
3083 * keyboard.c (parse_tool_bar_item): Likewise.
3084 * sound.c (sound_cleanup, alsa_close): Likewise.
3085 * termcap.c (tgetent): Likewise.
3086 * xfns.c (x_default_font_parameter): Likewise.
3087 * xsettings.c (read_and_apply_settings): Likewise.
3088
3089 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3090 (overrun_check_free): Protoize.
3091
3092 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3093
3094 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3095 since callers should never pass a negative size.
3096 Change the signature to match that of plain 'read' and 'write'; see
3097 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3098 * lisp.h: Update prototypes of emacs_write and emacs_read.
3099
3100 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3101
3102 * xdisp.c (redisplay_window): Don't try to determine the character
3103 position of the scroll margin if the window start point w->startp
3104 is outside the buffer's accessible region. (Bug#8468)
3105
3106 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3107
3108 Fix write-region and its subroutines for buffers > 2GB.
3109 * fileio.c (a_write, e_write): Modify declaration of arguments and
3110 local variables to support buffers larger than 2GB.
3111 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3112
3113 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3114 argument, local variables, and return value.
3115
3116 * lisp.h: Update prototypes of emacs_write and emacs_read.
3117
3118 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3119
3120 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3123
3124 Fix more problems found by GCC 4.6.0's static checks.
3125
3126 * xdisp.c (vmessage): Use a better test for character truncation.
3127
3128 * charset.c (load_charset_map): <, not <=, for optimization,
3129 and to avoid potential problems with integer overflow.
3130 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3131 * casetab.c (set_identity, shuffle): Likewise.
3132 * editfns.c (Fformat): Likewise.
3133 * syntax.c (skip_chars): Likewise.
3134
3135 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3136 This also lets GCC 4.6.0 generate slightly better loop code.
3137
3138 * callint.c (Fcall_interactively): <, not <=, for optimization.
3139 (Fcall_interactively): Count the number of arguments produced,
3140 not the number of arguments given. This is simpler and lets GCC
3141 4.6.0 generate slightly better code.
3142
3143 * ftfont.c: Distingish more carefully between FcChar8 and char.
3144 The previous code passed unsigned char * to a functions like
3145 strlen and xstrcasecmp that expect char *, which does not
3146 conform to the C standard.
3147 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3148 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3149 char * when the C standard requires it.
3150
3151 * keyboard.c (read_char): Remove unused var.
3152
3153 * eval.c: Port to Windows vsnprintf (Bug#8435).
3154 Include <limits.h>.
3155 (SIZE_MAX): Define if the headers do not.
3156 (verror): Do not give up if vsnprintf returns a negative count.
3157 Instead, grow the buffer. This ports to Windows vsnprintf, which
3158 does not conform to C99. Problem reported by Eli Zaretskii.
3159 Also, simplify the allocation scheme, by avoiding the need for
3160 calling realloc, and removing the ALLOCATED variable.
3161
3162 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3163
3164 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3165 But keep the doprint source code for now, as we might revamp it
3166 and use it again (Bug#8435).
3167 * lisp.h (doprnt): Remove.
3168 * Makefile.in (base_obj): Remove doprnt.o.
3169 * deps.mk (doprnt.o): Remove.
3170
3171 error: Print 32- and 64-bit integers portably (Bug#8435).
3172 Without this change, on typical 64-bit hosts error ("...%d...", N)
3173 was used to print both 32- and 64-bit integers N, which relied on
3174 undefined behavior.
3175 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3176 New macro.
3177 * lisp.h (error, verror): Mark as printf-like functions.
3178 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3179 Report overflow in size calculations when allocating printf buffer.
3180 Do not truncate output string at its first null byte.
3181 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3182 Truncate the output at a character boundary, since vsnprintf does not
3183 do that.
3184 * charset.c (check_iso_charset_parameter): Convert internal
3185 character to string before calling 'error', since %c now has the
3186 printf meaning.
3187 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3188 overflow when computing char to be passed to 'error'. Do not
3189 pass Lisp_Object to 'error'; pass the integer instead.
3190 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3191 formatted with plain %d.
3192
3193 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3194
3195 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3196
3197 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3198
3199 * xterm.c (x_catch_errors): Remove duplicate declaration.
3200
3201 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3202
3203 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3204
3205 2011-04-10 Jim Meyering <meyering@redhat.com>
3206
3207 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3208 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3209 return ssize_t not "int", and use size_t as the buffer length.
3210 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3211 * gnutls.h: Update declarations.
3212 * process.c (read_process_output): Use ssize_t, to match.
3213 (send_process): Likewise.
3214
3215 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3216
3217 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3218
3219 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3220
3221 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3222 Use unsigned char, to match FcChar8 type definition.
3223
3224 * xterm.c (handle_one_xevent):
3225 * xmenu.c (create_and_show_popup_menu):
3226 * xselect.c (x_decline_selection_request)
3227 (x_reply_selection_request): Avoid type-punned deref of X events.
3228
3229 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3230
3231 Fix some uses of `int' instead of EMACS_INT.
3232 * search.c (string_match_1, fast_string_match)
3233 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3234 (scan_buffer, find_next_newline_no_quit)
3235 (find_before_next_newline, search_command, Freplace_match)
3236 (Fmatch_data): Make some `int' variables be EMACS_INT.
3237
3238 * xdisp.c (display_count_lines): 3rd argument and return value now
3239 EMACS_INT. All callers changed.
3240 (pint2hrstr): Last argument is now EMACS_INT.
3241
3242 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3243 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3244 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3245 (decode_coding_utf_16, decode_coding_emacs_mule)
3246 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3247 (decode_coding_ccl, decode_coding_charset)
3248 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3249 (decode_coding_iso_2022, decode_coding_emacs_mule)
3250 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3251 <char_offset, last_offset>: Declare EMACS_INT.
3252 (encode_coding_utf_8, encode_coding_utf_16)
3253 (encode_coding_emacs_mule, encode_invocation_designation)
3254 (encode_designation_at_bol, encode_coding_iso_2022)
3255 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3256 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3257 Declare EMACS_INT.
3258 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3259 (encode_invocation_designation): Last argument P_NCHARS is now
3260 EMACS_INT.
3261 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3262 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3263
3264 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3265 All users changed.
3266
3267 * ccl.c (Fccl_execute_on_string): Declare some variables
3268 EMACS_INT.
3269
3270 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3271
3272 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3273
3274 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3275
3276 * process.c (Fformat_network_address): Doc fix.
3277
3278 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3279
3280 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3281
3282 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3283
3284 * keyboard.c (read_char): Call Lisp function help-form-show,
3285 instead of using internal_with_output_to_temp_buffer.
3286 (Qhelp_form_show): New var.
3287 (syms_of_keyboard): Use DEFSYM macro.
3288
3289 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3290
3291 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3292
3293 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3294
3295 * process.c (Flist_processes): Remove to Lisp.
3296 (list_processes_1): Delete.
3297
3298 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3299
3300 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3301
3302 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3303
3304 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 Fix more problems found by GCC 4.6.0's static checks.
3307
3308 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3309
3310 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3311
3312 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3313
3314 * xdisp.c (vmessage): Mark as a printf-like function.
3315
3316 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3317
3318 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3319
3320 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3321 printf-like functions.
3322 (tiff_load): Add casts to remove these marks before passing them
3323 to system-supplied API.
3324
3325 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3326
3327 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3328 This avoids several warnings with gcc -Wstrict-overflow.
3329 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3330 directly, rather than having caller test rule sign. This avoids
3331 some unnecessary tests.
3332 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3333 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3334 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3335
3336 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3337 (xfont_open): Avoid unnecessary tests.
3338
3339 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3340
3341 * composite.h, composite.c (composition_gstring_put_cache):
3342 Use EMACS_INT, not int, for length.
3343
3344 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3345 breaking out part of COMPOSITION_DECODE_RULE.
3346 (COMPOSITION_DECODE_RULE): Use it.
3347 * composite.c (get_composition_id): Remove unused local vars,
3348 by using the new macro.
3349
3350 * textprop.c (set_text_properties_1): Change while to do-while,
3351 since the condition is always true at first.
3352
3353 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3354 (interval_deletion_adjustment): Return unsigned value.
3355 All uses changed.
3356
3357 * process.c (list_processes_1, create_pty, read_process_output):
3358 (exec_sentinel): Remove vars that were set but not used.
3359 (create_pty): Remove unnecessary "volatile"s.
3360 (Fnetwork_interface_info): Avoid possibility of int overflow.
3361 (read_process_output): Do adaptive read buffering even if carryover.
3362 (read_process_output): Simplify nbytes computation if buffered.
3363
3364 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3365
3366 * syntax.c (scan_words): Remove var that was set but not used.
3367 (update_syntax_table): Use unsigned instead of int.
3368
3369 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3370 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3371 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3372
3373 * print.c (print_error_message): Avoid int overflow.
3374
3375 * font.c (font_list_entities): Redo for clarity,
3376 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3377
3378 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3379 (font_score): Avoid potential overflow in diff calculation.
3380
3381 * fns.c (substring_both): Remove var that is set but not used.
3382 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3383
3384 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3385
3386 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3387 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3388 can always succeed if overflow has undefined behavior.
3389
3390 * search.c (boyer_moore, wordify): Remove vars set but not used.
3391 (wordify): Omit three unnecessary tests.
3392
3393 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3394 All callers changed. This avoids the need for an unused var.
3395
3396 * casefiddle.c (casify_region): Remove var that is set but not used.
3397
3398 * dired.c (file_name_completion): Remove var that is set but not used.
3399
3400 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3401
3402 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3403 (Finsert_file_contents): Remove unnecessary code checking fd.
3404
3405 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3406 Check for integer overflow on size calculations.
3407
3408 * buffer.c (Fprevious_overlay_change): Remove var that is set
3409 but not used.
3410
3411 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3412 Remove vars that are set but not used.
3413 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3414 (timer_check_2): Mark vars as initialized.
3415
3416 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3417
3418 * image.c (lookup_image): Remove var that is set but not used.
3419 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3420
3421 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3422 that are set but not used.
3423
3424 * xfns.c (make_invisible_cursor): Don't return garbage
3425 if XCreateBitmapFromData fails (Bug#8410).
3426
3427 * xselect.c (x_get_local_selection, x_handle_property_notify):
3428 Remove vars that are set but not used.
3429
3430 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3431 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3432
3433 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3434 Remove var that is set but not used.
3435 (scroll_bar_windows_size): Now size_t, not int.
3436 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3437 Check for overflow.
3438
3439 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3440 (map_tty_color) [!defined MSDOS]: Likewise.
3441
3442 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3443
3444 * coding.c: Remove vars that are set but not used.
3445 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3446 All callers changed.
3447 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3448 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3449 (decode_coding_charset): Remove vars that are set but not used.
3450
3451 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3452 that is set but not used.
3453
3454 * print.c (print_object): Remove var that is set but not used.
3455
3456 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3457 The gnulib version avoids calling malloc in the usual case,
3458 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3459 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3460 * filelock.c (current_lock_owner): Likewise.
3461 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3462 * sysdep.c: Include allocator.h, careadlinkat.h.
3463 (emacs_no_realloc_allocator): New static constant.
3464 (emacs_readlink): New function.
3465 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3466 ../lib/careadlinkat.h.
3467
3468 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3469
3470 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3471 first non-nil return value).
3472
3473 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3474
3475 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3476 if not defined (Bug#8403).
3477
3478 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3479
3480 * xdisp.c (display_count_lines): Remove parameter `start',
3481 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3482 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3483 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3484 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3485 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3486 and thereabouts. All callers changed.
3487 (get_per_char_metric): Remove parameter `f', unused since
3488 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3489
3490 2011-04-02 Jim Meyering <meyering@redhat.com>
3491
3492 do not dereference NULL upon failed strdup
3493 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3494 (ns_get_family): Likewise.
3495
3496 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3497
3498 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3499
3500 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3501
3502 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3503 later (Bug#8403).
3504
3505 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3506
3507 Add lexical binding.
3508
3509 * window.c (Ftemp_output_buffer_show): New fun.
3510 (Fsave_window_excursion):
3511 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3512
3513 * lread.c (lisp_file_lexically_bound_p): New function.
3514 (Fload): Bind Qlexical_binding.
3515 (readevalloop): Remove `evalfun' arg.
3516 Bind Qinternal_interpreter_environment.
3517 (Feval_buffer): Bind Qlexical_binding.
3518 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3519 Mark as dynamic.
3520 (syms_of_lread): Declare `lexical-binding'.
3521
3522 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3523
3524 * keyboard.c (eval_dyn): New fun.
3525 (menu_item_eval_property): Use it.
3526
3527 * image.c (parse_image_spec): Use Ffunctionp.
3528
3529 * fns.c (concat, mapcar1): Accept byte-code-functions.
3530
3531 * eval.c (Fsetq): Handle lexical vars.
3532 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3533 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3534 (FletX, Flet): Obey lexical binding.
3535 (Fcommandp): Handle closures.
3536 (Feval): New `lexical' arg.
3537 (eval_sub): New function extracted from Feval. Use it almost
3538 everywhere where Feval was used. Look up vars in lexical env.
3539 Handle closures.
3540 (Ffunctionp): Move from subr.el.
3541 (Ffuncall): Handle closures.
3542 (apply_lambda): Remove `eval_flags'.
3543 (funcall_lambda): Handle closures and new byte-code-functions.
3544 (Fspecial_variable_p): New function.
3545 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3546 but without exporting it to Lisp.
3547
3548 * doc.c (Fdocumentation, store_function_docstring):
3549 * data.c (Finteractive_form): Handle closures.
3550
3551 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3552 interactive spec.
3553
3554 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3555 New byte-codes.
3556 (exec_byte_code): New function extracted from Fbyte_code to handle new
3557 calling convention for byte-code-functions. Add new byte-codes.
3558
3559 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3560
3561 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3562
3563 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3564
3565 * xdisp.c (redisplay_internal): Fix prototype.
3566
3567 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3568
3569 * xdisp.c (SCROLL_LIMIT): New macro.
3570 (try_scrolling): Use it when setting scroll_limit.
3571 Limit scrolling to 100 screen lines.
3572 (redisplay_window): Even when falling back on "recentering",
3573 position point in the window according to scroll-conservatively,
3574 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3575
3576 (try_scrolling): When point is above the window, allow searching
3577 as far as scroll_max, or one screenful, to compute vertical
3578 distance from PT to the scroll margin position. This prevents
3579 try_scrolling from unnecessarily failing when
3580 scroll-conservatively is set to a value slightly larger than the
3581 window height. Clean up the case of PT below the margin at bottom
3582 of window: scroll_max can no longer be INT_MAX. When aggressive
3583 scrolling is in use, don't let point enter the opposite scroll
3584 margin as result of the scroll.
3585 (syms_of_xdisp) <scroll-conservatively>: Document the
3586 threshold of 100 lines for never-recentering scrolling.
3587
3588 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3589
3590 * dispextern.h (move_it_by_lines):
3591 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3592 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3593 (message_log_check_duplicate): Remove parameters `prev_bol' and
3594 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3595 (redisplay_internal): Remove parameter `preserve_echo_area',
3596 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3597
3598 * indent.c (Fvertical_motion):
3599 * window.c (window_scroll_pixel_based, Frecenter):
3600 Don't pass `need_y_p' to `move_it_by_lines'.
3601
3602 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3603
3604 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3605 steal a few bits to be more compact.
3606 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3607 Remove unneeded casts.
3608
3609 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3610
3611 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3612
3613 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3614 binding" message (bug#7967).
3615
3616 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 Fix more problems found by GCC 4.6.0's static checks.
3619
3620 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3621 Remove unused local var.
3622
3623 * editfns.c (Fmessage_box): Remove unused local var.
3624
3625 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3626 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3627 Omit unused local vars.
3628 * window.c (shrink_windows): Omit unused local var.
3629 * menu.c (digest_single_submenu): Omit unused local var.
3630 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3631 Omit unused local var.
3632
3633 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3634 Don't assume string length fits in int.
3635 (keyremap_step, read_key_sequence): Use size_t for sizes.
3636 (read_key_sequence): Don't check last_real_key_start redundantly.
3637
3638 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3639 instead of alloca (Bug#8344).
3640
3641 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3642 (Fbacktrace_frame): Don't assume nframes fits in int.
3643
3644 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3645
3646 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3647 concerns.
3648
3649 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3650
3651 * cm.c (calccost): Turn while-do into do-while, for clarity.
3652
3653 * keyboard.c (syms_of_keyboard): Use the same style as later
3654 in this function when indexing through an array. This also
3655 works around GCC bug 48267.
3656
3657 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3658
3659 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3660
3661 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3662 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3663
3664 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3665 This avoids undefined behavior on integer overflow, and is a bit
3666 more convenient anyway since it is compared to a size_t variable.
3667
3668 Variadic C functions now count arguments with size_t, not int.
3669 This avoids an unnecessary limitation on 64-bit machines, which
3670 caused (substring ...) to crash on large vectors (Bug#8344).
3671 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3672 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3673 All variadic functions and their callers changed accordingly.
3674 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3675 * data.c (arith_driver, float_arith_driver): Likewise.
3676 * editfns.c (general_insert_function): Likewise.
3677 * eval.c (struct backtrace.nargs, interactive_p)
3678 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3679 (funcall_lambda, mark_backtrace): Likewise.
3680 * fns.c (concat): Likewise.
3681 * frame.c (x_set_frame_parameters): Likewise.
3682 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3683 0 if not found, not -1. All callers changed.
3684
3685 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3686 (stack_copy_size): Now size_t, not int.
3687 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3688
3689 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3690
3691 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3692 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3693 All callers changed.
3694
3695 * lisp.h (multibyte_char_to_unibyte):
3696 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3697 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3698 * character.h (CHAR_TO_BYTE8):
3699 * cmds.c (internal_self_insert):
3700 * editfns.c (general_insert_function):
3701 * keymap.c (push_key_description):
3702 * search.c (Freplace_match):
3703 * xdisp.c (message_dolog, set_message_1): All callers changed.
3704
3705 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3706
3707 * keyboard.c (safe_run_hook_funcall): New function.
3708 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3709 don't set the hook to nil, but remove the offending function instead.
3710 (Qcommand_hook_internal): Remove, unused.
3711 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3712 Vcommand_hook_internal.
3713
3714 * eval.c (enum run_hooks_condition): Remove.
3715 (funcall_nil, funcall_not): New functions.
3716 (run_hook_with_args): Call each function through a `funcall' argument.
3717 Remove `cond' argument, now redundant.
3718 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3719 (Frun_hook_with_args_until_failure): Adjust accordingly.
3720 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3721
3722 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3723
3724 * dispextern.h (string_buffer_position): Remove declaration.
3725
3726 * print.c (strout): Remove parameter `multibyte', unused since
3727 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3728
3729 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3730 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3731 All callers changed.
3732
3733 * w32.c (_wsa_errlist): Use braces for struct initializers.
3734
3735 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3736 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3737 All callers changed.
3738 (string_buffer_position): Likewise. Also, make static (it's never
3739 used outside xdisp.c).
3740 (cursor_row_p): Remove parameter `w', unused since
3741 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3742 (decode_mode_spec): Remove parameter `precision', introduced during
3743 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3744 All callers changed.
3745
3746 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3747
3748 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3749
3750 2011-03-27 Anders Lindgren <andlind@gmail.com>
3751
3752 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3753 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3754 (ns_update_auto_hide_menu_bar): New functions.
3755 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3756 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3757 ns_constrain_all_frames.
3758 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3759 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3760
3761 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3762
3763 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3764
3765 2011-03-27 Glenn Morris <rgm@gnu.org>
3766
3767 * syssignal.h: Replace RETSIGTYPE with void.
3768 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3769 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3770 Replace SIGTYPE with void everywhere.
3771 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3772 * s/template.h (SIGTYPE): Remove commented out definition.
3773
3774 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3775
3776 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3777 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3778
3779 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3780
3781 * w32.c (read_unc_volume): Use parameter `henum', instead of
3782 global variable `wget_enum_handle'.
3783
3784 * keymap.c (describe_vector): Remove parameters `indices' and
3785 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3786 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3787
3788 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3789
3790 * keyboard.c (timer_check): Remove parameter `do_it_now',
3791 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3792 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3793 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3794
3795 * keyboard.c (read_char):
3796 * w32menu.c (w32_menu_display_help):
3797 * xmenu.c (show_help_event, menu_help_callback):
3798 Adjust calls to `show_help_echo'.
3799
3800 * gtkutil.c (xg_maybe_add_timer):
3801 * keyboard.c (readable_events):
3802 * process.c (wait_reading_process_output):
3803 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3804
3805 * insdel.c (adjust_markers_gap_motion):
3806 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3807 (gap_left, gap_right): Don't call it.
3808
3809 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3810
3811 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3812 incurred during fontification.
3813
3814 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3815
3816 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3817 (DEFVAR_PER_BUFFER): Don't pass it.
3818
3819 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3820 (scrolling_window): Don't pass it.
3821
3822 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3823
3824 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3825
3826 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3827 and `suffix'.
3828 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3829 of variables specific to SELinux and computation of `encoded_absname'.
3830
3831 * image.c (XPutPixel): Remove unused variable `height'.
3832
3833 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3834
3835 * unexw32.c (get_section_info): Remove unused variable `section'.
3836
3837 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3838 (system_process_attributes): Remove unused variable `sess'.
3839 (sys_read): Remove unused variable `err'.
3840
3841 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3842 (w32_wnd_proc): Remove unused variable `isdead'.
3843 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3844 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3845 (x_create_tip_frame): Remove unused variable `tem'.
3846
3847 * w32inevt.c (w32_console_read_socket):
3848 Remove unused variable `no_events'.
3849
3850 * w32term.c (x_draw_composite_glyph_string_foreground):
3851 Remove unused variable `width'.
3852
3853 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3854
3855 * w32term.c (x_set_glyph_string_clipping):
3856 Don't pass uninitialized region to CombineRgn.
3857
3858 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3859
3860 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3861 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3862 (Fx_close_connection): Remove unused variable `i'.
3863
3864 * w32font.c (w32font_draw): Return number of glyphs.
3865 (w32font_open_internal): Remove unused variable `i'.
3866 (w32font_driver): Add missing initializer.
3867
3868 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3869 (fill_in_menu): Remove unused variable `items_added'.
3870
3871 * w32term.c (last_mouse_press_frame): Remove static global variable.
3872 (w32_clip_to_row): Remove unused variable `f'.
3873 (x_delete_terminal): Remove unused variable `i'.
3874
3875 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3876 (NOTHING): Remove unused static global variable.
3877 (uniscribe_check_otf): Remove unused variable `table'.
3878 (uniscribe_font_driver): Add missing initializers.
3879
3880 2011-03-23 Julien Danjou <julien@danjou.info>
3881
3882 * term.c (Fsuspend_tty, Fresume_tty):
3883 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3884 * window.c (temp_output_buffer_show):
3885 * insdel.c (signal_before_change):
3886 * frame.c (Fhandle_switch_frame):
3887 * fileio.c (Fdo_auto_save):
3888 * emacs.c (Fkill_emacs):
3889 * editfns.c (save_excursion_restore):
3890 * cmds.c (internal_self_insert):
3891 * callint.c (Fcall_interactively):
3892 * buffer.c (Fkill_all_local_variables):
3893 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3894 Use Frun_hooks.
3895 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3896 unconditionnaly since it does the check itself.
3897
3898 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3899
3900 Fix more problems found by GCC 4.5.2's static checks.
3901
3902 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3903 the first time through the loop, since we know p0 < p1 then.
3904 This also avoids a gcc -Wstrict-overflow warning.
3905
3906 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3907 leading to a memory leak, possible in functions like
3908 load_charset_map_from_file that can allocate an unbounded number
3909 of objects (Bug#8318).
3910
3911 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3912 that could (at least in theory) be that large.
3913
3914 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3915 This is less likely to overflow, and avoids undefined behavior if
3916 overflow does occur. All callers changed. Use strtoul to scan
3917 for the unsigned long integer.
3918 (pint2hrstr): Simplify and tune code slightly.
3919 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3920
3921 * scroll.c (do_scrolling): Work around GCC bug 48228.
3922 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3923
3924 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3925 This also avoids a warning with gcc -Wstrict-overflow.
3926 (validate_x_resource_name): Simplify count usage.
3927 This also avoids a warning with gcc -Wstrict-overflow.
3928
3929 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3930 fail (Bug#8306).
3931
3932 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3933
3934 * process.c (Fmake_network_process): Use socklen_t, not int,
3935 where POSIX says socklen_t is required in portable programs.
3936 This fixes a porting bug on hosts like 64-bit HP-UX, where
3937 socklen_t is wider than int (Bug#8277).
3938 (Fmake_network_process, server_accept_connection):
3939 (wait_reading_process_output, read_process_output):
3940 Likewise.
3941
3942 * process.c: Rename or move locals to avoid shadowing.
3943 (list_processes_1, Fmake_network_process):
3944 (read_process_output_error_handler, exec_sentinel_error_handler):
3945 Rename or move locals.
3946 (Fmake_network_process): Define label "retry_connect" only if needed.
3947 (Fnetwork_interface_info): Fix pointer signedness.
3948 (process_send_signal): Add cast to avoid pointer signedness problem.
3949 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3950 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3951
3952 Make tparam.h and terminfo.c consistent.
3953 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3954 Include tparam.h instead, since it declares them.
3955 * cm.h (PC): Remove extern decl; tparam.h now does this.
3956 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3957 * terminfo.c: Include tparam.h, to check interfaces.
3958 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3959 (tparam): Adjust signature to match interface in tparam.h;
3960 this removes some undefined behavior. Check that outstring and len
3961 are zero, which they always are with Emacs.
3962 * tparam.h (PC, BC, UP): New extern decls.
3963
3964 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3965 (xftfont_open): Rename locals to avoid shadowing.
3966
3967 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3968 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3969 (OTF_TAG_SYM): Omit macro if not needed.
3970 (ftfont_list): Remove unused local.
3971 (get_adstyle_property, ftfont_pattern_entity):
3972 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3973 Rename locals to avoid shadowing.
3974
3975 * xfont.c (xfont_list_family): Mark var as initialized.
3976
3977 * xml.c (make_dom): Now static.
3978
3979 * composite.c (composition_compute_stop_pos): Rename local to
3980 avoid shadowing.
3981 (composition_reseat_it): Remove unused locals.
3982 (find_automatic_composition, composition_adjust_point): Likewise.
3983 (composition_update_it): Mark var as initialized.
3984 (find_automatic_composition): Mark vars as initialized,
3985 with a FIXME (Bug#8290).
3986
3987 character.h: Rename locals to avoid shadowing.
3988 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3989 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3990 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3991 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3992 to avoid shadowing.
3993
3994 * textprop.c (property_change_between_p): Remove; unused.
3995
3996 * intervals.c (interval_start_pos): Now static.
3997
3998 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3999
4000 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4001 Rename locals to avoid shadowing.
4002
4003 * sound.c (wav_play, au_play, Fplay_sound_internal):
4004 Fix pointer signedness.
4005 (alsa_choose_format): Remove unused local var.
4006 (wav_play): Initialize a variable to 0, to prevent undefined
4007 behavior (Bug#8278).
4008
4009 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4010
4011 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4012
4013 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4014 clobbering (Bug#8298).
4015 * sysdep.c (sys_subshell): Likewise.
4016 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4017
4018 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4019 This should get cleaned up, so that child_setup has the
4020 same signature on all platforms.
4021
4022 * callproc.c (call_process_cleanup): Now static.
4023 (relocate_fd): Rename locals to avoid shadowing.
4024
4025 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4026
4027 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4028 not to be necessary, and produces flickering.
4029
4030 2011-03-20 Glenn Morris <rgm@gnu.org>
4031
4032 * config.in: Remove file.
4033
4034 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4035
4036 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4037 are now in src/globals.h.
4038 (syms_of_minibuf): Remove spurious & from previous change.
4039
4040 2011-03-20 Leo <sdl.web@gmail.com>
4041
4042 * minibuf.c (completing-read-function): New variable.
4043 (completing-read-default): Rename from completing-read.
4044 (completing-read): Call completing-read-function.
4045
4046 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4047
4048 * xfaces.c (Fx_load_color_file):
4049 Read color file from absolute filename (bug#8250).
4050
4051 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4052
4053 * makefile.w32-in: Update dependencies.
4054
4055 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4056
4057 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4058
4059 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4060
4061 Fix more problems found by GCC 4.5.2's static checks.
4062
4063 * process.c (make_serial_process_unwind, send_process_trap):
4064 (sigchld_handler): Now static.
4065
4066 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4067 That way, the code declares only the vars that it needs.
4068 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4069 * s/cygwin.h (PTY_ITERATION): Likewise.
4070 * s/darwin.h (PTY_ITERATION): Likewise.
4071 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4072
4073 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4074 * process.c (allocate_pty): Don't declare stb unless it's needed.
4075
4076 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4077 (CONSTANTLIM): Remove; unused.
4078 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4079 Define only if needed.
4080
4081 * unexelf.c (unexec): Name an expression,
4082 to avoid gcc -Wbad-function-cast warning.
4083 Use a different way to cause a compilation error if anyone uses
4084 n rather than nn, a way that does not involve shadowing.
4085 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4086
4087 * deps.mk (unexalpha.o): Remove; unused.
4088
4089 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4090 * unexec.h: New file.
4091 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4092 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4093 Depend on unexec.h.
4094 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4095 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4096 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4097 Change as necessary to match prototype in unexec.h.
4098
4099 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4100 shadowing.
4101 (back_comment, skip_chars): Mark vars as initialized.
4102
4103 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4104 Rename locals to avoid shadowing.
4105
4106 * lread.c (read1): Rewrite so as not to use empty "else".
4107 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4108
4109 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4110
4111 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4112 warning when compiling print.c.
4113
4114 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4115 instead of using an uninitialized var.
4116 (font_sort_entities): Mark var as initialized.
4117
4118 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4119
4120 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4121 pointers to constants.
4122 (font_parse_fcname): Remove unused vars.
4123 (font_delete_unmatched): Now static.
4124 (font_get_spec): Remove; unused.
4125 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4126 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4127 Rename or move locals to avoid shadowing.
4128
4129 * fns.c (require_nesting_list, require_unwind): Now static.
4130 (Ffillarray): Rename locals to avoid shadowing.
4131
4132 * floatfns.c (domain_error2): Define only if needed.
4133 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4134
4135 * alloc.c (mark_backtrace): Move decl from here ...
4136 * lisp.h: ... to here, so that it can be checked.
4137
4138 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4139 (Fdefvar): Rewrite so as not to use empty "else".
4140 (lisp_indirect_variable): Name an expression,
4141 to avoid gcc -Wbad-function-cast warning.
4142 (Fdefvar): Rename locals to avoid shadowing.
4143
4144 * callint.c (quotify_arg, quotify_args): Now static.
4145 (Fcall_interactively): Rename locals to avoid shadowing.
4146 Use const pointer when appropriate.
4147
4148 * lisp.h (get_system_name, get_operating_system_release):
4149 Move decls here, to check interfaces.
4150 * process.c (get_operating_system_release): Move decl to lisp.h.
4151 * xrdb.c (get_system_name): Likewise.
4152 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4153 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4154 some of which prompt warnings from gcc -Wbad-function-cast.
4155 (Fformat_time_string, Fencode_time, Finsert_char):
4156 (Ftranslate_region_internal, Fformat):
4157 Rename or remove local vars to avoid shadowing.
4158 (Ftranslate_region_internal): Mark var as initialized.
4159
4160 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4161 avoid shadowing.
4162
4163 * lisp.h (eassert): Check that the argument compiles, even if
4164 ENABLE_CHECKING is not defined.
4165
4166 * data.c (Findirect_variable): Name an expression, to avoid
4167 gcc -Wbad-function-cast warning.
4168 (default_value, arithcompare, arith_driver, arith_error): Now static.
4169 (store_symval_forwarding): Rename local to avoid shadowing.
4170 (Fmake_variable_buffer_local, Fmake_local_variable):
4171 Mark variables as initialized.
4172 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4173
4174 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4175 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4176 Rename locals to avoid shadowing.
4177 (mark_stack): Move local variables into the #ifdef region where
4178 they're used.
4179 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4180 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4181 needed otherwise.
4182 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4183 (GC_STRING_CHARS): Remove; not used.
4184 (Fmemory_limit): Cast sbrk's returned value to char *.
4185
4186 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4187 avoids undefined behavior in theory.
4188
4189 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4190
4191 Use functions, not macros, for up- and down-casing (Bug#8254).
4192 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4193 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4194 to use the following functions instead of these macros.
4195 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4196 EMACS_INT, since callers assume the returned value fits in int.
4197 (upcase1): Likewise, for UPCASE_TABLE.
4198 (uppercasep, lowercasep, upcase): New static inline functions.
4199 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4200 the race-condition problem in the old DOWNCASE.
4201
4202 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4203 Rename locals to avoid shadowing.
4204 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4205 (regex_compile, re_search_2, re_match_2_internal):
4206 Remove unused local vars.
4207 (FREE_VAR): Rewrite so as not to use empty "else",
4208 which gcc can warn about.
4209 (regex_compile, re_match_2_internal): Mark locals as initialized.
4210 (RETALLOC_IF): Define only if needed.
4211 (WORDCHAR_P): Likewise. This one is never needed, but is used
4212 only in a comment talking about a compiler bug, so put inside
4213 the #if 0 of that comment.
4214 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4215 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4216 Remove; unused.
4217
4218 * search.c (boyer_moore): Rename locals to avoid shadowing.
4219 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4220 (PREV_CHAR_BOUNDARY): Likewise.
4221
4222 * search.c (simple_search): Remove unused var.
4223
4224 * dired.c (compile_pattern): Move decl from here ...
4225 * lisp.h: ... to here, so that it can be checked.
4226 (struct re_registers): New forward decl.
4227
4228 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4229
4230 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4231 All uses changed.
4232 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4233 Rename locals to avoid shadowing.
4234 (Fvertical_motion): Mark locals as initialized.
4235
4236 * casefiddle.c (casify_object, casify_region): Now static.
4237 (casify_region): Mark local as initialized.
4238
4239 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4240
4241 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4242 New macros, so that the caller can use some names other than
4243 gcpro1, gcpro2, etc.
4244 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4245 of the new macros.
4246 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4247 argument, for consistency with GCPRO2_VAR, etc: it is now the
4248 prefix of the variable, not the variable itself. All uses
4249 changed.
4250 * dired.c (directory_files_internal, file_name_completion):
4251 Rename locals to avoid shadowing.
4252
4253 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4254 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4255 dired.c's scmp function, had undefined behavior.
4256 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4257 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4258 * buffer.h: ... to here, because these macros use current_buffer,
4259 and the new implementation with inline functions needs to have
4260 current_buffer in scope now, rather than later when the macros
4261 are used.
4262 (downcase, upcase1): New static inline functions.
4263 (DOWNCASE, UPCASE1): Reimplement using these functions.
4264 This avoids undefined behavior in expressions like
4265 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4266 from race conditions in accessing the global variables
4267 case_temp1 and case_temp2.
4268 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4269 * lisp.h (case_temp1, case_temp2): Remove their decls.
4270 * character.h (ASCII_CHAR_P): Move from here ...
4271 * lisp.h: ... to here, so that the inline functions mentioned
4272 above can use them.
4273
4274 * dired.c (directory_files_internal_unwind): Now static.
4275
4276 * fileio.c (file_name_as_directory, directory_file_name):
4277 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4278 Now static.
4279 (file_name_as_directory): Use const pointers when appropriate.
4280 (Fexpand_file_name): Likewise. In particular, newdir might
4281 point at constant storage, so make it a const pointer.
4282 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4283 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4284 signedness issues.
4285 (Fset_file_times, Finsert_file_contents, auto_save_error):
4286 Rename locals to avoid shadowing.
4287
4288 * minibuf.c (choose_minibuf_frame_1): Now static.
4289 (Ftry_completion, Fall_completions): Rename or remove locals
4290 to avoid shadowing.
4291
4292 * marker.c (bytepos_to_charpos): Remove; unused.
4293
4294 * lisp.h (verify_bytepos, count_markers): New decls,
4295 so that gcc does not warn that these functions aren't declared.
4296
4297 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4298 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4299 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4300 (copy_text): Remove unused local var.
4301
4302 * filelock.c (within_one_second): Now static.
4303 (lock_file_1): Rename local to avoid shadowing.
4304
4305 * buffer.c (fix_overlays_before): Mark locals as initialized.
4306 (fix_start_end_in_overlays): Likewise. This function should be
4307 simplified by using pointers-to-pointers, but that's a different
4308 matter.
4309 (switch_to_buffer_1): Now static.
4310 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4311 (report_overlay_modification): Rename locals to avoid shadowing.
4312
4313 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4314 Fix pointer signedness issue.
4315 (sys_subshell): Mark local as volatile if checking for lint,
4316 to suppress a gcc -Wclobbered warning that does not seem to be right.
4317 (MAXPATHLEN): Define only if needed.
4318
4319 * process.c (serial_open, serial_configure): Move decls from here ...
4320 * systty.h: ... to here, so that they can be checked.
4321
4322 * fns.c (get_random, seed_random): Move extern decls from here ...
4323 * lisp.h: ... to here, so that they can be checked.
4324
4325 * sysdep.c (reset_io): Now static.
4326 (wait_for_termination_signal): Remove; unused.
4327
4328 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4329 (copy_keymap_item, append_key, push_text_char_description):
4330 Now static.
4331 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4332 (DENSE_TABLE_SIZE): Remove; unused.
4333 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4334 (describe_map_tree):
4335 Rename locals to avoid shadowing.
4336
4337 * keyboard.c: Declare functions static if they are not used elsewhere.
4338 (echo_char, echo_dash, cmd_error, top_level_2):
4339 (poll_for_input, handle_async_input): Now static.
4340 (read_char, kbd_buffer_get_event, make_lispy_position):
4341 (make_lispy_event, make_lispy_movement, apply_modifiers):
4342 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4343 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4344 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4345 (read_key_sequence, read_char): Mark locals as initialized.
4346 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4347
4348 * keyboard.h (make_ctrl_char): New decl.
4349 (mark_kboards): Move decl here ...
4350 * alloc.c (mark_kboards): ... from here.
4351
4352 * lisp.h (force_auto_save_soon): New decl.
4353
4354 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4355 (DEFINE_DUMMY_FUNCTION): New macro.
4356 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4357 Use it.
4358 (main): Add casts to avoid warnings
4359 if GCC considers string literals to be constants.
4360
4361 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4362
4363 * dbusbind.c: Pointer signedness fixes.
4364 (xd_signature, xd_append_arg, xd_initialize):
4365 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4366 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4367 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4368 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4369
4370 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4371 if GCC considers string literals to be constants.
4372 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4373
4374 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4375
4376 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4377 (print_preprocess, print_object): New macro to fix last change.
4378
4379 * print.c (print_preprocess): Don't forget font objects.
4380
4381 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4382
4383 * emacs.c (USAGE3): Doc fixes.
4384
4385 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4386
4387 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4388 structure.
4389
4390 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4391
4392 * lisp.h (VWindow_system, Qfile_name_history):
4393 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4394 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4395 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4396
4397 * w32select.c: Don't #include "keyboard.h".
4398 (run_protected): Add extern declaration for waiting_for_input.
4399
4400 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4401 * w32console.c (detect_input_pending, read_input_pending)
4402 (encode_terminal_code):
4403 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4404 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4405 (w32_system_caret_y, Qfile_name_history):
4406 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4407 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4408 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4409 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4410 * w32proc.c (Qlocal, report_file_error):
4411 * w32term.c (Vwindow_system, updating_frame):
4412 * w32uniscribe.c (initialized, uniscribe_font_driver):
4413 Remove unneeded extern declarations.
4414
4415 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4416
4417 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4418
4419 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4420
4421 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4422 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4423 These macros can no longer be used for assignment.
4424
4425 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4426 Assign struct members directly, instead of using BUF_BEGV etc.
4427 (record_buffer_markers, fetch_buffer_markers): New functions for
4428 recording and fetching special buffer markers.
4429 (set_buffer_internal_1, set_buffer_temp): Use them.
4430
4431 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4432
4433 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4434
4435 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4436 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4437
4438 * xdisp.c (hscroll_window_tree):
4439 (reconsider_clip_changes): Use PT instead of BUF_PT.
4440
4441 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4442
4443 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4444 $(EMACS_ROOT)/lib/intprops.h.
4445
4446 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 Fix more problems found by GCC 4.5.2's static checks.
4449
4450 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4451 to unsigned char * to avoid compiler diagnostic.
4452 (xg_free_frame_widgets): Make it clear that a local variable is
4453 needed only if USE_GTK_TOOLTIP.
4454 (gdk_window_get_screen): Make it clear that this macro is needed
4455 only if USE_GTK_TOOLTIP.
4456 (int_gtk_range_get_value): New function, which avoids a diagnostic
4457 from gcc -Wbad-function-cast.
4458 (xg_set_toolkit_scroll_bar_thumb): Use it.
4459 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4460 diagnostic from gcc -Wbad-function-cast.
4461 (get_utf8_string, xg_get_file_with_chooser):
4462 Rename locals to avoid shadowing.
4463 (create_dialog): Move locals to avoid shadowing.
4464
4465 * xgselect.c (xg_select): Remove unused var.
4466
4467 * image.c (four_corners_best): Mark locals as initialized.
4468 (gif_load): Initialize transparent_p to zero (Bug#8238).
4469 Mark another local as initialized.
4470 (my_png_error, my_error_exit): Mark with NO_RETURN.
4471
4472 * image.c (clear_image_cache): Now static.
4473 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4474 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4475 (x_edge_detection): Remove unnecessary cast that
4476 gcc -Wbad-function-cast diagnoses.
4477 (gif_load): Fix pointer signedness.
4478 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4479 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4480
4481 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4482
4483 Improve quality of tests for time stamp overflow.
4484 For example, without this patch (encode-time 0 0 0 1 1
4485 1152921504606846976) returns the obviously-bogus value (-948597
4486 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4487 reports time overflow. See
4488 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4489 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4490 * editfns.c: Include limits.h and intprops.h.
4491 (TIME_T_MIN, TIME_T_MAX): New macros.
4492 (time_overflow): Move earlier, to before first use.
4493 (hi_time, lo_time): New functions, for an accurate test for
4494 out-of-range times.
4495 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4496 (Fget_internal_run_time): Don't assume time_t fits in int.
4497 (make_time): Use list2 instead of Fcons twice.
4498 (Fdecode_time): More accurate test for out-of-range times.
4499 (check_tm_member): New function.
4500 (Fencode_time): Use it, to test for out-of-range times.
4501 (lisp_time_argument): Don't rely on undefined left-shift and
4502 right-shift behavior when checking for time stamp overflow.
4503
4504 * editfns.c (time_overflow): New function, refactoring common code.
4505 (Fformat_time_string, Fdecode_time, Fencode_time):
4506 (Fcurrent_time_string): Use it.
4507
4508 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4509 * dired.c (make_time): Move to ...
4510 * editfns.c (make_time): ... here.
4511 * systime.h: Note the move.
4512
4513 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4514
4515 * fringe.c (update_window_fringes): Remove unused variables.
4516
4517 * unexmacosx.c (copy_data_segment): Also copy __got section.
4518 (Bug#8223)
4519
4520 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4521
4522 * termcap.c [MSDOS]: Include "msdos.h".
4523 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4524 Constify `char *' arguments and their references according to
4525 prototypes in tparam.h.
4526
4527 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4528
4529 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4530 Adapt all references accordingly.
4531
4532 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4533
4534 2011-03-11 Tom Tromey <tromey@redhat.com>
4535
4536 * buffer.c (syms_of_buffer): Remove obsolete comment.
4537
4538 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4539
4540 * termhooks.h (encode_terminal_code): Declare prototype.
4541
4542 * msdos.c (encode_terminal_code): Don't declare prototype.
4543
4544 * term.c (encode_terminal_code): Now external again, used by
4545 w32console.c and msdos.c.
4546
4547 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4548 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4549
4550 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 Fix some minor problems found by GCC 4.5.2's static checks.
4553
4554 * fringe.c (update_window_fringes): Mark locals as initialized
4555 (Bug#8227).
4556 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4557
4558 * alloc.c (mark_fringe_data): Move decl from here ...
4559 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4560 to check its interface.
4561 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4562
4563 * fontset.c (free_realized_fontset): Now static.
4564 (Fset_fontset_font): Rename local to avoid shadowing.
4565 (fontset_font): Mark local as initialized.
4566 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4567
4568 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4569
4570 * xselect.c (x_disown_buffer_selections): Remove; not used.
4571 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4572 (x_own_selection, Fx_disown_selection_internal): Rename locals
4573 to avoid shadowing.
4574 (x_handle_dnd_message): Remove local to avoid shadowing.
4575
4576 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4577 so that the caller can use some name other than gcpro1.
4578 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4579 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4580 (Fx_backspace_delete_keys_p):
4581 Use them to avoid shadowing, and rename vars to avoid shadowing.
4582 (x_decode_color, x_set_name, x_window): Now static.
4583 (Fx_create_frame): Add braces to silence GCC warning.
4584 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4585 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4586 Remove unused locals.
4587 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4588 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4589 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4590 macros.
4591
4592 * xterm.h (x_mouse_leave): New decl.
4593
4594 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4595 Remove unused functions.
4596 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4597 (x_calc_absolute_position): Now static.
4598 (XTread_socket): Don't define label "out" unless it's used.
4599 Don't declare local "event" unless it's used.
4600 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4601 unless they are used.
4602 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4603 (x_fatal_error_signal): Remove; not used.
4604 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4605 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4606 (x_error_catcher, x_connection_closed, x_error_handler):
4607 (x_error_quitter, xembed_send_message, x_iconify_frame):
4608 (my_log_handler): Rename locals to avoid shadowing.
4609 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4610 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4611
4612 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4613 Rename or move locals to avoid shadowing.
4614 (tty_defined_color, merge_face_heights): Now static.
4615 (free_realized_faces_for_fontset): Remove; not used.
4616 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4617 does not deduce is never used uninitialized.
4618 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4619 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4620
4621 * terminal.c (store_terminal_param): Now static.
4622
4623 * xmenu.c (menu_highlight_callback): Now static.
4624 (set_frame_menubar): Remove unused local.
4625 (xmenu_show): Rename parameter to avoid shadowing.
4626 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4627 since they might point to immutable storage.
4628 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4629 since it's unused otherwise.
4630
4631 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4632 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4633 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4634 avoids a gcc -Wuninitialized diagnostic.
4635 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4636 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4637 does not deduce are never used uninitialized.
4638
4639 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4640
4641 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4642 * window.c (window_loop, size_window):
4643 (run_window_configuration_change_hook, enlarge_window): Likewise.
4644
4645 * window.c (display_buffer): Now static.
4646 (size_window): Mark variables that gcc -Wuninitialized
4647 does not deduce are never used uninitialized.
4648 * window.h (check_all_windows): New decl, to forestall
4649 gcc -Wmissing-prototypes diagnostic.
4650 * dispextern.h (bidi_dump_cached_states): Likewise.
4651
4652 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4653 shadowing.
4654 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4655 Include <limits.h>.
4656 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4657 and to avoid gcc -Wuninitialized warning.
4658 (load_charset_map): Mark variables that gcc -Wuninitialized
4659 does not deduce are never used uninitialized.
4660 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4661
4662 * coding.c (coding_set_source, coding_set_destination):
4663 Use "else { /* comment */ }" rather than "else /* comment */;"
4664 for clarity, and to avoid gcc -Wempty-body warning.
4665 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4666 a block, when the outer 'i' will do.
4667 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4668 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4669 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4670 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4671 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4672 Rename locals to avoid shadowing.
4673 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4674 * coding.c (emacs_mule_char, encode_invocation_designation):
4675 Now static, since they're not used elsewhere.
4676 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4677 (decode_coding_object, encode_coding_object, detect_coding_system):
4678 (decode_coding_emacs_mule): Mark variables that gcc
4679 -Wuninitialized does not deduce are never used uninitialized.
4680 (detect_coding_iso_2022): Initialize a local variable that might
4681 be used uninitialized. Leave a FIXME because it's not clear that
4682 this initialization is needed. (Bug#8211)
4683 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4684 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4685 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4686 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4687 Remove unused macros.
4688
4689 * category.c (hash_get_category_set): Remove unused local var.
4690 (copy_category_table): Now static, since it's not used elsewhere.
4691 * character.c (string_count_byte8): Likewise.
4692
4693 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4694 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4695
4696 * chartab.c (copy_sub_char_table): Now static, since it's not used
4697 elsewhere.
4698 (sub_char_table_ref_and_range, char_table_ref_and_range):
4699 Rename locals to avoid shadowing.
4700 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4701
4702 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4703 (BIDI_BOB): Remove unused macro.
4704
4705 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4706 deduce are never used uninitialized.
4707 * term.c (encode_terminal_code): Likewise.
4708
4709 * term.c (encode_terminal_code): Now static. Remove unused local.
4710
4711 * tparam.h: New file.
4712 * term.c, tparam.h: Include it.
4713 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4714 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4715 Move these decls to tparam.h, and make them agree with what
4716 is actually in tparam.c. The previous trick of using incompatible
4717 decls in different modules does not conform to the C standard.
4718 All callers of tparam changed to use tparam's actual API.
4719 * tparam.c (tparam1, tparam, tgoto):
4720 Use const pointers where appropriate.
4721
4722 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4723 * cm.h (struct cm): Likewise.
4724 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4725 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4726 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4727 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4728 (turn_on_face, init_tty): Likewise.
4729 * termchar.h (struct tty_display_info): Likewise.
4730
4731 * term.c (term_mouse_position): Rename local to avoid shadowing.
4732
4733 * alloc.c (mark_ttys): Move decl from here ...
4734 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4735
4736 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4737
4738 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4739
4740 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4741
4742 * search.c (compile_pattern_1): Remove argument regp, unused since
4743 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4744 (compile_pattern): Don't pass it.
4745
4746 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4747
4748 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4749 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4750 for ! HAVE_GTK3.
4751 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4752
4753 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4754
4755 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4756 gdk_window_get_screen, gdk_window_get_geometry,
4757 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4758 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4759 (xg_get_pixbuf_from_pixmap): New function.
4760 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4761 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4762 Call xg_get_pixbuf_from_pixmap instead of
4763 gdk_pixbuf_get_from_drawable.
4764 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4765 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4766 (xg_check_special_colors): Use GtkStyleContext and its functions
4767 for HAVE_GTK3.
4768 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4769 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4770 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4771 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4772 Call gtk_widget_get_preferred_size.
4773 (xg_frame_resized): gdk_window_get_geometry only takes 5
4774 parameters.
4775 (xg_win_to_widget, xg_event_is_for_menubar):
4776 Call gdk_x11_window_lookup_for_display.
4777 (xg_set_widget_bg): New function.
4778 (delete_cb): New function.
4779 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4780 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4781 (xg_set_background_color): Call xg_set_widget_bg.
4782 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4783 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4784 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4785 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4786 if ! HAVE_GTK3.
4787 (update_frame_tool_bar): Call gtk_widget_hide.
4788 (xg_initialize): Use GDK_KEY_g.
4789
4790 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4791 if ! HAVE_GTK3
4792 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4793
4794 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4795 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4796 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4797
4798 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4799
4800 * w32xfns.c (select_palette): Check success of RealizePalette against
4801 GDI_ERROR, not zero.
4802
4803 See ChangeLog.11 for earlier changes.
4804
4805 ;; Local Variables:
4806 ;; coding: utf-8
4807 ;; End:
4808
4809 Copyright (C) 2011 Free Software Foundation, Inc.
4810
4811 This file is part of GNU Emacs.
4812
4813 GNU Emacs is free software: you can redistribute it and/or modify
4814 it under the terms of the GNU General Public License as published by
4815 the Free Software Foundation, either version 3 of the License, or
4816 (at your option) any later version.
4817
4818 GNU Emacs is distributed in the hope that it will be useful,
4819 but WITHOUT ANY WARRANTY; without even the implied warranty of
4820 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4821 GNU General Public License for more details.
4822
4823 You should have received a copy of the GNU General Public License
4824 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.