1 2012-07-12 Glenn Morris <rgm@gnu.org>
3 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
4 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
5 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
6 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
8 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
9 Move PTY_OPEN to configure.
11 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
12 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
13 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
15 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
17 Use empty_unibyte_string where applicable.
18 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
19 * lread.c (read1): Likewise.
20 * xsettings.c (syms_of_xsettings): Likewise.
22 2012-07-12 Glenn Morris <rgm@gnu.org>
24 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
25 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
26 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
27 * s/hpux10-20.h (RUN_TIME_REMAP):
28 * s/bsd-common.h (TABDLY): Move to configure.
30 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
32 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
34 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
35 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
37 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
39 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
40 * s/template.h: Move NARROWPROTO to configure.
42 2012-07-11 Glenn Morris <rgm@gnu.org>
44 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
45 unused since 2011-01-17 change to systty.h.
47 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
48 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
49 Move HAVE_PTYS and HAVE_SOCKETS to configure.
51 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
53 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
55 2012-07-11 Glenn Morris <rgm@gnu.org>
57 * s/darwin.h, s/gnu-linux.h, s/template.h:
58 Move INTERRUPT_INPUT to configure.
60 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
62 Minor adjustments to interning code.
63 * lisp.h (intern, intern_c_string): Redefine as static inline
64 wrappers for intern_1 and intern_c_string_1, respectively.
65 (intern_1, intern_c_string_1): Rename prototypes.
66 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
68 * font.c (font_intern_prop): Likewise. Adjust comment.
69 * w32font.c (intern_font_name): Likewise.
71 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
73 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
75 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
76 of Fcar/Fcdr if possible.
77 * font.c (check_otf_features): Likewise.
78 * fontset.c (Fnew_fontset): Likewise.
79 * gnutls.c (Fgnutls_boot): Likewise.
80 * minibuf.c (read_minibuf): Likewise.
81 * msdos.c (IT_set_frame_parameters): Likewise.
82 * xmenu.c (Fx_popup_dialog): Likewise.
83 * w32menu.c (Fx_popup_dialog): Likewise.
85 2012-07-11 Glenn Morris <rgm@gnu.org>
87 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
88 since nothing has defined it on these platforms.
90 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
91 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
93 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
94 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
95 Move CLASH_DETECTION to configure.
97 * s/gnu.h: Remove file, which is now empty.
99 * s/gnu.h, s/gnu-linux.h:
100 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
102 2012-07-11 John Wiegley <johnw@newartisans.com>
104 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
105 function attribute, so we only use it if it exists in the
108 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
110 Avoid call to strlen in fast_c_string_match_ignore_case.
111 * search.c (fast_c_string_match_ignore_case): Change to use
112 length argument. Adjust users accordingly.
113 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
115 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
118 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
119 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
122 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
125 * s/hpux10-20.h (HAVE_PERROR): Remove.
126 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
127 Remove dummy definition, as this problem was obsolete long ago.
130 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
132 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
134 Avoid calls to strlen in font processing functions.
135 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
136 (font_open_by_name): Change to use length argument. Adjust
138 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
140 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
141 Change to return ptrdiff_t.
142 (xfont_list_pattern, xfont_match): Use length returned by
143 xfont_decode_coding_xlfd.
144 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
146 2012-07-11 Glenn Morris <rgm@gnu.org>
148 * s/darwin.h, s/freebsd.h, s/netbsd.h:
149 Move DONT_REOPEN_PTY to configure.
151 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
152 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
154 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
156 Remove "#define unix" that is no longer needed (Bug#11905).
157 * s/aix4-2.h (unix): Remove; no longer needed.
159 EMACS_TIME simplification (Bug#11875).
160 This replaces macros (which typically do not work in GDB)
161 with functions, typedefs and enums, making the code easier to debug.
162 The functional style also makes code easier to read and maintain.
163 * systime.h: Include <sys/time.h> on all hosts, not just if
164 WINDOWSNT, since 'struct timeval' is needed in general.
165 (EMACS_TIME): Now a typedef, not a macro.
166 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
168 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
169 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
170 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
171 (EMACS_TIME_LE): Now functions, not macros.
172 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
173 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
174 which are not functions. All uses rewritten to use:
175 (make_emacs_time): New function.
176 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
177 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
178 not functions. All uses rewritten to use the following, respectively:
179 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
180 (add_emacs_time, sub_emacs_time): New functions.
181 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
182 * fileio.c (Fcopy_file):
183 * xterm.c (XTflash): Get the current time closer to when it's used.
184 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
186 * bytecode.c (targets): Suppress -Woverride-init warnings.
188 Simplify by avoiding confusing use of strncpy etc.
189 * doc.c (Fsnarf_documentation):
190 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
191 * frame.c (Fmake_terminal_frame):
192 * gtkutil.c (get_utf8_string):
194 * nsmenu.m (ns_update_menubar):
195 * regex.c (regerror):
196 Prefer memcpy to strncpy and strncat when either will do.
197 * fileio.c (Fsubstitute_in_file_name):
198 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
199 (menu_separator_name_p):
200 * nsmenu.m (ns_update_menubar):
201 Prefer memcmp to strncmp when either will do.
202 * nsterm.m: Include <ftoastr.h>.
204 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
205 Prefer snprintf to strncpy.
206 * nsterm.m (ns_term_init):
207 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
208 * nsterm.m (ns_term_init):
209 Avoid the need for strncpy, by using build_string or
210 make_unibyte_string directly. Use dtoastr, not snprintf.
211 * process.c (Fmake_network_process): Diagnose service names that
212 are too long, rather than silently truncating them or creating
213 non-null-terminated names.
214 (Fnetwork_interface_info): Likewise, for interface names.
215 * sysdep.c (system_process_attributes) [GNU_LINUX]:
216 Prefer sprintf to strncat.
217 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
218 Prefer vsnprintf to vsprintf + strncpy.
220 2012-07-10 Glenn Morris <rgm@gnu.org>
222 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
223 Clarify fallback case.
225 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
227 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
228 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
229 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
230 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
231 where argument type is known to be a Lisp_Cons.
233 2012-07-10 Tom Tromey <tromey@redhat.com>
235 * bytecode.c (BYTE_CODE_THREADED): New macro.
236 (BYTE_CODES): New macro. Replaces all old byte-code defines.
237 (enum byte_code_op): New type.
238 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
239 (exec_byte_code): Use them. Use token threading when applicable.
241 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
243 Optimize pure C strings initialization.
244 * lisp.h (make_pure_string): Fix prototype.
245 (build_pure_c_string): New function, defined as static inline. This
246 provides a better opportunity to optimize away calls to strlen when
247 the function is called with compile-time constant argument.
248 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
249 argument, adjust users accordingly. Use build_pure_c_string where
251 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
252 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
253 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
255 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
257 Avoid calls to strlen in miscellaneous functions.
258 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
259 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
260 * lread.c (openp): Likewise.
262 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
264 Avoid calls to strlen in path processing functions.
265 * fileio.c (file_name_as_directory): Add comment. Change to add
266 srclen argument and return the length of result. Adjust users
268 (directory_file_name): Fix comment. Change to add srclen argument,
269 swap 1st and 2nd arguments to obey the common convention. Adjust
271 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
273 2012-07-10 Glenn Morris <rgm@gnu.org>
275 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
276 Move PENDING_OUTPUT_COUNT definition to configure.
278 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
279 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
280 * s/gnu.h (DATA_START): Move definitions to configure.
282 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
283 We include usg5-4-common.h, which defines them both.
285 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
286 O_RDONLY already includes it).
288 Stop ns builds setting the EMACSLOADPATH environment variable.
289 * nsterm.m (ns_load_path): Rename from ns_init_paths.
290 Now it does not set EMACSLOADPATH, just returns the load-path string.
291 * nsterm.h: Update accordingly.
292 * lread.c [HAVE_NS]: Include nsterm.h.
293 (init_lread) [HAVE_NS]: Use ns_load_path.
294 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
296 2012-07-09 Glenn Morris <rgm@gnu.org>
298 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
299 since the included bsd-common.h does so.
301 Stop ns builds setting the EMACSPATH environment variable.
302 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
303 (ns_init_paths): Do not set EMACSPATH.
304 * nsterm.h (ns_exec_path): Add it.
305 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
308 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
310 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
312 * process.c (wait_reading_process_output): 'waitchannels' was unset
313 when read_kbd || !NILP (wait_for_cell); fix this.
315 Add GCC-style 'const' attribute to functions that can use it.
316 * character.h (char_resolve_modifier_mask):
317 * keyboard.h (make_ctrl_char):
318 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
319 (init_character_once, next_almost_prime, init_fns, init_image)
320 (flush_pending_output, init_sound):
321 * mem-limits.h (start_of_data):
322 * menu.h (finish_menu_items):
324 * emacs.c (DEFINE_DUMMY_FUNCTION):
325 Declare the dummy function with ATTRIBUTE_CONST.
326 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
327 Add decls with ATTRIBUTE_CONST.
329 Minor improvements to make_formatted_string.
330 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
331 where int is good enough, as vsprintf returns an int.
332 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
334 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
336 Use make_formatted_string to avoid double length calculation.
337 * lisp.h (make_formatted_string): New prototype.
338 * alloc.c (make_formatted_string): New function.
339 * buffer.c (Fgenerate_new_buffer_name): Use it.
340 * dbus.c (syms_of_dbusbind): Likewise.
341 * editfns.c (Fcurrent_time_zone): Likewise.
342 * filelock.c (get_boot_time): Likewise.
343 * frame.c (make_terminal_frame, set_term_frame_name)
344 (x_report_frame_params): Likewise.
345 * image.c (gs_load): Likewise.
346 * minibuf.c (get_minibuffer): Likewise.
347 * msdos.c (dos_set_window_size): Likewise.
348 * process.c (make_process): Likewise.
349 * xdisp.c (ensure_echo_area_buffers): Likewise.
350 * xsettings.c (apply_xft_settings): Likewise.
352 2012-07-09 Glenn Morris <rgm@gnu.org>
354 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
355 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
356 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
357 * nsterm.h (ns_etc_directory): Add it.
358 * callproc.c [HAVE_NS]: Include nsterm.h.
359 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
361 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
363 Move marker debugging code under MARKER_DEBUG.
364 * marker.c (MARKER_DEBUG): Move marker debugging code under
365 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
366 for bootstrap with --enable-checking (~3x slowdown reported
367 by Juanma Barranquero <lekktu@gmail.com>).
368 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
370 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
372 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
373 See <http://bugs.gnu.org/11825#29>.
375 2012-07-08 Eli Zaretskii <eliz@gnu.org>
377 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
378 has no font, use the frame's font. (Bug#11813)
379 (display_line): Add commentary about displaying truncation glyphs
381 (produce_special_glyphs): Move here from term.c.
383 * term.c (produce_special_glyphs): Move to xdisp.c.
385 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
388 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
390 * xdisp.c (display_line): Avoid warning about implicit declaration
393 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
395 * lisp.h: Remove empty conditional.
397 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
399 * lread.c (load_path_check): Now static.
401 Fix some minor --with-ns problems found by static checking.
402 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
403 (x_set_font) [!HAVE_X_WINDOWS]:
404 * image.c (xpm_load_image) [HAVE_NS]:
405 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
406 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
408 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
409 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
410 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
411 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
412 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
413 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
414 Fix pointer signedness problem.
415 * xfaces.c (FRAME_X_FONT_TABLE):
416 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
418 2012-07-07 Glenn Morris <rgm@gnu.org>
420 * lread.c (load_path_check): New function, split from init_lread.
421 (init_lread): Reorganize. Motivation:
422 If EMACSLOADPATH is set, check/warn about that rather than the
423 defaults, which we are not going to use. Hence we can remove
424 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
425 Don't warn if site-lisp directories are missing.
426 If not installed, start from a blank load-path, since
427 PATH_LOADSEARCH refers to the eventual installation directories.
429 2012-07-07 Eli Zaretskii <eliz@gnu.org>
431 Support truncation and continuation glyphs on GUI frames, when
432 fringes are disabled. (Bug#11832)
433 * xdisp.c (init_iterator): Get dimensions of truncation and
434 continuation glyphs even if on GUI frames. Adjust
435 it->last_visible_x on GUI frames when the left or right fringes,
437 (start_display, move_it_in_display_line_to): Handle the case of a
438 GUI frame without a fringe to display continuation or truncation
440 (insert_left_trunc_glyphs): Support GUI frames: make sure
441 truncation glyphs overwrite enough glyphs from the current line to
442 have sufficient space in pixels.
443 (display_line): Support truncation and continuation glyphs on GUI
444 frames. If some spare pixels are left on the line after inserting
445 the truncation glyphs, fill that space with a stretch glyph of a
446 suitably computed width.
448 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
449 produce_glyphs, to support GUI sessions.
451 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
453 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
455 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
457 Do not require float-time's arg to fit in time_t (Bug#11825).
458 This works better on hosts where time_t is unsigned, and where
459 float-time is applied to the (negative) difference between two times.
460 * editfns.c (decode_time_components): Last arg is now double *,
461 not int *, and means to store all the result as a double, without
462 worrying about whether the seconds part fits in time_t.
464 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
466 (Ffloat_time): Do not fail merely because the specified time falls
467 outside of time_t range.
469 2012-07-07 Glenn Morris <rgm@gnu.org>
471 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
472 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
473 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
475 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
477 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
480 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
482 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
484 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
485 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
486 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
487 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
488 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
489 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
491 * xfont.c (compare_font_names): Redo to omit the need for casts.
493 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
495 * xfns.c (Fx_change_window_property): Doc fix.
496 * w32fns.c (Fx_change_window_property): Doc fix.
498 * w32fns.c (Fx_window_property): Accept the same arguments as the
499 X Windows version. Doc fix.
500 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
502 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
503 Eli Zaretskii <eliz@gnu.org>
505 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
506 Windows-specific code from nt/config.nt moved here.
507 Obsolete settings removed.
509 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
511 * process.c: Avoid unnecessary calls to gettime.
512 (wait_reading_process_output): Don't get the time of day
513 when gobbling data immediately and not waiting, as there's no need
514 for it in that case. This removes a FIXME.
516 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
518 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
519 is defined (Bug#11768).
521 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
523 Fix marker debugging code.
524 * marker.c (byte_char_debug_check): Do not perform the check
525 if buffer is not multibyte.
526 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
527 Call byte_char_debug_check with correct arguments.
529 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
531 Compile marker debugging code only if ENABLE_CHECKING is defined.
532 * marker.c (byte_char_debug_check, count_markers):
533 Use only if ENABLE_CHECKING is defined.
534 (byte_debug_flag): Remove.
535 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
536 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
538 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
540 Avoid code repetition in marker-related functions.
541 * marker.c (attach_marker): New function.
542 (Fset_marker, set_marker_restricted, set_marker_both)
543 (set_marker_restricted_both): Use it.
544 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
545 Consistently rename charno to charpos.
546 (marker_position): Add eassert.
547 (marker_byte_position): Convert to eassert.
549 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
551 Simplify list operations in unchain_overlay and unchain_marker.
552 * buffer.c (unchain_overlay): Simplify. Add comment.
553 * marker.c (unchain_marker): Simplify. Fix comments.
555 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
557 Introduce fast path for the widely used marker operation.
558 * alloc.c (build_marker): New function.
559 * lisp.h (build_marker): New prototype.
560 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
561 * composite.c (autocmp_chars): Likewise.
562 * editfns.c (buildmark): Remove.
563 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
564 (save_restriction_save): Use build_marker.
565 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
566 * window.c (save_window_save): Likewise.
568 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
570 Do not use Fdelete_overlay in delete_all_overlays
571 to avoid redundant calls to unchain_overlay.
572 * buffer.c (drop_overlay): New function.
573 (delete_all_overlays, Fdelete_overlay): Use it.
574 * minibuf.c (get_minibuffer): Fix comment.
576 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
578 Port to OpenBSD 5.1 amd64.
579 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
580 This is needed for OpenBSD, and should be harmless on all BSD systems.
581 Also, include <sys/sysctl.h>, as it should be available on all
582 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
583 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
584 use p_pid member, not kp_proc.pid.
586 2012-07-06 Glenn Morris <rgm@gnu.org>
588 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
590 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
592 More xmalloc and related cleanup.
593 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
594 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
595 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
596 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
597 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
598 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
599 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
600 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
601 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
603 Omit needless casts involving void * pointers and allocation.
604 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
605 as the former is more robust if P's type is changed.
606 Prefer xzalloc to xmalloc + memset 0.
607 Simplify malloc-or-realloc to realloc.
608 Don't worry about xmalloc returning a null pointer.
609 Prefer xstrdup to xmalloc + strcpy.
610 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
612 * keyboard.c (apply_modifiers_uncached): Prefer local array to
613 alloca of a constant.
615 2012-07-05 Eli Zaretskii <eliz@gnu.org>
617 * xdisp.c (display_line): Fix horizontal pixel coordinates when
618 hscroll is larger than the line width. Fixes long and futile
619 looping inside extend_face_to_end_of_line (on a TTY) producing
620 glyphs that are not needed and thrown away.
622 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
624 * marker.c (set_marker_restricted_both): Simplify by using
627 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
629 * editfns.c (region_limit): Simplify by using clip_to_bounds.
631 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
633 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
634 not defined (Bug#11768).
635 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
636 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
637 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
638 followed by gtk_box_set_homogeneous (Bug#11768).
639 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
640 (update_theme_scrollbar_width, xg_create_scroll_bar):
641 Use gtk_scrollbar_new (Bug#11768).
642 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
643 (is_box_type): New function (Bug#11768).
644 (xg_tool_item_stale_p): Call is_box_type.
645 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
646 with default display (Bug#11768).
648 2012-07-05 Eli Zaretskii <eliz@gnu.org>
650 * xdisp.c (window_hscroll_limited): New function.
651 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
652 coordinates when window's hscroll is set to insanely large
655 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
657 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
658 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
660 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
663 * lisp.h (xzalloc): New prototype. Omit needless casts.
664 * alloc.c (xzalloc): New function. Omit needless casts.
665 * charset.c: Omit needless casts. Convert all calls to
666 xmalloc with following memset to xzalloc.
667 * dispnew.c: Likewise.
668 * fringe.c: Likewise.
672 * w32fns.c: Likewise.
673 * w32font.c: Likewise.
674 * w32term.c: Likewise.
675 * xfaces.c: Likewise.
678 * atimer.c: Omit needless casts.
679 * buffer.c: Likewise.
680 * callproc.c: Likewise.
682 * coding.c: Likewise.
683 * composite.c: Likewise.
685 * doprnt.c: Likewise.
686 * editfns.c: Likewise.
689 * filelock.c: Likewise.
691 * gtkutil.c: Likewise.
692 * keyboard.c: Likewise.
695 * minibuf.c: Likewise.
698 * process.c: Likewise.
699 * region-cache.c: Likewise.
700 * search.c: Likewise.
701 * sysdep.c: Likewise.
702 * termcap.c: Likewise.
703 * terminal.c: Likewise.
704 * tparam.c: Likewise.
705 * w16select.c: Likewise.
707 * w32reg.c: Likewise.
708 * w32select.c: Likewise.
709 * w32uniscribe.c: Likewise.
710 * widget.c: Likewise.
714 * xselect.c: Likewise.
716 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
718 * fileio.c (time_error_value): Check the right error number.
719 Problem reported by Troels Nielsen in
720 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
722 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
724 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
725 This should be fixed in a better way; see Eli Zaretskii in
726 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
727 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
729 * fileio.c (time_error_value): Rename from special_mtime.
730 The old name's problems were noted by Eli Zaretskii in
731 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
733 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
734 This variable's comment says Emacs needs at least one GDB-visible
735 symbol of type enum pvec_type, to work around GDB problems.
736 The symbol's value doesn't matter.
738 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
739 that causes compilation to fail on pre-C99 compilers.
741 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
743 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
744 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
746 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
748 * buffer.c (init_buffer_once): Fix initialization of
749 headers for buffer_defaults and buffer_local_symbols.
750 Reported by Juanma Barranquero <lekktu@gmail.com>.
752 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
754 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
755 * lisp.h (enum pvec_type): Use fewer bits.
756 (PSEUDOVECTOR_SIZE_BITS): New constant.
757 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
758 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
760 (PSEUDOVECTOR_TYPEP): New macro.
761 (TYPED_PSEUDOVECTORP): Use it.
762 * fns.c (internal_equal): Adapt code to extract pvectype.
763 * emacs.c (gdb_pvec_type): Update type.
764 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
765 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
766 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
767 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
768 (sweep_vectors): Use it. Use local var `total_bytes' instead of
769 abusing vector->header.next.nbytes.
770 (live_vector_p): Use PVEC_TYPE.
771 (mark_object): Adapt code to extract pvectype. Use switch.
773 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
775 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
776 Tighten new eassert a bit.
778 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
780 Fix compilation with --enable-gcc-warnings and -O1
782 * doprnt.c (doprnt): Change type of tem to int, initialize
783 to avoid compiler warning. Add eassert.
784 * search.c (simple_search): Initialize match_byte to avoid
785 compiler warning. Add eassert.
787 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
789 Avoid weird behavior with large horizontal scrolls.
790 Without this change, for example, large hscroll values would
791 mess up Emacs's display on Fedora 15 x86, presumably due to
792 overflows in int calculations in the display code.
793 Also, if buffers had long lines, Emacs would freeze.
794 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
795 (set_window_hscroll): New function, containing the old guts of
796 Fset_window_hscroll. Return the clipped value.
797 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
798 This avoids the need to check against PTRDIFF_MAX.
800 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
802 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
804 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
806 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
808 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
809 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
810 since GCC 4.4.6 issues a bogus warning for them.
812 Fix bugs in file timestamp newness comparisons.
813 * fileio.c (Ffile_newer_than_file_p):
814 * lread.c (Fload): Use full timestamp resolution of files,
815 not just the 1-second resolution, so that files that are only
816 slightly newer still count as newer.
817 * fileio.c (Ffile_newer_than_file_p): Don't assume file
818 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
820 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
822 * fileio.c: Improve handling of file time marker. (Bug#11852)
823 (special_mtime): New function.
824 (Finsert_file_contents, Fverify_visited_file_modtime):
825 Use it to set special mtime values consistently.
827 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
829 * fileio.c (Finsert_file_contents): Properly handle st_mtime
830 marker for non-existing file. (Bug#11852)
832 2012-07-03 Glenn Morris <rgm@gnu.org>
834 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
835 and did not make it into globals.h).
837 2012-07-03 Tom Tromey <tromey@redhat.com>
839 * window.c (Fset_window_margins, Fset_window_fringes)
840 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
841 * textprop.c (Fprevious_property_change): No longer static.
842 * syntax.c (Fsyntax_table_p): No longer static.
843 * process.c (Fget_process, Fprocess_datagram_address): No longer
845 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
846 * keyboard.c (Fcommand_execute): No longer static.
848 * insdel.c (Fcombine_after_change_execute): No longer static.
849 * image.c (Finit_image_library): No longer static.
850 * fileio.c (Fmake_symbolic_link): No longer static.
851 * eval.c (Ffetch_bytecode): No longer static.
852 * editfns.c (Fuser_full_name): No longer static.
853 * doc.c (Fdocumentation_property, Fsnarf_documentation):
855 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
857 * dired.c (Ffile_attributes): No longer static.
858 * composite.c (Fcomposition_get_gstring): No longer static.
859 * callproc.c (Fgetenv_internal): No longer static.
861 * ccl.h: Remove EXFUNs.
862 * buffer.h: Remove EXFUNs.
863 * dispextern.h: Remove EXFUNs.
864 * intervals.h: Remove EXFUNs.
865 * fontset.h: Remove EXFUN.
866 * font.h: Remove EXFUNs.
867 * dosfns.c (system_process_attributes): Remove EXFUN.
868 * keymap.h: Remove EXFUNs.
869 * lisp.h: Remove EXFUNs.
870 * w32term.h: Remove EXFUNs.
871 * window.h: Remove EXFUNs.
872 * xsettings.h: Remove EXFUN.
873 * xterm.h: Remove EXFUN.
875 2012-07-03 Glenn Morris <rgm@gnu.org>
877 * lisp.h (Frandom): Make it visible to C.
878 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
879 buffer for invisible buffers. (Bug#1229)
881 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
883 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
884 values which aren't power of 2.
885 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
886 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
889 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
891 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
893 * alloc.c (mark_object): Revert part of last patch to use `switch'.
895 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
897 * alloc.c (allocate_vector_block): Remove redundant
898 calls to mallopt if DOUG_LEA_MALLOC is defined.
899 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
900 avoid calls to mallopt if zero_vector is returned.
902 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
904 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
905 is enabled, avoid dereferencing NULL current_sblock if
908 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
910 Cleanup basic buffer management.
911 * buffer.h (struct buffer): Change layout to use generic vector
912 marking code. Fix some comments. Change type of 'clip_changed'
913 to bitfield. Remove unused #ifndef old.
914 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
915 (GET_OVERLAYS_AT): Fix indentation.
916 (for_each_per_buffer_object_at): New macro.
917 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
918 (Fbuffer_local_variables): Use it.
919 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
920 * alloc.c (allocate_buffer): Adjust to match new layout of
921 struct buffer. Fix comment.
922 (mark_overlay): New function.
923 (mark_buffer): Use it. Use mark_vectorlike to mark normal
924 Lisp area of struct buffer.
925 (mark_object): Use it. Adjust marking of misc objects
926 and related comments.
928 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
930 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
931 wrapper that is not needed because the wrapped code is a no-op (zero
932 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
933 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
935 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
937 * alloc.c (mark_buffer): Simplify. Remove prototype.
938 (mark_object): Add comment. Reorganize marking of vector-like
939 objects. Use CHECK_LIVE for all vector-like objects except buffers
940 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
941 redundant calls to mark_vectorlike for bool vectors.
943 2012-06-30 Glenn Morris <rgm@gnu.org>
945 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
947 * epaths.in (PATH_SITELOADSEARCH): New.
948 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
949 This is rather than relying on --enable-locallisppath elements
950 having "site-lisp" in their names. (Bug#10208#25, 11658)
952 2012-06-30 Eli Zaretskii <eliz@gnu.org>
954 * w32proc.c (sys_select): Accept and ignore one more argument.
956 * w32.c (emacs_gnutls_pull): Call select with one more argument.
958 * sysselect.h [DOS_NT]: Don't include sys/select.h.
959 (pselect) [!MS_DOS]: Redirect to sys_select.
961 * sysdep.c: Don't include dos.h and dosfns.h.
963 * process.c (sys_select):
964 * msdos.c (sys_select): Accept one more argument and ignore it.
966 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
967 adapt data types and code to that.
970 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
971 which clashes with the gnulib function of the same name.
973 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
975 * font.c (font_style_to_value, font_style_symbolic)
976 (font_prop_validate_style): Add type checks for values in
979 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
981 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
984 2012-06-29 Eli Zaretskii <eliz@gnu.org>
986 * xdisp.c (try_window_id): Undo last change.
988 * w32.c (getwd): Adjust commentary about startup_dir.
989 (init_environment): Always call sys_access, even in non-MSVC
990 builds. Don't chdir to the directory of the Emacs executable.
991 This undoes code from 1997 which was justified by the need to
992 "avoid conflicts when removing and renaming directories". But its
993 downside was that every relative file name was being interpreted
994 relative to the directory of the Emacs executable, which can never
995 be TRT. In particular, it broke sys_access when called with
997 (sys_access): Map GetLastError to errno.
999 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1001 * window.h (struct window): Change type of 'fringes_outside_margins'
1002 to bitfield. Fix comment. Adjust users accordingly.
1003 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1005 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1008 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1010 * gnutls.c (emacs_gnutls_handshake):
1011 Add QUIT to make the loop interruptible.
1013 2012-06-29 Glenn Morris <rgm@gnu.org>
1015 * charset.c (init_charset): Make lack of etc/charsets fatal.
1017 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1019 * editfns.c (region_limit): Fix type mismatch.
1021 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1023 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1024 undefined. Convert from xassert to eassert.
1025 * nsmenu.m: Convert from xassert to eassert.
1026 * nsterm.m: Likewise.
1028 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1030 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1032 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1034 Avoid integer overflow on scroll-left and scroll-right.
1035 * window.c (HSCROLL_MAX): New macro.
1036 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1037 overflow when requested scroll falls outside ptrdiff_t range.
1039 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1041 * window.h (struct window): Change type of 'hscroll',
1042 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1043 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1044 Adjust users accordingly.
1045 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1046 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1047 from EMACS_INT to ptrdiff_t.
1048 (make_window): Omit redundant initialization.
1050 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1052 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1054 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1056 * window.h (struct window): Change type of 'use_time' and
1057 'sequence_number' from Lisp_Object to int.
1058 * frame.c (make_frame): Adjust users accordingly.
1059 * print.c (print_object): Likewise.
1060 * window.c (select_window, Fwindow_use_time, make_parent_window)
1061 (make_window): Likewise.
1063 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1065 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1066 enabled with --enable-checking=[all,glyphs] configure option.
1067 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1068 adjust comments accordingly.
1069 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1070 undefined, adjust comments accordingly.
1071 * image.c: Likewise.
1072 * scroll.c: Likewise.
1073 * w32fns.c: Likewise.
1074 * w32term.c: Likewise.
1075 * xdisp.c: Likewise.
1076 * xfaces.c: Likewise.
1078 * xterm.c: Likewise.
1080 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1082 Generalize run-time debugging checks.
1083 * dispextern.h (XASSERTS): Remove.
1084 * fontset.c (xassert): Remove.
1085 Convert from xassert to eassert.
1086 * alloc.c: Convert from xassert to eassert.
1088 * dispnew.c: Likewise.
1090 * fringe.c: Likewise.
1091 * ftfont.c: Likewise.
1092 * gtkutil.c: Likewise.
1093 * image.c: Likewise.
1094 * keyboard.c: Likewise.
1096 * process.c: Likewise.
1097 * scroll.c: Likewise.
1098 * sound.c: Likewise.
1100 * w32console.c: Likewise.
1101 * w32fns.c: Likewise.
1102 * w32term.c: Likewise.
1103 * window.c: Likewise.
1104 * xdisp.c: Likewise.
1105 * xfaces.c: Likewise.
1107 * xselect.c: Likewise.
1108 * xterm.c: Likewise.
1110 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1112 * fns.c (maybe_resize_hash_table): Output message when growing the
1115 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1117 * alloc.c (allocate_string_data): Remove dead code.
1118 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1119 avoid GCC warning about unused macro.
1121 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1123 * alloc.c (allocate_string): Omit intervals initialization.
1124 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1125 as in make_pure_string and make_pure_c_string.
1127 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1129 * alloc.c (allocate_string): Fix last change.
1131 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1133 * alloc.c (allocate_string): Remove two redundant calls
1134 to memset, add explicit initialization where appropriate.
1136 2012-06-27 Glenn Morris <rgm@gnu.org>
1138 * lisp.mk (lisp): Remove paths.elc.
1140 2012-06-27 Chong Yidong <cyd@gnu.org>
1142 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1144 2012-06-26 John Wiegley <johnw@newartisans.com>
1146 * unexmacosx.c (copy_data_segment): Add two section names used
1147 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1149 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1150 when building with Clang.
1152 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1154 * eval.c (Fapply): Allow calling it with a single argument.
1156 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1158 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1159 _stricmp and _strnicmp.
1160 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1162 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1164 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1166 (allocate_process): Likewise for new process.
1167 (allocate_terminal): Change to use offsetof.
1168 (allocate_frame): Likewise.
1169 * frame.c (make_frame): Omit redundant initialization.
1170 * window.c (make_parent_window): Use memset.
1171 (make_window): Omit redundant initialization.
1172 * process.c (make_process): Omit redundant initialization.
1173 * terminal.c (create_terminal): Likewise.
1175 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1177 * term.c (delete_tty): Remove redundant call to memset.
1179 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1181 * alloc.c: Remove build_string.
1182 * lisp.h: Define build_string as static inline. This provides
1183 a better opportunity to optimize away calls to strlen when the
1184 function is called with compile-time constant argument.
1185 * image.c (imagemagick_error): Convert to build_string.
1186 * w32proc.c (sys_spawnve): Likewise.
1187 * xterm.c (x_term_init): Likewise.
1189 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1191 Use sprintf return value instead of invoking strlen on result.
1192 In the old days this wasn't portable, since some sprintf
1193 implementations returned char *. But they died out years ago and
1194 Emacs already assumes sprintf returns int.
1195 Similarly for float_to_string.
1196 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1197 * ccl.c (ccl_driver):
1198 * character.c (string_escape_byte8):
1199 * data.c (Fnumber_to_string):
1200 * doprnt.c (doprnt):
1201 * print.c (print_object):
1202 * xdisp.c (message_dolog):
1203 * xfns.c (syms_of_xfns):
1204 Use sprintf or float_to_string result to avoid need to call strlen.
1205 * data.c (Fnumber_to_string):
1206 Use make_unibyte_string, since the string must be ASCII.
1207 * lisp.h, print.c (float_to_string): Now returns int length.
1208 * term.c (produce_glyphless_glyph):
1209 Use sprintf result rather than recomputing it.
1211 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1212 * Makefile.in (ALL_CFLAGS):
1213 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1214 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1216 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1218 * dispextern.h (xstrcasecmp): Define to library function
1219 strcasecmp if available.
1220 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1222 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1224 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1225 Avoid comma operator.
1226 * menu.c (push_submenu_start, push_submenu_end)
1227 (push_left_right_boundary, push_menu_pane): Likewise.
1228 * msdos.c (dos_rawgetc): Likewise.
1230 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1232 * xfns.c (xic_create_fontsetname): Remove redundant calls
1235 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1237 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1238 sprintf already null-terminates its output.
1240 * xfns.c (x_window): Remove redundant cast.
1242 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1244 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1245 `const char *' to `char *' to avoid compiler warning.
1247 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1249 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1250 instead of truncating it to 63 (admittedly a generous limit).
1252 * process.c: Fix spelling and caps in comments.
1254 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1256 * emacs.c (setpgrp): Remove definition, unused.
1257 * sysdep.c (setpgrp): Remove definition, not used in this file.
1259 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1261 * makefile.w32-in: Update dependencies.
1263 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1265 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1266 (SYSTIME_H): Add nt/inc/sys/time.h.
1268 * systime.h [WINDOWSNT]: Include sys/time.h.
1270 * s/ms-w32.h (struct timespec): Definition moved from
1271 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1273 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1275 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1276 * buffer.h (buffer_slot_type_mismatch):
1277 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1278 * eval.c (unwind_to_catch):
1279 * image.c (my_png_error, my_error_exit):
1280 * keyboard.c (quit_throw_to_read_char, user_error)
1281 (Fexit_recursive_edit, Fabort_recursive_edit):
1282 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1283 (wrong_type_argument, buffer_overflow, __executable_start)
1284 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1285 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1286 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1288 (child_setup) [!DOS_NT]:
1289 * lread.c (end_of_file_error, invalid_syntax):
1290 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1291 * puresize.h (pure_write_error):
1292 * search.c (matcher_overflow):
1293 * sound.c (sound_perror, alsa_sound_perror):
1294 * sysdep.c, syssignal.h (croak):
1295 * term.c (maybe_fatal, vfatal):
1296 * textprop.c (text_read_only):
1297 * undo.c (user_error):
1298 * unexmacosx.c (unexec_error):
1299 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1300 Use _Noreturn rather than NO_RETURN.
1301 No need for separate decl merely because of _Noreturn.
1302 * sound.c (sound_warning, parse_sound):
1303 Remove unnecessary forward decls.
1305 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1307 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1308 * lisp.h (WAIT_READING_MAX): New macro.
1309 * dispnew.c (Fsleep_for, sit_for):
1310 * keyboard.c (kbd_buffer_get_event):
1311 * process.c (Faccept_process_output):
1312 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1313 This improves on the previous patch, which introduced a bug
1314 when time_t is unsigned and as wide as intmax_t.
1315 See <http://bugs.gnu.org/9000#51>.
1317 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1319 * dispnew.c (sit_for, Fsleep_for):
1320 * keyboard.c (kbd_buffer_get_event):
1321 * process.c (Faccept_process_output): Avoid compiler warnings when
1322 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1324 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1326 * makefile.w32-in: Update dependencies.
1328 * w32.c (ltime): Add return type and declare static.
1329 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1331 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1333 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1334 Privately reported by Herbert J. Skuhra.
1335 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1337 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1338 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1340 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1342 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1343 last argument of make_unibyte_string.
1345 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1346 language ID in the event parameters.
1348 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1349 event.code, not the obscure "character set ID".
1351 2012-06-23 Chong Yidong <cyd@gnu.org>
1353 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1355 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1357 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1358 * w32.c (fdutimens): New function.
1360 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1362 * s/ms-w32.h (pselect): Redirect to sys_select.
1364 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1366 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1367 in the logic of incrementing and decrementing the value of
1368 use_relocatable_buffers.
1370 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1372 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1373 Privately reported by Herbert J. Skuhra.
1374 [__FreeBSD__]: Remove "*/" typo after "#include".
1375 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1376 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1377 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1378 Don't assume EMACS_TIME and struct timeval are the same type.
1380 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1382 Support higher-resolution time stamps (Bug#9000).
1383 The time stamps are only nanosecond-resolution at the C level,
1384 since that's the best that any real-world system supports now.
1385 But they are picosecond-resolution at the Lisp level, as that's
1386 easy, and leaves room for future OS improvements.
1388 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1391 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1392 Don't get current time unless it's needed.
1394 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1395 now provides it if it's absent.
1396 (start_atimer): Port to higher-res time stamps.
1397 Check for time stamp overflow. Don't get current time more
1398 often than is needed.
1400 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1401 Include systime.h, not time.h.
1402 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1404 * dired.c: Include stat-time.h.
1405 (Ffile-attributes): File times now have higher resolution.
1407 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1408 (struct image): Timestamp now has higher resolution.
1410 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1411 has at least microseconds now. All uses removed.
1412 (update_frame, update_single_window, update_window, update_frame_1)
1413 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1415 * editfns.c (time_overflow): Now extern.
1416 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1417 (float-time, Fformat_time_string, Fcurrent_time_string)
1418 (Fcurrent_time_zone): Accept and generate higher-resolution
1420 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1421 (decode_time_components, lisp_seconds_argument): New functions.
1422 (make_time): Now static.
1423 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1424 Report an error if the time is invalid, rather than having the caller
1427 * fileio.c: Include <stat-time.h>
1428 (Fcopy_file): Copy higher-resolution time stamps.
1429 Prefer to set the time stamp via a file descriptor if that works.
1430 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1431 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1432 (Fvisited_file_modtime, Fset_visited_file_modtime):
1433 Support higher-resolution time stamps.
1435 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1437 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1439 * image.c (prepare_image_for_display, clear_image_cache)
1440 (lookup_image): Port to higer-resolution time stamps.
1442 * keyboard.c (start_polling, bind_polling_period):
1443 Check for time stamp overflow.
1444 (read_char, kbd_buffer_get_event, timer_start_idle)
1445 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1446 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1447 Port to higher-resolution time stamps. Do not assume time_t is signed.
1448 (decode_timer): New function. Timers are now vectors of length 9,
1449 not 8, to accommodate the picosecond component.
1450 (timer_check_2): Use it.
1452 * nsterm.m (select_timeout, timeval_subtract): Remove.
1453 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1454 as they're a bit more accurate and handle overflow better.
1455 (ns_select): Change prototype to be compatible with pselect.
1456 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1457 * nsterm.h (ns_select): Adjust prototype.
1459 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1460 us-resolution time stamps.
1461 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1463 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1465 * lisp.h (time_overflow): New decl.
1466 (wait_reading_process_output): First arg is now intmax_t, not int,
1467 to accommodate larger waits.
1469 * process.h (struct Lisp_Process.read_output_delay):
1470 Now counts nanoseconds, not microseconds.
1471 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1473 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1474 (wait_reading_process_output):
1475 Port to ns-resolution time stamps.
1476 (Faccept_process_output, wait_reading_process_output):
1477 Check for time stamp overflow. Do not assume time_t is signed.
1478 (select_wrapper): Remove; we now use pselect.
1479 (Fprocess_attributes): Now generates ns-resolution time stamps.
1481 * sysdep.c: Include utimens.h. Don't include utime.h
1482 or worry about struct utimbuf; gnulib does that for us now.
1483 (gettimeofday): Remove; gnulib provides a substitute.
1484 (make_timeval): New function.
1485 (set_file_times): Now sets ns-resolution time stamps.
1486 New arg FD; all uses changed.
1487 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1488 (system_process_attributes):
1489 Now returns ns-resolution time stamp. All uses changed.
1490 Check for time stamp overflow.
1492 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1493 provides a substitute now.
1495 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1496 since it guarantees struct timespec.
1497 (EMACS_TIME): Now struct timespec, so that we can support
1498 ns-resolution time stamps.
1499 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1500 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1501 (EMACS_USECS): Remove.
1502 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1503 so multiply the arg by 1000 before storing it.
1504 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1506 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1507 Port to ns-resolution time stamps.
1508 (EMACS_TIME_NEG_P): Remove; replaced by....
1509 (EMACS_TIME_SIGN): New macro.
1510 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1511 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1512 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1513 (make_timeval, make_lisp_time, decode_time_components): New decls.
1514 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1515 that it mishandled time_t overflow. You can't compare by subtracting!
1516 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1517 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1519 * term.c: Include <sys/time.h>.
1520 (timeval_to_Time): New function, for proper overflow wraparound.
1521 (term_mouse_position, term_mouse_click): Use it.
1523 * undo.c (record_first_change): Support higher-resolution time stamps
1525 (Fprimitive_undo): Use them when restoring time stamps.
1527 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1528 (w32_get_internal_run_time):
1529 Port to higher-resolution Emacs time stamps.
1530 (ltime): Now accepts single 64-bit integer, as that's more convenient
1533 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1535 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1536 for compatibility with pselect. Support ns-resolution time stamps.
1538 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1540 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1541 Check for time stamp overflow, and support ns-resolution time stamps.
1543 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1544 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1545 (timeval_subtract): Remove; no longer needed.
1546 (XTflash, XTring_bell, x_wait_for_event):
1547 Port to ns-resolution time stamps. Don't assume time_t is signed.
1549 2012-06-22 Chong Yidong <cyd@gnu.org>
1551 * xdisp.c (x_consider_frame_title): Revert last change.
1553 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1555 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1556 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1557 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1558 staticidx goes up to 1597 out of 1600 = 0x640.)
1560 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1562 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1563 Otherwise, the umask might be mistakenly 0 while handling input signals.
1565 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1567 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1569 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1571 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1572 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1573 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1574 access to `contents' member of Lisp_Vector objects with AREF and ASET
1577 2012-06-19 Chong Yidong <cyd@gnu.org>
1579 * frame.c (delete_frame): When selecting a frame on a different
1580 text terminal, do not alter the terminal's top-frame.
1582 * xdisp.c (format_mode_line_unwind_data): Record the target
1583 frame's selected window and its terminal's top-frame.
1584 (unwind_format_mode_line): Restore them.
1585 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1587 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1588 since tty frames can be explicitly named.
1589 (prepare_menu_bars): Likewise.
1591 * term.c (Ftty_top_frame): New function.
1593 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1595 Port byte-code-meter to modern targets.
1596 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1597 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1598 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1599 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1600 (METER_1, METER_2): Simplify.
1602 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1604 * data.c (Fdefalias): Return `symbol' (bug#11686).
1606 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1608 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1609 gets killed during executing of this function (Bug#11665).
1610 Try to always return Qt when the buffer has been actually killed.
1611 (Vkill_buffer_query_functions): In doc-string say that functions
1612 run by this hook should not change the current buffer.
1614 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1616 Fix recently-introduced process.c problems found by static checking.
1617 * process.c (write_queue_push, write_queue_pop, send_process):
1618 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1619 (write_queue_pop): Fix pointer signedness problem.
1620 (send_process): Remove unused local.
1622 2012-06-17 Chong Yidong <cyd@gnu.org>
1624 * xdisp.c (redisplay_internal): No need to redisplay terminal
1625 frames that are not on top.
1627 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1629 * process.c (make_process): Initialize write_queue.
1630 (write_queue_push, write_queue_pop): New functions.
1631 (send_process): Use them to maintain correct ordering of process
1634 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1636 * lisp.h (eassert): Assume C89 or later.
1637 This removes the need for CHECK.
1638 (CHECK): Remove. Its comments about always evaluating its
1639 argument were confusing, as 'eassert' typically does not evaluate
1642 * coding.c (produce_chars): Use ptrdiff_t, not int.
1644 * xterm.c (x_draw_underwave): Check for integer overflow.
1645 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1647 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1649 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1650 referenced (Bug#11583).
1652 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1654 Implement wave-style variant of underlining.
1655 * dispextern.h (face_underline_type): New enum.
1656 (face): Add field for underline type.
1657 * nsterm.m (ns_draw_underwave): New function.
1658 (ns_draw_text_decoration): Use it.
1659 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1661 (x_draw_glyph_string): Use them.
1662 * xfaces.c (Qline, Qwave): New Lisp objects.
1663 (check_lface_attrs, merge_face_ref)
1664 (Finternal_set_lisp_face_attribute, realize_x_face):
1665 Handle wave-style underline face attributes.
1666 * xterm.c (x_draw_underwave): New function.
1667 (x_draw_glyph_string): Use it.
1669 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1671 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1672 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1673 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1674 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1675 ($(BLD)/w32select.$(O)): Update dependencies.
1677 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1679 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1680 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1681 * character.c (_fetch_multibyte_char_p): Remove.
1682 * alloc.c: Include "character.h" before "buffer.h".
1684 * buffer.c: Likewise.
1685 * bytecode.c: Likewise.
1686 * callint.c: Likewise.
1687 * callproc.c: Likewise.
1688 * casefiddle.c: Likewise.
1689 * casetab.c: Likewise.
1690 * category.c: Likewise.
1692 * coding.c: Likewise.
1693 * composite.c: Likewise.
1694 * dired.c: Likewise.
1695 * dispnew.c: Likewise.
1697 * dosfns.c: Likewise.
1698 * editfns.c: Likewise.
1699 * emacs.c: Likewise.
1700 * fileio.c: Likewise.
1701 * filelock.c: Likewise.
1703 * fontset.c: Likewise.
1704 * fringe.c: Likewise.
1705 * indent.c: Likewise.
1706 * insdel.c: Likewise.
1707 * intervals.c: Likewise.
1708 * keyboard.c: Likewise.
1709 * keymap.c: Likewise.
1710 * lread.c: Likewise.
1711 * macros.c: Likewise.
1712 * marker.c: Likewise.
1713 * minibuf.c: Likewise.
1714 * nsfns.m: Likewise.
1715 * nsmenu.m: Likewise.
1716 * print.c: Likewise.
1717 * process.c: Likewise.
1718 * regex.c: Likewise.
1719 * region-cache.c: Likewise.
1720 * search.c: Likewise.
1721 * syntax.c: Likewise.
1723 * textprop.c: Likewise.
1725 * unexsol.c: Likewise.
1726 * w16select.c: Likewise.
1727 * w32fns.c: Likewise.
1728 * w32menu.c: Likewise.
1729 * window.c: Likewise.
1730 * xdisp.c: Likewise.
1732 * xmenu.c: Likewise.
1734 * xselect.c: Likewise.
1736 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1738 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1739 If all the glyphs of the glyph row came from strings, and we have no
1740 cursor positioning clues, put the cursor on the first glyph of the
1742 (handle_face_prop): Use chunk-relative overlay string index when
1743 indexing into it->string_overlays array. (Bug#11653)
1744 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1745 the rightmost. (Bug#11720)
1747 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1749 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1750 (CATEGORY_MEMBER): Enforce 1/0 value.
1751 * category.c (_temp_category_set): Remove.
1753 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1755 * window.c (Fdelete_other_windows_internal)
1756 (Fdelete_window_internal): Don't access frame's mouse highlight
1757 info of the initial frame. (Bug#11677)
1759 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1761 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1762 Assume USE_2_TAGS_FOR_INTS.
1763 (xreload): Adjust $tagmask width to match recent lisp.h change.
1765 Simplify lisp.h in minor ways that should not affect code.
1766 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1767 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1768 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1769 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1770 (INTTYPEBITS): New macro, for clarity.
1771 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1772 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1773 Simplify now that USE_LSB_TAG is always defined.
1774 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1775 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1777 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1779 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1781 2012-06-13 Glenn Morris <rgm@gnu.org>
1783 * s/bsd-common.h (BSD4_3):
1784 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1786 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1788 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1791 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1793 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1794 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1795 * alloc.c (widen_to_Lisp_Object): Remove.
1796 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1797 * frame.c (delete_frame): Remove outdated comment.
1798 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1799 USE_LISP_UNION_TYPE.
1800 (Fw32_unregister_hot_key): Likewise.
1801 (Fw32_toggle_lock_key): Likewise.
1802 * w32menu.c (add_menu_item): Likewise.
1803 (w32_menu_display_help): Use XIL instead of checking
1804 USE_LISP_UNION_TYPE.
1805 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1806 (init_heap): Likewise.
1807 * w32term.c (w32_read_socket): Update comment.
1809 2012-06-13 Glenn Morris <rgm@gnu.org>
1811 * s/usg5-4-common.h, src/s/unixware.h:
1812 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1814 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1816 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1818 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1819 * alloc.c (make_number) [!defined make_number]:
1820 Remove, as lisp.h always defines this now.
1821 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1822 (roundup_size): Verify that it is a power of 2.
1823 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1824 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1825 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1826 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1827 USE_LSB_TAG now is always defined to be either 0 or 1.
1829 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1830 code works fine either way, and efficiency is not a concern here,
1831 as the union type is for debugging, not for production.
1832 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1833 Use an inline function on all platforms when using the union type,
1834 since this is simpler and 'static inline' can be used portably
1836 (LISP_INITIALLY_ZERO): New macro.
1837 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1838 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1840 2012-06-12 Glenn Morris <rgm@gnu.org>
1842 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1844 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1846 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1847 Move BROKEN_SIGIO to configure.
1849 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1850 Move NO_TERMIO to configure.
1852 2012-06-12 Chong Yidong <cyd@gnu.org>
1854 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1855 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1856 MagickExportImagePixels is undefined.
1858 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1860 * image.c (imagemagick_load_image): Remove unused label.
1862 2012-06-11 Glenn Morris <rgm@gnu.org>
1864 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1865 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1866 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1867 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1869 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1871 * alloc.c (make_byte_code): New function.
1872 (Fmake_byte_code): Use it. Don't purify here.
1873 * lread.c (read1): Use it as well to avoid extra allocation.
1875 2012-06-11 Chong Yidong <cyd@gnu.org>
1877 * image.c (imagemagick_load_image): Implement transparency.
1879 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1881 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1882 account for preceding backslashes. (Bug#11663)
1884 2012-06-09 Chong Yidong <cyd@gnu.org>
1886 * term.c: Support italics in capable terminals (Bug#9652).
1887 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1888 (turn_on_face): Output using TS_enter_italic_mode if available.
1889 Don't handle unused blinking and alt-charset cases.
1890 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1891 and tty_alt_charset_p cases.
1892 (tty_capable_p, init_tty): Support italics.
1894 * termchar.h (struct tty_display_info): Add field for italics.
1895 Remove unused blink field.
1897 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1900 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1901 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1902 tty_alt_charset_p. Add tty_italic_p.
1904 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1906 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1907 dbus_type_is_basic if available.
1908 (xd_extract_signed, xd_extract_unsigned): Rename from
1909 extract_signed and extract_unsigned, respectively. Adapt callers.
1911 2012-06-09 Chong Yidong <cyd@gnu.org>
1913 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1915 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1918 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1920 * xdisp.c (vmessage): Treat frame message as multibyte.
1921 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1922 would generate the diagnostic "Making \302\247 buffer-local while
1925 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1927 * dispnew.c (showing_window_margins_p): Undo last change, which
1928 was done due to an inadvertent commit.
1929 (adjust_frame_glyphs_for_frame_redisplay): Do call
1930 showing_window_margins_p.
1932 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1934 * eval.c (Fmake_var_non_special): New primitive.
1935 (syms_of_eval): Defsubr it.
1936 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1938 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1940 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1941 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1943 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1945 * alloc.c (allocate_vectorlike): Fix last change.
1947 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1949 Block-based vector allocation of small vectors.
1950 * lisp.h (struct vectorlike_header): New field `nbytes',
1951 adjust comment accordingly.
1952 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1953 to denote vector blocks. Adjust users (live_vector_p,
1954 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1955 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1956 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1957 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1958 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1959 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1960 (roundup_size): New constant.
1961 (struct vector_block): New data type.
1962 (vector_blocks, vector_free_lists, zero_vector): New variables.
1963 (all_vectors): Rename to `large_vectors'.
1964 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1965 (sweep_vectors): New functions.
1966 (allocate_vectorlike): Return `zero_vector' as the only vector of
1967 0 items. Allocate new vector from block if vector size is less than
1968 or equal to VBLOCK_BYTES_MAX.
1969 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1970 (init_alloc_once): Add call to init_vectors.
1972 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1974 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1976 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1978 * doprnt.c (doprnt): Truncate multibyte char correctly.
1979 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1980 would mishandle a string argument "Xc" if X was a multibyte
1981 character of length 2: it would truncate after X's first byte
1982 rather than including all of X.
1984 2012-06-06 Chong Yidong <cyd@gnu.org>
1986 * buffer.c (word_wrap): Doc fix.
1988 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1990 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1992 2012-06-03 Glenn Morris <rgm@gnu.org>
1994 * xdisp.c (tool-bar-style): Doc fix.
1996 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1998 * Makefile.in (PAXCTL): Define.
1999 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2000 binary via PaX flags if the paxctl utility is available.
2001 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2002 Restore PaX flags to their default. (Bug#11398)
2004 2012-06-03 Chong Yidong <cyd@gnu.org>
2006 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2009 2012-06-03 Chong Yidong <cyd@gnu.org>
2011 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2012 (note_mode_line_or_margin_highlight): If there is no help echo,
2013 use mode-line-default-help-echo. Handle the case where the mouse
2014 position is past the end of the mode line string.
2016 * buffer.c (buffer_local_value_1): New function, split from
2017 Fbuffer_local_value; can return Qunbound.
2018 (Fbuffer_local_value): Use it.
2019 (Vmode_line_format): Docstring tweaks.
2021 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2023 * sysdep.c (system_process_attributes): Improve comment.
2025 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2027 * keyboard.c: Export real-this-command to Elisp.
2028 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2029 and DEFVAR it. Update all users.
2031 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2033 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2035 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2036 Convert pctcpu and pctmem to Lisp float properly.
2037 Let the compiler fold better, as 100.0/0x8000 is exact.
2039 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2041 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2044 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2046 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2048 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2050 For a 'struct window', replace some Lisp_Object fields to
2051 bitfields where appropriate, remove unused fields.
2052 * window.h (struct window): Remove unused 'last_mark_x' and
2053 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2054 change it's type from Lisp_Object to bitfield.
2055 Change type of 'force_start', 'optional_new_start',
2056 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2057 fields from Lisp_Object to bitfield. Adjust users accordingly.
2059 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2061 Pacify gcc -Wdouble-precision when using Xaw.
2062 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2063 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2064 Use 'float' consistently, rather than 'float' in most places
2065 and 'double' in a couple of places.
2067 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2069 * xdisp.c (handle_stop): Detect whether we have overlay strings
2070 loaded by testing it->current.overlay_string_index to be
2071 non-negative, instead of checking whether n_overlay_strings is
2072 positive. (Bug#11587)
2074 2012-05-31 Chong Yidong <cyd@gnu.org>
2076 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2078 * doc.c (Fsubstitute_command_keys): Doc fix.
2080 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2082 * search.c (search_buffer): Remove calls to
2083 r_alloc_inhibit_buffer_relocation, as it is now called by
2084 maybe_unify_char, which was the cause of relocation of buffer text
2087 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2089 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2090 for the duration of call to load_charset, to avoid problems with
2091 callers of maybe_unify_char that access buffer text through C
2094 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2095 decrement the inhibition flag, instead of just setting or
2098 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2100 Remove obsolete '#define static' cruft.
2101 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2102 This #undef was "temporary" in 2000; it is no longer needed
2103 now that '#define static' has gone away.
2104 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2105 (gray_bitmap_bits): Remove; no longer needed.
2106 All uses replaced with definiens.
2107 * xterm.c: Include "bitmaps/gray.xbm".
2109 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2111 Clean up __executable_start, monstartup when --enable-profiling.
2112 The following changes affect the code only when profiling.
2113 * dispnew.c (__executable_start): Rename from safe_bcopy.
2114 Define only on platforms that need it.
2115 * emacs.c: Include <sys/gmon.h> when profiling.
2116 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2117 (__executable_start): Remove decl, since lisp.h does it now.
2118 (safe_bcopy): Remove decl; no longer has that name.
2119 (main): Coalesce #if into single bit of code, for simplicity.
2120 Cast pointers to uintptr_t, since standard libraries want integers
2122 * lisp.h (__executable_start): New decl.
2124 2012-05-31 Glenn Morris <rgm@gnu.org>
2126 * image.c (Fimagemagick_types): Doc fix.
2128 2012-05-30 Jim Meyering <meyering@redhat.com>
2130 * callproc.c (Fcall_process_region): Include directory component
2131 in mkstemp error message (Bug#11586).
2133 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2135 * alloc.c, lisp.h (make_pure_vector): Now static.
2137 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2139 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2140 Move to byte-run.el.
2141 (Fautoload): Do the hash-doc more carefully.
2142 * data.c (Fdefalias): Purify definition, except for keymaps.
2143 (Qdefun): Move from eval.c.
2144 * lisp.h (Qdefun): Remove.
2145 * lread.c (read1): Tiny simplification.
2147 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2149 Do not create empty overlays with the evaporate property (Bug#9642).
2150 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2151 Bug#9642, but explicitly check that the buffer the overlay would
2152 be moved to is live and rearrange lines to make sure that errors
2153 will not put the overlay in an inconsistent state.
2154 (Fdelete_overlay): Cosmetics.
2156 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2158 * w32term.c (my_bring_window_to_top): New function.
2159 (x_raise_frame): Use handle returned by DeferWindowPos, which
2160 could be different from the original one.
2161 Call my_bring_window_to_top instead of my_set_foreground_window.
2164 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2165 by calling BringWindowToTop.
2167 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2168 (WM_EMACS_END): Increase by one.
2170 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2172 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2173 This avoids undefined behavior that might cause the eassert
2174 to not catch an out-of-range value.
2176 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2178 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2179 Update dependencies.
2181 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2183 * bidi.c (bidi_mirror_char): Fix last change.
2185 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2187 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2188 when referring to sectname field in printf format.
2190 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2192 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2193 Only r_alloc_inhibit_buffer_relocation needed to be added;
2194 the others were already declared.
2196 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2197 before checking whether it's out of range. Put the check inside
2199 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2201 2012-05-27 Ken Brown <kbrown@cornell.edu>
2203 * callproc.c (Fcall_process): Restore a line that was accidentally
2204 commented out in the 2011-02-13 change (bug#11547).
2206 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2208 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2209 defined on ralloc.c.
2211 * buffer.c [REL_ALLOC]: Remove prototypes of
2212 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2213 they are now on lisp.h.
2215 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2217 * search.c (search_buffer): Use it to inhibit relocation of buffer
2218 text while re_search_2 is doing its job, because re_search_2 is
2219 passed C pointers to buffer text. (Bug#11519)
2221 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2224 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2225 state after an additional call to move_it_in_display_line_to, keep
2226 the values of it->max_ascent and it->max_descent found for the
2228 (pos_visible_p): Revert the comparison against bottom_y to what it
2229 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2232 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2234 Fix coding-related core dumps with gcc -ftrapv.
2235 The code was computing A - B, where A and B are pointers, and B is
2236 random garbage. This can lead to core dumps on platforms that
2237 have special pointer registers, and it also leads to core dumps on
2238 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2239 A - B only when B is initialized properly.
2240 * coding.c (coding_set_source, coding_set_destination): Return void.
2241 (coding_change_source, coding_change_destinations): New functions,
2242 with the old behaviors of coding_set_source and coding_set_destination.
2243 All callers that need an offset changed to use these new functions.
2245 2012-05-26 Glenn Morris <rgm@gnu.org>
2247 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2249 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2251 Extend mouse support on W32 text-mode console.
2252 * xdisp.c (draw_row_with_mouse_face):
2253 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2255 * w32console.c: Include window.h.
2256 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2258 (initialize_w32_display): Initialize mouse-highlight data.
2260 * w32inevt.c: Include termchar.h and window.h.
2261 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2262 moves, call note_mouse_highlight. If help_echo changed, call
2263 gen_help_event to produce help-echo message in the echo area.
2264 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2267 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2269 * lread.c (read1): Simplify slightly to avoid an overflow warning
2270 with GCC 4.7.0 on x86-64.
2272 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2274 * bidi.c (bidi_mirror_char): Revert last change: an int is
2275 definitely wide enough here.
2277 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2279 Fix integer width and related bugs (Bug#9874).
2280 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2281 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2282 (string_bytes, check_sblock, allocate_string_data):
2283 (compact_small_strings, Fmake_bool_vector, make_string)
2284 (make_unibyte_string, make_multibyte_string)
2285 (make_string_from_bytes, make_specified_string)
2286 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2287 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2290 (allocate_pseudovector):
2291 Use int, not EMACS_INT, where int is wide enough.
2292 (inhibit_garbage_collection, Fgarbage_collect):
2293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2294 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2295 int might not be wide enough.
2296 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2297 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2298 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2299 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2300 (bidi_level_of_next_char, bidi_move_to_visually_next):
2301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2302 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2303 (Fkill_buffer, Fset_buffer_major_mode)
2304 (advance_to_char_boundary, Fbuffer_swap_text)
2305 (Fset_buffer_multibyte, overlays_at, overlays_in)
2306 (overlay_touches_p, struct sortvec, record_overlay_string)
2307 (overlay_strings, recenter_overlay_lists)
2308 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2309 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2310 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2311 (Foverlay_recenter, last_overlay_modification_hooks_used)
2312 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2314 (validate_region): Omit unnecessary test for b <= e,
2315 since that's guaranteed by the previous test.
2316 (adjust_overlays_for_delete): Avoid pos + length overflow.
2317 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2318 (report_overlay_modification):
2319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2320 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2321 Omit pointer cast, which isn't needed anyway, and doesn't work
2322 after the EMACS_INT -> ptrdiff_t change.
2323 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2324 * buffer.h: Adjust decls to match defn changes elsewhere.
2325 (struct buffer_text, struct buffer):
2326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2327 Use EMACS_INT, not int, where int might not be wide enough.
2328 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2329 not int, to avoid needless 32-bit limit on 64-bit hosts.
2330 (exec_byte_code): Use tighter memory-full test, one that checks
2331 for alloca overflow. Don't compute the address of the object just
2332 before an array, as that's not portable. Use EMACS_INT, not
2333 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2334 * callint.c (Fcall_interactively):
2335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2336 * callproc.c (call_process_kill, Fcall_process):
2337 Don't assume pid_t fits into an Emacs fixnum.
2338 (call_process_cleanup, Fcall_process, child_setup):
2339 Don't assume pid_t fits into int.
2340 (call_process_cleanup, Fcall_process, delete_temp_file)
2341 (Fcall_process_region):
2342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2343 (Fcall_process): Simplify handling of volatile integers.
2344 Use int, not EMACS_INT, where int will do.
2345 * casefiddle.c (casify_object, casify_region, operate_on_word)
2346 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2348 (casify_object): Avoid integer overflow when overallocating buffer.
2349 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2350 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2351 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2352 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2353 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2354 integers are now checked earlier. All uses replaced with XINT.
2356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2357 For CCL_MapSingle, check that content and value are in int range.
2358 (ccl_driver, Fregister_code_conversion_map):
2359 Check that Vcode_version_map_vector is a vector.
2360 (resolve_symbol_ccl_program): Check that vector header is in range.
2361 Always copy the vector, so that we can check its contents reliably
2362 now rather than having to recheck each instruction as it's being
2363 executed. Check that vector words fit in 'int'.
2364 (ccl_get_compiled_code, Fregister_ccl_program)
2365 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2366 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2367 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2368 contents are in range.
2369 (Fccl_execute_on_string): Check that status is in range.
2370 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2371 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2372 Accept and return EMACS_INT, not int, because callers can pass values
2374 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2375 (multibyte_chars_in_text, parse_str_as_multibyte)
2376 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2377 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2378 (string_escape_byte8, Fget_byte):
2379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2380 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2381 avoid mishandling large integers.
2382 * character.h: Adjust decls to match defn changes elsewhere.
2383 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2384 (Ffind_charset_region):
2385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2386 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2387 (load_charset_map_from_vector, Fdefine_charset_internal):
2388 Don't assume fixnum fits in int.
2389 (load_charset_map_from_vector, Fmap_charset_chars):
2390 Remove now-unnecessary CHECK_NATNUMs.
2391 (Fdefine_charset_internal): Check ranges here, more carefully.
2392 Don't rely on undefined behavior with signed left shift overflow.
2393 Don't assume unsigned int fits into fixnum, or that fixnum fits
2394 into unsigned int. Don't require max_code to be a valid fixnum;
2395 that's not true for gb10830 4-byte on a 32-bit host. Allow
2396 invalid_code to be a cons, for the same reason. Require code_offset
2397 to be a character. Avoid int overflow if max_char is close
2399 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2400 this is intended anyway and avoids some undefined behavior.
2401 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2402 INDEX_TO_CODE_POINT, as that's what it expects.
2403 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2404 * charset.h (DECODE_CHAR): Return int, not unsigned;
2405 this is what was intended anyway, and it avoids undefined behavior.
2406 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2407 integer-overflow issues.
2408 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2409 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2410 where the argument is EMACS_INT, and this behavior is not intended.
2411 * chartab.c (Fmake_char_table, Fset_char_table_range)
2412 (uniprop_get_decoder, uniprop_get_encoder):
2413 Don't assume fixnum fits in int.
2414 * cmds.c (move_point): New function, that does the gist of
2415 Fforward_char and Fbackward_char, but does so while checking
2416 for integer overflow more accurately.
2417 (Fforward_char, Fbackward_char): Use it.
2418 (Fforward_line, Fend_of_line, internal_self_insert)
2419 (internal_self_insert):
2420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2421 Fix a FIXME, by checking for integer overflow when calculating
2422 target_clm and actual_clm.
2423 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2424 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2425 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2426 (coding_alloc_by_making_gap, alloc_destination)
2427 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2428 (encode_coding_utf_16, detect_coding_emacs_mule)
2429 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2430 (detect_coding_iso_2022, decode_coding_iso_2022)
2431 (encode_invocation_designation, encode_designation_at_bol)
2432 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2433 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2434 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2435 (encode_coding_ccl, encode_coding_raw_text)
2436 (detect_coding_charset, decode_coding_charset)
2437 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2438 (produce_composition, produce_charset, produce_annotation)
2439 (decode_coding, handle_composition_annotation)
2440 (handle_charset_annotation, consume_chars, decode_coding_gap)
2441 (decode_coding_object, encode_coding_object, detect_coding_system)
2442 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2443 (code_convert_region, code_convert_string)
2444 (Fdefine_coding_system_internal)
2445 (coding_set_source, coding_set_destination):
2446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2447 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2448 (Fdefine_coding_system_internal):
2449 Don't assume fixnums fit in int.
2450 (decode_coding_gap, decode_coding_object, encode_coding_object)
2451 (Fread_coding_system, Fdetect_coding_region)
2452 (Funencodable_char_position, Fcheck_coding_systems_region)
2453 (get_translation, handle_composition_annotation, consume_chars):
2454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2455 (consume_chars): Rewrite to not calculate an address outside buffer.
2456 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2457 Don't access memory outside of the args array.
2458 (Fdefine_coding_system_internal): Check for charset-id overflow.
2459 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2460 result of ENCODE_CHAR.
2461 * coding.h: Adjust decls to match defn changes elsewhere.
2462 (struct coding_system):
2463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2464 * composite.c (get_composition_id, find_composition)
2465 (run_composition_function, update_compositions)
2466 (compose_text, composition_gstring_put_cache)
2467 (composition_gstring_p, composition_gstring_width)
2468 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2469 (composition_compute_stop_pos, composition_reseat_it)
2470 (composition_update_it, struct position_record)
2471 (find_automatic_composition, composition_adjust_point)
2472 (Fcomposition_get_gstring, Ffind_composition_internal):
2473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2474 (update_compositions):
2475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2476 * composite.h: Adjust decls to match defn changes elsewhere.
2477 (struct composition):
2478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2479 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2480 Do not attempt to compute the address of the object just before a
2481 buffer; this is not portable.
2483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2484 (Faset): Use int, not EMACS_INT, where int is wide enough.
2485 (Fstring_to_number): Don't assume fixnums fit in int.
2486 (Frem): Don't assume arg is nonnegative.
2487 * dbusbind.c (xd_append_arg): Check for integers out of range.
2488 (Fdbus_call_method): Don't overflow the timeout int.
2489 (extract_signed, extract_unsigned): New functions.
2490 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2491 (xd_get_connection_references): Return ptrdiff_t, not int.
2493 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2494 (xd_read_message_1):
2495 Use int, not unsigned, where the dbus API uses int.
2496 (Fdbus_message_internal): Don't overflow mtype.
2497 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2498 * dired.c (directory_files_internal, file_name_completion, scmp)
2499 (file_name_completion_stat):
2500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2501 (file_name_completion): Don't overflow matchcount.
2502 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2503 * dispextern.h: Adjust decls to match defn changes elsewhere.
2504 (struct text_pos, struct glyph, struct bidi_saved_info)
2505 (struct bidi_string_data, struct bidi_it, struct composition_it)
2507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2508 (struct display_pos, struct composition_it, struct it):
2509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2510 * dispnew.c (increment_matrix_positions)
2511 (increment_row_positions, mode_line_string)
2512 (marginal_area_string):
2513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2514 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2516 (duration_to_sec_usec): New function, to check for overflow better.
2517 (Fsleep_for, sit_for): Use it.
2518 * doc.c (get_doc_string, store_function_docstring):
2519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2520 (get_doc_string, Fsnarf_documentation):
2521 Use int, not EMACS_INT, where int is wide enough.
2523 Use SAFE_ALLOCA, not alloca.
2524 Check for overflow when converting EMACS_INT to off_t.
2525 * doprnt.c (doprnt):
2526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2527 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2528 Don't assume uid_t fits into fixnum.
2529 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2530 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2531 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2532 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2533 (general_insert_function)
2534 (Finsert_char, make_buffer_string, make_buffer_string_both)
2535 (update_buffer_properties, Fbuffer_substring)
2536 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2537 (Fsubst_char_in_region, check_translation)
2538 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2539 (transpose_markers, Ftranspose_regions):
2540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2541 (clip_to_bounds): Move to lisp.h as an inline function).
2542 (Fconstrain_to_field): Don't assume integers are nonnegative.
2543 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2544 (Fsubst_char_in_region, Fsave_restriction):
2545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2546 (Femacs_pid): Don't assume pid_t fits into fixnum.
2547 (lo_time): Use int, not EMACS_INT, when int suffices.
2548 (lisp_time_argument): Check for usec out of range.
2549 (Fencode_time): Don't assume fixnum fits in int.
2550 (Fuser_login_name, Fuser_full_name): Signal an error
2551 if a uid argument is out of range, rather than relying on
2553 (Fformat_time_string): Remove now-unnecessary check.
2554 lisp_time_argument checks for out-of-range usec now.
2555 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2556 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2557 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2558 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2559 (init_cmdargs, Fdump_emacs):
2560 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2561 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2562 the bottom (typically) 32 bits of the fixnum.
2563 * eval.c (specpdl_size, call_debugger):
2564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2565 (when_entered_debugger, Fbacktrace_debug):
2566 Don't assume fixnum can fit in int.
2567 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2568 the object just before a buffer; this is not portable.
2569 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2570 (grow_specpdl, unbind_to):
2571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2572 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2573 (grow_specpdl): Simplify allocation by using xpalloc.
2574 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2575 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2576 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2578 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2581 (Fcopy_file, non_regular_nbytes, read_non_regular)
2582 (Finsert_file_contents):
2583 Use int, not EMACS_INT, where int is wide enough.
2584 (READ_BUF_SIZE): Verify that it fits in int.
2585 (Finsert_file_contents): Check that counts are in proper range,
2586 rather than assuming fixnums fit into ptrdiff_t etc.
2587 Don't assume fixnums fit into int.
2588 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2589 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2590 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2591 (string_char_to_byte, string_byte_to_char)
2592 (string_make_multibyte, string_to_multibyte)
2593 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2594 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2595 (substring_both, Fdelete, internal_equal, Ffillarray)
2596 (Fclear_string, mapcar1)
2597 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2598 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2599 (larger_vector, make_hash_table, maybe_resize_hash_table)
2600 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2601 (Fmaphash, secure_hash):
2602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2603 (concat): Check for string index and length overflow.
2604 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2607 (larger_vector): New API (vec, incr_min, size_max) replaces old
2608 one (vec, new_size, init). This catches size overflow.
2609 INIT was removed because it was always Qnil.
2610 All callers changed.
2611 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2612 the upper bound on a hash table index size.
2613 (make_hash_table, maybe_resize_hash_table): Use it.
2614 (secure_hash): Computer start_byte and end_byte only after
2615 they're known to be in ptrdiff_t range.
2616 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2617 (Ffont_get_glyphs, Ffont_at):
2618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2619 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2620 (Flist_fonts, Fopen_font):
2621 Don't assume fixnum can fit in int.
2622 (check_gstring): Don't assume index can fit in int.
2623 (font_match_p): Check that fixnum is a character, not a nonnegative
2624 fixnum, since the later code needs to stuff it into an int.
2625 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2626 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2627 conversion overflow issues.
2628 (Fopen_font): Check for integer out of range.
2629 (Ffont_get_glyphs): Don't assume index can fit in int.
2630 * font.h: Adjust decls to match defn changes elsewhere.
2631 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2633 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2634 printmax_t, where ptrdiff_t is wide enough.
2635 (Finternal_char_font):
2636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2637 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2638 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2639 (Fset_frame_position, x_set_frame_parameters)
2640 (x_set_line_spacing, x_set_border_width)
2641 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2642 Check that fixnums are in proper range for system types.
2643 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2645 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2646 Use SAFE_ALLOCA_LISP, not alloca.
2647 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2648 intptr_t is wide enough.
2649 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2650 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2651 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2652 Check for fixnum out of range.
2653 * ftfont.c (ftfont_list): Don't assume index fits in int.
2654 Check that fixnums are in proper range for system types.
2655 (ftfont_shape_by_flt):
2656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2657 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2659 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2660 Check that fixnums are in proper range for system types.
2661 * gnutls.h: Adjust decls to match defn changes elsewhere.
2662 * gtkutil.c (xg_dialog_run):
2663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2664 (update_frame_tool_bar):
2665 Check that fixnums are in proper range for system types.
2666 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2667 (lookup_image): Check that fixnums are in range for system types.
2668 * indent.c (last_known_column, last_known_column_point):
2669 (current_column_bol_cache):
2670 (skip_invisible, current_column, check_display_width):
2671 (check_display_width, scan_for_column, current_column_1)
2672 (Findent_to, Fcurrent_indentation, position_indentation)
2673 (indented_beyond_p, Fmove_to_column, compute_motion):
2674 (Fcompute_motion, Fvertical_motion):
2675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2676 (last_known_column_modified): Use EMACS_INT, not int.
2677 (check_display_width):
2679 Check that fixnums and floats are in proper range for system types.
2680 (compute_motion): Don't assume index or fixnum fits in int.
2681 (compute_motion, Fcompute_motion):
2682 Use int, not EMACS_INT, when it is wide enough.
2683 (vmotion): Omit local var start_hpos that is always 0; that way
2684 we don't need to worry about overflow in expressions involving it.
2685 * indent.h: Adjust decls to match defn changes elsewhere.
2687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2688 Use int, not EMACS_INT, where int is wide enough.
2689 Remove unused members ovstring_chars_done and tab_offset;
2691 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2692 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2693 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2694 (make_gap, copy_text, insert, insert_and_inherit)
2695 (insert_before_markers, insert_before_markers_and_inherit)
2696 (insert_1, count_combining_before, count_combining_after)
2697 (insert_1_both, insert_from_string)
2698 (insert_from_string_before_markers, insert_from_string_1)
2699 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2700 (adjust_after_replace, adjust_after_insert, replace_range)
2701 (replace_range_2, del_range, del_range_1, del_range_byte)
2702 (del_range_both, del_range_2, modify_region)
2703 (prepare_to_modify_buffer, signal_before_change)
2704 (signal_after_change, Fcombine_after_change_execute):
2705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2706 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2707 (balance_an_interval, split_interval_right, split_interval_left)
2708 (find_interval, next_interval, update_interval)
2709 (adjust_intervals_for_insertion, delete_node, delete_interval)
2710 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2711 (static_offset_intervals, offset_intervals)
2712 (merge_interval_right, merge_interval_left, make_new_interval)
2713 (graft_intervals_into_buffer, temp_set_point_both)
2714 (temp_set_point, set_point, adjust_for_invis_intang)
2715 (set_point_both, move_if_not_intangible, get_property_and_range)
2716 (get_local_map, copy_intervals, copy_intervals_to_string)
2717 (compare_string_intervals, set_intervals_multibyte_1):
2718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2719 * intervals.h: Adjust decls to match defn changes elsewhere.
2721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2722 * keyboard.c (this_command_key_count, this_single_command_key_start)
2723 (before_command_key_count, before_command_echo_length, echo_now)
2724 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2725 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2726 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2727 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2729 (last_non_minibuf_size, last_point_position, echo_truncate)
2730 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2731 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2732 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2733 (stuff_buffered_input):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 (last_auto_save, command_loop_1, read_char):
2736 Use EMACS_INT, not int, to avoid integer overflow.
2737 (record_char): Avoid overflow in total_keys computation.
2738 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2739 * keyboard.h: Adjust decls to match defn changes elsewhere.
2740 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2741 (Fkey_description, Fdescribe_vector, Flookup_key):
2742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2743 (click_position): New function, to check that positions are in range.
2744 (Fcurrent_active_maps):
2746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2747 (Faccessible_keymaps, Fkey_description):
2748 (preferred_sequence_p):
2749 Don't assume fixnum can fit into int.
2750 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2751 Check for integer overflow in size calculations.
2752 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2753 avoid mishandling large integers.
2754 * lisp.h: Adjust decls to match defn changes elsewhere.
2755 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2756 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2757 (struct Lisp_Marker):
2758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2759 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2760 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2761 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2762 All callers changed.
2763 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2764 Assume the arg has valid form, since it always does.
2765 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2766 unsigned integer system type.
2767 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2768 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2770 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2771 (duration_to_sec_usec): New decl.
2772 * lread.c (read_from_string_index, read_from_string_index_byte)
2773 (read_from_string_limit, readchar, unreadchar, openp)
2774 (read_internal_start, read1, oblookup):
2775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2776 (Fload, readevalloop, Feval_buffer, Feval_region):
2777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2778 (openp): Check for out-of-range argument to 'access'.
2779 (read1): Use int, not EMACS_INT, where int is wide enough.
2780 Don't assume fixnum fits into int.
2781 Fix off-by-one error that can read outside a buffer.
2782 (read_filtered_event): Use duration_to_sec_usec
2783 to do proper overflow checking on durations.
2784 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2785 in size calculation.
2786 (Fexecute_kbd_macro):
2787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2788 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2789 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2790 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2791 (set_marker_both, set_marker_restricted_both, marker_position)
2792 (marker_byte_position, Fbuffer_has_markers_at):
2793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2794 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2795 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2796 It now merely ensures that the menu is large enough, without
2797 necessarily growing it, as this avoids some integer overflow issues.
2798 All callers changed.
2799 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2801 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2802 Use SAFE_ALLOCA_LISP, not alloca.
2803 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2804 to EMACS_INT. Check that fixnums are in proper range for system types.
2805 * minibuf.c (minibuf_prompt_width, string_to_object)
2806 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2807 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2809 (get_minibuffer, read_minibuf_unwind):
2810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2811 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2812 this simplifies overflow checking. All callers changed.
2813 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2816 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2817 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2818 Check that fixnums are in proper range for system types.
2819 (Fx_create_frame, Fx_show_tip):
2820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2821 * nsfont.m (ns_findfonts, nsfont_list_family):
2822 Don't assume fixnum fits in long.
2823 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2825 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2827 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2829 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2830 (PRINTDECLARE, PRINTPREPARE):
2831 (strout, print_string):
2832 (print, print_preprocess, print_check_string_charset_prop)
2834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2836 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2838 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2839 (printchar, strout): Use xpalloc to catch size calculation overflow.
2840 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2841 (print_error_message): Use SAFE_ALLOCA, not alloca.
2842 (print_object): Use int, not EMACS_INT, where int is wide enough.
2843 (print_depth, new_backquote_output, print_number_index):
2844 Use ptrdiff_t, not int, where int might not be wide enough.
2845 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2846 (Fset_process_window_size, Fformat_network_address)
2847 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2849 Check that fixnums are in proper range for system types.
2850 (Fsignal_process): Simplify by avoiding a goto.
2851 Check for process-ids out of pid_t range rather than relying on
2853 (process_tick, update_tick): Use EMACS_INT, not int.
2854 (Fformat_network_address, read_process_output, send_process)
2855 (Fprocess_send_region, status_notify):
2856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2857 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2858 (wait_reading_process_output, read_process_output, exec_sentinel):
2859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2860 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2861 (Faccept_process_output): Use duration_to_sec_usec to do proper
2862 overflow checking on durations.
2863 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2864 Don't assume pid_t fits in int.
2865 * process.h (struct Lisp_Process): Members tick and update_tick
2866 are now of type EMACS_INT, not int.
2867 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2868 configured --with-wide-int.
2869 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2870 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2871 * search.c (looking_at_1, string_match_1):
2872 (fast_string_match, fast_c_string_match_ignore_case)
2873 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2874 (scan_newline, find_before_next_newline, search_command)
2875 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2876 (set_search_regs, wordify):
2879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2880 (string_match_1, search_buffer, set_search_regs):
2882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2883 (wordify): Check for overflow in size calculation.
2884 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2885 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2886 Check that fixnums are in proper range for system types.
2887 * sound.c (struct sound_device)
2888 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2890 (Fplay_sound_internal):
2891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2892 * syntax.c (struct lisp_parse_state, find_start_modiff)
2893 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2894 (Fparse_partial_sexp):
2895 Don't assume fixnums can fit in int.
2896 (struct lisp_parse_state, find_start_pos, find_start_value)
2897 (find_start_value_byte, find_start_begv)
2898 (update_syntax_table, char_quoted, dec_bytepos)
2899 (find_defun_start, prev_char_comend_first, back_comment):
2900 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2901 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2903 (Finternal_describe_syntax_value): Check that match_lisp is a
2904 character, not an integer, since the code stuffs it into int.
2905 (scan_words, scan_sexps_forward):
2906 Check that fixnums are in proper range for system types.
2908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2909 (scan_sexps_forward):
2910 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2911 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2912 * syntax.h: Adjust decls to match defn changes elsewhere.
2913 (struct gl_state_s):
2914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2915 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2916 MOST_POSITIVE_FIXNUM.
2917 * sysdep.c (wait_for_termination_1, wait_for_termination)
2918 (interruptible_wait_for_termination, mkdir):
2919 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2920 (emacs_read, emacs_write):
2921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2922 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2923 and double all fit in int.
2924 * term.c (set_tty_color_mode):
2925 Check that fixnums are in proper range for system types.
2926 * termhooks.h (struct input_event):
2927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2928 * textprop.c (validate_interval_range, interval_of)
2929 (Fadd_text_properties, set_text_properties_1)
2930 (Fremove_text_properties, Fremove_list_of_text_properties)
2931 (Ftext_property_any, Ftext_property_not_all)
2932 (copy_text_properties, text_property_list, extend_property_ranges)
2933 (verify_interval_modification):
2934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2935 (Fnext_single_char_property_change)
2936 (Fprevious_single_char_property_change):
2937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2938 (copy_text_properties):
2939 Check for integer overflow in index calculation.
2940 * undo.c (last_boundary_position, record_point, record_insert)
2941 (record_delete, record_marker_adjustment, record_change)
2942 (record_property_change):
2943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2944 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2946 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2947 (Fx_hide_tip, Fx_file_dialog):
2948 * w32menu.c (set_frame_menubar):
2949 Use ptrdiff_t, not int, for consistency with rest of code.
2950 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2951 (select_window, Fdelete_other_windows_internal)
2952 (window_scroll_pixel_based, window_scroll_line_based)
2953 (Frecenter, Fset_window_configuration):
2954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2955 (Fset_window_hscroll, run_window_configuration_change_hook)
2956 (set_window_buffer, temp_output_buffer_show, scroll_command)
2957 (Fscroll_other_window, Frecenter):
2958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2959 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2960 Don't assume fixnum fits in int.
2961 (Fset_window_scroll_bars):
2962 Check that fixnums are in proper range for system types.
2963 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2964 (string_pos, c_string_pos, number_of_chars, init_iterator)
2965 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2966 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2967 (compute_display_string_end, handle_face_prop)
2968 (face_before_or_after_it_pos, handle_invisible_prop)
2969 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2970 (display_prop_intangible_p, string_buffer_position_lim)
2971 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2972 (get_overlay_strings_1, get_overlay_strings)
2973 (iterate_out_of_display_property, forward_to_next_line_start)
2974 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2975 (get_next_display_element, set_iterator_to_next)
2976 (get_visually_first_element, compute_stop_pos_backwards)
2977 (handle_stop_backwards, next_element_from_buffer)
2978 (move_it_in_display_line_to, move_it_in_display_line)
2979 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2980 (add_to_log, message_dolog, message_log_check_duplicate)
2981 (message2, message2_nolog, message3, message3_nolog
2982 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2983 (current_message_1, truncate_echo_area, truncate_message_1)
2984 (set_message, set_message_1, store_mode_line_noprop)
2985 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2986 (text_outside_line_unchanged_p, check_point_in_composition)
2987 (reconsider_clip_changes)
2988 (redisplay_internal, set_cursor_from_row, try_scrolling)
2989 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2990 (redisplay_window, find_last_unchanged_at_beg_row)
2991 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2992 (trailing_whitespace_p, find_row_edges, display_line)
2993 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2994 (display_mode_element, store_mode_line_string)
2995 (pint2str, pint2hrstr, decode_mode_spec)
2996 (display_count_lines, display_string, draw_glyphs)
2997 (x_produce_glyphs, x_insert_glyphs)
2998 (rows_from_pos_range, mouse_face_from_buffer_pos)
2999 (fast_find_string_pos, mouse_face_from_string_pos)
3000 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3002 (safe_call, init_from_display_pos, handle_fontified_prop)
3003 (handle_single_display_spec, load_overlay_strings)
3004 (with_echo_area_buffer, setup_echo_area_for_printing)
3005 (display_echo_area, echo_area_display)
3006 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3007 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3008 (redisplay_window, dump_glyph_row, display_mode_line)
3009 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3010 (handle_display_spec, display_prop_string_p):
3011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3012 (handle_single_display_spec, build_desired_tool_bar_string)
3013 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3014 (get_specified_cursor_type):
3015 Check that fixnums are in proper range for system types.
3016 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3017 (Flookup_image_map):
3018 Don't assume fixnums fit in int.
3019 (compare_overlay_entries):
3020 Avoid mishandling comparisons due to subtraction overflow.
3021 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3022 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3023 (handle_tool_bar_click):
3024 Use int, not unsigned, since we prefer signed and the signedness
3025 doesn't matter here.
3026 (get_next_display_element, next_element_from_display_vector):
3027 Use int, not EMACS_INT, when int is wide enough.
3028 (start_hourglass): Use duration_to_sec_usec to do proper
3029 overflow checking on durations.
3030 * xfaces.c (Fbitmap_spec_p):
3031 Check that fixnums are in proper range for system types.
3032 (compare_fonts_by_sort_order):
3033 Avoid mishandling comparisons due to subtraction overflow.
3034 (Fx_family_fonts, realize_basic_faces):
3035 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3037 Don't assume fixnum fits in int.
3038 Use SAFE_ALLOCA_LISP, not alloca.
3039 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3040 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3041 (face_at_buffer_position, face_for_overlay_string)
3042 (face_at_string_position):
3043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3044 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3045 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3047 Check that fixnums are in proper range for system types.
3048 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3049 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3051 (Fx_change_window_property): Don't assume fixnums fit in int.
3052 * xfont.c (xfont_chars_supported):
3053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3054 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3055 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3057 * xml.c (parse_region):
3058 * xrdb.c (magic_file_p):
3059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3060 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3061 (x_get_local_selection, x_reply_selection_request)
3062 (x_handle_selection_request, wait_for_property_change):
3063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3064 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3065 short is wide enough.
3066 (x_send_client_event): Don't assume fixnum fits in int.
3067 * xterm.c (x_x_to_emacs_modifiers):
3068 Don't assume EMACS_INT overflows nicely into int.
3069 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3071 (handle_one_xevent): NATNUMP can eval its arg twice.
3072 (x_connection_closed):
3073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3074 * xterm.h: Adjust decls to match defn changes elsewhere.
3075 (struct scroll_bar): Use struct vectorlike_header
3076 rather than rolling our own approximation.
3077 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3079 2012-05-25 Glenn Morris <rgm@gnu.org>
3081 * lisp.mk (lisp): Update for more files being compiled now.
3083 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3085 * lread.c: Remove `read_pure' which makes no difference.
3086 (read_pure): Remove var.
3087 (unreadpure): Remove function.
3088 (readevalloop): Don't call read_list with -1 flag.
3089 (read1, read_vector): Don't test read_pure any more.
3090 (read_list): Simplify.
3092 * fileio.c, character.h: Minor style tweaks.
3094 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3096 * window.h (clip_changed): Remove useless declaration.
3098 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3100 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3101 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3103 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3106 This directory predates autoconf and is no longer needed nowadays.
3107 Move its few remaining bits of functionality to where they're needed.
3108 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3109 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3110 * m/template.h: Remove.
3111 * Makefile.in (M_FILE): Remove. All uses removed.
3112 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3113 * lisp.h (USE_LSB_TAG):
3114 * mem-limits.h (EXCEEDS_LISP_PTR):
3115 Use VAL_MAX, not VALBITS, in #if.
3116 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3117 (EMACS_UINT): Define unconditionally now.
3118 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3119 (BITS_PER_EMACS_INT): New constants, replacing
3120 what used to be in config.h, but not useful in #if.
3121 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3122 define them any more.
3123 (VAL_MAX): New macro.
3125 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3126 BITS_PER_EMACS_INT, in #if.
3127 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3128 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3129 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3130 * s/ms-w32.h (DATA_START):
3131 Move here from removed file m/intel386.h.
3132 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3133 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3135 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3137 Assume C89 or later.
3138 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3139 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3141 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3142 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3143 * textprop.c, tparam.c (NULL): Remove.
3144 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3145 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3146 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3147 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3148 * xterm.c (input_signal_count): Assume volatile works.
3150 2012-05-21 Ken Brown <kbrown@cornell.edu>
3152 * xgselect.c (xg_select): Fix first argument in call to 'select'
3155 2012-05-20 Ken Brown <kbrown@cornell.edu>
3157 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3158 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3160 2012-05-19 Ken Brown <kbrown@cornell.edu>
3162 * xfns.c (x_in_use): Remove `static' qualifier.
3163 * xterm.h (x_in_use): Declare.
3164 * xgselect.c: Include xterm.h.
3165 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3166 and `display_arg' (bug#9754).
3168 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3170 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3172 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3173 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3175 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3177 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3179 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3180 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3182 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3183 reference to image_cache->refcount.
3184 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3186 2012-05-17 Juri Linkov <juri@jurta.org>
3188 * search.c (Fword_search_regexp, Fword_search_backward)
3189 (Fword_search_forward, Fword_search_backward_lax)
3190 (Fword_search_forward_lax): Move functions to isearch.el
3191 (bug#10145, bug#11381).
3193 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3195 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3197 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3199 * lread.c (init_obarray): Declare Qt and Qnil as special.
3201 2012-05-14 Glenn Morris <rgm@gnu.org>
3203 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3204 Put "libexec" before "bin", for the sake of init_callproc_1.
3206 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3208 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3210 * unexaix.c: Port to more-recent AIX compilers.
3211 (report_error, report_error_1, make_hdr, copy_sym)
3212 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3213 Make arguments const char *, not char *, to avoid violations of C
3214 standard and to fix some AIX warnings reported by Gilles Pion.
3216 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3218 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3219 already have overlays loaded.
3220 (handle_single_display_spec): Before returning without displaying
3221 fringe bitmap, synchronize the bidi iterator with the main display
3222 iterator, by calling iterate_out_of_display_property.
3223 (iterate_out_of_display_property): Detect buffer iteration by
3224 testing that it->string is a Lisp string.
3225 (get_next_display_element): When the current object is exhausted,
3226 and there's something on it->stack, call set_iterator_to_next to
3227 proceed with what's on the stack, instead of returning zero.
3228 (set_iterator_to_next): If called at the end of a Lisp string,
3229 proceed to consider_string_end without incrementing string
3230 position. Don't increment display vector index past the end of
3231 the display vector. (Bug#11417)
3232 (pos_visible_p): Don't report a position visible when move_it_to
3233 stopped at the last line of window, which happens to be scanned
3234 backwards by the bidi iteration. (Bug#11464)
3236 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3238 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3239 and right-margin display specs even if the spec is invalid or we
3240 are on a TTY, and thus unable to display on the fringes.
3241 That's because the text with the property will not be displayed anyway,
3242 so we need to signal to the caller that this is a "replacing"
3243 display spec. This fixes display when the spec is invalid or we
3246 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3248 * unexaix.c (make_hdr): Fix typo in prototype.
3249 This bug broke the build on AIX. Problem reported by Gilles Pion.
3251 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3253 * keyboard.c (kbd_buffer_get_event): Read special events also in
3254 batch mode. (Bug#11415)
3256 2012-05-12 Glenn Morris <rgm@gnu.org>
3258 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3260 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3262 * lisp.mk (lisp): Add newcomment.elc.
3264 2012-05-12 Glenn Morris <rgm@gnu.org>
3266 * Makefile.in (MKDIR_P): New, set by configure.
3267 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3269 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3271 Remove unused function hourglass_started.
3272 * dispextern.h (hourglass_started):
3273 * w32fns.c (hourglass_started):
3274 * xdisp.c (hourglass_started): Remove.
3276 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3278 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3279 Update dependencies.
3281 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3283 * xgselect.c (xg_select): Put maxfds+1 into a var.
3284 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3286 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3288 2012-05-10 Dave Abrahams <dave@boostpro.com>
3290 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3291 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3293 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3295 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3296 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3297 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3298 Initialize xd_registered_buses.
3300 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3302 Untag more efficiently if USE_LSB_TAG.
3303 This is based on a proposal by YAMAMOTO Mitsuharu in
3304 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3305 For an admittedly artificial (nth 8000 longlist) benchmark on
3306 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3307 Emacs's overall text size by 1%.
3308 * lisp.h (XUNTAG): New macro.
3309 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3310 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3311 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3312 * eval.c (Fautoload):
3313 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3314 * frame.h (XFRAME): Use XUNTAG.
3316 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3317 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3318 Remove unportable assumptions about print widths of types like
3320 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3321 intptr_t when converting between pointer and integer, to avoid GCC
3322 warnings about wrong width.
3324 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3326 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3327 stack for each reader_thread, instead of defaulting to 8MB
3328 determined by the linker. This avoids failures in creating
3329 subprocesses on Windows 7, see the discussion in this thread:
3330 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3332 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3334 Fix up display of the *Minibuf-0* buffer in the mini window.
3335 * keyboard.c (read_char): Don't clear the echo area if there's no
3337 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3338 contents of *Minibuf-0*) if there's no message displayed in its stead.
3340 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3342 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3345 2012-05-06 Chong Yidong <cyd@gnu.org>
3347 * lisp.mk (lisp): Update.
3349 2012-05-05 Jim Meyering <meyering@redhat.com>
3351 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3353 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3355 * data.c (PUT_ERROR): New macro.
3356 (syms_of_data): Use it. Add new error type `user-error'.
3357 * undo.c (user_error): New function.
3358 (Fprimitive_undo): Use it.
3359 * print.c (print_error_message): Adjust print style for `user-error'.
3360 * keyboard.c (user_error): New function.
3361 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3363 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3365 Do not limit current-time-string to years 1000..9999.
3366 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3367 (Fcurrent_time_string): Support any year that is supported by the
3368 underlying localtime representation. Don't use asctime, as it
3369 has undefined behavior for years outside the range -999..9999.
3371 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3373 Fix race conditions involving setenv, gmtime, localtime, asctime.
3374 Without this fix, interrupts could mess up code that uses these
3375 nonreentrant functions, since setting TZ invalidates existing
3376 tm_zone or tzname values, and since most of these functions return
3377 pointers to static storage.
3378 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3379 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3380 Grow the critical sections to include not just invoking
3381 localtime/gmtime, but also accessing these functions' results
3382 including their tm_zone values if any, and any related TZ setting.
3383 (format_time_string): Last arg is now struct tm *, not struct tm **,
3384 so that the struct tm is saved in the critical section.
3385 All callers changed. Simplify allocation of initial buffer, partly
3386 motivated by the fact that memory allocation needs to be outside
3387 the critical section.
3389 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3391 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3392 with RESET_INTERVAL.
3394 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3395 Remove duplicated buffer name initialization.
3397 2012-05-02 Jim Meyering <jim@meyering.net>
3399 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3401 * xfns.c (x_window): Use xstrdup (Bug#11375).
3403 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3405 * xdisp.c (pos_visible_p): If already at a newline from the
3406 display string before the 'while' loop, don't walk back the glyphs
3407 from it3.glyph_row. Solves assertion violation when the display
3408 string begins with a newline (egg.el). (Bug#11367)
3410 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3412 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3415 2012-05-01 Glenn Morris <rgm@gnu.org>
3417 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3418 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3419 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3420 All were removed before 23.1.
3422 * dispnew.c: Remove HAVE_LIBNCURSES test;
3423 it is always true on relevant platforms.
3425 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3426 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3428 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3430 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3432 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3433 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3436 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3438 Do not avoid creating empty evaporating overlays (Bug#9642).
3439 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3440 That is, do not delete an evaporating overlay if it becomes
3441 empty after its bounds are adjusted to fit within its buffer.
3442 This fix caused other problems, and I'm reverting it until we get
3443 to the bottom of them.
3445 2012-04-27 Chong Yidong <cyd@gnu.org>
3447 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3449 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3451 * xdisp.c (pos_visible_p): If the window start position is beyond
3452 ZV, start the display from buffer beginning. Prevents assertion
3453 violation in init_iterator when the minibuffer window is scrolled
3456 * window.c (window_scroll_pixel_based): Likewise.
3458 2012-04-27 Chong Yidong <cyd@gnu.org>
3460 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3462 2012-04-27 Glenn Morris <rgm@gnu.org>
3464 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3465 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3467 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3469 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3470 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3472 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3474 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3475 display element, check also the underlying string or buffer
3476 character. (Bug#11341)
3478 * w32menu.c: Include w32heap.h.
3479 (add_menu_item): If the call to AppendMenuW (via
3480 unicode_append_menu) fails, disable Unicode menus only if we are
3481 running on Windows 9X/Me.
3483 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3485 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3486 (xgetint): Add missing shift for LSB tags.
3488 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3490 * keyboard.c (read_char): Don't wipe echo area for select window
3491 events: These might get delayed via `mouse-autoselect-window'
3494 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3496 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3497 manipulation of :loaded-from data.
3499 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3501 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3502 now a cons (bug#11311).
3504 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3506 Do not create empty overlays with the evaporate property (Bug#9642).
3507 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3508 if it becomes empty after its bounds are adjusted to fit within
3509 its buffer. Without this fix, in a nonempty buffer (let ((o
3510 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3511 yields an empty overlay that has the evaporate property, which is
3512 not supposed to happen.
3514 Fix minor GTK3 problems found by static checking.
3515 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3516 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3517 (struct _EmacsFixedClass, emacs_fixed_get_type):
3518 Move decls here from emacsgtkfixed.h, since they needn't be public.
3519 (emacs_fixed_get_type): Now static.
3520 (emacs_fixed_class_init): Omit unused local.
3521 (emacs_fixed_child_type): Remove; unused.
3522 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3523 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3524 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3525 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3526 (EMACS_FIXED_GET_CLASS): Remove; unused.
3527 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3529 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3530 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3532 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3534 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3535 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3536 (__malloc_size_t, __malloc_ptrdiff_t):
3537 Remove. All uses removed, replaced by the definiens if needed,
3538 since we can assume C89 or better now.
3539 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3540 (protect_malloc_state, align, get_contiguous_space)
3541 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3542 (malloc_atfork_handler_child, malloc_enable_thread)
3543 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3544 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3545 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3546 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3547 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3548 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3549 Define using prototypes, not old style.
3550 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3551 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3552 (align): Don't assume that signed integer overflow wraps around.
3553 Omit unused local var.
3554 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3555 (_free_internal_nolock, memalign, mallochook, reallochook):
3556 Omit no-longer-needed casts.
3557 (valloc): Use getpagesize, not __getpagesize.
3558 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3559 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3561 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3563 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3565 Move functions from C to Lisp. Make non-blocking method calls
3566 the default. Implement further D-Bus standard interfaces.
3568 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3569 (QCdbus_request_name_allow_replacement)
3570 (QCdbus_request_name_replace_existing)
3571 (QCdbus_request_name_do_not_queue)
3572 (QCdbus_request_name_reply_primary_owner)
3573 (QCdbus_request_name_reply_in_queue)
3574 (QCdbus_request_name_reply_exists)
3575 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3576 (QCdbus_registered_serial, QCdbus_registered_method)
3577 (QCdbus_registered_signal): New Lisp objects.
3578 (XD_DEBUG_MESSAGE): Use sizeof.
3579 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3580 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3581 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3582 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3583 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3584 (xd_signature, xd_append_arg): Allow float for integer types.
3585 (xd_get_connection_references): New function.
3586 (xd_get_connection_address): Rename from xd_initialize.
3587 Return cached address.
3588 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3589 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3591 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3592 Return number of refcounts.
3593 (Fdbus_get_unique_name): Make stronger parameter check.
3594 (Fdbus_message_internal): New defun.
3595 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3596 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3597 (Fdbus_send_signal, Fdbus_register_service)
3598 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3599 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3600 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3601 (Vdbus_compiled_version, Vdbus_runtime_version)
3602 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3603 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3604 (Vdbus_message_type_signal): New defvars.
3605 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3608 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3610 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3611 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3612 Do not assume ptrdiff_t is the same width as 'int'.
3614 * alloc.c: Handle unusual debugging option combinations.
3615 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3616 since the two debugging options are incompatible.
3617 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3619 (mem_init, mem_insert, mem_insert_fixup):
3620 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3621 (NEED_MEM_INSERT): Remove; no longer needed.
3623 2012-04-22 Leo Liu <sdl.web@gmail.com>
3625 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3627 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3629 * sysdep.c [__FreeBSD__]: Minor cleanups.
3630 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3631 Use Emacs indenting style more consistently. Avoid some casts.
3632 Use 'double' consistently rather than mixing 'float' and 'double'.
3634 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3636 * sysdep.c (list_system_processes, system_process_attributes):
3637 Add implementation for FreeBSD (Bug#5243).
3639 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3641 * lisp.mk (lisp): Update.
3643 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3645 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3646 It is never used otherwise.
3648 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3650 * print.c (print_preprocess): Only check print_depth if print-circle
3652 (print_object): Check for cycles even when print-circle is nil and
3653 print-gensym is t, but only check print_depth if print-circle is nil.
3655 2012-04-20 Chong Yidong <cyd@gnu.org>
3657 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3658 set the status to "failed" and ensure that sentinel is run.
3660 2012-04-20 Glenn Morris <rgm@gnu.org>
3662 * process.c (Fset_process_inherit_coding_system_flag)
3663 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3664 (Fmake_network_process, Fmake_serial_process): Doc fix.
3666 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3668 * xdisp.c (string_buffer_position_lim): Limit starting position to
3670 (set_cursor_from_row): If called for a mode-line or header-line
3671 row, return zero immediately.
3672 (try_cursor_movement): If inside continuation line, don't back up
3673 farther than the first row after the header line, if any.
3674 Don't consider the header-line row as "partially visible", even if
3675 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3677 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3679 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3682 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3683 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3685 configure: new option --enable-gcc-warnings (Bug#11207)
3686 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3687 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3688 (ALL_CFLAGS): Use new macros rather than old.
3689 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3690 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3691 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3692 -Wunused-result, -Wunused-variable. This should go away once
3693 the Emacs and Gnulib regex code is merged.
3694 (xmalloc, xrealloc): Now static.
3696 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3698 * dired.c (Fsystem_groups): Remove unused local.
3700 2012-04-17 Glenn Morris <rgm@gnu.org>
3702 * dired.c (Fsystem_users): Doc fix.
3704 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3706 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3707 (syms_of_dired): Add them.
3709 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3711 Fix minor alloc.c problems found by static checking.
3712 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3713 New extern decls, to avoid calling undeclared functions.
3714 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3715 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3716 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3717 (NEED_MEM_INSERT): New macro.
3718 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3719 Remove one incorrect comment and fix another.
3721 Fix minor ralloc.c problems found by static checking.
3722 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3723 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3724 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3725 (r_alloc_sbrk): Now static.
3727 Improve ralloc.c interface checking.
3728 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3729 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3730 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3731 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3732 [REL_ALLOC]: ... to here, to check interface.
3733 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3734 Remove decls. This fixes an "It stinks!".
3736 * alloc.c (which_symbols): Fix alignment issue / type clash.
3738 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3740 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3741 (struct Lisp_Misc_Any): Likewise.
3742 (struct Lisp_Free): Likewise.
3743 * alloc.c (union aligned_Lisp_Symbol): Define.
3744 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3745 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3746 (union aligned_Lisp_Misc): Define.
3747 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3748 aligned_Lisp_Misc instead of union Lisp_Misc.
3749 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3751 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3753 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3754 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3755 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3756 * s/netbsd.h, s/sol2-6.h:
3757 Remove definition of GC_MARK_STACK, since the default now works.
3758 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3759 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3760 no longer the default.
3761 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3763 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3765 * lread.c (lisp_file_lexically_bound_p):
3766 Fix hang at ";-*-\n" (bug#11238).
3768 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3770 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3771 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3773 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3775 * nsterm.m (constrainFrameRect): Always constrain when there is only
3776 one screen (Bug#10962).
3778 2012-04-13 Ken Brown <kbrown@cornell.edu>
3780 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3782 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3784 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3786 2012-04-11 Daniel Colascione <dancol@dancol.org>
3788 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3789 against is gone. It's better to use vfork now so that when Cygwin
3790 gains a new, working vfork, we use it automatically (bug#10398).
3792 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3794 * window.c (save_window_save): Obey window-point-insertion-type.
3796 2012-04-11 Glenn Morris <rgm@gnu.org>
3798 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3800 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3802 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3804 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3806 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3807 (force_quit_count): New var.
3808 (handle_interrupt): Use it.
3810 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3812 * w32.c (w32_delayed_load): Record the full path of the library
3813 being loaded (bug#10424).
3815 2012-04-09 Glenn Morris <rgm@gnu.org>
3817 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3818 not just in the obarray, before snarfing them. (Bug#11036)
3820 * Makefile.in ($(leimdir)/leim-list.el):
3821 Pass EMACS rather than BUILT_EMACS.
3823 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3825 * process.c (make_process):
3826 * process.h: Add integer `gnutls_handshakes_tried' member to
3829 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3830 Add convenience `GNUTLS_LOG2i' macro.
3832 * gnutls.c (gnutls_log_function2i): Convenience log function.
3833 (emacs_gnutls_read): Use new log functions,
3834 `gnutls_handshakes_tried' process member, and
3835 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3836 attempts per process (connection).
3838 2012-04-09 Chong Yidong <cyd@gnu.org>
3840 * eval.c (Fuser_variable_p, user_variable_p_eh)
3841 (lisp_indirect_variable): Functions deleted.
3842 (Fdefvar): Caller changed.
3844 * callint.c (Finteractive, Fcall_interactively):
3845 * minibuf.c (Fread_variable): Callers changed.
3847 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3849 * xdisp.c (set_cursor_from_row): If the display string appears in
3850 the buffer at position that is closer to point than the position
3851 after the display string, display the cursor on the first glyph of
3852 the display string. Fixes cursor display when a 'display' text
3853 property immediately follows invisible text. (Bug#11094)
3855 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3857 composite.c: use 'double' consistently
3858 * composite.c (get_composition_id): Use 'double' consistently
3859 instead of converting 'float' to 'double' and vice versa; this is
3860 easier to understand and avoids a GCC warning.
3862 2012-04-09 Glenn Morris <rgm@gnu.org>
3864 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3865 preparation for dumping it with emacs. (Bug#4789)
3866 (leimdir): New variable.
3867 ($(leimdir)/leim-list.el): New rule.
3868 (emacs$(EXEEXT)): Depend on leim-list.el.
3870 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3871 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3872 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3874 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3876 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3879 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3881 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3882 Remove unused local variable.
3884 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3886 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3887 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3888 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3889 objects, as mark_maybe_pointer will catch them otherwise.
3890 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3891 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3893 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3895 Fix typo that broke non-Windows builds.
3896 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3898 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3900 Support building on MS-Windows with libxml2.
3902 * makefile.w32-in (OBJ2): Add xml.$(O).
3903 (GLOBAL_SOURCES): Add xml.c.
3904 ($(BLD)/xml.$(O)): New dependency list.
3906 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3907 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3908 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3909 [!WINDOWSNT]: New macros.
3910 (init_libxml2_functions, libxml2_loaded_p): New functions.
3911 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3912 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3913 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3914 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3916 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3917 Call init_libxml2_functions before calling libxml2 functions.
3918 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3920 * emacs.c: Don't include libxml/parser.h.
3921 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3922 xmlCleanupParser directly.
3924 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3926 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3928 * indent.c (Fvertical_motion): If there is a display string at
3929 point, use it.vpos to compute how many lines to backtrack after
3930 move_it_to point. (Bug#11133)
3932 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3934 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3935 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3936 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3937 macros related to unification of CJK characters. For the details,
3938 see the discussion following the message here:
3939 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3941 2012-04-04 Chong Yidong <cyd@gnu.org>
3943 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3945 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3947 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3948 instead of alloca. (Bug#11138)
3950 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3952 * w32menu.c (is_simple_dialog): Properly check lisp types.
3955 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3957 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3958 position we get to after a call to move_it_to fails the
3959 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3960 only if we wind up in a string from display property. (Bug#11063)
3962 * window.c (Fdelete_other_windows_internal): Invalidate the row
3963 and column information about mouse highlight, so that redisplay
3964 restores it after reallocating the glyph matrices. (Bug#7464)
3966 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3967 string comes from a `display' text property, use the buffer
3968 position of that property as if we actually saw that position in
3970 (move_it_by_lines): Remove the assertion that
3971 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3972 violated when there's a before-string at the beginning of a line.
3975 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3977 * xdisp.c (append_space_for_newline): If the default face was
3978 remapped, use the remapped face for the appended newline.
3979 (extend_face_to_end_of_line): Use the remapped default face for
3980 extending the face to the end of the line.
3981 (display_line): Call extend_face_to_end_of_line when the default
3982 face was remapped. (Bug#11068)
3984 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3986 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3988 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3990 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3992 2012-03-27 Glenn Morris <rgm@gnu.org>
3994 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3997 2012-03-26 Kenichi Handa <handa@m17n.org>
3999 * dispextern.h (struct glyph): Fix previous change. Change the
4000 bit length of glyphless.ch to 25 (Bug#11082).
4002 2012-03-26 Chong Yidong <cyd@gnu.org>
4004 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4005 (command_loop_1): Use it; inhibit selection update for
4006 handle-select-window too (Bug#8996).
4008 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4010 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4012 2012-03-25 Kenichi Handa <handa@m17n.org>
4014 * dispextern.h (struct glyph): Change the bit length of
4015 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4017 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4019 * s/ms-w32.h (tzname): Include time.h before redirecting to
4020 _tzname. Fixes the MSVC build. (Bug#9960)
4022 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4024 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4027 * xterm.c (XTread_socket): Only modify handling_signal if
4028 !SYNC_INPUT. (Bug#11080)
4030 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4032 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4033 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4034 when fetching a multibyte character consumes more bytes than
4035 CHAR_BYTES returns, due to unification of CJK characters in
4036 string_char. (Bug#11073)
4038 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4040 * process.c (wait_reading_process_output): Handle pty disconnect
4041 by refraining from sending oneself a SIGCHLD (bug#10933).
4043 2012-03-22 Chong Yidong <cyd@gnu.org>
4045 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4047 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4048 Mark string as coming from a prefix property.
4049 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4050 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4052 2012-03-21 Chong Yidong <cyd@gnu.org>
4054 * xfaces.c (Vface_remapping_alist): Doc fix.
4056 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4058 * w32proc.c (Fw32_set_console_codepage)
4059 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4062 2012-03-20 Chong Yidong <cyd@gnu.org>
4064 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4065 to reflect default non-nil value of redisplay-dont-pause.
4067 2012-03-19 Kenichi Handa <handa@m17n.org>
4069 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4070 it fit in a valid range (Bug#11003).
4072 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4074 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4075 that is not from display property, accept the row as a "cursor
4076 row" if one of the string's character has a non-nil `cursor'
4077 property. Fixes cursor positioning when there are newlines in
4078 overlay strings, e.g. in icomplete.el. (Bug#11035)
4080 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4082 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4084 2012-03-12 Chong Yidong <cyd@gnu.org>
4086 * eval.c (inhibit_lisp_code): Rename from
4087 inhibit_window_configuration_change_hook; move from window.c.
4089 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4090 * window.c (run_window_configuration_change_hook)
4091 (syms_of_window): Callers changed.
4093 2012-03-11 Chong Yidong <cyd@gnu.org>
4095 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4097 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4099 2012-03-10 Chong Yidong <cyd@gnu.org>
4101 * frame.c (other_visible_frames): Don't assume the selected frame
4102 is visible (Bug#10955).
4104 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4106 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4108 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4110 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4111 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4114 2012-03-03 Glenn Morris <rgm@gnu.org>
4116 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4118 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4120 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4121 position past the first glyph_row that ends at ZV. (Bug#10902)
4122 (redisplay_window, next_element_from_string): Fix typos in
4124 (redisplay_window): Pass to move_it_vertically the margin in
4125 pixels, not in screen lines.
4127 2012-03-02 Glenn Morris <rgm@gnu.org>
4129 * buffer.c (buffer-list-update-hook): Doc fix.
4131 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4133 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4134 push_it before setting up the iterator for the first overlay
4135 string, even if we have an empty string loaded.
4136 (next_overlay_string): If there's an empty string on the iterator
4137 stack, pop the stack. (Bug#10903)
4139 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4141 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4142 Suggested by Stefan Monnier in
4143 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4144 * alloc.c (widen_to_Lisp_Object): New static function.
4145 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4146 and widening them to Lisp_Objects. This would work even if
4147 USE_LSB_TAG is defined and wide integers are used, which might
4148 happen in a future version of Emacs.
4150 2012-02-25 Chong Yidong <cyd@gnu.org>
4152 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4155 * xselect.c (Fx_selection_exists_p): Doc fix.
4156 (x_clipboard_manager_save_all): Print an informative message
4157 before saving to clipboard manager.
4159 2012-02-24 Chong Yidong <cyd@gnu.org>
4161 * keyboard.c (process_special_events): Handle all X selection
4162 requests in kbd_buffer, not just the next one (Bug#8869).
4164 2012-02-23 Chong Yidong <cyd@gnu.org>
4166 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4167 call when setting menu-bar-lines and tool-bar-lines parameters.
4168 (unwind_create_frame_1): New helper function.
4170 * window.c (inhibit_window_configuration_change_hook): New var.
4171 (run_window_configuration_change_hook): Obey it.
4172 (syms_of_window): Initialize it.
4174 2012-02-22 Chong Yidong <cyd@gnu.org>
4176 * xterm.c (x_draw_image_relief): Add missing type check for
4177 Vtool_bar_button_margin (Bug#10743).
4179 2012-02-21 Chong Yidong <cyd@gnu.org>
4181 * fileio.c (Vfile_name_handler_alist): Doc fix.
4183 * buffer.c (Fget_file_buffer): Protect against invalid file
4184 handler return value.
4186 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4188 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4189 when computing $valmask.
4191 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4192 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4193 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4194 It's useless in that case, and it can cause problems on hosts
4195 that allocate halves of EMACS_INT values separately.
4196 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4197 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4198 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4199 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4200 it avoids undefined behavior on hosts where shifting right by more
4201 than the word width has undefined behavior.
4203 2012-02-19 Chong Yidong <cyd@gnu.org>
4205 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4206 (Funhandled_file_name_directory, Ffile_name_as_directory)
4207 (Fdirectory_file_name, Fexpand_file_name)
4208 (Fsubstitute_in_file_name): Protect against invalid file handler
4209 return values (Bug#10845).
4211 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4213 * .gdbinit (pitx): Fix incorrect references to fields of the
4216 2012-02-17 Chong Yidong <cyd@gnu.org>
4218 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4220 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4222 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4223 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4225 2012-02-15 Chong Yidong <cyd@gnu.org>
4227 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4228 marked as special. Also, starting docstrings with * is obsolete.
4230 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4232 * gnutls.c (emacs_gnutls_write): Fix last change.
4234 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4236 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4239 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4241 * keymap.c (Fsingle_key_description): Handle char ranges.
4243 2012-02-12 Chong Yidong <cyd@gnu.org>
4245 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4246 as that creates a dangerous corner case.
4248 * window.c (Fdelete_window_internal): Invalidate the mouse
4249 highlight (Bug#9904).
4251 2012-02-12 Glenn Morris <rgm@gnu.org>
4253 * xselect.c (Fx_own_selection_internal)
4254 (Fx_get_selection_internal, Fx_disown_selection_internal)
4255 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4256 * nsselect.m (Fx_own_selection_internal)
4257 (Fx_disown_selection_internal, Fx_selection_exists_p)
4258 (Fx_selection_owner_p, Fx_get_selection_internal):
4259 Sync docs and argument specs with the xselect.c versions.
4261 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4263 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4265 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4267 * w32select.c (Fx_selection_exists_p): Sync doc string and
4268 argument list with xselect.c. (Bug#10783)
4270 * w16select.c (Fx_selection_exists_p): Sync doc string and
4271 argument list with xselect.c. (Bug#10783)
4273 2012-02-10 Glenn Morris <rgm@gnu.org>
4275 * fns.c (Fsecure_hash): Doc fix.
4277 2012-02-09 Kenichi Handa <handa@m17n.org>
4279 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4281 2012-02-07 Chong Yidong <cyd@gnu.org>
4283 * buffer.c (Fbuffer_local_variables)
4284 (buffer_lisp_local_variables): Handle unbound vars correctly;
4285 don't let Qunbound leak into Lisp.
4287 2012-02-07 Glenn Morris <rgm@gnu.org>
4289 * image.c (Fimagemagick_types): Doc fix.
4291 * image.c (imagemagick-render-type): Change it from a lisp object
4292 to an integer. Move the doc here from the lisp manual.
4293 Treat all values not equal to 0 the same.
4295 2012-02-06 Chong Yidong <cyd@gnu.org>
4297 * doc.c (store_function_docstring): Avoid applying docstring of
4298 alias to base function (Bug#2603).
4300 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4302 * .gdbinit (pp1, pv1): Remove redundant defines.
4305 2012-02-04 Chong Yidong <cyd@gnu.org>
4307 * nsterm.m: Declare a global (Bug#10694).
4309 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4311 * w32.c (get_emacs_configuration_options):
4312 Include --enable-checking, if specified, in the return value.
4314 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4316 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4317 after rounding frame sizes. (Bug#9723)
4319 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4321 * keyboard.c (adjust_point_for_property): Don't position point
4322 before BEGV. (Bug#10696)
4324 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4326 Handle overflow when computing char display width (Bug#9496).
4327 * character.c (char_width): Return EMACS_INT, not int.
4328 (char_width, c_string_width): Check for overflow when
4329 computing the width; this is possible now that individual
4330 characters can have unbounded width. Problem introduced
4331 by merge from Emacs 23 on 2012-01-19.
4333 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4335 * dbusbind.c (Fdbus_register_method): Mention the return value
4336 :ignore in the docstring.
4338 2012-02-02 Glenn Morris <rgm@gnu.org>
4340 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4342 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4343 Unconditionally set to t. (Bug#10673)
4344 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4345 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4346 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4348 2012-02-02 Kenichi Handa <handa@m17n.org>
4350 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4351 0, do not call append_composite_glyph.
4353 2012-02-02 Kenichi Handa <handa@m17n.org>
4355 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4357 (x_produce_glyphs): If the component of a composition is a null
4358 string, set it->pixel_width to 1 to avoid zero-width glyph.
4360 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4362 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4363 first 2 arguments are identical. This makes inserting large
4364 output from a subprocess an order of magnitude faster on
4365 MS-Windows, where all sbrk'ed memory is always contiguous.
4367 2012-01-31 Glenn Morris <rgm@gnu.org>
4369 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4370 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4371 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4373 2012-01-29 Glenn Morris <rgm@gnu.org>
4375 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4377 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4379 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4381 2012-01-28 Chong Yidong <cyd@gnu.org>
4383 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4385 2012-01-26 Chong Yidong <cyd@gnu.org>
4387 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4389 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4390 repeat counts (Bug#10507).
4392 2012-01-26 Glenn Morris <rgm@gnu.org>
4394 * lread.c (syms_of_lread): Doc fix.
4396 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4398 * coding.c (encode_designation_at_bol): Change return value to
4401 2012-01-25 Chong Yidong <cyd@gnu.org>
4403 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4405 2012-01-21 Chong Yidong <cyd@gnu.org>
4407 * floatfns.c (Fcopysign): Make the second argument non-optional,
4408 since nil is not allowed anyway.
4410 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4412 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4413 (send_process): Likewise.
4415 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4417 * window.c (save_window_save, Fcurrent_window_configuration)
4418 (Vwindow_persistent_parameters): Do not use Qstate.
4419 Rewrite doc-strings.
4421 2012-01-19 Kenichi Handa <handa@m17n.org>
4423 * character.c (char_width): New function.
4424 (Fchar_width, c_string_width, lisp_string_width):
4425 Use char_width (Bug#9496).
4427 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4429 * window.c (Vwindow_persistent_parameters): New variable.
4430 (Fset_window_configuration, save_window_save): Handle persistent
4433 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4435 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4436 thrashing the stack of the thread. (Bug#9087)
4438 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4440 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4442 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4444 * xdisp.c (rows_from_pos_range): Handle the case where the
4445 highlight ends on a newline. (Bug#10464)
4446 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4447 he end column for display of highlight that ends on a newline
4450 2012-01-11 Glenn Morris <rgm@gnu.org>
4452 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4453 from load-path also when installation-directory is nil. (Bug#10208)
4455 2012-01-10 Glenn Morris <rgm@gnu.org>
4457 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4459 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4460 Update template values to be closer to their typical values these days.
4462 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4464 * xdisp.c (rows_from_pos_range): Accept additional argument
4465 DISP_STRING, and accept any glyph in a row whose object is that
4466 string as eligible for mouse highlight. Fixes mouse highlight of
4467 display strings from overlays. (Bug#10464)
4469 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4471 emacs: fix an auto-save permissions race condition (Bug#10400)
4472 * fileio.c (auto_saving_dir_umask): New static var.
4473 (Fmake_directory_internal): Use it.
4474 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4475 creating the directory. The old code temporarily assigns
4476 too-generous permissions to the directory.
4477 (do_auto_save_eh): Clear it.
4478 (Fdo_auto_save): Catch all errors, not just file errors, so
4479 that the var is always cleared.
4481 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4483 * search.c (scan_buffer): Pass character positions to
4484 know_region_cache, not byte positions. (Bug#6540)
4486 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4488 * w32.c (sys_rename): Report EXDEV when rename of a directory
4489 fails because the target is on another logical disk. (Bug#10284)
4491 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4493 * xterm.c (x_embed_request_focus): New function.
4495 * xterm.h: Add prototype.
4497 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4499 2012-01-05 Glenn Morris <rgm@gnu.org>
4501 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4503 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4505 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4506 Load gnutls_transport_set_lowat only if GnuTLS version is below
4508 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4509 GnuTLS versions below 2.11.1.
4511 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4513 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4514 to the doc string advising against its use for altering the way
4515 windows are scrolled.
4517 2011-12-28 Kenichi Handa <handa@m17n.org>
4519 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4520 coding-system ASCII compatible only when it does not produce BOM
4521 on encoding (Bug#10383).
4523 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4525 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4527 (create_and_show_popup_menu): Always use menu_position_func for
4530 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4532 * callint.c (Fcall_interactively): Don't truncate prompt string.
4534 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4536 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4537 property that ends at ZV, so that the bidi iteration could be
4538 resumed from there (after widening). (Bug#10360)
4540 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4542 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4544 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4546 * nsterm.m (x_free_frame_resources):
4547 Release f->output_data.ns->miniimage.
4548 (ns_index_color): Fix indentation. Do not retain
4549 color_table->colors[i].
4551 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4554 * nsfns.m (x_set_background_color): Assign return value from
4555 ns_index_color to face-background instead of NSColor*.
4556 (ns_implicitly_set_icon_type): Fix indentation.
4557 Change assignment in for loop to comparison.
4559 * emacs.c (ns_pool): New variable.
4560 (main): Assign ns_pool.
4561 (Fkill_emacs): Call ns_release_autorelease_pool.
4563 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4564 autorelease fdesc, release fdAttrs and tdict.
4565 (ns_get_covering_families): Release charset.
4566 (ns_findfonts): Release NSFontDescriptor created with new.
4567 (ns_uni_to_glyphs): Fix indentation.
4568 (setString): Release attrStr before assigning new value.
4570 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4572 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4574 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4575 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4577 2011-12-18 David Reitter <reitter@cmu.edu>
4579 * nsterm.m (ns_term_init): Subscribe for notifications
4580 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4581 to method trackingNotification in EmacsMenu.
4583 * nsmenu.m (trackingMenu): New variable.
4584 (trackingNotification): New method (from Aquamacs).
4585 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4586 from Aquamacs (Bug#7030).
4588 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4590 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4591 (symbol_to_nsstring): Fix indentation.
4592 (ns_symbol_to_pb): New function.
4593 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4594 (Fns_rotate_cut_buffers_internal): Remove.
4595 (Fns_store_selection_internal): Rename from
4596 Fns_store_cut_buffer_internal.
4597 (ns_get_foreign_selection, Fx_own_selection_internal)
4598 (Fx_disown_selection_internal, Fx_selection_exists_p)
4599 (Fns_get_selection_internal, Fns_store_selection_internal):
4600 Use ns_symbol_to_pb and check if return value is nil.
4601 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4602 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4603 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4604 renamed to Sns_store_selection_internal.
4605 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4606 and remove this function.
4607 (ns_handle_selection_clear): Remove, never used.
4608 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4611 2011-12-17 Ken Brown <kbrown@cornell.edu>
4613 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4614 GID is unknown (Bug#10257).
4616 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4618 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4619 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4620 which caused a build failure on GNU/Linux IA-64. This problem was
4621 introduced by my 2011-10-07 patch.
4623 2011-12-15 Juri Linkov <juri@jurta.org>
4625 * image.c (imagemagick_error): New function. (Bug#10112)
4626 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4627 Use `imagemagick_error' where ImageMagick functions return
4629 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4632 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4634 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4635 fill background (Bug#8992).
4637 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4639 * window.c (Vwindow_combination_resize)
4640 (Vwindow_combination_limit): Use t instead of non-nil in
4642 (Vrecenter_redisplay): Add first sentence of doc-string on
4644 (Frecenter): Fix doc-string typo.
4646 2011-12-11 Kenichi Handa <handa@m17n.org>
4648 * coding.c (Funencodable_char_position): Pay attention to the
4649 buffer text relocation (Bug#9389).
4651 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4653 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4654 gtk_init (Bug#10100).
4656 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4658 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4659 IT->string is nil. (Bug#10263)
4661 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4663 * nsterm.h (x_free_frame_resources): Declare.
4665 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4666 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4668 * nsterm.h (ns_get_defaults_value): Declare.
4670 * nsterm.m (ns_default): Call ns_get_defaults_value.
4672 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4674 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4677 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4679 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4680 that where the value of an _OBJC_* symbol points to is in the .bss
4681 section (Bug#10240).
4683 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4685 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4686 after the loop to call ccl_driver at least once (Bug#8619).
4688 2011-12-08 Kenichi Handa <handa@m17n.org>
4690 * ftfont.c (get_adstyle_property): Fix previous change
4693 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4695 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4696 dirs from the default value of EMACSLOADPATH (bug#10208).
4698 2011-12-07 Glenn Morris <rgm@gnu.org>
4700 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4701 installation and source directories as well. (Bug#10208)
4703 2011-12-06 Chong Yidong <cyd@gnu.org>
4705 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4707 2011-12-06 Glenn Morris <rgm@gnu.org>
4709 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4710 as an error, not just -1. (Bug#10217)
4712 2011-12-05 Chong Yidong <cyd@gnu.org>
4714 * keyboard.c (process_special_events): New function.
4715 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4717 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4719 * coding.c (encode_designation_at_bol): Don't use uninitialized
4720 local variable (Bug#9318).
4722 2011-12-05 Kenichi Handa <handa@m17n.org>
4724 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4725 return Qnil (Bug#8046, Bug#10193).
4727 2011-12-05 Kenichi Handa <handa@m17n.org>
4729 * coding.c (encode_designation_at_bol): New args charbuf_end and
4730 dst. Return the number of produced bytes. Callers changed.
4731 (coding_set_source): Return how many bytes coding->source was
4733 (coding_set_destination): Return how many bytes
4734 coding->destination was relocated.
4735 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4736 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4738 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4740 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4741 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4744 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4746 The following changes are to fix Bug#9318.
4748 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4749 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4750 (encode_coding_iso_2022, encode_coding_sjis)
4751 (encode_coding_big5, encode_coding_charset): Use the above macros.
4753 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4755 * lisp.h (process_quit_flag): Fix external declaration.
4757 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4759 Don't macro-inline non-performance-critical code.
4760 * eval.c (process_quit_flag): New function.
4761 * lisp.h (QUIT): Use it.
4763 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4765 * nsfns.m (get_geometry_from_preferences): New function.
4766 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4768 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4770 * emacs.c (Qkill_emacs): Define.
4771 (syms_of_emacs): Initialize it.
4772 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4773 Qquit_flag to `kill-emacs' instead.
4774 (quit_throw_to_read_char): Add parameter `from_signal'.
4775 All callers changed. Call Fkill_emacs if requested and safe.
4776 * lisp.h (QUIT): Call Fkill_emacs if requested.
4778 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4780 * widget.c (update_wm_hints): Return if wmshell is null.
4781 (widget_update_wm_size_hints): New function.
4783 * widget.h (widget_update_wm_size_hints): Declare.
4785 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4786 widget_update_wm_size_hints (Bug#10104).
4788 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4790 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4791 before a newline, prepare the bidi iterator for consuming the
4792 newline, and keep the current paragraph direction. (Bug#10183)
4793 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4795 2011-12-02 Juri Linkov <juri@jurta.org>
4797 * search.c (Fword_search_regexp): New Lisp function created from
4798 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4799 (Fword_search_backward, Fword_search_forward)
4800 (Fword_search_backward_lax, Fword_search_forward_lax):
4801 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4802 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4804 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4806 * fileio.c (Finsert_file_contents): Move after-change-function call
4807 to before the "handled:" label, since all "goto handled" appear in
4808 cases where the *-change-functions have already been properly called
4811 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4813 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4814 waiting for input. (Bug#10169)
4816 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4818 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4819 verifies glyph row's hash code--we have just reallocated the
4820 glyphs, so their contents can be complete garbage. (Bug#10164)
4822 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4824 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4826 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4828 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4829 attributes are tested _before_ calling verify_row_hash, to protect
4830 against GCC re-ordering of the tests. (Bug#10164)
4832 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4834 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4836 * xterm.c (handle_one_xevent): Only set async_visible and friends
4837 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4838 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4839 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4841 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4843 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4844 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4845 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4846 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4847 All uses changed to use GCPRO1 etc.
4848 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4849 Revert to old implementation (i.e., before 2011-03-11).
4851 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4853 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4854 of scroll runs so as to avoid assigning disabled bogus rows and
4855 unnecessary graphics copy operations.
4857 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4859 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4860 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4861 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4862 (malloc, free, realloc, calloc): Redirect to e_* only when
4865 * lisp.h (GCTYPEBITS): Move before first use.
4866 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4867 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4868 this macro definition.
4870 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4873 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4875 * gtkutil.c (xg_create_frame_widgets):
4876 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4877 present with Gtk+ 2.0.
4879 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4881 * fileio.c (Finsert_file_contents): Undo previous change; see
4882 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4884 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4886 Rename locals to avoid shadowing.
4887 * fileio.c (Finsert_file_contents):
4888 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4889 * process.c (wait_reading_process_output):
4890 Rename inner 'proc' to 'p' to avoid shadowing.
4891 Indent for consistency with usual Emacs style.
4893 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4895 * xdisp.c (redisplay_window): If cursor row is not fully visible
4896 after recentering, and scroll-conservatively is set to a large
4897 number, scroll window by a few more lines to make the cursor fully
4898 visible and out of scroll-margin. (Bug#10105)
4899 (start_display): Don't move to the next line if the display should
4900 start at a newline that is part of a display vector or an overlay
4903 2011-11-24 Juri Linkov <juri@jurta.org>
4905 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4906 after the `MagickPingImage' call. (Bug#10112)
4908 2011-11-23 Chong Yidong <cyd@gnu.org>
4910 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4912 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4914 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4915 making another buffer current. (Bug#10114)
4917 2011-11-23 Glenn Morris <rgm@gnu.org>
4919 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4921 2011-11-23 Chong Yidong <cyd@gnu.org>
4923 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4924 using it (Bug#5984).
4926 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4928 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4929 and header-lines, as they don't have one computed for them.
4932 * .gdbinit (prow): Make displayed values more self-explaining.
4933 Add row's hash code.
4935 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4937 * process.c (wait_reading_process_output): Fix asynchrounous
4938 GnuTLS socket handling on some versions of the GnuTLS library.
4939 (wait_reading_process_output): Add comment and URL.
4941 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4943 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4945 2011-11-21 Chong Yidong <cyd@gnu.org>
4947 * window.c (Fnext_window, Fprevious_window): Doc fix.
4949 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4951 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4953 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4955 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4957 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4959 * window.c (Fset_window_combination_limit): Rename argument
4961 (Vwindow_combination_limit): Remove "status" from doc-string.
4963 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4965 * m/ibms390.h: Remove.
4966 * m/ibms390x.h: Don't include "ibms390.h".
4968 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4970 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4971 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4973 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4975 * casetab.c (Fset_case_table):
4976 * charset.c (Fcharset_after): Fix typos.
4978 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4980 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4981 Otherwise, valgrind does not work on some platforms.
4982 Problem reported by Andreas Schwab in
4983 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4984 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4985 is set, removing the need for VIRT_ADDRESS_VARIES.
4986 (PURE_P): Use a more-efficient implementation that needs just one
4987 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4988 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4989 to 4 (xorl, subq, cmpq, setbe).
4990 * alloc.c (pure): Always extern now, since that's the
4991 VIRT_ADDR_VARIES behavior.
4992 (PURE_POINTER_P): Use a single comparison, not two, for
4993 consistency with the new puresize.h.
4994 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4995 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4996 Remove VIRT_ADDR_VARIES no longer needed.
4998 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5000 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5001 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5002 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5003 behave as if the cursor position were at the window margin.
5005 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5006 and the cursor position is out of bounds, behave as if the cursor
5007 position were at the window margin. (Bug#10075)
5009 2011-11-18 Chong Yidong <cyd@gnu.org>
5011 * window.c (Fwindow_combination_limit): Make first argument
5012 non-optional, since it is meaningless for live windows like the
5015 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5017 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5019 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5021 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5022 (graft_intervals_into_buffer): Simplify.
5024 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5026 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5027 hash values of the two rows.
5028 (copy_row_except_pointers): Preserve the used[] arrays and the
5029 hash values of the two rows. (Bug#10035)
5030 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5032 * xdisp.c (row_hash): New function, body extracted from
5033 compute_line_metrics.
5034 (compute_line_metrics): Call row_hash, instead of computing the
5037 * dispnew.c (verify_row_hash): Call row_hash for computing the
5038 hash code of a row, instead of duplicating code from xdisp.c.
5040 * dispextern.h (row_hash): Add prototype.
5042 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5044 * frame.c (delete_frame): Don't delete the terminal when the last
5045 X frame is closed if emacs is built with GTK toolkit.
5047 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5049 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5051 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5053 * window.c (Vwindow_splits): Rename to
5054 Vwindow_combination_resize. Suggested by Juri Linkov.
5055 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5058 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5060 * nsfns.m (Fns_font_name):
5061 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5063 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5065 * window.h (window): Rename slot "nest" to "combination_limit".
5066 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5067 (Fset_window_nest): Rename to Fset_window_combination_limit.
5068 (Vwindow_nest): Rename to Vwindow_combination_limit.
5069 (recombine_windows, make_parent_window, make_window)
5070 (Fsplit_window_internal, saved_window)
5071 (Fset_window_configuration, save_window_save): Rename all
5072 occurrences of window_nest to window_combination_limit.
5074 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5076 * image.c (imagemagick_load_image): Fix typo.
5078 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5080 * xdisp.c (display_line): Move the call to
5081 highlight_trailing_whitespace before the call to
5082 compute_line_metrics, since the latter needs to see the final
5083 faces of all the glyphs to compute ROW's hash value.
5084 Fixes assertion violations in row_equal_p. (Bug#10035)
5086 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5088 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5089 just return (bug#10044).
5091 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5093 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5094 with user-defined heap size. Bump the default size of the temacs
5095 heap to 27MB, to avoid memory warning when running temacs.
5096 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5098 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5099 current_matrix and desired_matrix. (Bug#9990)
5100 (verify_row_hash) [XASSERTS]: New function.
5101 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5102 that the hash value of glyph rows is correct.
5104 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5106 * window.h (window): Remove splits slot.
5107 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5108 (Fdelete_other_windows_internal, make_parent_window)
5109 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5110 (Fset_window_configuration, save_window_save): Don't deal with
5111 split status of windows.
5112 (saved_window): Remove splits slot.
5113 (Vwindow_splits): Rewrite doc-string.
5115 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5117 * xfns.c (unwind_create_frame):
5118 * nsfns.m (unwind_create_frame):
5119 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5120 Vframe_list (Bug#9999).
5122 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5124 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5126 2011-11-11 Kenichi Handa <handa@m17n.org>
5128 * callproc.c (Fcall_process): Set the member dst_multibyte of
5131 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5133 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5134 avoid a crash (bug#9496).
5136 2011-11-09 Chong Yidong <cyd@gnu.org>
5138 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5139 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5141 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5143 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5145 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5147 Avoid some portability problems by eschewing 'extern inline' functions.
5148 The trivial performance wins aren't worth the portability hassles; see
5149 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5151 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5152 (window_box_width, window_box_left, window_box_left_offset)
5153 (window_box_right, window_box_right_offset): Undo previous change,
5154 by removing the "extern"s.
5155 * intervals.c (adjust_intervals_for_insertion)
5156 (adjust_intervals_for_deletion): Undo previous change,
5157 making these static again.
5158 (offset_intervals, temp_set_point_both, temp_set_point)
5159 (copy_intervals_to_string): No longer inline.
5160 * xdisp.c (window_text_bottom_y, window_box_width)
5161 (window_box_height, window_box_left_offset)
5162 (window_box_right_offset, window_box_left, window_box_right)
5163 (window_box): No longer inline.
5165 2011-11-08 Chong Yidong <cyd@gnu.org>
5167 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5168 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5169 Signal an error if not a live window.
5170 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5171 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5173 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5175 * lisp.h (syms_of_abbrev): Remove declaration.
5176 Reported by CHENG Gao <chenggao@royau.me>.
5178 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5180 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5181 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5182 of temacs in GUI mode.
5184 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5186 * window.h: Declare delete_all_child_windows instead of
5187 delete_all_subwindows.
5188 * window.c (Fwindow_nest, Fset_window_nest)
5189 (Fset_window_new_total, Fset_window_new_normal)
5190 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5191 (delete_all_subwindows): Rename to delete_all_child_windows.
5192 (Fdelete_other_windows_internal, Fset_window_configuration):
5193 Call delete_all_child_windows instead of delete_all_subwindows.
5194 * frame.c (delete_frame): Call delete_all_child_windows instead
5195 of delete_all_subwindows.
5197 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5199 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5200 This is also needed for porting to any host where GC_MARK_STACK is
5201 not GC_MAKE_GCPROS_NOOPS.
5202 (which_symbols): Use it.
5204 2011-11-07 Kenichi Handa <handa@m17n.org>
5206 * coding.c (coding_set_destination): Check coding->src_pos only
5207 when coding->src_object is a buffer (bug#9910).
5209 * process.c (send_process): Set the member src_multibyte of coding
5210 to 0 (bug#9911) when sending a unibyte text.
5212 * callproc.c (Fcall_process): Set the member src_multibyte of
5213 process_coding to 0 (bug#9912).
5215 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5217 * xmenu.c (cleanup_widget_value_tree): New function.
5218 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5219 calling free_menubar_widget_value_tree directly (Bug#9830).
5221 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5223 Fix some portability problems with 'inline'.
5224 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5225 (window_box_width, window_box_left, window_box_left_offset)
5226 (window_box_right, window_box_right_offset): Declare extern.
5227 Otherwise, these inline functions do not conform to C99 and
5228 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5229 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5230 * intervals.c (adjust_intervals_for_insertion)
5231 (adjust_intervals_for_deletion): Now extern, because otherwise the
5232 extern inline functions 'offset_intervals' couldn't refer to it.
5233 (static_offset_intervals): Remove.
5234 (offset_intervals): Rewrite using the old contents of
5235 static_offset_intervals. The old version didn't conform to C99
5236 because an extern inline function contained a reference to an
5237 identifier with static linkage.
5239 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5241 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5244 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5246 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5247 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5248 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5249 return Qleft_to_right.
5251 2011-11-06 Chong Yidong <cyd@gnu.org>
5253 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5254 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5255 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5256 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5257 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5258 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5259 (Fwindow_vscroll): Doc fix.
5260 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5261 argument, since it makes no sense to pass a live window and for
5262 consistency with window-child.
5264 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5266 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5269 2011-11-05 Jason Rumney <jasonr@gnu.org>
5271 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5272 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5274 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5275 bitwise arithmetic preventing use of unicode-sip and non-truetype
5278 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5280 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5283 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5284 initialization code to keep similarity to xfns.c after changes
5287 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5289 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5290 (unwind_create_frame): New function (Bug#9943).
5291 (Fx_create_frame): Restructure code to be more similar to the one in
5292 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5293 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5294 Move terminal->reference_count++ just before making the frame official
5297 * nsterm.m (x_free_frame_resources): New function.
5298 (x_destroy_window): Move code to x_free_frame_resources.
5300 * xfns.c (unwind_create_frame): Fix comment.
5301 (Fx_create_frame, x_create_tip_frame):
5302 Move terminal->reference_count++ just before making the frame
5303 official. Move initialization of image_cache_refcount and
5304 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5306 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5308 Support MSVC build with newer versions of Visual Studio.
5309 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5310 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5313 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5314 which are not supported by MSVC.
5315 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5316 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5318 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5320 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5322 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5324 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5326 Support MSVC build with newer versions of Visual Studio.
5327 * w32.c: Don't include w32api.h for MSVC.
5328 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5330 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5331 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5332 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5333 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5335 (alloca) [_MSC_VER]: Define to _alloca.
5337 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5339 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5341 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5343 * xdisp.c (note_mouse_highlight): If either of
5344 previous/next-single-property-change returns nil, treat that as
5345 the beginning or the end of the buffer. (Bug#9955)
5347 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5349 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5350 label is not null (Bug#9951).
5351 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5354 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5356 * window.c (Fwindow_body_size): Mention in the doc string that the
5357 return value is in frame's canonical units. (Bug#9949)
5359 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5361 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5363 * w32fns.c (unwind_create_frame): If needed, free the glyph
5364 matrices of the partially constructed frame. (Bug#9943)
5365 * xfns.c (unwind_create_frame): Likewise.
5367 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5369 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5370 Don't stop backward scan on the continuation glyph, even though
5371 its CHARPOS is positive.
5372 (mouse_face_from_buffer_pos, note_mouse_highlight):
5373 Rename cover_string to disp_string.
5375 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5377 * window.c (temp_output_buffer_show): Don't use
5378 Vtemp_buffer_show_specifiers.
5379 (Vtemp_buffer_show_specifiers): Remove unused variable.
5381 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5383 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5384 past the beginning of the current glyph matrix.
5386 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5388 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5389 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5390 HAVE_GTK3 (Bug#9869).
5392 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5393 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5395 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5397 * xterm.c: Declare x_handle_net_wm_state to return int.
5398 (handle_one_xevent): Check if we are iconified but don't have
5399 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5400 (get_current_wm_state): Return non-zero if not hidden,
5401 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5402 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5403 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5404 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5406 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5408 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5409 so that this new function doesn't get optimized away by a
5410 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5412 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5414 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5416 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5418 Fix the `xbytecode' command.
5419 * .gdbinit (xprintbytestr): New command.
5420 (xwhichsymbols): Rename from `which'; all callers changed.
5421 (xbytecode): Print the byte-code string as well.
5423 2011-10-29 Kim Storm <storm@cua.dk>
5425 * alloc.c (which_symbols): New function.
5427 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5429 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5432 2011-10-29 Glenn Morris <rgm@gnu.org>
5434 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5435 Not clear what it was for, and it causes various bugs. (Bug#9839)
5437 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5439 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5440 possible random value that matches one of those tested as
5441 condition to clear the mouse face.
5443 2011-10-28 Chong Yidong <cyd@gnu.org>
5445 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5447 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5449 * window.c (make_window): Initialize phys_cursor_on_p.
5451 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5453 * lisp.h (struct Lisp_Symbol): Update comments.
5455 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5457 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5459 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5461 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5462 <oslsachem@gmail.com> for helping to debug this.
5464 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5465 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5466 (g_b_init_get_glyph_outline_w): New static variables.
5467 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5468 (GetGlyphOutlineW_Proc): New typedefs.
5469 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5470 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5472 (w32font_open_internal, compute_metrics):
5473 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5474 instead of calling the "wide" APIs directly.
5476 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5478 * w32.h (syms_of_w32font): Add prototype.
5480 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5482 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5483 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5484 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5485 (Fmove_to_window_line): Doc fix.
5487 2011-10-27 Chong Yidong <cyd@gnu.org>
5489 * process.c (make_process): Set gnutls_state to NULL.
5491 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5492 non-NULL, regardless of GNUTLS_INITSTAGE.
5493 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5494 an error. Set process slots as soon as we allocate them.
5496 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5498 2011-10-27 Chong Yidong <cyd@gnu.org>
5500 * gnutls.c (emacs_gnutls_deinit): New function.
5501 Deallocate credentials structures as well as calling gnutls_deinit.
5502 (Fgnutls_deinit, Fgnutls_boot): Use it.
5504 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5505 (deactivate_process): Call emacs_gnutls_deinit.
5507 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5509 * image.c (x_create_x_image_and_pixmap):
5510 * w32.c (sys_rename, w32_delayed_load):
5511 * w32font.c (fill_in_logfont):
5512 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5514 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5516 * w32fns.c (w32_default_color_map): New function,
5517 extracted from Fw32_default_color_map.
5518 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5520 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5522 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5524 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5526 * keyboard.c (test_undefined): New function (bug#9751).
5527 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5529 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5531 * sysdep.c (init_sys_modes): Fix the check for the controlling
5532 terminal (Bug#6649).
5534 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5536 * dispextern.h (struct bidi_it): New member next_en_type.
5538 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5539 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5540 current character, check also for next_en_type being WEAK_EN.
5541 (bidi_resolve_weak): Don't enter the expensive loop if the current
5542 position is before next_en_pos. Record the bidi type of the first
5543 non-ET, non-BN character we find, in addition to its position.
5544 (bidi_level_of_next_char): Invalidate next_en_type when
5545 next_en_pos is over-stepped.
5547 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5549 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5550 * editfns.c: Rewrite current-time-zone so that it invokes
5551 the equivalent of (format-time-string "%Z") to get the time zone name.
5552 This fixes a bug when the time zone name contains characters that
5553 need converting from the system time locale to Emacs internal format.
5554 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5555 that patch fixed format-time-string to do the conversion, but
5556 I forgot to fix current-time-zone.
5557 (format_time_string): New function, containing most of
5558 what Fformat_time_string used to contain.
5559 (Fformat_time_string): Rewrite in terms of format_time_string.
5560 This doesn't change this function's behavior.
5561 (current-time-zone): Rewrite to use format_time_string.
5562 This fixes the bug reported by Michael Schierl in
5563 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5564 Jason Rumney's 2007-06-07 change worked around this bug, but
5566 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5568 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5570 * xdisp.c (start_display): If the character at POS is displayed
5571 via a display vector, reset IT->current.dpvec_index to zero.
5572 (try_window_reusing_current_matrix): If a line ends in a display
5573 vector or the next line starts in a display vector, continue
5574 redrawing the window even though the character position of
5575 start_row was reached.
5578 2011-10-18 Chong Yidong <cyd@gnu.org>
5580 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5581 with nobreak-char-display too.
5583 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5585 Fix part 3 of bug#9771.
5586 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5587 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5588 non-neutral characters if the current character is a paragraph
5589 separator (a.k.a. Newline). This avoids running the same
5590 expensive loop twice, once when we consume the preceding newline
5591 and the other time when the line actually needs to be displayed.
5592 Avoid the loop when we see neutrals on the base embedding level
5593 following a character whose directionality is the same as the
5594 paragraph's. This avoids running the expensive loop when a line
5595 ends in a long sequence of neutrals, like control characters.
5596 Add assertion against STRONG_AL type. Slightly rearrange code
5597 that determines the type of a neutral given the first non-neutral
5599 (bidi_level_of_next_char): Set next_en_pos to zero when
5600 invalidating its info.
5602 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5604 * xdisp.c (push_display_prop): Determine whether to record string
5605 or buffer position by IT->string, not by IT->method. Allow
5606 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5607 (move_it_vertically_backward): Don't look for character position
5608 immediately after the newline when in a continuation line.
5611 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5613 * window.c (coordinates_in_window): Rewrite and delabelize
5614 vertical border check. (Bug#5357) (Bug#9618)
5616 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5618 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5619 errors in XSetWindowBorder (bug#9310).
5621 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5623 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5624 avoid crash when xmalloc overrun checking is enabled.
5626 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5628 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5629 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5630 cursor motion with <left> and <right> arrow keys.
5632 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5633 some callers set that themselves.
5635 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5637 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5638 display string and the previous row comes from the same string and
5639 is empty. (Bug#9739) (Bug#9738)
5641 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5643 * doc.c (get_doc_string): Encode file name (bug#9735).
5645 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5647 * bidi.c (bidi_level_of_next_char):
5648 * xdisp.c (get_visually_first_element): Remove old incorrect
5649 comments regarding the Unicode Line Separator character.
5651 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5653 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5655 * alloc.c (Fgc_status): Do not access beyond zombies array
5656 boundary if nzombies > MAX_ZOMBIES.
5657 * alloc.c (dump_zombies): Add missing format specifier.
5659 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5661 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5662 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5664 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5665 Some packages use them to denote characters with modifiers.
5667 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5669 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5670 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5671 matching a pp-number. Rename parameter var to var1.
5673 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5675 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5677 2011-10-08 Glenn Morris <rgm@gnu.org>
5679 * callint.c (Fcall_interactively): Give a more explicit error for the
5680 'c' case with a non-character input. (Bug#8479)
5682 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5684 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5686 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5687 lines that are hscrolled on the left.
5689 * dispnew.c (buffer_posn_from_coords): Account for a possible
5690 presence of header-line. (Bug#4426)
5692 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5694 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5695 Don't advertise functionality which we discourage or doesn't work.
5697 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5699 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5700 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5701 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5702 this makes Emacs dump core during garbage collection on rare
5703 occasions. sizeof is obviously inferior to offsetof here, so
5704 stick with offsetof.
5705 (GC_POINTER_ALIGNMENT): New macro.
5706 (mark_memory): Omit 3rd (offset) arg; caller changed.
5707 Don't assume EMACS_INT alignment is the same as pointer alignment.
5709 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5711 * keyboard.c (read_key_sequence_remapped): New var.
5712 (read_key_sequence): Compute remapping in the right buffer.
5713 (command_loop_1): Use read_key_sequence's remapping directly.
5715 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5717 * dired.c (file_name_completion): Don't expand file name.
5718 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5719 before checking file name handler.
5721 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5722 they've been requested explicitly (bug#9591).
5724 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5726 * keymap.c (Fsingle_key_description): Use make_specified_string
5727 instead of build_string to build string from push_key_description.
5730 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5732 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5733 This fixes a Y2038 bug on 64-bit hosts.
5734 * buffer.c (reset_buffer):
5735 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5736 (Fclear_buffer_auto_save_failure):
5737 Use 0, not -1, to represent an unset failure time, since time_t
5738 might not be signed.
5740 Remove dependency on glibc malloc internals.
5741 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5742 Move back here from lisp.h, but with their new implementations.
5743 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5744 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5745 * charset.c (charset_table_init): New static var.
5746 (syms_of_charset): Use it instead of xmalloc. This removes a
5747 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5748 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5749 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5750 Move back to alloc.c.
5751 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5752 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5754 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5756 * nsterm.m (windowDidResize): Call x_set_window_size only when
5757 ns_in_resize is true. Otherwise set pixelwidth/height and
5758 call change_frame_size (Bug#9628).
5760 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5762 Port --enable-checking=all to Fedora 14 x86-64.
5763 * charset.c (syms_of_charset): Also account for glibc malloc's
5764 internal overhead when calculating the initial malloc maximum.
5766 Port --enable-checking=all to Fedora 14 x86.
5767 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5769 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5770 (overrun_check_realloc, overrun_check_free):
5771 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5772 That way, xmalloc returns a properly-aligned pointer even if
5773 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5774 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5775 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5776 into account when calculating the initial malloc maximum.
5777 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5778 Move here from alloc.c, so that charset.c can use it too.
5779 Properly align; the old code wasn't right for common 32-bit hosts
5780 when configured with --enable-checking=all.
5781 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5782 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5784 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5786 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5789 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5791 * xdisp.c (compute_display_string_end): If there's no display
5792 string at CHARPOS, return -1.
5794 * bidi.c (bidi_fetch_char): When compute_display_string_end
5795 returns a negative value, treat the character as a normal
5796 character not covered by a display string. (Bug#9624)
5798 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5800 * lread.c (Fread_from_string): Fix typo in docstring.
5802 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5804 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5805 newline, reseat the iterator instead of bidi-iterating there one
5806 character at a time. (Bug#9610)
5807 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5808 TO_CHARPOS if the bidi iterator is at base embedding level.
5810 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5812 * lread.c (readevalloop): Use correct code for NBSP.
5813 (read1): Likewise. (Bug#9608)
5815 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5817 * dbusbind.c (Fdbus_register_signal): When service is not
5818 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5820 2011-09-25 Glenn Morris <rgm@gnu.org>
5822 * buffer.c (truncate-lines): Doc fix.
5824 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5826 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5827 (Fset_window_next_buffers): Doc fix.
5829 2011-09-24 Glenn Morris <rgm@gnu.org>
5831 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5833 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5835 Fix minor problems found by static checking.
5836 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5837 * indent.c (Fvertical_motion): Fix == vs = typo.
5839 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5841 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5842 Default value is now t. Doc fix.
5844 * indent.c (Fvertical_motion): Compute and apply the overshoot
5845 logic when moving up, not only when moving down. Fix the
5846 confusing name and values of the it_overshoot_expected variable;
5847 logic changes accordingly. (Bug#9254) (Bug#9549)
5849 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5850 CHARPOS is covered by a display string which includes newlines.
5851 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5852 is covered by a display string with embedded newlines.
5854 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5856 * dbusbind.c (Fdbus_register_signal): Add match rule to
5857 Vdbus_registered_objects_table. (Bug#9581)
5858 (Fdbus_register_method, Vdbus_registered_objects_table):
5861 2011-09-24 Jim Meyering <meyering@redhat.com>
5863 do not ignore write error for any output size
5864 The previous change was incomplete.
5865 While it makes emacs --batch detect the vast majority of stdout
5866 write failures, errors were still ignored whenever the output size is
5867 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5868 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5869 && echo FAIL: ignored write error
5870 FAIL: ignored write error
5871 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5872 && echo FAIL: ignored write error
5873 FAIL: ignored write error
5874 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5876 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5878 * emacs.c (Fkill_emacs): In noninteractive mode exit
5879 non-successfully if a write error occurred on stdout. (Bug#9574)
5881 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5883 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5886 * dispextern.h (struct it): Update the comment documenting what
5889 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5891 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5892 a display string, extend search for cursor position to end of row.
5893 (find_row_edges): If the row ends in a newline from a display
5894 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5895 Handle the case of a display string with multiple newlines.
5896 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5897 non-empty line. Fixes confusing cursor motion with arrow keys at
5898 the beginning of a line that starts with whitespace.
5900 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5902 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5905 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5907 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5910 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5912 * xdisp.c (display_line): Record maximum and minimum buffer
5913 positions even if no glyphs were produced (e.g., by a zero-width
5914 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5915 buffer positions that will be removed from the glyph row because
5917 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5918 column is beyond frame width: don't subtract 1 "pixel" when
5919 computing width of the stretch.
5920 (reseat_at_next_visible_line_start): Undo the change made on
5921 2011-09-17 that saved paragraph information and restored it after
5922 the call to `reseat'. (Bug#9545)
5924 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5926 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5927 and turn window cursor on if cleared (Bug#9415).
5929 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5931 * search.c (boyer_moore): Take unibyte characters from pattern
5932 literally. (Bug#9458)
5934 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5936 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5938 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5940 Fix minor problem found by static checking.
5941 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5942 initialized, to pacify gcc -Wuninitialized.
5944 * fileio.c: Report proper errno when syscall falls.
5945 (Finsert_file_contents): Save and restore errno,
5946 so that report_file_error outputs the correct diagnostic.
5947 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5949 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5951 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5953 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5955 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5956 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5958 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5960 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5961 about the current paragraph and restore it after the call to reseat.
5963 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5964 (bidi_find_paragraph_start): Search back for paragraph beginning
5965 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5966 (bidi_move_to_visually_next): Only trigger paragraph-related
5967 computations when the last character is a newline or at EOB, not
5968 just any NEUTRAL_B. (Bug#9470)
5970 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5971 truncated lines if point is covered by a display string. (Bug#9524)
5973 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5975 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5976 (cons_to_x_long): New function.
5977 (lisp_data_to_selection_data): Use it. Correct the test for
5978 short-versus-long data; it was negated. Break out of vector
5979 loop, for efficiency, when a long datum is discovered.
5981 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5983 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5985 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5987 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5988 GCC PR/17406) by declaring this function with external scope.
5990 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5992 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5993 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5995 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5997 * editfns.c (Fformat): Correctly handle text properties on "%%".
5999 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6001 * xterm.c (x_draw_composite_glyph_string_foreground):
6002 * w32term.c (x_draw_composite_glyph_string_foreground):
6003 * term.c (encode_terminal_code):
6004 * composite.c (composition_update_it, get_composition_id):
6005 * xdisp.c (get_next_display_element)
6006 (fill_composite_glyph_string): Add comments about special meaning
6007 of TAB characters in a composition.
6009 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6011 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6012 This occurs when processing a multibyte format.
6013 Problem reported by Wolfgang Jenker.
6015 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6017 * xdisp.c (try_cursor_movement): Only check for exact match if
6018 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6020 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6022 Remove unused external symbols.
6023 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6024 * xdisp.c (calc_pixel_width_or_height): Now static.
6025 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6026 * indent.c (check_display_width):
6027 * w32term.c: Fix comment to match code.
6028 * xterm.c, xterm.h (x_catching_errors): Remove.
6030 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6032 * xselect.c: Use signed conversions more consistently (Bug#9498).
6033 (selection_data_to_lisp_data): Assume incoming selection data are
6034 signed integers, not unsigned. This is to be consistent with
6035 outgoing selection data, which was modified to use signed integers
6036 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6037 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6038 expects long, not unsigned long.
6040 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6042 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6043 computation of loop end. Reported by Johan Bockgård
6046 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6048 * frame.c (Fother_visible_frames_p): Function deleted.
6050 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6052 * indent.c (compute_motion): Process display vector front to back
6053 rather than the other way around. (Bug#2496)
6055 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6057 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6059 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6061 * minibuf.c (Fread_from_minibuffer): Doc fix.
6063 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6065 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6066 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6068 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6070 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6071 value for non-existent files.
6073 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6075 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6076 set its "size" to -1. This will set the modtime_size field of
6077 the corresponding buffer to -1, which is what
6078 verify-visited-file-modtime expects for files that do not exist.
6081 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6083 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6085 * lisp.h: ... from here. push_key_description is no longer
6086 defined in keyboard.c, so its declaration should not be in
6087 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6088 logically belongs with push_key_description.
6090 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6092 * buffer.h: Include <sys/types.h> instead of <time.h>.
6093 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6094 Problem reported by Herbert J. Skuhra.
6096 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6098 * xml.c (parse_region): Make the parsing work for
6099 non-comment-starting XML files again (bug#9144).
6101 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6103 * image.c (gif_load): Fix calculation of bottom and right corner.
6106 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6108 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6109 redisplay in small windows.
6111 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6113 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6115 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6117 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6118 Operate on live windows only.
6120 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6122 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6124 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6126 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6127 only under bidi iteration.
6129 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6131 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6133 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6135 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6136 Without this fix, the command to link temacs failed due to an
6137 undefined symbol __builtin_isnan. This is because
6138 /usr/include/iso/math_c99.h #defines isnan(x) to
6139 __builtin_isnan(x), but the bundled gcc, which identifies itself
6140 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6142 * floatfns.c (isnan): #undef, and then #define to a clone of
6144 (Fisnan): Always define, since it's always available now.
6145 (syms_of_floatfns): Always define isnan at the Lisp level.
6147 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6149 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6151 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6153 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6154 The previous code assumed that file offsets (off_t values) fit in
6155 EMACS_INT variables, which is not true on typical 32-bit hosts.
6156 The code messed up by falsely reporting buffer overflow in cases
6157 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6158 when "big" contains more than 2**29 bytes, even though this
6159 inserts just one byte and does not overflow the buffer.
6160 (Finsert_file_contents): Store file offsets as off_t
6161 values, not as EMACS_INT values. Check for overflow when
6162 converting between EMACS_INT and off_t. When checking for
6163 buffer overflow or for overlap, take the offsets into account.
6164 Don't use EMACS_INT for small values where int suffices.
6165 When checking for overlap, fix a typo: ZV was used where
6166 ZV_BYTE was intended.
6167 (Fwrite_region): Don't assume off_t fits into 'long'.
6168 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6170 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6172 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6174 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6176 sprintf-related integer and memory overflow issues (Bug#9412).
6178 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6179 (esprintf, exprintf, evxprintf): New functions.
6180 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6181 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6182 (modify_event_symbol): Do not assume that the length of
6183 name_alist_or_stem is safe to alloca and fits in int.
6184 (Fexecute_extended_command): Likewise for function name and binding.
6185 (Frecursion_depth): Wrap around reliably on integer overflow.
6186 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6187 since some callers pass EMACS_INT values.
6188 (Fsingle_key_description): Don't crash if symbol name contains more
6189 than MAX_ALLOCA bytes.
6190 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6191 (get_minibuffer): Arg is now EMACS_INT, not int.
6192 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6193 (esprintf, exprintf, evxprintf): New decls.
6194 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6196 * dbusbind.c (signature_cat): New function.
6197 (xd_signature, Fdbus_register_signal):
6198 Do not overrun buffer; instead, report string overflow.
6200 * dispnew.c (add_window_display_history): Don't overrun buffer.
6201 Truncate instead; this is OK since it's just a log.
6203 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6204 even if the time zone offset is outlandishly large.
6205 Don't mishandle offset == INT_MIN.
6207 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6208 when creating daemon; the previous buffer-overflow check was incorrect.
6210 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6211 which has the guts of the old verror function.
6213 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6214 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6216 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6217 (font_unparse_xlfd): Don't blindly alloca long strings.
6218 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6219 fits in int, when using sprintf. Use single snprintf to count
6220 length of string rather than counting it via multiple sprintfs;
6221 that's simpler and more reliable.
6222 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6223 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6224 sprintf, in case result does not fit in int.
6226 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6227 (fontset_from_font): Print it.
6229 * frame.c (tty_frame_count): Now printmax_t, not int.
6230 (make_terminal_frame, set_term_frame_name): Print it.
6231 (x_report_frame_params): In X, window IDs are unsigned long,
6232 not signed long, so print them as unsigned.
6233 (validate_x_resource_name): Check for implausibly long names,
6234 and don't assume name length fits in 'int'.
6235 (x_get_resource_string): Don't blindly alloca invocation name;
6236 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6239 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6240 (xg_check_special_colors, xg_set_geometry):
6241 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6243 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6244 Use esprintf, not sprintf, in case result does not fit in int.
6246 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6247 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6248 it as a large positive number.
6249 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6250 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6252 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6253 in case result does not fit in int.
6255 * print.c (float_to_string): Detect width overflow more reliably.
6256 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6257 buffer overrun. Don't assume list length fits in 'int'. Treat
6258 print length of 0 as 0, not as infinity; to be consistent with other
6259 uses of print length in this function. Don't overflow print length
6260 index. Don't assume hash table size fits in 'long', or that
6261 vectorlike size fits in 'unsigned long'.
6263 * process.c (make_process): Use printmax_t, not int, to format
6264 process-name gensyms.
6266 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6268 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6269 to avoid potential buffer overrun.
6271 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6272 if X resource line is longer than 512 bytes.
6274 * xfns.c (x_window): Make sprintf buffer a bit bigger
6275 to avoid potential buffer overrun.
6277 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6279 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6281 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6283 Integer overflow fixes for scrolling, etc.
6284 Without these, Emacs silently mishandles large integers sometimes.
6285 For example, "C-u 4294967297 M-x recenter" was treated as if
6286 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6288 * xdisp.c (try_window_id): Check Emacs fixnum range before
6289 converting to 'int'.
6291 * window.c (window_scroll_line_based, Frecenter):
6292 Check that an Emacs fixnum is in range before assigning it to 'int'.
6293 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6294 values converted from Emacs fixnums.
6295 (Frecenter): Don't wrap around a line count if it is out of 'int'
6296 range; instead, treat it as an extreme value.
6297 (Fset_window_configuration, compare_window_configurations):
6298 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6300 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6301 that can exceed INT_MAX. Check that EMACS_INT value is in range
6302 before assigning it to the (possibly-narrower) index.
6303 (match_limit): Don't assume that a fixnum can fit in 'int'.
6305 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6308 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6309 (Fvertical_motion): Don't wrap around LINES values that don't fit
6310 in 'int'. Instead, treat them as extreme values. This is good
6311 enough for windows, which can't have more than INT_MAX lines anyway.
6313 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6315 * Require libxml/parser.h to avoid compilation warning.
6317 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6319 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6320 since this reportedly can destroy thread storage.
6322 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6324 * syntax.c (find_defun_start): Update all cache variables if
6325 exiting early (Bug#9401).
6327 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6329 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6331 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6332 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6333 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6335 * term.c (tty_append_glyph): New function.
6336 (produce_stretch_glyph): Static function and its prototype deleted.
6338 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6341 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6343 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6344 when checking :margin (Bug#9390).
6345 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6346 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6347 so that the name doesn't mislead. All uses changed.
6349 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6351 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6354 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6356 * xdisp.c (move_it_to): Don't bail out early when reaching
6357 position beyond to_charpos, if we are scanning backwards.
6358 (move_it_vertically_backward): When DY == 0, make sure we get to
6359 the first character in the line after the newline.
6361 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6363 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6364 (ccl_driver): Do not generate an out-of-range pointer.
6365 (Fccl_execute_on_string): Remove unnecessary check for
6366 integer overflow, noted by Stefan Monnier in
6367 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6368 Remove a FIXME that didn't need fixing.
6369 Simplify the newly-introduced buffer reallocation code.
6371 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6373 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6375 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6377 Integer and memory overflow issues (Bug#9196).
6379 * doc.c (get_doc_string): Rework so that
6380 get_doc_string_buffer_size is the actual buffer size, rather than
6381 being 1 less than the actual buffer size; this makes xpalloc more
6384 * image.c (x_allocate_bitmap_record, cache_image):
6385 * xselect.c (Fx_register_dnd_atom):
6386 Simplify previous changes by using xpalloc.
6388 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6389 since either will do and ptrdiff_t is convenient with xpalloc.
6391 * charset.c (charset_table_size)
6392 (struct charset_sort_data.priority): Now ptrdiff_t.
6393 (charset_compare): Don't overflow if priorities differ greatly.
6394 (Fsort_charsets): Don't assume list length fits in int.
6395 Check for size-calculation overflow when allocating sort data.
6396 (syms_of_charset): Allocate an initial charset table that is
6397 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6399 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6401 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6402 The actual value is always <= INT_MAX, and leaving it unsigned made
6403 overflow checking harder.
6405 * dispextern.h (struct glyph_matrix.rows_allocated)
6406 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6407 with xpalloc. The values are still always <= INT_MAX.
6409 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6411 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6412 (SAFE_NALLOCA): New macro.
6414 * region-cache.c (struct boundary.pos, find_cache_boundary)
6415 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6416 (set_cache_region, invalidate_region_cache)
6417 (revalidate_region_cache, know_region_cache, region_cache_forward)
6418 (region_cache_backward, pp_cache):
6419 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6420 so that ptrdiff_t * can be passed to xpalloc.
6421 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6422 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6423 (pp_cache): Don't assume cache_len fits in int.
6424 * region-cache.h: Adjust extern decls to match.
6426 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6427 EMACS_INT, since either will do, for xpalloc.
6429 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6430 (xnmalloc, xnrealloc, xpalloc): New functions.
6432 * bidi.c (bidi_shelve_header_size): New constant.
6433 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6434 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6436 * bidi.c (bidi_cache_shrink):
6437 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6439 Don't update size of array until after memory allocation succeeds,
6440 because xmalloc/xrealloc may not return.
6441 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6442 now that we have proper integer overflow checking.
6443 (record_overlay_string, overlay_strings): Catch overflows when
6444 calculating size of overlay_str_buf.
6446 * callproc.c (Fcall_process): Check for size overflow when
6447 calculating size of args2.
6448 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6449 Normally we prefer signed values, but sticking with ptrdiff_t would
6450 require adding more-complicated checks.
6452 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6453 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6454 Redo buffer-overflow calculations to avoid integer overflow.
6455 Add a FIXME comment where memory seems to be over-allocated.
6457 * character.c (Fstring): Check for size-calculation overflow.
6459 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6460 unnecessary integer overflow. Check for size overflow.
6461 (encode_coding_object): Don't update size until xmalloc succeeds.
6463 * composite.c (get_composition_id): Check for overflow in glyph
6464 length calculations.
6466 Integer and memory overflow fixes for display code.
6467 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6468 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6469 (scrolling_window): Check for overflow in size calculations.
6470 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6471 Don't assume glyph table len fits in int.
6472 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6473 (row_table_size): Now ptrdiff_t, not int.
6474 (scrolling_window): Avoid overflow in size calculations.
6475 Don't update size until allocation succeeds.
6476 * fns.c (concat): Check for overflow in size calculations.
6477 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6478 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6479 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6481 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6482 (get_doc_string): Check for size calculation overflow.
6483 Don't update size until allocation succeeds.
6484 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6485 EMACS_INT, where ptrdiff_t will do.
6486 (Fsubstitute_command_keys): Check for string overflow.
6488 * editfns.c (set_time_zone_rule): Don't assume environment length
6490 (message_length): Now ptrdiff_t, not int.
6491 (Fmessage_box): Don't update size until allocation succeeds.
6492 Don't assume message length fits in int.
6493 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6495 * emacs.c (main): Do not reallocate argv, since there is a null at
6496 the end that can be overwritten, and this way there's no need to
6497 worry about size-calculation overflow.
6498 (sort_args): Check for size-calculation overflow.
6500 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6502 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6504 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6505 (x_set_scroll_bar_width, x_figure_window_size):
6506 Check for integer overflow.
6507 (x_set_alpha): Do not assume XINT fits in int.
6509 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6510 This is for the members text_lines, text_cols, total_lines, total_cols,
6511 where the system imposes an 'int' limit.
6513 * fringe.c (Fdefine_fringe_bitmap):
6514 Don't update size until alloc works.
6516 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6517 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6519 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6520 Check for size-calculation overflow.
6521 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6522 do, as we prefer signed integers.
6523 (id_to_widget.max_size, id_to_widget.used)
6524 (xg_store_widget_in_map, xg_remove_widget_from_map)
6525 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6526 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6527 Use and return ptrdiff_t, not int.
6528 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6529 * gtkutil.h: Change prototypes to match the above.
6531 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6532 are duplicate now that they've been promoted to lisp.h.
6533 (x_allocate_bitmap_record, x_alloc_image_color)
6534 (make_image_cache, cache_image, xpm_load):
6535 Don't update size until alloc is done.
6536 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6538 Check for size calculation overflow.
6539 (ct_colors_allocated_max): New constant.
6540 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6543 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6544 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6545 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6546 Use ptrdiff_t, not int, to count maps.
6547 (read_char_minibuf_menu_prompt): Check for overflow in size
6548 calculations. Don't update size until allocation succeeds.
6549 Redo calculations to avoid overflow.
6550 * keyboard.h: Change prototypes to match the above.
6552 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6554 (current_minor_maps): Check for size calculation overflow.
6555 * keymap.h: Change prototypes to match the above.
6557 * lread.c (read1, init_obarray): Don't update size until alloc done.
6559 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6560 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6562 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6563 Now ptrdiff_t, not int.
6564 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6565 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6567 * process.c (Fnetwork_interface_list): Check for overflow
6568 in size calculation.
6570 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6572 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6573 overflow. Don't bother calling xmalloc when xrealloc will do.
6575 * search.c (Freplace_match): Check for size calculation overflow.
6576 (Fset_match_data): Don't assume list lengths fit in 'int'.
6578 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6579 for command line length. Do not attempt to address one before the
6580 beginning of an array, as that's not portable.
6582 * term.c (max_frame_lines): Remove; unused.
6583 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6585 (encode_terminal_code, calculate_costs): Check for size
6586 calculation overflow.
6587 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6588 table lengths and related sizes. Don't update size until alloc
6589 done. Redo calculations to avoid overflow.
6590 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6592 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6593 subtracting pointers.
6594 (gobble_line): Check for overflow more carefully. Don't update size
6597 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6598 Don't update size until alloc done.
6599 Redo size calculations to avoid overflow.
6600 Check for size calculation overflow.
6601 (main) [DEBUG]: Fix typo in invoking tparam1.
6603 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6604 Use ptrdiff_t, not int, for sizes.
6605 (store_mode_line_noprop_char): Don't update size until alloc done.
6607 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6608 Use ptrdiff_t, not int, for sizes.
6609 (Finternal_make_lisp_face, cache_face):
6610 Check for size calculation overflow.
6611 (cache_face): Treat size calculation overflows as if they were
6612 memory exhaustion (the usual treatment), rather than aborting.
6614 * xfns.c (x_encode_text, x_set_name_internal)
6615 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6616 sizes, since they can exceed INT_MAX in size. Check for size
6617 calculation overflow.
6619 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6620 (xg_select): Check for size calculation overflow.
6621 Don't update size until alloc done.
6623 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6624 as sprintf is limited to int lengths.
6626 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6627 (X_LONG_MIN): New macros.
6628 Use them to make the following changes clearer.
6629 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6630 This change doesn't affect the value now, but it may help remind
6631 future maintainers not to raise the value too much later.
6632 (SELECTION_QUANTUM): Remove, replacing with ...
6633 (selection_quantum): ... new function, which avoids overflow.
6635 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6636 assumption that selection length fits in 'int'.
6637 (x_reply_selection_request, x_handle_selection_request)
6638 (x_get_window_property, receive_incremental_selection)
6639 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6640 (lisp_data_to_selection_data, clean_local_selection_data):
6641 Use ptrdiff_t, not int, to record length of selection.
6642 (x_reply_selection_request, x_get_window_property)
6643 (receive_incremental_selection, x_property_data_to_lisp):
6644 Redo calculations to avoid overflow.
6645 (x_reply_selection_request): When sending hint, ceiling it at
6646 X_LONG_MAX rather than relying on wraparound overflow to send
6648 (x_get_window_property, receive_incremental_selection)
6649 (lisp_data_to_selection_data, x_property_data_to_lisp):
6650 Check for size-calculation overflow.
6651 (x_get_window_property, receive_incremental_selection)
6652 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6653 Don't store size until memory allocation succeeds.
6654 (x_get_window_property): Plug memory leak on memory exhaustion.
6655 Don't double-block input; malloc is safe here. Don't assume 2**34
6656 - 4 fits in unsigned long. Add an xassert to check
6657 XGetWindowProperty overflow. Be more careful about overflow
6658 calculations, and distinguish size from memory overflow better.
6659 (receive_incremental_selection): When tracing, don't assume
6660 unsigned int is less than INT_MAX.
6661 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6662 harmful) conversions of unsigned short to int.
6663 (lisp_data_to_selection_data): Don't assume that integers
6664 in the range -65535 through -1 fit in an X unsigned short.
6665 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6666 result parameters unless successful. Rely on cons_to_unsigned
6667 to report problems with elements; the old code wasn't right anyway.
6668 (x_check_property_data): Check for int overflow; we cannot use
6669 a wider type due to X limits.
6670 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6672 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6674 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6675 (x_term_init): Check for size calculation overflow.
6676 (x_color_cells): Don't store size until memory allocation succeeds.
6677 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6678 Don't assume alloca size is less than MAX_ALLOCA.
6679 (x_term_init): Don't assume length fits in int (sprintf is limited
6682 Use ptrdiff_t for composition IDs.
6683 * character.c (lisp_string_width):
6684 * composite.c (composition_table_size, n_compositions)
6685 (get_composition_id, composition_gstring_from_id):
6686 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6687 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6688 * window.c (Frecenter):
6689 Use ptrdiff_t, not int, for composition IDs.
6690 * composite.c (get_composition_id): Check for integer overflow.
6691 * composite.h: Adjust prototypes to match the above changes.
6693 Use ptrdiff_t for hash table indexes.
6694 * category.c (hash_get_category_set):
6695 * ccl.c (ccl_driver):
6696 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6697 * coding.c (coding_system_charset_list, detect_coding_system):
6698 * coding.h (struct coding_system.id):
6699 * composite.c (get_composition_id, gstring_lookup_cache):
6700 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6701 * image.c (xpm_get_color_table_h):
6702 * lisp.h (hash_lookup, hash_put):
6703 * minibuf.c (Ftest_completion):
6704 Use ptrdiff_t for hash table indexes, not int (which is too
6705 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6706 32-bit --with-wide-int hosts).
6708 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6709 Add a FIXME comment about memory leaks.
6710 (syms_of_charset): Don't assume xmalloc returns.
6712 Don't assume that stated character widths fit in int.
6713 * character.c (Fchar_width, c_string_width, lisp_string_width):
6714 * character.h (CHAR_WIDTH):
6715 * indent.c (MULTIBYTE_BYTES_WIDTH):
6716 Use sanitize_char_width to avoid undefined and/or bad behavior
6717 with outlandish widths.
6718 * character.h (sanitize_tab_width): Rename from sanitize_width,
6719 now that we have two such functions. All uses changed.
6720 (sanitize_char_width): New inline function.
6722 Don't assume that tab-width fits in int.
6723 * character.h (sanitize_width): New inline function.
6724 (SANE_TAB_WIDTH): New macro.
6725 (ASCII_CHAR_WIDTH): Use it.
6726 * indent.c (sane_tab_width): Remove. All uses replaced by
6727 SANE_TAB_WIDTH (current_buffer).
6728 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6730 * fileio.c: Integer overflow issues with file modes.
6731 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6733 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6734 Remove unreachable code.
6735 (read_hex, load_charset_map_from_file): Check for integer overflow.
6737 * xterm.c: Don't go over XClientMessageEvent limit.
6738 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6739 (x_send_scroll_bar_event): Likewise. Check that the size does not
6740 exceed limits imposed by XClientMessageEvent, as well as the usual
6741 ptrdiff_t and size_t limits.
6743 * keyboard.c: Overflow, signedness and related fixes.
6744 (make_lispy_movement): Use same integer type in forward decl
6745 that is used in the definition.
6746 (read_key_sequence, keyremap_step):
6747 Change bufsize argument back to int, undoing my 2011-03-30 change.
6748 We prefer signed types, and int is wide enough here.
6749 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6750 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6751 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6752 length, not size_t. Use ptrdiff_t for index, not int.
6753 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6754 possibility of integer overflow.
6756 Overflow, signedness and related fixes for images.
6758 * dispextern.h (struct it.stack[0].u.image.image_id)
6759 (struct_it.image_id, struct image.id, struct image_cache.size)
6760 (struct image_cache.used, struct image_cache.ref_count):
6761 * gtkutil.c (update_frame_tool_bar):
6762 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6763 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6764 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6765 * nsmenu.m (update_frame_tool_bar):
6766 * xdisp.c (calc_pixel_width_or_height):
6767 * xfns.c (image_cache_refcount):
6768 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6769 on typical 64-bit hosts.
6771 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6772 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6773 Omit unnecessary casts to int.
6774 (parse_image_spec): Check that integers fall into 'int' range
6775 when the callers expect that.
6776 (image_ascent): Redo ascent calculation to avoid int overflow.
6777 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6778 (lookup_image): Remove unnecessary tests.
6779 (xbm_image_p): Locals are now of int, not EMACS_INT,
6780 since parse_image_check makes sure they fit into int.
6781 (png_load, gif_load, svg_load_image):
6782 Prefer int to unsigned where either will do.
6783 (tiff_handler): New function, combining the cores of the
6784 old tiff_error_handler and tiff_warning_handler.
6785 This function is rewritten to use vsnprintf and thereby avoid
6786 stack buffer overflows. It uses only the features of vsnprintf
6787 that are common to both POSIX and native Microsoft.
6788 (tiff_error_handler, tiff_warning_handler): Use it.
6789 (tiff_load, gif_load, imagemagick_load_image):
6790 Don't assume :index value fits in 'int'.
6791 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6792 (imagemagick_load_image): Check that crop parameters fit into
6793 the integer types that MagickCropImage accepts. Don't assume
6794 Vimagemagick_render_type has a nonnegative value. Don't assume
6795 size_t fits in 'long'.
6796 (gs_load): Use printmax_t to print the widest integers possible.
6797 Check for integer overflow when computing image height and width.
6799 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6801 * xdisp.c (redisplay_window): Don't force window start if point
6802 will be invisible in the resulting window. (Bug#9324)
6804 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6806 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6807 the display spec is of the form `(space ...)'.
6808 (handle_display_spec): Return the value returned by
6809 handle_single_display_spec, not just 1 or zero.
6810 (handle_single_display_spec): If the display spec is of the form
6811 `(space ...)', and specifies display in the text area, return 2
6813 (try_cursor_movement): Check for the need to scroll more
6814 accurately, and prefer exact match for point under bidi.
6815 Don't advance `row' beyond the last row of the window.
6817 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6818 into disp_prop; all users changed.
6820 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6821 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6822 for the text covered by the display property.
6824 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6826 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6827 Change return value to nil.
6828 (Frecord_buffer): Delete unused function.
6830 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6832 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6833 buffers, return left-to-right.
6834 (set_cursor_from_row): Consider candidate row a win if its glyph
6835 represents a newline and point is on that newline. Fixes cursor
6836 positioning on the newline at EOL of R2L text within L2R
6837 paragraph, and vice versa.
6838 (try_cursor_movement): Check continued rows, in addition to
6839 continuation rows. Fixes unwarranted scroll when point enters a
6840 continued line of R2L text within an L2R paragraph, or vice versa.
6841 (cursor_row_p): Consider the case of point being equal to
6842 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6843 from the end of a short line to the beginning of a continued line
6844 of R2L text within L2R paragraph.
6845 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6846 composed characters.
6848 * bidi.c (bidi_check_type): Use xassert.
6849 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6852 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6854 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6857 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6859 * nsfont.m (ns_otf_to_script): Fix typo.
6861 2011-08-22 Kenichi Handa <handa@m17n.org>
6863 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6864 extra slot even if the purpose is char-code-property-table.
6866 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6868 * xdisp.c (redisplay_window): When computing centering_position,
6869 account for the height of the header line. (Bug#8874)
6871 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6872 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6873 candidate is selected by the mouse, and that candidate has a
6874 composed character under the mouse.
6876 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6877 coordinates reported by pos-visible-in-window-p for a composed
6878 character in column zero.
6880 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6882 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6884 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6886 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6887 consider it a hit if to_charpos is anywhere in the range of the
6888 composed buffer positions.
6890 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6892 * image.c (gif_load): Don't assume that each subimage has the same
6893 dimensions as the base image. Handle disposal method that is
6894 "undefined" by the gif spec (Bug#9335).
6896 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6898 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6899 (Fcondition_case): Document `debug' symbol in error handler.
6901 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6903 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6904 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6905 from an Org mode buffer to a Speedbar frame.
6907 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6908 a composition, take its buffer position from IT->cmp_it.charpos.
6909 Fixes cursor positioning at the beginning of a line that begins
6910 with a composed character.
6912 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6914 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6915 character bidirectional type, use STRONG_L instead. Fixes crashes
6916 in a buffer produced by `describe-categories'.
6918 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6919 members before the level stack, so they would be saved and
6920 restored when copying iterator state. Fixes incorrect reordering
6921 around TABs covered by display properties.
6923 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6925 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6927 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6929 * eval.c (internal_condition_case, internal_condition_case_1)
6930 (internal_condition_case_2, internal_condition_case_n):
6931 Remove unnecessary aborts (Bug#9081).
6933 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6935 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6936 has no `load' handler, try opening the file locally. (Bug#9311)
6938 2011-08-16 Ken Brown <kbrown@cornell.edu>
6940 * gmalloc.c: Expand comment.
6942 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6944 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6945 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6947 2011-08-16 Ken Brown <kbrown@cornell.edu>
6949 Fix memory allocation problems in Cygwin build (Bug#9273).
6951 * unexcw.c ( __malloc_initialized): Declare external variable.
6952 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6954 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6956 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6958 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6960 [CYGWIN] (special_realloc): New function.
6961 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6962 requests to realloc storage in the static heap.
6964 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6966 * bidi.c (bidi_initialize): Remove unused local.
6968 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6971 * biditype.h: Remove file.
6972 * makefile.w32-in ($(BLD)/bidi.$(O)):
6973 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6975 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6977 * chartab.c: Improve commentary for the uniprop_table API.
6979 * bidi.c (bidi_paragraph_init): Support zero value of
6980 bidi_ignore_explicit_marks_for_paragraph_level.
6981 (bidi_initialize): Use uniprop_table instead of including
6982 biditype.h and bidimirror.h.
6984 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6985 coordinates of the iterator when restoring from ppos_it.
6988 2011-08-14 Kenichi Handa <handa@m17n.org>
6990 * process.c (create_process): Call setup_process_coding_systems
6991 after the pid of the process is set to -1 (Bug#8162).
6993 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6995 * xdisp.c (move_it_in_display_line_to): Don't invoke
6996 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6997 ppos_it. Fixes vertical cursor motion when line beginning is
6998 covered by an image. (Bug#9296)
7000 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7002 * nsterm.h (ns_run_ascript): Declare.
7003 (NSAPP_DATA2_RUNASSCRIPT): Define.
7005 * nsfns.m (as_script, as_result, as_status): New static variables.
7006 (ns_run_ascript): New function.
7007 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7008 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7009 the event loop. Get status from as_status (Bug#7276).
7011 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7012 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7013 the event loop (Bug#7276).
7015 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7017 * gnutls.c (QCgnutls_bootprop_priority)
7018 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7019 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7020 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7021 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7022 (QCgnutls_bootprop_verify_hostname_error)
7023 (QCgnutls_bootprop_callbacks_verify): Rename from
7024 Qgnutls_bootprop_..., all uses changed.
7026 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7029 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7031 * xfaces.c (Qframe_set_background_mode): Now static.
7032 * dispextern.h (Qframe_set_background_mode): Remove decl.
7034 * process.c (Fnetwork_interface_info): Declare local only if needed.
7036 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7038 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7039 (Fnetwork_interface_list): Allocate in increments of bytes instead
7040 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7041 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7043 (struct ifflag_def): notrailers is smart on OSX.
7044 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7045 Get hardware address with getifaddrs if available.
7047 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7049 * xdisp.c (iterate_out_of_display_property): xassert that
7050 IT->position is set to within IT->object's boundaries. Break from
7051 the loop as soon as EOB is reached; avoids infloops in redisplay
7052 when IT->position is set up wrongly due to some bug.
7053 Set IT->current to match the bidi iterator unconditionally.
7054 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7055 entry. Force push_it to save on the stack the current
7056 buffer/string position, to be restored by pop_it. Fix flags in
7057 the iterator structure wrt the object coming from a display
7058 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7059 properties. (Bug#9284)
7061 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7063 * fontset.c (fontset_get_font_group): Add proper type checks.
7066 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7068 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7069 and LC_VERSION_MIN_MACOSX.
7070 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7071 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7073 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7075 * xdisp.c (forward_to_next_line_start): Allow to use the
7076 no-display-properties-and-no-overlays under bidi display.
7077 Set disp_pos in the bidi iterator to avoid searches for display
7078 properties and overlays.
7080 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7082 * editfns.c (Fset_time_zone_rule): Document relationship with the
7085 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7086 the font entity extracted from the cache (Bug#8109).
7088 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7090 * composite.c (autocmp_chars): Don't reset point. That is done by
7091 restore_point_unwind (Bug#5984).
7093 2011-08-07 Juri Linkov <juri@jurta.org>
7095 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7096 to show the arg `TIME' instead of `TIMEVAL'.
7098 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7100 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7101 display property strides EOL and includes a newline, as in
7102 longlines-mode. (Bug#9254)
7103 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7104 word-wrap under bidirectional display. (Bug#9224)
7106 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7107 is non-zero, even if the data buffer is NULL. Fixes a crash in
7108 vertical-motion with longlines-mode. (Bug#9254)
7110 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7112 * bidi.c <bidi_cache_total_alloc>: Now static.
7113 (bidi_initialize): Initialize bidi_cache_total_alloc.
7115 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7118 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7119 amount allocated this far in `bidi_cache_total_alloc'.
7120 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7121 non-zero, only free the data buffer without restoring the cache
7122 contents. All callers changed.
7124 * dispextern.h (bidi_unshelve_cache): Update prototype.
7126 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7127 (move_it_in_display_line, move_it_to)
7128 (move_it_vertically_backward, move_it_by_lines): Replace the call
7129 to xfree to an equivalent call to bidi_unshelve_cache.
7130 (move_it_in_display_line_to): Fix logic of returning
7131 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7133 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7135 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7136 came from a string character with a `cursor' property. (Bug#9229)
7138 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7140 * Makefile.in (LIB_PTHREAD): New variable.
7141 (LIBES): Add LIB_PTHREAD (Bug#9216).
7143 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7144 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7146 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7148 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7150 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7152 * xterm.c (x_find_topmost_parent): New function.
7153 (x_set_frame_alpha): Find topmost parent window with
7154 x_find_topmost_parent and set the property there also (bug#9181).
7155 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7157 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7159 * callproc.c (Fcall_process): Avoid vfork clobbering
7160 the local vars buffer, coding_systems, current_dir.
7162 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7164 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7166 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7168 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7169 so that it is not optimized away.
7171 * xdisp.c (compute_display_string_pos): Remove unused local.
7173 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7175 Fix slow cursor motion and scrolling in large buffers with
7176 selective display, like Org Mode buffers. (Bug#9218)
7178 * dispextern.h (struct bidi_it): New member disp_prop_p.
7180 * xdisp.c: Remove one-slot cache of display string positions.
7181 (compute_display_string_pos): Accept an additional argument
7182 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7183 for a display string or property. If found, set DISP_PROP_P
7186 * bidi.c (bidi_fetch_char): Accept an additional argument
7187 DISP_PROP_P, and pass it to compute_display_string_pos.
7188 Only handle text covered by a display string if DISP_PROP_P is returned
7189 non-zero. All callers of bidi_fetch_char changed.
7191 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7193 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7195 2010-12-03 Don March <don@ohspite.net>
7197 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7198 last character M-[char] is translated to ESC [char] (bug#7541).
7200 2011-08-02 Kenichi Handa <handa@m17n.org>
7202 * lisp.h (uniprop_table): Extern it.
7204 * chartab.c (uniprop_table): Make it non-static.
7206 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7208 * xdisp.c (forward_to_next_line_start): Accept additional argument
7209 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7211 (reseat_at_next_visible_line_start): Use the bidi iterator state
7212 returned by forward_to_next_line_start to restore the state of
7213 it->bidi_it after backing up to previous newline. (Bug#9212)
7215 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7217 * regex.c (re_comp): Protoize.
7218 (re_exec): Fix return type.
7219 (regexec): Fix type of `ret'. (Bug#9203)
7221 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7223 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7224 This is needed if max-image-size is a floating-point number.
7226 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7228 * print.c (print_object): Print empty symbol as ##.
7230 * lread.c (read1): Read ## as empty symbol.
7232 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7234 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7235 setting frame foreground color (Bug#9175).
7236 (x_set_background_color): Likewise.
7238 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7239 contents (Bug#9176).
7240 (EmacsTooltip -init): Remove bezels and add shadows to
7243 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7244 or scroll bar (Bug#8470).
7246 * nsfont.m (nsfont_open): Remove assignment to voffset and
7247 unnecessary vars hshink, expand, hd, full_height, min_height.
7248 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7250 * nsterm.h (nsfont_info): Remove voffset field.
7252 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7254 Implement strike-through and overline on NextStep (Bug#8863).
7256 * nsfont.m (nsfont_open): Use underline position provided by font,
7257 instead of hard-coded value of 2.
7258 (nsfont_draw): Call ns_draw_text_decoration instead.
7260 * nsterm.h: Add declaration for ns_draw_text_decoration.
7262 * nsterm.m (ns_draw_text_decoration): New function for drawing
7263 underline, overline, and strike-through.
7264 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7265 ns_draw_text_decoration. Change treatment of cursor drawing to
7266 accommodate underlining, etc.
7268 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7270 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7273 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7275 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7276 Without this fix, if a signal arrives just after memory fills up,
7277 'malloc' might be invoked reentrantly.
7279 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7280 In other words, assume that every image size is allowed, on non-X
7281 hosts. This assumption is probably wrong, but it lets Emacs compile.
7283 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7285 * regex.c (re_iswctype): Convert return values to boolean.
7287 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7289 * xdisp.c (compute_display_string_pos): Don't use cached display
7290 string position if the buffer had its restriction changed.
7293 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7295 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7297 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7299 Integer signedness and overflow and related fixes. (Bug#9079)
7301 * bidi.c: Integer size and overflow fixes.
7302 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7303 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7304 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7305 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7306 (bidi_find_other_level_edge):
7307 Use ptrdiff_t instead of EMACS_INT where either will do.
7308 This works better on 32-bit hosts configured --with-wide-int.
7309 (bidi_cache_ensure_space): Check for size-calculation overflow.
7310 Use % rather than repeated addition, for better worst-case speed.
7311 Don't set bidi_cache_size until after xrealloc returns, because it
7313 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7314 (bidi_cache_ensure_space): Also check that the bidi cache size
7315 does not exceed that of the largest Lisp string or buffer. See Eli
7316 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7318 * alloc.c (__malloc_size_t): Remove.
7319 All uses replaced by size_t. See Andreas Schwab's note
7320 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7322 * image.c: Improve checking for integer overflow.
7323 (check_image_size): Assume that f is nonnull, since
7324 it is always nonnull in practice. This is one less thing to
7325 worry about when checking for integer overflow later.
7326 (x_check_image_size): New function, which checks for integer
7327 overflow issues inside X.
7328 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7329 This removes the need for a memory_full check.
7330 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7331 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7332 (xbm_read_bitmap_data): Change locals back to 'int', since
7333 their values must fit in 'int'.
7334 (xpm_load_image, png_load, tiff_load):
7335 Invoke x_create_x_image_and_pixmap earlier,
7336 to avoid much needless work if the image is too large.
7337 (tiff_load): Treat overly large images as if
7338 x_create_x_image_and_pixmap failed, not as malloc failures.
7339 (gs_load): Use x_check_image_size.
7341 * gtkutil.c: Omit integer casts.
7342 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7343 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7345 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7347 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7348 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7349 would wrongly return t on a 64-bit host.
7351 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7352 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7353 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7354 and therefore cause GCC to emit a bogus diagnostic in some cases.
7356 * image.c: Integer signedness and overflow and related fixes.
7357 This is not an exhaustive set of fixes, but it's time to
7358 record what I've got.
7359 (lookup_pixel_color, check_image_size): Remove redundant decls.
7360 (check_image_size): Don't assume that arbitrary EMACS_INT values
7361 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7362 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7363 (tiff_load, imagemagick_load_image):
7364 Check for overflow in size calculations.
7365 (x_create_x_image_and_pixmap): Remove unnecessary test for
7366 xmalloc returning NULL; that can't happen.
7367 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7368 (xpm_color_bucket): Use better integer hashing function.
7369 (xpm_cache_color): Don't possibly over-allocate memory.
7370 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7371 (gif_memory_source):
7372 Use ptrdiff_t, not int or size_t, to record sizes.
7373 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7374 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7375 either works, as we prefer signed integers.
7376 (tiff_read_from_memory, tiff_write_from_memory):
7377 Return tsize_t, not size_t, since that's what the TIFF API wants.
7378 (tiff_read_from_memory): Don't fail simply because the read would
7379 go past EOF; instead, return a short read.
7380 (tiff_load): Omit no-longer-needed casts.
7381 (Fimagemagick_types): Don't assume size fits into 'int'.
7383 Improve hashing quality when configured --with-wide-int.
7384 * fns.c (hash_string): New function, taken from sxhash_string.
7385 Do not discard information about ASCII character case; this
7386 discarding is no longer needed.
7387 (sxhash-string): Use it. Change sig to match it. Caller changed.
7388 * lisp.h: Declare it.
7389 * lread.c (hash_string): Remove, since we now use fns.c's version.
7390 The fns.c version returns a wider integer if --with-wide-int is
7391 specified, so this should help the quality of the hashing a bit.
7393 * emacs.c: Integer overflow minor fix.
7394 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7395 Define only if GNU_LINUX.
7396 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7398 * dispnew.c: Integer signedness and overflow fixes.
7399 Remove unnecessary forward decls, that were a maintenance hassle.
7400 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7402 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7403 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7404 (prepare_desired_row, line_draw_cost):
7405 Use int, not unsigned, where either works.
7406 (save_current_matrix, restore_current_matrix):
7407 Use ptrdiff_t, not size_t, where either works.
7408 (init_display): Check for overflow more accurately, and without
7409 relying on undefined behavior.
7411 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7412 Remove, replacing with the new symbols in lisp.h. All uses changed.
7413 * fileio.c (make_temp_name):
7414 * filelock.c (lock_file_1, lock_file):
7415 * xdisp.c (message_dolog):
7416 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7417 Use pMd etc. instead.
7418 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7419 replacing the pWIDE etc. symbols removed from editfns.c.
7421 * keyboard.h (num_input_events): Now uintmax_t.
7422 This is (very slightly) less likely to mess up due to wraparound.
7425 * buffer.c: Integer signedness fixes.
7426 (alloc_buffer_text, enlarge_buffer_text):
7427 Use ptrdiff_t rather than size_t when either will do, as we prefer
7430 * alloc.c: Integer signedness and overflow fixes.
7431 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7432 (__malloc_size_t): Default to size_t, not to int.
7433 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7434 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7435 Prefer ptrdiff_t to size_t when either would do, as we prefer
7437 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7438 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7439 Now const. Initialize with values that are in range even if char
7441 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7442 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7443 These functions do the right thing with sizes > 2**32.
7444 (check_depth): Now ptrdiff_t, not int.
7445 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7446 Adjust to new way of storing sizes. Check for size overflow bugs
7448 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7449 slightly wrong anyway, as it missed one instance of
7450 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7451 (refill_memory_reserve): Omit needless cast to size_t.
7452 (mark_object_loop_halt): Mark as externally visible.
7454 * xselect.c: Integer signedness and overflow fixes.
7455 (Fx_register_dnd_atom, x_handle_dnd_message):
7456 Use ptrdiff_t, not size_t, since we prefer signed.
7457 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7458 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7459 x_dnd_atoms_size and x_dnd_atoms_length.
7461 * doprnt.c: Prefer signed to unsigned when either works.
7463 * doprnt.c (doprnt):
7465 * xdisp.c (vmessage):
7466 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7467 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7468 prefer signed arithmetic to avoid comparison confusion.
7469 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7470 but is a bit tricky.
7472 Assume freestanding C89 headers, string.h, stdlib.h.
7473 * data.c, doprnt.c, floatfns.c, print.c:
7474 Include float.h unconditionally.
7475 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7476 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7477 * regex.c: Likewise for stddef.h, string.h.
7478 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7479 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7480 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7481 (STDC_HEADERS): Remove obsolete defines.
7482 * sysdep.c: Include limits.h unconditionally.
7484 Assume support for memcmp, memcpy, memmove, memset.
7485 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7486 * regex.c (memcmp, memcpy):
7487 Remove; we assume C89 now.
7489 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7490 (__malloc_safe_bcopy): Remove; no longer needed.
7492 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7493 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7494 well either way, and we prefer signed to unsigned.
7496 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7498 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7499 closes the connection while we're reading (bug#9182).
7501 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7503 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7504 are specified (Bug#9168).
7506 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7508 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7509 Found by GCC static checking and --with-wide-int on a 32-bit host.
7511 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7513 * xdisp.c (compute_display_string_pos): Fix logic of caching
7514 previous display string position. Initialize cached_prev_pos to
7515 -1. Fixes slow-down at the beginning of a buffer.
7517 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7519 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7520 for attrs[LFACE_FONTSET_INDEX].
7522 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7524 * xml.c (parse_region): Remove unused local
7525 that was recently introduced.
7527 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7529 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7530 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7532 * xdisp.c (move_it_in_display_line_to): Record the best matching
7533 position for TO_CHARPOS while scanning the line, and restore it on
7534 exit if none of the characters scanned was an exact match.
7535 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7536 when exact match is impossible due to invisible text, and the
7537 lines are truncated.
7539 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7541 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7544 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7546 Fix a significant slow-down of cursor motion with C-n, C-p,
7547 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7548 auto-repeat under bidi redisplay in fontified buffers.
7549 * xdisp.c (compute_stop_pos_backwards): New function.
7550 (next_element_from_buffer): Call compute_stop_pos_backwards to
7551 find a suitable prev_stop when we find ourselves before
7553 (reseat): Don't look for prev_stop, as that could mean a very long
7555 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7556 <cached_disp_overlay_modiff>: Cache for last found display string
7558 (compute_display_string_pos): Return the cached position if asked
7559 about the same buffer in the same area of character positions, and
7560 the buffer wasn't changed since the time the display string
7561 position was cached.
7563 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7565 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7566 is an integer, which is important for empty lines. (Bug#9149)
7568 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7570 * frame.c (Fmodify_frame_parameters): In tty case, update the
7571 default face if necessary (Bug#4238).
7573 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7575 * editfns.c (Fstring_to_char): No need to explain what a character
7576 is in the docstring (Bug#6576).
7578 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7580 * xml.c (parse_region): Make sure we always return a tree.
7582 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7584 * xml.c (parse_region): If a document contains only comments,
7587 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7589 * xml.c (make_dom): Return comments, too.
7591 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7594 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7595 and the surrounding thread.
7596 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7597 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7598 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7600 * s/openbsd.h (BROKEN_SIGIO): Define.
7601 * unexelf.c (unexec) [__OpenBSD__]:
7602 Don't update the .mdebug section of the Alpha COFF symbol table.
7604 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7606 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7609 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7611 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7612 This fixes some race conditions on the permissions of any newly
7615 * alloc.c (valid_pointer_p): Use pipe, not open.
7616 This fixes some permissions issues when debugging.
7618 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7619 If fchown fails to set both uid and gid, try to set just gid,
7620 as that is sometimes allowed. Adjust the file's mode to eliminate
7621 setuid or setgid bits that are inappropriate if fchown fails.
7623 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7625 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7626 to compare Lisp_Objects.
7627 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7628 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7629 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7631 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7633 * lread.c (read_integer): Unread even EOF character.
7634 (read1): Likewise. Properly record start position of symbol.
7636 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7637 symbol character follows.
7639 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7641 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7642 This works around a problem with the previous change to Fcopy_file.
7643 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7644 and without this change, GCC might complain about discarding
7645 fchown's return value.
7647 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7649 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7651 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7653 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7655 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7657 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7658 it's used from the C level.
7660 * process.c: Use the same condition for POLL_FOR_INPUT in both
7661 keyboard.c and process.c (bug#1858).
7663 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7665 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7666 (Fgnutls_boot): Use it.
7668 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7670 * doc.c (Fsubstitute_command_keys): Revert last change.
7672 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7674 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7675 quotes the next character, and doesn't affect other longer
7676 sequences (bug#8935).
7678 * lread.c (syms_of_lread): Clarify that is isn't only
7679 `eval-buffer' and `eval-defun' that's affected by
7680 `lexical-binding' (bug#8460).
7682 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7684 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7685 bidi redisplay when a line includes both an image and is truncated.
7687 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7689 Fix minor problems found by static checking.
7690 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7691 (elsz): Now a signed constant, not a size_t var. We prefer signed
7692 types to unsigned, to avoid integer comparison confusion. Without
7693 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7694 "cannot optimize loop, the loop counter may overflow", a symptom
7696 * indent.c (Fvertical_motion): Mark locals as initialized.
7697 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7699 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7701 * search.c (Fre_search_backward): Mention `case-fold-search' in
7702 all the re_search_* functions (bug#8138).
7704 * keyboard.c (Fopen_dribble_file): Document when the file is
7707 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7709 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7712 Support bidi reordering of display and overlay strings.
7713 * xdisp.c (compute_display_string_pos)
7714 (compute_display_string_end): Accept additional argument STRING.
7715 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7716 (reseat_to_string): Initialize bidi_it->string.s and
7717 bidi_it->string.schars.
7718 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7719 NULL (avoids a crash in bidi_paragraph_init).
7720 Initialize itb.string.lstring.
7721 (init_iterator): Call bidi_init_it only of a valid
7722 buffer position was specified. Initialize paragraph_embedding to
7724 (reseat_to_string): Initialize the bidi iterator.
7725 (display_string): If we need to ignore text properties of
7726 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7727 original value of -1 will not work with bidi.)
7728 (compute_display_string_pos): First arg is now struct
7729 `text_pos *'; all callers changed. Support display properties on
7731 (compute_display_string_end): Support display properties on Lisp
7733 (init_iterator, reseat_1, reseat_to_string): Initialize the
7734 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7735 when iterating on a string not from display properties).
7736 (compute_display_string_pos, compute_display_string_end):
7737 Fix calculation of the object to scan. Fixes an error when using
7739 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7740 base_level_stop; instead, set base_level_stop to BEGV.
7741 Fixes crashes in vertical-motion.
7742 (next_element_from_buffer): Improve commentary for when
7743 the iterator is before prev_stop.
7744 (init_iterator): Initialize bidi_p from the default value of
7745 bidi-display-reordering, not from buffer-local value. Use the
7746 buffer-local value only if initializing for buffer iteration.
7747 (handle_invisible_prop): Support invisible properties on strings
7748 that are being bidi-reordered.
7749 (set_iterator_to_next): Support bidi reordering of C strings and
7751 (next_element_from_string): Support bidi reordering of Lisp
7753 (handle_stop_backwards): Support Lisp strings as well.
7754 (display_string): Support display of R2L glyph rows.
7755 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7756 (init_iterator): Don't initialize it->bidi_p for strings
7758 (reseat_to_string): Initialize it->bidi_p for strings here.
7759 (next_element_from_string, next_element_from_c_string)
7760 (next_element_from_buffer): Add xassert's for correspondence
7761 between IT's object being iterated and it->bidi_it.string
7763 (face_before_or_after_it_pos): Support bidi iteration.
7764 (next_element_from_c_string): Handle the case of the first string
7765 character that is not the first one in the visual order.
7766 (get_visually_first_element): New function, refactored from common
7767 parts of next_element_from_buffer, next_element_from_string, and
7768 next_element_from_c_string.
7769 (tool_bar_lines_needed, redisplay_tool_bar)
7770 (display_menu_bar): Force left-to-right direction. Add a FIXME
7771 comment for making that be controlled by a user option.
7772 (push_it, pop_it): Save and restore the state of the
7773 bidi iterator. Save and restore the bidi_p flag.
7774 (pop_it): Iterate out of display property for string iteration as
7776 (iterate_out_of_display_property): Support iteration over strings.
7777 (handle_single_display_spec): Set up it->bidi_it for iteration
7778 over a display string, and call bidi_init_it.
7779 (handle_single_display_spec, next_overlay_string)
7780 (get_overlay_strings_1, push_display_prop): Set up the bidi
7781 iterator for displaying display or overlay strings.
7782 (forward_to_next_line_start): Don't use the shortcut if
7784 (back_to_previous_visible_line_start): If handle_display_prop
7785 pushed the iterator stack, restore the internal state of the bidi
7786 iterator by calling bidi_pop_it same number of times.
7787 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7788 and we are bidi-iterating, don't decrement the iterator position;
7789 instead, set the first_elt flag in the bidi iterator, to produce
7791 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7792 (push_display_prop): xassert that we are iterating a buffer.
7793 (push_it, pop_it): Save and restore paragraph_embedding member.
7794 (handle_single_display_spec, next_overlay_string)
7795 (get_overlay_strings_1, reseat_1, reseat_to_string)
7796 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7797 correctly. Don't assume unibyte strings are not bidi-reordered.
7798 (compute_display_string_pos)
7799 (compute_display_string_end): Fix handling the case of C string.
7800 (push_it, pop_it): Save and restore from_disp_prop_p.
7801 (handle_single_display_spec, push_display_prop): Set the
7802 from_disp_prop_p flag.
7803 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7804 (pop_it): Call iterate_out_of_display_property only if we are
7805 popping after iteration over a string that came from a display
7806 property. Fix a typo in popping stretch info. Add an assertion
7807 for verifying that the iterator position is in sync with the bidi
7809 (handle_single_display_spec, get_overlay_strings_1)
7810 (push_display_prop): Fix initialization of paragraph direction for
7811 string when that of the parent object is not yet determined.
7812 (reseat_1): Call bidi_init_it to resync the bidi
7813 iterator with IT's position. (Bug#7616)
7814 (find_row_edges): If ROW->start.pos gives position
7815 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7816 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7817 Reset the from_disp_prop_p flag.
7818 (SAVE_IT, RESTORE_IT): New macros.
7819 (pos_visible_p, face_before_or_after_it_pos)
7820 (back_to_previous_visible_line_start)
7821 (move_it_in_display_line_to, move_it_in_display_line)
7822 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7823 (try_scrolling, redisplay_window, display_line): Use them when
7824 saving a temporary copy of the iterator and restoring it back.
7825 (back_to_previous_visible_line_start, reseat_1)
7826 (init_iterator): Empty the bidi cache "stack".
7827 (move_it_in_display_line_to): If iterator ended up at
7828 EOL, but we never saw any buffer positions smaller than
7829 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7830 motion in bidi-reordered lines.
7831 (move_it_in_display_line_to): Record prev_method and prev_pos
7832 immediately before the call to set_iterator_to_next. Fixes cursor
7833 motion in bidi-reordered lines with stretch glyphs and strings
7834 displayed in margins. (Bug#8133) (Bug#8867)
7835 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7837 (pos_visible_p): Support positions in bidi-reordered lines.
7838 Save and restore bidi cache.
7840 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7841 (bidi_paragraph_info): Delete unused struct.
7842 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7843 (bidi_cache_start): New variable.
7844 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7846 (bidi_cache_fetch_state, bidi_cache_search)
7847 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7848 (bidi_cache_find, bidi_peek_at_next_level)
7849 (bidi_level_of_next_char, bidi_find_other_level_edge)
7850 (bidi_move_to_visually_next): Compare cache index with
7851 bidi_cache_start rather than with zero.
7852 (bidi_fetch_char): Accept new argument STRING; all callers
7853 changed. Support iteration over a string. Support strings with
7854 display properties. Support unibyte strings. Fix the type of
7855 `len' according to what STRING_CHAR_AND_LENGTH expects.
7856 (bidi_paragraph_init, bidi_resolve_explicit_1)
7857 (bidi_resolve_explicit, bidi_resolve_weak)
7858 (bidi_level_of_next_char, bidi_move_to_visually_next):
7859 Support iteration over a string.
7860 (bidi_set_sor_type, bidi_resolve_explicit_1)
7861 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7862 can now be zero (for strings); special values 0 and -1 were
7863 changed to -1 and -2, respectively.
7864 (bidi_char_at_pos): New function.
7865 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7866 Call it instead of FETCH_MULTIBYTE_CHAR.
7867 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7868 initialized to valid values.
7869 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7871 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7872 the test for valid cached positions. Fix the logic for looking up
7873 the sentinel state in the cache. GCPRO the Lisp string we are
7875 (bidi_push_it, bidi_pop_it): New functions.
7876 (bidi_initialize): Initialize the bidi cache start stack pointer.
7877 (bidi_cache_ensure_space): New function, refactored from part of
7878 bidi_cache_iterator_state. Don't assume the required size is just
7879 one BIDI_CACHE_CHUNK away.
7880 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7881 (bidi_count_bytes, bidi_char_at_pos): New functions.
7882 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7883 always valid if bidi_cache_idx is valid.
7884 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7885 is valid if it's going to be used.
7886 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7887 (bidi_cache_fetch_state, bidi_cache_search)
7888 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7889 (bidi_cache_iterator_state, bidi_cache_find)
7890 (bidi_find_other_level_edge, bidi_cache_start_stack):
7891 All variables related to cache indices are now EMACS_INT.
7893 * dispextern.h (struct bidi_string_data): New structure.
7894 (struct bidi_it): New member `string'. Make flag members be 1-bit
7895 fields, and put them last in the struct.
7896 (compute_display_string_pos, compute_display_string_end):
7898 (bidi_push_it, bidi_pop_it): Add prototypes.
7899 (struct iterator_stack_entry): New members bidi_p,
7900 paragraph_embedding, and from_disp_prop_p.
7901 (struct it): Member bidi_p is now a bit field 1 bit wide.
7902 (bidi_shelve_cache, bidi_unshelve_cache):
7905 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7906 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7907 and vector-like objects.
7909 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7910 cache around display iteration.
7912 * window.c (Fwindow_end, window_scroll_pixel_based)
7913 (displayed_window_lines, Frecenter): Save and restore the bidi
7914 cache around display iteration.
7916 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7918 * editfns.c (Fdelete_region): Clarify the use of the named
7919 parameters (bug#6788).
7921 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7923 * indent.c (Fvertical_motion): Set and restore w->pointm when
7924 saving and restoring the window's buffer (Bug#9006).
7926 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7928 * editfns.c (Fstring_to_char): Clarify just what is returned
7929 (bug#6576). Text by Eli Zaretskii.
7931 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7933 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7935 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7937 * buffer.c (mmap_find): Fix a typo.
7939 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7941 Fix execution of x selection hooks.
7942 * xselect.c (Qx_lost_selection_functions)
7943 (Qx_sent_selection_functions): New vars.
7944 (syms_of_xselect): DEFSYM them.
7945 (x_handle_selection_request): Pass Qx_sent_selection_functions
7946 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7947 (x_handle_selection_clear,x_clear_frame_selections):
7948 Pass Qx_lost_selection_functions rather than
7949 Vx_lost_selection_functions to Frun_hook_with_args.
7951 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7953 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7954 The old code sometimes used this field without initializing it.
7956 * alloc.c (gc_sweep): Don't read past end of array.
7957 In theory, the old code could also have corrupted Emacs internals,
7958 though it'd be very unlikely.
7960 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7962 * character.c (Fcharacterp): Don't advertise optional ignored
7963 argument. (Bug#4026)
7965 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7967 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7970 * window.c (Fset_window_start): Doc fix (bug#4199).
7971 (Fset_window_hscroll): Ditto.
7973 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7975 Fix minor new problems caught by GCC 4.6.1.
7976 * term.c (init_tty): Remove unused local.
7977 * xsettings.c (store_monospaced_changed): Define this function only
7978 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7981 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7983 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7985 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7987 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7988 are the mini-buffer and the echo area (bug#3320).
7990 * term.c (init_tty): Remove support for supdup, c10 and perq
7991 terminals, which are no longer supported (bug#1482).
7993 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7995 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7997 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7999 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8000 for non-popups (Bug#3642).
8002 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8004 * alloc.c (reset_malloc_hooks): Protoize.
8005 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8006 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8007 * cm.c (losecursor): Likewise.
8008 * data.c (fmod): Likewise.
8009 * dispnew.c (swap_glyphs_in_rows): Likewise.
8010 * emacs.c (memory_warning_signal): Likewise.
8011 * floatfns.c (float_error): Likewise.
8012 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8013 (otf_open, font_otf_capability, generate_otf_features)
8014 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8016 * image.c (pbm_read_file): Likewise.
8017 * indent.c (string_display_width): Likewise.
8018 * intervals.c (check_for_interval, search_for_interval)
8019 (inc_interval_count, count_intervals, root_interval)
8020 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8021 * lread.c (defalias): Likewise.
8022 * ralloc.c (r_alloc_check): Likewise.
8023 * regex.c (set_image_of_range_1, set_image_of_range)
8024 (regex_grow_registers): Likewise.
8025 * sysdep.c (strerror): Likewise.
8026 * termcap.c (valid_filename_p, tprint, main): Likewise.
8027 * tparam.c (main): Likewise.
8028 * unexhp9k800.c (run_time_remap, save_data_space)
8029 (update_file_ptrs, read_header, write_header, calculate_checksum)
8030 (copy_file, copy_rest, display_header): Likewise.
8031 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8033 * xdisp.c (check_it): Likewise.
8034 * xfaces.c (register_color, unregister_color, unregister_colors):
8036 * xfns.c (print_fontset_result): Likewise.
8037 * xrdb.c (member, fatal, main): Likewise.
8039 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8041 Fix minor problems found by static checking (Bug#9031).
8042 * chartab.c (char_table_set_range, map_sub_char_table):
8043 Remove unused locals.
8044 (uniprop_table): Now static.
8045 * composite.c (_work_char): Remove unused static var.
8047 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8049 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8051 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8053 * gtkutil.c (qttip_cb): Remove code without function.
8055 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8057 * w32.c (pthread_sigmask): New stub.
8059 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8061 Use pthread_sigmask, not sigprocmask (Bug#9010).
8062 sigprocmask is portable only for single-threaded applications, and
8063 Emacs can be multi-threaded when it uses GTK.
8064 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8066 * callproc.c (Fcall_process):
8067 * process.c (create_process):
8068 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8069 Use pthread_sigmask, not sigprocmask.
8071 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8073 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8074 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8077 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8079 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8080 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8081 (xg_hide_tooltip): Fix comment.
8083 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8084 in registerServicesMenuSendTypes.
8085 (validRequestorForSendType): Don't check ns_return_types.
8087 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8090 2011-07-08 Jason Rumney <jasonr@gnu.org>
8092 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8093 SH_SHOW for hidden windows (Bug#5482).
8095 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8096 frame struct members of non-existent frames (Bug#6284).
8098 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8100 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8101 variable firstTime not needed on OSX >= 10.6.
8102 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8103 >= 10.5. Use setKnobProportion, setDoubleValue.
8105 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8106 (MAC_OS_X_VERSION_10_5): Define if not defined.
8107 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8108 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8109 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8111 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8112 cString and lossyCString on OSX >= 10.4.
8114 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8115 sizeToFit on OSX >= 10.2.
8117 * nsimage.m (allocInitFromFile): Don't use deprecated method
8118 bestRepresentationForDevice on OSX >= 10.6.
8120 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8123 * emacs.c: Declare unexec_init_emacs_zone.
8125 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8127 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8129 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8130 on svcsMenu (Bug#8842).
8132 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8134 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8136 * nsterm.m (QUTF8_STRING): Declare.
8137 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8138 (validRequestorForSendType): Return type is (id).
8139 Change indexOfObjectIdenticalTo to indexOfObject.
8140 Check if we have local selection before returning self (Bug#8842).
8141 (writeSelectionToPasteboard): Put local selection into paste board
8142 if we have a local selection (Bug#8842).
8143 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8145 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8146 (ns_get_local_selection): Declare.
8148 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8150 * keymap.c (describe_map_tree): Don't insert a double newline at
8151 the end of the buffer (bug#1169) and return whether we inserted
8154 * callint.c (Fcall_interactively): Change "reading args" to
8155 "providing args" to try to clarify what it does (bug#1010).
8157 2011-07-07 Kenichi Handa <handa@m17n.org>
8159 * composite.c (composition_compute_stop_pos): Ignore a static
8160 composition starting before CHARPOS (Bug#8915).
8162 * xdisp.c (handle_composition_prop): Likewise.
8164 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8166 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8169 2011-07-07 Kenichi Handa <handa@m17n.org>
8171 * character.h (unicode_category_t): New enum type.
8173 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8174 (Qchar_code_property_table): New variable.
8175 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8176 (UNIPROP_COMPRESSED_FORM_P): New macros.
8177 (char_table_ascii): Uncompress the compressed values.
8178 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8179 Uncompress the compressed values.
8180 (sub_char_table_ref_and_range): Likewise.
8181 (char_table_ref_and_range): Uncompress the compressed values.
8182 (sub_char_table_set): New arg is_uniprop. Callers changed.
8183 Uncompress the compressed values.
8184 (sub_char_table_set_range): Args changed. Callers changed.
8185 (char_table_set_range): Adjuted for the above change.
8186 (map_sub_char_table): Delete args default_val and parent. Add arg
8187 top. Give decoded values to a Lisp function.
8188 (map_char_table): Adjust for the above change. Give decoded
8189 values to a Lisp function. Gcpro more variables.
8190 (uniprop_table_uncompress)
8191 (uniprop_decode_value_run_length): New functions.
8192 (uniprop_decoder, uniprop_decoder_count): New variables.
8193 (uniprop_get_decoder, uniprop_encode_value_character)
8194 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8196 (uniprop_encoder, uniprop_encoder_count): New variables.
8197 (uniprop_get_encoder, uniprop_table)
8198 (Funicode_property_table_internal, Fget_unicode_property_internal)
8199 (Fput_unicode_property_internal): New functions.
8200 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8201 Sunicode_property_table_internal, Sget_unicode_property_internal,
8202 and Sput_unicode_property_internal. Defvar_lisp
8203 char-code-property-alist.
8205 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8206 Vunicode_category_table.
8208 * font.c (font_range): Adjust for the change of
8209 Vunicode_category_table.
8211 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8213 * m/iris4d.h: Remove file, move contents ...
8214 * s/irix6-5.h: ... here.
8216 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8218 Remove unportable assumption about struct layout (Bug#8884).
8219 * alloc.c (mark_buffer):
8220 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8221 (clone_per_buffer_values): Don't assume that
8222 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8223 This isn't true in general, and it's particularly not true
8224 if Emacs is configured with --with-wide-int.
8225 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8226 New macros, used in the buffer.c change.
8228 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8230 * xsettings.c: Use both GConf and GSettings if both are available.
8231 (store_config_changed_event): Add comment.
8232 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8233 (store_tool_bar_style_changed): New functions.
8234 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8235 (struct xsettings): Move font inside HAVE_XFT.
8236 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8237 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8238 Move inside HAVE_XFT.
8239 (something_changed_gsettingsCB): Rename from something_changedCB.
8240 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8242 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8243 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8244 (something_changed_gconfCB): Rename from something_changedCB.
8245 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8246 (parse_settings): Move check for font inside HAVE_XFT.
8247 (read_settings, apply_xft_settings): Add comment.
8248 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8249 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8250 call store_font_name_changed.
8251 (xft_settings_event): Add comment.
8252 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8253 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8254 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8255 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8256 (xsettings_initialize): Call init_gsettings last.
8257 (xsettings_get_system_font, xsettings_get_system_normal_font):
8260 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8262 Random fixes. E.g., (random) never returned negative values.
8263 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8264 subseconds part to the entropy, as that's a bit more random.
8265 Prefer signed to unsigned, since the signedness doesn't matter and
8266 in general we prefer signed. When given a limit, use a
8267 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8268 latter isn't right if USE_2_TAGS_FOR_INTS.
8269 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8270 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8272 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8274 * textprop.c (text_property_stickiness):
8275 Obey Vtext_property_default_nonsticky.
8276 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8277 * w32fns.c (syms_of_w32fns):
8278 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8280 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8282 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8283 This is more efficient than Ffile_directory_p and avoids a minor race.
8285 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8287 * buffer.c (Foverlay_put): Say what the return value is
8290 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8291 is a directory before asking whether to use the file name
8293 (barf_or_query_if_file_exists): Make the "File is a directory"
8294 error be more correct.
8296 * fns.c (Frequire): Remove the mention of the .gz files, since
8297 that's installation-specific, but keep the mention of
8298 `get-load-suffixes'.
8300 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8302 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8303 Report string overflow if the output is too long.
8305 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8307 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8308 (syms_of_gnutls): Remove duplicate DEFSYM for
8309 Qgnutls_bootprop_verify_hostname_error, an error for
8310 Qgnutls_bootprop_verify_error (which is no longer used).
8312 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8313 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8314 Also (re)move comments that are misplaced or no longer relevant.
8316 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8318 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8320 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8322 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8323 and background color parameters if they have been changed.
8325 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8327 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8329 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8331 * xsettings.c (SYSTEM_FONT): Define only when used.
8332 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8334 * keymap.c (access_keymap_1): Now static.
8336 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8338 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8339 leave any prefix arg for the up event (Bug#1586).
8341 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8343 * lread.c (syms_of_lread): Mention single symbols defined by
8344 `defvar' or `defconst' (bug#7154).
8346 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8347 (Frequire): Mention get-load-suffixes.
8349 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8351 * window.h (window): Remove clone_number slot.
8352 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8354 (make_parent_window, make_window, saved_window)
8355 (Fset_window_configuration, save_window_save): Don't deal with
8357 * buffer.c (Qclone_number): Remove declaration.
8358 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8360 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8362 Add multiple inheritance to keymaps.
8363 * keymap.c (Fmake_composed_keymap): New function.
8364 (Fset_keymap_parent): Simplify.
8365 (fix_submap_inheritance): Remove.
8366 (access_keymap_1): New function extracted from access_keymap to handle
8367 embedded parents and handle lists of maps.
8368 (access_keymap): Use it.
8369 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8370 (Fcopy_keymap): Handle embedded parents.
8371 (Fcommand_remapping, define_as_prefix): Simplify.
8372 (Fkey_binding): Simplify.
8373 (syms_of_keymap): Move minibuffer-local-completion-map,
8374 minibuffer-local-filename-completion-map,
8375 minibuffer-local-must-match-map, and
8376 minibuffer-local-filename-must-match-map to Elisp.
8377 (syms_of_keymap): Defsubr make-composed-keymap.
8378 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8379 (parse_menu_item): Trivial simplification.
8381 2011-07-01 Glenn Morris <rgm@gnu.org>
8383 * Makefile.in (SETTINGS_LIBS): Fix typo.
8385 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8387 * coding.c (Fencode_coding_string): Record the last coding system
8388 used, as the function doc string says (bug#8738).
8390 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8392 * xsettings.c (store_monospaced_changed): Take new font as arg and
8393 check for change against current_mono_font.
8394 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8395 (emacs_settings_constructor, emacs_settings_get_property)
8396 (emacs_settings_set_property, emacs_settings_class_init)
8397 (emacs_settings_init, gsettings_obj): Remove.
8398 (something_changedCB): New function for HAVE_GSETTINGS.
8399 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8400 with value as argument.
8401 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8402 g_settings_new (Bug#8967). Do not create gsettings_obj.
8403 Remove calls to g_settings_bind. Connect something_changedCB to
8406 * xgselect.c: Add defined (HAVE_GSETTINGS).
8407 (xgselect_initialize): Ditto.
8409 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8410 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8413 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8415 * eval.c (struct backtrace): Simplify and port the data structure.
8416 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8417 signed bit field, as this assumption is not portable and it makes
8418 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8419 "char debug_on_exit : 1" as this is not portable either; instead,
8420 use the portable "unsigned int debug_on_exit : 1". Remove unused
8421 member evalargs. Remove obsolete comments about cc bombing out.
8423 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8425 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8426 Let HAVE_GSETTINGS override HAVE_GCONF.
8427 (store_monospaced_changed): New function.
8428 (EMACS_SETTINGS): A new type derived from GObject to handle
8429 GSettings notifications.
8430 (emacs_settings_constructor, emacs_settings_get_property)
8431 (emacs_settings_set_property, emacs_settings_class_init):
8433 (gsettings_client, gsettings_obj): New variables.
8434 (GSETTINGS_SCHEMA): New define.
8435 (something_changedCB): Call store_monospaced_changed.
8436 (init_gsettings): New function.
8437 (xsettings_initialize): Call init_gsettings.
8438 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8441 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8444 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8446 * window.c (resize_root_window, grow_mini_window)
8447 (shrink_mini_window): Rename Qresize_root_window to
8448 Qwindow_resize_root_window and Qresize_root_window_vertically to
8449 Qwindow_resize_root_window_vertically.
8451 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8453 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8455 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8457 * makefile.w32-in: Redesign dependencies so they reflect more
8458 clearly which files are directly included by each source file,
8459 and not through other includes.
8461 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8463 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8464 (sort_overlays, overlay_strings): When an overlay's clone number
8465 matches the window's clone number process the overlay even if
8466 the overlay's window property doesn't match the current window.
8468 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8469 (Fwindow_hchild): Rename to Fwindow_left_child.
8470 (Fwindow_next): Rename to Fwindow_next_sibling.
8471 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8472 (resize_window_check): Rename to window_resize_check.
8473 (resize_window_apply): Rename to window_resize_apply.
8474 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8475 (Fdelete_other_windows_internal, resize_frame_windows)
8476 (Fsplit_window_internal, Fdelete_window_internal)
8477 (grow_mini_window, shrink_mini_window)
8478 (Fresize_mini_window_internal): Fix callers accordingly.
8480 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8482 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8483 (emacs_fixed_set_min_size): Remove.
8484 (emacs_fixed_new): Take frame as argument.
8486 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8487 (_EmacsFixedPrivate): Remove minwidth/height.
8488 Add struct frame *f.
8489 (emacs_fixed_init): Initialize priv->f.
8490 (get_parent_class, emacs_fixed_set_min_size): Remove.
8491 (emacs_fixed_new): Set priv->f to argument.
8492 (emacs_fixed_get_preferred_width)
8493 (emacs_fixed_get_preferred_height): Use min_width/height from
8494 frames size_hint to set minimum and natural (Bug#8919).
8495 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8496 and use min_width/height from frames size_hint to set
8497 min_width/height (Bug#8919).
8499 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8500 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8503 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8505 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8506 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8509 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8511 * process.c (wait_reading_process_output): Bypass select if
8512 waiting for a cell while ignoring keyboard input, and input is
8513 pending. Suggested by Jan Djärv (Bug#8869).
8515 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8517 Use gnulib's dup2 module instead of rolling our own.
8518 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8520 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8522 * dispnew.c (scrolling_window): Before scrolling, turn off a
8523 mouse-highlight in the window being scrolled.
8525 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8527 Move DEFSYM to lisp.h and use everywhere.
8529 * character.h (DEFSYM): Move declaration...
8530 * lisp.h (DEFSYM): ...here.
8536 * w32select.c: Don't include character.h.
8538 * alloc.c (syms_of_alloc):
8539 * buffer.c (syms_of_buffer):
8540 * bytecode.c (syms_of_bytecode):
8541 * callint.c (syms_of_callint):
8542 * casefiddle.c (syms_of_casefiddle):
8543 * casetab.c (init_casetab_once):
8544 * category.c (init_category_once, syms_of_category):
8545 * ccl.c (syms_of_ccl):
8546 * cmds.c (syms_of_cmds):
8547 * composite.c (syms_of_composite):
8548 * dbusbind.c (syms_of_dbusbind):
8549 * dired.c (syms_of_dired):
8550 * dispnew.c (syms_of_display):
8551 * doc.c (syms_of_doc):
8552 * editfns.c (syms_of_editfns):
8553 * emacs.c (syms_of_emacs):
8554 * eval.c (syms_of_eval):
8555 * fileio.c (syms_of_fileio):
8556 * fns.c (syms_of_fns):
8557 * frame.c (syms_of_frame):
8558 * fringe.c (syms_of_fringe):
8559 * insdel.c (syms_of_insdel):
8560 * keymap.c (syms_of_keymap):
8561 * lread.c (init_obarray, syms_of_lread):
8562 * macros.c (syms_of_macros):
8563 * msdos.c (syms_of_msdos):
8564 * print.c (syms_of_print):
8565 * process.c (syms_of_process):
8566 * search.c (syms_of_search):
8567 * sound.c (syms_of_sound):
8568 * syntax.c (init_syntax_once, syms_of_syntax):
8569 * terminal.c (syms_of_terminal):
8570 * textprop.c (syms_of_textprop):
8571 * undo.c (syms_of_undo):
8572 * w32.c (globals_of_w32):
8573 * window.c (syms_of_window):
8574 * xdisp.c (syms_of_xdisp):
8575 * xfaces.c (syms_of_xfaces):
8576 * xfns.c (syms_of_xfns):
8577 * xmenu.c (syms_of_xmenu):
8578 * xsettings.c (syms_of_xsettings):
8579 * xterm.c (syms_of_xterm): Use DEFSYM.
8581 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8583 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8585 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8587 Integer and buffer overflow fixes (Bug#8873).
8589 * print.c (printchar, strout): Check for string overflow.
8590 (PRINTPREPARE, printchar, strout):
8591 Don't set size unless allocation succeeds.
8593 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8594 for sizes. Check for string overflow more accurately.
8595 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8597 * macros.c: Integer and buffer overflow fixes.
8598 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8599 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8600 Use ptrdiff_t, not int, for sizes.
8601 Don't increment bufsize until after realloc succeeds.
8602 Check for size-calculation overflow.
8603 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8605 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8607 * lread.c: Integer overflow fixes.
8608 (read_integer): Radix is now EMACS_INT, not int,
8609 to improve quality of diagnostics for out-of-range radices.
8610 Calculate buffer size correctly for out-of-range radices.
8611 (read1): Check for integer overflow in radices, and in
8612 read-circle numbers.
8613 (read_escape): Avoid int overflow.
8614 (Fload, openp, read_buffer_size, read1)
8615 (substitute_object_recurse, read_vector, read_list, map_obarray):
8616 Use ptrdiff_t, not int, for sizes.
8617 (read1): Use EMACS_INT, not int, for sizes.
8618 Check for size overflow.
8620 * image.c (cache_image): Check for size arithmetic overflow.
8622 * lread.c: Integer overflow issues.
8623 (saved_doc_string_size, saved_doc_string_length)
8624 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8625 Now ptrdiff_t, not int.
8626 (read1): Don't assume doc string length fits in int. Check for
8627 out-of-range doc string lengths.
8628 (read_list): Don't assume file position fits in int.
8629 (read_escape): Check for hex character overflow.
8631 2011-06-22 Leo Liu <sdl.web@gmail.com>
8633 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8634 Move to minibuffer.el.
8636 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8638 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8639 The following patches are for when GLYPH_DEBUG && !XASSERT.
8640 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8641 * dispnew.c (flush_stdout):
8642 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8643 Mark as externally visible.
8644 * dispnew.c (check_window_matrix_pointers): Now static.
8645 * dispnew.c (window_to_frame_vpos):
8646 * xfns.c (unwind_create_frame):
8647 * xterm.c (x_check_font): Remove unused local.
8648 * scroll.c (CHECK_BOUNDS):
8649 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8650 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8651 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8652 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8653 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8655 (debug_method_add): Use va_list and vsprintf rather than relying
8656 on undefined behavior with wrong number of arguments.
8657 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8658 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8659 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8660 since we're not interested in debugging glyphs with old libraries.
8661 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8662 GCC 4.6.0's static checking.
8664 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8666 Integer overflow and signedness fixes (Bug#8873).
8667 A few related buffer overrun fixes, too.
8669 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8671 * dispextern.h (struct face.stipple):
8672 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8673 (x_bitmap_mask, x_allocate_bitmap_record)
8674 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8675 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8676 (x_create_bitmap_from_xpm_data):
8677 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8678 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8680 * xfaces.c (load_pixmap):
8681 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8682 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8683 (.bitmaps_last, struct x_output.icon_bitmap):
8684 Use ptrdiff_t, not int, for bitmap indexes.
8685 (x_allocate_bitmap_record): Check for size overflow.
8686 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8688 Use ptrdiff_t, not int, for overlay counts.
8689 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8690 * editfns.c (overlays_around, get_pos_property):
8691 * textprop.c (get_char_property_and_overlay):
8692 * xdisp.c (next_overlay_change, note_mouse_highlight):
8693 * xfaces.c (face_at_buffer_position):
8694 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8695 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8696 (Fnext_overlay_change, Fprevious_overlay_change)
8697 (mouse_face_overlay_overlaps, Foverlays_in):
8698 Use ptrdiff_t, not int, for sizes.
8699 (overlays_at, overlays_in): Check for size-calculation overflow.
8701 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8703 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8704 (x_session_initialize): Do not assume string length fits in int.
8706 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8707 This is unlikely, but can occur if DPI is outlandish.
8709 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8710 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8712 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8713 * xrdb.c (magic_file_p, search_magic_path):
8714 Omit last arg SUFFIX; it was always 0. All callers changed.
8715 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8717 * xfont.c (xfont_match): Avoid need for strlen.
8719 * xfns.c: Don't assume strlen fits in int.
8720 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8722 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8723 not unsigned long, as we prefer signed integers. All callers changed.
8724 Detect integer overflow in repeat count.
8725 (message_dolog): Don't assume print length fits in 39 bytes.
8726 (display_mode_element): Don't assume strlen fits in int.
8728 * termcap.c: Don't assume sizes fit in int and never overflow.
8729 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8730 (gobble_line): Check for size-calculation overflow.
8732 * minibuf.c (Fread_buffer):
8733 * lread.c (intern, intern_c_string):
8734 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8735 Don't assume string length fits in int.
8737 * keyboard.c (parse_tool_bar_item):
8738 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8740 * font.c: Don't assume string length fits in int.
8741 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8742 Use ptrdiff_t, not int.
8743 (font_intern_prop): Don't assume string length fits in int.
8744 Don't assume integer property fits in fixnum.
8745 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8747 * filelock.c: Fix some buffer overrun and integer overflow issues.
8748 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8749 Reformulate so as not to need the command string.
8750 Invoke gzip -cd rather than gunzip, as it's more portable.
8751 (lock_info_type, lock_file_1, lock_file):
8752 Don't assume pid_t and time_t fit in unsigned long.
8753 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8754 (current_lock_owner): Prefer signed type for sizes.
8755 Use memcpy, not strncpy, where memcpy is what is really wanted.
8756 Don't assume (via atoi) that time_t and pid_t fit in int.
8757 Check for time_t and/or pid_t out of range, e.g., via a network share.
8758 Don't alloca where an auto var works fine.
8760 * fileio.c: Fix some integer overflow issues.
8761 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8762 Don't assume string length fits in int.
8763 (directory_file_name): Don't assume string length fits in long.
8764 (make_temp_name): Don't assume pid fits in int, or that its print
8765 length is less than 20.
8767 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8769 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8771 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8773 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8774 We prefer signed integers, even for size calculations.
8776 * emacs.c: Don't assume string length fits in 'int'.
8777 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8778 (main): Don't invoke strlen when not needed.
8780 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8781 (XD_DEBUG_MESSAGE): Don't waste a byte.
8783 * callproc.c (getenv_internal_1, getenv_internal)
8785 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8787 * lread.c (invalid_syntax): Omit length argument.
8788 All uses changed. This doesn't fix a bug, but it simplifies the
8789 code away from its former Hollerith-constant appearance, and it's
8790 one less 'int' to worry about when looking at integer-overflow issues.
8791 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8793 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8794 This didn't break anything, but it didn't help either.
8795 It's confusing to put a bogus integer in a place where the actual
8796 value does not matter.
8797 (LIST_END_P): Remove unused macro and its bogus comment.
8798 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8800 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8801 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8803 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8804 We prefer signed types, and the value cannot exceed the EMACS_INT
8805 range anyway (because otherwise the length would not be representable).
8806 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8807 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8808 This avoids a GCC warning when WIDE_EMACS_INT.
8810 * indent.c (sane_tab_width): New function.
8811 (current_column, scan_for_column, Findent_to, position_indentation)
8812 (compute_motion): Use it. This is just for clarity.
8813 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8815 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8817 * lisp.h (lint_assume): New macro.
8818 * composite.c (composition_gstring_put_cache):
8819 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8821 * editfns.c, insdel.c:
8822 Omit unnecessary forward decls, to simplify future changes.
8824 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8826 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8828 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8829 Use much-faster test for byte-length change.
8830 Don't assume string byte-length fits in 'int'.
8831 Check that character arg fits in 'int'.
8832 (mapcar1): Declare byte as byte, for clarity.
8834 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8836 * fns.c (concat): Catch string overflow earlier.
8837 Do not rely on integer wraparound.
8839 * dispextern.h (struct it.overlay_strings_charpos)
8840 (struct it.selective): Now EMACS_INT, not int.
8841 * xdisp.c (forward_to_next_line_start)
8842 (back_to_previous_visible_line_start)
8843 (reseat_at_next_visible_line_start, next_element_from_buffer):
8844 Don't arbitrarily truncate the value of 'selective' to int.
8846 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8848 * composite.c: Don't truncate sizes to 'int'.
8849 (composition_gstring_p, composition_reseat_it)
8850 (composition_adjust_point): Use EMACS_INT, not int.
8851 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8852 not EMACS_UINT, for indexes.
8854 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8856 * buffer.c: Include <verify.h>.
8857 (struct sortvec.priority, struct sortstr.priority):
8858 Now EMACS_INT, not int.
8859 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8860 (struct sortstr.size, record_overlay_string)
8861 (struct sortstrlist.size, struct sortlist.used):
8862 Don't truncate size to int.
8863 (record_overlay_string): Check for size-calculation overflow.
8864 (init_buffer_once): Check at compile-time, not run-time.
8866 2011-06-22 Jim Meyering <meyering@redhat.com>
8868 Don't leak an XBM-image-sized buffer
8869 * image.c (xbm_load): Free the image buffer after using it.
8871 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8874 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8875 that Sun C diagnosed.
8876 * fns.c (secure_hash): Fix pointer signedness issue.
8877 * intervals.c (static_offset_intervals): New function.
8878 (offset_intervals): Use it.
8880 2011-06-21 Leo Liu <sdl.web@gmail.com>
8883 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8886 * fns.c (secure_hash): Rename from crypto_hash_function and change
8887 the first arg to accept symbols.
8888 (Fsecure_hash): New primitive.
8889 (syms_of_fns): New symbols.
8891 2011-06-20 Deniz Dogan <deniz@dogan.se>
8893 * process.c (Fset_process_buffer): Clarify return value in
8896 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8898 * dispnew.c (add_window_display_history): Use BVAR.
8900 * xdisp.c (debug_method_add): Use BVAR.
8901 (check_window_end, dump_glyph_matrix, dump_glyph)
8902 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8904 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8907 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8908 check till after the cache is created in init_frame_faces.
8910 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8912 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8914 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8916 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8917 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8918 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8920 Improve buffer-overflow checking (Bug#8873).
8921 * fileio.c (Finsert_file_contents):
8922 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8923 Remove the old (too-loose) buffer overflow checks.
8924 They weren't needed, since make_gap checks for buffer overflow.
8925 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8926 The old code merely checked for Emacs fixnum overflow, and relied
8927 on undefined (wraparound) behavior. The new code avoids undefined
8928 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8930 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8931 Tune. Don't use wider integers than needed. Don't use alloca.
8932 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8934 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8936 * insdel.c, lisp.h (buffer_overflow): New function.
8937 (insert_from_buffer_1, replace_range, replace_range_2):
8938 * insdel.c (make_gap_larger):
8939 * editfns.c (Finsert_char):
8940 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8942 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8944 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8946 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8948 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8949 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8951 * fileio.c: Don't assume EMACS_INT fits in off_t.
8952 (emacs_lseek): New static function.
8953 (Finsert_file_contents, Fwrite_region): Use it.
8954 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8956 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8958 * fns.c: Don't overflow int when computing a list length.
8959 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8960 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8961 truncation on 64-bit hosts. Check for QUIT every
8962 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8963 faster and is responsive enough.
8964 (Flength): Report an error instead of overflowing an integer.
8965 (Fsafe_length): Return a float if the value is not representable
8966 as a fixnum. This shouldn't happen except in contrived situations.
8967 (Fnthcdr, Fsort): Don't assume list length fits in int.
8968 (Fcopy_sequence): Don't assume vector length fits in int.
8970 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8971 (header_size, word_size): New constants.
8972 (allocate_vectorlike): Don't check size overflow here.
8973 (allocate_vector): Check it here instead, since this is the only
8974 caller of allocate_vectorlike that could cause overflow.
8975 Check that the new vector's length is representable as a fixnum.
8977 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8978 The previous code was bogus. For example, next_almost_prime (32)
8979 returned 39, which is undesirable as it is a multiple of 3; and
8980 next_almost_prime (24) returned 25, which is a multiple of 5 so
8981 why was the code bothering to check for multiples of 7?
8983 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8985 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8987 Variadic C functions now count arguments with ptrdiff_t.
8988 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8989 Back then I didn't know that the Emacs coding style prefers signed int.
8990 Also, in the meantime I found a few more instances where arguments
8991 were being counted with int, which may truncate counts on 64-bit
8992 machines, or EMACS_INT, which may be unnecessarily wide.
8993 * lisp.h (struct Lisp_Subr.function.aMANY)
8994 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8995 Arg counts are now ptrdiff_t, not size_t.
8996 All variadic functions and their callers changed accordingly.
8997 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8998 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8999 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9000 * callint.c (Fcall_interactively): Check arg count for overflow,
9001 to avoid potential buffer overrun. Use signed char, not 'int',
9002 for 'varies' array, so that we needn't bother to check its size
9003 calculation for overflow.
9004 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9005 * eval.c (apply_lambda):
9006 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9007 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9008 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9010 * callint.c (Fcall_interactively): Don't use index var as event count.
9012 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9013 * mem-limits.h (SIZE): Remove; no longer used.
9015 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9017 Remove unnecessary casts.
9018 * xterm.c (x_term_init):
9019 * xfns.c (x_set_border_pixel):
9020 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9021 These aren't needed now that we assume ANSI C.
9023 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9024 It's more likely to cause problems (due to unsigned overflow)
9027 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9029 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9031 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9033 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9035 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9037 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9039 GLYPH_CODE_FACE returns EMACS_INT, not int.
9040 * dispextern.h (merge_faces):
9041 * xfaces.c (merge_faces):
9042 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9043 Don't assume EMACS_INT fits in int.
9045 * character.h (CHAR_VALID_P): Remove unused parameter.
9046 * fontset.c, lisp.h, xdisp.c: All uses changed.
9048 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9050 * fns.c (concat): Minor tuning based on overflow analysis.
9051 This doesn't fix any bugs. Use int to hold character, instead
9052 of constantly refetching from Emacs object. Use XFASTINT, not
9053 XINT, for value known to be a character. Don't bother comparing
9054 a single byte to 0400, as it's always less.
9056 * floatfns.c (Fexpt):
9057 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9059 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9062 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9064 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9065 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9066 incorrectly succeed when S was a string, because 4294967386 was
9067 truncated before it was used.
9069 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9070 Otherwise, an out-of-range integer could cause undefined behavior
9073 * composite.c: Use int, not EMACS_INT, for characters.
9074 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9075 EMACS_INT, for values that are known to be in character range.
9076 This doesn't fix any bugs but is the usual style inside Emacs and
9077 may generate better code on 32-bit machines.
9079 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9080 This is for reasons similar to the recent CHAR_STRING fix.
9081 * charset.c (Fencode_char): Check that character arg is actually
9082 a character. Pass an int to ENCODE_CHAR.
9083 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9084 wider than 'int', as a compile-time check to prevent future regressions
9087 * character.c (char_string): Remove unnecessary casts.
9089 Make sure a 64-bit char is never passed to CHAR_STRING.
9090 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9091 by silently ignoring the top 32 bits, allowing some values
9092 that were far too large to be valid characters.
9093 * character.h: Include <verify.h>.
9094 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9095 arguments are no wider than unsigned, as a compile-time check
9096 to prevent future regressions in this area.
9098 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9099 (Fsubst_char_in_region):
9101 * xdisp.c (decode_mode_spec_coding):
9102 Adjust to CHAR_STRING's new requirement.
9103 * editfns.c (Finsert_char, Fsubst_char_in_region):
9104 * fns.c (concat): Check that character args are actually
9105 characters. Without this test, these functions did the wrong
9106 thing with wildly out-of-range values on 64-bit hosts.
9108 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9109 These casts should not be needed on 32-bit hosts, either.
9110 * keyboard.c (read_char):
9111 * lread.c (Fload): Remove casts to unsigned.
9113 * lisp.h (UNSIGNED_CMP): New macro.
9114 This fixes comparison bugs on 64-bit hosts.
9115 (ASCII_CHAR_P): Use it.
9116 * casefiddle.c (casify_object):
9117 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9118 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9119 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9120 * dispextern.h (FACE_FROM_ID):
9121 * keyboard.c (read_char): Use UNSIGNED_CMP.
9123 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9124 not to EMACS_INT, to avoid GCC warning.
9126 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9128 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9129 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9130 isn't needed on 32-bit machines.
9132 * buffer.c (Fgenerate_new_buffer_name):
9133 Use EMACS_INT for count, not int.
9134 (advance_to_char_boundary): Return EMACS_INT, not int.
9136 * data.c (Qcompiled_function): Now static.
9138 * window.c (window_body_lines): Now static.
9140 * image.c (gif_load): Rename local to avoid shadowing.
9142 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9143 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9144 * alloc.c (make_save_value): Integer argument is now of type
9146 (mark_object): Use ptrdiff_t, not int.
9147 * lisp.h (pD): New macro.
9148 * print.c (print_object): Use it.
9150 * alloc.c: Use EMACS_INT, not int, to count objects.
9151 (total_conses, total_markers, total_symbols, total_vector_size)
9152 (total_free_conses, total_free_markers, total_free_symbols)
9153 (total_free_floats, total_floats, total_free_intervals)
9154 (total_intervals, total_strings, total_free_strings):
9155 Now EMACS_INT, not int. All uses changed.
9156 (Fgarbage_collect): Compute overall total using a double, so that
9157 integer overflow is less likely to be a problem. Check for overflow
9158 when converting back to an integer.
9159 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9160 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9161 These were 'int' variables that could overflow on 64-bit hosts;
9162 they were never used, so remove them instead of repairing them.
9163 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9164 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9165 Previously, this ceilinged at INT_MAX, but that doesn't work on
9167 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9169 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9170 (allocate_vectorlike): Check for ptrdiff_t overflow.
9171 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9172 when a (possibly-narrower) signed value would do just as well.
9173 We prefer using signed arithmetic, to avoid comparison confusion.
9175 * alloc.c: Catch some string size overflows that we were missing.
9176 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9177 for convenience in STRING_BYTES_MAX.
9178 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9179 The definition here is exact; the one in lisp.h was approximate.
9180 (allocate_string_data): Check for string overflow. This catches
9181 some instances we weren't catching before. Also, it catches
9182 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9183 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9184 and ptrdiff_t and EMACS_INT are both 64 bits.
9186 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9187 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9188 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9190 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9192 * alloc.c (Fmake_string): Check for out-of-range init.
9194 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9196 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9198 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9200 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9201 xg_get_default_scrollbar_width.
9203 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9204 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9205 (style_changed_cb): Call update_theme_scrollbar_width and call
9206 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9207 all frames (Bug#8505).
9208 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9209 Call gtk_window_set_resizable if HAVE_GTK3.
9210 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9211 and height if HAVE_GTK3 (Bug#8505).
9212 (scroll_bar_width_for_theme): New variable.
9213 (update_theme_scrollbar_width): New function.
9214 (xg_get_default_scrollbar_width): Move code to
9215 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9216 (xg_initialize): Call update_theme_scrollbar_width.
9218 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9220 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9222 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9224 * frame.c (make_frame): Call other_buffer_safely instead of
9227 * window.c (temp_output_buffer_show): Call display_buffer with
9228 second argument Vtemp_buffer_show_specifiers and reset latter
9229 immediately after the call.
9230 (Vtemp_buffer_show_specifiers): New variable.
9231 (auto_window_vscroll_p, next_screen_context_lines)
9232 (Vscroll_preserve_screen_position): Remove leading asterisks from
9235 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9237 Fix minor problems found by GCC 4.6.0 static checking.
9238 * buffer.c (Qclone_number): Remove for now, as it's unused.
9239 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9240 (record_buffer): Remove unused local.
9241 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9242 (set_frame_buffer_list): Remove; unused.
9243 * frame.h (other_visible_frames): Remove decl.
9244 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9245 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9246 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9248 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9249 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9250 Define only if HAVE_GPM.
9251 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9252 (update_hints_inhibit): Remove; never set. All uses removed.
9253 * widgetprv.h (emacsFrameClassRec): Remove decl.
9254 * window.c (delete_deletable_window): Now returns void, since it
9255 wasn't returning anything.
9256 (compare_window_configurations): Remove unused locals.
9257 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9258 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9259 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9260 the same widths as pointers. This follows up on the 2011-05-06 patch.
9261 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9262 * xterm.h: Likewise.
9263 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9265 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9267 * makefile.w32-in: Update dependencies.
9268 (LISP_H): Add lib/intprops.h.
9270 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9272 * image.c (gif_load): Add animation frame delay to the metadata.
9273 (syms_of_image): Use DEFSYM. New symbol `delay'.
9275 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9277 * window.c (delete_deletable_window): Re-add.
9278 (Fset_window_configuration): Rewrite to handle dead buffers and
9279 consequently deletable windows.
9280 (window_tree, Fwindow_tree): Remove. Supply functionality in
9282 (compare_window_configurations): Simplify code.
9284 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9286 * image.c (imagemagick_load_image): Fix type mismatch.
9287 (Fimagemagick_types): Likewise.
9289 * window.h (replace_buffer_in_windows): Declare.
9291 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9293 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9294 Qclone_number. Remove external declaration of Qdelete_window.
9295 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9297 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9298 Run Qbuffer_list_update_hook if allowed.
9299 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9300 buffer list implementation.
9301 (other_buffer_safely): New function.
9302 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9303 calls to replace_buffer_in_windows and
9304 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9306 (record_buffer): Inhibit quitting and rewrite using quittable
9307 functions. Run Qbuffer_list_update_hook if allowed.
9308 (Frecord_buffer, Funrecord_buffer): New functions.
9309 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9310 Move switch-to-buffer to window.el.
9311 (bury-buffer): Move to window.el.
9312 (Vbuffer_list_update_hook): New variable.
9314 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9317 * window.h (resize_frame_windows): Move up in code.
9318 (Fwindow_frame): Remove EXFUN.
9319 (replace_buffer_in_all_windows): Remove prototype.
9320 (replace_buffer_in_windows_safely): Add prototype.
9322 * window.c: Declare Qdelete_window static again. Move down
9323 declaration of select_count.
9324 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9325 (Fother_window): Move to window.el.
9326 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9327 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9328 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9330 (replace_buffer_in_windows): Implement by calling
9331 Qreplace_buffer_in_windows.
9332 (replace_buffer_in_all_windows): Remove with some functionality
9333 moved into replace_buffer_in_windows_safely.
9334 (replace_buffer_in_windows_safely): New function.
9335 (select_window_norecord, select_frame_norecord): Move in front
9336 of run_window_configuration_change_hook. Remove now obsolete
9338 (Fset_window_buffer): Rewrite doc-string.
9339 Call Qrecord_window_buffer.
9340 (keys_of_window): Move binding for other-window to window.el.
9342 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9344 * dispextern.h (struct image): Replace data member, whose int_val
9345 and ptr_val fields were not used by anything, with a single
9348 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9349 (gif_clear_image, gif_load, imagemagick_load_image)
9350 (gs_clear_image, gs_load): Callers changed.
9352 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9354 * buffer.h: Include <time.h>, for time_t.
9355 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9357 Fix minor problems found by static checking.
9359 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9361 Make identifiers static if they are not used in other modules.
9362 * data.c (Qcompiled_function, Qframe, Qvector):
9363 * image.c (QimageMagick, Qsvg):
9364 * minibuf.c (Qmetadata):
9365 * window.c (resize_window_check, resize_root_window): Now static.
9366 * window.h (resize_window_check, resize_root_window): Remove decls.
9368 * window.c (window_deletion_count, delete_deletable_window):
9370 (window_body_lines): Now static.
9371 (Fdelete_other_windows_internal): Mark vars as initialized.
9372 Make sure 'resize_failed' is initialized.
9373 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9374 (resize_window_apply): Remove unused local.
9375 * window.h (delete_deletable_window): Remove decl.
9377 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9378 (imagemagick_load_image): Fix pointer signedness problem by changing
9379 last arg from unsigned char * to char *. All uses changed.
9380 Also, fix a local for similar reasons.
9381 Remove unused locals. Remove locals to avoid shadowing.
9382 (fn_rsvg_handle_free): Remove; unused.
9383 (svg_load, svg_load_image): Fix pointer signedness problem.
9384 (imagemagick_load_image): Don't use garbage pointer image_wand.
9386 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9388 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9390 * image.c (gif_load): Fix omitted cast error introduced by
9393 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9395 * window.h (resize_proportionally, orig_total_lines)
9396 (orig_top_line): Remove from window structure.
9397 (set_window_height, set_window_width, change_window_heights)
9398 (Fdelete_window): Remove prototypes.
9399 (resize_frame_windows): Remove duplicate declaration.
9401 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9403 * window.h (resize_frame_windows, resize_window_check)
9404 (delete_deletable_window, resize_root_window)
9405 (resize_frame_windows): Declare prototypes.
9407 * window.c (resize_window_apply): Make definition be "static" to
9408 match the prototype.
9410 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9412 * window.c: Remove declarations of Qwindow_size_fixed,
9413 window_min_size_1, window_min_size_2, window_min_size,
9414 size_window, window_fixed_size_p, enlarge_window, delete_window.
9415 Remove static from declaration of Qdelete_window, it's
9416 temporarily needed by Fbury_buffer.
9417 (replace_window): Don't assign orig_top_line and
9419 (Fdelete_window, delete_window): Remove. Window deletion is
9420 handled by window.el.
9421 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9422 Replace Fdelete_window calls with calls to Qdelete_window.
9423 (Fdelete_other_windows): Remove. Deleting other windows is
9424 handled by window.el.
9425 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9426 handled in window.el.
9427 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9428 Window minimum sizes are handled in window.el.
9429 (shrink_windows, size_window, set_window_height)
9430 (set_window_width, change_window_heights, window_height)
9431 (window_width, CURBEG, CURSIZE, enlarge_window)
9432 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9433 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9434 handled in window.el.
9435 (make_dummy_parent): Rename to make_parent_window and give it a
9436 second argument horflag.
9437 (make_window): Don't set resize_proportionally any more.
9438 (Fsplit_window): Remove. Windows are split in window.el.
9439 (save_restore_action, save_restore_orig_size)
9440 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9441 Resize mini windows in window.el.
9442 (grow_mini_window, shrink_mini_window): Implement by calling
9443 Qresize_root_window_vertically, resize_window_check and
9444 resize_window_apply.
9445 (saved_window, Fset_window_configuration, save_window_save):
9446 Do not handle orig_top_line, orig_total_lines, and
9447 resize_proportionally.
9448 (window_min_height, window_min_width): Move to window.el.
9449 (keys_of_window): Move bindings for delete-other-windows,
9450 split-window, delete-window and enlarge-window to window.el.
9452 * buffer.c: Temporarily extern Qdelete_window.
9453 (Fbury_buffer): Temporarily call Qdelete_window instead of
9454 Fdelete_window (Fbury_buffer will move to window.el soon).
9456 * frame.c (set_menu_bar_lines_1): Remove code handling
9457 orig_top_line and orig_total_lines.
9459 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9460 set_window_height but set heights directly.
9461 (change_frame_size_1): Use resize_frame_windows.
9463 * xdisp.c (init_xdisp): Don't use set_window_height but set
9466 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9467 Use resize_frame_windows instead of change_window_heights and run
9468 run_window_configuration_change_hook.
9470 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9471 instead of change_window_heights and run
9472 run_window_configuration_change_hook.
9474 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9476 * window.c (replace_window): Rename second argument REPLACEMENT to
9477 NEW. New third argument SETFLAG. Rewrite.
9478 (delete_window, make_dummy_parent): Call replace_window with
9480 (window_list_1): Move down in code.
9481 (run_window_configuration_change_hook): Move set_buffer part
9482 before select_frame_norecord part in order to unwind correctly.
9483 Rename count1 to count.
9484 (recombine_windows, delete_deletable_window, resize_root_window)
9485 (Fdelete_other_windows_internal)
9486 (Frun_window_configuration_change_hook, make_parent_window)
9487 (resize_window_check, resize_window_apply, Fresize_window_apply)
9488 (resize_frame_windows, Fsplit_window_internal)
9489 (Fdelete_window_internal, Fresize_mini_window_internal):
9491 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9493 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9495 * window.h (window): Add some new members to window structure -
9496 normal_lines, normal_cols, new_total, new_normal, clone_number,
9497 splits, nest, prev_buffers, next_buffers.
9498 (WINDOW_TOTAL_SIZE): Move here from window.c.
9499 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9501 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9503 (make_dummy_parent): Set new members of windows structure.
9504 (make_window): Move down in code. Handle new members of window
9506 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9507 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9508 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9509 (Fset_window_prev_buffers, Fwindow_next_buffers)
9510 (Fset_window_next_buffers, Fset_window_clone_number):
9512 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9513 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9515 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9516 Argument WINDOW can be now internal window too.
9517 (Fwindow_use_time): Move up in code.
9518 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9520 (Fset_window_configuration, saved_window)
9521 (Fcurrent_window_configuration, save_window_save): Handle new
9522 members of window structure.
9523 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9524 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9525 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9526 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9527 Qget_mru_window, Qresize_root_window,
9528 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9529 Qauto_buffer_name; staticpro them.
9531 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9533 * window.c (Fwindow_total_size, Fwindow_left_column)
9534 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9535 (Fwindow_list_1): New functions.
9536 (window_box_text_cols): Replace with window_body_cols.
9537 (Fwindow_width, Fscroll_left, Fscroll_right):
9538 Use window_body_cols instead of window_box_text_cols.
9539 (delete_window, Fset_window_configuration):
9540 Call delete_all_subwindows with window as argument.
9541 (delete_all_subwindows): Take a window as argument and not a
9543 (window_loop): Remove handling of GET_LRU_WINDOW and
9545 (Fget_lru_window, Fget_largest_window): Move to window.el.
9547 * window.h: Extern window_body_cols instead of
9548 window_box_text_cols. delete_all_subwindows now takes a
9549 Lisp_Object as argument.
9551 * indent.c (compute_motion, Fcompute_motion):
9552 Use window_body_cols instead of window_box_text_cols.
9554 * frame.c (delete_frame): Call delete_all_subwindows with root
9557 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9559 * fns.c (Fputhash): Document return value.
9561 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9563 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9565 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9567 Cons<->int and similar integer overflow fixes (Bug#8794).
9569 Check for overflow when converting integer to cons and back.
9570 * charset.c (Fdefine_charset_internal, Fdecode_char):
9571 Use cons_to_unsigned to catch overflow.
9572 (Fencode_char): Use INTEGER_TO_CONS.
9573 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9574 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9575 * data.c (long_to_cons, cons_to_long): Remove.
9576 (cons_to_unsigned, cons_to_signed): New functions.
9577 These signal an error for invalid or out-of-range values.
9578 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9579 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9580 * font.c (Ffont_variation_glyphs):
9581 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9582 * lisp.h: Include <intprops.h>.
9583 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9584 (cons_to_signed, cons_to_unsigned): New decls.
9585 (long_to_cons, cons_to_long): Remove decls.
9586 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9587 (Fprimitive_undo): Use CONS_TO_INTEGER.
9588 * xfns.c (Fx_window_property): Likewise.
9589 * xselect.c: Include <limits.h>.
9590 (x_own_selection, selection_data_to_lisp_data):
9591 Use INTEGER_TO_CONS.
9592 (x_handle_selection_request, x_handle_selection_clear)
9593 (x_get_foreign_selection, Fx_disown_selection_internal)
9594 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9595 (lisp_data_to_selection_data): Use cons_to_unsigned.
9596 (x_fill_property_data): Use cons_to_signed.
9597 Report values out of range.
9599 Check for buffer and string overflow more precisely.
9600 * buffer.h (BUF_BYTES_MAX): New macro.
9601 * lisp.h (STRING_BYTES_MAX): New macro.
9602 * alloc.c (Fmake_string):
9603 * character.c (string_escape_byte8):
9604 * coding.c (coding_alloc_by_realloc):
9605 * doprnt.c (doprnt):
9606 * editfns.c (Fformat):
9608 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9609 since they may not be the same number.
9610 * editfns.c (Finsert_char):
9611 * fileio.c (Finsert_file_contents):
9612 Likewise for BUF_BYTES_MAX.
9614 * image.c: Use ptrdiff_t, not int, for sizes.
9615 (slurp_file): Switch from int to ptrdiff_t.
9617 (slurp_file): Check that file size fits in both size_t (for
9618 malloc) and ptrdiff_t (for sanity and safety).
9620 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9621 if b->modtime has its maximal value.
9623 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9625 Don't assume time_t can fit into int.
9626 * buffer.h (struct buffer.modtime): Now time_t, not int.
9627 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9628 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9630 Minor fixes for signed vs unsigned integers.
9631 * character.h (MAYBE_UNIFY_CHAR):
9632 * charset.c (maybe_unify_char):
9633 * keyboard.c (read_char, reorder_modifiers):
9634 XINT -> XFASTINT, since the integer must be nonnegative.
9635 * ftfont.c (ftfont_spec_pattern):
9636 * keymap.c (access_keymap, silly_event_symbol_error):
9637 XUINT -> XFASTINT, since the integer must be nonnegative.
9638 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9639 since it makes no difference and we prefer signed.
9640 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9641 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9644 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9646 * window.h (Fwindow_frame): Declare.
9648 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9650 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9651 (SPARE_MEMORY): Always define.
9652 (LARGE_REQUEST): Remove.
9653 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9655 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9657 * lisp.h: Move EXFUNS for Fframe_root_window,
9658 Fframe_first_window and Fset_frame_selected_window to window.h.
9660 * window.h: Move EXFUNS for Fframe_root_window,
9661 Fframe_first_window and Fset_frame_selected_window here from
9664 * frame.c (Fwindow_frame, Fframe_first_window)
9665 (Fframe_root_window, Fframe_selected_window)
9666 (Fset_frame_selected_window): Move to window.c.
9667 (Factive_minibuffer_window): Move to minibuf.c.
9668 (Fother_visible_frames_p): New function.
9670 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9672 * window.c (decode_window, decode_any_window): Move up in code.
9673 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9674 (inhibit_frame_unsplittable): Remove unused variable.
9675 (Fwindow_buffer): Move up and rewrite doc-string.
9676 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9677 (Fwindow_prev): New functions.
9678 (Fwindow_frame): Move here from frame.c. Accept any window as
9680 (Fframe_root_window, Fframe_first_window)
9681 (Fframe_selected_window): Move here from frame.c. Accept frame
9682 or arbitrary window as argument. Update doc-strings.
9683 (Fminibuffer_window): Move up in code.
9684 (Fwindow_minibuffer_p): Move up in code and simplify.
9685 (Fset_frame_selected_window): Move here from frame.c.
9687 (Fselected_window, select_window, Fselect_window): Move up in
9688 code. Minor doc-string fixes.
9690 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9692 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9693 Do not assume that spare memory exists; that assumption is valid
9694 only if SYSTEM_MALLOC.
9695 (LARGE_REQUEST): New macro, so that the issue of large requests
9696 is separated from the issue of spare memory.
9698 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9700 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9703 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9705 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9708 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9710 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9712 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9714 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9715 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9717 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9719 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9721 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9723 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9724 (x_clipboard_manager_save): Add return value.
9725 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9727 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9728 Obey Vx_select_enable_clipboard_manager. Catch errors in
9729 x_clipboard_manager_save (Bug#8779).
9730 (Vx_select_enable_clipboard_manager): New variable.
9731 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9733 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9735 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9737 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9739 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9740 in the current matrix if keep_current_p is non-zero.
9742 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9744 * bidi.c (bidi_level_of_next_char): Fix last change.
9746 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9748 Support bidi reordering of text covered by display properties.
9750 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9751 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9752 (bidi_cache_search, bidi_cache_iterator_state)
9753 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9754 (bidi_level_of_next_char, bidi_move_to_visually_next):
9755 Support character positions inside a run of characters covered by a
9757 (bidi_paragraph_init, bidi_resolve_explicit_1)
9758 (bidi_level_of_next_char): Call bidi_fetch_char and
9759 bidi_fetch_char_advance instead of FETCH_CHAR and
9761 (bidi_init_it): Initialize new members.
9762 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9764 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9765 instead of using explicit *_CHAR codes.
9766 (bidi_resolve_explicit, bidi_resolve_weak):
9767 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9768 bidirectional text is supported only in multibyte buffers.
9769 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9770 it to initialize the frame_window_p member of struct bidi_it.
9771 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9772 (bidi_resolve_explicit, bidi_resolve_weak)
9773 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9774 bidi_it->nchars is non-positive.
9775 (bidi_level_of_next_char): Don't try to lookup the cache for the
9776 next/previous character if nothing is cached there yet, or if we
9777 were just reseat()'ed to a new position.
9779 * xdisp.c (set_cursor_from_row): Set start and stop points
9780 according to the row's direction when priming the loop that looks
9781 for the glyph on which to display cursor.
9782 (single_display_spec_intangible_p): Function deleted.
9783 (display_prop_intangible_p): Reimplement to call
9784 handle_display_spec instead of single_display_spec_intangible_p.
9785 Accept 3 additional arguments needed by handle_display_spec.
9786 This fixes incorrect cursor motion across display property with complex
9787 values: lists, `(when COND...)' forms, etc.
9788 (single_display_spec_string_p): Support property values that are
9789 lists with the argument STRING its top-level element.
9790 (display_prop_string_p): Fix the condition for processing a
9791 property that is a list to be consistent with handle_display_spec.
9792 (handle_display_spec): New function, refactored from the
9793 last portion of handle_display_prop.
9794 (compute_display_string_pos): Accept additional argument
9795 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9796 value of a `display' property is a "replacing spec".
9797 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9798 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9799 the display property, but just return a value indicating whether
9800 the display property will replace the characters it covers.
9801 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9802 frame_window_p members of struct bidi_it.
9803 (compute_display_string_pos, compute_display_string_end):
9805 (push_it): Accept second argument POSITION, where pop_it should
9806 jump to continue iteration.
9807 (reseat_1): Initialize bidi_it.disp_pos.
9809 * keyboard.c (adjust_point_for_property): Adjust the call to
9810 display_prop_intangible_p to its new signature.
9812 * dispextern.h (struct bidi_it): New member frame_window_p.
9813 (bidi_init_it): Update prototypes.
9814 (display_prop_intangible_p): Update prototype.
9815 (compute_display_string_pos, compute_display_string_end):
9817 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9820 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9822 Malloc failure behavior now depends on size of allocation.
9823 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9824 * lisp.h: Change signatures accordingly.
9825 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9826 All callers changed. (Bug#8762)
9828 * gnutls.c: Use Emacs's memory allocators.
9829 Without this change, the gnutls library would invoke malloc etc.
9830 directly, which causes problems on non-SYNC_INPUT hosts, and which
9831 runs afoul of improving memory_full behavior. (Bug#8761)
9832 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9833 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9834 xfree instead of the default malloc, realloc, free.
9835 (Fgnutls_boot): No need to check for memory allocation failure,
9836 since xmalloc does that for us.
9838 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9839 * category.c (hash_get_category_set):
9840 * ccl.c (ccl_driver):
9841 * charset.c (Fdefine_charset_internal):
9842 * charset.h (struct charset.hash_index):
9843 * composite.c (get_composition_id, gstring_lookup_cache)
9844 (composition_gstring_put_cache):
9845 * composite.h (struct composition.hash_index):
9846 * dispextern.h (struct image.hash):
9847 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9848 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9849 (hashfn_equal, hashfn_user_defined, make_hash_table)
9850 (maybe_resize_hash_table, hash_lookup, hash_put)
9851 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9852 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9853 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9854 * image.c (make_image, search_image_cache, lookup_image)
9855 (xpm_put_color_table_h):
9856 * lisp.h (struct Lisp_Hash_Table):
9857 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9858 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9859 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9860 * alloc.c (allocate_vectorlike):
9861 Check for overflow in vector size calculations.
9862 * ccl.c (ccl_driver):
9863 Check for overflow when converting EMACS_INT to int.
9864 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9865 need to be updated by these changes.
9866 * fns.c (make_hash_table, maybe_resize_hash_table):
9867 Check for integer overflow with large hash tables.
9868 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9869 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9870 (SXHASH_REDUCE): New macro.
9871 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9872 Use it instead of discarding useful hash info with large hash values.
9873 (sxhash_float): New function.
9874 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9875 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9876 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9877 Rewrite to use FIXNUM_BITS, as this simplifies things.
9878 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9879 Adjust signatures to match updated version of code.
9880 (consing_since_gc): Now EMACS_INT, since a single hash table can
9881 use more than INT_MAX bytes.
9883 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9885 Make it possible to build with GCC-4.6+ -O2 -flto.
9887 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9889 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9891 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9892 Call minibuffer-inactive-mode.
9894 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9896 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9897 Update dependencies.
9899 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9901 * data.c (init_data): Remove code for UTS, this system is not
9904 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9906 Don't force ./temacs to start in terminal mode.
9908 * frame.c (make_initial_frame): Initialize faces in all cases, not
9909 only when CANNOT_DUMP is defined.
9910 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9912 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9914 * dispnew.c (add_window_display_history): Use const for the string
9915 pointer. Remove declaration, not needed.
9917 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9919 Use 'inline', not 'INLINE'.
9920 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9921 * alloc.c, fontset.c (INLINE): Remove.
9922 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9923 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9924 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9925 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9926 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9928 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9930 Make it possible to run ./temacs.
9932 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9933 syms_of_callproc does the same thing. Remove test for
9934 "initialized", do it in the caller.
9935 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9937 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9939 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9940 (read_minibuf): Use get_minibuffer.
9941 (syms_of_minibuf): Use DEFSYM.
9942 (Qmetadata): New var.
9943 * data.c (Qbuffer): Don't make it static.
9944 (syms_of_data): Use DEFSYM.
9946 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9948 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9949 (CCL_CODE_MIN): New macro.
9951 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9953 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9955 * eval.c (Qdebug): Now static.
9956 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9957 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9958 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9960 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9962 * image.c: Various fixes to ImageMagick code comments.
9963 (Fimagemagick_types): Doc fix.
9965 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9967 Minor fixes prompted by GCC 4.6.0 warnings.
9969 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9971 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9972 (x_clipboard_manager_save_all): Move extern decl to ...
9973 * xterm.h: ... here, so that it can be checked for consistency.
9975 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9977 * xselect.c (x_clipboard_manager_save_frame)
9978 (x_clipboard_manager_save_all): New functions.
9979 (Fx_clipboard_manager_save): Lisp function deleted.
9981 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9982 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9984 * xterm.h: Update prototype.
9986 2011-05-28 William Xu <william.xwl@gmail.com>
9988 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9991 2011-05-28 Jim Meyering <meyering@redhat.com>
9993 Avoid a sign-extension bug in crypto_hash_function.
9994 * fns.c (to_uchar): Define.
9995 (crypto_hash_function): Use it to convert some newly-signed
9996 variables to unsigned, to avoid sign-extension bugs. For example,
9997 without this change, (md5 "truc") would evaluate to
9998 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9999 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10000 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10002 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10004 Integer overflow fixes.
10006 * dbusbind.c: Serial number integer overflow fixes.
10007 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10008 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10009 to hold a serial number that is too large for a fixnum.
10010 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10011 Check for serial numbers out of range. Decode any serial number
10012 that was so large that it became a float. (Bug#8722)
10014 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10015 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10016 Use XFASTINT rather than XUINT when numbers are nonnegative.
10017 (xd_append_arg, Fdbus_method_return_internal):
10018 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10019 arguments, check that Lisp number is nonnegative, rather than
10020 silently wrapping negative numbers around. (Bug#8722)
10021 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10024 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10026 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10028 ccl: Add integer overflow checks.
10029 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10030 (IN_INT_RANGE): New macros.
10031 (ccl_driver): Use them to check for integer overflow when
10032 decoding a CCL program. Many of the new checks are whether XINT (x)
10033 fits in int; it doesn't always, on 64-bit hosts. The new version
10034 doesn't catch all possible integer overflows, but it's an
10035 improvement. (Bug#8719)
10037 * alloc.c (make_event_array): Use XINT, not XUINT.
10038 There's no need for unsigned here.
10040 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10041 This follows up to the 2011-05-06 change that substituted uintptr_t
10042 for EMACS_INT. This case wasn't caught back then.
10044 Rework Fformat to avoid integer overflow issues.
10045 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10046 now (part of C89). Include <verify.h>.
10047 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10048 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10049 (Fformat): Avoid the prepass trying to compute sizes; it was only
10050 approximate and thus did not catch overflow reliably. Instead, walk
10051 through the format just once, formatting and computing sizes as we go,
10052 checking for integer overflow at every step, and allocating a larger
10053 buffer as needed. Keep track separately whether the format is
10054 multibyte. Keep only the most-recently calculated precision, rather
10055 than them all. Record whether each argument has been converted to
10056 string. Use EMACS_INT, not int, for byte and char and arg counts.
10057 Support field widths and precisions larger than INT_MAX. Avoid
10058 sprintf's undefined behavior with conversion specifications such as %#d
10059 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10060 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10061 formatting out-of-range floating point numbers with int
10062 formats. (Bug#8668)
10064 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10066 * data.c: Avoid integer truncation in expressions involving floats.
10067 * data.c: Include <intprops.h>.
10068 (arith_driver): When there's an integer overflow in an expression
10069 involving floating point, convert the integers to floating point
10070 so that the resulting value does not suffer from catastrophic
10071 integer truncation. For example, on a 64-bit host (* 4
10072 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10073 Do not rely on undefined behavior after integer overflow.
10075 merge count_size_as_multibyte, parse_str_to_multibyte
10076 * character.c, character.h (count_size_as_multibyte):
10077 Rename from parse_str_to_multibyte; all uses changed.
10078 Check for integer overflow.
10079 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10080 since it's now a duplicate of the other. This is more of
10081 a character than a buffer op, so better that it's in character.c.
10082 * fns.c, print.c: Adjust to above changes.
10084 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10086 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10088 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10090 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10091 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10092 (x_clipboard_manager_save): Now static.
10093 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10095 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10096 (crypto_hash_function): Now static.
10097 Fix pointer signedness problems. Avoid unnecessary initializations.
10099 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10101 * termhooks.h (Vselection_alist): Make it terminal-local.
10103 * terminal.c (create_terminal): Initialize it.
10105 * xselect.c: Support for clipboard managers.
10106 (Vselection_alist): Move to termhooks.h as terminal-local var.
10107 (LOCAL_SELECTION): New macro.
10108 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10109 (symbol_to_x_atom): Remove gratuitous arg.
10110 (x_handle_selection_request, lisp_data_to_selection_data)
10111 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10112 (x_own_selection, x_get_local_selection, x_convert_selection):
10113 New arg, specifying work frame. Use terminal-local Vselection_alist.
10114 (some_frame_on_display): Delete unused function.
10115 (Fx_own_selection_internal, Fx_get_selection_internal)
10116 (Fx_disown_selection_internal, Fx_selection_owner_p)
10117 (Fx_selection_exists_p): New optional frame arg.
10118 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10119 (x_handle_selection_clear): Don't treat other terminals with the
10120 same keyboard specially. Use the terminal-local Vselection_alist.
10121 (x_clear_frame_selections): Use Frun_hook_with_args.
10123 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10125 * xterm.h: Add support for those atoms.
10127 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10129 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10130 (converted_selections, conversion_fail_tag): New global variables.
10131 (x_selection_request_lisp_error): Free the above.
10132 (x_get_local_selection): Remove unnecessary code.
10133 (x_reply_selection_request): Args changed; handle arbitrary array
10134 of converted selections stored in converted_selections.
10135 Separate the XChangeProperty and SelectionNotify steps.
10136 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10137 (x_convert_selection): New function.
10138 (x_handle_selection_event): Simplify.
10139 (x_get_foreign_selection): Don't ignore incoming requests while
10140 waiting for an answer; this will fail when we implement
10141 SAVE_TARGETS, and seems unnecessary anyway.
10142 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10143 (Vx_sent_selection_functions): Doc fix.
10145 2011-05-26 Leo Liu <sdl.web@gmail.com>
10147 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10149 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10151 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10153 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10154 for fringe update if it has periodic bitmap.
10155 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10156 and fringe_bitmap_periodic_p.
10158 * fringe.c (get_fringe_bitmap_data): New function.
10159 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10160 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10161 row. Mark glyph row for fringe update if periodicity changed.
10163 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10164 for fringe update unless it has periodic bitmap.
10166 2011-05-25 Kenichi Handa <handa@m17n.org>
10168 * xdisp.c (get_next_display_element): Set correct it->face_id for
10169 a static composition.
10171 2011-05-24 Leo Liu <sdl.web@gmail.com>
10174 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10176 * fns.c (crypto_hash_function, Fsha1): New function.
10177 (Fmd5): Use crypto_hash_function.
10178 (syms_of_fns): Add Ssha1.
10180 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10182 * gnutls.c: Remove unused macros.
10183 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10184 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10185 Remove macros that are defined and never used.
10186 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10188 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10190 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10191 (Fx_get_selection_internal): Minor cleanup.
10192 (Fx_own_selection_internal): Rename arguments for consistency with
10195 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10197 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10199 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10201 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10203 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10205 * dispnew.c (scrolling_window): Don't exclude the case that the
10206 last enabled row in the desired matrix touches the bottom boundary.
10208 2011-05-21 Glenn Morris <rgm@gnu.org>
10210 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10211 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10212 and add some more files.
10214 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10216 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10217 report_file_error introduced by the change from 2011-05-07.
10219 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10221 * systime.h (Time): Define only if emacs is defined.
10222 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10223 where the include path doesn't have X11/X.h by default. See
10224 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10226 2011-05-20 Kenichi Handa <handa@m17n.org>
10228 * composite.c (find_automatic_composition): Fix previous change.
10230 2011-05-20 Glenn Morris <rgm@gnu.org>
10232 * lisp.mk: New file, split from Makefile.in.
10233 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10234 (shortlisp): Remove.
10235 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10237 2011-05-19 Glenn Morris <rgm@gnu.org>
10239 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10240 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10241 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10242 (lisp): Set the order to that of loadup.el.
10243 (shortlisp): Make it a copy of $lisp.
10244 (SOME_MACHINE_LISP): Remove.
10245 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10246 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10248 2011-05-18 Kenichi Handa <handa@m17n.org>
10250 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10251 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10252 (find_automatic_composition): Mostly rewrite for efficiency.
10254 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10256 * makefile.w32-in: Update dependencies.
10258 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10260 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10261 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10263 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10265 Fix some integer overflow issues, such as string length overflow.
10267 * insdel.c (count_size_as_multibyte): Check for string overflow.
10269 * character.c (lisp_string_width): Check for string overflow.
10270 Use EMACS_INT, not int, for string indexes and lengths; in
10271 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10272 the resulting string length overflows an EMACS_INT; instead,
10273 report a string overflow if no precision given. When checking for
10274 precision exhaustion, use a check that cannot possibly have
10275 integer overflow. (Bug#8675)
10276 * character.h (lisp_string_width): Adjust to new signature.
10278 * alloc.c (string_overflow): New function.
10279 (Fmake_string): Use it. This doesn't change behavior, but saves
10280 a few bytes and will simplify future changes.
10281 * character.c (string_escape_byte8): Likewise.
10282 * lisp.h (string_overflow): New decl.
10284 Fixups, following up to the user-interface timestamp change.
10285 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10286 for UI timestamps, instead of unsigned long.
10287 * msdos.c (mouse_get_pos): Likewise.
10288 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10289 * w32gui.h (Time): Define by including "systime.h" rather than by
10290 declaring it ourselves. (Bug#8664)
10292 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10293 * image.c (clear_image_cache): Likewise.
10295 * term.c (term_mouse_position): Don't assume time_t wraparound.
10297 Be more systematic about user-interface timestamps.
10298 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10299 and sometimes 'EMACS_UINT', to represent these timestamps.
10300 This change causes it to use 'Time' uniformly, as that's what X uses.
10301 This makes the code easier to follow, and makes it easier to catch
10302 integer overflow bugs such as Bug#8664.
10303 * frame.c (Fmouse_position, Fmouse_pixel_position):
10304 Use Time, not unsigned long, for user-interface timestamps.
10305 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10306 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10307 * keyboard.h (last_event_timestamp): Likewise.
10308 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10309 * menu.h (xmenu_show): Likewise.
10310 * term.c (term_mouse_position): Likewise.
10311 * termhooks.h (struct input_event.timestamp): Likewise.
10312 (struct terminal.mouse_position_hook): Likewise.
10313 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10314 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10315 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10316 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10317 what it was before.
10318 * menu.h, termhooks.h: Include "systime.h", for Time.
10320 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10321 Don't assume that the difference between two unsigned long values
10322 can fit into an integer. At this point, we know button_down_time
10323 <= event->timestamp, so the difference must be nonnegative, so
10324 there's no need to cast the result if double-click-time is
10325 nonnegative, as it should be; check that it's nonnegative, just in
10326 case. This bug is triggered when events are more than 2**31 ms
10327 apart (about 25 days). (Bug#8664)
10329 * xselect.c (last_event_timestamp): Remove duplicate decl.
10330 (x_own_selection): Remove needless cast to unsigned long.
10332 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10333 that always fit in int. Use a sentinel instead of a counter, to
10334 avoid a temp and to allay GCC's concerns about possible int overflow.
10335 * frame.h (struct frame): Use int for menu_bar_items_used
10336 instead of EMACS_INT, since it always fits in int.
10338 * menu.c (grow_menu_items): Check for int overflow.
10340 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10342 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10343 Before, the code was not consistent. These values cannot exceed
10344 2**31 - 1 so there's no need to make them unsigned.
10345 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10346 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10347 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10349 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10351 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10352 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10353 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10354 presumably because the widths might not match.
10356 * window.c (size_window): Avoid needless test at loop start.
10358 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10360 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10362 2011-05-12 Drew Adams <drew.adams@oracle.com>
10364 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10366 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10368 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10369 `width' to `bar_area_x' and `bar_area_width', respectively.
10370 (x_scroll_run): Take account of fringe background extension.
10372 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10373 Rename local vars `left' and `width' to `bar_area_x' and
10374 `bar_area_width', respectively.
10375 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10376 background extension.
10378 2011-05-10 Jim Meyering <meyering@redhat.com>
10380 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10382 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10384 * image.c (Finit_image_library): Return t for built-in image types,
10385 like pbm and xbm. (Bug#8640)
10387 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10389 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10391 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10393 * w32console.c (Fset_screen_color): Doc fix.
10394 (Fget_screen_color): New function.
10395 (syms_of_ntterm): Defsubr it.
10397 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10398 unlink the temporary file if Fcall_process didn't create it in the
10400 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10401 child process will be redirected to a file specified with `:file'.
10402 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10403 cue to call_process_cleanup not to close that handle.
10405 2011-05-07 Ben Key <bkey76@gmail.com>
10407 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10408 one of two shell specific rules, either bootstrap-temacs-CMD or
10409 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10410 to the previous implementation of the bootstrap-temacs rule.
10411 The bootstrap-temacs-CMD rule is similar to the previous
10412 implementation of the bootstrap-temacs rule except that it
10413 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10416 These changes, along with some changes to nt/configure.bat,
10417 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10418 earlier fix to add support for --cflags and --ldflags options
10419 that include quotes so that it works whether make uses cmd or
10422 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10424 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10425 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10427 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10428 a string. Handle both cases.
10429 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10430 (Fdbus_register_method): Use Qinvalid_function.
10432 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10434 * makefile.w32-in: Update dependencies.
10435 (LISP_H): Add inttypes.h and stdin.h.
10436 (PROCESS_H): Add unistd.h.
10438 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10440 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10441 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10443 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10445 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10447 * term.c (vfatal): Remove stray call to va_end.
10448 It's not needed and the C Standard doesn't allow it here anyway.
10450 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10451 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10453 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10456 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10458 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10460 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10462 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10464 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10466 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10467 * charset.c (Fdefine_charset_internal): Don't initialize
10468 charset.code_space[15]. The value was garbage, on hosts with
10469 32-bit int (Bug#8600).
10471 * lread.c (read_integer): Be more consistent with string-to-number.
10472 Use string_to_number to do the actual conversion; this avoids
10473 rounding errors and fixes some other screwups. Without this fix,
10474 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10475 (digit_to_number): Move earlier, for benefit of read_integer.
10476 Return -1 if the digit is out of range for the base, -2 if it is
10477 not a digit in any supported base. (Bug#8602)
10479 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10481 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10482 to match comment at start of function. This also removes a
10483 GCC warning about overflow in a 32+64-bit port.
10485 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10487 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10488 Reported by Stefan Monnier in
10489 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10490 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10491 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10493 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10494 (EMACS_UINTPTR): Likewise, with uintptr_t.
10496 * lisp.h: Prefer 64-bit EMACS_INT if available.
10497 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10498 on 32-bit hosts that have 64-bit int, so that they can access
10500 However, temporarily disable this change unless the temporary
10501 symbol WIDE_EMACS_INT is defined.
10503 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10505 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10506 This removes an assumption that EMACS_INT and long are the same
10507 width as pointers. The assumption is true for Emacs porting targets
10508 now, but we want to make other targets possible.
10509 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10510 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10511 In the rest of the code, change types of integers that hold casted
10512 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10513 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10514 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10515 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10516 No need to cast type when ORing.
10517 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10518 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10519 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10520 assume EMACS_INT is the same width as char *.
10521 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10522 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10523 Remove no-longer-needed casts.
10524 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10525 (xg_tool_bar_help_callback, xg_make_tool_item):
10526 Use EMACS_INTPTR to hold an integer
10527 that will be cast to void *; this can avoid a GCC warning
10528 if EMACS_INT is not the same width as void *.
10529 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10530 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10531 (current_message_1, set_message_1):
10532 Use a local to convert to proper width without a cast.
10533 * xmenu.c (dialog_selection_callback): Likewise.
10535 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10536 Also, don't assume VALBITS / RAND_BITS is less than 5,
10537 and don't rely on undefined behavior when shifting a 1 left into
10539 * lisp.h (get_random): Change signature to match.
10541 * lread.c (hash_string): Use size_t, not int, for hash computation.
10542 Normally we prefer signed values; but hashing is special, because
10543 it's better to use unsigned division on hash table sizes so that
10544 the remainder is nonnegative. Also, size_t is the natural width
10545 for hashing into memory. The previous code used 'int', which doesn't
10546 retain enough info to hash well into very large tables.
10547 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10549 * dbusbind.c: Don't possibly lose pointer info when converting.
10550 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10551 Use XPNTR rather than XHASH, so that the high-order bits of
10552 the pointer aren't lost when converting through void *.
10554 * eval.c (Fautoload): Don't double-shift a pointer.
10556 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10558 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10560 * gnutls.c (DEF_GNUTLS_FN):
10561 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10563 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10565 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10568 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10570 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10571 New version that can reserve upto 2GB of heap space.
10573 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10575 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10577 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10579 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10580 `gnutls_certificate_set_x509_key_file'.
10582 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10584 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10585 Update dependencies.
10587 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10589 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10590 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10591 Remove unused parameter `fildes'.
10592 * process.c (read_process_output, send_process): Don't pass it.
10594 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10596 Fix previous change: the library cache is defined in w32.c.
10597 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10598 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10600 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10602 Implement dynamic loading of GnuTLS on Windows.
10604 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10605 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10606 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10609 * gnutls.c (Qgnutls_dll): Define.
10610 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10611 (gnutls_*): Declare function pointers.
10612 (init_gnutls_functions): New function to initialize function pointers.
10613 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10614 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10615 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10616 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10617 (emacs_gnutls_write, emacs_gnutls_read)
10618 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10619 (Fgnutls_available_p): New function.
10620 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10621 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10622 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10624 * image.c: Include w32.h.
10625 (Vimage_type_cache): Delete.
10626 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10627 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10628 (w32_delayed_load): Move to w32.c.
10630 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10632 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10633 (w32_delayed_load): Move from image.c. When loading a library, record
10634 its filename in the :loaded-from property of the library id.
10635 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10636 Initialize and staticpro them.
10637 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10639 * process.c: Include lisp.h before w32.h, not after.
10640 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10641 instead of gnutls_record_check_pending.
10643 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10645 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10647 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10648 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10651 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10653 * xterm.c (x_set_frame_alpha): Do not set property on anything
10654 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10656 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10658 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10660 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10662 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10663 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10664 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10665 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10666 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10667 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10668 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10669 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10670 (Qgnutls_bootprop_callbacks_verify): Make static.
10672 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10674 * callproc.c: Indentation fixup.
10676 * sysdep.c (wait_for_termination_1): Make static.
10677 (wait_for_termination, interruptible_wait_for_termination):
10678 Move after wait_for_termination_1.
10680 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10682 * sysdep.c (interruptible_wait_for_termination): New function
10683 which is like wait_for_termination, but allows keyboard
10686 * callproc.c (Fcall_process): Add (:file "file") as an option for
10688 (Fcall_process_region): Ditto.
10690 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10692 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10693 rather than `XVECTOR (FOO)->size'.
10695 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10696 inttypes.h, as a gnulib replacement is used if it not available in
10699 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10701 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10702 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10703 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10705 * coding.c (coding_alloc_by_realloc): Error out if destination
10706 will grow beyond MOST_POSITIVE_FIXNUM.
10707 (decode_coding_emacs_mule): Abort if there isn't enough place in
10708 charbuf for the composition carryover bytes. Reserve an extra
10709 space for up to 2 characters produced in a loop.
10710 (decode_coding_iso_2022): Abort if there isn't enough place in
10711 charbuf for the composition carryover bytes.
10713 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10715 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10716 aborting when %lld or %lll format is passed.
10717 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10718 %llo or %llx format is passed. (Bug#8545)
10720 * window.c (window_scroll_line_based): Use a marker instead of
10721 simple variables to record original value of point. (Bug#7952)
10723 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10724 produced by %s or %c overflows available buffer space. (Bug#8545)
10726 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10728 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10729 (SIZE_MAX): Move defn after all includes, as they might #define it.
10731 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10733 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10735 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10737 * keyboard.c (Qdelayed_warnings_hook): Define.
10738 (command_loop_1): Run `delayed-warnings-hook'
10739 if Vdelayed_warnings_list is non-nil.
10740 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10741 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10743 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10745 * doprnt.c (doprnt): Don't return value smaller than the buffer
10746 size if the message was truncated. (Bug#8545).
10748 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10750 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10751 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10753 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10755 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10757 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10759 * makefile.w32-in: Update dependencies.
10761 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10763 Improve `doprnt' and its usage. (Bug#8545)
10764 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10765 `format_end'. Remove support for %l as a conversion specifier.
10766 Don't use xrealloc. Improve diagnostics when the %l size modifier
10767 is used. Update the commentary.
10769 * eval.c (verror): Simplify calculation of size_t.
10771 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10774 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10776 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10779 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10781 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10782 This makes this file independent of the recent pseudovector change.
10784 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10786 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10788 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10789 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10790 Remove unused local.
10791 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10793 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10794 GCC 4.6.0 optimizes based on type-based alias analysis.
10795 For example, if b is of type struct buffer * and v of type struct
10796 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10797 != &v->size, and therefore "v->size = 1; b->size = 2; return
10798 v->size;" must therefore return 1. This assumption is incorrect
10799 for Emacs, since it type-puns struct Lisp_Vector * with many other
10800 types. To fix this problem, this patch adds a new type struct
10801 vectorlike_header that documents the constraints on layout of vectors
10802 and pseudovectors, and helps optimizing compilers not get fooled
10803 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10804 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10805 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10807 (XSETPVECTYPE): Rewrite in terms of new macro.
10808 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10809 This is a bit clearer, and further avoids the possibility of
10810 undesirable aliasing.
10811 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10812 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10813 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10814 since Lisp_Subr is a special case (no "next" field).
10815 (ASIZE): Now uses header.size rather than size.
10816 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10817 to avoid the hassle of writing XVECTOR (foo)->header.size.
10818 (struct vectorlike_header): New type.
10819 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10820 object, to help avoid aliasing.
10821 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10822 (SUBRP): Likewise, since Lisp_Subr is a special case.
10823 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10824 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10825 (struct Lisp_Hash_Table): Combine first two members into a single
10826 struct vectorlike_header member. All uses of "size" and "next" members
10827 changed to be "header.size" and "header.next".
10828 * buffer.h (struct buffer): Likewise.
10829 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10830 * frame.h (struct frame): Likewise.
10831 * process.h (struct Lisp_Process): Likewise.
10832 * termhooks.h (struct terminal): Likewise.
10833 * window.c (struct save_window_data, struct saved_window): Likewise.
10834 * window.h (struct window): Likewise.
10835 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10836 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10837 * buffer.c (init_buffer_once): Likewise.
10838 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10840 * process.c (Fformat_network_address): Use local var for size,
10843 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10845 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10846 * data.c (atof): Remove decl; no longer used or needed.
10847 (digit_to_number): Move to lread.c.
10848 (Fstring_to_number): Use new string_to_number function, to be
10849 consistent with how the Lisp reader treats infinities and NaNs.
10850 Do not assume that floating-point numbers represent EMACS_INT
10851 without losing information; this is not true on most 64-bit hosts.
10852 Avoid double-rounding errors, by insisting on integers when
10853 parsing non-base-10 numbers, as the documentation specifies.
10854 * lisp.h (string_to_number): New decl, replacing ...
10855 (isfloat_string): Remove.
10856 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10857 (read1): Do not accept +. and -. as integers; this
10858 appears to have been a coding error. Similarly, do not accept
10859 strings like +-1e0 as floating point numbers. Do not report
10860 overflow for integer overflows unless the base is not 10 which
10861 means we have no simple and reliable way to continue.
10862 Break out the floating-point parsing into a new
10863 function string_to_number, so that Fstring_to_number parses
10864 floating point numbers consistently with the Lisp reader.
10865 (digit_to_number): Move here from data.c. Make it static inline.
10866 (E_CHAR, EXP_INT): Remove, replacing with ...
10867 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10868 (string_to_number): New function, replacing isfloat_string.
10869 This function checks for valid syntax and produces the resulting
10870 Lisp float number too. Rework it so that string-to-number
10871 no longer mishandles examples like "1.0e+". Use strtoumax,
10872 so that overflow for non-base-10 numbers is reported only when
10873 there's no portable and simple way to convert to floating point.
10875 * textprop.c (set_text_properties_1): Rewrite for clarity,
10876 and to avoid GCC warning about integer overflow.
10878 * intervals.h (struct interval): Use EMACS_INT for members
10879 where EMACS_UINT might cause problems. See
10880 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10881 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10882 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10884 (offset_intervals): Tell GCC not to worry about length overflow
10885 when negating a negative length.
10887 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10888 (overrun_check_free): Likewise.
10890 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10891 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10894 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10895 (gnutls_make_error): Rename local to avoid shadowing.
10896 (gnutls_emacs_global_deinit): ifdef out; not used.
10897 (Fgnutls_boot): Use const for pointer to readonly storage.
10898 Comment out unused local. Fix pointer signedness problems.
10900 * lread.c (openp): Don't stuff size_t into an 'int'.
10901 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10902 about possible signed overflow.
10904 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10905 (GDK_KEY_g): Don't define if already defined.
10906 (xg_prepare_tooltip): Avoid pointer signedness problem.
10907 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10909 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10910 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10912 * xfns.c (Fx_window_property): Simplify a bit,
10913 to make a bit faster and to avoid GCC 4.6.0 warning.
10914 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10916 * fns.c (internal_equal): Don't assume size_t fits in int.
10918 * alloc.c (compact_small_strings): Tighten assertion a little.
10920 Replace pEd with more-general pI, and fix some printf arg casts.
10921 * lisp.h (pI): New macro, generalizing old pEd macro to other
10922 conversion specifiers. For example, use "...%"pI"d..." rather
10923 than "...%"pEd"...".
10924 (pEd): Remove. All uses replaced with similar uses of pI.
10925 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10926 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10927 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10928 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10929 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10930 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10931 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10933 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10934 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10935 * print.c (safe_debug_print, print_object): Likewise.
10936 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10938 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10939 avoiding the 0 flag, which is not portable.
10940 * process.c (Fmake_network_process): Use pI to avoid cast.
10941 * region-cache.c (pp_cache): Likewise.
10942 * xdisp.c (decode_mode_spec): Likewise.
10943 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10944 behavior on 64-bit hosts with printf arg.
10945 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10946 (x_stop_queuing_selection_requests): Likewise.
10947 (x_get_window_property): Don't truncate byte count to an 'int'
10950 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10951 here, since it parses constructs like leading '-' and spaces,
10952 which are not wanted; and it overflows with large numbers.
10953 Instead, simply match F[0-9]+, which is what is wanted anyway.
10955 * alloc.c: Remove unportable assumptions about struct layout.
10956 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10957 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10958 (allocate_vectorlike, make_pure_vector): Use the new macros,
10959 plus offsetof, to remove unportable assumptions about struct layout.
10960 These assumptions hold on all porting targets that I know of, but
10961 they are not guaranteed, they're easy to remove, and removing them
10962 makes further changes easier.
10964 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10965 This doesn't fix a bug but makes the code clearer.
10966 (string_overrun_cookie): Now const. Use initializers that
10967 don't formally overflow signed char, to avoid warnings.
10968 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10969 can cause Emacs to crash when string overrun checking is enabled.
10970 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10971 multiple of sizeof (EMACS_INT); it need not be, if
10972 alignof(EMACS_INT) < sizeof (EMACS_INT).
10973 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10975 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10977 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10979 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10981 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10982 supposed to be handshaking. (Bug#8556)
10983 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10985 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10987 * lisp.h (Qdebug): List symbol.
10988 * eval.c (Qdebug): Restore global linkage.
10989 * keyboard.c (debug-on-event): New variable.
10990 (handle_user_signal): Break into debugger when debug-on-event
10991 matches the current signal symbol.
10993 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10995 * alloc.c (check_sblock, check_string_bytes)
10996 (check_string_free_list): Convert to standard C.
10998 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11000 * w32.c (emacs_gnutls_push): Fix typo.
11002 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11004 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11005 "cast to pointer from integer of different size".
11007 Improve doprnt and its use in verror. (Bug#8545)
11008 * doprnt.c (doprnt): Document the set of format control sequences
11009 supported by the function. Use SAFE_ALLOCA instead of always
11012 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11013 is one byte too soon. Don't use xrealloc; instead xfree and
11016 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11018 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11021 * gnutls.c: Renamed global_initialized to
11022 gnutls_global_initialized. Added internals for the
11023 :verify-hostname-error, :verify-error, and :verify-flags
11024 parameters of `gnutls-boot' and documented those parameters in the
11025 docstring. Start callback support.
11026 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11027 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11028 on error. Return error code.
11029 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11030 (emacs_gnutls_read): Likewise.
11031 (Fgnutls_boot): Return handshake error code.
11032 (emacs_gnutls_handle_error): New function.
11033 (wsaerror_to_errno): Likewise.
11035 * w32.h (emacs_gnutls_pull): Add prototype.
11036 (emacs_gnutls_push): Likewise.
11038 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11039 (emacs_gnutls_push): Likewise.
11041 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11043 * process.c (wait_reading_process_output): Check if GnuTLS
11044 buffered some data internally if no FDs are set for TLS
11047 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11048 (LIBS): Link to USER_LIBS.
11049 ($(BLD)/gnutls.$(0)): New target.
11051 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11053 * xdisp.c (handle_single_display_spec): Rename the
11054 display_replaced_before_p argument into display_replaced_p, to
11055 make it consistent with the commentary. Fix typos in the
11058 * textprop.c (syms_of_textprop): Remove dead code.
11059 (copy_text_properties): Delete obsolete commentary about an
11060 interface that was deleted long ago. Fix typos in the description
11063 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11064 to changes in oldXMenu/XMenu.h from 2011-04-16.
11065 <menu_help_message, prev_menu_help_message>: Constify.
11066 (IT_menu_make_room): menu->help_text is now `const char **';
11069 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11070 to changes in oldXMenu/XMenu.h from 2011-04-16.
11071 (struct XMenu): Declare `help_text' `const char **'.
11073 * xfaces.c <Qunspecified>: Make extern again.
11075 * syntax.c: Include sys/types.h before including regex.h, as
11078 * doc.c (get_doc_string): Improve the format passed to `error'.
11080 * doprnt.c (doprnt): Improve commentary.
11082 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11084 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11087 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11088 changes in globals.h immediately force recompilation.
11089 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11090 $(CURDIR)/s/ms-w32.h.
11091 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11093 * character.c (Fchar_direction): Function deleted.
11094 (syms_of_character): Don't defsubr it.
11095 <char-direction-table>: Deleted.
11097 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11099 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11100 * doprnt.c: Include limits.h.
11101 (SIZE_MAX): New macro.
11102 (doprnt): Return a size_t value. 2nd arg is now size_t.
11103 Many local variables are now size_t instead of int or unsigned.
11104 Improve overflow protection. Support `l' modifier for integer
11105 conversions. Support %l conversion. Don't assume an EMACS_INT
11106 argument for integer conversions and for %c.
11108 * lisp.h (doprnt): Restore prototype.
11110 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11111 $(SRC)/character.h.
11113 * Makefile.in (base_obj): Add back doprnt.o.
11115 * deps.mk (doprnt.o): Add back prerequisites.
11116 (callint.o): Depend on character.h.
11118 * eval.c (internal_lisp_condition_case): Include the handler
11119 representation in the error message.
11120 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11121 when breaking from the loop.
11123 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11125 * callint.c (Fcall_interactively): When displaying error message
11126 about invalid control letter, pass the character's codepoint, not
11127 a pointer to its multibyte form. Improve display of the character
11128 in octal and display also its hex code.
11130 * character.c (char_string): Use %x to display the (unsigned)
11131 codepoint of an invalid character, to avoid displaying a bogus
11134 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11135 `error', not SYMBOL_NAME itself.
11137 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11138 character arguments to `error'.
11140 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11141 to `error' in error message about FINAL_CHAR argument. Make sure
11142 FINAL_CHAR is a character, and use %c when it is passed as
11143 argument to `error'.
11145 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11147 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11149 * w32.c: Include <time.h>.
11150 (sys_localtime): New function.
11152 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11154 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11156 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11158 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11160 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11161 zombies (Bug#8467).
11163 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11165 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11166 gl_state.e_property when gl_state.object is Qt.
11168 * insdel.c (make_gap_larger): Remove limitation of buffer size
11171 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11173 * xdisp.c (lookup_glyphless_char_display)
11174 (produce_glyphless_glyph): Handle cons cell entry in
11175 glyphless-char-display.
11176 (Vglyphless_char_display): Document it.
11178 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11179 glyphless-char-display.
11181 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11183 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11185 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11187 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11188 definition for no-X builds.
11190 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11192 Static checks with GCC 4.6.0 and non-default toolkits.
11194 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11196 * process.c (keyboard_bit_set): Define only if SIGIO.
11197 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11198 (send_process): Repair possible setjmp clobbering.
11200 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11202 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11204 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11206 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11207 Define only if needed.
11209 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11210 by pacifying GCC about it. Maybe it's time to retire it?
11211 * xfaces.c (USG, __TIMEVAL__): Likewise.
11213 * dispextern.h (struct redisplay_interface): Rename param
11214 to avoid shadowing.
11215 * termhooks.h (struct terminal): Likewise.
11216 * xterm.c (xembed_send_message): Likewise.
11218 * insdel.c (make_gap_smaller): Define only if
11219 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11221 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11224 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11225 so that we aren't warned about unused symbols.
11227 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11229 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11231 * xfns.c (x_real_positions): Mark locals as initialized.
11233 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11235 * xterm.c: Fix problems found by static analysis with other toolkits.
11236 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11237 (x_dispatch_event): Declare static if USE_GTK, and
11238 define if USE_GTK || USE_X_TOOLKIT.
11239 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11240 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11241 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11242 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11244 * xmenu.c (menu_help_callback): Pointer type fixes.
11245 Use const pointers when pointing at readonly data. Avoid pointer
11246 signedness clashes.
11247 (FALSE): Remove unused macro.
11248 (update_frame_menubar): Remove unused decl.
11250 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11252 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11253 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11254 (single_menu_item): Rename local to avoid shadowing.
11256 * keyboard.c (make_lispy_event): Remove unused local var.
11258 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11259 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11261 * bitmaps: Change bitmaps from unsigned char back to the X11
11262 compatible char. Avoid the old compiler warnings about
11263 out-of-range initializers by using, for example, '\xab' rather
11266 * xgselect.c (xgselect_initialize): Check vs interface
11267 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11269 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11271 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11272 to read-only memory.
11274 * fns.c (vector): Remove; this old hack is no longer needed.
11276 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11278 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11280 * xrdb.c (x_load_resources): Omit unused local.
11282 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11283 (x_window): Rename locals to avoid shadowing.
11284 (USG): Use the kludged USG macro, to pacify gcc.
11286 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11287 (x_term_init): Remove local to avoid shadowing.
11289 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11291 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11292 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11294 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11296 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11298 Fix regex.c, syntax.c and friends for buffers > 2GB.
11299 * syntax.h (struct gl_state_s): Declare character position members
11302 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11304 * textprop.c (verify_interval_modification, interval_of):
11305 Declare arguments EMACS_INT.
11307 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11310 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11312 * indent.c (Fvertical_motion): Local variable it_start is now
11315 * regex.c (re_match, re_match_2, re_match_2_internal)
11316 (bcmp_translate, regcomp, regexec, print_double_string)
11317 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11318 (re_compile_pattern, re_exec): Declare arguments and local
11319 variables `size_t' and `ssize_t' and return values `regoff_t', as
11321 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11322 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11323 <compile_stack_type>: `size' and `avail' are now `size_t'.
11325 * regex.h <regoff_t>: Use ssize_t, not int.
11326 (re_search, re_search_2, re_match, re_match_2): Arguments that
11327 specify buffer/string position and length are now ssize_t and
11328 size_t. Return type is regoff_t.
11330 2011-04-16 Ben Key <bkey76@gmail.com>
11332 * nsfont.m: Fixed bugs in ns_get_family and
11333 ns_descriptor_to_entity that were caused by using free to
11334 deallocate memory blocks that were allocated by xmalloc (via
11335 xstrdup). This caused Emacs to crash when compiled with
11336 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11337 --enable-checking=xmallocoverrun). xfree is now used to
11338 deallocate these memory blocks.
11340 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11342 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11344 emacs_write: Accept and return EMACS_INT for sizes.
11345 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11347 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11348 Accept and return EMACS_INT.
11349 (emacs_gnutls_write): Return the number of bytes written on
11351 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11352 (emacs_read, emacs_write): Remove check for negative size, as the
11353 Emacs source code has been audited now.
11354 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11355 (emacs_read, emacs_write): Use it.
11356 * process.c (send_process): Adjust to the new signatures of
11357 emacs_write and emacs_gnutls_write. Do not attempt to store
11358 a byte offset into an 'int'; it might overflow.
11359 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11361 * sound.c: Don't assume sizes fit in 'int'.
11362 (struct sound_device.period_size, alsa_period_size):
11363 Return EMACS_INT, not int.
11364 (struct sound_device.write, vox_write, alsa_write):
11365 Accept EMACS_INT, not int.
11366 (wav_play, au_play): Use EMACS_INT to store sizes and to
11367 record read return values.
11369 2011-04-15 Ben Key <bkey76@gmail.com>
11371 * keyboard.c (Qundefined): Don't declare static since it is used
11373 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11374 static since they are used in nsfont.m.
11376 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11378 * process.c (Qprocessp): Don't declare static.
11379 * lisp.h (Qprocessp): Declare again.
11381 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11383 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11385 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11387 Improve C-level modularity by making more things 'static'.
11389 Don't publish debugger-only interfaces to other modules.
11390 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11391 (verify_bytepos, count_markers): Move decls to the only modules
11393 * region-cache.h (pp_cache): Likewise.
11394 * window.h (check_all_windows): Likewise.
11395 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11397 * sysdep.c (croak): Now static, if
11398 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11399 * syssignal.h (croak): Declare only if not static.
11401 * alloc.c (refill_memory_reserve): Now static if
11402 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11403 * lisp.h (refill_memory_reserve): Declare only if not static.
11405 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11406 Define only if USE_LUCID.
11408 * xrdb.c (x_customization_string, x_rm_string): Now static.
11410 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11411 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11413 * xdisp.c (draw_row_with_mouse_face): Now static.
11414 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11416 * window.h (check_all_windows): Mark externally visible.
11418 * window.c (window_deletion_count): Now static.
11420 * undo.c: Make symbols static if they're not exported.
11421 (last_undo_buffer, last_boundary_position, pending_boundary):
11424 * textprop.c (interval_insert_behind_hooks): Now static.
11425 (interval_insert_in_front_hooks): Likewise.
11427 * term.c: Make symbols static if they're not exported.
11428 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11429 (max_frame_lines, tty_set_terminal_modes):
11430 (tty_reset_terminal_modes, tty_turn_off_highlight):
11431 (get_tty_terminal): Now static.
11432 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11433 * termhooks.h (term_mouse_moveto): Do not declare if
11434 HAVE_WINDOW_SYSTEM.
11435 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11436 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11438 * sysdep.c: Make symbols static if they're not exported.
11439 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11441 (sigprocmask_set, full_mask): Remove; unused.
11442 (wait_debugging): Mark as visible.
11443 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11444 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11446 * syntax.c (syntax_temp): Define only if !__GNUC__.
11448 * sound.c (current_sound_device, current_sound): Now static.
11450 * search.c (searchbufs, searchbuf_head): Now static.
11452 * scroll.c (scroll_cost): Remove; unused.
11453 * dispextern.h (scroll_cost): Remove decl.
11455 * region-cache.h (pp_cache): Mark as externally visible.
11457 * process.c: Make symbols static if they're not exported.
11458 (process_tick, update_tick, create_process, chan_process):
11459 (Vprocess_alist, proc_buffered_char, datagram_access):
11460 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11461 (deactivate_process): Mark defn as static, as well as decl.
11462 * lisp.h (create_process): Remove decl.
11463 * process.h (chan_process, Vprocess_alist): Remove decls.
11465 * print.c: Make symbols static if they're not exported.
11466 (print_depth, new_backquote_output, being_printed, print_buffer):
11467 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11468 (print_interval, print_number_index, initial_stderr_stream):
11470 * lisp.h (Fprinc): Remove decl.
11471 (debug_output_compilation_hack): Mark as externally visible.
11473 * sysdep.c (croak): Move decl from here to syssignal.h.
11474 * syssignal.h (croak): Put it here, so the API can be checked when
11475 'croak' is called from dissociate_if_controlling_tty.
11477 * minibuf.c: Make symbols static if they're not exported.
11478 (minibuf_save_list, choose_minibuf_frame): Now static.
11479 * lisp.h (choose_minibuf_frame): Remove decl.
11481 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11483 * lread.c: Make symbols static if they're not exported.
11484 (read_objects, initial_obarray, oblookup_last_bucket_number):
11486 (make_symbol): Remove; unused.
11487 * lisp.h (initial_obarray, make_symbol): Remove decls.
11489 * keyboard.c: Make symbols static if they're not exported.
11490 (single_kboard, recent_keys_index, total_keys, recent_keys):
11491 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11492 (this_single_command_key_start, echoing, last_auto_save):
11493 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11494 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11495 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11496 (Vlispy_mouse_stem, double_click_count):
11498 (force_auto_save_soon): Define only if SIGDANGER.
11499 (ignore_mouse_drag_p): Now static if
11500 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11501 (print_help): Remove; unused.
11502 (stop_character, last_timer_event): Mark as externally visible.
11503 * keyboard.h (ignore_mouse_drag_p): Declare only if
11504 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11505 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11506 * lisp.h (echoing): Remove decl.
11507 (force_auto_save_soon): Declare only if SIGDANGER.
11508 * xdisp.c (redisplay_window): Simplify code, to make it more
11509 obvious that ignore_mouse_drag_p is not accessed if !defined
11510 USE_GTK && !defined HAVE_NS.
11512 * intervals.c: Make symbols static if they're not exported.
11513 (merge_properties_sticky, merge_interval_right, delete_interval):
11515 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11517 * insdel.c: Make symbols static if they're not exported.
11518 However, leave prepare_to_modify_buffer alone. It's never
11519 called from outside this function, but that appears to be a bug.
11520 (combine_after_change_list, combine_after_change_buffer):
11521 (adjust_after_replace, signal_before_change): Now static.
11522 (adjust_after_replace_noundo): Remove; unused.
11523 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11524 (signal_before_change): Remove decls.
11526 * indent.c (val_compute_motion, val_vmotion): Now static.
11528 * image.c: Make symbols static if they're not exported.
11529 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11531 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11532 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11534 * fringe.c (standard_bitmaps): Now static.
11535 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11537 * frame.c: Make symbols static if they're not exported.
11538 (x_report_frame_params, make_terminal_frame): Now static.
11539 (get_frame_param): Now static, unless HAVE_NS.
11540 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11541 (x_get_resource_string): Remove; not used.
11542 * frame.h (make_terminal_frame, x_report_frame_params):
11543 (x_get_resource_string); Remove decls.
11544 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11545 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11547 * font.c, fontset.c: Make symbols static if they're not exported.
11548 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11549 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11550 * font.c (font_close_object): Now static.
11551 * font.h (font_close_object): Remove.
11552 * fontset.c (FONTSET_OBJLIST): Remove.
11553 (free_realized_fontset) #if-0 the body, which does nothing.
11554 (face_suitable_for_char_p): #if-0, as it's never called.
11555 * fontset.h (face_suitable_for_char_p): Remove decl.
11556 * xfaces.c (face_at_string_position):
11557 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11558 since 0 is always ASCII.
11560 * fns.c (weak_hash_tables): Now static.
11562 * fileio.c: Make symbols static if they're not exported.
11563 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11564 (Vwrite_region_annotation_buffers): Now static.
11566 * eval.c: Make symbols static if they're not exported.
11567 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11568 * lisp.h (backtrace_list): Remove decl.
11570 * emacs.c: Make symbols static if they're not exported.
11571 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11572 (fatal_error_code, fatal_error_signal_hook, standard_args):
11574 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11575 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11576 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11577 * lisp.h (fatal_error_signal_hook): Remove decl.
11578 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11580 * editfns.c: Move a (normally-unused) function to its only use.
11581 * editfns.c, lisp.h (get_operating_system_release): Remove.
11582 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11583 worth the hassle of breaking this out.
11585 * xterm.c: Make symbols static if they're not exported.
11586 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11587 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11588 (x_destroy_window, x_delete_display):
11590 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11591 (x_mouse_leave): Remove; unused.
11592 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11593 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11594 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11596 (x_mouse_leave): Declare only if WINDOWSNT.
11597 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11598 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11601 * ftxfont.c: Make symbols static if they're not exported.
11602 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11604 * font.h (ftxfont_driver): Likewise.
11606 * xfns.c: Make symbols static if they're not exported.
11607 (x_last_font_name, x_display_info_for_name):
11608 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11609 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11610 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11611 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11612 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11613 (last_show_tip_args): Now static.
11614 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11615 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11616 (x_screen_planes): Remove; unused.
11617 * dispextern.h (x_screen_planes): Remove decl.
11619 * dispnew.c: Make symbols static if they're not exported.
11620 * dispextern.h (redraw_garbaged_frames, scrolling):
11621 (increment_row_positions): Remove.
11622 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11623 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11625 (redraw_garbaged_frames): Remove; unused.
11627 * xfaces.c: Make symbols static if they're not exported.
11628 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11630 * xterm.h (defined_color): Remove decls.
11631 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11632 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11633 (menu_face_changed_default, defined_color, free_realized_face):
11634 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11635 (ascii_face_of_lisp_face): Remove; unused.
11637 * xdisp.c: Make symbols static if they're not exported.
11638 * dispextern.h (scratch_glyph_row, window_box_edges):
11639 (glyph_to_pixel_coords, set_cursor_from_row):
11640 (get_next_display_element, set_iterator_to_next):
11641 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11642 (show_mouse_face): Remove decls
11643 * frame.h (message_buf_print): Likewise.
11644 * lisp.h (pop_message, set_message, check_point_in_composition):
11646 * xterm.h (set_vertical_scroll_bar): Likewise.
11647 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11648 (message_buf_print, scratch_glyph_row, displayed_buffer):
11649 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11650 (get_next_display_element, show_mouse_face, window_box_edges):
11651 (frame_to_window_pixel_xy, check_point_in_composition):
11652 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11653 (glyph_to_pixel_coords): Remove; unused.
11655 * dired.c (file_name_completion): Now static.
11657 * dbusbind.c (xd_in_read_queued_messages): Now static.
11659 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11660 * data.c (circular_list_error): Remove.
11662 * commands.h (last_point_position, last_point_position_buffer):
11663 (last_point_position_window): Remove decls.
11664 * keyboard.c: Make these variables static.
11666 * coding.h (coding, code_convert_region, encode_coding_gap):
11668 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11669 (iso_code_class, detect_coding, code_convert_region): Now static.
11670 (encode_coding_gap): Remove; unused.
11672 * chartab.c (chartab_chars, chartab_bits): Now static.
11674 * charset.h (charset_iso_8859_1): Remove decl.
11675 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11678 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11679 * ccl.c (Vccl_program_table): Now static.
11680 (check_ccl_update): Remove; unused.
11682 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11683 * category.h: ... from here.
11684 * category.c (check_category_table, set_category_set): Now static.
11686 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11687 * lisp.h: Remove these decls.
11689 * buffer.c (buffer_count): Remove unused var.
11691 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11692 so that it's not optimized away.
11693 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11694 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11695 exported only to the debugger.
11697 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11698 * atimer.h (run_all_atimers): Remove; not exported.
11700 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11701 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11702 was inaccessible from Lisp.
11703 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11704 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11706 alloc.c: Import and export fewer symbols, and remove unused items.
11707 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11709 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11710 it's not optimized away by whole-program optimization.
11711 (message_enable_multibyte, free_misc): Remove.
11712 (catchlist, handlerlist, mark_backtrace):
11713 Declare only if BYTE_MARK_STACK.
11714 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11715 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11716 (message_enable_multibyte): Remove decl.
11717 (free_misc, interval_free_list, float_block, float_block_index):
11718 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11719 (cons_free_list, last_marked_index):
11721 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11722 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11723 (mark_backtrace): Define only if BYTE_MARK_STACK.
11724 * xdisp.c (message_enable_multibyte): Now static.
11726 Declare Lisp_Object Q* variables to be 'static' if not exported.
11727 This makes it easier for human readers (and static analyzers)
11728 to see whether these variables are used from other modules.
11729 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11730 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11731 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11732 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11733 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11734 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11735 * xmenu.c, xselect.c:
11736 Declare Q* vars static if they are not used in other modules.
11737 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11738 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11739 Remove decls of unexported vars.
11740 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11742 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11744 Make Emacs functions such as Fatom 'static' by default.
11745 This makes it easier for human readers (and static analyzers)
11746 to see whether these functions can be called from other modules.
11747 DEFUN now defines a static function. To make the function external
11748 so that it can be used in other C modules, use the new macro DEFUE.
11749 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11750 (Finit_image_library):
11751 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11752 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11753 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11754 Remove decls, since these functions are now static.
11755 (Funintern, Fget_internal_run_time): New decls, since these functions
11756 were already external.
11758 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11759 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11760 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11761 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11762 * keyboard.c, keymap.c, lread.c:
11763 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11764 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11765 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11766 Mark functions with DEFUE instead of DEFUN,
11767 if they are used in other modules.
11768 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11769 decls for now-static functions.
11770 * buffer.h (Fdelete_overlay): Remove decl.
11771 * callproc.c (Fgetenv_internal): Mark as internal.
11772 * composite.c (Fremove_list_of_text_properties): Remove decl.
11773 (Fcomposition_get_gstring): New forward static decl.
11774 * composite.h (Fcomposite_get_gstring): Remove decl.
11775 * dired.c (Ffile_attributes): New forward static decl.
11776 * doc.c (Fdocumntation_property): New forward static decl.
11777 * eval.c (Ffetch_bytecode): New forward static decl.
11778 (Funintern): Remove extern decl; now in .h file where it belongs.
11779 * fileio.c (Fmake_symbolic_link): New forward static decl.
11780 * image.c (Finit_image_library): New forward static decl.
11781 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11782 * intervals.h (Fprevious_property_change):
11783 (Fremove_list_of_text_properties): Remove decls.
11784 * keyboard.c (Fthis_command_keys): Remove decl.
11785 (Fcommand_execute): New forward static decl.
11786 * keymap.c (Flookup_key): New forward static decl.
11787 (Fcopy_keymap): Now static.
11788 * keymap.h (Flookup_key): Remove decl.
11789 * process.c (Fget_process): New forward static decl.
11790 (Fprocess_datagram_address): Mark as internal.
11791 * syntax.c (Fsyntax_table_p): New forward static decl.
11792 (skip_chars): Remove duplicate decl.
11793 * textprop.c (Fprevious_property_change): New forward static decl.
11794 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11796 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11797 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11799 * editfns.c (Fformat): Remove unreachable code.
11801 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11803 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11806 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11808 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11809 when at ZV. (Bug#8487)
11811 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11813 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11815 * keyboard.c (parse_tool_bar_item): Likewise.
11816 * sound.c (sound_cleanup, alsa_close): Likewise.
11817 * termcap.c (tgetent): Likewise.
11818 * xfns.c (x_default_font_parameter): Likewise.
11819 * xsettings.c (read_and_apply_settings): Likewise.
11821 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11822 (overrun_check_free): Protoize.
11824 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11826 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11827 since callers should never pass a negative size.
11828 Change the signature to match that of plain 'read' and 'write'; see
11829 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11830 * lisp.h: Update prototypes of emacs_write and emacs_read.
11832 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11834 * xdisp.c (redisplay_window): Don't try to determine the character
11835 position of the scroll margin if the window start point w->startp
11836 is outside the buffer's accessible region. (Bug#8468)
11838 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11840 Fix write-region and its subroutines for buffers > 2GB.
11841 * fileio.c (a_write, e_write): Modify declaration of arguments and
11842 local variables to support buffers larger than 2GB.
11843 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11845 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11846 argument, local variables, and return value.
11848 * lisp.h: Update prototypes of emacs_write and emacs_read.
11850 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11852 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11854 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11856 Fix more problems found by GCC 4.6.0's static checks.
11858 * xdisp.c (vmessage): Use a better test for character truncation.
11860 * charset.c (load_charset_map): <, not <=, for optimization,
11861 and to avoid potential problems with integer overflow.
11862 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11863 * casetab.c (set_identity, shuffle): Likewise.
11864 * editfns.c (Fformat): Likewise.
11865 * syntax.c (skip_chars): Likewise.
11867 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11868 This also lets GCC 4.6.0 generate slightly better loop code.
11870 * callint.c (Fcall_interactively): <, not <=, for optimization.
11871 (Fcall_interactively): Count the number of arguments produced,
11872 not the number of arguments given. This is simpler and lets GCC
11873 4.6.0 generate slightly better code.
11875 * ftfont.c: Distingish more carefully between FcChar8 and char.
11876 The previous code passed unsigned char * to a functions like
11877 strlen and xstrcasecmp that expect char *, which does not
11878 conform to the C standard.
11879 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11880 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11881 char * when the C standard requires it.
11883 * keyboard.c (read_char): Remove unused var.
11885 * eval.c: Port to Windows vsnprintf (Bug#8435).
11886 Include <limits.h>.
11887 (SIZE_MAX): Define if the headers do not.
11888 (verror): Do not give up if vsnprintf returns a negative count.
11889 Instead, grow the buffer. This ports to Windows vsnprintf, which
11890 does not conform to C99. Problem reported by Eli Zaretskii.
11891 Also, simplify the allocation scheme, by avoiding the need for
11892 calling realloc, and removing the ALLOCATED variable.
11894 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11896 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11897 But keep the doprint source code for now, as we might revamp it
11898 and use it again (Bug#8435).
11899 * lisp.h (doprnt): Remove.
11900 * Makefile.in (base_obj): Remove doprnt.o.
11901 * deps.mk (doprnt.o): Remove.
11903 error: Print 32- and 64-bit integers portably (Bug#8435).
11904 Without this change, on typical 64-bit hosts error ("...%d...", N)
11905 was used to print both 32- and 64-bit integers N, which relied on
11906 undefined behavior.
11907 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11908 * lisp.h (error, verror): Mark as printf-like functions.
11909 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11910 Report overflow in size calculations when allocating printf buffer.
11911 Do not truncate output string at its first null byte.
11912 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11913 Truncate the output at a character boundary, since vsnprintf does not
11915 * charset.c (check_iso_charset_parameter): Convert internal
11916 character to string before calling 'error', since %c now has the
11918 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11919 overflow when computing char to be passed to 'error'. Do not
11920 pass Lisp_Object to 'error'; pass the integer instead.
11921 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11922 formatted with plain %d.
11924 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11926 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11928 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11930 * xterm.c (x_catch_errors): Remove duplicate declaration.
11932 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11934 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11936 2011-04-10 Jim Meyering <meyering@redhat.com>
11938 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11939 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11940 return ssize_t not "int", and use size_t as the buffer length.
11941 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11942 * gnutls.h: Update declarations.
11943 * process.c (read_process_output): Use ssize_t, to match.
11944 (send_process): Likewise.
11946 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11948 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11950 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11952 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11953 Use unsigned char, to match FcChar8 type definition.
11955 * xterm.c (handle_one_xevent):
11956 * xmenu.c (create_and_show_popup_menu):
11957 * xselect.c (x_decline_selection_request)
11958 (x_reply_selection_request): Avoid type-punned deref of X events.
11960 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11962 Fix some uses of `int' instead of EMACS_INT.
11963 * search.c (string_match_1, fast_string_match)
11964 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11965 (scan_buffer, find_next_newline_no_quit)
11966 (find_before_next_newline, search_command, Freplace_match)
11967 (Fmatch_data): Make some `int' variables be EMACS_INT.
11969 * xdisp.c (display_count_lines): 3rd argument and return value now
11970 EMACS_INT. All callers changed.
11971 (pint2hrstr): Last argument is now EMACS_INT.
11973 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11974 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11975 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11976 (decode_coding_utf_16, decode_coding_emacs_mule)
11977 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11978 (decode_coding_ccl, decode_coding_charset)
11979 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11980 (decode_coding_iso_2022, decode_coding_emacs_mule)
11981 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11982 <char_offset, last_offset>: Declare EMACS_INT.
11983 (encode_coding_utf_8, encode_coding_utf_16)
11984 (encode_coding_emacs_mule, encode_invocation_designation)
11985 (encode_designation_at_bol, encode_coding_iso_2022)
11986 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11987 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11989 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11990 (encode_invocation_designation): Last argument P_NCHARS is now
11992 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11993 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11995 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11998 * ccl.c (Fccl_execute_on_string): Declare some variables
12001 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12003 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12005 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12007 * process.c (Fformat_network_address): Doc fix.
12009 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12011 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12013 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12015 * keyboard.c (read_char): Call Lisp function help-form-show,
12016 instead of using internal_with_output_to_temp_buffer.
12017 (Qhelp_form_show): New var.
12018 (syms_of_keyboard): Use DEFSYM macro.
12020 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12022 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12024 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12026 * process.c (Flist_processes): Remove to Lisp.
12027 (list_processes_1): Delete.
12029 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12031 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12033 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12035 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12037 Fix more problems found by GCC 4.6.0's static checks.
12039 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12041 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12043 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12045 * xdisp.c (vmessage): Mark as a printf-like function.
12047 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12049 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12051 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12052 printf-like functions.
12053 (tiff_load): Add casts to remove these marks before passing them
12054 to system-supplied API.
12056 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12058 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12059 This avoids several warnings with gcc -Wstrict-overflow.
12060 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12061 directly, rather than having caller test rule sign. This avoids
12062 some unnecessary tests.
12063 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12064 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12065 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12067 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12068 (xfont_open): Avoid unnecessary tests.
12070 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12072 * composite.h, composite.c (composition_gstring_put_cache):
12073 Use EMACS_INT, not int, for length.
12075 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12076 breaking out part of COMPOSITION_DECODE_RULE.
12077 (COMPOSITION_DECODE_RULE): Use it.
12078 * composite.c (get_composition_id): Remove unused local vars,
12079 by using the new macro.
12081 * textprop.c (set_text_properties_1): Change while to do-while,
12082 since the condition is always true at first.
12084 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12085 (interval_deletion_adjustment): Return unsigned value.
12088 * process.c (list_processes_1, create_pty, read_process_output):
12089 (exec_sentinel): Remove vars that were set but not used.
12090 (create_pty): Remove unnecessary "volatile"s.
12091 (Fnetwork_interface_info): Avoid possibility of int overflow.
12092 (read_process_output): Do adaptive read buffering even if carryover.
12093 (read_process_output): Simplify nbytes computation if buffered.
12095 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12097 * syntax.c (scan_words): Remove var that was set but not used.
12098 (update_syntax_table): Use unsigned instead of int.
12100 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12101 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12102 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12104 * print.c (print_error_message): Avoid int overflow.
12106 * font.c (font_list_entities): Redo for clarity,
12107 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12109 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12110 (font_score): Avoid potential overflow in diff calculation.
12112 * fns.c (substring_both): Remove var that is set but not used.
12113 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12115 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12117 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12118 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12119 can always succeed if overflow has undefined behavior.
12121 * search.c (boyer_moore, wordify): Remove vars set but not used.
12122 (wordify): Omit three unnecessary tests.
12124 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12125 All callers changed. This avoids the need for an unused var.
12127 * casefiddle.c (casify_region): Remove var that is set but not used.
12129 * dired.c (file_name_completion): Remove var that is set but not used.
12131 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12133 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12134 (Finsert_file_contents): Remove unnecessary code checking fd.
12136 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12137 Check for integer overflow on size calculations.
12139 * buffer.c (Fprevious_overlay_change): Remove var that is set
12142 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12143 Remove vars that are set but not used.
12144 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12145 (timer_check_2): Mark vars as initialized.
12147 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12149 * image.c (lookup_image): Remove var that is set but not used.
12150 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12152 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12153 that are set but not used.
12155 * xfns.c (make_invisible_cursor): Don't return garbage
12156 if XCreateBitmapFromData fails (Bug#8410).
12158 * xselect.c (x_get_local_selection, x_handle_property_notify):
12159 Remove vars that are set but not used.
12161 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12162 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12164 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12165 Remove var that is set but not used.
12166 (scroll_bar_windows_size): Now size_t, not int.
12167 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12168 Check for overflow.
12170 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12171 (map_tty_color) [!defined MSDOS]: Likewise.
12173 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12175 * coding.c: Remove vars that are set but not used.
12176 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12177 All callers changed.
12178 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12179 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12180 (decode_coding_charset): Remove vars that are set but not used.
12182 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12183 that is set but not used.
12185 * print.c (print_object): Remove var that is set but not used.
12187 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12188 The gnulib version avoids calling malloc in the usual case,
12189 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12190 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12191 * filelock.c (current_lock_owner): Likewise.
12192 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12193 * sysdep.c: Include allocator.h, careadlinkat.h.
12194 (emacs_no_realloc_allocator): New static constant.
12195 (emacs_readlink): New function.
12196 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12197 ../lib/careadlinkat.h.
12199 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12201 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12202 first non-nil return value).
12204 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12206 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12207 if not defined (Bug#8403).
12209 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12211 * xdisp.c (display_count_lines): Remove parameter `start',
12212 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12213 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12214 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12215 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12216 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12217 and thereabouts. All callers changed.
12218 (get_per_char_metric): Remove parameter `f', unused since
12219 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12221 2011-04-02 Jim Meyering <meyering@redhat.com>
12223 do not dereference NULL upon failed strdup
12224 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12225 (ns_get_family): Likewise.
12227 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12229 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12231 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12233 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12236 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12238 Add lexical binding.
12240 * window.c (Ftemp_output_buffer_show): New fun.
12241 (Fsave_window_excursion):
12242 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12244 * lread.c (lisp_file_lexically_bound_p): New function.
12245 (Fload): Bind Qlexical_binding.
12246 (readevalloop): Remove `evalfun' arg.
12247 Bind Qinternal_interpreter_environment.
12248 (Feval_buffer): Bind Qlexical_binding.
12249 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12251 (syms_of_lread): Declare `lexical-binding'.
12253 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12255 * keyboard.c (eval_dyn): New fun.
12256 (menu_item_eval_property): Use it.
12258 * image.c (parse_image_spec): Use Ffunctionp.
12260 * fns.c (concat, mapcar1): Accept byte-code-functions.
12262 * eval.c (Fsetq): Handle lexical vars.
12263 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12264 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12265 (FletX, Flet): Obey lexical binding.
12266 (Fcommandp): Handle closures.
12267 (Feval): New `lexical' arg.
12268 (eval_sub): New function extracted from Feval. Use it almost
12269 everywhere where Feval was used. Look up vars in lexical env.
12271 (Ffunctionp): Move from subr.el.
12272 (Ffuncall): Handle closures.
12273 (apply_lambda): Remove `eval_flags'.
12274 (funcall_lambda): Handle closures and new byte-code-functions.
12275 (Fspecial_variable_p): New function.
12276 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12277 but without exporting it to Lisp.
12279 * doc.c (Fdocumentation, store_function_docstring):
12280 * data.c (Finteractive_form): Handle closures.
12282 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12285 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12287 (exec_byte_code): New function extracted from Fbyte_code to handle new
12288 calling convention for byte-code-functions. Add new byte-codes.
12290 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12292 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12294 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12296 * xdisp.c (redisplay_internal): Fix prototype.
12298 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12300 * xdisp.c (SCROLL_LIMIT): New macro.
12301 (try_scrolling): Use it when setting scroll_limit.
12302 Limit scrolling to 100 screen lines.
12303 (redisplay_window): Even when falling back on "recentering",
12304 position point in the window according to scroll-conservatively,
12305 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12307 (try_scrolling): When point is above the window, allow searching
12308 as far as scroll_max, or one screenful, to compute vertical
12309 distance from PT to the scroll margin position. This prevents
12310 try_scrolling from unnecessarily failing when
12311 scroll-conservatively is set to a value slightly larger than the
12312 window height. Clean up the case of PT below the margin at bottom
12313 of window: scroll_max can no longer be INT_MAX. When aggressive
12314 scrolling is in use, don't let point enter the opposite scroll
12315 margin as result of the scroll.
12316 (syms_of_xdisp) <scroll-conservatively>: Document the
12317 threshold of 100 lines for never-recentering scrolling.
12319 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12321 * dispextern.h (move_it_by_lines):
12322 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12323 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12324 (message_log_check_duplicate): Remove parameters `prev_bol' and
12325 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12326 (redisplay_internal): Remove parameter `preserve_echo_area',
12327 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12329 * indent.c (Fvertical_motion):
12330 * window.c (window_scroll_pixel_based, Frecenter):
12331 Don't pass `need_y_p' to `move_it_by_lines'.
12333 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12335 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12336 steal a few bits to be more compact.
12337 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12338 Remove unneeded casts.
12340 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12342 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12344 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12345 binding" message (bug#7967).
12347 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12349 Fix more problems found by GCC 4.6.0's static checks.
12351 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12352 Remove unused local var.
12354 * editfns.c (Fmessage_box): Remove unused local var.
12356 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12357 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12358 Omit unused local vars.
12359 * window.c (shrink_windows): Omit unused local var.
12360 * menu.c (digest_single_submenu): Omit unused local var.
12361 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12362 Omit unused local var.
12364 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12365 Don't assume string length fits in int.
12366 (keyremap_step, read_key_sequence): Use size_t for sizes.
12367 (read_key_sequence): Don't check last_real_key_start redundantly.
12369 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12370 instead of alloca (Bug#8344).
12372 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12373 (Fbacktrace_frame): Don't assume nframes fits in int.
12375 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12377 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12380 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12382 * cm.c (calccost): Turn while-do into do-while, for clarity.
12384 * keyboard.c (syms_of_keyboard): Use the same style as later
12385 in this function when indexing through an array. This also
12386 works around GCC bug 48267.
12388 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12390 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12392 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12393 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12395 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12396 This avoids undefined behavior on integer overflow, and is a bit
12397 more convenient anyway since it is compared to a size_t variable.
12399 Variadic C functions now count arguments with size_t, not int.
12400 This avoids an unnecessary limitation on 64-bit machines, which
12401 caused (substring ...) to crash on large vectors (Bug#8344).
12402 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12403 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12404 All variadic functions and their callers changed accordingly.
12405 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12406 * data.c (arith_driver, float_arith_driver): Likewise.
12407 * editfns.c (general_insert_function): Likewise.
12408 * eval.c (struct backtrace.nargs, interactive_p)
12409 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12410 (funcall_lambda, mark_backtrace): Likewise.
12411 * fns.c (concat): Likewise.
12412 * frame.c (x_set_frame_parameters): Likewise.
12413 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12414 0 if not found, not -1. All callers changed.
12416 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12417 (stack_copy_size): Now size_t, not int.
12418 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12420 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12422 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12423 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12424 All callers changed.
12426 * lisp.h (multibyte_char_to_unibyte):
12427 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12428 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12429 * character.h (CHAR_TO_BYTE8):
12430 * cmds.c (internal_self_insert):
12431 * editfns.c (general_insert_function):
12432 * keymap.c (push_key_description):
12433 * search.c (Freplace_match):
12434 * xdisp.c (message_dolog, set_message_1): All callers changed.
12436 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12438 * keyboard.c (safe_run_hook_funcall): New function.
12439 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12440 don't set the hook to nil, but remove the offending function instead.
12441 (Qcommand_hook_internal): Remove, unused.
12442 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12443 Vcommand_hook_internal.
12445 * eval.c (enum run_hooks_condition): Remove.
12446 (funcall_nil, funcall_not): New functions.
12447 (run_hook_with_args): Call each function through a `funcall' argument.
12448 Remove `cond' argument, now redundant.
12449 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12450 (Frun_hook_with_args_until_failure): Adjust accordingly.
12451 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12453 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12455 * dispextern.h (string_buffer_position): Remove declaration.
12457 * print.c (strout): Remove parameter `multibyte', unused since
12458 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12460 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12461 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12462 All callers changed.
12464 * w32.c (_wsa_errlist): Use braces for struct initializers.
12466 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12467 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12468 All callers changed.
12469 (string_buffer_position): Likewise. Also, make static (it's never
12470 used outside xdisp.c).
12471 (cursor_row_p): Remove parameter `w', unused since
12472 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12473 (decode_mode_spec): Remove parameter `precision', introduced during
12474 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12475 All callers changed.
12477 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12479 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12481 2011-03-27 Anders Lindgren <andlind@gmail.com>
12483 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12484 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12485 (ns_update_auto_hide_menu_bar): New functions.
12486 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12487 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12488 ns_constrain_all_frames.
12489 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12490 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12492 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12494 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12496 2011-03-27 Glenn Morris <rgm@gnu.org>
12498 * syssignal.h: Replace RETSIGTYPE with void.
12499 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12500 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12501 Replace SIGTYPE with void everywhere.
12502 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12503 * s/template.h (SIGTYPE): Remove commented out definition.
12505 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12507 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12508 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12510 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12512 * w32.c (read_unc_volume): Use parameter `henum', instead of
12513 global variable `wget_enum_handle'.
12515 * keymap.c (describe_vector): Remove parameters `indices' and
12516 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12517 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12519 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12521 * keyboard.c (timer_check): Remove parameter `do_it_now',
12522 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12523 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12524 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12526 * keyboard.c (read_char):
12527 * w32menu.c (w32_menu_display_help):
12528 * xmenu.c (show_help_event, menu_help_callback):
12529 Adjust calls to `show_help_echo'.
12531 * gtkutil.c (xg_maybe_add_timer):
12532 * keyboard.c (readable_events):
12533 * process.c (wait_reading_process_output):
12534 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12536 * insdel.c (adjust_markers_gap_motion):
12537 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12538 (gap_left, gap_right): Don't call it.
12540 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12542 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12543 incurred during fontification.
12545 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12547 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12548 (DEFVAR_PER_BUFFER): Don't pass it.
12550 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12551 (scrolling_window): Don't pass it.
12553 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12555 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12557 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12559 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12560 of variables specific to SELinux and computation of `encoded_absname'.
12562 * image.c (XPutPixel): Remove unused variable `height'.
12564 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12566 * unexw32.c (get_section_info): Remove unused variable `section'.
12568 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12569 (system_process_attributes): Remove unused variable `sess'.
12570 (sys_read): Remove unused variable `err'.
12572 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12573 (w32_wnd_proc): Remove unused variable `isdead'.
12574 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12575 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12576 (x_create_tip_frame): Remove unused variable `tem'.
12578 * w32inevt.c (w32_console_read_socket):
12579 Remove unused variable `no_events'.
12581 * w32term.c (x_draw_composite_glyph_string_foreground):
12582 Remove unused variable `width'.
12584 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12586 * w32term.c (x_set_glyph_string_clipping):
12587 Don't pass uninitialized region to CombineRgn.
12589 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12591 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12592 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12593 (Fx_close_connection): Remove unused variable `i'.
12595 * w32font.c (w32font_draw): Return number of glyphs.
12596 (w32font_open_internal): Remove unused variable `i'.
12597 (w32font_driver): Add missing initializer.
12599 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12600 (fill_in_menu): Remove unused variable `items_added'.
12602 * w32term.c (last_mouse_press_frame): Remove static global variable.
12603 (w32_clip_to_row): Remove unused variable `f'.
12604 (x_delete_terminal): Remove unused variable `i'.
12606 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12607 (NOTHING): Remove unused static global variable.
12608 (uniscribe_check_otf): Remove unused variable `table'.
12609 (uniscribe_font_driver): Add missing initializers.
12611 2011-03-23 Julien Danjou <julien@danjou.info>
12613 * term.c (Fsuspend_tty, Fresume_tty):
12614 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12615 * window.c (temp_output_buffer_show):
12616 * insdel.c (signal_before_change):
12617 * frame.c (Fhandle_switch_frame):
12618 * fileio.c (Fdo_auto_save):
12619 * emacs.c (Fkill_emacs):
12620 * editfns.c (save_excursion_restore):
12621 * cmds.c (internal_self_insert):
12622 * callint.c (Fcall_interactively):
12623 * buffer.c (Fkill_all_local_variables):
12624 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12626 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12627 unconditionally since it does the check itself.
12629 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12631 Fix more problems found by GCC 4.5.2's static checks.
12633 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12634 the first time through the loop, since we know p0 < p1 then.
12635 This also avoids a gcc -Wstrict-overflow warning.
12637 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12638 leading to a memory leak, possible in functions like
12639 load_charset_map_from_file that can allocate an unbounded number
12640 of objects (Bug#8318).
12642 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12643 that could (at least in theory) be that large.
12645 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12646 This is less likely to overflow, and avoids undefined behavior if
12647 overflow does occur. All callers changed. Use strtoul to scan
12648 for the unsigned long integer.
12649 (pint2hrstr): Simplify and tune code slightly.
12650 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12652 * scroll.c (do_scrolling): Work around GCC bug 48228.
12653 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12655 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12656 This also avoids a warning with gcc -Wstrict-overflow.
12657 (validate_x_resource_name): Simplify count usage.
12658 This also avoids a warning with gcc -Wstrict-overflow.
12660 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12663 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12665 * process.c (Fmake_network_process): Use socklen_t, not int,
12666 where POSIX says socklen_t is required in portable programs.
12667 This fixes a porting bug on hosts like 64-bit HP-UX, where
12668 socklen_t is wider than int (Bug#8277).
12669 (Fmake_network_process, server_accept_connection):
12670 (wait_reading_process_output, read_process_output):
12673 * process.c: Rename or move locals to avoid shadowing.
12674 (list_processes_1, Fmake_network_process):
12675 (read_process_output_error_handler, exec_sentinel_error_handler):
12676 Rename or move locals.
12677 (Fmake_network_process): Define label "retry_connect" only if needed.
12678 (Fnetwork_interface_info): Fix pointer signedness.
12679 (process_send_signal): Add cast to avoid pointer signedness problem.
12680 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12681 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12683 Make tparam.h and terminfo.c consistent.
12684 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12685 Include tparam.h instead, since it declares them.
12686 * cm.h (PC): Remove extern decl; tparam.h now does this.
12687 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12688 * terminfo.c: Include tparam.h, to check interfaces.
12689 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12690 (tparam): Adjust signature to match interface in tparam.h;
12691 this removes some undefined behavior. Check that outstring and len
12692 are zero, which they always are with Emacs.
12693 * tparam.h (PC, BC, UP): New extern decls.
12695 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12696 (xftfont_open): Rename locals to avoid shadowing.
12698 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12699 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12700 (OTF_TAG_SYM): Omit macro if not needed.
12701 (ftfont_list): Remove unused local.
12702 (get_adstyle_property, ftfont_pattern_entity):
12703 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12704 Rename locals to avoid shadowing.
12706 * xfont.c (xfont_list_family): Mark var as initialized.
12708 * xml.c (make_dom): Now static.
12710 * composite.c (composition_compute_stop_pos): Rename local to
12712 (composition_reseat_it): Remove unused locals.
12713 (find_automatic_composition, composition_adjust_point): Likewise.
12714 (composition_update_it): Mark var as initialized.
12715 (find_automatic_composition): Mark vars as initialized,
12716 with a FIXME (Bug#8290).
12718 character.h: Rename locals to avoid shadowing.
12719 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12720 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12721 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12722 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12723 to avoid shadowing.
12725 * textprop.c (property_change_between_p): Remove; unused.
12727 * intervals.c (interval_start_pos): Now static.
12729 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12731 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12732 Rename locals to avoid shadowing.
12734 * sound.c (wav_play, au_play, Fplay_sound_internal):
12735 Fix pointer signedness.
12736 (alsa_choose_format): Remove unused local var.
12737 (wav_play): Initialize a variable to 0, to prevent undefined
12738 behavior (Bug#8278).
12740 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12742 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12744 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12745 clobbering (Bug#8298).
12746 * sysdep.c (sys_subshell): Likewise.
12747 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12749 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12750 This should get cleaned up, so that child_setup has the
12751 same signature on all platforms.
12753 * callproc.c (call_process_cleanup): Now static.
12754 (relocate_fd): Rename locals to avoid shadowing.
12756 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12758 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12759 not to be necessary, and produces flickering.
12761 2011-03-20 Glenn Morris <rgm@gnu.org>
12763 * config.in: Remove file.
12765 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12767 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12768 are now in src/globals.h.
12769 (syms_of_minibuf): Remove spurious & from previous change.
12771 2011-03-20 Leo Liu <sdl.web@gmail.com>
12773 * minibuf.c (completing-read-function): New variable.
12774 (completing-read-default): Rename from completing-read.
12775 (completing-read): Call completing-read-function.
12777 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12779 * xfaces.c (Fx_load_color_file):
12780 Read color file from absolute filename (bug#8250).
12782 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12784 * makefile.w32-in: Update dependencies.
12786 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12788 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12790 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12792 Fix more problems found by GCC 4.5.2's static checks.
12794 * process.c (make_serial_process_unwind, send_process_trap):
12795 (sigchld_handler): Now static.
12797 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12798 That way, the code declares only the vars that it needs.
12799 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12800 * s/cygwin.h (PTY_ITERATION): Likewise.
12801 * s/darwin.h (PTY_ITERATION): Likewise.
12802 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12804 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12805 * process.c (allocate_pty): Don't declare stb unless it's needed.
12807 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12808 (CONSTANTLIM): Remove; unused.
12809 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12810 Define only if needed.
12812 * unexelf.c (unexec): Name an expression,
12813 to avoid gcc -Wbad-function-cast warning.
12814 Use a different way to cause a compilation error if anyone uses
12815 n rather than nn, a way that does not involve shadowing.
12816 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12818 * deps.mk (unexalpha.o): Remove; unused.
12820 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12821 * unexec.h: New file.
12822 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12823 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12824 Depend on unexec.h.
12825 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12826 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12827 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12828 Change as necessary to match prototype in unexec.h.
12830 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12832 (back_comment, skip_chars): Mark vars as initialized.
12834 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12835 Rename locals to avoid shadowing.
12837 * lread.c (read1): Rewrite so as not to use empty "else".
12838 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12840 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12842 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12843 warning when compiling print.c.
12845 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12846 instead of using an uninitialized var.
12847 (font_sort_entities): Mark var as initialized.
12849 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12851 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12852 pointers to constants.
12853 (font_parse_fcname): Remove unused vars.
12854 (font_delete_unmatched): Now static.
12855 (font_get_spec): Remove; unused.
12856 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12857 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12858 Rename or move locals to avoid shadowing.
12860 * fns.c (require_nesting_list, require_unwind): Now static.
12861 (Ffillarray): Rename locals to avoid shadowing.
12863 * floatfns.c (domain_error2): Define only if needed.
12864 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12866 * alloc.c (mark_backtrace): Move decl from here ...
12867 * lisp.h: ... to here, so that it can be checked.
12869 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12870 (Fdefvar): Rewrite so as not to use empty "else".
12871 (lisp_indirect_variable): Name an expression,
12872 to avoid gcc -Wbad-function-cast warning.
12873 (Fdefvar): Rename locals to avoid shadowing.
12875 * callint.c (quotify_arg, quotify_args): Now static.
12876 (Fcall_interactively): Rename locals to avoid shadowing.
12877 Use const pointer when appropriate.
12879 * lisp.h (get_system_name, get_operating_system_release):
12880 Move decls here, to check interfaces.
12881 * process.c (get_operating_system_release): Move decl to lisp.h.
12882 * xrdb.c (get_system_name): Likewise.
12883 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12884 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12885 some of which prompt warnings from gcc -Wbad-function-cast.
12886 (Fformat_time_string, Fencode_time, Finsert_char):
12887 (Ftranslate_region_internal, Fformat):
12888 Rename or remove local vars to avoid shadowing.
12889 (Ftranslate_region_internal): Mark var as initialized.
12891 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12894 * lisp.h (eassert): Check that the argument compiles, even if
12895 ENABLE_CHECKING is not defined.
12897 * data.c (Findirect_variable): Name an expression, to avoid
12898 gcc -Wbad-function-cast warning.
12899 (default_value, arithcompare, arith_driver, arith_error): Now static.
12900 (store_symval_forwarding): Rename local to avoid shadowing.
12901 (Fmake_variable_buffer_local, Fmake_local_variable):
12902 Mark variables as initialized.
12903 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12905 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12906 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12907 Rename locals to avoid shadowing.
12908 (mark_stack): Move local variables into the #ifdef region where
12910 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12911 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12913 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12914 (GC_STRING_CHARS): Remove; not used.
12915 (Fmemory_limit): Cast sbrk's returned value to char *.
12917 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12918 avoids undefined behavior in theory.
12920 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12922 Use functions, not macros, for up- and down-casing (Bug#8254).
12923 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12924 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12925 to use the following functions instead of these macros.
12926 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12927 EMACS_INT, since callers assume the returned value fits in int.
12928 (upcase1): Likewise, for UPCASE_TABLE.
12929 (uppercasep, lowercasep, upcase): New static inline functions.
12930 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12931 the race-condition problem in the old DOWNCASE.
12933 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12934 Rename locals to avoid shadowing.
12935 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12936 (regex_compile, re_search_2, re_match_2_internal):
12937 Remove unused local vars.
12938 (FREE_VAR): Rewrite so as not to use empty "else",
12939 which gcc can warn about.
12940 (regex_compile, re_match_2_internal): Mark locals as initialized.
12941 (RETALLOC_IF): Define only if needed.
12942 (WORDCHAR_P): Likewise. This one is never needed, but is used
12943 only in a comment talking about a compiler bug, so put inside
12944 the #if 0 of that comment.
12945 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12946 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12949 * search.c (boyer_moore): Rename locals to avoid shadowing.
12950 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12951 (PREV_CHAR_BOUNDARY): Likewise.
12953 * search.c (simple_search): Remove unused var.
12955 * dired.c (compile_pattern): Move decl from here ...
12956 * lisp.h: ... to here, so that it can be checked.
12957 (struct re_registers): New forward decl.
12959 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12961 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12963 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12964 Rename locals to avoid shadowing.
12965 (Fvertical_motion): Mark locals as initialized.
12967 * casefiddle.c (casify_object, casify_region): Now static.
12968 (casify_region): Mark local as initialized.
12970 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12972 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12973 New macros, so that the caller can use some names other than
12974 gcpro1, gcpro2, etc.
12975 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12977 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12978 argument, for consistency with GCPRO2_VAR, etc: it is now the
12979 prefix of the variable, not the variable itself. All uses
12981 * dired.c (directory_files_internal, file_name_completion):
12982 Rename locals to avoid shadowing.
12984 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12985 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12986 dired.c's scmp function, had undefined behavior.
12987 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12988 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12989 * buffer.h: ... to here, because these macros use current_buffer,
12990 and the new implementation with inline functions needs to have
12991 current_buffer in scope now, rather than later when the macros
12993 (downcase, upcase1): New static inline functions.
12994 (DOWNCASE, UPCASE1): Reimplement using these functions.
12995 This avoids undefined behavior in expressions like
12996 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12997 from race conditions in accessing the global variables
12998 case_temp1 and case_temp2.
12999 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13000 * lisp.h (case_temp1, case_temp2): Remove their decls.
13001 * character.h (ASCII_CHAR_P): Move from here ...
13002 * lisp.h: ... to here, so that the inline functions mentioned
13003 above can use them.
13005 * dired.c (directory_files_internal_unwind): Now static.
13007 * fileio.c (file_name_as_directory, directory_file_name):
13008 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13010 (file_name_as_directory): Use const pointers when appropriate.
13011 (Fexpand_file_name): Likewise. In particular, newdir might
13012 point at constant storage, so make it a const pointer.
13013 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13014 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13016 (Fset_file_times, Finsert_file_contents, auto_save_error):
13017 Rename locals to avoid shadowing.
13019 * minibuf.c (choose_minibuf_frame_1): Now static.
13020 (Ftry_completion, Fall_completions): Rename or remove locals
13021 to avoid shadowing.
13023 * marker.c (bytepos_to_charpos): Remove; unused.
13025 * lisp.h (verify_bytepos, count_markers): New decls,
13026 so that gcc does not warn that these functions aren't declared.
13028 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13029 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13030 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13031 (copy_text): Remove unused local var.
13033 * filelock.c (within_one_second): Now static.
13034 (lock_file_1): Rename local to avoid shadowing.
13036 * buffer.c (fix_overlays_before): Mark locals as initialized.
13037 (fix_start_end_in_overlays): Likewise. This function should be
13038 simplified by using pointers-to-pointers, but that's a different
13040 (switch_to_buffer_1): Now static.
13041 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13042 (report_overlay_modification): Rename locals to avoid shadowing.
13044 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13045 Fix pointer signedness issue.
13046 (sys_subshell): Mark local as volatile if checking for lint,
13047 to suppress a gcc -Wclobbered warning that does not seem to be right.
13048 (MAXPATHLEN): Define only if needed.
13050 * process.c (serial_open, serial_configure): Move decls from here ...
13051 * systty.h: ... to here, so that they can be checked.
13053 * fns.c (get_random, seed_random): Move extern decls from here ...
13054 * lisp.h: ... to here, so that they can be checked.
13056 * sysdep.c (reset_io): Now static.
13057 (wait_for_termination_signal): Remove; unused.
13059 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13060 (copy_keymap_item, append_key, push_text_char_description):
13062 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13063 (DENSE_TABLE_SIZE): Remove; unused.
13064 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13065 (describe_map_tree):
13066 Rename locals to avoid shadowing.
13068 * keyboard.c: Declare functions static if they are not used elsewhere.
13069 (echo_char, echo_dash, cmd_error, top_level_2):
13070 (poll_for_input, handle_async_input): Now static.
13071 (read_char, kbd_buffer_get_event, make_lispy_position):
13072 (make_lispy_event, make_lispy_movement, apply_modifiers):
13073 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13074 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13075 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13076 (read_key_sequence, read_char): Mark locals as initialized.
13077 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13079 * keyboard.h (make_ctrl_char): New decl.
13080 (mark_kboards): Move decl here ...
13081 * alloc.c (mark_kboards): ... from here.
13083 * lisp.h (force_auto_save_soon): New decl.
13085 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13086 (DEFINE_DUMMY_FUNCTION): New macro.
13087 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13089 (main): Add casts to avoid warnings
13090 if GCC considers string literals to be constants.
13092 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13094 * dbusbind.c: Pointer signedness fixes.
13095 (xd_signature, xd_append_arg, xd_initialize):
13096 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13097 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13098 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13099 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13101 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13102 if GCC considers string literals to be constants.
13103 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13105 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13107 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13108 (print_preprocess, print_object): New macro to fix last change.
13110 * print.c (print_preprocess): Don't forget font objects.
13112 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13114 * emacs.c (USAGE3): Doc fixes.
13116 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13118 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13121 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13123 * lisp.h (VWindow_system, Qfile_name_history):
13124 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13125 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13126 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13128 * w32select.c: Don't #include "keyboard.h".
13129 (run_protected): Add extern declaration for waiting_for_input.
13131 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13132 * w32console.c (detect_input_pending, read_input_pending)
13133 (encode_terminal_code):
13134 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13135 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13136 (w32_system_caret_y, Qfile_name_history):
13137 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13138 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13139 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13140 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13141 * w32proc.c (Qlocal, report_file_error):
13142 * w32term.c (Vwindow_system, updating_frame):
13143 * w32uniscribe.c (initialized, uniscribe_font_driver):
13144 Remove unneeded extern declarations.
13146 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13148 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13150 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13152 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13153 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13154 These macros can no longer be used for assignment.
13156 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13157 Assign struct members directly, instead of using BUF_BEGV etc.
13158 (record_buffer_markers, fetch_buffer_markers): New functions for
13159 recording and fetching special buffer markers.
13160 (set_buffer_internal_1, set_buffer_temp): Use them.
13162 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13164 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13166 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13167 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13169 * xdisp.c (hscroll_window_tree):
13170 (reconsider_clip_changes): Use PT instead of BUF_PT.
13172 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13174 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13175 $(EMACS_ROOT)/lib/intprops.h.
13177 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13179 Fix more problems found by GCC 4.5.2's static checks.
13181 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13182 to unsigned char * to avoid compiler diagnostic.
13183 (xg_free_frame_widgets): Make it clear that a local variable is
13184 needed only if USE_GTK_TOOLTIP.
13185 (gdk_window_get_screen): Make it clear that this macro is needed
13186 only if USE_GTK_TOOLTIP.
13187 (int_gtk_range_get_value): New function, which avoids a diagnostic
13188 from gcc -Wbad-function-cast.
13189 (xg_set_toolkit_scroll_bar_thumb): Use it.
13190 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13191 diagnostic from gcc -Wbad-function-cast.
13192 (get_utf8_string, xg_get_file_with_chooser):
13193 Rename locals to avoid shadowing.
13194 (create_dialog): Move locals to avoid shadowing.
13196 * xgselect.c (xg_select): Remove unused var.
13198 * image.c (four_corners_best): Mark locals as initialized.
13199 (gif_load): Initialize transparent_p to zero (Bug#8238).
13200 Mark another local as initialized.
13201 (my_png_error, my_error_exit): Mark with NO_RETURN.
13203 * image.c (clear_image_cache): Now static.
13204 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13205 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13206 (x_edge_detection): Remove unnecessary cast that
13207 gcc -Wbad-function-cast diagnoses.
13208 (gif_load): Fix pointer signedness.
13209 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13210 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13212 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13214 Improve quality of tests for time stamp overflow.
13215 For example, without this patch (encode-time 0 0 0 1 1
13216 1152921504606846976) returns the obviously-bogus value (-948597
13217 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13218 reports time overflow. See
13219 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13220 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13221 * editfns.c: Include limits.h and intprops.h.
13222 (TIME_T_MIN, TIME_T_MAX): New macros.
13223 (time_overflow): Move earlier, to before first use.
13224 (hi_time, lo_time): New functions, for an accurate test for
13225 out-of-range times.
13226 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13227 (Fget_internal_run_time): Don't assume time_t fits in int.
13228 (make_time): Use list2 instead of Fcons twice.
13229 (Fdecode_time): More accurate test for out-of-range times.
13230 (check_tm_member): New function.
13231 (Fencode_time): Use it, to test for out-of-range times.
13232 (lisp_time_argument): Don't rely on undefined left-shift and
13233 right-shift behavior when checking for time stamp overflow.
13235 * editfns.c (time_overflow): New function, refactoring common code.
13236 (Fformat_time_string, Fdecode_time, Fencode_time):
13237 (Fcurrent_time_string): Use it.
13239 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13240 * dired.c (make_time): Move to ...
13241 * editfns.c (make_time): ... here.
13242 * systime.h: Note the move.
13244 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13246 * fringe.c (update_window_fringes): Remove unused variables.
13248 * unexmacosx.c (copy_data_segment): Also copy __got section.
13251 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13253 * termcap.c [MSDOS]: Include "msdos.h".
13254 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13255 Constify `char *' arguments and their references according to
13256 prototypes in tparam.h.
13258 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13260 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13261 Adapt all references accordingly.
13263 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13265 2011-03-11 Tom Tromey <tromey@redhat.com>
13267 * buffer.c (syms_of_buffer): Remove obsolete comment.
13269 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13271 * termhooks.h (encode_terminal_code): Declare prototype.
13273 * msdos.c (encode_terminal_code): Don't declare prototype.
13275 * term.c (encode_terminal_code): Now external again, used by
13276 w32console.c and msdos.c.
13278 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13279 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13281 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13283 Fix some minor problems found by GCC 4.5.2's static checks.
13285 * fringe.c (update_window_fringes): Mark locals as initialized
13287 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13289 * alloc.c (mark_fringe_data): Move decl from here ...
13290 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13291 to check its interface.
13292 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13294 * fontset.c (free_realized_fontset): Now static.
13295 (Fset_fontset_font): Rename local to avoid shadowing.
13296 (fontset_font): Mark local as initialized.
13297 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13299 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13301 * xselect.c (x_disown_buffer_selections): Remove; not used.
13302 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13303 (x_own_selection, Fx_disown_selection_internal): Rename locals
13304 to avoid shadowing.
13305 (x_handle_dnd_message): Remove local to avoid shadowing.
13307 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13308 so that the caller can use some name other than gcpro1.
13309 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13310 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13311 (Fx_backspace_delete_keys_p):
13312 Use them to avoid shadowing, and rename vars to avoid shadowing.
13313 (x_decode_color, x_set_name, x_window): Now static.
13314 (Fx_create_frame): Add braces to silence GCC warning.
13315 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13316 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13317 Remove unused locals.
13318 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13319 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13320 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13323 * xterm.h (x_mouse_leave): New decl.
13325 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13326 Remove unused functions.
13327 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13328 (x_calc_absolute_position): Now static.
13329 (XTread_socket): Don't define label "out" unless it's used.
13330 Don't declare local "event" unless it's used.
13331 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13332 unless they are used.
13333 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13334 (x_fatal_error_signal): Remove; not used.
13335 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13336 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13337 (x_error_catcher, x_connection_closed, x_error_handler):
13338 (x_error_quitter, xembed_send_message, x_iconify_frame):
13339 (my_log_handler): Rename locals to avoid shadowing.
13340 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13341 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13343 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13344 Rename or move locals to avoid shadowing.
13345 (tty_defined_color, merge_face_heights): Now static.
13346 (free_realized_faces_for_fontset): Remove; not used.
13347 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13348 does not deduce is never used uninitialized.
13349 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13350 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13352 * terminal.c (store_terminal_param): Now static.
13354 * xmenu.c (menu_highlight_callback): Now static.
13355 (set_frame_menubar): Remove unused local.
13356 (xmenu_show): Rename parameter to avoid shadowing.
13357 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13358 since they might point to immutable storage.
13359 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13360 since it's unused otherwise.
13362 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13363 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13364 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13365 avoids a gcc -Wuninitialized diagnostic.
13366 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13367 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13368 does not deduce are never used uninitialized.
13370 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13372 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13373 * window.c (window_loop, size_window):
13374 (run_window_configuration_change_hook, enlarge_window): Likewise.
13376 * window.c (display_buffer): Now static.
13377 (size_window): Mark variables that gcc -Wuninitialized
13378 does not deduce are never used uninitialized.
13379 * window.h (check_all_windows): New decl, to forestall
13380 gcc -Wmissing-prototypes diagnostic.
13381 * dispextern.h (bidi_dump_cached_states): Likewise.
13383 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13385 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13386 Include <limits.h>.
13387 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13388 and to avoid gcc -Wuninitialized warning.
13389 (load_charset_map): Mark variables that gcc -Wuninitialized
13390 does not deduce are never used uninitialized.
13391 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13393 * coding.c (coding_set_source, coding_set_destination):
13394 Use "else { /* comment */ }" rather than "else /* comment */;"
13395 for clarity, and to avoid gcc -Wempty-body warning.
13396 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13397 a block, when the outer 'i' will do.
13398 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13399 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13400 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13401 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13402 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13403 Rename locals to avoid shadowing.
13404 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13405 * coding.c (emacs_mule_char, encode_invocation_designation):
13406 Now static, since they're not used elsewhere.
13407 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13408 (decode_coding_object, encode_coding_object, detect_coding_system):
13409 (decode_coding_emacs_mule): Mark variables that gcc
13410 -Wuninitialized does not deduce are never used uninitialized.
13411 (detect_coding_iso_2022): Initialize a local variable that might
13412 be used uninitialized. Leave a FIXME because it's not clear that
13413 this initialization is needed. (Bug#8211)
13414 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13415 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13416 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13417 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13418 Remove unused macros.
13420 * category.c (hash_get_category_set): Remove unused local var.
13421 (copy_category_table): Now static, since it's not used elsewhere.
13422 * character.c (string_count_byte8): Likewise.
13424 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13425 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13427 * chartab.c (copy_sub_char_table): Now static, since it's not used
13429 (sub_char_table_ref_and_range, char_table_ref_and_range):
13430 Rename locals to avoid shadowing.
13431 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13433 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13434 (BIDI_BOB): Remove unused macro.
13436 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13437 deduce are never used uninitialized.
13438 * term.c (encode_terminal_code): Likewise.
13440 * term.c (encode_terminal_code): Now static. Remove unused local.
13442 * tparam.h: New file.
13443 * term.c, tparam.h: Include it.
13444 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13445 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13446 Move these decls to tparam.h, and make them agree with what
13447 is actually in tparam.c. The previous trick of using incompatible
13448 decls in different modules does not conform to the C standard.
13449 All callers of tparam changed to use tparam's actual API.
13450 * tparam.c (tparam1, tparam, tgoto):
13451 Use const pointers where appropriate.
13453 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13454 * cm.h (struct cm): Likewise.
13455 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13456 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13457 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13458 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13459 (turn_on_face, init_tty): Likewise.
13460 * termchar.h (struct tty_display_info): Likewise.
13462 * term.c (term_mouse_position): Rename local to avoid shadowing.
13464 * alloc.c (mark_ttys): Move decl from here ...
13465 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13467 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13469 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13471 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13473 * search.c (compile_pattern_1): Remove argument regp, unused since
13474 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13475 (compile_pattern): Don't pass it.
13477 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13479 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13480 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13482 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13484 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13486 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13487 gdk_window_get_screen, gdk_window_get_geometry,
13488 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13489 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13490 (xg_get_pixbuf_from_pixmap): New function.
13491 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13492 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13493 Call xg_get_pixbuf_from_pixmap instead of
13494 gdk_pixbuf_get_from_drawable.
13495 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13496 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13497 (xg_check_special_colors): Use GtkStyleContext and its functions
13499 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13500 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13501 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13502 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13503 Call gtk_widget_get_preferred_size.
13504 (xg_frame_resized): gdk_window_get_geometry only takes 5
13506 (xg_win_to_widget, xg_event_is_for_menubar):
13507 Call gdk_x11_window_lookup_for_display.
13508 (xg_set_widget_bg): New function.
13509 (delete_cb): New function.
13510 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13511 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13512 (xg_set_background_color): Call xg_set_widget_bg.
13513 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13514 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13515 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13516 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13518 (update_frame_tool_bar): Call gtk_widget_hide.
13519 (xg_initialize): Use GDK_KEY_g.
13521 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13523 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13525 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13526 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13527 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13529 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13531 * w32xfns.c (select_palette): Check success of RealizePalette against
13532 GDI_ERROR, not zero.
13534 See ChangeLog.11 for earlier changes.
13536 ;; Local Variables:
13540 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13542 This file is part of GNU Emacs.
13544 GNU Emacs is free software: you can redistribute it and/or modify
13545 it under the terms of the GNU General Public License as published by
13546 the Free Software Foundation, either version 3 of the License, or
13547 (at your option) any later version.
13549 GNU Emacs is distributed in the hope that it will be useful,
13550 but WITHOUT ANY WARRANTY; without even the implied warranty of
13551 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13552 GNU General Public License for more details.
13554 You should have received a copy of the GNU General Public License
13555 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.