]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
[gnu-emacs] / src / ChangeLog
1 2011-06-09 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4 not to EMACS_INT, to avoid GCC warning.
5
6 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7
8 * buffer.h (PTR_BYTE_POS): Don't assume a byte count fits in 'unsigned'.
9
10 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
11 (advance_to_char_boundary): Return EMACS_INT, not int.
12
13 * data.c (Qcompiled_function): Now static.
14
15 2011-06-08 Paul Eggert <eggert@cs.ucla.edu>
16
17 * window.c (window_body_lines): Now static.
18
19 * image.c (gif_load): Rename local to avoid shadowing.
20
21 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
22 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
23 * alloc.c (make_save_value): Integer argument is now of type
24 ptrdiff_t, not int.
25 (mark_object): Use ptrdiff_t, not int.
26 * lisp.h (pD): New macro.
27 * print.c (print_object): Use it.
28
29 * alloc.c: Use EMACS_INT, not int, to count objects.
30 (total_conses, total_markers, total_symbols, total_vector_size)
31 (total_free_conses, total_free_markers, total_free_symbols)
32 (total_free_floats, total_floats, total_free_intervals, total_intervals)
33 (total_strings, total_free_strings):
34 Now EMACS_INT, not int. All uses changed.
35 (Fgarbage_collect): Compute overall total using a double, so that
36 integer overflow is less likely to be a problem. Check for overflow
37 when converting back to an integer.
38 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
39 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
40 These were 'int' variables that could overflow on 64-bit hosts;
41 they were never used, so remove them instead of repairing them.
42 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
43 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
44 Previously, this ceilinged at INT_MAX, but that doesn't work on
45 64-bit machines.
46 (allocate_pseudovector): Don't use EMACS_INT when int would do.
47
48 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
49 (allocate_vectorlike): Check for ptrdiff_t overflow.
50 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
51 when a (possibly-narrower) signed value would do just as well.
52 We prefer using signed arithmetic, to avoid comparison confusion.
53
54 * alloc.c: Catch some string size overflows that we were missing.
55 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
56 for convenience in STRING_BYTES_MAX.
57 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
58 The definition here is exact; the one in lisp.h was approximate.
59 (allocate_string_data): Check for string overflow. This catches
60 some instances we weren't catching before. Also, it catches
61 size_t overflow on (unusual) hosts where SIZE_MAX <= min
62 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
63 and ptrdiff_t and EMACS_INT are both 64 bits.
64
65 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
66 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
67 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
68
69 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
70
71 * alloc.c (Fmake_string): Check for out-of-range init.
72
73 2011-06-08 Martin Rudalics <rudalics@gmx.at>
74
75 * window.h (window): Add some new members to window structure -
76 normal_lines, normal_cols, new_total, new_normal, clone_number,
77 splits, nest, prev_buffers, next_buffers.
78 (WINDOW_TOTAL_SIZE): Move here from window.c.
79 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
80
81 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
82 Remove.
83 (make_dummy_parent): Set new members of windows structure.
84 (make_window): Move down in code. Handle new members of window
85 structure.
86 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
87 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
88 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
89 (Fset_window_prev_buffers, Fwindow_next_buffers)
90 (Fset_window_next_buffers, Fset_window_clone_number): New
91 functions.
92 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
93 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
94 Doc-string fixes.
95 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
96 Argument WINDOW can be now internal window too.
97 (Fwindow_use_time): Move up in code.
98 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
99 Rewrite doc-string.
100 (Fset_window_configuration, saved_window)
101 (Fcurrent_window_configuration, save_window_save): Handle new
102 members of window structure.
103 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
104 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
105 (syms_of_window): New Lisp objects Qrecord_window_buffer,
106 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
107 Qget_mru_window, Qresize_root_window,
108 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
109 Qauto_buffer_name; staticpro them.
110
111 2011-06-07 Martin Rudalics <rudalics@gmx.at>
112
113 * window.c (Fwindow_total_size, Fwindow_left_column)
114 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
115 (Fwindow_list_1): New functions.
116 (window_box_text_cols): Replace with window_body_cols.
117 (Fwindow_width, Fscroll_left, Fscroll_right): Use
118 window_body_cols instead of window_box_text_cols.
119 (delete_window, Fset_window_configuration): Call
120 delete_all_subwindows with window as argument.
121 (delete_all_subwindows): Take a window as argument and not a
122 structure. Rewrite.
123 (window_loop): Remove handling of GET_LRU_WINDOW and
124 GET_LARGEST_WINDOW.
125 (Fget_lru_window, Fget_largest_window): Move to window.el.
126
127 * window.h: Extern window_body_cols instead of
128 window_box_text_cols. delete_all_subwindows now takes a
129 Lisp_Object as argument.
130
131 * indent.c (compute_motion, Fcompute_motion): Use
132 window_body_cols instead of window_box_text_cols.
133
134 * frame.c (delete_frame): Call delete_all_subwindows with root
135 window as argument.
136
137 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
138
139 * fns.c (Fputhash): Document return value.
140
141 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
142
143 * image.c (gif_load): Implement gif89a spec "no disposal" method.
144
145 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
146
147 Cons<->int and similar integer overflow fixes (Bug#8794).
148
149 Check for overflow when converting integer to cons and back.
150 * charset.c (Fdefine_charset_internal, Fdecode_char):
151 Use cons_to_unsigned to catch overflow.
152 (Fencode_char): Use INTEGER_TO_CONS.
153 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
154 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
155 * data.c (long_to_cons, cons_to_long): Remove.
156 (cons_to_unsigned, cons_to_signed): New functions.
157 These signal an error for invalid or out-of-range values.
158 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
159 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
160 * font.c (Ffont_variation_glyphs):
161 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
162 * lisp.h: Include <intprops.h>.
163 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
164 (cons_to_signed, cons_to_unsigned): New decls.
165 (long_to_cons, cons_to_long): Remove decls.
166 * undo.c (record_first_change): Use INTEGER_TO_CONS.
167 (Fprimitive_undo): Use CONS_TO_INTEGER.
168 * xfns.c (Fx_window_property): Likewise.
169 * xselect.c: Include <limits.h>.
170 (x_own_selection, selection_data_to_lisp_data):
171 Use INTEGER_TO_CONS.
172 (x_handle_selection_request, x_handle_selection_clear)
173 (x_get_foreign_selection, Fx_disown_selection_internal)
174 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
175 (lisp_data_to_selection_data): Use cons_to_unsigned.
176 (x_fill_property_data): Use cons_to_signed.
177 Report values out of range.
178
179 Check for buffer and string overflow more precisely.
180 * buffer.h (BUF_BYTES_MAX): New macro.
181 * lisp.h (STRING_BYTES_MAX): New macro.
182 * alloc.c (Fmake_string):
183 * character.c (string_escape_byte8):
184 * coding.c (coding_alloc_by_realloc):
185 * doprnt.c (doprnt):
186 * editfns.c (Fformat):
187 * eval.c (verror):
188 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
189 since they may not be the same number.
190 * editfns.c (Finsert_char):
191 * fileio.c (Finsert_file_contents):
192 Likewise for BUF_BYTES_MAX.
193
194 * image.c: Use ptrdiff_t, not int, for sizes.
195 (slurp_file): Switch from int to ptrdiff_t.
196 All uses changed.
197 (slurp_file): Check that file size fits in both size_t (for
198 malloc) and ptrdiff_t (for sanity and safety).
199
200 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
201 if b->modtime has its maximal value.
202
203 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
204
205 Don't assume time_t can fit into int.
206 * buffer.h (struct buffer.modtime): Now time_t, not int.
207 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
208 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
209
210 Minor fixes for signed vs unsigned integers.
211 * character.h (MAYBE_UNIFY_CHAR):
212 * charset.c (maybe_unify_char):
213 * keyboard.c (read_char, reorder_modifiers):
214 XINT -> XFASTINT, since the integer must be nonnegative.
215 * ftfont.c (ftfont_spec_pattern):
216 * keymap.c (access_keymap, silly_event_symbol_error):
217 XUINT -> XFASTINT, since the integer must be nonnegative.
218 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
219 since it makes no difference and we prefer signed.
220 * keyboard.c (record_char): Use XUINT when all the neighbors do.
221 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
222 nonnegative.
223
224 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
225
226 * window.h (Fwindow_frame): Declare.
227
228 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
229
230 * alloc.c: Simplify handling of large-request failures (Bug#8800).
231 (SPARE_MEMORY): Always define.
232 (LARGE_REQUEST): Remove.
233 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
234
235 2011-06-06 Martin Rudalics <rudalics@gmx.at>
236
237 * lisp.h: Move EXFUNS for Fframe_root_window,
238 Fframe_first_window and Fset_frame_selected_window to window.h.
239
240 * window.h: Move EXFUNS for Fframe_root_window,
241 Fframe_first_window and Fset_frame_selected_window here from
242 lisp.h.
243
244 * frame.c (Fwindow_frame, Fframe_first_window)
245 (Fframe_root_window, Fframe_selected_window)
246 (Fset_frame_selected_window): Move to window.c.
247 (Factive_minibuffer_window): Move to minibuf.c.
248 (Fother_visible_frames_p): New function.
249
250 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
251
252 * window.c (decode_window, decode_any_window): Move up in code.
253 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
254 (inhibit_frame_unsplittable): Remove unused variable.
255 (Fwindow_buffer): Move up and rewrite doc-string.
256 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
257 (Fwindow_prev): New functions.
258 (Fwindow_frame): Move here from frame.c. Accept any window as
259 argument.
260 (Fframe_root_window, Fframe_first_window)
261 (Fframe_selected_window): Move here from frame.c. Accept frame
262 or arbitrary window as argument. Update doc-strings.
263 (Fminibuffer_window): Move up in code.
264 (Fwindow_minibuffer_p): Move up in code and simplify.
265 (Fset_frame_selected_window): Move here from frame.c.
266 Marginal rewrite.
267 (Fselected_window, select_window, Fselect_window): Move up in
268 code. Minor doc-string fixes.
269
270 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
271
272 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
273 Do not assume that spare memory exists; that assumption is valid
274 only if SYSTEM_MALLOC.
275 (LARGE_REQUEST): New macro, so that the issue of large requests
276 is separated from the issue of spare memory.
277
278 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
279
280 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
281 format. (Bug#8806)
282
283 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
284
285 * xfns.c (x_set_scroll_bar_default_width): Move declarations
286 before statements.
287
288 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
289
290 * gtkutil.c (xg_get_default_scrollbar_width): New function.
291
292 * gtkutil.h: Declare xg_get_default_scrollbar_width.
293
294 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
295 min width by calling x_set_scroll_bar_default_width (Bug#8505).
296
297 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
298
299 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
300
301 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
302
303 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
304 (x_clipboard_manager_save): Add return value.
305 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
306 New error handlers.
307 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
308 Obey Vx_select_enable_clipboard_manager. Catch errors in
309 x_clipboard_manager_save (Bug#8779).
310 (Vx_select_enable_clipboard_manager): New variable.
311 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
312
313 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
314
315 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
316
317 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
318
319 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
320 in the current matrix if keep_current_p is non-zero.
321
322 2011-06-04 Eli Zaretskii <eliz@gnu.org>
323
324 * bidi.c (bidi_level_of_next_char): Fix last change.
325
326 2011-06-03 Eli Zaretskii <eliz@gnu.org>
327
328 Support bidi reordering of text covered by display properties.
329
330 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
331 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
332 (bidi_cache_search, bidi_cache_iterator_state)
333 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
334 (bidi_level_of_next_char, bidi_move_to_visually_next):
335 Support character positions inside a run of characters covered by a
336 display string.
337 (bidi_paragraph_init, bidi_resolve_explicit_1)
338 (bidi_level_of_next_char): Call bidi_fetch_char and
339 bidi_fetch_char_advance instead of FETCH_CHAR and
340 FETCH_CHAR_ADVANCE.
341 (bidi_init_it): Initialize new members.
342 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
343 definitions.
344 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
345 instead of using explicit *_CHAR codes.
346 (bidi_resolve_explicit, bidi_resolve_weak):
347 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
348 bidirectional text is supported only in multibyte buffers.
349 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
350 it to initialize the frame_window_p member of struct bidi_it.
351 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
352 (bidi_resolve_explicit, bidi_resolve_weak)
353 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
354 bidi_it->nchars is non-positive.
355 (bidi_level_of_next_char): Don't try to lookup the cache for the
356 next/previous character if nothing is cached there yet, or if we
357 were just reseat()'ed to a new position.
358
359 * xdisp.c (set_cursor_from_row): Set start and stop points
360 according to the row's direction when priming the loop that looks
361 for the glyph on which to display cursor.
362 (single_display_spec_intangible_p): Function deleted.
363 (display_prop_intangible_p): Reimplement to call
364 handle_display_spec instead of single_display_spec_intangible_p.
365 Accept 3 additional arguments needed by handle_display_spec.
366 This fixes incorrect cursor motion across display property with complex
367 values: lists, `(when COND...)' forms, etc.
368 (single_display_spec_string_p): Support property values that are
369 lists with the argument STRING its top-level element.
370 (display_prop_string_p): Fix the condition for processing a
371 property that is a list to be consistent with handle_display_spec.
372 (handle_display_spec): New function, refactored from the
373 last portion of handle_display_prop.
374 (compute_display_string_pos): Accept additional argument
375 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
376 value of a `display' property is a "replacing spec".
377 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
378 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
379 the display property, but just return a value indicating whether
380 the display property will replace the characters it covers.
381 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
382 frame_window_p members of struct bidi_it.
383 (compute_display_string_pos, compute_display_string_end):
384 New functions.
385 (push_it): Accept second argument POSITION, where pop_it should
386 jump to continue iteration.
387 (reseat_1): Initialize bidi_it.disp_pos.
388
389 * keyboard.c (adjust_point_for_property): Adjust the call to
390 display_prop_intangible_p to its new signature.
391
392 * dispextern.h (struct bidi_it): New member frame_window_p.
393 (bidi_init_it): Update prototypes.
394 (display_prop_intangible_p): Update prototype.
395 (compute_display_string_pos, compute_display_string_end):
396 Declare prototypes.
397 (struct bidi_it): New members nchars and disp_pos. ch_len is now
398 EMACS_INT.
399
400 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
401
402 Malloc failure behavior now depends on size of allocation.
403 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
404 * lisp.h: Change signatures accordingly.
405 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
406 All callers changed. (Bug#8762)
407
408 * gnutls.c: Use Emacs's memory allocators.
409 Without this change, the gnutls library would invoke malloc etc.
410 directly, which causes problems on non-SYNC_INPUT hosts, and which
411 runs afoul of improving memory_full behavior. (Bug#8761)
412 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
413 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
414 xfree instead of the default malloc, realloc, free.
415 (Fgnutls_boot): No need to check for memory allocation failure,
416 since xmalloc does that for us.
417
418 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
419 * category.c (hash_get_category_set):
420 * ccl.c (ccl_driver):
421 * charset.c (Fdefine_charset_internal):
422 * charset.h (struct charset.hash_index):
423 * composite.c (get_composition_id, gstring_lookup_cache)
424 (composition_gstring_put_cache):
425 * composite.h (struct composition.hash_index):
426 * dispextern.h (struct image.hash):
427 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
428 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
429 (hashfn_equal, hashfn_user_defined, make_hash_table)
430 (maybe_resize_hash_table, hash_lookup, hash_put)
431 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
432 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
433 (Fsxhash, Fgethash, Fputhash, Fmaphash):
434 * image.c (make_image, search_image_cache, lookup_image)
435 (xpm_put_color_table_h):
436 * lisp.h (struct Lisp_Hash_Table):
437 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
438 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
439 for hashes and hash indexes, instead of 'unsigned' and 'int'.
440 * alloc.c (allocate_vectorlike):
441 Check for overflow in vector size calculations.
442 * ccl.c (ccl_driver):
443 Check for overflow when converting EMACS_INT to int.
444 * fns.c, image.c: Remove unnecessary static decls that would otherwise
445 need to be updated by these changes.
446 * fns.c (make_hash_table, maybe_resize_hash_table):
447 Check for integer overflow with large hash tables.
448 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
449 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
450 (SXHASH_REDUCE): New macro.
451 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
452 Use it instead of discarding useful hash info with large hash values.
453 (sxhash_float): New function.
454 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
455 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
456 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
457 Rewrite to use FIXNUM_BITS, as this simplifies things.
458 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
459 Adjust signatures to match updated version of code.
460 (consing_since_gc): Now EMACS_INT, since a single hash table can
461 use more than INT_MAX bytes.
462
463 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
464
465 Make it possible to build with GCC-4.6+ -O2 -flto.
466
467 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
468
469 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
470
471 * minibuf.c (get_minibuffer, read_minibuf_unwind):
472 Call minibuffer-inactive-mode.
473
474 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
475
476 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
477 Update dependencies.
478
479 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
480
481 * data.c (init_data): Remove code for UTS, this system is not
482 supported anymore.
483
484 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
485
486 Don't force ./temacs to start in terminal mode.
487
488 * frame.c (make_initial_frame): Initialize faces in all cases, not
489 only when CANNOT_DUMP is defined.
490 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
491
492 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
493
494 * dispnew.c (add_window_display_history): Use const for the string
495 pointer. Remove declaration, not needed.
496
497 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
498
499 Use 'inline', not 'INLINE'.
500 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
501 * alloc.c, fontset.c (INLINE): Remove.
502 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
503 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
504 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
505 * gmalloc.c (register_heapinfo): Use inline unconditionally.
506 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
507
508 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
509
510 Make it possible to run ./temacs.
511
512 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
513 syms_of_callproc does the same thing. Remove test for
514 "initialized", do it in the caller.
515 * emacs.c (main): Avoid calling set_initial_environment when dumping.
516
517 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
518
519 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
520 (read_minibuf): Use get_minibuffer.
521 (syms_of_minibuf): Use DEFSYM.
522 (Qmetadata): New var.
523 * data.c (Qbuffer): Don't make it static.
524 (syms_of_data): Use DEFSYM.
525
526 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
527
528 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
529 (CCL_CODE_MIN): New macro.
530
531 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
532
533 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
534
535 * eval.c (Qdebug): Now static.
536 * lisp.h (Qdebug): Remove decl. This reverts a part of the
537 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
538 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
539
540 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
541
542 * image.c: Various fixes to ImageMagick code comments.
543 (Fimagemagick_types): Doc fix.
544
545 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
546
547 Minor fixes prompted by GCC 4.6.0 warnings.
548
549 * xselect.c (converted_selections, conversion_fail_tag): Now static.
550
551 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
552 (x_clipboard_manager_save_all): Move extern decl to ...
553 * xterm.h: ... here, so that it can be checked for consistency.
554
555 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
556
557 * xselect.c (x_clipboard_manager_save_frame)
558 (x_clipboard_manager_save_all): New functions.
559 (Fx_clipboard_manager_save): Lisp function deleted.
560
561 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
562 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
563
564 * xterm.h: Update prototype.
565
566 2011-05-28 William Xu <william.xwl@gmail.com>
567
568 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
569 exiting (Bug#8239).
570
571 2011-05-28 Jim Meyering <meyering@redhat.com>
572
573 Avoid a sign-extension bug in crypto_hash_function.
574 * fns.c (to_uchar): Define.
575 (crypto_hash_function): Use it to convert some newly-signed
576 variables to unsigned, to avoid sign-extension bugs. For example,
577 without this change, (md5 "truc") would evaluate to
578 45723a2aff78ff4fff7fff1114760e62 rather than the expected
579 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
580 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
581
582 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
583
584 Integer overflow fixes.
585
586 * dbusbind.c: Serial number integer overflow fixes.
587 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
588 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
589 to hold a serial number that is too large for a fixnum.
590 (Fdbus_method_return_internal, Fdbus_method_error_internal):
591 Check for serial numbers out of range. Decode any serial number
592 that was so large that it became a float. (Bug#8722)
593
594 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
595 (Fdbus_call_method, Fdbus_call_method_asynchronously):
596 Use XFASTINT rather than XUINT when numbers are nonnegative.
597 (xd_append_arg, Fdbus_method_return_internal):
598 (Fdbus_method_error_internal): Likewise. Also, for unsigned
599 arguments, check that Lisp number is nonnegative, rather than
600 silently wrapping negative numbers around. (Bug#8722)
601 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
602 (Bug#8722)
603
604 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
605
606 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
607
608 ccl: add integer overflow checks
609 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
610 (IN_INT_RANGE): New macros.
611 (ccl_driver): Use them to check for integer overflow when
612 decoding a CCL program. Many of the new checks are whether XINT (x)
613 fits in int; it doesn't always, on 64-bit hosts. The new version
614 doesn't catch all possible integer overflows, but it's an
615 improvement. (Bug#8719)
616
617 * alloc.c (make_event_array): Use XINT, not XUINT.
618 There's no need for unsigned here.
619
620 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
621 This follows up to the 2011-05-06 change that substituted uintptr_t
622 for EMACS_INT. This case wasn't caught back then.
623
624 Rework Fformat to avoid integer overflow issues.
625 * editfns.c: Include <float.h> unconditionally, as it's everywhere
626 now (part of C89). Include <verify.h>.
627 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
628 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
629 (Fformat): Avoid the prepass trying to compute sizes; it was only
630 approximate and thus did not catch overflow reliably. Instead, walk
631 through the format just once, formatting and computing sizes as we go,
632 checking for integer overflow at every step, and allocating a larger
633 buffer as needed. Keep track separately whether the format is
634 multibyte. Keep only the most-recently calculated precision, rather
635 than them all. Record whether each argument has been converted to
636 string. Use EMACS_INT, not int, for byte and char and arg counts.
637 Support field widths and precisions larger than INT_MAX. Avoid
638 sprintf's undefined behavior with conversion specifications such as %#d
639 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
640 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
641 formatting out-of-range floating point numbers with int
642 formats. (Bug#8668)
643
644 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
645
646 * data.c: Avoid integer truncation in expressions involving floats.
647 * data.c: Include <intprops.h>.
648 (arith_driver): When there's an integer overflow in an expression
649 involving floating point, convert the integers to floating point
650 so that the resulting value does not suffer from catastrophic
651 integer truncation. For example, on a 64-bit host (* 4
652 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
653 Do not rely on undefined behavior after integer overflow.
654
655 merge count_size_as_multibyte, parse_str_to_multibyte
656 * character.c, character.h (count_size_as_multibyte):
657 Rename from parse_str_to_multibyte; all uses changed.
658 Check for integer overflow.
659 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
660 since it's now a duplicate of the other. This is more of
661 a character than a buffer op, so better that it's in character.c.
662 * fns.c, print.c: Adjust to above changes.
663
664 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
665
666 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
667
668 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
669
670 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
671 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
672 (x_clipboard_manager_save): Now static.
673 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
674
675 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
676 (crypto_hash_function): Now static.
677 Fix pointer signedness problems. Avoid unnecessary initializations.
678
679 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
680
681 * termhooks.h (Vselection_alist): Make it terminal-local.
682
683 * terminal.c (create_terminal): Initialize it.
684
685 * xselect.c: Support for clipboard managers.
686 (Vselection_alist): Move to termhooks.h as terminal-local var.
687 (LOCAL_SELECTION): New macro.
688 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
689 (symbol_to_x_atom): Remove gratuitous arg.
690 (x_handle_selection_request, lisp_data_to_selection_data)
691 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
692 (x_own_selection, x_get_local_selection, x_convert_selection):
693 New arg, specifying work frame. Use terminal-local Vselection_alist.
694 (some_frame_on_display): Delete unused function.
695 (Fx_own_selection_internal, Fx_get_selection_internal)
696 (Fx_disown_selection_internal, Fx_selection_owner_p)
697 (Fx_selection_exists_p): New optional frame arg.
698 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
699 (x_handle_selection_clear): Don't treat other terminals with the
700 same keyboard specially. Use the terminal-local Vselection_alist.
701 (x_clear_frame_selections): Use Frun_hook_with_args.
702
703 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
704
705 * xterm.h: Add support for those atoms.
706
707 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
708
709 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
710 (converted_selections, conversion_fail_tag): New global variables.
711 (x_selection_request_lisp_error): Free the above.
712 (x_get_local_selection): Remove unnecessary code.
713 (x_reply_selection_request): Args changed; handle arbitrary array
714 of converted selections stored in converted_selections.
715 Separate the XChangeProperty and SelectionNotify steps.
716 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
717 (x_convert_selection): New function.
718 (x_handle_selection_event): Simplify.
719 (x_get_foreign_selection): Don't ignore incoming requests while
720 waiting for an answer; this will fail when we implement
721 SAVE_TARGETS, and seems unnecessary anyway.
722 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
723 (Vx_sent_selection_functions): Doc fix.
724
725 2011-05-26 Leo Liu <sdl.web@gmail.com>
726
727 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
728
729 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
730
731 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
732
733 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
734 for fringe update if it has periodic bitmap.
735 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
736 and fringe_bitmap_periodic_p.
737
738 * fringe.c (get_fringe_bitmap_data): New function.
739 (draw_fringe_bitmap_1, update_window_fringes): Use it.
740 (update_window_fringes): Record periodicity of fringe bitmap in glyph
741 row. Mark glyph row for fringe update if periodicity changed.
742
743 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
744 for fringe update unless it has periodic bitmap.
745
746 2011-05-25 Kenichi Handa <handa@m17n.org>
747
748 * xdisp.c (get_next_display_element): Set correct it->face_id for
749 a static composition.
750
751 2011-05-24 Leo Liu <sdl.web@gmail.com>
752
753 * deps.mk (fns.o):
754 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
755
756 * fns.c (crypto_hash_function, Fsha1): New function.
757 (Fmd5): Use crypto_hash_function.
758 (syms_of_fns): Add Ssha1.
759
760 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
761
762 * gnutls.c: Remove unused macros.
763 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
764 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
765 Remove macros that are defined and never used.
766 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
767
768 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
769
770 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
771 (Fx_get_selection_internal): Minor cleanup.
772 (Fx_own_selection_internal): Rename arguments for consistency with
773 select.el.
774
775 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
776
777 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
778
779 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
780
781 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
782
783 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
784
785 * dispnew.c (scrolling_window): Don't exclude the case that the
786 last enabled row in the desired matrix touches the bottom boundary.
787
788 2011-05-21 Glenn Morris <rgm@gnu.org>
789
790 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
791 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
792 and add some more files.
793
794 2011-05-20 Eli Zaretskii <eliz@gnu.org>
795
796 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
797 report_file_error introduced by the change from 2011-05-07.
798
799 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
800
801 * systime.h (Time): Define only if emacs is defined.
802 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
803 where the include path doesn't have X11/X.h by default. See
804 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
805
806 2011-05-20 Kenichi Handa <handa@m17n.org>
807
808 * composite.c (find_automatic_composition): Fix previous change.
809
810 2011-05-20 Glenn Morris <rgm@gnu.org>
811
812 * lisp.mk: New file, split from Makefile.in.
813 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
814 (shortlisp): Remove.
815 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
816
817 2011-05-19 Glenn Morris <rgm@gnu.org>
818
819 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
820 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
821 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
822 (lisp): Set the order to that of loadup.el.
823 (shortlisp): Make it a copy of $lisp.
824 (SOME_MACHINE_LISP): Remove.
825 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
826 Use just $shortlisp, not $SOME_MACHINE_LISP too.
827
828 2011-05-18 Kenichi Handa <handa@m17n.org>
829
830 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
831 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
832 (find_automatic_composition): Mostly rewrite for efficiency.
833
834 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
835
836 * makefile.w32-in: Update dependencies.
837
838 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
839
840 * menu.c: Include limits.h (fixes the MS-Windows build broken by
841 revision 104625).
842
843 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
844
845 Fix some integer overflow issues, such as string length overflow.
846
847 * insdel.c (count_size_as_multibyte): Check for string overflow.
848
849 * character.c (lisp_string_width): Check for string overflow.
850 Use EMACS_INT, not int, for string indexes and lengths; in
851 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
852 the resulting string length overflows an EMACS_INT; instead,
853 report a string overflow if no precision given. When checking for
854 precision exhaustion, use a check that cannot possibly have
855 integer overflow. (Bug#8675)
856 * character.h (lisp_string_width): Adjust to new signature.
857
858 * alloc.c (string_overflow): New function.
859 (Fmake_string): Use it. This doesn't change behavior, but saves
860 a few bytes and will simplify future changes.
861 * character.c (string_escape_byte8): Likewise.
862 * lisp.h (string_overflow): New decl.
863
864 Fixups, following up to the user-interface timestamp change.
865 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
866 for UI timestamps, instead of unsigned long.
867 * msdos.c (mouse_get_pos): Likewise.
868 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
869 * w32gui.h (Time): Define by including "systime.h" rather than by
870 declaring it ourselves. (Bug#8664)
871
872 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
873 * image.c (clear_image_cache): Likewise.
874
875 * term.c (term_mouse_position): Don't assume time_t wraparound.
876
877 Be more systematic about user-interface timestamps.
878 Before, the code sometimes used 'Time', sometimes 'unsigned long',
879 and sometimes 'EMACS_UINT', to represent these timestamps.
880 This change causes it to use 'Time' uniformly, as that's what X uses.
881 This makes the code easier to follow, and makes it easier to catch
882 integer overflow bugs such as Bug#8664.
883 * frame.c (Fmouse_position, Fmouse_pixel_position):
884 Use Time, not unsigned long, for user-interface timestamps.
885 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
886 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
887 * keyboard.h (last_event_timestamp): Likewise.
888 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
889 * menu.h (xmenu_show): Likewise.
890 * term.c (term_mouse_position): Likewise.
891 * termhooks.h (struct input_event.timestamp): Likewise.
892 (struct terminal.mouse_position_hook): Likewise.
893 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
894 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
895 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
896 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
897 what it was before.
898 * menu.h, termhooks.h: Include "systime.h", for Time.
899
900 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
901 Don't assume that the difference between two unsigned long values
902 can fit into an integer. At this point, we know button_down_time
903 <= event->timestamp, so the difference must be nonnegative, so
904 there's no need to cast the result if double-click-time is
905 nonnegative, as it should be; check that it's nonnegative, just in
906 case. This bug is triggered when events are more than 2**31 ms
907 apart (about 25 days). (Bug#8664)
908
909 * xselect.c (last_event_timestamp): Remove duplicate decl.
910 (x_own_selection): Remove needless cast to unsigned long.
911
912 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
913 that always fit in int. Use a sentinel instead of a counter, to
914 avoid a temp and to allay GCC's concerns about possible int overflow.
915 * frame.h (struct frame): Use int for menu_bar_items_used
916 instead of EMACS_INT, since it always fits in int.
917
918 * menu.c (grow_menu_items): Check for int overflow.
919
920 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
921
922 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
923 Before, the code was not consistent. These values cannot exceed
924 2**31 - 1 so there's no need to make them unsigned.
925 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
926 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
927 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
928 as modifiers.
929 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
930
931 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
932 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
933 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
934 presumably because the widths might not match.
935
936 * window.c (size_window): Avoid needless test at loop start.
937
938 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
939
940 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
941
942 2011-05-12 Drew Adams <drew.adams@oracle.com>
943
944 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
945
946 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
947
948 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
949 `width' to `bar_area_x' and `bar_area_width', respectively.
950 (x_scroll_run): Take account of fringe background extension.
951
952 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
953 Rename local vars `left' and `width' to `bar_area_x' and
954 `bar_area_width', respectively.
955 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
956 background extension.
957
958 2011-05-10 Jim Meyering <meyering@redhat.com>
959
960 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
961
962 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
963
964 * image.c (Finit_image_library): Return t for built-in image types,
965 like pbm and xbm. (Bug#8640)
966
967 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
968
969 * w32menu.c (set_frame_menubar): Fix submenu allocation.
970
971 2011-05-07 Eli Zaretskii <eliz@gnu.org>
972
973 * w32console.c (Fset_screen_color): Doc fix.
974 (Fget_screen_color): New function.
975 (syms_of_ntterm): Defsubr it.
976
977 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
978 unlink the temporary file if Fcall_process didn't create it in the
979 first place.
980 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
981 child process will be redirected to a file specified with `:file'.
982 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
983 cue to call_process_cleanup not to close that handle.
984
985 2011-05-07 Ben Key <bkey76@gmail.com>
986
987 * makefile.w32-in: The bootstrap-temacs rule now makes use of
988 one of two shell specific rules, either bootstrap-temacs-CMD or
989 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
990 to the previous implementation of the bootstrap-temacs rule.
991 The bootstrap-temacs-CMD rule is similar to the previous
992 implementation of the bootstrap-temacs rule except that it
993 makes use of the ESC_CFLAGS variable instead of the CFLAGS
994 variable.
995
996 These changes, along with some changes to nt/configure.bat,
997 nt/gmake.defs, and nt/nmake.defs, are required to extend my
998 earlier fix to add support for --cflags and --ldflags options
999 that include quotes so that it works whether make uses cmd or
1000 sh as the shell.
1001
1002 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1003
1004 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1005 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1006 is a constant.
1007 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1008 a string. Handle both cases.
1009 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1010 (Fdbus_register_method): Use Qinvalid_function.
1011
1012 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1013
1014 * makefile.w32-in: Update dependencies.
1015 (LISP_H): Add inttypes.h and stdin.h.
1016 (PROCESS_H): Add unistd.h.
1017
1018 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1019
1020 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1021 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1022
1023 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1024
1025 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1026
1027 * term.c (vfatal): Remove stray call to va_end.
1028 It's not needed and the C Standard doesn't allow it here anyway.
1029
1030 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1031 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1032
1033 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1034 bytes.
1035
1036 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1037
1038 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1039
1040 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1041
1042 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1043
1044 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1045
1046 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1047 * charset.c (Fdefine_charset_internal): Don't initialize
1048 charset.code_space[15]. The value was garbage, on hosts with
1049 32-bit int (Bug#8600).
1050
1051 * lread.c (read_integer): Be more consistent with string-to-number.
1052 Use string_to_number to do the actual conversion; this avoids
1053 rounding errors and fixes some other screwups. Without this fix,
1054 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1055 (digit_to_number): Move earlier, for benefit of read_integer.
1056 Return -1 if the digit is out of range for the base, -2 if it is
1057 not a digit in any supported base. (Bug#8602)
1058
1059 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1060
1061 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1062 to match comment at start of function. This also removes a
1063 GCC warning about overflow in a 32+64-bit port.
1064
1065 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1066
1067 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1068 Reported by Stefan Monnier in
1069 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1070 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1071 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1072
1073 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1074 (EMACS_UINTPTR): Likewise, with uintptr_t.
1075
1076 * lisp.h: Prefer 64-bit EMACS_INT if available.
1077 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1078 on 32-bit hosts that have 64-bit int, so that they can access
1079 large files.
1080 However, temporarily disable this change unless the temporary
1081 symbol WIDE_EMACS_INT is defined.
1082
1083 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1084
1085 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1086 This removes an assumption that EMACS_INT and long are the same
1087 width as pointers. The assumption is true for Emacs porting targets
1088 now, but we want to make other targets possible.
1089 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1090 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1091 In the rest of the code, change types of integers that hold casted
1092 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1093 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1094 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1095 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1096 No need to cast type when ORing.
1097 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1098 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1099 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1100 assume EMACS_INT is the same width as char *.
1101 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1102 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1103 Remove no-longer-needed casts.
1104 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1105 (xg_tool_bar_help_callback, xg_make_tool_item):
1106 Use EMACS_INTPTR to hold an integer
1107 that will be cast to void *; this can avoid a GCC warning
1108 if EMACS_INT is not the same width as void *.
1109 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1110 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1111 (current_message_1, set_message_1):
1112 Use a local to convert to proper width without a cast.
1113 * xmenu.c (dialog_selection_callback): Likewise.
1114
1115 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1116 Also, don't assume VALBITS / RAND_BITS is less than 5,
1117 and don't rely on undefined behavior when shifting a 1 left into
1118 the sign bit.
1119 * lisp.h (get_random): Change signature to match.
1120
1121 * lread.c (hash_string): Use size_t, not int, for hash computation.
1122 Normally we prefer signed values; but hashing is special, because
1123 it's better to use unsigned division on hash table sizes so that
1124 the remainder is nonnegative. Also, size_t is the natural width
1125 for hashing into memory. The previous code used 'int', which doesn't
1126 retain enough info to hash well into very large tables.
1127 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1128
1129 * dbusbind.c: Don't possibly lose pointer info when converting.
1130 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1131 Use XPNTR rather than XHASH, so that the high-order bits of
1132 the pointer aren't lost when converting through void *.
1133
1134 * eval.c (Fautoload): Don't double-shift a pointer.
1135
1136 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1137
1138 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1139
1140 * gnutls.c (DEF_GNUTLS_FN):
1141 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1142
1143 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1144
1145 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1146 marker. (Bug#8610)
1147
1148 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1149
1150 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1151 New version that can reserve upto 2GB of heap space.
1152
1153 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1154
1155 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1156
1157 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1158
1159 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1160 `gnutls_certificate_set_x509_key_file'.
1161
1162 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1165 Update dependencies.
1166
1167 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1168
1169 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1170 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1171 Remove unused parameter `fildes'.
1172 * process.c (read_process_output, send_process): Don't pass it.
1173
1174 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1175
1176 Fix previous change: the library cache is defined in w32.c.
1177 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1178 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1179
1180 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1181
1182 Implement dynamic loading of GnuTLS on Windows.
1183
1184 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1185 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1186 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1187 Declare.
1188
1189 * gnutls.c (Qgnutls_dll): Define.
1190 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1191 (gnutls_*): Declare function pointers.
1192 (init_gnutls_functions): New function to initialize function pointers.
1193 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1194 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1195 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1196 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1197 (emacs_gnutls_write, emacs_gnutls_read)
1198 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1199 (Fgnutls_available_p): New function.
1200 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1201 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1202 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1203
1204 * image.c: Include w32.h.
1205 (Vimage_type_cache): Delete.
1206 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1207 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1208 (w32_delayed_load): Move to w32.c.
1209
1210 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1211
1212 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1213 (w32_delayed_load): Move from image.c. When loading a library, record
1214 its filename in the :loaded-from property of the library id.
1215 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1216 Initialize and staticpro them.
1217 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1218
1219 * process.c: Include lisp.h before w32.h, not after.
1220 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1221 instead of gnutls_record_check_pending.
1222
1223 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1224
1225 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1226
1227 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1228 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1229 as passed in.
1230
1231 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1232
1233 * xterm.c (x_set_frame_alpha): Do not set property on anything
1234 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1235
1236 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1237
1238 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1239
1240 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1241
1242 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1243 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1244 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1245 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1246 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1247 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1248 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1249 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1250 (Qgnutls_bootprop_callbacks_verify): Make static.
1251
1252 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1253
1254 * callproc.c: Indentation fixup.
1255
1256 * sysdep.c (wait_for_termination_1): Make static.
1257 (wait_for_termination, interruptible_wait_for_termination):
1258 Move after wait_for_termination_1.
1259
1260 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1261
1262 * sysdep.c (interruptible_wait_for_termination): New function
1263 which is like wait_for_termination, but allows keyboard
1264 interruptions.
1265
1266 * callproc.c (Fcall_process): Add (:file "file") as an option for
1267 the STDOUT buffer.
1268 (Fcall_process_region): Ditto.
1269
1270 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1271
1272 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1273 rather than `XVECTOR (FOO)->size'.
1274
1275 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1276 inttypes.h, as a gnulib replacement is used if it not available in
1277 system headers.
1278
1279 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1280
1281 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1282 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1283 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1284
1285 * coding.c (coding_alloc_by_realloc): Error out if destination
1286 will grow beyond MOST_POSITIVE_FIXNUM.
1287 (decode_coding_emacs_mule): Abort if there isn't enough place in
1288 charbuf for the composition carryover bytes. Reserve an extra
1289 space for up to 2 characters produced in a loop.
1290 (decode_coding_iso_2022): Abort if there isn't enough place in
1291 charbuf for the composition carryover bytes.
1292
1293 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1294
1295 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1296 aborting when %lld or %lll format is passed.
1297 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1298 %llo or %llx format is passed. (Bug#8545)
1299
1300 * window.c (window_scroll_line_based): Use a marker instead of
1301 simple variables to record original value of point. (Bug#7952)
1302
1303 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1304 produced by %s or %c overflows available buffer space. (Bug#8545)
1305
1306 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1309 (SIZE_MAX): Move defn after all includes, as they might #define it.
1310
1311 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1312
1313 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1314
1315 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1316
1317 * keyboard.c (Qdelayed_warnings_hook): Define.
1318 (command_loop_1): Run `delayed-warnings-hook'
1319 if Vdelayed_warnings_list is non-nil.
1320 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1321 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1322
1323 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1324
1325 * doprnt.c (doprnt): Don't return value smaller than the buffer
1326 size if the message was truncated. (Bug#8545).
1327
1328 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1329
1330 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1331 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1332
1333 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1334
1335 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1336
1337 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1338
1339 * makefile.w32-in: Update dependencies.
1340
1341 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1342
1343 Improve `doprnt' and its usage. (Bug#8545)
1344 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1345 `format_end'. Remove support for %l as a conversion specifier.
1346 Don't use xrealloc. Improve diagnostics when the %l size modifier
1347 is used. Update the commentary.
1348
1349 * eval.c (verror): Simplify calculation of size_t.
1350
1351 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1352 messages.
1353
1354 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1355
1356 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1357 change.
1358
1359 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1362 This makes this file independent of the recent pseudovector change.
1363
1364 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1367
1368 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1369 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1370 Remove unused local.
1371 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1372
1373 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1374 GCC 4.6.0 optimizes based on type-based alias analysis.
1375 For example, if b is of type struct buffer * and v of type struct
1376 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1377 != &v->size, and therefore "v->size = 1; b->size = 2; return
1378 v->size;" must therefore return 1. This assumption is incorrect
1379 for Emacs, since it type-puns struct Lisp_Vector * with many other
1380 types. To fix this problem, this patch adds a new type struct
1381 vectorlike_header that documents the constraints on layout of vectors
1382 and pseudovectors, and helps optimizing compilers not get fooled
1383 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1384 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1385 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1386 the size member.
1387 (XSETPVECTYPE): Rewrite in terms of new macro.
1388 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1389 This is a bit clearer, and further avoids the possibility of
1390 undesirable aliasing.
1391 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1392 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1393 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1394 since Lisp_Subr is a special case (no "next" field).
1395 (ASIZE): Now uses header.size rather than size.
1396 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1397 to avoid the hassle of writing XVECTOR (foo)->header.size.
1398 (struct vectorlike_header): New type.
1399 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1400 object, to help avoid aliasing.
1401 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1402 (SUBRP): Likewise, since Lisp_Subr is a special case.
1403 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1404 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1405 (struct Lisp_Hash_Table): Combine first two members into a single
1406 struct vectorlike_header member. All uses of "size" and "next" members
1407 changed to be "header.size" and "header.next".
1408 * buffer.h (struct buffer): Likewise.
1409 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1410 * frame.h (struct frame): Likewise.
1411 * process.h (struct Lisp_Process): Likewise.
1412 * termhooks.h (struct terminal): Likewise.
1413 * window.c (struct save_window_data, struct saved_window): Likewise.
1414 * window.h (struct window): Likewise.
1415 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1416 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1417 * buffer.c (init_buffer_once): Likewise.
1418 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1419 special case.
1420 * process.c (Fformat_network_address): Use local var for size,
1421 for brevity.
1422
1423 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1424
1425 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1426 * data.c (atof): Remove decl; no longer used or needed.
1427 (digit_to_number): Move to lread.c.
1428 (Fstring_to_number): Use new string_to_number function, to be
1429 consistent with how the Lisp reader treats infinities and NaNs.
1430 Do not assume that floating-point numbers represent EMACS_INT
1431 without losing information; this is not true on most 64-bit hosts.
1432 Avoid double-rounding errors, by insisting on integers when
1433 parsing non-base-10 numbers, as the documentation specifies.
1434 * lisp.h (string_to_number): New decl, replacing ...
1435 (isfloat_string): Remove.
1436 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1437 (read1): Do not accept +. and -. as integers; this
1438 appears to have been a coding error. Similarly, do not accept
1439 strings like +-1e0 as floating point numbers. Do not report
1440 overflow for integer overflows unless the base is not 10 which
1441 means we have no simple and reliable way to continue.
1442 Break out the floating-point parsing into a new
1443 function string_to_number, so that Fstring_to_number parses
1444 floating point numbers consistently with the Lisp reader.
1445 (digit_to_number): Move here from data.c. Make it static inline.
1446 (E_CHAR, EXP_INT): Remove, replacing with ...
1447 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1448 (string_to_number): New function, replacing isfloat_string.
1449 This function checks for valid syntax and produces the resulting
1450 Lisp float number too. Rework it so that string-to-number
1451 no longer mishandles examples like "1.0e+". Use strtoumax,
1452 so that overflow for non-base-10 numbers is reported only when
1453 there's no portable and simple way to convert to floating point.
1454
1455 * textprop.c (set_text_properties_1): Rewrite for clarity,
1456 and to avoid GCC warning about integer overflow.
1457
1458 * intervals.h (struct interval): Use EMACS_INT for members
1459 where EMACS_UINT might cause problems. See
1460 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1461 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1462 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1463 All uses changed.
1464 (offset_intervals): Tell GCC not to worry about length overflow
1465 when negating a negative length.
1466
1467 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1468 (overrun_check_free): Likewise.
1469
1470 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1471 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1472 word size.
1473
1474 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1475 (gnutls_make_error): Rename local to avoid shadowing.
1476 (gnutls_emacs_global_deinit): ifdef out; not used.
1477 (Fgnutls_boot): Use const for pointer to readonly storage.
1478 Comment out unused local. Fix pointer signedness problems.
1479
1480 * lread.c (openp): Don't stuff size_t into an 'int'.
1481 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1482 about possible signed overflow.
1483
1484 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1485 (GDK_KEY_g): Don't define if already defined.
1486 (xg_prepare_tooltip): Avoid pointer signedness problem.
1487 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1488
1489 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1490 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1491
1492 * xfns.c (Fx_window_property): Simplify a bit,
1493 to make a bit faster and to avoid GCC 4.6.0 warning.
1494 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1495
1496 * fns.c (internal_equal): Don't assume size_t fits in int.
1497
1498 * alloc.c (compact_small_strings): Tighten assertion a little.
1499
1500 Replace pEd with more-general pI, and fix some printf arg casts.
1501 * lisp.h (pI): New macro, generalizing old pEd macro to other
1502 conversion specifiers. For example, use "...%"pI"d..." rather
1503 than "...%"pEd"...".
1504 (pEd): Remove. All uses replaced with similar uses of pI.
1505 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1506 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1507 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1508 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1509 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1510 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1511 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1512 64-bit hosts.
1513 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1514 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1515 * print.c (safe_debug_print, print_object): Likewise.
1516 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1517 to int.
1518 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1519 avoiding the 0 flag, which is not portable.
1520 * process.c (Fmake_network_process): Use pI to avoid cast.
1521 * region-cache.c (pp_cache): Likewise.
1522 * xdisp.c (decode_mode_spec): Likewise.
1523 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1524 behavior on 64-bit hosts with printf arg.
1525 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1526 (x_stop_queuing_selection_requests): Likewise.
1527 (x_get_window_property): Don't truncate byte count to an 'int'
1528 when tracing.
1529
1530 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1531 here, since it parses constructs like leading '-' and spaces,
1532 which are not wanted; and it overflows with large numbers.
1533 Instead, simply match F[0-9]+, which is what is wanted anyway.
1534
1535 * alloc.c: Remove unportable assumptions about struct layout.
1536 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1537 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1538 (allocate_vectorlike, make_pure_vector): Use the new macros,
1539 plus offsetof, to remove unportable assumptions about struct layout.
1540 These assumptions hold on all porting targets that I know of, but
1541 they are not guaranteed, they're easy to remove, and removing them
1542 makes further changes easier.
1543
1544 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1545 This doesn't fix a bug but makes the code clearer.
1546 (string_overrun_cookie): Now const. Use initializers that
1547 don't formally overflow signed char, to avoid warnings.
1548 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1549 can cause Emacs to crash when string overrun checking is enabled.
1550 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1551 multiple of sizeof (EMACS_INT); it need not be, if
1552 alignof(EMACS_INT) < sizeof (EMACS_INT).
1553 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1554
1555 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1556
1557 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1558
1559 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1560
1561 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1562 supposed to be handshaking. (Bug#8556)
1563 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1564
1565 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1566
1567 * lisp.h (Qdebug): List symbol.
1568 * eval.c (Qdebug): Restore global linkage.
1569 * keyboard.c (debug-on-event): New variable.
1570 (handle_user_signal): Break into debugger when debug-on-event
1571 matches the current signal symbol.
1572
1573 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1574
1575 * alloc.c (check_sblock, check_string_bytes)
1576 (check_string_free_list): Convert to standard C.
1577
1578 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1579
1580 * w32.c (emacs_gnutls_push): Fix typo.
1581
1582 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1583
1584 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1585 "cast to pointer from integer of different size".
1586
1587 Improve doprnt and its use in verror. (Bug#8545)
1588 * doprnt.c (doprnt): Document the set of format control sequences
1589 supported by the function. Use SAFE_ALLOCA instead of always
1590 using `alloca'.
1591
1592 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1593 is one byte too soon. Don't use xrealloc; instead xfree and
1594 xmalloc anew.
1595
1596 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1597
1598 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1599 callbacks stage.
1600
1601 * gnutls.c: Renamed global_initialized to
1602 gnutls_global_initialized. Added internals for the
1603 :verify-hostname-error, :verify-error, and :verify-flags
1604 parameters of `gnutls-boot' and documented those parameters in the
1605 docstring. Start callback support.
1606 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1607 unless a fatal error occured. Call gnutls_alert_send_appropriate
1608 on error. Return error code.
1609 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1610 (emacs_gnutls_read): Likewise.
1611 (Fgnutls_boot): Return handshake error code.
1612 (emacs_gnutls_handle_error): New function.
1613 (wsaerror_to_errno): Likewise.
1614
1615 * w32.h (emacs_gnutls_pull): Add prototype.
1616 (emacs_gnutls_push): Likewise.
1617
1618 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1619 (emacs_gnutls_push): Likewise.
1620
1621 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1622
1623 * process.c (wait_reading_process_output): Check if GnuTLS
1624 buffered some data internally if no FDs are set for TLS
1625 connections.
1626
1627 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1628 (LIBS): Link to USER_LIBS.
1629 ($(BLD)/gnutls.$(0)): New target.
1630
1631 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1632
1633 * xdisp.c (handle_single_display_spec): Rename the
1634 display_replaced_before_p argument into display_replaced_p, to
1635 make it consistent with the commentary. Fix typos in the
1636 commentary.
1637
1638 * textprop.c (syms_of_textprop): Remove dead code.
1639 (copy_text_properties): Delete obsolete commentary about an
1640 interface that was deleted long ago. Fix typos in the description
1641 of arguments.
1642
1643 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1644 to changes in oldXMenu/XMenu.h from 2011-04-16.
1645 <menu_help_message, prev_menu_help_message>: Constify.
1646 (IT_menu_make_room): menu->help_text is now `const char **';
1647 adjust.
1648
1649 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1650 to changes in oldXMenu/XMenu.h from 2011-04-16.
1651 (struct XMenu): Declare `help_text' `const char **'.
1652
1653 * xfaces.c <Qunspecified>: Make extern again.
1654
1655 * syntax.c: Include sys/types.h before including regex.h, as
1656 required by Posix.
1657
1658 * doc.c (get_doc_string): Improve the format passed to `error'.
1659
1660 * doprnt.c (doprnt): Improve commentary.
1661
1662 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1663
1664 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1665 them with etags.
1666
1667 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1668 changes in globals.h immediately force recompilation.
1669 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1670 $(CURDIR)/s/ms-w32.h.
1671 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1672
1673 * character.c (Fchar_direction): Function deleted.
1674 (syms_of_character): Don't defsubr it.
1675 <char-direction-table>: Deleted.
1676
1677 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1678
1679 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1680 * doprnt.c: Include limits.h.
1681 (SIZE_MAX): New macro.
1682 (doprnt): Return a size_t value. 2nd arg is now size_t.
1683 Many local variables are now size_t instead of int or unsigned.
1684 Improve overflow protection. Support `l' modifier for integer
1685 conversions. Support %l conversion. Don't assume an EMACS_INT
1686 argument for integer conversions and for %c.
1687
1688 * lisp.h (doprnt): Restore prototype.
1689
1690 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1691 $(SRC)/character.h.
1692
1693 * Makefile.in (base_obj): Add back doprnt.o.
1694
1695 * deps.mk (doprnt.o): Add back prerequisites.
1696 (callint.o): Depend on character.h.
1697
1698 * eval.c (internal_lisp_condition_case): Include the handler
1699 representation in the error message.
1700 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1701 when breaking from the loop.
1702
1703 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1704
1705 * callint.c (Fcall_interactively): When displaying error message
1706 about invalid control letter, pass the character's codepoint, not
1707 a pointer to its multibyte form. Improve display of the character
1708 in octal and display also its hex code.
1709
1710 * character.c (char_string): Use %x to display the (unsigned)
1711 codepoint of an invalid character, to avoid displaying a bogus
1712 negative value.
1713
1714 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1715 `error', not SYMBOL_NAME itself.
1716
1717 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1718 character arguments to `error'.
1719
1720 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1721 to `error' in error message about FINAL_CHAR argument. Make sure
1722 FINAL_CHAR is a character, and use %c when it is passed as
1723 argument to `error'.
1724
1725 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1726
1727 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1728
1729 * w32.c: Include <time.h>.
1730 (sys_localtime): New function.
1731
1732 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1733
1734 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1735
1736 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1737
1738 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1739
1740 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1741 zombies (Bug#8467).
1742
1743 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1744
1745 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1746 gl_state.e_property when gl_state.object is Qt.
1747
1748 * insdel.c (make_gap_larger): Remove limitation of buffer size
1749 to <= INT_MAX.
1750
1751 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1752
1753 * xdisp.c (lookup_glyphless_char_display)
1754 (produce_glyphless_glyph): Handle cons cell entry in
1755 glyphless-char-display.
1756 (Vglyphless_char_display): Document it.
1757
1758 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1759 glyphless-char-display.
1760
1761 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1762
1763 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1764
1765 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1766
1767 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1768 definition for no-X builds.
1769
1770 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 Static checks with GCC 4.6.0 and non-default toolkits.
1773
1774 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1775
1776 * process.c (keyboard_bit_set): Define only if SIGIO.
1777 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1778 (send_process): Repair possible setjmp clobbering.
1779
1780 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1781
1782 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1783
1784 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1785
1786 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1787 Define only if needed.
1788
1789 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1790 by pacifying GCC about it. Maybe it's time to retire it?
1791 * xfaces.c (USG, __TIMEVAL__): Likewise.
1792
1793 * dispextern.h (struct redisplay_interface): Rename param
1794 to avoid shadowing.
1795 * termhooks.h (struct terminal): Likewise.
1796 * xterm.c (xembed_send_message): Likewise.
1797
1798 * insdel.c (make_gap_smaller): Define only if
1799 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1800
1801 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1802 it.
1803
1804 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1805 so that we aren't warned about unused symbols.
1806
1807 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1808
1809 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1810
1811 * xfns.c (x_real_positions): Mark locals as initialized.
1812
1813 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1814
1815 * xterm.c: Fix problems found by static analysis with other toolkits.
1816 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1817 (x_dispatch_event): Declare static if USE_GTK, and
1818 define if USE_GTK || USE_X_TOOLKIT.
1819 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1820 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1821 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1822 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1823
1824 * xmenu.c (menu_help_callback): Pointer type fixes.
1825 Use const pointers when pointing at readonly data. Avoid pointer
1826 signedness clashes.
1827 (FALSE): Remove unused macro.
1828 (update_frame_menubar): Remove unused decl.
1829
1830 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1831
1832 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1833 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1834 (single_menu_item): Rename local to avoid shadowing.
1835
1836 * keyboard.c (make_lispy_event): Remove unused local var.
1837
1838 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1839 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1840
1841 * bitmaps: Change bitmaps from unsigned char back to the X11
1842 compatible char. Avoid the old compiler warnings about
1843 out-of-range initializers by using, for example, '\xab' rather
1844 than 0xab.
1845
1846 * xgselect.c (xgselect_initialize): Check vs interface
1847 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1848
1849 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1850
1851 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1852 to read-only memory.
1853
1854 * fns.c (vector): Remove; this old hack is no longer needed.
1855
1856 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1857 Remove unused var.
1858 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1859
1860 * xrdb.c (x_load_resources): Omit unused local.
1861
1862 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1863 (x_window): Rename locals to avoid shadowing.
1864 (USG): Use the kludged USG macro, to pacify gcc.
1865
1866 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1867 (x_term_init): Remove local to avoid shadowing.
1868
1869 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1870
1871 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1872 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1873
1874 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1875
1876 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1877
1878 Fix regex.c, syntax.c and friends for buffers > 2GB.
1879 * syntax.h (struct gl_state_s): Declare character position members
1880 EMACS_INT.
1881
1882 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1883
1884 * textprop.c (verify_interval_modification, interval_of):
1885 Declare arguments EMACS_INT.
1886
1887 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1888 EMACS_INT.
1889
1890 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1891
1892 * indent.c (Fvertical_motion): Local variable it_start is now
1893 EMACS_INT.
1894
1895 * regex.c (re_match, re_match_2, re_match_2_internal)
1896 (bcmp_translate, regcomp, regexec, print_double_string)
1897 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1898 (re_compile_pattern, re_exec): Declare arguments and local
1899 variables `size_t' and `ssize_t' and return values `regoff_t', as
1900 appropriate.
1901 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1902 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1903 <compile_stack_type>: `size' and `avail' are now `size_t'.
1904
1905 * regex.h <regoff_t>: Use ssize_t, not int.
1906 (re_search, re_search_2, re_match, re_match_2): Arguments that
1907 specify buffer/string position and length are now ssize_t and
1908 size_t. Return type is regoff_t.
1909
1910 2011-04-16 Ben Key <bkey76@gmail.com>
1911
1912 * nsfont.m: Fixed bugs in ns_get_family and
1913 ns_descriptor_to_entity that were caused by using free to
1914 deallocate memory blocks that were allocated by xmalloc (via
1915 xstrdup). This caused Emacs to crash when compiled with
1916 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1917 --enable-checking=xmallocoverrun). xfree is now used to
1918 deallocate these memory blocks.
1919
1920 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1923
1924 emacs_write: Accept and return EMACS_INT for sizes.
1925 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1926 et seq.
1927 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1928 Accept and return EMACS_INT.
1929 (emacs_gnutls_write): Return the number of bytes written on
1930 partial writes.
1931 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1932 (emacs_read, emacs_write): Remove check for negative size, as the
1933 Emacs source code has been audited now.
1934 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1935 (emacs_read, emacs_write): Use it.
1936 * process.c (send_process): Adjust to the new signatures of
1937 emacs_write and emacs_gnutls_write. Do not attempt to store
1938 a byte offset into an 'int'; it might overflow.
1939 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1940
1941 * sound.c: Don't assume sizes fit in 'int'.
1942 (struct sound_device.period_size, alsa_period_size):
1943 Return EMACS_INT, not int.
1944 (struct sound_device.write, vox_write, alsa_write):
1945 Accept EMACS_INT, not int.
1946 (wav_play, au_play): Use EMACS_INT to store sizes and to
1947 record read return values.
1948
1949 2011-04-15 Ben Key <bkey76@gmail.com>
1950
1951 * keyboard.c (Qundefined): Don't declare static since it is used
1952 in nsfns.m.
1953 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1954 static since they are used in nsfont.m.
1955
1956 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1957
1958 * process.c (Qprocessp): Don't declare static.
1959 * lisp.h (Qprocessp): Declare again.
1960
1961 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1962
1963 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1964
1965 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 Improve C-level modularity by making more things 'static'.
1968
1969 Don't publish debugger-only interfaces to other modules.
1970 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1971 (verify_bytepos, count_markers): Move decls to the only modules
1972 that need them.
1973 * region-cache.h (pp_cache): Likewise.
1974 * window.h (check_all_windows): Likewise.
1975 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1976
1977 * sysdep.c (croak): Now static, if
1978 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1979 * syssignal.h (croak): Declare only if not static.
1980
1981 * alloc.c (refill_memory_reserve): Now static if
1982 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1983 * lisp.h (refill_memory_reserve): Declare only if not static.
1984
1985 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1986 Define only if USE_LUCID.
1987
1988 * xrdb.c (x_customization_string, x_rm_string): Now static.
1989
1990 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1991 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1992
1993 * xdisp.c (draw_row_with_mouse_face): Now static.
1994 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1995
1996 * window.h (check_all_windows): Mark externally visible.
1997
1998 * window.c (window_deletion_count): Now static.
1999
2000 * undo.c: Make symbols static if they're not exported.
2001 (last_undo_buffer, last_boundary_position, pending_boundary):
2002 Now static.
2003
2004 * textprop.c (interval_insert_behind_hooks): Now static.
2005 (interval_insert_in_front_hooks): Likewise.
2006
2007 * term.c: Make symbols static if they're not exported.
2008 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2009 (max_frame_lines, tty_set_terminal_modes):
2010 (tty_reset_terminal_modes, tty_turn_off_highlight):
2011 (get_tty_terminal): Now static.
2012 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2013 * termhooks.h (term_mouse_moveto): Do not declare if
2014 HAVE_WINDOW_SYSTEM.
2015 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2016 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2017
2018 * sysdep.c: Make symbols static if they're not exported.
2019 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2020 Now static.
2021 (sigprocmask_set, full_mask): Remove; unused.
2022 (wait_debugging): Mark as visible.
2023 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2024 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2025
2026 * syntax.c (syntax_temp): Define only if !__GNUC__.
2027
2028 * sound.c (current_sound_device, current_sound): Now static.
2029
2030 * search.c (searchbufs, searchbuf_head): Now static.
2031
2032 * scroll.c (scroll_cost): Remove; unused.
2033 * dispextern.h (scroll_cost): Remove decl.
2034
2035 * region-cache.h (pp_cache): Mark as externally visible.
2036
2037 * process.c: Make symbols static if they're not exported.
2038 (process_tick, update_tick, create_process, chan_process):
2039 (Vprocess_alist, proc_buffered_char, datagram_access):
2040 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2041 (deactivate_process): Mark defn as static, as well as decl.
2042 * lisp.h (create_process): Remove decl.
2043 * process.h (chan_process, Vprocess_alist): Remove decls.
2044
2045 * print.c: Make symbols static if they're not exported.
2046 (print_depth, new_backquote_output, being_printed, print_buffer):
2047 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2048 (print_interval, print_number_index, initial_stderr_stream):
2049 Now static.
2050 * lisp.h (Fprinc): Remove decl.
2051 (debug_output_compilation_hack): Mark as externally visible.
2052
2053 * sysdep.c (croak): Move decl from here to syssignal.h.
2054 * syssignal.h (croak): Put it here, so the API can be checked when
2055 'croak' is called from dissociate_if_controlling_tty.
2056
2057 * minibuf.c: Make symbols static if they're not exported.
2058 (minibuf_save_list, choose_minibuf_frame): Now static.
2059 * lisp.h (choose_minibuf_frame): Remove decl.
2060
2061 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2062
2063 * lread.c: Make symbols static if they're not exported.
2064 (read_objects, initial_obarray, oblookup_last_bucket_number):
2065 Now static.
2066 (make_symbol): Remove; unused.
2067 * lisp.h (initial_obarray, make_symbol): Remove decls.
2068
2069 * keyboard.c: Make symbols static if they're not exported.
2070 (single_kboard, recent_keys_index, total_keys, recent_keys):
2071 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2072 (this_single_command_key_start, echoing, last_auto_save):
2073 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2074 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2075 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2076 (Vlispy_mouse_stem, double_click_count):
2077 Now static.
2078 (force_auto_save_soon): Define only if SIGDANGER.
2079 (ignore_mouse_drag_p): Now static if
2080 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2081 (print_help): Remove; unused.
2082 (stop_character, last_timer_event): Mark as externally visible.
2083 * keyboard.h (ignore_mouse_drag_p): Declare only if
2084 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2085 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2086 * lisp.h (echoing): Remove decl.
2087 (force_auto_save_soon): Declare only if SIGDANGER.
2088 * xdisp.c (redisplay_window): Simplify code, to make it more
2089 obvious that ignore_mouse_drag_p is not accessed if !defined
2090 USE_GTK && !defined HAVE_NS.
2091
2092 * intervals.c: Make symbols static if they're not exported.
2093 (merge_properties_sticky, merge_interval_right, delete_interval):
2094 Now static.
2095 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2096
2097 * insdel.c: Make symbols static if they're not exported.
2098 However, leave prepare_to_modify_buffer alone. It's never
2099 called from outside this function, but that appears to be a bug.
2100 (combine_after_change_list, combine_after_change_buffer):
2101 (adjust_after_replace, signal_before_change): Now static.
2102 (adjust_after_replace_noundo): Remove; unused.
2103 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2104 (signal_before_change): Remove decls.
2105
2106 * indent.c (val_compute_motion, val_vmotion): Now static.
2107
2108 * image.c: Make symbols static if they're not exported.
2109 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2110 if USE_GTK.
2111 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2112 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2113
2114 * fringe.c (standard_bitmaps): Now static.
2115 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2116
2117 * frame.c: Make symbols static if they're not exported.
2118 (x_report_frame_params, make_terminal_frame): Now static.
2119 (get_frame_param): Now static, unless HAVE_NS.
2120 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2121 (x_get_resource_string): Remove; not used.
2122 * frame.h (make_terminal_frame, x_report_frame_params):
2123 (x_get_resource_string); Remove decls.
2124 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2125 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2126
2127 * font.c, fontset.c: Make symbols static if they're not exported.
2128 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2129 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2130 * font.c (font_close_object): Now static.
2131 * font.h (font_close_object): Remove.
2132 * fontset.c (FONTSET_OBJLIST): Remove.
2133 (free_realized_fontset) #if-0 the body, which does nothing.
2134 (face_suitable_for_char_p): #if-0, as it's never called.
2135 * fontset.h (face_suitable_for_char_p): Remove decl.
2136 * xfaces.c (face_at_string_position):
2137 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2138 since 0 is always ASCII.
2139
2140 * fns.c (weak_hash_tables): Now static.
2141
2142 * fileio.c: Make symbols static if they're not exported.
2143 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2144 (Vwrite_region_annotation_buffers): Now static.
2145
2146 * eval.c: Make symbols static if they're not exported.
2147 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2148 * lisp.h (backtrace_list): Remove decl.
2149
2150 * emacs.c: Make symbols static if they're not exported.
2151 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2152 (fatal_error_code, fatal_error_signal_hook, standard_args):
2153 Now static.
2154 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2155 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2156 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2157 * lisp.h (fatal_error_signal_hook): Remove decl.
2158 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2159
2160 * editfns.c: Move a (normally-unused) function to its only use.
2161 * editfns.c, lisp.h (get_operating_system_release): Remove.
2162 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2163 worth the hassle of breaking this out.
2164
2165 * xterm.c: Make symbols static if they're not exported.
2166 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2167 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2168 (x_destroy_window, x_delete_display):
2169 Now static.
2170 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2171 (x_mouse_leave): Remove; unused.
2172 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2173 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2174 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2175 Remove decls.
2176 (x_mouse_leave): Declare only if WINDOWSNT.
2177 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2178 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2179 USE_X_TOOLKIT.
2180
2181 * ftxfont.c: Make symbols static if they're not exported.
2182 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2183 HAVE_FREETYPE.
2184 * font.h (ftxfont_driver): Likewise.
2185
2186 * xfns.c: Make symbols static if they're not exported.
2187 (x_last_font_name, x_display_info_for_name):
2188 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2189 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2190 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2191 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2192 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2193 (last_show_tip_args): Now static.
2194 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2195 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2196 (x_screen_planes): Remove; unused.
2197 * dispextern.h (x_screen_planes): Remove decl.
2198
2199 * dispnew.c: Make symbols static if they're not exported.
2200 * dispextern.h (redraw_garbaged_frames, scrolling):
2201 (increment_row_positions): Remove.
2202 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2203 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2204 Now static.
2205 (redraw_garbaged_frames): Remove; unused.
2206
2207 * xfaces.c: Make symbols static if they're not exported.
2208 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2209 Remove decls.
2210 * xterm.h (defined_color): Remove decls.
2211 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2212 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2213 (menu_face_changed_default, defined_color, free_realized_face):
2214 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2215 (ascii_face_of_lisp_face): Remove; unused.
2216
2217 * xdisp.c: Make symbols static if they're not exported.
2218 * dispextern.h (scratch_glyph_row, window_box_edges):
2219 (glyph_to_pixel_coords, set_cursor_from_row):
2220 (get_next_display_element, set_iterator_to_next):
2221 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2222 (show_mouse_face): Remove decls
2223 * frame.h (message_buf_print): Likewise.
2224 * lisp.h (pop_message, set_message, check_point_in_composition):
2225 Likewise.
2226 * xterm.h (set_vertical_scroll_bar): Likewise.
2227 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2228 (message_buf_print, scratch_glyph_row, displayed_buffer):
2229 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2230 (get_next_display_element, show_mouse_face, window_box_edges):
2231 (frame_to_window_pixel_xy, check_point_in_composition):
2232 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2233 (glyph_to_pixel_coords): Remove; unused.
2234
2235 * dired.c (file_name_completion): Now static.
2236
2237 * dbusbind.c (xd_in_read_queued_messages): Now static.
2238
2239 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2240 * data.c (circular_list_error): Remove.
2241
2242 * commands.h (last_point_position, last_point_position_buffer):
2243 (last_point_position_window): Remove decls.
2244 * keyboard.c: Make these variables static.
2245
2246 * coding.h (coding, code_convert_region, encode_coding_gap):
2247 Remove decls.
2248 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2249 (iso_code_class, detect_coding, code_convert_region): Now static.
2250 (encode_coding_gap): Remove; unused.
2251
2252 * chartab.c (chartab_chars, chartab_bits): Now static.
2253
2254 * charset.h (charset_iso_8859_1): Remove decl.
2255 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2256 Now static.
2257
2258 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2259 * ccl.c (Vccl_program_table): Now static.
2260 (check_ccl_update): Remove; unused.
2261
2262 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2263 * category.h: ... from here.
2264 * category.c (check_category_table, set_category_set): Now static.
2265
2266 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2267 * lisp.h: Remove these decls.
2268
2269 * buffer.c (buffer_count): Remove unused var.
2270
2271 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2272 so that it's not optimized away.
2273 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2274 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2275 exported only to the debugger.
2276
2277 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2278 * atimer.h (run_all_atimers): Remove; not exported.
2279
2280 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2281 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2282 was inaccessible from Lisp.
2283 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2284 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2285
2286 alloc.c: Import and export fewer symbols, and remove unused items.
2287 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2288 is defined.
2289 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2290 it's not optimized away by whole-program optimization.
2291 (message_enable_multibyte, free_misc): Remove.
2292 (catchlist, handlerlist, mark_backtrace):
2293 Declare only if BYTE_MARK_STACK.
2294 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2295 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2296 (message_enable_multibyte): Remove decl.
2297 (free_misc, interval_free_list, float_block, float_block_index):
2298 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2299 (cons_free_list, last_marked_index):
2300 Now static.
2301 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2302 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2303 (mark_backtrace): Define only if BYTE_MARK_STACK.
2304 * xdisp.c (message_enable_multibyte): Now static.
2305
2306 Declare Lisp_Object Q* variables to be 'static' if not exported.
2307 This makes it easier for human readers (and static analyzers)
2308 to see whether these variables are used from other modules.
2309 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2310 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2311 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2312 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2313 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2314 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2315 * xmenu.c, xselect.c:
2316 Declare Q* vars static if they are not used in other modules.
2317 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2318 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2319 Remove decls of unexported vars.
2320 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2321
2322 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2323
2324 Make Emacs functions such as Fatom 'static' by default.
2325 This makes it easier for human readers (and static analyzers)
2326 to see whether these functions can be called from other modules.
2327 DEFUN now defines a static function. To make the function external
2328 so that it can be used in other C modules, use the new macro DEFUE.
2329 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2330 (Finit_image_library):
2331 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2332 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2333 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2334 Remove decls, since these functions are now static.
2335 (Funintern, Fget_internal_run_time): New decls, since these functions
2336 were already external.
2337
2338 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2339 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2340 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2341 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2342 * keyboard.c, keymap.c, lread.c:
2343 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2344 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2345 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2346 Mark functions with DEFUE instead of DEFUN,
2347 if they are used in other modules.
2348 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2349 decls for now-static functions.
2350 * buffer.h (Fdelete_overlay): Remove decl.
2351 * callproc.c (Fgetenv_internal): Mark as internal.
2352 * composite.c (Fremove_list_of_text_properties): Remove decl.
2353 (Fcomposition_get_gstring): New forward static decl.
2354 * composite.h (Fcomposite_get_gstring): Remove decl.
2355 * dired.c (Ffile_attributes): New forward static decl.
2356 * doc.c (Fdocumntation_property): New forward static decl.
2357 * eval.c (Ffetch_bytecode): New forward static decl.
2358 (Funintern): Remove extern decl; now in .h file where it belongs.
2359 * fileio.c (Fmake_symbolic_link): New forward static decl.
2360 * image.c (Finit_image_library): New forward static decl.
2361 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2362 * intervals.h (Fprevious_property_change):
2363 (Fremove_list_of_text_properties): Remove decls.
2364 * keyboard.c (Fthis_command_keys): Remove decl.
2365 (Fcommand_execute): New forward static decl.
2366 * keymap.c (Flookup_key): New forward static decl.
2367 (Fcopy_keymap): Now static.
2368 * keymap.h (Flookup_key): Remove decl.
2369 * process.c (Fget_process): New forward static decl.
2370 (Fprocess_datagram_address): Mark as internal.
2371 * syntax.c (Fsyntax_table_p): New forward static decl.
2372 (skip_chars): Remove duplicate decl.
2373 * textprop.c (Fprevious_property_change): New forward static decl.
2374 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2375 Now internal.
2376 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2377 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2378
2379 * editfns.c (Fformat): Remove unreachable code.
2380
2381 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2382
2383 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2384 change. (Bug#8496)
2385
2386 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2387
2388 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2389 when at ZV. (Bug#8487)
2390
2391 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2392
2393 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2394 (Bug#8437)
2395 * keyboard.c (parse_tool_bar_item): Likewise.
2396 * sound.c (sound_cleanup, alsa_close): Likewise.
2397 * termcap.c (tgetent): Likewise.
2398 * xfns.c (x_default_font_parameter): Likewise.
2399 * xsettings.c (read_and_apply_settings): Likewise.
2400
2401 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2402 (overrun_check_free): Protoize.
2403
2404 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2407 since callers should never pass a negative size.
2408 Change the signature to match that of plain 'read' and 'write'; see
2409 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2410 * lisp.h: Update prototypes of emacs_write and emacs_read.
2411
2412 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2413
2414 * xdisp.c (redisplay_window): Don't try to determine the character
2415 position of the scroll margin if the window start point w->startp
2416 is outside the buffer's accessible region. (Bug#8468)
2417
2418 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2419
2420 Fix write-region and its subroutines for buffers > 2GB.
2421 * fileio.c (a_write, e_write): Modify declaration of arguments and
2422 local variables to support buffers larger than 2GB.
2423 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2424
2425 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2426 argument, local variables, and return value.
2427
2428 * lisp.h: Update prototypes of emacs_write and emacs_read.
2429
2430 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2431
2432 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2435
2436 Fix more problems found by GCC 4.6.0's static checks.
2437
2438 * xdisp.c (vmessage): Use a better test for character truncation.
2439
2440 * charset.c (load_charset_map): <, not <=, for optimization,
2441 and to avoid potential problems with integer overflow.
2442 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2443 * casetab.c (set_identity, shuffle): Likewise.
2444 * editfns.c (Fformat): Likewise.
2445 * syntax.c (skip_chars): Likewise.
2446
2447 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2448 This also lets GCC 4.6.0 generate slightly better loop code.
2449
2450 * callint.c (Fcall_interactively): <, not <=, for optimization.
2451 (Fcall_interactively): Count the number of arguments produced,
2452 not the number of arguments given. This is simpler and lets GCC
2453 4.6.0 generate slightly better code.
2454
2455 * ftfont.c: Distingish more carefully between FcChar8 and char.
2456 The previous code passed unsigned char * to a functions like
2457 strlen and xstrcasecmp that expect char *, which does not
2458 conform to the C standard.
2459 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2460 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2461 char * when the C standard requires it.
2462
2463 * keyboard.c (read_char): Remove unused var.
2464
2465 * eval.c: Port to Windows vsnprintf (Bug#8435).
2466 Include <limits.h>.
2467 (SIZE_MAX): Define if the headers do not.
2468 (verror): Do not give up if vsnprintf returns a negative count.
2469 Instead, grow the buffer. This ports to Windows vsnprintf, which
2470 does not conform to C99. Problem reported by Eli Zaretskii.
2471 Also, simplify the allocation scheme, by avoiding the need for
2472 calling realloc, and removing the ALLOCATED variable.
2473
2474 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2475
2476 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2477 But keep the doprint source code for now, as we might revamp it
2478 and use it again (Bug#8435).
2479 * lisp.h (doprnt): Remove.
2480 * Makefile.in (base_obj): Remove doprnt.o.
2481 * deps.mk (doprnt.o): Remove.
2482
2483 error: Print 32- and 64-bit integers portably (Bug#8435).
2484 Without this change, on typical 64-bit hosts error ("...%d...", N)
2485 was used to print both 32- and 64-bit integers N, which relied on
2486 undefined behavior.
2487 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2488 New macro.
2489 * lisp.h (error, verror): Mark as printf-like functions.
2490 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2491 Report overflow in size calculations when allocating printf buffer.
2492 Do not truncate output string at its first null byte.
2493 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2494 Truncate the output at a character boundary, since vsnprintf does not
2495 do that.
2496 * charset.c (check_iso_charset_parameter): Convert internal
2497 character to string before calling 'error', since %c now has the
2498 printf meaning.
2499 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2500 overflow when computing char to be passed to 'error'. Do not
2501 pass Lisp_Object to 'error'; pass the integer instead.
2502 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2503 formatted with plain %d.
2504
2505 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2506
2507 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2508
2509 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2510
2511 * xterm.c (x_catch_errors): Remove duplicate declaration.
2512
2513 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2514
2515 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2516
2517 2011-04-10 Jim Meyering <meyering@redhat.com>
2518
2519 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2520 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2521 return ssize_t not "int", and use size_t as the buffer length.
2522 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2523 * gnutls.h: Update declarations.
2524 * process.c (read_process_output): Use ssize_t, to match.
2525 (send_process): Likewise.
2526
2527 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2528
2529 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2530
2531 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2532
2533 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2534 Use unsigned char, to match FcChar8 type definition.
2535
2536 * xterm.c (handle_one_xevent):
2537 * xmenu.c (create_and_show_popup_menu):
2538 * xselect.c (x_decline_selection_request)
2539 (x_reply_selection_request): Avoid type-punned deref of X events.
2540
2541 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2542
2543 Fix some uses of `int' instead of EMACS_INT.
2544 * search.c (string_match_1, fast_string_match)
2545 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2546 (scan_buffer, find_next_newline_no_quit)
2547 (find_before_next_newline, search_command, Freplace_match)
2548 (Fmatch_data): Make some `int' variables be EMACS_INT.
2549
2550 * xdisp.c (display_count_lines): 3rd argument and return value now
2551 EMACS_INT. All callers changed.
2552 (pint2hrstr): Last argument is now EMACS_INT.
2553
2554 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2555 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2556 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2557 (decode_coding_utf_16, decode_coding_emacs_mule)
2558 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2559 (decode_coding_ccl, decode_coding_charset)
2560 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2561 (decode_coding_iso_2022, decode_coding_emacs_mule)
2562 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2563 <char_offset, last_offset>: Declare EMACS_INT.
2564 (encode_coding_utf_8, encode_coding_utf_16)
2565 (encode_coding_emacs_mule, encode_invocation_designation)
2566 (encode_designation_at_bol, encode_coding_iso_2022)
2567 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2568 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2569 Declare EMACS_INT.
2570 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2571 (encode_invocation_designation): Last argument P_NCHARS is now
2572 EMACS_INT.
2573 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2574 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2575
2576 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2577 All users changed.
2578
2579 * ccl.c (Fccl_execute_on_string): Declare some variables
2580 EMACS_INT.
2581
2582 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2583
2584 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2585
2586 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2587
2588 * process.c (Fformat_network_address): Doc fix.
2589
2590 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2591
2592 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2593
2594 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2595
2596 * keyboard.c (read_char): Call Lisp function help-form-show,
2597 instead of using internal_with_output_to_temp_buffer.
2598 (Qhelp_form_show): New var.
2599 (syms_of_keyboard): Use DEFSYM macro.
2600
2601 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2602
2603 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2604
2605 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2606
2607 * process.c (Flist_processes): Remove to Lisp.
2608 (list_processes_1): Delete.
2609
2610 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2611
2612 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2613
2614 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2615
2616 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2617
2618 Fix more problems found by GCC 4.6.0's static checks.
2619
2620 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2621
2622 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2623
2624 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2625
2626 * xdisp.c (vmessage): Mark as a printf-like function.
2627
2628 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2629
2630 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2631
2632 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2633 printf-like functions.
2634 (tiff_load): Add casts to remove these marks before passing them
2635 to system-supplied API.
2636
2637 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2638
2639 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2640 This avoids several warnings with gcc -Wstrict-overflow.
2641 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2642 directly, rather than having caller test rule sign. This avoids
2643 some unnecessary tests.
2644 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2645 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2646 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2647
2648 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2649 (xfont_open): Avoid unnecessary tests.
2650
2651 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2652
2653 * composite.h, composite.c (composition_gstring_put_cache):
2654 Use EMACS_INT, not int, for length.
2655
2656 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2657 breaking out part of COMPOSITION_DECODE_RULE.
2658 (COMPOSITION_DECODE_RULE): Use it.
2659 * composite.c (get_composition_id): Remove unused local vars,
2660 by using the new macro.
2661
2662 * textprop.c (set_text_properties_1): Change while to do-while,
2663 since the condition is always true at first.
2664
2665 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2666 (interval_deletion_adjustment): Return unsigned value.
2667 All uses changed.
2668
2669 * process.c (list_processes_1, create_pty, read_process_output):
2670 (exec_sentinel): Remove vars that were set but not used.
2671 (create_pty): Remove unnecessary "volatile"s.
2672 (Fnetwork_interface_info): Avoid possibility of int overflow.
2673 (read_process_output): Do adaptive read buffering even if carryover.
2674 (read_process_output): Simplify nbytes computation if buffered.
2675
2676 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2677
2678 * syntax.c (scan_words): Remove var that was set but not used.
2679 (update_syntax_table): Use unsigned instead of int.
2680
2681 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2682 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2683 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2684
2685 * print.c (print_error_message): Avoid int overflow.
2686
2687 * font.c (font_list_entities): Redo for clarity,
2688 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2689
2690 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2691 (font_score): Avoid potential overflow in diff calculation.
2692
2693 * fns.c (substring_both): Remove var that is set but not used.
2694 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2695
2696 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2697
2698 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2699 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2700 can always succeed if overflow has undefined behavior.
2701
2702 * search.c (boyer_moore, wordify): Remove vars set but not used.
2703 (wordify): Omit three unnecessary tests.
2704
2705 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2706 All callers changed. This avoids the need for an unused var.
2707
2708 * casefiddle.c (casify_region): Remove var that is set but not used.
2709
2710 * dired.c (file_name_completion): Remove var that is set but not used.
2711
2712 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2713
2714 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2715 (Finsert_file_contents): Remove unnecessary code checking fd.
2716
2717 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2718 Check for integer overflow on size calculations.
2719
2720 * buffer.c (Fprevious_overlay_change): Remove var that is set
2721 but not used.
2722
2723 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2724 Remove vars that are set but not used.
2725 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2726 (timer_check_2): Mark vars as initialized.
2727
2728 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2729
2730 * image.c (lookup_image): Remove var that is set but not used.
2731 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2732
2733 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2734 that are set but not used.
2735
2736 * xfns.c (make_invisible_cursor): Don't return garbage
2737 if XCreateBitmapFromData fails (Bug#8410).
2738
2739 * xselect.c (x_get_local_selection, x_handle_property_notify):
2740 Remove vars that are set but not used.
2741
2742 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2743 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2744
2745 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2746 Remove var that is set but not used.
2747 (scroll_bar_windows_size): Now size_t, not int.
2748 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2749 Check for overflow.
2750
2751 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2752 (map_tty_color) [!defined MSDOS]: Likewise.
2753
2754 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2755
2756 * coding.c: Remove vars that are set but not used.
2757 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2758 All callers changed.
2759 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2760 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2761 (decode_coding_charset): Remove vars that are set but not used.
2762
2763 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2764 that is set but not used.
2765
2766 * print.c (print_object): Remove var that is set but not used.
2767
2768 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2769 The gnulib version avoids calling malloc in the usual case,
2770 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2771 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2772 * filelock.c (current_lock_owner): Likewise.
2773 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2774 * sysdep.c: Include allocator.h, careadlinkat.h.
2775 (emacs_no_realloc_allocator): New static constant.
2776 (emacs_readlink): New function.
2777 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2778 ../lib/careadlinkat.h.
2779
2780 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2781
2782 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2783 first non-nil return value).
2784
2785 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2786
2787 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2788 if not defined (Bug#8403).
2789
2790 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2791
2792 * xdisp.c (display_count_lines): Remove parameter `start',
2793 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2794 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2795 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2796 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2797 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2798 and thereabouts. All callers changed.
2799 (get_per_char_metric): Remove parameter `f', unused since
2800 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2801
2802 2011-04-02 Jim Meyering <meyering@redhat.com>
2803
2804 do not dereference NULL upon failed strdup
2805 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2806 (ns_get_family): Likewise.
2807
2808 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2809
2810 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2811
2812 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2813
2814 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2815 later (Bug#8403).
2816
2817 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2818
2819 Add lexical binding.
2820
2821 * window.c (Ftemp_output_buffer_show): New fun.
2822 (Fsave_window_excursion):
2823 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2824
2825 * lread.c (lisp_file_lexically_bound_p): New function.
2826 (Fload): Bind Qlexical_binding.
2827 (readevalloop): Remove `evalfun' arg.
2828 Bind Qinternal_interpreter_environment.
2829 (Feval_buffer): Bind Qlexical_binding.
2830 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2831 Mark as dynamic.
2832 (syms_of_lread): Declare `lexical-binding'.
2833
2834 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2835
2836 * keyboard.c (eval_dyn): New fun.
2837 (menu_item_eval_property): Use it.
2838
2839 * image.c (parse_image_spec): Use Ffunctionp.
2840
2841 * fns.c (concat, mapcar1): Accept byte-code-functions.
2842
2843 * eval.c (Fsetq): Handle lexical vars.
2844 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2845 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2846 (FletX, Flet): Obey lexical binding.
2847 (Fcommandp): Handle closures.
2848 (Feval): New `lexical' arg.
2849 (eval_sub): New function extracted from Feval. Use it almost
2850 everywhere where Feval was used. Look up vars in lexical env.
2851 Handle closures.
2852 (Ffunctionp): Move from subr.el.
2853 (Ffuncall): Handle closures.
2854 (apply_lambda): Remove `eval_flags'.
2855 (funcall_lambda): Handle closures and new byte-code-functions.
2856 (Fspecial_variable_p): New function.
2857 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2858 but without exporting it to Lisp.
2859
2860 * doc.c (Fdocumentation, store_function_docstring):
2861 * data.c (Finteractive_form): Handle closures.
2862
2863 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2864 interactive spec.
2865
2866 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2867 New byte-codes.
2868 (exec_byte_code): New function extracted from Fbyte_code to handle new
2869 calling convention for byte-code-functions. Add new byte-codes.
2870
2871 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2872
2873 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2874
2875 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * xdisp.c (redisplay_internal): Fix prototype.
2878
2879 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2880
2881 * xdisp.c (SCROLL_LIMIT): New macro.
2882 (try_scrolling): Use it when setting scroll_limit.
2883 Limit scrolling to 100 screen lines.
2884 (redisplay_window): Even when falling back on "recentering",
2885 position point in the window according to scroll-conservatively,
2886 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2887
2888 (try_scrolling): When point is above the window, allow searching
2889 as far as scroll_max, or one screenful, to compute vertical
2890 distance from PT to the scroll margin position. This prevents
2891 try_scrolling from unnecessarily failing when
2892 scroll-conservatively is set to a value slightly larger than the
2893 window height. Clean up the case of PT below the margin at bottom
2894 of window: scroll_max can no longer be INT_MAX. When aggressive
2895 scrolling is in use, don't let point enter the opposite scroll
2896 margin as result of the scroll.
2897 (syms_of_xdisp) <scroll-conservatively>: Document the
2898 threshold of 100 lines for never-recentering scrolling.
2899
2900 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2901
2902 * dispextern.h (move_it_by_lines):
2903 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2904 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2905 (message_log_check_duplicate): Remove parameters `prev_bol' and
2906 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2907 (redisplay_internal): Remove parameter `preserve_echo_area',
2908 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2909
2910 * indent.c (Fvertical_motion):
2911 * window.c (window_scroll_pixel_based, Frecenter):
2912 Don't pass `need_y_p' to `move_it_by_lines'.
2913
2914 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2915
2916 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2917 steal a few bits to be more compact.
2918 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2919 Remove unneeded casts.
2920
2921 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2922
2923 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2924
2925 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2926 binding" message (bug#7967).
2927
2928 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 Fix more problems found by GCC 4.6.0's static checks.
2931
2932 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2933 Remove unused local var.
2934
2935 * editfns.c (Fmessage_box): Remove unused local var.
2936
2937 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2938 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2939 Omit unused local vars.
2940 * window.c (shrink_windows): Omit unused local var.
2941 * menu.c (digest_single_submenu): Omit unused local var.
2942 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2943 Omit unused local var.
2944
2945 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2946 Don't assume string length fits in int.
2947 (keyremap_step, read_key_sequence): Use size_t for sizes.
2948 (read_key_sequence): Don't check last_real_key_start redundantly.
2949
2950 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2951 instead of alloca (Bug#8344).
2952
2953 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2954 (Fbacktrace_frame): Don't assume nframes fits in int.
2955
2956 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2957
2958 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2959 concerns.
2960
2961 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2962
2963 * cm.c (calccost): Turn while-do into do-while, for clarity.
2964
2965 * keyboard.c (syms_of_keyboard): Use the same style as later
2966 in this function when indexing through an array. This also
2967 works around GCC bug 48267.
2968
2969 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2970
2971 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2972
2973 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2974 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2975
2976 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2977 This avoids undefined behavior on integer overflow, and is a bit
2978 more convenient anyway since it is compared to a size_t variable.
2979
2980 Variadic C functions now count arguments with size_t, not int.
2981 This avoids an unnecessary limitation on 64-bit machines, which
2982 caused (substring ...) to crash on large vectors (Bug#8344).
2983 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2984 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2985 All variadic functions and their callers changed accordingly.
2986 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2987 * data.c (arith_driver, float_arith_driver): Likewise.
2988 * editfns.c (general_insert_function): Likewise.
2989 * eval.c (struct backtrace.nargs, interactive_p)
2990 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2991 (funcall_lambda, mark_backtrace): Likewise.
2992 * fns.c (concat): Likewise.
2993 * frame.c (x_set_frame_parameters): Likewise.
2994 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2995 0 if not found, not -1. All callers changed.
2996
2997 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2998 (stack_copy_size): Now size_t, not int.
2999 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3000
3001 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3002
3003 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3004 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3005 All callers changed.
3006
3007 * lisp.h (multibyte_char_to_unibyte):
3008 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3009 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3010 * character.h (CHAR_TO_BYTE8):
3011 * cmds.c (internal_self_insert):
3012 * editfns.c (general_insert_function):
3013 * keymap.c (push_key_description):
3014 * search.c (Freplace_match):
3015 * xdisp.c (message_dolog, set_message_1): All callers changed.
3016
3017 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3018
3019 * keyboard.c (safe_run_hook_funcall): New function.
3020 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3021 don't set the hook to nil, but remove the offending function instead.
3022 (Qcommand_hook_internal): Remove, unused.
3023 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3024 Vcommand_hook_internal.
3025
3026 * eval.c (enum run_hooks_condition): Remove.
3027 (funcall_nil, funcall_not): New functions.
3028 (run_hook_with_args): Call each function through a `funcall' argument.
3029 Remove `cond' argument, now redundant.
3030 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3031 (Frun_hook_with_args_until_failure): Adjust accordingly.
3032 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3033
3034 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3035
3036 * dispextern.h (string_buffer_position): Remove declaration.
3037
3038 * print.c (strout): Remove parameter `multibyte', unused since
3039 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3040
3041 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3042 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3043 All callers changed.
3044
3045 * w32.c (_wsa_errlist): Use braces for struct initializers.
3046
3047 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3048 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3049 All callers changed.
3050 (string_buffer_position): Likewise. Also, make static (it's never
3051 used outside xdisp.c).
3052 (cursor_row_p): Remove parameter `w', unused since
3053 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3054 (decode_mode_spec): Remove parameter `precision', introduced during
3055 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3056 All callers changed.
3057
3058 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3059
3060 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3061
3062 2011-03-27 Anders Lindgren <andlind@gmail.com>
3063
3064 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3065 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3066 (ns_update_auto_hide_menu_bar): New functions.
3067 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3068 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3069 ns_constrain_all_frames.
3070 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3071 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3072
3073 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3074
3075 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3076
3077 2011-03-27 Glenn Morris <rgm@gnu.org>
3078
3079 * syssignal.h: Replace RETSIGTYPE with void.
3080 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3081 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3082 Replace SIGTYPE with void everywhere.
3083 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3084 * s/template.h (SIGTYPE): Remove commented out definition.
3085
3086 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3087
3088 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3089 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3090
3091 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3092
3093 * w32.c (read_unc_volume): Use parameter `henum', instead of
3094 global variable `wget_enum_handle'.
3095
3096 * keymap.c (describe_vector): Remove parameters `indices' and
3097 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3098 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3099
3100 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3101
3102 * keyboard.c (timer_check): Remove parameter `do_it_now',
3103 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3104 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3105 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3106
3107 * keyboard.c (read_char):
3108 * w32menu.c (w32_menu_display_help):
3109 * xmenu.c (show_help_event, menu_help_callback):
3110 Adjust calls to `show_help_echo'.
3111
3112 * gtkutil.c (xg_maybe_add_timer):
3113 * keyboard.c (readable_events):
3114 * process.c (wait_reading_process_output):
3115 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3116
3117 * insdel.c (adjust_markers_gap_motion):
3118 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3119 (gap_left, gap_right): Don't call it.
3120
3121 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3122
3123 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3124 incurred during fontification.
3125
3126 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3127
3128 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3129 (DEFVAR_PER_BUFFER): Don't pass it.
3130
3131 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3132 (scrolling_window): Don't pass it.
3133
3134 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3135
3136 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3137
3138 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3139 and `suffix'.
3140 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3141 of variables specific to SELinux and computation of `encoded_absname'.
3142
3143 * image.c (XPutPixel): Remove unused variable `height'.
3144
3145 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3146
3147 * unexw32.c (get_section_info): Remove unused variable `section'.
3148
3149 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3150 (system_process_attributes): Remove unused variable `sess'.
3151 (sys_read): Remove unused variable `err'.
3152
3153 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3154 (w32_wnd_proc): Remove unused variable `isdead'.
3155 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3156 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3157 (x_create_tip_frame): Remove unused variable `tem'.
3158
3159 * w32inevt.c (w32_console_read_socket):
3160 Remove unused variable `no_events'.
3161
3162 * w32term.c (x_draw_composite_glyph_string_foreground):
3163 Remove unused variable `width'.
3164
3165 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3166
3167 * w32term.c (x_set_glyph_string_clipping):
3168 Don't pass uninitialized region to CombineRgn.
3169
3170 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3171
3172 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3173 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3174 (Fx_close_connection): Remove unused variable `i'.
3175
3176 * w32font.c (w32font_draw): Return number of glyphs.
3177 (w32font_open_internal): Remove unused variable `i'.
3178 (w32font_driver): Add missing initializer.
3179
3180 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3181 (fill_in_menu): Remove unused variable `items_added'.
3182
3183 * w32term.c (last_mouse_press_frame): Remove static global variable.
3184 (w32_clip_to_row): Remove unused variable `f'.
3185 (x_delete_terminal): Remove unused variable `i'.
3186
3187 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3188 (NOTHING): Remove unused static global variable.
3189 (uniscribe_check_otf): Remove unused variable `table'.
3190 (uniscribe_font_driver): Add missing initializers.
3191
3192 2011-03-23 Julien Danjou <julien@danjou.info>
3193
3194 * term.c (Fsuspend_tty, Fresume_tty):
3195 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3196 * window.c (temp_output_buffer_show):
3197 * insdel.c (signal_before_change):
3198 * frame.c (Fhandle_switch_frame):
3199 * fileio.c (Fdo_auto_save):
3200 * emacs.c (Fkill_emacs):
3201 * editfns.c (save_excursion_restore):
3202 * cmds.c (internal_self_insert):
3203 * callint.c (Fcall_interactively):
3204 * buffer.c (Fkill_all_local_variables):
3205 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3206 Use Frun_hooks.
3207 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3208 unconditionnaly since it does the check itself.
3209
3210 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 Fix more problems found by GCC 4.5.2's static checks.
3213
3214 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3215 the first time through the loop, since we know p0 < p1 then.
3216 This also avoids a gcc -Wstrict-overflow warning.
3217
3218 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3219 leading to a memory leak, possible in functions like
3220 load_charset_map_from_file that can allocate an unbounded number
3221 of objects (Bug#8318).
3222
3223 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3224 that could (at least in theory) be that large.
3225
3226 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3227 This is less likely to overflow, and avoids undefined behavior if
3228 overflow does occur. All callers changed. Use strtoul to scan
3229 for the unsigned long integer.
3230 (pint2hrstr): Simplify and tune code slightly.
3231 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3232
3233 * scroll.c (do_scrolling): Work around GCC bug 48228.
3234 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3235
3236 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3237 This also avoids a warning with gcc -Wstrict-overflow.
3238 (validate_x_resource_name): Simplify count usage.
3239 This also avoids a warning with gcc -Wstrict-overflow.
3240
3241 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3242 fail (Bug#8306).
3243
3244 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3245
3246 * process.c (Fmake_network_process): Use socklen_t, not int,
3247 where POSIX says socklen_t is required in portable programs.
3248 This fixes a porting bug on hosts like 64-bit HP-UX, where
3249 socklen_t is wider than int (Bug#8277).
3250 (Fmake_network_process, server_accept_connection):
3251 (wait_reading_process_output, read_process_output):
3252 Likewise.
3253
3254 * process.c: Rename or move locals to avoid shadowing.
3255 (list_processes_1, Fmake_network_process):
3256 (read_process_output_error_handler, exec_sentinel_error_handler):
3257 Rename or move locals.
3258 (Fmake_network_process): Define label "retry_connect" only if needed.
3259 (Fnetwork_interface_info): Fix pointer signedness.
3260 (process_send_signal): Add cast to avoid pointer signedness problem.
3261 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3262 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3263
3264 Make tparam.h and terminfo.c consistent.
3265 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3266 Include tparam.h instead, since it declares them.
3267 * cm.h (PC): Remove extern decl; tparam.h now does this.
3268 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3269 * terminfo.c: Include tparam.h, to check interfaces.
3270 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3271 (tparam): Adjust signature to match interface in tparam.h;
3272 this removes some undefined behavior. Check that outstring and len
3273 are zero, which they always are with Emacs.
3274 * tparam.h (PC, BC, UP): New extern decls.
3275
3276 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3277 (xftfont_open): Rename locals to avoid shadowing.
3278
3279 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3280 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3281 (OTF_TAG_SYM): Omit macro if not needed.
3282 (ftfont_list): Remove unused local.
3283 (get_adstyle_property, ftfont_pattern_entity):
3284 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3285 Rename locals to avoid shadowing.
3286
3287 * xfont.c (xfont_list_family): Mark var as initialized.
3288
3289 * xml.c (make_dom): Now static.
3290
3291 * composite.c (composition_compute_stop_pos): Rename local to
3292 avoid shadowing.
3293 (composition_reseat_it): Remove unused locals.
3294 (find_automatic_composition, composition_adjust_point): Likewise.
3295 (composition_update_it): Mark var as initialized.
3296 (find_automatic_composition): Mark vars as initialized,
3297 with a FIXME (Bug#8290).
3298
3299 character.h: Rename locals to avoid shadowing.
3300 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3301 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3302 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3303 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3304 to avoid shadowing.
3305
3306 * textprop.c (property_change_between_p): Remove; unused.
3307
3308 * intervals.c (interval_start_pos): Now static.
3309
3310 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3311
3312 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3313 Rename locals to avoid shadowing.
3314
3315 * sound.c (wav_play, au_play, Fplay_sound_internal):
3316 Fix pointer signedness.
3317 (alsa_choose_format): Remove unused local var.
3318 (wav_play): Initialize a variable to 0, to prevent undefined
3319 behavior (Bug#8278).
3320
3321 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3322
3323 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3324
3325 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3326 clobbering (Bug#8298).
3327 * sysdep.c (sys_subshell): Likewise.
3328 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3329
3330 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3331 This should get cleaned up, so that child_setup has the
3332 same signature on all platforms.
3333
3334 * callproc.c (call_process_cleanup): Now static.
3335 (relocate_fd): Rename locals to avoid shadowing.
3336
3337 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3338
3339 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3340 not to be necessary, and produces flickering.
3341
3342 2011-03-20 Glenn Morris <rgm@gnu.org>
3343
3344 * config.in: Remove file.
3345
3346 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3347
3348 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3349 are now in src/globals.h.
3350 (syms_of_minibuf): Remove spurious & from previous change.
3351
3352 2011-03-20 Leo <sdl.web@gmail.com>
3353
3354 * minibuf.c (completing-read-function): New variable.
3355 (completing-read-default): Rename from completing-read.
3356 (completing-read): Call completing-read-function.
3357
3358 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3359
3360 * xfaces.c (Fx_load_color_file):
3361 Read color file from absolute filename (bug#8250).
3362
3363 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3364
3365 * makefile.w32-in: Update dependencies.
3366
3367 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3368
3369 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3370
3371 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3372
3373 Fix more problems found by GCC 4.5.2's static checks.
3374
3375 * process.c (make_serial_process_unwind, send_process_trap):
3376 (sigchld_handler): Now static.
3377
3378 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3379 That way, the code declares only the vars that it needs.
3380 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3381 * s/cygwin.h (PTY_ITERATION): Likewise.
3382 * s/darwin.h (PTY_ITERATION): Likewise.
3383 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3384
3385 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3386 * process.c (allocate_pty): Don't declare stb unless it's needed.
3387
3388 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3389 (CONSTANTLIM): Remove; unused.
3390 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3391 Define only if needed.
3392
3393 * unexelf.c (unexec): Name an expression,
3394 to avoid gcc -Wbad-function-cast warning.
3395 Use a different way to cause a compilation error if anyone uses
3396 n rather than nn, a way that does not involve shadowing.
3397 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3398
3399 * deps.mk (unexalpha.o): Remove; unused.
3400
3401 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3402 * unexec.h: New file.
3403 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3404 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3405 Depend on unexec.h.
3406 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3407 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3408 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3409 Change as necessary to match prototype in unexec.h.
3410
3411 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3412 shadowing.
3413 (back_comment, skip_chars): Mark vars as initialized.
3414
3415 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3416 Rename locals to avoid shadowing.
3417
3418 * lread.c (read1): Rewrite so as not to use empty "else".
3419 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3420
3421 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3422
3423 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3424 warning when compiling print.c.
3425
3426 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3427 instead of using an uninitialized var.
3428 (font_sort_entities): Mark var as initialized.
3429
3430 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3431
3432 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3433 pointers to constants.
3434 (font_parse_fcname): Remove unused vars.
3435 (font_delete_unmatched): Now static.
3436 (font_get_spec): Remove; unused.
3437 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3438 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3439 Rename or move locals to avoid shadowing.
3440
3441 * fns.c (require_nesting_list, require_unwind): Now static.
3442 (Ffillarray): Rename locals to avoid shadowing.
3443
3444 * floatfns.c (domain_error2): Define only if needed.
3445 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3446
3447 * alloc.c (mark_backtrace): Move decl from here ...
3448 * lisp.h: ... to here, so that it can be checked.
3449
3450 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3451 (Fdefvar): Rewrite so as not to use empty "else".
3452 (lisp_indirect_variable): Name an expression,
3453 to avoid gcc -Wbad-function-cast warning.
3454 (Fdefvar): Rename locals to avoid shadowing.
3455
3456 * callint.c (quotify_arg, quotify_args): Now static.
3457 (Fcall_interactively): Rename locals to avoid shadowing.
3458 Use const pointer when appropriate.
3459
3460 * lisp.h (get_system_name, get_operating_system_release):
3461 Move decls here, to check interfaces.
3462 * process.c (get_operating_system_release): Move decl to lisp.h.
3463 * xrdb.c (get_system_name): Likewise.
3464 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3465 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3466 some of which prompt warnings from gcc -Wbad-function-cast.
3467 (Fformat_time_string, Fencode_time, Finsert_char):
3468 (Ftranslate_region_internal, Fformat):
3469 Rename or remove local vars to avoid shadowing.
3470 (Ftranslate_region_internal): Mark var as initialized.
3471
3472 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3473 avoid shadowing.
3474
3475 * lisp.h (eassert): Check that the argument compiles, even if
3476 ENABLE_CHECKING is not defined.
3477
3478 * data.c (Findirect_variable): Name an expression, to avoid
3479 gcc -Wbad-function-cast warning.
3480 (default_value, arithcompare, arith_driver, arith_error): Now static.
3481 (store_symval_forwarding): Rename local to avoid shadowing.
3482 (Fmake_variable_buffer_local, Fmake_local_variable):
3483 Mark variables as initialized.
3484 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3485
3486 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3487 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3488 Rename locals to avoid shadowing.
3489 (mark_stack): Move local variables into the #ifdef region where
3490 they're used.
3491 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3492 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3493 needed otherwise.
3494 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3495 (GC_STRING_CHARS): Remove; not used.
3496 (Fmemory_limit): Cast sbrk's returned value to char *.
3497
3498 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3499 avoids undefined behavior in theory.
3500
3501 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3502
3503 Use functions, not macros, for up- and down-casing (Bug#8254).
3504 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3505 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3506 to use the following functions instead of these macros.
3507 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3508 EMACS_INT, since callers assume the returned value fits in int.
3509 (upcase1): Likewise, for UPCASE_TABLE.
3510 (uppercasep, lowercasep, upcase): New static inline functions.
3511 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3512 the race-condition problem in the old DOWNCASE.
3513
3514 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3515 Rename locals to avoid shadowing.
3516 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3517 (regex_compile, re_search_2, re_match_2_internal):
3518 Remove unused local vars.
3519 (FREE_VAR): Rewrite so as not to use empty "else",
3520 which gcc can warn about.
3521 (regex_compile, re_match_2_internal): Mark locals as initialized.
3522 (RETALLOC_IF): Define only if needed.
3523 (WORDCHAR_P): Likewise. This one is never needed, but is used
3524 only in a comment talking about a compiler bug, so put inside
3525 the #if 0 of that comment.
3526 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3527 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3528 Remove; unused.
3529
3530 * search.c (boyer_moore): Rename locals to avoid shadowing.
3531 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3532 (PREV_CHAR_BOUNDARY): Likewise.
3533
3534 * search.c (simple_search): Remove unused var.
3535
3536 * dired.c (compile_pattern): Move decl from here ...
3537 * lisp.h: ... to here, so that it can be checked.
3538 (struct re_registers): New forward decl.
3539
3540 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3541
3542 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3543 All uses changed.
3544 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3545 Rename locals to avoid shadowing.
3546 (Fvertical_motion): Mark locals as initialized.
3547
3548 * casefiddle.c (casify_object, casify_region): Now static.
3549 (casify_region): Mark local as initialized.
3550
3551 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3552
3553 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3554 New macros, so that the caller can use some names other than
3555 gcpro1, gcpro2, etc.
3556 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3557 of the new macros.
3558 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3559 argument, for consistency with GCPRO2_VAR, etc: it is now the
3560 prefix of the variable, not the variable itself. All uses
3561 changed.
3562 * dired.c (directory_files_internal, file_name_completion):
3563 Rename locals to avoid shadowing.
3564
3565 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3566 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3567 dired.c's scmp function, had undefined behavior.
3568 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3569 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3570 * buffer.h: ... to here, because these macros use current_buffer,
3571 and the new implementation with inline functions needs to have
3572 current_buffer in scope now, rather than later when the macros
3573 are used.
3574 (downcase, upcase1): New static inline functions.
3575 (DOWNCASE, UPCASE1): Reimplement using these functions.
3576 This avoids undefined behavior in expressions like
3577 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3578 from race conditions in accessing the global variables
3579 case_temp1 and case_temp2.
3580 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3581 * lisp.h (case_temp1, case_temp2): Remove their decls.
3582 * character.h (ASCII_CHAR_P): Move from here ...
3583 * lisp.h: ... to here, so that the inline functions mentioned
3584 above can use them.
3585
3586 * dired.c (directory_files_internal_unwind): Now static.
3587
3588 * fileio.c (file_name_as_directory, directory_file_name):
3589 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3590 Now static.
3591 (file_name_as_directory): Use const pointers when appropriate.
3592 (Fexpand_file_name): Likewise. In particular, newdir might
3593 point at constant storage, so make it a const pointer.
3594 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3595 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3596 signedness issues.
3597 (Fset_file_times, Finsert_file_contents, auto_save_error):
3598 Rename locals to avoid shadowing.
3599
3600 * minibuf.c (choose_minibuf_frame_1): Now static.
3601 (Ftry_completion, Fall_completions): Rename or remove locals
3602 to avoid shadowing.
3603
3604 * marker.c (bytepos_to_charpos): Remove; unused.
3605
3606 * lisp.h (verify_bytepos, count_markers): New decls,
3607 so that gcc does not warn that these functions aren't declared.
3608
3609 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3610 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3611 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3612 (copy_text): Remove unused local var.
3613
3614 * filelock.c (within_one_second): Now static.
3615 (lock_file_1): Rename local to avoid shadowing.
3616
3617 * buffer.c (fix_overlays_before): Mark locals as initialized.
3618 (fix_start_end_in_overlays): Likewise. This function should be
3619 simplified by using pointers-to-pointers, but that's a different
3620 matter.
3621 (switch_to_buffer_1): Now static.
3622 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3623 (report_overlay_modification): Rename locals to avoid shadowing.
3624
3625 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3626 Fix pointer signedness issue.
3627 (sys_subshell): Mark local as volatile if checking for lint,
3628 to suppress a gcc -Wclobbered warning that does not seem to be right.
3629 (MAXPATHLEN): Define only if needed.
3630
3631 * process.c (serial_open, serial_configure): Move decls from here ...
3632 * systty.h: ... to here, so that they can be checked.
3633
3634 * fns.c (get_random, seed_random): Move extern decls from here ...
3635 * lisp.h: ... to here, so that they can be checked.
3636
3637 * sysdep.c (reset_io): Now static.
3638 (wait_for_termination_signal): Remove; unused.
3639
3640 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3641 (copy_keymap_item, append_key, push_text_char_description):
3642 Now static.
3643 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3644 (DENSE_TABLE_SIZE): Remove; unused.
3645 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3646 (describe_map_tree):
3647 Rename locals to avoid shadowing.
3648
3649 * keyboard.c: Declare functions static if they are not used elsewhere.
3650 (echo_char, echo_dash, cmd_error, top_level_2):
3651 (poll_for_input, handle_async_input): Now static.
3652 (read_char, kbd_buffer_get_event, make_lispy_position):
3653 (make_lispy_event, make_lispy_movement, apply_modifiers):
3654 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3655 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3656 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3657 (read_key_sequence, read_char): Mark locals as initialized.
3658 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3659
3660 * keyboard.h (make_ctrl_char): New decl.
3661 (mark_kboards): Move decl here ...
3662 * alloc.c (mark_kboards): ... from here.
3663
3664 * lisp.h (force_auto_save_soon): New decl.
3665
3666 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3667 (DEFINE_DUMMY_FUNCTION): New macro.
3668 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3669 Use it.
3670 (main): Add casts to avoid warnings
3671 if GCC considers string literals to be constants.
3672
3673 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3674
3675 * dbusbind.c: Pointer signedness fixes.
3676 (xd_signature, xd_append_arg, xd_initialize):
3677 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3678 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3679 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3680 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3681
3682 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3683 if GCC considers string literals to be constants.
3684 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3685
3686 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3687
3688 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3689 (print_preprocess, print_object): New macro to fix last change.
3690
3691 * print.c (print_preprocess): Don't forget font objects.
3692
3693 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3694
3695 * emacs.c (USAGE3): Doc fixes.
3696
3697 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3698
3699 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3700 structure.
3701
3702 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3703
3704 * lisp.h (VWindow_system, Qfile_name_history):
3705 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3706 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3707 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3708
3709 * w32select.c: Don't #include "keyboard.h".
3710 (run_protected): Add extern declaration for waiting_for_input.
3711
3712 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3713 * w32console.c (detect_input_pending, read_input_pending)
3714 (encode_terminal_code):
3715 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3716 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3717 (w32_system_caret_y, Qfile_name_history):
3718 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3719 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3720 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3721 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3722 * w32proc.c (Qlocal, report_file_error):
3723 * w32term.c (Vwindow_system, updating_frame):
3724 * w32uniscribe.c (initialized, uniscribe_font_driver):
3725 Remove unneeded extern declarations.
3726
3727 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3728
3729 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3730
3731 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3732
3733 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3734 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3735 These macros can no longer be used for assignment.
3736
3737 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3738 Assign struct members directly, instead of using BUF_BEGV etc.
3739 (record_buffer_markers, fetch_buffer_markers): New functions for
3740 recording and fetching special buffer markers.
3741 (set_buffer_internal_1, set_buffer_temp): Use them.
3742
3743 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3744
3745 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3746
3747 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3748 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3749
3750 * xdisp.c (hscroll_window_tree):
3751 (reconsider_clip_changes): Use PT instead of BUF_PT.
3752
3753 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3754
3755 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3756 $(EMACS_ROOT)/lib/intprops.h.
3757
3758 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3759
3760 Fix more problems found by GCC 4.5.2's static checks.
3761
3762 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3763 to unsigned char * to avoid compiler diagnostic.
3764 (xg_free_frame_widgets): Make it clear that a local variable is
3765 needed only if USE_GTK_TOOLTIP.
3766 (gdk_window_get_screen): Make it clear that this macro is needed
3767 only if USE_GTK_TOOLTIP.
3768 (int_gtk_range_get_value): New function, which avoids a diagnostic
3769 from gcc -Wbad-function-cast.
3770 (xg_set_toolkit_scroll_bar_thumb): Use it.
3771 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3772 diagnostic from gcc -Wbad-function-cast.
3773 (get_utf8_string, xg_get_file_with_chooser):
3774 Rename locals to avoid shadowing.
3775 (create_dialog): Move locals to avoid shadowing.
3776
3777 * xgselect.c (xg_select): Remove unused var.
3778
3779 * image.c (four_corners_best): Mark locals as initialized.
3780 (gif_load): Initialize transparent_p to zero (Bug#8238).
3781 Mark another local as initialized.
3782 (my_png_error, my_error_exit): Mark with NO_RETURN.
3783
3784 * image.c (clear_image_cache): Now static.
3785 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3786 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3787 (x_edge_detection): Remove unnecessary cast that
3788 gcc -Wbad-function-cast diagnoses.
3789 (gif_load): Fix pointer signedness.
3790 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3791 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3792
3793 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3794
3795 Improve quality of tests for time stamp overflow.
3796 For example, without this patch (encode-time 0 0 0 1 1
3797 1152921504606846976) returns the obviously-bogus value (-948597
3798 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3799 reports time overflow. See
3800 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3801 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3802 * editfns.c: Include limits.h and intprops.h.
3803 (TIME_T_MIN, TIME_T_MAX): New macros.
3804 (time_overflow): Move earlier, to before first use.
3805 (hi_time, lo_time): New functions, for an accurate test for
3806 out-of-range times.
3807 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3808 (Fget_internal_run_time): Don't assume time_t fits in int.
3809 (make_time): Use list2 instead of Fcons twice.
3810 (Fdecode_time): More accurate test for out-of-range times.
3811 (check_tm_member): New function.
3812 (Fencode_time): Use it, to test for out-of-range times.
3813 (lisp_time_argument): Don't rely on undefined left-shift and
3814 right-shift behavior when checking for time stamp overflow.
3815
3816 * editfns.c (time_overflow): New function, refactoring common code.
3817 (Fformat_time_string, Fdecode_time, Fencode_time):
3818 (Fcurrent_time_string): Use it.
3819
3820 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3821 * dired.c (make_time): Move to ...
3822 * editfns.c (make_time): ... here.
3823 * systime.h: Note the move.
3824
3825 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3826
3827 * fringe.c (update_window_fringes): Remove unused variables.
3828
3829 * unexmacosx.c (copy_data_segment): Also copy __got section.
3830 (Bug#8223)
3831
3832 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3833
3834 * termcap.c [MSDOS]: Include "msdos.h".
3835 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3836 Constify `char *' arguments and their references according to
3837 prototypes in tparam.h.
3838
3839 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3840
3841 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3842 Adapt all references accordingly.
3843
3844 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3845
3846 2011-03-11 Tom Tromey <tromey@redhat.com>
3847
3848 * buffer.c (syms_of_buffer): Remove obsolete comment.
3849
3850 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3851
3852 * termhooks.h (encode_terminal_code): Declare prototype.
3853
3854 * msdos.c (encode_terminal_code): Don't declare prototype.
3855
3856 * term.c (encode_terminal_code): Now external again, used by
3857 w32console.c and msdos.c.
3858
3859 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3860 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3861
3862 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 Fix some minor problems found by GCC 4.5.2's static checks.
3865
3866 * fringe.c (update_window_fringes): Mark locals as initialized
3867 (Bug#8227).
3868 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3869
3870 * alloc.c (mark_fringe_data): Move decl from here ...
3871 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3872 to check its interface.
3873 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3874
3875 * fontset.c (free_realized_fontset): Now static.
3876 (Fset_fontset_font): Rename local to avoid shadowing.
3877 (fontset_font): Mark local as initialized.
3878 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3879
3880 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3881
3882 * xselect.c (x_disown_buffer_selections): Remove; not used.
3883 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3884 (x_own_selection, Fx_disown_selection_internal): Rename locals
3885 to avoid shadowing.
3886 (x_handle_dnd_message): Remove local to avoid shadowing.
3887
3888 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3889 so that the caller can use some name other than gcpro1.
3890 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3891 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3892 (Fx_backspace_delete_keys_p):
3893 Use them to avoid shadowing, and rename vars to avoid shadowing.
3894 (x_decode_color, x_set_name, x_window): Now static.
3895 (Fx_create_frame): Add braces to silence GCC warning.
3896 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3897 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3898 Remove unused locals.
3899 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3900 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3901 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3902 macros.
3903
3904 * xterm.h (x_mouse_leave): New decl.
3905
3906 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3907 Remove unused functions.
3908 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3909 (x_calc_absolute_position): Now static.
3910 (XTread_socket): Don't define label "out" unless it's used.
3911 Don't declare local "event" unless it's used.
3912 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3913 unless they are used.
3914 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3915 (x_fatal_error_signal): Remove; not used.
3916 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3917 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3918 (x_error_catcher, x_connection_closed, x_error_handler):
3919 (x_error_quitter, xembed_send_message, x_iconify_frame):
3920 (my_log_handler): Rename locals to avoid shadowing.
3921 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3922 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3923
3924 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3925 Rename or move locals to avoid shadowing.
3926 (tty_defined_color, merge_face_heights): Now static.
3927 (free_realized_faces_for_fontset): Remove; not used.
3928 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3929 does not deduce is never used uninitialized.
3930 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3931 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3932
3933 * terminal.c (store_terminal_param): Now static.
3934
3935 * xmenu.c (menu_highlight_callback): Now static.
3936 (set_frame_menubar): Remove unused local.
3937 (xmenu_show): Rename parameter to avoid shadowing.
3938 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3939 since they might point to immutable storage.
3940 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3941 since it's unused otherwise.
3942
3943 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3944 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3945 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3946 avoids a gcc -Wuninitialized diagnostic.
3947 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3948 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3949 does not deduce are never used uninitialized.
3950
3951 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3952
3953 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3954 * window.c (window_loop, size_window):
3955 (run_window_configuration_change_hook, enlarge_window): Likewise.
3956
3957 * window.c (display_buffer): Now static.
3958 (size_window): Mark variables that gcc -Wuninitialized
3959 does not deduce are never used uninitialized.
3960 * window.h (check_all_windows): New decl, to forestall
3961 gcc -Wmissing-prototypes diagnostic.
3962 * dispextern.h (bidi_dump_cached_states): Likewise.
3963
3964 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3965 shadowing.
3966 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3967 Include <limits.h>.
3968 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3969 and to avoid gcc -Wuninitialized warning.
3970 (load_charset_map): Mark variables that gcc -Wuninitialized
3971 does not deduce are never used uninitialized.
3972 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3973
3974 * coding.c (coding_set_source, coding_set_destination):
3975 Use "else { /* comment */ }" rather than "else /* comment */;"
3976 for clarity, and to avoid gcc -Wempty-body warning.
3977 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3978 a block, when the outer 'i' will do.
3979 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3980 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3981 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3982 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3983 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3984 Rename locals to avoid shadowing.
3985 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3986 * coding.c (emacs_mule_char, encode_invocation_designation):
3987 Now static, since they're not used elsewhere.
3988 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3989 (decode_coding_object, encode_coding_object, detect_coding_system):
3990 (decode_coding_emacs_mule): Mark variables that gcc
3991 -Wuninitialized does not deduce are never used uninitialized.
3992 (detect_coding_iso_2022): Initialize a local variable that might
3993 be used uninitialized. Leave a FIXME because it's not clear that
3994 this initialization is needed. (Bug#8211)
3995 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3996 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3997 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3998 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3999 Remove unused macros.
4000
4001 * category.c (hash_get_category_set): Remove unused local var.
4002 (copy_category_table): Now static, since it's not used elsewhere.
4003 * character.c (string_count_byte8): Likewise.
4004
4005 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4006 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4007
4008 * chartab.c (copy_sub_char_table): Now static, since it's not used
4009 elsewhere.
4010 (sub_char_table_ref_and_range, char_table_ref_and_range):
4011 Rename locals to avoid shadowing.
4012 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4013
4014 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4015 (BIDI_BOB): Remove unused macro.
4016
4017 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4018 deduce are never used uninitialized.
4019 * term.c (encode_terminal_code): Likewise.
4020
4021 * term.c (encode_terminal_code): Now static. Remove unused local.
4022
4023 * tparam.h: New file.
4024 * term.c, tparam.h: Include it.
4025 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4026 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4027 Move these decls to tparam.h, and make them agree with what
4028 is actually in tparam.c. The previous trick of using incompatible
4029 decls in different modules does not conform to the C standard.
4030 All callers of tparam changed to use tparam's actual API.
4031 * tparam.c (tparam1, tparam, tgoto):
4032 Use const pointers where appropriate.
4033
4034 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4035 * cm.h (struct cm): Likewise.
4036 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4037 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4038 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4039 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4040 (turn_on_face, init_tty): Likewise.
4041 * termchar.h (struct tty_display_info): Likewise.
4042
4043 * term.c (term_mouse_position): Rename local to avoid shadowing.
4044
4045 * alloc.c (mark_ttys): Move decl from here ...
4046 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4047
4048 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4049
4050 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4051
4052 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4053
4054 * search.c (compile_pattern_1): Remove argument regp, unused since
4055 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4056 (compile_pattern): Don't pass it.
4057
4058 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4059
4060 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4061 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4062 for ! HAVE_GTK3.
4063 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4064
4065 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4066
4067 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4068 gdk_window_get_screen, gdk_window_get_geometry,
4069 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4070 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4071 (xg_get_pixbuf_from_pixmap): New function.
4072 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4073 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4074 Call xg_get_pixbuf_from_pixmap instead of
4075 gdk_pixbuf_get_from_drawable.
4076 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4077 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4078 (xg_check_special_colors): Use GtkStyleContext and its functions
4079 for HAVE_GTK3.
4080 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4081 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4082 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4083 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4084 Call gtk_widget_get_preferred_size.
4085 (xg_frame_resized): gdk_window_get_geometry only takes 5
4086 parameters.
4087 (xg_win_to_widget, xg_event_is_for_menubar):
4088 Call gdk_x11_window_lookup_for_display.
4089 (xg_set_widget_bg): New function.
4090 (delete_cb): New function.
4091 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4092 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4093 (xg_set_background_color): Call xg_set_widget_bg.
4094 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4095 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4096 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4097 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4098 if ! HAVE_GTK3.
4099 (update_frame_tool_bar): Call gtk_widget_hide.
4100 (xg_initialize): Use GDK_KEY_g.
4101
4102 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4103 if ! HAVE_GTK3
4104 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4105
4106 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4107 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4108 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4109
4110 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4111
4112 * w32xfns.c (select_palette): Check success of RealizePalette against
4113 GDI_ERROR, not zero.
4114
4115 See ChangeLog.11 for earlier changes.
4116
4117 ;; Local Variables:
4118 ;; coding: utf-8
4119 ;; End:
4120
4121 Copyright (C) 2011 Free Software Foundation, Inc.
4122
4123 This file is part of GNU Emacs.
4124
4125 GNU Emacs is free software: you can redistribute it and/or modify
4126 it under the terms of the GNU General Public License as published by
4127 the Free Software Foundation, either version 3 of the License, or
4128 (at your option) any later version.
4129
4130 GNU Emacs is distributed in the hope that it will be useful,
4131 but WITHOUT ANY WARRANTY; without even the implied warranty of
4132 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4133 GNU General Public License for more details.
4134
4135 You should have received a copy of the GNU General Public License
4136 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.