]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* buffer.h (struct buffer): Use time_t, not int, for a time stamp.
[gnu-emacs] / src / ChangeLog
1 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4 This fixes a Y2038 bug on 64-bit hosts.
5 * buffer.c (reset_buffer):
6 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7 (Fclear_buffer_auto_save_failure):
8 Use 0, not -1, to represent an unset failure time, since time_t
9 might not be signed.
10
11 Remove dependency on glibc malloc internals.
12 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
13 Move back here from lisp.h, but with their new implementations.
14 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
15 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
16 * charset.c (charset_table_init): New static var.
17 (syms_of_charset): Use it instead of xmalloc. This removes a
18 dependency on glibc malloc internals. See Eli Zaretskii's comment in
19 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
20 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
21 Move back to alloc.c.
22 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
23 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
24
25 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
26
27 * nsterm.m (windowDidResize): Call x_set_window_size only when
28 ns_in_resize is true. Otherwise set pixelwidth/height and
29 call change_frame_size (Bug#9628).
30
31 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
32
33 Port --enable-checking=all to Fedora 14 x86-64.
34 * charset.c (syms_of_charset): Also account for glibc malloc's
35 internal overhead when calculating the initial malloc maximum.
36
37 Port --enable-checking=all to Fedora 14 x86.
38 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
39 Move to lisp.h.
40 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
41 (overrun_check_realloc, overrun_check_free):
42 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
43 That way, xmalloc returns a properly-aligned pointer even if
44 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
45 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
46 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
47 into account when calculating the initial malloc maximum.
48 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
49 Move here from alloc.c, so that charset.c can use it too.
50 Properly align; the old code wasn't right for common 32-bit hosts
51 when configured with --enable-checking=all.
52 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
53 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
54
55 2011-09-29 Eli Zaretskii <eliz@gnu.org>
56
57 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
58 use EDOM.
59
60 2011-09-28 Eli Zaretskii <eliz@gnu.org>
61
62 * xdisp.c (compute_display_string_end): If there's no display
63 string at CHARPOS, return -1.
64
65 * bidi.c (bidi_fetch_char): When compute_display_string_end
66 returns a negative value, treat the character as a normal
67 character not covered by a display string. (Bug#9624)
68
69 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
70
71 * lread.c (Fread_from_string): Fix typo in docstring.
72
73 2011-09-27 Eli Zaretskii <eliz@gnu.org>
74
75 * xdisp.c (handle_invisible_prop): If invisible text ends on a
76 newline, reseat the iterator instead of bidi-iterating there one
77 character at a time. (Bug#9610)
78 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail out when
79 past TO_CHARPOS if the bidi iterator is at base embedding level.
80
81 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
82
83 * lread.c (readevalloop): Use correct code for NBSP.
84 (read1): Likewise. (Bug#9608)
85
86 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
87
88 * dbusbind.c (Fdbus_register_signal): When service is not
89 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
90
91 2011-09-25 Glenn Morris <rgm@gnu.org>
92
93 * buffer.c (truncate-lines): Doc fix.
94
95 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
96
97 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
98 (Fset_window_next_buffers): Doc fix.
99
100 2011-09-24 Glenn Morris <rgm@gnu.org>
101
102 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
103
104 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
105
106 Fix minor problems found by static checking.
107 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
108 * indent.c (Fvertical_motion): Fix == vs = typo.
109
110 2011-09-24 Eli Zaretskii <eliz@gnu.org>
111
112 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
113 value is now t. Doc fix.
114
115 * indent.c (Fvertical_motion): Compute and apply the overshoot
116 logic also when moving up, not only when moving down. Fix the
117 confusing name and values of the it_overshoot_expected variable;
118 logic changed accordingly. (Bug#9254) (Bug#9549)
119
120 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
121 CHARPOS is covered by a display string which includes newlines.
122 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
123 is covered by a display string with embedded newlines.
124
125 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
126
127 * dbusbind.c (Fdbus_register_signal): Add match rule to
128 Vdbus_registered_objects_table. (Bug#9581)
129 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
130 docstring.
131
132 2011-09-24 Jim Meyering <meyering@redhat.com>
133
134 Do not ignore write error for any output size.
135 The previous change was incomplete.
136 While it makes emacs --batch detect the vast majority of stdout
137 write failures, errors were still ignored whenever the output size is
138 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
139 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
140 && echo FAIL: ignored write error
141 FAIL: ignored write error
142 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
143 && echo FAIL: ignored write error
144 FAIL: ignored write error
145 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
146
147 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
148
149 * emacs.c (Fkill_emacs): In noninteractive mode exit
150 non-successfully if a write error occurred on stdout. (Bug#9574)
151
152 2011-09-21 Eli Zaretskii <eliz@gnu.org>
153
154 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
155 the xassert test.
156
157 * dispextern.h (struct it): Update the comment documenting what
158 can it->OBJECT be.
159
160 2011-09-20 Eli Zaretskii <eliz@gnu.org>
161
162 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
163 a display string, extend search for cursor position to end of row.
164 (find_row_edges): If the row ends in a newline from a display
165 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
166 Handle the case of a display string with multiple newlines.
167 (Fcurrent_bidi_paragraph_direction): Fix search for previous
168 non-empty line. Fixes confusing cursor motion with arrow keys at
169 the beginning of a line that starts with whitespace.
170
171 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
172
173 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
174 (bug#9493).
175
176 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
177
178 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
179 boolean (Bug#9154).
180
181 2011-09-18 Eli Zaretskii <eliz@gnu.org>
182
183 * xdisp.c (display_line): Record maximum and minimum buffer
184 positions even if no glyphs were produced (e.g., by a zero-width
185 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
186 buffer positions that will be removed from the glyph row because
187 they don't fit.
188 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
189 column is beyond frame width: don't subtract 1 "pixel" when
190 computing width of the stretch.
191 (reseat_at_next_visible_line_start): Undo the change made on
192 2011-09-17 that saved paragraph information and restored it after
193 the call to `reseat'. (Bug#9545)
194
195 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
196
197 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
198 and turn window cursor on if cleared (Bug#9415).
199
200 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
201
202 * search.c (boyer_moore): Take unibyte characters from pattern
203 literally. (Bug#9458)
204
205 2011-09-18 Eli Zaretskii <eliz@gnu.org>
206
207 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
208
209 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
210
211 Fix minor problem found by static checking.
212 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
213 initialized, to pacify gcc -Wuninitialized.
214
215 * fileio.c: Report proper errno when syscall falls.
216 (Finsert_file_contents): Save and restore errno,
217 so that report_file_error outputs the correct diagnostic.
218 (Fwrite_region) [CLASH_DETECTION]: Likewise.
219
220 2011-09-18 Eli Zaretskii <eliz@gnu.org>
221
222 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
223
224 2011-09-17 Eli Zaretskii <eliz@gnu.org>
225
226 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
227 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
228
229 2011-09-17 Eli Zaretskii <eliz@gnu.org>
230
231 * xdisp.c (reseat_at_next_visible_line_start): Keep information
232 about the current paragraph and restore it after the call to
233 reseat.
234
235 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
236 (bidi_find_paragraph_start): Search back for paragraph beginning
237 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
238 (bidi_move_to_visually_next): Only trigger paragraph-related
239 computations when the last character is a newline or at EOB, not
240 just any NEUTRAL_B. (Bug#9470)
241
242 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
243 truncated lines if point is covered by a display string. (Bug#9524)
244
245 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
246
247 * xselect.c: Relax test for outgoing X longs (Bug#9498).
248 (cons_to_x_long): New function.
249 (lisp_data_to_selection_data): Use it. Correct the test for
250 short-versus-long data; it was negated. Break out of vector
251 loop, for efficiency, when a long datum is discovered.
252
253 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
254
255 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
256
257 2011-09-16 Eli Zaretskii <eliz@gnu.org>
258
259 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
260 GCC PR/17406) by declaring this function with external scope.
261
262 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
263
264 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
265 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
266
267 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
268
269 * editfns.c (Fformat): Correctly handle text properties on "%%".
270
271 2011-09-15 Eli Zaretskii <eliz@gnu.org>
272
273 * xterm.c (x_draw_composite_glyph_string_foreground):
274 * w32term.c (x_draw_composite_glyph_string_foreground):
275 * term.c (encode_terminal_code):
276 * composite.c (composition_update_it, get_composition_id):
277 * xdisp.c (get_next_display_element)
278 (fill_composite_glyph_string): Add comments about special meaning
279 of TAB characters in a composition.
280
281 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
282
283 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
284 This occurs when processing a multibyte format.
285 Problem reported by Wolfgang Jenker.
286
287 2011-09-15 Johan Bockgård <bojohan@gnu.org>
288
289 * xdisp.c (try_cursor_movement): Only check for exact match if
290 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
291
292 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
293
294 Remove unused external symbols.
295 * dispextern.h (calc_pixel_width_or_height): Remove decl.
296 * xdisp.c (calc_pixel_width_or_height): Now static.
297 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
298 * indent.c (check_display_width):
299 * w32term.c: Fix comment to match code.
300 * xterm.c, xterm.h (x_catching_errors): Remove.
301
302 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
303
304 * xselect.c: Use signed conversions more consistently (Bug#9498).
305 (selection_data_to_lisp_data): Assume incoming selection data are
306 signed integers, not unsigned. This is to be consistent with
307 outgoing selection data, which was modified to use signed integers
308 in as part of the fix to Bug#9196 in response to Jan D.'s comment
309 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
310 expects long, not unsigned long.
311
312 2011-09-14 Eli Zaretskii <eliz@gnu.org>
313
314 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
315 computation of loop end. Reported by Johan Bockgård
316 <bojohan@gnu.org>.
317
318 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
319
320 * frame.c (Fother_visible_frames_p): Function deleted.
321
322 2011-09-12 Eli Zaretskii <eliz@gnu.org>
323
324 * indent.c (compute_motion): Process display vector front to back
325 rather than the other way around. (Bug#2496)
326
327 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
328
329 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
330
331 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
332
333 * minibuf.c (Fread_from_minibuffer): Doc fix.
334
335 2011-09-11 Eli Zaretskii <eliz@gnu.org>
336
337 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
338 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
339
340 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
341
342 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
343 value for non-existent files.
344
345 2011-09-11 Eli Zaretskii <eliz@gnu.org>
346
347 * fileio.c (Finsert_file_contents): If the file cannot be opened,
348 set its "size" to -1. This will set the modtime_size field of
349 the corresponding buffer to -1, which is what
350 verify-visited-file-modtime expects for files that do not exist.
351 (Bug#9139)
352
353 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
354
355 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
356 here ...
357 * lisp.h: ... from here. push_key_description is no longer
358 defined in keyboard.c, so its declaration should not be in
359 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
360 logically belongs with push_key_description.
361
362 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
363
364 * buffer.h: Include <sys/types.h> instead of <time.h>.
365 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
366 Problem reported by Herbert J. Skuhra.
367
368 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
369
370 * xml.c (parse_region): Make the parsing work for
371 non-comment-starting XML files again (bug#9144).
372
373 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
374
375 * image.c (gif_load): Fix calculation of bottom and right corner.
376 (Bug#9468)
377
378 2011-09-10 Eli Zaretskii <eliz@gnu.org>
379
380 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
381 redisplay in small windows.
382
383 2011-09-09 Eli Zaretskii <eliz@gnu.org>
384
385 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
386
387 2011-09-08 Martin Rudalics <rudalics@gmx.at>
388
389 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
390 Operate on live windows only.
391
392 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
393
394 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
395
396 2011-09-07 Eli Zaretskii <eliz@gnu.org>
397
398 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
399 only under bidi iteration.
400
401 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
402
403 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
404
405 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
406
407 isnan: Fix porting problem to Solaris 10 with bundled gcc.
408 Without this fix, the command to link temacs failed due to an
409 undefined symbol __builtin_isnan. This is because
410 /usr/include/iso/math_c99.h #defines isnan(x) to
411 __builtin_isnan(x), but the bundled gcc, which identifies itself
412 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
413 a __builtin_isnan.
414 * floatfns.c (isnan): #undef, and then #define to a clone of
415 what's in data.c.
416 (Fisnan): Always define, since it's always available now.
417 (syms_of_floatfns): Always define isnan at the Lisp level.
418
419 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
420
421 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
422
423 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
424
425 * fileio.c: Fix bugs with large file offsets (Bug#9428).
426 The previous code assumed that file offsets (off_t values) fit in
427 EMACS_INT variables, which is not true on typical 32-bit hosts.
428 The code messed up by falsely reporting buffer overflow in cases
429 such as (insert-file-contents "big" nil 1 2) into an empty buffer
430 when "big" contains more than 2**29 bytes, even though this
431 inserts just one byte and does not overflow the buffer.
432 (Finsert_file_contents): Store file offsets as off_t
433 values, not as EMACS_INT values. Check for overflow when
434 converting between EMACS_INT and off_t. When checking for
435 buffer overflow or for overlap, take the offsets into account.
436 Don't use EMACS_INT for small values where int suffices.
437 When checking for overlap, fix a typo: ZV was used where
438 ZV_BYTE was intended.
439 (Fwrite_region): Don't assume off_t fits into 'long'.
440 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
441
442 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
443
444 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
445
446 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
447
448 sprintf-related integer and memory overflow issues (Bug#9412).
449
450 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
451 (esprintf, exprintf, evxprintf): New functions.
452 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
453 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
454 (modify_event_symbol): Do not assume that the length of
455 name_alist_or_stem is safe to alloca and fits in int.
456 (Fexecute_extended_command): Likewise for function name and binding.
457 (Frecursion_depth): Wrap around reliably on integer overflow.
458 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
459 since some callers pass EMACS_INT values.
460 (Fsingle_key_description): Don't crash if symbol name contains more
461 than MAX_ALLOCA bytes.
462 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
463 (get_minibuffer): Arg is now EMACS_INT, not int.
464 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
465 (esprintf, exprintf, evxprintf): New decls.
466 * window.h (command_loop_level, minibuf_level): Reflect API changes.
467
468 * dbusbind.c (signature_cat): New function.
469 (xd_signature, Fdbus_register_signal):
470 Do not overrun buffer; instead, report string overflow.
471
472 * dispnew.c (add_window_display_history): Don't overrun buffer.
473 Truncate instead; this is OK since it's just a log.
474
475 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
476 even if the time zone offset is outlandishly large.
477 Don't mishandle offset == INT_MIN.
478
479 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
480 when creating daemon; the previous buffer-overflow check was incorrect.
481
482 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
483 which has the guts of the old verror function.
484
485 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
486 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
487
488 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
489 (font_unparse_xlfd): Don't blindly alloca long strings.
490 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
491 fits in int, when using sprintf. Use single snprintf to count
492 length of string rather than counting it via multiple sprintfs;
493 that's simpler and more reliable.
494 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
495 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
496 sprintf, in case result does not fit in int.
497
498 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
499 (fontset_from_font): Print it.
500
501 * frame.c (tty_frame_count): Now printmax_t, not int.
502 (make_terminal_frame, set_term_frame_name): Print it.
503 (x_report_frame_params): In X, window IDs are unsigned long,
504 not signed long, so print them as unsigned.
505 (validate_x_resource_name): Check for implausibly long names,
506 and don't assume name length fits in 'int'.
507 (x_get_resource_string): Don't blindly alloca invocation name;
508 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
509 not fit in int.
510
511 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
512 (xg_check_special_colors, xg_set_geometry):
513 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
514
515 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
516 Use esprintf, not sprintf, in case result does not fit in int.
517
518 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
519 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
520 it as a large positive number.
521 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
522 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
523
524 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
525 in case result does not fit in int.
526
527 * print.c (float_to_string): Detect width overflow more reliably.
528 (print_object): Make sprintf buffer a bit bigger, to avoid potential
529 buffer overrun. Don't assume list length fits in 'int'. Treat
530 print length of 0 as 0, not as infinity; to be consistent with other
531 uses of print length in this function. Don't overflow print length
532 index. Don't assume hash table size fits in 'long', or that
533 vectorlike size fits in 'unsigned long'.
534
535 * process.c (make_process): Use printmax_t, not int, to format
536 process-name gensyms.
537
538 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
539
540 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
541 to avoid potential buffer overrun.
542
543 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
544 if X resource line is longer than 512 bytes.
545
546 * xfns.c (x_window): Make sprintf buffer a bit bigger
547 to avoid potential buffer overrun.
548
549 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
550
551 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
552
553 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
554
555 Integer overflow fixes for scrolling, etc.
556 Without these, Emacs silently mishandles large integers sometimes.
557 For example, "C-u 4294967297 M-x recenter" was treated as if
558 it were "C-u 1 M-x recenter" on a typical 64-bit host.
559
560 * xdisp.c (try_window_id): Check Emacs fixnum range before
561 converting to 'int'.
562
563 * window.c (window_scroll_line_based, Frecenter):
564 Check that an Emacs fixnum is in range before assigning it to 'int'.
565 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
566 values converted from Emacs fixnums.
567 (Frecenter): Don't wrap around a line count if it is out of 'int'
568 range; instead, treat it as an extreme value.
569 (Fset_window_configuration, compare_window_configurations):
570 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
571
572 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
573 that can exceed INT_MAX. Check that EMACS_INT value is in range
574 before assigning it to the (possibly-narrower) index.
575 (match_limit): Don't assume that a fixnum can fit in 'int'.
576
577 * print.c (print_object): Use ptrdiff_t, not int, for index that can
578 exceed INT_MAX.
579
580 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
581 (Fvertical_motion): Don't wrap around LINES values that don't fit
582 in 'int'. Instead, treat them as extreme values. This is good
583 enough for windows, which can't have more than INT_MAX lines anyway.
584
585 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
586
587 * Require libxml/parser.h to avoid compilation warning.
588
589 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
590
591 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
592 since this reportedly can destroy thread storage.
593
594 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
595
596 * syntax.c (find_defun_start): Update all cache variables if
597 exiting early (Bug#9401).
598
599 2011-08-30 Eli Zaretskii <eliz@gnu.org>
600
601 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
602
603 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
604 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
605 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
606
607 * term.c (tty_append_glyph): New function.
608 (produce_stretch_glyph): Static function and its prototype deleted.
609
610 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
611 prototypes.
612
613 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
614
615 * image.c (parse_image_spec): Check for nonnegative, not for positive,
616 when checking :margin (Bug#9390).
617 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
618 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
619 so that the name doesn't mislead. All uses changed.
620
621 2011-08-28 Johan Bockgård <bojohan@gnu.org>
622
623 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
624 set_tty_hooks.
625
626 2011-08-27 Eli Zaretskii <eliz@gnu.org>
627
628 * xdisp.c (move_it_to): Don't bail out early when reaching
629 position beyond to_charpos, if we are scanning backwards.
630 (move_it_vertically_backward): When DY == 0, make sure we get to
631 the first character in the line after the newline.
632
633 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
634
635 * ccl.c: Improve and simplify overflow checking (Bug#9196).
636 (ccl_driver): Do not generate an out-of-range pointer.
637 (Fccl_execute_on_string): Remove unnecessary check for
638 integer overflow, noted by Stefan Monnier in
639 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
640 Remove a FIXME that didn't need fixing.
641 Simplify the newly-introduced buffer reallocation code.
642
643 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
644
645 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
646
647 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
648
649 Integer and memory overflow issues (Bug#9196).
650
651 * doc.c (get_doc_string): Rework so that
652 get_doc_string_buffer_size is the actual buffer size, rather than
653 being 1 less than the actual buffer size; this makes xpalloc more
654 convenient.
655
656 * image.c (x_allocate_bitmap_record, cache_image):
657 * xselect.c (Fx_register_dnd_atom):
658 Simplify previous changes by using xpalloc.
659
660 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
661 since either will do and ptrdiff_t is convenient with xpalloc.
662
663 * charset.c (charset_table_size)
664 (struct charset_sort_data.priority): Now ptrdiff_t.
665 (charset_compare): Don't overflow if priorities differ greatly.
666 (Fsort_charsets): Don't assume list length fits in int.
667 Check for size-calculation overflow when allocating sort data.
668 (syms_of_charset): Allocate an initial charset table that is
669 just under 64 KiB, to avoid problems with glibc malloc and mmap.
670
671 * cmds.c (internal_self_insert): Check for size-calculation overflow.
672
673 * composite.h (struct composition.glyph_len): Now int, not unsigned.
674 The actual value is always <= INT_MAX, and leaving it unsigned made
675 overflow checking harder.
676
677 * dispextern.h (struct glyph_matrix.rows_allocated)
678 (struct face_cache.size): Now ptrdiff_t, for convenience in use
679 with xpalloc. The values are still always <= INT_MAX.
680
681 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
682
683 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
684 (SAFE_NALLOCA): New macro.
685
686 * region-cache.c (struct boundary.pos, find_cache_boundary)
687 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
688 (set_cache_region, invalidate_region_cache)
689 (revalidate_region_cache, know_region_cache, region_cache_forward)
690 (region_cache_backward, pp_cache):
691 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
692 so that ptrdiff_t * can be passed to xpalloc.
693 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
694 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
695 (pp_cache): Don't assume cache_len fits in int.
696 * region-cache.h: Adjust extern decls to match.
697
698 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
699 EMACS_INT, since either will do, for xpalloc.
700
701 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
702 (xnmalloc, xnrealloc, xpalloc): New functions.
703
704 * bidi.c (bidi_shelve_header_size): New constant.
705 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
706 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
707
708 * bidi.c (bidi_cache_shrink):
709 * buffer.c (overlays_at, overlays_in, record_overlay_string)
710 (overlay_strings):
711 Don't update size of array until after memory allocation succeeds,
712 because xmalloc/xrealloc may not return.
713 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
714 now that we have proper integer overflow checking.
715 (record_overlay_string, overlay_strings): Catch overflows when
716 calculating size of overlay_str_buf.
717
718 * callproc.c (Fcall_process): Check for size overflow when
719 calculating size of args2.
720 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
721 Normally we prefer signed values, but sticking with ptrdiff_t would
722 require adding more-complicated checks.
723
724 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
725 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
726 Redo buffer-overflow calculations to avoid integer overflow.
727 Add a FIXME comment where memory seems to be over-allocated.
728
729 * character.c (Fstring): Check for size-calculation overflow.
730
731 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
732 unnecessary integer overflow. Check for size overflow.
733 (encode_coding_object): Don't update size until xmalloc succeeds.
734
735 * composite.c (get_composition_id): Check for overflow in glyph
736 length calculations.
737
738 Integer and memory overflow fixes for display code.
739 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
740 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
741 (scrolling_window): Check for overflow in size calculations.
742 (line_draw_cost, realloc_glyph_pool, add_row_entry):
743 Don't assume glyph table len fits in int.
744 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
745 (row_table_size): Now ptrdiff_t, not int.
746 (scrolling_window): Avoid overflow in size calculations.
747 Don't update size until allocation succeeds.
748 * fns.c (concat): Check for overflow in size calculations.
749 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
750 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
751 (NEXT_ALMOST_PRIME_LIMIT): New constant.
752
753 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
754 (get_doc_string): Check for size calculation overflow.
755 Don't update size until allocation succeeds.
756 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
757 EMACS_INT, where ptrdiff_t will do.
758 (Fsubstitute_command_keys): Check for string overflow.
759
760 * editfns.c (set_time_zone_rule): Don't assume environment length
761 fits in int.
762 (message_length): Now ptrdiff_t, not int.
763 (Fmessage_box): Don't update size until allocation succeeds.
764 Don't assume message length fits in int.
765 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
766
767 * emacs.c (main): Do not reallocate argv, since there is a null at
768 the end that can be overwritten, and this way there's no need to
769 worry about size-calculation overflow.
770 (sort_args): Check for size-calculation overflow.
771
772 * eval.c (init_eval_once, grow_specpdl): Don't update size until
773 alloc succeeds.
774 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
775
776 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
777 (x_set_scroll_bar_width, x_figure_window_size):
778 Check for integer overflow.
779 (x_set_alpha): Do not assume XINT fits in int.
780
781 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
782 This is for the members text_lines, text_cols, total_lines, total_cols,
783 where the system imposes an 'int' limit.
784
785 * fringe.c (Fdefine_fringe_bitmap):
786 Don't update size until alloc works.
787
788 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
789 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
790
791 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
792 Check for size-calculation overflow.
793 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
794 do, as we prefer signed integers.
795 (id_to_widget.max_size, id_to_widget.used)
796 (xg_store_widget_in_map, xg_remove_widget_from_map)
797 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
798 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
799 Use and return ptrdiff_t, not int.
800 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
801 * gtkutil.h: Change prototypes to match the above.
802
803 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
804 are duplicate now that they've been promoted to lisp.h.
805 (x_allocate_bitmap_record, x_alloc_image_color)
806 (make_image_cache, cache_image, xpm_load):
807 Don't update size until alloc is done.
808 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
809 (x_detect_edges):
810 Check for size calculation overflow.
811 (ct_colors_allocated_max): New constant.
812 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
813 overflow.
814
815 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
816 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
817 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
818 Use ptrdiff_t, not int, to count maps.
819 (read_char_minibuf_menu_prompt): Check for overflow in size
820 calculations. Don't update size until allocation succeeds. Redo
821 calculations to avoid overflow.
822 * keyboard.h: Change prototypes to match the above.
823
824 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
825 to count maps.
826 (current_minor_maps): Check for size calculation overflow.
827 * keymap.h: Change prototypes to match the above.
828
829 * lread.c (read1, init_obarray): Don't update size until alloc done.
830
831 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
832 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
833
834 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
835 Now ptrdiff_t, not int.
836 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
837 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
838
839 * process.c (Fnetwork_interface_list): Check for overflow
840 in size calculation.
841
842 * region-cache.c (move_cache_gap): Check for size calculation overflow.
843
844 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
845 overflow. Don't bother calling xmalloc when xrealloc will do.
846
847 * search.c (Freplace_match): Check for size calculation overflow.
848 (Fset_match_data): Don't assume list lengths fit in 'int'.
849
850 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
851 for command line length. Do not attempt to address one before the
852 beginning of an array, as that's not portable.
853
854 * term.c (max_frame_lines): Remove; unused.
855 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
856 not int.
857 (encode_terminal_code, calculate_costs): Check for size
858 calculation overflow.
859 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
860 table lengths and related sizes. Don't update size until alloc
861 done. Redo calculations to avoid overflow.
862 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
863
864 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
865 subtracting pointers.
866 (gobble_line): Check for overflow more carefully. Don't update size
867 until alloc done.
868
869 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
870 Don't update size until alloc done.
871 Redo size calculations to avoid overflow.
872 Check for size calculation overflow.
873 (main) [DEBUG]: Fix typo in invoking tparam1.
874
875 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
876 Use ptrdiff_t, not int, for sizes.
877 (store_mode_line_noprop_char): Don't update size until alloc done.
878
879 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
880 Use ptrdiff_t, not int, for sizes.
881 (Finternal_make_lisp_face, cache_face):
882 Check for size calculation overflow.
883 (cache_face): Treat size calculation overflows as if they were
884 memory exhaustion (the usual treatment), rather than aborting.
885
886 * xfns.c (x_encode_text, x_set_name_internal)
887 (Fx_change_window_property): Use ptrdiff_t, not int, to count
888 sizes, since they can exceed INT_MAX in size. Check for size
889 calculation overflow.
890
891 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
892 (xg_select): Check for size calculation overflow.
893 Don't update size until alloc done.
894
895 * xrdb.c (get_environ_db): Don't assume path length fits in int,
896 as sprintf is limited to int lengths.
897
898 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
899 (X_LONG_MIN): New macros.
900 Use them to make the following changes clearer.
901 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
902 This change doesn't affect the value now, but it may help remind
903 future maintainers not to raise the value too much later.
904 (SELECTION_QUANTUM): Remove, replacing with ...
905 (selection_quantum): ... new function, which avoids overflow.
906 All uses changed.
907 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
908 assumption that selection length fits in 'int'.
909 (x_reply_selection_request, x_handle_selection_request)
910 (x_get_window_property, receive_incremental_selection)
911 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
912 (lisp_data_to_selection_data, clean_local_selection_data):
913 Use ptrdiff_t, not int, to record length of selection.
914 (x_reply_selection_request, x_get_window_property)
915 (receive_incremental_selection, x_property_data_to_lisp):
916 Redo calculations to avoid overflow.
917 (x_reply_selection_request): When sending hint, ceiling it at
918 X_LONG_MAX rather than relying on wraparound overflow to send
919 something.
920 (x_get_window_property, receive_incremental_selection)
921 (lisp_data_to_selection_data, x_property_data_to_lisp):
922 Check for size-calculation overflow.
923 (x_get_window_property, receive_incremental_selection)
924 (lisp_data_to_selection_data, Fx_register_dnd_atom):
925 Don't store size until memory allocation succeeds.
926 (x_get_window_property): Plug memory leak on memory exhaustion.
927 Don't double-block input; malloc is safe here. Don't assume 2**34
928 - 4 fits in unsigned long. Add an xassert to check
929 XGetWindowProperty overflow. Be more careful about overflow
930 calculations, and distinguish size from memory overflow better.
931 (receive_incremental_selection): When tracing, don't assume
932 unsigned int is less than INT_MAX.
933 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
934 harmful) conversions of unsigned short to int.
935 (lisp_data_to_selection_data): Don't assume that integers
936 in the range -65535 through -1 fit in an X unsigned short.
937 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
938 result parameters unless successful. Rely on cons_to_unsigned
939 to report problems with elements; the old code wasn't right anyway.
940 (x_check_property_data): Check for int overflow; we cannot use
941 a wider type due to X limits.
942 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
943
944 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
945
946 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
947 (x_term_init): Check for size calculation overflow.
948 (x_color_cells): Don't store size until memory allocation succeeds.
949 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
950 Don't assume alloca size is less than MAX_ALLOCA.
951 (x_term_init): Don't assume length fits in int (sprintf is limited
952 to int size).
953
954 Use ptrdiff_t for composition IDs.
955 * character.c (lisp_string_width):
956 * composite.c (composition_table_size, n_compositions)
957 (get_composition_id, composition_gstring_from_id):
958 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
959 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
960 * window.c (Frecenter):
961 Use ptrdiff_t, not int, for composition IDs.
962 * composite.c (get_composition_id): Check for integer overflow.
963 * composite.h: Adjust prototypes to match the above changes.
964
965 Use ptrdiff_t for hash table indexes.
966 * category.c (hash_get_category_set):
967 * ccl.c (ccl_driver):
968 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
969 * coding.c (coding_system_charset_list, detect_coding_system):
970 * coding.h (struct coding_system.id):
971 * composite.c (get_composition_id, gstring_lookup_cache):
972 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
973 * image.c (xpm_get_color_table_h):
974 * lisp.h (hash_lookup, hash_put):
975 * minibuf.c (Ftest_completion):
976 Use ptrdiff_t for hash table indexes, not int (which is too
977 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
978 32-bit --with-wide-int hosts).
979
980 * charset.c (Fdefine_charset_internal): Check for integer overflow.
981 Add a FIXME comment about memory leaks.
982 (syms_of_charset): Don't assume xmalloc returns.
983
984 Don't assume that stated character widths fit in int.
985 * character.c (Fchar_width, c_string_width, lisp_string_width):
986 * character.h (CHAR_WIDTH):
987 * indent.c (MULTIBYTE_BYTES_WIDTH):
988 Use sanitize_char_width to avoid undefined and/or bad behavior
989 with outlandish widths.
990 * character.h (sanitize_tab_width): Renamed from sanitize_width,
991 now that we have two such functions. All uses changed.
992 (sanitize_char_width): New inline function.
993
994 Don't assume that tab-width fits in int.
995 * character.h (sanitize_width): New inline function.
996 (SANE_TAB_WIDTH): New macro.
997 (ASCII_CHAR_WIDTH): Use it.
998 * indent.c (sane_tab_width): Remove. All uses replaced by
999 SANE_TAB_WIDTH (current_buffer).
1000 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1001
1002 * fileio.c: Integer overflow issues with file modes.
1003 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1004
1005 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1006 Remove unreachable code.
1007 (read_hex, load_charset_map_from_file): Check for integer overflow.
1008
1009 * xterm.c: don't go over XClientMessageEvent limit
1010 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1011 (x_send_scroll_bar_event): Likewise. Check that the size does not
1012 exceed limits imposed by XClientMessageEvent, as well as the usual
1013 ptrdiff_t and size_t limits.
1014
1015 * keyboard.c: Overflow, signedness and related fixes.
1016 (make_lispy_movement): Use same integer type in forward decl
1017 that is used in the definition.
1018 (read_key_sequence, keyremap_step):
1019 Change bufsize argument back to int, undoing my 2011-03-30 change.
1020 We prefer signed types, and int is wide enough here.
1021 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1022 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1023 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1024 length, not size_t. Use ptrdiff_t for index, not int.
1025 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1026 possibility of integer overflow.
1027
1028 Overflow, signedness and related fixes for images.
1029
1030 * dispextern.h (struct it.stack[0].u.image.image_id)
1031 (struct_it.image_id, struct image.id, struct image_cache.size)
1032 (struct image_cache.used, struct image_cache.ref_count):
1033 * gtkutil.c (update_frame_tool_bar):
1034 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1035 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1036 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1037 * nsmenu.m (update_frame_tool_bar):
1038 * xdisp.c (calc_pixel_width_or_height):
1039 * xfns.c (image_cache_refcount):
1040 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1041 on typical 64-bit hosts.
1042
1043 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1044 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1045 Omit unnecessary casts to int.
1046 (parse_image_spec): Check that integers fall into 'int' range
1047 when the callers expect that.
1048 (image_ascent): Redo ascent calculation to avoid int overflow.
1049 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1050 (lookup_image): Remove unnecessary tests.
1051 (xbm_image_p): Locals are now of int, not EMACS_INT,
1052 since parse_image_check makes sure they fit into int.
1053 (png_load, gif_load, svg_load_image):
1054 Prefer int to unsigned where either will do.
1055 (tiff_handler): New function, combining the cores of the
1056 old tiff_error_handler and tiff_warning_handler. This
1057 function is rewritten to use vsnprintf and thereby avoid
1058 stack buffer overflows. It uses only the features of vsnprintf
1059 that are common to both POSIX and native Microsoft.
1060 (tiff_error_handler, tiff_warning_handler): Use it.
1061 (tiff_load, gif_load, imagemagick_load_image):
1062 Don't assume :index value fits in 'int'.
1063 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1064 (imagemagick_load_image): Check that crop parameters fit into
1065 the integer types that MagickCropImage accepts. Don't assume
1066 Vimagemagick_render_type has a nonnegative value. Don't assume
1067 size_t fits in 'long'.
1068 (gs_load): Use printmax_t to print the widest integers possible.
1069 Check for integer overflow when computing image height and width.
1070
1071 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1072
1073 * xdisp.c (redisplay_window): Don't force window start if point
1074 will be invisible in the resulting window. (Bug#9324)
1075
1076 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1077
1078 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1079 the display spec is of the form `(space ...)'.
1080 (handle_display_spec): Return the value returned by
1081 handle_single_display_spec, not just 1 or zero.
1082 (handle_single_display_spec): If the display spec is of the form
1083 `(space ...)', and specifies display in the text area, return 2
1084 rather than 1.
1085 (try_cursor_movement): Check for the need to scroll more
1086 accurately, and prefer exact match for point under bidi. Don't
1087 advance `row' beyond the last row of the window.
1088
1089 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1090 into disp_prop; all users changed.
1091
1092 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1093 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1094 for the text covered by the display property.
1095
1096 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1097
1098 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1099 Change return value to nil.
1100 (Frecord_buffer): Delete unused function.
1101
1102 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1103
1104 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1105 buffers, return left-to-right.
1106 (set_cursor_from_row): Consider candidate row a win if its glyph
1107 represents a newline and point is on that newline. Fixes cursor
1108 positioning on the newline at EOL of R2L text within L2R
1109 paragraph, and vice versa.
1110 (try_cursor_movement): Check continued rows, in addition to
1111 continuation rows. Fixes unwarranted scroll when point enters a
1112 continued line of R2L text within an L2R paragraph, or vice versa.
1113 (cursor_row_p): Consider the case of point being equal to
1114 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1115 from the end of a short line to the beginning of a continued line
1116 of R2L text within L2R paragraph.
1117 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1118 composed characters.
1119
1120 * bidi.c (bidi_check_type): Use xassert.
1121 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1122 members.
1123
1124 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1125
1126 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1127 a character.
1128
1129 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1130
1131 * nsfont.m (ns_otf_to_script): Fix typo.
1132
1133 2011-08-22 Kenichi Handa <handa@m17n.org>
1134
1135 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1136 extra slot even if the purpose is char-code-property-table.
1137
1138 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1139
1140 * xdisp.c (redisplay_window): When computing centering_position,
1141 account for the height of the header line. (Bug#8874)
1142
1143 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1144 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1145 candidate is selected by the mouse, and that candidate has a
1146 composed character under the mouse.
1147
1148 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1149 coordinates reported by pos-visible-in-window-p for a composed
1150 character in column zero.
1151
1152 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1153
1154 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1155
1156 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1157
1158 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1159 consider it a hit if to_charpos is anywhere in the range of the
1160 composed buffer positions.
1161
1162 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1163
1164 * image.c (gif_load): Don't assume that each subimage has the same
1165 dimensions as the base image. Handle disposal method that is
1166 "undefined" by the gif spec (Bug#9335).
1167
1168 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1169
1170 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1171 (Fcondition_case): Document `debug' symbol in error handler.
1172
1173 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1174
1175 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1176 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1177 from an Org mode buffer to a Speedbar frame.
1178
1179 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1180 a composition, take its buffer position from IT->cmp_it.charpos.
1181 Fixes cursor positioning at the beginning of a line that begins
1182 with a composed character.
1183
1184 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1185
1186 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1187 character bidirectional type, use STRONG_L instead. Fixes crashes
1188 in a buffer produced by `describe-categories'.
1189
1190 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1191 members before the level stack, so they would be saved and
1192 restored when copying iterator state. Fixes incorrect reordering
1193 around TABs covered by display properties.
1194
1195 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1196
1197 * process.c (Fnetwork_interface_list): Correctly determine buffer
1198 size.
1199
1200 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1201
1202 * eval.c (internal_condition_case, internal_condition_case_1)
1203 (internal_condition_case_2, internal_condition_case_n):
1204 Remove unnecessary aborts (Bug#9081).
1205
1206 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1207
1208 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1209 has no `load' handler, try opening the file locally. (Bug#9311)
1210
1211 2011-08-16 Ken Brown <kbrown@cornell.edu>
1212
1213 * gmalloc.c: Expand comment.
1214
1215 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1216
1217 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1218 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1219
1220 2011-08-16 Ken Brown <kbrown@cornell.edu>
1221
1222 Fix memory allocation problems in Cygwin build (Bug#9273).
1223
1224 * unexcw.c ( __malloc_initialized): Declare external variable.
1225 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1226
1227 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1228 New variables.
1229 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1230 dumped emacs.
1231 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1232 in the static heap.
1233 [CYGWIN] (special_realloc): New function.
1234 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1235 requests to realloc storage in the static heap.
1236
1237 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 * bidi.c (bidi_initialize): Remove unused local.
1240
1241 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1242
1243 * biditype.h: File removed.
1244
1245 * bidimirror.h: File removed.
1246
1247 * deps.mk (bidi.o): Remove biditype.h and
1248 bidimirror.h.
1249
1250 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1251 bidimirror.h.
1252
1253 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1254
1255 * chartab.c: Improve commentary for the uniprop_table API.
1256
1257 * bidi.c (bidi_paragraph_init): Support zero value of
1258 bidi_ignore_explicit_marks_for_paragraph_level.
1259 (bidi_initialize): Use uniprop_table instead of including
1260 biditype.h and bidimirror.h.
1261
1262 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1263 coordinates of the iterator when restoring from ppos_it.
1264 (Bug#9296)
1265
1266 2011-08-14 Kenichi Handa <handa@m17n.org>
1267
1268 * process.c (create_process): Call setup_process_coding_systems
1269 after the pid of the process is set to -1 (Bug#8162).
1270
1271 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1272
1273 * xdisp.c (move_it_in_display_line_to): Don't invoke
1274 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1275 ppos_it. Fixes vertical cursor motion when line beginning is
1276 covered by an image. (Bug#9296)
1277
1278 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1279
1280 * nsterm.h (ns_run_ascript): Declare.
1281 (NSAPP_DATA2_RUNASSCRIPT): Define.
1282
1283 * nsfns.m (as_script, as_result, as_status): New static variables.
1284 (ns_run_ascript): New function.
1285 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1286 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1287 the event loop. Get status from as_status (Bug#7276).
1288
1289 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1290 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1291 the event loop (Bug#7276).
1292
1293 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1294
1295 * gnutls.c (QCgnutls_bootprop_priority)
1296 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1297 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1298 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1299 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1300 (QCgnutls_bootprop_verify_hostname_error)
1301 (QCgnutls_bootprop_callbacks_verify): Rename from
1302 Qgnutls_bootprop_..., all uses changed.
1303
1304 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1305 uses changed.
1306
1307 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1308
1309 * xfaces.c (Qframe_set_background_mode): Now static.
1310 * dispextern.h (Qframe_set_background_mode): Remove decl.
1311
1312 * process.c (Fnetwork_interface_info): Declare local only if needed.
1313
1314 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1315
1316 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1317 (Fnetwork_interface_list): Allocate in increments of bytes instead
1318 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1319 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1320 sockaddr.
1321 (struct ifflag_def): notrailers is smart on OSX.
1322 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1323 Get hardware address with getifaddrs if available.
1324
1325 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1326
1327 * xdisp.c (iterate_out_of_display_property): xassert that
1328 IT->position is set to within IT->object's boundaries. Break from
1329 the loop as soon as EOB is reached; avoids infloops in redisplay
1330 when IT->position is set up wrongly due to some bug.
1331 Set IT->current to match the bidi iterator unconditionally.
1332 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1333 entry. Force push_it to save on the stack the current
1334 buffer/string position, to be restored by pop_it. Fix flags in
1335 the iterator structure wrt the object coming from a display
1336 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1337 properties. (Bug#9284)
1338
1339 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1340
1341 * fontset.c (fontset_get_font_group): Add proper type checks.
1342 (Bug#9172)
1343
1344 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1345
1346 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1347 and LC_VERSION_MIN_MACOSX.
1348 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1349 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1350
1351 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1352
1353 * xdisp.c (forward_to_next_line_start): Allow to use the
1354 no-display-properties-and-no-overlays under bidi display.
1355 Set disp_pos in the bidi iterator to avoid searches for display
1356 properties and overlays.
1357
1358 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1359
1360 * editfns.c (Fset_time_zone_rule): Document relationship with the
1361 setenv function.
1362
1363 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1364 the font entity extracted from the cache (Bug#8109).
1365
1366 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1367
1368 * composite.c (autocmp_chars): Don't reset point. That is done by
1369 restore_point_unwind (Bug#5984).
1370
1371 2011-08-07 Juri Linkov <juri@jurta.org>
1372
1373 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1374 to show the arg `TIME' instead of `TIMEVAL'.
1375
1376 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1377
1378 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1379 display property strides EOL and includes a newline, as in
1380 longlines-mode. (Bug#9254)
1381 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1382 word-wrap under bidirectional display. (Bug#9224)
1383
1384 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1385 is non-zero, even if the data buffer is NULL. Fixes a crash in
1386 vertical-motion with longlines-mode. (Bug#9254)
1387
1388 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1389
1390 * bidi.c <bidi_cache_total_alloc>: Now static.
1391 (bidi_initialize): Initialize bidi_cache_total_alloc.
1392
1393 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1394 cache. (Bug#9221)
1395
1396 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1397 amount allocated this far in `bidi_cache_total_alloc'.
1398 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1399 non-zero, only free the data buffer without restoring the cache
1400 contents. All callers changed.
1401
1402 * dispextern.h (bidi_unshelve_cache): Update prototype.
1403
1404 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1405 (move_it_in_display_line, move_it_to)
1406 (move_it_vertically_backward, move_it_by_lines): Replace the call
1407 to xfree to an equivalent call to bidi_unshelve_cache.
1408 (move_it_in_display_line_to): Fix logic of returning
1409 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1410
1411 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1412
1413 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1414 came from a string character with a `cursor' property. (Bug#9229)
1415
1416 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1417
1418 * Makefile.in (LIB_PTHREAD): New variable.
1419 (LIBES): Add LIB_PTHREAD (Bug#9216).
1420
1421 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1422 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1423
1424 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1425
1426 * regex.c (re_iswctype): Remove some redundant boolean
1427 conversions.
1428
1429 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1430
1431 * xterm.c (x_find_topmost_parent): New function.
1432 (x_set_frame_alpha): Find topmost parent window with
1433 x_find_topmost_parent and set the property there also (bug#9181).
1434 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1435
1436 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 * callproc.c (Fcall_process): Avoid vfork clobbering
1439 the local vars buffer, coding_systems, current_dir.
1440
1441 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1442
1443 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1444
1445 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1448 so that it is not optimized away.
1449
1450 * xdisp.c (compute_display_string_pos): Remove unused local.
1451
1452 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1453
1454 Fix slow cursor motion and scrolling in large buffers with
1455 selective display, like Org Mode buffers. (Bug#9218)
1456
1457 * dispextern.h (struct bidi_it): New member disp_prop_p.
1458
1459 * xdisp.c: Remove one-slot cache of display string positions.
1460 (compute_display_string_pos): Accept an additional argument
1461 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1462 for a display string or property. If found, set DISP_PROP_P
1463 non-zero.
1464
1465 * bidi.c (bidi_fetch_char): Accept an additional argument
1466 DISP_PROP_P, and pass it to compute_display_string_pos.
1467 Only handle text covered by a display string if DISP_PROP_P is returned
1468 non-zero. All callers of bidi_fetch_char changed.
1469
1470 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1471
1472 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1473
1474 2010-12-03 Don March <don@ohspite.net>
1475
1476 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1477 last character M-[char] is translated to ESC [char] (bug#7541).
1478
1479 2011-08-02 Kenichi Handa <handa@m17n.org>
1480
1481 * lisp.h (uniprop_table): Extern it.
1482
1483 * chartab.c (uniprop_table): Make it non-static.
1484
1485 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1486
1487 * xdisp.c (forward_to_next_line_start): Accept additional argument
1488 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1489 on the newline.
1490 (reseat_at_next_visible_line_start): Use the bidi iterator state
1491 returned by forward_to_next_line_start to restore the state of
1492 it->bidi_it after backing up to previous newline. (Bug#9212)
1493
1494 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1495
1496 * regex.c (re_comp): Protoize.
1497 (re_exec): Fix return type.
1498 (regexec): Fix type of `ret'. (Bug#9203)
1499
1500 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1501
1502 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1503 This is needed if max-image-size is a floating-point number.
1504
1505 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1506
1507 * print.c (print_object): Print empty symbol as ##.
1508
1509 * lread.c (read1): Read ## as empty symbol.
1510
1511 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1512
1513 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1514 setting frame foreground color (Bug#9175).
1515 (x_set_background_color): Likewise.
1516
1517 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1518 contents (Bug#9176).
1519 (EmacsTooltip -init): Remove bezels and add shadows to
1520 tooltip windows.
1521
1522 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1523 or scroll bar (Bug#8470).
1524
1525 * nsfont.m (nsfont_open): Remove assignment to voffset and
1526 unnecessary vars hshink, expand, hd, full_height, min_height.
1527 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1528
1529 * nsterm.h (nsfont_info): Remove voffset field.
1530
1531 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1532
1533 Implement strike-through and overline on NextStep (Bug#8863).
1534
1535 * nsfont.m (nsfont_open): Use underline position provided by font,
1536 instead of hard-coded value of 2.
1537 (nsfont_draw): Call ns_draw_text_decoration instead.
1538
1539 * nsterm.h: Add declaration for ns_draw_text_decoration.
1540
1541 * nsterm.m (ns_draw_text_decoration): New function for drawing
1542 underline, overline, and strike-through.
1543 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1544 ns_draw_text_decoration. Change treatment of cursor drawing to
1545 accommodate underlining, etc.
1546
1547 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1548
1549 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1550 default.
1551
1552 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1555 Without this fix, if a signal arrives just after memory fills up,
1556 'malloc' might be invoked reentrantly.
1557
1558 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1559 In other words, assume that every image size is allowed, on non-X
1560 hosts. This assumption is probably wrong, but it lets Emacs compile.
1561
1562 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1563
1564 * regex.c (re_iswctype): Convert return values to boolean.
1565
1566 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1567
1568 * xdisp.c (compute_display_string_pos): Don't use cached display
1569 string position if the buffer had its restriction changed.
1570 (Bug#9184)
1571
1572 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1573
1574 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1575
1576 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 Integer signedness and overflow and related fixes. (Bug#9079)
1579
1580 * bidi.c: Integer size and overflow fixes.
1581 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1582 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1583 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1584 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1585 (bidi_find_other_level_edge):
1586 Use ptrdiff_t instead of EMACS_INT where either will do.
1587 This works better on 32-bit hosts configured --with-wide-int.
1588 (bidi_cache_ensure_space): Check for size-calculation overflow.
1589 Use % rather than repeated addition, for better worst-case speed.
1590 Don't set bidi_cache_size until after xrealloc returns, because it
1591 might not return.
1592 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1593 (bidi_cache_ensure_space): Also check that the bidi cache size
1594 does not exceed that of the largest Lisp string or buffer. See Eli
1595 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1596
1597 * alloc.c (__malloc_size_t): Remove.
1598 All uses replaced by size_t. See Andreas Schwab's note
1599 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1600
1601 * image.c: Improve checking for integer overflow.
1602 (check_image_size): Assume that f is nonnull, since
1603 it is always nonnull in practice. This is one less thing to
1604 worry about when checking for integer overflow later.
1605 (x_check_image_size): New function, which checks for integer
1606 overflow issues inside X.
1607 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1608 This removes the need for a memory_full check.
1609 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1610 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1611 (xbm_read_bitmap_data): Change locals back to 'int', since
1612 their values must fit in 'int'.
1613 (xpm_load_image, png_load, tiff_load):
1614 Invoke x_create_x_image_and_pixmap earlier,
1615 to avoid much needless work if the image is too large.
1616 (tiff_load): Treat overly large images as if
1617 x_create_x_image_and_pixmap failed, not as malloc failures.
1618 (gs_load): Use x_check_image_size.
1619
1620 * gtkutil.c: Omit integer casts.
1621 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1622 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1623
1624 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1625
1626 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1627 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1628 would wrongly return t on a 64-bit host.
1629
1630 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1631 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1632 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1633 and therefore cause GCC to emit a bogus diagnostic in some cases.
1634
1635 * image.c: Integer signedness and overflow and related fixes.
1636 This is not an exhaustive set of fixes, but it's time to
1637 record what I've got.
1638 (lookup_pixel_color, check_image_size): Remove redundant decls.
1639 (check_image_size): Don't assume that arbitrary EMACS_INT values
1640 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1641 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1642 (tiff_load, imagemagick_load_image):
1643 Check for overflow in size calculations.
1644 (x_create_x_image_and_pixmap): Remove unnecessary test for
1645 xmalloc returning NULL; that can't happen.
1646 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1647 (xpm_color_bucket): Use better integer hashing function.
1648 (xpm_cache_color): Don't possibly over-allocate memory.
1649 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1650 (gif_memory_source):
1651 Use ptrdiff_t, not int or size_t, to record sizes.
1652 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1653 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1654 either works, as we prefer signed integers.
1655 (tiff_read_from_memory, tiff_write_from_memory):
1656 Return tsize_t, not size_t, since that's what the TIFF API wants.
1657 (tiff_read_from_memory): Don't fail simply because the read would
1658 go past EOF; instead, return a short read.
1659 (tiff_load): Omit no-longer-needed casts.
1660 (Fimagemagick_types): Don't assume size fits into 'int'.
1661
1662 Improve hashing quality when configured --with-wide-int.
1663 * fns.c (hash_string): New function, taken from sxhash_string.
1664 Do not discard information about ASCII character case; this
1665 discarding is no longer needed.
1666 (sxhash-string): Use it. Change sig to match it. Caller changed.
1667 * lisp.h: Declare it.
1668 * lread.c (hash_string): Remove, since we now use fns.c's version.
1669 The fns.c version returns a wider integer if --with-wide-int is
1670 specified, so this should help the quality of the hashing a bit.
1671
1672 * emacs.c: Integer overflow minor fix.
1673 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1674 Define only if GNU_LINUX.
1675 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1676
1677 * dispnew.c: Integer signedness and overflow fixes.
1678 Remove unnecessary forward decls, that were a maintenance hassle.
1679 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1680 All uses changed.
1681 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1682 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1683 (prepare_desired_row, line_draw_cost):
1684 Use int, not unsigned, where either works.
1685 (save_current_matrix, restore_current_matrix):
1686 Use ptrdiff_t, not size_t, where either works.
1687 (init_display): Check for overflow more accurately, and without
1688 relying on undefined behavior.
1689
1690 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1691 Remove, replacing with the new symbols in lisp.h. All uses changed.
1692 * fileio.c (make_temp_name):
1693 * filelock.c (lock_file_1, lock_file):
1694 * xdisp.c (message_dolog):
1695 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1696 Use pMd etc. instead.
1697 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1698 replacing the pWIDE etc. symbols removed from editfns.c.
1699
1700 * keyboard.h (num_input_events): Now uintmax_t.
1701 This is (very slightly) less likely to mess up due to wraparound.
1702 All uses changed.
1703
1704 * buffer.c: Integer signedness fixes.
1705 (alloc_buffer_text, enlarge_buffer_text):
1706 Use ptrdiff_t rather than size_t when either will do, as we prefer
1707 signed integers.
1708
1709 * alloc.c: Integer signedness and overflow fixes.
1710 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1711 (__malloc_size_t): Default to size_t, not to int.
1712 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1713 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1714 Prefer ptrdiff_t to size_t when either would do, as we prefer
1715 signed integers.
1716 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1717 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1718 Now const. Initialize with values that are in range even if char
1719 is signed.
1720 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1721 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1722 These functions do the right thing with sizes > 2**32.
1723 (check_depth): Now ptrdiff_t, not int.
1724 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1725 Adjust to new way of storing sizes. Check for size overflow bugs
1726 in rest of code.
1727 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1728 slightly wrong anyway, as it missed one instance of
1729 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1730 (refill_memory_reserve): Omit needless cast to size_t.
1731 (mark_object_loop_halt): Mark as externally visible.
1732
1733 * xselect.c: Integer signedness and overflow fixes.
1734 (Fx_register_dnd_atom, x_handle_dnd_message):
1735 Use ptrdiff_t, not size_t, since we prefer signed.
1736 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1737 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1738 x_dnd_atoms_size and x_dnd_atoms_length.
1739
1740 * doprnt.c: Prefer signed to unsigned when either works.
1741 * eval.c (verror):
1742 * doprnt.c (doprnt):
1743 * lisp.h (doprnt):
1744 * xdisp.c (vmessage):
1745 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1746 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1747 prefer signed arithmetic to avoid comparison confusion.
1748 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1749 but is a bit tricky.
1750
1751 Assume freestanding C89 headers, string.h, stdlib.h.
1752 * data.c, doprnt.c, floatfns.c, print.c:
1753 Include float.h unconditionally.
1754 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1755 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1756 * regex.c: Likewise for stddef.h, string.h.
1757 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1758 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1759 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1760 (STDC_HEADERS): Remove obsolete defines.
1761 * sysdep.c: Include limits.h unconditionally.
1762
1763 Assume support for memcmp, memcpy, memmove, memset.
1764 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1765 * regex.c (memcmp, memcpy):
1766 Remove; we assume C89 now.
1767
1768 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1769 (__malloc_safe_bcopy): Remove; no longer needed.
1770
1771 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1772 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1773 well either way, and we prefer signed to unsigned.
1774
1775 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1776
1777 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1778 closes the connection while we're reading (bug#9182).
1779
1780 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1781
1782 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1783 are specified (Bug#9168).
1784
1785 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1788 Found by GCC static checking and --with-wide-int on a 32-bit host.
1789
1790 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1791
1792 * xdisp.c (compute_display_string_pos): Fix logic of caching
1793 previous display string position. Initialize cached_prev_pos to
1794 -1. Fixes slow-down at the beginning of a buffer.
1795
1796 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1797
1798 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1799 for attrs[LFACE_FONTSET_INDEX].
1800
1801 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1802
1803 * xml.c (parse_region): Remove unused local
1804 that was recently introduced.
1805
1806 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1807
1808 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1809 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1810
1811 * xdisp.c (move_it_in_display_line_to): Record the best matching
1812 position for TO_CHARPOS while scanning the line, and restore it on
1813 exit if none of the characters scanned was an exact match.
1814 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1815 when exact match is impossible due to invisible text, and the
1816 lines are truncated.
1817
1818 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1819
1820 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1821 for OSX >= 10.7.
1822
1823 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1824
1825 Fix a significant slow-down of cursor motion with C-n, C-p,
1826 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1827 auto-repeat under bidi redisplay in fontified buffers.
1828 * xdisp.c (compute_stop_pos_backwards): New function.
1829 (next_element_from_buffer): Call compute_stop_pos_backwards to
1830 find a suitable prev_stop when we find ourselves before
1831 base_level_stop.
1832 (reseat): Don't look for prev_stop, as that could mean a very long
1833 run.
1834 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1835 <cached_disp_overlay_modiff>: Cache for last found display string
1836 position.
1837 (compute_display_string_pos): Return the cached position if asked
1838 about the same buffer in the same area of character positions, and
1839 the buffer wasn't changed since the time the display string
1840 position was cached.
1841
1842 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1843
1844 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1845 is an integer, which is important for empty lines. (Bug#9149)
1846
1847 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1848
1849 * frame.c (Fmodify_frame_parameters): In tty case, update the
1850 default face if necessary (Bug#4238).
1851
1852 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1853
1854 * editfns.c (Fstring_to_char): No need to explain what a character
1855 is in the docstring (Bug#6576).
1856
1857 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1858
1859 * xml.c (parse_region): Make sure we always return a tree.
1860
1861 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1862
1863 * xml.c (parse_region): If a document contains only comments,
1864 return that, too.
1865
1866 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1867
1868 * xml.c (make_dom): Return comments, too.
1869
1870 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 Port to OpenBSD.
1873 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1874 and the surrounding thread.
1875 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1876 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1877 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1878 timer goes off.
1879 * s/openbsd.h (BROKEN_SIGIO): Define.
1880 * unexelf.c (unexec) [__OpenBSD__]:
1881 Don't update the .mdebug section of the Alpha COFF symbol table.
1882
1883 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1884
1885 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1886 (bug#8460).
1887
1888 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1891 This fixes some race conditions on the permissions of any newly
1892 created file.
1893
1894 * alloc.c (valid_pointer_p): Use pipe, not open.
1895 This fixes some permissions issues when debugging.
1896
1897 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1898 If fchown fails to set both uid and gid, try to set just gid,
1899 as that is sometimes allowed. Adjust the file's mode to eliminate
1900 setuid or setgid bits that are inappropriate if fchown fails.
1901
1902 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1903
1904 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1905 to compare Lisp_Objects.
1906 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1907 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1908 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1909
1910 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1911
1912 * lread.c (read_integer): Unread even EOF character.
1913 (read1): Likewise. Properly record start position of symbol.
1914
1915 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1916 symbol character follows.
1917
1918 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1919
1920 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1921 This works around a problem with the previous change to Fcopy_file.
1922 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1923 and without this change, GCC might complain about discarding
1924 fchown's return value.
1925
1926 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1927
1928 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1929
1930 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1931
1932 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1933
1934 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1935
1936 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1937 it's used from the C level.
1938
1939 * process.c: Use the same condition for POLL_FOR_INPUT in both
1940 keyboard.c and process.c (bug#1858).
1941
1942 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1943
1944 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1945 (Fgnutls_boot): Use it.
1946
1947 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1948
1949 * doc.c (Fsubstitute_command_keys): Revert last change.
1950
1951 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1952
1953 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1954 quotes the next character, and doesn't affect other longer
1955 sequences (bug#8935).
1956
1957 * lread.c (syms_of_lread): Clarify that is isn't only
1958 `eval-buffer' and `eval-defun' that's affected by
1959 `lexical-binding' (bug#8460).
1960
1961 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1962
1963 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1964 bidi redisplay when a line includes both an image and is
1965 truncated.
1966
1967 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1968
1969 Fix minor problems found by static checking.
1970 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1971 (elsz): Now a signed constant, not a size_t var. We prefer signed
1972 types to unsigned, to avoid integer comparison confusion. Without
1973 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1974 "cannot optimize loop, the loop counter may overflow", a symptom
1975 of the confusion.
1976 * indent.c (Fvertical_motion): Mark locals as initialized.
1977 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1978
1979 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1980
1981 * search.c (Fre_search_backward): Mention `case-fold-search' in
1982 all the re_search_* functions (bug#8138).
1983
1984 * keyboard.c (Fopen_dribble_file): Document when the file is
1985 closed (bug#8056).
1986
1987 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1988
1989 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1990 bidi_cache_idx.
1991
1992 Support bidi reordering of display and overlay strings.
1993 * xdisp.c (compute_display_string_pos)
1994 (compute_display_string_end): Accept additional argument STRING.
1995 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1996 (reseat_to_string): Initialize bidi_it->string.s and
1997 bidi_it->string.schars.
1998 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1999 NULL (avoids a crash in bidi_paragraph_init).
2000 Initialize itb.string.lstring.
2001 (init_iterator): Call bidi_init_it only of a valid
2002 buffer position was specified. Initialize paragraph_embedding to
2003 L2R.
2004 (reseat_to_string): Initialize the bidi iterator.
2005 (display_string): If we need to ignore text properties of
2006 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2007 original value of -1 will not work with bidi.)
2008 (compute_display_string_pos): First arg is now struct
2009 `text_pos *'; all callers changed. Support display properties on
2010 Lisp strings.
2011 (compute_display_string_end): Support display properties on Lisp
2012 strings.
2013 (init_iterator, reseat_1, reseat_to_string): Initialize the
2014 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2015 when iterating on a string not from display properties).
2016 (compute_display_string_pos, compute_display_string_end):
2017 Fix calculation of the object to scan. Fixes an error when using
2018 arrow keys.
2019 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2020 base_level_stop; instead, set base_level_stop to BEGV.
2021 Fixes crashes in vertical-motion.
2022 (next_element_from_buffer): Improve commentary for when
2023 the iterator is before prev_stop.
2024 (init_iterator): Initialize bidi_p from the default value of
2025 bidi-display-reordering, not from buffer-local value. Use the
2026 buffer-local value only if initializing for buffer iteration.
2027 (handle_invisible_prop): Support invisible properties on strings
2028 that are being bidi-reordered.
2029 (set_iterator_to_next): Support bidi reordering of C strings and
2030 Lisp strings.
2031 (next_element_from_string): Support bidi reordering of Lisp
2032 strings.
2033 (handle_stop_backwards): Support Lisp strings as well.
2034 (display_string): Support display of R2L glyph rows.
2035 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2036 (init_iterator): Don't initialize it->bidi_p for strings
2037 here.
2038 (reseat_to_string): Initialize it->bidi_p for strings here.
2039 (next_element_from_string, next_element_from_c_string)
2040 (next_element_from_buffer): Add xassert's for correspondence
2041 between IT's object being iterated and it->bidi_it.string
2042 structure.
2043 (face_before_or_after_it_pos): Support bidi iteration.
2044 (next_element_from_c_string): Handle the case of the first string
2045 character that is not the first one in the visual order.
2046 (get_visually_first_element): New function, refactored from common
2047 parts of next_element_from_buffer, next_element_from_string, and
2048 next_element_from_c_string.
2049 (tool_bar_lines_needed, redisplay_tool_bar)
2050 (display_menu_bar): Force left-to-right direction. Add a FIXME
2051 comment for making that be controlled by a user option.
2052 (push_it, pop_it): Save and restore the state of the
2053 bidi iterator. Save and restore the bidi_p flag.
2054 (pop_it): Iterate out of display property for string iteration as
2055 well.
2056 (iterate_out_of_display_property): Support iteration over strings.
2057 (handle_single_display_spec): Set up it->bidi_it for iteration
2058 over a display string, and call bidi_init_it.
2059 (handle_single_display_spec, next_overlay_string)
2060 (get_overlay_strings_1, push_display_prop): Set up the bidi
2061 iterator for displaying display or overlay strings.
2062 (forward_to_next_line_start): Don't use the shortcut if
2063 bidi-iterating.
2064 (back_to_previous_visible_line_start): If handle_display_prop
2065 pushed the iterator stack, restore the internal state of the bidi
2066 iterator by calling bidi_pop_it same number of times.
2067 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2068 and we are bidi-iterating, don't decrement the iterator position;
2069 instead, set the first_elt flag in the bidi iterator, to produce
2070 the same effect.
2071 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2072 (push_display_prop): xassert that we are iterating a buffer.
2073 (push_it, pop_it): Save and restore paragraph_embedding member.
2074 (handle_single_display_spec, next_overlay_string)
2075 (get_overlay_strings_1, reseat_1, reseat_to_string)
2076 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2077 correctly. Don't assume unibyte strings are not bidi-reordered.
2078 (compute_display_string_pos)
2079 (compute_display_string_end): Fix handling the case of C string.
2080 (push_it, pop_it): Save and restore from_disp_prop_p.
2081 (handle_single_display_spec, push_display_prop): Set the
2082 from_disp_prop_p flag.
2083 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2084 (pop_it): Call iterate_out_of_display_property only if we are
2085 popping after iteration over a string that came from a display
2086 property. Fix a typo in popping stretch info. Add an assertion
2087 for verifying that the iterator position is in sync with the bidi
2088 iterator.
2089 (handle_single_display_spec, get_overlay_strings_1)
2090 (push_display_prop): Fix initialization of paragraph direction for
2091 string when that of the parent object is not yet determined.
2092 (reseat_1): Call bidi_init_it to resync the bidi
2093 iterator with IT's position. (Bug#7616)
2094 (find_row_edges): If ROW->start.pos gives position
2095 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2096 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2097 Reset the from_disp_prop_p flag.
2098 (SAVE_IT, RESTORE_IT): New macros.
2099 (pos_visible_p, face_before_or_after_it_pos)
2100 (back_to_previous_visible_line_start)
2101 (move_it_in_display_line_to, move_it_in_display_line)
2102 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2103 (try_scrolling, redisplay_window, display_line): Use them when
2104 saving a temporary copy of the iterator and restoring it back.
2105 (back_to_previous_visible_line_start, reseat_1)
2106 (init_iterator): Empty the bidi cache "stack".
2107 (move_it_in_display_line_to): If iterator ended up at
2108 EOL, but we never saw any buffer positions smaller than
2109 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2110 motion in bidi-reordered lines.
2111 (move_it_in_display_line_to): Record prev_method and prev_pos
2112 immediately before the call to set_iterator_to_next. Fixes cursor
2113 motion in bidi-reordered lines with stretch glyphs and strings
2114 displayed in margins. (Bug#8133) (Bug#8867)
2115 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2116 TO_CHARPOS.
2117 (pos_visible_p): Support positions in bidi-reordered lines.
2118 Save and restore bidi cache.
2119
2120 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2121 (bidi_paragraph_info): Delete unused struct.
2122 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2123 (bidi_cache_start): New variable.
2124 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2125 to zero.
2126 (bidi_cache_fetch_state, bidi_cache_search)
2127 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2128 (bidi_cache_find, bidi_peek_at_next_level)
2129 (bidi_level_of_next_char, bidi_find_other_level_edge)
2130 (bidi_move_to_visually_next): Compare cache index with
2131 bidi_cache_start rather than with zero.
2132 (bidi_fetch_char): Accept new argument STRING; all callers
2133 changed. Support iteration over a string. Support strings with
2134 display properties. Support unibyte strings. Fix the type of
2135 `len' according to what STRING_CHAR_AND_LENGTH expects.
2136 (bidi_paragraph_init, bidi_resolve_explicit_1)
2137 (bidi_resolve_explicit, bidi_resolve_weak)
2138 (bidi_level_of_next_char, bidi_move_to_visually_next):
2139 Support iteration over a string.
2140 (bidi_set_sor_type, bidi_resolve_explicit_1)
2141 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2142 can now be zero (for strings); special values 0 and -1 were
2143 changed to -1 and -2, respectively.
2144 (bidi_char_at_pos): New function.
2145 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2146 Call it instead of FETCH_MULTIBYTE_CHAR.
2147 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2148 initialized to valid values.
2149 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2150 values.
2151 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2152 the test for valid cached positions. Fix the logic for looking up
2153 the sentinel state in the cache. GCPRO the Lisp string we are
2154 iterating.
2155 (bidi_push_it, bidi_pop_it): New functions.
2156 (bidi_initialize): Initialize the bidi cache start stack pointer.
2157 (bidi_cache_ensure_space): New function, refactored from part of
2158 bidi_cache_iterator_state. Don't assume the required size is just
2159 one BIDI_CACHE_CHUNK away.
2160 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2161 (bidi_count_bytes, bidi_char_at_pos): New functions.
2162 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2163 always valid if bidi_cache_idx is valid.
2164 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2165 is valid if it's going to be used.
2166 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2167 (bidi_cache_fetch_state, bidi_cache_search)
2168 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2169 (bidi_cache_iterator_state, bidi_cache_find)
2170 (bidi_find_other_level_edge, bidi_cache_start_stack):
2171 All variables related to cache indices are now EMACS_INT.
2172
2173 * dispextern.h (struct bidi_string_data): New structure.
2174 (struct bidi_it): New member `string'. Make flag members be 1-bit
2175 fields, and put them last in the struct.
2176 (compute_display_string_pos, compute_display_string_end):
2177 Update prototypes.
2178 (bidi_push_it, bidi_pop_it): Add prototypes.
2179 (struct iterator_stack_entry): New members bidi_p,
2180 paragraph_embedding, and from_disp_prop_p.
2181 (struct it): Member bidi_p is now a bit field 1 bit wide.
2182 (bidi_shelve_cache, bidi_unshelve_cache):
2183 Declare prototypes.
2184
2185 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2186 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2187 and vector-like objects.
2188
2189 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2190 cache around display iteration.
2191
2192 * window.c (Fwindow_end, window_scroll_pixel_based)
2193 (displayed_window_lines, Frecenter): Save and restore the bidi
2194 cache around display iteration.
2195
2196 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2197
2198 * editfns.c (Fdelete_region): Clarify the use of the named
2199 parameters (bug#6788).
2200
2201 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2202
2203 * indent.c (Fvertical_motion): Set and restore w->pointm when
2204 saving and restoring the window's buffer (Bug#9006).
2205
2206 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2207
2208 * editfns.c (Fstring_to_char): Clarify just what is returned
2209 (bug#6576). Text by Eli Zaretskii.
2210
2211 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2212
2213 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2214
2215 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2216
2217 * buffer.c (mmap_find): Fix a typo.
2218
2219 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2220
2221 Fix execution of x selection hooks.
2222 * xselect.c (Qx_lost_selection_functions)
2223 (Qx_sent_selection_functions): New vars.
2224 (syms_of_xselect): DEFSYM them.
2225 (x_handle_selection_request): Pass Qx_sent_selection_functions
2226 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2227 (x_handle_selection_clear,x_clear_frame_selections):
2228 Pass Qx_lost_selection_functions rather than
2229 Vx_lost_selection_functions to Frun_hook_with_args.
2230
2231 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2234 The old code sometimes used this field without initializing it.
2235
2236 * alloc.c (gc_sweep): Don't read past end of array.
2237 In theory, the old code could also have corrupted Emacs internals,
2238 though it'd be very unlikely.
2239
2240 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2241
2242 * character.c (Fcharacterp): Don't advertise optional ignored
2243 argument. (Bug#4026)
2244
2245 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2246
2247 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2248 key" (bug#4257).
2249
2250 * window.c (Fset_window_start): Doc fix (bug#4199).
2251 (Fset_window_hscroll): Ditto.
2252
2253 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 Fix minor new problems caught by GCC 4.6.1.
2256 * term.c (init_tty): Remove unused local.
2257 * xsettings.c (store_monospaced_changed): Define this function only
2258 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2259 not used otherwise.
2260
2261 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2262
2263 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2264
2265 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2266
2267 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2268 are the mini-buffer and the echo area (bug#3320).
2269
2270 * term.c (init_tty): Remove support for supdup, c10 and perq
2271 terminals, which are no longer supported (bug#1482).
2272
2273 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2274
2275 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2276
2277 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2278
2279 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2280 for non-popups (Bug#3642).
2281
2282 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2283
2284 * alloc.c (reset_malloc_hooks): Protoize.
2285 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2286 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2287 * cm.c (losecursor): Likewise.
2288 * data.c (fmod): Likewise.
2289 * dispnew.c (swap_glyphs_in_rows): Likewise.
2290 * emacs.c (memory_warning_signal): Likewise.
2291 * floatfns.c (float_error): Likewise.
2292 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2293 (otf_open, font_otf_capability, generate_otf_features)
2294 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2295 Likewise.
2296 * image.c (pbm_read_file): Likewise.
2297 * indent.c (string_display_width): Likewise.
2298 * intervals.c (check_for_interval, search_for_interval)
2299 (inc_interval_count, count_intervals, root_interval)
2300 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2301 * lread.c (defalias): Likewise.
2302 * ralloc.c (r_alloc_check): Likewise.
2303 * regex.c (set_image_of_range_1, set_image_of_range)
2304 (regex_grow_registers): Likewise.
2305 * sysdep.c (strerror): Likewise.
2306 * termcap.c (valid_filename_p, tprint, main): Likewise.
2307 * tparam.c (main): Likewise.
2308 * unexhp9k800.c (run_time_remap, save_data_space)
2309 (update_file_ptrs, read_header, write_header, calculate_checksum)
2310 (copy_file, copy_rest, display_header): Likewise.
2311 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2312 Likewise.
2313 * xdisp.c (check_it): Likewise.
2314 * xfaces.c (register_color, unregister_color, unregister_colors):
2315 Likewise.
2316 * xfns.c (print_fontset_result): Likewise.
2317 * xrdb.c (member, fatal, main): Likewise.
2318
2319 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 Fix minor problems found by static checking (Bug#9031).
2322 * chartab.c (char_table_set_range, map_sub_char_table):
2323 Remove unused locals.
2324 (uniprop_table): Now static.
2325 * composite.c (_work_char): Remove unused static var.
2326
2327 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2328
2329 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2330
2331 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2332
2333 * gtkutil.c (qttip_cb): Remove code without function.
2334
2335 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2336
2337 * w32.c (pthread_sigmask): New stub.
2338
2339 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2340
2341 Use pthread_sigmask, not sigprocmask (Bug#9010).
2342 sigprocmask is portable only for single-threaded applications, and
2343 Emacs can be multi-threaded when it uses GTK.
2344 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2345 (LIBES): Use it.
2346 * callproc.c (Fcall_process):
2347 * process.c (create_process):
2348 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2349 Use pthread_sigmask, not sigprocmask.
2350
2351 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2352
2353 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2354 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2355 wrong (Bug#8591).
2356
2357 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2358
2359 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2360 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2361 (xg_hide_tooltip): Fix comment.
2362
2363 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2364 in registerServicesMenuSendTypes.
2365 (validRequestorForSendType): Don't check ns_return_types.
2366
2367 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2368 ns_return_type.
2369
2370 2011-07-08 Jason Rumney <jasonr@gnu.org>
2371
2372 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2373 frame struct members of non-existent frames (Bug#6284).
2374
2375 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2376
2377 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2378 variable firstTime not needed on OSX >= 10.6.
2379 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2380 >= 10.5. Use setKnobProportion, setDoubleValue.
2381
2382 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2383 (MAC_OS_X_VERSION_10_5): Define if not defined.
2384 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2385 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2386 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2387
2388 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2389 cString and lossyCString on OSX >= 10.4
2390
2391 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2392 sizeToFit on OSX >= 10.2.
2393
2394 * nsimage.m (allocInitFromFile): Don't use deprecated method
2395 bestRepresentationForDevice on OSX >= 10.6.
2396
2397 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2398 to avoid warning.
2399
2400 * emacs.c: Declare unexec_init_emacs_zone.
2401
2402 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2403
2404 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2405
2406 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2407 on svcsMenu (Bug#8842).
2408
2409 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2410 ns_return_types.
2411 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2412
2413 * nsterm.m (QUTF8_STRING): Declare.
2414 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2415 (validRequestorForSendType): Return type is (id).
2416 Change indexOfObjectIdenticalTo to indexOfObject.
2417 Check if we have local selection before returning self (Bug#8842).
2418 (writeSelectionToPasteboard): Put local selection into paste board
2419 if we have a local selection (Bug#8842).
2420 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2421
2422 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2423 (ns_get_local_selection): Declare.
2424
2425 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2426
2427 * keymap.c (describe_map_tree): Don't insert a double newline at
2428 the end of the buffer (bug#1169) and return whether we inserted
2429 something.
2430
2431 * callint.c (Fcall_interactively): Change "reading args" to
2432 "providing args" to try to clarify what it does (bug#1010).
2433
2434 2011-07-07 Kenichi Handa <handa@m17n.org>
2435
2436 * composite.c (composition_compute_stop_pos): Ignore a static
2437 composition starting before CHARPOS (Bug#8915).
2438
2439 * xdisp.c (handle_composition_prop): Likewise.
2440
2441 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2442
2443 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2444 (Bug#9015)
2445
2446 2011-07-07 Kenichi Handa <handa@m17n.org>
2447
2448 * character.h (unicode_category_t): New enum type.
2449
2450 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2451 (Qchar_code_property_table): New variable.
2452 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2453 (UNIPROP_COMPRESSED_FORM_P): New macros.
2454 (char_table_ascii): Uncompress the compressed values.
2455 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2456 Uncompress the compressed values.
2457 (sub_char_table_ref_and_range): Likewise.
2458 (char_table_ref_and_range): Uncompress the compressed values.
2459 (sub_char_table_set): New arg is_uniprop. Callers changed.
2460 Uncompress the compressed values.
2461 (sub_char_table_set_range): Args changed. Callers changed.
2462 (char_table_set_range): Adjuted for the above change.
2463 (map_sub_char_table): Delete args default_val and parent. Add arg
2464 top. Give decoded values to a Lisp function.
2465 (map_char_table): Adjust for the above change. Give decoded
2466 values to a Lisp function. Gcpro more variables.
2467 (uniprop_table_uncompress)
2468 (uniprop_decode_value_run_length): New functions.
2469 (uniprop_decoder, uniprop_decoder_count): New variables.
2470 (uniprop_get_decoder, uniprop_encode_value_character)
2471 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2472 New functions.
2473 (uniprop_encoder, uniprop_encoder_count): New variables.
2474 (uniprop_get_encoder, uniprop_table)
2475 (Funicode_property_table_internal, Fget_unicode_property_internal)
2476 (Fput_unicode_property_internal): New functions.
2477 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2478 Sunicode_property_table_internal, Sget_unicode_property_internal,
2479 and Sput_unicode_property_internal. Defvar_lisp
2480 char-code-property-alist.
2481
2482 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2483 Vunicode_category_table.
2484
2485 * font.c (font_range): Adjust for the change of
2486 Vunicode_category_table.
2487
2488 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2489
2490 * m/iris4d.h: Remove file, move contents ...
2491 * s/irix6-5.h: ... here.
2492
2493 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2494
2495 Remove unportable assumption about struct layout (Bug#8884).
2496 * alloc.c (mark_buffer):
2497 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2498 (clone_per_buffer_values): Don't assume that
2499 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2500 This isn't true in general, and it's particularly not true
2501 if Emacs is configured with --with-wide-int.
2502 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2503 New macros, used in the buffer.c change.
2504
2505 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2506
2507 * xsettings.c: Use both GConf and GSettings if both are available.
2508 (store_config_changed_event): Add comment.
2509 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2510 (store_tool_bar_style_changed): New functions.
2511 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2512 (struct xsettings): Move font inside HAVE_XFT.
2513 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2514 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2515 Move inside HAVE_XFT.
2516 (something_changed_gsettingsCB): Rename from something_changedCB.
2517 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2518 also.
2519 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2520 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2521 (something_changed_gconfCB): Rename from something_changedCB.
2522 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2523 (parse_settings): Move check for font inside HAVE_XFT.
2524 (read_settings, apply_xft_settings): Add comment.
2525 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2526 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2527 call store_font_name_changed.
2528 (xft_settings_event): Add comment.
2529 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2530 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2531 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2532 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2533 (xsettings_initialize): Call init_gsettings last.
2534 (xsettings_get_system_font, xsettings_get_system_normal_font):
2535 Add comment.
2536
2537 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2538
2539 Random fixes. E.g., (random) never returned negative values.
2540 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2541 subseconds part to the entropy, as that's a bit more random.
2542 Prefer signed to unsigned, since the signedness doesn't matter and
2543 in general we prefer signed. When given a limit, use a
2544 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2545 latter isn't right if USE_2_TAGS_FOR_INTS.
2546 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2547 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2548
2549 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2550
2551 * textprop.c (text_property_stickiness):
2552 Obey Vtext_property_default_nonsticky.
2553 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2554 * w32fns.c (syms_of_w32fns):
2555 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2556
2557 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2560 This is more efficient than Ffile_directory_p and avoids a minor race.
2561
2562 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2563
2564 * buffer.c (Foverlay_put): Say what the return value is
2565 (bug#7835).
2566
2567 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2568 is a directory before asking whether to use the file name
2569 (bug#7564).
2570 (barf_or_query_if_file_exists): Make the "File is a directory"
2571 error be more correct.
2572
2573 * fns.c (Frequire): Remove the mention of the .gz files, since
2574 that's installation-specific, but keep the mention of
2575 `get-load-suffixes'.
2576
2577 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2578
2579 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2580 Report string overflow if the output is too long.
2581
2582 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2583
2584 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2585 (syms_of_gnutls): Remove duplicate DEFSYM for
2586 Qgnutls_bootprop_verify_hostname_error, an error for
2587 Qgnutls_bootprop_verify_error (which is no longer used).
2588
2589 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2590 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2591 Also (re)move comments that are misplaced or no longer relevant.
2592
2593 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2594
2595 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2596
2597 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2598
2599 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2600 and background color parameters if they have been changed.
2601
2602 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2603
2604 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2605
2606 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 * xsettings.c (SYSTEM_FONT): Define only when used.
2609 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2610
2611 * keymap.c (access_keymap_1): Now static.
2612
2613 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2614
2615 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2616 leave any prefix arg for the up event (Bug#1586).
2617
2618 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2619
2620 * lread.c (syms_of_lread): Mention single symbols defined by
2621 `defvar' or `defconst' (bug#7154).
2622
2623 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2624 (Frequire): Mention get-load-suffixes.
2625
2626 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2627
2628 * window.h (window): Remove clone_number slot.
2629 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2630 Remove.
2631 (make_parent_window, make_window, saved_window)
2632 (Fset_window_configuration, save_window_save): Don't deal with
2633 clone numbers.
2634 * buffer.c (Qclone_number): Remove declaration.
2635 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2636
2637 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2638
2639 Add multiple inheritance to keymaps.
2640 * keymap.c (Fmake_composed_keymap): New function.
2641 (Fset_keymap_parent): Simplify.
2642 (fix_submap_inheritance): Remove.
2643 (access_keymap_1): New function extracted from access_keymap to handle
2644 embedded parents and handle lists of maps.
2645 (access_keymap): Use it.
2646 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2647 (Fcopy_keymap): Handle embedded parents.
2648 (Fcommand_remapping, define_as_prefix): Simplify.
2649 (Fkey_binding): Simplify.
2650 (syms_of_keymap): Move minibuffer-local-completion-map,
2651 minibuffer-local-filename-completion-map,
2652 minibuffer-local-must-match-map, and
2653 minibuffer-local-filename-must-match-map to Elisp.
2654 (syms_of_keymap): Defsubr make-composed-keymap.
2655 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2656 (parse_menu_item): Trivial simplification.
2657
2658 2011-07-01 Glenn Morris <rgm@gnu.org>
2659
2660 * Makefile.in (SETTINGS_LIBS): Fix typo.
2661
2662 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2663
2664 * coding.c (Fencode_coding_string): Record the last coding system
2665 used, as the function doc string says (bug#8738).
2666
2667 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2668
2669 * xsettings.c (store_monospaced_changed): Take new font as arg and
2670 check for change against current_mono_font.
2671 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2672 (emacs_settings_constructor, emacs_settings_get_property)
2673 (emacs_settings_set_property, emacs_settings_class_init)
2674 (emacs_settings_init, gsettings_obj): Remove.
2675 (something_changedCB): New function for HAVE_GSETTINGS.
2676 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2677 with value as argument.
2678 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2679 g_settings_new (Bug#8967). Do not create gsettings_obj.
2680 Remove calls to g_settings_bind. Connect something_changedCB to
2681 "changed".
2682
2683 * xgselect.c: Add defined (HAVE_GSETTINGS).
2684 (xgselect_initialize): Ditto.
2685
2686 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2687 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2688 xg_select.
2689
2690 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2691
2692 * eval.c (struct backtrace): Simplify and port the data structure.
2693 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2694 signed bit field, as this assumption is not portable and it makes
2695 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2696 "char debug_on_exit : 1" as this is not portable either; instead,
2697 use the portable "unsigned int debug_on_exit : 1". Remove unused
2698 member evalargs. Remove obsolete comments about cc bombing out.
2699
2700 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2701
2702 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2703 Let HAVE_GSETTINGS override HAVE_GCONF.
2704 (store_monospaced_changed): New function.
2705 (EMACS_SETTINGS): A new type derived from GObject to handle
2706 GSettings notifications.
2707 (emacs_settings_constructor, emacs_settings_get_property)
2708 (emacs_settings_set_property, emacs_settings_class_init):
2709 New functions.
2710 (gsettings_client, gsettings_obj): New variables.
2711 (GSETTINGS_SCHEMA): New define.
2712 (something_changedCB): Call store_monospaced_changed.
2713 (init_gsettings): New function.
2714 (xsettings_initialize): Call init_gsettings.
2715 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2716 to NULL.
2717
2718 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2719 GCONF_CFLAGS/LIBS.
2720
2721 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2722
2723 * window.c (resize_root_window, grow_mini_window)
2724 (shrink_mini_window): Rename Qresize_root_window to
2725 Qwindow_resize_root_window and Qresize_root_window_vertically to
2726 Qwindow_resize_root_window_vertically.
2727
2728 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2729
2730 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2731
2732 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2733
2734 * makefile.w32-in: Redesign dependencies so they reflect more
2735 clearly which files are directly included by each source file,
2736 and not through other includes.
2737
2738 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2739
2740 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2741 (sort_overlays, overlay_strings): When an overlay's clone number
2742 matches the window's clone number process the overlay even if
2743 the overlay's window property doesn't match the current window.
2744
2745 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2746 (Fwindow_hchild): Rename to Fwindow_left_child.
2747 (Fwindow_next): Rename to Fwindow_next_sibling.
2748 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2749 (resize_window_check): Rename to window_resize_check.
2750 (resize_window_apply): Rename to window_resize_apply.
2751 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2752 (Fdelete_other_windows_internal, resize_frame_windows)
2753 (Fsplit_window_internal, Fdelete_window_internal)
2754 (grow_mini_window, shrink_mini_window)
2755 (Fresize_mini_window_internal): Fix callers accordingly.
2756
2757 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2758
2759 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2760 (emacs_fixed_set_min_size): Remove.
2761 (emacs_fixed_new): Take frame as argument.
2762
2763 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2764 (_EmacsFixedPrivate): Remove minwidth/height.
2765 Add struct frame *f.
2766 (emacs_fixed_init): Initialize priv->f.
2767 (get_parent_class, emacs_fixed_set_min_size): Remove.
2768 (emacs_fixed_new): Set priv->f to argument.
2769 (emacs_fixed_get_preferred_width)
2770 (emacs_fixed_get_preferred_height): Use min_width/height from
2771 frames size_hint to set minimum and natural (Bug#8919).
2772 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2773 and use min_width/height from frames size_hint to set
2774 min_width/height (Bug#8919).
2775
2776 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2777 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2778 Fix indentation.
2779
2780 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2781
2782 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2783 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2784 called at ZV.
2785
2786 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2787
2788 * process.c (wait_reading_process_output): Bypass select if
2789 waiting for a cell while ignoring keyboard input, and input is
2790 pending. Suggested by Jan Djärv (Bug#8869).
2791
2792 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2793
2794 Use gnulib's dup2 module instead of rolling our own.
2795 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2796
2797 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2798
2799 * dispnew.c (scrolling_window): Before scrolling, turn off a
2800 mouse-highlight in the window being scrolled.
2801
2802 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2803
2804 Move DEFSYM to lisp.h and use everywhere.
2805
2806 * character.h (DEFSYM): Move declaration...
2807 * lisp.h (DEFSYM): ...here.
2808
2809 * gnutls.c:
2810 * minibuf.c:
2811 * w32menu.c:
2812 * w32proc.c:
2813 * w32select.c: Don't include character.h.
2814
2815 * alloc.c (syms_of_alloc):
2816 * buffer.c (syms_of_buffer):
2817 * bytecode.c (syms_of_bytecode):
2818 * callint.c (syms_of_callint):
2819 * casefiddle.c (syms_of_casefiddle):
2820 * casetab.c (init_casetab_once):
2821 * category.c (init_category_once, syms_of_category):
2822 * ccl.c (syms_of_ccl):
2823 * cmds.c (syms_of_cmds):
2824 * composite.c (syms_of_composite):
2825 * dbusbind.c (syms_of_dbusbind):
2826 * dired.c (syms_of_dired):
2827 * dispnew.c (syms_of_display):
2828 * doc.c (syms_of_doc):
2829 * editfns.c (syms_of_editfns):
2830 * emacs.c (syms_of_emacs):
2831 * eval.c (syms_of_eval):
2832 * fileio.c (syms_of_fileio):
2833 * fns.c (syms_of_fns):
2834 * frame.c (syms_of_frame):
2835 * fringe.c (syms_of_fringe):
2836 * insdel.c (syms_of_insdel):
2837 * keymap.c (syms_of_keymap):
2838 * lread.c (init_obarray, syms_of_lread):
2839 * macros.c (syms_of_macros):
2840 * msdos.c (syms_of_msdos):
2841 * print.c (syms_of_print):
2842 * process.c (syms_of_process):
2843 * search.c (syms_of_search):
2844 * sound.c (syms_of_sound):
2845 * syntax.c (init_syntax_once, syms_of_syntax):
2846 * terminal.c (syms_of_terminal):
2847 * textprop.c (syms_of_textprop):
2848 * undo.c (syms_of_undo):
2849 * w32.c (globals_of_w32):
2850 * window.c (syms_of_window):
2851 * xdisp.c (syms_of_xdisp):
2852 * xfaces.c (syms_of_xfaces):
2853 * xfns.c (syms_of_xfns):
2854 * xmenu.c (syms_of_xmenu):
2855 * xsettings.c (syms_of_xsettings):
2856 * xterm.c (syms_of_xterm): Use DEFSYM.
2857
2858 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2859
2860 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2861
2862 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 Integer and buffer overflow fixes (Bug#8873).
2865
2866 * print.c (printchar, strout): Check for string overflow.
2867 (PRINTPREPARE, printchar, strout):
2868 Don't set size unless allocation succeeds.
2869
2870 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2871 for sizes. Check for string overflow more accurately.
2872 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2873
2874 * macros.c: Integer and buffer overflow fixes.
2875 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2876 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2877 Use ptrdiff_t, not int, for sizes.
2878 Don't increment bufsize until after realloc succeeds.
2879 Check for size-calculation overflow.
2880 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2881
2882 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2883
2884 * lread.c: Integer overflow fixes.
2885 (read_integer): Radix is now EMACS_INT, not int,
2886 to improve quality of diagnostics for out-of-range radices.
2887 Calculate buffer size correctly for out-of-range radices.
2888 (read1): Check for integer overflow in radices, and in
2889 read-circle numbers.
2890 (read_escape): Avoid int overflow.
2891 (Fload, openp, read_buffer_size, read1)
2892 (substitute_object_recurse, read_vector, read_list, map_obarray):
2893 Use ptrdiff_t, not int, for sizes.
2894 (read1): Use EMACS_INT, not int, for sizes.
2895 Check for size overflow.
2896
2897 * image.c (cache_image): Check for size arithmetic overflow.
2898
2899 * lread.c: Integer overflow issues.
2900 (saved_doc_string_size, saved_doc_string_length)
2901 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2902 Now ptrdiff_t, not int.
2903 (read1): Don't assume doc string length fits in int. Check for
2904 out-of-range doc string lengths.
2905 (read_list): Don't assume file position fits in int.
2906 (read_escape): Check for hex character overflow.
2907
2908 2011-06-22 Leo Liu <sdl.web@gmail.com>
2909
2910 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2911 Move to minibuffer.el.
2912
2913 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2914
2915 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2916 The following patches are for when GLYPH_DEBUG && !XASSERT.
2917 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2918 * dispnew.c (flush_stdout):
2919 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2920 Mark as externally visible.
2921 * dispnew.c (check_window_matrix_pointers): Now static.
2922 * dispnew.c (window_to_frame_vpos):
2923 * xfns.c (unwind_create_frame):
2924 * xterm.c (x_check_font): Remove unused local.
2925 * scroll.c (CHECK_BOUNDS):
2926 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2927 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2928 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2929 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2930 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2931 Now static.
2932 (debug_method_add): Use va_list and vsprintf rather than relying
2933 on undefined behavior with wrong number of arguments.
2934 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2935 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2936 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2937 since we're not interested in debugging glyphs with old libraries.
2938 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2939 GCC 4.6.0's static checking.
2940
2941 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 Integer overflow and signedness fixes (Bug#8873).
2944 A few related buffer overrun fixes, too.
2945
2946 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2947
2948 * dispextern.h (struct face.stipple):
2949 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2950 (x_bitmap_mask, x_allocate_bitmap_record)
2951 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2952 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2953 (x_create_bitmap_from_xpm_data):
2954 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2955 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2956 (.bitmaps_last):
2957 * xfaces.c (load_pixmap):
2958 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2959 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2960 (.bitmaps_last, struct x_output.icon_bitmap):
2961 Use ptrdiff_t, not int, for bitmap indexes.
2962 (x_allocate_bitmap_record): Check for size overflow.
2963 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2964
2965 Use ptrdiff_t, not int, for overlay counts.
2966 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2967 * editfns.c (overlays_around, get_pos_property):
2968 * textprop.c (get_char_property_and_overlay):
2969 * xdisp.c (next_overlay_change, note_mouse_highlight):
2970 * xfaces.c (face_at_buffer_position):
2971 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2972 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2973 (Fnext_overlay_change, Fprevious_overlay_change)
2974 (mouse_face_overlay_overlaps, Foverlays_in):
2975 Use ptrdiff_t, not int, for sizes.
2976 (overlays_at, overlays_in): Check for size-calculation overflow.
2977
2978 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2979
2980 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2981 (x_session_initialize): Do not assume string length fits in int.
2982
2983 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2984 This is unlikely, but can occur if DPI is outlandish.
2985
2986 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2987 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2988
2989 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2990 * xrdb.c (magic_file_p, search_magic_path):
2991 Omit last arg SUFFIX; it was always 0. All callers changed.
2992 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2993
2994 * xfont.c (xfont_match): Avoid need for strlen.
2995
2996 * xfns.c: Don't assume strlen fits in int.
2997 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2998
2999 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3000 not unsigned long, as we prefer signed integers. All callers changed.
3001 Detect integer overflow in repeat count.
3002 (message_dolog): Don't assume print length fits in 39 bytes.
3003 (display_mode_element): Don't assume strlen fits in int.
3004
3005 * termcap.c: Don't assume sizes fit in int and never overflow.
3006 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3007 (gobble_line): Check for size-calculation overflow.
3008
3009 * minibuf.c (Fread_buffer):
3010 * lread.c (intern, intern_c_string):
3011 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3012 Don't assume string length fits in int.
3013
3014 * keyboard.c (parse_tool_bar_item):
3015 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3016
3017 * font.c: Don't assume string length fits in int.
3018 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3019 Use ptrdiff_t, not int.
3020 (font_intern_prop): Don't assume string length fits in int.
3021 Don't assume integer property fits in fixnum.
3022 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3023
3024 * filelock.c: Fix some buffer overrun and integer overflow issues.
3025 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3026 Reformulate so as not to need the command string.
3027 Invoke gzip -cd rather than gunzip, as it's more portable.
3028 (lock_info_type, lock_file_1, lock_file):
3029 Don't assume pid_t and time_t fit in unsigned long.
3030 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3031 (current_lock_owner): Prefer signed type for sizes.
3032 Use memcpy, not strncpy, where memcpy is what is really wanted.
3033 Don't assume (via atoi) that time_t and pid_t fit in int.
3034 Check for time_t and/or pid_t out of range, e.g., via a network share.
3035 Don't alloca where an auto var works fine.
3036
3037 * fileio.c: Fix some integer overflow issues.
3038 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3039 Don't assume string length fits in int.
3040 (directory_file_name): Don't assume string length fits in long.
3041 (make_temp_name): Don't assume pid fits in int, or that its print
3042 length is less than 20.
3043
3044 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3045
3046 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3047
3048 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3049
3050 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3051 We prefer signed integers, even for size calculations.
3052
3053 * emacs.c: Don't assume string length fits in 'int'.
3054 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3055 (main): Don't invoke strlen when not needed.
3056
3057 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3058 (XD_DEBUG_MESSAGE): Don't waste a byte.
3059
3060 * callproc.c (getenv_internal_1, getenv_internal)
3061 (Fgetenv_internal):
3062 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3063
3064 * lread.c (invalid_syntax): Omit length argument.
3065 All uses changed. This doesn't fix a bug, but it simplifies the
3066 code away from its former Hollerith-constant appearance, and it's
3067 one less 'int' to worry about when looking at integer-overflow issues.
3068 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3069
3070 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3071 This didn't break anything, but it didn't help either.
3072 It's confusing to put a bogus integer in a place where the actual
3073 value does not matter.
3074 (LIST_END_P): Remove unused macro and its bogus comment.
3075 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3076
3077 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3078 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3079 implementation.
3080 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3081 We prefer signed types, and the value cannot exceed the EMACS_INT
3082 range anyway (because otherwise the length would not be representable).
3083 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3084 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3085 This avoids a GCC warning when WIDE_EMACS_INT.
3086
3087 * indent.c (sane_tab_width): New function.
3088 (current_column, scan_for_column, Findent_to, position_indentation)
3089 (compute_motion): Use it. This is just for clarity.
3090 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3091
3092 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3093
3094 * lisp.h (lint_assume): New macro.
3095 * composite.c (composition_gstring_put_cache):
3096 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3097
3098 * editfns.c, insdel.c:
3099 Omit unnecessary forward decls, to simplify future changes.
3100
3101 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3102
3103 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3104
3105 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3106 Use much-faster test for byte-length change.
3107 Don't assume string byte-length fits in 'int'.
3108 Check that character arg fits in 'int'.
3109 (mapcar1): Declare byte as byte, for clarity.
3110
3111 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3112
3113 * fns.c (concat): Catch string overflow earlier.
3114 Do not rely on integer wraparound.
3115
3116 * dispextern.h (struct it.overlay_strings_charpos)
3117 (struct it.selective): Now EMACS_INT, not int.
3118 * xdisp.c (forward_to_next_line_start)
3119 (back_to_previous_visible_line_start)
3120 (reseat_at_next_visible_line_start, next_element_from_buffer):
3121 Don't arbitrarily truncate the value of 'selective' to int.
3122
3123 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3124
3125 * composite.c: Don't truncate sizes to 'int'.
3126 (composition_gstring_p, composition_reseat_it)
3127 (composition_adjust_point): Use EMACS_INT, not int.
3128 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3129 not EMACS_UINT, for indexes.
3130
3131 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3132
3133 * buffer.c: Include <verify.h>.
3134 (struct sortvec.priority, struct sortstr.priority):
3135 Now EMACS_INT, not int.
3136 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3137 (struct sortstr.size, record_overlay_string)
3138 (struct sortstrlist.size, struct sortlist.used):
3139 Don't truncate size to int.
3140 (record_overlay_string): Check for size-calculation overflow.
3141 (init_buffer_once): Check at compile-time, not run-time.
3142
3143 2011-06-22 Jim Meyering <meyering@redhat.com>
3144
3145 Don't leak an XBM-image-sized buffer
3146 * image.c (xbm_load): Free the image buffer after using it.
3147
3148 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3149
3150 Port to Sun C.
3151 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3152 that Sun C diagnosed.
3153 * fns.c (secure_hash): Fix pointer signedness issue.
3154 * intervals.c (static_offset_intervals): New function.
3155 (offset_intervals): Use it.
3156
3157 2011-06-21 Leo Liu <sdl.web@gmail.com>
3158
3159 * deps.mk (fns.o):
3160 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3161 sha512.h.
3162
3163 * fns.c (secure_hash): Rename from crypto_hash_function and change
3164 the first arg to accept symbols.
3165 (Fsecure_hash): New primitive.
3166 (syms_of_fns): New symbols.
3167
3168 2011-06-20 Deniz Dogan <deniz@dogan.se>
3169
3170 * process.c (Fset_process_buffer): Clarify return value in
3171 docstring.
3172
3173 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3174
3175 * dispnew.c (add_window_display_history): Use BVAR.
3176
3177 * xdisp.c (debug_method_add): Use BVAR.
3178 (check_window_end, dump_glyph_matrix, dump_glyph)
3179 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3180
3181 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3182 Likewise.
3183
3184 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3185 check till after the cache is created in init_frame_faces.
3186
3187 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3188
3189 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3190
3191 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3192
3193 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3194 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3195 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3196
3197 Improve buffer-overflow checking (Bug#8873).
3198 * fileio.c (Finsert_file_contents):
3199 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3200 Remove the old (too-loose) buffer overflow checks.
3201 They weren't needed, since make_gap checks for buffer overflow.
3202 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3203 The old code merely checked for Emacs fixnum overflow, and relied
3204 on undefined (wraparound) behavior. The new code avoids undefined
3205 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3206
3207 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3208 Tune. Don't use wider integers than needed. Don't use alloca.
3209 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3210
3211 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3212
3213 * insdel.c, lisp.h (buffer_overflow): New function.
3214 (insert_from_buffer_1, replace_range, replace_range_2):
3215 * insdel.c (make_gap_larger):
3216 * editfns.c (Finsert_char):
3217 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3218
3219 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3220
3221 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3222
3223 Integer overflow and signedness fixes (Bug#8873).
3224
3225 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3226 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3227
3228 * fileio.c: Don't assume EMACS_INT fits in off_t.
3229 (emacs_lseek): New static function.
3230 (Finsert_file_contents, Fwrite_region): Use it.
3231 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3232
3233 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3234
3235 * fns.c: Don't overflow int when computing a list length.
3236 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3237 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3238 truncation on 64-bit hosts. Check for QUIT every
3239 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3240 faster and is responsive enough.
3241 (Flength): Report an error instead of overflowing an integer.
3242 (Fsafe_length): Return a float if the value is not representable
3243 as a fixnum. This shouldn't happen except in contrived situations.
3244 (Fnthcdr, Fsort): Don't assume list length fits in int.
3245 (Fcopy_sequence): Don't assume vector length fits in int.
3246
3247 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3248 (header_size, word_size): New constants.
3249 (allocate_vectorlike): Don't check size overflow here.
3250 (allocate_vector): Check it here instead, since this is the only
3251 caller of allocate_vectorlike that could cause overflow.
3252 Check that the new vector's length is representable as a fixnum.
3253
3254 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3255 The previous code was bogus. For example, next_almost_prime (32)
3256 returned 39, which is undesirable as it is a multiple of 3; and
3257 next_almost_prime (24) returned 25, which is a multiple of 5 so
3258 why was the code bothering to check for multiples of 7?
3259
3260 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3261
3262 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3263
3264 Variadic C functions now count arguments with ptrdiff_t.
3265 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3266 Back then I didn't know that the Emacs coding style prefers signed int.
3267 Also, in the meantime I found a few more instances where arguments
3268 were being counted with int, which may truncate counts on 64-bit
3269 machines, or EMACS_INT, which may be unnecessarily wide.
3270 * lisp.h (struct Lisp_Subr.function.aMANY)
3271 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3272 Arg counts are now ptrdiff_t, not size_t.
3273 All variadic functions and their callers changed accordingly.
3274 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3275 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3276 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3277 * callint.c (Fcall_interactively): Check arg count for overflow,
3278 to avoid potential buffer overrun. Use signed char, not 'int',
3279 for 'varies' array, so that we needn't bother to check its size
3280 calculation for overflow.
3281 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3282 * eval.c (apply_lambda):
3283 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3284 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3285 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3286
3287 * callint.c (Fcall_interactively): Don't use index var as event count.
3288
3289 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3290 * mem-limits.h (SIZE): Remove; no longer used.
3291
3292 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3293
3294 Remove unnecessary casts.
3295 * xterm.c (x_term_init):
3296 * xfns.c (x_set_border_pixel):
3297 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3298 These aren't needed now that we assume ANSI C.
3299
3300 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3301 It's more likely to cause problems (due to unsigned overflow)
3302 than to cure them.
3303
3304 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3305
3306 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3307
3308 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3309
3310 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3311
3312 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3313
3314 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3315
3316 GLYPH_CODE_FACE returns EMACS_INT, not int.
3317 * dispextern.h (merge_faces):
3318 * xfaces.c (merge_faces):
3319 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3320 Don't assume EMACS_INT fits in int.
3321
3322 * character.h (CHAR_VALID_P): Remove unused parameter.
3323 * fontset.c, lisp.h, xdisp.c: All uses changed.
3324
3325 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3326
3327 * fns.c (concat): Minor tuning based on overflow analysis.
3328 This doesn't fix any bugs. Use int to hold character, instead
3329 of constantly refetching from Emacs object. Use XFASTINT, not
3330 XINT, for value known to be a character. Don't bother comparing
3331 a single byte to 0400, as it's always less.
3332
3333 * floatfns.c (Fexpt):
3334 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3335
3336 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3337 for characters.
3338
3339 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3340
3341 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3342 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3343 incorrectly succeed when S was a string, because 4294967386 was
3344 truncated before it was used.
3345
3346 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3347 Otherwise, an out-of-range integer could cause undefined behavior
3348 on a 64-bit host.
3349
3350 * composite.c: Use int, not EMACS_INT, for characters.
3351 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3352 EMACS_INT, for values that are known to be in character range.
3353 This doesn't fix any bugs but is the usual style inside Emacs and
3354 may generate better code on 32-bit machines.
3355
3356 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3357 This is for reasons similar to the recent CHAR_STRING fix.
3358 * charset.c (Fencode_char): Check that character arg is actually
3359 a character. Pass an int to ENCODE_CHAR.
3360 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3361 wider than 'int', as a compile-time check to prevent future regressions
3362 in this area.
3363
3364 * character.c (char_string): Remove unnecessary casts.
3365
3366 Make sure a 64-bit char is never passed to CHAR_STRING.
3367 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3368 by silently ignoring the top 32 bits, allowing some values
3369 that were far too large to be valid characters.
3370 * character.h: Include <verify.h>.
3371 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3372 arguments are no wider than unsigned, as a compile-time check
3373 to prevent future regressions in this area.
3374 * data.c (Faset):
3375 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3376 (Fsubst_char_in_region):
3377 * fns.c (concat):
3378 * xdisp.c (decode_mode_spec_coding):
3379 Adjust to CHAR_STRING's new requirement.
3380 * editfns.c (Finsert_char, Fsubst_char_in_region):
3381 * fns.c (concat): Check that character args are actually
3382 characters. Without this test, these functions did the wrong
3383 thing with wildly out-of-range values on 64-bit hosts.
3384
3385 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3386 These casts should not be needed on 32-bit hosts, either.
3387 * keyboard.c (read_char):
3388 * lread.c (Fload): Remove casts to unsigned.
3389
3390 * lisp.h (UNSIGNED_CMP): New macro.
3391 This fixes comparison bugs on 64-bit hosts.
3392 (ASCII_CHAR_P): Use it.
3393 * casefiddle.c (casify_object):
3394 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3395 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3396 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3397 * dispextern.h (FACE_FROM_ID):
3398 * keyboard.c (read_char): Use UNSIGNED_CMP.
3399
3400 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3401 not to EMACS_INT, to avoid GCC warning.
3402
3403 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3404
3405 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3406 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3407 isn't needed on 32-bit machines.
3408
3409 * buffer.c (Fgenerate_new_buffer_name):
3410 Use EMACS_INT for count, not int.
3411 (advance_to_char_boundary): Return EMACS_INT, not int.
3412
3413 * data.c (Qcompiled_function): Now static.
3414
3415 * window.c (window_body_lines): Now static.
3416
3417 * image.c (gif_load): Rename local to avoid shadowing.
3418
3419 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3420 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3421 * alloc.c (make_save_value): Integer argument is now of type
3422 ptrdiff_t, not int.
3423 (mark_object): Use ptrdiff_t, not int.
3424 * lisp.h (pD): New macro.
3425 * print.c (print_object): Use it.
3426
3427 * alloc.c: Use EMACS_INT, not int, to count objects.
3428 (total_conses, total_markers, total_symbols, total_vector_size)
3429 (total_free_conses, total_free_markers, total_free_symbols)
3430 (total_free_floats, total_floats, total_free_intervals)
3431 (total_intervals, total_strings, total_free_strings):
3432 Now EMACS_INT, not int. All uses changed.
3433 (Fgarbage_collect): Compute overall total using a double, so that
3434 integer overflow is less likely to be a problem. Check for overflow
3435 when converting back to an integer.
3436 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3437 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3438 These were 'int' variables that could overflow on 64-bit hosts;
3439 they were never used, so remove them instead of repairing them.
3440 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3441 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3442 Previously, this ceilinged at INT_MAX, but that doesn't work on
3443 64-bit machines.
3444 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3445
3446 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3447 (allocate_vectorlike): Check for ptrdiff_t overflow.
3448 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3449 when a (possibly-narrower) signed value would do just as well.
3450 We prefer using signed arithmetic, to avoid comparison confusion.
3451
3452 * alloc.c: Catch some string size overflows that we were missing.
3453 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3454 for convenience in STRING_BYTES_MAX.
3455 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3456 The definition here is exact; the one in lisp.h was approximate.
3457 (allocate_string_data): Check for string overflow. This catches
3458 some instances we weren't catching before. Also, it catches
3459 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3460 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3461 and ptrdiff_t and EMACS_INT are both 64 bits.
3462
3463 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3464 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3465 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3466
3467 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3468
3469 * alloc.c (Fmake_string): Check for out-of-range init.
3470
3471 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3472
3473 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3474
3475 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3476
3477 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3478 xg_get_default_scrollbar_width.
3479
3480 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3481 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3482 (style_changed_cb): Call update_theme_scrollbar_width and call
3483 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3484 all frames (Bug#8505).
3485 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3486 Call gtk_window_set_resizable if HAVE_GTK3.
3487 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3488 and height if HAVE_GTK3 (Bug#8505).
3489 (scroll_bar_width_for_theme): New variable.
3490 (update_theme_scrollbar_width): New function.
3491 (xg_get_default_scrollbar_width): Move code to
3492 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3493 (xg_initialize): Call update_theme_scrollbar_width.
3494
3495 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3496
3497 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3498
3499 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3500
3501 * frame.c (make_frame): Call other_buffer_safely instead of
3502 other_buffer.
3503
3504 * window.c (temp_output_buffer_show): Call display_buffer with
3505 second argument Vtemp_buffer_show_specifiers and reset latter
3506 immediately after the call.
3507 (Vtemp_buffer_show_specifiers): New variable.
3508 (auto_window_vscroll_p, next_screen_context_lines)
3509 (Vscroll_preserve_screen_position): Remove leading asterisks from
3510 doc-strings.
3511
3512 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 Fix minor problems found by GCC 4.6.0 static checking.
3515 * buffer.c (Qclone_number): Remove for now, as it's unused.
3516 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3517 (record_buffer): Remove unused local.
3518 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3519 (set_frame_buffer_list): Remove; unused.
3520 * frame.h (other_visible_frames): Remove decl.
3521 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3522 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3523 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3524 if HAVE_GPM.
3525 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3526 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3527 Define only if HAVE_GPM.
3528 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3529 (update_hints_inhibit): Remove; never set. All uses removed.
3530 * widgetprv.h (emacsFrameClassRec): Remove decl.
3531 * window.c (delete_deletable_window): Now returns void, since it
3532 wasn't returning anything.
3533 (compare_window_configurations): Remove unused locals.
3534 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3535 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3536 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3537 the same widths as pointers. This follows up on the 2011-05-06 patch.
3538 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3539 * xterm.h: Likewise.
3540 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3541
3542 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3543
3544 * makefile.w32-in: Update dependencies.
3545 (LISP_H): Add lib/intprops.h.
3546
3547 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3548
3549 * image.c (gif_load): Add animation frame delay to the metadata.
3550 (syms_of_image): Use DEFSYM. New symbol `delay'.
3551
3552 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3553
3554 * window.c (delete_deletable_window): Re-add.
3555 (Fset_window_configuration): Rewrite to handle dead buffers and
3556 consequently deletable windows.
3557 (window_tree, Fwindow_tree): Remove. Supply functionality in
3558 window.el.
3559 (compare_window_configurations): Simplify code.
3560
3561 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3562
3563 * image.c (imagemagick_load_image): Fix type mismatch.
3564 (Fimagemagick_types): Likewise.
3565
3566 * window.h (replace_buffer_in_windows): Declare.
3567
3568 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3569
3570 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3571 Qclone_number. Remove external declaration of Qdelete_window.
3572 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3573 code.
3574 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3575 Run Qbuffer_list_update_hook if allowed.
3576 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3577 buffer list implementation.
3578 (other_buffer_safely): New function.
3579 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3580 calls to replace_buffer_in_windows and
3581 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3582 if allowed.
3583 (record_buffer): Inhibit quitting and rewrite using quittable
3584 functions. Run Qbuffer_list_update_hook if allowed.
3585 (Frecord_buffer, Funrecord_buffer): New functions.
3586 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3587 Move switch-to-buffer to window.el.
3588 (bury-buffer): Move to window.el.
3589 (Vbuffer_list_update_hook): New variable.
3590
3591 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3592 section.
3593
3594 * window.h (resize_frame_windows): Move up in code.
3595 (Fwindow_frame): Remove EXFUN.
3596 (replace_buffer_in_all_windows): Remove prototype.
3597 (replace_buffer_in_windows_safely): Add prototype.
3598
3599 * window.c: Declare Qdelete_window static again. Move down
3600 declaration of select_count.
3601 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3602 (Fother_window): Move to window.el.
3603 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3604 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3605 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3606 window.el.
3607 (replace_buffer_in_windows): Implement by calling
3608 Qreplace_buffer_in_windows.
3609 (replace_buffer_in_all_windows): Remove with some functionality
3610 moved into replace_buffer_in_windows_safely.
3611 (replace_buffer_in_windows_safely): New function.
3612 (select_window_norecord, select_frame_norecord): Move in front
3613 of run_window_configuration_change_hook. Remove now obsolete
3614 declarations.
3615 (Fset_window_buffer): Rewrite doc-string.
3616 Call Qrecord_window_buffer.
3617 (keys_of_window): Move binding for other-window to window.el.
3618
3619 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3620
3621 * dispextern.h (struct image): Replace data member, whose int_val
3622 and ptr_val fields were not used by anything, with a single
3623 lisp_val object.
3624
3625 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3626 (gif_clear_image, gif_load, imagemagick_load_image)
3627 (gs_clear_image, gs_load): Callers changed.
3628
3629 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3630
3631 * buffer.h: Include <time.h>, for time_t.
3632 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3633
3634 Fix minor problems found by static checking.
3635
3636 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3637
3638 Make identifiers static if they are not used in other modules.
3639 * data.c (Qcompiled_function, Qframe, Qvector):
3640 * image.c (QimageMagick, Qsvg):
3641 * minibuf.c (Qmetadata):
3642 * window.c (resize_window_check, resize_root_window): Now static.
3643 * window.h (resize_window_check, resize_root_window): Remove decls.
3644
3645 * window.c (window_deletion_count, delete_deletable_window):
3646 Remove; unused.
3647 (window_body_lines): Now static.
3648 (Fdelete_other_windows_internal): Mark vars as initialized.
3649 Make sure 'resize_failed' is initialized.
3650 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3651 (resize_window_apply): Remove unused local.
3652 * window.h (delete_deletable_window): Remove decl.
3653
3654 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3655 (imagemagick_load_image): Fix pointer signedness problem by changing
3656 last arg from unsigned char * to char *. All uses changed.
3657 Also, fix a local for similar reasons.
3658 Remove unused locals. Remove locals to avoid shadowing.
3659 (fn_rsvg_handle_free): Remove; unused.
3660 (svg_load, svg_load_image): Fix pointer signedness problem.
3661 (imagemagick_load_image): Don't use garbage pointer image_wand.
3662
3663 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3664
3665 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3666
3667 * image.c (gif_load): Fix omitted cast error introduced by
3668 2011-06-06 change.
3669
3670 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3671
3672 * window.h (resize_proportionally, orig_total_lines)
3673 (orig_top_line): Remove from window structure.
3674 (set_window_height, set_window_width, change_window_heights)
3675 (Fdelete_window): Remove prototypes.
3676 (resize_frame_windows): Remove duplicate declaration.
3677
3678 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3679
3680 * window.h (resize_frame_windows, resize_window_check)
3681 (delete_deletable_window, resize_root_window)
3682 (resize_frame_windows): Declare prototypes.
3683
3684 * window.c (resize_window_apply): Make definition be "static" to
3685 match the prototype.
3686
3687 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3688
3689 * window.c: Remove declarations of Qwindow_size_fixed,
3690 window_min_size_1, window_min_size_2, window_min_size,
3691 size_window, window_fixed_size_p, enlarge_window, delete_window.
3692 Remove static from declaration of Qdelete_window, it's
3693 temporarily needed by Fbury_buffer.
3694 (replace_window): Don't assign orig_top_line and
3695 orig_total_lines.
3696 (Fdelete_window, delete_window): Remove. Window deletion is
3697 handled by window.el.
3698 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3699 Replace Fdelete_window calls with calls to Qdelete_window.
3700 (Fdelete_other_windows): Remove. Deleting other windows is
3701 handled by window.el.
3702 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3703 handled in window.el.
3704 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3705 Window minimum sizes are handled in window.el.
3706 (shrink_windows, size_window, set_window_height)
3707 (set_window_width, change_window_heights, window_height)
3708 (window_width, CURBEG, CURSIZE, enlarge_window)
3709 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3710 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3711 handled in window.el.
3712 (make_dummy_parent): Rename to make_parent_window and give it a
3713 second argument horflag.
3714 (make_window): Don't set resize_proportionally any more.
3715 (Fsplit_window): Remove. Windows are split in window.el.
3716 (save_restore_action, save_restore_orig_size)
3717 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3718 Resize mini windows in window.el.
3719 (grow_mini_window, shrink_mini_window): Implement by calling
3720 Qresize_root_window_vertically, resize_window_check and
3721 resize_window_apply.
3722 (saved_window, Fset_window_configuration, save_window_save):
3723 Do not handle orig_top_line, orig_total_lines, and
3724 resize_proportionally.
3725 (window_min_height, window_min_width): Move to window.el.
3726 (keys_of_window): Move bindings for delete-other-windows,
3727 split-window, delete-window and enlarge-window to window.el.
3728
3729 * buffer.c: Temporarily extern Qdelete_window.
3730 (Fbury_buffer): Temporarily call Qdelete_window instead of
3731 Fdelete_window (Fbury_buffer will move to window.el soon).
3732
3733 * frame.c (set_menu_bar_lines_1): Remove code handling
3734 orig_top_line and orig_total_lines.
3735
3736 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3737 set_window_height but set heights directly.
3738 (change_frame_size_1): Use resize_frame_windows.
3739
3740 * xdisp.c (init_xdisp): Don't use set_window_height but set
3741 heights directly.
3742
3743 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3744 Use resize_frame_windows instead of change_window_heights and run
3745 run_window_configuration_change_hook.
3746
3747 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3748 instead of change_window_heights and run
3749 run_window_configuration_change_hook.
3750
3751 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3752
3753 * window.c (replace_window): Rename second argument REPLACEMENT to
3754 NEW. New third argument SETFLAG. Rewrite.
3755 (delete_window, make_dummy_parent): Call replace_window with
3756 third argument 1.
3757 (window_list_1): Move down in code.
3758 (run_window_configuration_change_hook): Move set_buffer part
3759 before select_frame_norecord part in order to unwind correctly.
3760 Rename count1 to count.
3761 (recombine_windows, delete_deletable_window, resize_root_window)
3762 (Fdelete_other_windows_internal)
3763 (Frun_window_configuration_change_hook, make_parent_window)
3764 (resize_window_check, resize_window_apply, Fresize_window_apply)
3765 (resize_frame_windows, Fsplit_window_internal)
3766 (Fdelete_window_internal, Fresize_mini_window_internal):
3767 New functions.
3768 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3769
3770 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3771
3772 * window.h (window): Add some new members to window structure -
3773 normal_lines, normal_cols, new_total, new_normal, clone_number,
3774 splits, nest, prev_buffers, next_buffers.
3775 (WINDOW_TOTAL_SIZE): Move here from window.c.
3776 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3777
3778 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3779 Remove.
3780 (make_dummy_parent): Set new members of windows structure.
3781 (make_window): Move down in code. Handle new members of window
3782 structure.
3783 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3784 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3785 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3786 (Fset_window_prev_buffers, Fwindow_next_buffers)
3787 (Fset_window_next_buffers, Fset_window_clone_number):
3788 New functions.
3789 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3790 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3791 Doc-string fixes.
3792 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3793 Argument WINDOW can be now internal window too.
3794 (Fwindow_use_time): Move up in code.
3795 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3796 Rewrite doc-string.
3797 (Fset_window_configuration, saved_window)
3798 (Fcurrent_window_configuration, save_window_save): Handle new
3799 members of window structure.
3800 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3801 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3802 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3803 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3804 Qget_mru_window, Qresize_root_window,
3805 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3806 Qauto_buffer_name; staticpro them.
3807
3808 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3809
3810 * window.c (Fwindow_total_size, Fwindow_left_column)
3811 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3812 (Fwindow_list_1): New functions.
3813 (window_box_text_cols): Replace with window_body_cols.
3814 (Fwindow_width, Fscroll_left, Fscroll_right):
3815 Use window_body_cols instead of window_box_text_cols.
3816 (delete_window, Fset_window_configuration):
3817 Call delete_all_subwindows with window as argument.
3818 (delete_all_subwindows): Take a window as argument and not a
3819 structure. Rewrite.
3820 (window_loop): Remove handling of GET_LRU_WINDOW and
3821 GET_LARGEST_WINDOW.
3822 (Fget_lru_window, Fget_largest_window): Move to window.el.
3823
3824 * window.h: Extern window_body_cols instead of
3825 window_box_text_cols. delete_all_subwindows now takes a
3826 Lisp_Object as argument.
3827
3828 * indent.c (compute_motion, Fcompute_motion):
3829 Use window_body_cols instead of window_box_text_cols.
3830
3831 * frame.c (delete_frame): Call delete_all_subwindows with root
3832 window as argument.
3833
3834 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3835
3836 * fns.c (Fputhash): Document return value.
3837
3838 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3839
3840 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3841
3842 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3843
3844 Cons<->int and similar integer overflow fixes (Bug#8794).
3845
3846 Check for overflow when converting integer to cons and back.
3847 * charset.c (Fdefine_charset_internal, Fdecode_char):
3848 Use cons_to_unsigned to catch overflow.
3849 (Fencode_char): Use INTEGER_TO_CONS.
3850 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3851 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3852 * data.c (long_to_cons, cons_to_long): Remove.
3853 (cons_to_unsigned, cons_to_signed): New functions.
3854 These signal an error for invalid or out-of-range values.
3855 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3856 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3857 * font.c (Ffont_variation_glyphs):
3858 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3859 * lisp.h: Include <intprops.h>.
3860 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3861 (cons_to_signed, cons_to_unsigned): New decls.
3862 (long_to_cons, cons_to_long): Remove decls.
3863 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3864 (Fprimitive_undo): Use CONS_TO_INTEGER.
3865 * xfns.c (Fx_window_property): Likewise.
3866 * xselect.c: Include <limits.h>.
3867 (x_own_selection, selection_data_to_lisp_data):
3868 Use INTEGER_TO_CONS.
3869 (x_handle_selection_request, x_handle_selection_clear)
3870 (x_get_foreign_selection, Fx_disown_selection_internal)
3871 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3872 (lisp_data_to_selection_data): Use cons_to_unsigned.
3873 (x_fill_property_data): Use cons_to_signed.
3874 Report values out of range.
3875
3876 Check for buffer and string overflow more precisely.
3877 * buffer.h (BUF_BYTES_MAX): New macro.
3878 * lisp.h (STRING_BYTES_MAX): New macro.
3879 * alloc.c (Fmake_string):
3880 * character.c (string_escape_byte8):
3881 * coding.c (coding_alloc_by_realloc):
3882 * doprnt.c (doprnt):
3883 * editfns.c (Fformat):
3884 * eval.c (verror):
3885 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3886 since they may not be the same number.
3887 * editfns.c (Finsert_char):
3888 * fileio.c (Finsert_file_contents):
3889 Likewise for BUF_BYTES_MAX.
3890
3891 * image.c: Use ptrdiff_t, not int, for sizes.
3892 (slurp_file): Switch from int to ptrdiff_t.
3893 All uses changed.
3894 (slurp_file): Check that file size fits in both size_t (for
3895 malloc) and ptrdiff_t (for sanity and safety).
3896
3897 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3898 if b->modtime has its maximal value.
3899
3900 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3901
3902 Don't assume time_t can fit into int.
3903 * buffer.h (struct buffer.modtime): Now time_t, not int.
3904 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3905 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3906
3907 Minor fixes for signed vs unsigned integers.
3908 * character.h (MAYBE_UNIFY_CHAR):
3909 * charset.c (maybe_unify_char):
3910 * keyboard.c (read_char, reorder_modifiers):
3911 XINT -> XFASTINT, since the integer must be nonnegative.
3912 * ftfont.c (ftfont_spec_pattern):
3913 * keymap.c (access_keymap, silly_event_symbol_error):
3914 XUINT -> XFASTINT, since the integer must be nonnegative.
3915 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3916 since it makes no difference and we prefer signed.
3917 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3918 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3919 nonnegative.
3920
3921 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3922
3923 * window.h (Fwindow_frame): Declare.
3924
3925 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3926
3927 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3928 (SPARE_MEMORY): Always define.
3929 (LARGE_REQUEST): Remove.
3930 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3931
3932 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3933
3934 * lisp.h: Move EXFUNS for Fframe_root_window,
3935 Fframe_first_window and Fset_frame_selected_window to window.h.
3936
3937 * window.h: Move EXFUNS for Fframe_root_window,
3938 Fframe_first_window and Fset_frame_selected_window here from
3939 lisp.h.
3940
3941 * frame.c (Fwindow_frame, Fframe_first_window)
3942 (Fframe_root_window, Fframe_selected_window)
3943 (Fset_frame_selected_window): Move to window.c.
3944 (Factive_minibuffer_window): Move to minibuf.c.
3945 (Fother_visible_frames_p): New function.
3946
3947 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3948
3949 * window.c (decode_window, decode_any_window): Move up in code.
3950 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3951 (inhibit_frame_unsplittable): Remove unused variable.
3952 (Fwindow_buffer): Move up and rewrite doc-string.
3953 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3954 (Fwindow_prev): New functions.
3955 (Fwindow_frame): Move here from frame.c. Accept any window as
3956 argument.
3957 (Fframe_root_window, Fframe_first_window)
3958 (Fframe_selected_window): Move here from frame.c. Accept frame
3959 or arbitrary window as argument. Update doc-strings.
3960 (Fminibuffer_window): Move up in code.
3961 (Fwindow_minibuffer_p): Move up in code and simplify.
3962 (Fset_frame_selected_window): Move here from frame.c.
3963 Marginal rewrite.
3964 (Fselected_window, select_window, Fselect_window): Move up in
3965 code. Minor doc-string fixes.
3966
3967 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3968
3969 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3970 Do not assume that spare memory exists; that assumption is valid
3971 only if SYSTEM_MALLOC.
3972 (LARGE_REQUEST): New macro, so that the issue of large requests
3973 is separated from the issue of spare memory.
3974
3975 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3976
3977 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3978 format. (Bug#8806)
3979
3980 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3981
3982 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3983 before statements.
3984
3985 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3986
3987 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3988
3989 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3990
3991 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3992 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3993
3994 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3995
3996 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3997
3998 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3999
4000 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4001 (x_clipboard_manager_save): Add return value.
4002 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4003 New error handlers.
4004 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4005 Obey Vx_select_enable_clipboard_manager. Catch errors in
4006 x_clipboard_manager_save (Bug#8779).
4007 (Vx_select_enable_clipboard_manager): New variable.
4008 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4009
4010 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4011
4012 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4013
4014 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4015
4016 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4017 in the current matrix if keep_current_p is non-zero.
4018
4019 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4020
4021 * bidi.c (bidi_level_of_next_char): Fix last change.
4022
4023 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4024
4025 Support bidi reordering of text covered by display properties.
4026
4027 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4028 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4029 (bidi_cache_search, bidi_cache_iterator_state)
4030 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4031 (bidi_level_of_next_char, bidi_move_to_visually_next):
4032 Support character positions inside a run of characters covered by a
4033 display string.
4034 (bidi_paragraph_init, bidi_resolve_explicit_1)
4035 (bidi_level_of_next_char): Call bidi_fetch_char and
4036 bidi_fetch_char_advance instead of FETCH_CHAR and
4037 FETCH_CHAR_ADVANCE.
4038 (bidi_init_it): Initialize new members.
4039 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4040 definitions.
4041 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4042 instead of using explicit *_CHAR codes.
4043 (bidi_resolve_explicit, bidi_resolve_weak):
4044 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4045 bidirectional text is supported only in multibyte buffers.
4046 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4047 it to initialize the frame_window_p member of struct bidi_it.
4048 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4049 (bidi_resolve_explicit, bidi_resolve_weak)
4050 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4051 bidi_it->nchars is non-positive.
4052 (bidi_level_of_next_char): Don't try to lookup the cache for the
4053 next/previous character if nothing is cached there yet, or if we
4054 were just reseat()'ed to a new position.
4055
4056 * xdisp.c (set_cursor_from_row): Set start and stop points
4057 according to the row's direction when priming the loop that looks
4058 for the glyph on which to display cursor.
4059 (single_display_spec_intangible_p): Function deleted.
4060 (display_prop_intangible_p): Reimplement to call
4061 handle_display_spec instead of single_display_spec_intangible_p.
4062 Accept 3 additional arguments needed by handle_display_spec.
4063 This fixes incorrect cursor motion across display property with complex
4064 values: lists, `(when COND...)' forms, etc.
4065 (single_display_spec_string_p): Support property values that are
4066 lists with the argument STRING its top-level element.
4067 (display_prop_string_p): Fix the condition for processing a
4068 property that is a list to be consistent with handle_display_spec.
4069 (handle_display_spec): New function, refactored from the
4070 last portion of handle_display_prop.
4071 (compute_display_string_pos): Accept additional argument
4072 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4073 value of a `display' property is a "replacing spec".
4074 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4075 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4076 the display property, but just return a value indicating whether
4077 the display property will replace the characters it covers.
4078 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4079 frame_window_p members of struct bidi_it.
4080 (compute_display_string_pos, compute_display_string_end):
4081 New functions.
4082 (push_it): Accept second argument POSITION, where pop_it should
4083 jump to continue iteration.
4084 (reseat_1): Initialize bidi_it.disp_pos.
4085
4086 * keyboard.c (adjust_point_for_property): Adjust the call to
4087 display_prop_intangible_p to its new signature.
4088
4089 * dispextern.h (struct bidi_it): New member frame_window_p.
4090 (bidi_init_it): Update prototypes.
4091 (display_prop_intangible_p): Update prototype.
4092 (compute_display_string_pos, compute_display_string_end):
4093 Declare prototypes.
4094 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4095 EMACS_INT.
4096
4097 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 Malloc failure behavior now depends on size of allocation.
4100 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4101 * lisp.h: Change signatures accordingly.
4102 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4103 All callers changed. (Bug#8762)
4104
4105 * gnutls.c: Use Emacs's memory allocators.
4106 Without this change, the gnutls library would invoke malloc etc.
4107 directly, which causes problems on non-SYNC_INPUT hosts, and which
4108 runs afoul of improving memory_full behavior. (Bug#8761)
4109 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4110 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4111 xfree instead of the default malloc, realloc, free.
4112 (Fgnutls_boot): No need to check for memory allocation failure,
4113 since xmalloc does that for us.
4114
4115 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4116 * category.c (hash_get_category_set):
4117 * ccl.c (ccl_driver):
4118 * charset.c (Fdefine_charset_internal):
4119 * charset.h (struct charset.hash_index):
4120 * composite.c (get_composition_id, gstring_lookup_cache)
4121 (composition_gstring_put_cache):
4122 * composite.h (struct composition.hash_index):
4123 * dispextern.h (struct image.hash):
4124 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4125 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4126 (hashfn_equal, hashfn_user_defined, make_hash_table)
4127 (maybe_resize_hash_table, hash_lookup, hash_put)
4128 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4129 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4130 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4131 * image.c (make_image, search_image_cache, lookup_image)
4132 (xpm_put_color_table_h):
4133 * lisp.h (struct Lisp_Hash_Table):
4134 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4135 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4136 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4137 * alloc.c (allocate_vectorlike):
4138 Check for overflow in vector size calculations.
4139 * ccl.c (ccl_driver):
4140 Check for overflow when converting EMACS_INT to int.
4141 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4142 need to be updated by these changes.
4143 * fns.c (make_hash_table, maybe_resize_hash_table):
4144 Check for integer overflow with large hash tables.
4145 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4146 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4147 (SXHASH_REDUCE): New macro.
4148 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4149 Use it instead of discarding useful hash info with large hash values.
4150 (sxhash_float): New function.
4151 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4152 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4153 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4154 Rewrite to use FIXNUM_BITS, as this simplifies things.
4155 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4156 Adjust signatures to match updated version of code.
4157 (consing_since_gc): Now EMACS_INT, since a single hash table can
4158 use more than INT_MAX bytes.
4159
4160 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4161
4162 Make it possible to build with GCC-4.6+ -O2 -flto.
4163
4164 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4165
4166 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4167
4168 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4169 Call minibuffer-inactive-mode.
4170
4171 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4172
4173 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4174 Update dependencies.
4175
4176 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4177
4178 * data.c (init_data): Remove code for UTS, this system is not
4179 supported anymore.
4180
4181 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4182
4183 Don't force ./temacs to start in terminal mode.
4184
4185 * frame.c (make_initial_frame): Initialize faces in all cases, not
4186 only when CANNOT_DUMP is defined.
4187 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4188
4189 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4190
4191 * dispnew.c (add_window_display_history): Use const for the string
4192 pointer. Remove declaration, not needed.
4193
4194 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4195
4196 Use 'inline', not 'INLINE'.
4197 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4198 * alloc.c, fontset.c (INLINE): Remove.
4199 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4200 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4201 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4202 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4203 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4204
4205 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4206
4207 Make it possible to run ./temacs.
4208
4209 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4210 syms_of_callproc does the same thing. Remove test for
4211 "initialized", do it in the caller.
4212 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4213
4214 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4215
4216 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4217 (read_minibuf): Use get_minibuffer.
4218 (syms_of_minibuf): Use DEFSYM.
4219 (Qmetadata): New var.
4220 * data.c (Qbuffer): Don't make it static.
4221 (syms_of_data): Use DEFSYM.
4222
4223 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4224
4225 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4226 (CCL_CODE_MIN): New macro.
4227
4228 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4229
4230 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4231
4232 * eval.c (Qdebug): Now static.
4233 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4234 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4235 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4236
4237 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4238
4239 * image.c: Various fixes to ImageMagick code comments.
4240 (Fimagemagick_types): Doc fix.
4241
4242 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4243
4244 Minor fixes prompted by GCC 4.6.0 warnings.
4245
4246 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4247
4248 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4249 (x_clipboard_manager_save_all): Move extern decl to ...
4250 * xterm.h: ... here, so that it can be checked for consistency.
4251
4252 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4253
4254 * xselect.c (x_clipboard_manager_save_frame)
4255 (x_clipboard_manager_save_all): New functions.
4256 (Fx_clipboard_manager_save): Lisp function deleted.
4257
4258 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4259 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4260
4261 * xterm.h: Update prototype.
4262
4263 2011-05-28 William Xu <william.xwl@gmail.com>
4264
4265 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4266 exiting (Bug#8239).
4267
4268 2011-05-28 Jim Meyering <meyering@redhat.com>
4269
4270 Avoid a sign-extension bug in crypto_hash_function.
4271 * fns.c (to_uchar): Define.
4272 (crypto_hash_function): Use it to convert some newly-signed
4273 variables to unsigned, to avoid sign-extension bugs. For example,
4274 without this change, (md5 "truc") would evaluate to
4275 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4276 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4277 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4278
4279 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4280
4281 Integer overflow fixes.
4282
4283 * dbusbind.c: Serial number integer overflow fixes.
4284 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4285 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4286 to hold a serial number that is too large for a fixnum.
4287 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4288 Check for serial numbers out of range. Decode any serial number
4289 that was so large that it became a float. (Bug#8722)
4290
4291 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4292 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4293 Use XFASTINT rather than XUINT when numbers are nonnegative.
4294 (xd_append_arg, Fdbus_method_return_internal):
4295 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4296 arguments, check that Lisp number is nonnegative, rather than
4297 silently wrapping negative numbers around. (Bug#8722)
4298 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4299 (Bug#8722)
4300
4301 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4302
4303 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4304
4305 ccl: add integer overflow checks
4306 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4307 (IN_INT_RANGE): New macros.
4308 (ccl_driver): Use them to check for integer overflow when
4309 decoding a CCL program. Many of the new checks are whether XINT (x)
4310 fits in int; it doesn't always, on 64-bit hosts. The new version
4311 doesn't catch all possible integer overflows, but it's an
4312 improvement. (Bug#8719)
4313
4314 * alloc.c (make_event_array): Use XINT, not XUINT.
4315 There's no need for unsigned here.
4316
4317 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4318 This follows up to the 2011-05-06 change that substituted uintptr_t
4319 for EMACS_INT. This case wasn't caught back then.
4320
4321 Rework Fformat to avoid integer overflow issues.
4322 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4323 now (part of C89). Include <verify.h>.
4324 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4325 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4326 (Fformat): Avoid the prepass trying to compute sizes; it was only
4327 approximate and thus did not catch overflow reliably. Instead, walk
4328 through the format just once, formatting and computing sizes as we go,
4329 checking for integer overflow at every step, and allocating a larger
4330 buffer as needed. Keep track separately whether the format is
4331 multibyte. Keep only the most-recently calculated precision, rather
4332 than them all. Record whether each argument has been converted to
4333 string. Use EMACS_INT, not int, for byte and char and arg counts.
4334 Support field widths and precisions larger than INT_MAX. Avoid
4335 sprintf's undefined behavior with conversion specifications such as %#d
4336 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4337 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4338 formatting out-of-range floating point numbers with int
4339 formats. (Bug#8668)
4340
4341 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4342
4343 * data.c: Avoid integer truncation in expressions involving floats.
4344 * data.c: Include <intprops.h>.
4345 (arith_driver): When there's an integer overflow in an expression
4346 involving floating point, convert the integers to floating point
4347 so that the resulting value does not suffer from catastrophic
4348 integer truncation. For example, on a 64-bit host (* 4
4349 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4350 Do not rely on undefined behavior after integer overflow.
4351
4352 merge count_size_as_multibyte, parse_str_to_multibyte
4353 * character.c, character.h (count_size_as_multibyte):
4354 Rename from parse_str_to_multibyte; all uses changed.
4355 Check for integer overflow.
4356 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4357 since it's now a duplicate of the other. This is more of
4358 a character than a buffer op, so better that it's in character.c.
4359 * fns.c, print.c: Adjust to above changes.
4360
4361 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4362
4363 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4364
4365 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4366
4367 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4368 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4369 (x_clipboard_manager_save): Now static.
4370 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4371
4372 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4373 (crypto_hash_function): Now static.
4374 Fix pointer signedness problems. Avoid unnecessary initializations.
4375
4376 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4377
4378 * termhooks.h (Vselection_alist): Make it terminal-local.
4379
4380 * terminal.c (create_terminal): Initialize it.
4381
4382 * xselect.c: Support for clipboard managers.
4383 (Vselection_alist): Move to termhooks.h as terminal-local var.
4384 (LOCAL_SELECTION): New macro.
4385 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4386 (symbol_to_x_atom): Remove gratuitous arg.
4387 (x_handle_selection_request, lisp_data_to_selection_data)
4388 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4389 (x_own_selection, x_get_local_selection, x_convert_selection):
4390 New arg, specifying work frame. Use terminal-local Vselection_alist.
4391 (some_frame_on_display): Delete unused function.
4392 (Fx_own_selection_internal, Fx_get_selection_internal)
4393 (Fx_disown_selection_internal, Fx_selection_owner_p)
4394 (Fx_selection_exists_p): New optional frame arg.
4395 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4396 (x_handle_selection_clear): Don't treat other terminals with the
4397 same keyboard specially. Use the terminal-local Vselection_alist.
4398 (x_clear_frame_selections): Use Frun_hook_with_args.
4399
4400 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4401
4402 * xterm.h: Add support for those atoms.
4403
4404 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4405
4406 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4407 (converted_selections, conversion_fail_tag): New global variables.
4408 (x_selection_request_lisp_error): Free the above.
4409 (x_get_local_selection): Remove unnecessary code.
4410 (x_reply_selection_request): Args changed; handle arbitrary array
4411 of converted selections stored in converted_selections.
4412 Separate the XChangeProperty and SelectionNotify steps.
4413 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4414 (x_convert_selection): New function.
4415 (x_handle_selection_event): Simplify.
4416 (x_get_foreign_selection): Don't ignore incoming requests while
4417 waiting for an answer; this will fail when we implement
4418 SAVE_TARGETS, and seems unnecessary anyway.
4419 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4420 (Vx_sent_selection_functions): Doc fix.
4421
4422 2011-05-26 Leo Liu <sdl.web@gmail.com>
4423
4424 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4425
4426 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4427
4428 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4429
4430 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4431 for fringe update if it has periodic bitmap.
4432 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4433 and fringe_bitmap_periodic_p.
4434
4435 * fringe.c (get_fringe_bitmap_data): New function.
4436 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4437 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4438 row. Mark glyph row for fringe update if periodicity changed.
4439
4440 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4441 for fringe update unless it has periodic bitmap.
4442
4443 2011-05-25 Kenichi Handa <handa@m17n.org>
4444
4445 * xdisp.c (get_next_display_element): Set correct it->face_id for
4446 a static composition.
4447
4448 2011-05-24 Leo Liu <sdl.web@gmail.com>
4449
4450 * deps.mk (fns.o):
4451 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4452
4453 * fns.c (crypto_hash_function, Fsha1): New function.
4454 (Fmd5): Use crypto_hash_function.
4455 (syms_of_fns): Add Ssha1.
4456
4457 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 * gnutls.c: Remove unused macros.
4460 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4461 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4462 Remove macros that are defined and never used.
4463 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4464
4465 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4466
4467 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4468 (Fx_get_selection_internal): Minor cleanup.
4469 (Fx_own_selection_internal): Rename arguments for consistency with
4470 select.el.
4471
4472 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4473
4474 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4475
4476 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4477
4478 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4479
4480 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4481
4482 * dispnew.c (scrolling_window): Don't exclude the case that the
4483 last enabled row in the desired matrix touches the bottom boundary.
4484
4485 2011-05-21 Glenn Morris <rgm@gnu.org>
4486
4487 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4488 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4489 and add some more files.
4490
4491 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4492
4493 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4494 report_file_error introduced by the change from 2011-05-07.
4495
4496 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4497
4498 * systime.h (Time): Define only if emacs is defined.
4499 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4500 where the include path doesn't have X11/X.h by default. See
4501 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4502
4503 2011-05-20 Kenichi Handa <handa@m17n.org>
4504
4505 * composite.c (find_automatic_composition): Fix previous change.
4506
4507 2011-05-20 Glenn Morris <rgm@gnu.org>
4508
4509 * lisp.mk: New file, split from Makefile.in.
4510 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4511 (shortlisp): Remove.
4512 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4513
4514 2011-05-19 Glenn Morris <rgm@gnu.org>
4515
4516 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4517 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4518 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4519 (lisp): Set the order to that of loadup.el.
4520 (shortlisp): Make it a copy of $lisp.
4521 (SOME_MACHINE_LISP): Remove.
4522 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4523 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4524
4525 2011-05-18 Kenichi Handa <handa@m17n.org>
4526
4527 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4528 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4529 (find_automatic_composition): Mostly rewrite for efficiency.
4530
4531 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4532
4533 * makefile.w32-in: Update dependencies.
4534
4535 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4536
4537 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4538 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4539
4540 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4541
4542 Fix some integer overflow issues, such as string length overflow.
4543
4544 * insdel.c (count_size_as_multibyte): Check for string overflow.
4545
4546 * character.c (lisp_string_width): Check for string overflow.
4547 Use EMACS_INT, not int, for string indexes and lengths; in
4548 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4549 the resulting string length overflows an EMACS_INT; instead,
4550 report a string overflow if no precision given. When checking for
4551 precision exhaustion, use a check that cannot possibly have
4552 integer overflow. (Bug#8675)
4553 * character.h (lisp_string_width): Adjust to new signature.
4554
4555 * alloc.c (string_overflow): New function.
4556 (Fmake_string): Use it. This doesn't change behavior, but saves
4557 a few bytes and will simplify future changes.
4558 * character.c (string_escape_byte8): Likewise.
4559 * lisp.h (string_overflow): New decl.
4560
4561 Fixups, following up to the user-interface timestamp change.
4562 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4563 for UI timestamps, instead of unsigned long.
4564 * msdos.c (mouse_get_pos): Likewise.
4565 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4566 * w32gui.h (Time): Define by including "systime.h" rather than by
4567 declaring it ourselves. (Bug#8664)
4568
4569 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4570 * image.c (clear_image_cache): Likewise.
4571
4572 * term.c (term_mouse_position): Don't assume time_t wraparound.
4573
4574 Be more systematic about user-interface timestamps.
4575 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4576 and sometimes 'EMACS_UINT', to represent these timestamps.
4577 This change causes it to use 'Time' uniformly, as that's what X uses.
4578 This makes the code easier to follow, and makes it easier to catch
4579 integer overflow bugs such as Bug#8664.
4580 * frame.c (Fmouse_position, Fmouse_pixel_position):
4581 Use Time, not unsigned long, for user-interface timestamps.
4582 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4583 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4584 * keyboard.h (last_event_timestamp): Likewise.
4585 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4586 * menu.h (xmenu_show): Likewise.
4587 * term.c (term_mouse_position): Likewise.
4588 * termhooks.h (struct input_event.timestamp): Likewise.
4589 (struct terminal.mouse_position_hook): Likewise.
4590 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4591 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4592 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4593 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4594 what it was before.
4595 * menu.h, termhooks.h: Include "systime.h", for Time.
4596
4597 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4598 Don't assume that the difference between two unsigned long values
4599 can fit into an integer. At this point, we know button_down_time
4600 <= event->timestamp, so the difference must be nonnegative, so
4601 there's no need to cast the result if double-click-time is
4602 nonnegative, as it should be; check that it's nonnegative, just in
4603 case. This bug is triggered when events are more than 2**31 ms
4604 apart (about 25 days). (Bug#8664)
4605
4606 * xselect.c (last_event_timestamp): Remove duplicate decl.
4607 (x_own_selection): Remove needless cast to unsigned long.
4608
4609 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4610 that always fit in int. Use a sentinel instead of a counter, to
4611 avoid a temp and to allay GCC's concerns about possible int overflow.
4612 * frame.h (struct frame): Use int for menu_bar_items_used
4613 instead of EMACS_INT, since it always fits in int.
4614
4615 * menu.c (grow_menu_items): Check for int overflow.
4616
4617 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4618
4619 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4620 Before, the code was not consistent. These values cannot exceed
4621 2**31 - 1 so there's no need to make them unsigned.
4622 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4623 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4624 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4625 as modifiers.
4626 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4627
4628 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4629 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4630 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4631 presumably because the widths might not match.
4632
4633 * window.c (size_window): Avoid needless test at loop start.
4634
4635 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4636
4637 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4638
4639 2011-05-12 Drew Adams <drew.adams@oracle.com>
4640
4641 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4642
4643 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4644
4645 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4646 `width' to `bar_area_x' and `bar_area_width', respectively.
4647 (x_scroll_run): Take account of fringe background extension.
4648
4649 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4650 Rename local vars `left' and `width' to `bar_area_x' and
4651 `bar_area_width', respectively.
4652 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4653 background extension.
4654
4655 2011-05-10 Jim Meyering <meyering@redhat.com>
4656
4657 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4658
4659 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4660
4661 * image.c (Finit_image_library): Return t for built-in image types,
4662 like pbm and xbm. (Bug#8640)
4663
4664 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4665
4666 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4667
4668 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4669
4670 * w32console.c (Fset_screen_color): Doc fix.
4671 (Fget_screen_color): New function.
4672 (syms_of_ntterm): Defsubr it.
4673
4674 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4675 unlink the temporary file if Fcall_process didn't create it in the
4676 first place.
4677 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4678 child process will be redirected to a file specified with `:file'.
4679 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4680 cue to call_process_cleanup not to close that handle.
4681
4682 2011-05-07 Ben Key <bkey76@gmail.com>
4683
4684 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4685 one of two shell specific rules, either bootstrap-temacs-CMD or
4686 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4687 to the previous implementation of the bootstrap-temacs rule.
4688 The bootstrap-temacs-CMD rule is similar to the previous
4689 implementation of the bootstrap-temacs rule except that it
4690 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4691 variable.
4692
4693 These changes, along with some changes to nt/configure.bat,
4694 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4695 earlier fix to add support for --cflags and --ldflags options
4696 that include quotes so that it works whether make uses cmd or
4697 sh as the shell.
4698
4699 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4700
4701 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4702 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4703 is a constant.
4704 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4705 a string. Handle both cases.
4706 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4707 (Fdbus_register_method): Use Qinvalid_function.
4708
4709 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4710
4711 * makefile.w32-in: Update dependencies.
4712 (LISP_H): Add inttypes.h and stdin.h.
4713 (PROCESS_H): Add unistd.h.
4714
4715 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4716
4717 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4718 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4719
4720 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4721
4722 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4723
4724 * term.c (vfatal): Remove stray call to va_end.
4725 It's not needed and the C Standard doesn't allow it here anyway.
4726
4727 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4728 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4729
4730 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4731 bytes.
4732
4733 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4734
4735 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4736
4737 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4738
4739 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4740
4741 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4742
4743 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4744 * charset.c (Fdefine_charset_internal): Don't initialize
4745 charset.code_space[15]. The value was garbage, on hosts with
4746 32-bit int (Bug#8600).
4747
4748 * lread.c (read_integer): Be more consistent with string-to-number.
4749 Use string_to_number to do the actual conversion; this avoids
4750 rounding errors and fixes some other screwups. Without this fix,
4751 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4752 (digit_to_number): Move earlier, for benefit of read_integer.
4753 Return -1 if the digit is out of range for the base, -2 if it is
4754 not a digit in any supported base. (Bug#8602)
4755
4756 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4757
4758 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4759 to match comment at start of function. This also removes a
4760 GCC warning about overflow in a 32+64-bit port.
4761
4762 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4763
4764 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4765 Reported by Stefan Monnier in
4766 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4767 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4768 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4769
4770 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4771 (EMACS_UINTPTR): Likewise, with uintptr_t.
4772
4773 * lisp.h: Prefer 64-bit EMACS_INT if available.
4774 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4775 on 32-bit hosts that have 64-bit int, so that they can access
4776 large files.
4777 However, temporarily disable this change unless the temporary
4778 symbol WIDE_EMACS_INT is defined.
4779
4780 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4781
4782 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4783 This removes an assumption that EMACS_INT and long are the same
4784 width as pointers. The assumption is true for Emacs porting targets
4785 now, but we want to make other targets possible.
4786 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4787 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4788 In the rest of the code, change types of integers that hold casted
4789 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4790 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4791 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4792 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4793 No need to cast type when ORing.
4794 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4795 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4796 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4797 assume EMACS_INT is the same width as char *.
4798 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4799 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4800 Remove no-longer-needed casts.
4801 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4802 (xg_tool_bar_help_callback, xg_make_tool_item):
4803 Use EMACS_INTPTR to hold an integer
4804 that will be cast to void *; this can avoid a GCC warning
4805 if EMACS_INT is not the same width as void *.
4806 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4807 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4808 (current_message_1, set_message_1):
4809 Use a local to convert to proper width without a cast.
4810 * xmenu.c (dialog_selection_callback): Likewise.
4811
4812 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4813 Also, don't assume VALBITS / RAND_BITS is less than 5,
4814 and don't rely on undefined behavior when shifting a 1 left into
4815 the sign bit.
4816 * lisp.h (get_random): Change signature to match.
4817
4818 * lread.c (hash_string): Use size_t, not int, for hash computation.
4819 Normally we prefer signed values; but hashing is special, because
4820 it's better to use unsigned division on hash table sizes so that
4821 the remainder is nonnegative. Also, size_t is the natural width
4822 for hashing into memory. The previous code used 'int', which doesn't
4823 retain enough info to hash well into very large tables.
4824 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4825
4826 * dbusbind.c: Don't possibly lose pointer info when converting.
4827 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4828 Use XPNTR rather than XHASH, so that the high-order bits of
4829 the pointer aren't lost when converting through void *.
4830
4831 * eval.c (Fautoload): Don't double-shift a pointer.
4832
4833 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4834
4835 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4836
4837 * gnutls.c (DEF_GNUTLS_FN):
4838 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4839
4840 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4841
4842 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4843 marker. (Bug#8610)
4844
4845 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4846
4847 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4848 New version that can reserve upto 2GB of heap space.
4849
4850 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4851
4852 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4853
4854 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4855
4856 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4857 `gnutls_certificate_set_x509_key_file'.
4858
4859 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4860
4861 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4862 Update dependencies.
4863
4864 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4865
4866 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4867 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4868 Remove unused parameter `fildes'.
4869 * process.c (read_process_output, send_process): Don't pass it.
4870
4871 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4872
4873 Fix previous change: the library cache is defined in w32.c.
4874 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4875 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4876
4877 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4878
4879 Implement dynamic loading of GnuTLS on Windows.
4880
4881 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4882 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4883 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4884 Declare.
4885
4886 * gnutls.c (Qgnutls_dll): Define.
4887 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4888 (gnutls_*): Declare function pointers.
4889 (init_gnutls_functions): New function to initialize function pointers.
4890 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4891 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4892 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4893 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4894 (emacs_gnutls_write, emacs_gnutls_read)
4895 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4896 (Fgnutls_available_p): New function.
4897 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4898 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4899 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4900
4901 * image.c: Include w32.h.
4902 (Vimage_type_cache): Delete.
4903 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4904 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4905 (w32_delayed_load): Move to w32.c.
4906
4907 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4908
4909 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4910 (w32_delayed_load): Move from image.c. When loading a library, record
4911 its filename in the :loaded-from property of the library id.
4912 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4913 Initialize and staticpro them.
4914 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4915
4916 * process.c: Include lisp.h before w32.h, not after.
4917 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4918 instead of gnutls_record_check_pending.
4919
4920 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4921
4922 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4923
4924 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4925 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4926 as passed in.
4927
4928 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4929
4930 * xterm.c (x_set_frame_alpha): Do not set property on anything
4931 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4932
4933 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4934
4935 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4936
4937 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4938
4939 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4940 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4941 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4942 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4943 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4944 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4945 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4946 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4947 (Qgnutls_bootprop_callbacks_verify): Make static.
4948
4949 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4950
4951 * callproc.c: Indentation fixup.
4952
4953 * sysdep.c (wait_for_termination_1): Make static.
4954 (wait_for_termination, interruptible_wait_for_termination):
4955 Move after wait_for_termination_1.
4956
4957 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4958
4959 * sysdep.c (interruptible_wait_for_termination): New function
4960 which is like wait_for_termination, but allows keyboard
4961 interruptions.
4962
4963 * callproc.c (Fcall_process): Add (:file "file") as an option for
4964 the STDOUT buffer.
4965 (Fcall_process_region): Ditto.
4966
4967 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4968
4969 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4970 rather than `XVECTOR (FOO)->size'.
4971
4972 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4973 inttypes.h, as a gnulib replacement is used if it not available in
4974 system headers.
4975
4976 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4977
4978 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4979 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4980 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4981
4982 * coding.c (coding_alloc_by_realloc): Error out if destination
4983 will grow beyond MOST_POSITIVE_FIXNUM.
4984 (decode_coding_emacs_mule): Abort if there isn't enough place in
4985 charbuf for the composition carryover bytes. Reserve an extra
4986 space for up to 2 characters produced in a loop.
4987 (decode_coding_iso_2022): Abort if there isn't enough place in
4988 charbuf for the composition carryover bytes.
4989
4990 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4991
4992 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4993 aborting when %lld or %lll format is passed.
4994 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4995 %llo or %llx format is passed. (Bug#8545)
4996
4997 * window.c (window_scroll_line_based): Use a marker instead of
4998 simple variables to record original value of point. (Bug#7952)
4999
5000 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5001 produced by %s or %c overflows available buffer space. (Bug#8545)
5002
5003 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5004
5005 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5006 (SIZE_MAX): Move defn after all includes, as they might #define it.
5007
5008 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5009
5010 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5011
5012 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5013
5014 * keyboard.c (Qdelayed_warnings_hook): Define.
5015 (command_loop_1): Run `delayed-warnings-hook'
5016 if Vdelayed_warnings_list is non-nil.
5017 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5018 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5019
5020 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5021
5022 * doprnt.c (doprnt): Don't return value smaller than the buffer
5023 size if the message was truncated. (Bug#8545).
5024
5025 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5026
5027 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5028 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5029
5030 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5031
5032 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5033
5034 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5035
5036 * makefile.w32-in: Update dependencies.
5037
5038 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5039
5040 Improve `doprnt' and its usage. (Bug#8545)
5041 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5042 `format_end'. Remove support for %l as a conversion specifier.
5043 Don't use xrealloc. Improve diagnostics when the %l size modifier
5044 is used. Update the commentary.
5045
5046 * eval.c (verror): Simplify calculation of size_t.
5047
5048 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5049 messages.
5050
5051 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5052
5053 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5054 change.
5055
5056 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5057
5058 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5059 This makes this file independent of the recent pseudovector change.
5060
5061 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5062
5063 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5064
5065 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5066 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5067 Remove unused local.
5068 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5069
5070 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5071 GCC 4.6.0 optimizes based on type-based alias analysis.
5072 For example, if b is of type struct buffer * and v of type struct
5073 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5074 != &v->size, and therefore "v->size = 1; b->size = 2; return
5075 v->size;" must therefore return 1. This assumption is incorrect
5076 for Emacs, since it type-puns struct Lisp_Vector * with many other
5077 types. To fix this problem, this patch adds a new type struct
5078 vectorlike_header that documents the constraints on layout of vectors
5079 and pseudovectors, and helps optimizing compilers not get fooled
5080 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5081 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5082 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5083 the size member.
5084 (XSETPVECTYPE): Rewrite in terms of new macro.
5085 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5086 This is a bit clearer, and further avoids the possibility of
5087 undesirable aliasing.
5088 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5089 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5090 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5091 since Lisp_Subr is a special case (no "next" field).
5092 (ASIZE): Now uses header.size rather than size.
5093 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5094 to avoid the hassle of writing XVECTOR (foo)->header.size.
5095 (struct vectorlike_header): New type.
5096 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5097 object, to help avoid aliasing.
5098 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5099 (SUBRP): Likewise, since Lisp_Subr is a special case.
5100 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5101 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5102 (struct Lisp_Hash_Table): Combine first two members into a single
5103 struct vectorlike_header member. All uses of "size" and "next" members
5104 changed to be "header.size" and "header.next".
5105 * buffer.h (struct buffer): Likewise.
5106 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5107 * frame.h (struct frame): Likewise.
5108 * process.h (struct Lisp_Process): Likewise.
5109 * termhooks.h (struct terminal): Likewise.
5110 * window.c (struct save_window_data, struct saved_window): Likewise.
5111 * window.h (struct window): Likewise.
5112 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5113 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5114 * buffer.c (init_buffer_once): Likewise.
5115 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5116 special case.
5117 * process.c (Fformat_network_address): Use local var for size,
5118 for brevity.
5119
5120 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5121
5122 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5123 * data.c (atof): Remove decl; no longer used or needed.
5124 (digit_to_number): Move to lread.c.
5125 (Fstring_to_number): Use new string_to_number function, to be
5126 consistent with how the Lisp reader treats infinities and NaNs.
5127 Do not assume that floating-point numbers represent EMACS_INT
5128 without losing information; this is not true on most 64-bit hosts.
5129 Avoid double-rounding errors, by insisting on integers when
5130 parsing non-base-10 numbers, as the documentation specifies.
5131 * lisp.h (string_to_number): New decl, replacing ...
5132 (isfloat_string): Remove.
5133 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5134 (read1): Do not accept +. and -. as integers; this
5135 appears to have been a coding error. Similarly, do not accept
5136 strings like +-1e0 as floating point numbers. Do not report
5137 overflow for integer overflows unless the base is not 10 which
5138 means we have no simple and reliable way to continue.
5139 Break out the floating-point parsing into a new
5140 function string_to_number, so that Fstring_to_number parses
5141 floating point numbers consistently with the Lisp reader.
5142 (digit_to_number): Move here from data.c. Make it static inline.
5143 (E_CHAR, EXP_INT): Remove, replacing with ...
5144 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5145 (string_to_number): New function, replacing isfloat_string.
5146 This function checks for valid syntax and produces the resulting
5147 Lisp float number too. Rework it so that string-to-number
5148 no longer mishandles examples like "1.0e+". Use strtoumax,
5149 so that overflow for non-base-10 numbers is reported only when
5150 there's no portable and simple way to convert to floating point.
5151
5152 * textprop.c (set_text_properties_1): Rewrite for clarity,
5153 and to avoid GCC warning about integer overflow.
5154
5155 * intervals.h (struct interval): Use EMACS_INT for members
5156 where EMACS_UINT might cause problems. See
5157 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5158 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5159 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5160 All uses changed.
5161 (offset_intervals): Tell GCC not to worry about length overflow
5162 when negating a negative length.
5163
5164 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5165 (overrun_check_free): Likewise.
5166
5167 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5168 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5169 word size.
5170
5171 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5172 (gnutls_make_error): Rename local to avoid shadowing.
5173 (gnutls_emacs_global_deinit): ifdef out; not used.
5174 (Fgnutls_boot): Use const for pointer to readonly storage.
5175 Comment out unused local. Fix pointer signedness problems.
5176
5177 * lread.c (openp): Don't stuff size_t into an 'int'.
5178 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5179 about possible signed overflow.
5180
5181 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5182 (GDK_KEY_g): Don't define if already defined.
5183 (xg_prepare_tooltip): Avoid pointer signedness problem.
5184 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5185
5186 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5187 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5188
5189 * xfns.c (Fx_window_property): Simplify a bit,
5190 to make a bit faster and to avoid GCC 4.6.0 warning.
5191 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5192
5193 * fns.c (internal_equal): Don't assume size_t fits in int.
5194
5195 * alloc.c (compact_small_strings): Tighten assertion a little.
5196
5197 Replace pEd with more-general pI, and fix some printf arg casts.
5198 * lisp.h (pI): New macro, generalizing old pEd macro to other
5199 conversion specifiers. For example, use "...%"pI"d..." rather
5200 than "...%"pEd"...".
5201 (pEd): Remove. All uses replaced with similar uses of pI.
5202 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5203 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5204 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5205 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5206 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5207 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5208 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5209 64-bit hosts.
5210 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5211 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5212 * print.c (safe_debug_print, print_object): Likewise.
5213 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5214 to int.
5215 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5216 avoiding the 0 flag, which is not portable.
5217 * process.c (Fmake_network_process): Use pI to avoid cast.
5218 * region-cache.c (pp_cache): Likewise.
5219 * xdisp.c (decode_mode_spec): Likewise.
5220 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5221 behavior on 64-bit hosts with printf arg.
5222 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5223 (x_stop_queuing_selection_requests): Likewise.
5224 (x_get_window_property): Don't truncate byte count to an 'int'
5225 when tracing.
5226
5227 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5228 here, since it parses constructs like leading '-' and spaces,
5229 which are not wanted; and it overflows with large numbers.
5230 Instead, simply match F[0-9]+, which is what is wanted anyway.
5231
5232 * alloc.c: Remove unportable assumptions about struct layout.
5233 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5234 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5235 (allocate_vectorlike, make_pure_vector): Use the new macros,
5236 plus offsetof, to remove unportable assumptions about struct layout.
5237 These assumptions hold on all porting targets that I know of, but
5238 they are not guaranteed, they're easy to remove, and removing them
5239 makes further changes easier.
5240
5241 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5242 This doesn't fix a bug but makes the code clearer.
5243 (string_overrun_cookie): Now const. Use initializers that
5244 don't formally overflow signed char, to avoid warnings.
5245 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5246 can cause Emacs to crash when string overrun checking is enabled.
5247 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5248 multiple of sizeof (EMACS_INT); it need not be, if
5249 alignof(EMACS_INT) < sizeof (EMACS_INT).
5250 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5251
5252 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5253
5254 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5255
5256 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5257
5258 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5259 supposed to be handshaking. (Bug#8556)
5260 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5261
5262 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5263
5264 * lisp.h (Qdebug): List symbol.
5265 * eval.c (Qdebug): Restore global linkage.
5266 * keyboard.c (debug-on-event): New variable.
5267 (handle_user_signal): Break into debugger when debug-on-event
5268 matches the current signal symbol.
5269
5270 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5271
5272 * alloc.c (check_sblock, check_string_bytes)
5273 (check_string_free_list): Convert to standard C.
5274
5275 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5276
5277 * w32.c (emacs_gnutls_push): Fix typo.
5278
5279 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5280
5281 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5282 "cast to pointer from integer of different size".
5283
5284 Improve doprnt and its use in verror. (Bug#8545)
5285 * doprnt.c (doprnt): Document the set of format control sequences
5286 supported by the function. Use SAFE_ALLOCA instead of always
5287 using `alloca'.
5288
5289 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5290 is one byte too soon. Don't use xrealloc; instead xfree and
5291 xmalloc anew.
5292
5293 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5294
5295 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5296 callbacks stage.
5297
5298 * gnutls.c: Renamed global_initialized to
5299 gnutls_global_initialized. Added internals for the
5300 :verify-hostname-error, :verify-error, and :verify-flags
5301 parameters of `gnutls-boot' and documented those parameters in the
5302 docstring. Start callback support.
5303 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5304 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5305 on error. Return error code.
5306 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5307 (emacs_gnutls_read): Likewise.
5308 (Fgnutls_boot): Return handshake error code.
5309 (emacs_gnutls_handle_error): New function.
5310 (wsaerror_to_errno): Likewise.
5311
5312 * w32.h (emacs_gnutls_pull): Add prototype.
5313 (emacs_gnutls_push): Likewise.
5314
5315 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5316 (emacs_gnutls_push): Likewise.
5317
5318 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5319
5320 * process.c (wait_reading_process_output): Check if GnuTLS
5321 buffered some data internally if no FDs are set for TLS
5322 connections.
5323
5324 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5325 (LIBS): Link to USER_LIBS.
5326 ($(BLD)/gnutls.$(0)): New target.
5327
5328 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5329
5330 * xdisp.c (handle_single_display_spec): Rename the
5331 display_replaced_before_p argument into display_replaced_p, to
5332 make it consistent with the commentary. Fix typos in the
5333 commentary.
5334
5335 * textprop.c (syms_of_textprop): Remove dead code.
5336 (copy_text_properties): Delete obsolete commentary about an
5337 interface that was deleted long ago. Fix typos in the description
5338 of arguments.
5339
5340 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5341 to changes in oldXMenu/XMenu.h from 2011-04-16.
5342 <menu_help_message, prev_menu_help_message>: Constify.
5343 (IT_menu_make_room): menu->help_text is now `const char **';
5344 adjust.
5345
5346 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5347 to changes in oldXMenu/XMenu.h from 2011-04-16.
5348 (struct XMenu): Declare `help_text' `const char **'.
5349
5350 * xfaces.c <Qunspecified>: Make extern again.
5351
5352 * syntax.c: Include sys/types.h before including regex.h, as
5353 required by Posix.
5354
5355 * doc.c (get_doc_string): Improve the format passed to `error'.
5356
5357 * doprnt.c (doprnt): Improve commentary.
5358
5359 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5360
5361 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5362 them with etags.
5363
5364 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5365 changes in globals.h immediately force recompilation.
5366 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5367 $(CURDIR)/s/ms-w32.h.
5368 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5369
5370 * character.c (Fchar_direction): Function deleted.
5371 (syms_of_character): Don't defsubr it.
5372 <char-direction-table>: Deleted.
5373
5374 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5375
5376 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5377 * doprnt.c: Include limits.h.
5378 (SIZE_MAX): New macro.
5379 (doprnt): Return a size_t value. 2nd arg is now size_t.
5380 Many local variables are now size_t instead of int or unsigned.
5381 Improve overflow protection. Support `l' modifier for integer
5382 conversions. Support %l conversion. Don't assume an EMACS_INT
5383 argument for integer conversions and for %c.
5384
5385 * lisp.h (doprnt): Restore prototype.
5386
5387 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5388 $(SRC)/character.h.
5389
5390 * Makefile.in (base_obj): Add back doprnt.o.
5391
5392 * deps.mk (doprnt.o): Add back prerequisites.
5393 (callint.o): Depend on character.h.
5394
5395 * eval.c (internal_lisp_condition_case): Include the handler
5396 representation in the error message.
5397 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5398 when breaking from the loop.
5399
5400 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5401
5402 * callint.c (Fcall_interactively): When displaying error message
5403 about invalid control letter, pass the character's codepoint, not
5404 a pointer to its multibyte form. Improve display of the character
5405 in octal and display also its hex code.
5406
5407 * character.c (char_string): Use %x to display the (unsigned)
5408 codepoint of an invalid character, to avoid displaying a bogus
5409 negative value.
5410
5411 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5412 `error', not SYMBOL_NAME itself.
5413
5414 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5415 character arguments to `error'.
5416
5417 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5418 to `error' in error message about FINAL_CHAR argument. Make sure
5419 FINAL_CHAR is a character, and use %c when it is passed as
5420 argument to `error'.
5421
5422 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5423
5424 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5425
5426 * w32.c: Include <time.h>.
5427 (sys_localtime): New function.
5428
5429 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5430
5431 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5432
5433 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5434
5435 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5436
5437 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5438 zombies (Bug#8467).
5439
5440 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5441
5442 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5443 gl_state.e_property when gl_state.object is Qt.
5444
5445 * insdel.c (make_gap_larger): Remove limitation of buffer size
5446 to <= INT_MAX.
5447
5448 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5449
5450 * xdisp.c (lookup_glyphless_char_display)
5451 (produce_glyphless_glyph): Handle cons cell entry in
5452 glyphless-char-display.
5453 (Vglyphless_char_display): Document it.
5454
5455 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5456 glyphless-char-display.
5457
5458 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5459
5460 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5461
5462 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5463
5464 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5465 definition for no-X builds.
5466
5467 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5468
5469 Static checks with GCC 4.6.0 and non-default toolkits.
5470
5471 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5472
5473 * process.c (keyboard_bit_set): Define only if SIGIO.
5474 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5475 (send_process): Repair possible setjmp clobbering.
5476
5477 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5478
5479 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5480
5481 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5482
5483 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5484 Define only if needed.
5485
5486 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5487 by pacifying GCC about it. Maybe it's time to retire it?
5488 * xfaces.c (USG, __TIMEVAL__): Likewise.
5489
5490 * dispextern.h (struct redisplay_interface): Rename param
5491 to avoid shadowing.
5492 * termhooks.h (struct terminal): Likewise.
5493 * xterm.c (xembed_send_message): Likewise.
5494
5495 * insdel.c (make_gap_smaller): Define only if
5496 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5497
5498 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5499 it.
5500
5501 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5502 so that we aren't warned about unused symbols.
5503
5504 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5505
5506 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5507
5508 * xfns.c (x_real_positions): Mark locals as initialized.
5509
5510 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5511
5512 * xterm.c: Fix problems found by static analysis with other toolkits.
5513 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5514 (x_dispatch_event): Declare static if USE_GTK, and
5515 define if USE_GTK || USE_X_TOOLKIT.
5516 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5517 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5518 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5519 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5520
5521 * xmenu.c (menu_help_callback): Pointer type fixes.
5522 Use const pointers when pointing at readonly data. Avoid pointer
5523 signedness clashes.
5524 (FALSE): Remove unused macro.
5525 (update_frame_menubar): Remove unused decl.
5526
5527 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5528
5529 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5530 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5531 (single_menu_item): Rename local to avoid shadowing.
5532
5533 * keyboard.c (make_lispy_event): Remove unused local var.
5534
5535 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5536 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5537
5538 * bitmaps: Change bitmaps from unsigned char back to the X11
5539 compatible char. Avoid the old compiler warnings about
5540 out-of-range initializers by using, for example, '\xab' rather
5541 than 0xab.
5542
5543 * xgselect.c (xgselect_initialize): Check vs interface
5544 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5545
5546 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5547
5548 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5549 to read-only memory.
5550
5551 * fns.c (vector): Remove; this old hack is no longer needed.
5552
5553 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5554 Remove unused var.
5555 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5556
5557 * xrdb.c (x_load_resources): Omit unused local.
5558
5559 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5560 (x_window): Rename locals to avoid shadowing.
5561 (USG): Use the kludged USG macro, to pacify gcc.
5562
5563 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5564 (x_term_init): Remove local to avoid shadowing.
5565
5566 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5567
5568 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5569 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5570
5571 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5572
5573 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5574
5575 Fix regex.c, syntax.c and friends for buffers > 2GB.
5576 * syntax.h (struct gl_state_s): Declare character position members
5577 EMACS_INT.
5578
5579 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5580
5581 * textprop.c (verify_interval_modification, interval_of):
5582 Declare arguments EMACS_INT.
5583
5584 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5585 EMACS_INT.
5586
5587 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5588
5589 * indent.c (Fvertical_motion): Local variable it_start is now
5590 EMACS_INT.
5591
5592 * regex.c (re_match, re_match_2, re_match_2_internal)
5593 (bcmp_translate, regcomp, regexec, print_double_string)
5594 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5595 (re_compile_pattern, re_exec): Declare arguments and local
5596 variables `size_t' and `ssize_t' and return values `regoff_t', as
5597 appropriate.
5598 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5599 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5600 <compile_stack_type>: `size' and `avail' are now `size_t'.
5601
5602 * regex.h <regoff_t>: Use ssize_t, not int.
5603 (re_search, re_search_2, re_match, re_match_2): Arguments that
5604 specify buffer/string position and length are now ssize_t and
5605 size_t. Return type is regoff_t.
5606
5607 2011-04-16 Ben Key <bkey76@gmail.com>
5608
5609 * nsfont.m: Fixed bugs in ns_get_family and
5610 ns_descriptor_to_entity that were caused by using free to
5611 deallocate memory blocks that were allocated by xmalloc (via
5612 xstrdup). This caused Emacs to crash when compiled with
5613 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5614 --enable-checking=xmallocoverrun). xfree is now used to
5615 deallocate these memory blocks.
5616
5617 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5618
5619 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5620
5621 emacs_write: Accept and return EMACS_INT for sizes.
5622 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5623 et seq.
5624 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5625 Accept and return EMACS_INT.
5626 (emacs_gnutls_write): Return the number of bytes written on
5627 partial writes.
5628 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5629 (emacs_read, emacs_write): Remove check for negative size, as the
5630 Emacs source code has been audited now.
5631 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5632 (emacs_read, emacs_write): Use it.
5633 * process.c (send_process): Adjust to the new signatures of
5634 emacs_write and emacs_gnutls_write. Do not attempt to store
5635 a byte offset into an 'int'; it might overflow.
5636 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5637
5638 * sound.c: Don't assume sizes fit in 'int'.
5639 (struct sound_device.period_size, alsa_period_size):
5640 Return EMACS_INT, not int.
5641 (struct sound_device.write, vox_write, alsa_write):
5642 Accept EMACS_INT, not int.
5643 (wav_play, au_play): Use EMACS_INT to store sizes and to
5644 record read return values.
5645
5646 2011-04-15 Ben Key <bkey76@gmail.com>
5647
5648 * keyboard.c (Qundefined): Don't declare static since it is used
5649 in nsfns.m.
5650 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5651 static since they are used in nsfont.m.
5652
5653 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5654
5655 * process.c (Qprocessp): Don't declare static.
5656 * lisp.h (Qprocessp): Declare again.
5657
5658 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5659
5660 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5661
5662 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5663
5664 Improve C-level modularity by making more things 'static'.
5665
5666 Don't publish debugger-only interfaces to other modules.
5667 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5668 (verify_bytepos, count_markers): Move decls to the only modules
5669 that need them.
5670 * region-cache.h (pp_cache): Likewise.
5671 * window.h (check_all_windows): Likewise.
5672 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5673
5674 * sysdep.c (croak): Now static, if
5675 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5676 * syssignal.h (croak): Declare only if not static.
5677
5678 * alloc.c (refill_memory_reserve): Now static if
5679 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5680 * lisp.h (refill_memory_reserve): Declare only if not static.
5681
5682 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5683 Define only if USE_LUCID.
5684
5685 * xrdb.c (x_customization_string, x_rm_string): Now static.
5686
5687 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5688 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5689
5690 * xdisp.c (draw_row_with_mouse_face): Now static.
5691 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5692
5693 * window.h (check_all_windows): Mark externally visible.
5694
5695 * window.c (window_deletion_count): Now static.
5696
5697 * undo.c: Make symbols static if they're not exported.
5698 (last_undo_buffer, last_boundary_position, pending_boundary):
5699 Now static.
5700
5701 * textprop.c (interval_insert_behind_hooks): Now static.
5702 (interval_insert_in_front_hooks): Likewise.
5703
5704 * term.c: Make symbols static if they're not exported.
5705 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5706 (max_frame_lines, tty_set_terminal_modes):
5707 (tty_reset_terminal_modes, tty_turn_off_highlight):
5708 (get_tty_terminal): Now static.
5709 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5710 * termhooks.h (term_mouse_moveto): Do not declare if
5711 HAVE_WINDOW_SYSTEM.
5712 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5713 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5714
5715 * sysdep.c: Make symbols static if they're not exported.
5716 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5717 Now static.
5718 (sigprocmask_set, full_mask): Remove; unused.
5719 (wait_debugging): Mark as visible.
5720 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5721 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5722
5723 * syntax.c (syntax_temp): Define only if !__GNUC__.
5724
5725 * sound.c (current_sound_device, current_sound): Now static.
5726
5727 * search.c (searchbufs, searchbuf_head): Now static.
5728
5729 * scroll.c (scroll_cost): Remove; unused.
5730 * dispextern.h (scroll_cost): Remove decl.
5731
5732 * region-cache.h (pp_cache): Mark as externally visible.
5733
5734 * process.c: Make symbols static if they're not exported.
5735 (process_tick, update_tick, create_process, chan_process):
5736 (Vprocess_alist, proc_buffered_char, datagram_access):
5737 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5738 (deactivate_process): Mark defn as static, as well as decl.
5739 * lisp.h (create_process): Remove decl.
5740 * process.h (chan_process, Vprocess_alist): Remove decls.
5741
5742 * print.c: Make symbols static if they're not exported.
5743 (print_depth, new_backquote_output, being_printed, print_buffer):
5744 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5745 (print_interval, print_number_index, initial_stderr_stream):
5746 Now static.
5747 * lisp.h (Fprinc): Remove decl.
5748 (debug_output_compilation_hack): Mark as externally visible.
5749
5750 * sysdep.c (croak): Move decl from here to syssignal.h.
5751 * syssignal.h (croak): Put it here, so the API can be checked when
5752 'croak' is called from dissociate_if_controlling_tty.
5753
5754 * minibuf.c: Make symbols static if they're not exported.
5755 (minibuf_save_list, choose_minibuf_frame): Now static.
5756 * lisp.h (choose_minibuf_frame): Remove decl.
5757
5758 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5759
5760 * lread.c: Make symbols static if they're not exported.
5761 (read_objects, initial_obarray, oblookup_last_bucket_number):
5762 Now static.
5763 (make_symbol): Remove; unused.
5764 * lisp.h (initial_obarray, make_symbol): Remove decls.
5765
5766 * keyboard.c: Make symbols static if they're not exported.
5767 (single_kboard, recent_keys_index, total_keys, recent_keys):
5768 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5769 (this_single_command_key_start, echoing, last_auto_save):
5770 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5771 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5772 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5773 (Vlispy_mouse_stem, double_click_count):
5774 Now static.
5775 (force_auto_save_soon): Define only if SIGDANGER.
5776 (ignore_mouse_drag_p): Now static if
5777 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5778 (print_help): Remove; unused.
5779 (stop_character, last_timer_event): Mark as externally visible.
5780 * keyboard.h (ignore_mouse_drag_p): Declare only if
5781 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5782 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5783 * lisp.h (echoing): Remove decl.
5784 (force_auto_save_soon): Declare only if SIGDANGER.
5785 * xdisp.c (redisplay_window): Simplify code, to make it more
5786 obvious that ignore_mouse_drag_p is not accessed if !defined
5787 USE_GTK && !defined HAVE_NS.
5788
5789 * intervals.c: Make symbols static if they're not exported.
5790 (merge_properties_sticky, merge_interval_right, delete_interval):
5791 Now static.
5792 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5793
5794 * insdel.c: Make symbols static if they're not exported.
5795 However, leave prepare_to_modify_buffer alone. It's never
5796 called from outside this function, but that appears to be a bug.
5797 (combine_after_change_list, combine_after_change_buffer):
5798 (adjust_after_replace, signal_before_change): Now static.
5799 (adjust_after_replace_noundo): Remove; unused.
5800 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5801 (signal_before_change): Remove decls.
5802
5803 * indent.c (val_compute_motion, val_vmotion): Now static.
5804
5805 * image.c: Make symbols static if they're not exported.
5806 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5807 if USE_GTK.
5808 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5809 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5810
5811 * fringe.c (standard_bitmaps): Now static.
5812 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5813
5814 * frame.c: Make symbols static if they're not exported.
5815 (x_report_frame_params, make_terminal_frame): Now static.
5816 (get_frame_param): Now static, unless HAVE_NS.
5817 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5818 (x_get_resource_string): Remove; not used.
5819 * frame.h (make_terminal_frame, x_report_frame_params):
5820 (x_get_resource_string); Remove decls.
5821 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5822 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5823
5824 * font.c, fontset.c: Make symbols static if they're not exported.
5825 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5826 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5827 * font.c (font_close_object): Now static.
5828 * font.h (font_close_object): Remove.
5829 * fontset.c (FONTSET_OBJLIST): Remove.
5830 (free_realized_fontset) #if-0 the body, which does nothing.
5831 (face_suitable_for_char_p): #if-0, as it's never called.
5832 * fontset.h (face_suitable_for_char_p): Remove decl.
5833 * xfaces.c (face_at_string_position):
5834 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5835 since 0 is always ASCII.
5836
5837 * fns.c (weak_hash_tables): Now static.
5838
5839 * fileio.c: Make symbols static if they're not exported.
5840 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5841 (Vwrite_region_annotation_buffers): Now static.
5842
5843 * eval.c: Make symbols static if they're not exported.
5844 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5845 * lisp.h (backtrace_list): Remove decl.
5846
5847 * emacs.c: Make symbols static if they're not exported.
5848 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5849 (fatal_error_code, fatal_error_signal_hook, standard_args):
5850 Now static.
5851 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5852 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5853 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5854 * lisp.h (fatal_error_signal_hook): Remove decl.
5855 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5856
5857 * editfns.c: Move a (normally-unused) function to its only use.
5858 * editfns.c, lisp.h (get_operating_system_release): Remove.
5859 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5860 worth the hassle of breaking this out.
5861
5862 * xterm.c: Make symbols static if they're not exported.
5863 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5864 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5865 (x_destroy_window, x_delete_display):
5866 Now static.
5867 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5868 (x_mouse_leave): Remove; unused.
5869 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5870 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5871 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5872 Remove decls.
5873 (x_mouse_leave): Declare only if WINDOWSNT.
5874 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5875 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5876 USE_X_TOOLKIT.
5877
5878 * ftxfont.c: Make symbols static if they're not exported.
5879 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5880 HAVE_FREETYPE.
5881 * font.h (ftxfont_driver): Likewise.
5882
5883 * xfns.c: Make symbols static if they're not exported.
5884 (x_last_font_name, x_display_info_for_name):
5885 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5886 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5887 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5888 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5889 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5890 (last_show_tip_args): Now static.
5891 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5892 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5893 (x_screen_planes): Remove; unused.
5894 * dispextern.h (x_screen_planes): Remove decl.
5895
5896 * dispnew.c: Make symbols static if they're not exported.
5897 * dispextern.h (redraw_garbaged_frames, scrolling):
5898 (increment_row_positions): Remove.
5899 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5900 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5901 Now static.
5902 (redraw_garbaged_frames): Remove; unused.
5903
5904 * xfaces.c: Make symbols static if they're not exported.
5905 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5906 Remove decls.
5907 * xterm.h (defined_color): Remove decls.
5908 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5909 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5910 (menu_face_changed_default, defined_color, free_realized_face):
5911 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5912 (ascii_face_of_lisp_face): Remove; unused.
5913
5914 * xdisp.c: Make symbols static if they're not exported.
5915 * dispextern.h (scratch_glyph_row, window_box_edges):
5916 (glyph_to_pixel_coords, set_cursor_from_row):
5917 (get_next_display_element, set_iterator_to_next):
5918 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5919 (show_mouse_face): Remove decls
5920 * frame.h (message_buf_print): Likewise.
5921 * lisp.h (pop_message, set_message, check_point_in_composition):
5922 Likewise.
5923 * xterm.h (set_vertical_scroll_bar): Likewise.
5924 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5925 (message_buf_print, scratch_glyph_row, displayed_buffer):
5926 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5927 (get_next_display_element, show_mouse_face, window_box_edges):
5928 (frame_to_window_pixel_xy, check_point_in_composition):
5929 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5930 (glyph_to_pixel_coords): Remove; unused.
5931
5932 * dired.c (file_name_completion): Now static.
5933
5934 * dbusbind.c (xd_in_read_queued_messages): Now static.
5935
5936 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5937 * data.c (circular_list_error): Remove.
5938
5939 * commands.h (last_point_position, last_point_position_buffer):
5940 (last_point_position_window): Remove decls.
5941 * keyboard.c: Make these variables static.
5942
5943 * coding.h (coding, code_convert_region, encode_coding_gap):
5944 Remove decls.
5945 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5946 (iso_code_class, detect_coding, code_convert_region): Now static.
5947 (encode_coding_gap): Remove; unused.
5948
5949 * chartab.c (chartab_chars, chartab_bits): Now static.
5950
5951 * charset.h (charset_iso_8859_1): Remove decl.
5952 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5953 Now static.
5954
5955 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5956 * ccl.c (Vccl_program_table): Now static.
5957 (check_ccl_update): Remove; unused.
5958
5959 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5960 * category.h: ... from here.
5961 * category.c (check_category_table, set_category_set): Now static.
5962
5963 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5964 * lisp.h: Remove these decls.
5965
5966 * buffer.c (buffer_count): Remove unused var.
5967
5968 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5969 so that it's not optimized away.
5970 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5971 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5972 exported only to the debugger.
5973
5974 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5975 * atimer.h (run_all_atimers): Remove; not exported.
5976
5977 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5978 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5979 was inaccessible from Lisp.
5980 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5981 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5982
5983 alloc.c: Import and export fewer symbols, and remove unused items.
5984 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5985 is defined.
5986 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5987 it's not optimized away by whole-program optimization.
5988 (message_enable_multibyte, free_misc): Remove.
5989 (catchlist, handlerlist, mark_backtrace):
5990 Declare only if BYTE_MARK_STACK.
5991 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5992 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5993 (message_enable_multibyte): Remove decl.
5994 (free_misc, interval_free_list, float_block, float_block_index):
5995 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5996 (cons_free_list, last_marked_index):
5997 Now static.
5998 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5999 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6000 (mark_backtrace): Define only if BYTE_MARK_STACK.
6001 * xdisp.c (message_enable_multibyte): Now static.
6002
6003 Declare Lisp_Object Q* variables to be 'static' if not exported.
6004 This makes it easier for human readers (and static analyzers)
6005 to see whether these variables are used from other modules.
6006 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6007 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6008 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6009 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6010 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6011 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6012 * xmenu.c, xselect.c:
6013 Declare Q* vars static if they are not used in other modules.
6014 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6015 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6016 Remove decls of unexported vars.
6017 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6018
6019 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6020
6021 Make Emacs functions such as Fatom 'static' by default.
6022 This makes it easier for human readers (and static analyzers)
6023 to see whether these functions can be called from other modules.
6024 DEFUN now defines a static function. To make the function external
6025 so that it can be used in other C modules, use the new macro DEFUE.
6026 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6027 (Finit_image_library):
6028 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6029 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6030 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6031 Remove decls, since these functions are now static.
6032 (Funintern, Fget_internal_run_time): New decls, since these functions
6033 were already external.
6034
6035 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6036 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6037 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6038 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6039 * keyboard.c, keymap.c, lread.c:
6040 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6041 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6042 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6043 Mark functions with DEFUE instead of DEFUN,
6044 if they are used in other modules.
6045 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6046 decls for now-static functions.
6047 * buffer.h (Fdelete_overlay): Remove decl.
6048 * callproc.c (Fgetenv_internal): Mark as internal.
6049 * composite.c (Fremove_list_of_text_properties): Remove decl.
6050 (Fcomposition_get_gstring): New forward static decl.
6051 * composite.h (Fcomposite_get_gstring): Remove decl.
6052 * dired.c (Ffile_attributes): New forward static decl.
6053 * doc.c (Fdocumntation_property): New forward static decl.
6054 * eval.c (Ffetch_bytecode): New forward static decl.
6055 (Funintern): Remove extern decl; now in .h file where it belongs.
6056 * fileio.c (Fmake_symbolic_link): New forward static decl.
6057 * image.c (Finit_image_library): New forward static decl.
6058 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6059 * intervals.h (Fprevious_property_change):
6060 (Fremove_list_of_text_properties): Remove decls.
6061 * keyboard.c (Fthis_command_keys): Remove decl.
6062 (Fcommand_execute): New forward static decl.
6063 * keymap.c (Flookup_key): New forward static decl.
6064 (Fcopy_keymap): Now static.
6065 * keymap.h (Flookup_key): Remove decl.
6066 * process.c (Fget_process): New forward static decl.
6067 (Fprocess_datagram_address): Mark as internal.
6068 * syntax.c (Fsyntax_table_p): New forward static decl.
6069 (skip_chars): Remove duplicate decl.
6070 * textprop.c (Fprevious_property_change): New forward static decl.
6071 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6072 Now internal.
6073 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6074 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6075
6076 * editfns.c (Fformat): Remove unreachable code.
6077
6078 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6079
6080 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6081 change. (Bug#8496)
6082
6083 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6084
6085 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6086 when at ZV. (Bug#8487)
6087
6088 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6089
6090 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6091 (Bug#8437)
6092 * keyboard.c (parse_tool_bar_item): Likewise.
6093 * sound.c (sound_cleanup, alsa_close): Likewise.
6094 * termcap.c (tgetent): Likewise.
6095 * xfns.c (x_default_font_parameter): Likewise.
6096 * xsettings.c (read_and_apply_settings): Likewise.
6097
6098 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6099 (overrun_check_free): Protoize.
6100
6101 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6102
6103 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6104 since callers should never pass a negative size.
6105 Change the signature to match that of plain 'read' and 'write'; see
6106 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6107 * lisp.h: Update prototypes of emacs_write and emacs_read.
6108
6109 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6110
6111 * xdisp.c (redisplay_window): Don't try to determine the character
6112 position of the scroll margin if the window start point w->startp
6113 is outside the buffer's accessible region. (Bug#8468)
6114
6115 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6116
6117 Fix write-region and its subroutines for buffers > 2GB.
6118 * fileio.c (a_write, e_write): Modify declaration of arguments and
6119 local variables to support buffers larger than 2GB.
6120 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6121
6122 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6123 argument, local variables, and return value.
6124
6125 * lisp.h: Update prototypes of emacs_write and emacs_read.
6126
6127 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6128
6129 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6130
6131 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6132
6133 Fix more problems found by GCC 4.6.0's static checks.
6134
6135 * xdisp.c (vmessage): Use a better test for character truncation.
6136
6137 * charset.c (load_charset_map): <, not <=, for optimization,
6138 and to avoid potential problems with integer overflow.
6139 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6140 * casetab.c (set_identity, shuffle): Likewise.
6141 * editfns.c (Fformat): Likewise.
6142 * syntax.c (skip_chars): Likewise.
6143
6144 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6145 This also lets GCC 4.6.0 generate slightly better loop code.
6146
6147 * callint.c (Fcall_interactively): <, not <=, for optimization.
6148 (Fcall_interactively): Count the number of arguments produced,
6149 not the number of arguments given. This is simpler and lets GCC
6150 4.6.0 generate slightly better code.
6151
6152 * ftfont.c: Distingish more carefully between FcChar8 and char.
6153 The previous code passed unsigned char * to a functions like
6154 strlen and xstrcasecmp that expect char *, which does not
6155 conform to the C standard.
6156 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6157 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6158 char * when the C standard requires it.
6159
6160 * keyboard.c (read_char): Remove unused var.
6161
6162 * eval.c: Port to Windows vsnprintf (Bug#8435).
6163 Include <limits.h>.
6164 (SIZE_MAX): Define if the headers do not.
6165 (verror): Do not give up if vsnprintf returns a negative count.
6166 Instead, grow the buffer. This ports to Windows vsnprintf, which
6167 does not conform to C99. Problem reported by Eli Zaretskii.
6168 Also, simplify the allocation scheme, by avoiding the need for
6169 calling realloc, and removing the ALLOCATED variable.
6170
6171 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6172
6173 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6174 But keep the doprint source code for now, as we might revamp it
6175 and use it again (Bug#8435).
6176 * lisp.h (doprnt): Remove.
6177 * Makefile.in (base_obj): Remove doprnt.o.
6178 * deps.mk (doprnt.o): Remove.
6179
6180 error: Print 32- and 64-bit integers portably (Bug#8435).
6181 Without this change, on typical 64-bit hosts error ("...%d...", N)
6182 was used to print both 32- and 64-bit integers N, which relied on
6183 undefined behavior.
6184 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6185 New macro.
6186 * lisp.h (error, verror): Mark as printf-like functions.
6187 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6188 Report overflow in size calculations when allocating printf buffer.
6189 Do not truncate output string at its first null byte.
6190 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6191 Truncate the output at a character boundary, since vsnprintf does not
6192 do that.
6193 * charset.c (check_iso_charset_parameter): Convert internal
6194 character to string before calling 'error', since %c now has the
6195 printf meaning.
6196 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6197 overflow when computing char to be passed to 'error'. Do not
6198 pass Lisp_Object to 'error'; pass the integer instead.
6199 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6200 formatted with plain %d.
6201
6202 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6203
6204 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6205
6206 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6207
6208 * xterm.c (x_catch_errors): Remove duplicate declaration.
6209
6210 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6211
6212 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6213
6214 2011-04-10 Jim Meyering <meyering@redhat.com>
6215
6216 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6217 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6218 return ssize_t not "int", and use size_t as the buffer length.
6219 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6220 * gnutls.h: Update declarations.
6221 * process.c (read_process_output): Use ssize_t, to match.
6222 (send_process): Likewise.
6223
6224 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6225
6226 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6227
6228 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6229
6230 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6231 Use unsigned char, to match FcChar8 type definition.
6232
6233 * xterm.c (handle_one_xevent):
6234 * xmenu.c (create_and_show_popup_menu):
6235 * xselect.c (x_decline_selection_request)
6236 (x_reply_selection_request): Avoid type-punned deref of X events.
6237
6238 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6239
6240 Fix some uses of `int' instead of EMACS_INT.
6241 * search.c (string_match_1, fast_string_match)
6242 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6243 (scan_buffer, find_next_newline_no_quit)
6244 (find_before_next_newline, search_command, Freplace_match)
6245 (Fmatch_data): Make some `int' variables be EMACS_INT.
6246
6247 * xdisp.c (display_count_lines): 3rd argument and return value now
6248 EMACS_INT. All callers changed.
6249 (pint2hrstr): Last argument is now EMACS_INT.
6250
6251 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6252 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6253 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6254 (decode_coding_utf_16, decode_coding_emacs_mule)
6255 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6256 (decode_coding_ccl, decode_coding_charset)
6257 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6258 (decode_coding_iso_2022, decode_coding_emacs_mule)
6259 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6260 <char_offset, last_offset>: Declare EMACS_INT.
6261 (encode_coding_utf_8, encode_coding_utf_16)
6262 (encode_coding_emacs_mule, encode_invocation_designation)
6263 (encode_designation_at_bol, encode_coding_iso_2022)
6264 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6265 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6266 Declare EMACS_INT.
6267 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6268 (encode_invocation_designation): Last argument P_NCHARS is now
6269 EMACS_INT.
6270 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6271 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6272
6273 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6274 All users changed.
6275
6276 * ccl.c (Fccl_execute_on_string): Declare some variables
6277 EMACS_INT.
6278
6279 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6280
6281 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6282
6283 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6284
6285 * process.c (Fformat_network_address): Doc fix.
6286
6287 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6288
6289 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6290
6291 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6292
6293 * keyboard.c (read_char): Call Lisp function help-form-show,
6294 instead of using internal_with_output_to_temp_buffer.
6295 (Qhelp_form_show): New var.
6296 (syms_of_keyboard): Use DEFSYM macro.
6297
6298 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6299
6300 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6301
6302 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6303
6304 * process.c (Flist_processes): Remove to Lisp.
6305 (list_processes_1): Delete.
6306
6307 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6308
6309 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6310
6311 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6312
6313 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6314
6315 Fix more problems found by GCC 4.6.0's static checks.
6316
6317 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6318
6319 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6320
6321 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6322
6323 * xdisp.c (vmessage): Mark as a printf-like function.
6324
6325 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6326
6327 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6328
6329 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6330 printf-like functions.
6331 (tiff_load): Add casts to remove these marks before passing them
6332 to system-supplied API.
6333
6334 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6335
6336 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6337 This avoids several warnings with gcc -Wstrict-overflow.
6338 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6339 directly, rather than having caller test rule sign. This avoids
6340 some unnecessary tests.
6341 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6342 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6343 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6344
6345 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6346 (xfont_open): Avoid unnecessary tests.
6347
6348 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6349
6350 * composite.h, composite.c (composition_gstring_put_cache):
6351 Use EMACS_INT, not int, for length.
6352
6353 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6354 breaking out part of COMPOSITION_DECODE_RULE.
6355 (COMPOSITION_DECODE_RULE): Use it.
6356 * composite.c (get_composition_id): Remove unused local vars,
6357 by using the new macro.
6358
6359 * textprop.c (set_text_properties_1): Change while to do-while,
6360 since the condition is always true at first.
6361
6362 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6363 (interval_deletion_adjustment): Return unsigned value.
6364 All uses changed.
6365
6366 * process.c (list_processes_1, create_pty, read_process_output):
6367 (exec_sentinel): Remove vars that were set but not used.
6368 (create_pty): Remove unnecessary "volatile"s.
6369 (Fnetwork_interface_info): Avoid possibility of int overflow.
6370 (read_process_output): Do adaptive read buffering even if carryover.
6371 (read_process_output): Simplify nbytes computation if buffered.
6372
6373 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6374
6375 * syntax.c (scan_words): Remove var that was set but not used.
6376 (update_syntax_table): Use unsigned instead of int.
6377
6378 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6379 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6380 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6381
6382 * print.c (print_error_message): Avoid int overflow.
6383
6384 * font.c (font_list_entities): Redo for clarity,
6385 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6386
6387 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6388 (font_score): Avoid potential overflow in diff calculation.
6389
6390 * fns.c (substring_both): Remove var that is set but not used.
6391 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6392
6393 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6394
6395 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6396 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6397 can always succeed if overflow has undefined behavior.
6398
6399 * search.c (boyer_moore, wordify): Remove vars set but not used.
6400 (wordify): Omit three unnecessary tests.
6401
6402 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6403 All callers changed. This avoids the need for an unused var.
6404
6405 * casefiddle.c (casify_region): Remove var that is set but not used.
6406
6407 * dired.c (file_name_completion): Remove var that is set but not used.
6408
6409 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6410
6411 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6412 (Finsert_file_contents): Remove unnecessary code checking fd.
6413
6414 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6415 Check for integer overflow on size calculations.
6416
6417 * buffer.c (Fprevious_overlay_change): Remove var that is set
6418 but not used.
6419
6420 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6421 Remove vars that are set but not used.
6422 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6423 (timer_check_2): Mark vars as initialized.
6424
6425 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6426
6427 * image.c (lookup_image): Remove var that is set but not used.
6428 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6429
6430 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6431 that are set but not used.
6432
6433 * xfns.c (make_invisible_cursor): Don't return garbage
6434 if XCreateBitmapFromData fails (Bug#8410).
6435
6436 * xselect.c (x_get_local_selection, x_handle_property_notify):
6437 Remove vars that are set but not used.
6438
6439 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6440 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6441
6442 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6443 Remove var that is set but not used.
6444 (scroll_bar_windows_size): Now size_t, not int.
6445 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6446 Check for overflow.
6447
6448 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6449 (map_tty_color) [!defined MSDOS]: Likewise.
6450
6451 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6452
6453 * coding.c: Remove vars that are set but not used.
6454 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6455 All callers changed.
6456 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6457 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6458 (decode_coding_charset): Remove vars that are set but not used.
6459
6460 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6461 that is set but not used.
6462
6463 * print.c (print_object): Remove var that is set but not used.
6464
6465 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6466 The gnulib version avoids calling malloc in the usual case,
6467 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6468 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6469 * filelock.c (current_lock_owner): Likewise.
6470 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6471 * sysdep.c: Include allocator.h, careadlinkat.h.
6472 (emacs_no_realloc_allocator): New static constant.
6473 (emacs_readlink): New function.
6474 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6475 ../lib/careadlinkat.h.
6476
6477 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6478
6479 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6480 first non-nil return value).
6481
6482 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6483
6484 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6485 if not defined (Bug#8403).
6486
6487 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6488
6489 * xdisp.c (display_count_lines): Remove parameter `start',
6490 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6491 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6492 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6493 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6494 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6495 and thereabouts. All callers changed.
6496 (get_per_char_metric): Remove parameter `f', unused since
6497 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6498
6499 2011-04-02 Jim Meyering <meyering@redhat.com>
6500
6501 do not dereference NULL upon failed strdup
6502 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6503 (ns_get_family): Likewise.
6504
6505 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6506
6507 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6508
6509 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6510
6511 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6512 later (Bug#8403).
6513
6514 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6515
6516 Add lexical binding.
6517
6518 * window.c (Ftemp_output_buffer_show): New fun.
6519 (Fsave_window_excursion):
6520 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6521
6522 * lread.c (lisp_file_lexically_bound_p): New function.
6523 (Fload): Bind Qlexical_binding.
6524 (readevalloop): Remove `evalfun' arg.
6525 Bind Qinternal_interpreter_environment.
6526 (Feval_buffer): Bind Qlexical_binding.
6527 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6528 Mark as dynamic.
6529 (syms_of_lread): Declare `lexical-binding'.
6530
6531 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6532
6533 * keyboard.c (eval_dyn): New fun.
6534 (menu_item_eval_property): Use it.
6535
6536 * image.c (parse_image_spec): Use Ffunctionp.
6537
6538 * fns.c (concat, mapcar1): Accept byte-code-functions.
6539
6540 * eval.c (Fsetq): Handle lexical vars.
6541 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6542 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6543 (FletX, Flet): Obey lexical binding.
6544 (Fcommandp): Handle closures.
6545 (Feval): New `lexical' arg.
6546 (eval_sub): New function extracted from Feval. Use it almost
6547 everywhere where Feval was used. Look up vars in lexical env.
6548 Handle closures.
6549 (Ffunctionp): Move from subr.el.
6550 (Ffuncall): Handle closures.
6551 (apply_lambda): Remove `eval_flags'.
6552 (funcall_lambda): Handle closures and new byte-code-functions.
6553 (Fspecial_variable_p): New function.
6554 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6555 but without exporting it to Lisp.
6556
6557 * doc.c (Fdocumentation, store_function_docstring):
6558 * data.c (Finteractive_form): Handle closures.
6559
6560 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6561 interactive spec.
6562
6563 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6564 New byte-codes.
6565 (exec_byte_code): New function extracted from Fbyte_code to handle new
6566 calling convention for byte-code-functions. Add new byte-codes.
6567
6568 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6569
6570 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6571
6572 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6573
6574 * xdisp.c (redisplay_internal): Fix prototype.
6575
6576 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6577
6578 * xdisp.c (SCROLL_LIMIT): New macro.
6579 (try_scrolling): Use it when setting scroll_limit.
6580 Limit scrolling to 100 screen lines.
6581 (redisplay_window): Even when falling back on "recentering",
6582 position point in the window according to scroll-conservatively,
6583 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6584
6585 (try_scrolling): When point is above the window, allow searching
6586 as far as scroll_max, or one screenful, to compute vertical
6587 distance from PT to the scroll margin position. This prevents
6588 try_scrolling from unnecessarily failing when
6589 scroll-conservatively is set to a value slightly larger than the
6590 window height. Clean up the case of PT below the margin at bottom
6591 of window: scroll_max can no longer be INT_MAX. When aggressive
6592 scrolling is in use, don't let point enter the opposite scroll
6593 margin as result of the scroll.
6594 (syms_of_xdisp) <scroll-conservatively>: Document the
6595 threshold of 100 lines for never-recentering scrolling.
6596
6597 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6598
6599 * dispextern.h (move_it_by_lines):
6600 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6601 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6602 (message_log_check_duplicate): Remove parameters `prev_bol' and
6603 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6604 (redisplay_internal): Remove parameter `preserve_echo_area',
6605 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6606
6607 * indent.c (Fvertical_motion):
6608 * window.c (window_scroll_pixel_based, Frecenter):
6609 Don't pass `need_y_p' to `move_it_by_lines'.
6610
6611 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6612
6613 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6614 steal a few bits to be more compact.
6615 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6616 Remove unneeded casts.
6617
6618 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6619
6620 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6621
6622 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6623 binding" message (bug#7967).
6624
6625 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6626
6627 Fix more problems found by GCC 4.6.0's static checks.
6628
6629 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6630 Remove unused local var.
6631
6632 * editfns.c (Fmessage_box): Remove unused local var.
6633
6634 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6635 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6636 Omit unused local vars.
6637 * window.c (shrink_windows): Omit unused local var.
6638 * menu.c (digest_single_submenu): Omit unused local var.
6639 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6640 Omit unused local var.
6641
6642 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6643 Don't assume string length fits in int.
6644 (keyremap_step, read_key_sequence): Use size_t for sizes.
6645 (read_key_sequence): Don't check last_real_key_start redundantly.
6646
6647 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6648 instead of alloca (Bug#8344).
6649
6650 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6651 (Fbacktrace_frame): Don't assume nframes fits in int.
6652
6653 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6654
6655 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6656 concerns.
6657
6658 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6659
6660 * cm.c (calccost): Turn while-do into do-while, for clarity.
6661
6662 * keyboard.c (syms_of_keyboard): Use the same style as later
6663 in this function when indexing through an array. This also
6664 works around GCC bug 48267.
6665
6666 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6667
6668 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6669
6670 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6671 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6672
6673 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6674 This avoids undefined behavior on integer overflow, and is a bit
6675 more convenient anyway since it is compared to a size_t variable.
6676
6677 Variadic C functions now count arguments with size_t, not int.
6678 This avoids an unnecessary limitation on 64-bit machines, which
6679 caused (substring ...) to crash on large vectors (Bug#8344).
6680 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6681 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6682 All variadic functions and their callers changed accordingly.
6683 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6684 * data.c (arith_driver, float_arith_driver): Likewise.
6685 * editfns.c (general_insert_function): Likewise.
6686 * eval.c (struct backtrace.nargs, interactive_p)
6687 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6688 (funcall_lambda, mark_backtrace): Likewise.
6689 * fns.c (concat): Likewise.
6690 * frame.c (x_set_frame_parameters): Likewise.
6691 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6692 0 if not found, not -1. All callers changed.
6693
6694 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6695 (stack_copy_size): Now size_t, not int.
6696 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6697
6698 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6699
6700 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6701 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6702 All callers changed.
6703
6704 * lisp.h (multibyte_char_to_unibyte):
6705 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6706 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6707 * character.h (CHAR_TO_BYTE8):
6708 * cmds.c (internal_self_insert):
6709 * editfns.c (general_insert_function):
6710 * keymap.c (push_key_description):
6711 * search.c (Freplace_match):
6712 * xdisp.c (message_dolog, set_message_1): All callers changed.
6713
6714 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6715
6716 * keyboard.c (safe_run_hook_funcall): New function.
6717 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6718 don't set the hook to nil, but remove the offending function instead.
6719 (Qcommand_hook_internal): Remove, unused.
6720 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6721 Vcommand_hook_internal.
6722
6723 * eval.c (enum run_hooks_condition): Remove.
6724 (funcall_nil, funcall_not): New functions.
6725 (run_hook_with_args): Call each function through a `funcall' argument.
6726 Remove `cond' argument, now redundant.
6727 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6728 (Frun_hook_with_args_until_failure): Adjust accordingly.
6729 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6730
6731 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6732
6733 * dispextern.h (string_buffer_position): Remove declaration.
6734
6735 * print.c (strout): Remove parameter `multibyte', unused since
6736 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6737
6738 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6739 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6740 All callers changed.
6741
6742 * w32.c (_wsa_errlist): Use braces for struct initializers.
6743
6744 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6745 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6746 All callers changed.
6747 (string_buffer_position): Likewise. Also, make static (it's never
6748 used outside xdisp.c).
6749 (cursor_row_p): Remove parameter `w', unused since
6750 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6751 (decode_mode_spec): Remove parameter `precision', introduced during
6752 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6753 All callers changed.
6754
6755 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6756
6757 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6758
6759 2011-03-27 Anders Lindgren <andlind@gmail.com>
6760
6761 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6762 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6763 (ns_update_auto_hide_menu_bar): New functions.
6764 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6765 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6766 ns_constrain_all_frames.
6767 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6768 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6769
6770 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6771
6772 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6773
6774 2011-03-27 Glenn Morris <rgm@gnu.org>
6775
6776 * syssignal.h: Replace RETSIGTYPE with void.
6777 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6778 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6779 Replace SIGTYPE with void everywhere.
6780 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6781 * s/template.h (SIGTYPE): Remove commented out definition.
6782
6783 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6784
6785 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6786 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6787
6788 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6789
6790 * w32.c (read_unc_volume): Use parameter `henum', instead of
6791 global variable `wget_enum_handle'.
6792
6793 * keymap.c (describe_vector): Remove parameters `indices' and
6794 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6795 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6796
6797 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6798
6799 * keyboard.c (timer_check): Remove parameter `do_it_now',
6800 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6801 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6802 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6803
6804 * keyboard.c (read_char):
6805 * w32menu.c (w32_menu_display_help):
6806 * xmenu.c (show_help_event, menu_help_callback):
6807 Adjust calls to `show_help_echo'.
6808
6809 * gtkutil.c (xg_maybe_add_timer):
6810 * keyboard.c (readable_events):
6811 * process.c (wait_reading_process_output):
6812 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6813
6814 * insdel.c (adjust_markers_gap_motion):
6815 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6816 (gap_left, gap_right): Don't call it.
6817
6818 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6819
6820 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6821 incurred during fontification.
6822
6823 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6824
6825 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6826 (DEFVAR_PER_BUFFER): Don't pass it.
6827
6828 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6829 (scrolling_window): Don't pass it.
6830
6831 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6832
6833 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6834
6835 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6836 and `suffix'.
6837 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6838 of variables specific to SELinux and computation of `encoded_absname'.
6839
6840 * image.c (XPutPixel): Remove unused variable `height'.
6841
6842 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6843
6844 * unexw32.c (get_section_info): Remove unused variable `section'.
6845
6846 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6847 (system_process_attributes): Remove unused variable `sess'.
6848 (sys_read): Remove unused variable `err'.
6849
6850 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6851 (w32_wnd_proc): Remove unused variable `isdead'.
6852 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6853 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6854 (x_create_tip_frame): Remove unused variable `tem'.
6855
6856 * w32inevt.c (w32_console_read_socket):
6857 Remove unused variable `no_events'.
6858
6859 * w32term.c (x_draw_composite_glyph_string_foreground):
6860 Remove unused variable `width'.
6861
6862 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6863
6864 * w32term.c (x_set_glyph_string_clipping):
6865 Don't pass uninitialized region to CombineRgn.
6866
6867 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6868
6869 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6870 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6871 (Fx_close_connection): Remove unused variable `i'.
6872
6873 * w32font.c (w32font_draw): Return number of glyphs.
6874 (w32font_open_internal): Remove unused variable `i'.
6875 (w32font_driver): Add missing initializer.
6876
6877 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6878 (fill_in_menu): Remove unused variable `items_added'.
6879
6880 * w32term.c (last_mouse_press_frame): Remove static global variable.
6881 (w32_clip_to_row): Remove unused variable `f'.
6882 (x_delete_terminal): Remove unused variable `i'.
6883
6884 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6885 (NOTHING): Remove unused static global variable.
6886 (uniscribe_check_otf): Remove unused variable `table'.
6887 (uniscribe_font_driver): Add missing initializers.
6888
6889 2011-03-23 Julien Danjou <julien@danjou.info>
6890
6891 * term.c (Fsuspend_tty, Fresume_tty):
6892 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6893 * window.c (temp_output_buffer_show):
6894 * insdel.c (signal_before_change):
6895 * frame.c (Fhandle_switch_frame):
6896 * fileio.c (Fdo_auto_save):
6897 * emacs.c (Fkill_emacs):
6898 * editfns.c (save_excursion_restore):
6899 * cmds.c (internal_self_insert):
6900 * callint.c (Fcall_interactively):
6901 * buffer.c (Fkill_all_local_variables):
6902 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6903 Use Frun_hooks.
6904 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6905 unconditionnaly since it does the check itself.
6906
6907 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6908
6909 Fix more problems found by GCC 4.5.2's static checks.
6910
6911 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6912 the first time through the loop, since we know p0 < p1 then.
6913 This also avoids a gcc -Wstrict-overflow warning.
6914
6915 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6916 leading to a memory leak, possible in functions like
6917 load_charset_map_from_file that can allocate an unbounded number
6918 of objects (Bug#8318).
6919
6920 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6921 that could (at least in theory) be that large.
6922
6923 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6924 This is less likely to overflow, and avoids undefined behavior if
6925 overflow does occur. All callers changed. Use strtoul to scan
6926 for the unsigned long integer.
6927 (pint2hrstr): Simplify and tune code slightly.
6928 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6929
6930 * scroll.c (do_scrolling): Work around GCC bug 48228.
6931 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6932
6933 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6934 This also avoids a warning with gcc -Wstrict-overflow.
6935 (validate_x_resource_name): Simplify count usage.
6936 This also avoids a warning with gcc -Wstrict-overflow.
6937
6938 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6939 fail (Bug#8306).
6940
6941 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6942
6943 * process.c (Fmake_network_process): Use socklen_t, not int,
6944 where POSIX says socklen_t is required in portable programs.
6945 This fixes a porting bug on hosts like 64-bit HP-UX, where
6946 socklen_t is wider than int (Bug#8277).
6947 (Fmake_network_process, server_accept_connection):
6948 (wait_reading_process_output, read_process_output):
6949 Likewise.
6950
6951 * process.c: Rename or move locals to avoid shadowing.
6952 (list_processes_1, Fmake_network_process):
6953 (read_process_output_error_handler, exec_sentinel_error_handler):
6954 Rename or move locals.
6955 (Fmake_network_process): Define label "retry_connect" only if needed.
6956 (Fnetwork_interface_info): Fix pointer signedness.
6957 (process_send_signal): Add cast to avoid pointer signedness problem.
6958 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6959 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6960
6961 Make tparam.h and terminfo.c consistent.
6962 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6963 Include tparam.h instead, since it declares them.
6964 * cm.h (PC): Remove extern decl; tparam.h now does this.
6965 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6966 * terminfo.c: Include tparam.h, to check interfaces.
6967 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6968 (tparam): Adjust signature to match interface in tparam.h;
6969 this removes some undefined behavior. Check that outstring and len
6970 are zero, which they always are with Emacs.
6971 * tparam.h (PC, BC, UP): New extern decls.
6972
6973 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6974 (xftfont_open): Rename locals to avoid shadowing.
6975
6976 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6977 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6978 (OTF_TAG_SYM): Omit macro if not needed.
6979 (ftfont_list): Remove unused local.
6980 (get_adstyle_property, ftfont_pattern_entity):
6981 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6982 Rename locals to avoid shadowing.
6983
6984 * xfont.c (xfont_list_family): Mark var as initialized.
6985
6986 * xml.c (make_dom): Now static.
6987
6988 * composite.c (composition_compute_stop_pos): Rename local to
6989 avoid shadowing.
6990 (composition_reseat_it): Remove unused locals.
6991 (find_automatic_composition, composition_adjust_point): Likewise.
6992 (composition_update_it): Mark var as initialized.
6993 (find_automatic_composition): Mark vars as initialized,
6994 with a FIXME (Bug#8290).
6995
6996 character.h: Rename locals to avoid shadowing.
6997 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6998 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6999 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7000 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7001 to avoid shadowing.
7002
7003 * textprop.c (property_change_between_p): Remove; unused.
7004
7005 * intervals.c (interval_start_pos): Now static.
7006
7007 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7008
7009 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7010 Rename locals to avoid shadowing.
7011
7012 * sound.c (wav_play, au_play, Fplay_sound_internal):
7013 Fix pointer signedness.
7014 (alsa_choose_format): Remove unused local var.
7015 (wav_play): Initialize a variable to 0, to prevent undefined
7016 behavior (Bug#8278).
7017
7018 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7019
7020 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7021
7022 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7023 clobbering (Bug#8298).
7024 * sysdep.c (sys_subshell): Likewise.
7025 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7026
7027 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7028 This should get cleaned up, so that child_setup has the
7029 same signature on all platforms.
7030
7031 * callproc.c (call_process_cleanup): Now static.
7032 (relocate_fd): Rename locals to avoid shadowing.
7033
7034 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7035
7036 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7037 not to be necessary, and produces flickering.
7038
7039 2011-03-20 Glenn Morris <rgm@gnu.org>
7040
7041 * config.in: Remove file.
7042
7043 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7044
7045 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7046 are now in src/globals.h.
7047 (syms_of_minibuf): Remove spurious & from previous change.
7048
7049 2011-03-20 Leo <sdl.web@gmail.com>
7050
7051 * minibuf.c (completing-read-function): New variable.
7052 (completing-read-default): Rename from completing-read.
7053 (completing-read): Call completing-read-function.
7054
7055 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7056
7057 * xfaces.c (Fx_load_color_file):
7058 Read color file from absolute filename (bug#8250).
7059
7060 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7061
7062 * makefile.w32-in: Update dependencies.
7063
7064 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7065
7066 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7067
7068 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7069
7070 Fix more problems found by GCC 4.5.2's static checks.
7071
7072 * process.c (make_serial_process_unwind, send_process_trap):
7073 (sigchld_handler): Now static.
7074
7075 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7076 That way, the code declares only the vars that it needs.
7077 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7078 * s/cygwin.h (PTY_ITERATION): Likewise.
7079 * s/darwin.h (PTY_ITERATION): Likewise.
7080 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7081
7082 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7083 * process.c (allocate_pty): Don't declare stb unless it's needed.
7084
7085 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7086 (CONSTANTLIM): Remove; unused.
7087 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7088 Define only if needed.
7089
7090 * unexelf.c (unexec): Name an expression,
7091 to avoid gcc -Wbad-function-cast warning.
7092 Use a different way to cause a compilation error if anyone uses
7093 n rather than nn, a way that does not involve shadowing.
7094 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7095
7096 * deps.mk (unexalpha.o): Remove; unused.
7097
7098 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7099 * unexec.h: New file.
7100 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7101 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7102 Depend on unexec.h.
7103 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7104 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7105 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7106 Change as necessary to match prototype in unexec.h.
7107
7108 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7109 shadowing.
7110 (back_comment, skip_chars): Mark vars as initialized.
7111
7112 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7113 Rename locals to avoid shadowing.
7114
7115 * lread.c (read1): Rewrite so as not to use empty "else".
7116 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7117
7118 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7119
7120 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7121 warning when compiling print.c.
7122
7123 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7124 instead of using an uninitialized var.
7125 (font_sort_entities): Mark var as initialized.
7126
7127 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7128
7129 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7130 pointers to constants.
7131 (font_parse_fcname): Remove unused vars.
7132 (font_delete_unmatched): Now static.
7133 (font_get_spec): Remove; unused.
7134 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7135 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7136 Rename or move locals to avoid shadowing.
7137
7138 * fns.c (require_nesting_list, require_unwind): Now static.
7139 (Ffillarray): Rename locals to avoid shadowing.
7140
7141 * floatfns.c (domain_error2): Define only if needed.
7142 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7143
7144 * alloc.c (mark_backtrace): Move decl from here ...
7145 * lisp.h: ... to here, so that it can be checked.
7146
7147 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7148 (Fdefvar): Rewrite so as not to use empty "else".
7149 (lisp_indirect_variable): Name an expression,
7150 to avoid gcc -Wbad-function-cast warning.
7151 (Fdefvar): Rename locals to avoid shadowing.
7152
7153 * callint.c (quotify_arg, quotify_args): Now static.
7154 (Fcall_interactively): Rename locals to avoid shadowing.
7155 Use const pointer when appropriate.
7156
7157 * lisp.h (get_system_name, get_operating_system_release):
7158 Move decls here, to check interfaces.
7159 * process.c (get_operating_system_release): Move decl to lisp.h.
7160 * xrdb.c (get_system_name): Likewise.
7161 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7162 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7163 some of which prompt warnings from gcc -Wbad-function-cast.
7164 (Fformat_time_string, Fencode_time, Finsert_char):
7165 (Ftranslate_region_internal, Fformat):
7166 Rename or remove local vars to avoid shadowing.
7167 (Ftranslate_region_internal): Mark var as initialized.
7168
7169 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7170 avoid shadowing.
7171
7172 * lisp.h (eassert): Check that the argument compiles, even if
7173 ENABLE_CHECKING is not defined.
7174
7175 * data.c (Findirect_variable): Name an expression, to avoid
7176 gcc -Wbad-function-cast warning.
7177 (default_value, arithcompare, arith_driver, arith_error): Now static.
7178 (store_symval_forwarding): Rename local to avoid shadowing.
7179 (Fmake_variable_buffer_local, Fmake_local_variable):
7180 Mark variables as initialized.
7181 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7182
7183 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7184 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7185 Rename locals to avoid shadowing.
7186 (mark_stack): Move local variables into the #ifdef region where
7187 they're used.
7188 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7189 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7190 needed otherwise.
7191 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7192 (GC_STRING_CHARS): Remove; not used.
7193 (Fmemory_limit): Cast sbrk's returned value to char *.
7194
7195 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7196 avoids undefined behavior in theory.
7197
7198 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7199
7200 Use functions, not macros, for up- and down-casing (Bug#8254).
7201 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7202 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7203 to use the following functions instead of these macros.
7204 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7205 EMACS_INT, since callers assume the returned value fits in int.
7206 (upcase1): Likewise, for UPCASE_TABLE.
7207 (uppercasep, lowercasep, upcase): New static inline functions.
7208 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7209 the race-condition problem in the old DOWNCASE.
7210
7211 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7212 Rename locals to avoid shadowing.
7213 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7214 (regex_compile, re_search_2, re_match_2_internal):
7215 Remove unused local vars.
7216 (FREE_VAR): Rewrite so as not to use empty "else",
7217 which gcc can warn about.
7218 (regex_compile, re_match_2_internal): Mark locals as initialized.
7219 (RETALLOC_IF): Define only if needed.
7220 (WORDCHAR_P): Likewise. This one is never needed, but is used
7221 only in a comment talking about a compiler bug, so put inside
7222 the #if 0 of that comment.
7223 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7224 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7225 Remove; unused.
7226
7227 * search.c (boyer_moore): Rename locals to avoid shadowing.
7228 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7229 (PREV_CHAR_BOUNDARY): Likewise.
7230
7231 * search.c (simple_search): Remove unused var.
7232
7233 * dired.c (compile_pattern): Move decl from here ...
7234 * lisp.h: ... to here, so that it can be checked.
7235 (struct re_registers): New forward decl.
7236
7237 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7238
7239 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7240 All uses changed.
7241 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7242 Rename locals to avoid shadowing.
7243 (Fvertical_motion): Mark locals as initialized.
7244
7245 * casefiddle.c (casify_object, casify_region): Now static.
7246 (casify_region): Mark local as initialized.
7247
7248 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7249
7250 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7251 New macros, so that the caller can use some names other than
7252 gcpro1, gcpro2, etc.
7253 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7254 of the new macros.
7255 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7256 argument, for consistency with GCPRO2_VAR, etc: it is now the
7257 prefix of the variable, not the variable itself. All uses
7258 changed.
7259 * dired.c (directory_files_internal, file_name_completion):
7260 Rename locals to avoid shadowing.
7261
7262 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7263 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7264 dired.c's scmp function, had undefined behavior.
7265 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7266 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7267 * buffer.h: ... to here, because these macros use current_buffer,
7268 and the new implementation with inline functions needs to have
7269 current_buffer in scope now, rather than later when the macros
7270 are used.
7271 (downcase, upcase1): New static inline functions.
7272 (DOWNCASE, UPCASE1): Reimplement using these functions.
7273 This avoids undefined behavior in expressions like
7274 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7275 from race conditions in accessing the global variables
7276 case_temp1 and case_temp2.
7277 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7278 * lisp.h (case_temp1, case_temp2): Remove their decls.
7279 * character.h (ASCII_CHAR_P): Move from here ...
7280 * lisp.h: ... to here, so that the inline functions mentioned
7281 above can use them.
7282
7283 * dired.c (directory_files_internal_unwind): Now static.
7284
7285 * fileio.c (file_name_as_directory, directory_file_name):
7286 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7287 Now static.
7288 (file_name_as_directory): Use const pointers when appropriate.
7289 (Fexpand_file_name): Likewise. In particular, newdir might
7290 point at constant storage, so make it a const pointer.
7291 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7292 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7293 signedness issues.
7294 (Fset_file_times, Finsert_file_contents, auto_save_error):
7295 Rename locals to avoid shadowing.
7296
7297 * minibuf.c (choose_minibuf_frame_1): Now static.
7298 (Ftry_completion, Fall_completions): Rename or remove locals
7299 to avoid shadowing.
7300
7301 * marker.c (bytepos_to_charpos): Remove; unused.
7302
7303 * lisp.h (verify_bytepos, count_markers): New decls,
7304 so that gcc does not warn that these functions aren't declared.
7305
7306 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7307 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7308 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7309 (copy_text): Remove unused local var.
7310
7311 * filelock.c (within_one_second): Now static.
7312 (lock_file_1): Rename local to avoid shadowing.
7313
7314 * buffer.c (fix_overlays_before): Mark locals as initialized.
7315 (fix_start_end_in_overlays): Likewise. This function should be
7316 simplified by using pointers-to-pointers, but that's a different
7317 matter.
7318 (switch_to_buffer_1): Now static.
7319 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7320 (report_overlay_modification): Rename locals to avoid shadowing.
7321
7322 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7323 Fix pointer signedness issue.
7324 (sys_subshell): Mark local as volatile if checking for lint,
7325 to suppress a gcc -Wclobbered warning that does not seem to be right.
7326 (MAXPATHLEN): Define only if needed.
7327
7328 * process.c (serial_open, serial_configure): Move decls from here ...
7329 * systty.h: ... to here, so that they can be checked.
7330
7331 * fns.c (get_random, seed_random): Move extern decls from here ...
7332 * lisp.h: ... to here, so that they can be checked.
7333
7334 * sysdep.c (reset_io): Now static.
7335 (wait_for_termination_signal): Remove; unused.
7336
7337 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7338 (copy_keymap_item, append_key, push_text_char_description):
7339 Now static.
7340 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7341 (DENSE_TABLE_SIZE): Remove; unused.
7342 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7343 (describe_map_tree):
7344 Rename locals to avoid shadowing.
7345
7346 * keyboard.c: Declare functions static if they are not used elsewhere.
7347 (echo_char, echo_dash, cmd_error, top_level_2):
7348 (poll_for_input, handle_async_input): Now static.
7349 (read_char, kbd_buffer_get_event, make_lispy_position):
7350 (make_lispy_event, make_lispy_movement, apply_modifiers):
7351 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7352 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7353 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7354 (read_key_sequence, read_char): Mark locals as initialized.
7355 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7356
7357 * keyboard.h (make_ctrl_char): New decl.
7358 (mark_kboards): Move decl here ...
7359 * alloc.c (mark_kboards): ... from here.
7360
7361 * lisp.h (force_auto_save_soon): New decl.
7362
7363 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7364 (DEFINE_DUMMY_FUNCTION): New macro.
7365 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7366 Use it.
7367 (main): Add casts to avoid warnings
7368 if GCC considers string literals to be constants.
7369
7370 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7371
7372 * dbusbind.c: Pointer signedness fixes.
7373 (xd_signature, xd_append_arg, xd_initialize):
7374 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7375 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7376 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7377 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7378
7379 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7380 if GCC considers string literals to be constants.
7381 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7382
7383 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7384
7385 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7386 (print_preprocess, print_object): New macro to fix last change.
7387
7388 * print.c (print_preprocess): Don't forget font objects.
7389
7390 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7391
7392 * emacs.c (USAGE3): Doc fixes.
7393
7394 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7395
7396 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7397 structure.
7398
7399 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7400
7401 * lisp.h (VWindow_system, Qfile_name_history):
7402 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7403 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7404 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7405
7406 * w32select.c: Don't #include "keyboard.h".
7407 (run_protected): Add extern declaration for waiting_for_input.
7408
7409 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7410 * w32console.c (detect_input_pending, read_input_pending)
7411 (encode_terminal_code):
7412 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7413 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7414 (w32_system_caret_y, Qfile_name_history):
7415 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7416 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7417 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7418 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7419 * w32proc.c (Qlocal, report_file_error):
7420 * w32term.c (Vwindow_system, updating_frame):
7421 * w32uniscribe.c (initialized, uniscribe_font_driver):
7422 Remove unneeded extern declarations.
7423
7424 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7425
7426 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7427
7428 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7429
7430 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7431 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7432 These macros can no longer be used for assignment.
7433
7434 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7435 Assign struct members directly, instead of using BUF_BEGV etc.
7436 (record_buffer_markers, fetch_buffer_markers): New functions for
7437 recording and fetching special buffer markers.
7438 (set_buffer_internal_1, set_buffer_temp): Use them.
7439
7440 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7441
7442 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7443
7444 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7445 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7446
7447 * xdisp.c (hscroll_window_tree):
7448 (reconsider_clip_changes): Use PT instead of BUF_PT.
7449
7450 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7451
7452 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7453 $(EMACS_ROOT)/lib/intprops.h.
7454
7455 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7456
7457 Fix more problems found by GCC 4.5.2's static checks.
7458
7459 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7460 to unsigned char * to avoid compiler diagnostic.
7461 (xg_free_frame_widgets): Make it clear that a local variable is
7462 needed only if USE_GTK_TOOLTIP.
7463 (gdk_window_get_screen): Make it clear that this macro is needed
7464 only if USE_GTK_TOOLTIP.
7465 (int_gtk_range_get_value): New function, which avoids a diagnostic
7466 from gcc -Wbad-function-cast.
7467 (xg_set_toolkit_scroll_bar_thumb): Use it.
7468 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7469 diagnostic from gcc -Wbad-function-cast.
7470 (get_utf8_string, xg_get_file_with_chooser):
7471 Rename locals to avoid shadowing.
7472 (create_dialog): Move locals to avoid shadowing.
7473
7474 * xgselect.c (xg_select): Remove unused var.
7475
7476 * image.c (four_corners_best): Mark locals as initialized.
7477 (gif_load): Initialize transparent_p to zero (Bug#8238).
7478 Mark another local as initialized.
7479 (my_png_error, my_error_exit): Mark with NO_RETURN.
7480
7481 * image.c (clear_image_cache): Now static.
7482 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7483 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7484 (x_edge_detection): Remove unnecessary cast that
7485 gcc -Wbad-function-cast diagnoses.
7486 (gif_load): Fix pointer signedness.
7487 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7488 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7489
7490 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7491
7492 Improve quality of tests for time stamp overflow.
7493 For example, without this patch (encode-time 0 0 0 1 1
7494 1152921504606846976) returns the obviously-bogus value (-948597
7495 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7496 reports time overflow. See
7497 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7498 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7499 * editfns.c: Include limits.h and intprops.h.
7500 (TIME_T_MIN, TIME_T_MAX): New macros.
7501 (time_overflow): Move earlier, to before first use.
7502 (hi_time, lo_time): New functions, for an accurate test for
7503 out-of-range times.
7504 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7505 (Fget_internal_run_time): Don't assume time_t fits in int.
7506 (make_time): Use list2 instead of Fcons twice.
7507 (Fdecode_time): More accurate test for out-of-range times.
7508 (check_tm_member): New function.
7509 (Fencode_time): Use it, to test for out-of-range times.
7510 (lisp_time_argument): Don't rely on undefined left-shift and
7511 right-shift behavior when checking for time stamp overflow.
7512
7513 * editfns.c (time_overflow): New function, refactoring common code.
7514 (Fformat_time_string, Fdecode_time, Fencode_time):
7515 (Fcurrent_time_string): Use it.
7516
7517 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7518 * dired.c (make_time): Move to ...
7519 * editfns.c (make_time): ... here.
7520 * systime.h: Note the move.
7521
7522 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7523
7524 * fringe.c (update_window_fringes): Remove unused variables.
7525
7526 * unexmacosx.c (copy_data_segment): Also copy __got section.
7527 (Bug#8223)
7528
7529 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7530
7531 * termcap.c [MSDOS]: Include "msdos.h".
7532 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7533 Constify `char *' arguments and their references according to
7534 prototypes in tparam.h.
7535
7536 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7537
7538 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7539 Adapt all references accordingly.
7540
7541 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7542
7543 2011-03-11 Tom Tromey <tromey@redhat.com>
7544
7545 * buffer.c (syms_of_buffer): Remove obsolete comment.
7546
7547 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7548
7549 * termhooks.h (encode_terminal_code): Declare prototype.
7550
7551 * msdos.c (encode_terminal_code): Don't declare prototype.
7552
7553 * term.c (encode_terminal_code): Now external again, used by
7554 w32console.c and msdos.c.
7555
7556 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7557 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7558
7559 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7560
7561 Fix some minor problems found by GCC 4.5.2's static checks.
7562
7563 * fringe.c (update_window_fringes): Mark locals as initialized
7564 (Bug#8227).
7565 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7566
7567 * alloc.c (mark_fringe_data): Move decl from here ...
7568 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7569 to check its interface.
7570 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7571
7572 * fontset.c (free_realized_fontset): Now static.
7573 (Fset_fontset_font): Rename local to avoid shadowing.
7574 (fontset_font): Mark local as initialized.
7575 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7576
7577 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7578
7579 * xselect.c (x_disown_buffer_selections): Remove; not used.
7580 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7581 (x_own_selection, Fx_disown_selection_internal): Rename locals
7582 to avoid shadowing.
7583 (x_handle_dnd_message): Remove local to avoid shadowing.
7584
7585 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7586 so that the caller can use some name other than gcpro1.
7587 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7588 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7589 (Fx_backspace_delete_keys_p):
7590 Use them to avoid shadowing, and rename vars to avoid shadowing.
7591 (x_decode_color, x_set_name, x_window): Now static.
7592 (Fx_create_frame): Add braces to silence GCC warning.
7593 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7594 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7595 Remove unused locals.
7596 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7597 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7598 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7599 macros.
7600
7601 * xterm.h (x_mouse_leave): New decl.
7602
7603 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7604 Remove unused functions.
7605 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7606 (x_calc_absolute_position): Now static.
7607 (XTread_socket): Don't define label "out" unless it's used.
7608 Don't declare local "event" unless it's used.
7609 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7610 unless they are used.
7611 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7612 (x_fatal_error_signal): Remove; not used.
7613 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7614 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7615 (x_error_catcher, x_connection_closed, x_error_handler):
7616 (x_error_quitter, xembed_send_message, x_iconify_frame):
7617 (my_log_handler): Rename locals to avoid shadowing.
7618 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7619 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7620
7621 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7622 Rename or move locals to avoid shadowing.
7623 (tty_defined_color, merge_face_heights): Now static.
7624 (free_realized_faces_for_fontset): Remove; not used.
7625 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7626 does not deduce is never used uninitialized.
7627 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7628 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7629
7630 * terminal.c (store_terminal_param): Now static.
7631
7632 * xmenu.c (menu_highlight_callback): Now static.
7633 (set_frame_menubar): Remove unused local.
7634 (xmenu_show): Rename parameter to avoid shadowing.
7635 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7636 since they might point to immutable storage.
7637 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7638 since it's unused otherwise.
7639
7640 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7641 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7642 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7643 avoids a gcc -Wuninitialized diagnostic.
7644 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7645 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7646 does not deduce are never used uninitialized.
7647
7648 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7649
7650 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7651 * window.c (window_loop, size_window):
7652 (run_window_configuration_change_hook, enlarge_window): Likewise.
7653
7654 * window.c (display_buffer): Now static.
7655 (size_window): Mark variables that gcc -Wuninitialized
7656 does not deduce are never used uninitialized.
7657 * window.h (check_all_windows): New decl, to forestall
7658 gcc -Wmissing-prototypes diagnostic.
7659 * dispextern.h (bidi_dump_cached_states): Likewise.
7660
7661 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7662 shadowing.
7663 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7664 Include <limits.h>.
7665 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7666 and to avoid gcc -Wuninitialized warning.
7667 (load_charset_map): Mark variables that gcc -Wuninitialized
7668 does not deduce are never used uninitialized.
7669 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7670
7671 * coding.c (coding_set_source, coding_set_destination):
7672 Use "else { /* comment */ }" rather than "else /* comment */;"
7673 for clarity, and to avoid gcc -Wempty-body warning.
7674 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7675 a block, when the outer 'i' will do.
7676 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7677 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7678 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7679 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7680 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7681 Rename locals to avoid shadowing.
7682 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7683 * coding.c (emacs_mule_char, encode_invocation_designation):
7684 Now static, since they're not used elsewhere.
7685 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7686 (decode_coding_object, encode_coding_object, detect_coding_system):
7687 (decode_coding_emacs_mule): Mark variables that gcc
7688 -Wuninitialized does not deduce are never used uninitialized.
7689 (detect_coding_iso_2022): Initialize a local variable that might
7690 be used uninitialized. Leave a FIXME because it's not clear that
7691 this initialization is needed. (Bug#8211)
7692 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7693 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7694 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7695 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7696 Remove unused macros.
7697
7698 * category.c (hash_get_category_set): Remove unused local var.
7699 (copy_category_table): Now static, since it's not used elsewhere.
7700 * character.c (string_count_byte8): Likewise.
7701
7702 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7703 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7704
7705 * chartab.c (copy_sub_char_table): Now static, since it's not used
7706 elsewhere.
7707 (sub_char_table_ref_and_range, char_table_ref_and_range):
7708 Rename locals to avoid shadowing.
7709 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7710
7711 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7712 (BIDI_BOB): Remove unused macro.
7713
7714 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7715 deduce are never used uninitialized.
7716 * term.c (encode_terminal_code): Likewise.
7717
7718 * term.c (encode_terminal_code): Now static. Remove unused local.
7719
7720 * tparam.h: New file.
7721 * term.c, tparam.h: Include it.
7722 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7723 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7724 Move these decls to tparam.h, and make them agree with what
7725 is actually in tparam.c. The previous trick of using incompatible
7726 decls in different modules does not conform to the C standard.
7727 All callers of tparam changed to use tparam's actual API.
7728 * tparam.c (tparam1, tparam, tgoto):
7729 Use const pointers where appropriate.
7730
7731 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7732 * cm.h (struct cm): Likewise.
7733 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7734 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7735 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7736 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7737 (turn_on_face, init_tty): Likewise.
7738 * termchar.h (struct tty_display_info): Likewise.
7739
7740 * term.c (term_mouse_position): Rename local to avoid shadowing.
7741
7742 * alloc.c (mark_ttys): Move decl from here ...
7743 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7744
7745 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7746
7747 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7748
7749 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7750
7751 * search.c (compile_pattern_1): Remove argument regp, unused since
7752 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7753 (compile_pattern): Don't pass it.
7754
7755 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7756
7757 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7758 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7759 for ! HAVE_GTK3.
7760 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7761
7762 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7763
7764 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7765 gdk_window_get_screen, gdk_window_get_geometry,
7766 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7767 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7768 (xg_get_pixbuf_from_pixmap): New function.
7769 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7770 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7771 Call xg_get_pixbuf_from_pixmap instead of
7772 gdk_pixbuf_get_from_drawable.
7773 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7774 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7775 (xg_check_special_colors): Use GtkStyleContext and its functions
7776 for HAVE_GTK3.
7777 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7778 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7779 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7780 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7781 Call gtk_widget_get_preferred_size.
7782 (xg_frame_resized): gdk_window_get_geometry only takes 5
7783 parameters.
7784 (xg_win_to_widget, xg_event_is_for_menubar):
7785 Call gdk_x11_window_lookup_for_display.
7786 (xg_set_widget_bg): New function.
7787 (delete_cb): New function.
7788 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7789 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7790 (xg_set_background_color): Call xg_set_widget_bg.
7791 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7792 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7793 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7794 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7795 if ! HAVE_GTK3.
7796 (update_frame_tool_bar): Call gtk_widget_hide.
7797 (xg_initialize): Use GDK_KEY_g.
7798
7799 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7800 if ! HAVE_GTK3
7801 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7802
7803 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7804 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7805 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7806
7807 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7808
7809 * w32xfns.c (select_palette): Check success of RealizePalette against
7810 GDI_ERROR, not zero.
7811
7812 See ChangeLog.11 for earlier changes.
7813
7814 ;; Local Variables:
7815 ;; coding: utf-8
7816 ;; End:
7817
7818 Copyright (C) 2011 Free Software Foundation, Inc.
7819
7820 This file is part of GNU Emacs.
7821
7822 GNU Emacs is free software: you can redistribute it and/or modify
7823 it under the terms of the GNU General Public License as published by
7824 the Free Software Foundation, either version 3 of the License, or
7825 (at your option) any later version.
7826
7827 GNU Emacs is distributed in the hope that it will be useful,
7828 but WITHOUT ANY WARRANTY; without even the implied warranty of
7829 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7830 GNU General Public License for more details.
7831
7832 You should have received a copy of the GNU General Public License
7833 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.