1 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5 candidate is selected by the mouse, and that candidate has a
6 composed character under the mouse.
8 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9 coordinates reported by pos-visible-in-window-p for a composed
10 character in column zero.
12 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
14 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
16 2011-08-22 Eli Zaretskii <eliz@gnu.org>
18 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
19 consider it a hit if to_charpos is anywhere in the range of the
20 composed buffer positions.
22 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
24 * image.c (gif_load): Don't assume that each subimage has the same
25 dimensions as the base image. Handle disposal method that is
26 "undefined" by the gif spec (Bug#9335).
28 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
30 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
31 (Fcondition_case): Document `debug' symbol in error handler.
33 2011-08-19 Eli Zaretskii <eliz@gnu.org>
35 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
36 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
37 from an Org mode buffer to a Speedbar frame.
39 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
40 a composition, take its buffer position from IT->cmp_it.charpos.
41 Fixes cursor positioning at the beginning of a line that begins
42 with a composed character.
44 2011-08-18 Eli Zaretskii <eliz@gnu.org>
46 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
47 character bidirectional type, use STRONG_L instead. Fixes crashes
48 in a buffer produced by `describe-categories'.
50 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
51 members before the level stack, so they would be saved and
52 restored when copying iterator state. Fixes incorrect reordering
53 around TABs covered by display properties.
55 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
57 * process.c (Fnetwork_interface_list): Correctly determine buffer
60 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
62 * eval.c (internal_condition_case, internal_condition_case_1)
63 (internal_condition_case_2, internal_condition_case_n):
64 Remove unnecessary aborts (Bug#9081).
66 2011-08-17 Eli Zaretskii <eliz@gnu.org>
68 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
69 has no `load' handler, try opening the file locally. (Bug#9311)
71 2011-08-16 Ken Brown <kbrown@cornell.edu>
73 * gmalloc.c: Expand comment.
75 2011-08-16 Eli Zaretskii <eliz@gnu.org>
77 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
78 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
80 2011-08-16 Ken Brown <kbrown@cornell.edu>
82 Fix memory allocation problems in Cygwin build (Bug#9273).
84 * unexcw.c ( __malloc_initialized): Declare external variable.
85 (fixup_executable): Force the dumped emacs to reinitialize malloc.
87 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
89 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
91 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
93 [CYGWIN] (special_realloc): New function.
94 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
95 requests to realloc storage in the static heap.
97 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
99 * bidi.c (bidi_initialize): Remove unused local.
101 2011-08-15 Eli Zaretskii <eliz@gnu.org>
103 * biditype.h: File removed.
105 * bidimirror.h: File removed.
107 * deps.mk (bidi.o): Remove biditype.h and
110 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
113 * dispextern.h: Fix a typo in the comment to bidi_type_t.
115 * chartab.c: Improve commentary for the uniprop_table API.
117 * bidi.c (bidi_paragraph_init): Support zero value of
118 bidi_ignore_explicit_marks_for_paragraph_level.
119 (bidi_initialize): Use uniprop_table instead of including
120 biditype.h and bidimirror.h.
122 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
123 coordinates of the iterator when restoring from ppos_it.
126 2011-08-14 Kenichi Handa <handa@m17n.org>
128 * process.c (create_process): Call setup_process_coding_systems
129 after the pid of the process is set to -1 (Bug#8162).
131 2011-08-14 Eli Zaretskii <eliz@gnu.org>
133 * xdisp.c (move_it_in_display_line_to): Don't invoke
134 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
135 ppos_it. Fixes vertical cursor motion when line beginning is
136 covered by an image. (Bug#9296)
138 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
140 * nsterm.h (ns_run_ascript): Declare.
141 (NSAPP_DATA2_RUNASSCRIPT): Define.
143 * nsfns.m (as_script, as_result, as_status): New static variables.
144 (ns_run_ascript): New function.
145 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
146 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
147 the event loop. Get status from as_status (Bug#7276).
149 * nsterm.m (sendEvent): If event is NSApplicationDefined and
150 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
151 the event loop (Bug#7276).
153 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
155 * gnutls.c (QCgnutls_bootprop_priority)
156 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
157 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
158 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
159 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
160 (QCgnutls_bootprop_verify_hostname_error)
161 (QCgnutls_bootprop_callbacks_verify): Rename from
162 Qgnutls_bootprop_..., all uses changed.
164 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
167 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
169 * xfaces.c (Qframe_set_background_mode): Now static.
170 * dispextern.h (Qframe_set_background_mode): Remove decl.
172 * process.c (Fnetwork_interface_info): Declare local only if needed.
174 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
176 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
177 (Fnetwork_interface_list): Allocate in increments of bytes instead
178 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
179 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
181 (struct ifflag_def): notrailers is smart on OSX.
182 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
183 Get hardware address with getifaddrs if available.
185 2011-08-12 Eli Zaretskii <eliz@gnu.org>
187 * xdisp.c (iterate_out_of_display_property): xassert that
188 IT->position is set to within IT->object's boundaries. Break from
189 the loop as soon as EOB is reached; avoids infloops in redisplay
190 when IT->position is set up wrongly due to some bug.
191 Set IT->current to match the bidi iterator unconditionally.
192 (push_display_prop): Allow GET_FROM_STRING as IT->method on
193 entry. Force push_it to save on the stack the current
194 buffer/string position, to be restored by pop_it. Fix flags in
195 the iterator structure wrt the object coming from a display
196 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
197 properties. (Bug#9284)
199 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
201 * fontset.c (fontset_get_font_group): Add proper type checks.
204 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
206 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
207 and LC_VERSION_MIN_MACOSX.
208 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
209 (dump_it) [LC_FUNCTION_STARTS]: Use it.
211 2011-08-08 Eli Zaretskii <eliz@gnu.org>
213 * xdisp.c (forward_to_next_line_start): Allow to use the
214 no-display-properties-and-no-overlays under bidi display.
215 Set disp_pos in the bidi iterator to avoid searches for display
216 properties and overlays.
218 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
220 * editfns.c (Fset_time_zone_rule): Document relationship with the
223 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
224 the font entity extracted from the cache (Bug#8109).
226 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
228 * composite.c (autocmp_chars): Don't reset point. That is done by
229 restore_point_unwind (Bug#5984).
231 2011-08-07 Juri Linkov <juri@jurta.org>
233 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
234 to show the arg `TIME' instead of `TIMEVAL'.
236 2011-08-06 Eli Zaretskii <eliz@gnu.org>
238 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
239 display property strides EOL and includes a newline, as in
240 longlines-mode. (Bug#9254)
241 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
242 word-wrap under bidirectional display. (Bug#9224)
244 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
245 is non-zero, even if the data buffer is NULL. Fixes a crash in
246 vertical-motion with longlines-mode. (Bug#9254)
248 2011-08-05 Eli Zaretskii <eliz@gnu.org>
250 * bidi.c <bidi_cache_total_alloc>: Now static.
251 (bidi_initialize): Initialize bidi_cache_total_alloc.
253 * xdisp.c (display_line): Release buffer allocated for shelved bidi
256 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
257 amount allocated this far in `bidi_cache_total_alloc'.
258 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
259 non-zero, only free the data buffer without restoring the cache
260 contents. All callers changed.
262 * dispextern.h (bidi_unshelve_cache): Update prototype.
264 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
265 (move_it_in_display_line, move_it_to)
266 (move_it_vertically_backward, move_it_by_lines): Replace the call
267 to xfree to an equivalent call to bidi_unshelve_cache.
268 (move_it_in_display_line_to): Fix logic of returning
269 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
271 2011-08-05 Eli Zaretskii <eliz@gnu.org>
273 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
274 came from a string character with a `cursor' property. (Bug#9229)
276 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
278 * Makefile.in (LIB_PTHREAD): New variable.
279 (LIBES): Add LIB_PTHREAD (Bug#9216).
281 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
282 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
284 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
286 * regex.c (re_iswctype): Remove some redundant boolean
289 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
291 * xterm.c (x_find_topmost_parent): New function.
292 (x_set_frame_alpha): Find topmost parent window with
293 x_find_topmost_parent and set the property there also (bug#9181).
294 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
296 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
298 * callproc.c (Fcall_process): Avoid vfork clobbering
299 the local vars buffer, coding_systems, current_dir.
301 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
303 * keymap.c (Fmake_composed_keymap): Move to subr.el.
305 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
307 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
308 so that it is not optimized away.
310 * xdisp.c (compute_display_string_pos): Remove unused local.
312 2011-08-02 Eli Zaretskii <eliz@gnu.org>
314 Fix slow cursor motion and scrolling in large buffers with
315 selective display, like Org Mode buffers. (Bug#9218)
317 * dispextern.h (struct bidi_it): New member disp_prop_p.
319 * xdisp.c: Remove one-slot cache of display string positions.
320 (compute_display_string_pos): Accept an additional argument
321 DISP_PROP_P; callers changed. Scan at most 5K characters forward
322 for a display string or property. If found, set DISP_PROP_P
325 * bidi.c (bidi_fetch_char): Accept an additional argument
326 DISP_PROP_P, and pass it to compute_display_string_pos.
327 Only handle text covered by a display string if DISP_PROP_P is returned
328 non-zero. All callers of bidi_fetch_char changed.
330 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
332 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
334 2010-12-03 Don March <don@ohspite.net>
336 * keymap.c (Fdefine_key): Fix non-prefix key error message when
337 last character M-[char] is translated to ESC [char] (bug#7541).
339 2011-08-02 Kenichi Handa <handa@m17n.org>
341 * lisp.h (uniprop_table): Extern it.
343 * chartab.c (uniprop_table): Make it non-static.
345 2011-08-01 Eli Zaretskii <eliz@gnu.org>
347 * xdisp.c (forward_to_next_line_start): Accept additional argument
348 BIDI_IT_PREV, and store into it the state of the bidi iterator had
350 (reseat_at_next_visible_line_start): Use the bidi iterator state
351 returned by forward_to_next_line_start to restore the state of
352 it->bidi_it after backing up to previous newline. (Bug#9212)
354 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
356 * regex.c (re_comp): Protoize.
357 (re_exec): Fix return type.
358 (regexec): Fix type of `ret'. (Bug#9203)
360 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
362 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
363 This is needed if max-image-size is a floating-point number.
365 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
367 * print.c (print_object): Print empty symbol as ##.
369 * lread.c (read1): Read ## as empty symbol.
371 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
373 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
374 setting frame foreground color (Bug#9175).
375 (x_set_background_color): Likewise.
377 * nsmenu.m (-setText): Size tooltip dimensions precisely to
379 (EmacsTooltip -init): Remove bezels and add shadows to
382 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
383 or scroll bar (Bug#8470).
385 * nsfont.m (nsfont_open): Remove assignment to voffset and
386 unnecessary vars hshink, expand, hd, full_height, min_height.
387 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
389 * nsterm.h (nsfont_info): Remove voffset field.
391 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
393 Implement strike-through and overline on NextStep (Bug#8863).
395 * nsfont.m (nsfont_open): Use underline position provided by font,
396 instead of hard-coded value of 2.
397 (nsfont_draw): Call ns_draw_text_decoration instead.
399 * nsterm.h: Add declaration for ns_draw_text_decoration.
401 * nsterm.m (ns_draw_text_decoration): New function for drawing
402 underline, overline, and strike-through.
403 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
404 ns_draw_text_decoration. Change treatment of cursor drawing to
405 accomodate underlining, etc.
407 2011-07-28 Eli Zaretskii <eliz@gnu.org>
409 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
412 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
414 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
415 Without this fix, if a signal arrives just after memory fills up,
416 'malloc' might be invoked reentrantly.
418 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
419 In other words, assume that every image size is allowed, on non-X
420 hosts. This assumption is probably wrong, but it lets Emacs compile.
422 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
424 * regex.c (re_iswctype): Convert return values to boolean.
426 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
428 * xdisp.c (compute_display_string_pos): Don't use cached display
429 string position if the buffer had its restriction changed.
432 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
434 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
436 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
438 Integer signedness and overflow and related fixes. (Bug#9079)
440 * bidi.c: Integer size and overflow fixes.
441 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
442 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
443 (bidi_cache_find_level_change, bidi_cache_ensure_space)
444 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
445 (bidi_find_other_level_edge):
446 Use ptrdiff_t instead of EMACS_INT where either will do.
447 This works better on 32-bit hosts configured --with-wide-int.
448 (bidi_cache_ensure_space): Check for size-calculation overflow.
449 Use % rather than repeated addition, for better worst-case speed.
450 Don't set bidi_cache_size until after xrealloc returns, because it
452 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
453 (bidi_cache_ensure_space): Also check that the bidi cache size
454 does not exceed that of the largest Lisp string or buffer. See Eli
455 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
457 * alloc.c (__malloc_size_t): Remove.
458 All uses replaced by size_t. See Andreas Schwab's note
459 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
461 * image.c: Improve checking for integer overflow.
462 (check_image_size): Assume that f is nonnull, since
463 it is always nonnull in practice. This is one less thing to
464 worry about when checking for integer overflow later.
465 (x_check_image_size): New function, which checks for integer
466 overflow issues inside X.
467 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
468 This removes the need for a memory_full check.
469 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
470 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
471 (xbm_read_bitmap_data): Change locals back to 'int', since
472 their values must fit in 'int'.
473 (xpm_load_image, png_load, tiff_load):
474 Invoke x_create_x_image_and_pixmap earlier,
475 to avoid much needless work if the image is too large.
476 (tiff_load): Treat overly large images as if
477 x_create_x_image_and_pixmap failed, not as malloc failures.
478 (gs_load): Use x_check_image_size.
480 * gtkutil.c: Omit integer casts.
481 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
482 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
484 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
486 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
487 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
488 would wrongly return t on a 64-bit host.
490 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
491 The plain *_OVERFLOW macros run afoul of GCC bug 49705
492 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
493 and therefore cause GCC to emit a bogus diagnostic in some cases.
495 * image.c: Integer signedness and overflow and related fixes.
496 This is not an exhaustive set of fixes, but it's time to
497 record what I've got.
498 (lookup_pixel_color, check_image_size): Remove redundant decls.
499 (check_image_size): Don't assume that arbitrary EMACS_INT values
500 fit in 'int', or that arbitrary 'double' values fit in 'int'.
501 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
502 (tiff_load, imagemagick_load_image):
503 Check for overflow in size calculations.
504 (x_create_x_image_and_pixmap): Remove unnecessary test for
505 xmalloc returning NULL; that can't happen.
506 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
507 (xpm_color_bucket): Use better integer hashing function.
508 (xpm_cache_color): Don't possibly over-allocate memory.
509 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
511 Use ptrdiff_t, not int or size_t, to record sizes.
512 (png_load): Don't assume values greater than 2**31 fit in 'int'.
513 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
514 either works, as we prefer signed integers.
515 (tiff_read_from_memory, tiff_write_from_memory):
516 Return tsize_t, not size_t, since that's what the TIFF API wants.
517 (tiff_read_from_memory): Don't fail simply because the read would
518 go past EOF; instead, return a short read.
519 (tiff_load): Omit no-longer-needed casts.
520 (Fimagemagick_types): Don't assume size fits into 'int'.
522 Improve hashing quality when configured --with-wide-int.
523 * fns.c (hash_string): New function, taken from sxhash_string.
524 Do not discard information about ASCII character case; this
525 discarding is no longer needed.
526 (sxhash-string): Use it. Change sig to match it. Caller changed.
527 * lisp.h: Declare it.
528 * lread.c (hash_string): Remove, since we now use fns.c's version.
529 The fns.c version returns a wider integer if --with-wide-int is
530 specified, so this should help the quality of the hashing a bit.
532 * emacs.c: Integer overflow minor fix.
533 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
534 Define only if GNU_LINUX.
535 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
537 * dispnew.c: Integer signedness and overflow fixes.
538 Remove unnecessary forward decls, that were a maintenance hassle.
539 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
541 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
542 (scrolling_window): Use ptrdiff_t, not int, for byte count.
543 (prepare_desired_row, line_draw_cost):
544 Use int, not unsigned, where either works.
545 (save_current_matrix, restore_current_matrix):
546 Use ptrdiff_t, not size_t, where either works.
547 (init_display): Check for overflow more accurately, and without
548 relying on undefined behavior.
550 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
551 Remove, replacing with the new symbols in lisp.h. All uses changed.
552 * fileio.c (make_temp_name):
553 * filelock.c (lock_file_1, lock_file):
554 * xdisp.c (message_dolog):
555 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
556 Use pMd etc. instead.
557 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
558 replacing the pWIDE etc. symbols removed from editfns.c.
560 * keyboard.h (num_input_events): Now uintmax_t.
561 This is (very slightly) less likely to mess up due to wraparound.
564 * buffer.c: Integer signedness fixes.
565 (alloc_buffer_text, enlarge_buffer_text):
566 Use ptrdiff_t rather than size_t when either will do, as we prefer
569 * alloc.c: Integer signedness and overflow fixes.
570 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
571 (__malloc_size_t): Default to size_t, not to int.
572 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
573 (Fgarbage_collect, mark_object_loop_halt, mark_object):
574 Prefer ptrdiff_t to size_t when either would do, as we prefer
576 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
577 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
578 Now const. Initialize with values that are in range even if char
580 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
581 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
582 These functions do the right thing with sizes > 2**32.
583 (check_depth): Now ptrdiff_t, not int.
584 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
585 Adjust to new way of storing sizes. Check for size overflow bugs
587 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
588 slightly wrong anyway, as it missed one instance of
589 XMALLOC_OVERRUN_CHECK_OVERHEAD.
590 (refill_memory_reserve): Omit needless cast to size_t.
591 (mark_object_loop_halt): Mark as externally visible.
593 * xselect.c: Integer signedness and overflow fixes.
594 (Fx_register_dnd_atom, x_handle_dnd_message):
595 Use ptrdiff_t, not size_t, since we prefer signed.
596 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
597 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
598 x_dnd_atoms_size and x_dnd_atoms_length.
600 * doprnt.c: Prefer signed to unsigned when either works.
604 * xdisp.c (vmessage):
605 Use ptrdiff_t, not size_t, when using or implementing doprnt,
606 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
607 prefer signed arithmetic to avoid comparison confusion.
608 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
611 Assume freestanding C89 headers, string.h, stdlib.h.
612 * data.c, doprnt.c, floatfns.c, print.c:
613 Include float.h unconditionally.
614 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
615 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
616 * regex.c: Likewise for stddef.h, string.h.
617 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
618 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
619 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
620 (STDC_HEADERS): Remove obsolete defines.
621 * sysdep.c: Include limits.h unconditionally.
623 Assume support for memcmp, memcpy, memmove, memset.
624 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
625 * regex.c (memcmp, memcpy):
626 Remove; we assume C89 now.
628 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
629 (__malloc_safe_bcopy): Remove; no longer needed.
631 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
632 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
633 well either way, and we prefer signed to unsigned.
635 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
637 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
638 closes the connection while we're reading (bug#9182).
640 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
642 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
643 are specified (Bug#9168).
645 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
647 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
648 Found by GCC static checking and --with-wide-int on a 32-bit host.
650 2011-07-25 Eli Zaretskii <eliz@gnu.org>
652 * xdisp.c (compute_display_string_pos): Fix logic of caching
653 previous display string position. Initialize cached_prev_pos to
654 -1. Fixes slow-down at the beginning of a buffer.
656 2011-07-24 Eli Zaretskii <eliz@gnu.org>
658 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
659 for attrs[LFACE_FONTSET_INDEX].
661 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
663 * xml.c (parse_region): Remove unused local
664 that was recently introduced.
666 2011-07-23 Eli Zaretskii <eliz@gnu.org>
668 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
669 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
671 * xdisp.c (move_it_in_display_line_to): Record the best matching
672 position for TO_CHARPOS while scanning the line, and restore it on
673 exit if none of the characters scanned was an exact match.
674 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
675 when exact match is impossible due to invisible text, and the
678 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
680 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
683 2011-07-22 Eli Zaretskii <eliz@gnu.org>
685 Fix a significant slow-down of cursor motion with C-n, C-p,
686 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
687 auto-repeat under bidi redisplay in fontified buffers.
688 * xdisp.c (compute_stop_pos_backwards): New function.
689 (next_element_from_buffer): Call compute_stop_pos_backwards to
690 find a suitable prev_stop when we find ourselves before
692 (reseat): Don't look for prev_stop, as that could mean a very long
694 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
695 <cached_disp_overlay_modiff>: Cache for last found display string
697 (compute_display_string_pos): Return the cached position if asked
698 about the same buffer in the same area of character positions, and
699 the buffer wasn't changed since the time the display string
702 2011-07-22 Eli Zaretskii <eliz@gnu.org>
704 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
705 is an integer, which is important for empty lines. (Bug#9149)
707 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
709 * frame.c (Fmodify_frame_parameters): In tty case, update the
710 default face if necessary (Bug#4238).
712 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
714 * editfns.c (Fstring_to_char): No need to explain what a character
715 is in the docstring (Bug#6576).
717 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
719 * xml.c (parse_region): Make sure we always return a tree.
721 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
723 * xml.c (parse_region): If a document contains only comments,
726 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
728 * xml.c (make_dom): Return comments, too.
730 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
733 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
734 and the surrounding thread.
735 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
736 rather than fgets, and retry after EINTR. Otherwise, 'emacs
737 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
739 * s/openbsd.h (BROKEN_SIGIO): Define.
740 * unexelf.c (unexec) [__OpenBSD__]:
741 Don't update the .mdebug section of the Alpha COFF symbol table.
743 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
745 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
748 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
750 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
751 This fixes some race conditions on the permissions of any newly
754 * alloc.c (valid_pointer_p): Use pipe, not open.
755 This fixes some permissions issues when debugging.
757 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
758 If fchown fails to set both uid and gid, try to set just gid,
759 as that is sometimes allowed. Adjust the file's mode to eliminate
760 setuid or setgid bits that are inappropriate if fchown fails.
762 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
764 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
765 to compare Lisp_Objects.
766 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
767 global_gnutls_log_level, don't mistake it for a Lisp_Object.
768 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
770 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
772 * lread.c (read_integer): Unread even EOF character.
773 (read1): Likewise. Properly record start position of symbol.
775 * lread.c (read1): Read `#:' as empty uninterned symbol if no
776 symbol character follows.
778 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
780 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
781 This works around a problem with the previous change to Fcopy_file.
782 Recent glibc declares fchown with __attribute__((warn_unused_result)),
783 and without this change, GCC might complain about discarding
784 fchown's return value.
786 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
788 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
790 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
792 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
794 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
796 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
797 it's used from the C level.
799 * process.c: Use the same condition for POLL_FOR_INPUT in both
800 keyboard.c and process.c (bug#1858).
802 2011-07-09 Lawrence Mitchell <wence@gmx.li>
804 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
805 (Fgnutls_boot): Use it.
807 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
809 * doc.c (Fsubstitute_command_keys): Revert last change.
811 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
813 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
814 quotes the next character, and doesn't affect other longer
815 sequences (bug#8935).
817 * lread.c (syms_of_lread): Clarify that is isn't only
818 `eval-buffer' and `eval-defun' that's affected by
819 `lexical-binding' (bug#8460).
821 2011-07-15 Eli Zaretskii <eliz@gnu.org>
823 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
824 bidi redisplay when a line includes both an image and is
827 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
829 Fix minor problems found by static checking.
830 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
831 (elsz): Now a signed constant, not a size_t var. We prefer signed
832 types to unsigned, to avoid integer comparison confusion. Without
833 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
834 "cannot optimize loop, the loop counter may overflow", a symptom
836 * indent.c (Fvertical_motion): Mark locals as initialized.
837 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
839 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
841 * search.c (Fre_search_backward): Mention `case-fold-search' in
842 all the re_search_* functions (bug#8138).
844 * keyboard.c (Fopen_dribble_file): Document when the file is
847 2011-07-14 Eli Zaretskii <eliz@gnu.org>
849 * bidi.c (bidi_dump_cached_states): Fix format of displaying
852 Support bidi reordering of display and overlay strings.
853 * xdisp.c (compute_display_string_pos)
854 (compute_display_string_end): Accept additional argument STRING.
855 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
856 (reseat_to_string): Initialize bidi_it->string.s and
857 bidi_it->string.schars.
858 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
859 NULL (avoids a crash in bidi_paragraph_init).
860 Initialize itb.string.lstring.
861 (init_iterator): Call bidi_init_it only of a valid
862 buffer position was specified. Initialize paragraph_embedding to
864 (reseat_to_string): Initialize the bidi iterator.
865 (display_string): If we need to ignore text properties of
866 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
867 original value of -1 will not work with bidi.)
868 (compute_display_string_pos): First arg is now struct
869 `text_pos *'; all callers changed. Support display properties on
871 (compute_display_string_end): Support display properties on Lisp
873 (init_iterator, reseat_1, reseat_to_string): Initialize the
874 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
875 when iterating on a string not from display properties).
876 (compute_display_string_pos, compute_display_string_end):
877 Fix calculation of the object to scan. Fixes an error when using
879 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
880 base_level_stop; instead, set base_level_stop to BEGV.
881 Fixes crashes in vertical-motion.
882 (next_element_from_buffer): Improve commentary for when
883 the iterator is before prev_stop.
884 (init_iterator): Initialize bidi_p from the default value of
885 bidi-display-reordering, not from buffer-local value. Use the
886 buffer-local value only if initializing for buffer iteration.
887 (handle_invisible_prop): Support invisible properties on strings
888 that are being bidi-reordered.
889 (set_iterator_to_next): Support bidi reordering of C strings and
891 (next_element_from_string): Support bidi reordering of Lisp
893 (handle_stop_backwards): Support Lisp strings as well.
894 (display_string): Support display of R2L glyph rows.
895 Use IT_STRING_CHARPOS when displaying from a Lisp string.
896 (init_iterator): Don't initialize it->bidi_p for strings
898 (reseat_to_string): Initialize it->bidi_p for strings here.
899 (next_element_from_string, next_element_from_c_string)
900 (next_element_from_buffer): Add xassert's for correspondence
901 between IT's object being iterated and it->bidi_it.string
903 (face_before_or_after_it_pos): Support bidi iteration.
904 (next_element_from_c_string): Handle the case of the first string
905 character that is not the first one in the visual order.
906 (get_visually_first_element): New function, refactored from common
907 parts of next_element_from_buffer, next_element_from_string, and
908 next_element_from_c_string.
909 (tool_bar_lines_needed, redisplay_tool_bar)
910 (display_menu_bar): Force left-to-right direction. Add a FIXME
911 comment for making that be controlled by a user option.
912 (push_it, pop_it): Save and restore the state of the
913 bidi iterator. Save and restore the bidi_p flag.
914 (pop_it): Iterate out of display property for string iteration as
916 (iterate_out_of_display_property): Support iteration over strings.
917 (handle_single_display_spec): Set up it->bidi_it for iteration
918 over a display string, and call bidi_init_it.
919 (handle_single_display_spec, next_overlay_string)
920 (get_overlay_strings_1, push_display_prop): Set up the bidi
921 iterator for displaying display or overlay strings.
922 (forward_to_next_line_start): Don't use the shortcut if
924 (back_to_previous_visible_line_start): If handle_display_prop
925 pushed the iterator stack, restore the internal state of the bidi
926 iterator by calling bidi_pop_it same number of times.
927 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
928 and we are bidi-iterating, don't decrement the iterator position;
929 instead, set the first_elt flag in the bidi iterator, to produce
931 (reseat_1): Remove redundant setting of string_from_display_prop_p.
932 (push_display_prop): xassert that we are iterating a buffer.
933 (push_it, pop_it): Save and restore paragraph_embedding member.
934 (handle_single_display_spec, next_overlay_string)
935 (get_overlay_strings_1, reseat_1, reseat_to_string)
936 (push_display_prop): Set up the `unibyte' member of bidi_it.string
937 correctly. Don't assume unibyte strings are not bidi-reordered.
938 (compute_display_string_pos)
939 (compute_display_string_end): Fix handling the case of C string.
940 (push_it, pop_it): Save and restore from_disp_prop_p.
941 (handle_single_display_spec, push_display_prop): Set the
942 from_disp_prop_p flag.
943 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
944 (pop_it): Call iterate_out_of_display_property only if we are
945 popping after iteration over a string that came from a display
946 property. Fix a typo in popping stretch info. Add an assertion
947 for verifying that the iterator position is in sync with the bidi
949 (handle_single_display_spec, get_overlay_strings_1)
950 (push_display_prop): Fix initialization of paragraph direction for
951 string when that of the parent object is not yet determined.
952 (reseat_1): Call bidi_init_it to resync the bidi
953 iterator with IT's position. (Bug#7616)
954 (find_row_edges): If ROW->start.pos gives position
955 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
956 (handle_stop, back_to_previous_visible_line_start, reseat_1):
957 Reset the from_disp_prop_p flag.
958 (SAVE_IT, RESTORE_IT): New macros.
959 (pos_visible_p, face_before_or_after_it_pos)
960 (back_to_previous_visible_line_start)
961 (move_it_in_display_line_to, move_it_in_display_line)
962 (move_it_to, move_it_vertically_backward, move_it_by_lines)
963 (try_scrolling, redisplay_window, display_line): Use them when
964 saving a temporary copy of the iterator and restoring it back.
965 (back_to_previous_visible_line_start, reseat_1)
966 (init_iterator): Empty the bidi cache "stack".
967 (move_it_in_display_line_to): If iterator ended up at
968 EOL, but we never saw any buffer positions smaller than
969 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
970 motion in bidi-reordered lines.
971 (move_it_in_display_line_to): Record prev_method and prev_pos
972 immediately before the call to set_iterator_to_next. Fixes cursor
973 motion in bidi-reordered lines with stretch glyphs and strings
974 displayed in margins. (Bug#8133) (Bug#8867)
975 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
977 (pos_visible_p): Support positions in bidi-reordered lines.
978 Save and restore bidi cache.
980 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
981 (bidi_paragraph_info): Delete unused struct.
982 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
983 (bidi_cache_start): New variable.
984 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
986 (bidi_cache_fetch_state, bidi_cache_search)
987 (bidi_cache_find_level_change, bidi_cache_iterator_state)
988 (bidi_cache_find, bidi_peek_at_next_level)
989 (bidi_level_of_next_char, bidi_find_other_level_edge)
990 (bidi_move_to_visually_next): Compare cache index with
991 bidi_cache_start rather than with zero.
992 (bidi_fetch_char): Accept new argument STRING; all callers
993 changed. Support iteration over a string. Support strings with
994 display properties. Support unibyte strings. Fix the type of
995 `len' according to what STRING_CHAR_AND_LENGTH expects.
996 (bidi_paragraph_init, bidi_resolve_explicit_1)
997 (bidi_resolve_explicit, bidi_resolve_weak)
998 (bidi_level_of_next_char, bidi_move_to_visually_next):
999 Support iteration over a string.
1000 (bidi_set_sor_type, bidi_resolve_explicit_1)
1001 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1002 can now be zero (for strings); special values 0 and -1 were
1003 changed to -1 and -2, respectively.
1004 (bidi_char_at_pos): New function.
1005 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1006 Call it instead of FETCH_MULTIBYTE_CHAR.
1007 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1008 initialized to valid values.
1009 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1011 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1012 the test for valid cached positions. Fix the logic for looking up
1013 the sentinel state in the cache. GCPRO the Lisp string we are
1015 (bidi_push_it, bidi_pop_it): New functions.
1016 (bidi_initialize): Initialize the bidi cache start stack pointer.
1017 (bidi_cache_ensure_space): New function, refactored from part of
1018 bidi_cache_iterator_state. Don't assume the required size is just
1019 one BIDI_CACHE_CHUNK away.
1020 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1021 (bidi_count_bytes, bidi_char_at_pos): New functions.
1022 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1023 always valid if bidi_cache_idx is valid.
1024 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1025 is valid if it's going to be used.
1026 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1027 (bidi_cache_fetch_state, bidi_cache_search)
1028 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1029 (bidi_cache_iterator_state, bidi_cache_find)
1030 (bidi_find_other_level_edge, bidi_cache_start_stack):
1031 All variables related to cache indices are now EMACS_INT.
1033 * dispextern.h (struct bidi_string_data): New structure.
1034 (struct bidi_it): New member `string'. Make flag members be 1-bit
1035 fields, and put them last in the struct.
1036 (compute_display_string_pos, compute_display_string_end):
1038 (bidi_push_it, bidi_pop_it): Add prototypes.
1039 (struct iterator_stack_entry): New members bidi_p,
1040 paragraph_embedding, and from_disp_prop_p.
1041 (struct it): Member bidi_p is now a bit field 1 bit wide.
1042 (bidi_shelve_cache, bidi_unshelve_cache):
1045 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1046 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1047 and vector-like objects.
1049 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1050 cache around display iteration.
1052 * window.c (Fwindow_end, window_scroll_pixel_based)
1053 (displayed_window_lines, Frecenter): Save and restore the bidi
1054 cache around display iteration.
1056 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1058 * editfns.c (Fdelete_region): Clarify the use of the named
1059 parameters (bug#6788).
1061 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1063 * indent.c (Fvertical_motion): Set and restore w->pointm when
1064 saving and restoring the window's buffer (Bug#9006).
1066 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1068 * editfns.c (Fstring_to_char): Clarify just what is returned
1069 (bug#6576). Text by Eli Zaretskii.
1071 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1073 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1075 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1077 * buffer.c (mmap_find): Fix a typo.
1079 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1081 Fix execution of x selection hooks.
1082 * xselect.c (Qx_lost_selection_functions)
1083 (Qx_sent_selection_functions): New vars.
1084 (syms_of_xselect): DEFSYM them.
1085 (x_handle_selection_request): Pass Qx_sent_selection_functions
1086 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1087 (x_handle_selection_clear,x_clear_frame_selections):
1088 Pass Qx_lost_selection_functions rather than
1089 Vx_lost_selection_functions to Frun_hook_with_args.
1091 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1093 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1094 The old code sometimes used this field without initializing it.
1096 * alloc.c (gc_sweep): Don't read past end of array.
1097 In theory, the old code could also have corrupted Emacs internals,
1098 though it'd be very unlikely.
1100 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1102 * character.c (Fcharacterp): Don't advertise optional ignored
1103 argument. (Bug#4026)
1105 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1107 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1110 * window.c (Fset_window_start): Doc fix (bug#4199).
1111 (Fset_window_hscroll): Ditto.
1113 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1115 Fix minor new problems caught by GCC 4.6.1.
1116 * term.c (init_tty): Remove unused local.
1117 * xsettings.c (store_monospaced_changed): Define this function only
1118 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1121 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1123 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1125 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1127 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1128 are the mini-buffer and the echo area (bug#3320).
1130 * term.c (init_tty): Remove support for supdup, c10 and perq
1131 terminals, which are no longer supported (bug#1482).
1133 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1135 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1137 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1139 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1140 for non-popups (Bug#3642).
1142 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1144 * alloc.c (reset_malloc_hooks): Protoize.
1145 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1146 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1147 * cm.c (losecursor): Likewise.
1148 * data.c (fmod): Likewise.
1149 * dispnew.c (swap_glyphs_in_rows): Likewise.
1150 * emacs.c (memory_warning_signal): Likewise.
1151 * floatfns.c (float_error): Likewise.
1152 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1153 (otf_open, font_otf_capability, generate_otf_features)
1154 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1156 * image.c (pbm_read_file): Likewise.
1157 * indent.c (string_display_width): Likewise.
1158 * intervals.c (check_for_interval, search_for_interval)
1159 (inc_interval_count, count_intervals, root_interval)
1160 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1161 * lread.c (defalias): Likewise.
1162 * ralloc.c (r_alloc_check): Likewise.
1163 * regex.c (set_image_of_range_1, set_image_of_range)
1164 (regex_grow_registers): Likewise.
1165 * sysdep.c (strerror): Likewise.
1166 * termcap.c (valid_filename_p, tprint, main): Likewise.
1167 * tparam.c (main): Likewise.
1168 * unexhp9k800.c (run_time_remap, save_data_space)
1169 (update_file_ptrs, read_header, write_header, calculate_checksum)
1170 (copy_file, copy_rest, display_header): Likewise.
1171 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1173 * xdisp.c (check_it): Likewise.
1174 * xfaces.c (register_color, unregister_color, unregister_colors):
1176 * xfns.c (print_fontset_result): Likewise.
1177 * xrdb.c (member, fatal, main): Likewise.
1179 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1181 Fix minor problems found by static checking (Bug#9031).
1182 * chartab.c (char_table_set_range, map_sub_char_table):
1183 Remove unused locals.
1184 (uniprop_table): Now static.
1185 * composite.c (_work_char): Remove unused static var.
1187 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1189 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1191 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1193 * gtkutil.c (qttip_cb): Remove code without function.
1195 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1197 * w32.c (pthread_sigmask): New stub.
1199 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1201 Use pthread_sigmask, not sigprocmask (Bug#9010).
1202 sigprocmask is portable only for single-threaded applications, and
1203 Emacs can be multi-threaded when it uses GTK.
1204 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1206 * callproc.c (Fcall_process):
1207 * process.c (create_process):
1208 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1209 Use pthread_sigmask, not sigprocmask.
1211 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1213 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1214 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1217 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1219 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1220 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1221 (xg_hide_tooltip): Fix comment.
1223 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1224 in registerServicesMenuSendTypes.
1225 (validRequestorForSendType): Don't check ns_return_types.
1227 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1230 2011-07-08 Jason Rumney <jasonr@gnu.org>
1232 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1233 frame struct members of non-existent frames (Bug#6284).
1235 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1237 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1238 variable firstTime not needed on OSX >= 10.6.
1239 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1240 >= 10.5. Use setKnobProportion, setDoubleValue.
1242 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1243 (MAC_OS_X_VERSION_10_5): Define if not defined.
1244 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1245 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1246 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1248 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1249 cString and lossyCString on OSX >= 10.4
1251 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1252 sizeToFit on OSX >= 10.2.
1254 * nsimage.m (allocInitFromFile): Don't use deprecated method
1255 bestRepresentationForDevice on OSX >= 10.6.
1257 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1260 * emacs.c: Declare unexec_init_emacs_zone.
1262 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1264 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1266 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1267 on svcsMenu (Bug#8842).
1269 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1271 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1273 * nsterm.m (QUTF8_STRING): Declare.
1274 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1275 (validRequestorForSendType): Return type is (id).
1276 Change indexOfObjectIdenticalTo to indexOfObject.
1277 Check if we have local selection before returning self (Bug#8842).
1278 (writeSelectionToPasteboard): Put local selection into paste board
1279 if we have a local selection (Bug#8842).
1280 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1282 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1283 (ns_get_local_selection): Declare.
1285 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1287 * keymap.c (describe_map_tree): Don't insert a double newline at
1288 the end of the buffer (bug#1169) and return whether we inserted
1291 * callint.c (Fcall_interactively): Change "reading args" to
1292 "providing args" to try to clarify what it does (bug#1010).
1294 2011-07-07 Kenichi Handa <handa@m17n.org>
1296 * composite.c (composition_compute_stop_pos): Ignore a static
1297 composition starting before CHARPOS (Bug#8915).
1299 * xdisp.c (handle_composition_prop): Likewise.
1301 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1303 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1306 2011-07-07 Kenichi Handa <handa@m17n.org>
1308 * character.h (unicode_category_t): New enum type.
1310 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1311 (Qchar_code_property_table): New variable.
1312 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1313 (UNIPROP_COMPRESSED_FORM_P): New macros.
1314 (char_table_ascii): Uncompress the compressed values.
1315 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1316 Uncompress the compressed values.
1317 (sub_char_table_ref_and_range): Likewise.
1318 (char_table_ref_and_range): Uncompress the compressed values.
1319 (sub_char_table_set): New arg is_uniprop. Callers changed.
1320 Uncompress the compressed values.
1321 (sub_char_table_set_range): Args changed. Callers changed.
1322 (char_table_set_range): Adjuted for the above change.
1323 (map_sub_char_table): Delete args default_val and parent. Add arg
1324 top. Give decoded values to a Lisp function.
1325 (map_char_table): Adjust for the above change. Give decoded
1326 values to a Lisp function. Gcpro more variables.
1327 (uniprop_table_uncompress)
1328 (uniprop_decode_value_run_length): New functions.
1329 (uniprop_decoder, uniprop_decoder_count): New variables.
1330 (uniprop_get_decoder, uniprop_encode_value_character)
1331 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1333 (uniprop_encoder, uniprop_encoder_count): New variables.
1334 (uniprop_get_encoder, uniprop_table)
1335 (Funicode_property_table_internal, Fget_unicode_property_internal)
1336 (Fput_unicode_property_internal): New functions.
1337 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1338 Sunicode_property_table_internal, Sget_unicode_property_internal,
1339 and Sput_unicode_property_internal. Defvar_lisp
1340 char-code-property-alist.
1342 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1343 Vunicode_category_table.
1345 * font.c (font_range): Adjust for the change of
1346 Vunicode_category_table.
1348 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1350 * m/iris4d.h: Remove file, move contents ...
1351 * s/irix6-5.h: ... here.
1353 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1355 Remove unportable assumption about struct layout (Bug#8884).
1356 * alloc.c (mark_buffer):
1357 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1358 (clone_per_buffer_values): Don't assume that
1359 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1360 This isn't true in general, and it's particularly not true
1361 if Emacs is configured with --with-wide-int.
1362 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1363 New macros, used in the buffer.c change.
1365 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1367 * xsettings.c: Use both GConf and GSettings if both are available.
1368 (store_config_changed_event): Add comment.
1369 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1370 (store_tool_bar_style_changed): New functions.
1371 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1372 (struct xsettings): Move font inside HAVE_XFT.
1373 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1374 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1375 Move inside HAVE_XFT.
1376 (something_changed_gsettingsCB): Rename from something_changedCB.
1377 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1379 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1380 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1381 (something_changed_gconfCB): Rename from something_changedCB.
1382 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1383 (parse_settings): Move check for font inside HAVE_XFT.
1384 (read_settings, apply_xft_settings): Add comment.
1385 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1386 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1387 call store_font_name_changed.
1388 (xft_settings_event): Add comment.
1389 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1390 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1391 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1392 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1393 (xsettings_initialize): Call init_gsettings last.
1394 (xsettings_get_system_font, xsettings_get_system_normal_font):
1397 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1399 Random fixes. E.g., (random) never returned negative values.
1400 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1401 subseconds part to the entropy, as that's a bit more random.
1402 Prefer signed to unsigned, since the signedness doesn't matter and
1403 in general we prefer signed. When given a limit, use a
1404 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1405 latter isn't right if USE_2_TAGS_FOR_INTS.
1406 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1407 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1409 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1411 * textprop.c (text_property_stickiness):
1412 Obey Vtext_property_default_nonsticky.
1413 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1414 * w32fns.c (syms_of_w32fns):
1415 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1417 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1419 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1420 This is more efficient than Ffile_directory_p and avoids a minor race.
1422 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1424 * buffer.c (Foverlay_put): Say what the return value is
1427 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1428 is a directory before asking whether to use the file name
1430 (barf_or_query_if_file_exists): Make the "File is a directory"
1431 error be more correct.
1433 * fns.c (Frequire): Remove the mention of the .gz files, since
1434 that's installation-specific, but keep the mention of
1435 `get-load-suffixes'.
1437 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1439 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1440 Report string overflow if the output is too long.
1442 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1444 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1445 (syms_of_gnutls): Remove duplicate DEFSYM for
1446 Qgnutls_bootprop_verify_hostname_error, an error for
1447 Qgnutls_bootprop_verify_error (which is no longer used).
1449 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1450 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1451 Also (re)move comments that are misplaced or no longer relevant.
1453 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1455 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1457 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1459 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1460 and background color parameters if they have been changed.
1462 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1464 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1466 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1468 * xsettings.c (SYSTEM_FONT): Define only when used.
1469 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1471 * keymap.c (access_keymap_1): Now static.
1473 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1475 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1476 leave any prefix arg for the up event (Bug#1586).
1478 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1480 * lread.c (syms_of_lread): Mention single symbols defined by
1481 `defvar' or `defconst' (bug#7154).
1483 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1484 (Frequire): Mention get-load-suffixes.
1486 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1488 * window.h (window): Remove clone_number slot.
1489 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1491 (make_parent_window, make_window, saved_window)
1492 (Fset_window_configuration, save_window_save): Don't deal with
1494 * buffer.c (Qclone_number): Remove declaration.
1495 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1497 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1499 Add multiple inheritance to keymaps.
1500 * keymap.c (Fmake_composed_keymap): New function.
1501 (Fset_keymap_parent): Simplify.
1502 (fix_submap_inheritance): Remove.
1503 (access_keymap_1): New function extracted from access_keymap to handle
1504 embedded parents and handle lists of maps.
1505 (access_keymap): Use it.
1506 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1507 (Fcopy_keymap): Handle embedded parents.
1508 (Fcommand_remapping, define_as_prefix): Simplify.
1509 (Fkey_binding): Simplify.
1510 (syms_of_keymap): Move minibuffer-local-completion-map,
1511 minibuffer-local-filename-completion-map,
1512 minibuffer-local-must-match-map, and
1513 minibuffer-local-filename-must-match-map to Elisp.
1514 (syms_of_keymap): Defsubr make-composed-keymap.
1515 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1516 (parse_menu_item): Trivial simplification.
1518 2011-07-01 Glenn Morris <rgm@gnu.org>
1520 * Makefile.in (SETTINGS_LIBS): Fix typo.
1522 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1524 * coding.c (Fencode_coding_string): Record the last coding system
1525 used, as the function doc string says (bug#8738).
1527 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1529 * xsettings.c (store_monospaced_changed): Take new font as arg and
1530 check for change against current_mono_font.
1531 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1532 (emacs_settings_constructor, emacs_settings_get_property)
1533 (emacs_settings_set_property, emacs_settings_class_init)
1534 (emacs_settings_init, gsettings_obj): Remove.
1535 (something_changedCB): New function for HAVE_GSETTINGS.
1536 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1537 with value as argument.
1538 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1539 g_settings_new (Bug#8967). Do not create gsettings_obj.
1540 Remove calls to g_settings_bind. Connect something_changedCB to
1543 * xgselect.c: Add defined (HAVE_GSETTINGS).
1544 (xgselect_initialize): Ditto.
1546 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1547 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1550 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1552 * eval.c (struct backtrace): Simplify and port the data structure.
1553 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1554 signed bit field, as this assumption is not portable and it makes
1555 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1556 "char debug_on_exit : 1" as this is not portable either; instead,
1557 use the portable "unsigned int debug_on_exit : 1". Remove unused
1558 member evalargs. Remove obsolete comments about cc bombing out.
1560 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1562 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1563 Let HAVE_GSETTINGS override HAVE_GCONF.
1564 (store_monospaced_changed): New function.
1565 (EMACS_SETTINGS): A new type derived from GObject to handle
1566 GSettings notifications.
1567 (emacs_settings_constructor, emacs_settings_get_property)
1568 (emacs_settings_set_property, emacs_settings_class_init):
1570 (gsettings_client, gsettings_obj): New variables.
1571 (GSETTINGS_SCHEMA): New define.
1572 (something_changedCB): Call store_monospaced_changed.
1573 (init_gsettings): New function.
1574 (xsettings_initialize): Call init_gsettings.
1575 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1578 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1581 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1583 * window.c (resize_root_window, grow_mini_window)
1584 (shrink_mini_window): Rename Qresize_root_window to
1585 Qwindow_resize_root_window and Qresize_root_window_vertically to
1586 Qwindow_resize_root_window_vertically.
1588 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1590 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1592 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1594 * makefile.w32-in: Redesign dependencies so they reflect more
1595 clearly which files are directly included by each source file,
1596 and not through other includes.
1598 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1600 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1601 (sort_overlays, overlay_strings): When an overlay's clone number
1602 matches the window's clone number process the overlay even if
1603 the overlay's window property doesn't match the current window.
1605 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1606 (Fwindow_hchild): Rename to Fwindow_left_child.
1607 (Fwindow_next): Rename to Fwindow_next_sibling.
1608 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1609 (resize_window_check): Rename to window_resize_check.
1610 (resize_window_apply): Rename to window_resize_apply.
1611 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1612 (Fdelete_other_windows_internal, resize_frame_windows)
1613 (Fsplit_window_internal, Fdelete_window_internal)
1614 (grow_mini_window, shrink_mini_window)
1615 (Fresize_mini_window_internal): Fix callers accordingly.
1617 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1619 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1620 (emacs_fixed_set_min_size): Remove.
1621 (emacs_fixed_new): Take frame as argument.
1623 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1624 (_EmacsFixedPrivate): Remove minwidth/height.
1625 Add struct frame *f.
1626 (emacs_fixed_init): Initialize priv->f.
1627 (get_parent_class, emacs_fixed_set_min_size): Remove.
1628 (emacs_fixed_new): Set priv->f to argument.
1629 (emacs_fixed_get_preferred_width)
1630 (emacs_fixed_get_preferred_height): Use min_width/height from
1631 frames size_hint to set minimum and natural (Bug#8919).
1632 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1633 and use min_width/height from frames size_hint to set
1634 min_width/height (Bug#8919).
1636 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1637 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1640 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1642 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1643 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1646 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1648 * process.c (wait_reading_process_output): Bypass select if
1649 waiting for a cell while ignoring keyboard input, and input is
1650 pending. Suggested by Jan Djärv (Bug#8869).
1652 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1654 Use gnulib's dup2 module instead of rolling our own.
1655 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1657 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1659 * dispnew.c (scrolling_window): Before scrolling, turn off a
1660 mouse-highlight in the window being scrolled.
1662 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1664 Move DEFSYM to lisp.h and use everywhere.
1666 * character.h (DEFSYM): Move declaration...
1667 * lisp.h (DEFSYM): ...here.
1673 * w32select.c: Don't include character.h.
1675 * alloc.c (syms_of_alloc):
1676 * buffer.c (syms_of_buffer):
1677 * bytecode.c (syms_of_bytecode):
1678 * callint.c (syms_of_callint):
1679 * casefiddle.c (syms_of_casefiddle):
1680 * casetab.c (init_casetab_once):
1681 * category.c (init_category_once, syms_of_category):
1682 * ccl.c (syms_of_ccl):
1683 * cmds.c (syms_of_cmds):
1684 * composite.c (syms_of_composite):
1685 * dbusbind.c (syms_of_dbusbind):
1686 * dired.c (syms_of_dired):
1687 * dispnew.c (syms_of_display):
1688 * doc.c (syms_of_doc):
1689 * editfns.c (syms_of_editfns):
1690 * emacs.c (syms_of_emacs):
1691 * eval.c (syms_of_eval):
1692 * fileio.c (syms_of_fileio):
1693 * fns.c (syms_of_fns):
1694 * frame.c (syms_of_frame):
1695 * fringe.c (syms_of_fringe):
1696 * insdel.c (syms_of_insdel):
1697 * keymap.c (syms_of_keymap):
1698 * lread.c (init_obarray, syms_of_lread):
1699 * macros.c (syms_of_macros):
1700 * msdos.c (syms_of_msdos):
1701 * print.c (syms_of_print):
1702 * process.c (syms_of_process):
1703 * search.c (syms_of_search):
1704 * sound.c (syms_of_sound):
1705 * syntax.c (init_syntax_once, syms_of_syntax):
1706 * terminal.c (syms_of_terminal):
1707 * textprop.c (syms_of_textprop):
1708 * undo.c (syms_of_undo):
1709 * w32.c (globals_of_w32):
1710 * window.c (syms_of_window):
1711 * xdisp.c (syms_of_xdisp):
1712 * xfaces.c (syms_of_xfaces):
1713 * xfns.c (syms_of_xfns):
1714 * xmenu.c (syms_of_xmenu):
1715 * xsettings.c (syms_of_xsettings):
1716 * xterm.c (syms_of_xterm): Use DEFSYM.
1718 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1720 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1722 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1724 Integer and buffer overflow fixes (Bug#8873).
1726 * print.c (printchar, strout): Check for string overflow.
1727 (PRINTPREPARE, printchar, strout):
1728 Don't set size unless allocation succeeds.
1730 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1731 for sizes. Check for string overflow more accurately.
1732 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1734 * macros.c: Integer and buffer overflow fixes.
1735 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1736 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1737 Use ptrdiff_t, not int, for sizes.
1738 Don't increment bufsize until after realloc succeeds.
1739 Check for size-calculation overflow.
1740 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1742 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1744 * lread.c: Integer overflow fixes.
1745 (read_integer): Radix is now EMACS_INT, not int,
1746 to improve quality of diagnostics for out-of-range radices.
1747 Calculate buffer size correctly for out-of-range radices.
1748 (read1): Check for integer overflow in radices, and in
1749 read-circle numbers.
1750 (read_escape): Avoid int overflow.
1751 (Fload, openp, read_buffer_size, read1)
1752 (substitute_object_recurse, read_vector, read_list, map_obarray):
1753 Use ptrdiff_t, not int, for sizes.
1754 (read1): Use EMACS_INT, not int, for sizes.
1755 Check for size overflow.
1757 * image.c (cache_image): Check for size arithmetic overflow.
1759 * lread.c: Integer overflow issues.
1760 (saved_doc_string_size, saved_doc_string_length)
1761 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1762 Now ptrdiff_t, not int.
1763 (read1): Don't assume doc string length fits in int. Check for
1764 out-of-range doc string lengths.
1765 (read_list): Don't assume file position fits in int.
1766 (read_escape): Check for hex character overflow.
1768 2011-06-22 Leo Liu <sdl.web@gmail.com>
1770 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1771 Move to minibuffer.el.
1773 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1775 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1776 The following patches are for when GLYPH_DEBUG && !XASSERT.
1777 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1778 * dispnew.c (flush_stdout):
1779 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1780 Mark as externally visible.
1781 * dispnew.c (check_window_matrix_pointers): Now static.
1782 * dispnew.c (window_to_frame_vpos):
1783 * xfns.c (unwind_create_frame):
1784 * xterm.c (x_check_font): Remove unused local.
1785 * scroll.c (CHECK_BOUNDS):
1786 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1787 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1788 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1789 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1790 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1792 (debug_method_add): Use va_list and vsprintf rather than relying
1793 on undefined behavior with wrong number of arguments.
1794 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1795 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1796 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1797 since we're not interested in debugging glyphs with old libraries.
1798 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1799 GCC 4.6.0's static checking.
1801 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1803 Integer overflow and signedness fixes (Bug#8873).
1804 A few related buffer overrun fixes, too.
1806 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1808 * dispextern.h (struct face.stipple):
1809 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1810 (x_bitmap_mask, x_allocate_bitmap_record)
1811 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1812 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1813 (x_create_bitmap_from_xpm_data):
1814 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1815 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1817 * xfaces.c (load_pixmap):
1818 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1819 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1820 (.bitmaps_last, struct x_output.icon_bitmap):
1821 Use ptrdiff_t, not int, for bitmap indexes.
1822 (x_allocate_bitmap_record): Check for size overflow.
1823 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1825 Use ptrdiff_t, not int, for overlay counts.
1826 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1827 * editfns.c (overlays_around, get_pos_property):
1828 * textprop.c (get_char_property_and_overlay):
1829 * xdisp.c (next_overlay_change, note_mouse_highlight):
1830 * xfaces.c (face_at_buffer_position):
1831 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1832 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1833 (Fnext_overlay_change, Fprevious_overlay_change)
1834 (mouse_face_overlay_overlaps, Foverlays_in):
1835 Use ptrdiff_t, not int, for sizes.
1836 (overlays_at, overlays_in): Check for size-calculation overflow.
1838 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1840 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1841 (x_session_initialize): Do not assume string length fits in int.
1843 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1844 This is unlikely, but can occur if DPI is outlandish.
1846 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1847 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1849 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1850 * xrdb.c (magic_file_p, search_magic_path):
1851 Omit last arg SUFFIX; it was always 0. All callers changed.
1852 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1854 * xfont.c (xfont_match): Avoid need for strlen.
1856 * xfns.c: Don't assume strlen fits in int.
1857 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1859 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1860 not unsigned long, as we prefer signed integers. All callers changed.
1861 Detect integer overflow in repeat count.
1862 (message_dolog): Don't assume print length fits in 39 bytes.
1863 (display_mode_element): Don't assume strlen fits in int.
1865 * termcap.c: Don't assume sizes fit in int and never overflow.
1866 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1867 (gobble_line): Check for size-calculation overflow.
1869 * minibuf.c (Fread_buffer):
1870 * lread.c (intern, intern_c_string):
1871 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1872 Don't assume string length fits in int.
1874 * keyboard.c (parse_tool_bar_item):
1875 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1877 * font.c: Don't assume string length fits in int.
1878 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1879 Use ptrdiff_t, not int.
1880 (font_intern_prop): Don't assume string length fits in int.
1881 Don't assume integer property fits in fixnum.
1882 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1884 * filelock.c: Fix some buffer overrun and integer overflow issues.
1885 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1886 Reformulate so as not to need the command string.
1887 Invoke gzip -cd rather than gunzip, as it's more portable.
1888 (lock_info_type, lock_file_1, lock_file):
1889 Don't assume pid_t and time_t fit in unsigned long.
1890 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1891 (current_lock_owner): Prefer signed type for sizes.
1892 Use memcpy, not strncpy, where memcpy is what is really wanted.
1893 Don't assume (via atoi) that time_t and pid_t fit in int.
1894 Check for time_t and/or pid_t out of range, e.g., via a network share.
1895 Don't alloca where an auto var works fine.
1897 * fileio.c: Fix some integer overflow issues.
1898 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1899 Don't assume string length fits in int.
1900 (directory_file_name): Don't assume string length fits in long.
1901 (make_temp_name): Don't assume pid fits in int, or that its print
1902 length is less than 20.
1904 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1906 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1908 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1910 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1911 We prefer signed integers, even for size calculations.
1913 * emacs.c: Don't assume string length fits in 'int'.
1914 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1915 (main): Don't invoke strlen when not needed.
1917 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1918 (XD_DEBUG_MESSAGE): Don't waste a byte.
1920 * callproc.c (getenv_internal_1, getenv_internal)
1922 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1924 * lread.c (invalid_syntax): Omit length argument.
1925 All uses changed. This doesn't fix a bug, but it simplifies the
1926 code away from its former Hollerith-constant appearance, and it's
1927 one less 'int' to worry about when looking at integer-overflow issues.
1928 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1930 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1931 This didn't break anything, but it didn't help either.
1932 It's confusing to put a bogus integer in a place where the actual
1933 value does not matter.
1934 (LIST_END_P): Remove unused macro and its bogus comment.
1935 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1937 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1938 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1940 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1941 We prefer signed types, and the value cannot exceed the EMACS_INT
1942 range anyway (because otherwise the length would not be representable).
1943 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1944 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1945 This avoids a GCC warning when WIDE_EMACS_INT.
1947 * indent.c (sane_tab_width): New function.
1948 (current_column, scan_for_column, Findent_to, position_indentation)
1949 (compute_motion): Use it. This is just for clarity.
1950 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1952 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1954 * lisp.h (lint_assume): New macro.
1955 * composite.c (composition_gstring_put_cache):
1956 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1958 * editfns.c, insdel.c:
1959 Omit unnecessary forward decls, to simplify future changes.
1961 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1963 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1965 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1966 Use much-faster test for byte-length change.
1967 Don't assume string byte-length fits in 'int'.
1968 Check that character arg fits in 'int'.
1969 (mapcar1): Declare byte as byte, for clarity.
1971 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1973 * fns.c (concat): Catch string overflow earlier.
1974 Do not rely on integer wraparound.
1976 * dispextern.h (struct it.overlay_strings_charpos)
1977 (struct it.selective): Now EMACS_INT, not int.
1978 * xdisp.c (forward_to_next_line_start)
1979 (back_to_previous_visible_line_start)
1980 (reseat_at_next_visible_line_start, next_element_from_buffer):
1981 Don't arbitrarily truncate the value of 'selective' to int.
1983 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1985 * composite.c: Don't truncate sizes to 'int'.
1986 (composition_gstring_p, composition_reseat_it)
1987 (composition_adjust_point): Use EMACS_INT, not int.
1988 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1989 not EMACS_UINT, for indexes.
1991 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1993 * buffer.c: Include <verify.h>.
1994 (struct sortvec.priority, struct sortstr.priority):
1995 Now EMACS_INT, not int.
1996 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1997 (struct sortstr.size, record_overlay_string)
1998 (struct sortstrlist.size, struct sortlist.used):
1999 Don't truncate size to int.
2000 (record_overlay_string): Check for size-calculation overflow.
2001 (init_buffer_once): Check at compile-time, not run-time.
2003 2011-06-22 Jim Meyering <meyering@redhat.com>
2005 Don't leak an XBM-image-sized buffer
2006 * image.c (xbm_load): Free the image buffer after using it.
2008 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2011 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2012 that Sun C diagnosed.
2013 * fns.c (secure_hash): Fix pointer signedness issue.
2014 * intervals.c (static_offset_intervals): New function.
2015 (offset_intervals): Use it.
2017 2011-06-21 Leo Liu <sdl.web@gmail.com>
2020 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2023 * fns.c (secure_hash): Rename from crypto_hash_function and change
2024 the first arg to accept symbols.
2025 (Fsecure_hash): New primitive.
2026 (syms_of_fns): New symbols.
2028 2011-06-20 Deniz Dogan <deniz@dogan.se>
2030 * process.c (Fset_process_buffer): Clarify return value in
2033 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2035 * dispnew.c (add_window_display_history): Use BVAR.
2037 * xdisp.c (debug_method_add): Use BVAR.
2038 (check_window_end, dump_glyph_matrix, dump_glyph)
2039 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2041 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2044 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2045 check till after the cache is created in init_frame_faces.
2047 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2049 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2051 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2053 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2054 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2055 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2057 Improve buffer-overflow checking (Bug#8873).
2058 * fileio.c (Finsert_file_contents):
2059 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2060 Remove the old (too-loose) buffer overflow checks.
2061 They weren't needed, since make_gap checks for buffer overflow.
2062 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2063 The old code merely checked for Emacs fixnum overflow, and relied
2064 on undefined (wraparound) behavior. The new code avoids undefined
2065 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2067 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2068 Tune. Don't use wider integers than needed. Don't use alloca.
2069 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2071 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2073 * insdel.c, lisp.h (buffer_overflow): New function.
2074 (insert_from_buffer_1, replace_range, replace_range_2):
2075 * insdel.c (make_gap_larger):
2076 * editfns.c (Finsert_char):
2077 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2079 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2081 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2083 Integer overflow and signedness fixes (Bug#8873).
2085 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2086 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2088 * fileio.c: Don't assume EMACS_INT fits in off_t.
2089 (emacs_lseek): New static function.
2090 (Finsert_file_contents, Fwrite_region): Use it.
2091 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2093 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2095 * fns.c: Don't overflow int when computing a list length.
2096 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2097 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2098 truncation on 64-bit hosts. Check for QUIT every
2099 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2100 faster and is responsive enough.
2101 (Flength): Report an error instead of overflowing an integer.
2102 (Fsafe_length): Return a float if the value is not representable
2103 as a fixnum. This shouldn't happen except in contrived situations.
2104 (Fnthcdr, Fsort): Don't assume list length fits in int.
2105 (Fcopy_sequence): Don't assume vector length fits in int.
2107 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2108 (header_size, word_size): New constants.
2109 (allocate_vectorlike): Don't check size overflow here.
2110 (allocate_vector): Check it here instead, since this is the only
2111 caller of allocate_vectorlike that could cause overflow.
2112 Check that the new vector's length is representable as a fixnum.
2114 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2115 The previous code was bogus. For example, next_almost_prime (32)
2116 returned 39, which is undesirable as it is a multiple of 3; and
2117 next_almost_prime (24) returned 25, which is a multiple of 5 so
2118 why was the code bothering to check for multiples of 7?
2120 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2122 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2124 Variadic C functions now count arguments with ptrdiff_t.
2125 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2126 Back then I didn't know that the Emacs coding style prefers signed int.
2127 Also, in the meantime I found a few more instances where arguments
2128 were being counted with int, which may truncate counts on 64-bit
2129 machines, or EMACS_INT, which may be unnecessarily wide.
2130 * lisp.h (struct Lisp_Subr.function.aMANY)
2131 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2132 Arg counts are now ptrdiff_t, not size_t.
2133 All variadic functions and their callers changed accordingly.
2134 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2135 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2136 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2137 * callint.c (Fcall_interactively): Check arg count for overflow,
2138 to avoid potential buffer overrun. Use signed char, not 'int',
2139 for 'varies' array, so that we needn't bother to check its size
2140 calculation for overflow.
2141 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2142 * eval.c (apply_lambda):
2143 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2144 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2145 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2147 * callint.c (Fcall_interactively): Don't use index var as event count.
2149 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2150 * mem-limits.h (SIZE): Remove; no longer used.
2152 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2154 Remove unnecessary casts.
2155 * xterm.c (x_term_init):
2156 * xfns.c (x_set_border_pixel):
2157 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2158 These aren't needed now that we assume ANSI C.
2160 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2161 It's more likely to cause problems (due to unsigned overflow)
2164 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2166 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2168 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2170 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2172 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2174 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2176 GLYPH_CODE_FACE returns EMACS_INT, not int.
2177 * dispextern.h (merge_faces):
2178 * xfaces.c (merge_faces):
2179 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2180 Don't assume EMACS_INT fits in int.
2182 * character.h (CHAR_VALID_P): Remove unused parameter.
2183 * fontset.c, lisp.h, xdisp.c: All uses changed.
2185 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2187 * fns.c (concat): Minor tuning based on overflow analysis.
2188 This doesn't fix any bugs. Use int to hold character, instead
2189 of constantly refetching from Emacs object. Use XFASTINT, not
2190 XINT, for value known to be a character. Don't bother comparing
2191 a single byte to 0400, as it's always less.
2193 * floatfns.c (Fexpt):
2194 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2196 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2199 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2201 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2202 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2203 incorrectly succeed when S was a string, because 4294967386 was
2204 truncated before it was used.
2206 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2207 Otherwise, an out-of-range integer could cause undefined behavior
2210 * composite.c: Use int, not EMACS_INT, for characters.
2211 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2212 EMACS_INT, for values that are known to be in character range.
2213 This doesn't fix any bugs but is the usual style inside Emacs and
2214 may generate better code on 32-bit machines.
2216 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2217 This is for reasons similar to the recent CHAR_STRING fix.
2218 * charset.c (Fencode_char): Check that character arg is actually
2219 a character. Pass an int to ENCODE_CHAR.
2220 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2221 wider than 'int', as a compile-time check to prevent future regressions
2224 * character.c (char_string): Remove unnecessary casts.
2226 Make sure a 64-bit char is never passed to CHAR_STRING.
2227 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2228 by silently ignoring the top 32 bits, allowing some values
2229 that were far too large to be valid characters.
2230 * character.h: Include <verify.h>.
2231 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2232 arguments are no wider than unsigned, as a compile-time check
2233 to prevent future regressions in this area.
2235 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2236 (Fsubst_char_in_region):
2238 * xdisp.c (decode_mode_spec_coding):
2239 Adjust to CHAR_STRING's new requirement.
2240 * editfns.c (Finsert_char, Fsubst_char_in_region):
2241 * fns.c (concat): Check that character args are actually
2242 characters. Without this test, these functions did the wrong
2243 thing with wildly out-of-range values on 64-bit hosts.
2245 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2246 These casts should not be needed on 32-bit hosts, either.
2247 * keyboard.c (read_char):
2248 * lread.c (Fload): Remove casts to unsigned.
2250 * lisp.h (UNSIGNED_CMP): New macro.
2251 This fixes comparison bugs on 64-bit hosts.
2252 (ASCII_CHAR_P): Use it.
2253 * casefiddle.c (casify_object):
2254 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2255 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2256 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2257 * dispextern.h (FACE_FROM_ID):
2258 * keyboard.c (read_char): Use UNSIGNED_CMP.
2260 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2261 not to EMACS_INT, to avoid GCC warning.
2263 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2265 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2266 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2267 isn't needed on 32-bit machines.
2269 * buffer.c (Fgenerate_new_buffer_name):
2270 Use EMACS_INT for count, not int.
2271 (advance_to_char_boundary): Return EMACS_INT, not int.
2273 * data.c (Qcompiled_function): Now static.
2275 * window.c (window_body_lines): Now static.
2277 * image.c (gif_load): Rename local to avoid shadowing.
2279 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2280 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2281 * alloc.c (make_save_value): Integer argument is now of type
2283 (mark_object): Use ptrdiff_t, not int.
2284 * lisp.h (pD): New macro.
2285 * print.c (print_object): Use it.
2287 * alloc.c: Use EMACS_INT, not int, to count objects.
2288 (total_conses, total_markers, total_symbols, total_vector_size)
2289 (total_free_conses, total_free_markers, total_free_symbols)
2290 (total_free_floats, total_floats, total_free_intervals)
2291 (total_intervals, total_strings, total_free_strings):
2292 Now EMACS_INT, not int. All uses changed.
2293 (Fgarbage_collect): Compute overall total using a double, so that
2294 integer overflow is less likely to be a problem. Check for overflow
2295 when converting back to an integer.
2296 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2297 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2298 These were 'int' variables that could overflow on 64-bit hosts;
2299 they were never used, so remove them instead of repairing them.
2300 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2301 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2302 Previously, this ceilinged at INT_MAX, but that doesn't work on
2304 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2306 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2307 (allocate_vectorlike): Check for ptrdiff_t overflow.
2308 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2309 when a (possibly-narrower) signed value would do just as well.
2310 We prefer using signed arithmetic, to avoid comparison confusion.
2312 * alloc.c: Catch some string size overflows that we were missing.
2313 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2314 for convenience in STRING_BYTES_MAX.
2315 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2316 The definition here is exact; the one in lisp.h was approximate.
2317 (allocate_string_data): Check for string overflow. This catches
2318 some instances we weren't catching before. Also, it catches
2319 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2320 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2321 and ptrdiff_t and EMACS_INT are both 64 bits.
2323 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2324 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2325 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2327 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2329 * alloc.c (Fmake_string): Check for out-of-range init.
2331 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2333 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2335 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2337 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2338 xg_get_default_scrollbar_width.
2340 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2341 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2342 (style_changed_cb): Call update_theme_scrollbar_width and call
2343 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2344 all frames (Bug#8505).
2345 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2346 Call gtk_window_set_resizable if HAVE_GTK3.
2347 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2348 and height if HAVE_GTK3 (Bug#8505).
2349 (scroll_bar_width_for_theme): New variable.
2350 (update_theme_scrollbar_width): New function.
2351 (xg_get_default_scrollbar_width): Move code to
2352 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2353 (xg_initialize): Call update_theme_scrollbar_width.
2355 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2357 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2359 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2361 * frame.c (make_frame): Call other_buffer_safely instead of
2364 * window.c (temp_output_buffer_show): Call display_buffer with
2365 second argument Vtemp_buffer_show_specifiers and reset latter
2366 immediately after the call.
2367 (Vtemp_buffer_show_specifiers): New variable.
2368 (auto_window_vscroll_p, next_screen_context_lines)
2369 (Vscroll_preserve_screen_position): Remove leading asterisks from
2372 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2374 Fix minor problems found by GCC 4.6.0 static checking.
2375 * buffer.c (Qclone_number): Remove for now, as it's unused.
2376 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2377 (record_buffer): Remove unused local.
2378 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2379 (set_frame_buffer_list): Remove; unused.
2380 * frame.h (other_visible_frames): Remove decl.
2381 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2382 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2383 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2385 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2386 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2387 Define only if HAVE_GPM.
2388 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2389 (update_hints_inhibit): Remove; never set. All uses removed.
2390 * widgetprv.h (emacsFrameClassRec): Remove decl.
2391 * window.c (delete_deletable_window): Now returns void, since it
2392 wasn't returning anything.
2393 (compare_window_configurations): Remove unused locals.
2394 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2395 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2396 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2397 the same widths as pointers. This follows up on the 2011-05-06 patch.
2398 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2399 * xterm.h: Likewise.
2400 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2402 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2404 * makefile.w32-in: Update dependencies.
2405 (LISP_H): Add lib/intprops.h.
2407 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2409 * image.c (gif_load): Add animation frame delay to the metadata.
2410 (syms_of_image): Use DEFSYM. New symbol `delay'.
2412 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2414 * window.c (delete_deletable_window): Re-add.
2415 (Fset_window_configuration): Rewrite to handle dead buffers and
2416 consequently deletable windows.
2417 (window_tree, Fwindow_tree): Remove. Supply functionality in
2419 (compare_window_configurations): Simplify code.
2421 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2423 * image.c (imagemagick_load_image): Fix type mismatch.
2424 (Fimagemagick_types): Likewise.
2426 * window.h (replace_buffer_in_windows): Declare.
2428 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2430 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2431 Qclone_number. Remove external declaration of Qdelete_window.
2432 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2434 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2435 Run Qbuffer_list_update_hook if allowed.
2436 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2437 buffer list implementation.
2438 (other_buffer_safely): New function.
2439 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2440 calls to replace_buffer_in_windows and
2441 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2443 (record_buffer): Inhibit quitting and rewrite using quittable
2444 functions. Run Qbuffer_list_update_hook if allowed.
2445 (Frecord_buffer, Funrecord_buffer): New functions.
2446 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2447 Move switch-to-buffer to window.el.
2448 (bury-buffer): Move to window.el.
2449 (Vbuffer_list_update_hook): New variable.
2451 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2454 * window.h (resize_frame_windows): Move up in code.
2455 (Fwindow_frame): Remove EXFUN.
2456 (replace_buffer_in_all_windows): Remove prototype.
2457 (replace_buffer_in_windows_safely): Add prototype.
2459 * window.c: Declare Qdelete_window static again. Move down
2460 declaration of select_count.
2461 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2462 (Fother_window): Move to window.el.
2463 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2464 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2465 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2467 (replace_buffer_in_windows): Implement by calling
2468 Qreplace_buffer_in_windows.
2469 (replace_buffer_in_all_windows): Remove with some functionality
2470 moved into replace_buffer_in_windows_safely.
2471 (replace_buffer_in_windows_safely): New function.
2472 (select_window_norecord, select_frame_norecord): Move in front
2473 of run_window_configuration_change_hook. Remove now obsolete
2475 (Fset_window_buffer): Rewrite doc-string.
2476 Call Qrecord_window_buffer.
2477 (keys_of_window): Move binding for other-window to window.el.
2479 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2481 * dispextern.h (struct image): Replace data member, whose int_val
2482 and ptr_val fields were not used by anything, with a single
2485 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2486 (gif_clear_image, gif_load, imagemagick_load_image)
2487 (gs_clear_image, gs_load): Callers changed.
2489 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2491 * buffer.h: Include <time.h>, for time_t.
2492 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2494 Fix minor problems found by static checking.
2496 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2498 Make identifiers static if they are not used in other modules.
2499 * data.c (Qcompiled_function, Qframe, Qvector):
2500 * image.c (QimageMagick, Qsvg):
2501 * minibuf.c (Qmetadata):
2502 * window.c (resize_window_check, resize_root_window): Now static.
2503 * window.h (resize_window_check, resize_root_window): Remove decls.
2505 * window.c (window_deletion_count, delete_deletable_window):
2507 (window_body_lines): Now static.
2508 (Fdelete_other_windows_internal): Mark vars as initialized.
2509 Make sure 'resize_failed' is initialized.
2510 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2511 (resize_window_apply): Remove unused local.
2512 * window.h (delete_deletable_window): Remove decl.
2514 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2515 (imagemagick_load_image): Fix pointer signedness problem by changing
2516 last arg from unsigned char * to char *. All uses changed.
2517 Also, fix a local for similar reasons.
2518 Remove unused locals. Remove locals to avoid shadowing.
2519 (fn_rsvg_handle_free): Remove; unused.
2520 (svg_load, svg_load_image): Fix pointer signedness problem.
2521 (imagemagick_load_image): Don't use garbage pointer image_wand.
2523 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2525 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2527 * image.c (gif_load): Fix omitted cast error introduced by
2530 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2532 * window.h (resize_proportionally, orig_total_lines)
2533 (orig_top_line): Remove from window structure.
2534 (set_window_height, set_window_width, change_window_heights)
2535 (Fdelete_window): Remove prototypes.
2536 (resize_frame_windows): Remove duplicate declaration.
2538 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2540 * window.h (resize_frame_windows, resize_window_check)
2541 (delete_deletable_window, resize_root_window)
2542 (resize_frame_windows): Declare prototypes.
2544 * window.c (resize_window_apply): Make definition be "static" to
2545 match the prototype.
2547 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2549 * window.c: Remove declarations of Qwindow_size_fixed,
2550 window_min_size_1, window_min_size_2, window_min_size,
2551 size_window, window_fixed_size_p, enlarge_window, delete_window.
2552 Remove static from declaration of Qdelete_window, it's
2553 temporarily needed by Fbury_buffer.
2554 (replace_window): Don't assign orig_top_line and
2556 (Fdelete_window, delete_window): Remove. Window deletion is
2557 handled by window.el.
2558 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2559 Replace Fdelete_window calls with calls to Qdelete_window.
2560 (Fdelete_other_windows): Remove. Deleting other windows is
2561 handled by window.el.
2562 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2563 handled in window.el.
2564 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2565 Window minimum sizes are handled in window.el.
2566 (shrink_windows, size_window, set_window_height)
2567 (set_window_width, change_window_heights, window_height)
2568 (window_width, CURBEG, CURSIZE, enlarge_window)
2569 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2570 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2571 handled in window.el.
2572 (make_dummy_parent): Rename to make_parent_window and give it a
2573 second argument horflag.
2574 (make_window): Don't set resize_proportionally any more.
2575 (Fsplit_window): Remove. Windows are split in window.el.
2576 (save_restore_action, save_restore_orig_size)
2577 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2578 Resize mini windows in window.el.
2579 (grow_mini_window, shrink_mini_window): Implement by calling
2580 Qresize_root_window_vertically, resize_window_check and
2581 resize_window_apply.
2582 (saved_window, Fset_window_configuration, save_window_save):
2583 Do not handle orig_top_line, orig_total_lines, and
2584 resize_proportionally.
2585 (window_min_height, window_min_width): Move to window.el.
2586 (keys_of_window): Move bindings for delete-other-windows,
2587 split-window, delete-window and enlarge-window to window.el.
2589 * buffer.c: Temporarily extern Qdelete_window.
2590 (Fbury_buffer): Temporarily call Qdelete_window instead of
2591 Fdelete_window (Fbury_buffer will move to window.el soon).
2593 * frame.c (set_menu_bar_lines_1): Remove code handling
2594 orig_top_line and orig_total_lines.
2596 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2597 set_window_height but set heights directly.
2598 (change_frame_size_1): Use resize_frame_windows.
2600 * xdisp.c (init_xdisp): Don't use set_window_height but set
2603 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2604 Use resize_frame_windows instead of change_window_heights and run
2605 run_window_configuration_change_hook.
2607 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2608 instead of change_window_heights and run
2609 run_window_configuration_change_hook.
2611 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2613 * window.c (replace_window): Rename second argument REPLACEMENT to
2614 NEW. New third argument SETFLAG. Rewrite.
2615 (delete_window, make_dummy_parent): Call replace_window with
2617 (window_list_1): Move down in code.
2618 (run_window_configuration_change_hook): Move set_buffer part
2619 before select_frame_norecord part in order to unwind correctly.
2620 Rename count1 to count.
2621 (recombine_windows, delete_deletable_window, resize_root_window)
2622 (Fdelete_other_windows_internal)
2623 (Frun_window_configuration_change_hook, make_parent_window)
2624 (resize_window_check, resize_window_apply, Fresize_window_apply)
2625 (resize_frame_windows, Fsplit_window_internal)
2626 (Fdelete_window_internal, Fresize_mini_window_internal):
2628 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2630 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2632 * window.h (window): Add some new members to window structure -
2633 normal_lines, normal_cols, new_total, new_normal, clone_number,
2634 splits, nest, prev_buffers, next_buffers.
2635 (WINDOW_TOTAL_SIZE): Move here from window.c.
2636 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2638 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2640 (make_dummy_parent): Set new members of windows structure.
2641 (make_window): Move down in code. Handle new members of window
2643 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2644 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2645 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2646 (Fset_window_prev_buffers, Fwindow_next_buffers)
2647 (Fset_window_next_buffers, Fset_window_clone_number):
2649 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2650 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2652 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2653 Argument WINDOW can be now internal window too.
2654 (Fwindow_use_time): Move up in code.
2655 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2657 (Fset_window_configuration, saved_window)
2658 (Fcurrent_window_configuration, save_window_save): Handle new
2659 members of window structure.
2660 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2661 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2662 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2663 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2664 Qget_mru_window, Qresize_root_window,
2665 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2666 Qauto_buffer_name; staticpro them.
2668 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2670 * window.c (Fwindow_total_size, Fwindow_left_column)
2671 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2672 (Fwindow_list_1): New functions.
2673 (window_box_text_cols): Replace with window_body_cols.
2674 (Fwindow_width, Fscroll_left, Fscroll_right):
2675 Use window_body_cols instead of window_box_text_cols.
2676 (delete_window, Fset_window_configuration):
2677 Call delete_all_subwindows with window as argument.
2678 (delete_all_subwindows): Take a window as argument and not a
2680 (window_loop): Remove handling of GET_LRU_WINDOW and
2682 (Fget_lru_window, Fget_largest_window): Move to window.el.
2684 * window.h: Extern window_body_cols instead of
2685 window_box_text_cols. delete_all_subwindows now takes a
2686 Lisp_Object as argument.
2688 * indent.c (compute_motion, Fcompute_motion):
2689 Use window_body_cols instead of window_box_text_cols.
2691 * frame.c (delete_frame): Call delete_all_subwindows with root
2694 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2696 * fns.c (Fputhash): Document return value.
2698 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2700 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2702 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2704 Cons<->int and similar integer overflow fixes (Bug#8794).
2706 Check for overflow when converting integer to cons and back.
2707 * charset.c (Fdefine_charset_internal, Fdecode_char):
2708 Use cons_to_unsigned to catch overflow.
2709 (Fencode_char): Use INTEGER_TO_CONS.
2710 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2711 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2712 * data.c (long_to_cons, cons_to_long): Remove.
2713 (cons_to_unsigned, cons_to_signed): New functions.
2714 These signal an error for invalid or out-of-range values.
2715 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2716 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2717 * font.c (Ffont_variation_glyphs):
2718 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2719 * lisp.h: Include <intprops.h>.
2720 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2721 (cons_to_signed, cons_to_unsigned): New decls.
2722 (long_to_cons, cons_to_long): Remove decls.
2723 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2724 (Fprimitive_undo): Use CONS_TO_INTEGER.
2725 * xfns.c (Fx_window_property): Likewise.
2726 * xselect.c: Include <limits.h>.
2727 (x_own_selection, selection_data_to_lisp_data):
2728 Use INTEGER_TO_CONS.
2729 (x_handle_selection_request, x_handle_selection_clear)
2730 (x_get_foreign_selection, Fx_disown_selection_internal)
2731 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2732 (lisp_data_to_selection_data): Use cons_to_unsigned.
2733 (x_fill_property_data): Use cons_to_signed.
2734 Report values out of range.
2736 Check for buffer and string overflow more precisely.
2737 * buffer.h (BUF_BYTES_MAX): New macro.
2738 * lisp.h (STRING_BYTES_MAX): New macro.
2739 * alloc.c (Fmake_string):
2740 * character.c (string_escape_byte8):
2741 * coding.c (coding_alloc_by_realloc):
2742 * doprnt.c (doprnt):
2743 * editfns.c (Fformat):
2745 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2746 since they may not be the same number.
2747 * editfns.c (Finsert_char):
2748 * fileio.c (Finsert_file_contents):
2749 Likewise for BUF_BYTES_MAX.
2751 * image.c: Use ptrdiff_t, not int, for sizes.
2752 (slurp_file): Switch from int to ptrdiff_t.
2754 (slurp_file): Check that file size fits in both size_t (for
2755 malloc) and ptrdiff_t (for sanity and safety).
2757 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2758 if b->modtime has its maximal value.
2760 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2762 Don't assume time_t can fit into int.
2763 * buffer.h (struct buffer.modtime): Now time_t, not int.
2764 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2765 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2767 Minor fixes for signed vs unsigned integers.
2768 * character.h (MAYBE_UNIFY_CHAR):
2769 * charset.c (maybe_unify_char):
2770 * keyboard.c (read_char, reorder_modifiers):
2771 XINT -> XFASTINT, since the integer must be nonnegative.
2772 * ftfont.c (ftfont_spec_pattern):
2773 * keymap.c (access_keymap, silly_event_symbol_error):
2774 XUINT -> XFASTINT, since the integer must be nonnegative.
2775 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2776 since it makes no difference and we prefer signed.
2777 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2778 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2781 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2783 * window.h (Fwindow_frame): Declare.
2785 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2787 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2788 (SPARE_MEMORY): Always define.
2789 (LARGE_REQUEST): Remove.
2790 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2792 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2794 * lisp.h: Move EXFUNS for Fframe_root_window,
2795 Fframe_first_window and Fset_frame_selected_window to window.h.
2797 * window.h: Move EXFUNS for Fframe_root_window,
2798 Fframe_first_window and Fset_frame_selected_window here from
2801 * frame.c (Fwindow_frame, Fframe_first_window)
2802 (Fframe_root_window, Fframe_selected_window)
2803 (Fset_frame_selected_window): Move to window.c.
2804 (Factive_minibuffer_window): Move to minibuf.c.
2805 (Fother_visible_frames_p): New function.
2807 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2809 * window.c (decode_window, decode_any_window): Move up in code.
2810 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2811 (inhibit_frame_unsplittable): Remove unused variable.
2812 (Fwindow_buffer): Move up and rewrite doc-string.
2813 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2814 (Fwindow_prev): New functions.
2815 (Fwindow_frame): Move here from frame.c. Accept any window as
2817 (Fframe_root_window, Fframe_first_window)
2818 (Fframe_selected_window): Move here from frame.c. Accept frame
2819 or arbitrary window as argument. Update doc-strings.
2820 (Fminibuffer_window): Move up in code.
2821 (Fwindow_minibuffer_p): Move up in code and simplify.
2822 (Fset_frame_selected_window): Move here from frame.c.
2824 (Fselected_window, select_window, Fselect_window): Move up in
2825 code. Minor doc-string fixes.
2827 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2829 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2830 Do not assume that spare memory exists; that assumption is valid
2831 only if SYSTEM_MALLOC.
2832 (LARGE_REQUEST): New macro, so that the issue of large requests
2833 is separated from the issue of spare memory.
2835 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2837 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2840 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2842 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2845 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2847 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2849 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2851 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2852 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2854 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2856 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2858 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2860 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2861 (x_clipboard_manager_save): Add return value.
2862 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2864 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2865 Obey Vx_select_enable_clipboard_manager. Catch errors in
2866 x_clipboard_manager_save (Bug#8779).
2867 (Vx_select_enable_clipboard_manager): New variable.
2868 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2870 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2872 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2874 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2876 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2877 in the current matrix if keep_current_p is non-zero.
2879 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2881 * bidi.c (bidi_level_of_next_char): Fix last change.
2883 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2885 Support bidi reordering of text covered by display properties.
2887 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2888 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2889 (bidi_cache_search, bidi_cache_iterator_state)
2890 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2891 (bidi_level_of_next_char, bidi_move_to_visually_next):
2892 Support character positions inside a run of characters covered by a
2894 (bidi_paragraph_init, bidi_resolve_explicit_1)
2895 (bidi_level_of_next_char): Call bidi_fetch_char and
2896 bidi_fetch_char_advance instead of FETCH_CHAR and
2898 (bidi_init_it): Initialize new members.
2899 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2901 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2902 instead of using explicit *_CHAR codes.
2903 (bidi_resolve_explicit, bidi_resolve_weak):
2904 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2905 bidirectional text is supported only in multibyte buffers.
2906 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2907 it to initialize the frame_window_p member of struct bidi_it.
2908 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2909 (bidi_resolve_explicit, bidi_resolve_weak)
2910 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2911 bidi_it->nchars is non-positive.
2912 (bidi_level_of_next_char): Don't try to lookup the cache for the
2913 next/previous character if nothing is cached there yet, or if we
2914 were just reseat()'ed to a new position.
2916 * xdisp.c (set_cursor_from_row): Set start and stop points
2917 according to the row's direction when priming the loop that looks
2918 for the glyph on which to display cursor.
2919 (single_display_spec_intangible_p): Function deleted.
2920 (display_prop_intangible_p): Reimplement to call
2921 handle_display_spec instead of single_display_spec_intangible_p.
2922 Accept 3 additional arguments needed by handle_display_spec.
2923 This fixes incorrect cursor motion across display property with complex
2924 values: lists, `(when COND...)' forms, etc.
2925 (single_display_spec_string_p): Support property values that are
2926 lists with the argument STRING its top-level element.
2927 (display_prop_string_p): Fix the condition for processing a
2928 property that is a list to be consistent with handle_display_spec.
2929 (handle_display_spec): New function, refactored from the
2930 last portion of handle_display_prop.
2931 (compute_display_string_pos): Accept additional argument
2932 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2933 value of a `display' property is a "replacing spec".
2934 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2935 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2936 the display property, but just return a value indicating whether
2937 the display property will replace the characters it covers.
2938 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2939 frame_window_p members of struct bidi_it.
2940 (compute_display_string_pos, compute_display_string_end):
2942 (push_it): Accept second argument POSITION, where pop_it should
2943 jump to continue iteration.
2944 (reseat_1): Initialize bidi_it.disp_pos.
2946 * keyboard.c (adjust_point_for_property): Adjust the call to
2947 display_prop_intangible_p to its new signature.
2949 * dispextern.h (struct bidi_it): New member frame_window_p.
2950 (bidi_init_it): Update prototypes.
2951 (display_prop_intangible_p): Update prototype.
2952 (compute_display_string_pos, compute_display_string_end):
2954 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2957 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2959 Malloc failure behavior now depends on size of allocation.
2960 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2961 * lisp.h: Change signatures accordingly.
2962 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2963 All callers changed. (Bug#8762)
2965 * gnutls.c: Use Emacs's memory allocators.
2966 Without this change, the gnutls library would invoke malloc etc.
2967 directly, which causes problems on non-SYNC_INPUT hosts, and which
2968 runs afoul of improving memory_full behavior. (Bug#8761)
2969 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2970 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2971 xfree instead of the default malloc, realloc, free.
2972 (Fgnutls_boot): No need to check for memory allocation failure,
2973 since xmalloc does that for us.
2975 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2976 * category.c (hash_get_category_set):
2977 * ccl.c (ccl_driver):
2978 * charset.c (Fdefine_charset_internal):
2979 * charset.h (struct charset.hash_index):
2980 * composite.c (get_composition_id, gstring_lookup_cache)
2981 (composition_gstring_put_cache):
2982 * composite.h (struct composition.hash_index):
2983 * dispextern.h (struct image.hash):
2984 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2985 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2986 (hashfn_equal, hashfn_user_defined, make_hash_table)
2987 (maybe_resize_hash_table, hash_lookup, hash_put)
2988 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2989 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2990 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2991 * image.c (make_image, search_image_cache, lookup_image)
2992 (xpm_put_color_table_h):
2993 * lisp.h (struct Lisp_Hash_Table):
2994 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2995 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2996 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2997 * alloc.c (allocate_vectorlike):
2998 Check for overflow in vector size calculations.
2999 * ccl.c (ccl_driver):
3000 Check for overflow when converting EMACS_INT to int.
3001 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3002 need to be updated by these changes.
3003 * fns.c (make_hash_table, maybe_resize_hash_table):
3004 Check for integer overflow with large hash tables.
3005 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3006 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3007 (SXHASH_REDUCE): New macro.
3008 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3009 Use it instead of discarding useful hash info with large hash values.
3010 (sxhash_float): New function.
3011 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3012 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3013 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3014 Rewrite to use FIXNUM_BITS, as this simplifies things.
3015 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3016 Adjust signatures to match updated version of code.
3017 (consing_since_gc): Now EMACS_INT, since a single hash table can
3018 use more than INT_MAX bytes.
3020 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3022 Make it possible to build with GCC-4.6+ -O2 -flto.
3024 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3026 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3028 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3029 Call minibuffer-inactive-mode.
3031 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3033 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3034 Update dependencies.
3036 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3038 * data.c (init_data): Remove code for UTS, this system is not
3041 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3043 Don't force ./temacs to start in terminal mode.
3045 * frame.c (make_initial_frame): Initialize faces in all cases, not
3046 only when CANNOT_DUMP is defined.
3047 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3049 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3051 * dispnew.c (add_window_display_history): Use const for the string
3052 pointer. Remove declaration, not needed.
3054 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3056 Use 'inline', not 'INLINE'.
3057 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3058 * alloc.c, fontset.c (INLINE): Remove.
3059 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3060 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3061 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3062 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3063 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3065 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3067 Make it possible to run ./temacs.
3069 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3070 syms_of_callproc does the same thing. Remove test for
3071 "initialized", do it in the caller.
3072 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3074 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3076 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3077 (read_minibuf): Use get_minibuffer.
3078 (syms_of_minibuf): Use DEFSYM.
3079 (Qmetadata): New var.
3080 * data.c (Qbuffer): Don't make it static.
3081 (syms_of_data): Use DEFSYM.
3083 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3085 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3086 (CCL_CODE_MIN): New macro.
3088 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3090 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3092 * eval.c (Qdebug): Now static.
3093 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3094 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3095 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3097 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3099 * image.c: Various fixes to ImageMagick code comments.
3100 (Fimagemagick_types): Doc fix.
3102 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3104 Minor fixes prompted by GCC 4.6.0 warnings.
3106 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3108 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3109 (x_clipboard_manager_save_all): Move extern decl to ...
3110 * xterm.h: ... here, so that it can be checked for consistency.
3112 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3114 * xselect.c (x_clipboard_manager_save_frame)
3115 (x_clipboard_manager_save_all): New functions.
3116 (Fx_clipboard_manager_save): Lisp function deleted.
3118 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3119 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3121 * xterm.h: Update prototype.
3123 2011-05-28 William Xu <william.xwl@gmail.com>
3125 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3128 2011-05-28 Jim Meyering <meyering@redhat.com>
3130 Avoid a sign-extension bug in crypto_hash_function.
3131 * fns.c (to_uchar): Define.
3132 (crypto_hash_function): Use it to convert some newly-signed
3133 variables to unsigned, to avoid sign-extension bugs. For example,
3134 without this change, (md5 "truc") would evaluate to
3135 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3136 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3137 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3139 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3141 Integer overflow fixes.
3143 * dbusbind.c: Serial number integer overflow fixes.
3144 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3145 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3146 to hold a serial number that is too large for a fixnum.
3147 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3148 Check for serial numbers out of range. Decode any serial number
3149 that was so large that it became a float. (Bug#8722)
3151 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3152 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3153 Use XFASTINT rather than XUINT when numbers are nonnegative.
3154 (xd_append_arg, Fdbus_method_return_internal):
3155 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3156 arguments, check that Lisp number is nonnegative, rather than
3157 silently wrapping negative numbers around. (Bug#8722)
3158 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3161 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3163 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3165 ccl: add integer overflow checks
3166 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3167 (IN_INT_RANGE): New macros.
3168 (ccl_driver): Use them to check for integer overflow when
3169 decoding a CCL program. Many of the new checks are whether XINT (x)
3170 fits in int; it doesn't always, on 64-bit hosts. The new version
3171 doesn't catch all possible integer overflows, but it's an
3172 improvement. (Bug#8719)
3174 * alloc.c (make_event_array): Use XINT, not XUINT.
3175 There's no need for unsigned here.
3177 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3178 This follows up to the 2011-05-06 change that substituted uintptr_t
3179 for EMACS_INT. This case wasn't caught back then.
3181 Rework Fformat to avoid integer overflow issues.
3182 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3183 now (part of C89). Include <verify.h>.
3184 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3185 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3186 (Fformat): Avoid the prepass trying to compute sizes; it was only
3187 approximate and thus did not catch overflow reliably. Instead, walk
3188 through the format just once, formatting and computing sizes as we go,
3189 checking for integer overflow at every step, and allocating a larger
3190 buffer as needed. Keep track separately whether the format is
3191 multibyte. Keep only the most-recently calculated precision, rather
3192 than them all. Record whether each argument has been converted to
3193 string. Use EMACS_INT, not int, for byte and char and arg counts.
3194 Support field widths and precisions larger than INT_MAX. Avoid
3195 sprintf's undefined behavior with conversion specifications such as %#d
3196 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3197 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3198 formatting out-of-range floating point numbers with int
3201 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3203 * data.c: Avoid integer truncation in expressions involving floats.
3204 * data.c: Include <intprops.h>.
3205 (arith_driver): When there's an integer overflow in an expression
3206 involving floating point, convert the integers to floating point
3207 so that the resulting value does not suffer from catastrophic
3208 integer truncation. For example, on a 64-bit host (* 4
3209 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3210 Do not rely on undefined behavior after integer overflow.
3212 merge count_size_as_multibyte, parse_str_to_multibyte
3213 * character.c, character.h (count_size_as_multibyte):
3214 Rename from parse_str_to_multibyte; all uses changed.
3215 Check for integer overflow.
3216 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3217 since it's now a duplicate of the other. This is more of
3218 a character than a buffer op, so better that it's in character.c.
3219 * fns.c, print.c: Adjust to above changes.
3221 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3223 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3225 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3227 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3228 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3229 (x_clipboard_manager_save): Now static.
3230 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3232 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3233 (crypto_hash_function): Now static.
3234 Fix pointer signedness problems. Avoid unnecessary initializations.
3236 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3238 * termhooks.h (Vselection_alist): Make it terminal-local.
3240 * terminal.c (create_terminal): Initialize it.
3242 * xselect.c: Support for clipboard managers.
3243 (Vselection_alist): Move to termhooks.h as terminal-local var.
3244 (LOCAL_SELECTION): New macro.
3245 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3246 (symbol_to_x_atom): Remove gratuitous arg.
3247 (x_handle_selection_request, lisp_data_to_selection_data)
3248 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3249 (x_own_selection, x_get_local_selection, x_convert_selection):
3250 New arg, specifying work frame. Use terminal-local Vselection_alist.
3251 (some_frame_on_display): Delete unused function.
3252 (Fx_own_selection_internal, Fx_get_selection_internal)
3253 (Fx_disown_selection_internal, Fx_selection_owner_p)
3254 (Fx_selection_exists_p): New optional frame arg.
3255 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3256 (x_handle_selection_clear): Don't treat other terminals with the
3257 same keyboard specially. Use the terminal-local Vselection_alist.
3258 (x_clear_frame_selections): Use Frun_hook_with_args.
3260 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3262 * xterm.h: Add support for those atoms.
3264 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3266 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3267 (converted_selections, conversion_fail_tag): New global variables.
3268 (x_selection_request_lisp_error): Free the above.
3269 (x_get_local_selection): Remove unnecessary code.
3270 (x_reply_selection_request): Args changed; handle arbitrary array
3271 of converted selections stored in converted_selections.
3272 Separate the XChangeProperty and SelectionNotify steps.
3273 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3274 (x_convert_selection): New function.
3275 (x_handle_selection_event): Simplify.
3276 (x_get_foreign_selection): Don't ignore incoming requests while
3277 waiting for an answer; this will fail when we implement
3278 SAVE_TARGETS, and seems unnecessary anyway.
3279 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3280 (Vx_sent_selection_functions): Doc fix.
3282 2011-05-26 Leo Liu <sdl.web@gmail.com>
3284 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3286 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3288 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3290 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3291 for fringe update if it has periodic bitmap.
3292 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3293 and fringe_bitmap_periodic_p.
3295 * fringe.c (get_fringe_bitmap_data): New function.
3296 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3297 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3298 row. Mark glyph row for fringe update if periodicity changed.
3300 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3301 for fringe update unless it has periodic bitmap.
3303 2011-05-25 Kenichi Handa <handa@m17n.org>
3305 * xdisp.c (get_next_display_element): Set correct it->face_id for
3306 a static composition.
3308 2011-05-24 Leo Liu <sdl.web@gmail.com>
3311 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3313 * fns.c (crypto_hash_function, Fsha1): New function.
3314 (Fmd5): Use crypto_hash_function.
3315 (syms_of_fns): Add Ssha1.
3317 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3319 * gnutls.c: Remove unused macros.
3320 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3321 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3322 Remove macros that are defined and never used.
3323 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3325 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3327 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3328 (Fx_get_selection_internal): Minor cleanup.
3329 (Fx_own_selection_internal): Rename arguments for consistency with
3332 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3334 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3336 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3338 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3340 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3342 * dispnew.c (scrolling_window): Don't exclude the case that the
3343 last enabled row in the desired matrix touches the bottom boundary.
3345 2011-05-21 Glenn Morris <rgm@gnu.org>
3347 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3348 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3349 and add some more files.
3351 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3353 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3354 report_file_error introduced by the change from 2011-05-07.
3356 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3358 * systime.h (Time): Define only if emacs is defined.
3359 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3360 where the include path doesn't have X11/X.h by default. See
3361 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3363 2011-05-20 Kenichi Handa <handa@m17n.org>
3365 * composite.c (find_automatic_composition): Fix previous change.
3367 2011-05-20 Glenn Morris <rgm@gnu.org>
3369 * lisp.mk: New file, split from Makefile.in.
3370 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3371 (shortlisp): Remove.
3372 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3374 2011-05-19 Glenn Morris <rgm@gnu.org>
3376 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3377 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3378 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3379 (lisp): Set the order to that of loadup.el.
3380 (shortlisp): Make it a copy of $lisp.
3381 (SOME_MACHINE_LISP): Remove.
3382 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3383 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3385 2011-05-18 Kenichi Handa <handa@m17n.org>
3387 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3388 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3389 (find_automatic_composition): Mostly rewrite for efficiency.
3391 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3393 * makefile.w32-in: Update dependencies.
3395 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3397 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3398 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3400 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3402 Fix some integer overflow issues, such as string length overflow.
3404 * insdel.c (count_size_as_multibyte): Check for string overflow.
3406 * character.c (lisp_string_width): Check for string overflow.
3407 Use EMACS_INT, not int, for string indexes and lengths; in
3408 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3409 the resulting string length overflows an EMACS_INT; instead,
3410 report a string overflow if no precision given. When checking for
3411 precision exhaustion, use a check that cannot possibly have
3412 integer overflow. (Bug#8675)
3413 * character.h (lisp_string_width): Adjust to new signature.
3415 * alloc.c (string_overflow): New function.
3416 (Fmake_string): Use it. This doesn't change behavior, but saves
3417 a few bytes and will simplify future changes.
3418 * character.c (string_escape_byte8): Likewise.
3419 * lisp.h (string_overflow): New decl.
3421 Fixups, following up to the user-interface timestamp change.
3422 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3423 for UI timestamps, instead of unsigned long.
3424 * msdos.c (mouse_get_pos): Likewise.
3425 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3426 * w32gui.h (Time): Define by including "systime.h" rather than by
3427 declaring it ourselves. (Bug#8664)
3429 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3430 * image.c (clear_image_cache): Likewise.
3432 * term.c (term_mouse_position): Don't assume time_t wraparound.
3434 Be more systematic about user-interface timestamps.
3435 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3436 and sometimes 'EMACS_UINT', to represent these timestamps.
3437 This change causes it to use 'Time' uniformly, as that's what X uses.
3438 This makes the code easier to follow, and makes it easier to catch
3439 integer overflow bugs such as Bug#8664.
3440 * frame.c (Fmouse_position, Fmouse_pixel_position):
3441 Use Time, not unsigned long, for user-interface timestamps.
3442 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3443 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3444 * keyboard.h (last_event_timestamp): Likewise.
3445 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3446 * menu.h (xmenu_show): Likewise.
3447 * term.c (term_mouse_position): Likewise.
3448 * termhooks.h (struct input_event.timestamp): Likewise.
3449 (struct terminal.mouse_position_hook): Likewise.
3450 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3451 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3452 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3453 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3455 * menu.h, termhooks.h: Include "systime.h", for Time.
3457 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3458 Don't assume that the difference between two unsigned long values
3459 can fit into an integer. At this point, we know button_down_time
3460 <= event->timestamp, so the difference must be nonnegative, so
3461 there's no need to cast the result if double-click-time is
3462 nonnegative, as it should be; check that it's nonnegative, just in
3463 case. This bug is triggered when events are more than 2**31 ms
3464 apart (about 25 days). (Bug#8664)
3466 * xselect.c (last_event_timestamp): Remove duplicate decl.
3467 (x_own_selection): Remove needless cast to unsigned long.
3469 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3470 that always fit in int. Use a sentinel instead of a counter, to
3471 avoid a temp and to allay GCC's concerns about possible int overflow.
3472 * frame.h (struct frame): Use int for menu_bar_items_used
3473 instead of EMACS_INT, since it always fits in int.
3475 * menu.c (grow_menu_items): Check for int overflow.
3477 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3479 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3480 Before, the code was not consistent. These values cannot exceed
3481 2**31 - 1 so there's no need to make them unsigned.
3482 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3483 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3484 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3486 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3488 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3489 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3490 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3491 presumably because the widths might not match.
3493 * window.c (size_window): Avoid needless test at loop start.
3495 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3497 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3499 2011-05-12 Drew Adams <drew.adams@oracle.com>
3501 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3503 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3505 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3506 `width' to `bar_area_x' and `bar_area_width', respectively.
3507 (x_scroll_run): Take account of fringe background extension.
3509 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3510 Rename local vars `left' and `width' to `bar_area_x' and
3511 `bar_area_width', respectively.
3512 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3513 background extension.
3515 2011-05-10 Jim Meyering <meyering@redhat.com>
3517 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3519 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3521 * image.c (Finit_image_library): Return t for built-in image types,
3522 like pbm and xbm. (Bug#8640)
3524 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3526 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3528 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3530 * w32console.c (Fset_screen_color): Doc fix.
3531 (Fget_screen_color): New function.
3532 (syms_of_ntterm): Defsubr it.
3534 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3535 unlink the temporary file if Fcall_process didn't create it in the
3537 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3538 child process will be redirected to a file specified with `:file'.
3539 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3540 cue to call_process_cleanup not to close that handle.
3542 2011-05-07 Ben Key <bkey76@gmail.com>
3544 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3545 one of two shell specific rules, either bootstrap-temacs-CMD or
3546 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3547 to the previous implementation of the bootstrap-temacs rule.
3548 The bootstrap-temacs-CMD rule is similar to the previous
3549 implementation of the bootstrap-temacs rule except that it
3550 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3553 These changes, along with some changes to nt/configure.bat,
3554 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3555 earlier fix to add support for --cflags and --ldflags options
3556 that include quotes so that it works whether make uses cmd or
3559 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3561 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3562 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3564 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3565 a string. Handle both cases.
3566 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3567 (Fdbus_register_method): Use Qinvalid_function.
3569 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3571 * makefile.w32-in: Update dependencies.
3572 (LISP_H): Add inttypes.h and stdin.h.
3573 (PROCESS_H): Add unistd.h.
3575 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3577 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3578 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3580 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3582 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3584 * term.c (vfatal): Remove stray call to va_end.
3585 It's not needed and the C Standard doesn't allow it here anyway.
3587 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3588 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3590 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3593 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3595 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3597 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3599 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3601 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3603 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3604 * charset.c (Fdefine_charset_internal): Don't initialize
3605 charset.code_space[15]. The value was garbage, on hosts with
3606 32-bit int (Bug#8600).
3608 * lread.c (read_integer): Be more consistent with string-to-number.
3609 Use string_to_number to do the actual conversion; this avoids
3610 rounding errors and fixes some other screwups. Without this fix,
3611 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3612 (digit_to_number): Move earlier, for benefit of read_integer.
3613 Return -1 if the digit is out of range for the base, -2 if it is
3614 not a digit in any supported base. (Bug#8602)
3616 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3618 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3619 to match comment at start of function. This also removes a
3620 GCC warning about overflow in a 32+64-bit port.
3622 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3624 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3625 Reported by Stefan Monnier in
3626 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3627 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3628 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3630 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3631 (EMACS_UINTPTR): Likewise, with uintptr_t.
3633 * lisp.h: Prefer 64-bit EMACS_INT if available.
3634 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3635 on 32-bit hosts that have 64-bit int, so that they can access
3637 However, temporarily disable this change unless the temporary
3638 symbol WIDE_EMACS_INT is defined.
3640 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3642 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3643 This removes an assumption that EMACS_INT and long are the same
3644 width as pointers. The assumption is true for Emacs porting targets
3645 now, but we want to make other targets possible.
3646 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3647 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3648 In the rest of the code, change types of integers that hold casted
3649 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3650 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3651 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3652 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3653 No need to cast type when ORing.
3654 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3655 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3656 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3657 assume EMACS_INT is the same width as char *.
3658 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3659 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3660 Remove no-longer-needed casts.
3661 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3662 (xg_tool_bar_help_callback, xg_make_tool_item):
3663 Use EMACS_INTPTR to hold an integer
3664 that will be cast to void *; this can avoid a GCC warning
3665 if EMACS_INT is not the same width as void *.
3666 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3667 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3668 (current_message_1, set_message_1):
3669 Use a local to convert to proper width without a cast.
3670 * xmenu.c (dialog_selection_callback): Likewise.
3672 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3673 Also, don't assume VALBITS / RAND_BITS is less than 5,
3674 and don't rely on undefined behavior when shifting a 1 left into
3676 * lisp.h (get_random): Change signature to match.
3678 * lread.c (hash_string): Use size_t, not int, for hash computation.
3679 Normally we prefer signed values; but hashing is special, because
3680 it's better to use unsigned division on hash table sizes so that
3681 the remainder is nonnegative. Also, size_t is the natural width
3682 for hashing into memory. The previous code used 'int', which doesn't
3683 retain enough info to hash well into very large tables.
3684 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3686 * dbusbind.c: Don't possibly lose pointer info when converting.
3687 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3688 Use XPNTR rather than XHASH, so that the high-order bits of
3689 the pointer aren't lost when converting through void *.
3691 * eval.c (Fautoload): Don't double-shift a pointer.
3693 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3695 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3697 * gnutls.c (DEF_GNUTLS_FN):
3698 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3700 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3702 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3705 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3707 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3708 New version that can reserve upto 2GB of heap space.
3710 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3712 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3714 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3716 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3717 `gnutls_certificate_set_x509_key_file'.
3719 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3721 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3722 Update dependencies.
3724 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3726 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3727 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3728 Remove unused parameter `fildes'.
3729 * process.c (read_process_output, send_process): Don't pass it.
3731 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3733 Fix previous change: the library cache is defined in w32.c.
3734 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3735 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3737 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3739 Implement dynamic loading of GnuTLS on Windows.
3741 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3742 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3743 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3746 * gnutls.c (Qgnutls_dll): Define.
3747 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3748 (gnutls_*): Declare function pointers.
3749 (init_gnutls_functions): New function to initialize function pointers.
3750 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3751 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3752 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3753 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3754 (emacs_gnutls_write, emacs_gnutls_read)
3755 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3756 (Fgnutls_available_p): New function.
3757 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3758 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3759 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3761 * image.c: Include w32.h.
3762 (Vimage_type_cache): Delete.
3763 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3764 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3765 (w32_delayed_load): Move to w32.c.
3767 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3769 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3770 (w32_delayed_load): Move from image.c. When loading a library, record
3771 its filename in the :loaded-from property of the library id.
3772 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3773 Initialize and staticpro them.
3774 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3776 * process.c: Include lisp.h before w32.h, not after.
3777 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3778 instead of gnutls_record_check_pending.
3780 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3782 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3784 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3785 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3788 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3790 * xterm.c (x_set_frame_alpha): Do not set property on anything
3791 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3793 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3795 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3797 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3799 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3800 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3801 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3802 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3803 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3804 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3805 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3806 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3807 (Qgnutls_bootprop_callbacks_verify): Make static.
3809 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3811 * callproc.c: Indentation fixup.
3813 * sysdep.c (wait_for_termination_1): Make static.
3814 (wait_for_termination, interruptible_wait_for_termination):
3815 Move after wait_for_termination_1.
3817 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3819 * sysdep.c (interruptible_wait_for_termination): New function
3820 which is like wait_for_termination, but allows keyboard
3823 * callproc.c (Fcall_process): Add (:file "file") as an option for
3825 (Fcall_process_region): Ditto.
3827 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3829 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3830 rather than `XVECTOR (FOO)->size'.
3832 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3833 inttypes.h, as a gnulib replacement is used if it not available in
3836 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3838 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3839 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3840 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3842 * coding.c (coding_alloc_by_realloc): Error out if destination
3843 will grow beyond MOST_POSITIVE_FIXNUM.
3844 (decode_coding_emacs_mule): Abort if there isn't enough place in
3845 charbuf for the composition carryover bytes. Reserve an extra
3846 space for up to 2 characters produced in a loop.
3847 (decode_coding_iso_2022): Abort if there isn't enough place in
3848 charbuf for the composition carryover bytes.
3850 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3852 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3853 aborting when %lld or %lll format is passed.
3854 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3855 %llo or %llx format is passed. (Bug#8545)
3857 * window.c (window_scroll_line_based): Use a marker instead of
3858 simple variables to record original value of point. (Bug#7952)
3860 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3861 produced by %s or %c overflows available buffer space. (Bug#8545)
3863 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3865 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3866 (SIZE_MAX): Move defn after all includes, as they might #define it.
3868 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3870 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3872 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3874 * keyboard.c (Qdelayed_warnings_hook): Define.
3875 (command_loop_1): Run `delayed-warnings-hook'
3876 if Vdelayed_warnings_list is non-nil.
3877 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3878 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3880 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3882 * doprnt.c (doprnt): Don't return value smaller than the buffer
3883 size if the message was truncated. (Bug#8545).
3885 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3887 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3888 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3890 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3892 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3894 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3896 * makefile.w32-in: Update dependencies.
3898 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3900 Improve `doprnt' and its usage. (Bug#8545)
3901 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3902 `format_end'. Remove support for %l as a conversion specifier.
3903 Don't use xrealloc. Improve diagnostics when the %l size modifier
3904 is used. Update the commentary.
3906 * eval.c (verror): Simplify calculation of size_t.
3908 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3911 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3913 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3916 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3918 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3919 This makes this file independent of the recent pseudovector change.
3921 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3923 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3925 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3926 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3927 Remove unused local.
3928 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3930 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3931 GCC 4.6.0 optimizes based on type-based alias analysis.
3932 For example, if b is of type struct buffer * and v of type struct
3933 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3934 != &v->size, and therefore "v->size = 1; b->size = 2; return
3935 v->size;" must therefore return 1. This assumption is incorrect
3936 for Emacs, since it type-puns struct Lisp_Vector * with many other
3937 types. To fix this problem, this patch adds a new type struct
3938 vectorlike_header that documents the constraints on layout of vectors
3939 and pseudovectors, and helps optimizing compilers not get fooled
3940 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3941 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3942 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3944 (XSETPVECTYPE): Rewrite in terms of new macro.
3945 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3946 This is a bit clearer, and further avoids the possibility of
3947 undesirable aliasing.
3948 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3949 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3950 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3951 since Lisp_Subr is a special case (no "next" field).
3952 (ASIZE): Now uses header.size rather than size.
3953 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3954 to avoid the hassle of writing XVECTOR (foo)->header.size.
3955 (struct vectorlike_header): New type.
3956 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3957 object, to help avoid aliasing.
3958 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3959 (SUBRP): Likewise, since Lisp_Subr is a special case.
3960 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3961 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3962 (struct Lisp_Hash_Table): Combine first two members into a single
3963 struct vectorlike_header member. All uses of "size" and "next" members
3964 changed to be "header.size" and "header.next".
3965 * buffer.h (struct buffer): Likewise.
3966 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3967 * frame.h (struct frame): Likewise.
3968 * process.h (struct Lisp_Process): Likewise.
3969 * termhooks.h (struct terminal): Likewise.
3970 * window.c (struct save_window_data, struct saved_window): Likewise.
3971 * window.h (struct window): Likewise.
3972 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3973 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3974 * buffer.c (init_buffer_once): Likewise.
3975 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3977 * process.c (Fformat_network_address): Use local var for size,
3980 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3982 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3983 * data.c (atof): Remove decl; no longer used or needed.
3984 (digit_to_number): Move to lread.c.
3985 (Fstring_to_number): Use new string_to_number function, to be
3986 consistent with how the Lisp reader treats infinities and NaNs.
3987 Do not assume that floating-point numbers represent EMACS_INT
3988 without losing information; this is not true on most 64-bit hosts.
3989 Avoid double-rounding errors, by insisting on integers when
3990 parsing non-base-10 numbers, as the documentation specifies.
3991 * lisp.h (string_to_number): New decl, replacing ...
3992 (isfloat_string): Remove.
3993 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3994 (read1): Do not accept +. and -. as integers; this
3995 appears to have been a coding error. Similarly, do not accept
3996 strings like +-1e0 as floating point numbers. Do not report
3997 overflow for integer overflows unless the base is not 10 which
3998 means we have no simple and reliable way to continue.
3999 Break out the floating-point parsing into a new
4000 function string_to_number, so that Fstring_to_number parses
4001 floating point numbers consistently with the Lisp reader.
4002 (digit_to_number): Move here from data.c. Make it static inline.
4003 (E_CHAR, EXP_INT): Remove, replacing with ...
4004 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4005 (string_to_number): New function, replacing isfloat_string.
4006 This function checks for valid syntax and produces the resulting
4007 Lisp float number too. Rework it so that string-to-number
4008 no longer mishandles examples like "1.0e+". Use strtoumax,
4009 so that overflow for non-base-10 numbers is reported only when
4010 there's no portable and simple way to convert to floating point.
4012 * textprop.c (set_text_properties_1): Rewrite for clarity,
4013 and to avoid GCC warning about integer overflow.
4015 * intervals.h (struct interval): Use EMACS_INT for members
4016 where EMACS_UINT might cause problems. See
4017 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4018 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4019 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4021 (offset_intervals): Tell GCC not to worry about length overflow
4022 when negating a negative length.
4024 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4025 (overrun_check_free): Likewise.
4027 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4028 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4031 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4032 (gnutls_make_error): Rename local to avoid shadowing.
4033 (gnutls_emacs_global_deinit): ifdef out; not used.
4034 (Fgnutls_boot): Use const for pointer to readonly storage.
4035 Comment out unused local. Fix pointer signedness problems.
4037 * lread.c (openp): Don't stuff size_t into an 'int'.
4038 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4039 about possible signed overflow.
4041 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4042 (GDK_KEY_g): Don't define if already defined.
4043 (xg_prepare_tooltip): Avoid pointer signedness problem.
4044 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4046 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4047 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4049 * xfns.c (Fx_window_property): Simplify a bit,
4050 to make a bit faster and to avoid GCC 4.6.0 warning.
4051 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4053 * fns.c (internal_equal): Don't assume size_t fits in int.
4055 * alloc.c (compact_small_strings): Tighten assertion a little.
4057 Replace pEd with more-general pI, and fix some printf arg casts.
4058 * lisp.h (pI): New macro, generalizing old pEd macro to other
4059 conversion specifiers. For example, use "...%"pI"d..." rather
4060 than "...%"pEd"...".
4061 (pEd): Remove. All uses replaced with similar uses of pI.
4062 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4063 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4064 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4065 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4066 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4067 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4068 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4070 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4071 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4072 * print.c (safe_debug_print, print_object): Likewise.
4073 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4075 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4076 avoiding the 0 flag, which is not portable.
4077 * process.c (Fmake_network_process): Use pI to avoid cast.
4078 * region-cache.c (pp_cache): Likewise.
4079 * xdisp.c (decode_mode_spec): Likewise.
4080 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4081 behavior on 64-bit hosts with printf arg.
4082 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4083 (x_stop_queuing_selection_requests): Likewise.
4084 (x_get_window_property): Don't truncate byte count to an 'int'
4087 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4088 here, since it parses constructs like leading '-' and spaces,
4089 which are not wanted; and it overflows with large numbers.
4090 Instead, simply match F[0-9]+, which is what is wanted anyway.
4092 * alloc.c: Remove unportable assumptions about struct layout.
4093 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4094 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4095 (allocate_vectorlike, make_pure_vector): Use the new macros,
4096 plus offsetof, to remove unportable assumptions about struct layout.
4097 These assumptions hold on all porting targets that I know of, but
4098 they are not guaranteed, they're easy to remove, and removing them
4099 makes further changes easier.
4101 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4102 This doesn't fix a bug but makes the code clearer.
4103 (string_overrun_cookie): Now const. Use initializers that
4104 don't formally overflow signed char, to avoid warnings.
4105 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4106 can cause Emacs to crash when string overrun checking is enabled.
4107 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4108 multiple of sizeof (EMACS_INT); it need not be, if
4109 alignof(EMACS_INT) < sizeof (EMACS_INT).
4110 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4112 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4114 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4116 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4118 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4119 supposed to be handshaking. (Bug#8556)
4120 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4122 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4124 * lisp.h (Qdebug): List symbol.
4125 * eval.c (Qdebug): Restore global linkage.
4126 * keyboard.c (debug-on-event): New variable.
4127 (handle_user_signal): Break into debugger when debug-on-event
4128 matches the current signal symbol.
4130 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4132 * alloc.c (check_sblock, check_string_bytes)
4133 (check_string_free_list): Convert to standard C.
4135 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4137 * w32.c (emacs_gnutls_push): Fix typo.
4139 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4141 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4142 "cast to pointer from integer of different size".
4144 Improve doprnt and its use in verror. (Bug#8545)
4145 * doprnt.c (doprnt): Document the set of format control sequences
4146 supported by the function. Use SAFE_ALLOCA instead of always
4149 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4150 is one byte too soon. Don't use xrealloc; instead xfree and
4153 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4155 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4158 * gnutls.c: Renamed global_initialized to
4159 gnutls_global_initialized. Added internals for the
4160 :verify-hostname-error, :verify-error, and :verify-flags
4161 parameters of `gnutls-boot' and documented those parameters in the
4162 docstring. Start callback support.
4163 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4164 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4165 on error. Return error code.
4166 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4167 (emacs_gnutls_read): Likewise.
4168 (Fgnutls_boot): Return handshake error code.
4169 (emacs_gnutls_handle_error): New function.
4170 (wsaerror_to_errno): Likewise.
4172 * w32.h (emacs_gnutls_pull): Add prototype.
4173 (emacs_gnutls_push): Likewise.
4175 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4176 (emacs_gnutls_push): Likewise.
4178 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4180 * process.c (wait_reading_process_output): Check if GnuTLS
4181 buffered some data internally if no FDs are set for TLS
4184 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4185 (LIBS): Link to USER_LIBS.
4186 ($(BLD)/gnutls.$(0)): New target.
4188 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4190 * xdisp.c (handle_single_display_spec): Rename the
4191 display_replaced_before_p argument into display_replaced_p, to
4192 make it consistent with the commentary. Fix typos in the
4195 * textprop.c (syms_of_textprop): Remove dead code.
4196 (copy_text_properties): Delete obsolete commentary about an
4197 interface that was deleted long ago. Fix typos in the description
4200 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4201 to changes in oldXMenu/XMenu.h from 2011-04-16.
4202 <menu_help_message, prev_menu_help_message>: Constify.
4203 (IT_menu_make_room): menu->help_text is now `const char **';
4206 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4207 to changes in oldXMenu/XMenu.h from 2011-04-16.
4208 (struct XMenu): Declare `help_text' `const char **'.
4210 * xfaces.c <Qunspecified>: Make extern again.
4212 * syntax.c: Include sys/types.h before including regex.h, as
4215 * doc.c (get_doc_string): Improve the format passed to `error'.
4217 * doprnt.c (doprnt): Improve commentary.
4219 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4221 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4224 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4225 changes in globals.h immediately force recompilation.
4226 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4227 $(CURDIR)/s/ms-w32.h.
4228 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4230 * character.c (Fchar_direction): Function deleted.
4231 (syms_of_character): Don't defsubr it.
4232 <char-direction-table>: Deleted.
4234 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4236 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4237 * doprnt.c: Include limits.h.
4238 (SIZE_MAX): New macro.
4239 (doprnt): Return a size_t value. 2nd arg is now size_t.
4240 Many local variables are now size_t instead of int or unsigned.
4241 Improve overflow protection. Support `l' modifier for integer
4242 conversions. Support %l conversion. Don't assume an EMACS_INT
4243 argument for integer conversions and for %c.
4245 * lisp.h (doprnt): Restore prototype.
4247 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4250 * Makefile.in (base_obj): Add back doprnt.o.
4252 * deps.mk (doprnt.o): Add back prerequisites.
4253 (callint.o): Depend on character.h.
4255 * eval.c (internal_lisp_condition_case): Include the handler
4256 representation in the error message.
4257 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4258 when breaking from the loop.
4260 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4262 * callint.c (Fcall_interactively): When displaying error message
4263 about invalid control letter, pass the character's codepoint, not
4264 a pointer to its multibyte form. Improve display of the character
4265 in octal and display also its hex code.
4267 * character.c (char_string): Use %x to display the (unsigned)
4268 codepoint of an invalid character, to avoid displaying a bogus
4271 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4272 `error', not SYMBOL_NAME itself.
4274 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4275 character arguments to `error'.
4277 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4278 to `error' in error message about FINAL_CHAR argument. Make sure
4279 FINAL_CHAR is a character, and use %c when it is passed as
4280 argument to `error'.
4282 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4284 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4286 * w32.c: Include <time.h>.
4287 (sys_localtime): New function.
4289 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4291 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4293 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4295 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4297 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4300 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4302 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4303 gl_state.e_property when gl_state.object is Qt.
4305 * insdel.c (make_gap_larger): Remove limitation of buffer size
4308 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4310 * xdisp.c (lookup_glyphless_char_display)
4311 (produce_glyphless_glyph): Handle cons cell entry in
4312 glyphless-char-display.
4313 (Vglyphless_char_display): Document it.
4315 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4316 glyphless-char-display.
4318 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4320 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4322 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4324 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4325 definition for no-X builds.
4327 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4329 Static checks with GCC 4.6.0 and non-default toolkits.
4331 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4333 * process.c (keyboard_bit_set): Define only if SIGIO.
4334 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4335 (send_process): Repair possible setjmp clobbering.
4337 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4339 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4341 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4343 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4344 Define only if needed.
4346 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4347 by pacifying GCC about it. Maybe it's time to retire it?
4348 * xfaces.c (USG, __TIMEVAL__): Likewise.
4350 * dispextern.h (struct redisplay_interface): Rename param
4352 * termhooks.h (struct terminal): Likewise.
4353 * xterm.c (xembed_send_message): Likewise.
4355 * insdel.c (make_gap_smaller): Define only if
4356 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4358 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4361 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4362 so that we aren't warned about unused symbols.
4364 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4366 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4368 * xfns.c (x_real_positions): Mark locals as initialized.
4370 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4372 * xterm.c: Fix problems found by static analysis with other toolkits.
4373 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4374 (x_dispatch_event): Declare static if USE_GTK, and
4375 define if USE_GTK || USE_X_TOOLKIT.
4376 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4377 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4378 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4379 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4381 * xmenu.c (menu_help_callback): Pointer type fixes.
4382 Use const pointers when pointing at readonly data. Avoid pointer
4384 (FALSE): Remove unused macro.
4385 (update_frame_menubar): Remove unused decl.
4387 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4389 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4390 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4391 (single_menu_item): Rename local to avoid shadowing.
4393 * keyboard.c (make_lispy_event): Remove unused local var.
4395 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4396 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4398 * bitmaps: Change bitmaps from unsigned char back to the X11
4399 compatible char. Avoid the old compiler warnings about
4400 out-of-range initializers by using, for example, '\xab' rather
4403 * xgselect.c (xgselect_initialize): Check vs interface
4404 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4406 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4408 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4409 to read-only memory.
4411 * fns.c (vector): Remove; this old hack is no longer needed.
4413 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4415 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4417 * xrdb.c (x_load_resources): Omit unused local.
4419 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4420 (x_window): Rename locals to avoid shadowing.
4421 (USG): Use the kludged USG macro, to pacify gcc.
4423 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4424 (x_term_init): Remove local to avoid shadowing.
4426 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4428 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4429 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4431 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4433 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4435 Fix regex.c, syntax.c and friends for buffers > 2GB.
4436 * syntax.h (struct gl_state_s): Declare character position members
4439 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4441 * textprop.c (verify_interval_modification, interval_of):
4442 Declare arguments EMACS_INT.
4444 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4447 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4449 * indent.c (Fvertical_motion): Local variable it_start is now
4452 * regex.c (re_match, re_match_2, re_match_2_internal)
4453 (bcmp_translate, regcomp, regexec, print_double_string)
4454 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4455 (re_compile_pattern, re_exec): Declare arguments and local
4456 variables `size_t' and `ssize_t' and return values `regoff_t', as
4458 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4459 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4460 <compile_stack_type>: `size' and `avail' are now `size_t'.
4462 * regex.h <regoff_t>: Use ssize_t, not int.
4463 (re_search, re_search_2, re_match, re_match_2): Arguments that
4464 specify buffer/string position and length are now ssize_t and
4465 size_t. Return type is regoff_t.
4467 2011-04-16 Ben Key <bkey76@gmail.com>
4469 * nsfont.m: Fixed bugs in ns_get_family and
4470 ns_descriptor_to_entity that were caused by using free to
4471 deallocate memory blocks that were allocated by xmalloc (via
4472 xstrdup). This caused Emacs to crash when compiled with
4473 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4474 --enable-checking=xmallocoverrun). xfree is now used to
4475 deallocate these memory blocks.
4477 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4479 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4481 emacs_write: Accept and return EMACS_INT for sizes.
4482 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4484 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4485 Accept and return EMACS_INT.
4486 (emacs_gnutls_write): Return the number of bytes written on
4488 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4489 (emacs_read, emacs_write): Remove check for negative size, as the
4490 Emacs source code has been audited now.
4491 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4492 (emacs_read, emacs_write): Use it.
4493 * process.c (send_process): Adjust to the new signatures of
4494 emacs_write and emacs_gnutls_write. Do not attempt to store
4495 a byte offset into an 'int'; it might overflow.
4496 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4498 * sound.c: Don't assume sizes fit in 'int'.
4499 (struct sound_device.period_size, alsa_period_size):
4500 Return EMACS_INT, not int.
4501 (struct sound_device.write, vox_write, alsa_write):
4502 Accept EMACS_INT, not int.
4503 (wav_play, au_play): Use EMACS_INT to store sizes and to
4504 record read return values.
4506 2011-04-15 Ben Key <bkey76@gmail.com>
4508 * keyboard.c (Qundefined): Don't declare static since it is used
4510 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4511 static since they are used in nsfont.m.
4513 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4515 * process.c (Qprocessp): Don't declare static.
4516 * lisp.h (Qprocessp): Declare again.
4518 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4520 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4522 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4524 Improve C-level modularity by making more things 'static'.
4526 Don't publish debugger-only interfaces to other modules.
4527 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4528 (verify_bytepos, count_markers): Move decls to the only modules
4530 * region-cache.h (pp_cache): Likewise.
4531 * window.h (check_all_windows): Likewise.
4532 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4534 * sysdep.c (croak): Now static, if
4535 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4536 * syssignal.h (croak): Declare only if not static.
4538 * alloc.c (refill_memory_reserve): Now static if
4539 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4540 * lisp.h (refill_memory_reserve): Declare only if not static.
4542 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4543 Define only if USE_LUCID.
4545 * xrdb.c (x_customization_string, x_rm_string): Now static.
4547 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4548 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4550 * xdisp.c (draw_row_with_mouse_face): Now static.
4551 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4553 * window.h (check_all_windows): Mark externally visible.
4555 * window.c (window_deletion_count): Now static.
4557 * undo.c: Make symbols static if they're not exported.
4558 (last_undo_buffer, last_boundary_position, pending_boundary):
4561 * textprop.c (interval_insert_behind_hooks): Now static.
4562 (interval_insert_in_front_hooks): Likewise.
4564 * term.c: Make symbols static if they're not exported.
4565 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4566 (max_frame_lines, tty_set_terminal_modes):
4567 (tty_reset_terminal_modes, tty_turn_off_highlight):
4568 (get_tty_terminal): Now static.
4569 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4570 * termhooks.h (term_mouse_moveto): Do not declare if
4572 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4573 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4575 * sysdep.c: Make symbols static if they're not exported.
4576 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4578 (sigprocmask_set, full_mask): Remove; unused.
4579 (wait_debugging): Mark as visible.
4580 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4581 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4583 * syntax.c (syntax_temp): Define only if !__GNUC__.
4585 * sound.c (current_sound_device, current_sound): Now static.
4587 * search.c (searchbufs, searchbuf_head): Now static.
4589 * scroll.c (scroll_cost): Remove; unused.
4590 * dispextern.h (scroll_cost): Remove decl.
4592 * region-cache.h (pp_cache): Mark as externally visible.
4594 * process.c: Make symbols static if they're not exported.
4595 (process_tick, update_tick, create_process, chan_process):
4596 (Vprocess_alist, proc_buffered_char, datagram_access):
4597 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4598 (deactivate_process): Mark defn as static, as well as decl.
4599 * lisp.h (create_process): Remove decl.
4600 * process.h (chan_process, Vprocess_alist): Remove decls.
4602 * print.c: Make symbols static if they're not exported.
4603 (print_depth, new_backquote_output, being_printed, print_buffer):
4604 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4605 (print_interval, print_number_index, initial_stderr_stream):
4607 * lisp.h (Fprinc): Remove decl.
4608 (debug_output_compilation_hack): Mark as externally visible.
4610 * sysdep.c (croak): Move decl from here to syssignal.h.
4611 * syssignal.h (croak): Put it here, so the API can be checked when
4612 'croak' is called from dissociate_if_controlling_tty.
4614 * minibuf.c: Make symbols static if they're not exported.
4615 (minibuf_save_list, choose_minibuf_frame): Now static.
4616 * lisp.h (choose_minibuf_frame): Remove decl.
4618 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4620 * lread.c: Make symbols static if they're not exported.
4621 (read_objects, initial_obarray, oblookup_last_bucket_number):
4623 (make_symbol): Remove; unused.
4624 * lisp.h (initial_obarray, make_symbol): Remove decls.
4626 * keyboard.c: Make symbols static if they're not exported.
4627 (single_kboard, recent_keys_index, total_keys, recent_keys):
4628 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4629 (this_single_command_key_start, echoing, last_auto_save):
4630 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4631 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4632 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4633 (Vlispy_mouse_stem, double_click_count):
4635 (force_auto_save_soon): Define only if SIGDANGER.
4636 (ignore_mouse_drag_p): Now static if
4637 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4638 (print_help): Remove; unused.
4639 (stop_character, last_timer_event): Mark as externally visible.
4640 * keyboard.h (ignore_mouse_drag_p): Declare only if
4641 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4642 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4643 * lisp.h (echoing): Remove decl.
4644 (force_auto_save_soon): Declare only if SIGDANGER.
4645 * xdisp.c (redisplay_window): Simplify code, to make it more
4646 obvious that ignore_mouse_drag_p is not accessed if !defined
4647 USE_GTK && !defined HAVE_NS.
4649 * intervals.c: Make symbols static if they're not exported.
4650 (merge_properties_sticky, merge_interval_right, delete_interval):
4652 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4654 * insdel.c: Make symbols static if they're not exported.
4655 However, leave prepare_to_modify_buffer alone. It's never
4656 called from outside this function, but that appears to be a bug.
4657 (combine_after_change_list, combine_after_change_buffer):
4658 (adjust_after_replace, signal_before_change): Now static.
4659 (adjust_after_replace_noundo): Remove; unused.
4660 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4661 (signal_before_change): Remove decls.
4663 * indent.c (val_compute_motion, val_vmotion): Now static.
4665 * image.c: Make symbols static if they're not exported.
4666 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4668 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4669 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4671 * fringe.c (standard_bitmaps): Now static.
4672 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4674 * frame.c: Make symbols static if they're not exported.
4675 (x_report_frame_params, make_terminal_frame): Now static.
4676 (get_frame_param): Now static, unless HAVE_NS.
4677 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4678 (x_get_resource_string): Remove; not used.
4679 * frame.h (make_terminal_frame, x_report_frame_params):
4680 (x_get_resource_string); Remove decls.
4681 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4682 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4684 * font.c, fontset.c: Make symbols static if they're not exported.
4685 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4686 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4687 * font.c (font_close_object): Now static.
4688 * font.h (font_close_object): Remove.
4689 * fontset.c (FONTSET_OBJLIST): Remove.
4690 (free_realized_fontset) #if-0 the body, which does nothing.
4691 (face_suitable_for_char_p): #if-0, as it's never called.
4692 * fontset.h (face_suitable_for_char_p): Remove decl.
4693 * xfaces.c (face_at_string_position):
4694 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4695 since 0 is always ASCII.
4697 * fns.c (weak_hash_tables): Now static.
4699 * fileio.c: Make symbols static if they're not exported.
4700 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4701 (Vwrite_region_annotation_buffers): Now static.
4703 * eval.c: Make symbols static if they're not exported.
4704 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4705 * lisp.h (backtrace_list): Remove decl.
4707 * emacs.c: Make symbols static if they're not exported.
4708 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4709 (fatal_error_code, fatal_error_signal_hook, standard_args):
4711 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4712 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4713 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4714 * lisp.h (fatal_error_signal_hook): Remove decl.
4715 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4717 * editfns.c: Move a (normally-unused) function to its only use.
4718 * editfns.c, lisp.h (get_operating_system_release): Remove.
4719 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4720 worth the hassle of breaking this out.
4722 * xterm.c: Make symbols static if they're not exported.
4723 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4724 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4725 (x_destroy_window, x_delete_display):
4727 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4728 (x_mouse_leave): Remove; unused.
4729 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4730 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4731 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4733 (x_mouse_leave): Declare only if WINDOWSNT.
4734 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4735 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4738 * ftxfont.c: Make symbols static if they're not exported.
4739 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4741 * font.h (ftxfont_driver): Likewise.
4743 * xfns.c: Make symbols static if they're not exported.
4744 (x_last_font_name, x_display_info_for_name):
4745 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4746 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4747 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4748 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4749 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4750 (last_show_tip_args): Now static.
4751 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4752 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4753 (x_screen_planes): Remove; unused.
4754 * dispextern.h (x_screen_planes): Remove decl.
4756 * dispnew.c: Make symbols static if they're not exported.
4757 * dispextern.h (redraw_garbaged_frames, scrolling):
4758 (increment_row_positions): Remove.
4759 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4760 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4762 (redraw_garbaged_frames): Remove; unused.
4764 * xfaces.c: Make symbols static if they're not exported.
4765 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4767 * xterm.h (defined_color): Remove decls.
4768 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4769 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4770 (menu_face_changed_default, defined_color, free_realized_face):
4771 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4772 (ascii_face_of_lisp_face): Remove; unused.
4774 * xdisp.c: Make symbols static if they're not exported.
4775 * dispextern.h (scratch_glyph_row, window_box_edges):
4776 (glyph_to_pixel_coords, set_cursor_from_row):
4777 (get_next_display_element, set_iterator_to_next):
4778 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4779 (show_mouse_face): Remove decls
4780 * frame.h (message_buf_print): Likewise.
4781 * lisp.h (pop_message, set_message, check_point_in_composition):
4783 * xterm.h (set_vertical_scroll_bar): Likewise.
4784 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4785 (message_buf_print, scratch_glyph_row, displayed_buffer):
4786 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4787 (get_next_display_element, show_mouse_face, window_box_edges):
4788 (frame_to_window_pixel_xy, check_point_in_composition):
4789 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4790 (glyph_to_pixel_coords): Remove; unused.
4792 * dired.c (file_name_completion): Now static.
4794 * dbusbind.c (xd_in_read_queued_messages): Now static.
4796 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4797 * data.c (circular_list_error): Remove.
4799 * commands.h (last_point_position, last_point_position_buffer):
4800 (last_point_position_window): Remove decls.
4801 * keyboard.c: Make these variables static.
4803 * coding.h (coding, code_convert_region, encode_coding_gap):
4805 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4806 (iso_code_class, detect_coding, code_convert_region): Now static.
4807 (encode_coding_gap): Remove; unused.
4809 * chartab.c (chartab_chars, chartab_bits): Now static.
4811 * charset.h (charset_iso_8859_1): Remove decl.
4812 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4815 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4816 * ccl.c (Vccl_program_table): Now static.
4817 (check_ccl_update): Remove; unused.
4819 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4820 * category.h: ... from here.
4821 * category.c (check_category_table, set_category_set): Now static.
4823 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4824 * lisp.h: Remove these decls.
4826 * buffer.c (buffer_count): Remove unused var.
4828 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4829 so that it's not optimized away.
4830 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4831 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4832 exported only to the debugger.
4834 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4835 * atimer.h (run_all_atimers): Remove; not exported.
4837 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4838 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4839 was inaccessible from Lisp.
4840 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4841 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4843 alloc.c: Import and export fewer symbols, and remove unused items.
4844 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4846 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4847 it's not optimized away by whole-program optimization.
4848 (message_enable_multibyte, free_misc): Remove.
4849 (catchlist, handlerlist, mark_backtrace):
4850 Declare only if BYTE_MARK_STACK.
4851 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4852 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4853 (message_enable_multibyte): Remove decl.
4854 (free_misc, interval_free_list, float_block, float_block_index):
4855 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4856 (cons_free_list, last_marked_index):
4858 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4859 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4860 (mark_backtrace): Define only if BYTE_MARK_STACK.
4861 * xdisp.c (message_enable_multibyte): Now static.
4863 Declare Lisp_Object Q* variables to be 'static' if not exported.
4864 This makes it easier for human readers (and static analyzers)
4865 to see whether these variables are used from other modules.
4866 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4867 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4868 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4869 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4870 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4871 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4872 * xmenu.c, xselect.c:
4873 Declare Q* vars static if they are not used in other modules.
4874 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4875 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4876 Remove decls of unexported vars.
4877 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4879 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4881 Make Emacs functions such as Fatom 'static' by default.
4882 This makes it easier for human readers (and static analyzers)
4883 to see whether these functions can be called from other modules.
4884 DEFUN now defines a static function. To make the function external
4885 so that it can be used in other C modules, use the new macro DEFUE.
4886 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4887 (Finit_image_library):
4888 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4889 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4890 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4891 Remove decls, since these functions are now static.
4892 (Funintern, Fget_internal_run_time): New decls, since these functions
4893 were already external.
4895 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4896 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4897 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4898 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4899 * keyboard.c, keymap.c, lread.c:
4900 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4901 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4902 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4903 Mark functions with DEFUE instead of DEFUN,
4904 if they are used in other modules.
4905 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4906 decls for now-static functions.
4907 * buffer.h (Fdelete_overlay): Remove decl.
4908 * callproc.c (Fgetenv_internal): Mark as internal.
4909 * composite.c (Fremove_list_of_text_properties): Remove decl.
4910 (Fcomposition_get_gstring): New forward static decl.
4911 * composite.h (Fcomposite_get_gstring): Remove decl.
4912 * dired.c (Ffile_attributes): New forward static decl.
4913 * doc.c (Fdocumntation_property): New forward static decl.
4914 * eval.c (Ffetch_bytecode): New forward static decl.
4915 (Funintern): Remove extern decl; now in .h file where it belongs.
4916 * fileio.c (Fmake_symbolic_link): New forward static decl.
4917 * image.c (Finit_image_library): New forward static decl.
4918 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4919 * intervals.h (Fprevious_property_change):
4920 (Fremove_list_of_text_properties): Remove decls.
4921 * keyboard.c (Fthis_command_keys): Remove decl.
4922 (Fcommand_execute): New forward static decl.
4923 * keymap.c (Flookup_key): New forward static decl.
4924 (Fcopy_keymap): Now static.
4925 * keymap.h (Flookup_key): Remove decl.
4926 * process.c (Fget_process): New forward static decl.
4927 (Fprocess_datagram_address): Mark as internal.
4928 * syntax.c (Fsyntax_table_p): New forward static decl.
4929 (skip_chars): Remove duplicate decl.
4930 * textprop.c (Fprevious_property_change): New forward static decl.
4931 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4933 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4934 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4936 * editfns.c (Fformat): Remove unreachable code.
4938 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4940 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4943 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4945 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4946 when at ZV. (Bug#8487)
4948 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4950 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4952 * keyboard.c (parse_tool_bar_item): Likewise.
4953 * sound.c (sound_cleanup, alsa_close): Likewise.
4954 * termcap.c (tgetent): Likewise.
4955 * xfns.c (x_default_font_parameter): Likewise.
4956 * xsettings.c (read_and_apply_settings): Likewise.
4958 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4959 (overrun_check_free): Protoize.
4961 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4963 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4964 since callers should never pass a negative size.
4965 Change the signature to match that of plain 'read' and 'write'; see
4966 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4967 * lisp.h: Update prototypes of emacs_write and emacs_read.
4969 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4971 * xdisp.c (redisplay_window): Don't try to determine the character
4972 position of the scroll margin if the window start point w->startp
4973 is outside the buffer's accessible region. (Bug#8468)
4975 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4977 Fix write-region and its subroutines for buffers > 2GB.
4978 * fileio.c (a_write, e_write): Modify declaration of arguments and
4979 local variables to support buffers larger than 2GB.
4980 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4982 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4983 argument, local variables, and return value.
4985 * lisp.h: Update prototypes of emacs_write and emacs_read.
4987 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4989 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4991 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4993 Fix more problems found by GCC 4.6.0's static checks.
4995 * xdisp.c (vmessage): Use a better test for character truncation.
4997 * charset.c (load_charset_map): <, not <=, for optimization,
4998 and to avoid potential problems with integer overflow.
4999 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5000 * casetab.c (set_identity, shuffle): Likewise.
5001 * editfns.c (Fformat): Likewise.
5002 * syntax.c (skip_chars): Likewise.
5004 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5005 This also lets GCC 4.6.0 generate slightly better loop code.
5007 * callint.c (Fcall_interactively): <, not <=, for optimization.
5008 (Fcall_interactively): Count the number of arguments produced,
5009 not the number of arguments given. This is simpler and lets GCC
5010 4.6.0 generate slightly better code.
5012 * ftfont.c: Distingish more carefully between FcChar8 and char.
5013 The previous code passed unsigned char * to a functions like
5014 strlen and xstrcasecmp that expect char *, which does not
5015 conform to the C standard.
5016 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5017 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5018 char * when the C standard requires it.
5020 * keyboard.c (read_char): Remove unused var.
5022 * eval.c: Port to Windows vsnprintf (Bug#8435).
5024 (SIZE_MAX): Define if the headers do not.
5025 (verror): Do not give up if vsnprintf returns a negative count.
5026 Instead, grow the buffer. This ports to Windows vsnprintf, which
5027 does not conform to C99. Problem reported by Eli Zaretskii.
5028 Also, simplify the allocation scheme, by avoiding the need for
5029 calling realloc, and removing the ALLOCATED variable.
5031 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5033 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5034 But keep the doprint source code for now, as we might revamp it
5035 and use it again (Bug#8435).
5036 * lisp.h (doprnt): Remove.
5037 * Makefile.in (base_obj): Remove doprnt.o.
5038 * deps.mk (doprnt.o): Remove.
5040 error: Print 32- and 64-bit integers portably (Bug#8435).
5041 Without this change, on typical 64-bit hosts error ("...%d...", N)
5042 was used to print both 32- and 64-bit integers N, which relied on
5044 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5046 * lisp.h (error, verror): Mark as printf-like functions.
5047 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5048 Report overflow in size calculations when allocating printf buffer.
5049 Do not truncate output string at its first null byte.
5050 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5051 Truncate the output at a character boundary, since vsnprintf does not
5053 * charset.c (check_iso_charset_parameter): Convert internal
5054 character to string before calling 'error', since %c now has the
5056 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5057 overflow when computing char to be passed to 'error'. Do not
5058 pass Lisp_Object to 'error'; pass the integer instead.
5059 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5060 formatted with plain %d.
5062 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5064 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5066 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5068 * xterm.c (x_catch_errors): Remove duplicate declaration.
5070 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5072 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5074 2011-04-10 Jim Meyering <meyering@redhat.com>
5076 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5077 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5078 return ssize_t not "int", and use size_t as the buffer length.
5079 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5080 * gnutls.h: Update declarations.
5081 * process.c (read_process_output): Use ssize_t, to match.
5082 (send_process): Likewise.
5084 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5086 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5088 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5090 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5091 Use unsigned char, to match FcChar8 type definition.
5093 * xterm.c (handle_one_xevent):
5094 * xmenu.c (create_and_show_popup_menu):
5095 * xselect.c (x_decline_selection_request)
5096 (x_reply_selection_request): Avoid type-punned deref of X events.
5098 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5100 Fix some uses of `int' instead of EMACS_INT.
5101 * search.c (string_match_1, fast_string_match)
5102 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5103 (scan_buffer, find_next_newline_no_quit)
5104 (find_before_next_newline, search_command, Freplace_match)
5105 (Fmatch_data): Make some `int' variables be EMACS_INT.
5107 * xdisp.c (display_count_lines): 3rd argument and return value now
5108 EMACS_INT. All callers changed.
5109 (pint2hrstr): Last argument is now EMACS_INT.
5111 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5112 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5113 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5114 (decode_coding_utf_16, decode_coding_emacs_mule)
5115 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5116 (decode_coding_ccl, decode_coding_charset)
5117 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5118 (decode_coding_iso_2022, decode_coding_emacs_mule)
5119 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5120 <char_offset, last_offset>: Declare EMACS_INT.
5121 (encode_coding_utf_8, encode_coding_utf_16)
5122 (encode_coding_emacs_mule, encode_invocation_designation)
5123 (encode_designation_at_bol, encode_coding_iso_2022)
5124 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5125 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5127 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5128 (encode_invocation_designation): Last argument P_NCHARS is now
5130 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5131 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5133 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5136 * ccl.c (Fccl_execute_on_string): Declare some variables
5139 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5141 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5143 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5145 * process.c (Fformat_network_address): Doc fix.
5147 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5149 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5151 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5153 * keyboard.c (read_char): Call Lisp function help-form-show,
5154 instead of using internal_with_output_to_temp_buffer.
5155 (Qhelp_form_show): New var.
5156 (syms_of_keyboard): Use DEFSYM macro.
5158 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5160 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5162 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5164 * process.c (Flist_processes): Remove to Lisp.
5165 (list_processes_1): Delete.
5167 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5169 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5171 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5173 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5175 Fix more problems found by GCC 4.6.0's static checks.
5177 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5179 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5181 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5183 * xdisp.c (vmessage): Mark as a printf-like function.
5185 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5187 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5189 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5190 printf-like functions.
5191 (tiff_load): Add casts to remove these marks before passing them
5192 to system-supplied API.
5194 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5196 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5197 This avoids several warnings with gcc -Wstrict-overflow.
5198 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5199 directly, rather than having caller test rule sign. This avoids
5200 some unnecessary tests.
5201 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5202 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5203 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5205 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5206 (xfont_open): Avoid unnecessary tests.
5208 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5210 * composite.h, composite.c (composition_gstring_put_cache):
5211 Use EMACS_INT, not int, for length.
5213 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5214 breaking out part of COMPOSITION_DECODE_RULE.
5215 (COMPOSITION_DECODE_RULE): Use it.
5216 * composite.c (get_composition_id): Remove unused local vars,
5217 by using the new macro.
5219 * textprop.c (set_text_properties_1): Change while to do-while,
5220 since the condition is always true at first.
5222 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5223 (interval_deletion_adjustment): Return unsigned value.
5226 * process.c (list_processes_1, create_pty, read_process_output):
5227 (exec_sentinel): Remove vars that were set but not used.
5228 (create_pty): Remove unnecessary "volatile"s.
5229 (Fnetwork_interface_info): Avoid possibility of int overflow.
5230 (read_process_output): Do adaptive read buffering even if carryover.
5231 (read_process_output): Simplify nbytes computation if buffered.
5233 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5235 * syntax.c (scan_words): Remove var that was set but not used.
5236 (update_syntax_table): Use unsigned instead of int.
5238 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5239 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5240 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5242 * print.c (print_error_message): Avoid int overflow.
5244 * font.c (font_list_entities): Redo for clarity,
5245 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5247 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5248 (font_score): Avoid potential overflow in diff calculation.
5250 * fns.c (substring_both): Remove var that is set but not used.
5251 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5253 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5255 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5256 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5257 can always succeed if overflow has undefined behavior.
5259 * search.c (boyer_moore, wordify): Remove vars set but not used.
5260 (wordify): Omit three unnecessary tests.
5262 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5263 All callers changed. This avoids the need for an unused var.
5265 * casefiddle.c (casify_region): Remove var that is set but not used.
5267 * dired.c (file_name_completion): Remove var that is set but not used.
5269 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5271 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5272 (Finsert_file_contents): Remove unnecessary code checking fd.
5274 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5275 Check for integer overflow on size calculations.
5277 * buffer.c (Fprevious_overlay_change): Remove var that is set
5280 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5281 Remove vars that are set but not used.
5282 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5283 (timer_check_2): Mark vars as initialized.
5285 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5287 * image.c (lookup_image): Remove var that is set but not used.
5288 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5290 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5291 that are set but not used.
5293 * xfns.c (make_invisible_cursor): Don't return garbage
5294 if XCreateBitmapFromData fails (Bug#8410).
5296 * xselect.c (x_get_local_selection, x_handle_property_notify):
5297 Remove vars that are set but not used.
5299 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5300 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5302 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5303 Remove var that is set but not used.
5304 (scroll_bar_windows_size): Now size_t, not int.
5305 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5308 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5309 (map_tty_color) [!defined MSDOS]: Likewise.
5311 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5313 * coding.c: Remove vars that are set but not used.
5314 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5315 All callers changed.
5316 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5317 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5318 (decode_coding_charset): Remove vars that are set but not used.
5320 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5321 that is set but not used.
5323 * print.c (print_object): Remove var that is set but not used.
5325 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5326 The gnulib version avoids calling malloc in the usual case,
5327 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5328 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5329 * filelock.c (current_lock_owner): Likewise.
5330 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5331 * sysdep.c: Include allocator.h, careadlinkat.h.
5332 (emacs_no_realloc_allocator): New static constant.
5333 (emacs_readlink): New function.
5334 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5335 ../lib/careadlinkat.h.
5337 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5339 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5340 first non-nil return value).
5342 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5344 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5345 if not defined (Bug#8403).
5347 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5349 * xdisp.c (display_count_lines): Remove parameter `start',
5350 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5351 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5352 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5353 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5354 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5355 and thereabouts. All callers changed.
5356 (get_per_char_metric): Remove parameter `f', unused since
5357 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5359 2011-04-02 Jim Meyering <meyering@redhat.com>
5361 do not dereference NULL upon failed strdup
5362 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5363 (ns_get_family): Likewise.
5365 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5367 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5369 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5371 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5374 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5376 Add lexical binding.
5378 * window.c (Ftemp_output_buffer_show): New fun.
5379 (Fsave_window_excursion):
5380 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5382 * lread.c (lisp_file_lexically_bound_p): New function.
5383 (Fload): Bind Qlexical_binding.
5384 (readevalloop): Remove `evalfun' arg.
5385 Bind Qinternal_interpreter_environment.
5386 (Feval_buffer): Bind Qlexical_binding.
5387 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5389 (syms_of_lread): Declare `lexical-binding'.
5391 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5393 * keyboard.c (eval_dyn): New fun.
5394 (menu_item_eval_property): Use it.
5396 * image.c (parse_image_spec): Use Ffunctionp.
5398 * fns.c (concat, mapcar1): Accept byte-code-functions.
5400 * eval.c (Fsetq): Handle lexical vars.
5401 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5402 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5403 (FletX, Flet): Obey lexical binding.
5404 (Fcommandp): Handle closures.
5405 (Feval): New `lexical' arg.
5406 (eval_sub): New function extracted from Feval. Use it almost
5407 everywhere where Feval was used. Look up vars in lexical env.
5409 (Ffunctionp): Move from subr.el.
5410 (Ffuncall): Handle closures.
5411 (apply_lambda): Remove `eval_flags'.
5412 (funcall_lambda): Handle closures and new byte-code-functions.
5413 (Fspecial_variable_p): New function.
5414 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5415 but without exporting it to Lisp.
5417 * doc.c (Fdocumentation, store_function_docstring):
5418 * data.c (Finteractive_form): Handle closures.
5420 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5423 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5425 (exec_byte_code): New function extracted from Fbyte_code to handle new
5426 calling convention for byte-code-functions. Add new byte-codes.
5428 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5430 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5432 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5434 * xdisp.c (redisplay_internal): Fix prototype.
5436 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5438 * xdisp.c (SCROLL_LIMIT): New macro.
5439 (try_scrolling): Use it when setting scroll_limit.
5440 Limit scrolling to 100 screen lines.
5441 (redisplay_window): Even when falling back on "recentering",
5442 position point in the window according to scroll-conservatively,
5443 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5445 (try_scrolling): When point is above the window, allow searching
5446 as far as scroll_max, or one screenful, to compute vertical
5447 distance from PT to the scroll margin position. This prevents
5448 try_scrolling from unnecessarily failing when
5449 scroll-conservatively is set to a value slightly larger than the
5450 window height. Clean up the case of PT below the margin at bottom
5451 of window: scroll_max can no longer be INT_MAX. When aggressive
5452 scrolling is in use, don't let point enter the opposite scroll
5453 margin as result of the scroll.
5454 (syms_of_xdisp) <scroll-conservatively>: Document the
5455 threshold of 100 lines for never-recentering scrolling.
5457 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5459 * dispextern.h (move_it_by_lines):
5460 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5461 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5462 (message_log_check_duplicate): Remove parameters `prev_bol' and
5463 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5464 (redisplay_internal): Remove parameter `preserve_echo_area',
5465 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5467 * indent.c (Fvertical_motion):
5468 * window.c (window_scroll_pixel_based, Frecenter):
5469 Don't pass `need_y_p' to `move_it_by_lines'.
5471 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5473 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5474 steal a few bits to be more compact.
5475 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5476 Remove unneeded casts.
5478 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5480 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5482 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5483 binding" message (bug#7967).
5485 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5487 Fix more problems found by GCC 4.6.0's static checks.
5489 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5490 Remove unused local var.
5492 * editfns.c (Fmessage_box): Remove unused local var.
5494 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5495 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5496 Omit unused local vars.
5497 * window.c (shrink_windows): Omit unused local var.
5498 * menu.c (digest_single_submenu): Omit unused local var.
5499 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5500 Omit unused local var.
5502 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5503 Don't assume string length fits in int.
5504 (keyremap_step, read_key_sequence): Use size_t for sizes.
5505 (read_key_sequence): Don't check last_real_key_start redundantly.
5507 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5508 instead of alloca (Bug#8344).
5510 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5511 (Fbacktrace_frame): Don't assume nframes fits in int.
5513 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5515 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5518 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5520 * cm.c (calccost): Turn while-do into do-while, for clarity.
5522 * keyboard.c (syms_of_keyboard): Use the same style as later
5523 in this function when indexing through an array. This also
5524 works around GCC bug 48267.
5526 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5528 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5530 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5531 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5533 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5534 This avoids undefined behavior on integer overflow, and is a bit
5535 more convenient anyway since it is compared to a size_t variable.
5537 Variadic C functions now count arguments with size_t, not int.
5538 This avoids an unnecessary limitation on 64-bit machines, which
5539 caused (substring ...) to crash on large vectors (Bug#8344).
5540 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5541 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5542 All variadic functions and their callers changed accordingly.
5543 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5544 * data.c (arith_driver, float_arith_driver): Likewise.
5545 * editfns.c (general_insert_function): Likewise.
5546 * eval.c (struct backtrace.nargs, interactive_p)
5547 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5548 (funcall_lambda, mark_backtrace): Likewise.
5549 * fns.c (concat): Likewise.
5550 * frame.c (x_set_frame_parameters): Likewise.
5551 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5552 0 if not found, not -1. All callers changed.
5554 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5555 (stack_copy_size): Now size_t, not int.
5556 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5558 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5560 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5561 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5562 All callers changed.
5564 * lisp.h (multibyte_char_to_unibyte):
5565 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5566 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5567 * character.h (CHAR_TO_BYTE8):
5568 * cmds.c (internal_self_insert):
5569 * editfns.c (general_insert_function):
5570 * keymap.c (push_key_description):
5571 * search.c (Freplace_match):
5572 * xdisp.c (message_dolog, set_message_1): All callers changed.
5574 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5576 * keyboard.c (safe_run_hook_funcall): New function.
5577 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5578 don't set the hook to nil, but remove the offending function instead.
5579 (Qcommand_hook_internal): Remove, unused.
5580 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5581 Vcommand_hook_internal.
5583 * eval.c (enum run_hooks_condition): Remove.
5584 (funcall_nil, funcall_not): New functions.
5585 (run_hook_with_args): Call each function through a `funcall' argument.
5586 Remove `cond' argument, now redundant.
5587 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5588 (Frun_hook_with_args_until_failure): Adjust accordingly.
5589 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5591 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5593 * dispextern.h (string_buffer_position): Remove declaration.
5595 * print.c (strout): Remove parameter `multibyte', unused since
5596 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5598 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5599 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5600 All callers changed.
5602 * w32.c (_wsa_errlist): Use braces for struct initializers.
5604 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5605 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5606 All callers changed.
5607 (string_buffer_position): Likewise. Also, make static (it's never
5608 used outside xdisp.c).
5609 (cursor_row_p): Remove parameter `w', unused since
5610 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5611 (decode_mode_spec): Remove parameter `precision', introduced during
5612 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5613 All callers changed.
5615 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5617 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5619 2011-03-27 Anders Lindgren <andlind@gmail.com>
5621 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5622 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5623 (ns_update_auto_hide_menu_bar): New functions.
5624 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5625 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5626 ns_constrain_all_frames.
5627 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5628 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5630 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5632 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5634 2011-03-27 Glenn Morris <rgm@gnu.org>
5636 * syssignal.h: Replace RETSIGTYPE with void.
5637 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5638 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5639 Replace SIGTYPE with void everywhere.
5640 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5641 * s/template.h (SIGTYPE): Remove commented out definition.
5643 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5645 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5646 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5648 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5650 * w32.c (read_unc_volume): Use parameter `henum', instead of
5651 global variable `wget_enum_handle'.
5653 * keymap.c (describe_vector): Remove parameters `indices' and
5654 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5655 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5657 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5659 * keyboard.c (timer_check): Remove parameter `do_it_now',
5660 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5661 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5662 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5664 * keyboard.c (read_char):
5665 * w32menu.c (w32_menu_display_help):
5666 * xmenu.c (show_help_event, menu_help_callback):
5667 Adjust calls to `show_help_echo'.
5669 * gtkutil.c (xg_maybe_add_timer):
5670 * keyboard.c (readable_events):
5671 * process.c (wait_reading_process_output):
5672 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5674 * insdel.c (adjust_markers_gap_motion):
5675 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5676 (gap_left, gap_right): Don't call it.
5678 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5680 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5681 incurred during fontification.
5683 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5685 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5686 (DEFVAR_PER_BUFFER): Don't pass it.
5688 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5689 (scrolling_window): Don't pass it.
5691 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5693 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5695 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5697 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5698 of variables specific to SELinux and computation of `encoded_absname'.
5700 * image.c (XPutPixel): Remove unused variable `height'.
5702 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5704 * unexw32.c (get_section_info): Remove unused variable `section'.
5706 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5707 (system_process_attributes): Remove unused variable `sess'.
5708 (sys_read): Remove unused variable `err'.
5710 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5711 (w32_wnd_proc): Remove unused variable `isdead'.
5712 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5713 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5714 (x_create_tip_frame): Remove unused variable `tem'.
5716 * w32inevt.c (w32_console_read_socket):
5717 Remove unused variable `no_events'.
5719 * w32term.c (x_draw_composite_glyph_string_foreground):
5720 Remove unused variable `width'.
5722 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5724 * w32term.c (x_set_glyph_string_clipping):
5725 Don't pass uninitialized region to CombineRgn.
5727 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5729 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5730 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5731 (Fx_close_connection): Remove unused variable `i'.
5733 * w32font.c (w32font_draw): Return number of glyphs.
5734 (w32font_open_internal): Remove unused variable `i'.
5735 (w32font_driver): Add missing initializer.
5737 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5738 (fill_in_menu): Remove unused variable `items_added'.
5740 * w32term.c (last_mouse_press_frame): Remove static global variable.
5741 (w32_clip_to_row): Remove unused variable `f'.
5742 (x_delete_terminal): Remove unused variable `i'.
5744 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5745 (NOTHING): Remove unused static global variable.
5746 (uniscribe_check_otf): Remove unused variable `table'.
5747 (uniscribe_font_driver): Add missing initializers.
5749 2011-03-23 Julien Danjou <julien@danjou.info>
5751 * term.c (Fsuspend_tty, Fresume_tty):
5752 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5753 * window.c (temp_output_buffer_show):
5754 * insdel.c (signal_before_change):
5755 * frame.c (Fhandle_switch_frame):
5756 * fileio.c (Fdo_auto_save):
5757 * emacs.c (Fkill_emacs):
5758 * editfns.c (save_excursion_restore):
5759 * cmds.c (internal_self_insert):
5760 * callint.c (Fcall_interactively):
5761 * buffer.c (Fkill_all_local_variables):
5762 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5764 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5765 unconditionnaly since it does the check itself.
5767 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5769 Fix more problems found by GCC 4.5.2's static checks.
5771 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5772 the first time through the loop, since we know p0 < p1 then.
5773 This also avoids a gcc -Wstrict-overflow warning.
5775 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5776 leading to a memory leak, possible in functions like
5777 load_charset_map_from_file that can allocate an unbounded number
5778 of objects (Bug#8318).
5780 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5781 that could (at least in theory) be that large.
5783 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5784 This is less likely to overflow, and avoids undefined behavior if
5785 overflow does occur. All callers changed. Use strtoul to scan
5786 for the unsigned long integer.
5787 (pint2hrstr): Simplify and tune code slightly.
5788 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5790 * scroll.c (do_scrolling): Work around GCC bug 48228.
5791 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5793 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5794 This also avoids a warning with gcc -Wstrict-overflow.
5795 (validate_x_resource_name): Simplify count usage.
5796 This also avoids a warning with gcc -Wstrict-overflow.
5798 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5801 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5803 * process.c (Fmake_network_process): Use socklen_t, not int,
5804 where POSIX says socklen_t is required in portable programs.
5805 This fixes a porting bug on hosts like 64-bit HP-UX, where
5806 socklen_t is wider than int (Bug#8277).
5807 (Fmake_network_process, server_accept_connection):
5808 (wait_reading_process_output, read_process_output):
5811 * process.c: Rename or move locals to avoid shadowing.
5812 (list_processes_1, Fmake_network_process):
5813 (read_process_output_error_handler, exec_sentinel_error_handler):
5814 Rename or move locals.
5815 (Fmake_network_process): Define label "retry_connect" only if needed.
5816 (Fnetwork_interface_info): Fix pointer signedness.
5817 (process_send_signal): Add cast to avoid pointer signedness problem.
5818 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5819 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5821 Make tparam.h and terminfo.c consistent.
5822 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5823 Include tparam.h instead, since it declares them.
5824 * cm.h (PC): Remove extern decl; tparam.h now does this.
5825 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5826 * terminfo.c: Include tparam.h, to check interfaces.
5827 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5828 (tparam): Adjust signature to match interface in tparam.h;
5829 this removes some undefined behavior. Check that outstring and len
5830 are zero, which they always are with Emacs.
5831 * tparam.h (PC, BC, UP): New extern decls.
5833 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5834 (xftfont_open): Rename locals to avoid shadowing.
5836 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5837 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5838 (OTF_TAG_SYM): Omit macro if not needed.
5839 (ftfont_list): Remove unused local.
5840 (get_adstyle_property, ftfont_pattern_entity):
5841 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5842 Rename locals to avoid shadowing.
5844 * xfont.c (xfont_list_family): Mark var as initialized.
5846 * xml.c (make_dom): Now static.
5848 * composite.c (composition_compute_stop_pos): Rename local to
5850 (composition_reseat_it): Remove unused locals.
5851 (find_automatic_composition, composition_adjust_point): Likewise.
5852 (composition_update_it): Mark var as initialized.
5853 (find_automatic_composition): Mark vars as initialized,
5854 with a FIXME (Bug#8290).
5856 character.h: Rename locals to avoid shadowing.
5857 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5858 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5859 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5860 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5863 * textprop.c (property_change_between_p): Remove; unused.
5865 * intervals.c (interval_start_pos): Now static.
5867 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5869 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5870 Rename locals to avoid shadowing.
5872 * sound.c (wav_play, au_play, Fplay_sound_internal):
5873 Fix pointer signedness.
5874 (alsa_choose_format): Remove unused local var.
5875 (wav_play): Initialize a variable to 0, to prevent undefined
5876 behavior (Bug#8278).
5878 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5880 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5882 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5883 clobbering (Bug#8298).
5884 * sysdep.c (sys_subshell): Likewise.
5885 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5887 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5888 This should get cleaned up, so that child_setup has the
5889 same signature on all platforms.
5891 * callproc.c (call_process_cleanup): Now static.
5892 (relocate_fd): Rename locals to avoid shadowing.
5894 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5896 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5897 not to be necessary, and produces flickering.
5899 2011-03-20 Glenn Morris <rgm@gnu.org>
5901 * config.in: Remove file.
5903 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5905 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5906 are now in src/globals.h.
5907 (syms_of_minibuf): Remove spurious & from previous change.
5909 2011-03-20 Leo <sdl.web@gmail.com>
5911 * minibuf.c (completing-read-function): New variable.
5912 (completing-read-default): Rename from completing-read.
5913 (completing-read): Call completing-read-function.
5915 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5917 * xfaces.c (Fx_load_color_file):
5918 Read color file from absolute filename (bug#8250).
5920 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5922 * makefile.w32-in: Update dependencies.
5924 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5926 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5928 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5930 Fix more problems found by GCC 4.5.2's static checks.
5932 * process.c (make_serial_process_unwind, send_process_trap):
5933 (sigchld_handler): Now static.
5935 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5936 That way, the code declares only the vars that it needs.
5937 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5938 * s/cygwin.h (PTY_ITERATION): Likewise.
5939 * s/darwin.h (PTY_ITERATION): Likewise.
5940 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5942 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5943 * process.c (allocate_pty): Don't declare stb unless it's needed.
5945 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5946 (CONSTANTLIM): Remove; unused.
5947 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5948 Define only if needed.
5950 * unexelf.c (unexec): Name an expression,
5951 to avoid gcc -Wbad-function-cast warning.
5952 Use a different way to cause a compilation error if anyone uses
5953 n rather than nn, a way that does not involve shadowing.
5954 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5956 * deps.mk (unexalpha.o): Remove; unused.
5958 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5959 * unexec.h: New file.
5960 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5961 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5963 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5964 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5965 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5966 Change as necessary to match prototype in unexec.h.
5968 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5970 (back_comment, skip_chars): Mark vars as initialized.
5972 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5973 Rename locals to avoid shadowing.
5975 * lread.c (read1): Rewrite so as not to use empty "else".
5976 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5978 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5980 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5981 warning when compiling print.c.
5983 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5984 instead of using an uninitialized var.
5985 (font_sort_entities): Mark var as initialized.
5987 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5989 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5990 pointers to constants.
5991 (font_parse_fcname): Remove unused vars.
5992 (font_delete_unmatched): Now static.
5993 (font_get_spec): Remove; unused.
5994 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5995 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5996 Rename or move locals to avoid shadowing.
5998 * fns.c (require_nesting_list, require_unwind): Now static.
5999 (Ffillarray): Rename locals to avoid shadowing.
6001 * floatfns.c (domain_error2): Define only if needed.
6002 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6004 * alloc.c (mark_backtrace): Move decl from here ...
6005 * lisp.h: ... to here, so that it can be checked.
6007 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6008 (Fdefvar): Rewrite so as not to use empty "else".
6009 (lisp_indirect_variable): Name an expression,
6010 to avoid gcc -Wbad-function-cast warning.
6011 (Fdefvar): Rename locals to avoid shadowing.
6013 * callint.c (quotify_arg, quotify_args): Now static.
6014 (Fcall_interactively): Rename locals to avoid shadowing.
6015 Use const pointer when appropriate.
6017 * lisp.h (get_system_name, get_operating_system_release):
6018 Move decls here, to check interfaces.
6019 * process.c (get_operating_system_release): Move decl to lisp.h.
6020 * xrdb.c (get_system_name): Likewise.
6021 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6022 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6023 some of which prompt warnings from gcc -Wbad-function-cast.
6024 (Fformat_time_string, Fencode_time, Finsert_char):
6025 (Ftranslate_region_internal, Fformat):
6026 Rename or remove local vars to avoid shadowing.
6027 (Ftranslate_region_internal): Mark var as initialized.
6029 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6032 * lisp.h (eassert): Check that the argument compiles, even if
6033 ENABLE_CHECKING is not defined.
6035 * data.c (Findirect_variable): Name an expression, to avoid
6036 gcc -Wbad-function-cast warning.
6037 (default_value, arithcompare, arith_driver, arith_error): Now static.
6038 (store_symval_forwarding): Rename local to avoid shadowing.
6039 (Fmake_variable_buffer_local, Fmake_local_variable):
6040 Mark variables as initialized.
6041 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6043 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6044 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6045 Rename locals to avoid shadowing.
6046 (mark_stack): Move local variables into the #ifdef region where
6048 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6049 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6051 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6052 (GC_STRING_CHARS): Remove; not used.
6053 (Fmemory_limit): Cast sbrk's returned value to char *.
6055 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6056 avoids undefined behavior in theory.
6058 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6060 Use functions, not macros, for up- and down-casing (Bug#8254).
6061 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6062 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6063 to use the following functions instead of these macros.
6064 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6065 EMACS_INT, since callers assume the returned value fits in int.
6066 (upcase1): Likewise, for UPCASE_TABLE.
6067 (uppercasep, lowercasep, upcase): New static inline functions.
6068 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6069 the race-condition problem in the old DOWNCASE.
6071 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6072 Rename locals to avoid shadowing.
6073 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6074 (regex_compile, re_search_2, re_match_2_internal):
6075 Remove unused local vars.
6076 (FREE_VAR): Rewrite so as not to use empty "else",
6077 which gcc can warn about.
6078 (regex_compile, re_match_2_internal): Mark locals as initialized.
6079 (RETALLOC_IF): Define only if needed.
6080 (WORDCHAR_P): Likewise. This one is never needed, but is used
6081 only in a comment talking about a compiler bug, so put inside
6082 the #if 0 of that comment.
6083 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6084 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6087 * search.c (boyer_moore): Rename locals to avoid shadowing.
6088 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6089 (PREV_CHAR_BOUNDARY): Likewise.
6091 * search.c (simple_search): Remove unused var.
6093 * dired.c (compile_pattern): Move decl from here ...
6094 * lisp.h: ... to here, so that it can be checked.
6095 (struct re_registers): New forward decl.
6097 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6099 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6101 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6102 Rename locals to avoid shadowing.
6103 (Fvertical_motion): Mark locals as initialized.
6105 * casefiddle.c (casify_object, casify_region): Now static.
6106 (casify_region): Mark local as initialized.
6108 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6110 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6111 New macros, so that the caller can use some names other than
6112 gcpro1, gcpro2, etc.
6113 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6115 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6116 argument, for consistency with GCPRO2_VAR, etc: it is now the
6117 prefix of the variable, not the variable itself. All uses
6119 * dired.c (directory_files_internal, file_name_completion):
6120 Rename locals to avoid shadowing.
6122 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6123 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6124 dired.c's scmp function, had undefined behavior.
6125 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6126 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6127 * buffer.h: ... to here, because these macros use current_buffer,
6128 and the new implementation with inline functions needs to have
6129 current_buffer in scope now, rather than later when the macros
6131 (downcase, upcase1): New static inline functions.
6132 (DOWNCASE, UPCASE1): Reimplement using these functions.
6133 This avoids undefined behavior in expressions like
6134 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6135 from race conditions in accessing the global variables
6136 case_temp1 and case_temp2.
6137 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6138 * lisp.h (case_temp1, case_temp2): Remove their decls.
6139 * character.h (ASCII_CHAR_P): Move from here ...
6140 * lisp.h: ... to here, so that the inline functions mentioned
6143 * dired.c (directory_files_internal_unwind): Now static.
6145 * fileio.c (file_name_as_directory, directory_file_name):
6146 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6148 (file_name_as_directory): Use const pointers when appropriate.
6149 (Fexpand_file_name): Likewise. In particular, newdir might
6150 point at constant storage, so make it a const pointer.
6151 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6152 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6154 (Fset_file_times, Finsert_file_contents, auto_save_error):
6155 Rename locals to avoid shadowing.
6157 * minibuf.c (choose_minibuf_frame_1): Now static.
6158 (Ftry_completion, Fall_completions): Rename or remove locals
6161 * marker.c (bytepos_to_charpos): Remove; unused.
6163 * lisp.h (verify_bytepos, count_markers): New decls,
6164 so that gcc does not warn that these functions aren't declared.
6166 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6167 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6168 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6169 (copy_text): Remove unused local var.
6171 * filelock.c (within_one_second): Now static.
6172 (lock_file_1): Rename local to avoid shadowing.
6174 * buffer.c (fix_overlays_before): Mark locals as initialized.
6175 (fix_start_end_in_overlays): Likewise. This function should be
6176 simplified by using pointers-to-pointers, but that's a different
6178 (switch_to_buffer_1): Now static.
6179 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6180 (report_overlay_modification): Rename locals to avoid shadowing.
6182 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6183 Fix pointer signedness issue.
6184 (sys_subshell): Mark local as volatile if checking for lint,
6185 to suppress a gcc -Wclobbered warning that does not seem to be right.
6186 (MAXPATHLEN): Define only if needed.
6188 * process.c (serial_open, serial_configure): Move decls from here ...
6189 * systty.h: ... to here, so that they can be checked.
6191 * fns.c (get_random, seed_random): Move extern decls from here ...
6192 * lisp.h: ... to here, so that they can be checked.
6194 * sysdep.c (reset_io): Now static.
6195 (wait_for_termination_signal): Remove; unused.
6197 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6198 (copy_keymap_item, append_key, push_text_char_description):
6200 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6201 (DENSE_TABLE_SIZE): Remove; unused.
6202 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6203 (describe_map_tree):
6204 Rename locals to avoid shadowing.
6206 * keyboard.c: Declare functions static if they are not used elsewhere.
6207 (echo_char, echo_dash, cmd_error, top_level_2):
6208 (poll_for_input, handle_async_input): Now static.
6209 (read_char, kbd_buffer_get_event, make_lispy_position):
6210 (make_lispy_event, make_lispy_movement, apply_modifiers):
6211 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6212 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6213 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6214 (read_key_sequence, read_char): Mark locals as initialized.
6215 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6217 * keyboard.h (make_ctrl_char): New decl.
6218 (mark_kboards): Move decl here ...
6219 * alloc.c (mark_kboards): ... from here.
6221 * lisp.h (force_auto_save_soon): New decl.
6223 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6224 (DEFINE_DUMMY_FUNCTION): New macro.
6225 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6227 (main): Add casts to avoid warnings
6228 if GCC considers string literals to be constants.
6230 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6232 * dbusbind.c: Pointer signedness fixes.
6233 (xd_signature, xd_append_arg, xd_initialize):
6234 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6235 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6236 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6237 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6239 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6240 if GCC considers string literals to be constants.
6241 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6243 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6245 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6246 (print_preprocess, print_object): New macro to fix last change.
6248 * print.c (print_preprocess): Don't forget font objects.
6250 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6252 * emacs.c (USAGE3): Doc fixes.
6254 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6256 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6259 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6261 * lisp.h (VWindow_system, Qfile_name_history):
6262 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6263 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6264 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6266 * w32select.c: Don't #include "keyboard.h".
6267 (run_protected): Add extern declaration for waiting_for_input.
6269 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6270 * w32console.c (detect_input_pending, read_input_pending)
6271 (encode_terminal_code):
6272 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6273 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6274 (w32_system_caret_y, Qfile_name_history):
6275 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6276 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6277 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6278 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6279 * w32proc.c (Qlocal, report_file_error):
6280 * w32term.c (Vwindow_system, updating_frame):
6281 * w32uniscribe.c (initialized, uniscribe_font_driver):
6282 Remove unneeded extern declarations.
6284 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6286 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6288 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6290 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6291 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6292 These macros can no longer be used for assignment.
6294 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6295 Assign struct members directly, instead of using BUF_BEGV etc.
6296 (record_buffer_markers, fetch_buffer_markers): New functions for
6297 recording and fetching special buffer markers.
6298 (set_buffer_internal_1, set_buffer_temp): Use them.
6300 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6302 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6304 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6305 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6307 * xdisp.c (hscroll_window_tree):
6308 (reconsider_clip_changes): Use PT instead of BUF_PT.
6310 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6312 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6313 $(EMACS_ROOT)/lib/intprops.h.
6315 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6317 Fix more problems found by GCC 4.5.2's static checks.
6319 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6320 to unsigned char * to avoid compiler diagnostic.
6321 (xg_free_frame_widgets): Make it clear that a local variable is
6322 needed only if USE_GTK_TOOLTIP.
6323 (gdk_window_get_screen): Make it clear that this macro is needed
6324 only if USE_GTK_TOOLTIP.
6325 (int_gtk_range_get_value): New function, which avoids a diagnostic
6326 from gcc -Wbad-function-cast.
6327 (xg_set_toolkit_scroll_bar_thumb): Use it.
6328 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6329 diagnostic from gcc -Wbad-function-cast.
6330 (get_utf8_string, xg_get_file_with_chooser):
6331 Rename locals to avoid shadowing.
6332 (create_dialog): Move locals to avoid shadowing.
6334 * xgselect.c (xg_select): Remove unused var.
6336 * image.c (four_corners_best): Mark locals as initialized.
6337 (gif_load): Initialize transparent_p to zero (Bug#8238).
6338 Mark another local as initialized.
6339 (my_png_error, my_error_exit): Mark with NO_RETURN.
6341 * image.c (clear_image_cache): Now static.
6342 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6343 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6344 (x_edge_detection): Remove unnecessary cast that
6345 gcc -Wbad-function-cast diagnoses.
6346 (gif_load): Fix pointer signedness.
6347 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6348 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6350 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6352 Improve quality of tests for time stamp overflow.
6353 For example, without this patch (encode-time 0 0 0 1 1
6354 1152921504606846976) returns the obviously-bogus value (-948597
6355 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6356 reports time overflow. See
6357 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6358 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6359 * editfns.c: Include limits.h and intprops.h.
6360 (TIME_T_MIN, TIME_T_MAX): New macros.
6361 (time_overflow): Move earlier, to before first use.
6362 (hi_time, lo_time): New functions, for an accurate test for
6364 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6365 (Fget_internal_run_time): Don't assume time_t fits in int.
6366 (make_time): Use list2 instead of Fcons twice.
6367 (Fdecode_time): More accurate test for out-of-range times.
6368 (check_tm_member): New function.
6369 (Fencode_time): Use it, to test for out-of-range times.
6370 (lisp_time_argument): Don't rely on undefined left-shift and
6371 right-shift behavior when checking for time stamp overflow.
6373 * editfns.c (time_overflow): New function, refactoring common code.
6374 (Fformat_time_string, Fdecode_time, Fencode_time):
6375 (Fcurrent_time_string): Use it.
6377 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6378 * dired.c (make_time): Move to ...
6379 * editfns.c (make_time): ... here.
6380 * systime.h: Note the move.
6382 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6384 * fringe.c (update_window_fringes): Remove unused variables.
6386 * unexmacosx.c (copy_data_segment): Also copy __got section.
6389 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6391 * termcap.c [MSDOS]: Include "msdos.h".
6392 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6393 Constify `char *' arguments and their references according to
6394 prototypes in tparam.h.
6396 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6398 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6399 Adapt all references accordingly.
6401 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6403 2011-03-11 Tom Tromey <tromey@redhat.com>
6405 * buffer.c (syms_of_buffer): Remove obsolete comment.
6407 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6409 * termhooks.h (encode_terminal_code): Declare prototype.
6411 * msdos.c (encode_terminal_code): Don't declare prototype.
6413 * term.c (encode_terminal_code): Now external again, used by
6414 w32console.c and msdos.c.
6416 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6417 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6419 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6421 Fix some minor problems found by GCC 4.5.2's static checks.
6423 * fringe.c (update_window_fringes): Mark locals as initialized
6425 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6427 * alloc.c (mark_fringe_data): Move decl from here ...
6428 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6429 to check its interface.
6430 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6432 * fontset.c (free_realized_fontset): Now static.
6433 (Fset_fontset_font): Rename local to avoid shadowing.
6434 (fontset_font): Mark local as initialized.
6435 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6437 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6439 * xselect.c (x_disown_buffer_selections): Remove; not used.
6440 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6441 (x_own_selection, Fx_disown_selection_internal): Rename locals
6443 (x_handle_dnd_message): Remove local to avoid shadowing.
6445 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6446 so that the caller can use some name other than gcpro1.
6447 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6448 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6449 (Fx_backspace_delete_keys_p):
6450 Use them to avoid shadowing, and rename vars to avoid shadowing.
6451 (x_decode_color, x_set_name, x_window): Now static.
6452 (Fx_create_frame): Add braces to silence GCC warning.
6453 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6454 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6455 Remove unused locals.
6456 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6457 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6458 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6461 * xterm.h (x_mouse_leave): New decl.
6463 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6464 Remove unused functions.
6465 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6466 (x_calc_absolute_position): Now static.
6467 (XTread_socket): Don't define label "out" unless it's used.
6468 Don't declare local "event" unless it's used.
6469 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6470 unless they are used.
6471 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6472 (x_fatal_error_signal): Remove; not used.
6473 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6474 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6475 (x_error_catcher, x_connection_closed, x_error_handler):
6476 (x_error_quitter, xembed_send_message, x_iconify_frame):
6477 (my_log_handler): Rename locals to avoid shadowing.
6478 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6479 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6481 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6482 Rename or move locals to avoid shadowing.
6483 (tty_defined_color, merge_face_heights): Now static.
6484 (free_realized_faces_for_fontset): Remove; not used.
6485 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6486 does not deduce is never used uninitialized.
6487 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6488 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6490 * terminal.c (store_terminal_param): Now static.
6492 * xmenu.c (menu_highlight_callback): Now static.
6493 (set_frame_menubar): Remove unused local.
6494 (xmenu_show): Rename parameter to avoid shadowing.
6495 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6496 since they might point to immutable storage.
6497 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6498 since it's unused otherwise.
6500 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6501 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6502 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6503 avoids a gcc -Wuninitialized diagnostic.
6504 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6505 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6506 does not deduce are never used uninitialized.
6508 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6510 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6511 * window.c (window_loop, size_window):
6512 (run_window_configuration_change_hook, enlarge_window): Likewise.
6514 * window.c (display_buffer): Now static.
6515 (size_window): Mark variables that gcc -Wuninitialized
6516 does not deduce are never used uninitialized.
6517 * window.h (check_all_windows): New decl, to forestall
6518 gcc -Wmissing-prototypes diagnostic.
6519 * dispextern.h (bidi_dump_cached_states): Likewise.
6521 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6523 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6525 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6526 and to avoid gcc -Wuninitialized warning.
6527 (load_charset_map): Mark variables that gcc -Wuninitialized
6528 does not deduce are never used uninitialized.
6529 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6531 * coding.c (coding_set_source, coding_set_destination):
6532 Use "else { /* comment */ }" rather than "else /* comment */;"
6533 for clarity, and to avoid gcc -Wempty-body warning.
6534 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6535 a block, when the outer 'i' will do.
6536 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6537 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6538 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6539 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6540 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6541 Rename locals to avoid shadowing.
6542 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6543 * coding.c (emacs_mule_char, encode_invocation_designation):
6544 Now static, since they're not used elsewhere.
6545 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6546 (decode_coding_object, encode_coding_object, detect_coding_system):
6547 (decode_coding_emacs_mule): Mark variables that gcc
6548 -Wuninitialized does not deduce are never used uninitialized.
6549 (detect_coding_iso_2022): Initialize a local variable that might
6550 be used uninitialized. Leave a FIXME because it's not clear that
6551 this initialization is needed. (Bug#8211)
6552 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6553 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6554 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6555 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6556 Remove unused macros.
6558 * category.c (hash_get_category_set): Remove unused local var.
6559 (copy_category_table): Now static, since it's not used elsewhere.
6560 * character.c (string_count_byte8): Likewise.
6562 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6563 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6565 * chartab.c (copy_sub_char_table): Now static, since it's not used
6567 (sub_char_table_ref_and_range, char_table_ref_and_range):
6568 Rename locals to avoid shadowing.
6569 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6571 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6572 (BIDI_BOB): Remove unused macro.
6574 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6575 deduce are never used uninitialized.
6576 * term.c (encode_terminal_code): Likewise.
6578 * term.c (encode_terminal_code): Now static. Remove unused local.
6580 * tparam.h: New file.
6581 * term.c, tparam.h: Include it.
6582 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6583 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6584 Move these decls to tparam.h, and make them agree with what
6585 is actually in tparam.c. The previous trick of using incompatible
6586 decls in different modules does not conform to the C standard.
6587 All callers of tparam changed to use tparam's actual API.
6588 * tparam.c (tparam1, tparam, tgoto):
6589 Use const pointers where appropriate.
6591 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6592 * cm.h (struct cm): Likewise.
6593 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6594 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6595 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6596 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6597 (turn_on_face, init_tty): Likewise.
6598 * termchar.h (struct tty_display_info): Likewise.
6600 * term.c (term_mouse_position): Rename local to avoid shadowing.
6602 * alloc.c (mark_ttys): Move decl from here ...
6603 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6605 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6607 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6609 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6611 * search.c (compile_pattern_1): Remove argument regp, unused since
6612 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6613 (compile_pattern): Don't pass it.
6615 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6617 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6618 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6620 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6622 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6624 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6625 gdk_window_get_screen, gdk_window_get_geometry,
6626 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6627 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6628 (xg_get_pixbuf_from_pixmap): New function.
6629 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6630 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6631 Call xg_get_pixbuf_from_pixmap instead of
6632 gdk_pixbuf_get_from_drawable.
6633 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6634 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6635 (xg_check_special_colors): Use GtkStyleContext and its functions
6637 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6638 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6639 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6640 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6641 Call gtk_widget_get_preferred_size.
6642 (xg_frame_resized): gdk_window_get_geometry only takes 5
6644 (xg_win_to_widget, xg_event_is_for_menubar):
6645 Call gdk_x11_window_lookup_for_display.
6646 (xg_set_widget_bg): New function.
6647 (delete_cb): New function.
6648 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6649 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6650 (xg_set_background_color): Call xg_set_widget_bg.
6651 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6652 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6653 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6654 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6656 (update_frame_tool_bar): Call gtk_widget_hide.
6657 (xg_initialize): Use GDK_KEY_g.
6659 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6661 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6663 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6664 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6665 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6667 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6669 * w32xfns.c (select_palette): Check success of RealizePalette against
6670 GDI_ERROR, not zero.
6672 See ChangeLog.11 for earlier changes.
6678 Copyright (C) 2011 Free Software Foundation, Inc.
6680 This file is part of GNU Emacs.
6682 GNU Emacs is free software: you can redistribute it and/or modify
6683 it under the terms of the GNU General Public License as published by
6684 the Free Software Foundation, either version 3 of the License, or
6685 (at your option) any later version.
6687 GNU Emacs is distributed in the hope that it will be useful,
6688 but WITHOUT ANY WARRANTY; without even the implied warranty of
6689 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6690 GNU General Public License for more details.
6692 You should have received a copy of the GNU General Public License
6693 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.