1 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3 * image.c (imagemagick_load_image): Remove unused label.
5 2012-06-11 Glenn Morris <rgm@gnu.org>
7 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
8 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
9 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
10 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
12 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
14 * alloc.c (make_byte_code): New function.
15 (Fmake_byte_code): Use it. Don't purify here.
16 * lread.c (read1): Use it as well to avoid extra allocation.
18 2012-06-11 Chong Yidong <cyd@gnu.org>
20 * image.c (imagemagick_load_image): Implement transparency.
22 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
24 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
25 account for preceding backslashes. (Bug#11663)
27 2012-06-09 Chong Yidong <cyd@gnu.org>
29 * term.c: Support italics in capable terminals (Bug#9652).
30 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
31 (turn_on_face): Output using TS_enter_italic_mode if available.
32 Don't handle unused blinking and alt-charset cases.
33 (turn_off_face): Handle italic case; discard unused tty_blinking_p
34 and tty_alt_charset_p cases.
35 (tty_capable_p, init_tty): Support italics.
37 * termchar.h (struct tty_display_info): Add field for italics.
38 Remove unused blink field.
40 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
43 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
44 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
45 tty_alt_charset_p. Add tty_italic_p.
47 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
49 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
50 dbus_type_is_basic if available.
51 (xd_extract_signed, xd_extract_unsigned): Rename from
52 extract_signed and extract_unsigned, respectively. Adapt callers.
54 2012-06-09 Chong Yidong <cyd@gnu.org>
56 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
58 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
61 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
63 * xdisp.c (vmessage): Treat frame message as multibyte.
64 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
65 would generate the diagnostic "Making \302\247 buffer-local while
68 2012-06-08 Eli Zaretskii <eliz@gnu.org>
70 * dispnew.c (showing_window_margins_p): Undo last change, which
71 was done due to an inadvertent commit.
72 (adjust_frame_glyphs_for_frame_redisplay): Do call
73 showing_window_margins_p.
75 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
77 * eval.c (Fmake_var_non_special): New primitive.
78 (syms_of_eval): Defsubr it.
79 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
81 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
83 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
84 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
86 2012-06-08 Eli Zaretskii <eliz@gnu.org>
88 * alloc.c (allocate_vectorlike): Fix last change.
90 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
92 Block-based vector allocation of small vectors.
93 * lisp.h (struct vectorlike_header): New field `nbytes',
94 adjust comment accordingly.
95 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
96 to denote vector blocks. Adjust users (live_vector_p,
97 mark_maybe_pointer, valid_lisp_object_p) accordingly.
98 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
99 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
100 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
101 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
102 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
103 (roundup_size): New constant.
104 (struct vector_block): New data type.
105 (vector_blocks, vector_free_lists, zero_vector): New variables.
106 (all_vectors): Rename to `large_vectors'.
107 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
108 (sweep_vectors): New functions.
109 (allocate_vectorlike): Return `zero_vector' as the only vector of
110 0 items. Allocate new vector from block if vector size is less than
111 or equal to VBLOCK_BYTES_MAX.
112 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
113 (init_alloc_once): Add call to init_vectors.
115 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
117 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
119 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
121 * doprnt.c (doprnt): Truncate multibyte char correctly.
122 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
123 would mishandle a string argument "Xc" if X was a multibyte
124 character of length 2: it would truncate after X's first byte
125 rather than including all of X.
127 2012-06-06 Chong Yidong <cyd@gnu.org>
129 * buffer.c (word_wrap): Doc fix.
131 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
133 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
135 2012-06-03 Glenn Morris <rgm@gnu.org>
137 * xdisp.c (tool-bar-style): Doc fix.
139 2012-06-03 Ulrich Müller <ulm@gentoo.org>
141 * Makefile.in (PAXCTL): Define.
142 (temacs$(EXEEXT)): Disable memory randomization for the temacs
143 binary via PaX flags if the paxctl utility is available.
144 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
145 Restore PaX flags to their default. (Bug#11398)
147 2012-06-03 Chong Yidong <cyd@gnu.org>
149 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
152 2012-06-03 Chong Yidong <cyd@gnu.org>
154 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
155 (note_mode_line_or_margin_highlight): If there is no help echo,
156 use mode-line-default-help-echo. Handle the case where the mouse
157 position is past the end of the mode line string.
159 * buffer.c (buffer_local_value_1): New function, split from
160 Fbuffer_local_value; can return Qunbound.
161 (Fbuffer_local_value): Use it.
162 (Vmode_line_format): Docstring tweaks.
164 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
166 * sysdep.c (system_process_attributes): Improve comment.
168 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
170 * keyboard.c: Export real-this-command to Elisp.
171 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
172 and DEFVAR it. Update all users.
174 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
176 * minibuf.c (Fassoc_string): Remove duplicate declaration.
178 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
179 Convert pctcpu and pctmem to Lisp float properly.
180 Let the compiler fold better, as 100.0/0x8000 is exact.
182 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
184 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
187 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
189 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
191 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
193 For a 'struct window', replace some Lisp_Object fields to
194 bitfields where appropriate, remove unused fields.
195 * window.h (struct window): Remove unused 'last_mark_x' and
196 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
197 change it's type from Lisp_Object to bitfield.
198 Change type of 'force_start', 'optional_new_start',
199 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
200 fields from Lisp_Object to bitfield. Adjust users accordingly.
202 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
204 Pacify gcc -Wdouble-precision when using Xaw.
205 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
206 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
207 Use 'float' consistently, rather than 'float' in most places
208 and 'double' in a couple of places.
210 2012-05-31 Eli Zaretskii <eliz@gnu.org>
212 * xdisp.c (handle_stop): Detect whether we have overlay strings
213 loaded by testing it->current.overlay_string_index to be
214 non-negative, instead of checking whether n_overlay_strings is
215 positive. (Bug#11587)
217 2012-05-31 Chong Yidong <cyd@gnu.org>
219 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
221 * doc.c (Fsubstitute_command_keys): Doc fix.
223 2012-05-31 Eli Zaretskii <eliz@gnu.org>
225 * search.c (search_buffer): Remove calls to
226 r_alloc_inhibit_buffer_relocation, as it is now called by
227 maybe_unify_char, which was the cause of relocation of buffer text
230 2012-05-31 Eli Zaretskii <eliz@gnu.org>
232 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
233 for the duration of call to load_charset, to avoid problems with
234 callers of maybe_unify_char that access buffer text through C
237 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
238 decrement the inhibition flag, instead of just setting or
241 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
243 Remove obsolete '#define static' cruft.
244 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
245 This #undef was "temporary" in 2000; it is no longer needed
246 now that '#define static' has gone away.
247 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
248 (gray_bitmap_bits): Remove; no longer needed.
249 All uses replaced with definiens.
250 * xterm.c: Include "bitmaps/gray.xbm".
252 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
254 Clean up __executable_start, monstartup when --enable-profiling.
255 The following changes affect the code only when profiling.
256 * dispnew.c (__executable_start): Rename from safe_bcopy.
257 Define only on platforms that need it.
258 * emacs.c: Include <sys/gmon.h> when profiling.
259 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
260 (__executable_start): Remove decl, since lisp.h does it now.
261 (safe_bcopy): Remove decl; no longer has that name.
262 (main): Coalesce #if into single bit of code, for simplicity.
263 Cast pointers to uintptr_t, since standard libraries want integers
265 * lisp.h (__executable_start): New decl.
267 2012-05-31 Glenn Morris <rgm@gnu.org>
269 * image.c (Fimagemagick_types): Doc fix.
271 2012-05-30 Jim Meyering <meyering@redhat.com>
273 * callproc.c (Fcall_process_region): Include directory component
274 in mkstemp error message (Bug#11586).
276 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
278 * alloc.c, lisp.h (make_pure_vector): Now static.
280 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
282 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
284 (Fautoload): Do the hash-doc more carefully.
285 * data.c (Fdefalias): Purify definition, except for keymaps.
286 (Qdefun): Move from eval.c.
287 * lisp.h (Qdefun): Remove.
288 * lread.c (read1): Tiny simplification.
290 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
292 Do not create empty overlays with the evaporate property (Bug#9642).
293 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
294 Bug#9642, but explicitly check that the buffer the overlay would
295 be moved to is live and rearrange lines to make sure that errors
296 will not put the overlay in an inconsistent state.
297 (Fdelete_overlay): Cosmetics.
299 2012-05-28 Eli Zaretskii <eliz@gnu.org>
301 * w32term.c (my_bring_window_to_top): New function.
302 (x_raise_frame): Use handle returned by DeferWindowPos, which
303 could be different from the original one.
304 Call my_bring_window_to_top instead of my_set_foreground_window.
307 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
308 by calling BringWindowToTop.
310 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
311 (WM_EMACS_END): Increase by one.
313 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
315 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
316 This avoids undefined behavior that might cause the eassert
317 to not catch an out-of-range value.
319 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
321 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
324 2012-05-27 Eli Zaretskii <eliz@gnu.org>
326 * bidi.c (bidi_mirror_char): Fix last change.
328 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
330 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
331 when referring to sectname field in printf format.
333 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
335 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
336 Only r_alloc_inhibit_buffer_relocation needed to be added;
337 the others were already declared.
339 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
340 before checking whether it's out of range. Put the check inside
342 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
344 2012-05-27 Ken Brown <kbrown@cornell.edu>
346 * callproc.c (Fcall_process): Restore a line that was accidentally
347 commented out in the 2011-02-13 change (bug#11547).
349 2012-05-27 Eli Zaretskii <eliz@gnu.org>
351 * lisp.h [REL_ALLOC]: Add prototypes for external functions
354 * buffer.c [REL_ALLOC]: Remove prototypes of
355 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
356 they are now on lisp.h.
358 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
360 * search.c (search_buffer): Use it to inhibit relocation of buffer
361 text while re_search_2 is doing its job, because re_search_2 is
362 passed C pointers to buffer text. (Bug#11519)
364 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
367 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
368 state after an additional call to move_it_in_display_line_to, keep
369 the values of it->max_ascent and it->max_descent found for the
371 (pos_visible_p): Revert the comparison against bottom_y to what it
372 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
375 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
377 Fix coding-related core dumps with gcc -ftrapv.
378 The code was computing A - B, where A and B are pointers, and B is
379 random garbage. This can lead to core dumps on platforms that
380 have special pointer registers, and it also leads to core dumps on
381 x86-64 when compiled with gcc -ftrapv. The fix is to compute
382 A - B only when B is initialized properly.
383 * coding.c (coding_set_source, coding_set_destination): Return void.
384 (coding_change_source, coding_change_destinations): New functions,
385 with the old behaviors of coding_set_source and coding_set_destination.
386 All callers that need an offset changed to use these new functions.
388 2012-05-26 Glenn Morris <rgm@gnu.org>
390 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
392 2012-05-26 Eli Zaretskii <eliz@gnu.org>
394 Extend mouse support on W32 text-mode console.
395 * xdisp.c (draw_row_with_mouse_face):
396 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
398 * w32console.c: Include window.h.
399 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
401 (initialize_w32_display): Initialize mouse-highlight data.
403 * w32inevt.c: Include termchar.h and window.h.
404 (do_mouse_event): Support mouse-autoselect-window. When the mouse
405 moves, call note_mouse_highlight. If help_echo changed, call
406 gen_help_event to produce help-echo message in the echo area.
407 Call clear_mouse_face if mouse_face_hidden is set in the mouse
410 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
412 * lread.c (read1): Simplify slightly to avoid an overflow warning
413 with GCC 4.7.0 on x86-64.
415 2012-05-26 Eli Zaretskii <eliz@gnu.org>
417 * bidi.c (bidi_mirror_char): Revert last change: an int is
418 definitely wide enough here.
420 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
422 Fix integer width and related bugs (Bug#9874).
423 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
424 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
425 (string_bytes, check_sblock, allocate_string_data):
426 (compact_small_strings, Fmake_bool_vector, make_string)
427 (make_unibyte_string, make_multibyte_string)
428 (make_string_from_bytes, make_specified_string)
429 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
430 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
433 (allocate_pseudovector):
434 Use int, not EMACS_INT, where int is wide enough.
435 (inhibit_garbage_collection, Fgarbage_collect):
436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
437 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
438 int might not be wide enough.
439 (bidi_cache_search, bidi_cache_find, bidi_init_it)
440 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
441 (bidi_at_paragraph_end, bidi_find_paragraph_start)
442 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
443 (bidi_level_of_next_char, bidi_move_to_visually_next):
444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
445 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
446 (Fkill_buffer, Fset_buffer_major_mode)
447 (advance_to_char_boundary, Fbuffer_swap_text)
448 (Fset_buffer_multibyte, overlays_at, overlays_in)
449 (overlay_touches_p, struct sortvec, record_overlay_string)
450 (overlay_strings, recenter_overlay_lists)
451 (adjust_overlays_for_insert, adjust_overlays_for_delete)
452 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
453 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
454 (Foverlay_recenter, last_overlay_modification_hooks_used)
455 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
457 (validate_region): Omit unnecessary test for b <= e,
458 since that's guaranteed by the previous test.
459 (adjust_overlays_for_delete): Avoid pos + length overflow.
460 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
461 (report_overlay_modification):
462 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
463 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
464 Omit pointer cast, which isn't needed anyway, and doesn't work
465 after the EMACS_INT -> ptrdiff_t change.
466 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
467 * buffer.h: Adjust decls to match defn changes elsewhere.
468 (struct buffer_text, struct buffer):
469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
470 Use EMACS_INT, not int, where int might not be wide enough.
471 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
472 not int, to avoid needless 32-bit limit on 64-bit hosts.
473 (exec_byte_code): Use tighter memory-full test, one that checks
474 for alloca overflow. Don't compute the address of the object just
475 before an array, as that's not portable. Use EMACS_INT, not
476 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
477 * callint.c (Fcall_interactively):
478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
479 * callproc.c (call_process_kill, Fcall_process):
480 Don't assume pid_t fits into an Emacs fixnum.
481 (call_process_cleanup, Fcall_process, child_setup):
482 Don't assume pid_t fits into int.
483 (call_process_cleanup, Fcall_process, delete_temp_file)
484 (Fcall_process_region):
485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
486 (Fcall_process): Simplify handling of volatile integers.
487 Use int, not EMACS_INT, where int will do.
488 * casefiddle.c (casify_object, casify_region, operate_on_word)
489 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
491 (casify_object): Avoid integer overflow when overallocating buffer.
492 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
493 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
494 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
495 * category.h (CATEGORYP): Don't assume arg is nonnegative.
496 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
497 integers are now checked earlier. All uses replaced with XINT.
499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
500 For CCL_MapSingle, check that content and value are in int range.
501 (ccl_driver, Fregister_code_conversion_map):
502 Check that Vcode_version_map_vector is a vector.
503 (resolve_symbol_ccl_program): Check that vector header is in range.
504 Always copy the vector, so that we can check its contents reliably
505 now rather than having to recheck each instruction as it's being
506 executed. Check that vector words fit in 'int'.
507 (ccl_get_compiled_code, Fregister_ccl_program)
508 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
509 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
510 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
511 contents are in range.
512 (Fccl_execute_on_string): Check that status is in range.
513 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
514 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
515 Accept and return EMACS_INT, not int, because callers can pass values
517 (c_string_width, strwidth, lisp_string_width, chars_in_text)
518 (multibyte_chars_in_text, parse_str_as_multibyte)
519 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
520 (str_as_unibyte, str_to_unibyte, string_count_byte8)
521 (string_escape_byte8, Fget_byte):
522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
523 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
524 avoid mishandling large integers.
525 * character.h: Adjust decls to match defn changes elsewhere.
526 * charset.c (load_charset_map_from_file, find_charsets_in_text)
527 (Ffind_charset_region):
528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
529 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
530 (load_charset_map_from_vector, Fdefine_charset_internal):
531 Don't assume fixnum fits in int.
532 (load_charset_map_from_vector, Fmap_charset_chars):
533 Remove now-unnecessary CHECK_NATNUMs.
534 (Fdefine_charset_internal): Check ranges here, more carefully.
535 Don't rely on undefined behavior with signed left shift overflow.
536 Don't assume unsigned int fits into fixnum, or that fixnum fits
537 into unsigned int. Don't require max_code to be a valid fixnum;
538 that's not true for gb10830 4-byte on a 32-bit host. Allow
539 invalid_code to be a cons, for the same reason. Require code_offset
540 to be a character. Avoid int overflow if max_char is close
542 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
543 this is intended anyway and avoids some undefined behavior.
544 (load_charset_map): Pass unsigned, not int, as 2nd arg of
545 INDEX_TO_CODE_POINT, as that's what it expects.
546 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
547 * charset.h (DECODE_CHAR): Return int, not unsigned;
548 this is what was intended anyway, and it avoids undefined behavior.
549 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
550 integer-overflow issues.
551 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
552 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
553 where the argument is EMACS_INT, and this behavior is not intended.
554 * chartab.c (Fmake_char_table, Fset_char_table_range)
555 (uniprop_get_decoder, uniprop_get_encoder):
556 Don't assume fixnum fits in int.
557 * cmds.c (move_point): New function, that does the gist of
558 Fforward_char and Fbackward_char, but does so while checking
559 for integer overflow more accurately.
560 (Fforward_char, Fbackward_char): Use it.
561 (Fforward_line, Fend_of_line, internal_self_insert)
562 (internal_self_insert):
563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
564 Fix a FIXME, by checking for integer overflow when calculating
565 target_clm and actual_clm.
566 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
567 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
568 (ASSURE_DESTINATION, coding_alloc_by_realloc)
569 (coding_alloc_by_making_gap, alloc_destination)
570 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
571 (encode_coding_utf_16, detect_coding_emacs_mule)
572 (decode_coding_emacs_mule, encode_coding_emacs_mule)
573 (detect_coding_iso_2022, decode_coding_iso_2022)
574 (encode_invocation_designation, encode_designation_at_bol)
575 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
576 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
577 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
578 (encode_coding_ccl, encode_coding_raw_text)
579 (detect_coding_charset, decode_coding_charset)
580 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
581 (produce_composition, produce_charset, produce_annotation)
582 (decode_coding, handle_composition_annotation)
583 (handle_charset_annotation, consume_chars, decode_coding_gap)
584 (decode_coding_object, encode_coding_object, detect_coding_system)
585 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
586 (code_convert_region, code_convert_string)
587 (Fdefine_coding_system_internal)
588 (coding_set_source, coding_set_destination):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
591 (Fdefine_coding_system_internal):
592 Don't assume fixnums fit in int.
593 (decode_coding_gap, decode_coding_object, encode_coding_object)
594 (Fread_coding_system, Fdetect_coding_region)
595 (Funencodable_char_position, Fcheck_coding_systems_region)
596 (get_translation, handle_composition_annotation, consume_chars):
597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
598 (consume_chars): Rewrite to not calculate an address outside buffer.
599 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
600 Don't access memory outside of the args array.
601 (Fdefine_coding_system_internal): Check for charset-id overflow.
602 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
603 result of ENCODE_CHAR.
604 * coding.h: Adjust decls to match defn changes elsewhere.
605 (struct coding_system):
606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
607 * composite.c (get_composition_id, find_composition)
608 (run_composition_function, update_compositions)
609 (compose_text, composition_gstring_put_cache)
610 (composition_gstring_p, composition_gstring_width)
611 (fill_gstring_header, fill_gstring_body, autocmp_chars)
612 (composition_compute_stop_pos, composition_reseat_it)
613 (composition_update_it, struct position_record)
614 (find_automatic_composition, composition_adjust_point)
615 (Fcomposition_get_gstring, Ffind_composition_internal):
616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
617 (update_compositions):
618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
619 * composite.h: Adjust decls to match defn changes elsewhere.
620 (struct composition):
621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
622 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
623 Do not attempt to compute the address of the object just before a
624 buffer; this is not portable.
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 (Faset): Use int, not EMACS_INT, where int is wide enough.
628 (Fstring_to_number): Don't assume fixnums fit in int.
629 (Frem): Don't assume arg is nonnegative.
630 * dbusbind.c (xd_append_arg): Check for integers out of range.
631 (Fdbus_call_method): Don't overflow the timeout int.
632 (extract_signed, extract_unsigned): New functions.
633 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
634 (xd_get_connection_references): Return ptrdiff_t, not int.
636 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
638 Use int, not unsigned, where the dbus API uses int.
639 (Fdbus_message_internal): Don't overflow mtype.
640 (syms_of_dbusbind): Allocate right-sized buffer for integers.
641 * dired.c (directory_files_internal, file_name_completion, scmp)
642 (file_name_completion_stat):
643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
644 (file_name_completion): Don't overflow matchcount.
645 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
646 * dispextern.h: Adjust decls to match defn changes elsewhere.
647 (struct text_pos, struct glyph, struct bidi_saved_info)
648 (struct bidi_string_data, struct bidi_it, struct composition_it)
650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
651 (struct display_pos, struct composition_it, struct it):
652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
653 * dispnew.c (increment_matrix_positions)
654 (increment_row_positions, mode_line_string)
655 (marginal_area_string):
656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
657 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
659 (duration_to_sec_usec): New function, to check for overflow better.
660 (Fsleep_for, sit_for): Use it.
661 * doc.c (get_doc_string, store_function_docstring):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 (get_doc_string, Fsnarf_documentation):
664 Use int, not EMACS_INT, where int is wide enough.
666 Use SAFE_ALLOCA, not alloca.
667 Check for overflow when converting EMACS_INT to off_t.
669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
670 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
671 Don't assume uid_t fits into fixnum.
672 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
673 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
674 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
675 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
676 (general_insert_function)
677 (Finsert_char, make_buffer_string, make_buffer_string_both)
678 (update_buffer_properties, Fbuffer_substring)
679 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
680 (Fsubst_char_in_region, check_translation)
681 (Ftranslate_region_internal, save_restriction_restore, Fformat)
682 (transpose_markers, Ftranspose_regions):
683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
684 (clip_to_bounds): Move to lisp.h as an inline function).
685 (Fconstrain_to_field): Don't assume integers are nonnegative.
686 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
687 (Fsubst_char_in_region, Fsave_restriction):
688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
689 (Femacs_pid): Don't assume pid_t fits into fixnum.
690 (lo_time): Use int, not EMACS_INT, when int suffices.
691 (lisp_time_argument): Check for usec out of range.
692 (Fencode_time): Don't assume fixnum fits in int.
693 (Fuser_login_name, Fuser_full_name): Signal an error
694 if a uid argument is out of range, rather than relying on
696 (Fformat_time_string): Remove now-unnecessary check.
697 lisp_time_argument checks for out-of-range usec now.
698 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
699 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
700 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
701 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
702 (init_cmdargs, Fdump_emacs):
703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
704 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
705 the bottom (typically) 32 bits of the fixnum.
706 * eval.c (specpdl_size, call_debugger):
707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
708 (when_entered_debugger, Fbacktrace_debug):
709 Don't assume fixnum can fit in int.
710 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
711 the object just before a buffer; this is not portable.
712 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
713 (grow_specpdl, unbind_to):
714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
715 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
716 (grow_specpdl): Simplify allocation by using xpalloc.
717 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
718 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
719 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
721 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
724 (Fcopy_file, non_regular_nbytes, read_non_regular)
725 (Finsert_file_contents):
726 Use int, not EMACS_INT, where int is wide enough.
727 (READ_BUF_SIZE): Verify that it fits in int.
728 (Finsert_file_contents): Check that counts are in proper range,
729 rather than assuming fixnums fit into ptrdiff_t etc.
730 Don't assume fixnums fit into int.
731 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
732 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
733 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
734 (string_char_to_byte, string_byte_to_char)
735 (string_make_multibyte, string_to_multibyte)
736 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
737 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
738 (substring_both, Fdelete, internal_equal, Ffillarray)
739 (Fclear_string, mapcar1)
740 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
741 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
742 (larger_vector, make_hash_table, maybe_resize_hash_table)
743 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
744 (Fmaphash, secure_hash):
745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
746 (concat): Check for string index and length overflow.
747 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
750 (larger_vector): New API (vec, incr_min, size_max) replaces old
751 one (vec, new_size, init). This catches size overflow.
752 INIT was removed because it was always Qnil.
754 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
755 the upper bound on a hash table index size.
756 (make_hash_table, maybe_resize_hash_table): Use it.
757 (secure_hash): Computer start_byte and end_byte only after
758 they're known to be in ptrdiff_t range.
759 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
760 (Ffont_get_glyphs, Ffont_at):
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
763 (Flist_fonts, Fopen_font):
764 Don't assume fixnum can fit in int.
765 (check_gstring): Don't assume index can fit in int.
766 (font_match_p): Check that fixnum is a character, not a nonnegative
767 fixnum, since the later code needs to stuff it into an int.
768 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
769 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
770 conversion overflow issues.
771 (Fopen_font): Check for integer out of range.
772 (Ffont_get_glyphs): Don't assume index can fit in int.
773 * font.h: Adjust decls to match defn changes elsewhere.
774 * fontset.c (reorder_font_vector): Redo score calculation to avoid
776 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
777 printmax_t, where ptrdiff_t is wide enough.
778 (Finternal_char_font):
779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
780 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
781 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
782 (Fset_frame_position, x_set_frame_parameters)
783 (x_set_line_spacing, x_set_border_width)
784 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
785 Check that fixnums are in proper range for system types.
786 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
788 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
789 Use SAFE_ALLOCA_LISP, not alloca.
790 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
791 intptr_t is wide enough.
792 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
793 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
794 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
795 Check for fixnum out of range.
796 * ftfont.c (ftfont_list): Don't assume index fits in int.
797 Check that fixnums are in proper range for system types.
798 (ftfont_shape_by_flt):
799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
800 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
802 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
803 Check that fixnums are in proper range for system types.
804 * gnutls.h: Adjust decls to match defn changes elsewhere.
805 * gtkutil.c (xg_dialog_run):
806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
807 (update_frame_tool_bar):
808 Check that fixnums are in proper range for system types.
809 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
810 (lookup_image): Check that fixnums are in range for system types.
811 * indent.c (last_known_column, last_known_column_point):
812 (current_column_bol_cache):
813 (skip_invisible, current_column, check_display_width):
814 (check_display_width, scan_for_column, current_column_1)
815 (Findent_to, Fcurrent_indentation, position_indentation)
816 (indented_beyond_p, Fmove_to_column, compute_motion):
817 (Fcompute_motion, Fvertical_motion):
818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
819 (last_known_column_modified): Use EMACS_INT, not int.
820 (check_display_width):
822 Check that fixnums and floats are in proper range for system types.
823 (compute_motion): Don't assume index or fixnum fits in int.
824 (compute_motion, Fcompute_motion):
825 Use int, not EMACS_INT, when it is wide enough.
826 (vmotion): Omit local var start_hpos that is always 0; that way
827 we don't need to worry about overflow in expressions involving it.
828 * indent.h: Adjust decls to match defn changes elsewhere.
830 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
831 Use int, not EMACS_INT, where int is wide enough.
832 Remove unused members ovstring_chars_done and tab_offset;
834 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
835 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
836 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
837 (make_gap, copy_text, insert, insert_and_inherit)
838 (insert_before_markers, insert_before_markers_and_inherit)
839 (insert_1, count_combining_before, count_combining_after)
840 (insert_1_both, insert_from_string)
841 (insert_from_string_before_markers, insert_from_string_1)
842 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
843 (adjust_after_replace, adjust_after_insert, replace_range)
844 (replace_range_2, del_range, del_range_1, del_range_byte)
845 (del_range_both, del_range_2, modify_region)
846 (prepare_to_modify_buffer, signal_before_change)
847 (signal_after_change, Fcombine_after_change_execute):
848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
849 * intervals.c (traverse_intervals, rotate_right, rotate_left)
850 (balance_an_interval, split_interval_right, split_interval_left)
851 (find_interval, next_interval, update_interval)
852 (adjust_intervals_for_insertion, delete_node, delete_interval)
853 (interval_deletion_adjustment, adjust_intervals_for_deletion)
854 (static_offset_intervals, offset_intervals)
855 (merge_interval_right, merge_interval_left, make_new_interval)
856 (graft_intervals_into_buffer, temp_set_point_both)
857 (temp_set_point, set_point, adjust_for_invis_intang)
858 (set_point_both, move_if_not_intangible, get_property_and_range)
859 (get_local_map, copy_intervals, copy_intervals_to_string)
860 (compare_string_intervals, set_intervals_multibyte_1):
861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
862 * intervals.h: Adjust decls to match defn changes elsewhere.
864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
865 * keyboard.c (this_command_key_count, this_single_command_key_start)
866 (before_command_key_count, before_command_echo_length, echo_now)
867 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
868 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
869 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
870 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
872 (last_non_minibuf_size, last_point_position, echo_truncate)
873 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
874 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
875 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
876 (stuff_buffered_input):
877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
878 (last_auto_save, command_loop_1, read_char):
879 Use EMACS_INT, not int, to avoid integer overflow.
880 (record_char): Avoid overflow in total_keys computation.
881 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
882 * keyboard.h: Adjust decls to match defn changes elsewhere.
883 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
884 (Fkey_description, Fdescribe_vector, Flookup_key):
885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
886 (click_position): New function, to check that positions are in range.
887 (Fcurrent_active_maps):
889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
890 (Faccessible_keymaps, Fkey_description):
891 (preferred_sequence_p):
892 Don't assume fixnum can fit into int.
893 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
894 Check for integer overflow in size calculations.
895 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
896 avoid mishandling large integers.
897 * lisp.h: Adjust decls to match defn changes elsewhere.
898 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
899 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
900 (struct Lisp_Marker):
901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
902 (clip_to_bounds): Now an inline function, moved here from editfns.c.
903 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
904 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
906 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
907 Assume the arg has valid form, since it always does.
908 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
909 unsigned integer system type.
910 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
911 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
913 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
914 (duration_to_sec_usec): New decl.
915 * lread.c (read_from_string_index, read_from_string_index_byte)
916 (read_from_string_limit, readchar, unreadchar, openp)
917 (read_internal_start, read1, oblookup):
918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
919 (Fload, readevalloop, Feval_buffer, Feval_region):
920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
921 (openp): Check for out-of-range argument to 'access'.
922 (read1): Use int, not EMACS_INT, where int is wide enough.
923 Don't assume fixnum fits into int.
924 Fix off-by-one error that can read outside a buffer.
925 (read_filtered_event): Use duration_to_sec_usec
926 to do proper overflow checking on durations.
927 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
929 (Fexecute_kbd_macro):
930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
931 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
932 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
933 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
934 (set_marker_both, set_marker_restricted_both, marker_position)
935 (marker_byte_position, Fbuffer_has_markers_at):
936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
937 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
938 * menu.c (ensure_menu_items): Rename from grow_menu_items.
939 It now merely ensures that the menu is large enough, without
940 necessarily growing it, as this avoids some integer overflow issues.
942 (keymap_panes, parse_single_submenu, Fx_popup_menu):
943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
944 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
945 Use SAFE_ALLOCA_LISP, not alloca.
946 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
947 to EMACS_INT. Check that fixnums are in proper range for system types.
948 * minibuf.c (minibuf_prompt_width, string_to_object)
949 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
950 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
952 (get_minibuffer, read_minibuf_unwind):
953 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
954 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
955 this simplifies overflow checking. All callers changed.
956 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
959 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
960 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
961 Check that fixnums are in proper range for system types.
962 (Fx_create_frame, Fx_show_tip):
963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
964 * nsfont.m (ns_findfonts, nsfont_list_family):
965 Don't assume fixnum fits in long.
966 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
968 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
970 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
971 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
972 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
973 (PRINTDECLARE, PRINTPREPARE):
974 (strout, print_string):
975 (print, print_preprocess, print_check_string_charset_prop)
977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
979 (temp_output_buffer_setup, Fprin1_to_string, print_object):
980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
981 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
982 (printchar, strout): Use xpalloc to catch size calculation overflow.
983 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
984 (print_error_message): Use SAFE_ALLOCA, not alloca.
985 (print_object): Use int, not EMACS_INT, where int is wide enough.
986 (print_depth, new_backquote_output, print_number_index):
987 Use ptrdiff_t, not int, where int might not be wide enough.
988 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
989 (Fset_process_window_size, Fformat_network_address)
990 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
992 Check that fixnums are in proper range for system types.
993 (Fsignal_process): Simplify by avoiding a goto.
994 Check for process-ids out of pid_t range rather than relying on
996 (process_tick, update_tick): Use EMACS_INT, not int.
997 (Fformat_network_address, read_process_output, send_process)
998 (Fprocess_send_region, status_notify):
999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1000 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1001 (wait_reading_process_output, read_process_output, exec_sentinel):
1002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1003 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1004 (Faccept_process_output): Use duration_to_sec_usec to do proper
1005 overflow checking on durations.
1006 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1007 Don't assume pid_t fits in int.
1008 * process.h (struct Lisp_Process): Members tick and update_tick
1009 are now of type EMACS_INT, not int.
1010 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1011 configured --with-wide-int.
1012 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1013 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1014 * search.c (looking_at_1, string_match_1):
1015 (fast_string_match, fast_c_string_match_ignore_case)
1016 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1017 (scan_newline, find_before_next_newline, search_command)
1018 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1019 (set_search_regs, wordify):
1022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1023 (string_match_1, search_buffer, set_search_regs):
1025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1026 (wordify): Check for overflow in size calculation.
1027 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1028 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1029 Check that fixnums are in proper range for system types.
1030 * sound.c (struct sound_device)
1031 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1033 (Fplay_sound_internal):
1034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1035 * syntax.c (struct lisp_parse_state, find_start_modiff)
1036 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1037 (Fparse_partial_sexp):
1038 Don't assume fixnums can fit in int.
1039 (struct lisp_parse_state, find_start_pos, find_start_value)
1040 (find_start_value_byte, find_start_begv)
1041 (update_syntax_table, char_quoted, dec_bytepos)
1042 (find_defun_start, prev_char_comend_first, back_comment):
1043 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1044 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1046 (Finternal_describe_syntax_value): Check that match_lisp is a
1047 character, not an integer, since the code stuffs it into int.
1048 (scan_words, scan_sexps_forward):
1049 Check that fixnums are in proper range for system types.
1051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1052 (scan_sexps_forward):
1053 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1054 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1055 * syntax.h: Adjust decls to match defn changes elsewhere.
1056 (struct gl_state_s):
1057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1058 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1059 MOST_POSITIVE_FIXNUM.
1060 * sysdep.c (wait_for_termination_1, wait_for_termination)
1061 (interruptible_wait_for_termination, mkdir):
1062 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1063 (emacs_read, emacs_write):
1064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1065 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1066 and double all fit in int.
1067 * term.c (set_tty_color_mode):
1068 Check that fixnums are in proper range for system types.
1069 * termhooks.h (struct input_event):
1070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1071 * textprop.c (validate_interval_range, interval_of)
1072 (Fadd_text_properties, set_text_properties_1)
1073 (Fremove_text_properties, Fremove_list_of_text_properties)
1074 (Ftext_property_any, Ftext_property_not_all)
1075 (copy_text_properties, text_property_list, extend_property_ranges)
1076 (verify_interval_modification):
1077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1078 (Fnext_single_char_property_change)
1079 (Fprevious_single_char_property_change):
1080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1081 (copy_text_properties):
1082 Check for integer overflow in index calculation.
1083 * undo.c (last_boundary_position, record_point, record_insert)
1084 (record_delete, record_marker_adjustment, record_change)
1085 (record_property_change):
1086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1087 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1089 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1090 (Fx_hide_tip, Fx_file_dialog):
1091 * w32menu.c (set_frame_menubar):
1092 Use ptrdiff_t, not int, for consistency with rest of code.
1093 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1094 (select_window, Fdelete_other_windows_internal)
1095 (window_scroll_pixel_based, window_scroll_line_based)
1096 (Frecenter, Fset_window_configuration):
1097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1098 (Fset_window_hscroll, run_window_configuration_change_hook)
1099 (set_window_buffer, temp_output_buffer_show, scroll_command)
1100 (Fscroll_other_window, Frecenter):
1101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1102 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1103 Don't assume fixnum fits in int.
1104 (Fset_window_scroll_bars):
1105 Check that fixnums are in proper range for system types.
1106 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1107 (string_pos, c_string_pos, number_of_chars, init_iterator)
1108 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1109 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1110 (compute_display_string_end, handle_face_prop)
1111 (face_before_or_after_it_pos, handle_invisible_prop)
1112 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1113 (display_prop_intangible_p, string_buffer_position_lim)
1114 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1115 (get_overlay_strings_1, get_overlay_strings)
1116 (iterate_out_of_display_property, forward_to_next_line_start)
1117 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1118 (get_next_display_element, set_iterator_to_next)
1119 (get_visually_first_element, compute_stop_pos_backwards)
1120 (handle_stop_backwards, next_element_from_buffer)
1121 (move_it_in_display_line_to, move_it_in_display_line)
1122 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1123 (add_to_log, message_dolog, message_log_check_duplicate)
1124 (message2, message2_nolog, message3, message3_nolog
1125 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1126 (current_message_1, truncate_echo_area, truncate_message_1)
1127 (set_message, set_message_1, store_mode_line_noprop)
1128 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1129 (text_outside_line_unchanged_p, check_point_in_composition)
1130 (reconsider_clip_changes)
1131 (redisplay_internal, set_cursor_from_row, try_scrolling)
1132 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1133 (redisplay_window, find_last_unchanged_at_beg_row)
1134 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1135 (trailing_whitespace_p, find_row_edges, display_line)
1136 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1137 (display_mode_element, store_mode_line_string)
1138 (pint2str, pint2hrstr, decode_mode_spec)
1139 (display_count_lines, display_string, draw_glyphs)
1140 (x_produce_glyphs, x_insert_glyphs)
1141 (rows_from_pos_range, mouse_face_from_buffer_pos)
1142 (fast_find_string_pos, mouse_face_from_string_pos)
1143 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1145 (safe_call, init_from_display_pos, handle_fontified_prop)
1146 (handle_single_display_spec, load_overlay_strings)
1147 (with_echo_area_buffer, setup_echo_area_for_printing)
1148 (display_echo_area, echo_area_display)
1149 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1150 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1151 (redisplay_window, dump_glyph_row, display_mode_line)
1152 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1153 (handle_display_spec, display_prop_string_p):
1154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1155 (handle_single_display_spec, build_desired_tool_bar_string)
1156 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1157 (get_specified_cursor_type):
1158 Check that fixnums are in proper range for system types.
1159 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1160 (Flookup_image_map):
1161 Don't assume fixnums fit in int.
1162 (compare_overlay_entries):
1163 Avoid mishandling comparisons due to subtraction overflow.
1164 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1165 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1166 (handle_tool_bar_click):
1167 Use int, not unsigned, since we prefer signed and the signedness
1168 doesn't matter here.
1169 (get_next_display_element, next_element_from_display_vector):
1170 Use int, not EMACS_INT, when int is wide enough.
1171 (start_hourglass): Use duration_to_sec_usec to do proper
1172 overflow checking on durations.
1173 * xfaces.c (Fbitmap_spec_p):
1174 Check that fixnums are in proper range for system types.
1175 (compare_fonts_by_sort_order):
1176 Avoid mishandling comparisons due to subtraction overflow.
1177 (Fx_family_fonts, realize_basic_faces):
1178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1180 Don't assume fixnum fits in int.
1181 Use SAFE_ALLOCA_LISP, not alloca.
1182 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1183 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1184 (face_at_buffer_position, face_for_overlay_string)
1185 (face_at_string_position):
1186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1187 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1188 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1190 Check that fixnums are in proper range for system types.
1191 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1192 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1194 (Fx_change_window_property): Don't assume fixnums fit in int.
1195 * xfont.c (xfont_chars_supported):
1196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1197 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1198 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1200 * xml.c (parse_region):
1201 * xrdb.c (magic_file_p):
1202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1203 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1204 (x_get_local_selection, x_reply_selection_request)
1205 (x_handle_selection_request, wait_for_property_change):
1206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1207 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1208 short is wide enough.
1209 (x_send_client_event): Don't assume fixnum fits in int.
1210 * xterm.c (x_x_to_emacs_modifiers):
1211 Don't assume EMACS_INT overflows nicely into int.
1212 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1214 (handle_one_xevent): NATNUMP can eval its arg twice.
1215 (x_connection_closed):
1216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1217 * xterm.h: Adjust decls to match defn changes elsewhere.
1218 (struct scroll_bar): Use struct vectorlike_header
1219 rather than rolling our own approximation.
1220 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1222 2012-05-25 Glenn Morris <rgm@gnu.org>
1224 * lisp.mk (lisp): Update for more files being compiled now.
1226 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1228 * lread.c: Remove `read_pure' which makes no difference.
1229 (read_pure): Remove var.
1230 (unreadpure): Remove function.
1231 (readevalloop): Don't call read_list with -1 flag.
1232 (read1, read_vector): Don't test read_pure any more.
1233 (read_list): Simplify.
1235 * fileio.c, character.h: Minor style tweaks.
1237 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1239 * window.h (clip_changed): Remove useless declaration.
1241 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1243 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1244 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1246 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1249 This directory predates autoconf and is no longer needed nowadays.
1250 Move its few remaining bits of functionality to where they're needed.
1251 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1252 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1253 * m/template.h: Remove.
1254 * Makefile.in (M_FILE): Remove. All uses removed.
1255 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1256 * lisp.h (USE_LSB_TAG):
1257 * mem-limits.h (EXCEEDS_LISP_PTR):
1258 Use VAL_MAX, not VALBITS, in #if.
1259 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1260 (EMACS_UINT): Define unconditionally now.
1261 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1262 (BITS_PER_EMACS_INT): New constants, replacing
1263 what used to be in config.h, but not useful in #if.
1264 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1265 define them any more.
1266 (VAL_MAX): New macro.
1268 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1269 BITS_PER_EMACS_INT, in #if.
1270 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1271 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1272 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1273 * s/ms-w32.h (DATA_START):
1274 Move here from removed file m/intel386.h.
1275 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1276 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1278 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1280 Assume C89 or later.
1281 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1282 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1284 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1285 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1286 * textprop.c, tparam.c (NULL): Remove.
1287 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1288 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1289 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1290 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1291 * xterm.c (input_signal_count): Assume volatile works.
1293 2012-05-21 Ken Brown <kbrown@cornell.edu>
1295 * xgselect.c (xg_select): Fix first argument in call to 'select'
1298 2012-05-20 Ken Brown <kbrown@cornell.edu>
1300 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1301 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1303 2012-05-19 Ken Brown <kbrown@cornell.edu>
1305 * xfns.c (x_in_use): Remove `static' qualifier.
1306 * xterm.h (x_in_use): Declare.
1307 * xgselect.c: Include xterm.h.
1308 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1309 and `display_arg' (bug#9754).
1311 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1313 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1315 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1316 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1318 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1320 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1322 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1323 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1325 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1326 reference to image_cache->refcount.
1327 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1329 2012-05-17 Juri Linkov <juri@jurta.org>
1331 * search.c (Fword_search_regexp, Fword_search_backward)
1332 (Fword_search_forward, Fword_search_backward_lax)
1333 (Fword_search_forward_lax): Move functions to isearch.el
1334 (bug#10145, bug#11381).
1336 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1338 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1340 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1342 * lread.c (init_obarray): Declare Qt and Qnil as special.
1344 2012-05-14 Glenn Morris <rgm@gnu.org>
1346 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1347 Put "libexec" before "bin", for the sake of init_callproc_1.
1349 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1351 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1353 * unexaix.c: Port to more-recent AIX compilers.
1354 (report_error, report_error_1, make_hdr, copy_sym)
1355 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1356 Make arguments const char *, not char *, to avoid violations of C
1357 standard and to fix some AIX warnings reported by Gilles Pion.
1359 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1361 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1362 already have overlays loaded.
1363 (handle_single_display_spec): Before returning without displaying
1364 fringe bitmap, synchronize the bidi iterator with the main display
1365 iterator, by calling iterate_out_of_display_property.
1366 (iterate_out_of_display_property): Detect buffer iteration by
1367 testing that it->string is a Lisp string.
1368 (get_next_display_element): When the current object is exhausted,
1369 and there's something on it->stack, call set_iterator_to_next to
1370 proceed with what's on the stack, instead of returning zero.
1371 (set_iterator_to_next): If called at the end of a Lisp string,
1372 proceed to consider_string_end without incrementing string
1373 position. Don't increment display vector index past the end of
1374 the display vector. (Bug#11417)
1375 (pos_visible_p): Don't report a position visible when move_it_to
1376 stopped at the last line of window, which happens to be scanned
1377 backwards by the bidi iteration. (Bug#11464)
1379 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1381 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1382 and right-margin display specs even if the spec is invalid or we
1383 are on a TTY, and thus unable to display on the fringes.
1384 That's because the text with the property will not be displayed anyway,
1385 so we need to signal to the caller that this is a "replacing"
1386 display spec. This fixes display when the spec is invalid or we
1389 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1391 * unexaix.c (make_hdr): Fix typo in prototype.
1392 This bug broke the build on AIX. Problem reported by Gilles Pion.
1394 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1396 * keyboard.c (kbd_buffer_get_event): Read special events also in
1397 batch mode. (Bug#11415)
1399 2012-05-12 Glenn Morris <rgm@gnu.org>
1401 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1403 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1405 * lisp.mk (lisp): Add newcomment.elc.
1407 2012-05-12 Glenn Morris <rgm@gnu.org>
1409 * Makefile.in (MKDIR_P): New, set by configure.
1410 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1412 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1414 Remove unused function hourglass_started.
1415 * dispextern.h (hourglass_started):
1416 * w32fns.c (hourglass_started):
1417 * xdisp.c (hourglass_started): Remove.
1419 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1421 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1422 Update dependencies.
1424 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1426 * xgselect.c (xg_select): Put maxfds+1 into a var.
1427 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1429 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1431 2012-05-10 Dave Abrahams <dave@boostpro.com>
1433 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1434 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1436 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1438 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1439 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1440 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1441 Initialize xd_registered_buses.
1443 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1445 Untag more efficiently if USE_LSB_TAG.
1446 This is based on a proposal by YAMAMOTO Mitsuharu in
1447 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1448 For an admittedly artificial (nth 8000 longlist) benchmark on
1449 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1450 Emacs's overall text size by 1%.
1451 * lisp.h (XUNTAG): New macro.
1452 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1453 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1454 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1455 * eval.c (Fautoload):
1456 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1457 * frame.h (XFRAME): Use XUNTAG.
1459 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1460 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1461 Remove unportable assumptions about print widths of types like
1463 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1464 intptr_t when converting between pointer and integer, to avoid GCC
1465 warnings about wrong width.
1467 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1469 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1470 stack for each reader_thread, instead of defaulting to 8MB
1471 determined by the linker. This avoids failures in creating
1472 subprocesses on Windows 7, see the discussion in this thread:
1473 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1475 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1477 Fix up display of the *Minibuf-0* buffer in the mini window.
1478 * keyboard.c (read_char): Don't clear the echo area if there's no
1480 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1481 contents of *Minibuf-0*) if there's no message displayed in its stead.
1483 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1485 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1488 2012-05-06 Chong Yidong <cyd@gnu.org>
1490 * lisp.mk (lisp): Update.
1492 2012-05-05 Jim Meyering <meyering@redhat.com>
1494 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1496 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1498 * data.c (PUT_ERROR): New macro.
1499 (syms_of_data): Use it. Add new error type `user-error'.
1500 * undo.c (user_error): New function.
1501 (Fprimitive_undo): Use it.
1502 * print.c (print_error_message): Adjust print style for `user-error'.
1503 * keyboard.c (user_error): New function.
1504 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1506 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1508 Do not limit current-time-string to years 1000..9999.
1509 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1510 (Fcurrent_time_string): Support any year that is supported by the
1511 underlying localtime representation. Don't use asctime, as it
1512 has undefined behavior for years outside the range -999..9999.
1514 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1516 Fix race conditions involving setenv, gmtime, localtime, asctime.
1517 Without this fix, interrupts could mess up code that uses these
1518 nonreentrant functions, since setting TZ invalidates existing
1519 tm_zone or tzname values, and since most of these functions return
1520 pointers to static storage.
1521 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1522 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1523 Grow the critical sections to include not just invoking
1524 localtime/gmtime, but also accessing these functions' results
1525 including their tm_zone values if any, and any related TZ setting.
1526 (format_time_string): Last arg is now struct tm *, not struct tm **,
1527 so that the struct tm is saved in the critical section.
1528 All callers changed. Simplify allocation of initial buffer, partly
1529 motivated by the fact that memory allocation needs to be outside
1530 the critical section.
1532 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1534 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1535 with RESET_INTERVAL.
1537 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1538 Remove duplicated buffer name initialization.
1540 2012-05-02 Jim Meyering <jim@meyering.net>
1542 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1544 * xfns.c (x_window): Use xstrdup (Bug#11375).
1546 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1548 * xdisp.c (pos_visible_p): If already at a newline from the
1549 display string before the 'while' loop, don't walk back the glyphs
1550 from it3.glyph_row. Solves assertion violation when the display
1551 string begins with a newline (egg.el). (Bug#11367)
1553 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1555 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1558 2012-05-01 Glenn Morris <rgm@gnu.org>
1560 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1561 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1562 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1563 All were removed before 23.1.
1565 * dispnew.c: Remove HAVE_LIBNCURSES test;
1566 it is always true on relevant platforms.
1568 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1569 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1571 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1573 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1575 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1576 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1579 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1581 Do not avoid creating empty evaporating overlays (Bug#9642).
1582 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1583 That is, do not delete an evaporating overlay if it becomes
1584 empty after its bounds are adjusted to fit within its buffer.
1585 This fix caused other problems, and I'm reverting it until we get
1586 to the bottom of them.
1588 2012-04-27 Chong Yidong <cyd@gnu.org>
1590 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1592 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1594 * xdisp.c (pos_visible_p): If the window start position is beyond
1595 ZV, start the display from buffer beginning. Prevents assertion
1596 violation in init_iterator when the minibuffer window is scrolled
1599 * window.c (window_scroll_pixel_based): Likewise.
1601 2012-04-27 Chong Yidong <cyd@gnu.org>
1603 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1605 2012-04-27 Glenn Morris <rgm@gnu.org>
1607 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1608 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1610 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1612 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1613 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1615 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1617 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1618 display element, check also the underlying string or buffer
1619 character. (Bug#11341)
1621 * w32menu.c: Include w32heap.h.
1622 (add_menu_item): If the call to AppendMenuW (via
1623 unicode_append_menu) fails, disable Unicode menus only if we are
1624 running on Windows 9X/Me.
1626 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1628 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1629 (xgetint): Add missing shift for LSB tags.
1631 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1633 * keyboard.c (read_char): Don't wipe echo area for select window
1634 events: These might get delayed via `mouse-autoselect-window'
1637 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1639 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1640 manipulation of :loaded-from data.
1642 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1644 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1645 now a cons (bug#11311).
1647 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1649 Do not create empty overlays with the evaporate property (Bug#9642).
1650 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1651 if it becomes empty after its bounds are adjusted to fit within
1652 its buffer. Without this fix, in a nonempty buffer (let ((o
1653 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1654 yields an empty overlay that has the evaporate property, which is
1655 not supposed to happen.
1657 Fix minor GTK3 problems found by static checking.
1658 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1659 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1660 (struct _EmacsFixedClass, emacs_fixed_get_type):
1661 Move decls here from emacsgtkfixed.h, since they needn't be public.
1662 (emacs_fixed_get_type): Now static.
1663 (emacs_fixed_class_init): Omit unused local.
1664 (emacs_fixed_child_type): Remove; unused.
1665 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1666 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1667 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1668 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1669 (EMACS_FIXED_GET_CLASS): Remove; unused.
1670 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1672 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1673 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1675 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1677 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1678 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1679 (__malloc_size_t, __malloc_ptrdiff_t):
1680 Remove. All uses removed, replaced by the definiens if needed,
1681 since we can assume C89 or better now.
1682 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1683 (protect_malloc_state, align, get_contiguous_space)
1684 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1685 (malloc_atfork_handler_child, malloc_enable_thread)
1686 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1687 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1688 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1689 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1690 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1691 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1692 Define using prototypes, not old style.
1693 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1694 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1695 (align): Don't assume that signed integer overflow wraps around.
1696 Omit unused local var.
1697 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1698 (_free_internal_nolock, memalign, mallochook, reallochook):
1699 Omit no-longer-needed casts.
1700 (valloc): Use getpagesize, not __getpagesize.
1701 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1702 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1704 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1706 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1708 Move functions from C to Lisp. Make non-blocking method calls
1709 the default. Implement further D-Bus standard interfaces.
1711 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1712 (QCdbus_request_name_allow_replacement)
1713 (QCdbus_request_name_replace_existing)
1714 (QCdbus_request_name_do_not_queue)
1715 (QCdbus_request_name_reply_primary_owner)
1716 (QCdbus_request_name_reply_in_queue)
1717 (QCdbus_request_name_reply_exists)
1718 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1719 (QCdbus_registered_serial, QCdbus_registered_method)
1720 (QCdbus_registered_signal): New Lisp objects.
1721 (XD_DEBUG_MESSAGE): Use sizeof.
1722 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1723 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1724 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1725 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1726 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1727 (xd_signature, xd_append_arg): Allow float for integer types.
1728 (xd_get_connection_references): New function.
1729 (xd_get_connection_address): Rename from xd_initialize.
1730 Return cached address.
1731 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1732 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1734 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1735 Return number of refcounts.
1736 (Fdbus_get_unique_name): Make stronger parameter check.
1737 (Fdbus_message_internal): New defun.
1738 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1739 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1740 (Fdbus_send_signal, Fdbus_register_service)
1741 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1742 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1743 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1744 (Vdbus_compiled_version, Vdbus_runtime_version)
1745 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1746 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1747 (Vdbus_message_type_signal): New defvars.
1748 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1751 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1753 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1754 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1755 Do not assume ptrdiff_t is the same width as 'int'.
1757 * alloc.c: Handle unusual debugging option combinations.
1758 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1759 since the two debugging options are incompatible.
1760 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1762 (mem_init, mem_insert, mem_insert_fixup):
1763 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1764 (NEED_MEM_INSERT): Remove; no longer needed.
1766 2012-04-22 Leo Liu <sdl.web@gmail.com>
1768 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1770 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1772 * sysdep.c [__FreeBSD__]: Minor cleanups.
1773 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1774 Use Emacs indenting style more consistently. Avoid some casts.
1775 Use 'double' consistently rather than mixing 'float' and 'double'.
1777 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1779 * sysdep.c (list_system_processes, system_process_attributes):
1780 Add implementation for FreeBSD (Bug#5243).
1782 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1784 * lisp.mk (lisp): Update.
1786 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1788 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1789 It is never used otherwise.
1791 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1793 * print.c (print_preprocess): Only check print_depth if print-circle
1795 (print_object): Check for cycles even when print-circle is nil and
1796 print-gensym is t, but only check print_depth if print-circle is nil.
1798 2012-04-20 Chong Yidong <cyd@gnu.org>
1800 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1801 set the status to "failed" and ensure that sentinel is run.
1803 2012-04-20 Glenn Morris <rgm@gnu.org>
1805 * process.c (Fset_process_inherit_coding_system_flag)
1806 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1807 (Fmake_network_process, Fmake_serial_process): Doc fix.
1809 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1811 * xdisp.c (string_buffer_position_lim): Limit starting position to
1813 (set_cursor_from_row): If called for a mode-line or header-line
1814 row, return zero immediately.
1815 (try_cursor_movement): If inside continuation line, don't back up
1816 farther than the first row after the header line, if any.
1817 Don't consider the header-line row as "partially visible", even if
1818 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1820 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1822 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1825 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1826 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1828 configure: new option --enable-gcc-warnings (Bug#11207)
1829 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1830 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1831 (ALL_CFLAGS): Use new macros rather than old.
1832 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1833 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1834 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1835 -Wunused-result, -Wunused-variable. This should go away once
1836 the Emacs and Gnulib regex code is merged.
1837 (xmalloc, xrealloc): Now static.
1839 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1841 * dired.c (Fsystem_groups): Remove unused local.
1843 2012-04-17 Glenn Morris <rgm@gnu.org>
1845 * dired.c (Fsystem_users): Doc fix.
1847 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1849 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1850 (syms_of_dired): Add them.
1852 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1854 Fix minor alloc.c problems found by static checking.
1855 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1856 New extern decls, to avoid calling undeclared functions.
1857 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1858 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1859 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1860 (NEED_MEM_INSERT): New macro.
1861 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1862 Remove one incorrect comment and fix another.
1864 Fix minor ralloc.c problems found by static checking.
1865 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1866 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1867 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1868 (r_alloc_sbrk): Now static.
1870 Improve ralloc.c interface checking.
1871 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1872 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1873 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1874 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1875 [REL_ALLOC]: ... to here, to check interface.
1876 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1877 Remove decls. This fixes an "It stinks!".
1879 * alloc.c (which_symbols): Fix alignment issue / type clash.
1881 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1883 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1884 (struct Lisp_Misc_Any): Likewise.
1885 (struct Lisp_Free): Likewise.
1886 * alloc.c (union aligned_Lisp_Symbol): Define.
1887 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1888 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1889 (union aligned_Lisp_Misc): Define.
1890 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1891 aligned_Lisp_Misc instead of union Lisp_Misc.
1892 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1894 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1896 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1897 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1898 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1899 * s/netbsd.h, s/sol2-6.h:
1900 Remove definition of GC_MARK_STACK, since the default now works.
1901 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1902 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1903 no longer the default.
1904 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1906 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1908 * lread.c (lisp_file_lexically_bound_p):
1909 Fix hang at ";-*-\n" (bug#11238).
1911 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1913 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1914 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1916 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1918 * nsterm.m (constrainFrameRect): Always constrain when there is only
1919 one screen (Bug#10962).
1921 2012-04-13 Ken Brown <kbrown@cornell.edu>
1923 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1925 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1927 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1929 2012-04-11 Daniel Colascione <dancol@dancol.org>
1931 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1932 against is gone. It's better to use vfork now so that when Cygwin
1933 gains a new, working vfork, we use it automatically (bug#10398).
1935 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1937 * window.c (save_window_save): Obey window-point-insertion-type.
1939 2012-04-11 Glenn Morris <rgm@gnu.org>
1941 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1943 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1945 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1947 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1949 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1950 (force_quit_count): New var.
1951 (handle_interrupt): Use it.
1953 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1955 * w32.c (w32_delayed_load): Record the full path of the library
1956 being loaded (bug#10424).
1958 2012-04-09 Glenn Morris <rgm@gnu.org>
1960 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1961 not just in the obarray, before snarfing them. (Bug#11036)
1963 * Makefile.in ($(leimdir)/leim-list.el):
1964 Pass EMACS rather than BUILT_EMACS.
1966 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1968 * process.c (make_process):
1969 * process.h: Add integer `gnutls_handshakes_tried' member to
1972 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1973 Add convenience `GNUTLS_LOG2i' macro.
1975 * gnutls.c (gnutls_log_function2i): Convenience log function.
1976 (emacs_gnutls_read): Use new log functions,
1977 `gnutls_handshakes_tried' process member, and
1978 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1979 attempts per process (connection).
1981 2012-04-09 Chong Yidong <cyd@gnu.org>
1983 * eval.c (Fuser_variable_p, user_variable_p_eh)
1984 (lisp_indirect_variable): Functions deleted.
1985 (Fdefvar): Caller changed.
1987 * callint.c (Finteractive, Fcall_interactively):
1988 * minibuf.c (Fread_variable): Callers changed.
1990 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1992 * xdisp.c (set_cursor_from_row): If the display string appears in
1993 the buffer at position that is closer to point than the position
1994 after the display string, display the cursor on the first glyph of
1995 the display string. Fixes cursor display when a 'display' text
1996 property immediately follows invisible text. (Bug#11094)
1998 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2000 composite.c: use 'double' consistently
2001 * composite.c (get_composition_id): Use 'double' consistently
2002 instead of converting 'float' to 'double' and vice versa; this is
2003 easier to understand and avoids a GCC warning.
2005 2012-04-09 Glenn Morris <rgm@gnu.org>
2007 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2008 preparation for dumping it with emacs. (Bug#4789)
2009 (leimdir): New variable.
2010 ($(leimdir)/leim-list.el): New rule.
2011 (emacs$(EXEEXT)): Depend on leim-list.el.
2013 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2014 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2015 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2017 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2019 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2022 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2024 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2025 Remove unused local variable.
2027 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2029 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2030 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2031 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2032 objects, as mark_maybe_pointer will catch them otherwise.
2033 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2034 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2036 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2038 Fix typo that broke non-Windows builds.
2039 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2041 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2043 Support building on MS-Windows with libxml2.
2045 * makefile.w32-in (OBJ2): Add xml.$(O).
2046 (GLOBAL_SOURCES): Add xml.c.
2047 ($(BLD)/xml.$(O)): New dependency list.
2049 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2050 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2051 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2052 [!WINDOWSNT]: New macros.
2053 (init_libxml2_functions, libxml2_loaded_p): New functions.
2054 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2055 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2056 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2057 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2059 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2060 Call init_libxml2_functions before calling libxml2 functions.
2061 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2063 * emacs.c: Don't include libxml/parser.h.
2064 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2065 xmlCleanupParser directly.
2067 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2069 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2071 * indent.c (Fvertical_motion): If there is a display string at
2072 point, use it.vpos to compute how many lines to backtrack after
2073 move_it_to point. (Bug#11133)
2075 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2077 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2078 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2079 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2080 macros related to unification of CJK characters. For the details,
2081 see the discussion following the message here:
2082 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2084 2012-04-04 Chong Yidong <cyd@gnu.org>
2086 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2088 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2090 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2091 instead of alloca. (Bug#11138)
2093 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2095 * w32menu.c (is_simple_dialog): Properly check lisp types.
2098 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2100 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2101 position we get to after a call to move_it_to fails the
2102 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2103 only if we wind up in a string from display property. (Bug#11063)
2105 * window.c (Fdelete_other_windows_internal): Invalidate the row
2106 and column information about mouse highlight, so that redisplay
2107 restores it after reallocating the glyph matrices. (Bug#7464)
2109 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2110 string comes from a `display' text property, use the buffer
2111 position of that property as if we actually saw that position in
2113 (move_it_by_lines): Remove the assertion that
2114 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2115 violated when there's a before-string at the beginning of a line.
2118 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2120 * xdisp.c (append_space_for_newline): If the default face was
2121 remapped, use the remapped face for the appended newline.
2122 (extend_face_to_end_of_line): Use the remapped default face for
2123 extending the face to the end of the line.
2124 (display_line): Call extend_face_to_end_of_line when the default
2125 face was remapped. (Bug#11068)
2127 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2129 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2131 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2133 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2135 2012-03-27 Glenn Morris <rgm@gnu.org>
2137 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2140 2012-03-26 Kenichi Handa <handa@m17n.org>
2142 * dispextern.h (struct glyph): Fix previous change. Change the
2143 bit length of glyphless.ch to 25 (Bug#11082).
2145 2012-03-26 Chong Yidong <cyd@gnu.org>
2147 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2148 (command_loop_1): Use it; inhibit selection update for
2149 handle-select-window too (Bug#8996).
2151 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2153 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2155 2012-03-25 Kenichi Handa <handa@m17n.org>
2157 * dispextern.h (struct glyph): Change the bit length of
2158 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2160 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2162 * s/ms-w32.h (tzname): Include time.h before redirecting to
2163 _tzname. Fixes the MSVC build. (Bug#9960)
2165 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2167 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2170 * xterm.c (XTread_socket): Only modify handling_signal if
2171 !SYNC_INPUT. (Bug#11080)
2173 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2175 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2176 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2177 when fetching a multibyte character consumes more bytes than
2178 CHAR_BYTES returns, due to unification of CJK characters in
2179 string_char. (Bug#11073)
2181 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2183 * process.c (wait_reading_process_output): Handle pty disconnect
2184 by refraining from sending oneself a SIGCHLD (bug#10933).
2186 2012-03-22 Chong Yidong <cyd@gnu.org>
2188 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2190 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2191 Mark string as coming from a prefix property.
2192 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2193 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2195 2012-03-21 Chong Yidong <cyd@gnu.org>
2197 * xfaces.c (Vface_remapping_alist): Doc fix.
2199 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2201 * w32proc.c (Fw32_set_console_codepage)
2202 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2205 2012-03-20 Chong Yidong <cyd@gnu.org>
2207 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2208 to reflect default non-nil value of redisplay-dont-pause.
2210 2012-03-19 Kenichi Handa <handa@m17n.org>
2212 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2213 it fit in a valid range (Bug#11003).
2215 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2217 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2218 that is not from display property, accept the row as a "cursor
2219 row" if one of the string's character has a non-nil `cursor'
2220 property. Fixes cursor positioning when there are newlines in
2221 overlay strings, e.g. in icomplete.el. (Bug#11035)
2223 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2225 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2227 2012-03-12 Chong Yidong <cyd@gnu.org>
2229 * eval.c (inhibit_lisp_code): Rename from
2230 inhibit_window_configuration_change_hook; move from window.c.
2232 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2233 * window.c (run_window_configuration_change_hook)
2234 (syms_of_window): Callers changed.
2236 2012-03-11 Chong Yidong <cyd@gnu.org>
2238 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2240 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2242 2012-03-10 Chong Yidong <cyd@gnu.org>
2244 * frame.c (other_visible_frames): Don't assume the selected frame
2245 is visible (Bug#10955).
2247 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2249 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2251 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2253 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2254 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2257 2012-03-03 Glenn Morris <rgm@gnu.org>
2259 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2261 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2263 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2264 position past the first glyph_row that ends at ZV. (Bug#10902)
2265 (redisplay_window, next_element_from_string): Fix typos in
2267 (redisplay_window): Pass to move_it_vertically the margin in
2268 pixels, not in screen lines.
2270 2012-03-02 Glenn Morris <rgm@gnu.org>
2272 * buffer.c (buffer-list-update-hook): Doc fix.
2274 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2276 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2277 push_it before setting up the iterator for the first overlay
2278 string, even if we have an empty string loaded.
2279 (next_overlay_string): If there's an empty string on the iterator
2280 stack, pop the stack. (Bug#10903)
2282 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2284 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2285 Suggested by Stefan Monnier in
2286 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2287 * alloc.c (widen_to_Lisp_Object): New static function.
2288 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2289 and widening them to Lisp_Objects. This would work even if
2290 USE_LSB_TAG is defined and wide integers are used, which might
2291 happen in a future version of Emacs.
2293 2012-02-25 Chong Yidong <cyd@gnu.org>
2295 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2298 * xselect.c (Fx_selection_exists_p): Doc fix.
2299 (x_clipboard_manager_save_all): Print an informative message
2300 before saving to clipboard manager.
2302 2012-02-24 Chong Yidong <cyd@gnu.org>
2304 * keyboard.c (process_special_events): Handle all X selection
2305 requests in kbd_buffer, not just the next one (Bug#8869).
2307 2012-02-23 Chong Yidong <cyd@gnu.org>
2309 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2310 call when setting menu-bar-lines and tool-bar-lines parameters.
2311 (unwind_create_frame_1): New helper function.
2313 * window.c (inhibit_window_configuration_change_hook): New var.
2314 (run_window_configuration_change_hook): Obey it.
2315 (syms_of_window): Initialize it.
2317 2012-02-22 Chong Yidong <cyd@gnu.org>
2319 * xterm.c (x_draw_image_relief): Add missing type check for
2320 Vtool_bar_button_margin (Bug#10743).
2322 2012-02-21 Chong Yidong <cyd@gnu.org>
2324 * fileio.c (Vfile_name_handler_alist): Doc fix.
2326 * buffer.c (Fget_file_buffer): Protect against invalid file
2327 handler return value.
2329 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2331 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2332 when computing $valmask.
2334 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2335 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2336 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2337 It's useless in that case, and it can cause problems on hosts
2338 that allocate halves of EMACS_INT values separately.
2339 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2340 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2341 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2342 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2343 it avoids undefined behavior on hosts where shifting right by more
2344 than the word width has undefined behavior.
2346 2012-02-19 Chong Yidong <cyd@gnu.org>
2348 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2349 (Funhandled_file_name_directory, Ffile_name_as_directory)
2350 (Fdirectory_file_name, Fexpand_file_name)
2351 (Fsubstitute_in_file_name): Protect against invalid file handler
2352 return values (Bug#10845).
2354 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2356 * .gdbinit (pitx): Fix incorrect references to fields of the
2359 2012-02-17 Chong Yidong <cyd@gnu.org>
2361 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2363 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2365 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2366 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2368 2012-02-15 Chong Yidong <cyd@gnu.org>
2370 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2371 marked as special. Also, starting docstrings with * is obsolete.
2373 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2375 * gnutls.c (emacs_gnutls_write): Fix last change.
2377 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2379 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2382 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2384 * keymap.c (Fsingle_key_description): Handle char ranges.
2386 2012-02-12 Chong Yidong <cyd@gnu.org>
2388 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2389 as that creates a dangerous corner case.
2391 * window.c (Fdelete_window_internal): Invalidate the mouse
2392 highlight (Bug#9904).
2394 2012-02-12 Glenn Morris <rgm@gnu.org>
2396 * xselect.c (Fx_own_selection_internal)
2397 (Fx_get_selection_internal, Fx_disown_selection_internal)
2398 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2399 * nsselect.m (Fx_own_selection_internal)
2400 (Fx_disown_selection_internal, Fx_selection_exists_p)
2401 (Fx_selection_owner_p, Fx_get_selection_internal):
2402 Sync docs and argument specs with the xselect.c versions.
2404 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2406 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2408 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2410 * w32select.c (Fx_selection_exists_p): Sync doc string and
2411 argument list with xselect.c. (Bug#10783)
2413 * w16select.c (Fx_selection_exists_p): Sync doc string and
2414 argument list with xselect.c. (Bug#10783)
2416 2012-02-10 Glenn Morris <rgm@gnu.org>
2418 * fns.c (Fsecure_hash): Doc fix.
2420 2012-02-09 Kenichi Handa <handa@m17n.org>
2422 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2424 2012-02-07 Chong Yidong <cyd@gnu.org>
2426 * buffer.c (Fbuffer_local_variables)
2427 (buffer_lisp_local_variables): Handle unbound vars correctly;
2428 don't let Qunbound leak into Lisp.
2430 2012-02-07 Glenn Morris <rgm@gnu.org>
2432 * image.c (Fimagemagick_types): Doc fix.
2434 * image.c (imagemagick-render-type): Change it from a lisp object
2435 to an integer. Move the doc here from the lisp manual.
2436 Treat all values not equal to 0 the same.
2438 2012-02-06 Chong Yidong <cyd@gnu.org>
2440 * doc.c (store_function_docstring): Avoid applying docstring of
2441 alias to base function (Bug#2603).
2443 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2445 * .gdbinit (pp1, pv1): Remove redundant defines.
2448 2012-02-04 Chong Yidong <cyd@gnu.org>
2450 * nsterm.m: Declare a global (Bug#10694).
2452 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2454 * w32.c (get_emacs_configuration_options):
2455 Include --enable-checking, if specified, in the return value.
2457 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2459 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2460 after rounding frame sizes. (Bug#9723)
2462 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2464 * keyboard.c (adjust_point_for_property): Don't position point
2465 before BEGV. (Bug#10696)
2467 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2469 Handle overflow when computing char display width (Bug#9496).
2470 * character.c (char_width): Return EMACS_INT, not int.
2471 (char_width, c_string_width): Check for overflow when
2472 computing the width; this is possible now that individual
2473 characters can have unbounded width. Problem introduced
2474 by merge from Emacs 23 on 2012-01-19.
2476 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2478 * dbusbind.c (Fdbus_register_method): Mention the return value
2479 :ignore in the docstring.
2481 2012-02-02 Glenn Morris <rgm@gnu.org>
2483 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2485 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2486 Unconditionally set to t. (Bug#10673)
2487 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2488 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2489 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2491 2012-02-02 Kenichi Handa <handa@m17n.org>
2493 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2494 0, do not call append_composite_glyph.
2496 2012-02-02 Kenichi Handa <handa@m17n.org>
2498 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2500 (x_produce_glyphs): If the component of a composition is a null
2501 string, set it->pixel_width to 1 to avoid zero-width glyph.
2503 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2505 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2506 first 2 arguments are identical. This makes inserting large
2507 output from a subprocess an order of magnitude faster on
2508 MS-Windows, where all sbrk'ed memory is always contiguous.
2510 2012-01-31 Glenn Morris <rgm@gnu.org>
2512 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2513 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2514 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2516 2012-01-29 Glenn Morris <rgm@gnu.org>
2518 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2520 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2522 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2524 2012-01-28 Chong Yidong <cyd@gnu.org>
2526 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2528 2012-01-26 Chong Yidong <cyd@gnu.org>
2530 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2532 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2533 repeat counts (Bug#10507).
2535 2012-01-26 Glenn Morris <rgm@gnu.org>
2537 * lread.c (syms_of_lread): Doc fix.
2539 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2541 * coding.c (encode_designation_at_bol): Change return value to
2544 2012-01-25 Chong Yidong <cyd@gnu.org>
2546 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2548 2012-01-21 Chong Yidong <cyd@gnu.org>
2550 * floatfns.c (Fcopysign): Make the second argument non-optional,
2551 since nil is not allowed anyway.
2553 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2555 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2556 (send_process): Likewise.
2558 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2560 * window.c (save_window_save, Fcurrent_window_configuration)
2561 (Vwindow_persistent_parameters): Do not use Qstate.
2562 Rewrite doc-strings.
2564 2012-01-19 Kenichi Handa <handa@m17n.org>
2566 * character.c (char_width): New function.
2567 (Fchar_width, c_string_width, lisp_string_width):
2568 Use char_width (Bug#9496).
2570 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2572 * window.c (Vwindow_persistent_parameters): New variable.
2573 (Fset_window_configuration, save_window_save): Handle persistent
2576 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2578 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2579 thrashing the stack of the thread. (Bug#9087)
2581 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2583 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2585 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2587 * xdisp.c (rows_from_pos_range): Handle the case where the
2588 highlight ends on a newline. (Bug#10464)
2589 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2590 he end column for display of highlight that ends on a newline
2593 2012-01-11 Glenn Morris <rgm@gnu.org>
2595 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2596 from load-path also when installation-directory is nil. (Bug#10208)
2598 2012-01-10 Glenn Morris <rgm@gnu.org>
2600 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2602 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2603 Update template values to be closer to their typical values these days.
2605 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2607 * xdisp.c (rows_from_pos_range): Accept additional argument
2608 DISP_STRING, and accept any glyph in a row whose object is that
2609 string as eligible for mouse highlight. Fixes mouse highlight of
2610 display strings from overlays. (Bug#10464)
2612 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2614 emacs: fix an auto-save permissions race condition (Bug#10400)
2615 * fileio.c (auto_saving_dir_umask): New static var.
2616 (Fmake_directory_internal): Use it.
2617 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2618 creating the directory. The old code temporarily assigns
2619 too-generous permissions to the directory.
2620 (do_auto_save_eh): Clear it.
2621 (Fdo_auto_save): Catch all errors, not just file errors, so
2622 that the var is always cleared.
2624 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2626 * search.c (scan_buffer): Pass character positions to
2627 know_region_cache, not byte positions. (Bug#6540)
2629 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2631 * w32.c (sys_rename): Report EXDEV when rename of a directory
2632 fails because the target is on another logical disk. (Bug#10284)
2634 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2636 * xterm.c (x_embed_request_focus): New function.
2638 * xterm.h: Add prototype.
2640 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2642 2012-01-05 Glenn Morris <rgm@gnu.org>
2644 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2646 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2648 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2649 Load gnutls_transport_set_lowat only if GnuTLS version is below
2651 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2652 GnuTLS versions below 2.11.1.
2654 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2656 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2657 to the doc string advising against its use for altering the way
2658 windows are scrolled.
2660 2011-12-28 Kenichi Handa <handa@m17n.org>
2662 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2663 coding-system ASCII compatible only when it does not produce BOM
2664 on encoding (Bug#10383).
2666 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2668 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2670 (create_and_show_popup_menu): Always use menu_position_func for
2673 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2675 * callint.c (Fcall_interactively): Don't truncate prompt string.
2677 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2679 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2680 property that ends at ZV, so that the bidi iteration could be
2681 resumed from there (after widening). (Bug#10360)
2683 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2685 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2687 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2689 * nsterm.m (x_free_frame_resources):
2690 Release f->output_data.ns->miniimage.
2691 (ns_index_color): Fix indentation. Do not retain
2692 color_table->colors[i].
2694 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2697 * nsfns.m (x_set_background_color): Assign return value from
2698 ns_index_color to face-background instead of NSColor*.
2699 (ns_implicitly_set_icon_type): Fix indentation.
2700 Change assignment in for loop to comparison.
2702 * emacs.c (ns_pool): New variable.
2703 (main): Assign ns_pool.
2704 (Fkill_emacs): Call ns_release_autorelease_pool.
2706 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2707 autorelease fdesc, release fdAttrs and tdict.
2708 (ns_get_covering_families): Release charset.
2709 (ns_findfonts): Release NSFontDescriptor created with new.
2710 (ns_uni_to_glyphs): Fix indentation.
2711 (setString): Release attrStr before assigning new value.
2713 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2715 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2717 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2718 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2720 2011-12-18 David Reitter <reitter@cmu.edu>
2722 * nsterm.m (ns_term_init): Subscribe for notifications
2723 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2724 to method trackingNotification in EmacsMenu.
2726 * nsmenu.m (trackingMenu): New variable.
2727 (trackingNotification): New method (from Aquamacs).
2728 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2729 from Aquamacs (Bug#7030).
2731 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2733 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2734 (symbol_to_nsstring): Fix indentation.
2735 (ns_symbol_to_pb): New function.
2736 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2737 (Fns_rotate_cut_buffers_internal): Remove.
2738 (Fns_store_selection_internal): Rename from
2739 Fns_store_cut_buffer_internal.
2740 (ns_get_foreign_selection, Fx_own_selection_internal)
2741 (Fx_disown_selection_internal, Fx_selection_exists_p)
2742 (Fns_get_selection_internal, Fns_store_selection_internal):
2743 Use ns_symbol_to_pb and check if return value is nil.
2744 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2745 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2746 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2747 renamed to Sns_store_selection_internal.
2748 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2749 and remove this function.
2750 (ns_handle_selection_clear): Remove, never used.
2751 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2754 2011-12-17 Ken Brown <kbrown@cornell.edu>
2756 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2757 GID is unknown (Bug#10257).
2759 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2761 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2762 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2763 which caused a build failure on GNU/Linux IA-64. This problem was
2764 introduced by my 2011-10-07 patch.
2766 2011-12-15 Juri Linkov <juri@jurta.org>
2768 * image.c (imagemagick_error): New function. (Bug#10112)
2769 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2770 Use `imagemagick_error' where ImageMagick functions return
2772 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2775 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2777 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2778 fill background (Bug#8992).
2780 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2782 * window.c (Vwindow_combination_resize)
2783 (Vwindow_combination_limit): Use t instead of non-nil in
2785 (Vrecenter_redisplay): Add first sentence of doc-string on
2787 (Frecenter): Fix doc-string typo.
2789 2011-12-11 Kenichi Handa <handa@m17n.org>
2791 * coding.c (Funencodable_char_position): Pay attention to the
2792 buffer text relocation (Bug#9389).
2794 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2796 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2797 gtk_init (Bug#10100).
2799 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2801 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2802 IT->string is nil. (Bug#10263)
2804 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2806 * nsterm.h (x_free_frame_resources): Declare.
2808 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2809 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2811 * nsterm.h (ns_get_defaults_value): Declare.
2813 * nsterm.m (ns_default): Call ns_get_defaults_value.
2815 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2817 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2820 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2822 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2823 that where the value of an _OBJC_* symbol points to is in the .bss
2824 section (Bug#10240).
2826 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2828 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2829 after the loop to call ccl_driver at least once (Bug#8619).
2831 2011-12-08 Kenichi Handa <handa@m17n.org>
2833 * ftfont.c (get_adstyle_property): Fix previous change
2836 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2838 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2839 dirs from the default value of EMACSLOADPATH (bug#10208).
2841 2011-12-07 Glenn Morris <rgm@gnu.org>
2843 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2844 installation and source directories as well. (Bug#10208)
2846 2011-12-06 Chong Yidong <cyd@gnu.org>
2848 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2850 2011-12-06 Glenn Morris <rgm@gnu.org>
2852 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2853 as an error, not just -1. (Bug#10217)
2855 2011-12-05 Chong Yidong <cyd@gnu.org>
2857 * keyboard.c (process_special_events): New function.
2858 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2860 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2862 * coding.c (encode_designation_at_bol): Don't use uninitialized
2863 local variable (Bug#9318).
2865 2011-12-05 Kenichi Handa <handa@m17n.org>
2867 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2868 return Qnil (Bug#8046, Bug#10193).
2870 2011-12-05 Kenichi Handa <handa@m17n.org>
2872 * coding.c (encode_designation_at_bol): New args charbuf_end and
2873 dst. Return the number of produced bytes. Callers changed.
2874 (coding_set_source): Return how many bytes coding->source was
2876 (coding_set_destination): Return how many bytes
2877 coding->destination was relocated.
2878 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2879 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2881 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2883 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2884 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2887 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2889 The following changes are to fix Bug#9318.
2891 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2892 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2893 (encode_coding_iso_2022, encode_coding_sjis)
2894 (encode_coding_big5, encode_coding_charset): Use the above macros.
2896 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2898 * lisp.h (process_quit_flag): Fix external declaration.
2900 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2902 Don't macro-inline non-performance-critical code.
2903 * eval.c (process_quit_flag): New function.
2904 * lisp.h (QUIT): Use it.
2906 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2908 * nsfns.m (get_geometry_from_preferences): New function.
2909 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2911 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2913 * emacs.c (Qkill_emacs): Define.
2914 (syms_of_emacs): Initialize it.
2915 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2916 Qquit_flag to `kill-emacs' instead.
2917 (quit_throw_to_read_char): Add parameter `from_signal'.
2918 All callers changed. Call Fkill_emacs if requested and safe.
2919 * lisp.h (QUIT): Call Fkill_emacs if requested.
2921 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2923 * widget.c (update_wm_hints): Return if wmshell is null.
2924 (widget_update_wm_size_hints): New function.
2926 * widget.h (widget_update_wm_size_hints): Declare.
2928 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2929 widget_update_wm_size_hints (Bug#10104).
2931 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2933 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2934 before a newline, prepare the bidi iterator for consuming the
2935 newline, and keep the current paragraph direction. (Bug#10183)
2936 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2938 2011-12-02 Juri Linkov <juri@jurta.org>
2940 * search.c (Fword_search_regexp): New Lisp function created from
2941 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2942 (Fword_search_backward, Fword_search_forward)
2943 (Fword_search_backward_lax, Fword_search_forward_lax):
2944 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2945 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2947 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2949 * fileio.c (Finsert_file_contents): Move after-change-function call
2950 to before the "handled:" label, since all "goto handled" appear in
2951 cases where the *-change-functions have already been properly called
2954 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2956 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2957 waiting for input. (Bug#10169)
2959 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2961 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2962 verifies glyph row's hash code--we have just reallocated the
2963 glyphs, so their contents can be complete garbage. (Bug#10164)
2965 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2967 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2969 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2971 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2972 attributes are tested _before_ calling verify_row_hash, to protect
2973 against GCC re-ordering of the tests. (Bug#10164)
2975 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2977 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2979 * xterm.c (handle_one_xevent): Only set async_visible and friends
2980 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2981 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2982 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2984 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2986 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2987 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2988 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2989 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2990 All uses changed to use GCPRO1 etc.
2991 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2992 Revert to old implementation (i.e., before 2011-03-11).
2994 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2996 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2997 of scroll runs so as to avoid assigning disabled bogus rows and
2998 unnecessary graphics copy operations.
3000 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3002 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3003 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3004 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3005 (malloc, free, realloc, calloc): Redirect to e_* only when
3008 * lisp.h (GCTYPEBITS): Move before first use.
3009 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3010 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3011 this macro definition.
3013 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3016 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3018 * gtkutil.c (xg_create_frame_widgets):
3019 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3020 present with Gtk+ 2.0.
3022 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3024 * fileio.c (Finsert_file_contents): Undo previous change; see
3025 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3027 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3029 Rename locals to avoid shadowing.
3030 * fileio.c (Finsert_file_contents):
3031 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3032 * process.c (wait_reading_process_output):
3033 Rename inner 'proc' to 'p' to avoid shadowing.
3034 Indent for consistency with usual Emacs style.
3036 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3038 * xdisp.c (redisplay_window): If cursor row is not fully visible
3039 after recentering, and scroll-conservatively is set to a large
3040 number, scroll window by a few more lines to make the cursor fully
3041 visible and out of scroll-margin. (Bug#10105)
3042 (start_display): Don't move to the next line if the display should
3043 start at a newline that is part of a display vector or an overlay
3046 2011-11-24 Juri Linkov <juri@jurta.org>
3048 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3049 after the `MagickPingImage' call. (Bug#10112)
3051 2011-11-23 Chong Yidong <cyd@gnu.org>
3053 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3055 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3057 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3058 making another buffer current. (Bug#10114)
3060 2011-11-23 Glenn Morris <rgm@gnu.org>
3062 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3064 2011-11-23 Chong Yidong <cyd@gnu.org>
3066 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3067 using it (Bug#5984).
3069 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3071 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3072 and header-lines, as they don't have one computed for them.
3075 * .gdbinit (prow): Make displayed values more self-explaining.
3076 Add row's hash code.
3078 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3080 * process.c (wait_reading_process_output): Fix asynchrounous
3081 GnuTLS socket handling on some versions of the GnuTLS library.
3082 (wait_reading_process_output): Add comment and URL.
3084 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3086 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3088 2011-11-21 Chong Yidong <cyd@gnu.org>
3090 * window.c (Fnext_window, Fprevious_window): Doc fix.
3092 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3094 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3096 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3098 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3100 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3102 * window.c (Fset_window_combination_limit): Rename argument
3104 (Vwindow_combination_limit): Remove "status" from doc-string.
3106 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3108 * m/ibms390.h: Remove.
3109 * m/ibms390x.h: Don't include "ibms390.h".
3111 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3113 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3114 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3116 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3118 * casetab.c (Fset_case_table):
3119 * charset.c (Fcharset_after): Fix typos.
3121 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3123 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3124 Otherwise, valgrind does not work on some platforms.
3125 Problem reported by Andreas Schwab in
3126 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3127 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3128 is set, removing the need for VIRT_ADDRESS_VARIES.
3129 (PURE_P): Use a more-efficient implementation that needs just one
3130 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3131 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3132 to 4 (xorl, subq, cmpq, setbe).
3133 * alloc.c (pure): Always extern now, since that's the
3134 VIRT_ADDR_VARIES behavior.
3135 (PURE_POINTER_P): Use a single comparison, not two, for
3136 consistency with the new puresize.h.
3137 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3138 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3139 Remove VIRT_ADDR_VARIES no longer needed.
3141 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3143 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3144 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3145 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3146 behave as if the cursor position were at the window margin.
3148 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3149 and the cursor position is out of bounds, behave as if the cursor
3150 position were at the window margin. (Bug#10075)
3152 2011-11-18 Chong Yidong <cyd@gnu.org>
3154 * window.c (Fwindow_combination_limit): Make first argument
3155 non-optional, since it is meaningless for live windows like the
3158 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3160 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3162 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3164 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3165 (graft_intervals_into_buffer): Simplify.
3167 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3169 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3170 hash values of the two rows.
3171 (copy_row_except_pointers): Preserve the used[] arrays and the
3172 hash values of the two rows. (Bug#10035)
3173 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3175 * xdisp.c (row_hash): New function, body extracted from
3176 compute_line_metrics.
3177 (compute_line_metrics): Call row_hash, instead of computing the
3180 * dispnew.c (verify_row_hash): Call row_hash for computing the
3181 hash code of a row, instead of duplicating code from xdisp.c.
3183 * dispextern.h (row_hash): Add prototype.
3185 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3187 * frame.c (delete_frame): Don't delete the terminal when the last
3188 X frame is closed if emacs is built with GTK toolkit.
3190 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3192 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3194 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3196 * window.c (Vwindow_splits): Rename to
3197 Vwindow_combination_resize. Suggested by Juri Linkov.
3198 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3201 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3203 * nsfns.m (Fns_font_name):
3204 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3206 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3208 * window.h (window): Rename slot "nest" to "combination_limit".
3209 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3210 (Fset_window_nest): Rename to Fset_window_combination_limit.
3211 (Vwindow_nest): Rename to Vwindow_combination_limit.
3212 (recombine_windows, make_parent_window, make_window)
3213 (Fsplit_window_internal, saved_window)
3214 (Fset_window_configuration, save_window_save): Rename all
3215 occurrences of window_nest to window_combination_limit.
3217 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3219 * image.c (imagemagick_load_image): Fix typo.
3221 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3223 * xdisp.c (display_line): Move the call to
3224 highlight_trailing_whitespace before the call to
3225 compute_line_metrics, since the latter needs to see the final
3226 faces of all the glyphs to compute ROW's hash value.
3227 Fixes assertion violations in row_equal_p. (Bug#10035)
3229 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3231 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3232 just return (bug#10044).
3234 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3236 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3237 with user-defined heap size. Bump the default size of the temacs
3238 heap to 27MB, to avoid memory warning when running temacs.
3239 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3241 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3242 current_matrix and desired_matrix. (Bug#9990)
3243 (verify_row_hash) [XASSERTS]: New function.
3244 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3245 that the hash value of glyph rows is correct.
3247 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3249 * window.h (window): Remove splits slot.
3250 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3251 (Fdelete_other_windows_internal, make_parent_window)
3252 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3253 (Fset_window_configuration, save_window_save): Don't deal with
3254 split status of windows.
3255 (saved_window): Remove splits slot.
3256 (Vwindow_splits): Rewrite doc-string.
3258 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3260 * xfns.c (unwind_create_frame):
3261 * nsfns.m (unwind_create_frame):
3262 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3263 Vframe_list (Bug#9999).
3265 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3267 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3269 2011-11-11 Kenichi Handa <handa@m17n.org>
3271 * callproc.c (Fcall_process): Set the member dst_multibyte of
3274 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3276 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3277 avoid a crash (bug#9496).
3279 2011-11-09 Chong Yidong <cyd@gnu.org>
3281 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3282 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3284 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3286 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3288 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3290 Avoid some portability problems by eschewing 'extern inline' functions.
3291 The trivial performance wins aren't worth the portability hassles; see
3292 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3294 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3295 (window_box_width, window_box_left, window_box_left_offset)
3296 (window_box_right, window_box_right_offset): Undo previous change,
3297 by removing the "extern"s.
3298 * intervals.c (adjust_intervals_for_insertion)
3299 (adjust_intervals_for_deletion): Undo previous change,
3300 making these static again.
3301 (offset_intervals, temp_set_point_both, temp_set_point)
3302 (copy_intervals_to_string): No longer inline.
3303 * xdisp.c (window_text_bottom_y, window_box_width)
3304 (window_box_height, window_box_left_offset)
3305 (window_box_right_offset, window_box_left, window_box_right)
3306 (window_box): No longer inline.
3308 2011-11-08 Chong Yidong <cyd@gnu.org>
3310 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3311 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3312 Signal an error if not a live window.
3313 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3314 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3316 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3318 * lisp.h (syms_of_abbrev): Remove declaration.
3319 Reported by CHENG Gao <chenggao@royau.me>.
3321 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3323 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3324 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3325 of temacs in GUI mode.
3327 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3329 * window.h: Declare delete_all_child_windows instead of
3330 delete_all_subwindows.
3331 * window.c (Fwindow_nest, Fset_window_nest)
3332 (Fset_window_new_total, Fset_window_new_normal)
3333 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3334 (delete_all_subwindows): Rename to delete_all_child_windows.
3335 (Fdelete_other_windows_internal, Fset_window_configuration):
3336 Call delete_all_child_windows instead of delete_all_subwindows.
3337 * frame.c (delete_frame): Call delete_all_child_windows instead
3338 of delete_all_subwindows.
3340 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3342 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3343 This is also needed for porting to any host where GC_MARK_STACK is
3344 not GC_MAKE_GCPROS_NOOPS.
3345 (which_symbols): Use it.
3347 2011-11-07 Kenichi Handa <handa@m17n.org>
3349 * coding.c (coding_set_destination): Check coding->src_pos only
3350 when coding->src_object is a buffer (bug#9910).
3352 * process.c (send_process): Set the member src_multibyte of coding
3353 to 0 (bug#9911) when sending a unibyte text.
3355 * callproc.c (Fcall_process): Set the member src_multibyte of
3356 process_coding to 0 (bug#9912).
3358 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3360 * xmenu.c (cleanup_widget_value_tree): New function.
3361 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3362 calling free_menubar_widget_value_tree directly (Bug#9830).
3364 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3366 Fix some portability problems with 'inline'.
3367 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3368 (window_box_width, window_box_left, window_box_left_offset)
3369 (window_box_right, window_box_right_offset): Declare extern.
3370 Otherwise, these inline functions do not conform to C99 and
3371 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3372 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3373 * intervals.c (adjust_intervals_for_insertion)
3374 (adjust_intervals_for_deletion): Now extern, because otherwise the
3375 extern inline functions 'offset_intervals' couldn't refer to it.
3376 (static_offset_intervals): Remove.
3377 (offset_intervals): Rewrite using the old contents of
3378 static_offset_intervals. The old version didn't conform to C99
3379 because an extern inline function contained a reference to an
3380 identifier with static linkage.
3382 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3384 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3387 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3389 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3390 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3391 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3392 return Qleft_to_right.
3394 2011-11-06 Chong Yidong <cyd@gnu.org>
3396 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3397 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3398 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3399 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3400 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3401 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3402 (Fwindow_vscroll): Doc fix.
3403 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3404 argument, since it makes no sense to pass a live window and for
3405 consistency with window-child.
3407 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3409 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3412 2011-11-05 Jason Rumney <jasonr@gnu.org>
3414 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3415 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3417 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3418 bitwise arithmetic preventing use of unicode-sip and non-truetype
3421 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3423 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3426 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3427 initialization code to keep similarity to xfns.c after changes
3430 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3432 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3433 (unwind_create_frame): New function (Bug#9943).
3434 (Fx_create_frame): Restructure code to be more similar to the one in
3435 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3436 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3437 Move terminal->reference_count++ just before making the frame official
3440 * nsterm.m (x_free_frame_resources): New function.
3441 (x_destroy_window): Move code to x_free_frame_resources.
3443 * xfns.c (unwind_create_frame): Fix comment.
3444 (Fx_create_frame, x_create_tip_frame):
3445 Move terminal->reference_count++ just before making the frame
3446 official. Move initialization of image_cache_refcount and
3447 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3449 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3451 Support MSVC build with newer versions of Visual Studio.
3452 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3453 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3456 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3457 which are not supported by MSVC.
3458 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3459 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3461 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3463 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3465 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3467 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3469 Support MSVC build with newer versions of Visual Studio.
3470 * w32.c: Don't include w32api.h for MSVC.
3471 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3473 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3474 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3475 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3476 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3478 (alloca) [_MSC_VER]: Define to _alloca.
3480 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3482 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3484 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3486 * xdisp.c (note_mouse_highlight): If either of
3487 previous/next-single-property-change returns nil, treat that as
3488 the beginning or the end of the buffer. (Bug#9955)
3490 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3492 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3493 label is not null (Bug#9951).
3494 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3497 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3499 * window.c (Fwindow_body_size): Mention in the doc string that the
3500 return value is in frame's canonical units. (Bug#9949)
3502 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3504 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3506 * w32fns.c (unwind_create_frame): If needed, free the glyph
3507 matrices of the partially constructed frame. (Bug#9943)
3508 * xfns.c (unwind_create_frame): Likewise.
3510 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3512 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3513 Don't stop backward scan on the continuation glyph, even though
3514 its CHARPOS is positive.
3515 (mouse_face_from_buffer_pos, note_mouse_highlight):
3516 Rename cover_string to disp_string.
3518 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3520 * window.c (temp_output_buffer_show): Don't use
3521 Vtemp_buffer_show_specifiers.
3522 (Vtemp_buffer_show_specifiers): Remove unused variable.
3524 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3526 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3527 past the beginning of the current glyph matrix.
3529 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3531 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3532 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3533 HAVE_GTK3 (Bug#9869).
3535 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3536 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3538 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3540 * xterm.c: Declare x_handle_net_wm_state to return int.
3541 (handle_one_xevent): Check if we are iconified but don't have
3542 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3543 (get_current_wm_state): Return non-zero if not hidden,
3544 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3545 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3546 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3547 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3549 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3551 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3552 so that this new function doesn't get optimized away by a
3553 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3555 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3557 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3559 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3561 Fix the `xbytecode' command.
3562 * .gdbinit (xprintbytestr): New command.
3563 (xwhichsymbols): Rename from `which'; all callers changed.
3564 (xbytecode): Print the byte-code string as well.
3566 2011-10-29 Kim Storm <storm@cua.dk>
3568 * alloc.c (which_symbols): New function.
3570 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3572 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3575 2011-10-29 Glenn Morris <rgm@gnu.org>
3577 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3578 Not clear what it was for, and it causes various bugs. (Bug#9839)
3580 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3582 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3583 possible random value that matches one of those tested as
3584 condition to clear the mouse face.
3586 2011-10-28 Chong Yidong <cyd@gnu.org>
3588 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3590 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3592 * window.c (make_window): Initialize phys_cursor_on_p.
3594 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3596 * lisp.h (struct Lisp_Symbol): Update comments.
3598 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3600 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3602 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3604 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3605 <oslsachem@gmail.com> for helping to debug this.
3607 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3608 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3609 (g_b_init_get_glyph_outline_w): New static variables.
3610 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3611 (GetGlyphOutlineW_Proc): New typedefs.
3612 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3613 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3615 (w32font_open_internal, compute_metrics):
3616 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3617 instead of calling the "wide" APIs directly.
3619 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3621 * w32.h (syms_of_w32font): Add prototype.
3623 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3625 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3626 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3627 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3628 (Fmove_to_window_line): Doc fix.
3630 2011-10-27 Chong Yidong <cyd@gnu.org>
3632 * process.c (make_process): Set gnutls_state to NULL.
3634 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3635 non-NULL, regardless of GNUTLS_INITSTAGE.
3636 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3637 an error. Set process slots as soon as we allocate them.
3639 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3641 2011-10-27 Chong Yidong <cyd@gnu.org>
3643 * gnutls.c (emacs_gnutls_deinit): New function.
3644 Deallocate credentials structures as well as calling gnutls_deinit.
3645 (Fgnutls_deinit, Fgnutls_boot): Use it.
3647 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3648 (deactivate_process): Call emacs_gnutls_deinit.
3650 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3652 * image.c (x_create_x_image_and_pixmap):
3653 * w32.c (sys_rename, w32_delayed_load):
3654 * w32font.c (fill_in_logfont):
3655 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3657 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3659 * w32fns.c (w32_default_color_map): New function,
3660 extracted from Fw32_default_color_map.
3661 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3663 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3665 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3667 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3669 * keyboard.c (test_undefined): New function (bug#9751).
3670 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3672 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3674 * sysdep.c (init_sys_modes): Fix the check for the controlling
3675 terminal (Bug#6649).
3677 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3679 * dispextern.h (struct bidi_it): New member next_en_type.
3681 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3682 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3683 current character, check also for next_en_type being WEAK_EN.
3684 (bidi_resolve_weak): Don't enter the expensive loop if the current
3685 position is before next_en_pos. Record the bidi type of the first
3686 non-ET, non-BN character we find, in addition to its position.
3687 (bidi_level_of_next_char): Invalidate next_en_type when
3688 next_en_pos is over-stepped.
3690 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3692 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3693 * editfns.c: Rewrite current-time-zone so that it invokes
3694 the equivalent of (format-time-string "%Z") to get the time zone name.
3695 This fixes a bug when the time zone name contains characters that
3696 need converting from the system time locale to Emacs internal format.
3697 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3698 that patch fixed format-time-string to do the conversion, but
3699 I forgot to fix current-time-zone.
3700 (format_time_string): New function, containing most of
3701 what Fformat_time_string used to contain.
3702 (Fformat_time_string): Rewrite in terms of format_time_string.
3703 This doesn't change this function's behavior.
3704 (current-time-zone): Rewrite to use format_time_string.
3705 This fixes the bug reported by Michael Schierl in
3706 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3707 Jason Rumney's 2007-06-07 change worked around this bug, but
3709 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3711 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3713 * xdisp.c (start_display): If the character at POS is displayed
3714 via a display vector, reset IT->current.dpvec_index to zero.
3715 (try_window_reusing_current_matrix): If a line ends in a display
3716 vector or the next line starts in a display vector, continue
3717 redrawing the window even though the character position of
3718 start_row was reached.
3721 2011-10-18 Chong Yidong <cyd@gnu.org>
3723 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3724 with nobreak-char-display too.
3726 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3728 Fix part 3 of bug#9771.
3729 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3730 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3731 non-neutral characters if the current character is a paragraph
3732 separator (a.k.a. Newline). This avoids running the same
3733 expensive loop twice, once when we consume the preceding newline
3734 and the other time when the line actually needs to be displayed.
3735 Avoid the loop when we see neutrals on the base embedding level
3736 following a character whose directionality is the same as the
3737 paragraph's. This avoids running the expensive loop when a line
3738 ends in a long sequence of neutrals, like control characters.
3739 Add assertion against STRONG_AL type. Slightly rearrange code
3740 that determines the type of a neutral given the first non-neutral
3742 (bidi_level_of_next_char): Set next_en_pos to zero when
3743 invalidating its info.
3745 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3747 * xdisp.c (push_display_prop): Determine whether to record string
3748 or buffer position by IT->string, not by IT->method. Allow
3749 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3750 (move_it_vertically_backward): Don't look for character position
3751 immediately after the newline when in a continuation line.
3754 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3756 * window.c (coordinates_in_window): Rewrite and delabelize
3757 vertical border check. (Bug#5357) (Bug#9618)
3759 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3761 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3762 errors in XSetWindowBorder (bug#9310).
3764 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3766 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3767 avoid crash when xmalloc overrun checking is enabled.
3769 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3771 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3772 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3773 cursor motion with <left> and <right> arrow keys.
3775 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3776 some callers set that themselves.
3778 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3780 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3781 display string and the previous row comes from the same string and
3782 is empty. (Bug#9739) (Bug#9738)
3784 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3786 * doc.c (get_doc_string): Encode file name (bug#9735).
3788 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3790 * bidi.c (bidi_level_of_next_char):
3791 * xdisp.c (get_visually_first_element): Remove old incorrect
3792 comments regarding the Unicode Line Separator character.
3794 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3796 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3798 * alloc.c (Fgc_status): Do not access beyond zombies array
3799 boundary if nzombies > MAX_ZOMBIES.
3800 * alloc.c (dump_zombies): Add missing format specifier.
3802 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3804 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3805 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3807 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3808 Some packages use them to denote characters with modifiers.
3810 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3812 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3813 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3814 matching a pp-number. Rename parameter var to var1.
3816 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3818 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3820 2011-10-08 Glenn Morris <rgm@gnu.org>
3822 * callint.c (Fcall_interactively): Give a more explicit error for the
3823 'c' case with a non-character input. (Bug#8479)
3825 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3827 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3829 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3830 lines that are hscrolled on the left.
3832 * dispnew.c (buffer_posn_from_coords): Account for a possible
3833 presence of header-line. (Bug#4426)
3835 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3837 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3838 Don't advertise functionality which we discourage or doesn't work.
3840 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3842 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3843 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3844 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3845 this makes Emacs dump core during garbage collection on rare
3846 occasions. sizeof is obviously inferior to offsetof here, so
3847 stick with offsetof.
3848 (GC_POINTER_ALIGNMENT): New macro.
3849 (mark_memory): Omit 3rd (offset) arg; caller changed.
3850 Don't assume EMACS_INT alignment is the same as pointer alignment.
3852 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3854 * keyboard.c (read_key_sequence_remapped): New var.
3855 (read_key_sequence): Compute remapping in the right buffer.
3856 (command_loop_1): Use read_key_sequence's remapping directly.
3858 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3860 * dired.c (file_name_completion): Don't expand file name.
3861 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3862 before checking file name handler.
3864 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3865 they've been requested explicitly (bug#9591).
3867 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3869 * keymap.c (Fsingle_key_description): Use make_specified_string
3870 instead of build_string to build string from push_key_description.
3873 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3875 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3876 This fixes a Y2038 bug on 64-bit hosts.
3877 * buffer.c (reset_buffer):
3878 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3879 (Fclear_buffer_auto_save_failure):
3880 Use 0, not -1, to represent an unset failure time, since time_t
3881 might not be signed.
3883 Remove dependency on glibc malloc internals.
3884 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3885 Move back here from lisp.h, but with their new implementations.
3886 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3887 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3888 * charset.c (charset_table_init): New static var.
3889 (syms_of_charset): Use it instead of xmalloc. This removes a
3890 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3891 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3892 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3893 Move back to alloc.c.
3894 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3895 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3897 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3899 * nsterm.m (windowDidResize): Call x_set_window_size only when
3900 ns_in_resize is true. Otherwise set pixelwidth/height and
3901 call change_frame_size (Bug#9628).
3903 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3905 Port --enable-checking=all to Fedora 14 x86-64.
3906 * charset.c (syms_of_charset): Also account for glibc malloc's
3907 internal overhead when calculating the initial malloc maximum.
3909 Port --enable-checking=all to Fedora 14 x86.
3910 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3912 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3913 (overrun_check_realloc, overrun_check_free):
3914 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3915 That way, xmalloc returns a properly-aligned pointer even if
3916 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3917 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3918 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3919 into account when calculating the initial malloc maximum.
3920 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3921 Move here from alloc.c, so that charset.c can use it too.
3922 Properly align; the old code wasn't right for common 32-bit hosts
3923 when configured with --enable-checking=all.
3924 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3925 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3927 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3929 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3932 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3934 * xdisp.c (compute_display_string_end): If there's no display
3935 string at CHARPOS, return -1.
3937 * bidi.c (bidi_fetch_char): When compute_display_string_end
3938 returns a negative value, treat the character as a normal
3939 character not covered by a display string. (Bug#9624)
3941 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3943 * lread.c (Fread_from_string): Fix typo in docstring.
3945 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3947 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3948 newline, reseat the iterator instead of bidi-iterating there one
3949 character at a time. (Bug#9610)
3950 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3951 TO_CHARPOS if the bidi iterator is at base embedding level.
3953 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3955 * lread.c (readevalloop): Use correct code for NBSP.
3956 (read1): Likewise. (Bug#9608)
3958 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3960 * dbusbind.c (Fdbus_register_signal): When service is not
3961 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3963 2011-09-25 Glenn Morris <rgm@gnu.org>
3965 * buffer.c (truncate-lines): Doc fix.
3967 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3969 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3970 (Fset_window_next_buffers): Doc fix.
3972 2011-09-24 Glenn Morris <rgm@gnu.org>
3974 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3976 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3978 Fix minor problems found by static checking.
3979 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3980 * indent.c (Fvertical_motion): Fix == vs = typo.
3982 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3984 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3985 Default value is now t. Doc fix.
3987 * indent.c (Fvertical_motion): Compute and apply the overshoot
3988 logic when moving up, not only when moving down. Fix the
3989 confusing name and values of the it_overshoot_expected variable;
3990 logic changes accordingly. (Bug#9254) (Bug#9549)
3992 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3993 CHARPOS is covered by a display string which includes newlines.
3994 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3995 is covered by a display string with embedded newlines.
3997 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3999 * dbusbind.c (Fdbus_register_signal): Add match rule to
4000 Vdbus_registered_objects_table. (Bug#9581)
4001 (Fdbus_register_method, Vdbus_registered_objects_table):
4004 2011-09-24 Jim Meyering <meyering@redhat.com>
4006 do not ignore write error for any output size
4007 The previous change was incomplete.
4008 While it makes emacs --batch detect the vast majority of stdout
4009 write failures, errors were still ignored whenever the output size is
4010 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4011 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4012 && echo FAIL: ignored write error
4013 FAIL: ignored write error
4014 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4015 && echo FAIL: ignored write error
4016 FAIL: ignored write error
4017 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4019 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4021 * emacs.c (Fkill_emacs): In noninteractive mode exit
4022 non-successfully if a write error occurred on stdout. (Bug#9574)
4024 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4026 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4029 * dispextern.h (struct it): Update the comment documenting what
4032 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4034 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4035 a display string, extend search for cursor position to end of row.
4036 (find_row_edges): If the row ends in a newline from a display
4037 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4038 Handle the case of a display string with multiple newlines.
4039 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4040 non-empty line. Fixes confusing cursor motion with arrow keys at
4041 the beginning of a line that starts with whitespace.
4043 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4045 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4048 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4050 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4053 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4055 * xdisp.c (display_line): Record maximum and minimum buffer
4056 positions even if no glyphs were produced (e.g., by a zero-width
4057 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4058 buffer positions that will be removed from the glyph row because
4060 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4061 column is beyond frame width: don't subtract 1 "pixel" when
4062 computing width of the stretch.
4063 (reseat_at_next_visible_line_start): Undo the change made on
4064 2011-09-17 that saved paragraph information and restored it after
4065 the call to `reseat'. (Bug#9545)
4067 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4069 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4070 and turn window cursor on if cleared (Bug#9415).
4072 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4074 * search.c (boyer_moore): Take unibyte characters from pattern
4075 literally. (Bug#9458)
4077 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4079 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4081 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4083 Fix minor problem found by static checking.
4084 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4085 initialized, to pacify gcc -Wuninitialized.
4087 * fileio.c: Report proper errno when syscall falls.
4088 (Finsert_file_contents): Save and restore errno,
4089 so that report_file_error outputs the correct diagnostic.
4090 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4092 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4094 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4096 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4098 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4099 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4101 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4103 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4104 about the current paragraph and restore it after the call to reseat.
4106 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4107 (bidi_find_paragraph_start): Search back for paragraph beginning
4108 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4109 (bidi_move_to_visually_next): Only trigger paragraph-related
4110 computations when the last character is a newline or at EOB, not
4111 just any NEUTRAL_B. (Bug#9470)
4113 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4114 truncated lines if point is covered by a display string. (Bug#9524)
4116 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4118 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4119 (cons_to_x_long): New function.
4120 (lisp_data_to_selection_data): Use it. Correct the test for
4121 short-versus-long data; it was negated. Break out of vector
4122 loop, for efficiency, when a long datum is discovered.
4124 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4126 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4128 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4130 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4131 GCC PR/17406) by declaring this function with external scope.
4133 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4135 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4136 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4138 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4140 * editfns.c (Fformat): Correctly handle text properties on "%%".
4142 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4144 * xterm.c (x_draw_composite_glyph_string_foreground):
4145 * w32term.c (x_draw_composite_glyph_string_foreground):
4146 * term.c (encode_terminal_code):
4147 * composite.c (composition_update_it, get_composition_id):
4148 * xdisp.c (get_next_display_element)
4149 (fill_composite_glyph_string): Add comments about special meaning
4150 of TAB characters in a composition.
4152 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4154 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4155 This occurs when processing a multibyte format.
4156 Problem reported by Wolfgang Jenker.
4158 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4160 * xdisp.c (try_cursor_movement): Only check for exact match if
4161 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4163 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4165 Remove unused external symbols.
4166 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4167 * xdisp.c (calc_pixel_width_or_height): Now static.
4168 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4169 * indent.c (check_display_width):
4170 * w32term.c: Fix comment to match code.
4171 * xterm.c, xterm.h (x_catching_errors): Remove.
4173 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4175 * xselect.c: Use signed conversions more consistently (Bug#9498).
4176 (selection_data_to_lisp_data): Assume incoming selection data are
4177 signed integers, not unsigned. This is to be consistent with
4178 outgoing selection data, which was modified to use signed integers
4179 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4180 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4181 expects long, not unsigned long.
4183 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4185 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4186 computation of loop end. Reported by Johan Bockgård
4189 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4191 * frame.c (Fother_visible_frames_p): Function deleted.
4193 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4195 * indent.c (compute_motion): Process display vector front to back
4196 rather than the other way around. (Bug#2496)
4198 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4200 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4202 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4204 * minibuf.c (Fread_from_minibuffer): Doc fix.
4206 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4208 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4209 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4211 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4213 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4214 value for non-existent files.
4216 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4218 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4219 set its "size" to -1. This will set the modtime_size field of
4220 the corresponding buffer to -1, which is what
4221 verify-visited-file-modtime expects for files that do not exist.
4224 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4226 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4228 * lisp.h: ... from here. push_key_description is no longer
4229 defined in keyboard.c, so its declaration should not be in
4230 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4231 logically belongs with push_key_description.
4233 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4235 * buffer.h: Include <sys/types.h> instead of <time.h>.
4236 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4237 Problem reported by Herbert J. Skuhra.
4239 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4241 * xml.c (parse_region): Make the parsing work for
4242 non-comment-starting XML files again (bug#9144).
4244 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4246 * image.c (gif_load): Fix calculation of bottom and right corner.
4249 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4251 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4252 redisplay in small windows.
4254 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4256 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4258 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4260 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4261 Operate on live windows only.
4263 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4265 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4267 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4269 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4270 only under bidi iteration.
4272 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4274 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4276 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4278 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4279 Without this fix, the command to link temacs failed due to an
4280 undefined symbol __builtin_isnan. This is because
4281 /usr/include/iso/math_c99.h #defines isnan(x) to
4282 __builtin_isnan(x), but the bundled gcc, which identifies itself
4283 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4285 * floatfns.c (isnan): #undef, and then #define to a clone of
4287 (Fisnan): Always define, since it's always available now.
4288 (syms_of_floatfns): Always define isnan at the Lisp level.
4290 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4292 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4294 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4296 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4297 The previous code assumed that file offsets (off_t values) fit in
4298 EMACS_INT variables, which is not true on typical 32-bit hosts.
4299 The code messed up by falsely reporting buffer overflow in cases
4300 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4301 when "big" contains more than 2**29 bytes, even though this
4302 inserts just one byte and does not overflow the buffer.
4303 (Finsert_file_contents): Store file offsets as off_t
4304 values, not as EMACS_INT values. Check for overflow when
4305 converting between EMACS_INT and off_t. When checking for
4306 buffer overflow or for overlap, take the offsets into account.
4307 Don't use EMACS_INT for small values where int suffices.
4308 When checking for overlap, fix a typo: ZV was used where
4309 ZV_BYTE was intended.
4310 (Fwrite_region): Don't assume off_t fits into 'long'.
4311 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4313 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4315 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4317 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4319 sprintf-related integer and memory overflow issues (Bug#9412).
4321 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4322 (esprintf, exprintf, evxprintf): New functions.
4323 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4324 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4325 (modify_event_symbol): Do not assume that the length of
4326 name_alist_or_stem is safe to alloca and fits in int.
4327 (Fexecute_extended_command): Likewise for function name and binding.
4328 (Frecursion_depth): Wrap around reliably on integer overflow.
4329 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4330 since some callers pass EMACS_INT values.
4331 (Fsingle_key_description): Don't crash if symbol name contains more
4332 than MAX_ALLOCA bytes.
4333 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4334 (get_minibuffer): Arg is now EMACS_INT, not int.
4335 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4336 (esprintf, exprintf, evxprintf): New decls.
4337 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4339 * dbusbind.c (signature_cat): New function.
4340 (xd_signature, Fdbus_register_signal):
4341 Do not overrun buffer; instead, report string overflow.
4343 * dispnew.c (add_window_display_history): Don't overrun buffer.
4344 Truncate instead; this is OK since it's just a log.
4346 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4347 even if the time zone offset is outlandishly large.
4348 Don't mishandle offset == INT_MIN.
4350 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4351 when creating daemon; the previous buffer-overflow check was incorrect.
4353 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4354 which has the guts of the old verror function.
4356 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4357 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4359 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4360 (font_unparse_xlfd): Don't blindly alloca long strings.
4361 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4362 fits in int, when using sprintf. Use single snprintf to count
4363 length of string rather than counting it via multiple sprintfs;
4364 that's simpler and more reliable.
4365 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4366 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4367 sprintf, in case result does not fit in int.
4369 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4370 (fontset_from_font): Print it.
4372 * frame.c (tty_frame_count): Now printmax_t, not int.
4373 (make_terminal_frame, set_term_frame_name): Print it.
4374 (x_report_frame_params): In X, window IDs are unsigned long,
4375 not signed long, so print them as unsigned.
4376 (validate_x_resource_name): Check for implausibly long names,
4377 and don't assume name length fits in 'int'.
4378 (x_get_resource_string): Don't blindly alloca invocation name;
4379 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4382 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4383 (xg_check_special_colors, xg_set_geometry):
4384 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4386 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4387 Use esprintf, not sprintf, in case result does not fit in int.
4389 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4390 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4391 it as a large positive number.
4392 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4393 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4395 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4396 in case result does not fit in int.
4398 * print.c (float_to_string): Detect width overflow more reliably.
4399 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4400 buffer overrun. Don't assume list length fits in 'int'. Treat
4401 print length of 0 as 0, not as infinity; to be consistent with other
4402 uses of print length in this function. Don't overflow print length
4403 index. Don't assume hash table size fits in 'long', or that
4404 vectorlike size fits in 'unsigned long'.
4406 * process.c (make_process): Use printmax_t, not int, to format
4407 process-name gensyms.
4409 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4411 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4412 to avoid potential buffer overrun.
4414 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4415 if X resource line is longer than 512 bytes.
4417 * xfns.c (x_window): Make sprintf buffer a bit bigger
4418 to avoid potential buffer overrun.
4420 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4422 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4424 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4426 Integer overflow fixes for scrolling, etc.
4427 Without these, Emacs silently mishandles large integers sometimes.
4428 For example, "C-u 4294967297 M-x recenter" was treated as if
4429 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4431 * xdisp.c (try_window_id): Check Emacs fixnum range before
4432 converting to 'int'.
4434 * window.c (window_scroll_line_based, Frecenter):
4435 Check that an Emacs fixnum is in range before assigning it to 'int'.
4436 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4437 values converted from Emacs fixnums.
4438 (Frecenter): Don't wrap around a line count if it is out of 'int'
4439 range; instead, treat it as an extreme value.
4440 (Fset_window_configuration, compare_window_configurations):
4441 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4443 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4444 that can exceed INT_MAX. Check that EMACS_INT value is in range
4445 before assigning it to the (possibly-narrower) index.
4446 (match_limit): Don't assume that a fixnum can fit in 'int'.
4448 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4451 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4452 (Fvertical_motion): Don't wrap around LINES values that don't fit
4453 in 'int'. Instead, treat them as extreme values. This is good
4454 enough for windows, which can't have more than INT_MAX lines anyway.
4456 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4458 * Require libxml/parser.h to avoid compilation warning.
4460 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4462 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4463 since this reportedly can destroy thread storage.
4465 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4467 * syntax.c (find_defun_start): Update all cache variables if
4468 exiting early (Bug#9401).
4470 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4472 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4474 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4475 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4476 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4478 * term.c (tty_append_glyph): New function.
4479 (produce_stretch_glyph): Static function and its prototype deleted.
4481 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4484 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4486 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4487 when checking :margin (Bug#9390).
4488 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4489 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4490 so that the name doesn't mislead. All uses changed.
4492 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4494 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4497 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4499 * xdisp.c (move_it_to): Don't bail out early when reaching
4500 position beyond to_charpos, if we are scanning backwards.
4501 (move_it_vertically_backward): When DY == 0, make sure we get to
4502 the first character in the line after the newline.
4504 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4506 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4507 (ccl_driver): Do not generate an out-of-range pointer.
4508 (Fccl_execute_on_string): Remove unnecessary check for
4509 integer overflow, noted by Stefan Monnier in
4510 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4511 Remove a FIXME that didn't need fixing.
4512 Simplify the newly-introduced buffer reallocation code.
4514 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4516 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4518 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4520 Integer and memory overflow issues (Bug#9196).
4522 * doc.c (get_doc_string): Rework so that
4523 get_doc_string_buffer_size is the actual buffer size, rather than
4524 being 1 less than the actual buffer size; this makes xpalloc more
4527 * image.c (x_allocate_bitmap_record, cache_image):
4528 * xselect.c (Fx_register_dnd_atom):
4529 Simplify previous changes by using xpalloc.
4531 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4532 since either will do and ptrdiff_t is convenient with xpalloc.
4534 * charset.c (charset_table_size)
4535 (struct charset_sort_data.priority): Now ptrdiff_t.
4536 (charset_compare): Don't overflow if priorities differ greatly.
4537 (Fsort_charsets): Don't assume list length fits in int.
4538 Check for size-calculation overflow when allocating sort data.
4539 (syms_of_charset): Allocate an initial charset table that is
4540 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4542 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4544 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4545 The actual value is always <= INT_MAX, and leaving it unsigned made
4546 overflow checking harder.
4548 * dispextern.h (struct glyph_matrix.rows_allocated)
4549 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4550 with xpalloc. The values are still always <= INT_MAX.
4552 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4554 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4555 (SAFE_NALLOCA): New macro.
4557 * region-cache.c (struct boundary.pos, find_cache_boundary)
4558 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4559 (set_cache_region, invalidate_region_cache)
4560 (revalidate_region_cache, know_region_cache, region_cache_forward)
4561 (region_cache_backward, pp_cache):
4562 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4563 so that ptrdiff_t * can be passed to xpalloc.
4564 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4565 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4566 (pp_cache): Don't assume cache_len fits in int.
4567 * region-cache.h: Adjust extern decls to match.
4569 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4570 EMACS_INT, since either will do, for xpalloc.
4572 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4573 (xnmalloc, xnrealloc, xpalloc): New functions.
4575 * bidi.c (bidi_shelve_header_size): New constant.
4576 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4577 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4579 * bidi.c (bidi_cache_shrink):
4580 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4582 Don't update size of array until after memory allocation succeeds,
4583 because xmalloc/xrealloc may not return.
4584 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4585 now that we have proper integer overflow checking.
4586 (record_overlay_string, overlay_strings): Catch overflows when
4587 calculating size of overlay_str_buf.
4589 * callproc.c (Fcall_process): Check for size overflow when
4590 calculating size of args2.
4591 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4592 Normally we prefer signed values, but sticking with ptrdiff_t would
4593 require adding more-complicated checks.
4595 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4596 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4597 Redo buffer-overflow calculations to avoid integer overflow.
4598 Add a FIXME comment where memory seems to be over-allocated.
4600 * character.c (Fstring): Check for size-calculation overflow.
4602 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4603 unnecessary integer overflow. Check for size overflow.
4604 (encode_coding_object): Don't update size until xmalloc succeeds.
4606 * composite.c (get_composition_id): Check for overflow in glyph
4607 length calculations.
4609 Integer and memory overflow fixes for display code.
4610 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4611 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4612 (scrolling_window): Check for overflow in size calculations.
4613 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4614 Don't assume glyph table len fits in int.
4615 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4616 (row_table_size): Now ptrdiff_t, not int.
4617 (scrolling_window): Avoid overflow in size calculations.
4618 Don't update size until allocation succeeds.
4619 * fns.c (concat): Check for overflow in size calculations.
4620 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4621 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4622 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4624 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4625 (get_doc_string): Check for size calculation overflow.
4626 Don't update size until allocation succeeds.
4627 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4628 EMACS_INT, where ptrdiff_t will do.
4629 (Fsubstitute_command_keys): Check for string overflow.
4631 * editfns.c (set_time_zone_rule): Don't assume environment length
4633 (message_length): Now ptrdiff_t, not int.
4634 (Fmessage_box): Don't update size until allocation succeeds.
4635 Don't assume message length fits in int.
4636 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4638 * emacs.c (main): Do not reallocate argv, since there is a null at
4639 the end that can be overwritten, and this way there's no need to
4640 worry about size-calculation overflow.
4641 (sort_args): Check for size-calculation overflow.
4643 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4645 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4647 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4648 (x_set_scroll_bar_width, x_figure_window_size):
4649 Check for integer overflow.
4650 (x_set_alpha): Do not assume XINT fits in int.
4652 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4653 This is for the members text_lines, text_cols, total_lines, total_cols,
4654 where the system imposes an 'int' limit.
4656 * fringe.c (Fdefine_fringe_bitmap):
4657 Don't update size until alloc works.
4659 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4660 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4662 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4663 Check for size-calculation overflow.
4664 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4665 do, as we prefer signed integers.
4666 (id_to_widget.max_size, id_to_widget.used)
4667 (xg_store_widget_in_map, xg_remove_widget_from_map)
4668 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4669 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4670 Use and return ptrdiff_t, not int.
4671 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4672 * gtkutil.h: Change prototypes to match the above.
4674 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4675 are duplicate now that they've been promoted to lisp.h.
4676 (x_allocate_bitmap_record, x_alloc_image_color)
4677 (make_image_cache, cache_image, xpm_load):
4678 Don't update size until alloc is done.
4679 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4681 Check for size calculation overflow.
4682 (ct_colors_allocated_max): New constant.
4683 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4686 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4687 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4688 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4689 Use ptrdiff_t, not int, to count maps.
4690 (read_char_minibuf_menu_prompt): Check for overflow in size
4691 calculations. Don't update size until allocation succeeds.
4692 Redo calculations to avoid overflow.
4693 * keyboard.h: Change prototypes to match the above.
4695 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4697 (current_minor_maps): Check for size calculation overflow.
4698 * keymap.h: Change prototypes to match the above.
4700 * lread.c (read1, init_obarray): Don't update size until alloc done.
4702 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4703 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4705 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4706 Now ptrdiff_t, not int.
4707 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4708 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4710 * process.c (Fnetwork_interface_list): Check for overflow
4711 in size calculation.
4713 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4715 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4716 overflow. Don't bother calling xmalloc when xrealloc will do.
4718 * search.c (Freplace_match): Check for size calculation overflow.
4719 (Fset_match_data): Don't assume list lengths fit in 'int'.
4721 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4722 for command line length. Do not attempt to address one before the
4723 beginning of an array, as that's not portable.
4725 * term.c (max_frame_lines): Remove; unused.
4726 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4728 (encode_terminal_code, calculate_costs): Check for size
4729 calculation overflow.
4730 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4731 table lengths and related sizes. Don't update size until alloc
4732 done. Redo calculations to avoid overflow.
4733 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4735 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4736 subtracting pointers.
4737 (gobble_line): Check for overflow more carefully. Don't update size
4740 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4741 Don't update size until alloc done.
4742 Redo size calculations to avoid overflow.
4743 Check for size calculation overflow.
4744 (main) [DEBUG]: Fix typo in invoking tparam1.
4746 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4747 Use ptrdiff_t, not int, for sizes.
4748 (store_mode_line_noprop_char): Don't update size until alloc done.
4750 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4751 Use ptrdiff_t, not int, for sizes.
4752 (Finternal_make_lisp_face, cache_face):
4753 Check for size calculation overflow.
4754 (cache_face): Treat size calculation overflows as if they were
4755 memory exhaustion (the usual treatment), rather than aborting.
4757 * xfns.c (x_encode_text, x_set_name_internal)
4758 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4759 sizes, since they can exceed INT_MAX in size. Check for size
4760 calculation overflow.
4762 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4763 (xg_select): Check for size calculation overflow.
4764 Don't update size until alloc done.
4766 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4767 as sprintf is limited to int lengths.
4769 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4770 (X_LONG_MIN): New macros.
4771 Use them to make the following changes clearer.
4772 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4773 This change doesn't affect the value now, but it may help remind
4774 future maintainers not to raise the value too much later.
4775 (SELECTION_QUANTUM): Remove, replacing with ...
4776 (selection_quantum): ... new function, which avoids overflow.
4778 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4779 assumption that selection length fits in 'int'.
4780 (x_reply_selection_request, x_handle_selection_request)
4781 (x_get_window_property, receive_incremental_selection)
4782 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4783 (lisp_data_to_selection_data, clean_local_selection_data):
4784 Use ptrdiff_t, not int, to record length of selection.
4785 (x_reply_selection_request, x_get_window_property)
4786 (receive_incremental_selection, x_property_data_to_lisp):
4787 Redo calculations to avoid overflow.
4788 (x_reply_selection_request): When sending hint, ceiling it at
4789 X_LONG_MAX rather than relying on wraparound overflow to send
4791 (x_get_window_property, receive_incremental_selection)
4792 (lisp_data_to_selection_data, x_property_data_to_lisp):
4793 Check for size-calculation overflow.
4794 (x_get_window_property, receive_incremental_selection)
4795 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4796 Don't store size until memory allocation succeeds.
4797 (x_get_window_property): Plug memory leak on memory exhaustion.
4798 Don't double-block input; malloc is safe here. Don't assume 2**34
4799 - 4 fits in unsigned long. Add an xassert to check
4800 XGetWindowProperty overflow. Be more careful about overflow
4801 calculations, and distinguish size from memory overflow better.
4802 (receive_incremental_selection): When tracing, don't assume
4803 unsigned int is less than INT_MAX.
4804 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4805 harmful) conversions of unsigned short to int.
4806 (lisp_data_to_selection_data): Don't assume that integers
4807 in the range -65535 through -1 fit in an X unsigned short.
4808 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4809 result parameters unless successful. Rely on cons_to_unsigned
4810 to report problems with elements; the old code wasn't right anyway.
4811 (x_check_property_data): Check for int overflow; we cannot use
4812 a wider type due to X limits.
4813 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4815 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4817 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4818 (x_term_init): Check for size calculation overflow.
4819 (x_color_cells): Don't store size until memory allocation succeeds.
4820 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4821 Don't assume alloca size is less than MAX_ALLOCA.
4822 (x_term_init): Don't assume length fits in int (sprintf is limited
4825 Use ptrdiff_t for composition IDs.
4826 * character.c (lisp_string_width):
4827 * composite.c (composition_table_size, n_compositions)
4828 (get_composition_id, composition_gstring_from_id):
4829 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4830 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4831 * window.c (Frecenter):
4832 Use ptrdiff_t, not int, for composition IDs.
4833 * composite.c (get_composition_id): Check for integer overflow.
4834 * composite.h: Adjust prototypes to match the above changes.
4836 Use ptrdiff_t for hash table indexes.
4837 * category.c (hash_get_category_set):
4838 * ccl.c (ccl_driver):
4839 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4840 * coding.c (coding_system_charset_list, detect_coding_system):
4841 * coding.h (struct coding_system.id):
4842 * composite.c (get_composition_id, gstring_lookup_cache):
4843 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4844 * image.c (xpm_get_color_table_h):
4845 * lisp.h (hash_lookup, hash_put):
4846 * minibuf.c (Ftest_completion):
4847 Use ptrdiff_t for hash table indexes, not int (which is too
4848 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4849 32-bit --with-wide-int hosts).
4851 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4852 Add a FIXME comment about memory leaks.
4853 (syms_of_charset): Don't assume xmalloc returns.
4855 Don't assume that stated character widths fit in int.
4856 * character.c (Fchar_width, c_string_width, lisp_string_width):
4857 * character.h (CHAR_WIDTH):
4858 * indent.c (MULTIBYTE_BYTES_WIDTH):
4859 Use sanitize_char_width to avoid undefined and/or bad behavior
4860 with outlandish widths.
4861 * character.h (sanitize_tab_width): Rename from sanitize_width,
4862 now that we have two such functions. All uses changed.
4863 (sanitize_char_width): New inline function.
4865 Don't assume that tab-width fits in int.
4866 * character.h (sanitize_width): New inline function.
4867 (SANE_TAB_WIDTH): New macro.
4868 (ASCII_CHAR_WIDTH): Use it.
4869 * indent.c (sane_tab_width): Remove. All uses replaced by
4870 SANE_TAB_WIDTH (current_buffer).
4871 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4873 * fileio.c: Integer overflow issues with file modes.
4874 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4876 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4877 Remove unreachable code.
4878 (read_hex, load_charset_map_from_file): Check for integer overflow.
4880 * xterm.c: Don't go over XClientMessageEvent limit.
4881 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4882 (x_send_scroll_bar_event): Likewise. Check that the size does not
4883 exceed limits imposed by XClientMessageEvent, as well as the usual
4884 ptrdiff_t and size_t limits.
4886 * keyboard.c: Overflow, signedness and related fixes.
4887 (make_lispy_movement): Use same integer type in forward decl
4888 that is used in the definition.
4889 (read_key_sequence, keyremap_step):
4890 Change bufsize argument back to int, undoing my 2011-03-30 change.
4891 We prefer signed types, and int is wide enough here.
4892 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4893 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4894 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4895 length, not size_t. Use ptrdiff_t for index, not int.
4896 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4897 possibility of integer overflow.
4899 Overflow, signedness and related fixes for images.
4901 * dispextern.h (struct it.stack[0].u.image.image_id)
4902 (struct_it.image_id, struct image.id, struct image_cache.size)
4903 (struct image_cache.used, struct image_cache.ref_count):
4904 * gtkutil.c (update_frame_tool_bar):
4905 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4906 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4907 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4908 * nsmenu.m (update_frame_tool_bar):
4909 * xdisp.c (calc_pixel_width_or_height):
4910 * xfns.c (image_cache_refcount):
4911 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4912 on typical 64-bit hosts.
4914 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4915 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4916 Omit unnecessary casts to int.
4917 (parse_image_spec): Check that integers fall into 'int' range
4918 when the callers expect that.
4919 (image_ascent): Redo ascent calculation to avoid int overflow.
4920 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4921 (lookup_image): Remove unnecessary tests.
4922 (xbm_image_p): Locals are now of int, not EMACS_INT,
4923 since parse_image_check makes sure they fit into int.
4924 (png_load, gif_load, svg_load_image):
4925 Prefer int to unsigned where either will do.
4926 (tiff_handler): New function, combining the cores of the
4927 old tiff_error_handler and tiff_warning_handler.
4928 This function is rewritten to use vsnprintf and thereby avoid
4929 stack buffer overflows. It uses only the features of vsnprintf
4930 that are common to both POSIX and native Microsoft.
4931 (tiff_error_handler, tiff_warning_handler): Use it.
4932 (tiff_load, gif_load, imagemagick_load_image):
4933 Don't assume :index value fits in 'int'.
4934 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4935 (imagemagick_load_image): Check that crop parameters fit into
4936 the integer types that MagickCropImage accepts. Don't assume
4937 Vimagemagick_render_type has a nonnegative value. Don't assume
4938 size_t fits in 'long'.
4939 (gs_load): Use printmax_t to print the widest integers possible.
4940 Check for integer overflow when computing image height and width.
4942 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4944 * xdisp.c (redisplay_window): Don't force window start if point
4945 will be invisible in the resulting window. (Bug#9324)
4947 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4949 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4950 the display spec is of the form `(space ...)'.
4951 (handle_display_spec): Return the value returned by
4952 handle_single_display_spec, not just 1 or zero.
4953 (handle_single_display_spec): If the display spec is of the form
4954 `(space ...)', and specifies display in the text area, return 2
4956 (try_cursor_movement): Check for the need to scroll more
4957 accurately, and prefer exact match for point under bidi.
4958 Don't advance `row' beyond the last row of the window.
4960 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4961 into disp_prop; all users changed.
4963 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4964 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4965 for the text covered by the display property.
4967 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4969 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4970 Change return value to nil.
4971 (Frecord_buffer): Delete unused function.
4973 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4975 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4976 buffers, return left-to-right.
4977 (set_cursor_from_row): Consider candidate row a win if its glyph
4978 represents a newline and point is on that newline. Fixes cursor
4979 positioning on the newline at EOL of R2L text within L2R
4980 paragraph, and vice versa.
4981 (try_cursor_movement): Check continued rows, in addition to
4982 continuation rows. Fixes unwarranted scroll when point enters a
4983 continued line of R2L text within an L2R paragraph, or vice versa.
4984 (cursor_row_p): Consider the case of point being equal to
4985 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4986 from the end of a short line to the beginning of a continued line
4987 of R2L text within L2R paragraph.
4988 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4989 composed characters.
4991 * bidi.c (bidi_check_type): Use xassert.
4992 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4995 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4997 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5000 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5002 * nsfont.m (ns_otf_to_script): Fix typo.
5004 2011-08-22 Kenichi Handa <handa@m17n.org>
5006 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5007 extra slot even if the purpose is char-code-property-table.
5009 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5011 * xdisp.c (redisplay_window): When computing centering_position,
5012 account for the height of the header line. (Bug#8874)
5014 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5015 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5016 candidate is selected by the mouse, and that candidate has a
5017 composed character under the mouse.
5019 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5020 coordinates reported by pos-visible-in-window-p for a composed
5021 character in column zero.
5023 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5025 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5027 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5029 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5030 consider it a hit if to_charpos is anywhere in the range of the
5031 composed buffer positions.
5033 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5035 * image.c (gif_load): Don't assume that each subimage has the same
5036 dimensions as the base image. Handle disposal method that is
5037 "undefined" by the gif spec (Bug#9335).
5039 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5041 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5042 (Fcondition_case): Document `debug' symbol in error handler.
5044 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5046 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5047 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5048 from an Org mode buffer to a Speedbar frame.
5050 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5051 a composition, take its buffer position from IT->cmp_it.charpos.
5052 Fixes cursor positioning at the beginning of a line that begins
5053 with a composed character.
5055 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5057 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5058 character bidirectional type, use STRONG_L instead. Fixes crashes
5059 in a buffer produced by `describe-categories'.
5061 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5062 members before the level stack, so they would be saved and
5063 restored when copying iterator state. Fixes incorrect reordering
5064 around TABs covered by display properties.
5066 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5068 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5070 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5072 * eval.c (internal_condition_case, internal_condition_case_1)
5073 (internal_condition_case_2, internal_condition_case_n):
5074 Remove unnecessary aborts (Bug#9081).
5076 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5078 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5079 has no `load' handler, try opening the file locally. (Bug#9311)
5081 2011-08-16 Ken Brown <kbrown@cornell.edu>
5083 * gmalloc.c: Expand comment.
5085 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5087 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5088 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5090 2011-08-16 Ken Brown <kbrown@cornell.edu>
5092 Fix memory allocation problems in Cygwin build (Bug#9273).
5094 * unexcw.c ( __malloc_initialized): Declare external variable.
5095 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5097 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5099 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5101 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5103 [CYGWIN] (special_realloc): New function.
5104 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5105 requests to realloc storage in the static heap.
5107 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5109 * bidi.c (bidi_initialize): Remove unused local.
5111 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5114 * biditype.h: Remove file.
5115 * makefile.w32-in ($(BLD)/bidi.$(O)):
5116 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5118 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5120 * chartab.c: Improve commentary for the uniprop_table API.
5122 * bidi.c (bidi_paragraph_init): Support zero value of
5123 bidi_ignore_explicit_marks_for_paragraph_level.
5124 (bidi_initialize): Use uniprop_table instead of including
5125 biditype.h and bidimirror.h.
5127 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5128 coordinates of the iterator when restoring from ppos_it.
5131 2011-08-14 Kenichi Handa <handa@m17n.org>
5133 * process.c (create_process): Call setup_process_coding_systems
5134 after the pid of the process is set to -1 (Bug#8162).
5136 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5138 * xdisp.c (move_it_in_display_line_to): Don't invoke
5139 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5140 ppos_it. Fixes vertical cursor motion when line beginning is
5141 covered by an image. (Bug#9296)
5143 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5145 * nsterm.h (ns_run_ascript): Declare.
5146 (NSAPP_DATA2_RUNASSCRIPT): Define.
5148 * nsfns.m (as_script, as_result, as_status): New static variables.
5149 (ns_run_ascript): New function.
5150 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5151 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5152 the event loop. Get status from as_status (Bug#7276).
5154 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5155 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5156 the event loop (Bug#7276).
5158 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5160 * gnutls.c (QCgnutls_bootprop_priority)
5161 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5162 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5163 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5164 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5165 (QCgnutls_bootprop_verify_hostname_error)
5166 (QCgnutls_bootprop_callbacks_verify): Rename from
5167 Qgnutls_bootprop_..., all uses changed.
5169 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5172 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5174 * xfaces.c (Qframe_set_background_mode): Now static.
5175 * dispextern.h (Qframe_set_background_mode): Remove decl.
5177 * process.c (Fnetwork_interface_info): Declare local only if needed.
5179 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5181 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5182 (Fnetwork_interface_list): Allocate in increments of bytes instead
5183 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5184 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5186 (struct ifflag_def): notrailers is smart on OSX.
5187 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5188 Get hardware address with getifaddrs if available.
5190 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5192 * xdisp.c (iterate_out_of_display_property): xassert that
5193 IT->position is set to within IT->object's boundaries. Break from
5194 the loop as soon as EOB is reached; avoids infloops in redisplay
5195 when IT->position is set up wrongly due to some bug.
5196 Set IT->current to match the bidi iterator unconditionally.
5197 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5198 entry. Force push_it to save on the stack the current
5199 buffer/string position, to be restored by pop_it. Fix flags in
5200 the iterator structure wrt the object coming from a display
5201 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5202 properties. (Bug#9284)
5204 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5206 * fontset.c (fontset_get_font_group): Add proper type checks.
5209 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5211 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5212 and LC_VERSION_MIN_MACOSX.
5213 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5214 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5216 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5218 * xdisp.c (forward_to_next_line_start): Allow to use the
5219 no-display-properties-and-no-overlays under bidi display.
5220 Set disp_pos in the bidi iterator to avoid searches for display
5221 properties and overlays.
5223 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5225 * editfns.c (Fset_time_zone_rule): Document relationship with the
5228 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5229 the font entity extracted from the cache (Bug#8109).
5231 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5233 * composite.c (autocmp_chars): Don't reset point. That is done by
5234 restore_point_unwind (Bug#5984).
5236 2011-08-07 Juri Linkov <juri@jurta.org>
5238 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5239 to show the arg `TIME' instead of `TIMEVAL'.
5241 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5243 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5244 display property strides EOL and includes a newline, as in
5245 longlines-mode. (Bug#9254)
5246 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5247 word-wrap under bidirectional display. (Bug#9224)
5249 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5250 is non-zero, even if the data buffer is NULL. Fixes a crash in
5251 vertical-motion with longlines-mode. (Bug#9254)
5253 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5255 * bidi.c <bidi_cache_total_alloc>: Now static.
5256 (bidi_initialize): Initialize bidi_cache_total_alloc.
5258 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5261 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5262 amount allocated this far in `bidi_cache_total_alloc'.
5263 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5264 non-zero, only free the data buffer without restoring the cache
5265 contents. All callers changed.
5267 * dispextern.h (bidi_unshelve_cache): Update prototype.
5269 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5270 (move_it_in_display_line, move_it_to)
5271 (move_it_vertically_backward, move_it_by_lines): Replace the call
5272 to xfree to an equivalent call to bidi_unshelve_cache.
5273 (move_it_in_display_line_to): Fix logic of returning
5274 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5276 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5278 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5279 came from a string character with a `cursor' property. (Bug#9229)
5281 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5283 * Makefile.in (LIB_PTHREAD): New variable.
5284 (LIBES): Add LIB_PTHREAD (Bug#9216).
5286 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5287 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5289 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5291 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5293 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5295 * xterm.c (x_find_topmost_parent): New function.
5296 (x_set_frame_alpha): Find topmost parent window with
5297 x_find_topmost_parent and set the property there also (bug#9181).
5298 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5300 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5302 * callproc.c (Fcall_process): Avoid vfork clobbering
5303 the local vars buffer, coding_systems, current_dir.
5305 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5307 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5309 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5311 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5312 so that it is not optimized away.
5314 * xdisp.c (compute_display_string_pos): Remove unused local.
5316 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5318 Fix slow cursor motion and scrolling in large buffers with
5319 selective display, like Org Mode buffers. (Bug#9218)
5321 * dispextern.h (struct bidi_it): New member disp_prop_p.
5323 * xdisp.c: Remove one-slot cache of display string positions.
5324 (compute_display_string_pos): Accept an additional argument
5325 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5326 for a display string or property. If found, set DISP_PROP_P
5329 * bidi.c (bidi_fetch_char): Accept an additional argument
5330 DISP_PROP_P, and pass it to compute_display_string_pos.
5331 Only handle text covered by a display string if DISP_PROP_P is returned
5332 non-zero. All callers of bidi_fetch_char changed.
5334 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5336 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5338 2010-12-03 Don March <don@ohspite.net>
5340 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5341 last character M-[char] is translated to ESC [char] (bug#7541).
5343 2011-08-02 Kenichi Handa <handa@m17n.org>
5345 * lisp.h (uniprop_table): Extern it.
5347 * chartab.c (uniprop_table): Make it non-static.
5349 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5351 * xdisp.c (forward_to_next_line_start): Accept additional argument
5352 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5354 (reseat_at_next_visible_line_start): Use the bidi iterator state
5355 returned by forward_to_next_line_start to restore the state of
5356 it->bidi_it after backing up to previous newline. (Bug#9212)
5358 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5360 * regex.c (re_comp): Protoize.
5361 (re_exec): Fix return type.
5362 (regexec): Fix type of `ret'. (Bug#9203)
5364 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5366 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5367 This is needed if max-image-size is a floating-point number.
5369 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5371 * print.c (print_object): Print empty symbol as ##.
5373 * lread.c (read1): Read ## as empty symbol.
5375 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5377 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5378 setting frame foreground color (Bug#9175).
5379 (x_set_background_color): Likewise.
5381 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5382 contents (Bug#9176).
5383 (EmacsTooltip -init): Remove bezels and add shadows to
5386 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5387 or scroll bar (Bug#8470).
5389 * nsfont.m (nsfont_open): Remove assignment to voffset and
5390 unnecessary vars hshink, expand, hd, full_height, min_height.
5391 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5393 * nsterm.h (nsfont_info): Remove voffset field.
5395 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5397 Implement strike-through and overline on NextStep (Bug#8863).
5399 * nsfont.m (nsfont_open): Use underline position provided by font,
5400 instead of hard-coded value of 2.
5401 (nsfont_draw): Call ns_draw_text_decoration instead.
5403 * nsterm.h: Add declaration for ns_draw_text_decoration.
5405 * nsterm.m (ns_draw_text_decoration): New function for drawing
5406 underline, overline, and strike-through.
5407 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5408 ns_draw_text_decoration. Change treatment of cursor drawing to
5409 accommodate underlining, etc.
5411 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5413 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5416 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5418 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5419 Without this fix, if a signal arrives just after memory fills up,
5420 'malloc' might be invoked reentrantly.
5422 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5423 In other words, assume that every image size is allowed, on non-X
5424 hosts. This assumption is probably wrong, but it lets Emacs compile.
5426 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5428 * regex.c (re_iswctype): Convert return values to boolean.
5430 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5432 * xdisp.c (compute_display_string_pos): Don't use cached display
5433 string position if the buffer had its restriction changed.
5436 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5438 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5440 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5442 Integer signedness and overflow and related fixes. (Bug#9079)
5444 * bidi.c: Integer size and overflow fixes.
5445 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5446 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5447 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5448 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5449 (bidi_find_other_level_edge):
5450 Use ptrdiff_t instead of EMACS_INT where either will do.
5451 This works better on 32-bit hosts configured --with-wide-int.
5452 (bidi_cache_ensure_space): Check for size-calculation overflow.
5453 Use % rather than repeated addition, for better worst-case speed.
5454 Don't set bidi_cache_size until after xrealloc returns, because it
5456 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5457 (bidi_cache_ensure_space): Also check that the bidi cache size
5458 does not exceed that of the largest Lisp string or buffer. See Eli
5459 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5461 * alloc.c (__malloc_size_t): Remove.
5462 All uses replaced by size_t. See Andreas Schwab's note
5463 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5465 * image.c: Improve checking for integer overflow.
5466 (check_image_size): Assume that f is nonnull, since
5467 it is always nonnull in practice. This is one less thing to
5468 worry about when checking for integer overflow later.
5469 (x_check_image_size): New function, which checks for integer
5470 overflow issues inside X.
5471 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5472 This removes the need for a memory_full check.
5473 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5474 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5475 (xbm_read_bitmap_data): Change locals back to 'int', since
5476 their values must fit in 'int'.
5477 (xpm_load_image, png_load, tiff_load):
5478 Invoke x_create_x_image_and_pixmap earlier,
5479 to avoid much needless work if the image is too large.
5480 (tiff_load): Treat overly large images as if
5481 x_create_x_image_and_pixmap failed, not as malloc failures.
5482 (gs_load): Use x_check_image_size.
5484 * gtkutil.c: Omit integer casts.
5485 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5486 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5488 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5490 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5491 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5492 would wrongly return t on a 64-bit host.
5494 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5495 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5496 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5497 and therefore cause GCC to emit a bogus diagnostic in some cases.
5499 * image.c: Integer signedness and overflow and related fixes.
5500 This is not an exhaustive set of fixes, but it's time to
5501 record what I've got.
5502 (lookup_pixel_color, check_image_size): Remove redundant decls.
5503 (check_image_size): Don't assume that arbitrary EMACS_INT values
5504 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5505 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5506 (tiff_load, imagemagick_load_image):
5507 Check for overflow in size calculations.
5508 (x_create_x_image_and_pixmap): Remove unnecessary test for
5509 xmalloc returning NULL; that can't happen.
5510 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5511 (xpm_color_bucket): Use better integer hashing function.
5512 (xpm_cache_color): Don't possibly over-allocate memory.
5513 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5514 (gif_memory_source):
5515 Use ptrdiff_t, not int or size_t, to record sizes.
5516 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5517 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5518 either works, as we prefer signed integers.
5519 (tiff_read_from_memory, tiff_write_from_memory):
5520 Return tsize_t, not size_t, since that's what the TIFF API wants.
5521 (tiff_read_from_memory): Don't fail simply because the read would
5522 go past EOF; instead, return a short read.
5523 (tiff_load): Omit no-longer-needed casts.
5524 (Fimagemagick_types): Don't assume size fits into 'int'.
5526 Improve hashing quality when configured --with-wide-int.
5527 * fns.c (hash_string): New function, taken from sxhash_string.
5528 Do not discard information about ASCII character case; this
5529 discarding is no longer needed.
5530 (sxhash-string): Use it. Change sig to match it. Caller changed.
5531 * lisp.h: Declare it.
5532 * lread.c (hash_string): Remove, since we now use fns.c's version.
5533 The fns.c version returns a wider integer if --with-wide-int is
5534 specified, so this should help the quality of the hashing a bit.
5536 * emacs.c: Integer overflow minor fix.
5537 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5538 Define only if GNU_LINUX.
5539 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5541 * dispnew.c: Integer signedness and overflow fixes.
5542 Remove unnecessary forward decls, that were a maintenance hassle.
5543 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5545 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5546 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5547 (prepare_desired_row, line_draw_cost):
5548 Use int, not unsigned, where either works.
5549 (save_current_matrix, restore_current_matrix):
5550 Use ptrdiff_t, not size_t, where either works.
5551 (init_display): Check for overflow more accurately, and without
5552 relying on undefined behavior.
5554 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5555 Remove, replacing with the new symbols in lisp.h. All uses changed.
5556 * fileio.c (make_temp_name):
5557 * filelock.c (lock_file_1, lock_file):
5558 * xdisp.c (message_dolog):
5559 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5560 Use pMd etc. instead.
5561 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5562 replacing the pWIDE etc. symbols removed from editfns.c.
5564 * keyboard.h (num_input_events): Now uintmax_t.
5565 This is (very slightly) less likely to mess up due to wraparound.
5568 * buffer.c: Integer signedness fixes.
5569 (alloc_buffer_text, enlarge_buffer_text):
5570 Use ptrdiff_t rather than size_t when either will do, as we prefer
5573 * alloc.c: Integer signedness and overflow fixes.
5574 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5575 (__malloc_size_t): Default to size_t, not to int.
5576 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5577 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5578 Prefer ptrdiff_t to size_t when either would do, as we prefer
5580 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5581 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5582 Now const. Initialize with values that are in range even if char
5584 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5585 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5586 These functions do the right thing with sizes > 2**32.
5587 (check_depth): Now ptrdiff_t, not int.
5588 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5589 Adjust to new way of storing sizes. Check for size overflow bugs
5591 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5592 slightly wrong anyway, as it missed one instance of
5593 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5594 (refill_memory_reserve): Omit needless cast to size_t.
5595 (mark_object_loop_halt): Mark as externally visible.
5597 * xselect.c: Integer signedness and overflow fixes.
5598 (Fx_register_dnd_atom, x_handle_dnd_message):
5599 Use ptrdiff_t, not size_t, since we prefer signed.
5600 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5601 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5602 x_dnd_atoms_size and x_dnd_atoms_length.
5604 * doprnt.c: Prefer signed to unsigned when either works.
5606 * doprnt.c (doprnt):
5608 * xdisp.c (vmessage):
5609 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5610 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5611 prefer signed arithmetic to avoid comparison confusion.
5612 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5613 but is a bit tricky.
5615 Assume freestanding C89 headers, string.h, stdlib.h.
5616 * data.c, doprnt.c, floatfns.c, print.c:
5617 Include float.h unconditionally.
5618 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5619 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5620 * regex.c: Likewise for stddef.h, string.h.
5621 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5622 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5623 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5624 (STDC_HEADERS): Remove obsolete defines.
5625 * sysdep.c: Include limits.h unconditionally.
5627 Assume support for memcmp, memcpy, memmove, memset.
5628 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5629 * regex.c (memcmp, memcpy):
5630 Remove; we assume C89 now.
5632 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5633 (__malloc_safe_bcopy): Remove; no longer needed.
5635 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5636 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5637 well either way, and we prefer signed to unsigned.
5639 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5641 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5642 closes the connection while we're reading (bug#9182).
5644 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5646 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5647 are specified (Bug#9168).
5649 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5651 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5652 Found by GCC static checking and --with-wide-int on a 32-bit host.
5654 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5656 * xdisp.c (compute_display_string_pos): Fix logic of caching
5657 previous display string position. Initialize cached_prev_pos to
5658 -1. Fixes slow-down at the beginning of a buffer.
5660 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5662 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5663 for attrs[LFACE_FONTSET_INDEX].
5665 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5667 * xml.c (parse_region): Remove unused local
5668 that was recently introduced.
5670 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5672 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5673 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5675 * xdisp.c (move_it_in_display_line_to): Record the best matching
5676 position for TO_CHARPOS while scanning the line, and restore it on
5677 exit if none of the characters scanned was an exact match.
5678 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5679 when exact match is impossible due to invisible text, and the
5680 lines are truncated.
5682 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5684 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5687 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5689 Fix a significant slow-down of cursor motion with C-n, C-p,
5690 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5691 auto-repeat under bidi redisplay in fontified buffers.
5692 * xdisp.c (compute_stop_pos_backwards): New function.
5693 (next_element_from_buffer): Call compute_stop_pos_backwards to
5694 find a suitable prev_stop when we find ourselves before
5696 (reseat): Don't look for prev_stop, as that could mean a very long
5698 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5699 <cached_disp_overlay_modiff>: Cache for last found display string
5701 (compute_display_string_pos): Return the cached position if asked
5702 about the same buffer in the same area of character positions, and
5703 the buffer wasn't changed since the time the display string
5704 position was cached.
5706 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5708 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5709 is an integer, which is important for empty lines. (Bug#9149)
5711 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5713 * frame.c (Fmodify_frame_parameters): In tty case, update the
5714 default face if necessary (Bug#4238).
5716 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5718 * editfns.c (Fstring_to_char): No need to explain what a character
5719 is in the docstring (Bug#6576).
5721 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5723 * xml.c (parse_region): Make sure we always return a tree.
5725 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5727 * xml.c (parse_region): If a document contains only comments,
5730 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5732 * xml.c (make_dom): Return comments, too.
5734 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5737 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5738 and the surrounding thread.
5739 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5740 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5741 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5743 * s/openbsd.h (BROKEN_SIGIO): Define.
5744 * unexelf.c (unexec) [__OpenBSD__]:
5745 Don't update the .mdebug section of the Alpha COFF symbol table.
5747 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5749 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5752 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5754 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5755 This fixes some race conditions on the permissions of any newly
5758 * alloc.c (valid_pointer_p): Use pipe, not open.
5759 This fixes some permissions issues when debugging.
5761 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5762 If fchown fails to set both uid and gid, try to set just gid,
5763 as that is sometimes allowed. Adjust the file's mode to eliminate
5764 setuid or setgid bits that are inappropriate if fchown fails.
5766 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5768 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5769 to compare Lisp_Objects.
5770 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5771 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5772 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5774 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5776 * lread.c (read_integer): Unread even EOF character.
5777 (read1): Likewise. Properly record start position of symbol.
5779 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5780 symbol character follows.
5782 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5784 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5785 This works around a problem with the previous change to Fcopy_file.
5786 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5787 and without this change, GCC might complain about discarding
5788 fchown's return value.
5790 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5792 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5794 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5796 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5798 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5800 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5801 it's used from the C level.
5803 * process.c: Use the same condition for POLL_FOR_INPUT in both
5804 keyboard.c and process.c (bug#1858).
5806 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5808 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5809 (Fgnutls_boot): Use it.
5811 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5813 * doc.c (Fsubstitute_command_keys): Revert last change.
5815 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5817 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5818 quotes the next character, and doesn't affect other longer
5819 sequences (bug#8935).
5821 * lread.c (syms_of_lread): Clarify that is isn't only
5822 `eval-buffer' and `eval-defun' that's affected by
5823 `lexical-binding' (bug#8460).
5825 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5827 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5828 bidi redisplay when a line includes both an image and is truncated.
5830 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5832 Fix minor problems found by static checking.
5833 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5834 (elsz): Now a signed constant, not a size_t var. We prefer signed
5835 types to unsigned, to avoid integer comparison confusion. Without
5836 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5837 "cannot optimize loop, the loop counter may overflow", a symptom
5839 * indent.c (Fvertical_motion): Mark locals as initialized.
5840 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5842 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5844 * search.c (Fre_search_backward): Mention `case-fold-search' in
5845 all the re_search_* functions (bug#8138).
5847 * keyboard.c (Fopen_dribble_file): Document when the file is
5850 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5852 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5855 Support bidi reordering of display and overlay strings.
5856 * xdisp.c (compute_display_string_pos)
5857 (compute_display_string_end): Accept additional argument STRING.
5858 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5859 (reseat_to_string): Initialize bidi_it->string.s and
5860 bidi_it->string.schars.
5861 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5862 NULL (avoids a crash in bidi_paragraph_init).
5863 Initialize itb.string.lstring.
5864 (init_iterator): Call bidi_init_it only of a valid
5865 buffer position was specified. Initialize paragraph_embedding to
5867 (reseat_to_string): Initialize the bidi iterator.
5868 (display_string): If we need to ignore text properties of
5869 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5870 original value of -1 will not work with bidi.)
5871 (compute_display_string_pos): First arg is now struct
5872 `text_pos *'; all callers changed. Support display properties on
5874 (compute_display_string_end): Support display properties on Lisp
5876 (init_iterator, reseat_1, reseat_to_string): Initialize the
5877 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5878 when iterating on a string not from display properties).
5879 (compute_display_string_pos, compute_display_string_end):
5880 Fix calculation of the object to scan. Fixes an error when using
5882 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5883 base_level_stop; instead, set base_level_stop to BEGV.
5884 Fixes crashes in vertical-motion.
5885 (next_element_from_buffer): Improve commentary for when
5886 the iterator is before prev_stop.
5887 (init_iterator): Initialize bidi_p from the default value of
5888 bidi-display-reordering, not from buffer-local value. Use the
5889 buffer-local value only if initializing for buffer iteration.
5890 (handle_invisible_prop): Support invisible properties on strings
5891 that are being bidi-reordered.
5892 (set_iterator_to_next): Support bidi reordering of C strings and
5894 (next_element_from_string): Support bidi reordering of Lisp
5896 (handle_stop_backwards): Support Lisp strings as well.
5897 (display_string): Support display of R2L glyph rows.
5898 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5899 (init_iterator): Don't initialize it->bidi_p for strings
5901 (reseat_to_string): Initialize it->bidi_p for strings here.
5902 (next_element_from_string, next_element_from_c_string)
5903 (next_element_from_buffer): Add xassert's for correspondence
5904 between IT's object being iterated and it->bidi_it.string
5906 (face_before_or_after_it_pos): Support bidi iteration.
5907 (next_element_from_c_string): Handle the case of the first string
5908 character that is not the first one in the visual order.
5909 (get_visually_first_element): New function, refactored from common
5910 parts of next_element_from_buffer, next_element_from_string, and
5911 next_element_from_c_string.
5912 (tool_bar_lines_needed, redisplay_tool_bar)
5913 (display_menu_bar): Force left-to-right direction. Add a FIXME
5914 comment for making that be controlled by a user option.
5915 (push_it, pop_it): Save and restore the state of the
5916 bidi iterator. Save and restore the bidi_p flag.
5917 (pop_it): Iterate out of display property for string iteration as
5919 (iterate_out_of_display_property): Support iteration over strings.
5920 (handle_single_display_spec): Set up it->bidi_it for iteration
5921 over a display string, and call bidi_init_it.
5922 (handle_single_display_spec, next_overlay_string)
5923 (get_overlay_strings_1, push_display_prop): Set up the bidi
5924 iterator for displaying display or overlay strings.
5925 (forward_to_next_line_start): Don't use the shortcut if
5927 (back_to_previous_visible_line_start): If handle_display_prop
5928 pushed the iterator stack, restore the internal state of the bidi
5929 iterator by calling bidi_pop_it same number of times.
5930 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5931 and we are bidi-iterating, don't decrement the iterator position;
5932 instead, set the first_elt flag in the bidi iterator, to produce
5934 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5935 (push_display_prop): xassert that we are iterating a buffer.
5936 (push_it, pop_it): Save and restore paragraph_embedding member.
5937 (handle_single_display_spec, next_overlay_string)
5938 (get_overlay_strings_1, reseat_1, reseat_to_string)
5939 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5940 correctly. Don't assume unibyte strings are not bidi-reordered.
5941 (compute_display_string_pos)
5942 (compute_display_string_end): Fix handling the case of C string.
5943 (push_it, pop_it): Save and restore from_disp_prop_p.
5944 (handle_single_display_spec, push_display_prop): Set the
5945 from_disp_prop_p flag.
5946 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5947 (pop_it): Call iterate_out_of_display_property only if we are
5948 popping after iteration over a string that came from a display
5949 property. Fix a typo in popping stretch info. Add an assertion
5950 for verifying that the iterator position is in sync with the bidi
5952 (handle_single_display_spec, get_overlay_strings_1)
5953 (push_display_prop): Fix initialization of paragraph direction for
5954 string when that of the parent object is not yet determined.
5955 (reseat_1): Call bidi_init_it to resync the bidi
5956 iterator with IT's position. (Bug#7616)
5957 (find_row_edges): If ROW->start.pos gives position
5958 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5959 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5960 Reset the from_disp_prop_p flag.
5961 (SAVE_IT, RESTORE_IT): New macros.
5962 (pos_visible_p, face_before_or_after_it_pos)
5963 (back_to_previous_visible_line_start)
5964 (move_it_in_display_line_to, move_it_in_display_line)
5965 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5966 (try_scrolling, redisplay_window, display_line): Use them when
5967 saving a temporary copy of the iterator and restoring it back.
5968 (back_to_previous_visible_line_start, reseat_1)
5969 (init_iterator): Empty the bidi cache "stack".
5970 (move_it_in_display_line_to): If iterator ended up at
5971 EOL, but we never saw any buffer positions smaller than
5972 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5973 motion in bidi-reordered lines.
5974 (move_it_in_display_line_to): Record prev_method and prev_pos
5975 immediately before the call to set_iterator_to_next. Fixes cursor
5976 motion in bidi-reordered lines with stretch glyphs and strings
5977 displayed in margins. (Bug#8133) (Bug#8867)
5978 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5980 (pos_visible_p): Support positions in bidi-reordered lines.
5981 Save and restore bidi cache.
5983 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5984 (bidi_paragraph_info): Delete unused struct.
5985 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5986 (bidi_cache_start): New variable.
5987 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5989 (bidi_cache_fetch_state, bidi_cache_search)
5990 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5991 (bidi_cache_find, bidi_peek_at_next_level)
5992 (bidi_level_of_next_char, bidi_find_other_level_edge)
5993 (bidi_move_to_visually_next): Compare cache index with
5994 bidi_cache_start rather than with zero.
5995 (bidi_fetch_char): Accept new argument STRING; all callers
5996 changed. Support iteration over a string. Support strings with
5997 display properties. Support unibyte strings. Fix the type of
5998 `len' according to what STRING_CHAR_AND_LENGTH expects.
5999 (bidi_paragraph_init, bidi_resolve_explicit_1)
6000 (bidi_resolve_explicit, bidi_resolve_weak)
6001 (bidi_level_of_next_char, bidi_move_to_visually_next):
6002 Support iteration over a string.
6003 (bidi_set_sor_type, bidi_resolve_explicit_1)
6004 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6005 can now be zero (for strings); special values 0 and -1 were
6006 changed to -1 and -2, respectively.
6007 (bidi_char_at_pos): New function.
6008 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6009 Call it instead of FETCH_MULTIBYTE_CHAR.
6010 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6011 initialized to valid values.
6012 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6014 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6015 the test for valid cached positions. Fix the logic for looking up
6016 the sentinel state in the cache. GCPRO the Lisp string we are
6018 (bidi_push_it, bidi_pop_it): New functions.
6019 (bidi_initialize): Initialize the bidi cache start stack pointer.
6020 (bidi_cache_ensure_space): New function, refactored from part of
6021 bidi_cache_iterator_state. Don't assume the required size is just
6022 one BIDI_CACHE_CHUNK away.
6023 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6024 (bidi_count_bytes, bidi_char_at_pos): New functions.
6025 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6026 always valid if bidi_cache_idx is valid.
6027 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6028 is valid if it's going to be used.
6029 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6030 (bidi_cache_fetch_state, bidi_cache_search)
6031 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6032 (bidi_cache_iterator_state, bidi_cache_find)
6033 (bidi_find_other_level_edge, bidi_cache_start_stack):
6034 All variables related to cache indices are now EMACS_INT.
6036 * dispextern.h (struct bidi_string_data): New structure.
6037 (struct bidi_it): New member `string'. Make flag members be 1-bit
6038 fields, and put them last in the struct.
6039 (compute_display_string_pos, compute_display_string_end):
6041 (bidi_push_it, bidi_pop_it): Add prototypes.
6042 (struct iterator_stack_entry): New members bidi_p,
6043 paragraph_embedding, and from_disp_prop_p.
6044 (struct it): Member bidi_p is now a bit field 1 bit wide.
6045 (bidi_shelve_cache, bidi_unshelve_cache):
6048 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6049 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6050 and vector-like objects.
6052 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6053 cache around display iteration.
6055 * window.c (Fwindow_end, window_scroll_pixel_based)
6056 (displayed_window_lines, Frecenter): Save and restore the bidi
6057 cache around display iteration.
6059 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6061 * editfns.c (Fdelete_region): Clarify the use of the named
6062 parameters (bug#6788).
6064 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6066 * indent.c (Fvertical_motion): Set and restore w->pointm when
6067 saving and restoring the window's buffer (Bug#9006).
6069 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6071 * editfns.c (Fstring_to_char): Clarify just what is returned
6072 (bug#6576). Text by Eli Zaretskii.
6074 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6076 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6078 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6080 * buffer.c (mmap_find): Fix a typo.
6082 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6084 Fix execution of x selection hooks.
6085 * xselect.c (Qx_lost_selection_functions)
6086 (Qx_sent_selection_functions): New vars.
6087 (syms_of_xselect): DEFSYM them.
6088 (x_handle_selection_request): Pass Qx_sent_selection_functions
6089 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6090 (x_handle_selection_clear,x_clear_frame_selections):
6091 Pass Qx_lost_selection_functions rather than
6092 Vx_lost_selection_functions to Frun_hook_with_args.
6094 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6096 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6097 The old code sometimes used this field without initializing it.
6099 * alloc.c (gc_sweep): Don't read past end of array.
6100 In theory, the old code could also have corrupted Emacs internals,
6101 though it'd be very unlikely.
6103 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6105 * character.c (Fcharacterp): Don't advertise optional ignored
6106 argument. (Bug#4026)
6108 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6110 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6113 * window.c (Fset_window_start): Doc fix (bug#4199).
6114 (Fset_window_hscroll): Ditto.
6116 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6118 Fix minor new problems caught by GCC 4.6.1.
6119 * term.c (init_tty): Remove unused local.
6120 * xsettings.c (store_monospaced_changed): Define this function only
6121 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6124 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6126 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6128 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6130 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6131 are the mini-buffer and the echo area (bug#3320).
6133 * term.c (init_tty): Remove support for supdup, c10 and perq
6134 terminals, which are no longer supported (bug#1482).
6136 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6138 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6140 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6142 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6143 for non-popups (Bug#3642).
6145 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6147 * alloc.c (reset_malloc_hooks): Protoize.
6148 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6149 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6150 * cm.c (losecursor): Likewise.
6151 * data.c (fmod): Likewise.
6152 * dispnew.c (swap_glyphs_in_rows): Likewise.
6153 * emacs.c (memory_warning_signal): Likewise.
6154 * floatfns.c (float_error): Likewise.
6155 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6156 (otf_open, font_otf_capability, generate_otf_features)
6157 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6159 * image.c (pbm_read_file): Likewise.
6160 * indent.c (string_display_width): Likewise.
6161 * intervals.c (check_for_interval, search_for_interval)
6162 (inc_interval_count, count_intervals, root_interval)
6163 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6164 * lread.c (defalias): Likewise.
6165 * ralloc.c (r_alloc_check): Likewise.
6166 * regex.c (set_image_of_range_1, set_image_of_range)
6167 (regex_grow_registers): Likewise.
6168 * sysdep.c (strerror): Likewise.
6169 * termcap.c (valid_filename_p, tprint, main): Likewise.
6170 * tparam.c (main): Likewise.
6171 * unexhp9k800.c (run_time_remap, save_data_space)
6172 (update_file_ptrs, read_header, write_header, calculate_checksum)
6173 (copy_file, copy_rest, display_header): Likewise.
6174 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6176 * xdisp.c (check_it): Likewise.
6177 * xfaces.c (register_color, unregister_color, unregister_colors):
6179 * xfns.c (print_fontset_result): Likewise.
6180 * xrdb.c (member, fatal, main): Likewise.
6182 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6184 Fix minor problems found by static checking (Bug#9031).
6185 * chartab.c (char_table_set_range, map_sub_char_table):
6186 Remove unused locals.
6187 (uniprop_table): Now static.
6188 * composite.c (_work_char): Remove unused static var.
6190 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6192 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6194 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6196 * gtkutil.c (qttip_cb): Remove code without function.
6198 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6200 * w32.c (pthread_sigmask): New stub.
6202 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6204 Use pthread_sigmask, not sigprocmask (Bug#9010).
6205 sigprocmask is portable only for single-threaded applications, and
6206 Emacs can be multi-threaded when it uses GTK.
6207 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6209 * callproc.c (Fcall_process):
6210 * process.c (create_process):
6211 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6212 Use pthread_sigmask, not sigprocmask.
6214 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6216 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6217 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6220 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6222 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6223 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6224 (xg_hide_tooltip): Fix comment.
6226 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6227 in registerServicesMenuSendTypes.
6228 (validRequestorForSendType): Don't check ns_return_types.
6230 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6233 2011-07-08 Jason Rumney <jasonr@gnu.org>
6235 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6236 SH_SHOW for hidden windows (Bug#5482).
6238 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6239 frame struct members of non-existent frames (Bug#6284).
6241 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6243 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6244 variable firstTime not needed on OSX >= 10.6.
6245 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6246 >= 10.5. Use setKnobProportion, setDoubleValue.
6248 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6249 (MAC_OS_X_VERSION_10_5): Define if not defined.
6250 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6251 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6252 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6254 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6255 cString and lossyCString on OSX >= 10.4
6257 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6258 sizeToFit on OSX >= 10.2.
6260 * nsimage.m (allocInitFromFile): Don't use deprecated method
6261 bestRepresentationForDevice on OSX >= 10.6.
6263 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6266 * emacs.c: Declare unexec_init_emacs_zone.
6268 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6270 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6272 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6273 on svcsMenu (Bug#8842).
6275 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6277 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6279 * nsterm.m (QUTF8_STRING): Declare.
6280 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6281 (validRequestorForSendType): Return type is (id).
6282 Change indexOfObjectIdenticalTo to indexOfObject.
6283 Check if we have local selection before returning self (Bug#8842).
6284 (writeSelectionToPasteboard): Put local selection into paste board
6285 if we have a local selection (Bug#8842).
6286 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6288 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6289 (ns_get_local_selection): Declare.
6291 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6293 * keymap.c (describe_map_tree): Don't insert a double newline at
6294 the end of the buffer (bug#1169) and return whether we inserted
6297 * callint.c (Fcall_interactively): Change "reading args" to
6298 "providing args" to try to clarify what it does (bug#1010).
6300 2011-07-07 Kenichi Handa <handa@m17n.org>
6302 * composite.c (composition_compute_stop_pos): Ignore a static
6303 composition starting before CHARPOS (Bug#8915).
6305 * xdisp.c (handle_composition_prop): Likewise.
6307 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6309 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6312 2011-07-07 Kenichi Handa <handa@m17n.org>
6314 * character.h (unicode_category_t): New enum type.
6316 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6317 (Qchar_code_property_table): New variable.
6318 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6319 (UNIPROP_COMPRESSED_FORM_P): New macros.
6320 (char_table_ascii): Uncompress the compressed values.
6321 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6322 Uncompress the compressed values.
6323 (sub_char_table_ref_and_range): Likewise.
6324 (char_table_ref_and_range): Uncompress the compressed values.
6325 (sub_char_table_set): New arg is_uniprop. Callers changed.
6326 Uncompress the compressed values.
6327 (sub_char_table_set_range): Args changed. Callers changed.
6328 (char_table_set_range): Adjuted for the above change.
6329 (map_sub_char_table): Delete args default_val and parent. Add arg
6330 top. Give decoded values to a Lisp function.
6331 (map_char_table): Adjust for the above change. Give decoded
6332 values to a Lisp function. Gcpro more variables.
6333 (uniprop_table_uncompress)
6334 (uniprop_decode_value_run_length): New functions.
6335 (uniprop_decoder, uniprop_decoder_count): New variables.
6336 (uniprop_get_decoder, uniprop_encode_value_character)
6337 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6339 (uniprop_encoder, uniprop_encoder_count): New variables.
6340 (uniprop_get_encoder, uniprop_table)
6341 (Funicode_property_table_internal, Fget_unicode_property_internal)
6342 (Fput_unicode_property_internal): New functions.
6343 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6344 Sunicode_property_table_internal, Sget_unicode_property_internal,
6345 and Sput_unicode_property_internal. Defvar_lisp
6346 char-code-property-alist.
6348 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6349 Vunicode_category_table.
6351 * font.c (font_range): Adjust for the change of
6352 Vunicode_category_table.
6354 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6356 * m/iris4d.h: Remove file, move contents ...
6357 * s/irix6-5.h: ... here.
6359 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6361 Remove unportable assumption about struct layout (Bug#8884).
6362 * alloc.c (mark_buffer):
6363 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6364 (clone_per_buffer_values): Don't assume that
6365 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6366 This isn't true in general, and it's particularly not true
6367 if Emacs is configured with --with-wide-int.
6368 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6369 New macros, used in the buffer.c change.
6371 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6373 * xsettings.c: Use both GConf and GSettings if both are available.
6374 (store_config_changed_event): Add comment.
6375 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6376 (store_tool_bar_style_changed): New functions.
6377 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6378 (struct xsettings): Move font inside HAVE_XFT.
6379 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6380 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6381 Move inside HAVE_XFT.
6382 (something_changed_gsettingsCB): Rename from something_changedCB.
6383 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6385 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6386 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6387 (something_changed_gconfCB): Rename from something_changedCB.
6388 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6389 (parse_settings): Move check for font inside HAVE_XFT.
6390 (read_settings, apply_xft_settings): Add comment.
6391 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6392 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6393 call store_font_name_changed.
6394 (xft_settings_event): Add comment.
6395 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6396 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6397 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6398 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6399 (xsettings_initialize): Call init_gsettings last.
6400 (xsettings_get_system_font, xsettings_get_system_normal_font):
6403 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6405 Random fixes. E.g., (random) never returned negative values.
6406 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6407 subseconds part to the entropy, as that's a bit more random.
6408 Prefer signed to unsigned, since the signedness doesn't matter and
6409 in general we prefer signed. When given a limit, use a
6410 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6411 latter isn't right if USE_2_TAGS_FOR_INTS.
6412 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6413 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6415 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6417 * textprop.c (text_property_stickiness):
6418 Obey Vtext_property_default_nonsticky.
6419 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6420 * w32fns.c (syms_of_w32fns):
6421 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6423 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6425 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6426 This is more efficient than Ffile_directory_p and avoids a minor race.
6428 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6430 * buffer.c (Foverlay_put): Say what the return value is
6433 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6434 is a directory before asking whether to use the file name
6436 (barf_or_query_if_file_exists): Make the "File is a directory"
6437 error be more correct.
6439 * fns.c (Frequire): Remove the mention of the .gz files, since
6440 that's installation-specific, but keep the mention of
6441 `get-load-suffixes'.
6443 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6445 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6446 Report string overflow if the output is too long.
6448 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6450 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6451 (syms_of_gnutls): Remove duplicate DEFSYM for
6452 Qgnutls_bootprop_verify_hostname_error, an error for
6453 Qgnutls_bootprop_verify_error (which is no longer used).
6455 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6456 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6457 Also (re)move comments that are misplaced or no longer relevant.
6459 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6461 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6463 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6465 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6466 and background color parameters if they have been changed.
6468 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6470 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6472 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6474 * xsettings.c (SYSTEM_FONT): Define only when used.
6475 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6477 * keymap.c (access_keymap_1): Now static.
6479 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6481 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6482 leave any prefix arg for the up event (Bug#1586).
6484 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6486 * lread.c (syms_of_lread): Mention single symbols defined by
6487 `defvar' or `defconst' (bug#7154).
6489 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6490 (Frequire): Mention get-load-suffixes.
6492 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6494 * window.h (window): Remove clone_number slot.
6495 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6497 (make_parent_window, make_window, saved_window)
6498 (Fset_window_configuration, save_window_save): Don't deal with
6500 * buffer.c (Qclone_number): Remove declaration.
6501 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6503 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6505 Add multiple inheritance to keymaps.
6506 * keymap.c (Fmake_composed_keymap): New function.
6507 (Fset_keymap_parent): Simplify.
6508 (fix_submap_inheritance): Remove.
6509 (access_keymap_1): New function extracted from access_keymap to handle
6510 embedded parents and handle lists of maps.
6511 (access_keymap): Use it.
6512 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6513 (Fcopy_keymap): Handle embedded parents.
6514 (Fcommand_remapping, define_as_prefix): Simplify.
6515 (Fkey_binding): Simplify.
6516 (syms_of_keymap): Move minibuffer-local-completion-map,
6517 minibuffer-local-filename-completion-map,
6518 minibuffer-local-must-match-map, and
6519 minibuffer-local-filename-must-match-map to Elisp.
6520 (syms_of_keymap): Defsubr make-composed-keymap.
6521 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6522 (parse_menu_item): Trivial simplification.
6524 2011-07-01 Glenn Morris <rgm@gnu.org>
6526 * Makefile.in (SETTINGS_LIBS): Fix typo.
6528 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6530 * coding.c (Fencode_coding_string): Record the last coding system
6531 used, as the function doc string says (bug#8738).
6533 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6535 * xsettings.c (store_monospaced_changed): Take new font as arg and
6536 check for change against current_mono_font.
6537 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6538 (emacs_settings_constructor, emacs_settings_get_property)
6539 (emacs_settings_set_property, emacs_settings_class_init)
6540 (emacs_settings_init, gsettings_obj): Remove.
6541 (something_changedCB): New function for HAVE_GSETTINGS.
6542 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6543 with value as argument.
6544 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6545 g_settings_new (Bug#8967). Do not create gsettings_obj.
6546 Remove calls to g_settings_bind. Connect something_changedCB to
6549 * xgselect.c: Add defined (HAVE_GSETTINGS).
6550 (xgselect_initialize): Ditto.
6552 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6553 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6556 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6558 * eval.c (struct backtrace): Simplify and port the data structure.
6559 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6560 signed bit field, as this assumption is not portable and it makes
6561 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6562 "char debug_on_exit : 1" as this is not portable either; instead,
6563 use the portable "unsigned int debug_on_exit : 1". Remove unused
6564 member evalargs. Remove obsolete comments about cc bombing out.
6566 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6568 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6569 Let HAVE_GSETTINGS override HAVE_GCONF.
6570 (store_monospaced_changed): New function.
6571 (EMACS_SETTINGS): A new type derived from GObject to handle
6572 GSettings notifications.
6573 (emacs_settings_constructor, emacs_settings_get_property)
6574 (emacs_settings_set_property, emacs_settings_class_init):
6576 (gsettings_client, gsettings_obj): New variables.
6577 (GSETTINGS_SCHEMA): New define.
6578 (something_changedCB): Call store_monospaced_changed.
6579 (init_gsettings): New function.
6580 (xsettings_initialize): Call init_gsettings.
6581 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6584 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6587 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6589 * window.c (resize_root_window, grow_mini_window)
6590 (shrink_mini_window): Rename Qresize_root_window to
6591 Qwindow_resize_root_window and Qresize_root_window_vertically to
6592 Qwindow_resize_root_window_vertically.
6594 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6596 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6598 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6600 * makefile.w32-in: Redesign dependencies so they reflect more
6601 clearly which files are directly included by each source file,
6602 and not through other includes.
6604 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6606 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6607 (sort_overlays, overlay_strings): When an overlay's clone number
6608 matches the window's clone number process the overlay even if
6609 the overlay's window property doesn't match the current window.
6611 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6612 (Fwindow_hchild): Rename to Fwindow_left_child.
6613 (Fwindow_next): Rename to Fwindow_next_sibling.
6614 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6615 (resize_window_check): Rename to window_resize_check.
6616 (resize_window_apply): Rename to window_resize_apply.
6617 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6618 (Fdelete_other_windows_internal, resize_frame_windows)
6619 (Fsplit_window_internal, Fdelete_window_internal)
6620 (grow_mini_window, shrink_mini_window)
6621 (Fresize_mini_window_internal): Fix callers accordingly.
6623 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6625 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6626 (emacs_fixed_set_min_size): Remove.
6627 (emacs_fixed_new): Take frame as argument.
6629 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6630 (_EmacsFixedPrivate): Remove minwidth/height.
6631 Add struct frame *f.
6632 (emacs_fixed_init): Initialize priv->f.
6633 (get_parent_class, emacs_fixed_set_min_size): Remove.
6634 (emacs_fixed_new): Set priv->f to argument.
6635 (emacs_fixed_get_preferred_width)
6636 (emacs_fixed_get_preferred_height): Use min_width/height from
6637 frames size_hint to set minimum and natural (Bug#8919).
6638 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6639 and use min_width/height from frames size_hint to set
6640 min_width/height (Bug#8919).
6642 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6643 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6646 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6648 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6649 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6652 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6654 * process.c (wait_reading_process_output): Bypass select if
6655 waiting for a cell while ignoring keyboard input, and input is
6656 pending. Suggested by Jan Djärv (Bug#8869).
6658 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6660 Use gnulib's dup2 module instead of rolling our own.
6661 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6663 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6665 * dispnew.c (scrolling_window): Before scrolling, turn off a
6666 mouse-highlight in the window being scrolled.
6668 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6670 Move DEFSYM to lisp.h and use everywhere.
6672 * character.h (DEFSYM): Move declaration...
6673 * lisp.h (DEFSYM): ...here.
6679 * w32select.c: Don't include character.h.
6681 * alloc.c (syms_of_alloc):
6682 * buffer.c (syms_of_buffer):
6683 * bytecode.c (syms_of_bytecode):
6684 * callint.c (syms_of_callint):
6685 * casefiddle.c (syms_of_casefiddle):
6686 * casetab.c (init_casetab_once):
6687 * category.c (init_category_once, syms_of_category):
6688 * ccl.c (syms_of_ccl):
6689 * cmds.c (syms_of_cmds):
6690 * composite.c (syms_of_composite):
6691 * dbusbind.c (syms_of_dbusbind):
6692 * dired.c (syms_of_dired):
6693 * dispnew.c (syms_of_display):
6694 * doc.c (syms_of_doc):
6695 * editfns.c (syms_of_editfns):
6696 * emacs.c (syms_of_emacs):
6697 * eval.c (syms_of_eval):
6698 * fileio.c (syms_of_fileio):
6699 * fns.c (syms_of_fns):
6700 * frame.c (syms_of_frame):
6701 * fringe.c (syms_of_fringe):
6702 * insdel.c (syms_of_insdel):
6703 * keymap.c (syms_of_keymap):
6704 * lread.c (init_obarray, syms_of_lread):
6705 * macros.c (syms_of_macros):
6706 * msdos.c (syms_of_msdos):
6707 * print.c (syms_of_print):
6708 * process.c (syms_of_process):
6709 * search.c (syms_of_search):
6710 * sound.c (syms_of_sound):
6711 * syntax.c (init_syntax_once, syms_of_syntax):
6712 * terminal.c (syms_of_terminal):
6713 * textprop.c (syms_of_textprop):
6714 * undo.c (syms_of_undo):
6715 * w32.c (globals_of_w32):
6716 * window.c (syms_of_window):
6717 * xdisp.c (syms_of_xdisp):
6718 * xfaces.c (syms_of_xfaces):
6719 * xfns.c (syms_of_xfns):
6720 * xmenu.c (syms_of_xmenu):
6721 * xsettings.c (syms_of_xsettings):
6722 * xterm.c (syms_of_xterm): Use DEFSYM.
6724 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6726 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6728 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6730 Integer and buffer overflow fixes (Bug#8873).
6732 * print.c (printchar, strout): Check for string overflow.
6733 (PRINTPREPARE, printchar, strout):
6734 Don't set size unless allocation succeeds.
6736 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6737 for sizes. Check for string overflow more accurately.
6738 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6740 * macros.c: Integer and buffer overflow fixes.
6741 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6742 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6743 Use ptrdiff_t, not int, for sizes.
6744 Don't increment bufsize until after realloc succeeds.
6745 Check for size-calculation overflow.
6746 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6748 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6750 * lread.c: Integer overflow fixes.
6751 (read_integer): Radix is now EMACS_INT, not int,
6752 to improve quality of diagnostics for out-of-range radices.
6753 Calculate buffer size correctly for out-of-range radices.
6754 (read1): Check for integer overflow in radices, and in
6755 read-circle numbers.
6756 (read_escape): Avoid int overflow.
6757 (Fload, openp, read_buffer_size, read1)
6758 (substitute_object_recurse, read_vector, read_list, map_obarray):
6759 Use ptrdiff_t, not int, for sizes.
6760 (read1): Use EMACS_INT, not int, for sizes.
6761 Check for size overflow.
6763 * image.c (cache_image): Check for size arithmetic overflow.
6765 * lread.c: Integer overflow issues.
6766 (saved_doc_string_size, saved_doc_string_length)
6767 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6768 Now ptrdiff_t, not int.
6769 (read1): Don't assume doc string length fits in int. Check for
6770 out-of-range doc string lengths.
6771 (read_list): Don't assume file position fits in int.
6772 (read_escape): Check for hex character overflow.
6774 2011-06-22 Leo Liu <sdl.web@gmail.com>
6776 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6777 Move to minibuffer.el.
6779 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6781 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6782 The following patches are for when GLYPH_DEBUG && !XASSERT.
6783 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6784 * dispnew.c (flush_stdout):
6785 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6786 Mark as externally visible.
6787 * dispnew.c (check_window_matrix_pointers): Now static.
6788 * dispnew.c (window_to_frame_vpos):
6789 * xfns.c (unwind_create_frame):
6790 * xterm.c (x_check_font): Remove unused local.
6791 * scroll.c (CHECK_BOUNDS):
6792 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6793 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6794 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6795 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6796 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6798 (debug_method_add): Use va_list and vsprintf rather than relying
6799 on undefined behavior with wrong number of arguments.
6800 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6801 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6802 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6803 since we're not interested in debugging glyphs with old libraries.
6804 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6805 GCC 4.6.0's static checking.
6807 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6809 Integer overflow and signedness fixes (Bug#8873).
6810 A few related buffer overrun fixes, too.
6812 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6814 * dispextern.h (struct face.stipple):
6815 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6816 (x_bitmap_mask, x_allocate_bitmap_record)
6817 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6818 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6819 (x_create_bitmap_from_xpm_data):
6820 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6821 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6823 * xfaces.c (load_pixmap):
6824 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6825 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6826 (.bitmaps_last, struct x_output.icon_bitmap):
6827 Use ptrdiff_t, not int, for bitmap indexes.
6828 (x_allocate_bitmap_record): Check for size overflow.
6829 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6831 Use ptrdiff_t, not int, for overlay counts.
6832 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6833 * editfns.c (overlays_around, get_pos_property):
6834 * textprop.c (get_char_property_and_overlay):
6835 * xdisp.c (next_overlay_change, note_mouse_highlight):
6836 * xfaces.c (face_at_buffer_position):
6837 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6838 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6839 (Fnext_overlay_change, Fprevious_overlay_change)
6840 (mouse_face_overlay_overlaps, Foverlays_in):
6841 Use ptrdiff_t, not int, for sizes.
6842 (overlays_at, overlays_in): Check for size-calculation overflow.
6844 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6846 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6847 (x_session_initialize): Do not assume string length fits in int.
6849 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6850 This is unlikely, but can occur if DPI is outlandish.
6852 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6853 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6855 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6856 * xrdb.c (magic_file_p, search_magic_path):
6857 Omit last arg SUFFIX; it was always 0. All callers changed.
6858 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6860 * xfont.c (xfont_match): Avoid need for strlen.
6862 * xfns.c: Don't assume strlen fits in int.
6863 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6865 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6866 not unsigned long, as we prefer signed integers. All callers changed.
6867 Detect integer overflow in repeat count.
6868 (message_dolog): Don't assume print length fits in 39 bytes.
6869 (display_mode_element): Don't assume strlen fits in int.
6871 * termcap.c: Don't assume sizes fit in int and never overflow.
6872 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6873 (gobble_line): Check for size-calculation overflow.
6875 * minibuf.c (Fread_buffer):
6876 * lread.c (intern, intern_c_string):
6877 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6878 Don't assume string length fits in int.
6880 * keyboard.c (parse_tool_bar_item):
6881 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6883 * font.c: Don't assume string length fits in int.
6884 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6885 Use ptrdiff_t, not int.
6886 (font_intern_prop): Don't assume string length fits in int.
6887 Don't assume integer property fits in fixnum.
6888 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6890 * filelock.c: Fix some buffer overrun and integer overflow issues.
6891 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6892 Reformulate so as not to need the command string.
6893 Invoke gzip -cd rather than gunzip, as it's more portable.
6894 (lock_info_type, lock_file_1, lock_file):
6895 Don't assume pid_t and time_t fit in unsigned long.
6896 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6897 (current_lock_owner): Prefer signed type for sizes.
6898 Use memcpy, not strncpy, where memcpy is what is really wanted.
6899 Don't assume (via atoi) that time_t and pid_t fit in int.
6900 Check for time_t and/or pid_t out of range, e.g., via a network share.
6901 Don't alloca where an auto var works fine.
6903 * fileio.c: Fix some integer overflow issues.
6904 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6905 Don't assume string length fits in int.
6906 (directory_file_name): Don't assume string length fits in long.
6907 (make_temp_name): Don't assume pid fits in int, or that its print
6908 length is less than 20.
6910 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6912 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6914 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6916 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6917 We prefer signed integers, even for size calculations.
6919 * emacs.c: Don't assume string length fits in 'int'.
6920 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6921 (main): Don't invoke strlen when not needed.
6923 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6924 (XD_DEBUG_MESSAGE): Don't waste a byte.
6926 * callproc.c (getenv_internal_1, getenv_internal)
6928 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6930 * lread.c (invalid_syntax): Omit length argument.
6931 All uses changed. This doesn't fix a bug, but it simplifies the
6932 code away from its former Hollerith-constant appearance, and it's
6933 one less 'int' to worry about when looking at integer-overflow issues.
6934 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6936 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6937 This didn't break anything, but it didn't help either.
6938 It's confusing to put a bogus integer in a place where the actual
6939 value does not matter.
6940 (LIST_END_P): Remove unused macro and its bogus comment.
6941 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6943 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6944 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6946 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6947 We prefer signed types, and the value cannot exceed the EMACS_INT
6948 range anyway (because otherwise the length would not be representable).
6949 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6950 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6951 This avoids a GCC warning when WIDE_EMACS_INT.
6953 * indent.c (sane_tab_width): New function.
6954 (current_column, scan_for_column, Findent_to, position_indentation)
6955 (compute_motion): Use it. This is just for clarity.
6956 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6958 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6960 * lisp.h (lint_assume): New macro.
6961 * composite.c (composition_gstring_put_cache):
6962 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6964 * editfns.c, insdel.c:
6965 Omit unnecessary forward decls, to simplify future changes.
6967 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6969 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6971 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6972 Use much-faster test for byte-length change.
6973 Don't assume string byte-length fits in 'int'.
6974 Check that character arg fits in 'int'.
6975 (mapcar1): Declare byte as byte, for clarity.
6977 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6979 * fns.c (concat): Catch string overflow earlier.
6980 Do not rely on integer wraparound.
6982 * dispextern.h (struct it.overlay_strings_charpos)
6983 (struct it.selective): Now EMACS_INT, not int.
6984 * xdisp.c (forward_to_next_line_start)
6985 (back_to_previous_visible_line_start)
6986 (reseat_at_next_visible_line_start, next_element_from_buffer):
6987 Don't arbitrarily truncate the value of 'selective' to int.
6989 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6991 * composite.c: Don't truncate sizes to 'int'.
6992 (composition_gstring_p, composition_reseat_it)
6993 (composition_adjust_point): Use EMACS_INT, not int.
6994 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6995 not EMACS_UINT, for indexes.
6997 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6999 * buffer.c: Include <verify.h>.
7000 (struct sortvec.priority, struct sortstr.priority):
7001 Now EMACS_INT, not int.
7002 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7003 (struct sortstr.size, record_overlay_string)
7004 (struct sortstrlist.size, struct sortlist.used):
7005 Don't truncate size to int.
7006 (record_overlay_string): Check for size-calculation overflow.
7007 (init_buffer_once): Check at compile-time, not run-time.
7009 2011-06-22 Jim Meyering <meyering@redhat.com>
7011 Don't leak an XBM-image-sized buffer
7012 * image.c (xbm_load): Free the image buffer after using it.
7014 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7017 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7018 that Sun C diagnosed.
7019 * fns.c (secure_hash): Fix pointer signedness issue.
7020 * intervals.c (static_offset_intervals): New function.
7021 (offset_intervals): Use it.
7023 2011-06-21 Leo Liu <sdl.web@gmail.com>
7026 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7029 * fns.c (secure_hash): Rename from crypto_hash_function and change
7030 the first arg to accept symbols.
7031 (Fsecure_hash): New primitive.
7032 (syms_of_fns): New symbols.
7034 2011-06-20 Deniz Dogan <deniz@dogan.se>
7036 * process.c (Fset_process_buffer): Clarify return value in
7039 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7041 * dispnew.c (add_window_display_history): Use BVAR.
7043 * xdisp.c (debug_method_add): Use BVAR.
7044 (check_window_end, dump_glyph_matrix, dump_glyph)
7045 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7047 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7050 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7051 check till after the cache is created in init_frame_faces.
7053 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7055 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7057 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7059 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7060 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7061 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7063 Improve buffer-overflow checking (Bug#8873).
7064 * fileio.c (Finsert_file_contents):
7065 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7066 Remove the old (too-loose) buffer overflow checks.
7067 They weren't needed, since make_gap checks for buffer overflow.
7068 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7069 The old code merely checked for Emacs fixnum overflow, and relied
7070 on undefined (wraparound) behavior. The new code avoids undefined
7071 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7073 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7074 Tune. Don't use wider integers than needed. Don't use alloca.
7075 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7077 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7079 * insdel.c, lisp.h (buffer_overflow): New function.
7080 (insert_from_buffer_1, replace_range, replace_range_2):
7081 * insdel.c (make_gap_larger):
7082 * editfns.c (Finsert_char):
7083 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7085 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7087 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7089 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7091 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7092 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7094 * fileio.c: Don't assume EMACS_INT fits in off_t.
7095 (emacs_lseek): New static function.
7096 (Finsert_file_contents, Fwrite_region): Use it.
7097 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7099 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7101 * fns.c: Don't overflow int when computing a list length.
7102 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7103 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7104 truncation on 64-bit hosts. Check for QUIT every
7105 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7106 faster and is responsive enough.
7107 (Flength): Report an error instead of overflowing an integer.
7108 (Fsafe_length): Return a float if the value is not representable
7109 as a fixnum. This shouldn't happen except in contrived situations.
7110 (Fnthcdr, Fsort): Don't assume list length fits in int.
7111 (Fcopy_sequence): Don't assume vector length fits in int.
7113 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7114 (header_size, word_size): New constants.
7115 (allocate_vectorlike): Don't check size overflow here.
7116 (allocate_vector): Check it here instead, since this is the only
7117 caller of allocate_vectorlike that could cause overflow.
7118 Check that the new vector's length is representable as a fixnum.
7120 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7121 The previous code was bogus. For example, next_almost_prime (32)
7122 returned 39, which is undesirable as it is a multiple of 3; and
7123 next_almost_prime (24) returned 25, which is a multiple of 5 so
7124 why was the code bothering to check for multiples of 7?
7126 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7128 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7130 Variadic C functions now count arguments with ptrdiff_t.
7131 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7132 Back then I didn't know that the Emacs coding style prefers signed int.
7133 Also, in the meantime I found a few more instances where arguments
7134 were being counted with int, which may truncate counts on 64-bit
7135 machines, or EMACS_INT, which may be unnecessarily wide.
7136 * lisp.h (struct Lisp_Subr.function.aMANY)
7137 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7138 Arg counts are now ptrdiff_t, not size_t.
7139 All variadic functions and their callers changed accordingly.
7140 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7141 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7142 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7143 * callint.c (Fcall_interactively): Check arg count for overflow,
7144 to avoid potential buffer overrun. Use signed char, not 'int',
7145 for 'varies' array, so that we needn't bother to check its size
7146 calculation for overflow.
7147 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7148 * eval.c (apply_lambda):
7149 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7150 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7151 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7153 * callint.c (Fcall_interactively): Don't use index var as event count.
7155 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7156 * mem-limits.h (SIZE): Remove; no longer used.
7158 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7160 Remove unnecessary casts.
7161 * xterm.c (x_term_init):
7162 * xfns.c (x_set_border_pixel):
7163 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7164 These aren't needed now that we assume ANSI C.
7166 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7167 It's more likely to cause problems (due to unsigned overflow)
7170 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7172 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7174 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7176 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7178 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7180 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7182 GLYPH_CODE_FACE returns EMACS_INT, not int.
7183 * dispextern.h (merge_faces):
7184 * xfaces.c (merge_faces):
7185 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7186 Don't assume EMACS_INT fits in int.
7188 * character.h (CHAR_VALID_P): Remove unused parameter.
7189 * fontset.c, lisp.h, xdisp.c: All uses changed.
7191 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7193 * fns.c (concat): Minor tuning based on overflow analysis.
7194 This doesn't fix any bugs. Use int to hold character, instead
7195 of constantly refetching from Emacs object. Use XFASTINT, not
7196 XINT, for value known to be a character. Don't bother comparing
7197 a single byte to 0400, as it's always less.
7199 * floatfns.c (Fexpt):
7200 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7202 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7205 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7207 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7208 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7209 incorrectly succeed when S was a string, because 4294967386 was
7210 truncated before it was used.
7212 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7213 Otherwise, an out-of-range integer could cause undefined behavior
7216 * composite.c: Use int, not EMACS_INT, for characters.
7217 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7218 EMACS_INT, for values that are known to be in character range.
7219 This doesn't fix any bugs but is the usual style inside Emacs and
7220 may generate better code on 32-bit machines.
7222 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7223 This is for reasons similar to the recent CHAR_STRING fix.
7224 * charset.c (Fencode_char): Check that character arg is actually
7225 a character. Pass an int to ENCODE_CHAR.
7226 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7227 wider than 'int', as a compile-time check to prevent future regressions
7230 * character.c (char_string): Remove unnecessary casts.
7232 Make sure a 64-bit char is never passed to CHAR_STRING.
7233 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7234 by silently ignoring the top 32 bits, allowing some values
7235 that were far too large to be valid characters.
7236 * character.h: Include <verify.h>.
7237 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7238 arguments are no wider than unsigned, as a compile-time check
7239 to prevent future regressions in this area.
7241 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7242 (Fsubst_char_in_region):
7244 * xdisp.c (decode_mode_spec_coding):
7245 Adjust to CHAR_STRING's new requirement.
7246 * editfns.c (Finsert_char, Fsubst_char_in_region):
7247 * fns.c (concat): Check that character args are actually
7248 characters. Without this test, these functions did the wrong
7249 thing with wildly out-of-range values on 64-bit hosts.
7251 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7252 These casts should not be needed on 32-bit hosts, either.
7253 * keyboard.c (read_char):
7254 * lread.c (Fload): Remove casts to unsigned.
7256 * lisp.h (UNSIGNED_CMP): New macro.
7257 This fixes comparison bugs on 64-bit hosts.
7258 (ASCII_CHAR_P): Use it.
7259 * casefiddle.c (casify_object):
7260 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7261 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7262 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7263 * dispextern.h (FACE_FROM_ID):
7264 * keyboard.c (read_char): Use UNSIGNED_CMP.
7266 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7267 not to EMACS_INT, to avoid GCC warning.
7269 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7271 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7272 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7273 isn't needed on 32-bit machines.
7275 * buffer.c (Fgenerate_new_buffer_name):
7276 Use EMACS_INT for count, not int.
7277 (advance_to_char_boundary): Return EMACS_INT, not int.
7279 * data.c (Qcompiled_function): Now static.
7281 * window.c (window_body_lines): Now static.
7283 * image.c (gif_load): Rename local to avoid shadowing.
7285 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7286 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7287 * alloc.c (make_save_value): Integer argument is now of type
7289 (mark_object): Use ptrdiff_t, not int.
7290 * lisp.h (pD): New macro.
7291 * print.c (print_object): Use it.
7293 * alloc.c: Use EMACS_INT, not int, to count objects.
7294 (total_conses, total_markers, total_symbols, total_vector_size)
7295 (total_free_conses, total_free_markers, total_free_symbols)
7296 (total_free_floats, total_floats, total_free_intervals)
7297 (total_intervals, total_strings, total_free_strings):
7298 Now EMACS_INT, not int. All uses changed.
7299 (Fgarbage_collect): Compute overall total using a double, so that
7300 integer overflow is less likely to be a problem. Check for overflow
7301 when converting back to an integer.
7302 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7303 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7304 These were 'int' variables that could overflow on 64-bit hosts;
7305 they were never used, so remove them instead of repairing them.
7306 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7307 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7308 Previously, this ceilinged at INT_MAX, but that doesn't work on
7310 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7312 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7313 (allocate_vectorlike): Check for ptrdiff_t overflow.
7314 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7315 when a (possibly-narrower) signed value would do just as well.
7316 We prefer using signed arithmetic, to avoid comparison confusion.
7318 * alloc.c: Catch some string size overflows that we were missing.
7319 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7320 for convenience in STRING_BYTES_MAX.
7321 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7322 The definition here is exact; the one in lisp.h was approximate.
7323 (allocate_string_data): Check for string overflow. This catches
7324 some instances we weren't catching before. Also, it catches
7325 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7326 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7327 and ptrdiff_t and EMACS_INT are both 64 bits.
7329 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7330 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7331 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7333 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7335 * alloc.c (Fmake_string): Check for out-of-range init.
7337 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7339 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7341 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7343 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7344 xg_get_default_scrollbar_width.
7346 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7347 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7348 (style_changed_cb): Call update_theme_scrollbar_width and call
7349 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7350 all frames (Bug#8505).
7351 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7352 Call gtk_window_set_resizable if HAVE_GTK3.
7353 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7354 and height if HAVE_GTK3 (Bug#8505).
7355 (scroll_bar_width_for_theme): New variable.
7356 (update_theme_scrollbar_width): New function.
7357 (xg_get_default_scrollbar_width): Move code to
7358 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7359 (xg_initialize): Call update_theme_scrollbar_width.
7361 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7363 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7365 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7367 * frame.c (make_frame): Call other_buffer_safely instead of
7370 * window.c (temp_output_buffer_show): Call display_buffer with
7371 second argument Vtemp_buffer_show_specifiers and reset latter
7372 immediately after the call.
7373 (Vtemp_buffer_show_specifiers): New variable.
7374 (auto_window_vscroll_p, next_screen_context_lines)
7375 (Vscroll_preserve_screen_position): Remove leading asterisks from
7378 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7380 Fix minor problems found by GCC 4.6.0 static checking.
7381 * buffer.c (Qclone_number): Remove for now, as it's unused.
7382 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7383 (record_buffer): Remove unused local.
7384 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7385 (set_frame_buffer_list): Remove; unused.
7386 * frame.h (other_visible_frames): Remove decl.
7387 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7388 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7389 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7391 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7392 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7393 Define only if HAVE_GPM.
7394 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7395 (update_hints_inhibit): Remove; never set. All uses removed.
7396 * widgetprv.h (emacsFrameClassRec): Remove decl.
7397 * window.c (delete_deletable_window): Now returns void, since it
7398 wasn't returning anything.
7399 (compare_window_configurations): Remove unused locals.
7400 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7401 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7402 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7403 the same widths as pointers. This follows up on the 2011-05-06 patch.
7404 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7405 * xterm.h: Likewise.
7406 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7408 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7410 * makefile.w32-in: Update dependencies.
7411 (LISP_H): Add lib/intprops.h.
7413 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7415 * image.c (gif_load): Add animation frame delay to the metadata.
7416 (syms_of_image): Use DEFSYM. New symbol `delay'.
7418 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7420 * window.c (delete_deletable_window): Re-add.
7421 (Fset_window_configuration): Rewrite to handle dead buffers and
7422 consequently deletable windows.
7423 (window_tree, Fwindow_tree): Remove. Supply functionality in
7425 (compare_window_configurations): Simplify code.
7427 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7429 * image.c (imagemagick_load_image): Fix type mismatch.
7430 (Fimagemagick_types): Likewise.
7432 * window.h (replace_buffer_in_windows): Declare.
7434 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7436 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7437 Qclone_number. Remove external declaration of Qdelete_window.
7438 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7440 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7441 Run Qbuffer_list_update_hook if allowed.
7442 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7443 buffer list implementation.
7444 (other_buffer_safely): New function.
7445 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7446 calls to replace_buffer_in_windows and
7447 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7449 (record_buffer): Inhibit quitting and rewrite using quittable
7450 functions. Run Qbuffer_list_update_hook if allowed.
7451 (Frecord_buffer, Funrecord_buffer): New functions.
7452 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7453 Move switch-to-buffer to window.el.
7454 (bury-buffer): Move to window.el.
7455 (Vbuffer_list_update_hook): New variable.
7457 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7460 * window.h (resize_frame_windows): Move up in code.
7461 (Fwindow_frame): Remove EXFUN.
7462 (replace_buffer_in_all_windows): Remove prototype.
7463 (replace_buffer_in_windows_safely): Add prototype.
7465 * window.c: Declare Qdelete_window static again. Move down
7466 declaration of select_count.
7467 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7468 (Fother_window): Move to window.el.
7469 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7470 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7471 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7473 (replace_buffer_in_windows): Implement by calling
7474 Qreplace_buffer_in_windows.
7475 (replace_buffer_in_all_windows): Remove with some functionality
7476 moved into replace_buffer_in_windows_safely.
7477 (replace_buffer_in_windows_safely): New function.
7478 (select_window_norecord, select_frame_norecord): Move in front
7479 of run_window_configuration_change_hook. Remove now obsolete
7481 (Fset_window_buffer): Rewrite doc-string.
7482 Call Qrecord_window_buffer.
7483 (keys_of_window): Move binding for other-window to window.el.
7485 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7487 * dispextern.h (struct image): Replace data member, whose int_val
7488 and ptr_val fields were not used by anything, with a single
7491 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7492 (gif_clear_image, gif_load, imagemagick_load_image)
7493 (gs_clear_image, gs_load): Callers changed.
7495 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7497 * buffer.h: Include <time.h>, for time_t.
7498 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7500 Fix minor problems found by static checking.
7502 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7504 Make identifiers static if they are not used in other modules.
7505 * data.c (Qcompiled_function, Qframe, Qvector):
7506 * image.c (QimageMagick, Qsvg):
7507 * minibuf.c (Qmetadata):
7508 * window.c (resize_window_check, resize_root_window): Now static.
7509 * window.h (resize_window_check, resize_root_window): Remove decls.
7511 * window.c (window_deletion_count, delete_deletable_window):
7513 (window_body_lines): Now static.
7514 (Fdelete_other_windows_internal): Mark vars as initialized.
7515 Make sure 'resize_failed' is initialized.
7516 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7517 (resize_window_apply): Remove unused local.
7518 * window.h (delete_deletable_window): Remove decl.
7520 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7521 (imagemagick_load_image): Fix pointer signedness problem by changing
7522 last arg from unsigned char * to char *. All uses changed.
7523 Also, fix a local for similar reasons.
7524 Remove unused locals. Remove locals to avoid shadowing.
7525 (fn_rsvg_handle_free): Remove; unused.
7526 (svg_load, svg_load_image): Fix pointer signedness problem.
7527 (imagemagick_load_image): Don't use garbage pointer image_wand.
7529 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7531 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7533 * image.c (gif_load): Fix omitted cast error introduced by
7536 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7538 * window.h (resize_proportionally, orig_total_lines)
7539 (orig_top_line): Remove from window structure.
7540 (set_window_height, set_window_width, change_window_heights)
7541 (Fdelete_window): Remove prototypes.
7542 (resize_frame_windows): Remove duplicate declaration.
7544 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7546 * window.h (resize_frame_windows, resize_window_check)
7547 (delete_deletable_window, resize_root_window)
7548 (resize_frame_windows): Declare prototypes.
7550 * window.c (resize_window_apply): Make definition be "static" to
7551 match the prototype.
7553 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7555 * window.c: Remove declarations of Qwindow_size_fixed,
7556 window_min_size_1, window_min_size_2, window_min_size,
7557 size_window, window_fixed_size_p, enlarge_window, delete_window.
7558 Remove static from declaration of Qdelete_window, it's
7559 temporarily needed by Fbury_buffer.
7560 (replace_window): Don't assign orig_top_line and
7562 (Fdelete_window, delete_window): Remove. Window deletion is
7563 handled by window.el.
7564 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7565 Replace Fdelete_window calls with calls to Qdelete_window.
7566 (Fdelete_other_windows): Remove. Deleting other windows is
7567 handled by window.el.
7568 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7569 handled in window.el.
7570 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7571 Window minimum sizes are handled in window.el.
7572 (shrink_windows, size_window, set_window_height)
7573 (set_window_width, change_window_heights, window_height)
7574 (window_width, CURBEG, CURSIZE, enlarge_window)
7575 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7576 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7577 handled in window.el.
7578 (make_dummy_parent): Rename to make_parent_window and give it a
7579 second argument horflag.
7580 (make_window): Don't set resize_proportionally any more.
7581 (Fsplit_window): Remove. Windows are split in window.el.
7582 (save_restore_action, save_restore_orig_size)
7583 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7584 Resize mini windows in window.el.
7585 (grow_mini_window, shrink_mini_window): Implement by calling
7586 Qresize_root_window_vertically, resize_window_check and
7587 resize_window_apply.
7588 (saved_window, Fset_window_configuration, save_window_save):
7589 Do not handle orig_top_line, orig_total_lines, and
7590 resize_proportionally.
7591 (window_min_height, window_min_width): Move to window.el.
7592 (keys_of_window): Move bindings for delete-other-windows,
7593 split-window, delete-window and enlarge-window to window.el.
7595 * buffer.c: Temporarily extern Qdelete_window.
7596 (Fbury_buffer): Temporarily call Qdelete_window instead of
7597 Fdelete_window (Fbury_buffer will move to window.el soon).
7599 * frame.c (set_menu_bar_lines_1): Remove code handling
7600 orig_top_line and orig_total_lines.
7602 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7603 set_window_height but set heights directly.
7604 (change_frame_size_1): Use resize_frame_windows.
7606 * xdisp.c (init_xdisp): Don't use set_window_height but set
7609 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7610 Use resize_frame_windows instead of change_window_heights and run
7611 run_window_configuration_change_hook.
7613 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7614 instead of change_window_heights and run
7615 run_window_configuration_change_hook.
7617 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7619 * window.c (replace_window): Rename second argument REPLACEMENT to
7620 NEW. New third argument SETFLAG. Rewrite.
7621 (delete_window, make_dummy_parent): Call replace_window with
7623 (window_list_1): Move down in code.
7624 (run_window_configuration_change_hook): Move set_buffer part
7625 before select_frame_norecord part in order to unwind correctly.
7626 Rename count1 to count.
7627 (recombine_windows, delete_deletable_window, resize_root_window)
7628 (Fdelete_other_windows_internal)
7629 (Frun_window_configuration_change_hook, make_parent_window)
7630 (resize_window_check, resize_window_apply, Fresize_window_apply)
7631 (resize_frame_windows, Fsplit_window_internal)
7632 (Fdelete_window_internal, Fresize_mini_window_internal):
7634 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7636 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7638 * window.h (window): Add some new members to window structure -
7639 normal_lines, normal_cols, new_total, new_normal, clone_number,
7640 splits, nest, prev_buffers, next_buffers.
7641 (WINDOW_TOTAL_SIZE): Move here from window.c.
7642 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7644 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7646 (make_dummy_parent): Set new members of windows structure.
7647 (make_window): Move down in code. Handle new members of window
7649 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7650 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7651 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7652 (Fset_window_prev_buffers, Fwindow_next_buffers)
7653 (Fset_window_next_buffers, Fset_window_clone_number):
7655 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7656 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7658 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7659 Argument WINDOW can be now internal window too.
7660 (Fwindow_use_time): Move up in code.
7661 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7663 (Fset_window_configuration, saved_window)
7664 (Fcurrent_window_configuration, save_window_save): Handle new
7665 members of window structure.
7666 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7667 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7668 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7669 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7670 Qget_mru_window, Qresize_root_window,
7671 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7672 Qauto_buffer_name; staticpro them.
7674 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7676 * window.c (Fwindow_total_size, Fwindow_left_column)
7677 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7678 (Fwindow_list_1): New functions.
7679 (window_box_text_cols): Replace with window_body_cols.
7680 (Fwindow_width, Fscroll_left, Fscroll_right):
7681 Use window_body_cols instead of window_box_text_cols.
7682 (delete_window, Fset_window_configuration):
7683 Call delete_all_subwindows with window as argument.
7684 (delete_all_subwindows): Take a window as argument and not a
7686 (window_loop): Remove handling of GET_LRU_WINDOW and
7688 (Fget_lru_window, Fget_largest_window): Move to window.el.
7690 * window.h: Extern window_body_cols instead of
7691 window_box_text_cols. delete_all_subwindows now takes a
7692 Lisp_Object as argument.
7694 * indent.c (compute_motion, Fcompute_motion):
7695 Use window_body_cols instead of window_box_text_cols.
7697 * frame.c (delete_frame): Call delete_all_subwindows with root
7700 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7702 * fns.c (Fputhash): Document return value.
7704 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7706 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7708 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7710 Cons<->int and similar integer overflow fixes (Bug#8794).
7712 Check for overflow when converting integer to cons and back.
7713 * charset.c (Fdefine_charset_internal, Fdecode_char):
7714 Use cons_to_unsigned to catch overflow.
7715 (Fencode_char): Use INTEGER_TO_CONS.
7716 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7717 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7718 * data.c (long_to_cons, cons_to_long): Remove.
7719 (cons_to_unsigned, cons_to_signed): New functions.
7720 These signal an error for invalid or out-of-range values.
7721 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7722 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7723 * font.c (Ffont_variation_glyphs):
7724 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7725 * lisp.h: Include <intprops.h>.
7726 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7727 (cons_to_signed, cons_to_unsigned): New decls.
7728 (long_to_cons, cons_to_long): Remove decls.
7729 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7730 (Fprimitive_undo): Use CONS_TO_INTEGER.
7731 * xfns.c (Fx_window_property): Likewise.
7732 * xselect.c: Include <limits.h>.
7733 (x_own_selection, selection_data_to_lisp_data):
7734 Use INTEGER_TO_CONS.
7735 (x_handle_selection_request, x_handle_selection_clear)
7736 (x_get_foreign_selection, Fx_disown_selection_internal)
7737 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7738 (lisp_data_to_selection_data): Use cons_to_unsigned.
7739 (x_fill_property_data): Use cons_to_signed.
7740 Report values out of range.
7742 Check for buffer and string overflow more precisely.
7743 * buffer.h (BUF_BYTES_MAX): New macro.
7744 * lisp.h (STRING_BYTES_MAX): New macro.
7745 * alloc.c (Fmake_string):
7746 * character.c (string_escape_byte8):
7747 * coding.c (coding_alloc_by_realloc):
7748 * doprnt.c (doprnt):
7749 * editfns.c (Fformat):
7751 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7752 since they may not be the same number.
7753 * editfns.c (Finsert_char):
7754 * fileio.c (Finsert_file_contents):
7755 Likewise for BUF_BYTES_MAX.
7757 * image.c: Use ptrdiff_t, not int, for sizes.
7758 (slurp_file): Switch from int to ptrdiff_t.
7760 (slurp_file): Check that file size fits in both size_t (for
7761 malloc) and ptrdiff_t (for sanity and safety).
7763 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7764 if b->modtime has its maximal value.
7766 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7768 Don't assume time_t can fit into int.
7769 * buffer.h (struct buffer.modtime): Now time_t, not int.
7770 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7771 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7773 Minor fixes for signed vs unsigned integers.
7774 * character.h (MAYBE_UNIFY_CHAR):
7775 * charset.c (maybe_unify_char):
7776 * keyboard.c (read_char, reorder_modifiers):
7777 XINT -> XFASTINT, since the integer must be nonnegative.
7778 * ftfont.c (ftfont_spec_pattern):
7779 * keymap.c (access_keymap, silly_event_symbol_error):
7780 XUINT -> XFASTINT, since the integer must be nonnegative.
7781 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7782 since it makes no difference and we prefer signed.
7783 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7784 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7787 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7789 * window.h (Fwindow_frame): Declare.
7791 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7793 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7794 (SPARE_MEMORY): Always define.
7795 (LARGE_REQUEST): Remove.
7796 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7798 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7800 * lisp.h: Move EXFUNS for Fframe_root_window,
7801 Fframe_first_window and Fset_frame_selected_window to window.h.
7803 * window.h: Move EXFUNS for Fframe_root_window,
7804 Fframe_first_window and Fset_frame_selected_window here from
7807 * frame.c (Fwindow_frame, Fframe_first_window)
7808 (Fframe_root_window, Fframe_selected_window)
7809 (Fset_frame_selected_window): Move to window.c.
7810 (Factive_minibuffer_window): Move to minibuf.c.
7811 (Fother_visible_frames_p): New function.
7813 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7815 * window.c (decode_window, decode_any_window): Move up in code.
7816 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7817 (inhibit_frame_unsplittable): Remove unused variable.
7818 (Fwindow_buffer): Move up and rewrite doc-string.
7819 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7820 (Fwindow_prev): New functions.
7821 (Fwindow_frame): Move here from frame.c. Accept any window as
7823 (Fframe_root_window, Fframe_first_window)
7824 (Fframe_selected_window): Move here from frame.c. Accept frame
7825 or arbitrary window as argument. Update doc-strings.
7826 (Fminibuffer_window): Move up in code.
7827 (Fwindow_minibuffer_p): Move up in code and simplify.
7828 (Fset_frame_selected_window): Move here from frame.c.
7830 (Fselected_window, select_window, Fselect_window): Move up in
7831 code. Minor doc-string fixes.
7833 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7835 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7836 Do not assume that spare memory exists; that assumption is valid
7837 only if SYSTEM_MALLOC.
7838 (LARGE_REQUEST): New macro, so that the issue of large requests
7839 is separated from the issue of spare memory.
7841 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7843 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7846 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7848 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7851 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7853 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7855 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7857 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7858 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7860 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7862 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7864 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7866 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7867 (x_clipboard_manager_save): Add return value.
7868 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7870 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7871 Obey Vx_select_enable_clipboard_manager. Catch errors in
7872 x_clipboard_manager_save (Bug#8779).
7873 (Vx_select_enable_clipboard_manager): New variable.
7874 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7876 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7878 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7880 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7882 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7883 in the current matrix if keep_current_p is non-zero.
7885 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7887 * bidi.c (bidi_level_of_next_char): Fix last change.
7889 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7891 Support bidi reordering of text covered by display properties.
7893 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7894 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7895 (bidi_cache_search, bidi_cache_iterator_state)
7896 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7897 (bidi_level_of_next_char, bidi_move_to_visually_next):
7898 Support character positions inside a run of characters covered by a
7900 (bidi_paragraph_init, bidi_resolve_explicit_1)
7901 (bidi_level_of_next_char): Call bidi_fetch_char and
7902 bidi_fetch_char_advance instead of FETCH_CHAR and
7904 (bidi_init_it): Initialize new members.
7905 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7907 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7908 instead of using explicit *_CHAR codes.
7909 (bidi_resolve_explicit, bidi_resolve_weak):
7910 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7911 bidirectional text is supported only in multibyte buffers.
7912 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7913 it to initialize the frame_window_p member of struct bidi_it.
7914 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7915 (bidi_resolve_explicit, bidi_resolve_weak)
7916 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7917 bidi_it->nchars is non-positive.
7918 (bidi_level_of_next_char): Don't try to lookup the cache for the
7919 next/previous character if nothing is cached there yet, or if we
7920 were just reseat()'ed to a new position.
7922 * xdisp.c (set_cursor_from_row): Set start and stop points
7923 according to the row's direction when priming the loop that looks
7924 for the glyph on which to display cursor.
7925 (single_display_spec_intangible_p): Function deleted.
7926 (display_prop_intangible_p): Reimplement to call
7927 handle_display_spec instead of single_display_spec_intangible_p.
7928 Accept 3 additional arguments needed by handle_display_spec.
7929 This fixes incorrect cursor motion across display property with complex
7930 values: lists, `(when COND...)' forms, etc.
7931 (single_display_spec_string_p): Support property values that are
7932 lists with the argument STRING its top-level element.
7933 (display_prop_string_p): Fix the condition for processing a
7934 property that is a list to be consistent with handle_display_spec.
7935 (handle_display_spec): New function, refactored from the
7936 last portion of handle_display_prop.
7937 (compute_display_string_pos): Accept additional argument
7938 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7939 value of a `display' property is a "replacing spec".
7940 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7941 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7942 the display property, but just return a value indicating whether
7943 the display property will replace the characters it covers.
7944 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7945 frame_window_p members of struct bidi_it.
7946 (compute_display_string_pos, compute_display_string_end):
7948 (push_it): Accept second argument POSITION, where pop_it should
7949 jump to continue iteration.
7950 (reseat_1): Initialize bidi_it.disp_pos.
7952 * keyboard.c (adjust_point_for_property): Adjust the call to
7953 display_prop_intangible_p to its new signature.
7955 * dispextern.h (struct bidi_it): New member frame_window_p.
7956 (bidi_init_it): Update prototypes.
7957 (display_prop_intangible_p): Update prototype.
7958 (compute_display_string_pos, compute_display_string_end):
7960 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7963 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7965 Malloc failure behavior now depends on size of allocation.
7966 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7967 * lisp.h: Change signatures accordingly.
7968 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7969 All callers changed. (Bug#8762)
7971 * gnutls.c: Use Emacs's memory allocators.
7972 Without this change, the gnutls library would invoke malloc etc.
7973 directly, which causes problems on non-SYNC_INPUT hosts, and which
7974 runs afoul of improving memory_full behavior. (Bug#8761)
7975 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7976 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7977 xfree instead of the default malloc, realloc, free.
7978 (Fgnutls_boot): No need to check for memory allocation failure,
7979 since xmalloc does that for us.
7981 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7982 * category.c (hash_get_category_set):
7983 * ccl.c (ccl_driver):
7984 * charset.c (Fdefine_charset_internal):
7985 * charset.h (struct charset.hash_index):
7986 * composite.c (get_composition_id, gstring_lookup_cache)
7987 (composition_gstring_put_cache):
7988 * composite.h (struct composition.hash_index):
7989 * dispextern.h (struct image.hash):
7990 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7991 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7992 (hashfn_equal, hashfn_user_defined, make_hash_table)
7993 (maybe_resize_hash_table, hash_lookup, hash_put)
7994 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7995 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7996 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7997 * image.c (make_image, search_image_cache, lookup_image)
7998 (xpm_put_color_table_h):
7999 * lisp.h (struct Lisp_Hash_Table):
8000 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8001 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8002 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8003 * alloc.c (allocate_vectorlike):
8004 Check for overflow in vector size calculations.
8005 * ccl.c (ccl_driver):
8006 Check for overflow when converting EMACS_INT to int.
8007 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8008 need to be updated by these changes.
8009 * fns.c (make_hash_table, maybe_resize_hash_table):
8010 Check for integer overflow with large hash tables.
8011 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8012 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8013 (SXHASH_REDUCE): New macro.
8014 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8015 Use it instead of discarding useful hash info with large hash values.
8016 (sxhash_float): New function.
8017 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8018 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8019 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8020 Rewrite to use FIXNUM_BITS, as this simplifies things.
8021 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8022 Adjust signatures to match updated version of code.
8023 (consing_since_gc): Now EMACS_INT, since a single hash table can
8024 use more than INT_MAX bytes.
8026 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8028 Make it possible to build with GCC-4.6+ -O2 -flto.
8030 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8032 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8034 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8035 Call minibuffer-inactive-mode.
8037 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8039 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8040 Update dependencies.
8042 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8044 * data.c (init_data): Remove code for UTS, this system is not
8047 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8049 Don't force ./temacs to start in terminal mode.
8051 * frame.c (make_initial_frame): Initialize faces in all cases, not
8052 only when CANNOT_DUMP is defined.
8053 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8055 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8057 * dispnew.c (add_window_display_history): Use const for the string
8058 pointer. Remove declaration, not needed.
8060 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8062 Use 'inline', not 'INLINE'.
8063 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8064 * alloc.c, fontset.c (INLINE): Remove.
8065 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8066 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8067 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8068 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8069 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8071 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8073 Make it possible to run ./temacs.
8075 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8076 syms_of_callproc does the same thing. Remove test for
8077 "initialized", do it in the caller.
8078 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8080 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8082 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8083 (read_minibuf): Use get_minibuffer.
8084 (syms_of_minibuf): Use DEFSYM.
8085 (Qmetadata): New var.
8086 * data.c (Qbuffer): Don't make it static.
8087 (syms_of_data): Use DEFSYM.
8089 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8091 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8092 (CCL_CODE_MIN): New macro.
8094 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8096 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8098 * eval.c (Qdebug): Now static.
8099 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8100 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8101 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8103 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8105 * image.c: Various fixes to ImageMagick code comments.
8106 (Fimagemagick_types): Doc fix.
8108 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8110 Minor fixes prompted by GCC 4.6.0 warnings.
8112 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8114 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8115 (x_clipboard_manager_save_all): Move extern decl to ...
8116 * xterm.h: ... here, so that it can be checked for consistency.
8118 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8120 * xselect.c (x_clipboard_manager_save_frame)
8121 (x_clipboard_manager_save_all): New functions.
8122 (Fx_clipboard_manager_save): Lisp function deleted.
8124 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8125 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8127 * xterm.h: Update prototype.
8129 2011-05-28 William Xu <william.xwl@gmail.com>
8131 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8134 2011-05-28 Jim Meyering <meyering@redhat.com>
8136 Avoid a sign-extension bug in crypto_hash_function.
8137 * fns.c (to_uchar): Define.
8138 (crypto_hash_function): Use it to convert some newly-signed
8139 variables to unsigned, to avoid sign-extension bugs. For example,
8140 without this change, (md5 "truc") would evaluate to
8141 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8142 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8143 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8145 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8147 Integer overflow fixes.
8149 * dbusbind.c: Serial number integer overflow fixes.
8150 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8151 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8152 to hold a serial number that is too large for a fixnum.
8153 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8154 Check for serial numbers out of range. Decode any serial number
8155 that was so large that it became a float. (Bug#8722)
8157 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8158 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8159 Use XFASTINT rather than XUINT when numbers are nonnegative.
8160 (xd_append_arg, Fdbus_method_return_internal):
8161 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8162 arguments, check that Lisp number is nonnegative, rather than
8163 silently wrapping negative numbers around. (Bug#8722)
8164 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8167 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8169 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8171 ccl: Add integer overflow checks.
8172 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8173 (IN_INT_RANGE): New macros.
8174 (ccl_driver): Use them to check for integer overflow when
8175 decoding a CCL program. Many of the new checks are whether XINT (x)
8176 fits in int; it doesn't always, on 64-bit hosts. The new version
8177 doesn't catch all possible integer overflows, but it's an
8178 improvement. (Bug#8719)
8180 * alloc.c (make_event_array): Use XINT, not XUINT.
8181 There's no need for unsigned here.
8183 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8184 This follows up to the 2011-05-06 change that substituted uintptr_t
8185 for EMACS_INT. This case wasn't caught back then.
8187 Rework Fformat to avoid integer overflow issues.
8188 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8189 now (part of C89). Include <verify.h>.
8190 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8191 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8192 (Fformat): Avoid the prepass trying to compute sizes; it was only
8193 approximate and thus did not catch overflow reliably. Instead, walk
8194 through the format just once, formatting and computing sizes as we go,
8195 checking for integer overflow at every step, and allocating a larger
8196 buffer as needed. Keep track separately whether the format is
8197 multibyte. Keep only the most-recently calculated precision, rather
8198 than them all. Record whether each argument has been converted to
8199 string. Use EMACS_INT, not int, for byte and char and arg counts.
8200 Support field widths and precisions larger than INT_MAX. Avoid
8201 sprintf's undefined behavior with conversion specifications such as %#d
8202 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8203 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8204 formatting out-of-range floating point numbers with int
8207 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8209 * data.c: Avoid integer truncation in expressions involving floats.
8210 * data.c: Include <intprops.h>.
8211 (arith_driver): When there's an integer overflow in an expression
8212 involving floating point, convert the integers to floating point
8213 so that the resulting value does not suffer from catastrophic
8214 integer truncation. For example, on a 64-bit host (* 4
8215 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8216 Do not rely on undefined behavior after integer overflow.
8218 merge count_size_as_multibyte, parse_str_to_multibyte
8219 * character.c, character.h (count_size_as_multibyte):
8220 Rename from parse_str_to_multibyte; all uses changed.
8221 Check for integer overflow.
8222 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8223 since it's now a duplicate of the other. This is more of
8224 a character than a buffer op, so better that it's in character.c.
8225 * fns.c, print.c: Adjust to above changes.
8227 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8229 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8231 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8233 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8234 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8235 (x_clipboard_manager_save): Now static.
8236 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8238 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8239 (crypto_hash_function): Now static.
8240 Fix pointer signedness problems. Avoid unnecessary initializations.
8242 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8244 * termhooks.h (Vselection_alist): Make it terminal-local.
8246 * terminal.c (create_terminal): Initialize it.
8248 * xselect.c: Support for clipboard managers.
8249 (Vselection_alist): Move to termhooks.h as terminal-local var.
8250 (LOCAL_SELECTION): New macro.
8251 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8252 (symbol_to_x_atom): Remove gratuitous arg.
8253 (x_handle_selection_request, lisp_data_to_selection_data)
8254 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8255 (x_own_selection, x_get_local_selection, x_convert_selection):
8256 New arg, specifying work frame. Use terminal-local Vselection_alist.
8257 (some_frame_on_display): Delete unused function.
8258 (Fx_own_selection_internal, Fx_get_selection_internal)
8259 (Fx_disown_selection_internal, Fx_selection_owner_p)
8260 (Fx_selection_exists_p): New optional frame arg.
8261 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8262 (x_handle_selection_clear): Don't treat other terminals with the
8263 same keyboard specially. Use the terminal-local Vselection_alist.
8264 (x_clear_frame_selections): Use Frun_hook_with_args.
8266 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8268 * xterm.h: Add support for those atoms.
8270 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8272 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8273 (converted_selections, conversion_fail_tag): New global variables.
8274 (x_selection_request_lisp_error): Free the above.
8275 (x_get_local_selection): Remove unnecessary code.
8276 (x_reply_selection_request): Args changed; handle arbitrary array
8277 of converted selections stored in converted_selections.
8278 Separate the XChangeProperty and SelectionNotify steps.
8279 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8280 (x_convert_selection): New function.
8281 (x_handle_selection_event): Simplify.
8282 (x_get_foreign_selection): Don't ignore incoming requests while
8283 waiting for an answer; this will fail when we implement
8284 SAVE_TARGETS, and seems unnecessary anyway.
8285 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8286 (Vx_sent_selection_functions): Doc fix.
8288 2011-05-26 Leo Liu <sdl.web@gmail.com>
8290 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8292 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8294 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8296 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8297 for fringe update if it has periodic bitmap.
8298 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8299 and fringe_bitmap_periodic_p.
8301 * fringe.c (get_fringe_bitmap_data): New function.
8302 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8303 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8304 row. Mark glyph row for fringe update if periodicity changed.
8306 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8307 for fringe update unless it has periodic bitmap.
8309 2011-05-25 Kenichi Handa <handa@m17n.org>
8311 * xdisp.c (get_next_display_element): Set correct it->face_id for
8312 a static composition.
8314 2011-05-24 Leo Liu <sdl.web@gmail.com>
8317 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8319 * fns.c (crypto_hash_function, Fsha1): New function.
8320 (Fmd5): Use crypto_hash_function.
8321 (syms_of_fns): Add Ssha1.
8323 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8325 * gnutls.c: Remove unused macros.
8326 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8327 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8328 Remove macros that are defined and never used.
8329 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8331 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8333 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8334 (Fx_get_selection_internal): Minor cleanup.
8335 (Fx_own_selection_internal): Rename arguments for consistency with
8338 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8340 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8342 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8344 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8346 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8348 * dispnew.c (scrolling_window): Don't exclude the case that the
8349 last enabled row in the desired matrix touches the bottom boundary.
8351 2011-05-21 Glenn Morris <rgm@gnu.org>
8353 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8354 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8355 and add some more files.
8357 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8359 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8360 report_file_error introduced by the change from 2011-05-07.
8362 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8364 * systime.h (Time): Define only if emacs is defined.
8365 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8366 where the include path doesn't have X11/X.h by default. See
8367 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8369 2011-05-20 Kenichi Handa <handa@m17n.org>
8371 * composite.c (find_automatic_composition): Fix previous change.
8373 2011-05-20 Glenn Morris <rgm@gnu.org>
8375 * lisp.mk: New file, split from Makefile.in.
8376 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8377 (shortlisp): Remove.
8378 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8380 2011-05-19 Glenn Morris <rgm@gnu.org>
8382 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8383 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8384 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8385 (lisp): Set the order to that of loadup.el.
8386 (shortlisp): Make it a copy of $lisp.
8387 (SOME_MACHINE_LISP): Remove.
8388 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8389 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8391 2011-05-18 Kenichi Handa <handa@m17n.org>
8393 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8394 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8395 (find_automatic_composition): Mostly rewrite for efficiency.
8397 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8399 * makefile.w32-in: Update dependencies.
8401 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8403 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8404 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8406 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8408 Fix some integer overflow issues, such as string length overflow.
8410 * insdel.c (count_size_as_multibyte): Check for string overflow.
8412 * character.c (lisp_string_width): Check for string overflow.
8413 Use EMACS_INT, not int, for string indexes and lengths; in
8414 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8415 the resulting string length overflows an EMACS_INT; instead,
8416 report a string overflow if no precision given. When checking for
8417 precision exhaustion, use a check that cannot possibly have
8418 integer overflow. (Bug#8675)
8419 * character.h (lisp_string_width): Adjust to new signature.
8421 * alloc.c (string_overflow): New function.
8422 (Fmake_string): Use it. This doesn't change behavior, but saves
8423 a few bytes and will simplify future changes.
8424 * character.c (string_escape_byte8): Likewise.
8425 * lisp.h (string_overflow): New decl.
8427 Fixups, following up to the user-interface timestamp change.
8428 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8429 for UI timestamps, instead of unsigned long.
8430 * msdos.c (mouse_get_pos): Likewise.
8431 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8432 * w32gui.h (Time): Define by including "systime.h" rather than by
8433 declaring it ourselves. (Bug#8664)
8435 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8436 * image.c (clear_image_cache): Likewise.
8438 * term.c (term_mouse_position): Don't assume time_t wraparound.
8440 Be more systematic about user-interface timestamps.
8441 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8442 and sometimes 'EMACS_UINT', to represent these timestamps.
8443 This change causes it to use 'Time' uniformly, as that's what X uses.
8444 This makes the code easier to follow, and makes it easier to catch
8445 integer overflow bugs such as Bug#8664.
8446 * frame.c (Fmouse_position, Fmouse_pixel_position):
8447 Use Time, not unsigned long, for user-interface timestamps.
8448 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8449 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8450 * keyboard.h (last_event_timestamp): Likewise.
8451 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8452 * menu.h (xmenu_show): Likewise.
8453 * term.c (term_mouse_position): Likewise.
8454 * termhooks.h (struct input_event.timestamp): Likewise.
8455 (struct terminal.mouse_position_hook): Likewise.
8456 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8457 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8458 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8459 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8461 * menu.h, termhooks.h: Include "systime.h", for Time.
8463 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8464 Don't assume that the difference between two unsigned long values
8465 can fit into an integer. At this point, we know button_down_time
8466 <= event->timestamp, so the difference must be nonnegative, so
8467 there's no need to cast the result if double-click-time is
8468 nonnegative, as it should be; check that it's nonnegative, just in
8469 case. This bug is triggered when events are more than 2**31 ms
8470 apart (about 25 days). (Bug#8664)
8472 * xselect.c (last_event_timestamp): Remove duplicate decl.
8473 (x_own_selection): Remove needless cast to unsigned long.
8475 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8476 that always fit in int. Use a sentinel instead of a counter, to
8477 avoid a temp and to allay GCC's concerns about possible int overflow.
8478 * frame.h (struct frame): Use int for menu_bar_items_used
8479 instead of EMACS_INT, since it always fits in int.
8481 * menu.c (grow_menu_items): Check for int overflow.
8483 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8485 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8486 Before, the code was not consistent. These values cannot exceed
8487 2**31 - 1 so there's no need to make them unsigned.
8488 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8489 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8490 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8492 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8494 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8495 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8496 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8497 presumably because the widths might not match.
8499 * window.c (size_window): Avoid needless test at loop start.
8501 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8503 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8505 2011-05-12 Drew Adams <drew.adams@oracle.com>
8507 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8509 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8511 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8512 `width' to `bar_area_x' and `bar_area_width', respectively.
8513 (x_scroll_run): Take account of fringe background extension.
8515 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8516 Rename local vars `left' and `width' to `bar_area_x' and
8517 `bar_area_width', respectively.
8518 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8519 background extension.
8521 2011-05-10 Jim Meyering <meyering@redhat.com>
8523 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8525 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8527 * image.c (Finit_image_library): Return t for built-in image types,
8528 like pbm and xbm. (Bug#8640)
8530 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8532 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8534 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8536 * w32console.c (Fset_screen_color): Doc fix.
8537 (Fget_screen_color): New function.
8538 (syms_of_ntterm): Defsubr it.
8540 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8541 unlink the temporary file if Fcall_process didn't create it in the
8543 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8544 child process will be redirected to a file specified with `:file'.
8545 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8546 cue to call_process_cleanup not to close that handle.
8548 2011-05-07 Ben Key <bkey76@gmail.com>
8550 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8551 one of two shell specific rules, either bootstrap-temacs-CMD or
8552 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8553 to the previous implementation of the bootstrap-temacs rule.
8554 The bootstrap-temacs-CMD rule is similar to the previous
8555 implementation of the bootstrap-temacs rule except that it
8556 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8559 These changes, along with some changes to nt/configure.bat,
8560 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8561 earlier fix to add support for --cflags and --ldflags options
8562 that include quotes so that it works whether make uses cmd or
8565 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8567 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8568 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8570 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8571 a string. Handle both cases.
8572 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8573 (Fdbus_register_method): Use Qinvalid_function.
8575 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8577 * makefile.w32-in: Update dependencies.
8578 (LISP_H): Add inttypes.h and stdin.h.
8579 (PROCESS_H): Add unistd.h.
8581 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8583 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8584 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8586 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8588 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8590 * term.c (vfatal): Remove stray call to va_end.
8591 It's not needed and the C Standard doesn't allow it here anyway.
8593 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8594 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8596 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8599 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8601 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8603 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8605 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8607 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8609 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8610 * charset.c (Fdefine_charset_internal): Don't initialize
8611 charset.code_space[15]. The value was garbage, on hosts with
8612 32-bit int (Bug#8600).
8614 * lread.c (read_integer): Be more consistent with string-to-number.
8615 Use string_to_number to do the actual conversion; this avoids
8616 rounding errors and fixes some other screwups. Without this fix,
8617 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8618 (digit_to_number): Move earlier, for benefit of read_integer.
8619 Return -1 if the digit is out of range for the base, -2 if it is
8620 not a digit in any supported base. (Bug#8602)
8622 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8624 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8625 to match comment at start of function. This also removes a
8626 GCC warning about overflow in a 32+64-bit port.
8628 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8630 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8631 Reported by Stefan Monnier in
8632 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8633 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8634 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8636 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8637 (EMACS_UINTPTR): Likewise, with uintptr_t.
8639 * lisp.h: Prefer 64-bit EMACS_INT if available.
8640 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8641 on 32-bit hosts that have 64-bit int, so that they can access
8643 However, temporarily disable this change unless the temporary
8644 symbol WIDE_EMACS_INT is defined.
8646 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8648 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8649 This removes an assumption that EMACS_INT and long are the same
8650 width as pointers. The assumption is true for Emacs porting targets
8651 now, but we want to make other targets possible.
8652 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8653 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8654 In the rest of the code, change types of integers that hold casted
8655 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8656 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8657 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8658 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8659 No need to cast type when ORing.
8660 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8661 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8662 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8663 assume EMACS_INT is the same width as char *.
8664 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8665 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8666 Remove no-longer-needed casts.
8667 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8668 (xg_tool_bar_help_callback, xg_make_tool_item):
8669 Use EMACS_INTPTR to hold an integer
8670 that will be cast to void *; this can avoid a GCC warning
8671 if EMACS_INT is not the same width as void *.
8672 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8673 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8674 (current_message_1, set_message_1):
8675 Use a local to convert to proper width without a cast.
8676 * xmenu.c (dialog_selection_callback): Likewise.
8678 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8679 Also, don't assume VALBITS / RAND_BITS is less than 5,
8680 and don't rely on undefined behavior when shifting a 1 left into
8682 * lisp.h (get_random): Change signature to match.
8684 * lread.c (hash_string): Use size_t, not int, for hash computation.
8685 Normally we prefer signed values; but hashing is special, because
8686 it's better to use unsigned division on hash table sizes so that
8687 the remainder is nonnegative. Also, size_t is the natural width
8688 for hashing into memory. The previous code used 'int', which doesn't
8689 retain enough info to hash well into very large tables.
8690 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8692 * dbusbind.c: Don't possibly lose pointer info when converting.
8693 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8694 Use XPNTR rather than XHASH, so that the high-order bits of
8695 the pointer aren't lost when converting through void *.
8697 * eval.c (Fautoload): Don't double-shift a pointer.
8699 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8701 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8703 * gnutls.c (DEF_GNUTLS_FN):
8704 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8706 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8708 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8711 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8713 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8714 New version that can reserve upto 2GB of heap space.
8716 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8718 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8720 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8722 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8723 `gnutls_certificate_set_x509_key_file'.
8725 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8727 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8728 Update dependencies.
8730 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8732 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8733 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8734 Remove unused parameter `fildes'.
8735 * process.c (read_process_output, send_process): Don't pass it.
8737 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8739 Fix previous change: the library cache is defined in w32.c.
8740 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8741 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8743 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8745 Implement dynamic loading of GnuTLS on Windows.
8747 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8748 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8749 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8752 * gnutls.c (Qgnutls_dll): Define.
8753 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8754 (gnutls_*): Declare function pointers.
8755 (init_gnutls_functions): New function to initialize function pointers.
8756 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8757 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8758 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8759 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8760 (emacs_gnutls_write, emacs_gnutls_read)
8761 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8762 (Fgnutls_available_p): New function.
8763 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8764 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8765 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8767 * image.c: Include w32.h.
8768 (Vimage_type_cache): Delete.
8769 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8770 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8771 (w32_delayed_load): Move to w32.c.
8773 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8775 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8776 (w32_delayed_load): Move from image.c. When loading a library, record
8777 its filename in the :loaded-from property of the library id.
8778 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8779 Initialize and staticpro them.
8780 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8782 * process.c: Include lisp.h before w32.h, not after.
8783 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8784 instead of gnutls_record_check_pending.
8786 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8788 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8790 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8791 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8794 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8796 * xterm.c (x_set_frame_alpha): Do not set property on anything
8797 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8799 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8801 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8803 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8805 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8806 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8807 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8808 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8809 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8810 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8811 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8812 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8813 (Qgnutls_bootprop_callbacks_verify): Make static.
8815 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8817 * callproc.c: Indentation fixup.
8819 * sysdep.c (wait_for_termination_1): Make static.
8820 (wait_for_termination, interruptible_wait_for_termination):
8821 Move after wait_for_termination_1.
8823 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8825 * sysdep.c (interruptible_wait_for_termination): New function
8826 which is like wait_for_termination, but allows keyboard
8829 * callproc.c (Fcall_process): Add (:file "file") as an option for
8831 (Fcall_process_region): Ditto.
8833 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8835 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8836 rather than `XVECTOR (FOO)->size'.
8838 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8839 inttypes.h, as a gnulib replacement is used if it not available in
8842 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8844 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8845 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8846 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8848 * coding.c (coding_alloc_by_realloc): Error out if destination
8849 will grow beyond MOST_POSITIVE_FIXNUM.
8850 (decode_coding_emacs_mule): Abort if there isn't enough place in
8851 charbuf for the composition carryover bytes. Reserve an extra
8852 space for up to 2 characters produced in a loop.
8853 (decode_coding_iso_2022): Abort if there isn't enough place in
8854 charbuf for the composition carryover bytes.
8856 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8858 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8859 aborting when %lld or %lll format is passed.
8860 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8861 %llo or %llx format is passed. (Bug#8545)
8863 * window.c (window_scroll_line_based): Use a marker instead of
8864 simple variables to record original value of point. (Bug#7952)
8866 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8867 produced by %s or %c overflows available buffer space. (Bug#8545)
8869 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8871 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8872 (SIZE_MAX): Move defn after all includes, as they might #define it.
8874 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8876 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8878 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8880 * keyboard.c (Qdelayed_warnings_hook): Define.
8881 (command_loop_1): Run `delayed-warnings-hook'
8882 if Vdelayed_warnings_list is non-nil.
8883 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8884 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8886 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8888 * doprnt.c (doprnt): Don't return value smaller than the buffer
8889 size if the message was truncated. (Bug#8545).
8891 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8893 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8894 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8896 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8898 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8900 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8902 * makefile.w32-in: Update dependencies.
8904 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8906 Improve `doprnt' and its usage. (Bug#8545)
8907 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8908 `format_end'. Remove support for %l as a conversion specifier.
8909 Don't use xrealloc. Improve diagnostics when the %l size modifier
8910 is used. Update the commentary.
8912 * eval.c (verror): Simplify calculation of size_t.
8914 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8917 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8919 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8922 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8924 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8925 This makes this file independent of the recent pseudovector change.
8927 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8929 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8931 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8932 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8933 Remove unused local.
8934 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8936 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8937 GCC 4.6.0 optimizes based on type-based alias analysis.
8938 For example, if b is of type struct buffer * and v of type struct
8939 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8940 != &v->size, and therefore "v->size = 1; b->size = 2; return
8941 v->size;" must therefore return 1. This assumption is incorrect
8942 for Emacs, since it type-puns struct Lisp_Vector * with many other
8943 types. To fix this problem, this patch adds a new type struct
8944 vectorlike_header that documents the constraints on layout of vectors
8945 and pseudovectors, and helps optimizing compilers not get fooled
8946 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8947 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8948 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8950 (XSETPVECTYPE): Rewrite in terms of new macro.
8951 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8952 This is a bit clearer, and further avoids the possibility of
8953 undesirable aliasing.
8954 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8955 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8956 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8957 since Lisp_Subr is a special case (no "next" field).
8958 (ASIZE): Now uses header.size rather than size.
8959 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8960 to avoid the hassle of writing XVECTOR (foo)->header.size.
8961 (struct vectorlike_header): New type.
8962 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8963 object, to help avoid aliasing.
8964 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8965 (SUBRP): Likewise, since Lisp_Subr is a special case.
8966 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8967 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8968 (struct Lisp_Hash_Table): Combine first two members into a single
8969 struct vectorlike_header member. All uses of "size" and "next" members
8970 changed to be "header.size" and "header.next".
8971 * buffer.h (struct buffer): Likewise.
8972 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8973 * frame.h (struct frame): Likewise.
8974 * process.h (struct Lisp_Process): Likewise.
8975 * termhooks.h (struct terminal): Likewise.
8976 * window.c (struct save_window_data, struct saved_window): Likewise.
8977 * window.h (struct window): Likewise.
8978 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8979 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8980 * buffer.c (init_buffer_once): Likewise.
8981 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8983 * process.c (Fformat_network_address): Use local var for size,
8986 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8988 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8989 * data.c (atof): Remove decl; no longer used or needed.
8990 (digit_to_number): Move to lread.c.
8991 (Fstring_to_number): Use new string_to_number function, to be
8992 consistent with how the Lisp reader treats infinities and NaNs.
8993 Do not assume that floating-point numbers represent EMACS_INT
8994 without losing information; this is not true on most 64-bit hosts.
8995 Avoid double-rounding errors, by insisting on integers when
8996 parsing non-base-10 numbers, as the documentation specifies.
8997 * lisp.h (string_to_number): New decl, replacing ...
8998 (isfloat_string): Remove.
8999 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9000 (read1): Do not accept +. and -. as integers; this
9001 appears to have been a coding error. Similarly, do not accept
9002 strings like +-1e0 as floating point numbers. Do not report
9003 overflow for integer overflows unless the base is not 10 which
9004 means we have no simple and reliable way to continue.
9005 Break out the floating-point parsing into a new
9006 function string_to_number, so that Fstring_to_number parses
9007 floating point numbers consistently with the Lisp reader.
9008 (digit_to_number): Move here from data.c. Make it static inline.
9009 (E_CHAR, EXP_INT): Remove, replacing with ...
9010 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9011 (string_to_number): New function, replacing isfloat_string.
9012 This function checks for valid syntax and produces the resulting
9013 Lisp float number too. Rework it so that string-to-number
9014 no longer mishandles examples like "1.0e+". Use strtoumax,
9015 so that overflow for non-base-10 numbers is reported only when
9016 there's no portable and simple way to convert to floating point.
9018 * textprop.c (set_text_properties_1): Rewrite for clarity,
9019 and to avoid GCC warning about integer overflow.
9021 * intervals.h (struct interval): Use EMACS_INT for members
9022 where EMACS_UINT might cause problems. See
9023 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9024 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9025 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9027 (offset_intervals): Tell GCC not to worry about length overflow
9028 when negating a negative length.
9030 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9031 (overrun_check_free): Likewise.
9033 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9034 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9037 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9038 (gnutls_make_error): Rename local to avoid shadowing.
9039 (gnutls_emacs_global_deinit): ifdef out; not used.
9040 (Fgnutls_boot): Use const for pointer to readonly storage.
9041 Comment out unused local. Fix pointer signedness problems.
9043 * lread.c (openp): Don't stuff size_t into an 'int'.
9044 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9045 about possible signed overflow.
9047 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9048 (GDK_KEY_g): Don't define if already defined.
9049 (xg_prepare_tooltip): Avoid pointer signedness problem.
9050 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9052 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9053 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9055 * xfns.c (Fx_window_property): Simplify a bit,
9056 to make a bit faster and to avoid GCC 4.6.0 warning.
9057 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9059 * fns.c (internal_equal): Don't assume size_t fits in int.
9061 * alloc.c (compact_small_strings): Tighten assertion a little.
9063 Replace pEd with more-general pI, and fix some printf arg casts.
9064 * lisp.h (pI): New macro, generalizing old pEd macro to other
9065 conversion specifiers. For example, use "...%"pI"d..." rather
9066 than "...%"pEd"...".
9067 (pEd): Remove. All uses replaced with similar uses of pI.
9068 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9069 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9070 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9071 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9072 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9073 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9074 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9076 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9077 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9078 * print.c (safe_debug_print, print_object): Likewise.
9079 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9081 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9082 avoiding the 0 flag, which is not portable.
9083 * process.c (Fmake_network_process): Use pI to avoid cast.
9084 * region-cache.c (pp_cache): Likewise.
9085 * xdisp.c (decode_mode_spec): Likewise.
9086 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9087 behavior on 64-bit hosts with printf arg.
9088 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9089 (x_stop_queuing_selection_requests): Likewise.
9090 (x_get_window_property): Don't truncate byte count to an 'int'
9093 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9094 here, since it parses constructs like leading '-' and spaces,
9095 which are not wanted; and it overflows with large numbers.
9096 Instead, simply match F[0-9]+, which is what is wanted anyway.
9098 * alloc.c: Remove unportable assumptions about struct layout.
9099 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9100 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9101 (allocate_vectorlike, make_pure_vector): Use the new macros,
9102 plus offsetof, to remove unportable assumptions about struct layout.
9103 These assumptions hold on all porting targets that I know of, but
9104 they are not guaranteed, they're easy to remove, and removing them
9105 makes further changes easier.
9107 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9108 This doesn't fix a bug but makes the code clearer.
9109 (string_overrun_cookie): Now const. Use initializers that
9110 don't formally overflow signed char, to avoid warnings.
9111 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9112 can cause Emacs to crash when string overrun checking is enabled.
9113 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9114 multiple of sizeof (EMACS_INT); it need not be, if
9115 alignof(EMACS_INT) < sizeof (EMACS_INT).
9116 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9118 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9120 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9122 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9124 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9125 supposed to be handshaking. (Bug#8556)
9126 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9128 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9130 * lisp.h (Qdebug): List symbol.
9131 * eval.c (Qdebug): Restore global linkage.
9132 * keyboard.c (debug-on-event): New variable.
9133 (handle_user_signal): Break into debugger when debug-on-event
9134 matches the current signal symbol.
9136 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9138 * alloc.c (check_sblock, check_string_bytes)
9139 (check_string_free_list): Convert to standard C.
9141 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9143 * w32.c (emacs_gnutls_push): Fix typo.
9145 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9147 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9148 "cast to pointer from integer of different size".
9150 Improve doprnt and its use in verror. (Bug#8545)
9151 * doprnt.c (doprnt): Document the set of format control sequences
9152 supported by the function. Use SAFE_ALLOCA instead of always
9155 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9156 is one byte too soon. Don't use xrealloc; instead xfree and
9159 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9161 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9164 * gnutls.c: Renamed global_initialized to
9165 gnutls_global_initialized. Added internals for the
9166 :verify-hostname-error, :verify-error, and :verify-flags
9167 parameters of `gnutls-boot' and documented those parameters in the
9168 docstring. Start callback support.
9169 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9170 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9171 on error. Return error code.
9172 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9173 (emacs_gnutls_read): Likewise.
9174 (Fgnutls_boot): Return handshake error code.
9175 (emacs_gnutls_handle_error): New function.
9176 (wsaerror_to_errno): Likewise.
9178 * w32.h (emacs_gnutls_pull): Add prototype.
9179 (emacs_gnutls_push): Likewise.
9181 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9182 (emacs_gnutls_push): Likewise.
9184 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9186 * process.c (wait_reading_process_output): Check if GnuTLS
9187 buffered some data internally if no FDs are set for TLS
9190 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9191 (LIBS): Link to USER_LIBS.
9192 ($(BLD)/gnutls.$(0)): New target.
9194 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9196 * xdisp.c (handle_single_display_spec): Rename the
9197 display_replaced_before_p argument into display_replaced_p, to
9198 make it consistent with the commentary. Fix typos in the
9201 * textprop.c (syms_of_textprop): Remove dead code.
9202 (copy_text_properties): Delete obsolete commentary about an
9203 interface that was deleted long ago. Fix typos in the description
9206 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9207 to changes in oldXMenu/XMenu.h from 2011-04-16.
9208 <menu_help_message, prev_menu_help_message>: Constify.
9209 (IT_menu_make_room): menu->help_text is now `const char **';
9212 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9213 to changes in oldXMenu/XMenu.h from 2011-04-16.
9214 (struct XMenu): Declare `help_text' `const char **'.
9216 * xfaces.c <Qunspecified>: Make extern again.
9218 * syntax.c: Include sys/types.h before including regex.h, as
9221 * doc.c (get_doc_string): Improve the format passed to `error'.
9223 * doprnt.c (doprnt): Improve commentary.
9225 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9227 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9230 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9231 changes in globals.h immediately force recompilation.
9232 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9233 $(CURDIR)/s/ms-w32.h.
9234 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9236 * character.c (Fchar_direction): Function deleted.
9237 (syms_of_character): Don't defsubr it.
9238 <char-direction-table>: Deleted.
9240 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9242 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9243 * doprnt.c: Include limits.h.
9244 (SIZE_MAX): New macro.
9245 (doprnt): Return a size_t value. 2nd arg is now size_t.
9246 Many local variables are now size_t instead of int or unsigned.
9247 Improve overflow protection. Support `l' modifier for integer
9248 conversions. Support %l conversion. Don't assume an EMACS_INT
9249 argument for integer conversions and for %c.
9251 * lisp.h (doprnt): Restore prototype.
9253 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9256 * Makefile.in (base_obj): Add back doprnt.o.
9258 * deps.mk (doprnt.o): Add back prerequisites.
9259 (callint.o): Depend on character.h.
9261 * eval.c (internal_lisp_condition_case): Include the handler
9262 representation in the error message.
9263 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9264 when breaking from the loop.
9266 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9268 * callint.c (Fcall_interactively): When displaying error message
9269 about invalid control letter, pass the character's codepoint, not
9270 a pointer to its multibyte form. Improve display of the character
9271 in octal and display also its hex code.
9273 * character.c (char_string): Use %x to display the (unsigned)
9274 codepoint of an invalid character, to avoid displaying a bogus
9277 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9278 `error', not SYMBOL_NAME itself.
9280 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9281 character arguments to `error'.
9283 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9284 to `error' in error message about FINAL_CHAR argument. Make sure
9285 FINAL_CHAR is a character, and use %c when it is passed as
9286 argument to `error'.
9288 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9290 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9292 * w32.c: Include <time.h>.
9293 (sys_localtime): New function.
9295 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9297 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9299 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9301 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9303 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9306 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9308 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9309 gl_state.e_property when gl_state.object is Qt.
9311 * insdel.c (make_gap_larger): Remove limitation of buffer size
9314 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9316 * xdisp.c (lookup_glyphless_char_display)
9317 (produce_glyphless_glyph): Handle cons cell entry in
9318 glyphless-char-display.
9319 (Vglyphless_char_display): Document it.
9321 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9322 glyphless-char-display.
9324 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9326 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9328 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9330 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9331 definition for no-X builds.
9333 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9335 Static checks with GCC 4.6.0 and non-default toolkits.
9337 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9339 * process.c (keyboard_bit_set): Define only if SIGIO.
9340 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9341 (send_process): Repair possible setjmp clobbering.
9343 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9345 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9347 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9349 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9350 Define only if needed.
9352 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9353 by pacifying GCC about it. Maybe it's time to retire it?
9354 * xfaces.c (USG, __TIMEVAL__): Likewise.
9356 * dispextern.h (struct redisplay_interface): Rename param
9358 * termhooks.h (struct terminal): Likewise.
9359 * xterm.c (xembed_send_message): Likewise.
9361 * insdel.c (make_gap_smaller): Define only if
9362 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9364 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9367 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9368 so that we aren't warned about unused symbols.
9370 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9372 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9374 * xfns.c (x_real_positions): Mark locals as initialized.
9376 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9378 * xterm.c: Fix problems found by static analysis with other toolkits.
9379 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9380 (x_dispatch_event): Declare static if USE_GTK, and
9381 define if USE_GTK || USE_X_TOOLKIT.
9382 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9383 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9384 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9385 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9387 * xmenu.c (menu_help_callback): Pointer type fixes.
9388 Use const pointers when pointing at readonly data. Avoid pointer
9390 (FALSE): Remove unused macro.
9391 (update_frame_menubar): Remove unused decl.
9393 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9395 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9396 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9397 (single_menu_item): Rename local to avoid shadowing.
9399 * keyboard.c (make_lispy_event): Remove unused local var.
9401 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9402 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9404 * bitmaps: Change bitmaps from unsigned char back to the X11
9405 compatible char. Avoid the old compiler warnings about
9406 out-of-range initializers by using, for example, '\xab' rather
9409 * xgselect.c (xgselect_initialize): Check vs interface
9410 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9412 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9414 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9415 to read-only memory.
9417 * fns.c (vector): Remove; this old hack is no longer needed.
9419 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9421 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9423 * xrdb.c (x_load_resources): Omit unused local.
9425 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9426 (x_window): Rename locals to avoid shadowing.
9427 (USG): Use the kludged USG macro, to pacify gcc.
9429 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9430 (x_term_init): Remove local to avoid shadowing.
9432 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9434 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9435 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9437 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9439 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9441 Fix regex.c, syntax.c and friends for buffers > 2GB.
9442 * syntax.h (struct gl_state_s): Declare character position members
9445 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9447 * textprop.c (verify_interval_modification, interval_of):
9448 Declare arguments EMACS_INT.
9450 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9453 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9455 * indent.c (Fvertical_motion): Local variable it_start is now
9458 * regex.c (re_match, re_match_2, re_match_2_internal)
9459 (bcmp_translate, regcomp, regexec, print_double_string)
9460 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9461 (re_compile_pattern, re_exec): Declare arguments and local
9462 variables `size_t' and `ssize_t' and return values `regoff_t', as
9464 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9465 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9466 <compile_stack_type>: `size' and `avail' are now `size_t'.
9468 * regex.h <regoff_t>: Use ssize_t, not int.
9469 (re_search, re_search_2, re_match, re_match_2): Arguments that
9470 specify buffer/string position and length are now ssize_t and
9471 size_t. Return type is regoff_t.
9473 2011-04-16 Ben Key <bkey76@gmail.com>
9475 * nsfont.m: Fixed bugs in ns_get_family and
9476 ns_descriptor_to_entity that were caused by using free to
9477 deallocate memory blocks that were allocated by xmalloc (via
9478 xstrdup). This caused Emacs to crash when compiled with
9479 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9480 --enable-checking=xmallocoverrun). xfree is now used to
9481 deallocate these memory blocks.
9483 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9485 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9487 emacs_write: Accept and return EMACS_INT for sizes.
9488 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9490 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9491 Accept and return EMACS_INT.
9492 (emacs_gnutls_write): Return the number of bytes written on
9494 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9495 (emacs_read, emacs_write): Remove check for negative size, as the
9496 Emacs source code has been audited now.
9497 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9498 (emacs_read, emacs_write): Use it.
9499 * process.c (send_process): Adjust to the new signatures of
9500 emacs_write and emacs_gnutls_write. Do not attempt to store
9501 a byte offset into an 'int'; it might overflow.
9502 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9504 * sound.c: Don't assume sizes fit in 'int'.
9505 (struct sound_device.period_size, alsa_period_size):
9506 Return EMACS_INT, not int.
9507 (struct sound_device.write, vox_write, alsa_write):
9508 Accept EMACS_INT, not int.
9509 (wav_play, au_play): Use EMACS_INT to store sizes and to
9510 record read return values.
9512 2011-04-15 Ben Key <bkey76@gmail.com>
9514 * keyboard.c (Qundefined): Don't declare static since it is used
9516 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9517 static since they are used in nsfont.m.
9519 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9521 * process.c (Qprocessp): Don't declare static.
9522 * lisp.h (Qprocessp): Declare again.
9524 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9526 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9528 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9530 Improve C-level modularity by making more things 'static'.
9532 Don't publish debugger-only interfaces to other modules.
9533 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9534 (verify_bytepos, count_markers): Move decls to the only modules
9536 * region-cache.h (pp_cache): Likewise.
9537 * window.h (check_all_windows): Likewise.
9538 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9540 * sysdep.c (croak): Now static, if
9541 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9542 * syssignal.h (croak): Declare only if not static.
9544 * alloc.c (refill_memory_reserve): Now static if
9545 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9546 * lisp.h (refill_memory_reserve): Declare only if not static.
9548 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9549 Define only if USE_LUCID.
9551 * xrdb.c (x_customization_string, x_rm_string): Now static.
9553 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9554 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9556 * xdisp.c (draw_row_with_mouse_face): Now static.
9557 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9559 * window.h (check_all_windows): Mark externally visible.
9561 * window.c (window_deletion_count): Now static.
9563 * undo.c: Make symbols static if they're not exported.
9564 (last_undo_buffer, last_boundary_position, pending_boundary):
9567 * textprop.c (interval_insert_behind_hooks): Now static.
9568 (interval_insert_in_front_hooks): Likewise.
9570 * term.c: Make symbols static if they're not exported.
9571 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9572 (max_frame_lines, tty_set_terminal_modes):
9573 (tty_reset_terminal_modes, tty_turn_off_highlight):
9574 (get_tty_terminal): Now static.
9575 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9576 * termhooks.h (term_mouse_moveto): Do not declare if
9578 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9579 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9581 * sysdep.c: Make symbols static if they're not exported.
9582 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9584 (sigprocmask_set, full_mask): Remove; unused.
9585 (wait_debugging): Mark as visible.
9586 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9587 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9589 * syntax.c (syntax_temp): Define only if !__GNUC__.
9591 * sound.c (current_sound_device, current_sound): Now static.
9593 * search.c (searchbufs, searchbuf_head): Now static.
9595 * scroll.c (scroll_cost): Remove; unused.
9596 * dispextern.h (scroll_cost): Remove decl.
9598 * region-cache.h (pp_cache): Mark as externally visible.
9600 * process.c: Make symbols static if they're not exported.
9601 (process_tick, update_tick, create_process, chan_process):
9602 (Vprocess_alist, proc_buffered_char, datagram_access):
9603 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9604 (deactivate_process): Mark defn as static, as well as decl.
9605 * lisp.h (create_process): Remove decl.
9606 * process.h (chan_process, Vprocess_alist): Remove decls.
9608 * print.c: Make symbols static if they're not exported.
9609 (print_depth, new_backquote_output, being_printed, print_buffer):
9610 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9611 (print_interval, print_number_index, initial_stderr_stream):
9613 * lisp.h (Fprinc): Remove decl.
9614 (debug_output_compilation_hack): Mark as externally visible.
9616 * sysdep.c (croak): Move decl from here to syssignal.h.
9617 * syssignal.h (croak): Put it here, so the API can be checked when
9618 'croak' is called from dissociate_if_controlling_tty.
9620 * minibuf.c: Make symbols static if they're not exported.
9621 (minibuf_save_list, choose_minibuf_frame): Now static.
9622 * lisp.h (choose_minibuf_frame): Remove decl.
9624 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9626 * lread.c: Make symbols static if they're not exported.
9627 (read_objects, initial_obarray, oblookup_last_bucket_number):
9629 (make_symbol): Remove; unused.
9630 * lisp.h (initial_obarray, make_symbol): Remove decls.
9632 * keyboard.c: Make symbols static if they're not exported.
9633 (single_kboard, recent_keys_index, total_keys, recent_keys):
9634 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9635 (this_single_command_key_start, echoing, last_auto_save):
9636 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9637 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9638 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9639 (Vlispy_mouse_stem, double_click_count):
9641 (force_auto_save_soon): Define only if SIGDANGER.
9642 (ignore_mouse_drag_p): Now static if
9643 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9644 (print_help): Remove; unused.
9645 (stop_character, last_timer_event): Mark as externally visible.
9646 * keyboard.h (ignore_mouse_drag_p): Declare only if
9647 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9648 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9649 * lisp.h (echoing): Remove decl.
9650 (force_auto_save_soon): Declare only if SIGDANGER.
9651 * xdisp.c (redisplay_window): Simplify code, to make it more
9652 obvious that ignore_mouse_drag_p is not accessed if !defined
9653 USE_GTK && !defined HAVE_NS.
9655 * intervals.c: Make symbols static if they're not exported.
9656 (merge_properties_sticky, merge_interval_right, delete_interval):
9658 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9660 * insdel.c: Make symbols static if they're not exported.
9661 However, leave prepare_to_modify_buffer alone. It's never
9662 called from outside this function, but that appears to be a bug.
9663 (combine_after_change_list, combine_after_change_buffer):
9664 (adjust_after_replace, signal_before_change): Now static.
9665 (adjust_after_replace_noundo): Remove; unused.
9666 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9667 (signal_before_change): Remove decls.
9669 * indent.c (val_compute_motion, val_vmotion): Now static.
9671 * image.c: Make symbols static if they're not exported.
9672 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9674 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9675 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9677 * fringe.c (standard_bitmaps): Now static.
9678 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9680 * frame.c: Make symbols static if they're not exported.
9681 (x_report_frame_params, make_terminal_frame): Now static.
9682 (get_frame_param): Now static, unless HAVE_NS.
9683 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9684 (x_get_resource_string): Remove; not used.
9685 * frame.h (make_terminal_frame, x_report_frame_params):
9686 (x_get_resource_string); Remove decls.
9687 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9688 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9690 * font.c, fontset.c: Make symbols static if they're not exported.
9691 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9692 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9693 * font.c (font_close_object): Now static.
9694 * font.h (font_close_object): Remove.
9695 * fontset.c (FONTSET_OBJLIST): Remove.
9696 (free_realized_fontset) #if-0 the body, which does nothing.
9697 (face_suitable_for_char_p): #if-0, as it's never called.
9698 * fontset.h (face_suitable_for_char_p): Remove decl.
9699 * xfaces.c (face_at_string_position):
9700 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9701 since 0 is always ASCII.
9703 * fns.c (weak_hash_tables): Now static.
9705 * fileio.c: Make symbols static if they're not exported.
9706 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9707 (Vwrite_region_annotation_buffers): Now static.
9709 * eval.c: Make symbols static if they're not exported.
9710 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9711 * lisp.h (backtrace_list): Remove decl.
9713 * emacs.c: Make symbols static if they're not exported.
9714 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9715 (fatal_error_code, fatal_error_signal_hook, standard_args):
9717 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9718 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9719 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9720 * lisp.h (fatal_error_signal_hook): Remove decl.
9721 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9723 * editfns.c: Move a (normally-unused) function to its only use.
9724 * editfns.c, lisp.h (get_operating_system_release): Remove.
9725 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9726 worth the hassle of breaking this out.
9728 * xterm.c: Make symbols static if they're not exported.
9729 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9730 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9731 (x_destroy_window, x_delete_display):
9733 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9734 (x_mouse_leave): Remove; unused.
9735 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9736 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9737 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9739 (x_mouse_leave): Declare only if WINDOWSNT.
9740 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9741 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9744 * ftxfont.c: Make symbols static if they're not exported.
9745 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9747 * font.h (ftxfont_driver): Likewise.
9749 * xfns.c: Make symbols static if they're not exported.
9750 (x_last_font_name, x_display_info_for_name):
9751 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9752 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9753 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9754 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9755 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9756 (last_show_tip_args): Now static.
9757 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9758 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9759 (x_screen_planes): Remove; unused.
9760 * dispextern.h (x_screen_planes): Remove decl.
9762 * dispnew.c: Make symbols static if they're not exported.
9763 * dispextern.h (redraw_garbaged_frames, scrolling):
9764 (increment_row_positions): Remove.
9765 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9766 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9768 (redraw_garbaged_frames): Remove; unused.
9770 * xfaces.c: Make symbols static if they're not exported.
9771 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9773 * xterm.h (defined_color): Remove decls.
9774 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9775 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9776 (menu_face_changed_default, defined_color, free_realized_face):
9777 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9778 (ascii_face_of_lisp_face): Remove; unused.
9780 * xdisp.c: Make symbols static if they're not exported.
9781 * dispextern.h (scratch_glyph_row, window_box_edges):
9782 (glyph_to_pixel_coords, set_cursor_from_row):
9783 (get_next_display_element, set_iterator_to_next):
9784 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9785 (show_mouse_face): Remove decls
9786 * frame.h (message_buf_print): Likewise.
9787 * lisp.h (pop_message, set_message, check_point_in_composition):
9789 * xterm.h (set_vertical_scroll_bar): Likewise.
9790 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9791 (message_buf_print, scratch_glyph_row, displayed_buffer):
9792 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9793 (get_next_display_element, show_mouse_face, window_box_edges):
9794 (frame_to_window_pixel_xy, check_point_in_composition):
9795 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9796 (glyph_to_pixel_coords): Remove; unused.
9798 * dired.c (file_name_completion): Now static.
9800 * dbusbind.c (xd_in_read_queued_messages): Now static.
9802 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9803 * data.c (circular_list_error): Remove.
9805 * commands.h (last_point_position, last_point_position_buffer):
9806 (last_point_position_window): Remove decls.
9807 * keyboard.c: Make these variables static.
9809 * coding.h (coding, code_convert_region, encode_coding_gap):
9811 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9812 (iso_code_class, detect_coding, code_convert_region): Now static.
9813 (encode_coding_gap): Remove; unused.
9815 * chartab.c (chartab_chars, chartab_bits): Now static.
9817 * charset.h (charset_iso_8859_1): Remove decl.
9818 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9821 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9822 * ccl.c (Vccl_program_table): Now static.
9823 (check_ccl_update): Remove; unused.
9825 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9826 * category.h: ... from here.
9827 * category.c (check_category_table, set_category_set): Now static.
9829 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9830 * lisp.h: Remove these decls.
9832 * buffer.c (buffer_count): Remove unused var.
9834 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9835 so that it's not optimized away.
9836 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9837 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9838 exported only to the debugger.
9840 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9841 * atimer.h (run_all_atimers): Remove; not exported.
9843 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9844 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9845 was inaccessible from Lisp.
9846 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9847 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9849 alloc.c: Import and export fewer symbols, and remove unused items.
9850 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9852 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9853 it's not optimized away by whole-program optimization.
9854 (message_enable_multibyte, free_misc): Remove.
9855 (catchlist, handlerlist, mark_backtrace):
9856 Declare only if BYTE_MARK_STACK.
9857 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9858 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9859 (message_enable_multibyte): Remove decl.
9860 (free_misc, interval_free_list, float_block, float_block_index):
9861 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9862 (cons_free_list, last_marked_index):
9864 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9865 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9866 (mark_backtrace): Define only if BYTE_MARK_STACK.
9867 * xdisp.c (message_enable_multibyte): Now static.
9869 Declare Lisp_Object Q* variables to be 'static' if not exported.
9870 This makes it easier for human readers (and static analyzers)
9871 to see whether these variables are used from other modules.
9872 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9873 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9874 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9875 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9876 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9877 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9878 * xmenu.c, xselect.c:
9879 Declare Q* vars static if they are not used in other modules.
9880 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9881 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9882 Remove decls of unexported vars.
9883 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9885 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9887 Make Emacs functions such as Fatom 'static' by default.
9888 This makes it easier for human readers (and static analyzers)
9889 to see whether these functions can be called from other modules.
9890 DEFUN now defines a static function. To make the function external
9891 so that it can be used in other C modules, use the new macro DEFUE.
9892 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9893 (Finit_image_library):
9894 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9895 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9896 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9897 Remove decls, since these functions are now static.
9898 (Funintern, Fget_internal_run_time): New decls, since these functions
9899 were already external.
9901 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9902 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9903 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9904 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9905 * keyboard.c, keymap.c, lread.c:
9906 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9907 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9908 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9909 Mark functions with DEFUE instead of DEFUN,
9910 if they are used in other modules.
9911 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9912 decls for now-static functions.
9913 * buffer.h (Fdelete_overlay): Remove decl.
9914 * callproc.c (Fgetenv_internal): Mark as internal.
9915 * composite.c (Fremove_list_of_text_properties): Remove decl.
9916 (Fcomposition_get_gstring): New forward static decl.
9917 * composite.h (Fcomposite_get_gstring): Remove decl.
9918 * dired.c (Ffile_attributes): New forward static decl.
9919 * doc.c (Fdocumntation_property): New forward static decl.
9920 * eval.c (Ffetch_bytecode): New forward static decl.
9921 (Funintern): Remove extern decl; now in .h file where it belongs.
9922 * fileio.c (Fmake_symbolic_link): New forward static decl.
9923 * image.c (Finit_image_library): New forward static decl.
9924 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9925 * intervals.h (Fprevious_property_change):
9926 (Fremove_list_of_text_properties): Remove decls.
9927 * keyboard.c (Fthis_command_keys): Remove decl.
9928 (Fcommand_execute): New forward static decl.
9929 * keymap.c (Flookup_key): New forward static decl.
9930 (Fcopy_keymap): Now static.
9931 * keymap.h (Flookup_key): Remove decl.
9932 * process.c (Fget_process): New forward static decl.
9933 (Fprocess_datagram_address): Mark as internal.
9934 * syntax.c (Fsyntax_table_p): New forward static decl.
9935 (skip_chars): Remove duplicate decl.
9936 * textprop.c (Fprevious_property_change): New forward static decl.
9937 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9939 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9940 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9942 * editfns.c (Fformat): Remove unreachable code.
9944 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9946 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9949 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9951 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9952 when at ZV. (Bug#8487)
9954 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9956 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9958 * keyboard.c (parse_tool_bar_item): Likewise.
9959 * sound.c (sound_cleanup, alsa_close): Likewise.
9960 * termcap.c (tgetent): Likewise.
9961 * xfns.c (x_default_font_parameter): Likewise.
9962 * xsettings.c (read_and_apply_settings): Likewise.
9964 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9965 (overrun_check_free): Protoize.
9967 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9969 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9970 since callers should never pass a negative size.
9971 Change the signature to match that of plain 'read' and 'write'; see
9972 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9973 * lisp.h: Update prototypes of emacs_write and emacs_read.
9975 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9977 * xdisp.c (redisplay_window): Don't try to determine the character
9978 position of the scroll margin if the window start point w->startp
9979 is outside the buffer's accessible region. (Bug#8468)
9981 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9983 Fix write-region and its subroutines for buffers > 2GB.
9984 * fileio.c (a_write, e_write): Modify declaration of arguments and
9985 local variables to support buffers larger than 2GB.
9986 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9988 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9989 argument, local variables, and return value.
9991 * lisp.h: Update prototypes of emacs_write and emacs_read.
9993 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9995 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9997 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9999 Fix more problems found by GCC 4.6.0's static checks.
10001 * xdisp.c (vmessage): Use a better test for character truncation.
10003 * charset.c (load_charset_map): <, not <=, for optimization,
10004 and to avoid potential problems with integer overflow.
10005 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10006 * casetab.c (set_identity, shuffle): Likewise.
10007 * editfns.c (Fformat): Likewise.
10008 * syntax.c (skip_chars): Likewise.
10010 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10011 This also lets GCC 4.6.0 generate slightly better loop code.
10013 * callint.c (Fcall_interactively): <, not <=, for optimization.
10014 (Fcall_interactively): Count the number of arguments produced,
10015 not the number of arguments given. This is simpler and lets GCC
10016 4.6.0 generate slightly better code.
10018 * ftfont.c: Distingish more carefully between FcChar8 and char.
10019 The previous code passed unsigned char * to a functions like
10020 strlen and xstrcasecmp that expect char *, which does not
10021 conform to the C standard.
10022 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10023 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10024 char * when the C standard requires it.
10026 * keyboard.c (read_char): Remove unused var.
10028 * eval.c: Port to Windows vsnprintf (Bug#8435).
10029 Include <limits.h>.
10030 (SIZE_MAX): Define if the headers do not.
10031 (verror): Do not give up if vsnprintf returns a negative count.
10032 Instead, grow the buffer. This ports to Windows vsnprintf, which
10033 does not conform to C99. Problem reported by Eli Zaretskii.
10034 Also, simplify the allocation scheme, by avoiding the need for
10035 calling realloc, and removing the ALLOCATED variable.
10037 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10039 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10040 But keep the doprint source code for now, as we might revamp it
10041 and use it again (Bug#8435).
10042 * lisp.h (doprnt): Remove.
10043 * Makefile.in (base_obj): Remove doprnt.o.
10044 * deps.mk (doprnt.o): Remove.
10046 error: Print 32- and 64-bit integers portably (Bug#8435).
10047 Without this change, on typical 64-bit hosts error ("...%d...", N)
10048 was used to print both 32- and 64-bit integers N, which relied on
10049 undefined behavior.
10050 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10051 * lisp.h (error, verror): Mark as printf-like functions.
10052 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10053 Report overflow in size calculations when allocating printf buffer.
10054 Do not truncate output string at its first null byte.
10055 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10056 Truncate the output at a character boundary, since vsnprintf does not
10058 * charset.c (check_iso_charset_parameter): Convert internal
10059 character to string before calling 'error', since %c now has the
10061 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10062 overflow when computing char to be passed to 'error'. Do not
10063 pass Lisp_Object to 'error'; pass the integer instead.
10064 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10065 formatted with plain %d.
10067 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10069 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10071 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10073 * xterm.c (x_catch_errors): Remove duplicate declaration.
10075 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10077 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10079 2011-04-10 Jim Meyering <meyering@redhat.com>
10081 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10082 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10083 return ssize_t not "int", and use size_t as the buffer length.
10084 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10085 * gnutls.h: Update declarations.
10086 * process.c (read_process_output): Use ssize_t, to match.
10087 (send_process): Likewise.
10089 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10091 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10093 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10095 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10096 Use unsigned char, to match FcChar8 type definition.
10098 * xterm.c (handle_one_xevent):
10099 * xmenu.c (create_and_show_popup_menu):
10100 * xselect.c (x_decline_selection_request)
10101 (x_reply_selection_request): Avoid type-punned deref of X events.
10103 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10105 Fix some uses of `int' instead of EMACS_INT.
10106 * search.c (string_match_1, fast_string_match)
10107 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10108 (scan_buffer, find_next_newline_no_quit)
10109 (find_before_next_newline, search_command, Freplace_match)
10110 (Fmatch_data): Make some `int' variables be EMACS_INT.
10112 * xdisp.c (display_count_lines): 3rd argument and return value now
10113 EMACS_INT. All callers changed.
10114 (pint2hrstr): Last argument is now EMACS_INT.
10116 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10117 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10118 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10119 (decode_coding_utf_16, decode_coding_emacs_mule)
10120 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10121 (decode_coding_ccl, decode_coding_charset)
10122 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10123 (decode_coding_iso_2022, decode_coding_emacs_mule)
10124 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10125 <char_offset, last_offset>: Declare EMACS_INT.
10126 (encode_coding_utf_8, encode_coding_utf_16)
10127 (encode_coding_emacs_mule, encode_invocation_designation)
10128 (encode_designation_at_bol, encode_coding_iso_2022)
10129 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10130 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10132 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10133 (encode_invocation_designation): Last argument P_NCHARS is now
10135 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10136 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10138 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10141 * ccl.c (Fccl_execute_on_string): Declare some variables
10144 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10146 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10148 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10150 * process.c (Fformat_network_address): Doc fix.
10152 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10154 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10156 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10158 * keyboard.c (read_char): Call Lisp function help-form-show,
10159 instead of using internal_with_output_to_temp_buffer.
10160 (Qhelp_form_show): New var.
10161 (syms_of_keyboard): Use DEFSYM macro.
10163 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10165 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10167 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10169 * process.c (Flist_processes): Remove to Lisp.
10170 (list_processes_1): Delete.
10172 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10174 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10176 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10178 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10180 Fix more problems found by GCC 4.6.0's static checks.
10182 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10184 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10186 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10188 * xdisp.c (vmessage): Mark as a printf-like function.
10190 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10192 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10194 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10195 printf-like functions.
10196 (tiff_load): Add casts to remove these marks before passing them
10197 to system-supplied API.
10199 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10201 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10202 This avoids several warnings with gcc -Wstrict-overflow.
10203 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10204 directly, rather than having caller test rule sign. This avoids
10205 some unnecessary tests.
10206 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10207 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10208 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10210 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10211 (xfont_open): Avoid unnecessary tests.
10213 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10215 * composite.h, composite.c (composition_gstring_put_cache):
10216 Use EMACS_INT, not int, for length.
10218 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10219 breaking out part of COMPOSITION_DECODE_RULE.
10220 (COMPOSITION_DECODE_RULE): Use it.
10221 * composite.c (get_composition_id): Remove unused local vars,
10222 by using the new macro.
10224 * textprop.c (set_text_properties_1): Change while to do-while,
10225 since the condition is always true at first.
10227 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10228 (interval_deletion_adjustment): Return unsigned value.
10231 * process.c (list_processes_1, create_pty, read_process_output):
10232 (exec_sentinel): Remove vars that were set but not used.
10233 (create_pty): Remove unnecessary "volatile"s.
10234 (Fnetwork_interface_info): Avoid possibility of int overflow.
10235 (read_process_output): Do adaptive read buffering even if carryover.
10236 (read_process_output): Simplify nbytes computation if buffered.
10238 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10240 * syntax.c (scan_words): Remove var that was set but not used.
10241 (update_syntax_table): Use unsigned instead of int.
10243 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10244 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10245 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10247 * print.c (print_error_message): Avoid int overflow.
10249 * font.c (font_list_entities): Redo for clarity,
10250 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10252 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10253 (font_score): Avoid potential overflow in diff calculation.
10255 * fns.c (substring_both): Remove var that is set but not used.
10256 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10258 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10260 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10261 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10262 can always succeed if overflow has undefined behavior.
10264 * search.c (boyer_moore, wordify): Remove vars set but not used.
10265 (wordify): Omit three unnecessary tests.
10267 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10268 All callers changed. This avoids the need for an unused var.
10270 * casefiddle.c (casify_region): Remove var that is set but not used.
10272 * dired.c (file_name_completion): Remove var that is set but not used.
10274 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10276 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10277 (Finsert_file_contents): Remove unnecessary code checking fd.
10279 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10280 Check for integer overflow on size calculations.
10282 * buffer.c (Fprevious_overlay_change): Remove var that is set
10285 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10286 Remove vars that are set but not used.
10287 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10288 (timer_check_2): Mark vars as initialized.
10290 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10292 * image.c (lookup_image): Remove var that is set but not used.
10293 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10295 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10296 that are set but not used.
10298 * xfns.c (make_invisible_cursor): Don't return garbage
10299 if XCreateBitmapFromData fails (Bug#8410).
10301 * xselect.c (x_get_local_selection, x_handle_property_notify):
10302 Remove vars that are set but not used.
10304 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10305 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10307 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10308 Remove var that is set but not used.
10309 (scroll_bar_windows_size): Now size_t, not int.
10310 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10311 Check for overflow.
10313 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10314 (map_tty_color) [!defined MSDOS]: Likewise.
10316 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10318 * coding.c: Remove vars that are set but not used.
10319 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10320 All callers changed.
10321 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10322 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10323 (decode_coding_charset): Remove vars that are set but not used.
10325 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10326 that is set but not used.
10328 * print.c (print_object): Remove var that is set but not used.
10330 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10331 The gnulib version avoids calling malloc in the usual case,
10332 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10333 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10334 * filelock.c (current_lock_owner): Likewise.
10335 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10336 * sysdep.c: Include allocator.h, careadlinkat.h.
10337 (emacs_no_realloc_allocator): New static constant.
10338 (emacs_readlink): New function.
10339 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10340 ../lib/careadlinkat.h.
10342 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10344 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10345 first non-nil return value).
10347 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10349 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10350 if not defined (Bug#8403).
10352 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10354 * xdisp.c (display_count_lines): Remove parameter `start',
10355 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10356 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10357 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10358 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10359 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10360 and thereabouts. All callers changed.
10361 (get_per_char_metric): Remove parameter `f', unused since
10362 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10364 2011-04-02 Jim Meyering <meyering@redhat.com>
10366 do not dereference NULL upon failed strdup
10367 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10368 (ns_get_family): Likewise.
10370 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10372 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10374 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10376 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10379 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10381 Add lexical binding.
10383 * window.c (Ftemp_output_buffer_show): New fun.
10384 (Fsave_window_excursion):
10385 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10387 * lread.c (lisp_file_lexically_bound_p): New function.
10388 (Fload): Bind Qlexical_binding.
10389 (readevalloop): Remove `evalfun' arg.
10390 Bind Qinternal_interpreter_environment.
10391 (Feval_buffer): Bind Qlexical_binding.
10392 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10394 (syms_of_lread): Declare `lexical-binding'.
10396 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10398 * keyboard.c (eval_dyn): New fun.
10399 (menu_item_eval_property): Use it.
10401 * image.c (parse_image_spec): Use Ffunctionp.
10403 * fns.c (concat, mapcar1): Accept byte-code-functions.
10405 * eval.c (Fsetq): Handle lexical vars.
10406 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10407 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10408 (FletX, Flet): Obey lexical binding.
10409 (Fcommandp): Handle closures.
10410 (Feval): New `lexical' arg.
10411 (eval_sub): New function extracted from Feval. Use it almost
10412 everywhere where Feval was used. Look up vars in lexical env.
10414 (Ffunctionp): Move from subr.el.
10415 (Ffuncall): Handle closures.
10416 (apply_lambda): Remove `eval_flags'.
10417 (funcall_lambda): Handle closures and new byte-code-functions.
10418 (Fspecial_variable_p): New function.
10419 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10420 but without exporting it to Lisp.
10422 * doc.c (Fdocumentation, store_function_docstring):
10423 * data.c (Finteractive_form): Handle closures.
10425 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10428 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10430 (exec_byte_code): New function extracted from Fbyte_code to handle new
10431 calling convention for byte-code-functions. Add new byte-codes.
10433 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10435 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10437 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10439 * xdisp.c (redisplay_internal): Fix prototype.
10441 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10443 * xdisp.c (SCROLL_LIMIT): New macro.
10444 (try_scrolling): Use it when setting scroll_limit.
10445 Limit scrolling to 100 screen lines.
10446 (redisplay_window): Even when falling back on "recentering",
10447 position point in the window according to scroll-conservatively,
10448 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10450 (try_scrolling): When point is above the window, allow searching
10451 as far as scroll_max, or one screenful, to compute vertical
10452 distance from PT to the scroll margin position. This prevents
10453 try_scrolling from unnecessarily failing when
10454 scroll-conservatively is set to a value slightly larger than the
10455 window height. Clean up the case of PT below the margin at bottom
10456 of window: scroll_max can no longer be INT_MAX. When aggressive
10457 scrolling is in use, don't let point enter the opposite scroll
10458 margin as result of the scroll.
10459 (syms_of_xdisp) <scroll-conservatively>: Document the
10460 threshold of 100 lines for never-recentering scrolling.
10462 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10464 * dispextern.h (move_it_by_lines):
10465 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10466 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10467 (message_log_check_duplicate): Remove parameters `prev_bol' and
10468 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10469 (redisplay_internal): Remove parameter `preserve_echo_area',
10470 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10472 * indent.c (Fvertical_motion):
10473 * window.c (window_scroll_pixel_based, Frecenter):
10474 Don't pass `need_y_p' to `move_it_by_lines'.
10476 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10478 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10479 steal a few bits to be more compact.
10480 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10481 Remove unneeded casts.
10483 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10485 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10487 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10488 binding" message (bug#7967).
10490 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10492 Fix more problems found by GCC 4.6.0's static checks.
10494 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10495 Remove unused local var.
10497 * editfns.c (Fmessage_box): Remove unused local var.
10499 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10500 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10501 Omit unused local vars.
10502 * window.c (shrink_windows): Omit unused local var.
10503 * menu.c (digest_single_submenu): Omit unused local var.
10504 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10505 Omit unused local var.
10507 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10508 Don't assume string length fits in int.
10509 (keyremap_step, read_key_sequence): Use size_t for sizes.
10510 (read_key_sequence): Don't check last_real_key_start redundantly.
10512 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10513 instead of alloca (Bug#8344).
10515 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10516 (Fbacktrace_frame): Don't assume nframes fits in int.
10518 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10520 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10523 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10525 * cm.c (calccost): Turn while-do into do-while, for clarity.
10527 * keyboard.c (syms_of_keyboard): Use the same style as later
10528 in this function when indexing through an array. This also
10529 works around GCC bug 48267.
10531 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10533 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10535 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10536 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10538 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10539 This avoids undefined behavior on integer overflow, and is a bit
10540 more convenient anyway since it is compared to a size_t variable.
10542 Variadic C functions now count arguments with size_t, not int.
10543 This avoids an unnecessary limitation on 64-bit machines, which
10544 caused (substring ...) to crash on large vectors (Bug#8344).
10545 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10546 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10547 All variadic functions and their callers changed accordingly.
10548 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10549 * data.c (arith_driver, float_arith_driver): Likewise.
10550 * editfns.c (general_insert_function): Likewise.
10551 * eval.c (struct backtrace.nargs, interactive_p)
10552 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10553 (funcall_lambda, mark_backtrace): Likewise.
10554 * fns.c (concat): Likewise.
10555 * frame.c (x_set_frame_parameters): Likewise.
10556 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10557 0 if not found, not -1. All callers changed.
10559 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10560 (stack_copy_size): Now size_t, not int.
10561 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10563 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10565 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10566 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10567 All callers changed.
10569 * lisp.h (multibyte_char_to_unibyte):
10570 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10571 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10572 * character.h (CHAR_TO_BYTE8):
10573 * cmds.c (internal_self_insert):
10574 * editfns.c (general_insert_function):
10575 * keymap.c (push_key_description):
10576 * search.c (Freplace_match):
10577 * xdisp.c (message_dolog, set_message_1): All callers changed.
10579 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10581 * keyboard.c (safe_run_hook_funcall): New function.
10582 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10583 don't set the hook to nil, but remove the offending function instead.
10584 (Qcommand_hook_internal): Remove, unused.
10585 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10586 Vcommand_hook_internal.
10588 * eval.c (enum run_hooks_condition): Remove.
10589 (funcall_nil, funcall_not): New functions.
10590 (run_hook_with_args): Call each function through a `funcall' argument.
10591 Remove `cond' argument, now redundant.
10592 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10593 (Frun_hook_with_args_until_failure): Adjust accordingly.
10594 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10596 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10598 * dispextern.h (string_buffer_position): Remove declaration.
10600 * print.c (strout): Remove parameter `multibyte', unused since
10601 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10603 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10604 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10605 All callers changed.
10607 * w32.c (_wsa_errlist): Use braces for struct initializers.
10609 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10610 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10611 All callers changed.
10612 (string_buffer_position): Likewise. Also, make static (it's never
10613 used outside xdisp.c).
10614 (cursor_row_p): Remove parameter `w', unused since
10615 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10616 (decode_mode_spec): Remove parameter `precision', introduced during
10617 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10618 All callers changed.
10620 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10622 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10624 2011-03-27 Anders Lindgren <andlind@gmail.com>
10626 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10627 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10628 (ns_update_auto_hide_menu_bar): New functions.
10629 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10630 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10631 ns_constrain_all_frames.
10632 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10633 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10635 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10637 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10639 2011-03-27 Glenn Morris <rgm@gnu.org>
10641 * syssignal.h: Replace RETSIGTYPE with void.
10642 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10643 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10644 Replace SIGTYPE with void everywhere.
10645 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10646 * s/template.h (SIGTYPE): Remove commented out definition.
10648 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10650 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10651 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10653 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10655 * w32.c (read_unc_volume): Use parameter `henum', instead of
10656 global variable `wget_enum_handle'.
10658 * keymap.c (describe_vector): Remove parameters `indices' and
10659 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10660 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10662 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10664 * keyboard.c (timer_check): Remove parameter `do_it_now',
10665 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10666 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10667 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10669 * keyboard.c (read_char):
10670 * w32menu.c (w32_menu_display_help):
10671 * xmenu.c (show_help_event, menu_help_callback):
10672 Adjust calls to `show_help_echo'.
10674 * gtkutil.c (xg_maybe_add_timer):
10675 * keyboard.c (readable_events):
10676 * process.c (wait_reading_process_output):
10677 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10679 * insdel.c (adjust_markers_gap_motion):
10680 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10681 (gap_left, gap_right): Don't call it.
10683 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10685 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10686 incurred during fontification.
10688 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10690 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10691 (DEFVAR_PER_BUFFER): Don't pass it.
10693 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10694 (scrolling_window): Don't pass it.
10696 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10698 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10700 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10702 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10703 of variables specific to SELinux and computation of `encoded_absname'.
10705 * image.c (XPutPixel): Remove unused variable `height'.
10707 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10709 * unexw32.c (get_section_info): Remove unused variable `section'.
10711 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10712 (system_process_attributes): Remove unused variable `sess'.
10713 (sys_read): Remove unused variable `err'.
10715 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10716 (w32_wnd_proc): Remove unused variable `isdead'.
10717 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10718 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10719 (x_create_tip_frame): Remove unused variable `tem'.
10721 * w32inevt.c (w32_console_read_socket):
10722 Remove unused variable `no_events'.
10724 * w32term.c (x_draw_composite_glyph_string_foreground):
10725 Remove unused variable `width'.
10727 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10729 * w32term.c (x_set_glyph_string_clipping):
10730 Don't pass uninitialized region to CombineRgn.
10732 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10734 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10735 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10736 (Fx_close_connection): Remove unused variable `i'.
10738 * w32font.c (w32font_draw): Return number of glyphs.
10739 (w32font_open_internal): Remove unused variable `i'.
10740 (w32font_driver): Add missing initializer.
10742 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10743 (fill_in_menu): Remove unused variable `items_added'.
10745 * w32term.c (last_mouse_press_frame): Remove static global variable.
10746 (w32_clip_to_row): Remove unused variable `f'.
10747 (x_delete_terminal): Remove unused variable `i'.
10749 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10750 (NOTHING): Remove unused static global variable.
10751 (uniscribe_check_otf): Remove unused variable `table'.
10752 (uniscribe_font_driver): Add missing initializers.
10754 2011-03-23 Julien Danjou <julien@danjou.info>
10756 * term.c (Fsuspend_tty, Fresume_tty):
10757 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10758 * window.c (temp_output_buffer_show):
10759 * insdel.c (signal_before_change):
10760 * frame.c (Fhandle_switch_frame):
10761 * fileio.c (Fdo_auto_save):
10762 * emacs.c (Fkill_emacs):
10763 * editfns.c (save_excursion_restore):
10764 * cmds.c (internal_self_insert):
10765 * callint.c (Fcall_interactively):
10766 * buffer.c (Fkill_all_local_variables):
10767 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10769 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10770 unconditionally since it does the check itself.
10772 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10774 Fix more problems found by GCC 4.5.2's static checks.
10776 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10777 the first time through the loop, since we know p0 < p1 then.
10778 This also avoids a gcc -Wstrict-overflow warning.
10780 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10781 leading to a memory leak, possible in functions like
10782 load_charset_map_from_file that can allocate an unbounded number
10783 of objects (Bug#8318).
10785 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10786 that could (at least in theory) be that large.
10788 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10789 This is less likely to overflow, and avoids undefined behavior if
10790 overflow does occur. All callers changed. Use strtoul to scan
10791 for the unsigned long integer.
10792 (pint2hrstr): Simplify and tune code slightly.
10793 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10795 * scroll.c (do_scrolling): Work around GCC bug 48228.
10796 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10798 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10799 This also avoids a warning with gcc -Wstrict-overflow.
10800 (validate_x_resource_name): Simplify count usage.
10801 This also avoids a warning with gcc -Wstrict-overflow.
10803 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10806 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10808 * process.c (Fmake_network_process): Use socklen_t, not int,
10809 where POSIX says socklen_t is required in portable programs.
10810 This fixes a porting bug on hosts like 64-bit HP-UX, where
10811 socklen_t is wider than int (Bug#8277).
10812 (Fmake_network_process, server_accept_connection):
10813 (wait_reading_process_output, read_process_output):
10816 * process.c: Rename or move locals to avoid shadowing.
10817 (list_processes_1, Fmake_network_process):
10818 (read_process_output_error_handler, exec_sentinel_error_handler):
10819 Rename or move locals.
10820 (Fmake_network_process): Define label "retry_connect" only if needed.
10821 (Fnetwork_interface_info): Fix pointer signedness.
10822 (process_send_signal): Add cast to avoid pointer signedness problem.
10823 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10824 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10826 Make tparam.h and terminfo.c consistent.
10827 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10828 Include tparam.h instead, since it declares them.
10829 * cm.h (PC): Remove extern decl; tparam.h now does this.
10830 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10831 * terminfo.c: Include tparam.h, to check interfaces.
10832 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10833 (tparam): Adjust signature to match interface in tparam.h;
10834 this removes some undefined behavior. Check that outstring and len
10835 are zero, which they always are with Emacs.
10836 * tparam.h (PC, BC, UP): New extern decls.
10838 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10839 (xftfont_open): Rename locals to avoid shadowing.
10841 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10842 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10843 (OTF_TAG_SYM): Omit macro if not needed.
10844 (ftfont_list): Remove unused local.
10845 (get_adstyle_property, ftfont_pattern_entity):
10846 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10847 Rename locals to avoid shadowing.
10849 * xfont.c (xfont_list_family): Mark var as initialized.
10851 * xml.c (make_dom): Now static.
10853 * composite.c (composition_compute_stop_pos): Rename local to
10855 (composition_reseat_it): Remove unused locals.
10856 (find_automatic_composition, composition_adjust_point): Likewise.
10857 (composition_update_it): Mark var as initialized.
10858 (find_automatic_composition): Mark vars as initialized,
10859 with a FIXME (Bug#8290).
10861 character.h: Rename locals to avoid shadowing.
10862 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10863 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10864 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10865 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10866 to avoid shadowing.
10868 * textprop.c (property_change_between_p): Remove; unused.
10870 * intervals.c (interval_start_pos): Now static.
10872 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10874 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10875 Rename locals to avoid shadowing.
10877 * sound.c (wav_play, au_play, Fplay_sound_internal):
10878 Fix pointer signedness.
10879 (alsa_choose_format): Remove unused local var.
10880 (wav_play): Initialize a variable to 0, to prevent undefined
10881 behavior (Bug#8278).
10883 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10885 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10887 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10888 clobbering (Bug#8298).
10889 * sysdep.c (sys_subshell): Likewise.
10890 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10892 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10893 This should get cleaned up, so that child_setup has the
10894 same signature on all platforms.
10896 * callproc.c (call_process_cleanup): Now static.
10897 (relocate_fd): Rename locals to avoid shadowing.
10899 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10901 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10902 not to be necessary, and produces flickering.
10904 2011-03-20 Glenn Morris <rgm@gnu.org>
10906 * config.in: Remove file.
10908 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10910 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10911 are now in src/globals.h.
10912 (syms_of_minibuf): Remove spurious & from previous change.
10914 2011-03-20 Leo Liu <sdl.web@gmail.com>
10916 * minibuf.c (completing-read-function): New variable.
10917 (completing-read-default): Rename from completing-read.
10918 (completing-read): Call completing-read-function.
10920 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10922 * xfaces.c (Fx_load_color_file):
10923 Read color file from absolute filename (bug#8250).
10925 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10927 * makefile.w32-in: Update dependencies.
10929 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10931 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10933 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10935 Fix more problems found by GCC 4.5.2's static checks.
10937 * process.c (make_serial_process_unwind, send_process_trap):
10938 (sigchld_handler): Now static.
10940 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10941 That way, the code declares only the vars that it needs.
10942 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10943 * s/cygwin.h (PTY_ITERATION): Likewise.
10944 * s/darwin.h (PTY_ITERATION): Likewise.
10945 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10947 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10948 * process.c (allocate_pty): Don't declare stb unless it's needed.
10950 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10951 (CONSTANTLIM): Remove; unused.
10952 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10953 Define only if needed.
10955 * unexelf.c (unexec): Name an expression,
10956 to avoid gcc -Wbad-function-cast warning.
10957 Use a different way to cause a compilation error if anyone uses
10958 n rather than nn, a way that does not involve shadowing.
10959 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10961 * deps.mk (unexalpha.o): Remove; unused.
10963 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10964 * unexec.h: New file.
10965 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10966 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10967 Depend on unexec.h.
10968 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10969 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10970 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10971 Change as necessary to match prototype in unexec.h.
10973 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10975 (back_comment, skip_chars): Mark vars as initialized.
10977 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10978 Rename locals to avoid shadowing.
10980 * lread.c (read1): Rewrite so as not to use empty "else".
10981 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10983 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10985 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10986 warning when compiling print.c.
10988 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10989 instead of using an uninitialized var.
10990 (font_sort_entities): Mark var as initialized.
10992 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10994 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10995 pointers to constants.
10996 (font_parse_fcname): Remove unused vars.
10997 (font_delete_unmatched): Now static.
10998 (font_get_spec): Remove; unused.
10999 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11000 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11001 Rename or move locals to avoid shadowing.
11003 * fns.c (require_nesting_list, require_unwind): Now static.
11004 (Ffillarray): Rename locals to avoid shadowing.
11006 * floatfns.c (domain_error2): Define only if needed.
11007 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11009 * alloc.c (mark_backtrace): Move decl from here ...
11010 * lisp.h: ... to here, so that it can be checked.
11012 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11013 (Fdefvar): Rewrite so as not to use empty "else".
11014 (lisp_indirect_variable): Name an expression,
11015 to avoid gcc -Wbad-function-cast warning.
11016 (Fdefvar): Rename locals to avoid shadowing.
11018 * callint.c (quotify_arg, quotify_args): Now static.
11019 (Fcall_interactively): Rename locals to avoid shadowing.
11020 Use const pointer when appropriate.
11022 * lisp.h (get_system_name, get_operating_system_release):
11023 Move decls here, to check interfaces.
11024 * process.c (get_operating_system_release): Move decl to lisp.h.
11025 * xrdb.c (get_system_name): Likewise.
11026 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11027 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11028 some of which prompt warnings from gcc -Wbad-function-cast.
11029 (Fformat_time_string, Fencode_time, Finsert_char):
11030 (Ftranslate_region_internal, Fformat):
11031 Rename or remove local vars to avoid shadowing.
11032 (Ftranslate_region_internal): Mark var as initialized.
11034 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11037 * lisp.h (eassert): Check that the argument compiles, even if
11038 ENABLE_CHECKING is not defined.
11040 * data.c (Findirect_variable): Name an expression, to avoid
11041 gcc -Wbad-function-cast warning.
11042 (default_value, arithcompare, arith_driver, arith_error): Now static.
11043 (store_symval_forwarding): Rename local to avoid shadowing.
11044 (Fmake_variable_buffer_local, Fmake_local_variable):
11045 Mark variables as initialized.
11046 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11048 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11049 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11050 Rename locals to avoid shadowing.
11051 (mark_stack): Move local variables into the #ifdef region where
11053 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11054 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11056 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11057 (GC_STRING_CHARS): Remove; not used.
11058 (Fmemory_limit): Cast sbrk's returned value to char *.
11060 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11061 avoids undefined behavior in theory.
11063 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11065 Use functions, not macros, for up- and down-casing (Bug#8254).
11066 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11067 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11068 to use the following functions instead of these macros.
11069 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11070 EMACS_INT, since callers assume the returned value fits in int.
11071 (upcase1): Likewise, for UPCASE_TABLE.
11072 (uppercasep, lowercasep, upcase): New static inline functions.
11073 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11074 the race-condition problem in the old DOWNCASE.
11076 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11077 Rename locals to avoid shadowing.
11078 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11079 (regex_compile, re_search_2, re_match_2_internal):
11080 Remove unused local vars.
11081 (FREE_VAR): Rewrite so as not to use empty "else",
11082 which gcc can warn about.
11083 (regex_compile, re_match_2_internal): Mark locals as initialized.
11084 (RETALLOC_IF): Define only if needed.
11085 (WORDCHAR_P): Likewise. This one is never needed, but is used
11086 only in a comment talking about a compiler bug, so put inside
11087 the #if 0 of that comment.
11088 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11089 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11092 * search.c (boyer_moore): Rename locals to avoid shadowing.
11093 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11094 (PREV_CHAR_BOUNDARY): Likewise.
11096 * search.c (simple_search): Remove unused var.
11098 * dired.c (compile_pattern): Move decl from here ...
11099 * lisp.h: ... to here, so that it can be checked.
11100 (struct re_registers): New forward decl.
11102 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11104 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11106 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11107 Rename locals to avoid shadowing.
11108 (Fvertical_motion): Mark locals as initialized.
11110 * casefiddle.c (casify_object, casify_region): Now static.
11111 (casify_region): Mark local as initialized.
11113 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11115 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11116 New macros, so that the caller can use some names other than
11117 gcpro1, gcpro2, etc.
11118 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11120 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11121 argument, for consistency with GCPRO2_VAR, etc: it is now the
11122 prefix of the variable, not the variable itself. All uses
11124 * dired.c (directory_files_internal, file_name_completion):
11125 Rename locals to avoid shadowing.
11127 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11128 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11129 dired.c's scmp function, had undefined behavior.
11130 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11131 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11132 * buffer.h: ... to here, because these macros use current_buffer,
11133 and the new implementation with inline functions needs to have
11134 current_buffer in scope now, rather than later when the macros
11136 (downcase, upcase1): New static inline functions.
11137 (DOWNCASE, UPCASE1): Reimplement using these functions.
11138 This avoids undefined behavior in expressions like
11139 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11140 from race conditions in accessing the global variables
11141 case_temp1 and case_temp2.
11142 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11143 * lisp.h (case_temp1, case_temp2): Remove their decls.
11144 * character.h (ASCII_CHAR_P): Move from here ...
11145 * lisp.h: ... to here, so that the inline functions mentioned
11146 above can use them.
11148 * dired.c (directory_files_internal_unwind): Now static.
11150 * fileio.c (file_name_as_directory, directory_file_name):
11151 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11153 (file_name_as_directory): Use const pointers when appropriate.
11154 (Fexpand_file_name): Likewise. In particular, newdir might
11155 point at constant storage, so make it a const pointer.
11156 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11157 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11159 (Fset_file_times, Finsert_file_contents, auto_save_error):
11160 Rename locals to avoid shadowing.
11162 * minibuf.c (choose_minibuf_frame_1): Now static.
11163 (Ftry_completion, Fall_completions): Rename or remove locals
11164 to avoid shadowing.
11166 * marker.c (bytepos_to_charpos): Remove; unused.
11168 * lisp.h (verify_bytepos, count_markers): New decls,
11169 so that gcc does not warn that these functions aren't declared.
11171 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11172 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11173 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11174 (copy_text): Remove unused local var.
11176 * filelock.c (within_one_second): Now static.
11177 (lock_file_1): Rename local to avoid shadowing.
11179 * buffer.c (fix_overlays_before): Mark locals as initialized.
11180 (fix_start_end_in_overlays): Likewise. This function should be
11181 simplified by using pointers-to-pointers, but that's a different
11183 (switch_to_buffer_1): Now static.
11184 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11185 (report_overlay_modification): Rename locals to avoid shadowing.
11187 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11188 Fix pointer signedness issue.
11189 (sys_subshell): Mark local as volatile if checking for lint,
11190 to suppress a gcc -Wclobbered warning that does not seem to be right.
11191 (MAXPATHLEN): Define only if needed.
11193 * process.c (serial_open, serial_configure): Move decls from here ...
11194 * systty.h: ... to here, so that they can be checked.
11196 * fns.c (get_random, seed_random): Move extern decls from here ...
11197 * lisp.h: ... to here, so that they can be checked.
11199 * sysdep.c (reset_io): Now static.
11200 (wait_for_termination_signal): Remove; unused.
11202 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11203 (copy_keymap_item, append_key, push_text_char_description):
11205 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11206 (DENSE_TABLE_SIZE): Remove; unused.
11207 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11208 (describe_map_tree):
11209 Rename locals to avoid shadowing.
11211 * keyboard.c: Declare functions static if they are not used elsewhere.
11212 (echo_char, echo_dash, cmd_error, top_level_2):
11213 (poll_for_input, handle_async_input): Now static.
11214 (read_char, kbd_buffer_get_event, make_lispy_position):
11215 (make_lispy_event, make_lispy_movement, apply_modifiers):
11216 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11217 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11218 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11219 (read_key_sequence, read_char): Mark locals as initialized.
11220 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11222 * keyboard.h (make_ctrl_char): New decl.
11223 (mark_kboards): Move decl here ...
11224 * alloc.c (mark_kboards): ... from here.
11226 * lisp.h (force_auto_save_soon): New decl.
11228 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11229 (DEFINE_DUMMY_FUNCTION): New macro.
11230 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11232 (main): Add casts to avoid warnings
11233 if GCC considers string literals to be constants.
11235 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11237 * dbusbind.c: Pointer signedness fixes.
11238 (xd_signature, xd_append_arg, xd_initialize):
11239 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11240 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11241 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11242 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11244 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11245 if GCC considers string literals to be constants.
11246 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11248 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11250 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11251 (print_preprocess, print_object): New macro to fix last change.
11253 * print.c (print_preprocess): Don't forget font objects.
11255 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11257 * emacs.c (USAGE3): Doc fixes.
11259 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11261 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11264 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11266 * lisp.h (VWindow_system, Qfile_name_history):
11267 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11268 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11269 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11271 * w32select.c: Don't #include "keyboard.h".
11272 (run_protected): Add extern declaration for waiting_for_input.
11274 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11275 * w32console.c (detect_input_pending, read_input_pending)
11276 (encode_terminal_code):
11277 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11278 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11279 (w32_system_caret_y, Qfile_name_history):
11280 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11281 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11282 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11283 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11284 * w32proc.c (Qlocal, report_file_error):
11285 * w32term.c (Vwindow_system, updating_frame):
11286 * w32uniscribe.c (initialized, uniscribe_font_driver):
11287 Remove unneeded extern declarations.
11289 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11291 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11293 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11295 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11296 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11297 These macros can no longer be used for assignment.
11299 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11300 Assign struct members directly, instead of using BUF_BEGV etc.
11301 (record_buffer_markers, fetch_buffer_markers): New functions for
11302 recording and fetching special buffer markers.
11303 (set_buffer_internal_1, set_buffer_temp): Use them.
11305 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11307 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11309 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11310 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11312 * xdisp.c (hscroll_window_tree):
11313 (reconsider_clip_changes): Use PT instead of BUF_PT.
11315 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11317 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11318 $(EMACS_ROOT)/lib/intprops.h.
11320 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11322 Fix more problems found by GCC 4.5.2's static checks.
11324 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11325 to unsigned char * to avoid compiler diagnostic.
11326 (xg_free_frame_widgets): Make it clear that a local variable is
11327 needed only if USE_GTK_TOOLTIP.
11328 (gdk_window_get_screen): Make it clear that this macro is needed
11329 only if USE_GTK_TOOLTIP.
11330 (int_gtk_range_get_value): New function, which avoids a diagnostic
11331 from gcc -Wbad-function-cast.
11332 (xg_set_toolkit_scroll_bar_thumb): Use it.
11333 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11334 diagnostic from gcc -Wbad-function-cast.
11335 (get_utf8_string, xg_get_file_with_chooser):
11336 Rename locals to avoid shadowing.
11337 (create_dialog): Move locals to avoid shadowing.
11339 * xgselect.c (xg_select): Remove unused var.
11341 * image.c (four_corners_best): Mark locals as initialized.
11342 (gif_load): Initialize transparent_p to zero (Bug#8238).
11343 Mark another local as initialized.
11344 (my_png_error, my_error_exit): Mark with NO_RETURN.
11346 * image.c (clear_image_cache): Now static.
11347 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11348 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11349 (x_edge_detection): Remove unnecessary cast that
11350 gcc -Wbad-function-cast diagnoses.
11351 (gif_load): Fix pointer signedness.
11352 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11353 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11355 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11357 Improve quality of tests for time stamp overflow.
11358 For example, without this patch (encode-time 0 0 0 1 1
11359 1152921504606846976) returns the obviously-bogus value (-948597
11360 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11361 reports time overflow. See
11362 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11363 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11364 * editfns.c: Include limits.h and intprops.h.
11365 (TIME_T_MIN, TIME_T_MAX): New macros.
11366 (time_overflow): Move earlier, to before first use.
11367 (hi_time, lo_time): New functions, for an accurate test for
11368 out-of-range times.
11369 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11370 (Fget_internal_run_time): Don't assume time_t fits in int.
11371 (make_time): Use list2 instead of Fcons twice.
11372 (Fdecode_time): More accurate test for out-of-range times.
11373 (check_tm_member): New function.
11374 (Fencode_time): Use it, to test for out-of-range times.
11375 (lisp_time_argument): Don't rely on undefined left-shift and
11376 right-shift behavior when checking for time stamp overflow.
11378 * editfns.c (time_overflow): New function, refactoring common code.
11379 (Fformat_time_string, Fdecode_time, Fencode_time):
11380 (Fcurrent_time_string): Use it.
11382 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11383 * dired.c (make_time): Move to ...
11384 * editfns.c (make_time): ... here.
11385 * systime.h: Note the move.
11387 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11389 * fringe.c (update_window_fringes): Remove unused variables.
11391 * unexmacosx.c (copy_data_segment): Also copy __got section.
11394 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11396 * termcap.c [MSDOS]: Include "msdos.h".
11397 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11398 Constify `char *' arguments and their references according to
11399 prototypes in tparam.h.
11401 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11403 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11404 Adapt all references accordingly.
11406 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11408 2011-03-11 Tom Tromey <tromey@redhat.com>
11410 * buffer.c (syms_of_buffer): Remove obsolete comment.
11412 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11414 * termhooks.h (encode_terminal_code): Declare prototype.
11416 * msdos.c (encode_terminal_code): Don't declare prototype.
11418 * term.c (encode_terminal_code): Now external again, used by
11419 w32console.c and msdos.c.
11421 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11422 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11424 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11426 Fix some minor problems found by GCC 4.5.2's static checks.
11428 * fringe.c (update_window_fringes): Mark locals as initialized
11430 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11432 * alloc.c (mark_fringe_data): Move decl from here ...
11433 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11434 to check its interface.
11435 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11437 * fontset.c (free_realized_fontset): Now static.
11438 (Fset_fontset_font): Rename local to avoid shadowing.
11439 (fontset_font): Mark local as initialized.
11440 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11442 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11444 * xselect.c (x_disown_buffer_selections): Remove; not used.
11445 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11446 (x_own_selection, Fx_disown_selection_internal): Rename locals
11447 to avoid shadowing.
11448 (x_handle_dnd_message): Remove local to avoid shadowing.
11450 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11451 so that the caller can use some name other than gcpro1.
11452 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11453 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11454 (Fx_backspace_delete_keys_p):
11455 Use them to avoid shadowing, and rename vars to avoid shadowing.
11456 (x_decode_color, x_set_name, x_window): Now static.
11457 (Fx_create_frame): Add braces to silence GCC warning.
11458 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11459 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11460 Remove unused locals.
11461 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11462 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11463 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11466 * xterm.h (x_mouse_leave): New decl.
11468 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11469 Remove unused functions.
11470 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11471 (x_calc_absolute_position): Now static.
11472 (XTread_socket): Don't define label "out" unless it's used.
11473 Don't declare local "event" unless it's used.
11474 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11475 unless they are used.
11476 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11477 (x_fatal_error_signal): Remove; not used.
11478 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11479 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11480 (x_error_catcher, x_connection_closed, x_error_handler):
11481 (x_error_quitter, xembed_send_message, x_iconify_frame):
11482 (my_log_handler): Rename locals to avoid shadowing.
11483 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11484 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11486 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11487 Rename or move locals to avoid shadowing.
11488 (tty_defined_color, merge_face_heights): Now static.
11489 (free_realized_faces_for_fontset): Remove; not used.
11490 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11491 does not deduce is never used uninitialized.
11492 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11493 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11495 * terminal.c (store_terminal_param): Now static.
11497 * xmenu.c (menu_highlight_callback): Now static.
11498 (set_frame_menubar): Remove unused local.
11499 (xmenu_show): Rename parameter to avoid shadowing.
11500 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11501 since they might point to immutable storage.
11502 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11503 since it's unused otherwise.
11505 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11506 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11507 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11508 avoids a gcc -Wuninitialized diagnostic.
11509 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11510 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11511 does not deduce are never used uninitialized.
11513 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11515 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11516 * window.c (window_loop, size_window):
11517 (run_window_configuration_change_hook, enlarge_window): Likewise.
11519 * window.c (display_buffer): Now static.
11520 (size_window): Mark variables that gcc -Wuninitialized
11521 does not deduce are never used uninitialized.
11522 * window.h (check_all_windows): New decl, to forestall
11523 gcc -Wmissing-prototypes diagnostic.
11524 * dispextern.h (bidi_dump_cached_states): Likewise.
11526 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11528 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11529 Include <limits.h>.
11530 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11531 and to avoid gcc -Wuninitialized warning.
11532 (load_charset_map): Mark variables that gcc -Wuninitialized
11533 does not deduce are never used uninitialized.
11534 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11536 * coding.c (coding_set_source, coding_set_destination):
11537 Use "else { /* comment */ }" rather than "else /* comment */;"
11538 for clarity, and to avoid gcc -Wempty-body warning.
11539 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11540 a block, when the outer 'i' will do.
11541 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11542 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11543 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11544 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11545 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11546 Rename locals to avoid shadowing.
11547 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11548 * coding.c (emacs_mule_char, encode_invocation_designation):
11549 Now static, since they're not used elsewhere.
11550 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11551 (decode_coding_object, encode_coding_object, detect_coding_system):
11552 (decode_coding_emacs_mule): Mark variables that gcc
11553 -Wuninitialized does not deduce are never used uninitialized.
11554 (detect_coding_iso_2022): Initialize a local variable that might
11555 be used uninitialized. Leave a FIXME because it's not clear that
11556 this initialization is needed. (Bug#8211)
11557 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11558 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11559 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11560 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11561 Remove unused macros.
11563 * category.c (hash_get_category_set): Remove unused local var.
11564 (copy_category_table): Now static, since it's not used elsewhere.
11565 * character.c (string_count_byte8): Likewise.
11567 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11568 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11570 * chartab.c (copy_sub_char_table): Now static, since it's not used
11572 (sub_char_table_ref_and_range, char_table_ref_and_range):
11573 Rename locals to avoid shadowing.
11574 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11576 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11577 (BIDI_BOB): Remove unused macro.
11579 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11580 deduce are never used uninitialized.
11581 * term.c (encode_terminal_code): Likewise.
11583 * term.c (encode_terminal_code): Now static. Remove unused local.
11585 * tparam.h: New file.
11586 * term.c, tparam.h: Include it.
11587 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11588 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11589 Move these decls to tparam.h, and make them agree with what
11590 is actually in tparam.c. The previous trick of using incompatible
11591 decls in different modules does not conform to the C standard.
11592 All callers of tparam changed to use tparam's actual API.
11593 * tparam.c (tparam1, tparam, tgoto):
11594 Use const pointers where appropriate.
11596 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11597 * cm.h (struct cm): Likewise.
11598 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11599 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11600 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11601 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11602 (turn_on_face, init_tty): Likewise.
11603 * termchar.h (struct tty_display_info): Likewise.
11605 * term.c (term_mouse_position): Rename local to avoid shadowing.
11607 * alloc.c (mark_ttys): Move decl from here ...
11608 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11610 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11612 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11614 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11616 * search.c (compile_pattern_1): Remove argument regp, unused since
11617 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11618 (compile_pattern): Don't pass it.
11620 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11622 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11623 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11625 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11627 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11629 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11630 gdk_window_get_screen, gdk_window_get_geometry,
11631 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11632 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11633 (xg_get_pixbuf_from_pixmap): New function.
11634 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11635 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11636 Call xg_get_pixbuf_from_pixmap instead of
11637 gdk_pixbuf_get_from_drawable.
11638 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11639 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11640 (xg_check_special_colors): Use GtkStyleContext and its functions
11642 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11643 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11644 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11645 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11646 Call gtk_widget_get_preferred_size.
11647 (xg_frame_resized): gdk_window_get_geometry only takes 5
11649 (xg_win_to_widget, xg_event_is_for_menubar):
11650 Call gdk_x11_window_lookup_for_display.
11651 (xg_set_widget_bg): New function.
11652 (delete_cb): New function.
11653 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11654 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11655 (xg_set_background_color): Call xg_set_widget_bg.
11656 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11657 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11658 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11659 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11661 (update_frame_tool_bar): Call gtk_widget_hide.
11662 (xg_initialize): Use GDK_KEY_g.
11664 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11666 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11668 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11669 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11670 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11672 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11674 * w32xfns.c (select_palette): Check success of RealizePalette against
11675 GDI_ERROR, not zero.
11677 See ChangeLog.11 for earlier changes.
11679 ;; Local Variables:
11683 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11685 This file is part of GNU Emacs.
11687 GNU Emacs is free software: you can redistribute it and/or modify
11688 it under the terms of the GNU General Public License as published by
11689 the Free Software Foundation, either version 3 of the License, or
11690 (at your option) any later version.
11692 GNU Emacs is distributed in the hope that it will be useful,
11693 but WITHOUT ANY WARRANTY; without even the implied warranty of
11694 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11695 GNU General Public License for more details.
11697 You should have received a copy of the GNU General Public License
11698 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.