1 2012-06-12 Glenn Morris <rgm@gnu.org>
3 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4 Move BROKEN_SIGIO to configure.
6 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
7 Move NO_TERMIO to configure.
9 2012-06-12 Chong Yidong <cyd@gnu.org>
11 * image.c (imagemagick_load_image): Use MagickFlattenImage if
12 MagickMergeImageLayers is undefined. Use pixel pusher loop if
13 MagickExportImagePixels is undefined.
15 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
17 * image.c (imagemagick_load_image): Remove unused label.
19 2012-06-11 Glenn Morris <rgm@gnu.org>
21 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
22 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
23 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
24 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
26 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
28 * alloc.c (make_byte_code): New function.
29 (Fmake_byte_code): Use it. Don't purify here.
30 * lread.c (read1): Use it as well to avoid extra allocation.
32 2012-06-11 Chong Yidong <cyd@gnu.org>
34 * image.c (imagemagick_load_image): Implement transparency.
36 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
38 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
39 account for preceding backslashes. (Bug#11663)
41 2012-06-09 Chong Yidong <cyd@gnu.org>
43 * term.c: Support italics in capable terminals (Bug#9652).
44 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
45 (turn_on_face): Output using TS_enter_italic_mode if available.
46 Don't handle unused blinking and alt-charset cases.
47 (turn_off_face): Handle italic case; discard unused tty_blinking_p
48 and tty_alt_charset_p cases.
49 (tty_capable_p, init_tty): Support italics.
51 * termchar.h (struct tty_display_info): Add field for italics.
52 Remove unused blink field.
54 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
57 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
58 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
59 tty_alt_charset_p. Add tty_italic_p.
61 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
63 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
64 dbus_type_is_basic if available.
65 (xd_extract_signed, xd_extract_unsigned): Rename from
66 extract_signed and extract_unsigned, respectively. Adapt callers.
68 2012-06-09 Chong Yidong <cyd@gnu.org>
70 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
72 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
75 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
77 * xdisp.c (vmessage): Treat frame message as multibyte.
78 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
79 would generate the diagnostic "Making \302\247 buffer-local while
82 2012-06-08 Eli Zaretskii <eliz@gnu.org>
84 * dispnew.c (showing_window_margins_p): Undo last change, which
85 was done due to an inadvertent commit.
86 (adjust_frame_glyphs_for_frame_redisplay): Do call
87 showing_window_margins_p.
89 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
91 * eval.c (Fmake_var_non_special): New primitive.
92 (syms_of_eval): Defsubr it.
93 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
95 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
97 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
98 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
100 2012-06-08 Eli Zaretskii <eliz@gnu.org>
102 * alloc.c (allocate_vectorlike): Fix last change.
104 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
106 Block-based vector allocation of small vectors.
107 * lisp.h (struct vectorlike_header): New field `nbytes',
108 adjust comment accordingly.
109 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
110 to denote vector blocks. Adjust users (live_vector_p,
111 mark_maybe_pointer, valid_lisp_object_p) accordingly.
112 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
113 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
114 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
115 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
116 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
117 (roundup_size): New constant.
118 (struct vector_block): New data type.
119 (vector_blocks, vector_free_lists, zero_vector): New variables.
120 (all_vectors): Rename to `large_vectors'.
121 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
122 (sweep_vectors): New functions.
123 (allocate_vectorlike): Return `zero_vector' as the only vector of
124 0 items. Allocate new vector from block if vector size is less than
125 or equal to VBLOCK_BYTES_MAX.
126 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
127 (init_alloc_once): Add call to init_vectors.
129 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
131 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
133 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
135 * doprnt.c (doprnt): Truncate multibyte char correctly.
136 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
137 would mishandle a string argument "Xc" if X was a multibyte
138 character of length 2: it would truncate after X's first byte
139 rather than including all of X.
141 2012-06-06 Chong Yidong <cyd@gnu.org>
143 * buffer.c (word_wrap): Doc fix.
145 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
147 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
149 2012-06-03 Glenn Morris <rgm@gnu.org>
151 * xdisp.c (tool-bar-style): Doc fix.
153 2012-06-03 Ulrich Müller <ulm@gentoo.org>
155 * Makefile.in (PAXCTL): Define.
156 (temacs$(EXEEXT)): Disable memory randomization for the temacs
157 binary via PaX flags if the paxctl utility is available.
158 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
159 Restore PaX flags to their default. (Bug#11398)
161 2012-06-03 Chong Yidong <cyd@gnu.org>
163 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
166 2012-06-03 Chong Yidong <cyd@gnu.org>
168 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
169 (note_mode_line_or_margin_highlight): If there is no help echo,
170 use mode-line-default-help-echo. Handle the case where the mouse
171 position is past the end of the mode line string.
173 * buffer.c (buffer_local_value_1): New function, split from
174 Fbuffer_local_value; can return Qunbound.
175 (Fbuffer_local_value): Use it.
176 (Vmode_line_format): Docstring tweaks.
178 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
180 * sysdep.c (system_process_attributes): Improve comment.
182 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
184 * keyboard.c: Export real-this-command to Elisp.
185 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
186 and DEFVAR it. Update all users.
188 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
190 * minibuf.c (Fassoc_string): Remove duplicate declaration.
192 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
193 Convert pctcpu and pctmem to Lisp float properly.
194 Let the compiler fold better, as 100.0/0x8000 is exact.
196 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
198 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
201 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
203 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
205 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
207 For a 'struct window', replace some Lisp_Object fields to
208 bitfields where appropriate, remove unused fields.
209 * window.h (struct window): Remove unused 'last_mark_x' and
210 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
211 change it's type from Lisp_Object to bitfield.
212 Change type of 'force_start', 'optional_new_start',
213 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
214 fields from Lisp_Object to bitfield. Adjust users accordingly.
216 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
218 Pacify gcc -Wdouble-precision when using Xaw.
219 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
220 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
221 Use 'float' consistently, rather than 'float' in most places
222 and 'double' in a couple of places.
224 2012-05-31 Eli Zaretskii <eliz@gnu.org>
226 * xdisp.c (handle_stop): Detect whether we have overlay strings
227 loaded by testing it->current.overlay_string_index to be
228 non-negative, instead of checking whether n_overlay_strings is
229 positive. (Bug#11587)
231 2012-05-31 Chong Yidong <cyd@gnu.org>
233 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
235 * doc.c (Fsubstitute_command_keys): Doc fix.
237 2012-05-31 Eli Zaretskii <eliz@gnu.org>
239 * search.c (search_buffer): Remove calls to
240 r_alloc_inhibit_buffer_relocation, as it is now called by
241 maybe_unify_char, which was the cause of relocation of buffer text
244 2012-05-31 Eli Zaretskii <eliz@gnu.org>
246 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
247 for the duration of call to load_charset, to avoid problems with
248 callers of maybe_unify_char that access buffer text through C
251 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
252 decrement the inhibition flag, instead of just setting or
255 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
257 Remove obsolete '#define static' cruft.
258 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
259 This #undef was "temporary" in 2000; it is no longer needed
260 now that '#define static' has gone away.
261 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
262 (gray_bitmap_bits): Remove; no longer needed.
263 All uses replaced with definiens.
264 * xterm.c: Include "bitmaps/gray.xbm".
266 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
268 Clean up __executable_start, monstartup when --enable-profiling.
269 The following changes affect the code only when profiling.
270 * dispnew.c (__executable_start): Rename from safe_bcopy.
271 Define only on platforms that need it.
272 * emacs.c: Include <sys/gmon.h> when profiling.
273 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
274 (__executable_start): Remove decl, since lisp.h does it now.
275 (safe_bcopy): Remove decl; no longer has that name.
276 (main): Coalesce #if into single bit of code, for simplicity.
277 Cast pointers to uintptr_t, since standard libraries want integers
279 * lisp.h (__executable_start): New decl.
281 2012-05-31 Glenn Morris <rgm@gnu.org>
283 * image.c (Fimagemagick_types): Doc fix.
285 2012-05-30 Jim Meyering <meyering@redhat.com>
287 * callproc.c (Fcall_process_region): Include directory component
288 in mkstemp error message (Bug#11586).
290 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
292 * alloc.c, lisp.h (make_pure_vector): Now static.
294 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
296 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
298 (Fautoload): Do the hash-doc more carefully.
299 * data.c (Fdefalias): Purify definition, except for keymaps.
300 (Qdefun): Move from eval.c.
301 * lisp.h (Qdefun): Remove.
302 * lread.c (read1): Tiny simplification.
304 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
306 Do not create empty overlays with the evaporate property (Bug#9642).
307 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
308 Bug#9642, but explicitly check that the buffer the overlay would
309 be moved to is live and rearrange lines to make sure that errors
310 will not put the overlay in an inconsistent state.
311 (Fdelete_overlay): Cosmetics.
313 2012-05-28 Eli Zaretskii <eliz@gnu.org>
315 * w32term.c (my_bring_window_to_top): New function.
316 (x_raise_frame): Use handle returned by DeferWindowPos, which
317 could be different from the original one.
318 Call my_bring_window_to_top instead of my_set_foreground_window.
321 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
322 by calling BringWindowToTop.
324 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
325 (WM_EMACS_END): Increase by one.
327 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
329 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
330 This avoids undefined behavior that might cause the eassert
331 to not catch an out-of-range value.
333 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
335 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
338 2012-05-27 Eli Zaretskii <eliz@gnu.org>
340 * bidi.c (bidi_mirror_char): Fix last change.
342 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
344 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
345 when referring to sectname field in printf format.
347 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
349 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
350 Only r_alloc_inhibit_buffer_relocation needed to be added;
351 the others were already declared.
353 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
354 before checking whether it's out of range. Put the check inside
356 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
358 2012-05-27 Ken Brown <kbrown@cornell.edu>
360 * callproc.c (Fcall_process): Restore a line that was accidentally
361 commented out in the 2011-02-13 change (bug#11547).
363 2012-05-27 Eli Zaretskii <eliz@gnu.org>
365 * lisp.h [REL_ALLOC]: Add prototypes for external functions
368 * buffer.c [REL_ALLOC]: Remove prototypes of
369 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
370 they are now on lisp.h.
372 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
374 * search.c (search_buffer): Use it to inhibit relocation of buffer
375 text while re_search_2 is doing its job, because re_search_2 is
376 passed C pointers to buffer text. (Bug#11519)
378 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
381 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
382 state after an additional call to move_it_in_display_line_to, keep
383 the values of it->max_ascent and it->max_descent found for the
385 (pos_visible_p): Revert the comparison against bottom_y to what it
386 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
389 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
391 Fix coding-related core dumps with gcc -ftrapv.
392 The code was computing A - B, where A and B are pointers, and B is
393 random garbage. This can lead to core dumps on platforms that
394 have special pointer registers, and it also leads to core dumps on
395 x86-64 when compiled with gcc -ftrapv. The fix is to compute
396 A - B only when B is initialized properly.
397 * coding.c (coding_set_source, coding_set_destination): Return void.
398 (coding_change_source, coding_change_destinations): New functions,
399 with the old behaviors of coding_set_source and coding_set_destination.
400 All callers that need an offset changed to use these new functions.
402 2012-05-26 Glenn Morris <rgm@gnu.org>
404 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
406 2012-05-26 Eli Zaretskii <eliz@gnu.org>
408 Extend mouse support on W32 text-mode console.
409 * xdisp.c (draw_row_with_mouse_face):
410 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
412 * w32console.c: Include window.h.
413 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
415 (initialize_w32_display): Initialize mouse-highlight data.
417 * w32inevt.c: Include termchar.h and window.h.
418 (do_mouse_event): Support mouse-autoselect-window. When the mouse
419 moves, call note_mouse_highlight. If help_echo changed, call
420 gen_help_event to produce help-echo message in the echo area.
421 Call clear_mouse_face if mouse_face_hidden is set in the mouse
424 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
426 * lread.c (read1): Simplify slightly to avoid an overflow warning
427 with GCC 4.7.0 on x86-64.
429 2012-05-26 Eli Zaretskii <eliz@gnu.org>
431 * bidi.c (bidi_mirror_char): Revert last change: an int is
432 definitely wide enough here.
434 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
436 Fix integer width and related bugs (Bug#9874).
437 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
438 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
439 (string_bytes, check_sblock, allocate_string_data):
440 (compact_small_strings, Fmake_bool_vector, make_string)
441 (make_unibyte_string, make_multibyte_string)
442 (make_string_from_bytes, make_specified_string)
443 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
444 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
447 (allocate_pseudovector):
448 Use int, not EMACS_INT, where int is wide enough.
449 (inhibit_garbage_collection, Fgarbage_collect):
450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
451 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
452 int might not be wide enough.
453 (bidi_cache_search, bidi_cache_find, bidi_init_it)
454 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
455 (bidi_at_paragraph_end, bidi_find_paragraph_start)
456 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
457 (bidi_level_of_next_char, bidi_move_to_visually_next):
458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
459 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
460 (Fkill_buffer, Fset_buffer_major_mode)
461 (advance_to_char_boundary, Fbuffer_swap_text)
462 (Fset_buffer_multibyte, overlays_at, overlays_in)
463 (overlay_touches_p, struct sortvec, record_overlay_string)
464 (overlay_strings, recenter_overlay_lists)
465 (adjust_overlays_for_insert, adjust_overlays_for_delete)
466 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
467 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
468 (Foverlay_recenter, last_overlay_modification_hooks_used)
469 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 (validate_region): Omit unnecessary test for b <= e,
472 since that's guaranteed by the previous test.
473 (adjust_overlays_for_delete): Avoid pos + length overflow.
474 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
475 (report_overlay_modification):
476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
477 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
478 Omit pointer cast, which isn't needed anyway, and doesn't work
479 after the EMACS_INT -> ptrdiff_t change.
480 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
481 * buffer.h: Adjust decls to match defn changes elsewhere.
482 (struct buffer_text, struct buffer):
483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
484 Use EMACS_INT, not int, where int might not be wide enough.
485 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
486 not int, to avoid needless 32-bit limit on 64-bit hosts.
487 (exec_byte_code): Use tighter memory-full test, one that checks
488 for alloca overflow. Don't compute the address of the object just
489 before an array, as that's not portable. Use EMACS_INT, not
490 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
491 * callint.c (Fcall_interactively):
492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
493 * callproc.c (call_process_kill, Fcall_process):
494 Don't assume pid_t fits into an Emacs fixnum.
495 (call_process_cleanup, Fcall_process, child_setup):
496 Don't assume pid_t fits into int.
497 (call_process_cleanup, Fcall_process, delete_temp_file)
498 (Fcall_process_region):
499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
500 (Fcall_process): Simplify handling of volatile integers.
501 Use int, not EMACS_INT, where int will do.
502 * casefiddle.c (casify_object, casify_region, operate_on_word)
503 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 (casify_object): Avoid integer overflow when overallocating buffer.
506 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
507 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
508 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
509 * category.h (CATEGORYP): Don't assume arg is nonnegative.
510 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
511 integers are now checked earlier. All uses replaced with XINT.
513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
514 For CCL_MapSingle, check that content and value are in int range.
515 (ccl_driver, Fregister_code_conversion_map):
516 Check that Vcode_version_map_vector is a vector.
517 (resolve_symbol_ccl_program): Check that vector header is in range.
518 Always copy the vector, so that we can check its contents reliably
519 now rather than having to recheck each instruction as it's being
520 executed. Check that vector words fit in 'int'.
521 (ccl_get_compiled_code, Fregister_ccl_program)
522 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
523 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
524 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
525 contents are in range.
526 (Fccl_execute_on_string): Check that status is in range.
527 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
528 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
529 Accept and return EMACS_INT, not int, because callers can pass values
531 (c_string_width, strwidth, lisp_string_width, chars_in_text)
532 (multibyte_chars_in_text, parse_str_as_multibyte)
533 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
534 (str_as_unibyte, str_to_unibyte, string_count_byte8)
535 (string_escape_byte8, Fget_byte):
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
538 avoid mishandling large integers.
539 * character.h: Adjust decls to match defn changes elsewhere.
540 * charset.c (load_charset_map_from_file, find_charsets_in_text)
541 (Ffind_charset_region):
542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
543 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
544 (load_charset_map_from_vector, Fdefine_charset_internal):
545 Don't assume fixnum fits in int.
546 (load_charset_map_from_vector, Fmap_charset_chars):
547 Remove now-unnecessary CHECK_NATNUMs.
548 (Fdefine_charset_internal): Check ranges here, more carefully.
549 Don't rely on undefined behavior with signed left shift overflow.
550 Don't assume unsigned int fits into fixnum, or that fixnum fits
551 into unsigned int. Don't require max_code to be a valid fixnum;
552 that's not true for gb10830 4-byte on a 32-bit host. Allow
553 invalid_code to be a cons, for the same reason. Require code_offset
554 to be a character. Avoid int overflow if max_char is close
556 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
557 this is intended anyway and avoids some undefined behavior.
558 (load_charset_map): Pass unsigned, not int, as 2nd arg of
559 INDEX_TO_CODE_POINT, as that's what it expects.
560 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
561 * charset.h (DECODE_CHAR): Return int, not unsigned;
562 this is what was intended anyway, and it avoids undefined behavior.
563 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
564 integer-overflow issues.
565 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
566 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
567 where the argument is EMACS_INT, and this behavior is not intended.
568 * chartab.c (Fmake_char_table, Fset_char_table_range)
569 (uniprop_get_decoder, uniprop_get_encoder):
570 Don't assume fixnum fits in int.
571 * cmds.c (move_point): New function, that does the gist of
572 Fforward_char and Fbackward_char, but does so while checking
573 for integer overflow more accurately.
574 (Fforward_char, Fbackward_char): Use it.
575 (Fforward_line, Fend_of_line, internal_self_insert)
576 (internal_self_insert):
577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
578 Fix a FIXME, by checking for integer overflow when calculating
579 target_clm and actual_clm.
580 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
581 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
582 (ASSURE_DESTINATION, coding_alloc_by_realloc)
583 (coding_alloc_by_making_gap, alloc_destination)
584 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
585 (encode_coding_utf_16, detect_coding_emacs_mule)
586 (decode_coding_emacs_mule, encode_coding_emacs_mule)
587 (detect_coding_iso_2022, decode_coding_iso_2022)
588 (encode_invocation_designation, encode_designation_at_bol)
589 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
590 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
591 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
592 (encode_coding_ccl, encode_coding_raw_text)
593 (detect_coding_charset, decode_coding_charset)
594 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
595 (produce_composition, produce_charset, produce_annotation)
596 (decode_coding, handle_composition_annotation)
597 (handle_charset_annotation, consume_chars, decode_coding_gap)
598 (decode_coding_object, encode_coding_object, detect_coding_system)
599 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
600 (code_convert_region, code_convert_string)
601 (Fdefine_coding_system_internal)
602 (coding_set_source, coding_set_destination):
603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
604 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
605 (Fdefine_coding_system_internal):
606 Don't assume fixnums fit in int.
607 (decode_coding_gap, decode_coding_object, encode_coding_object)
608 (Fread_coding_system, Fdetect_coding_region)
609 (Funencodable_char_position, Fcheck_coding_systems_region)
610 (get_translation, handle_composition_annotation, consume_chars):
611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
612 (consume_chars): Rewrite to not calculate an address outside buffer.
613 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
614 Don't access memory outside of the args array.
615 (Fdefine_coding_system_internal): Check for charset-id overflow.
616 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
617 result of ENCODE_CHAR.
618 * coding.h: Adjust decls to match defn changes elsewhere.
619 (struct coding_system):
620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
621 * composite.c (get_composition_id, find_composition)
622 (run_composition_function, update_compositions)
623 (compose_text, composition_gstring_put_cache)
624 (composition_gstring_p, composition_gstring_width)
625 (fill_gstring_header, fill_gstring_body, autocmp_chars)
626 (composition_compute_stop_pos, composition_reseat_it)
627 (composition_update_it, struct position_record)
628 (find_automatic_composition, composition_adjust_point)
629 (Fcomposition_get_gstring, Ffind_composition_internal):
630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
631 (update_compositions):
632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
633 * composite.h: Adjust decls to match defn changes elsewhere.
634 (struct composition):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
636 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
637 Do not attempt to compute the address of the object just before a
638 buffer; this is not portable.
640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
641 (Faset): Use int, not EMACS_INT, where int is wide enough.
642 (Fstring_to_number): Don't assume fixnums fit in int.
643 (Frem): Don't assume arg is nonnegative.
644 * dbusbind.c (xd_append_arg): Check for integers out of range.
645 (Fdbus_call_method): Don't overflow the timeout int.
646 (extract_signed, extract_unsigned): New functions.
647 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
648 (xd_get_connection_references): Return ptrdiff_t, not int.
650 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
652 Use int, not unsigned, where the dbus API uses int.
653 (Fdbus_message_internal): Don't overflow mtype.
654 (syms_of_dbusbind): Allocate right-sized buffer for integers.
655 * dired.c (directory_files_internal, file_name_completion, scmp)
656 (file_name_completion_stat):
657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
658 (file_name_completion): Don't overflow matchcount.
659 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
660 * dispextern.h: Adjust decls to match defn changes elsewhere.
661 (struct text_pos, struct glyph, struct bidi_saved_info)
662 (struct bidi_string_data, struct bidi_it, struct composition_it)
664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
665 (struct display_pos, struct composition_it, struct it):
666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
667 * dispnew.c (increment_matrix_positions)
668 (increment_row_positions, mode_line_string)
669 (marginal_area_string):
670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
671 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
673 (duration_to_sec_usec): New function, to check for overflow better.
674 (Fsleep_for, sit_for): Use it.
675 * doc.c (get_doc_string, store_function_docstring):
676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
677 (get_doc_string, Fsnarf_documentation):
678 Use int, not EMACS_INT, where int is wide enough.
680 Use SAFE_ALLOCA, not alloca.
681 Check for overflow when converting EMACS_INT to off_t.
683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
684 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
685 Don't assume uid_t fits into fixnum.
686 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
687 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
688 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
689 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
690 (general_insert_function)
691 (Finsert_char, make_buffer_string, make_buffer_string_both)
692 (update_buffer_properties, Fbuffer_substring)
693 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
694 (Fsubst_char_in_region, check_translation)
695 (Ftranslate_region_internal, save_restriction_restore, Fformat)
696 (transpose_markers, Ftranspose_regions):
697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
698 (clip_to_bounds): Move to lisp.h as an inline function).
699 (Fconstrain_to_field): Don't assume integers are nonnegative.
700 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
701 (Fsubst_char_in_region, Fsave_restriction):
702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
703 (Femacs_pid): Don't assume pid_t fits into fixnum.
704 (lo_time): Use int, not EMACS_INT, when int suffices.
705 (lisp_time_argument): Check for usec out of range.
706 (Fencode_time): Don't assume fixnum fits in int.
707 (Fuser_login_name, Fuser_full_name): Signal an error
708 if a uid argument is out of range, rather than relying on
710 (Fformat_time_string): Remove now-unnecessary check.
711 lisp_time_argument checks for out-of-range usec now.
712 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
713 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
714 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
715 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
716 (init_cmdargs, Fdump_emacs):
717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
718 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
719 the bottom (typically) 32 bits of the fixnum.
720 * eval.c (specpdl_size, call_debugger):
721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
722 (when_entered_debugger, Fbacktrace_debug):
723 Don't assume fixnum can fit in int.
724 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
725 the object just before a buffer; this is not portable.
726 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
727 (grow_specpdl, unbind_to):
728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
729 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
730 (grow_specpdl): Simplify allocation by using xpalloc.
731 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
732 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
733 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
735 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
738 (Fcopy_file, non_regular_nbytes, read_non_regular)
739 (Finsert_file_contents):
740 Use int, not EMACS_INT, where int is wide enough.
741 (READ_BUF_SIZE): Verify that it fits in int.
742 (Finsert_file_contents): Check that counts are in proper range,
743 rather than assuming fixnums fit into ptrdiff_t etc.
744 Don't assume fixnums fit into int.
745 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
746 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
747 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
748 (string_char_to_byte, string_byte_to_char)
749 (string_make_multibyte, string_to_multibyte)
750 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
751 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
752 (substring_both, Fdelete, internal_equal, Ffillarray)
753 (Fclear_string, mapcar1)
754 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
755 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
756 (larger_vector, make_hash_table, maybe_resize_hash_table)
757 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
758 (Fmaphash, secure_hash):
759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
760 (concat): Check for string index and length overflow.
761 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 (larger_vector): New API (vec, incr_min, size_max) replaces old
765 one (vec, new_size, init). This catches size overflow.
766 INIT was removed because it was always Qnil.
768 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
769 the upper bound on a hash table index size.
770 (make_hash_table, maybe_resize_hash_table): Use it.
771 (secure_hash): Computer start_byte and end_byte only after
772 they're known to be in ptrdiff_t range.
773 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
774 (Ffont_get_glyphs, Ffont_at):
775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
776 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
777 (Flist_fonts, Fopen_font):
778 Don't assume fixnum can fit in int.
779 (check_gstring): Don't assume index can fit in int.
780 (font_match_p): Check that fixnum is a character, not a nonnegative
781 fixnum, since the later code needs to stuff it into an int.
782 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
783 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
784 conversion overflow issues.
785 (Fopen_font): Check for integer out of range.
786 (Ffont_get_glyphs): Don't assume index can fit in int.
787 * font.h: Adjust decls to match defn changes elsewhere.
788 * fontset.c (reorder_font_vector): Redo score calculation to avoid
790 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
791 printmax_t, where ptrdiff_t is wide enough.
792 (Finternal_char_font):
793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
794 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
795 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
796 (Fset_frame_position, x_set_frame_parameters)
797 (x_set_line_spacing, x_set_border_width)
798 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
799 Check that fixnums are in proper range for system types.
800 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
802 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
803 Use SAFE_ALLOCA_LISP, not alloca.
804 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
805 intptr_t is wide enough.
806 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
807 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
808 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
809 Check for fixnum out of range.
810 * ftfont.c (ftfont_list): Don't assume index fits in int.
811 Check that fixnums are in proper range for system types.
812 (ftfont_shape_by_flt):
813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
814 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
816 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
817 Check that fixnums are in proper range for system types.
818 * gnutls.h: Adjust decls to match defn changes elsewhere.
819 * gtkutil.c (xg_dialog_run):
820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
821 (update_frame_tool_bar):
822 Check that fixnums are in proper range for system types.
823 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
824 (lookup_image): Check that fixnums are in range for system types.
825 * indent.c (last_known_column, last_known_column_point):
826 (current_column_bol_cache):
827 (skip_invisible, current_column, check_display_width):
828 (check_display_width, scan_for_column, current_column_1)
829 (Findent_to, Fcurrent_indentation, position_indentation)
830 (indented_beyond_p, Fmove_to_column, compute_motion):
831 (Fcompute_motion, Fvertical_motion):
832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
833 (last_known_column_modified): Use EMACS_INT, not int.
834 (check_display_width):
836 Check that fixnums and floats are in proper range for system types.
837 (compute_motion): Don't assume index or fixnum fits in int.
838 (compute_motion, Fcompute_motion):
839 Use int, not EMACS_INT, when it is wide enough.
840 (vmotion): Omit local var start_hpos that is always 0; that way
841 we don't need to worry about overflow in expressions involving it.
842 * indent.h: Adjust decls to match defn changes elsewhere.
844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
845 Use int, not EMACS_INT, where int is wide enough.
846 Remove unused members ovstring_chars_done and tab_offset;
848 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
849 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
850 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
851 (make_gap, copy_text, insert, insert_and_inherit)
852 (insert_before_markers, insert_before_markers_and_inherit)
853 (insert_1, count_combining_before, count_combining_after)
854 (insert_1_both, insert_from_string)
855 (insert_from_string_before_markers, insert_from_string_1)
856 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
857 (adjust_after_replace, adjust_after_insert, replace_range)
858 (replace_range_2, del_range, del_range_1, del_range_byte)
859 (del_range_both, del_range_2, modify_region)
860 (prepare_to_modify_buffer, signal_before_change)
861 (signal_after_change, Fcombine_after_change_execute):
862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
863 * intervals.c (traverse_intervals, rotate_right, rotate_left)
864 (balance_an_interval, split_interval_right, split_interval_left)
865 (find_interval, next_interval, update_interval)
866 (adjust_intervals_for_insertion, delete_node, delete_interval)
867 (interval_deletion_adjustment, adjust_intervals_for_deletion)
868 (static_offset_intervals, offset_intervals)
869 (merge_interval_right, merge_interval_left, make_new_interval)
870 (graft_intervals_into_buffer, temp_set_point_both)
871 (temp_set_point, set_point, adjust_for_invis_intang)
872 (set_point_both, move_if_not_intangible, get_property_and_range)
873 (get_local_map, copy_intervals, copy_intervals_to_string)
874 (compare_string_intervals, set_intervals_multibyte_1):
875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
876 * intervals.h: Adjust decls to match defn changes elsewhere.
878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
879 * keyboard.c (this_command_key_count, this_single_command_key_start)
880 (before_command_key_count, before_command_echo_length, echo_now)
881 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
882 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
883 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
884 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
886 (last_non_minibuf_size, last_point_position, echo_truncate)
887 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
888 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
889 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
890 (stuff_buffered_input):
891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
892 (last_auto_save, command_loop_1, read_char):
893 Use EMACS_INT, not int, to avoid integer overflow.
894 (record_char): Avoid overflow in total_keys computation.
895 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
896 * keyboard.h: Adjust decls to match defn changes elsewhere.
897 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
898 (Fkey_description, Fdescribe_vector, Flookup_key):
899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
900 (click_position): New function, to check that positions are in range.
901 (Fcurrent_active_maps):
903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
904 (Faccessible_keymaps, Fkey_description):
905 (preferred_sequence_p):
906 Don't assume fixnum can fit into int.
907 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
908 Check for integer overflow in size calculations.
909 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
910 avoid mishandling large integers.
911 * lisp.h: Adjust decls to match defn changes elsewhere.
912 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
913 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
914 (struct Lisp_Marker):
915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
916 (clip_to_bounds): Now an inline function, moved here from editfns.c.
917 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
918 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
920 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
921 Assume the arg has valid form, since it always does.
922 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
923 unsigned integer system type.
924 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
925 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
927 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
928 (duration_to_sec_usec): New decl.
929 * lread.c (read_from_string_index, read_from_string_index_byte)
930 (read_from_string_limit, readchar, unreadchar, openp)
931 (read_internal_start, read1, oblookup):
932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
933 (Fload, readevalloop, Feval_buffer, Feval_region):
934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
935 (openp): Check for out-of-range argument to 'access'.
936 (read1): Use int, not EMACS_INT, where int is wide enough.
937 Don't assume fixnum fits into int.
938 Fix off-by-one error that can read outside a buffer.
939 (read_filtered_event): Use duration_to_sec_usec
940 to do proper overflow checking on durations.
941 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
943 (Fexecute_kbd_macro):
944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
945 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
946 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
947 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
948 (set_marker_both, set_marker_restricted_both, marker_position)
949 (marker_byte_position, Fbuffer_has_markers_at):
950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
951 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
952 * menu.c (ensure_menu_items): Rename from grow_menu_items.
953 It now merely ensures that the menu is large enough, without
954 necessarily growing it, as this avoids some integer overflow issues.
956 (keymap_panes, parse_single_submenu, Fx_popup_menu):
957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
958 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
959 Use SAFE_ALLOCA_LISP, not alloca.
960 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
961 to EMACS_INT. Check that fixnums are in proper range for system types.
962 * minibuf.c (minibuf_prompt_width, string_to_object)
963 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
964 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
966 (get_minibuffer, read_minibuf_unwind):
967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
968 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
969 this simplifies overflow checking. All callers changed.
970 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
973 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
974 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
975 Check that fixnums are in proper range for system types.
976 (Fx_create_frame, Fx_show_tip):
977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
978 * nsfont.m (ns_findfonts, nsfont_list_family):
979 Don't assume fixnum fits in long.
980 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
982 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
984 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
986 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
987 (PRINTDECLARE, PRINTPREPARE):
988 (strout, print_string):
989 (print, print_preprocess, print_check_string_charset_prop)
991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
993 (temp_output_buffer_setup, Fprin1_to_string, print_object):
994 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
995 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
996 (printchar, strout): Use xpalloc to catch size calculation overflow.
997 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
998 (print_error_message): Use SAFE_ALLOCA, not alloca.
999 (print_object): Use int, not EMACS_INT, where int is wide enough.
1000 (print_depth, new_backquote_output, print_number_index):
1001 Use ptrdiff_t, not int, where int might not be wide enough.
1002 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1003 (Fset_process_window_size, Fformat_network_address)
1004 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1006 Check that fixnums are in proper range for system types.
1007 (Fsignal_process): Simplify by avoiding a goto.
1008 Check for process-ids out of pid_t range rather than relying on
1010 (process_tick, update_tick): Use EMACS_INT, not int.
1011 (Fformat_network_address, read_process_output, send_process)
1012 (Fprocess_send_region, status_notify):
1013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1014 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1015 (wait_reading_process_output, read_process_output, exec_sentinel):
1016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1017 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1018 (Faccept_process_output): Use duration_to_sec_usec to do proper
1019 overflow checking on durations.
1020 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1021 Don't assume pid_t fits in int.
1022 * process.h (struct Lisp_Process): Members tick and update_tick
1023 are now of type EMACS_INT, not int.
1024 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1025 configured --with-wide-int.
1026 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1027 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1028 * search.c (looking_at_1, string_match_1):
1029 (fast_string_match, fast_c_string_match_ignore_case)
1030 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1031 (scan_newline, find_before_next_newline, search_command)
1032 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1033 (set_search_regs, wordify):
1036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1037 (string_match_1, search_buffer, set_search_regs):
1039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1040 (wordify): Check for overflow in size calculation.
1041 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1042 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1043 Check that fixnums are in proper range for system types.
1044 * sound.c (struct sound_device)
1045 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1047 (Fplay_sound_internal):
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 * syntax.c (struct lisp_parse_state, find_start_modiff)
1050 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1051 (Fparse_partial_sexp):
1052 Don't assume fixnums can fit in int.
1053 (struct lisp_parse_state, find_start_pos, find_start_value)
1054 (find_start_value_byte, find_start_begv)
1055 (update_syntax_table, char_quoted, dec_bytepos)
1056 (find_defun_start, prev_char_comend_first, back_comment):
1057 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1058 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1060 (Finternal_describe_syntax_value): Check that match_lisp is a
1061 character, not an integer, since the code stuffs it into int.
1062 (scan_words, scan_sexps_forward):
1063 Check that fixnums are in proper range for system types.
1065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1066 (scan_sexps_forward):
1067 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1068 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1069 * syntax.h: Adjust decls to match defn changes elsewhere.
1070 (struct gl_state_s):
1071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1072 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1073 MOST_POSITIVE_FIXNUM.
1074 * sysdep.c (wait_for_termination_1, wait_for_termination)
1075 (interruptible_wait_for_termination, mkdir):
1076 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1077 (emacs_read, emacs_write):
1078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1079 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1080 and double all fit in int.
1081 * term.c (set_tty_color_mode):
1082 Check that fixnums are in proper range for system types.
1083 * termhooks.h (struct input_event):
1084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1085 * textprop.c (validate_interval_range, interval_of)
1086 (Fadd_text_properties, set_text_properties_1)
1087 (Fremove_text_properties, Fremove_list_of_text_properties)
1088 (Ftext_property_any, Ftext_property_not_all)
1089 (copy_text_properties, text_property_list, extend_property_ranges)
1090 (verify_interval_modification):
1091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1092 (Fnext_single_char_property_change)
1093 (Fprevious_single_char_property_change):
1094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1095 (copy_text_properties):
1096 Check for integer overflow in index calculation.
1097 * undo.c (last_boundary_position, record_point, record_insert)
1098 (record_delete, record_marker_adjustment, record_change)
1099 (record_property_change):
1100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1101 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1103 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1104 (Fx_hide_tip, Fx_file_dialog):
1105 * w32menu.c (set_frame_menubar):
1106 Use ptrdiff_t, not int, for consistency with rest of code.
1107 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1108 (select_window, Fdelete_other_windows_internal)
1109 (window_scroll_pixel_based, window_scroll_line_based)
1110 (Frecenter, Fset_window_configuration):
1111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1112 (Fset_window_hscroll, run_window_configuration_change_hook)
1113 (set_window_buffer, temp_output_buffer_show, scroll_command)
1114 (Fscroll_other_window, Frecenter):
1115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1116 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1117 Don't assume fixnum fits in int.
1118 (Fset_window_scroll_bars):
1119 Check that fixnums are in proper range for system types.
1120 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1121 (string_pos, c_string_pos, number_of_chars, init_iterator)
1122 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1123 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1124 (compute_display_string_end, handle_face_prop)
1125 (face_before_or_after_it_pos, handle_invisible_prop)
1126 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1127 (display_prop_intangible_p, string_buffer_position_lim)
1128 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1129 (get_overlay_strings_1, get_overlay_strings)
1130 (iterate_out_of_display_property, forward_to_next_line_start)
1131 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1132 (get_next_display_element, set_iterator_to_next)
1133 (get_visually_first_element, compute_stop_pos_backwards)
1134 (handle_stop_backwards, next_element_from_buffer)
1135 (move_it_in_display_line_to, move_it_in_display_line)
1136 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1137 (add_to_log, message_dolog, message_log_check_duplicate)
1138 (message2, message2_nolog, message3, message3_nolog
1139 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1140 (current_message_1, truncate_echo_area, truncate_message_1)
1141 (set_message, set_message_1, store_mode_line_noprop)
1142 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1143 (text_outside_line_unchanged_p, check_point_in_composition)
1144 (reconsider_clip_changes)
1145 (redisplay_internal, set_cursor_from_row, try_scrolling)
1146 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1147 (redisplay_window, find_last_unchanged_at_beg_row)
1148 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1149 (trailing_whitespace_p, find_row_edges, display_line)
1150 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1151 (display_mode_element, store_mode_line_string)
1152 (pint2str, pint2hrstr, decode_mode_spec)
1153 (display_count_lines, display_string, draw_glyphs)
1154 (x_produce_glyphs, x_insert_glyphs)
1155 (rows_from_pos_range, mouse_face_from_buffer_pos)
1156 (fast_find_string_pos, mouse_face_from_string_pos)
1157 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1159 (safe_call, init_from_display_pos, handle_fontified_prop)
1160 (handle_single_display_spec, load_overlay_strings)
1161 (with_echo_area_buffer, setup_echo_area_for_printing)
1162 (display_echo_area, echo_area_display)
1163 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1164 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1165 (redisplay_window, dump_glyph_row, display_mode_line)
1166 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1167 (handle_display_spec, display_prop_string_p):
1168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1169 (handle_single_display_spec, build_desired_tool_bar_string)
1170 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1171 (get_specified_cursor_type):
1172 Check that fixnums are in proper range for system types.
1173 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1174 (Flookup_image_map):
1175 Don't assume fixnums fit in int.
1176 (compare_overlay_entries):
1177 Avoid mishandling comparisons due to subtraction overflow.
1178 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1179 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1180 (handle_tool_bar_click):
1181 Use int, not unsigned, since we prefer signed and the signedness
1182 doesn't matter here.
1183 (get_next_display_element, next_element_from_display_vector):
1184 Use int, not EMACS_INT, when int is wide enough.
1185 (start_hourglass): Use duration_to_sec_usec to do proper
1186 overflow checking on durations.
1187 * xfaces.c (Fbitmap_spec_p):
1188 Check that fixnums are in proper range for system types.
1189 (compare_fonts_by_sort_order):
1190 Avoid mishandling comparisons due to subtraction overflow.
1191 (Fx_family_fonts, realize_basic_faces):
1192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1194 Don't assume fixnum fits in int.
1195 Use SAFE_ALLOCA_LISP, not alloca.
1196 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1197 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1198 (face_at_buffer_position, face_for_overlay_string)
1199 (face_at_string_position):
1200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1201 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1202 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1204 Check that fixnums are in proper range for system types.
1205 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1206 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1208 (Fx_change_window_property): Don't assume fixnums fit in int.
1209 * xfont.c (xfont_chars_supported):
1210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1211 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1212 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1214 * xml.c (parse_region):
1215 * xrdb.c (magic_file_p):
1216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1217 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1218 (x_get_local_selection, x_reply_selection_request)
1219 (x_handle_selection_request, wait_for_property_change):
1220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1221 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1222 short is wide enough.
1223 (x_send_client_event): Don't assume fixnum fits in int.
1224 * xterm.c (x_x_to_emacs_modifiers):
1225 Don't assume EMACS_INT overflows nicely into int.
1226 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1228 (handle_one_xevent): NATNUMP can eval its arg twice.
1229 (x_connection_closed):
1230 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1231 * xterm.h: Adjust decls to match defn changes elsewhere.
1232 (struct scroll_bar): Use struct vectorlike_header
1233 rather than rolling our own approximation.
1234 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1236 2012-05-25 Glenn Morris <rgm@gnu.org>
1238 * lisp.mk (lisp): Update for more files being compiled now.
1240 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1242 * lread.c: Remove `read_pure' which makes no difference.
1243 (read_pure): Remove var.
1244 (unreadpure): Remove function.
1245 (readevalloop): Don't call read_list with -1 flag.
1246 (read1, read_vector): Don't test read_pure any more.
1247 (read_list): Simplify.
1249 * fileio.c, character.h: Minor style tweaks.
1251 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1253 * window.h (clip_changed): Remove useless declaration.
1255 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1257 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1258 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1260 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1263 This directory predates autoconf and is no longer needed nowadays.
1264 Move its few remaining bits of functionality to where they're needed.
1265 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1266 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1267 * m/template.h: Remove.
1268 * Makefile.in (M_FILE): Remove. All uses removed.
1269 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1270 * lisp.h (USE_LSB_TAG):
1271 * mem-limits.h (EXCEEDS_LISP_PTR):
1272 Use VAL_MAX, not VALBITS, in #if.
1273 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1274 (EMACS_UINT): Define unconditionally now.
1275 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1276 (BITS_PER_EMACS_INT): New constants, replacing
1277 what used to be in config.h, but not useful in #if.
1278 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1279 define them any more.
1280 (VAL_MAX): New macro.
1282 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1283 BITS_PER_EMACS_INT, in #if.
1284 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1285 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1286 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1287 * s/ms-w32.h (DATA_START):
1288 Move here from removed file m/intel386.h.
1289 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1290 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1292 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1294 Assume C89 or later.
1295 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1296 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1298 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1299 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1300 * textprop.c, tparam.c (NULL): Remove.
1301 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1302 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1303 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1304 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1305 * xterm.c (input_signal_count): Assume volatile works.
1307 2012-05-21 Ken Brown <kbrown@cornell.edu>
1309 * xgselect.c (xg_select): Fix first argument in call to 'select'
1312 2012-05-20 Ken Brown <kbrown@cornell.edu>
1314 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1315 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1317 2012-05-19 Ken Brown <kbrown@cornell.edu>
1319 * xfns.c (x_in_use): Remove `static' qualifier.
1320 * xterm.h (x_in_use): Declare.
1321 * xgselect.c: Include xterm.h.
1322 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1323 and `display_arg' (bug#9754).
1325 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1327 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1329 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1330 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1332 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1334 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1336 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1337 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1339 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1340 reference to image_cache->refcount.
1341 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1343 2012-05-17 Juri Linkov <juri@jurta.org>
1345 * search.c (Fword_search_regexp, Fword_search_backward)
1346 (Fword_search_forward, Fword_search_backward_lax)
1347 (Fword_search_forward_lax): Move functions to isearch.el
1348 (bug#10145, bug#11381).
1350 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1352 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1354 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1356 * lread.c (init_obarray): Declare Qt and Qnil as special.
1358 2012-05-14 Glenn Morris <rgm@gnu.org>
1360 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1361 Put "libexec" before "bin", for the sake of init_callproc_1.
1363 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1365 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1367 * unexaix.c: Port to more-recent AIX compilers.
1368 (report_error, report_error_1, make_hdr, copy_sym)
1369 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1370 Make arguments const char *, not char *, to avoid violations of C
1371 standard and to fix some AIX warnings reported by Gilles Pion.
1373 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1375 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1376 already have overlays loaded.
1377 (handle_single_display_spec): Before returning without displaying
1378 fringe bitmap, synchronize the bidi iterator with the main display
1379 iterator, by calling iterate_out_of_display_property.
1380 (iterate_out_of_display_property): Detect buffer iteration by
1381 testing that it->string is a Lisp string.
1382 (get_next_display_element): When the current object is exhausted,
1383 and there's something on it->stack, call set_iterator_to_next to
1384 proceed with what's on the stack, instead of returning zero.
1385 (set_iterator_to_next): If called at the end of a Lisp string,
1386 proceed to consider_string_end without incrementing string
1387 position. Don't increment display vector index past the end of
1388 the display vector. (Bug#11417)
1389 (pos_visible_p): Don't report a position visible when move_it_to
1390 stopped at the last line of window, which happens to be scanned
1391 backwards by the bidi iteration. (Bug#11464)
1393 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1395 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1396 and right-margin display specs even if the spec is invalid or we
1397 are on a TTY, and thus unable to display on the fringes.
1398 That's because the text with the property will not be displayed anyway,
1399 so we need to signal to the caller that this is a "replacing"
1400 display spec. This fixes display when the spec is invalid or we
1403 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1405 * unexaix.c (make_hdr): Fix typo in prototype.
1406 This bug broke the build on AIX. Problem reported by Gilles Pion.
1408 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1410 * keyboard.c (kbd_buffer_get_event): Read special events also in
1411 batch mode. (Bug#11415)
1413 2012-05-12 Glenn Morris <rgm@gnu.org>
1415 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1417 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1419 * lisp.mk (lisp): Add newcomment.elc.
1421 2012-05-12 Glenn Morris <rgm@gnu.org>
1423 * Makefile.in (MKDIR_P): New, set by configure.
1424 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1426 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1428 Remove unused function hourglass_started.
1429 * dispextern.h (hourglass_started):
1430 * w32fns.c (hourglass_started):
1431 * xdisp.c (hourglass_started): Remove.
1433 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1435 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1436 Update dependencies.
1438 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1440 * xgselect.c (xg_select): Put maxfds+1 into a var.
1441 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1443 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1445 2012-05-10 Dave Abrahams <dave@boostpro.com>
1447 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1448 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1450 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1452 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1453 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1454 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1455 Initialize xd_registered_buses.
1457 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1459 Untag more efficiently if USE_LSB_TAG.
1460 This is based on a proposal by YAMAMOTO Mitsuharu in
1461 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1462 For an admittedly artificial (nth 8000 longlist) benchmark on
1463 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1464 Emacs's overall text size by 1%.
1465 * lisp.h (XUNTAG): New macro.
1466 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1467 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1468 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1469 * eval.c (Fautoload):
1470 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1471 * frame.h (XFRAME): Use XUNTAG.
1473 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1474 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1475 Remove unportable assumptions about print widths of types like
1477 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1478 intptr_t when converting between pointer and integer, to avoid GCC
1479 warnings about wrong width.
1481 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1483 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1484 stack for each reader_thread, instead of defaulting to 8MB
1485 determined by the linker. This avoids failures in creating
1486 subprocesses on Windows 7, see the discussion in this thread:
1487 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1489 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1491 Fix up display of the *Minibuf-0* buffer in the mini window.
1492 * keyboard.c (read_char): Don't clear the echo area if there's no
1494 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1495 contents of *Minibuf-0*) if there's no message displayed in its stead.
1497 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1499 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1502 2012-05-06 Chong Yidong <cyd@gnu.org>
1504 * lisp.mk (lisp): Update.
1506 2012-05-05 Jim Meyering <meyering@redhat.com>
1508 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1510 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1512 * data.c (PUT_ERROR): New macro.
1513 (syms_of_data): Use it. Add new error type `user-error'.
1514 * undo.c (user_error): New function.
1515 (Fprimitive_undo): Use it.
1516 * print.c (print_error_message): Adjust print style for `user-error'.
1517 * keyboard.c (user_error): New function.
1518 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1520 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1522 Do not limit current-time-string to years 1000..9999.
1523 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1524 (Fcurrent_time_string): Support any year that is supported by the
1525 underlying localtime representation. Don't use asctime, as it
1526 has undefined behavior for years outside the range -999..9999.
1528 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1530 Fix race conditions involving setenv, gmtime, localtime, asctime.
1531 Without this fix, interrupts could mess up code that uses these
1532 nonreentrant functions, since setting TZ invalidates existing
1533 tm_zone or tzname values, and since most of these functions return
1534 pointers to static storage.
1535 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1536 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1537 Grow the critical sections to include not just invoking
1538 localtime/gmtime, but also accessing these functions' results
1539 including their tm_zone values if any, and any related TZ setting.
1540 (format_time_string): Last arg is now struct tm *, not struct tm **,
1541 so that the struct tm is saved in the critical section.
1542 All callers changed. Simplify allocation of initial buffer, partly
1543 motivated by the fact that memory allocation needs to be outside
1544 the critical section.
1546 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1548 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1549 with RESET_INTERVAL.
1551 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1552 Remove duplicated buffer name initialization.
1554 2012-05-02 Jim Meyering <jim@meyering.net>
1556 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1558 * xfns.c (x_window): Use xstrdup (Bug#11375).
1560 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1562 * xdisp.c (pos_visible_p): If already at a newline from the
1563 display string before the 'while' loop, don't walk back the glyphs
1564 from it3.glyph_row. Solves assertion violation when the display
1565 string begins with a newline (egg.el). (Bug#11367)
1567 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1569 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1572 2012-05-01 Glenn Morris <rgm@gnu.org>
1574 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1575 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1576 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1577 All were removed before 23.1.
1579 * dispnew.c: Remove HAVE_LIBNCURSES test;
1580 it is always true on relevant platforms.
1582 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1583 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1585 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1587 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1589 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1590 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1593 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1595 Do not avoid creating empty evaporating overlays (Bug#9642).
1596 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1597 That is, do not delete an evaporating overlay if it becomes
1598 empty after its bounds are adjusted to fit within its buffer.
1599 This fix caused other problems, and I'm reverting it until we get
1600 to the bottom of them.
1602 2012-04-27 Chong Yidong <cyd@gnu.org>
1604 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1606 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1608 * xdisp.c (pos_visible_p): If the window start position is beyond
1609 ZV, start the display from buffer beginning. Prevents assertion
1610 violation in init_iterator when the minibuffer window is scrolled
1613 * window.c (window_scroll_pixel_based): Likewise.
1615 2012-04-27 Chong Yidong <cyd@gnu.org>
1617 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1619 2012-04-27 Glenn Morris <rgm@gnu.org>
1621 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1622 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1624 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1626 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1627 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1629 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1631 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1632 display element, check also the underlying string or buffer
1633 character. (Bug#11341)
1635 * w32menu.c: Include w32heap.h.
1636 (add_menu_item): If the call to AppendMenuW (via
1637 unicode_append_menu) fails, disable Unicode menus only if we are
1638 running on Windows 9X/Me.
1640 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1642 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1643 (xgetint): Add missing shift for LSB tags.
1645 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1647 * keyboard.c (read_char): Don't wipe echo area for select window
1648 events: These might get delayed via `mouse-autoselect-window'
1651 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1653 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1654 manipulation of :loaded-from data.
1656 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1658 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1659 now a cons (bug#11311).
1661 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1663 Do not create empty overlays with the evaporate property (Bug#9642).
1664 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1665 if it becomes empty after its bounds are adjusted to fit within
1666 its buffer. Without this fix, in a nonempty buffer (let ((o
1667 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1668 yields an empty overlay that has the evaporate property, which is
1669 not supposed to happen.
1671 Fix minor GTK3 problems found by static checking.
1672 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1673 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1674 (struct _EmacsFixedClass, emacs_fixed_get_type):
1675 Move decls here from emacsgtkfixed.h, since they needn't be public.
1676 (emacs_fixed_get_type): Now static.
1677 (emacs_fixed_class_init): Omit unused local.
1678 (emacs_fixed_child_type): Remove; unused.
1679 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1680 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1681 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1682 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1683 (EMACS_FIXED_GET_CLASS): Remove; unused.
1684 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1686 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1687 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1689 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1691 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1692 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1693 (__malloc_size_t, __malloc_ptrdiff_t):
1694 Remove. All uses removed, replaced by the definiens if needed,
1695 since we can assume C89 or better now.
1696 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1697 (protect_malloc_state, align, get_contiguous_space)
1698 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1699 (malloc_atfork_handler_child, malloc_enable_thread)
1700 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1701 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1702 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1703 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1704 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1705 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1706 Define using prototypes, not old style.
1707 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1708 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1709 (align): Don't assume that signed integer overflow wraps around.
1710 Omit unused local var.
1711 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1712 (_free_internal_nolock, memalign, mallochook, reallochook):
1713 Omit no-longer-needed casts.
1714 (valloc): Use getpagesize, not __getpagesize.
1715 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1716 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1718 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1720 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1722 Move functions from C to Lisp. Make non-blocking method calls
1723 the default. Implement further D-Bus standard interfaces.
1725 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1726 (QCdbus_request_name_allow_replacement)
1727 (QCdbus_request_name_replace_existing)
1728 (QCdbus_request_name_do_not_queue)
1729 (QCdbus_request_name_reply_primary_owner)
1730 (QCdbus_request_name_reply_in_queue)
1731 (QCdbus_request_name_reply_exists)
1732 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1733 (QCdbus_registered_serial, QCdbus_registered_method)
1734 (QCdbus_registered_signal): New Lisp objects.
1735 (XD_DEBUG_MESSAGE): Use sizeof.
1736 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1737 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1738 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1739 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1740 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1741 (xd_signature, xd_append_arg): Allow float for integer types.
1742 (xd_get_connection_references): New function.
1743 (xd_get_connection_address): Rename from xd_initialize.
1744 Return cached address.
1745 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1746 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1748 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1749 Return number of refcounts.
1750 (Fdbus_get_unique_name): Make stronger parameter check.
1751 (Fdbus_message_internal): New defun.
1752 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1753 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1754 (Fdbus_send_signal, Fdbus_register_service)
1755 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1756 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1757 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1758 (Vdbus_compiled_version, Vdbus_runtime_version)
1759 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1760 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1761 (Vdbus_message_type_signal): New defvars.
1762 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1765 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1767 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1768 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1769 Do not assume ptrdiff_t is the same width as 'int'.
1771 * alloc.c: Handle unusual debugging option combinations.
1772 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1773 since the two debugging options are incompatible.
1774 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1776 (mem_init, mem_insert, mem_insert_fixup):
1777 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1778 (NEED_MEM_INSERT): Remove; no longer needed.
1780 2012-04-22 Leo Liu <sdl.web@gmail.com>
1782 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1784 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1786 * sysdep.c [__FreeBSD__]: Minor cleanups.
1787 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1788 Use Emacs indenting style more consistently. Avoid some casts.
1789 Use 'double' consistently rather than mixing 'float' and 'double'.
1791 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1793 * sysdep.c (list_system_processes, system_process_attributes):
1794 Add implementation for FreeBSD (Bug#5243).
1796 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1798 * lisp.mk (lisp): Update.
1800 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1802 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1803 It is never used otherwise.
1805 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1807 * print.c (print_preprocess): Only check print_depth if print-circle
1809 (print_object): Check for cycles even when print-circle is nil and
1810 print-gensym is t, but only check print_depth if print-circle is nil.
1812 2012-04-20 Chong Yidong <cyd@gnu.org>
1814 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1815 set the status to "failed" and ensure that sentinel is run.
1817 2012-04-20 Glenn Morris <rgm@gnu.org>
1819 * process.c (Fset_process_inherit_coding_system_flag)
1820 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1821 (Fmake_network_process, Fmake_serial_process): Doc fix.
1823 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1825 * xdisp.c (string_buffer_position_lim): Limit starting position to
1827 (set_cursor_from_row): If called for a mode-line or header-line
1828 row, return zero immediately.
1829 (try_cursor_movement): If inside continuation line, don't back up
1830 farther than the first row after the header line, if any.
1831 Don't consider the header-line row as "partially visible", even if
1832 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1834 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1836 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1839 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1840 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1842 configure: new option --enable-gcc-warnings (Bug#11207)
1843 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1844 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1845 (ALL_CFLAGS): Use new macros rather than old.
1846 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1847 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1848 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1849 -Wunused-result, -Wunused-variable. This should go away once
1850 the Emacs and Gnulib regex code is merged.
1851 (xmalloc, xrealloc): Now static.
1853 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1855 * dired.c (Fsystem_groups): Remove unused local.
1857 2012-04-17 Glenn Morris <rgm@gnu.org>
1859 * dired.c (Fsystem_users): Doc fix.
1861 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1863 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1864 (syms_of_dired): Add them.
1866 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1868 Fix minor alloc.c problems found by static checking.
1869 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1870 New extern decls, to avoid calling undeclared functions.
1871 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1872 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1873 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1874 (NEED_MEM_INSERT): New macro.
1875 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1876 Remove one incorrect comment and fix another.
1878 Fix minor ralloc.c problems found by static checking.
1879 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1880 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1881 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1882 (r_alloc_sbrk): Now static.
1884 Improve ralloc.c interface checking.
1885 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1886 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1887 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1888 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1889 [REL_ALLOC]: ... to here, to check interface.
1890 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1891 Remove decls. This fixes an "It stinks!".
1893 * alloc.c (which_symbols): Fix alignment issue / type clash.
1895 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1897 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1898 (struct Lisp_Misc_Any): Likewise.
1899 (struct Lisp_Free): Likewise.
1900 * alloc.c (union aligned_Lisp_Symbol): Define.
1901 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1902 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1903 (union aligned_Lisp_Misc): Define.
1904 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1905 aligned_Lisp_Misc instead of union Lisp_Misc.
1906 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1908 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1910 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1911 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1912 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1913 * s/netbsd.h, s/sol2-6.h:
1914 Remove definition of GC_MARK_STACK, since the default now works.
1915 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1916 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1917 no longer the default.
1918 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1920 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1922 * lread.c (lisp_file_lexically_bound_p):
1923 Fix hang at ";-*-\n" (bug#11238).
1925 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1927 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1928 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1930 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1932 * nsterm.m (constrainFrameRect): Always constrain when there is only
1933 one screen (Bug#10962).
1935 2012-04-13 Ken Brown <kbrown@cornell.edu>
1937 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1939 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1941 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1943 2012-04-11 Daniel Colascione <dancol@dancol.org>
1945 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1946 against is gone. It's better to use vfork now so that when Cygwin
1947 gains a new, working vfork, we use it automatically (bug#10398).
1949 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1951 * window.c (save_window_save): Obey window-point-insertion-type.
1953 2012-04-11 Glenn Morris <rgm@gnu.org>
1955 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1957 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1959 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1961 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1963 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1964 (force_quit_count): New var.
1965 (handle_interrupt): Use it.
1967 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1969 * w32.c (w32_delayed_load): Record the full path of the library
1970 being loaded (bug#10424).
1972 2012-04-09 Glenn Morris <rgm@gnu.org>
1974 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1975 not just in the obarray, before snarfing them. (Bug#11036)
1977 * Makefile.in ($(leimdir)/leim-list.el):
1978 Pass EMACS rather than BUILT_EMACS.
1980 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1982 * process.c (make_process):
1983 * process.h: Add integer `gnutls_handshakes_tried' member to
1986 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1987 Add convenience `GNUTLS_LOG2i' macro.
1989 * gnutls.c (gnutls_log_function2i): Convenience log function.
1990 (emacs_gnutls_read): Use new log functions,
1991 `gnutls_handshakes_tried' process member, and
1992 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1993 attempts per process (connection).
1995 2012-04-09 Chong Yidong <cyd@gnu.org>
1997 * eval.c (Fuser_variable_p, user_variable_p_eh)
1998 (lisp_indirect_variable): Functions deleted.
1999 (Fdefvar): Caller changed.
2001 * callint.c (Finteractive, Fcall_interactively):
2002 * minibuf.c (Fread_variable): Callers changed.
2004 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2006 * xdisp.c (set_cursor_from_row): If the display string appears in
2007 the buffer at position that is closer to point than the position
2008 after the display string, display the cursor on the first glyph of
2009 the display string. Fixes cursor display when a 'display' text
2010 property immediately follows invisible text. (Bug#11094)
2012 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2014 composite.c: use 'double' consistently
2015 * composite.c (get_composition_id): Use 'double' consistently
2016 instead of converting 'float' to 'double' and vice versa; this is
2017 easier to understand and avoids a GCC warning.
2019 2012-04-09 Glenn Morris <rgm@gnu.org>
2021 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2022 preparation for dumping it with emacs. (Bug#4789)
2023 (leimdir): New variable.
2024 ($(leimdir)/leim-list.el): New rule.
2025 (emacs$(EXEEXT)): Depend on leim-list.el.
2027 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2028 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2029 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2031 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2033 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2036 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2038 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2039 Remove unused local variable.
2041 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2043 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2044 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2045 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2046 objects, as mark_maybe_pointer will catch them otherwise.
2047 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2048 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2050 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2052 Fix typo that broke non-Windows builds.
2053 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2055 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2057 Support building on MS-Windows with libxml2.
2059 * makefile.w32-in (OBJ2): Add xml.$(O).
2060 (GLOBAL_SOURCES): Add xml.c.
2061 ($(BLD)/xml.$(O)): New dependency list.
2063 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2064 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2065 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2066 [!WINDOWSNT]: New macros.
2067 (init_libxml2_functions, libxml2_loaded_p): New functions.
2068 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2069 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2070 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2071 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2073 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2074 Call init_libxml2_functions before calling libxml2 functions.
2075 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2077 * emacs.c: Don't include libxml/parser.h.
2078 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2079 xmlCleanupParser directly.
2081 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2083 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2085 * indent.c (Fvertical_motion): If there is a display string at
2086 point, use it.vpos to compute how many lines to backtrack after
2087 move_it_to point. (Bug#11133)
2089 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2091 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2092 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2093 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2094 macros related to unification of CJK characters. For the details,
2095 see the discussion following the message here:
2096 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2098 2012-04-04 Chong Yidong <cyd@gnu.org>
2100 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2102 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2104 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2105 instead of alloca. (Bug#11138)
2107 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2109 * w32menu.c (is_simple_dialog): Properly check lisp types.
2112 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2114 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2115 position we get to after a call to move_it_to fails the
2116 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2117 only if we wind up in a string from display property. (Bug#11063)
2119 * window.c (Fdelete_other_windows_internal): Invalidate the row
2120 and column information about mouse highlight, so that redisplay
2121 restores it after reallocating the glyph matrices. (Bug#7464)
2123 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2124 string comes from a `display' text property, use the buffer
2125 position of that property as if we actually saw that position in
2127 (move_it_by_lines): Remove the assertion that
2128 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2129 violated when there's a before-string at the beginning of a line.
2132 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2134 * xdisp.c (append_space_for_newline): If the default face was
2135 remapped, use the remapped face for the appended newline.
2136 (extend_face_to_end_of_line): Use the remapped default face for
2137 extending the face to the end of the line.
2138 (display_line): Call extend_face_to_end_of_line when the default
2139 face was remapped. (Bug#11068)
2141 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2143 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2145 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2147 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2149 2012-03-27 Glenn Morris <rgm@gnu.org>
2151 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2154 2012-03-26 Kenichi Handa <handa@m17n.org>
2156 * dispextern.h (struct glyph): Fix previous change. Change the
2157 bit length of glyphless.ch to 25 (Bug#11082).
2159 2012-03-26 Chong Yidong <cyd@gnu.org>
2161 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2162 (command_loop_1): Use it; inhibit selection update for
2163 handle-select-window too (Bug#8996).
2165 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2167 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2169 2012-03-25 Kenichi Handa <handa@m17n.org>
2171 * dispextern.h (struct glyph): Change the bit length of
2172 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2174 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2176 * s/ms-w32.h (tzname): Include time.h before redirecting to
2177 _tzname. Fixes the MSVC build. (Bug#9960)
2179 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2181 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2184 * xterm.c (XTread_socket): Only modify handling_signal if
2185 !SYNC_INPUT. (Bug#11080)
2187 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2189 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2190 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2191 when fetching a multibyte character consumes more bytes than
2192 CHAR_BYTES returns, due to unification of CJK characters in
2193 string_char. (Bug#11073)
2195 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2197 * process.c (wait_reading_process_output): Handle pty disconnect
2198 by refraining from sending oneself a SIGCHLD (bug#10933).
2200 2012-03-22 Chong Yidong <cyd@gnu.org>
2202 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2204 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2205 Mark string as coming from a prefix property.
2206 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2207 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2209 2012-03-21 Chong Yidong <cyd@gnu.org>
2211 * xfaces.c (Vface_remapping_alist): Doc fix.
2213 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2215 * w32proc.c (Fw32_set_console_codepage)
2216 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2219 2012-03-20 Chong Yidong <cyd@gnu.org>
2221 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2222 to reflect default non-nil value of redisplay-dont-pause.
2224 2012-03-19 Kenichi Handa <handa@m17n.org>
2226 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2227 it fit in a valid range (Bug#11003).
2229 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2231 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2232 that is not from display property, accept the row as a "cursor
2233 row" if one of the string's character has a non-nil `cursor'
2234 property. Fixes cursor positioning when there are newlines in
2235 overlay strings, e.g. in icomplete.el. (Bug#11035)
2237 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2239 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2241 2012-03-12 Chong Yidong <cyd@gnu.org>
2243 * eval.c (inhibit_lisp_code): Rename from
2244 inhibit_window_configuration_change_hook; move from window.c.
2246 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2247 * window.c (run_window_configuration_change_hook)
2248 (syms_of_window): Callers changed.
2250 2012-03-11 Chong Yidong <cyd@gnu.org>
2252 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2254 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2256 2012-03-10 Chong Yidong <cyd@gnu.org>
2258 * frame.c (other_visible_frames): Don't assume the selected frame
2259 is visible (Bug#10955).
2261 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2263 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2265 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2267 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2268 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2271 2012-03-03 Glenn Morris <rgm@gnu.org>
2273 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2275 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2277 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2278 position past the first glyph_row that ends at ZV. (Bug#10902)
2279 (redisplay_window, next_element_from_string): Fix typos in
2281 (redisplay_window): Pass to move_it_vertically the margin in
2282 pixels, not in screen lines.
2284 2012-03-02 Glenn Morris <rgm@gnu.org>
2286 * buffer.c (buffer-list-update-hook): Doc fix.
2288 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2290 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2291 push_it before setting up the iterator for the first overlay
2292 string, even if we have an empty string loaded.
2293 (next_overlay_string): If there's an empty string on the iterator
2294 stack, pop the stack. (Bug#10903)
2296 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2298 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2299 Suggested by Stefan Monnier in
2300 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2301 * alloc.c (widen_to_Lisp_Object): New static function.
2302 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2303 and widening them to Lisp_Objects. This would work even if
2304 USE_LSB_TAG is defined and wide integers are used, which might
2305 happen in a future version of Emacs.
2307 2012-02-25 Chong Yidong <cyd@gnu.org>
2309 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2312 * xselect.c (Fx_selection_exists_p): Doc fix.
2313 (x_clipboard_manager_save_all): Print an informative message
2314 before saving to clipboard manager.
2316 2012-02-24 Chong Yidong <cyd@gnu.org>
2318 * keyboard.c (process_special_events): Handle all X selection
2319 requests in kbd_buffer, not just the next one (Bug#8869).
2321 2012-02-23 Chong Yidong <cyd@gnu.org>
2323 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2324 call when setting menu-bar-lines and tool-bar-lines parameters.
2325 (unwind_create_frame_1): New helper function.
2327 * window.c (inhibit_window_configuration_change_hook): New var.
2328 (run_window_configuration_change_hook): Obey it.
2329 (syms_of_window): Initialize it.
2331 2012-02-22 Chong Yidong <cyd@gnu.org>
2333 * xterm.c (x_draw_image_relief): Add missing type check for
2334 Vtool_bar_button_margin (Bug#10743).
2336 2012-02-21 Chong Yidong <cyd@gnu.org>
2338 * fileio.c (Vfile_name_handler_alist): Doc fix.
2340 * buffer.c (Fget_file_buffer): Protect against invalid file
2341 handler return value.
2343 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2345 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2346 when computing $valmask.
2348 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2349 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2350 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2351 It's useless in that case, and it can cause problems on hosts
2352 that allocate halves of EMACS_INT values separately.
2353 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2354 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2355 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2356 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2357 it avoids undefined behavior on hosts where shifting right by more
2358 than the word width has undefined behavior.
2360 2012-02-19 Chong Yidong <cyd@gnu.org>
2362 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2363 (Funhandled_file_name_directory, Ffile_name_as_directory)
2364 (Fdirectory_file_name, Fexpand_file_name)
2365 (Fsubstitute_in_file_name): Protect against invalid file handler
2366 return values (Bug#10845).
2368 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2370 * .gdbinit (pitx): Fix incorrect references to fields of the
2373 2012-02-17 Chong Yidong <cyd@gnu.org>
2375 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2377 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2379 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2380 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2382 2012-02-15 Chong Yidong <cyd@gnu.org>
2384 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2385 marked as special. Also, starting docstrings with * is obsolete.
2387 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2389 * gnutls.c (emacs_gnutls_write): Fix last change.
2391 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2393 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2396 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2398 * keymap.c (Fsingle_key_description): Handle char ranges.
2400 2012-02-12 Chong Yidong <cyd@gnu.org>
2402 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2403 as that creates a dangerous corner case.
2405 * window.c (Fdelete_window_internal): Invalidate the mouse
2406 highlight (Bug#9904).
2408 2012-02-12 Glenn Morris <rgm@gnu.org>
2410 * xselect.c (Fx_own_selection_internal)
2411 (Fx_get_selection_internal, Fx_disown_selection_internal)
2412 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2413 * nsselect.m (Fx_own_selection_internal)
2414 (Fx_disown_selection_internal, Fx_selection_exists_p)
2415 (Fx_selection_owner_p, Fx_get_selection_internal):
2416 Sync docs and argument specs with the xselect.c versions.
2418 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2420 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2422 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2424 * w32select.c (Fx_selection_exists_p): Sync doc string and
2425 argument list with xselect.c. (Bug#10783)
2427 * w16select.c (Fx_selection_exists_p): Sync doc string and
2428 argument list with xselect.c. (Bug#10783)
2430 2012-02-10 Glenn Morris <rgm@gnu.org>
2432 * fns.c (Fsecure_hash): Doc fix.
2434 2012-02-09 Kenichi Handa <handa@m17n.org>
2436 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2438 2012-02-07 Chong Yidong <cyd@gnu.org>
2440 * buffer.c (Fbuffer_local_variables)
2441 (buffer_lisp_local_variables): Handle unbound vars correctly;
2442 don't let Qunbound leak into Lisp.
2444 2012-02-07 Glenn Morris <rgm@gnu.org>
2446 * image.c (Fimagemagick_types): Doc fix.
2448 * image.c (imagemagick-render-type): Change it from a lisp object
2449 to an integer. Move the doc here from the lisp manual.
2450 Treat all values not equal to 0 the same.
2452 2012-02-06 Chong Yidong <cyd@gnu.org>
2454 * doc.c (store_function_docstring): Avoid applying docstring of
2455 alias to base function (Bug#2603).
2457 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2459 * .gdbinit (pp1, pv1): Remove redundant defines.
2462 2012-02-04 Chong Yidong <cyd@gnu.org>
2464 * nsterm.m: Declare a global (Bug#10694).
2466 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2468 * w32.c (get_emacs_configuration_options):
2469 Include --enable-checking, if specified, in the return value.
2471 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2473 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2474 after rounding frame sizes. (Bug#9723)
2476 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2478 * keyboard.c (adjust_point_for_property): Don't position point
2479 before BEGV. (Bug#10696)
2481 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2483 Handle overflow when computing char display width (Bug#9496).
2484 * character.c (char_width): Return EMACS_INT, not int.
2485 (char_width, c_string_width): Check for overflow when
2486 computing the width; this is possible now that individual
2487 characters can have unbounded width. Problem introduced
2488 by merge from Emacs 23 on 2012-01-19.
2490 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2492 * dbusbind.c (Fdbus_register_method): Mention the return value
2493 :ignore in the docstring.
2495 2012-02-02 Glenn Morris <rgm@gnu.org>
2497 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2499 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2500 Unconditionally set to t. (Bug#10673)
2501 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2502 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2503 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2505 2012-02-02 Kenichi Handa <handa@m17n.org>
2507 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2508 0, do not call append_composite_glyph.
2510 2012-02-02 Kenichi Handa <handa@m17n.org>
2512 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2514 (x_produce_glyphs): If the component of a composition is a null
2515 string, set it->pixel_width to 1 to avoid zero-width glyph.
2517 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2519 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2520 first 2 arguments are identical. This makes inserting large
2521 output from a subprocess an order of magnitude faster on
2522 MS-Windows, where all sbrk'ed memory is always contiguous.
2524 2012-01-31 Glenn Morris <rgm@gnu.org>
2526 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2527 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2528 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2530 2012-01-29 Glenn Morris <rgm@gnu.org>
2532 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2534 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2536 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2538 2012-01-28 Chong Yidong <cyd@gnu.org>
2540 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2542 2012-01-26 Chong Yidong <cyd@gnu.org>
2544 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2546 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2547 repeat counts (Bug#10507).
2549 2012-01-26 Glenn Morris <rgm@gnu.org>
2551 * lread.c (syms_of_lread): Doc fix.
2553 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2555 * coding.c (encode_designation_at_bol): Change return value to
2558 2012-01-25 Chong Yidong <cyd@gnu.org>
2560 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2562 2012-01-21 Chong Yidong <cyd@gnu.org>
2564 * floatfns.c (Fcopysign): Make the second argument non-optional,
2565 since nil is not allowed anyway.
2567 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2569 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2570 (send_process): Likewise.
2572 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2574 * window.c (save_window_save, Fcurrent_window_configuration)
2575 (Vwindow_persistent_parameters): Do not use Qstate.
2576 Rewrite doc-strings.
2578 2012-01-19 Kenichi Handa <handa@m17n.org>
2580 * character.c (char_width): New function.
2581 (Fchar_width, c_string_width, lisp_string_width):
2582 Use char_width (Bug#9496).
2584 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2586 * window.c (Vwindow_persistent_parameters): New variable.
2587 (Fset_window_configuration, save_window_save): Handle persistent
2590 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2592 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2593 thrashing the stack of the thread. (Bug#9087)
2595 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2597 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2599 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2601 * xdisp.c (rows_from_pos_range): Handle the case where the
2602 highlight ends on a newline. (Bug#10464)
2603 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2604 he end column for display of highlight that ends on a newline
2607 2012-01-11 Glenn Morris <rgm@gnu.org>
2609 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2610 from load-path also when installation-directory is nil. (Bug#10208)
2612 2012-01-10 Glenn Morris <rgm@gnu.org>
2614 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2616 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2617 Update template values to be closer to their typical values these days.
2619 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2621 * xdisp.c (rows_from_pos_range): Accept additional argument
2622 DISP_STRING, and accept any glyph in a row whose object is that
2623 string as eligible for mouse highlight. Fixes mouse highlight of
2624 display strings from overlays. (Bug#10464)
2626 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2628 emacs: fix an auto-save permissions race condition (Bug#10400)
2629 * fileio.c (auto_saving_dir_umask): New static var.
2630 (Fmake_directory_internal): Use it.
2631 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2632 creating the directory. The old code temporarily assigns
2633 too-generous permissions to the directory.
2634 (do_auto_save_eh): Clear it.
2635 (Fdo_auto_save): Catch all errors, not just file errors, so
2636 that the var is always cleared.
2638 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2640 * search.c (scan_buffer): Pass character positions to
2641 know_region_cache, not byte positions. (Bug#6540)
2643 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2645 * w32.c (sys_rename): Report EXDEV when rename of a directory
2646 fails because the target is on another logical disk. (Bug#10284)
2648 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2650 * xterm.c (x_embed_request_focus): New function.
2652 * xterm.h: Add prototype.
2654 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2656 2012-01-05 Glenn Morris <rgm@gnu.org>
2658 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2660 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2662 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2663 Load gnutls_transport_set_lowat only if GnuTLS version is below
2665 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2666 GnuTLS versions below 2.11.1.
2668 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2670 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2671 to the doc string advising against its use for altering the way
2672 windows are scrolled.
2674 2011-12-28 Kenichi Handa <handa@m17n.org>
2676 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2677 coding-system ASCII compatible only when it does not produce BOM
2678 on encoding (Bug#10383).
2680 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2682 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2684 (create_and_show_popup_menu): Always use menu_position_func for
2687 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2689 * callint.c (Fcall_interactively): Don't truncate prompt string.
2691 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2693 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2694 property that ends at ZV, so that the bidi iteration could be
2695 resumed from there (after widening). (Bug#10360)
2697 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2699 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2701 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2703 * nsterm.m (x_free_frame_resources):
2704 Release f->output_data.ns->miniimage.
2705 (ns_index_color): Fix indentation. Do not retain
2706 color_table->colors[i].
2708 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2711 * nsfns.m (x_set_background_color): Assign return value from
2712 ns_index_color to face-background instead of NSColor*.
2713 (ns_implicitly_set_icon_type): Fix indentation.
2714 Change assignment in for loop to comparison.
2716 * emacs.c (ns_pool): New variable.
2717 (main): Assign ns_pool.
2718 (Fkill_emacs): Call ns_release_autorelease_pool.
2720 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2721 autorelease fdesc, release fdAttrs and tdict.
2722 (ns_get_covering_families): Release charset.
2723 (ns_findfonts): Release NSFontDescriptor created with new.
2724 (ns_uni_to_glyphs): Fix indentation.
2725 (setString): Release attrStr before assigning new value.
2727 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2729 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2731 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2732 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2734 2011-12-18 David Reitter <reitter@cmu.edu>
2736 * nsterm.m (ns_term_init): Subscribe for notifications
2737 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2738 to method trackingNotification in EmacsMenu.
2740 * nsmenu.m (trackingMenu): New variable.
2741 (trackingNotification): New method (from Aquamacs).
2742 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2743 from Aquamacs (Bug#7030).
2745 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2747 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2748 (symbol_to_nsstring): Fix indentation.
2749 (ns_symbol_to_pb): New function.
2750 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2751 (Fns_rotate_cut_buffers_internal): Remove.
2752 (Fns_store_selection_internal): Rename from
2753 Fns_store_cut_buffer_internal.
2754 (ns_get_foreign_selection, Fx_own_selection_internal)
2755 (Fx_disown_selection_internal, Fx_selection_exists_p)
2756 (Fns_get_selection_internal, Fns_store_selection_internal):
2757 Use ns_symbol_to_pb and check if return value is nil.
2758 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2759 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2760 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2761 renamed to Sns_store_selection_internal.
2762 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2763 and remove this function.
2764 (ns_handle_selection_clear): Remove, never used.
2765 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2768 2011-12-17 Ken Brown <kbrown@cornell.edu>
2770 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2771 GID is unknown (Bug#10257).
2773 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2775 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2776 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2777 which caused a build failure on GNU/Linux IA-64. This problem was
2778 introduced by my 2011-10-07 patch.
2780 2011-12-15 Juri Linkov <juri@jurta.org>
2782 * image.c (imagemagick_error): New function. (Bug#10112)
2783 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2784 Use `imagemagick_error' where ImageMagick functions return
2786 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2789 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2791 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2792 fill background (Bug#8992).
2794 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2796 * window.c (Vwindow_combination_resize)
2797 (Vwindow_combination_limit): Use t instead of non-nil in
2799 (Vrecenter_redisplay): Add first sentence of doc-string on
2801 (Frecenter): Fix doc-string typo.
2803 2011-12-11 Kenichi Handa <handa@m17n.org>
2805 * coding.c (Funencodable_char_position): Pay attention to the
2806 buffer text relocation (Bug#9389).
2808 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2810 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2811 gtk_init (Bug#10100).
2813 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2815 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2816 IT->string is nil. (Bug#10263)
2818 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2820 * nsterm.h (x_free_frame_resources): Declare.
2822 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2823 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2825 * nsterm.h (ns_get_defaults_value): Declare.
2827 * nsterm.m (ns_default): Call ns_get_defaults_value.
2829 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2831 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2834 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2836 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2837 that where the value of an _OBJC_* symbol points to is in the .bss
2838 section (Bug#10240).
2840 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2842 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2843 after the loop to call ccl_driver at least once (Bug#8619).
2845 2011-12-08 Kenichi Handa <handa@m17n.org>
2847 * ftfont.c (get_adstyle_property): Fix previous change
2850 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2852 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2853 dirs from the default value of EMACSLOADPATH (bug#10208).
2855 2011-12-07 Glenn Morris <rgm@gnu.org>
2857 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2858 installation and source directories as well. (Bug#10208)
2860 2011-12-06 Chong Yidong <cyd@gnu.org>
2862 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2864 2011-12-06 Glenn Morris <rgm@gnu.org>
2866 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2867 as an error, not just -1. (Bug#10217)
2869 2011-12-05 Chong Yidong <cyd@gnu.org>
2871 * keyboard.c (process_special_events): New function.
2872 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2874 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2876 * coding.c (encode_designation_at_bol): Don't use uninitialized
2877 local variable (Bug#9318).
2879 2011-12-05 Kenichi Handa <handa@m17n.org>
2881 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2882 return Qnil (Bug#8046, Bug#10193).
2884 2011-12-05 Kenichi Handa <handa@m17n.org>
2886 * coding.c (encode_designation_at_bol): New args charbuf_end and
2887 dst. Return the number of produced bytes. Callers changed.
2888 (coding_set_source): Return how many bytes coding->source was
2890 (coding_set_destination): Return how many bytes
2891 coding->destination was relocated.
2892 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2893 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2895 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2897 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2898 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2901 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2903 The following changes are to fix Bug#9318.
2905 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2906 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2907 (encode_coding_iso_2022, encode_coding_sjis)
2908 (encode_coding_big5, encode_coding_charset): Use the above macros.
2910 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2912 * lisp.h (process_quit_flag): Fix external declaration.
2914 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2916 Don't macro-inline non-performance-critical code.
2917 * eval.c (process_quit_flag): New function.
2918 * lisp.h (QUIT): Use it.
2920 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2922 * nsfns.m (get_geometry_from_preferences): New function.
2923 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2925 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2927 * emacs.c (Qkill_emacs): Define.
2928 (syms_of_emacs): Initialize it.
2929 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2930 Qquit_flag to `kill-emacs' instead.
2931 (quit_throw_to_read_char): Add parameter `from_signal'.
2932 All callers changed. Call Fkill_emacs if requested and safe.
2933 * lisp.h (QUIT): Call Fkill_emacs if requested.
2935 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2937 * widget.c (update_wm_hints): Return if wmshell is null.
2938 (widget_update_wm_size_hints): New function.
2940 * widget.h (widget_update_wm_size_hints): Declare.
2942 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2943 widget_update_wm_size_hints (Bug#10104).
2945 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2947 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2948 before a newline, prepare the bidi iterator for consuming the
2949 newline, and keep the current paragraph direction. (Bug#10183)
2950 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2952 2011-12-02 Juri Linkov <juri@jurta.org>
2954 * search.c (Fword_search_regexp): New Lisp function created from
2955 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2956 (Fword_search_backward, Fword_search_forward)
2957 (Fword_search_backward_lax, Fword_search_forward_lax):
2958 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2959 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2961 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2963 * fileio.c (Finsert_file_contents): Move after-change-function call
2964 to before the "handled:" label, since all "goto handled" appear in
2965 cases where the *-change-functions have already been properly called
2968 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2970 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2971 waiting for input. (Bug#10169)
2973 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2975 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2976 verifies glyph row's hash code--we have just reallocated the
2977 glyphs, so their contents can be complete garbage. (Bug#10164)
2979 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2981 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2983 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2985 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2986 attributes are tested _before_ calling verify_row_hash, to protect
2987 against GCC re-ordering of the tests. (Bug#10164)
2989 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2991 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2993 * xterm.c (handle_one_xevent): Only set async_visible and friends
2994 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2995 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2996 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2998 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3000 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3001 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3002 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3003 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3004 All uses changed to use GCPRO1 etc.
3005 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3006 Revert to old implementation (i.e., before 2011-03-11).
3008 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3010 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3011 of scroll runs so as to avoid assigning disabled bogus rows and
3012 unnecessary graphics copy operations.
3014 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3016 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3017 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3018 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3019 (malloc, free, realloc, calloc): Redirect to e_* only when
3022 * lisp.h (GCTYPEBITS): Move before first use.
3023 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3024 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3025 this macro definition.
3027 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3030 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3032 * gtkutil.c (xg_create_frame_widgets):
3033 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3034 present with Gtk+ 2.0.
3036 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3038 * fileio.c (Finsert_file_contents): Undo previous change; see
3039 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3041 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3043 Rename locals to avoid shadowing.
3044 * fileio.c (Finsert_file_contents):
3045 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3046 * process.c (wait_reading_process_output):
3047 Rename inner 'proc' to 'p' to avoid shadowing.
3048 Indent for consistency with usual Emacs style.
3050 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3052 * xdisp.c (redisplay_window): If cursor row is not fully visible
3053 after recentering, and scroll-conservatively is set to a large
3054 number, scroll window by a few more lines to make the cursor fully
3055 visible and out of scroll-margin. (Bug#10105)
3056 (start_display): Don't move to the next line if the display should
3057 start at a newline that is part of a display vector or an overlay
3060 2011-11-24 Juri Linkov <juri@jurta.org>
3062 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3063 after the `MagickPingImage' call. (Bug#10112)
3065 2011-11-23 Chong Yidong <cyd@gnu.org>
3067 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3069 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3071 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3072 making another buffer current. (Bug#10114)
3074 2011-11-23 Glenn Morris <rgm@gnu.org>
3076 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3078 2011-11-23 Chong Yidong <cyd@gnu.org>
3080 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3081 using it (Bug#5984).
3083 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3085 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3086 and header-lines, as they don't have one computed for them.
3089 * .gdbinit (prow): Make displayed values more self-explaining.
3090 Add row's hash code.
3092 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3094 * process.c (wait_reading_process_output): Fix asynchrounous
3095 GnuTLS socket handling on some versions of the GnuTLS library.
3096 (wait_reading_process_output): Add comment and URL.
3098 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3100 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3102 2011-11-21 Chong Yidong <cyd@gnu.org>
3104 * window.c (Fnext_window, Fprevious_window): Doc fix.
3106 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3108 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3110 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3112 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3114 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3116 * window.c (Fset_window_combination_limit): Rename argument
3118 (Vwindow_combination_limit): Remove "status" from doc-string.
3120 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3122 * m/ibms390.h: Remove.
3123 * m/ibms390x.h: Don't include "ibms390.h".
3125 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3127 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3128 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3130 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3132 * casetab.c (Fset_case_table):
3133 * charset.c (Fcharset_after): Fix typos.
3135 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3137 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3138 Otherwise, valgrind does not work on some platforms.
3139 Problem reported by Andreas Schwab in
3140 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3141 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3142 is set, removing the need for VIRT_ADDRESS_VARIES.
3143 (PURE_P): Use a more-efficient implementation that needs just one
3144 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3145 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3146 to 4 (xorl, subq, cmpq, setbe).
3147 * alloc.c (pure): Always extern now, since that's the
3148 VIRT_ADDR_VARIES behavior.
3149 (PURE_POINTER_P): Use a single comparison, not two, for
3150 consistency with the new puresize.h.
3151 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3152 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3153 Remove VIRT_ADDR_VARIES no longer needed.
3155 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3157 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3158 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3159 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3160 behave as if the cursor position were at the window margin.
3162 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3163 and the cursor position is out of bounds, behave as if the cursor
3164 position were at the window margin. (Bug#10075)
3166 2011-11-18 Chong Yidong <cyd@gnu.org>
3168 * window.c (Fwindow_combination_limit): Make first argument
3169 non-optional, since it is meaningless for live windows like the
3172 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3174 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3176 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3178 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3179 (graft_intervals_into_buffer): Simplify.
3181 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3183 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3184 hash values of the two rows.
3185 (copy_row_except_pointers): Preserve the used[] arrays and the
3186 hash values of the two rows. (Bug#10035)
3187 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3189 * xdisp.c (row_hash): New function, body extracted from
3190 compute_line_metrics.
3191 (compute_line_metrics): Call row_hash, instead of computing the
3194 * dispnew.c (verify_row_hash): Call row_hash for computing the
3195 hash code of a row, instead of duplicating code from xdisp.c.
3197 * dispextern.h (row_hash): Add prototype.
3199 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3201 * frame.c (delete_frame): Don't delete the terminal when the last
3202 X frame is closed if emacs is built with GTK toolkit.
3204 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3206 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3208 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3210 * window.c (Vwindow_splits): Rename to
3211 Vwindow_combination_resize. Suggested by Juri Linkov.
3212 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3215 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3217 * nsfns.m (Fns_font_name):
3218 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3220 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3222 * window.h (window): Rename slot "nest" to "combination_limit".
3223 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3224 (Fset_window_nest): Rename to Fset_window_combination_limit.
3225 (Vwindow_nest): Rename to Vwindow_combination_limit.
3226 (recombine_windows, make_parent_window, make_window)
3227 (Fsplit_window_internal, saved_window)
3228 (Fset_window_configuration, save_window_save): Rename all
3229 occurrences of window_nest to window_combination_limit.
3231 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3233 * image.c (imagemagick_load_image): Fix typo.
3235 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3237 * xdisp.c (display_line): Move the call to
3238 highlight_trailing_whitespace before the call to
3239 compute_line_metrics, since the latter needs to see the final
3240 faces of all the glyphs to compute ROW's hash value.
3241 Fixes assertion violations in row_equal_p. (Bug#10035)
3243 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3245 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3246 just return (bug#10044).
3248 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3250 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3251 with user-defined heap size. Bump the default size of the temacs
3252 heap to 27MB, to avoid memory warning when running temacs.
3253 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3255 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3256 current_matrix and desired_matrix. (Bug#9990)
3257 (verify_row_hash) [XASSERTS]: New function.
3258 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3259 that the hash value of glyph rows is correct.
3261 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3263 * window.h (window): Remove splits slot.
3264 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3265 (Fdelete_other_windows_internal, make_parent_window)
3266 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3267 (Fset_window_configuration, save_window_save): Don't deal with
3268 split status of windows.
3269 (saved_window): Remove splits slot.
3270 (Vwindow_splits): Rewrite doc-string.
3272 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3274 * xfns.c (unwind_create_frame):
3275 * nsfns.m (unwind_create_frame):
3276 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3277 Vframe_list (Bug#9999).
3279 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3281 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3283 2011-11-11 Kenichi Handa <handa@m17n.org>
3285 * callproc.c (Fcall_process): Set the member dst_multibyte of
3288 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3290 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3291 avoid a crash (bug#9496).
3293 2011-11-09 Chong Yidong <cyd@gnu.org>
3295 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3296 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3298 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3300 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3302 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3304 Avoid some portability problems by eschewing 'extern inline' functions.
3305 The trivial performance wins aren't worth the portability hassles; see
3306 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3308 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3309 (window_box_width, window_box_left, window_box_left_offset)
3310 (window_box_right, window_box_right_offset): Undo previous change,
3311 by removing the "extern"s.
3312 * intervals.c (adjust_intervals_for_insertion)
3313 (adjust_intervals_for_deletion): Undo previous change,
3314 making these static again.
3315 (offset_intervals, temp_set_point_both, temp_set_point)
3316 (copy_intervals_to_string): No longer inline.
3317 * xdisp.c (window_text_bottom_y, window_box_width)
3318 (window_box_height, window_box_left_offset)
3319 (window_box_right_offset, window_box_left, window_box_right)
3320 (window_box): No longer inline.
3322 2011-11-08 Chong Yidong <cyd@gnu.org>
3324 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3325 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3326 Signal an error if not a live window.
3327 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3328 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3330 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3332 * lisp.h (syms_of_abbrev): Remove declaration.
3333 Reported by CHENG Gao <chenggao@royau.me>.
3335 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3337 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3338 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3339 of temacs in GUI mode.
3341 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3343 * window.h: Declare delete_all_child_windows instead of
3344 delete_all_subwindows.
3345 * window.c (Fwindow_nest, Fset_window_nest)
3346 (Fset_window_new_total, Fset_window_new_normal)
3347 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3348 (delete_all_subwindows): Rename to delete_all_child_windows.
3349 (Fdelete_other_windows_internal, Fset_window_configuration):
3350 Call delete_all_child_windows instead of delete_all_subwindows.
3351 * frame.c (delete_frame): Call delete_all_child_windows instead
3352 of delete_all_subwindows.
3354 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3356 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3357 This is also needed for porting to any host where GC_MARK_STACK is
3358 not GC_MAKE_GCPROS_NOOPS.
3359 (which_symbols): Use it.
3361 2011-11-07 Kenichi Handa <handa@m17n.org>
3363 * coding.c (coding_set_destination): Check coding->src_pos only
3364 when coding->src_object is a buffer (bug#9910).
3366 * process.c (send_process): Set the member src_multibyte of coding
3367 to 0 (bug#9911) when sending a unibyte text.
3369 * callproc.c (Fcall_process): Set the member src_multibyte of
3370 process_coding to 0 (bug#9912).
3372 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3374 * xmenu.c (cleanup_widget_value_tree): New function.
3375 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3376 calling free_menubar_widget_value_tree directly (Bug#9830).
3378 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3380 Fix some portability problems with 'inline'.
3381 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3382 (window_box_width, window_box_left, window_box_left_offset)
3383 (window_box_right, window_box_right_offset): Declare extern.
3384 Otherwise, these inline functions do not conform to C99 and
3385 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3386 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3387 * intervals.c (adjust_intervals_for_insertion)
3388 (adjust_intervals_for_deletion): Now extern, because otherwise the
3389 extern inline functions 'offset_intervals' couldn't refer to it.
3390 (static_offset_intervals): Remove.
3391 (offset_intervals): Rewrite using the old contents of
3392 static_offset_intervals. The old version didn't conform to C99
3393 because an extern inline function contained a reference to an
3394 identifier with static linkage.
3396 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3398 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3401 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3403 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3404 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3405 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3406 return Qleft_to_right.
3408 2011-11-06 Chong Yidong <cyd@gnu.org>
3410 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3411 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3412 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3413 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3414 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3415 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3416 (Fwindow_vscroll): Doc fix.
3417 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3418 argument, since it makes no sense to pass a live window and for
3419 consistency with window-child.
3421 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3423 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3426 2011-11-05 Jason Rumney <jasonr@gnu.org>
3428 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3429 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3431 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3432 bitwise arithmetic preventing use of unicode-sip and non-truetype
3435 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3437 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3440 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3441 initialization code to keep similarity to xfns.c after changes
3444 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3446 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3447 (unwind_create_frame): New function (Bug#9943).
3448 (Fx_create_frame): Restructure code to be more similar to the one in
3449 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3450 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3451 Move terminal->reference_count++ just before making the frame official
3454 * nsterm.m (x_free_frame_resources): New function.
3455 (x_destroy_window): Move code to x_free_frame_resources.
3457 * xfns.c (unwind_create_frame): Fix comment.
3458 (Fx_create_frame, x_create_tip_frame):
3459 Move terminal->reference_count++ just before making the frame
3460 official. Move initialization of image_cache_refcount and
3461 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3463 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3465 Support MSVC build with newer versions of Visual Studio.
3466 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3467 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3470 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3471 which are not supported by MSVC.
3472 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3473 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3475 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3477 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3479 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3481 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3483 Support MSVC build with newer versions of Visual Studio.
3484 * w32.c: Don't include w32api.h for MSVC.
3485 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3487 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3488 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3489 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3490 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3492 (alloca) [_MSC_VER]: Define to _alloca.
3494 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3496 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3498 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3500 * xdisp.c (note_mouse_highlight): If either of
3501 previous/next-single-property-change returns nil, treat that as
3502 the beginning or the end of the buffer. (Bug#9955)
3504 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3506 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3507 label is not null (Bug#9951).
3508 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3511 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3513 * window.c (Fwindow_body_size): Mention in the doc string that the
3514 return value is in frame's canonical units. (Bug#9949)
3516 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3518 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3520 * w32fns.c (unwind_create_frame): If needed, free the glyph
3521 matrices of the partially constructed frame. (Bug#9943)
3522 * xfns.c (unwind_create_frame): Likewise.
3524 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3526 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3527 Don't stop backward scan on the continuation glyph, even though
3528 its CHARPOS is positive.
3529 (mouse_face_from_buffer_pos, note_mouse_highlight):
3530 Rename cover_string to disp_string.
3532 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3534 * window.c (temp_output_buffer_show): Don't use
3535 Vtemp_buffer_show_specifiers.
3536 (Vtemp_buffer_show_specifiers): Remove unused variable.
3538 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3540 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3541 past the beginning of the current glyph matrix.
3543 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3545 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3546 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3547 HAVE_GTK3 (Bug#9869).
3549 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3550 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3552 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3554 * xterm.c: Declare x_handle_net_wm_state to return int.
3555 (handle_one_xevent): Check if we are iconified but don't have
3556 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3557 (get_current_wm_state): Return non-zero if not hidden,
3558 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3559 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3560 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3561 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3563 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3565 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3566 so that this new function doesn't get optimized away by a
3567 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3569 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3571 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3573 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3575 Fix the `xbytecode' command.
3576 * .gdbinit (xprintbytestr): New command.
3577 (xwhichsymbols): Rename from `which'; all callers changed.
3578 (xbytecode): Print the byte-code string as well.
3580 2011-10-29 Kim Storm <storm@cua.dk>
3582 * alloc.c (which_symbols): New function.
3584 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3586 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3589 2011-10-29 Glenn Morris <rgm@gnu.org>
3591 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3592 Not clear what it was for, and it causes various bugs. (Bug#9839)
3594 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3596 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3597 possible random value that matches one of those tested as
3598 condition to clear the mouse face.
3600 2011-10-28 Chong Yidong <cyd@gnu.org>
3602 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3604 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3606 * window.c (make_window): Initialize phys_cursor_on_p.
3608 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3610 * lisp.h (struct Lisp_Symbol): Update comments.
3612 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3614 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3616 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3618 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3619 <oslsachem@gmail.com> for helping to debug this.
3621 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3622 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3623 (g_b_init_get_glyph_outline_w): New static variables.
3624 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3625 (GetGlyphOutlineW_Proc): New typedefs.
3626 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3627 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3629 (w32font_open_internal, compute_metrics):
3630 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3631 instead of calling the "wide" APIs directly.
3633 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3635 * w32.h (syms_of_w32font): Add prototype.
3637 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3639 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3640 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3641 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3642 (Fmove_to_window_line): Doc fix.
3644 2011-10-27 Chong Yidong <cyd@gnu.org>
3646 * process.c (make_process): Set gnutls_state to NULL.
3648 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3649 non-NULL, regardless of GNUTLS_INITSTAGE.
3650 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3651 an error. Set process slots as soon as we allocate them.
3653 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3655 2011-10-27 Chong Yidong <cyd@gnu.org>
3657 * gnutls.c (emacs_gnutls_deinit): New function.
3658 Deallocate credentials structures as well as calling gnutls_deinit.
3659 (Fgnutls_deinit, Fgnutls_boot): Use it.
3661 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3662 (deactivate_process): Call emacs_gnutls_deinit.
3664 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3666 * image.c (x_create_x_image_and_pixmap):
3667 * w32.c (sys_rename, w32_delayed_load):
3668 * w32font.c (fill_in_logfont):
3669 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3671 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3673 * w32fns.c (w32_default_color_map): New function,
3674 extracted from Fw32_default_color_map.
3675 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3677 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3679 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3681 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3683 * keyboard.c (test_undefined): New function (bug#9751).
3684 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3686 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3688 * sysdep.c (init_sys_modes): Fix the check for the controlling
3689 terminal (Bug#6649).
3691 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3693 * dispextern.h (struct bidi_it): New member next_en_type.
3695 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3696 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3697 current character, check also for next_en_type being WEAK_EN.
3698 (bidi_resolve_weak): Don't enter the expensive loop if the current
3699 position is before next_en_pos. Record the bidi type of the first
3700 non-ET, non-BN character we find, in addition to its position.
3701 (bidi_level_of_next_char): Invalidate next_en_type when
3702 next_en_pos is over-stepped.
3704 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3706 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3707 * editfns.c: Rewrite current-time-zone so that it invokes
3708 the equivalent of (format-time-string "%Z") to get the time zone name.
3709 This fixes a bug when the time zone name contains characters that
3710 need converting from the system time locale to Emacs internal format.
3711 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3712 that patch fixed format-time-string to do the conversion, but
3713 I forgot to fix current-time-zone.
3714 (format_time_string): New function, containing most of
3715 what Fformat_time_string used to contain.
3716 (Fformat_time_string): Rewrite in terms of format_time_string.
3717 This doesn't change this function's behavior.
3718 (current-time-zone): Rewrite to use format_time_string.
3719 This fixes the bug reported by Michael Schierl in
3720 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3721 Jason Rumney's 2007-06-07 change worked around this bug, but
3723 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3725 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3727 * xdisp.c (start_display): If the character at POS is displayed
3728 via a display vector, reset IT->current.dpvec_index to zero.
3729 (try_window_reusing_current_matrix): If a line ends in a display
3730 vector or the next line starts in a display vector, continue
3731 redrawing the window even though the character position of
3732 start_row was reached.
3735 2011-10-18 Chong Yidong <cyd@gnu.org>
3737 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3738 with nobreak-char-display too.
3740 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3742 Fix part 3 of bug#9771.
3743 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3744 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3745 non-neutral characters if the current character is a paragraph
3746 separator (a.k.a. Newline). This avoids running the same
3747 expensive loop twice, once when we consume the preceding newline
3748 and the other time when the line actually needs to be displayed.
3749 Avoid the loop when we see neutrals on the base embedding level
3750 following a character whose directionality is the same as the
3751 paragraph's. This avoids running the expensive loop when a line
3752 ends in a long sequence of neutrals, like control characters.
3753 Add assertion against STRONG_AL type. Slightly rearrange code
3754 that determines the type of a neutral given the first non-neutral
3756 (bidi_level_of_next_char): Set next_en_pos to zero when
3757 invalidating its info.
3759 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3761 * xdisp.c (push_display_prop): Determine whether to record string
3762 or buffer position by IT->string, not by IT->method. Allow
3763 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3764 (move_it_vertically_backward): Don't look for character position
3765 immediately after the newline when in a continuation line.
3768 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3770 * window.c (coordinates_in_window): Rewrite and delabelize
3771 vertical border check. (Bug#5357) (Bug#9618)
3773 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3775 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3776 errors in XSetWindowBorder (bug#9310).
3778 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3780 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3781 avoid crash when xmalloc overrun checking is enabled.
3783 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3785 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3786 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3787 cursor motion with <left> and <right> arrow keys.
3789 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3790 some callers set that themselves.
3792 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3794 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3795 display string and the previous row comes from the same string and
3796 is empty. (Bug#9739) (Bug#9738)
3798 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3800 * doc.c (get_doc_string): Encode file name (bug#9735).
3802 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3804 * bidi.c (bidi_level_of_next_char):
3805 * xdisp.c (get_visually_first_element): Remove old incorrect
3806 comments regarding the Unicode Line Separator character.
3808 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3810 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3812 * alloc.c (Fgc_status): Do not access beyond zombies array
3813 boundary if nzombies > MAX_ZOMBIES.
3814 * alloc.c (dump_zombies): Add missing format specifier.
3816 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3818 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3819 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3821 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3822 Some packages use them to denote characters with modifiers.
3824 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3826 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3827 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3828 matching a pp-number. Rename parameter var to var1.
3830 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3832 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3834 2011-10-08 Glenn Morris <rgm@gnu.org>
3836 * callint.c (Fcall_interactively): Give a more explicit error for the
3837 'c' case with a non-character input. (Bug#8479)
3839 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3841 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3843 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3844 lines that are hscrolled on the left.
3846 * dispnew.c (buffer_posn_from_coords): Account for a possible
3847 presence of header-line. (Bug#4426)
3849 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3851 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3852 Don't advertise functionality which we discourage or doesn't work.
3854 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3856 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3857 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3858 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3859 this makes Emacs dump core during garbage collection on rare
3860 occasions. sizeof is obviously inferior to offsetof here, so
3861 stick with offsetof.
3862 (GC_POINTER_ALIGNMENT): New macro.
3863 (mark_memory): Omit 3rd (offset) arg; caller changed.
3864 Don't assume EMACS_INT alignment is the same as pointer alignment.
3866 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3868 * keyboard.c (read_key_sequence_remapped): New var.
3869 (read_key_sequence): Compute remapping in the right buffer.
3870 (command_loop_1): Use read_key_sequence's remapping directly.
3872 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3874 * dired.c (file_name_completion): Don't expand file name.
3875 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3876 before checking file name handler.
3878 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3879 they've been requested explicitly (bug#9591).
3881 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3883 * keymap.c (Fsingle_key_description): Use make_specified_string
3884 instead of build_string to build string from push_key_description.
3887 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3889 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3890 This fixes a Y2038 bug on 64-bit hosts.
3891 * buffer.c (reset_buffer):
3892 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3893 (Fclear_buffer_auto_save_failure):
3894 Use 0, not -1, to represent an unset failure time, since time_t
3895 might not be signed.
3897 Remove dependency on glibc malloc internals.
3898 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3899 Move back here from lisp.h, but with their new implementations.
3900 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3901 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3902 * charset.c (charset_table_init): New static var.
3903 (syms_of_charset): Use it instead of xmalloc. This removes a
3904 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3905 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3906 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3907 Move back to alloc.c.
3908 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3909 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3911 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3913 * nsterm.m (windowDidResize): Call x_set_window_size only when
3914 ns_in_resize is true. Otherwise set pixelwidth/height and
3915 call change_frame_size (Bug#9628).
3917 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3919 Port --enable-checking=all to Fedora 14 x86-64.
3920 * charset.c (syms_of_charset): Also account for glibc malloc's
3921 internal overhead when calculating the initial malloc maximum.
3923 Port --enable-checking=all to Fedora 14 x86.
3924 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3926 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3927 (overrun_check_realloc, overrun_check_free):
3928 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3929 That way, xmalloc returns a properly-aligned pointer even if
3930 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3931 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3932 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3933 into account when calculating the initial malloc maximum.
3934 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3935 Move here from alloc.c, so that charset.c can use it too.
3936 Properly align; the old code wasn't right for common 32-bit hosts
3937 when configured with --enable-checking=all.
3938 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3939 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3941 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3943 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3946 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3948 * xdisp.c (compute_display_string_end): If there's no display
3949 string at CHARPOS, return -1.
3951 * bidi.c (bidi_fetch_char): When compute_display_string_end
3952 returns a negative value, treat the character as a normal
3953 character not covered by a display string. (Bug#9624)
3955 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3957 * lread.c (Fread_from_string): Fix typo in docstring.
3959 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3961 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3962 newline, reseat the iterator instead of bidi-iterating there one
3963 character at a time. (Bug#9610)
3964 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3965 TO_CHARPOS if the bidi iterator is at base embedding level.
3967 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3969 * lread.c (readevalloop): Use correct code for NBSP.
3970 (read1): Likewise. (Bug#9608)
3972 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3974 * dbusbind.c (Fdbus_register_signal): When service is not
3975 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3977 2011-09-25 Glenn Morris <rgm@gnu.org>
3979 * buffer.c (truncate-lines): Doc fix.
3981 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3983 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3984 (Fset_window_next_buffers): Doc fix.
3986 2011-09-24 Glenn Morris <rgm@gnu.org>
3988 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3990 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3992 Fix minor problems found by static checking.
3993 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3994 * indent.c (Fvertical_motion): Fix == vs = typo.
3996 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3998 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3999 Default value is now t. Doc fix.
4001 * indent.c (Fvertical_motion): Compute and apply the overshoot
4002 logic when moving up, not only when moving down. Fix the
4003 confusing name and values of the it_overshoot_expected variable;
4004 logic changes accordingly. (Bug#9254) (Bug#9549)
4006 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4007 CHARPOS is covered by a display string which includes newlines.
4008 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4009 is covered by a display string with embedded newlines.
4011 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4013 * dbusbind.c (Fdbus_register_signal): Add match rule to
4014 Vdbus_registered_objects_table. (Bug#9581)
4015 (Fdbus_register_method, Vdbus_registered_objects_table):
4018 2011-09-24 Jim Meyering <meyering@redhat.com>
4020 do not ignore write error for any output size
4021 The previous change was incomplete.
4022 While it makes emacs --batch detect the vast majority of stdout
4023 write failures, errors were still ignored whenever the output size is
4024 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4025 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4026 && echo FAIL: ignored write error
4027 FAIL: ignored write error
4028 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4029 && echo FAIL: ignored write error
4030 FAIL: ignored write error
4031 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4033 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4035 * emacs.c (Fkill_emacs): In noninteractive mode exit
4036 non-successfully if a write error occurred on stdout. (Bug#9574)
4038 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4040 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4043 * dispextern.h (struct it): Update the comment documenting what
4046 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4048 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4049 a display string, extend search for cursor position to end of row.
4050 (find_row_edges): If the row ends in a newline from a display
4051 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4052 Handle the case of a display string with multiple newlines.
4053 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4054 non-empty line. Fixes confusing cursor motion with arrow keys at
4055 the beginning of a line that starts with whitespace.
4057 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4059 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4062 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4064 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4067 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4069 * xdisp.c (display_line): Record maximum and minimum buffer
4070 positions even if no glyphs were produced (e.g., by a zero-width
4071 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4072 buffer positions that will be removed from the glyph row because
4074 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4075 column is beyond frame width: don't subtract 1 "pixel" when
4076 computing width of the stretch.
4077 (reseat_at_next_visible_line_start): Undo the change made on
4078 2011-09-17 that saved paragraph information and restored it after
4079 the call to `reseat'. (Bug#9545)
4081 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4083 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4084 and turn window cursor on if cleared (Bug#9415).
4086 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4088 * search.c (boyer_moore): Take unibyte characters from pattern
4089 literally. (Bug#9458)
4091 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4093 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4095 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4097 Fix minor problem found by static checking.
4098 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4099 initialized, to pacify gcc -Wuninitialized.
4101 * fileio.c: Report proper errno when syscall falls.
4102 (Finsert_file_contents): Save and restore errno,
4103 so that report_file_error outputs the correct diagnostic.
4104 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4106 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4108 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4110 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4112 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4113 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4115 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4117 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4118 about the current paragraph and restore it after the call to reseat.
4120 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4121 (bidi_find_paragraph_start): Search back for paragraph beginning
4122 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4123 (bidi_move_to_visually_next): Only trigger paragraph-related
4124 computations when the last character is a newline or at EOB, not
4125 just any NEUTRAL_B. (Bug#9470)
4127 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4128 truncated lines if point is covered by a display string. (Bug#9524)
4130 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4132 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4133 (cons_to_x_long): New function.
4134 (lisp_data_to_selection_data): Use it. Correct the test for
4135 short-versus-long data; it was negated. Break out of vector
4136 loop, for efficiency, when a long datum is discovered.
4138 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4140 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4142 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4144 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4145 GCC PR/17406) by declaring this function with external scope.
4147 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4149 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4150 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4152 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4154 * editfns.c (Fformat): Correctly handle text properties on "%%".
4156 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4158 * xterm.c (x_draw_composite_glyph_string_foreground):
4159 * w32term.c (x_draw_composite_glyph_string_foreground):
4160 * term.c (encode_terminal_code):
4161 * composite.c (composition_update_it, get_composition_id):
4162 * xdisp.c (get_next_display_element)
4163 (fill_composite_glyph_string): Add comments about special meaning
4164 of TAB characters in a composition.
4166 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4168 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4169 This occurs when processing a multibyte format.
4170 Problem reported by Wolfgang Jenker.
4172 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4174 * xdisp.c (try_cursor_movement): Only check for exact match if
4175 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4177 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4179 Remove unused external symbols.
4180 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4181 * xdisp.c (calc_pixel_width_or_height): Now static.
4182 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4183 * indent.c (check_display_width):
4184 * w32term.c: Fix comment to match code.
4185 * xterm.c, xterm.h (x_catching_errors): Remove.
4187 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4189 * xselect.c: Use signed conversions more consistently (Bug#9498).
4190 (selection_data_to_lisp_data): Assume incoming selection data are
4191 signed integers, not unsigned. This is to be consistent with
4192 outgoing selection data, which was modified to use signed integers
4193 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4194 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4195 expects long, not unsigned long.
4197 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4199 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4200 computation of loop end. Reported by Johan Bockgård
4203 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4205 * frame.c (Fother_visible_frames_p): Function deleted.
4207 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4209 * indent.c (compute_motion): Process display vector front to back
4210 rather than the other way around. (Bug#2496)
4212 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4214 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4216 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4218 * minibuf.c (Fread_from_minibuffer): Doc fix.
4220 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4222 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4223 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4225 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4227 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4228 value for non-existent files.
4230 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4232 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4233 set its "size" to -1. This will set the modtime_size field of
4234 the corresponding buffer to -1, which is what
4235 verify-visited-file-modtime expects for files that do not exist.
4238 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4240 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4242 * lisp.h: ... from here. push_key_description is no longer
4243 defined in keyboard.c, so its declaration should not be in
4244 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4245 logically belongs with push_key_description.
4247 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4249 * buffer.h: Include <sys/types.h> instead of <time.h>.
4250 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4251 Problem reported by Herbert J. Skuhra.
4253 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4255 * xml.c (parse_region): Make the parsing work for
4256 non-comment-starting XML files again (bug#9144).
4258 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4260 * image.c (gif_load): Fix calculation of bottom and right corner.
4263 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4265 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4266 redisplay in small windows.
4268 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4270 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4272 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4274 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4275 Operate on live windows only.
4277 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4279 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4281 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4283 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4284 only under bidi iteration.
4286 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4288 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4290 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4292 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4293 Without this fix, the command to link temacs failed due to an
4294 undefined symbol __builtin_isnan. This is because
4295 /usr/include/iso/math_c99.h #defines isnan(x) to
4296 __builtin_isnan(x), but the bundled gcc, which identifies itself
4297 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4299 * floatfns.c (isnan): #undef, and then #define to a clone of
4301 (Fisnan): Always define, since it's always available now.
4302 (syms_of_floatfns): Always define isnan at the Lisp level.
4304 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4306 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4308 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4310 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4311 The previous code assumed that file offsets (off_t values) fit in
4312 EMACS_INT variables, which is not true on typical 32-bit hosts.
4313 The code messed up by falsely reporting buffer overflow in cases
4314 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4315 when "big" contains more than 2**29 bytes, even though this
4316 inserts just one byte and does not overflow the buffer.
4317 (Finsert_file_contents): Store file offsets as off_t
4318 values, not as EMACS_INT values. Check for overflow when
4319 converting between EMACS_INT and off_t. When checking for
4320 buffer overflow or for overlap, take the offsets into account.
4321 Don't use EMACS_INT for small values where int suffices.
4322 When checking for overlap, fix a typo: ZV was used where
4323 ZV_BYTE was intended.
4324 (Fwrite_region): Don't assume off_t fits into 'long'.
4325 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4327 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4329 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4331 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4333 sprintf-related integer and memory overflow issues (Bug#9412).
4335 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4336 (esprintf, exprintf, evxprintf): New functions.
4337 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4338 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4339 (modify_event_symbol): Do not assume that the length of
4340 name_alist_or_stem is safe to alloca and fits in int.
4341 (Fexecute_extended_command): Likewise for function name and binding.
4342 (Frecursion_depth): Wrap around reliably on integer overflow.
4343 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4344 since some callers pass EMACS_INT values.
4345 (Fsingle_key_description): Don't crash if symbol name contains more
4346 than MAX_ALLOCA bytes.
4347 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4348 (get_minibuffer): Arg is now EMACS_INT, not int.
4349 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4350 (esprintf, exprintf, evxprintf): New decls.
4351 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4353 * dbusbind.c (signature_cat): New function.
4354 (xd_signature, Fdbus_register_signal):
4355 Do not overrun buffer; instead, report string overflow.
4357 * dispnew.c (add_window_display_history): Don't overrun buffer.
4358 Truncate instead; this is OK since it's just a log.
4360 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4361 even if the time zone offset is outlandishly large.
4362 Don't mishandle offset == INT_MIN.
4364 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4365 when creating daemon; the previous buffer-overflow check was incorrect.
4367 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4368 which has the guts of the old verror function.
4370 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4371 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4373 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4374 (font_unparse_xlfd): Don't blindly alloca long strings.
4375 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4376 fits in int, when using sprintf. Use single snprintf to count
4377 length of string rather than counting it via multiple sprintfs;
4378 that's simpler and more reliable.
4379 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4380 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4381 sprintf, in case result does not fit in int.
4383 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4384 (fontset_from_font): Print it.
4386 * frame.c (tty_frame_count): Now printmax_t, not int.
4387 (make_terminal_frame, set_term_frame_name): Print it.
4388 (x_report_frame_params): In X, window IDs are unsigned long,
4389 not signed long, so print them as unsigned.
4390 (validate_x_resource_name): Check for implausibly long names,
4391 and don't assume name length fits in 'int'.
4392 (x_get_resource_string): Don't blindly alloca invocation name;
4393 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4396 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4397 (xg_check_special_colors, xg_set_geometry):
4398 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4400 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4401 Use esprintf, not sprintf, in case result does not fit in int.
4403 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4404 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4405 it as a large positive number.
4406 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4407 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4409 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4410 in case result does not fit in int.
4412 * print.c (float_to_string): Detect width overflow more reliably.
4413 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4414 buffer overrun. Don't assume list length fits in 'int'. Treat
4415 print length of 0 as 0, not as infinity; to be consistent with other
4416 uses of print length in this function. Don't overflow print length
4417 index. Don't assume hash table size fits in 'long', or that
4418 vectorlike size fits in 'unsigned long'.
4420 * process.c (make_process): Use printmax_t, not int, to format
4421 process-name gensyms.
4423 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4425 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4426 to avoid potential buffer overrun.
4428 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4429 if X resource line is longer than 512 bytes.
4431 * xfns.c (x_window): Make sprintf buffer a bit bigger
4432 to avoid potential buffer overrun.
4434 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4436 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4438 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4440 Integer overflow fixes for scrolling, etc.
4441 Without these, Emacs silently mishandles large integers sometimes.
4442 For example, "C-u 4294967297 M-x recenter" was treated as if
4443 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4445 * xdisp.c (try_window_id): Check Emacs fixnum range before
4446 converting to 'int'.
4448 * window.c (window_scroll_line_based, Frecenter):
4449 Check that an Emacs fixnum is in range before assigning it to 'int'.
4450 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4451 values converted from Emacs fixnums.
4452 (Frecenter): Don't wrap around a line count if it is out of 'int'
4453 range; instead, treat it as an extreme value.
4454 (Fset_window_configuration, compare_window_configurations):
4455 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4457 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4458 that can exceed INT_MAX. Check that EMACS_INT value is in range
4459 before assigning it to the (possibly-narrower) index.
4460 (match_limit): Don't assume that a fixnum can fit in 'int'.
4462 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4465 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4466 (Fvertical_motion): Don't wrap around LINES values that don't fit
4467 in 'int'. Instead, treat them as extreme values. This is good
4468 enough for windows, which can't have more than INT_MAX lines anyway.
4470 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4472 * Require libxml/parser.h to avoid compilation warning.
4474 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4476 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4477 since this reportedly can destroy thread storage.
4479 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4481 * syntax.c (find_defun_start): Update all cache variables if
4482 exiting early (Bug#9401).
4484 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4486 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4488 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4489 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4490 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4492 * term.c (tty_append_glyph): New function.
4493 (produce_stretch_glyph): Static function and its prototype deleted.
4495 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4498 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4500 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4501 when checking :margin (Bug#9390).
4502 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4503 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4504 so that the name doesn't mislead. All uses changed.
4506 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4508 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4511 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4513 * xdisp.c (move_it_to): Don't bail out early when reaching
4514 position beyond to_charpos, if we are scanning backwards.
4515 (move_it_vertically_backward): When DY == 0, make sure we get to
4516 the first character in the line after the newline.
4518 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4520 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4521 (ccl_driver): Do not generate an out-of-range pointer.
4522 (Fccl_execute_on_string): Remove unnecessary check for
4523 integer overflow, noted by Stefan Monnier in
4524 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4525 Remove a FIXME that didn't need fixing.
4526 Simplify the newly-introduced buffer reallocation code.
4528 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4530 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4532 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4534 Integer and memory overflow issues (Bug#9196).
4536 * doc.c (get_doc_string): Rework so that
4537 get_doc_string_buffer_size is the actual buffer size, rather than
4538 being 1 less than the actual buffer size; this makes xpalloc more
4541 * image.c (x_allocate_bitmap_record, cache_image):
4542 * xselect.c (Fx_register_dnd_atom):
4543 Simplify previous changes by using xpalloc.
4545 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4546 since either will do and ptrdiff_t is convenient with xpalloc.
4548 * charset.c (charset_table_size)
4549 (struct charset_sort_data.priority): Now ptrdiff_t.
4550 (charset_compare): Don't overflow if priorities differ greatly.
4551 (Fsort_charsets): Don't assume list length fits in int.
4552 Check for size-calculation overflow when allocating sort data.
4553 (syms_of_charset): Allocate an initial charset table that is
4554 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4556 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4558 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4559 The actual value is always <= INT_MAX, and leaving it unsigned made
4560 overflow checking harder.
4562 * dispextern.h (struct glyph_matrix.rows_allocated)
4563 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4564 with xpalloc. The values are still always <= INT_MAX.
4566 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4568 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4569 (SAFE_NALLOCA): New macro.
4571 * region-cache.c (struct boundary.pos, find_cache_boundary)
4572 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4573 (set_cache_region, invalidate_region_cache)
4574 (revalidate_region_cache, know_region_cache, region_cache_forward)
4575 (region_cache_backward, pp_cache):
4576 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4577 so that ptrdiff_t * can be passed to xpalloc.
4578 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4579 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4580 (pp_cache): Don't assume cache_len fits in int.
4581 * region-cache.h: Adjust extern decls to match.
4583 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4584 EMACS_INT, since either will do, for xpalloc.
4586 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4587 (xnmalloc, xnrealloc, xpalloc): New functions.
4589 * bidi.c (bidi_shelve_header_size): New constant.
4590 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4591 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4593 * bidi.c (bidi_cache_shrink):
4594 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4596 Don't update size of array until after memory allocation succeeds,
4597 because xmalloc/xrealloc may not return.
4598 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4599 now that we have proper integer overflow checking.
4600 (record_overlay_string, overlay_strings): Catch overflows when
4601 calculating size of overlay_str_buf.
4603 * callproc.c (Fcall_process): Check for size overflow when
4604 calculating size of args2.
4605 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4606 Normally we prefer signed values, but sticking with ptrdiff_t would
4607 require adding more-complicated checks.
4609 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4610 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4611 Redo buffer-overflow calculations to avoid integer overflow.
4612 Add a FIXME comment where memory seems to be over-allocated.
4614 * character.c (Fstring): Check for size-calculation overflow.
4616 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4617 unnecessary integer overflow. Check for size overflow.
4618 (encode_coding_object): Don't update size until xmalloc succeeds.
4620 * composite.c (get_composition_id): Check for overflow in glyph
4621 length calculations.
4623 Integer and memory overflow fixes for display code.
4624 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4625 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4626 (scrolling_window): Check for overflow in size calculations.
4627 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4628 Don't assume glyph table len fits in int.
4629 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4630 (row_table_size): Now ptrdiff_t, not int.
4631 (scrolling_window): Avoid overflow in size calculations.
4632 Don't update size until allocation succeeds.
4633 * fns.c (concat): Check for overflow in size calculations.
4634 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4635 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4636 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4638 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4639 (get_doc_string): Check for size calculation overflow.
4640 Don't update size until allocation succeeds.
4641 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4642 EMACS_INT, where ptrdiff_t will do.
4643 (Fsubstitute_command_keys): Check for string overflow.
4645 * editfns.c (set_time_zone_rule): Don't assume environment length
4647 (message_length): Now ptrdiff_t, not int.
4648 (Fmessage_box): Don't update size until allocation succeeds.
4649 Don't assume message length fits in int.
4650 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4652 * emacs.c (main): Do not reallocate argv, since there is a null at
4653 the end that can be overwritten, and this way there's no need to
4654 worry about size-calculation overflow.
4655 (sort_args): Check for size-calculation overflow.
4657 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4659 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4661 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4662 (x_set_scroll_bar_width, x_figure_window_size):
4663 Check for integer overflow.
4664 (x_set_alpha): Do not assume XINT fits in int.
4666 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4667 This is for the members text_lines, text_cols, total_lines, total_cols,
4668 where the system imposes an 'int' limit.
4670 * fringe.c (Fdefine_fringe_bitmap):
4671 Don't update size until alloc works.
4673 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4674 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4676 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4677 Check for size-calculation overflow.
4678 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4679 do, as we prefer signed integers.
4680 (id_to_widget.max_size, id_to_widget.used)
4681 (xg_store_widget_in_map, xg_remove_widget_from_map)
4682 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4683 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4684 Use and return ptrdiff_t, not int.
4685 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4686 * gtkutil.h: Change prototypes to match the above.
4688 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4689 are duplicate now that they've been promoted to lisp.h.
4690 (x_allocate_bitmap_record, x_alloc_image_color)
4691 (make_image_cache, cache_image, xpm_load):
4692 Don't update size until alloc is done.
4693 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4695 Check for size calculation overflow.
4696 (ct_colors_allocated_max): New constant.
4697 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4700 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4701 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4702 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4703 Use ptrdiff_t, not int, to count maps.
4704 (read_char_minibuf_menu_prompt): Check for overflow in size
4705 calculations. Don't update size until allocation succeeds.
4706 Redo calculations to avoid overflow.
4707 * keyboard.h: Change prototypes to match the above.
4709 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4711 (current_minor_maps): Check for size calculation overflow.
4712 * keymap.h: Change prototypes to match the above.
4714 * lread.c (read1, init_obarray): Don't update size until alloc done.
4716 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4717 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4719 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4720 Now ptrdiff_t, not int.
4721 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4722 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4724 * process.c (Fnetwork_interface_list): Check for overflow
4725 in size calculation.
4727 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4729 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4730 overflow. Don't bother calling xmalloc when xrealloc will do.
4732 * search.c (Freplace_match): Check for size calculation overflow.
4733 (Fset_match_data): Don't assume list lengths fit in 'int'.
4735 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4736 for command line length. Do not attempt to address one before the
4737 beginning of an array, as that's not portable.
4739 * term.c (max_frame_lines): Remove; unused.
4740 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4742 (encode_terminal_code, calculate_costs): Check for size
4743 calculation overflow.
4744 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4745 table lengths and related sizes. Don't update size until alloc
4746 done. Redo calculations to avoid overflow.
4747 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4749 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4750 subtracting pointers.
4751 (gobble_line): Check for overflow more carefully. Don't update size
4754 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4755 Don't update size until alloc done.
4756 Redo size calculations to avoid overflow.
4757 Check for size calculation overflow.
4758 (main) [DEBUG]: Fix typo in invoking tparam1.
4760 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4761 Use ptrdiff_t, not int, for sizes.
4762 (store_mode_line_noprop_char): Don't update size until alloc done.
4764 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4765 Use ptrdiff_t, not int, for sizes.
4766 (Finternal_make_lisp_face, cache_face):
4767 Check for size calculation overflow.
4768 (cache_face): Treat size calculation overflows as if they were
4769 memory exhaustion (the usual treatment), rather than aborting.
4771 * xfns.c (x_encode_text, x_set_name_internal)
4772 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4773 sizes, since they can exceed INT_MAX in size. Check for size
4774 calculation overflow.
4776 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4777 (xg_select): Check for size calculation overflow.
4778 Don't update size until alloc done.
4780 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4781 as sprintf is limited to int lengths.
4783 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4784 (X_LONG_MIN): New macros.
4785 Use them to make the following changes clearer.
4786 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4787 This change doesn't affect the value now, but it may help remind
4788 future maintainers not to raise the value too much later.
4789 (SELECTION_QUANTUM): Remove, replacing with ...
4790 (selection_quantum): ... new function, which avoids overflow.
4792 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4793 assumption that selection length fits in 'int'.
4794 (x_reply_selection_request, x_handle_selection_request)
4795 (x_get_window_property, receive_incremental_selection)
4796 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4797 (lisp_data_to_selection_data, clean_local_selection_data):
4798 Use ptrdiff_t, not int, to record length of selection.
4799 (x_reply_selection_request, x_get_window_property)
4800 (receive_incremental_selection, x_property_data_to_lisp):
4801 Redo calculations to avoid overflow.
4802 (x_reply_selection_request): When sending hint, ceiling it at
4803 X_LONG_MAX rather than relying on wraparound overflow to send
4805 (x_get_window_property, receive_incremental_selection)
4806 (lisp_data_to_selection_data, x_property_data_to_lisp):
4807 Check for size-calculation overflow.
4808 (x_get_window_property, receive_incremental_selection)
4809 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4810 Don't store size until memory allocation succeeds.
4811 (x_get_window_property): Plug memory leak on memory exhaustion.
4812 Don't double-block input; malloc is safe here. Don't assume 2**34
4813 - 4 fits in unsigned long. Add an xassert to check
4814 XGetWindowProperty overflow. Be more careful about overflow
4815 calculations, and distinguish size from memory overflow better.
4816 (receive_incremental_selection): When tracing, don't assume
4817 unsigned int is less than INT_MAX.
4818 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4819 harmful) conversions of unsigned short to int.
4820 (lisp_data_to_selection_data): Don't assume that integers
4821 in the range -65535 through -1 fit in an X unsigned short.
4822 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4823 result parameters unless successful. Rely on cons_to_unsigned
4824 to report problems with elements; the old code wasn't right anyway.
4825 (x_check_property_data): Check for int overflow; we cannot use
4826 a wider type due to X limits.
4827 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4829 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4831 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4832 (x_term_init): Check for size calculation overflow.
4833 (x_color_cells): Don't store size until memory allocation succeeds.
4834 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4835 Don't assume alloca size is less than MAX_ALLOCA.
4836 (x_term_init): Don't assume length fits in int (sprintf is limited
4839 Use ptrdiff_t for composition IDs.
4840 * character.c (lisp_string_width):
4841 * composite.c (composition_table_size, n_compositions)
4842 (get_composition_id, composition_gstring_from_id):
4843 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4844 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4845 * window.c (Frecenter):
4846 Use ptrdiff_t, not int, for composition IDs.
4847 * composite.c (get_composition_id): Check for integer overflow.
4848 * composite.h: Adjust prototypes to match the above changes.
4850 Use ptrdiff_t for hash table indexes.
4851 * category.c (hash_get_category_set):
4852 * ccl.c (ccl_driver):
4853 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4854 * coding.c (coding_system_charset_list, detect_coding_system):
4855 * coding.h (struct coding_system.id):
4856 * composite.c (get_composition_id, gstring_lookup_cache):
4857 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4858 * image.c (xpm_get_color_table_h):
4859 * lisp.h (hash_lookup, hash_put):
4860 * minibuf.c (Ftest_completion):
4861 Use ptrdiff_t for hash table indexes, not int (which is too
4862 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4863 32-bit --with-wide-int hosts).
4865 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4866 Add a FIXME comment about memory leaks.
4867 (syms_of_charset): Don't assume xmalloc returns.
4869 Don't assume that stated character widths fit in int.
4870 * character.c (Fchar_width, c_string_width, lisp_string_width):
4871 * character.h (CHAR_WIDTH):
4872 * indent.c (MULTIBYTE_BYTES_WIDTH):
4873 Use sanitize_char_width to avoid undefined and/or bad behavior
4874 with outlandish widths.
4875 * character.h (sanitize_tab_width): Rename from sanitize_width,
4876 now that we have two such functions. All uses changed.
4877 (sanitize_char_width): New inline function.
4879 Don't assume that tab-width fits in int.
4880 * character.h (sanitize_width): New inline function.
4881 (SANE_TAB_WIDTH): New macro.
4882 (ASCII_CHAR_WIDTH): Use it.
4883 * indent.c (sane_tab_width): Remove. All uses replaced by
4884 SANE_TAB_WIDTH (current_buffer).
4885 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4887 * fileio.c: Integer overflow issues with file modes.
4888 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4890 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4891 Remove unreachable code.
4892 (read_hex, load_charset_map_from_file): Check for integer overflow.
4894 * xterm.c: Don't go over XClientMessageEvent limit.
4895 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4896 (x_send_scroll_bar_event): Likewise. Check that the size does not
4897 exceed limits imposed by XClientMessageEvent, as well as the usual
4898 ptrdiff_t and size_t limits.
4900 * keyboard.c: Overflow, signedness and related fixes.
4901 (make_lispy_movement): Use same integer type in forward decl
4902 that is used in the definition.
4903 (read_key_sequence, keyremap_step):
4904 Change bufsize argument back to int, undoing my 2011-03-30 change.
4905 We prefer signed types, and int is wide enough here.
4906 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4907 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4908 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4909 length, not size_t. Use ptrdiff_t for index, not int.
4910 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4911 possibility of integer overflow.
4913 Overflow, signedness and related fixes for images.
4915 * dispextern.h (struct it.stack[0].u.image.image_id)
4916 (struct_it.image_id, struct image.id, struct image_cache.size)
4917 (struct image_cache.used, struct image_cache.ref_count):
4918 * gtkutil.c (update_frame_tool_bar):
4919 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4920 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4921 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4922 * nsmenu.m (update_frame_tool_bar):
4923 * xdisp.c (calc_pixel_width_or_height):
4924 * xfns.c (image_cache_refcount):
4925 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4926 on typical 64-bit hosts.
4928 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4929 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4930 Omit unnecessary casts to int.
4931 (parse_image_spec): Check that integers fall into 'int' range
4932 when the callers expect that.
4933 (image_ascent): Redo ascent calculation to avoid int overflow.
4934 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4935 (lookup_image): Remove unnecessary tests.
4936 (xbm_image_p): Locals are now of int, not EMACS_INT,
4937 since parse_image_check makes sure they fit into int.
4938 (png_load, gif_load, svg_load_image):
4939 Prefer int to unsigned where either will do.
4940 (tiff_handler): New function, combining the cores of the
4941 old tiff_error_handler and tiff_warning_handler.
4942 This function is rewritten to use vsnprintf and thereby avoid
4943 stack buffer overflows. It uses only the features of vsnprintf
4944 that are common to both POSIX and native Microsoft.
4945 (tiff_error_handler, tiff_warning_handler): Use it.
4946 (tiff_load, gif_load, imagemagick_load_image):
4947 Don't assume :index value fits in 'int'.
4948 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4949 (imagemagick_load_image): Check that crop parameters fit into
4950 the integer types that MagickCropImage accepts. Don't assume
4951 Vimagemagick_render_type has a nonnegative value. Don't assume
4952 size_t fits in 'long'.
4953 (gs_load): Use printmax_t to print the widest integers possible.
4954 Check for integer overflow when computing image height and width.
4956 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4958 * xdisp.c (redisplay_window): Don't force window start if point
4959 will be invisible in the resulting window. (Bug#9324)
4961 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4963 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4964 the display spec is of the form `(space ...)'.
4965 (handle_display_spec): Return the value returned by
4966 handle_single_display_spec, not just 1 or zero.
4967 (handle_single_display_spec): If the display spec is of the form
4968 `(space ...)', and specifies display in the text area, return 2
4970 (try_cursor_movement): Check for the need to scroll more
4971 accurately, and prefer exact match for point under bidi.
4972 Don't advance `row' beyond the last row of the window.
4974 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4975 into disp_prop; all users changed.
4977 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4978 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4979 for the text covered by the display property.
4981 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4983 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4984 Change return value to nil.
4985 (Frecord_buffer): Delete unused function.
4987 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4989 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4990 buffers, return left-to-right.
4991 (set_cursor_from_row): Consider candidate row a win if its glyph
4992 represents a newline and point is on that newline. Fixes cursor
4993 positioning on the newline at EOL of R2L text within L2R
4994 paragraph, and vice versa.
4995 (try_cursor_movement): Check continued rows, in addition to
4996 continuation rows. Fixes unwarranted scroll when point enters a
4997 continued line of R2L text within an L2R paragraph, or vice versa.
4998 (cursor_row_p): Consider the case of point being equal to
4999 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5000 from the end of a short line to the beginning of a continued line
5001 of R2L text within L2R paragraph.
5002 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5003 composed characters.
5005 * bidi.c (bidi_check_type): Use xassert.
5006 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5009 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5011 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5014 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5016 * nsfont.m (ns_otf_to_script): Fix typo.
5018 2011-08-22 Kenichi Handa <handa@m17n.org>
5020 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5021 extra slot even if the purpose is char-code-property-table.
5023 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5025 * xdisp.c (redisplay_window): When computing centering_position,
5026 account for the height of the header line. (Bug#8874)
5028 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5029 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5030 candidate is selected by the mouse, and that candidate has a
5031 composed character under the mouse.
5033 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5034 coordinates reported by pos-visible-in-window-p for a composed
5035 character in column zero.
5037 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5039 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5041 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5043 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5044 consider it a hit if to_charpos is anywhere in the range of the
5045 composed buffer positions.
5047 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5049 * image.c (gif_load): Don't assume that each subimage has the same
5050 dimensions as the base image. Handle disposal method that is
5051 "undefined" by the gif spec (Bug#9335).
5053 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5055 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5056 (Fcondition_case): Document `debug' symbol in error handler.
5058 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5060 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5061 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5062 from an Org mode buffer to a Speedbar frame.
5064 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5065 a composition, take its buffer position from IT->cmp_it.charpos.
5066 Fixes cursor positioning at the beginning of a line that begins
5067 with a composed character.
5069 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5071 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5072 character bidirectional type, use STRONG_L instead. Fixes crashes
5073 in a buffer produced by `describe-categories'.
5075 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5076 members before the level stack, so they would be saved and
5077 restored when copying iterator state. Fixes incorrect reordering
5078 around TABs covered by display properties.
5080 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5082 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5084 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5086 * eval.c (internal_condition_case, internal_condition_case_1)
5087 (internal_condition_case_2, internal_condition_case_n):
5088 Remove unnecessary aborts (Bug#9081).
5090 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5092 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5093 has no `load' handler, try opening the file locally. (Bug#9311)
5095 2011-08-16 Ken Brown <kbrown@cornell.edu>
5097 * gmalloc.c: Expand comment.
5099 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5101 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5102 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5104 2011-08-16 Ken Brown <kbrown@cornell.edu>
5106 Fix memory allocation problems in Cygwin build (Bug#9273).
5108 * unexcw.c ( __malloc_initialized): Declare external variable.
5109 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5111 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5113 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5115 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5117 [CYGWIN] (special_realloc): New function.
5118 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5119 requests to realloc storage in the static heap.
5121 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5123 * bidi.c (bidi_initialize): Remove unused local.
5125 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5128 * biditype.h: Remove file.
5129 * makefile.w32-in ($(BLD)/bidi.$(O)):
5130 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5132 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5134 * chartab.c: Improve commentary for the uniprop_table API.
5136 * bidi.c (bidi_paragraph_init): Support zero value of
5137 bidi_ignore_explicit_marks_for_paragraph_level.
5138 (bidi_initialize): Use uniprop_table instead of including
5139 biditype.h and bidimirror.h.
5141 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5142 coordinates of the iterator when restoring from ppos_it.
5145 2011-08-14 Kenichi Handa <handa@m17n.org>
5147 * process.c (create_process): Call setup_process_coding_systems
5148 after the pid of the process is set to -1 (Bug#8162).
5150 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5152 * xdisp.c (move_it_in_display_line_to): Don't invoke
5153 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5154 ppos_it. Fixes vertical cursor motion when line beginning is
5155 covered by an image. (Bug#9296)
5157 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5159 * nsterm.h (ns_run_ascript): Declare.
5160 (NSAPP_DATA2_RUNASSCRIPT): Define.
5162 * nsfns.m (as_script, as_result, as_status): New static variables.
5163 (ns_run_ascript): New function.
5164 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5165 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5166 the event loop. Get status from as_status (Bug#7276).
5168 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5169 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5170 the event loop (Bug#7276).
5172 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5174 * gnutls.c (QCgnutls_bootprop_priority)
5175 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5176 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5177 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5178 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5179 (QCgnutls_bootprop_verify_hostname_error)
5180 (QCgnutls_bootprop_callbacks_verify): Rename from
5181 Qgnutls_bootprop_..., all uses changed.
5183 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5186 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5188 * xfaces.c (Qframe_set_background_mode): Now static.
5189 * dispextern.h (Qframe_set_background_mode): Remove decl.
5191 * process.c (Fnetwork_interface_info): Declare local only if needed.
5193 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5195 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5196 (Fnetwork_interface_list): Allocate in increments of bytes instead
5197 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5198 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5200 (struct ifflag_def): notrailers is smart on OSX.
5201 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5202 Get hardware address with getifaddrs if available.
5204 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5206 * xdisp.c (iterate_out_of_display_property): xassert that
5207 IT->position is set to within IT->object's boundaries. Break from
5208 the loop as soon as EOB is reached; avoids infloops in redisplay
5209 when IT->position is set up wrongly due to some bug.
5210 Set IT->current to match the bidi iterator unconditionally.
5211 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5212 entry. Force push_it to save on the stack the current
5213 buffer/string position, to be restored by pop_it. Fix flags in
5214 the iterator structure wrt the object coming from a display
5215 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5216 properties. (Bug#9284)
5218 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5220 * fontset.c (fontset_get_font_group): Add proper type checks.
5223 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5225 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5226 and LC_VERSION_MIN_MACOSX.
5227 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5228 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5230 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5232 * xdisp.c (forward_to_next_line_start): Allow to use the
5233 no-display-properties-and-no-overlays under bidi display.
5234 Set disp_pos in the bidi iterator to avoid searches for display
5235 properties and overlays.
5237 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5239 * editfns.c (Fset_time_zone_rule): Document relationship with the
5242 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5243 the font entity extracted from the cache (Bug#8109).
5245 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5247 * composite.c (autocmp_chars): Don't reset point. That is done by
5248 restore_point_unwind (Bug#5984).
5250 2011-08-07 Juri Linkov <juri@jurta.org>
5252 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5253 to show the arg `TIME' instead of `TIMEVAL'.
5255 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5257 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5258 display property strides EOL and includes a newline, as in
5259 longlines-mode. (Bug#9254)
5260 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5261 word-wrap under bidirectional display. (Bug#9224)
5263 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5264 is non-zero, even if the data buffer is NULL. Fixes a crash in
5265 vertical-motion with longlines-mode. (Bug#9254)
5267 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5269 * bidi.c <bidi_cache_total_alloc>: Now static.
5270 (bidi_initialize): Initialize bidi_cache_total_alloc.
5272 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5275 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5276 amount allocated this far in `bidi_cache_total_alloc'.
5277 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5278 non-zero, only free the data buffer without restoring the cache
5279 contents. All callers changed.
5281 * dispextern.h (bidi_unshelve_cache): Update prototype.
5283 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5284 (move_it_in_display_line, move_it_to)
5285 (move_it_vertically_backward, move_it_by_lines): Replace the call
5286 to xfree to an equivalent call to bidi_unshelve_cache.
5287 (move_it_in_display_line_to): Fix logic of returning
5288 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5290 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5292 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5293 came from a string character with a `cursor' property. (Bug#9229)
5295 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5297 * Makefile.in (LIB_PTHREAD): New variable.
5298 (LIBES): Add LIB_PTHREAD (Bug#9216).
5300 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5301 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5303 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5305 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5307 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5309 * xterm.c (x_find_topmost_parent): New function.
5310 (x_set_frame_alpha): Find topmost parent window with
5311 x_find_topmost_parent and set the property there also (bug#9181).
5312 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5314 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5316 * callproc.c (Fcall_process): Avoid vfork clobbering
5317 the local vars buffer, coding_systems, current_dir.
5319 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5321 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5323 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5325 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5326 so that it is not optimized away.
5328 * xdisp.c (compute_display_string_pos): Remove unused local.
5330 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5332 Fix slow cursor motion and scrolling in large buffers with
5333 selective display, like Org Mode buffers. (Bug#9218)
5335 * dispextern.h (struct bidi_it): New member disp_prop_p.
5337 * xdisp.c: Remove one-slot cache of display string positions.
5338 (compute_display_string_pos): Accept an additional argument
5339 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5340 for a display string or property. If found, set DISP_PROP_P
5343 * bidi.c (bidi_fetch_char): Accept an additional argument
5344 DISP_PROP_P, and pass it to compute_display_string_pos.
5345 Only handle text covered by a display string if DISP_PROP_P is returned
5346 non-zero. All callers of bidi_fetch_char changed.
5348 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5350 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5352 2010-12-03 Don March <don@ohspite.net>
5354 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5355 last character M-[char] is translated to ESC [char] (bug#7541).
5357 2011-08-02 Kenichi Handa <handa@m17n.org>
5359 * lisp.h (uniprop_table): Extern it.
5361 * chartab.c (uniprop_table): Make it non-static.
5363 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5365 * xdisp.c (forward_to_next_line_start): Accept additional argument
5366 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5368 (reseat_at_next_visible_line_start): Use the bidi iterator state
5369 returned by forward_to_next_line_start to restore the state of
5370 it->bidi_it after backing up to previous newline. (Bug#9212)
5372 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5374 * regex.c (re_comp): Protoize.
5375 (re_exec): Fix return type.
5376 (regexec): Fix type of `ret'. (Bug#9203)
5378 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5380 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5381 This is needed if max-image-size is a floating-point number.
5383 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5385 * print.c (print_object): Print empty symbol as ##.
5387 * lread.c (read1): Read ## as empty symbol.
5389 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5391 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5392 setting frame foreground color (Bug#9175).
5393 (x_set_background_color): Likewise.
5395 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5396 contents (Bug#9176).
5397 (EmacsTooltip -init): Remove bezels and add shadows to
5400 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5401 or scroll bar (Bug#8470).
5403 * nsfont.m (nsfont_open): Remove assignment to voffset and
5404 unnecessary vars hshink, expand, hd, full_height, min_height.
5405 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5407 * nsterm.h (nsfont_info): Remove voffset field.
5409 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5411 Implement strike-through and overline on NextStep (Bug#8863).
5413 * nsfont.m (nsfont_open): Use underline position provided by font,
5414 instead of hard-coded value of 2.
5415 (nsfont_draw): Call ns_draw_text_decoration instead.
5417 * nsterm.h: Add declaration for ns_draw_text_decoration.
5419 * nsterm.m (ns_draw_text_decoration): New function for drawing
5420 underline, overline, and strike-through.
5421 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5422 ns_draw_text_decoration. Change treatment of cursor drawing to
5423 accommodate underlining, etc.
5425 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5427 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5430 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5432 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5433 Without this fix, if a signal arrives just after memory fills up,
5434 'malloc' might be invoked reentrantly.
5436 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5437 In other words, assume that every image size is allowed, on non-X
5438 hosts. This assumption is probably wrong, but it lets Emacs compile.
5440 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5442 * regex.c (re_iswctype): Convert return values to boolean.
5444 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5446 * xdisp.c (compute_display_string_pos): Don't use cached display
5447 string position if the buffer had its restriction changed.
5450 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5452 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5454 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5456 Integer signedness and overflow and related fixes. (Bug#9079)
5458 * bidi.c: Integer size and overflow fixes.
5459 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5460 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5461 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5462 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5463 (bidi_find_other_level_edge):
5464 Use ptrdiff_t instead of EMACS_INT where either will do.
5465 This works better on 32-bit hosts configured --with-wide-int.
5466 (bidi_cache_ensure_space): Check for size-calculation overflow.
5467 Use % rather than repeated addition, for better worst-case speed.
5468 Don't set bidi_cache_size until after xrealloc returns, because it
5470 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5471 (bidi_cache_ensure_space): Also check that the bidi cache size
5472 does not exceed that of the largest Lisp string or buffer. See Eli
5473 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5475 * alloc.c (__malloc_size_t): Remove.
5476 All uses replaced by size_t. See Andreas Schwab's note
5477 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5479 * image.c: Improve checking for integer overflow.
5480 (check_image_size): Assume that f is nonnull, since
5481 it is always nonnull in practice. This is one less thing to
5482 worry about when checking for integer overflow later.
5483 (x_check_image_size): New function, which checks for integer
5484 overflow issues inside X.
5485 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5486 This removes the need for a memory_full check.
5487 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5488 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5489 (xbm_read_bitmap_data): Change locals back to 'int', since
5490 their values must fit in 'int'.
5491 (xpm_load_image, png_load, tiff_load):
5492 Invoke x_create_x_image_and_pixmap earlier,
5493 to avoid much needless work if the image is too large.
5494 (tiff_load): Treat overly large images as if
5495 x_create_x_image_and_pixmap failed, not as malloc failures.
5496 (gs_load): Use x_check_image_size.
5498 * gtkutil.c: Omit integer casts.
5499 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5500 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5502 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5504 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5505 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5506 would wrongly return t on a 64-bit host.
5508 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5509 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5510 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5511 and therefore cause GCC to emit a bogus diagnostic in some cases.
5513 * image.c: Integer signedness and overflow and related fixes.
5514 This is not an exhaustive set of fixes, but it's time to
5515 record what I've got.
5516 (lookup_pixel_color, check_image_size): Remove redundant decls.
5517 (check_image_size): Don't assume that arbitrary EMACS_INT values
5518 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5519 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5520 (tiff_load, imagemagick_load_image):
5521 Check for overflow in size calculations.
5522 (x_create_x_image_and_pixmap): Remove unnecessary test for
5523 xmalloc returning NULL; that can't happen.
5524 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5525 (xpm_color_bucket): Use better integer hashing function.
5526 (xpm_cache_color): Don't possibly over-allocate memory.
5527 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5528 (gif_memory_source):
5529 Use ptrdiff_t, not int or size_t, to record sizes.
5530 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5531 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5532 either works, as we prefer signed integers.
5533 (tiff_read_from_memory, tiff_write_from_memory):
5534 Return tsize_t, not size_t, since that's what the TIFF API wants.
5535 (tiff_read_from_memory): Don't fail simply because the read would
5536 go past EOF; instead, return a short read.
5537 (tiff_load): Omit no-longer-needed casts.
5538 (Fimagemagick_types): Don't assume size fits into 'int'.
5540 Improve hashing quality when configured --with-wide-int.
5541 * fns.c (hash_string): New function, taken from sxhash_string.
5542 Do not discard information about ASCII character case; this
5543 discarding is no longer needed.
5544 (sxhash-string): Use it. Change sig to match it. Caller changed.
5545 * lisp.h: Declare it.
5546 * lread.c (hash_string): Remove, since we now use fns.c's version.
5547 The fns.c version returns a wider integer if --with-wide-int is
5548 specified, so this should help the quality of the hashing a bit.
5550 * emacs.c: Integer overflow minor fix.
5551 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5552 Define only if GNU_LINUX.
5553 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5555 * dispnew.c: Integer signedness and overflow fixes.
5556 Remove unnecessary forward decls, that were a maintenance hassle.
5557 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5559 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5560 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5561 (prepare_desired_row, line_draw_cost):
5562 Use int, not unsigned, where either works.
5563 (save_current_matrix, restore_current_matrix):
5564 Use ptrdiff_t, not size_t, where either works.
5565 (init_display): Check for overflow more accurately, and without
5566 relying on undefined behavior.
5568 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5569 Remove, replacing with the new symbols in lisp.h. All uses changed.
5570 * fileio.c (make_temp_name):
5571 * filelock.c (lock_file_1, lock_file):
5572 * xdisp.c (message_dolog):
5573 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5574 Use pMd etc. instead.
5575 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5576 replacing the pWIDE etc. symbols removed from editfns.c.
5578 * keyboard.h (num_input_events): Now uintmax_t.
5579 This is (very slightly) less likely to mess up due to wraparound.
5582 * buffer.c: Integer signedness fixes.
5583 (alloc_buffer_text, enlarge_buffer_text):
5584 Use ptrdiff_t rather than size_t when either will do, as we prefer
5587 * alloc.c: Integer signedness and overflow fixes.
5588 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5589 (__malloc_size_t): Default to size_t, not to int.
5590 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5591 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5592 Prefer ptrdiff_t to size_t when either would do, as we prefer
5594 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5595 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5596 Now const. Initialize with values that are in range even if char
5598 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5599 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5600 These functions do the right thing with sizes > 2**32.
5601 (check_depth): Now ptrdiff_t, not int.
5602 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5603 Adjust to new way of storing sizes. Check for size overflow bugs
5605 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5606 slightly wrong anyway, as it missed one instance of
5607 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5608 (refill_memory_reserve): Omit needless cast to size_t.
5609 (mark_object_loop_halt): Mark as externally visible.
5611 * xselect.c: Integer signedness and overflow fixes.
5612 (Fx_register_dnd_atom, x_handle_dnd_message):
5613 Use ptrdiff_t, not size_t, since we prefer signed.
5614 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5615 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5616 x_dnd_atoms_size and x_dnd_atoms_length.
5618 * doprnt.c: Prefer signed to unsigned when either works.
5620 * doprnt.c (doprnt):
5622 * xdisp.c (vmessage):
5623 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5624 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5625 prefer signed arithmetic to avoid comparison confusion.
5626 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5627 but is a bit tricky.
5629 Assume freestanding C89 headers, string.h, stdlib.h.
5630 * data.c, doprnt.c, floatfns.c, print.c:
5631 Include float.h unconditionally.
5632 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5633 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5634 * regex.c: Likewise for stddef.h, string.h.
5635 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5636 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5637 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5638 (STDC_HEADERS): Remove obsolete defines.
5639 * sysdep.c: Include limits.h unconditionally.
5641 Assume support for memcmp, memcpy, memmove, memset.
5642 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5643 * regex.c (memcmp, memcpy):
5644 Remove; we assume C89 now.
5646 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5647 (__malloc_safe_bcopy): Remove; no longer needed.
5649 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5650 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5651 well either way, and we prefer signed to unsigned.
5653 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5655 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5656 closes the connection while we're reading (bug#9182).
5658 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5660 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5661 are specified (Bug#9168).
5663 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5665 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5666 Found by GCC static checking and --with-wide-int on a 32-bit host.
5668 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5670 * xdisp.c (compute_display_string_pos): Fix logic of caching
5671 previous display string position. Initialize cached_prev_pos to
5672 -1. Fixes slow-down at the beginning of a buffer.
5674 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5676 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5677 for attrs[LFACE_FONTSET_INDEX].
5679 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5681 * xml.c (parse_region): Remove unused local
5682 that was recently introduced.
5684 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5686 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5687 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5689 * xdisp.c (move_it_in_display_line_to): Record the best matching
5690 position for TO_CHARPOS while scanning the line, and restore it on
5691 exit if none of the characters scanned was an exact match.
5692 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5693 when exact match is impossible due to invisible text, and the
5694 lines are truncated.
5696 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5698 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5701 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5703 Fix a significant slow-down of cursor motion with C-n, C-p,
5704 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5705 auto-repeat under bidi redisplay in fontified buffers.
5706 * xdisp.c (compute_stop_pos_backwards): New function.
5707 (next_element_from_buffer): Call compute_stop_pos_backwards to
5708 find a suitable prev_stop when we find ourselves before
5710 (reseat): Don't look for prev_stop, as that could mean a very long
5712 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5713 <cached_disp_overlay_modiff>: Cache for last found display string
5715 (compute_display_string_pos): Return the cached position if asked
5716 about the same buffer in the same area of character positions, and
5717 the buffer wasn't changed since the time the display string
5718 position was cached.
5720 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5722 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5723 is an integer, which is important for empty lines. (Bug#9149)
5725 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5727 * frame.c (Fmodify_frame_parameters): In tty case, update the
5728 default face if necessary (Bug#4238).
5730 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5732 * editfns.c (Fstring_to_char): No need to explain what a character
5733 is in the docstring (Bug#6576).
5735 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5737 * xml.c (parse_region): Make sure we always return a tree.
5739 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5741 * xml.c (parse_region): If a document contains only comments,
5744 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5746 * xml.c (make_dom): Return comments, too.
5748 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5751 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5752 and the surrounding thread.
5753 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5754 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5755 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5757 * s/openbsd.h (BROKEN_SIGIO): Define.
5758 * unexelf.c (unexec) [__OpenBSD__]:
5759 Don't update the .mdebug section of the Alpha COFF symbol table.
5761 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5763 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5766 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5768 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5769 This fixes some race conditions on the permissions of any newly
5772 * alloc.c (valid_pointer_p): Use pipe, not open.
5773 This fixes some permissions issues when debugging.
5775 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5776 If fchown fails to set both uid and gid, try to set just gid,
5777 as that is sometimes allowed. Adjust the file's mode to eliminate
5778 setuid or setgid bits that are inappropriate if fchown fails.
5780 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5782 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5783 to compare Lisp_Objects.
5784 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5785 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5786 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5788 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5790 * lread.c (read_integer): Unread even EOF character.
5791 (read1): Likewise. Properly record start position of symbol.
5793 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5794 symbol character follows.
5796 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5798 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5799 This works around a problem with the previous change to Fcopy_file.
5800 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5801 and without this change, GCC might complain about discarding
5802 fchown's return value.
5804 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5806 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5808 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5810 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5812 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5814 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5815 it's used from the C level.
5817 * process.c: Use the same condition for POLL_FOR_INPUT in both
5818 keyboard.c and process.c (bug#1858).
5820 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5822 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5823 (Fgnutls_boot): Use it.
5825 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5827 * doc.c (Fsubstitute_command_keys): Revert last change.
5829 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5831 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5832 quotes the next character, and doesn't affect other longer
5833 sequences (bug#8935).
5835 * lread.c (syms_of_lread): Clarify that is isn't only
5836 `eval-buffer' and `eval-defun' that's affected by
5837 `lexical-binding' (bug#8460).
5839 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5841 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5842 bidi redisplay when a line includes both an image and is truncated.
5844 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5846 Fix minor problems found by static checking.
5847 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5848 (elsz): Now a signed constant, not a size_t var. We prefer signed
5849 types to unsigned, to avoid integer comparison confusion. Without
5850 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5851 "cannot optimize loop, the loop counter may overflow", a symptom
5853 * indent.c (Fvertical_motion): Mark locals as initialized.
5854 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5856 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5858 * search.c (Fre_search_backward): Mention `case-fold-search' in
5859 all the re_search_* functions (bug#8138).
5861 * keyboard.c (Fopen_dribble_file): Document when the file is
5864 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5866 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5869 Support bidi reordering of display and overlay strings.
5870 * xdisp.c (compute_display_string_pos)
5871 (compute_display_string_end): Accept additional argument STRING.
5872 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5873 (reseat_to_string): Initialize bidi_it->string.s and
5874 bidi_it->string.schars.
5875 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5876 NULL (avoids a crash in bidi_paragraph_init).
5877 Initialize itb.string.lstring.
5878 (init_iterator): Call bidi_init_it only of a valid
5879 buffer position was specified. Initialize paragraph_embedding to
5881 (reseat_to_string): Initialize the bidi iterator.
5882 (display_string): If we need to ignore text properties of
5883 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5884 original value of -1 will not work with bidi.)
5885 (compute_display_string_pos): First arg is now struct
5886 `text_pos *'; all callers changed. Support display properties on
5888 (compute_display_string_end): Support display properties on Lisp
5890 (init_iterator, reseat_1, reseat_to_string): Initialize the
5891 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5892 when iterating on a string not from display properties).
5893 (compute_display_string_pos, compute_display_string_end):
5894 Fix calculation of the object to scan. Fixes an error when using
5896 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5897 base_level_stop; instead, set base_level_stop to BEGV.
5898 Fixes crashes in vertical-motion.
5899 (next_element_from_buffer): Improve commentary for when
5900 the iterator is before prev_stop.
5901 (init_iterator): Initialize bidi_p from the default value of
5902 bidi-display-reordering, not from buffer-local value. Use the
5903 buffer-local value only if initializing for buffer iteration.
5904 (handle_invisible_prop): Support invisible properties on strings
5905 that are being bidi-reordered.
5906 (set_iterator_to_next): Support bidi reordering of C strings and
5908 (next_element_from_string): Support bidi reordering of Lisp
5910 (handle_stop_backwards): Support Lisp strings as well.
5911 (display_string): Support display of R2L glyph rows.
5912 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5913 (init_iterator): Don't initialize it->bidi_p for strings
5915 (reseat_to_string): Initialize it->bidi_p for strings here.
5916 (next_element_from_string, next_element_from_c_string)
5917 (next_element_from_buffer): Add xassert's for correspondence
5918 between IT's object being iterated and it->bidi_it.string
5920 (face_before_or_after_it_pos): Support bidi iteration.
5921 (next_element_from_c_string): Handle the case of the first string
5922 character that is not the first one in the visual order.
5923 (get_visually_first_element): New function, refactored from common
5924 parts of next_element_from_buffer, next_element_from_string, and
5925 next_element_from_c_string.
5926 (tool_bar_lines_needed, redisplay_tool_bar)
5927 (display_menu_bar): Force left-to-right direction. Add a FIXME
5928 comment for making that be controlled by a user option.
5929 (push_it, pop_it): Save and restore the state of the
5930 bidi iterator. Save and restore the bidi_p flag.
5931 (pop_it): Iterate out of display property for string iteration as
5933 (iterate_out_of_display_property): Support iteration over strings.
5934 (handle_single_display_spec): Set up it->bidi_it for iteration
5935 over a display string, and call bidi_init_it.
5936 (handle_single_display_spec, next_overlay_string)
5937 (get_overlay_strings_1, push_display_prop): Set up the bidi
5938 iterator for displaying display or overlay strings.
5939 (forward_to_next_line_start): Don't use the shortcut if
5941 (back_to_previous_visible_line_start): If handle_display_prop
5942 pushed the iterator stack, restore the internal state of the bidi
5943 iterator by calling bidi_pop_it same number of times.
5944 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5945 and we are bidi-iterating, don't decrement the iterator position;
5946 instead, set the first_elt flag in the bidi iterator, to produce
5948 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5949 (push_display_prop): xassert that we are iterating a buffer.
5950 (push_it, pop_it): Save and restore paragraph_embedding member.
5951 (handle_single_display_spec, next_overlay_string)
5952 (get_overlay_strings_1, reseat_1, reseat_to_string)
5953 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5954 correctly. Don't assume unibyte strings are not bidi-reordered.
5955 (compute_display_string_pos)
5956 (compute_display_string_end): Fix handling the case of C string.
5957 (push_it, pop_it): Save and restore from_disp_prop_p.
5958 (handle_single_display_spec, push_display_prop): Set the
5959 from_disp_prop_p flag.
5960 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5961 (pop_it): Call iterate_out_of_display_property only if we are
5962 popping after iteration over a string that came from a display
5963 property. Fix a typo in popping stretch info. Add an assertion
5964 for verifying that the iterator position is in sync with the bidi
5966 (handle_single_display_spec, get_overlay_strings_1)
5967 (push_display_prop): Fix initialization of paragraph direction for
5968 string when that of the parent object is not yet determined.
5969 (reseat_1): Call bidi_init_it to resync the bidi
5970 iterator with IT's position. (Bug#7616)
5971 (find_row_edges): If ROW->start.pos gives position
5972 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5973 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5974 Reset the from_disp_prop_p flag.
5975 (SAVE_IT, RESTORE_IT): New macros.
5976 (pos_visible_p, face_before_or_after_it_pos)
5977 (back_to_previous_visible_line_start)
5978 (move_it_in_display_line_to, move_it_in_display_line)
5979 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5980 (try_scrolling, redisplay_window, display_line): Use them when
5981 saving a temporary copy of the iterator and restoring it back.
5982 (back_to_previous_visible_line_start, reseat_1)
5983 (init_iterator): Empty the bidi cache "stack".
5984 (move_it_in_display_line_to): If iterator ended up at
5985 EOL, but we never saw any buffer positions smaller than
5986 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5987 motion in bidi-reordered lines.
5988 (move_it_in_display_line_to): Record prev_method and prev_pos
5989 immediately before the call to set_iterator_to_next. Fixes cursor
5990 motion in bidi-reordered lines with stretch glyphs and strings
5991 displayed in margins. (Bug#8133) (Bug#8867)
5992 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5994 (pos_visible_p): Support positions in bidi-reordered lines.
5995 Save and restore bidi cache.
5997 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5998 (bidi_paragraph_info): Delete unused struct.
5999 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6000 (bidi_cache_start): New variable.
6001 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6003 (bidi_cache_fetch_state, bidi_cache_search)
6004 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6005 (bidi_cache_find, bidi_peek_at_next_level)
6006 (bidi_level_of_next_char, bidi_find_other_level_edge)
6007 (bidi_move_to_visually_next): Compare cache index with
6008 bidi_cache_start rather than with zero.
6009 (bidi_fetch_char): Accept new argument STRING; all callers
6010 changed. Support iteration over a string. Support strings with
6011 display properties. Support unibyte strings. Fix the type of
6012 `len' according to what STRING_CHAR_AND_LENGTH expects.
6013 (bidi_paragraph_init, bidi_resolve_explicit_1)
6014 (bidi_resolve_explicit, bidi_resolve_weak)
6015 (bidi_level_of_next_char, bidi_move_to_visually_next):
6016 Support iteration over a string.
6017 (bidi_set_sor_type, bidi_resolve_explicit_1)
6018 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6019 can now be zero (for strings); special values 0 and -1 were
6020 changed to -1 and -2, respectively.
6021 (bidi_char_at_pos): New function.
6022 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6023 Call it instead of FETCH_MULTIBYTE_CHAR.
6024 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6025 initialized to valid values.
6026 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6028 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6029 the test for valid cached positions. Fix the logic for looking up
6030 the sentinel state in the cache. GCPRO the Lisp string we are
6032 (bidi_push_it, bidi_pop_it): New functions.
6033 (bidi_initialize): Initialize the bidi cache start stack pointer.
6034 (bidi_cache_ensure_space): New function, refactored from part of
6035 bidi_cache_iterator_state. Don't assume the required size is just
6036 one BIDI_CACHE_CHUNK away.
6037 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6038 (bidi_count_bytes, bidi_char_at_pos): New functions.
6039 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6040 always valid if bidi_cache_idx is valid.
6041 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6042 is valid if it's going to be used.
6043 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6044 (bidi_cache_fetch_state, bidi_cache_search)
6045 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6046 (bidi_cache_iterator_state, bidi_cache_find)
6047 (bidi_find_other_level_edge, bidi_cache_start_stack):
6048 All variables related to cache indices are now EMACS_INT.
6050 * dispextern.h (struct bidi_string_data): New structure.
6051 (struct bidi_it): New member `string'. Make flag members be 1-bit
6052 fields, and put them last in the struct.
6053 (compute_display_string_pos, compute_display_string_end):
6055 (bidi_push_it, bidi_pop_it): Add prototypes.
6056 (struct iterator_stack_entry): New members bidi_p,
6057 paragraph_embedding, and from_disp_prop_p.
6058 (struct it): Member bidi_p is now a bit field 1 bit wide.
6059 (bidi_shelve_cache, bidi_unshelve_cache):
6062 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6063 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6064 and vector-like objects.
6066 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6067 cache around display iteration.
6069 * window.c (Fwindow_end, window_scroll_pixel_based)
6070 (displayed_window_lines, Frecenter): Save and restore the bidi
6071 cache around display iteration.
6073 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6075 * editfns.c (Fdelete_region): Clarify the use of the named
6076 parameters (bug#6788).
6078 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6080 * indent.c (Fvertical_motion): Set and restore w->pointm when
6081 saving and restoring the window's buffer (Bug#9006).
6083 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6085 * editfns.c (Fstring_to_char): Clarify just what is returned
6086 (bug#6576). Text by Eli Zaretskii.
6088 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6090 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6092 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6094 * buffer.c (mmap_find): Fix a typo.
6096 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6098 Fix execution of x selection hooks.
6099 * xselect.c (Qx_lost_selection_functions)
6100 (Qx_sent_selection_functions): New vars.
6101 (syms_of_xselect): DEFSYM them.
6102 (x_handle_selection_request): Pass Qx_sent_selection_functions
6103 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6104 (x_handle_selection_clear,x_clear_frame_selections):
6105 Pass Qx_lost_selection_functions rather than
6106 Vx_lost_selection_functions to Frun_hook_with_args.
6108 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6110 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6111 The old code sometimes used this field without initializing it.
6113 * alloc.c (gc_sweep): Don't read past end of array.
6114 In theory, the old code could also have corrupted Emacs internals,
6115 though it'd be very unlikely.
6117 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6119 * character.c (Fcharacterp): Don't advertise optional ignored
6120 argument. (Bug#4026)
6122 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6124 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6127 * window.c (Fset_window_start): Doc fix (bug#4199).
6128 (Fset_window_hscroll): Ditto.
6130 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6132 Fix minor new problems caught by GCC 4.6.1.
6133 * term.c (init_tty): Remove unused local.
6134 * xsettings.c (store_monospaced_changed): Define this function only
6135 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6138 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6140 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6142 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6144 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6145 are the mini-buffer and the echo area (bug#3320).
6147 * term.c (init_tty): Remove support for supdup, c10 and perq
6148 terminals, which are no longer supported (bug#1482).
6150 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6152 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6154 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6156 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6157 for non-popups (Bug#3642).
6159 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6161 * alloc.c (reset_malloc_hooks): Protoize.
6162 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6163 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6164 * cm.c (losecursor): Likewise.
6165 * data.c (fmod): Likewise.
6166 * dispnew.c (swap_glyphs_in_rows): Likewise.
6167 * emacs.c (memory_warning_signal): Likewise.
6168 * floatfns.c (float_error): Likewise.
6169 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6170 (otf_open, font_otf_capability, generate_otf_features)
6171 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6173 * image.c (pbm_read_file): Likewise.
6174 * indent.c (string_display_width): Likewise.
6175 * intervals.c (check_for_interval, search_for_interval)
6176 (inc_interval_count, count_intervals, root_interval)
6177 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6178 * lread.c (defalias): Likewise.
6179 * ralloc.c (r_alloc_check): Likewise.
6180 * regex.c (set_image_of_range_1, set_image_of_range)
6181 (regex_grow_registers): Likewise.
6182 * sysdep.c (strerror): Likewise.
6183 * termcap.c (valid_filename_p, tprint, main): Likewise.
6184 * tparam.c (main): Likewise.
6185 * unexhp9k800.c (run_time_remap, save_data_space)
6186 (update_file_ptrs, read_header, write_header, calculate_checksum)
6187 (copy_file, copy_rest, display_header): Likewise.
6188 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6190 * xdisp.c (check_it): Likewise.
6191 * xfaces.c (register_color, unregister_color, unregister_colors):
6193 * xfns.c (print_fontset_result): Likewise.
6194 * xrdb.c (member, fatal, main): Likewise.
6196 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6198 Fix minor problems found by static checking (Bug#9031).
6199 * chartab.c (char_table_set_range, map_sub_char_table):
6200 Remove unused locals.
6201 (uniprop_table): Now static.
6202 * composite.c (_work_char): Remove unused static var.
6204 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6206 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6208 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6210 * gtkutil.c (qttip_cb): Remove code without function.
6212 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6214 * w32.c (pthread_sigmask): New stub.
6216 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6218 Use pthread_sigmask, not sigprocmask (Bug#9010).
6219 sigprocmask is portable only for single-threaded applications, and
6220 Emacs can be multi-threaded when it uses GTK.
6221 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6223 * callproc.c (Fcall_process):
6224 * process.c (create_process):
6225 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6226 Use pthread_sigmask, not sigprocmask.
6228 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6230 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6231 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6234 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6236 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6237 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6238 (xg_hide_tooltip): Fix comment.
6240 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6241 in registerServicesMenuSendTypes.
6242 (validRequestorForSendType): Don't check ns_return_types.
6244 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6247 2011-07-08 Jason Rumney <jasonr@gnu.org>
6249 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6250 SH_SHOW for hidden windows (Bug#5482).
6252 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6253 frame struct members of non-existent frames (Bug#6284).
6255 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6257 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6258 variable firstTime not needed on OSX >= 10.6.
6259 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6260 >= 10.5. Use setKnobProportion, setDoubleValue.
6262 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6263 (MAC_OS_X_VERSION_10_5): Define if not defined.
6264 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6265 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6266 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6268 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6269 cString and lossyCString on OSX >= 10.4
6271 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6272 sizeToFit on OSX >= 10.2.
6274 * nsimage.m (allocInitFromFile): Don't use deprecated method
6275 bestRepresentationForDevice on OSX >= 10.6.
6277 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6280 * emacs.c: Declare unexec_init_emacs_zone.
6282 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6284 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6286 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6287 on svcsMenu (Bug#8842).
6289 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6291 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6293 * nsterm.m (QUTF8_STRING): Declare.
6294 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6295 (validRequestorForSendType): Return type is (id).
6296 Change indexOfObjectIdenticalTo to indexOfObject.
6297 Check if we have local selection before returning self (Bug#8842).
6298 (writeSelectionToPasteboard): Put local selection into paste board
6299 if we have a local selection (Bug#8842).
6300 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6302 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6303 (ns_get_local_selection): Declare.
6305 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6307 * keymap.c (describe_map_tree): Don't insert a double newline at
6308 the end of the buffer (bug#1169) and return whether we inserted
6311 * callint.c (Fcall_interactively): Change "reading args" to
6312 "providing args" to try to clarify what it does (bug#1010).
6314 2011-07-07 Kenichi Handa <handa@m17n.org>
6316 * composite.c (composition_compute_stop_pos): Ignore a static
6317 composition starting before CHARPOS (Bug#8915).
6319 * xdisp.c (handle_composition_prop): Likewise.
6321 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6323 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6326 2011-07-07 Kenichi Handa <handa@m17n.org>
6328 * character.h (unicode_category_t): New enum type.
6330 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6331 (Qchar_code_property_table): New variable.
6332 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6333 (UNIPROP_COMPRESSED_FORM_P): New macros.
6334 (char_table_ascii): Uncompress the compressed values.
6335 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6336 Uncompress the compressed values.
6337 (sub_char_table_ref_and_range): Likewise.
6338 (char_table_ref_and_range): Uncompress the compressed values.
6339 (sub_char_table_set): New arg is_uniprop. Callers changed.
6340 Uncompress the compressed values.
6341 (sub_char_table_set_range): Args changed. Callers changed.
6342 (char_table_set_range): Adjuted for the above change.
6343 (map_sub_char_table): Delete args default_val and parent. Add arg
6344 top. Give decoded values to a Lisp function.
6345 (map_char_table): Adjust for the above change. Give decoded
6346 values to a Lisp function. Gcpro more variables.
6347 (uniprop_table_uncompress)
6348 (uniprop_decode_value_run_length): New functions.
6349 (uniprop_decoder, uniprop_decoder_count): New variables.
6350 (uniprop_get_decoder, uniprop_encode_value_character)
6351 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6353 (uniprop_encoder, uniprop_encoder_count): New variables.
6354 (uniprop_get_encoder, uniprop_table)
6355 (Funicode_property_table_internal, Fget_unicode_property_internal)
6356 (Fput_unicode_property_internal): New functions.
6357 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6358 Sunicode_property_table_internal, Sget_unicode_property_internal,
6359 and Sput_unicode_property_internal. Defvar_lisp
6360 char-code-property-alist.
6362 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6363 Vunicode_category_table.
6365 * font.c (font_range): Adjust for the change of
6366 Vunicode_category_table.
6368 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6370 * m/iris4d.h: Remove file, move contents ...
6371 * s/irix6-5.h: ... here.
6373 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6375 Remove unportable assumption about struct layout (Bug#8884).
6376 * alloc.c (mark_buffer):
6377 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6378 (clone_per_buffer_values): Don't assume that
6379 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6380 This isn't true in general, and it's particularly not true
6381 if Emacs is configured with --with-wide-int.
6382 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6383 New macros, used in the buffer.c change.
6385 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6387 * xsettings.c: Use both GConf and GSettings if both are available.
6388 (store_config_changed_event): Add comment.
6389 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6390 (store_tool_bar_style_changed): New functions.
6391 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6392 (struct xsettings): Move font inside HAVE_XFT.
6393 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6394 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6395 Move inside HAVE_XFT.
6396 (something_changed_gsettingsCB): Rename from something_changedCB.
6397 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6399 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6400 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6401 (something_changed_gconfCB): Rename from something_changedCB.
6402 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6403 (parse_settings): Move check for font inside HAVE_XFT.
6404 (read_settings, apply_xft_settings): Add comment.
6405 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6406 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6407 call store_font_name_changed.
6408 (xft_settings_event): Add comment.
6409 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6410 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6411 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6412 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6413 (xsettings_initialize): Call init_gsettings last.
6414 (xsettings_get_system_font, xsettings_get_system_normal_font):
6417 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6419 Random fixes. E.g., (random) never returned negative values.
6420 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6421 subseconds part to the entropy, as that's a bit more random.
6422 Prefer signed to unsigned, since the signedness doesn't matter and
6423 in general we prefer signed. When given a limit, use a
6424 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6425 latter isn't right if USE_2_TAGS_FOR_INTS.
6426 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6427 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6429 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6431 * textprop.c (text_property_stickiness):
6432 Obey Vtext_property_default_nonsticky.
6433 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6434 * w32fns.c (syms_of_w32fns):
6435 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6437 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6439 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6440 This is more efficient than Ffile_directory_p and avoids a minor race.
6442 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6444 * buffer.c (Foverlay_put): Say what the return value is
6447 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6448 is a directory before asking whether to use the file name
6450 (barf_or_query_if_file_exists): Make the "File is a directory"
6451 error be more correct.
6453 * fns.c (Frequire): Remove the mention of the .gz files, since
6454 that's installation-specific, but keep the mention of
6455 `get-load-suffixes'.
6457 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6459 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6460 Report string overflow if the output is too long.
6462 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6464 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6465 (syms_of_gnutls): Remove duplicate DEFSYM for
6466 Qgnutls_bootprop_verify_hostname_error, an error for
6467 Qgnutls_bootprop_verify_error (which is no longer used).
6469 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6470 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6471 Also (re)move comments that are misplaced or no longer relevant.
6473 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6475 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6477 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6479 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6480 and background color parameters if they have been changed.
6482 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6484 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6486 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6488 * xsettings.c (SYSTEM_FONT): Define only when used.
6489 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6491 * keymap.c (access_keymap_1): Now static.
6493 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6495 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6496 leave any prefix arg for the up event (Bug#1586).
6498 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6500 * lread.c (syms_of_lread): Mention single symbols defined by
6501 `defvar' or `defconst' (bug#7154).
6503 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6504 (Frequire): Mention get-load-suffixes.
6506 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6508 * window.h (window): Remove clone_number slot.
6509 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6511 (make_parent_window, make_window, saved_window)
6512 (Fset_window_configuration, save_window_save): Don't deal with
6514 * buffer.c (Qclone_number): Remove declaration.
6515 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6517 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6519 Add multiple inheritance to keymaps.
6520 * keymap.c (Fmake_composed_keymap): New function.
6521 (Fset_keymap_parent): Simplify.
6522 (fix_submap_inheritance): Remove.
6523 (access_keymap_1): New function extracted from access_keymap to handle
6524 embedded parents and handle lists of maps.
6525 (access_keymap): Use it.
6526 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6527 (Fcopy_keymap): Handle embedded parents.
6528 (Fcommand_remapping, define_as_prefix): Simplify.
6529 (Fkey_binding): Simplify.
6530 (syms_of_keymap): Move minibuffer-local-completion-map,
6531 minibuffer-local-filename-completion-map,
6532 minibuffer-local-must-match-map, and
6533 minibuffer-local-filename-must-match-map to Elisp.
6534 (syms_of_keymap): Defsubr make-composed-keymap.
6535 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6536 (parse_menu_item): Trivial simplification.
6538 2011-07-01 Glenn Morris <rgm@gnu.org>
6540 * Makefile.in (SETTINGS_LIBS): Fix typo.
6542 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6544 * coding.c (Fencode_coding_string): Record the last coding system
6545 used, as the function doc string says (bug#8738).
6547 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6549 * xsettings.c (store_monospaced_changed): Take new font as arg and
6550 check for change against current_mono_font.
6551 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6552 (emacs_settings_constructor, emacs_settings_get_property)
6553 (emacs_settings_set_property, emacs_settings_class_init)
6554 (emacs_settings_init, gsettings_obj): Remove.
6555 (something_changedCB): New function for HAVE_GSETTINGS.
6556 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6557 with value as argument.
6558 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6559 g_settings_new (Bug#8967). Do not create gsettings_obj.
6560 Remove calls to g_settings_bind. Connect something_changedCB to
6563 * xgselect.c: Add defined (HAVE_GSETTINGS).
6564 (xgselect_initialize): Ditto.
6566 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6567 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6570 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6572 * eval.c (struct backtrace): Simplify and port the data structure.
6573 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6574 signed bit field, as this assumption is not portable and it makes
6575 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6576 "char debug_on_exit : 1" as this is not portable either; instead,
6577 use the portable "unsigned int debug_on_exit : 1". Remove unused
6578 member evalargs. Remove obsolete comments about cc bombing out.
6580 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6582 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6583 Let HAVE_GSETTINGS override HAVE_GCONF.
6584 (store_monospaced_changed): New function.
6585 (EMACS_SETTINGS): A new type derived from GObject to handle
6586 GSettings notifications.
6587 (emacs_settings_constructor, emacs_settings_get_property)
6588 (emacs_settings_set_property, emacs_settings_class_init):
6590 (gsettings_client, gsettings_obj): New variables.
6591 (GSETTINGS_SCHEMA): New define.
6592 (something_changedCB): Call store_monospaced_changed.
6593 (init_gsettings): New function.
6594 (xsettings_initialize): Call init_gsettings.
6595 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6598 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6601 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6603 * window.c (resize_root_window, grow_mini_window)
6604 (shrink_mini_window): Rename Qresize_root_window to
6605 Qwindow_resize_root_window and Qresize_root_window_vertically to
6606 Qwindow_resize_root_window_vertically.
6608 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6610 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6612 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6614 * makefile.w32-in: Redesign dependencies so they reflect more
6615 clearly which files are directly included by each source file,
6616 and not through other includes.
6618 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6620 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6621 (sort_overlays, overlay_strings): When an overlay's clone number
6622 matches the window's clone number process the overlay even if
6623 the overlay's window property doesn't match the current window.
6625 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6626 (Fwindow_hchild): Rename to Fwindow_left_child.
6627 (Fwindow_next): Rename to Fwindow_next_sibling.
6628 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6629 (resize_window_check): Rename to window_resize_check.
6630 (resize_window_apply): Rename to window_resize_apply.
6631 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6632 (Fdelete_other_windows_internal, resize_frame_windows)
6633 (Fsplit_window_internal, Fdelete_window_internal)
6634 (grow_mini_window, shrink_mini_window)
6635 (Fresize_mini_window_internal): Fix callers accordingly.
6637 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6639 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6640 (emacs_fixed_set_min_size): Remove.
6641 (emacs_fixed_new): Take frame as argument.
6643 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6644 (_EmacsFixedPrivate): Remove minwidth/height.
6645 Add struct frame *f.
6646 (emacs_fixed_init): Initialize priv->f.
6647 (get_parent_class, emacs_fixed_set_min_size): Remove.
6648 (emacs_fixed_new): Set priv->f to argument.
6649 (emacs_fixed_get_preferred_width)
6650 (emacs_fixed_get_preferred_height): Use min_width/height from
6651 frames size_hint to set minimum and natural (Bug#8919).
6652 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6653 and use min_width/height from frames size_hint to set
6654 min_width/height (Bug#8919).
6656 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6657 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6660 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6662 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6663 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6666 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6668 * process.c (wait_reading_process_output): Bypass select if
6669 waiting for a cell while ignoring keyboard input, and input is
6670 pending. Suggested by Jan Djärv (Bug#8869).
6672 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6674 Use gnulib's dup2 module instead of rolling our own.
6675 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6677 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6679 * dispnew.c (scrolling_window): Before scrolling, turn off a
6680 mouse-highlight in the window being scrolled.
6682 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6684 Move DEFSYM to lisp.h and use everywhere.
6686 * character.h (DEFSYM): Move declaration...
6687 * lisp.h (DEFSYM): ...here.
6693 * w32select.c: Don't include character.h.
6695 * alloc.c (syms_of_alloc):
6696 * buffer.c (syms_of_buffer):
6697 * bytecode.c (syms_of_bytecode):
6698 * callint.c (syms_of_callint):
6699 * casefiddle.c (syms_of_casefiddle):
6700 * casetab.c (init_casetab_once):
6701 * category.c (init_category_once, syms_of_category):
6702 * ccl.c (syms_of_ccl):
6703 * cmds.c (syms_of_cmds):
6704 * composite.c (syms_of_composite):
6705 * dbusbind.c (syms_of_dbusbind):
6706 * dired.c (syms_of_dired):
6707 * dispnew.c (syms_of_display):
6708 * doc.c (syms_of_doc):
6709 * editfns.c (syms_of_editfns):
6710 * emacs.c (syms_of_emacs):
6711 * eval.c (syms_of_eval):
6712 * fileio.c (syms_of_fileio):
6713 * fns.c (syms_of_fns):
6714 * frame.c (syms_of_frame):
6715 * fringe.c (syms_of_fringe):
6716 * insdel.c (syms_of_insdel):
6717 * keymap.c (syms_of_keymap):
6718 * lread.c (init_obarray, syms_of_lread):
6719 * macros.c (syms_of_macros):
6720 * msdos.c (syms_of_msdos):
6721 * print.c (syms_of_print):
6722 * process.c (syms_of_process):
6723 * search.c (syms_of_search):
6724 * sound.c (syms_of_sound):
6725 * syntax.c (init_syntax_once, syms_of_syntax):
6726 * terminal.c (syms_of_terminal):
6727 * textprop.c (syms_of_textprop):
6728 * undo.c (syms_of_undo):
6729 * w32.c (globals_of_w32):
6730 * window.c (syms_of_window):
6731 * xdisp.c (syms_of_xdisp):
6732 * xfaces.c (syms_of_xfaces):
6733 * xfns.c (syms_of_xfns):
6734 * xmenu.c (syms_of_xmenu):
6735 * xsettings.c (syms_of_xsettings):
6736 * xterm.c (syms_of_xterm): Use DEFSYM.
6738 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6740 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6742 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6744 Integer and buffer overflow fixes (Bug#8873).
6746 * print.c (printchar, strout): Check for string overflow.
6747 (PRINTPREPARE, printchar, strout):
6748 Don't set size unless allocation succeeds.
6750 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6751 for sizes. Check for string overflow more accurately.
6752 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6754 * macros.c: Integer and buffer overflow fixes.
6755 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6756 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6757 Use ptrdiff_t, not int, for sizes.
6758 Don't increment bufsize until after realloc succeeds.
6759 Check for size-calculation overflow.
6760 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6762 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6764 * lread.c: Integer overflow fixes.
6765 (read_integer): Radix is now EMACS_INT, not int,
6766 to improve quality of diagnostics for out-of-range radices.
6767 Calculate buffer size correctly for out-of-range radices.
6768 (read1): Check for integer overflow in radices, and in
6769 read-circle numbers.
6770 (read_escape): Avoid int overflow.
6771 (Fload, openp, read_buffer_size, read1)
6772 (substitute_object_recurse, read_vector, read_list, map_obarray):
6773 Use ptrdiff_t, not int, for sizes.
6774 (read1): Use EMACS_INT, not int, for sizes.
6775 Check for size overflow.
6777 * image.c (cache_image): Check for size arithmetic overflow.
6779 * lread.c: Integer overflow issues.
6780 (saved_doc_string_size, saved_doc_string_length)
6781 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6782 Now ptrdiff_t, not int.
6783 (read1): Don't assume doc string length fits in int. Check for
6784 out-of-range doc string lengths.
6785 (read_list): Don't assume file position fits in int.
6786 (read_escape): Check for hex character overflow.
6788 2011-06-22 Leo Liu <sdl.web@gmail.com>
6790 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6791 Move to minibuffer.el.
6793 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6795 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6796 The following patches are for when GLYPH_DEBUG && !XASSERT.
6797 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6798 * dispnew.c (flush_stdout):
6799 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6800 Mark as externally visible.
6801 * dispnew.c (check_window_matrix_pointers): Now static.
6802 * dispnew.c (window_to_frame_vpos):
6803 * xfns.c (unwind_create_frame):
6804 * xterm.c (x_check_font): Remove unused local.
6805 * scroll.c (CHECK_BOUNDS):
6806 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6807 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6808 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6809 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6810 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6812 (debug_method_add): Use va_list and vsprintf rather than relying
6813 on undefined behavior with wrong number of arguments.
6814 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6815 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6816 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6817 since we're not interested in debugging glyphs with old libraries.
6818 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6819 GCC 4.6.0's static checking.
6821 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6823 Integer overflow and signedness fixes (Bug#8873).
6824 A few related buffer overrun fixes, too.
6826 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6828 * dispextern.h (struct face.stipple):
6829 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6830 (x_bitmap_mask, x_allocate_bitmap_record)
6831 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6832 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6833 (x_create_bitmap_from_xpm_data):
6834 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6835 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6837 * xfaces.c (load_pixmap):
6838 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6839 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6840 (.bitmaps_last, struct x_output.icon_bitmap):
6841 Use ptrdiff_t, not int, for bitmap indexes.
6842 (x_allocate_bitmap_record): Check for size overflow.
6843 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6845 Use ptrdiff_t, not int, for overlay counts.
6846 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6847 * editfns.c (overlays_around, get_pos_property):
6848 * textprop.c (get_char_property_and_overlay):
6849 * xdisp.c (next_overlay_change, note_mouse_highlight):
6850 * xfaces.c (face_at_buffer_position):
6851 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6852 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6853 (Fnext_overlay_change, Fprevious_overlay_change)
6854 (mouse_face_overlay_overlaps, Foverlays_in):
6855 Use ptrdiff_t, not int, for sizes.
6856 (overlays_at, overlays_in): Check for size-calculation overflow.
6858 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6860 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6861 (x_session_initialize): Do not assume string length fits in int.
6863 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6864 This is unlikely, but can occur if DPI is outlandish.
6866 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6867 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6869 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6870 * xrdb.c (magic_file_p, search_magic_path):
6871 Omit last arg SUFFIX; it was always 0. All callers changed.
6872 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6874 * xfont.c (xfont_match): Avoid need for strlen.
6876 * xfns.c: Don't assume strlen fits in int.
6877 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6879 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6880 not unsigned long, as we prefer signed integers. All callers changed.
6881 Detect integer overflow in repeat count.
6882 (message_dolog): Don't assume print length fits in 39 bytes.
6883 (display_mode_element): Don't assume strlen fits in int.
6885 * termcap.c: Don't assume sizes fit in int and never overflow.
6886 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6887 (gobble_line): Check for size-calculation overflow.
6889 * minibuf.c (Fread_buffer):
6890 * lread.c (intern, intern_c_string):
6891 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6892 Don't assume string length fits in int.
6894 * keyboard.c (parse_tool_bar_item):
6895 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6897 * font.c: Don't assume string length fits in int.
6898 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6899 Use ptrdiff_t, not int.
6900 (font_intern_prop): Don't assume string length fits in int.
6901 Don't assume integer property fits in fixnum.
6902 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6904 * filelock.c: Fix some buffer overrun and integer overflow issues.
6905 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6906 Reformulate so as not to need the command string.
6907 Invoke gzip -cd rather than gunzip, as it's more portable.
6908 (lock_info_type, lock_file_1, lock_file):
6909 Don't assume pid_t and time_t fit in unsigned long.
6910 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6911 (current_lock_owner): Prefer signed type for sizes.
6912 Use memcpy, not strncpy, where memcpy is what is really wanted.
6913 Don't assume (via atoi) that time_t and pid_t fit in int.
6914 Check for time_t and/or pid_t out of range, e.g., via a network share.
6915 Don't alloca where an auto var works fine.
6917 * fileio.c: Fix some integer overflow issues.
6918 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6919 Don't assume string length fits in int.
6920 (directory_file_name): Don't assume string length fits in long.
6921 (make_temp_name): Don't assume pid fits in int, or that its print
6922 length is less than 20.
6924 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6926 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6928 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6930 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6931 We prefer signed integers, even for size calculations.
6933 * emacs.c: Don't assume string length fits in 'int'.
6934 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6935 (main): Don't invoke strlen when not needed.
6937 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6938 (XD_DEBUG_MESSAGE): Don't waste a byte.
6940 * callproc.c (getenv_internal_1, getenv_internal)
6942 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6944 * lread.c (invalid_syntax): Omit length argument.
6945 All uses changed. This doesn't fix a bug, but it simplifies the
6946 code away from its former Hollerith-constant appearance, and it's
6947 one less 'int' to worry about when looking at integer-overflow issues.
6948 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6950 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6951 This didn't break anything, but it didn't help either.
6952 It's confusing to put a bogus integer in a place where the actual
6953 value does not matter.
6954 (LIST_END_P): Remove unused macro and its bogus comment.
6955 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6957 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6958 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6960 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6961 We prefer signed types, and the value cannot exceed the EMACS_INT
6962 range anyway (because otherwise the length would not be representable).
6963 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6964 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6965 This avoids a GCC warning when WIDE_EMACS_INT.
6967 * indent.c (sane_tab_width): New function.
6968 (current_column, scan_for_column, Findent_to, position_indentation)
6969 (compute_motion): Use it. This is just for clarity.
6970 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6972 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6974 * lisp.h (lint_assume): New macro.
6975 * composite.c (composition_gstring_put_cache):
6976 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6978 * editfns.c, insdel.c:
6979 Omit unnecessary forward decls, to simplify future changes.
6981 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6983 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6985 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6986 Use much-faster test for byte-length change.
6987 Don't assume string byte-length fits in 'int'.
6988 Check that character arg fits in 'int'.
6989 (mapcar1): Declare byte as byte, for clarity.
6991 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6993 * fns.c (concat): Catch string overflow earlier.
6994 Do not rely on integer wraparound.
6996 * dispextern.h (struct it.overlay_strings_charpos)
6997 (struct it.selective): Now EMACS_INT, not int.
6998 * xdisp.c (forward_to_next_line_start)
6999 (back_to_previous_visible_line_start)
7000 (reseat_at_next_visible_line_start, next_element_from_buffer):
7001 Don't arbitrarily truncate the value of 'selective' to int.
7003 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7005 * composite.c: Don't truncate sizes to 'int'.
7006 (composition_gstring_p, composition_reseat_it)
7007 (composition_adjust_point): Use EMACS_INT, not int.
7008 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7009 not EMACS_UINT, for indexes.
7011 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7013 * buffer.c: Include <verify.h>.
7014 (struct sortvec.priority, struct sortstr.priority):
7015 Now EMACS_INT, not int.
7016 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7017 (struct sortstr.size, record_overlay_string)
7018 (struct sortstrlist.size, struct sortlist.used):
7019 Don't truncate size to int.
7020 (record_overlay_string): Check for size-calculation overflow.
7021 (init_buffer_once): Check at compile-time, not run-time.
7023 2011-06-22 Jim Meyering <meyering@redhat.com>
7025 Don't leak an XBM-image-sized buffer
7026 * image.c (xbm_load): Free the image buffer after using it.
7028 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7031 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7032 that Sun C diagnosed.
7033 * fns.c (secure_hash): Fix pointer signedness issue.
7034 * intervals.c (static_offset_intervals): New function.
7035 (offset_intervals): Use it.
7037 2011-06-21 Leo Liu <sdl.web@gmail.com>
7040 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7043 * fns.c (secure_hash): Rename from crypto_hash_function and change
7044 the first arg to accept symbols.
7045 (Fsecure_hash): New primitive.
7046 (syms_of_fns): New symbols.
7048 2011-06-20 Deniz Dogan <deniz@dogan.se>
7050 * process.c (Fset_process_buffer): Clarify return value in
7053 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7055 * dispnew.c (add_window_display_history): Use BVAR.
7057 * xdisp.c (debug_method_add): Use BVAR.
7058 (check_window_end, dump_glyph_matrix, dump_glyph)
7059 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7061 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7064 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7065 check till after the cache is created in init_frame_faces.
7067 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7069 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7071 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7073 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7074 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7075 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7077 Improve buffer-overflow checking (Bug#8873).
7078 * fileio.c (Finsert_file_contents):
7079 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7080 Remove the old (too-loose) buffer overflow checks.
7081 They weren't needed, since make_gap checks for buffer overflow.
7082 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7083 The old code merely checked for Emacs fixnum overflow, and relied
7084 on undefined (wraparound) behavior. The new code avoids undefined
7085 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7087 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7088 Tune. Don't use wider integers than needed. Don't use alloca.
7089 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7091 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7093 * insdel.c, lisp.h (buffer_overflow): New function.
7094 (insert_from_buffer_1, replace_range, replace_range_2):
7095 * insdel.c (make_gap_larger):
7096 * editfns.c (Finsert_char):
7097 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7099 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7101 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7103 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7105 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7106 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7108 * fileio.c: Don't assume EMACS_INT fits in off_t.
7109 (emacs_lseek): New static function.
7110 (Finsert_file_contents, Fwrite_region): Use it.
7111 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7113 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7115 * fns.c: Don't overflow int when computing a list length.
7116 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7117 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7118 truncation on 64-bit hosts. Check for QUIT every
7119 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7120 faster and is responsive enough.
7121 (Flength): Report an error instead of overflowing an integer.
7122 (Fsafe_length): Return a float if the value is not representable
7123 as a fixnum. This shouldn't happen except in contrived situations.
7124 (Fnthcdr, Fsort): Don't assume list length fits in int.
7125 (Fcopy_sequence): Don't assume vector length fits in int.
7127 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7128 (header_size, word_size): New constants.
7129 (allocate_vectorlike): Don't check size overflow here.
7130 (allocate_vector): Check it here instead, since this is the only
7131 caller of allocate_vectorlike that could cause overflow.
7132 Check that the new vector's length is representable as a fixnum.
7134 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7135 The previous code was bogus. For example, next_almost_prime (32)
7136 returned 39, which is undesirable as it is a multiple of 3; and
7137 next_almost_prime (24) returned 25, which is a multiple of 5 so
7138 why was the code bothering to check for multiples of 7?
7140 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7142 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7144 Variadic C functions now count arguments with ptrdiff_t.
7145 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7146 Back then I didn't know that the Emacs coding style prefers signed int.
7147 Also, in the meantime I found a few more instances where arguments
7148 were being counted with int, which may truncate counts on 64-bit
7149 machines, or EMACS_INT, which may be unnecessarily wide.
7150 * lisp.h (struct Lisp_Subr.function.aMANY)
7151 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7152 Arg counts are now ptrdiff_t, not size_t.
7153 All variadic functions and their callers changed accordingly.
7154 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7155 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7156 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7157 * callint.c (Fcall_interactively): Check arg count for overflow,
7158 to avoid potential buffer overrun. Use signed char, not 'int',
7159 for 'varies' array, so that we needn't bother to check its size
7160 calculation for overflow.
7161 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7162 * eval.c (apply_lambda):
7163 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7164 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7165 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7167 * callint.c (Fcall_interactively): Don't use index var as event count.
7169 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7170 * mem-limits.h (SIZE): Remove; no longer used.
7172 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7174 Remove unnecessary casts.
7175 * xterm.c (x_term_init):
7176 * xfns.c (x_set_border_pixel):
7177 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7178 These aren't needed now that we assume ANSI C.
7180 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7181 It's more likely to cause problems (due to unsigned overflow)
7184 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7186 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7188 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7190 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7192 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7194 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7196 GLYPH_CODE_FACE returns EMACS_INT, not int.
7197 * dispextern.h (merge_faces):
7198 * xfaces.c (merge_faces):
7199 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7200 Don't assume EMACS_INT fits in int.
7202 * character.h (CHAR_VALID_P): Remove unused parameter.
7203 * fontset.c, lisp.h, xdisp.c: All uses changed.
7205 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7207 * fns.c (concat): Minor tuning based on overflow analysis.
7208 This doesn't fix any bugs. Use int to hold character, instead
7209 of constantly refetching from Emacs object. Use XFASTINT, not
7210 XINT, for value known to be a character. Don't bother comparing
7211 a single byte to 0400, as it's always less.
7213 * floatfns.c (Fexpt):
7214 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7216 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7219 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7221 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7222 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7223 incorrectly succeed when S was a string, because 4294967386 was
7224 truncated before it was used.
7226 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7227 Otherwise, an out-of-range integer could cause undefined behavior
7230 * composite.c: Use int, not EMACS_INT, for characters.
7231 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7232 EMACS_INT, for values that are known to be in character range.
7233 This doesn't fix any bugs but is the usual style inside Emacs and
7234 may generate better code on 32-bit machines.
7236 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7237 This is for reasons similar to the recent CHAR_STRING fix.
7238 * charset.c (Fencode_char): Check that character arg is actually
7239 a character. Pass an int to ENCODE_CHAR.
7240 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7241 wider than 'int', as a compile-time check to prevent future regressions
7244 * character.c (char_string): Remove unnecessary casts.
7246 Make sure a 64-bit char is never passed to CHAR_STRING.
7247 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7248 by silently ignoring the top 32 bits, allowing some values
7249 that were far too large to be valid characters.
7250 * character.h: Include <verify.h>.
7251 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7252 arguments are no wider than unsigned, as a compile-time check
7253 to prevent future regressions in this area.
7255 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7256 (Fsubst_char_in_region):
7258 * xdisp.c (decode_mode_spec_coding):
7259 Adjust to CHAR_STRING's new requirement.
7260 * editfns.c (Finsert_char, Fsubst_char_in_region):
7261 * fns.c (concat): Check that character args are actually
7262 characters. Without this test, these functions did the wrong
7263 thing with wildly out-of-range values on 64-bit hosts.
7265 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7266 These casts should not be needed on 32-bit hosts, either.
7267 * keyboard.c (read_char):
7268 * lread.c (Fload): Remove casts to unsigned.
7270 * lisp.h (UNSIGNED_CMP): New macro.
7271 This fixes comparison bugs on 64-bit hosts.
7272 (ASCII_CHAR_P): Use it.
7273 * casefiddle.c (casify_object):
7274 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7275 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7276 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7277 * dispextern.h (FACE_FROM_ID):
7278 * keyboard.c (read_char): Use UNSIGNED_CMP.
7280 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7281 not to EMACS_INT, to avoid GCC warning.
7283 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7285 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7286 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7287 isn't needed on 32-bit machines.
7289 * buffer.c (Fgenerate_new_buffer_name):
7290 Use EMACS_INT for count, not int.
7291 (advance_to_char_boundary): Return EMACS_INT, not int.
7293 * data.c (Qcompiled_function): Now static.
7295 * window.c (window_body_lines): Now static.
7297 * image.c (gif_load): Rename local to avoid shadowing.
7299 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7300 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7301 * alloc.c (make_save_value): Integer argument is now of type
7303 (mark_object): Use ptrdiff_t, not int.
7304 * lisp.h (pD): New macro.
7305 * print.c (print_object): Use it.
7307 * alloc.c: Use EMACS_INT, not int, to count objects.
7308 (total_conses, total_markers, total_symbols, total_vector_size)
7309 (total_free_conses, total_free_markers, total_free_symbols)
7310 (total_free_floats, total_floats, total_free_intervals)
7311 (total_intervals, total_strings, total_free_strings):
7312 Now EMACS_INT, not int. All uses changed.
7313 (Fgarbage_collect): Compute overall total using a double, so that
7314 integer overflow is less likely to be a problem. Check for overflow
7315 when converting back to an integer.
7316 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7317 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7318 These were 'int' variables that could overflow on 64-bit hosts;
7319 they were never used, so remove them instead of repairing them.
7320 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7321 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7322 Previously, this ceilinged at INT_MAX, but that doesn't work on
7324 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7326 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7327 (allocate_vectorlike): Check for ptrdiff_t overflow.
7328 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7329 when a (possibly-narrower) signed value would do just as well.
7330 We prefer using signed arithmetic, to avoid comparison confusion.
7332 * alloc.c: Catch some string size overflows that we were missing.
7333 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7334 for convenience in STRING_BYTES_MAX.
7335 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7336 The definition here is exact; the one in lisp.h was approximate.
7337 (allocate_string_data): Check for string overflow. This catches
7338 some instances we weren't catching before. Also, it catches
7339 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7340 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7341 and ptrdiff_t and EMACS_INT are both 64 bits.
7343 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7344 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7345 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7347 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7349 * alloc.c (Fmake_string): Check for out-of-range init.
7351 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7353 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7355 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7357 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7358 xg_get_default_scrollbar_width.
7360 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7361 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7362 (style_changed_cb): Call update_theme_scrollbar_width and call
7363 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7364 all frames (Bug#8505).
7365 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7366 Call gtk_window_set_resizable if HAVE_GTK3.
7367 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7368 and height if HAVE_GTK3 (Bug#8505).
7369 (scroll_bar_width_for_theme): New variable.
7370 (update_theme_scrollbar_width): New function.
7371 (xg_get_default_scrollbar_width): Move code to
7372 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7373 (xg_initialize): Call update_theme_scrollbar_width.
7375 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7377 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7379 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7381 * frame.c (make_frame): Call other_buffer_safely instead of
7384 * window.c (temp_output_buffer_show): Call display_buffer with
7385 second argument Vtemp_buffer_show_specifiers and reset latter
7386 immediately after the call.
7387 (Vtemp_buffer_show_specifiers): New variable.
7388 (auto_window_vscroll_p, next_screen_context_lines)
7389 (Vscroll_preserve_screen_position): Remove leading asterisks from
7392 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7394 Fix minor problems found by GCC 4.6.0 static checking.
7395 * buffer.c (Qclone_number): Remove for now, as it's unused.
7396 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7397 (record_buffer): Remove unused local.
7398 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7399 (set_frame_buffer_list): Remove; unused.
7400 * frame.h (other_visible_frames): Remove decl.
7401 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7402 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7403 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7405 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7406 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7407 Define only if HAVE_GPM.
7408 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7409 (update_hints_inhibit): Remove; never set. All uses removed.
7410 * widgetprv.h (emacsFrameClassRec): Remove decl.
7411 * window.c (delete_deletable_window): Now returns void, since it
7412 wasn't returning anything.
7413 (compare_window_configurations): Remove unused locals.
7414 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7415 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7416 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7417 the same widths as pointers. This follows up on the 2011-05-06 patch.
7418 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7419 * xterm.h: Likewise.
7420 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7422 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7424 * makefile.w32-in: Update dependencies.
7425 (LISP_H): Add lib/intprops.h.
7427 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7429 * image.c (gif_load): Add animation frame delay to the metadata.
7430 (syms_of_image): Use DEFSYM. New symbol `delay'.
7432 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7434 * window.c (delete_deletable_window): Re-add.
7435 (Fset_window_configuration): Rewrite to handle dead buffers and
7436 consequently deletable windows.
7437 (window_tree, Fwindow_tree): Remove. Supply functionality in
7439 (compare_window_configurations): Simplify code.
7441 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7443 * image.c (imagemagick_load_image): Fix type mismatch.
7444 (Fimagemagick_types): Likewise.
7446 * window.h (replace_buffer_in_windows): Declare.
7448 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7450 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7451 Qclone_number. Remove external declaration of Qdelete_window.
7452 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7454 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7455 Run Qbuffer_list_update_hook if allowed.
7456 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7457 buffer list implementation.
7458 (other_buffer_safely): New function.
7459 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7460 calls to replace_buffer_in_windows and
7461 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7463 (record_buffer): Inhibit quitting and rewrite using quittable
7464 functions. Run Qbuffer_list_update_hook if allowed.
7465 (Frecord_buffer, Funrecord_buffer): New functions.
7466 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7467 Move switch-to-buffer to window.el.
7468 (bury-buffer): Move to window.el.
7469 (Vbuffer_list_update_hook): New variable.
7471 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7474 * window.h (resize_frame_windows): Move up in code.
7475 (Fwindow_frame): Remove EXFUN.
7476 (replace_buffer_in_all_windows): Remove prototype.
7477 (replace_buffer_in_windows_safely): Add prototype.
7479 * window.c: Declare Qdelete_window static again. Move down
7480 declaration of select_count.
7481 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7482 (Fother_window): Move to window.el.
7483 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7484 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7485 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7487 (replace_buffer_in_windows): Implement by calling
7488 Qreplace_buffer_in_windows.
7489 (replace_buffer_in_all_windows): Remove with some functionality
7490 moved into replace_buffer_in_windows_safely.
7491 (replace_buffer_in_windows_safely): New function.
7492 (select_window_norecord, select_frame_norecord): Move in front
7493 of run_window_configuration_change_hook. Remove now obsolete
7495 (Fset_window_buffer): Rewrite doc-string.
7496 Call Qrecord_window_buffer.
7497 (keys_of_window): Move binding for other-window to window.el.
7499 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7501 * dispextern.h (struct image): Replace data member, whose int_val
7502 and ptr_val fields were not used by anything, with a single
7505 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7506 (gif_clear_image, gif_load, imagemagick_load_image)
7507 (gs_clear_image, gs_load): Callers changed.
7509 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7511 * buffer.h: Include <time.h>, for time_t.
7512 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7514 Fix minor problems found by static checking.
7516 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7518 Make identifiers static if they are not used in other modules.
7519 * data.c (Qcompiled_function, Qframe, Qvector):
7520 * image.c (QimageMagick, Qsvg):
7521 * minibuf.c (Qmetadata):
7522 * window.c (resize_window_check, resize_root_window): Now static.
7523 * window.h (resize_window_check, resize_root_window): Remove decls.
7525 * window.c (window_deletion_count, delete_deletable_window):
7527 (window_body_lines): Now static.
7528 (Fdelete_other_windows_internal): Mark vars as initialized.
7529 Make sure 'resize_failed' is initialized.
7530 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7531 (resize_window_apply): Remove unused local.
7532 * window.h (delete_deletable_window): Remove decl.
7534 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7535 (imagemagick_load_image): Fix pointer signedness problem by changing
7536 last arg from unsigned char * to char *. All uses changed.
7537 Also, fix a local for similar reasons.
7538 Remove unused locals. Remove locals to avoid shadowing.
7539 (fn_rsvg_handle_free): Remove; unused.
7540 (svg_load, svg_load_image): Fix pointer signedness problem.
7541 (imagemagick_load_image): Don't use garbage pointer image_wand.
7543 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7545 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7547 * image.c (gif_load): Fix omitted cast error introduced by
7550 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7552 * window.h (resize_proportionally, orig_total_lines)
7553 (orig_top_line): Remove from window structure.
7554 (set_window_height, set_window_width, change_window_heights)
7555 (Fdelete_window): Remove prototypes.
7556 (resize_frame_windows): Remove duplicate declaration.
7558 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7560 * window.h (resize_frame_windows, resize_window_check)
7561 (delete_deletable_window, resize_root_window)
7562 (resize_frame_windows): Declare prototypes.
7564 * window.c (resize_window_apply): Make definition be "static" to
7565 match the prototype.
7567 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7569 * window.c: Remove declarations of Qwindow_size_fixed,
7570 window_min_size_1, window_min_size_2, window_min_size,
7571 size_window, window_fixed_size_p, enlarge_window, delete_window.
7572 Remove static from declaration of Qdelete_window, it's
7573 temporarily needed by Fbury_buffer.
7574 (replace_window): Don't assign orig_top_line and
7576 (Fdelete_window, delete_window): Remove. Window deletion is
7577 handled by window.el.
7578 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7579 Replace Fdelete_window calls with calls to Qdelete_window.
7580 (Fdelete_other_windows): Remove. Deleting other windows is
7581 handled by window.el.
7582 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7583 handled in window.el.
7584 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7585 Window minimum sizes are handled in window.el.
7586 (shrink_windows, size_window, set_window_height)
7587 (set_window_width, change_window_heights, window_height)
7588 (window_width, CURBEG, CURSIZE, enlarge_window)
7589 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7590 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7591 handled in window.el.
7592 (make_dummy_parent): Rename to make_parent_window and give it a
7593 second argument horflag.
7594 (make_window): Don't set resize_proportionally any more.
7595 (Fsplit_window): Remove. Windows are split in window.el.
7596 (save_restore_action, save_restore_orig_size)
7597 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7598 Resize mini windows in window.el.
7599 (grow_mini_window, shrink_mini_window): Implement by calling
7600 Qresize_root_window_vertically, resize_window_check and
7601 resize_window_apply.
7602 (saved_window, Fset_window_configuration, save_window_save):
7603 Do not handle orig_top_line, orig_total_lines, and
7604 resize_proportionally.
7605 (window_min_height, window_min_width): Move to window.el.
7606 (keys_of_window): Move bindings for delete-other-windows,
7607 split-window, delete-window and enlarge-window to window.el.
7609 * buffer.c: Temporarily extern Qdelete_window.
7610 (Fbury_buffer): Temporarily call Qdelete_window instead of
7611 Fdelete_window (Fbury_buffer will move to window.el soon).
7613 * frame.c (set_menu_bar_lines_1): Remove code handling
7614 orig_top_line and orig_total_lines.
7616 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7617 set_window_height but set heights directly.
7618 (change_frame_size_1): Use resize_frame_windows.
7620 * xdisp.c (init_xdisp): Don't use set_window_height but set
7623 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7624 Use resize_frame_windows instead of change_window_heights and run
7625 run_window_configuration_change_hook.
7627 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7628 instead of change_window_heights and run
7629 run_window_configuration_change_hook.
7631 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7633 * window.c (replace_window): Rename second argument REPLACEMENT to
7634 NEW. New third argument SETFLAG. Rewrite.
7635 (delete_window, make_dummy_parent): Call replace_window with
7637 (window_list_1): Move down in code.
7638 (run_window_configuration_change_hook): Move set_buffer part
7639 before select_frame_norecord part in order to unwind correctly.
7640 Rename count1 to count.
7641 (recombine_windows, delete_deletable_window, resize_root_window)
7642 (Fdelete_other_windows_internal)
7643 (Frun_window_configuration_change_hook, make_parent_window)
7644 (resize_window_check, resize_window_apply, Fresize_window_apply)
7645 (resize_frame_windows, Fsplit_window_internal)
7646 (Fdelete_window_internal, Fresize_mini_window_internal):
7648 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7650 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7652 * window.h (window): Add some new members to window structure -
7653 normal_lines, normal_cols, new_total, new_normal, clone_number,
7654 splits, nest, prev_buffers, next_buffers.
7655 (WINDOW_TOTAL_SIZE): Move here from window.c.
7656 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7658 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7660 (make_dummy_parent): Set new members of windows structure.
7661 (make_window): Move down in code. Handle new members of window
7663 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7664 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7665 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7666 (Fset_window_prev_buffers, Fwindow_next_buffers)
7667 (Fset_window_next_buffers, Fset_window_clone_number):
7669 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7670 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7672 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7673 Argument WINDOW can be now internal window too.
7674 (Fwindow_use_time): Move up in code.
7675 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7677 (Fset_window_configuration, saved_window)
7678 (Fcurrent_window_configuration, save_window_save): Handle new
7679 members of window structure.
7680 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7681 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7682 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7683 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7684 Qget_mru_window, Qresize_root_window,
7685 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7686 Qauto_buffer_name; staticpro them.
7688 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7690 * window.c (Fwindow_total_size, Fwindow_left_column)
7691 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7692 (Fwindow_list_1): New functions.
7693 (window_box_text_cols): Replace with window_body_cols.
7694 (Fwindow_width, Fscroll_left, Fscroll_right):
7695 Use window_body_cols instead of window_box_text_cols.
7696 (delete_window, Fset_window_configuration):
7697 Call delete_all_subwindows with window as argument.
7698 (delete_all_subwindows): Take a window as argument and not a
7700 (window_loop): Remove handling of GET_LRU_WINDOW and
7702 (Fget_lru_window, Fget_largest_window): Move to window.el.
7704 * window.h: Extern window_body_cols instead of
7705 window_box_text_cols. delete_all_subwindows now takes a
7706 Lisp_Object as argument.
7708 * indent.c (compute_motion, Fcompute_motion):
7709 Use window_body_cols instead of window_box_text_cols.
7711 * frame.c (delete_frame): Call delete_all_subwindows with root
7714 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7716 * fns.c (Fputhash): Document return value.
7718 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7720 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7722 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7724 Cons<->int and similar integer overflow fixes (Bug#8794).
7726 Check for overflow when converting integer to cons and back.
7727 * charset.c (Fdefine_charset_internal, Fdecode_char):
7728 Use cons_to_unsigned to catch overflow.
7729 (Fencode_char): Use INTEGER_TO_CONS.
7730 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7731 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7732 * data.c (long_to_cons, cons_to_long): Remove.
7733 (cons_to_unsigned, cons_to_signed): New functions.
7734 These signal an error for invalid or out-of-range values.
7735 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7736 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7737 * font.c (Ffont_variation_glyphs):
7738 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7739 * lisp.h: Include <intprops.h>.
7740 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7741 (cons_to_signed, cons_to_unsigned): New decls.
7742 (long_to_cons, cons_to_long): Remove decls.
7743 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7744 (Fprimitive_undo): Use CONS_TO_INTEGER.
7745 * xfns.c (Fx_window_property): Likewise.
7746 * xselect.c: Include <limits.h>.
7747 (x_own_selection, selection_data_to_lisp_data):
7748 Use INTEGER_TO_CONS.
7749 (x_handle_selection_request, x_handle_selection_clear)
7750 (x_get_foreign_selection, Fx_disown_selection_internal)
7751 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7752 (lisp_data_to_selection_data): Use cons_to_unsigned.
7753 (x_fill_property_data): Use cons_to_signed.
7754 Report values out of range.
7756 Check for buffer and string overflow more precisely.
7757 * buffer.h (BUF_BYTES_MAX): New macro.
7758 * lisp.h (STRING_BYTES_MAX): New macro.
7759 * alloc.c (Fmake_string):
7760 * character.c (string_escape_byte8):
7761 * coding.c (coding_alloc_by_realloc):
7762 * doprnt.c (doprnt):
7763 * editfns.c (Fformat):
7765 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7766 since they may not be the same number.
7767 * editfns.c (Finsert_char):
7768 * fileio.c (Finsert_file_contents):
7769 Likewise for BUF_BYTES_MAX.
7771 * image.c: Use ptrdiff_t, not int, for sizes.
7772 (slurp_file): Switch from int to ptrdiff_t.
7774 (slurp_file): Check that file size fits in both size_t (for
7775 malloc) and ptrdiff_t (for sanity and safety).
7777 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7778 if b->modtime has its maximal value.
7780 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7782 Don't assume time_t can fit into int.
7783 * buffer.h (struct buffer.modtime): Now time_t, not int.
7784 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7785 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7787 Minor fixes for signed vs unsigned integers.
7788 * character.h (MAYBE_UNIFY_CHAR):
7789 * charset.c (maybe_unify_char):
7790 * keyboard.c (read_char, reorder_modifiers):
7791 XINT -> XFASTINT, since the integer must be nonnegative.
7792 * ftfont.c (ftfont_spec_pattern):
7793 * keymap.c (access_keymap, silly_event_symbol_error):
7794 XUINT -> XFASTINT, since the integer must be nonnegative.
7795 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7796 since it makes no difference and we prefer signed.
7797 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7798 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7801 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7803 * window.h (Fwindow_frame): Declare.
7805 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7807 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7808 (SPARE_MEMORY): Always define.
7809 (LARGE_REQUEST): Remove.
7810 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7812 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7814 * lisp.h: Move EXFUNS for Fframe_root_window,
7815 Fframe_first_window and Fset_frame_selected_window to window.h.
7817 * window.h: Move EXFUNS for Fframe_root_window,
7818 Fframe_first_window and Fset_frame_selected_window here from
7821 * frame.c (Fwindow_frame, Fframe_first_window)
7822 (Fframe_root_window, Fframe_selected_window)
7823 (Fset_frame_selected_window): Move to window.c.
7824 (Factive_minibuffer_window): Move to minibuf.c.
7825 (Fother_visible_frames_p): New function.
7827 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7829 * window.c (decode_window, decode_any_window): Move up in code.
7830 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7831 (inhibit_frame_unsplittable): Remove unused variable.
7832 (Fwindow_buffer): Move up and rewrite doc-string.
7833 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7834 (Fwindow_prev): New functions.
7835 (Fwindow_frame): Move here from frame.c. Accept any window as
7837 (Fframe_root_window, Fframe_first_window)
7838 (Fframe_selected_window): Move here from frame.c. Accept frame
7839 or arbitrary window as argument. Update doc-strings.
7840 (Fminibuffer_window): Move up in code.
7841 (Fwindow_minibuffer_p): Move up in code and simplify.
7842 (Fset_frame_selected_window): Move here from frame.c.
7844 (Fselected_window, select_window, Fselect_window): Move up in
7845 code. Minor doc-string fixes.
7847 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7849 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7850 Do not assume that spare memory exists; that assumption is valid
7851 only if SYSTEM_MALLOC.
7852 (LARGE_REQUEST): New macro, so that the issue of large requests
7853 is separated from the issue of spare memory.
7855 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7857 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7860 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7862 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7865 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7867 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7869 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7871 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7872 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7874 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7876 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7878 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7880 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7881 (x_clipboard_manager_save): Add return value.
7882 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7884 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7885 Obey Vx_select_enable_clipboard_manager. Catch errors in
7886 x_clipboard_manager_save (Bug#8779).
7887 (Vx_select_enable_clipboard_manager): New variable.
7888 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7890 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7892 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7894 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7896 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7897 in the current matrix if keep_current_p is non-zero.
7899 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7901 * bidi.c (bidi_level_of_next_char): Fix last change.
7903 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7905 Support bidi reordering of text covered by display properties.
7907 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7908 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7909 (bidi_cache_search, bidi_cache_iterator_state)
7910 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7911 (bidi_level_of_next_char, bidi_move_to_visually_next):
7912 Support character positions inside a run of characters covered by a
7914 (bidi_paragraph_init, bidi_resolve_explicit_1)
7915 (bidi_level_of_next_char): Call bidi_fetch_char and
7916 bidi_fetch_char_advance instead of FETCH_CHAR and
7918 (bidi_init_it): Initialize new members.
7919 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7921 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7922 instead of using explicit *_CHAR codes.
7923 (bidi_resolve_explicit, bidi_resolve_weak):
7924 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7925 bidirectional text is supported only in multibyte buffers.
7926 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7927 it to initialize the frame_window_p member of struct bidi_it.
7928 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7929 (bidi_resolve_explicit, bidi_resolve_weak)
7930 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7931 bidi_it->nchars is non-positive.
7932 (bidi_level_of_next_char): Don't try to lookup the cache for the
7933 next/previous character if nothing is cached there yet, or if we
7934 were just reseat()'ed to a new position.
7936 * xdisp.c (set_cursor_from_row): Set start and stop points
7937 according to the row's direction when priming the loop that looks
7938 for the glyph on which to display cursor.
7939 (single_display_spec_intangible_p): Function deleted.
7940 (display_prop_intangible_p): Reimplement to call
7941 handle_display_spec instead of single_display_spec_intangible_p.
7942 Accept 3 additional arguments needed by handle_display_spec.
7943 This fixes incorrect cursor motion across display property with complex
7944 values: lists, `(when COND...)' forms, etc.
7945 (single_display_spec_string_p): Support property values that are
7946 lists with the argument STRING its top-level element.
7947 (display_prop_string_p): Fix the condition for processing a
7948 property that is a list to be consistent with handle_display_spec.
7949 (handle_display_spec): New function, refactored from the
7950 last portion of handle_display_prop.
7951 (compute_display_string_pos): Accept additional argument
7952 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7953 value of a `display' property is a "replacing spec".
7954 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7955 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7956 the display property, but just return a value indicating whether
7957 the display property will replace the characters it covers.
7958 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7959 frame_window_p members of struct bidi_it.
7960 (compute_display_string_pos, compute_display_string_end):
7962 (push_it): Accept second argument POSITION, where pop_it should
7963 jump to continue iteration.
7964 (reseat_1): Initialize bidi_it.disp_pos.
7966 * keyboard.c (adjust_point_for_property): Adjust the call to
7967 display_prop_intangible_p to its new signature.
7969 * dispextern.h (struct bidi_it): New member frame_window_p.
7970 (bidi_init_it): Update prototypes.
7971 (display_prop_intangible_p): Update prototype.
7972 (compute_display_string_pos, compute_display_string_end):
7974 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7977 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7979 Malloc failure behavior now depends on size of allocation.
7980 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7981 * lisp.h: Change signatures accordingly.
7982 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7983 All callers changed. (Bug#8762)
7985 * gnutls.c: Use Emacs's memory allocators.
7986 Without this change, the gnutls library would invoke malloc etc.
7987 directly, which causes problems on non-SYNC_INPUT hosts, and which
7988 runs afoul of improving memory_full behavior. (Bug#8761)
7989 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7990 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7991 xfree instead of the default malloc, realloc, free.
7992 (Fgnutls_boot): No need to check for memory allocation failure,
7993 since xmalloc does that for us.
7995 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7996 * category.c (hash_get_category_set):
7997 * ccl.c (ccl_driver):
7998 * charset.c (Fdefine_charset_internal):
7999 * charset.h (struct charset.hash_index):
8000 * composite.c (get_composition_id, gstring_lookup_cache)
8001 (composition_gstring_put_cache):
8002 * composite.h (struct composition.hash_index):
8003 * dispextern.h (struct image.hash):
8004 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8005 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8006 (hashfn_equal, hashfn_user_defined, make_hash_table)
8007 (maybe_resize_hash_table, hash_lookup, hash_put)
8008 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8009 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8010 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8011 * image.c (make_image, search_image_cache, lookup_image)
8012 (xpm_put_color_table_h):
8013 * lisp.h (struct Lisp_Hash_Table):
8014 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8015 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8016 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8017 * alloc.c (allocate_vectorlike):
8018 Check for overflow in vector size calculations.
8019 * ccl.c (ccl_driver):
8020 Check for overflow when converting EMACS_INT to int.
8021 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8022 need to be updated by these changes.
8023 * fns.c (make_hash_table, maybe_resize_hash_table):
8024 Check for integer overflow with large hash tables.
8025 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8026 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8027 (SXHASH_REDUCE): New macro.
8028 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8029 Use it instead of discarding useful hash info with large hash values.
8030 (sxhash_float): New function.
8031 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8032 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8033 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8034 Rewrite to use FIXNUM_BITS, as this simplifies things.
8035 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8036 Adjust signatures to match updated version of code.
8037 (consing_since_gc): Now EMACS_INT, since a single hash table can
8038 use more than INT_MAX bytes.
8040 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8042 Make it possible to build with GCC-4.6+ -O2 -flto.
8044 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8046 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8048 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8049 Call minibuffer-inactive-mode.
8051 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8053 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8054 Update dependencies.
8056 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8058 * data.c (init_data): Remove code for UTS, this system is not
8061 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8063 Don't force ./temacs to start in terminal mode.
8065 * frame.c (make_initial_frame): Initialize faces in all cases, not
8066 only when CANNOT_DUMP is defined.
8067 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8069 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8071 * dispnew.c (add_window_display_history): Use const for the string
8072 pointer. Remove declaration, not needed.
8074 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8076 Use 'inline', not 'INLINE'.
8077 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8078 * alloc.c, fontset.c (INLINE): Remove.
8079 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8080 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8081 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8082 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8083 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8085 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8087 Make it possible to run ./temacs.
8089 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8090 syms_of_callproc does the same thing. Remove test for
8091 "initialized", do it in the caller.
8092 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8094 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8096 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8097 (read_minibuf): Use get_minibuffer.
8098 (syms_of_minibuf): Use DEFSYM.
8099 (Qmetadata): New var.
8100 * data.c (Qbuffer): Don't make it static.
8101 (syms_of_data): Use DEFSYM.
8103 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8105 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8106 (CCL_CODE_MIN): New macro.
8108 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8110 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8112 * eval.c (Qdebug): Now static.
8113 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8114 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8115 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8117 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8119 * image.c: Various fixes to ImageMagick code comments.
8120 (Fimagemagick_types): Doc fix.
8122 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8124 Minor fixes prompted by GCC 4.6.0 warnings.
8126 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8128 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8129 (x_clipboard_manager_save_all): Move extern decl to ...
8130 * xterm.h: ... here, so that it can be checked for consistency.
8132 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8134 * xselect.c (x_clipboard_manager_save_frame)
8135 (x_clipboard_manager_save_all): New functions.
8136 (Fx_clipboard_manager_save): Lisp function deleted.
8138 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8139 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8141 * xterm.h: Update prototype.
8143 2011-05-28 William Xu <william.xwl@gmail.com>
8145 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8148 2011-05-28 Jim Meyering <meyering@redhat.com>
8150 Avoid a sign-extension bug in crypto_hash_function.
8151 * fns.c (to_uchar): Define.
8152 (crypto_hash_function): Use it to convert some newly-signed
8153 variables to unsigned, to avoid sign-extension bugs. For example,
8154 without this change, (md5 "truc") would evaluate to
8155 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8156 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8157 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8159 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8161 Integer overflow fixes.
8163 * dbusbind.c: Serial number integer overflow fixes.
8164 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8165 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8166 to hold a serial number that is too large for a fixnum.
8167 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8168 Check for serial numbers out of range. Decode any serial number
8169 that was so large that it became a float. (Bug#8722)
8171 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8172 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8173 Use XFASTINT rather than XUINT when numbers are nonnegative.
8174 (xd_append_arg, Fdbus_method_return_internal):
8175 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8176 arguments, check that Lisp number is nonnegative, rather than
8177 silently wrapping negative numbers around. (Bug#8722)
8178 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8181 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8183 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8185 ccl: Add integer overflow checks.
8186 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8187 (IN_INT_RANGE): New macros.
8188 (ccl_driver): Use them to check for integer overflow when
8189 decoding a CCL program. Many of the new checks are whether XINT (x)
8190 fits in int; it doesn't always, on 64-bit hosts. The new version
8191 doesn't catch all possible integer overflows, but it's an
8192 improvement. (Bug#8719)
8194 * alloc.c (make_event_array): Use XINT, not XUINT.
8195 There's no need for unsigned here.
8197 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8198 This follows up to the 2011-05-06 change that substituted uintptr_t
8199 for EMACS_INT. This case wasn't caught back then.
8201 Rework Fformat to avoid integer overflow issues.
8202 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8203 now (part of C89). Include <verify.h>.
8204 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8205 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8206 (Fformat): Avoid the prepass trying to compute sizes; it was only
8207 approximate and thus did not catch overflow reliably. Instead, walk
8208 through the format just once, formatting and computing sizes as we go,
8209 checking for integer overflow at every step, and allocating a larger
8210 buffer as needed. Keep track separately whether the format is
8211 multibyte. Keep only the most-recently calculated precision, rather
8212 than them all. Record whether each argument has been converted to
8213 string. Use EMACS_INT, not int, for byte and char and arg counts.
8214 Support field widths and precisions larger than INT_MAX. Avoid
8215 sprintf's undefined behavior with conversion specifications such as %#d
8216 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8217 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8218 formatting out-of-range floating point numbers with int
8221 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8223 * data.c: Avoid integer truncation in expressions involving floats.
8224 * data.c: Include <intprops.h>.
8225 (arith_driver): When there's an integer overflow in an expression
8226 involving floating point, convert the integers to floating point
8227 so that the resulting value does not suffer from catastrophic
8228 integer truncation. For example, on a 64-bit host (* 4
8229 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8230 Do not rely on undefined behavior after integer overflow.
8232 merge count_size_as_multibyte, parse_str_to_multibyte
8233 * character.c, character.h (count_size_as_multibyte):
8234 Rename from parse_str_to_multibyte; all uses changed.
8235 Check for integer overflow.
8236 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8237 since it's now a duplicate of the other. This is more of
8238 a character than a buffer op, so better that it's in character.c.
8239 * fns.c, print.c: Adjust to above changes.
8241 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8243 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8245 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8247 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8248 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8249 (x_clipboard_manager_save): Now static.
8250 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8252 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8253 (crypto_hash_function): Now static.
8254 Fix pointer signedness problems. Avoid unnecessary initializations.
8256 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8258 * termhooks.h (Vselection_alist): Make it terminal-local.
8260 * terminal.c (create_terminal): Initialize it.
8262 * xselect.c: Support for clipboard managers.
8263 (Vselection_alist): Move to termhooks.h as terminal-local var.
8264 (LOCAL_SELECTION): New macro.
8265 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8266 (symbol_to_x_atom): Remove gratuitous arg.
8267 (x_handle_selection_request, lisp_data_to_selection_data)
8268 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8269 (x_own_selection, x_get_local_selection, x_convert_selection):
8270 New arg, specifying work frame. Use terminal-local Vselection_alist.
8271 (some_frame_on_display): Delete unused function.
8272 (Fx_own_selection_internal, Fx_get_selection_internal)
8273 (Fx_disown_selection_internal, Fx_selection_owner_p)
8274 (Fx_selection_exists_p): New optional frame arg.
8275 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8276 (x_handle_selection_clear): Don't treat other terminals with the
8277 same keyboard specially. Use the terminal-local Vselection_alist.
8278 (x_clear_frame_selections): Use Frun_hook_with_args.
8280 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8282 * xterm.h: Add support for those atoms.
8284 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8286 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8287 (converted_selections, conversion_fail_tag): New global variables.
8288 (x_selection_request_lisp_error): Free the above.
8289 (x_get_local_selection): Remove unnecessary code.
8290 (x_reply_selection_request): Args changed; handle arbitrary array
8291 of converted selections stored in converted_selections.
8292 Separate the XChangeProperty and SelectionNotify steps.
8293 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8294 (x_convert_selection): New function.
8295 (x_handle_selection_event): Simplify.
8296 (x_get_foreign_selection): Don't ignore incoming requests while
8297 waiting for an answer; this will fail when we implement
8298 SAVE_TARGETS, and seems unnecessary anyway.
8299 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8300 (Vx_sent_selection_functions): Doc fix.
8302 2011-05-26 Leo Liu <sdl.web@gmail.com>
8304 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8306 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8308 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8310 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8311 for fringe update if it has periodic bitmap.
8312 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8313 and fringe_bitmap_periodic_p.
8315 * fringe.c (get_fringe_bitmap_data): New function.
8316 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8317 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8318 row. Mark glyph row for fringe update if periodicity changed.
8320 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8321 for fringe update unless it has periodic bitmap.
8323 2011-05-25 Kenichi Handa <handa@m17n.org>
8325 * xdisp.c (get_next_display_element): Set correct it->face_id for
8326 a static composition.
8328 2011-05-24 Leo Liu <sdl.web@gmail.com>
8331 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8333 * fns.c (crypto_hash_function, Fsha1): New function.
8334 (Fmd5): Use crypto_hash_function.
8335 (syms_of_fns): Add Ssha1.
8337 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8339 * gnutls.c: Remove unused macros.
8340 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8341 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8342 Remove macros that are defined and never used.
8343 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8345 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8347 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8348 (Fx_get_selection_internal): Minor cleanup.
8349 (Fx_own_selection_internal): Rename arguments for consistency with
8352 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8354 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8356 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8358 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8360 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8362 * dispnew.c (scrolling_window): Don't exclude the case that the
8363 last enabled row in the desired matrix touches the bottom boundary.
8365 2011-05-21 Glenn Morris <rgm@gnu.org>
8367 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8368 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8369 and add some more files.
8371 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8373 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8374 report_file_error introduced by the change from 2011-05-07.
8376 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8378 * systime.h (Time): Define only if emacs is defined.
8379 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8380 where the include path doesn't have X11/X.h by default. See
8381 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8383 2011-05-20 Kenichi Handa <handa@m17n.org>
8385 * composite.c (find_automatic_composition): Fix previous change.
8387 2011-05-20 Glenn Morris <rgm@gnu.org>
8389 * lisp.mk: New file, split from Makefile.in.
8390 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8391 (shortlisp): Remove.
8392 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8394 2011-05-19 Glenn Morris <rgm@gnu.org>
8396 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8397 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8398 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8399 (lisp): Set the order to that of loadup.el.
8400 (shortlisp): Make it a copy of $lisp.
8401 (SOME_MACHINE_LISP): Remove.
8402 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8403 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8405 2011-05-18 Kenichi Handa <handa@m17n.org>
8407 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8408 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8409 (find_automatic_composition): Mostly rewrite for efficiency.
8411 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8413 * makefile.w32-in: Update dependencies.
8415 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8417 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8418 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8420 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8422 Fix some integer overflow issues, such as string length overflow.
8424 * insdel.c (count_size_as_multibyte): Check for string overflow.
8426 * character.c (lisp_string_width): Check for string overflow.
8427 Use EMACS_INT, not int, for string indexes and lengths; in
8428 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8429 the resulting string length overflows an EMACS_INT; instead,
8430 report a string overflow if no precision given. When checking for
8431 precision exhaustion, use a check that cannot possibly have
8432 integer overflow. (Bug#8675)
8433 * character.h (lisp_string_width): Adjust to new signature.
8435 * alloc.c (string_overflow): New function.
8436 (Fmake_string): Use it. This doesn't change behavior, but saves
8437 a few bytes and will simplify future changes.
8438 * character.c (string_escape_byte8): Likewise.
8439 * lisp.h (string_overflow): New decl.
8441 Fixups, following up to the user-interface timestamp change.
8442 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8443 for UI timestamps, instead of unsigned long.
8444 * msdos.c (mouse_get_pos): Likewise.
8445 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8446 * w32gui.h (Time): Define by including "systime.h" rather than by
8447 declaring it ourselves. (Bug#8664)
8449 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8450 * image.c (clear_image_cache): Likewise.
8452 * term.c (term_mouse_position): Don't assume time_t wraparound.
8454 Be more systematic about user-interface timestamps.
8455 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8456 and sometimes 'EMACS_UINT', to represent these timestamps.
8457 This change causes it to use 'Time' uniformly, as that's what X uses.
8458 This makes the code easier to follow, and makes it easier to catch
8459 integer overflow bugs such as Bug#8664.
8460 * frame.c (Fmouse_position, Fmouse_pixel_position):
8461 Use Time, not unsigned long, for user-interface timestamps.
8462 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8463 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8464 * keyboard.h (last_event_timestamp): Likewise.
8465 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8466 * menu.h (xmenu_show): Likewise.
8467 * term.c (term_mouse_position): Likewise.
8468 * termhooks.h (struct input_event.timestamp): Likewise.
8469 (struct terminal.mouse_position_hook): Likewise.
8470 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8471 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8472 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8473 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8475 * menu.h, termhooks.h: Include "systime.h", for Time.
8477 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8478 Don't assume that the difference between two unsigned long values
8479 can fit into an integer. At this point, we know button_down_time
8480 <= event->timestamp, so the difference must be nonnegative, so
8481 there's no need to cast the result if double-click-time is
8482 nonnegative, as it should be; check that it's nonnegative, just in
8483 case. This bug is triggered when events are more than 2**31 ms
8484 apart (about 25 days). (Bug#8664)
8486 * xselect.c (last_event_timestamp): Remove duplicate decl.
8487 (x_own_selection): Remove needless cast to unsigned long.
8489 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8490 that always fit in int. Use a sentinel instead of a counter, to
8491 avoid a temp and to allay GCC's concerns about possible int overflow.
8492 * frame.h (struct frame): Use int for menu_bar_items_used
8493 instead of EMACS_INT, since it always fits in int.
8495 * menu.c (grow_menu_items): Check for int overflow.
8497 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8499 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8500 Before, the code was not consistent. These values cannot exceed
8501 2**31 - 1 so there's no need to make them unsigned.
8502 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8503 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8504 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8506 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8508 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8509 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8510 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8511 presumably because the widths might not match.
8513 * window.c (size_window): Avoid needless test at loop start.
8515 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8517 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8519 2011-05-12 Drew Adams <drew.adams@oracle.com>
8521 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8523 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8525 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8526 `width' to `bar_area_x' and `bar_area_width', respectively.
8527 (x_scroll_run): Take account of fringe background extension.
8529 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8530 Rename local vars `left' and `width' to `bar_area_x' and
8531 `bar_area_width', respectively.
8532 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8533 background extension.
8535 2011-05-10 Jim Meyering <meyering@redhat.com>
8537 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8539 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8541 * image.c (Finit_image_library): Return t for built-in image types,
8542 like pbm and xbm. (Bug#8640)
8544 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8546 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8548 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8550 * w32console.c (Fset_screen_color): Doc fix.
8551 (Fget_screen_color): New function.
8552 (syms_of_ntterm): Defsubr it.
8554 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8555 unlink the temporary file if Fcall_process didn't create it in the
8557 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8558 child process will be redirected to a file specified with `:file'.
8559 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8560 cue to call_process_cleanup not to close that handle.
8562 2011-05-07 Ben Key <bkey76@gmail.com>
8564 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8565 one of two shell specific rules, either bootstrap-temacs-CMD or
8566 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8567 to the previous implementation of the bootstrap-temacs rule.
8568 The bootstrap-temacs-CMD rule is similar to the previous
8569 implementation of the bootstrap-temacs rule except that it
8570 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8573 These changes, along with some changes to nt/configure.bat,
8574 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8575 earlier fix to add support for --cflags and --ldflags options
8576 that include quotes so that it works whether make uses cmd or
8579 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8581 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8582 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8584 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8585 a string. Handle both cases.
8586 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8587 (Fdbus_register_method): Use Qinvalid_function.
8589 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8591 * makefile.w32-in: Update dependencies.
8592 (LISP_H): Add inttypes.h and stdin.h.
8593 (PROCESS_H): Add unistd.h.
8595 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8597 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8598 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8600 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8602 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8604 * term.c (vfatal): Remove stray call to va_end.
8605 It's not needed and the C Standard doesn't allow it here anyway.
8607 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8608 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8610 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8613 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8615 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8617 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8619 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8621 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8623 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8624 * charset.c (Fdefine_charset_internal): Don't initialize
8625 charset.code_space[15]. The value was garbage, on hosts with
8626 32-bit int (Bug#8600).
8628 * lread.c (read_integer): Be more consistent with string-to-number.
8629 Use string_to_number to do the actual conversion; this avoids
8630 rounding errors and fixes some other screwups. Without this fix,
8631 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8632 (digit_to_number): Move earlier, for benefit of read_integer.
8633 Return -1 if the digit is out of range for the base, -2 if it is
8634 not a digit in any supported base. (Bug#8602)
8636 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8638 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8639 to match comment at start of function. This also removes a
8640 GCC warning about overflow in a 32+64-bit port.
8642 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8644 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8645 Reported by Stefan Monnier in
8646 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8647 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8648 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8650 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8651 (EMACS_UINTPTR): Likewise, with uintptr_t.
8653 * lisp.h: Prefer 64-bit EMACS_INT if available.
8654 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8655 on 32-bit hosts that have 64-bit int, so that they can access
8657 However, temporarily disable this change unless the temporary
8658 symbol WIDE_EMACS_INT is defined.
8660 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8662 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8663 This removes an assumption that EMACS_INT and long are the same
8664 width as pointers. The assumption is true for Emacs porting targets
8665 now, but we want to make other targets possible.
8666 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8667 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8668 In the rest of the code, change types of integers that hold casted
8669 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8670 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8671 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8672 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8673 No need to cast type when ORing.
8674 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8675 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8676 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8677 assume EMACS_INT is the same width as char *.
8678 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8679 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8680 Remove no-longer-needed casts.
8681 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8682 (xg_tool_bar_help_callback, xg_make_tool_item):
8683 Use EMACS_INTPTR to hold an integer
8684 that will be cast to void *; this can avoid a GCC warning
8685 if EMACS_INT is not the same width as void *.
8686 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8687 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8688 (current_message_1, set_message_1):
8689 Use a local to convert to proper width without a cast.
8690 * xmenu.c (dialog_selection_callback): Likewise.
8692 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8693 Also, don't assume VALBITS / RAND_BITS is less than 5,
8694 and don't rely on undefined behavior when shifting a 1 left into
8696 * lisp.h (get_random): Change signature to match.
8698 * lread.c (hash_string): Use size_t, not int, for hash computation.
8699 Normally we prefer signed values; but hashing is special, because
8700 it's better to use unsigned division on hash table sizes so that
8701 the remainder is nonnegative. Also, size_t is the natural width
8702 for hashing into memory. The previous code used 'int', which doesn't
8703 retain enough info to hash well into very large tables.
8704 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8706 * dbusbind.c: Don't possibly lose pointer info when converting.
8707 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8708 Use XPNTR rather than XHASH, so that the high-order bits of
8709 the pointer aren't lost when converting through void *.
8711 * eval.c (Fautoload): Don't double-shift a pointer.
8713 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8715 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8717 * gnutls.c (DEF_GNUTLS_FN):
8718 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8720 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8722 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8725 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8727 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8728 New version that can reserve upto 2GB of heap space.
8730 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8732 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8734 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8736 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8737 `gnutls_certificate_set_x509_key_file'.
8739 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8741 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8742 Update dependencies.
8744 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8746 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8747 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8748 Remove unused parameter `fildes'.
8749 * process.c (read_process_output, send_process): Don't pass it.
8751 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8753 Fix previous change: the library cache is defined in w32.c.
8754 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8755 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8757 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8759 Implement dynamic loading of GnuTLS on Windows.
8761 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8762 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8763 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8766 * gnutls.c (Qgnutls_dll): Define.
8767 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8768 (gnutls_*): Declare function pointers.
8769 (init_gnutls_functions): New function to initialize function pointers.
8770 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8771 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8772 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8773 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8774 (emacs_gnutls_write, emacs_gnutls_read)
8775 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8776 (Fgnutls_available_p): New function.
8777 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8778 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8779 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8781 * image.c: Include w32.h.
8782 (Vimage_type_cache): Delete.
8783 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8784 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8785 (w32_delayed_load): Move to w32.c.
8787 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8789 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8790 (w32_delayed_load): Move from image.c. When loading a library, record
8791 its filename in the :loaded-from property of the library id.
8792 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8793 Initialize and staticpro them.
8794 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8796 * process.c: Include lisp.h before w32.h, not after.
8797 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8798 instead of gnutls_record_check_pending.
8800 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8802 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8804 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8805 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8808 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8810 * xterm.c (x_set_frame_alpha): Do not set property on anything
8811 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8813 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8815 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8817 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8819 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8820 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8821 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8822 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8823 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8824 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8825 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8826 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8827 (Qgnutls_bootprop_callbacks_verify): Make static.
8829 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8831 * callproc.c: Indentation fixup.
8833 * sysdep.c (wait_for_termination_1): Make static.
8834 (wait_for_termination, interruptible_wait_for_termination):
8835 Move after wait_for_termination_1.
8837 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8839 * sysdep.c (interruptible_wait_for_termination): New function
8840 which is like wait_for_termination, but allows keyboard
8843 * callproc.c (Fcall_process): Add (:file "file") as an option for
8845 (Fcall_process_region): Ditto.
8847 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8849 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8850 rather than `XVECTOR (FOO)->size'.
8852 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8853 inttypes.h, as a gnulib replacement is used if it not available in
8856 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8858 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8859 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8860 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8862 * coding.c (coding_alloc_by_realloc): Error out if destination
8863 will grow beyond MOST_POSITIVE_FIXNUM.
8864 (decode_coding_emacs_mule): Abort if there isn't enough place in
8865 charbuf for the composition carryover bytes. Reserve an extra
8866 space for up to 2 characters produced in a loop.
8867 (decode_coding_iso_2022): Abort if there isn't enough place in
8868 charbuf for the composition carryover bytes.
8870 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8872 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8873 aborting when %lld or %lll format is passed.
8874 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8875 %llo or %llx format is passed. (Bug#8545)
8877 * window.c (window_scroll_line_based): Use a marker instead of
8878 simple variables to record original value of point. (Bug#7952)
8880 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8881 produced by %s or %c overflows available buffer space. (Bug#8545)
8883 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8885 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8886 (SIZE_MAX): Move defn after all includes, as they might #define it.
8888 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8890 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8892 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8894 * keyboard.c (Qdelayed_warnings_hook): Define.
8895 (command_loop_1): Run `delayed-warnings-hook'
8896 if Vdelayed_warnings_list is non-nil.
8897 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8898 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8900 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8902 * doprnt.c (doprnt): Don't return value smaller than the buffer
8903 size if the message was truncated. (Bug#8545).
8905 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8907 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8908 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8910 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8912 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8914 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8916 * makefile.w32-in: Update dependencies.
8918 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8920 Improve `doprnt' and its usage. (Bug#8545)
8921 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8922 `format_end'. Remove support for %l as a conversion specifier.
8923 Don't use xrealloc. Improve diagnostics when the %l size modifier
8924 is used. Update the commentary.
8926 * eval.c (verror): Simplify calculation of size_t.
8928 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8931 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8933 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8936 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8938 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8939 This makes this file independent of the recent pseudovector change.
8941 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8943 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8945 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8946 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8947 Remove unused local.
8948 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8950 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8951 GCC 4.6.0 optimizes based on type-based alias analysis.
8952 For example, if b is of type struct buffer * and v of type struct
8953 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8954 != &v->size, and therefore "v->size = 1; b->size = 2; return
8955 v->size;" must therefore return 1. This assumption is incorrect
8956 for Emacs, since it type-puns struct Lisp_Vector * with many other
8957 types. To fix this problem, this patch adds a new type struct
8958 vectorlike_header that documents the constraints on layout of vectors
8959 and pseudovectors, and helps optimizing compilers not get fooled
8960 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8961 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8962 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8964 (XSETPVECTYPE): Rewrite in terms of new macro.
8965 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8966 This is a bit clearer, and further avoids the possibility of
8967 undesirable aliasing.
8968 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8969 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8970 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8971 since Lisp_Subr is a special case (no "next" field).
8972 (ASIZE): Now uses header.size rather than size.
8973 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8974 to avoid the hassle of writing XVECTOR (foo)->header.size.
8975 (struct vectorlike_header): New type.
8976 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8977 object, to help avoid aliasing.
8978 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8979 (SUBRP): Likewise, since Lisp_Subr is a special case.
8980 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8981 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8982 (struct Lisp_Hash_Table): Combine first two members into a single
8983 struct vectorlike_header member. All uses of "size" and "next" members
8984 changed to be "header.size" and "header.next".
8985 * buffer.h (struct buffer): Likewise.
8986 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8987 * frame.h (struct frame): Likewise.
8988 * process.h (struct Lisp_Process): Likewise.
8989 * termhooks.h (struct terminal): Likewise.
8990 * window.c (struct save_window_data, struct saved_window): Likewise.
8991 * window.h (struct window): Likewise.
8992 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8993 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8994 * buffer.c (init_buffer_once): Likewise.
8995 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8997 * process.c (Fformat_network_address): Use local var for size,
9000 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9002 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9003 * data.c (atof): Remove decl; no longer used or needed.
9004 (digit_to_number): Move to lread.c.
9005 (Fstring_to_number): Use new string_to_number function, to be
9006 consistent with how the Lisp reader treats infinities and NaNs.
9007 Do not assume that floating-point numbers represent EMACS_INT
9008 without losing information; this is not true on most 64-bit hosts.
9009 Avoid double-rounding errors, by insisting on integers when
9010 parsing non-base-10 numbers, as the documentation specifies.
9011 * lisp.h (string_to_number): New decl, replacing ...
9012 (isfloat_string): Remove.
9013 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9014 (read1): Do not accept +. and -. as integers; this
9015 appears to have been a coding error. Similarly, do not accept
9016 strings like +-1e0 as floating point numbers. Do not report
9017 overflow for integer overflows unless the base is not 10 which
9018 means we have no simple and reliable way to continue.
9019 Break out the floating-point parsing into a new
9020 function string_to_number, so that Fstring_to_number parses
9021 floating point numbers consistently with the Lisp reader.
9022 (digit_to_number): Move here from data.c. Make it static inline.
9023 (E_CHAR, EXP_INT): Remove, replacing with ...
9024 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9025 (string_to_number): New function, replacing isfloat_string.
9026 This function checks for valid syntax and produces the resulting
9027 Lisp float number too. Rework it so that string-to-number
9028 no longer mishandles examples like "1.0e+". Use strtoumax,
9029 so that overflow for non-base-10 numbers is reported only when
9030 there's no portable and simple way to convert to floating point.
9032 * textprop.c (set_text_properties_1): Rewrite for clarity,
9033 and to avoid GCC warning about integer overflow.
9035 * intervals.h (struct interval): Use EMACS_INT for members
9036 where EMACS_UINT might cause problems. See
9037 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9038 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9039 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9041 (offset_intervals): Tell GCC not to worry about length overflow
9042 when negating a negative length.
9044 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9045 (overrun_check_free): Likewise.
9047 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9048 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9051 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9052 (gnutls_make_error): Rename local to avoid shadowing.
9053 (gnutls_emacs_global_deinit): ifdef out; not used.
9054 (Fgnutls_boot): Use const for pointer to readonly storage.
9055 Comment out unused local. Fix pointer signedness problems.
9057 * lread.c (openp): Don't stuff size_t into an 'int'.
9058 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9059 about possible signed overflow.
9061 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9062 (GDK_KEY_g): Don't define if already defined.
9063 (xg_prepare_tooltip): Avoid pointer signedness problem.
9064 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9066 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9067 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9069 * xfns.c (Fx_window_property): Simplify a bit,
9070 to make a bit faster and to avoid GCC 4.6.0 warning.
9071 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9073 * fns.c (internal_equal): Don't assume size_t fits in int.
9075 * alloc.c (compact_small_strings): Tighten assertion a little.
9077 Replace pEd with more-general pI, and fix some printf arg casts.
9078 * lisp.h (pI): New macro, generalizing old pEd macro to other
9079 conversion specifiers. For example, use "...%"pI"d..." rather
9080 than "...%"pEd"...".
9081 (pEd): Remove. All uses replaced with similar uses of pI.
9082 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9083 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9084 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9085 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9086 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9087 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9088 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9090 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9091 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9092 * print.c (safe_debug_print, print_object): Likewise.
9093 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9095 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9096 avoiding the 0 flag, which is not portable.
9097 * process.c (Fmake_network_process): Use pI to avoid cast.
9098 * region-cache.c (pp_cache): Likewise.
9099 * xdisp.c (decode_mode_spec): Likewise.
9100 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9101 behavior on 64-bit hosts with printf arg.
9102 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9103 (x_stop_queuing_selection_requests): Likewise.
9104 (x_get_window_property): Don't truncate byte count to an 'int'
9107 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9108 here, since it parses constructs like leading '-' and spaces,
9109 which are not wanted; and it overflows with large numbers.
9110 Instead, simply match F[0-9]+, which is what is wanted anyway.
9112 * alloc.c: Remove unportable assumptions about struct layout.
9113 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9114 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9115 (allocate_vectorlike, make_pure_vector): Use the new macros,
9116 plus offsetof, to remove unportable assumptions about struct layout.
9117 These assumptions hold on all porting targets that I know of, but
9118 they are not guaranteed, they're easy to remove, and removing them
9119 makes further changes easier.
9121 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9122 This doesn't fix a bug but makes the code clearer.
9123 (string_overrun_cookie): Now const. Use initializers that
9124 don't formally overflow signed char, to avoid warnings.
9125 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9126 can cause Emacs to crash when string overrun checking is enabled.
9127 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9128 multiple of sizeof (EMACS_INT); it need not be, if
9129 alignof(EMACS_INT) < sizeof (EMACS_INT).
9130 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9132 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9134 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9136 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9138 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9139 supposed to be handshaking. (Bug#8556)
9140 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9142 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9144 * lisp.h (Qdebug): List symbol.
9145 * eval.c (Qdebug): Restore global linkage.
9146 * keyboard.c (debug-on-event): New variable.
9147 (handle_user_signal): Break into debugger when debug-on-event
9148 matches the current signal symbol.
9150 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9152 * alloc.c (check_sblock, check_string_bytes)
9153 (check_string_free_list): Convert to standard C.
9155 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9157 * w32.c (emacs_gnutls_push): Fix typo.
9159 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9161 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9162 "cast to pointer from integer of different size".
9164 Improve doprnt and its use in verror. (Bug#8545)
9165 * doprnt.c (doprnt): Document the set of format control sequences
9166 supported by the function. Use SAFE_ALLOCA instead of always
9169 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9170 is one byte too soon. Don't use xrealloc; instead xfree and
9173 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9175 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9178 * gnutls.c: Renamed global_initialized to
9179 gnutls_global_initialized. Added internals for the
9180 :verify-hostname-error, :verify-error, and :verify-flags
9181 parameters of `gnutls-boot' and documented those parameters in the
9182 docstring. Start callback support.
9183 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9184 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9185 on error. Return error code.
9186 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9187 (emacs_gnutls_read): Likewise.
9188 (Fgnutls_boot): Return handshake error code.
9189 (emacs_gnutls_handle_error): New function.
9190 (wsaerror_to_errno): Likewise.
9192 * w32.h (emacs_gnutls_pull): Add prototype.
9193 (emacs_gnutls_push): Likewise.
9195 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9196 (emacs_gnutls_push): Likewise.
9198 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9200 * process.c (wait_reading_process_output): Check if GnuTLS
9201 buffered some data internally if no FDs are set for TLS
9204 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9205 (LIBS): Link to USER_LIBS.
9206 ($(BLD)/gnutls.$(0)): New target.
9208 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9210 * xdisp.c (handle_single_display_spec): Rename the
9211 display_replaced_before_p argument into display_replaced_p, to
9212 make it consistent with the commentary. Fix typos in the
9215 * textprop.c (syms_of_textprop): Remove dead code.
9216 (copy_text_properties): Delete obsolete commentary about an
9217 interface that was deleted long ago. Fix typos in the description
9220 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9221 to changes in oldXMenu/XMenu.h from 2011-04-16.
9222 <menu_help_message, prev_menu_help_message>: Constify.
9223 (IT_menu_make_room): menu->help_text is now `const char **';
9226 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9227 to changes in oldXMenu/XMenu.h from 2011-04-16.
9228 (struct XMenu): Declare `help_text' `const char **'.
9230 * xfaces.c <Qunspecified>: Make extern again.
9232 * syntax.c: Include sys/types.h before including regex.h, as
9235 * doc.c (get_doc_string): Improve the format passed to `error'.
9237 * doprnt.c (doprnt): Improve commentary.
9239 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9241 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9244 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9245 changes in globals.h immediately force recompilation.
9246 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9247 $(CURDIR)/s/ms-w32.h.
9248 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9250 * character.c (Fchar_direction): Function deleted.
9251 (syms_of_character): Don't defsubr it.
9252 <char-direction-table>: Deleted.
9254 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9256 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9257 * doprnt.c: Include limits.h.
9258 (SIZE_MAX): New macro.
9259 (doprnt): Return a size_t value. 2nd arg is now size_t.
9260 Many local variables are now size_t instead of int or unsigned.
9261 Improve overflow protection. Support `l' modifier for integer
9262 conversions. Support %l conversion. Don't assume an EMACS_INT
9263 argument for integer conversions and for %c.
9265 * lisp.h (doprnt): Restore prototype.
9267 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9270 * Makefile.in (base_obj): Add back doprnt.o.
9272 * deps.mk (doprnt.o): Add back prerequisites.
9273 (callint.o): Depend on character.h.
9275 * eval.c (internal_lisp_condition_case): Include the handler
9276 representation in the error message.
9277 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9278 when breaking from the loop.
9280 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9282 * callint.c (Fcall_interactively): When displaying error message
9283 about invalid control letter, pass the character's codepoint, not
9284 a pointer to its multibyte form. Improve display of the character
9285 in octal and display also its hex code.
9287 * character.c (char_string): Use %x to display the (unsigned)
9288 codepoint of an invalid character, to avoid displaying a bogus
9291 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9292 `error', not SYMBOL_NAME itself.
9294 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9295 character arguments to `error'.
9297 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9298 to `error' in error message about FINAL_CHAR argument. Make sure
9299 FINAL_CHAR is a character, and use %c when it is passed as
9300 argument to `error'.
9302 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9304 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9306 * w32.c: Include <time.h>.
9307 (sys_localtime): New function.
9309 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9311 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9313 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9315 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9317 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9320 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9322 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9323 gl_state.e_property when gl_state.object is Qt.
9325 * insdel.c (make_gap_larger): Remove limitation of buffer size
9328 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9330 * xdisp.c (lookup_glyphless_char_display)
9331 (produce_glyphless_glyph): Handle cons cell entry in
9332 glyphless-char-display.
9333 (Vglyphless_char_display): Document it.
9335 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9336 glyphless-char-display.
9338 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9340 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9342 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9344 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9345 definition for no-X builds.
9347 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9349 Static checks with GCC 4.6.0 and non-default toolkits.
9351 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9353 * process.c (keyboard_bit_set): Define only if SIGIO.
9354 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9355 (send_process): Repair possible setjmp clobbering.
9357 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9359 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9361 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9363 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9364 Define only if needed.
9366 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9367 by pacifying GCC about it. Maybe it's time to retire it?
9368 * xfaces.c (USG, __TIMEVAL__): Likewise.
9370 * dispextern.h (struct redisplay_interface): Rename param
9372 * termhooks.h (struct terminal): Likewise.
9373 * xterm.c (xembed_send_message): Likewise.
9375 * insdel.c (make_gap_smaller): Define only if
9376 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9378 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9381 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9382 so that we aren't warned about unused symbols.
9384 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9386 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9388 * xfns.c (x_real_positions): Mark locals as initialized.
9390 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9392 * xterm.c: Fix problems found by static analysis with other toolkits.
9393 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9394 (x_dispatch_event): Declare static if USE_GTK, and
9395 define if USE_GTK || USE_X_TOOLKIT.
9396 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9397 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9398 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9399 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9401 * xmenu.c (menu_help_callback): Pointer type fixes.
9402 Use const pointers when pointing at readonly data. Avoid pointer
9404 (FALSE): Remove unused macro.
9405 (update_frame_menubar): Remove unused decl.
9407 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9409 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9410 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9411 (single_menu_item): Rename local to avoid shadowing.
9413 * keyboard.c (make_lispy_event): Remove unused local var.
9415 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9416 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9418 * bitmaps: Change bitmaps from unsigned char back to the X11
9419 compatible char. Avoid the old compiler warnings about
9420 out-of-range initializers by using, for example, '\xab' rather
9423 * xgselect.c (xgselect_initialize): Check vs interface
9424 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9426 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9428 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9429 to read-only memory.
9431 * fns.c (vector): Remove; this old hack is no longer needed.
9433 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9435 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9437 * xrdb.c (x_load_resources): Omit unused local.
9439 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9440 (x_window): Rename locals to avoid shadowing.
9441 (USG): Use the kludged USG macro, to pacify gcc.
9443 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9444 (x_term_init): Remove local to avoid shadowing.
9446 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9448 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9449 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9451 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9453 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9455 Fix regex.c, syntax.c and friends for buffers > 2GB.
9456 * syntax.h (struct gl_state_s): Declare character position members
9459 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9461 * textprop.c (verify_interval_modification, interval_of):
9462 Declare arguments EMACS_INT.
9464 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9467 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9469 * indent.c (Fvertical_motion): Local variable it_start is now
9472 * regex.c (re_match, re_match_2, re_match_2_internal)
9473 (bcmp_translate, regcomp, regexec, print_double_string)
9474 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9475 (re_compile_pattern, re_exec): Declare arguments and local
9476 variables `size_t' and `ssize_t' and return values `regoff_t', as
9478 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9479 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9480 <compile_stack_type>: `size' and `avail' are now `size_t'.
9482 * regex.h <regoff_t>: Use ssize_t, not int.
9483 (re_search, re_search_2, re_match, re_match_2): Arguments that
9484 specify buffer/string position and length are now ssize_t and
9485 size_t. Return type is regoff_t.
9487 2011-04-16 Ben Key <bkey76@gmail.com>
9489 * nsfont.m: Fixed bugs in ns_get_family and
9490 ns_descriptor_to_entity that were caused by using free to
9491 deallocate memory blocks that were allocated by xmalloc (via
9492 xstrdup). This caused Emacs to crash when compiled with
9493 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9494 --enable-checking=xmallocoverrun). xfree is now used to
9495 deallocate these memory blocks.
9497 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9499 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9501 emacs_write: Accept and return EMACS_INT for sizes.
9502 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9504 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9505 Accept and return EMACS_INT.
9506 (emacs_gnutls_write): Return the number of bytes written on
9508 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9509 (emacs_read, emacs_write): Remove check for negative size, as the
9510 Emacs source code has been audited now.
9511 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9512 (emacs_read, emacs_write): Use it.
9513 * process.c (send_process): Adjust to the new signatures of
9514 emacs_write and emacs_gnutls_write. Do not attempt to store
9515 a byte offset into an 'int'; it might overflow.
9516 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9518 * sound.c: Don't assume sizes fit in 'int'.
9519 (struct sound_device.period_size, alsa_period_size):
9520 Return EMACS_INT, not int.
9521 (struct sound_device.write, vox_write, alsa_write):
9522 Accept EMACS_INT, not int.
9523 (wav_play, au_play): Use EMACS_INT to store sizes and to
9524 record read return values.
9526 2011-04-15 Ben Key <bkey76@gmail.com>
9528 * keyboard.c (Qundefined): Don't declare static since it is used
9530 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9531 static since they are used in nsfont.m.
9533 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9535 * process.c (Qprocessp): Don't declare static.
9536 * lisp.h (Qprocessp): Declare again.
9538 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9540 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9542 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9544 Improve C-level modularity by making more things 'static'.
9546 Don't publish debugger-only interfaces to other modules.
9547 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9548 (verify_bytepos, count_markers): Move decls to the only modules
9550 * region-cache.h (pp_cache): Likewise.
9551 * window.h (check_all_windows): Likewise.
9552 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9554 * sysdep.c (croak): Now static, if
9555 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9556 * syssignal.h (croak): Declare only if not static.
9558 * alloc.c (refill_memory_reserve): Now static if
9559 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9560 * lisp.h (refill_memory_reserve): Declare only if not static.
9562 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9563 Define only if USE_LUCID.
9565 * xrdb.c (x_customization_string, x_rm_string): Now static.
9567 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9568 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9570 * xdisp.c (draw_row_with_mouse_face): Now static.
9571 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9573 * window.h (check_all_windows): Mark externally visible.
9575 * window.c (window_deletion_count): Now static.
9577 * undo.c: Make symbols static if they're not exported.
9578 (last_undo_buffer, last_boundary_position, pending_boundary):
9581 * textprop.c (interval_insert_behind_hooks): Now static.
9582 (interval_insert_in_front_hooks): Likewise.
9584 * term.c: Make symbols static if they're not exported.
9585 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9586 (max_frame_lines, tty_set_terminal_modes):
9587 (tty_reset_terminal_modes, tty_turn_off_highlight):
9588 (get_tty_terminal): Now static.
9589 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9590 * termhooks.h (term_mouse_moveto): Do not declare if
9592 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9593 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9595 * sysdep.c: Make symbols static if they're not exported.
9596 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9598 (sigprocmask_set, full_mask): Remove; unused.
9599 (wait_debugging): Mark as visible.
9600 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9601 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9603 * syntax.c (syntax_temp): Define only if !__GNUC__.
9605 * sound.c (current_sound_device, current_sound): Now static.
9607 * search.c (searchbufs, searchbuf_head): Now static.
9609 * scroll.c (scroll_cost): Remove; unused.
9610 * dispextern.h (scroll_cost): Remove decl.
9612 * region-cache.h (pp_cache): Mark as externally visible.
9614 * process.c: Make symbols static if they're not exported.
9615 (process_tick, update_tick, create_process, chan_process):
9616 (Vprocess_alist, proc_buffered_char, datagram_access):
9617 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9618 (deactivate_process): Mark defn as static, as well as decl.
9619 * lisp.h (create_process): Remove decl.
9620 * process.h (chan_process, Vprocess_alist): Remove decls.
9622 * print.c: Make symbols static if they're not exported.
9623 (print_depth, new_backquote_output, being_printed, print_buffer):
9624 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9625 (print_interval, print_number_index, initial_stderr_stream):
9627 * lisp.h (Fprinc): Remove decl.
9628 (debug_output_compilation_hack): Mark as externally visible.
9630 * sysdep.c (croak): Move decl from here to syssignal.h.
9631 * syssignal.h (croak): Put it here, so the API can be checked when
9632 'croak' is called from dissociate_if_controlling_tty.
9634 * minibuf.c: Make symbols static if they're not exported.
9635 (minibuf_save_list, choose_minibuf_frame): Now static.
9636 * lisp.h (choose_minibuf_frame): Remove decl.
9638 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9640 * lread.c: Make symbols static if they're not exported.
9641 (read_objects, initial_obarray, oblookup_last_bucket_number):
9643 (make_symbol): Remove; unused.
9644 * lisp.h (initial_obarray, make_symbol): Remove decls.
9646 * keyboard.c: Make symbols static if they're not exported.
9647 (single_kboard, recent_keys_index, total_keys, recent_keys):
9648 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9649 (this_single_command_key_start, echoing, last_auto_save):
9650 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9651 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9652 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9653 (Vlispy_mouse_stem, double_click_count):
9655 (force_auto_save_soon): Define only if SIGDANGER.
9656 (ignore_mouse_drag_p): Now static if
9657 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9658 (print_help): Remove; unused.
9659 (stop_character, last_timer_event): Mark as externally visible.
9660 * keyboard.h (ignore_mouse_drag_p): Declare only if
9661 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9662 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9663 * lisp.h (echoing): Remove decl.
9664 (force_auto_save_soon): Declare only if SIGDANGER.
9665 * xdisp.c (redisplay_window): Simplify code, to make it more
9666 obvious that ignore_mouse_drag_p is not accessed if !defined
9667 USE_GTK && !defined HAVE_NS.
9669 * intervals.c: Make symbols static if they're not exported.
9670 (merge_properties_sticky, merge_interval_right, delete_interval):
9672 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9674 * insdel.c: Make symbols static if they're not exported.
9675 However, leave prepare_to_modify_buffer alone. It's never
9676 called from outside this function, but that appears to be a bug.
9677 (combine_after_change_list, combine_after_change_buffer):
9678 (adjust_after_replace, signal_before_change): Now static.
9679 (adjust_after_replace_noundo): Remove; unused.
9680 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9681 (signal_before_change): Remove decls.
9683 * indent.c (val_compute_motion, val_vmotion): Now static.
9685 * image.c: Make symbols static if they're not exported.
9686 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9688 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9689 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9691 * fringe.c (standard_bitmaps): Now static.
9692 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9694 * frame.c: Make symbols static if they're not exported.
9695 (x_report_frame_params, make_terminal_frame): Now static.
9696 (get_frame_param): Now static, unless HAVE_NS.
9697 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9698 (x_get_resource_string): Remove; not used.
9699 * frame.h (make_terminal_frame, x_report_frame_params):
9700 (x_get_resource_string); Remove decls.
9701 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9702 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9704 * font.c, fontset.c: Make symbols static if they're not exported.
9705 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9706 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9707 * font.c (font_close_object): Now static.
9708 * font.h (font_close_object): Remove.
9709 * fontset.c (FONTSET_OBJLIST): Remove.
9710 (free_realized_fontset) #if-0 the body, which does nothing.
9711 (face_suitable_for_char_p): #if-0, as it's never called.
9712 * fontset.h (face_suitable_for_char_p): Remove decl.
9713 * xfaces.c (face_at_string_position):
9714 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9715 since 0 is always ASCII.
9717 * fns.c (weak_hash_tables): Now static.
9719 * fileio.c: Make symbols static if they're not exported.
9720 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9721 (Vwrite_region_annotation_buffers): Now static.
9723 * eval.c: Make symbols static if they're not exported.
9724 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9725 * lisp.h (backtrace_list): Remove decl.
9727 * emacs.c: Make symbols static if they're not exported.
9728 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9729 (fatal_error_code, fatal_error_signal_hook, standard_args):
9731 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9732 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9733 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9734 * lisp.h (fatal_error_signal_hook): Remove decl.
9735 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9737 * editfns.c: Move a (normally-unused) function to its only use.
9738 * editfns.c, lisp.h (get_operating_system_release): Remove.
9739 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9740 worth the hassle of breaking this out.
9742 * xterm.c: Make symbols static if they're not exported.
9743 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9744 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9745 (x_destroy_window, x_delete_display):
9747 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9748 (x_mouse_leave): Remove; unused.
9749 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9750 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9751 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9753 (x_mouse_leave): Declare only if WINDOWSNT.
9754 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9755 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9758 * ftxfont.c: Make symbols static if they're not exported.
9759 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9761 * font.h (ftxfont_driver): Likewise.
9763 * xfns.c: Make symbols static if they're not exported.
9764 (x_last_font_name, x_display_info_for_name):
9765 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9766 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9767 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9768 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9769 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9770 (last_show_tip_args): Now static.
9771 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9772 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9773 (x_screen_planes): Remove; unused.
9774 * dispextern.h (x_screen_planes): Remove decl.
9776 * dispnew.c: Make symbols static if they're not exported.
9777 * dispextern.h (redraw_garbaged_frames, scrolling):
9778 (increment_row_positions): Remove.
9779 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9780 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9782 (redraw_garbaged_frames): Remove; unused.
9784 * xfaces.c: Make symbols static if they're not exported.
9785 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9787 * xterm.h (defined_color): Remove decls.
9788 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9789 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9790 (menu_face_changed_default, defined_color, free_realized_face):
9791 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9792 (ascii_face_of_lisp_face): Remove; unused.
9794 * xdisp.c: Make symbols static if they're not exported.
9795 * dispextern.h (scratch_glyph_row, window_box_edges):
9796 (glyph_to_pixel_coords, set_cursor_from_row):
9797 (get_next_display_element, set_iterator_to_next):
9798 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9799 (show_mouse_face): Remove decls
9800 * frame.h (message_buf_print): Likewise.
9801 * lisp.h (pop_message, set_message, check_point_in_composition):
9803 * xterm.h (set_vertical_scroll_bar): Likewise.
9804 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9805 (message_buf_print, scratch_glyph_row, displayed_buffer):
9806 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9807 (get_next_display_element, show_mouse_face, window_box_edges):
9808 (frame_to_window_pixel_xy, check_point_in_composition):
9809 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9810 (glyph_to_pixel_coords): Remove; unused.
9812 * dired.c (file_name_completion): Now static.
9814 * dbusbind.c (xd_in_read_queued_messages): Now static.
9816 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9817 * data.c (circular_list_error): Remove.
9819 * commands.h (last_point_position, last_point_position_buffer):
9820 (last_point_position_window): Remove decls.
9821 * keyboard.c: Make these variables static.
9823 * coding.h (coding, code_convert_region, encode_coding_gap):
9825 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9826 (iso_code_class, detect_coding, code_convert_region): Now static.
9827 (encode_coding_gap): Remove; unused.
9829 * chartab.c (chartab_chars, chartab_bits): Now static.
9831 * charset.h (charset_iso_8859_1): Remove decl.
9832 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9835 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9836 * ccl.c (Vccl_program_table): Now static.
9837 (check_ccl_update): Remove; unused.
9839 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9840 * category.h: ... from here.
9841 * category.c (check_category_table, set_category_set): Now static.
9843 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9844 * lisp.h: Remove these decls.
9846 * buffer.c (buffer_count): Remove unused var.
9848 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9849 so that it's not optimized away.
9850 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9851 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9852 exported only to the debugger.
9854 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9855 * atimer.h (run_all_atimers): Remove; not exported.
9857 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9858 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9859 was inaccessible from Lisp.
9860 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9861 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9863 alloc.c: Import and export fewer symbols, and remove unused items.
9864 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9866 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9867 it's not optimized away by whole-program optimization.
9868 (message_enable_multibyte, free_misc): Remove.
9869 (catchlist, handlerlist, mark_backtrace):
9870 Declare only if BYTE_MARK_STACK.
9871 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9872 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9873 (message_enable_multibyte): Remove decl.
9874 (free_misc, interval_free_list, float_block, float_block_index):
9875 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9876 (cons_free_list, last_marked_index):
9878 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9879 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9880 (mark_backtrace): Define only if BYTE_MARK_STACK.
9881 * xdisp.c (message_enable_multibyte): Now static.
9883 Declare Lisp_Object Q* variables to be 'static' if not exported.
9884 This makes it easier for human readers (and static analyzers)
9885 to see whether these variables are used from other modules.
9886 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9887 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9888 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9889 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9890 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9891 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9892 * xmenu.c, xselect.c:
9893 Declare Q* vars static if they are not used in other modules.
9894 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9895 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9896 Remove decls of unexported vars.
9897 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9899 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9901 Make Emacs functions such as Fatom 'static' by default.
9902 This makes it easier for human readers (and static analyzers)
9903 to see whether these functions can be called from other modules.
9904 DEFUN now defines a static function. To make the function external
9905 so that it can be used in other C modules, use the new macro DEFUE.
9906 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9907 (Finit_image_library):
9908 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9909 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9910 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9911 Remove decls, since these functions are now static.
9912 (Funintern, Fget_internal_run_time): New decls, since these functions
9913 were already external.
9915 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9916 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9917 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9918 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9919 * keyboard.c, keymap.c, lread.c:
9920 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9921 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9922 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9923 Mark functions with DEFUE instead of DEFUN,
9924 if they are used in other modules.
9925 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9926 decls for now-static functions.
9927 * buffer.h (Fdelete_overlay): Remove decl.
9928 * callproc.c (Fgetenv_internal): Mark as internal.
9929 * composite.c (Fremove_list_of_text_properties): Remove decl.
9930 (Fcomposition_get_gstring): New forward static decl.
9931 * composite.h (Fcomposite_get_gstring): Remove decl.
9932 * dired.c (Ffile_attributes): New forward static decl.
9933 * doc.c (Fdocumntation_property): New forward static decl.
9934 * eval.c (Ffetch_bytecode): New forward static decl.
9935 (Funintern): Remove extern decl; now in .h file where it belongs.
9936 * fileio.c (Fmake_symbolic_link): New forward static decl.
9937 * image.c (Finit_image_library): New forward static decl.
9938 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9939 * intervals.h (Fprevious_property_change):
9940 (Fremove_list_of_text_properties): Remove decls.
9941 * keyboard.c (Fthis_command_keys): Remove decl.
9942 (Fcommand_execute): New forward static decl.
9943 * keymap.c (Flookup_key): New forward static decl.
9944 (Fcopy_keymap): Now static.
9945 * keymap.h (Flookup_key): Remove decl.
9946 * process.c (Fget_process): New forward static decl.
9947 (Fprocess_datagram_address): Mark as internal.
9948 * syntax.c (Fsyntax_table_p): New forward static decl.
9949 (skip_chars): Remove duplicate decl.
9950 * textprop.c (Fprevious_property_change): New forward static decl.
9951 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9953 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9954 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9956 * editfns.c (Fformat): Remove unreachable code.
9958 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9960 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9963 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9965 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9966 when at ZV. (Bug#8487)
9968 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9970 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9972 * keyboard.c (parse_tool_bar_item): Likewise.
9973 * sound.c (sound_cleanup, alsa_close): Likewise.
9974 * termcap.c (tgetent): Likewise.
9975 * xfns.c (x_default_font_parameter): Likewise.
9976 * xsettings.c (read_and_apply_settings): Likewise.
9978 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9979 (overrun_check_free): Protoize.
9981 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9983 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9984 since callers should never pass a negative size.
9985 Change the signature to match that of plain 'read' and 'write'; see
9986 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9987 * lisp.h: Update prototypes of emacs_write and emacs_read.
9989 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9991 * xdisp.c (redisplay_window): Don't try to determine the character
9992 position of the scroll margin if the window start point w->startp
9993 is outside the buffer's accessible region. (Bug#8468)
9995 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9997 Fix write-region and its subroutines for buffers > 2GB.
9998 * fileio.c (a_write, e_write): Modify declaration of arguments and
9999 local variables to support buffers larger than 2GB.
10000 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10002 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10003 argument, local variables, and return value.
10005 * lisp.h: Update prototypes of emacs_write and emacs_read.
10007 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10009 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10011 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10013 Fix more problems found by GCC 4.6.0's static checks.
10015 * xdisp.c (vmessage): Use a better test for character truncation.
10017 * charset.c (load_charset_map): <, not <=, for optimization,
10018 and to avoid potential problems with integer overflow.
10019 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10020 * casetab.c (set_identity, shuffle): Likewise.
10021 * editfns.c (Fformat): Likewise.
10022 * syntax.c (skip_chars): Likewise.
10024 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10025 This also lets GCC 4.6.0 generate slightly better loop code.
10027 * callint.c (Fcall_interactively): <, not <=, for optimization.
10028 (Fcall_interactively): Count the number of arguments produced,
10029 not the number of arguments given. This is simpler and lets GCC
10030 4.6.0 generate slightly better code.
10032 * ftfont.c: Distingish more carefully between FcChar8 and char.
10033 The previous code passed unsigned char * to a functions like
10034 strlen and xstrcasecmp that expect char *, which does not
10035 conform to the C standard.
10036 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10037 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10038 char * when the C standard requires it.
10040 * keyboard.c (read_char): Remove unused var.
10042 * eval.c: Port to Windows vsnprintf (Bug#8435).
10043 Include <limits.h>.
10044 (SIZE_MAX): Define if the headers do not.
10045 (verror): Do not give up if vsnprintf returns a negative count.
10046 Instead, grow the buffer. This ports to Windows vsnprintf, which
10047 does not conform to C99. Problem reported by Eli Zaretskii.
10048 Also, simplify the allocation scheme, by avoiding the need for
10049 calling realloc, and removing the ALLOCATED variable.
10051 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10053 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10054 But keep the doprint source code for now, as we might revamp it
10055 and use it again (Bug#8435).
10056 * lisp.h (doprnt): Remove.
10057 * Makefile.in (base_obj): Remove doprnt.o.
10058 * deps.mk (doprnt.o): Remove.
10060 error: Print 32- and 64-bit integers portably (Bug#8435).
10061 Without this change, on typical 64-bit hosts error ("...%d...", N)
10062 was used to print both 32- and 64-bit integers N, which relied on
10063 undefined behavior.
10064 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10065 * lisp.h (error, verror): Mark as printf-like functions.
10066 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10067 Report overflow in size calculations when allocating printf buffer.
10068 Do not truncate output string at its first null byte.
10069 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10070 Truncate the output at a character boundary, since vsnprintf does not
10072 * charset.c (check_iso_charset_parameter): Convert internal
10073 character to string before calling 'error', since %c now has the
10075 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10076 overflow when computing char to be passed to 'error'. Do not
10077 pass Lisp_Object to 'error'; pass the integer instead.
10078 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10079 formatted with plain %d.
10081 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10083 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10085 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10087 * xterm.c (x_catch_errors): Remove duplicate declaration.
10089 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10091 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10093 2011-04-10 Jim Meyering <meyering@redhat.com>
10095 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10096 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10097 return ssize_t not "int", and use size_t as the buffer length.
10098 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10099 * gnutls.h: Update declarations.
10100 * process.c (read_process_output): Use ssize_t, to match.
10101 (send_process): Likewise.
10103 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10105 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10107 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10109 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10110 Use unsigned char, to match FcChar8 type definition.
10112 * xterm.c (handle_one_xevent):
10113 * xmenu.c (create_and_show_popup_menu):
10114 * xselect.c (x_decline_selection_request)
10115 (x_reply_selection_request): Avoid type-punned deref of X events.
10117 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10119 Fix some uses of `int' instead of EMACS_INT.
10120 * search.c (string_match_1, fast_string_match)
10121 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10122 (scan_buffer, find_next_newline_no_quit)
10123 (find_before_next_newline, search_command, Freplace_match)
10124 (Fmatch_data): Make some `int' variables be EMACS_INT.
10126 * xdisp.c (display_count_lines): 3rd argument and return value now
10127 EMACS_INT. All callers changed.
10128 (pint2hrstr): Last argument is now EMACS_INT.
10130 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10131 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10132 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10133 (decode_coding_utf_16, decode_coding_emacs_mule)
10134 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10135 (decode_coding_ccl, decode_coding_charset)
10136 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10137 (decode_coding_iso_2022, decode_coding_emacs_mule)
10138 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10139 <char_offset, last_offset>: Declare EMACS_INT.
10140 (encode_coding_utf_8, encode_coding_utf_16)
10141 (encode_coding_emacs_mule, encode_invocation_designation)
10142 (encode_designation_at_bol, encode_coding_iso_2022)
10143 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10144 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10146 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10147 (encode_invocation_designation): Last argument P_NCHARS is now
10149 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10150 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10152 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10155 * ccl.c (Fccl_execute_on_string): Declare some variables
10158 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10160 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10162 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10164 * process.c (Fformat_network_address): Doc fix.
10166 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10168 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10170 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10172 * keyboard.c (read_char): Call Lisp function help-form-show,
10173 instead of using internal_with_output_to_temp_buffer.
10174 (Qhelp_form_show): New var.
10175 (syms_of_keyboard): Use DEFSYM macro.
10177 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10179 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10181 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10183 * process.c (Flist_processes): Remove to Lisp.
10184 (list_processes_1): Delete.
10186 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10188 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10190 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10192 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10194 Fix more problems found by GCC 4.6.0's static checks.
10196 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10198 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10200 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10202 * xdisp.c (vmessage): Mark as a printf-like function.
10204 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10206 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10208 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10209 printf-like functions.
10210 (tiff_load): Add casts to remove these marks before passing them
10211 to system-supplied API.
10213 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10215 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10216 This avoids several warnings with gcc -Wstrict-overflow.
10217 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10218 directly, rather than having caller test rule sign. This avoids
10219 some unnecessary tests.
10220 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10221 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10222 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10224 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10225 (xfont_open): Avoid unnecessary tests.
10227 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10229 * composite.h, composite.c (composition_gstring_put_cache):
10230 Use EMACS_INT, not int, for length.
10232 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10233 breaking out part of COMPOSITION_DECODE_RULE.
10234 (COMPOSITION_DECODE_RULE): Use it.
10235 * composite.c (get_composition_id): Remove unused local vars,
10236 by using the new macro.
10238 * textprop.c (set_text_properties_1): Change while to do-while,
10239 since the condition is always true at first.
10241 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10242 (interval_deletion_adjustment): Return unsigned value.
10245 * process.c (list_processes_1, create_pty, read_process_output):
10246 (exec_sentinel): Remove vars that were set but not used.
10247 (create_pty): Remove unnecessary "volatile"s.
10248 (Fnetwork_interface_info): Avoid possibility of int overflow.
10249 (read_process_output): Do adaptive read buffering even if carryover.
10250 (read_process_output): Simplify nbytes computation if buffered.
10252 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10254 * syntax.c (scan_words): Remove var that was set but not used.
10255 (update_syntax_table): Use unsigned instead of int.
10257 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10258 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10259 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10261 * print.c (print_error_message): Avoid int overflow.
10263 * font.c (font_list_entities): Redo for clarity,
10264 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10266 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10267 (font_score): Avoid potential overflow in diff calculation.
10269 * fns.c (substring_both): Remove var that is set but not used.
10270 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10272 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10274 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10275 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10276 can always succeed if overflow has undefined behavior.
10278 * search.c (boyer_moore, wordify): Remove vars set but not used.
10279 (wordify): Omit three unnecessary tests.
10281 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10282 All callers changed. This avoids the need for an unused var.
10284 * casefiddle.c (casify_region): Remove var that is set but not used.
10286 * dired.c (file_name_completion): Remove var that is set but not used.
10288 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10290 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10291 (Finsert_file_contents): Remove unnecessary code checking fd.
10293 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10294 Check for integer overflow on size calculations.
10296 * buffer.c (Fprevious_overlay_change): Remove var that is set
10299 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10300 Remove vars that are set but not used.
10301 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10302 (timer_check_2): Mark vars as initialized.
10304 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10306 * image.c (lookup_image): Remove var that is set but not used.
10307 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10309 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10310 that are set but not used.
10312 * xfns.c (make_invisible_cursor): Don't return garbage
10313 if XCreateBitmapFromData fails (Bug#8410).
10315 * xselect.c (x_get_local_selection, x_handle_property_notify):
10316 Remove vars that are set but not used.
10318 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10319 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10321 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10322 Remove var that is set but not used.
10323 (scroll_bar_windows_size): Now size_t, not int.
10324 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10325 Check for overflow.
10327 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10328 (map_tty_color) [!defined MSDOS]: Likewise.
10330 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10332 * coding.c: Remove vars that are set but not used.
10333 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10334 All callers changed.
10335 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10336 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10337 (decode_coding_charset): Remove vars that are set but not used.
10339 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10340 that is set but not used.
10342 * print.c (print_object): Remove var that is set but not used.
10344 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10345 The gnulib version avoids calling malloc in the usual case,
10346 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10347 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10348 * filelock.c (current_lock_owner): Likewise.
10349 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10350 * sysdep.c: Include allocator.h, careadlinkat.h.
10351 (emacs_no_realloc_allocator): New static constant.
10352 (emacs_readlink): New function.
10353 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10354 ../lib/careadlinkat.h.
10356 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10358 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10359 first non-nil return value).
10361 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10363 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10364 if not defined (Bug#8403).
10366 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10368 * xdisp.c (display_count_lines): Remove parameter `start',
10369 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10370 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10371 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10372 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10373 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10374 and thereabouts. All callers changed.
10375 (get_per_char_metric): Remove parameter `f', unused since
10376 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10378 2011-04-02 Jim Meyering <meyering@redhat.com>
10380 do not dereference NULL upon failed strdup
10381 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10382 (ns_get_family): Likewise.
10384 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10386 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10388 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10390 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10393 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10395 Add lexical binding.
10397 * window.c (Ftemp_output_buffer_show): New fun.
10398 (Fsave_window_excursion):
10399 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10401 * lread.c (lisp_file_lexically_bound_p): New function.
10402 (Fload): Bind Qlexical_binding.
10403 (readevalloop): Remove `evalfun' arg.
10404 Bind Qinternal_interpreter_environment.
10405 (Feval_buffer): Bind Qlexical_binding.
10406 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10408 (syms_of_lread): Declare `lexical-binding'.
10410 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10412 * keyboard.c (eval_dyn): New fun.
10413 (menu_item_eval_property): Use it.
10415 * image.c (parse_image_spec): Use Ffunctionp.
10417 * fns.c (concat, mapcar1): Accept byte-code-functions.
10419 * eval.c (Fsetq): Handle lexical vars.
10420 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10421 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10422 (FletX, Flet): Obey lexical binding.
10423 (Fcommandp): Handle closures.
10424 (Feval): New `lexical' arg.
10425 (eval_sub): New function extracted from Feval. Use it almost
10426 everywhere where Feval was used. Look up vars in lexical env.
10428 (Ffunctionp): Move from subr.el.
10429 (Ffuncall): Handle closures.
10430 (apply_lambda): Remove `eval_flags'.
10431 (funcall_lambda): Handle closures and new byte-code-functions.
10432 (Fspecial_variable_p): New function.
10433 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10434 but without exporting it to Lisp.
10436 * doc.c (Fdocumentation, store_function_docstring):
10437 * data.c (Finteractive_form): Handle closures.
10439 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10442 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10444 (exec_byte_code): New function extracted from Fbyte_code to handle new
10445 calling convention for byte-code-functions. Add new byte-codes.
10447 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10449 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10451 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10453 * xdisp.c (redisplay_internal): Fix prototype.
10455 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10457 * xdisp.c (SCROLL_LIMIT): New macro.
10458 (try_scrolling): Use it when setting scroll_limit.
10459 Limit scrolling to 100 screen lines.
10460 (redisplay_window): Even when falling back on "recentering",
10461 position point in the window according to scroll-conservatively,
10462 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10464 (try_scrolling): When point is above the window, allow searching
10465 as far as scroll_max, or one screenful, to compute vertical
10466 distance from PT to the scroll margin position. This prevents
10467 try_scrolling from unnecessarily failing when
10468 scroll-conservatively is set to a value slightly larger than the
10469 window height. Clean up the case of PT below the margin at bottom
10470 of window: scroll_max can no longer be INT_MAX. When aggressive
10471 scrolling is in use, don't let point enter the opposite scroll
10472 margin as result of the scroll.
10473 (syms_of_xdisp) <scroll-conservatively>: Document the
10474 threshold of 100 lines for never-recentering scrolling.
10476 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10478 * dispextern.h (move_it_by_lines):
10479 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10480 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10481 (message_log_check_duplicate): Remove parameters `prev_bol' and
10482 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10483 (redisplay_internal): Remove parameter `preserve_echo_area',
10484 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10486 * indent.c (Fvertical_motion):
10487 * window.c (window_scroll_pixel_based, Frecenter):
10488 Don't pass `need_y_p' to `move_it_by_lines'.
10490 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10492 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10493 steal a few bits to be more compact.
10494 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10495 Remove unneeded casts.
10497 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10499 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10501 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10502 binding" message (bug#7967).
10504 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10506 Fix more problems found by GCC 4.6.0's static checks.
10508 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10509 Remove unused local var.
10511 * editfns.c (Fmessage_box): Remove unused local var.
10513 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10514 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10515 Omit unused local vars.
10516 * window.c (shrink_windows): Omit unused local var.
10517 * menu.c (digest_single_submenu): Omit unused local var.
10518 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10519 Omit unused local var.
10521 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10522 Don't assume string length fits in int.
10523 (keyremap_step, read_key_sequence): Use size_t for sizes.
10524 (read_key_sequence): Don't check last_real_key_start redundantly.
10526 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10527 instead of alloca (Bug#8344).
10529 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10530 (Fbacktrace_frame): Don't assume nframes fits in int.
10532 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10534 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10537 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10539 * cm.c (calccost): Turn while-do into do-while, for clarity.
10541 * keyboard.c (syms_of_keyboard): Use the same style as later
10542 in this function when indexing through an array. This also
10543 works around GCC bug 48267.
10545 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10547 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10549 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10550 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10552 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10553 This avoids undefined behavior on integer overflow, and is a bit
10554 more convenient anyway since it is compared to a size_t variable.
10556 Variadic C functions now count arguments with size_t, not int.
10557 This avoids an unnecessary limitation on 64-bit machines, which
10558 caused (substring ...) to crash on large vectors (Bug#8344).
10559 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10560 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10561 All variadic functions and their callers changed accordingly.
10562 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10563 * data.c (arith_driver, float_arith_driver): Likewise.
10564 * editfns.c (general_insert_function): Likewise.
10565 * eval.c (struct backtrace.nargs, interactive_p)
10566 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10567 (funcall_lambda, mark_backtrace): Likewise.
10568 * fns.c (concat): Likewise.
10569 * frame.c (x_set_frame_parameters): Likewise.
10570 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10571 0 if not found, not -1. All callers changed.
10573 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10574 (stack_copy_size): Now size_t, not int.
10575 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10577 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10579 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10580 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10581 All callers changed.
10583 * lisp.h (multibyte_char_to_unibyte):
10584 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10585 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10586 * character.h (CHAR_TO_BYTE8):
10587 * cmds.c (internal_self_insert):
10588 * editfns.c (general_insert_function):
10589 * keymap.c (push_key_description):
10590 * search.c (Freplace_match):
10591 * xdisp.c (message_dolog, set_message_1): All callers changed.
10593 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10595 * keyboard.c (safe_run_hook_funcall): New function.
10596 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10597 don't set the hook to nil, but remove the offending function instead.
10598 (Qcommand_hook_internal): Remove, unused.
10599 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10600 Vcommand_hook_internal.
10602 * eval.c (enum run_hooks_condition): Remove.
10603 (funcall_nil, funcall_not): New functions.
10604 (run_hook_with_args): Call each function through a `funcall' argument.
10605 Remove `cond' argument, now redundant.
10606 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10607 (Frun_hook_with_args_until_failure): Adjust accordingly.
10608 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10610 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10612 * dispextern.h (string_buffer_position): Remove declaration.
10614 * print.c (strout): Remove parameter `multibyte', unused since
10615 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10617 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10618 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10619 All callers changed.
10621 * w32.c (_wsa_errlist): Use braces for struct initializers.
10623 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10624 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10625 All callers changed.
10626 (string_buffer_position): Likewise. Also, make static (it's never
10627 used outside xdisp.c).
10628 (cursor_row_p): Remove parameter `w', unused since
10629 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10630 (decode_mode_spec): Remove parameter `precision', introduced during
10631 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10632 All callers changed.
10634 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10636 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10638 2011-03-27 Anders Lindgren <andlind@gmail.com>
10640 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10641 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10642 (ns_update_auto_hide_menu_bar): New functions.
10643 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10644 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10645 ns_constrain_all_frames.
10646 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10647 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10649 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10651 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10653 2011-03-27 Glenn Morris <rgm@gnu.org>
10655 * syssignal.h: Replace RETSIGTYPE with void.
10656 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10657 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10658 Replace SIGTYPE with void everywhere.
10659 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10660 * s/template.h (SIGTYPE): Remove commented out definition.
10662 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10664 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10665 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10667 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10669 * w32.c (read_unc_volume): Use parameter `henum', instead of
10670 global variable `wget_enum_handle'.
10672 * keymap.c (describe_vector): Remove parameters `indices' and
10673 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10674 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10676 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10678 * keyboard.c (timer_check): Remove parameter `do_it_now',
10679 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10680 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10681 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10683 * keyboard.c (read_char):
10684 * w32menu.c (w32_menu_display_help):
10685 * xmenu.c (show_help_event, menu_help_callback):
10686 Adjust calls to `show_help_echo'.
10688 * gtkutil.c (xg_maybe_add_timer):
10689 * keyboard.c (readable_events):
10690 * process.c (wait_reading_process_output):
10691 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10693 * insdel.c (adjust_markers_gap_motion):
10694 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10695 (gap_left, gap_right): Don't call it.
10697 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10699 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10700 incurred during fontification.
10702 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10704 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10705 (DEFVAR_PER_BUFFER): Don't pass it.
10707 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10708 (scrolling_window): Don't pass it.
10710 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10712 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10714 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10716 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10717 of variables specific to SELinux and computation of `encoded_absname'.
10719 * image.c (XPutPixel): Remove unused variable `height'.
10721 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10723 * unexw32.c (get_section_info): Remove unused variable `section'.
10725 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10726 (system_process_attributes): Remove unused variable `sess'.
10727 (sys_read): Remove unused variable `err'.
10729 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10730 (w32_wnd_proc): Remove unused variable `isdead'.
10731 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10732 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10733 (x_create_tip_frame): Remove unused variable `tem'.
10735 * w32inevt.c (w32_console_read_socket):
10736 Remove unused variable `no_events'.
10738 * w32term.c (x_draw_composite_glyph_string_foreground):
10739 Remove unused variable `width'.
10741 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10743 * w32term.c (x_set_glyph_string_clipping):
10744 Don't pass uninitialized region to CombineRgn.
10746 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10748 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10749 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10750 (Fx_close_connection): Remove unused variable `i'.
10752 * w32font.c (w32font_draw): Return number of glyphs.
10753 (w32font_open_internal): Remove unused variable `i'.
10754 (w32font_driver): Add missing initializer.
10756 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10757 (fill_in_menu): Remove unused variable `items_added'.
10759 * w32term.c (last_mouse_press_frame): Remove static global variable.
10760 (w32_clip_to_row): Remove unused variable `f'.
10761 (x_delete_terminal): Remove unused variable `i'.
10763 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10764 (NOTHING): Remove unused static global variable.
10765 (uniscribe_check_otf): Remove unused variable `table'.
10766 (uniscribe_font_driver): Add missing initializers.
10768 2011-03-23 Julien Danjou <julien@danjou.info>
10770 * term.c (Fsuspend_tty, Fresume_tty):
10771 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10772 * window.c (temp_output_buffer_show):
10773 * insdel.c (signal_before_change):
10774 * frame.c (Fhandle_switch_frame):
10775 * fileio.c (Fdo_auto_save):
10776 * emacs.c (Fkill_emacs):
10777 * editfns.c (save_excursion_restore):
10778 * cmds.c (internal_self_insert):
10779 * callint.c (Fcall_interactively):
10780 * buffer.c (Fkill_all_local_variables):
10781 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10783 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10784 unconditionally since it does the check itself.
10786 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10788 Fix more problems found by GCC 4.5.2's static checks.
10790 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10791 the first time through the loop, since we know p0 < p1 then.
10792 This also avoids a gcc -Wstrict-overflow warning.
10794 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10795 leading to a memory leak, possible in functions like
10796 load_charset_map_from_file that can allocate an unbounded number
10797 of objects (Bug#8318).
10799 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10800 that could (at least in theory) be that large.
10802 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10803 This is less likely to overflow, and avoids undefined behavior if
10804 overflow does occur. All callers changed. Use strtoul to scan
10805 for the unsigned long integer.
10806 (pint2hrstr): Simplify and tune code slightly.
10807 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10809 * scroll.c (do_scrolling): Work around GCC bug 48228.
10810 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10812 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10813 This also avoids a warning with gcc -Wstrict-overflow.
10814 (validate_x_resource_name): Simplify count usage.
10815 This also avoids a warning with gcc -Wstrict-overflow.
10817 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10820 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10822 * process.c (Fmake_network_process): Use socklen_t, not int,
10823 where POSIX says socklen_t is required in portable programs.
10824 This fixes a porting bug on hosts like 64-bit HP-UX, where
10825 socklen_t is wider than int (Bug#8277).
10826 (Fmake_network_process, server_accept_connection):
10827 (wait_reading_process_output, read_process_output):
10830 * process.c: Rename or move locals to avoid shadowing.
10831 (list_processes_1, Fmake_network_process):
10832 (read_process_output_error_handler, exec_sentinel_error_handler):
10833 Rename or move locals.
10834 (Fmake_network_process): Define label "retry_connect" only if needed.
10835 (Fnetwork_interface_info): Fix pointer signedness.
10836 (process_send_signal): Add cast to avoid pointer signedness problem.
10837 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10838 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10840 Make tparam.h and terminfo.c consistent.
10841 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10842 Include tparam.h instead, since it declares them.
10843 * cm.h (PC): Remove extern decl; tparam.h now does this.
10844 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10845 * terminfo.c: Include tparam.h, to check interfaces.
10846 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10847 (tparam): Adjust signature to match interface in tparam.h;
10848 this removes some undefined behavior. Check that outstring and len
10849 are zero, which they always are with Emacs.
10850 * tparam.h (PC, BC, UP): New extern decls.
10852 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10853 (xftfont_open): Rename locals to avoid shadowing.
10855 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10856 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10857 (OTF_TAG_SYM): Omit macro if not needed.
10858 (ftfont_list): Remove unused local.
10859 (get_adstyle_property, ftfont_pattern_entity):
10860 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10861 Rename locals to avoid shadowing.
10863 * xfont.c (xfont_list_family): Mark var as initialized.
10865 * xml.c (make_dom): Now static.
10867 * composite.c (composition_compute_stop_pos): Rename local to
10869 (composition_reseat_it): Remove unused locals.
10870 (find_automatic_composition, composition_adjust_point): Likewise.
10871 (composition_update_it): Mark var as initialized.
10872 (find_automatic_composition): Mark vars as initialized,
10873 with a FIXME (Bug#8290).
10875 character.h: Rename locals to avoid shadowing.
10876 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10877 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10878 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10879 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10880 to avoid shadowing.
10882 * textprop.c (property_change_between_p): Remove; unused.
10884 * intervals.c (interval_start_pos): Now static.
10886 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10888 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10889 Rename locals to avoid shadowing.
10891 * sound.c (wav_play, au_play, Fplay_sound_internal):
10892 Fix pointer signedness.
10893 (alsa_choose_format): Remove unused local var.
10894 (wav_play): Initialize a variable to 0, to prevent undefined
10895 behavior (Bug#8278).
10897 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10899 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10901 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10902 clobbering (Bug#8298).
10903 * sysdep.c (sys_subshell): Likewise.
10904 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10906 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10907 This should get cleaned up, so that child_setup has the
10908 same signature on all platforms.
10910 * callproc.c (call_process_cleanup): Now static.
10911 (relocate_fd): Rename locals to avoid shadowing.
10913 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10915 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10916 not to be necessary, and produces flickering.
10918 2011-03-20 Glenn Morris <rgm@gnu.org>
10920 * config.in: Remove file.
10922 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10924 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10925 are now in src/globals.h.
10926 (syms_of_minibuf): Remove spurious & from previous change.
10928 2011-03-20 Leo Liu <sdl.web@gmail.com>
10930 * minibuf.c (completing-read-function): New variable.
10931 (completing-read-default): Rename from completing-read.
10932 (completing-read): Call completing-read-function.
10934 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10936 * xfaces.c (Fx_load_color_file):
10937 Read color file from absolute filename (bug#8250).
10939 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10941 * makefile.w32-in: Update dependencies.
10943 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10945 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10947 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10949 Fix more problems found by GCC 4.5.2's static checks.
10951 * process.c (make_serial_process_unwind, send_process_trap):
10952 (sigchld_handler): Now static.
10954 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10955 That way, the code declares only the vars that it needs.
10956 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10957 * s/cygwin.h (PTY_ITERATION): Likewise.
10958 * s/darwin.h (PTY_ITERATION): Likewise.
10959 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10961 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10962 * process.c (allocate_pty): Don't declare stb unless it's needed.
10964 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10965 (CONSTANTLIM): Remove; unused.
10966 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10967 Define only if needed.
10969 * unexelf.c (unexec): Name an expression,
10970 to avoid gcc -Wbad-function-cast warning.
10971 Use a different way to cause a compilation error if anyone uses
10972 n rather than nn, a way that does not involve shadowing.
10973 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10975 * deps.mk (unexalpha.o): Remove; unused.
10977 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10978 * unexec.h: New file.
10979 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10980 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10981 Depend on unexec.h.
10982 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10983 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10984 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10985 Change as necessary to match prototype in unexec.h.
10987 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10989 (back_comment, skip_chars): Mark vars as initialized.
10991 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10992 Rename locals to avoid shadowing.
10994 * lread.c (read1): Rewrite so as not to use empty "else".
10995 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10997 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10999 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11000 warning when compiling print.c.
11002 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11003 instead of using an uninitialized var.
11004 (font_sort_entities): Mark var as initialized.
11006 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11008 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11009 pointers to constants.
11010 (font_parse_fcname): Remove unused vars.
11011 (font_delete_unmatched): Now static.
11012 (font_get_spec): Remove; unused.
11013 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11014 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11015 Rename or move locals to avoid shadowing.
11017 * fns.c (require_nesting_list, require_unwind): Now static.
11018 (Ffillarray): Rename locals to avoid shadowing.
11020 * floatfns.c (domain_error2): Define only if needed.
11021 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11023 * alloc.c (mark_backtrace): Move decl from here ...
11024 * lisp.h: ... to here, so that it can be checked.
11026 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11027 (Fdefvar): Rewrite so as not to use empty "else".
11028 (lisp_indirect_variable): Name an expression,
11029 to avoid gcc -Wbad-function-cast warning.
11030 (Fdefvar): Rename locals to avoid shadowing.
11032 * callint.c (quotify_arg, quotify_args): Now static.
11033 (Fcall_interactively): Rename locals to avoid shadowing.
11034 Use const pointer when appropriate.
11036 * lisp.h (get_system_name, get_operating_system_release):
11037 Move decls here, to check interfaces.
11038 * process.c (get_operating_system_release): Move decl to lisp.h.
11039 * xrdb.c (get_system_name): Likewise.
11040 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11041 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11042 some of which prompt warnings from gcc -Wbad-function-cast.
11043 (Fformat_time_string, Fencode_time, Finsert_char):
11044 (Ftranslate_region_internal, Fformat):
11045 Rename or remove local vars to avoid shadowing.
11046 (Ftranslate_region_internal): Mark var as initialized.
11048 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11051 * lisp.h (eassert): Check that the argument compiles, even if
11052 ENABLE_CHECKING is not defined.
11054 * data.c (Findirect_variable): Name an expression, to avoid
11055 gcc -Wbad-function-cast warning.
11056 (default_value, arithcompare, arith_driver, arith_error): Now static.
11057 (store_symval_forwarding): Rename local to avoid shadowing.
11058 (Fmake_variable_buffer_local, Fmake_local_variable):
11059 Mark variables as initialized.
11060 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11062 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11063 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11064 Rename locals to avoid shadowing.
11065 (mark_stack): Move local variables into the #ifdef region where
11067 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11068 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11070 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11071 (GC_STRING_CHARS): Remove; not used.
11072 (Fmemory_limit): Cast sbrk's returned value to char *.
11074 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11075 avoids undefined behavior in theory.
11077 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11079 Use functions, not macros, for up- and down-casing (Bug#8254).
11080 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11081 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11082 to use the following functions instead of these macros.
11083 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11084 EMACS_INT, since callers assume the returned value fits in int.
11085 (upcase1): Likewise, for UPCASE_TABLE.
11086 (uppercasep, lowercasep, upcase): New static inline functions.
11087 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11088 the race-condition problem in the old DOWNCASE.
11090 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11091 Rename locals to avoid shadowing.
11092 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11093 (regex_compile, re_search_2, re_match_2_internal):
11094 Remove unused local vars.
11095 (FREE_VAR): Rewrite so as not to use empty "else",
11096 which gcc can warn about.
11097 (regex_compile, re_match_2_internal): Mark locals as initialized.
11098 (RETALLOC_IF): Define only if needed.
11099 (WORDCHAR_P): Likewise. This one is never needed, but is used
11100 only in a comment talking about a compiler bug, so put inside
11101 the #if 0 of that comment.
11102 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11103 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11106 * search.c (boyer_moore): Rename locals to avoid shadowing.
11107 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11108 (PREV_CHAR_BOUNDARY): Likewise.
11110 * search.c (simple_search): Remove unused var.
11112 * dired.c (compile_pattern): Move decl from here ...
11113 * lisp.h: ... to here, so that it can be checked.
11114 (struct re_registers): New forward decl.
11116 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11118 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11120 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11121 Rename locals to avoid shadowing.
11122 (Fvertical_motion): Mark locals as initialized.
11124 * casefiddle.c (casify_object, casify_region): Now static.
11125 (casify_region): Mark local as initialized.
11127 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11129 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11130 New macros, so that the caller can use some names other than
11131 gcpro1, gcpro2, etc.
11132 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11134 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11135 argument, for consistency with GCPRO2_VAR, etc: it is now the
11136 prefix of the variable, not the variable itself. All uses
11138 * dired.c (directory_files_internal, file_name_completion):
11139 Rename locals to avoid shadowing.
11141 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11142 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11143 dired.c's scmp function, had undefined behavior.
11144 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11145 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11146 * buffer.h: ... to here, because these macros use current_buffer,
11147 and the new implementation with inline functions needs to have
11148 current_buffer in scope now, rather than later when the macros
11150 (downcase, upcase1): New static inline functions.
11151 (DOWNCASE, UPCASE1): Reimplement using these functions.
11152 This avoids undefined behavior in expressions like
11153 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11154 from race conditions in accessing the global variables
11155 case_temp1 and case_temp2.
11156 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11157 * lisp.h (case_temp1, case_temp2): Remove their decls.
11158 * character.h (ASCII_CHAR_P): Move from here ...
11159 * lisp.h: ... to here, so that the inline functions mentioned
11160 above can use them.
11162 * dired.c (directory_files_internal_unwind): Now static.
11164 * fileio.c (file_name_as_directory, directory_file_name):
11165 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11167 (file_name_as_directory): Use const pointers when appropriate.
11168 (Fexpand_file_name): Likewise. In particular, newdir might
11169 point at constant storage, so make it a const pointer.
11170 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11171 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11173 (Fset_file_times, Finsert_file_contents, auto_save_error):
11174 Rename locals to avoid shadowing.
11176 * minibuf.c (choose_minibuf_frame_1): Now static.
11177 (Ftry_completion, Fall_completions): Rename or remove locals
11178 to avoid shadowing.
11180 * marker.c (bytepos_to_charpos): Remove; unused.
11182 * lisp.h (verify_bytepos, count_markers): New decls,
11183 so that gcc does not warn that these functions aren't declared.
11185 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11186 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11187 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11188 (copy_text): Remove unused local var.
11190 * filelock.c (within_one_second): Now static.
11191 (lock_file_1): Rename local to avoid shadowing.
11193 * buffer.c (fix_overlays_before): Mark locals as initialized.
11194 (fix_start_end_in_overlays): Likewise. This function should be
11195 simplified by using pointers-to-pointers, but that's a different
11197 (switch_to_buffer_1): Now static.
11198 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11199 (report_overlay_modification): Rename locals to avoid shadowing.
11201 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11202 Fix pointer signedness issue.
11203 (sys_subshell): Mark local as volatile if checking for lint,
11204 to suppress a gcc -Wclobbered warning that does not seem to be right.
11205 (MAXPATHLEN): Define only if needed.
11207 * process.c (serial_open, serial_configure): Move decls from here ...
11208 * systty.h: ... to here, so that they can be checked.
11210 * fns.c (get_random, seed_random): Move extern decls from here ...
11211 * lisp.h: ... to here, so that they can be checked.
11213 * sysdep.c (reset_io): Now static.
11214 (wait_for_termination_signal): Remove; unused.
11216 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11217 (copy_keymap_item, append_key, push_text_char_description):
11219 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11220 (DENSE_TABLE_SIZE): Remove; unused.
11221 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11222 (describe_map_tree):
11223 Rename locals to avoid shadowing.
11225 * keyboard.c: Declare functions static if they are not used elsewhere.
11226 (echo_char, echo_dash, cmd_error, top_level_2):
11227 (poll_for_input, handle_async_input): Now static.
11228 (read_char, kbd_buffer_get_event, make_lispy_position):
11229 (make_lispy_event, make_lispy_movement, apply_modifiers):
11230 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11231 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11232 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11233 (read_key_sequence, read_char): Mark locals as initialized.
11234 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11236 * keyboard.h (make_ctrl_char): New decl.
11237 (mark_kboards): Move decl here ...
11238 * alloc.c (mark_kboards): ... from here.
11240 * lisp.h (force_auto_save_soon): New decl.
11242 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11243 (DEFINE_DUMMY_FUNCTION): New macro.
11244 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11246 (main): Add casts to avoid warnings
11247 if GCC considers string literals to be constants.
11249 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11251 * dbusbind.c: Pointer signedness fixes.
11252 (xd_signature, xd_append_arg, xd_initialize):
11253 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11254 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11255 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11256 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11258 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11259 if GCC considers string literals to be constants.
11260 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11262 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11264 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11265 (print_preprocess, print_object): New macro to fix last change.
11267 * print.c (print_preprocess): Don't forget font objects.
11269 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11271 * emacs.c (USAGE3): Doc fixes.
11273 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11275 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11278 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11280 * lisp.h (VWindow_system, Qfile_name_history):
11281 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11282 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11283 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11285 * w32select.c: Don't #include "keyboard.h".
11286 (run_protected): Add extern declaration for waiting_for_input.
11288 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11289 * w32console.c (detect_input_pending, read_input_pending)
11290 (encode_terminal_code):
11291 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11292 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11293 (w32_system_caret_y, Qfile_name_history):
11294 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11295 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11296 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11297 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11298 * w32proc.c (Qlocal, report_file_error):
11299 * w32term.c (Vwindow_system, updating_frame):
11300 * w32uniscribe.c (initialized, uniscribe_font_driver):
11301 Remove unneeded extern declarations.
11303 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11305 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11307 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11309 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11310 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11311 These macros can no longer be used for assignment.
11313 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11314 Assign struct members directly, instead of using BUF_BEGV etc.
11315 (record_buffer_markers, fetch_buffer_markers): New functions for
11316 recording and fetching special buffer markers.
11317 (set_buffer_internal_1, set_buffer_temp): Use them.
11319 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11321 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11323 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11324 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11326 * xdisp.c (hscroll_window_tree):
11327 (reconsider_clip_changes): Use PT instead of BUF_PT.
11329 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11331 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11332 $(EMACS_ROOT)/lib/intprops.h.
11334 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11336 Fix more problems found by GCC 4.5.2's static checks.
11338 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11339 to unsigned char * to avoid compiler diagnostic.
11340 (xg_free_frame_widgets): Make it clear that a local variable is
11341 needed only if USE_GTK_TOOLTIP.
11342 (gdk_window_get_screen): Make it clear that this macro is needed
11343 only if USE_GTK_TOOLTIP.
11344 (int_gtk_range_get_value): New function, which avoids a diagnostic
11345 from gcc -Wbad-function-cast.
11346 (xg_set_toolkit_scroll_bar_thumb): Use it.
11347 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11348 diagnostic from gcc -Wbad-function-cast.
11349 (get_utf8_string, xg_get_file_with_chooser):
11350 Rename locals to avoid shadowing.
11351 (create_dialog): Move locals to avoid shadowing.
11353 * xgselect.c (xg_select): Remove unused var.
11355 * image.c (four_corners_best): Mark locals as initialized.
11356 (gif_load): Initialize transparent_p to zero (Bug#8238).
11357 Mark another local as initialized.
11358 (my_png_error, my_error_exit): Mark with NO_RETURN.
11360 * image.c (clear_image_cache): Now static.
11361 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11362 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11363 (x_edge_detection): Remove unnecessary cast that
11364 gcc -Wbad-function-cast diagnoses.
11365 (gif_load): Fix pointer signedness.
11366 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11367 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11369 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11371 Improve quality of tests for time stamp overflow.
11372 For example, without this patch (encode-time 0 0 0 1 1
11373 1152921504606846976) returns the obviously-bogus value (-948597
11374 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11375 reports time overflow. See
11376 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11377 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11378 * editfns.c: Include limits.h and intprops.h.
11379 (TIME_T_MIN, TIME_T_MAX): New macros.
11380 (time_overflow): Move earlier, to before first use.
11381 (hi_time, lo_time): New functions, for an accurate test for
11382 out-of-range times.
11383 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11384 (Fget_internal_run_time): Don't assume time_t fits in int.
11385 (make_time): Use list2 instead of Fcons twice.
11386 (Fdecode_time): More accurate test for out-of-range times.
11387 (check_tm_member): New function.
11388 (Fencode_time): Use it, to test for out-of-range times.
11389 (lisp_time_argument): Don't rely on undefined left-shift and
11390 right-shift behavior when checking for time stamp overflow.
11392 * editfns.c (time_overflow): New function, refactoring common code.
11393 (Fformat_time_string, Fdecode_time, Fencode_time):
11394 (Fcurrent_time_string): Use it.
11396 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11397 * dired.c (make_time): Move to ...
11398 * editfns.c (make_time): ... here.
11399 * systime.h: Note the move.
11401 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11403 * fringe.c (update_window_fringes): Remove unused variables.
11405 * unexmacosx.c (copy_data_segment): Also copy __got section.
11408 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11410 * termcap.c [MSDOS]: Include "msdos.h".
11411 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11412 Constify `char *' arguments and their references according to
11413 prototypes in tparam.h.
11415 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11417 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11418 Adapt all references accordingly.
11420 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11422 2011-03-11 Tom Tromey <tromey@redhat.com>
11424 * buffer.c (syms_of_buffer): Remove obsolete comment.
11426 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11428 * termhooks.h (encode_terminal_code): Declare prototype.
11430 * msdos.c (encode_terminal_code): Don't declare prototype.
11432 * term.c (encode_terminal_code): Now external again, used by
11433 w32console.c and msdos.c.
11435 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11436 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11438 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11440 Fix some minor problems found by GCC 4.5.2's static checks.
11442 * fringe.c (update_window_fringes): Mark locals as initialized
11444 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11446 * alloc.c (mark_fringe_data): Move decl from here ...
11447 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11448 to check its interface.
11449 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11451 * fontset.c (free_realized_fontset): Now static.
11452 (Fset_fontset_font): Rename local to avoid shadowing.
11453 (fontset_font): Mark local as initialized.
11454 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11456 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11458 * xselect.c (x_disown_buffer_selections): Remove; not used.
11459 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11460 (x_own_selection, Fx_disown_selection_internal): Rename locals
11461 to avoid shadowing.
11462 (x_handle_dnd_message): Remove local to avoid shadowing.
11464 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11465 so that the caller can use some name other than gcpro1.
11466 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11467 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11468 (Fx_backspace_delete_keys_p):
11469 Use them to avoid shadowing, and rename vars to avoid shadowing.
11470 (x_decode_color, x_set_name, x_window): Now static.
11471 (Fx_create_frame): Add braces to silence GCC warning.
11472 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11473 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11474 Remove unused locals.
11475 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11476 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11477 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11480 * xterm.h (x_mouse_leave): New decl.
11482 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11483 Remove unused functions.
11484 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11485 (x_calc_absolute_position): Now static.
11486 (XTread_socket): Don't define label "out" unless it's used.
11487 Don't declare local "event" unless it's used.
11488 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11489 unless they are used.
11490 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11491 (x_fatal_error_signal): Remove; not used.
11492 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11493 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11494 (x_error_catcher, x_connection_closed, x_error_handler):
11495 (x_error_quitter, xembed_send_message, x_iconify_frame):
11496 (my_log_handler): Rename locals to avoid shadowing.
11497 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11498 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11500 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11501 Rename or move locals to avoid shadowing.
11502 (tty_defined_color, merge_face_heights): Now static.
11503 (free_realized_faces_for_fontset): Remove; not used.
11504 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11505 does not deduce is never used uninitialized.
11506 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11507 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11509 * terminal.c (store_terminal_param): Now static.
11511 * xmenu.c (menu_highlight_callback): Now static.
11512 (set_frame_menubar): Remove unused local.
11513 (xmenu_show): Rename parameter to avoid shadowing.
11514 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11515 since they might point to immutable storage.
11516 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11517 since it's unused otherwise.
11519 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11520 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11521 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11522 avoids a gcc -Wuninitialized diagnostic.
11523 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11524 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11525 does not deduce are never used uninitialized.
11527 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11529 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11530 * window.c (window_loop, size_window):
11531 (run_window_configuration_change_hook, enlarge_window): Likewise.
11533 * window.c (display_buffer): Now static.
11534 (size_window): Mark variables that gcc -Wuninitialized
11535 does not deduce are never used uninitialized.
11536 * window.h (check_all_windows): New decl, to forestall
11537 gcc -Wmissing-prototypes diagnostic.
11538 * dispextern.h (bidi_dump_cached_states): Likewise.
11540 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11542 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11543 Include <limits.h>.
11544 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11545 and to avoid gcc -Wuninitialized warning.
11546 (load_charset_map): Mark variables that gcc -Wuninitialized
11547 does not deduce are never used uninitialized.
11548 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11550 * coding.c (coding_set_source, coding_set_destination):
11551 Use "else { /* comment */ }" rather than "else /* comment */;"
11552 for clarity, and to avoid gcc -Wempty-body warning.
11553 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11554 a block, when the outer 'i' will do.
11555 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11556 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11557 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11558 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11559 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11560 Rename locals to avoid shadowing.
11561 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11562 * coding.c (emacs_mule_char, encode_invocation_designation):
11563 Now static, since they're not used elsewhere.
11564 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11565 (decode_coding_object, encode_coding_object, detect_coding_system):
11566 (decode_coding_emacs_mule): Mark variables that gcc
11567 -Wuninitialized does not deduce are never used uninitialized.
11568 (detect_coding_iso_2022): Initialize a local variable that might
11569 be used uninitialized. Leave a FIXME because it's not clear that
11570 this initialization is needed. (Bug#8211)
11571 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11572 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11573 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11574 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11575 Remove unused macros.
11577 * category.c (hash_get_category_set): Remove unused local var.
11578 (copy_category_table): Now static, since it's not used elsewhere.
11579 * character.c (string_count_byte8): Likewise.
11581 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11582 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11584 * chartab.c (copy_sub_char_table): Now static, since it's not used
11586 (sub_char_table_ref_and_range, char_table_ref_and_range):
11587 Rename locals to avoid shadowing.
11588 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11590 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11591 (BIDI_BOB): Remove unused macro.
11593 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11594 deduce are never used uninitialized.
11595 * term.c (encode_terminal_code): Likewise.
11597 * term.c (encode_terminal_code): Now static. Remove unused local.
11599 * tparam.h: New file.
11600 * term.c, tparam.h: Include it.
11601 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11602 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11603 Move these decls to tparam.h, and make them agree with what
11604 is actually in tparam.c. The previous trick of using incompatible
11605 decls in different modules does not conform to the C standard.
11606 All callers of tparam changed to use tparam's actual API.
11607 * tparam.c (tparam1, tparam, tgoto):
11608 Use const pointers where appropriate.
11610 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11611 * cm.h (struct cm): Likewise.
11612 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11613 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11614 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11615 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11616 (turn_on_face, init_tty): Likewise.
11617 * termchar.h (struct tty_display_info): Likewise.
11619 * term.c (term_mouse_position): Rename local to avoid shadowing.
11621 * alloc.c (mark_ttys): Move decl from here ...
11622 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11624 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11626 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11628 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11630 * search.c (compile_pattern_1): Remove argument regp, unused since
11631 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11632 (compile_pattern): Don't pass it.
11634 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11636 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11637 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11639 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11641 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11643 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11644 gdk_window_get_screen, gdk_window_get_geometry,
11645 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11646 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11647 (xg_get_pixbuf_from_pixmap): New function.
11648 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11649 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11650 Call xg_get_pixbuf_from_pixmap instead of
11651 gdk_pixbuf_get_from_drawable.
11652 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11653 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11654 (xg_check_special_colors): Use GtkStyleContext and its functions
11656 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11657 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11658 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11659 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11660 Call gtk_widget_get_preferred_size.
11661 (xg_frame_resized): gdk_window_get_geometry only takes 5
11663 (xg_win_to_widget, xg_event_is_for_menubar):
11664 Call gdk_x11_window_lookup_for_display.
11665 (xg_set_widget_bg): New function.
11666 (delete_cb): New function.
11667 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11668 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11669 (xg_set_background_color): Call xg_set_widget_bg.
11670 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11671 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11672 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11673 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11675 (update_frame_tool_bar): Call gtk_widget_hide.
11676 (xg_initialize): Use GDK_KEY_g.
11678 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11680 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11682 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11683 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11684 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11686 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11688 * w32xfns.c (select_palette): Check success of RealizePalette against
11689 GDI_ERROR, not zero.
11691 See ChangeLog.11 for earlier changes.
11693 ;; Local Variables:
11697 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11699 This file is part of GNU Emacs.
11701 GNU Emacs is free software: you can redistribute it and/or modify
11702 it under the terms of the GNU General Public License as published by
11703 the Free Software Foundation, either version 3 of the License, or
11704 (at your option) any later version.
11706 GNU Emacs is distributed in the hope that it will be useful,
11707 but WITHOUT ANY WARRANTY; without even the implied warranty of
11708 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11709 GNU General Public License for more details.
11711 You should have received a copy of the GNU General Public License
11712 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.