]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from mainline.
[gnu-emacs] / src / ChangeLog
1 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4 Also, don't assume VALBITS / RAND_BITS is less than 5,
5 and don't rely on undefined behavior when shifting a 1 left into
6 the sign bit.
7 * lisp.h (get_random): Change signature to match.
8
9 * lread.c (hash_string): Use size_t, not int, for hash computation.
10 Normally we prefer signed values; but hashing is special, because
11 it's better to use unsigned division on hash table sizes so that
12 the remainder is nonnegative. Also, size_t is the natural width
13 for hashing into memory. The previous code used 'int', which doesn't
14 retain enough info to hash well into very large tables.
15 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
16
17 * dbusbind.c: Don't possibly lose pointer info when converting.
18 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
19 Use XPNTR rather than XHASH, so that the high-order bits of
20 the pointer aren't lost when converting through void *.
21
22 * eval.c (Fautoload): Don't double-shift a pointer.
23
24 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
25
26 2011-04-28 Eli Zaretskii <eliz@gnu.org>
27
28 * doprnt.c (doprnt): Don't return value smaller than the buffer
29 size if the message was truncated. (Bug#8545).
30
31 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
32
33 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
34 (Fx_window_property): #if-0 the whole functions, not just the bodies.
35
36 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
37
38 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
39
40 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
41
42 * makefile.w32-in: Update dependencies.
43
44 2011-04-27 Eli Zaretskii <eliz@gnu.org>
45
46 Improve `doprnt' and its usage. (Bug#8545)
47 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
48 `format_end'. Remove support for %l as a conversion specifier.
49 Don't use xrealloc. Improve diagnostics when the %l size modifier
50 is used. Update the commentary.
51
52 * eval.c (verror): Simplify calculation of size_t.
53
54 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
55 messages.
56
57 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
58
59 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
60 change.
61
62 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
63
64 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
65 This makes this file independent of the recent pseudovector change.
66
67 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
68
69 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
70
71 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
72 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
73 Remove unused local.
74 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
75
76 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
77 GCC 4.6.0 optimizes based on type-based alias analysis. For
78 example, if b is of type struct buffer * and v of type struct
79 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
80 != &v->size, and therefore "v->size = 1; b->size = 2; return
81 v->size;" must therefore return 1. This assumption is incorrect
82 for Emacs, since it type-puns struct Lisp_Vector * with many other
83 types. To fix this problem, this patch adds a new type struct
84 vectorlike_header that documents the constraints on layout of vectors
85 and pseudovectors, and helps optimizing compilers not get fooled
86 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
87 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
88 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
89 the size member.
90 (XSETPVECTYPE): Rewrite in terms of new macro.
91 (XSETPVECTYPESIZE): New macro, specifying both type and size.
92 This is a bit clearer, and further avoids the possibility of
93 undesirable aliasing.
94 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
95 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
96 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
97 since Lisp_Subr is a special case (no "next" field).
98 (ASIZE): Now uses header.size rather than size. All
99 previous uses of XVECTOR (foo)->size replaced to use this macro,
100 to avoid the hassle of writing XVECTOR (foo)->header.size.
101 (struct vectorlike_header): New type.
102 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
103 object, to help avoid aliasing.
104 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
105 (SUBRP): Likewise, since Lisp_Subr is a special case.
106 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
107 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
108 (struct Lisp_Hash_Table): Combine first two members into a single
109 struct vectorlike_header member. All uses of "size" and "next" members
110 changed to be "header.size" and "header.next".
111 * buffer.h (struct buffer): Likewise.
112 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
113 * frame.h (struct frame): Likewise.
114 * process.h (struct Lisp_Process): Likewise.
115 * termhooks.h (struct terminal): Likewise.
116 * window.c (struct save_window_data, struct saved_window): Likewise.
117 * window.h (struct window): Likewise.
118 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
119 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
120 * buffer.c (init_buffer_once): Likewise.
121 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
122 special case.
123 * process.c (Fformat_network_address): Use local var for size,
124 for brevity.
125
126 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
127
128 Make the Lisp reader and string-to-float more consistent (Bug#8525)
129 * data.c (atof): Remove decl; no longer used or needed.
130 (digit_to_number): Move to lread.c.
131 (Fstring_to_number): Use new string_to_number function, to be
132 consistent with how the Lisp reader treats infinities and NaNs.
133 Do not assume that floating-point numbers represent EMACS_INT
134 without losing information; this is not true on most 64-bit hosts.
135 Avoid double-rounding errors, by insisting on integers when
136 parsing non-base-10 numbers, as the documentation specifies.
137 * lisp.h (string_to_number): New decl, replacing ...
138 (isfloat_string): Remove.
139 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
140 (read1): Do not accept +. and -. as integers; this
141 appears to have been a coding error. Similarly, do not accept
142 strings like +-1e0 as floating point numbers. Do not report
143 overflow for integer overflows unless the base is not 10 which
144 means we have no simple and reliable way to continue.
145 Break out the floating-point parsing into a new
146 function string_to_number, so that Fstring_to_number parses
147 floating point numbers consistently with the Lisp reader.
148 (digit_to_number): Moved here from data.c. Make it static inline.
149 (E_CHAR, EXP_INT): Remove, replacing with ...
150 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
151 (string_to_number): New function, replacing isfloat_string.
152 This function checks for valid syntax and produces the resulting
153 Lisp float number too. Rework it so that string-to-number
154 no longer mishandles examples like "1.0e+". Use strtoumax,
155 so that overflow for non-base-10 numbers is reported only when
156 there's no portable and simple way to convert to floating point.
157
158 * textprop.c (set_text_properties_1): Rewrite for clarity,
159 and to avoid GCC warning about integer overflow.
160
161 * intervals.h (struct interval): Use EMACS_INT for members
162 where EMACS_UINT might cause problems. See
163 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
164 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
165 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
166 All uses changed.
167 (offset_intervals): Tell GCC not to worry about length overflow
168 when negating a negative length.
169
170 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
171 (overrun_check_free): Likewise.
172
173 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
174 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
175 word size.
176
177 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
178 (gnutls_make_error): Rename local to avoid shadowing.
179 (gnutls_emacs_global_deinit): ifdef out; not used.
180 (Fgnutls_boot): Use const for pointer to readonly storage.
181 Comment out unused local. Fix pointer signedness problems.
182
183 * lread.c (openp): Don't stuff size_t into an 'int'.
184 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
185 about possible signed overflow.
186
187 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
188 (GDK_KEY_g): Don't define if already defined.
189 (xg_prepare_tooltip): Avoid pointer signedness problem.
190 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
191
192 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
193 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
194
195 * xfns.c (Fx_window_property): Simplify a bit,
196 to make a bit faster and to avoid GCC 4.6.0 warning.
197 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
198
199 * fns.c (internal_equal): Don't assume size_t fits in int.
200
201 * alloc.c (compact_small_strings): Tighten assertion a little.
202
203 Replace pEd with more-general pI, and fix some printf arg casts.
204 * lisp.h (pI): New macro, generalizing old pEd macro to other
205 conversion specifiers. For example, use "...%"pI"d..." rather
206 than "...%"pEd"...".
207 (pEd): Remove. All uses replaced with similar uses of pI.
208 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
209 * alloc.c (check_pure_size): Don't overflow by converting size to int.
210 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
211 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
212 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
213 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
214 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
215 64-bit hosts.
216 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
217 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
218 * print.c (safe_debug_print, print_object): Likewise.
219 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
220 to int.
221 Use pI instead of if-then-else-abort. Use %p to avoid casts,
222 avoiding the 0 flag, which is not portable.
223 * process.c (Fmake_network_process): Use pI to avoid cast.
224 * region-cache.c (pp_cache): Likewise.
225 * xdisp.c (decode_mode_spec): Likewise.
226 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
227 behavior on 64-bit hosts with printf arg.
228 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
229 (x_stop_queuing_selection_requests): Likewise.
230 (x_get_window_property): Don't truncate byte count to an 'int'
231 when tracing.
232
233 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
234 here, since it parses constructs like leading '-' and spaces,
235 which are not wanted; and it overflows with large numbers.
236 Instead, simply match F[0-9]+, which is what is wanted anyway.
237
238 * alloc.c: Remove unportable assumptions about struct layout.
239 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
240 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
241 (allocate_vectorlike, make_pure_vector): Use the new macros,
242 plus offsetof, to remove unportable assumptions about struct layout.
243 These assumptions hold on all porting targets that I know of, but
244 they are not guaranteed, they're easy to remove, and removing them
245 makes further changes easier.
246
247 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
248 This doesn't fix a bug but makes the code clearer.
249 (string_overrun_cookie): Now const. Use initializers that
250 don't formally overflow signed char, to avoid warnings.
251 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
252 can cause Emacs to crash when string overrun checking is enabled.
253 (allocate_buffer): Don't assume sizeof (struct buffer) is a
254 multiple of sizeof (EMACS_INT); it need not be, if
255 alignof(EMACS_INT) < sizeof (EMACS_INT).
256 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
257
258 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
259
260 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
261
262 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
263
264 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
265 supposed to be handshaking. (Bug#8556)
266 Reported by Paul Eggert <eggert@cs.ucla.edu>.
267
268 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
269
270 * lisp.h (Qdebug): List symbol.
271 * eval.c (Qdebug): Restore global linkage.
272 * keyboard.c (debug-on-event): New variable.
273 (handle_user_signal): Break into debugger when debug-on-event
274 matches the current signal symbol.
275
276 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
277
278 * alloc.c (check_sblock, check_string_bytes)
279 (check_string_free_list): Convert to standard C.
280
281 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
282
283 * w32.c (emacs_gnutls_push): Fix typo.
284
285 2011-04-25 Eli Zaretskii <eliz@gnu.org>
286
287 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
288 "cast to pointer from integer of different size".
289
290 Improve doprnt and its use in verror. (Bug#8545)
291 * doprnt.c (doprnt): Document the set of format control sequences
292 supported by the function. Use SAFE_ALLOCA instead of always
293 using `alloca'.
294
295 * eval.c (verror): Don't limit the buffer size at size_max-1, that
296 is one byte too soon. Don't use xrealloc; instead xfree and
297 xmalloc anew.
298
299 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
300
301 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
302 callbacks stage.
303
304 * gnutls.c: Renamed global_initialized to
305 gnutls_global_initialized. Added internals for the
306 :verify-hostname-error, :verify-error, and :verify-flags
307 parameters of `gnutls-boot' and documented those parameters in the
308 docstring. Start callback support.
309 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
310 unless a fatal error occured. Call gnutls_alert_send_appropriate
311 on error. Return error code.
312 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
313 (emacs_gnutls_read): Likewise.
314 (Fgnutls_boot): Return handshake error code.
315 (emacs_gnutls_handle_error): New function.
316 (wsaerror_to_errno): Likewise.
317
318 * w32.h (emacs_gnutls_pull): Add prototype.
319 (emacs_gnutls_push): Likewise.
320
321 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
322 (emacs_gnutls_push): Likewise.
323
324 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
325
326 * process.c (wait_reading_process_output): Check if GnuTLS
327 buffered some data internally if no FDs are set for TLS
328 connections.
329
330 * makefile.w32-in (OBJ2): Add gnutls.$(O).
331 (LIBS): Link to USER_LIBS.
332 ($(BLD)/gnutls.$(0)): New target.
333
334 2011-04-24 Eli Zaretskii <eliz@gnu.org>
335
336 * xdisp.c (handle_single_display_spec): Rename the
337 display_replaced_before_p argument into display_replaced_p, to
338 make it consistent with the commentary. Fix typos in the
339 commentary.
340
341 * textprop.c (syms_of_textprop): Remove dead code.
342 (copy_text_properties): Delete obsolete commentary about an
343 interface that was deleted long ago. Fix typos in the description
344 of arguments.
345
346 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
347 to changes in oldXMenu/XMenu.h from 2011-04-16.
348 <menu_help_message, prev_menu_help_message>: Constify.
349 (IT_menu_make_room): menu->help_text is now `const char **';
350 adjust.
351
352 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
353 to changes in oldXMenu/XMenu.h from 2011-04-16.
354 (struct XMenu): Declare `help_text' `const char **'.
355
356 * xfaces.c <Qunspecified>: Make extern again.
357
358 * syntax.c: Include sys/types.h before including regex.h, as
359 required by Posix.
360
361 * doc.c (get_doc_string): Improve the format passed to `error'.
362
363 * doprnt.c (doprnt): Improve commentary.
364
365 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
366
367 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
368 them with etags.
369
370 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
371 changes in globals.h immediately force recompilation.
372 (TAGS): Depend on $(CURDIR)/m/intel386.h and
373 $(CURDIR)/s/ms-w32.h.
374 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
375
376 * character.c (Fchar_direction): Function deleted.
377 (syms_of_character): Don't defsubr it.
378 <char-direction-table>: Deleted.
379
380 2011-04-23 Eli Zaretskii <eliz@gnu.org>
381
382 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
383 * doprnt.c: Include limits.h.
384 (SIZE_MAX): New macro.
385 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
386 local variables are now size_t instead of int or unsigned.
387 Improve overflow protection. Support `l' modifier for integer
388 conversions. Support %l conversion. Don't assume an EMACS_INT
389 argument for integer conversions and for %c.
390
391 * lisp.h (doprnt): Restore prototype.
392
393 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
394 $(SRC)/character.h.
395
396 * Makefile.in (base_obj): Add back doprnt.o.
397
398 * deps.mk (doprnt.o): Add back prerequisites.
399 (callint.o): Depend on character.h.
400
401 * eval.c (internal_lisp_condition_case): Include the handler
402 representation in the error message.
403 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
404 when breaking from the loop.
405
406 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
407
408 * callint.c (Fcall_interactively): When displaying error message
409 about invalid control letter, pass the character's codepoint, not
410 a pointer to its multibyte form. Improve display of the character
411 in octal and display also its hex code.
412
413 * character.c (char_string): Use %x to display the (unsigned)
414 codepoint of an invalid character, to avoid displaying a bogus
415 negative value.
416
417 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
418 `error', not SYMBOL_NAME itself.
419
420 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
421 character arguments to `error'.
422
423 * charset.c (check_iso_charset_parameter): Fix incorrect argument
424 to `error' in error message about FINAL_CHAR argument. Make sure
425 FINAL_CHAR is a character, and use %c when it is passed as
426 argument to `error'.
427
428 2011-04-23 Eli Zaretskii <eliz@gnu.org>
429
430 * s/ms-w32.h (localtime): Redirect to sys_localtime.
431
432 * w32.c: Include <time.h>.
433 (sys_localtime): New function.
434
435 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
436
437 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
438
439 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
440
441 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
442
443 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
444 zombies (Bug#8467).
445
446 2011-04-19 Eli Zaretskii <eliz@gnu.org>
447
448 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
449 gl_state.e_property when gl_state.object is Qt.
450
451 * insdel.c (make_gap_larger): Remove limitation of buffer size
452 to <= INT_MAX.
453
454 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
455
456 * xdisp.c (lookup_glyphless_char_display)
457 (produce_glyphless_glyph): Handle cons cell entry in
458 glyphless-char-display.
459 (Vglyphless_char_display): Document it.
460
461 * term.c (produce_glyphless_glyph): Handle cons cell entry in
462 glyphless-char-display.
463
464 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
465
466 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
467
468 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
469
470 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
471 definition for no-X builds.
472
473 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
474
475 Static checks with GCC 4.6.0 and non-default toolkits.
476
477 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
478
479 * process.c (keyboard_bit_set): Define only if SIGIO.
480 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
481 (send_process): Repair possible setjmp clobbering.
482
483 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
484
485 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
486
487 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
488
489 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
490 Define only if needed.
491
492 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
493 by pacifying GCC about it. Maybe it's time to retire it?
494 * xfaces.c (USG, __TIMEVAL__): Likewise.
495
496 * dispextern.h (struct redisplay_interface): Rename param
497 to avoid shadowing.
498 * termhooks.h (struct terminal): Likewise.
499 * xterm.c (xembed_send_message): Likewise.
500
501 * insdel.c (make_gap_smaller): Define only if
502 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
503
504 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
505 it.
506
507 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
508 so that we aren't warned about unused symbols.
509
510 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
511
512 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
513
514 * xfns.c (x_real_positions): Mark locals as initialized.
515
516 * xmenu.c (xmenu_show): Don't use uninitialized vars.
517
518 * xterm.c: Fix problems found by static analysis with other toolkits.
519 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
520 (x_dispatch_event): Declare static if USE_GTK, and
521 define if USE_GTK || USE_X_TOOLKIT.
522 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
523 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
524 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
525 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
526
527 * xmenu.c (menu_help_callback): Pointer type fixes.
528 Use const pointers when pointing at readonly data. Avoid pointer
529 signedness clashes.
530 (FALSE): Remove unused macro.
531 (update_frame_menubar): Remove unused decl.
532
533 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
534
535 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
536 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
537 (single_menu_item): Rename local to avoid shadowing.
538
539 * keyboard.c (make_lispy_event): Remove unused local var.
540
541 * frame.c, frame.h (x_get_resource_string): Bring this back, but
542 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
543
544 * bitmaps: Change bitmaps from unsigned char back to the X11
545 compatible char. Avoid the old compiler warnings about
546 out-of-range initializers by using, for example, '\xab' rather
547 than 0xab.
548
549 * xgselect.c (xgselect_initialize): Check vs interface
550 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
551
552 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
553
554 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
555 to read-only memory.
556
557 * fns.c (vector): Remove; this old hack is no longer needed.
558
559 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
560 Remove unused var.
561 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
562
563 * xrdb.c (x_load_resources): Omit unused local.
564
565 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
566 (x_window): Rename locals to avoid shadowing.
567 (USG): Use the kludged USG macro, to pacify gcc.
568
569 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
570 (x_term_init): Remove local to avoid shadowing.
571
572 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
573
574 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
575 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
576
577 2011-04-16 Eli Zaretskii <eliz@gnu.org>
578
579 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
580
581 Fix regex.c, syntax.c and friends for buffers > 2GB.
582 * syntax.h (struct gl_state_s): Declare character position members
583 EMACS_INT.
584
585 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
586
587 * textprop.c (verify_interval_modification, interval_of): Declare
588 arguments EMACS_INT.
589
590 * intervals.c (adjust_intervals_for_insertion): Declare arguments
591 EMACS_INT.
592
593 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
594
595 * indent.c (Fvertical_motion): Local variable it_start is now
596 EMACS_INT.
597
598 * regex.c (re_match, re_match_2, re_match_2_internal)
599 (bcmp_translate, regcomp, regexec, print_double_string)
600 (group_in_compile_stack, re_search, re_search_2, regex_compile)
601 (re_compile_pattern, re_exec): Declare arguments and local
602 variables `size_t' and `ssize_t' and return values `regoff_t', as
603 appropriate.
604 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
605 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
606 <compile_stack_type>: `size' and `avail' are now `size_t'.
607
608 * regex.h <regoff_t>: Use ssize_t, not int.
609 (re_search, re_search_2, re_match, re_match_2): Arguments that
610 specify buffer/string position and length are now ssize_t and
611 size_t. Return type is regoff_t.
612
613 2011-04-16 Ben Key <bkey76@gmail.com>
614
615 * nsfont.m: Fixed bugs in ns_get_family and
616 ns_descriptor_to_entity that were caused by using free to
617 deallocate memory blocks that were allocated by xmalloc (via
618 xstrdup). This caused Emacs to crash when compiled with
619 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
620 --enable-checking=xmallocoverrun). xfree is now used to
621 deallocate these memory blocks.
622
623 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
624
625 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
626
627 emacs_write: Accept and return EMACS_INT for sizes.
628 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
629 et seq.
630 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
631 Accept and return EMACS_INT.
632 (emacs_gnutls_write): Return the number of bytes written on
633 partial writes.
634 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
635 (emacs_read, emacs_write): Remove check for negative size, as the
636 Emacs source code has been audited now.
637 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
638 (emacs_read, emacs_write): Use it.
639 * process.c (send_process): Adjust to the new signatures of
640 emacs_write and emacs_gnutls_write. Do not attempt to store
641 a byte offset into an 'int'; it might overflow.
642 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
643
644 * sound.c: Don't assume sizes fit in 'int'.
645 (struct sound_device.period_size, alsa_period_size):
646 Return EMACS_INT, not int.
647 (struct sound_device.write, vox_write, alsa_write):
648 Accept EMACS_INT, not int.
649 (wav_play, au_play): Use EMACS_INT to store sizes and to
650 record read return values.
651
652 2011-04-15 Ben Key <bkey76@gmail.com>
653
654 * keyboard.c (Qundefined): Don't declare static since it is used
655 in nsfns.m.
656 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
657 static since they are used in nsfont.m.
658
659 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
660
661 * process.c (Qprocessp): Don't declare static.
662 * lisp.h (Qprocessp): Declare again.
663
664 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
665
666 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
667
668 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
669
670 Improve C-level modularity by making more things 'static'.
671
672 Don't publish debugger-only interfaces to other modules.
673 * lisp.h (safe_debug_print, debug_output_compilation_hack):
674 (verify_bytepos, count_markers): Move decls to the only modules
675 that need them.
676 * region-cache.h (pp_cache): Likewise.
677 * window.h (check_all_windows): Likewise.
678 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
679
680 * sysdep.c (croak): Now static, if
681 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
682 * syssignal.h (croak): Declare only if not static.
683
684 * alloc.c (refill_memory_reserve): Now static if
685 !defined REL_ALLOC || defined SYSTEM_MALLOC.
686 * lisp.h (refill_memory_reserve): Declare only if not static.
687
688 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
689 Define only if USE_LUCID.
690
691 * xrdb.c (x_customization_string, x_rm_string): Now static.
692
693 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
694 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
695
696 * xdisp.c (draw_row_with_mouse_face): Now static.
697 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
698
699 * window.h (check_all_windows): Mark externally visible.
700
701 * window.c (window_deletion_count): Now static.
702
703 * undo.c: Make symbols static if they're not exported.
704 (last_undo_buffer, last_boundary_position, pending_boundary):
705 Now static.
706
707 * textprop.c (interval_insert_behind_hooks): Now static.
708 (interval_insert_in_front_hooks): Likewise.
709
710 * term.c: Make symbols static if they're not exported.
711 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
712 (max_frame_lines, tty_set_terminal_modes):
713 (tty_reset_terminal_modes, tty_turn_off_highlight):
714 (get_tty_terminal): Now static.
715 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
716 * termhooks.h (term_mouse_moveto): Do not declare if
717 HAVE_WINDOW_SYSTEM.
718 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
719 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
720
721 * sysdep.c: Make symbols static if they're not exported.
722 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
723 Now static.
724 (sigprocmask_set, full_mask): Remove; unused.
725 (wait_debugging): Mark as visible.
726 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
727 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
728
729 * syntax.c (syntax_temp): Define only if !__GNUC__.
730
731 * sound.c (current_sound_device, current_sound): Now static.
732
733 * search.c (searchbufs, searchbuf_head): Now static.
734
735 * scroll.c (scroll_cost): Remove; unused.
736 * dispextern.h (scroll_cost): Remove decl.
737
738 * region-cache.h (pp_cache): Mark as externally visible.
739
740 * process.c: Make symbols static if they're not exported.
741 (process_tick, update_tick, create_process, chan_process):
742 (Vprocess_alist, proc_buffered_char, datagram_access):
743 (fd_callback_data, send_process_frame, process_sent_to): Now static.
744 (deactivate_process): Mark defn as static, as well as decl.
745 * lisp.h (create_process): Remove decl.
746 * process.h (chan_process, Vprocess_alist): Remove decls.
747
748 * print.c: Make symbols static if they're not exported.
749 (print_depth, new_backquote_output, being_printed, print_buffer):
750 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
751 (print_interval, print_number_index, initial_stderr_stream):
752 Now static.
753 * lisp.h (Fprinc): Remove decl.
754 (debug_output_compilation_hack): Mark as externally visible.
755
756 * sysdep.c (croak): Move decl from here to syssignal.h.
757 * syssignal.h (croak): Put it here, so the API can be checked when
758 'croak' is called from dissociate_if_controlling_tty.
759
760 * minibuf.c: Make symbols static if they're not exported.
761 (minibuf_save_list, choose_minibuf_frame): Now static.
762 * lisp.h (choose_minibuf_frame): Remove decl.
763
764 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
765
766 * lread.c: Make symbols static if they're not exported.
767 (read_objects, initial_obarray, oblookup_last_bucket_number):
768 Now static.
769 (make_symbol): Remove; unused.
770 * lisp.h (initial_obarray, make_symbol): Remove decls.
771
772 * keyboard.c: Make symbols static if they're not exported.
773 (single_kboard, recent_keys_index, total_keys, recent_keys):
774 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
775 (this_single_command_key_start, echoing, last_auto_save):
776 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
777 (command_loop, echo_now, keyboard_init_hook, help_char_p):
778 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
779 (Vlispy_mouse_stem, double_click_count):
780 Now static.
781 (force_auto_save_soon): Define only if SIGDANGER.
782 (ignore_mouse_drag_p): Now static if
783 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
784 (print_help): Remove; unused.
785 (stop_character, last_timer_event): Mark as externally visible.
786 * keyboard.h (ignore_mouse_drag_p): Declare only if
787 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
788 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
789 * lisp.h (echoing): Remove decl.
790 (force_auto_save_soon): Declare only if SIGDANGER.
791 * xdisp.c (redisplay_window): Simplify code, to make it more
792 obvious that ignore_mouse_drag_p is not accessed if !defined
793 USE_GTK && !defined HAVE_NS.
794
795 * intervals.c: Make symbols static if they're not exported.
796 (merge_properties_sticky, merge_interval_right, delete_interval):
797 Now static.
798 * intervals.h (merge_interval_right, delete_interval): Remove decls.
799
800 * insdel.c: Make symbols static if they're not exported.
801 However, leave prepare_to_modify_buffer alone. It's never
802 called from outside this function, but that appears to be a bug.
803 (combine_after_change_list, combine_after_change_buffer):
804 (adjust_after_replace, signal_before_change): Now static.
805 (adjust_after_replace_noundo): Remove; unused.
806 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
807 (signal_before_change): Remove decls.
808
809 * indent.c (val_compute_motion, val_vmotion): Now static.
810
811 * image.c: Make symbols static if they're not exported.
812 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
813 if USE_GTK.
814 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
815 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
816
817 * fringe.c (standard_bitmaps): Now static.
818 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
819
820 * frame.c: Make symbols static if they're not exported.
821 (x_report_frame_params, make_terminal_frame): Now static.
822 (get_frame_param): Now static, unless HAVE_NS.
823 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
824 (x_get_resource_string): Remove; not used.
825 * frame.h (make_terminal_frame, x_report_frame_params):
826 (x_get_resource_string); Remove decls.
827 (x_fullscreen_adjust): Declare only if WINDOWSNT.
828 * lisp.h (get_frame_param): Declare only if HAVE_NS.
829
830 * font.c, fontset.c: Make symbols static if they're not exported.
831 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
832 (FACE_SUITABLE_FOR_CHAR_P): Use it.
833 * font.c (font_close_object): Now static.
834 * font.h (font_close_object): Remove.
835 * fontset.c (FONTSET_OBJLIST): Remove.
836 (free_realized_fontset) #if-0 the body, which does nothing.
837 (face_suitable_for_char_p): #if-0, as it's never called.
838 * fontset.h (face_suitable_for_char_p): Remove decl.
839 * xfaces.c (face_at_string_position): Use
840 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
841 since 0 is always ASCII.
842
843 * fns.c (weak_hash_tables): Now static.
844
845 * fileio.c: Make symbols static if they're not exported.
846 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
847 (Vwrite_region_annotation_buffers): Now static.
848
849 * eval.c: Make symbols static if they're not exported.
850 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
851 * lisp.h (backtrace_list): Remove decl.
852
853 * emacs.c: Make symbols static if they're not exported.
854 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
855 (fatal_error_code, fatal_error_signal_hook, standard_args):
856 Now static.
857 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
858 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
859 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
860 * lisp.h (fatal_error_signal_hook): Remove decl.
861 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
862
863 * editfns.c: Move a (normally-unused) function to its only use.
864 * editfns.c, lisp.h (get_operating_system_release): Remove.
865 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
866 worth the hassle of breaking this out.
867
868 * xterm.c: Make symbols static if they're not exported.
869 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
870 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
871 (x_destroy_window, x_delete_display):
872 Now static.
873 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
874 (x_mouse_leave): Remove; unused.
875 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
876 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
877 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
878 Remove decls.
879 (x_mouse_leave): Declare only if WINDOWSNT.
880 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
881 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
882 USE_X_TOOLKIT.
883
884 * ftxfont.c: Make symbols static if they're not exported.
885 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
886 HAVE_FREETYPE.
887 * font.h (ftxfont_driver): Likewise.
888
889 * xfns.c: Make symbols static if they're not exported.
890 (x_last_font_name, x_display_info_for_name):
891 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
892 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
893 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
894 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
895 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
896 (last_show_tip_args): Now static.
897 (xic_defaut_fontset, xic_create_fontsetname): Define only if
898 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
899 (x_screen_planes): Remove; unused.
900 * dispextern.h (x_screen_planes): Remove decl.
901
902 * dispnew.c: Make symbols static if they're not exported.
903 * dispextern.h (redraw_garbaged_frames, scrolling):
904 (increment_row_positions): Remove.
905 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
906 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
907 Now static.
908 (redraw_garbaged_frames): Remove; unused.
909
910 * xfaces.c: Make symbols static if they're not exported.
911 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
912 Remove decls.
913 * xterm.h (defined_color): Remove decls.
914 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
915 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
916 (menu_face_changed_default, defined_color, free_realized_face):
917 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
918 (ascii_face_of_lisp_face): Remove; unused.
919
920 * xdisp.c: Make symbols static if they're not exported.
921 * dispextern.h (scratch_glyph_row, window_box_edges):
922 (glyph_to_pixel_coords, set_cursor_from_row):
923 (get_next_display_element, set_iterator_to_next):
924 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
925 (show_mouse_face): Remove decls
926 * frame.h (message_buf_print): Likewise.
927 * lisp.h (pop_message, set_message, check_point_in_composition):
928 Likewise.
929 * xterm.h (set_vertical_scroll_bar): Likewise.
930 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
931 (message_buf_print, scratch_glyph_row, displayed_buffer):
932 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
933 (get_next_display_element, show_mouse_face, window_box_edges):
934 (frame_to_window_pixel_xy, check_point_in_composition):
935 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
936 (glyph_to_pixel_coords): Remove; unused.
937
938 * dired.c (file_name_completion): Now static.
939
940 * dbusbind.c (xd_in_read_queued_messages): Now static.
941
942 * lisp.h (circular_list_error, FOREACH): Remove; unused.
943 * data.c (circular_list_error): Remove.
944
945 * commands.h (last_point_position, last_point_position_buffer):
946 (last_point_position_window): Remove decls.
947 * keyboard.c: Make these variables static.
948
949 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
950 decls.
951 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
952 (iso_code_class, detect_coding, code_convert_region): Now static.
953 (encode_coding_gap): Remove; unused.
954
955 * chartab.c (chartab_chars, chartab_bits): Now static.
956
957 * charset.h (charset_iso_8859_1): Remove decl.
958 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
959 Now static.
960
961 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
962 * ccl.c (Vccl_program_table): Now static.
963 (check_ccl_update): Remove; unused.
964
965 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
966 * category.h: ... from here.
967 * category.c (check_category_table, set_category_set): Now static.
968
969 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
970 * lisp.h: Remove these decls.
971
972 * buffer.c (buffer_count): Remove unused var.
973
974 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
975 so that it's not optimized away.
976 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
977 * dispextern.h (bidi_dump_cached_states): Remove, since it's
978 exported only to the debugger.
979
980 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
981 * atimer.h (run_all_atimers): Removed; not exported.
982
983 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
984 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
985 was inaccessible from Lisp.
986 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
987 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
988
989 alloc.c: Import and export fewer symbols, and remove unused items.
990 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
991 is defined.
992 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
993 it's not optimized away by whole-program optimization.
994 (message_enable_multibyte, free_misc): Remove.
995 (catchlist, handlerlist, mark_backtrace):
996 Declare only if BYTE_MARK_STACK.
997 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
998 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
999 (message_enable_multibyte): Remove decl.
1000 (free_misc, interval_free_list, float_block, float_block_index):
1001 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1002 (cons_free_list, last_marked_index):
1003 Now static.
1004 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1005 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1006 (mark_backtrace): Define only if BYTE_MARK_STACK.
1007 * xdisp.c (message_enable_multibyte): Now static.
1008
1009 Declare Lisp_Object Q* variables to be 'static' if not exported.
1010 This makes it easier for human readers (and static analyzers)
1011 to see whether these variables are used from other modules.
1012 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1013 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1014 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1015 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1016 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1017 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1018 * xmenu.c, xselect.c:
1019 Declare Q* vars static if they are not used in other modules.
1020 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1021 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1022 Remove decls of unexported vars.
1023 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1024
1025 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1026
1027 Make Emacs functions such as Fatom 'static' by default.
1028 This makes it easier for human readers (and static analyzers)
1029 to see whether these functions can be called from other modules.
1030 DEFUN now defines a static function. To make the function external
1031 so that it can be used in other C modules, use the new macro DEFUE.
1032 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1033 (Finit_image_library):
1034 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1035 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1036 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1037 Remove decls, since these functions are now static.
1038 (Funintern, Fget_internal_run_time): New decls, since these functions
1039 were already external.
1040
1041 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1042 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1043 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1044 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1045 * keyboard.c, keymap.c, lread.c:
1046 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1047 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1048 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1049 Mark functions with DEFUE instead of DEFUN,
1050 if they are used in other modules.
1051 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1052 decls for now-static functions.
1053 * buffer.h (Fdelete_overlay): Remove decl.
1054 * callproc.c (Fgetenv_internal): Mark as internal.
1055 * composite.c (Fremove_list_of_text_properties): Remove decl.
1056 (Fcomposition_get_gstring): New forward static decl.
1057 * composite.h (Fcomposite_get_gstring): Remove decl.
1058 * dired.c (Ffile_attributes): New forward static decl.
1059 * doc.c (Fdocumntation_property): New forward static decl.
1060 * eval.c (Ffetch_bytecode): New forward static decl.
1061 (Funintern): Remove extern decl; now in .h file where it belongs.
1062 * fileio.c (Fmake_symbolic_link): New forward static decl.
1063 * image.c (Finit_image_library): New forward static decl.
1064 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1065 * intervals.h (Fprevious_property_change):
1066 (Fremove_list_of_text_properties): Remove decls.
1067 * keyboard.c (Fthis_command_keys): Remove decl.
1068 (Fcommand_execute): New forward static decl.
1069 * keymap.c (Flookup_key): New forward static decl.
1070 (Fcopy_keymap): Now static.
1071 * keymap.h (Flookup_key): Remove decl.
1072 * process.c (Fget_process): New forward static decl.
1073 (Fprocess_datagram_address): Mark as internal.
1074 * syntax.c (Fsyntax_table_p): New forward static decl.
1075 (skip_chars): Remove duplicate decl.
1076 * textprop.c (Fprevious_property_change): New forward static decl.
1077 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1078 Now internal.
1079 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1080 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1081
1082 * editfns.c (Fformat): Remove unreachable code.
1083
1084 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1085
1086 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1087 change. (Bug#8496)
1088
1089 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1090
1091 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1092 when at ZV. (Bug#8487)
1093
1094 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1095
1096 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1097 (Bug#8437)
1098 * keyboard.c (parse_tool_bar_item): Likewise.
1099 * sound.c (sound_cleanup, alsa_close): Likewise.
1100 * termcap.c (tgetent): Likewise.
1101 * xfns.c (x_default_font_parameter): Likewise.
1102 * xsettings.c (read_and_apply_settings): Likewise.
1103
1104 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1105 (overrun_check_free): Protoize.
1106
1107 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1108
1109 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1110 since callers should never pass a negative size.
1111 Change the signature to match that of plain 'read' and 'write'; see
1112 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1113 * lisp.h: Update prototypes of emacs_write and emacs_read.
1114
1115 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1116
1117 * xdisp.c (redisplay_window): Don't try to determine the character
1118 position of the scroll margin if the window start point w->startp
1119 is outside the buffer's accessible region. (Bug#8468)
1120
1121 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1122
1123 Fix write-region and its subroutines for buffers > 2GB.
1124 * fileio.c (a_write, e_write): Modify declaration of arguments and
1125 local variables to support buffers larger than 2GB.
1126 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1127
1128 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1129 argument, local variables, and return value.
1130
1131 * lisp.h: Update prototypes of emacs_write and emacs_read.
1132
1133 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1134
1135 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1136
1137 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1138
1139 Fix more problems found by GCC 4.6.0's static checks.
1140
1141 * xdisp.c (vmessage): Use a better test for character truncation.
1142
1143 * charset.c (load_charset_map): <, not <=, for optimization,
1144 and to avoid potential problems with integer overflow.
1145 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1146 * casetab.c (set_identity, shuffle): Likewise.
1147 * editfns.c (Fformat): Likewise.
1148 * syntax.c (skip_chars): Likewise.
1149
1150 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1151 This also lets GCC 4.6.0 generate slightly better loop code.
1152
1153 * callint.c (Fcall_interactively): <, not <=, for optimization.
1154 (Fcall_interactively): Count the number of arguments produced,
1155 not the number of arguments given. This is simpler and lets GCC
1156 4.6.0 generate slightly better code.
1157
1158 * ftfont.c: Distingish more carefully between FcChar8 and char.
1159 The previous code passed unsigned char * to a functions like
1160 strlen and xstrcasecmp that expect char *, which does not
1161 conform to the C standard.
1162 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1163 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1164 char * when the C standard requires it.
1165
1166 * keyboard.c (read_char): Remove unused var.
1167
1168 * eval.c: Port to Windows vsnprintf (Bug#8435).
1169 Include <limits.h>.
1170 (SIZE_MAX): Define if the headers do not.
1171 (verror): Do not give up if vsnprintf returns a negative count.
1172 Instead, grow the buffer. This ports to Windows vsnprintf, which
1173 does not conform to C99. Problem reported by Eli Zaretskii.
1174 Also, simplify the allocation scheme, by avoiding the need for
1175 calling realloc, and removing the ALLOCATED variable.
1176
1177 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1178
1179 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1180 But keep the doprint source code for now, as we might revamp it
1181 and use it again (Bug#8435).
1182 * lisp.h (doprnt): Remove.
1183 * Makefile.in (base_obj): Remove doprnt.o.
1184 * deps.mk (doprnt.o): Remove.
1185
1186 error: Print 32- and 64-bit integers portably (Bug#8435).
1187 Without this change, on typical 64-bit hosts error ("...%d...", N)
1188 was used to print both 32- and 64-bit integers N, which relied on
1189 undefined behavior.
1190 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1191 New macro.
1192 * lisp.h (error, verror): Mark as printf-like functions.
1193 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1194 Report overflow in size calculations when allocating printf buffer.
1195 Do not truncate output string at its first null byte.
1196 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1197 Truncate the output at a character boundary, since vsnprintf does not
1198 do that.
1199 * charset.c (check_iso_charset_parameter): Convert internal
1200 character to string before calling 'error', since %c now has the
1201 printf meaning.
1202 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1203 overflow when computing char to be passed to 'error'. Do not
1204 pass Lisp_Object to 'error'; pass the integer instead.
1205 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1206 formatted with plain %d.
1207
1208 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1209
1210 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1211
1212 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1213
1214 * xterm.c (x_catch_errors): Remove duplicate declaration.
1215
1216 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1217
1218 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1219
1220 2011-04-10 Jim Meyering <meyering@redhat.com>
1221
1222 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1223 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1224 return ssize_t not "int", and use size_t as the buffer length.
1225 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1226 * gnutls.h: Update declarations.
1227 * process.c (read_process_output): Use ssize_t, to match.
1228 (send_process): Likewise.
1229
1230 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1231
1232 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1233
1234 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1235
1236 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1237 unsigned char, to match FcChar8 type definition.
1238
1239 * xterm.c (handle_one_xevent):
1240 * xmenu.c (create_and_show_popup_menu):
1241 * xselect.c (x_decline_selection_request)
1242 (x_reply_selection_request): Avoid type-punned deref of X events.
1243
1244 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1245
1246 Fix some uses of `int' instead of EMACS_INT.
1247 * search.c (string_match_1, fast_string_match)
1248 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1249 (scan_buffer, find_next_newline_no_quit)
1250 (find_before_next_newline, search_command, Freplace_match)
1251 (Fmatch_data): Make some `int' variables be EMACS_INT.
1252
1253 * xdisp.c (display_count_lines): 3rd argument and return value now
1254 EMACS_INT. All callers changed.
1255 (pint2hrstr): Last argument is now EMACS_INT.
1256
1257 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1258 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1259 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1260 (decode_coding_utf_16, decode_coding_emacs_mule)
1261 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1262 (decode_coding_ccl, decode_coding_charset)
1263 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1264 (decode_coding_iso_2022, decode_coding_emacs_mule)
1265 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1266 <char_offset, last_offset>: Declare EMACS_INT.
1267 (encode_coding_utf_8, encode_coding_utf_16)
1268 (encode_coding_emacs_mule, encode_invocation_designation)
1269 (encode_designation_at_bol, encode_coding_iso_2022)
1270 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1271 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1272 Declare EMACS_INT.
1273 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1274 (encode_invocation_designation): Last argument P_NCHARS is now
1275 EMACS_INT.
1276 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1277 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1278
1279 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1280 All users changed.
1281
1282 * ccl.c (Fccl_execute_on_string): Declare some variables
1283 EMACS_INT.
1284
1285 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1286
1287 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1288
1289 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1290
1291 * process.c (Fformat_network_address): Doc fix.
1292
1293 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1294
1295 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1296
1297 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1298
1299 * keyboard.c (read_char): Call Lisp function help-form-show,
1300 instead of using internal_with_output_to_temp_buffer.
1301 (Qhelp_form_show): New var.
1302 (syms_of_keyboard): Use DEFSYM macro.
1303
1304 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1305
1306 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1307
1308 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1309
1310 * process.c (Flist_processes): Removed to Lisp.
1311 (list_processes_1): Deleted.
1312
1313 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1314
1315 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1316
1317 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1318
1319 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 Fix more problems found by GCC 4.6.0's static checks.
1322
1323 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1324
1325 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1326
1327 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1328
1329 * xdisp.c (vmessage): Mark as a printf-like function.
1330
1331 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1332
1333 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1334
1335 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1336 printf-like functions.
1337 (tiff_load): Add casts to remove these marks before passing them
1338 to system-supplied API.
1339
1340 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1341
1342 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1343 This avoids several warnings with gcc -Wstrict-overflow.
1344 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1345 directly, rather than having caller test rule sign. This avoids
1346 some unnecessary tests.
1347 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1348 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1349 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1350
1351 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1352 (xfont_open): Avoid unnecessary tests.
1353
1354 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1355
1356 * composite.h, composite.c (composition_gstring_put_cache):
1357 Use EMACS_INT, not int, for length.
1358
1359 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1360 breaking out part of COMPOSITION_DECODE_RULE.
1361 (COMPOSITION_DECODE_RULE): Use it.
1362 * composite.c (get_composition_id): Remove unused local vars,
1363 by using the new macro.
1364
1365 * textprop.c (set_text_properties_1): Change while to do-while,
1366 since the condition is always true at first.
1367
1368 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1369 (interval_deletion_adjustment): Return unsigned value.
1370 All uses changed.
1371
1372 * process.c (list_processes_1, create_pty, read_process_output):
1373 (exec_sentinel): Remove vars that were set but not used.
1374 (create_pty): Remove unnecessary "volatile"s.
1375 (Fnetwork_interface_info): Avoid possibility of int overflow.
1376 (read_process_output): Do adaptive read buffering even if carryover.
1377 (read_process_output): Simplify nbytes computation if buffered.
1378
1379 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1380
1381 * syntax.c (scan_words): Remove var that was set but not used.
1382 (update_syntax_table): Use unsigned instead of int.
1383
1384 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1385 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1386 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1387
1388 * print.c (print_error_message): Avoid int overflow.
1389
1390 * font.c (font_list_entities): Redo for clarity,
1391 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1392
1393 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1394 (font_score): Avoid potential overflow in diff calculation.
1395
1396 * fns.c (substring_both): Remove var that is set but not used.
1397 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1398
1399 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1400
1401 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1402 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1403 can always succeed if overflow has undefined behavior.
1404
1405 * search.c (boyer_moore, wordify): Remove vars set but not used.
1406 (wordify): Omit three unnecessary tests.
1407
1408 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1409 All callers changed. This avoids the need for an unused var.
1410
1411 * casefiddle.c (casify_region): Remove var that is set but not used.
1412
1413 * dired.c (file_name_completion): Remove var that is set but not used.
1414
1415 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1416
1417 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1418 (Finsert_file_contents): Remove unnecessary code checking fd.
1419
1420 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1421 Check for integer overflow on size calculations.
1422
1423 * buffer.c (Fprevious_overlay_change): Remove var that is set
1424 but not used.
1425
1426 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1427 Remove vars that are set but not used.
1428 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1429 (timer_check_2): Mark vars as initialized.
1430
1431 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1432
1433 * image.c (lookup_image): Remove var that is set but not used.
1434 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1435
1436 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1437 that are set but not used.
1438
1439 * xfns.c (make_invisible_cursor): Don't return garbage
1440 if XCreateBitmapFromData fails (Bug#8410).
1441
1442 * xselect.c (x_get_local_selection, x_handle_property_notify):
1443 Remove vars that are set but not used.
1444
1445 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1446 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1447
1448 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1449 Remove var that is set but not used.
1450 (scroll_bar_windows_size): Now size_t, not int.
1451 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1452 Check for overflow.
1453
1454 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1455 (map_tty_color) [!defined MSDOS]: Likewise.
1456
1457 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1458
1459 * coding.c: Remove vars that are set but not used.
1460 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1461 All callers changed.
1462 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1463 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1464 (decode_coding_charset): Remove vars that are set but not used.
1465
1466 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1467 that is set but not used.
1468
1469 * print.c (print_object): Remove var that is set but not used.
1470
1471 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1472 The gnulib version avoids calling malloc in the usual case,
1473 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1474 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1475 * filelock.c (current_lock_owner): Likewise.
1476 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1477 * sysdep.c: Include allocator.h, careadlinkat.h.
1478 (emacs_no_realloc_allocator): New static constant.
1479 (emacs_readlink): New function.
1480 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1481 ../lib/careadlinkat.h.
1482
1483 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1484
1485 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1486 first non-nil return value).
1487
1488 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1489
1490 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1491 if not defined (Bug#8403).
1492
1493 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1494
1495 * xdisp.c (display_count_lines): Remove parameter `start',
1496 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1497 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1498 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1499 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1500 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1501 and thereabouts. All callers changed.
1502 (get_per_char_metric): Remove parameter `f', unused since
1503 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1504
1505 2011-04-02 Jim Meyering <meyering@redhat.com>
1506
1507 do not dereference NULL upon failed strdup
1508 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1509 (ns_get_family): Likewise.
1510
1511 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1512
1513 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1514
1515 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1516
1517 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1518 later (Bug#8403).
1519
1520 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1521
1522 Add lexical binding.
1523
1524 * window.c (Ftemp_output_buffer_show): New fun.
1525 (Fsave_window_excursion):
1526 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1527
1528 * lread.c (lisp_file_lexically_bound_p): New function.
1529 (Fload): Bind Qlexical_binding.
1530 (readevalloop): Remove `evalfun' arg.
1531 Bind Qinternal_interpreter_environment.
1532 (Feval_buffer): Bind Qlexical_binding.
1533 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1534 Mark as dynamic.
1535 (syms_of_lread): Declare `lexical-binding'.
1536
1537 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1538
1539 * keyboard.c (eval_dyn): New fun.
1540 (menu_item_eval_property): Use it.
1541
1542 * image.c (parse_image_spec): Use Ffunctionp.
1543
1544 * fns.c (concat, mapcar1): Accept byte-code-functions.
1545
1546 * eval.c (Fsetq): Handle lexical vars.
1547 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1548 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1549 (FletX, Flet): Obey lexical binding.
1550 (Fcommandp): Handle closures.
1551 (Feval): New `lexical' arg.
1552 (eval_sub): New function extracted from Feval. Use it almost
1553 everywhere where Feval was used. Look up vars in lexical env.
1554 Handle closures.
1555 (Ffunctionp): Move from subr.el.
1556 (Ffuncall): Handle closures.
1557 (apply_lambda): Remove `eval_flags'.
1558 (funcall_lambda): Handle closures and new byte-code-functions.
1559 (Fspecial_variable_p): New function.
1560 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1561 but without exporting it to Lisp.
1562
1563 * doc.c (Fdocumentation, store_function_docstring):
1564 * data.c (Finteractive_form): Handle closures.
1565
1566 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1567 interactive spec.
1568
1569 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1570 byte-codes.
1571 (exec_byte_code): New function extracted from Fbyte_code to handle new
1572 calling convention for byte-code-functions. Add new byte-codes.
1573
1574 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1575
1576 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1577
1578 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1579
1580 * xdisp.c (redisplay_internal): Fix prototype.
1581
1582 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1583
1584 * xdisp.c (SCROLL_LIMIT): New macro.
1585 (try_scrolling): Use it when setting scroll_limit. Limit
1586 scrolling to 100 screen lines.
1587 (redisplay_window): Even when falling back on "recentering",
1588 position point in the window according to scroll-conservatively,
1589 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1590
1591 (try_scrolling): When point is above the window, allow searching
1592 as far as scroll_max, or one screenful, to compute vertical
1593 distance from PT to the scroll margin position. This prevents
1594 try_scrolling from unnecessarily failing when
1595 scroll-conservatively is set to a value slightly larger than the
1596 window height. Clean up the case of PT below the margin at bottom
1597 of window: scroll_max can no longer be INT_MAX. When aggressive
1598 scrolling is in use, don't let point enter the opposite scroll
1599 margin as result of the scroll.
1600 (syms_of_xdisp) <scroll-conservatively>: Document the
1601 threshold of 100 lines for never-recentering scrolling.
1602
1603 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1604
1605 * dispextern.h (move_it_by_lines):
1606 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1607 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1608 (message_log_check_duplicate): Remove parameters `prev_bol' and
1609 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1610 (redisplay_internal): Remove parameter `preserve_echo_area',
1611 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1612
1613 * indent.c (Fvertical_motion):
1614 * window.c (window_scroll_pixel_based, Frecenter):
1615 Don't pass `need_y_p' to `move_it_by_lines'.
1616
1617 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1618
1619 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1620 steal a few bits to be more compact.
1621 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1622 Remove unneeded casts.
1623
1624 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1625
1626 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1627
1628 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1629 binding" message (bug#7967).
1630
1631 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 Fix more problems found by GCC 4.6.0's static checks.
1634
1635 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1636 Remove unused local var.
1637
1638 * editfns.c (Fmessage_box): Remove unused local var.
1639
1640 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1641 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1642 Omit unused local vars.
1643 * window.c (shrink_windows): Omit unused local var.
1644 * menu.c (digest_single_submenu): Omit unused local var.
1645 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1646 Omit unused local var.
1647
1648 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1649 Don't assume string length fits in int.
1650 (keyremap_step, read_key_sequence): Use size_t for sizes.
1651 (read_key_sequence): Don't check last_real_key_start redundantly.
1652
1653 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1654 instead of alloca (Bug#8344).
1655
1656 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1657 (Fbacktrace_frame): Don't assume nframes fits in int.
1658
1659 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1660
1661 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1662 concerns.
1663
1664 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1665
1666 * cm.c (calccost): Turn while-do into do-while, for clarity.
1667
1668 * keyboard.c (syms_of_keyboard): Use the same style as later
1669 in this function when indexing through an array. This also
1670 works around GCC bug 48267.
1671
1672 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1673
1674 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1675
1676 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1677 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1678
1679 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1680 This avoids undefined behavior on integer overflow, and is a bit
1681 more convenient anyway since it is compared to a size_t variable.
1682
1683 Variadic C functions now count arguments with size_t, not int.
1684 This avoids an unnecessary limitation on 64-bit machines, which
1685 caused (substring ...) to crash on large vectors (Bug#8344).
1686 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1687 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1688 All variadic functions and their callers changed accordingly.
1689 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1690 * data.c (arith_driver, float_arith_driver): Likewise.
1691 * editfns.c (general_insert_function): Likewise.
1692 * eval.c (struct backtrace.nargs, interactive_p)
1693 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1694 (funcall_lambda, mark_backtrace): Likewise.
1695 * fns.c (concat): Likewise.
1696 * frame.c (x_set_frame_parameters): Likewise.
1697 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1698 0 if not found, not -1. All callers changed.
1699
1700 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1701 (stack_copy_size): Now size_t, not int.
1702 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1703
1704 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1705
1706 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1707 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1708 All callers changed.
1709
1710 * lisp.h (multibyte_char_to_unibyte):
1711 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1712 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1713 * character.h (CHAR_TO_BYTE8):
1714 * cmds.c (internal_self_insert):
1715 * editfns.c (general_insert_function):
1716 * keymap.c (push_key_description):
1717 * search.c (Freplace_match):
1718 * xdisp.c (message_dolog, set_message_1): All callers changed.
1719
1720 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1721
1722 * keyboard.c (safe_run_hook_funcall): New function.
1723 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1724 don't set the hook to nil, but remove the offending function instead.
1725 (Qcommand_hook_internal): Remove, unused.
1726 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1727 Vcommand_hook_internal.
1728
1729 * eval.c (enum run_hooks_condition): Remove.
1730 (funcall_nil, funcall_not): New functions.
1731 (run_hook_with_args): Call each function through a `funcall' argument.
1732 Remove `cond' argument, now redundant.
1733 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1734 (Frun_hook_with_args_until_failure): Adjust accordingly.
1735 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1736
1737 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1738
1739 * dispextern.h (string_buffer_position): Remove declaration.
1740
1741 * print.c (strout): Remove parameter `multibyte', unused since
1742 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1743
1744 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1745 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1746 All callers changed.
1747
1748 * w32.c (_wsa_errlist): Use braces for struct initializers.
1749
1750 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1751 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1752 All callers changed.
1753 (string_buffer_position): Likewise. Also, make static (it's never
1754 used outside xdisp.c).
1755 (cursor_row_p): Remove parameter `w', unused since
1756 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1757 (decode_mode_spec): Remove parameter `precision', introduced during
1758 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1759 All callers changed.
1760
1761 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1762
1763 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1764
1765 2011-03-27 Anders Lindgren <andlind@gmail.com>
1766
1767 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1768 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1769 (ns_update_auto_hide_menu_bar): New functions.
1770 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1771 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1772 ns_constrain_all_frames.
1773 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1774 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1775
1776 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1777
1778 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1779
1780 2011-03-27 Glenn Morris <rgm@gnu.org>
1781
1782 * syssignal.h: Replace RETSIGTYPE with void.
1783 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1784 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1785 Replace SIGTYPE with void everywhere.
1786 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1787 * s/template.h (SIGTYPE): Remove commented out definition.
1788
1789 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1790
1791 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1792 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1793
1794 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1795
1796 * w32.c (read_unc_volume): Use parameter `henum', instead of
1797 global variable `wget_enum_handle'.
1798
1799 * keymap.c (describe_vector): Remove parameters `indices' and
1800 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1801 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1802
1803 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1804
1805 * keyboard.c (timer_check): Remove parameter `do_it_now',
1806 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1807 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1808 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1809
1810 * keyboard.c (read_char):
1811 * w32menu.c (w32_menu_display_help):
1812 * xmenu.c (show_help_event, menu_help_callback):
1813 Adjust calls to `show_help_echo'.
1814
1815 * gtkutil.c (xg_maybe_add_timer):
1816 * keyboard.c (readable_events):
1817 * process.c (wait_reading_process_output):
1818 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1819
1820 * insdel.c (adjust_markers_gap_motion):
1821 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1822 (gap_left, gap_right): Don't call it.
1823
1824 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1825
1826 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1827 incurred during fontification.
1828
1829 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1830
1831 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1832 (DEFVAR_PER_BUFFER): Don't pass it.
1833
1834 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1835 (scrolling_window): Don't pass it.
1836
1837 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1838
1839 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1840
1841 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1842 and `suffix'.
1843 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1844 of variables specific to SELinux and computation of `encoded_absname'.
1845
1846 * image.c (XPutPixel): Remove unused variable `height'.
1847
1848 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1849
1850 * unexw32.c (get_section_info): Remove unused variable `section'.
1851
1852 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1853 (system_process_attributes): Remove unused variable `sess'.
1854 (sys_read): Remove unused variable `err'.
1855
1856 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1857 (w32_wnd_proc): Remove unused variable `isdead'.
1858 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1859 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1860 (x_create_tip_frame): Remove unused variable `tem'.
1861
1862 * w32inevt.c (w32_console_read_socket):
1863 Remove unused variable `no_events'.
1864
1865 * w32term.c (x_draw_composite_glyph_string_foreground):
1866 Remove unused variable `width'.
1867
1868 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1869
1870 * w32term.c (x_set_glyph_string_clipping):
1871 Don't pass uninitialized region to CombineRgn.
1872
1873 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1874
1875 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1876 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1877 (Fx_close_connection): Remove unused variable `i'.
1878
1879 * w32font.c (w32font_draw): Return number of glyphs.
1880 (w32font_open_internal): Remove unused variable `i'.
1881 (w32font_driver): Add missing initializer.
1882
1883 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1884 (fill_in_menu): Remove unused variable `items_added'.
1885
1886 * w32term.c (last_mouse_press_frame): Remove static global variable.
1887 (w32_clip_to_row): Remove unused variable `f'.
1888 (x_delete_terminal): Remove unused variable `i'.
1889
1890 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1891 (NOTHING): Remove unused static global variable.
1892 (uniscribe_check_otf): Remove unused variable `table'.
1893 (uniscribe_font_driver): Add missing initializers.
1894
1895 2011-03-23 Julien Danjou <julien@danjou.info>
1896
1897 * term.c (Fsuspend_tty, Fresume_tty):
1898 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1899 * window.c (temp_output_buffer_show):
1900 * insdel.c (signal_before_change):
1901 * frame.c (Fhandle_switch_frame):
1902 * fileio.c (Fdo_auto_save):
1903 * emacs.c (Fkill_emacs):
1904 * editfns.c (save_excursion_restore):
1905 * cmds.c (internal_self_insert):
1906 * callint.c (Fcall_interactively):
1907 * buffer.c (Fkill_all_local_variables):
1908 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1909 Use Frun_hooks.
1910 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1911 unconditionnaly since it does the check itself.
1912
1913 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 Fix more problems found by GCC 4.5.2's static checks.
1916
1917 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1918 the first time through the loop, since we know p0 < p1 then.
1919 This also avoids a gcc -Wstrict-overflow warning.
1920
1921 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1922 leading to a memory leak, possible in functions like
1923 load_charset_map_from_file that can allocate an unbounded number
1924 of objects (Bug#8318).
1925
1926 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1927 that could (at least in theory) be that large.
1928
1929 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1930 This is less likely to overflow, and avoids undefined behavior if
1931 overflow does occur. All callers changed. Use strtoul to scan
1932 for the unsigned long integer.
1933 (pint2hrstr): Simplify and tune code slightly.
1934 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1935
1936 * scroll.c (do_scrolling): Work around GCC bug 48228.
1937 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1938
1939 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1940 This also avoids a warning with gcc -Wstrict-overflow.
1941 (validate_x_resource_name): Simplify count usage.
1942 This also avoids a warning with gcc -Wstrict-overflow.
1943
1944 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1945 fail (Bug#8306).
1946
1947 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1948
1949 * process.c (Fmake_network_process): Use socklen_t, not int,
1950 where POSIX says socklen_t is required in portable programs.
1951 This fixes a porting bug on hosts like 64-bit HP-UX, where
1952 socklen_t is wider than int (Bug#8277).
1953 (Fmake_network_process, server_accept_connection):
1954 (wait_reading_process_output, read_process_output):
1955 Likewise.
1956
1957 * process.c: Rename or move locals to avoid shadowing.
1958 (list_processes_1, Fmake_network_process):
1959 (read_process_output_error_handler, exec_sentinel_error_handler):
1960 Rename or move locals.
1961 (Fmake_network_process): Define label "retry_connect" only if needed.
1962 (Fnetwork_interface_info): Fix pointer signedness.
1963 (process_send_signal): Add cast to avoid pointer signedness problem.
1964 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1965 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1966
1967 Make tparam.h and terminfo.c consistent.
1968 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1969 Include tparam.h instead, since it declares them.
1970 * cm.h (PC): Remove extern decl; tparam.h now does this.
1971 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1972 * terminfo.c: Include tparam.h, to check interfaces.
1973 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1974 (tparam): Adjust signature to match interface in tparam.h;
1975 this removes some undefined behavior. Check that outstring and len
1976 are zero, which they always are with Emacs.
1977 * tparam.h (PC, BC, UP): New extern decls.
1978
1979 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1980 (xftfont_open): Rename locals to avoid shadowing.
1981
1982 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1983 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1984 (OTF_TAG_SYM): Omit macro if not needed.
1985 (ftfont_list): Remove unused local.
1986 (get_adstyle_property, ftfont_pattern_entity):
1987 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1988 Rename locals to avoid shadowing.
1989
1990 * xfont.c (xfont_list_family): Mark var as initialized.
1991
1992 * xml.c (make_dom): Now static.
1993
1994 * composite.c (composition_compute_stop_pos): Rename local to
1995 avoid shadowing.
1996 (composition_reseat_it): Remove unused locals.
1997 (find_automatic_composition, composition_adjust_point): Likewise.
1998 (composition_update_it): Mark var as initialized.
1999 (find_automatic_composition): Mark vars as initialized,
2000 with a FIXME (Bug#8290).
2001
2002 character.h: Rename locals to avoid shadowing.
2003 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2004 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2005 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2006 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2007 to avoid shadowing.
2008
2009 * textprop.c (property_change_between_p): Remove; unused.
2010
2011 * intervals.c (interval_start_pos): Now static.
2012
2013 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2014
2015 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2016 Rename locals to avoid shadowing.
2017
2018 * sound.c (wav_play, au_play, Fplay_sound_internal):
2019 Fix pointer signedness.
2020 (alsa_choose_format): Remove unused local var.
2021 (wav_play): Initialize a variable to 0, to prevent undefined
2022 behavior (Bug#8278).
2023
2024 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2025
2026 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2027
2028 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2029 clobbering (Bug#8298).
2030 * sysdep.c (sys_subshell): Likewise.
2031 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2032
2033 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2034 This should get cleaned up, so that child_setup has the
2035 same signature on all platforms.
2036
2037 * callproc.c (call_process_cleanup): Now static.
2038 (relocate_fd): Rename locals to avoid shadowing.
2039
2040 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2041
2042 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2043 not to be necessary, and produces flickering.
2044
2045 2011-03-20 Glenn Morris <rgm@gnu.org>
2046
2047 * config.in: Remove file.
2048
2049 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2050
2051 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2052 are now in src/globals.h.
2053 (syms_of_minibuf): Remove spurious & from previous change.
2054
2055 2011-03-20 Leo <sdl.web@gmail.com>
2056
2057 * minibuf.c (completing-read-function): New variable.
2058 (completing-read-default): Rename from completing-read.
2059 (completing-read): Call completing-read-function.
2060
2061 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2062
2063 * xfaces.c (Fx_load_color_file):
2064 Read color file from absolute filename (bug#8250).
2065
2066 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2067
2068 * makefile.w32-in: Update dependencies.
2069
2070 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2071
2072 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2073
2074 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2075
2076 Fix more problems found by GCC 4.5.2's static checks.
2077
2078 * process.c (make_serial_process_unwind, send_process_trap):
2079 (sigchld_handler): Now static.
2080
2081 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2082 That way, the code declares only the vars that it needs.
2083 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2084 * s/cygwin.h (PTY_ITERATION): Likewise.
2085 * s/darwin.h (PTY_ITERATION): Likewise.
2086 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2087
2088 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2089 * process.c (allocate_pty): Don't declare stb unless it's needed.
2090
2091 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2092 (CONSTANTLIM): Remove; unused.
2093 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2094 Define only if needed.
2095
2096 * unexelf.c (unexec): Name an expression,
2097 to avoid gcc -Wbad-function-cast warning.
2098 Use a different way to cause a compilation error if anyone uses
2099 n rather than nn, a way that does not involve shadowing.
2100 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2101
2102 * deps.mk (unexalpha.o): Remove; unused.
2103
2104 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2105 * unexec.h: New file.
2106 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2107 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2108 Depend on unexec.h.
2109 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2110 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2111 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2112 Change as necessary to match prototype in unexec.h.
2113
2114 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2115 shadowing.
2116 (back_comment, skip_chars): Mark vars as initialized.
2117
2118 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2119 Rename locals to avoid shadowing.
2120
2121 * lread.c (read1): Rewrite so as not to use empty "else".
2122 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2123
2124 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2125
2126 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2127 warning when compiling print.c.
2128
2129 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2130 instead of using an uninitialized var.
2131 (font_sort_entities): Mark var as initialized.
2132
2133 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2134
2135 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2136 pointers to constants.
2137 (font_parse_fcname): Remove unused vars.
2138 (font_delete_unmatched): Now static.
2139 (font_get_spec): Remove; unused.
2140 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2141 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2142 Rename or move locals to avoid shadowing.
2143
2144 * fns.c (require_nesting_list, require_unwind): Now static.
2145 (Ffillarray): Rename locals to avoid shadowing.
2146
2147 * floatfns.c (domain_error2): Define only if needed.
2148 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2149
2150 * alloc.c (mark_backtrace): Move decl from here ...
2151 * lisp.h: ... to here, so that it can be checked.
2152
2153 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2154 (Fdefvar): Rewrite so as not to use empty "else".
2155 (lisp_indirect_variable): Name an expression,
2156 to avoid gcc -Wbad-function-cast warning.
2157 (Fdefvar): Rename locals to avoid shadowing.
2158
2159 * callint.c (quotify_arg, quotify_args): Now static.
2160 (Fcall_interactively): Rename locals to avoid shadowing.
2161 Use const pointer when appropriate.
2162
2163 * lisp.h (get_system_name, get_operating_system_release):
2164 Move decls here, to check interfaces.
2165 * process.c (get_operating_system_release): Move decl to lisp.h.
2166 * xrdb.c (get_system_name): Likewise.
2167 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2168 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2169 some of which prompt warnings from gcc -Wbad-function-cast.
2170 (Fformat_time_string, Fencode_time, Finsert_char):
2171 (Ftranslate_region_internal, Fformat):
2172 Rename or remove local vars to avoid shadowing.
2173 (Ftranslate_region_internal): Mark var as initialized.
2174
2175 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2176 avoid shadowing.
2177
2178 * lisp.h (eassert): Check that the argument compiles, even if
2179 ENABLE_CHECKING is not defined.
2180
2181 * data.c (Findirect_variable): Name an expression, to avoid
2182 gcc -Wbad-function-cast warning.
2183 (default_value, arithcompare, arith_driver, arith_error): Now static.
2184 (store_symval_forwarding): Rename local to avoid shadowing.
2185 (Fmake_variable_buffer_local, Fmake_local_variable):
2186 Mark variables as initialized.
2187 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2188
2189 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2190 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2191 Rename locals to avoid shadowing.
2192 (mark_stack): Move local variables into the #ifdef region where
2193 they're used.
2194 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2195 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2196 needed otherwise.
2197 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2198 (GC_STRING_CHARS): Remove; not used.
2199 (Fmemory_limit): Cast sbrk's returned value to char *.
2200
2201 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2202 avoids undefined behavior in theory.
2203
2204 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2205
2206 Use functions, not macros, for up- and down-casing (Bug#8254).
2207 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2208 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2209 to use the following functions instead of these macros.
2210 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2211 EMACS_INT, since callers assume the returned value fits in int.
2212 (upcase1): Likewise, for UPCASE_TABLE.
2213 (uppercasep, lowercasep, upcase): New static inline functions.
2214 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2215 the race-condition problem in the old DOWNCASE.
2216
2217 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2218 Rename locals to avoid shadowing.
2219 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2220 (regex_compile, re_search_2, re_match_2_internal):
2221 Remove unused local vars.
2222 (FREE_VAR): Rewrite so as not to use empty "else",
2223 which gcc can warn about.
2224 (regex_compile, re_match_2_internal): Mark locals as initialized.
2225 (RETALLOC_IF): Define only if needed.
2226 (WORDCHAR_P): Likewise. This one is never needed, but is used
2227 only in a comment talking about a compiler bug, so put inside
2228 the #if 0 of that comment.
2229 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2230 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2231 Remove; unused.
2232
2233 * search.c (boyer_moore): Rename locals to avoid shadowing.
2234 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2235 (PREV_CHAR_BOUNDARY): Likewise.
2236
2237 * search.c (simple_search): Remove unused var.
2238
2239 * dired.c (compile_pattern): Move decl from here ...
2240 * lisp.h: ... to here, so that it can be checked.
2241 (struct re_registers): New forward decl.
2242
2243 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2244
2245 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2246 All uses changed.
2247 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2248 Rename locals to avoid shadowing.
2249 (Fvertical_motion): Mark locals as initialized.
2250
2251 * casefiddle.c (casify_object, casify_region): Now static.
2252 (casify_region): Mark local as initialized.
2253
2254 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2255
2256 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2257 New macros, so that the caller can use some names other than
2258 gcpro1, gcpro2, etc.
2259 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2260 of the new macros.
2261 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2262 argument, for consistency with GCPRO2_VAR, etc: it is now the
2263 prefix of the variable, not the variable itself. All uses
2264 changed.
2265 * dired.c (directory_files_internal, file_name_completion):
2266 Rename locals to avoid shadowing.
2267
2268 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2269 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2270 dired.c's scmp function, had undefined behavior.
2271 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2272 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2273 * buffer.h: ... to here, because these macros use current_buffer,
2274 and the new implementation with inline functions needs to have
2275 current_buffer in scope now, rather than later when the macros
2276 are used.
2277 (downcase, upcase1): New static inline functions.
2278 (DOWNCASE, UPCASE1): Reimplement using these functions.
2279 This avoids undefined behavior in expressions like
2280 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2281 from race conditions in accessing the global variables
2282 case_temp1 and case_temp2.
2283 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2284 * lisp.h (case_temp1, case_temp2): Remove their decls.
2285 * character.h (ASCII_CHAR_P): Move from here ...
2286 * lisp.h: ... to here, so that the inline functions mentioned
2287 above can use them.
2288
2289 * dired.c (directory_files_internal_unwind): Now static.
2290
2291 * fileio.c (file_name_as_directory, directory_file_name):
2292 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2293 Now static.
2294 (file_name_as_directory): Use const pointers when appropriate.
2295 (Fexpand_file_name): Likewise. In particular, newdir might
2296 point at constant storage, so make it a const pointer.
2297 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2298 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2299 signedness issues.
2300 (Fset_file_times, Finsert_file_contents, auto_save_error):
2301 Rename locals to avoid shadowing.
2302
2303 * minibuf.c (choose_minibuf_frame_1): Now static.
2304 (Ftry_completion, Fall_completions): Rename or remove locals
2305 to avoid shadowing.
2306
2307 * marker.c (bytepos_to_charpos): Remove; unused.
2308
2309 * lisp.h (verify_bytepos, count_markers): New decls,
2310 so that gcc does not warn that these functions aren't declared.
2311
2312 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2313 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2314 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2315 (copy_text): Remove unused local var.
2316
2317 * filelock.c (within_one_second): Now static.
2318 (lock_file_1): Rename local to avoid shadowing.
2319
2320 * buffer.c (fix_overlays_before): Mark locals as initialized.
2321 (fix_start_end_in_overlays): Likewise. This function should be
2322 simplified by using pointers-to-pointers, but that's a different
2323 matter.
2324 (switch_to_buffer_1): Now static.
2325 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2326 (report_overlay_modification): Rename locals to avoid shadowing.
2327
2328 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2329 Fix pointer signedness issue.
2330 (sys_subshell): Mark local as volatile if checking for lint,
2331 to suppress a gcc -Wclobbered warning that does not seem to be right.
2332 (MAXPATHLEN): Define only if needed.
2333
2334 * process.c (serial_open, serial_configure): Move decls from here ...
2335 * systty.h: ... to here, so that they can be checked.
2336
2337 * fns.c (get_random, seed_random): Move extern decls from here ...
2338 * lisp.h: ... to here, so that they can be checked.
2339
2340 * sysdep.c (reset_io): Now static.
2341 (wait_for_termination_signal): Remove; unused.
2342
2343 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2344 (copy_keymap_item, append_key, push_text_char_description):
2345 Now static.
2346 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2347 (DENSE_TABLE_SIZE): Remove; unused.
2348 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2349 (describe_map_tree):
2350 Rename locals to avoid shadowing.
2351
2352 * keyboard.c: Declare functions static if they are not used elsewhere.
2353 (echo_char, echo_dash, cmd_error, top_level_2):
2354 (poll_for_input, handle_async_input): Now static.
2355 (read_char, kbd_buffer_get_event, make_lispy_position):
2356 (make_lispy_event, make_lispy_movement, apply_modifiers):
2357 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2358 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2359 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2360 (read_key_sequence, read_char): Mark locals as initialized.
2361 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2362
2363 * keyboard.h (make_ctrl_char): New decl.
2364 (mark_kboards): Move decl here ...
2365 * alloc.c (mark_kboards): ... from here.
2366
2367 * lisp.h (force_auto_save_soon): New decl.
2368
2369 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2370 (DEFINE_DUMMY_FUNCTION): New macro.
2371 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2372 Use it.
2373 (main): Add casts to avoid warnings
2374 if GCC considers string literals to be constants.
2375
2376 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2377
2378 * dbusbind.c: Pointer signedness fixes.
2379 (xd_signature, xd_append_arg, xd_initialize):
2380 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2381 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2382 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2383 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2384
2385 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2386 if GCC considers string literals to be constants.
2387 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2388
2389 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2390
2391 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2392 (print_preprocess, print_object): New macro to fix last change.
2393
2394 * print.c (print_preprocess): Don't forget font objects.
2395
2396 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2397
2398 * emacs.c (USAGE3): Doc fixes.
2399
2400 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2401
2402 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2403 structure.
2404
2405 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2406
2407 * lisp.h (VWindow_system, Qfile_name_history):
2408 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2409 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2410 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2411
2412 * w32select.c: Don't #include "keyboard.h".
2413 (run_protected): Add extern declaration for waiting_for_input.
2414
2415 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2416 * w32console.c (detect_input_pending, read_input_pending)
2417 (encode_terminal_code):
2418 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2419 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2420 (w32_system_caret_y, Qfile_name_history):
2421 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2422 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2423 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2424 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2425 * w32proc.c (Qlocal, report_file_error):
2426 * w32term.c (Vwindow_system, updating_frame):
2427 * w32uniscribe.c (initialized, uniscribe_font_driver):
2428 Remove unneeded extern declarations.
2429
2430 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2431
2432 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2433
2434 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2435
2436 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2437 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2438 These macros can no longer be used for assignment.
2439
2440 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2441 Assign struct members directly, instead of using BUF_BEGV etc.
2442 (record_buffer_markers, fetch_buffer_markers): New functions for
2443 recording and fetching special buffer markers.
2444 (set_buffer_internal_1, set_buffer_temp): Use them.
2445
2446 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2447
2448 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2449
2450 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2451 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2452
2453 * xdisp.c (hscroll_window_tree):
2454 (reconsider_clip_changes): Use PT instead of BUF_PT.
2455
2456 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2457
2458 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2459 $(EMACS_ROOT)/lib/intprops.h.
2460
2461 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2462
2463 Fix more problems found by GCC 4.5.2's static checks.
2464
2465 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2466 to unsigned char * to avoid compiler diagnostic.
2467 (xg_free_frame_widgets): Make it clear that a local variable is
2468 needed only if USE_GTK_TOOLTIP.
2469 (gdk_window_get_screen): Make it clear that this macro is needed
2470 only if USE_GTK_TOOLTIP.
2471 (int_gtk_range_get_value): New function, which avoids a diagnostic
2472 from gcc -Wbad-function-cast.
2473 (xg_set_toolkit_scroll_bar_thumb): Use it.
2474 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2475 diagnostic from gcc -Wbad-function-cast.
2476 (get_utf8_string, xg_get_file_with_chooser):
2477 Rename locals to avoid shadowing.
2478 (create_dialog): Move locals to avoid shadowing.
2479
2480 * xgselect.c (xg_select): Remove unused var.
2481
2482 * image.c (four_corners_best): Mark locals as initialized.
2483 (gif_load): Initialize transparent_p to zero (Bug#8238).
2484 Mark another local as initialized.
2485 (my_png_error, my_error_exit): Mark with NO_RETURN.
2486
2487 * image.c (clear_image_cache): Now static.
2488 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2489 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2490 (x_edge_detection): Remove unnecessary cast that
2491 gcc -Wbad-function-cast diagnoses.
2492 (gif_load): Fix pointer signedness.
2493 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2494 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2495
2496 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2497
2498 Improve quality of tests for time stamp overflow.
2499 For example, without this patch (encode-time 0 0 0 1 1
2500 1152921504606846976) returns the obviously-bogus value (-948597
2501 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2502 reports time overflow. See
2503 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2504 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2505 * editfns.c: Include limits.h and intprops.h.
2506 (TIME_T_MIN, TIME_T_MAX): New macros.
2507 (time_overflow): Move earlier, to before first use.
2508 (hi_time, lo_time): New functions, for an accurate test for
2509 out-of-range times.
2510 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2511 (Fget_internal_run_time): Don't assume time_t fits in int.
2512 (make_time): Use list2 instead of Fcons twice.
2513 (Fdecode_time): More accurate test for out-of-range times.
2514 (check_tm_member): New function.
2515 (Fencode_time): Use it, to test for out-of-range times.
2516 (lisp_time_argument): Don't rely on undefined left-shift and
2517 right-shift behavior when checking for time stamp overflow.
2518
2519 * editfns.c (time_overflow): New function, refactoring common code.
2520 (Fformat_time_string, Fdecode_time, Fencode_time):
2521 (Fcurrent_time_string): Use it.
2522
2523 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2524 * dired.c (make_time): Move to ...
2525 * editfns.c (make_time): ... here.
2526 * systime.h: Note the move.
2527
2528 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2529
2530 * fringe.c (update_window_fringes): Remove unused variables.
2531
2532 * unexmacosx.c (copy_data_segment): Also copy __got section.
2533 (Bug#8223)
2534
2535 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2536
2537 * termcap.c [MSDOS]: Include "msdos.h".
2538 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2539 Constify `char *' arguments and their references according to
2540 prototypes in tparam.h.
2541
2542 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2543
2544 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2545 Adapt all references accordingly.
2546
2547 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2548
2549 2011-03-11 Tom Tromey <tromey@redhat.com>
2550
2551 * buffer.c (syms_of_buffer): Remove obsolete comment.
2552
2553 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2554
2555 * termhooks.h (encode_terminal_code): Declare prototype.
2556
2557 * msdos.c (encode_terminal_code): Don't declare prototype.
2558
2559 * term.c (encode_terminal_code): Now external again, used by
2560 w32console.c and msdos.c.
2561
2562 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2563 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2564
2565 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2566
2567 Fix some minor problems found by GCC 4.5.2's static checks.
2568
2569 * fringe.c (update_window_fringes): Mark locals as initialized
2570 (Bug#8227).
2571 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2572
2573 * alloc.c (mark_fringe_data): Move decl from here ...
2574 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2575 to check its interface.
2576 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2577
2578 * fontset.c (free_realized_fontset): Now static.
2579 (Fset_fontset_font): Rename local to avoid shadowing.
2580 (fontset_font): Mark local as initialized.
2581 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2582
2583 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2584
2585 * xselect.c (x_disown_buffer_selections): Remove; not used.
2586 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2587 (x_own_selection, Fx_disown_selection_internal): Rename locals
2588 to avoid shadowing.
2589 (x_handle_dnd_message): Remove local to avoid shadowing.
2590
2591 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2592 so that the caller can use some name other than gcpro1.
2593 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2594 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2595 (Fx_backspace_delete_keys_p):
2596 Use them to avoid shadowing, and rename vars to avoid shadowing.
2597 (x_decode_color, x_set_name, x_window): Now static.
2598 (Fx_create_frame): Add braces to silence GCC warning.
2599 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2600 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2601 Remove unused locals.
2602 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2603 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2604 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2605 macros.
2606
2607 * xterm.h (x_mouse_leave): New decl.
2608
2609 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2610 Remove unused functions.
2611 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2612 (x_calc_absolute_position): Now static.
2613 (XTread_socket): Don't define label "out" unless it's used.
2614 Don't declare local "event" unless it's used.
2615 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2616 unless they are used.
2617 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2618 (x_fatal_error_signal): Remove; not used.
2619 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2620 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2621 (x_error_catcher, x_connection_closed, x_error_handler):
2622 (x_error_quitter, xembed_send_message, x_iconify_frame):
2623 (my_log_handler): Rename locals to avoid shadowing.
2624 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2625 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2626
2627 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2628 Rename or move locals to avoid shadowing.
2629 (tty_defined_color, merge_face_heights): Now static.
2630 (free_realized_faces_for_fontset): Remove; not used.
2631 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2632 does not deduce is never used uninitialized.
2633 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2634 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2635
2636 * terminal.c (store_terminal_param): Now static.
2637
2638 * xmenu.c (menu_highlight_callback): Now static.
2639 (set_frame_menubar): Remove unused local.
2640 (xmenu_show): Rename parameter to avoid shadowing.
2641 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2642 since they might point to immutable storage.
2643 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2644 since it's unused otherwise.
2645
2646 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2647 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2648 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2649 avoids a gcc -Wuninitialized diagnostic.
2650 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2651 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2652 does not deduce are never used uninitialized.
2653
2654 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2655
2656 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2657 * window.c (window_loop, size_window):
2658 (run_window_configuration_change_hook, enlarge_window): Likewise.
2659
2660 * window.c (display_buffer): Now static.
2661 (size_window): Mark variables that gcc -Wuninitialized
2662 does not deduce are never used uninitialized.
2663 * window.h (check_all_windows): New decl, to forestall
2664 gcc -Wmissing-prototypes diagnostic.
2665 * dispextern.h (bidi_dump_cached_states): Likewise.
2666
2667 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2668 shadowing.
2669 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2670 Include <limits.h>.
2671 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2672 and to avoid gcc -Wuninitialized warning.
2673 (load_charset_map): Mark variables that gcc -Wuninitialized
2674 does not deduce are never used uninitialized.
2675 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2676
2677 * coding.c (coding_set_source, coding_set_destination):
2678 Use "else { /* comment */ }" rather than "else /* comment */;"
2679 for clarity, and to avoid gcc -Wempty-body warning.
2680 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2681 a block, when the outer 'i' will do.
2682 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2683 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2684 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2685 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2686 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2687 Rename locals to avoid shadowing.
2688 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2689 * coding.c (emacs_mule_char, encode_invocation_designation):
2690 Now static, since they're not used elsewhere.
2691 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2692 (decode_coding_object, encode_coding_object, detect_coding_system):
2693 (decode_coding_emacs_mule): Mark variables that gcc
2694 -Wuninitialized does not deduce are never used uninitialized.
2695 (detect_coding_iso_2022): Initialize a local variable that might
2696 be used uninitialized. Leave a FIXME because it's not clear that
2697 this initialization is needed. (Bug#8211)
2698 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2699 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2700 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2701 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2702 Remove unused macros.
2703
2704 * category.c (hash_get_category_set): Remove unused local var.
2705 (copy_category_table): Now static, since it's not used elsewhere.
2706 * character.c (string_count_byte8): Likewise.
2707
2708 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2709 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2710
2711 * chartab.c (copy_sub_char_table): Now static, since it's not used
2712 elsewhere.
2713 (sub_char_table_ref_and_range, char_table_ref_and_range):
2714 Rename locals to avoid shadowing.
2715 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2716
2717 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2718 (BIDI_BOB): Remove unused macro.
2719
2720 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2721 deduce are never used uninitialized.
2722 * term.c (encode_terminal_code): Likewise.
2723
2724 * term.c (encode_terminal_code): Now static. Remove unused local.
2725
2726 * tparam.h: New file.
2727 * term.c, tparam.h: Include it.
2728 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2729 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2730 Move these decls to tparam.h, and make them agree with what
2731 is actually in tparam.c. The previous trick of using incompatible
2732 decls in different modules does not conform to the C standard.
2733 All callers of tparam changed to use tparam's actual API.
2734 * tparam.c (tparam1, tparam, tgoto):
2735 Use const pointers where appropriate.
2736
2737 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2738 * cm.h (struct cm): Likewise.
2739 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2740 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2741 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2742 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2743 (turn_on_face, init_tty): Likewise.
2744 * termchar.h (struct tty_display_info): Likewise.
2745
2746 * term.c (term_mouse_position): Rename local to avoid shadowing.
2747
2748 * alloc.c (mark_ttys): Move decl from here ...
2749 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2750
2751 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2752
2753 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2754
2755 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2756
2757 * search.c (compile_pattern_1): Remove argument regp, unused since
2758 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2759 (compile_pattern): Don't pass it.
2760
2761 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2762
2763 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2764 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2765 for ! HAVE_GTK3.
2766 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2767
2768 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2769
2770 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2771 gdk_window_get_screen, gdk_window_get_geometry,
2772 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2773 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2774 (xg_get_pixbuf_from_pixmap): New function.
2775 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2776 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2777 Call xg_get_pixbuf_from_pixmap instead of
2778 gdk_pixbuf_get_from_drawable.
2779 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2780 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2781 (xg_check_special_colors): Use GtkStyleContext and its functions
2782 for HAVE_GTK3.
2783 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2784 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2785 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2786 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2787 Call gtk_widget_get_preferred_size.
2788 (xg_frame_resized): gdk_window_get_geometry only takes 5
2789 parameters.
2790 (xg_win_to_widget, xg_event_is_for_menubar):
2791 Call gdk_x11_window_lookup_for_display.
2792 (xg_set_widget_bg): New function.
2793 (delete_cb): New function.
2794 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2795 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2796 (xg_set_background_color): Call xg_set_widget_bg.
2797 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2798 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2799 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2800 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2801 if ! HAVE_GTK3.
2802 (update_frame_tool_bar): Call gtk_widget_hide.
2803 (xg_initialize): Use GDK_KEY_g.
2804
2805 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2806 if ! HAVE_GTK3
2807 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2808
2809 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2810 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2811 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2812
2813 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2814
2815 * w32xfns.c (select_palette): Check success of RealizePalette against
2816 GDI_ERROR, not zero.
2817
2818 See ChangeLog.11 for earlier changes.
2819
2820 ;; Local Variables:
2821 ;; coding: utf-8
2822 ;; End:
2823
2824 Copyright (C) 2011 Free Software Foundation, Inc.
2825
2826 This file is part of GNU Emacs.
2827
2828 GNU Emacs is free software: you can redistribute it and/or modify
2829 it under the terms of the GNU General Public License as published by
2830 the Free Software Foundation, either version 3 of the License, or
2831 (at your option) any later version.
2832
2833 GNU Emacs is distributed in the hope that it will be useful,
2834 but WITHOUT ANY WARRANTY; without even the implied warranty of
2835 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2836 GNU General Public License for more details.
2837
2838 You should have received a copy of the GNU General Public License
2839 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.