1 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4 Do not assume that spare memory exists; that assumption is valid
6 (LARGE_REQUEST): New macro, so that the issue of large requests
7 is separated from the issue of spare memory.
9 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
14 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
16 * xfns.c (x_set_scroll_bar_default_width): Move declarations
19 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
21 * gtkutil.c (xg_get_default_scrollbar_width): New function.
23 * gtkutil.h: Declare xg_get_default_scrollbar_width.
25 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
26 min width by calling x_set_scroll_bar_default_width (Bug#8505).
28 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
30 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
32 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
34 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
35 (x_clipboard_manager_save): Add return value.
36 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
38 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
39 Obey Vx_select_enable_clipboard_manager. Catch errors in
40 x_clipboard_manager_save (Bug#8779).
41 (Vx_select_enable_clipboard_manager): New variable.
42 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
44 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
46 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
48 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
50 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
51 in the current matrix if keep_current_p is non-zero.
53 2011-06-04 Eli Zaretskii <eliz@gnu.org>
55 * bidi.c (bidi_level_of_next_char): Fix last change.
57 2011-06-03 Eli Zaretskii <eliz@gnu.org>
59 Support bidi reordering of text covered by display properties.
61 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
62 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
63 (bidi_cache_search, bidi_cache_iterator_state)
64 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
65 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
66 character positions inside a run of characters covered by a
68 (bidi_paragraph_init, bidi_resolve_explicit_1)
69 (bidi_level_of_next_char): Call bidi_fetch_char and
70 bidi_fetch_char_advance instead of FETCH_CHAR and
72 (bidi_init_it): Initialize new members.
73 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
75 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
76 instead of using explicit *_CHAR codes.
77 (bidi_resolve_explicit, bidi_resolve_weak): Use
78 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
79 bidirectional text is supported only in multibyte buffers.
80 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
81 it to initialize the frame_window_p member of struct bidi_it.
82 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
83 (bidi_resolve_explicit, bidi_resolve_weak)
84 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
85 bidi_it->nchars is non-positive.
86 (bidi_level_of_next_char): Don't try to lookup the cache for the
87 next/previous character if nothing is cached there yet, or if we
88 were just reseat()'ed to a new position.
90 * xdisp.c (set_cursor_from_row): Set start and stop points
91 according to the row's direction when priming the loop that looks
92 for the glyph on which to display cursor.
93 (single_display_spec_intangible_p): Function deleted.
94 (display_prop_intangible_p): Reimplement to call
95 handle_display_spec instead of single_display_spec_intangible_p.
96 Accept 3 additional arguments needed by handle_display_spec. This
97 fixes incorrect cursor motion across display property with complex
98 values: lists, `(when COND...)' forms, etc.
99 (single_display_spec_string_p): Support property values that are
100 lists with the argument STRING its top-level element.
101 (display_prop_string_p): Fix the condition for processing a
102 property that is a list to be consistent with handle_display_spec.
103 (handle_display_spec): New function, refactored from the
104 last portion of handle_display_prop.
105 (compute_display_string_pos): Accept additional argument
106 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
107 value of a `display' property is a "replacing spec".
108 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
109 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
110 the display property, but just return a value indicating whether
111 the display property will replace the characters it covers.
112 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
113 frame_window_p members of struct bidi_it.
114 (compute_display_string_pos, compute_display_string_end): New
116 (push_it): Accept second argument POSITION, where pop_it should
117 jump to continue iteration.
118 (reseat_1): Initialize bidi_it.disp_pos.
120 * keyboard.c (adjust_point_for_property): Adjust the call to
121 display_prop_intangible_p to its new signature.
123 * dispextern.h (struct bidi_it): New member frame_window_p.
124 (bidi_init_it): Update prototypes.
125 (display_prop_intangible_p): Update prototype.
126 (compute_display_string_pos, compute_display_string_end): Declare
128 (struct bidi_it): New members nchars and disp_pos. ch_len is now
131 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
133 Malloc failure behavior now depends on size of allocation.
134 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
135 * lisp.h: Change signatures accordingly.
136 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
137 All callers changed. (Bug#8762)
139 * gnutls.c: Use Emacs's memory allocators.
140 Without this change, the gnutls library would invoke malloc etc.
141 directly, which causes problems on non-SYNC_INPUT hosts, and which
142 runs afoul of improving memory_full behavior. (Bug#8761)
143 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
144 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
145 xfree instead of the default malloc, realloc, free.
146 (Fgnutls_boot): No need to check for memory allocation failure,
147 since xmalloc does that for us.
149 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
150 * category.c (hash_get_category_set):
151 * ccl.c (ccl_driver):
152 * charset.c (Fdefine_charset_internal):
153 * charset.h (struct charset.hash_index):
154 * composite.c (get_composition_id, gstring_lookup_cache)
155 (composition_gstring_put_cache):
156 * composite.h (struct composition.hash_index):
157 * dispextern.h (struct image.hash):
158 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
159 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
160 (hashfn_equal, hashfn_user_defined, make_hash_table)
161 (maybe_resize_hash_table, hash_lookup, hash_put)
162 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
163 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
164 (Fsxhash, Fgethash, Fputhash, Fmaphash):
165 * image.c (make_image, search_image_cache, lookup_image)
166 (xpm_put_color_table_h):
167 * lisp.h (struct Lisp_Hash_Table):
168 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
169 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
170 for hashes and hash indexes, instead of 'unsigned' and 'int'.
171 * alloc.c (allocate_vectorlike):
172 Check for overflow in vector size calculations.
173 * ccl.c (ccl_driver):
174 Check for overflow when converting EMACS_INT to int.
175 * fns.c, image.c: Remove unnecessary static decls that would otherwise
176 need to be updated by these changes.
177 * fns.c (make_hash_table, maybe_resize_hash_table):
178 Check for integer overflow with large hash tables.
179 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
180 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
181 (SXHASH_REDUCE): New macro.
182 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
183 Use it instead of discarding useful hash info with large hash values.
184 (sxhash_float): New function.
185 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
186 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
187 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
188 Rewrite to use FIXNUM_BITS, as this simplifies things.
189 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
190 Adjust signatures to match updated version of code.
191 (consing_since_gc): Now EMACS_INT, since a single hash table can
192 use more than INT_MAX bytes.
194 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
196 Make it possible to build with GCC-4.6+ -O2 -flto.
198 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
200 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
202 * minibuf.c (get_minibuffer, read_minibuf_unwind):
203 Call minibuffer-inactive-mode.
205 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
207 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
210 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
212 * data.c (init_data): Remove code for UTS, this system is not
215 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
217 Don't force ./temacs to start in terminal mode.
219 * frame.c (make_initial_frame): Initialize faces in all cases, not
220 only when CANNOT_DUMP is defined.
221 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
223 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
225 * dispnew.c (add_window_display_history): Use const for the string
226 pointer. Remove declaration, not needed.
228 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
230 Use 'inline', not 'INLINE'.
231 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
232 * alloc.c, fontset.c (INLINE): Remove.
233 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
234 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
235 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
236 * gmalloc.c (register_heapinfo): Use inline unconditionally.
237 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
239 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
241 Make it possible to run ./temacs.
243 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
244 syms_of_callproc does the same thing. Remove test for
245 "initialized", do it in the caller.
246 * emacs.c (main): Avoid calling set_initial_environment when dumping.
248 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
250 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
251 (read_minibuf): Use get_minibuffer.
252 (syms_of_minibuf): Use DEFSYM.
253 (Qmetadata): New var.
254 * data.c (Qbuffer): Don't make it static.
255 (syms_of_data): Use DEFSYM.
257 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
259 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
260 (CCL_CODE_MIN): New macro.
262 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
264 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
266 * eval.c (Qdebug): Now static.
267 * lisp.h (Qdebug): Remove decl. This reverts a part of the
268 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
269 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
271 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
273 * image.c: Various fixes to ImageMagick code comments.
274 (Fimagemagick_types): Doc fix.
276 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
278 Minor fixes prompted by GCC 4.6.0 warnings.
280 * xselect.c (converted_selections, conversion_fail_tag): Now static.
282 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
283 (x_clipboard_manager_save_all): Move extern decl to ...
284 * xterm.h: ... here, so that it can be checked for consistency.
286 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
288 * xselect.c (x_clipboard_manager_save_frame)
289 (x_clipboard_manager_save_all): New functions.
290 (Fx_clipboard_manager_save): Lisp function deleted.
292 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
293 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
295 * xterm.h: Update prototype.
297 2011-05-28 William Xu <william.xwl@gmail.com>
299 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
302 2011-05-28 Jim Meyering <meyering@redhat.com>
304 Avoid a sign-extension bug in crypto_hash_function.
305 * fns.c (to_uchar): Define.
306 (crypto_hash_function): Use it to convert some newly-signed
307 variables to unsigned, to avoid sign-extension bugs. For example,
308 without this change, (md5 "truc") would evaluate to
309 45723a2aff78ff4fff7fff1114760e62 rather than the expected
310 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
311 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
313 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
315 Integer overflow fixes.
317 * dbusbind.c: Serial number integer overflow fixes.
318 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
319 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
320 to hold a serial number that is too large for a fixnum.
321 (Fdbus_method_return_internal, Fdbus_method_error_internal):
322 Check for serial numbers out of range. Decode any serial number
323 that was so large that it became a float. (Bug#8722)
325 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
326 (Fdbus_call_method, Fdbus_call_method_asynchronously):
327 Use XFASTINT rather than XUINT when numbers are nonnegative.
328 (xd_append_arg, Fdbus_method_return_internal):
329 (Fdbus_method_error_internal): Likewise. Also, for unsigned
330 arguments, check that Lisp number is nonnegative, rather than
331 silently wrapping negative numbers around. (Bug#8722)
332 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
335 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
337 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
339 ccl: add integer overflow checks
340 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
341 (IN_INT_RANGE): New macros.
342 (ccl_driver): Use them to check for integer overflow when
343 decoding a CCL program. Many of the new checks are whether XINT (x)
344 fits in int; it doesn't always, on 64-bit hosts. The new version
345 doesn't catch all possible integer overflows, but it's an
346 improvement. (Bug#8719)
348 * alloc.c (make_event_array): Use XINT, not XUINT.
349 There's no need for unsigned here.
351 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
352 This follows up to the 2011-05-06 change that substituted uintptr_t
353 for EMACS_INT. This case wasn't caught back then.
355 Rework Fformat to avoid integer overflow issues.
356 * editfns.c: Include <float.h> unconditionally, as it's everywhere
357 now (part of C89). Include <verify.h>.
358 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
359 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
360 (Fformat): Avoid the prepass trying to compute sizes; it was only
361 approximate and thus did not catch overflow reliably. Instead, walk
362 through the format just once, formatting and computing sizes as we go,
363 checking for integer overflow at every step, and allocating a larger
364 buffer as needed. Keep track separately whether the format is
365 multibyte. Keep only the most-recently calculated precision, rather
366 than them all. Record whether each argument has been converted to
367 string. Use EMACS_INT, not int, for byte and char and arg counts.
368 Support field widths and precisions larger than INT_MAX. Avoid
369 sprintf's undefined behavior with conversion specifications such as %#d
370 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
371 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
372 formatting out-of-range floating point numbers with int
375 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
377 * data.c: Avoid integer truncation in expressions involving floats.
378 * data.c: Include <intprops.h>.
379 (arith_driver): When there's an integer overflow in an expression
380 involving floating point, convert the integers to floating point
381 so that the resulting value does not suffer from catastrophic
382 integer truncation. For example, on a 64-bit host (* 4
383 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
384 Do not rely on undefined behavior after integer overflow.
386 merge count_size_as_multibyte, parse_str_to_multibyte
387 * character.c, character.h (count_size_as_multibyte):
388 Rename from parse_str_to_multibyte; all uses changed.
389 Check for integer overflow.
390 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
391 since it's now a duplicate of the other. This is more of
392 a character than a buffer op, so better that it's in character.c.
393 * fns.c, print.c: Adjust to above changes.
395 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
397 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
399 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
401 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
402 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
403 (x_clipboard_manager_save): Now static.
404 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
406 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
407 (crypto_hash_function): Now static.
408 Fix pointer signedness problems. Avoid unnecessary initializations.
410 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
412 * termhooks.h (Vselection_alist): Make it terminal-local.
414 * terminal.c (create_terminal): Initialize it.
416 * xselect.c: Support for clipboard managers.
417 (Vselection_alist): Move to termhooks.h as terminal-local var.
418 (LOCAL_SELECTION): New macro.
419 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
420 (symbol_to_x_atom): Remove gratuitous arg.
421 (x_handle_selection_request, lisp_data_to_selection_data)
422 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
423 (x_own_selection, x_get_local_selection, x_convert_selection):
424 New arg, specifying work frame. Use terminal-local Vselection_alist.
425 (some_frame_on_display): Delete unused function.
426 (Fx_own_selection_internal, Fx_get_selection_internal)
427 (Fx_disown_selection_internal, Fx_selection_owner_p)
428 (Fx_selection_exists_p): New optional frame arg.
429 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
430 (x_handle_selection_clear): Don't treat other terminals with the
431 same keyboard specially. Use the terminal-local Vselection_alist.
432 (x_clear_frame_selections): Use Frun_hook_with_args.
434 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
436 * xterm.h: Add support for those atoms.
438 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
440 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
441 (converted_selections, conversion_fail_tag): New global variables.
442 (x_selection_request_lisp_error): Free the above.
443 (x_get_local_selection): Remove unnecessary code.
444 (x_reply_selection_request): Args changed; handle arbitrary array
445 of converted selections stored in converted_selections.
446 Separate the XChangeProperty and SelectionNotify steps.
447 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
448 (x_convert_selection): New function.
449 (x_handle_selection_event): Simplify.
450 (x_get_foreign_selection): Don't ignore incoming requests while
451 waiting for an answer; this will fail when we implement
452 SAVE_TARGETS, and seems unnecessary anyway.
453 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
454 (Vx_sent_selection_functions): Doc fix.
456 2011-05-26 Leo Liu <sdl.web@gmail.com>
458 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
460 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
462 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
464 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
465 for fringe update if it has periodic bitmap.
466 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
467 and fringe_bitmap_periodic_p.
469 * fringe.c (get_fringe_bitmap_data): New function.
470 (draw_fringe_bitmap_1, update_window_fringes): Use it.
471 (update_window_fringes): Record periodicity of fringe bitmap in glyph
472 row. Mark glyph row for fringe update if periodicity changed.
474 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
475 for fringe update unless it has periodic bitmap.
477 2011-05-25 Kenichi Handa <handa@m17n.org>
479 * xdisp.c (get_next_display_element): Set correct it->face_id for
480 a static composition.
482 2011-05-24 Leo Liu <sdl.web@gmail.com>
485 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
487 * fns.c (crypto_hash_function, Fsha1): New function.
488 (Fmd5): Use crypto_hash_function.
489 (syms_of_fns): Add Ssha1.
491 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
493 * gnutls.c: Remove unused macros.
494 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
495 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
496 Remove macros that are defined and never used.
497 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
499 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
501 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
502 (Fx_get_selection_internal): Minor cleanup.
503 (Fx_own_selection_internal): Rename arguments for consistency with
506 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
508 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
510 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
512 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
514 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
516 * dispnew.c (scrolling_window): Don't exclude the case that the
517 last enabled row in the desired matrix touches the bottom boundary.
519 2011-05-21 Glenn Morris <rgm@gnu.org>
521 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
522 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
523 and add some more files.
525 2011-05-20 Eli Zaretskii <eliz@gnu.org>
527 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
528 report_file_error introduced by the change from 2011-05-07.
530 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
532 * systime.h (Time): Define only if emacs is defined.
533 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
534 where the include path doesn't have X11/X.h by default. See
535 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
537 2011-05-20 Kenichi Handa <handa@m17n.org>
539 * composite.c (find_automatic_composition): Fix previous change.
541 2011-05-20 Glenn Morris <rgm@gnu.org>
543 * lisp.mk: New file, split from Makefile.in.
544 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
546 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
548 2011-05-19 Glenn Morris <rgm@gnu.org>
550 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
551 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
552 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
553 (lisp): Set the order to that of loadup.el.
554 (shortlisp): Make it a copy of $lisp.
555 (SOME_MACHINE_LISP): Remove.
556 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
557 Use just $shortlisp, not $SOME_MACHINE_LISP too.
559 2011-05-18 Kenichi Handa <handa@m17n.org>
561 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
562 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
563 (find_automatic_composition): Mostly rewrite for efficiency.
565 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
567 * makefile.w32-in: Update dependencies.
569 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
571 * menu.c: Include limits.h (fixes the MS-Windows build broken by
574 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
576 Fix some integer overflow issues, such as string length overflow.
578 * insdel.c (count_size_as_multibyte): Check for string overflow.
580 * character.c (lisp_string_width): Check for string overflow.
581 Use EMACS_INT, not int, for string indexes and lengths; in
582 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
583 the resulting string length overflows an EMACS_INT; instead,
584 report a string overflow if no precision given. When checking for
585 precision exhaustion, use a check that cannot possibly have
586 integer overflow. (Bug#8675)
587 * character.h (lisp_string_width): Adjust to new signature.
589 * alloc.c (string_overflow): New function.
590 (Fmake_string): Use it. This doesn't change behavior, but saves
591 a few bytes and will simplify future changes.
592 * character.c (string_escape_byte8): Likewise.
593 * lisp.h (string_overflow): New decl.
595 Fixups, following up to the user-interface timestamp change.
596 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
597 for UI timestamps, instead of unsigned long.
598 * msdos.c (mouse_get_pos): Likewise.
599 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
600 * w32gui.h (Time): Define by including "systime.h" rather than by
601 declaring it ourselves. (Bug#8664)
603 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
604 * image.c (clear_image_cache): Likewise.
606 * term.c (term_mouse_position): Don't assume time_t wraparound.
608 Be more systematic about user-interface timestamps.
609 Before, the code sometimes used 'Time', sometimes 'unsigned long',
610 and sometimes 'EMACS_UINT', to represent these timestamps.
611 This change causes it to use 'Time' uniformly, as that's what X uses.
612 This makes the code easier to follow, and makes it easier to catch
613 integer overflow bugs such as Bug#8664.
614 * frame.c (Fmouse_position, Fmouse_pixel_position):
615 Use Time, not unsigned long, for user-interface timestamps.
616 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
617 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
618 * keyboard.h (last_event_timestamp): Likewise.
619 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
620 * menu.h (xmenu_show): Likewise.
621 * term.c (term_mouse_position): Likewise.
622 * termhooks.h (struct input_event.timestamp): Likewise.
623 (struct terminal.mouse_position_hook): Likewise.
624 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
625 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
626 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
627 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
629 * menu.h, termhooks.h: Include "systime.h", for Time.
631 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
632 Don't assume that the difference between two unsigned long values
633 can fit into an integer. At this point, we know button_down_time
634 <= event->timestamp, so the difference must be nonnegative, so
635 there's no need to cast the result if double-click-time is
636 nonnegative, as it should be; check that it's nonnegative, just in
637 case. This bug is triggered when events are more than 2**31 ms
638 apart (about 25 days). (Bug#8664)
640 * xselect.c (last_event_timestamp): Remove duplicate decl.
641 (x_own_selection): Remove needless cast to unsigned long.
643 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
644 that always fit in int. Use a sentinel instead of a counter, to
645 avoid a temp and to allay GCC's concerns about possible int overflow.
646 * frame.h (struct frame): Use int for menu_bar_items_used
647 instead of EMACS_INT, since it always fits in int.
649 * menu.c (grow_menu_items): Check for int overflow.
651 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
653 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
654 Before, the code was not consistent. These values cannot exceed
655 2**31 - 1 so there's no need to make them unsigned.
656 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
657 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
658 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
660 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
662 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
663 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
664 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
665 presumably because the widths might not match.
667 * window.c (size_window): Avoid needless test at loop start.
669 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
671 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
673 2011-05-12 Drew Adams <drew.adams@oracle.com>
675 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
677 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
679 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
680 `width' to `bar_area_x' and `bar_area_width', respectively.
681 (x_scroll_run): Take account of fringe background extension.
683 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
684 Rename local vars `left' and `width' to `bar_area_x' and
685 `bar_area_width', respectively.
686 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
687 background extension.
689 2011-05-10 Jim Meyering <meyering@redhat.com>
691 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
693 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
695 * image.c (Finit_image_library): Return t for built-in image types,
696 like pbm and xbm. (Bug#8640)
698 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
700 * w32menu.c (set_frame_menubar): Fix submenu allocation.
702 2011-05-07 Eli Zaretskii <eliz@gnu.org>
704 * w32console.c (Fset_screen_color): Doc fix.
705 (Fget_screen_color): New function.
706 (syms_of_ntterm): Defsubr it.
708 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
709 unlink the temporary file if Fcall_process didn't create it in the
711 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
712 child process will be redirected to a file specified with `:file'.
713 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
714 cue to call_process_cleanup not to close that handle.
716 2011-05-07 Ben Key <bkey76@gmail.com>
718 * makefile.w32-in: The bootstrap-temacs rule now makes use of
719 one of two shell specific rules, either bootstrap-temacs-CMD or
720 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
721 to the previous implementation of the bootstrap-temacs rule.
722 The bootstrap-temacs-CMD rule is similar to the previous
723 implementation of the bootstrap-temacs rule except that it
724 makes use of the ESC_CFLAGS variable instead of the CFLAGS
727 These changes, along with some changes to nt/configure.bat,
728 nt/gmake.defs, and nt/nmake.defs, are required to extend my
729 earlier fix to add support for --cflags and --ldflags options
730 that include quotes so that it works whether make uses cmd or
733 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
735 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
736 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
738 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
739 a string. Handle both cases.
740 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
741 (Fdbus_register_method): Use Qinvalid_function.
743 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
745 * makefile.w32-in: Update dependencies.
746 (LISP_H): Add inttypes.h and stdin.h.
747 (PROCESS_H): Add unistd.h.
749 2011-05-06 Eli Zaretskii <eliz@gnu.org>
751 * lread.c: Include limits.h (fixes the MS-Windows build broken by
752 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
754 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
756 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
758 * term.c (vfatal): Remove stray call to va_end.
759 It's not needed and the C Standard doesn't allow it here anyway.
761 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
762 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
764 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
767 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
769 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
771 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
773 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
775 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
777 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
778 * charset.c (Fdefine_charset_internal): Don't initialize
779 charset.code_space[15]. The value was garbage, on hosts with
780 32-bit int (Bug#8600).
782 * lread.c (read_integer): Be more consistent with string-to-number.
783 Use string_to_number to do the actual conversion; this avoids
784 rounding errors and fixes some other screwups. Without this fix,
785 for example, #x1fffffffffffffff was misread as -2305843009213693952.
786 (digit_to_number): Move earlier, for benefit of read_integer.
787 Return -1 if the digit is out of range for the base, -2 if it is
788 not a digit in any supported base. (Bug#8602)
790 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
792 * dispnew.c (scrolling_window): Return 1 if we scrolled,
793 to match comment at start of function. This also removes a
794 GCC warning about overflow in a 32+64-bit port.
796 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
798 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
799 Reported by Stefan Monnier in
800 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
801 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
802 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
804 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
805 (EMACS_UINTPTR): Likewise, with uintptr_t.
807 * lisp.h: Prefer 64-bit EMACS_INT if available.
808 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
809 on 32-bit hosts that have 64-bit int, so that they can access
811 However, temporarily disable this change unless the temporary
812 symbol WIDE_EMACS_INT is defined.
814 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
816 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
817 This removes an assumption that EMACS_INT and long are the same
818 width as pointers. The assumption is true for Emacs porting targets
819 now, but we want to make other targets possible.
820 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
821 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
822 In the rest of the code, change types of integers that hold casted
823 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
824 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
825 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
826 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
827 No need to cast type when ORing.
828 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
829 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
830 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
831 assume EMACS_INT is the same width as char *.
832 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
833 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
834 Remove no-longer-needed casts.
835 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
836 (xg_tool_bar_help_callback, xg_make_tool_item):
837 Use EMACS_INTPTR to hold an integer
838 that will be cast to void *; this can avoid a GCC warning
839 if EMACS_INT is not the same width as void *.
840 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
841 * xdisp.c (display_echo_area_1, resize_mini_window_1):
842 (current_message_1, set_message_1):
843 Use a local to convert to proper width without a cast.
844 * xmenu.c (dialog_selection_callback): Likewise.
846 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
847 Also, don't assume VALBITS / RAND_BITS is less than 5,
848 and don't rely on undefined behavior when shifting a 1 left into
850 * lisp.h (get_random): Change signature to match.
852 * lread.c (hash_string): Use size_t, not int, for hash computation.
853 Normally we prefer signed values; but hashing is special, because
854 it's better to use unsigned division on hash table sizes so that
855 the remainder is nonnegative. Also, size_t is the natural width
856 for hashing into memory. The previous code used 'int', which doesn't
857 retain enough info to hash well into very large tables.
858 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
860 * dbusbind.c: Don't possibly lose pointer info when converting.
861 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
862 Use XPNTR rather than XHASH, so that the high-order bits of
863 the pointer aren't lost when converting through void *.
865 * eval.c (Fautoload): Don't double-shift a pointer.
867 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
869 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
871 * gnutls.c (DEF_GNUTLS_FN):
872 * image.c (DEF_IMGLIB_FN): Make function pointers static.
874 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
876 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
879 2011-05-05 Eli Zaretskii <eliz@gnu.org>
881 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
882 New version that can reserve upto 2GB of heap space.
884 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
886 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
888 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
890 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
891 `gnutls_certificate_set_x509_key_file'.
893 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
895 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
898 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
900 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
901 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
902 Remove unused parameter `fildes'.
903 * process.c (read_process_output, send_process): Don't pass it.
905 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
907 Fix previous change: the library cache is defined in w32.c.
908 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
909 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
911 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
913 Implement dynamic loading of GnuTLS on Windows.
915 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
916 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
917 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
920 * gnutls.c (Qgnutls_dll): Define.
921 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
922 (gnutls_*): Declare function pointers.
923 (init_gnutls_functions): New function to initialize function pointers.
924 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
925 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
926 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
927 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
928 (emacs_gnutls_write, emacs_gnutls_read)
929 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
930 (Fgnutls_available_p): New function.
931 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
932 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
933 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
935 * image.c: Include w32.h.
936 (Vimage_type_cache): Delete.
937 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
938 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
939 (w32_delayed_load): Move to w32.c.
941 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
943 * w32.c (QCloaded_from, Vlibrary_cache): Define.
944 (w32_delayed_load): Move from image.c. When loading a library, record
945 its filename in the :loaded-from property of the library id.
946 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
947 Initialize and staticpro them.
948 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
950 * process.c: Include lisp.h before w32.h, not after.
951 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
952 instead of gnutls_record_check_pending.
954 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
956 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
958 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
959 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
962 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
964 * xterm.c (x_set_frame_alpha): Do not set property on anything
965 else than FRAME_X_OUTER_WINDOW (Bug#8608).
967 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
969 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
971 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
973 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
974 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
975 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
976 (gnutls_global_initialized, Qgnutls_bootprop_priority)
977 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
978 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
979 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
980 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
981 (Qgnutls_bootprop_callbacks_verify): Make static.
983 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
985 * callproc.c: Indentation fixup.
987 * sysdep.c (wait_for_termination_1): Make static.
988 (wait_for_termination, interruptible_wait_for_termination):
989 Move after wait_for_termination_1.
991 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
993 * sysdep.c (interruptible_wait_for_termination): New function
994 which is like wait_for_termination, but allows keyboard
997 * callproc.c (Fcall_process): Add (:file "file") as an option for
999 (Fcall_process_region): Ditto.
1001 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1003 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1004 rather than `XVECTOR (FOO)->size'.
1006 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1007 inttypes.h, as a gnulib replacement is used if it not available in
1010 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1012 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1013 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1014 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1016 * coding.c (coding_alloc_by_realloc): Error out if destination
1017 will grow beyond MOST_POSITIVE_FIXNUM.
1018 (decode_coding_emacs_mule): Abort if there isn't enough place in
1019 charbuf for the composition carryover bytes. Reserve an extra
1020 space for up to 2 characters produced in a loop.
1021 (decode_coding_iso_2022): Abort if there isn't enough place in
1022 charbuf for the composition carryover bytes.
1024 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1026 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1027 aborting when %lld or %lll format is passed.
1028 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1029 %llo or %llx format is passed. (Bug#8545)
1031 * window.c (window_scroll_line_based): Use a marker instead of
1032 simple variables to record original value of point. (Bug#7952)
1034 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1035 produced by %s or %c overflows available buffer space. (Bug#8545)
1037 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1039 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1040 (SIZE_MAX): Move defn after all includes, as they might #define it.
1042 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1044 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1046 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1048 * keyboard.c (Qdelayed_warnings_hook): Define.
1049 (command_loop_1): Run `delayed-warnings-hook'
1050 if Vdelayed_warnings_list is non-nil.
1051 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1052 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1054 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1056 * doprnt.c (doprnt): Don't return value smaller than the buffer
1057 size if the message was truncated. (Bug#8545).
1059 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1061 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1062 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1064 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1066 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1068 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1070 * makefile.w32-in: Update dependencies.
1072 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1074 Improve `doprnt' and its usage. (Bug#8545)
1075 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1076 `format_end'. Remove support for %l as a conversion specifier.
1077 Don't use xrealloc. Improve diagnostics when the %l size modifier
1078 is used. Update the commentary.
1080 * eval.c (verror): Simplify calculation of size_t.
1082 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1085 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1087 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1090 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1092 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1093 This makes this file independent of the recent pseudovector change.
1095 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1097 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1099 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1100 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1101 Remove unused local.
1102 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1104 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1105 GCC 4.6.0 optimizes based on type-based alias analysis.
1106 For example, if b is of type struct buffer * and v of type struct
1107 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1108 != &v->size, and therefore "v->size = 1; b->size = 2; return
1109 v->size;" must therefore return 1. This assumption is incorrect
1110 for Emacs, since it type-puns struct Lisp_Vector * with many other
1111 types. To fix this problem, this patch adds a new type struct
1112 vectorlike_header that documents the constraints on layout of vectors
1113 and pseudovectors, and helps optimizing compilers not get fooled
1114 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1115 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1116 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1118 (XSETPVECTYPE): Rewrite in terms of new macro.
1119 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1120 This is a bit clearer, and further avoids the possibility of
1121 undesirable aliasing.
1122 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1123 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1124 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1125 since Lisp_Subr is a special case (no "next" field).
1126 (ASIZE): Now uses header.size rather than size.
1127 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1128 to avoid the hassle of writing XVECTOR (foo)->header.size.
1129 (struct vectorlike_header): New type.
1130 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1131 object, to help avoid aliasing.
1132 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1133 (SUBRP): Likewise, since Lisp_Subr is a special case.
1134 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1135 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1136 (struct Lisp_Hash_Table): Combine first two members into a single
1137 struct vectorlike_header member. All uses of "size" and "next" members
1138 changed to be "header.size" and "header.next".
1139 * buffer.h (struct buffer): Likewise.
1140 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1141 * frame.h (struct frame): Likewise.
1142 * process.h (struct Lisp_Process): Likewise.
1143 * termhooks.h (struct terminal): Likewise.
1144 * window.c (struct save_window_data, struct saved_window): Likewise.
1145 * window.h (struct window): Likewise.
1146 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1147 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1148 * buffer.c (init_buffer_once): Likewise.
1149 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1151 * process.c (Fformat_network_address): Use local var for size,
1154 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1156 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1157 * data.c (atof): Remove decl; no longer used or needed.
1158 (digit_to_number): Move to lread.c.
1159 (Fstring_to_number): Use new string_to_number function, to be
1160 consistent with how the Lisp reader treats infinities and NaNs.
1161 Do not assume that floating-point numbers represent EMACS_INT
1162 without losing information; this is not true on most 64-bit hosts.
1163 Avoid double-rounding errors, by insisting on integers when
1164 parsing non-base-10 numbers, as the documentation specifies.
1165 * lisp.h (string_to_number): New decl, replacing ...
1166 (isfloat_string): Remove.
1167 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1168 (read1): Do not accept +. and -. as integers; this
1169 appears to have been a coding error. Similarly, do not accept
1170 strings like +-1e0 as floating point numbers. Do not report
1171 overflow for integer overflows unless the base is not 10 which
1172 means we have no simple and reliable way to continue.
1173 Break out the floating-point parsing into a new
1174 function string_to_number, so that Fstring_to_number parses
1175 floating point numbers consistently with the Lisp reader.
1176 (digit_to_number): Move here from data.c. Make it static inline.
1177 (E_CHAR, EXP_INT): Remove, replacing with ...
1178 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1179 (string_to_number): New function, replacing isfloat_string.
1180 This function checks for valid syntax and produces the resulting
1181 Lisp float number too. Rework it so that string-to-number
1182 no longer mishandles examples like "1.0e+". Use strtoumax,
1183 so that overflow for non-base-10 numbers is reported only when
1184 there's no portable and simple way to convert to floating point.
1186 * textprop.c (set_text_properties_1): Rewrite for clarity,
1187 and to avoid GCC warning about integer overflow.
1189 * intervals.h (struct interval): Use EMACS_INT for members
1190 where EMACS_UINT might cause problems. See
1191 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1192 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1193 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1195 (offset_intervals): Tell GCC not to worry about length overflow
1196 when negating a negative length.
1198 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1199 (overrun_check_free): Likewise.
1201 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1202 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1205 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1206 (gnutls_make_error): Rename local to avoid shadowing.
1207 (gnutls_emacs_global_deinit): ifdef out; not used.
1208 (Fgnutls_boot): Use const for pointer to readonly storage.
1209 Comment out unused local. Fix pointer signedness problems.
1211 * lread.c (openp): Don't stuff size_t into an 'int'.
1212 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1213 about possible signed overflow.
1215 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1216 (GDK_KEY_g): Don't define if already defined.
1217 (xg_prepare_tooltip): Avoid pointer signedness problem.
1218 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1220 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1221 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1223 * xfns.c (Fx_window_property): Simplify a bit,
1224 to make a bit faster and to avoid GCC 4.6.0 warning.
1225 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1227 * fns.c (internal_equal): Don't assume size_t fits in int.
1229 * alloc.c (compact_small_strings): Tighten assertion a little.
1231 Replace pEd with more-general pI, and fix some printf arg casts.
1232 * lisp.h (pI): New macro, generalizing old pEd macro to other
1233 conversion specifiers. For example, use "...%"pI"d..." rather
1234 than "...%"pEd"...".
1235 (pEd): Remove. All uses replaced with similar uses of pI.
1236 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1237 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1238 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1239 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1240 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1241 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1242 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1244 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1245 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1246 * print.c (safe_debug_print, print_object): Likewise.
1247 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1249 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1250 avoiding the 0 flag, which is not portable.
1251 * process.c (Fmake_network_process): Use pI to avoid cast.
1252 * region-cache.c (pp_cache): Likewise.
1253 * xdisp.c (decode_mode_spec): Likewise.
1254 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1255 behavior on 64-bit hosts with printf arg.
1256 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1257 (x_stop_queuing_selection_requests): Likewise.
1258 (x_get_window_property): Don't truncate byte count to an 'int'
1261 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1262 here, since it parses constructs like leading '-' and spaces,
1263 which are not wanted; and it overflows with large numbers.
1264 Instead, simply match F[0-9]+, which is what is wanted anyway.
1266 * alloc.c: Remove unportable assumptions about struct layout.
1267 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1268 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1269 (allocate_vectorlike, make_pure_vector): Use the new macros,
1270 plus offsetof, to remove unportable assumptions about struct layout.
1271 These assumptions hold on all porting targets that I know of, but
1272 they are not guaranteed, they're easy to remove, and removing them
1273 makes further changes easier.
1275 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1276 This doesn't fix a bug but makes the code clearer.
1277 (string_overrun_cookie): Now const. Use initializers that
1278 don't formally overflow signed char, to avoid warnings.
1279 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1280 can cause Emacs to crash when string overrun checking is enabled.
1281 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1282 multiple of sizeof (EMACS_INT); it need not be, if
1283 alignof(EMACS_INT) < sizeof (EMACS_INT).
1284 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1286 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1288 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1290 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1292 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1293 supposed to be handshaking. (Bug#8556)
1294 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1296 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1298 * lisp.h (Qdebug): List symbol.
1299 * eval.c (Qdebug): Restore global linkage.
1300 * keyboard.c (debug-on-event): New variable.
1301 (handle_user_signal): Break into debugger when debug-on-event
1302 matches the current signal symbol.
1304 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1306 * alloc.c (check_sblock, check_string_bytes)
1307 (check_string_free_list): Convert to standard C.
1309 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1311 * w32.c (emacs_gnutls_push): Fix typo.
1313 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1315 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1316 "cast to pointer from integer of different size".
1318 Improve doprnt and its use in verror. (Bug#8545)
1319 * doprnt.c (doprnt): Document the set of format control sequences
1320 supported by the function. Use SAFE_ALLOCA instead of always
1323 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1324 is one byte too soon. Don't use xrealloc; instead xfree and
1327 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1329 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1332 * gnutls.c: Renamed global_initialized to
1333 gnutls_global_initialized. Added internals for the
1334 :verify-hostname-error, :verify-error, and :verify-flags
1335 parameters of `gnutls-boot' and documented those parameters in the
1336 docstring. Start callback support.
1337 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1338 unless a fatal error occured. Call gnutls_alert_send_appropriate
1339 on error. Return error code.
1340 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1341 (emacs_gnutls_read): Likewise.
1342 (Fgnutls_boot): Return handshake error code.
1343 (emacs_gnutls_handle_error): New function.
1344 (wsaerror_to_errno): Likewise.
1346 * w32.h (emacs_gnutls_pull): Add prototype.
1347 (emacs_gnutls_push): Likewise.
1349 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1350 (emacs_gnutls_push): Likewise.
1352 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1354 * process.c (wait_reading_process_output): Check if GnuTLS
1355 buffered some data internally if no FDs are set for TLS
1358 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1359 (LIBS): Link to USER_LIBS.
1360 ($(BLD)/gnutls.$(0)): New target.
1362 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1364 * xdisp.c (handle_single_display_spec): Rename the
1365 display_replaced_before_p argument into display_replaced_p, to
1366 make it consistent with the commentary. Fix typos in the
1369 * textprop.c (syms_of_textprop): Remove dead code.
1370 (copy_text_properties): Delete obsolete commentary about an
1371 interface that was deleted long ago. Fix typos in the description
1374 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1375 to changes in oldXMenu/XMenu.h from 2011-04-16.
1376 <menu_help_message, prev_menu_help_message>: Constify.
1377 (IT_menu_make_room): menu->help_text is now `const char **';
1380 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1381 to changes in oldXMenu/XMenu.h from 2011-04-16.
1382 (struct XMenu): Declare `help_text' `const char **'.
1384 * xfaces.c <Qunspecified>: Make extern again.
1386 * syntax.c: Include sys/types.h before including regex.h, as
1389 * doc.c (get_doc_string): Improve the format passed to `error'.
1391 * doprnt.c (doprnt): Improve commentary.
1393 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1395 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1398 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1399 changes in globals.h immediately force recompilation.
1400 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1401 $(CURDIR)/s/ms-w32.h.
1402 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1404 * character.c (Fchar_direction): Function deleted.
1405 (syms_of_character): Don't defsubr it.
1406 <char-direction-table>: Deleted.
1408 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1410 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1411 * doprnt.c: Include limits.h.
1412 (SIZE_MAX): New macro.
1413 (doprnt): Return a size_t value. 2nd arg is now size_t.
1414 Many local variables are now size_t instead of int or unsigned.
1415 Improve overflow protection. Support `l' modifier for integer
1416 conversions. Support %l conversion. Don't assume an EMACS_INT
1417 argument for integer conversions and for %c.
1419 * lisp.h (doprnt): Restore prototype.
1421 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1424 * Makefile.in (base_obj): Add back doprnt.o.
1426 * deps.mk (doprnt.o): Add back prerequisites.
1427 (callint.o): Depend on character.h.
1429 * eval.c (internal_lisp_condition_case): Include the handler
1430 representation in the error message.
1431 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1432 when breaking from the loop.
1434 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1436 * callint.c (Fcall_interactively): When displaying error message
1437 about invalid control letter, pass the character's codepoint, not
1438 a pointer to its multibyte form. Improve display of the character
1439 in octal and display also its hex code.
1441 * character.c (char_string): Use %x to display the (unsigned)
1442 codepoint of an invalid character, to avoid displaying a bogus
1445 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1446 `error', not SYMBOL_NAME itself.
1448 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1449 character arguments to `error'.
1451 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1452 to `error' in error message about FINAL_CHAR argument. Make sure
1453 FINAL_CHAR is a character, and use %c when it is passed as
1454 argument to `error'.
1456 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1458 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1460 * w32.c: Include <time.h>.
1461 (sys_localtime): New function.
1463 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1465 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1467 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1469 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1471 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1474 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1476 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1477 gl_state.e_property when gl_state.object is Qt.
1479 * insdel.c (make_gap_larger): Remove limitation of buffer size
1482 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1484 * xdisp.c (lookup_glyphless_char_display)
1485 (produce_glyphless_glyph): Handle cons cell entry in
1486 glyphless-char-display.
1487 (Vglyphless_char_display): Document it.
1489 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1490 glyphless-char-display.
1492 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1494 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1496 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1498 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1499 definition for no-X builds.
1501 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1503 Static checks with GCC 4.6.0 and non-default toolkits.
1505 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1507 * process.c (keyboard_bit_set): Define only if SIGIO.
1508 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1509 (send_process): Repair possible setjmp clobbering.
1511 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1513 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1515 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1517 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1518 Define only if needed.
1520 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1521 by pacifying GCC about it. Maybe it's time to retire it?
1522 * xfaces.c (USG, __TIMEVAL__): Likewise.
1524 * dispextern.h (struct redisplay_interface): Rename param
1526 * termhooks.h (struct terminal): Likewise.
1527 * xterm.c (xembed_send_message): Likewise.
1529 * insdel.c (make_gap_smaller): Define only if
1530 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1532 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1535 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1536 so that we aren't warned about unused symbols.
1538 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1540 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1542 * xfns.c (x_real_positions): Mark locals as initialized.
1544 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1546 * xterm.c: Fix problems found by static analysis with other toolkits.
1547 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1548 (x_dispatch_event): Declare static if USE_GTK, and
1549 define if USE_GTK || USE_X_TOOLKIT.
1550 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1551 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1552 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1553 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1555 * xmenu.c (menu_help_callback): Pointer type fixes.
1556 Use const pointers when pointing at readonly data. Avoid pointer
1558 (FALSE): Remove unused macro.
1559 (update_frame_menubar): Remove unused decl.
1561 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1563 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1564 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1565 (single_menu_item): Rename local to avoid shadowing.
1567 * keyboard.c (make_lispy_event): Remove unused local var.
1569 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1570 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1572 * bitmaps: Change bitmaps from unsigned char back to the X11
1573 compatible char. Avoid the old compiler warnings about
1574 out-of-range initializers by using, for example, '\xab' rather
1577 * xgselect.c (xgselect_initialize): Check vs interface
1578 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1580 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1582 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1583 to read-only memory.
1585 * fns.c (vector): Remove; this old hack is no longer needed.
1587 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1589 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1591 * xrdb.c (x_load_resources): Omit unused local.
1593 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1594 (x_window): Rename locals to avoid shadowing.
1595 (USG): Use the kludged USG macro, to pacify gcc.
1597 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1598 (x_term_init): Remove local to avoid shadowing.
1600 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1602 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1603 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1605 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1607 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1609 Fix regex.c, syntax.c and friends for buffers > 2GB.
1610 * syntax.h (struct gl_state_s): Declare character position members
1613 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1615 * textprop.c (verify_interval_modification, interval_of):
1616 Declare arguments EMACS_INT.
1618 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1621 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1623 * indent.c (Fvertical_motion): Local variable it_start is now
1626 * regex.c (re_match, re_match_2, re_match_2_internal)
1627 (bcmp_translate, regcomp, regexec, print_double_string)
1628 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1629 (re_compile_pattern, re_exec): Declare arguments and local
1630 variables `size_t' and `ssize_t' and return values `regoff_t', as
1632 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1633 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1634 <compile_stack_type>: `size' and `avail' are now `size_t'.
1636 * regex.h <regoff_t>: Use ssize_t, not int.
1637 (re_search, re_search_2, re_match, re_match_2): Arguments that
1638 specify buffer/string position and length are now ssize_t and
1639 size_t. Return type is regoff_t.
1641 2011-04-16 Ben Key <bkey76@gmail.com>
1643 * nsfont.m: Fixed bugs in ns_get_family and
1644 ns_descriptor_to_entity that were caused by using free to
1645 deallocate memory blocks that were allocated by xmalloc (via
1646 xstrdup). This caused Emacs to crash when compiled with
1647 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1648 --enable-checking=xmallocoverrun). xfree is now used to
1649 deallocate these memory blocks.
1651 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1653 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1655 emacs_write: Accept and return EMACS_INT for sizes.
1656 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1658 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1659 Accept and return EMACS_INT.
1660 (emacs_gnutls_write): Return the number of bytes written on
1662 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1663 (emacs_read, emacs_write): Remove check for negative size, as the
1664 Emacs source code has been audited now.
1665 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1666 (emacs_read, emacs_write): Use it.
1667 * process.c (send_process): Adjust to the new signatures of
1668 emacs_write and emacs_gnutls_write. Do not attempt to store
1669 a byte offset into an 'int'; it might overflow.
1670 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1672 * sound.c: Don't assume sizes fit in 'int'.
1673 (struct sound_device.period_size, alsa_period_size):
1674 Return EMACS_INT, not int.
1675 (struct sound_device.write, vox_write, alsa_write):
1676 Accept EMACS_INT, not int.
1677 (wav_play, au_play): Use EMACS_INT to store sizes and to
1678 record read return values.
1680 2011-04-15 Ben Key <bkey76@gmail.com>
1682 * keyboard.c (Qundefined): Don't declare static since it is used
1684 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1685 static since they are used in nsfont.m.
1687 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1689 * process.c (Qprocessp): Don't declare static.
1690 * lisp.h (Qprocessp): Declare again.
1692 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1694 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1696 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1698 Improve C-level modularity by making more things 'static'.
1700 Don't publish debugger-only interfaces to other modules.
1701 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1702 (verify_bytepos, count_markers): Move decls to the only modules
1704 * region-cache.h (pp_cache): Likewise.
1705 * window.h (check_all_windows): Likewise.
1706 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1708 * sysdep.c (croak): Now static, if
1709 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1710 * syssignal.h (croak): Declare only if not static.
1712 * alloc.c (refill_memory_reserve): Now static if
1713 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1714 * lisp.h (refill_memory_reserve): Declare only if not static.
1716 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1717 Define only if USE_LUCID.
1719 * xrdb.c (x_customization_string, x_rm_string): Now static.
1721 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1722 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1724 * xdisp.c (draw_row_with_mouse_face): Now static.
1725 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1727 * window.h (check_all_windows): Mark externally visible.
1729 * window.c (window_deletion_count): Now static.
1731 * undo.c: Make symbols static if they're not exported.
1732 (last_undo_buffer, last_boundary_position, pending_boundary):
1735 * textprop.c (interval_insert_behind_hooks): Now static.
1736 (interval_insert_in_front_hooks): Likewise.
1738 * term.c: Make symbols static if they're not exported.
1739 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1740 (max_frame_lines, tty_set_terminal_modes):
1741 (tty_reset_terminal_modes, tty_turn_off_highlight):
1742 (get_tty_terminal): Now static.
1743 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1744 * termhooks.h (term_mouse_moveto): Do not declare if
1746 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1747 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1749 * sysdep.c: Make symbols static if they're not exported.
1750 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1752 (sigprocmask_set, full_mask): Remove; unused.
1753 (wait_debugging): Mark as visible.
1754 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1755 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1757 * syntax.c (syntax_temp): Define only if !__GNUC__.
1759 * sound.c (current_sound_device, current_sound): Now static.
1761 * search.c (searchbufs, searchbuf_head): Now static.
1763 * scroll.c (scroll_cost): Remove; unused.
1764 * dispextern.h (scroll_cost): Remove decl.
1766 * region-cache.h (pp_cache): Mark as externally visible.
1768 * process.c: Make symbols static if they're not exported.
1769 (process_tick, update_tick, create_process, chan_process):
1770 (Vprocess_alist, proc_buffered_char, datagram_access):
1771 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1772 (deactivate_process): Mark defn as static, as well as decl.
1773 * lisp.h (create_process): Remove decl.
1774 * process.h (chan_process, Vprocess_alist): Remove decls.
1776 * print.c: Make symbols static if they're not exported.
1777 (print_depth, new_backquote_output, being_printed, print_buffer):
1778 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1779 (print_interval, print_number_index, initial_stderr_stream):
1781 * lisp.h (Fprinc): Remove decl.
1782 (debug_output_compilation_hack): Mark as externally visible.
1784 * sysdep.c (croak): Move decl from here to syssignal.h.
1785 * syssignal.h (croak): Put it here, so the API can be checked when
1786 'croak' is called from dissociate_if_controlling_tty.
1788 * minibuf.c: Make symbols static if they're not exported.
1789 (minibuf_save_list, choose_minibuf_frame): Now static.
1790 * lisp.h (choose_minibuf_frame): Remove decl.
1792 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1794 * lread.c: Make symbols static if they're not exported.
1795 (read_objects, initial_obarray, oblookup_last_bucket_number):
1797 (make_symbol): Remove; unused.
1798 * lisp.h (initial_obarray, make_symbol): Remove decls.
1800 * keyboard.c: Make symbols static if they're not exported.
1801 (single_kboard, recent_keys_index, total_keys, recent_keys):
1802 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1803 (this_single_command_key_start, echoing, last_auto_save):
1804 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1805 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1806 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1807 (Vlispy_mouse_stem, double_click_count):
1809 (force_auto_save_soon): Define only if SIGDANGER.
1810 (ignore_mouse_drag_p): Now static if
1811 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1812 (print_help): Remove; unused.
1813 (stop_character, last_timer_event): Mark as externally visible.
1814 * keyboard.h (ignore_mouse_drag_p): Declare only if
1815 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1816 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1817 * lisp.h (echoing): Remove decl.
1818 (force_auto_save_soon): Declare only if SIGDANGER.
1819 * xdisp.c (redisplay_window): Simplify code, to make it more
1820 obvious that ignore_mouse_drag_p is not accessed if !defined
1821 USE_GTK && !defined HAVE_NS.
1823 * intervals.c: Make symbols static if they're not exported.
1824 (merge_properties_sticky, merge_interval_right, delete_interval):
1826 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1828 * insdel.c: Make symbols static if they're not exported.
1829 However, leave prepare_to_modify_buffer alone. It's never
1830 called from outside this function, but that appears to be a bug.
1831 (combine_after_change_list, combine_after_change_buffer):
1832 (adjust_after_replace, signal_before_change): Now static.
1833 (adjust_after_replace_noundo): Remove; unused.
1834 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1835 (signal_before_change): Remove decls.
1837 * indent.c (val_compute_motion, val_vmotion): Now static.
1839 * image.c: Make symbols static if they're not exported.
1840 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1842 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1843 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1845 * fringe.c (standard_bitmaps): Now static.
1846 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1848 * frame.c: Make symbols static if they're not exported.
1849 (x_report_frame_params, make_terminal_frame): Now static.
1850 (get_frame_param): Now static, unless HAVE_NS.
1851 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1852 (x_get_resource_string): Remove; not used.
1853 * frame.h (make_terminal_frame, x_report_frame_params):
1854 (x_get_resource_string); Remove decls.
1855 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1856 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1858 * font.c, fontset.c: Make symbols static if they're not exported.
1859 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1860 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1861 * font.c (font_close_object): Now static.
1862 * font.h (font_close_object): Remove.
1863 * fontset.c (FONTSET_OBJLIST): Remove.
1864 (free_realized_fontset) #if-0 the body, which does nothing.
1865 (face_suitable_for_char_p): #if-0, as it's never called.
1866 * fontset.h (face_suitable_for_char_p): Remove decl.
1867 * xfaces.c (face_at_string_position):
1868 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1869 since 0 is always ASCII.
1871 * fns.c (weak_hash_tables): Now static.
1873 * fileio.c: Make symbols static if they're not exported.
1874 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1875 (Vwrite_region_annotation_buffers): Now static.
1877 * eval.c: Make symbols static if they're not exported.
1878 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1879 * lisp.h (backtrace_list): Remove decl.
1881 * emacs.c: Make symbols static if they're not exported.
1882 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1883 (fatal_error_code, fatal_error_signal_hook, standard_args):
1885 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1886 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1887 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1888 * lisp.h (fatal_error_signal_hook): Remove decl.
1889 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1891 * editfns.c: Move a (normally-unused) function to its only use.
1892 * editfns.c, lisp.h (get_operating_system_release): Remove.
1893 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1894 worth the hassle of breaking this out.
1896 * xterm.c: Make symbols static if they're not exported.
1897 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1898 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1899 (x_destroy_window, x_delete_display):
1901 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1902 (x_mouse_leave): Remove; unused.
1903 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1904 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1905 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1907 (x_mouse_leave): Declare only if WINDOWSNT.
1908 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1909 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1912 * ftxfont.c: Make symbols static if they're not exported.
1913 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1915 * font.h (ftxfont_driver): Likewise.
1917 * xfns.c: Make symbols static if they're not exported.
1918 (x_last_font_name, x_display_info_for_name):
1919 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1920 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1921 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1922 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1923 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1924 (last_show_tip_args): Now static.
1925 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1926 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1927 (x_screen_planes): Remove; unused.
1928 * dispextern.h (x_screen_planes): Remove decl.
1930 * dispnew.c: Make symbols static if they're not exported.
1931 * dispextern.h (redraw_garbaged_frames, scrolling):
1932 (increment_row_positions): Remove.
1933 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1934 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1936 (redraw_garbaged_frames): Remove; unused.
1938 * xfaces.c: Make symbols static if they're not exported.
1939 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1941 * xterm.h (defined_color): Remove decls.
1942 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1943 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1944 (menu_face_changed_default, defined_color, free_realized_face):
1945 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1946 (ascii_face_of_lisp_face): Remove; unused.
1948 * xdisp.c: Make symbols static if they're not exported.
1949 * dispextern.h (scratch_glyph_row, window_box_edges):
1950 (glyph_to_pixel_coords, set_cursor_from_row):
1951 (get_next_display_element, set_iterator_to_next):
1952 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1953 (show_mouse_face): Remove decls
1954 * frame.h (message_buf_print): Likewise.
1955 * lisp.h (pop_message, set_message, check_point_in_composition):
1957 * xterm.h (set_vertical_scroll_bar): Likewise.
1958 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1959 (message_buf_print, scratch_glyph_row, displayed_buffer):
1960 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1961 (get_next_display_element, show_mouse_face, window_box_edges):
1962 (frame_to_window_pixel_xy, check_point_in_composition):
1963 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1964 (glyph_to_pixel_coords): Remove; unused.
1966 * dired.c (file_name_completion): Now static.
1968 * dbusbind.c (xd_in_read_queued_messages): Now static.
1970 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1971 * data.c (circular_list_error): Remove.
1973 * commands.h (last_point_position, last_point_position_buffer):
1974 (last_point_position_window): Remove decls.
1975 * keyboard.c: Make these variables static.
1977 * coding.h (coding, code_convert_region, encode_coding_gap):
1979 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1980 (iso_code_class, detect_coding, code_convert_region): Now static.
1981 (encode_coding_gap): Remove; unused.
1983 * chartab.c (chartab_chars, chartab_bits): Now static.
1985 * charset.h (charset_iso_8859_1): Remove decl.
1986 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1989 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1990 * ccl.c (Vccl_program_table): Now static.
1991 (check_ccl_update): Remove; unused.
1993 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1994 * category.h: ... from here.
1995 * category.c (check_category_table, set_category_set): Now static.
1997 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1998 * lisp.h: Remove these decls.
2000 * buffer.c (buffer_count): Remove unused var.
2002 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2003 so that it's not optimized away.
2004 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2005 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2006 exported only to the debugger.
2008 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2009 * atimer.h (run_all_atimers): Remove; not exported.
2011 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2012 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2013 was inaccessible from Lisp.
2014 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2015 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2017 alloc.c: Import and export fewer symbols, and remove unused items.
2018 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2020 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2021 it's not optimized away by whole-program optimization.
2022 (message_enable_multibyte, free_misc): Remove.
2023 (catchlist, handlerlist, mark_backtrace):
2024 Declare only if BYTE_MARK_STACK.
2025 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2026 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2027 (message_enable_multibyte): Remove decl.
2028 (free_misc, interval_free_list, float_block, float_block_index):
2029 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2030 (cons_free_list, last_marked_index):
2032 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2033 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2034 (mark_backtrace): Define only if BYTE_MARK_STACK.
2035 * xdisp.c (message_enable_multibyte): Now static.
2037 Declare Lisp_Object Q* variables to be 'static' if not exported.
2038 This makes it easier for human readers (and static analyzers)
2039 to see whether these variables are used from other modules.
2040 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2041 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2042 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2043 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2044 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2045 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2046 * xmenu.c, xselect.c:
2047 Declare Q* vars static if they are not used in other modules.
2048 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2049 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2050 Remove decls of unexported vars.
2051 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2053 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2055 Make Emacs functions such as Fatom 'static' by default.
2056 This makes it easier for human readers (and static analyzers)
2057 to see whether these functions can be called from other modules.
2058 DEFUN now defines a static function. To make the function external
2059 so that it can be used in other C modules, use the new macro DEFUE.
2060 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2061 (Finit_image_library):
2062 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2063 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2064 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2065 Remove decls, since these functions are now static.
2066 (Funintern, Fget_internal_run_time): New decls, since these functions
2067 were already external.
2069 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2070 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2071 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2072 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2073 * keyboard.c, keymap.c, lread.c:
2074 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2075 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2076 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2077 Mark functions with DEFUE instead of DEFUN,
2078 if they are used in other modules.
2079 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2080 decls for now-static functions.
2081 * buffer.h (Fdelete_overlay): Remove decl.
2082 * callproc.c (Fgetenv_internal): Mark as internal.
2083 * composite.c (Fremove_list_of_text_properties): Remove decl.
2084 (Fcomposition_get_gstring): New forward static decl.
2085 * composite.h (Fcomposite_get_gstring): Remove decl.
2086 * dired.c (Ffile_attributes): New forward static decl.
2087 * doc.c (Fdocumntation_property): New forward static decl.
2088 * eval.c (Ffetch_bytecode): New forward static decl.
2089 (Funintern): Remove extern decl; now in .h file where it belongs.
2090 * fileio.c (Fmake_symbolic_link): New forward static decl.
2091 * image.c (Finit_image_library): New forward static decl.
2092 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2093 * intervals.h (Fprevious_property_change):
2094 (Fremove_list_of_text_properties): Remove decls.
2095 * keyboard.c (Fthis_command_keys): Remove decl.
2096 (Fcommand_execute): New forward static decl.
2097 * keymap.c (Flookup_key): New forward static decl.
2098 (Fcopy_keymap): Now static.
2099 * keymap.h (Flookup_key): Remove decl.
2100 * process.c (Fget_process): New forward static decl.
2101 (Fprocess_datagram_address): Mark as internal.
2102 * syntax.c (Fsyntax_table_p): New forward static decl.
2103 (skip_chars): Remove duplicate decl.
2104 * textprop.c (Fprevious_property_change): New forward static decl.
2105 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2107 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2108 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2110 * editfns.c (Fformat): Remove unreachable code.
2112 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2114 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2117 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2119 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2120 when at ZV. (Bug#8487)
2122 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2124 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2126 * keyboard.c (parse_tool_bar_item): Likewise.
2127 * sound.c (sound_cleanup, alsa_close): Likewise.
2128 * termcap.c (tgetent): Likewise.
2129 * xfns.c (x_default_font_parameter): Likewise.
2130 * xsettings.c (read_and_apply_settings): Likewise.
2132 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2133 (overrun_check_free): Protoize.
2135 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2137 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2138 since callers should never pass a negative size.
2139 Change the signature to match that of plain 'read' and 'write'; see
2140 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2141 * lisp.h: Update prototypes of emacs_write and emacs_read.
2143 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2145 * xdisp.c (redisplay_window): Don't try to determine the character
2146 position of the scroll margin if the window start point w->startp
2147 is outside the buffer's accessible region. (Bug#8468)
2149 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2151 Fix write-region and its subroutines for buffers > 2GB.
2152 * fileio.c (a_write, e_write): Modify declaration of arguments and
2153 local variables to support buffers larger than 2GB.
2154 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2156 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2157 argument, local variables, and return value.
2159 * lisp.h: Update prototypes of emacs_write and emacs_read.
2161 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2163 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2165 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2167 Fix more problems found by GCC 4.6.0's static checks.
2169 * xdisp.c (vmessage): Use a better test for character truncation.
2171 * charset.c (load_charset_map): <, not <=, for optimization,
2172 and to avoid potential problems with integer overflow.
2173 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2174 * casetab.c (set_identity, shuffle): Likewise.
2175 * editfns.c (Fformat): Likewise.
2176 * syntax.c (skip_chars): Likewise.
2178 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2179 This also lets GCC 4.6.0 generate slightly better loop code.
2181 * callint.c (Fcall_interactively): <, not <=, for optimization.
2182 (Fcall_interactively): Count the number of arguments produced,
2183 not the number of arguments given. This is simpler and lets GCC
2184 4.6.0 generate slightly better code.
2186 * ftfont.c: Distingish more carefully between FcChar8 and char.
2187 The previous code passed unsigned char * to a functions like
2188 strlen and xstrcasecmp that expect char *, which does not
2189 conform to the C standard.
2190 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2191 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2192 char * when the C standard requires it.
2194 * keyboard.c (read_char): Remove unused var.
2196 * eval.c: Port to Windows vsnprintf (Bug#8435).
2198 (SIZE_MAX): Define if the headers do not.
2199 (verror): Do not give up if vsnprintf returns a negative count.
2200 Instead, grow the buffer. This ports to Windows vsnprintf, which
2201 does not conform to C99. Problem reported by Eli Zaretskii.
2202 Also, simplify the allocation scheme, by avoiding the need for
2203 calling realloc, and removing the ALLOCATED variable.
2205 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2207 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2208 But keep the doprint source code for now, as we might revamp it
2209 and use it again (Bug#8435).
2210 * lisp.h (doprnt): Remove.
2211 * Makefile.in (base_obj): Remove doprnt.o.
2212 * deps.mk (doprnt.o): Remove.
2214 error: Print 32- and 64-bit integers portably (Bug#8435).
2215 Without this change, on typical 64-bit hosts error ("...%d...", N)
2216 was used to print both 32- and 64-bit integers N, which relied on
2218 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2220 * lisp.h (error, verror): Mark as printf-like functions.
2221 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2222 Report overflow in size calculations when allocating printf buffer.
2223 Do not truncate output string at its first null byte.
2224 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2225 Truncate the output at a character boundary, since vsnprintf does not
2227 * charset.c (check_iso_charset_parameter): Convert internal
2228 character to string before calling 'error', since %c now has the
2230 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2231 overflow when computing char to be passed to 'error'. Do not
2232 pass Lisp_Object to 'error'; pass the integer instead.
2233 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2234 formatted with plain %d.
2236 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2238 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2240 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2242 * xterm.c (x_catch_errors): Remove duplicate declaration.
2244 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2246 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2248 2011-04-10 Jim Meyering <meyering@redhat.com>
2250 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2251 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2252 return ssize_t not "int", and use size_t as the buffer length.
2253 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2254 * gnutls.h: Update declarations.
2255 * process.c (read_process_output): Use ssize_t, to match.
2256 (send_process): Likewise.
2258 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2260 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2262 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2264 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2265 Use unsigned char, to match FcChar8 type definition.
2267 * xterm.c (handle_one_xevent):
2268 * xmenu.c (create_and_show_popup_menu):
2269 * xselect.c (x_decline_selection_request)
2270 (x_reply_selection_request): Avoid type-punned deref of X events.
2272 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2274 Fix some uses of `int' instead of EMACS_INT.
2275 * search.c (string_match_1, fast_string_match)
2276 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2277 (scan_buffer, find_next_newline_no_quit)
2278 (find_before_next_newline, search_command, Freplace_match)
2279 (Fmatch_data): Make some `int' variables be EMACS_INT.
2281 * xdisp.c (display_count_lines): 3rd argument and return value now
2282 EMACS_INT. All callers changed.
2283 (pint2hrstr): Last argument is now EMACS_INT.
2285 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2286 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2287 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2288 (decode_coding_utf_16, decode_coding_emacs_mule)
2289 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2290 (decode_coding_ccl, decode_coding_charset)
2291 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2292 (decode_coding_iso_2022, decode_coding_emacs_mule)
2293 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2294 <char_offset, last_offset>: Declare EMACS_INT.
2295 (encode_coding_utf_8, encode_coding_utf_16)
2296 (encode_coding_emacs_mule, encode_invocation_designation)
2297 (encode_designation_at_bol, encode_coding_iso_2022)
2298 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2299 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2301 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2302 (encode_invocation_designation): Last argument P_NCHARS is now
2304 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2305 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2307 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2310 * ccl.c (Fccl_execute_on_string): Declare some variables
2313 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2315 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2317 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2319 * process.c (Fformat_network_address): Doc fix.
2321 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2323 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2325 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2327 * keyboard.c (read_char): Call Lisp function help-form-show,
2328 instead of using internal_with_output_to_temp_buffer.
2329 (Qhelp_form_show): New var.
2330 (syms_of_keyboard): Use DEFSYM macro.
2332 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2334 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2336 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2338 * process.c (Flist_processes): Remove to Lisp.
2339 (list_processes_1): Delete.
2341 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2343 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2345 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2347 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2349 Fix more problems found by GCC 4.6.0's static checks.
2351 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2353 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2355 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2357 * xdisp.c (vmessage): Mark as a printf-like function.
2359 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2361 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2363 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2364 printf-like functions.
2365 (tiff_load): Add casts to remove these marks before passing them
2366 to system-supplied API.
2368 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2370 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2371 This avoids several warnings with gcc -Wstrict-overflow.
2372 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2373 directly, rather than having caller test rule sign. This avoids
2374 some unnecessary tests.
2375 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2376 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2377 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2379 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2380 (xfont_open): Avoid unnecessary tests.
2382 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2384 * composite.h, composite.c (composition_gstring_put_cache):
2385 Use EMACS_INT, not int, for length.
2387 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2388 breaking out part of COMPOSITION_DECODE_RULE.
2389 (COMPOSITION_DECODE_RULE): Use it.
2390 * composite.c (get_composition_id): Remove unused local vars,
2391 by using the new macro.
2393 * textprop.c (set_text_properties_1): Change while to do-while,
2394 since the condition is always true at first.
2396 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2397 (interval_deletion_adjustment): Return unsigned value.
2400 * process.c (list_processes_1, create_pty, read_process_output):
2401 (exec_sentinel): Remove vars that were set but not used.
2402 (create_pty): Remove unnecessary "volatile"s.
2403 (Fnetwork_interface_info): Avoid possibility of int overflow.
2404 (read_process_output): Do adaptive read buffering even if carryover.
2405 (read_process_output): Simplify nbytes computation if buffered.
2407 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2409 * syntax.c (scan_words): Remove var that was set but not used.
2410 (update_syntax_table): Use unsigned instead of int.
2412 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2413 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2414 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2416 * print.c (print_error_message): Avoid int overflow.
2418 * font.c (font_list_entities): Redo for clarity,
2419 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2421 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2422 (font_score): Avoid potential overflow in diff calculation.
2424 * fns.c (substring_both): Remove var that is set but not used.
2425 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2427 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2429 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2430 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2431 can always succeed if overflow has undefined behavior.
2433 * search.c (boyer_moore, wordify): Remove vars set but not used.
2434 (wordify): Omit three unnecessary tests.
2436 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2437 All callers changed. This avoids the need for an unused var.
2439 * casefiddle.c (casify_region): Remove var that is set but not used.
2441 * dired.c (file_name_completion): Remove var that is set but not used.
2443 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2445 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2446 (Finsert_file_contents): Remove unnecessary code checking fd.
2448 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2449 Check for integer overflow on size calculations.
2451 * buffer.c (Fprevious_overlay_change): Remove var that is set
2454 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2455 Remove vars that are set but not used.
2456 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2457 (timer_check_2): Mark vars as initialized.
2459 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2461 * image.c (lookup_image): Remove var that is set but not used.
2462 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2464 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2465 that are set but not used.
2467 * xfns.c (make_invisible_cursor): Don't return garbage
2468 if XCreateBitmapFromData fails (Bug#8410).
2470 * xselect.c (x_get_local_selection, x_handle_property_notify):
2471 Remove vars that are set but not used.
2473 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2474 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2476 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2477 Remove var that is set but not used.
2478 (scroll_bar_windows_size): Now size_t, not int.
2479 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2482 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2483 (map_tty_color) [!defined MSDOS]: Likewise.
2485 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2487 * coding.c: Remove vars that are set but not used.
2488 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2489 All callers changed.
2490 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2491 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2492 (decode_coding_charset): Remove vars that are set but not used.
2494 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2495 that is set but not used.
2497 * print.c (print_object): Remove var that is set but not used.
2499 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2500 The gnulib version avoids calling malloc in the usual case,
2501 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2502 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2503 * filelock.c (current_lock_owner): Likewise.
2504 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2505 * sysdep.c: Include allocator.h, careadlinkat.h.
2506 (emacs_no_realloc_allocator): New static constant.
2507 (emacs_readlink): New function.
2508 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2509 ../lib/careadlinkat.h.
2511 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2513 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2514 first non-nil return value).
2516 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2518 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2519 if not defined (Bug#8403).
2521 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2523 * xdisp.c (display_count_lines): Remove parameter `start',
2524 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2525 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2526 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2527 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2528 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2529 and thereabouts. All callers changed.
2530 (get_per_char_metric): Remove parameter `f', unused since
2531 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2533 2011-04-02 Jim Meyering <meyering@redhat.com>
2535 do not dereference NULL upon failed strdup
2536 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2537 (ns_get_family): Likewise.
2539 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2541 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2543 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2545 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2548 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2550 Add lexical binding.
2552 * window.c (Ftemp_output_buffer_show): New fun.
2553 (Fsave_window_excursion):
2554 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2556 * lread.c (lisp_file_lexically_bound_p): New function.
2557 (Fload): Bind Qlexical_binding.
2558 (readevalloop): Remove `evalfun' arg.
2559 Bind Qinternal_interpreter_environment.
2560 (Feval_buffer): Bind Qlexical_binding.
2561 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2563 (syms_of_lread): Declare `lexical-binding'.
2565 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2567 * keyboard.c (eval_dyn): New fun.
2568 (menu_item_eval_property): Use it.
2570 * image.c (parse_image_spec): Use Ffunctionp.
2572 * fns.c (concat, mapcar1): Accept byte-code-functions.
2574 * eval.c (Fsetq): Handle lexical vars.
2575 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2576 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2577 (FletX, Flet): Obey lexical binding.
2578 (Fcommandp): Handle closures.
2579 (Feval): New `lexical' arg.
2580 (eval_sub): New function extracted from Feval. Use it almost
2581 everywhere where Feval was used. Look up vars in lexical env.
2583 (Ffunctionp): Move from subr.el.
2584 (Ffuncall): Handle closures.
2585 (apply_lambda): Remove `eval_flags'.
2586 (funcall_lambda): Handle closures and new byte-code-functions.
2587 (Fspecial_variable_p): New function.
2588 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2589 but without exporting it to Lisp.
2591 * doc.c (Fdocumentation, store_function_docstring):
2592 * data.c (Finteractive_form): Handle closures.
2594 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2597 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2599 (exec_byte_code): New function extracted from Fbyte_code to handle new
2600 calling convention for byte-code-functions. Add new byte-codes.
2602 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2604 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2606 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2608 * xdisp.c (redisplay_internal): Fix prototype.
2610 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2612 * xdisp.c (SCROLL_LIMIT): New macro.
2613 (try_scrolling): Use it when setting scroll_limit.
2614 Limit scrolling to 100 screen lines.
2615 (redisplay_window): Even when falling back on "recentering",
2616 position point in the window according to scroll-conservatively,
2617 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2619 (try_scrolling): When point is above the window, allow searching
2620 as far as scroll_max, or one screenful, to compute vertical
2621 distance from PT to the scroll margin position. This prevents
2622 try_scrolling from unnecessarily failing when
2623 scroll-conservatively is set to a value slightly larger than the
2624 window height. Clean up the case of PT below the margin at bottom
2625 of window: scroll_max can no longer be INT_MAX. When aggressive
2626 scrolling is in use, don't let point enter the opposite scroll
2627 margin as result of the scroll.
2628 (syms_of_xdisp) <scroll-conservatively>: Document the
2629 threshold of 100 lines for never-recentering scrolling.
2631 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2633 * dispextern.h (move_it_by_lines):
2634 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2635 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2636 (message_log_check_duplicate): Remove parameters `prev_bol' and
2637 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2638 (redisplay_internal): Remove parameter `preserve_echo_area',
2639 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2641 * indent.c (Fvertical_motion):
2642 * window.c (window_scroll_pixel_based, Frecenter):
2643 Don't pass `need_y_p' to `move_it_by_lines'.
2645 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2647 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2648 steal a few bits to be more compact.
2649 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2650 Remove unneeded casts.
2652 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2654 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2656 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2657 binding" message (bug#7967).
2659 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2661 Fix more problems found by GCC 4.6.0's static checks.
2663 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2664 Remove unused local var.
2666 * editfns.c (Fmessage_box): Remove unused local var.
2668 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2669 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2670 Omit unused local vars.
2671 * window.c (shrink_windows): Omit unused local var.
2672 * menu.c (digest_single_submenu): Omit unused local var.
2673 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2674 Omit unused local var.
2676 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2677 Don't assume string length fits in int.
2678 (keyremap_step, read_key_sequence): Use size_t for sizes.
2679 (read_key_sequence): Don't check last_real_key_start redundantly.
2681 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2682 instead of alloca (Bug#8344).
2684 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2685 (Fbacktrace_frame): Don't assume nframes fits in int.
2687 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2689 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2692 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2694 * cm.c (calccost): Turn while-do into do-while, for clarity.
2696 * keyboard.c (syms_of_keyboard): Use the same style as later
2697 in this function when indexing through an array. This also
2698 works around GCC bug 48267.
2700 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2702 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2704 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2705 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2707 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2708 This avoids undefined behavior on integer overflow, and is a bit
2709 more convenient anyway since it is compared to a size_t variable.
2711 Variadic C functions now count arguments with size_t, not int.
2712 This avoids an unnecessary limitation on 64-bit machines, which
2713 caused (substring ...) to crash on large vectors (Bug#8344).
2714 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2715 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2716 All variadic functions and their callers changed accordingly.
2717 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2718 * data.c (arith_driver, float_arith_driver): Likewise.
2719 * editfns.c (general_insert_function): Likewise.
2720 * eval.c (struct backtrace.nargs, interactive_p)
2721 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2722 (funcall_lambda, mark_backtrace): Likewise.
2723 * fns.c (concat): Likewise.
2724 * frame.c (x_set_frame_parameters): Likewise.
2725 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2726 0 if not found, not -1. All callers changed.
2728 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2729 (stack_copy_size): Now size_t, not int.
2730 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2732 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2734 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2735 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2736 All callers changed.
2738 * lisp.h (multibyte_char_to_unibyte):
2739 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2740 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2741 * character.h (CHAR_TO_BYTE8):
2742 * cmds.c (internal_self_insert):
2743 * editfns.c (general_insert_function):
2744 * keymap.c (push_key_description):
2745 * search.c (Freplace_match):
2746 * xdisp.c (message_dolog, set_message_1): All callers changed.
2748 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2750 * keyboard.c (safe_run_hook_funcall): New function.
2751 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2752 don't set the hook to nil, but remove the offending function instead.
2753 (Qcommand_hook_internal): Remove, unused.
2754 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2755 Vcommand_hook_internal.
2757 * eval.c (enum run_hooks_condition): Remove.
2758 (funcall_nil, funcall_not): New functions.
2759 (run_hook_with_args): Call each function through a `funcall' argument.
2760 Remove `cond' argument, now redundant.
2761 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2762 (Frun_hook_with_args_until_failure): Adjust accordingly.
2763 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2765 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2767 * dispextern.h (string_buffer_position): Remove declaration.
2769 * print.c (strout): Remove parameter `multibyte', unused since
2770 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2772 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2773 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2774 All callers changed.
2776 * w32.c (_wsa_errlist): Use braces for struct initializers.
2778 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2779 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2780 All callers changed.
2781 (string_buffer_position): Likewise. Also, make static (it's never
2782 used outside xdisp.c).
2783 (cursor_row_p): Remove parameter `w', unused since
2784 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2785 (decode_mode_spec): Remove parameter `precision', introduced during
2786 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2787 All callers changed.
2789 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2791 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2793 2011-03-27 Anders Lindgren <andlind@gmail.com>
2795 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2796 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2797 (ns_update_auto_hide_menu_bar): New functions.
2798 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2799 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2800 ns_constrain_all_frames.
2801 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2802 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2804 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2806 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2808 2011-03-27 Glenn Morris <rgm@gnu.org>
2810 * syssignal.h: Replace RETSIGTYPE with void.
2811 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2812 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2813 Replace SIGTYPE with void everywhere.
2814 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2815 * s/template.h (SIGTYPE): Remove commented out definition.
2817 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2819 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2820 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2822 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2824 * w32.c (read_unc_volume): Use parameter `henum', instead of
2825 global variable `wget_enum_handle'.
2827 * keymap.c (describe_vector): Remove parameters `indices' and
2828 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2829 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2831 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2833 * keyboard.c (timer_check): Remove parameter `do_it_now',
2834 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2835 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2836 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2838 * keyboard.c (read_char):
2839 * w32menu.c (w32_menu_display_help):
2840 * xmenu.c (show_help_event, menu_help_callback):
2841 Adjust calls to `show_help_echo'.
2843 * gtkutil.c (xg_maybe_add_timer):
2844 * keyboard.c (readable_events):
2845 * process.c (wait_reading_process_output):
2846 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2848 * insdel.c (adjust_markers_gap_motion):
2849 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2850 (gap_left, gap_right): Don't call it.
2852 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2854 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2855 incurred during fontification.
2857 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2859 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2860 (DEFVAR_PER_BUFFER): Don't pass it.
2862 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2863 (scrolling_window): Don't pass it.
2865 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2867 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2869 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2871 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2872 of variables specific to SELinux and computation of `encoded_absname'.
2874 * image.c (XPutPixel): Remove unused variable `height'.
2876 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2878 * unexw32.c (get_section_info): Remove unused variable `section'.
2880 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2881 (system_process_attributes): Remove unused variable `sess'.
2882 (sys_read): Remove unused variable `err'.
2884 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2885 (w32_wnd_proc): Remove unused variable `isdead'.
2886 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2887 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2888 (x_create_tip_frame): Remove unused variable `tem'.
2890 * w32inevt.c (w32_console_read_socket):
2891 Remove unused variable `no_events'.
2893 * w32term.c (x_draw_composite_glyph_string_foreground):
2894 Remove unused variable `width'.
2896 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2898 * w32term.c (x_set_glyph_string_clipping):
2899 Don't pass uninitialized region to CombineRgn.
2901 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2903 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2904 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2905 (Fx_close_connection): Remove unused variable `i'.
2907 * w32font.c (w32font_draw): Return number of glyphs.
2908 (w32font_open_internal): Remove unused variable `i'.
2909 (w32font_driver): Add missing initializer.
2911 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2912 (fill_in_menu): Remove unused variable `items_added'.
2914 * w32term.c (last_mouse_press_frame): Remove static global variable.
2915 (w32_clip_to_row): Remove unused variable `f'.
2916 (x_delete_terminal): Remove unused variable `i'.
2918 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2919 (NOTHING): Remove unused static global variable.
2920 (uniscribe_check_otf): Remove unused variable `table'.
2921 (uniscribe_font_driver): Add missing initializers.
2923 2011-03-23 Julien Danjou <julien@danjou.info>
2925 * term.c (Fsuspend_tty, Fresume_tty):
2926 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2927 * window.c (temp_output_buffer_show):
2928 * insdel.c (signal_before_change):
2929 * frame.c (Fhandle_switch_frame):
2930 * fileio.c (Fdo_auto_save):
2931 * emacs.c (Fkill_emacs):
2932 * editfns.c (save_excursion_restore):
2933 * cmds.c (internal_self_insert):
2934 * callint.c (Fcall_interactively):
2935 * buffer.c (Fkill_all_local_variables):
2936 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2938 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2939 unconditionnaly since it does the check itself.
2941 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2943 Fix more problems found by GCC 4.5.2's static checks.
2945 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2946 the first time through the loop, since we know p0 < p1 then.
2947 This also avoids a gcc -Wstrict-overflow warning.
2949 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2950 leading to a memory leak, possible in functions like
2951 load_charset_map_from_file that can allocate an unbounded number
2952 of objects (Bug#8318).
2954 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2955 that could (at least in theory) be that large.
2957 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2958 This is less likely to overflow, and avoids undefined behavior if
2959 overflow does occur. All callers changed. Use strtoul to scan
2960 for the unsigned long integer.
2961 (pint2hrstr): Simplify and tune code slightly.
2962 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2964 * scroll.c (do_scrolling): Work around GCC bug 48228.
2965 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2967 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2968 This also avoids a warning with gcc -Wstrict-overflow.
2969 (validate_x_resource_name): Simplify count usage.
2970 This also avoids a warning with gcc -Wstrict-overflow.
2972 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2975 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2977 * process.c (Fmake_network_process): Use socklen_t, not int,
2978 where POSIX says socklen_t is required in portable programs.
2979 This fixes a porting bug on hosts like 64-bit HP-UX, where
2980 socklen_t is wider than int (Bug#8277).
2981 (Fmake_network_process, server_accept_connection):
2982 (wait_reading_process_output, read_process_output):
2985 * process.c: Rename or move locals to avoid shadowing.
2986 (list_processes_1, Fmake_network_process):
2987 (read_process_output_error_handler, exec_sentinel_error_handler):
2988 Rename or move locals.
2989 (Fmake_network_process): Define label "retry_connect" only if needed.
2990 (Fnetwork_interface_info): Fix pointer signedness.
2991 (process_send_signal): Add cast to avoid pointer signedness problem.
2992 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2993 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2995 Make tparam.h and terminfo.c consistent.
2996 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2997 Include tparam.h instead, since it declares them.
2998 * cm.h (PC): Remove extern decl; tparam.h now does this.
2999 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3000 * terminfo.c: Include tparam.h, to check interfaces.
3001 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3002 (tparam): Adjust signature to match interface in tparam.h;
3003 this removes some undefined behavior. Check that outstring and len
3004 are zero, which they always are with Emacs.
3005 * tparam.h (PC, BC, UP): New extern decls.
3007 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3008 (xftfont_open): Rename locals to avoid shadowing.
3010 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3011 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3012 (OTF_TAG_SYM): Omit macro if not needed.
3013 (ftfont_list): Remove unused local.
3014 (get_adstyle_property, ftfont_pattern_entity):
3015 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3016 Rename locals to avoid shadowing.
3018 * xfont.c (xfont_list_family): Mark var as initialized.
3020 * xml.c (make_dom): Now static.
3022 * composite.c (composition_compute_stop_pos): Rename local to
3024 (composition_reseat_it): Remove unused locals.
3025 (find_automatic_composition, composition_adjust_point): Likewise.
3026 (composition_update_it): Mark var as initialized.
3027 (find_automatic_composition): Mark vars as initialized,
3028 with a FIXME (Bug#8290).
3030 character.h: Rename locals to avoid shadowing.
3031 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3032 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3033 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3034 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3037 * textprop.c (property_change_between_p): Remove; unused.
3039 * intervals.c (interval_start_pos): Now static.
3041 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3043 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3044 Rename locals to avoid shadowing.
3046 * sound.c (wav_play, au_play, Fplay_sound_internal):
3047 Fix pointer signedness.
3048 (alsa_choose_format): Remove unused local var.
3049 (wav_play): Initialize a variable to 0, to prevent undefined
3050 behavior (Bug#8278).
3052 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3054 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3056 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3057 clobbering (Bug#8298).
3058 * sysdep.c (sys_subshell): Likewise.
3059 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3061 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3062 This should get cleaned up, so that child_setup has the
3063 same signature on all platforms.
3065 * callproc.c (call_process_cleanup): Now static.
3066 (relocate_fd): Rename locals to avoid shadowing.
3068 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3070 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3071 not to be necessary, and produces flickering.
3073 2011-03-20 Glenn Morris <rgm@gnu.org>
3075 * config.in: Remove file.
3077 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3079 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3080 are now in src/globals.h.
3081 (syms_of_minibuf): Remove spurious & from previous change.
3083 2011-03-20 Leo <sdl.web@gmail.com>
3085 * minibuf.c (completing-read-function): New variable.
3086 (completing-read-default): Rename from completing-read.
3087 (completing-read): Call completing-read-function.
3089 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3091 * xfaces.c (Fx_load_color_file):
3092 Read color file from absolute filename (bug#8250).
3094 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3096 * makefile.w32-in: Update dependencies.
3098 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3100 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3102 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3104 Fix more problems found by GCC 4.5.2's static checks.
3106 * process.c (make_serial_process_unwind, send_process_trap):
3107 (sigchld_handler): Now static.
3109 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3110 That way, the code declares only the vars that it needs.
3111 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3112 * s/cygwin.h (PTY_ITERATION): Likewise.
3113 * s/darwin.h (PTY_ITERATION): Likewise.
3114 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3116 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3117 * process.c (allocate_pty): Don't declare stb unless it's needed.
3119 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3120 (CONSTANTLIM): Remove; unused.
3121 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3122 Define only if needed.
3124 * unexelf.c (unexec): Name an expression,
3125 to avoid gcc -Wbad-function-cast warning.
3126 Use a different way to cause a compilation error if anyone uses
3127 n rather than nn, a way that does not involve shadowing.
3128 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3130 * deps.mk (unexalpha.o): Remove; unused.
3132 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3133 * unexec.h: New file.
3134 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3135 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3137 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3138 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3139 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3140 Change as necessary to match prototype in unexec.h.
3142 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3144 (back_comment, skip_chars): Mark vars as initialized.
3146 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3147 Rename locals to avoid shadowing.
3149 * lread.c (read1): Rewrite so as not to use empty "else".
3150 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3152 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3154 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3155 warning when compiling print.c.
3157 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3158 instead of using an uninitialized var.
3159 (font_sort_entities): Mark var as initialized.
3161 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3163 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3164 pointers to constants.
3165 (font_parse_fcname): Remove unused vars.
3166 (font_delete_unmatched): Now static.
3167 (font_get_spec): Remove; unused.
3168 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3169 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3170 Rename or move locals to avoid shadowing.
3172 * fns.c (require_nesting_list, require_unwind): Now static.
3173 (Ffillarray): Rename locals to avoid shadowing.
3175 * floatfns.c (domain_error2): Define only if needed.
3176 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3178 * alloc.c (mark_backtrace): Move decl from here ...
3179 * lisp.h: ... to here, so that it can be checked.
3181 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3182 (Fdefvar): Rewrite so as not to use empty "else".
3183 (lisp_indirect_variable): Name an expression,
3184 to avoid gcc -Wbad-function-cast warning.
3185 (Fdefvar): Rename locals to avoid shadowing.
3187 * callint.c (quotify_arg, quotify_args): Now static.
3188 (Fcall_interactively): Rename locals to avoid shadowing.
3189 Use const pointer when appropriate.
3191 * lisp.h (get_system_name, get_operating_system_release):
3192 Move decls here, to check interfaces.
3193 * process.c (get_operating_system_release): Move decl to lisp.h.
3194 * xrdb.c (get_system_name): Likewise.
3195 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3196 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3197 some of which prompt warnings from gcc -Wbad-function-cast.
3198 (Fformat_time_string, Fencode_time, Finsert_char):
3199 (Ftranslate_region_internal, Fformat):
3200 Rename or remove local vars to avoid shadowing.
3201 (Ftranslate_region_internal): Mark var as initialized.
3203 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3206 * lisp.h (eassert): Check that the argument compiles, even if
3207 ENABLE_CHECKING is not defined.
3209 * data.c (Findirect_variable): Name an expression, to avoid
3210 gcc -Wbad-function-cast warning.
3211 (default_value, arithcompare, arith_driver, arith_error): Now static.
3212 (store_symval_forwarding): Rename local to avoid shadowing.
3213 (Fmake_variable_buffer_local, Fmake_local_variable):
3214 Mark variables as initialized.
3215 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3217 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3218 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3219 Rename locals to avoid shadowing.
3220 (mark_stack): Move local variables into the #ifdef region where
3222 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3223 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3225 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3226 (GC_STRING_CHARS): Remove; not used.
3227 (Fmemory_limit): Cast sbrk's returned value to char *.
3229 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3230 avoids undefined behavior in theory.
3232 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3234 Use functions, not macros, for up- and down-casing (Bug#8254).
3235 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3236 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3237 to use the following functions instead of these macros.
3238 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3239 EMACS_INT, since callers assume the returned value fits in int.
3240 (upcase1): Likewise, for UPCASE_TABLE.
3241 (uppercasep, lowercasep, upcase): New static inline functions.
3242 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3243 the race-condition problem in the old DOWNCASE.
3245 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3246 Rename locals to avoid shadowing.
3247 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3248 (regex_compile, re_search_2, re_match_2_internal):
3249 Remove unused local vars.
3250 (FREE_VAR): Rewrite so as not to use empty "else",
3251 which gcc can warn about.
3252 (regex_compile, re_match_2_internal): Mark locals as initialized.
3253 (RETALLOC_IF): Define only if needed.
3254 (WORDCHAR_P): Likewise. This one is never needed, but is used
3255 only in a comment talking about a compiler bug, so put inside
3256 the #if 0 of that comment.
3257 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3258 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3261 * search.c (boyer_moore): Rename locals to avoid shadowing.
3262 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3263 (PREV_CHAR_BOUNDARY): Likewise.
3265 * search.c (simple_search): Remove unused var.
3267 * dired.c (compile_pattern): Move decl from here ...
3268 * lisp.h: ... to here, so that it can be checked.
3269 (struct re_registers): New forward decl.
3271 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3273 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3275 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3276 Rename locals to avoid shadowing.
3277 (Fvertical_motion): Mark locals as initialized.
3279 * casefiddle.c (casify_object, casify_region): Now static.
3280 (casify_region): Mark local as initialized.
3282 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3284 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3285 New macros, so that the caller can use some names other than
3286 gcpro1, gcpro2, etc.
3287 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3289 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3290 argument, for consistency with GCPRO2_VAR, etc: it is now the
3291 prefix of the variable, not the variable itself. All uses
3293 * dired.c (directory_files_internal, file_name_completion):
3294 Rename locals to avoid shadowing.
3296 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3297 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3298 dired.c's scmp function, had undefined behavior.
3299 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3300 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3301 * buffer.h: ... to here, because these macros use current_buffer,
3302 and the new implementation with inline functions needs to have
3303 current_buffer in scope now, rather than later when the macros
3305 (downcase, upcase1): New static inline functions.
3306 (DOWNCASE, UPCASE1): Reimplement using these functions.
3307 This avoids undefined behavior in expressions like
3308 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3309 from race conditions in accessing the global variables
3310 case_temp1 and case_temp2.
3311 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3312 * lisp.h (case_temp1, case_temp2): Remove their decls.
3313 * character.h (ASCII_CHAR_P): Move from here ...
3314 * lisp.h: ... to here, so that the inline functions mentioned
3317 * dired.c (directory_files_internal_unwind): Now static.
3319 * fileio.c (file_name_as_directory, directory_file_name):
3320 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3322 (file_name_as_directory): Use const pointers when appropriate.
3323 (Fexpand_file_name): Likewise. In particular, newdir might
3324 point at constant storage, so make it a const pointer.
3325 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3326 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3328 (Fset_file_times, Finsert_file_contents, auto_save_error):
3329 Rename locals to avoid shadowing.
3331 * minibuf.c (choose_minibuf_frame_1): Now static.
3332 (Ftry_completion, Fall_completions): Rename or remove locals
3335 * marker.c (bytepos_to_charpos): Remove; unused.
3337 * lisp.h (verify_bytepos, count_markers): New decls,
3338 so that gcc does not warn that these functions aren't declared.
3340 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3341 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3342 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3343 (copy_text): Remove unused local var.
3345 * filelock.c (within_one_second): Now static.
3346 (lock_file_1): Rename local to avoid shadowing.
3348 * buffer.c (fix_overlays_before): Mark locals as initialized.
3349 (fix_start_end_in_overlays): Likewise. This function should be
3350 simplified by using pointers-to-pointers, but that's a different
3352 (switch_to_buffer_1): Now static.
3353 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3354 (report_overlay_modification): Rename locals to avoid shadowing.
3356 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3357 Fix pointer signedness issue.
3358 (sys_subshell): Mark local as volatile if checking for lint,
3359 to suppress a gcc -Wclobbered warning that does not seem to be right.
3360 (MAXPATHLEN): Define only if needed.
3362 * process.c (serial_open, serial_configure): Move decls from here ...
3363 * systty.h: ... to here, so that they can be checked.
3365 * fns.c (get_random, seed_random): Move extern decls from here ...
3366 * lisp.h: ... to here, so that they can be checked.
3368 * sysdep.c (reset_io): Now static.
3369 (wait_for_termination_signal): Remove; unused.
3371 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3372 (copy_keymap_item, append_key, push_text_char_description):
3374 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3375 (DENSE_TABLE_SIZE): Remove; unused.
3376 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3377 (describe_map_tree):
3378 Rename locals to avoid shadowing.
3380 * keyboard.c: Declare functions static if they are not used elsewhere.
3381 (echo_char, echo_dash, cmd_error, top_level_2):
3382 (poll_for_input, handle_async_input): Now static.
3383 (read_char, kbd_buffer_get_event, make_lispy_position):
3384 (make_lispy_event, make_lispy_movement, apply_modifiers):
3385 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3386 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3387 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3388 (read_key_sequence, read_char): Mark locals as initialized.
3389 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3391 * keyboard.h (make_ctrl_char): New decl.
3392 (mark_kboards): Move decl here ...
3393 * alloc.c (mark_kboards): ... from here.
3395 * lisp.h (force_auto_save_soon): New decl.
3397 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3398 (DEFINE_DUMMY_FUNCTION): New macro.
3399 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3401 (main): Add casts to avoid warnings
3402 if GCC considers string literals to be constants.
3404 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3406 * dbusbind.c: Pointer signedness fixes.
3407 (xd_signature, xd_append_arg, xd_initialize):
3408 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3409 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3410 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3411 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3413 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3414 if GCC considers string literals to be constants.
3415 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3417 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3419 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3420 (print_preprocess, print_object): New macro to fix last change.
3422 * print.c (print_preprocess): Don't forget font objects.
3424 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3426 * emacs.c (USAGE3): Doc fixes.
3428 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3430 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3433 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3435 * lisp.h (VWindow_system, Qfile_name_history):
3436 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3437 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3438 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3440 * w32select.c: Don't #include "keyboard.h".
3441 (run_protected): Add extern declaration for waiting_for_input.
3443 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3444 * w32console.c (detect_input_pending, read_input_pending)
3445 (encode_terminal_code):
3446 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3447 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3448 (w32_system_caret_y, Qfile_name_history):
3449 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3450 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3451 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3452 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3453 * w32proc.c (Qlocal, report_file_error):
3454 * w32term.c (Vwindow_system, updating_frame):
3455 * w32uniscribe.c (initialized, uniscribe_font_driver):
3456 Remove unneeded extern declarations.
3458 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3460 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3462 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3464 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3465 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3466 These macros can no longer be used for assignment.
3468 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3469 Assign struct members directly, instead of using BUF_BEGV etc.
3470 (record_buffer_markers, fetch_buffer_markers): New functions for
3471 recording and fetching special buffer markers.
3472 (set_buffer_internal_1, set_buffer_temp): Use them.
3474 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3476 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3478 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3479 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3481 * xdisp.c (hscroll_window_tree):
3482 (reconsider_clip_changes): Use PT instead of BUF_PT.
3484 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3486 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3487 $(EMACS_ROOT)/lib/intprops.h.
3489 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3491 Fix more problems found by GCC 4.5.2's static checks.
3493 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3494 to unsigned char * to avoid compiler diagnostic.
3495 (xg_free_frame_widgets): Make it clear that a local variable is
3496 needed only if USE_GTK_TOOLTIP.
3497 (gdk_window_get_screen): Make it clear that this macro is needed
3498 only if USE_GTK_TOOLTIP.
3499 (int_gtk_range_get_value): New function, which avoids a diagnostic
3500 from gcc -Wbad-function-cast.
3501 (xg_set_toolkit_scroll_bar_thumb): Use it.
3502 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3503 diagnostic from gcc -Wbad-function-cast.
3504 (get_utf8_string, xg_get_file_with_chooser):
3505 Rename locals to avoid shadowing.
3506 (create_dialog): Move locals to avoid shadowing.
3508 * xgselect.c (xg_select): Remove unused var.
3510 * image.c (four_corners_best): Mark locals as initialized.
3511 (gif_load): Initialize transparent_p to zero (Bug#8238).
3512 Mark another local as initialized.
3513 (my_png_error, my_error_exit): Mark with NO_RETURN.
3515 * image.c (clear_image_cache): Now static.
3516 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3517 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3518 (x_edge_detection): Remove unnecessary cast that
3519 gcc -Wbad-function-cast diagnoses.
3520 (gif_load): Fix pointer signedness.
3521 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3522 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3524 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3526 Improve quality of tests for time stamp overflow.
3527 For example, without this patch (encode-time 0 0 0 1 1
3528 1152921504606846976) returns the obviously-bogus value (-948597
3529 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3530 reports time overflow. See
3531 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3532 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3533 * editfns.c: Include limits.h and intprops.h.
3534 (TIME_T_MIN, TIME_T_MAX): New macros.
3535 (time_overflow): Move earlier, to before first use.
3536 (hi_time, lo_time): New functions, for an accurate test for
3538 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3539 (Fget_internal_run_time): Don't assume time_t fits in int.
3540 (make_time): Use list2 instead of Fcons twice.
3541 (Fdecode_time): More accurate test for out-of-range times.
3542 (check_tm_member): New function.
3543 (Fencode_time): Use it, to test for out-of-range times.
3544 (lisp_time_argument): Don't rely on undefined left-shift and
3545 right-shift behavior when checking for time stamp overflow.
3547 * editfns.c (time_overflow): New function, refactoring common code.
3548 (Fformat_time_string, Fdecode_time, Fencode_time):
3549 (Fcurrent_time_string): Use it.
3551 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3552 * dired.c (make_time): Move to ...
3553 * editfns.c (make_time): ... here.
3554 * systime.h: Note the move.
3556 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3558 * fringe.c (update_window_fringes): Remove unused variables.
3560 * unexmacosx.c (copy_data_segment): Also copy __got section.
3563 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3565 * termcap.c [MSDOS]: Include "msdos.h".
3566 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3567 Constify `char *' arguments and their references according to
3568 prototypes in tparam.h.
3570 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3572 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3573 Adapt all references accordingly.
3575 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3577 2011-03-11 Tom Tromey <tromey@redhat.com>
3579 * buffer.c (syms_of_buffer): Remove obsolete comment.
3581 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3583 * termhooks.h (encode_terminal_code): Declare prototype.
3585 * msdos.c (encode_terminal_code): Don't declare prototype.
3587 * term.c (encode_terminal_code): Now external again, used by
3588 w32console.c and msdos.c.
3590 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3591 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3593 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3595 Fix some minor problems found by GCC 4.5.2's static checks.
3597 * fringe.c (update_window_fringes): Mark locals as initialized
3599 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3601 * alloc.c (mark_fringe_data): Move decl from here ...
3602 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3603 to check its interface.
3604 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3606 * fontset.c (free_realized_fontset): Now static.
3607 (Fset_fontset_font): Rename local to avoid shadowing.
3608 (fontset_font): Mark local as initialized.
3609 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3611 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3613 * xselect.c (x_disown_buffer_selections): Remove; not used.
3614 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3615 (x_own_selection, Fx_disown_selection_internal): Rename locals
3617 (x_handle_dnd_message): Remove local to avoid shadowing.
3619 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3620 so that the caller can use some name other than gcpro1.
3621 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3622 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3623 (Fx_backspace_delete_keys_p):
3624 Use them to avoid shadowing, and rename vars to avoid shadowing.
3625 (x_decode_color, x_set_name, x_window): Now static.
3626 (Fx_create_frame): Add braces to silence GCC warning.
3627 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3628 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3629 Remove unused locals.
3630 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3631 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3632 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3635 * xterm.h (x_mouse_leave): New decl.
3637 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3638 Remove unused functions.
3639 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3640 (x_calc_absolute_position): Now static.
3641 (XTread_socket): Don't define label "out" unless it's used.
3642 Don't declare local "event" unless it's used.
3643 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3644 unless they are used.
3645 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3646 (x_fatal_error_signal): Remove; not used.
3647 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3648 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3649 (x_error_catcher, x_connection_closed, x_error_handler):
3650 (x_error_quitter, xembed_send_message, x_iconify_frame):
3651 (my_log_handler): Rename locals to avoid shadowing.
3652 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3653 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3655 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3656 Rename or move locals to avoid shadowing.
3657 (tty_defined_color, merge_face_heights): Now static.
3658 (free_realized_faces_for_fontset): Remove; not used.
3659 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3660 does not deduce is never used uninitialized.
3661 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3662 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3664 * terminal.c (store_terminal_param): Now static.
3666 * xmenu.c (menu_highlight_callback): Now static.
3667 (set_frame_menubar): Remove unused local.
3668 (xmenu_show): Rename parameter to avoid shadowing.
3669 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3670 since they might point to immutable storage.
3671 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3672 since it's unused otherwise.
3674 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3675 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3676 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3677 avoids a gcc -Wuninitialized diagnostic.
3678 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3679 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3680 does not deduce are never used uninitialized.
3682 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3684 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3685 * window.c (window_loop, size_window):
3686 (run_window_configuration_change_hook, enlarge_window): Likewise.
3688 * window.c (display_buffer): Now static.
3689 (size_window): Mark variables that gcc -Wuninitialized
3690 does not deduce are never used uninitialized.
3691 * window.h (check_all_windows): New decl, to forestall
3692 gcc -Wmissing-prototypes diagnostic.
3693 * dispextern.h (bidi_dump_cached_states): Likewise.
3695 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3697 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3699 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3700 and to avoid gcc -Wuninitialized warning.
3701 (load_charset_map): Mark variables that gcc -Wuninitialized
3702 does not deduce are never used uninitialized.
3703 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3705 * coding.c (coding_set_source, coding_set_destination):
3706 Use "else { /* comment */ }" rather than "else /* comment */;"
3707 for clarity, and to avoid gcc -Wempty-body warning.
3708 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3709 a block, when the outer 'i' will do.
3710 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3711 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3712 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3713 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3714 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3715 Rename locals to avoid shadowing.
3716 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3717 * coding.c (emacs_mule_char, encode_invocation_designation):
3718 Now static, since they're not used elsewhere.
3719 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3720 (decode_coding_object, encode_coding_object, detect_coding_system):
3721 (decode_coding_emacs_mule): Mark variables that gcc
3722 -Wuninitialized does not deduce are never used uninitialized.
3723 (detect_coding_iso_2022): Initialize a local variable that might
3724 be used uninitialized. Leave a FIXME because it's not clear that
3725 this initialization is needed. (Bug#8211)
3726 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3727 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3728 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3729 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3730 Remove unused macros.
3732 * category.c (hash_get_category_set): Remove unused local var.
3733 (copy_category_table): Now static, since it's not used elsewhere.
3734 * character.c (string_count_byte8): Likewise.
3736 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3737 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3739 * chartab.c (copy_sub_char_table): Now static, since it's not used
3741 (sub_char_table_ref_and_range, char_table_ref_and_range):
3742 Rename locals to avoid shadowing.
3743 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3745 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3746 (BIDI_BOB): Remove unused macro.
3748 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3749 deduce are never used uninitialized.
3750 * term.c (encode_terminal_code): Likewise.
3752 * term.c (encode_terminal_code): Now static. Remove unused local.
3754 * tparam.h: New file.
3755 * term.c, tparam.h: Include it.
3756 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3757 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3758 Move these decls to tparam.h, and make them agree with what
3759 is actually in tparam.c. The previous trick of using incompatible
3760 decls in different modules does not conform to the C standard.
3761 All callers of tparam changed to use tparam's actual API.
3762 * tparam.c (tparam1, tparam, tgoto):
3763 Use const pointers where appropriate.
3765 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3766 * cm.h (struct cm): Likewise.
3767 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3768 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3769 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3770 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3771 (turn_on_face, init_tty): Likewise.
3772 * termchar.h (struct tty_display_info): Likewise.
3774 * term.c (term_mouse_position): Rename local to avoid shadowing.
3776 * alloc.c (mark_ttys): Move decl from here ...
3777 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3779 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3781 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3783 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3785 * search.c (compile_pattern_1): Remove argument regp, unused since
3786 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3787 (compile_pattern): Don't pass it.
3789 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3791 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3792 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3794 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3796 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3798 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3799 gdk_window_get_screen, gdk_window_get_geometry,
3800 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3801 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3802 (xg_get_pixbuf_from_pixmap): New function.
3803 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3804 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3805 Call xg_get_pixbuf_from_pixmap instead of
3806 gdk_pixbuf_get_from_drawable.
3807 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3808 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3809 (xg_check_special_colors): Use GtkStyleContext and its functions
3811 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3812 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3813 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3814 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3815 Call gtk_widget_get_preferred_size.
3816 (xg_frame_resized): gdk_window_get_geometry only takes 5
3818 (xg_win_to_widget, xg_event_is_for_menubar):
3819 Call gdk_x11_window_lookup_for_display.
3820 (xg_set_widget_bg): New function.
3821 (delete_cb): New function.
3822 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3823 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3824 (xg_set_background_color): Call xg_set_widget_bg.
3825 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3826 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3827 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3828 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3830 (update_frame_tool_bar): Call gtk_widget_hide.
3831 (xg_initialize): Use GDK_KEY_g.
3833 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3835 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3837 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3838 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3839 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3841 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3843 * w32xfns.c (select_palette): Check success of RealizePalette against
3844 GDI_ERROR, not zero.
3846 See ChangeLog.11 for earlier changes.
3852 Copyright (C) 2011 Free Software Foundation, Inc.
3854 This file is part of GNU Emacs.
3856 GNU Emacs is free software: you can redistribute it and/or modify
3857 it under the terms of the GNU General Public License as published by
3858 the Free Software Foundation, either version 3 of the License, or
3859 (at your option) any later version.
3861 GNU Emacs is distributed in the hope that it will be useful,
3862 but WITHOUT ANY WARRANTY; without even the implied warranty of
3863 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3864 GNU General Public License for more details.
3866 You should have received a copy of the GNU General Public License
3867 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.