1 2012-07-17 Eli Zaretskii <eliz@gnu.org>
3 Remove FILE_SYSTEM_CASE.
4 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
6 * fileio.c (FILE_SYSTEM_CASE): Don't define.
7 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
8 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
9 call-process-region passes it through expand-file-name.
11 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
13 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
15 Fix crash when creating indirect buffer (Bug#11917)
16 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
17 Don't handle unbound variables specially if non-zero.
18 (Fbuffer_local_variables): Pass zero.
19 (clone_per_buffer_values): Pass non-zero.
21 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
23 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
24 to make the loop interruptible.
26 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
28 * gnutls.c (emacs_gnutls_handshake): Only retry if
31 2012-07-17 Eli Zaretskii <eliz@gnu.org>
32 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
34 Cleanup and convert miscellaneous checks to eassert.
35 * alloc.c (mark_interval): Fix comment, partially rephrase
36 old comment from intervals.h (see below).
37 * intervals.c (find_interval, adjust_intervals_for_insertion)
38 (delete_interval, adjust_intervals_for_deletion)
39 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
41 (adjust_intervals_for_insertion, make_new_interval):
42 Remove obsolete and unused code.
43 * intervals.h (struct interval): Remove obsolete comment.
44 * textprotp.c (erase_properties): Remove unused code.
45 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
46 (Fremove_list_of_text_properties): Convert to eassert.
48 2012-07-17 Chong Yidong <cyd@gnu.org>
50 * editfns.c (Finsert_char): Doc fix.
52 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
54 Fix previous change to make Fmemory_free always accurate.
55 * alloc.c (make_interval): Update total_free_intervals.
56 (make_float): Likewise for total_free_floats.
57 (free_cons, Fcons): Likewise for total_free_conses.
58 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
59 Likewise for total_free_vector_bytes.
60 (Fmake_symbol): Likewise for total_free_symbols.
63 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
65 Simple free memory accounting feature.
66 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
67 (sweep_vectors): Accumulate size of free vectors.
68 (Fgarbage_collect): Setup bytes_free.
69 (Fmemory_free): New function.
70 (syms_of_alloc): Register it.
72 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
74 Cleanup overlays checking.
75 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
76 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
78 (sort_overlays): Change to use OVERLAYP.
80 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
82 * editfns.c (Finsert_char): Make it interactive, and make the
83 second arg optional. Copy interactive spec and docstring from
86 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
88 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
89 Unlike the other wrapped functions, fabs has an unspecified
92 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
94 * nsterm.m (keyDown): Interpret flags without left/right bits
95 as the left key (Bug#11670).
97 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
99 Remove empty and useless init functions.
100 * lisp.h (init_character_once, init_fns, init_image)
101 (init_filelock, init_sound): Remove prototype.
102 * character.c (init_character_once): Remove.
103 * filelock.c (init_filelock): Likewise.
104 * fns.c (init_fns): Likewise.
105 * image.c (init_image): Likewise.
106 * sound.c (init_sound): Likewise.
107 * emacs.c (main): Adjust accordingly.
109 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
111 * gtkutil.h: Tiny cleanups.
112 (use_old_gtk_file_dialog): Remove useless declaration.
113 (xg_uses_old_file_dialog): Add suggested const attribute.
115 2012-07-15 Eli Zaretskii <eliz@gnu.org>
117 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
118 (bidi_paragraph_init): Use it to limit search forward for a strong
119 directional character in abnormally large paragraphs full of
120 neutral or weak characters. (Bug#11943)
122 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
124 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
125 the toolbar (Bug#9451).
126 (xg_make_tool_item): Give the widget event box a transparent
129 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
131 Cleanup basic allocation variables and functions.
132 * alloc.c (ignore_warnings, init_intervals, init_float)
133 (init_cons, init_symbol, init_marker): Remove.
134 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
135 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
136 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
137 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
138 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
139 (staticidx, init_alloc_once, init_strings, free_ablock):
140 Remove redundant initialization.
141 * fns.c (init_weak_hash_tables): Remove.
142 * lisp.h (init_weak_hash_tables): Remove prototype.
144 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
146 Use zero_vector where appropriate.
147 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
149 * lisp.h (zero_vector): New declaration.
150 * font.c (null_vector): Remove.
151 (syms_of_font): Remove initialization and staticpro.
152 (font_list_entities, font_find_for_lface): Change to use zero_vector.
153 * keymap.c (Faccessible_keymaps): Likewise.
155 2012-07-15 Leo Liu <sdl.web@gmail.com>
157 * fringe.c: Fix typo in comments.
159 2012-07-14 Leo Liu <sdl.web@gmail.com>
161 * fringe.c: Add a new bitmap exclamation-mark.
163 2012-07-14 Eli Zaretskii <eliz@gnu.org>
165 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
167 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
168 (HAVE_MENUS): Don't define, defined by editing config.in with
170 (GMALLOC_INHIBIT_VALLOC): Don't define.
171 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
173 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
175 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
177 2012-07-14 Glenn Morris <rgm@gnu.org>
179 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
180 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
181 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
183 2012-07-13 Glenn Morris <rgm@gnu.org>
185 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
187 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
188 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
190 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
192 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
193 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
194 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
195 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
197 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
198 as boolean expression.
199 (x_set_window_size): Remove unused variable toolbar.
200 (ns_get_color_default, ns_mod_to_lisp): Remove.
201 (ns_mouse_position): Remove unused variables xchar and ychar.
202 (ns_compute_glyph_string_overhangs): Remove unused variable face.
203 (ns_set_vertical_scroll_bar): Remove unused variable count.
204 (ns_delete_terminal): Remove unused variable i.
205 (ns_term_init): Remove unused variables r, g and b.
206 (mouseDown): Remove unused variable window.
207 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
208 (initFrameFromEmacs): Remove unused variable vbextra.
209 (mouseEntered): Remove unused variables p and dpyinfo.
210 (mouseExited): Remove unused variables p and r.
211 (ns_define_frame_cursor, ns_clear_frame_area)
212 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
213 (menuDown): Assign [sender tag] to variable and cast the variable.
215 * nsterm.h (menuDown): Add id as type to argument sender.
216 (ns_display_info_for_name): Add Lisp_Object argument.
217 (ns_term_init): Add Lisp_Object argument.
218 (ns_map_event_to_object): Add void argument.
219 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
220 prototype with arguments and only declare if __OBJC__.
221 (nxatoms_of_nsselect): Add void argument.
222 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
223 (ns_alloc_autorelease_pool): Add void argument.
224 (ns_release_autorelease_pool): Add void* argument.
225 (ns_get_defaults_value): Add const char* argument.
227 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
228 (initFromContents): Use SSDATA where appropriate.
229 (ns_update_menubar): Add braces to ambigous if-else.
230 (initWithTitle): Put () around assignment in if statement.
231 (ns_menu_show): Remove unused variables window and keymap.
232 (update_frame_tool_bar): Remove unused variable selected_p.
233 (initWithContentRect): Remove unused variable this_cmd_name.
235 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
237 (setXBMColor): Remove unused variable len.
238 (setPixmapData): Put () around assignment in loop statement.
240 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
241 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
243 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
244 around assignment in loop statement.
245 (nsfont_open): Remove unused variable i.
246 (nsfont_open): Remove unused variable len.
247 (nsfont_draw): Remove unused variable cs.
249 * nsfns.m (x_set_icon_name, ns_set_name_internal)
250 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
251 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
252 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
253 (Fns_font_name, Fns_perform_service)
254 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
255 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
256 (ns_set_name): Remove unused variable view.
257 (x_set_menu_bar_lines): Remove unused variable olines.
258 (x_set_tool_bar_lines): Remove unused variable root_window.
259 (Fns_list_colors): Put () around assignment in while statement.
260 (Fns_perform_service): Remove unused variable len.
261 (Fns_display_usable_bounds): Remove unused variable top.
262 (syms_of_nsfns): Remove unused variable i.
264 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
267 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
269 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
270 and free it with DestroyExceptionInfo (Bug#11558).
272 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
274 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
275 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
276 Set here, not in nt/config.nt.
278 2012-07-13 Eli Zaretskii <eliz@gnu.org>
280 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
281 cursor overflow into the last glyph on display line when the right
282 fringe is off. (Bug#11832)
284 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
286 * xdisp.c (produce_special_glyphs): Now static.
287 * dispextern.h (produce_special_glyphs): Remove decl.
289 2012-07-13 Glenn Morris <rgm@gnu.org>
291 * s/bsd-common, s/cygwin.h: Remove empty files.
292 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
294 * s/usg5-4-common.h (USG, USG5):
295 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
296 * s/sol2-6.h (SOLARIS2):
297 * s/irix6-5.h (IRIX6_5):
298 * s/hpux10-20.h (USG, USG5, HPUX):
299 * s/gnu-linux.h (USG, GNU_LINUX):
300 * s/freebsd.h (BSD_SYSTEM):
301 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
302 * s/cygwin.h (CYGWIN):
303 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
304 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
306 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
308 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
310 2012-07-13 Glenn Morris <rgm@gnu.org>
312 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
314 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
316 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
317 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
319 2012-07-12 Glenn Morris <rgm@gnu.org>
321 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
323 * process.c (init_process_emacs): Rename from init_process.
324 The old name is also the name of a Mach system call.
325 * lisp.h, emacs.c: Update for this name change.
326 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
329 2012-07-12 Eli Zaretskii <eliz@gnu.org>
331 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
332 memmove call that removes glyphs covered by the left truncation
333 glyph. Improve commentary.
334 (display_line): Fix display of continuation glyphs on GUI frames
335 when the right fringe is turned off and variable-size fonts are
336 used in the window. Move the code that appends a stretch glyph to
337 produce_special_glyphs, so that it could be used for truncation
338 and continuation glyphs alike.
339 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
340 glyph of a suitably computed width, to align the special glyphs at
341 the window margin. Code moved from display_line. (Bug#11832)
343 2012-07-12 Glenn Morris <rgm@gnu.org>
345 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
347 * s/gnu-linux.h, s/hpux10-20.h:
348 Do not unconditionally define HAVE_XRMSETDATABASE.
350 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
352 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
354 Fix typos that broke OS X build.
355 Reported by Randal L. Schwartz in
356 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
357 * nsterm.m (ns_timeout): Add missing local decl.
358 (ns_get_color): snprintf -> sprintf, to fix typo.
360 2012-07-12 Glenn Morris <rgm@gnu.org>
362 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
363 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
364 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
365 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
367 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
368 Move PTY_OPEN to configure.
370 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
371 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
372 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
374 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
376 Use empty_unibyte_string where applicable.
377 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
378 * lread.c (read1): Likewise.
379 * xsettings.c (syms_of_xsettings): Likewise.
381 2012-07-12 Glenn Morris <rgm@gnu.org>
383 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
384 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
385 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
386 * s/hpux10-20.h (RUN_TIME_REMAP):
387 * s/bsd-common.h (TABDLY): Move to configure.
389 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
391 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
393 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
394 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
396 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
398 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
399 * s/template.h: Move NARROWPROTO to configure.
401 2012-07-11 Glenn Morris <rgm@gnu.org>
403 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
404 unused since 2011-01-17 change to systty.h.
406 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
407 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
408 Move HAVE_PTYS and HAVE_SOCKETS to configure.
410 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
412 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
414 2012-07-11 Glenn Morris <rgm@gnu.org>
416 * s/darwin.h, s/gnu-linux.h, s/template.h:
417 Move INTERRUPT_INPUT to configure.
419 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
421 Minor adjustments to interning code.
422 * lisp.h (intern, intern_c_string): Redefine as static inline
423 wrappers for intern_1 and intern_c_string_1, respectively.
424 (intern_1, intern_c_string_1): Rename prototypes.
425 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
427 * font.c (font_intern_prop): Likewise. Adjust comment.
428 * w32font.c (intern_font_name): Likewise.
430 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
432 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
434 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
435 of Fcar/Fcdr if possible.
436 * font.c (check_otf_features): Likewise.
437 * fontset.c (Fnew_fontset): Likewise.
438 * gnutls.c (Fgnutls_boot): Likewise.
439 * minibuf.c (read_minibuf): Likewise.
440 * msdos.c (IT_set_frame_parameters): Likewise.
441 * xmenu.c (Fx_popup_dialog): Likewise.
442 * w32menu.c (Fx_popup_dialog): Likewise.
444 2012-07-11 Glenn Morris <rgm@gnu.org>
446 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
447 since nothing has defined it on these platforms.
449 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
450 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
452 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
453 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
454 Move CLASH_DETECTION to configure.
456 * s/gnu.h: Remove file, which is now empty.
458 * s/gnu.h, s/gnu-linux.h:
459 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
461 2012-07-11 John Wiegley <johnw@newartisans.com>
463 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
464 function attribute, so we only use it if it exists in the
467 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
469 Avoid call to strlen in fast_c_string_match_ignore_case.
470 * search.c (fast_c_string_match_ignore_case): Change to use
471 length argument. Adjust users accordingly.
472 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
474 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
477 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
478 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
481 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
484 * s/hpux10-20.h (HAVE_PERROR): Remove.
485 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
486 Remove dummy definition, as this problem was obsolete long ago.
489 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
491 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
493 Avoid calls to strlen in font processing functions.
494 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
495 (font_open_by_name): Change to use length argument. Adjust
497 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
499 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
500 Change to return ptrdiff_t.
501 (xfont_list_pattern, xfont_match): Use length returned by
502 xfont_decode_coding_xlfd.
503 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
505 2012-07-11 Glenn Morris <rgm@gnu.org>
507 * s/darwin.h, s/freebsd.h, s/netbsd.h:
508 Move DONT_REOPEN_PTY to configure.
510 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
511 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
513 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
515 Remove "#define unix" that is no longer needed (Bug#11905).
516 * s/aix4-2.h (unix): Remove; no longer needed.
518 EMACS_TIME simplification (Bug#11875).
519 This replaces macros (which typically do not work in GDB)
520 with functions, typedefs and enums, making the code easier to debug.
521 The functional style also makes code easier to read and maintain.
522 * systime.h: Include <sys/time.h> on all hosts, not just if
523 WINDOWSNT, since 'struct timeval' is needed in general.
524 (EMACS_TIME): Now a typedef, not a macro.
525 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
527 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
528 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
529 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
530 (EMACS_TIME_LE): Now functions, not macros.
531 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
532 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
533 which are not functions. All uses rewritten to use:
534 (make_emacs_time): New function.
535 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
536 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
537 not functions. All uses rewritten to use the following, respectively:
538 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
539 (add_emacs_time, sub_emacs_time): New functions.
540 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
541 * fileio.c (Fcopy_file):
542 * xterm.c (XTflash): Get the current time closer to when it's used.
543 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
545 * bytecode.c (targets): Suppress -Woverride-init warnings.
547 Simplify by avoiding confusing use of strncpy etc.
548 * doc.c (Fsnarf_documentation):
549 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
550 * frame.c (Fmake_terminal_frame):
551 * gtkutil.c (get_utf8_string):
553 * nsmenu.m (ns_update_menubar):
554 * regex.c (regerror):
555 Prefer memcpy to strncpy and strncat when either will do.
556 * fileio.c (Fsubstitute_in_file_name):
557 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
558 (menu_separator_name_p):
559 * nsmenu.m (ns_update_menubar):
560 Prefer memcmp to strncmp when either will do.
561 * nsterm.m: Include <ftoastr.h>.
563 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
564 Prefer snprintf to strncpy.
565 * nsterm.m (ns_term_init):
566 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
567 * nsterm.m (ns_term_init):
568 Avoid the need for strncpy, by using build_string or
569 make_unibyte_string directly. Use dtoastr, not snprintf.
570 * process.c (Fmake_network_process): Diagnose service names that
571 are too long, rather than silently truncating them or creating
572 non-null-terminated names.
573 (Fnetwork_interface_info): Likewise, for interface names.
574 * sysdep.c (system_process_attributes) [GNU_LINUX]:
575 Prefer sprintf to strncat.
576 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
577 Prefer vsnprintf to vsprintf + strncpy.
579 2012-07-10 Glenn Morris <rgm@gnu.org>
581 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
582 Clarify fallback case.
584 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
586 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
587 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
588 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
589 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
590 where argument type is known to be a Lisp_Cons.
592 2012-07-10 Tom Tromey <tromey@redhat.com>
594 * bytecode.c (BYTE_CODE_THREADED): New macro.
595 (BYTE_CODES): New macro. Replaces all old byte-code defines.
596 (enum byte_code_op): New type.
597 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
598 (exec_byte_code): Use them. Use token threading when applicable.
600 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
602 Optimize pure C strings initialization.
603 * lisp.h (make_pure_string): Fix prototype.
604 (build_pure_c_string): New function, defined as static inline. This
605 provides a better opportunity to optimize away calls to strlen when
606 the function is called with compile-time constant argument.
607 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
608 argument, adjust users accordingly. Use build_pure_c_string where
610 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
611 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
612 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
614 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
616 Avoid calls to strlen in miscellaneous functions.
617 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
618 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
619 * lread.c (openp): Likewise.
621 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
623 Avoid calls to strlen in path processing functions.
624 * fileio.c (file_name_as_directory): Add comment. Change to add
625 srclen argument and return the length of result. Adjust users
627 (directory_file_name): Fix comment. Change to add srclen argument,
628 swap 1st and 2nd arguments to obey the common convention. Adjust
630 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
632 2012-07-10 Glenn Morris <rgm@gnu.org>
634 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
635 Move PENDING_OUTPUT_COUNT definition to configure.
637 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
638 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
639 * s/gnu.h (DATA_START): Move definitions to configure.
641 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
642 We include usg5-4-common.h, which defines them both.
644 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
645 O_RDONLY already includes it).
647 Stop ns builds setting the EMACSLOADPATH environment variable.
648 * nsterm.m (ns_load_path): Rename from ns_init_paths.
649 Now it does not set EMACSLOADPATH, just returns the load-path string.
650 * nsterm.h: Update accordingly.
651 * lread.c [HAVE_NS]: Include nsterm.h.
652 (init_lread) [HAVE_NS]: Use ns_load_path.
653 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
655 2012-07-09 Glenn Morris <rgm@gnu.org>
657 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
658 since the included bsd-common.h does so.
660 Stop ns builds setting the EMACSPATH environment variable.
661 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
662 (ns_init_paths): Do not set EMACSPATH.
663 * nsterm.h (ns_exec_path): Add it.
664 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
667 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
669 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
671 * process.c (wait_reading_process_output): 'waitchannels' was unset
672 when read_kbd || !NILP (wait_for_cell); fix this.
674 Add GCC-style 'const' attribute to functions that can use it.
675 * character.h (char_resolve_modifier_mask):
676 * keyboard.h (make_ctrl_char):
677 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
678 (init_character_once, next_almost_prime, init_fns, init_image)
679 (flush_pending_output, init_sound):
680 * mem-limits.h (start_of_data):
681 * menu.h (finish_menu_items):
683 * emacs.c (DEFINE_DUMMY_FUNCTION):
684 Declare the dummy function with ATTRIBUTE_CONST.
685 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
686 Add decls with ATTRIBUTE_CONST.
688 Minor improvements to make_formatted_string.
689 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
690 where int is good enough, as vsprintf returns an int.
691 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
693 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
695 Use make_formatted_string to avoid double length calculation.
696 * lisp.h (make_formatted_string): New prototype.
697 * alloc.c (make_formatted_string): New function.
698 * buffer.c (Fgenerate_new_buffer_name): Use it.
699 * dbus.c (syms_of_dbusbind): Likewise.
700 * editfns.c (Fcurrent_time_zone): Likewise.
701 * filelock.c (get_boot_time): Likewise.
702 * frame.c (make_terminal_frame, set_term_frame_name)
703 (x_report_frame_params): Likewise.
704 * image.c (gs_load): Likewise.
705 * minibuf.c (get_minibuffer): Likewise.
706 * msdos.c (dos_set_window_size): Likewise.
707 * process.c (make_process): Likewise.
708 * xdisp.c (ensure_echo_area_buffers): Likewise.
709 * xsettings.c (apply_xft_settings): Likewise.
711 2012-07-09 Glenn Morris <rgm@gnu.org>
713 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
714 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
715 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
716 * nsterm.h (ns_etc_directory): Add it.
717 * callproc.c [HAVE_NS]: Include nsterm.h.
718 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
720 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
722 Move marker debugging code under MARKER_DEBUG.
723 * marker.c (MARKER_DEBUG): Move marker debugging code under
724 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
725 for bootstrap with --enable-checking (~3x slowdown reported
726 by Juanma Barranquero <lekktu@gmail.com>).
727 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
729 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
731 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
732 See <http://bugs.gnu.org/11825#29>.
734 2012-07-08 Eli Zaretskii <eliz@gnu.org>
736 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
737 has no font, use the frame's font. (Bug#11813)
738 (display_line): Add commentary about displaying truncation glyphs
740 (produce_special_glyphs): Move here from term.c.
742 * term.c (produce_special_glyphs): Move to xdisp.c.
744 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
747 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
749 * xdisp.c (display_line): Avoid warning about implicit declaration
752 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
754 * lisp.h: Remove empty conditional.
756 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
758 * lread.c (load_path_check): Now static.
760 Fix some minor --with-ns problems found by static checking.
761 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
762 (x_set_font) [!HAVE_X_WINDOWS]:
763 * image.c (xpm_load_image) [HAVE_NS]:
764 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
765 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
767 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
768 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
769 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
770 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
771 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
772 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
773 Fix pointer signedness problem.
774 * xfaces.c (FRAME_X_FONT_TABLE):
775 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
777 2012-07-07 Glenn Morris <rgm@gnu.org>
779 * lread.c (load_path_check): New function, split from init_lread.
780 (init_lread): Reorganize. Motivation:
781 If EMACSLOADPATH is set, check/warn about that rather than the
782 defaults, which we are not going to use. Hence we can remove
783 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
784 Don't warn if site-lisp directories are missing.
785 If not installed, start from a blank load-path, since
786 PATH_LOADSEARCH refers to the eventual installation directories.
788 2012-07-07 Eli Zaretskii <eliz@gnu.org>
790 Support truncation and continuation glyphs on GUI frames, when
791 fringes are disabled. (Bug#11832)
792 * xdisp.c (init_iterator): Get dimensions of truncation and
793 continuation glyphs even if on GUI frames. Adjust
794 it->last_visible_x on GUI frames when the left or right fringes,
796 (start_display, move_it_in_display_line_to): Handle the case of a
797 GUI frame without a fringe to display continuation or truncation
799 (insert_left_trunc_glyphs): Support GUI frames: make sure
800 truncation glyphs overwrite enough glyphs from the current line to
801 have sufficient space in pixels.
802 (display_line): Support truncation and continuation glyphs on GUI
803 frames. If some spare pixels are left on the line after inserting
804 the truncation glyphs, fill that space with a stretch glyph of a
805 suitably computed width.
807 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
808 produce_glyphs, to support GUI sessions.
810 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
812 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
814 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
816 Do not require float-time's arg to fit in time_t (Bug#11825).
817 This works better on hosts where time_t is unsigned, and where
818 float-time is applied to the (negative) difference between two times.
819 * editfns.c (decode_time_components): Last arg is now double *,
820 not int *, and means to store all the result as a double, without
821 worrying about whether the seconds part fits in time_t.
823 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
825 (Ffloat_time): Do not fail merely because the specified time falls
826 outside of time_t range.
828 2012-07-07 Glenn Morris <rgm@gnu.org>
830 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
831 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
832 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
834 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
836 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
839 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
841 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
843 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
844 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
845 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
846 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
847 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
848 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
850 * xfont.c (compare_font_names): Redo to omit the need for casts.
852 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
854 * xfns.c (Fx_change_window_property): Doc fix.
855 * w32fns.c (Fx_change_window_property): Doc fix.
857 * w32fns.c (Fx_window_property): Accept the same arguments as the
858 X Windows version. Doc fix.
859 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
861 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
862 Eli Zaretskii <eliz@gnu.org>
864 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
865 Windows-specific code from nt/config.nt moved here.
866 Obsolete settings removed.
868 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
870 * process.c: Avoid unnecessary calls to gettime.
871 (wait_reading_process_output): Don't get the time of day
872 when gobbling data immediately and not waiting, as there's no need
873 for it in that case. This removes a FIXME.
875 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
877 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
878 is defined (Bug#11768).
880 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
882 Fix marker debugging code.
883 * marker.c (byte_char_debug_check): Do not perform the check
884 if buffer is not multibyte.
885 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
886 Call byte_char_debug_check with correct arguments.
888 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
890 Compile marker debugging code only if ENABLE_CHECKING is defined.
891 * marker.c (byte_char_debug_check, count_markers):
892 Use only if ENABLE_CHECKING is defined.
893 (byte_debug_flag): Remove.
894 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
895 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
897 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
899 Avoid code repetition in marker-related functions.
900 * marker.c (attach_marker): New function.
901 (Fset_marker, set_marker_restricted, set_marker_both)
902 (set_marker_restricted_both): Use it.
903 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
904 Consistently rename charno to charpos.
905 (marker_position): Add eassert.
906 (marker_byte_position): Convert to eassert.
908 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
910 Simplify list operations in unchain_overlay and unchain_marker.
911 * buffer.c (unchain_overlay): Simplify. Add comment.
912 * marker.c (unchain_marker): Simplify. Fix comments.
914 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
916 Introduce fast path for the widely used marker operation.
917 * alloc.c (build_marker): New function.
918 * lisp.h (build_marker): New prototype.
919 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
920 * composite.c (autocmp_chars): Likewise.
921 * editfns.c (buildmark): Remove.
922 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
923 (save_restriction_save): Use build_marker.
924 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
925 * window.c (save_window_save): Likewise.
927 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
929 Do not use Fdelete_overlay in delete_all_overlays
930 to avoid redundant calls to unchain_overlay.
931 * buffer.c (drop_overlay): New function.
932 (delete_all_overlays, Fdelete_overlay): Use it.
933 * minibuf.c (get_minibuffer): Fix comment.
935 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
937 Port to OpenBSD 5.1 amd64.
938 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
939 This is needed for OpenBSD, and should be harmless on all BSD systems.
940 Also, include <sys/sysctl.h>, as it should be available on all
941 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
942 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
943 use p_pid member, not kp_proc.pid.
945 2012-07-06 Glenn Morris <rgm@gnu.org>
947 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
949 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
951 More xmalloc and related cleanup.
952 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
953 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
954 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
955 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
956 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
957 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
958 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
959 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
960 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
962 Omit needless casts involving void * pointers and allocation.
963 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
964 as the former is more robust if P's type is changed.
965 Prefer xzalloc to xmalloc + memset 0.
966 Simplify malloc-or-realloc to realloc.
967 Don't worry about xmalloc returning a null pointer.
968 Prefer xstrdup to xmalloc + strcpy.
969 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
971 * keyboard.c (apply_modifiers_uncached): Prefer local array to
972 alloca of a constant.
974 2012-07-05 Eli Zaretskii <eliz@gnu.org>
976 * xdisp.c (display_line): Fix horizontal pixel coordinates when
977 hscroll is larger than the line width. Fixes long and futile
978 looping inside extend_face_to_end_of_line (on a TTY) producing
979 glyphs that are not needed and thrown away.
981 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
983 * marker.c (set_marker_restricted_both): Simplify by using
986 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
988 * editfns.c (region_limit): Simplify by using clip_to_bounds.
990 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
992 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
993 not defined (Bug#11768).
994 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
995 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
996 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
997 followed by gtk_box_set_homogeneous (Bug#11768).
998 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
999 (update_theme_scrollbar_width, xg_create_scroll_bar):
1000 Use gtk_scrollbar_new (Bug#11768).
1001 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1002 (is_box_type): New function (Bug#11768).
1003 (xg_tool_item_stale_p): Call is_box_type.
1004 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1005 with default display (Bug#11768).
1007 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1009 * xdisp.c (window_hscroll_limited): New function.
1010 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1011 coordinates when window's hscroll is set to insanely large
1014 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1016 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1017 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1019 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1022 * lisp.h (xzalloc): New prototype. Omit needless casts.
1023 * alloc.c (xzalloc): New function. Omit needless casts.
1024 * charset.c: Omit needless casts. Convert all calls to
1025 xmalloc with following memset to xzalloc.
1026 * dispnew.c: Likewise.
1027 * fringe.c: Likewise.
1028 * image.c: Likewise.
1029 * sound.c: Likewise.
1031 * w32fns.c: Likewise.
1032 * w32font.c: Likewise.
1033 * w32term.c: Likewise.
1034 * xfaces.c: Likewise.
1036 * xterm.c: Likewise.
1037 * atimer.c: Omit needless casts.
1038 * buffer.c: Likewise.
1039 * callproc.c: Likewise.
1041 * coding.c: Likewise.
1042 * composite.c: Likewise.
1044 * doprnt.c: Likewise.
1045 * editfns.c: Likewise.
1046 * emacs.c: Likewise.
1048 * filelock.c: Likewise.
1050 * gtkutil.c: Likewise.
1051 * keyboard.c: Likewise.
1053 * lread.c: Likewise.
1054 * minibuf.c: Likewise.
1055 * msdos.c: Likewise.
1056 * print.c: Likewise.
1057 * process.c: Likewise.
1058 * region-cache.c: Likewise.
1059 * search.c: Likewise.
1060 * sysdep.c: Likewise.
1061 * termcap.c: Likewise.
1062 * terminal.c: Likewise.
1063 * tparam.c: Likewise.
1064 * w16select.c: Likewise.
1066 * w32reg.c: Likewise.
1067 * w32select.c: Likewise.
1068 * w32uniscribe.c: Likewise.
1069 * widget.c: Likewise.
1070 * xdisp.c: Likewise.
1071 * xmenu.c: Likewise.
1073 * xselect.c: Likewise.
1075 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1077 * fileio.c (time_error_value): Check the right error number.
1078 Problem reported by Troels Nielsen in
1079 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1081 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1083 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1084 This should be fixed in a better way; see Eli Zaretskii in
1085 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1086 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1088 * fileio.c (time_error_value): Rename from special_mtime.
1089 The old name's problems were noted by Eli Zaretskii in
1090 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1092 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1093 This variable's comment says Emacs needs at least one GDB-visible
1094 symbol of type enum pvec_type, to work around GDB problems.
1095 The symbol's value doesn't matter.
1097 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1098 that causes compilation to fail on pre-C99 compilers.
1100 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1102 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1103 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1105 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1107 * buffer.c (init_buffer_once): Fix initialization of
1108 headers for buffer_defaults and buffer_local_symbols.
1109 Reported by Juanma Barranquero <lekktu@gmail.com>.
1111 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1113 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1114 * lisp.h (enum pvec_type): Use fewer bits.
1115 (PSEUDOVECTOR_SIZE_BITS): New constant.
1116 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1117 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1118 change in pvec_type.
1119 (PSEUDOVECTOR_TYPEP): New macro.
1120 (TYPED_PSEUDOVECTORP): Use it.
1121 * fns.c (internal_equal): Adapt code to extract pvectype.
1122 * emacs.c (gdb_pvec_type): Update type.
1123 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1124 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1125 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1126 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1127 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1128 abusing vector->header.next.nbytes.
1129 (live_vector_p): Use PVEC_TYPE.
1130 (mark_object): Adapt code to extract pvectype. Use switch.
1132 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1134 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1135 Tighten new eassert a bit.
1137 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1139 Fix compilation with --enable-gcc-warnings and -O1
1141 * doprnt.c (doprnt): Change type of tem to int, initialize
1142 to avoid compiler warning. Add eassert.
1143 * search.c (simple_search): Initialize match_byte to avoid
1144 compiler warning. Add eassert.
1146 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1148 Avoid weird behavior with large horizontal scrolls.
1149 Without this change, for example, large hscroll values would
1150 mess up Emacs's display on Fedora 15 x86, presumably due to
1151 overflows in int calculations in the display code.
1152 Also, if buffers had long lines, Emacs would freeze.
1153 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1154 (set_window_hscroll): New function, containing the old guts of
1155 Fset_window_hscroll. Return the clipped value.
1156 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1157 This avoids the need to check against PTRDIFF_MAX.
1159 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1161 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1163 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1165 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1167 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1168 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1169 since GCC 4.4.6 issues a bogus warning for them.
1171 Fix bugs in file timestamp newness comparisons.
1172 * fileio.c (Ffile_newer_than_file_p):
1173 * lread.c (Fload): Use full timestamp resolution of files,
1174 not just the 1-second resolution, so that files that are only
1175 slightly newer still count as newer.
1176 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1177 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1179 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1181 * fileio.c: Improve handling of file time marker. (Bug#11852)
1182 (special_mtime): New function.
1183 (Finsert_file_contents, Fverify_visited_file_modtime):
1184 Use it to set special mtime values consistently.
1186 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1188 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1189 marker for non-existing file. (Bug#11852)
1191 2012-07-03 Glenn Morris <rgm@gnu.org>
1193 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1194 and did not make it into globals.h).
1196 2012-07-03 Tom Tromey <tromey@redhat.com>
1198 * window.c (Fset_window_margins, Fset_window_fringes)
1199 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1200 * textprop.c (Fprevious_property_change): No longer static.
1201 * syntax.c (Fsyntax_table_p): No longer static.
1202 * process.c (Fget_process, Fprocess_datagram_address): No longer
1204 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1205 * keyboard.c (Fcommand_execute): No longer static.
1207 * insdel.c (Fcombine_after_change_execute): No longer static.
1208 * image.c (Finit_image_library): No longer static.
1209 * fileio.c (Fmake_symbolic_link): No longer static.
1210 * eval.c (Ffetch_bytecode): No longer static.
1211 * editfns.c (Fuser_full_name): No longer static.
1212 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1214 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1216 * dired.c (Ffile_attributes): No longer static.
1217 * composite.c (Fcomposition_get_gstring): No longer static.
1218 * callproc.c (Fgetenv_internal): No longer static.
1220 * ccl.h: Remove EXFUNs.
1221 * buffer.h: Remove EXFUNs.
1222 * dispextern.h: Remove EXFUNs.
1223 * intervals.h: Remove EXFUNs.
1224 * fontset.h: Remove EXFUN.
1225 * font.h: Remove EXFUNs.
1226 * dosfns.c (system_process_attributes): Remove EXFUN.
1227 * keymap.h: Remove EXFUNs.
1228 * lisp.h: Remove EXFUNs.
1229 * w32term.h: Remove EXFUNs.
1230 * window.h: Remove EXFUNs.
1231 * xsettings.h: Remove EXFUN.
1232 * xterm.h: Remove EXFUN.
1234 2012-07-03 Glenn Morris <rgm@gnu.org>
1236 * lisp.h (Frandom): Make it visible to C.
1237 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1238 buffer for invisible buffers. (Bug#1229)
1240 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1242 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1243 values which aren't power of 2.
1244 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1245 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1248 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1250 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1252 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1254 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1256 * alloc.c (allocate_vector_block): Remove redundant
1257 calls to mallopt if DOUG_LEA_MALLOC is defined.
1258 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1259 avoid calls to mallopt if zero_vector is returned.
1261 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1263 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1264 is enabled, avoid dereferencing NULL current_sblock if
1267 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1269 Cleanup basic buffer management.
1270 * buffer.h (struct buffer): Change layout to use generic vector
1271 marking code. Fix some comments. Change type of 'clip_changed'
1272 to bitfield. Remove unused #ifndef old.
1273 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1274 (GET_OVERLAYS_AT): Fix indentation.
1275 (for_each_per_buffer_object_at): New macro.
1276 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1277 (Fbuffer_local_variables): Use it.
1278 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1279 * alloc.c (allocate_buffer): Adjust to match new layout of
1280 struct buffer. Fix comment.
1281 (mark_overlay): New function.
1282 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1283 Lisp area of struct buffer.
1284 (mark_object): Use it. Adjust marking of misc objects
1285 and related comments.
1287 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1289 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1290 wrapper that is not needed because the wrapped code is a no-op (zero
1291 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1292 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1294 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1296 * alloc.c (mark_buffer): Simplify. Remove prototype.
1297 (mark_object): Add comment. Reorganize marking of vector-like
1298 objects. Use CHECK_LIVE for all vector-like objects except buffers
1299 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1300 redundant calls to mark_vectorlike for bool vectors.
1302 2012-06-30 Glenn Morris <rgm@gnu.org>
1304 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1306 * epaths.in (PATH_SITELOADSEARCH): New.
1307 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1308 This is rather than relying on --enable-locallisppath elements
1309 having "site-lisp" in their names. (Bug#10208#25, 11658)
1311 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1313 * w32proc.c (sys_select): Accept and ignore one more argument.
1315 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1317 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1318 (pselect) [!MS_DOS]: Redirect to sys_select.
1320 * sysdep.c: Don't include dos.h and dosfns.h.
1322 * process.c (sys_select):
1323 * msdos.c (sys_select): Accept one more argument and ignore it.
1325 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1326 adapt data types and code to that.
1329 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1330 which clashes with the gnulib function of the same name.
1332 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1334 * font.c (font_style_to_value, font_style_symbolic)
1335 (font_prop_validate_style): Add type checks for values in
1338 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1340 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1343 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1345 * xdisp.c (try_window_id): Undo last change.
1347 * w32.c (getwd): Adjust commentary about startup_dir.
1348 (init_environment): Always call sys_access, even in non-MSVC
1349 builds. Don't chdir to the directory of the Emacs executable.
1350 This undoes code from 1997 which was justified by the need to
1351 "avoid conflicts when removing and renaming directories". But its
1352 downside was that every relative file name was being interpreted
1353 relative to the directory of the Emacs executable, which can never
1354 be TRT. In particular, it broke sys_access when called with
1355 relative file names.
1356 (sys_access): Map GetLastError to errno.
1358 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1360 * window.h (struct window): Change type of 'fringes_outside_margins'
1361 to bitfield. Fix comment. Adjust users accordingly.
1362 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1364 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1367 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1369 * gnutls.c (emacs_gnutls_handshake):
1370 Add QUIT to make the loop interruptible.
1372 2012-06-29 Glenn Morris <rgm@gnu.org>
1374 * charset.c (init_charset): Make lack of etc/charsets fatal.
1376 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1378 * editfns.c (region_limit): Fix type mismatch.
1380 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1382 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1383 undefined. Convert from xassert to eassert.
1384 * nsmenu.m: Convert from xassert to eassert.
1385 * nsterm.m: Likewise.
1387 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1389 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1391 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1393 Avoid integer overflow on scroll-left and scroll-right.
1394 * window.c (HSCROLL_MAX): New macro.
1395 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1396 overflow when requested scroll falls outside ptrdiff_t range.
1398 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1400 * window.h (struct window): Change type of 'hscroll',
1401 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1402 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1403 Adjust users accordingly.
1404 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1405 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1406 from EMACS_INT to ptrdiff_t.
1407 (make_window): Omit redundant initialization.
1409 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1411 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1413 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1415 * window.h (struct window): Change type of 'use_time' and
1416 'sequence_number' from Lisp_Object to int.
1417 * frame.c (make_frame): Adjust users accordingly.
1418 * print.c (print_object): Likewise.
1419 * window.c (select_window, Fwindow_use_time, make_parent_window)
1420 (make_window): Likewise.
1422 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1424 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1425 enabled with --enable-checking=[all,glyphs] configure option.
1426 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1427 adjust comments accordingly.
1428 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1429 undefined, adjust comments accordingly.
1430 * image.c: Likewise.
1431 * scroll.c: Likewise.
1432 * w32fns.c: Likewise.
1433 * w32term.c: Likewise.
1434 * xdisp.c: Likewise.
1435 * xfaces.c: Likewise.
1437 * xterm.c: Likewise.
1439 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1441 Generalize run-time debugging checks.
1442 * dispextern.h (XASSERTS): Remove.
1443 * fontset.c (xassert): Remove.
1444 Convert from xassert to eassert.
1445 * alloc.c: Convert from xassert to eassert.
1447 * dispnew.c: Likewise.
1449 * fringe.c: Likewise.
1450 * ftfont.c: Likewise.
1451 * gtkutil.c: Likewise.
1452 * image.c: Likewise.
1453 * keyboard.c: Likewise.
1455 * process.c: Likewise.
1456 * scroll.c: Likewise.
1457 * sound.c: Likewise.
1459 * w32console.c: Likewise.
1460 * w32fns.c: Likewise.
1461 * w32term.c: Likewise.
1462 * window.c: Likewise.
1463 * xdisp.c: Likewise.
1464 * xfaces.c: Likewise.
1466 * xselect.c: Likewise.
1467 * xterm.c: Likewise.
1469 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1471 * fns.c (maybe_resize_hash_table): Output message when growing the
1474 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1476 * alloc.c (allocate_string_data): Remove dead code.
1477 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1478 avoid GCC warning about unused macro.
1480 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1482 * alloc.c (allocate_string): Omit intervals initialization.
1483 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1484 as in make_pure_string and make_pure_c_string.
1486 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1488 * alloc.c (allocate_string): Fix last change.
1490 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1492 * alloc.c (allocate_string): Remove two redundant calls
1493 to memset, add explicit initialization where appropriate.
1495 2012-06-27 Glenn Morris <rgm@gnu.org>
1497 * lisp.mk (lisp): Remove paths.elc.
1499 2012-06-27 Chong Yidong <cyd@gnu.org>
1501 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1503 2012-06-26 John Wiegley <johnw@newartisans.com>
1505 * unexmacosx.c (copy_data_segment): Add two section names used
1506 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1508 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1509 when building with Clang.
1511 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1513 * eval.c (Fapply): Allow calling it with a single argument.
1515 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1517 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1518 _stricmp and _strnicmp.
1519 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1521 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1523 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1525 (allocate_process): Likewise for new process.
1526 (allocate_terminal): Change to use offsetof.
1527 (allocate_frame): Likewise.
1528 * frame.c (make_frame): Omit redundant initialization.
1529 * window.c (make_parent_window): Use memset.
1530 (make_window): Omit redundant initialization.
1531 * process.c (make_process): Omit redundant initialization.
1532 * terminal.c (create_terminal): Likewise.
1534 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1536 * term.c (delete_tty): Remove redundant call to memset.
1538 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1540 * alloc.c: Remove build_string.
1541 * lisp.h: Define build_string as static inline. This provides
1542 a better opportunity to optimize away calls to strlen when the
1543 function is called with compile-time constant argument.
1544 * image.c (imagemagick_error): Convert to build_string.
1545 * w32proc.c (sys_spawnve): Likewise.
1546 * xterm.c (x_term_init): Likewise.
1548 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1550 Use sprintf return value instead of invoking strlen on result.
1551 In the old days this wasn't portable, since some sprintf
1552 implementations returned char *. But they died out years ago and
1553 Emacs already assumes sprintf returns int.
1554 Similarly for float_to_string.
1555 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1556 * ccl.c (ccl_driver):
1557 * character.c (string_escape_byte8):
1558 * data.c (Fnumber_to_string):
1559 * doprnt.c (doprnt):
1560 * print.c (print_object):
1561 * xdisp.c (message_dolog):
1562 * xfns.c (syms_of_xfns):
1563 Use sprintf or float_to_string result to avoid need to call strlen.
1564 * data.c (Fnumber_to_string):
1565 Use make_unibyte_string, since the string must be ASCII.
1566 * lisp.h, print.c (float_to_string): Now returns int length.
1567 * term.c (produce_glyphless_glyph):
1568 Use sprintf result rather than recomputing it.
1570 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1571 * Makefile.in (ALL_CFLAGS):
1572 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1573 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1575 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1577 * dispextern.h (xstrcasecmp): Define to library function
1578 strcasecmp if available.
1579 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1581 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1583 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1584 Avoid comma operator.
1585 * menu.c (push_submenu_start, push_submenu_end)
1586 (push_left_right_boundary, push_menu_pane): Likewise.
1587 * msdos.c (dos_rawgetc): Likewise.
1589 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1591 * xfns.c (xic_create_fontsetname): Remove redundant calls
1594 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1596 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1597 sprintf already null-terminates its output.
1599 * xfns.c (x_window): Remove redundant cast.
1601 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1603 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1604 `const char *' to `char *' to avoid compiler warning.
1606 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1608 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1609 instead of truncating it to 63 (admittedly a generous limit).
1611 * process.c: Fix spelling and caps in comments.
1613 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1615 * emacs.c (setpgrp): Remove definition, unused.
1616 * sysdep.c (setpgrp): Remove definition, not used in this file.
1618 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1620 * makefile.w32-in: Update dependencies.
1622 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1624 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1625 (SYSTIME_H): Add nt/inc/sys/time.h.
1627 * systime.h [WINDOWSNT]: Include sys/time.h.
1629 * s/ms-w32.h (struct timespec): Definition moved from
1630 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1632 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1634 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1635 * buffer.h (buffer_slot_type_mismatch):
1636 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1637 * eval.c (unwind_to_catch):
1638 * image.c (my_png_error, my_error_exit):
1639 * keyboard.c (quit_throw_to_read_char, user_error)
1640 (Fexit_recursive_edit, Fabort_recursive_edit):
1641 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1642 (wrong_type_argument, buffer_overflow, __executable_start)
1643 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1644 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1645 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1647 (child_setup) [!DOS_NT]:
1648 * lread.c (end_of_file_error, invalid_syntax):
1649 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1650 * puresize.h (pure_write_error):
1651 * search.c (matcher_overflow):
1652 * sound.c (sound_perror, alsa_sound_perror):
1653 * sysdep.c, syssignal.h (croak):
1654 * term.c (maybe_fatal, vfatal):
1655 * textprop.c (text_read_only):
1656 * undo.c (user_error):
1657 * unexmacosx.c (unexec_error):
1658 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1659 Use _Noreturn rather than NO_RETURN.
1660 No need for separate decl merely because of _Noreturn.
1661 * sound.c (sound_warning, parse_sound):
1662 Remove unnecessary forward decls.
1664 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1666 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1667 * lisp.h (WAIT_READING_MAX): New macro.
1668 * dispnew.c (Fsleep_for, sit_for):
1669 * keyboard.c (kbd_buffer_get_event):
1670 * process.c (Faccept_process_output):
1671 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1672 This improves on the previous patch, which introduced a bug
1673 when time_t is unsigned and as wide as intmax_t.
1674 See <http://bugs.gnu.org/9000#51>.
1676 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1678 * dispnew.c (sit_for, Fsleep_for):
1679 * keyboard.c (kbd_buffer_get_event):
1680 * process.c (Faccept_process_output): Avoid compiler warnings when
1681 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1683 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1685 * makefile.w32-in: Update dependencies.
1687 * w32.c (ltime): Add return type and declare static.
1688 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1690 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1692 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1693 Privately reported by Herbert J. Skuhra.
1694 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1696 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1697 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1699 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1701 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1702 last argument of make_unibyte_string.
1704 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1705 language ID in the event parameters.
1707 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1708 event.code, not the obscure "character set ID".
1710 2012-06-23 Chong Yidong <cyd@gnu.org>
1712 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1714 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1716 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1717 * w32.c (fdutimens): New function.
1719 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1721 * s/ms-w32.h (pselect): Redirect to sys_select.
1723 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1725 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1726 in the logic of incrementing and decrementing the value of
1727 use_relocatable_buffers.
1729 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1731 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1732 Privately reported by Herbert J. Skuhra.
1733 [__FreeBSD__]: Remove "*/" typo after "#include".
1734 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1735 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1736 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1737 Don't assume EMACS_TIME and struct timeval are the same type.
1739 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1741 Support higher-resolution time stamps (Bug#9000).
1742 The time stamps are only nanosecond-resolution at the C level,
1743 since that's the best that any real-world system supports now.
1744 But they are picosecond-resolution at the Lisp level, as that's
1745 easy, and leaves room for future OS improvements.
1747 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1750 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1751 Don't get current time unless it's needed.
1753 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1754 now provides it if it's absent.
1755 (start_atimer): Port to higher-res time stamps.
1756 Check for time stamp overflow. Don't get current time more
1757 often than is needed.
1759 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1760 Include systime.h, not time.h.
1761 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1763 * dired.c: Include stat-time.h.
1764 (Ffile-attributes): File times now have higher resolution.
1766 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1767 (struct image): Timestamp now has higher resolution.
1769 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1770 has at least microseconds now. All uses removed.
1771 (update_frame, update_single_window, update_window, update_frame_1)
1772 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1774 * editfns.c (time_overflow): Now extern.
1775 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1776 (float-time, Fformat_time_string, Fcurrent_time_string)
1777 (Fcurrent_time_zone): Accept and generate higher-resolution
1779 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1780 (decode_time_components, lisp_seconds_argument): New functions.
1781 (make_time): Now static.
1782 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1783 Report an error if the time is invalid, rather than having the caller
1786 * fileio.c: Include <stat-time.h>
1787 (Fcopy_file): Copy higher-resolution time stamps.
1788 Prefer to set the time stamp via a file descriptor if that works.
1789 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1790 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1791 (Fvisited_file_modtime, Fset_visited_file_modtime):
1792 Support higher-resolution time stamps.
1794 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1796 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1798 * image.c (prepare_image_for_display, clear_image_cache)
1799 (lookup_image): Port to higer-resolution time stamps.
1801 * keyboard.c (start_polling, bind_polling_period):
1802 Check for time stamp overflow.
1803 (read_char, kbd_buffer_get_event, timer_start_idle)
1804 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1805 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1806 Port to higher-resolution time stamps. Do not assume time_t is signed.
1807 (decode_timer): New function. Timers are now vectors of length 9,
1808 not 8, to accommodate the picosecond component.
1809 (timer_check_2): Use it.
1811 * nsterm.m (select_timeout, timeval_subtract): Remove.
1812 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1813 as they're a bit more accurate and handle overflow better.
1814 (ns_select): Change prototype to be compatible with pselect.
1815 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1816 * nsterm.h (ns_select): Adjust prototype.
1818 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1819 us-resolution time stamps.
1820 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1822 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1824 * lisp.h (time_overflow): New decl.
1825 (wait_reading_process_output): First arg is now intmax_t, not int,
1826 to accommodate larger waits.
1828 * process.h (struct Lisp_Process.read_output_delay):
1829 Now counts nanoseconds, not microseconds.
1830 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1832 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1833 (wait_reading_process_output):
1834 Port to ns-resolution time stamps.
1835 (Faccept_process_output, wait_reading_process_output):
1836 Check for time stamp overflow. Do not assume time_t is signed.
1837 (select_wrapper): Remove; we now use pselect.
1838 (Fprocess_attributes): Now generates ns-resolution time stamps.
1840 * sysdep.c: Include utimens.h. Don't include utime.h
1841 or worry about struct utimbuf; gnulib does that for us now.
1842 (gettimeofday): Remove; gnulib provides a substitute.
1843 (make_timeval): New function.
1844 (set_file_times): Now sets ns-resolution time stamps.
1845 New arg FD; all uses changed.
1846 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1847 (system_process_attributes):
1848 Now returns ns-resolution time stamp. All uses changed.
1849 Check for time stamp overflow.
1851 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1852 provides a substitute now.
1854 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1855 since it guarantees struct timespec.
1856 (EMACS_TIME): Now struct timespec, so that we can support
1857 ns-resolution time stamps.
1858 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1859 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1860 (EMACS_USECS): Remove.
1861 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1862 so multiply the arg by 1000 before storing it.
1863 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1865 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1866 Port to ns-resolution time stamps.
1867 (EMACS_TIME_NEG_P): Remove; replaced by....
1868 (EMACS_TIME_SIGN): New macro.
1869 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1870 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1871 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1872 (make_timeval, make_lisp_time, decode_time_components): New decls.
1873 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1874 that it mishandled time_t overflow. You can't compare by subtracting!
1875 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1876 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1878 * term.c: Include <sys/time.h>.
1879 (timeval_to_Time): New function, for proper overflow wraparound.
1880 (term_mouse_position, term_mouse_click): Use it.
1882 * undo.c (record_first_change): Support higher-resolution time stamps
1884 (Fprimitive_undo): Use them when restoring time stamps.
1886 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1887 (w32_get_internal_run_time):
1888 Port to higher-resolution Emacs time stamps.
1889 (ltime): Now accepts single 64-bit integer, as that's more convenient
1892 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1894 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1895 for compatibility with pselect. Support ns-resolution time stamps.
1897 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1899 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1900 Check for time stamp overflow, and support ns-resolution time stamps.
1902 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1903 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1904 (timeval_subtract): Remove; no longer needed.
1905 (XTflash, XTring_bell, x_wait_for_event):
1906 Port to ns-resolution time stamps. Don't assume time_t is signed.
1908 2012-06-22 Chong Yidong <cyd@gnu.org>
1910 * xdisp.c (x_consider_frame_title): Revert last change.
1912 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1914 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1915 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1916 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1917 staticidx goes up to 1597 out of 1600 = 0x640.)
1919 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1921 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1922 Otherwise, the umask might be mistakenly 0 while handling input signals.
1924 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1926 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1928 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1930 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1931 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1932 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1933 access to `contents' member of Lisp_Vector objects with AREF and ASET
1936 2012-06-19 Chong Yidong <cyd@gnu.org>
1938 * frame.c (delete_frame): When selecting a frame on a different
1939 text terminal, do not alter the terminal's top-frame.
1941 * xdisp.c (format_mode_line_unwind_data): Record the target
1942 frame's selected window and its terminal's top-frame.
1943 (unwind_format_mode_line): Restore them.
1944 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1946 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1947 since tty frames can be explicitly named.
1948 (prepare_menu_bars): Likewise.
1950 * term.c (Ftty_top_frame): New function.
1952 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1954 Port byte-code-meter to modern targets.
1955 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1956 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1957 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1958 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1959 (METER_1, METER_2): Simplify.
1961 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1963 * data.c (Fdefalias): Return `symbol' (bug#11686).
1965 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1967 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1968 gets killed during executing of this function (Bug#11665).
1969 Try to always return Qt when the buffer has been actually killed.
1970 (Vkill_buffer_query_functions): In doc-string say that functions
1971 run by this hook should not change the current buffer.
1973 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1975 Fix recently-introduced process.c problems found by static checking.
1976 * process.c (write_queue_push, write_queue_pop, send_process):
1977 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1978 (write_queue_pop): Fix pointer signedness problem.
1979 (send_process): Remove unused local.
1981 2012-06-17 Chong Yidong <cyd@gnu.org>
1983 * xdisp.c (redisplay_internal): No need to redisplay terminal
1984 frames that are not on top.
1986 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1988 * process.c (make_process): Initialize write_queue.
1989 (write_queue_push, write_queue_pop): New functions.
1990 (send_process): Use them to maintain correct ordering of process
1993 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1995 * lisp.h (eassert): Assume C89 or later.
1996 This removes the need for CHECK.
1997 (CHECK): Remove. Its comments about always evaluating its
1998 argument were confusing, as 'eassert' typically does not evaluate
2001 * coding.c (produce_chars): Use ptrdiff_t, not int.
2003 * xterm.c (x_draw_underwave): Check for integer overflow.
2004 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2006 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2008 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2009 referenced (Bug#11583).
2011 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2013 Implement wave-style variant of underlining.
2014 * dispextern.h (face_underline_type): New enum.
2015 (face): Add field for underline type.
2016 * nsterm.m (ns_draw_underwave): New function.
2017 (ns_draw_text_decoration): Use it.
2018 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2020 (x_draw_glyph_string): Use them.
2021 * xfaces.c (Qline, Qwave): New Lisp objects.
2022 (check_lface_attrs, merge_face_ref)
2023 (Finternal_set_lisp_face_attribute, realize_x_face):
2024 Handle wave-style underline face attributes.
2025 * xterm.c (x_draw_underwave): New function.
2026 (x_draw_glyph_string): Use it.
2028 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2030 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2031 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2032 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2033 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2034 ($(BLD)/w32select.$(O)): Update dependencies.
2036 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2038 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2039 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2040 * character.c (_fetch_multibyte_char_p): Remove.
2041 * alloc.c: Include "character.h" before "buffer.h".
2043 * buffer.c: Likewise.
2044 * bytecode.c: Likewise.
2045 * callint.c: Likewise.
2046 * callproc.c: Likewise.
2047 * casefiddle.c: Likewise.
2048 * casetab.c: Likewise.
2049 * category.c: Likewise.
2051 * coding.c: Likewise.
2052 * composite.c: Likewise.
2053 * dired.c: Likewise.
2054 * dispnew.c: Likewise.
2056 * dosfns.c: Likewise.
2057 * editfns.c: Likewise.
2058 * emacs.c: Likewise.
2059 * fileio.c: Likewise.
2060 * filelock.c: Likewise.
2062 * fontset.c: Likewise.
2063 * fringe.c: Likewise.
2064 * indent.c: Likewise.
2065 * insdel.c: Likewise.
2066 * intervals.c: Likewise.
2067 * keyboard.c: Likewise.
2068 * keymap.c: Likewise.
2069 * lread.c: Likewise.
2070 * macros.c: Likewise.
2071 * marker.c: Likewise.
2072 * minibuf.c: Likewise.
2073 * nsfns.m: Likewise.
2074 * nsmenu.m: Likewise.
2075 * print.c: Likewise.
2076 * process.c: Likewise.
2077 * regex.c: Likewise.
2078 * region-cache.c: Likewise.
2079 * search.c: Likewise.
2080 * syntax.c: Likewise.
2082 * textprop.c: Likewise.
2084 * unexsol.c: Likewise.
2085 * w16select.c: Likewise.
2086 * w32fns.c: Likewise.
2087 * w32menu.c: Likewise.
2088 * window.c: Likewise.
2089 * xdisp.c: Likewise.
2091 * xmenu.c: Likewise.
2093 * xselect.c: Likewise.
2095 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2097 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2098 If all the glyphs of the glyph row came from strings, and we have no
2099 cursor positioning clues, put the cursor on the first glyph of the
2101 (handle_face_prop): Use chunk-relative overlay string index when
2102 indexing into it->string_overlays array. (Bug#11653)
2103 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2104 the rightmost. (Bug#11720)
2106 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2108 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2109 (CATEGORY_MEMBER): Enforce 1/0 value.
2110 * category.c (_temp_category_set): Remove.
2112 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2114 * window.c (Fdelete_other_windows_internal)
2115 (Fdelete_window_internal): Don't access frame's mouse highlight
2116 info of the initial frame. (Bug#11677)
2118 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2120 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2121 Assume USE_2_TAGS_FOR_INTS.
2122 (xreload): Adjust $tagmask width to match recent lisp.h change.
2124 Simplify lisp.h in minor ways that should not affect code.
2125 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2126 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2127 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2128 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2129 (INTTYPEBITS): New macro, for clarity.
2130 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2131 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2132 Simplify now that USE_LSB_TAG is always defined.
2133 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2134 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2136 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2138 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2140 2012-06-13 Glenn Morris <rgm@gnu.org>
2142 * s/bsd-common.h (BSD4_3):
2143 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2145 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2147 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2150 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2152 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2153 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2154 * alloc.c (widen_to_Lisp_Object): Remove.
2155 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2156 * frame.c (delete_frame): Remove outdated comment.
2157 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2158 USE_LISP_UNION_TYPE.
2159 (Fw32_unregister_hot_key): Likewise.
2160 (Fw32_toggle_lock_key): Likewise.
2161 * w32menu.c (add_menu_item): Likewise.
2162 (w32_menu_display_help): Use XIL instead of checking
2163 USE_LISP_UNION_TYPE.
2164 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2165 (init_heap): Likewise.
2166 * w32term.c (w32_read_socket): Update comment.
2168 2012-06-13 Glenn Morris <rgm@gnu.org>
2170 * s/usg5-4-common.h, src/s/unixware.h:
2171 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2173 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2175 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2177 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2178 * alloc.c (make_number) [!defined make_number]:
2179 Remove, as lisp.h always defines this now.
2180 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2181 (roundup_size): Verify that it is a power of 2.
2182 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2183 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2184 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2185 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2186 USE_LSB_TAG now is always defined to be either 0 or 1.
2188 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2189 code works fine either way, and efficiency is not a concern here,
2190 as the union type is for debugging, not for production.
2191 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2192 Use an inline function on all platforms when using the union type,
2193 since this is simpler and 'static inline' can be used portably
2195 (LISP_INITIALLY_ZERO): New macro.
2196 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2197 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2199 2012-06-12 Glenn Morris <rgm@gnu.org>
2201 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2203 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2205 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2206 Move BROKEN_SIGIO to configure.
2208 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2209 Move NO_TERMIO to configure.
2211 2012-06-12 Chong Yidong <cyd@gnu.org>
2213 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2214 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2215 MagickExportImagePixels is undefined.
2217 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2219 * image.c (imagemagick_load_image): Remove unused label.
2221 2012-06-11 Glenn Morris <rgm@gnu.org>
2223 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2224 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2225 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2226 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2228 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2230 * alloc.c (make_byte_code): New function.
2231 (Fmake_byte_code): Use it. Don't purify here.
2232 * lread.c (read1): Use it as well to avoid extra allocation.
2234 2012-06-11 Chong Yidong <cyd@gnu.org>
2236 * image.c (imagemagick_load_image): Implement transparency.
2238 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2240 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2241 account for preceding backslashes. (Bug#11663)
2243 2012-06-09 Chong Yidong <cyd@gnu.org>
2245 * term.c: Support italics in capable terminals (Bug#9652).
2246 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2247 (turn_on_face): Output using TS_enter_italic_mode if available.
2248 Don't handle unused blinking and alt-charset cases.
2249 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2250 and tty_alt_charset_p cases.
2251 (tty_capable_p, init_tty): Support italics.
2253 * termchar.h (struct tty_display_info): Add field for italics.
2254 Remove unused blink field.
2256 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2259 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2260 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2261 tty_alt_charset_p. Add tty_italic_p.
2263 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2265 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2266 dbus_type_is_basic if available.
2267 (xd_extract_signed, xd_extract_unsigned): Rename from
2268 extract_signed and extract_unsigned, respectively. Adapt callers.
2270 2012-06-09 Chong Yidong <cyd@gnu.org>
2272 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2274 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2277 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2279 * xdisp.c (vmessage): Treat frame message as multibyte.
2280 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2281 would generate the diagnostic "Making \302\247 buffer-local while
2284 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2286 * dispnew.c (showing_window_margins_p): Undo last change, which
2287 was done due to an inadvertent commit.
2288 (adjust_frame_glyphs_for_frame_redisplay): Do call
2289 showing_window_margins_p.
2291 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2293 * eval.c (Fmake_var_non_special): New primitive.
2294 (syms_of_eval): Defsubr it.
2295 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2297 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2299 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2300 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2302 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2304 * alloc.c (allocate_vectorlike): Fix last change.
2306 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2308 Block-based vector allocation of small vectors.
2309 * lisp.h (struct vectorlike_header): New field `nbytes',
2310 adjust comment accordingly.
2311 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2312 to denote vector blocks. Adjust users (live_vector_p,
2313 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2314 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2315 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2316 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2317 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2318 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2319 (roundup_size): New constant.
2320 (struct vector_block): New data type.
2321 (vector_blocks, vector_free_lists, zero_vector): New variables.
2322 (all_vectors): Rename to `large_vectors'.
2323 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2324 (sweep_vectors): New functions.
2325 (allocate_vectorlike): Return `zero_vector' as the only vector of
2326 0 items. Allocate new vector from block if vector size is less than
2327 or equal to VBLOCK_BYTES_MAX.
2328 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2329 (init_alloc_once): Add call to init_vectors.
2331 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2333 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2335 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2337 * doprnt.c (doprnt): Truncate multibyte char correctly.
2338 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2339 would mishandle a string argument "Xc" if X was a multibyte
2340 character of length 2: it would truncate after X's first byte
2341 rather than including all of X.
2343 2012-06-06 Chong Yidong <cyd@gnu.org>
2345 * buffer.c (word_wrap): Doc fix.
2347 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2349 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2351 2012-06-03 Glenn Morris <rgm@gnu.org>
2353 * xdisp.c (tool-bar-style): Doc fix.
2355 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2357 * Makefile.in (PAXCTL): Define.
2358 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2359 binary via PaX flags if the paxctl utility is available.
2360 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2361 Restore PaX flags to their default. (Bug#11398)
2363 2012-06-03 Chong Yidong <cyd@gnu.org>
2365 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2368 2012-06-03 Chong Yidong <cyd@gnu.org>
2370 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2371 (note_mode_line_or_margin_highlight): If there is no help echo,
2372 use mode-line-default-help-echo. Handle the case where the mouse
2373 position is past the end of the mode line string.
2375 * buffer.c (buffer_local_value_1): New function, split from
2376 Fbuffer_local_value; can return Qunbound.
2377 (Fbuffer_local_value): Use it.
2378 (Vmode_line_format): Docstring tweaks.
2380 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2382 * sysdep.c (system_process_attributes): Improve comment.
2384 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2386 * keyboard.c: Export real-this-command to Elisp.
2387 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2388 and DEFVAR it. Update all users.
2390 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2392 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2394 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2395 Convert pctcpu and pctmem to Lisp float properly.
2396 Let the compiler fold better, as 100.0/0x8000 is exact.
2398 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2400 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2403 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2405 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2407 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2409 For a 'struct window', replace some Lisp_Object fields to
2410 bitfields where appropriate, remove unused fields.
2411 * window.h (struct window): Remove unused 'last_mark_x' and
2412 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2413 change it's type from Lisp_Object to bitfield.
2414 Change type of 'force_start', 'optional_new_start',
2415 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2416 fields from Lisp_Object to bitfield. Adjust users accordingly.
2418 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2420 Pacify gcc -Wdouble-precision when using Xaw.
2421 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2422 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2423 Use 'float' consistently, rather than 'float' in most places
2424 and 'double' in a couple of places.
2426 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2428 * xdisp.c (handle_stop): Detect whether we have overlay strings
2429 loaded by testing it->current.overlay_string_index to be
2430 non-negative, instead of checking whether n_overlay_strings is
2431 positive. (Bug#11587)
2433 2012-05-31 Chong Yidong <cyd@gnu.org>
2435 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2437 * doc.c (Fsubstitute_command_keys): Doc fix.
2439 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2441 * search.c (search_buffer): Remove calls to
2442 r_alloc_inhibit_buffer_relocation, as it is now called by
2443 maybe_unify_char, which was the cause of relocation of buffer text
2446 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2448 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2449 for the duration of call to load_charset, to avoid problems with
2450 callers of maybe_unify_char that access buffer text through C
2453 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2454 decrement the inhibition flag, instead of just setting or
2457 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2459 Remove obsolete '#define static' cruft.
2460 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2461 This #undef was "temporary" in 2000; it is no longer needed
2462 now that '#define static' has gone away.
2463 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2464 (gray_bitmap_bits): Remove; no longer needed.
2465 All uses replaced with definiens.
2466 * xterm.c: Include "bitmaps/gray.xbm".
2468 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2470 Clean up __executable_start, monstartup when --enable-profiling.
2471 The following changes affect the code only when profiling.
2472 * dispnew.c (__executable_start): Rename from safe_bcopy.
2473 Define only on platforms that need it.
2474 * emacs.c: Include <sys/gmon.h> when profiling.
2475 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2476 (__executable_start): Remove decl, since lisp.h does it now.
2477 (safe_bcopy): Remove decl; no longer has that name.
2478 (main): Coalesce #if into single bit of code, for simplicity.
2479 Cast pointers to uintptr_t, since standard libraries want integers
2481 * lisp.h (__executable_start): New decl.
2483 2012-05-31 Glenn Morris <rgm@gnu.org>
2485 * image.c (Fimagemagick_types): Doc fix.
2487 2012-05-30 Jim Meyering <meyering@redhat.com>
2489 * callproc.c (Fcall_process_region): Include directory component
2490 in mkstemp error message (Bug#11586).
2492 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2494 * alloc.c, lisp.h (make_pure_vector): Now static.
2496 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2498 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2499 Move to byte-run.el.
2500 (Fautoload): Do the hash-doc more carefully.
2501 * data.c (Fdefalias): Purify definition, except for keymaps.
2502 (Qdefun): Move from eval.c.
2503 * lisp.h (Qdefun): Remove.
2504 * lread.c (read1): Tiny simplification.
2506 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2508 Do not create empty overlays with the evaporate property (Bug#9642).
2509 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2510 Bug#9642, but explicitly check that the buffer the overlay would
2511 be moved to is live and rearrange lines to make sure that errors
2512 will not put the overlay in an inconsistent state.
2513 (Fdelete_overlay): Cosmetics.
2515 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2517 * w32term.c (my_bring_window_to_top): New function.
2518 (x_raise_frame): Use handle returned by DeferWindowPos, which
2519 could be different from the original one.
2520 Call my_bring_window_to_top instead of my_set_foreground_window.
2523 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2524 by calling BringWindowToTop.
2526 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2527 (WM_EMACS_END): Increase by one.
2529 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2531 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2532 This avoids undefined behavior that might cause the eassert
2533 to not catch an out-of-range value.
2535 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2537 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2538 Update dependencies.
2540 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2542 * bidi.c (bidi_mirror_char): Fix last change.
2544 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2546 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2547 when referring to sectname field in printf format.
2549 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2551 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2552 Only r_alloc_inhibit_buffer_relocation needed to be added;
2553 the others were already declared.
2555 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2556 before checking whether it's out of range. Put the check inside
2558 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2560 2012-05-27 Ken Brown <kbrown@cornell.edu>
2562 * callproc.c (Fcall_process): Restore a line that was accidentally
2563 commented out in the 2011-02-13 change (bug#11547).
2565 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2567 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2568 defined on ralloc.c.
2570 * buffer.c [REL_ALLOC]: Remove prototypes of
2571 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2572 they are now on lisp.h.
2574 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2576 * search.c (search_buffer): Use it to inhibit relocation of buffer
2577 text while re_search_2 is doing its job, because re_search_2 is
2578 passed C pointers to buffer text. (Bug#11519)
2580 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2583 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2584 state after an additional call to move_it_in_display_line_to, keep
2585 the values of it->max_ascent and it->max_descent found for the
2587 (pos_visible_p): Revert the comparison against bottom_y to what it
2588 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2591 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2593 Fix coding-related core dumps with gcc -ftrapv.
2594 The code was computing A - B, where A and B are pointers, and B is
2595 random garbage. This can lead to core dumps on platforms that
2596 have special pointer registers, and it also leads to core dumps on
2597 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2598 A - B only when B is initialized properly.
2599 * coding.c (coding_set_source, coding_set_destination): Return void.
2600 (coding_change_source, coding_change_destinations): New functions,
2601 with the old behaviors of coding_set_source and coding_set_destination.
2602 All callers that need an offset changed to use these new functions.
2604 2012-05-26 Glenn Morris <rgm@gnu.org>
2606 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2608 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2610 Extend mouse support on W32 text-mode console.
2611 * xdisp.c (draw_row_with_mouse_face):
2612 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2614 * w32console.c: Include window.h.
2615 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2617 (initialize_w32_display): Initialize mouse-highlight data.
2619 * w32inevt.c: Include termchar.h and window.h.
2620 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2621 moves, call note_mouse_highlight. If help_echo changed, call
2622 gen_help_event to produce help-echo message in the echo area.
2623 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2626 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2628 * lread.c (read1): Simplify slightly to avoid an overflow warning
2629 with GCC 4.7.0 on x86-64.
2631 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2633 * bidi.c (bidi_mirror_char): Revert last change: an int is
2634 definitely wide enough here.
2636 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2638 Fix integer width and related bugs (Bug#9874).
2639 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2640 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2641 (string_bytes, check_sblock, allocate_string_data):
2642 (compact_small_strings, Fmake_bool_vector, make_string)
2643 (make_unibyte_string, make_multibyte_string)
2644 (make_string_from_bytes, make_specified_string)
2645 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2646 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2649 (allocate_pseudovector):
2650 Use int, not EMACS_INT, where int is wide enough.
2651 (inhibit_garbage_collection, Fgarbage_collect):
2652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2653 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2654 int might not be wide enough.
2655 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2656 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2657 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2658 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2659 (bidi_level_of_next_char, bidi_move_to_visually_next):
2660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2661 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2662 (Fkill_buffer, Fset_buffer_major_mode)
2663 (advance_to_char_boundary, Fbuffer_swap_text)
2664 (Fset_buffer_multibyte, overlays_at, overlays_in)
2665 (overlay_touches_p, struct sortvec, record_overlay_string)
2666 (overlay_strings, recenter_overlay_lists)
2667 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2668 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2669 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2670 (Foverlay_recenter, last_overlay_modification_hooks_used)
2671 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2673 (validate_region): Omit unnecessary test for b <= e,
2674 since that's guaranteed by the previous test.
2675 (adjust_overlays_for_delete): Avoid pos + length overflow.
2676 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2677 (report_overlay_modification):
2678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2679 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2680 Omit pointer cast, which isn't needed anyway, and doesn't work
2681 after the EMACS_INT -> ptrdiff_t change.
2682 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2683 * buffer.h: Adjust decls to match defn changes elsewhere.
2684 (struct buffer_text, struct buffer):
2685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2686 Use EMACS_INT, not int, where int might not be wide enough.
2687 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2688 not int, to avoid needless 32-bit limit on 64-bit hosts.
2689 (exec_byte_code): Use tighter memory-full test, one that checks
2690 for alloca overflow. Don't compute the address of the object just
2691 before an array, as that's not portable. Use EMACS_INT, not
2692 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2693 * callint.c (Fcall_interactively):
2694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2695 * callproc.c (call_process_kill, Fcall_process):
2696 Don't assume pid_t fits into an Emacs fixnum.
2697 (call_process_cleanup, Fcall_process, child_setup):
2698 Don't assume pid_t fits into int.
2699 (call_process_cleanup, Fcall_process, delete_temp_file)
2700 (Fcall_process_region):
2701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2702 (Fcall_process): Simplify handling of volatile integers.
2703 Use int, not EMACS_INT, where int will do.
2704 * casefiddle.c (casify_object, casify_region, operate_on_word)
2705 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2707 (casify_object): Avoid integer overflow when overallocating buffer.
2708 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2709 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2710 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2711 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2712 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2713 integers are now checked earlier. All uses replaced with XINT.
2715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2716 For CCL_MapSingle, check that content and value are in int range.
2717 (ccl_driver, Fregister_code_conversion_map):
2718 Check that Vcode_version_map_vector is a vector.
2719 (resolve_symbol_ccl_program): Check that vector header is in range.
2720 Always copy the vector, so that we can check its contents reliably
2721 now rather than having to recheck each instruction as it's being
2722 executed. Check that vector words fit in 'int'.
2723 (ccl_get_compiled_code, Fregister_ccl_program)
2724 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2725 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2726 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2727 contents are in range.
2728 (Fccl_execute_on_string): Check that status is in range.
2729 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2730 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2731 Accept and return EMACS_INT, not int, because callers can pass values
2733 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2734 (multibyte_chars_in_text, parse_str_as_multibyte)
2735 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2736 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2737 (string_escape_byte8, Fget_byte):
2738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2739 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2740 avoid mishandling large integers.
2741 * character.h: Adjust decls to match defn changes elsewhere.
2742 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2743 (Ffind_charset_region):
2744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2745 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2746 (load_charset_map_from_vector, Fdefine_charset_internal):
2747 Don't assume fixnum fits in int.
2748 (load_charset_map_from_vector, Fmap_charset_chars):
2749 Remove now-unnecessary CHECK_NATNUMs.
2750 (Fdefine_charset_internal): Check ranges here, more carefully.
2751 Don't rely on undefined behavior with signed left shift overflow.
2752 Don't assume unsigned int fits into fixnum, or that fixnum fits
2753 into unsigned int. Don't require max_code to be a valid fixnum;
2754 that's not true for gb10830 4-byte on a 32-bit host. Allow
2755 invalid_code to be a cons, for the same reason. Require code_offset
2756 to be a character. Avoid int overflow if max_char is close
2758 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2759 this is intended anyway and avoids some undefined behavior.
2760 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2761 INDEX_TO_CODE_POINT, as that's what it expects.
2762 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2763 * charset.h (DECODE_CHAR): Return int, not unsigned;
2764 this is what was intended anyway, and it avoids undefined behavior.
2765 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2766 integer-overflow issues.
2767 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2768 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2769 where the argument is EMACS_INT, and this behavior is not intended.
2770 * chartab.c (Fmake_char_table, Fset_char_table_range)
2771 (uniprop_get_decoder, uniprop_get_encoder):
2772 Don't assume fixnum fits in int.
2773 * cmds.c (move_point): New function, that does the gist of
2774 Fforward_char and Fbackward_char, but does so while checking
2775 for integer overflow more accurately.
2776 (Fforward_char, Fbackward_char): Use it.
2777 (Fforward_line, Fend_of_line, internal_self_insert)
2778 (internal_self_insert):
2779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2780 Fix a FIXME, by checking for integer overflow when calculating
2781 target_clm and actual_clm.
2782 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2783 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2784 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2785 (coding_alloc_by_making_gap, alloc_destination)
2786 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2787 (encode_coding_utf_16, detect_coding_emacs_mule)
2788 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2789 (detect_coding_iso_2022, decode_coding_iso_2022)
2790 (encode_invocation_designation, encode_designation_at_bol)
2791 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2792 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2793 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2794 (encode_coding_ccl, encode_coding_raw_text)
2795 (detect_coding_charset, decode_coding_charset)
2796 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2797 (produce_composition, produce_charset, produce_annotation)
2798 (decode_coding, handle_composition_annotation)
2799 (handle_charset_annotation, consume_chars, decode_coding_gap)
2800 (decode_coding_object, encode_coding_object, detect_coding_system)
2801 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2802 (code_convert_region, code_convert_string)
2803 (Fdefine_coding_system_internal)
2804 (coding_set_source, coding_set_destination):
2805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2806 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2807 (Fdefine_coding_system_internal):
2808 Don't assume fixnums fit in int.
2809 (decode_coding_gap, decode_coding_object, encode_coding_object)
2810 (Fread_coding_system, Fdetect_coding_region)
2811 (Funencodable_char_position, Fcheck_coding_systems_region)
2812 (get_translation, handle_composition_annotation, consume_chars):
2813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2814 (consume_chars): Rewrite to not calculate an address outside buffer.
2815 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2816 Don't access memory outside of the args array.
2817 (Fdefine_coding_system_internal): Check for charset-id overflow.
2818 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2819 result of ENCODE_CHAR.
2820 * coding.h: Adjust decls to match defn changes elsewhere.
2821 (struct coding_system):
2822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2823 * composite.c (get_composition_id, find_composition)
2824 (run_composition_function, update_compositions)
2825 (compose_text, composition_gstring_put_cache)
2826 (composition_gstring_p, composition_gstring_width)
2827 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2828 (composition_compute_stop_pos, composition_reseat_it)
2829 (composition_update_it, struct position_record)
2830 (find_automatic_composition, composition_adjust_point)
2831 (Fcomposition_get_gstring, Ffind_composition_internal):
2832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2833 (update_compositions):
2834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2835 * composite.h: Adjust decls to match defn changes elsewhere.
2836 (struct composition):
2837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2838 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2839 Do not attempt to compute the address of the object just before a
2840 buffer; this is not portable.
2842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2843 (Faset): Use int, not EMACS_INT, where int is wide enough.
2844 (Fstring_to_number): Don't assume fixnums fit in int.
2845 (Frem): Don't assume arg is nonnegative.
2846 * dbusbind.c (xd_append_arg): Check for integers out of range.
2847 (Fdbus_call_method): Don't overflow the timeout int.
2848 (extract_signed, extract_unsigned): New functions.
2849 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2850 (xd_get_connection_references): Return ptrdiff_t, not int.
2852 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2853 (xd_read_message_1):
2854 Use int, not unsigned, where the dbus API uses int.
2855 (Fdbus_message_internal): Don't overflow mtype.
2856 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2857 * dired.c (directory_files_internal, file_name_completion, scmp)
2858 (file_name_completion_stat):
2859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2860 (file_name_completion): Don't overflow matchcount.
2861 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2862 * dispextern.h: Adjust decls to match defn changes elsewhere.
2863 (struct text_pos, struct glyph, struct bidi_saved_info)
2864 (struct bidi_string_data, struct bidi_it, struct composition_it)
2866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2867 (struct display_pos, struct composition_it, struct it):
2868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2869 * dispnew.c (increment_matrix_positions)
2870 (increment_row_positions, mode_line_string)
2871 (marginal_area_string):
2872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2873 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2875 (duration_to_sec_usec): New function, to check for overflow better.
2876 (Fsleep_for, sit_for): Use it.
2877 * doc.c (get_doc_string, store_function_docstring):
2878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2879 (get_doc_string, Fsnarf_documentation):
2880 Use int, not EMACS_INT, where int is wide enough.
2882 Use SAFE_ALLOCA, not alloca.
2883 Check for overflow when converting EMACS_INT to off_t.
2884 * doprnt.c (doprnt):
2885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2886 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2887 Don't assume uid_t fits into fixnum.
2888 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2889 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2890 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2891 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2892 (general_insert_function)
2893 (Finsert_char, make_buffer_string, make_buffer_string_both)
2894 (update_buffer_properties, Fbuffer_substring)
2895 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2896 (Fsubst_char_in_region, check_translation)
2897 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2898 (transpose_markers, Ftranspose_regions):
2899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2900 (clip_to_bounds): Move to lisp.h as an inline function).
2901 (Fconstrain_to_field): Don't assume integers are nonnegative.
2902 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2903 (Fsubst_char_in_region, Fsave_restriction):
2904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2905 (Femacs_pid): Don't assume pid_t fits into fixnum.
2906 (lo_time): Use int, not EMACS_INT, when int suffices.
2907 (lisp_time_argument): Check for usec out of range.
2908 (Fencode_time): Don't assume fixnum fits in int.
2909 (Fuser_login_name, Fuser_full_name): Signal an error
2910 if a uid argument is out of range, rather than relying on
2912 (Fformat_time_string): Remove now-unnecessary check.
2913 lisp_time_argument checks for out-of-range usec now.
2914 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2915 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2916 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2917 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2918 (init_cmdargs, Fdump_emacs):
2919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2920 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2921 the bottom (typically) 32 bits of the fixnum.
2922 * eval.c (specpdl_size, call_debugger):
2923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2924 (when_entered_debugger, Fbacktrace_debug):
2925 Don't assume fixnum can fit in int.
2926 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2927 the object just before a buffer; this is not portable.
2928 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2929 (grow_specpdl, unbind_to):
2930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2931 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2932 (grow_specpdl): Simplify allocation by using xpalloc.
2933 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2934 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2935 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2937 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2940 (Fcopy_file, non_regular_nbytes, read_non_regular)
2941 (Finsert_file_contents):
2942 Use int, not EMACS_INT, where int is wide enough.
2943 (READ_BUF_SIZE): Verify that it fits in int.
2944 (Finsert_file_contents): Check that counts are in proper range,
2945 rather than assuming fixnums fit into ptrdiff_t etc.
2946 Don't assume fixnums fit into int.
2947 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2948 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2949 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2950 (string_char_to_byte, string_byte_to_char)
2951 (string_make_multibyte, string_to_multibyte)
2952 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2953 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2954 (substring_both, Fdelete, internal_equal, Ffillarray)
2955 (Fclear_string, mapcar1)
2956 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2957 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2958 (larger_vector, make_hash_table, maybe_resize_hash_table)
2959 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2960 (Fmaphash, secure_hash):
2961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2962 (concat): Check for string index and length overflow.
2963 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2966 (larger_vector): New API (vec, incr_min, size_max) replaces old
2967 one (vec, new_size, init). This catches size overflow.
2968 INIT was removed because it was always Qnil.
2969 All callers changed.
2970 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2971 the upper bound on a hash table index size.
2972 (make_hash_table, maybe_resize_hash_table): Use it.
2973 (secure_hash): Computer start_byte and end_byte only after
2974 they're known to be in ptrdiff_t range.
2975 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2976 (Ffont_get_glyphs, Ffont_at):
2977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2978 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2979 (Flist_fonts, Fopen_font):
2980 Don't assume fixnum can fit in int.
2981 (check_gstring): Don't assume index can fit in int.
2982 (font_match_p): Check that fixnum is a character, not a nonnegative
2983 fixnum, since the later code needs to stuff it into an int.
2984 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2985 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2986 conversion overflow issues.
2987 (Fopen_font): Check for integer out of range.
2988 (Ffont_get_glyphs): Don't assume index can fit in int.
2989 * font.h: Adjust decls to match defn changes elsewhere.
2990 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2992 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2993 printmax_t, where ptrdiff_t is wide enough.
2994 (Finternal_char_font):
2995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2996 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2997 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2998 (Fset_frame_position, x_set_frame_parameters)
2999 (x_set_line_spacing, x_set_border_width)
3000 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3001 Check that fixnums are in proper range for system types.
3002 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3004 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3005 Use SAFE_ALLOCA_LISP, not alloca.
3006 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3007 intptr_t is wide enough.
3008 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3009 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3010 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3011 Check for fixnum out of range.
3012 * ftfont.c (ftfont_list): Don't assume index fits in int.
3013 Check that fixnums are in proper range for system types.
3014 (ftfont_shape_by_flt):
3015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3016 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3018 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3019 Check that fixnums are in proper range for system types.
3020 * gnutls.h: Adjust decls to match defn changes elsewhere.
3021 * gtkutil.c (xg_dialog_run):
3022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3023 (update_frame_tool_bar):
3024 Check that fixnums are in proper range for system types.
3025 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3026 (lookup_image): Check that fixnums are in range for system types.
3027 * indent.c (last_known_column, last_known_column_point):
3028 (current_column_bol_cache):
3029 (skip_invisible, current_column, check_display_width):
3030 (check_display_width, scan_for_column, current_column_1)
3031 (Findent_to, Fcurrent_indentation, position_indentation)
3032 (indented_beyond_p, Fmove_to_column, compute_motion):
3033 (Fcompute_motion, Fvertical_motion):
3034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3035 (last_known_column_modified): Use EMACS_INT, not int.
3036 (check_display_width):
3038 Check that fixnums and floats are in proper range for system types.
3039 (compute_motion): Don't assume index or fixnum fits in int.
3040 (compute_motion, Fcompute_motion):
3041 Use int, not EMACS_INT, when it is wide enough.
3042 (vmotion): Omit local var start_hpos that is always 0; that way
3043 we don't need to worry about overflow in expressions involving it.
3044 * indent.h: Adjust decls to match defn changes elsewhere.
3046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3047 Use int, not EMACS_INT, where int is wide enough.
3048 Remove unused members ovstring_chars_done and tab_offset;
3050 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3051 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3052 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3053 (make_gap, copy_text, insert, insert_and_inherit)
3054 (insert_before_markers, insert_before_markers_and_inherit)
3055 (insert_1, count_combining_before, count_combining_after)
3056 (insert_1_both, insert_from_string)
3057 (insert_from_string_before_markers, insert_from_string_1)
3058 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3059 (adjust_after_replace, adjust_after_insert, replace_range)
3060 (replace_range_2, del_range, del_range_1, del_range_byte)
3061 (del_range_both, del_range_2, modify_region)
3062 (prepare_to_modify_buffer, signal_before_change)
3063 (signal_after_change, Fcombine_after_change_execute):
3064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3065 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3066 (balance_an_interval, split_interval_right, split_interval_left)
3067 (find_interval, next_interval, update_interval)
3068 (adjust_intervals_for_insertion, delete_node, delete_interval)
3069 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3070 (static_offset_intervals, offset_intervals)
3071 (merge_interval_right, merge_interval_left, make_new_interval)
3072 (graft_intervals_into_buffer, temp_set_point_both)
3073 (temp_set_point, set_point, adjust_for_invis_intang)
3074 (set_point_both, move_if_not_intangible, get_property_and_range)
3075 (get_local_map, copy_intervals, copy_intervals_to_string)
3076 (compare_string_intervals, set_intervals_multibyte_1):
3077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3078 * intervals.h: Adjust decls to match defn changes elsewhere.
3080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3081 * keyboard.c (this_command_key_count, this_single_command_key_start)
3082 (before_command_key_count, before_command_echo_length, echo_now)
3083 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3084 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3085 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3086 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3088 (last_non_minibuf_size, last_point_position, echo_truncate)
3089 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3090 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3091 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3092 (stuff_buffered_input):
3093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3094 (last_auto_save, command_loop_1, read_char):
3095 Use EMACS_INT, not int, to avoid integer overflow.
3096 (record_char): Avoid overflow in total_keys computation.
3097 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3098 * keyboard.h: Adjust decls to match defn changes elsewhere.
3099 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3100 (Fkey_description, Fdescribe_vector, Flookup_key):
3101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3102 (click_position): New function, to check that positions are in range.
3103 (Fcurrent_active_maps):
3105 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3106 (Faccessible_keymaps, Fkey_description):
3107 (preferred_sequence_p):
3108 Don't assume fixnum can fit into int.
3109 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3110 Check for integer overflow in size calculations.
3111 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3112 avoid mishandling large integers.
3113 * lisp.h: Adjust decls to match defn changes elsewhere.
3114 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3115 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3116 (struct Lisp_Marker):
3117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3118 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3119 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3120 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3121 All callers changed.
3122 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3123 Assume the arg has valid form, since it always does.
3124 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3125 unsigned integer system type.
3126 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3127 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3129 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3130 (duration_to_sec_usec): New decl.
3131 * lread.c (read_from_string_index, read_from_string_index_byte)
3132 (read_from_string_limit, readchar, unreadchar, openp)
3133 (read_internal_start, read1, oblookup):
3134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3135 (Fload, readevalloop, Feval_buffer, Feval_region):
3136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3137 (openp): Check for out-of-range argument to 'access'.
3138 (read1): Use int, not EMACS_INT, where int is wide enough.
3139 Don't assume fixnum fits into int.
3140 Fix off-by-one error that can read outside a buffer.
3141 (read_filtered_event): Use duration_to_sec_usec
3142 to do proper overflow checking on durations.
3143 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3144 in size calculation.
3145 (Fexecute_kbd_macro):
3146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3147 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3148 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3149 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3150 (set_marker_both, set_marker_restricted_both, marker_position)
3151 (marker_byte_position, Fbuffer_has_markers_at):
3152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3153 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3154 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3155 It now merely ensures that the menu is large enough, without
3156 necessarily growing it, as this avoids some integer overflow issues.
3157 All callers changed.
3158 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3159 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3160 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3161 Use SAFE_ALLOCA_LISP, not alloca.
3162 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3163 to EMACS_INT. Check that fixnums are in proper range for system types.
3164 * minibuf.c (minibuf_prompt_width, string_to_object)
3165 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3166 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3168 (get_minibuffer, read_minibuf_unwind):
3169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3170 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3171 this simplifies overflow checking. All callers changed.
3172 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3175 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3176 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3177 Check that fixnums are in proper range for system types.
3178 (Fx_create_frame, Fx_show_tip):
3179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3180 * nsfont.m (ns_findfonts, nsfont_list_family):
3181 Don't assume fixnum fits in long.
3182 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3184 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3186 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3188 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3189 (PRINTDECLARE, PRINTPREPARE):
3190 (strout, print_string):
3191 (print, print_preprocess, print_check_string_charset_prop)
3193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3195 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3197 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3198 (printchar, strout): Use xpalloc to catch size calculation overflow.
3199 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3200 (print_error_message): Use SAFE_ALLOCA, not alloca.
3201 (print_object): Use int, not EMACS_INT, where int is wide enough.
3202 (print_depth, new_backquote_output, print_number_index):
3203 Use ptrdiff_t, not int, where int might not be wide enough.
3204 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3205 (Fset_process_window_size, Fformat_network_address)
3206 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3208 Check that fixnums are in proper range for system types.
3209 (Fsignal_process): Simplify by avoiding a goto.
3210 Check for process-ids out of pid_t range rather than relying on
3212 (process_tick, update_tick): Use EMACS_INT, not int.
3213 (Fformat_network_address, read_process_output, send_process)
3214 (Fprocess_send_region, status_notify):
3215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3216 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3217 (wait_reading_process_output, read_process_output, exec_sentinel):
3218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3219 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3220 (Faccept_process_output): Use duration_to_sec_usec to do proper
3221 overflow checking on durations.
3222 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3223 Don't assume pid_t fits in int.
3224 * process.h (struct Lisp_Process): Members tick and update_tick
3225 are now of type EMACS_INT, not int.
3226 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3227 configured --with-wide-int.
3228 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3229 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3230 * search.c (looking_at_1, string_match_1):
3231 (fast_string_match, fast_c_string_match_ignore_case)
3232 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3233 (scan_newline, find_before_next_newline, search_command)
3234 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3235 (set_search_regs, wordify):
3238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3239 (string_match_1, search_buffer, set_search_regs):
3241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3242 (wordify): Check for overflow in size calculation.
3243 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3244 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3245 Check that fixnums are in proper range for system types.
3246 * sound.c (struct sound_device)
3247 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3249 (Fplay_sound_internal):
3250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3251 * syntax.c (struct lisp_parse_state, find_start_modiff)
3252 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3253 (Fparse_partial_sexp):
3254 Don't assume fixnums can fit in int.
3255 (struct lisp_parse_state, find_start_pos, find_start_value)
3256 (find_start_value_byte, find_start_begv)
3257 (update_syntax_table, char_quoted, dec_bytepos)
3258 (find_defun_start, prev_char_comend_first, back_comment):
3259 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3260 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3262 (Finternal_describe_syntax_value): Check that match_lisp is a
3263 character, not an integer, since the code stuffs it into int.
3264 (scan_words, scan_sexps_forward):
3265 Check that fixnums are in proper range for system types.
3267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3268 (scan_sexps_forward):
3269 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3270 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3271 * syntax.h: Adjust decls to match defn changes elsewhere.
3272 (struct gl_state_s):
3273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3274 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3275 MOST_POSITIVE_FIXNUM.
3276 * sysdep.c (wait_for_termination_1, wait_for_termination)
3277 (interruptible_wait_for_termination, mkdir):
3278 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3279 (emacs_read, emacs_write):
3280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3281 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3282 and double all fit in int.
3283 * term.c (set_tty_color_mode):
3284 Check that fixnums are in proper range for system types.
3285 * termhooks.h (struct input_event):
3286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3287 * textprop.c (validate_interval_range, interval_of)
3288 (Fadd_text_properties, set_text_properties_1)
3289 (Fremove_text_properties, Fremove_list_of_text_properties)
3290 (Ftext_property_any, Ftext_property_not_all)
3291 (copy_text_properties, text_property_list, extend_property_ranges)
3292 (verify_interval_modification):
3293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3294 (Fnext_single_char_property_change)
3295 (Fprevious_single_char_property_change):
3296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3297 (copy_text_properties):
3298 Check for integer overflow in index calculation.
3299 * undo.c (last_boundary_position, record_point, record_insert)
3300 (record_delete, record_marker_adjustment, record_change)
3301 (record_property_change):
3302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3303 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3305 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3306 (Fx_hide_tip, Fx_file_dialog):
3307 * w32menu.c (set_frame_menubar):
3308 Use ptrdiff_t, not int, for consistency with rest of code.
3309 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3310 (select_window, Fdelete_other_windows_internal)
3311 (window_scroll_pixel_based, window_scroll_line_based)
3312 (Frecenter, Fset_window_configuration):
3313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3314 (Fset_window_hscroll, run_window_configuration_change_hook)
3315 (set_window_buffer, temp_output_buffer_show, scroll_command)
3316 (Fscroll_other_window, Frecenter):
3317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3318 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3319 Don't assume fixnum fits in int.
3320 (Fset_window_scroll_bars):
3321 Check that fixnums are in proper range for system types.
3322 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3323 (string_pos, c_string_pos, number_of_chars, init_iterator)
3324 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3325 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3326 (compute_display_string_end, handle_face_prop)
3327 (face_before_or_after_it_pos, handle_invisible_prop)
3328 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3329 (display_prop_intangible_p, string_buffer_position_lim)
3330 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3331 (get_overlay_strings_1, get_overlay_strings)
3332 (iterate_out_of_display_property, forward_to_next_line_start)
3333 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3334 (get_next_display_element, set_iterator_to_next)
3335 (get_visually_first_element, compute_stop_pos_backwards)
3336 (handle_stop_backwards, next_element_from_buffer)
3337 (move_it_in_display_line_to, move_it_in_display_line)
3338 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3339 (add_to_log, message_dolog, message_log_check_duplicate)
3340 (message2, message2_nolog, message3, message3_nolog
3341 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3342 (current_message_1, truncate_echo_area, truncate_message_1)
3343 (set_message, set_message_1, store_mode_line_noprop)
3344 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3345 (text_outside_line_unchanged_p, check_point_in_composition)
3346 (reconsider_clip_changes)
3347 (redisplay_internal, set_cursor_from_row, try_scrolling)
3348 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3349 (redisplay_window, find_last_unchanged_at_beg_row)
3350 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3351 (trailing_whitespace_p, find_row_edges, display_line)
3352 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3353 (display_mode_element, store_mode_line_string)
3354 (pint2str, pint2hrstr, decode_mode_spec)
3355 (display_count_lines, display_string, draw_glyphs)
3356 (x_produce_glyphs, x_insert_glyphs)
3357 (rows_from_pos_range, mouse_face_from_buffer_pos)
3358 (fast_find_string_pos, mouse_face_from_string_pos)
3359 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3361 (safe_call, init_from_display_pos, handle_fontified_prop)
3362 (handle_single_display_spec, load_overlay_strings)
3363 (with_echo_area_buffer, setup_echo_area_for_printing)
3364 (display_echo_area, echo_area_display)
3365 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3366 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3367 (redisplay_window, dump_glyph_row, display_mode_line)
3368 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3369 (handle_display_spec, display_prop_string_p):
3370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3371 (handle_single_display_spec, build_desired_tool_bar_string)
3372 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3373 (get_specified_cursor_type):
3374 Check that fixnums are in proper range for system types.
3375 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3376 (Flookup_image_map):
3377 Don't assume fixnums fit in int.
3378 (compare_overlay_entries):
3379 Avoid mishandling comparisons due to subtraction overflow.
3380 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3381 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3382 (handle_tool_bar_click):
3383 Use int, not unsigned, since we prefer signed and the signedness
3384 doesn't matter here.
3385 (get_next_display_element, next_element_from_display_vector):
3386 Use int, not EMACS_INT, when int is wide enough.
3387 (start_hourglass): Use duration_to_sec_usec to do proper
3388 overflow checking on durations.
3389 * xfaces.c (Fbitmap_spec_p):
3390 Check that fixnums are in proper range for system types.
3391 (compare_fonts_by_sort_order):
3392 Avoid mishandling comparisons due to subtraction overflow.
3393 (Fx_family_fonts, realize_basic_faces):
3394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3396 Don't assume fixnum fits in int.
3397 Use SAFE_ALLOCA_LISP, not alloca.
3398 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3399 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3400 (face_at_buffer_position, face_for_overlay_string)
3401 (face_at_string_position):
3402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3403 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3404 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3406 Check that fixnums are in proper range for system types.
3407 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3408 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3410 (Fx_change_window_property): Don't assume fixnums fit in int.
3411 * xfont.c (xfont_chars_supported):
3412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3413 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3414 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3416 * xml.c (parse_region):
3417 * xrdb.c (magic_file_p):
3418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3419 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3420 (x_get_local_selection, x_reply_selection_request)
3421 (x_handle_selection_request, wait_for_property_change):
3422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3423 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3424 short is wide enough.
3425 (x_send_client_event): Don't assume fixnum fits in int.
3426 * xterm.c (x_x_to_emacs_modifiers):
3427 Don't assume EMACS_INT overflows nicely into int.
3428 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3430 (handle_one_xevent): NATNUMP can eval its arg twice.
3431 (x_connection_closed):
3432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3433 * xterm.h: Adjust decls to match defn changes elsewhere.
3434 (struct scroll_bar): Use struct vectorlike_header
3435 rather than rolling our own approximation.
3436 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3438 2012-05-25 Glenn Morris <rgm@gnu.org>
3440 * lisp.mk (lisp): Update for more files being compiled now.
3442 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3444 * lread.c: Remove `read_pure' which makes no difference.
3445 (read_pure): Remove var.
3446 (unreadpure): Remove function.
3447 (readevalloop): Don't call read_list with -1 flag.
3448 (read1, read_vector): Don't test read_pure any more.
3449 (read_list): Simplify.
3451 * fileio.c, character.h: Minor style tweaks.
3453 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3455 * window.h (clip_changed): Remove useless declaration.
3457 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3459 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3460 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3462 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3465 This directory predates autoconf and is no longer needed nowadays.
3466 Move its few remaining bits of functionality to where they're needed.
3467 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3468 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3469 * m/template.h: Remove.
3470 * Makefile.in (M_FILE): Remove. All uses removed.
3471 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3472 * lisp.h (USE_LSB_TAG):
3473 * mem-limits.h (EXCEEDS_LISP_PTR):
3474 Use VAL_MAX, not VALBITS, in #if.
3475 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3476 (EMACS_UINT): Define unconditionally now.
3477 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3478 (BITS_PER_EMACS_INT): New constants, replacing
3479 what used to be in config.h, but not useful in #if.
3480 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3481 define them any more.
3482 (VAL_MAX): New macro.
3484 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3485 BITS_PER_EMACS_INT, in #if.
3486 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3487 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3488 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3489 * s/ms-w32.h (DATA_START):
3490 Move here from removed file m/intel386.h.
3491 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3492 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3494 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3496 Assume C89 or later.
3497 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3498 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3500 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3501 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3502 * textprop.c, tparam.c (NULL): Remove.
3503 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3504 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3505 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3506 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3507 * xterm.c (input_signal_count): Assume volatile works.
3509 2012-05-21 Ken Brown <kbrown@cornell.edu>
3511 * xgselect.c (xg_select): Fix first argument in call to 'select'
3514 2012-05-20 Ken Brown <kbrown@cornell.edu>
3516 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3517 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3519 2012-05-19 Ken Brown <kbrown@cornell.edu>
3521 * xfns.c (x_in_use): Remove `static' qualifier.
3522 * xterm.h (x_in_use): Declare.
3523 * xgselect.c: Include xterm.h.
3524 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3525 and `display_arg' (bug#9754).
3527 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3529 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3531 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3532 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3534 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3536 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3538 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3539 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3541 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3542 reference to image_cache->refcount.
3543 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3545 2012-05-17 Juri Linkov <juri@jurta.org>
3547 * search.c (Fword_search_regexp, Fword_search_backward)
3548 (Fword_search_forward, Fword_search_backward_lax)
3549 (Fword_search_forward_lax): Move functions to isearch.el
3550 (bug#10145, bug#11381).
3552 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3554 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3556 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3558 * lread.c (init_obarray): Declare Qt and Qnil as special.
3560 2012-05-14 Glenn Morris <rgm@gnu.org>
3562 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3563 Put "libexec" before "bin", for the sake of init_callproc_1.
3565 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3567 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3569 * unexaix.c: Port to more-recent AIX compilers.
3570 (report_error, report_error_1, make_hdr, copy_sym)
3571 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3572 Make arguments const char *, not char *, to avoid violations of C
3573 standard and to fix some AIX warnings reported by Gilles Pion.
3575 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3577 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3578 already have overlays loaded.
3579 (handle_single_display_spec): Before returning without displaying
3580 fringe bitmap, synchronize the bidi iterator with the main display
3581 iterator, by calling iterate_out_of_display_property.
3582 (iterate_out_of_display_property): Detect buffer iteration by
3583 testing that it->string is a Lisp string.
3584 (get_next_display_element): When the current object is exhausted,
3585 and there's something on it->stack, call set_iterator_to_next to
3586 proceed with what's on the stack, instead of returning zero.
3587 (set_iterator_to_next): If called at the end of a Lisp string,
3588 proceed to consider_string_end without incrementing string
3589 position. Don't increment display vector index past the end of
3590 the display vector. (Bug#11417)
3591 (pos_visible_p): Don't report a position visible when move_it_to
3592 stopped at the last line of window, which happens to be scanned
3593 backwards by the bidi iteration. (Bug#11464)
3595 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3597 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3598 and right-margin display specs even if the spec is invalid or we
3599 are on a TTY, and thus unable to display on the fringes.
3600 That's because the text with the property will not be displayed anyway,
3601 so we need to signal to the caller that this is a "replacing"
3602 display spec. This fixes display when the spec is invalid or we
3605 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3607 * unexaix.c (make_hdr): Fix typo in prototype.
3608 This bug broke the build on AIX. Problem reported by Gilles Pion.
3610 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3612 * keyboard.c (kbd_buffer_get_event): Read special events also in
3613 batch mode. (Bug#11415)
3615 2012-05-12 Glenn Morris <rgm@gnu.org>
3617 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3619 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3621 * lisp.mk (lisp): Add newcomment.elc.
3623 2012-05-12 Glenn Morris <rgm@gnu.org>
3625 * Makefile.in (MKDIR_P): New, set by configure.
3626 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3628 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3630 Remove unused function hourglass_started.
3631 * dispextern.h (hourglass_started):
3632 * w32fns.c (hourglass_started):
3633 * xdisp.c (hourglass_started): Remove.
3635 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3637 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3638 Update dependencies.
3640 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3642 * xgselect.c (xg_select): Put maxfds+1 into a var.
3643 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3645 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3647 2012-05-10 Dave Abrahams <dave@boostpro.com>
3649 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3650 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3652 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3654 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3655 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3656 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3657 Initialize xd_registered_buses.
3659 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3661 Untag more efficiently if USE_LSB_TAG.
3662 This is based on a proposal by YAMAMOTO Mitsuharu in
3663 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3664 For an admittedly artificial (nth 8000 longlist) benchmark on
3665 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3666 Emacs's overall text size by 1%.
3667 * lisp.h (XUNTAG): New macro.
3668 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3669 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3670 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3671 * eval.c (Fautoload):
3672 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3673 * frame.h (XFRAME): Use XUNTAG.
3675 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3676 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3677 Remove unportable assumptions about print widths of types like
3679 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3680 intptr_t when converting between pointer and integer, to avoid GCC
3681 warnings about wrong width.
3683 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3685 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3686 stack for each reader_thread, instead of defaulting to 8MB
3687 determined by the linker. This avoids failures in creating
3688 subprocesses on Windows 7, see the discussion in this thread:
3689 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3691 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3693 Fix up display of the *Minibuf-0* buffer in the mini window.
3694 * keyboard.c (read_char): Don't clear the echo area if there's no
3696 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3697 contents of *Minibuf-0*) if there's no message displayed in its stead.
3699 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3701 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3704 2012-05-06 Chong Yidong <cyd@gnu.org>
3706 * lisp.mk (lisp): Update.
3708 2012-05-05 Jim Meyering <meyering@redhat.com>
3710 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3712 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3714 * data.c (PUT_ERROR): New macro.
3715 (syms_of_data): Use it. Add new error type `user-error'.
3716 * undo.c (user_error): New function.
3717 (Fprimitive_undo): Use it.
3718 * print.c (print_error_message): Adjust print style for `user-error'.
3719 * keyboard.c (user_error): New function.
3720 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3722 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3724 Do not limit current-time-string to years 1000..9999.
3725 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3726 (Fcurrent_time_string): Support any year that is supported by the
3727 underlying localtime representation. Don't use asctime, as it
3728 has undefined behavior for years outside the range -999..9999.
3730 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3732 Fix race conditions involving setenv, gmtime, localtime, asctime.
3733 Without this fix, interrupts could mess up code that uses these
3734 nonreentrant functions, since setting TZ invalidates existing
3735 tm_zone or tzname values, and since most of these functions return
3736 pointers to static storage.
3737 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3738 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3739 Grow the critical sections to include not just invoking
3740 localtime/gmtime, but also accessing these functions' results
3741 including their tm_zone values if any, and any related TZ setting.
3742 (format_time_string): Last arg is now struct tm *, not struct tm **,
3743 so that the struct tm is saved in the critical section.
3744 All callers changed. Simplify allocation of initial buffer, partly
3745 motivated by the fact that memory allocation needs to be outside
3746 the critical section.
3748 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3750 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3751 with RESET_INTERVAL.
3753 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3754 Remove duplicated buffer name initialization.
3756 2012-05-02 Jim Meyering <jim@meyering.net>
3758 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3760 * xfns.c (x_window): Use xstrdup (Bug#11375).
3762 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3764 * xdisp.c (pos_visible_p): If already at a newline from the
3765 display string before the 'while' loop, don't walk back the glyphs
3766 from it3.glyph_row. Solves assertion violation when the display
3767 string begins with a newline (egg.el). (Bug#11367)
3769 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3771 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3774 2012-05-01 Glenn Morris <rgm@gnu.org>
3776 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3777 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3778 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3779 All were removed before 23.1.
3781 * dispnew.c: Remove HAVE_LIBNCURSES test;
3782 it is always true on relevant platforms.
3784 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3785 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3787 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3789 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3791 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3792 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3795 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3797 Do not avoid creating empty evaporating overlays (Bug#9642).
3798 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3799 That is, do not delete an evaporating overlay if it becomes
3800 empty after its bounds are adjusted to fit within its buffer.
3801 This fix caused other problems, and I'm reverting it until we get
3802 to the bottom of them.
3804 2012-04-27 Chong Yidong <cyd@gnu.org>
3806 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3808 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3810 * xdisp.c (pos_visible_p): If the window start position is beyond
3811 ZV, start the display from buffer beginning. Prevents assertion
3812 violation in init_iterator when the minibuffer window is scrolled
3815 * window.c (window_scroll_pixel_based): Likewise.
3817 2012-04-27 Chong Yidong <cyd@gnu.org>
3819 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3821 2012-04-27 Glenn Morris <rgm@gnu.org>
3823 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3824 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3826 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3828 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3829 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3831 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3833 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3834 display element, check also the underlying string or buffer
3835 character. (Bug#11341)
3837 * w32menu.c: Include w32heap.h.
3838 (add_menu_item): If the call to AppendMenuW (via
3839 unicode_append_menu) fails, disable Unicode menus only if we are
3840 running on Windows 9X/Me.
3842 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3844 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3845 (xgetint): Add missing shift for LSB tags.
3847 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3849 * keyboard.c (read_char): Don't wipe echo area for select window
3850 events: These might get delayed via `mouse-autoselect-window'
3853 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3855 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3856 manipulation of :loaded-from data.
3858 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3860 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3861 now a cons (bug#11311).
3863 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3865 Do not create empty overlays with the evaporate property (Bug#9642).
3866 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3867 if it becomes empty after its bounds are adjusted to fit within
3868 its buffer. Without this fix, in a nonempty buffer (let ((o
3869 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3870 yields an empty overlay that has the evaporate property, which is
3871 not supposed to happen.
3873 Fix minor GTK3 problems found by static checking.
3874 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3875 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3876 (struct _EmacsFixedClass, emacs_fixed_get_type):
3877 Move decls here from emacsgtkfixed.h, since they needn't be public.
3878 (emacs_fixed_get_type): Now static.
3879 (emacs_fixed_class_init): Omit unused local.
3880 (emacs_fixed_child_type): Remove; unused.
3881 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3882 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3883 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3884 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3885 (EMACS_FIXED_GET_CLASS): Remove; unused.
3886 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3888 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3889 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3891 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3893 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3894 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3895 (__malloc_size_t, __malloc_ptrdiff_t):
3896 Remove. All uses removed, replaced by the definiens if needed,
3897 since we can assume C89 or better now.
3898 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3899 (protect_malloc_state, align, get_contiguous_space)
3900 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3901 (malloc_atfork_handler_child, malloc_enable_thread)
3902 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3903 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3904 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3905 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3906 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3907 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3908 Define using prototypes, not old style.
3909 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3910 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3911 (align): Don't assume that signed integer overflow wraps around.
3912 Omit unused local var.
3913 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3914 (_free_internal_nolock, memalign, mallochook, reallochook):
3915 Omit no-longer-needed casts.
3916 (valloc): Use getpagesize, not __getpagesize.
3917 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3918 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3920 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3922 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3924 Move functions from C to Lisp. Make non-blocking method calls
3925 the default. Implement further D-Bus standard interfaces.
3927 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3928 (QCdbus_request_name_allow_replacement)
3929 (QCdbus_request_name_replace_existing)
3930 (QCdbus_request_name_do_not_queue)
3931 (QCdbus_request_name_reply_primary_owner)
3932 (QCdbus_request_name_reply_in_queue)
3933 (QCdbus_request_name_reply_exists)
3934 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3935 (QCdbus_registered_serial, QCdbus_registered_method)
3936 (QCdbus_registered_signal): New Lisp objects.
3937 (XD_DEBUG_MESSAGE): Use sizeof.
3938 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3939 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3940 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3941 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3942 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3943 (xd_signature, xd_append_arg): Allow float for integer types.
3944 (xd_get_connection_references): New function.
3945 (xd_get_connection_address): Rename from xd_initialize.
3946 Return cached address.
3947 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3948 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3950 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3951 Return number of refcounts.
3952 (Fdbus_get_unique_name): Make stronger parameter check.
3953 (Fdbus_message_internal): New defun.
3954 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3955 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3956 (Fdbus_send_signal, Fdbus_register_service)
3957 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3958 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3959 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3960 (Vdbus_compiled_version, Vdbus_runtime_version)
3961 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3962 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3963 (Vdbus_message_type_signal): New defvars.
3964 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3967 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3969 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3970 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3971 Do not assume ptrdiff_t is the same width as 'int'.
3973 * alloc.c: Handle unusual debugging option combinations.
3974 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3975 since the two debugging options are incompatible.
3976 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3978 (mem_init, mem_insert, mem_insert_fixup):
3979 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3980 (NEED_MEM_INSERT): Remove; no longer needed.
3982 2012-04-22 Leo Liu <sdl.web@gmail.com>
3984 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3986 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3988 * sysdep.c [__FreeBSD__]: Minor cleanups.
3989 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3990 Use Emacs indenting style more consistently. Avoid some casts.
3991 Use 'double' consistently rather than mixing 'float' and 'double'.
3993 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3995 * sysdep.c (list_system_processes, system_process_attributes):
3996 Add implementation for FreeBSD (Bug#5243).
3998 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4000 * lisp.mk (lisp): Update.
4002 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4004 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4005 It is never used otherwise.
4007 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4009 * print.c (print_preprocess): Only check print_depth if print-circle
4011 (print_object): Check for cycles even when print-circle is nil and
4012 print-gensym is t, but only check print_depth if print-circle is nil.
4014 2012-04-20 Chong Yidong <cyd@gnu.org>
4016 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4017 set the status to "failed" and ensure that sentinel is run.
4019 2012-04-20 Glenn Morris <rgm@gnu.org>
4021 * process.c (Fset_process_inherit_coding_system_flag)
4022 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4023 (Fmake_network_process, Fmake_serial_process): Doc fix.
4025 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4027 * xdisp.c (string_buffer_position_lim): Limit starting position to
4029 (set_cursor_from_row): If called for a mode-line or header-line
4030 row, return zero immediately.
4031 (try_cursor_movement): If inside continuation line, don't back up
4032 farther than the first row after the header line, if any.
4033 Don't consider the header-line row as "partially visible", even if
4034 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4036 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4038 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4041 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4042 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4044 configure: new option --enable-gcc-warnings (Bug#11207)
4045 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4046 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4047 (ALL_CFLAGS): Use new macros rather than old.
4048 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4049 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4050 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4051 -Wunused-result, -Wunused-variable. This should go away once
4052 the Emacs and Gnulib regex code is merged.
4053 (xmalloc, xrealloc): Now static.
4055 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4057 * dired.c (Fsystem_groups): Remove unused local.
4059 2012-04-17 Glenn Morris <rgm@gnu.org>
4061 * dired.c (Fsystem_users): Doc fix.
4063 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4065 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4066 (syms_of_dired): Add them.
4068 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4070 Fix minor alloc.c problems found by static checking.
4071 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4072 New extern decls, to avoid calling undeclared functions.
4073 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4074 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4075 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4076 (NEED_MEM_INSERT): New macro.
4077 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4078 Remove one incorrect comment and fix another.
4080 Fix minor ralloc.c problems found by static checking.
4081 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4082 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4083 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4084 (r_alloc_sbrk): Now static.
4086 Improve ralloc.c interface checking.
4087 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4088 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4089 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4090 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4091 [REL_ALLOC]: ... to here, to check interface.
4092 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4093 Remove decls. This fixes an "It stinks!".
4095 * alloc.c (which_symbols): Fix alignment issue / type clash.
4097 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4099 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4100 (struct Lisp_Misc_Any): Likewise.
4101 (struct Lisp_Free): Likewise.
4102 * alloc.c (union aligned_Lisp_Symbol): Define.
4103 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4104 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4105 (union aligned_Lisp_Misc): Define.
4106 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4107 aligned_Lisp_Misc instead of union Lisp_Misc.
4108 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4110 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4112 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4113 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4114 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4115 * s/netbsd.h, s/sol2-6.h:
4116 Remove definition of GC_MARK_STACK, since the default now works.
4117 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4118 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4119 no longer the default.
4120 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4122 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4124 * lread.c (lisp_file_lexically_bound_p):
4125 Fix hang at ";-*-\n" (bug#11238).
4127 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4129 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4130 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4132 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4134 * nsterm.m (constrainFrameRect): Always constrain when there is only
4135 one screen (Bug#10962).
4137 2012-04-13 Ken Brown <kbrown@cornell.edu>
4139 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4141 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4143 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4145 2012-04-11 Daniel Colascione <dancol@dancol.org>
4147 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4148 against is gone. It's better to use vfork now so that when Cygwin
4149 gains a new, working vfork, we use it automatically (bug#10398).
4151 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4153 * window.c (save_window_save): Obey window-point-insertion-type.
4155 2012-04-11 Glenn Morris <rgm@gnu.org>
4157 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4159 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4161 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4163 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4165 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4166 (force_quit_count): New var.
4167 (handle_interrupt): Use it.
4169 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4171 * w32.c (w32_delayed_load): Record the full path of the library
4172 being loaded (bug#10424).
4174 2012-04-09 Glenn Morris <rgm@gnu.org>
4176 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4177 not just in the obarray, before snarfing them. (Bug#11036)
4179 * Makefile.in ($(leimdir)/leim-list.el):
4180 Pass EMACS rather than BUILT_EMACS.
4182 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4184 * process.c (make_process):
4185 * process.h: Add integer `gnutls_handshakes_tried' member to
4188 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4189 Add convenience `GNUTLS_LOG2i' macro.
4191 * gnutls.c (gnutls_log_function2i): Convenience log function.
4192 (emacs_gnutls_read): Use new log functions,
4193 `gnutls_handshakes_tried' process member, and
4194 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4195 attempts per process (connection).
4197 2012-04-09 Chong Yidong <cyd@gnu.org>
4199 * eval.c (Fuser_variable_p, user_variable_p_eh)
4200 (lisp_indirect_variable): Functions deleted.
4201 (Fdefvar): Caller changed.
4203 * callint.c (Finteractive, Fcall_interactively):
4204 * minibuf.c (Fread_variable): Callers changed.
4206 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4208 * xdisp.c (set_cursor_from_row): If the display string appears in
4209 the buffer at position that is closer to point than the position
4210 after the display string, display the cursor on the first glyph of
4211 the display string. Fixes cursor display when a 'display' text
4212 property immediately follows invisible text. (Bug#11094)
4214 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4216 composite.c: use 'double' consistently
4217 * composite.c (get_composition_id): Use 'double' consistently
4218 instead of converting 'float' to 'double' and vice versa; this is
4219 easier to understand and avoids a GCC warning.
4221 2012-04-09 Glenn Morris <rgm@gnu.org>
4223 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4224 preparation for dumping it with emacs. (Bug#4789)
4225 (leimdir): New variable.
4226 ($(leimdir)/leim-list.el): New rule.
4227 (emacs$(EXEEXT)): Depend on leim-list.el.
4229 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4230 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4231 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4233 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4235 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4238 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4240 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4241 Remove unused local variable.
4243 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4245 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4246 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4247 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4248 objects, as mark_maybe_pointer will catch them otherwise.
4249 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4250 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4252 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4254 Fix typo that broke non-Windows builds.
4255 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4257 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4259 Support building on MS-Windows with libxml2.
4261 * makefile.w32-in (OBJ2): Add xml.$(O).
4262 (GLOBAL_SOURCES): Add xml.c.
4263 ($(BLD)/xml.$(O)): New dependency list.
4265 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4266 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4267 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4268 [!WINDOWSNT]: New macros.
4269 (init_libxml2_functions, libxml2_loaded_p): New functions.
4270 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4271 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4272 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4273 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4275 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4276 Call init_libxml2_functions before calling libxml2 functions.
4277 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4279 * emacs.c: Don't include libxml/parser.h.
4280 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4281 xmlCleanupParser directly.
4283 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4285 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4287 * indent.c (Fvertical_motion): If there is a display string at
4288 point, use it.vpos to compute how many lines to backtrack after
4289 move_it_to point. (Bug#11133)
4291 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4293 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4294 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4295 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4296 macros related to unification of CJK characters. For the details,
4297 see the discussion following the message here:
4298 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4300 2012-04-04 Chong Yidong <cyd@gnu.org>
4302 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4304 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4306 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4307 instead of alloca. (Bug#11138)
4309 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4311 * w32menu.c (is_simple_dialog): Properly check lisp types.
4314 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4316 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4317 position we get to after a call to move_it_to fails the
4318 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4319 only if we wind up in a string from display property. (Bug#11063)
4321 * window.c (Fdelete_other_windows_internal): Invalidate the row
4322 and column information about mouse highlight, so that redisplay
4323 restores it after reallocating the glyph matrices. (Bug#7464)
4325 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4326 string comes from a `display' text property, use the buffer
4327 position of that property as if we actually saw that position in
4329 (move_it_by_lines): Remove the assertion that
4330 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4331 violated when there's a before-string at the beginning of a line.
4334 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4336 * xdisp.c (append_space_for_newline): If the default face was
4337 remapped, use the remapped face for the appended newline.
4338 (extend_face_to_end_of_line): Use the remapped default face for
4339 extending the face to the end of the line.
4340 (display_line): Call extend_face_to_end_of_line when the default
4341 face was remapped. (Bug#11068)
4343 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4345 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4347 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4349 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4351 2012-03-27 Glenn Morris <rgm@gnu.org>
4353 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4356 2012-03-26 Kenichi Handa <handa@m17n.org>
4358 * dispextern.h (struct glyph): Fix previous change. Change the
4359 bit length of glyphless.ch to 25 (Bug#11082).
4361 2012-03-26 Chong Yidong <cyd@gnu.org>
4363 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4364 (command_loop_1): Use it; inhibit selection update for
4365 handle-select-window too (Bug#8996).
4367 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4369 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4371 2012-03-25 Kenichi Handa <handa@m17n.org>
4373 * dispextern.h (struct glyph): Change the bit length of
4374 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4376 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4378 * s/ms-w32.h (tzname): Include time.h before redirecting to
4379 _tzname. Fixes the MSVC build. (Bug#9960)
4381 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4383 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4386 * xterm.c (XTread_socket): Only modify handling_signal if
4387 !SYNC_INPUT. (Bug#11080)
4389 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4391 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4392 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4393 when fetching a multibyte character consumes more bytes than
4394 CHAR_BYTES returns, due to unification of CJK characters in
4395 string_char. (Bug#11073)
4397 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4399 * process.c (wait_reading_process_output): Handle pty disconnect
4400 by refraining from sending oneself a SIGCHLD (bug#10933).
4402 2012-03-22 Chong Yidong <cyd@gnu.org>
4404 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4406 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4407 Mark string as coming from a prefix property.
4408 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4409 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4411 2012-03-21 Chong Yidong <cyd@gnu.org>
4413 * xfaces.c (Vface_remapping_alist): Doc fix.
4415 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4417 * w32proc.c (Fw32_set_console_codepage)
4418 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4421 2012-03-20 Chong Yidong <cyd@gnu.org>
4423 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4424 to reflect default non-nil value of redisplay-dont-pause.
4426 2012-03-19 Kenichi Handa <handa@m17n.org>
4428 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4429 it fit in a valid range (Bug#11003).
4431 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4433 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4434 that is not from display property, accept the row as a "cursor
4435 row" if one of the string's character has a non-nil `cursor'
4436 property. Fixes cursor positioning when there are newlines in
4437 overlay strings, e.g. in icomplete.el. (Bug#11035)
4439 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4441 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4443 2012-03-12 Chong Yidong <cyd@gnu.org>
4445 * eval.c (inhibit_lisp_code): Rename from
4446 inhibit_window_configuration_change_hook; move from window.c.
4448 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4449 * window.c (run_window_configuration_change_hook)
4450 (syms_of_window): Callers changed.
4452 2012-03-11 Chong Yidong <cyd@gnu.org>
4454 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4456 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4458 2012-03-10 Chong Yidong <cyd@gnu.org>
4460 * frame.c (other_visible_frames): Don't assume the selected frame
4461 is visible (Bug#10955).
4463 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4465 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4467 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4469 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4470 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4473 2012-03-03 Glenn Morris <rgm@gnu.org>
4475 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4477 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4479 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4480 position past the first glyph_row that ends at ZV. (Bug#10902)
4481 (redisplay_window, next_element_from_string): Fix typos in
4483 (redisplay_window): Pass to move_it_vertically the margin in
4484 pixels, not in screen lines.
4486 2012-03-02 Glenn Morris <rgm@gnu.org>
4488 * buffer.c (buffer-list-update-hook): Doc fix.
4490 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4492 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4493 push_it before setting up the iterator for the first overlay
4494 string, even if we have an empty string loaded.
4495 (next_overlay_string): If there's an empty string on the iterator
4496 stack, pop the stack. (Bug#10903)
4498 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4500 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4501 Suggested by Stefan Monnier in
4502 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4503 * alloc.c (widen_to_Lisp_Object): New static function.
4504 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4505 and widening them to Lisp_Objects. This would work even if
4506 USE_LSB_TAG is defined and wide integers are used, which might
4507 happen in a future version of Emacs.
4509 2012-02-25 Chong Yidong <cyd@gnu.org>
4511 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4514 * xselect.c (Fx_selection_exists_p): Doc fix.
4515 (x_clipboard_manager_save_all): Print an informative message
4516 before saving to clipboard manager.
4518 2012-02-24 Chong Yidong <cyd@gnu.org>
4520 * keyboard.c (process_special_events): Handle all X selection
4521 requests in kbd_buffer, not just the next one (Bug#8869).
4523 2012-02-23 Chong Yidong <cyd@gnu.org>
4525 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4526 call when setting menu-bar-lines and tool-bar-lines parameters.
4527 (unwind_create_frame_1): New helper function.
4529 * window.c (inhibit_window_configuration_change_hook): New var.
4530 (run_window_configuration_change_hook): Obey it.
4531 (syms_of_window): Initialize it.
4533 2012-02-22 Chong Yidong <cyd@gnu.org>
4535 * xterm.c (x_draw_image_relief): Add missing type check for
4536 Vtool_bar_button_margin (Bug#10743).
4538 2012-02-21 Chong Yidong <cyd@gnu.org>
4540 * fileio.c (Vfile_name_handler_alist): Doc fix.
4542 * buffer.c (Fget_file_buffer): Protect against invalid file
4543 handler return value.
4545 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4547 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4548 when computing $valmask.
4550 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4551 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4552 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4553 It's useless in that case, and it can cause problems on hosts
4554 that allocate halves of EMACS_INT values separately.
4555 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4556 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4557 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4558 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4559 it avoids undefined behavior on hosts where shifting right by more
4560 than the word width has undefined behavior.
4562 2012-02-19 Chong Yidong <cyd@gnu.org>
4564 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4565 (Funhandled_file_name_directory, Ffile_name_as_directory)
4566 (Fdirectory_file_name, Fexpand_file_name)
4567 (Fsubstitute_in_file_name): Protect against invalid file handler
4568 return values (Bug#10845).
4570 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4572 * .gdbinit (pitx): Fix incorrect references to fields of the
4575 2012-02-17 Chong Yidong <cyd@gnu.org>
4577 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4579 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4581 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4582 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4584 2012-02-15 Chong Yidong <cyd@gnu.org>
4586 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4587 marked as special. Also, starting docstrings with * is obsolete.
4589 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4591 * gnutls.c (emacs_gnutls_write): Fix last change.
4593 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4595 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4598 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4600 * keymap.c (Fsingle_key_description): Handle char ranges.
4602 2012-02-12 Chong Yidong <cyd@gnu.org>
4604 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4605 as that creates a dangerous corner case.
4607 * window.c (Fdelete_window_internal): Invalidate the mouse
4608 highlight (Bug#9904).
4610 2012-02-12 Glenn Morris <rgm@gnu.org>
4612 * xselect.c (Fx_own_selection_internal)
4613 (Fx_get_selection_internal, Fx_disown_selection_internal)
4614 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4615 * nsselect.m (Fx_own_selection_internal)
4616 (Fx_disown_selection_internal, Fx_selection_exists_p)
4617 (Fx_selection_owner_p, Fx_get_selection_internal):
4618 Sync docs and argument specs with the xselect.c versions.
4620 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4622 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4624 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4626 * w32select.c (Fx_selection_exists_p): Sync doc string and
4627 argument list with xselect.c. (Bug#10783)
4629 * w16select.c (Fx_selection_exists_p): Sync doc string and
4630 argument list with xselect.c. (Bug#10783)
4632 2012-02-10 Glenn Morris <rgm@gnu.org>
4634 * fns.c (Fsecure_hash): Doc fix.
4636 2012-02-09 Kenichi Handa <handa@m17n.org>
4638 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4640 2012-02-07 Chong Yidong <cyd@gnu.org>
4642 * buffer.c (Fbuffer_local_variables)
4643 (buffer_lisp_local_variables): Handle unbound vars correctly;
4644 don't let Qunbound leak into Lisp.
4646 2012-02-07 Glenn Morris <rgm@gnu.org>
4648 * image.c (Fimagemagick_types): Doc fix.
4650 * image.c (imagemagick-render-type): Change it from a lisp object
4651 to an integer. Move the doc here from the lisp manual.
4652 Treat all values not equal to 0 the same.
4654 2012-02-06 Chong Yidong <cyd@gnu.org>
4656 * doc.c (store_function_docstring): Avoid applying docstring of
4657 alias to base function (Bug#2603).
4659 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4661 * .gdbinit (pp1, pv1): Remove redundant defines.
4664 2012-02-04 Chong Yidong <cyd@gnu.org>
4666 * nsterm.m: Declare a global (Bug#10694).
4668 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4670 * w32.c (get_emacs_configuration_options):
4671 Include --enable-checking, if specified, in the return value.
4673 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4675 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4676 after rounding frame sizes. (Bug#9723)
4678 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4680 * keyboard.c (adjust_point_for_property): Don't position point
4681 before BEGV. (Bug#10696)
4683 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4685 Handle overflow when computing char display width (Bug#9496).
4686 * character.c (char_width): Return EMACS_INT, not int.
4687 (char_width, c_string_width): Check for overflow when
4688 computing the width; this is possible now that individual
4689 characters can have unbounded width. Problem introduced
4690 by merge from Emacs 23 on 2012-01-19.
4692 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4694 * dbusbind.c (Fdbus_register_method): Mention the return value
4695 :ignore in the docstring.
4697 2012-02-02 Glenn Morris <rgm@gnu.org>
4699 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4701 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4702 Unconditionally set to t. (Bug#10673)
4703 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4704 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4705 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4707 2012-02-02 Kenichi Handa <handa@m17n.org>
4709 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4710 0, do not call append_composite_glyph.
4712 2012-02-02 Kenichi Handa <handa@m17n.org>
4714 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4716 (x_produce_glyphs): If the component of a composition is a null
4717 string, set it->pixel_width to 1 to avoid zero-width glyph.
4719 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4721 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4722 first 2 arguments are identical. This makes inserting large
4723 output from a subprocess an order of magnitude faster on
4724 MS-Windows, where all sbrk'ed memory is always contiguous.
4726 2012-01-31 Glenn Morris <rgm@gnu.org>
4728 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4729 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4730 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4732 2012-01-29 Glenn Morris <rgm@gnu.org>
4734 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4736 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4738 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4740 2012-01-28 Chong Yidong <cyd@gnu.org>
4742 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4744 2012-01-26 Chong Yidong <cyd@gnu.org>
4746 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4748 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4749 repeat counts (Bug#10507).
4751 2012-01-26 Glenn Morris <rgm@gnu.org>
4753 * lread.c (syms_of_lread): Doc fix.
4755 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4757 * coding.c (encode_designation_at_bol): Change return value to
4760 2012-01-25 Chong Yidong <cyd@gnu.org>
4762 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4764 2012-01-21 Chong Yidong <cyd@gnu.org>
4766 * floatfns.c (Fcopysign): Make the second argument non-optional,
4767 since nil is not allowed anyway.
4769 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4771 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4772 (send_process): Likewise.
4774 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4776 * window.c (save_window_save, Fcurrent_window_configuration)
4777 (Vwindow_persistent_parameters): Do not use Qstate.
4778 Rewrite doc-strings.
4780 2012-01-19 Kenichi Handa <handa@m17n.org>
4782 * character.c (char_width): New function.
4783 (Fchar_width, c_string_width, lisp_string_width):
4784 Use char_width (Bug#9496).
4786 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4788 * window.c (Vwindow_persistent_parameters): New variable.
4789 (Fset_window_configuration, save_window_save): Handle persistent
4792 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4794 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4795 thrashing the stack of the thread. (Bug#9087)
4797 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4799 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4801 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4803 * xdisp.c (rows_from_pos_range): Handle the case where the
4804 highlight ends on a newline. (Bug#10464)
4805 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4806 he end column for display of highlight that ends on a newline
4809 2012-01-11 Glenn Morris <rgm@gnu.org>
4811 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4812 from load-path also when installation-directory is nil. (Bug#10208)
4814 2012-01-10 Glenn Morris <rgm@gnu.org>
4816 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4818 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4819 Update template values to be closer to their typical values these days.
4821 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4823 * xdisp.c (rows_from_pos_range): Accept additional argument
4824 DISP_STRING, and accept any glyph in a row whose object is that
4825 string as eligible for mouse highlight. Fixes mouse highlight of
4826 display strings from overlays. (Bug#10464)
4828 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4830 emacs: fix an auto-save permissions race condition (Bug#10400)
4831 * fileio.c (auto_saving_dir_umask): New static var.
4832 (Fmake_directory_internal): Use it.
4833 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4834 creating the directory. The old code temporarily assigns
4835 too-generous permissions to the directory.
4836 (do_auto_save_eh): Clear it.
4837 (Fdo_auto_save): Catch all errors, not just file errors, so
4838 that the var is always cleared.
4840 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4842 * search.c (scan_buffer): Pass character positions to
4843 know_region_cache, not byte positions. (Bug#6540)
4845 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4847 * w32.c (sys_rename): Report EXDEV when rename of a directory
4848 fails because the target is on another logical disk. (Bug#10284)
4850 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4852 * xterm.c (x_embed_request_focus): New function.
4854 * xterm.h: Add prototype.
4856 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4858 2012-01-05 Glenn Morris <rgm@gnu.org>
4860 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4862 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4864 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4865 Load gnutls_transport_set_lowat only if GnuTLS version is below
4867 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4868 GnuTLS versions below 2.11.1.
4870 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4872 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4873 to the doc string advising against its use for altering the way
4874 windows are scrolled.
4876 2011-12-28 Kenichi Handa <handa@m17n.org>
4878 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4879 coding-system ASCII compatible only when it does not produce BOM
4880 on encoding (Bug#10383).
4882 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4884 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4886 (create_and_show_popup_menu): Always use menu_position_func for
4889 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4891 * callint.c (Fcall_interactively): Don't truncate prompt string.
4893 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4895 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4896 property that ends at ZV, so that the bidi iteration could be
4897 resumed from there (after widening). (Bug#10360)
4899 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4901 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4903 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4905 * nsterm.m (x_free_frame_resources):
4906 Release f->output_data.ns->miniimage.
4907 (ns_index_color): Fix indentation. Do not retain
4908 color_table->colors[i].
4910 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4913 * nsfns.m (x_set_background_color): Assign return value from
4914 ns_index_color to face-background instead of NSColor*.
4915 (ns_implicitly_set_icon_type): Fix indentation.
4916 Change assignment in for loop to comparison.
4918 * emacs.c (ns_pool): New variable.
4919 (main): Assign ns_pool.
4920 (Fkill_emacs): Call ns_release_autorelease_pool.
4922 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4923 autorelease fdesc, release fdAttrs and tdict.
4924 (ns_get_covering_families): Release charset.
4925 (ns_findfonts): Release NSFontDescriptor created with new.
4926 (ns_uni_to_glyphs): Fix indentation.
4927 (setString): Release attrStr before assigning new value.
4929 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4931 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4933 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4934 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4936 2011-12-18 David Reitter <reitter@cmu.edu>
4938 * nsterm.m (ns_term_init): Subscribe for notifications
4939 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4940 to method trackingNotification in EmacsMenu.
4942 * nsmenu.m (trackingMenu): New variable.
4943 (trackingNotification): New method (from Aquamacs).
4944 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4945 from Aquamacs (Bug#7030).
4947 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4949 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4950 (symbol_to_nsstring): Fix indentation.
4951 (ns_symbol_to_pb): New function.
4952 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4953 (Fns_rotate_cut_buffers_internal): Remove.
4954 (Fns_store_selection_internal): Rename from
4955 Fns_store_cut_buffer_internal.
4956 (ns_get_foreign_selection, Fx_own_selection_internal)
4957 (Fx_disown_selection_internal, Fx_selection_exists_p)
4958 (Fns_get_selection_internal, Fns_store_selection_internal):
4959 Use ns_symbol_to_pb and check if return value is nil.
4960 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4961 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4962 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4963 renamed to Sns_store_selection_internal.
4964 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4965 and remove this function.
4966 (ns_handle_selection_clear): Remove, never used.
4967 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4970 2011-12-17 Ken Brown <kbrown@cornell.edu>
4972 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4973 GID is unknown (Bug#10257).
4975 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4977 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4978 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4979 which caused a build failure on GNU/Linux IA-64. This problem was
4980 introduced by my 2011-10-07 patch.
4982 2011-12-15 Juri Linkov <juri@jurta.org>
4984 * image.c (imagemagick_error): New function. (Bug#10112)
4985 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4986 Use `imagemagick_error' where ImageMagick functions return
4988 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4991 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4993 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4994 fill background (Bug#8992).
4996 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4998 * window.c (Vwindow_combination_resize)
4999 (Vwindow_combination_limit): Use t instead of non-nil in
5001 (Vrecenter_redisplay): Add first sentence of doc-string on
5003 (Frecenter): Fix doc-string typo.
5005 2011-12-11 Kenichi Handa <handa@m17n.org>
5007 * coding.c (Funencodable_char_position): Pay attention to the
5008 buffer text relocation (Bug#9389).
5010 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5012 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5013 gtk_init (Bug#10100).
5015 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5017 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5018 IT->string is nil. (Bug#10263)
5020 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5022 * nsterm.h (x_free_frame_resources): Declare.
5024 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5025 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5027 * nsterm.h (ns_get_defaults_value): Declare.
5029 * nsterm.m (ns_default): Call ns_get_defaults_value.
5031 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5033 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5036 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5038 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5039 that where the value of an _OBJC_* symbol points to is in the .bss
5040 section (Bug#10240).
5042 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5044 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5045 after the loop to call ccl_driver at least once (Bug#8619).
5047 2011-12-08 Kenichi Handa <handa@m17n.org>
5049 * ftfont.c (get_adstyle_property): Fix previous change
5052 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5054 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5055 dirs from the default value of EMACSLOADPATH (bug#10208).
5057 2011-12-07 Glenn Morris <rgm@gnu.org>
5059 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5060 installation and source directories as well. (Bug#10208)
5062 2011-12-06 Chong Yidong <cyd@gnu.org>
5064 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5066 2011-12-06 Glenn Morris <rgm@gnu.org>
5068 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5069 as an error, not just -1. (Bug#10217)
5071 2011-12-05 Chong Yidong <cyd@gnu.org>
5073 * keyboard.c (process_special_events): New function.
5074 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5076 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5078 * coding.c (encode_designation_at_bol): Don't use uninitialized
5079 local variable (Bug#9318).
5081 2011-12-05 Kenichi Handa <handa@m17n.org>
5083 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5084 return Qnil (Bug#8046, Bug#10193).
5086 2011-12-05 Kenichi Handa <handa@m17n.org>
5088 * coding.c (encode_designation_at_bol): New args charbuf_end and
5089 dst. Return the number of produced bytes. Callers changed.
5090 (coding_set_source): Return how many bytes coding->source was
5092 (coding_set_destination): Return how many bytes
5093 coding->destination was relocated.
5094 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5095 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5097 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5099 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5100 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5103 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5105 The following changes are to fix Bug#9318.
5107 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5108 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5109 (encode_coding_iso_2022, encode_coding_sjis)
5110 (encode_coding_big5, encode_coding_charset): Use the above macros.
5112 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5114 * lisp.h (process_quit_flag): Fix external declaration.
5116 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5118 Don't macro-inline non-performance-critical code.
5119 * eval.c (process_quit_flag): New function.
5120 * lisp.h (QUIT): Use it.
5122 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5124 * nsfns.m (get_geometry_from_preferences): New function.
5125 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5127 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5129 * emacs.c (Qkill_emacs): Define.
5130 (syms_of_emacs): Initialize it.
5131 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5132 Qquit_flag to `kill-emacs' instead.
5133 (quit_throw_to_read_char): Add parameter `from_signal'.
5134 All callers changed. Call Fkill_emacs if requested and safe.
5135 * lisp.h (QUIT): Call Fkill_emacs if requested.
5137 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5139 * widget.c (update_wm_hints): Return if wmshell is null.
5140 (widget_update_wm_size_hints): New function.
5142 * widget.h (widget_update_wm_size_hints): Declare.
5144 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5145 widget_update_wm_size_hints (Bug#10104).
5147 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5149 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5150 before a newline, prepare the bidi iterator for consuming the
5151 newline, and keep the current paragraph direction. (Bug#10183)
5152 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5154 2011-12-02 Juri Linkov <juri@jurta.org>
5156 * search.c (Fword_search_regexp): New Lisp function created from
5157 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5158 (Fword_search_backward, Fword_search_forward)
5159 (Fword_search_backward_lax, Fword_search_forward_lax):
5160 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5161 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5163 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5165 * fileio.c (Finsert_file_contents): Move after-change-function call
5166 to before the "handled:" label, since all "goto handled" appear in
5167 cases where the *-change-functions have already been properly called
5170 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5172 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5173 waiting for input. (Bug#10169)
5175 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5177 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5178 verifies glyph row's hash code--we have just reallocated the
5179 glyphs, so their contents can be complete garbage. (Bug#10164)
5181 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5183 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5185 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5187 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5188 attributes are tested _before_ calling verify_row_hash, to protect
5189 against GCC re-ordering of the tests. (Bug#10164)
5191 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5193 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5195 * xterm.c (handle_one_xevent): Only set async_visible and friends
5196 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5197 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5198 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5200 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5202 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5203 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5204 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5205 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5206 All uses changed to use GCPRO1 etc.
5207 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5208 Revert to old implementation (i.e., before 2011-03-11).
5210 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5212 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5213 of scroll runs so as to avoid assigning disabled bogus rows and
5214 unnecessary graphics copy operations.
5216 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5218 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5219 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5220 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5221 (malloc, free, realloc, calloc): Redirect to e_* only when
5224 * lisp.h (GCTYPEBITS): Move before first use.
5225 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5226 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5227 this macro definition.
5229 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5232 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5234 * gtkutil.c (xg_create_frame_widgets):
5235 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5236 present with Gtk+ 2.0.
5238 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5240 * fileio.c (Finsert_file_contents): Undo previous change; see
5241 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5243 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5245 Rename locals to avoid shadowing.
5246 * fileio.c (Finsert_file_contents):
5247 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5248 * process.c (wait_reading_process_output):
5249 Rename inner 'proc' to 'p' to avoid shadowing.
5250 Indent for consistency with usual Emacs style.
5252 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5254 * xdisp.c (redisplay_window): If cursor row is not fully visible
5255 after recentering, and scroll-conservatively is set to a large
5256 number, scroll window by a few more lines to make the cursor fully
5257 visible and out of scroll-margin. (Bug#10105)
5258 (start_display): Don't move to the next line if the display should
5259 start at a newline that is part of a display vector or an overlay
5262 2011-11-24 Juri Linkov <juri@jurta.org>
5264 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5265 after the `MagickPingImage' call. (Bug#10112)
5267 2011-11-23 Chong Yidong <cyd@gnu.org>
5269 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5271 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5273 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5274 making another buffer current. (Bug#10114)
5276 2011-11-23 Glenn Morris <rgm@gnu.org>
5278 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5280 2011-11-23 Chong Yidong <cyd@gnu.org>
5282 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5283 using it (Bug#5984).
5285 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5287 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5288 and header-lines, as they don't have one computed for them.
5291 * .gdbinit (prow): Make displayed values more self-explaining.
5292 Add row's hash code.
5294 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5296 * process.c (wait_reading_process_output): Fix asynchrounous
5297 GnuTLS socket handling on some versions of the GnuTLS library.
5298 (wait_reading_process_output): Add comment and URL.
5300 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5302 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5304 2011-11-21 Chong Yidong <cyd@gnu.org>
5306 * window.c (Fnext_window, Fprevious_window): Doc fix.
5308 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5310 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5312 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5314 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5316 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5318 * window.c (Fset_window_combination_limit): Rename argument
5320 (Vwindow_combination_limit): Remove "status" from doc-string.
5322 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5324 * m/ibms390.h: Remove.
5325 * m/ibms390x.h: Don't include "ibms390.h".
5327 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5329 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5330 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5332 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5334 * casetab.c (Fset_case_table):
5335 * charset.c (Fcharset_after): Fix typos.
5337 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5339 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5340 Otherwise, valgrind does not work on some platforms.
5341 Problem reported by Andreas Schwab in
5342 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5343 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5344 is set, removing the need for VIRT_ADDRESS_VARIES.
5345 (PURE_P): Use a more-efficient implementation that needs just one
5346 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5347 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5348 to 4 (xorl, subq, cmpq, setbe).
5349 * alloc.c (pure): Always extern now, since that's the
5350 VIRT_ADDR_VARIES behavior.
5351 (PURE_POINTER_P): Use a single comparison, not two, for
5352 consistency with the new puresize.h.
5353 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5354 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5355 Remove VIRT_ADDR_VARIES no longer needed.
5357 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5359 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5360 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5361 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5362 behave as if the cursor position were at the window margin.
5364 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5365 and the cursor position is out of bounds, behave as if the cursor
5366 position were at the window margin. (Bug#10075)
5368 2011-11-18 Chong Yidong <cyd@gnu.org>
5370 * window.c (Fwindow_combination_limit): Make first argument
5371 non-optional, since it is meaningless for live windows like the
5374 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5376 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5378 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5380 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5381 (graft_intervals_into_buffer): Simplify.
5383 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5385 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5386 hash values of the two rows.
5387 (copy_row_except_pointers): Preserve the used[] arrays and the
5388 hash values of the two rows. (Bug#10035)
5389 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5391 * xdisp.c (row_hash): New function, body extracted from
5392 compute_line_metrics.
5393 (compute_line_metrics): Call row_hash, instead of computing the
5396 * dispnew.c (verify_row_hash): Call row_hash for computing the
5397 hash code of a row, instead of duplicating code from xdisp.c.
5399 * dispextern.h (row_hash): Add prototype.
5401 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5403 * frame.c (delete_frame): Don't delete the terminal when the last
5404 X frame is closed if emacs is built with GTK toolkit.
5406 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5408 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5410 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5412 * window.c (Vwindow_splits): Rename to
5413 Vwindow_combination_resize. Suggested by Juri Linkov.
5414 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5417 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5419 * nsfns.m (Fns_font_name):
5420 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5422 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5424 * window.h (window): Rename slot "nest" to "combination_limit".
5425 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5426 (Fset_window_nest): Rename to Fset_window_combination_limit.
5427 (Vwindow_nest): Rename to Vwindow_combination_limit.
5428 (recombine_windows, make_parent_window, make_window)
5429 (Fsplit_window_internal, saved_window)
5430 (Fset_window_configuration, save_window_save): Rename all
5431 occurrences of window_nest to window_combination_limit.
5433 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5435 * image.c (imagemagick_load_image): Fix typo.
5437 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5439 * xdisp.c (display_line): Move the call to
5440 highlight_trailing_whitespace before the call to
5441 compute_line_metrics, since the latter needs to see the final
5442 faces of all the glyphs to compute ROW's hash value.
5443 Fixes assertion violations in row_equal_p. (Bug#10035)
5445 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5447 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5448 just return (bug#10044).
5450 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5452 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5453 with user-defined heap size. Bump the default size of the temacs
5454 heap to 27MB, to avoid memory warning when running temacs.
5455 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5457 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5458 current_matrix and desired_matrix. (Bug#9990)
5459 (verify_row_hash) [XASSERTS]: New function.
5460 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5461 that the hash value of glyph rows is correct.
5463 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5465 * window.h (window): Remove splits slot.
5466 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5467 (Fdelete_other_windows_internal, make_parent_window)
5468 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5469 (Fset_window_configuration, save_window_save): Don't deal with
5470 split status of windows.
5471 (saved_window): Remove splits slot.
5472 (Vwindow_splits): Rewrite doc-string.
5474 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5476 * xfns.c (unwind_create_frame):
5477 * nsfns.m (unwind_create_frame):
5478 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5479 Vframe_list (Bug#9999).
5481 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5483 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5485 2011-11-11 Kenichi Handa <handa@m17n.org>
5487 * callproc.c (Fcall_process): Set the member dst_multibyte of
5490 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5492 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5493 avoid a crash (bug#9496).
5495 2011-11-09 Chong Yidong <cyd@gnu.org>
5497 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5498 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5500 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5502 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5504 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5506 Avoid some portability problems by eschewing 'extern inline' functions.
5507 The trivial performance wins aren't worth the portability hassles; see
5508 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5510 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5511 (window_box_width, window_box_left, window_box_left_offset)
5512 (window_box_right, window_box_right_offset): Undo previous change,
5513 by removing the "extern"s.
5514 * intervals.c (adjust_intervals_for_insertion)
5515 (adjust_intervals_for_deletion): Undo previous change,
5516 making these static again.
5517 (offset_intervals, temp_set_point_both, temp_set_point)
5518 (copy_intervals_to_string): No longer inline.
5519 * xdisp.c (window_text_bottom_y, window_box_width)
5520 (window_box_height, window_box_left_offset)
5521 (window_box_right_offset, window_box_left, window_box_right)
5522 (window_box): No longer inline.
5524 2011-11-08 Chong Yidong <cyd@gnu.org>
5526 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5527 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5528 Signal an error if not a live window.
5529 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5530 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5532 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5534 * lisp.h (syms_of_abbrev): Remove declaration.
5535 Reported by CHENG Gao <chenggao@royau.me>.
5537 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5539 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5540 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5541 of temacs in GUI mode.
5543 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5545 * window.h: Declare delete_all_child_windows instead of
5546 delete_all_subwindows.
5547 * window.c (Fwindow_nest, Fset_window_nest)
5548 (Fset_window_new_total, Fset_window_new_normal)
5549 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5550 (delete_all_subwindows): Rename to delete_all_child_windows.
5551 (Fdelete_other_windows_internal, Fset_window_configuration):
5552 Call delete_all_child_windows instead of delete_all_subwindows.
5553 * frame.c (delete_frame): Call delete_all_child_windows instead
5554 of delete_all_subwindows.
5556 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5558 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5559 This is also needed for porting to any host where GC_MARK_STACK is
5560 not GC_MAKE_GCPROS_NOOPS.
5561 (which_symbols): Use it.
5563 2011-11-07 Kenichi Handa <handa@m17n.org>
5565 * coding.c (coding_set_destination): Check coding->src_pos only
5566 when coding->src_object is a buffer (bug#9910).
5568 * process.c (send_process): Set the member src_multibyte of coding
5569 to 0 (bug#9911) when sending a unibyte text.
5571 * callproc.c (Fcall_process): Set the member src_multibyte of
5572 process_coding to 0 (bug#9912).
5574 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5576 * xmenu.c (cleanup_widget_value_tree): New function.
5577 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5578 calling free_menubar_widget_value_tree directly (Bug#9830).
5580 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5582 Fix some portability problems with 'inline'.
5583 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5584 (window_box_width, window_box_left, window_box_left_offset)
5585 (window_box_right, window_box_right_offset): Declare extern.
5586 Otherwise, these inline functions do not conform to C99 and
5587 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5588 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5589 * intervals.c (adjust_intervals_for_insertion)
5590 (adjust_intervals_for_deletion): Now extern, because otherwise the
5591 extern inline functions 'offset_intervals' couldn't refer to it.
5592 (static_offset_intervals): Remove.
5593 (offset_intervals): Rewrite using the old contents of
5594 static_offset_intervals. The old version didn't conform to C99
5595 because an extern inline function contained a reference to an
5596 identifier with static linkage.
5598 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5600 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5603 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5605 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5606 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5607 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5608 return Qleft_to_right.
5610 2011-11-06 Chong Yidong <cyd@gnu.org>
5612 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5613 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5614 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5615 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5616 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5617 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5618 (Fwindow_vscroll): Doc fix.
5619 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5620 argument, since it makes no sense to pass a live window and for
5621 consistency with window-child.
5623 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5625 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5628 2011-11-05 Jason Rumney <jasonr@gnu.org>
5630 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5631 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5633 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5634 bitwise arithmetic preventing use of unicode-sip and non-truetype
5637 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5639 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5642 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5643 initialization code to keep similarity to xfns.c after changes
5646 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5648 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5649 (unwind_create_frame): New function (Bug#9943).
5650 (Fx_create_frame): Restructure code to be more similar to the one in
5651 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5652 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5653 Move terminal->reference_count++ just before making the frame official
5656 * nsterm.m (x_free_frame_resources): New function.
5657 (x_destroy_window): Move code to x_free_frame_resources.
5659 * xfns.c (unwind_create_frame): Fix comment.
5660 (Fx_create_frame, x_create_tip_frame):
5661 Move terminal->reference_count++ just before making the frame
5662 official. Move initialization of image_cache_refcount and
5663 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5665 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5667 Support MSVC build with newer versions of Visual Studio.
5668 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5669 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5672 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5673 which are not supported by MSVC.
5674 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5675 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5677 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5679 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5681 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5683 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5685 Support MSVC build with newer versions of Visual Studio.
5686 * w32.c: Don't include w32api.h for MSVC.
5687 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5689 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5690 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5691 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5692 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5694 (alloca) [_MSC_VER]: Define to _alloca.
5696 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5698 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5700 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5702 * xdisp.c (note_mouse_highlight): If either of
5703 previous/next-single-property-change returns nil, treat that as
5704 the beginning or the end of the buffer. (Bug#9955)
5706 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5708 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5709 label is not null (Bug#9951).
5710 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5713 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5715 * window.c (Fwindow_body_size): Mention in the doc string that the
5716 return value is in frame's canonical units. (Bug#9949)
5718 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5720 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5722 * w32fns.c (unwind_create_frame): If needed, free the glyph
5723 matrices of the partially constructed frame. (Bug#9943)
5724 * xfns.c (unwind_create_frame): Likewise.
5726 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5728 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5729 Don't stop backward scan on the continuation glyph, even though
5730 its CHARPOS is positive.
5731 (mouse_face_from_buffer_pos, note_mouse_highlight):
5732 Rename cover_string to disp_string.
5734 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5736 * window.c (temp_output_buffer_show): Don't use
5737 Vtemp_buffer_show_specifiers.
5738 (Vtemp_buffer_show_specifiers): Remove unused variable.
5740 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5742 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5743 past the beginning of the current glyph matrix.
5745 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5747 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5748 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5749 HAVE_GTK3 (Bug#9869).
5751 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5752 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5754 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5756 * xterm.c: Declare x_handle_net_wm_state to return int.
5757 (handle_one_xevent): Check if we are iconified but don't have
5758 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5759 (get_current_wm_state): Return non-zero if not hidden,
5760 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5761 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5762 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5763 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5765 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5767 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5768 so that this new function doesn't get optimized away by a
5769 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5771 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5773 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5775 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5777 Fix the `xbytecode' command.
5778 * .gdbinit (xprintbytestr): New command.
5779 (xwhichsymbols): Rename from `which'; all callers changed.
5780 (xbytecode): Print the byte-code string as well.
5782 2011-10-29 Kim Storm <storm@cua.dk>
5784 * alloc.c (which_symbols): New function.
5786 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5788 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5791 2011-10-29 Glenn Morris <rgm@gnu.org>
5793 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5794 Not clear what it was for, and it causes various bugs. (Bug#9839)
5796 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5798 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5799 possible random value that matches one of those tested as
5800 condition to clear the mouse face.
5802 2011-10-28 Chong Yidong <cyd@gnu.org>
5804 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5806 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5808 * window.c (make_window): Initialize phys_cursor_on_p.
5810 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5812 * lisp.h (struct Lisp_Symbol): Update comments.
5814 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5816 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5818 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5820 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5821 <oslsachem@gmail.com> for helping to debug this.
5823 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5824 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5825 (g_b_init_get_glyph_outline_w): New static variables.
5826 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5827 (GetGlyphOutlineW_Proc): New typedefs.
5828 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5829 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5831 (w32font_open_internal, compute_metrics):
5832 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5833 instead of calling the "wide" APIs directly.
5835 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5837 * w32.h (syms_of_w32font): Add prototype.
5839 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5841 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5842 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5843 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5844 (Fmove_to_window_line): Doc fix.
5846 2011-10-27 Chong Yidong <cyd@gnu.org>
5848 * process.c (make_process): Set gnutls_state to NULL.
5850 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5851 non-NULL, regardless of GNUTLS_INITSTAGE.
5852 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5853 an error. Set process slots as soon as we allocate them.
5855 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5857 2011-10-27 Chong Yidong <cyd@gnu.org>
5859 * gnutls.c (emacs_gnutls_deinit): New function.
5860 Deallocate credentials structures as well as calling gnutls_deinit.
5861 (Fgnutls_deinit, Fgnutls_boot): Use it.
5863 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5864 (deactivate_process): Call emacs_gnutls_deinit.
5866 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5868 * image.c (x_create_x_image_and_pixmap):
5869 * w32.c (sys_rename, w32_delayed_load):
5870 * w32font.c (fill_in_logfont):
5871 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5873 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5875 * w32fns.c (w32_default_color_map): New function,
5876 extracted from Fw32_default_color_map.
5877 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5879 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5881 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5883 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5885 * keyboard.c (test_undefined): New function (bug#9751).
5886 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5888 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5890 * sysdep.c (init_sys_modes): Fix the check for the controlling
5891 terminal (Bug#6649).
5893 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5895 * dispextern.h (struct bidi_it): New member next_en_type.
5897 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5898 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5899 current character, check also for next_en_type being WEAK_EN.
5900 (bidi_resolve_weak): Don't enter the expensive loop if the current
5901 position is before next_en_pos. Record the bidi type of the first
5902 non-ET, non-BN character we find, in addition to its position.
5903 (bidi_level_of_next_char): Invalidate next_en_type when
5904 next_en_pos is over-stepped.
5906 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5908 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5909 * editfns.c: Rewrite current-time-zone so that it invokes
5910 the equivalent of (format-time-string "%Z") to get the time zone name.
5911 This fixes a bug when the time zone name contains characters that
5912 need converting from the system time locale to Emacs internal format.
5913 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5914 that patch fixed format-time-string to do the conversion, but
5915 I forgot to fix current-time-zone.
5916 (format_time_string): New function, containing most of
5917 what Fformat_time_string used to contain.
5918 (Fformat_time_string): Rewrite in terms of format_time_string.
5919 This doesn't change this function's behavior.
5920 (current-time-zone): Rewrite to use format_time_string.
5921 This fixes the bug reported by Michael Schierl in
5922 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5923 Jason Rumney's 2007-06-07 change worked around this bug, but
5925 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5927 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5929 * xdisp.c (start_display): If the character at POS is displayed
5930 via a display vector, reset IT->current.dpvec_index to zero.
5931 (try_window_reusing_current_matrix): If a line ends in a display
5932 vector or the next line starts in a display vector, continue
5933 redrawing the window even though the character position of
5934 start_row was reached.
5937 2011-10-18 Chong Yidong <cyd@gnu.org>
5939 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5940 with nobreak-char-display too.
5942 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5944 Fix part 3 of bug#9771.
5945 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5946 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5947 non-neutral characters if the current character is a paragraph
5948 separator (a.k.a. Newline). This avoids running the same
5949 expensive loop twice, once when we consume the preceding newline
5950 and the other time when the line actually needs to be displayed.
5951 Avoid the loop when we see neutrals on the base embedding level
5952 following a character whose directionality is the same as the
5953 paragraph's. This avoids running the expensive loop when a line
5954 ends in a long sequence of neutrals, like control characters.
5955 Add assertion against STRONG_AL type. Slightly rearrange code
5956 that determines the type of a neutral given the first non-neutral
5958 (bidi_level_of_next_char): Set next_en_pos to zero when
5959 invalidating its info.
5961 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5963 * xdisp.c (push_display_prop): Determine whether to record string
5964 or buffer position by IT->string, not by IT->method. Allow
5965 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5966 (move_it_vertically_backward): Don't look for character position
5967 immediately after the newline when in a continuation line.
5970 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5972 * window.c (coordinates_in_window): Rewrite and delabelize
5973 vertical border check. (Bug#5357) (Bug#9618)
5975 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5977 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5978 errors in XSetWindowBorder (bug#9310).
5980 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5982 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5983 avoid crash when xmalloc overrun checking is enabled.
5985 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5987 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5988 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5989 cursor motion with <left> and <right> arrow keys.
5991 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5992 some callers set that themselves.
5994 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5996 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5997 display string and the previous row comes from the same string and
5998 is empty. (Bug#9739) (Bug#9738)
6000 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6002 * doc.c (get_doc_string): Encode file name (bug#9735).
6004 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6006 * bidi.c (bidi_level_of_next_char):
6007 * xdisp.c (get_visually_first_element): Remove old incorrect
6008 comments regarding the Unicode Line Separator character.
6010 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6012 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6014 * alloc.c (Fgc_status): Do not access beyond zombies array
6015 boundary if nzombies > MAX_ZOMBIES.
6016 * alloc.c (dump_zombies): Add missing format specifier.
6018 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6020 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6021 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6023 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6024 Some packages use them to denote characters with modifiers.
6026 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6028 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6029 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6030 matching a pp-number. Rename parameter var to var1.
6032 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6034 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6036 2011-10-08 Glenn Morris <rgm@gnu.org>
6038 * callint.c (Fcall_interactively): Give a more explicit error for the
6039 'c' case with a non-character input. (Bug#8479)
6041 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6043 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6045 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6046 lines that are hscrolled on the left.
6048 * dispnew.c (buffer_posn_from_coords): Account for a possible
6049 presence of header-line. (Bug#4426)
6051 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6053 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6054 Don't advertise functionality which we discourage or doesn't work.
6056 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6058 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6059 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6060 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6061 this makes Emacs dump core during garbage collection on rare
6062 occasions. sizeof is obviously inferior to offsetof here, so
6063 stick with offsetof.
6064 (GC_POINTER_ALIGNMENT): New macro.
6065 (mark_memory): Omit 3rd (offset) arg; caller changed.
6066 Don't assume EMACS_INT alignment is the same as pointer alignment.
6068 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6070 * keyboard.c (read_key_sequence_remapped): New var.
6071 (read_key_sequence): Compute remapping in the right buffer.
6072 (command_loop_1): Use read_key_sequence's remapping directly.
6074 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6076 * dired.c (file_name_completion): Don't expand file name.
6077 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6078 before checking file name handler.
6080 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6081 they've been requested explicitly (bug#9591).
6083 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6085 * keymap.c (Fsingle_key_description): Use make_specified_string
6086 instead of build_string to build string from push_key_description.
6089 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6091 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6092 This fixes a Y2038 bug on 64-bit hosts.
6093 * buffer.c (reset_buffer):
6094 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6095 (Fclear_buffer_auto_save_failure):
6096 Use 0, not -1, to represent an unset failure time, since time_t
6097 might not be signed.
6099 Remove dependency on glibc malloc internals.
6100 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6101 Move back here from lisp.h, but with their new implementations.
6102 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6103 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6104 * charset.c (charset_table_init): New static var.
6105 (syms_of_charset): Use it instead of xmalloc. This removes a
6106 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6107 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6108 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6109 Move back to alloc.c.
6110 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6111 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6113 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6115 * nsterm.m (windowDidResize): Call x_set_window_size only when
6116 ns_in_resize is true. Otherwise set pixelwidth/height and
6117 call change_frame_size (Bug#9628).
6119 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6121 Port --enable-checking=all to Fedora 14 x86-64.
6122 * charset.c (syms_of_charset): Also account for glibc malloc's
6123 internal overhead when calculating the initial malloc maximum.
6125 Port --enable-checking=all to Fedora 14 x86.
6126 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6128 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6129 (overrun_check_realloc, overrun_check_free):
6130 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6131 That way, xmalloc returns a properly-aligned pointer even if
6132 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6133 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6134 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6135 into account when calculating the initial malloc maximum.
6136 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6137 Move here from alloc.c, so that charset.c can use it too.
6138 Properly align; the old code wasn't right for common 32-bit hosts
6139 when configured with --enable-checking=all.
6140 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6141 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6143 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6145 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6148 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6150 * xdisp.c (compute_display_string_end): If there's no display
6151 string at CHARPOS, return -1.
6153 * bidi.c (bidi_fetch_char): When compute_display_string_end
6154 returns a negative value, treat the character as a normal
6155 character not covered by a display string. (Bug#9624)
6157 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6159 * lread.c (Fread_from_string): Fix typo in docstring.
6161 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6163 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6164 newline, reseat the iterator instead of bidi-iterating there one
6165 character at a time. (Bug#9610)
6166 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6167 TO_CHARPOS if the bidi iterator is at base embedding level.
6169 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6171 * lread.c (readevalloop): Use correct code for NBSP.
6172 (read1): Likewise. (Bug#9608)
6174 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6176 * dbusbind.c (Fdbus_register_signal): When service is not
6177 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6179 2011-09-25 Glenn Morris <rgm@gnu.org>
6181 * buffer.c (truncate-lines): Doc fix.
6183 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6185 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6186 (Fset_window_next_buffers): Doc fix.
6188 2011-09-24 Glenn Morris <rgm@gnu.org>
6190 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6192 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6194 Fix minor problems found by static checking.
6195 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6196 * indent.c (Fvertical_motion): Fix == vs = typo.
6198 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6200 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6201 Default value is now t. Doc fix.
6203 * indent.c (Fvertical_motion): Compute and apply the overshoot
6204 logic when moving up, not only when moving down. Fix the
6205 confusing name and values of the it_overshoot_expected variable;
6206 logic changes accordingly. (Bug#9254) (Bug#9549)
6208 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6209 CHARPOS is covered by a display string which includes newlines.
6210 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6211 is covered by a display string with embedded newlines.
6213 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6215 * dbusbind.c (Fdbus_register_signal): Add match rule to
6216 Vdbus_registered_objects_table. (Bug#9581)
6217 (Fdbus_register_method, Vdbus_registered_objects_table):
6220 2011-09-24 Jim Meyering <meyering@redhat.com>
6222 do not ignore write error for any output size
6223 The previous change was incomplete.
6224 While it makes emacs --batch detect the vast majority of stdout
6225 write failures, errors were still ignored whenever the output size is
6226 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6227 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6228 && echo FAIL: ignored write error
6229 FAIL: ignored write error
6230 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6231 && echo FAIL: ignored write error
6232 FAIL: ignored write error
6233 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6235 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6237 * emacs.c (Fkill_emacs): In noninteractive mode exit
6238 non-successfully if a write error occurred on stdout. (Bug#9574)
6240 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6242 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6245 * dispextern.h (struct it): Update the comment documenting what
6248 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6250 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6251 a display string, extend search for cursor position to end of row.
6252 (find_row_edges): If the row ends in a newline from a display
6253 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6254 Handle the case of a display string with multiple newlines.
6255 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6256 non-empty line. Fixes confusing cursor motion with arrow keys at
6257 the beginning of a line that starts with whitespace.
6259 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6261 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6264 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6266 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6269 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6271 * xdisp.c (display_line): Record maximum and minimum buffer
6272 positions even if no glyphs were produced (e.g., by a zero-width
6273 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6274 buffer positions that will be removed from the glyph row because
6276 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6277 column is beyond frame width: don't subtract 1 "pixel" when
6278 computing width of the stretch.
6279 (reseat_at_next_visible_line_start): Undo the change made on
6280 2011-09-17 that saved paragraph information and restored it after
6281 the call to `reseat'. (Bug#9545)
6283 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6285 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6286 and turn window cursor on if cleared (Bug#9415).
6288 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6290 * search.c (boyer_moore): Take unibyte characters from pattern
6291 literally. (Bug#9458)
6293 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6295 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6297 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6299 Fix minor problem found by static checking.
6300 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6301 initialized, to pacify gcc -Wuninitialized.
6303 * fileio.c: Report proper errno when syscall falls.
6304 (Finsert_file_contents): Save and restore errno,
6305 so that report_file_error outputs the correct diagnostic.
6306 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6308 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6310 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6312 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6314 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6315 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6317 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6319 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6320 about the current paragraph and restore it after the call to reseat.
6322 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6323 (bidi_find_paragraph_start): Search back for paragraph beginning
6324 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6325 (bidi_move_to_visually_next): Only trigger paragraph-related
6326 computations when the last character is a newline or at EOB, not
6327 just any NEUTRAL_B. (Bug#9470)
6329 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6330 truncated lines if point is covered by a display string. (Bug#9524)
6332 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6334 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6335 (cons_to_x_long): New function.
6336 (lisp_data_to_selection_data): Use it. Correct the test for
6337 short-versus-long data; it was negated. Break out of vector
6338 loop, for efficiency, when a long datum is discovered.
6340 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6342 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6344 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6346 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6347 GCC PR/17406) by declaring this function with external scope.
6349 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6351 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6352 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6354 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6356 * editfns.c (Fformat): Correctly handle text properties on "%%".
6358 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6360 * xterm.c (x_draw_composite_glyph_string_foreground):
6361 * w32term.c (x_draw_composite_glyph_string_foreground):
6362 * term.c (encode_terminal_code):
6363 * composite.c (composition_update_it, get_composition_id):
6364 * xdisp.c (get_next_display_element)
6365 (fill_composite_glyph_string): Add comments about special meaning
6366 of TAB characters in a composition.
6368 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6370 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6371 This occurs when processing a multibyte format.
6372 Problem reported by Wolfgang Jenker.
6374 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6376 * xdisp.c (try_cursor_movement): Only check for exact match if
6377 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6379 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6381 Remove unused external symbols.
6382 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6383 * xdisp.c (calc_pixel_width_or_height): Now static.
6384 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6385 * indent.c (check_display_width):
6386 * w32term.c: Fix comment to match code.
6387 * xterm.c, xterm.h (x_catching_errors): Remove.
6389 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6391 * xselect.c: Use signed conversions more consistently (Bug#9498).
6392 (selection_data_to_lisp_data): Assume incoming selection data are
6393 signed integers, not unsigned. This is to be consistent with
6394 outgoing selection data, which was modified to use signed integers
6395 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6396 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6397 expects long, not unsigned long.
6399 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6401 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6402 computation of loop end. Reported by Johan Bockgård
6405 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6407 * frame.c (Fother_visible_frames_p): Function deleted.
6409 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6411 * indent.c (compute_motion): Process display vector front to back
6412 rather than the other way around. (Bug#2496)
6414 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6416 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6418 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6420 * minibuf.c (Fread_from_minibuffer): Doc fix.
6422 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6424 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6425 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6427 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6429 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6430 value for non-existent files.
6432 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6434 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6435 set its "size" to -1. This will set the modtime_size field of
6436 the corresponding buffer to -1, which is what
6437 verify-visited-file-modtime expects for files that do not exist.
6440 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6442 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6444 * lisp.h: ... from here. push_key_description is no longer
6445 defined in keyboard.c, so its declaration should not be in
6446 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6447 logically belongs with push_key_description.
6449 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6451 * buffer.h: Include <sys/types.h> instead of <time.h>.
6452 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6453 Problem reported by Herbert J. Skuhra.
6455 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6457 * xml.c (parse_region): Make the parsing work for
6458 non-comment-starting XML files again (bug#9144).
6460 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6462 * image.c (gif_load): Fix calculation of bottom and right corner.
6465 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6467 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6468 redisplay in small windows.
6470 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6472 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6474 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6476 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6477 Operate on live windows only.
6479 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6481 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6483 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6485 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6486 only under bidi iteration.
6488 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6490 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6492 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6494 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6495 Without this fix, the command to link temacs failed due to an
6496 undefined symbol __builtin_isnan. This is because
6497 /usr/include/iso/math_c99.h #defines isnan(x) to
6498 __builtin_isnan(x), but the bundled gcc, which identifies itself
6499 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6501 * floatfns.c (isnan): #undef, and then #define to a clone of
6503 (Fisnan): Always define, since it's always available now.
6504 (syms_of_floatfns): Always define isnan at the Lisp level.
6506 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6508 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6510 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6512 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6513 The previous code assumed that file offsets (off_t values) fit in
6514 EMACS_INT variables, which is not true on typical 32-bit hosts.
6515 The code messed up by falsely reporting buffer overflow in cases
6516 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6517 when "big" contains more than 2**29 bytes, even though this
6518 inserts just one byte and does not overflow the buffer.
6519 (Finsert_file_contents): Store file offsets as off_t
6520 values, not as EMACS_INT values. Check for overflow when
6521 converting between EMACS_INT and off_t. When checking for
6522 buffer overflow or for overlap, take the offsets into account.
6523 Don't use EMACS_INT for small values where int suffices.
6524 When checking for overlap, fix a typo: ZV was used where
6525 ZV_BYTE was intended.
6526 (Fwrite_region): Don't assume off_t fits into 'long'.
6527 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6529 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6531 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6533 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6535 sprintf-related integer and memory overflow issues (Bug#9412).
6537 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6538 (esprintf, exprintf, evxprintf): New functions.
6539 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6540 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6541 (modify_event_symbol): Do not assume that the length of
6542 name_alist_or_stem is safe to alloca and fits in int.
6543 (Fexecute_extended_command): Likewise for function name and binding.
6544 (Frecursion_depth): Wrap around reliably on integer overflow.
6545 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6546 since some callers pass EMACS_INT values.
6547 (Fsingle_key_description): Don't crash if symbol name contains more
6548 than MAX_ALLOCA bytes.
6549 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6550 (get_minibuffer): Arg is now EMACS_INT, not int.
6551 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6552 (esprintf, exprintf, evxprintf): New decls.
6553 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6555 * dbusbind.c (signature_cat): New function.
6556 (xd_signature, Fdbus_register_signal):
6557 Do not overrun buffer; instead, report string overflow.
6559 * dispnew.c (add_window_display_history): Don't overrun buffer.
6560 Truncate instead; this is OK since it's just a log.
6562 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6563 even if the time zone offset is outlandishly large.
6564 Don't mishandle offset == INT_MIN.
6566 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6567 when creating daemon; the previous buffer-overflow check was incorrect.
6569 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6570 which has the guts of the old verror function.
6572 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6573 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6575 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6576 (font_unparse_xlfd): Don't blindly alloca long strings.
6577 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6578 fits in int, when using sprintf. Use single snprintf to count
6579 length of string rather than counting it via multiple sprintfs;
6580 that's simpler and more reliable.
6581 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6582 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6583 sprintf, in case result does not fit in int.
6585 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6586 (fontset_from_font): Print it.
6588 * frame.c (tty_frame_count): Now printmax_t, not int.
6589 (make_terminal_frame, set_term_frame_name): Print it.
6590 (x_report_frame_params): In X, window IDs are unsigned long,
6591 not signed long, so print them as unsigned.
6592 (validate_x_resource_name): Check for implausibly long names,
6593 and don't assume name length fits in 'int'.
6594 (x_get_resource_string): Don't blindly alloca invocation name;
6595 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6598 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6599 (xg_check_special_colors, xg_set_geometry):
6600 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6602 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6603 Use esprintf, not sprintf, in case result does not fit in int.
6605 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6606 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6607 it as a large positive number.
6608 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6609 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6611 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6612 in case result does not fit in int.
6614 * print.c (float_to_string): Detect width overflow more reliably.
6615 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6616 buffer overrun. Don't assume list length fits in 'int'. Treat
6617 print length of 0 as 0, not as infinity; to be consistent with other
6618 uses of print length in this function. Don't overflow print length
6619 index. Don't assume hash table size fits in 'long', or that
6620 vectorlike size fits in 'unsigned long'.
6622 * process.c (make_process): Use printmax_t, not int, to format
6623 process-name gensyms.
6625 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6627 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6628 to avoid potential buffer overrun.
6630 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6631 if X resource line is longer than 512 bytes.
6633 * xfns.c (x_window): Make sprintf buffer a bit bigger
6634 to avoid potential buffer overrun.
6636 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6638 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6640 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6642 Integer overflow fixes for scrolling, etc.
6643 Without these, Emacs silently mishandles large integers sometimes.
6644 For example, "C-u 4294967297 M-x recenter" was treated as if
6645 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6647 * xdisp.c (try_window_id): Check Emacs fixnum range before
6648 converting to 'int'.
6650 * window.c (window_scroll_line_based, Frecenter):
6651 Check that an Emacs fixnum is in range before assigning it to 'int'.
6652 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6653 values converted from Emacs fixnums.
6654 (Frecenter): Don't wrap around a line count if it is out of 'int'
6655 range; instead, treat it as an extreme value.
6656 (Fset_window_configuration, compare_window_configurations):
6657 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6659 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6660 that can exceed INT_MAX. Check that EMACS_INT value is in range
6661 before assigning it to the (possibly-narrower) index.
6662 (match_limit): Don't assume that a fixnum can fit in 'int'.
6664 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6667 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6668 (Fvertical_motion): Don't wrap around LINES values that don't fit
6669 in 'int'. Instead, treat them as extreme values. This is good
6670 enough for windows, which can't have more than INT_MAX lines anyway.
6672 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6674 * Require libxml/parser.h to avoid compilation warning.
6676 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6678 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6679 since this reportedly can destroy thread storage.
6681 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6683 * syntax.c (find_defun_start): Update all cache variables if
6684 exiting early (Bug#9401).
6686 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6688 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6690 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6691 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6692 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6694 * term.c (tty_append_glyph): New function.
6695 (produce_stretch_glyph): Static function and its prototype deleted.
6697 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6700 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6702 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6703 when checking :margin (Bug#9390).
6704 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6705 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6706 so that the name doesn't mislead. All uses changed.
6708 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6710 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6713 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6715 * xdisp.c (move_it_to): Don't bail out early when reaching
6716 position beyond to_charpos, if we are scanning backwards.
6717 (move_it_vertically_backward): When DY == 0, make sure we get to
6718 the first character in the line after the newline.
6720 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6722 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6723 (ccl_driver): Do not generate an out-of-range pointer.
6724 (Fccl_execute_on_string): Remove unnecessary check for
6725 integer overflow, noted by Stefan Monnier in
6726 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6727 Remove a FIXME that didn't need fixing.
6728 Simplify the newly-introduced buffer reallocation code.
6730 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6732 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6734 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6736 Integer and memory overflow issues (Bug#9196).
6738 * doc.c (get_doc_string): Rework so that
6739 get_doc_string_buffer_size is the actual buffer size, rather than
6740 being 1 less than the actual buffer size; this makes xpalloc more
6743 * image.c (x_allocate_bitmap_record, cache_image):
6744 * xselect.c (Fx_register_dnd_atom):
6745 Simplify previous changes by using xpalloc.
6747 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6748 since either will do and ptrdiff_t is convenient with xpalloc.
6750 * charset.c (charset_table_size)
6751 (struct charset_sort_data.priority): Now ptrdiff_t.
6752 (charset_compare): Don't overflow if priorities differ greatly.
6753 (Fsort_charsets): Don't assume list length fits in int.
6754 Check for size-calculation overflow when allocating sort data.
6755 (syms_of_charset): Allocate an initial charset table that is
6756 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6758 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6760 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6761 The actual value is always <= INT_MAX, and leaving it unsigned made
6762 overflow checking harder.
6764 * dispextern.h (struct glyph_matrix.rows_allocated)
6765 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6766 with xpalloc. The values are still always <= INT_MAX.
6768 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6770 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6771 (SAFE_NALLOCA): New macro.
6773 * region-cache.c (struct boundary.pos, find_cache_boundary)
6774 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6775 (set_cache_region, invalidate_region_cache)
6776 (revalidate_region_cache, know_region_cache, region_cache_forward)
6777 (region_cache_backward, pp_cache):
6778 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6779 so that ptrdiff_t * can be passed to xpalloc.
6780 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6781 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6782 (pp_cache): Don't assume cache_len fits in int.
6783 * region-cache.h: Adjust extern decls to match.
6785 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6786 EMACS_INT, since either will do, for xpalloc.
6788 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6789 (xnmalloc, xnrealloc, xpalloc): New functions.
6791 * bidi.c (bidi_shelve_header_size): New constant.
6792 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6793 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6795 * bidi.c (bidi_cache_shrink):
6796 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6798 Don't update size of array until after memory allocation succeeds,
6799 because xmalloc/xrealloc may not return.
6800 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6801 now that we have proper integer overflow checking.
6802 (record_overlay_string, overlay_strings): Catch overflows when
6803 calculating size of overlay_str_buf.
6805 * callproc.c (Fcall_process): Check for size overflow when
6806 calculating size of args2.
6807 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6808 Normally we prefer signed values, but sticking with ptrdiff_t would
6809 require adding more-complicated checks.
6811 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6812 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6813 Redo buffer-overflow calculations to avoid integer overflow.
6814 Add a FIXME comment where memory seems to be over-allocated.
6816 * character.c (Fstring): Check for size-calculation overflow.
6818 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6819 unnecessary integer overflow. Check for size overflow.
6820 (encode_coding_object): Don't update size until xmalloc succeeds.
6822 * composite.c (get_composition_id): Check for overflow in glyph
6823 length calculations.
6825 Integer and memory overflow fixes for display code.
6826 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6827 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6828 (scrolling_window): Check for overflow in size calculations.
6829 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6830 Don't assume glyph table len fits in int.
6831 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6832 (row_table_size): Now ptrdiff_t, not int.
6833 (scrolling_window): Avoid overflow in size calculations.
6834 Don't update size until allocation succeeds.
6835 * fns.c (concat): Check for overflow in size calculations.
6836 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6837 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6838 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6840 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6841 (get_doc_string): Check for size calculation overflow.
6842 Don't update size until allocation succeeds.
6843 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6844 EMACS_INT, where ptrdiff_t will do.
6845 (Fsubstitute_command_keys): Check for string overflow.
6847 * editfns.c (set_time_zone_rule): Don't assume environment length
6849 (message_length): Now ptrdiff_t, not int.
6850 (Fmessage_box): Don't update size until allocation succeeds.
6851 Don't assume message length fits in int.
6852 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6854 * emacs.c (main): Do not reallocate argv, since there is a null at
6855 the end that can be overwritten, and this way there's no need to
6856 worry about size-calculation overflow.
6857 (sort_args): Check for size-calculation overflow.
6859 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6861 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6863 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6864 (x_set_scroll_bar_width, x_figure_window_size):
6865 Check for integer overflow.
6866 (x_set_alpha): Do not assume XINT fits in int.
6868 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6869 This is for the members text_lines, text_cols, total_lines, total_cols,
6870 where the system imposes an 'int' limit.
6872 * fringe.c (Fdefine_fringe_bitmap):
6873 Don't update size until alloc works.
6875 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6876 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6878 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6879 Check for size-calculation overflow.
6880 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6881 do, as we prefer signed integers.
6882 (id_to_widget.max_size, id_to_widget.used)
6883 (xg_store_widget_in_map, xg_remove_widget_from_map)
6884 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6885 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6886 Use and return ptrdiff_t, not int.
6887 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6888 * gtkutil.h: Change prototypes to match the above.
6890 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6891 are duplicate now that they've been promoted to lisp.h.
6892 (x_allocate_bitmap_record, x_alloc_image_color)
6893 (make_image_cache, cache_image, xpm_load):
6894 Don't update size until alloc is done.
6895 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6897 Check for size calculation overflow.
6898 (ct_colors_allocated_max): New constant.
6899 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6902 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6903 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6904 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6905 Use ptrdiff_t, not int, to count maps.
6906 (read_char_minibuf_menu_prompt): Check for overflow in size
6907 calculations. Don't update size until allocation succeeds.
6908 Redo calculations to avoid overflow.
6909 * keyboard.h: Change prototypes to match the above.
6911 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6913 (current_minor_maps): Check for size calculation overflow.
6914 * keymap.h: Change prototypes to match the above.
6916 * lread.c (read1, init_obarray): Don't update size until alloc done.
6918 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6919 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6921 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6922 Now ptrdiff_t, not int.
6923 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6924 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6926 * process.c (Fnetwork_interface_list): Check for overflow
6927 in size calculation.
6929 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6931 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6932 overflow. Don't bother calling xmalloc when xrealloc will do.
6934 * search.c (Freplace_match): Check for size calculation overflow.
6935 (Fset_match_data): Don't assume list lengths fit in 'int'.
6937 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6938 for command line length. Do not attempt to address one before the
6939 beginning of an array, as that's not portable.
6941 * term.c (max_frame_lines): Remove; unused.
6942 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6944 (encode_terminal_code, calculate_costs): Check for size
6945 calculation overflow.
6946 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6947 table lengths and related sizes. Don't update size until alloc
6948 done. Redo calculations to avoid overflow.
6949 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6951 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6952 subtracting pointers.
6953 (gobble_line): Check for overflow more carefully. Don't update size
6956 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6957 Don't update size until alloc done.
6958 Redo size calculations to avoid overflow.
6959 Check for size calculation overflow.
6960 (main) [DEBUG]: Fix typo in invoking tparam1.
6962 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6963 Use ptrdiff_t, not int, for sizes.
6964 (store_mode_line_noprop_char): Don't update size until alloc done.
6966 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6967 Use ptrdiff_t, not int, for sizes.
6968 (Finternal_make_lisp_face, cache_face):
6969 Check for size calculation overflow.
6970 (cache_face): Treat size calculation overflows as if they were
6971 memory exhaustion (the usual treatment), rather than aborting.
6973 * xfns.c (x_encode_text, x_set_name_internal)
6974 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6975 sizes, since they can exceed INT_MAX in size. Check for size
6976 calculation overflow.
6978 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6979 (xg_select): Check for size calculation overflow.
6980 Don't update size until alloc done.
6982 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6983 as sprintf is limited to int lengths.
6985 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6986 (X_LONG_MIN): New macros.
6987 Use them to make the following changes clearer.
6988 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6989 This change doesn't affect the value now, but it may help remind
6990 future maintainers not to raise the value too much later.
6991 (SELECTION_QUANTUM): Remove, replacing with ...
6992 (selection_quantum): ... new function, which avoids overflow.
6994 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6995 assumption that selection length fits in 'int'.
6996 (x_reply_selection_request, x_handle_selection_request)
6997 (x_get_window_property, receive_incremental_selection)
6998 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6999 (lisp_data_to_selection_data, clean_local_selection_data):
7000 Use ptrdiff_t, not int, to record length of selection.
7001 (x_reply_selection_request, x_get_window_property)
7002 (receive_incremental_selection, x_property_data_to_lisp):
7003 Redo calculations to avoid overflow.
7004 (x_reply_selection_request): When sending hint, ceiling it at
7005 X_LONG_MAX rather than relying on wraparound overflow to send
7007 (x_get_window_property, receive_incremental_selection)
7008 (lisp_data_to_selection_data, x_property_data_to_lisp):
7009 Check for size-calculation overflow.
7010 (x_get_window_property, receive_incremental_selection)
7011 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7012 Don't store size until memory allocation succeeds.
7013 (x_get_window_property): Plug memory leak on memory exhaustion.
7014 Don't double-block input; malloc is safe here. Don't assume 2**34
7015 - 4 fits in unsigned long. Add an xassert to check
7016 XGetWindowProperty overflow. Be more careful about overflow
7017 calculations, and distinguish size from memory overflow better.
7018 (receive_incremental_selection): When tracing, don't assume
7019 unsigned int is less than INT_MAX.
7020 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7021 harmful) conversions of unsigned short to int.
7022 (lisp_data_to_selection_data): Don't assume that integers
7023 in the range -65535 through -1 fit in an X unsigned short.
7024 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7025 result parameters unless successful. Rely on cons_to_unsigned
7026 to report problems with elements; the old code wasn't right anyway.
7027 (x_check_property_data): Check for int overflow; we cannot use
7028 a wider type due to X limits.
7029 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7031 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7033 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7034 (x_term_init): Check for size calculation overflow.
7035 (x_color_cells): Don't store size until memory allocation succeeds.
7036 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7037 Don't assume alloca size is less than MAX_ALLOCA.
7038 (x_term_init): Don't assume length fits in int (sprintf is limited
7041 Use ptrdiff_t for composition IDs.
7042 * character.c (lisp_string_width):
7043 * composite.c (composition_table_size, n_compositions)
7044 (get_composition_id, composition_gstring_from_id):
7045 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7046 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7047 * window.c (Frecenter):
7048 Use ptrdiff_t, not int, for composition IDs.
7049 * composite.c (get_composition_id): Check for integer overflow.
7050 * composite.h: Adjust prototypes to match the above changes.
7052 Use ptrdiff_t for hash table indexes.
7053 * category.c (hash_get_category_set):
7054 * ccl.c (ccl_driver):
7055 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7056 * coding.c (coding_system_charset_list, detect_coding_system):
7057 * coding.h (struct coding_system.id):
7058 * composite.c (get_composition_id, gstring_lookup_cache):
7059 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7060 * image.c (xpm_get_color_table_h):
7061 * lisp.h (hash_lookup, hash_put):
7062 * minibuf.c (Ftest_completion):
7063 Use ptrdiff_t for hash table indexes, not int (which is too
7064 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7065 32-bit --with-wide-int hosts).
7067 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7068 Add a FIXME comment about memory leaks.
7069 (syms_of_charset): Don't assume xmalloc returns.
7071 Don't assume that stated character widths fit in int.
7072 * character.c (Fchar_width, c_string_width, lisp_string_width):
7073 * character.h (CHAR_WIDTH):
7074 * indent.c (MULTIBYTE_BYTES_WIDTH):
7075 Use sanitize_char_width to avoid undefined and/or bad behavior
7076 with outlandish widths.
7077 * character.h (sanitize_tab_width): Rename from sanitize_width,
7078 now that we have two such functions. All uses changed.
7079 (sanitize_char_width): New inline function.
7081 Don't assume that tab-width fits in int.
7082 * character.h (sanitize_width): New inline function.
7083 (SANE_TAB_WIDTH): New macro.
7084 (ASCII_CHAR_WIDTH): Use it.
7085 * indent.c (sane_tab_width): Remove. All uses replaced by
7086 SANE_TAB_WIDTH (current_buffer).
7087 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7089 * fileio.c: Integer overflow issues with file modes.
7090 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7092 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7093 Remove unreachable code.
7094 (read_hex, load_charset_map_from_file): Check for integer overflow.
7096 * xterm.c: Don't go over XClientMessageEvent limit.
7097 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7098 (x_send_scroll_bar_event): Likewise. Check that the size does not
7099 exceed limits imposed by XClientMessageEvent, as well as the usual
7100 ptrdiff_t and size_t limits.
7102 * keyboard.c: Overflow, signedness and related fixes.
7103 (make_lispy_movement): Use same integer type in forward decl
7104 that is used in the definition.
7105 (read_key_sequence, keyremap_step):
7106 Change bufsize argument back to int, undoing my 2011-03-30 change.
7107 We prefer signed types, and int is wide enough here.
7108 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7109 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7110 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7111 length, not size_t. Use ptrdiff_t for index, not int.
7112 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7113 possibility of integer overflow.
7115 Overflow, signedness and related fixes for images.
7117 * dispextern.h (struct it.stack[0].u.image.image_id)
7118 (struct_it.image_id, struct image.id, struct image_cache.size)
7119 (struct image_cache.used, struct image_cache.ref_count):
7120 * gtkutil.c (update_frame_tool_bar):
7121 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7122 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7123 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7124 * nsmenu.m (update_frame_tool_bar):
7125 * xdisp.c (calc_pixel_width_or_height):
7126 * xfns.c (image_cache_refcount):
7127 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7128 on typical 64-bit hosts.
7130 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7131 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7132 Omit unnecessary casts to int.
7133 (parse_image_spec): Check that integers fall into 'int' range
7134 when the callers expect that.
7135 (image_ascent): Redo ascent calculation to avoid int overflow.
7136 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7137 (lookup_image): Remove unnecessary tests.
7138 (xbm_image_p): Locals are now of int, not EMACS_INT,
7139 since parse_image_check makes sure they fit into int.
7140 (png_load, gif_load, svg_load_image):
7141 Prefer int to unsigned where either will do.
7142 (tiff_handler): New function, combining the cores of the
7143 old tiff_error_handler and tiff_warning_handler.
7144 This function is rewritten to use vsnprintf and thereby avoid
7145 stack buffer overflows. It uses only the features of vsnprintf
7146 that are common to both POSIX and native Microsoft.
7147 (tiff_error_handler, tiff_warning_handler): Use it.
7148 (tiff_load, gif_load, imagemagick_load_image):
7149 Don't assume :index value fits in 'int'.
7150 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7151 (imagemagick_load_image): Check that crop parameters fit into
7152 the integer types that MagickCropImage accepts. Don't assume
7153 Vimagemagick_render_type has a nonnegative value. Don't assume
7154 size_t fits in 'long'.
7155 (gs_load): Use printmax_t to print the widest integers possible.
7156 Check for integer overflow when computing image height and width.
7158 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7160 * xdisp.c (redisplay_window): Don't force window start if point
7161 will be invisible in the resulting window. (Bug#9324)
7163 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7165 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7166 the display spec is of the form `(space ...)'.
7167 (handle_display_spec): Return the value returned by
7168 handle_single_display_spec, not just 1 or zero.
7169 (handle_single_display_spec): If the display spec is of the form
7170 `(space ...)', and specifies display in the text area, return 2
7172 (try_cursor_movement): Check for the need to scroll more
7173 accurately, and prefer exact match for point under bidi.
7174 Don't advance `row' beyond the last row of the window.
7176 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7177 into disp_prop; all users changed.
7179 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7180 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7181 for the text covered by the display property.
7183 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7185 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7186 Change return value to nil.
7187 (Frecord_buffer): Delete unused function.
7189 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7191 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7192 buffers, return left-to-right.
7193 (set_cursor_from_row): Consider candidate row a win if its glyph
7194 represents a newline and point is on that newline. Fixes cursor
7195 positioning on the newline at EOL of R2L text within L2R
7196 paragraph, and vice versa.
7197 (try_cursor_movement): Check continued rows, in addition to
7198 continuation rows. Fixes unwarranted scroll when point enters a
7199 continued line of R2L text within an L2R paragraph, or vice versa.
7200 (cursor_row_p): Consider the case of point being equal to
7201 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7202 from the end of a short line to the beginning of a continued line
7203 of R2L text within L2R paragraph.
7204 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7205 composed characters.
7207 * bidi.c (bidi_check_type): Use xassert.
7208 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7211 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7213 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7216 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7218 * nsfont.m (ns_otf_to_script): Fix typo.
7220 2011-08-22 Kenichi Handa <handa@m17n.org>
7222 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7223 extra slot even if the purpose is char-code-property-table.
7225 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7227 * xdisp.c (redisplay_window): When computing centering_position,
7228 account for the height of the header line. (Bug#8874)
7230 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7231 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7232 candidate is selected by the mouse, and that candidate has a
7233 composed character under the mouse.
7235 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7236 coordinates reported by pos-visible-in-window-p for a composed
7237 character in column zero.
7239 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7241 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7243 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7245 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7246 consider it a hit if to_charpos is anywhere in the range of the
7247 composed buffer positions.
7249 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7251 * image.c (gif_load): Don't assume that each subimage has the same
7252 dimensions as the base image. Handle disposal method that is
7253 "undefined" by the gif spec (Bug#9335).
7255 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7257 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7258 (Fcondition_case): Document `debug' symbol in error handler.
7260 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7262 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7263 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7264 from an Org mode buffer to a Speedbar frame.
7266 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7267 a composition, take its buffer position from IT->cmp_it.charpos.
7268 Fixes cursor positioning at the beginning of a line that begins
7269 with a composed character.
7271 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7273 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7274 character bidirectional type, use STRONG_L instead. Fixes crashes
7275 in a buffer produced by `describe-categories'.
7277 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7278 members before the level stack, so they would be saved and
7279 restored when copying iterator state. Fixes incorrect reordering
7280 around TABs covered by display properties.
7282 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7284 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7286 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7288 * eval.c (internal_condition_case, internal_condition_case_1)
7289 (internal_condition_case_2, internal_condition_case_n):
7290 Remove unnecessary aborts (Bug#9081).
7292 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7294 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7295 has no `load' handler, try opening the file locally. (Bug#9311)
7297 2011-08-16 Ken Brown <kbrown@cornell.edu>
7299 * gmalloc.c: Expand comment.
7301 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7303 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7304 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7306 2011-08-16 Ken Brown <kbrown@cornell.edu>
7308 Fix memory allocation problems in Cygwin build (Bug#9273).
7310 * unexcw.c ( __malloc_initialized): Declare external variable.
7311 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7313 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7315 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7317 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7319 [CYGWIN] (special_realloc): New function.
7320 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7321 requests to realloc storage in the static heap.
7323 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7325 * bidi.c (bidi_initialize): Remove unused local.
7327 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7330 * biditype.h: Remove file.
7331 * makefile.w32-in ($(BLD)/bidi.$(O)):
7332 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7334 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7336 * chartab.c: Improve commentary for the uniprop_table API.
7338 * bidi.c (bidi_paragraph_init): Support zero value of
7339 bidi_ignore_explicit_marks_for_paragraph_level.
7340 (bidi_initialize): Use uniprop_table instead of including
7341 biditype.h and bidimirror.h.
7343 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7344 coordinates of the iterator when restoring from ppos_it.
7347 2011-08-14 Kenichi Handa <handa@m17n.org>
7349 * process.c (create_process): Call setup_process_coding_systems
7350 after the pid of the process is set to -1 (Bug#8162).
7352 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7354 * xdisp.c (move_it_in_display_line_to): Don't invoke
7355 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7356 ppos_it. Fixes vertical cursor motion when line beginning is
7357 covered by an image. (Bug#9296)
7359 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7361 * nsterm.h (ns_run_ascript): Declare.
7362 (NSAPP_DATA2_RUNASSCRIPT): Define.
7364 * nsfns.m (as_script, as_result, as_status): New static variables.
7365 (ns_run_ascript): New function.
7366 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7367 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7368 the event loop. Get status from as_status (Bug#7276).
7370 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7371 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7372 the event loop (Bug#7276).
7374 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7376 * gnutls.c (QCgnutls_bootprop_priority)
7377 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7378 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7379 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7380 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7381 (QCgnutls_bootprop_verify_hostname_error)
7382 (QCgnutls_bootprop_callbacks_verify): Rename from
7383 Qgnutls_bootprop_..., all uses changed.
7385 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7388 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7390 * xfaces.c (Qframe_set_background_mode): Now static.
7391 * dispextern.h (Qframe_set_background_mode): Remove decl.
7393 * process.c (Fnetwork_interface_info): Declare local only if needed.
7395 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7397 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7398 (Fnetwork_interface_list): Allocate in increments of bytes instead
7399 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7400 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7402 (struct ifflag_def): notrailers is smart on OSX.
7403 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7404 Get hardware address with getifaddrs if available.
7406 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7408 * xdisp.c (iterate_out_of_display_property): xassert that
7409 IT->position is set to within IT->object's boundaries. Break from
7410 the loop as soon as EOB is reached; avoids infloops in redisplay
7411 when IT->position is set up wrongly due to some bug.
7412 Set IT->current to match the bidi iterator unconditionally.
7413 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7414 entry. Force push_it to save on the stack the current
7415 buffer/string position, to be restored by pop_it. Fix flags in
7416 the iterator structure wrt the object coming from a display
7417 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7418 properties. (Bug#9284)
7420 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7422 * fontset.c (fontset_get_font_group): Add proper type checks.
7425 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7427 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7428 and LC_VERSION_MIN_MACOSX.
7429 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7430 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7432 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7434 * xdisp.c (forward_to_next_line_start): Allow to use the
7435 no-display-properties-and-no-overlays under bidi display.
7436 Set disp_pos in the bidi iterator to avoid searches for display
7437 properties and overlays.
7439 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7441 * editfns.c (Fset_time_zone_rule): Document relationship with the
7444 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7445 the font entity extracted from the cache (Bug#8109).
7447 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7449 * composite.c (autocmp_chars): Don't reset point. That is done by
7450 restore_point_unwind (Bug#5984).
7452 2011-08-07 Juri Linkov <juri@jurta.org>
7454 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7455 to show the arg `TIME' instead of `TIMEVAL'.
7457 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7459 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7460 display property strides EOL and includes a newline, as in
7461 longlines-mode. (Bug#9254)
7462 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7463 word-wrap under bidirectional display. (Bug#9224)
7465 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7466 is non-zero, even if the data buffer is NULL. Fixes a crash in
7467 vertical-motion with longlines-mode. (Bug#9254)
7469 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7471 * bidi.c <bidi_cache_total_alloc>: Now static.
7472 (bidi_initialize): Initialize bidi_cache_total_alloc.
7474 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7477 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7478 amount allocated this far in `bidi_cache_total_alloc'.
7479 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7480 non-zero, only free the data buffer without restoring the cache
7481 contents. All callers changed.
7483 * dispextern.h (bidi_unshelve_cache): Update prototype.
7485 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7486 (move_it_in_display_line, move_it_to)
7487 (move_it_vertically_backward, move_it_by_lines): Replace the call
7488 to xfree to an equivalent call to bidi_unshelve_cache.
7489 (move_it_in_display_line_to): Fix logic of returning
7490 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7492 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7494 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7495 came from a string character with a `cursor' property. (Bug#9229)
7497 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7499 * Makefile.in (LIB_PTHREAD): New variable.
7500 (LIBES): Add LIB_PTHREAD (Bug#9216).
7502 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7503 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7505 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7507 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7509 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7511 * xterm.c (x_find_topmost_parent): New function.
7512 (x_set_frame_alpha): Find topmost parent window with
7513 x_find_topmost_parent and set the property there also (bug#9181).
7514 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7516 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7518 * callproc.c (Fcall_process): Avoid vfork clobbering
7519 the local vars buffer, coding_systems, current_dir.
7521 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7523 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7525 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7527 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7528 so that it is not optimized away.
7530 * xdisp.c (compute_display_string_pos): Remove unused local.
7532 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7534 Fix slow cursor motion and scrolling in large buffers with
7535 selective display, like Org Mode buffers. (Bug#9218)
7537 * dispextern.h (struct bidi_it): New member disp_prop_p.
7539 * xdisp.c: Remove one-slot cache of display string positions.
7540 (compute_display_string_pos): Accept an additional argument
7541 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7542 for a display string or property. If found, set DISP_PROP_P
7545 * bidi.c (bidi_fetch_char): Accept an additional argument
7546 DISP_PROP_P, and pass it to compute_display_string_pos.
7547 Only handle text covered by a display string if DISP_PROP_P is returned
7548 non-zero. All callers of bidi_fetch_char changed.
7550 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7552 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7554 2010-12-03 Don March <don@ohspite.net>
7556 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7557 last character M-[char] is translated to ESC [char] (bug#7541).
7559 2011-08-02 Kenichi Handa <handa@m17n.org>
7561 * lisp.h (uniprop_table): Extern it.
7563 * chartab.c (uniprop_table): Make it non-static.
7565 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7567 * xdisp.c (forward_to_next_line_start): Accept additional argument
7568 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7570 (reseat_at_next_visible_line_start): Use the bidi iterator state
7571 returned by forward_to_next_line_start to restore the state of
7572 it->bidi_it after backing up to previous newline. (Bug#9212)
7574 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7576 * regex.c (re_comp): Protoize.
7577 (re_exec): Fix return type.
7578 (regexec): Fix type of `ret'. (Bug#9203)
7580 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7582 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7583 This is needed if max-image-size is a floating-point number.
7585 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7587 * print.c (print_object): Print empty symbol as ##.
7589 * lread.c (read1): Read ## as empty symbol.
7591 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7593 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7594 setting frame foreground color (Bug#9175).
7595 (x_set_background_color): Likewise.
7597 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7598 contents (Bug#9176).
7599 (EmacsTooltip -init): Remove bezels and add shadows to
7602 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7603 or scroll bar (Bug#8470).
7605 * nsfont.m (nsfont_open): Remove assignment to voffset and
7606 unnecessary vars hshink, expand, hd, full_height, min_height.
7607 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7609 * nsterm.h (nsfont_info): Remove voffset field.
7611 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7613 Implement strike-through and overline on NextStep (Bug#8863).
7615 * nsfont.m (nsfont_open): Use underline position provided by font,
7616 instead of hard-coded value of 2.
7617 (nsfont_draw): Call ns_draw_text_decoration instead.
7619 * nsterm.h: Add declaration for ns_draw_text_decoration.
7621 * nsterm.m (ns_draw_text_decoration): New function for drawing
7622 underline, overline, and strike-through.
7623 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7624 ns_draw_text_decoration. Change treatment of cursor drawing to
7625 accommodate underlining, etc.
7627 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7629 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7632 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7634 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7635 Without this fix, if a signal arrives just after memory fills up,
7636 'malloc' might be invoked reentrantly.
7638 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7639 In other words, assume that every image size is allowed, on non-X
7640 hosts. This assumption is probably wrong, but it lets Emacs compile.
7642 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7644 * regex.c (re_iswctype): Convert return values to boolean.
7646 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7648 * xdisp.c (compute_display_string_pos): Don't use cached display
7649 string position if the buffer had its restriction changed.
7652 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7654 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7656 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7658 Integer signedness and overflow and related fixes. (Bug#9079)
7660 * bidi.c: Integer size and overflow fixes.
7661 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7662 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7663 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7664 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7665 (bidi_find_other_level_edge):
7666 Use ptrdiff_t instead of EMACS_INT where either will do.
7667 This works better on 32-bit hosts configured --with-wide-int.
7668 (bidi_cache_ensure_space): Check for size-calculation overflow.
7669 Use % rather than repeated addition, for better worst-case speed.
7670 Don't set bidi_cache_size until after xrealloc returns, because it
7672 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7673 (bidi_cache_ensure_space): Also check that the bidi cache size
7674 does not exceed that of the largest Lisp string or buffer. See Eli
7675 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7677 * alloc.c (__malloc_size_t): Remove.
7678 All uses replaced by size_t. See Andreas Schwab's note
7679 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7681 * image.c: Improve checking for integer overflow.
7682 (check_image_size): Assume that f is nonnull, since
7683 it is always nonnull in practice. This is one less thing to
7684 worry about when checking for integer overflow later.
7685 (x_check_image_size): New function, which checks for integer
7686 overflow issues inside X.
7687 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7688 This removes the need for a memory_full check.
7689 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7690 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7691 (xbm_read_bitmap_data): Change locals back to 'int', since
7692 their values must fit in 'int'.
7693 (xpm_load_image, png_load, tiff_load):
7694 Invoke x_create_x_image_and_pixmap earlier,
7695 to avoid much needless work if the image is too large.
7696 (tiff_load): Treat overly large images as if
7697 x_create_x_image_and_pixmap failed, not as malloc failures.
7698 (gs_load): Use x_check_image_size.
7700 * gtkutil.c: Omit integer casts.
7701 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7702 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7704 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7706 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7707 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7708 would wrongly return t on a 64-bit host.
7710 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7711 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7712 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7713 and therefore cause GCC to emit a bogus diagnostic in some cases.
7715 * image.c: Integer signedness and overflow and related fixes.
7716 This is not an exhaustive set of fixes, but it's time to
7717 record what I've got.
7718 (lookup_pixel_color, check_image_size): Remove redundant decls.
7719 (check_image_size): Don't assume that arbitrary EMACS_INT values
7720 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7721 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7722 (tiff_load, imagemagick_load_image):
7723 Check for overflow in size calculations.
7724 (x_create_x_image_and_pixmap): Remove unnecessary test for
7725 xmalloc returning NULL; that can't happen.
7726 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7727 (xpm_color_bucket): Use better integer hashing function.
7728 (xpm_cache_color): Don't possibly over-allocate memory.
7729 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7730 (gif_memory_source):
7731 Use ptrdiff_t, not int or size_t, to record sizes.
7732 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7733 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7734 either works, as we prefer signed integers.
7735 (tiff_read_from_memory, tiff_write_from_memory):
7736 Return tsize_t, not size_t, since that's what the TIFF API wants.
7737 (tiff_read_from_memory): Don't fail simply because the read would
7738 go past EOF; instead, return a short read.
7739 (tiff_load): Omit no-longer-needed casts.
7740 (Fimagemagick_types): Don't assume size fits into 'int'.
7742 Improve hashing quality when configured --with-wide-int.
7743 * fns.c (hash_string): New function, taken from sxhash_string.
7744 Do not discard information about ASCII character case; this
7745 discarding is no longer needed.
7746 (sxhash-string): Use it. Change sig to match it. Caller changed.
7747 * lisp.h: Declare it.
7748 * lread.c (hash_string): Remove, since we now use fns.c's version.
7749 The fns.c version returns a wider integer if --with-wide-int is
7750 specified, so this should help the quality of the hashing a bit.
7752 * emacs.c: Integer overflow minor fix.
7753 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7754 Define only if GNU_LINUX.
7755 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7757 * dispnew.c: Integer signedness and overflow fixes.
7758 Remove unnecessary forward decls, that were a maintenance hassle.
7759 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7761 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7762 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7763 (prepare_desired_row, line_draw_cost):
7764 Use int, not unsigned, where either works.
7765 (save_current_matrix, restore_current_matrix):
7766 Use ptrdiff_t, not size_t, where either works.
7767 (init_display): Check for overflow more accurately, and without
7768 relying on undefined behavior.
7770 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7771 Remove, replacing with the new symbols in lisp.h. All uses changed.
7772 * fileio.c (make_temp_name):
7773 * filelock.c (lock_file_1, lock_file):
7774 * xdisp.c (message_dolog):
7775 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7776 Use pMd etc. instead.
7777 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7778 replacing the pWIDE etc. symbols removed from editfns.c.
7780 * keyboard.h (num_input_events): Now uintmax_t.
7781 This is (very slightly) less likely to mess up due to wraparound.
7784 * buffer.c: Integer signedness fixes.
7785 (alloc_buffer_text, enlarge_buffer_text):
7786 Use ptrdiff_t rather than size_t when either will do, as we prefer
7789 * alloc.c: Integer signedness and overflow fixes.
7790 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7791 (__malloc_size_t): Default to size_t, not to int.
7792 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7793 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7794 Prefer ptrdiff_t to size_t when either would do, as we prefer
7796 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7797 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7798 Now const. Initialize with values that are in range even if char
7800 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7801 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7802 These functions do the right thing with sizes > 2**32.
7803 (check_depth): Now ptrdiff_t, not int.
7804 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7805 Adjust to new way of storing sizes. Check for size overflow bugs
7807 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7808 slightly wrong anyway, as it missed one instance of
7809 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7810 (refill_memory_reserve): Omit needless cast to size_t.
7811 (mark_object_loop_halt): Mark as externally visible.
7813 * xselect.c: Integer signedness and overflow fixes.
7814 (Fx_register_dnd_atom, x_handle_dnd_message):
7815 Use ptrdiff_t, not size_t, since we prefer signed.
7816 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7817 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7818 x_dnd_atoms_size and x_dnd_atoms_length.
7820 * doprnt.c: Prefer signed to unsigned when either works.
7822 * doprnt.c (doprnt):
7824 * xdisp.c (vmessage):
7825 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7826 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7827 prefer signed arithmetic to avoid comparison confusion.
7828 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7829 but is a bit tricky.
7831 Assume freestanding C89 headers, string.h, stdlib.h.
7832 * data.c, doprnt.c, floatfns.c, print.c:
7833 Include float.h unconditionally.
7834 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7835 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7836 * regex.c: Likewise for stddef.h, string.h.
7837 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7838 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7839 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7840 (STDC_HEADERS): Remove obsolete defines.
7841 * sysdep.c: Include limits.h unconditionally.
7843 Assume support for memcmp, memcpy, memmove, memset.
7844 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7845 * regex.c (memcmp, memcpy):
7846 Remove; we assume C89 now.
7848 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7849 (__malloc_safe_bcopy): Remove; no longer needed.
7851 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7852 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7853 well either way, and we prefer signed to unsigned.
7855 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7857 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7858 closes the connection while we're reading (bug#9182).
7860 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7862 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7863 are specified (Bug#9168).
7865 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7867 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7868 Found by GCC static checking and --with-wide-int on a 32-bit host.
7870 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7872 * xdisp.c (compute_display_string_pos): Fix logic of caching
7873 previous display string position. Initialize cached_prev_pos to
7874 -1. Fixes slow-down at the beginning of a buffer.
7876 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7878 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7879 for attrs[LFACE_FONTSET_INDEX].
7881 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7883 * xml.c (parse_region): Remove unused local
7884 that was recently introduced.
7886 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7888 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7889 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7891 * xdisp.c (move_it_in_display_line_to): Record the best matching
7892 position for TO_CHARPOS while scanning the line, and restore it on
7893 exit if none of the characters scanned was an exact match.
7894 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7895 when exact match is impossible due to invisible text, and the
7896 lines are truncated.
7898 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7900 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7903 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7905 Fix a significant slow-down of cursor motion with C-n, C-p,
7906 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7907 auto-repeat under bidi redisplay in fontified buffers.
7908 * xdisp.c (compute_stop_pos_backwards): New function.
7909 (next_element_from_buffer): Call compute_stop_pos_backwards to
7910 find a suitable prev_stop when we find ourselves before
7912 (reseat): Don't look for prev_stop, as that could mean a very long
7914 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7915 <cached_disp_overlay_modiff>: Cache for last found display string
7917 (compute_display_string_pos): Return the cached position if asked
7918 about the same buffer in the same area of character positions, and
7919 the buffer wasn't changed since the time the display string
7920 position was cached.
7922 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7924 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7925 is an integer, which is important for empty lines. (Bug#9149)
7927 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7929 * frame.c (Fmodify_frame_parameters): In tty case, update the
7930 default face if necessary (Bug#4238).
7932 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7934 * editfns.c (Fstring_to_char): No need to explain what a character
7935 is in the docstring (Bug#6576).
7937 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7939 * xml.c (parse_region): Make sure we always return a tree.
7941 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7943 * xml.c (parse_region): If a document contains only comments,
7946 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7948 * xml.c (make_dom): Return comments, too.
7950 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7953 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7954 and the surrounding thread.
7955 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7956 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7957 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7959 * s/openbsd.h (BROKEN_SIGIO): Define.
7960 * unexelf.c (unexec) [__OpenBSD__]:
7961 Don't update the .mdebug section of the Alpha COFF symbol table.
7963 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7965 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7968 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7970 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7971 This fixes some race conditions on the permissions of any newly
7974 * alloc.c (valid_pointer_p): Use pipe, not open.
7975 This fixes some permissions issues when debugging.
7977 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7978 If fchown fails to set both uid and gid, try to set just gid,
7979 as that is sometimes allowed. Adjust the file's mode to eliminate
7980 setuid or setgid bits that are inappropriate if fchown fails.
7982 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7984 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7985 to compare Lisp_Objects.
7986 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7987 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7988 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7990 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7992 * lread.c (read_integer): Unread even EOF character.
7993 (read1): Likewise. Properly record start position of symbol.
7995 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7996 symbol character follows.
7998 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8000 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8001 This works around a problem with the previous change to Fcopy_file.
8002 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8003 and without this change, GCC might complain about discarding
8004 fchown's return value.
8006 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8008 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8010 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8012 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8014 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8016 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8017 it's used from the C level.
8019 * process.c: Use the same condition for POLL_FOR_INPUT in both
8020 keyboard.c and process.c (bug#1858).
8022 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8024 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8025 (Fgnutls_boot): Use it.
8027 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8029 * doc.c (Fsubstitute_command_keys): Revert last change.
8031 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8033 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8034 quotes the next character, and doesn't affect other longer
8035 sequences (bug#8935).
8037 * lread.c (syms_of_lread): Clarify that is isn't only
8038 `eval-buffer' and `eval-defun' that's affected by
8039 `lexical-binding' (bug#8460).
8041 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8043 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8044 bidi redisplay when a line includes both an image and is truncated.
8046 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8048 Fix minor problems found by static checking.
8049 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8050 (elsz): Now a signed constant, not a size_t var. We prefer signed
8051 types to unsigned, to avoid integer comparison confusion. Without
8052 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8053 "cannot optimize loop, the loop counter may overflow", a symptom
8055 * indent.c (Fvertical_motion): Mark locals as initialized.
8056 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8058 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8060 * search.c (Fre_search_backward): Mention `case-fold-search' in
8061 all the re_search_* functions (bug#8138).
8063 * keyboard.c (Fopen_dribble_file): Document when the file is
8066 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8068 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8071 Support bidi reordering of display and overlay strings.
8072 * xdisp.c (compute_display_string_pos)
8073 (compute_display_string_end): Accept additional argument STRING.
8074 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8075 (reseat_to_string): Initialize bidi_it->string.s and
8076 bidi_it->string.schars.
8077 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8078 NULL (avoids a crash in bidi_paragraph_init).
8079 Initialize itb.string.lstring.
8080 (init_iterator): Call bidi_init_it only of a valid
8081 buffer position was specified. Initialize paragraph_embedding to
8083 (reseat_to_string): Initialize the bidi iterator.
8084 (display_string): If we need to ignore text properties of
8085 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8086 original value of -1 will not work with bidi.)
8087 (compute_display_string_pos): First arg is now struct
8088 `text_pos *'; all callers changed. Support display properties on
8090 (compute_display_string_end): Support display properties on Lisp
8092 (init_iterator, reseat_1, reseat_to_string): Initialize the
8093 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8094 when iterating on a string not from display properties).
8095 (compute_display_string_pos, compute_display_string_end):
8096 Fix calculation of the object to scan. Fixes an error when using
8098 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8099 base_level_stop; instead, set base_level_stop to BEGV.
8100 Fixes crashes in vertical-motion.
8101 (next_element_from_buffer): Improve commentary for when
8102 the iterator is before prev_stop.
8103 (init_iterator): Initialize bidi_p from the default value of
8104 bidi-display-reordering, not from buffer-local value. Use the
8105 buffer-local value only if initializing for buffer iteration.
8106 (handle_invisible_prop): Support invisible properties on strings
8107 that are being bidi-reordered.
8108 (set_iterator_to_next): Support bidi reordering of C strings and
8110 (next_element_from_string): Support bidi reordering of Lisp
8112 (handle_stop_backwards): Support Lisp strings as well.
8113 (display_string): Support display of R2L glyph rows.
8114 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8115 (init_iterator): Don't initialize it->bidi_p for strings
8117 (reseat_to_string): Initialize it->bidi_p for strings here.
8118 (next_element_from_string, next_element_from_c_string)
8119 (next_element_from_buffer): Add xassert's for correspondence
8120 between IT's object being iterated and it->bidi_it.string
8122 (face_before_or_after_it_pos): Support bidi iteration.
8123 (next_element_from_c_string): Handle the case of the first string
8124 character that is not the first one in the visual order.
8125 (get_visually_first_element): New function, refactored from common
8126 parts of next_element_from_buffer, next_element_from_string, and
8127 next_element_from_c_string.
8128 (tool_bar_lines_needed, redisplay_tool_bar)
8129 (display_menu_bar): Force left-to-right direction. Add a FIXME
8130 comment for making that be controlled by a user option.
8131 (push_it, pop_it): Save and restore the state of the
8132 bidi iterator. Save and restore the bidi_p flag.
8133 (pop_it): Iterate out of display property for string iteration as
8135 (iterate_out_of_display_property): Support iteration over strings.
8136 (handle_single_display_spec): Set up it->bidi_it for iteration
8137 over a display string, and call bidi_init_it.
8138 (handle_single_display_spec, next_overlay_string)
8139 (get_overlay_strings_1, push_display_prop): Set up the bidi
8140 iterator for displaying display or overlay strings.
8141 (forward_to_next_line_start): Don't use the shortcut if
8143 (back_to_previous_visible_line_start): If handle_display_prop
8144 pushed the iterator stack, restore the internal state of the bidi
8145 iterator by calling bidi_pop_it same number of times.
8146 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8147 and we are bidi-iterating, don't decrement the iterator position;
8148 instead, set the first_elt flag in the bidi iterator, to produce
8150 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8151 (push_display_prop): xassert that we are iterating a buffer.
8152 (push_it, pop_it): Save and restore paragraph_embedding member.
8153 (handle_single_display_spec, next_overlay_string)
8154 (get_overlay_strings_1, reseat_1, reseat_to_string)
8155 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8156 correctly. Don't assume unibyte strings are not bidi-reordered.
8157 (compute_display_string_pos)
8158 (compute_display_string_end): Fix handling the case of C string.
8159 (push_it, pop_it): Save and restore from_disp_prop_p.
8160 (handle_single_display_spec, push_display_prop): Set the
8161 from_disp_prop_p flag.
8162 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8163 (pop_it): Call iterate_out_of_display_property only if we are
8164 popping after iteration over a string that came from a display
8165 property. Fix a typo in popping stretch info. Add an assertion
8166 for verifying that the iterator position is in sync with the bidi
8168 (handle_single_display_spec, get_overlay_strings_1)
8169 (push_display_prop): Fix initialization of paragraph direction for
8170 string when that of the parent object is not yet determined.
8171 (reseat_1): Call bidi_init_it to resync the bidi
8172 iterator with IT's position. (Bug#7616)
8173 (find_row_edges): If ROW->start.pos gives position
8174 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8175 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8176 Reset the from_disp_prop_p flag.
8177 (SAVE_IT, RESTORE_IT): New macros.
8178 (pos_visible_p, face_before_or_after_it_pos)
8179 (back_to_previous_visible_line_start)
8180 (move_it_in_display_line_to, move_it_in_display_line)
8181 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8182 (try_scrolling, redisplay_window, display_line): Use them when
8183 saving a temporary copy of the iterator and restoring it back.
8184 (back_to_previous_visible_line_start, reseat_1)
8185 (init_iterator): Empty the bidi cache "stack".
8186 (move_it_in_display_line_to): If iterator ended up at
8187 EOL, but we never saw any buffer positions smaller than
8188 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8189 motion in bidi-reordered lines.
8190 (move_it_in_display_line_to): Record prev_method and prev_pos
8191 immediately before the call to set_iterator_to_next. Fixes cursor
8192 motion in bidi-reordered lines with stretch glyphs and strings
8193 displayed in margins. (Bug#8133) (Bug#8867)
8194 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8196 (pos_visible_p): Support positions in bidi-reordered lines.
8197 Save and restore bidi cache.
8199 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8200 (bidi_paragraph_info): Delete unused struct.
8201 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8202 (bidi_cache_start): New variable.
8203 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8205 (bidi_cache_fetch_state, bidi_cache_search)
8206 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8207 (bidi_cache_find, bidi_peek_at_next_level)
8208 (bidi_level_of_next_char, bidi_find_other_level_edge)
8209 (bidi_move_to_visually_next): Compare cache index with
8210 bidi_cache_start rather than with zero.
8211 (bidi_fetch_char): Accept new argument STRING; all callers
8212 changed. Support iteration over a string. Support strings with
8213 display properties. Support unibyte strings. Fix the type of
8214 `len' according to what STRING_CHAR_AND_LENGTH expects.
8215 (bidi_paragraph_init, bidi_resolve_explicit_1)
8216 (bidi_resolve_explicit, bidi_resolve_weak)
8217 (bidi_level_of_next_char, bidi_move_to_visually_next):
8218 Support iteration over a string.
8219 (bidi_set_sor_type, bidi_resolve_explicit_1)
8220 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8221 can now be zero (for strings); special values 0 and -1 were
8222 changed to -1 and -2, respectively.
8223 (bidi_char_at_pos): New function.
8224 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8225 Call it instead of FETCH_MULTIBYTE_CHAR.
8226 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8227 initialized to valid values.
8228 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8230 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8231 the test for valid cached positions. Fix the logic for looking up
8232 the sentinel state in the cache. GCPRO the Lisp string we are
8234 (bidi_push_it, bidi_pop_it): New functions.
8235 (bidi_initialize): Initialize the bidi cache start stack pointer.
8236 (bidi_cache_ensure_space): New function, refactored from part of
8237 bidi_cache_iterator_state. Don't assume the required size is just
8238 one BIDI_CACHE_CHUNK away.
8239 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8240 (bidi_count_bytes, bidi_char_at_pos): New functions.
8241 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8242 always valid if bidi_cache_idx is valid.
8243 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8244 is valid if it's going to be used.
8245 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8246 (bidi_cache_fetch_state, bidi_cache_search)
8247 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8248 (bidi_cache_iterator_state, bidi_cache_find)
8249 (bidi_find_other_level_edge, bidi_cache_start_stack):
8250 All variables related to cache indices are now EMACS_INT.
8252 * dispextern.h (struct bidi_string_data): New structure.
8253 (struct bidi_it): New member `string'. Make flag members be 1-bit
8254 fields, and put them last in the struct.
8255 (compute_display_string_pos, compute_display_string_end):
8257 (bidi_push_it, bidi_pop_it): Add prototypes.
8258 (struct iterator_stack_entry): New members bidi_p,
8259 paragraph_embedding, and from_disp_prop_p.
8260 (struct it): Member bidi_p is now a bit field 1 bit wide.
8261 (bidi_shelve_cache, bidi_unshelve_cache):
8264 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8265 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8266 and vector-like objects.
8268 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8269 cache around display iteration.
8271 * window.c (Fwindow_end, window_scroll_pixel_based)
8272 (displayed_window_lines, Frecenter): Save and restore the bidi
8273 cache around display iteration.
8275 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8277 * editfns.c (Fdelete_region): Clarify the use of the named
8278 parameters (bug#6788).
8280 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8282 * indent.c (Fvertical_motion): Set and restore w->pointm when
8283 saving and restoring the window's buffer (Bug#9006).
8285 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8287 * editfns.c (Fstring_to_char): Clarify just what is returned
8288 (bug#6576). Text by Eli Zaretskii.
8290 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8292 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8294 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8296 * buffer.c (mmap_find): Fix a typo.
8298 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8300 Fix execution of x selection hooks.
8301 * xselect.c (Qx_lost_selection_functions)
8302 (Qx_sent_selection_functions): New vars.
8303 (syms_of_xselect): DEFSYM them.
8304 (x_handle_selection_request): Pass Qx_sent_selection_functions
8305 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8306 (x_handle_selection_clear,x_clear_frame_selections):
8307 Pass Qx_lost_selection_functions rather than
8308 Vx_lost_selection_functions to Frun_hook_with_args.
8310 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8312 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8313 The old code sometimes used this field without initializing it.
8315 * alloc.c (gc_sweep): Don't read past end of array.
8316 In theory, the old code could also have corrupted Emacs internals,
8317 though it'd be very unlikely.
8319 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8321 * character.c (Fcharacterp): Don't advertise optional ignored
8322 argument. (Bug#4026)
8324 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8326 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8329 * window.c (Fset_window_start): Doc fix (bug#4199).
8330 (Fset_window_hscroll): Ditto.
8332 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8334 Fix minor new problems caught by GCC 4.6.1.
8335 * term.c (init_tty): Remove unused local.
8336 * xsettings.c (store_monospaced_changed): Define this function only
8337 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8340 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8342 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8344 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8346 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8347 are the mini-buffer and the echo area (bug#3320).
8349 * term.c (init_tty): Remove support for supdup, c10 and perq
8350 terminals, which are no longer supported (bug#1482).
8352 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8354 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8356 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8358 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8359 for non-popups (Bug#3642).
8361 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8363 * alloc.c (reset_malloc_hooks): Protoize.
8364 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8365 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8366 * cm.c (losecursor): Likewise.
8367 * data.c (fmod): Likewise.
8368 * dispnew.c (swap_glyphs_in_rows): Likewise.
8369 * emacs.c (memory_warning_signal): Likewise.
8370 * floatfns.c (float_error): Likewise.
8371 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8372 (otf_open, font_otf_capability, generate_otf_features)
8373 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8375 * image.c (pbm_read_file): Likewise.
8376 * indent.c (string_display_width): Likewise.
8377 * intervals.c (check_for_interval, search_for_interval)
8378 (inc_interval_count, count_intervals, root_interval)
8379 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8380 * lread.c (defalias): Likewise.
8381 * ralloc.c (r_alloc_check): Likewise.
8382 * regex.c (set_image_of_range_1, set_image_of_range)
8383 (regex_grow_registers): Likewise.
8384 * sysdep.c (strerror): Likewise.
8385 * termcap.c (valid_filename_p, tprint, main): Likewise.
8386 * tparam.c (main): Likewise.
8387 * unexhp9k800.c (run_time_remap, save_data_space)
8388 (update_file_ptrs, read_header, write_header, calculate_checksum)
8389 (copy_file, copy_rest, display_header): Likewise.
8390 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8392 * xdisp.c (check_it): Likewise.
8393 * xfaces.c (register_color, unregister_color, unregister_colors):
8395 * xfns.c (print_fontset_result): Likewise.
8396 * xrdb.c (member, fatal, main): Likewise.
8398 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8400 Fix minor problems found by static checking (Bug#9031).
8401 * chartab.c (char_table_set_range, map_sub_char_table):
8402 Remove unused locals.
8403 (uniprop_table): Now static.
8404 * composite.c (_work_char): Remove unused static var.
8406 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8408 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8410 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8412 * gtkutil.c (qttip_cb): Remove code without function.
8414 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8416 * w32.c (pthread_sigmask): New stub.
8418 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8420 Use pthread_sigmask, not sigprocmask (Bug#9010).
8421 sigprocmask is portable only for single-threaded applications, and
8422 Emacs can be multi-threaded when it uses GTK.
8423 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8425 * callproc.c (Fcall_process):
8426 * process.c (create_process):
8427 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8428 Use pthread_sigmask, not sigprocmask.
8430 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8432 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8433 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8436 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8438 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8439 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8440 (xg_hide_tooltip): Fix comment.
8442 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8443 in registerServicesMenuSendTypes.
8444 (validRequestorForSendType): Don't check ns_return_types.
8446 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8449 2011-07-08 Jason Rumney <jasonr@gnu.org>
8451 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8452 SH_SHOW for hidden windows (Bug#5482).
8454 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8455 frame struct members of non-existent frames (Bug#6284).
8457 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8459 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8460 variable firstTime not needed on OSX >= 10.6.
8461 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8462 >= 10.5. Use setKnobProportion, setDoubleValue.
8464 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8465 (MAC_OS_X_VERSION_10_5): Define if not defined.
8466 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8467 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8468 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8470 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8471 cString and lossyCString on OSX >= 10.4.
8473 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8474 sizeToFit on OSX >= 10.2.
8476 * nsimage.m (allocInitFromFile): Don't use deprecated method
8477 bestRepresentationForDevice on OSX >= 10.6.
8479 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8482 * emacs.c: Declare unexec_init_emacs_zone.
8484 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8486 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8488 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8489 on svcsMenu (Bug#8842).
8491 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8493 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8495 * nsterm.m (QUTF8_STRING): Declare.
8496 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8497 (validRequestorForSendType): Return type is (id).
8498 Change indexOfObjectIdenticalTo to indexOfObject.
8499 Check if we have local selection before returning self (Bug#8842).
8500 (writeSelectionToPasteboard): Put local selection into paste board
8501 if we have a local selection (Bug#8842).
8502 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8504 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8505 (ns_get_local_selection): Declare.
8507 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8509 * keymap.c (describe_map_tree): Don't insert a double newline at
8510 the end of the buffer (bug#1169) and return whether we inserted
8513 * callint.c (Fcall_interactively): Change "reading args" to
8514 "providing args" to try to clarify what it does (bug#1010).
8516 2011-07-07 Kenichi Handa <handa@m17n.org>
8518 * composite.c (composition_compute_stop_pos): Ignore a static
8519 composition starting before CHARPOS (Bug#8915).
8521 * xdisp.c (handle_composition_prop): Likewise.
8523 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8525 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8528 2011-07-07 Kenichi Handa <handa@m17n.org>
8530 * character.h (unicode_category_t): New enum type.
8532 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8533 (Qchar_code_property_table): New variable.
8534 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8535 (UNIPROP_COMPRESSED_FORM_P): New macros.
8536 (char_table_ascii): Uncompress the compressed values.
8537 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8538 Uncompress the compressed values.
8539 (sub_char_table_ref_and_range): Likewise.
8540 (char_table_ref_and_range): Uncompress the compressed values.
8541 (sub_char_table_set): New arg is_uniprop. Callers changed.
8542 Uncompress the compressed values.
8543 (sub_char_table_set_range): Args changed. Callers changed.
8544 (char_table_set_range): Adjuted for the above change.
8545 (map_sub_char_table): Delete args default_val and parent. Add arg
8546 top. Give decoded values to a Lisp function.
8547 (map_char_table): Adjust for the above change. Give decoded
8548 values to a Lisp function. Gcpro more variables.
8549 (uniprop_table_uncompress)
8550 (uniprop_decode_value_run_length): New functions.
8551 (uniprop_decoder, uniprop_decoder_count): New variables.
8552 (uniprop_get_decoder, uniprop_encode_value_character)
8553 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8555 (uniprop_encoder, uniprop_encoder_count): New variables.
8556 (uniprop_get_encoder, uniprop_table)
8557 (Funicode_property_table_internal, Fget_unicode_property_internal)
8558 (Fput_unicode_property_internal): New functions.
8559 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8560 Sunicode_property_table_internal, Sget_unicode_property_internal,
8561 and Sput_unicode_property_internal. Defvar_lisp
8562 char-code-property-alist.
8564 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8565 Vunicode_category_table.
8567 * font.c (font_range): Adjust for the change of
8568 Vunicode_category_table.
8570 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8572 * m/iris4d.h: Remove file, move contents ...
8573 * s/irix6-5.h: ... here.
8575 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8577 Remove unportable assumption about struct layout (Bug#8884).
8578 * alloc.c (mark_buffer):
8579 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8580 (clone_per_buffer_values): Don't assume that
8581 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8582 This isn't true in general, and it's particularly not true
8583 if Emacs is configured with --with-wide-int.
8584 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8585 New macros, used in the buffer.c change.
8587 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8589 * xsettings.c: Use both GConf and GSettings if both are available.
8590 (store_config_changed_event): Add comment.
8591 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8592 (store_tool_bar_style_changed): New functions.
8593 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8594 (struct xsettings): Move font inside HAVE_XFT.
8595 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8596 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8597 Move inside HAVE_XFT.
8598 (something_changed_gsettingsCB): Rename from something_changedCB.
8599 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8601 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8602 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8603 (something_changed_gconfCB): Rename from something_changedCB.
8604 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8605 (parse_settings): Move check for font inside HAVE_XFT.
8606 (read_settings, apply_xft_settings): Add comment.
8607 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8608 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8609 call store_font_name_changed.
8610 (xft_settings_event): Add comment.
8611 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8612 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8613 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8614 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8615 (xsettings_initialize): Call init_gsettings last.
8616 (xsettings_get_system_font, xsettings_get_system_normal_font):
8619 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8621 Random fixes. E.g., (random) never returned negative values.
8622 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8623 subseconds part to the entropy, as that's a bit more random.
8624 Prefer signed to unsigned, since the signedness doesn't matter and
8625 in general we prefer signed. When given a limit, use a
8626 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8627 latter isn't right if USE_2_TAGS_FOR_INTS.
8628 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8629 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8631 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8633 * textprop.c (text_property_stickiness):
8634 Obey Vtext_property_default_nonsticky.
8635 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8636 * w32fns.c (syms_of_w32fns):
8637 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8639 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8641 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8642 This is more efficient than Ffile_directory_p and avoids a minor race.
8644 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8646 * buffer.c (Foverlay_put): Say what the return value is
8649 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8650 is a directory before asking whether to use the file name
8652 (barf_or_query_if_file_exists): Make the "File is a directory"
8653 error be more correct.
8655 * fns.c (Frequire): Remove the mention of the .gz files, since
8656 that's installation-specific, but keep the mention of
8657 `get-load-suffixes'.
8659 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8661 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8662 Report string overflow if the output is too long.
8664 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8666 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8667 (syms_of_gnutls): Remove duplicate DEFSYM for
8668 Qgnutls_bootprop_verify_hostname_error, an error for
8669 Qgnutls_bootprop_verify_error (which is no longer used).
8671 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8672 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8673 Also (re)move comments that are misplaced or no longer relevant.
8675 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8677 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8679 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8681 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8682 and background color parameters if they have been changed.
8684 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8686 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8688 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8690 * xsettings.c (SYSTEM_FONT): Define only when used.
8691 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8693 * keymap.c (access_keymap_1): Now static.
8695 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8697 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8698 leave any prefix arg for the up event (Bug#1586).
8700 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8702 * lread.c (syms_of_lread): Mention single symbols defined by
8703 `defvar' or `defconst' (bug#7154).
8705 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8706 (Frequire): Mention get-load-suffixes.
8708 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8710 * window.h (window): Remove clone_number slot.
8711 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8713 (make_parent_window, make_window, saved_window)
8714 (Fset_window_configuration, save_window_save): Don't deal with
8716 * buffer.c (Qclone_number): Remove declaration.
8717 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8719 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8721 Add multiple inheritance to keymaps.
8722 * keymap.c (Fmake_composed_keymap): New function.
8723 (Fset_keymap_parent): Simplify.
8724 (fix_submap_inheritance): Remove.
8725 (access_keymap_1): New function extracted from access_keymap to handle
8726 embedded parents and handle lists of maps.
8727 (access_keymap): Use it.
8728 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8729 (Fcopy_keymap): Handle embedded parents.
8730 (Fcommand_remapping, define_as_prefix): Simplify.
8731 (Fkey_binding): Simplify.
8732 (syms_of_keymap): Move minibuffer-local-completion-map,
8733 minibuffer-local-filename-completion-map,
8734 minibuffer-local-must-match-map, and
8735 minibuffer-local-filename-must-match-map to Elisp.
8736 (syms_of_keymap): Defsubr make-composed-keymap.
8737 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8738 (parse_menu_item): Trivial simplification.
8740 2011-07-01 Glenn Morris <rgm@gnu.org>
8742 * Makefile.in (SETTINGS_LIBS): Fix typo.
8744 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8746 * coding.c (Fencode_coding_string): Record the last coding system
8747 used, as the function doc string says (bug#8738).
8749 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8751 * xsettings.c (store_monospaced_changed): Take new font as arg and
8752 check for change against current_mono_font.
8753 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8754 (emacs_settings_constructor, emacs_settings_get_property)
8755 (emacs_settings_set_property, emacs_settings_class_init)
8756 (emacs_settings_init, gsettings_obj): Remove.
8757 (something_changedCB): New function for HAVE_GSETTINGS.
8758 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8759 with value as argument.
8760 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8761 g_settings_new (Bug#8967). Do not create gsettings_obj.
8762 Remove calls to g_settings_bind. Connect something_changedCB to
8765 * xgselect.c: Add defined (HAVE_GSETTINGS).
8766 (xgselect_initialize): Ditto.
8768 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8769 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8772 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8774 * eval.c (struct backtrace): Simplify and port the data structure.
8775 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8776 signed bit field, as this assumption is not portable and it makes
8777 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8778 "char debug_on_exit : 1" as this is not portable either; instead,
8779 use the portable "unsigned int debug_on_exit : 1". Remove unused
8780 member evalargs. Remove obsolete comments about cc bombing out.
8782 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8784 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8785 Let HAVE_GSETTINGS override HAVE_GCONF.
8786 (store_monospaced_changed): New function.
8787 (EMACS_SETTINGS): A new type derived from GObject to handle
8788 GSettings notifications.
8789 (emacs_settings_constructor, emacs_settings_get_property)
8790 (emacs_settings_set_property, emacs_settings_class_init):
8792 (gsettings_client, gsettings_obj): New variables.
8793 (GSETTINGS_SCHEMA): New define.
8794 (something_changedCB): Call store_monospaced_changed.
8795 (init_gsettings): New function.
8796 (xsettings_initialize): Call init_gsettings.
8797 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8800 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8803 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8805 * window.c (resize_root_window, grow_mini_window)
8806 (shrink_mini_window): Rename Qresize_root_window to
8807 Qwindow_resize_root_window and Qresize_root_window_vertically to
8808 Qwindow_resize_root_window_vertically.
8810 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8812 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8814 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8816 * makefile.w32-in: Redesign dependencies so they reflect more
8817 clearly which files are directly included by each source file,
8818 and not through other includes.
8820 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8822 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8823 (sort_overlays, overlay_strings): When an overlay's clone number
8824 matches the window's clone number process the overlay even if
8825 the overlay's window property doesn't match the current window.
8827 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8828 (Fwindow_hchild): Rename to Fwindow_left_child.
8829 (Fwindow_next): Rename to Fwindow_next_sibling.
8830 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8831 (resize_window_check): Rename to window_resize_check.
8832 (resize_window_apply): Rename to window_resize_apply.
8833 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8834 (Fdelete_other_windows_internal, resize_frame_windows)
8835 (Fsplit_window_internal, Fdelete_window_internal)
8836 (grow_mini_window, shrink_mini_window)
8837 (Fresize_mini_window_internal): Fix callers accordingly.
8839 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8841 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8842 (emacs_fixed_set_min_size): Remove.
8843 (emacs_fixed_new): Take frame as argument.
8845 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8846 (_EmacsFixedPrivate): Remove minwidth/height.
8847 Add struct frame *f.
8848 (emacs_fixed_init): Initialize priv->f.
8849 (get_parent_class, emacs_fixed_set_min_size): Remove.
8850 (emacs_fixed_new): Set priv->f to argument.
8851 (emacs_fixed_get_preferred_width)
8852 (emacs_fixed_get_preferred_height): Use min_width/height from
8853 frames size_hint to set minimum and natural (Bug#8919).
8854 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8855 and use min_width/height from frames size_hint to set
8856 min_width/height (Bug#8919).
8858 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8859 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8862 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8864 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8865 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8868 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8870 * process.c (wait_reading_process_output): Bypass select if
8871 waiting for a cell while ignoring keyboard input, and input is
8872 pending. Suggested by Jan Djärv (Bug#8869).
8874 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8876 Use gnulib's dup2 module instead of rolling our own.
8877 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8879 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8881 * dispnew.c (scrolling_window): Before scrolling, turn off a
8882 mouse-highlight in the window being scrolled.
8884 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8886 Move DEFSYM to lisp.h and use everywhere.
8888 * character.h (DEFSYM): Move declaration...
8889 * lisp.h (DEFSYM): ...here.
8895 * w32select.c: Don't include character.h.
8897 * alloc.c (syms_of_alloc):
8898 * buffer.c (syms_of_buffer):
8899 * bytecode.c (syms_of_bytecode):
8900 * callint.c (syms_of_callint):
8901 * casefiddle.c (syms_of_casefiddle):
8902 * casetab.c (init_casetab_once):
8903 * category.c (init_category_once, syms_of_category):
8904 * ccl.c (syms_of_ccl):
8905 * cmds.c (syms_of_cmds):
8906 * composite.c (syms_of_composite):
8907 * dbusbind.c (syms_of_dbusbind):
8908 * dired.c (syms_of_dired):
8909 * dispnew.c (syms_of_display):
8910 * doc.c (syms_of_doc):
8911 * editfns.c (syms_of_editfns):
8912 * emacs.c (syms_of_emacs):
8913 * eval.c (syms_of_eval):
8914 * fileio.c (syms_of_fileio):
8915 * fns.c (syms_of_fns):
8916 * frame.c (syms_of_frame):
8917 * fringe.c (syms_of_fringe):
8918 * insdel.c (syms_of_insdel):
8919 * keymap.c (syms_of_keymap):
8920 * lread.c (init_obarray, syms_of_lread):
8921 * macros.c (syms_of_macros):
8922 * msdos.c (syms_of_msdos):
8923 * print.c (syms_of_print):
8924 * process.c (syms_of_process):
8925 * search.c (syms_of_search):
8926 * sound.c (syms_of_sound):
8927 * syntax.c (init_syntax_once, syms_of_syntax):
8928 * terminal.c (syms_of_terminal):
8929 * textprop.c (syms_of_textprop):
8930 * undo.c (syms_of_undo):
8931 * w32.c (globals_of_w32):
8932 * window.c (syms_of_window):
8933 * xdisp.c (syms_of_xdisp):
8934 * xfaces.c (syms_of_xfaces):
8935 * xfns.c (syms_of_xfns):
8936 * xmenu.c (syms_of_xmenu):
8937 * xsettings.c (syms_of_xsettings):
8938 * xterm.c (syms_of_xterm): Use DEFSYM.
8940 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8942 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8944 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8946 Integer and buffer overflow fixes (Bug#8873).
8948 * print.c (printchar, strout): Check for string overflow.
8949 (PRINTPREPARE, printchar, strout):
8950 Don't set size unless allocation succeeds.
8952 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8953 for sizes. Check for string overflow more accurately.
8954 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8956 * macros.c: Integer and buffer overflow fixes.
8957 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8958 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8959 Use ptrdiff_t, not int, for sizes.
8960 Don't increment bufsize until after realloc succeeds.
8961 Check for size-calculation overflow.
8962 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8964 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8966 * lread.c: Integer overflow fixes.
8967 (read_integer): Radix is now EMACS_INT, not int,
8968 to improve quality of diagnostics for out-of-range radices.
8969 Calculate buffer size correctly for out-of-range radices.
8970 (read1): Check for integer overflow in radices, and in
8971 read-circle numbers.
8972 (read_escape): Avoid int overflow.
8973 (Fload, openp, read_buffer_size, read1)
8974 (substitute_object_recurse, read_vector, read_list, map_obarray):
8975 Use ptrdiff_t, not int, for sizes.
8976 (read1): Use EMACS_INT, not int, for sizes.
8977 Check for size overflow.
8979 * image.c (cache_image): Check for size arithmetic overflow.
8981 * lread.c: Integer overflow issues.
8982 (saved_doc_string_size, saved_doc_string_length)
8983 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8984 Now ptrdiff_t, not int.
8985 (read1): Don't assume doc string length fits in int. Check for
8986 out-of-range doc string lengths.
8987 (read_list): Don't assume file position fits in int.
8988 (read_escape): Check for hex character overflow.
8990 2011-06-22 Leo Liu <sdl.web@gmail.com>
8992 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8993 Move to minibuffer.el.
8995 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8997 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8998 The following patches are for when GLYPH_DEBUG && !XASSERT.
8999 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9000 * dispnew.c (flush_stdout):
9001 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9002 Mark as externally visible.
9003 * dispnew.c (check_window_matrix_pointers): Now static.
9004 * dispnew.c (window_to_frame_vpos):
9005 * xfns.c (unwind_create_frame):
9006 * xterm.c (x_check_font): Remove unused local.
9007 * scroll.c (CHECK_BOUNDS):
9008 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9009 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9010 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9011 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9012 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9014 (debug_method_add): Use va_list and vsprintf rather than relying
9015 on undefined behavior with wrong number of arguments.
9016 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9017 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9018 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9019 since we're not interested in debugging glyphs with old libraries.
9020 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9021 GCC 4.6.0's static checking.
9023 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9025 Integer overflow and signedness fixes (Bug#8873).
9026 A few related buffer overrun fixes, too.
9028 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9030 * dispextern.h (struct face.stipple):
9031 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9032 (x_bitmap_mask, x_allocate_bitmap_record)
9033 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9034 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9035 (x_create_bitmap_from_xpm_data):
9036 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9037 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9039 * xfaces.c (load_pixmap):
9040 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9041 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9042 (.bitmaps_last, struct x_output.icon_bitmap):
9043 Use ptrdiff_t, not int, for bitmap indexes.
9044 (x_allocate_bitmap_record): Check for size overflow.
9045 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9047 Use ptrdiff_t, not int, for overlay counts.
9048 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9049 * editfns.c (overlays_around, get_pos_property):
9050 * textprop.c (get_char_property_and_overlay):
9051 * xdisp.c (next_overlay_change, note_mouse_highlight):
9052 * xfaces.c (face_at_buffer_position):
9053 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9054 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9055 (Fnext_overlay_change, Fprevious_overlay_change)
9056 (mouse_face_overlay_overlaps, Foverlays_in):
9057 Use ptrdiff_t, not int, for sizes.
9058 (overlays_at, overlays_in): Check for size-calculation overflow.
9060 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9062 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9063 (x_session_initialize): Do not assume string length fits in int.
9065 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9066 This is unlikely, but can occur if DPI is outlandish.
9068 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9069 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9071 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9072 * xrdb.c (magic_file_p, search_magic_path):
9073 Omit last arg SUFFIX; it was always 0. All callers changed.
9074 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9076 * xfont.c (xfont_match): Avoid need for strlen.
9078 * xfns.c: Don't assume strlen fits in int.
9079 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9081 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9082 not unsigned long, as we prefer signed integers. All callers changed.
9083 Detect integer overflow in repeat count.
9084 (message_dolog): Don't assume print length fits in 39 bytes.
9085 (display_mode_element): Don't assume strlen fits in int.
9087 * termcap.c: Don't assume sizes fit in int and never overflow.
9088 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9089 (gobble_line): Check for size-calculation overflow.
9091 * minibuf.c (Fread_buffer):
9092 * lread.c (intern, intern_c_string):
9093 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9094 Don't assume string length fits in int.
9096 * keyboard.c (parse_tool_bar_item):
9097 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9099 * font.c: Don't assume string length fits in int.
9100 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9101 Use ptrdiff_t, not int.
9102 (font_intern_prop): Don't assume string length fits in int.
9103 Don't assume integer property fits in fixnum.
9104 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9106 * filelock.c: Fix some buffer overrun and integer overflow issues.
9107 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9108 Reformulate so as not to need the command string.
9109 Invoke gzip -cd rather than gunzip, as it's more portable.
9110 (lock_info_type, lock_file_1, lock_file):
9111 Don't assume pid_t and time_t fit in unsigned long.
9112 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9113 (current_lock_owner): Prefer signed type for sizes.
9114 Use memcpy, not strncpy, where memcpy is what is really wanted.
9115 Don't assume (via atoi) that time_t and pid_t fit in int.
9116 Check for time_t and/or pid_t out of range, e.g., via a network share.
9117 Don't alloca where an auto var works fine.
9119 * fileio.c: Fix some integer overflow issues.
9120 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9121 Don't assume string length fits in int.
9122 (directory_file_name): Don't assume string length fits in long.
9123 (make_temp_name): Don't assume pid fits in int, or that its print
9124 length is less than 20.
9126 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9128 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9130 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9132 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9133 We prefer signed integers, even for size calculations.
9135 * emacs.c: Don't assume string length fits in 'int'.
9136 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9137 (main): Don't invoke strlen when not needed.
9139 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9140 (XD_DEBUG_MESSAGE): Don't waste a byte.
9142 * callproc.c (getenv_internal_1, getenv_internal)
9144 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9146 * lread.c (invalid_syntax): Omit length argument.
9147 All uses changed. This doesn't fix a bug, but it simplifies the
9148 code away from its former Hollerith-constant appearance, and it's
9149 one less 'int' to worry about when looking at integer-overflow issues.
9150 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9152 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9153 This didn't break anything, but it didn't help either.
9154 It's confusing to put a bogus integer in a place where the actual
9155 value does not matter.
9156 (LIST_END_P): Remove unused macro and its bogus comment.
9157 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9159 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9160 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9162 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9163 We prefer signed types, and the value cannot exceed the EMACS_INT
9164 range anyway (because otherwise the length would not be representable).
9165 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9166 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9167 This avoids a GCC warning when WIDE_EMACS_INT.
9169 * indent.c (sane_tab_width): New function.
9170 (current_column, scan_for_column, Findent_to, position_indentation)
9171 (compute_motion): Use it. This is just for clarity.
9172 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9174 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9176 * lisp.h (lint_assume): New macro.
9177 * composite.c (composition_gstring_put_cache):
9178 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9180 * editfns.c, insdel.c:
9181 Omit unnecessary forward decls, to simplify future changes.
9183 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9185 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9187 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9188 Use much-faster test for byte-length change.
9189 Don't assume string byte-length fits in 'int'.
9190 Check that character arg fits in 'int'.
9191 (mapcar1): Declare byte as byte, for clarity.
9193 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9195 * fns.c (concat): Catch string overflow earlier.
9196 Do not rely on integer wraparound.
9198 * dispextern.h (struct it.overlay_strings_charpos)
9199 (struct it.selective): Now EMACS_INT, not int.
9200 * xdisp.c (forward_to_next_line_start)
9201 (back_to_previous_visible_line_start)
9202 (reseat_at_next_visible_line_start, next_element_from_buffer):
9203 Don't arbitrarily truncate the value of 'selective' to int.
9205 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9207 * composite.c: Don't truncate sizes to 'int'.
9208 (composition_gstring_p, composition_reseat_it)
9209 (composition_adjust_point): Use EMACS_INT, not int.
9210 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9211 not EMACS_UINT, for indexes.
9213 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9215 * buffer.c: Include <verify.h>.
9216 (struct sortvec.priority, struct sortstr.priority):
9217 Now EMACS_INT, not int.
9218 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9219 (struct sortstr.size, record_overlay_string)
9220 (struct sortstrlist.size, struct sortlist.used):
9221 Don't truncate size to int.
9222 (record_overlay_string): Check for size-calculation overflow.
9223 (init_buffer_once): Check at compile-time, not run-time.
9225 2011-06-22 Jim Meyering <meyering@redhat.com>
9227 Don't leak an XBM-image-sized buffer
9228 * image.c (xbm_load): Free the image buffer after using it.
9230 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9233 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9234 that Sun C diagnosed.
9235 * fns.c (secure_hash): Fix pointer signedness issue.
9236 * intervals.c (static_offset_intervals): New function.
9237 (offset_intervals): Use it.
9239 2011-06-21 Leo Liu <sdl.web@gmail.com>
9242 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9245 * fns.c (secure_hash): Rename from crypto_hash_function and change
9246 the first arg to accept symbols.
9247 (Fsecure_hash): New primitive.
9248 (syms_of_fns): New symbols.
9250 2011-06-20 Deniz Dogan <deniz@dogan.se>
9252 * process.c (Fset_process_buffer): Clarify return value in
9255 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9257 * dispnew.c (add_window_display_history): Use BVAR.
9259 * xdisp.c (debug_method_add): Use BVAR.
9260 (check_window_end, dump_glyph_matrix, dump_glyph)
9261 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9263 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9266 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9267 check till after the cache is created in init_frame_faces.
9269 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9271 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9273 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9275 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9276 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9277 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9279 Improve buffer-overflow checking (Bug#8873).
9280 * fileio.c (Finsert_file_contents):
9281 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9282 Remove the old (too-loose) buffer overflow checks.
9283 They weren't needed, since make_gap checks for buffer overflow.
9284 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9285 The old code merely checked for Emacs fixnum overflow, and relied
9286 on undefined (wraparound) behavior. The new code avoids undefined
9287 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9289 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9290 Tune. Don't use wider integers than needed. Don't use alloca.
9291 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9293 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9295 * insdel.c, lisp.h (buffer_overflow): New function.
9296 (insert_from_buffer_1, replace_range, replace_range_2):
9297 * insdel.c (make_gap_larger):
9298 * editfns.c (Finsert_char):
9299 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9301 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9303 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9305 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9307 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9308 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9310 * fileio.c: Don't assume EMACS_INT fits in off_t.
9311 (emacs_lseek): New static function.
9312 (Finsert_file_contents, Fwrite_region): Use it.
9313 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9315 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9317 * fns.c: Don't overflow int when computing a list length.
9318 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9319 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9320 truncation on 64-bit hosts. Check for QUIT every
9321 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9322 faster and is responsive enough.
9323 (Flength): Report an error instead of overflowing an integer.
9324 (Fsafe_length): Return a float if the value is not representable
9325 as a fixnum. This shouldn't happen except in contrived situations.
9326 (Fnthcdr, Fsort): Don't assume list length fits in int.
9327 (Fcopy_sequence): Don't assume vector length fits in int.
9329 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9330 (header_size, word_size): New constants.
9331 (allocate_vectorlike): Don't check size overflow here.
9332 (allocate_vector): Check it here instead, since this is the only
9333 caller of allocate_vectorlike that could cause overflow.
9334 Check that the new vector's length is representable as a fixnum.
9336 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9337 The previous code was bogus. For example, next_almost_prime (32)
9338 returned 39, which is undesirable as it is a multiple of 3; and
9339 next_almost_prime (24) returned 25, which is a multiple of 5 so
9340 why was the code bothering to check for multiples of 7?
9342 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9344 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9346 Variadic C functions now count arguments with ptrdiff_t.
9347 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9348 Back then I didn't know that the Emacs coding style prefers signed int.
9349 Also, in the meantime I found a few more instances where arguments
9350 were being counted with int, which may truncate counts on 64-bit
9351 machines, or EMACS_INT, which may be unnecessarily wide.
9352 * lisp.h (struct Lisp_Subr.function.aMANY)
9353 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9354 Arg counts are now ptrdiff_t, not size_t.
9355 All variadic functions and their callers changed accordingly.
9356 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9357 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9358 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9359 * callint.c (Fcall_interactively): Check arg count for overflow,
9360 to avoid potential buffer overrun. Use signed char, not 'int',
9361 for 'varies' array, so that we needn't bother to check its size
9362 calculation for overflow.
9363 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9364 * eval.c (apply_lambda):
9365 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9366 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9367 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9369 * callint.c (Fcall_interactively): Don't use index var as event count.
9371 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9372 * mem-limits.h (SIZE): Remove; no longer used.
9374 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9376 Remove unnecessary casts.
9377 * xterm.c (x_term_init):
9378 * xfns.c (x_set_border_pixel):
9379 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9380 These aren't needed now that we assume ANSI C.
9382 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9383 It's more likely to cause problems (due to unsigned overflow)
9386 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9388 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9390 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9392 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9394 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9396 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9398 GLYPH_CODE_FACE returns EMACS_INT, not int.
9399 * dispextern.h (merge_faces):
9400 * xfaces.c (merge_faces):
9401 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9402 Don't assume EMACS_INT fits in int.
9404 * character.h (CHAR_VALID_P): Remove unused parameter.
9405 * fontset.c, lisp.h, xdisp.c: All uses changed.
9407 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9409 * fns.c (concat): Minor tuning based on overflow analysis.
9410 This doesn't fix any bugs. Use int to hold character, instead
9411 of constantly refetching from Emacs object. Use XFASTINT, not
9412 XINT, for value known to be a character. Don't bother comparing
9413 a single byte to 0400, as it's always less.
9415 * floatfns.c (Fexpt):
9416 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9418 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9421 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9423 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9424 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9425 incorrectly succeed when S was a string, because 4294967386 was
9426 truncated before it was used.
9428 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9429 Otherwise, an out-of-range integer could cause undefined behavior
9432 * composite.c: Use int, not EMACS_INT, for characters.
9433 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9434 EMACS_INT, for values that are known to be in character range.
9435 This doesn't fix any bugs but is the usual style inside Emacs and
9436 may generate better code on 32-bit machines.
9438 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9439 This is for reasons similar to the recent CHAR_STRING fix.
9440 * charset.c (Fencode_char): Check that character arg is actually
9441 a character. Pass an int to ENCODE_CHAR.
9442 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9443 wider than 'int', as a compile-time check to prevent future regressions
9446 * character.c (char_string): Remove unnecessary casts.
9448 Make sure a 64-bit char is never passed to CHAR_STRING.
9449 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9450 by silently ignoring the top 32 bits, allowing some values
9451 that were far too large to be valid characters.
9452 * character.h: Include <verify.h>.
9453 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9454 arguments are no wider than unsigned, as a compile-time check
9455 to prevent future regressions in this area.
9457 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9458 (Fsubst_char_in_region):
9460 * xdisp.c (decode_mode_spec_coding):
9461 Adjust to CHAR_STRING's new requirement.
9462 * editfns.c (Finsert_char, Fsubst_char_in_region):
9463 * fns.c (concat): Check that character args are actually
9464 characters. Without this test, these functions did the wrong
9465 thing with wildly out-of-range values on 64-bit hosts.
9467 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9468 These casts should not be needed on 32-bit hosts, either.
9469 * keyboard.c (read_char):
9470 * lread.c (Fload): Remove casts to unsigned.
9472 * lisp.h (UNSIGNED_CMP): New macro.
9473 This fixes comparison bugs on 64-bit hosts.
9474 (ASCII_CHAR_P): Use it.
9475 * casefiddle.c (casify_object):
9476 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9477 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9478 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9479 * dispextern.h (FACE_FROM_ID):
9480 * keyboard.c (read_char): Use UNSIGNED_CMP.
9482 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9483 not to EMACS_INT, to avoid GCC warning.
9485 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9487 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9488 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9489 isn't needed on 32-bit machines.
9491 * buffer.c (Fgenerate_new_buffer_name):
9492 Use EMACS_INT for count, not int.
9493 (advance_to_char_boundary): Return EMACS_INT, not int.
9495 * data.c (Qcompiled_function): Now static.
9497 * window.c (window_body_lines): Now static.
9499 * image.c (gif_load): Rename local to avoid shadowing.
9501 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9502 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9503 * alloc.c (make_save_value): Integer argument is now of type
9505 (mark_object): Use ptrdiff_t, not int.
9506 * lisp.h (pD): New macro.
9507 * print.c (print_object): Use it.
9509 * alloc.c: Use EMACS_INT, not int, to count objects.
9510 (total_conses, total_markers, total_symbols, total_vector_size)
9511 (total_free_conses, total_free_markers, total_free_symbols)
9512 (total_free_floats, total_floats, total_free_intervals)
9513 (total_intervals, total_strings, total_free_strings):
9514 Now EMACS_INT, not int. All uses changed.
9515 (Fgarbage_collect): Compute overall total using a double, so that
9516 integer overflow is less likely to be a problem. Check for overflow
9517 when converting back to an integer.
9518 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9519 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9520 These were 'int' variables that could overflow on 64-bit hosts;
9521 they were never used, so remove them instead of repairing them.
9522 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9523 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9524 Previously, this ceilinged at INT_MAX, but that doesn't work on
9526 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9528 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9529 (allocate_vectorlike): Check for ptrdiff_t overflow.
9530 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9531 when a (possibly-narrower) signed value would do just as well.
9532 We prefer using signed arithmetic, to avoid comparison confusion.
9534 * alloc.c: Catch some string size overflows that we were missing.
9535 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9536 for convenience in STRING_BYTES_MAX.
9537 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9538 The definition here is exact; the one in lisp.h was approximate.
9539 (allocate_string_data): Check for string overflow. This catches
9540 some instances we weren't catching before. Also, it catches
9541 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9542 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9543 and ptrdiff_t and EMACS_INT are both 64 bits.
9545 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9546 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9547 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9549 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9551 * alloc.c (Fmake_string): Check for out-of-range init.
9553 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9555 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9557 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9559 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9560 xg_get_default_scrollbar_width.
9562 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9563 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9564 (style_changed_cb): Call update_theme_scrollbar_width and call
9565 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9566 all frames (Bug#8505).
9567 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9568 Call gtk_window_set_resizable if HAVE_GTK3.
9569 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9570 and height if HAVE_GTK3 (Bug#8505).
9571 (scroll_bar_width_for_theme): New variable.
9572 (update_theme_scrollbar_width): New function.
9573 (xg_get_default_scrollbar_width): Move code to
9574 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9575 (xg_initialize): Call update_theme_scrollbar_width.
9577 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9579 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9581 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9583 * frame.c (make_frame): Call other_buffer_safely instead of
9586 * window.c (temp_output_buffer_show): Call display_buffer with
9587 second argument Vtemp_buffer_show_specifiers and reset latter
9588 immediately after the call.
9589 (Vtemp_buffer_show_specifiers): New variable.
9590 (auto_window_vscroll_p, next_screen_context_lines)
9591 (Vscroll_preserve_screen_position): Remove leading asterisks from
9594 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9596 Fix minor problems found by GCC 4.6.0 static checking.
9597 * buffer.c (Qclone_number): Remove for now, as it's unused.
9598 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9599 (record_buffer): Remove unused local.
9600 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9601 (set_frame_buffer_list): Remove; unused.
9602 * frame.h (other_visible_frames): Remove decl.
9603 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9604 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9605 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9607 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9608 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9609 Define only if HAVE_GPM.
9610 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9611 (update_hints_inhibit): Remove; never set. All uses removed.
9612 * widgetprv.h (emacsFrameClassRec): Remove decl.
9613 * window.c (delete_deletable_window): Now returns void, since it
9614 wasn't returning anything.
9615 (compare_window_configurations): Remove unused locals.
9616 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9617 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9618 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9619 the same widths as pointers. This follows up on the 2011-05-06 patch.
9620 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9621 * xterm.h: Likewise.
9622 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9624 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9626 * makefile.w32-in: Update dependencies.
9627 (LISP_H): Add lib/intprops.h.
9629 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9631 * image.c (gif_load): Add animation frame delay to the metadata.
9632 (syms_of_image): Use DEFSYM. New symbol `delay'.
9634 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9636 * window.c (delete_deletable_window): Re-add.
9637 (Fset_window_configuration): Rewrite to handle dead buffers and
9638 consequently deletable windows.
9639 (window_tree, Fwindow_tree): Remove. Supply functionality in
9641 (compare_window_configurations): Simplify code.
9643 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9645 * image.c (imagemagick_load_image): Fix type mismatch.
9646 (Fimagemagick_types): Likewise.
9648 * window.h (replace_buffer_in_windows): Declare.
9650 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9652 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9653 Qclone_number. Remove external declaration of Qdelete_window.
9654 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9656 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9657 Run Qbuffer_list_update_hook if allowed.
9658 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9659 buffer list implementation.
9660 (other_buffer_safely): New function.
9661 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9662 calls to replace_buffer_in_windows and
9663 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9665 (record_buffer): Inhibit quitting and rewrite using quittable
9666 functions. Run Qbuffer_list_update_hook if allowed.
9667 (Frecord_buffer, Funrecord_buffer): New functions.
9668 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9669 Move switch-to-buffer to window.el.
9670 (bury-buffer): Move to window.el.
9671 (Vbuffer_list_update_hook): New variable.
9673 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9676 * window.h (resize_frame_windows): Move up in code.
9677 (Fwindow_frame): Remove EXFUN.
9678 (replace_buffer_in_all_windows): Remove prototype.
9679 (replace_buffer_in_windows_safely): Add prototype.
9681 * window.c: Declare Qdelete_window static again. Move down
9682 declaration of select_count.
9683 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9684 (Fother_window): Move to window.el.
9685 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9686 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9687 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9689 (replace_buffer_in_windows): Implement by calling
9690 Qreplace_buffer_in_windows.
9691 (replace_buffer_in_all_windows): Remove with some functionality
9692 moved into replace_buffer_in_windows_safely.
9693 (replace_buffer_in_windows_safely): New function.
9694 (select_window_norecord, select_frame_norecord): Move in front
9695 of run_window_configuration_change_hook. Remove now obsolete
9697 (Fset_window_buffer): Rewrite doc-string.
9698 Call Qrecord_window_buffer.
9699 (keys_of_window): Move binding for other-window to window.el.
9701 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9703 * dispextern.h (struct image): Replace data member, whose int_val
9704 and ptr_val fields were not used by anything, with a single
9707 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9708 (gif_clear_image, gif_load, imagemagick_load_image)
9709 (gs_clear_image, gs_load): Callers changed.
9711 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9713 * buffer.h: Include <time.h>, for time_t.
9714 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9716 Fix minor problems found by static checking.
9718 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9720 Make identifiers static if they are not used in other modules.
9721 * data.c (Qcompiled_function, Qframe, Qvector):
9722 * image.c (QimageMagick, Qsvg):
9723 * minibuf.c (Qmetadata):
9724 * window.c (resize_window_check, resize_root_window): Now static.
9725 * window.h (resize_window_check, resize_root_window): Remove decls.
9727 * window.c (window_deletion_count, delete_deletable_window):
9729 (window_body_lines): Now static.
9730 (Fdelete_other_windows_internal): Mark vars as initialized.
9731 Make sure 'resize_failed' is initialized.
9732 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9733 (resize_window_apply): Remove unused local.
9734 * window.h (delete_deletable_window): Remove decl.
9736 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9737 (imagemagick_load_image): Fix pointer signedness problem by changing
9738 last arg from unsigned char * to char *. All uses changed.
9739 Also, fix a local for similar reasons.
9740 Remove unused locals. Remove locals to avoid shadowing.
9741 (fn_rsvg_handle_free): Remove; unused.
9742 (svg_load, svg_load_image): Fix pointer signedness problem.
9743 (imagemagick_load_image): Don't use garbage pointer image_wand.
9745 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9747 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9749 * image.c (gif_load): Fix omitted cast error introduced by
9752 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9754 * window.h (resize_proportionally, orig_total_lines)
9755 (orig_top_line): Remove from window structure.
9756 (set_window_height, set_window_width, change_window_heights)
9757 (Fdelete_window): Remove prototypes.
9758 (resize_frame_windows): Remove duplicate declaration.
9760 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9762 * window.h (resize_frame_windows, resize_window_check)
9763 (delete_deletable_window, resize_root_window)
9764 (resize_frame_windows): Declare prototypes.
9766 * window.c (resize_window_apply): Make definition be "static" to
9767 match the prototype.
9769 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9771 * window.c: Remove declarations of Qwindow_size_fixed,
9772 window_min_size_1, window_min_size_2, window_min_size,
9773 size_window, window_fixed_size_p, enlarge_window, delete_window.
9774 Remove static from declaration of Qdelete_window, it's
9775 temporarily needed by Fbury_buffer.
9776 (replace_window): Don't assign orig_top_line and
9778 (Fdelete_window, delete_window): Remove. Window deletion is
9779 handled by window.el.
9780 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9781 Replace Fdelete_window calls with calls to Qdelete_window.
9782 (Fdelete_other_windows): Remove. Deleting other windows is
9783 handled by window.el.
9784 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9785 handled in window.el.
9786 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9787 Window minimum sizes are handled in window.el.
9788 (shrink_windows, size_window, set_window_height)
9789 (set_window_width, change_window_heights, window_height)
9790 (window_width, CURBEG, CURSIZE, enlarge_window)
9791 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9792 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9793 handled in window.el.
9794 (make_dummy_parent): Rename to make_parent_window and give it a
9795 second argument horflag.
9796 (make_window): Don't set resize_proportionally any more.
9797 (Fsplit_window): Remove. Windows are split in window.el.
9798 (save_restore_action, save_restore_orig_size)
9799 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9800 Resize mini windows in window.el.
9801 (grow_mini_window, shrink_mini_window): Implement by calling
9802 Qresize_root_window_vertically, resize_window_check and
9803 resize_window_apply.
9804 (saved_window, Fset_window_configuration, save_window_save):
9805 Do not handle orig_top_line, orig_total_lines, and
9806 resize_proportionally.
9807 (window_min_height, window_min_width): Move to window.el.
9808 (keys_of_window): Move bindings for delete-other-windows,
9809 split-window, delete-window and enlarge-window to window.el.
9811 * buffer.c: Temporarily extern Qdelete_window.
9812 (Fbury_buffer): Temporarily call Qdelete_window instead of
9813 Fdelete_window (Fbury_buffer will move to window.el soon).
9815 * frame.c (set_menu_bar_lines_1): Remove code handling
9816 orig_top_line and orig_total_lines.
9818 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9819 set_window_height but set heights directly.
9820 (change_frame_size_1): Use resize_frame_windows.
9822 * xdisp.c (init_xdisp): Don't use set_window_height but set
9825 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9826 Use resize_frame_windows instead of change_window_heights and run
9827 run_window_configuration_change_hook.
9829 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9830 instead of change_window_heights and run
9831 run_window_configuration_change_hook.
9833 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9835 * window.c (replace_window): Rename second argument REPLACEMENT to
9836 NEW. New third argument SETFLAG. Rewrite.
9837 (delete_window, make_dummy_parent): Call replace_window with
9839 (window_list_1): Move down in code.
9840 (run_window_configuration_change_hook): Move set_buffer part
9841 before select_frame_norecord part in order to unwind correctly.
9842 Rename count1 to count.
9843 (recombine_windows, delete_deletable_window, resize_root_window)
9844 (Fdelete_other_windows_internal)
9845 (Frun_window_configuration_change_hook, make_parent_window)
9846 (resize_window_check, resize_window_apply, Fresize_window_apply)
9847 (resize_frame_windows, Fsplit_window_internal)
9848 (Fdelete_window_internal, Fresize_mini_window_internal):
9850 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9852 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9854 * window.h (window): Add some new members to window structure -
9855 normal_lines, normal_cols, new_total, new_normal, clone_number,
9856 splits, nest, prev_buffers, next_buffers.
9857 (WINDOW_TOTAL_SIZE): Move here from window.c.
9858 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9860 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9862 (make_dummy_parent): Set new members of windows structure.
9863 (make_window): Move down in code. Handle new members of window
9865 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9866 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9867 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9868 (Fset_window_prev_buffers, Fwindow_next_buffers)
9869 (Fset_window_next_buffers, Fset_window_clone_number):
9871 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9872 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9874 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9875 Argument WINDOW can be now internal window too.
9876 (Fwindow_use_time): Move up in code.
9877 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9879 (Fset_window_configuration, saved_window)
9880 (Fcurrent_window_configuration, save_window_save): Handle new
9881 members of window structure.
9882 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9883 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9884 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9885 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9886 Qget_mru_window, Qresize_root_window,
9887 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9888 Qauto_buffer_name; staticpro them.
9890 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9892 * window.c (Fwindow_total_size, Fwindow_left_column)
9893 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9894 (Fwindow_list_1): New functions.
9895 (window_box_text_cols): Replace with window_body_cols.
9896 (Fwindow_width, Fscroll_left, Fscroll_right):
9897 Use window_body_cols instead of window_box_text_cols.
9898 (delete_window, Fset_window_configuration):
9899 Call delete_all_subwindows with window as argument.
9900 (delete_all_subwindows): Take a window as argument and not a
9902 (window_loop): Remove handling of GET_LRU_WINDOW and
9904 (Fget_lru_window, Fget_largest_window): Move to window.el.
9906 * window.h: Extern window_body_cols instead of
9907 window_box_text_cols. delete_all_subwindows now takes a
9908 Lisp_Object as argument.
9910 * indent.c (compute_motion, Fcompute_motion):
9911 Use window_body_cols instead of window_box_text_cols.
9913 * frame.c (delete_frame): Call delete_all_subwindows with root
9916 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9918 * fns.c (Fputhash): Document return value.
9920 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9922 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9924 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9926 Cons<->int and similar integer overflow fixes (Bug#8794).
9928 Check for overflow when converting integer to cons and back.
9929 * charset.c (Fdefine_charset_internal, Fdecode_char):
9930 Use cons_to_unsigned to catch overflow.
9931 (Fencode_char): Use INTEGER_TO_CONS.
9932 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9933 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9934 * data.c (long_to_cons, cons_to_long): Remove.
9935 (cons_to_unsigned, cons_to_signed): New functions.
9936 These signal an error for invalid or out-of-range values.
9937 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9938 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9939 * font.c (Ffont_variation_glyphs):
9940 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9941 * lisp.h: Include <intprops.h>.
9942 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9943 (cons_to_signed, cons_to_unsigned): New decls.
9944 (long_to_cons, cons_to_long): Remove decls.
9945 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9946 (Fprimitive_undo): Use CONS_TO_INTEGER.
9947 * xfns.c (Fx_window_property): Likewise.
9948 * xselect.c: Include <limits.h>.
9949 (x_own_selection, selection_data_to_lisp_data):
9950 Use INTEGER_TO_CONS.
9951 (x_handle_selection_request, x_handle_selection_clear)
9952 (x_get_foreign_selection, Fx_disown_selection_internal)
9953 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9954 (lisp_data_to_selection_data): Use cons_to_unsigned.
9955 (x_fill_property_data): Use cons_to_signed.
9956 Report values out of range.
9958 Check for buffer and string overflow more precisely.
9959 * buffer.h (BUF_BYTES_MAX): New macro.
9960 * lisp.h (STRING_BYTES_MAX): New macro.
9961 * alloc.c (Fmake_string):
9962 * character.c (string_escape_byte8):
9963 * coding.c (coding_alloc_by_realloc):
9964 * doprnt.c (doprnt):
9965 * editfns.c (Fformat):
9967 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9968 since they may not be the same number.
9969 * editfns.c (Finsert_char):
9970 * fileio.c (Finsert_file_contents):
9971 Likewise for BUF_BYTES_MAX.
9973 * image.c: Use ptrdiff_t, not int, for sizes.
9974 (slurp_file): Switch from int to ptrdiff_t.
9976 (slurp_file): Check that file size fits in both size_t (for
9977 malloc) and ptrdiff_t (for sanity and safety).
9979 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9980 if b->modtime has its maximal value.
9982 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9984 Don't assume time_t can fit into int.
9985 * buffer.h (struct buffer.modtime): Now time_t, not int.
9986 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9987 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9989 Minor fixes for signed vs unsigned integers.
9990 * character.h (MAYBE_UNIFY_CHAR):
9991 * charset.c (maybe_unify_char):
9992 * keyboard.c (read_char, reorder_modifiers):
9993 XINT -> XFASTINT, since the integer must be nonnegative.
9994 * ftfont.c (ftfont_spec_pattern):
9995 * keymap.c (access_keymap, silly_event_symbol_error):
9996 XUINT -> XFASTINT, since the integer must be nonnegative.
9997 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9998 since it makes no difference and we prefer signed.
9999 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10000 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10003 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10005 * window.h (Fwindow_frame): Declare.
10007 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10009 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10010 (SPARE_MEMORY): Always define.
10011 (LARGE_REQUEST): Remove.
10012 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10014 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10016 * lisp.h: Move EXFUNS for Fframe_root_window,
10017 Fframe_first_window and Fset_frame_selected_window to window.h.
10019 * window.h: Move EXFUNS for Fframe_root_window,
10020 Fframe_first_window and Fset_frame_selected_window here from
10023 * frame.c (Fwindow_frame, Fframe_first_window)
10024 (Fframe_root_window, Fframe_selected_window)
10025 (Fset_frame_selected_window): Move to window.c.
10026 (Factive_minibuffer_window): Move to minibuf.c.
10027 (Fother_visible_frames_p): New function.
10029 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10031 * window.c (decode_window, decode_any_window): Move up in code.
10032 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10033 (inhibit_frame_unsplittable): Remove unused variable.
10034 (Fwindow_buffer): Move up and rewrite doc-string.
10035 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10036 (Fwindow_prev): New functions.
10037 (Fwindow_frame): Move here from frame.c. Accept any window as
10039 (Fframe_root_window, Fframe_first_window)
10040 (Fframe_selected_window): Move here from frame.c. Accept frame
10041 or arbitrary window as argument. Update doc-strings.
10042 (Fminibuffer_window): Move up in code.
10043 (Fwindow_minibuffer_p): Move up in code and simplify.
10044 (Fset_frame_selected_window): Move here from frame.c.
10046 (Fselected_window, select_window, Fselect_window): Move up in
10047 code. Minor doc-string fixes.
10049 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10051 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10052 Do not assume that spare memory exists; that assumption is valid
10053 only if SYSTEM_MALLOC.
10054 (LARGE_REQUEST): New macro, so that the issue of large requests
10055 is separated from the issue of spare memory.
10057 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10059 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10062 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10064 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10067 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10069 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10071 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10073 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10074 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10076 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10078 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10080 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10082 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10083 (x_clipboard_manager_save): Add return value.
10084 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10085 New error handlers.
10086 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10087 Obey Vx_select_enable_clipboard_manager. Catch errors in
10088 x_clipboard_manager_save (Bug#8779).
10089 (Vx_select_enable_clipboard_manager): New variable.
10090 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10092 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10094 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10096 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10098 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10099 in the current matrix if keep_current_p is non-zero.
10101 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10103 * bidi.c (bidi_level_of_next_char): Fix last change.
10105 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10107 Support bidi reordering of text covered by display properties.
10109 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10110 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10111 (bidi_cache_search, bidi_cache_iterator_state)
10112 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10113 (bidi_level_of_next_char, bidi_move_to_visually_next):
10114 Support character positions inside a run of characters covered by a
10116 (bidi_paragraph_init, bidi_resolve_explicit_1)
10117 (bidi_level_of_next_char): Call bidi_fetch_char and
10118 bidi_fetch_char_advance instead of FETCH_CHAR and
10119 FETCH_CHAR_ADVANCE.
10120 (bidi_init_it): Initialize new members.
10121 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10123 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10124 instead of using explicit *_CHAR codes.
10125 (bidi_resolve_explicit, bidi_resolve_weak):
10126 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10127 bidirectional text is supported only in multibyte buffers.
10128 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10129 it to initialize the frame_window_p member of struct bidi_it.
10130 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10131 (bidi_resolve_explicit, bidi_resolve_weak)
10132 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10133 bidi_it->nchars is non-positive.
10134 (bidi_level_of_next_char): Don't try to lookup the cache for the
10135 next/previous character if nothing is cached there yet, or if we
10136 were just reseat()'ed to a new position.
10138 * xdisp.c (set_cursor_from_row): Set start and stop points
10139 according to the row's direction when priming the loop that looks
10140 for the glyph on which to display cursor.
10141 (single_display_spec_intangible_p): Function deleted.
10142 (display_prop_intangible_p): Reimplement to call
10143 handle_display_spec instead of single_display_spec_intangible_p.
10144 Accept 3 additional arguments needed by handle_display_spec.
10145 This fixes incorrect cursor motion across display property with complex
10146 values: lists, `(when COND...)' forms, etc.
10147 (single_display_spec_string_p): Support property values that are
10148 lists with the argument STRING its top-level element.
10149 (display_prop_string_p): Fix the condition for processing a
10150 property that is a list to be consistent with handle_display_spec.
10151 (handle_display_spec): New function, refactored from the
10152 last portion of handle_display_prop.
10153 (compute_display_string_pos): Accept additional argument
10154 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10155 value of a `display' property is a "replacing spec".
10156 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10157 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10158 the display property, but just return a value indicating whether
10159 the display property will replace the characters it covers.
10160 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10161 frame_window_p members of struct bidi_it.
10162 (compute_display_string_pos, compute_display_string_end):
10164 (push_it): Accept second argument POSITION, where pop_it should
10165 jump to continue iteration.
10166 (reseat_1): Initialize bidi_it.disp_pos.
10168 * keyboard.c (adjust_point_for_property): Adjust the call to
10169 display_prop_intangible_p to its new signature.
10171 * dispextern.h (struct bidi_it): New member frame_window_p.
10172 (bidi_init_it): Update prototypes.
10173 (display_prop_intangible_p): Update prototype.
10174 (compute_display_string_pos, compute_display_string_end):
10175 Declare prototypes.
10176 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10179 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10181 Malloc failure behavior now depends on size of allocation.
10182 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10183 * lisp.h: Change signatures accordingly.
10184 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10185 All callers changed. (Bug#8762)
10187 * gnutls.c: Use Emacs's memory allocators.
10188 Without this change, the gnutls library would invoke malloc etc.
10189 directly, which causes problems on non-SYNC_INPUT hosts, and which
10190 runs afoul of improving memory_full behavior. (Bug#8761)
10191 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10192 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10193 xfree instead of the default malloc, realloc, free.
10194 (Fgnutls_boot): No need to check for memory allocation failure,
10195 since xmalloc does that for us.
10197 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10198 * category.c (hash_get_category_set):
10199 * ccl.c (ccl_driver):
10200 * charset.c (Fdefine_charset_internal):
10201 * charset.h (struct charset.hash_index):
10202 * composite.c (get_composition_id, gstring_lookup_cache)
10203 (composition_gstring_put_cache):
10204 * composite.h (struct composition.hash_index):
10205 * dispextern.h (struct image.hash):
10206 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10207 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10208 (hashfn_equal, hashfn_user_defined, make_hash_table)
10209 (maybe_resize_hash_table, hash_lookup, hash_put)
10210 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10211 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10212 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10213 * image.c (make_image, search_image_cache, lookup_image)
10214 (xpm_put_color_table_h):
10215 * lisp.h (struct Lisp_Hash_Table):
10216 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10217 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10218 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10219 * alloc.c (allocate_vectorlike):
10220 Check for overflow in vector size calculations.
10221 * ccl.c (ccl_driver):
10222 Check for overflow when converting EMACS_INT to int.
10223 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10224 need to be updated by these changes.
10225 * fns.c (make_hash_table, maybe_resize_hash_table):
10226 Check for integer overflow with large hash tables.
10227 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10228 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10229 (SXHASH_REDUCE): New macro.
10230 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10231 Use it instead of discarding useful hash info with large hash values.
10232 (sxhash_float): New function.
10233 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10234 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10235 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10236 Rewrite to use FIXNUM_BITS, as this simplifies things.
10237 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10238 Adjust signatures to match updated version of code.
10239 (consing_since_gc): Now EMACS_INT, since a single hash table can
10240 use more than INT_MAX bytes.
10242 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10244 Make it possible to build with GCC-4.6+ -O2 -flto.
10246 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10248 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10250 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10251 Call minibuffer-inactive-mode.
10253 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10255 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10256 Update dependencies.
10258 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10260 * data.c (init_data): Remove code for UTS, this system is not
10263 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10265 Don't force ./temacs to start in terminal mode.
10267 * frame.c (make_initial_frame): Initialize faces in all cases, not
10268 only when CANNOT_DUMP is defined.
10269 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10271 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10273 * dispnew.c (add_window_display_history): Use const for the string
10274 pointer. Remove declaration, not needed.
10276 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10278 Use 'inline', not 'INLINE'.
10279 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10280 * alloc.c, fontset.c (INLINE): Remove.
10281 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10282 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10283 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10284 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10285 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10287 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10289 Make it possible to run ./temacs.
10291 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10292 syms_of_callproc does the same thing. Remove test for
10293 "initialized", do it in the caller.
10294 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10296 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10298 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10299 (read_minibuf): Use get_minibuffer.
10300 (syms_of_minibuf): Use DEFSYM.
10301 (Qmetadata): New var.
10302 * data.c (Qbuffer): Don't make it static.
10303 (syms_of_data): Use DEFSYM.
10305 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10307 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10308 (CCL_CODE_MIN): New macro.
10310 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10312 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10314 * eval.c (Qdebug): Now static.
10315 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10316 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10317 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10319 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10321 * image.c: Various fixes to ImageMagick code comments.
10322 (Fimagemagick_types): Doc fix.
10324 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10326 Minor fixes prompted by GCC 4.6.0 warnings.
10328 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10330 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10331 (x_clipboard_manager_save_all): Move extern decl to ...
10332 * xterm.h: ... here, so that it can be checked for consistency.
10334 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10336 * xselect.c (x_clipboard_manager_save_frame)
10337 (x_clipboard_manager_save_all): New functions.
10338 (Fx_clipboard_manager_save): Lisp function deleted.
10340 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10341 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10343 * xterm.h: Update prototype.
10345 2011-05-28 William Xu <william.xwl@gmail.com>
10347 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10348 exiting (Bug#8239).
10350 2011-05-28 Jim Meyering <meyering@redhat.com>
10352 Avoid a sign-extension bug in crypto_hash_function.
10353 * fns.c (to_uchar): Define.
10354 (crypto_hash_function): Use it to convert some newly-signed
10355 variables to unsigned, to avoid sign-extension bugs. For example,
10356 without this change, (md5 "truc") would evaluate to
10357 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10358 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10359 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10361 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10363 Integer overflow fixes.
10365 * dbusbind.c: Serial number integer overflow fixes.
10366 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10367 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10368 to hold a serial number that is too large for a fixnum.
10369 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10370 Check for serial numbers out of range. Decode any serial number
10371 that was so large that it became a float. (Bug#8722)
10373 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10374 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10375 Use XFASTINT rather than XUINT when numbers are nonnegative.
10376 (xd_append_arg, Fdbus_method_return_internal):
10377 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10378 arguments, check that Lisp number is nonnegative, rather than
10379 silently wrapping negative numbers around. (Bug#8722)
10380 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10383 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10385 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10387 ccl: Add integer overflow checks.
10388 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10389 (IN_INT_RANGE): New macros.
10390 (ccl_driver): Use them to check for integer overflow when
10391 decoding a CCL program. Many of the new checks are whether XINT (x)
10392 fits in int; it doesn't always, on 64-bit hosts. The new version
10393 doesn't catch all possible integer overflows, but it's an
10394 improvement. (Bug#8719)
10396 * alloc.c (make_event_array): Use XINT, not XUINT.
10397 There's no need for unsigned here.
10399 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10400 This follows up to the 2011-05-06 change that substituted uintptr_t
10401 for EMACS_INT. This case wasn't caught back then.
10403 Rework Fformat to avoid integer overflow issues.
10404 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10405 now (part of C89). Include <verify.h>.
10406 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10407 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10408 (Fformat): Avoid the prepass trying to compute sizes; it was only
10409 approximate and thus did not catch overflow reliably. Instead, walk
10410 through the format just once, formatting and computing sizes as we go,
10411 checking for integer overflow at every step, and allocating a larger
10412 buffer as needed. Keep track separately whether the format is
10413 multibyte. Keep only the most-recently calculated precision, rather
10414 than them all. Record whether each argument has been converted to
10415 string. Use EMACS_INT, not int, for byte and char and arg counts.
10416 Support field widths and precisions larger than INT_MAX. Avoid
10417 sprintf's undefined behavior with conversion specifications such as %#d
10418 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10419 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10420 formatting out-of-range floating point numbers with int
10421 formats. (Bug#8668)
10423 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10425 * data.c: Avoid integer truncation in expressions involving floats.
10426 * data.c: Include <intprops.h>.
10427 (arith_driver): When there's an integer overflow in an expression
10428 involving floating point, convert the integers to floating point
10429 so that the resulting value does not suffer from catastrophic
10430 integer truncation. For example, on a 64-bit host (* 4
10431 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10432 Do not rely on undefined behavior after integer overflow.
10434 merge count_size_as_multibyte, parse_str_to_multibyte
10435 * character.c, character.h (count_size_as_multibyte):
10436 Rename from parse_str_to_multibyte; all uses changed.
10437 Check for integer overflow.
10438 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10439 since it's now a duplicate of the other. This is more of
10440 a character than a buffer op, so better that it's in character.c.
10441 * fns.c, print.c: Adjust to above changes.
10443 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10445 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10447 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10449 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10450 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10451 (x_clipboard_manager_save): Now static.
10452 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10454 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10455 (crypto_hash_function): Now static.
10456 Fix pointer signedness problems. Avoid unnecessary initializations.
10458 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10460 * termhooks.h (Vselection_alist): Make it terminal-local.
10462 * terminal.c (create_terminal): Initialize it.
10464 * xselect.c: Support for clipboard managers.
10465 (Vselection_alist): Move to termhooks.h as terminal-local var.
10466 (LOCAL_SELECTION): New macro.
10467 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10468 (symbol_to_x_atom): Remove gratuitous arg.
10469 (x_handle_selection_request, lisp_data_to_selection_data)
10470 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10471 (x_own_selection, x_get_local_selection, x_convert_selection):
10472 New arg, specifying work frame. Use terminal-local Vselection_alist.
10473 (some_frame_on_display): Delete unused function.
10474 (Fx_own_selection_internal, Fx_get_selection_internal)
10475 (Fx_disown_selection_internal, Fx_selection_owner_p)
10476 (Fx_selection_exists_p): New optional frame arg.
10477 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10478 (x_handle_selection_clear): Don't treat other terminals with the
10479 same keyboard specially. Use the terminal-local Vselection_alist.
10480 (x_clear_frame_selections): Use Frun_hook_with_args.
10482 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10484 * xterm.h: Add support for those atoms.
10486 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10488 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10489 (converted_selections, conversion_fail_tag): New global variables.
10490 (x_selection_request_lisp_error): Free the above.
10491 (x_get_local_selection): Remove unnecessary code.
10492 (x_reply_selection_request): Args changed; handle arbitrary array
10493 of converted selections stored in converted_selections.
10494 Separate the XChangeProperty and SelectionNotify steps.
10495 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10496 (x_convert_selection): New function.
10497 (x_handle_selection_event): Simplify.
10498 (x_get_foreign_selection): Don't ignore incoming requests while
10499 waiting for an answer; this will fail when we implement
10500 SAVE_TARGETS, and seems unnecessary anyway.
10501 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10502 (Vx_sent_selection_functions): Doc fix.
10504 2011-05-26 Leo Liu <sdl.web@gmail.com>
10506 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10508 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10510 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10512 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10513 for fringe update if it has periodic bitmap.
10514 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10515 and fringe_bitmap_periodic_p.
10517 * fringe.c (get_fringe_bitmap_data): New function.
10518 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10519 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10520 row. Mark glyph row for fringe update if periodicity changed.
10522 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10523 for fringe update unless it has periodic bitmap.
10525 2011-05-25 Kenichi Handa <handa@m17n.org>
10527 * xdisp.c (get_next_display_element): Set correct it->face_id for
10528 a static composition.
10530 2011-05-24 Leo Liu <sdl.web@gmail.com>
10533 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10535 * fns.c (crypto_hash_function, Fsha1): New function.
10536 (Fmd5): Use crypto_hash_function.
10537 (syms_of_fns): Add Ssha1.
10539 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10541 * gnutls.c: Remove unused macros.
10542 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10543 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10544 Remove macros that are defined and never used.
10545 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10547 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10549 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10550 (Fx_get_selection_internal): Minor cleanup.
10551 (Fx_own_selection_internal): Rename arguments for consistency with
10554 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10556 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10558 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10560 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10562 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10564 * dispnew.c (scrolling_window): Don't exclude the case that the
10565 last enabled row in the desired matrix touches the bottom boundary.
10567 2011-05-21 Glenn Morris <rgm@gnu.org>
10569 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10570 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10571 and add some more files.
10573 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10575 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10576 report_file_error introduced by the change from 2011-05-07.
10578 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10580 * systime.h (Time): Define only if emacs is defined.
10581 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10582 where the include path doesn't have X11/X.h by default. See
10583 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10585 2011-05-20 Kenichi Handa <handa@m17n.org>
10587 * composite.c (find_automatic_composition): Fix previous change.
10589 2011-05-20 Glenn Morris <rgm@gnu.org>
10591 * lisp.mk: New file, split from Makefile.in.
10592 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10593 (shortlisp): Remove.
10594 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10596 2011-05-19 Glenn Morris <rgm@gnu.org>
10598 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10599 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10600 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10601 (lisp): Set the order to that of loadup.el.
10602 (shortlisp): Make it a copy of $lisp.
10603 (SOME_MACHINE_LISP): Remove.
10604 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10605 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10607 2011-05-18 Kenichi Handa <handa@m17n.org>
10609 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10610 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10611 (find_automatic_composition): Mostly rewrite for efficiency.
10613 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10615 * makefile.w32-in: Update dependencies.
10617 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10619 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10620 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10622 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10624 Fix some integer overflow issues, such as string length overflow.
10626 * insdel.c (count_size_as_multibyte): Check for string overflow.
10628 * character.c (lisp_string_width): Check for string overflow.
10629 Use EMACS_INT, not int, for string indexes and lengths; in
10630 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10631 the resulting string length overflows an EMACS_INT; instead,
10632 report a string overflow if no precision given. When checking for
10633 precision exhaustion, use a check that cannot possibly have
10634 integer overflow. (Bug#8675)
10635 * character.h (lisp_string_width): Adjust to new signature.
10637 * alloc.c (string_overflow): New function.
10638 (Fmake_string): Use it. This doesn't change behavior, but saves
10639 a few bytes and will simplify future changes.
10640 * character.c (string_escape_byte8): Likewise.
10641 * lisp.h (string_overflow): New decl.
10643 Fixups, following up to the user-interface timestamp change.
10644 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10645 for UI timestamps, instead of unsigned long.
10646 * msdos.c (mouse_get_pos): Likewise.
10647 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10648 * w32gui.h (Time): Define by including "systime.h" rather than by
10649 declaring it ourselves. (Bug#8664)
10651 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10652 * image.c (clear_image_cache): Likewise.
10654 * term.c (term_mouse_position): Don't assume time_t wraparound.
10656 Be more systematic about user-interface timestamps.
10657 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10658 and sometimes 'EMACS_UINT', to represent these timestamps.
10659 This change causes it to use 'Time' uniformly, as that's what X uses.
10660 This makes the code easier to follow, and makes it easier to catch
10661 integer overflow bugs such as Bug#8664.
10662 * frame.c (Fmouse_position, Fmouse_pixel_position):
10663 Use Time, not unsigned long, for user-interface timestamps.
10664 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10665 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10666 * keyboard.h (last_event_timestamp): Likewise.
10667 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10668 * menu.h (xmenu_show): Likewise.
10669 * term.c (term_mouse_position): Likewise.
10670 * termhooks.h (struct input_event.timestamp): Likewise.
10671 (struct terminal.mouse_position_hook): Likewise.
10672 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10673 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10674 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10675 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10676 what it was before.
10677 * menu.h, termhooks.h: Include "systime.h", for Time.
10679 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10680 Don't assume that the difference between two unsigned long values
10681 can fit into an integer. At this point, we know button_down_time
10682 <= event->timestamp, so the difference must be nonnegative, so
10683 there's no need to cast the result if double-click-time is
10684 nonnegative, as it should be; check that it's nonnegative, just in
10685 case. This bug is triggered when events are more than 2**31 ms
10686 apart (about 25 days). (Bug#8664)
10688 * xselect.c (last_event_timestamp): Remove duplicate decl.
10689 (x_own_selection): Remove needless cast to unsigned long.
10691 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10692 that always fit in int. Use a sentinel instead of a counter, to
10693 avoid a temp and to allay GCC's concerns about possible int overflow.
10694 * frame.h (struct frame): Use int for menu_bar_items_used
10695 instead of EMACS_INT, since it always fits in int.
10697 * menu.c (grow_menu_items): Check for int overflow.
10699 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10701 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10702 Before, the code was not consistent. These values cannot exceed
10703 2**31 - 1 so there's no need to make them unsigned.
10704 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10705 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10706 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10708 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10710 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10711 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10712 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10713 presumably because the widths might not match.
10715 * window.c (size_window): Avoid needless test at loop start.
10717 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10719 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10721 2011-05-12 Drew Adams <drew.adams@oracle.com>
10723 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10725 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10727 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10728 `width' to `bar_area_x' and `bar_area_width', respectively.
10729 (x_scroll_run): Take account of fringe background extension.
10731 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10732 Rename local vars `left' and `width' to `bar_area_x' and
10733 `bar_area_width', respectively.
10734 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10735 background extension.
10737 2011-05-10 Jim Meyering <meyering@redhat.com>
10739 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10741 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10743 * image.c (Finit_image_library): Return t for built-in image types,
10744 like pbm and xbm. (Bug#8640)
10746 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10748 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10750 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10752 * w32console.c (Fset_screen_color): Doc fix.
10753 (Fget_screen_color): New function.
10754 (syms_of_ntterm): Defsubr it.
10756 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10757 unlink the temporary file if Fcall_process didn't create it in the
10759 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10760 child process will be redirected to a file specified with `:file'.
10761 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10762 cue to call_process_cleanup not to close that handle.
10764 2011-05-07 Ben Key <bkey76@gmail.com>
10766 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10767 one of two shell specific rules, either bootstrap-temacs-CMD or
10768 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10769 to the previous implementation of the bootstrap-temacs rule.
10770 The bootstrap-temacs-CMD rule is similar to the previous
10771 implementation of the bootstrap-temacs rule except that it
10772 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10775 These changes, along with some changes to nt/configure.bat,
10776 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10777 earlier fix to add support for --cflags and --ldflags options
10778 that include quotes so that it works whether make uses cmd or
10781 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10783 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10784 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10786 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10787 a string. Handle both cases.
10788 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10789 (Fdbus_register_method): Use Qinvalid_function.
10791 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10793 * makefile.w32-in: Update dependencies.
10794 (LISP_H): Add inttypes.h and stdin.h.
10795 (PROCESS_H): Add unistd.h.
10797 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10799 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10800 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10802 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10804 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10806 * term.c (vfatal): Remove stray call to va_end.
10807 It's not needed and the C Standard doesn't allow it here anyway.
10809 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10810 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10812 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10815 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10817 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10819 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10821 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10823 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10825 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10826 * charset.c (Fdefine_charset_internal): Don't initialize
10827 charset.code_space[15]. The value was garbage, on hosts with
10828 32-bit int (Bug#8600).
10830 * lread.c (read_integer): Be more consistent with string-to-number.
10831 Use string_to_number to do the actual conversion; this avoids
10832 rounding errors and fixes some other screwups. Without this fix,
10833 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10834 (digit_to_number): Move earlier, for benefit of read_integer.
10835 Return -1 if the digit is out of range for the base, -2 if it is
10836 not a digit in any supported base. (Bug#8602)
10838 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10840 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10841 to match comment at start of function. This also removes a
10842 GCC warning about overflow in a 32+64-bit port.
10844 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10846 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10847 Reported by Stefan Monnier in
10848 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10849 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10850 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10852 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10853 (EMACS_UINTPTR): Likewise, with uintptr_t.
10855 * lisp.h: Prefer 64-bit EMACS_INT if available.
10856 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10857 on 32-bit hosts that have 64-bit int, so that they can access
10859 However, temporarily disable this change unless the temporary
10860 symbol WIDE_EMACS_INT is defined.
10862 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10864 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10865 This removes an assumption that EMACS_INT and long are the same
10866 width as pointers. The assumption is true for Emacs porting targets
10867 now, but we want to make other targets possible.
10868 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10869 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10870 In the rest of the code, change types of integers that hold casted
10871 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10872 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10873 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10874 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10875 No need to cast type when ORing.
10876 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10877 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10878 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10879 assume EMACS_INT is the same width as char *.
10880 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10881 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10882 Remove no-longer-needed casts.
10883 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10884 (xg_tool_bar_help_callback, xg_make_tool_item):
10885 Use EMACS_INTPTR to hold an integer
10886 that will be cast to void *; this can avoid a GCC warning
10887 if EMACS_INT is not the same width as void *.
10888 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10889 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10890 (current_message_1, set_message_1):
10891 Use a local to convert to proper width without a cast.
10892 * xmenu.c (dialog_selection_callback): Likewise.
10894 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10895 Also, don't assume VALBITS / RAND_BITS is less than 5,
10896 and don't rely on undefined behavior when shifting a 1 left into
10898 * lisp.h (get_random): Change signature to match.
10900 * lread.c (hash_string): Use size_t, not int, for hash computation.
10901 Normally we prefer signed values; but hashing is special, because
10902 it's better to use unsigned division on hash table sizes so that
10903 the remainder is nonnegative. Also, size_t is the natural width
10904 for hashing into memory. The previous code used 'int', which doesn't
10905 retain enough info to hash well into very large tables.
10906 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10908 * dbusbind.c: Don't possibly lose pointer info when converting.
10909 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10910 Use XPNTR rather than XHASH, so that the high-order bits of
10911 the pointer aren't lost when converting through void *.
10913 * eval.c (Fautoload): Don't double-shift a pointer.
10915 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10917 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10919 * gnutls.c (DEF_GNUTLS_FN):
10920 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10922 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10924 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10927 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10929 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10930 New version that can reserve upto 2GB of heap space.
10932 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10934 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10936 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10938 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10939 `gnutls_certificate_set_x509_key_file'.
10941 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10943 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10944 Update dependencies.
10946 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10948 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10949 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10950 Remove unused parameter `fildes'.
10951 * process.c (read_process_output, send_process): Don't pass it.
10953 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10955 Fix previous change: the library cache is defined in w32.c.
10956 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10957 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10959 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10961 Implement dynamic loading of GnuTLS on Windows.
10963 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10964 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10965 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10968 * gnutls.c (Qgnutls_dll): Define.
10969 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10970 (gnutls_*): Declare function pointers.
10971 (init_gnutls_functions): New function to initialize function pointers.
10972 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10973 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10974 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10975 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10976 (emacs_gnutls_write, emacs_gnutls_read)
10977 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10978 (Fgnutls_available_p): New function.
10979 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10980 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10981 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10983 * image.c: Include w32.h.
10984 (Vimage_type_cache): Delete.
10985 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10986 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10987 (w32_delayed_load): Move to w32.c.
10989 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10991 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10992 (w32_delayed_load): Move from image.c. When loading a library, record
10993 its filename in the :loaded-from property of the library id.
10994 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10995 Initialize and staticpro them.
10996 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10998 * process.c: Include lisp.h before w32.h, not after.
10999 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11000 instead of gnutls_record_check_pending.
11002 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11004 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11006 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11007 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11010 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11012 * xterm.c (x_set_frame_alpha): Do not set property on anything
11013 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11015 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11017 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11019 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11021 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11022 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11023 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11024 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11025 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11026 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11027 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11028 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11029 (Qgnutls_bootprop_callbacks_verify): Make static.
11031 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11033 * callproc.c: Indentation fixup.
11035 * sysdep.c (wait_for_termination_1): Make static.
11036 (wait_for_termination, interruptible_wait_for_termination):
11037 Move after wait_for_termination_1.
11039 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11041 * sysdep.c (interruptible_wait_for_termination): New function
11042 which is like wait_for_termination, but allows keyboard
11045 * callproc.c (Fcall_process): Add (:file "file") as an option for
11047 (Fcall_process_region): Ditto.
11049 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11051 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11052 rather than `XVECTOR (FOO)->size'.
11054 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11055 inttypes.h, as a gnulib replacement is used if it not available in
11058 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11060 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11061 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11062 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11064 * coding.c (coding_alloc_by_realloc): Error out if destination
11065 will grow beyond MOST_POSITIVE_FIXNUM.
11066 (decode_coding_emacs_mule): Abort if there isn't enough place in
11067 charbuf for the composition carryover bytes. Reserve an extra
11068 space for up to 2 characters produced in a loop.
11069 (decode_coding_iso_2022): Abort if there isn't enough place in
11070 charbuf for the composition carryover bytes.
11072 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11074 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11075 aborting when %lld or %lll format is passed.
11076 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11077 %llo or %llx format is passed. (Bug#8545)
11079 * window.c (window_scroll_line_based): Use a marker instead of
11080 simple variables to record original value of point. (Bug#7952)
11082 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11083 produced by %s or %c overflows available buffer space. (Bug#8545)
11085 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11087 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11088 (SIZE_MAX): Move defn after all includes, as they might #define it.
11090 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11092 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11094 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11096 * keyboard.c (Qdelayed_warnings_hook): Define.
11097 (command_loop_1): Run `delayed-warnings-hook'
11098 if Vdelayed_warnings_list is non-nil.
11099 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11100 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11102 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11104 * doprnt.c (doprnt): Don't return value smaller than the buffer
11105 size if the message was truncated. (Bug#8545).
11107 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11109 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11110 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11112 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11114 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11116 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11118 * makefile.w32-in: Update dependencies.
11120 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11122 Improve `doprnt' and its usage. (Bug#8545)
11123 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11124 `format_end'. Remove support for %l as a conversion specifier.
11125 Don't use xrealloc. Improve diagnostics when the %l size modifier
11126 is used. Update the commentary.
11128 * eval.c (verror): Simplify calculation of size_t.
11130 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11133 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11135 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11138 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11140 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11141 This makes this file independent of the recent pseudovector change.
11143 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11145 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11147 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11148 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11149 Remove unused local.
11150 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11152 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11153 GCC 4.6.0 optimizes based on type-based alias analysis.
11154 For example, if b is of type struct buffer * and v of type struct
11155 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11156 != &v->size, and therefore "v->size = 1; b->size = 2; return
11157 v->size;" must therefore return 1. This assumption is incorrect
11158 for Emacs, since it type-puns struct Lisp_Vector * with many other
11159 types. To fix this problem, this patch adds a new type struct
11160 vectorlike_header that documents the constraints on layout of vectors
11161 and pseudovectors, and helps optimizing compilers not get fooled
11162 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11163 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11164 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11166 (XSETPVECTYPE): Rewrite in terms of new macro.
11167 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11168 This is a bit clearer, and further avoids the possibility of
11169 undesirable aliasing.
11170 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11171 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11172 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11173 since Lisp_Subr is a special case (no "next" field).
11174 (ASIZE): Now uses header.size rather than size.
11175 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11176 to avoid the hassle of writing XVECTOR (foo)->header.size.
11177 (struct vectorlike_header): New type.
11178 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11179 object, to help avoid aliasing.
11180 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11181 (SUBRP): Likewise, since Lisp_Subr is a special case.
11182 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11183 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11184 (struct Lisp_Hash_Table): Combine first two members into a single
11185 struct vectorlike_header member. All uses of "size" and "next" members
11186 changed to be "header.size" and "header.next".
11187 * buffer.h (struct buffer): Likewise.
11188 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11189 * frame.h (struct frame): Likewise.
11190 * process.h (struct Lisp_Process): Likewise.
11191 * termhooks.h (struct terminal): Likewise.
11192 * window.c (struct save_window_data, struct saved_window): Likewise.
11193 * window.h (struct window): Likewise.
11194 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11195 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11196 * buffer.c (init_buffer_once): Likewise.
11197 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11199 * process.c (Fformat_network_address): Use local var for size,
11202 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11204 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11205 * data.c (atof): Remove decl; no longer used or needed.
11206 (digit_to_number): Move to lread.c.
11207 (Fstring_to_number): Use new string_to_number function, to be
11208 consistent with how the Lisp reader treats infinities and NaNs.
11209 Do not assume that floating-point numbers represent EMACS_INT
11210 without losing information; this is not true on most 64-bit hosts.
11211 Avoid double-rounding errors, by insisting on integers when
11212 parsing non-base-10 numbers, as the documentation specifies.
11213 * lisp.h (string_to_number): New decl, replacing ...
11214 (isfloat_string): Remove.
11215 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11216 (read1): Do not accept +. and -. as integers; this
11217 appears to have been a coding error. Similarly, do not accept
11218 strings like +-1e0 as floating point numbers. Do not report
11219 overflow for integer overflows unless the base is not 10 which
11220 means we have no simple and reliable way to continue.
11221 Break out the floating-point parsing into a new
11222 function string_to_number, so that Fstring_to_number parses
11223 floating point numbers consistently with the Lisp reader.
11224 (digit_to_number): Move here from data.c. Make it static inline.
11225 (E_CHAR, EXP_INT): Remove, replacing with ...
11226 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11227 (string_to_number): New function, replacing isfloat_string.
11228 This function checks for valid syntax and produces the resulting
11229 Lisp float number too. Rework it so that string-to-number
11230 no longer mishandles examples like "1.0e+". Use strtoumax,
11231 so that overflow for non-base-10 numbers is reported only when
11232 there's no portable and simple way to convert to floating point.
11234 * textprop.c (set_text_properties_1): Rewrite for clarity,
11235 and to avoid GCC warning about integer overflow.
11237 * intervals.h (struct interval): Use EMACS_INT for members
11238 where EMACS_UINT might cause problems. See
11239 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11240 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11241 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11243 (offset_intervals): Tell GCC not to worry about length overflow
11244 when negating a negative length.
11246 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11247 (overrun_check_free): Likewise.
11249 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11250 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11253 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11254 (gnutls_make_error): Rename local to avoid shadowing.
11255 (gnutls_emacs_global_deinit): ifdef out; not used.
11256 (Fgnutls_boot): Use const for pointer to readonly storage.
11257 Comment out unused local. Fix pointer signedness problems.
11259 * lread.c (openp): Don't stuff size_t into an 'int'.
11260 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11261 about possible signed overflow.
11263 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11264 (GDK_KEY_g): Don't define if already defined.
11265 (xg_prepare_tooltip): Avoid pointer signedness problem.
11266 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11268 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11269 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11271 * xfns.c (Fx_window_property): Simplify a bit,
11272 to make a bit faster and to avoid GCC 4.6.0 warning.
11273 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11275 * fns.c (internal_equal): Don't assume size_t fits in int.
11277 * alloc.c (compact_small_strings): Tighten assertion a little.
11279 Replace pEd with more-general pI, and fix some printf arg casts.
11280 * lisp.h (pI): New macro, generalizing old pEd macro to other
11281 conversion specifiers. For example, use "...%"pI"d..." rather
11282 than "...%"pEd"...".
11283 (pEd): Remove. All uses replaced with similar uses of pI.
11284 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11285 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11286 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11287 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11288 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11289 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11290 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11292 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11293 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11294 * print.c (safe_debug_print, print_object): Likewise.
11295 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11297 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11298 avoiding the 0 flag, which is not portable.
11299 * process.c (Fmake_network_process): Use pI to avoid cast.
11300 * region-cache.c (pp_cache): Likewise.
11301 * xdisp.c (decode_mode_spec): Likewise.
11302 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11303 behavior on 64-bit hosts with printf arg.
11304 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11305 (x_stop_queuing_selection_requests): Likewise.
11306 (x_get_window_property): Don't truncate byte count to an 'int'
11309 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11310 here, since it parses constructs like leading '-' and spaces,
11311 which are not wanted; and it overflows with large numbers.
11312 Instead, simply match F[0-9]+, which is what is wanted anyway.
11314 * alloc.c: Remove unportable assumptions about struct layout.
11315 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11316 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11317 (allocate_vectorlike, make_pure_vector): Use the new macros,
11318 plus offsetof, to remove unportable assumptions about struct layout.
11319 These assumptions hold on all porting targets that I know of, but
11320 they are not guaranteed, they're easy to remove, and removing them
11321 makes further changes easier.
11323 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11324 This doesn't fix a bug but makes the code clearer.
11325 (string_overrun_cookie): Now const. Use initializers that
11326 don't formally overflow signed char, to avoid warnings.
11327 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11328 can cause Emacs to crash when string overrun checking is enabled.
11329 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11330 multiple of sizeof (EMACS_INT); it need not be, if
11331 alignof(EMACS_INT) < sizeof (EMACS_INT).
11332 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11334 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11336 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11338 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11340 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11341 supposed to be handshaking. (Bug#8556)
11342 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11344 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11346 * lisp.h (Qdebug): List symbol.
11347 * eval.c (Qdebug): Restore global linkage.
11348 * keyboard.c (debug-on-event): New variable.
11349 (handle_user_signal): Break into debugger when debug-on-event
11350 matches the current signal symbol.
11352 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11354 * alloc.c (check_sblock, check_string_bytes)
11355 (check_string_free_list): Convert to standard C.
11357 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11359 * w32.c (emacs_gnutls_push): Fix typo.
11361 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11363 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11364 "cast to pointer from integer of different size".
11366 Improve doprnt and its use in verror. (Bug#8545)
11367 * doprnt.c (doprnt): Document the set of format control sequences
11368 supported by the function. Use SAFE_ALLOCA instead of always
11371 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11372 is one byte too soon. Don't use xrealloc; instead xfree and
11375 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11377 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11380 * gnutls.c: Renamed global_initialized to
11381 gnutls_global_initialized. Added internals for the
11382 :verify-hostname-error, :verify-error, and :verify-flags
11383 parameters of `gnutls-boot' and documented those parameters in the
11384 docstring. Start callback support.
11385 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11386 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11387 on error. Return error code.
11388 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11389 (emacs_gnutls_read): Likewise.
11390 (Fgnutls_boot): Return handshake error code.
11391 (emacs_gnutls_handle_error): New function.
11392 (wsaerror_to_errno): Likewise.
11394 * w32.h (emacs_gnutls_pull): Add prototype.
11395 (emacs_gnutls_push): Likewise.
11397 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11398 (emacs_gnutls_push): Likewise.
11400 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11402 * process.c (wait_reading_process_output): Check if GnuTLS
11403 buffered some data internally if no FDs are set for TLS
11406 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11407 (LIBS): Link to USER_LIBS.
11408 ($(BLD)/gnutls.$(0)): New target.
11410 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11412 * xdisp.c (handle_single_display_spec): Rename the
11413 display_replaced_before_p argument into display_replaced_p, to
11414 make it consistent with the commentary. Fix typos in the
11417 * textprop.c (syms_of_textprop): Remove dead code.
11418 (copy_text_properties): Delete obsolete commentary about an
11419 interface that was deleted long ago. Fix typos in the description
11422 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11423 to changes in oldXMenu/XMenu.h from 2011-04-16.
11424 <menu_help_message, prev_menu_help_message>: Constify.
11425 (IT_menu_make_room): menu->help_text is now `const char **';
11428 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11429 to changes in oldXMenu/XMenu.h from 2011-04-16.
11430 (struct XMenu): Declare `help_text' `const char **'.
11432 * xfaces.c <Qunspecified>: Make extern again.
11434 * syntax.c: Include sys/types.h before including regex.h, as
11437 * doc.c (get_doc_string): Improve the format passed to `error'.
11439 * doprnt.c (doprnt): Improve commentary.
11441 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11443 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11446 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11447 changes in globals.h immediately force recompilation.
11448 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11449 $(CURDIR)/s/ms-w32.h.
11450 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11452 * character.c (Fchar_direction): Function deleted.
11453 (syms_of_character): Don't defsubr it.
11454 <char-direction-table>: Deleted.
11456 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11458 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11459 * doprnt.c: Include limits.h.
11460 (SIZE_MAX): New macro.
11461 (doprnt): Return a size_t value. 2nd arg is now size_t.
11462 Many local variables are now size_t instead of int or unsigned.
11463 Improve overflow protection. Support `l' modifier for integer
11464 conversions. Support %l conversion. Don't assume an EMACS_INT
11465 argument for integer conversions and for %c.
11467 * lisp.h (doprnt): Restore prototype.
11469 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11470 $(SRC)/character.h.
11472 * Makefile.in (base_obj): Add back doprnt.o.
11474 * deps.mk (doprnt.o): Add back prerequisites.
11475 (callint.o): Depend on character.h.
11477 * eval.c (internal_lisp_condition_case): Include the handler
11478 representation in the error message.
11479 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11480 when breaking from the loop.
11482 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11484 * callint.c (Fcall_interactively): When displaying error message
11485 about invalid control letter, pass the character's codepoint, not
11486 a pointer to its multibyte form. Improve display of the character
11487 in octal and display also its hex code.
11489 * character.c (char_string): Use %x to display the (unsigned)
11490 codepoint of an invalid character, to avoid displaying a bogus
11493 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11494 `error', not SYMBOL_NAME itself.
11496 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11497 character arguments to `error'.
11499 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11500 to `error' in error message about FINAL_CHAR argument. Make sure
11501 FINAL_CHAR is a character, and use %c when it is passed as
11502 argument to `error'.
11504 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11506 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11508 * w32.c: Include <time.h>.
11509 (sys_localtime): New function.
11511 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11513 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11515 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11517 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11519 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11520 zombies (Bug#8467).
11522 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11524 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11525 gl_state.e_property when gl_state.object is Qt.
11527 * insdel.c (make_gap_larger): Remove limitation of buffer size
11530 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11532 * xdisp.c (lookup_glyphless_char_display)
11533 (produce_glyphless_glyph): Handle cons cell entry in
11534 glyphless-char-display.
11535 (Vglyphless_char_display): Document it.
11537 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11538 glyphless-char-display.
11540 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11542 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11544 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11546 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11547 definition for no-X builds.
11549 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11551 Static checks with GCC 4.6.0 and non-default toolkits.
11553 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11555 * process.c (keyboard_bit_set): Define only if SIGIO.
11556 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11557 (send_process): Repair possible setjmp clobbering.
11559 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11561 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11563 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11565 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11566 Define only if needed.
11568 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11569 by pacifying GCC about it. Maybe it's time to retire it?
11570 * xfaces.c (USG, __TIMEVAL__): Likewise.
11572 * dispextern.h (struct redisplay_interface): Rename param
11573 to avoid shadowing.
11574 * termhooks.h (struct terminal): Likewise.
11575 * xterm.c (xembed_send_message): Likewise.
11577 * insdel.c (make_gap_smaller): Define only if
11578 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11580 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11583 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11584 so that we aren't warned about unused symbols.
11586 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11588 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11590 * xfns.c (x_real_positions): Mark locals as initialized.
11592 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11594 * xterm.c: Fix problems found by static analysis with other toolkits.
11595 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11596 (x_dispatch_event): Declare static if USE_GTK, and
11597 define if USE_GTK || USE_X_TOOLKIT.
11598 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11599 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11600 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11601 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11603 * xmenu.c (menu_help_callback): Pointer type fixes.
11604 Use const pointers when pointing at readonly data. Avoid pointer
11605 signedness clashes.
11606 (FALSE): Remove unused macro.
11607 (update_frame_menubar): Remove unused decl.
11609 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11611 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11612 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11613 (single_menu_item): Rename local to avoid shadowing.
11615 * keyboard.c (make_lispy_event): Remove unused local var.
11617 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11618 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11620 * bitmaps: Change bitmaps from unsigned char back to the X11
11621 compatible char. Avoid the old compiler warnings about
11622 out-of-range initializers by using, for example, '\xab' rather
11625 * xgselect.c (xgselect_initialize): Check vs interface
11626 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11628 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11630 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11631 to read-only memory.
11633 * fns.c (vector): Remove; this old hack is no longer needed.
11635 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11637 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11639 * xrdb.c (x_load_resources): Omit unused local.
11641 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11642 (x_window): Rename locals to avoid shadowing.
11643 (USG): Use the kludged USG macro, to pacify gcc.
11645 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11646 (x_term_init): Remove local to avoid shadowing.
11648 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11650 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11651 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11653 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11655 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11657 Fix regex.c, syntax.c and friends for buffers > 2GB.
11658 * syntax.h (struct gl_state_s): Declare character position members
11661 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11663 * textprop.c (verify_interval_modification, interval_of):
11664 Declare arguments EMACS_INT.
11666 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11669 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11671 * indent.c (Fvertical_motion): Local variable it_start is now
11674 * regex.c (re_match, re_match_2, re_match_2_internal)
11675 (bcmp_translate, regcomp, regexec, print_double_string)
11676 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11677 (re_compile_pattern, re_exec): Declare arguments and local
11678 variables `size_t' and `ssize_t' and return values `regoff_t', as
11680 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11681 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11682 <compile_stack_type>: `size' and `avail' are now `size_t'.
11684 * regex.h <regoff_t>: Use ssize_t, not int.
11685 (re_search, re_search_2, re_match, re_match_2): Arguments that
11686 specify buffer/string position and length are now ssize_t and
11687 size_t. Return type is regoff_t.
11689 2011-04-16 Ben Key <bkey76@gmail.com>
11691 * nsfont.m: Fixed bugs in ns_get_family and
11692 ns_descriptor_to_entity that were caused by using free to
11693 deallocate memory blocks that were allocated by xmalloc (via
11694 xstrdup). This caused Emacs to crash when compiled with
11695 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11696 --enable-checking=xmallocoverrun). xfree is now used to
11697 deallocate these memory blocks.
11699 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11701 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11703 emacs_write: Accept and return EMACS_INT for sizes.
11704 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11706 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11707 Accept and return EMACS_INT.
11708 (emacs_gnutls_write): Return the number of bytes written on
11710 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11711 (emacs_read, emacs_write): Remove check for negative size, as the
11712 Emacs source code has been audited now.
11713 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11714 (emacs_read, emacs_write): Use it.
11715 * process.c (send_process): Adjust to the new signatures of
11716 emacs_write and emacs_gnutls_write. Do not attempt to store
11717 a byte offset into an 'int'; it might overflow.
11718 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11720 * sound.c: Don't assume sizes fit in 'int'.
11721 (struct sound_device.period_size, alsa_period_size):
11722 Return EMACS_INT, not int.
11723 (struct sound_device.write, vox_write, alsa_write):
11724 Accept EMACS_INT, not int.
11725 (wav_play, au_play): Use EMACS_INT to store sizes and to
11726 record read return values.
11728 2011-04-15 Ben Key <bkey76@gmail.com>
11730 * keyboard.c (Qundefined): Don't declare static since it is used
11732 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11733 static since they are used in nsfont.m.
11735 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11737 * process.c (Qprocessp): Don't declare static.
11738 * lisp.h (Qprocessp): Declare again.
11740 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11742 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11744 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11746 Improve C-level modularity by making more things 'static'.
11748 Don't publish debugger-only interfaces to other modules.
11749 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11750 (verify_bytepos, count_markers): Move decls to the only modules
11752 * region-cache.h (pp_cache): Likewise.
11753 * window.h (check_all_windows): Likewise.
11754 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11756 * sysdep.c (croak): Now static, if
11757 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11758 * syssignal.h (croak): Declare only if not static.
11760 * alloc.c (refill_memory_reserve): Now static if
11761 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11762 * lisp.h (refill_memory_reserve): Declare only if not static.
11764 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11765 Define only if USE_LUCID.
11767 * xrdb.c (x_customization_string, x_rm_string): Now static.
11769 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11770 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11772 * xdisp.c (draw_row_with_mouse_face): Now static.
11773 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11775 * window.h (check_all_windows): Mark externally visible.
11777 * window.c (window_deletion_count): Now static.
11779 * undo.c: Make symbols static if they're not exported.
11780 (last_undo_buffer, last_boundary_position, pending_boundary):
11783 * textprop.c (interval_insert_behind_hooks): Now static.
11784 (interval_insert_in_front_hooks): Likewise.
11786 * term.c: Make symbols static if they're not exported.
11787 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11788 (max_frame_lines, tty_set_terminal_modes):
11789 (tty_reset_terminal_modes, tty_turn_off_highlight):
11790 (get_tty_terminal): Now static.
11791 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11792 * termhooks.h (term_mouse_moveto): Do not declare if
11793 HAVE_WINDOW_SYSTEM.
11794 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11795 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11797 * sysdep.c: Make symbols static if they're not exported.
11798 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11800 (sigprocmask_set, full_mask): Remove; unused.
11801 (wait_debugging): Mark as visible.
11802 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11803 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11805 * syntax.c (syntax_temp): Define only if !__GNUC__.
11807 * sound.c (current_sound_device, current_sound): Now static.
11809 * search.c (searchbufs, searchbuf_head): Now static.
11811 * scroll.c (scroll_cost): Remove; unused.
11812 * dispextern.h (scroll_cost): Remove decl.
11814 * region-cache.h (pp_cache): Mark as externally visible.
11816 * process.c: Make symbols static if they're not exported.
11817 (process_tick, update_tick, create_process, chan_process):
11818 (Vprocess_alist, proc_buffered_char, datagram_access):
11819 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11820 (deactivate_process): Mark defn as static, as well as decl.
11821 * lisp.h (create_process): Remove decl.
11822 * process.h (chan_process, Vprocess_alist): Remove decls.
11824 * print.c: Make symbols static if they're not exported.
11825 (print_depth, new_backquote_output, being_printed, print_buffer):
11826 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11827 (print_interval, print_number_index, initial_stderr_stream):
11829 * lisp.h (Fprinc): Remove decl.
11830 (debug_output_compilation_hack): Mark as externally visible.
11832 * sysdep.c (croak): Move decl from here to syssignal.h.
11833 * syssignal.h (croak): Put it here, so the API can be checked when
11834 'croak' is called from dissociate_if_controlling_tty.
11836 * minibuf.c: Make symbols static if they're not exported.
11837 (minibuf_save_list, choose_minibuf_frame): Now static.
11838 * lisp.h (choose_minibuf_frame): Remove decl.
11840 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11842 * lread.c: Make symbols static if they're not exported.
11843 (read_objects, initial_obarray, oblookup_last_bucket_number):
11845 (make_symbol): Remove; unused.
11846 * lisp.h (initial_obarray, make_symbol): Remove decls.
11848 * keyboard.c: Make symbols static if they're not exported.
11849 (single_kboard, recent_keys_index, total_keys, recent_keys):
11850 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11851 (this_single_command_key_start, echoing, last_auto_save):
11852 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11853 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11854 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11855 (Vlispy_mouse_stem, double_click_count):
11857 (force_auto_save_soon): Define only if SIGDANGER.
11858 (ignore_mouse_drag_p): Now static if
11859 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11860 (print_help): Remove; unused.
11861 (stop_character, last_timer_event): Mark as externally visible.
11862 * keyboard.h (ignore_mouse_drag_p): Declare only if
11863 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11864 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11865 * lisp.h (echoing): Remove decl.
11866 (force_auto_save_soon): Declare only if SIGDANGER.
11867 * xdisp.c (redisplay_window): Simplify code, to make it more
11868 obvious that ignore_mouse_drag_p is not accessed if !defined
11869 USE_GTK && !defined HAVE_NS.
11871 * intervals.c: Make symbols static if they're not exported.
11872 (merge_properties_sticky, merge_interval_right, delete_interval):
11874 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11876 * insdel.c: Make symbols static if they're not exported.
11877 However, leave prepare_to_modify_buffer alone. It's never
11878 called from outside this function, but that appears to be a bug.
11879 (combine_after_change_list, combine_after_change_buffer):
11880 (adjust_after_replace, signal_before_change): Now static.
11881 (adjust_after_replace_noundo): Remove; unused.
11882 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11883 (signal_before_change): Remove decls.
11885 * indent.c (val_compute_motion, val_vmotion): Now static.
11887 * image.c: Make symbols static if they're not exported.
11888 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11890 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11891 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11893 * fringe.c (standard_bitmaps): Now static.
11894 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11896 * frame.c: Make symbols static if they're not exported.
11897 (x_report_frame_params, make_terminal_frame): Now static.
11898 (get_frame_param): Now static, unless HAVE_NS.
11899 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11900 (x_get_resource_string): Remove; not used.
11901 * frame.h (make_terminal_frame, x_report_frame_params):
11902 (x_get_resource_string); Remove decls.
11903 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11904 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11906 * font.c, fontset.c: Make symbols static if they're not exported.
11907 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11908 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11909 * font.c (font_close_object): Now static.
11910 * font.h (font_close_object): Remove.
11911 * fontset.c (FONTSET_OBJLIST): Remove.
11912 (free_realized_fontset) #if-0 the body, which does nothing.
11913 (face_suitable_for_char_p): #if-0, as it's never called.
11914 * fontset.h (face_suitable_for_char_p): Remove decl.
11915 * xfaces.c (face_at_string_position):
11916 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11917 since 0 is always ASCII.
11919 * fns.c (weak_hash_tables): Now static.
11921 * fileio.c: Make symbols static if they're not exported.
11922 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11923 (Vwrite_region_annotation_buffers): Now static.
11925 * eval.c: Make symbols static if they're not exported.
11926 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11927 * lisp.h (backtrace_list): Remove decl.
11929 * emacs.c: Make symbols static if they're not exported.
11930 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11931 (fatal_error_code, fatal_error_signal_hook, standard_args):
11933 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11934 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11935 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11936 * lisp.h (fatal_error_signal_hook): Remove decl.
11937 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11939 * editfns.c: Move a (normally-unused) function to its only use.
11940 * editfns.c, lisp.h (get_operating_system_release): Remove.
11941 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11942 worth the hassle of breaking this out.
11944 * xterm.c: Make symbols static if they're not exported.
11945 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11946 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11947 (x_destroy_window, x_delete_display):
11949 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11950 (x_mouse_leave): Remove; unused.
11951 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11952 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11953 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11955 (x_mouse_leave): Declare only if WINDOWSNT.
11956 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11957 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11960 * ftxfont.c: Make symbols static if they're not exported.
11961 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11963 * font.h (ftxfont_driver): Likewise.
11965 * xfns.c: Make symbols static if they're not exported.
11966 (x_last_font_name, x_display_info_for_name):
11967 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11968 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11969 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11970 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11971 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11972 (last_show_tip_args): Now static.
11973 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11974 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11975 (x_screen_planes): Remove; unused.
11976 * dispextern.h (x_screen_planes): Remove decl.
11978 * dispnew.c: Make symbols static if they're not exported.
11979 * dispextern.h (redraw_garbaged_frames, scrolling):
11980 (increment_row_positions): Remove.
11981 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11982 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11984 (redraw_garbaged_frames): Remove; unused.
11986 * xfaces.c: Make symbols static if they're not exported.
11987 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11989 * xterm.h (defined_color): Remove decls.
11990 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11991 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11992 (menu_face_changed_default, defined_color, free_realized_face):
11993 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11994 (ascii_face_of_lisp_face): Remove; unused.
11996 * xdisp.c: Make symbols static if they're not exported.
11997 * dispextern.h (scratch_glyph_row, window_box_edges):
11998 (glyph_to_pixel_coords, set_cursor_from_row):
11999 (get_next_display_element, set_iterator_to_next):
12000 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12001 (show_mouse_face): Remove decls
12002 * frame.h (message_buf_print): Likewise.
12003 * lisp.h (pop_message, set_message, check_point_in_composition):
12005 * xterm.h (set_vertical_scroll_bar): Likewise.
12006 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12007 (message_buf_print, scratch_glyph_row, displayed_buffer):
12008 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12009 (get_next_display_element, show_mouse_face, window_box_edges):
12010 (frame_to_window_pixel_xy, check_point_in_composition):
12011 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12012 (glyph_to_pixel_coords): Remove; unused.
12014 * dired.c (file_name_completion): Now static.
12016 * dbusbind.c (xd_in_read_queued_messages): Now static.
12018 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12019 * data.c (circular_list_error): Remove.
12021 * commands.h (last_point_position, last_point_position_buffer):
12022 (last_point_position_window): Remove decls.
12023 * keyboard.c: Make these variables static.
12025 * coding.h (coding, code_convert_region, encode_coding_gap):
12027 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12028 (iso_code_class, detect_coding, code_convert_region): Now static.
12029 (encode_coding_gap): Remove; unused.
12031 * chartab.c (chartab_chars, chartab_bits): Now static.
12033 * charset.h (charset_iso_8859_1): Remove decl.
12034 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12037 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12038 * ccl.c (Vccl_program_table): Now static.
12039 (check_ccl_update): Remove; unused.
12041 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12042 * category.h: ... from here.
12043 * category.c (check_category_table, set_category_set): Now static.
12045 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12046 * lisp.h: Remove these decls.
12048 * buffer.c (buffer_count): Remove unused var.
12050 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12051 so that it's not optimized away.
12052 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12053 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12054 exported only to the debugger.
12056 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12057 * atimer.h (run_all_atimers): Remove; not exported.
12059 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12060 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12061 was inaccessible from Lisp.
12062 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12063 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12065 alloc.c: Import and export fewer symbols, and remove unused items.
12066 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12068 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12069 it's not optimized away by whole-program optimization.
12070 (message_enable_multibyte, free_misc): Remove.
12071 (catchlist, handlerlist, mark_backtrace):
12072 Declare only if BYTE_MARK_STACK.
12073 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12074 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12075 (message_enable_multibyte): Remove decl.
12076 (free_misc, interval_free_list, float_block, float_block_index):
12077 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12078 (cons_free_list, last_marked_index):
12080 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12081 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12082 (mark_backtrace): Define only if BYTE_MARK_STACK.
12083 * xdisp.c (message_enable_multibyte): Now static.
12085 Declare Lisp_Object Q* variables to be 'static' if not exported.
12086 This makes it easier for human readers (and static analyzers)
12087 to see whether these variables are used from other modules.
12088 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12089 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12090 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12091 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12092 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12093 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12094 * xmenu.c, xselect.c:
12095 Declare Q* vars static if they are not used in other modules.
12096 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12097 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12098 Remove decls of unexported vars.
12099 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12101 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12103 Make Emacs functions such as Fatom 'static' by default.
12104 This makes it easier for human readers (and static analyzers)
12105 to see whether these functions can be called from other modules.
12106 DEFUN now defines a static function. To make the function external
12107 so that it can be used in other C modules, use the new macro DEFUE.
12108 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12109 (Finit_image_library):
12110 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12111 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12112 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12113 Remove decls, since these functions are now static.
12114 (Funintern, Fget_internal_run_time): New decls, since these functions
12115 were already external.
12117 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12118 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12119 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12120 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12121 * keyboard.c, keymap.c, lread.c:
12122 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12123 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12124 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12125 Mark functions with DEFUE instead of DEFUN,
12126 if they are used in other modules.
12127 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12128 decls for now-static functions.
12129 * buffer.h (Fdelete_overlay): Remove decl.
12130 * callproc.c (Fgetenv_internal): Mark as internal.
12131 * composite.c (Fremove_list_of_text_properties): Remove decl.
12132 (Fcomposition_get_gstring): New forward static decl.
12133 * composite.h (Fcomposite_get_gstring): Remove decl.
12134 * dired.c (Ffile_attributes): New forward static decl.
12135 * doc.c (Fdocumntation_property): New forward static decl.
12136 * eval.c (Ffetch_bytecode): New forward static decl.
12137 (Funintern): Remove extern decl; now in .h file where it belongs.
12138 * fileio.c (Fmake_symbolic_link): New forward static decl.
12139 * image.c (Finit_image_library): New forward static decl.
12140 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12141 * intervals.h (Fprevious_property_change):
12142 (Fremove_list_of_text_properties): Remove decls.
12143 * keyboard.c (Fthis_command_keys): Remove decl.
12144 (Fcommand_execute): New forward static decl.
12145 * keymap.c (Flookup_key): New forward static decl.
12146 (Fcopy_keymap): Now static.
12147 * keymap.h (Flookup_key): Remove decl.
12148 * process.c (Fget_process): New forward static decl.
12149 (Fprocess_datagram_address): Mark as internal.
12150 * syntax.c (Fsyntax_table_p): New forward static decl.
12151 (skip_chars): Remove duplicate decl.
12152 * textprop.c (Fprevious_property_change): New forward static decl.
12153 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12155 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12156 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12158 * editfns.c (Fformat): Remove unreachable code.
12160 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12162 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12165 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12167 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12168 when at ZV. (Bug#8487)
12170 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12172 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12174 * keyboard.c (parse_tool_bar_item): Likewise.
12175 * sound.c (sound_cleanup, alsa_close): Likewise.
12176 * termcap.c (tgetent): Likewise.
12177 * xfns.c (x_default_font_parameter): Likewise.
12178 * xsettings.c (read_and_apply_settings): Likewise.
12180 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12181 (overrun_check_free): Protoize.
12183 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12185 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12186 since callers should never pass a negative size.
12187 Change the signature to match that of plain 'read' and 'write'; see
12188 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12189 * lisp.h: Update prototypes of emacs_write and emacs_read.
12191 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12193 * xdisp.c (redisplay_window): Don't try to determine the character
12194 position of the scroll margin if the window start point w->startp
12195 is outside the buffer's accessible region. (Bug#8468)
12197 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12199 Fix write-region and its subroutines for buffers > 2GB.
12200 * fileio.c (a_write, e_write): Modify declaration of arguments and
12201 local variables to support buffers larger than 2GB.
12202 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12204 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12205 argument, local variables, and return value.
12207 * lisp.h: Update prototypes of emacs_write and emacs_read.
12209 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12211 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12213 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12215 Fix more problems found by GCC 4.6.0's static checks.
12217 * xdisp.c (vmessage): Use a better test for character truncation.
12219 * charset.c (load_charset_map): <, not <=, for optimization,
12220 and to avoid potential problems with integer overflow.
12221 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12222 * casetab.c (set_identity, shuffle): Likewise.
12223 * editfns.c (Fformat): Likewise.
12224 * syntax.c (skip_chars): Likewise.
12226 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12227 This also lets GCC 4.6.0 generate slightly better loop code.
12229 * callint.c (Fcall_interactively): <, not <=, for optimization.
12230 (Fcall_interactively): Count the number of arguments produced,
12231 not the number of arguments given. This is simpler and lets GCC
12232 4.6.0 generate slightly better code.
12234 * ftfont.c: Distingish more carefully between FcChar8 and char.
12235 The previous code passed unsigned char * to a functions like
12236 strlen and xstrcasecmp that expect char *, which does not
12237 conform to the C standard.
12238 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12239 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12240 char * when the C standard requires it.
12242 * keyboard.c (read_char): Remove unused var.
12244 * eval.c: Port to Windows vsnprintf (Bug#8435).
12245 Include <limits.h>.
12246 (SIZE_MAX): Define if the headers do not.
12247 (verror): Do not give up if vsnprintf returns a negative count.
12248 Instead, grow the buffer. This ports to Windows vsnprintf, which
12249 does not conform to C99. Problem reported by Eli Zaretskii.
12250 Also, simplify the allocation scheme, by avoiding the need for
12251 calling realloc, and removing the ALLOCATED variable.
12253 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12255 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12256 But keep the doprint source code for now, as we might revamp it
12257 and use it again (Bug#8435).
12258 * lisp.h (doprnt): Remove.
12259 * Makefile.in (base_obj): Remove doprnt.o.
12260 * deps.mk (doprnt.o): Remove.
12262 error: Print 32- and 64-bit integers portably (Bug#8435).
12263 Without this change, on typical 64-bit hosts error ("...%d...", N)
12264 was used to print both 32- and 64-bit integers N, which relied on
12265 undefined behavior.
12266 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12267 * lisp.h (error, verror): Mark as printf-like functions.
12268 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12269 Report overflow in size calculations when allocating printf buffer.
12270 Do not truncate output string at its first null byte.
12271 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12272 Truncate the output at a character boundary, since vsnprintf does not
12274 * charset.c (check_iso_charset_parameter): Convert internal
12275 character to string before calling 'error', since %c now has the
12277 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12278 overflow when computing char to be passed to 'error'. Do not
12279 pass Lisp_Object to 'error'; pass the integer instead.
12280 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12281 formatted with plain %d.
12283 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12285 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12287 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12289 * xterm.c (x_catch_errors): Remove duplicate declaration.
12291 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12293 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12295 2011-04-10 Jim Meyering <meyering@redhat.com>
12297 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12298 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12299 return ssize_t not "int", and use size_t as the buffer length.
12300 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12301 * gnutls.h: Update declarations.
12302 * process.c (read_process_output): Use ssize_t, to match.
12303 (send_process): Likewise.
12305 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12307 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12309 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12311 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12312 Use unsigned char, to match FcChar8 type definition.
12314 * xterm.c (handle_one_xevent):
12315 * xmenu.c (create_and_show_popup_menu):
12316 * xselect.c (x_decline_selection_request)
12317 (x_reply_selection_request): Avoid type-punned deref of X events.
12319 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12321 Fix some uses of `int' instead of EMACS_INT.
12322 * search.c (string_match_1, fast_string_match)
12323 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12324 (scan_buffer, find_next_newline_no_quit)
12325 (find_before_next_newline, search_command, Freplace_match)
12326 (Fmatch_data): Make some `int' variables be EMACS_INT.
12328 * xdisp.c (display_count_lines): 3rd argument and return value now
12329 EMACS_INT. All callers changed.
12330 (pint2hrstr): Last argument is now EMACS_INT.
12332 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12333 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12334 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12335 (decode_coding_utf_16, decode_coding_emacs_mule)
12336 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12337 (decode_coding_ccl, decode_coding_charset)
12338 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12339 (decode_coding_iso_2022, decode_coding_emacs_mule)
12340 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12341 <char_offset, last_offset>: Declare EMACS_INT.
12342 (encode_coding_utf_8, encode_coding_utf_16)
12343 (encode_coding_emacs_mule, encode_invocation_designation)
12344 (encode_designation_at_bol, encode_coding_iso_2022)
12345 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12346 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12348 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12349 (encode_invocation_designation): Last argument P_NCHARS is now
12351 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12352 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12354 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12357 * ccl.c (Fccl_execute_on_string): Declare some variables
12360 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12362 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12364 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12366 * process.c (Fformat_network_address): Doc fix.
12368 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12370 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12372 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12374 * keyboard.c (read_char): Call Lisp function help-form-show,
12375 instead of using internal_with_output_to_temp_buffer.
12376 (Qhelp_form_show): New var.
12377 (syms_of_keyboard): Use DEFSYM macro.
12379 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12381 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12383 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12385 * process.c (Flist_processes): Remove to Lisp.
12386 (list_processes_1): Delete.
12388 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12390 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12392 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12394 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12396 Fix more problems found by GCC 4.6.0's static checks.
12398 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12400 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12402 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12404 * xdisp.c (vmessage): Mark as a printf-like function.
12406 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12408 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12410 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12411 printf-like functions.
12412 (tiff_load): Add casts to remove these marks before passing them
12413 to system-supplied API.
12415 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12417 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12418 This avoids several warnings with gcc -Wstrict-overflow.
12419 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12420 directly, rather than having caller test rule sign. This avoids
12421 some unnecessary tests.
12422 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12423 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12424 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12426 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12427 (xfont_open): Avoid unnecessary tests.
12429 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12431 * composite.h, composite.c (composition_gstring_put_cache):
12432 Use EMACS_INT, not int, for length.
12434 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12435 breaking out part of COMPOSITION_DECODE_RULE.
12436 (COMPOSITION_DECODE_RULE): Use it.
12437 * composite.c (get_composition_id): Remove unused local vars,
12438 by using the new macro.
12440 * textprop.c (set_text_properties_1): Change while to do-while,
12441 since the condition is always true at first.
12443 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12444 (interval_deletion_adjustment): Return unsigned value.
12447 * process.c (list_processes_1, create_pty, read_process_output):
12448 (exec_sentinel): Remove vars that were set but not used.
12449 (create_pty): Remove unnecessary "volatile"s.
12450 (Fnetwork_interface_info): Avoid possibility of int overflow.
12451 (read_process_output): Do adaptive read buffering even if carryover.
12452 (read_process_output): Simplify nbytes computation if buffered.
12454 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12456 * syntax.c (scan_words): Remove var that was set but not used.
12457 (update_syntax_table): Use unsigned instead of int.
12459 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12460 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12461 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12463 * print.c (print_error_message): Avoid int overflow.
12465 * font.c (font_list_entities): Redo for clarity,
12466 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12468 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12469 (font_score): Avoid potential overflow in diff calculation.
12471 * fns.c (substring_both): Remove var that is set but not used.
12472 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12474 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12476 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12477 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12478 can always succeed if overflow has undefined behavior.
12480 * search.c (boyer_moore, wordify): Remove vars set but not used.
12481 (wordify): Omit three unnecessary tests.
12483 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12484 All callers changed. This avoids the need for an unused var.
12486 * casefiddle.c (casify_region): Remove var that is set but not used.
12488 * dired.c (file_name_completion): Remove var that is set but not used.
12490 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12492 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12493 (Finsert_file_contents): Remove unnecessary code checking fd.
12495 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12496 Check for integer overflow on size calculations.
12498 * buffer.c (Fprevious_overlay_change): Remove var that is set
12501 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12502 Remove vars that are set but not used.
12503 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12504 (timer_check_2): Mark vars as initialized.
12506 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12508 * image.c (lookup_image): Remove var that is set but not used.
12509 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12511 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12512 that are set but not used.
12514 * xfns.c (make_invisible_cursor): Don't return garbage
12515 if XCreateBitmapFromData fails (Bug#8410).
12517 * xselect.c (x_get_local_selection, x_handle_property_notify):
12518 Remove vars that are set but not used.
12520 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12521 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12523 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12524 Remove var that is set but not used.
12525 (scroll_bar_windows_size): Now size_t, not int.
12526 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12527 Check for overflow.
12529 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12530 (map_tty_color) [!defined MSDOS]: Likewise.
12532 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12534 * coding.c: Remove vars that are set but not used.
12535 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12536 All callers changed.
12537 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12538 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12539 (decode_coding_charset): Remove vars that are set but not used.
12541 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12542 that is set but not used.
12544 * print.c (print_object): Remove var that is set but not used.
12546 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12547 The gnulib version avoids calling malloc in the usual case,
12548 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12549 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12550 * filelock.c (current_lock_owner): Likewise.
12551 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12552 * sysdep.c: Include allocator.h, careadlinkat.h.
12553 (emacs_no_realloc_allocator): New static constant.
12554 (emacs_readlink): New function.
12555 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12556 ../lib/careadlinkat.h.
12558 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12560 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12561 first non-nil return value).
12563 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12565 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12566 if not defined (Bug#8403).
12568 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12570 * xdisp.c (display_count_lines): Remove parameter `start',
12571 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12572 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12573 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12574 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12575 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12576 and thereabouts. All callers changed.
12577 (get_per_char_metric): Remove parameter `f', unused since
12578 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12580 2011-04-02 Jim Meyering <meyering@redhat.com>
12582 do not dereference NULL upon failed strdup
12583 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12584 (ns_get_family): Likewise.
12586 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12588 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12590 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12592 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12595 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12597 Add lexical binding.
12599 * window.c (Ftemp_output_buffer_show): New fun.
12600 (Fsave_window_excursion):
12601 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12603 * lread.c (lisp_file_lexically_bound_p): New function.
12604 (Fload): Bind Qlexical_binding.
12605 (readevalloop): Remove `evalfun' arg.
12606 Bind Qinternal_interpreter_environment.
12607 (Feval_buffer): Bind Qlexical_binding.
12608 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12610 (syms_of_lread): Declare `lexical-binding'.
12612 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12614 * keyboard.c (eval_dyn): New fun.
12615 (menu_item_eval_property): Use it.
12617 * image.c (parse_image_spec): Use Ffunctionp.
12619 * fns.c (concat, mapcar1): Accept byte-code-functions.
12621 * eval.c (Fsetq): Handle lexical vars.
12622 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12623 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12624 (FletX, Flet): Obey lexical binding.
12625 (Fcommandp): Handle closures.
12626 (Feval): New `lexical' arg.
12627 (eval_sub): New function extracted from Feval. Use it almost
12628 everywhere where Feval was used. Look up vars in lexical env.
12630 (Ffunctionp): Move from subr.el.
12631 (Ffuncall): Handle closures.
12632 (apply_lambda): Remove `eval_flags'.
12633 (funcall_lambda): Handle closures and new byte-code-functions.
12634 (Fspecial_variable_p): New function.
12635 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12636 but without exporting it to Lisp.
12638 * doc.c (Fdocumentation, store_function_docstring):
12639 * data.c (Finteractive_form): Handle closures.
12641 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12644 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12646 (exec_byte_code): New function extracted from Fbyte_code to handle new
12647 calling convention for byte-code-functions. Add new byte-codes.
12649 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12651 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12653 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12655 * xdisp.c (redisplay_internal): Fix prototype.
12657 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12659 * xdisp.c (SCROLL_LIMIT): New macro.
12660 (try_scrolling): Use it when setting scroll_limit.
12661 Limit scrolling to 100 screen lines.
12662 (redisplay_window): Even when falling back on "recentering",
12663 position point in the window according to scroll-conservatively,
12664 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12666 (try_scrolling): When point is above the window, allow searching
12667 as far as scroll_max, or one screenful, to compute vertical
12668 distance from PT to the scroll margin position. This prevents
12669 try_scrolling from unnecessarily failing when
12670 scroll-conservatively is set to a value slightly larger than the
12671 window height. Clean up the case of PT below the margin at bottom
12672 of window: scroll_max can no longer be INT_MAX. When aggressive
12673 scrolling is in use, don't let point enter the opposite scroll
12674 margin as result of the scroll.
12675 (syms_of_xdisp) <scroll-conservatively>: Document the
12676 threshold of 100 lines for never-recentering scrolling.
12678 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12680 * dispextern.h (move_it_by_lines):
12681 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12682 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12683 (message_log_check_duplicate): Remove parameters `prev_bol' and
12684 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12685 (redisplay_internal): Remove parameter `preserve_echo_area',
12686 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12688 * indent.c (Fvertical_motion):
12689 * window.c (window_scroll_pixel_based, Frecenter):
12690 Don't pass `need_y_p' to `move_it_by_lines'.
12692 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12694 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12695 steal a few bits to be more compact.
12696 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12697 Remove unneeded casts.
12699 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12701 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12703 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12704 binding" message (bug#7967).
12706 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12708 Fix more problems found by GCC 4.6.0's static checks.
12710 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12711 Remove unused local var.
12713 * editfns.c (Fmessage_box): Remove unused local var.
12715 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12716 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12717 Omit unused local vars.
12718 * window.c (shrink_windows): Omit unused local var.
12719 * menu.c (digest_single_submenu): Omit unused local var.
12720 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12721 Omit unused local var.
12723 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12724 Don't assume string length fits in int.
12725 (keyremap_step, read_key_sequence): Use size_t for sizes.
12726 (read_key_sequence): Don't check last_real_key_start redundantly.
12728 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12729 instead of alloca (Bug#8344).
12731 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12732 (Fbacktrace_frame): Don't assume nframes fits in int.
12734 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12736 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12739 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12741 * cm.c (calccost): Turn while-do into do-while, for clarity.
12743 * keyboard.c (syms_of_keyboard): Use the same style as later
12744 in this function when indexing through an array. This also
12745 works around GCC bug 48267.
12747 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12749 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12751 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12752 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12754 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12755 This avoids undefined behavior on integer overflow, and is a bit
12756 more convenient anyway since it is compared to a size_t variable.
12758 Variadic C functions now count arguments with size_t, not int.
12759 This avoids an unnecessary limitation on 64-bit machines, which
12760 caused (substring ...) to crash on large vectors (Bug#8344).
12761 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12762 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12763 All variadic functions and their callers changed accordingly.
12764 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12765 * data.c (arith_driver, float_arith_driver): Likewise.
12766 * editfns.c (general_insert_function): Likewise.
12767 * eval.c (struct backtrace.nargs, interactive_p)
12768 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12769 (funcall_lambda, mark_backtrace): Likewise.
12770 * fns.c (concat): Likewise.
12771 * frame.c (x_set_frame_parameters): Likewise.
12772 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12773 0 if not found, not -1. All callers changed.
12775 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12776 (stack_copy_size): Now size_t, not int.
12777 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12779 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12781 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12782 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12783 All callers changed.
12785 * lisp.h (multibyte_char_to_unibyte):
12786 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12787 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12788 * character.h (CHAR_TO_BYTE8):
12789 * cmds.c (internal_self_insert):
12790 * editfns.c (general_insert_function):
12791 * keymap.c (push_key_description):
12792 * search.c (Freplace_match):
12793 * xdisp.c (message_dolog, set_message_1): All callers changed.
12795 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12797 * keyboard.c (safe_run_hook_funcall): New function.
12798 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12799 don't set the hook to nil, but remove the offending function instead.
12800 (Qcommand_hook_internal): Remove, unused.
12801 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12802 Vcommand_hook_internal.
12804 * eval.c (enum run_hooks_condition): Remove.
12805 (funcall_nil, funcall_not): New functions.
12806 (run_hook_with_args): Call each function through a `funcall' argument.
12807 Remove `cond' argument, now redundant.
12808 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12809 (Frun_hook_with_args_until_failure): Adjust accordingly.
12810 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12812 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12814 * dispextern.h (string_buffer_position): Remove declaration.
12816 * print.c (strout): Remove parameter `multibyte', unused since
12817 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12819 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12820 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12821 All callers changed.
12823 * w32.c (_wsa_errlist): Use braces for struct initializers.
12825 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12826 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12827 All callers changed.
12828 (string_buffer_position): Likewise. Also, make static (it's never
12829 used outside xdisp.c).
12830 (cursor_row_p): Remove parameter `w', unused since
12831 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12832 (decode_mode_spec): Remove parameter `precision', introduced during
12833 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12834 All callers changed.
12836 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12838 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12840 2011-03-27 Anders Lindgren <andlind@gmail.com>
12842 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12843 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12844 (ns_update_auto_hide_menu_bar): New functions.
12845 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12846 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12847 ns_constrain_all_frames.
12848 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12849 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12851 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12853 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12855 2011-03-27 Glenn Morris <rgm@gnu.org>
12857 * syssignal.h: Replace RETSIGTYPE with void.
12858 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12859 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12860 Replace SIGTYPE with void everywhere.
12861 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12862 * s/template.h (SIGTYPE): Remove commented out definition.
12864 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12866 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12867 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12869 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12871 * w32.c (read_unc_volume): Use parameter `henum', instead of
12872 global variable `wget_enum_handle'.
12874 * keymap.c (describe_vector): Remove parameters `indices' and
12875 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12876 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12878 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12880 * keyboard.c (timer_check): Remove parameter `do_it_now',
12881 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12882 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12883 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12885 * keyboard.c (read_char):
12886 * w32menu.c (w32_menu_display_help):
12887 * xmenu.c (show_help_event, menu_help_callback):
12888 Adjust calls to `show_help_echo'.
12890 * gtkutil.c (xg_maybe_add_timer):
12891 * keyboard.c (readable_events):
12892 * process.c (wait_reading_process_output):
12893 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12895 * insdel.c (adjust_markers_gap_motion):
12896 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12897 (gap_left, gap_right): Don't call it.
12899 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12901 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12902 incurred during fontification.
12904 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12906 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12907 (DEFVAR_PER_BUFFER): Don't pass it.
12909 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12910 (scrolling_window): Don't pass it.
12912 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12914 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12916 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12918 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12919 of variables specific to SELinux and computation of `encoded_absname'.
12921 * image.c (XPutPixel): Remove unused variable `height'.
12923 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12925 * unexw32.c (get_section_info): Remove unused variable `section'.
12927 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12928 (system_process_attributes): Remove unused variable `sess'.
12929 (sys_read): Remove unused variable `err'.
12931 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12932 (w32_wnd_proc): Remove unused variable `isdead'.
12933 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12934 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12935 (x_create_tip_frame): Remove unused variable `tem'.
12937 * w32inevt.c (w32_console_read_socket):
12938 Remove unused variable `no_events'.
12940 * w32term.c (x_draw_composite_glyph_string_foreground):
12941 Remove unused variable `width'.
12943 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12945 * w32term.c (x_set_glyph_string_clipping):
12946 Don't pass uninitialized region to CombineRgn.
12948 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12950 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12951 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12952 (Fx_close_connection): Remove unused variable `i'.
12954 * w32font.c (w32font_draw): Return number of glyphs.
12955 (w32font_open_internal): Remove unused variable `i'.
12956 (w32font_driver): Add missing initializer.
12958 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12959 (fill_in_menu): Remove unused variable `items_added'.
12961 * w32term.c (last_mouse_press_frame): Remove static global variable.
12962 (w32_clip_to_row): Remove unused variable `f'.
12963 (x_delete_terminal): Remove unused variable `i'.
12965 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12966 (NOTHING): Remove unused static global variable.
12967 (uniscribe_check_otf): Remove unused variable `table'.
12968 (uniscribe_font_driver): Add missing initializers.
12970 2011-03-23 Julien Danjou <julien@danjou.info>
12972 * term.c (Fsuspend_tty, Fresume_tty):
12973 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12974 * window.c (temp_output_buffer_show):
12975 * insdel.c (signal_before_change):
12976 * frame.c (Fhandle_switch_frame):
12977 * fileio.c (Fdo_auto_save):
12978 * emacs.c (Fkill_emacs):
12979 * editfns.c (save_excursion_restore):
12980 * cmds.c (internal_self_insert):
12981 * callint.c (Fcall_interactively):
12982 * buffer.c (Fkill_all_local_variables):
12983 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12985 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12986 unconditionally since it does the check itself.
12988 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12990 Fix more problems found by GCC 4.5.2's static checks.
12992 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12993 the first time through the loop, since we know p0 < p1 then.
12994 This also avoids a gcc -Wstrict-overflow warning.
12996 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12997 leading to a memory leak, possible in functions like
12998 load_charset_map_from_file that can allocate an unbounded number
12999 of objects (Bug#8318).
13001 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13002 that could (at least in theory) be that large.
13004 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13005 This is less likely to overflow, and avoids undefined behavior if
13006 overflow does occur. All callers changed. Use strtoul to scan
13007 for the unsigned long integer.
13008 (pint2hrstr): Simplify and tune code slightly.
13009 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13011 * scroll.c (do_scrolling): Work around GCC bug 48228.
13012 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13014 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13015 This also avoids a warning with gcc -Wstrict-overflow.
13016 (validate_x_resource_name): Simplify count usage.
13017 This also avoids a warning with gcc -Wstrict-overflow.
13019 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13022 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13024 * process.c (Fmake_network_process): Use socklen_t, not int,
13025 where POSIX says socklen_t is required in portable programs.
13026 This fixes a porting bug on hosts like 64-bit HP-UX, where
13027 socklen_t is wider than int (Bug#8277).
13028 (Fmake_network_process, server_accept_connection):
13029 (wait_reading_process_output, read_process_output):
13032 * process.c: Rename or move locals to avoid shadowing.
13033 (list_processes_1, Fmake_network_process):
13034 (read_process_output_error_handler, exec_sentinel_error_handler):
13035 Rename or move locals.
13036 (Fmake_network_process): Define label "retry_connect" only if needed.
13037 (Fnetwork_interface_info): Fix pointer signedness.
13038 (process_send_signal): Add cast to avoid pointer signedness problem.
13039 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13040 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13042 Make tparam.h and terminfo.c consistent.
13043 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13044 Include tparam.h instead, since it declares them.
13045 * cm.h (PC): Remove extern decl; tparam.h now does this.
13046 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13047 * terminfo.c: Include tparam.h, to check interfaces.
13048 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13049 (tparam): Adjust signature to match interface in tparam.h;
13050 this removes some undefined behavior. Check that outstring and len
13051 are zero, which they always are with Emacs.
13052 * tparam.h (PC, BC, UP): New extern decls.
13054 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13055 (xftfont_open): Rename locals to avoid shadowing.
13057 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13058 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13059 (OTF_TAG_SYM): Omit macro if not needed.
13060 (ftfont_list): Remove unused local.
13061 (get_adstyle_property, ftfont_pattern_entity):
13062 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13063 Rename locals to avoid shadowing.
13065 * xfont.c (xfont_list_family): Mark var as initialized.
13067 * xml.c (make_dom): Now static.
13069 * composite.c (composition_compute_stop_pos): Rename local to
13071 (composition_reseat_it): Remove unused locals.
13072 (find_automatic_composition, composition_adjust_point): Likewise.
13073 (composition_update_it): Mark var as initialized.
13074 (find_automatic_composition): Mark vars as initialized,
13075 with a FIXME (Bug#8290).
13077 character.h: Rename locals to avoid shadowing.
13078 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13079 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13080 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13081 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13082 to avoid shadowing.
13084 * textprop.c (property_change_between_p): Remove; unused.
13086 * intervals.c (interval_start_pos): Now static.
13088 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13090 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13091 Rename locals to avoid shadowing.
13093 * sound.c (wav_play, au_play, Fplay_sound_internal):
13094 Fix pointer signedness.
13095 (alsa_choose_format): Remove unused local var.
13096 (wav_play): Initialize a variable to 0, to prevent undefined
13097 behavior (Bug#8278).
13099 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13101 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13103 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13104 clobbering (Bug#8298).
13105 * sysdep.c (sys_subshell): Likewise.
13106 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13108 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13109 This should get cleaned up, so that child_setup has the
13110 same signature on all platforms.
13112 * callproc.c (call_process_cleanup): Now static.
13113 (relocate_fd): Rename locals to avoid shadowing.
13115 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13117 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13118 not to be necessary, and produces flickering.
13120 2011-03-20 Glenn Morris <rgm@gnu.org>
13122 * config.in: Remove file.
13124 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13126 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13127 are now in src/globals.h.
13128 (syms_of_minibuf): Remove spurious & from previous change.
13130 2011-03-20 Leo Liu <sdl.web@gmail.com>
13132 * minibuf.c (completing-read-function): New variable.
13133 (completing-read-default): Rename from completing-read.
13134 (completing-read): Call completing-read-function.
13136 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13138 * xfaces.c (Fx_load_color_file):
13139 Read color file from absolute filename (bug#8250).
13141 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13143 * makefile.w32-in: Update dependencies.
13145 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13147 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13149 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13151 Fix more problems found by GCC 4.5.2's static checks.
13153 * process.c (make_serial_process_unwind, send_process_trap):
13154 (sigchld_handler): Now static.
13156 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13157 That way, the code declares only the vars that it needs.
13158 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13159 * s/cygwin.h (PTY_ITERATION): Likewise.
13160 * s/darwin.h (PTY_ITERATION): Likewise.
13161 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13163 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13164 * process.c (allocate_pty): Don't declare stb unless it's needed.
13166 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13167 (CONSTANTLIM): Remove; unused.
13168 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13169 Define only if needed.
13171 * unexelf.c (unexec): Name an expression,
13172 to avoid gcc -Wbad-function-cast warning.
13173 Use a different way to cause a compilation error if anyone uses
13174 n rather than nn, a way that does not involve shadowing.
13175 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13177 * deps.mk (unexalpha.o): Remove; unused.
13179 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13180 * unexec.h: New file.
13181 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13182 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13183 Depend on unexec.h.
13184 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13185 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13186 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13187 Change as necessary to match prototype in unexec.h.
13189 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13191 (back_comment, skip_chars): Mark vars as initialized.
13193 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13194 Rename locals to avoid shadowing.
13196 * lread.c (read1): Rewrite so as not to use empty "else".
13197 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13199 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13201 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13202 warning when compiling print.c.
13204 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13205 instead of using an uninitialized var.
13206 (font_sort_entities): Mark var as initialized.
13208 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13210 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13211 pointers to constants.
13212 (font_parse_fcname): Remove unused vars.
13213 (font_delete_unmatched): Now static.
13214 (font_get_spec): Remove; unused.
13215 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13216 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13217 Rename or move locals to avoid shadowing.
13219 * fns.c (require_nesting_list, require_unwind): Now static.
13220 (Ffillarray): Rename locals to avoid shadowing.
13222 * floatfns.c (domain_error2): Define only if needed.
13223 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13225 * alloc.c (mark_backtrace): Move decl from here ...
13226 * lisp.h: ... to here, so that it can be checked.
13228 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13229 (Fdefvar): Rewrite so as not to use empty "else".
13230 (lisp_indirect_variable): Name an expression,
13231 to avoid gcc -Wbad-function-cast warning.
13232 (Fdefvar): Rename locals to avoid shadowing.
13234 * callint.c (quotify_arg, quotify_args): Now static.
13235 (Fcall_interactively): Rename locals to avoid shadowing.
13236 Use const pointer when appropriate.
13238 * lisp.h (get_system_name, get_operating_system_release):
13239 Move decls here, to check interfaces.
13240 * process.c (get_operating_system_release): Move decl to lisp.h.
13241 * xrdb.c (get_system_name): Likewise.
13242 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13243 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13244 some of which prompt warnings from gcc -Wbad-function-cast.
13245 (Fformat_time_string, Fencode_time, Finsert_char):
13246 (Ftranslate_region_internal, Fformat):
13247 Rename or remove local vars to avoid shadowing.
13248 (Ftranslate_region_internal): Mark var as initialized.
13250 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13253 * lisp.h (eassert): Check that the argument compiles, even if
13254 ENABLE_CHECKING is not defined.
13256 * data.c (Findirect_variable): Name an expression, to avoid
13257 gcc -Wbad-function-cast warning.
13258 (default_value, arithcompare, arith_driver, arith_error): Now static.
13259 (store_symval_forwarding): Rename local to avoid shadowing.
13260 (Fmake_variable_buffer_local, Fmake_local_variable):
13261 Mark variables as initialized.
13262 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13264 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13265 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13266 Rename locals to avoid shadowing.
13267 (mark_stack): Move local variables into the #ifdef region where
13269 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13270 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13272 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13273 (GC_STRING_CHARS): Remove; not used.
13274 (Fmemory_limit): Cast sbrk's returned value to char *.
13276 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13277 avoids undefined behavior in theory.
13279 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13281 Use functions, not macros, for up- and down-casing (Bug#8254).
13282 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13283 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13284 to use the following functions instead of these macros.
13285 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13286 EMACS_INT, since callers assume the returned value fits in int.
13287 (upcase1): Likewise, for UPCASE_TABLE.
13288 (uppercasep, lowercasep, upcase): New static inline functions.
13289 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13290 the race-condition problem in the old DOWNCASE.
13292 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13293 Rename locals to avoid shadowing.
13294 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13295 (regex_compile, re_search_2, re_match_2_internal):
13296 Remove unused local vars.
13297 (FREE_VAR): Rewrite so as not to use empty "else",
13298 which gcc can warn about.
13299 (regex_compile, re_match_2_internal): Mark locals as initialized.
13300 (RETALLOC_IF): Define only if needed.
13301 (WORDCHAR_P): Likewise. This one is never needed, but is used
13302 only in a comment talking about a compiler bug, so put inside
13303 the #if 0 of that comment.
13304 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13305 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13308 * search.c (boyer_moore): Rename locals to avoid shadowing.
13309 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13310 (PREV_CHAR_BOUNDARY): Likewise.
13312 * search.c (simple_search): Remove unused var.
13314 * dired.c (compile_pattern): Move decl from here ...
13315 * lisp.h: ... to here, so that it can be checked.
13316 (struct re_registers): New forward decl.
13318 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13320 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13322 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13323 Rename locals to avoid shadowing.
13324 (Fvertical_motion): Mark locals as initialized.
13326 * casefiddle.c (casify_object, casify_region): Now static.
13327 (casify_region): Mark local as initialized.
13329 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13331 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13332 New macros, so that the caller can use some names other than
13333 gcpro1, gcpro2, etc.
13334 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13336 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13337 argument, for consistency with GCPRO2_VAR, etc: it is now the
13338 prefix of the variable, not the variable itself. All uses
13340 * dired.c (directory_files_internal, file_name_completion):
13341 Rename locals to avoid shadowing.
13343 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13344 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13345 dired.c's scmp function, had undefined behavior.
13346 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13347 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13348 * buffer.h: ... to here, because these macros use current_buffer,
13349 and the new implementation with inline functions needs to have
13350 current_buffer in scope now, rather than later when the macros
13352 (downcase, upcase1): New static inline functions.
13353 (DOWNCASE, UPCASE1): Reimplement using these functions.
13354 This avoids undefined behavior in expressions like
13355 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13356 from race conditions in accessing the global variables
13357 case_temp1 and case_temp2.
13358 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13359 * lisp.h (case_temp1, case_temp2): Remove their decls.
13360 * character.h (ASCII_CHAR_P): Move from here ...
13361 * lisp.h: ... to here, so that the inline functions mentioned
13362 above can use them.
13364 * dired.c (directory_files_internal_unwind): Now static.
13366 * fileio.c (file_name_as_directory, directory_file_name):
13367 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13369 (file_name_as_directory): Use const pointers when appropriate.
13370 (Fexpand_file_name): Likewise. In particular, newdir might
13371 point at constant storage, so make it a const pointer.
13372 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13373 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13375 (Fset_file_times, Finsert_file_contents, auto_save_error):
13376 Rename locals to avoid shadowing.
13378 * minibuf.c (choose_minibuf_frame_1): Now static.
13379 (Ftry_completion, Fall_completions): Rename or remove locals
13380 to avoid shadowing.
13382 * marker.c (bytepos_to_charpos): Remove; unused.
13384 * lisp.h (verify_bytepos, count_markers): New decls,
13385 so that gcc does not warn that these functions aren't declared.
13387 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13388 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13389 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13390 (copy_text): Remove unused local var.
13392 * filelock.c (within_one_second): Now static.
13393 (lock_file_1): Rename local to avoid shadowing.
13395 * buffer.c (fix_overlays_before): Mark locals as initialized.
13396 (fix_start_end_in_overlays): Likewise. This function should be
13397 simplified by using pointers-to-pointers, but that's a different
13399 (switch_to_buffer_1): Now static.
13400 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13401 (report_overlay_modification): Rename locals to avoid shadowing.
13403 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13404 Fix pointer signedness issue.
13405 (sys_subshell): Mark local as volatile if checking for lint,
13406 to suppress a gcc -Wclobbered warning that does not seem to be right.
13407 (MAXPATHLEN): Define only if needed.
13409 * process.c (serial_open, serial_configure): Move decls from here ...
13410 * systty.h: ... to here, so that they can be checked.
13412 * fns.c (get_random, seed_random): Move extern decls from here ...
13413 * lisp.h: ... to here, so that they can be checked.
13415 * sysdep.c (reset_io): Now static.
13416 (wait_for_termination_signal): Remove; unused.
13418 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13419 (copy_keymap_item, append_key, push_text_char_description):
13421 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13422 (DENSE_TABLE_SIZE): Remove; unused.
13423 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13424 (describe_map_tree):
13425 Rename locals to avoid shadowing.
13427 * keyboard.c: Declare functions static if they are not used elsewhere.
13428 (echo_char, echo_dash, cmd_error, top_level_2):
13429 (poll_for_input, handle_async_input): Now static.
13430 (read_char, kbd_buffer_get_event, make_lispy_position):
13431 (make_lispy_event, make_lispy_movement, apply_modifiers):
13432 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13433 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13434 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13435 (read_key_sequence, read_char): Mark locals as initialized.
13436 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13438 * keyboard.h (make_ctrl_char): New decl.
13439 (mark_kboards): Move decl here ...
13440 * alloc.c (mark_kboards): ... from here.
13442 * lisp.h (force_auto_save_soon): New decl.
13444 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13445 (DEFINE_DUMMY_FUNCTION): New macro.
13446 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13448 (main): Add casts to avoid warnings
13449 if GCC considers string literals to be constants.
13451 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13453 * dbusbind.c: Pointer signedness fixes.
13454 (xd_signature, xd_append_arg, xd_initialize):
13455 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13456 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13457 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13458 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13460 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13461 if GCC considers string literals to be constants.
13462 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13464 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13466 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13467 (print_preprocess, print_object): New macro to fix last change.
13469 * print.c (print_preprocess): Don't forget font objects.
13471 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13473 * emacs.c (USAGE3): Doc fixes.
13475 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13477 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13480 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13482 * lisp.h (VWindow_system, Qfile_name_history):
13483 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13484 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13485 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13487 * w32select.c: Don't #include "keyboard.h".
13488 (run_protected): Add extern declaration for waiting_for_input.
13490 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13491 * w32console.c (detect_input_pending, read_input_pending)
13492 (encode_terminal_code):
13493 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13494 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13495 (w32_system_caret_y, Qfile_name_history):
13496 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13497 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13498 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13499 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13500 * w32proc.c (Qlocal, report_file_error):
13501 * w32term.c (Vwindow_system, updating_frame):
13502 * w32uniscribe.c (initialized, uniscribe_font_driver):
13503 Remove unneeded extern declarations.
13505 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13507 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13509 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13511 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13512 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13513 These macros can no longer be used for assignment.
13515 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13516 Assign struct members directly, instead of using BUF_BEGV etc.
13517 (record_buffer_markers, fetch_buffer_markers): New functions for
13518 recording and fetching special buffer markers.
13519 (set_buffer_internal_1, set_buffer_temp): Use them.
13521 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13523 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13525 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13526 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13528 * xdisp.c (hscroll_window_tree):
13529 (reconsider_clip_changes): Use PT instead of BUF_PT.
13531 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13533 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13534 $(EMACS_ROOT)/lib/intprops.h.
13536 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13538 Fix more problems found by GCC 4.5.2's static checks.
13540 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13541 to unsigned char * to avoid compiler diagnostic.
13542 (xg_free_frame_widgets): Make it clear that a local variable is
13543 needed only if USE_GTK_TOOLTIP.
13544 (gdk_window_get_screen): Make it clear that this macro is needed
13545 only if USE_GTK_TOOLTIP.
13546 (int_gtk_range_get_value): New function, which avoids a diagnostic
13547 from gcc -Wbad-function-cast.
13548 (xg_set_toolkit_scroll_bar_thumb): Use it.
13549 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13550 diagnostic from gcc -Wbad-function-cast.
13551 (get_utf8_string, xg_get_file_with_chooser):
13552 Rename locals to avoid shadowing.
13553 (create_dialog): Move locals to avoid shadowing.
13555 * xgselect.c (xg_select): Remove unused var.
13557 * image.c (four_corners_best): Mark locals as initialized.
13558 (gif_load): Initialize transparent_p to zero (Bug#8238).
13559 Mark another local as initialized.
13560 (my_png_error, my_error_exit): Mark with NO_RETURN.
13562 * image.c (clear_image_cache): Now static.
13563 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13564 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13565 (x_edge_detection): Remove unnecessary cast that
13566 gcc -Wbad-function-cast diagnoses.
13567 (gif_load): Fix pointer signedness.
13568 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13569 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13571 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13573 Improve quality of tests for time stamp overflow.
13574 For example, without this patch (encode-time 0 0 0 1 1
13575 1152921504606846976) returns the obviously-bogus value (-948597
13576 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13577 reports time overflow. See
13578 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13579 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13580 * editfns.c: Include limits.h and intprops.h.
13581 (TIME_T_MIN, TIME_T_MAX): New macros.
13582 (time_overflow): Move earlier, to before first use.
13583 (hi_time, lo_time): New functions, for an accurate test for
13584 out-of-range times.
13585 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13586 (Fget_internal_run_time): Don't assume time_t fits in int.
13587 (make_time): Use list2 instead of Fcons twice.
13588 (Fdecode_time): More accurate test for out-of-range times.
13589 (check_tm_member): New function.
13590 (Fencode_time): Use it, to test for out-of-range times.
13591 (lisp_time_argument): Don't rely on undefined left-shift and
13592 right-shift behavior when checking for time stamp overflow.
13594 * editfns.c (time_overflow): New function, refactoring common code.
13595 (Fformat_time_string, Fdecode_time, Fencode_time):
13596 (Fcurrent_time_string): Use it.
13598 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13599 * dired.c (make_time): Move to ...
13600 * editfns.c (make_time): ... here.
13601 * systime.h: Note the move.
13603 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13605 * fringe.c (update_window_fringes): Remove unused variables.
13607 * unexmacosx.c (copy_data_segment): Also copy __got section.
13610 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13612 * termcap.c [MSDOS]: Include "msdos.h".
13613 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13614 Constify `char *' arguments and their references according to
13615 prototypes in tparam.h.
13617 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13619 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13620 Adapt all references accordingly.
13622 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13624 2011-03-11 Tom Tromey <tromey@redhat.com>
13626 * buffer.c (syms_of_buffer): Remove obsolete comment.
13628 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13630 * termhooks.h (encode_terminal_code): Declare prototype.
13632 * msdos.c (encode_terminal_code): Don't declare prototype.
13634 * term.c (encode_terminal_code): Now external again, used by
13635 w32console.c and msdos.c.
13637 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13638 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13640 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13642 Fix some minor problems found by GCC 4.5.2's static checks.
13644 * fringe.c (update_window_fringes): Mark locals as initialized
13646 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13648 * alloc.c (mark_fringe_data): Move decl from here ...
13649 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13650 to check its interface.
13651 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13653 * fontset.c (free_realized_fontset): Now static.
13654 (Fset_fontset_font): Rename local to avoid shadowing.
13655 (fontset_font): Mark local as initialized.
13656 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13658 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13660 * xselect.c (x_disown_buffer_selections): Remove; not used.
13661 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13662 (x_own_selection, Fx_disown_selection_internal): Rename locals
13663 to avoid shadowing.
13664 (x_handle_dnd_message): Remove local to avoid shadowing.
13666 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13667 so that the caller can use some name other than gcpro1.
13668 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13669 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13670 (Fx_backspace_delete_keys_p):
13671 Use them to avoid shadowing, and rename vars to avoid shadowing.
13672 (x_decode_color, x_set_name, x_window): Now static.
13673 (Fx_create_frame): Add braces to silence GCC warning.
13674 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13675 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13676 Remove unused locals.
13677 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13678 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13679 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13682 * xterm.h (x_mouse_leave): New decl.
13684 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13685 Remove unused functions.
13686 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13687 (x_calc_absolute_position): Now static.
13688 (XTread_socket): Don't define label "out" unless it's used.
13689 Don't declare local "event" unless it's used.
13690 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13691 unless they are used.
13692 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13693 (x_fatal_error_signal): Remove; not used.
13694 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13695 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13696 (x_error_catcher, x_connection_closed, x_error_handler):
13697 (x_error_quitter, xembed_send_message, x_iconify_frame):
13698 (my_log_handler): Rename locals to avoid shadowing.
13699 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13700 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13702 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13703 Rename or move locals to avoid shadowing.
13704 (tty_defined_color, merge_face_heights): Now static.
13705 (free_realized_faces_for_fontset): Remove; not used.
13706 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13707 does not deduce is never used uninitialized.
13708 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13709 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13711 * terminal.c (store_terminal_param): Now static.
13713 * xmenu.c (menu_highlight_callback): Now static.
13714 (set_frame_menubar): Remove unused local.
13715 (xmenu_show): Rename parameter to avoid shadowing.
13716 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13717 since they might point to immutable storage.
13718 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13719 since it's unused otherwise.
13721 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13722 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13723 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13724 avoids a gcc -Wuninitialized diagnostic.
13725 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13726 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13727 does not deduce are never used uninitialized.
13729 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13731 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13732 * window.c (window_loop, size_window):
13733 (run_window_configuration_change_hook, enlarge_window): Likewise.
13735 * window.c (display_buffer): Now static.
13736 (size_window): Mark variables that gcc -Wuninitialized
13737 does not deduce are never used uninitialized.
13738 * window.h (check_all_windows): New decl, to forestall
13739 gcc -Wmissing-prototypes diagnostic.
13740 * dispextern.h (bidi_dump_cached_states): Likewise.
13742 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13744 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13745 Include <limits.h>.
13746 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13747 and to avoid gcc -Wuninitialized warning.
13748 (load_charset_map): Mark variables that gcc -Wuninitialized
13749 does not deduce are never used uninitialized.
13750 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13752 * coding.c (coding_set_source, coding_set_destination):
13753 Use "else { /* comment */ }" rather than "else /* comment */;"
13754 for clarity, and to avoid gcc -Wempty-body warning.
13755 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13756 a block, when the outer 'i' will do.
13757 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13758 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13759 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13760 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13761 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13762 Rename locals to avoid shadowing.
13763 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13764 * coding.c (emacs_mule_char, encode_invocation_designation):
13765 Now static, since they're not used elsewhere.
13766 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13767 (decode_coding_object, encode_coding_object, detect_coding_system):
13768 (decode_coding_emacs_mule): Mark variables that gcc
13769 -Wuninitialized does not deduce are never used uninitialized.
13770 (detect_coding_iso_2022): Initialize a local variable that might
13771 be used uninitialized. Leave a FIXME because it's not clear that
13772 this initialization is needed. (Bug#8211)
13773 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13774 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13775 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13776 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13777 Remove unused macros.
13779 * category.c (hash_get_category_set): Remove unused local var.
13780 (copy_category_table): Now static, since it's not used elsewhere.
13781 * character.c (string_count_byte8): Likewise.
13783 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13784 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13786 * chartab.c (copy_sub_char_table): Now static, since it's not used
13788 (sub_char_table_ref_and_range, char_table_ref_and_range):
13789 Rename locals to avoid shadowing.
13790 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13792 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13793 (BIDI_BOB): Remove unused macro.
13795 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13796 deduce are never used uninitialized.
13797 * term.c (encode_terminal_code): Likewise.
13799 * term.c (encode_terminal_code): Now static. Remove unused local.
13801 * tparam.h: New file.
13802 * term.c, tparam.h: Include it.
13803 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13804 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13805 Move these decls to tparam.h, and make them agree with what
13806 is actually in tparam.c. The previous trick of using incompatible
13807 decls in different modules does not conform to the C standard.
13808 All callers of tparam changed to use tparam's actual API.
13809 * tparam.c (tparam1, tparam, tgoto):
13810 Use const pointers where appropriate.
13812 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13813 * cm.h (struct cm): Likewise.
13814 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13815 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13816 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13817 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13818 (turn_on_face, init_tty): Likewise.
13819 * termchar.h (struct tty_display_info): Likewise.
13821 * term.c (term_mouse_position): Rename local to avoid shadowing.
13823 * alloc.c (mark_ttys): Move decl from here ...
13824 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13826 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13828 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13830 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13832 * search.c (compile_pattern_1): Remove argument regp, unused since
13833 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13834 (compile_pattern): Don't pass it.
13836 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13838 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13839 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13841 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13843 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13845 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13846 gdk_window_get_screen, gdk_window_get_geometry,
13847 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13848 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13849 (xg_get_pixbuf_from_pixmap): New function.
13850 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13851 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13852 Call xg_get_pixbuf_from_pixmap instead of
13853 gdk_pixbuf_get_from_drawable.
13854 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13855 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13856 (xg_check_special_colors): Use GtkStyleContext and its functions
13858 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13859 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13860 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13861 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13862 Call gtk_widget_get_preferred_size.
13863 (xg_frame_resized): gdk_window_get_geometry only takes 5
13865 (xg_win_to_widget, xg_event_is_for_menubar):
13866 Call gdk_x11_window_lookup_for_display.
13867 (xg_set_widget_bg): New function.
13868 (delete_cb): New function.
13869 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13870 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13871 (xg_set_background_color): Call xg_set_widget_bg.
13872 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13873 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13874 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13875 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13877 (update_frame_tool_bar): Call gtk_widget_hide.
13878 (xg_initialize): Use GDK_KEY_g.
13880 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13882 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13884 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13885 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13886 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13888 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13890 * w32xfns.c (select_palette): Check success of RealizePalette against
13891 GDI_ERROR, not zero.
13893 See ChangeLog.11 for earlier changes.
13895 ;; Local Variables:
13899 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13901 This file is part of GNU Emacs.
13903 GNU Emacs is free software: you can redistribute it and/or modify
13904 it under the terms of the GNU General Public License as published by
13905 the Free Software Foundation, either version 3 of the License, or
13906 (at your option) any later version.
13908 GNU Emacs is distributed in the hope that it will be useful,
13909 but WITHOUT ANY WARRANTY; without even the implied warranty of
13910 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13911 GNU General Public License for more details.
13913 You should have received a copy of the GNU General Public License
13914 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.