1 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3 *xdisp.c (display_line): Release buffer allocated for shelved bidi
6 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7 amount allocated this far in `bidi_cache_total_alloc'.
8 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9 non-zero, only free the data buffer without restoring the cache
10 contents. All callers changed.
12 * dispextern.h (bidi_unshelve_cache): Update prototype.
14 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
15 (move_it_in_display_line, move_it_to)
16 (move_it_vertically_backward, move_it_by_lines): Replace the call
17 to xfree to an equivalent call to bidi_unshelve_cache.
18 (move_it_in_display_line_to): Fix logic of returning
19 MOVE_POS_MATCH_OR_ZV in the bidi case.
21 2011-08-05 Eli Zaretskii <eliz@gnu.org>
23 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
24 came from a string character with a `cursor' property. (Bug#9229)
26 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
28 * Makefile.in (LIB_PTHREAD): New variable.
29 (LIBES): Add LIB_PTHREAD (Bug#9216).
31 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
32 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
34 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
36 * regex.c (re_iswctype): Remove some redundant boolean
39 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
41 * xterm.c (x_find_topmost_parent): New function.
42 (x_set_frame_alpha): Find topmost parent window with
43 x_find_topmost_parent and set the property there also (bug#9181).
44 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
46 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
48 * callproc.c (Fcall_process): Avoid vfork clobbering
49 the local vars buffer, coding_systems, current_dir.
51 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
53 * keymap.c (Fmake_composed_keymap): Move to subr.el.
55 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
57 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
58 so that it is not optimized away.
60 * xdisp.c (compute_display_string_pos): Remove unused local.
62 2011-08-02 Eli Zaretskii <eliz@gnu.org>
64 Fix slow cursor motion and scrolling in large buffers with
65 selective display, like Org Mode buffers. (Bug#9218)
67 * dispextern.h (struct bidi_it): New member disp_prop_p.
69 * xdisp.c: Remove one-slot cache of display string positions.
70 (compute_display_string_pos): Accept an additional argument
71 DISP_PROP_P; callers changed. Scan at most 5K characters forward
72 for a display string or property. If found, set DISP_PROP_P
75 * bidi.c (bidi_fetch_char): Accept an additional argument
76 DISP_PROP_P, and pass it to compute_display_string_pos.
77 Only handle text covered by a display string if DISP_PROP_P is returned
78 non-zero. All callers of bidi_fetch_char changed.
80 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
82 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
84 2010-12-03 Don March <don@ohspite.net>
86 * keymap.c (Fdefine_key): Fix non-prefix key error message when
87 last character M-[char] is translated to ESC [char] (bug#7541).
89 2011-08-02 Kenichi Handa <handa@m17n.org>
91 * lisp.h (uniprop_table): Extern it.
93 * chartab.c (uniprop_table): Make it non-static.
95 2011-08-01 Eli Zaretskii <eliz@gnu.org>
97 * xdisp.c (forward_to_next_line_start): Accept additional argument
98 BIDI_IT_PREV, and store into it the state of the bidi iterator had
100 (reseat_at_next_visible_line_start): Use the bidi iterator state
101 returned by forward_to_next_line_start to restore the state of
102 it->bidi_it after backing up to previous newline. (Bug#9212)
104 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
106 * regex.c (re_comp): Protoize.
107 (re_exec): Fix return type.
108 (regexec): Fix type of `ret'. (Bug#9203)
110 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
112 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
113 This is needed if max-image-size is a floating-point number.
115 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
117 * print.c (print_object): Print empty symbol as ##.
119 * lread.c (read1): Read ## as empty symbol.
121 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
123 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
124 setting frame foreground color (Bug#9175).
125 (x_set_background_color): Likewise.
127 * nsmenu.m (-setText): Size tooltip dimensions precisely to
129 (EmacsTooltip -init): Remove bezels and add shadows to
132 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
133 or scroll bar (Bug#8470).
135 * nsfont.m (nsfont_open): Remove assignment to voffset and
136 unnecessary vars hshink, expand, hd, full_height, min_height.
137 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
139 * nsterm.h (nsfont_info): Remove voffset field.
141 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
143 Implement strike-through and overline on NextStep (Bug#8863).
145 * nsfont.m (nsfont_open): Use underline position provided by font,
146 instead of hard-coded value of 2.
147 (nsfont_draw): Call ns_draw_text_decoration instead.
149 * nsterm.h: Add declaration for ns_draw_text_decoration.
151 * nsterm.m (ns_draw_text_decoration): New function for drawing
152 underline, overline, and strike-through.
153 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
154 ns_draw_text_decoration. Change treatment of cursor drawing to
155 accomodate underlining, etc.
157 2011-07-28 Eli Zaretskii <eliz@gnu.org>
159 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
162 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
164 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
165 Without this fix, if a signal arrives just after memory fills up,
166 'malloc' might be invoked reentrantly.
168 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
169 In other words, assume that every image size is allowed, on non-X
170 hosts. This assumption is probably wrong, but it lets Emacs compile.
172 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
174 * regex.c (re_iswctype): Convert return values to boolean.
176 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
178 * xdisp.c (compute_display_string_pos): Don't use cached display
179 string position if the buffer had its restriction changed.
182 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
184 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
186 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
188 Integer signedness and overflow and related fixes. (Bug#9079)
190 * bidi.c: Integer size and overflow fixes.
191 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
192 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
193 (bidi_cache_find_level_change, bidi_cache_ensure_space)
194 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
195 (bidi_find_other_level_edge):
196 Use ptrdiff_t instead of EMACS_INT where either will do.
197 This works better on 32-bit hosts configured --with-wide-int.
198 (bidi_cache_ensure_space): Check for size-calculation overflow.
199 Use % rather than repeated addition, for better worst-case speed.
200 Don't set bidi_cache_size until after xrealloc returns, because it
202 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
203 (bidi_cache_ensure_space): Also check that the bidi cache size
204 does not exceed that of the largest Lisp string or buffer. See Eli
205 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
207 * alloc.c (__malloc_size_t): Remove.
208 All uses replaced by size_t. See Andreas Schwab's note
209 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
211 * image.c: Improve checking for integer overflow.
212 (check_image_size): Assume that f is nonnull, since
213 it is always nonnull in practice. This is one less thing to
214 worry about when checking for integer overflow later.
215 (x_check_image_size): New function, which checks for integer
216 overflow issues inside X.
217 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
218 This removes the need for a memory_full check.
219 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
220 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
221 (xbm_read_bitmap_data): Change locals back to 'int', since
222 their values must fit in 'int'.
223 (xpm_load_image, png_load, tiff_load):
224 Invoke x_create_x_image_and_pixmap earlier,
225 to avoid much needless work if the image is too large.
226 (tiff_load): Treat overly large images as if
227 x_create_x_image_and_pixmap failed, not as malloc failures.
228 (gs_load): Use x_check_image_size.
230 * gtkutil.c: Omit integer casts.
231 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
232 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
234 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
236 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
237 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
238 would wrongly return t on a 64-bit host.
240 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
241 The plain *_OVERFLOW macros run afoul of GCC bug 49705
242 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
243 and therefore cause GCC to emit a bogus diagnostic in some cases.
245 * image.c: Integer signedness and overflow and related fixes.
246 This is not an exhaustive set of fixes, but it's time to
247 record what I've got.
248 (lookup_pixel_color, check_image_size): Remove redundant decls.
249 (check_image_size): Don't assume that arbitrary EMACS_INT values
250 fit in 'int', or that arbitrary 'double' values fit in 'int'.
251 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
252 (tiff_load, imagemagick_load_image):
253 Check for overflow in size calculations.
254 (x_create_x_image_and_pixmap): Remove unnecessary test for
255 xmalloc returning NULL; that can't happen.
256 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
257 (xpm_color_bucket): Use better integer hashing function.
258 (xpm_cache_color): Don't possibly over-allocate memory.
259 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
261 Use ptrdiff_t, not int or size_t, to record sizes.
262 (png_load): Don't assume values greater than 2**31 fit in 'int'.
263 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
264 either works, as we prefer signed integers.
265 (tiff_read_from_memory, tiff_write_from_memory):
266 Return tsize_t, not size_t, since that's what the TIFF API wants.
267 (tiff_read_from_memory): Don't fail simply because the read would
268 go past EOF; instead, return a short read.
269 (tiff_load): Omit no-longer-needed casts.
270 (Fimagemagick_types): Don't assume size fits into 'int'.
272 Improve hashing quality when configured --with-wide-int.
273 * fns.c (hash_string): New function, taken from sxhash_string.
274 Do not discard information about ASCII character case; this
275 discarding is no longer needed.
276 (sxhash-string): Use it. Change sig to match it. Caller changed.
277 * lisp.h: Declare it.
278 * lread.c (hash_string): Remove, since we now use fns.c's version.
279 The fns.c version returns a wider integer if --with-wide-int is
280 specified, so this should help the quality of the hashing a bit.
282 * emacs.c: Integer overflow minor fix.
283 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
284 Define only if GNU_LINUX.
285 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
287 * dispnew.c: Integer signedness and overflow fixes.
288 Remove unnecessary forward decls, that were a maintenance hassle.
289 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
291 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
292 (scrolling_window): Use ptrdiff_t, not int, for byte count.
293 (prepare_desired_row, line_draw_cost):
294 Use int, not unsigned, where either works.
295 (save_current_matrix, restore_current_matrix):
296 Use ptrdiff_t, not size_t, where either works.
297 (init_display): Check for overflow more accurately, and without
298 relying on undefined behavior.
300 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
301 Remove, replacing with the new symbols in lisp.h. All uses changed.
302 * fileio.c (make_temp_name):
303 * filelock.c (lock_file_1, lock_file):
304 * xdisp.c (message_dolog):
305 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
306 Use pMd etc. instead.
307 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
308 replacing the pWIDE etc. symbols removed from editfns.c.
310 * keyboard.h (num_input_events): Now uintmax_t.
311 This is (very slightly) less likely to mess up due to wraparound.
314 * buffer.c: Integer signedness fixes.
315 (alloc_buffer_text, enlarge_buffer_text):
316 Use ptrdiff_t rather than size_t when either will do, as we prefer
319 * alloc.c: Integer signedness and overflow fixes.
320 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
321 (__malloc_size_t): Default to size_t, not to int.
322 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
323 (Fgarbage_collect, mark_object_loop_halt, mark_object):
324 Prefer ptrdiff_t to size_t when either would do, as we prefer
326 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
327 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
328 Now const. Initialize with values that are in range even if char
330 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
331 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
332 These functions do the right thing with sizes > 2**32.
333 (check_depth): Now ptrdiff_t, not int.
334 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
335 Adjust to new way of storing sizes. Check for size overflow bugs
337 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
338 slightly wrong anyway, as it missed one instance of
339 XMALLOC_OVERRUN_CHECK_OVERHEAD.
340 (refill_memory_reserve): Omit needless cast to size_t.
341 (mark_object_loop_halt): Mark as externally visible.
343 * xselect.c: Integer signedness and overflow fixes.
344 (Fx_register_dnd_atom, x_handle_dnd_message):
345 Use ptrdiff_t, not size_t, since we prefer signed.
346 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
347 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
348 x_dnd_atoms_size and x_dnd_atoms_length.
350 * doprnt.c: Prefer signed to unsigned when either works.
354 * xdisp.c (vmessage):
355 Use ptrdiff_t, not size_t, when using or implementing doprnt,
356 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
357 prefer signed arithmetic to avoid comparison confusion.
358 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
361 Assume freestanding C89 headers, string.h, stdlib.h.
362 * data.c, doprnt.c, floatfns.c, print.c:
363 Include float.h unconditionally.
364 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
365 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
366 * regex.c: Likewise for stddef.h, string.h.
367 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
368 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
369 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
370 (STDC_HEADERS): Remove obsolete defines.
371 * sysdep.c: Include limits.h unconditionally.
373 Assume support for memcmp, memcpy, memmove, memset.
374 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
375 * regex.c (memcmp, memcpy):
376 Remove; we assume C89 now.
378 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
379 (__malloc_safe_bcopy): Remove; no longer needed.
381 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
382 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
383 well either way, and we prefer signed to unsigned.
385 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
387 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
388 closes the connection while we're reading (bug#9182).
390 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
392 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
393 are specified (Bug#9168).
395 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
397 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
398 Found by GCC static checking and --with-wide-int on a 32-bit host.
400 2011-07-25 Eli Zaretskii <eliz@gnu.org>
402 * xdisp.c (compute_display_string_pos): Fix logic of caching
403 previous display string position. Initialize cached_prev_pos to
404 -1. Fixes slow-down at the beginning of a buffer.
406 2011-07-24 Eli Zaretskii <eliz@gnu.org>
408 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
409 for attrs[LFACE_FONTSET_INDEX].
411 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
413 * xml.c (parse_region): Remove unused local
414 that was recently introduced.
416 2011-07-23 Eli Zaretskii <eliz@gnu.org>
418 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
419 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
421 * xdisp.c (move_it_in_display_line_to): Record the best matching
422 position for TO_CHARPOS while scanning the line, and restore it on
423 exit if none of the characters scanned was an exact match.
424 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
425 when exact match is impossible due to invisible text, and the
428 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
430 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
433 2011-07-22 Eli Zaretskii <eliz@gnu.org>
435 Fix a significant slow-down of cursor motion with C-n, C-p,
436 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
437 auto-repeat under bidi redisplay in fontified buffers.
438 * xdisp.c (compute_stop_pos_backwards): New function.
439 (next_element_from_buffer): Call compute_stop_pos_backwards to
440 find a suitable prev_stop when we find ourselves before
442 (reseat): Don't look for prev_stop, as that could mean a very long
444 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
445 <cached_disp_overlay_modiff>: Cache for last found display string
447 (compute_display_string_pos): Return the cached position if asked
448 about the same buffer in the same area of character positions, and
449 the buffer wasn't changed since the time the display string
452 2011-07-22 Eli Zaretskii <eliz@gnu.org>
454 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
455 is an integer, which is important for empty lines. (Bug#9149)
457 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
459 * frame.c (Fmodify_frame_parameters): In tty case, update the
460 default face if necessary (Bug#4238).
462 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
464 * editfns.c (Fstring_to_char): No need to explain what a character
465 is in the docstring (Bug#6576).
467 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
469 * xml.c (parse_region): Make sure we always return a tree.
471 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
473 * xml.c (parse_region): If a document contains only comments,
476 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
478 * xml.c (make_dom): Return comments, too.
480 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
483 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
484 and the surrounding thread.
485 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
486 rather than fgets, and retry after EINTR. Otherwise, 'emacs
487 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
489 * s/openbsd.h (BROKEN_SIGIO): Define.
490 * unexelf.c (unexec) [__OpenBSD__]:
491 Don't update the .mdebug section of the Alpha COFF symbol table.
493 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
495 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
498 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
500 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
501 This fixes some race conditions on the permissions of any newly
504 * alloc.c (valid_pointer_p): Use pipe, not open.
505 This fixes some permissions issues when debugging.
507 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
508 If fchown fails to set both uid and gid, try to set just gid,
509 as that is sometimes allowed. Adjust the file's mode to eliminate
510 setuid or setgid bits that are inappropriate if fchown fails.
512 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
514 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
515 to compare Lisp_Objects.
516 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
517 global_gnutls_log_level, don't mistake it for a Lisp_Object.
518 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
520 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
522 * lread.c (read_integer): Unread even EOF character.
523 (read1): Likewise. Properly record start position of symbol.
525 * lread.c (read1): Read `#:' as empty uninterned symbol if no
526 symbol character follows.
528 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
530 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
531 This works around a problem with the previous change to Fcopy_file.
532 Recent glibc declares fchown with __attribute__((warn_unused_result)),
533 and without this change, GCC might complain about discarding
534 fchown's return value.
536 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
538 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
540 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
542 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
544 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
546 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
547 it's used from the C level.
549 * process.c: Use the same condition for POLL_FOR_INPUT in both
550 keyboard.c and process.c (bug#1858).
552 2011-07-09 Lawrence Mitchell <wence@gmx.li>
554 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
555 (Fgnutls_boot): Use it.
557 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
559 * doc.c (Fsubstitute_command_keys): Revert last change.
561 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
563 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
564 quotes the next character, and doesn't affect other longer
565 sequences (bug#8935).
567 * lread.c (syms_of_lread): Clarify that is isn't only
568 `eval-buffer' and `eval-defun' that's affected by
569 `lexical-binding' (bug#8460).
571 2011-07-15 Eli Zaretskii <eliz@gnu.org>
573 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
574 bidi redisplay when a line includes both an image and is
577 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
579 Fix minor problems found by static checking.
580 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
581 (elsz): Now a signed constant, not a size_t var. We prefer signed
582 types to unsigned, to avoid integer comparison confusion. Without
583 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
584 "cannot optimize loop, the loop counter may overflow", a symptom
586 * indent.c (Fvertical_motion): Mark locals as initialized.
587 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
589 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
591 * search.c (Fre_search_backward): Mention `case-fold-search' in
592 all the re_search_* functions (bug#8138).
594 * keyboard.c (Fopen_dribble_file): Document when the file is
597 2011-07-14 Eli Zaretskii <eliz@gnu.org>
599 * bidi.c (bidi_dump_cached_states): Fix format of displaying
602 Support bidi reordering of display and overlay strings.
603 * xdisp.c (compute_display_string_pos)
604 (compute_display_string_end): Accept additional argument STRING.
605 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
606 (reseat_to_string): Initialize bidi_it->string.s and
607 bidi_it->string.schars.
608 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
609 NULL (avoids a crash in bidi_paragraph_init).
610 Initialize itb.string.lstring.
611 (init_iterator): Call bidi_init_it only of a valid
612 buffer position was specified. Initialize paragraph_embedding to
614 (reseat_to_string): Initialize the bidi iterator.
615 (display_string): If we need to ignore text properties of
616 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
617 original value of -1 will not work with bidi.)
618 (compute_display_string_pos): First arg is now struct
619 `text_pos *'; all callers changed. Support display properties on
621 (compute_display_string_end): Support display properties on Lisp
623 (init_iterator, reseat_1, reseat_to_string): Initialize the
624 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
625 when iterating on a string not from display properties).
626 (compute_display_string_pos, compute_display_string_end):
627 Fix calculation of the object to scan. Fixes an error when using
629 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
630 base_level_stop; instead, set base_level_stop to BEGV.
631 Fixes crashes in vertical-motion.
632 (next_element_from_buffer): Improve commentary for when
633 the iterator is before prev_stop.
634 (init_iterator): Initialize bidi_p from the default value of
635 bidi-display-reordering, not from buffer-local value. Use the
636 buffer-local value only if initializing for buffer iteration.
637 (handle_invisible_prop): Support invisible properties on strings
638 that are being bidi-reordered.
639 (set_iterator_to_next): Support bidi reordering of C strings and
641 (next_element_from_string): Support bidi reordering of Lisp
643 (handle_stop_backwards): Support Lisp strings as well.
644 (display_string): Support display of R2L glyph rows.
645 Use IT_STRING_CHARPOS when displaying from a Lisp string.
646 (init_iterator): Don't initialize it->bidi_p for strings
648 (reseat_to_string): Initialize it->bidi_p for strings here.
649 (next_element_from_string, next_element_from_c_string)
650 (next_element_from_buffer): Add xassert's for correspondence
651 between IT's object being iterated and it->bidi_it.string
653 (face_before_or_after_it_pos): Support bidi iteration.
654 (next_element_from_c_string): Handle the case of the first string
655 character that is not the first one in the visual order.
656 (get_visually_first_element): New function, refactored from common
657 parts of next_element_from_buffer, next_element_from_string, and
658 next_element_from_c_string.
659 (tool_bar_lines_needed, redisplay_tool_bar)
660 (display_menu_bar): Force left-to-right direction. Add a FIXME
661 comment for making that be controlled by a user option.
662 (push_it, pop_it): Save and restore the state of the
663 bidi iterator. Save and restore the bidi_p flag.
664 (pop_it): Iterate out of display property for string iteration as
666 (iterate_out_of_display_property): Support iteration over strings.
667 (handle_single_display_spec): Set up it->bidi_it for iteration
668 over a display string, and call bidi_init_it.
669 (handle_single_display_spec, next_overlay_string)
670 (get_overlay_strings_1, push_display_prop): Set up the bidi
671 iterator for displaying display or overlay strings.
672 (forward_to_next_line_start): Don't use the shortcut if
674 (back_to_previous_visible_line_start): If handle_display_prop
675 pushed the iterator stack, restore the internal state of the bidi
676 iterator by calling bidi_pop_it same number of times.
677 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
678 and we are bidi-iterating, don't decrement the iterator position;
679 instead, set the first_elt flag in the bidi iterator, to produce
681 (reseat_1): Remove redundant setting of string_from_display_prop_p.
682 (push_display_prop): xassert that we are iterating a buffer.
683 (push_it, pop_it): Save and restore paragraph_embedding member.
684 (handle_single_display_spec, next_overlay_string)
685 (get_overlay_strings_1, reseat_1, reseat_to_string)
686 (push_display_prop): Set up the `unibyte' member of bidi_it.string
687 correctly. Don't assume unibyte strings are not bidi-reordered.
688 (compute_display_string_pos)
689 (compute_display_string_end): Fix handling the case of C string.
690 (push_it, pop_it): Save and restore from_disp_prop_p.
691 (handle_single_display_spec, push_display_prop): Set the
692 from_disp_prop_p flag.
693 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
694 (pop_it): Call iterate_out_of_display_property only if we are
695 popping after iteration over a string that came from a display
696 property. Fix a typo in popping stretch info. Add an assertion
697 for verifying that the iterator position is in sync with the bidi
699 (handle_single_display_spec, get_overlay_strings_1)
700 (push_display_prop): Fix initialization of paragraph direction for
701 string when that of the parent object is not yet determined.
702 (reseat_1): Call bidi_init_it to resync the bidi
703 iterator with IT's position. (Bug#7616)
704 (find_row_edges): If ROW->start.pos gives position
705 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
706 (handle_stop, back_to_previous_visible_line_start, reseat_1):
707 Reset the from_disp_prop_p flag.
708 (SAVE_IT, RESTORE_IT): New macros.
709 (pos_visible_p, face_before_or_after_it_pos)
710 (back_to_previous_visible_line_start)
711 (move_it_in_display_line_to, move_it_in_display_line)
712 (move_it_to, move_it_vertically_backward, move_it_by_lines)
713 (try_scrolling, redisplay_window, display_line): Use them when
714 saving a temporary copy of the iterator and restoring it back.
715 (back_to_previous_visible_line_start, reseat_1)
716 (init_iterator): Empty the bidi cache "stack".
717 (move_it_in_display_line_to): If iterator ended up at
718 EOL, but we never saw any buffer positions smaller than
719 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
720 motion in bidi-reordered lines.
721 (move_it_in_display_line_to): Record prev_method and prev_pos
722 immediately before the call to set_iterator_to_next. Fixes cursor
723 motion in bidi-reordered lines with stretch glyphs and strings
724 displayed in margins. (Bug#8133) (Bug#8867)
725 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
727 (pos_visible_p): Support positions in bidi-reordered lines.
728 Save and restore bidi cache.
730 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
731 (bidi_paragraph_info): Delete unused struct.
732 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
733 (bidi_cache_start): New variable.
734 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
736 (bidi_cache_fetch_state, bidi_cache_search)
737 (bidi_cache_find_level_change, bidi_cache_iterator_state)
738 (bidi_cache_find, bidi_peek_at_next_level)
739 (bidi_level_of_next_char, bidi_find_other_level_edge)
740 (bidi_move_to_visually_next): Compare cache index with
741 bidi_cache_start rather than with zero.
742 (bidi_fetch_char): Accept new argument STRING; all callers
743 changed. Support iteration over a string. Support strings with
744 display properties. Support unibyte strings. Fix the type of
745 `len' according to what STRING_CHAR_AND_LENGTH expects.
746 (bidi_paragraph_init, bidi_resolve_explicit_1)
747 (bidi_resolve_explicit, bidi_resolve_weak)
748 (bidi_level_of_next_char, bidi_move_to_visually_next):
749 Support iteration over a string.
750 (bidi_set_sor_type, bidi_resolve_explicit_1)
751 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
752 can now be zero (for strings); special values 0 and -1 were
753 changed to -1 and -2, respectively.
754 (bidi_char_at_pos): New function.
755 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
756 Call it instead of FETCH_MULTIBYTE_CHAR.
757 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
758 initialized to valid values.
759 (bidi_init_it): Don't initialize charpos and bytepos with invalid
761 (bidi_level_of_next_char): Allow the sentinel "position" to pass
762 the test for valid cached positions. Fix the logic for looking up
763 the sentinel state in the cache. GCPRO the Lisp string we are
765 (bidi_push_it, bidi_pop_it): New functions.
766 (bidi_initialize): Initialize the bidi cache start stack pointer.
767 (bidi_cache_ensure_space): New function, refactored from part of
768 bidi_cache_iterator_state. Don't assume the required size is just
769 one BIDI_CACHE_CHUNK away.
770 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
771 (bidi_count_bytes, bidi_char_at_pos): New functions.
772 (bidi_cache_search): Don't assume bidi_cache_last_idx is
773 always valid if bidi_cache_idx is valid.
774 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
775 is valid if it's going to be used.
776 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
777 (bidi_cache_fetch_state, bidi_cache_search)
778 (bidi_cache_find_level_change, bidi_cache_ensure_space)
779 (bidi_cache_iterator_state, bidi_cache_find)
780 (bidi_find_other_level_edge, bidi_cache_start_stack):
781 All variables related to cache indices are now EMACS_INT.
783 * dispextern.h (struct bidi_string_data): New structure.
784 (struct bidi_it): New member `string'. Make flag members be 1-bit
785 fields, and put them last in the struct.
786 (compute_display_string_pos, compute_display_string_end):
788 (bidi_push_it, bidi_pop_it): Add prototypes.
789 (struct iterator_stack_entry): New members bidi_p,
790 paragraph_embedding, and from_disp_prop_p.
791 (struct it): Member bidi_p is now a bit field 1 bit wide.
792 (bidi_shelve_cache, bidi_unshelve_cache):
795 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
796 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
797 and vector-like objects.
799 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
800 cache around display iteration.
802 * window.c (Fwindow_end, window_scroll_pixel_based)
803 (displayed_window_lines, Frecenter): Save and restore the bidi
804 cache around display iteration.
806 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
808 * editfns.c (Fdelete_region): Clarify the use of the named
809 parameters (bug#6788).
811 2011-07-14 Martin Rudalics <rudalics@gmx.at>
813 * indent.c (Fvertical_motion): Set and restore w->pointm when
814 saving and restoring the window's buffer (Bug#9006).
816 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
818 * editfns.c (Fstring_to_char): Clarify just what is returned
819 (bug#6576). Text by Eli Zaretskii.
821 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
823 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
825 2011-07-13 Eli Zaretskii <eliz@gnu.org>
827 * buffer.c (mmap_find): Fix a typo.
829 2011-07-13 Johan Bockgård <bojohan@gnu.org>
831 Fix execution of x selection hooks.
832 * xselect.c (Qx_lost_selection_functions)
833 (Qx_sent_selection_functions): New vars.
834 (syms_of_xselect): DEFSYM them.
835 (x_handle_selection_request): Pass Qx_sent_selection_functions
836 rather than Vx_sent_selection_functions to Frun_hook_with_args.
837 (x_handle_selection_clear,x_clear_frame_selections):
838 Pass Qx_lost_selection_functions rather than
839 Vx_lost_selection_functions to Frun_hook_with_args.
841 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
843 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
844 The old code sometimes used this field without initializing it.
846 * alloc.c (gc_sweep): Don't read past end of array.
847 In theory, the old code could also have corrupted Emacs internals,
848 though it'd be very unlikely.
850 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
852 * character.c (Fcharacterp): Don't advertise optional ignored
855 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
857 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
860 * window.c (Fset_window_start): Doc fix (bug#4199).
861 (Fset_window_hscroll): Ditto.
863 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
865 Fix minor new problems caught by GCC 4.6.1.
866 * term.c (init_tty): Remove unused local.
867 * xsettings.c (store_monospaced_changed): Define this function only
868 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
871 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
873 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
875 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
877 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
878 are the mini-buffer and the echo area (bug#3320).
880 * term.c (init_tty): Remove support for supdup, c10 and perq
881 terminals, which are no longer supported (bug#1482).
883 2011-07-10 Johan Bockgård <bojohan@gnu.org>
885 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
887 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
889 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
890 for non-popups (Bug#3642).
892 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
894 * alloc.c (reset_malloc_hooks): Protoize.
895 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
896 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
897 * cm.c (losecursor): Likewise.
898 * data.c (fmod): Likewise.
899 * dispnew.c (swap_glyphs_in_rows): Likewise.
900 * emacs.c (memory_warning_signal): Likewise.
901 * floatfns.c (float_error): Likewise.
902 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
903 (otf_open, font_otf_capability, generate_otf_features)
904 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
906 * image.c (pbm_read_file): Likewise.
907 * indent.c (string_display_width): Likewise.
908 * intervals.c (check_for_interval, search_for_interval)
909 (inc_interval_count, count_intervals, root_interval)
910 (adjust_intervals_for_insertion, make_new_interval): Likewise.
911 * lread.c (defalias): Likewise.
912 * ralloc.c (r_alloc_check): Likewise.
913 * regex.c (set_image_of_range_1, set_image_of_range)
914 (regex_grow_registers): Likewise.
915 * sysdep.c (strerror): Likewise.
916 * termcap.c (valid_filename_p, tprint, main): Likewise.
917 * tparam.c (main): Likewise.
918 * unexhp9k800.c (run_time_remap, save_data_space)
919 (update_file_ptrs, read_header, write_header, calculate_checksum)
920 (copy_file, copy_rest, display_header): Likewise.
921 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
923 * xdisp.c (check_it): Likewise.
924 * xfaces.c (register_color, unregister_color, unregister_colors):
926 * xfns.c (print_fontset_result): Likewise.
927 * xrdb.c (member, fatal, main): Likewise.
929 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
931 Fix minor problems found by static checking (Bug#9031).
932 * chartab.c (char_table_set_range, map_sub_char_table):
933 Remove unused locals.
934 (uniprop_table): Now static.
935 * composite.c (_work_char): Remove unused static var.
937 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
939 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
941 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
943 * gtkutil.c (qttip_cb): Remove code without function.
945 2011-07-09 Eli Zaretskii <eliz@gnu.org>
947 * w32.c (pthread_sigmask): New stub.
949 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
951 Use pthread_sigmask, not sigprocmask (Bug#9010).
952 sigprocmask is portable only for single-threaded applications, and
953 Emacs can be multi-threaded when it uses GTK.
954 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
956 * callproc.c (Fcall_process):
957 * process.c (create_process):
958 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
959 Use pthread_sigmask, not sigprocmask.
961 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
963 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
964 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
967 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
969 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
970 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
971 (xg_hide_tooltip): Fix comment.
973 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
974 in registerServicesMenuSendTypes.
975 (validRequestorForSendType): Don't check ns_return_types.
977 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
980 2011-07-08 Jason Rumney <jasonr@gnu.org>
982 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
983 frame struct members of non-existent frames (Bug#6284).
985 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
987 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
988 variable firstTime not needed on OSX >= 10.6.
989 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
990 >= 10.5. Use setKnobProportion, setDoubleValue.
992 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
993 (MAC_OS_X_VERSION_10_5): Define if not defined.
994 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
995 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
996 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
998 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
999 cString and lossyCString on OSX >= 10.4
1001 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1002 sizeToFit on OSX >= 10.2.
1004 * nsimage.m (allocInitFromFile): Don't use deprecated method
1005 bestRepresentationForDevice on OSX >= 10.6.
1007 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1010 * emacs.c: Declare unexec_init_emacs_zone.
1012 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1014 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1016 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1017 on svcsMenu (Bug#8842).
1019 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1021 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1023 * nsterm.m (QUTF8_STRING): Declare.
1024 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1025 (validRequestorForSendType): Return type is (id).
1026 Change indexOfObjectIdenticalTo to indexOfObject.
1027 Check if we have local selection before returning self (Bug#8842).
1028 (writeSelectionToPasteboard): Put local selection into paste board
1029 if we have a local selection (Bug#8842).
1030 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1032 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1033 (ns_get_local_selection): Declare.
1035 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1037 * keymap.c (describe_map_tree): Don't insert a double newline at
1038 the end of the buffer (bug#1169) and return whether we inserted
1041 * callint.c (Fcall_interactively): Change "reading args" to
1042 "providing args" to try to clarify what it does (bug#1010).
1044 2011-07-07 Kenichi Handa <handa@m17n.org>
1046 * composite.c (composition_compute_stop_pos): Ignore a static
1047 composition starting before CHARPOS (Bug#8915).
1049 * xdisp.c (handle_composition_prop): Likewise.
1051 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1053 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1056 2011-07-07 Kenichi Handa <handa@m17n.org>
1058 * character.h (unicode_category_t): New enum type.
1060 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1061 (Qchar_code_property_table): New variable.
1062 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1063 (UNIPROP_COMPRESSED_FORM_P): New macros.
1064 (char_table_ascii): Uncompress the compressed values.
1065 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1066 Uncompress the compressed values.
1067 (sub_char_table_ref_and_range): Likewise.
1068 (char_table_ref_and_range): Uncompress the compressed values.
1069 (sub_char_table_set): New arg is_uniprop. Callers changed.
1070 Uncompress the compressed values.
1071 (sub_char_table_set_range): Args changed. Callers changed.
1072 (char_table_set_range): Adjuted for the above change.
1073 (map_sub_char_table): Delete args default_val and parent. Add arg
1074 top. Give decoded values to a Lisp function.
1075 (map_char_table): Adjust for the above change. Give decoded
1076 values to a Lisp function. Gcpro more variables.
1077 (uniprop_table_uncompress)
1078 (uniprop_decode_value_run_length): New functions.
1079 (uniprop_decoder, uniprop_decoder_count): New variables.
1080 (uniprop_get_decoder, uniprop_encode_value_character)
1081 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1083 (uniprop_encoder, uniprop_encoder_count): New variables.
1084 (uniprop_get_encoder, uniprop_table)
1085 (Funicode_property_table_internal, Fget_unicode_property_internal)
1086 (Fput_unicode_property_internal): New functions.
1087 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1088 Sunicode_property_table_internal, Sget_unicode_property_internal,
1089 and Sput_unicode_property_internal. Defvar_lisp
1090 char-code-property-alist.
1092 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1093 Vunicode_category_table.
1095 * font.c (font_range): Adjust for the change of
1096 Vunicode_category_table.
1098 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1100 * m/iris4d.h: Remove file, move contents ...
1101 * s/irix6-5.h: ... here.
1103 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1105 Remove unportable assumption about struct layout (Bug#8884).
1106 * alloc.c (mark_buffer):
1107 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1108 (clone_per_buffer_values): Don't assume that
1109 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1110 This isn't true in general, and it's particularly not true
1111 if Emacs is configured with --with-wide-int.
1112 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1113 New macros, used in the buffer.c change.
1115 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1117 * xsettings.c: Use both GConf and GSettings if both are available.
1118 (store_config_changed_event): Add comment.
1119 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1120 (store_tool_bar_style_changed): New functions.
1121 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1122 (struct xsettings): Move font inside HAVE_XFT.
1123 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1124 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1125 Move inside HAVE_XFT.
1126 (something_changed_gsettingsCB): Rename from something_changedCB.
1127 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1129 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1130 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1131 (something_changed_gconfCB): Rename from something_changedCB.
1132 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1133 (parse_settings): Move check for font inside HAVE_XFT.
1134 (read_settings, apply_xft_settings): Add comment.
1135 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1136 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1137 call store_font_name_changed.
1138 (xft_settings_event): Add comment.
1139 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1140 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1141 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1142 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1143 (xsettings_initialize): Call init_gsettings last.
1144 (xsettings_get_system_font, xsettings_get_system_normal_font):
1147 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1149 Random fixes. E.g., (random) never returned negative values.
1150 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1151 subseconds part to the entropy, as that's a bit more random.
1152 Prefer signed to unsigned, since the signedness doesn't matter and
1153 in general we prefer signed. When given a limit, use a
1154 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1155 latter isn't right if USE_2_TAGS_FOR_INTS.
1156 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1157 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1159 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1161 * textprop.c (text_property_stickiness):
1162 Obey Vtext_property_default_nonsticky.
1163 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1164 * w32fns.c (syms_of_w32fns):
1165 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1167 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1169 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1170 This is more efficient than Ffile_directory_p and avoids a minor race.
1172 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1174 * buffer.c (Foverlay_put): Say what the return value is
1177 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1178 is a directory before asking whether to use the file name
1180 (barf_or_query_if_file_exists): Make the "File is a directory"
1181 error be more correct.
1183 * fns.c (Frequire): Remove the mention of the .gz files, since
1184 that's installation-specific, but keep the mention of
1185 `get-load-suffixes'.
1187 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1189 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1190 Report string overflow if the output is too long.
1192 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1194 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1195 (syms_of_gnutls): Remove duplicate DEFSYM for
1196 Qgnutls_bootprop_verify_hostname_error, an error for
1197 Qgnutls_bootprop_verify_error (which is no longer used).
1199 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1200 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1201 Also (re)move comments that are misplaced or no longer relevant.
1203 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1205 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1207 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1209 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1210 and background color parameters if they have been changed.
1212 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1214 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1216 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1218 * xsettings.c (SYSTEM_FONT): Define only when used.
1219 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1221 * keymap.c (access_keymap_1): Now static.
1223 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1225 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1226 leave any prefix arg for the up event (Bug#1586).
1228 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1230 * lread.c (syms_of_lread): Mention single symbols defined by
1231 `defvar' or `defconst' (bug#7154).
1233 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1234 (Frequire): Mention get-load-suffixes.
1236 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1238 * window.h (window): Remove clone_number slot.
1239 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1241 (make_parent_window, make_window, saved_window)
1242 (Fset_window_configuration, save_window_save): Don't deal with
1244 * buffer.c (Qclone_number): Remove declaration.
1245 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1247 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1249 Add multiple inheritance to keymaps.
1250 * keymap.c (Fmake_composed_keymap): New function.
1251 (Fset_keymap_parent): Simplify.
1252 (fix_submap_inheritance): Remove.
1253 (access_keymap_1): New function extracted from access_keymap to handle
1254 embedded parents and handle lists of maps.
1255 (access_keymap): Use it.
1256 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1257 (Fcopy_keymap): Handle embedded parents.
1258 (Fcommand_remapping, define_as_prefix): Simplify.
1259 (Fkey_binding): Simplify.
1260 (syms_of_keymap): Move minibuffer-local-completion-map,
1261 minibuffer-local-filename-completion-map,
1262 minibuffer-local-must-match-map, and
1263 minibuffer-local-filename-must-match-map to Elisp.
1264 (syms_of_keymap): Defsubr make-composed-keymap.
1265 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1266 (parse_menu_item): Trivial simplification.
1268 2011-07-01 Glenn Morris <rgm@gnu.org>
1270 * Makefile.in (SETTINGS_LIBS): Fix typo.
1272 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1274 * coding.c (Fencode_coding_string): Record the last coding system
1275 used, as the function doc string says (bug#8738).
1277 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1279 * xsettings.c (store_monospaced_changed): Take new font as arg and
1280 check for change against current_mono_font.
1281 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1282 (emacs_settings_constructor, emacs_settings_get_property)
1283 (emacs_settings_set_property, emacs_settings_class_init)
1284 (emacs_settings_init, gsettings_obj): Remove.
1285 (something_changedCB): New function for HAVE_GSETTINGS.
1286 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1287 with value as argument.
1288 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1289 g_settings_new (Bug#8967). Do not create gsettings_obj.
1290 Remove calls to g_settings_bind. Connect something_changedCB to
1293 * xgselect.c: Add defined (HAVE_GSETTINGS).
1294 (xgselect_initialize): Ditto.
1296 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1297 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1300 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1302 * eval.c (struct backtrace): Simplify and port the data structure.
1303 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1304 signed bit field, as this assumption is not portable and it makes
1305 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1306 "char debug_on_exit : 1" as this is not portable either; instead,
1307 use the portable "unsigned int debug_on_exit : 1". Remove unused
1308 member evalargs. Remove obsolete comments about cc bombing out.
1310 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1312 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1313 Let HAVE_GSETTINGS override HAVE_GCONF.
1314 (store_monospaced_changed): New function.
1315 (EMACS_SETTINGS): A new type derived from GObject to handle
1316 GSettings notifications.
1317 (emacs_settings_constructor, emacs_settings_get_property)
1318 (emacs_settings_set_property, emacs_settings_class_init):
1320 (gsettings_client, gsettings_obj): New variables.
1321 (GSETTINGS_SCHEMA): New define.
1322 (something_changedCB): Call store_monospaced_changed.
1323 (init_gsettings): New function.
1324 (xsettings_initialize): Call init_gsettings.
1325 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1328 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1331 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1333 * window.c (resize_root_window, grow_mini_window)
1334 (shrink_mini_window): Rename Qresize_root_window to
1335 Qwindow_resize_root_window and Qresize_root_window_vertically to
1336 Qwindow_resize_root_window_vertically.
1338 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1340 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1342 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1344 * makefile.w32-in: Redesign dependencies so they reflect more
1345 clearly which files are directly included by each source file,
1346 and not through other includes.
1348 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1350 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1351 (sort_overlays, overlay_strings): When an overlay's clone number
1352 matches the window's clone number process the overlay even if
1353 the overlay's window property doesn't match the current window.
1355 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1356 (Fwindow_hchild): Rename to Fwindow_left_child.
1357 (Fwindow_next): Rename to Fwindow_next_sibling.
1358 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1359 (resize_window_check): Rename to window_resize_check.
1360 (resize_window_apply): Rename to window_resize_apply.
1361 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1362 (Fdelete_other_windows_internal, resize_frame_windows)
1363 (Fsplit_window_internal, Fdelete_window_internal)
1364 (grow_mini_window, shrink_mini_window)
1365 (Fresize_mini_window_internal): Fix callers accordingly.
1367 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1369 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1370 (emacs_fixed_set_min_size): Remove.
1371 (emacs_fixed_new): Take frame as argument.
1373 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1374 (_EmacsFixedPrivate): Remove minwidth/height.
1375 Add struct frame *f.
1376 (emacs_fixed_init): Initialize priv->f.
1377 (get_parent_class, emacs_fixed_set_min_size): Remove.
1378 (emacs_fixed_new): Set priv->f to argument.
1379 (emacs_fixed_get_preferred_width)
1380 (emacs_fixed_get_preferred_height): Use min_width/height from
1381 frames size_hint to set minimum and natural (Bug#8919).
1382 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1383 and use min_width/height from frames size_hint to set
1384 min_width/height (Bug#8919).
1386 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1387 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1390 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1392 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1393 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1396 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1398 * process.c (wait_reading_process_output): Bypass select if
1399 waiting for a cell while ignoring keyboard input, and input is
1400 pending. Suggested by Jan Djärv (Bug#8869).
1402 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1404 Use gnulib's dup2 module instead of rolling our own.
1405 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1407 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1409 * dispnew.c (scrolling_window): Before scrolling, turn off a
1410 mouse-highlight in the window being scrolled.
1412 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1414 Move DEFSYM to lisp.h and use everywhere.
1416 * character.h (DEFSYM): Move declaration...
1417 * lisp.h (DEFSYM): ...here.
1423 * w32select.c: Don't include character.h.
1425 * alloc.c (syms_of_alloc):
1426 * buffer.c (syms_of_buffer):
1427 * bytecode.c (syms_of_bytecode):
1428 * callint.c (syms_of_callint):
1429 * casefiddle.c (syms_of_casefiddle):
1430 * casetab.c (init_casetab_once):
1431 * category.c (init_category_once, syms_of_category):
1432 * ccl.c (syms_of_ccl):
1433 * cmds.c (syms_of_cmds):
1434 * composite.c (syms_of_composite):
1435 * dbusbind.c (syms_of_dbusbind):
1436 * dired.c (syms_of_dired):
1437 * dispnew.c (syms_of_display):
1438 * doc.c (syms_of_doc):
1439 * editfns.c (syms_of_editfns):
1440 * emacs.c (syms_of_emacs):
1441 * eval.c (syms_of_eval):
1442 * fileio.c (syms_of_fileio):
1443 * fns.c (syms_of_fns):
1444 * frame.c (syms_of_frame):
1445 * fringe.c (syms_of_fringe):
1446 * insdel.c (syms_of_insdel):
1447 * keymap.c (syms_of_keymap):
1448 * lread.c (init_obarray, syms_of_lread):
1449 * macros.c (syms_of_macros):
1450 * msdos.c (syms_of_msdos):
1451 * print.c (syms_of_print):
1452 * process.c (syms_of_process):
1453 * search.c (syms_of_search):
1454 * sound.c (syms_of_sound):
1455 * syntax.c (init_syntax_once, syms_of_syntax):
1456 * terminal.c (syms_of_terminal):
1457 * textprop.c (syms_of_textprop):
1458 * undo.c (syms_of_undo):
1459 * w32.c (globals_of_w32):
1460 * window.c (syms_of_window):
1461 * xdisp.c (syms_of_xdisp):
1462 * xfaces.c (syms_of_xfaces):
1463 * xfns.c (syms_of_xfns):
1464 * xmenu.c (syms_of_xmenu):
1465 * xsettings.c (syms_of_xsettings):
1466 * xterm.c (syms_of_xterm): Use DEFSYM.
1468 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1470 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1472 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1474 Integer and buffer overflow fixes (Bug#8873).
1476 * print.c (printchar, strout): Check for string overflow.
1477 (PRINTPREPARE, printchar, strout):
1478 Don't set size unless allocation succeeds.
1480 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1481 for sizes. Check for string overflow more accurately.
1482 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1484 * macros.c: Integer and buffer overflow fixes.
1485 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1486 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1487 Use ptrdiff_t, not int, for sizes.
1488 Don't increment bufsize until after realloc succeeds.
1489 Check for size-calculation overflow.
1490 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1492 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1494 * lread.c: Integer overflow fixes.
1495 (read_integer): Radix is now EMACS_INT, not int,
1496 to improve quality of diagnostics for out-of-range radices.
1497 Calculate buffer size correctly for out-of-range radices.
1498 (read1): Check for integer overflow in radices, and in
1499 read-circle numbers.
1500 (read_escape): Avoid int overflow.
1501 (Fload, openp, read_buffer_size, read1)
1502 (substitute_object_recurse, read_vector, read_list, map_obarray):
1503 Use ptrdiff_t, not int, for sizes.
1504 (read1): Use EMACS_INT, not int, for sizes.
1505 Check for size overflow.
1507 * image.c (cache_image): Check for size arithmetic overflow.
1509 * lread.c: Integer overflow issues.
1510 (saved_doc_string_size, saved_doc_string_length)
1511 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1512 Now ptrdiff_t, not int.
1513 (read1): Don't assume doc string length fits in int. Check for
1514 out-of-range doc string lengths.
1515 (read_list): Don't assume file position fits in int.
1516 (read_escape): Check for hex character overflow.
1518 2011-06-22 Leo Liu <sdl.web@gmail.com>
1520 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1521 Move to minibuffer.el.
1523 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1525 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1526 The following patches are for when GLYPH_DEBUG && !XASSERT.
1527 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1528 * dispnew.c (flush_stdout):
1529 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1530 Mark as externally visible.
1531 * dispnew.c (check_window_matrix_pointers): Now static.
1532 * dispnew.c (window_to_frame_vpos):
1533 * xfns.c (unwind_create_frame):
1534 * xterm.c (x_check_font): Remove unused local.
1535 * scroll.c (CHECK_BOUNDS):
1536 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1537 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1538 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1539 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1540 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1542 (debug_method_add): Use va_list and vsprintf rather than relying
1543 on undefined behavior with wrong number of arguments.
1544 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1545 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1546 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1547 since we're not interested in debugging glyphs with old libraries.
1548 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1549 GCC 4.6.0's static checking.
1551 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1553 Integer overflow and signedness fixes (Bug#8873).
1554 A few related buffer overrun fixes, too.
1556 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1558 * dispextern.h (struct face.stipple):
1559 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1560 (x_bitmap_mask, x_allocate_bitmap_record)
1561 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1562 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1563 (x_create_bitmap_from_xpm_data):
1564 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1565 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1567 * xfaces.c (load_pixmap):
1568 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1569 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1570 (.bitmaps_last, struct x_output.icon_bitmap):
1571 Use ptrdiff_t, not int, for bitmap indexes.
1572 (x_allocate_bitmap_record): Check for size overflow.
1573 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1575 Use ptrdiff_t, not int, for overlay counts.
1576 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1577 * editfns.c (overlays_around, get_pos_property):
1578 * textprop.c (get_char_property_and_overlay):
1579 * xdisp.c (next_overlay_change, note_mouse_highlight):
1580 * xfaces.c (face_at_buffer_position):
1581 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1582 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1583 (Fnext_overlay_change, Fprevious_overlay_change)
1584 (mouse_face_overlay_overlaps, Foverlays_in):
1585 Use ptrdiff_t, not int, for sizes.
1586 (overlays_at, overlays_in): Check for size-calculation overflow.
1588 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1590 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1591 (x_session_initialize): Do not assume string length fits in int.
1593 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1594 This is unlikely, but can occur if DPI is outlandish.
1596 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1597 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1599 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1600 * xrdb.c (magic_file_p, search_magic_path):
1601 Omit last arg SUFFIX; it was always 0. All callers changed.
1602 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1604 * xfont.c (xfont_match): Avoid need for strlen.
1606 * xfns.c: Don't assume strlen fits in int.
1607 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1609 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1610 not unsigned long, as we prefer signed integers. All callers changed.
1611 Detect integer overflow in repeat count.
1612 (message_dolog): Don't assume print length fits in 39 bytes.
1613 (display_mode_element): Don't assume strlen fits in int.
1615 * termcap.c: Don't assume sizes fit in int and never overflow.
1616 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1617 (gobble_line): Check for size-calculation overflow.
1619 * minibuf.c (Fread_buffer):
1620 * lread.c (intern, intern_c_string):
1621 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1622 Don't assume string length fits in int.
1624 * keyboard.c (parse_tool_bar_item):
1625 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1627 * font.c: Don't assume string length fits in int.
1628 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1629 Use ptrdiff_t, not int.
1630 (font_intern_prop): Don't assume string length fits in int.
1631 Don't assume integer property fits in fixnum.
1632 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1634 * filelock.c: Fix some buffer overrun and integer overflow issues.
1635 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1636 Reformulate so as not to need the command string.
1637 Invoke gzip -cd rather than gunzip, as it's more portable.
1638 (lock_info_type, lock_file_1, lock_file):
1639 Don't assume pid_t and time_t fit in unsigned long.
1640 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1641 (current_lock_owner): Prefer signed type for sizes.
1642 Use memcpy, not strncpy, where memcpy is what is really wanted.
1643 Don't assume (via atoi) that time_t and pid_t fit in int.
1644 Check for time_t and/or pid_t out of range, e.g., via a network share.
1645 Don't alloca where an auto var works fine.
1647 * fileio.c: Fix some integer overflow issues.
1648 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1649 Don't assume string length fits in int.
1650 (directory_file_name): Don't assume string length fits in long.
1651 (make_temp_name): Don't assume pid fits in int, or that its print
1652 length is less than 20.
1654 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1656 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1658 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1660 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1661 We prefer signed integers, even for size calculations.
1663 * emacs.c: Don't assume string length fits in 'int'.
1664 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1665 (main): Don't invoke strlen when not needed.
1667 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1668 (XD_DEBUG_MESSAGE): Don't waste a byte.
1670 * callproc.c (getenv_internal_1, getenv_internal)
1672 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1674 * lread.c (invalid_syntax): Omit length argument.
1675 All uses changed. This doesn't fix a bug, but it simplifies the
1676 code away from its former Hollerith-constant appearance, and it's
1677 one less 'int' to worry about when looking at integer-overflow issues.
1678 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1680 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1681 This didn't break anything, but it didn't help either.
1682 It's confusing to put a bogus integer in a place where the actual
1683 value does not matter.
1684 (LIST_END_P): Remove unused macro and its bogus comment.
1685 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1687 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1688 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1690 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1691 We prefer signed types, and the value cannot exceed the EMACS_INT
1692 range anyway (because otherwise the length would not be representable).
1693 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1694 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1695 This avoids a GCC warning when WIDE_EMACS_INT.
1697 * indent.c (sane_tab_width): New function.
1698 (current_column, scan_for_column, Findent_to, position_indentation)
1699 (compute_motion): Use it. This is just for clarity.
1700 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1702 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1704 * lisp.h (lint_assume): New macro.
1705 * composite.c (composition_gstring_put_cache):
1706 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1708 * editfns.c, insdel.c:
1709 Omit unnecessary forward decls, to simplify future changes.
1711 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1713 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1715 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1716 Use much-faster test for byte-length change.
1717 Don't assume string byte-length fits in 'int'.
1718 Check that character arg fits in 'int'.
1719 (mapcar1): Declare byte as byte, for clarity.
1721 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1723 * fns.c (concat): Catch string overflow earlier.
1724 Do not rely on integer wraparound.
1726 * dispextern.h (struct it.overlay_strings_charpos)
1727 (struct it.selective): Now EMACS_INT, not int.
1728 * xdisp.c (forward_to_next_line_start)
1729 (back_to_previous_visible_line_start)
1730 (reseat_at_next_visible_line_start, next_element_from_buffer):
1731 Don't arbitrarily truncate the value of 'selective' to int.
1733 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1735 * composite.c: Don't truncate sizes to 'int'.
1736 (composition_gstring_p, composition_reseat_it)
1737 (composition_adjust_point): Use EMACS_INT, not int.
1738 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1739 not EMACS_UINT, for indexes.
1741 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1743 * buffer.c: Include <verify.h>.
1744 (struct sortvec.priority, struct sortstr.priority):
1745 Now EMACS_INT, not int.
1746 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1747 (struct sortstr.size, record_overlay_string)
1748 (struct sortstrlist.size, struct sortlist.used):
1749 Don't truncate size to int.
1750 (record_overlay_string): Check for size-calculation overflow.
1751 (init_buffer_once): Check at compile-time, not run-time.
1753 2011-06-22 Jim Meyering <meyering@redhat.com>
1755 Don't leak an XBM-image-sized buffer
1756 * image.c (xbm_load): Free the image buffer after using it.
1758 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1761 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1762 that Sun C diagnosed.
1763 * fns.c (secure_hash): Fix pointer signedness issue.
1764 * intervals.c (static_offset_intervals): New function.
1765 (offset_intervals): Use it.
1767 2011-06-21 Leo Liu <sdl.web@gmail.com>
1770 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1773 * fns.c (secure_hash): Rename from crypto_hash_function and change
1774 the first arg to accept symbols.
1775 (Fsecure_hash): New primitive.
1776 (syms_of_fns): New symbols.
1778 2011-06-20 Deniz Dogan <deniz@dogan.se>
1780 * process.c (Fset_process_buffer): Clarify return value in
1783 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1785 * dispnew.c (add_window_display_history): Use BVAR.
1787 * xdisp.c (debug_method_add): Use BVAR.
1788 (check_window_end, dump_glyph_matrix, dump_glyph)
1789 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1791 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1794 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1795 check till after the cache is created in init_frame_faces.
1797 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1799 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1801 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1803 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1804 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1805 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1807 Improve buffer-overflow checking (Bug#8873).
1808 * fileio.c (Finsert_file_contents):
1809 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1810 Remove the old (too-loose) buffer overflow checks.
1811 They weren't needed, since make_gap checks for buffer overflow.
1812 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1813 The old code merely checked for Emacs fixnum overflow, and relied
1814 on undefined (wraparound) behavior. The new code avoids undefined
1815 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1817 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1818 Tune. Don't use wider integers than needed. Don't use alloca.
1819 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1821 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1823 * insdel.c, lisp.h (buffer_overflow): New function.
1824 (insert_from_buffer_1, replace_range, replace_range_2):
1825 * insdel.c (make_gap_larger):
1826 * editfns.c (Finsert_char):
1827 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1829 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1831 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1833 Integer overflow and signedness fixes (Bug#8873).
1835 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1836 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1838 * fileio.c: Don't assume EMACS_INT fits in off_t.
1839 (emacs_lseek): New static function.
1840 (Finsert_file_contents, Fwrite_region): Use it.
1841 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1843 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1845 * fns.c: Don't overflow int when computing a list length.
1846 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1847 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1848 truncation on 64-bit hosts. Check for QUIT every
1849 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1850 faster and is responsive enough.
1851 (Flength): Report an error instead of overflowing an integer.
1852 (Fsafe_length): Return a float if the value is not representable
1853 as a fixnum. This shouldn't happen except in contrived situations.
1854 (Fnthcdr, Fsort): Don't assume list length fits in int.
1855 (Fcopy_sequence): Don't assume vector length fits in int.
1857 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1858 (header_size, word_size): New constants.
1859 (allocate_vectorlike): Don't check size overflow here.
1860 (allocate_vector): Check it here instead, since this is the only
1861 caller of allocate_vectorlike that could cause overflow.
1862 Check that the new vector's length is representable as a fixnum.
1864 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1865 The previous code was bogus. For example, next_almost_prime (32)
1866 returned 39, which is undesirable as it is a multiple of 3; and
1867 next_almost_prime (24) returned 25, which is a multiple of 5 so
1868 why was the code bothering to check for multiples of 7?
1870 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1872 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1874 Variadic C functions now count arguments with ptrdiff_t.
1875 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1876 Back then I didn't know that the Emacs coding style prefers signed int.
1877 Also, in the meantime I found a few more instances where arguments
1878 were being counted with int, which may truncate counts on 64-bit
1879 machines, or EMACS_INT, which may be unnecessarily wide.
1880 * lisp.h (struct Lisp_Subr.function.aMANY)
1881 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1882 Arg counts are now ptrdiff_t, not size_t.
1883 All variadic functions and their callers changed accordingly.
1884 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1885 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1886 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1887 * callint.c (Fcall_interactively): Check arg count for overflow,
1888 to avoid potential buffer overrun. Use signed char, not 'int',
1889 for 'varies' array, so that we needn't bother to check its size
1890 calculation for overflow.
1891 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1892 * eval.c (apply_lambda):
1893 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1894 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1895 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1897 * callint.c (Fcall_interactively): Don't use index var as event count.
1899 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1900 * mem-limits.h (SIZE): Remove; no longer used.
1902 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1904 Remove unnecessary casts.
1905 * xterm.c (x_term_init):
1906 * xfns.c (x_set_border_pixel):
1907 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1908 These aren't needed now that we assume ANSI C.
1910 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1911 It's more likely to cause problems (due to unsigned overflow)
1914 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1916 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1918 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1920 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1922 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1924 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1926 GLYPH_CODE_FACE returns EMACS_INT, not int.
1927 * dispextern.h (merge_faces):
1928 * xfaces.c (merge_faces):
1929 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1930 Don't assume EMACS_INT fits in int.
1932 * character.h (CHAR_VALID_P): Remove unused parameter.
1933 * fontset.c, lisp.h, xdisp.c: All uses changed.
1935 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1937 * fns.c (concat): Minor tuning based on overflow analysis.
1938 This doesn't fix any bugs. Use int to hold character, instead
1939 of constantly refetching from Emacs object. Use XFASTINT, not
1940 XINT, for value known to be a character. Don't bother comparing
1941 a single byte to 0400, as it's always less.
1943 * floatfns.c (Fexpt):
1944 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1946 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1949 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1951 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1952 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1953 incorrectly succeed when S was a string, because 4294967386 was
1954 truncated before it was used.
1956 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1957 Otherwise, an out-of-range integer could cause undefined behavior
1960 * composite.c: Use int, not EMACS_INT, for characters.
1961 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1962 EMACS_INT, for values that are known to be in character range.
1963 This doesn't fix any bugs but is the usual style inside Emacs and
1964 may generate better code on 32-bit machines.
1966 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1967 This is for reasons similar to the recent CHAR_STRING fix.
1968 * charset.c (Fencode_char): Check that character arg is actually
1969 a character. Pass an int to ENCODE_CHAR.
1970 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1971 wider than 'int', as a compile-time check to prevent future regressions
1974 * character.c (char_string): Remove unnecessary casts.
1976 Make sure a 64-bit char is never passed to CHAR_STRING.
1977 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1978 by silently ignoring the top 32 bits, allowing some values
1979 that were far too large to be valid characters.
1980 * character.h: Include <verify.h>.
1981 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1982 arguments are no wider than unsigned, as a compile-time check
1983 to prevent future regressions in this area.
1985 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1986 (Fsubst_char_in_region):
1988 * xdisp.c (decode_mode_spec_coding):
1989 Adjust to CHAR_STRING's new requirement.
1990 * editfns.c (Finsert_char, Fsubst_char_in_region):
1991 * fns.c (concat): Check that character args are actually
1992 characters. Without this test, these functions did the wrong
1993 thing with wildly out-of-range values on 64-bit hosts.
1995 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1996 These casts should not be needed on 32-bit hosts, either.
1997 * keyboard.c (read_char):
1998 * lread.c (Fload): Remove casts to unsigned.
2000 * lisp.h (UNSIGNED_CMP): New macro.
2001 This fixes comparison bugs on 64-bit hosts.
2002 (ASCII_CHAR_P): Use it.
2003 * casefiddle.c (casify_object):
2004 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2005 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2006 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2007 * dispextern.h (FACE_FROM_ID):
2008 * keyboard.c (read_char): Use UNSIGNED_CMP.
2010 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2011 not to EMACS_INT, to avoid GCC warning.
2013 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2015 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2016 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2017 isn't needed on 32-bit machines.
2019 * buffer.c (Fgenerate_new_buffer_name):
2020 Use EMACS_INT for count, not int.
2021 (advance_to_char_boundary): Return EMACS_INT, not int.
2023 * data.c (Qcompiled_function): Now static.
2025 * window.c (window_body_lines): Now static.
2027 * image.c (gif_load): Rename local to avoid shadowing.
2029 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2030 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2031 * alloc.c (make_save_value): Integer argument is now of type
2033 (mark_object): Use ptrdiff_t, not int.
2034 * lisp.h (pD): New macro.
2035 * print.c (print_object): Use it.
2037 * alloc.c: Use EMACS_INT, not int, to count objects.
2038 (total_conses, total_markers, total_symbols, total_vector_size)
2039 (total_free_conses, total_free_markers, total_free_symbols)
2040 (total_free_floats, total_floats, total_free_intervals)
2041 (total_intervals, total_strings, total_free_strings):
2042 Now EMACS_INT, not int. All uses changed.
2043 (Fgarbage_collect): Compute overall total using a double, so that
2044 integer overflow is less likely to be a problem. Check for overflow
2045 when converting back to an integer.
2046 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2047 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2048 These were 'int' variables that could overflow on 64-bit hosts;
2049 they were never used, so remove them instead of repairing them.
2050 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2051 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2052 Previously, this ceilinged at INT_MAX, but that doesn't work on
2054 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2056 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2057 (allocate_vectorlike): Check for ptrdiff_t overflow.
2058 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2059 when a (possibly-narrower) signed value would do just as well.
2060 We prefer using signed arithmetic, to avoid comparison confusion.
2062 * alloc.c: Catch some string size overflows that we were missing.
2063 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2064 for convenience in STRING_BYTES_MAX.
2065 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2066 The definition here is exact; the one in lisp.h was approximate.
2067 (allocate_string_data): Check for string overflow. This catches
2068 some instances we weren't catching before. Also, it catches
2069 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2070 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2071 and ptrdiff_t and EMACS_INT are both 64 bits.
2073 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2074 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2075 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2077 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2079 * alloc.c (Fmake_string): Check for out-of-range init.
2081 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2083 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2085 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2087 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2088 xg_get_default_scrollbar_width.
2090 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2091 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2092 (style_changed_cb): Call update_theme_scrollbar_width and call
2093 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2094 all frames (Bug#8505).
2095 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2096 Call gtk_window_set_resizable if HAVE_GTK3.
2097 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2098 and height if HAVE_GTK3 (Bug#8505).
2099 (scroll_bar_width_for_theme): New variable.
2100 (update_theme_scrollbar_width): New function.
2101 (xg_get_default_scrollbar_width): Move code to
2102 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2103 (xg_initialize): Call update_theme_scrollbar_width.
2105 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2107 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2109 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2111 * frame.c (make_frame): Call other_buffer_safely instead of
2114 * window.c (temp_output_buffer_show): Call display_buffer with
2115 second argument Vtemp_buffer_show_specifiers and reset latter
2116 immediately after the call.
2117 (Vtemp_buffer_show_specifiers): New variable.
2118 (auto_window_vscroll_p, next_screen_context_lines)
2119 (Vscroll_preserve_screen_position): Remove leading asterisks from
2122 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2124 Fix minor problems found by GCC 4.6.0 static checking.
2125 * buffer.c (Qclone_number): Remove for now, as it's unused.
2126 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2127 (record_buffer): Remove unused local.
2128 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2129 (set_frame_buffer_list): Remove; unused.
2130 * frame.h (other_visible_frames): Remove decl.
2131 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2132 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2133 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2135 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2136 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2137 Define only if HAVE_GPM.
2138 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2139 (update_hints_inhibit): Remove; never set. All uses removed.
2140 * widgetprv.h (emacsFrameClassRec): Remove decl.
2141 * window.c (delete_deletable_window): Now returns void, since it
2142 wasn't returning anything.
2143 (compare_window_configurations): Remove unused locals.
2144 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2145 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2146 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2147 the same widths as pointers. This follows up on the 2011-05-06 patch.
2148 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2149 * xterm.h: Likewise.
2150 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2152 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2154 * makefile.w32-in: Update dependencies.
2155 (LISP_H): Add lib/intprops.h.
2157 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2159 * image.c (gif_load): Add animation frame delay to the metadata.
2160 (syms_of_image): Use DEFSYM. New symbol `delay'.
2162 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2164 * window.c (delete_deletable_window): Re-add.
2165 (Fset_window_configuration): Rewrite to handle dead buffers and
2166 consequently deletable windows.
2167 (window_tree, Fwindow_tree): Remove. Supply functionality in
2169 (compare_window_configurations): Simplify code.
2171 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2173 * image.c (imagemagick_load_image): Fix type mismatch.
2174 (Fimagemagick_types): Likewise.
2176 * window.h (replace_buffer_in_windows): Declare.
2178 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2180 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2181 Qclone_number. Remove external declaration of Qdelete_window.
2182 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2184 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2185 Run Qbuffer_list_update_hook if allowed.
2186 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2187 buffer list implementation.
2188 (other_buffer_safely): New function.
2189 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2190 calls to replace_buffer_in_windows and
2191 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2193 (record_buffer): Inhibit quitting and rewrite using quittable
2194 functions. Run Qbuffer_list_update_hook if allowed.
2195 (Frecord_buffer, Funrecord_buffer): New functions.
2196 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2197 Move switch-to-buffer to window.el.
2198 (bury-buffer): Move to window.el.
2199 (Vbuffer_list_update_hook): New variable.
2201 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2204 * window.h (resize_frame_windows): Move up in code.
2205 (Fwindow_frame): Remove EXFUN.
2206 (replace_buffer_in_all_windows): Remove prototype.
2207 (replace_buffer_in_windows_safely): Add prototype.
2209 * window.c: Declare Qdelete_window static again. Move down
2210 declaration of select_count.
2211 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2212 (Fother_window): Move to window.el.
2213 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2214 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2215 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2217 (replace_buffer_in_windows): Implement by calling
2218 Qreplace_buffer_in_windows.
2219 (replace_buffer_in_all_windows): Remove with some functionality
2220 moved into replace_buffer_in_windows_safely.
2221 (replace_buffer_in_windows_safely): New function.
2222 (select_window_norecord, select_frame_norecord): Move in front
2223 of run_window_configuration_change_hook. Remove now obsolete
2225 (Fset_window_buffer): Rewrite doc-string.
2226 Call Qrecord_window_buffer.
2227 (keys_of_window): Move binding for other-window to window.el.
2229 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2231 * dispextern.h (struct image): Replace data member, whose int_val
2232 and ptr_val fields were not used by anything, with a single
2235 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2236 (gif_clear_image, gif_load, imagemagick_load_image)
2237 (gs_clear_image, gs_load): Callers changed.
2239 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2241 * buffer.h: Include <time.h>, for time_t.
2242 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2244 Fix minor problems found by static checking.
2246 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2248 Make identifiers static if they are not used in other modules.
2249 * data.c (Qcompiled_function, Qframe, Qvector):
2250 * image.c (QimageMagick, Qsvg):
2251 * minibuf.c (Qmetadata):
2252 * window.c (resize_window_check, resize_root_window): Now static.
2253 * window.h (resize_window_check, resize_root_window): Remove decls.
2255 * window.c (window_deletion_count, delete_deletable_window):
2257 (window_body_lines): Now static.
2258 (Fdelete_other_windows_internal): Mark vars as initialized.
2259 Make sure 'resize_failed' is initialized.
2260 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2261 (resize_window_apply): Remove unused local.
2262 * window.h (delete_deletable_window): Remove decl.
2264 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2265 (imagemagick_load_image): Fix pointer signedness problem by changing
2266 last arg from unsigned char * to char *. All uses changed.
2267 Also, fix a local for similar reasons.
2268 Remove unused locals. Remove locals to avoid shadowing.
2269 (fn_rsvg_handle_free): Remove; unused.
2270 (svg_load, svg_load_image): Fix pointer signedness problem.
2271 (imagemagick_load_image): Don't use garbage pointer image_wand.
2273 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2275 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2277 * image.c (gif_load): Fix omitted cast error introduced by
2280 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2282 * window.h (resize_proportionally, orig_total_lines)
2283 (orig_top_line): Remove from window structure.
2284 (set_window_height, set_window_width, change_window_heights)
2285 (Fdelete_window): Remove prototypes.
2286 (resize_frame_windows): Remove duplicate declaration.
2288 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2290 * window.h (resize_frame_windows, resize_window_check)
2291 (delete_deletable_window, resize_root_window)
2292 (resize_frame_windows): Declare prototypes.
2294 * window.c (resize_window_apply): Make definition be "static" to
2295 match the prototype.
2297 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2299 * window.c: Remove declarations of Qwindow_size_fixed,
2300 window_min_size_1, window_min_size_2, window_min_size,
2301 size_window, window_fixed_size_p, enlarge_window, delete_window.
2302 Remove static from declaration of Qdelete_window, it's
2303 temporarily needed by Fbury_buffer.
2304 (replace_window): Don't assign orig_top_line and
2306 (Fdelete_window, delete_window): Remove. Window deletion is
2307 handled by window.el.
2308 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2309 Replace Fdelete_window calls with calls to Qdelete_window.
2310 (Fdelete_other_windows): Remove. Deleting other windows is
2311 handled by window.el.
2312 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2313 handled in window.el.
2314 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2315 Window minimum sizes are handled in window.el.
2316 (shrink_windows, size_window, set_window_height)
2317 (set_window_width, change_window_heights, window_height)
2318 (window_width, CURBEG, CURSIZE, enlarge_window)
2319 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2320 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2321 handled in window.el.
2322 (make_dummy_parent): Rename to make_parent_window and give it a
2323 second argument horflag.
2324 (make_window): Don't set resize_proportionally any more.
2325 (Fsplit_window): Remove. Windows are split in window.el.
2326 (save_restore_action, save_restore_orig_size)
2327 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2328 Resize mini windows in window.el.
2329 (grow_mini_window, shrink_mini_window): Implement by calling
2330 Qresize_root_window_vertically, resize_window_check and
2331 resize_window_apply.
2332 (saved_window, Fset_window_configuration, save_window_save):
2333 Do not handle orig_top_line, orig_total_lines, and
2334 resize_proportionally.
2335 (window_min_height, window_min_width): Move to window.el.
2336 (keys_of_window): Move bindings for delete-other-windows,
2337 split-window, delete-window and enlarge-window to window.el.
2339 * buffer.c: Temporarily extern Qdelete_window.
2340 (Fbury_buffer): Temporarily call Qdelete_window instead of
2341 Fdelete_window (Fbury_buffer will move to window.el soon).
2343 * frame.c (set_menu_bar_lines_1): Remove code handling
2344 orig_top_line and orig_total_lines.
2346 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2347 set_window_height but set heights directly.
2348 (change_frame_size_1): Use resize_frame_windows.
2350 * xdisp.c (init_xdisp): Don't use set_window_height but set
2353 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2354 Use resize_frame_windows instead of change_window_heights and run
2355 run_window_configuration_change_hook.
2357 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2358 instead of change_window_heights and run
2359 run_window_configuration_change_hook.
2361 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2363 * window.c (replace_window): Rename second argument REPLACEMENT to
2364 NEW. New third argument SETFLAG. Rewrite.
2365 (delete_window, make_dummy_parent): Call replace_window with
2367 (window_list_1): Move down in code.
2368 (run_window_configuration_change_hook): Move set_buffer part
2369 before select_frame_norecord part in order to unwind correctly.
2370 Rename count1 to count.
2371 (recombine_windows, delete_deletable_window, resize_root_window)
2372 (Fdelete_other_windows_internal)
2373 (Frun_window_configuration_change_hook, make_parent_window)
2374 (resize_window_check, resize_window_apply, Fresize_window_apply)
2375 (resize_frame_windows, Fsplit_window_internal)
2376 (Fdelete_window_internal, Fresize_mini_window_internal):
2378 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2380 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2382 * window.h (window): Add some new members to window structure -
2383 normal_lines, normal_cols, new_total, new_normal, clone_number,
2384 splits, nest, prev_buffers, next_buffers.
2385 (WINDOW_TOTAL_SIZE): Move here from window.c.
2386 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2388 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2390 (make_dummy_parent): Set new members of windows structure.
2391 (make_window): Move down in code. Handle new members of window
2393 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2394 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2395 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2396 (Fset_window_prev_buffers, Fwindow_next_buffers)
2397 (Fset_window_next_buffers, Fset_window_clone_number):
2399 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2400 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2402 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2403 Argument WINDOW can be now internal window too.
2404 (Fwindow_use_time): Move up in code.
2405 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2407 (Fset_window_configuration, saved_window)
2408 (Fcurrent_window_configuration, save_window_save): Handle new
2409 members of window structure.
2410 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2411 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2412 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2413 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2414 Qget_mru_window, Qresize_root_window,
2415 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2416 Qauto_buffer_name; staticpro them.
2418 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2420 * window.c (Fwindow_total_size, Fwindow_left_column)
2421 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2422 (Fwindow_list_1): New functions.
2423 (window_box_text_cols): Replace with window_body_cols.
2424 (Fwindow_width, Fscroll_left, Fscroll_right):
2425 Use window_body_cols instead of window_box_text_cols.
2426 (delete_window, Fset_window_configuration):
2427 Call delete_all_subwindows with window as argument.
2428 (delete_all_subwindows): Take a window as argument and not a
2430 (window_loop): Remove handling of GET_LRU_WINDOW and
2432 (Fget_lru_window, Fget_largest_window): Move to window.el.
2434 * window.h: Extern window_body_cols instead of
2435 window_box_text_cols. delete_all_subwindows now takes a
2436 Lisp_Object as argument.
2438 * indent.c (compute_motion, Fcompute_motion):
2439 Use window_body_cols instead of window_box_text_cols.
2441 * frame.c (delete_frame): Call delete_all_subwindows with root
2444 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2446 * fns.c (Fputhash): Document return value.
2448 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2450 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2452 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2454 Cons<->int and similar integer overflow fixes (Bug#8794).
2456 Check for overflow when converting integer to cons and back.
2457 * charset.c (Fdefine_charset_internal, Fdecode_char):
2458 Use cons_to_unsigned to catch overflow.
2459 (Fencode_char): Use INTEGER_TO_CONS.
2460 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2461 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2462 * data.c (long_to_cons, cons_to_long): Remove.
2463 (cons_to_unsigned, cons_to_signed): New functions.
2464 These signal an error for invalid or out-of-range values.
2465 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2466 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2467 * font.c (Ffont_variation_glyphs):
2468 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2469 * lisp.h: Include <intprops.h>.
2470 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2471 (cons_to_signed, cons_to_unsigned): New decls.
2472 (long_to_cons, cons_to_long): Remove decls.
2473 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2474 (Fprimitive_undo): Use CONS_TO_INTEGER.
2475 * xfns.c (Fx_window_property): Likewise.
2476 * xselect.c: Include <limits.h>.
2477 (x_own_selection, selection_data_to_lisp_data):
2478 Use INTEGER_TO_CONS.
2479 (x_handle_selection_request, x_handle_selection_clear)
2480 (x_get_foreign_selection, Fx_disown_selection_internal)
2481 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2482 (lisp_data_to_selection_data): Use cons_to_unsigned.
2483 (x_fill_property_data): Use cons_to_signed.
2484 Report values out of range.
2486 Check for buffer and string overflow more precisely.
2487 * buffer.h (BUF_BYTES_MAX): New macro.
2488 * lisp.h (STRING_BYTES_MAX): New macro.
2489 * alloc.c (Fmake_string):
2490 * character.c (string_escape_byte8):
2491 * coding.c (coding_alloc_by_realloc):
2492 * doprnt.c (doprnt):
2493 * editfns.c (Fformat):
2495 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2496 since they may not be the same number.
2497 * editfns.c (Finsert_char):
2498 * fileio.c (Finsert_file_contents):
2499 Likewise for BUF_BYTES_MAX.
2501 * image.c: Use ptrdiff_t, not int, for sizes.
2502 (slurp_file): Switch from int to ptrdiff_t.
2504 (slurp_file): Check that file size fits in both size_t (for
2505 malloc) and ptrdiff_t (for sanity and safety).
2507 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2508 if b->modtime has its maximal value.
2510 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2512 Don't assume time_t can fit into int.
2513 * buffer.h (struct buffer.modtime): Now time_t, not int.
2514 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2515 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2517 Minor fixes for signed vs unsigned integers.
2518 * character.h (MAYBE_UNIFY_CHAR):
2519 * charset.c (maybe_unify_char):
2520 * keyboard.c (read_char, reorder_modifiers):
2521 XINT -> XFASTINT, since the integer must be nonnegative.
2522 * ftfont.c (ftfont_spec_pattern):
2523 * keymap.c (access_keymap, silly_event_symbol_error):
2524 XUINT -> XFASTINT, since the integer must be nonnegative.
2525 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2526 since it makes no difference and we prefer signed.
2527 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2528 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2531 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2533 * window.h (Fwindow_frame): Declare.
2535 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2537 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2538 (SPARE_MEMORY): Always define.
2539 (LARGE_REQUEST): Remove.
2540 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2542 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2544 * lisp.h: Move EXFUNS for Fframe_root_window,
2545 Fframe_first_window and Fset_frame_selected_window to window.h.
2547 * window.h: Move EXFUNS for Fframe_root_window,
2548 Fframe_first_window and Fset_frame_selected_window here from
2551 * frame.c (Fwindow_frame, Fframe_first_window)
2552 (Fframe_root_window, Fframe_selected_window)
2553 (Fset_frame_selected_window): Move to window.c.
2554 (Factive_minibuffer_window): Move to minibuf.c.
2555 (Fother_visible_frames_p): New function.
2557 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2559 * window.c (decode_window, decode_any_window): Move up in code.
2560 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2561 (inhibit_frame_unsplittable): Remove unused variable.
2562 (Fwindow_buffer): Move up and rewrite doc-string.
2563 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2564 (Fwindow_prev): New functions.
2565 (Fwindow_frame): Move here from frame.c. Accept any window as
2567 (Fframe_root_window, Fframe_first_window)
2568 (Fframe_selected_window): Move here from frame.c. Accept frame
2569 or arbitrary window as argument. Update doc-strings.
2570 (Fminibuffer_window): Move up in code.
2571 (Fwindow_minibuffer_p): Move up in code and simplify.
2572 (Fset_frame_selected_window): Move here from frame.c.
2574 (Fselected_window, select_window, Fselect_window): Move up in
2575 code. Minor doc-string fixes.
2577 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2579 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2580 Do not assume that spare memory exists; that assumption is valid
2581 only if SYSTEM_MALLOC.
2582 (LARGE_REQUEST): New macro, so that the issue of large requests
2583 is separated from the issue of spare memory.
2585 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2587 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2590 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2592 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2595 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2597 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2599 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2601 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2602 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2604 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2606 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2608 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2610 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2611 (x_clipboard_manager_save): Add return value.
2612 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2614 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2615 Obey Vx_select_enable_clipboard_manager. Catch errors in
2616 x_clipboard_manager_save (Bug#8779).
2617 (Vx_select_enable_clipboard_manager): New variable.
2618 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2620 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2622 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2624 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2626 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2627 in the current matrix if keep_current_p is non-zero.
2629 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2631 * bidi.c (bidi_level_of_next_char): Fix last change.
2633 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2635 Support bidi reordering of text covered by display properties.
2637 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2638 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2639 (bidi_cache_search, bidi_cache_iterator_state)
2640 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2641 (bidi_level_of_next_char, bidi_move_to_visually_next):
2642 Support character positions inside a run of characters covered by a
2644 (bidi_paragraph_init, bidi_resolve_explicit_1)
2645 (bidi_level_of_next_char): Call bidi_fetch_char and
2646 bidi_fetch_char_advance instead of FETCH_CHAR and
2648 (bidi_init_it): Initialize new members.
2649 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2651 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2652 instead of using explicit *_CHAR codes.
2653 (bidi_resolve_explicit, bidi_resolve_weak):
2654 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2655 bidirectional text is supported only in multibyte buffers.
2656 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2657 it to initialize the frame_window_p member of struct bidi_it.
2658 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2659 (bidi_resolve_explicit, bidi_resolve_weak)
2660 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2661 bidi_it->nchars is non-positive.
2662 (bidi_level_of_next_char): Don't try to lookup the cache for the
2663 next/previous character if nothing is cached there yet, or if we
2664 were just reseat()'ed to a new position.
2666 * xdisp.c (set_cursor_from_row): Set start and stop points
2667 according to the row's direction when priming the loop that looks
2668 for the glyph on which to display cursor.
2669 (single_display_spec_intangible_p): Function deleted.
2670 (display_prop_intangible_p): Reimplement to call
2671 handle_display_spec instead of single_display_spec_intangible_p.
2672 Accept 3 additional arguments needed by handle_display_spec.
2673 This fixes incorrect cursor motion across display property with complex
2674 values: lists, `(when COND...)' forms, etc.
2675 (single_display_spec_string_p): Support property values that are
2676 lists with the argument STRING its top-level element.
2677 (display_prop_string_p): Fix the condition for processing a
2678 property that is a list to be consistent with handle_display_spec.
2679 (handle_display_spec): New function, refactored from the
2680 last portion of handle_display_prop.
2681 (compute_display_string_pos): Accept additional argument
2682 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2683 value of a `display' property is a "replacing spec".
2684 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2685 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2686 the display property, but just return a value indicating whether
2687 the display property will replace the characters it covers.
2688 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2689 frame_window_p members of struct bidi_it.
2690 (compute_display_string_pos, compute_display_string_end):
2692 (push_it): Accept second argument POSITION, where pop_it should
2693 jump to continue iteration.
2694 (reseat_1): Initialize bidi_it.disp_pos.
2696 * keyboard.c (adjust_point_for_property): Adjust the call to
2697 display_prop_intangible_p to its new signature.
2699 * dispextern.h (struct bidi_it): New member frame_window_p.
2700 (bidi_init_it): Update prototypes.
2701 (display_prop_intangible_p): Update prototype.
2702 (compute_display_string_pos, compute_display_string_end):
2704 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2707 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2709 Malloc failure behavior now depends on size of allocation.
2710 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2711 * lisp.h: Change signatures accordingly.
2712 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2713 All callers changed. (Bug#8762)
2715 * gnutls.c: Use Emacs's memory allocators.
2716 Without this change, the gnutls library would invoke malloc etc.
2717 directly, which causes problems on non-SYNC_INPUT hosts, and which
2718 runs afoul of improving memory_full behavior. (Bug#8761)
2719 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2720 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2721 xfree instead of the default malloc, realloc, free.
2722 (Fgnutls_boot): No need to check for memory allocation failure,
2723 since xmalloc does that for us.
2725 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2726 * category.c (hash_get_category_set):
2727 * ccl.c (ccl_driver):
2728 * charset.c (Fdefine_charset_internal):
2729 * charset.h (struct charset.hash_index):
2730 * composite.c (get_composition_id, gstring_lookup_cache)
2731 (composition_gstring_put_cache):
2732 * composite.h (struct composition.hash_index):
2733 * dispextern.h (struct image.hash):
2734 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2735 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2736 (hashfn_equal, hashfn_user_defined, make_hash_table)
2737 (maybe_resize_hash_table, hash_lookup, hash_put)
2738 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2739 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2740 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2741 * image.c (make_image, search_image_cache, lookup_image)
2742 (xpm_put_color_table_h):
2743 * lisp.h (struct Lisp_Hash_Table):
2744 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2745 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2746 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2747 * alloc.c (allocate_vectorlike):
2748 Check for overflow in vector size calculations.
2749 * ccl.c (ccl_driver):
2750 Check for overflow when converting EMACS_INT to int.
2751 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2752 need to be updated by these changes.
2753 * fns.c (make_hash_table, maybe_resize_hash_table):
2754 Check for integer overflow with large hash tables.
2755 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2756 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2757 (SXHASH_REDUCE): New macro.
2758 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2759 Use it instead of discarding useful hash info with large hash values.
2760 (sxhash_float): New function.
2761 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2762 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2763 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2764 Rewrite to use FIXNUM_BITS, as this simplifies things.
2765 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2766 Adjust signatures to match updated version of code.
2767 (consing_since_gc): Now EMACS_INT, since a single hash table can
2768 use more than INT_MAX bytes.
2770 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2772 Make it possible to build with GCC-4.6+ -O2 -flto.
2774 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2776 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2778 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2779 Call minibuffer-inactive-mode.
2781 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2783 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2784 Update dependencies.
2786 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2788 * data.c (init_data): Remove code for UTS, this system is not
2791 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2793 Don't force ./temacs to start in terminal mode.
2795 * frame.c (make_initial_frame): Initialize faces in all cases, not
2796 only when CANNOT_DUMP is defined.
2797 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2799 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2801 * dispnew.c (add_window_display_history): Use const for the string
2802 pointer. Remove declaration, not needed.
2804 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2806 Use 'inline', not 'INLINE'.
2807 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2808 * alloc.c, fontset.c (INLINE): Remove.
2809 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2810 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2811 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2812 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2813 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2815 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2817 Make it possible to run ./temacs.
2819 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2820 syms_of_callproc does the same thing. Remove test for
2821 "initialized", do it in the caller.
2822 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2824 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2826 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2827 (read_minibuf): Use get_minibuffer.
2828 (syms_of_minibuf): Use DEFSYM.
2829 (Qmetadata): New var.
2830 * data.c (Qbuffer): Don't make it static.
2831 (syms_of_data): Use DEFSYM.
2833 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2835 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2836 (CCL_CODE_MIN): New macro.
2838 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2840 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2842 * eval.c (Qdebug): Now static.
2843 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2844 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2845 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2847 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2849 * image.c: Various fixes to ImageMagick code comments.
2850 (Fimagemagick_types): Doc fix.
2852 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2854 Minor fixes prompted by GCC 4.6.0 warnings.
2856 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2858 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2859 (x_clipboard_manager_save_all): Move extern decl to ...
2860 * xterm.h: ... here, so that it can be checked for consistency.
2862 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2864 * xselect.c (x_clipboard_manager_save_frame)
2865 (x_clipboard_manager_save_all): New functions.
2866 (Fx_clipboard_manager_save): Lisp function deleted.
2868 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2869 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2871 * xterm.h: Update prototype.
2873 2011-05-28 William Xu <william.xwl@gmail.com>
2875 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2878 2011-05-28 Jim Meyering <meyering@redhat.com>
2880 Avoid a sign-extension bug in crypto_hash_function.
2881 * fns.c (to_uchar): Define.
2882 (crypto_hash_function): Use it to convert some newly-signed
2883 variables to unsigned, to avoid sign-extension bugs. For example,
2884 without this change, (md5 "truc") would evaluate to
2885 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2886 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2887 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2889 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2891 Integer overflow fixes.
2893 * dbusbind.c: Serial number integer overflow fixes.
2894 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2895 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2896 to hold a serial number that is too large for a fixnum.
2897 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2898 Check for serial numbers out of range. Decode any serial number
2899 that was so large that it became a float. (Bug#8722)
2901 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2902 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2903 Use XFASTINT rather than XUINT when numbers are nonnegative.
2904 (xd_append_arg, Fdbus_method_return_internal):
2905 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2906 arguments, check that Lisp number is nonnegative, rather than
2907 silently wrapping negative numbers around. (Bug#8722)
2908 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2911 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2913 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2915 ccl: add integer overflow checks
2916 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2917 (IN_INT_RANGE): New macros.
2918 (ccl_driver): Use them to check for integer overflow when
2919 decoding a CCL program. Many of the new checks are whether XINT (x)
2920 fits in int; it doesn't always, on 64-bit hosts. The new version
2921 doesn't catch all possible integer overflows, but it's an
2922 improvement. (Bug#8719)
2924 * alloc.c (make_event_array): Use XINT, not XUINT.
2925 There's no need for unsigned here.
2927 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2928 This follows up to the 2011-05-06 change that substituted uintptr_t
2929 for EMACS_INT. This case wasn't caught back then.
2931 Rework Fformat to avoid integer overflow issues.
2932 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2933 now (part of C89). Include <verify.h>.
2934 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2935 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2936 (Fformat): Avoid the prepass trying to compute sizes; it was only
2937 approximate and thus did not catch overflow reliably. Instead, walk
2938 through the format just once, formatting and computing sizes as we go,
2939 checking for integer overflow at every step, and allocating a larger
2940 buffer as needed. Keep track separately whether the format is
2941 multibyte. Keep only the most-recently calculated precision, rather
2942 than them all. Record whether each argument has been converted to
2943 string. Use EMACS_INT, not int, for byte and char and arg counts.
2944 Support field widths and precisions larger than INT_MAX. Avoid
2945 sprintf's undefined behavior with conversion specifications such as %#d
2946 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2947 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2948 formatting out-of-range floating point numbers with int
2951 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2953 * data.c: Avoid integer truncation in expressions involving floats.
2954 * data.c: Include <intprops.h>.
2955 (arith_driver): When there's an integer overflow in an expression
2956 involving floating point, convert the integers to floating point
2957 so that the resulting value does not suffer from catastrophic
2958 integer truncation. For example, on a 64-bit host (* 4
2959 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2960 Do not rely on undefined behavior after integer overflow.
2962 merge count_size_as_multibyte, parse_str_to_multibyte
2963 * character.c, character.h (count_size_as_multibyte):
2964 Rename from parse_str_to_multibyte; all uses changed.
2965 Check for integer overflow.
2966 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2967 since it's now a duplicate of the other. This is more of
2968 a character than a buffer op, so better that it's in character.c.
2969 * fns.c, print.c: Adjust to above changes.
2971 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2973 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2975 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2977 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2978 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2979 (x_clipboard_manager_save): Now static.
2980 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2982 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2983 (crypto_hash_function): Now static.
2984 Fix pointer signedness problems. Avoid unnecessary initializations.
2986 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2988 * termhooks.h (Vselection_alist): Make it terminal-local.
2990 * terminal.c (create_terminal): Initialize it.
2992 * xselect.c: Support for clipboard managers.
2993 (Vselection_alist): Move to termhooks.h as terminal-local var.
2994 (LOCAL_SELECTION): New macro.
2995 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2996 (symbol_to_x_atom): Remove gratuitous arg.
2997 (x_handle_selection_request, lisp_data_to_selection_data)
2998 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2999 (x_own_selection, x_get_local_selection, x_convert_selection):
3000 New arg, specifying work frame. Use terminal-local Vselection_alist.
3001 (some_frame_on_display): Delete unused function.
3002 (Fx_own_selection_internal, Fx_get_selection_internal)
3003 (Fx_disown_selection_internal, Fx_selection_owner_p)
3004 (Fx_selection_exists_p): New optional frame arg.
3005 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3006 (x_handle_selection_clear): Don't treat other terminals with the
3007 same keyboard specially. Use the terminal-local Vselection_alist.
3008 (x_clear_frame_selections): Use Frun_hook_with_args.
3010 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3012 * xterm.h: Add support for those atoms.
3014 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3016 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3017 (converted_selections, conversion_fail_tag): New global variables.
3018 (x_selection_request_lisp_error): Free the above.
3019 (x_get_local_selection): Remove unnecessary code.
3020 (x_reply_selection_request): Args changed; handle arbitrary array
3021 of converted selections stored in converted_selections.
3022 Separate the XChangeProperty and SelectionNotify steps.
3023 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3024 (x_convert_selection): New function.
3025 (x_handle_selection_event): Simplify.
3026 (x_get_foreign_selection): Don't ignore incoming requests while
3027 waiting for an answer; this will fail when we implement
3028 SAVE_TARGETS, and seems unnecessary anyway.
3029 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3030 (Vx_sent_selection_functions): Doc fix.
3032 2011-05-26 Leo Liu <sdl.web@gmail.com>
3034 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3036 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3038 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3040 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3041 for fringe update if it has periodic bitmap.
3042 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3043 and fringe_bitmap_periodic_p.
3045 * fringe.c (get_fringe_bitmap_data): New function.
3046 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3047 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3048 row. Mark glyph row for fringe update if periodicity changed.
3050 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3051 for fringe update unless it has periodic bitmap.
3053 2011-05-25 Kenichi Handa <handa@m17n.org>
3055 * xdisp.c (get_next_display_element): Set correct it->face_id for
3056 a static composition.
3058 2011-05-24 Leo Liu <sdl.web@gmail.com>
3061 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3063 * fns.c (crypto_hash_function, Fsha1): New function.
3064 (Fmd5): Use crypto_hash_function.
3065 (syms_of_fns): Add Ssha1.
3067 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3069 * gnutls.c: Remove unused macros.
3070 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3071 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3072 Remove macros that are defined and never used.
3073 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3075 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3077 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3078 (Fx_get_selection_internal): Minor cleanup.
3079 (Fx_own_selection_internal): Rename arguments for consistency with
3082 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3084 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3086 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3088 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3090 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3092 * dispnew.c (scrolling_window): Don't exclude the case that the
3093 last enabled row in the desired matrix touches the bottom boundary.
3095 2011-05-21 Glenn Morris <rgm@gnu.org>
3097 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3098 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3099 and add some more files.
3101 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3103 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3104 report_file_error introduced by the change from 2011-05-07.
3106 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3108 * systime.h (Time): Define only if emacs is defined.
3109 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3110 where the include path doesn't have X11/X.h by default. See
3111 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3113 2011-05-20 Kenichi Handa <handa@m17n.org>
3115 * composite.c (find_automatic_composition): Fix previous change.
3117 2011-05-20 Glenn Morris <rgm@gnu.org>
3119 * lisp.mk: New file, split from Makefile.in.
3120 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3121 (shortlisp): Remove.
3122 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3124 2011-05-19 Glenn Morris <rgm@gnu.org>
3126 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3127 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3128 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3129 (lisp): Set the order to that of loadup.el.
3130 (shortlisp): Make it a copy of $lisp.
3131 (SOME_MACHINE_LISP): Remove.
3132 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3133 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3135 2011-05-18 Kenichi Handa <handa@m17n.org>
3137 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3138 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3139 (find_automatic_composition): Mostly rewrite for efficiency.
3141 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3143 * makefile.w32-in: Update dependencies.
3145 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3147 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3148 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3150 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3152 Fix some integer overflow issues, such as string length overflow.
3154 * insdel.c (count_size_as_multibyte): Check for string overflow.
3156 * character.c (lisp_string_width): Check for string overflow.
3157 Use EMACS_INT, not int, for string indexes and lengths; in
3158 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3159 the resulting string length overflows an EMACS_INT; instead,
3160 report a string overflow if no precision given. When checking for
3161 precision exhaustion, use a check that cannot possibly have
3162 integer overflow. (Bug#8675)
3163 * character.h (lisp_string_width): Adjust to new signature.
3165 * alloc.c (string_overflow): New function.
3166 (Fmake_string): Use it. This doesn't change behavior, but saves
3167 a few bytes and will simplify future changes.
3168 * character.c (string_escape_byte8): Likewise.
3169 * lisp.h (string_overflow): New decl.
3171 Fixups, following up to the user-interface timestamp change.
3172 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3173 for UI timestamps, instead of unsigned long.
3174 * msdos.c (mouse_get_pos): Likewise.
3175 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3176 * w32gui.h (Time): Define by including "systime.h" rather than by
3177 declaring it ourselves. (Bug#8664)
3179 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3180 * image.c (clear_image_cache): Likewise.
3182 * term.c (term_mouse_position): Don't assume time_t wraparound.
3184 Be more systematic about user-interface timestamps.
3185 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3186 and sometimes 'EMACS_UINT', to represent these timestamps.
3187 This change causes it to use 'Time' uniformly, as that's what X uses.
3188 This makes the code easier to follow, and makes it easier to catch
3189 integer overflow bugs such as Bug#8664.
3190 * frame.c (Fmouse_position, Fmouse_pixel_position):
3191 Use Time, not unsigned long, for user-interface timestamps.
3192 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3193 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3194 * keyboard.h (last_event_timestamp): Likewise.
3195 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3196 * menu.h (xmenu_show): Likewise.
3197 * term.c (term_mouse_position): Likewise.
3198 * termhooks.h (struct input_event.timestamp): Likewise.
3199 (struct terminal.mouse_position_hook): Likewise.
3200 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3201 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3202 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3203 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3205 * menu.h, termhooks.h: Include "systime.h", for Time.
3207 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3208 Don't assume that the difference between two unsigned long values
3209 can fit into an integer. At this point, we know button_down_time
3210 <= event->timestamp, so the difference must be nonnegative, so
3211 there's no need to cast the result if double-click-time is
3212 nonnegative, as it should be; check that it's nonnegative, just in
3213 case. This bug is triggered when events are more than 2**31 ms
3214 apart (about 25 days). (Bug#8664)
3216 * xselect.c (last_event_timestamp): Remove duplicate decl.
3217 (x_own_selection): Remove needless cast to unsigned long.
3219 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3220 that always fit in int. Use a sentinel instead of a counter, to
3221 avoid a temp and to allay GCC's concerns about possible int overflow.
3222 * frame.h (struct frame): Use int for menu_bar_items_used
3223 instead of EMACS_INT, since it always fits in int.
3225 * menu.c (grow_menu_items): Check for int overflow.
3227 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3229 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3230 Before, the code was not consistent. These values cannot exceed
3231 2**31 - 1 so there's no need to make them unsigned.
3232 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3233 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3234 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3236 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3238 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3239 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3240 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3241 presumably because the widths might not match.
3243 * window.c (size_window): Avoid needless test at loop start.
3245 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3247 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3249 2011-05-12 Drew Adams <drew.adams@oracle.com>
3251 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3253 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3255 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3256 `width' to `bar_area_x' and `bar_area_width', respectively.
3257 (x_scroll_run): Take account of fringe background extension.
3259 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3260 Rename local vars `left' and `width' to `bar_area_x' and
3261 `bar_area_width', respectively.
3262 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3263 background extension.
3265 2011-05-10 Jim Meyering <meyering@redhat.com>
3267 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3269 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3271 * image.c (Finit_image_library): Return t for built-in image types,
3272 like pbm and xbm. (Bug#8640)
3274 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3276 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3278 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3280 * w32console.c (Fset_screen_color): Doc fix.
3281 (Fget_screen_color): New function.
3282 (syms_of_ntterm): Defsubr it.
3284 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3285 unlink the temporary file if Fcall_process didn't create it in the
3287 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3288 child process will be redirected to a file specified with `:file'.
3289 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3290 cue to call_process_cleanup not to close that handle.
3292 2011-05-07 Ben Key <bkey76@gmail.com>
3294 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3295 one of two shell specific rules, either bootstrap-temacs-CMD or
3296 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3297 to the previous implementation of the bootstrap-temacs rule.
3298 The bootstrap-temacs-CMD rule is similar to the previous
3299 implementation of the bootstrap-temacs rule except that it
3300 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3303 These changes, along with some changes to nt/configure.bat,
3304 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3305 earlier fix to add support for --cflags and --ldflags options
3306 that include quotes so that it works whether make uses cmd or
3309 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3311 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3312 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3314 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3315 a string. Handle both cases.
3316 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3317 (Fdbus_register_method): Use Qinvalid_function.
3319 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3321 * makefile.w32-in: Update dependencies.
3322 (LISP_H): Add inttypes.h and stdin.h.
3323 (PROCESS_H): Add unistd.h.
3325 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3327 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3328 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3330 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3332 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3334 * term.c (vfatal): Remove stray call to va_end.
3335 It's not needed and the C Standard doesn't allow it here anyway.
3337 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3338 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3340 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3343 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3345 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3347 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3349 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3351 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3353 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3354 * charset.c (Fdefine_charset_internal): Don't initialize
3355 charset.code_space[15]. The value was garbage, on hosts with
3356 32-bit int (Bug#8600).
3358 * lread.c (read_integer): Be more consistent with string-to-number.
3359 Use string_to_number to do the actual conversion; this avoids
3360 rounding errors and fixes some other screwups. Without this fix,
3361 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3362 (digit_to_number): Move earlier, for benefit of read_integer.
3363 Return -1 if the digit is out of range for the base, -2 if it is
3364 not a digit in any supported base. (Bug#8602)
3366 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3368 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3369 to match comment at start of function. This also removes a
3370 GCC warning about overflow in a 32+64-bit port.
3372 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3374 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3375 Reported by Stefan Monnier in
3376 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3377 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3378 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3380 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3381 (EMACS_UINTPTR): Likewise, with uintptr_t.
3383 * lisp.h: Prefer 64-bit EMACS_INT if available.
3384 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3385 on 32-bit hosts that have 64-bit int, so that they can access
3387 However, temporarily disable this change unless the temporary
3388 symbol WIDE_EMACS_INT is defined.
3390 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3392 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3393 This removes an assumption that EMACS_INT and long are the same
3394 width as pointers. The assumption is true for Emacs porting targets
3395 now, but we want to make other targets possible.
3396 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3397 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3398 In the rest of the code, change types of integers that hold casted
3399 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3400 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3401 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3402 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3403 No need to cast type when ORing.
3404 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3405 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3406 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3407 assume EMACS_INT is the same width as char *.
3408 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3409 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3410 Remove no-longer-needed casts.
3411 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3412 (xg_tool_bar_help_callback, xg_make_tool_item):
3413 Use EMACS_INTPTR to hold an integer
3414 that will be cast to void *; this can avoid a GCC warning
3415 if EMACS_INT is not the same width as void *.
3416 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3417 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3418 (current_message_1, set_message_1):
3419 Use a local to convert to proper width without a cast.
3420 * xmenu.c (dialog_selection_callback): Likewise.
3422 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3423 Also, don't assume VALBITS / RAND_BITS is less than 5,
3424 and don't rely on undefined behavior when shifting a 1 left into
3426 * lisp.h (get_random): Change signature to match.
3428 * lread.c (hash_string): Use size_t, not int, for hash computation.
3429 Normally we prefer signed values; but hashing is special, because
3430 it's better to use unsigned division on hash table sizes so that
3431 the remainder is nonnegative. Also, size_t is the natural width
3432 for hashing into memory. The previous code used 'int', which doesn't
3433 retain enough info to hash well into very large tables.
3434 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3436 * dbusbind.c: Don't possibly lose pointer info when converting.
3437 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3438 Use XPNTR rather than XHASH, so that the high-order bits of
3439 the pointer aren't lost when converting through void *.
3441 * eval.c (Fautoload): Don't double-shift a pointer.
3443 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3445 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3447 * gnutls.c (DEF_GNUTLS_FN):
3448 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3450 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3452 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3455 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3457 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3458 New version that can reserve upto 2GB of heap space.
3460 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3462 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3464 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3466 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3467 `gnutls_certificate_set_x509_key_file'.
3469 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3471 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3472 Update dependencies.
3474 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3476 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3477 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3478 Remove unused parameter `fildes'.
3479 * process.c (read_process_output, send_process): Don't pass it.
3481 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3483 Fix previous change: the library cache is defined in w32.c.
3484 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3485 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3487 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3489 Implement dynamic loading of GnuTLS on Windows.
3491 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3492 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3493 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3496 * gnutls.c (Qgnutls_dll): Define.
3497 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3498 (gnutls_*): Declare function pointers.
3499 (init_gnutls_functions): New function to initialize function pointers.
3500 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3501 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3502 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3503 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3504 (emacs_gnutls_write, emacs_gnutls_read)
3505 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3506 (Fgnutls_available_p): New function.
3507 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3508 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3509 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3511 * image.c: Include w32.h.
3512 (Vimage_type_cache): Delete.
3513 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3514 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3515 (w32_delayed_load): Move to w32.c.
3517 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3519 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3520 (w32_delayed_load): Move from image.c. When loading a library, record
3521 its filename in the :loaded-from property of the library id.
3522 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3523 Initialize and staticpro them.
3524 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3526 * process.c: Include lisp.h before w32.h, not after.
3527 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3528 instead of gnutls_record_check_pending.
3530 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3532 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3534 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3535 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3538 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3540 * xterm.c (x_set_frame_alpha): Do not set property on anything
3541 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3543 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3545 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3547 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3549 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3550 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3551 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3552 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3553 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3554 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3555 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3556 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3557 (Qgnutls_bootprop_callbacks_verify): Make static.
3559 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3561 * callproc.c: Indentation fixup.
3563 * sysdep.c (wait_for_termination_1): Make static.
3564 (wait_for_termination, interruptible_wait_for_termination):
3565 Move after wait_for_termination_1.
3567 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3569 * sysdep.c (interruptible_wait_for_termination): New function
3570 which is like wait_for_termination, but allows keyboard
3573 * callproc.c (Fcall_process): Add (:file "file") as an option for
3575 (Fcall_process_region): Ditto.
3577 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3579 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3580 rather than `XVECTOR (FOO)->size'.
3582 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3583 inttypes.h, as a gnulib replacement is used if it not available in
3586 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3588 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3589 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3590 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3592 * coding.c (coding_alloc_by_realloc): Error out if destination
3593 will grow beyond MOST_POSITIVE_FIXNUM.
3594 (decode_coding_emacs_mule): Abort if there isn't enough place in
3595 charbuf for the composition carryover bytes. Reserve an extra
3596 space for up to 2 characters produced in a loop.
3597 (decode_coding_iso_2022): Abort if there isn't enough place in
3598 charbuf for the composition carryover bytes.
3600 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3602 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3603 aborting when %lld or %lll format is passed.
3604 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3605 %llo or %llx format is passed. (Bug#8545)
3607 * window.c (window_scroll_line_based): Use a marker instead of
3608 simple variables to record original value of point. (Bug#7952)
3610 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3611 produced by %s or %c overflows available buffer space. (Bug#8545)
3613 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3615 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3616 (SIZE_MAX): Move defn after all includes, as they might #define it.
3618 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3620 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3622 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3624 * keyboard.c (Qdelayed_warnings_hook): Define.
3625 (command_loop_1): Run `delayed-warnings-hook'
3626 if Vdelayed_warnings_list is non-nil.
3627 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3628 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3630 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3632 * doprnt.c (doprnt): Don't return value smaller than the buffer
3633 size if the message was truncated. (Bug#8545).
3635 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3637 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3638 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3640 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3642 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3644 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3646 * makefile.w32-in: Update dependencies.
3648 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3650 Improve `doprnt' and its usage. (Bug#8545)
3651 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3652 `format_end'. Remove support for %l as a conversion specifier.
3653 Don't use xrealloc. Improve diagnostics when the %l size modifier
3654 is used. Update the commentary.
3656 * eval.c (verror): Simplify calculation of size_t.
3658 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3661 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3663 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3666 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3668 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3669 This makes this file independent of the recent pseudovector change.
3671 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3673 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3675 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3676 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3677 Remove unused local.
3678 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3680 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3681 GCC 4.6.0 optimizes based on type-based alias analysis.
3682 For example, if b is of type struct buffer * and v of type struct
3683 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3684 != &v->size, and therefore "v->size = 1; b->size = 2; return
3685 v->size;" must therefore return 1. This assumption is incorrect
3686 for Emacs, since it type-puns struct Lisp_Vector * with many other
3687 types. To fix this problem, this patch adds a new type struct
3688 vectorlike_header that documents the constraints on layout of vectors
3689 and pseudovectors, and helps optimizing compilers not get fooled
3690 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3691 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3692 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3694 (XSETPVECTYPE): Rewrite in terms of new macro.
3695 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3696 This is a bit clearer, and further avoids the possibility of
3697 undesirable aliasing.
3698 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3699 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3700 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3701 since Lisp_Subr is a special case (no "next" field).
3702 (ASIZE): Now uses header.size rather than size.
3703 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3704 to avoid the hassle of writing XVECTOR (foo)->header.size.
3705 (struct vectorlike_header): New type.
3706 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3707 object, to help avoid aliasing.
3708 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3709 (SUBRP): Likewise, since Lisp_Subr is a special case.
3710 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3711 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3712 (struct Lisp_Hash_Table): Combine first two members into a single
3713 struct vectorlike_header member. All uses of "size" and "next" members
3714 changed to be "header.size" and "header.next".
3715 * buffer.h (struct buffer): Likewise.
3716 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3717 * frame.h (struct frame): Likewise.
3718 * process.h (struct Lisp_Process): Likewise.
3719 * termhooks.h (struct terminal): Likewise.
3720 * window.c (struct save_window_data, struct saved_window): Likewise.
3721 * window.h (struct window): Likewise.
3722 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3723 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3724 * buffer.c (init_buffer_once): Likewise.
3725 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3727 * process.c (Fformat_network_address): Use local var for size,
3730 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3732 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3733 * data.c (atof): Remove decl; no longer used or needed.
3734 (digit_to_number): Move to lread.c.
3735 (Fstring_to_number): Use new string_to_number function, to be
3736 consistent with how the Lisp reader treats infinities and NaNs.
3737 Do not assume that floating-point numbers represent EMACS_INT
3738 without losing information; this is not true on most 64-bit hosts.
3739 Avoid double-rounding errors, by insisting on integers when
3740 parsing non-base-10 numbers, as the documentation specifies.
3741 * lisp.h (string_to_number): New decl, replacing ...
3742 (isfloat_string): Remove.
3743 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3744 (read1): Do not accept +. and -. as integers; this
3745 appears to have been a coding error. Similarly, do not accept
3746 strings like +-1e0 as floating point numbers. Do not report
3747 overflow for integer overflows unless the base is not 10 which
3748 means we have no simple and reliable way to continue.
3749 Break out the floating-point parsing into a new
3750 function string_to_number, so that Fstring_to_number parses
3751 floating point numbers consistently with the Lisp reader.
3752 (digit_to_number): Move here from data.c. Make it static inline.
3753 (E_CHAR, EXP_INT): Remove, replacing with ...
3754 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3755 (string_to_number): New function, replacing isfloat_string.
3756 This function checks for valid syntax and produces the resulting
3757 Lisp float number too. Rework it so that string-to-number
3758 no longer mishandles examples like "1.0e+". Use strtoumax,
3759 so that overflow for non-base-10 numbers is reported only when
3760 there's no portable and simple way to convert to floating point.
3762 * textprop.c (set_text_properties_1): Rewrite for clarity,
3763 and to avoid GCC warning about integer overflow.
3765 * intervals.h (struct interval): Use EMACS_INT for members
3766 where EMACS_UINT might cause problems. See
3767 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3768 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3769 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3771 (offset_intervals): Tell GCC not to worry about length overflow
3772 when negating a negative length.
3774 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3775 (overrun_check_free): Likewise.
3777 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3778 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3781 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3782 (gnutls_make_error): Rename local to avoid shadowing.
3783 (gnutls_emacs_global_deinit): ifdef out; not used.
3784 (Fgnutls_boot): Use const for pointer to readonly storage.
3785 Comment out unused local. Fix pointer signedness problems.
3787 * lread.c (openp): Don't stuff size_t into an 'int'.
3788 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3789 about possible signed overflow.
3791 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3792 (GDK_KEY_g): Don't define if already defined.
3793 (xg_prepare_tooltip): Avoid pointer signedness problem.
3794 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3796 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3797 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3799 * xfns.c (Fx_window_property): Simplify a bit,
3800 to make a bit faster and to avoid GCC 4.6.0 warning.
3801 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3803 * fns.c (internal_equal): Don't assume size_t fits in int.
3805 * alloc.c (compact_small_strings): Tighten assertion a little.
3807 Replace pEd with more-general pI, and fix some printf arg casts.
3808 * lisp.h (pI): New macro, generalizing old pEd macro to other
3809 conversion specifiers. For example, use "...%"pI"d..." rather
3810 than "...%"pEd"...".
3811 (pEd): Remove. All uses replaced with similar uses of pI.
3812 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3813 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3814 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3815 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3816 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3817 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3818 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3820 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3821 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3822 * print.c (safe_debug_print, print_object): Likewise.
3823 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3825 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3826 avoiding the 0 flag, which is not portable.
3827 * process.c (Fmake_network_process): Use pI to avoid cast.
3828 * region-cache.c (pp_cache): Likewise.
3829 * xdisp.c (decode_mode_spec): Likewise.
3830 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3831 behavior on 64-bit hosts with printf arg.
3832 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3833 (x_stop_queuing_selection_requests): Likewise.
3834 (x_get_window_property): Don't truncate byte count to an 'int'
3837 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3838 here, since it parses constructs like leading '-' and spaces,
3839 which are not wanted; and it overflows with large numbers.
3840 Instead, simply match F[0-9]+, which is what is wanted anyway.
3842 * alloc.c: Remove unportable assumptions about struct layout.
3843 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3844 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3845 (allocate_vectorlike, make_pure_vector): Use the new macros,
3846 plus offsetof, to remove unportable assumptions about struct layout.
3847 These assumptions hold on all porting targets that I know of, but
3848 they are not guaranteed, they're easy to remove, and removing them
3849 makes further changes easier.
3851 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3852 This doesn't fix a bug but makes the code clearer.
3853 (string_overrun_cookie): Now const. Use initializers that
3854 don't formally overflow signed char, to avoid warnings.
3855 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3856 can cause Emacs to crash when string overrun checking is enabled.
3857 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3858 multiple of sizeof (EMACS_INT); it need not be, if
3859 alignof(EMACS_INT) < sizeof (EMACS_INT).
3860 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3862 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3864 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3866 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3868 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3869 supposed to be handshaking. (Bug#8556)
3870 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3872 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3874 * lisp.h (Qdebug): List symbol.
3875 * eval.c (Qdebug): Restore global linkage.
3876 * keyboard.c (debug-on-event): New variable.
3877 (handle_user_signal): Break into debugger when debug-on-event
3878 matches the current signal symbol.
3880 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3882 * alloc.c (check_sblock, check_string_bytes)
3883 (check_string_free_list): Convert to standard C.
3885 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3887 * w32.c (emacs_gnutls_push): Fix typo.
3889 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3891 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3892 "cast to pointer from integer of different size".
3894 Improve doprnt and its use in verror. (Bug#8545)
3895 * doprnt.c (doprnt): Document the set of format control sequences
3896 supported by the function. Use SAFE_ALLOCA instead of always
3899 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3900 is one byte too soon. Don't use xrealloc; instead xfree and
3903 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3905 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3908 * gnutls.c: Renamed global_initialized to
3909 gnutls_global_initialized. Added internals for the
3910 :verify-hostname-error, :verify-error, and :verify-flags
3911 parameters of `gnutls-boot' and documented those parameters in the
3912 docstring. Start callback support.
3913 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3914 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3915 on error. Return error code.
3916 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3917 (emacs_gnutls_read): Likewise.
3918 (Fgnutls_boot): Return handshake error code.
3919 (emacs_gnutls_handle_error): New function.
3920 (wsaerror_to_errno): Likewise.
3922 * w32.h (emacs_gnutls_pull): Add prototype.
3923 (emacs_gnutls_push): Likewise.
3925 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3926 (emacs_gnutls_push): Likewise.
3928 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3930 * process.c (wait_reading_process_output): Check if GnuTLS
3931 buffered some data internally if no FDs are set for TLS
3934 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3935 (LIBS): Link to USER_LIBS.
3936 ($(BLD)/gnutls.$(0)): New target.
3938 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3940 * xdisp.c (handle_single_display_spec): Rename the
3941 display_replaced_before_p argument into display_replaced_p, to
3942 make it consistent with the commentary. Fix typos in the
3945 * textprop.c (syms_of_textprop): Remove dead code.
3946 (copy_text_properties): Delete obsolete commentary about an
3947 interface that was deleted long ago. Fix typos in the description
3950 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3951 to changes in oldXMenu/XMenu.h from 2011-04-16.
3952 <menu_help_message, prev_menu_help_message>: Constify.
3953 (IT_menu_make_room): menu->help_text is now `const char **';
3956 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3957 to changes in oldXMenu/XMenu.h from 2011-04-16.
3958 (struct XMenu): Declare `help_text' `const char **'.
3960 * xfaces.c <Qunspecified>: Make extern again.
3962 * syntax.c: Include sys/types.h before including regex.h, as
3965 * doc.c (get_doc_string): Improve the format passed to `error'.
3967 * doprnt.c (doprnt): Improve commentary.
3969 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3971 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3974 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3975 changes in globals.h immediately force recompilation.
3976 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3977 $(CURDIR)/s/ms-w32.h.
3978 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3980 * character.c (Fchar_direction): Function deleted.
3981 (syms_of_character): Don't defsubr it.
3982 <char-direction-table>: Deleted.
3984 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3986 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3987 * doprnt.c: Include limits.h.
3988 (SIZE_MAX): New macro.
3989 (doprnt): Return a size_t value. 2nd arg is now size_t.
3990 Many local variables are now size_t instead of int or unsigned.
3991 Improve overflow protection. Support `l' modifier for integer
3992 conversions. Support %l conversion. Don't assume an EMACS_INT
3993 argument for integer conversions and for %c.
3995 * lisp.h (doprnt): Restore prototype.
3997 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4000 * Makefile.in (base_obj): Add back doprnt.o.
4002 * deps.mk (doprnt.o): Add back prerequisites.
4003 (callint.o): Depend on character.h.
4005 * eval.c (internal_lisp_condition_case): Include the handler
4006 representation in the error message.
4007 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4008 when breaking from the loop.
4010 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4012 * callint.c (Fcall_interactively): When displaying error message
4013 about invalid control letter, pass the character's codepoint, not
4014 a pointer to its multibyte form. Improve display of the character
4015 in octal and display also its hex code.
4017 * character.c (char_string): Use %x to display the (unsigned)
4018 codepoint of an invalid character, to avoid displaying a bogus
4021 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4022 `error', not SYMBOL_NAME itself.
4024 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4025 character arguments to `error'.
4027 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4028 to `error' in error message about FINAL_CHAR argument. Make sure
4029 FINAL_CHAR is a character, and use %c when it is passed as
4030 argument to `error'.
4032 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4034 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4036 * w32.c: Include <time.h>.
4037 (sys_localtime): New function.
4039 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4041 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4043 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4045 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4047 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4050 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4052 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4053 gl_state.e_property when gl_state.object is Qt.
4055 * insdel.c (make_gap_larger): Remove limitation of buffer size
4058 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4060 * xdisp.c (lookup_glyphless_char_display)
4061 (produce_glyphless_glyph): Handle cons cell entry in
4062 glyphless-char-display.
4063 (Vglyphless_char_display): Document it.
4065 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4066 glyphless-char-display.
4068 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4070 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4072 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4074 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4075 definition for no-X builds.
4077 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4079 Static checks with GCC 4.6.0 and non-default toolkits.
4081 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4083 * process.c (keyboard_bit_set): Define only if SIGIO.
4084 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4085 (send_process): Repair possible setjmp clobbering.
4087 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4089 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4091 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4093 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4094 Define only if needed.
4096 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4097 by pacifying GCC about it. Maybe it's time to retire it?
4098 * xfaces.c (USG, __TIMEVAL__): Likewise.
4100 * dispextern.h (struct redisplay_interface): Rename param
4102 * termhooks.h (struct terminal): Likewise.
4103 * xterm.c (xembed_send_message): Likewise.
4105 * insdel.c (make_gap_smaller): Define only if
4106 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4108 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4111 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4112 so that we aren't warned about unused symbols.
4114 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4116 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4118 * xfns.c (x_real_positions): Mark locals as initialized.
4120 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4122 * xterm.c: Fix problems found by static analysis with other toolkits.
4123 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4124 (x_dispatch_event): Declare static if USE_GTK, and
4125 define if USE_GTK || USE_X_TOOLKIT.
4126 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4127 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4128 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4129 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4131 * xmenu.c (menu_help_callback): Pointer type fixes.
4132 Use const pointers when pointing at readonly data. Avoid pointer
4134 (FALSE): Remove unused macro.
4135 (update_frame_menubar): Remove unused decl.
4137 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4139 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4140 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4141 (single_menu_item): Rename local to avoid shadowing.
4143 * keyboard.c (make_lispy_event): Remove unused local var.
4145 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4146 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4148 * bitmaps: Change bitmaps from unsigned char back to the X11
4149 compatible char. Avoid the old compiler warnings about
4150 out-of-range initializers by using, for example, '\xab' rather
4153 * xgselect.c (xgselect_initialize): Check vs interface
4154 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4156 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4158 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4159 to read-only memory.
4161 * fns.c (vector): Remove; this old hack is no longer needed.
4163 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4165 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4167 * xrdb.c (x_load_resources): Omit unused local.
4169 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4170 (x_window): Rename locals to avoid shadowing.
4171 (USG): Use the kludged USG macro, to pacify gcc.
4173 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4174 (x_term_init): Remove local to avoid shadowing.
4176 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4178 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4179 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4181 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4183 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4185 Fix regex.c, syntax.c and friends for buffers > 2GB.
4186 * syntax.h (struct gl_state_s): Declare character position members
4189 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4191 * textprop.c (verify_interval_modification, interval_of):
4192 Declare arguments EMACS_INT.
4194 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4197 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4199 * indent.c (Fvertical_motion): Local variable it_start is now
4202 * regex.c (re_match, re_match_2, re_match_2_internal)
4203 (bcmp_translate, regcomp, regexec, print_double_string)
4204 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4205 (re_compile_pattern, re_exec): Declare arguments and local
4206 variables `size_t' and `ssize_t' and return values `regoff_t', as
4208 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4209 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4210 <compile_stack_type>: `size' and `avail' are now `size_t'.
4212 * regex.h <regoff_t>: Use ssize_t, not int.
4213 (re_search, re_search_2, re_match, re_match_2): Arguments that
4214 specify buffer/string position and length are now ssize_t and
4215 size_t. Return type is regoff_t.
4217 2011-04-16 Ben Key <bkey76@gmail.com>
4219 * nsfont.m: Fixed bugs in ns_get_family and
4220 ns_descriptor_to_entity that were caused by using free to
4221 deallocate memory blocks that were allocated by xmalloc (via
4222 xstrdup). This caused Emacs to crash when compiled with
4223 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4224 --enable-checking=xmallocoverrun). xfree is now used to
4225 deallocate these memory blocks.
4227 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4229 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4231 emacs_write: Accept and return EMACS_INT for sizes.
4232 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4234 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4235 Accept and return EMACS_INT.
4236 (emacs_gnutls_write): Return the number of bytes written on
4238 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4239 (emacs_read, emacs_write): Remove check for negative size, as the
4240 Emacs source code has been audited now.
4241 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4242 (emacs_read, emacs_write): Use it.
4243 * process.c (send_process): Adjust to the new signatures of
4244 emacs_write and emacs_gnutls_write. Do not attempt to store
4245 a byte offset into an 'int'; it might overflow.
4246 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4248 * sound.c: Don't assume sizes fit in 'int'.
4249 (struct sound_device.period_size, alsa_period_size):
4250 Return EMACS_INT, not int.
4251 (struct sound_device.write, vox_write, alsa_write):
4252 Accept EMACS_INT, not int.
4253 (wav_play, au_play): Use EMACS_INT to store sizes and to
4254 record read return values.
4256 2011-04-15 Ben Key <bkey76@gmail.com>
4258 * keyboard.c (Qundefined): Don't declare static since it is used
4260 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4261 static since they are used in nsfont.m.
4263 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4265 * process.c (Qprocessp): Don't declare static.
4266 * lisp.h (Qprocessp): Declare again.
4268 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4270 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4272 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4274 Improve C-level modularity by making more things 'static'.
4276 Don't publish debugger-only interfaces to other modules.
4277 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4278 (verify_bytepos, count_markers): Move decls to the only modules
4280 * region-cache.h (pp_cache): Likewise.
4281 * window.h (check_all_windows): Likewise.
4282 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4284 * sysdep.c (croak): Now static, if
4285 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4286 * syssignal.h (croak): Declare only if not static.
4288 * alloc.c (refill_memory_reserve): Now static if
4289 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4290 * lisp.h (refill_memory_reserve): Declare only if not static.
4292 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4293 Define only if USE_LUCID.
4295 * xrdb.c (x_customization_string, x_rm_string): Now static.
4297 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4298 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4300 * xdisp.c (draw_row_with_mouse_face): Now static.
4301 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4303 * window.h (check_all_windows): Mark externally visible.
4305 * window.c (window_deletion_count): Now static.
4307 * undo.c: Make symbols static if they're not exported.
4308 (last_undo_buffer, last_boundary_position, pending_boundary):
4311 * textprop.c (interval_insert_behind_hooks): Now static.
4312 (interval_insert_in_front_hooks): Likewise.
4314 * term.c: Make symbols static if they're not exported.
4315 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4316 (max_frame_lines, tty_set_terminal_modes):
4317 (tty_reset_terminal_modes, tty_turn_off_highlight):
4318 (get_tty_terminal): Now static.
4319 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4320 * termhooks.h (term_mouse_moveto): Do not declare if
4322 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4323 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4325 * sysdep.c: Make symbols static if they're not exported.
4326 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4328 (sigprocmask_set, full_mask): Remove; unused.
4329 (wait_debugging): Mark as visible.
4330 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4331 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4333 * syntax.c (syntax_temp): Define only if !__GNUC__.
4335 * sound.c (current_sound_device, current_sound): Now static.
4337 * search.c (searchbufs, searchbuf_head): Now static.
4339 * scroll.c (scroll_cost): Remove; unused.
4340 * dispextern.h (scroll_cost): Remove decl.
4342 * region-cache.h (pp_cache): Mark as externally visible.
4344 * process.c: Make symbols static if they're not exported.
4345 (process_tick, update_tick, create_process, chan_process):
4346 (Vprocess_alist, proc_buffered_char, datagram_access):
4347 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4348 (deactivate_process): Mark defn as static, as well as decl.
4349 * lisp.h (create_process): Remove decl.
4350 * process.h (chan_process, Vprocess_alist): Remove decls.
4352 * print.c: Make symbols static if they're not exported.
4353 (print_depth, new_backquote_output, being_printed, print_buffer):
4354 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4355 (print_interval, print_number_index, initial_stderr_stream):
4357 * lisp.h (Fprinc): Remove decl.
4358 (debug_output_compilation_hack): Mark as externally visible.
4360 * sysdep.c (croak): Move decl from here to syssignal.h.
4361 * syssignal.h (croak): Put it here, so the API can be checked when
4362 'croak' is called from dissociate_if_controlling_tty.
4364 * minibuf.c: Make symbols static if they're not exported.
4365 (minibuf_save_list, choose_minibuf_frame): Now static.
4366 * lisp.h (choose_minibuf_frame): Remove decl.
4368 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4370 * lread.c: Make symbols static if they're not exported.
4371 (read_objects, initial_obarray, oblookup_last_bucket_number):
4373 (make_symbol): Remove; unused.
4374 * lisp.h (initial_obarray, make_symbol): Remove decls.
4376 * keyboard.c: Make symbols static if they're not exported.
4377 (single_kboard, recent_keys_index, total_keys, recent_keys):
4378 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4379 (this_single_command_key_start, echoing, last_auto_save):
4380 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4381 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4382 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4383 (Vlispy_mouse_stem, double_click_count):
4385 (force_auto_save_soon): Define only if SIGDANGER.
4386 (ignore_mouse_drag_p): Now static if
4387 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4388 (print_help): Remove; unused.
4389 (stop_character, last_timer_event): Mark as externally visible.
4390 * keyboard.h (ignore_mouse_drag_p): Declare only if
4391 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4392 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4393 * lisp.h (echoing): Remove decl.
4394 (force_auto_save_soon): Declare only if SIGDANGER.
4395 * xdisp.c (redisplay_window): Simplify code, to make it more
4396 obvious that ignore_mouse_drag_p is not accessed if !defined
4397 USE_GTK && !defined HAVE_NS.
4399 * intervals.c: Make symbols static if they're not exported.
4400 (merge_properties_sticky, merge_interval_right, delete_interval):
4402 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4404 * insdel.c: Make symbols static if they're not exported.
4405 However, leave prepare_to_modify_buffer alone. It's never
4406 called from outside this function, but that appears to be a bug.
4407 (combine_after_change_list, combine_after_change_buffer):
4408 (adjust_after_replace, signal_before_change): Now static.
4409 (adjust_after_replace_noundo): Remove; unused.
4410 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4411 (signal_before_change): Remove decls.
4413 * indent.c (val_compute_motion, val_vmotion): Now static.
4415 * image.c: Make symbols static if they're not exported.
4416 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4418 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4419 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4421 * fringe.c (standard_bitmaps): Now static.
4422 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4424 * frame.c: Make symbols static if they're not exported.
4425 (x_report_frame_params, make_terminal_frame): Now static.
4426 (get_frame_param): Now static, unless HAVE_NS.
4427 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4428 (x_get_resource_string): Remove; not used.
4429 * frame.h (make_terminal_frame, x_report_frame_params):
4430 (x_get_resource_string); Remove decls.
4431 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4432 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4434 * font.c, fontset.c: Make symbols static if they're not exported.
4435 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4436 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4437 * font.c (font_close_object): Now static.
4438 * font.h (font_close_object): Remove.
4439 * fontset.c (FONTSET_OBJLIST): Remove.
4440 (free_realized_fontset) #if-0 the body, which does nothing.
4441 (face_suitable_for_char_p): #if-0, as it's never called.
4442 * fontset.h (face_suitable_for_char_p): Remove decl.
4443 * xfaces.c (face_at_string_position):
4444 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4445 since 0 is always ASCII.
4447 * fns.c (weak_hash_tables): Now static.
4449 * fileio.c: Make symbols static if they're not exported.
4450 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4451 (Vwrite_region_annotation_buffers): Now static.
4453 * eval.c: Make symbols static if they're not exported.
4454 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4455 * lisp.h (backtrace_list): Remove decl.
4457 * emacs.c: Make symbols static if they're not exported.
4458 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4459 (fatal_error_code, fatal_error_signal_hook, standard_args):
4461 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4462 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4463 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4464 * lisp.h (fatal_error_signal_hook): Remove decl.
4465 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4467 * editfns.c: Move a (normally-unused) function to its only use.
4468 * editfns.c, lisp.h (get_operating_system_release): Remove.
4469 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4470 worth the hassle of breaking this out.
4472 * xterm.c: Make symbols static if they're not exported.
4473 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4474 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4475 (x_destroy_window, x_delete_display):
4477 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4478 (x_mouse_leave): Remove; unused.
4479 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4480 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4481 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4483 (x_mouse_leave): Declare only if WINDOWSNT.
4484 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4485 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4488 * ftxfont.c: Make symbols static if they're not exported.
4489 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4491 * font.h (ftxfont_driver): Likewise.
4493 * xfns.c: Make symbols static if they're not exported.
4494 (x_last_font_name, x_display_info_for_name):
4495 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4496 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4497 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4498 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4499 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4500 (last_show_tip_args): Now static.
4501 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4502 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4503 (x_screen_planes): Remove; unused.
4504 * dispextern.h (x_screen_planes): Remove decl.
4506 * dispnew.c: Make symbols static if they're not exported.
4507 * dispextern.h (redraw_garbaged_frames, scrolling):
4508 (increment_row_positions): Remove.
4509 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4510 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4512 (redraw_garbaged_frames): Remove; unused.
4514 * xfaces.c: Make symbols static if they're not exported.
4515 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4517 * xterm.h (defined_color): Remove decls.
4518 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4519 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4520 (menu_face_changed_default, defined_color, free_realized_face):
4521 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4522 (ascii_face_of_lisp_face): Remove; unused.
4524 * xdisp.c: Make symbols static if they're not exported.
4525 * dispextern.h (scratch_glyph_row, window_box_edges):
4526 (glyph_to_pixel_coords, set_cursor_from_row):
4527 (get_next_display_element, set_iterator_to_next):
4528 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4529 (show_mouse_face): Remove decls
4530 * frame.h (message_buf_print): Likewise.
4531 * lisp.h (pop_message, set_message, check_point_in_composition):
4533 * xterm.h (set_vertical_scroll_bar): Likewise.
4534 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4535 (message_buf_print, scratch_glyph_row, displayed_buffer):
4536 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4537 (get_next_display_element, show_mouse_face, window_box_edges):
4538 (frame_to_window_pixel_xy, check_point_in_composition):
4539 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4540 (glyph_to_pixel_coords): Remove; unused.
4542 * dired.c (file_name_completion): Now static.
4544 * dbusbind.c (xd_in_read_queued_messages): Now static.
4546 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4547 * data.c (circular_list_error): Remove.
4549 * commands.h (last_point_position, last_point_position_buffer):
4550 (last_point_position_window): Remove decls.
4551 * keyboard.c: Make these variables static.
4553 * coding.h (coding, code_convert_region, encode_coding_gap):
4555 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4556 (iso_code_class, detect_coding, code_convert_region): Now static.
4557 (encode_coding_gap): Remove; unused.
4559 * chartab.c (chartab_chars, chartab_bits): Now static.
4561 * charset.h (charset_iso_8859_1): Remove decl.
4562 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4565 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4566 * ccl.c (Vccl_program_table): Now static.
4567 (check_ccl_update): Remove; unused.
4569 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4570 * category.h: ... from here.
4571 * category.c (check_category_table, set_category_set): Now static.
4573 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4574 * lisp.h: Remove these decls.
4576 * buffer.c (buffer_count): Remove unused var.
4578 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4579 so that it's not optimized away.
4580 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4581 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4582 exported only to the debugger.
4584 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4585 * atimer.h (run_all_atimers): Remove; not exported.
4587 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4588 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4589 was inaccessible from Lisp.
4590 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4591 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4593 alloc.c: Import and export fewer symbols, and remove unused items.
4594 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4596 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4597 it's not optimized away by whole-program optimization.
4598 (message_enable_multibyte, free_misc): Remove.
4599 (catchlist, handlerlist, mark_backtrace):
4600 Declare only if BYTE_MARK_STACK.
4601 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4602 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4603 (message_enable_multibyte): Remove decl.
4604 (free_misc, interval_free_list, float_block, float_block_index):
4605 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4606 (cons_free_list, last_marked_index):
4608 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4609 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4610 (mark_backtrace): Define only if BYTE_MARK_STACK.
4611 * xdisp.c (message_enable_multibyte): Now static.
4613 Declare Lisp_Object Q* variables to be 'static' if not exported.
4614 This makes it easier for human readers (and static analyzers)
4615 to see whether these variables are used from other modules.
4616 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4617 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4618 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4619 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4620 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4621 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4622 * xmenu.c, xselect.c:
4623 Declare Q* vars static if they are not used in other modules.
4624 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4625 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4626 Remove decls of unexported vars.
4627 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4629 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4631 Make Emacs functions such as Fatom 'static' by default.
4632 This makes it easier for human readers (and static analyzers)
4633 to see whether these functions can be called from other modules.
4634 DEFUN now defines a static function. To make the function external
4635 so that it can be used in other C modules, use the new macro DEFUE.
4636 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4637 (Finit_image_library):
4638 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4639 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4640 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4641 Remove decls, since these functions are now static.
4642 (Funintern, Fget_internal_run_time): New decls, since these functions
4643 were already external.
4645 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4646 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4647 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4648 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4649 * keyboard.c, keymap.c, lread.c:
4650 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4651 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4652 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4653 Mark functions with DEFUE instead of DEFUN,
4654 if they are used in other modules.
4655 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4656 decls for now-static functions.
4657 * buffer.h (Fdelete_overlay): Remove decl.
4658 * callproc.c (Fgetenv_internal): Mark as internal.
4659 * composite.c (Fremove_list_of_text_properties): Remove decl.
4660 (Fcomposition_get_gstring): New forward static decl.
4661 * composite.h (Fcomposite_get_gstring): Remove decl.
4662 * dired.c (Ffile_attributes): New forward static decl.
4663 * doc.c (Fdocumntation_property): New forward static decl.
4664 * eval.c (Ffetch_bytecode): New forward static decl.
4665 (Funintern): Remove extern decl; now in .h file where it belongs.
4666 * fileio.c (Fmake_symbolic_link): New forward static decl.
4667 * image.c (Finit_image_library): New forward static decl.
4668 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4669 * intervals.h (Fprevious_property_change):
4670 (Fremove_list_of_text_properties): Remove decls.
4671 * keyboard.c (Fthis_command_keys): Remove decl.
4672 (Fcommand_execute): New forward static decl.
4673 * keymap.c (Flookup_key): New forward static decl.
4674 (Fcopy_keymap): Now static.
4675 * keymap.h (Flookup_key): Remove decl.
4676 * process.c (Fget_process): New forward static decl.
4677 (Fprocess_datagram_address): Mark as internal.
4678 * syntax.c (Fsyntax_table_p): New forward static decl.
4679 (skip_chars): Remove duplicate decl.
4680 * textprop.c (Fprevious_property_change): New forward static decl.
4681 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4683 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4684 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4686 * editfns.c (Fformat): Remove unreachable code.
4688 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4690 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4693 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4695 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4696 when at ZV. (Bug#8487)
4698 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4700 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4702 * keyboard.c (parse_tool_bar_item): Likewise.
4703 * sound.c (sound_cleanup, alsa_close): Likewise.
4704 * termcap.c (tgetent): Likewise.
4705 * xfns.c (x_default_font_parameter): Likewise.
4706 * xsettings.c (read_and_apply_settings): Likewise.
4708 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4709 (overrun_check_free): Protoize.
4711 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4713 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4714 since callers should never pass a negative size.
4715 Change the signature to match that of plain 'read' and 'write'; see
4716 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4717 * lisp.h: Update prototypes of emacs_write and emacs_read.
4719 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4721 * xdisp.c (redisplay_window): Don't try to determine the character
4722 position of the scroll margin if the window start point w->startp
4723 is outside the buffer's accessible region. (Bug#8468)
4725 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4727 Fix write-region and its subroutines for buffers > 2GB.
4728 * fileio.c (a_write, e_write): Modify declaration of arguments and
4729 local variables to support buffers larger than 2GB.
4730 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4732 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4733 argument, local variables, and return value.
4735 * lisp.h: Update prototypes of emacs_write and emacs_read.
4737 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4739 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4741 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4743 Fix more problems found by GCC 4.6.0's static checks.
4745 * xdisp.c (vmessage): Use a better test for character truncation.
4747 * charset.c (load_charset_map): <, not <=, for optimization,
4748 and to avoid potential problems with integer overflow.
4749 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4750 * casetab.c (set_identity, shuffle): Likewise.
4751 * editfns.c (Fformat): Likewise.
4752 * syntax.c (skip_chars): Likewise.
4754 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4755 This also lets GCC 4.6.0 generate slightly better loop code.
4757 * callint.c (Fcall_interactively): <, not <=, for optimization.
4758 (Fcall_interactively): Count the number of arguments produced,
4759 not the number of arguments given. This is simpler and lets GCC
4760 4.6.0 generate slightly better code.
4762 * ftfont.c: Distingish more carefully between FcChar8 and char.
4763 The previous code passed unsigned char * to a functions like
4764 strlen and xstrcasecmp that expect char *, which does not
4765 conform to the C standard.
4766 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4767 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4768 char * when the C standard requires it.
4770 * keyboard.c (read_char): Remove unused var.
4772 * eval.c: Port to Windows vsnprintf (Bug#8435).
4774 (SIZE_MAX): Define if the headers do not.
4775 (verror): Do not give up if vsnprintf returns a negative count.
4776 Instead, grow the buffer. This ports to Windows vsnprintf, which
4777 does not conform to C99. Problem reported by Eli Zaretskii.
4778 Also, simplify the allocation scheme, by avoiding the need for
4779 calling realloc, and removing the ALLOCATED variable.
4781 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4783 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4784 But keep the doprint source code for now, as we might revamp it
4785 and use it again (Bug#8435).
4786 * lisp.h (doprnt): Remove.
4787 * Makefile.in (base_obj): Remove doprnt.o.
4788 * deps.mk (doprnt.o): Remove.
4790 error: Print 32- and 64-bit integers portably (Bug#8435).
4791 Without this change, on typical 64-bit hosts error ("...%d...", N)
4792 was used to print both 32- and 64-bit integers N, which relied on
4794 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4796 * lisp.h (error, verror): Mark as printf-like functions.
4797 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4798 Report overflow in size calculations when allocating printf buffer.
4799 Do not truncate output string at its first null byte.
4800 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4801 Truncate the output at a character boundary, since vsnprintf does not
4803 * charset.c (check_iso_charset_parameter): Convert internal
4804 character to string before calling 'error', since %c now has the
4806 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4807 overflow when computing char to be passed to 'error'. Do not
4808 pass Lisp_Object to 'error'; pass the integer instead.
4809 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4810 formatted with plain %d.
4812 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4814 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4816 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4818 * xterm.c (x_catch_errors): Remove duplicate declaration.
4820 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4822 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4824 2011-04-10 Jim Meyering <meyering@redhat.com>
4826 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4827 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4828 return ssize_t not "int", and use size_t as the buffer length.
4829 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4830 * gnutls.h: Update declarations.
4831 * process.c (read_process_output): Use ssize_t, to match.
4832 (send_process): Likewise.
4834 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4836 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4838 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4840 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4841 Use unsigned char, to match FcChar8 type definition.
4843 * xterm.c (handle_one_xevent):
4844 * xmenu.c (create_and_show_popup_menu):
4845 * xselect.c (x_decline_selection_request)
4846 (x_reply_selection_request): Avoid type-punned deref of X events.
4848 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4850 Fix some uses of `int' instead of EMACS_INT.
4851 * search.c (string_match_1, fast_string_match)
4852 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4853 (scan_buffer, find_next_newline_no_quit)
4854 (find_before_next_newline, search_command, Freplace_match)
4855 (Fmatch_data): Make some `int' variables be EMACS_INT.
4857 * xdisp.c (display_count_lines): 3rd argument and return value now
4858 EMACS_INT. All callers changed.
4859 (pint2hrstr): Last argument is now EMACS_INT.
4861 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4862 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4863 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4864 (decode_coding_utf_16, decode_coding_emacs_mule)
4865 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4866 (decode_coding_ccl, decode_coding_charset)
4867 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4868 (decode_coding_iso_2022, decode_coding_emacs_mule)
4869 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4870 <char_offset, last_offset>: Declare EMACS_INT.
4871 (encode_coding_utf_8, encode_coding_utf_16)
4872 (encode_coding_emacs_mule, encode_invocation_designation)
4873 (encode_designation_at_bol, encode_coding_iso_2022)
4874 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4875 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4877 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4878 (encode_invocation_designation): Last argument P_NCHARS is now
4880 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4881 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4883 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4886 * ccl.c (Fccl_execute_on_string): Declare some variables
4889 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4891 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4893 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4895 * process.c (Fformat_network_address): Doc fix.
4897 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4899 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4901 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4903 * keyboard.c (read_char): Call Lisp function help-form-show,
4904 instead of using internal_with_output_to_temp_buffer.
4905 (Qhelp_form_show): New var.
4906 (syms_of_keyboard): Use DEFSYM macro.
4908 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4910 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4912 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4914 * process.c (Flist_processes): Remove to Lisp.
4915 (list_processes_1): Delete.
4917 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4919 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4921 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4923 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4925 Fix more problems found by GCC 4.6.0's static checks.
4927 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4929 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4931 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4933 * xdisp.c (vmessage): Mark as a printf-like function.
4935 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4937 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4939 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4940 printf-like functions.
4941 (tiff_load): Add casts to remove these marks before passing them
4942 to system-supplied API.
4944 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4946 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4947 This avoids several warnings with gcc -Wstrict-overflow.
4948 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4949 directly, rather than having caller test rule sign. This avoids
4950 some unnecessary tests.
4951 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4952 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4953 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4955 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4956 (xfont_open): Avoid unnecessary tests.
4958 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4960 * composite.h, composite.c (composition_gstring_put_cache):
4961 Use EMACS_INT, not int, for length.
4963 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4964 breaking out part of COMPOSITION_DECODE_RULE.
4965 (COMPOSITION_DECODE_RULE): Use it.
4966 * composite.c (get_composition_id): Remove unused local vars,
4967 by using the new macro.
4969 * textprop.c (set_text_properties_1): Change while to do-while,
4970 since the condition is always true at first.
4972 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4973 (interval_deletion_adjustment): Return unsigned value.
4976 * process.c (list_processes_1, create_pty, read_process_output):
4977 (exec_sentinel): Remove vars that were set but not used.
4978 (create_pty): Remove unnecessary "volatile"s.
4979 (Fnetwork_interface_info): Avoid possibility of int overflow.
4980 (read_process_output): Do adaptive read buffering even if carryover.
4981 (read_process_output): Simplify nbytes computation if buffered.
4983 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4985 * syntax.c (scan_words): Remove var that was set but not used.
4986 (update_syntax_table): Use unsigned instead of int.
4988 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4989 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4990 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4992 * print.c (print_error_message): Avoid int overflow.
4994 * font.c (font_list_entities): Redo for clarity,
4995 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4997 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4998 (font_score): Avoid potential overflow in diff calculation.
5000 * fns.c (substring_both): Remove var that is set but not used.
5001 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5003 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5005 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5006 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5007 can always succeed if overflow has undefined behavior.
5009 * search.c (boyer_moore, wordify): Remove vars set but not used.
5010 (wordify): Omit three unnecessary tests.
5012 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5013 All callers changed. This avoids the need for an unused var.
5015 * casefiddle.c (casify_region): Remove var that is set but not used.
5017 * dired.c (file_name_completion): Remove var that is set but not used.
5019 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5021 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5022 (Finsert_file_contents): Remove unnecessary code checking fd.
5024 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5025 Check for integer overflow on size calculations.
5027 * buffer.c (Fprevious_overlay_change): Remove var that is set
5030 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5031 Remove vars that are set but not used.
5032 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5033 (timer_check_2): Mark vars as initialized.
5035 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5037 * image.c (lookup_image): Remove var that is set but not used.
5038 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5040 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5041 that are set but not used.
5043 * xfns.c (make_invisible_cursor): Don't return garbage
5044 if XCreateBitmapFromData fails (Bug#8410).
5046 * xselect.c (x_get_local_selection, x_handle_property_notify):
5047 Remove vars that are set but not used.
5049 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5050 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5052 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5053 Remove var that is set but not used.
5054 (scroll_bar_windows_size): Now size_t, not int.
5055 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5058 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5059 (map_tty_color) [!defined MSDOS]: Likewise.
5061 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5063 * coding.c: Remove vars that are set but not used.
5064 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5065 All callers changed.
5066 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5067 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5068 (decode_coding_charset): Remove vars that are set but not used.
5070 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5071 that is set but not used.
5073 * print.c (print_object): Remove var that is set but not used.
5075 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5076 The gnulib version avoids calling malloc in the usual case,
5077 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5078 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5079 * filelock.c (current_lock_owner): Likewise.
5080 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5081 * sysdep.c: Include allocator.h, careadlinkat.h.
5082 (emacs_no_realloc_allocator): New static constant.
5083 (emacs_readlink): New function.
5084 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5085 ../lib/careadlinkat.h.
5087 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5089 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5090 first non-nil return value).
5092 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5094 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5095 if not defined (Bug#8403).
5097 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5099 * xdisp.c (display_count_lines): Remove parameter `start',
5100 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5101 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5102 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5103 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5104 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5105 and thereabouts. All callers changed.
5106 (get_per_char_metric): Remove parameter `f', unused since
5107 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5109 2011-04-02 Jim Meyering <meyering@redhat.com>
5111 do not dereference NULL upon failed strdup
5112 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5113 (ns_get_family): Likewise.
5115 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5117 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5119 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5121 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5124 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5126 Add lexical binding.
5128 * window.c (Ftemp_output_buffer_show): New fun.
5129 (Fsave_window_excursion):
5130 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5132 * lread.c (lisp_file_lexically_bound_p): New function.
5133 (Fload): Bind Qlexical_binding.
5134 (readevalloop): Remove `evalfun' arg.
5135 Bind Qinternal_interpreter_environment.
5136 (Feval_buffer): Bind Qlexical_binding.
5137 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5139 (syms_of_lread): Declare `lexical-binding'.
5141 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5143 * keyboard.c (eval_dyn): New fun.
5144 (menu_item_eval_property): Use it.
5146 * image.c (parse_image_spec): Use Ffunctionp.
5148 * fns.c (concat, mapcar1): Accept byte-code-functions.
5150 * eval.c (Fsetq): Handle lexical vars.
5151 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5152 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5153 (FletX, Flet): Obey lexical binding.
5154 (Fcommandp): Handle closures.
5155 (Feval): New `lexical' arg.
5156 (eval_sub): New function extracted from Feval. Use it almost
5157 everywhere where Feval was used. Look up vars in lexical env.
5159 (Ffunctionp): Move from subr.el.
5160 (Ffuncall): Handle closures.
5161 (apply_lambda): Remove `eval_flags'.
5162 (funcall_lambda): Handle closures and new byte-code-functions.
5163 (Fspecial_variable_p): New function.
5164 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5165 but without exporting it to Lisp.
5167 * doc.c (Fdocumentation, store_function_docstring):
5168 * data.c (Finteractive_form): Handle closures.
5170 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5173 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5175 (exec_byte_code): New function extracted from Fbyte_code to handle new
5176 calling convention for byte-code-functions. Add new byte-codes.
5178 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5180 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5182 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5184 * xdisp.c (redisplay_internal): Fix prototype.
5186 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5188 * xdisp.c (SCROLL_LIMIT): New macro.
5189 (try_scrolling): Use it when setting scroll_limit.
5190 Limit scrolling to 100 screen lines.
5191 (redisplay_window): Even when falling back on "recentering",
5192 position point in the window according to scroll-conservatively,
5193 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5195 (try_scrolling): When point is above the window, allow searching
5196 as far as scroll_max, or one screenful, to compute vertical
5197 distance from PT to the scroll margin position. This prevents
5198 try_scrolling from unnecessarily failing when
5199 scroll-conservatively is set to a value slightly larger than the
5200 window height. Clean up the case of PT below the margin at bottom
5201 of window: scroll_max can no longer be INT_MAX. When aggressive
5202 scrolling is in use, don't let point enter the opposite scroll
5203 margin as result of the scroll.
5204 (syms_of_xdisp) <scroll-conservatively>: Document the
5205 threshold of 100 lines for never-recentering scrolling.
5207 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5209 * dispextern.h (move_it_by_lines):
5210 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5211 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5212 (message_log_check_duplicate): Remove parameters `prev_bol' and
5213 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5214 (redisplay_internal): Remove parameter `preserve_echo_area',
5215 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5217 * indent.c (Fvertical_motion):
5218 * window.c (window_scroll_pixel_based, Frecenter):
5219 Don't pass `need_y_p' to `move_it_by_lines'.
5221 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5223 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5224 steal a few bits to be more compact.
5225 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5226 Remove unneeded casts.
5228 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5230 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5232 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5233 binding" message (bug#7967).
5235 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5237 Fix more problems found by GCC 4.6.0's static checks.
5239 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5240 Remove unused local var.
5242 * editfns.c (Fmessage_box): Remove unused local var.
5244 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5245 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5246 Omit unused local vars.
5247 * window.c (shrink_windows): Omit unused local var.
5248 * menu.c (digest_single_submenu): Omit unused local var.
5249 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5250 Omit unused local var.
5252 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5253 Don't assume string length fits in int.
5254 (keyremap_step, read_key_sequence): Use size_t for sizes.
5255 (read_key_sequence): Don't check last_real_key_start redundantly.
5257 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5258 instead of alloca (Bug#8344).
5260 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5261 (Fbacktrace_frame): Don't assume nframes fits in int.
5263 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5265 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5268 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5270 * cm.c (calccost): Turn while-do into do-while, for clarity.
5272 * keyboard.c (syms_of_keyboard): Use the same style as later
5273 in this function when indexing through an array. This also
5274 works around GCC bug 48267.
5276 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5278 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5280 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5281 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5283 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5284 This avoids undefined behavior on integer overflow, and is a bit
5285 more convenient anyway since it is compared to a size_t variable.
5287 Variadic C functions now count arguments with size_t, not int.
5288 This avoids an unnecessary limitation on 64-bit machines, which
5289 caused (substring ...) to crash on large vectors (Bug#8344).
5290 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5291 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5292 All variadic functions and their callers changed accordingly.
5293 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5294 * data.c (arith_driver, float_arith_driver): Likewise.
5295 * editfns.c (general_insert_function): Likewise.
5296 * eval.c (struct backtrace.nargs, interactive_p)
5297 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5298 (funcall_lambda, mark_backtrace): Likewise.
5299 * fns.c (concat): Likewise.
5300 * frame.c (x_set_frame_parameters): Likewise.
5301 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5302 0 if not found, not -1. All callers changed.
5304 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5305 (stack_copy_size): Now size_t, not int.
5306 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5308 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5310 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5311 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5312 All callers changed.
5314 * lisp.h (multibyte_char_to_unibyte):
5315 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5316 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5317 * character.h (CHAR_TO_BYTE8):
5318 * cmds.c (internal_self_insert):
5319 * editfns.c (general_insert_function):
5320 * keymap.c (push_key_description):
5321 * search.c (Freplace_match):
5322 * xdisp.c (message_dolog, set_message_1): All callers changed.
5324 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5326 * keyboard.c (safe_run_hook_funcall): New function.
5327 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5328 don't set the hook to nil, but remove the offending function instead.
5329 (Qcommand_hook_internal): Remove, unused.
5330 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5331 Vcommand_hook_internal.
5333 * eval.c (enum run_hooks_condition): Remove.
5334 (funcall_nil, funcall_not): New functions.
5335 (run_hook_with_args): Call each function through a `funcall' argument.
5336 Remove `cond' argument, now redundant.
5337 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5338 (Frun_hook_with_args_until_failure): Adjust accordingly.
5339 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5341 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5343 * dispextern.h (string_buffer_position): Remove declaration.
5345 * print.c (strout): Remove parameter `multibyte', unused since
5346 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5348 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5349 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5350 All callers changed.
5352 * w32.c (_wsa_errlist): Use braces for struct initializers.
5354 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5355 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5356 All callers changed.
5357 (string_buffer_position): Likewise. Also, make static (it's never
5358 used outside xdisp.c).
5359 (cursor_row_p): Remove parameter `w', unused since
5360 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5361 (decode_mode_spec): Remove parameter `precision', introduced during
5362 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5363 All callers changed.
5365 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5367 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5369 2011-03-27 Anders Lindgren <andlind@gmail.com>
5371 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5372 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5373 (ns_update_auto_hide_menu_bar): New functions.
5374 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5375 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5376 ns_constrain_all_frames.
5377 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5378 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5380 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5382 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5384 2011-03-27 Glenn Morris <rgm@gnu.org>
5386 * syssignal.h: Replace RETSIGTYPE with void.
5387 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5388 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5389 Replace SIGTYPE with void everywhere.
5390 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5391 * s/template.h (SIGTYPE): Remove commented out definition.
5393 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5395 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5396 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5398 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5400 * w32.c (read_unc_volume): Use parameter `henum', instead of
5401 global variable `wget_enum_handle'.
5403 * keymap.c (describe_vector): Remove parameters `indices' and
5404 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5405 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5407 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5409 * keyboard.c (timer_check): Remove parameter `do_it_now',
5410 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5411 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5412 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5414 * keyboard.c (read_char):
5415 * w32menu.c (w32_menu_display_help):
5416 * xmenu.c (show_help_event, menu_help_callback):
5417 Adjust calls to `show_help_echo'.
5419 * gtkutil.c (xg_maybe_add_timer):
5420 * keyboard.c (readable_events):
5421 * process.c (wait_reading_process_output):
5422 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5424 * insdel.c (adjust_markers_gap_motion):
5425 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5426 (gap_left, gap_right): Don't call it.
5428 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5430 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5431 incurred during fontification.
5433 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5435 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5436 (DEFVAR_PER_BUFFER): Don't pass it.
5438 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5439 (scrolling_window): Don't pass it.
5441 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5443 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5445 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5447 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5448 of variables specific to SELinux and computation of `encoded_absname'.
5450 * image.c (XPutPixel): Remove unused variable `height'.
5452 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5454 * unexw32.c (get_section_info): Remove unused variable `section'.
5456 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5457 (system_process_attributes): Remove unused variable `sess'.
5458 (sys_read): Remove unused variable `err'.
5460 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5461 (w32_wnd_proc): Remove unused variable `isdead'.
5462 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5463 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5464 (x_create_tip_frame): Remove unused variable `tem'.
5466 * w32inevt.c (w32_console_read_socket):
5467 Remove unused variable `no_events'.
5469 * w32term.c (x_draw_composite_glyph_string_foreground):
5470 Remove unused variable `width'.
5472 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5474 * w32term.c (x_set_glyph_string_clipping):
5475 Don't pass uninitialized region to CombineRgn.
5477 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5479 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5480 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5481 (Fx_close_connection): Remove unused variable `i'.
5483 * w32font.c (w32font_draw): Return number of glyphs.
5484 (w32font_open_internal): Remove unused variable `i'.
5485 (w32font_driver): Add missing initializer.
5487 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5488 (fill_in_menu): Remove unused variable `items_added'.
5490 * w32term.c (last_mouse_press_frame): Remove static global variable.
5491 (w32_clip_to_row): Remove unused variable `f'.
5492 (x_delete_terminal): Remove unused variable `i'.
5494 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5495 (NOTHING): Remove unused static global variable.
5496 (uniscribe_check_otf): Remove unused variable `table'.
5497 (uniscribe_font_driver): Add missing initializers.
5499 2011-03-23 Julien Danjou <julien@danjou.info>
5501 * term.c (Fsuspend_tty, Fresume_tty):
5502 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5503 * window.c (temp_output_buffer_show):
5504 * insdel.c (signal_before_change):
5505 * frame.c (Fhandle_switch_frame):
5506 * fileio.c (Fdo_auto_save):
5507 * emacs.c (Fkill_emacs):
5508 * editfns.c (save_excursion_restore):
5509 * cmds.c (internal_self_insert):
5510 * callint.c (Fcall_interactively):
5511 * buffer.c (Fkill_all_local_variables):
5512 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5514 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5515 unconditionnaly since it does the check itself.
5517 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5519 Fix more problems found by GCC 4.5.2's static checks.
5521 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5522 the first time through the loop, since we know p0 < p1 then.
5523 This also avoids a gcc -Wstrict-overflow warning.
5525 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5526 leading to a memory leak, possible in functions like
5527 load_charset_map_from_file that can allocate an unbounded number
5528 of objects (Bug#8318).
5530 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5531 that could (at least in theory) be that large.
5533 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5534 This is less likely to overflow, and avoids undefined behavior if
5535 overflow does occur. All callers changed. Use strtoul to scan
5536 for the unsigned long integer.
5537 (pint2hrstr): Simplify and tune code slightly.
5538 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5540 * scroll.c (do_scrolling): Work around GCC bug 48228.
5541 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5543 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5544 This also avoids a warning with gcc -Wstrict-overflow.
5545 (validate_x_resource_name): Simplify count usage.
5546 This also avoids a warning with gcc -Wstrict-overflow.
5548 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5551 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5553 * process.c (Fmake_network_process): Use socklen_t, not int,
5554 where POSIX says socklen_t is required in portable programs.
5555 This fixes a porting bug on hosts like 64-bit HP-UX, where
5556 socklen_t is wider than int (Bug#8277).
5557 (Fmake_network_process, server_accept_connection):
5558 (wait_reading_process_output, read_process_output):
5561 * process.c: Rename or move locals to avoid shadowing.
5562 (list_processes_1, Fmake_network_process):
5563 (read_process_output_error_handler, exec_sentinel_error_handler):
5564 Rename or move locals.
5565 (Fmake_network_process): Define label "retry_connect" only if needed.
5566 (Fnetwork_interface_info): Fix pointer signedness.
5567 (process_send_signal): Add cast to avoid pointer signedness problem.
5568 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5569 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5571 Make tparam.h and terminfo.c consistent.
5572 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5573 Include tparam.h instead, since it declares them.
5574 * cm.h (PC): Remove extern decl; tparam.h now does this.
5575 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5576 * terminfo.c: Include tparam.h, to check interfaces.
5577 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5578 (tparam): Adjust signature to match interface in tparam.h;
5579 this removes some undefined behavior. Check that outstring and len
5580 are zero, which they always are with Emacs.
5581 * tparam.h (PC, BC, UP): New extern decls.
5583 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5584 (xftfont_open): Rename locals to avoid shadowing.
5586 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5587 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5588 (OTF_TAG_SYM): Omit macro if not needed.
5589 (ftfont_list): Remove unused local.
5590 (get_adstyle_property, ftfont_pattern_entity):
5591 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5592 Rename locals to avoid shadowing.
5594 * xfont.c (xfont_list_family): Mark var as initialized.
5596 * xml.c (make_dom): Now static.
5598 * composite.c (composition_compute_stop_pos): Rename local to
5600 (composition_reseat_it): Remove unused locals.
5601 (find_automatic_composition, composition_adjust_point): Likewise.
5602 (composition_update_it): Mark var as initialized.
5603 (find_automatic_composition): Mark vars as initialized,
5604 with a FIXME (Bug#8290).
5606 character.h: Rename locals to avoid shadowing.
5607 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5608 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5609 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5610 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5613 * textprop.c (property_change_between_p): Remove; unused.
5615 * intervals.c (interval_start_pos): Now static.
5617 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5619 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5620 Rename locals to avoid shadowing.
5622 * sound.c (wav_play, au_play, Fplay_sound_internal):
5623 Fix pointer signedness.
5624 (alsa_choose_format): Remove unused local var.
5625 (wav_play): Initialize a variable to 0, to prevent undefined
5626 behavior (Bug#8278).
5628 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5630 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5632 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5633 clobbering (Bug#8298).
5634 * sysdep.c (sys_subshell): Likewise.
5635 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5637 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5638 This should get cleaned up, so that child_setup has the
5639 same signature on all platforms.
5641 * callproc.c (call_process_cleanup): Now static.
5642 (relocate_fd): Rename locals to avoid shadowing.
5644 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5646 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5647 not to be necessary, and produces flickering.
5649 2011-03-20 Glenn Morris <rgm@gnu.org>
5651 * config.in: Remove file.
5653 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5655 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5656 are now in src/globals.h.
5657 (syms_of_minibuf): Remove spurious & from previous change.
5659 2011-03-20 Leo <sdl.web@gmail.com>
5661 * minibuf.c (completing-read-function): New variable.
5662 (completing-read-default): Rename from completing-read.
5663 (completing-read): Call completing-read-function.
5665 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5667 * xfaces.c (Fx_load_color_file):
5668 Read color file from absolute filename (bug#8250).
5670 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5672 * makefile.w32-in: Update dependencies.
5674 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5676 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5678 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5680 Fix more problems found by GCC 4.5.2's static checks.
5682 * process.c (make_serial_process_unwind, send_process_trap):
5683 (sigchld_handler): Now static.
5685 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5686 That way, the code declares only the vars that it needs.
5687 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5688 * s/cygwin.h (PTY_ITERATION): Likewise.
5689 * s/darwin.h (PTY_ITERATION): Likewise.
5690 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5692 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5693 * process.c (allocate_pty): Don't declare stb unless it's needed.
5695 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5696 (CONSTANTLIM): Remove; unused.
5697 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5698 Define only if needed.
5700 * unexelf.c (unexec): Name an expression,
5701 to avoid gcc -Wbad-function-cast warning.
5702 Use a different way to cause a compilation error if anyone uses
5703 n rather than nn, a way that does not involve shadowing.
5704 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5706 * deps.mk (unexalpha.o): Remove; unused.
5708 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5709 * unexec.h: New file.
5710 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5711 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5713 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5714 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5715 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5716 Change as necessary to match prototype in unexec.h.
5718 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5720 (back_comment, skip_chars): Mark vars as initialized.
5722 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5723 Rename locals to avoid shadowing.
5725 * lread.c (read1): Rewrite so as not to use empty "else".
5726 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5728 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5730 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5731 warning when compiling print.c.
5733 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5734 instead of using an uninitialized var.
5735 (font_sort_entities): Mark var as initialized.
5737 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5739 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5740 pointers to constants.
5741 (font_parse_fcname): Remove unused vars.
5742 (font_delete_unmatched): Now static.
5743 (font_get_spec): Remove; unused.
5744 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5745 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5746 Rename or move locals to avoid shadowing.
5748 * fns.c (require_nesting_list, require_unwind): Now static.
5749 (Ffillarray): Rename locals to avoid shadowing.
5751 * floatfns.c (domain_error2): Define only if needed.
5752 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5754 * alloc.c (mark_backtrace): Move decl from here ...
5755 * lisp.h: ... to here, so that it can be checked.
5757 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5758 (Fdefvar): Rewrite so as not to use empty "else".
5759 (lisp_indirect_variable): Name an expression,
5760 to avoid gcc -Wbad-function-cast warning.
5761 (Fdefvar): Rename locals to avoid shadowing.
5763 * callint.c (quotify_arg, quotify_args): Now static.
5764 (Fcall_interactively): Rename locals to avoid shadowing.
5765 Use const pointer when appropriate.
5767 * lisp.h (get_system_name, get_operating_system_release):
5768 Move decls here, to check interfaces.
5769 * process.c (get_operating_system_release): Move decl to lisp.h.
5770 * xrdb.c (get_system_name): Likewise.
5771 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5772 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5773 some of which prompt warnings from gcc -Wbad-function-cast.
5774 (Fformat_time_string, Fencode_time, Finsert_char):
5775 (Ftranslate_region_internal, Fformat):
5776 Rename or remove local vars to avoid shadowing.
5777 (Ftranslate_region_internal): Mark var as initialized.
5779 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5782 * lisp.h (eassert): Check that the argument compiles, even if
5783 ENABLE_CHECKING is not defined.
5785 * data.c (Findirect_variable): Name an expression, to avoid
5786 gcc -Wbad-function-cast warning.
5787 (default_value, arithcompare, arith_driver, arith_error): Now static.
5788 (store_symval_forwarding): Rename local to avoid shadowing.
5789 (Fmake_variable_buffer_local, Fmake_local_variable):
5790 Mark variables as initialized.
5791 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5793 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5794 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5795 Rename locals to avoid shadowing.
5796 (mark_stack): Move local variables into the #ifdef region where
5798 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5799 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5801 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5802 (GC_STRING_CHARS): Remove; not used.
5803 (Fmemory_limit): Cast sbrk's returned value to char *.
5805 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5806 avoids undefined behavior in theory.
5808 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5810 Use functions, not macros, for up- and down-casing (Bug#8254).
5811 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5812 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5813 to use the following functions instead of these macros.
5814 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5815 EMACS_INT, since callers assume the returned value fits in int.
5816 (upcase1): Likewise, for UPCASE_TABLE.
5817 (uppercasep, lowercasep, upcase): New static inline functions.
5818 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5819 the race-condition problem in the old DOWNCASE.
5821 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5822 Rename locals to avoid shadowing.
5823 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5824 (regex_compile, re_search_2, re_match_2_internal):
5825 Remove unused local vars.
5826 (FREE_VAR): Rewrite so as not to use empty "else",
5827 which gcc can warn about.
5828 (regex_compile, re_match_2_internal): Mark locals as initialized.
5829 (RETALLOC_IF): Define only if needed.
5830 (WORDCHAR_P): Likewise. This one is never needed, but is used
5831 only in a comment talking about a compiler bug, so put inside
5832 the #if 0 of that comment.
5833 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5834 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5837 * search.c (boyer_moore): Rename locals to avoid shadowing.
5838 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5839 (PREV_CHAR_BOUNDARY): Likewise.
5841 * search.c (simple_search): Remove unused var.
5843 * dired.c (compile_pattern): Move decl from here ...
5844 * lisp.h: ... to here, so that it can be checked.
5845 (struct re_registers): New forward decl.
5847 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5849 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5851 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5852 Rename locals to avoid shadowing.
5853 (Fvertical_motion): Mark locals as initialized.
5855 * casefiddle.c (casify_object, casify_region): Now static.
5856 (casify_region): Mark local as initialized.
5858 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5860 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5861 New macros, so that the caller can use some names other than
5862 gcpro1, gcpro2, etc.
5863 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5865 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5866 argument, for consistency with GCPRO2_VAR, etc: it is now the
5867 prefix of the variable, not the variable itself. All uses
5869 * dired.c (directory_files_internal, file_name_completion):
5870 Rename locals to avoid shadowing.
5872 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5873 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5874 dired.c's scmp function, had undefined behavior.
5875 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5876 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5877 * buffer.h: ... to here, because these macros use current_buffer,
5878 and the new implementation with inline functions needs to have
5879 current_buffer in scope now, rather than later when the macros
5881 (downcase, upcase1): New static inline functions.
5882 (DOWNCASE, UPCASE1): Reimplement using these functions.
5883 This avoids undefined behavior in expressions like
5884 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5885 from race conditions in accessing the global variables
5886 case_temp1 and case_temp2.
5887 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5888 * lisp.h (case_temp1, case_temp2): Remove their decls.
5889 * character.h (ASCII_CHAR_P): Move from here ...
5890 * lisp.h: ... to here, so that the inline functions mentioned
5893 * dired.c (directory_files_internal_unwind): Now static.
5895 * fileio.c (file_name_as_directory, directory_file_name):
5896 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5898 (file_name_as_directory): Use const pointers when appropriate.
5899 (Fexpand_file_name): Likewise. In particular, newdir might
5900 point at constant storage, so make it a const pointer.
5901 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5902 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5904 (Fset_file_times, Finsert_file_contents, auto_save_error):
5905 Rename locals to avoid shadowing.
5907 * minibuf.c (choose_minibuf_frame_1): Now static.
5908 (Ftry_completion, Fall_completions): Rename or remove locals
5911 * marker.c (bytepos_to_charpos): Remove; unused.
5913 * lisp.h (verify_bytepos, count_markers): New decls,
5914 so that gcc does not warn that these functions aren't declared.
5916 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5917 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5918 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5919 (copy_text): Remove unused local var.
5921 * filelock.c (within_one_second): Now static.
5922 (lock_file_1): Rename local to avoid shadowing.
5924 * buffer.c (fix_overlays_before): Mark locals as initialized.
5925 (fix_start_end_in_overlays): Likewise. This function should be
5926 simplified by using pointers-to-pointers, but that's a different
5928 (switch_to_buffer_1): Now static.
5929 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5930 (report_overlay_modification): Rename locals to avoid shadowing.
5932 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5933 Fix pointer signedness issue.
5934 (sys_subshell): Mark local as volatile if checking for lint,
5935 to suppress a gcc -Wclobbered warning that does not seem to be right.
5936 (MAXPATHLEN): Define only if needed.
5938 * process.c (serial_open, serial_configure): Move decls from here ...
5939 * systty.h: ... to here, so that they can be checked.
5941 * fns.c (get_random, seed_random): Move extern decls from here ...
5942 * lisp.h: ... to here, so that they can be checked.
5944 * sysdep.c (reset_io): Now static.
5945 (wait_for_termination_signal): Remove; unused.
5947 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5948 (copy_keymap_item, append_key, push_text_char_description):
5950 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5951 (DENSE_TABLE_SIZE): Remove; unused.
5952 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5953 (describe_map_tree):
5954 Rename locals to avoid shadowing.
5956 * keyboard.c: Declare functions static if they are not used elsewhere.
5957 (echo_char, echo_dash, cmd_error, top_level_2):
5958 (poll_for_input, handle_async_input): Now static.
5959 (read_char, kbd_buffer_get_event, make_lispy_position):
5960 (make_lispy_event, make_lispy_movement, apply_modifiers):
5961 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5962 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5963 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5964 (read_key_sequence, read_char): Mark locals as initialized.
5965 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5967 * keyboard.h (make_ctrl_char): New decl.
5968 (mark_kboards): Move decl here ...
5969 * alloc.c (mark_kboards): ... from here.
5971 * lisp.h (force_auto_save_soon): New decl.
5973 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5974 (DEFINE_DUMMY_FUNCTION): New macro.
5975 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5977 (main): Add casts to avoid warnings
5978 if GCC considers string literals to be constants.
5980 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5982 * dbusbind.c: Pointer signedness fixes.
5983 (xd_signature, xd_append_arg, xd_initialize):
5984 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5985 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5986 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5987 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5989 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5990 if GCC considers string literals to be constants.
5991 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5993 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5995 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5996 (print_preprocess, print_object): New macro to fix last change.
5998 * print.c (print_preprocess): Don't forget font objects.
6000 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6002 * emacs.c (USAGE3): Doc fixes.
6004 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6006 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6009 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6011 * lisp.h (VWindow_system, Qfile_name_history):
6012 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6013 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6014 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6016 * w32select.c: Don't #include "keyboard.h".
6017 (run_protected): Add extern declaration for waiting_for_input.
6019 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6020 * w32console.c (detect_input_pending, read_input_pending)
6021 (encode_terminal_code):
6022 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6023 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6024 (w32_system_caret_y, Qfile_name_history):
6025 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6026 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6027 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6028 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6029 * w32proc.c (Qlocal, report_file_error):
6030 * w32term.c (Vwindow_system, updating_frame):
6031 * w32uniscribe.c (initialized, uniscribe_font_driver):
6032 Remove unneeded extern declarations.
6034 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6036 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6038 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6040 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6041 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6042 These macros can no longer be used for assignment.
6044 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6045 Assign struct members directly, instead of using BUF_BEGV etc.
6046 (record_buffer_markers, fetch_buffer_markers): New functions for
6047 recording and fetching special buffer markers.
6048 (set_buffer_internal_1, set_buffer_temp): Use them.
6050 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6052 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6054 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6055 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6057 * xdisp.c (hscroll_window_tree):
6058 (reconsider_clip_changes): Use PT instead of BUF_PT.
6060 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6062 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6063 $(EMACS_ROOT)/lib/intprops.h.
6065 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6067 Fix more problems found by GCC 4.5.2's static checks.
6069 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6070 to unsigned char * to avoid compiler diagnostic.
6071 (xg_free_frame_widgets): Make it clear that a local variable is
6072 needed only if USE_GTK_TOOLTIP.
6073 (gdk_window_get_screen): Make it clear that this macro is needed
6074 only if USE_GTK_TOOLTIP.
6075 (int_gtk_range_get_value): New function, which avoids a diagnostic
6076 from gcc -Wbad-function-cast.
6077 (xg_set_toolkit_scroll_bar_thumb): Use it.
6078 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6079 diagnostic from gcc -Wbad-function-cast.
6080 (get_utf8_string, xg_get_file_with_chooser):
6081 Rename locals to avoid shadowing.
6082 (create_dialog): Move locals to avoid shadowing.
6084 * xgselect.c (xg_select): Remove unused var.
6086 * image.c (four_corners_best): Mark locals as initialized.
6087 (gif_load): Initialize transparent_p to zero (Bug#8238).
6088 Mark another local as initialized.
6089 (my_png_error, my_error_exit): Mark with NO_RETURN.
6091 * image.c (clear_image_cache): Now static.
6092 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6093 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6094 (x_edge_detection): Remove unnecessary cast that
6095 gcc -Wbad-function-cast diagnoses.
6096 (gif_load): Fix pointer signedness.
6097 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6098 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6100 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6102 Improve quality of tests for time stamp overflow.
6103 For example, without this patch (encode-time 0 0 0 1 1
6104 1152921504606846976) returns the obviously-bogus value (-948597
6105 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6106 reports time overflow. See
6107 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6108 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6109 * editfns.c: Include limits.h and intprops.h.
6110 (TIME_T_MIN, TIME_T_MAX): New macros.
6111 (time_overflow): Move earlier, to before first use.
6112 (hi_time, lo_time): New functions, for an accurate test for
6114 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6115 (Fget_internal_run_time): Don't assume time_t fits in int.
6116 (make_time): Use list2 instead of Fcons twice.
6117 (Fdecode_time): More accurate test for out-of-range times.
6118 (check_tm_member): New function.
6119 (Fencode_time): Use it, to test for out-of-range times.
6120 (lisp_time_argument): Don't rely on undefined left-shift and
6121 right-shift behavior when checking for time stamp overflow.
6123 * editfns.c (time_overflow): New function, refactoring common code.
6124 (Fformat_time_string, Fdecode_time, Fencode_time):
6125 (Fcurrent_time_string): Use it.
6127 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6128 * dired.c (make_time): Move to ...
6129 * editfns.c (make_time): ... here.
6130 * systime.h: Note the move.
6132 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6134 * fringe.c (update_window_fringes): Remove unused variables.
6136 * unexmacosx.c (copy_data_segment): Also copy __got section.
6139 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6141 * termcap.c [MSDOS]: Include "msdos.h".
6142 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6143 Constify `char *' arguments and their references according to
6144 prototypes in tparam.h.
6146 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6148 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6149 Adapt all references accordingly.
6151 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6153 2011-03-11 Tom Tromey <tromey@redhat.com>
6155 * buffer.c (syms_of_buffer): Remove obsolete comment.
6157 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6159 * termhooks.h (encode_terminal_code): Declare prototype.
6161 * msdos.c (encode_terminal_code): Don't declare prototype.
6163 * term.c (encode_terminal_code): Now external again, used by
6164 w32console.c and msdos.c.
6166 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6167 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6169 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6171 Fix some minor problems found by GCC 4.5.2's static checks.
6173 * fringe.c (update_window_fringes): Mark locals as initialized
6175 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6177 * alloc.c (mark_fringe_data): Move decl from here ...
6178 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6179 to check its interface.
6180 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6182 * fontset.c (free_realized_fontset): Now static.
6183 (Fset_fontset_font): Rename local to avoid shadowing.
6184 (fontset_font): Mark local as initialized.
6185 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6187 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6189 * xselect.c (x_disown_buffer_selections): Remove; not used.
6190 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6191 (x_own_selection, Fx_disown_selection_internal): Rename locals
6193 (x_handle_dnd_message): Remove local to avoid shadowing.
6195 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6196 so that the caller can use some name other than gcpro1.
6197 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6198 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6199 (Fx_backspace_delete_keys_p):
6200 Use them to avoid shadowing, and rename vars to avoid shadowing.
6201 (x_decode_color, x_set_name, x_window): Now static.
6202 (Fx_create_frame): Add braces to silence GCC warning.
6203 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6204 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6205 Remove unused locals.
6206 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6207 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6208 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6211 * xterm.h (x_mouse_leave): New decl.
6213 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6214 Remove unused functions.
6215 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6216 (x_calc_absolute_position): Now static.
6217 (XTread_socket): Don't define label "out" unless it's used.
6218 Don't declare local "event" unless it's used.
6219 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6220 unless they are used.
6221 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6222 (x_fatal_error_signal): Remove; not used.
6223 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6224 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6225 (x_error_catcher, x_connection_closed, x_error_handler):
6226 (x_error_quitter, xembed_send_message, x_iconify_frame):
6227 (my_log_handler): Rename locals to avoid shadowing.
6228 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6229 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6231 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6232 Rename or move locals to avoid shadowing.
6233 (tty_defined_color, merge_face_heights): Now static.
6234 (free_realized_faces_for_fontset): Remove; not used.
6235 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6236 does not deduce is never used uninitialized.
6237 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6238 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6240 * terminal.c (store_terminal_param): Now static.
6242 * xmenu.c (menu_highlight_callback): Now static.
6243 (set_frame_menubar): Remove unused local.
6244 (xmenu_show): Rename parameter to avoid shadowing.
6245 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6246 since they might point to immutable storage.
6247 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6248 since it's unused otherwise.
6250 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6251 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6252 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6253 avoids a gcc -Wuninitialized diagnostic.
6254 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6255 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6256 does not deduce are never used uninitialized.
6258 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6260 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6261 * window.c (window_loop, size_window):
6262 (run_window_configuration_change_hook, enlarge_window): Likewise.
6264 * window.c (display_buffer): Now static.
6265 (size_window): Mark variables that gcc -Wuninitialized
6266 does not deduce are never used uninitialized.
6267 * window.h (check_all_windows): New decl, to forestall
6268 gcc -Wmissing-prototypes diagnostic.
6269 * dispextern.h (bidi_dump_cached_states): Likewise.
6271 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6273 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6275 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6276 and to avoid gcc -Wuninitialized warning.
6277 (load_charset_map): Mark variables that gcc -Wuninitialized
6278 does not deduce are never used uninitialized.
6279 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6281 * coding.c (coding_set_source, coding_set_destination):
6282 Use "else { /* comment */ }" rather than "else /* comment */;"
6283 for clarity, and to avoid gcc -Wempty-body warning.
6284 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6285 a block, when the outer 'i' will do.
6286 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6287 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6288 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6289 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6290 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6291 Rename locals to avoid shadowing.
6292 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6293 * coding.c (emacs_mule_char, encode_invocation_designation):
6294 Now static, since they're not used elsewhere.
6295 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6296 (decode_coding_object, encode_coding_object, detect_coding_system):
6297 (decode_coding_emacs_mule): Mark variables that gcc
6298 -Wuninitialized does not deduce are never used uninitialized.
6299 (detect_coding_iso_2022): Initialize a local variable that might
6300 be used uninitialized. Leave a FIXME because it's not clear that
6301 this initialization is needed. (Bug#8211)
6302 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6303 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6304 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6305 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6306 Remove unused macros.
6308 * category.c (hash_get_category_set): Remove unused local var.
6309 (copy_category_table): Now static, since it's not used elsewhere.
6310 * character.c (string_count_byte8): Likewise.
6312 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6313 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6315 * chartab.c (copy_sub_char_table): Now static, since it's not used
6317 (sub_char_table_ref_and_range, char_table_ref_and_range):
6318 Rename locals to avoid shadowing.
6319 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6321 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6322 (BIDI_BOB): Remove unused macro.
6324 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6325 deduce are never used uninitialized.
6326 * term.c (encode_terminal_code): Likewise.
6328 * term.c (encode_terminal_code): Now static. Remove unused local.
6330 * tparam.h: New file.
6331 * term.c, tparam.h: Include it.
6332 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6333 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6334 Move these decls to tparam.h, and make them agree with what
6335 is actually in tparam.c. The previous trick of using incompatible
6336 decls in different modules does not conform to the C standard.
6337 All callers of tparam changed to use tparam's actual API.
6338 * tparam.c (tparam1, tparam, tgoto):
6339 Use const pointers where appropriate.
6341 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6342 * cm.h (struct cm): Likewise.
6343 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6344 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6345 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6346 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6347 (turn_on_face, init_tty): Likewise.
6348 * termchar.h (struct tty_display_info): Likewise.
6350 * term.c (term_mouse_position): Rename local to avoid shadowing.
6352 * alloc.c (mark_ttys): Move decl from here ...
6353 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6355 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6357 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6359 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6361 * search.c (compile_pattern_1): Remove argument regp, unused since
6362 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6363 (compile_pattern): Don't pass it.
6365 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6367 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6368 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6370 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6372 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6374 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6375 gdk_window_get_screen, gdk_window_get_geometry,
6376 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6377 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6378 (xg_get_pixbuf_from_pixmap): New function.
6379 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6380 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6381 Call xg_get_pixbuf_from_pixmap instead of
6382 gdk_pixbuf_get_from_drawable.
6383 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6384 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6385 (xg_check_special_colors): Use GtkStyleContext and its functions
6387 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6388 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6389 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6390 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6391 Call gtk_widget_get_preferred_size.
6392 (xg_frame_resized): gdk_window_get_geometry only takes 5
6394 (xg_win_to_widget, xg_event_is_for_menubar):
6395 Call gdk_x11_window_lookup_for_display.
6396 (xg_set_widget_bg): New function.
6397 (delete_cb): New function.
6398 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6399 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6400 (xg_set_background_color): Call xg_set_widget_bg.
6401 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6402 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6403 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6404 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6406 (update_frame_tool_bar): Call gtk_widget_hide.
6407 (xg_initialize): Use GDK_KEY_g.
6409 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6411 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6413 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6414 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6415 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6417 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6419 * w32xfns.c (select_palette): Check success of RealizePalette against
6420 GDI_ERROR, not zero.
6422 See ChangeLog.11 for earlier changes.
6428 Copyright (C) 2011 Free Software Foundation, Inc.
6430 This file is part of GNU Emacs.
6432 GNU Emacs is free software: you can redistribute it and/or modify
6433 it under the terms of the GNU General Public License as published by
6434 the Free Software Foundation, either version 3 of the License, or
6435 (at your option) any later version.
6437 GNU Emacs is distributed in the hope that it will be useful,
6438 but WITHOUT ANY WARRANTY; without even the implied warranty of
6439 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6440 GNU General Public License for more details.
6442 You should have received a copy of the GNU General Public License
6443 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.