]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Rename more functions to use window-/window-- prefixes.
[gnu-emacs] / src / ChangeLog
1 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2
3 * window.c (resize_root_window, grow_mini_window)
4 (shrink_mini_window): Rename Qresize_root_window to
5 Qwindow_resize_root_window and Qresize_root_window_vertically to
6 Qwindow_resize_root_window_vertically.
7
8 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9
10 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
11
12 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
13
14 * makefile.w32-in: Redesign dependencies so they reflect more
15 clearly which files are directly included by each source file,
16 and not through other includes.
17
18 2011-06-27 Martin Rudalics <rudalics@gmx.at>
19
20 * buffer.c (Qclone_number): Declare static and DEFSYM it.
21 (sort_overlays, overlay_strings): When an overlay's clone number
22 matches the window's clone number process the overlay even if
23 the overlay's window property doesn't match the current window.
24
25 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
26 (Fwindow_hchild): Rename to Fwindow_left_child.
27 (Fwindow_next): Rename to Fwindow_next_sibling.
28 (Fwindow_prev): Rename to Fwindow_prev_sibling.
29 (resize_window_check): Rename to window_resize_check.
30 (resize_window_apply): Rename to window_resize_apply.
31 (Fresize_window_apply): Rename to Fwindow_resize_apply.
32 (Fdelete_other_windows_internal, resize_frame_windows)
33 (Fsplit_window_internal, Fdelete_window_internal)
34 (grow_mini_window, shrink_mini_window)
35 (Fresize_mini_window_internal): Fix callers accordingly.
36
37 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
38
39 * emacsgtkfixed.h: State that this is only used with Gtk+3.
40 (emacs_fixed_set_min_size): Remove.
41 (emacs_fixed_new): Take frame as argument.
42
43 * emacsgtkfixed.c: State that this is only used with Gtk+3.
44 (_EmacsFixedPrivate): Remove minwidth/height.
45 Add struct frame *f.
46 (emacs_fixed_init): Initialize priv->f.
47 (get_parent_class, emacs_fixed_set_min_size): Remove.
48 (emacs_fixed_new): Set priv->f to argument.
49 (emacs_fixed_get_preferred_width)
50 (emacs_fixed_get_preferred_height): Use min_width/height from
51 frames size_hint to set minimum and natural (Bug#8919).
52 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
53 and use min_width/height from frames size_hint to set
54 min_width/height (Bug#8919).
55
56 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
57 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
58 indentation.
59
60 2011-06-26 Eli Zaretskii <eliz@gnu.org>
61
62 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
63 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
64 called at ZV.
65
66 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
67
68 * process.c (wait_reading_process_output): Bypass select if
69 waiting for a cell while ignoring keyboard input, and input is
70 pending. Suggested by Jan Djärv (Bug#8869).
71
72 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
73
74 Use gnulib's dup2 module instead of rolling our own.
75 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
76
77 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
78
79 * dispnew.c (scrolling_window): Before scrolling, turn off a
80 mouse-highlight in the window being scrolled.
81
82 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
83
84 Move DEFSYM to lisp.h and use everywhere.
85
86 * character.h (DEFSYM): Move declaration...
87 * lisp.h (DEFSYM): ...here.
88
89 * gnutls.c:
90 * minibuf.c:
91 * w32menu.c:
92 * w32proc.c:
93 * w32select.c: Don't include character.h.
94
95 * alloc.c (syms_of_alloc):
96 * buffer.c (syms_of_buffer):
97 * bytecode.c (syms_of_bytecode):
98 * callint.c (syms_of_callint):
99 * casefiddle.c (syms_of_casefiddle):
100 * casetab.c (init_casetab_once):
101 * category.c (init_category_once, syms_of_category):
102 * ccl.c (syms_of_ccl):
103 * cmds.c (syms_of_cmds):
104 * composite.c (syms_of_composite):
105 * dbusbind.c (syms_of_dbusbind):
106 * dired.c (syms_of_dired):
107 * dispnew.c (syms_of_display):
108 * doc.c (syms_of_doc):
109 * editfns.c (syms_of_editfns):
110 * emacs.c (syms_of_emacs):
111 * eval.c (syms_of_eval):
112 * fileio.c (syms_of_fileio):
113 * fns.c (syms_of_fns):
114 * frame.c (syms_of_frame):
115 * fringe.c (syms_of_fringe):
116 * insdel.c (syms_of_insdel):
117 * keymap.c (syms_of_keymap):
118 * lread.c (init_obarray, syms_of_lread):
119 * macros.c (syms_of_macros):
120 * msdos.c (syms_of_msdos):
121 * print.c (syms_of_print):
122 * process.c (syms_of_process):
123 * search.c (syms_of_search):
124 * sound.c (syms_of_sound):
125 * syntax.c (init_syntax_once, syms_of_syntax):
126 * terminal.c (syms_of_terminal):
127 * textprop.c (syms_of_textprop):
128 * undo.c (syms_of_undo):
129 * w32.c (globals_of_w32):
130 * window.c (syms_of_window):
131 * xdisp.c (syms_of_xdisp):
132 * xfaces.c (syms_of_xfaces):
133 * xfns.c (syms_of_xfns):
134 * xmenu.c (syms_of_xmenu):
135 * xsettings.c (syms_of_xsettings):
136 * xterm.c (syms_of_xterm): Use DEFSYM.
137
138 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
139
140 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
141
142 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
143
144 Integer and buffer overflow fixes (Bug#8873).
145
146 * print.c (printchar, strout): Check for string overflow.
147 (PRINTPREPARE, printchar, strout):
148 Don't set size unless allocation succeeds.
149
150 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
151 for sizes. Check for string overflow more accurately.
152 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
153
154 * macros.c: Integer and buffer overflow fixes.
155 * keyboard.h (struct keyboard.kbd_macro_bufsize):
156 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
157 Use ptrdiff_t, not int, for sizes.
158 Don't increment bufsize until after realloc succeeds.
159 Check for size-calculation overflow.
160 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
161
162 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
163
164 * lread.c: Integer overflow fixes.
165 (read_integer): Radix is now EMACS_INT, not int,
166 to improve quality of diagnostics for out-of-range radices.
167 Calculate buffer size correctly for out-of-range radices.
168 (read1): Check for integer overflow in radices, and in
169 read-circle numbers.
170 (read_escape): Avoid int overflow.
171 (Fload, openp, read_buffer_size, read1)
172 (substitute_object_recurse, read_vector, read_list, map_obarray):
173 Use ptrdiff_t, not int, for sizes.
174 (read1): Use EMACS_INT, not int, for sizes.
175 Check for size overflow.
176
177 * image.c (cache_image): Check for size arithmetic overflow.
178
179 * lread.c: Integer overflow issues.
180 (saved_doc_string_size, saved_doc_string_length)
181 (prev_saved_doc_string_size, prev_saved_doc_string_length):
182 Now ptrdiff_t, not int.
183 (read1): Don't assume doc string length fits in int. Check for
184 out-of-range doc string lengths.
185 (read_list): Don't assume file position fits in int.
186 (read_escape): Check for hex character overflow.
187
188 2011-06-22 Leo Liu <sdl.web@gmail.com>
189
190 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
191 Move to minibuffer.el.
192
193 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
194
195 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
196 The following patches are for when GLYPH_DEBUG && !XASSERT.
197 * dispextern.h (trace_redisplay_p, dump_glyph_string):
198 * dispnew.c (flush_stdout):
199 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
200 Mark as externally visible.
201 * dispnew.c (check_window_matrix_pointers): Now static.
202 * dispnew.c (window_to_frame_vpos):
203 * xfns.c (unwind_create_frame):
204 * xterm.c (x_check_font): Remove unused local.
205 * scroll.c (CHECK_BOUNDS):
206 * xfaces.c (cache_fache): Rename local to avoid shadowing.
207 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
208 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
209 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
210 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
211 Now static.
212 (debug_method_add): Use va_list and vsprintf rather than relying
213 on undefined behavior with wrong number of arguments.
214 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
215 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
216 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
217 since we're not interested in debugging glyphs with old libraries.
218 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
219 GCC 4.6.0's static checking.
220
221 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
222
223 Integer overflow and signedness fixes (Bug#8873).
224 A few related buffer overrun fixes, too.
225
226 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
227
228 * dispextern.h (struct face.stipple):
229 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
230 (x_bitmap_mask, x_allocate_bitmap_record)
231 (x_create_bitmap_from_data, x_create_bitmap_from_file)
232 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
233 (x_create_bitmap_from_xpm_data):
234 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
235 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
236 (.bitmaps_last):
237 * xfaces.c (load_pixmap):
238 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
239 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
240 (.bitmaps_last, struct x_output.icon_bitmap):
241 Use ptrdiff_t, not int, for bitmap indexes.
242 (x_allocate_bitmap_record): Check for size overflow.
243 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
244
245 Use ptrdiff_t, not int, for overlay counts.
246 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
247 * editfns.c (overlays_around, get_pos_property):
248 * textprop.c (get_char_property_and_overlay):
249 * xdisp.c (next_overlay_change, note_mouse_highlight):
250 * xfaces.c (face_at_buffer_position):
251 * buffer.c (OVERLAY_COUNT_MAX): New macro.
252 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
253 (Fnext_overlay_change, Fprevious_overlay_change)
254 (mouse_face_overlay_overlaps, Foverlays_in):
255 Use ptrdiff_t, not int, for sizes.
256 (overlays_at, overlays_in): Check for size-calculation overflow.
257
258 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
259
260 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
261 (x_session_initialize): Do not assume string length fits in int.
262
263 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
264 This is unlikely, but can occur if DPI is outlandish.
265
266 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
267 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
268
269 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
270 * xrdb.c (magic_file_p, search_magic_path):
271 Omit last arg SUFFIX; it was always 0. All callers changed.
272 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
273
274 * xfont.c (xfont_match): Avoid need for strlen.
275
276 * xfns.c: Don't assume strlen fits in int.
277 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
278
279 * xdisp.c (message_log_check_duplicate): Return intmax_t,
280 not unsigned long, as we prefer signed integers. All callers changed.
281 Detect integer overflow in repeat count.
282 (message_dolog): Don't assume print length fits in 39 bytes.
283 (display_mode_element): Don't assume strlen fits in int.
284
285 * termcap.c: Don't assume sizes fit in int and never overflow.
286 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
287 (gobble_line): Check for size-calculation overflow.
288
289 * minibuf.c (Fread_buffer):
290 * lread.c (intern, intern_c_string):
291 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
292 Don't assume string length fits in int.
293
294 * keyboard.c (parse_tool_bar_item):
295 * gtkutil.c (style_changed_cb): Avoid need for strlen.
296
297 * font.c: Don't assume string length fits in int.
298 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
299 Use ptrdiff_t, not int.
300 (font_intern_prop): Don't assume string length fits in int.
301 Don't assume integer property fits in fixnum.
302 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
303
304 * filelock.c: Fix some buffer overrun and integer overflow issues.
305 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
306 Reformulate so as not to need the command string.
307 Invoke gzip -cd rather than gunzip, as it's more portable.
308 (lock_info_type, lock_file_1, lock_file):
309 Don't assume pid_t and time_t fit in unsigned long.
310 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
311 (current_lock_owner): Prefer signed type for sizes.
312 Use memcpy, not strncpy, where memcpy is what is really wanted.
313 Don't assume (via atoi) that time_t and pid_t fit in int.
314 Check for time_t and/or pid_t out of range, e.g., via a network share.
315 Don't alloca where an auto var works fine.
316
317 * fileio.c: Fix some integer overflow issues.
318 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
319 Don't assume string length fits in int.
320 (directory_file_name): Don't assume string length fits in long.
321 (make_temp_name): Don't assume pid fits in int, or that its print
322 length is less than 20.
323
324 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
325
326 * coding.c (make_subsidiaries): Don't assume string length fits in int.
327
328 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
329
330 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
331 We prefer signed integers, even for size calculations.
332
333 * emacs.c: Don't assume string length fits in 'int'.
334 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
335 (main): Don't invoke strlen when not needed.
336
337 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
338 (XD_DEBUG_MESSAGE): Don't waste a byte.
339
340 * callproc.c (getenv_internal_1, getenv_internal)
341 (Fgetenv_internal):
342 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
343
344 * lread.c (invalid_syntax): Omit length argument.
345 All uses changed. This doesn't fix a bug, but it simplifies the
346 code away from its former Hollerith-constant appearance, and it's
347 one less 'int' to worry about when looking at integer-overflow issues.
348 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
349
350 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
351 This didn't break anything, but it didn't help either.
352 It's confusing to put a bogus integer in a place where the actual
353 value does not matter.
354 (LIST_END_P): Remove unused macro and its bogus comment.
355 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
356
357 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
358 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
359 implementation.
360 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
361 We prefer signed types, and the value cannot exceed the EMACS_INT
362 range anyway (because otherwise the length would not be representable).
363 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
364 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
365 This avoids a GCC warning when WIDE_EMACS_INT.
366
367 * indent.c (sane_tab_width): New function.
368 (current_column, scan_for_column, Findent_to, position_indentation)
369 (compute_motion): Use it. This is just for clarity.
370 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
371
372 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
373
374 * lisp.h (lint_assume): New macro.
375 * composite.c (composition_gstring_put_cache):
376 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
377
378 * editfns.c, insdel.c:
379 Omit unnecessary forward decls, to simplify future changes.
380
381 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
382
383 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
384
385 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
386 Use much-faster test for byte-length change.
387 Don't assume string byte-length fits in 'int'.
388 Check that character arg fits in 'int'.
389 (mapcar1): Declare byte as byte, for clarity.
390
391 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
392
393 * fns.c (concat): Catch string overflow earlier.
394 Do not rely on integer wraparound.
395
396 * dispextern.h (struct it.overlay_strings_charpos)
397 (struct it.selective): Now EMACS_INT, not int.
398 * xdisp.c (forward_to_next_line_start)
399 (back_to_previous_visible_line_start)
400 (reseat_at_next_visible_line_start, next_element_from_buffer):
401 Don't arbitrarily truncate the value of 'selective' to int.
402
403 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
404
405 * composite.c: Don't truncate sizes to 'int'.
406 (composition_gstring_p, composition_reseat_it)
407 (composition_adjust_point): Use EMACS_INT, not int.
408 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
409 not EMACS_UINT, for indexes.
410
411 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
412
413 * buffer.c: Include <verify.h>.
414 (struct sortvec.priority, struct sortstr.priority):
415 Now EMACS_INT, not int.
416 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
417 (struct sortstr.size, record_overlay_string)
418 (struct sortstrlist.size, struct sortlist.used):
419 Don't truncate size to int.
420 (record_overlay_string): Check for size-calculation overflow.
421 (init_buffer_once): Check at compile-time, not run-time.
422
423 2011-06-22 Jim Meyering <meyering@redhat.com>
424
425 Don't leak an XBM-image-sized buffer
426 * image.c (xbm_load): Free the image buffer after using it.
427
428 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
429
430 Port to Sun C.
431 * composite.c (find_automatic_composition): Omit needless 'return 0;'
432 that Sun C diagnosed.
433 * fns.c (secure_hash): Fix pointer signedness issue.
434 * intervals.c (static_offset_intervals): New function.
435 (offset_intervals): Use it.
436
437 2011-06-21 Leo Liu <sdl.web@gmail.com>
438
439 * deps.mk (fns.o):
440 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
441 sha512.h.
442
443 * fns.c (secure_hash): Rename from crypto_hash_function and change
444 the first arg to accept symbols.
445 (Fsecure_hash): New primitive.
446 (syms_of_fns): New symbols.
447
448 2011-06-20 Deniz Dogan <deniz@dogan.se>
449
450 * process.c (Fset_process_buffer): Clarify return value in
451 docstring.
452
453 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
454
455 * dispnew.c (add_window_display_history): Use BVAR.
456
457 * xdisp.c (debug_method_add): Use BVAR.
458 (check_window_end, dump_glyph_matrix, dump_glyph)
459 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
460
461 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
462 Likewise.
463
464 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
465 check till after the cache is created in init_frame_faces.
466
467 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
468
469 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
470
471 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
472
473 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
474 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
475 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
476
477 Improve buffer-overflow checking (Bug#8873).
478 * fileio.c (Finsert_file_contents):
479 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
480 Remove the old (too-loose) buffer overflow checks.
481 They weren't needed, since make_gap checks for buffer overflow.
482 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
483 The old code merely checked for Emacs fixnum overflow, and relied
484 on undefined (wraparound) behavior. The new code avoids undefined
485 behavior, and also checks for ptrdiff_t and/or size_t overflow.
486
487 * editfns.c (Finsert_char): Don't dump core with very negative counts.
488 Tune. Don't use wider integers than needed. Don't use alloca.
489 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
490
491 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
492
493 * insdel.c, lisp.h (buffer_overflow): New function.
494 (insert_from_buffer_1, replace_range, replace_range_2):
495 * insdel.c (make_gap_larger):
496 * editfns.c (Finsert_char):
497 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
498
499 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
500
501 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
502
503 Integer overflow and signedness fixes (Bug#8873).
504
505 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
506 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
507
508 * fileio.c: Don't assume EMACS_INT fits in off_t.
509 (emacs_lseek): New static function.
510 (Finsert_file_contents, Fwrite_region): Use it.
511 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
512
513 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
514
515 * fns.c: Don't overflow int when computing a list length.
516 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
517 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
518 truncation on 64-bit hosts. Check for QUIT every
519 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
520 faster and is responsive enough.
521 (Flength): Report an error instead of overflowing an integer.
522 (Fsafe_length): Return a float if the value is not representable
523 as a fixnum. This shouldn't happen except in contrived situations.
524 (Fnthcdr, Fsort): Don't assume list length fits in int.
525 (Fcopy_sequence): Don't assume vector length fits in int.
526
527 * alloc.c: Check that resized vectors' lengths fit in fixnums.
528 (header_size, word_size): New constants.
529 (allocate_vectorlike): Don't check size overflow here.
530 (allocate_vector): Check it here instead, since this is the only
531 caller of allocate_vectorlike that could cause overflow.
532 Check that the new vector's length is representable as a fixnum.
533
534 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
535 The previous code was bogus. For example, next_almost_prime (32)
536 returned 39, which is undesirable as it is a multiple of 3; and
537 next_almost_prime (24) returned 25, which is a multiple of 5 so
538 why was the code bothering to check for multiples of 7?
539
540 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
541
542 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
543
544 Variadic C functions now count arguments with ptrdiff_t.
545 This partly undoes my 2011-03-30 change, which replaced int with size_t.
546 Back then I didn't know that the Emacs coding style prefers signed int.
547 Also, in the meantime I found a few more instances where arguments
548 were being counted with int, which may truncate counts on 64-bit
549 machines, or EMACS_INT, which may be unnecessarily wide.
550 * lisp.h (struct Lisp_Subr.function.aMANY)
551 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
552 Arg counts are now ptrdiff_t, not size_t.
553 All variadic functions and their callers changed accordingly.
554 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
555 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
556 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
557 * callint.c (Fcall_interactively): Check arg count for overflow,
558 to avoid potential buffer overrun. Use signed char, not 'int',
559 for 'varies' array, so that we needn't bother to check its size
560 calculation for overflow.
561 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
562 * eval.c (apply_lambda):
563 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
564 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
565 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
566
567 * callint.c (Fcall_interactively): Don't use index var as event count.
568
569 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
570 * mem-limits.h (SIZE): Remove; no longer used.
571
572 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
573
574 Remove unnecessary casts.
575 * xterm.c (x_term_init):
576 * xfns.c (x_set_border_pixel):
577 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
578 These aren't needed now that we assume ANSI C.
579
580 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
581 It's more likely to cause problems (due to unsigned overflow)
582 than to cure them.
583
584 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
585
586 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
587
588 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
589
590 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
591
592 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
593
594 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
595
596 GLYPH_CODE_FACE returns EMACS_INT, not int.
597 * dispextern.h (merge_faces):
598 * xfaces.c (merge_faces):
599 * xdisp.c (get_next_display_element, next_element_from_display_vector):
600 Don't assume EMACS_INT fits in int.
601
602 * character.h (CHAR_VALID_P): Remove unused parameter.
603 * fontset.c, lisp.h, xdisp.c: All uses changed.
604
605 * editfns.c (Ftranslate_region_internal): Omit redundant test.
606
607 * fns.c (concat): Minor tuning based on overflow analysis.
608 This doesn't fix any bugs. Use int to hold character, instead
609 of constantly refetching from Emacs object. Use XFASTINT, not
610 XINT, for value known to be a character. Don't bother comparing
611 a single byte to 0400, as it's always less.
612
613 * floatfns.c (Fexpt):
614 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
615
616 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
617 for characters.
618
619 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
620
621 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
622 Without this fix, on a 64-bit host (aset S 0 4294967386) would
623 incorrectly succeed when S was a string, because 4294967386 was
624 truncated before it was used.
625
626 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
627 Otherwise, an out-of-range integer could cause undefined behavior
628 on a 64-bit host.
629
630 * composite.c: Use int, not EMACS_INT, for characters.
631 (fill_gstring_body, composition_compute_stop_pos): Use int, not
632 EMACS_INT, for values that are known to be in character range.
633 This doesn't fix any bugs but is the usual style inside Emacs and
634 may generate better code on 32-bit machines.
635
636 Make sure a 64-bit char is never passed to ENCODE_CHAR.
637 This is for reasons similar to the recent CHAR_STRING fix.
638 * charset.c (Fencode_char): Check that character arg is actually
639 a character. Pass an int to ENCODE_CHAR.
640 * charset.h (ENCODE_CHAR): Verify that the character argument is no
641 wider than 'int', as a compile-time check to prevent future regressions
642 in this area.
643
644 * character.c (char_string): Remove unnecessary casts.
645
646 Make sure a 64-bit char is never passed to CHAR_STRING.
647 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
648 by silently ignoring the top 32 bits, allowing some values
649 that were far too large to be valid characters.
650 * character.h: Include <verify.h>.
651 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
652 arguments are no wider than unsigned, as a compile-time check
653 to prevent future regressions in this area.
654 * data.c (Faset):
655 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
656 (Fsubst_char_in_region):
657 * fns.c (concat):
658 * xdisp.c (decode_mode_spec_coding):
659 Adjust to CHAR_STRING's new requirement.
660 * editfns.c (Finsert_char, Fsubst_char_in_region):
661 * fns.c (concat): Check that character args are actually
662 characters. Without this test, these functions did the wrong
663 thing with wildly out-of-range values on 64-bit hosts.
664
665 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
666 These casts should not be needed on 32-bit hosts, either.
667 * keyboard.c (read_char):
668 * lread.c (Fload): Remove casts to unsigned.
669
670 * lisp.h (UNSIGNED_CMP): New macro.
671 This fixes comparison bugs on 64-bit hosts.
672 (ASCII_CHAR_P): Use it.
673 * casefiddle.c (casify_object):
674 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
675 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
676 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
677 * dispextern.h (FACE_FROM_ID):
678 * keyboard.c (read_char): Use UNSIGNED_CMP.
679
680 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
681 not to EMACS_INT, to avoid GCC warning.
682
683 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
684
685 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
686 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
687 isn't needed on 32-bit machines.
688
689 * buffer.c (Fgenerate_new_buffer_name):
690 Use EMACS_INT for count, not int.
691 (advance_to_char_boundary): Return EMACS_INT, not int.
692
693 * data.c (Qcompiled_function): Now static.
694
695 * window.c (window_body_lines): Now static.
696
697 * image.c (gif_load): Rename local to avoid shadowing.
698
699 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
700 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
701 * alloc.c (make_save_value): Integer argument is now of type
702 ptrdiff_t, not int.
703 (mark_object): Use ptrdiff_t, not int.
704 * lisp.h (pD): New macro.
705 * print.c (print_object): Use it.
706
707 * alloc.c: Use EMACS_INT, not int, to count objects.
708 (total_conses, total_markers, total_symbols, total_vector_size)
709 (total_free_conses, total_free_markers, total_free_symbols)
710 (total_free_floats, total_floats, total_free_intervals)
711 (total_intervals, total_strings, total_free_strings):
712 Now EMACS_INT, not int. All uses changed.
713 (Fgarbage_collect): Compute overall total using a double, so that
714 integer overflow is less likely to be a problem. Check for overflow
715 when converting back to an integer.
716 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
717 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
718 These were 'int' variables that could overflow on 64-bit hosts;
719 they were never used, so remove them instead of repairing them.
720 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
721 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
722 Previously, this ceilinged at INT_MAX, but that doesn't work on
723 64-bit machines.
724 (allocate_pseudovector): Don't use EMACS_INT when int would do.
725
726 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
727 (allocate_vectorlike): Check for ptrdiff_t overflow.
728 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
729 when a (possibly-narrower) signed value would do just as well.
730 We prefer using signed arithmetic, to avoid comparison confusion.
731
732 * alloc.c: Catch some string size overflows that we were missing.
733 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
734 for convenience in STRING_BYTES_MAX.
735 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
736 The definition here is exact; the one in lisp.h was approximate.
737 (allocate_string_data): Check for string overflow. This catches
738 some instances we weren't catching before. Also, it catches
739 size_t overflow on (unusual) hosts where SIZE_MAX <= min
740 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
741 and ptrdiff_t and EMACS_INT are both 64 bits.
742
743 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
744 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
745 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
746
747 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
748
749 * alloc.c (Fmake_string): Check for out-of-range init.
750
751 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
752
753 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
754
755 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
756
757 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
758 xg_get_default_scrollbar_width.
759
760 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
761 (int_gtk_range_get_value): Move to the scroll bar part of the file.
762 (style_changed_cb): Call update_theme_scrollbar_width and call
763 x_set_scroll_bar_default_width and xg_frame_set_char_size for
764 all frames (Bug#8505).
765 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
766 Call gtk_window_set_resizable if HAVE_GTK3.
767 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
768 and height if HAVE_GTK3 (Bug#8505).
769 (scroll_bar_width_for_theme): New variable.
770 (update_theme_scrollbar_width): New function.
771 (xg_get_default_scrollbar_width): Move code to
772 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
773 (xg_initialize): Call update_theme_scrollbar_width.
774
775 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
776
777 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
778
779 2011-06-12 Martin Rudalics <rudalics@gmx.at>
780
781 * frame.c (make_frame): Call other_buffer_safely instead of
782 other_buffer.
783
784 * window.c (temp_output_buffer_show): Call display_buffer with
785 second argument Vtemp_buffer_show_specifiers and reset latter
786 immediately after the call.
787 (Vtemp_buffer_show_specifiers): New variable.
788 (auto_window_vscroll_p, next_screen_context_lines)
789 (Vscroll_preserve_screen_position): Remove leading asterisks from
790 doc-strings.
791
792 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
793
794 Fix minor problems found by GCC 4.6.0 static checking.
795 * buffer.c (Qclone_number): Remove for now, as it's unused.
796 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
797 (record_buffer): Remove unused local.
798 * frame.c (other_visible_frames, frame_buffer_list): Now static.
799 (set_frame_buffer_list): Remove; unused.
800 * frame.h (other_visible_frames): Remove decl.
801 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
802 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
803 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
804 if HAVE_GPM.
805 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
806 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
807 Define only if HAVE_GPM.
808 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
809 (update_hints_inhibit): Remove; never set. All uses removed.
810 * widgetprv.h (emacsFrameClassRec): Remove decl.
811 * window.c (delete_deletable_window): Now returns void, since it
812 wasn't returning anything.
813 (compare_window_configurations): Remove unused locals.
814 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
815 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
816 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
817 the same widths as pointers. This follows up on the 2011-05-06 patch.
818 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
819 * xterm.h: Likewise.
820 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
821
822 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
823
824 * makefile.w32-in: Update dependencies.
825 (LISP_H): Add lib/intprops.h.
826
827 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
828
829 * image.c (gif_load): Add animation frame delay to the metadata.
830 (syms_of_image): Use DEFSYM. New symbol `delay'.
831
832 2011-06-11 Martin Rudalics <rudalics@gmx.at>
833
834 * window.c (delete_deletable_window): Re-add.
835 (Fset_window_configuration): Rewrite to handle dead buffers and
836 consequently deletable windows.
837 (window_tree, Fwindow_tree): Remove. Supply functionality in
838 window.el.
839 (compare_window_configurations): Simplify code.
840
841 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
842
843 * image.c (imagemagick_load_image): Fix type mismatch.
844 (Fimagemagick_types): Likewise.
845
846 * window.h (replace_buffer_in_windows): Declare.
847
848 2011-06-11 Martin Rudalics <rudalics@gmx.at>
849
850 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
851 Qclone_number. Remove external declaration of Qdelete_window.
852 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
853 code.
854 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
855 Qbuffer_list_update_hook if allowed.
856 (Fother_buffer): Rewrite doc-string. Major rewrite for new
857 buffer list implementation.
858 (other_buffer_safely): New function.
859 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
860 calls to replace_buffer_in_windows and
861 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
862 if allowed.
863 (record_buffer): Inhibit quitting and rewrite using quittable
864 functions. Run Qbuffer_list_update_hook if allowed.
865 (Frecord_buffer, Funrecord_buffer): New functions.
866 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
867 switch-to-buffer to window.el.
868 (bury-buffer): Move to window.el.
869 (Vbuffer_list_update_hook): New variable.
870
871 * lisp.h (other_buffer_safely): Add prototype in buffer.c
872 section.
873
874 * window.h (resize_frame_windows): Move up in code.
875 (Fwindow_frame): Remove EXFUN.
876 (replace_buffer_in_all_windows): Remove prototype.
877 (replace_buffer_in_windows_safely): Add prototype.
878
879 * window.c: Declare Qdelete_window static again. Move down
880 declaration of select_count.
881 (Fnext_window, Fprevious_window): Rewrite doc-strings.
882 (Fother_window): Move to window.el.
883 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
884 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
885 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
886 window.el.
887 (replace_buffer_in_windows): Implement by calling
888 Qreplace_buffer_in_windows.
889 (replace_buffer_in_all_windows): Remove with some functionality
890 moved into replace_buffer_in_windows_safely.
891 (replace_buffer_in_windows_safely): New function.
892 (select_window_norecord, select_frame_norecord): Move in front
893 of run_window_configuration_change_hook. Remove now obsolete
894 declarations.
895 (Fset_window_buffer): Rewrite doc-string. Call
896 Qrecord_window_buffer.
897 (keys_of_window): Move binding for other-window to window.el.
898
899 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
900
901 * dispextern.h (struct image): Replace data member, whose int_val
902 and ptr_val fields were not used by anything, with a single
903 lisp_val object.
904
905 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
906 (gif_clear_image, gif_load, imagemagick_load_image)
907 (gs_clear_image, gs_load): Callers changed.
908
909 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
910
911 * buffer.h: Include <time.h>, for time_t.
912 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
913
914 Fix minor problems found by static checking.
915
916 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
917
918 Make identifiers static if they are not used in other modules.
919 * data.c (Qcompiled_function, Qframe, Qvector):
920 * image.c (QimageMagick, Qsvg):
921 * minibuf.c (Qmetadata):
922 * window.c (resize_window_check, resize_root_window): Now static.
923 * window.h (resize_window_check, resize_root_window): Remove decls.
924
925 * window.c (window_deletion_count, delete_deletable_window):
926 Remove; unused.
927 (window_body_lines): Now static.
928 (Fdelete_other_windows_internal): Mark vars as initialized.
929 Make sure 'resize_failed' is initialized.
930 (run_window_configuration_change_hook): Rename local to avoid shadowing.
931 (resize_window_apply): Remove unused local.
932 * window.h (delete_deletable_window): Remove decl.
933
934 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
935 (imagemagick_load_image): Fix pointer signedness problem by changing
936 last arg from unsigned char * to char *. All uses changed.
937 Also, fix a local for similar reasons.
938 Remove unused locals. Remove locals to avoid shadowing.
939 (fn_rsvg_handle_free): Remove; unused.
940 (svg_load, svg_load_image): Fix pointer signedness problem.
941 (imagemagick_load_image): Don't use garbage pointer image_wand.
942
943 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
944
945 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
946
947 * image.c (gif_load): Fix omitted cast error introduced by
948 2011-06-06 change.
949
950 2011-06-10 Martin Rudalics <rudalics@gmx.at>
951
952 * window.h (resize_proportionally, orig_total_lines)
953 (orig_top_line): Remove from window structure.
954 (set_window_height, set_window_width, change_window_heights)
955 (Fdelete_window): Remove prototypes.
956 (resize_frame_windows): Remove duplicate declaration.
957
958 2011-06-10 Eli Zaretskii <eliz@gnu.org>
959
960 * window.h (resize_frame_windows, resize_window_check)
961 (delete_deletable_window, resize_root_window)
962 (resize_frame_windows): Declare prototypes.
963
964 * window.c (resize_window_apply): Make definition be "static" to
965 match the prototype.
966
967 2011-06-10 Martin Rudalics <rudalics@gmx.at>
968
969 * window.c: Remove declarations of Qwindow_size_fixed,
970 window_min_size_1, window_min_size_2, window_min_size,
971 size_window, window_fixed_size_p, enlarge_window, delete_window.
972 Remove static from declaration of Qdelete_window, it's
973 temporarily needed by Fbury_buffer.
974 (replace_window): Don't assign orig_top_line and
975 orig_total_lines.
976 (Fdelete_window, delete_window): Remove. Window deletion is
977 handled by window.el.
978 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
979 Fdelete_window calls with calls to Qdelete_window.
980 (Fdelete_other_windows): Remove. Deleting other windows is
981 handled by window.el.
982 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
983 handled in window.el.
984 (window_min_size_2, window_min_size_1, window_min_size): Remove.
985 Window minimum sizes are handled in window.el.
986 (shrink_windows, size_window, set_window_height)
987 (set_window_width, change_window_heights, window_height)
988 (window_width, CURBEG, CURSIZE, enlarge_window)
989 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
990 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
991 handled in window.el.
992 (make_dummy_parent): Rename to make_parent_window and give it a
993 second argument horflag.
994 (make_window): Don't set resize_proportionally any more.
995 (Fsplit_window): Remove. Windows are split in window.el.
996 (save_restore_action, save_restore_orig_size)
997 (shrink_window_lowest_first, save_restore_orig_size): Remove.
998 Resize mini windows in window.el.
999 (grow_mini_window, shrink_mini_window): Implement by calling
1000 Qresize_root_window_vertically, resize_window_check and
1001 resize_window_apply.
1002 (saved_window, Fset_window_configuration, save_window_save): Do
1003 not handle orig_top_line, orig_total_lines, and
1004 resize_proportionally.
1005 (window_min_height, window_min_width): Move to window.el.
1006 (keys_of_window): Move bindings for delete-other-windows,
1007 split-window, delete-window and enlarge-window to window.el.
1008
1009 * buffer.c: Temporarily extern Qdelete_window.
1010 (Fbury_buffer): Temporarily call Qdelete_window instead of
1011 Fdelete_window (Fbury_buffer will move to window.el soon).
1012
1013 * frame.c (set_menu_bar_lines_1): Remove code handling
1014 orig_top_line and orig_total_lines.
1015
1016 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1017 set_window_height but set heights directly.
1018 (change_frame_size_1): Use resize_frame_windows.
1019
1020 * xdisp.c (init_xdisp): Don't use set_window_height but set
1021 heights directly.
1022
1023 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1024 resize_frame_windows instead of change_window_heights and run
1025 run_window_configuration_change_hook.
1026
1027 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1028 instead of change_window_heights and run
1029 run_window_configuration_change_hook.
1030
1031 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1032
1033 * window.c (replace_window): Rename second argument REPLACEMENT to
1034 NEW. New third argument SETFLAG. Rewrite.
1035 (delete_window, make_dummy_parent): Call replace_window with
1036 third argument 1.
1037 (window_list_1): Move down in code.
1038 (run_window_configuration_change_hook): Move set_buffer part
1039 before select_frame_norecord part in order to unwind correctly.
1040 Rename count1 to count.
1041 (recombine_windows, delete_deletable_window, resize_root_window)
1042 (Fdelete_other_windows_internal)
1043 (Frun_window_configuration_change_hook, make_parent_window)
1044 (resize_window_check, resize_window_apply, Fresize_window_apply)
1045 (resize_frame_windows, Fsplit_window_internal)
1046 (Fdelete_window_internal, Fresize_mini_window_internal): New
1047 functions.
1048 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1049
1050 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1051
1052 * window.h (window): Add some new members to window structure -
1053 normal_lines, normal_cols, new_total, new_normal, clone_number,
1054 splits, nest, prev_buffers, next_buffers.
1055 (WINDOW_TOTAL_SIZE): Move here from window.c.
1056 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1057
1058 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1059 Remove.
1060 (make_dummy_parent): Set new members of windows structure.
1061 (make_window): Move down in code. Handle new members of window
1062 structure.
1063 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1064 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1065 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1066 (Fset_window_prev_buffers, Fwindow_next_buffers)
1067 (Fset_window_next_buffers, Fset_window_clone_number): New
1068 functions.
1069 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1070 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1071 Doc-string fixes.
1072 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1073 Argument WINDOW can be now internal window too.
1074 (Fwindow_use_time): Move up in code.
1075 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1076 Rewrite doc-string.
1077 (Fset_window_configuration, saved_window)
1078 (Fcurrent_window_configuration, save_window_save): Handle new
1079 members of window structure.
1080 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1081 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1082 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1083 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1084 Qget_mru_window, Qresize_root_window,
1085 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1086 Qauto_buffer_name; staticpro them.
1087
1088 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1089
1090 * window.c (Fwindow_total_size, Fwindow_left_column)
1091 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1092 (Fwindow_list_1): New functions.
1093 (window_box_text_cols): Replace with window_body_cols.
1094 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1095 window_body_cols instead of window_box_text_cols.
1096 (delete_window, Fset_window_configuration): Call
1097 delete_all_subwindows with window as argument.
1098 (delete_all_subwindows): Take a window as argument and not a
1099 structure. Rewrite.
1100 (window_loop): Remove handling of GET_LRU_WINDOW and
1101 GET_LARGEST_WINDOW.
1102 (Fget_lru_window, Fget_largest_window): Move to window.el.
1103
1104 * window.h: Extern window_body_cols instead of
1105 window_box_text_cols. delete_all_subwindows now takes a
1106 Lisp_Object as argument.
1107
1108 * indent.c (compute_motion, Fcompute_motion): Use
1109 window_body_cols instead of window_box_text_cols.
1110
1111 * frame.c (delete_frame): Call delete_all_subwindows with root
1112 window as argument.
1113
1114 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1115
1116 * fns.c (Fputhash): Document return value.
1117
1118 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1119
1120 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1121
1122 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 Cons<->int and similar integer overflow fixes (Bug#8794).
1125
1126 Check for overflow when converting integer to cons and back.
1127 * charset.c (Fdefine_charset_internal, Fdecode_char):
1128 Use cons_to_unsigned to catch overflow.
1129 (Fencode_char): Use INTEGER_TO_CONS.
1130 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1131 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1132 * data.c (long_to_cons, cons_to_long): Remove.
1133 (cons_to_unsigned, cons_to_signed): New functions.
1134 These signal an error for invalid or out-of-range values.
1135 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1136 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1137 * font.c (Ffont_variation_glyphs):
1138 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1139 * lisp.h: Include <intprops.h>.
1140 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1141 (cons_to_signed, cons_to_unsigned): New decls.
1142 (long_to_cons, cons_to_long): Remove decls.
1143 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1144 (Fprimitive_undo): Use CONS_TO_INTEGER.
1145 * xfns.c (Fx_window_property): Likewise.
1146 * xselect.c: Include <limits.h>.
1147 (x_own_selection, selection_data_to_lisp_data):
1148 Use INTEGER_TO_CONS.
1149 (x_handle_selection_request, x_handle_selection_clear)
1150 (x_get_foreign_selection, Fx_disown_selection_internal)
1151 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1152 (lisp_data_to_selection_data): Use cons_to_unsigned.
1153 (x_fill_property_data): Use cons_to_signed.
1154 Report values out of range.
1155
1156 Check for buffer and string overflow more precisely.
1157 * buffer.h (BUF_BYTES_MAX): New macro.
1158 * lisp.h (STRING_BYTES_MAX): New macro.
1159 * alloc.c (Fmake_string):
1160 * character.c (string_escape_byte8):
1161 * coding.c (coding_alloc_by_realloc):
1162 * doprnt.c (doprnt):
1163 * editfns.c (Fformat):
1164 * eval.c (verror):
1165 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1166 since they may not be the same number.
1167 * editfns.c (Finsert_char):
1168 * fileio.c (Finsert_file_contents):
1169 Likewise for BUF_BYTES_MAX.
1170
1171 * image.c: Use ptrdiff_t, not int, for sizes.
1172 (slurp_file): Switch from int to ptrdiff_t.
1173 All uses changed.
1174 (slurp_file): Check that file size fits in both size_t (for
1175 malloc) and ptrdiff_t (for sanity and safety).
1176
1177 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1178 if b->modtime has its maximal value.
1179
1180 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1181
1182 Don't assume time_t can fit into int.
1183 * buffer.h (struct buffer.modtime): Now time_t, not int.
1184 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1185 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1186
1187 Minor fixes for signed vs unsigned integers.
1188 * character.h (MAYBE_UNIFY_CHAR):
1189 * charset.c (maybe_unify_char):
1190 * keyboard.c (read_char, reorder_modifiers):
1191 XINT -> XFASTINT, since the integer must be nonnegative.
1192 * ftfont.c (ftfont_spec_pattern):
1193 * keymap.c (access_keymap, silly_event_symbol_error):
1194 XUINT -> XFASTINT, since the integer must be nonnegative.
1195 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1196 since it makes no difference and we prefer signed.
1197 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1198 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1199 nonnegative.
1200
1201 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1202
1203 * window.h (Fwindow_frame): Declare.
1204
1205 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1208 (SPARE_MEMORY): Always define.
1209 (LARGE_REQUEST): Remove.
1210 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1211
1212 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1213
1214 * lisp.h: Move EXFUNS for Fframe_root_window,
1215 Fframe_first_window and Fset_frame_selected_window to window.h.
1216
1217 * window.h: Move EXFUNS for Fframe_root_window,
1218 Fframe_first_window and Fset_frame_selected_window here from
1219 lisp.h.
1220
1221 * frame.c (Fwindow_frame, Fframe_first_window)
1222 (Fframe_root_window, Fframe_selected_window)
1223 (Fset_frame_selected_window): Move to window.c.
1224 (Factive_minibuffer_window): Move to minibuf.c.
1225 (Fother_visible_frames_p): New function.
1226
1227 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1228
1229 * window.c (decode_window, decode_any_window): Move up in code.
1230 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1231 (inhibit_frame_unsplittable): Remove unused variable.
1232 (Fwindow_buffer): Move up and rewrite doc-string.
1233 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1234 (Fwindow_prev): New functions.
1235 (Fwindow_frame): Move here from frame.c. Accept any window as
1236 argument.
1237 (Fframe_root_window, Fframe_first_window)
1238 (Fframe_selected_window): Move here from frame.c. Accept frame
1239 or arbitrary window as argument. Update doc-strings.
1240 (Fminibuffer_window): Move up in code.
1241 (Fwindow_minibuffer_p): Move up in code and simplify.
1242 (Fset_frame_selected_window): Move here from frame.c.
1243 Marginal rewrite.
1244 (Fselected_window, select_window, Fselect_window): Move up in
1245 code. Minor doc-string fixes.
1246
1247 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1250 Do not assume that spare memory exists; that assumption is valid
1251 only if SYSTEM_MALLOC.
1252 (LARGE_REQUEST): New macro, so that the issue of large requests
1253 is separated from the issue of spare memory.
1254
1255 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1256
1257 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1258 format. (Bug#8806)
1259
1260 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1261
1262 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1263 before statements.
1264
1265 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1266
1267 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1268
1269 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1270
1271 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1272 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1273
1274 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1275
1276 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1277
1278 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1279
1280 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1281 (x_clipboard_manager_save): Add return value.
1282 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1283 New error handlers.
1284 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1285 Obey Vx_select_enable_clipboard_manager. Catch errors in
1286 x_clipboard_manager_save (Bug#8779).
1287 (Vx_select_enable_clipboard_manager): New variable.
1288 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1289
1290 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1291
1292 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1293
1294 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1295
1296 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1297 in the current matrix if keep_current_p is non-zero.
1298
1299 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1300
1301 * bidi.c (bidi_level_of_next_char): Fix last change.
1302
1303 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1304
1305 Support bidi reordering of text covered by display properties.
1306
1307 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1308 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1309 (bidi_cache_search, bidi_cache_iterator_state)
1310 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1311 (bidi_level_of_next_char, bidi_move_to_visually_next):
1312 Support character positions inside a run of characters covered by a
1313 display string.
1314 (bidi_paragraph_init, bidi_resolve_explicit_1)
1315 (bidi_level_of_next_char): Call bidi_fetch_char and
1316 bidi_fetch_char_advance instead of FETCH_CHAR and
1317 FETCH_CHAR_ADVANCE.
1318 (bidi_init_it): Initialize new members.
1319 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1320 definitions.
1321 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1322 instead of using explicit *_CHAR codes.
1323 (bidi_resolve_explicit, bidi_resolve_weak):
1324 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1325 bidirectional text is supported only in multibyte buffers.
1326 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1327 it to initialize the frame_window_p member of struct bidi_it.
1328 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1329 (bidi_resolve_explicit, bidi_resolve_weak)
1330 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1331 bidi_it->nchars is non-positive.
1332 (bidi_level_of_next_char): Don't try to lookup the cache for the
1333 next/previous character if nothing is cached there yet, or if we
1334 were just reseat()'ed to a new position.
1335
1336 * xdisp.c (set_cursor_from_row): Set start and stop points
1337 according to the row's direction when priming the loop that looks
1338 for the glyph on which to display cursor.
1339 (single_display_spec_intangible_p): Function deleted.
1340 (display_prop_intangible_p): Reimplement to call
1341 handle_display_spec instead of single_display_spec_intangible_p.
1342 Accept 3 additional arguments needed by handle_display_spec.
1343 This fixes incorrect cursor motion across display property with complex
1344 values: lists, `(when COND...)' forms, etc.
1345 (single_display_spec_string_p): Support property values that are
1346 lists with the argument STRING its top-level element.
1347 (display_prop_string_p): Fix the condition for processing a
1348 property that is a list to be consistent with handle_display_spec.
1349 (handle_display_spec): New function, refactored from the
1350 last portion of handle_display_prop.
1351 (compute_display_string_pos): Accept additional argument
1352 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1353 value of a `display' property is a "replacing spec".
1354 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1355 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1356 the display property, but just return a value indicating whether
1357 the display property will replace the characters it covers.
1358 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1359 frame_window_p members of struct bidi_it.
1360 (compute_display_string_pos, compute_display_string_end):
1361 New functions.
1362 (push_it): Accept second argument POSITION, where pop_it should
1363 jump to continue iteration.
1364 (reseat_1): Initialize bidi_it.disp_pos.
1365
1366 * keyboard.c (adjust_point_for_property): Adjust the call to
1367 display_prop_intangible_p to its new signature.
1368
1369 * dispextern.h (struct bidi_it): New member frame_window_p.
1370 (bidi_init_it): Update prototypes.
1371 (display_prop_intangible_p): Update prototype.
1372 (compute_display_string_pos, compute_display_string_end):
1373 Declare prototypes.
1374 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1375 EMACS_INT.
1376
1377 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1378
1379 Malloc failure behavior now depends on size of allocation.
1380 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1381 * lisp.h: Change signatures accordingly.
1382 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1383 All callers changed. (Bug#8762)
1384
1385 * gnutls.c: Use Emacs's memory allocators.
1386 Without this change, the gnutls library would invoke malloc etc.
1387 directly, which causes problems on non-SYNC_INPUT hosts, and which
1388 runs afoul of improving memory_full behavior. (Bug#8761)
1389 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1390 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1391 xfree instead of the default malloc, realloc, free.
1392 (Fgnutls_boot): No need to check for memory allocation failure,
1393 since xmalloc does that for us.
1394
1395 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1396 * category.c (hash_get_category_set):
1397 * ccl.c (ccl_driver):
1398 * charset.c (Fdefine_charset_internal):
1399 * charset.h (struct charset.hash_index):
1400 * composite.c (get_composition_id, gstring_lookup_cache)
1401 (composition_gstring_put_cache):
1402 * composite.h (struct composition.hash_index):
1403 * dispextern.h (struct image.hash):
1404 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1405 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1406 (hashfn_equal, hashfn_user_defined, make_hash_table)
1407 (maybe_resize_hash_table, hash_lookup, hash_put)
1408 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1409 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1410 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1411 * image.c (make_image, search_image_cache, lookup_image)
1412 (xpm_put_color_table_h):
1413 * lisp.h (struct Lisp_Hash_Table):
1414 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1415 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1416 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1417 * alloc.c (allocate_vectorlike):
1418 Check for overflow in vector size calculations.
1419 * ccl.c (ccl_driver):
1420 Check for overflow when converting EMACS_INT to int.
1421 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1422 need to be updated by these changes.
1423 * fns.c (make_hash_table, maybe_resize_hash_table):
1424 Check for integer overflow with large hash tables.
1425 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1426 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1427 (SXHASH_REDUCE): New macro.
1428 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1429 Use it instead of discarding useful hash info with large hash values.
1430 (sxhash_float): New function.
1431 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1432 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1433 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1434 Rewrite to use FIXNUM_BITS, as this simplifies things.
1435 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1436 Adjust signatures to match updated version of code.
1437 (consing_since_gc): Now EMACS_INT, since a single hash table can
1438 use more than INT_MAX bytes.
1439
1440 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1441
1442 Make it possible to build with GCC-4.6+ -O2 -flto.
1443
1444 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1445
1446 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1447
1448 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1449 Call minibuffer-inactive-mode.
1450
1451 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1452
1453 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1454 Update dependencies.
1455
1456 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1457
1458 * data.c (init_data): Remove code for UTS, this system is not
1459 supported anymore.
1460
1461 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1462
1463 Don't force ./temacs to start in terminal mode.
1464
1465 * frame.c (make_initial_frame): Initialize faces in all cases, not
1466 only when CANNOT_DUMP is defined.
1467 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1468
1469 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1470
1471 * dispnew.c (add_window_display_history): Use const for the string
1472 pointer. Remove declaration, not needed.
1473
1474 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 Use 'inline', not 'INLINE'.
1477 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1478 * alloc.c, fontset.c (INLINE): Remove.
1479 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1480 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1481 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1482 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1483 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1484
1485 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1486
1487 Make it possible to run ./temacs.
1488
1489 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1490 syms_of_callproc does the same thing. Remove test for
1491 "initialized", do it in the caller.
1492 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1493
1494 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1495
1496 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1497 (read_minibuf): Use get_minibuffer.
1498 (syms_of_minibuf): Use DEFSYM.
1499 (Qmetadata): New var.
1500 * data.c (Qbuffer): Don't make it static.
1501 (syms_of_data): Use DEFSYM.
1502
1503 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1506 (CCL_CODE_MIN): New macro.
1507
1508 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1509
1510 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1511
1512 * eval.c (Qdebug): Now static.
1513 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1514 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1515 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1516
1517 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1518
1519 * image.c: Various fixes to ImageMagick code comments.
1520 (Fimagemagick_types): Doc fix.
1521
1522 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 Minor fixes prompted by GCC 4.6.0 warnings.
1525
1526 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1527
1528 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1529 (x_clipboard_manager_save_all): Move extern decl to ...
1530 * xterm.h: ... here, so that it can be checked for consistency.
1531
1532 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1533
1534 * xselect.c (x_clipboard_manager_save_frame)
1535 (x_clipboard_manager_save_all): New functions.
1536 (Fx_clipboard_manager_save): Lisp function deleted.
1537
1538 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1539 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1540
1541 * xterm.h: Update prototype.
1542
1543 2011-05-28 William Xu <william.xwl@gmail.com>
1544
1545 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1546 exiting (Bug#8239).
1547
1548 2011-05-28 Jim Meyering <meyering@redhat.com>
1549
1550 Avoid a sign-extension bug in crypto_hash_function.
1551 * fns.c (to_uchar): Define.
1552 (crypto_hash_function): Use it to convert some newly-signed
1553 variables to unsigned, to avoid sign-extension bugs. For example,
1554 without this change, (md5 "truc") would evaluate to
1555 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1556 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1557 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1558
1559 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 Integer overflow fixes.
1562
1563 * dbusbind.c: Serial number integer overflow fixes.
1564 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1565 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1566 to hold a serial number that is too large for a fixnum.
1567 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1568 Check for serial numbers out of range. Decode any serial number
1569 that was so large that it became a float. (Bug#8722)
1570
1571 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1572 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1573 Use XFASTINT rather than XUINT when numbers are nonnegative.
1574 (xd_append_arg, Fdbus_method_return_internal):
1575 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1576 arguments, check that Lisp number is nonnegative, rather than
1577 silently wrapping negative numbers around. (Bug#8722)
1578 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1579 (Bug#8722)
1580
1581 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1582
1583 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1584
1585 ccl: add integer overflow checks
1586 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1587 (IN_INT_RANGE): New macros.
1588 (ccl_driver): Use them to check for integer overflow when
1589 decoding a CCL program. Many of the new checks are whether XINT (x)
1590 fits in int; it doesn't always, on 64-bit hosts. The new version
1591 doesn't catch all possible integer overflows, but it's an
1592 improvement. (Bug#8719)
1593
1594 * alloc.c (make_event_array): Use XINT, not XUINT.
1595 There's no need for unsigned here.
1596
1597 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1598 This follows up to the 2011-05-06 change that substituted uintptr_t
1599 for EMACS_INT. This case wasn't caught back then.
1600
1601 Rework Fformat to avoid integer overflow issues.
1602 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1603 now (part of C89). Include <verify.h>.
1604 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1605 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1606 (Fformat): Avoid the prepass trying to compute sizes; it was only
1607 approximate and thus did not catch overflow reliably. Instead, walk
1608 through the format just once, formatting and computing sizes as we go,
1609 checking for integer overflow at every step, and allocating a larger
1610 buffer as needed. Keep track separately whether the format is
1611 multibyte. Keep only the most-recently calculated precision, rather
1612 than them all. Record whether each argument has been converted to
1613 string. Use EMACS_INT, not int, for byte and char and arg counts.
1614 Support field widths and precisions larger than INT_MAX. Avoid
1615 sprintf's undefined behavior with conversion specifications such as %#d
1616 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1617 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1618 formatting out-of-range floating point numbers with int
1619 formats. (Bug#8668)
1620
1621 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1622
1623 * data.c: Avoid integer truncation in expressions involving floats.
1624 * data.c: Include <intprops.h>.
1625 (arith_driver): When there's an integer overflow in an expression
1626 involving floating point, convert the integers to floating point
1627 so that the resulting value does not suffer from catastrophic
1628 integer truncation. For example, on a 64-bit host (* 4
1629 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1630 Do not rely on undefined behavior after integer overflow.
1631
1632 merge count_size_as_multibyte, parse_str_to_multibyte
1633 * character.c, character.h (count_size_as_multibyte):
1634 Rename from parse_str_to_multibyte; all uses changed.
1635 Check for integer overflow.
1636 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1637 since it's now a duplicate of the other. This is more of
1638 a character than a buffer op, so better that it's in character.c.
1639 * fns.c, print.c: Adjust to above changes.
1640
1641 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1642
1643 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1644
1645 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1646
1647 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1648 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1649 (x_clipboard_manager_save): Now static.
1650 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1651
1652 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1653 (crypto_hash_function): Now static.
1654 Fix pointer signedness problems. Avoid unnecessary initializations.
1655
1656 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1657
1658 * termhooks.h (Vselection_alist): Make it terminal-local.
1659
1660 * terminal.c (create_terminal): Initialize it.
1661
1662 * xselect.c: Support for clipboard managers.
1663 (Vselection_alist): Move to termhooks.h as terminal-local var.
1664 (LOCAL_SELECTION): New macro.
1665 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1666 (symbol_to_x_atom): Remove gratuitous arg.
1667 (x_handle_selection_request, lisp_data_to_selection_data)
1668 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1669 (x_own_selection, x_get_local_selection, x_convert_selection):
1670 New arg, specifying work frame. Use terminal-local Vselection_alist.
1671 (some_frame_on_display): Delete unused function.
1672 (Fx_own_selection_internal, Fx_get_selection_internal)
1673 (Fx_disown_selection_internal, Fx_selection_owner_p)
1674 (Fx_selection_exists_p): New optional frame arg.
1675 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1676 (x_handle_selection_clear): Don't treat other terminals with the
1677 same keyboard specially. Use the terminal-local Vselection_alist.
1678 (x_clear_frame_selections): Use Frun_hook_with_args.
1679
1680 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1681
1682 * xterm.h: Add support for those atoms.
1683
1684 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1685
1686 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1687 (converted_selections, conversion_fail_tag): New global variables.
1688 (x_selection_request_lisp_error): Free the above.
1689 (x_get_local_selection): Remove unnecessary code.
1690 (x_reply_selection_request): Args changed; handle arbitrary array
1691 of converted selections stored in converted_selections.
1692 Separate the XChangeProperty and SelectionNotify steps.
1693 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1694 (x_convert_selection): New function.
1695 (x_handle_selection_event): Simplify.
1696 (x_get_foreign_selection): Don't ignore incoming requests while
1697 waiting for an answer; this will fail when we implement
1698 SAVE_TARGETS, and seems unnecessary anyway.
1699 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1700 (Vx_sent_selection_functions): Doc fix.
1701
1702 2011-05-26 Leo Liu <sdl.web@gmail.com>
1703
1704 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1705
1706 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1707
1708 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1709
1710 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1711 for fringe update if it has periodic bitmap.
1712 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1713 and fringe_bitmap_periodic_p.
1714
1715 * fringe.c (get_fringe_bitmap_data): New function.
1716 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1717 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1718 row. Mark glyph row for fringe update if periodicity changed.
1719
1720 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1721 for fringe update unless it has periodic bitmap.
1722
1723 2011-05-25 Kenichi Handa <handa@m17n.org>
1724
1725 * xdisp.c (get_next_display_element): Set correct it->face_id for
1726 a static composition.
1727
1728 2011-05-24 Leo Liu <sdl.web@gmail.com>
1729
1730 * deps.mk (fns.o):
1731 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1732
1733 * fns.c (crypto_hash_function, Fsha1): New function.
1734 (Fmd5): Use crypto_hash_function.
1735 (syms_of_fns): Add Ssha1.
1736
1737 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1738
1739 * gnutls.c: Remove unused macros.
1740 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1741 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1742 Remove macros that are defined and never used.
1743 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1744
1745 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1746
1747 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1748 (Fx_get_selection_internal): Minor cleanup.
1749 (Fx_own_selection_internal): Rename arguments for consistency with
1750 select.el.
1751
1752 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1755
1756 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1757
1758 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1759
1760 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1761
1762 * dispnew.c (scrolling_window): Don't exclude the case that the
1763 last enabled row in the desired matrix touches the bottom boundary.
1764
1765 2011-05-21 Glenn Morris <rgm@gnu.org>
1766
1767 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1768 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1769 and add some more files.
1770
1771 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1772
1773 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1774 report_file_error introduced by the change from 2011-05-07.
1775
1776 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 * systime.h (Time): Define only if emacs is defined.
1779 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1780 where the include path doesn't have X11/X.h by default. See
1781 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1782
1783 2011-05-20 Kenichi Handa <handa@m17n.org>
1784
1785 * composite.c (find_automatic_composition): Fix previous change.
1786
1787 2011-05-20 Glenn Morris <rgm@gnu.org>
1788
1789 * lisp.mk: New file, split from Makefile.in.
1790 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1791 (shortlisp): Remove.
1792 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1793
1794 2011-05-19 Glenn Morris <rgm@gnu.org>
1795
1796 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1797 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1798 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1799 (lisp): Set the order to that of loadup.el.
1800 (shortlisp): Make it a copy of $lisp.
1801 (SOME_MACHINE_LISP): Remove.
1802 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1803 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1804
1805 2011-05-18 Kenichi Handa <handa@m17n.org>
1806
1807 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1808 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1809 (find_automatic_composition): Mostly rewrite for efficiency.
1810
1811 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1812
1813 * makefile.w32-in: Update dependencies.
1814
1815 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1816
1817 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1818 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1819
1820 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1821
1822 Fix some integer overflow issues, such as string length overflow.
1823
1824 * insdel.c (count_size_as_multibyte): Check for string overflow.
1825
1826 * character.c (lisp_string_width): Check for string overflow.
1827 Use EMACS_INT, not int, for string indexes and lengths; in
1828 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1829 the resulting string length overflows an EMACS_INT; instead,
1830 report a string overflow if no precision given. When checking for
1831 precision exhaustion, use a check that cannot possibly have
1832 integer overflow. (Bug#8675)
1833 * character.h (lisp_string_width): Adjust to new signature.
1834
1835 * alloc.c (string_overflow): New function.
1836 (Fmake_string): Use it. This doesn't change behavior, but saves
1837 a few bytes and will simplify future changes.
1838 * character.c (string_escape_byte8): Likewise.
1839 * lisp.h (string_overflow): New decl.
1840
1841 Fixups, following up to the user-interface timestamp change.
1842 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1843 for UI timestamps, instead of unsigned long.
1844 * msdos.c (mouse_get_pos): Likewise.
1845 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1846 * w32gui.h (Time): Define by including "systime.h" rather than by
1847 declaring it ourselves. (Bug#8664)
1848
1849 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1850 * image.c (clear_image_cache): Likewise.
1851
1852 * term.c (term_mouse_position): Don't assume time_t wraparound.
1853
1854 Be more systematic about user-interface timestamps.
1855 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1856 and sometimes 'EMACS_UINT', to represent these timestamps.
1857 This change causes it to use 'Time' uniformly, as that's what X uses.
1858 This makes the code easier to follow, and makes it easier to catch
1859 integer overflow bugs such as Bug#8664.
1860 * frame.c (Fmouse_position, Fmouse_pixel_position):
1861 Use Time, not unsigned long, for user-interface timestamps.
1862 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1863 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1864 * keyboard.h (last_event_timestamp): Likewise.
1865 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1866 * menu.h (xmenu_show): Likewise.
1867 * term.c (term_mouse_position): Likewise.
1868 * termhooks.h (struct input_event.timestamp): Likewise.
1869 (struct terminal.mouse_position_hook): Likewise.
1870 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1871 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1872 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1873 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1874 what it was before.
1875 * menu.h, termhooks.h: Include "systime.h", for Time.
1876
1877 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1878 Don't assume that the difference between two unsigned long values
1879 can fit into an integer. At this point, we know button_down_time
1880 <= event->timestamp, so the difference must be nonnegative, so
1881 there's no need to cast the result if double-click-time is
1882 nonnegative, as it should be; check that it's nonnegative, just in
1883 case. This bug is triggered when events are more than 2**31 ms
1884 apart (about 25 days). (Bug#8664)
1885
1886 * xselect.c (last_event_timestamp): Remove duplicate decl.
1887 (x_own_selection): Remove needless cast to unsigned long.
1888
1889 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1890 that always fit in int. Use a sentinel instead of a counter, to
1891 avoid a temp and to allay GCC's concerns about possible int overflow.
1892 * frame.h (struct frame): Use int for menu_bar_items_used
1893 instead of EMACS_INT, since it always fits in int.
1894
1895 * menu.c (grow_menu_items): Check for int overflow.
1896
1897 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1898
1899 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1900 Before, the code was not consistent. These values cannot exceed
1901 2**31 - 1 so there's no need to make them unsigned.
1902 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1903 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1904 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1905 as modifiers.
1906 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1907
1908 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1909 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1910 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1911 presumably because the widths might not match.
1912
1913 * window.c (size_window): Avoid needless test at loop start.
1914
1915 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1916
1917 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1918
1919 2011-05-12 Drew Adams <drew.adams@oracle.com>
1920
1921 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1922
1923 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1924
1925 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1926 `width' to `bar_area_x' and `bar_area_width', respectively.
1927 (x_scroll_run): Take account of fringe background extension.
1928
1929 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1930 Rename local vars `left' and `width' to `bar_area_x' and
1931 `bar_area_width', respectively.
1932 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1933 background extension.
1934
1935 2011-05-10 Jim Meyering <meyering@redhat.com>
1936
1937 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1938
1939 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1940
1941 * image.c (Finit_image_library): Return t for built-in image types,
1942 like pbm and xbm. (Bug#8640)
1943
1944 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1945
1946 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1947
1948 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1949
1950 * w32console.c (Fset_screen_color): Doc fix.
1951 (Fget_screen_color): New function.
1952 (syms_of_ntterm): Defsubr it.
1953
1954 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1955 unlink the temporary file if Fcall_process didn't create it in the
1956 first place.
1957 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1958 child process will be redirected to a file specified with `:file'.
1959 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1960 cue to call_process_cleanup not to close that handle.
1961
1962 2011-05-07 Ben Key <bkey76@gmail.com>
1963
1964 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1965 one of two shell specific rules, either bootstrap-temacs-CMD or
1966 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1967 to the previous implementation of the bootstrap-temacs rule.
1968 The bootstrap-temacs-CMD rule is similar to the previous
1969 implementation of the bootstrap-temacs rule except that it
1970 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1971 variable.
1972
1973 These changes, along with some changes to nt/configure.bat,
1974 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1975 earlier fix to add support for --cflags and --ldflags options
1976 that include quotes so that it works whether make uses cmd or
1977 sh as the shell.
1978
1979 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1980
1981 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1982 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1983 is a constant.
1984 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1985 a string. Handle both cases.
1986 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1987 (Fdbus_register_method): Use Qinvalid_function.
1988
1989 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1990
1991 * makefile.w32-in: Update dependencies.
1992 (LISP_H): Add inttypes.h and stdin.h.
1993 (PROCESS_H): Add unistd.h.
1994
1995 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1996
1997 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1998 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1999
2000 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2001
2002 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2003
2004 * term.c (vfatal): Remove stray call to va_end.
2005 It's not needed and the C Standard doesn't allow it here anyway.
2006
2007 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2008 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2009
2010 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2011 bytes.
2012
2013 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2014
2015 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2016
2017 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2018
2019 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2020
2021 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2022
2023 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2024 * charset.c (Fdefine_charset_internal): Don't initialize
2025 charset.code_space[15]. The value was garbage, on hosts with
2026 32-bit int (Bug#8600).
2027
2028 * lread.c (read_integer): Be more consistent with string-to-number.
2029 Use string_to_number to do the actual conversion; this avoids
2030 rounding errors and fixes some other screwups. Without this fix,
2031 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2032 (digit_to_number): Move earlier, for benefit of read_integer.
2033 Return -1 if the digit is out of range for the base, -2 if it is
2034 not a digit in any supported base. (Bug#8602)
2035
2036 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2037
2038 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2039 to match comment at start of function. This also removes a
2040 GCC warning about overflow in a 32+64-bit port.
2041
2042 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2043
2044 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2045 Reported by Stefan Monnier in
2046 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2047 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2048 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2049
2050 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2051 (EMACS_UINTPTR): Likewise, with uintptr_t.
2052
2053 * lisp.h: Prefer 64-bit EMACS_INT if available.
2054 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2055 on 32-bit hosts that have 64-bit int, so that they can access
2056 large files.
2057 However, temporarily disable this change unless the temporary
2058 symbol WIDE_EMACS_INT is defined.
2059
2060 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2061
2062 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2063 This removes an assumption that EMACS_INT and long are the same
2064 width as pointers. The assumption is true for Emacs porting targets
2065 now, but we want to make other targets possible.
2066 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2067 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2068 In the rest of the code, change types of integers that hold casted
2069 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2070 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2071 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2072 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2073 No need to cast type when ORing.
2074 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2075 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2076 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2077 assume EMACS_INT is the same width as char *.
2078 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2079 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2080 Remove no-longer-needed casts.
2081 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2082 (xg_tool_bar_help_callback, xg_make_tool_item):
2083 Use EMACS_INTPTR to hold an integer
2084 that will be cast to void *; this can avoid a GCC warning
2085 if EMACS_INT is not the same width as void *.
2086 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2087 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2088 (current_message_1, set_message_1):
2089 Use a local to convert to proper width without a cast.
2090 * xmenu.c (dialog_selection_callback): Likewise.
2091
2092 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2093 Also, don't assume VALBITS / RAND_BITS is less than 5,
2094 and don't rely on undefined behavior when shifting a 1 left into
2095 the sign bit.
2096 * lisp.h (get_random): Change signature to match.
2097
2098 * lread.c (hash_string): Use size_t, not int, for hash computation.
2099 Normally we prefer signed values; but hashing is special, because
2100 it's better to use unsigned division on hash table sizes so that
2101 the remainder is nonnegative. Also, size_t is the natural width
2102 for hashing into memory. The previous code used 'int', which doesn't
2103 retain enough info to hash well into very large tables.
2104 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2105
2106 * dbusbind.c: Don't possibly lose pointer info when converting.
2107 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2108 Use XPNTR rather than XHASH, so that the high-order bits of
2109 the pointer aren't lost when converting through void *.
2110
2111 * eval.c (Fautoload): Don't double-shift a pointer.
2112
2113 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2114
2115 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2116
2117 * gnutls.c (DEF_GNUTLS_FN):
2118 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2119
2120 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2121
2122 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2123 marker. (Bug#8610)
2124
2125 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2126
2127 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2128 New version that can reserve upto 2GB of heap space.
2129
2130 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2131
2132 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2133
2134 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2135
2136 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2137 `gnutls_certificate_set_x509_key_file'.
2138
2139 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2140
2141 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2142 Update dependencies.
2143
2144 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2145
2146 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2147 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2148 Remove unused parameter `fildes'.
2149 * process.c (read_process_output, send_process): Don't pass it.
2150
2151 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2152
2153 Fix previous change: the library cache is defined in w32.c.
2154 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2155 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2156
2157 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2158
2159 Implement dynamic loading of GnuTLS on Windows.
2160
2161 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2162 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2163 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2164 Declare.
2165
2166 * gnutls.c (Qgnutls_dll): Define.
2167 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2168 (gnutls_*): Declare function pointers.
2169 (init_gnutls_functions): New function to initialize function pointers.
2170 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2171 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2172 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2173 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2174 (emacs_gnutls_write, emacs_gnutls_read)
2175 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2176 (Fgnutls_available_p): New function.
2177 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2178 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2179 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2180
2181 * image.c: Include w32.h.
2182 (Vimage_type_cache): Delete.
2183 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2184 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2185 (w32_delayed_load): Move to w32.c.
2186
2187 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2188
2189 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2190 (w32_delayed_load): Move from image.c. When loading a library, record
2191 its filename in the :loaded-from property of the library id.
2192 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2193 Initialize and staticpro them.
2194 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2195
2196 * process.c: Include lisp.h before w32.h, not after.
2197 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2198 instead of gnutls_record_check_pending.
2199
2200 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2201
2202 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2203
2204 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2205 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2206 as passed in.
2207
2208 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2209
2210 * xterm.c (x_set_frame_alpha): Do not set property on anything
2211 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2212
2213 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2214
2215 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2216
2217 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2218
2219 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2220 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2221 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2222 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2223 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2224 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2225 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2226 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2227 (Qgnutls_bootprop_callbacks_verify): Make static.
2228
2229 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2230
2231 * callproc.c: Indentation fixup.
2232
2233 * sysdep.c (wait_for_termination_1): Make static.
2234 (wait_for_termination, interruptible_wait_for_termination):
2235 Move after wait_for_termination_1.
2236
2237 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2238
2239 * sysdep.c (interruptible_wait_for_termination): New function
2240 which is like wait_for_termination, but allows keyboard
2241 interruptions.
2242
2243 * callproc.c (Fcall_process): Add (:file "file") as an option for
2244 the STDOUT buffer.
2245 (Fcall_process_region): Ditto.
2246
2247 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2248
2249 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2250 rather than `XVECTOR (FOO)->size'.
2251
2252 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2253 inttypes.h, as a gnulib replacement is used if it not available in
2254 system headers.
2255
2256 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2257
2258 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2259 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2260 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2261
2262 * coding.c (coding_alloc_by_realloc): Error out if destination
2263 will grow beyond MOST_POSITIVE_FIXNUM.
2264 (decode_coding_emacs_mule): Abort if there isn't enough place in
2265 charbuf for the composition carryover bytes. Reserve an extra
2266 space for up to 2 characters produced in a loop.
2267 (decode_coding_iso_2022): Abort if there isn't enough place in
2268 charbuf for the composition carryover bytes.
2269
2270 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2271
2272 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2273 aborting when %lld or %lll format is passed.
2274 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2275 %llo or %llx format is passed. (Bug#8545)
2276
2277 * window.c (window_scroll_line_based): Use a marker instead of
2278 simple variables to record original value of point. (Bug#7952)
2279
2280 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2281 produced by %s or %c overflows available buffer space. (Bug#8545)
2282
2283 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2284
2285 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2286 (SIZE_MAX): Move defn after all includes, as they might #define it.
2287
2288 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2289
2290 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2291
2292 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2293
2294 * keyboard.c (Qdelayed_warnings_hook): Define.
2295 (command_loop_1): Run `delayed-warnings-hook'
2296 if Vdelayed_warnings_list is non-nil.
2297 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2298 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2299
2300 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2301
2302 * doprnt.c (doprnt): Don't return value smaller than the buffer
2303 size if the message was truncated. (Bug#8545).
2304
2305 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2306
2307 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2308 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2309
2310 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2313
2314 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2315
2316 * makefile.w32-in: Update dependencies.
2317
2318 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2319
2320 Improve `doprnt' and its usage. (Bug#8545)
2321 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2322 `format_end'. Remove support for %l as a conversion specifier.
2323 Don't use xrealloc. Improve diagnostics when the %l size modifier
2324 is used. Update the commentary.
2325
2326 * eval.c (verror): Simplify calculation of size_t.
2327
2328 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2329 messages.
2330
2331 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2332
2333 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2334 change.
2335
2336 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2337
2338 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2339 This makes this file independent of the recent pseudovector change.
2340
2341 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2342
2343 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2344
2345 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2346 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2347 Remove unused local.
2348 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2349
2350 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2351 GCC 4.6.0 optimizes based on type-based alias analysis.
2352 For example, if b is of type struct buffer * and v of type struct
2353 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2354 != &v->size, and therefore "v->size = 1; b->size = 2; return
2355 v->size;" must therefore return 1. This assumption is incorrect
2356 for Emacs, since it type-puns struct Lisp_Vector * with many other
2357 types. To fix this problem, this patch adds a new type struct
2358 vectorlike_header that documents the constraints on layout of vectors
2359 and pseudovectors, and helps optimizing compilers not get fooled
2360 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2361 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2362 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2363 the size member.
2364 (XSETPVECTYPE): Rewrite in terms of new macro.
2365 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2366 This is a bit clearer, and further avoids the possibility of
2367 undesirable aliasing.
2368 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2369 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2370 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2371 since Lisp_Subr is a special case (no "next" field).
2372 (ASIZE): Now uses header.size rather than size.
2373 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2374 to avoid the hassle of writing XVECTOR (foo)->header.size.
2375 (struct vectorlike_header): New type.
2376 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2377 object, to help avoid aliasing.
2378 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2379 (SUBRP): Likewise, since Lisp_Subr is a special case.
2380 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2381 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2382 (struct Lisp_Hash_Table): Combine first two members into a single
2383 struct vectorlike_header member. All uses of "size" and "next" members
2384 changed to be "header.size" and "header.next".
2385 * buffer.h (struct buffer): Likewise.
2386 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2387 * frame.h (struct frame): Likewise.
2388 * process.h (struct Lisp_Process): Likewise.
2389 * termhooks.h (struct terminal): Likewise.
2390 * window.c (struct save_window_data, struct saved_window): Likewise.
2391 * window.h (struct window): Likewise.
2392 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2393 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2394 * buffer.c (init_buffer_once): Likewise.
2395 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2396 special case.
2397 * process.c (Fformat_network_address): Use local var for size,
2398 for brevity.
2399
2400 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2401
2402 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2403 * data.c (atof): Remove decl; no longer used or needed.
2404 (digit_to_number): Move to lread.c.
2405 (Fstring_to_number): Use new string_to_number function, to be
2406 consistent with how the Lisp reader treats infinities and NaNs.
2407 Do not assume that floating-point numbers represent EMACS_INT
2408 without losing information; this is not true on most 64-bit hosts.
2409 Avoid double-rounding errors, by insisting on integers when
2410 parsing non-base-10 numbers, as the documentation specifies.
2411 * lisp.h (string_to_number): New decl, replacing ...
2412 (isfloat_string): Remove.
2413 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2414 (read1): Do not accept +. and -. as integers; this
2415 appears to have been a coding error. Similarly, do not accept
2416 strings like +-1e0 as floating point numbers. Do not report
2417 overflow for integer overflows unless the base is not 10 which
2418 means we have no simple and reliable way to continue.
2419 Break out the floating-point parsing into a new
2420 function string_to_number, so that Fstring_to_number parses
2421 floating point numbers consistently with the Lisp reader.
2422 (digit_to_number): Move here from data.c. Make it static inline.
2423 (E_CHAR, EXP_INT): Remove, replacing with ...
2424 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2425 (string_to_number): New function, replacing isfloat_string.
2426 This function checks for valid syntax and produces the resulting
2427 Lisp float number too. Rework it so that string-to-number
2428 no longer mishandles examples like "1.0e+". Use strtoumax,
2429 so that overflow for non-base-10 numbers is reported only when
2430 there's no portable and simple way to convert to floating point.
2431
2432 * textprop.c (set_text_properties_1): Rewrite for clarity,
2433 and to avoid GCC warning about integer overflow.
2434
2435 * intervals.h (struct interval): Use EMACS_INT for members
2436 where EMACS_UINT might cause problems. See
2437 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2438 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2439 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2440 All uses changed.
2441 (offset_intervals): Tell GCC not to worry about length overflow
2442 when negating a negative length.
2443
2444 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2445 (overrun_check_free): Likewise.
2446
2447 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2448 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2449 word size.
2450
2451 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2452 (gnutls_make_error): Rename local to avoid shadowing.
2453 (gnutls_emacs_global_deinit): ifdef out; not used.
2454 (Fgnutls_boot): Use const for pointer to readonly storage.
2455 Comment out unused local. Fix pointer signedness problems.
2456
2457 * lread.c (openp): Don't stuff size_t into an 'int'.
2458 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2459 about possible signed overflow.
2460
2461 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2462 (GDK_KEY_g): Don't define if already defined.
2463 (xg_prepare_tooltip): Avoid pointer signedness problem.
2464 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2465
2466 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2467 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2468
2469 * xfns.c (Fx_window_property): Simplify a bit,
2470 to make a bit faster and to avoid GCC 4.6.0 warning.
2471 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2472
2473 * fns.c (internal_equal): Don't assume size_t fits in int.
2474
2475 * alloc.c (compact_small_strings): Tighten assertion a little.
2476
2477 Replace pEd with more-general pI, and fix some printf arg casts.
2478 * lisp.h (pI): New macro, generalizing old pEd macro to other
2479 conversion specifiers. For example, use "...%"pI"d..." rather
2480 than "...%"pEd"...".
2481 (pEd): Remove. All uses replaced with similar uses of pI.
2482 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2483 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2484 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2485 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2486 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2487 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2488 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2489 64-bit hosts.
2490 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2491 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2492 * print.c (safe_debug_print, print_object): Likewise.
2493 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2494 to int.
2495 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2496 avoiding the 0 flag, which is not portable.
2497 * process.c (Fmake_network_process): Use pI to avoid cast.
2498 * region-cache.c (pp_cache): Likewise.
2499 * xdisp.c (decode_mode_spec): Likewise.
2500 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2501 behavior on 64-bit hosts with printf arg.
2502 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2503 (x_stop_queuing_selection_requests): Likewise.
2504 (x_get_window_property): Don't truncate byte count to an 'int'
2505 when tracing.
2506
2507 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2508 here, since it parses constructs like leading '-' and spaces,
2509 which are not wanted; and it overflows with large numbers.
2510 Instead, simply match F[0-9]+, which is what is wanted anyway.
2511
2512 * alloc.c: Remove unportable assumptions about struct layout.
2513 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2514 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2515 (allocate_vectorlike, make_pure_vector): Use the new macros,
2516 plus offsetof, to remove unportable assumptions about struct layout.
2517 These assumptions hold on all porting targets that I know of, but
2518 they are not guaranteed, they're easy to remove, and removing them
2519 makes further changes easier.
2520
2521 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2522 This doesn't fix a bug but makes the code clearer.
2523 (string_overrun_cookie): Now const. Use initializers that
2524 don't formally overflow signed char, to avoid warnings.
2525 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2526 can cause Emacs to crash when string overrun checking is enabled.
2527 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2528 multiple of sizeof (EMACS_INT); it need not be, if
2529 alignof(EMACS_INT) < sizeof (EMACS_INT).
2530 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2531
2532 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2533
2534 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2535
2536 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2537
2538 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2539 supposed to be handshaking. (Bug#8556)
2540 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2541
2542 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2543
2544 * lisp.h (Qdebug): List symbol.
2545 * eval.c (Qdebug): Restore global linkage.
2546 * keyboard.c (debug-on-event): New variable.
2547 (handle_user_signal): Break into debugger when debug-on-event
2548 matches the current signal symbol.
2549
2550 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2551
2552 * alloc.c (check_sblock, check_string_bytes)
2553 (check_string_free_list): Convert to standard C.
2554
2555 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2556
2557 * w32.c (emacs_gnutls_push): Fix typo.
2558
2559 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2560
2561 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2562 "cast to pointer from integer of different size".
2563
2564 Improve doprnt and its use in verror. (Bug#8545)
2565 * doprnt.c (doprnt): Document the set of format control sequences
2566 supported by the function. Use SAFE_ALLOCA instead of always
2567 using `alloca'.
2568
2569 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2570 is one byte too soon. Don't use xrealloc; instead xfree and
2571 xmalloc anew.
2572
2573 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2574
2575 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2576 callbacks stage.
2577
2578 * gnutls.c: Renamed global_initialized to
2579 gnutls_global_initialized. Added internals for the
2580 :verify-hostname-error, :verify-error, and :verify-flags
2581 parameters of `gnutls-boot' and documented those parameters in the
2582 docstring. Start callback support.
2583 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2584 unless a fatal error occured. Call gnutls_alert_send_appropriate
2585 on error. Return error code.
2586 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2587 (emacs_gnutls_read): Likewise.
2588 (Fgnutls_boot): Return handshake error code.
2589 (emacs_gnutls_handle_error): New function.
2590 (wsaerror_to_errno): Likewise.
2591
2592 * w32.h (emacs_gnutls_pull): Add prototype.
2593 (emacs_gnutls_push): Likewise.
2594
2595 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2596 (emacs_gnutls_push): Likewise.
2597
2598 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2599
2600 * process.c (wait_reading_process_output): Check if GnuTLS
2601 buffered some data internally if no FDs are set for TLS
2602 connections.
2603
2604 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2605 (LIBS): Link to USER_LIBS.
2606 ($(BLD)/gnutls.$(0)): New target.
2607
2608 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2609
2610 * xdisp.c (handle_single_display_spec): Rename the
2611 display_replaced_before_p argument into display_replaced_p, to
2612 make it consistent with the commentary. Fix typos in the
2613 commentary.
2614
2615 * textprop.c (syms_of_textprop): Remove dead code.
2616 (copy_text_properties): Delete obsolete commentary about an
2617 interface that was deleted long ago. Fix typos in the description
2618 of arguments.
2619
2620 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2621 to changes in oldXMenu/XMenu.h from 2011-04-16.
2622 <menu_help_message, prev_menu_help_message>: Constify.
2623 (IT_menu_make_room): menu->help_text is now `const char **';
2624 adjust.
2625
2626 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2627 to changes in oldXMenu/XMenu.h from 2011-04-16.
2628 (struct XMenu): Declare `help_text' `const char **'.
2629
2630 * xfaces.c <Qunspecified>: Make extern again.
2631
2632 * syntax.c: Include sys/types.h before including regex.h, as
2633 required by Posix.
2634
2635 * doc.c (get_doc_string): Improve the format passed to `error'.
2636
2637 * doprnt.c (doprnt): Improve commentary.
2638
2639 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2640
2641 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2642 them with etags.
2643
2644 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2645 changes in globals.h immediately force recompilation.
2646 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2647 $(CURDIR)/s/ms-w32.h.
2648 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2649
2650 * character.c (Fchar_direction): Function deleted.
2651 (syms_of_character): Don't defsubr it.
2652 <char-direction-table>: Deleted.
2653
2654 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2655
2656 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2657 * doprnt.c: Include limits.h.
2658 (SIZE_MAX): New macro.
2659 (doprnt): Return a size_t value. 2nd arg is now size_t.
2660 Many local variables are now size_t instead of int or unsigned.
2661 Improve overflow protection. Support `l' modifier for integer
2662 conversions. Support %l conversion. Don't assume an EMACS_INT
2663 argument for integer conversions and for %c.
2664
2665 * lisp.h (doprnt): Restore prototype.
2666
2667 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2668 $(SRC)/character.h.
2669
2670 * Makefile.in (base_obj): Add back doprnt.o.
2671
2672 * deps.mk (doprnt.o): Add back prerequisites.
2673 (callint.o): Depend on character.h.
2674
2675 * eval.c (internal_lisp_condition_case): Include the handler
2676 representation in the error message.
2677 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2678 when breaking from the loop.
2679
2680 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2681
2682 * callint.c (Fcall_interactively): When displaying error message
2683 about invalid control letter, pass the character's codepoint, not
2684 a pointer to its multibyte form. Improve display of the character
2685 in octal and display also its hex code.
2686
2687 * character.c (char_string): Use %x to display the (unsigned)
2688 codepoint of an invalid character, to avoid displaying a bogus
2689 negative value.
2690
2691 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2692 `error', not SYMBOL_NAME itself.
2693
2694 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2695 character arguments to `error'.
2696
2697 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2698 to `error' in error message about FINAL_CHAR argument. Make sure
2699 FINAL_CHAR is a character, and use %c when it is passed as
2700 argument to `error'.
2701
2702 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2703
2704 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2705
2706 * w32.c: Include <time.h>.
2707 (sys_localtime): New function.
2708
2709 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2710
2711 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2712
2713 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2714
2715 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2716
2717 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2718 zombies (Bug#8467).
2719
2720 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2721
2722 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2723 gl_state.e_property when gl_state.object is Qt.
2724
2725 * insdel.c (make_gap_larger): Remove limitation of buffer size
2726 to <= INT_MAX.
2727
2728 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2729
2730 * xdisp.c (lookup_glyphless_char_display)
2731 (produce_glyphless_glyph): Handle cons cell entry in
2732 glyphless-char-display.
2733 (Vglyphless_char_display): Document it.
2734
2735 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2736 glyphless-char-display.
2737
2738 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2739
2740 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2741
2742 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2743
2744 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2745 definition for no-X builds.
2746
2747 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2748
2749 Static checks with GCC 4.6.0 and non-default toolkits.
2750
2751 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2752
2753 * process.c (keyboard_bit_set): Define only if SIGIO.
2754 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2755 (send_process): Repair possible setjmp clobbering.
2756
2757 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2758
2759 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2760
2761 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2762
2763 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2764 Define only if needed.
2765
2766 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2767 by pacifying GCC about it. Maybe it's time to retire it?
2768 * xfaces.c (USG, __TIMEVAL__): Likewise.
2769
2770 * dispextern.h (struct redisplay_interface): Rename param
2771 to avoid shadowing.
2772 * termhooks.h (struct terminal): Likewise.
2773 * xterm.c (xembed_send_message): Likewise.
2774
2775 * insdel.c (make_gap_smaller): Define only if
2776 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2777
2778 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2779 it.
2780
2781 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2782 so that we aren't warned about unused symbols.
2783
2784 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2785
2786 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2787
2788 * xfns.c (x_real_positions): Mark locals as initialized.
2789
2790 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2791
2792 * xterm.c: Fix problems found by static analysis with other toolkits.
2793 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2794 (x_dispatch_event): Declare static if USE_GTK, and
2795 define if USE_GTK || USE_X_TOOLKIT.
2796 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2797 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2798 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2799 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2800
2801 * xmenu.c (menu_help_callback): Pointer type fixes.
2802 Use const pointers when pointing at readonly data. Avoid pointer
2803 signedness clashes.
2804 (FALSE): Remove unused macro.
2805 (update_frame_menubar): Remove unused decl.
2806
2807 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2808
2809 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2810 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2811 (single_menu_item): Rename local to avoid shadowing.
2812
2813 * keyboard.c (make_lispy_event): Remove unused local var.
2814
2815 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2816 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2817
2818 * bitmaps: Change bitmaps from unsigned char back to the X11
2819 compatible char. Avoid the old compiler warnings about
2820 out-of-range initializers by using, for example, '\xab' rather
2821 than 0xab.
2822
2823 * xgselect.c (xgselect_initialize): Check vs interface
2824 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2825
2826 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2827
2828 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2829 to read-only memory.
2830
2831 * fns.c (vector): Remove; this old hack is no longer needed.
2832
2833 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2834 Remove unused var.
2835 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2836
2837 * xrdb.c (x_load_resources): Omit unused local.
2838
2839 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2840 (x_window): Rename locals to avoid shadowing.
2841 (USG): Use the kludged USG macro, to pacify gcc.
2842
2843 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2844 (x_term_init): Remove local to avoid shadowing.
2845
2846 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2847
2848 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2849 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2850
2851 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2852
2853 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2854
2855 Fix regex.c, syntax.c and friends for buffers > 2GB.
2856 * syntax.h (struct gl_state_s): Declare character position members
2857 EMACS_INT.
2858
2859 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2860
2861 * textprop.c (verify_interval_modification, interval_of):
2862 Declare arguments EMACS_INT.
2863
2864 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2865 EMACS_INT.
2866
2867 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2868
2869 * indent.c (Fvertical_motion): Local variable it_start is now
2870 EMACS_INT.
2871
2872 * regex.c (re_match, re_match_2, re_match_2_internal)
2873 (bcmp_translate, regcomp, regexec, print_double_string)
2874 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2875 (re_compile_pattern, re_exec): Declare arguments and local
2876 variables `size_t' and `ssize_t' and return values `regoff_t', as
2877 appropriate.
2878 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2879 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2880 <compile_stack_type>: `size' and `avail' are now `size_t'.
2881
2882 * regex.h <regoff_t>: Use ssize_t, not int.
2883 (re_search, re_search_2, re_match, re_match_2): Arguments that
2884 specify buffer/string position and length are now ssize_t and
2885 size_t. Return type is regoff_t.
2886
2887 2011-04-16 Ben Key <bkey76@gmail.com>
2888
2889 * nsfont.m: Fixed bugs in ns_get_family and
2890 ns_descriptor_to_entity that were caused by using free to
2891 deallocate memory blocks that were allocated by xmalloc (via
2892 xstrdup). This caused Emacs to crash when compiled with
2893 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2894 --enable-checking=xmallocoverrun). xfree is now used to
2895 deallocate these memory blocks.
2896
2897 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2900
2901 emacs_write: Accept and return EMACS_INT for sizes.
2902 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2903 et seq.
2904 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2905 Accept and return EMACS_INT.
2906 (emacs_gnutls_write): Return the number of bytes written on
2907 partial writes.
2908 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2909 (emacs_read, emacs_write): Remove check for negative size, as the
2910 Emacs source code has been audited now.
2911 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2912 (emacs_read, emacs_write): Use it.
2913 * process.c (send_process): Adjust to the new signatures of
2914 emacs_write and emacs_gnutls_write. Do not attempt to store
2915 a byte offset into an 'int'; it might overflow.
2916 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2917
2918 * sound.c: Don't assume sizes fit in 'int'.
2919 (struct sound_device.period_size, alsa_period_size):
2920 Return EMACS_INT, not int.
2921 (struct sound_device.write, vox_write, alsa_write):
2922 Accept EMACS_INT, not int.
2923 (wav_play, au_play): Use EMACS_INT to store sizes and to
2924 record read return values.
2925
2926 2011-04-15 Ben Key <bkey76@gmail.com>
2927
2928 * keyboard.c (Qundefined): Don't declare static since it is used
2929 in nsfns.m.
2930 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2931 static since they are used in nsfont.m.
2932
2933 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2934
2935 * process.c (Qprocessp): Don't declare static.
2936 * lisp.h (Qprocessp): Declare again.
2937
2938 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2939
2940 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2941
2942 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 Improve C-level modularity by making more things 'static'.
2945
2946 Don't publish debugger-only interfaces to other modules.
2947 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2948 (verify_bytepos, count_markers): Move decls to the only modules
2949 that need them.
2950 * region-cache.h (pp_cache): Likewise.
2951 * window.h (check_all_windows): Likewise.
2952 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2953
2954 * sysdep.c (croak): Now static, if
2955 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2956 * syssignal.h (croak): Declare only if not static.
2957
2958 * alloc.c (refill_memory_reserve): Now static if
2959 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2960 * lisp.h (refill_memory_reserve): Declare only if not static.
2961
2962 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2963 Define only if USE_LUCID.
2964
2965 * xrdb.c (x_customization_string, x_rm_string): Now static.
2966
2967 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2968 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2969
2970 * xdisp.c (draw_row_with_mouse_face): Now static.
2971 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2972
2973 * window.h (check_all_windows): Mark externally visible.
2974
2975 * window.c (window_deletion_count): Now static.
2976
2977 * undo.c: Make symbols static if they're not exported.
2978 (last_undo_buffer, last_boundary_position, pending_boundary):
2979 Now static.
2980
2981 * textprop.c (interval_insert_behind_hooks): Now static.
2982 (interval_insert_in_front_hooks): Likewise.
2983
2984 * term.c: Make symbols static if they're not exported.
2985 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2986 (max_frame_lines, tty_set_terminal_modes):
2987 (tty_reset_terminal_modes, tty_turn_off_highlight):
2988 (get_tty_terminal): Now static.
2989 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2990 * termhooks.h (term_mouse_moveto): Do not declare if
2991 HAVE_WINDOW_SYSTEM.
2992 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2993 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2994
2995 * sysdep.c: Make symbols static if they're not exported.
2996 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2997 Now static.
2998 (sigprocmask_set, full_mask): Remove; unused.
2999 (wait_debugging): Mark as visible.
3000 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3001 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3002
3003 * syntax.c (syntax_temp): Define only if !__GNUC__.
3004
3005 * sound.c (current_sound_device, current_sound): Now static.
3006
3007 * search.c (searchbufs, searchbuf_head): Now static.
3008
3009 * scroll.c (scroll_cost): Remove; unused.
3010 * dispextern.h (scroll_cost): Remove decl.
3011
3012 * region-cache.h (pp_cache): Mark as externally visible.
3013
3014 * process.c: Make symbols static if they're not exported.
3015 (process_tick, update_tick, create_process, chan_process):
3016 (Vprocess_alist, proc_buffered_char, datagram_access):
3017 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3018 (deactivate_process): Mark defn as static, as well as decl.
3019 * lisp.h (create_process): Remove decl.
3020 * process.h (chan_process, Vprocess_alist): Remove decls.
3021
3022 * print.c: Make symbols static if they're not exported.
3023 (print_depth, new_backquote_output, being_printed, print_buffer):
3024 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3025 (print_interval, print_number_index, initial_stderr_stream):
3026 Now static.
3027 * lisp.h (Fprinc): Remove decl.
3028 (debug_output_compilation_hack): Mark as externally visible.
3029
3030 * sysdep.c (croak): Move decl from here to syssignal.h.
3031 * syssignal.h (croak): Put it here, so the API can be checked when
3032 'croak' is called from dissociate_if_controlling_tty.
3033
3034 * minibuf.c: Make symbols static if they're not exported.
3035 (minibuf_save_list, choose_minibuf_frame): Now static.
3036 * lisp.h (choose_minibuf_frame): Remove decl.
3037
3038 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3039
3040 * lread.c: Make symbols static if they're not exported.
3041 (read_objects, initial_obarray, oblookup_last_bucket_number):
3042 Now static.
3043 (make_symbol): Remove; unused.
3044 * lisp.h (initial_obarray, make_symbol): Remove decls.
3045
3046 * keyboard.c: Make symbols static if they're not exported.
3047 (single_kboard, recent_keys_index, total_keys, recent_keys):
3048 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3049 (this_single_command_key_start, echoing, last_auto_save):
3050 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3051 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3052 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3053 (Vlispy_mouse_stem, double_click_count):
3054 Now static.
3055 (force_auto_save_soon): Define only if SIGDANGER.
3056 (ignore_mouse_drag_p): Now static if
3057 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3058 (print_help): Remove; unused.
3059 (stop_character, last_timer_event): Mark as externally visible.
3060 * keyboard.h (ignore_mouse_drag_p): Declare only if
3061 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3062 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3063 * lisp.h (echoing): Remove decl.
3064 (force_auto_save_soon): Declare only if SIGDANGER.
3065 * xdisp.c (redisplay_window): Simplify code, to make it more
3066 obvious that ignore_mouse_drag_p is not accessed if !defined
3067 USE_GTK && !defined HAVE_NS.
3068
3069 * intervals.c: Make symbols static if they're not exported.
3070 (merge_properties_sticky, merge_interval_right, delete_interval):
3071 Now static.
3072 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3073
3074 * insdel.c: Make symbols static if they're not exported.
3075 However, leave prepare_to_modify_buffer alone. It's never
3076 called from outside this function, but that appears to be a bug.
3077 (combine_after_change_list, combine_after_change_buffer):
3078 (adjust_after_replace, signal_before_change): Now static.
3079 (adjust_after_replace_noundo): Remove; unused.
3080 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3081 (signal_before_change): Remove decls.
3082
3083 * indent.c (val_compute_motion, val_vmotion): Now static.
3084
3085 * image.c: Make symbols static if they're not exported.
3086 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3087 if USE_GTK.
3088 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3089 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3090
3091 * fringe.c (standard_bitmaps): Now static.
3092 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3093
3094 * frame.c: Make symbols static if they're not exported.
3095 (x_report_frame_params, make_terminal_frame): Now static.
3096 (get_frame_param): Now static, unless HAVE_NS.
3097 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3098 (x_get_resource_string): Remove; not used.
3099 * frame.h (make_terminal_frame, x_report_frame_params):
3100 (x_get_resource_string); Remove decls.
3101 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3102 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3103
3104 * font.c, fontset.c: Make symbols static if they're not exported.
3105 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3106 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3107 * font.c (font_close_object): Now static.
3108 * font.h (font_close_object): Remove.
3109 * fontset.c (FONTSET_OBJLIST): Remove.
3110 (free_realized_fontset) #if-0 the body, which does nothing.
3111 (face_suitable_for_char_p): #if-0, as it's never called.
3112 * fontset.h (face_suitable_for_char_p): Remove decl.
3113 * xfaces.c (face_at_string_position):
3114 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3115 since 0 is always ASCII.
3116
3117 * fns.c (weak_hash_tables): Now static.
3118
3119 * fileio.c: Make symbols static if they're not exported.
3120 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3121 (Vwrite_region_annotation_buffers): Now static.
3122
3123 * eval.c: Make symbols static if they're not exported.
3124 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3125 * lisp.h (backtrace_list): Remove decl.
3126
3127 * emacs.c: Make symbols static if they're not exported.
3128 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3129 (fatal_error_code, fatal_error_signal_hook, standard_args):
3130 Now static.
3131 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3132 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3133 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3134 * lisp.h (fatal_error_signal_hook): Remove decl.
3135 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3136
3137 * editfns.c: Move a (normally-unused) function to its only use.
3138 * editfns.c, lisp.h (get_operating_system_release): Remove.
3139 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3140 worth the hassle of breaking this out.
3141
3142 * xterm.c: Make symbols static if they're not exported.
3143 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3144 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3145 (x_destroy_window, x_delete_display):
3146 Now static.
3147 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3148 (x_mouse_leave): Remove; unused.
3149 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3150 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3151 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3152 Remove decls.
3153 (x_mouse_leave): Declare only if WINDOWSNT.
3154 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3155 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3156 USE_X_TOOLKIT.
3157
3158 * ftxfont.c: Make symbols static if they're not exported.
3159 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3160 HAVE_FREETYPE.
3161 * font.h (ftxfont_driver): Likewise.
3162
3163 * xfns.c: Make symbols static if they're not exported.
3164 (x_last_font_name, x_display_info_for_name):
3165 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3166 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3167 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3168 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3169 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3170 (last_show_tip_args): Now static.
3171 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3172 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3173 (x_screen_planes): Remove; unused.
3174 * dispextern.h (x_screen_planes): Remove decl.
3175
3176 * dispnew.c: Make symbols static if they're not exported.
3177 * dispextern.h (redraw_garbaged_frames, scrolling):
3178 (increment_row_positions): Remove.
3179 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3180 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3181 Now static.
3182 (redraw_garbaged_frames): Remove; unused.
3183
3184 * xfaces.c: Make symbols static if they're not exported.
3185 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3186 Remove decls.
3187 * xterm.h (defined_color): Remove decls.
3188 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3189 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3190 (menu_face_changed_default, defined_color, free_realized_face):
3191 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3192 (ascii_face_of_lisp_face): Remove; unused.
3193
3194 * xdisp.c: Make symbols static if they're not exported.
3195 * dispextern.h (scratch_glyph_row, window_box_edges):
3196 (glyph_to_pixel_coords, set_cursor_from_row):
3197 (get_next_display_element, set_iterator_to_next):
3198 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3199 (show_mouse_face): Remove decls
3200 * frame.h (message_buf_print): Likewise.
3201 * lisp.h (pop_message, set_message, check_point_in_composition):
3202 Likewise.
3203 * xterm.h (set_vertical_scroll_bar): Likewise.
3204 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3205 (message_buf_print, scratch_glyph_row, displayed_buffer):
3206 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3207 (get_next_display_element, show_mouse_face, window_box_edges):
3208 (frame_to_window_pixel_xy, check_point_in_composition):
3209 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3210 (glyph_to_pixel_coords): Remove; unused.
3211
3212 * dired.c (file_name_completion): Now static.
3213
3214 * dbusbind.c (xd_in_read_queued_messages): Now static.
3215
3216 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3217 * data.c (circular_list_error): Remove.
3218
3219 * commands.h (last_point_position, last_point_position_buffer):
3220 (last_point_position_window): Remove decls.
3221 * keyboard.c: Make these variables static.
3222
3223 * coding.h (coding, code_convert_region, encode_coding_gap):
3224 Remove decls.
3225 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3226 (iso_code_class, detect_coding, code_convert_region): Now static.
3227 (encode_coding_gap): Remove; unused.
3228
3229 * chartab.c (chartab_chars, chartab_bits): Now static.
3230
3231 * charset.h (charset_iso_8859_1): Remove decl.
3232 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3233 Now static.
3234
3235 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3236 * ccl.c (Vccl_program_table): Now static.
3237 (check_ccl_update): Remove; unused.
3238
3239 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3240 * category.h: ... from here.
3241 * category.c (check_category_table, set_category_set): Now static.
3242
3243 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3244 * lisp.h: Remove these decls.
3245
3246 * buffer.c (buffer_count): Remove unused var.
3247
3248 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3249 so that it's not optimized away.
3250 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3251 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3252 exported only to the debugger.
3253
3254 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3255 * atimer.h (run_all_atimers): Remove; not exported.
3256
3257 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3258 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3259 was inaccessible from Lisp.
3260 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3261 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3262
3263 alloc.c: Import and export fewer symbols, and remove unused items.
3264 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3265 is defined.
3266 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3267 it's not optimized away by whole-program optimization.
3268 (message_enable_multibyte, free_misc): Remove.
3269 (catchlist, handlerlist, mark_backtrace):
3270 Declare only if BYTE_MARK_STACK.
3271 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3272 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3273 (message_enable_multibyte): Remove decl.
3274 (free_misc, interval_free_list, float_block, float_block_index):
3275 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3276 (cons_free_list, last_marked_index):
3277 Now static.
3278 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3279 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3280 (mark_backtrace): Define only if BYTE_MARK_STACK.
3281 * xdisp.c (message_enable_multibyte): Now static.
3282
3283 Declare Lisp_Object Q* variables to be 'static' if not exported.
3284 This makes it easier for human readers (and static analyzers)
3285 to see whether these variables are used from other modules.
3286 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3287 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3288 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3289 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3290 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3291 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3292 * xmenu.c, xselect.c:
3293 Declare Q* vars static if they are not used in other modules.
3294 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3295 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3296 Remove decls of unexported vars.
3297 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3298
3299 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3300
3301 Make Emacs functions such as Fatom 'static' by default.
3302 This makes it easier for human readers (and static analyzers)
3303 to see whether these functions can be called from other modules.
3304 DEFUN now defines a static function. To make the function external
3305 so that it can be used in other C modules, use the new macro DEFUE.
3306 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3307 (Finit_image_library):
3308 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3309 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3310 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3311 Remove decls, since these functions are now static.
3312 (Funintern, Fget_internal_run_time): New decls, since these functions
3313 were already external.
3314
3315 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3316 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3317 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3318 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3319 * keyboard.c, keymap.c, lread.c:
3320 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3321 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3322 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3323 Mark functions with DEFUE instead of DEFUN,
3324 if they are used in other modules.
3325 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3326 decls for now-static functions.
3327 * buffer.h (Fdelete_overlay): Remove decl.
3328 * callproc.c (Fgetenv_internal): Mark as internal.
3329 * composite.c (Fremove_list_of_text_properties): Remove decl.
3330 (Fcomposition_get_gstring): New forward static decl.
3331 * composite.h (Fcomposite_get_gstring): Remove decl.
3332 * dired.c (Ffile_attributes): New forward static decl.
3333 * doc.c (Fdocumntation_property): New forward static decl.
3334 * eval.c (Ffetch_bytecode): New forward static decl.
3335 (Funintern): Remove extern decl; now in .h file where it belongs.
3336 * fileio.c (Fmake_symbolic_link): New forward static decl.
3337 * image.c (Finit_image_library): New forward static decl.
3338 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3339 * intervals.h (Fprevious_property_change):
3340 (Fremove_list_of_text_properties): Remove decls.
3341 * keyboard.c (Fthis_command_keys): Remove decl.
3342 (Fcommand_execute): New forward static decl.
3343 * keymap.c (Flookup_key): New forward static decl.
3344 (Fcopy_keymap): Now static.
3345 * keymap.h (Flookup_key): Remove decl.
3346 * process.c (Fget_process): New forward static decl.
3347 (Fprocess_datagram_address): Mark as internal.
3348 * syntax.c (Fsyntax_table_p): New forward static decl.
3349 (skip_chars): Remove duplicate decl.
3350 * textprop.c (Fprevious_property_change): New forward static decl.
3351 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3352 Now internal.
3353 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3354 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3355
3356 * editfns.c (Fformat): Remove unreachable code.
3357
3358 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3359
3360 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3361 change. (Bug#8496)
3362
3363 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3364
3365 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3366 when at ZV. (Bug#8487)
3367
3368 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3369
3370 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3371 (Bug#8437)
3372 * keyboard.c (parse_tool_bar_item): Likewise.
3373 * sound.c (sound_cleanup, alsa_close): Likewise.
3374 * termcap.c (tgetent): Likewise.
3375 * xfns.c (x_default_font_parameter): Likewise.
3376 * xsettings.c (read_and_apply_settings): Likewise.
3377
3378 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3379 (overrun_check_free): Protoize.
3380
3381 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3382
3383 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3384 since callers should never pass a negative size.
3385 Change the signature to match that of plain 'read' and 'write'; see
3386 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3387 * lisp.h: Update prototypes of emacs_write and emacs_read.
3388
3389 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3390
3391 * xdisp.c (redisplay_window): Don't try to determine the character
3392 position of the scroll margin if the window start point w->startp
3393 is outside the buffer's accessible region. (Bug#8468)
3394
3395 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3396
3397 Fix write-region and its subroutines for buffers > 2GB.
3398 * fileio.c (a_write, e_write): Modify declaration of arguments and
3399 local variables to support buffers larger than 2GB.
3400 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3401
3402 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3403 argument, local variables, and return value.
3404
3405 * lisp.h: Update prototypes of emacs_write and emacs_read.
3406
3407 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3408
3409 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3410
3411 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3412
3413 Fix more problems found by GCC 4.6.0's static checks.
3414
3415 * xdisp.c (vmessage): Use a better test for character truncation.
3416
3417 * charset.c (load_charset_map): <, not <=, for optimization,
3418 and to avoid potential problems with integer overflow.
3419 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3420 * casetab.c (set_identity, shuffle): Likewise.
3421 * editfns.c (Fformat): Likewise.
3422 * syntax.c (skip_chars): Likewise.
3423
3424 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3425 This also lets GCC 4.6.0 generate slightly better loop code.
3426
3427 * callint.c (Fcall_interactively): <, not <=, for optimization.
3428 (Fcall_interactively): Count the number of arguments produced,
3429 not the number of arguments given. This is simpler and lets GCC
3430 4.6.0 generate slightly better code.
3431
3432 * ftfont.c: Distingish more carefully between FcChar8 and char.
3433 The previous code passed unsigned char * to a functions like
3434 strlen and xstrcasecmp that expect char *, which does not
3435 conform to the C standard.
3436 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3437 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3438 char * when the C standard requires it.
3439
3440 * keyboard.c (read_char): Remove unused var.
3441
3442 * eval.c: Port to Windows vsnprintf (Bug#8435).
3443 Include <limits.h>.
3444 (SIZE_MAX): Define if the headers do not.
3445 (verror): Do not give up if vsnprintf returns a negative count.
3446 Instead, grow the buffer. This ports to Windows vsnprintf, which
3447 does not conform to C99. Problem reported by Eli Zaretskii.
3448 Also, simplify the allocation scheme, by avoiding the need for
3449 calling realloc, and removing the ALLOCATED variable.
3450
3451 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3452
3453 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3454 But keep the doprint source code for now, as we might revamp it
3455 and use it again (Bug#8435).
3456 * lisp.h (doprnt): Remove.
3457 * Makefile.in (base_obj): Remove doprnt.o.
3458 * deps.mk (doprnt.o): Remove.
3459
3460 error: Print 32- and 64-bit integers portably (Bug#8435).
3461 Without this change, on typical 64-bit hosts error ("...%d...", N)
3462 was used to print both 32- and 64-bit integers N, which relied on
3463 undefined behavior.
3464 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3465 New macro.
3466 * lisp.h (error, verror): Mark as printf-like functions.
3467 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3468 Report overflow in size calculations when allocating printf buffer.
3469 Do not truncate output string at its first null byte.
3470 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3471 Truncate the output at a character boundary, since vsnprintf does not
3472 do that.
3473 * charset.c (check_iso_charset_parameter): Convert internal
3474 character to string before calling 'error', since %c now has the
3475 printf meaning.
3476 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3477 overflow when computing char to be passed to 'error'. Do not
3478 pass Lisp_Object to 'error'; pass the integer instead.
3479 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3480 formatted with plain %d.
3481
3482 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3483
3484 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3485
3486 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3487
3488 * xterm.c (x_catch_errors): Remove duplicate declaration.
3489
3490 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3491
3492 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3493
3494 2011-04-10 Jim Meyering <meyering@redhat.com>
3495
3496 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3497 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3498 return ssize_t not "int", and use size_t as the buffer length.
3499 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3500 * gnutls.h: Update declarations.
3501 * process.c (read_process_output): Use ssize_t, to match.
3502 (send_process): Likewise.
3503
3504 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3505
3506 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3507
3508 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3509
3510 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3511 Use unsigned char, to match FcChar8 type definition.
3512
3513 * xterm.c (handle_one_xevent):
3514 * xmenu.c (create_and_show_popup_menu):
3515 * xselect.c (x_decline_selection_request)
3516 (x_reply_selection_request): Avoid type-punned deref of X events.
3517
3518 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3519
3520 Fix some uses of `int' instead of EMACS_INT.
3521 * search.c (string_match_1, fast_string_match)
3522 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3523 (scan_buffer, find_next_newline_no_quit)
3524 (find_before_next_newline, search_command, Freplace_match)
3525 (Fmatch_data): Make some `int' variables be EMACS_INT.
3526
3527 * xdisp.c (display_count_lines): 3rd argument and return value now
3528 EMACS_INT. All callers changed.
3529 (pint2hrstr): Last argument is now EMACS_INT.
3530
3531 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3532 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3533 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3534 (decode_coding_utf_16, decode_coding_emacs_mule)
3535 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3536 (decode_coding_ccl, decode_coding_charset)
3537 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3538 (decode_coding_iso_2022, decode_coding_emacs_mule)
3539 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3540 <char_offset, last_offset>: Declare EMACS_INT.
3541 (encode_coding_utf_8, encode_coding_utf_16)
3542 (encode_coding_emacs_mule, encode_invocation_designation)
3543 (encode_designation_at_bol, encode_coding_iso_2022)
3544 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3545 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3546 Declare EMACS_INT.
3547 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3548 (encode_invocation_designation): Last argument P_NCHARS is now
3549 EMACS_INT.
3550 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3551 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3552
3553 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3554 All users changed.
3555
3556 * ccl.c (Fccl_execute_on_string): Declare some variables
3557 EMACS_INT.
3558
3559 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3560
3561 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3562
3563 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3564
3565 * process.c (Fformat_network_address): Doc fix.
3566
3567 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3568
3569 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3570
3571 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3572
3573 * keyboard.c (read_char): Call Lisp function help-form-show,
3574 instead of using internal_with_output_to_temp_buffer.
3575 (Qhelp_form_show): New var.
3576 (syms_of_keyboard): Use DEFSYM macro.
3577
3578 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3579
3580 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3581
3582 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3583
3584 * process.c (Flist_processes): Remove to Lisp.
3585 (list_processes_1): Delete.
3586
3587 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3588
3589 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3590
3591 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3592
3593 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3594
3595 Fix more problems found by GCC 4.6.0's static checks.
3596
3597 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3598
3599 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3600
3601 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3602
3603 * xdisp.c (vmessage): Mark as a printf-like function.
3604
3605 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3606
3607 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3608
3609 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3610 printf-like functions.
3611 (tiff_load): Add casts to remove these marks before passing them
3612 to system-supplied API.
3613
3614 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3615
3616 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3617 This avoids several warnings with gcc -Wstrict-overflow.
3618 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3619 directly, rather than having caller test rule sign. This avoids
3620 some unnecessary tests.
3621 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3622 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3623 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3624
3625 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3626 (xfont_open): Avoid unnecessary tests.
3627
3628 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3629
3630 * composite.h, composite.c (composition_gstring_put_cache):
3631 Use EMACS_INT, not int, for length.
3632
3633 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3634 breaking out part of COMPOSITION_DECODE_RULE.
3635 (COMPOSITION_DECODE_RULE): Use it.
3636 * composite.c (get_composition_id): Remove unused local vars,
3637 by using the new macro.
3638
3639 * textprop.c (set_text_properties_1): Change while to do-while,
3640 since the condition is always true at first.
3641
3642 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3643 (interval_deletion_adjustment): Return unsigned value.
3644 All uses changed.
3645
3646 * process.c (list_processes_1, create_pty, read_process_output):
3647 (exec_sentinel): Remove vars that were set but not used.
3648 (create_pty): Remove unnecessary "volatile"s.
3649 (Fnetwork_interface_info): Avoid possibility of int overflow.
3650 (read_process_output): Do adaptive read buffering even if carryover.
3651 (read_process_output): Simplify nbytes computation if buffered.
3652
3653 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3654
3655 * syntax.c (scan_words): Remove var that was set but not used.
3656 (update_syntax_table): Use unsigned instead of int.
3657
3658 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3659 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3660 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3661
3662 * print.c (print_error_message): Avoid int overflow.
3663
3664 * font.c (font_list_entities): Redo for clarity,
3665 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3666
3667 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3668 (font_score): Avoid potential overflow in diff calculation.
3669
3670 * fns.c (substring_both): Remove var that is set but not used.
3671 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3672
3673 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3674
3675 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3676 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3677 can always succeed if overflow has undefined behavior.
3678
3679 * search.c (boyer_moore, wordify): Remove vars set but not used.
3680 (wordify): Omit three unnecessary tests.
3681
3682 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3683 All callers changed. This avoids the need for an unused var.
3684
3685 * casefiddle.c (casify_region): Remove var that is set but not used.
3686
3687 * dired.c (file_name_completion): Remove var that is set but not used.
3688
3689 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3690
3691 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3692 (Finsert_file_contents): Remove unnecessary code checking fd.
3693
3694 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3695 Check for integer overflow on size calculations.
3696
3697 * buffer.c (Fprevious_overlay_change): Remove var that is set
3698 but not used.
3699
3700 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3701 Remove vars that are set but not used.
3702 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3703 (timer_check_2): Mark vars as initialized.
3704
3705 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3706
3707 * image.c (lookup_image): Remove var that is set but not used.
3708 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3709
3710 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3711 that are set but not used.
3712
3713 * xfns.c (make_invisible_cursor): Don't return garbage
3714 if XCreateBitmapFromData fails (Bug#8410).
3715
3716 * xselect.c (x_get_local_selection, x_handle_property_notify):
3717 Remove vars that are set but not used.
3718
3719 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3720 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3721
3722 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3723 Remove var that is set but not used.
3724 (scroll_bar_windows_size): Now size_t, not int.
3725 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3726 Check for overflow.
3727
3728 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3729 (map_tty_color) [!defined MSDOS]: Likewise.
3730
3731 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3732
3733 * coding.c: Remove vars that are set but not used.
3734 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3735 All callers changed.
3736 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3737 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3738 (decode_coding_charset): Remove vars that are set but not used.
3739
3740 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3741 that is set but not used.
3742
3743 * print.c (print_object): Remove var that is set but not used.
3744
3745 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3746 The gnulib version avoids calling malloc in the usual case,
3747 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3748 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3749 * filelock.c (current_lock_owner): Likewise.
3750 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3751 * sysdep.c: Include allocator.h, careadlinkat.h.
3752 (emacs_no_realloc_allocator): New static constant.
3753 (emacs_readlink): New function.
3754 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3755 ../lib/careadlinkat.h.
3756
3757 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3758
3759 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3760 first non-nil return value).
3761
3762 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3763
3764 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3765 if not defined (Bug#8403).
3766
3767 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3768
3769 * xdisp.c (display_count_lines): Remove parameter `start',
3770 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3771 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3772 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3773 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3774 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3775 and thereabouts. All callers changed.
3776 (get_per_char_metric): Remove parameter `f', unused since
3777 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3778
3779 2011-04-02 Jim Meyering <meyering@redhat.com>
3780
3781 do not dereference NULL upon failed strdup
3782 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3783 (ns_get_family): Likewise.
3784
3785 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3786
3787 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3788
3789 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3790
3791 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3792 later (Bug#8403).
3793
3794 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3795
3796 Add lexical binding.
3797
3798 * window.c (Ftemp_output_buffer_show): New fun.
3799 (Fsave_window_excursion):
3800 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3801
3802 * lread.c (lisp_file_lexically_bound_p): New function.
3803 (Fload): Bind Qlexical_binding.
3804 (readevalloop): Remove `evalfun' arg.
3805 Bind Qinternal_interpreter_environment.
3806 (Feval_buffer): Bind Qlexical_binding.
3807 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3808 Mark as dynamic.
3809 (syms_of_lread): Declare `lexical-binding'.
3810
3811 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3812
3813 * keyboard.c (eval_dyn): New fun.
3814 (menu_item_eval_property): Use it.
3815
3816 * image.c (parse_image_spec): Use Ffunctionp.
3817
3818 * fns.c (concat, mapcar1): Accept byte-code-functions.
3819
3820 * eval.c (Fsetq): Handle lexical vars.
3821 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3822 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3823 (FletX, Flet): Obey lexical binding.
3824 (Fcommandp): Handle closures.
3825 (Feval): New `lexical' arg.
3826 (eval_sub): New function extracted from Feval. Use it almost
3827 everywhere where Feval was used. Look up vars in lexical env.
3828 Handle closures.
3829 (Ffunctionp): Move from subr.el.
3830 (Ffuncall): Handle closures.
3831 (apply_lambda): Remove `eval_flags'.
3832 (funcall_lambda): Handle closures and new byte-code-functions.
3833 (Fspecial_variable_p): New function.
3834 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3835 but without exporting it to Lisp.
3836
3837 * doc.c (Fdocumentation, store_function_docstring):
3838 * data.c (Finteractive_form): Handle closures.
3839
3840 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3841 interactive spec.
3842
3843 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3844 New byte-codes.
3845 (exec_byte_code): New function extracted from Fbyte_code to handle new
3846 calling convention for byte-code-functions. Add new byte-codes.
3847
3848 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3849
3850 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3851
3852 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3853
3854 * xdisp.c (redisplay_internal): Fix prototype.
3855
3856 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3857
3858 * xdisp.c (SCROLL_LIMIT): New macro.
3859 (try_scrolling): Use it when setting scroll_limit.
3860 Limit scrolling to 100 screen lines.
3861 (redisplay_window): Even when falling back on "recentering",
3862 position point in the window according to scroll-conservatively,
3863 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3864
3865 (try_scrolling): When point is above the window, allow searching
3866 as far as scroll_max, or one screenful, to compute vertical
3867 distance from PT to the scroll margin position. This prevents
3868 try_scrolling from unnecessarily failing when
3869 scroll-conservatively is set to a value slightly larger than the
3870 window height. Clean up the case of PT below the margin at bottom
3871 of window: scroll_max can no longer be INT_MAX. When aggressive
3872 scrolling is in use, don't let point enter the opposite scroll
3873 margin as result of the scroll.
3874 (syms_of_xdisp) <scroll-conservatively>: Document the
3875 threshold of 100 lines for never-recentering scrolling.
3876
3877 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3878
3879 * dispextern.h (move_it_by_lines):
3880 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3881 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3882 (message_log_check_duplicate): Remove parameters `prev_bol' and
3883 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3884 (redisplay_internal): Remove parameter `preserve_echo_area',
3885 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3886
3887 * indent.c (Fvertical_motion):
3888 * window.c (window_scroll_pixel_based, Frecenter):
3889 Don't pass `need_y_p' to `move_it_by_lines'.
3890
3891 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3892
3893 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3894 steal a few bits to be more compact.
3895 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3896 Remove unneeded casts.
3897
3898 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3899
3900 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3901
3902 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3903 binding" message (bug#7967).
3904
3905 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3906
3907 Fix more problems found by GCC 4.6.0's static checks.
3908
3909 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3910 Remove unused local var.
3911
3912 * editfns.c (Fmessage_box): Remove unused local var.
3913
3914 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3915 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3916 Omit unused local vars.
3917 * window.c (shrink_windows): Omit unused local var.
3918 * menu.c (digest_single_submenu): Omit unused local var.
3919 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3920 Omit unused local var.
3921
3922 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3923 Don't assume string length fits in int.
3924 (keyremap_step, read_key_sequence): Use size_t for sizes.
3925 (read_key_sequence): Don't check last_real_key_start redundantly.
3926
3927 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3928 instead of alloca (Bug#8344).
3929
3930 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3931 (Fbacktrace_frame): Don't assume nframes fits in int.
3932
3933 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3934
3935 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3936 concerns.
3937
3938 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3939
3940 * cm.c (calccost): Turn while-do into do-while, for clarity.
3941
3942 * keyboard.c (syms_of_keyboard): Use the same style as later
3943 in this function when indexing through an array. This also
3944 works around GCC bug 48267.
3945
3946 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3947
3948 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3949
3950 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3951 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3952
3953 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3954 This avoids undefined behavior on integer overflow, and is a bit
3955 more convenient anyway since it is compared to a size_t variable.
3956
3957 Variadic C functions now count arguments with size_t, not int.
3958 This avoids an unnecessary limitation on 64-bit machines, which
3959 caused (substring ...) to crash on large vectors (Bug#8344).
3960 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3961 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3962 All variadic functions and their callers changed accordingly.
3963 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3964 * data.c (arith_driver, float_arith_driver): Likewise.
3965 * editfns.c (general_insert_function): Likewise.
3966 * eval.c (struct backtrace.nargs, interactive_p)
3967 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3968 (funcall_lambda, mark_backtrace): Likewise.
3969 * fns.c (concat): Likewise.
3970 * frame.c (x_set_frame_parameters): Likewise.
3971 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3972 0 if not found, not -1. All callers changed.
3973
3974 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3975 (stack_copy_size): Now size_t, not int.
3976 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3977
3978 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3979
3980 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3981 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3982 All callers changed.
3983
3984 * lisp.h (multibyte_char_to_unibyte):
3985 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3986 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3987 * character.h (CHAR_TO_BYTE8):
3988 * cmds.c (internal_self_insert):
3989 * editfns.c (general_insert_function):
3990 * keymap.c (push_key_description):
3991 * search.c (Freplace_match):
3992 * xdisp.c (message_dolog, set_message_1): All callers changed.
3993
3994 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3995
3996 * keyboard.c (safe_run_hook_funcall): New function.
3997 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3998 don't set the hook to nil, but remove the offending function instead.
3999 (Qcommand_hook_internal): Remove, unused.
4000 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4001 Vcommand_hook_internal.
4002
4003 * eval.c (enum run_hooks_condition): Remove.
4004 (funcall_nil, funcall_not): New functions.
4005 (run_hook_with_args): Call each function through a `funcall' argument.
4006 Remove `cond' argument, now redundant.
4007 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4008 (Frun_hook_with_args_until_failure): Adjust accordingly.
4009 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4010
4011 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4012
4013 * dispextern.h (string_buffer_position): Remove declaration.
4014
4015 * print.c (strout): Remove parameter `multibyte', unused since
4016 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4017
4018 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4019 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4020 All callers changed.
4021
4022 * w32.c (_wsa_errlist): Use braces for struct initializers.
4023
4024 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4025 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4026 All callers changed.
4027 (string_buffer_position): Likewise. Also, make static (it's never
4028 used outside xdisp.c).
4029 (cursor_row_p): Remove parameter `w', unused since
4030 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4031 (decode_mode_spec): Remove parameter `precision', introduced during
4032 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4033 All callers changed.
4034
4035 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4036
4037 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4038
4039 2011-03-27 Anders Lindgren <andlind@gmail.com>
4040
4041 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4042 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4043 (ns_update_auto_hide_menu_bar): New functions.
4044 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4045 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4046 ns_constrain_all_frames.
4047 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4048 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4049
4050 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4051
4052 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4053
4054 2011-03-27 Glenn Morris <rgm@gnu.org>
4055
4056 * syssignal.h: Replace RETSIGTYPE with void.
4057 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4058 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4059 Replace SIGTYPE with void everywhere.
4060 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4061 * s/template.h (SIGTYPE): Remove commented out definition.
4062
4063 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4064
4065 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4066 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4067
4068 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4069
4070 * w32.c (read_unc_volume): Use parameter `henum', instead of
4071 global variable `wget_enum_handle'.
4072
4073 * keymap.c (describe_vector): Remove parameters `indices' and
4074 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4075 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4076
4077 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4078
4079 * keyboard.c (timer_check): Remove parameter `do_it_now',
4080 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4081 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4082 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4083
4084 * keyboard.c (read_char):
4085 * w32menu.c (w32_menu_display_help):
4086 * xmenu.c (show_help_event, menu_help_callback):
4087 Adjust calls to `show_help_echo'.
4088
4089 * gtkutil.c (xg_maybe_add_timer):
4090 * keyboard.c (readable_events):
4091 * process.c (wait_reading_process_output):
4092 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4093
4094 * insdel.c (adjust_markers_gap_motion):
4095 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4096 (gap_left, gap_right): Don't call it.
4097
4098 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4099
4100 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4101 incurred during fontification.
4102
4103 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4104
4105 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4106 (DEFVAR_PER_BUFFER): Don't pass it.
4107
4108 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4109 (scrolling_window): Don't pass it.
4110
4111 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4112
4113 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4114
4115 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4116 and `suffix'.
4117 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4118 of variables specific to SELinux and computation of `encoded_absname'.
4119
4120 * image.c (XPutPixel): Remove unused variable `height'.
4121
4122 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4123
4124 * unexw32.c (get_section_info): Remove unused variable `section'.
4125
4126 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4127 (system_process_attributes): Remove unused variable `sess'.
4128 (sys_read): Remove unused variable `err'.
4129
4130 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4131 (w32_wnd_proc): Remove unused variable `isdead'.
4132 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4133 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4134 (x_create_tip_frame): Remove unused variable `tem'.
4135
4136 * w32inevt.c (w32_console_read_socket):
4137 Remove unused variable `no_events'.
4138
4139 * w32term.c (x_draw_composite_glyph_string_foreground):
4140 Remove unused variable `width'.
4141
4142 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4143
4144 * w32term.c (x_set_glyph_string_clipping):
4145 Don't pass uninitialized region to CombineRgn.
4146
4147 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4148
4149 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4150 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4151 (Fx_close_connection): Remove unused variable `i'.
4152
4153 * w32font.c (w32font_draw): Return number of glyphs.
4154 (w32font_open_internal): Remove unused variable `i'.
4155 (w32font_driver): Add missing initializer.
4156
4157 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4158 (fill_in_menu): Remove unused variable `items_added'.
4159
4160 * w32term.c (last_mouse_press_frame): Remove static global variable.
4161 (w32_clip_to_row): Remove unused variable `f'.
4162 (x_delete_terminal): Remove unused variable `i'.
4163
4164 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4165 (NOTHING): Remove unused static global variable.
4166 (uniscribe_check_otf): Remove unused variable `table'.
4167 (uniscribe_font_driver): Add missing initializers.
4168
4169 2011-03-23 Julien Danjou <julien@danjou.info>
4170
4171 * term.c (Fsuspend_tty, Fresume_tty):
4172 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4173 * window.c (temp_output_buffer_show):
4174 * insdel.c (signal_before_change):
4175 * frame.c (Fhandle_switch_frame):
4176 * fileio.c (Fdo_auto_save):
4177 * emacs.c (Fkill_emacs):
4178 * editfns.c (save_excursion_restore):
4179 * cmds.c (internal_self_insert):
4180 * callint.c (Fcall_interactively):
4181 * buffer.c (Fkill_all_local_variables):
4182 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4183 Use Frun_hooks.
4184 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4185 unconditionnaly since it does the check itself.
4186
4187 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4188
4189 Fix more problems found by GCC 4.5.2's static checks.
4190
4191 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4192 the first time through the loop, since we know p0 < p1 then.
4193 This also avoids a gcc -Wstrict-overflow warning.
4194
4195 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4196 leading to a memory leak, possible in functions like
4197 load_charset_map_from_file that can allocate an unbounded number
4198 of objects (Bug#8318).
4199
4200 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4201 that could (at least in theory) be that large.
4202
4203 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4204 This is less likely to overflow, and avoids undefined behavior if
4205 overflow does occur. All callers changed. Use strtoul to scan
4206 for the unsigned long integer.
4207 (pint2hrstr): Simplify and tune code slightly.
4208 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4209
4210 * scroll.c (do_scrolling): Work around GCC bug 48228.
4211 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4212
4213 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4214 This also avoids a warning with gcc -Wstrict-overflow.
4215 (validate_x_resource_name): Simplify count usage.
4216 This also avoids a warning with gcc -Wstrict-overflow.
4217
4218 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4219 fail (Bug#8306).
4220
4221 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4222
4223 * process.c (Fmake_network_process): Use socklen_t, not int,
4224 where POSIX says socklen_t is required in portable programs.
4225 This fixes a porting bug on hosts like 64-bit HP-UX, where
4226 socklen_t is wider than int (Bug#8277).
4227 (Fmake_network_process, server_accept_connection):
4228 (wait_reading_process_output, read_process_output):
4229 Likewise.
4230
4231 * process.c: Rename or move locals to avoid shadowing.
4232 (list_processes_1, Fmake_network_process):
4233 (read_process_output_error_handler, exec_sentinel_error_handler):
4234 Rename or move locals.
4235 (Fmake_network_process): Define label "retry_connect" only if needed.
4236 (Fnetwork_interface_info): Fix pointer signedness.
4237 (process_send_signal): Add cast to avoid pointer signedness problem.
4238 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4239 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4240
4241 Make tparam.h and terminfo.c consistent.
4242 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4243 Include tparam.h instead, since it declares them.
4244 * cm.h (PC): Remove extern decl; tparam.h now does this.
4245 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4246 * terminfo.c: Include tparam.h, to check interfaces.
4247 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4248 (tparam): Adjust signature to match interface in tparam.h;
4249 this removes some undefined behavior. Check that outstring and len
4250 are zero, which they always are with Emacs.
4251 * tparam.h (PC, BC, UP): New extern decls.
4252
4253 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4254 (xftfont_open): Rename locals to avoid shadowing.
4255
4256 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4257 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4258 (OTF_TAG_SYM): Omit macro if not needed.
4259 (ftfont_list): Remove unused local.
4260 (get_adstyle_property, ftfont_pattern_entity):
4261 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4262 Rename locals to avoid shadowing.
4263
4264 * xfont.c (xfont_list_family): Mark var as initialized.
4265
4266 * xml.c (make_dom): Now static.
4267
4268 * composite.c (composition_compute_stop_pos): Rename local to
4269 avoid shadowing.
4270 (composition_reseat_it): Remove unused locals.
4271 (find_automatic_composition, composition_adjust_point): Likewise.
4272 (composition_update_it): Mark var as initialized.
4273 (find_automatic_composition): Mark vars as initialized,
4274 with a FIXME (Bug#8290).
4275
4276 character.h: Rename locals to avoid shadowing.
4277 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4278 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4279 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4280 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4281 to avoid shadowing.
4282
4283 * textprop.c (property_change_between_p): Remove; unused.
4284
4285 * intervals.c (interval_start_pos): Now static.
4286
4287 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4288
4289 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4290 Rename locals to avoid shadowing.
4291
4292 * sound.c (wav_play, au_play, Fplay_sound_internal):
4293 Fix pointer signedness.
4294 (alsa_choose_format): Remove unused local var.
4295 (wav_play): Initialize a variable to 0, to prevent undefined
4296 behavior (Bug#8278).
4297
4298 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4299
4300 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4301
4302 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4303 clobbering (Bug#8298).
4304 * sysdep.c (sys_subshell): Likewise.
4305 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4306
4307 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4308 This should get cleaned up, so that child_setup has the
4309 same signature on all platforms.
4310
4311 * callproc.c (call_process_cleanup): Now static.
4312 (relocate_fd): Rename locals to avoid shadowing.
4313
4314 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4315
4316 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4317 not to be necessary, and produces flickering.
4318
4319 2011-03-20 Glenn Morris <rgm@gnu.org>
4320
4321 * config.in: Remove file.
4322
4323 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4324
4325 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4326 are now in src/globals.h.
4327 (syms_of_minibuf): Remove spurious & from previous change.
4328
4329 2011-03-20 Leo <sdl.web@gmail.com>
4330
4331 * minibuf.c (completing-read-function): New variable.
4332 (completing-read-default): Rename from completing-read.
4333 (completing-read): Call completing-read-function.
4334
4335 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4336
4337 * xfaces.c (Fx_load_color_file):
4338 Read color file from absolute filename (bug#8250).
4339
4340 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4341
4342 * makefile.w32-in: Update dependencies.
4343
4344 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4345
4346 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4347
4348 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4349
4350 Fix more problems found by GCC 4.5.2's static checks.
4351
4352 * process.c (make_serial_process_unwind, send_process_trap):
4353 (sigchld_handler): Now static.
4354
4355 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4356 That way, the code declares only the vars that it needs.
4357 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4358 * s/cygwin.h (PTY_ITERATION): Likewise.
4359 * s/darwin.h (PTY_ITERATION): Likewise.
4360 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4361
4362 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4363 * process.c (allocate_pty): Don't declare stb unless it's needed.
4364
4365 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4366 (CONSTANTLIM): Remove; unused.
4367 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4368 Define only if needed.
4369
4370 * unexelf.c (unexec): Name an expression,
4371 to avoid gcc -Wbad-function-cast warning.
4372 Use a different way to cause a compilation error if anyone uses
4373 n rather than nn, a way that does not involve shadowing.
4374 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4375
4376 * deps.mk (unexalpha.o): Remove; unused.
4377
4378 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4379 * unexec.h: New file.
4380 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4381 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4382 Depend on unexec.h.
4383 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4384 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4385 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4386 Change as necessary to match prototype in unexec.h.
4387
4388 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4389 shadowing.
4390 (back_comment, skip_chars): Mark vars as initialized.
4391
4392 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4393 Rename locals to avoid shadowing.
4394
4395 * lread.c (read1): Rewrite so as not to use empty "else".
4396 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4397
4398 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4399
4400 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4401 warning when compiling print.c.
4402
4403 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4404 instead of using an uninitialized var.
4405 (font_sort_entities): Mark var as initialized.
4406
4407 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4408
4409 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4410 pointers to constants.
4411 (font_parse_fcname): Remove unused vars.
4412 (font_delete_unmatched): Now static.
4413 (font_get_spec): Remove; unused.
4414 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4415 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4416 Rename or move locals to avoid shadowing.
4417
4418 * fns.c (require_nesting_list, require_unwind): Now static.
4419 (Ffillarray): Rename locals to avoid shadowing.
4420
4421 * floatfns.c (domain_error2): Define only if needed.
4422 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4423
4424 * alloc.c (mark_backtrace): Move decl from here ...
4425 * lisp.h: ... to here, so that it can be checked.
4426
4427 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4428 (Fdefvar): Rewrite so as not to use empty "else".
4429 (lisp_indirect_variable): Name an expression,
4430 to avoid gcc -Wbad-function-cast warning.
4431 (Fdefvar): Rename locals to avoid shadowing.
4432
4433 * callint.c (quotify_arg, quotify_args): Now static.
4434 (Fcall_interactively): Rename locals to avoid shadowing.
4435 Use const pointer when appropriate.
4436
4437 * lisp.h (get_system_name, get_operating_system_release):
4438 Move decls here, to check interfaces.
4439 * process.c (get_operating_system_release): Move decl to lisp.h.
4440 * xrdb.c (get_system_name): Likewise.
4441 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4442 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4443 some of which prompt warnings from gcc -Wbad-function-cast.
4444 (Fformat_time_string, Fencode_time, Finsert_char):
4445 (Ftranslate_region_internal, Fformat):
4446 Rename or remove local vars to avoid shadowing.
4447 (Ftranslate_region_internal): Mark var as initialized.
4448
4449 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4450 avoid shadowing.
4451
4452 * lisp.h (eassert): Check that the argument compiles, even if
4453 ENABLE_CHECKING is not defined.
4454
4455 * data.c (Findirect_variable): Name an expression, to avoid
4456 gcc -Wbad-function-cast warning.
4457 (default_value, arithcompare, arith_driver, arith_error): Now static.
4458 (store_symval_forwarding): Rename local to avoid shadowing.
4459 (Fmake_variable_buffer_local, Fmake_local_variable):
4460 Mark variables as initialized.
4461 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4462
4463 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4464 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4465 Rename locals to avoid shadowing.
4466 (mark_stack): Move local variables into the #ifdef region where
4467 they're used.
4468 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4469 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4470 needed otherwise.
4471 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4472 (GC_STRING_CHARS): Remove; not used.
4473 (Fmemory_limit): Cast sbrk's returned value to char *.
4474
4475 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4476 avoids undefined behavior in theory.
4477
4478 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4479
4480 Use functions, not macros, for up- and down-casing (Bug#8254).
4481 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4482 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4483 to use the following functions instead of these macros.
4484 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4485 EMACS_INT, since callers assume the returned value fits in int.
4486 (upcase1): Likewise, for UPCASE_TABLE.
4487 (uppercasep, lowercasep, upcase): New static inline functions.
4488 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4489 the race-condition problem in the old DOWNCASE.
4490
4491 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4492 Rename locals to avoid shadowing.
4493 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4494 (regex_compile, re_search_2, re_match_2_internal):
4495 Remove unused local vars.
4496 (FREE_VAR): Rewrite so as not to use empty "else",
4497 which gcc can warn about.
4498 (regex_compile, re_match_2_internal): Mark locals as initialized.
4499 (RETALLOC_IF): Define only if needed.
4500 (WORDCHAR_P): Likewise. This one is never needed, but is used
4501 only in a comment talking about a compiler bug, so put inside
4502 the #if 0 of that comment.
4503 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4504 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4505 Remove; unused.
4506
4507 * search.c (boyer_moore): Rename locals to avoid shadowing.
4508 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4509 (PREV_CHAR_BOUNDARY): Likewise.
4510
4511 * search.c (simple_search): Remove unused var.
4512
4513 * dired.c (compile_pattern): Move decl from here ...
4514 * lisp.h: ... to here, so that it can be checked.
4515 (struct re_registers): New forward decl.
4516
4517 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4518
4519 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4520 All uses changed.
4521 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4522 Rename locals to avoid shadowing.
4523 (Fvertical_motion): Mark locals as initialized.
4524
4525 * casefiddle.c (casify_object, casify_region): Now static.
4526 (casify_region): Mark local as initialized.
4527
4528 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4529
4530 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4531 New macros, so that the caller can use some names other than
4532 gcpro1, gcpro2, etc.
4533 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4534 of the new macros.
4535 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4536 argument, for consistency with GCPRO2_VAR, etc: it is now the
4537 prefix of the variable, not the variable itself. All uses
4538 changed.
4539 * dired.c (directory_files_internal, file_name_completion):
4540 Rename locals to avoid shadowing.
4541
4542 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4543 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4544 dired.c's scmp function, had undefined behavior.
4545 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4546 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4547 * buffer.h: ... to here, because these macros use current_buffer,
4548 and the new implementation with inline functions needs to have
4549 current_buffer in scope now, rather than later when the macros
4550 are used.
4551 (downcase, upcase1): New static inline functions.
4552 (DOWNCASE, UPCASE1): Reimplement using these functions.
4553 This avoids undefined behavior in expressions like
4554 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4555 from race conditions in accessing the global variables
4556 case_temp1 and case_temp2.
4557 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4558 * lisp.h (case_temp1, case_temp2): Remove their decls.
4559 * character.h (ASCII_CHAR_P): Move from here ...
4560 * lisp.h: ... to here, so that the inline functions mentioned
4561 above can use them.
4562
4563 * dired.c (directory_files_internal_unwind): Now static.
4564
4565 * fileio.c (file_name_as_directory, directory_file_name):
4566 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4567 Now static.
4568 (file_name_as_directory): Use const pointers when appropriate.
4569 (Fexpand_file_name): Likewise. In particular, newdir might
4570 point at constant storage, so make it a const pointer.
4571 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4572 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4573 signedness issues.
4574 (Fset_file_times, Finsert_file_contents, auto_save_error):
4575 Rename locals to avoid shadowing.
4576
4577 * minibuf.c (choose_minibuf_frame_1): Now static.
4578 (Ftry_completion, Fall_completions): Rename or remove locals
4579 to avoid shadowing.
4580
4581 * marker.c (bytepos_to_charpos): Remove; unused.
4582
4583 * lisp.h (verify_bytepos, count_markers): New decls,
4584 so that gcc does not warn that these functions aren't declared.
4585
4586 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4587 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4588 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4589 (copy_text): Remove unused local var.
4590
4591 * filelock.c (within_one_second): Now static.
4592 (lock_file_1): Rename local to avoid shadowing.
4593
4594 * buffer.c (fix_overlays_before): Mark locals as initialized.
4595 (fix_start_end_in_overlays): Likewise. This function should be
4596 simplified by using pointers-to-pointers, but that's a different
4597 matter.
4598 (switch_to_buffer_1): Now static.
4599 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4600 (report_overlay_modification): Rename locals to avoid shadowing.
4601
4602 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4603 Fix pointer signedness issue.
4604 (sys_subshell): Mark local as volatile if checking for lint,
4605 to suppress a gcc -Wclobbered warning that does not seem to be right.
4606 (MAXPATHLEN): Define only if needed.
4607
4608 * process.c (serial_open, serial_configure): Move decls from here ...
4609 * systty.h: ... to here, so that they can be checked.
4610
4611 * fns.c (get_random, seed_random): Move extern decls from here ...
4612 * lisp.h: ... to here, so that they can be checked.
4613
4614 * sysdep.c (reset_io): Now static.
4615 (wait_for_termination_signal): Remove; unused.
4616
4617 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4618 (copy_keymap_item, append_key, push_text_char_description):
4619 Now static.
4620 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4621 (DENSE_TABLE_SIZE): Remove; unused.
4622 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4623 (describe_map_tree):
4624 Rename locals to avoid shadowing.
4625
4626 * keyboard.c: Declare functions static if they are not used elsewhere.
4627 (echo_char, echo_dash, cmd_error, top_level_2):
4628 (poll_for_input, handle_async_input): Now static.
4629 (read_char, kbd_buffer_get_event, make_lispy_position):
4630 (make_lispy_event, make_lispy_movement, apply_modifiers):
4631 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4632 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4633 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4634 (read_key_sequence, read_char): Mark locals as initialized.
4635 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4636
4637 * keyboard.h (make_ctrl_char): New decl.
4638 (mark_kboards): Move decl here ...
4639 * alloc.c (mark_kboards): ... from here.
4640
4641 * lisp.h (force_auto_save_soon): New decl.
4642
4643 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4644 (DEFINE_DUMMY_FUNCTION): New macro.
4645 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4646 Use it.
4647 (main): Add casts to avoid warnings
4648 if GCC considers string literals to be constants.
4649
4650 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4651
4652 * dbusbind.c: Pointer signedness fixes.
4653 (xd_signature, xd_append_arg, xd_initialize):
4654 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4655 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4656 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4657 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4658
4659 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4660 if GCC considers string literals to be constants.
4661 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4662
4663 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4664
4665 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4666 (print_preprocess, print_object): New macro to fix last change.
4667
4668 * print.c (print_preprocess): Don't forget font objects.
4669
4670 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4671
4672 * emacs.c (USAGE3): Doc fixes.
4673
4674 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4675
4676 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4677 structure.
4678
4679 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4680
4681 * lisp.h (VWindow_system, Qfile_name_history):
4682 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4683 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4684 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4685
4686 * w32select.c: Don't #include "keyboard.h".
4687 (run_protected): Add extern declaration for waiting_for_input.
4688
4689 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4690 * w32console.c (detect_input_pending, read_input_pending)
4691 (encode_terminal_code):
4692 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4693 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4694 (w32_system_caret_y, Qfile_name_history):
4695 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4696 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4697 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4698 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4699 * w32proc.c (Qlocal, report_file_error):
4700 * w32term.c (Vwindow_system, updating_frame):
4701 * w32uniscribe.c (initialized, uniscribe_font_driver):
4702 Remove unneeded extern declarations.
4703
4704 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4705
4706 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4707
4708 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4709
4710 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4711 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4712 These macros can no longer be used for assignment.
4713
4714 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4715 Assign struct members directly, instead of using BUF_BEGV etc.
4716 (record_buffer_markers, fetch_buffer_markers): New functions for
4717 recording and fetching special buffer markers.
4718 (set_buffer_internal_1, set_buffer_temp): Use them.
4719
4720 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4721
4722 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4723
4724 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4725 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4726
4727 * xdisp.c (hscroll_window_tree):
4728 (reconsider_clip_changes): Use PT instead of BUF_PT.
4729
4730 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4731
4732 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4733 $(EMACS_ROOT)/lib/intprops.h.
4734
4735 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4736
4737 Fix more problems found by GCC 4.5.2's static checks.
4738
4739 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4740 to unsigned char * to avoid compiler diagnostic.
4741 (xg_free_frame_widgets): Make it clear that a local variable is
4742 needed only if USE_GTK_TOOLTIP.
4743 (gdk_window_get_screen): Make it clear that this macro is needed
4744 only if USE_GTK_TOOLTIP.
4745 (int_gtk_range_get_value): New function, which avoids a diagnostic
4746 from gcc -Wbad-function-cast.
4747 (xg_set_toolkit_scroll_bar_thumb): Use it.
4748 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4749 diagnostic from gcc -Wbad-function-cast.
4750 (get_utf8_string, xg_get_file_with_chooser):
4751 Rename locals to avoid shadowing.
4752 (create_dialog): Move locals to avoid shadowing.
4753
4754 * xgselect.c (xg_select): Remove unused var.
4755
4756 * image.c (four_corners_best): Mark locals as initialized.
4757 (gif_load): Initialize transparent_p to zero (Bug#8238).
4758 Mark another local as initialized.
4759 (my_png_error, my_error_exit): Mark with NO_RETURN.
4760
4761 * image.c (clear_image_cache): Now static.
4762 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4763 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4764 (x_edge_detection): Remove unnecessary cast that
4765 gcc -Wbad-function-cast diagnoses.
4766 (gif_load): Fix pointer signedness.
4767 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4768 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4769
4770 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4771
4772 Improve quality of tests for time stamp overflow.
4773 For example, without this patch (encode-time 0 0 0 1 1
4774 1152921504606846976) returns the obviously-bogus value (-948597
4775 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4776 reports time overflow. See
4777 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4778 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4779 * editfns.c: Include limits.h and intprops.h.
4780 (TIME_T_MIN, TIME_T_MAX): New macros.
4781 (time_overflow): Move earlier, to before first use.
4782 (hi_time, lo_time): New functions, for an accurate test for
4783 out-of-range times.
4784 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4785 (Fget_internal_run_time): Don't assume time_t fits in int.
4786 (make_time): Use list2 instead of Fcons twice.
4787 (Fdecode_time): More accurate test for out-of-range times.
4788 (check_tm_member): New function.
4789 (Fencode_time): Use it, to test for out-of-range times.
4790 (lisp_time_argument): Don't rely on undefined left-shift and
4791 right-shift behavior when checking for time stamp overflow.
4792
4793 * editfns.c (time_overflow): New function, refactoring common code.
4794 (Fformat_time_string, Fdecode_time, Fencode_time):
4795 (Fcurrent_time_string): Use it.
4796
4797 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4798 * dired.c (make_time): Move to ...
4799 * editfns.c (make_time): ... here.
4800 * systime.h: Note the move.
4801
4802 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4803
4804 * fringe.c (update_window_fringes): Remove unused variables.
4805
4806 * unexmacosx.c (copy_data_segment): Also copy __got section.
4807 (Bug#8223)
4808
4809 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4810
4811 * termcap.c [MSDOS]: Include "msdos.h".
4812 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4813 Constify `char *' arguments and their references according to
4814 prototypes in tparam.h.
4815
4816 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4817
4818 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4819 Adapt all references accordingly.
4820
4821 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4822
4823 2011-03-11 Tom Tromey <tromey@redhat.com>
4824
4825 * buffer.c (syms_of_buffer): Remove obsolete comment.
4826
4827 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4828
4829 * termhooks.h (encode_terminal_code): Declare prototype.
4830
4831 * msdos.c (encode_terminal_code): Don't declare prototype.
4832
4833 * term.c (encode_terminal_code): Now external again, used by
4834 w32console.c and msdos.c.
4835
4836 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4837 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4838
4839 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4840
4841 Fix some minor problems found by GCC 4.5.2's static checks.
4842
4843 * fringe.c (update_window_fringes): Mark locals as initialized
4844 (Bug#8227).
4845 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4846
4847 * alloc.c (mark_fringe_data): Move decl from here ...
4848 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4849 to check its interface.
4850 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4851
4852 * fontset.c (free_realized_fontset): Now static.
4853 (Fset_fontset_font): Rename local to avoid shadowing.
4854 (fontset_font): Mark local as initialized.
4855 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4856
4857 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4858
4859 * xselect.c (x_disown_buffer_selections): Remove; not used.
4860 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4861 (x_own_selection, Fx_disown_selection_internal): Rename locals
4862 to avoid shadowing.
4863 (x_handle_dnd_message): Remove local to avoid shadowing.
4864
4865 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4866 so that the caller can use some name other than gcpro1.
4867 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4868 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4869 (Fx_backspace_delete_keys_p):
4870 Use them to avoid shadowing, and rename vars to avoid shadowing.
4871 (x_decode_color, x_set_name, x_window): Now static.
4872 (Fx_create_frame): Add braces to silence GCC warning.
4873 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4874 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4875 Remove unused locals.
4876 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4877 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4878 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4879 macros.
4880
4881 * xterm.h (x_mouse_leave): New decl.
4882
4883 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4884 Remove unused functions.
4885 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4886 (x_calc_absolute_position): Now static.
4887 (XTread_socket): Don't define label "out" unless it's used.
4888 Don't declare local "event" unless it's used.
4889 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4890 unless they are used.
4891 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4892 (x_fatal_error_signal): Remove; not used.
4893 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4894 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4895 (x_error_catcher, x_connection_closed, x_error_handler):
4896 (x_error_quitter, xembed_send_message, x_iconify_frame):
4897 (my_log_handler): Rename locals to avoid shadowing.
4898 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4899 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4900
4901 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4902 Rename or move locals to avoid shadowing.
4903 (tty_defined_color, merge_face_heights): Now static.
4904 (free_realized_faces_for_fontset): Remove; not used.
4905 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4906 does not deduce is never used uninitialized.
4907 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4908 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4909
4910 * terminal.c (store_terminal_param): Now static.
4911
4912 * xmenu.c (menu_highlight_callback): Now static.
4913 (set_frame_menubar): Remove unused local.
4914 (xmenu_show): Rename parameter to avoid shadowing.
4915 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4916 since they might point to immutable storage.
4917 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4918 since it's unused otherwise.
4919
4920 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4921 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4922 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4923 avoids a gcc -Wuninitialized diagnostic.
4924 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4925 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4926 does not deduce are never used uninitialized.
4927
4928 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4929
4930 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4931 * window.c (window_loop, size_window):
4932 (run_window_configuration_change_hook, enlarge_window): Likewise.
4933
4934 * window.c (display_buffer): Now static.
4935 (size_window): Mark variables that gcc -Wuninitialized
4936 does not deduce are never used uninitialized.
4937 * window.h (check_all_windows): New decl, to forestall
4938 gcc -Wmissing-prototypes diagnostic.
4939 * dispextern.h (bidi_dump_cached_states): Likewise.
4940
4941 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4942 shadowing.
4943 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4944 Include <limits.h>.
4945 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4946 and to avoid gcc -Wuninitialized warning.
4947 (load_charset_map): Mark variables that gcc -Wuninitialized
4948 does not deduce are never used uninitialized.
4949 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4950
4951 * coding.c (coding_set_source, coding_set_destination):
4952 Use "else { /* comment */ }" rather than "else /* comment */;"
4953 for clarity, and to avoid gcc -Wempty-body warning.
4954 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4955 a block, when the outer 'i' will do.
4956 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4957 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4958 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4959 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4960 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4961 Rename locals to avoid shadowing.
4962 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4963 * coding.c (emacs_mule_char, encode_invocation_designation):
4964 Now static, since they're not used elsewhere.
4965 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4966 (decode_coding_object, encode_coding_object, detect_coding_system):
4967 (decode_coding_emacs_mule): Mark variables that gcc
4968 -Wuninitialized does not deduce are never used uninitialized.
4969 (detect_coding_iso_2022): Initialize a local variable that might
4970 be used uninitialized. Leave a FIXME because it's not clear that
4971 this initialization is needed. (Bug#8211)
4972 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4973 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4974 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4975 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4976 Remove unused macros.
4977
4978 * category.c (hash_get_category_set): Remove unused local var.
4979 (copy_category_table): Now static, since it's not used elsewhere.
4980 * character.c (string_count_byte8): Likewise.
4981
4982 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4983 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4984
4985 * chartab.c (copy_sub_char_table): Now static, since it's not used
4986 elsewhere.
4987 (sub_char_table_ref_and_range, char_table_ref_and_range):
4988 Rename locals to avoid shadowing.
4989 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4990
4991 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4992 (BIDI_BOB): Remove unused macro.
4993
4994 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4995 deduce are never used uninitialized.
4996 * term.c (encode_terminal_code): Likewise.
4997
4998 * term.c (encode_terminal_code): Now static. Remove unused local.
4999
5000 * tparam.h: New file.
5001 * term.c, tparam.h: Include it.
5002 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5003 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5004 Move these decls to tparam.h, and make them agree with what
5005 is actually in tparam.c. The previous trick of using incompatible
5006 decls in different modules does not conform to the C standard.
5007 All callers of tparam changed to use tparam's actual API.
5008 * tparam.c (tparam1, tparam, tgoto):
5009 Use const pointers where appropriate.
5010
5011 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5012 * cm.h (struct cm): Likewise.
5013 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5014 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5015 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5016 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5017 (turn_on_face, init_tty): Likewise.
5018 * termchar.h (struct tty_display_info): Likewise.
5019
5020 * term.c (term_mouse_position): Rename local to avoid shadowing.
5021
5022 * alloc.c (mark_ttys): Move decl from here ...
5023 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5024
5025 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5026
5027 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5028
5029 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5030
5031 * search.c (compile_pattern_1): Remove argument regp, unused since
5032 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5033 (compile_pattern): Don't pass it.
5034
5035 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5036
5037 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5038 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5039 for ! HAVE_GTK3.
5040 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5041
5042 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5043
5044 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5045 gdk_window_get_screen, gdk_window_get_geometry,
5046 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5047 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5048 (xg_get_pixbuf_from_pixmap): New function.
5049 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5050 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5051 Call xg_get_pixbuf_from_pixmap instead of
5052 gdk_pixbuf_get_from_drawable.
5053 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5054 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5055 (xg_check_special_colors): Use GtkStyleContext and its functions
5056 for HAVE_GTK3.
5057 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5058 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5059 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5060 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5061 Call gtk_widget_get_preferred_size.
5062 (xg_frame_resized): gdk_window_get_geometry only takes 5
5063 parameters.
5064 (xg_win_to_widget, xg_event_is_for_menubar):
5065 Call gdk_x11_window_lookup_for_display.
5066 (xg_set_widget_bg): New function.
5067 (delete_cb): New function.
5068 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5069 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5070 (xg_set_background_color): Call xg_set_widget_bg.
5071 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5072 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5073 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5074 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5075 if ! HAVE_GTK3.
5076 (update_frame_tool_bar): Call gtk_widget_hide.
5077 (xg_initialize): Use GDK_KEY_g.
5078
5079 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5080 if ! HAVE_GTK3
5081 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5082
5083 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5084 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5085 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5086
5087 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5088
5089 * w32xfns.c (select_palette): Check success of RealizePalette against
5090 GDI_ERROR, not zero.
5091
5092 See ChangeLog.11 for earlier changes.
5093
5094 ;; Local Variables:
5095 ;; coding: utf-8
5096 ;; End:
5097
5098 Copyright (C) 2011 Free Software Foundation, Inc.
5099
5100 This file is part of GNU Emacs.
5101
5102 GNU Emacs is free software: you can redistribute it and/or modify
5103 it under the terms of the GNU General Public License as published by
5104 the Free Software Foundation, either version 3 of the License, or
5105 (at your option) any later version.
5106
5107 GNU Emacs is distributed in the hope that it will be useful,
5108 but WITHOUT ANY WARRANTY; without even the implied warranty of
5109 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5110 GNU General Public License for more details.
5111
5112 You should have received a copy of the GNU General Public License
5113 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.