1 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3 Extend mouse support on W32 text-mode console.
4 * xdisp.c (draw_row_with_mouse_face): Call
5 tty_draw_row_with_mouse_face for WINDOWSNT as well.
7 * w32console.c: Include window.h.
8 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face): New
10 (initialize_w32_display): Initialize mouse-highlight data.
12 * w32inevt.c: Include termchar.h and window.h.
13 (do_mouse_event): Support mouse-autoselect-window. When the mouse
14 moves, call note_mouse_highlight. If help_echo changed, call
15 gen_help_event to produce help-echo message in the echo area.
16 Call clear_mouse_face if mouse_face_hidden is set in the mouse
19 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
21 * lread.c (read1): Simplify slightly to avoid an overflow warning
22 with GCC 4.7.0 on x86-64.
24 2012-05-26 Eli Zaretskii <eliz@gnu.org>
26 * bidi.c (bidi_mirror_char): Revert last change: an int is
27 definitely wide enough here.
29 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
31 Fix integer width and related bugs (Bug#9874).
32 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
33 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
34 (string_bytes, check_sblock, allocate_string_data):
35 (compact_small_strings, Fmake_bool_vector, make_string)
36 (make_unibyte_string, make_multibyte_string)
37 (make_string_from_bytes, make_specified_string)
38 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
39 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
41 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
42 (allocate_pseudovector):
43 Use int, not EMACS_INT, where int is wide enough.
44 (inhibit_garbage_collection, Fgarbage_collect):
45 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
46 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
47 int might not be wide enough.
48 (bidi_cache_search, bidi_cache_find, bidi_init_it)
49 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
50 (bidi_at_paragraph_end, bidi_find_paragraph_start)
51 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
52 (bidi_level_of_next_char, bidi_move_to_visually_next):
53 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
55 (Fkill_buffer, Fset_buffer_major_mode)
56 (advance_to_char_boundary, Fbuffer_swap_text)
57 (Fset_buffer_multibyte, overlays_at, overlays_in)
58 (overlay_touches_p, struct sortvec, record_overlay_string)
59 (overlay_strings, recenter_overlay_lists)
60 (adjust_overlays_for_insert, adjust_overlays_for_delete)
61 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
62 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
63 (Foverlay_recenter, last_overlay_modification_hooks_used)
64 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
65 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
66 (validate_region): Omit unnecessary test for b <= e,
67 since that's guaranteed by the previous test.
68 (adjust_overlays_for_delete): Avoid pos + length overflow.
69 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
70 (report_overlay_modification):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
73 Omit pointer cast, which isn't needed anyway, and doesn't work
74 after the EMACS_INT -> ptrdiff_t change.
75 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
76 * buffer.h: Adjust decls to match defn changes elsewhere.
77 (struct buffer_text, struct buffer):
78 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
79 Use EMACS_INT, not int, where int might not be wide enough.
80 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
81 not int, to avoid needless 32-bit limit on 64-bit hosts.
82 (exec_byte_code): Use tighter memory-full test, one that checks
83 for alloca overflow. Don't compute the address of the object just
84 before an array, as that's not portable. Use EMACS_INT, not
85 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
86 * callint.c (Fcall_interactively):
87 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
88 * callproc.c (call_process_kill, Fcall_process):
89 Don't assume pid_t fits into an Emacs fixnum.
90 (call_process_cleanup, Fcall_process, child_setup):
91 Don't assume pid_t fits into int.
92 (call_process_cleanup, Fcall_process, delete_temp_file)
93 (Fcall_process_region):
94 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
95 (Fcall_process): Simplify handling of volatile integers.
96 Use int, not EMACS_INT, where int will do.
97 * casefiddle.c (casify_object, casify_region, operate_on_word)
98 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
99 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
100 (casify_object): Avoid integer overflow when overallocating buffer.
101 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
102 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
103 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
104 * category.h (CATEGORYP): Don't assume arg is nonnegative.
105 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
106 integers are now checked earlier. All uses replaced with XINT.
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 For CCL_MapSingle, check that content and value are in int range.
110 (ccl_driver, Fregister_code_conversion_map):
111 Check that Vcode_version_map_vector is a vector.
112 (resolve_symbol_ccl_program): Check that vector header is in range.
113 Always copy the vector, so that we can check its contents reliably
114 now rather than having to recheck each instruction as it's being
115 executed. Check that vector words fit in 'int'.
116 (ccl_get_compiled_code, Fregister_ccl_program)
117 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
118 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
119 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
120 contents are in range.
121 (Fccl_execute_on_string): Check that status is in range.
122 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
123 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
124 Accept and return EMACS_INT, not int, because callers can pass values
126 (c_string_width, strwidth, lisp_string_width, chars_in_text)
127 (multibyte_chars_in_text, parse_str_as_multibyte)
128 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
129 (str_as_unibyte, str_to_unibyte, string_count_byte8)
130 (string_escape_byte8, Fget_byte):
131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
132 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
133 avoid mishandling large integers.
134 * character.h: Adjust decls to match defn changes elsewhere.
135 * charset.c (load_charset_map_from_file, find_charsets_in_text)
136 (Ffind_charset_region):
137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
138 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
139 (load_charset_map_from_vector, Fdefine_charset_internal):
140 Don't assume fixnum fits in int.
141 (load_charset_map_from_vector, Fmap_charset_chars):
142 Remove now-unnecessary CHECK_NATNUMs.
143 (Fdefine_charset_internal): Check ranges here, more carefully.
144 Don't rely on undefined behavior with signed left shift overflow.
145 Don't assume unsigned int fits into fixnum, or that fixnum fits
146 into unsigned int. Don't require max_code to be a valid fixnum;
147 that's not true for gb10830 4-byte on a 32-bit host. Allow
148 invalid_code to be a cons, for the same reason. Require code_offset
149 to be a character. Avoid int overflow if max_char is close
151 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
152 this is intended anyway and avoids some undefined behavior.
153 (load_charset_map): Pass unsigned, not int, as 2nd arg of
154 INDEX_TO_CODE_POINT, as that's what it expects.
155 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
156 * charset.h (DECODE_CHAR): Return int, not unsigned;
157 this is what was intended anyway, and it avoids undefined behavior.
158 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
159 integer-overflow issues.
160 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
161 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
162 where the argument is EMACS_INT, and this behavior is not intended.
163 * chartab.c (Fmake_char_table, Fset_char_table_range)
164 (uniprop_get_decoder, uniprop_get_encoder):
165 Don't assume fixnum fits in int.
166 * cmds.c (move_point): New function, that does the gist of
167 Fforward_char and Fbackward_char, but does so while checking
168 for integer overflow more accurately.
169 (Fforward_char, Fbackward_char): Use it.
170 (Fforward_line, Fend_of_line, internal_self_insert)
171 (internal_self_insert):
172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
173 Fix a FIXME, by checking for integer overflow when calculating
174 target_clm and actual_clm.
175 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
176 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
177 (ASSURE_DESTINATION, coding_alloc_by_realloc)
178 (coding_alloc_by_making_gap, alloc_destination)
179 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
180 (encode_coding_utf_16, detect_coding_emacs_mule)
181 (decode_coding_emacs_mule, encode_coding_emacs_mule)
182 (detect_coding_iso_2022, decode_coding_iso_2022)
183 (encode_invocation_designation, encode_designation_at_bol)
184 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
185 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
186 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
187 (encode_coding_ccl, encode_coding_raw_text)
188 (detect_coding_charset, decode_coding_charset)
189 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
190 (produce_composition, produce_charset, produce_annotation)
191 (decode_coding, handle_composition_annotation)
192 (handle_charset_annotation, consume_chars, decode_coding_gap)
193 (decode_coding_object, encode_coding_object, detect_coding_system)
194 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
195 (code_convert_region, code_convert_string)
196 (Fdefine_coding_system_internal)
197 (coding_set_source, coding_set_destination):
198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
199 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
200 (Fdefine_coding_system_internal):
201 Don't assume fixnums fit in int.
202 (decode_coding_gap, decode_coding_object, encode_coding_object)
203 (Fread_coding_system, Fdetect_coding_region)
204 (Funencodable_char_position, Fcheck_coding_systems_region)
205 (get_translation, handle_composition_annotation, consume_chars):
206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
207 (consume_chars): Rewrite to not calculate an address outside buffer.
208 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
209 Don't access memory outside of the args array.
210 (Fdefine_coding_system_internal): Check for charset-id overflow.
211 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
212 result of ENCODE_CHAR.
213 * coding.h: Adjust decls to match defn changes elsewhere.
214 (struct coding_system):
215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
216 * composite.c (get_composition_id, find_composition)
217 (run_composition_function, update_compositions)
218 (compose_text, composition_gstring_put_cache)
219 (composition_gstring_p, composition_gstring_width)
220 (fill_gstring_header, fill_gstring_body, autocmp_chars)
221 (composition_compute_stop_pos, composition_reseat_it)
222 (composition_update_it, struct position_record)
223 (find_automatic_composition, composition_adjust_point)
224 (Fcomposition_get_gstring, Ffind_composition_internal):
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (update_compositions):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * composite.h: Adjust decls to match defn changes elsewhere.
229 (struct composition):
230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
231 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
232 Do not attempt to compute the address of the object just before a
233 buffer; this is not portable.
235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
236 (Faset): Use int, not EMACS_INT, where int is wide enough.
237 (Fstring_to_number): Don't assume fixnums fit in int.
238 (Frem): Don't assume arg is nonnegative.
239 * dbusbind.c (xd_append_arg): Check for integers out of range.
240 (Fdbus_call_method): Don't overflow the timeout int.
241 (extract_signed, extract_unsigned): New functions.
242 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
243 (xd_get_connection_references): Return ptrdiff_t, not int.
245 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
247 Use int, not unsigned, where the dbus API uses int.
248 (Fdbus_message_internal): Don't overflow mtype.
249 (syms_of_dbusbind): Allocate right-sized buffer for integers.
250 * dired.c (directory_files_internal, file_name_completion, scmp)
251 (file_name_completion_stat):
252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
253 (file_name_completion): Don't overflow matchcount.
254 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
255 * dispextern.h: Adjust decls to match defn changes elsewhere.
256 (struct text_pos, struct glyph, struct bidi_saved_info)
257 (struct bidi_string_data, struct bidi_it, struct composition_it)
259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
260 (struct display_pos, struct composition_it, struct it):
261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
262 * dispnew.c (increment_matrix_positions)
263 (increment_row_positions, mode_line_string)
264 (marginal_area_string):
265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
266 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
268 (duration_to_sec_usec): New function, to check for overflow better.
269 (Fsleep_for, sit_for): Use it.
270 * doc.c (get_doc_string, store_function_docstring):
271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
272 (get_doc_string, Fsnarf_documentation):
273 Use int, not EMACS_INT, where int is wide enough.
275 Use SAFE_ALLOCA, not alloca.
276 Check for overflow when converting EMACS_INT to off_t.
278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
279 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
280 Don't assume uid_t fits into fixnum.
281 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
282 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
283 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
284 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
285 (general_insert_function)
286 (Finsert_char, make_buffer_string, make_buffer_string_both)
287 (update_buffer_properties, Fbuffer_substring)
288 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
289 (Fsubst_char_in_region, check_translation)
290 (Ftranslate_region_internal, save_restriction_restore, Fformat)
291 (transpose_markers, Ftranspose_regions):
292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
293 (clip_to_bounds): Move to lisp.h as an inline function).
294 (Fconstrain_to_field): Don't assume integers are nonnegative.
295 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
296 (Fsubst_char_in_region, Fsave_restriction):
297 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
298 (Femacs_pid): Don't assume pid_t fits into fixnum.
299 (lo_time): Use int, not EMACS_INT, when int suffices.
300 (lisp_time_argument): Check for usec out of range.
301 (Fencode_time): Don't assume fixnum fits in int.
302 (Fuser_login_name, Fuser_full_name): Signal an error
303 if a uid argument is out of range, rather than relying on
305 (Fformat_time_string): Remove now-unnecessary check.
306 lisp_time_argument checks for out-of-range usec now.
307 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
308 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
309 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
310 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
311 (init_cmdargs, Fdump_emacs):
312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
313 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
314 the bottom (typically) 32 bits of the fixnum.
315 * eval.c (specpdl_size, call_debugger):
316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
317 (when_entered_debugger, Fbacktrace_debug):
318 Don't assume fixnum can fit in int.
319 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
320 the object just before a buffer; this is not portable.
321 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
322 (grow_specpdl, unbind_to):
323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
324 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
325 (grow_specpdl): Simplify allocation by using xpalloc.
326 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
327 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
328 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
330 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
333 (Fcopy_file, non_regular_nbytes, read_non_regular)
334 (Finsert_file_contents):
335 Use int, not EMACS_INT, where int is wide enough.
336 (READ_BUF_SIZE): Verify that it fits in int.
337 (Finsert_file_contents): Check that counts are in proper range,
338 rather than assuming fixnums fit into ptrdiff_t etc.
339 Don't assume fixnums fit into int.
340 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
341 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
342 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
343 (string_char_to_byte, string_byte_to_char)
344 (string_make_multibyte, string_to_multibyte)
345 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
346 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
347 (substring_both, Fdelete, internal_equal, Ffillarray)
348 (Fclear_string, mapcar1)
349 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
350 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
351 (larger_vector, make_hash_table, maybe_resize_hash_table)
352 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
353 (Fmaphash, secure_hash):
354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
355 (concat): Check for string index and length overflow.
356 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
358 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
359 (larger_vector): New API (vec, incr_min, size_max) replaces old
360 one (vec, new_size, init). This catches size overflow.
361 INIT was removed because it was always Qnil.
363 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
364 the upper bound on a hash table index size.
365 (make_hash_table, maybe_resize_hash_table): Use it.
366 (secure_hash): Computer start_byte and end_byte only after
367 they're known to be in ptrdiff_t range.
368 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
369 (Ffont_get_glyphs, Ffont_at):
370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
371 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
372 (Flist_fonts, Fopen_font):
373 Don't assume fixnum can fit in int.
374 (check_gstring): Don't assume index can fit in int.
375 (font_match_p): Check that fixnum is a character, not a nonnegative
376 fixnum, since the later code needs to stuff it into an int.
377 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
378 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
379 conversion overflow issues.
380 (Fopen_font): Check for integer out of range.
381 (Ffont_get_glyphs): Don't assume index can fit in int.
382 * font.h: Adjust decls to match defn changes elsewhere.
383 * fontset.c (reorder_font_vector): Redo score calculation to avoid
385 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
386 printmax_t, where ptrdiff_t is wide enough.
387 (Finternal_char_font):
388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
389 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
390 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
391 (Fset_frame_position, x_set_frame_parameters)
392 (x_set_line_spacing, x_set_border_width)
393 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
394 Check that fixnums are in proper range for system types.
395 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
397 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
398 Use SAFE_ALLOCA_LISP, not alloca.
399 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
400 intptr_t is wide enough.
401 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
402 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
403 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
404 Check for fixnum out of range.
405 * ftfont.c (ftfont_list): Don't assume index fits in int.
406 Check that fixnums are in proper range for system types.
407 (ftfont_shape_by_flt):
408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
409 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
411 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
412 Check that fixnums are in proper range for system types.
413 * gnutls.h: Adjust decls to match defn changes elsewhere.
414 * gtkutil.c (xg_dialog_run):
415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
416 (update_frame_tool_bar):
417 Check that fixnums are in proper range for system types.
418 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
419 (lookup_image): Check that fixnums are in range for system types.
420 * indent.c (last_known_column, last_known_column_point):
421 (current_column_bol_cache):
422 (skip_invisible, current_column, check_display_width):
423 (check_display_width, scan_for_column, current_column_1)
424 (Findent_to, Fcurrent_indentation, position_indentation)
425 (indented_beyond_p, Fmove_to_column, compute_motion):
426 (Fcompute_motion, Fvertical_motion):
427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
428 (last_known_column_modified): Use EMACS_INT, not int.
429 (check_display_width):
431 Check that fixnums and floats are in proper range for system types.
432 (compute_motion): Don't assume index or fixnum fits in int.
433 (compute_motion, Fcompute_motion):
434 Use int, not EMACS_INT, when it is wide enough.
435 (vmotion): Omit local var start_hpos that is always 0; that way
436 we don't need to worry about overflow in expressions involving it.
437 * indent.h: Adjust decls to match defn changes elsewhere.
439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
440 Use int, not EMACS_INT, where int is wide enough.
441 Remove unused members ovstring_chars_done and tab_offset;
443 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
444 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
445 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
446 (make_gap, copy_text, insert, insert_and_inherit)
447 (insert_before_markers, insert_before_markers_and_inherit)
448 (insert_1, count_combining_before, count_combining_after)
449 (insert_1_both, insert_from_string)
450 (insert_from_string_before_markers, insert_from_string_1)
451 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
452 (adjust_after_replace, adjust_after_insert, replace_range)
453 (replace_range_2, del_range, del_range_1, del_range_byte)
454 (del_range_both, del_range_2, modify_region)
455 (prepare_to_modify_buffer, signal_before_change)
456 (signal_after_change, Fcombine_after_change_execute):
457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
458 * intervals.c (traverse_intervals, rotate_right, rotate_left)
459 (balance_an_interval, split_interval_right, split_interval_left)
460 (find_interval, next_interval, update_interval)
461 (adjust_intervals_for_insertion, delete_node, delete_interval)
462 (interval_deletion_adjustment, adjust_intervals_for_deletion)
463 (static_offset_intervals, offset_intervals)
464 (merge_interval_right, merge_interval_left, make_new_interval)
465 (graft_intervals_into_buffer, temp_set_point_both)
466 (temp_set_point, set_point, adjust_for_invis_intang)
467 (set_point_both, move_if_not_intangible, get_property_and_range)
468 (get_local_map, copy_intervals, copy_intervals_to_string)
469 (compare_string_intervals, set_intervals_multibyte_1):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 * intervals.h: Adjust decls to match defn changes elsewhere.
473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
474 * keyboard.c (this_command_key_count, this_single_command_key_start)
475 (before_command_key_count, before_command_echo_length, echo_now)
476 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
477 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
478 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
479 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
481 (last_non_minibuf_size, last_point_position, echo_truncate)
482 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
483 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
484 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
485 (stuff_buffered_input):
486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
487 (last_auto_save, command_loop_1, read_char):
488 Use EMACS_INT, not int, to avoid integer overflow.
489 (record_char): Avoid overflow in total_keys computation.
490 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
491 * keyboard.h: Adjust decls to match defn changes elsewhere.
492 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
493 (Fkey_description, Fdescribe_vector, Flookup_key):
494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
495 (click_position): New function, to check that positions are in range.
496 (Fcurrent_active_maps):
498 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
499 (Faccessible_keymaps, Fkey_description):
500 (preferred_sequence_p):
501 Don't assume fixnum can fit into int.
502 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
503 Check for integer overflow in size calculations.
504 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
505 avoid mishandling large integers.
506 * lisp.h: Adjust decls to match defn changes elsewhere.
507 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
508 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
509 (struct Lisp_Marker):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
511 (clip_to_bounds): Now an inline function, moved here from editfns.c.
512 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
513 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
515 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
516 Assume the arg has valid form, since it always does.
517 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
518 unsigned integer system type.
519 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
520 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
522 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
523 (duration_to_sec_usec): New decl.
524 * lread.c (read_from_string_index, read_from_string_index_byte)
525 (read_from_string_limit, readchar, unreadchar, openp)
526 (read_internal_start, read1, oblookup):
527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
528 (Fload, readevalloop, Feval_buffer, Feval_region):
529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
530 (openp): Check for out-of-range argument to 'access'.
531 (read1): Use int, not EMACS_INT, where int is wide enough.
532 Don't assume fixnum fits into int.
533 Fix off-by-one error that can read outside a buffer.
534 (read_filtered_event): Use duration_to_sec_usec
535 to do proper overflow checking on durations.
536 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
538 (Fexecute_kbd_macro):
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
541 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
542 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
543 (set_marker_both, set_marker_restricted_both, marker_position)
544 (marker_byte_position, Fbuffer_has_markers_at):
545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
546 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
547 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
548 It now merely ensures that the menu is large enough, without
549 necessarily growing it, as this avoids some integer overflow issues.
551 (keymap_panes, parse_single_submenu, Fx_popup_menu):
552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
553 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
554 Use SAFE_ALLOCA_LISP, not alloca.
555 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
556 to EMACS_INT. Check that fixnums are in proper range for system types.
557 * minibuf.c (minibuf_prompt_width, string_to_object)
558 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
559 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
561 (get_minibuffer, read_minibuf_unwind):
562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
563 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
564 this simplifies overflow checking. All callers changed.
565 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
568 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
569 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
570 Check that fixnums are in proper range for system types.
571 (Fx_create_frame, Fx_show_tip):
572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
573 * nsfont.m (ns_findfonts, nsfont_list_family):
574 Don't assume fixnum fits in long.
575 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
577 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
579 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
581 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
582 (PRINTDECLARE, PRINTPREPARE):
583 (strout, print_string):
584 (print, print_preprocess, print_check_string_charset_prop)
586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
588 (temp_output_buffer_setup, Fprin1_to_string, print_object):
589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
590 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
591 (printchar, strout): Use xpalloc to catch size calculation overflow.
592 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
593 (print_error_message): Use SAFE_ALLOCA, not alloca.
594 (print_object): Use int, not EMACS_INT, where int is wide enough.
595 (print_depth, new_backquote_output, print_number_index):
596 Use ptrdiff_t, not int, where int might not be wide enough.
597 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
598 (Fset_process_window_size, Fformat_network_address)
599 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
601 Check that fixnums are in proper range for system types.
602 (Fsignal_process): Simplify by avoiding a goto.
603 Check for process-ids out of pid_t range rather than relying on
605 (process_tick, update_tick): Use EMACS_INT, not int.
606 (Fformat_network_address, read_process_output, send_process)
607 (Fprocess_send_region, status_notify):
608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
609 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
610 (wait_reading_process_output, read_process_output, exec_sentinel):
611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
612 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
613 (Faccept_process_output): Use duration_to_sec_usec to do proper
614 overflow checking on durations.
615 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
616 Don't assume pid_t fits in int.
617 * process.h (struct Lisp_Process): Members tick and update_tick
618 are now of type EMACS_INT, not int.
619 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
620 configured --with-wide-int.
621 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
622 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
623 * search.c (looking_at_1, string_match_1):
624 (fast_string_match, fast_c_string_match_ignore_case)
625 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
626 (scan_newline, find_before_next_newline, search_command)
627 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
628 (set_search_regs, wordify):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (string_match_1, search_buffer, set_search_regs):
634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
635 (wordify): Check for overflow in size calculation.
636 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
637 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
638 Check that fixnums are in proper range for system types.
639 * sound.c (struct sound_device)
640 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
642 (Fplay_sound_internal):
643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
644 * syntax.c (struct lisp_parse_state, find_start_modiff)
645 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
646 (Fparse_partial_sexp):
647 Don't assume fixnums can fit in int.
648 (struct lisp_parse_state, find_start_pos, find_start_value)
649 (find_start_value_byte, find_start_begv)
650 (update_syntax_table, char_quoted, dec_bytepos)
651 (find_defun_start, prev_char_comend_first, back_comment):
652 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
653 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
655 (Finternal_describe_syntax_value): Check that match_lisp is a
656 character, not an integer, since the code stuffs it into int.
657 (scan_words, scan_sexps_forward):
658 Check that fixnums are in proper range for system types.
660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
661 (scan_sexps_forward):
662 Use CHARACTERP, not INTEGERP, since the value must fit into int.
663 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
664 * syntax.h: Adjust decls to match defn changes elsewhere.
666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
667 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
668 MOST_POSITIVE_FIXNUM.
669 * sysdep.c (wait_for_termination_1, wait_for_termination)
670 (interruptible_wait_for_termination, mkdir):
671 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
672 (emacs_read, emacs_write):
673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
674 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
675 and double all fit in int.
676 * term.c (set_tty_color_mode):
677 Check that fixnums are in proper range for system types.
678 * termhooks.h (struct input_event):
679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
680 * textprop.c (validate_interval_range, interval_of)
681 (Fadd_text_properties, set_text_properties_1)
682 (Fremove_text_properties, Fremove_list_of_text_properties)
683 (Ftext_property_any, Ftext_property_not_all)
684 (copy_text_properties, text_property_list, extend_property_ranges)
685 (verify_interval_modification):
686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
687 (Fnext_single_char_property_change)
688 (Fprevious_single_char_property_change):
689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
690 (copy_text_properties):
691 Check for integer overflow in index calculation.
692 * undo.c (last_boundary_position, record_point, record_insert)
693 (record_delete, record_marker_adjustment, record_change)
694 (record_property_change):
695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
696 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
698 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
699 (Fx_hide_tip, Fx_file_dialog):
700 * w32menu.c (set_frame_menubar):
701 Use ptrdiff_t, not int, for consistency with rest of code.
702 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
703 (select_window, Fdelete_other_windows_internal)
704 (window_scroll_pixel_based, window_scroll_line_based)
705 (Frecenter, Fset_window_configuration):
706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
707 (Fset_window_hscroll, run_window_configuration_change_hook)
708 (set_window_buffer, temp_output_buffer_show, scroll_command)
709 (Fscroll_other_window, Frecenter):
710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
711 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
712 Don't assume fixnum fits in int.
713 (Fset_window_scroll_bars):
714 Check that fixnums are in proper range for system types.
715 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
716 (string_pos, c_string_pos, number_of_chars, init_iterator)
717 (in_ellipses_for_invisible_text_p, init_from_display_pos)
718 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
719 (compute_display_string_end, handle_face_prop)
720 (face_before_or_after_it_pos, handle_invisible_prop)
721 (handle_display_prop, handle_display_spec, handle_single_display_spec)
722 (display_prop_intangible_p, string_buffer_position_lim)
723 (string_buffer_position, handle_composition_prop, load_overlay_strings)
724 (get_overlay_strings_1, get_overlay_strings)
725 (iterate_out_of_display_property, forward_to_next_line_start)
726 (back_to_previous_visible_line_start, reseat, reseat_to_string)
727 (get_next_display_element, set_iterator_to_next)
728 (get_visually_first_element, compute_stop_pos_backwards)
729 (handle_stop_backwards, next_element_from_buffer)
730 (move_it_in_display_line_to, move_it_in_display_line)
731 (move_it_to, move_it_vertically_backward, move_it_by_lines)
732 (add_to_log, message_dolog, message_log_check_duplicate)
733 (message2, message2_nolog, message3, message3_nolog
734 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
735 (current_message_1, truncate_echo_area, truncate_message_1)
736 (set_message, set_message_1, store_mode_line_noprop)
737 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
738 (text_outside_line_unchanged_p, check_point_in_composition)
739 (reconsider_clip_changes)
740 (redisplay_internal, set_cursor_from_row, try_scrolling)
741 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
742 (redisplay_window, find_last_unchanged_at_beg_row)
743 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
744 (trailing_whitespace_p, find_row_edges, display_line)
745 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
746 (display_mode_element, store_mode_line_string)
747 (pint2str, pint2hrstr, decode_mode_spec)
748 (display_count_lines, display_string, draw_glyphs)
749 (x_produce_glyphs, x_insert_glyphs)
750 (rows_from_pos_range, mouse_face_from_buffer_pos)
751 (fast_find_string_pos, mouse_face_from_string_pos)
752 (note_mode_line_or_margin_highlight, note_mouse_highlight):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 (safe_call, init_from_display_pos, handle_fontified_prop)
755 (handle_single_display_spec, load_overlay_strings)
756 (with_echo_area_buffer, setup_echo_area_for_printing)
757 (display_echo_area, echo_area_display)
758 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
759 (update_tool_bar, hscroll_window_tree, redisplay_internal)
760 (redisplay_window, dump_glyph_row, display_mode_line)
761 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
762 (handle_display_spec, display_prop_string_p):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 (handle_single_display_spec, build_desired_tool_bar_string)
765 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
766 (get_specified_cursor_type):
767 Check that fixnums are in proper range for system types.
768 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
770 Don't assume fixnums fit in int.
771 (compare_overlay_entries):
772 Avoid mishandling comparisons due to subtraction overflow.
773 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
774 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
775 (handle_tool_bar_click):
776 Use int, not unsigned, since we prefer signed and the signedness
778 (get_next_display_element, next_element_from_display_vector):
779 Use int, not EMACS_INT, when int is wide enough.
780 (start_hourglass): Use duration_to_sec_usec to do proper
781 overflow checking on durations.
782 * xfaces.c (Fbitmap_spec_p):
783 Check that fixnums are in proper range for system types.
784 (compare_fonts_by_sort_order):
785 Avoid mishandling comparisons due to subtraction overflow.
786 (Fx_family_fonts, realize_basic_faces):
787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
789 Don't assume fixnum fits in int.
790 Use SAFE_ALLOCA_LISP, not alloca.
791 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
792 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
793 (face_at_buffer_position, face_for_overlay_string)
794 (face_at_string_position):
795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
796 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
797 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
799 Check that fixnums are in proper range for system types.
800 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
801 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
803 (Fx_change_window_property): Don't assume fixnums fit in int.
804 * xfont.c (xfont_chars_supported):
805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
806 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
807 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
809 * xml.c (parse_region):
810 * xrdb.c (magic_file_p):
811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
812 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
813 (x_get_local_selection, x_reply_selection_request)
814 (x_handle_selection_request, wait_for_property_change):
815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
816 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
817 short is wide enough.
818 (x_send_client_event): Don't assume fixnum fits in int.
819 * xterm.c (x_x_to_emacs_modifiers):
820 Don't assume EMACS_INT overflows nicely into int.
821 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
823 (handle_one_xevent): NATNUMP can eval its arg twice.
824 (x_connection_closed):
825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
826 * xterm.h: Adjust decls to match defn changes elsewhere.
827 (struct scroll_bar): Use struct vectorlike_header
828 rather than rolling our own approximation.
829 (SCROLL_BAR_VEC_SIZE): Remove; not used.
831 2012-05-25 Glenn Morris <rgm@gnu.org>
833 * lisp.mk (lisp): Update for more files being compiled now.
835 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
837 * lread.c: Remove `read_pure' which makes no difference.
838 (read_pure): Remove var.
839 (unreadpure): Remove function.
840 (readevalloop): Don't call read_list with -1 flag.
841 (read1, read_vector): Don't test read_pure any more.
842 (read_list): Simplify.
844 * fileio.c, character.h: Minor style tweaks.
846 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
848 * window.h (clip_changed): Remove useless declaration.
850 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
852 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
853 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
855 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
858 This directory predates autoconf and is no longer needed nowadays.
859 Move its few remaining bits of functionality to where they're needed.
860 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
861 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
862 * m/template.h: Remove.
863 * Makefile.in (M_FILE): Remove. All uses removed.
864 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
865 * lisp.h (USE_LSB_TAG):
866 * mem-limits.h (EXCEEDS_LISP_PTR):
867 Use VAL_MAX, not VALBITS, in #if.
868 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
869 (EMACS_UINT): Define unconditionally now.
870 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
871 (BITS_PER_EMACS_INT): New constants, replacing
872 what used to be in config.h, but not useful in #if.
873 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
874 define them any more.
875 (VAL_MAX): New macro.
877 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
878 BITS_PER_EMACS_INT, in #if.
879 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
880 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
881 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
882 * s/ms-w32.h (DATA_START):
883 Move here from removed file m/intel386.h.
884 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
885 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
887 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
890 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
891 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
893 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
894 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
895 * textprop.c, tparam.c (NULL): Remove.
896 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
897 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
898 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
899 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
900 * xterm.c (input_signal_count): Assume volatile works.
902 2012-05-21 Ken Brown <kbrown@cornell.edu>
904 * xgselect.c (xg_select): Fix first argument in call to 'select'
907 2012-05-20 Ken Brown <kbrown@cornell.edu>
909 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
910 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
912 2012-05-19 Ken Brown <kbrown@cornell.edu>
914 * xfns.c (x_in_use): Remove `static' qualifier.
915 * xterm.h (x_in_use): Declare.
916 * xgselect.c: Include xterm.h.
917 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
918 and `display_arg' (bug#9754).
920 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
922 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
924 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
925 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
927 2012-05-18 Eli Zaretskii <eliz@gnu.org>
929 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
931 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
932 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
934 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
935 reference to image_cache->refcount.
936 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
938 2012-05-17 Juri Linkov <juri@jurta.org>
940 * search.c (Fword_search_regexp, Fword_search_backward)
941 (Fword_search_forward, Fword_search_backward_lax)
942 (Fword_search_forward_lax): Move functions to isearch.el
943 (bug#10145, bug#11381).
945 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
947 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
949 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
951 * lread.c (init_obarray): Declare Qt and Qnil as special.
953 2012-05-14 Glenn Morris <rgm@gnu.org>
955 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
956 Put "libexec" before "bin", for the sake of init_callproc_1.
958 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
960 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
962 * unexaix.c: Port to more-recent AIX compilers.
963 (report_error, report_error_1, make_hdr, copy_sym)
964 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
965 Make arguments const char *, not char *, to avoid violations of C
966 standard and to fix some AIX warnings reported by Gilles Pion.
968 2012-05-14 Eli Zaretskii <eliz@gnu.org>
970 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
971 already have overlays loaded.
972 (handle_single_display_spec): Before returning without displaying
973 fringe bitmap, synchronize the bidi iterator with the main display
974 iterator, by calling iterate_out_of_display_property.
975 (iterate_out_of_display_property): Detect buffer iteration by
976 testing that it->string is a Lisp string.
977 (get_next_display_element): When the current object is exhausted,
978 and there's something on it->stack, call set_iterator_to_next to
979 proceed with what's on the stack, instead of returning zero.
980 (set_iterator_to_next): If called at the end of a Lisp string,
981 proceed to consider_string_end without incrementing string
982 position. Don't increment display vector index past the end of
983 the display vector. (Bug#11417)
984 (pos_visible_p): Don't report a position visible when move_it_to
985 stopped at the last line of window, which happens to be scanned
986 backwards by the bidi iteration. (Bug#11464)
988 2012-05-14 Eli Zaretskii <eliz@gnu.org>
990 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
991 and right-margin display specs even if the spec is invalid or we
992 are on a TTY, and thus unable to display on the fringes. That's
993 because the text with the property will not be displayed anyway,
994 so we need to signal to the caller that this is a "replacing"
995 display spec. This fixes display when the spec is invalid or we
998 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1000 * unexaix.c (make_hdr): Fix typo in prototype.
1001 This bug broke the build on AIX. Problem reported by Gilles Pion.
1003 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1005 * keyboard.c (kbd_buffer_get_event): Read special events also in
1006 batch mode. (Bug#11415)
1008 2012-05-12 Glenn Morris <rgm@gnu.org>
1010 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1012 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1014 * lisp.mk (lisp): Add newcomment.elc.
1016 2012-05-12 Glenn Morris <rgm@gnu.org>
1018 * Makefile.in (MKDIR_P): New, set by configure.
1019 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1021 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1023 Remove unused function hourglass_started.
1024 * dispextern.h (hourglass_started):
1025 * w32fns.c (hourglass_started):
1026 * xdisp.c (hourglass_started): Remove.
1028 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1030 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1031 Update dependencies.
1033 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1035 * xgselect.c (xg_select): Put maxfds+1 into a var.
1036 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1038 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1040 2012-05-10 Dave Abrahams <dave@boostpro.com>
1042 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1043 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1045 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1047 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1048 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1049 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1050 Initialize xd_registered_buses.
1052 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1054 Untag more efficiently if USE_LSB_TAG.
1055 This is based on a proposal by YAMAMOTO Mitsuharu in
1056 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1057 For an admittedly artificial (nth 8000 longlist) benchmark on
1058 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1059 Emacs's overall text size by 1%.
1060 * lisp.h (XUNTAG): New macro.
1061 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1062 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1063 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1064 * eval.c (Fautoload):
1065 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1066 * frame.h (XFRAME): Use XUNTAG.
1068 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1069 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1070 Remove unportable assumptions about print widths of types like
1072 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1073 intptr_t when converting between pointer and integer, to avoid GCC
1074 warnings about wrong width.
1076 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1078 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1079 stack for each reader_thread, instead of defaulting to 8MB
1080 determined by the linker. This avoids failures in creating
1081 subprocesses on Windows 7, see the discussion in this thread:
1082 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1084 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1086 Fix up display of the *Minibuf-0* buffer in the mini window.
1087 * keyboard.c (read_char): Don't clear the echo area if there's no
1089 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1090 contents of *Minibuf-0*) if there's no message displayed in its stead.
1092 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1094 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1097 2012-05-06 Chong Yidong <cyd@gnu.org>
1099 * lisp.mk (lisp): Update.
1101 2012-05-05 Jim Meyering <meyering@redhat.com>
1103 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1105 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1107 * data.c (PUT_ERROR): New macro.
1108 (syms_of_data): Use it. Add new error type `user-error'.
1109 * undo.c (user_error): New function.
1110 (Fprimitive_undo): Use it.
1111 * print.c (print_error_message): Adjust print style for `user-error'.
1112 * keyboard.c (user_error): New function.
1113 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1115 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1117 Do not limit current-time-string to years 1000..9999.
1118 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1119 (Fcurrent_time_string): Support any year that is supported by the
1120 underlying localtime representation. Don't use asctime, as it
1121 has undefined behavior for years outside the range -999..9999.
1123 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1125 Fix race conditions involving setenv, gmtime, localtime, asctime.
1126 Without this fix, interrupts could mess up code that uses these
1127 nonreentrant functions, since setting TZ invalidates existing
1128 tm_zone or tzname values, and since most of these functions return
1129 pointers to static storage.
1130 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1131 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1132 Grow the critical sections to include not just invoking
1133 localtime/gmtime, but also accessing these functions' results
1134 including their tm_zone values if any, and any related TZ setting.
1135 (format_time_string): Last arg is now struct tm *, not struct tm **,
1136 so that the struct tm is saved in the critical section.
1137 All callers changed. Simplify allocation of initial buffer, partly
1138 motivated by the fact that memory allocation needs to be outside
1139 the critical section.
1141 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1143 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1144 with RESET_INTERVAL.
1146 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1147 Remove duplicated buffer name initialization.
1149 2012-05-02 Jim Meyering <jim@meyering.net>
1151 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1153 * xfns.c (x_window): Use xstrdup (Bug#11375).
1155 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1157 * xdisp.c (pos_visible_p): If already at a newline from the
1158 display string before the 'while' loop, don't walk back the glyphs
1159 from it3.glyph_row. Solves assertion violation when the display
1160 string begins with a newline (egg.el). (Bug#11367)
1162 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1164 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1167 2012-05-01 Glenn Morris <rgm@gnu.org>
1169 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1170 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1171 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1172 All were removed before 23.1.
1174 * dispnew.c: Remove HAVE_LIBNCURSES test;
1175 it is always true on relevant platforms.
1177 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1178 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1180 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1182 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1184 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1185 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1188 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1190 Do not avoid creating empty evaporating overlays (Bug#9642).
1191 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1192 That is, do not delete an evaporating overlay if it becomes
1193 empty after its bounds are adjusted to fit within its buffer.
1194 This fix caused other problems, and I'm reverting it until we get
1195 to the bottom of them.
1197 2012-04-27 Chong Yidong <cyd@gnu.org>
1199 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1201 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1203 * xdisp.c (pos_visible_p): If the window start position is beyond
1204 ZV, start the display from buffer beginning. Prevents assertion
1205 violation in init_iterator when the minibuffer window is scrolled
1208 * window.c (window_scroll_pixel_based): Likewise.
1210 2012-04-27 Chong Yidong <cyd@gnu.org>
1212 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1214 2012-04-27 Glenn Morris <rgm@gnu.org>
1216 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1217 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1219 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1221 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1222 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1224 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1226 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1227 display element, check also the underlying string or buffer
1228 character. (Bug#11341)
1230 * w32menu.c: Include w32heap.h.
1231 (add_menu_item): If the call to AppendMenuW (via
1232 unicode_append_menu) fails, disable Unicode menus only if we are
1233 running on Windows 9X/Me.
1235 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1237 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1238 (xgetint): Add missing shift for LSB tags.
1240 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1242 * keyboard.c (read_char): Don't wipe echo area for select window
1243 events: These might get delayed via `mouse-autoselect-window'
1246 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1248 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1249 manipulation of :loaded-from data.
1251 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1253 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1254 now a cons (bug#11311).
1256 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1258 Do not create empty overlays with the evaporate property (Bug#9642).
1259 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1260 if it becomes empty after its bounds are adjusted to fit within
1261 its buffer. Without this fix, in a nonempty buffer (let ((o
1262 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1263 yields an empty overlay that has the evaporate property, which is
1264 not supposed to happen.
1266 Fix minor GTK3 problems found by static checking.
1267 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1268 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1269 (struct _EmacsFixedClass, emacs_fixed_get_type):
1270 Move decls here from emacsgtkfixed.h, since they needn't be public.
1271 (emacs_fixed_get_type): Now static.
1272 (emacs_fixed_class_init): Omit unused local.
1273 (emacs_fixed_child_type): Remove; unused.
1274 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1275 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1276 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1277 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1278 (EMACS_FIXED_GET_CLASS): Remove; unused.
1279 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1281 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1282 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1284 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1286 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1287 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1288 (__malloc_size_t, __malloc_ptrdiff_t):
1289 Remove. All uses removed, replaced by the definiens if needed,
1290 since we can assume C89 or better now.
1291 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1292 (protect_malloc_state, align, get_contiguous_space)
1293 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1294 (malloc_atfork_handler_child, malloc_enable_thread)
1295 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1296 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1297 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1298 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1299 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1300 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1301 Define using prototypes, not old style.
1302 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1303 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1304 (align): Don't assume that signed integer overflow wraps around.
1305 Omit unused local var.
1306 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1307 (_free_internal_nolock, memalign, mallochook, reallochook):
1308 Omit no-longer-needed casts.
1309 (valloc): Use getpagesize, not __getpagesize.
1310 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1311 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1313 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1315 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1317 Move functions from C to Lisp. Make non-blocking method calls
1318 the default. Implement further D-Bus standard interfaces.
1320 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1321 (QCdbus_request_name_allow_replacement)
1322 (QCdbus_request_name_replace_existing)
1323 (QCdbus_request_name_do_not_queue)
1324 (QCdbus_request_name_reply_primary_owner)
1325 (QCdbus_request_name_reply_in_queue)
1326 (QCdbus_request_name_reply_exists)
1327 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1328 (QCdbus_registered_serial, QCdbus_registered_method)
1329 (QCdbus_registered_signal): New Lisp objects.
1330 (XD_DEBUG_MESSAGE): Use sizeof.
1331 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1332 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1333 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1334 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1335 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1336 (xd_signature, xd_append_arg): Allow float for integer types.
1337 (xd_get_connection_references): New function.
1338 (xd_get_connection_address): Rename from xd_initialize.
1339 Return cached address.
1340 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1341 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1343 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1344 Return number of refcounts.
1345 (Fdbus_get_unique_name): Make stronger parameter check.
1346 (Fdbus_message_internal): New defun.
1347 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1348 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1349 (Fdbus_send_signal, Fdbus_register_service)
1350 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1351 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1352 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1353 (Vdbus_compiled_version, Vdbus_runtime_version)
1354 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1355 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1356 (Vdbus_message_type_signal): New defvars.
1357 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1360 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1362 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1363 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1364 Do not assume ptrdiff_t is the same width as 'int'.
1366 * alloc.c: Handle unusual debugging option combinations.
1367 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1368 since the two debugging options are incompatible.
1369 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1371 (mem_init, mem_insert, mem_insert_fixup):
1372 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1373 (NEED_MEM_INSERT): Remove; no longer needed.
1375 2012-04-22 Leo Liu <sdl.web@gmail.com>
1377 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1379 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1381 * sysdep.c [__FreeBSD__]: Minor cleanups.
1382 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1383 Use Emacs indenting style more consistently. Avoid some casts.
1384 Use 'double' consistently rather than mixing 'float' and 'double'.
1386 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1388 * sysdep.c (list_system_processes, system_process_attributes):
1389 Add implementation for FreeBSD (Bug#5243).
1391 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1393 * lisp.mk (lisp): Update.
1395 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1397 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1398 It is never used otherwise.
1400 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1402 * print.c (print_preprocess): Only check print_depth if print-circle
1404 (print_object): Check for cycles even when print-circle is nil and
1405 print-gensym is t, but only check print_depth if print-circle is nil.
1407 2012-04-20 Chong Yidong <cyd@gnu.org>
1409 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1410 set the status to "failed" and ensure that sentinel is run.
1412 2012-04-20 Glenn Morris <rgm@gnu.org>
1414 * process.c (Fset_process_inherit_coding_system_flag)
1415 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1416 (Fmake_network_process, Fmake_serial_process): Doc fix.
1418 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1420 * xdisp.c (string_buffer_position_lim): Limit starting position to
1422 (set_cursor_from_row): If called for a mode-line or header-line
1423 row, return zero immediately.
1424 (try_cursor_movement): If inside continuation line, don't back up
1425 farther than the first row after the header line, if any.
1426 Don't consider the header-line row as "partially visible", even if
1427 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1429 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1431 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1434 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1435 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1437 configure: new option --enable-gcc-warnings (Bug#11207)
1438 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1439 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1440 (ALL_CFLAGS): Use new macros rather than old.
1441 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1442 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1443 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1444 -Wunused-result, -Wunused-variable. This should go away once
1445 the Emacs and Gnulib regex code is merged.
1446 (xmalloc, xrealloc): Now static.
1448 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1450 * dired.c (Fsystem_groups): Remove unused local.
1452 2012-04-17 Glenn Morris <rgm@gnu.org>
1454 * dired.c (Fsystem_users): Doc fix.
1456 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1458 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1459 (syms_of_dired): Add them.
1461 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1463 Fix minor alloc.c problems found by static checking.
1464 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1465 New extern decls, to avoid calling undeclared functions.
1466 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1467 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1468 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1469 (NEED_MEM_INSERT): New macro.
1470 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1471 Remove one incorrect comment and fix another.
1473 Fix minor ralloc.c problems found by static checking.
1474 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1475 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1476 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1477 (r_alloc_sbrk): Now static.
1479 Improve ralloc.c interface checking.
1480 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1481 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1482 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1483 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1484 [REL_ALLOC]: ... to here, to check interface.
1485 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1486 Remove decls. This fixes an "It stinks!".
1488 * alloc.c (which_symbols): Fix alignment issue / type clash.
1490 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1492 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1493 (struct Lisp_Misc_Any): Likewise.
1494 (struct Lisp_Free): Likewise.
1495 * alloc.c (union aligned_Lisp_Symbol): Define.
1496 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1497 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1498 (union aligned_Lisp_Misc): Define.
1499 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1500 aligned_Lisp_Misc instead of union Lisp_Misc.
1501 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1503 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1505 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1506 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1507 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1508 * s/netbsd.h, s/sol2-6.h:
1509 Remove definition of GC_MARK_STACK, since the default now works.
1510 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1511 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1512 no longer the default.
1513 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1515 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1517 * lread.c (lisp_file_lexically_bound_p):
1518 Fix hang at ";-*-\n" (bug#11238).
1520 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1522 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1523 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1525 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1527 * nsterm.m (constrainFrameRect): Always constrain when there is only
1528 one screen (Bug#10962).
1530 2012-04-13 Ken Brown <kbrown@cornell.edu>
1532 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1534 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1536 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1538 2012-04-11 Daniel Colascione <dancol@dancol.org>
1540 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1541 against is gone. It's better to use vfork now so that when Cygwin
1542 gains a new, working vfork, we use it automatically (bug#10398).
1544 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1546 * window.c (save_window_save): Obey window-point-insertion-type.
1548 2012-04-11 Glenn Morris <rgm@gnu.org>
1550 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1552 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1554 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1556 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1558 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1559 (force_quit_count): New var.
1560 (handle_interrupt): Use it.
1562 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1564 * w32.c (w32_delayed_load): Record the full path of the library
1565 being loaded (bug#10424).
1567 2012-04-09 Glenn Morris <rgm@gnu.org>
1569 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1570 not just in the obarray, before snarfing them. (Bug#11036)
1572 * Makefile.in ($(leimdir)/leim-list.el):
1573 Pass EMACS rather than BUILT_EMACS.
1575 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1577 * process.c (make_process):
1578 * process.h: Add integer `gnutls_handshakes_tried' member to
1581 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1582 Add convenience `GNUTLS_LOG2i' macro.
1584 * gnutls.c (gnutls_log_function2i): Convenience log function.
1585 (emacs_gnutls_read): Use new log functions,
1586 `gnutls_handshakes_tried' process member, and
1587 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1588 attempts per process (connection).
1590 2012-04-09 Chong Yidong <cyd@gnu.org>
1592 * eval.c (Fuser_variable_p, user_variable_p_eh)
1593 (lisp_indirect_variable): Functions deleted.
1594 (Fdefvar): Caller changed.
1596 * callint.c (Finteractive, Fcall_interactively):
1597 * minibuf.c (Fread_variable): Callers changed.
1599 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1601 * xdisp.c (set_cursor_from_row): If the display string appears in
1602 the buffer at position that is closer to point than the position
1603 after the display string, display the cursor on the first glyph of
1604 the display string. Fixes cursor display when a 'display' text
1605 property immediately follows invisible text. (Bug#11094)
1607 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1609 composite.c: use 'double' consistently
1610 * composite.c (get_composition_id): Use 'double' consistently
1611 instead of converting 'float' to 'double' and vice versa; this is
1612 easier to understand and avoids a GCC warning.
1614 2012-04-09 Glenn Morris <rgm@gnu.org>
1616 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1617 preparation for dumping it with emacs. (Bug#4789)
1618 (leimdir): New variable.
1619 ($(leimdir)/leim-list.el): New rule.
1620 (emacs$(EXEEXT)): Depend on leim-list.el.
1622 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1623 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1624 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1626 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1628 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1631 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1633 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1634 Remove unused local variable.
1636 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1638 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1639 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1640 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1641 objects, as mark_maybe_pointer will catch them otherwise.
1642 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1643 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1645 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1647 Fix typo that broke non-Windows builds.
1648 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1650 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1652 Support building on MS-Windows with libxml2.
1654 * makefile.w32-in (OBJ2): Add xml.$(O).
1655 (GLOBAL_SOURCES): Add xml.c.
1656 ($(BLD)/xml.$(O)): New dependency list.
1658 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1659 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1660 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1661 [!WINDOWSNT]: New macros.
1662 (init_libxml2_functions, libxml2_loaded_p): New functions.
1663 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1664 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1665 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1666 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1668 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1669 Call init_libxml2_functions before calling libxml2 functions.
1670 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1672 * emacs.c: Don't include libxml/parser.h.
1673 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1674 xmlCleanupParser directly.
1676 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1678 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1680 * indent.c (Fvertical_motion): If there is a display string at
1681 point, use it.vpos to compute how many lines to backtrack after
1682 move_it_to point. (Bug#11133)
1684 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1686 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1687 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1688 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1689 macros related to unification of CJK characters. For the details,
1690 see the discussion following the message here:
1691 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1693 2012-04-04 Chong Yidong <cyd@gnu.org>
1695 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1697 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1699 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1700 instead of alloca. (Bug#11138)
1702 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1704 * w32menu.c (is_simple_dialog): Properly check lisp types.
1707 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1709 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1710 position we get to after a call to move_it_to fails the
1711 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1712 only if we wind up in a string from display property. (Bug#11063)
1714 * window.c (Fdelete_other_windows_internal): Invalidate the row
1715 and column information about mouse highlight, so that redisplay
1716 restores it after reallocating the glyph matrices. (Bug#7464)
1718 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1719 string comes from a `display' text property, use the buffer
1720 position of that property as if we actually saw that position in
1722 (move_it_by_lines): Remove the assertion that
1723 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1724 violated when there's a before-string at the beginning of a line.
1727 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1729 * xdisp.c (append_space_for_newline): If the default face was
1730 remapped, use the remapped face for the appended newline.
1731 (extend_face_to_end_of_line): Use the remapped default face for
1732 extending the face to the end of the line.
1733 (display_line): Call extend_face_to_end_of_line when the default
1734 face was remapped. (Bug#11068)
1736 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1738 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1740 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1742 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1744 2012-03-27 Glenn Morris <rgm@gnu.org>
1746 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1749 2012-03-26 Kenichi Handa <handa@m17n.org>
1751 * dispextern.h (struct glyph): Fix previous change. Change the
1752 bit length of glyphless.ch to 25 (Bug#11082).
1754 2012-03-26 Chong Yidong <cyd@gnu.org>
1756 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1757 (command_loop_1): Use it; inhibit selection update for
1758 handle-select-window too (Bug#8996).
1760 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1762 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1764 2012-03-25 Kenichi Handa <handa@m17n.org>
1766 * dispextern.h (struct glyph): Change the bit length of
1767 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1769 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1771 * s/ms-w32.h (tzname): Include time.h before redirecting to
1772 _tzname. Fixes the MSVC build. (Bug#9960)
1774 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1776 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1779 * xterm.c (XTread_socket): Only modify handling_signal if
1780 !SYNC_INPUT. (Bug#11080)
1782 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1784 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1785 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1786 when fetching a multibyte character consumes more bytes than
1787 CHAR_BYTES returns, due to unification of CJK characters in
1788 string_char. (Bug#11073)
1790 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1792 * process.c (wait_reading_process_output): Handle pty disconnect
1793 by refraining from sending oneself a SIGCHLD (bug#10933).
1795 2012-03-22 Chong Yidong <cyd@gnu.org>
1797 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1799 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1800 Mark string as coming from a prefix property.
1801 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1802 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1804 2012-03-21 Chong Yidong <cyd@gnu.org>
1806 * xfaces.c (Vface_remapping_alist): Doc fix.
1808 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1810 * w32proc.c (Fw32_set_console_codepage)
1811 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1814 2012-03-20 Chong Yidong <cyd@gnu.org>
1816 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1817 to reflect default non-nil value of redisplay-dont-pause.
1819 2012-03-19 Kenichi Handa <handa@m17n.org>
1821 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1822 it fit in a valid range (Bug#11003).
1824 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1826 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1827 that is not from display property, accept the row as a "cursor
1828 row" if one of the string's character has a non-nil `cursor'
1829 property. Fixes cursor positioning when there are newlines in
1830 overlay strings, e.g. in icomplete.el. (Bug#11035)
1832 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1834 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1836 2012-03-12 Chong Yidong <cyd@gnu.org>
1838 * eval.c (inhibit_lisp_code): Rename from
1839 inhibit_window_configuration_change_hook; move from window.c.
1841 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1842 * window.c (run_window_configuration_change_hook)
1843 (syms_of_window): Callers changed.
1845 2012-03-11 Chong Yidong <cyd@gnu.org>
1847 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1849 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1851 2012-03-10 Chong Yidong <cyd@gnu.org>
1853 * frame.c (other_visible_frames): Don't assume the selected frame
1854 is visible (Bug#10955).
1856 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1858 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1860 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1862 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1863 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1866 2012-03-03 Glenn Morris <rgm@gnu.org>
1868 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1870 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1872 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1873 position past the first glyph_row that ends at ZV. (Bug#10902)
1874 (redisplay_window, next_element_from_string): Fix typos in
1876 (redisplay_window): Pass to move_it_vertically the margin in
1877 pixels, not in screen lines.
1879 2012-03-02 Glenn Morris <rgm@gnu.org>
1881 * buffer.c (buffer-list-update-hook): Doc fix.
1883 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1885 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1886 push_it before setting up the iterator for the first overlay
1887 string, even if we have an empty string loaded.
1888 (next_overlay_string): If there's an empty string on the iterator
1889 stack, pop the stack. (Bug#10903)
1891 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1893 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1894 Suggested by Stefan Monnier in
1895 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1896 * alloc.c (widen_to_Lisp_Object): New static function.
1897 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1898 and widening them to Lisp_Objects. This would work even if
1899 USE_LSB_TAG is defined and wide integers are used, which might
1900 happen in a future version of Emacs.
1902 2012-02-25 Chong Yidong <cyd@gnu.org>
1904 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1907 * xselect.c (Fx_selection_exists_p): Doc fix.
1908 (x_clipboard_manager_save_all): Print an informative message
1909 before saving to clipboard manager.
1911 2012-02-24 Chong Yidong <cyd@gnu.org>
1913 * keyboard.c (process_special_events): Handle all X selection
1914 requests in kbd_buffer, not just the next one (Bug#8869).
1916 2012-02-23 Chong Yidong <cyd@gnu.org>
1918 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1919 call when setting menu-bar-lines and tool-bar-lines parameters.
1920 (unwind_create_frame_1): New helper function.
1922 * window.c (inhibit_window_configuration_change_hook): New var.
1923 (run_window_configuration_change_hook): Obey it.
1924 (syms_of_window): Initialize it.
1926 2012-02-22 Chong Yidong <cyd@gnu.org>
1928 * xterm.c (x_draw_image_relief): Add missing type check for
1929 Vtool_bar_button_margin (Bug#10743).
1931 2012-02-21 Chong Yidong <cyd@gnu.org>
1933 * fileio.c (Vfile_name_handler_alist): Doc fix.
1935 * buffer.c (Fget_file_buffer): Protect against invalid file
1936 handler return value.
1938 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1940 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1941 when computing $valmask.
1943 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1944 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1945 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1946 It's useless in that case, and it can cause problems on hosts
1947 that allocate halves of EMACS_INT values separately.
1948 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1949 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1950 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1951 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1952 it avoids undefined behavior on hosts where shifting right by more
1953 than the word width has undefined behavior.
1955 2012-02-19 Chong Yidong <cyd@gnu.org>
1957 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1958 (Funhandled_file_name_directory, Ffile_name_as_directory)
1959 (Fdirectory_file_name, Fexpand_file_name)
1960 (Fsubstitute_in_file_name): Protect against invalid file handler
1961 return values (Bug#10845).
1963 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1965 * .gdbinit (pitx): Fix incorrect references to fields of the
1968 2012-02-17 Chong Yidong <cyd@gnu.org>
1970 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1972 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1974 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1975 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1977 2012-02-15 Chong Yidong <cyd@gnu.org>
1979 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1980 marked as special. Also, starting docstrings with * is obsolete.
1982 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1984 * gnutls.c (emacs_gnutls_write): Fix last change.
1986 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1988 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1991 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1993 * keymap.c (Fsingle_key_description): Handle char ranges.
1995 2012-02-12 Chong Yidong <cyd@gnu.org>
1997 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1998 as that creates a dangerous corner case.
2000 * window.c (Fdelete_window_internal): Invalidate the mouse
2001 highlight (Bug#9904).
2003 2012-02-12 Glenn Morris <rgm@gnu.org>
2005 * xselect.c (Fx_own_selection_internal)
2006 (Fx_get_selection_internal, Fx_disown_selection_internal)
2007 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2008 * nsselect.m (Fx_own_selection_internal)
2009 (Fx_disown_selection_internal, Fx_selection_exists_p)
2010 (Fx_selection_owner_p, Fx_get_selection_internal):
2011 Sync docs and argument specs with the xselect.c versions.
2013 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2015 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2017 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2019 * w32select.c (Fx_selection_exists_p): Sync doc string and
2020 argument list with xselect.c. (Bug#10783)
2022 * w16select.c (Fx_selection_exists_p): Sync doc string and
2023 argument list with xselect.c. (Bug#10783)
2025 2012-02-10 Glenn Morris <rgm@gnu.org>
2027 * fns.c (Fsecure_hash): Doc fix.
2029 2012-02-09 Kenichi Handa <handa@m17n.org>
2031 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2033 2012-02-07 Chong Yidong <cyd@gnu.org>
2035 * buffer.c (Fbuffer_local_variables)
2036 (buffer_lisp_local_variables): Handle unbound vars correctly;
2037 don't let Qunbound leak into Lisp.
2039 2012-02-07 Glenn Morris <rgm@gnu.org>
2041 * image.c (Fimagemagick_types): Doc fix.
2043 * image.c (imagemagick-render-type): Change it from a lisp object
2044 to an integer. Move the doc here from the lisp manual.
2045 Treat all values not equal to 0 the same.
2047 2012-02-06 Chong Yidong <cyd@gnu.org>
2049 * doc.c (store_function_docstring): Avoid applying docstring of
2050 alias to base function (Bug#2603).
2052 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2054 * .gdbinit (pp1, pv1): Remove redundant defines.
2057 2012-02-04 Chong Yidong <cyd@gnu.org>
2059 * nsterm.m: Declare a global (Bug#10694).
2061 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2063 * w32.c (get_emacs_configuration_options):
2064 Include --enable-checking, if specified, in the return value.
2066 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2068 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2069 after rounding frame sizes. (Bug#9723)
2071 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2073 * keyboard.c (adjust_point_for_property): Don't position point
2074 before BEGV. (Bug#10696)
2076 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2078 Handle overflow when computing char display width (Bug#9496).
2079 * character.c (char_width): Return EMACS_INT, not int.
2080 (char_width, c_string_width): Check for overflow when
2081 computing the width; this is possible now that individual
2082 characters can have unbounded width. Problem introduced
2083 by merge from Emacs 23 on 2012-01-19.
2085 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2087 * dbusbind.c (Fdbus_register_method): Mention the return value
2088 :ignore in the docstring.
2090 2012-02-02 Glenn Morris <rgm@gnu.org>
2092 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2094 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2095 Unconditionally set to t. (Bug#10673)
2096 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2097 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2098 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2100 2012-02-02 Kenichi Handa <handa@m17n.org>
2102 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2103 0, do not call append_composite_glyph.
2105 2012-02-02 Kenichi Handa <handa@m17n.org>
2107 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2109 (x_produce_glyphs): If the component of a composition is a null
2110 string, set it->pixel_width to 1 to avoid zero-width glyph.
2112 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2114 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2115 first 2 arguments are identical. This makes inserting large
2116 output from a subprocess an order of magnitude faster on
2117 MS-Windows, where all sbrk'ed memory is always contiguous.
2119 2012-01-31 Glenn Morris <rgm@gnu.org>
2121 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2122 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2123 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2125 2012-01-29 Glenn Morris <rgm@gnu.org>
2127 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2129 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2131 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2133 2012-01-28 Chong Yidong <cyd@gnu.org>
2135 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2137 2012-01-26 Chong Yidong <cyd@gnu.org>
2139 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2141 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2142 repeat counts (Bug#10507).
2144 2012-01-26 Glenn Morris <rgm@gnu.org>
2146 * lread.c (syms_of_lread): Doc fix.
2148 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2150 * coding.c (encode_designation_at_bol): Change return value to
2153 2012-01-25 Chong Yidong <cyd@gnu.org>
2155 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2157 2012-01-21 Chong Yidong <cyd@gnu.org>
2159 * floatfns.c (Fcopysign): Make the second argument non-optional,
2160 since nil is not allowed anyway.
2162 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2164 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2165 (send_process): Likewise.
2167 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2169 * window.c (save_window_save, Fcurrent_window_configuration)
2170 (Vwindow_persistent_parameters): Do not use Qstate.
2171 Rewrite doc-strings.
2173 2012-01-19 Kenichi Handa <handa@m17n.org>
2175 * character.c (char_width): New function.
2176 (Fchar_width, c_string_width, lisp_string_width):
2177 Use char_width (Bug#9496).
2179 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2181 * window.c (Vwindow_persistent_parameters): New variable.
2182 (Fset_window_configuration, save_window_save): Handle persistent
2185 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2187 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2188 thrashing the stack of the thread. (Bug#9087)
2190 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2192 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2194 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2196 * xdisp.c (rows_from_pos_range): Handle the case where the
2197 highlight ends on a newline. (Bug#10464)
2198 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2199 he end column for display of highlight that ends on a newline
2202 2012-01-11 Glenn Morris <rgm@gnu.org>
2204 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2205 from load-path also when installation-directory is nil. (Bug#10208)
2207 2012-01-10 Glenn Morris <rgm@gnu.org>
2209 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2211 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2212 Update template values to be closer to their typical values these days.
2214 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2216 * xdisp.c (rows_from_pos_range): Accept additional argument
2217 DISP_STRING, and accept any glyph in a row whose object is that
2218 string as eligible for mouse highlight. Fixes mouse highlight of
2219 display strings from overlays. (Bug#10464)
2221 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2223 emacs: fix an auto-save permissions race condition (Bug#10400)
2224 * fileio.c (auto_saving_dir_umask): New static var.
2225 (Fmake_directory_internal): Use it.
2226 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2227 creating the directory. The old code temporarily assigns
2228 too-generous permissions to the directory.
2229 (do_auto_save_eh): Clear it.
2230 (Fdo_auto_save): Catch all errors, not just file errors, so
2231 that the var is always cleared.
2233 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2235 * search.c (scan_buffer): Pass character positions to
2236 know_region_cache, not byte positions. (Bug#6540)
2238 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2240 * w32.c (sys_rename): Report EXDEV when rename of a directory
2241 fails because the target is on another logical disk. (Bug#10284)
2243 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2245 * xterm.c (x_embed_request_focus): New function.
2247 * xterm.h: Add prototype.
2249 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2251 2012-01-05 Glenn Morris <rgm@gnu.org>
2253 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2255 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2257 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2258 Load gnutls_transport_set_lowat only if GnuTLS version is below
2260 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2261 GnuTLS versions below 2.11.1.
2263 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2265 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2266 to the doc string advising against its use for altering the way
2267 windows are scrolled.
2269 2011-12-28 Kenichi Handa <handa@m17n.org>
2271 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2272 coding-system ASCII compatible only when it does not produce BOM
2273 on encoding (Bug#10383).
2275 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2277 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2279 (create_and_show_popup_menu): Always use menu_position_func for
2282 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2284 * callint.c (Fcall_interactively): Don't truncate prompt string.
2286 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2288 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2289 property that ends at ZV, so that the bidi iteration could be
2290 resumed from there (after widening). (Bug#10360)
2292 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2294 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2296 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2298 * nsterm.m (x_free_frame_resources):
2299 Release f->output_data.ns->miniimage.
2300 (ns_index_color): Fix indentation. Do not retain
2301 color_table->colors[i].
2303 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2306 * nsfns.m (x_set_background_color): Assign return value from
2307 ns_index_color to face-background instead of NSColor*.
2308 (ns_implicitly_set_icon_type): Fix indentation.
2309 Change assignment in for loop to comparison.
2311 * emacs.c (ns_pool): New variable.
2312 (main): Assign ns_pool.
2313 (Fkill_emacs): Call ns_release_autorelease_pool.
2315 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2316 autorelease fdesc, release fdAttrs and tdict.
2317 (ns_get_covering_families): Release charset.
2318 (ns_findfonts): Release NSFontDescriptor created with new.
2319 (ns_uni_to_glyphs): Fix indentation.
2320 (setString): Release attrStr before assigning new value.
2322 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2324 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2326 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2327 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2329 2011-12-18 David Reitter <reitter@cmu.edu>
2331 * nsterm.m (ns_term_init): Subscribe for notifications
2332 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2333 to method trackingNotification in EmacsMenu.
2335 * nsmenu.m (trackingMenu): New variable.
2336 (trackingNotification): New method (from Aquamacs).
2337 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2338 from Aquamacs (Bug#7030).
2340 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2342 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2343 (symbol_to_nsstring): Fix indentation.
2344 (ns_symbol_to_pb): New function.
2345 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2346 (Fns_rotate_cut_buffers_internal): Remove.
2347 (Fns_store_selection_internal): Rename from
2348 Fns_store_cut_buffer_internal.
2349 (ns_get_foreign_selection, Fx_own_selection_internal)
2350 (Fx_disown_selection_internal, Fx_selection_exists_p)
2351 (Fns_get_selection_internal, Fns_store_selection_internal):
2352 Use ns_symbol_to_pb and check if return value is nil.
2353 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2354 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2355 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2356 renamed to Sns_store_selection_internal.
2357 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2358 and remove this function.
2359 (ns_handle_selection_clear): Remove, never used.
2360 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2363 2011-12-17 Ken Brown <kbrown@cornell.edu>
2365 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2366 GID is unknown (Bug#10257).
2368 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2370 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2371 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2372 which caused a build failure on GNU/Linux IA-64. This problem was
2373 introduced by my 2011-10-07 patch.
2375 2011-12-15 Juri Linkov <juri@jurta.org>
2377 * image.c (imagemagick_error): New function. (Bug#10112)
2378 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2379 Use `imagemagick_error' where ImageMagick functions return
2381 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2384 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2386 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2387 fill background (Bug#8992).
2389 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2391 * window.c (Vwindow_combination_resize)
2392 (Vwindow_combination_limit): Use t instead of non-nil in
2394 (Vrecenter_redisplay): Add first sentence of doc-string on
2396 (Frecenter): Fix doc-string typo.
2398 2011-12-11 Kenichi Handa <handa@m17n.org>
2400 * coding.c (Funencodable_char_position): Pay attention to the
2401 buffer text relocation (Bug#9389).
2403 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2405 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2406 gtk_init (Bug#10100).
2408 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2410 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2411 IT->string is nil. (Bug#10263)
2413 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2415 * nsterm.h (x_free_frame_resources): Declare.
2417 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2418 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2420 * nsterm.h (ns_get_defaults_value): Declare.
2422 * nsterm.m (ns_default): Call ns_get_defaults_value.
2424 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2426 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2429 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2431 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2432 that where the value of an _OBJC_* symbol points to is in the .bss
2433 section (Bug#10240).
2435 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2437 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2438 after the loop to call ccl_driver at least once (Bug#8619).
2440 2011-12-08 Kenichi Handa <handa@m17n.org>
2442 * ftfont.c (get_adstyle_property): Fix previous change
2445 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2447 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2448 dirs from the default value of EMACSLOADPATH (bug#10208).
2450 2011-12-07 Glenn Morris <rgm@gnu.org>
2452 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2453 installation and source directories as well. (Bug#10208)
2455 2011-12-06 Chong Yidong <cyd@gnu.org>
2457 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2459 2011-12-06 Glenn Morris <rgm@gnu.org>
2461 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2462 as an error, not just -1. (Bug#10217)
2464 2011-12-05 Chong Yidong <cyd@gnu.org>
2466 * keyboard.c (process_special_events): New function.
2467 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2469 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2471 * coding.c (encode_designation_at_bol): Don't use uninitialized
2472 local variable (Bug#9318).
2474 2011-12-05 Kenichi Handa <handa@m17n.org>
2476 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2477 return Qnil (Bug#8046, Bug#10193).
2479 2011-12-05 Kenichi Handa <handa@m17n.org>
2481 * coding.c (encode_designation_at_bol): New args charbuf_end and
2482 dst. Return the number of produced bytes. Callers changed.
2483 (coding_set_source): Return how many bytes coding->source was
2485 (coding_set_destination): Return how many bytes
2486 coding->destination was relocated.
2487 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2488 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2490 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2492 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2493 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2496 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2498 The following changes are to fix Bug#9318.
2500 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2501 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2502 (encode_coding_iso_2022, encode_coding_sjis)
2503 (encode_coding_big5, encode_coding_charset): Use the above macros.
2505 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2507 * lisp.h (process_quit_flag): Fix external declaration.
2509 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2511 Don't macro-inline non-performance-critical code.
2512 * eval.c (process_quit_flag): New function.
2513 * lisp.h (QUIT): Use it.
2515 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2517 * nsfns.m (get_geometry_from_preferences): New function.
2518 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2520 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2522 * emacs.c (Qkill_emacs): Define.
2523 (syms_of_emacs): Initialize it.
2524 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2525 Qquit_flag to `kill-emacs' instead.
2526 (quit_throw_to_read_char): Add parameter `from_signal'.
2527 All callers changed. Call Fkill_emacs if requested and safe.
2528 * lisp.h (QUIT): Call Fkill_emacs if requested.
2530 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2532 * widget.c (update_wm_hints): Return if wmshell is null.
2533 (widget_update_wm_size_hints): New function.
2535 * widget.h (widget_update_wm_size_hints): Declare.
2537 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2538 widget_update_wm_size_hints (Bug#10104).
2540 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2542 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2543 before a newline, prepare the bidi iterator for consuming the
2544 newline, and keep the current paragraph direction. (Bug#10183)
2545 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2547 2011-12-02 Juri Linkov <juri@jurta.org>
2549 * search.c (Fword_search_regexp): New Lisp function created from
2550 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2551 (Fword_search_backward, Fword_search_forward)
2552 (Fword_search_backward_lax, Fword_search_forward_lax):
2553 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2554 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2556 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2558 * fileio.c (Finsert_file_contents): Move after-change-function call
2559 to before the "handled:" label, since all "goto handled" appear in
2560 cases where the *-change-functions have already been properly called
2563 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2565 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2566 waiting for input. (Bug#10169)
2568 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2570 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2571 verifies glyph row's hash code--we have just reallocated the
2572 glyphs, so their contents can be complete garbage. (Bug#10164)
2574 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2576 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2578 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2580 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2581 attributes are tested _before_ calling verify_row_hash, to protect
2582 against GCC re-ordering of the tests. (Bug#10164)
2584 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2586 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2588 * xterm.c (handle_one_xevent): Only set async_visible and friends
2589 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2590 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2591 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2593 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2595 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2596 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2597 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2598 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2599 All uses changed to use GCPRO1 etc.
2600 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2601 Revert to old implementation (i.e., before 2011-03-11).
2603 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2605 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2606 of scroll runs so as to avoid assigning disabled bogus rows and
2607 unnecessary graphics copy operations.
2609 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2611 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2612 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2613 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2614 (malloc, free, realloc, calloc): Redirect to e_* only when
2617 * lisp.h (GCTYPEBITS): Move before first use.
2618 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2619 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2620 this macro definition.
2622 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2625 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2627 * gtkutil.c (xg_create_frame_widgets):
2628 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2629 present with Gtk+ 2.0.
2631 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2633 * fileio.c (Finsert_file_contents): Undo previous change; see
2634 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2636 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2638 Rename locals to avoid shadowing.
2639 * fileio.c (Finsert_file_contents):
2640 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2641 * process.c (wait_reading_process_output):
2642 Rename inner 'proc' to 'p' to avoid shadowing.
2643 Indent for consistency with usual Emacs style.
2645 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2647 * xdisp.c (redisplay_window): If cursor row is not fully visible
2648 after recentering, and scroll-conservatively is set to a large
2649 number, scroll window by a few more lines to make the cursor fully
2650 visible and out of scroll-margin. (Bug#10105)
2651 (start_display): Don't move to the next line if the display should
2652 start at a newline that is part of a display vector or an overlay
2655 2011-11-24 Juri Linkov <juri@jurta.org>
2657 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2658 after the `MagickPingImage' call. (Bug#10112)
2660 2011-11-23 Chong Yidong <cyd@gnu.org>
2662 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2664 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2666 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2667 making another buffer current. (Bug#10114)
2669 2011-11-23 Glenn Morris <rgm@gnu.org>
2671 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2673 2011-11-23 Chong Yidong <cyd@gnu.org>
2675 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2676 using it (Bug#5984).
2678 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2680 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2681 and header-lines, as they don't have one computed for them.
2684 * .gdbinit (prow): Make displayed values more self-explaining.
2685 Add row's hash code.
2687 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2689 * process.c (wait_reading_process_output): Fix asynchrounous
2690 GnuTLS socket handling on some versions of the GnuTLS library.
2691 (wait_reading_process_output): Add comment and URL.
2693 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2695 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2697 2011-11-21 Chong Yidong <cyd@gnu.org>
2699 * window.c (Fnext_window, Fprevious_window): Doc fix.
2701 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2703 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2705 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2707 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2709 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2711 * window.c (Fset_window_combination_limit): Rename argument
2713 (Vwindow_combination_limit): Remove "status" from doc-string.
2715 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2717 * m/ibms390.h: Remove.
2718 * m/ibms390x.h: Don't include "ibms390.h".
2720 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2722 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2723 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2725 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2727 * casetab.c (Fset_case_table):
2728 * charset.c (Fcharset_after): Fix typos.
2730 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2732 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2733 Otherwise, valgrind does not work on some platforms.
2734 Problem reported by Andreas Schwab in
2735 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2736 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2737 is set, removing the need for VIRT_ADDRESS_VARIES.
2738 (PURE_P): Use a more-efficient implementation that needs just one
2739 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2740 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2741 to 4 (xorl, subq, cmpq, setbe).
2742 * alloc.c (pure): Always extern now, since that's the
2743 VIRT_ADDR_VARIES behavior.
2744 (PURE_POINTER_P): Use a single comparison, not two, for
2745 consistency with the new puresize.h.
2746 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2747 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2748 Remove VIRT_ADDR_VARIES no longer needed.
2750 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2752 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2753 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2754 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2755 behave as if the cursor position were at the window margin.
2757 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2758 and the cursor position is out of bounds, behave as if the cursor
2759 position were at the window margin. (Bug#10075)
2761 2011-11-18 Chong Yidong <cyd@gnu.org>
2763 * window.c (Fwindow_combination_limit): Make first argument
2764 non-optional, since it is meaningless for live windows like the
2767 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2769 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2771 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2773 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2774 (graft_intervals_into_buffer): Simplify.
2776 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2778 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2779 hash values of the two rows.
2780 (copy_row_except_pointers): Preserve the used[] arrays and the
2781 hash values of the two rows. (Bug#10035)
2782 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2784 * xdisp.c (row_hash): New function, body extracted from
2785 compute_line_metrics.
2786 (compute_line_metrics): Call row_hash, instead of computing the
2789 * dispnew.c (verify_row_hash): Call row_hash for computing the
2790 hash code of a row, instead of duplicating code from xdisp.c.
2792 * dispextern.h (row_hash): Add prototype.
2794 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2796 * frame.c (delete_frame): Don't delete the terminal when the last
2797 X frame is closed if emacs is built with GTK toolkit.
2799 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2801 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2803 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2805 * window.c (Vwindow_splits): Rename to
2806 Vwindow_combination_resize. Suggested by Juri Linkov.
2807 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2810 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2812 * nsfns.m (Fns_font_name):
2813 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2815 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2817 * window.h (window): Rename slot "nest" to "combination_limit".
2818 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2819 (Fset_window_nest): Rename to Fset_window_combination_limit.
2820 (Vwindow_nest): Rename to Vwindow_combination_limit.
2821 (recombine_windows, make_parent_window, make_window)
2822 (Fsplit_window_internal, saved_window)
2823 (Fset_window_configuration, save_window_save): Rename all
2824 occurrences of window_nest to window_combination_limit.
2826 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2828 * image.c (imagemagick_load_image): Fix typo.
2830 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2832 * xdisp.c (display_line): Move the call to
2833 highlight_trailing_whitespace before the call to
2834 compute_line_metrics, since the latter needs to see the final
2835 faces of all the glyphs to compute ROW's hash value.
2836 Fixes assertion violations in row_equal_p. (Bug#10035)
2838 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2840 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2841 just return (bug#10044).
2843 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2845 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2846 with user-defined heap size. Bump the default size of the temacs
2847 heap to 27MB, to avoid memory warning when running temacs.
2848 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2850 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2851 current_matrix and desired_matrix. (Bug#9990)
2852 (verify_row_hash) [XASSERTS]: New function.
2853 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2854 that the hash value of glyph rows is correct.
2856 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2858 * window.h (window): Remove splits slot.
2859 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2860 (Fdelete_other_windows_internal, make_parent_window)
2861 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2862 (Fset_window_configuration, save_window_save): Don't deal with
2863 split status of windows.
2864 (saved_window): Remove splits slot.
2865 (Vwindow_splits): Rewrite doc-string.
2867 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2869 * xfns.c (unwind_create_frame):
2870 * nsfns.m (unwind_create_frame):
2871 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2872 Vframe_list (Bug#9999).
2874 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2876 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2878 2011-11-11 Kenichi Handa <handa@m17n.org>
2880 * callproc.c (Fcall_process): Set the member dst_multibyte of
2883 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2885 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2886 avoid a crash (bug#9496).
2888 2011-11-09 Chong Yidong <cyd@gnu.org>
2890 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2891 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2893 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2895 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2897 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2899 Avoid some portability problems by eschewing 'extern inline' functions.
2900 The trivial performance wins aren't worth the portability hassles; see
2901 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2903 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2904 (window_box_width, window_box_left, window_box_left_offset)
2905 (window_box_right, window_box_right_offset): Undo previous change,
2906 by removing the "extern"s.
2907 * intervals.c (adjust_intervals_for_insertion)
2908 (adjust_intervals_for_deletion): Undo previous change,
2909 making these static again.
2910 (offset_intervals, temp_set_point_both, temp_set_point)
2911 (copy_intervals_to_string): No longer inline.
2912 * xdisp.c (window_text_bottom_y, window_box_width)
2913 (window_box_height, window_box_left_offset)
2914 (window_box_right_offset, window_box_left, window_box_right)
2915 (window_box): No longer inline.
2917 2011-11-08 Chong Yidong <cyd@gnu.org>
2919 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2920 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2921 Signal an error if not a live window.
2922 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2923 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2925 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2927 * lisp.h (syms_of_abbrev): Remove declaration.
2928 Reported by CHENG Gao <chenggao@royau.me>.
2930 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2932 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2933 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2934 of temacs in GUI mode.
2936 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2938 * window.h: Declare delete_all_child_windows instead of
2939 delete_all_subwindows.
2940 * window.c (Fwindow_nest, Fset_window_nest)
2941 (Fset_window_new_total, Fset_window_new_normal)
2942 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2943 (delete_all_subwindows): Rename to delete_all_child_windows.
2944 (Fdelete_other_windows_internal, Fset_window_configuration):
2945 Call delete_all_child_windows instead of delete_all_subwindows.
2946 * frame.c (delete_frame): Call delete_all_child_windows instead
2947 of delete_all_subwindows.
2949 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2951 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2952 This is also needed for porting to any host where GC_MARK_STACK is
2953 not GC_MAKE_GCPROS_NOOPS.
2954 (which_symbols): Use it.
2956 2011-11-07 Kenichi Handa <handa@m17n.org>
2958 * coding.c (coding_set_destination): Check coding->src_pos only
2959 when coding->src_object is a buffer (bug#9910).
2961 * process.c (send_process): Set the member src_multibyte of coding
2962 to 0 (bug#9911) when sending a unibyte text.
2964 * callproc.c (Fcall_process): Set the member src_multibyte of
2965 process_coding to 0 (bug#9912).
2967 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2969 * xmenu.c (cleanup_widget_value_tree): New function.
2970 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2971 calling free_menubar_widget_value_tree directly (Bug#9830).
2973 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2975 Fix some portability problems with 'inline'.
2976 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2977 (window_box_width, window_box_left, window_box_left_offset)
2978 (window_box_right, window_box_right_offset): Declare extern.
2979 Otherwise, these inline functions do not conform to C99 and
2980 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2981 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2982 * intervals.c (adjust_intervals_for_insertion)
2983 (adjust_intervals_for_deletion): Now extern, because otherwise the
2984 extern inline functions 'offset_intervals' couldn't refer to it.
2985 (static_offset_intervals): Remove.
2986 (offset_intervals): Rewrite using the old contents of
2987 static_offset_intervals. The old version didn't conform to C99
2988 because an extern inline function contained a reference to an
2989 identifier with static linkage.
2991 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2993 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2996 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2998 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2999 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3000 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3001 return Qleft_to_right.
3003 2011-11-06 Chong Yidong <cyd@gnu.org>
3005 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3006 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3007 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3008 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3009 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3010 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3011 (Fwindow_vscroll): Doc fix.
3012 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3013 argument, since it makes no sense to pass a live window and for
3014 consistency with window-child.
3016 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3018 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3021 2011-11-05 Jason Rumney <jasonr@gnu.org>
3023 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3024 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3026 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3027 bitwise arithmetic preventing use of unicode-sip and non-truetype
3030 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3032 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3035 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3036 initialization code to keep similarity to xfns.c after changes
3039 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3041 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3042 (unwind_create_frame): New function (Bug#9943).
3043 (Fx_create_frame): Restructure code to be more similar to the one in
3044 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3045 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3046 Move terminal->reference_count++ just before making the frame official
3049 * nsterm.m (x_free_frame_resources): New function.
3050 (x_destroy_window): Move code to x_free_frame_resources.
3052 * xfns.c (unwind_create_frame): Fix comment.
3053 (Fx_create_frame, x_create_tip_frame):
3054 Move terminal->reference_count++ just before making the frame
3055 official. Move initialization of image_cache_refcount and
3056 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3058 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3060 Support MSVC build with newer versions of Visual Studio.
3061 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3062 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3065 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3066 which are not supported by MSVC.
3067 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3068 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3070 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3072 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3074 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3076 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3078 Support MSVC build with newer versions of Visual Studio.
3079 * w32.c: Don't include w32api.h for MSVC.
3080 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3082 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3083 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3084 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3085 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3087 (alloca) [_MSC_VER]: Define to _alloca.
3089 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3091 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3093 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3095 * xdisp.c (note_mouse_highlight): If either of
3096 previous/next-single-property-change returns nil, treat that as
3097 the beginning or the end of the buffer. (Bug#9955)
3099 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3101 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3102 label is not null (Bug#9951).
3103 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3106 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3108 * window.c (Fwindow_body_size): Mention in the doc string that the
3109 return value is in frame's canonical units. (Bug#9949)
3111 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3113 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3115 * w32fns.c (unwind_create_frame): If needed, free the glyph
3116 matrices of the partially constructed frame. (Bug#9943)
3117 * xfns.c (unwind_create_frame): Likewise.
3119 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3121 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3122 Don't stop backward scan on the continuation glyph, even though
3123 its CHARPOS is positive.
3124 (mouse_face_from_buffer_pos, note_mouse_highlight):
3125 Rename cover_string to disp_string.
3127 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3129 * window.c (temp_output_buffer_show): Don't use
3130 Vtemp_buffer_show_specifiers.
3131 (Vtemp_buffer_show_specifiers): Remove unused variable.
3133 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3135 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3136 past the beginning of the current glyph matrix.
3138 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3140 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3141 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3142 HAVE_GTK3 (Bug#9869).
3144 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3145 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3147 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3149 * xterm.c: Declare x_handle_net_wm_state to return int.
3150 (handle_one_xevent): Check if we are iconified but don't have
3151 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3152 (get_current_wm_state): Return non-zero if not hidden,
3153 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3154 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3155 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3156 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3158 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3160 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3161 so that this new function doesn't get optimized away by a
3162 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3164 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3166 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3168 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3170 Fix the `xbytecode' command.
3171 * .gdbinit (xprintbytestr): New command.
3172 (xwhichsymbols): Rename from `which'; all callers changed.
3173 (xbytecode): Print the byte-code string as well.
3175 2011-10-29 Kim Storm <storm@cua.dk>
3177 * alloc.c (which_symbols): New function.
3179 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3181 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3184 2011-10-29 Glenn Morris <rgm@gnu.org>
3186 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3187 Not clear what it was for, and it causes various bugs. (Bug#9839)
3189 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3191 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3192 possible random value that matches one of those tested as
3193 condition to clear the mouse face.
3195 2011-10-28 Chong Yidong <cyd@gnu.org>
3197 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3199 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3201 * window.c (make_window): Initialize phys_cursor_on_p.
3203 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3205 * lisp.h (struct Lisp_Symbol): Update comments.
3207 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3209 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3211 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3213 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3214 <oslsachem@gmail.com> for helping to debug this.
3216 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3217 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3218 (g_b_init_get_glyph_outline_w): New static variables.
3219 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3220 (GetGlyphOutlineW_Proc): New typedefs.
3221 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3222 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3224 (w32font_open_internal, compute_metrics):
3225 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3226 instead of calling the "wide" APIs directly.
3228 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3230 * w32.h (syms_of_w32font): Add prototype.
3232 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3234 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3235 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3236 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3237 (Fmove_to_window_line): Doc fix.
3239 2011-10-27 Chong Yidong <cyd@gnu.org>
3241 * process.c (make_process): Set gnutls_state to NULL.
3243 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3244 non-NULL, regardless of GNUTLS_INITSTAGE.
3245 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3246 an error. Set process slots as soon as we allocate them.
3248 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3250 2011-10-27 Chong Yidong <cyd@gnu.org>
3252 * gnutls.c (emacs_gnutls_deinit): New function.
3253 Deallocate credentials structures as well as calling gnutls_deinit.
3254 (Fgnutls_deinit, Fgnutls_boot): Use it.
3256 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3257 (deactivate_process): Call emacs_gnutls_deinit.
3259 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3261 * image.c (x_create_x_image_and_pixmap):
3262 * w32.c (sys_rename, w32_delayed_load):
3263 * w32font.c (fill_in_logfont):
3264 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3266 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3268 * w32fns.c (w32_default_color_map): New function,
3269 extracted from Fw32_default_color_map.
3270 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3272 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3274 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3276 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3278 * keyboard.c (test_undefined): New function (bug#9751).
3279 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3281 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3283 * sysdep.c (init_sys_modes): Fix the check for the controlling
3284 terminal (Bug#6649).
3286 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3288 * dispextern.h (struct bidi_it): New member next_en_type.
3290 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3291 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3292 current character, check also for next_en_type being WEAK_EN.
3293 (bidi_resolve_weak): Don't enter the expensive loop if the current
3294 position is before next_en_pos. Record the bidi type of the first
3295 non-ET, non-BN character we find, in addition to its position.
3296 (bidi_level_of_next_char): Invalidate next_en_type when
3297 next_en_pos is over-stepped.
3299 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3301 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3302 * editfns.c: Rewrite current-time-zone so that it invokes
3303 the equivalent of (format-time-string "%Z") to get the time zone name.
3304 This fixes a bug when the time zone name contains characters that
3305 need converting from the system time locale to Emacs internal format.
3306 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3307 that patch fixed format-time-string to do the conversion, but
3308 I forgot to fix current-time-zone.
3309 (format_time_string): New function, containing most of
3310 what Fformat_time_string used to contain.
3311 (Fformat_time_string): Rewrite in terms of format_time_string.
3312 This doesn't change this function's behavior.
3313 (current-time-zone): Rewrite to use format_time_string.
3314 This fixes the bug reported by Michael Schierl in
3315 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3316 Jason Rumney's 2007-06-07 change worked around this bug, but
3318 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3320 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3322 * xdisp.c (start_display): If the character at POS is displayed
3323 via a display vector, reset IT->current.dpvec_index to zero.
3324 (try_window_reusing_current_matrix): If a line ends in a display
3325 vector or the next line starts in a display vector, continue
3326 redrawing the window even though the character position of
3327 start_row was reached.
3330 2011-10-18 Chong Yidong <cyd@gnu.org>
3332 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3333 with nobreak-char-display too.
3335 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3337 Fix part 3 of bug#9771.
3338 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3339 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3340 non-neutral characters if the current character is a paragraph
3341 separator (a.k.a. Newline). This avoids running the same
3342 expensive loop twice, once when we consume the preceding newline
3343 and the other time when the line actually needs to be displayed.
3344 Avoid the loop when we see neutrals on the base embedding level
3345 following a character whose directionality is the same as the
3346 paragraph's. This avoids running the expensive loop when a line
3347 ends in a long sequence of neutrals, like control characters.
3348 Add assertion against STRONG_AL type. Slightly rearrange code
3349 that determines the type of a neutral given the first non-neutral
3351 (bidi_level_of_next_char): Set next_en_pos to zero when
3352 invalidating its info.
3354 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3356 * xdisp.c (push_display_prop): Determine whether to record string
3357 or buffer position by IT->string, not by IT->method. Allow
3358 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3359 (move_it_vertically_backward): Don't look for character position
3360 immediately after the newline when in a continuation line.
3363 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3365 * window.c (coordinates_in_window): Rewrite and delabelize
3366 vertical border check. (Bug#5357) (Bug#9618)
3368 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3370 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3371 errors in XSetWindowBorder (bug#9310).
3373 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3375 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3376 avoid crash when xmalloc overrun checking is enabled.
3378 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3380 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3381 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3382 cursor motion with <left> and <right> arrow keys.
3384 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3385 some callers set that themselves.
3387 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3389 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3390 display string and the previous row comes from the same string and
3391 is empty. (Bug#9739) (Bug#9738)
3393 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3395 * doc.c (get_doc_string): Encode file name (bug#9735).
3397 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3399 * bidi.c (bidi_level_of_next_char):
3400 * xdisp.c (get_visually_first_element): Remove old incorrect
3401 comments regarding the Unicode Line Separator character.
3403 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3405 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3407 * alloc.c (Fgc_status): Do not access beyond zombies array
3408 boundary if nzombies > MAX_ZOMBIES.
3409 * alloc.c (dump_zombies): Add missing format specifier.
3411 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3413 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3414 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3416 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3417 Some packages use them to denote characters with modifiers.
3419 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3421 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3422 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3423 matching a pp-number. Rename parameter var to var1.
3425 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3427 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3429 2011-10-08 Glenn Morris <rgm@gnu.org>
3431 * callint.c (Fcall_interactively): Give a more explicit error for the
3432 'c' case with a non-character input. (Bug#8479)
3434 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3436 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3438 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3439 lines that are hscrolled on the left.
3441 * dispnew.c (buffer_posn_from_coords): Account for a possible
3442 presence of header-line. (Bug#4426)
3444 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3446 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3447 Don't advertise functionality which we discourage or doesn't work.
3449 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3451 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3452 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3453 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3454 this makes Emacs dump core during garbage collection on rare
3455 occasions. sizeof is obviously inferior to offsetof here, so
3456 stick with offsetof.
3457 (GC_POINTER_ALIGNMENT): New macro.
3458 (mark_memory): Omit 3rd (offset) arg; caller changed.
3459 Don't assume EMACS_INT alignment is the same as pointer alignment.
3461 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3463 * keyboard.c (read_key_sequence_remapped): New var.
3464 (read_key_sequence): Compute remapping in the right buffer.
3465 (command_loop_1): Use read_key_sequence's remapping directly.
3467 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3469 * dired.c (file_name_completion): Don't expand file name.
3470 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3471 before checking file name handler.
3473 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3474 they've been requested explicitly (bug#9591).
3476 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3478 * keymap.c (Fsingle_key_description): Use make_specified_string
3479 instead of build_string to build string from push_key_description.
3482 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3484 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3485 This fixes a Y2038 bug on 64-bit hosts.
3486 * buffer.c (reset_buffer):
3487 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3488 (Fclear_buffer_auto_save_failure):
3489 Use 0, not -1, to represent an unset failure time, since time_t
3490 might not be signed.
3492 Remove dependency on glibc malloc internals.
3493 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3494 Move back here from lisp.h, but with their new implementations.
3495 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3496 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3497 * charset.c (charset_table_init): New static var.
3498 (syms_of_charset): Use it instead of xmalloc. This removes a
3499 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3500 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3501 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3502 Move back to alloc.c.
3503 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3504 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3506 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3508 * nsterm.m (windowDidResize): Call x_set_window_size only when
3509 ns_in_resize is true. Otherwise set pixelwidth/height and
3510 call change_frame_size (Bug#9628).
3512 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3514 Port --enable-checking=all to Fedora 14 x86-64.
3515 * charset.c (syms_of_charset): Also account for glibc malloc's
3516 internal overhead when calculating the initial malloc maximum.
3518 Port --enable-checking=all to Fedora 14 x86.
3519 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3521 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3522 (overrun_check_realloc, overrun_check_free):
3523 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3524 That way, xmalloc returns a properly-aligned pointer even if
3525 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3526 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3527 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3528 into account when calculating the initial malloc maximum.
3529 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3530 Move here from alloc.c, so that charset.c can use it too.
3531 Properly align; the old code wasn't right for common 32-bit hosts
3532 when configured with --enable-checking=all.
3533 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3534 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3536 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3538 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3541 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3543 * xdisp.c (compute_display_string_end): If there's no display
3544 string at CHARPOS, return -1.
3546 * bidi.c (bidi_fetch_char): When compute_display_string_end
3547 returns a negative value, treat the character as a normal
3548 character not covered by a display string. (Bug#9624)
3550 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3552 * lread.c (Fread_from_string): Fix typo in docstring.
3554 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3556 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3557 newline, reseat the iterator instead of bidi-iterating there one
3558 character at a time. (Bug#9610)
3559 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3560 TO_CHARPOS if the bidi iterator is at base embedding level.
3562 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3564 * lread.c (readevalloop): Use correct code for NBSP.
3565 (read1): Likewise. (Bug#9608)
3567 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3569 * dbusbind.c (Fdbus_register_signal): When service is not
3570 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3572 2011-09-25 Glenn Morris <rgm@gnu.org>
3574 * buffer.c (truncate-lines): Doc fix.
3576 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3578 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3579 (Fset_window_next_buffers): Doc fix.
3581 2011-09-24 Glenn Morris <rgm@gnu.org>
3583 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3585 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3587 Fix minor problems found by static checking.
3588 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3589 * indent.c (Fvertical_motion): Fix == vs = typo.
3591 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3593 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3594 Default value is now t. Doc fix.
3596 * indent.c (Fvertical_motion): Compute and apply the overshoot
3597 logic when moving up, not only when moving down. Fix the
3598 confusing name and values of the it_overshoot_expected variable;
3599 logic changes accordingly. (Bug#9254) (Bug#9549)
3601 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3602 CHARPOS is covered by a display string which includes newlines.
3603 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3604 is covered by a display string with embedded newlines.
3606 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3608 * dbusbind.c (Fdbus_register_signal): Add match rule to
3609 Vdbus_registered_objects_table. (Bug#9581)
3610 (Fdbus_register_method, Vdbus_registered_objects_table):
3613 2011-09-24 Jim Meyering <meyering@redhat.com>
3615 do not ignore write error for any output size
3616 The previous change was incomplete.
3617 While it makes emacs --batch detect the vast majority of stdout
3618 write failures, errors were still ignored whenever the output size is
3619 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3620 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3621 && echo FAIL: ignored write error
3622 FAIL: ignored write error
3623 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3624 && echo FAIL: ignored write error
3625 FAIL: ignored write error
3626 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3628 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3630 * emacs.c (Fkill_emacs): In noninteractive mode exit
3631 non-successfully if a write error occurred on stdout. (Bug#9574)
3633 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3635 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3638 * dispextern.h (struct it): Update the comment documenting what
3641 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3643 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3644 a display string, extend search for cursor position to end of row.
3645 (find_row_edges): If the row ends in a newline from a display
3646 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3647 Handle the case of a display string with multiple newlines.
3648 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3649 non-empty line. Fixes confusing cursor motion with arrow keys at
3650 the beginning of a line that starts with whitespace.
3652 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3654 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3657 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3659 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3662 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3664 * xdisp.c (display_line): Record maximum and minimum buffer
3665 positions even if no glyphs were produced (e.g., by a zero-width
3666 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3667 buffer positions that will be removed from the glyph row because
3669 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3670 column is beyond frame width: don't subtract 1 "pixel" when
3671 computing width of the stretch.
3672 (reseat_at_next_visible_line_start): Undo the change made on
3673 2011-09-17 that saved paragraph information and restored it after
3674 the call to `reseat'. (Bug#9545)
3676 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3678 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3679 and turn window cursor on if cleared (Bug#9415).
3681 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3683 * search.c (boyer_moore): Take unibyte characters from pattern
3684 literally. (Bug#9458)
3686 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3688 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3690 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3692 Fix minor problem found by static checking.
3693 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3694 initialized, to pacify gcc -Wuninitialized.
3696 * fileio.c: Report proper errno when syscall falls.
3697 (Finsert_file_contents): Save and restore errno,
3698 so that report_file_error outputs the correct diagnostic.
3699 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3701 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3703 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3705 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3707 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3708 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3710 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3712 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3713 about the current paragraph and restore it after the call to reseat.
3715 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3716 (bidi_find_paragraph_start): Search back for paragraph beginning
3717 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3718 (bidi_move_to_visually_next): Only trigger paragraph-related
3719 computations when the last character is a newline or at EOB, not
3720 just any NEUTRAL_B. (Bug#9470)
3722 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3723 truncated lines if point is covered by a display string. (Bug#9524)
3725 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3727 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3728 (cons_to_x_long): New function.
3729 (lisp_data_to_selection_data): Use it. Correct the test for
3730 short-versus-long data; it was negated. Break out of vector
3731 loop, for efficiency, when a long datum is discovered.
3733 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3735 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3737 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3739 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3740 GCC PR/17406) by declaring this function with external scope.
3742 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3744 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3745 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3747 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3749 * editfns.c (Fformat): Correctly handle text properties on "%%".
3751 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3753 * xterm.c (x_draw_composite_glyph_string_foreground):
3754 * w32term.c (x_draw_composite_glyph_string_foreground):
3755 * term.c (encode_terminal_code):
3756 * composite.c (composition_update_it, get_composition_id):
3757 * xdisp.c (get_next_display_element)
3758 (fill_composite_glyph_string): Add comments about special meaning
3759 of TAB characters in a composition.
3761 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3763 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3764 This occurs when processing a multibyte format.
3765 Problem reported by Wolfgang Jenker.
3767 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3769 * xdisp.c (try_cursor_movement): Only check for exact match if
3770 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3772 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3774 Remove unused external symbols.
3775 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3776 * xdisp.c (calc_pixel_width_or_height): Now static.
3777 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3778 * indent.c (check_display_width):
3779 * w32term.c: Fix comment to match code.
3780 * xterm.c, xterm.h (x_catching_errors): Remove.
3782 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3784 * xselect.c: Use signed conversions more consistently (Bug#9498).
3785 (selection_data_to_lisp_data): Assume incoming selection data are
3786 signed integers, not unsigned. This is to be consistent with
3787 outgoing selection data, which was modified to use signed integers
3788 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3789 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3790 expects long, not unsigned long.
3792 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3794 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3795 computation of loop end. Reported by Johan Bockgård
3798 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3800 * frame.c (Fother_visible_frames_p): Function deleted.
3802 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3804 * indent.c (compute_motion): Process display vector front to back
3805 rather than the other way around. (Bug#2496)
3807 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3809 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3811 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3813 * minibuf.c (Fread_from_minibuffer): Doc fix.
3815 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3817 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3818 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3820 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3822 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3823 value for non-existent files.
3825 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3827 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3828 set its "size" to -1. This will set the modtime_size field of
3829 the corresponding buffer to -1, which is what
3830 verify-visited-file-modtime expects for files that do not exist.
3833 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3835 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3837 * lisp.h: ... from here. push_key_description is no longer
3838 defined in keyboard.c, so its declaration should not be in
3839 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3840 logically belongs with push_key_description.
3842 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3844 * buffer.h: Include <sys/types.h> instead of <time.h>.
3845 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3846 Problem reported by Herbert J. Skuhra.
3848 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3850 * xml.c (parse_region): Make the parsing work for
3851 non-comment-starting XML files again (bug#9144).
3853 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3855 * image.c (gif_load): Fix calculation of bottom and right corner.
3858 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3860 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3861 redisplay in small windows.
3863 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3865 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3867 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3869 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3870 Operate on live windows only.
3872 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3874 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3876 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3878 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3879 only under bidi iteration.
3881 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3883 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3885 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3887 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3888 Without this fix, the command to link temacs failed due to an
3889 undefined symbol __builtin_isnan. This is because
3890 /usr/include/iso/math_c99.h #defines isnan(x) to
3891 __builtin_isnan(x), but the bundled gcc, which identifies itself
3892 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3894 * floatfns.c (isnan): #undef, and then #define to a clone of
3896 (Fisnan): Always define, since it's always available now.
3897 (syms_of_floatfns): Always define isnan at the Lisp level.
3899 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3901 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3903 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3905 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3906 The previous code assumed that file offsets (off_t values) fit in
3907 EMACS_INT variables, which is not true on typical 32-bit hosts.
3908 The code messed up by falsely reporting buffer overflow in cases
3909 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3910 when "big" contains more than 2**29 bytes, even though this
3911 inserts just one byte and does not overflow the buffer.
3912 (Finsert_file_contents): Store file offsets as off_t
3913 values, not as EMACS_INT values. Check for overflow when
3914 converting between EMACS_INT and off_t. When checking for
3915 buffer overflow or for overlap, take the offsets into account.
3916 Don't use EMACS_INT for small values where int suffices.
3917 When checking for overlap, fix a typo: ZV was used where
3918 ZV_BYTE was intended.
3919 (Fwrite_region): Don't assume off_t fits into 'long'.
3920 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3922 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3924 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3926 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3928 sprintf-related integer and memory overflow issues (Bug#9412).
3930 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3931 (esprintf, exprintf, evxprintf): New functions.
3932 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3933 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3934 (modify_event_symbol): Do not assume that the length of
3935 name_alist_or_stem is safe to alloca and fits in int.
3936 (Fexecute_extended_command): Likewise for function name and binding.
3937 (Frecursion_depth): Wrap around reliably on integer overflow.
3938 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3939 since some callers pass EMACS_INT values.
3940 (Fsingle_key_description): Don't crash if symbol name contains more
3941 than MAX_ALLOCA bytes.
3942 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3943 (get_minibuffer): Arg is now EMACS_INT, not int.
3944 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
3945 (esprintf, exprintf, evxprintf): New decls.
3946 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3948 * dbusbind.c (signature_cat): New function.
3949 (xd_signature, Fdbus_register_signal):
3950 Do not overrun buffer; instead, report string overflow.
3952 * dispnew.c (add_window_display_history): Don't overrun buffer.
3953 Truncate instead; this is OK since it's just a log.
3955 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3956 even if the time zone offset is outlandishly large.
3957 Don't mishandle offset == INT_MIN.
3959 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3960 when creating daemon; the previous buffer-overflow check was incorrect.
3962 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3963 which has the guts of the old verror function.
3965 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3966 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3968 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3969 (font_unparse_xlfd): Don't blindly alloca long strings.
3970 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3971 fits in int, when using sprintf. Use single snprintf to count
3972 length of string rather than counting it via multiple sprintfs;
3973 that's simpler and more reliable.
3974 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3975 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3976 sprintf, in case result does not fit in int.
3978 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3979 (fontset_from_font): Print it.
3981 * frame.c (tty_frame_count): Now printmax_t, not int.
3982 (make_terminal_frame, set_term_frame_name): Print it.
3983 (x_report_frame_params): In X, window IDs are unsigned long,
3984 not signed long, so print them as unsigned.
3985 (validate_x_resource_name): Check for implausibly long names,
3986 and don't assume name length fits in 'int'.
3987 (x_get_resource_string): Don't blindly alloca invocation name;
3988 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3991 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3992 (xg_check_special_colors, xg_set_geometry):
3993 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3995 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3996 Use esprintf, not sprintf, in case result does not fit in int.
3998 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3999 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4000 it as a large positive number.
4001 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4002 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4004 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4005 in case result does not fit in int.
4007 * print.c (float_to_string): Detect width overflow more reliably.
4008 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4009 buffer overrun. Don't assume list length fits in 'int'. Treat
4010 print length of 0 as 0, not as infinity; to be consistent with other
4011 uses of print length in this function. Don't overflow print length
4012 index. Don't assume hash table size fits in 'long', or that
4013 vectorlike size fits in 'unsigned long'.
4015 * process.c (make_process): Use printmax_t, not int, to format
4016 process-name gensyms.
4018 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4020 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4021 to avoid potential buffer overrun.
4023 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4024 if X resource line is longer than 512 bytes.
4026 * xfns.c (x_window): Make sprintf buffer a bit bigger
4027 to avoid potential buffer overrun.
4029 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4031 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4033 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4035 Integer overflow fixes for scrolling, etc.
4036 Without these, Emacs silently mishandles large integers sometimes.
4037 For example, "C-u 4294967297 M-x recenter" was treated as if
4038 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4040 * xdisp.c (try_window_id): Check Emacs fixnum range before
4041 converting to 'int'.
4043 * window.c (window_scroll_line_based, Frecenter):
4044 Check that an Emacs fixnum is in range before assigning it to 'int'.
4045 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4046 values converted from Emacs fixnums.
4047 (Frecenter): Don't wrap around a line count if it is out of 'int'
4048 range; instead, treat it as an extreme value.
4049 (Fset_window_configuration, compare_window_configurations):
4050 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4052 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4053 that can exceed INT_MAX. Check that EMACS_INT value is in range
4054 before assigning it to the (possibly-narrower) index.
4055 (match_limit): Don't assume that a fixnum can fit in 'int'.
4057 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4060 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4061 (Fvertical_motion): Don't wrap around LINES values that don't fit
4062 in 'int'. Instead, treat them as extreme values. This is good
4063 enough for windows, which can't have more than INT_MAX lines anyway.
4065 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4067 * Require libxml/parser.h to avoid compilation warning.
4069 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4071 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4072 since this reportedly can destroy thread storage.
4074 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4076 * syntax.c (find_defun_start): Update all cache variables if
4077 exiting early (Bug#9401).
4079 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4081 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4083 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4084 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4085 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4087 * term.c (tty_append_glyph): New function.
4088 (produce_stretch_glyph): Static function and its prototype deleted.
4090 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4093 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4095 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4096 when checking :margin (Bug#9390).
4097 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4098 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4099 so that the name doesn't mislead. All uses changed.
4101 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4103 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4106 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4108 * xdisp.c (move_it_to): Don't bail out early when reaching
4109 position beyond to_charpos, if we are scanning backwards.
4110 (move_it_vertically_backward): When DY == 0, make sure we get to
4111 the first character in the line after the newline.
4113 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4115 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4116 (ccl_driver): Do not generate an out-of-range pointer.
4117 (Fccl_execute_on_string): Remove unnecessary check for
4118 integer overflow, noted by Stefan Monnier in
4119 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4120 Remove a FIXME that didn't need fixing.
4121 Simplify the newly-introduced buffer reallocation code.
4123 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4125 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4127 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4129 Integer and memory overflow issues (Bug#9196).
4131 * doc.c (get_doc_string): Rework so that
4132 get_doc_string_buffer_size is the actual buffer size, rather than
4133 being 1 less than the actual buffer size; this makes xpalloc more
4136 * image.c (x_allocate_bitmap_record, cache_image):
4137 * xselect.c (Fx_register_dnd_atom):
4138 Simplify previous changes by using xpalloc.
4140 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4141 since either will do and ptrdiff_t is convenient with xpalloc.
4143 * charset.c (charset_table_size)
4144 (struct charset_sort_data.priority): Now ptrdiff_t.
4145 (charset_compare): Don't overflow if priorities differ greatly.
4146 (Fsort_charsets): Don't assume list length fits in int.
4147 Check for size-calculation overflow when allocating sort data.
4148 (syms_of_charset): Allocate an initial charset table that is
4149 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4151 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4153 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4154 The actual value is always <= INT_MAX, and leaving it unsigned made
4155 overflow checking harder.
4157 * dispextern.h (struct glyph_matrix.rows_allocated)
4158 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4159 with xpalloc. The values are still always <= INT_MAX.
4161 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4163 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4164 (SAFE_NALLOCA): New macro.
4166 * region-cache.c (struct boundary.pos, find_cache_boundary)
4167 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4168 (set_cache_region, invalidate_region_cache)
4169 (revalidate_region_cache, know_region_cache, region_cache_forward)
4170 (region_cache_backward, pp_cache):
4171 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4172 so that ptrdiff_t * can be passed to xpalloc.
4173 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4174 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4175 (pp_cache): Don't assume cache_len fits in int.
4176 * region-cache.h: Adjust extern decls to match.
4178 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4179 EMACS_INT, since either will do, for xpalloc.
4181 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4182 (xnmalloc, xnrealloc, xpalloc): New functions.
4184 * bidi.c (bidi_shelve_header_size): New constant.
4185 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4186 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4188 * bidi.c (bidi_cache_shrink):
4189 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4191 Don't update size of array until after memory allocation succeeds,
4192 because xmalloc/xrealloc may not return.
4193 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4194 now that we have proper integer overflow checking.
4195 (record_overlay_string, overlay_strings): Catch overflows when
4196 calculating size of overlay_str_buf.
4198 * callproc.c (Fcall_process): Check for size overflow when
4199 calculating size of args2.
4200 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4201 Normally we prefer signed values, but sticking with ptrdiff_t would
4202 require adding more-complicated checks.
4204 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4205 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4206 Redo buffer-overflow calculations to avoid integer overflow.
4207 Add a FIXME comment where memory seems to be over-allocated.
4209 * character.c (Fstring): Check for size-calculation overflow.
4211 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4212 unnecessary integer overflow. Check for size overflow.
4213 (encode_coding_object): Don't update size until xmalloc succeeds.
4215 * composite.c (get_composition_id): Check for overflow in glyph
4216 length calculations.
4218 Integer and memory overflow fixes for display code.
4219 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4220 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4221 (scrolling_window): Check for overflow in size calculations.
4222 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4223 Don't assume glyph table len fits in int.
4224 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4225 (row_table_size): Now ptrdiff_t, not int.
4226 (scrolling_window): Avoid overflow in size calculations.
4227 Don't update size until allocation succeeds.
4228 * fns.c (concat): Check for overflow in size calculations.
4229 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4230 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4231 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4233 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4234 (get_doc_string): Check for size calculation overflow.
4235 Don't update size until allocation succeeds.
4236 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4237 EMACS_INT, where ptrdiff_t will do.
4238 (Fsubstitute_command_keys): Check for string overflow.
4240 * editfns.c (set_time_zone_rule): Don't assume environment length
4242 (message_length): Now ptrdiff_t, not int.
4243 (Fmessage_box): Don't update size until allocation succeeds.
4244 Don't assume message length fits in int.
4245 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4247 * emacs.c (main): Do not reallocate argv, since there is a null at
4248 the end that can be overwritten, and this way there's no need to
4249 worry about size-calculation overflow.
4250 (sort_args): Check for size-calculation overflow.
4252 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4254 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4256 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4257 (x_set_scroll_bar_width, x_figure_window_size):
4258 Check for integer overflow.
4259 (x_set_alpha): Do not assume XINT fits in int.
4261 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4262 This is for the members text_lines, text_cols, total_lines, total_cols,
4263 where the system imposes an 'int' limit.
4265 * fringe.c (Fdefine_fringe_bitmap):
4266 Don't update size until alloc works.
4268 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4269 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4271 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4272 Check for size-calculation overflow.
4273 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4274 do, as we prefer signed integers.
4275 (id_to_widget.max_size, id_to_widget.used)
4276 (xg_store_widget_in_map, xg_remove_widget_from_map)
4277 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4278 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4279 Use and return ptrdiff_t, not int.
4280 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4281 * gtkutil.h: Change prototypes to match the above.
4283 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4284 are duplicate now that they've been promoted to lisp.h.
4285 (x_allocate_bitmap_record, x_alloc_image_color)
4286 (make_image_cache, cache_image, xpm_load):
4287 Don't update size until alloc is done.
4288 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4290 Check for size calculation overflow.
4291 (ct_colors_allocated_max): New constant.
4292 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4295 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4296 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4297 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4298 Use ptrdiff_t, not int, to count maps.
4299 (read_char_minibuf_menu_prompt): Check for overflow in size
4300 calculations. Don't update size until allocation succeeds.
4301 Redo calculations to avoid overflow.
4302 * keyboard.h: Change prototypes to match the above.
4304 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4306 (current_minor_maps): Check for size calculation overflow.
4307 * keymap.h: Change prototypes to match the above.
4309 * lread.c (read1, init_obarray): Don't update size until alloc done.
4311 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4312 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4314 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4315 Now ptrdiff_t, not int.
4316 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4317 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4319 * process.c (Fnetwork_interface_list): Check for overflow
4320 in size calculation.
4322 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4324 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4325 overflow. Don't bother calling xmalloc when xrealloc will do.
4327 * search.c (Freplace_match): Check for size calculation overflow.
4328 (Fset_match_data): Don't assume list lengths fit in 'int'.
4330 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4331 for command line length. Do not attempt to address one before the
4332 beginning of an array, as that's not portable.
4334 * term.c (max_frame_lines): Remove; unused.
4335 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4337 (encode_terminal_code, calculate_costs): Check for size
4338 calculation overflow.
4339 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4340 table lengths and related sizes. Don't update size until alloc
4341 done. Redo calculations to avoid overflow.
4342 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4344 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4345 subtracting pointers.
4346 (gobble_line): Check for overflow more carefully. Don't update size
4349 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4350 Don't update size until alloc done.
4351 Redo size calculations to avoid overflow.
4352 Check for size calculation overflow.
4353 (main) [DEBUG]: Fix typo in invoking tparam1.
4355 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4356 Use ptrdiff_t, not int, for sizes.
4357 (store_mode_line_noprop_char): Don't update size until alloc done.
4359 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4360 Use ptrdiff_t, not int, for sizes.
4361 (Finternal_make_lisp_face, cache_face):
4362 Check for size calculation overflow.
4363 (cache_face): Treat size calculation overflows as if they were
4364 memory exhaustion (the usual treatment), rather than aborting.
4366 * xfns.c (x_encode_text, x_set_name_internal)
4367 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4368 sizes, since they can exceed INT_MAX in size. Check for size
4369 calculation overflow.
4371 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4372 (xg_select): Check for size calculation overflow.
4373 Don't update size until alloc done.
4375 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4376 as sprintf is limited to int lengths.
4378 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4379 (X_LONG_MIN): New macros.
4380 Use them to make the following changes clearer.
4381 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4382 This change doesn't affect the value now, but it may help remind
4383 future maintainers not to raise the value too much later.
4384 (SELECTION_QUANTUM): Remove, replacing with ...
4385 (selection_quantum): ... new function, which avoids overflow.
4387 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4388 assumption that selection length fits in 'int'.
4389 (x_reply_selection_request, x_handle_selection_request)
4390 (x_get_window_property, receive_incremental_selection)
4391 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4392 (lisp_data_to_selection_data, clean_local_selection_data):
4393 Use ptrdiff_t, not int, to record length of selection.
4394 (x_reply_selection_request, x_get_window_property)
4395 (receive_incremental_selection, x_property_data_to_lisp):
4396 Redo calculations to avoid overflow.
4397 (x_reply_selection_request): When sending hint, ceiling it at
4398 X_LONG_MAX rather than relying on wraparound overflow to send
4400 (x_get_window_property, receive_incremental_selection)
4401 (lisp_data_to_selection_data, x_property_data_to_lisp):
4402 Check for size-calculation overflow.
4403 (x_get_window_property, receive_incremental_selection)
4404 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4405 Don't store size until memory allocation succeeds.
4406 (x_get_window_property): Plug memory leak on memory exhaustion.
4407 Don't double-block input; malloc is safe here. Don't assume 2**34
4408 - 4 fits in unsigned long. Add an xassert to check
4409 XGetWindowProperty overflow. Be more careful about overflow
4410 calculations, and distinguish size from memory overflow better.
4411 (receive_incremental_selection): When tracing, don't assume
4412 unsigned int is less than INT_MAX.
4413 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4414 harmful) conversions of unsigned short to int.
4415 (lisp_data_to_selection_data): Don't assume that integers
4416 in the range -65535 through -1 fit in an X unsigned short.
4417 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4418 result parameters unless successful. Rely on cons_to_unsigned
4419 to report problems with elements; the old code wasn't right anyway.
4420 (x_check_property_data): Check for int overflow; we cannot use
4421 a wider type due to X limits.
4422 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4424 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4426 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4427 (x_term_init): Check for size calculation overflow.
4428 (x_color_cells): Don't store size until memory allocation succeeds.
4429 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4430 Don't assume alloca size is less than MAX_ALLOCA.
4431 (x_term_init): Don't assume length fits in int (sprintf is limited
4434 Use ptrdiff_t for composition IDs.
4435 * character.c (lisp_string_width):
4436 * composite.c (composition_table_size, n_compositions)
4437 (get_composition_id, composition_gstring_from_id):
4438 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4439 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4440 * window.c (Frecenter):
4441 Use ptrdiff_t, not int, for composition IDs.
4442 * composite.c (get_composition_id): Check for integer overflow.
4443 * composite.h: Adjust prototypes to match the above changes.
4445 Use ptrdiff_t for hash table indexes.
4446 * category.c (hash_get_category_set):
4447 * ccl.c (ccl_driver):
4448 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4449 * coding.c (coding_system_charset_list, detect_coding_system):
4450 * coding.h (struct coding_system.id):
4451 * composite.c (get_composition_id, gstring_lookup_cache):
4452 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4453 * image.c (xpm_get_color_table_h):
4454 * lisp.h (hash_lookup, hash_put):
4455 * minibuf.c (Ftest_completion):
4456 Use ptrdiff_t for hash table indexes, not int (which is too
4457 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4458 32-bit --with-wide-int hosts).
4460 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4461 Add a FIXME comment about memory leaks.
4462 (syms_of_charset): Don't assume xmalloc returns.
4464 Don't assume that stated character widths fit in int.
4465 * character.c (Fchar_width, c_string_width, lisp_string_width):
4466 * character.h (CHAR_WIDTH):
4467 * indent.c (MULTIBYTE_BYTES_WIDTH):
4468 Use sanitize_char_width to avoid undefined and/or bad behavior
4469 with outlandish widths.
4470 * character.h (sanitize_tab_width): Rename from sanitize_width,
4471 now that we have two such functions. All uses changed.
4472 (sanitize_char_width): New inline function.
4474 Don't assume that tab-width fits in int.
4475 * character.h (sanitize_width): New inline function.
4476 (SANE_TAB_WIDTH): New macro.
4477 (ASCII_CHAR_WIDTH): Use it.
4478 * indent.c (sane_tab_width): Remove. All uses replaced by
4479 SANE_TAB_WIDTH (current_buffer).
4480 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4482 * fileio.c: Integer overflow issues with file modes.
4483 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4485 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4486 Remove unreachable code.
4487 (read_hex, load_charset_map_from_file): Check for integer overflow.
4489 * xterm.c: Don't go over XClientMessageEvent limit.
4490 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4491 (x_send_scroll_bar_event): Likewise. Check that the size does not
4492 exceed limits imposed by XClientMessageEvent, as well as the usual
4493 ptrdiff_t and size_t limits.
4495 * keyboard.c: Overflow, signedness and related fixes.
4496 (make_lispy_movement): Use same integer type in forward decl
4497 that is used in the definition.
4498 (read_key_sequence, keyremap_step):
4499 Change bufsize argument back to int, undoing my 2011-03-30 change.
4500 We prefer signed types, and int is wide enough here.
4501 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4502 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4503 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4504 length, not size_t. Use ptrdiff_t for index, not int.
4505 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4506 possibility of integer overflow.
4508 Overflow, signedness and related fixes for images.
4510 * dispextern.h (struct it.stack[0].u.image.image_id)
4511 (struct_it.image_id, struct image.id, struct image_cache.size)
4512 (struct image_cache.used, struct image_cache.ref_count):
4513 * gtkutil.c (update_frame_tool_bar):
4514 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4515 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4516 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4517 * nsmenu.m (update_frame_tool_bar):
4518 * xdisp.c (calc_pixel_width_or_height):
4519 * xfns.c (image_cache_refcount):
4520 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4521 on typical 64-bit hosts.
4523 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4524 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4525 Omit unnecessary casts to int.
4526 (parse_image_spec): Check that integers fall into 'int' range
4527 when the callers expect that.
4528 (image_ascent): Redo ascent calculation to avoid int overflow.
4529 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4530 (lookup_image): Remove unnecessary tests.
4531 (xbm_image_p): Locals are now of int, not EMACS_INT,
4532 since parse_image_check makes sure they fit into int.
4533 (png_load, gif_load, svg_load_image):
4534 Prefer int to unsigned where either will do.
4535 (tiff_handler): New function, combining the cores of the
4536 old tiff_error_handler and tiff_warning_handler.
4537 This function is rewritten to use vsnprintf and thereby avoid
4538 stack buffer overflows. It uses only the features of vsnprintf
4539 that are common to both POSIX and native Microsoft.
4540 (tiff_error_handler, tiff_warning_handler): Use it.
4541 (tiff_load, gif_load, imagemagick_load_image):
4542 Don't assume :index value fits in 'int'.
4543 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4544 (imagemagick_load_image): Check that crop parameters fit into
4545 the integer types that MagickCropImage accepts. Don't assume
4546 Vimagemagick_render_type has a nonnegative value. Don't assume
4547 size_t fits in 'long'.
4548 (gs_load): Use printmax_t to print the widest integers possible.
4549 Check for integer overflow when computing image height and width.
4551 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4553 * xdisp.c (redisplay_window): Don't force window start if point
4554 will be invisible in the resulting window. (Bug#9324)
4556 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4558 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4559 the display spec is of the form `(space ...)'.
4560 (handle_display_spec): Return the value returned by
4561 handle_single_display_spec, not just 1 or zero.
4562 (handle_single_display_spec): If the display spec is of the form
4563 `(space ...)', and specifies display in the text area, return 2
4565 (try_cursor_movement): Check for the need to scroll more
4566 accurately, and prefer exact match for point under bidi.
4567 Don't advance `row' beyond the last row of the window.
4569 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4570 into disp_prop; all users changed.
4572 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4573 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4574 for the text covered by the display property.
4576 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4578 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4579 Change return value to nil.
4580 (Frecord_buffer): Delete unused function.
4582 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4584 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4585 buffers, return left-to-right.
4586 (set_cursor_from_row): Consider candidate row a win if its glyph
4587 represents a newline and point is on that newline. Fixes cursor
4588 positioning on the newline at EOL of R2L text within L2R
4589 paragraph, and vice versa.
4590 (try_cursor_movement): Check continued rows, in addition to
4591 continuation rows. Fixes unwarranted scroll when point enters a
4592 continued line of R2L text within an L2R paragraph, or vice versa.
4593 (cursor_row_p): Consider the case of point being equal to
4594 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4595 from the end of a short line to the beginning of a continued line
4596 of R2L text within L2R paragraph.
4597 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4598 composed characters.
4600 * bidi.c (bidi_check_type): Use xassert.
4601 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4604 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4606 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4609 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4611 * nsfont.m (ns_otf_to_script): Fix typo.
4613 2011-08-22 Kenichi Handa <handa@m17n.org>
4615 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4616 extra slot even if the purpose is char-code-property-table.
4618 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4620 * xdisp.c (redisplay_window): When computing centering_position,
4621 account for the height of the header line. (Bug#8874)
4623 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4624 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4625 candidate is selected by the mouse, and that candidate has a
4626 composed character under the mouse.
4628 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4629 coordinates reported by pos-visible-in-window-p for a composed
4630 character in column zero.
4632 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4634 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4636 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4638 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4639 consider it a hit if to_charpos is anywhere in the range of the
4640 composed buffer positions.
4642 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4644 * image.c (gif_load): Don't assume that each subimage has the same
4645 dimensions as the base image. Handle disposal method that is
4646 "undefined" by the gif spec (Bug#9335).
4648 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4650 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4651 (Fcondition_case): Document `debug' symbol in error handler.
4653 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4655 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4656 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4657 from an Org mode buffer to a Speedbar frame.
4659 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4660 a composition, take its buffer position from IT->cmp_it.charpos.
4661 Fixes cursor positioning at the beginning of a line that begins
4662 with a composed character.
4664 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4666 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4667 character bidirectional type, use STRONG_L instead. Fixes crashes
4668 in a buffer produced by `describe-categories'.
4670 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4671 members before the level stack, so they would be saved and
4672 restored when copying iterator state. Fixes incorrect reordering
4673 around TABs covered by display properties.
4675 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4677 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4679 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4681 * eval.c (internal_condition_case, internal_condition_case_1)
4682 (internal_condition_case_2, internal_condition_case_n):
4683 Remove unnecessary aborts (Bug#9081).
4685 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4687 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4688 has no `load' handler, try opening the file locally. (Bug#9311)
4690 2011-08-16 Ken Brown <kbrown@cornell.edu>
4692 * gmalloc.c: Expand comment.
4694 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4696 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4697 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4699 2011-08-16 Ken Brown <kbrown@cornell.edu>
4701 Fix memory allocation problems in Cygwin build (Bug#9273).
4703 * unexcw.c ( __malloc_initialized): Declare external variable.
4704 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4706 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4708 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4710 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4712 [CYGWIN] (special_realloc): New function.
4713 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4714 requests to realloc storage in the static heap.
4716 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4718 * bidi.c (bidi_initialize): Remove unused local.
4720 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4723 * biditype.h: Remove file.
4724 * makefile.w32-in ($(BLD)/bidi.$(O)):
4725 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4727 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4729 * chartab.c: Improve commentary for the uniprop_table API.
4731 * bidi.c (bidi_paragraph_init): Support zero value of
4732 bidi_ignore_explicit_marks_for_paragraph_level.
4733 (bidi_initialize): Use uniprop_table instead of including
4734 biditype.h and bidimirror.h.
4736 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4737 coordinates of the iterator when restoring from ppos_it.
4740 2011-08-14 Kenichi Handa <handa@m17n.org>
4742 * process.c (create_process): Call setup_process_coding_systems
4743 after the pid of the process is set to -1 (Bug#8162).
4745 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4747 * xdisp.c (move_it_in_display_line_to): Don't invoke
4748 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4749 ppos_it. Fixes vertical cursor motion when line beginning is
4750 covered by an image. (Bug#9296)
4752 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4754 * nsterm.h (ns_run_ascript): Declare.
4755 (NSAPP_DATA2_RUNASSCRIPT): Define.
4757 * nsfns.m (as_script, as_result, as_status): New static variables.
4758 (ns_run_ascript): New function.
4759 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4760 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4761 the event loop. Get status from as_status (Bug#7276).
4763 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4764 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4765 the event loop (Bug#7276).
4767 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4769 * gnutls.c (QCgnutls_bootprop_priority)
4770 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4771 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4772 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4773 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4774 (QCgnutls_bootprop_verify_hostname_error)
4775 (QCgnutls_bootprop_callbacks_verify): Rename from
4776 Qgnutls_bootprop_..., all uses changed.
4778 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4781 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4783 * xfaces.c (Qframe_set_background_mode): Now static.
4784 * dispextern.h (Qframe_set_background_mode): Remove decl.
4786 * process.c (Fnetwork_interface_info): Declare local only if needed.
4788 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4790 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4791 (Fnetwork_interface_list): Allocate in increments of bytes instead
4792 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4793 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4795 (struct ifflag_def): notrailers is smart on OSX.
4796 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4797 Get hardware address with getifaddrs if available.
4799 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4801 * xdisp.c (iterate_out_of_display_property): xassert that
4802 IT->position is set to within IT->object's boundaries. Break from
4803 the loop as soon as EOB is reached; avoids infloops in redisplay
4804 when IT->position is set up wrongly due to some bug.
4805 Set IT->current to match the bidi iterator unconditionally.
4806 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4807 entry. Force push_it to save on the stack the current
4808 buffer/string position, to be restored by pop_it. Fix flags in
4809 the iterator structure wrt the object coming from a display
4810 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4811 properties. (Bug#9284)
4813 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4815 * fontset.c (fontset_get_font_group): Add proper type checks.
4818 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4820 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4821 and LC_VERSION_MIN_MACOSX.
4822 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4823 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4825 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4827 * xdisp.c (forward_to_next_line_start): Allow to use the
4828 no-display-properties-and-no-overlays under bidi display.
4829 Set disp_pos in the bidi iterator to avoid searches for display
4830 properties and overlays.
4832 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4834 * editfns.c (Fset_time_zone_rule): Document relationship with the
4837 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4838 the font entity extracted from the cache (Bug#8109).
4840 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4842 * composite.c (autocmp_chars): Don't reset point. That is done by
4843 restore_point_unwind (Bug#5984).
4845 2011-08-07 Juri Linkov <juri@jurta.org>
4847 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4848 to show the arg `TIME' instead of `TIMEVAL'.
4850 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4852 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4853 display property strides EOL and includes a newline, as in
4854 longlines-mode. (Bug#9254)
4855 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4856 word-wrap under bidirectional display. (Bug#9224)
4858 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4859 is non-zero, even if the data buffer is NULL. Fixes a crash in
4860 vertical-motion with longlines-mode. (Bug#9254)
4862 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4864 * bidi.c <bidi_cache_total_alloc>: Now static.
4865 (bidi_initialize): Initialize bidi_cache_total_alloc.
4867 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4870 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4871 amount allocated this far in `bidi_cache_total_alloc'.
4872 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4873 non-zero, only free the data buffer without restoring the cache
4874 contents. All callers changed.
4876 * dispextern.h (bidi_unshelve_cache): Update prototype.
4878 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4879 (move_it_in_display_line, move_it_to)
4880 (move_it_vertically_backward, move_it_by_lines): Replace the call
4881 to xfree to an equivalent call to bidi_unshelve_cache.
4882 (move_it_in_display_line_to): Fix logic of returning
4883 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4885 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4887 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4888 came from a string character with a `cursor' property. (Bug#9229)
4890 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4892 * Makefile.in (LIB_PTHREAD): New variable.
4893 (LIBES): Add LIB_PTHREAD (Bug#9216).
4895 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4896 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4898 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4900 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4902 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4904 * xterm.c (x_find_topmost_parent): New function.
4905 (x_set_frame_alpha): Find topmost parent window with
4906 x_find_topmost_parent and set the property there also (bug#9181).
4907 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4909 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4911 * callproc.c (Fcall_process): Avoid vfork clobbering
4912 the local vars buffer, coding_systems, current_dir.
4914 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4916 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4918 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4920 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4921 so that it is not optimized away.
4923 * xdisp.c (compute_display_string_pos): Remove unused local.
4925 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4927 Fix slow cursor motion and scrolling in large buffers with
4928 selective display, like Org Mode buffers. (Bug#9218)
4930 * dispextern.h (struct bidi_it): New member disp_prop_p.
4932 * xdisp.c: Remove one-slot cache of display string positions.
4933 (compute_display_string_pos): Accept an additional argument
4934 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4935 for a display string or property. If found, set DISP_PROP_P
4938 * bidi.c (bidi_fetch_char): Accept an additional argument
4939 DISP_PROP_P, and pass it to compute_display_string_pos.
4940 Only handle text covered by a display string if DISP_PROP_P is returned
4941 non-zero. All callers of bidi_fetch_char changed.
4943 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4945 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4947 2010-12-03 Don March <don@ohspite.net>
4949 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4950 last character M-[char] is translated to ESC [char] (bug#7541).
4952 2011-08-02 Kenichi Handa <handa@m17n.org>
4954 * lisp.h (uniprop_table): Extern it.
4956 * chartab.c (uniprop_table): Make it non-static.
4958 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4960 * xdisp.c (forward_to_next_line_start): Accept additional argument
4961 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4963 (reseat_at_next_visible_line_start): Use the bidi iterator state
4964 returned by forward_to_next_line_start to restore the state of
4965 it->bidi_it after backing up to previous newline. (Bug#9212)
4967 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4969 * regex.c (re_comp): Protoize.
4970 (re_exec): Fix return type.
4971 (regexec): Fix type of `ret'. (Bug#9203)
4973 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4975 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4976 This is needed if max-image-size is a floating-point number.
4978 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4980 * print.c (print_object): Print empty symbol as ##.
4982 * lread.c (read1): Read ## as empty symbol.
4984 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4986 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4987 setting frame foreground color (Bug#9175).
4988 (x_set_background_color): Likewise.
4990 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4991 contents (Bug#9176).
4992 (EmacsTooltip -init): Remove bezels and add shadows to
4995 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4996 or scroll bar (Bug#8470).
4998 * nsfont.m (nsfont_open): Remove assignment to voffset and
4999 unnecessary vars hshink, expand, hd, full_height, min_height.
5000 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5002 * nsterm.h (nsfont_info): Remove voffset field.
5004 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5006 Implement strike-through and overline on NextStep (Bug#8863).
5008 * nsfont.m (nsfont_open): Use underline position provided by font,
5009 instead of hard-coded value of 2.
5010 (nsfont_draw): Call ns_draw_text_decoration instead.
5012 * nsterm.h: Add declaration for ns_draw_text_decoration.
5014 * nsterm.m (ns_draw_text_decoration): New function for drawing
5015 underline, overline, and strike-through.
5016 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5017 ns_draw_text_decoration. Change treatment of cursor drawing to
5018 accommodate underlining, etc.
5020 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5022 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5025 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5027 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5028 Without this fix, if a signal arrives just after memory fills up,
5029 'malloc' might be invoked reentrantly.
5031 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5032 In other words, assume that every image size is allowed, on non-X
5033 hosts. This assumption is probably wrong, but it lets Emacs compile.
5035 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5037 * regex.c (re_iswctype): Convert return values to boolean.
5039 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5041 * xdisp.c (compute_display_string_pos): Don't use cached display
5042 string position if the buffer had its restriction changed.
5045 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5047 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5049 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5051 Integer signedness and overflow and related fixes. (Bug#9079)
5053 * bidi.c: Integer size and overflow fixes.
5054 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5055 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5056 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5057 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5058 (bidi_find_other_level_edge):
5059 Use ptrdiff_t instead of EMACS_INT where either will do.
5060 This works better on 32-bit hosts configured --with-wide-int.
5061 (bidi_cache_ensure_space): Check for size-calculation overflow.
5062 Use % rather than repeated addition, for better worst-case speed.
5063 Don't set bidi_cache_size until after xrealloc returns, because it
5065 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5066 (bidi_cache_ensure_space): Also check that the bidi cache size
5067 does not exceed that of the largest Lisp string or buffer. See Eli
5068 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5070 * alloc.c (__malloc_size_t): Remove.
5071 All uses replaced by size_t. See Andreas Schwab's note
5072 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5074 * image.c: Improve checking for integer overflow.
5075 (check_image_size): Assume that f is nonnull, since
5076 it is always nonnull in practice. This is one less thing to
5077 worry about when checking for integer overflow later.
5078 (x_check_image_size): New function, which checks for integer
5079 overflow issues inside X.
5080 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5081 This removes the need for a memory_full check.
5082 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5083 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5084 (xbm_read_bitmap_data): Change locals back to 'int', since
5085 their values must fit in 'int'.
5086 (xpm_load_image, png_load, tiff_load):
5087 Invoke x_create_x_image_and_pixmap earlier,
5088 to avoid much needless work if the image is too large.
5089 (tiff_load): Treat overly large images as if
5090 x_create_x_image_and_pixmap failed, not as malloc failures.
5091 (gs_load): Use x_check_image_size.
5093 * gtkutil.c: Omit integer casts.
5094 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5095 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5097 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5099 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5100 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5101 would wrongly return t on a 64-bit host.
5103 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5104 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5105 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5106 and therefore cause GCC to emit a bogus diagnostic in some cases.
5108 * image.c: Integer signedness and overflow and related fixes.
5109 This is not an exhaustive set of fixes, but it's time to
5110 record what I've got.
5111 (lookup_pixel_color, check_image_size): Remove redundant decls.
5112 (check_image_size): Don't assume that arbitrary EMACS_INT values
5113 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5114 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5115 (tiff_load, imagemagick_load_image):
5116 Check for overflow in size calculations.
5117 (x_create_x_image_and_pixmap): Remove unnecessary test for
5118 xmalloc returning NULL; that can't happen.
5119 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5120 (xpm_color_bucket): Use better integer hashing function.
5121 (xpm_cache_color): Don't possibly over-allocate memory.
5122 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5123 (gif_memory_source):
5124 Use ptrdiff_t, not int or size_t, to record sizes.
5125 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5126 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5127 either works, as we prefer signed integers.
5128 (tiff_read_from_memory, tiff_write_from_memory):
5129 Return tsize_t, not size_t, since that's what the TIFF API wants.
5130 (tiff_read_from_memory): Don't fail simply because the read would
5131 go past EOF; instead, return a short read.
5132 (tiff_load): Omit no-longer-needed casts.
5133 (Fimagemagick_types): Don't assume size fits into 'int'.
5135 Improve hashing quality when configured --with-wide-int.
5136 * fns.c (hash_string): New function, taken from sxhash_string.
5137 Do not discard information about ASCII character case; this
5138 discarding is no longer needed.
5139 (sxhash-string): Use it. Change sig to match it. Caller changed.
5140 * lisp.h: Declare it.
5141 * lread.c (hash_string): Remove, since we now use fns.c's version.
5142 The fns.c version returns a wider integer if --with-wide-int is
5143 specified, so this should help the quality of the hashing a bit.
5145 * emacs.c: Integer overflow minor fix.
5146 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5147 Define only if GNU_LINUX.
5148 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5150 * dispnew.c: Integer signedness and overflow fixes.
5151 Remove unnecessary forward decls, that were a maintenance hassle.
5152 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5154 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5155 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5156 (prepare_desired_row, line_draw_cost):
5157 Use int, not unsigned, where either works.
5158 (save_current_matrix, restore_current_matrix):
5159 Use ptrdiff_t, not size_t, where either works.
5160 (init_display): Check for overflow more accurately, and without
5161 relying on undefined behavior.
5163 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5164 Remove, replacing with the new symbols in lisp.h. All uses changed.
5165 * fileio.c (make_temp_name):
5166 * filelock.c (lock_file_1, lock_file):
5167 * xdisp.c (message_dolog):
5168 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5169 Use pMd etc. instead.
5170 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5171 replacing the pWIDE etc. symbols removed from editfns.c.
5173 * keyboard.h (num_input_events): Now uintmax_t.
5174 This is (very slightly) less likely to mess up due to wraparound.
5177 * buffer.c: Integer signedness fixes.
5178 (alloc_buffer_text, enlarge_buffer_text):
5179 Use ptrdiff_t rather than size_t when either will do, as we prefer
5182 * alloc.c: Integer signedness and overflow fixes.
5183 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5184 (__malloc_size_t): Default to size_t, not to int.
5185 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5186 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5187 Prefer ptrdiff_t to size_t when either would do, as we prefer
5189 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5190 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5191 Now const. Initialize with values that are in range even if char
5193 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5194 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5195 These functions do the right thing with sizes > 2**32.
5196 (check_depth): Now ptrdiff_t, not int.
5197 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5198 Adjust to new way of storing sizes. Check for size overflow bugs
5200 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5201 slightly wrong anyway, as it missed one instance of
5202 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5203 (refill_memory_reserve): Omit needless cast to size_t.
5204 (mark_object_loop_halt): Mark as externally visible.
5206 * xselect.c: Integer signedness and overflow fixes.
5207 (Fx_register_dnd_atom, x_handle_dnd_message):
5208 Use ptrdiff_t, not size_t, since we prefer signed.
5209 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5210 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5211 x_dnd_atoms_size and x_dnd_atoms_length.
5213 * doprnt.c: Prefer signed to unsigned when either works.
5215 * doprnt.c (doprnt):
5217 * xdisp.c (vmessage):
5218 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5219 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5220 prefer signed arithmetic to avoid comparison confusion.
5221 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5222 but is a bit tricky.
5224 Assume freestanding C89 headers, string.h, stdlib.h.
5225 * data.c, doprnt.c, floatfns.c, print.c:
5226 Include float.h unconditionally.
5227 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5228 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5229 * regex.c: Likewise for stddef.h, string.h.
5230 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5231 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5232 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5233 (STDC_HEADERS): Remove obsolete defines.
5234 * sysdep.c: Include limits.h unconditionally.
5236 Assume support for memcmp, memcpy, memmove, memset.
5237 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5238 * regex.c (memcmp, memcpy):
5239 Remove; we assume C89 now.
5241 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5242 (__malloc_safe_bcopy): Remove; no longer needed.
5244 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5245 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5246 well either way, and we prefer signed to unsigned.
5248 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5250 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5251 closes the connection while we're reading (bug#9182).
5253 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5255 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5256 are specified (Bug#9168).
5258 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5260 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5261 Found by GCC static checking and --with-wide-int on a 32-bit host.
5263 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5265 * xdisp.c (compute_display_string_pos): Fix logic of caching
5266 previous display string position. Initialize cached_prev_pos to
5267 -1. Fixes slow-down at the beginning of a buffer.
5269 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5271 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5272 for attrs[LFACE_FONTSET_INDEX].
5274 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5276 * xml.c (parse_region): Remove unused local
5277 that was recently introduced.
5279 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5281 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5282 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5284 * xdisp.c (move_it_in_display_line_to): Record the best matching
5285 position for TO_CHARPOS while scanning the line, and restore it on
5286 exit if none of the characters scanned was an exact match.
5287 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5288 when exact match is impossible due to invisible text, and the
5289 lines are truncated.
5291 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5293 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5296 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5298 Fix a significant slow-down of cursor motion with C-n, C-p,
5299 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5300 auto-repeat under bidi redisplay in fontified buffers.
5301 * xdisp.c (compute_stop_pos_backwards): New function.
5302 (next_element_from_buffer): Call compute_stop_pos_backwards to
5303 find a suitable prev_stop when we find ourselves before
5305 (reseat): Don't look for prev_stop, as that could mean a very long
5307 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5308 <cached_disp_overlay_modiff>: Cache for last found display string
5310 (compute_display_string_pos): Return the cached position if asked
5311 about the same buffer in the same area of character positions, and
5312 the buffer wasn't changed since the time the display string
5313 position was cached.
5315 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5317 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5318 is an integer, which is important for empty lines. (Bug#9149)
5320 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5322 * frame.c (Fmodify_frame_parameters): In tty case, update the
5323 default face if necessary (Bug#4238).
5325 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5327 * editfns.c (Fstring_to_char): No need to explain what a character
5328 is in the docstring (Bug#6576).
5330 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5332 * xml.c (parse_region): Make sure we always return a tree.
5334 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5336 * xml.c (parse_region): If a document contains only comments,
5339 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5341 * xml.c (make_dom): Return comments, too.
5343 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5346 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5347 and the surrounding thread.
5348 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5349 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5350 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5352 * s/openbsd.h (BROKEN_SIGIO): Define.
5353 * unexelf.c (unexec) [__OpenBSD__]:
5354 Don't update the .mdebug section of the Alpha COFF symbol table.
5356 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5358 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5361 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5363 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5364 This fixes some race conditions on the permissions of any newly
5367 * alloc.c (valid_pointer_p): Use pipe, not open.
5368 This fixes some permissions issues when debugging.
5370 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5371 If fchown fails to set both uid and gid, try to set just gid,
5372 as that is sometimes allowed. Adjust the file's mode to eliminate
5373 setuid or setgid bits that are inappropriate if fchown fails.
5375 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5377 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5378 to compare Lisp_Objects.
5379 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5380 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5381 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5383 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5385 * lread.c (read_integer): Unread even EOF character.
5386 (read1): Likewise. Properly record start position of symbol.
5388 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5389 symbol character follows.
5391 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5393 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5394 This works around a problem with the previous change to Fcopy_file.
5395 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5396 and without this change, GCC might complain about discarding
5397 fchown's return value.
5399 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5401 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5403 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5405 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5407 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5409 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5410 it's used from the C level.
5412 * process.c: Use the same condition for POLL_FOR_INPUT in both
5413 keyboard.c and process.c (bug#1858).
5415 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5417 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5418 (Fgnutls_boot): Use it.
5420 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5422 * doc.c (Fsubstitute_command_keys): Revert last change.
5424 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5426 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5427 quotes the next character, and doesn't affect other longer
5428 sequences (bug#8935).
5430 * lread.c (syms_of_lread): Clarify that is isn't only
5431 `eval-buffer' and `eval-defun' that's affected by
5432 `lexical-binding' (bug#8460).
5434 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5436 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5437 bidi redisplay when a line includes both an image and is truncated.
5439 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5441 Fix minor problems found by static checking.
5442 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5443 (elsz): Now a signed constant, not a size_t var. We prefer signed
5444 types to unsigned, to avoid integer comparison confusion. Without
5445 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5446 "cannot optimize loop, the loop counter may overflow", a symptom
5448 * indent.c (Fvertical_motion): Mark locals as initialized.
5449 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5451 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5453 * search.c (Fre_search_backward): Mention `case-fold-search' in
5454 all the re_search_* functions (bug#8138).
5456 * keyboard.c (Fopen_dribble_file): Document when the file is
5459 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5461 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5464 Support bidi reordering of display and overlay strings.
5465 * xdisp.c (compute_display_string_pos)
5466 (compute_display_string_end): Accept additional argument STRING.
5467 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5468 (reseat_to_string): Initialize bidi_it->string.s and
5469 bidi_it->string.schars.
5470 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5471 NULL (avoids a crash in bidi_paragraph_init).
5472 Initialize itb.string.lstring.
5473 (init_iterator): Call bidi_init_it only of a valid
5474 buffer position was specified. Initialize paragraph_embedding to
5476 (reseat_to_string): Initialize the bidi iterator.
5477 (display_string): If we need to ignore text properties of
5478 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5479 original value of -1 will not work with bidi.)
5480 (compute_display_string_pos): First arg is now struct
5481 `text_pos *'; all callers changed. Support display properties on
5483 (compute_display_string_end): Support display properties on Lisp
5485 (init_iterator, reseat_1, reseat_to_string): Initialize the
5486 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5487 when iterating on a string not from display properties).
5488 (compute_display_string_pos, compute_display_string_end):
5489 Fix calculation of the object to scan. Fixes an error when using
5491 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5492 base_level_stop; instead, set base_level_stop to BEGV.
5493 Fixes crashes in vertical-motion.
5494 (next_element_from_buffer): Improve commentary for when
5495 the iterator is before prev_stop.
5496 (init_iterator): Initialize bidi_p from the default value of
5497 bidi-display-reordering, not from buffer-local value. Use the
5498 buffer-local value only if initializing for buffer iteration.
5499 (handle_invisible_prop): Support invisible properties on strings
5500 that are being bidi-reordered.
5501 (set_iterator_to_next): Support bidi reordering of C strings and
5503 (next_element_from_string): Support bidi reordering of Lisp
5505 (handle_stop_backwards): Support Lisp strings as well.
5506 (display_string): Support display of R2L glyph rows.
5507 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5508 (init_iterator): Don't initialize it->bidi_p for strings
5510 (reseat_to_string): Initialize it->bidi_p for strings here.
5511 (next_element_from_string, next_element_from_c_string)
5512 (next_element_from_buffer): Add xassert's for correspondence
5513 between IT's object being iterated and it->bidi_it.string
5515 (face_before_or_after_it_pos): Support bidi iteration.
5516 (next_element_from_c_string): Handle the case of the first string
5517 character that is not the first one in the visual order.
5518 (get_visually_first_element): New function, refactored from common
5519 parts of next_element_from_buffer, next_element_from_string, and
5520 next_element_from_c_string.
5521 (tool_bar_lines_needed, redisplay_tool_bar)
5522 (display_menu_bar): Force left-to-right direction. Add a FIXME
5523 comment for making that be controlled by a user option.
5524 (push_it, pop_it): Save and restore the state of the
5525 bidi iterator. Save and restore the bidi_p flag.
5526 (pop_it): Iterate out of display property for string iteration as
5528 (iterate_out_of_display_property): Support iteration over strings.
5529 (handle_single_display_spec): Set up it->bidi_it for iteration
5530 over a display string, and call bidi_init_it.
5531 (handle_single_display_spec, next_overlay_string)
5532 (get_overlay_strings_1, push_display_prop): Set up the bidi
5533 iterator for displaying display or overlay strings.
5534 (forward_to_next_line_start): Don't use the shortcut if
5536 (back_to_previous_visible_line_start): If handle_display_prop
5537 pushed the iterator stack, restore the internal state of the bidi
5538 iterator by calling bidi_pop_it same number of times.
5539 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5540 and we are bidi-iterating, don't decrement the iterator position;
5541 instead, set the first_elt flag in the bidi iterator, to produce
5543 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5544 (push_display_prop): xassert that we are iterating a buffer.
5545 (push_it, pop_it): Save and restore paragraph_embedding member.
5546 (handle_single_display_spec, next_overlay_string)
5547 (get_overlay_strings_1, reseat_1, reseat_to_string)
5548 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5549 correctly. Don't assume unibyte strings are not bidi-reordered.
5550 (compute_display_string_pos)
5551 (compute_display_string_end): Fix handling the case of C string.
5552 (push_it, pop_it): Save and restore from_disp_prop_p.
5553 (handle_single_display_spec, push_display_prop): Set the
5554 from_disp_prop_p flag.
5555 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5556 (pop_it): Call iterate_out_of_display_property only if we are
5557 popping after iteration over a string that came from a display
5558 property. Fix a typo in popping stretch info. Add an assertion
5559 for verifying that the iterator position is in sync with the bidi
5561 (handle_single_display_spec, get_overlay_strings_1)
5562 (push_display_prop): Fix initialization of paragraph direction for
5563 string when that of the parent object is not yet determined.
5564 (reseat_1): Call bidi_init_it to resync the bidi
5565 iterator with IT's position. (Bug#7616)
5566 (find_row_edges): If ROW->start.pos gives position
5567 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5568 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5569 Reset the from_disp_prop_p flag.
5570 (SAVE_IT, RESTORE_IT): New macros.
5571 (pos_visible_p, face_before_or_after_it_pos)
5572 (back_to_previous_visible_line_start)
5573 (move_it_in_display_line_to, move_it_in_display_line)
5574 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5575 (try_scrolling, redisplay_window, display_line): Use them when
5576 saving a temporary copy of the iterator and restoring it back.
5577 (back_to_previous_visible_line_start, reseat_1)
5578 (init_iterator): Empty the bidi cache "stack".
5579 (move_it_in_display_line_to): If iterator ended up at
5580 EOL, but we never saw any buffer positions smaller than
5581 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5582 motion in bidi-reordered lines.
5583 (move_it_in_display_line_to): Record prev_method and prev_pos
5584 immediately before the call to set_iterator_to_next. Fixes cursor
5585 motion in bidi-reordered lines with stretch glyphs and strings
5586 displayed in margins. (Bug#8133) (Bug#8867)
5587 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5589 (pos_visible_p): Support positions in bidi-reordered lines.
5590 Save and restore bidi cache.
5592 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5593 (bidi_paragraph_info): Delete unused struct.
5594 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5595 (bidi_cache_start): New variable.
5596 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5598 (bidi_cache_fetch_state, bidi_cache_search)
5599 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5600 (bidi_cache_find, bidi_peek_at_next_level)
5601 (bidi_level_of_next_char, bidi_find_other_level_edge)
5602 (bidi_move_to_visually_next): Compare cache index with
5603 bidi_cache_start rather than with zero.
5604 (bidi_fetch_char): Accept new argument STRING; all callers
5605 changed. Support iteration over a string. Support strings with
5606 display properties. Support unibyte strings. Fix the type of
5607 `len' according to what STRING_CHAR_AND_LENGTH expects.
5608 (bidi_paragraph_init, bidi_resolve_explicit_1)
5609 (bidi_resolve_explicit, bidi_resolve_weak)
5610 (bidi_level_of_next_char, bidi_move_to_visually_next):
5611 Support iteration over a string.
5612 (bidi_set_sor_type, bidi_resolve_explicit_1)
5613 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5614 can now be zero (for strings); special values 0 and -1 were
5615 changed to -1 and -2, respectively.
5616 (bidi_char_at_pos): New function.
5617 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5618 Call it instead of FETCH_MULTIBYTE_CHAR.
5619 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5620 initialized to valid values.
5621 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5623 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5624 the test for valid cached positions. Fix the logic for looking up
5625 the sentinel state in the cache. GCPRO the Lisp string we are
5627 (bidi_push_it, bidi_pop_it): New functions.
5628 (bidi_initialize): Initialize the bidi cache start stack pointer.
5629 (bidi_cache_ensure_space): New function, refactored from part of
5630 bidi_cache_iterator_state. Don't assume the required size is just
5631 one BIDI_CACHE_CHUNK away.
5632 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5633 (bidi_count_bytes, bidi_char_at_pos): New functions.
5634 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5635 always valid if bidi_cache_idx is valid.
5636 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5637 is valid if it's going to be used.
5638 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5639 (bidi_cache_fetch_state, bidi_cache_search)
5640 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5641 (bidi_cache_iterator_state, bidi_cache_find)
5642 (bidi_find_other_level_edge, bidi_cache_start_stack):
5643 All variables related to cache indices are now EMACS_INT.
5645 * dispextern.h (struct bidi_string_data): New structure.
5646 (struct bidi_it): New member `string'. Make flag members be 1-bit
5647 fields, and put them last in the struct.
5648 (compute_display_string_pos, compute_display_string_end):
5650 (bidi_push_it, bidi_pop_it): Add prototypes.
5651 (struct iterator_stack_entry): New members bidi_p,
5652 paragraph_embedding, and from_disp_prop_p.
5653 (struct it): Member bidi_p is now a bit field 1 bit wide.
5654 (bidi_shelve_cache, bidi_unshelve_cache):
5657 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5658 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5659 and vector-like objects.
5661 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5662 cache around display iteration.
5664 * window.c (Fwindow_end, window_scroll_pixel_based)
5665 (displayed_window_lines, Frecenter): Save and restore the bidi
5666 cache around display iteration.
5668 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5670 * editfns.c (Fdelete_region): Clarify the use of the named
5671 parameters (bug#6788).
5673 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5675 * indent.c (Fvertical_motion): Set and restore w->pointm when
5676 saving and restoring the window's buffer (Bug#9006).
5678 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5680 * editfns.c (Fstring_to_char): Clarify just what is returned
5681 (bug#6576). Text by Eli Zaretskii.
5683 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5685 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5687 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5689 * buffer.c (mmap_find): Fix a typo.
5691 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5693 Fix execution of x selection hooks.
5694 * xselect.c (Qx_lost_selection_functions)
5695 (Qx_sent_selection_functions): New vars.
5696 (syms_of_xselect): DEFSYM them.
5697 (x_handle_selection_request): Pass Qx_sent_selection_functions
5698 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5699 (x_handle_selection_clear,x_clear_frame_selections):
5700 Pass Qx_lost_selection_functions rather than
5701 Vx_lost_selection_functions to Frun_hook_with_args.
5703 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5705 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5706 The old code sometimes used this field without initializing it.
5708 * alloc.c (gc_sweep): Don't read past end of array.
5709 In theory, the old code could also have corrupted Emacs internals,
5710 though it'd be very unlikely.
5712 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5714 * character.c (Fcharacterp): Don't advertise optional ignored
5715 argument. (Bug#4026)
5717 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5719 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5722 * window.c (Fset_window_start): Doc fix (bug#4199).
5723 (Fset_window_hscroll): Ditto.
5725 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5727 Fix minor new problems caught by GCC 4.6.1.
5728 * term.c (init_tty): Remove unused local.
5729 * xsettings.c (store_monospaced_changed): Define this function only
5730 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5733 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5735 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5737 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5739 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5740 are the mini-buffer and the echo area (bug#3320).
5742 * term.c (init_tty): Remove support for supdup, c10 and perq
5743 terminals, which are no longer supported (bug#1482).
5745 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5747 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5749 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5751 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5752 for non-popups (Bug#3642).
5754 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5756 * alloc.c (reset_malloc_hooks): Protoize.
5757 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5758 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5759 * cm.c (losecursor): Likewise.
5760 * data.c (fmod): Likewise.
5761 * dispnew.c (swap_glyphs_in_rows): Likewise.
5762 * emacs.c (memory_warning_signal): Likewise.
5763 * floatfns.c (float_error): Likewise.
5764 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5765 (otf_open, font_otf_capability, generate_otf_features)
5766 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5768 * image.c (pbm_read_file): Likewise.
5769 * indent.c (string_display_width): Likewise.
5770 * intervals.c (check_for_interval, search_for_interval)
5771 (inc_interval_count, count_intervals, root_interval)
5772 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5773 * lread.c (defalias): Likewise.
5774 * ralloc.c (r_alloc_check): Likewise.
5775 * regex.c (set_image_of_range_1, set_image_of_range)
5776 (regex_grow_registers): Likewise.
5777 * sysdep.c (strerror): Likewise.
5778 * termcap.c (valid_filename_p, tprint, main): Likewise.
5779 * tparam.c (main): Likewise.
5780 * unexhp9k800.c (run_time_remap, save_data_space)
5781 (update_file_ptrs, read_header, write_header, calculate_checksum)
5782 (copy_file, copy_rest, display_header): Likewise.
5783 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5785 * xdisp.c (check_it): Likewise.
5786 * xfaces.c (register_color, unregister_color, unregister_colors):
5788 * xfns.c (print_fontset_result): Likewise.
5789 * xrdb.c (member, fatal, main): Likewise.
5791 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5793 Fix minor problems found by static checking (Bug#9031).
5794 * chartab.c (char_table_set_range, map_sub_char_table):
5795 Remove unused locals.
5796 (uniprop_table): Now static.
5797 * composite.c (_work_char): Remove unused static var.
5799 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5801 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5803 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5805 * gtkutil.c (qttip_cb): Remove code without function.
5807 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5809 * w32.c (pthread_sigmask): New stub.
5811 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5813 Use pthread_sigmask, not sigprocmask (Bug#9010).
5814 sigprocmask is portable only for single-threaded applications, and
5815 Emacs can be multi-threaded when it uses GTK.
5816 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5818 * callproc.c (Fcall_process):
5819 * process.c (create_process):
5820 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5821 Use pthread_sigmask, not sigprocmask.
5823 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5825 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5826 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5829 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5831 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5832 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5833 (xg_hide_tooltip): Fix comment.
5835 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5836 in registerServicesMenuSendTypes.
5837 (validRequestorForSendType): Don't check ns_return_types.
5839 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5842 2011-07-08 Jason Rumney <jasonr@gnu.org>
5844 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5845 SH_SHOW for hidden windows (Bug#5482).
5847 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5848 frame struct members of non-existent frames (Bug#6284).
5850 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5852 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5853 variable firstTime not needed on OSX >= 10.6.
5854 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5855 >= 10.5. Use setKnobProportion, setDoubleValue.
5857 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5858 (MAC_OS_X_VERSION_10_5): Define if not defined.
5859 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5860 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5861 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5863 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5864 cString and lossyCString on OSX >= 10.4
5866 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5867 sizeToFit on OSX >= 10.2.
5869 * nsimage.m (allocInitFromFile): Don't use deprecated method
5870 bestRepresentationForDevice on OSX >= 10.6.
5872 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5875 * emacs.c: Declare unexec_init_emacs_zone.
5877 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5879 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5881 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5882 on svcsMenu (Bug#8842).
5884 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5886 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5888 * nsterm.m (QUTF8_STRING): Declare.
5889 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5890 (validRequestorForSendType): Return type is (id).
5891 Change indexOfObjectIdenticalTo to indexOfObject.
5892 Check if we have local selection before returning self (Bug#8842).
5893 (writeSelectionToPasteboard): Put local selection into paste board
5894 if we have a local selection (Bug#8842).
5895 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5897 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5898 (ns_get_local_selection): Declare.
5900 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5902 * keymap.c (describe_map_tree): Don't insert a double newline at
5903 the end of the buffer (bug#1169) and return whether we inserted
5906 * callint.c (Fcall_interactively): Change "reading args" to
5907 "providing args" to try to clarify what it does (bug#1010).
5909 2011-07-07 Kenichi Handa <handa@m17n.org>
5911 * composite.c (composition_compute_stop_pos): Ignore a static
5912 composition starting before CHARPOS (Bug#8915).
5914 * xdisp.c (handle_composition_prop): Likewise.
5916 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5918 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5921 2011-07-07 Kenichi Handa <handa@m17n.org>
5923 * character.h (unicode_category_t): New enum type.
5925 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5926 (Qchar_code_property_table): New variable.
5927 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5928 (UNIPROP_COMPRESSED_FORM_P): New macros.
5929 (char_table_ascii): Uncompress the compressed values.
5930 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5931 Uncompress the compressed values.
5932 (sub_char_table_ref_and_range): Likewise.
5933 (char_table_ref_and_range): Uncompress the compressed values.
5934 (sub_char_table_set): New arg is_uniprop. Callers changed.
5935 Uncompress the compressed values.
5936 (sub_char_table_set_range): Args changed. Callers changed.
5937 (char_table_set_range): Adjuted for the above change.
5938 (map_sub_char_table): Delete args default_val and parent. Add arg
5939 top. Give decoded values to a Lisp function.
5940 (map_char_table): Adjust for the above change. Give decoded
5941 values to a Lisp function. Gcpro more variables.
5942 (uniprop_table_uncompress)
5943 (uniprop_decode_value_run_length): New functions.
5944 (uniprop_decoder, uniprop_decoder_count): New variables.
5945 (uniprop_get_decoder, uniprop_encode_value_character)
5946 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5948 (uniprop_encoder, uniprop_encoder_count): New variables.
5949 (uniprop_get_encoder, uniprop_table)
5950 (Funicode_property_table_internal, Fget_unicode_property_internal)
5951 (Fput_unicode_property_internal): New functions.
5952 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5953 Sunicode_property_table_internal, Sget_unicode_property_internal,
5954 and Sput_unicode_property_internal. Defvar_lisp
5955 char-code-property-alist.
5957 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5958 Vunicode_category_table.
5960 * font.c (font_range): Adjust for the change of
5961 Vunicode_category_table.
5963 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5965 * m/iris4d.h: Remove file, move contents ...
5966 * s/irix6-5.h: ... here.
5968 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5970 Remove unportable assumption about struct layout (Bug#8884).
5971 * alloc.c (mark_buffer):
5972 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5973 (clone_per_buffer_values): Don't assume that
5974 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5975 This isn't true in general, and it's particularly not true
5976 if Emacs is configured with --with-wide-int.
5977 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5978 New macros, used in the buffer.c change.
5980 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5982 * xsettings.c: Use both GConf and GSettings if both are available.
5983 (store_config_changed_event): Add comment.
5984 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5985 (store_tool_bar_style_changed): New functions.
5986 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5987 (struct xsettings): Move font inside HAVE_XFT.
5988 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5989 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5990 Move inside HAVE_XFT.
5991 (something_changed_gsettingsCB): Rename from something_changedCB.
5992 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5994 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5995 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5996 (something_changed_gconfCB): Rename from something_changedCB.
5997 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5998 (parse_settings): Move check for font inside HAVE_XFT.
5999 (read_settings, apply_xft_settings): Add comment.
6000 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6001 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6002 call store_font_name_changed.
6003 (xft_settings_event): Add comment.
6004 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6005 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6006 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6007 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6008 (xsettings_initialize): Call init_gsettings last.
6009 (xsettings_get_system_font, xsettings_get_system_normal_font):
6012 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6014 Random fixes. E.g., (random) never returned negative values.
6015 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6016 subseconds part to the entropy, as that's a bit more random.
6017 Prefer signed to unsigned, since the signedness doesn't matter and
6018 in general we prefer signed. When given a limit, use a
6019 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6020 latter isn't right if USE_2_TAGS_FOR_INTS.
6021 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6022 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6024 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6026 * textprop.c (text_property_stickiness):
6027 Obey Vtext_property_default_nonsticky.
6028 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6029 * w32fns.c (syms_of_w32fns):
6030 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6032 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6034 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6035 This is more efficient than Ffile_directory_p and avoids a minor race.
6037 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6039 * buffer.c (Foverlay_put): Say what the return value is
6042 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6043 is a directory before asking whether to use the file name
6045 (barf_or_query_if_file_exists): Make the "File is a directory"
6046 error be more correct.
6048 * fns.c (Frequire): Remove the mention of the .gz files, since
6049 that's installation-specific, but keep the mention of
6050 `get-load-suffixes'.
6052 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6054 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6055 Report string overflow if the output is too long.
6057 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6059 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6060 (syms_of_gnutls): Remove duplicate DEFSYM for
6061 Qgnutls_bootprop_verify_hostname_error, an error for
6062 Qgnutls_bootprop_verify_error (which is no longer used).
6064 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6065 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6066 Also (re)move comments that are misplaced or no longer relevant.
6068 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6070 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6072 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6074 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6075 and background color parameters if they have been changed.
6077 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6079 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6081 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6083 * xsettings.c (SYSTEM_FONT): Define only when used.
6084 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6086 * keymap.c (access_keymap_1): Now static.
6088 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6090 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6091 leave any prefix arg for the up event (Bug#1586).
6093 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6095 * lread.c (syms_of_lread): Mention single symbols defined by
6096 `defvar' or `defconst' (bug#7154).
6098 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6099 (Frequire): Mention get-load-suffixes.
6101 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6103 * window.h (window): Remove clone_number slot.
6104 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6106 (make_parent_window, make_window, saved_window)
6107 (Fset_window_configuration, save_window_save): Don't deal with
6109 * buffer.c (Qclone_number): Remove declaration.
6110 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6112 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6114 Add multiple inheritance to keymaps.
6115 * keymap.c (Fmake_composed_keymap): New function.
6116 (Fset_keymap_parent): Simplify.
6117 (fix_submap_inheritance): Remove.
6118 (access_keymap_1): New function extracted from access_keymap to handle
6119 embedded parents and handle lists of maps.
6120 (access_keymap): Use it.
6121 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6122 (Fcopy_keymap): Handle embedded parents.
6123 (Fcommand_remapping, define_as_prefix): Simplify.
6124 (Fkey_binding): Simplify.
6125 (syms_of_keymap): Move minibuffer-local-completion-map,
6126 minibuffer-local-filename-completion-map,
6127 minibuffer-local-must-match-map, and
6128 minibuffer-local-filename-must-match-map to Elisp.
6129 (syms_of_keymap): Defsubr make-composed-keymap.
6130 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6131 (parse_menu_item): Trivial simplification.
6133 2011-07-01 Glenn Morris <rgm@gnu.org>
6135 * Makefile.in (SETTINGS_LIBS): Fix typo.
6137 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6139 * coding.c (Fencode_coding_string): Record the last coding system
6140 used, as the function doc string says (bug#8738).
6142 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6144 * xsettings.c (store_monospaced_changed): Take new font as arg and
6145 check for change against current_mono_font.
6146 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6147 (emacs_settings_constructor, emacs_settings_get_property)
6148 (emacs_settings_set_property, emacs_settings_class_init)
6149 (emacs_settings_init, gsettings_obj): Remove.
6150 (something_changedCB): New function for HAVE_GSETTINGS.
6151 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6152 with value as argument.
6153 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6154 g_settings_new (Bug#8967). Do not create gsettings_obj.
6155 Remove calls to g_settings_bind. Connect something_changedCB to
6158 * xgselect.c: Add defined (HAVE_GSETTINGS).
6159 (xgselect_initialize): Ditto.
6161 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6162 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6165 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6167 * eval.c (struct backtrace): Simplify and port the data structure.
6168 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6169 signed bit field, as this assumption is not portable and it makes
6170 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6171 "char debug_on_exit : 1" as this is not portable either; instead,
6172 use the portable "unsigned int debug_on_exit : 1". Remove unused
6173 member evalargs. Remove obsolete comments about cc bombing out.
6175 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6177 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6178 Let HAVE_GSETTINGS override HAVE_GCONF.
6179 (store_monospaced_changed): New function.
6180 (EMACS_SETTINGS): A new type derived from GObject to handle
6181 GSettings notifications.
6182 (emacs_settings_constructor, emacs_settings_get_property)
6183 (emacs_settings_set_property, emacs_settings_class_init):
6185 (gsettings_client, gsettings_obj): New variables.
6186 (GSETTINGS_SCHEMA): New define.
6187 (something_changedCB): Call store_monospaced_changed.
6188 (init_gsettings): New function.
6189 (xsettings_initialize): Call init_gsettings.
6190 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6193 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6196 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6198 * window.c (resize_root_window, grow_mini_window)
6199 (shrink_mini_window): Rename Qresize_root_window to
6200 Qwindow_resize_root_window and Qresize_root_window_vertically to
6201 Qwindow_resize_root_window_vertically.
6203 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6205 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6207 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6209 * makefile.w32-in: Redesign dependencies so they reflect more
6210 clearly which files are directly included by each source file,
6211 and not through other includes.
6213 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6215 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6216 (sort_overlays, overlay_strings): When an overlay's clone number
6217 matches the window's clone number process the overlay even if
6218 the overlay's window property doesn't match the current window.
6220 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6221 (Fwindow_hchild): Rename to Fwindow_left_child.
6222 (Fwindow_next): Rename to Fwindow_next_sibling.
6223 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6224 (resize_window_check): Rename to window_resize_check.
6225 (resize_window_apply): Rename to window_resize_apply.
6226 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6227 (Fdelete_other_windows_internal, resize_frame_windows)
6228 (Fsplit_window_internal, Fdelete_window_internal)
6229 (grow_mini_window, shrink_mini_window)
6230 (Fresize_mini_window_internal): Fix callers accordingly.
6232 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6234 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6235 (emacs_fixed_set_min_size): Remove.
6236 (emacs_fixed_new): Take frame as argument.
6238 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6239 (_EmacsFixedPrivate): Remove minwidth/height.
6240 Add struct frame *f.
6241 (emacs_fixed_init): Initialize priv->f.
6242 (get_parent_class, emacs_fixed_set_min_size): Remove.
6243 (emacs_fixed_new): Set priv->f to argument.
6244 (emacs_fixed_get_preferred_width)
6245 (emacs_fixed_get_preferred_height): Use min_width/height from
6246 frames size_hint to set minimum and natural (Bug#8919).
6247 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6248 and use min_width/height from frames size_hint to set
6249 min_width/height (Bug#8919).
6251 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6252 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6255 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6257 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6258 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6261 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6263 * process.c (wait_reading_process_output): Bypass select if
6264 waiting for a cell while ignoring keyboard input, and input is
6265 pending. Suggested by Jan Djärv (Bug#8869).
6267 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6269 Use gnulib's dup2 module instead of rolling our own.
6270 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6272 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6274 * dispnew.c (scrolling_window): Before scrolling, turn off a
6275 mouse-highlight in the window being scrolled.
6277 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6279 Move DEFSYM to lisp.h and use everywhere.
6281 * character.h (DEFSYM): Move declaration...
6282 * lisp.h (DEFSYM): ...here.
6288 * w32select.c: Don't include character.h.
6290 * alloc.c (syms_of_alloc):
6291 * buffer.c (syms_of_buffer):
6292 * bytecode.c (syms_of_bytecode):
6293 * callint.c (syms_of_callint):
6294 * casefiddle.c (syms_of_casefiddle):
6295 * casetab.c (init_casetab_once):
6296 * category.c (init_category_once, syms_of_category):
6297 * ccl.c (syms_of_ccl):
6298 * cmds.c (syms_of_cmds):
6299 * composite.c (syms_of_composite):
6300 * dbusbind.c (syms_of_dbusbind):
6301 * dired.c (syms_of_dired):
6302 * dispnew.c (syms_of_display):
6303 * doc.c (syms_of_doc):
6304 * editfns.c (syms_of_editfns):
6305 * emacs.c (syms_of_emacs):
6306 * eval.c (syms_of_eval):
6307 * fileio.c (syms_of_fileio):
6308 * fns.c (syms_of_fns):
6309 * frame.c (syms_of_frame):
6310 * fringe.c (syms_of_fringe):
6311 * insdel.c (syms_of_insdel):
6312 * keymap.c (syms_of_keymap):
6313 * lread.c (init_obarray, syms_of_lread):
6314 * macros.c (syms_of_macros):
6315 * msdos.c (syms_of_msdos):
6316 * print.c (syms_of_print):
6317 * process.c (syms_of_process):
6318 * search.c (syms_of_search):
6319 * sound.c (syms_of_sound):
6320 * syntax.c (init_syntax_once, syms_of_syntax):
6321 * terminal.c (syms_of_terminal):
6322 * textprop.c (syms_of_textprop):
6323 * undo.c (syms_of_undo):
6324 * w32.c (globals_of_w32):
6325 * window.c (syms_of_window):
6326 * xdisp.c (syms_of_xdisp):
6327 * xfaces.c (syms_of_xfaces):
6328 * xfns.c (syms_of_xfns):
6329 * xmenu.c (syms_of_xmenu):
6330 * xsettings.c (syms_of_xsettings):
6331 * xterm.c (syms_of_xterm): Use DEFSYM.
6333 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6335 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6337 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6339 Integer and buffer overflow fixes (Bug#8873).
6341 * print.c (printchar, strout): Check for string overflow.
6342 (PRINTPREPARE, printchar, strout):
6343 Don't set size unless allocation succeeds.
6345 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6346 for sizes. Check for string overflow more accurately.
6347 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6349 * macros.c: Integer and buffer overflow fixes.
6350 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6351 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6352 Use ptrdiff_t, not int, for sizes.
6353 Don't increment bufsize until after realloc succeeds.
6354 Check for size-calculation overflow.
6355 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6357 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6359 * lread.c: Integer overflow fixes.
6360 (read_integer): Radix is now EMACS_INT, not int,
6361 to improve quality of diagnostics for out-of-range radices.
6362 Calculate buffer size correctly for out-of-range radices.
6363 (read1): Check for integer overflow in radices, and in
6364 read-circle numbers.
6365 (read_escape): Avoid int overflow.
6366 (Fload, openp, read_buffer_size, read1)
6367 (substitute_object_recurse, read_vector, read_list, map_obarray):
6368 Use ptrdiff_t, not int, for sizes.
6369 (read1): Use EMACS_INT, not int, for sizes.
6370 Check for size overflow.
6372 * image.c (cache_image): Check for size arithmetic overflow.
6374 * lread.c: Integer overflow issues.
6375 (saved_doc_string_size, saved_doc_string_length)
6376 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6377 Now ptrdiff_t, not int.
6378 (read1): Don't assume doc string length fits in int. Check for
6379 out-of-range doc string lengths.
6380 (read_list): Don't assume file position fits in int.
6381 (read_escape): Check for hex character overflow.
6383 2011-06-22 Leo Liu <sdl.web@gmail.com>
6385 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6386 Move to minibuffer.el.
6388 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6390 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6391 The following patches are for when GLYPH_DEBUG && !XASSERT.
6392 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6393 * dispnew.c (flush_stdout):
6394 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6395 Mark as externally visible.
6396 * dispnew.c (check_window_matrix_pointers): Now static.
6397 * dispnew.c (window_to_frame_vpos):
6398 * xfns.c (unwind_create_frame):
6399 * xterm.c (x_check_font): Remove unused local.
6400 * scroll.c (CHECK_BOUNDS):
6401 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6402 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6403 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6404 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6405 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6407 (debug_method_add): Use va_list and vsprintf rather than relying
6408 on undefined behavior with wrong number of arguments.
6409 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6410 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6411 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6412 since we're not interested in debugging glyphs with old libraries.
6413 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6414 GCC 4.6.0's static checking.
6416 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6418 Integer overflow and signedness fixes (Bug#8873).
6419 A few related buffer overrun fixes, too.
6421 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6423 * dispextern.h (struct face.stipple):
6424 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6425 (x_bitmap_mask, x_allocate_bitmap_record)
6426 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6427 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6428 (x_create_bitmap_from_xpm_data):
6429 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6430 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6432 * xfaces.c (load_pixmap):
6433 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6434 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6435 (.bitmaps_last, struct x_output.icon_bitmap):
6436 Use ptrdiff_t, not int, for bitmap indexes.
6437 (x_allocate_bitmap_record): Check for size overflow.
6438 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6440 Use ptrdiff_t, not int, for overlay counts.
6441 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6442 * editfns.c (overlays_around, get_pos_property):
6443 * textprop.c (get_char_property_and_overlay):
6444 * xdisp.c (next_overlay_change, note_mouse_highlight):
6445 * xfaces.c (face_at_buffer_position):
6446 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6447 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6448 (Fnext_overlay_change, Fprevious_overlay_change)
6449 (mouse_face_overlay_overlaps, Foverlays_in):
6450 Use ptrdiff_t, not int, for sizes.
6451 (overlays_at, overlays_in): Check for size-calculation overflow.
6453 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6455 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6456 (x_session_initialize): Do not assume string length fits in int.
6458 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6459 This is unlikely, but can occur if DPI is outlandish.
6461 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6462 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6464 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6465 * xrdb.c (magic_file_p, search_magic_path):
6466 Omit last arg SUFFIX; it was always 0. All callers changed.
6467 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6469 * xfont.c (xfont_match): Avoid need for strlen.
6471 * xfns.c: Don't assume strlen fits in int.
6472 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6474 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6475 not unsigned long, as we prefer signed integers. All callers changed.
6476 Detect integer overflow in repeat count.
6477 (message_dolog): Don't assume print length fits in 39 bytes.
6478 (display_mode_element): Don't assume strlen fits in int.
6480 * termcap.c: Don't assume sizes fit in int and never overflow.
6481 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6482 (gobble_line): Check for size-calculation overflow.
6484 * minibuf.c (Fread_buffer):
6485 * lread.c (intern, intern_c_string):
6486 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6487 Don't assume string length fits in int.
6489 * keyboard.c (parse_tool_bar_item):
6490 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6492 * font.c: Don't assume string length fits in int.
6493 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6494 Use ptrdiff_t, not int.
6495 (font_intern_prop): Don't assume string length fits in int.
6496 Don't assume integer property fits in fixnum.
6497 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6499 * filelock.c: Fix some buffer overrun and integer overflow issues.
6500 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6501 Reformulate so as not to need the command string.
6502 Invoke gzip -cd rather than gunzip, as it's more portable.
6503 (lock_info_type, lock_file_1, lock_file):
6504 Don't assume pid_t and time_t fit in unsigned long.
6505 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6506 (current_lock_owner): Prefer signed type for sizes.
6507 Use memcpy, not strncpy, where memcpy is what is really wanted.
6508 Don't assume (via atoi) that time_t and pid_t fit in int.
6509 Check for time_t and/or pid_t out of range, e.g., via a network share.
6510 Don't alloca where an auto var works fine.
6512 * fileio.c: Fix some integer overflow issues.
6513 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6514 Don't assume string length fits in int.
6515 (directory_file_name): Don't assume string length fits in long.
6516 (make_temp_name): Don't assume pid fits in int, or that its print
6517 length is less than 20.
6519 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6521 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6523 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6525 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6526 We prefer signed integers, even for size calculations.
6528 * emacs.c: Don't assume string length fits in 'int'.
6529 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6530 (main): Don't invoke strlen when not needed.
6532 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6533 (XD_DEBUG_MESSAGE): Don't waste a byte.
6535 * callproc.c (getenv_internal_1, getenv_internal)
6537 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6539 * lread.c (invalid_syntax): Omit length argument.
6540 All uses changed. This doesn't fix a bug, but it simplifies the
6541 code away from its former Hollerith-constant appearance, and it's
6542 one less 'int' to worry about when looking at integer-overflow issues.
6543 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6545 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6546 This didn't break anything, but it didn't help either.
6547 It's confusing to put a bogus integer in a place where the actual
6548 value does not matter.
6549 (LIST_END_P): Remove unused macro and its bogus comment.
6550 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6552 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6553 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6555 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6556 We prefer signed types, and the value cannot exceed the EMACS_INT
6557 range anyway (because otherwise the length would not be representable).
6558 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6559 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6560 This avoids a GCC warning when WIDE_EMACS_INT.
6562 * indent.c (sane_tab_width): New function.
6563 (current_column, scan_for_column, Findent_to, position_indentation)
6564 (compute_motion): Use it. This is just for clarity.
6565 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6567 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6569 * lisp.h (lint_assume): New macro.
6570 * composite.c (composition_gstring_put_cache):
6571 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6573 * editfns.c, insdel.c:
6574 Omit unnecessary forward decls, to simplify future changes.
6576 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6578 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6580 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6581 Use much-faster test for byte-length change.
6582 Don't assume string byte-length fits in 'int'.
6583 Check that character arg fits in 'int'.
6584 (mapcar1): Declare byte as byte, for clarity.
6586 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6588 * fns.c (concat): Catch string overflow earlier.
6589 Do not rely on integer wraparound.
6591 * dispextern.h (struct it.overlay_strings_charpos)
6592 (struct it.selective): Now EMACS_INT, not int.
6593 * xdisp.c (forward_to_next_line_start)
6594 (back_to_previous_visible_line_start)
6595 (reseat_at_next_visible_line_start, next_element_from_buffer):
6596 Don't arbitrarily truncate the value of 'selective' to int.
6598 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6600 * composite.c: Don't truncate sizes to 'int'.
6601 (composition_gstring_p, composition_reseat_it)
6602 (composition_adjust_point): Use EMACS_INT, not int.
6603 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6604 not EMACS_UINT, for indexes.
6606 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6608 * buffer.c: Include <verify.h>.
6609 (struct sortvec.priority, struct sortstr.priority):
6610 Now EMACS_INT, not int.
6611 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6612 (struct sortstr.size, record_overlay_string)
6613 (struct sortstrlist.size, struct sortlist.used):
6614 Don't truncate size to int.
6615 (record_overlay_string): Check for size-calculation overflow.
6616 (init_buffer_once): Check at compile-time, not run-time.
6618 2011-06-22 Jim Meyering <meyering@redhat.com>
6620 Don't leak an XBM-image-sized buffer
6621 * image.c (xbm_load): Free the image buffer after using it.
6623 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6626 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6627 that Sun C diagnosed.
6628 * fns.c (secure_hash): Fix pointer signedness issue.
6629 * intervals.c (static_offset_intervals): New function.
6630 (offset_intervals): Use it.
6632 2011-06-21 Leo Liu <sdl.web@gmail.com>
6635 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6638 * fns.c (secure_hash): Rename from crypto_hash_function and change
6639 the first arg to accept symbols.
6640 (Fsecure_hash): New primitive.
6641 (syms_of_fns): New symbols.
6643 2011-06-20 Deniz Dogan <deniz@dogan.se>
6645 * process.c (Fset_process_buffer): Clarify return value in
6648 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6650 * dispnew.c (add_window_display_history): Use BVAR.
6652 * xdisp.c (debug_method_add): Use BVAR.
6653 (check_window_end, dump_glyph_matrix, dump_glyph)
6654 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6656 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6659 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6660 check till after the cache is created in init_frame_faces.
6662 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6664 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6666 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6668 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6669 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6670 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6672 Improve buffer-overflow checking (Bug#8873).
6673 * fileio.c (Finsert_file_contents):
6674 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6675 Remove the old (too-loose) buffer overflow checks.
6676 They weren't needed, since make_gap checks for buffer overflow.
6677 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6678 The old code merely checked for Emacs fixnum overflow, and relied
6679 on undefined (wraparound) behavior. The new code avoids undefined
6680 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6682 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6683 Tune. Don't use wider integers than needed. Don't use alloca.
6684 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6686 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6688 * insdel.c, lisp.h (buffer_overflow): New function.
6689 (insert_from_buffer_1, replace_range, replace_range_2):
6690 * insdel.c (make_gap_larger):
6691 * editfns.c (Finsert_char):
6692 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6694 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6696 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6698 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6700 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6701 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6703 * fileio.c: Don't assume EMACS_INT fits in off_t.
6704 (emacs_lseek): New static function.
6705 (Finsert_file_contents, Fwrite_region): Use it.
6706 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6708 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6710 * fns.c: Don't overflow int when computing a list length.
6711 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6712 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6713 truncation on 64-bit hosts. Check for QUIT every
6714 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6715 faster and is responsive enough.
6716 (Flength): Report an error instead of overflowing an integer.
6717 (Fsafe_length): Return a float if the value is not representable
6718 as a fixnum. This shouldn't happen except in contrived situations.
6719 (Fnthcdr, Fsort): Don't assume list length fits in int.
6720 (Fcopy_sequence): Don't assume vector length fits in int.
6722 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6723 (header_size, word_size): New constants.
6724 (allocate_vectorlike): Don't check size overflow here.
6725 (allocate_vector): Check it here instead, since this is the only
6726 caller of allocate_vectorlike that could cause overflow.
6727 Check that the new vector's length is representable as a fixnum.
6729 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6730 The previous code was bogus. For example, next_almost_prime (32)
6731 returned 39, which is undesirable as it is a multiple of 3; and
6732 next_almost_prime (24) returned 25, which is a multiple of 5 so
6733 why was the code bothering to check for multiples of 7?
6735 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6737 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6739 Variadic C functions now count arguments with ptrdiff_t.
6740 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6741 Back then I didn't know that the Emacs coding style prefers signed int.
6742 Also, in the meantime I found a few more instances where arguments
6743 were being counted with int, which may truncate counts on 64-bit
6744 machines, or EMACS_INT, which may be unnecessarily wide.
6745 * lisp.h (struct Lisp_Subr.function.aMANY)
6746 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6747 Arg counts are now ptrdiff_t, not size_t.
6748 All variadic functions and their callers changed accordingly.
6749 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6750 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6751 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6752 * callint.c (Fcall_interactively): Check arg count for overflow,
6753 to avoid potential buffer overrun. Use signed char, not 'int',
6754 for 'varies' array, so that we needn't bother to check its size
6755 calculation for overflow.
6756 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6757 * eval.c (apply_lambda):
6758 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6759 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6760 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6762 * callint.c (Fcall_interactively): Don't use index var as event count.
6764 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6765 * mem-limits.h (SIZE): Remove; no longer used.
6767 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6769 Remove unnecessary casts.
6770 * xterm.c (x_term_init):
6771 * xfns.c (x_set_border_pixel):
6772 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6773 These aren't needed now that we assume ANSI C.
6775 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6776 It's more likely to cause problems (due to unsigned overflow)
6779 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6781 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6783 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6785 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6787 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6789 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6791 GLYPH_CODE_FACE returns EMACS_INT, not int.
6792 * dispextern.h (merge_faces):
6793 * xfaces.c (merge_faces):
6794 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6795 Don't assume EMACS_INT fits in int.
6797 * character.h (CHAR_VALID_P): Remove unused parameter.
6798 * fontset.c, lisp.h, xdisp.c: All uses changed.
6800 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6802 * fns.c (concat): Minor tuning based on overflow analysis.
6803 This doesn't fix any bugs. Use int to hold character, instead
6804 of constantly refetching from Emacs object. Use XFASTINT, not
6805 XINT, for value known to be a character. Don't bother comparing
6806 a single byte to 0400, as it's always less.
6808 * floatfns.c (Fexpt):
6809 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6811 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6814 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6816 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6817 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6818 incorrectly succeed when S was a string, because 4294967386 was
6819 truncated before it was used.
6821 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6822 Otherwise, an out-of-range integer could cause undefined behavior
6825 * composite.c: Use int, not EMACS_INT, for characters.
6826 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6827 EMACS_INT, for values that are known to be in character range.
6828 This doesn't fix any bugs but is the usual style inside Emacs and
6829 may generate better code on 32-bit machines.
6831 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6832 This is for reasons similar to the recent CHAR_STRING fix.
6833 * charset.c (Fencode_char): Check that character arg is actually
6834 a character. Pass an int to ENCODE_CHAR.
6835 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6836 wider than 'int', as a compile-time check to prevent future regressions
6839 * character.c (char_string): Remove unnecessary casts.
6841 Make sure a 64-bit char is never passed to CHAR_STRING.
6842 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6843 by silently ignoring the top 32 bits, allowing some values
6844 that were far too large to be valid characters.
6845 * character.h: Include <verify.h>.
6846 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6847 arguments are no wider than unsigned, as a compile-time check
6848 to prevent future regressions in this area.
6850 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6851 (Fsubst_char_in_region):
6853 * xdisp.c (decode_mode_spec_coding):
6854 Adjust to CHAR_STRING's new requirement.
6855 * editfns.c (Finsert_char, Fsubst_char_in_region):
6856 * fns.c (concat): Check that character args are actually
6857 characters. Without this test, these functions did the wrong
6858 thing with wildly out-of-range values on 64-bit hosts.
6860 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6861 These casts should not be needed on 32-bit hosts, either.
6862 * keyboard.c (read_char):
6863 * lread.c (Fload): Remove casts to unsigned.
6865 * lisp.h (UNSIGNED_CMP): New macro.
6866 This fixes comparison bugs on 64-bit hosts.
6867 (ASCII_CHAR_P): Use it.
6868 * casefiddle.c (casify_object):
6869 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6870 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6871 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6872 * dispextern.h (FACE_FROM_ID):
6873 * keyboard.c (read_char): Use UNSIGNED_CMP.
6875 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6876 not to EMACS_INT, to avoid GCC warning.
6878 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6880 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6881 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6882 isn't needed on 32-bit machines.
6884 * buffer.c (Fgenerate_new_buffer_name):
6885 Use EMACS_INT for count, not int.
6886 (advance_to_char_boundary): Return EMACS_INT, not int.
6888 * data.c (Qcompiled_function): Now static.
6890 * window.c (window_body_lines): Now static.
6892 * image.c (gif_load): Rename local to avoid shadowing.
6894 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6895 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6896 * alloc.c (make_save_value): Integer argument is now of type
6898 (mark_object): Use ptrdiff_t, not int.
6899 * lisp.h (pD): New macro.
6900 * print.c (print_object): Use it.
6902 * alloc.c: Use EMACS_INT, not int, to count objects.
6903 (total_conses, total_markers, total_symbols, total_vector_size)
6904 (total_free_conses, total_free_markers, total_free_symbols)
6905 (total_free_floats, total_floats, total_free_intervals)
6906 (total_intervals, total_strings, total_free_strings):
6907 Now EMACS_INT, not int. All uses changed.
6908 (Fgarbage_collect): Compute overall total using a double, so that
6909 integer overflow is less likely to be a problem. Check for overflow
6910 when converting back to an integer.
6911 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6912 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6913 These were 'int' variables that could overflow on 64-bit hosts;
6914 they were never used, so remove them instead of repairing them.
6915 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6916 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6917 Previously, this ceilinged at INT_MAX, but that doesn't work on
6919 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6921 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6922 (allocate_vectorlike): Check for ptrdiff_t overflow.
6923 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6924 when a (possibly-narrower) signed value would do just as well.
6925 We prefer using signed arithmetic, to avoid comparison confusion.
6927 * alloc.c: Catch some string size overflows that we were missing.
6928 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6929 for convenience in STRING_BYTES_MAX.
6930 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6931 The definition here is exact; the one in lisp.h was approximate.
6932 (allocate_string_data): Check for string overflow. This catches
6933 some instances we weren't catching before. Also, it catches
6934 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6935 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6936 and ptrdiff_t and EMACS_INT are both 64 bits.
6938 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6939 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6940 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6942 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6944 * alloc.c (Fmake_string): Check for out-of-range init.
6946 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6948 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6950 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6952 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6953 xg_get_default_scrollbar_width.
6955 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6956 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6957 (style_changed_cb): Call update_theme_scrollbar_width and call
6958 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6959 all frames (Bug#8505).
6960 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6961 Call gtk_window_set_resizable if HAVE_GTK3.
6962 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6963 and height if HAVE_GTK3 (Bug#8505).
6964 (scroll_bar_width_for_theme): New variable.
6965 (update_theme_scrollbar_width): New function.
6966 (xg_get_default_scrollbar_width): Move code to
6967 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6968 (xg_initialize): Call update_theme_scrollbar_width.
6970 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6972 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6974 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6976 * frame.c (make_frame): Call other_buffer_safely instead of
6979 * window.c (temp_output_buffer_show): Call display_buffer with
6980 second argument Vtemp_buffer_show_specifiers and reset latter
6981 immediately after the call.
6982 (Vtemp_buffer_show_specifiers): New variable.
6983 (auto_window_vscroll_p, next_screen_context_lines)
6984 (Vscroll_preserve_screen_position): Remove leading asterisks from
6987 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6989 Fix minor problems found by GCC 4.6.0 static checking.
6990 * buffer.c (Qclone_number): Remove for now, as it's unused.
6991 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6992 (record_buffer): Remove unused local.
6993 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6994 (set_frame_buffer_list): Remove; unused.
6995 * frame.h (other_visible_frames): Remove decl.
6996 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6997 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6998 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7000 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7001 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7002 Define only if HAVE_GPM.
7003 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7004 (update_hints_inhibit): Remove; never set. All uses removed.
7005 * widgetprv.h (emacsFrameClassRec): Remove decl.
7006 * window.c (delete_deletable_window): Now returns void, since it
7007 wasn't returning anything.
7008 (compare_window_configurations): Remove unused locals.
7009 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7010 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7011 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7012 the same widths as pointers. This follows up on the 2011-05-06 patch.
7013 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7014 * xterm.h: Likewise.
7015 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7017 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7019 * makefile.w32-in: Update dependencies.
7020 (LISP_H): Add lib/intprops.h.
7022 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7024 * image.c (gif_load): Add animation frame delay to the metadata.
7025 (syms_of_image): Use DEFSYM. New symbol `delay'.
7027 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7029 * window.c (delete_deletable_window): Re-add.
7030 (Fset_window_configuration): Rewrite to handle dead buffers and
7031 consequently deletable windows.
7032 (window_tree, Fwindow_tree): Remove. Supply functionality in
7034 (compare_window_configurations): Simplify code.
7036 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7038 * image.c (imagemagick_load_image): Fix type mismatch.
7039 (Fimagemagick_types): Likewise.
7041 * window.h (replace_buffer_in_windows): Declare.
7043 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7045 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7046 Qclone_number. Remove external declaration of Qdelete_window.
7047 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7049 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7050 Run Qbuffer_list_update_hook if allowed.
7051 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7052 buffer list implementation.
7053 (other_buffer_safely): New function.
7054 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7055 calls to replace_buffer_in_windows and
7056 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7058 (record_buffer): Inhibit quitting and rewrite using quittable
7059 functions. Run Qbuffer_list_update_hook if allowed.
7060 (Frecord_buffer, Funrecord_buffer): New functions.
7061 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7062 Move switch-to-buffer to window.el.
7063 (bury-buffer): Move to window.el.
7064 (Vbuffer_list_update_hook): New variable.
7066 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7069 * window.h (resize_frame_windows): Move up in code.
7070 (Fwindow_frame): Remove EXFUN.
7071 (replace_buffer_in_all_windows): Remove prototype.
7072 (replace_buffer_in_windows_safely): Add prototype.
7074 * window.c: Declare Qdelete_window static again. Move down
7075 declaration of select_count.
7076 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7077 (Fother_window): Move to window.el.
7078 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7079 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7080 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7082 (replace_buffer_in_windows): Implement by calling
7083 Qreplace_buffer_in_windows.
7084 (replace_buffer_in_all_windows): Remove with some functionality
7085 moved into replace_buffer_in_windows_safely.
7086 (replace_buffer_in_windows_safely): New function.
7087 (select_window_norecord, select_frame_norecord): Move in front
7088 of run_window_configuration_change_hook. Remove now obsolete
7090 (Fset_window_buffer): Rewrite doc-string.
7091 Call Qrecord_window_buffer.
7092 (keys_of_window): Move binding for other-window to window.el.
7094 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7096 * dispextern.h (struct image): Replace data member, whose int_val
7097 and ptr_val fields were not used by anything, with a single
7100 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7101 (gif_clear_image, gif_load, imagemagick_load_image)
7102 (gs_clear_image, gs_load): Callers changed.
7104 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7106 * buffer.h: Include <time.h>, for time_t.
7107 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7109 Fix minor problems found by static checking.
7111 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7113 Make identifiers static if they are not used in other modules.
7114 * data.c (Qcompiled_function, Qframe, Qvector):
7115 * image.c (QimageMagick, Qsvg):
7116 * minibuf.c (Qmetadata):
7117 * window.c (resize_window_check, resize_root_window): Now static.
7118 * window.h (resize_window_check, resize_root_window): Remove decls.
7120 * window.c (window_deletion_count, delete_deletable_window):
7122 (window_body_lines): Now static.
7123 (Fdelete_other_windows_internal): Mark vars as initialized.
7124 Make sure 'resize_failed' is initialized.
7125 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7126 (resize_window_apply): Remove unused local.
7127 * window.h (delete_deletable_window): Remove decl.
7129 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7130 (imagemagick_load_image): Fix pointer signedness problem by changing
7131 last arg from unsigned char * to char *. All uses changed.
7132 Also, fix a local for similar reasons.
7133 Remove unused locals. Remove locals to avoid shadowing.
7134 (fn_rsvg_handle_free): Remove; unused.
7135 (svg_load, svg_load_image): Fix pointer signedness problem.
7136 (imagemagick_load_image): Don't use garbage pointer image_wand.
7138 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7140 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7142 * image.c (gif_load): Fix omitted cast error introduced by
7145 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7147 * window.h (resize_proportionally, orig_total_lines)
7148 (orig_top_line): Remove from window structure.
7149 (set_window_height, set_window_width, change_window_heights)
7150 (Fdelete_window): Remove prototypes.
7151 (resize_frame_windows): Remove duplicate declaration.
7153 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7155 * window.h (resize_frame_windows, resize_window_check)
7156 (delete_deletable_window, resize_root_window)
7157 (resize_frame_windows): Declare prototypes.
7159 * window.c (resize_window_apply): Make definition be "static" to
7160 match the prototype.
7162 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7164 * window.c: Remove declarations of Qwindow_size_fixed,
7165 window_min_size_1, window_min_size_2, window_min_size,
7166 size_window, window_fixed_size_p, enlarge_window, delete_window.
7167 Remove static from declaration of Qdelete_window, it's
7168 temporarily needed by Fbury_buffer.
7169 (replace_window): Don't assign orig_top_line and
7171 (Fdelete_window, delete_window): Remove. Window deletion is
7172 handled by window.el.
7173 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7174 Replace Fdelete_window calls with calls to Qdelete_window.
7175 (Fdelete_other_windows): Remove. Deleting other windows is
7176 handled by window.el.
7177 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7178 handled in window.el.
7179 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7180 Window minimum sizes are handled in window.el.
7181 (shrink_windows, size_window, set_window_height)
7182 (set_window_width, change_window_heights, window_height)
7183 (window_width, CURBEG, CURSIZE, enlarge_window)
7184 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7185 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7186 handled in window.el.
7187 (make_dummy_parent): Rename to make_parent_window and give it a
7188 second argument horflag.
7189 (make_window): Don't set resize_proportionally any more.
7190 (Fsplit_window): Remove. Windows are split in window.el.
7191 (save_restore_action, save_restore_orig_size)
7192 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7193 Resize mini windows in window.el.
7194 (grow_mini_window, shrink_mini_window): Implement by calling
7195 Qresize_root_window_vertically, resize_window_check and
7196 resize_window_apply.
7197 (saved_window, Fset_window_configuration, save_window_save):
7198 Do not handle orig_top_line, orig_total_lines, and
7199 resize_proportionally.
7200 (window_min_height, window_min_width): Move to window.el.
7201 (keys_of_window): Move bindings for delete-other-windows,
7202 split-window, delete-window and enlarge-window to window.el.
7204 * buffer.c: Temporarily extern Qdelete_window.
7205 (Fbury_buffer): Temporarily call Qdelete_window instead of
7206 Fdelete_window (Fbury_buffer will move to window.el soon).
7208 * frame.c (set_menu_bar_lines_1): Remove code handling
7209 orig_top_line and orig_total_lines.
7211 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7212 set_window_height but set heights directly.
7213 (change_frame_size_1): Use resize_frame_windows.
7215 * xdisp.c (init_xdisp): Don't use set_window_height but set
7218 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7219 Use resize_frame_windows instead of change_window_heights and run
7220 run_window_configuration_change_hook.
7222 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7223 instead of change_window_heights and run
7224 run_window_configuration_change_hook.
7226 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7228 * window.c (replace_window): Rename second argument REPLACEMENT to
7229 NEW. New third argument SETFLAG. Rewrite.
7230 (delete_window, make_dummy_parent): Call replace_window with
7232 (window_list_1): Move down in code.
7233 (run_window_configuration_change_hook): Move set_buffer part
7234 before select_frame_norecord part in order to unwind correctly.
7235 Rename count1 to count.
7236 (recombine_windows, delete_deletable_window, resize_root_window)
7237 (Fdelete_other_windows_internal)
7238 (Frun_window_configuration_change_hook, make_parent_window)
7239 (resize_window_check, resize_window_apply, Fresize_window_apply)
7240 (resize_frame_windows, Fsplit_window_internal)
7241 (Fdelete_window_internal, Fresize_mini_window_internal):
7243 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7245 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7247 * window.h (window): Add some new members to window structure -
7248 normal_lines, normal_cols, new_total, new_normal, clone_number,
7249 splits, nest, prev_buffers, next_buffers.
7250 (WINDOW_TOTAL_SIZE): Move here from window.c.
7251 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7253 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7255 (make_dummy_parent): Set new members of windows structure.
7256 (make_window): Move down in code. Handle new members of window
7258 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7259 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7260 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7261 (Fset_window_prev_buffers, Fwindow_next_buffers)
7262 (Fset_window_next_buffers, Fset_window_clone_number):
7264 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7265 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7267 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7268 Argument WINDOW can be now internal window too.
7269 (Fwindow_use_time): Move up in code.
7270 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7272 (Fset_window_configuration, saved_window)
7273 (Fcurrent_window_configuration, save_window_save): Handle new
7274 members of window structure.
7275 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7276 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7277 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7278 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7279 Qget_mru_window, Qresize_root_window,
7280 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7281 Qauto_buffer_name; staticpro them.
7283 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7285 * window.c (Fwindow_total_size, Fwindow_left_column)
7286 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7287 (Fwindow_list_1): New functions.
7288 (window_box_text_cols): Replace with window_body_cols.
7289 (Fwindow_width, Fscroll_left, Fscroll_right):
7290 Use window_body_cols instead of window_box_text_cols.
7291 (delete_window, Fset_window_configuration):
7292 Call delete_all_subwindows with window as argument.
7293 (delete_all_subwindows): Take a window as argument and not a
7295 (window_loop): Remove handling of GET_LRU_WINDOW and
7297 (Fget_lru_window, Fget_largest_window): Move to window.el.
7299 * window.h: Extern window_body_cols instead of
7300 window_box_text_cols. delete_all_subwindows now takes a
7301 Lisp_Object as argument.
7303 * indent.c (compute_motion, Fcompute_motion):
7304 Use window_body_cols instead of window_box_text_cols.
7306 * frame.c (delete_frame): Call delete_all_subwindows with root
7309 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7311 * fns.c (Fputhash): Document return value.
7313 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7315 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7317 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7319 Cons<->int and similar integer overflow fixes (Bug#8794).
7321 Check for overflow when converting integer to cons and back.
7322 * charset.c (Fdefine_charset_internal, Fdecode_char):
7323 Use cons_to_unsigned to catch overflow.
7324 (Fencode_char): Use INTEGER_TO_CONS.
7325 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7326 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7327 * data.c (long_to_cons, cons_to_long): Remove.
7328 (cons_to_unsigned, cons_to_signed): New functions.
7329 These signal an error for invalid or out-of-range values.
7330 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7331 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7332 * font.c (Ffont_variation_glyphs):
7333 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7334 * lisp.h: Include <intprops.h>.
7335 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7336 (cons_to_signed, cons_to_unsigned): New decls.
7337 (long_to_cons, cons_to_long): Remove decls.
7338 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7339 (Fprimitive_undo): Use CONS_TO_INTEGER.
7340 * xfns.c (Fx_window_property): Likewise.
7341 * xselect.c: Include <limits.h>.
7342 (x_own_selection, selection_data_to_lisp_data):
7343 Use INTEGER_TO_CONS.
7344 (x_handle_selection_request, x_handle_selection_clear)
7345 (x_get_foreign_selection, Fx_disown_selection_internal)
7346 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7347 (lisp_data_to_selection_data): Use cons_to_unsigned.
7348 (x_fill_property_data): Use cons_to_signed.
7349 Report values out of range.
7351 Check for buffer and string overflow more precisely.
7352 * buffer.h (BUF_BYTES_MAX): New macro.
7353 * lisp.h (STRING_BYTES_MAX): New macro.
7354 * alloc.c (Fmake_string):
7355 * character.c (string_escape_byte8):
7356 * coding.c (coding_alloc_by_realloc):
7357 * doprnt.c (doprnt):
7358 * editfns.c (Fformat):
7360 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7361 since they may not be the same number.
7362 * editfns.c (Finsert_char):
7363 * fileio.c (Finsert_file_contents):
7364 Likewise for BUF_BYTES_MAX.
7366 * image.c: Use ptrdiff_t, not int, for sizes.
7367 (slurp_file): Switch from int to ptrdiff_t.
7369 (slurp_file): Check that file size fits in both size_t (for
7370 malloc) and ptrdiff_t (for sanity and safety).
7372 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7373 if b->modtime has its maximal value.
7375 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7377 Don't assume time_t can fit into int.
7378 * buffer.h (struct buffer.modtime): Now time_t, not int.
7379 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7380 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7382 Minor fixes for signed vs unsigned integers.
7383 * character.h (MAYBE_UNIFY_CHAR):
7384 * charset.c (maybe_unify_char):
7385 * keyboard.c (read_char, reorder_modifiers):
7386 XINT -> XFASTINT, since the integer must be nonnegative.
7387 * ftfont.c (ftfont_spec_pattern):
7388 * keymap.c (access_keymap, silly_event_symbol_error):
7389 XUINT -> XFASTINT, since the integer must be nonnegative.
7390 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7391 since it makes no difference and we prefer signed.
7392 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7393 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7396 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7398 * window.h (Fwindow_frame): Declare.
7400 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7402 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7403 (SPARE_MEMORY): Always define.
7404 (LARGE_REQUEST): Remove.
7405 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7407 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7409 * lisp.h: Move EXFUNS for Fframe_root_window,
7410 Fframe_first_window and Fset_frame_selected_window to window.h.
7412 * window.h: Move EXFUNS for Fframe_root_window,
7413 Fframe_first_window and Fset_frame_selected_window here from
7416 * frame.c (Fwindow_frame, Fframe_first_window)
7417 (Fframe_root_window, Fframe_selected_window)
7418 (Fset_frame_selected_window): Move to window.c.
7419 (Factive_minibuffer_window): Move to minibuf.c.
7420 (Fother_visible_frames_p): New function.
7422 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7424 * window.c (decode_window, decode_any_window): Move up in code.
7425 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7426 (inhibit_frame_unsplittable): Remove unused variable.
7427 (Fwindow_buffer): Move up and rewrite doc-string.
7428 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7429 (Fwindow_prev): New functions.
7430 (Fwindow_frame): Move here from frame.c. Accept any window as
7432 (Fframe_root_window, Fframe_first_window)
7433 (Fframe_selected_window): Move here from frame.c. Accept frame
7434 or arbitrary window as argument. Update doc-strings.
7435 (Fminibuffer_window): Move up in code.
7436 (Fwindow_minibuffer_p): Move up in code and simplify.
7437 (Fset_frame_selected_window): Move here from frame.c.
7439 (Fselected_window, select_window, Fselect_window): Move up in
7440 code. Minor doc-string fixes.
7442 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7444 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7445 Do not assume that spare memory exists; that assumption is valid
7446 only if SYSTEM_MALLOC.
7447 (LARGE_REQUEST): New macro, so that the issue of large requests
7448 is separated from the issue of spare memory.
7450 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7452 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7455 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7457 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7460 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7462 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7464 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7466 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7467 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7469 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7471 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7473 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7475 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7476 (x_clipboard_manager_save): Add return value.
7477 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7479 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7480 Obey Vx_select_enable_clipboard_manager. Catch errors in
7481 x_clipboard_manager_save (Bug#8779).
7482 (Vx_select_enable_clipboard_manager): New variable.
7483 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7485 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7487 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7489 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7491 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7492 in the current matrix if keep_current_p is non-zero.
7494 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7496 * bidi.c (bidi_level_of_next_char): Fix last change.
7498 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7500 Support bidi reordering of text covered by display properties.
7502 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7503 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7504 (bidi_cache_search, bidi_cache_iterator_state)
7505 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7506 (bidi_level_of_next_char, bidi_move_to_visually_next):
7507 Support character positions inside a run of characters covered by a
7509 (bidi_paragraph_init, bidi_resolve_explicit_1)
7510 (bidi_level_of_next_char): Call bidi_fetch_char and
7511 bidi_fetch_char_advance instead of FETCH_CHAR and
7513 (bidi_init_it): Initialize new members.
7514 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7516 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7517 instead of using explicit *_CHAR codes.
7518 (bidi_resolve_explicit, bidi_resolve_weak):
7519 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7520 bidirectional text is supported only in multibyte buffers.
7521 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7522 it to initialize the frame_window_p member of struct bidi_it.
7523 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7524 (bidi_resolve_explicit, bidi_resolve_weak)
7525 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7526 bidi_it->nchars is non-positive.
7527 (bidi_level_of_next_char): Don't try to lookup the cache for the
7528 next/previous character if nothing is cached there yet, or if we
7529 were just reseat()'ed to a new position.
7531 * xdisp.c (set_cursor_from_row): Set start and stop points
7532 according to the row's direction when priming the loop that looks
7533 for the glyph on which to display cursor.
7534 (single_display_spec_intangible_p): Function deleted.
7535 (display_prop_intangible_p): Reimplement to call
7536 handle_display_spec instead of single_display_spec_intangible_p.
7537 Accept 3 additional arguments needed by handle_display_spec.
7538 This fixes incorrect cursor motion across display property with complex
7539 values: lists, `(when COND...)' forms, etc.
7540 (single_display_spec_string_p): Support property values that are
7541 lists with the argument STRING its top-level element.
7542 (display_prop_string_p): Fix the condition for processing a
7543 property that is a list to be consistent with handle_display_spec.
7544 (handle_display_spec): New function, refactored from the
7545 last portion of handle_display_prop.
7546 (compute_display_string_pos): Accept additional argument
7547 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7548 value of a `display' property is a "replacing spec".
7549 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7550 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7551 the display property, but just return a value indicating whether
7552 the display property will replace the characters it covers.
7553 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7554 frame_window_p members of struct bidi_it.
7555 (compute_display_string_pos, compute_display_string_end):
7557 (push_it): Accept second argument POSITION, where pop_it should
7558 jump to continue iteration.
7559 (reseat_1): Initialize bidi_it.disp_pos.
7561 * keyboard.c (adjust_point_for_property): Adjust the call to
7562 display_prop_intangible_p to its new signature.
7564 * dispextern.h (struct bidi_it): New member frame_window_p.
7565 (bidi_init_it): Update prototypes.
7566 (display_prop_intangible_p): Update prototype.
7567 (compute_display_string_pos, compute_display_string_end):
7569 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7572 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7574 Malloc failure behavior now depends on size of allocation.
7575 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7576 * lisp.h: Change signatures accordingly.
7577 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7578 All callers changed. (Bug#8762)
7580 * gnutls.c: Use Emacs's memory allocators.
7581 Without this change, the gnutls library would invoke malloc etc.
7582 directly, which causes problems on non-SYNC_INPUT hosts, and which
7583 runs afoul of improving memory_full behavior. (Bug#8761)
7584 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7585 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7586 xfree instead of the default malloc, realloc, free.
7587 (Fgnutls_boot): No need to check for memory allocation failure,
7588 since xmalloc does that for us.
7590 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7591 * category.c (hash_get_category_set):
7592 * ccl.c (ccl_driver):
7593 * charset.c (Fdefine_charset_internal):
7594 * charset.h (struct charset.hash_index):
7595 * composite.c (get_composition_id, gstring_lookup_cache)
7596 (composition_gstring_put_cache):
7597 * composite.h (struct composition.hash_index):
7598 * dispextern.h (struct image.hash):
7599 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7600 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7601 (hashfn_equal, hashfn_user_defined, make_hash_table)
7602 (maybe_resize_hash_table, hash_lookup, hash_put)
7603 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7604 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7605 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7606 * image.c (make_image, search_image_cache, lookup_image)
7607 (xpm_put_color_table_h):
7608 * lisp.h (struct Lisp_Hash_Table):
7609 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7610 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7611 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7612 * alloc.c (allocate_vectorlike):
7613 Check for overflow in vector size calculations.
7614 * ccl.c (ccl_driver):
7615 Check for overflow when converting EMACS_INT to int.
7616 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7617 need to be updated by these changes.
7618 * fns.c (make_hash_table, maybe_resize_hash_table):
7619 Check for integer overflow with large hash tables.
7620 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7621 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7622 (SXHASH_REDUCE): New macro.
7623 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7624 Use it instead of discarding useful hash info with large hash values.
7625 (sxhash_float): New function.
7626 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7627 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7628 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7629 Rewrite to use FIXNUM_BITS, as this simplifies things.
7630 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7631 Adjust signatures to match updated version of code.
7632 (consing_since_gc): Now EMACS_INT, since a single hash table can
7633 use more than INT_MAX bytes.
7635 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7637 Make it possible to build with GCC-4.6+ -O2 -flto.
7639 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7641 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7643 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7644 Call minibuffer-inactive-mode.
7646 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7648 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7649 Update dependencies.
7651 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7653 * data.c (init_data): Remove code for UTS, this system is not
7656 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7658 Don't force ./temacs to start in terminal mode.
7660 * frame.c (make_initial_frame): Initialize faces in all cases, not
7661 only when CANNOT_DUMP is defined.
7662 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7664 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7666 * dispnew.c (add_window_display_history): Use const for the string
7667 pointer. Remove declaration, not needed.
7669 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7671 Use 'inline', not 'INLINE'.
7672 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7673 * alloc.c, fontset.c (INLINE): Remove.
7674 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7675 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7676 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7677 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7678 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7680 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7682 Make it possible to run ./temacs.
7684 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7685 syms_of_callproc does the same thing. Remove test for
7686 "initialized", do it in the caller.
7687 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7689 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7691 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7692 (read_minibuf): Use get_minibuffer.
7693 (syms_of_minibuf): Use DEFSYM.
7694 (Qmetadata): New var.
7695 * data.c (Qbuffer): Don't make it static.
7696 (syms_of_data): Use DEFSYM.
7698 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7700 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7701 (CCL_CODE_MIN): New macro.
7703 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7705 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7707 * eval.c (Qdebug): Now static.
7708 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7709 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7710 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7712 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7714 * image.c: Various fixes to ImageMagick code comments.
7715 (Fimagemagick_types): Doc fix.
7717 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7719 Minor fixes prompted by GCC 4.6.0 warnings.
7721 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7723 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7724 (x_clipboard_manager_save_all): Move extern decl to ...
7725 * xterm.h: ... here, so that it can be checked for consistency.
7727 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7729 * xselect.c (x_clipboard_manager_save_frame)
7730 (x_clipboard_manager_save_all): New functions.
7731 (Fx_clipboard_manager_save): Lisp function deleted.
7733 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7734 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7736 * xterm.h: Update prototype.
7738 2011-05-28 William Xu <william.xwl@gmail.com>
7740 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7743 2011-05-28 Jim Meyering <meyering@redhat.com>
7745 Avoid a sign-extension bug in crypto_hash_function.
7746 * fns.c (to_uchar): Define.
7747 (crypto_hash_function): Use it to convert some newly-signed
7748 variables to unsigned, to avoid sign-extension bugs. For example,
7749 without this change, (md5 "truc") would evaluate to
7750 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7751 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7752 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7754 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7756 Integer overflow fixes.
7758 * dbusbind.c: Serial number integer overflow fixes.
7759 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7760 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7761 to hold a serial number that is too large for a fixnum.
7762 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7763 Check for serial numbers out of range. Decode any serial number
7764 that was so large that it became a float. (Bug#8722)
7766 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7767 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7768 Use XFASTINT rather than XUINT when numbers are nonnegative.
7769 (xd_append_arg, Fdbus_method_return_internal):
7770 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7771 arguments, check that Lisp number is nonnegative, rather than
7772 silently wrapping negative numbers around. (Bug#8722)
7773 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7776 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7778 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7780 ccl: Add integer overflow checks.
7781 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7782 (IN_INT_RANGE): New macros.
7783 (ccl_driver): Use them to check for integer overflow when
7784 decoding a CCL program. Many of the new checks are whether XINT (x)
7785 fits in int; it doesn't always, on 64-bit hosts. The new version
7786 doesn't catch all possible integer overflows, but it's an
7787 improvement. (Bug#8719)
7789 * alloc.c (make_event_array): Use XINT, not XUINT.
7790 There's no need for unsigned here.
7792 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7793 This follows up to the 2011-05-06 change that substituted uintptr_t
7794 for EMACS_INT. This case wasn't caught back then.
7796 Rework Fformat to avoid integer overflow issues.
7797 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7798 now (part of C89). Include <verify.h>.
7799 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7800 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7801 (Fformat): Avoid the prepass trying to compute sizes; it was only
7802 approximate and thus did not catch overflow reliably. Instead, walk
7803 through the format just once, formatting and computing sizes as we go,
7804 checking for integer overflow at every step, and allocating a larger
7805 buffer as needed. Keep track separately whether the format is
7806 multibyte. Keep only the most-recently calculated precision, rather
7807 than them all. Record whether each argument has been converted to
7808 string. Use EMACS_INT, not int, for byte and char and arg counts.
7809 Support field widths and precisions larger than INT_MAX. Avoid
7810 sprintf's undefined behavior with conversion specifications such as %#d
7811 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7812 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7813 formatting out-of-range floating point numbers with int
7816 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7818 * data.c: Avoid integer truncation in expressions involving floats.
7819 * data.c: Include <intprops.h>.
7820 (arith_driver): When there's an integer overflow in an expression
7821 involving floating point, convert the integers to floating point
7822 so that the resulting value does not suffer from catastrophic
7823 integer truncation. For example, on a 64-bit host (* 4
7824 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7825 Do not rely on undefined behavior after integer overflow.
7827 merge count_size_as_multibyte, parse_str_to_multibyte
7828 * character.c, character.h (count_size_as_multibyte):
7829 Rename from parse_str_to_multibyte; all uses changed.
7830 Check for integer overflow.
7831 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7832 since it's now a duplicate of the other. This is more of
7833 a character than a buffer op, so better that it's in character.c.
7834 * fns.c, print.c: Adjust to above changes.
7836 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7838 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7840 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7842 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7843 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7844 (x_clipboard_manager_save): Now static.
7845 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7847 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7848 (crypto_hash_function): Now static.
7849 Fix pointer signedness problems. Avoid unnecessary initializations.
7851 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7853 * termhooks.h (Vselection_alist): Make it terminal-local.
7855 * terminal.c (create_terminal): Initialize it.
7857 * xselect.c: Support for clipboard managers.
7858 (Vselection_alist): Move to termhooks.h as terminal-local var.
7859 (LOCAL_SELECTION): New macro.
7860 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7861 (symbol_to_x_atom): Remove gratuitous arg.
7862 (x_handle_selection_request, lisp_data_to_selection_data)
7863 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7864 (x_own_selection, x_get_local_selection, x_convert_selection):
7865 New arg, specifying work frame. Use terminal-local Vselection_alist.
7866 (some_frame_on_display): Delete unused function.
7867 (Fx_own_selection_internal, Fx_get_selection_internal)
7868 (Fx_disown_selection_internal, Fx_selection_owner_p)
7869 (Fx_selection_exists_p): New optional frame arg.
7870 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7871 (x_handle_selection_clear): Don't treat other terminals with the
7872 same keyboard specially. Use the terminal-local Vselection_alist.
7873 (x_clear_frame_selections): Use Frun_hook_with_args.
7875 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7877 * xterm.h: Add support for those atoms.
7879 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7881 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7882 (converted_selections, conversion_fail_tag): New global variables.
7883 (x_selection_request_lisp_error): Free the above.
7884 (x_get_local_selection): Remove unnecessary code.
7885 (x_reply_selection_request): Args changed; handle arbitrary array
7886 of converted selections stored in converted_selections.
7887 Separate the XChangeProperty and SelectionNotify steps.
7888 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7889 (x_convert_selection): New function.
7890 (x_handle_selection_event): Simplify.
7891 (x_get_foreign_selection): Don't ignore incoming requests while
7892 waiting for an answer; this will fail when we implement
7893 SAVE_TARGETS, and seems unnecessary anyway.
7894 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7895 (Vx_sent_selection_functions): Doc fix.
7897 2011-05-26 Leo Liu <sdl.web@gmail.com>
7899 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7901 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7903 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7905 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7906 for fringe update if it has periodic bitmap.
7907 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7908 and fringe_bitmap_periodic_p.
7910 * fringe.c (get_fringe_bitmap_data): New function.
7911 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7912 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7913 row. Mark glyph row for fringe update if periodicity changed.
7915 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7916 for fringe update unless it has periodic bitmap.
7918 2011-05-25 Kenichi Handa <handa@m17n.org>
7920 * xdisp.c (get_next_display_element): Set correct it->face_id for
7921 a static composition.
7923 2011-05-24 Leo Liu <sdl.web@gmail.com>
7926 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7928 * fns.c (crypto_hash_function, Fsha1): New function.
7929 (Fmd5): Use crypto_hash_function.
7930 (syms_of_fns): Add Ssha1.
7932 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7934 * gnutls.c: Remove unused macros.
7935 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7936 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7937 Remove macros that are defined and never used.
7938 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7940 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7942 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7943 (Fx_get_selection_internal): Minor cleanup.
7944 (Fx_own_selection_internal): Rename arguments for consistency with
7947 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7949 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7951 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7953 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7955 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7957 * dispnew.c (scrolling_window): Don't exclude the case that the
7958 last enabled row in the desired matrix touches the bottom boundary.
7960 2011-05-21 Glenn Morris <rgm@gnu.org>
7962 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7963 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7964 and add some more files.
7966 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7968 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7969 report_file_error introduced by the change from 2011-05-07.
7971 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7973 * systime.h (Time): Define only if emacs is defined.
7974 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7975 where the include path doesn't have X11/X.h by default. See
7976 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7978 2011-05-20 Kenichi Handa <handa@m17n.org>
7980 * composite.c (find_automatic_composition): Fix previous change.
7982 2011-05-20 Glenn Morris <rgm@gnu.org>
7984 * lisp.mk: New file, split from Makefile.in.
7985 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7986 (shortlisp): Remove.
7987 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7989 2011-05-19 Glenn Morris <rgm@gnu.org>
7991 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7992 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7993 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7994 (lisp): Set the order to that of loadup.el.
7995 (shortlisp): Make it a copy of $lisp.
7996 (SOME_MACHINE_LISP): Remove.
7997 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7998 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8000 2011-05-18 Kenichi Handa <handa@m17n.org>
8002 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8003 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8004 (find_automatic_composition): Mostly rewrite for efficiency.
8006 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8008 * makefile.w32-in: Update dependencies.
8010 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8012 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8013 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8015 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8017 Fix some integer overflow issues, such as string length overflow.
8019 * insdel.c (count_size_as_multibyte): Check for string overflow.
8021 * character.c (lisp_string_width): Check for string overflow.
8022 Use EMACS_INT, not int, for string indexes and lengths; in
8023 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8024 the resulting string length overflows an EMACS_INT; instead,
8025 report a string overflow if no precision given. When checking for
8026 precision exhaustion, use a check that cannot possibly have
8027 integer overflow. (Bug#8675)
8028 * character.h (lisp_string_width): Adjust to new signature.
8030 * alloc.c (string_overflow): New function.
8031 (Fmake_string): Use it. This doesn't change behavior, but saves
8032 a few bytes and will simplify future changes.
8033 * character.c (string_escape_byte8): Likewise.
8034 * lisp.h (string_overflow): New decl.
8036 Fixups, following up to the user-interface timestamp change.
8037 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8038 for UI timestamps, instead of unsigned long.
8039 * msdos.c (mouse_get_pos): Likewise.
8040 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8041 * w32gui.h (Time): Define by including "systime.h" rather than by
8042 declaring it ourselves. (Bug#8664)
8044 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8045 * image.c (clear_image_cache): Likewise.
8047 * term.c (term_mouse_position): Don't assume time_t wraparound.
8049 Be more systematic about user-interface timestamps.
8050 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8051 and sometimes 'EMACS_UINT', to represent these timestamps.
8052 This change causes it to use 'Time' uniformly, as that's what X uses.
8053 This makes the code easier to follow, and makes it easier to catch
8054 integer overflow bugs such as Bug#8664.
8055 * frame.c (Fmouse_position, Fmouse_pixel_position):
8056 Use Time, not unsigned long, for user-interface timestamps.
8057 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8058 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8059 * keyboard.h (last_event_timestamp): Likewise.
8060 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8061 * menu.h (xmenu_show): Likewise.
8062 * term.c (term_mouse_position): Likewise.
8063 * termhooks.h (struct input_event.timestamp): Likewise.
8064 (struct terminal.mouse_position_hook): Likewise.
8065 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8066 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8067 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8068 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8070 * menu.h, termhooks.h: Include "systime.h", for Time.
8072 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8073 Don't assume that the difference between two unsigned long values
8074 can fit into an integer. At this point, we know button_down_time
8075 <= event->timestamp, so the difference must be nonnegative, so
8076 there's no need to cast the result if double-click-time is
8077 nonnegative, as it should be; check that it's nonnegative, just in
8078 case. This bug is triggered when events are more than 2**31 ms
8079 apart (about 25 days). (Bug#8664)
8081 * xselect.c (last_event_timestamp): Remove duplicate decl.
8082 (x_own_selection): Remove needless cast to unsigned long.
8084 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8085 that always fit in int. Use a sentinel instead of a counter, to
8086 avoid a temp and to allay GCC's concerns about possible int overflow.
8087 * frame.h (struct frame): Use int for menu_bar_items_used
8088 instead of EMACS_INT, since it always fits in int.
8090 * menu.c (grow_menu_items): Check for int overflow.
8092 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8094 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8095 Before, the code was not consistent. These values cannot exceed
8096 2**31 - 1 so there's no need to make them unsigned.
8097 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8098 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8099 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8101 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8103 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8104 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8105 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8106 presumably because the widths might not match.
8108 * window.c (size_window): Avoid needless test at loop start.
8110 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8112 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8114 2011-05-12 Drew Adams <drew.adams@oracle.com>
8116 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8118 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8120 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8121 `width' to `bar_area_x' and `bar_area_width', respectively.
8122 (x_scroll_run): Take account of fringe background extension.
8124 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8125 Rename local vars `left' and `width' to `bar_area_x' and
8126 `bar_area_width', respectively.
8127 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8128 background extension.
8130 2011-05-10 Jim Meyering <meyering@redhat.com>
8132 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8134 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8136 * image.c (Finit_image_library): Return t for built-in image types,
8137 like pbm and xbm. (Bug#8640)
8139 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8141 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8143 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8145 * w32console.c (Fset_screen_color): Doc fix.
8146 (Fget_screen_color): New function.
8147 (syms_of_ntterm): Defsubr it.
8149 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8150 unlink the temporary file if Fcall_process didn't create it in the
8152 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8153 child process will be redirected to a file specified with `:file'.
8154 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8155 cue to call_process_cleanup not to close that handle.
8157 2011-05-07 Ben Key <bkey76@gmail.com>
8159 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8160 one of two shell specific rules, either bootstrap-temacs-CMD or
8161 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8162 to the previous implementation of the bootstrap-temacs rule.
8163 The bootstrap-temacs-CMD rule is similar to the previous
8164 implementation of the bootstrap-temacs rule except that it
8165 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8168 These changes, along with some changes to nt/configure.bat,
8169 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8170 earlier fix to add support for --cflags and --ldflags options
8171 that include quotes so that it works whether make uses cmd or
8174 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8176 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8177 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8179 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8180 a string. Handle both cases.
8181 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8182 (Fdbus_register_method): Use Qinvalid_function.
8184 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8186 * makefile.w32-in: Update dependencies.
8187 (LISP_H): Add inttypes.h and stdin.h.
8188 (PROCESS_H): Add unistd.h.
8190 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8192 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8193 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8195 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8197 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8199 * term.c (vfatal): Remove stray call to va_end.
8200 It's not needed and the C Standard doesn't allow it here anyway.
8202 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8203 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8205 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8208 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8210 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8212 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8214 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8216 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8218 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8219 * charset.c (Fdefine_charset_internal): Don't initialize
8220 charset.code_space[15]. The value was garbage, on hosts with
8221 32-bit int (Bug#8600).
8223 * lread.c (read_integer): Be more consistent with string-to-number.
8224 Use string_to_number to do the actual conversion; this avoids
8225 rounding errors and fixes some other screwups. Without this fix,
8226 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8227 (digit_to_number): Move earlier, for benefit of read_integer.
8228 Return -1 if the digit is out of range for the base, -2 if it is
8229 not a digit in any supported base. (Bug#8602)
8231 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8233 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8234 to match comment at start of function. This also removes a
8235 GCC warning about overflow in a 32+64-bit port.
8237 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8239 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8240 Reported by Stefan Monnier in
8241 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8242 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8243 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8245 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8246 (EMACS_UINTPTR): Likewise, with uintptr_t.
8248 * lisp.h: Prefer 64-bit EMACS_INT if available.
8249 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8250 on 32-bit hosts that have 64-bit int, so that they can access
8252 However, temporarily disable this change unless the temporary
8253 symbol WIDE_EMACS_INT is defined.
8255 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8257 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8258 This removes an assumption that EMACS_INT and long are the same
8259 width as pointers. The assumption is true for Emacs porting targets
8260 now, but we want to make other targets possible.
8261 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8262 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8263 In the rest of the code, change types of integers that hold casted
8264 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8265 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8266 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8267 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8268 No need to cast type when ORing.
8269 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8270 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8271 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8272 assume EMACS_INT is the same width as char *.
8273 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8274 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8275 Remove no-longer-needed casts.
8276 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8277 (xg_tool_bar_help_callback, xg_make_tool_item):
8278 Use EMACS_INTPTR to hold an integer
8279 that will be cast to void *; this can avoid a GCC warning
8280 if EMACS_INT is not the same width as void *.
8281 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8282 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8283 (current_message_1, set_message_1):
8284 Use a local to convert to proper width without a cast.
8285 * xmenu.c (dialog_selection_callback): Likewise.
8287 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8288 Also, don't assume VALBITS / RAND_BITS is less than 5,
8289 and don't rely on undefined behavior when shifting a 1 left into
8291 * lisp.h (get_random): Change signature to match.
8293 * lread.c (hash_string): Use size_t, not int, for hash computation.
8294 Normally we prefer signed values; but hashing is special, because
8295 it's better to use unsigned division on hash table sizes so that
8296 the remainder is nonnegative. Also, size_t is the natural width
8297 for hashing into memory. The previous code used 'int', which doesn't
8298 retain enough info to hash well into very large tables.
8299 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8301 * dbusbind.c: Don't possibly lose pointer info when converting.
8302 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8303 Use XPNTR rather than XHASH, so that the high-order bits of
8304 the pointer aren't lost when converting through void *.
8306 * eval.c (Fautoload): Don't double-shift a pointer.
8308 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8310 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8312 * gnutls.c (DEF_GNUTLS_FN):
8313 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8315 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8317 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8320 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8322 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8323 New version that can reserve upto 2GB of heap space.
8325 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8327 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8329 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8331 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8332 `gnutls_certificate_set_x509_key_file'.
8334 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8336 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8337 Update dependencies.
8339 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8341 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8342 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8343 Remove unused parameter `fildes'.
8344 * process.c (read_process_output, send_process): Don't pass it.
8346 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8348 Fix previous change: the library cache is defined in w32.c.
8349 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8350 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8352 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8354 Implement dynamic loading of GnuTLS on Windows.
8356 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8357 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8358 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8361 * gnutls.c (Qgnutls_dll): Define.
8362 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8363 (gnutls_*): Declare function pointers.
8364 (init_gnutls_functions): New function to initialize function pointers.
8365 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8366 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8367 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8368 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8369 (emacs_gnutls_write, emacs_gnutls_read)
8370 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8371 (Fgnutls_available_p): New function.
8372 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8373 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8374 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8376 * image.c: Include w32.h.
8377 (Vimage_type_cache): Delete.
8378 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8379 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8380 (w32_delayed_load): Move to w32.c.
8382 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8384 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8385 (w32_delayed_load): Move from image.c. When loading a library, record
8386 its filename in the :loaded-from property of the library id.
8387 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8388 Initialize and staticpro them.
8389 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8391 * process.c: Include lisp.h before w32.h, not after.
8392 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8393 instead of gnutls_record_check_pending.
8395 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8397 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8399 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8400 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8403 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8405 * xterm.c (x_set_frame_alpha): Do not set property on anything
8406 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8408 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8410 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8412 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8414 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8415 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8416 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8417 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8418 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8419 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8420 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8421 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8422 (Qgnutls_bootprop_callbacks_verify): Make static.
8424 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8426 * callproc.c: Indentation fixup.
8428 * sysdep.c (wait_for_termination_1): Make static.
8429 (wait_for_termination, interruptible_wait_for_termination):
8430 Move after wait_for_termination_1.
8432 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8434 * sysdep.c (interruptible_wait_for_termination): New function
8435 which is like wait_for_termination, but allows keyboard
8438 * callproc.c (Fcall_process): Add (:file "file") as an option for
8440 (Fcall_process_region): Ditto.
8442 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8444 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8445 rather than `XVECTOR (FOO)->size'.
8447 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8448 inttypes.h, as a gnulib replacement is used if it not available in
8451 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8453 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8454 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8455 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8457 * coding.c (coding_alloc_by_realloc): Error out if destination
8458 will grow beyond MOST_POSITIVE_FIXNUM.
8459 (decode_coding_emacs_mule): Abort if there isn't enough place in
8460 charbuf for the composition carryover bytes. Reserve an extra
8461 space for up to 2 characters produced in a loop.
8462 (decode_coding_iso_2022): Abort if there isn't enough place in
8463 charbuf for the composition carryover bytes.
8465 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8467 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8468 aborting when %lld or %lll format is passed.
8469 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8470 %llo or %llx format is passed. (Bug#8545)
8472 * window.c (window_scroll_line_based): Use a marker instead of
8473 simple variables to record original value of point. (Bug#7952)
8475 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8476 produced by %s or %c overflows available buffer space. (Bug#8545)
8478 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8480 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8481 (SIZE_MAX): Move defn after all includes, as they might #define it.
8483 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8485 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8487 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8489 * keyboard.c (Qdelayed_warnings_hook): Define.
8490 (command_loop_1): Run `delayed-warnings-hook'
8491 if Vdelayed_warnings_list is non-nil.
8492 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8493 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8495 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8497 * doprnt.c (doprnt): Don't return value smaller than the buffer
8498 size if the message was truncated. (Bug#8545).
8500 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8502 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8503 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8505 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8507 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8509 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8511 * makefile.w32-in: Update dependencies.
8513 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8515 Improve `doprnt' and its usage. (Bug#8545)
8516 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8517 `format_end'. Remove support for %l as a conversion specifier.
8518 Don't use xrealloc. Improve diagnostics when the %l size modifier
8519 is used. Update the commentary.
8521 * eval.c (verror): Simplify calculation of size_t.
8523 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8526 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8528 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8531 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8533 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8534 This makes this file independent of the recent pseudovector change.
8536 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8538 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8540 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8541 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8542 Remove unused local.
8543 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8545 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8546 GCC 4.6.0 optimizes based on type-based alias analysis.
8547 For example, if b is of type struct buffer * and v of type struct
8548 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8549 != &v->size, and therefore "v->size = 1; b->size = 2; return
8550 v->size;" must therefore return 1. This assumption is incorrect
8551 for Emacs, since it type-puns struct Lisp_Vector * with many other
8552 types. To fix this problem, this patch adds a new type struct
8553 vectorlike_header that documents the constraints on layout of vectors
8554 and pseudovectors, and helps optimizing compilers not get fooled
8555 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8556 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8557 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8559 (XSETPVECTYPE): Rewrite in terms of new macro.
8560 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8561 This is a bit clearer, and further avoids the possibility of
8562 undesirable aliasing.
8563 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8564 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8565 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8566 since Lisp_Subr is a special case (no "next" field).
8567 (ASIZE): Now uses header.size rather than size.
8568 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8569 to avoid the hassle of writing XVECTOR (foo)->header.size.
8570 (struct vectorlike_header): New type.
8571 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8572 object, to help avoid aliasing.
8573 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8574 (SUBRP): Likewise, since Lisp_Subr is a special case.
8575 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8576 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8577 (struct Lisp_Hash_Table): Combine first two members into a single
8578 struct vectorlike_header member. All uses of "size" and "next" members
8579 changed to be "header.size" and "header.next".
8580 * buffer.h (struct buffer): Likewise.
8581 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8582 * frame.h (struct frame): Likewise.
8583 * process.h (struct Lisp_Process): Likewise.
8584 * termhooks.h (struct terminal): Likewise.
8585 * window.c (struct save_window_data, struct saved_window): Likewise.
8586 * window.h (struct window): Likewise.
8587 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8588 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8589 * buffer.c (init_buffer_once): Likewise.
8590 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8592 * process.c (Fformat_network_address): Use local var for size,
8595 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8597 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8598 * data.c (atof): Remove decl; no longer used or needed.
8599 (digit_to_number): Move to lread.c.
8600 (Fstring_to_number): Use new string_to_number function, to be
8601 consistent with how the Lisp reader treats infinities and NaNs.
8602 Do not assume that floating-point numbers represent EMACS_INT
8603 without losing information; this is not true on most 64-bit hosts.
8604 Avoid double-rounding errors, by insisting on integers when
8605 parsing non-base-10 numbers, as the documentation specifies.
8606 * lisp.h (string_to_number): New decl, replacing ...
8607 (isfloat_string): Remove.
8608 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8609 (read1): Do not accept +. and -. as integers; this
8610 appears to have been a coding error. Similarly, do not accept
8611 strings like +-1e0 as floating point numbers. Do not report
8612 overflow for integer overflows unless the base is not 10 which
8613 means we have no simple and reliable way to continue.
8614 Break out the floating-point parsing into a new
8615 function string_to_number, so that Fstring_to_number parses
8616 floating point numbers consistently with the Lisp reader.
8617 (digit_to_number): Move here from data.c. Make it static inline.
8618 (E_CHAR, EXP_INT): Remove, replacing with ...
8619 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8620 (string_to_number): New function, replacing isfloat_string.
8621 This function checks for valid syntax and produces the resulting
8622 Lisp float number too. Rework it so that string-to-number
8623 no longer mishandles examples like "1.0e+". Use strtoumax,
8624 so that overflow for non-base-10 numbers is reported only when
8625 there's no portable and simple way to convert to floating point.
8627 * textprop.c (set_text_properties_1): Rewrite for clarity,
8628 and to avoid GCC warning about integer overflow.
8630 * intervals.h (struct interval): Use EMACS_INT for members
8631 where EMACS_UINT might cause problems. See
8632 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8633 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8634 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8636 (offset_intervals): Tell GCC not to worry about length overflow
8637 when negating a negative length.
8639 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8640 (overrun_check_free): Likewise.
8642 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8643 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8646 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8647 (gnutls_make_error): Rename local to avoid shadowing.
8648 (gnutls_emacs_global_deinit): ifdef out; not used.
8649 (Fgnutls_boot): Use const for pointer to readonly storage.
8650 Comment out unused local. Fix pointer signedness problems.
8652 * lread.c (openp): Don't stuff size_t into an 'int'.
8653 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8654 about possible signed overflow.
8656 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8657 (GDK_KEY_g): Don't define if already defined.
8658 (xg_prepare_tooltip): Avoid pointer signedness problem.
8659 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8661 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8662 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8664 * xfns.c (Fx_window_property): Simplify a bit,
8665 to make a bit faster and to avoid GCC 4.6.0 warning.
8666 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8668 * fns.c (internal_equal): Don't assume size_t fits in int.
8670 * alloc.c (compact_small_strings): Tighten assertion a little.
8672 Replace pEd with more-general pI, and fix some printf arg casts.
8673 * lisp.h (pI): New macro, generalizing old pEd macro to other
8674 conversion specifiers. For example, use "...%"pI"d..." rather
8675 than "...%"pEd"...".
8676 (pEd): Remove. All uses replaced with similar uses of pI.
8677 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8678 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8679 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8680 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8681 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8682 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8683 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8685 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8686 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8687 * print.c (safe_debug_print, print_object): Likewise.
8688 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8690 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8691 avoiding the 0 flag, which is not portable.
8692 * process.c (Fmake_network_process): Use pI to avoid cast.
8693 * region-cache.c (pp_cache): Likewise.
8694 * xdisp.c (decode_mode_spec): Likewise.
8695 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8696 behavior on 64-bit hosts with printf arg.
8697 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8698 (x_stop_queuing_selection_requests): Likewise.
8699 (x_get_window_property): Don't truncate byte count to an 'int'
8702 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8703 here, since it parses constructs like leading '-' and spaces,
8704 which are not wanted; and it overflows with large numbers.
8705 Instead, simply match F[0-9]+, which is what is wanted anyway.
8707 * alloc.c: Remove unportable assumptions about struct layout.
8708 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8709 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8710 (allocate_vectorlike, make_pure_vector): Use the new macros,
8711 plus offsetof, to remove unportable assumptions about struct layout.
8712 These assumptions hold on all porting targets that I know of, but
8713 they are not guaranteed, they're easy to remove, and removing them
8714 makes further changes easier.
8716 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8717 This doesn't fix a bug but makes the code clearer.
8718 (string_overrun_cookie): Now const. Use initializers that
8719 don't formally overflow signed char, to avoid warnings.
8720 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8721 can cause Emacs to crash when string overrun checking is enabled.
8722 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8723 multiple of sizeof (EMACS_INT); it need not be, if
8724 alignof(EMACS_INT) < sizeof (EMACS_INT).
8725 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8727 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8729 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8731 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8733 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8734 supposed to be handshaking. (Bug#8556)
8735 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8737 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8739 * lisp.h (Qdebug): List symbol.
8740 * eval.c (Qdebug): Restore global linkage.
8741 * keyboard.c (debug-on-event): New variable.
8742 (handle_user_signal): Break into debugger when debug-on-event
8743 matches the current signal symbol.
8745 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8747 * alloc.c (check_sblock, check_string_bytes)
8748 (check_string_free_list): Convert to standard C.
8750 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8752 * w32.c (emacs_gnutls_push): Fix typo.
8754 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8756 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8757 "cast to pointer from integer of different size".
8759 Improve doprnt and its use in verror. (Bug#8545)
8760 * doprnt.c (doprnt): Document the set of format control sequences
8761 supported by the function. Use SAFE_ALLOCA instead of always
8764 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8765 is one byte too soon. Don't use xrealloc; instead xfree and
8768 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8770 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8773 * gnutls.c: Renamed global_initialized to
8774 gnutls_global_initialized. Added internals for the
8775 :verify-hostname-error, :verify-error, and :verify-flags
8776 parameters of `gnutls-boot' and documented those parameters in the
8777 docstring. Start callback support.
8778 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8779 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8780 on error. Return error code.
8781 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8782 (emacs_gnutls_read): Likewise.
8783 (Fgnutls_boot): Return handshake error code.
8784 (emacs_gnutls_handle_error): New function.
8785 (wsaerror_to_errno): Likewise.
8787 * w32.h (emacs_gnutls_pull): Add prototype.
8788 (emacs_gnutls_push): Likewise.
8790 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8791 (emacs_gnutls_push): Likewise.
8793 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8795 * process.c (wait_reading_process_output): Check if GnuTLS
8796 buffered some data internally if no FDs are set for TLS
8799 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8800 (LIBS): Link to USER_LIBS.
8801 ($(BLD)/gnutls.$(0)): New target.
8803 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8805 * xdisp.c (handle_single_display_spec): Rename the
8806 display_replaced_before_p argument into display_replaced_p, to
8807 make it consistent with the commentary. Fix typos in the
8810 * textprop.c (syms_of_textprop): Remove dead code.
8811 (copy_text_properties): Delete obsolete commentary about an
8812 interface that was deleted long ago. Fix typos in the description
8815 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8816 to changes in oldXMenu/XMenu.h from 2011-04-16.
8817 <menu_help_message, prev_menu_help_message>: Constify.
8818 (IT_menu_make_room): menu->help_text is now `const char **';
8821 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8822 to changes in oldXMenu/XMenu.h from 2011-04-16.
8823 (struct XMenu): Declare `help_text' `const char **'.
8825 * xfaces.c <Qunspecified>: Make extern again.
8827 * syntax.c: Include sys/types.h before including regex.h, as
8830 * doc.c (get_doc_string): Improve the format passed to `error'.
8832 * doprnt.c (doprnt): Improve commentary.
8834 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8836 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8839 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8840 changes in globals.h immediately force recompilation.
8841 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8842 $(CURDIR)/s/ms-w32.h.
8843 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8845 * character.c (Fchar_direction): Function deleted.
8846 (syms_of_character): Don't defsubr it.
8847 <char-direction-table>: Deleted.
8849 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8851 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8852 * doprnt.c: Include limits.h.
8853 (SIZE_MAX): New macro.
8854 (doprnt): Return a size_t value. 2nd arg is now size_t.
8855 Many local variables are now size_t instead of int or unsigned.
8856 Improve overflow protection. Support `l' modifier for integer
8857 conversions. Support %l conversion. Don't assume an EMACS_INT
8858 argument for integer conversions and for %c.
8860 * lisp.h (doprnt): Restore prototype.
8862 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8865 * Makefile.in (base_obj): Add back doprnt.o.
8867 * deps.mk (doprnt.o): Add back prerequisites.
8868 (callint.o): Depend on character.h.
8870 * eval.c (internal_lisp_condition_case): Include the handler
8871 representation in the error message.
8872 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8873 when breaking from the loop.
8875 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8877 * callint.c (Fcall_interactively): When displaying error message
8878 about invalid control letter, pass the character's codepoint, not
8879 a pointer to its multibyte form. Improve display of the character
8880 in octal and display also its hex code.
8882 * character.c (char_string): Use %x to display the (unsigned)
8883 codepoint of an invalid character, to avoid displaying a bogus
8886 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8887 `error', not SYMBOL_NAME itself.
8889 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8890 character arguments to `error'.
8892 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8893 to `error' in error message about FINAL_CHAR argument. Make sure
8894 FINAL_CHAR is a character, and use %c when it is passed as
8895 argument to `error'.
8897 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8899 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8901 * w32.c: Include <time.h>.
8902 (sys_localtime): New function.
8904 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8906 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8908 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8910 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8912 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8915 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8917 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8918 gl_state.e_property when gl_state.object is Qt.
8920 * insdel.c (make_gap_larger): Remove limitation of buffer size
8923 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8925 * xdisp.c (lookup_glyphless_char_display)
8926 (produce_glyphless_glyph): Handle cons cell entry in
8927 glyphless-char-display.
8928 (Vglyphless_char_display): Document it.
8930 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8931 glyphless-char-display.
8933 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8935 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8937 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8939 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8940 definition for no-X builds.
8942 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8944 Static checks with GCC 4.6.0 and non-default toolkits.
8946 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8948 * process.c (keyboard_bit_set): Define only if SIGIO.
8949 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8950 (send_process): Repair possible setjmp clobbering.
8952 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8954 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8956 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8958 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8959 Define only if needed.
8961 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8962 by pacifying GCC about it. Maybe it's time to retire it?
8963 * xfaces.c (USG, __TIMEVAL__): Likewise.
8965 * dispextern.h (struct redisplay_interface): Rename param
8967 * termhooks.h (struct terminal): Likewise.
8968 * xterm.c (xembed_send_message): Likewise.
8970 * insdel.c (make_gap_smaller): Define only if
8971 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8973 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8976 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8977 so that we aren't warned about unused symbols.
8979 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8981 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8983 * xfns.c (x_real_positions): Mark locals as initialized.
8985 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8987 * xterm.c: Fix problems found by static analysis with other toolkits.
8988 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8989 (x_dispatch_event): Declare static if USE_GTK, and
8990 define if USE_GTK || USE_X_TOOLKIT.
8991 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8992 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8993 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8994 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8996 * xmenu.c (menu_help_callback): Pointer type fixes.
8997 Use const pointers when pointing at readonly data. Avoid pointer
8999 (FALSE): Remove unused macro.
9000 (update_frame_menubar): Remove unused decl.
9002 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9004 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9005 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9006 (single_menu_item): Rename local to avoid shadowing.
9008 * keyboard.c (make_lispy_event): Remove unused local var.
9010 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9011 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9013 * bitmaps: Change bitmaps from unsigned char back to the X11
9014 compatible char. Avoid the old compiler warnings about
9015 out-of-range initializers by using, for example, '\xab' rather
9018 * xgselect.c (xgselect_initialize): Check vs interface
9019 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9021 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9023 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9024 to read-only memory.
9026 * fns.c (vector): Remove; this old hack is no longer needed.
9028 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9030 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9032 * xrdb.c (x_load_resources): Omit unused local.
9034 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9035 (x_window): Rename locals to avoid shadowing.
9036 (USG): Use the kludged USG macro, to pacify gcc.
9038 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9039 (x_term_init): Remove local to avoid shadowing.
9041 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9043 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9044 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9046 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9048 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9050 Fix regex.c, syntax.c and friends for buffers > 2GB.
9051 * syntax.h (struct gl_state_s): Declare character position members
9054 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9056 * textprop.c (verify_interval_modification, interval_of):
9057 Declare arguments EMACS_INT.
9059 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9062 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9064 * indent.c (Fvertical_motion): Local variable it_start is now
9067 * regex.c (re_match, re_match_2, re_match_2_internal)
9068 (bcmp_translate, regcomp, regexec, print_double_string)
9069 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9070 (re_compile_pattern, re_exec): Declare arguments and local
9071 variables `size_t' and `ssize_t' and return values `regoff_t', as
9073 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9074 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9075 <compile_stack_type>: `size' and `avail' are now `size_t'.
9077 * regex.h <regoff_t>: Use ssize_t, not int.
9078 (re_search, re_search_2, re_match, re_match_2): Arguments that
9079 specify buffer/string position and length are now ssize_t and
9080 size_t. Return type is regoff_t.
9082 2011-04-16 Ben Key <bkey76@gmail.com>
9084 * nsfont.m: Fixed bugs in ns_get_family and
9085 ns_descriptor_to_entity that were caused by using free to
9086 deallocate memory blocks that were allocated by xmalloc (via
9087 xstrdup). This caused Emacs to crash when compiled with
9088 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9089 --enable-checking=xmallocoverrun). xfree is now used to
9090 deallocate these memory blocks.
9092 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9094 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9096 emacs_write: Accept and return EMACS_INT for sizes.
9097 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9099 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9100 Accept and return EMACS_INT.
9101 (emacs_gnutls_write): Return the number of bytes written on
9103 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9104 (emacs_read, emacs_write): Remove check for negative size, as the
9105 Emacs source code has been audited now.
9106 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9107 (emacs_read, emacs_write): Use it.
9108 * process.c (send_process): Adjust to the new signatures of
9109 emacs_write and emacs_gnutls_write. Do not attempt to store
9110 a byte offset into an 'int'; it might overflow.
9111 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9113 * sound.c: Don't assume sizes fit in 'int'.
9114 (struct sound_device.period_size, alsa_period_size):
9115 Return EMACS_INT, not int.
9116 (struct sound_device.write, vox_write, alsa_write):
9117 Accept EMACS_INT, not int.
9118 (wav_play, au_play): Use EMACS_INT to store sizes and to
9119 record read return values.
9121 2011-04-15 Ben Key <bkey76@gmail.com>
9123 * keyboard.c (Qundefined): Don't declare static since it is used
9125 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9126 static since they are used in nsfont.m.
9128 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9130 * process.c (Qprocessp): Don't declare static.
9131 * lisp.h (Qprocessp): Declare again.
9133 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9135 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9137 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9139 Improve C-level modularity by making more things 'static'.
9141 Don't publish debugger-only interfaces to other modules.
9142 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9143 (verify_bytepos, count_markers): Move decls to the only modules
9145 * region-cache.h (pp_cache): Likewise.
9146 * window.h (check_all_windows): Likewise.
9147 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9149 * sysdep.c (croak): Now static, if
9150 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9151 * syssignal.h (croak): Declare only if not static.
9153 * alloc.c (refill_memory_reserve): Now static if
9154 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9155 * lisp.h (refill_memory_reserve): Declare only if not static.
9157 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9158 Define only if USE_LUCID.
9160 * xrdb.c (x_customization_string, x_rm_string): Now static.
9162 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9163 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9165 * xdisp.c (draw_row_with_mouse_face): Now static.
9166 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9168 * window.h (check_all_windows): Mark externally visible.
9170 * window.c (window_deletion_count): Now static.
9172 * undo.c: Make symbols static if they're not exported.
9173 (last_undo_buffer, last_boundary_position, pending_boundary):
9176 * textprop.c (interval_insert_behind_hooks): Now static.
9177 (interval_insert_in_front_hooks): Likewise.
9179 * term.c: Make symbols static if they're not exported.
9180 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9181 (max_frame_lines, tty_set_terminal_modes):
9182 (tty_reset_terminal_modes, tty_turn_off_highlight):
9183 (get_tty_terminal): Now static.
9184 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9185 * termhooks.h (term_mouse_moveto): Do not declare if
9187 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9188 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9190 * sysdep.c: Make symbols static if they're not exported.
9191 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9193 (sigprocmask_set, full_mask): Remove; unused.
9194 (wait_debugging): Mark as visible.
9195 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9196 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9198 * syntax.c (syntax_temp): Define only if !__GNUC__.
9200 * sound.c (current_sound_device, current_sound): Now static.
9202 * search.c (searchbufs, searchbuf_head): Now static.
9204 * scroll.c (scroll_cost): Remove; unused.
9205 * dispextern.h (scroll_cost): Remove decl.
9207 * region-cache.h (pp_cache): Mark as externally visible.
9209 * process.c: Make symbols static if they're not exported.
9210 (process_tick, update_tick, create_process, chan_process):
9211 (Vprocess_alist, proc_buffered_char, datagram_access):
9212 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9213 (deactivate_process): Mark defn as static, as well as decl.
9214 * lisp.h (create_process): Remove decl.
9215 * process.h (chan_process, Vprocess_alist): Remove decls.
9217 * print.c: Make symbols static if they're not exported.
9218 (print_depth, new_backquote_output, being_printed, print_buffer):
9219 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9220 (print_interval, print_number_index, initial_stderr_stream):
9222 * lisp.h (Fprinc): Remove decl.
9223 (debug_output_compilation_hack): Mark as externally visible.
9225 * sysdep.c (croak): Move decl from here to syssignal.h.
9226 * syssignal.h (croak): Put it here, so the API can be checked when
9227 'croak' is called from dissociate_if_controlling_tty.
9229 * minibuf.c: Make symbols static if they're not exported.
9230 (minibuf_save_list, choose_minibuf_frame): Now static.
9231 * lisp.h (choose_minibuf_frame): Remove decl.
9233 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9235 * lread.c: Make symbols static if they're not exported.
9236 (read_objects, initial_obarray, oblookup_last_bucket_number):
9238 (make_symbol): Remove; unused.
9239 * lisp.h (initial_obarray, make_symbol): Remove decls.
9241 * keyboard.c: Make symbols static if they're not exported.
9242 (single_kboard, recent_keys_index, total_keys, recent_keys):
9243 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9244 (this_single_command_key_start, echoing, last_auto_save):
9245 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9246 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9247 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9248 (Vlispy_mouse_stem, double_click_count):
9250 (force_auto_save_soon): Define only if SIGDANGER.
9251 (ignore_mouse_drag_p): Now static if
9252 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9253 (print_help): Remove; unused.
9254 (stop_character, last_timer_event): Mark as externally visible.
9255 * keyboard.h (ignore_mouse_drag_p): Declare only if
9256 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9257 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9258 * lisp.h (echoing): Remove decl.
9259 (force_auto_save_soon): Declare only if SIGDANGER.
9260 * xdisp.c (redisplay_window): Simplify code, to make it more
9261 obvious that ignore_mouse_drag_p is not accessed if !defined
9262 USE_GTK && !defined HAVE_NS.
9264 * intervals.c: Make symbols static if they're not exported.
9265 (merge_properties_sticky, merge_interval_right, delete_interval):
9267 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9269 * insdel.c: Make symbols static if they're not exported.
9270 However, leave prepare_to_modify_buffer alone. It's never
9271 called from outside this function, but that appears to be a bug.
9272 (combine_after_change_list, combine_after_change_buffer):
9273 (adjust_after_replace, signal_before_change): Now static.
9274 (adjust_after_replace_noundo): Remove; unused.
9275 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9276 (signal_before_change): Remove decls.
9278 * indent.c (val_compute_motion, val_vmotion): Now static.
9280 * image.c: Make symbols static if they're not exported.
9281 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9283 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9284 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9286 * fringe.c (standard_bitmaps): Now static.
9287 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9289 * frame.c: Make symbols static if they're not exported.
9290 (x_report_frame_params, make_terminal_frame): Now static.
9291 (get_frame_param): Now static, unless HAVE_NS.
9292 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9293 (x_get_resource_string): Remove; not used.
9294 * frame.h (make_terminal_frame, x_report_frame_params):
9295 (x_get_resource_string); Remove decls.
9296 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9297 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9299 * font.c, fontset.c: Make symbols static if they're not exported.
9300 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9301 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9302 * font.c (font_close_object): Now static.
9303 * font.h (font_close_object): Remove.
9304 * fontset.c (FONTSET_OBJLIST): Remove.
9305 (free_realized_fontset) #if-0 the body, which does nothing.
9306 (face_suitable_for_char_p): #if-0, as it's never called.
9307 * fontset.h (face_suitable_for_char_p): Remove decl.
9308 * xfaces.c (face_at_string_position):
9309 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9310 since 0 is always ASCII.
9312 * fns.c (weak_hash_tables): Now static.
9314 * fileio.c: Make symbols static if they're not exported.
9315 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9316 (Vwrite_region_annotation_buffers): Now static.
9318 * eval.c: Make symbols static if they're not exported.
9319 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9320 * lisp.h (backtrace_list): Remove decl.
9322 * emacs.c: Make symbols static if they're not exported.
9323 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9324 (fatal_error_code, fatal_error_signal_hook, standard_args):
9326 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9327 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9328 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9329 * lisp.h (fatal_error_signal_hook): Remove decl.
9330 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9332 * editfns.c: Move a (normally-unused) function to its only use.
9333 * editfns.c, lisp.h (get_operating_system_release): Remove.
9334 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9335 worth the hassle of breaking this out.
9337 * xterm.c: Make symbols static if they're not exported.
9338 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9339 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9340 (x_destroy_window, x_delete_display):
9342 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9343 (x_mouse_leave): Remove; unused.
9344 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9345 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9346 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9348 (x_mouse_leave): Declare only if WINDOWSNT.
9349 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9350 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9353 * ftxfont.c: Make symbols static if they're not exported.
9354 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9356 * font.h (ftxfont_driver): Likewise.
9358 * xfns.c: Make symbols static if they're not exported.
9359 (x_last_font_name, x_display_info_for_name):
9360 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9361 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9362 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9363 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9364 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9365 (last_show_tip_args): Now static.
9366 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9367 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9368 (x_screen_planes): Remove; unused.
9369 * dispextern.h (x_screen_planes): Remove decl.
9371 * dispnew.c: Make symbols static if they're not exported.
9372 * dispextern.h (redraw_garbaged_frames, scrolling):
9373 (increment_row_positions): Remove.
9374 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9375 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9377 (redraw_garbaged_frames): Remove; unused.
9379 * xfaces.c: Make symbols static if they're not exported.
9380 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9382 * xterm.h (defined_color): Remove decls.
9383 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9384 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9385 (menu_face_changed_default, defined_color, free_realized_face):
9386 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9387 (ascii_face_of_lisp_face): Remove; unused.
9389 * xdisp.c: Make symbols static if they're not exported.
9390 * dispextern.h (scratch_glyph_row, window_box_edges):
9391 (glyph_to_pixel_coords, set_cursor_from_row):
9392 (get_next_display_element, set_iterator_to_next):
9393 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9394 (show_mouse_face): Remove decls
9395 * frame.h (message_buf_print): Likewise.
9396 * lisp.h (pop_message, set_message, check_point_in_composition):
9398 * xterm.h (set_vertical_scroll_bar): Likewise.
9399 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9400 (message_buf_print, scratch_glyph_row, displayed_buffer):
9401 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9402 (get_next_display_element, show_mouse_face, window_box_edges):
9403 (frame_to_window_pixel_xy, check_point_in_composition):
9404 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9405 (glyph_to_pixel_coords): Remove; unused.
9407 * dired.c (file_name_completion): Now static.
9409 * dbusbind.c (xd_in_read_queued_messages): Now static.
9411 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9412 * data.c (circular_list_error): Remove.
9414 * commands.h (last_point_position, last_point_position_buffer):
9415 (last_point_position_window): Remove decls.
9416 * keyboard.c: Make these variables static.
9418 * coding.h (coding, code_convert_region, encode_coding_gap):
9420 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9421 (iso_code_class, detect_coding, code_convert_region): Now static.
9422 (encode_coding_gap): Remove; unused.
9424 * chartab.c (chartab_chars, chartab_bits): Now static.
9426 * charset.h (charset_iso_8859_1): Remove decl.
9427 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9430 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9431 * ccl.c (Vccl_program_table): Now static.
9432 (check_ccl_update): Remove; unused.
9434 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9435 * category.h: ... from here.
9436 * category.c (check_category_table, set_category_set): Now static.
9438 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9439 * lisp.h: Remove these decls.
9441 * buffer.c (buffer_count): Remove unused var.
9443 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9444 so that it's not optimized away.
9445 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9446 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9447 exported only to the debugger.
9449 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9450 * atimer.h (run_all_atimers): Remove; not exported.
9452 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9453 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9454 was inaccessible from Lisp.
9455 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9456 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9458 alloc.c: Import and export fewer symbols, and remove unused items.
9459 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9461 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9462 it's not optimized away by whole-program optimization.
9463 (message_enable_multibyte, free_misc): Remove.
9464 (catchlist, handlerlist, mark_backtrace):
9465 Declare only if BYTE_MARK_STACK.
9466 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9467 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9468 (message_enable_multibyte): Remove decl.
9469 (free_misc, interval_free_list, float_block, float_block_index):
9470 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9471 (cons_free_list, last_marked_index):
9473 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9474 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9475 (mark_backtrace): Define only if BYTE_MARK_STACK.
9476 * xdisp.c (message_enable_multibyte): Now static.
9478 Declare Lisp_Object Q* variables to be 'static' if not exported.
9479 This makes it easier for human readers (and static analyzers)
9480 to see whether these variables are used from other modules.
9481 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9482 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9483 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9484 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9485 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9486 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9487 * xmenu.c, xselect.c:
9488 Declare Q* vars static if they are not used in other modules.
9489 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9490 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9491 Remove decls of unexported vars.
9492 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9494 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9496 Make Emacs functions such as Fatom 'static' by default.
9497 This makes it easier for human readers (and static analyzers)
9498 to see whether these functions can be called from other modules.
9499 DEFUN now defines a static function. To make the function external
9500 so that it can be used in other C modules, use the new macro DEFUE.
9501 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9502 (Finit_image_library):
9503 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9504 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9505 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9506 Remove decls, since these functions are now static.
9507 (Funintern, Fget_internal_run_time): New decls, since these functions
9508 were already external.
9510 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9511 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9512 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9513 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9514 * keyboard.c, keymap.c, lread.c:
9515 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9516 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9517 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9518 Mark functions with DEFUE instead of DEFUN,
9519 if they are used in other modules.
9520 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9521 decls for now-static functions.
9522 * buffer.h (Fdelete_overlay): Remove decl.
9523 * callproc.c (Fgetenv_internal): Mark as internal.
9524 * composite.c (Fremove_list_of_text_properties): Remove decl.
9525 (Fcomposition_get_gstring): New forward static decl.
9526 * composite.h (Fcomposite_get_gstring): Remove decl.
9527 * dired.c (Ffile_attributes): New forward static decl.
9528 * doc.c (Fdocumntation_property): New forward static decl.
9529 * eval.c (Ffetch_bytecode): New forward static decl.
9530 (Funintern): Remove extern decl; now in .h file where it belongs.
9531 * fileio.c (Fmake_symbolic_link): New forward static decl.
9532 * image.c (Finit_image_library): New forward static decl.
9533 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9534 * intervals.h (Fprevious_property_change):
9535 (Fremove_list_of_text_properties): Remove decls.
9536 * keyboard.c (Fthis_command_keys): Remove decl.
9537 (Fcommand_execute): New forward static decl.
9538 * keymap.c (Flookup_key): New forward static decl.
9539 (Fcopy_keymap): Now static.
9540 * keymap.h (Flookup_key): Remove decl.
9541 * process.c (Fget_process): New forward static decl.
9542 (Fprocess_datagram_address): Mark as internal.
9543 * syntax.c (Fsyntax_table_p): New forward static decl.
9544 (skip_chars): Remove duplicate decl.
9545 * textprop.c (Fprevious_property_change): New forward static decl.
9546 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9548 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9549 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9551 * editfns.c (Fformat): Remove unreachable code.
9553 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9555 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9558 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9560 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9561 when at ZV. (Bug#8487)
9563 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9565 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9567 * keyboard.c (parse_tool_bar_item): Likewise.
9568 * sound.c (sound_cleanup, alsa_close): Likewise.
9569 * termcap.c (tgetent): Likewise.
9570 * xfns.c (x_default_font_parameter): Likewise.
9571 * xsettings.c (read_and_apply_settings): Likewise.
9573 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9574 (overrun_check_free): Protoize.
9576 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9578 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9579 since callers should never pass a negative size.
9580 Change the signature to match that of plain 'read' and 'write'; see
9581 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9582 * lisp.h: Update prototypes of emacs_write and emacs_read.
9584 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9586 * xdisp.c (redisplay_window): Don't try to determine the character
9587 position of the scroll margin if the window start point w->startp
9588 is outside the buffer's accessible region. (Bug#8468)
9590 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9592 Fix write-region and its subroutines for buffers > 2GB.
9593 * fileio.c (a_write, e_write): Modify declaration of arguments and
9594 local variables to support buffers larger than 2GB.
9595 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9597 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9598 argument, local variables, and return value.
9600 * lisp.h: Update prototypes of emacs_write and emacs_read.
9602 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9604 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9606 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9608 Fix more problems found by GCC 4.6.0's static checks.
9610 * xdisp.c (vmessage): Use a better test for character truncation.
9612 * charset.c (load_charset_map): <, not <=, for optimization,
9613 and to avoid potential problems with integer overflow.
9614 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9615 * casetab.c (set_identity, shuffle): Likewise.
9616 * editfns.c (Fformat): Likewise.
9617 * syntax.c (skip_chars): Likewise.
9619 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9620 This also lets GCC 4.6.0 generate slightly better loop code.
9622 * callint.c (Fcall_interactively): <, not <=, for optimization.
9623 (Fcall_interactively): Count the number of arguments produced,
9624 not the number of arguments given. This is simpler and lets GCC
9625 4.6.0 generate slightly better code.
9627 * ftfont.c: Distingish more carefully between FcChar8 and char.
9628 The previous code passed unsigned char * to a functions like
9629 strlen and xstrcasecmp that expect char *, which does not
9630 conform to the C standard.
9631 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9632 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9633 char * when the C standard requires it.
9635 * keyboard.c (read_char): Remove unused var.
9637 * eval.c: Port to Windows vsnprintf (Bug#8435).
9639 (SIZE_MAX): Define if the headers do not.
9640 (verror): Do not give up if vsnprintf returns a negative count.
9641 Instead, grow the buffer. This ports to Windows vsnprintf, which
9642 does not conform to C99. Problem reported by Eli Zaretskii.
9643 Also, simplify the allocation scheme, by avoiding the need for
9644 calling realloc, and removing the ALLOCATED variable.
9646 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9648 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9649 But keep the doprint source code for now, as we might revamp it
9650 and use it again (Bug#8435).
9651 * lisp.h (doprnt): Remove.
9652 * Makefile.in (base_obj): Remove doprnt.o.
9653 * deps.mk (doprnt.o): Remove.
9655 error: Print 32- and 64-bit integers portably (Bug#8435).
9656 Without this change, on typical 64-bit hosts error ("...%d...", N)
9657 was used to print both 32- and 64-bit integers N, which relied on
9659 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9660 * lisp.h (error, verror): Mark as printf-like functions.
9661 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9662 Report overflow in size calculations when allocating printf buffer.
9663 Do not truncate output string at its first null byte.
9664 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9665 Truncate the output at a character boundary, since vsnprintf does not
9667 * charset.c (check_iso_charset_parameter): Convert internal
9668 character to string before calling 'error', since %c now has the
9670 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9671 overflow when computing char to be passed to 'error'. Do not
9672 pass Lisp_Object to 'error'; pass the integer instead.
9673 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9674 formatted with plain %d.
9676 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9678 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9680 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9682 * xterm.c (x_catch_errors): Remove duplicate declaration.
9684 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9686 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9688 2011-04-10 Jim Meyering <meyering@redhat.com>
9690 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9691 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9692 return ssize_t not "int", and use size_t as the buffer length.
9693 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9694 * gnutls.h: Update declarations.
9695 * process.c (read_process_output): Use ssize_t, to match.
9696 (send_process): Likewise.
9698 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9700 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9702 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9704 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9705 Use unsigned char, to match FcChar8 type definition.
9707 * xterm.c (handle_one_xevent):
9708 * xmenu.c (create_and_show_popup_menu):
9709 * xselect.c (x_decline_selection_request)
9710 (x_reply_selection_request): Avoid type-punned deref of X events.
9712 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9714 Fix some uses of `int' instead of EMACS_INT.
9715 * search.c (string_match_1, fast_string_match)
9716 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9717 (scan_buffer, find_next_newline_no_quit)
9718 (find_before_next_newline, search_command, Freplace_match)
9719 (Fmatch_data): Make some `int' variables be EMACS_INT.
9721 * xdisp.c (display_count_lines): 3rd argument and return value now
9722 EMACS_INT. All callers changed.
9723 (pint2hrstr): Last argument is now EMACS_INT.
9725 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9726 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9727 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9728 (decode_coding_utf_16, decode_coding_emacs_mule)
9729 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9730 (decode_coding_ccl, decode_coding_charset)
9731 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9732 (decode_coding_iso_2022, decode_coding_emacs_mule)
9733 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9734 <char_offset, last_offset>: Declare EMACS_INT.
9735 (encode_coding_utf_8, encode_coding_utf_16)
9736 (encode_coding_emacs_mule, encode_invocation_designation)
9737 (encode_designation_at_bol, encode_coding_iso_2022)
9738 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9739 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9741 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9742 (encode_invocation_designation): Last argument P_NCHARS is now
9744 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9745 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9747 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9750 * ccl.c (Fccl_execute_on_string): Declare some variables
9753 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9755 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9757 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9759 * process.c (Fformat_network_address): Doc fix.
9761 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9763 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9765 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9767 * keyboard.c (read_char): Call Lisp function help-form-show,
9768 instead of using internal_with_output_to_temp_buffer.
9769 (Qhelp_form_show): New var.
9770 (syms_of_keyboard): Use DEFSYM macro.
9772 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9774 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9776 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9778 * process.c (Flist_processes): Remove to Lisp.
9779 (list_processes_1): Delete.
9781 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9783 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9785 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9787 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9789 Fix more problems found by GCC 4.6.0's static checks.
9791 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9793 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9795 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9797 * xdisp.c (vmessage): Mark as a printf-like function.
9799 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9801 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9803 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9804 printf-like functions.
9805 (tiff_load): Add casts to remove these marks before passing them
9806 to system-supplied API.
9808 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9810 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9811 This avoids several warnings with gcc -Wstrict-overflow.
9812 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9813 directly, rather than having caller test rule sign. This avoids
9814 some unnecessary tests.
9815 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9816 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9817 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9819 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9820 (xfont_open): Avoid unnecessary tests.
9822 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9824 * composite.h, composite.c (composition_gstring_put_cache):
9825 Use EMACS_INT, not int, for length.
9827 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9828 breaking out part of COMPOSITION_DECODE_RULE.
9829 (COMPOSITION_DECODE_RULE): Use it.
9830 * composite.c (get_composition_id): Remove unused local vars,
9831 by using the new macro.
9833 * textprop.c (set_text_properties_1): Change while to do-while,
9834 since the condition is always true at first.
9836 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9837 (interval_deletion_adjustment): Return unsigned value.
9840 * process.c (list_processes_1, create_pty, read_process_output):
9841 (exec_sentinel): Remove vars that were set but not used.
9842 (create_pty): Remove unnecessary "volatile"s.
9843 (Fnetwork_interface_info): Avoid possibility of int overflow.
9844 (read_process_output): Do adaptive read buffering even if carryover.
9845 (read_process_output): Simplify nbytes computation if buffered.
9847 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9849 * syntax.c (scan_words): Remove var that was set but not used.
9850 (update_syntax_table): Use unsigned instead of int.
9852 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9853 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9854 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9856 * print.c (print_error_message): Avoid int overflow.
9858 * font.c (font_list_entities): Redo for clarity,
9859 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9861 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9862 (font_score): Avoid potential overflow in diff calculation.
9864 * fns.c (substring_both): Remove var that is set but not used.
9865 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9867 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9869 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9870 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9871 can always succeed if overflow has undefined behavior.
9873 * search.c (boyer_moore, wordify): Remove vars set but not used.
9874 (wordify): Omit three unnecessary tests.
9876 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9877 All callers changed. This avoids the need for an unused var.
9879 * casefiddle.c (casify_region): Remove var that is set but not used.
9881 * dired.c (file_name_completion): Remove var that is set but not used.
9883 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9885 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9886 (Finsert_file_contents): Remove unnecessary code checking fd.
9888 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9889 Check for integer overflow on size calculations.
9891 * buffer.c (Fprevious_overlay_change): Remove var that is set
9894 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9895 Remove vars that are set but not used.
9896 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
9897 (timer_check_2): Mark vars as initialized.
9899 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9901 * image.c (lookup_image): Remove var that is set but not used.
9902 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9904 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9905 that are set but not used.
9907 * xfns.c (make_invisible_cursor): Don't return garbage
9908 if XCreateBitmapFromData fails (Bug#8410).
9910 * xselect.c (x_get_local_selection, x_handle_property_notify):
9911 Remove vars that are set but not used.
9913 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9914 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9916 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9917 Remove var that is set but not used.
9918 (scroll_bar_windows_size): Now size_t, not int.
9919 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9922 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9923 (map_tty_color) [!defined MSDOS]: Likewise.
9925 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9927 * coding.c: Remove vars that are set but not used.
9928 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9929 All callers changed.
9930 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9931 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9932 (decode_coding_charset): Remove vars that are set but not used.
9934 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9935 that is set but not used.
9937 * print.c (print_object): Remove var that is set but not used.
9939 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9940 The gnulib version avoids calling malloc in the usual case,
9941 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9942 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9943 * filelock.c (current_lock_owner): Likewise.
9944 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9945 * sysdep.c: Include allocator.h, careadlinkat.h.
9946 (emacs_no_realloc_allocator): New static constant.
9947 (emacs_readlink): New function.
9948 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9949 ../lib/careadlinkat.h.
9951 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9953 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9954 first non-nil return value).
9956 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9958 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9959 if not defined (Bug#8403).
9961 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9963 * xdisp.c (display_count_lines): Remove parameter `start',
9964 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9965 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9966 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9967 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9968 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9969 and thereabouts. All callers changed.
9970 (get_per_char_metric): Remove parameter `f', unused since
9971 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9973 2011-04-02 Jim Meyering <meyering@redhat.com>
9975 do not dereference NULL upon failed strdup
9976 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9977 (ns_get_family): Likewise.
9979 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9981 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9983 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9985 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9988 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9990 Add lexical binding.
9992 * window.c (Ftemp_output_buffer_show): New fun.
9993 (Fsave_window_excursion):
9994 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9996 * lread.c (lisp_file_lexically_bound_p): New function.
9997 (Fload): Bind Qlexical_binding.
9998 (readevalloop): Remove `evalfun' arg.
9999 Bind Qinternal_interpreter_environment.
10000 (Feval_buffer): Bind Qlexical_binding.
10001 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10003 (syms_of_lread): Declare `lexical-binding'.
10005 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10007 * keyboard.c (eval_dyn): New fun.
10008 (menu_item_eval_property): Use it.
10010 * image.c (parse_image_spec): Use Ffunctionp.
10012 * fns.c (concat, mapcar1): Accept byte-code-functions.
10014 * eval.c (Fsetq): Handle lexical vars.
10015 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10016 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10017 (FletX, Flet): Obey lexical binding.
10018 (Fcommandp): Handle closures.
10019 (Feval): New `lexical' arg.
10020 (eval_sub): New function extracted from Feval. Use it almost
10021 everywhere where Feval was used. Look up vars in lexical env.
10023 (Ffunctionp): Move from subr.el.
10024 (Ffuncall): Handle closures.
10025 (apply_lambda): Remove `eval_flags'.
10026 (funcall_lambda): Handle closures and new byte-code-functions.
10027 (Fspecial_variable_p): New function.
10028 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10029 but without exporting it to Lisp.
10031 * doc.c (Fdocumentation, store_function_docstring):
10032 * data.c (Finteractive_form): Handle closures.
10034 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10037 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10039 (exec_byte_code): New function extracted from Fbyte_code to handle new
10040 calling convention for byte-code-functions. Add new byte-codes.
10042 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10044 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10046 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10048 * xdisp.c (redisplay_internal): Fix prototype.
10050 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10052 * xdisp.c (SCROLL_LIMIT): New macro.
10053 (try_scrolling): Use it when setting scroll_limit.
10054 Limit scrolling to 100 screen lines.
10055 (redisplay_window): Even when falling back on "recentering",
10056 position point in the window according to scroll-conservatively,
10057 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10059 (try_scrolling): When point is above the window, allow searching
10060 as far as scroll_max, or one screenful, to compute vertical
10061 distance from PT to the scroll margin position. This prevents
10062 try_scrolling from unnecessarily failing when
10063 scroll-conservatively is set to a value slightly larger than the
10064 window height. Clean up the case of PT below the margin at bottom
10065 of window: scroll_max can no longer be INT_MAX. When aggressive
10066 scrolling is in use, don't let point enter the opposite scroll
10067 margin as result of the scroll.
10068 (syms_of_xdisp) <scroll-conservatively>: Document the
10069 threshold of 100 lines for never-recentering scrolling.
10071 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10073 * dispextern.h (move_it_by_lines):
10074 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10075 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10076 (message_log_check_duplicate): Remove parameters `prev_bol' and
10077 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10078 (redisplay_internal): Remove parameter `preserve_echo_area',
10079 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10081 * indent.c (Fvertical_motion):
10082 * window.c (window_scroll_pixel_based, Frecenter):
10083 Don't pass `need_y_p' to `move_it_by_lines'.
10085 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10087 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10088 steal a few bits to be more compact.
10089 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10090 Remove unneeded casts.
10092 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10094 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10096 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10097 binding" message (bug#7967).
10099 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10101 Fix more problems found by GCC 4.6.0's static checks.
10103 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10104 Remove unused local var.
10106 * editfns.c (Fmessage_box): Remove unused local var.
10108 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10109 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10110 Omit unused local vars.
10111 * window.c (shrink_windows): Omit unused local var.
10112 * menu.c (digest_single_submenu): Omit unused local var.
10113 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10114 Omit unused local var.
10116 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10117 Don't assume string length fits in int.
10118 (keyremap_step, read_key_sequence): Use size_t for sizes.
10119 (read_key_sequence): Don't check last_real_key_start redundantly.
10121 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10122 instead of alloca (Bug#8344).
10124 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10125 (Fbacktrace_frame): Don't assume nframes fits in int.
10127 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10129 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10132 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10134 * cm.c (calccost): Turn while-do into do-while, for clarity.
10136 * keyboard.c (syms_of_keyboard): Use the same style as later
10137 in this function when indexing through an array. This also
10138 works around GCC bug 48267.
10140 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10142 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10144 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10145 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10147 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10148 This avoids undefined behavior on integer overflow, and is a bit
10149 more convenient anyway since it is compared to a size_t variable.
10151 Variadic C functions now count arguments with size_t, not int.
10152 This avoids an unnecessary limitation on 64-bit machines, which
10153 caused (substring ...) to crash on large vectors (Bug#8344).
10154 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10155 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10156 All variadic functions and their callers changed accordingly.
10157 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10158 * data.c (arith_driver, float_arith_driver): Likewise.
10159 * editfns.c (general_insert_function): Likewise.
10160 * eval.c (struct backtrace.nargs, interactive_p)
10161 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10162 (funcall_lambda, mark_backtrace): Likewise.
10163 * fns.c (concat): Likewise.
10164 * frame.c (x_set_frame_parameters): Likewise.
10165 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10166 0 if not found, not -1. All callers changed.
10168 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10169 (stack_copy_size): Now size_t, not int.
10170 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10172 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10174 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10175 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10176 All callers changed.
10178 * lisp.h (multibyte_char_to_unibyte):
10179 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10180 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10181 * character.h (CHAR_TO_BYTE8):
10182 * cmds.c (internal_self_insert):
10183 * editfns.c (general_insert_function):
10184 * keymap.c (push_key_description):
10185 * search.c (Freplace_match):
10186 * xdisp.c (message_dolog, set_message_1): All callers changed.
10188 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10190 * keyboard.c (safe_run_hook_funcall): New function.
10191 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10192 don't set the hook to nil, but remove the offending function instead.
10193 (Qcommand_hook_internal): Remove, unused.
10194 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10195 Vcommand_hook_internal.
10197 * eval.c (enum run_hooks_condition): Remove.
10198 (funcall_nil, funcall_not): New functions.
10199 (run_hook_with_args): Call each function through a `funcall' argument.
10200 Remove `cond' argument, now redundant.
10201 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10202 (Frun_hook_with_args_until_failure): Adjust accordingly.
10203 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10205 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10207 * dispextern.h (string_buffer_position): Remove declaration.
10209 * print.c (strout): Remove parameter `multibyte', unused since
10210 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10212 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10213 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10214 All callers changed.
10216 * w32.c (_wsa_errlist): Use braces for struct initializers.
10218 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10219 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10220 All callers changed.
10221 (string_buffer_position): Likewise. Also, make static (it's never
10222 used outside xdisp.c).
10223 (cursor_row_p): Remove parameter `w', unused since
10224 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10225 (decode_mode_spec): Remove parameter `precision', introduced during
10226 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10227 All callers changed.
10229 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10231 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10233 2011-03-27 Anders Lindgren <andlind@gmail.com>
10235 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10236 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10237 (ns_update_auto_hide_menu_bar): New functions.
10238 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10239 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10240 ns_constrain_all_frames.
10241 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10242 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10244 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10246 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10248 2011-03-27 Glenn Morris <rgm@gnu.org>
10250 * syssignal.h: Replace RETSIGTYPE with void.
10251 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10252 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10253 Replace SIGTYPE with void everywhere.
10254 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10255 * s/template.h (SIGTYPE): Remove commented out definition.
10257 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10259 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10260 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10262 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10264 * w32.c (read_unc_volume): Use parameter `henum', instead of
10265 global variable `wget_enum_handle'.
10267 * keymap.c (describe_vector): Remove parameters `indices' and
10268 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10269 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10271 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10273 * keyboard.c (timer_check): Remove parameter `do_it_now',
10274 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10275 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10276 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10278 * keyboard.c (read_char):
10279 * w32menu.c (w32_menu_display_help):
10280 * xmenu.c (show_help_event, menu_help_callback):
10281 Adjust calls to `show_help_echo'.
10283 * gtkutil.c (xg_maybe_add_timer):
10284 * keyboard.c (readable_events):
10285 * process.c (wait_reading_process_output):
10286 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10288 * insdel.c (adjust_markers_gap_motion):
10289 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10290 (gap_left, gap_right): Don't call it.
10292 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10294 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10295 incurred during fontification.
10297 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10299 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10300 (DEFVAR_PER_BUFFER): Don't pass it.
10302 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10303 (scrolling_window): Don't pass it.
10305 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10307 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10309 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10311 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10312 of variables specific to SELinux and computation of `encoded_absname'.
10314 * image.c (XPutPixel): Remove unused variable `height'.
10316 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10318 * unexw32.c (get_section_info): Remove unused variable `section'.
10320 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10321 (system_process_attributes): Remove unused variable `sess'.
10322 (sys_read): Remove unused variable `err'.
10324 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10325 (w32_wnd_proc): Remove unused variable `isdead'.
10326 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10327 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10328 (x_create_tip_frame): Remove unused variable `tem'.
10330 * w32inevt.c (w32_console_read_socket):
10331 Remove unused variable `no_events'.
10333 * w32term.c (x_draw_composite_glyph_string_foreground):
10334 Remove unused variable `width'.
10336 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10338 * w32term.c (x_set_glyph_string_clipping):
10339 Don't pass uninitialized region to CombineRgn.
10341 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10343 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10344 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10345 (Fx_close_connection): Remove unused variable `i'.
10347 * w32font.c (w32font_draw): Return number of glyphs.
10348 (w32font_open_internal): Remove unused variable `i'.
10349 (w32font_driver): Add missing initializer.
10351 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10352 (fill_in_menu): Remove unused variable `items_added'.
10354 * w32term.c (last_mouse_press_frame): Remove static global variable.
10355 (w32_clip_to_row): Remove unused variable `f'.
10356 (x_delete_terminal): Remove unused variable `i'.
10358 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10359 (NOTHING): Remove unused static global variable.
10360 (uniscribe_check_otf): Remove unused variable `table'.
10361 (uniscribe_font_driver): Add missing initializers.
10363 2011-03-23 Julien Danjou <julien@danjou.info>
10365 * term.c (Fsuspend_tty, Fresume_tty):
10366 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10367 * window.c (temp_output_buffer_show):
10368 * insdel.c (signal_before_change):
10369 * frame.c (Fhandle_switch_frame):
10370 * fileio.c (Fdo_auto_save):
10371 * emacs.c (Fkill_emacs):
10372 * editfns.c (save_excursion_restore):
10373 * cmds.c (internal_self_insert):
10374 * callint.c (Fcall_interactively):
10375 * buffer.c (Fkill_all_local_variables):
10376 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10378 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10379 unconditionally since it does the check itself.
10381 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10383 Fix more problems found by GCC 4.5.2's static checks.
10385 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10386 the first time through the loop, since we know p0 < p1 then.
10387 This also avoids a gcc -Wstrict-overflow warning.
10389 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10390 leading to a memory leak, possible in functions like
10391 load_charset_map_from_file that can allocate an unbounded number
10392 of objects (Bug#8318).
10394 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10395 that could (at least in theory) be that large.
10397 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10398 This is less likely to overflow, and avoids undefined behavior if
10399 overflow does occur. All callers changed. Use strtoul to scan
10400 for the unsigned long integer.
10401 (pint2hrstr): Simplify and tune code slightly.
10402 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10404 * scroll.c (do_scrolling): Work around GCC bug 48228.
10405 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10407 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10408 This also avoids a warning with gcc -Wstrict-overflow.
10409 (validate_x_resource_name): Simplify count usage.
10410 This also avoids a warning with gcc -Wstrict-overflow.
10412 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10415 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10417 * process.c (Fmake_network_process): Use socklen_t, not int,
10418 where POSIX says socklen_t is required in portable programs.
10419 This fixes a porting bug on hosts like 64-bit HP-UX, where
10420 socklen_t is wider than int (Bug#8277).
10421 (Fmake_network_process, server_accept_connection):
10422 (wait_reading_process_output, read_process_output):
10425 * process.c: Rename or move locals to avoid shadowing.
10426 (list_processes_1, Fmake_network_process):
10427 (read_process_output_error_handler, exec_sentinel_error_handler):
10428 Rename or move locals.
10429 (Fmake_network_process): Define label "retry_connect" only if needed.
10430 (Fnetwork_interface_info): Fix pointer signedness.
10431 (process_send_signal): Add cast to avoid pointer signedness problem.
10432 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10433 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10435 Make tparam.h and terminfo.c consistent.
10436 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10437 Include tparam.h instead, since it declares them.
10438 * cm.h (PC): Remove extern decl; tparam.h now does this.
10439 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10440 * terminfo.c: Include tparam.h, to check interfaces.
10441 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10442 (tparam): Adjust signature to match interface in tparam.h;
10443 this removes some undefined behavior. Check that outstring and len
10444 are zero, which they always are with Emacs.
10445 * tparam.h (PC, BC, UP): New extern decls.
10447 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10448 (xftfont_open): Rename locals to avoid shadowing.
10450 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10451 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10452 (OTF_TAG_SYM): Omit macro if not needed.
10453 (ftfont_list): Remove unused local.
10454 (get_adstyle_property, ftfont_pattern_entity):
10455 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10456 Rename locals to avoid shadowing.
10458 * xfont.c (xfont_list_family): Mark var as initialized.
10460 * xml.c (make_dom): Now static.
10462 * composite.c (composition_compute_stop_pos): Rename local to
10464 (composition_reseat_it): Remove unused locals.
10465 (find_automatic_composition, composition_adjust_point): Likewise.
10466 (composition_update_it): Mark var as initialized.
10467 (find_automatic_composition): Mark vars as initialized,
10468 with a FIXME (Bug#8290).
10470 character.h: Rename locals to avoid shadowing.
10471 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10472 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10473 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10474 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10475 to avoid shadowing.
10477 * textprop.c (property_change_between_p): Remove; unused.
10479 * intervals.c (interval_start_pos): Now static.
10481 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10483 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10484 Rename locals to avoid shadowing.
10486 * sound.c (wav_play, au_play, Fplay_sound_internal):
10487 Fix pointer signedness.
10488 (alsa_choose_format): Remove unused local var.
10489 (wav_play): Initialize a variable to 0, to prevent undefined
10490 behavior (Bug#8278).
10492 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10494 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10496 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10497 clobbering (Bug#8298).
10498 * sysdep.c (sys_subshell): Likewise.
10499 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10501 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10502 This should get cleaned up, so that child_setup has the
10503 same signature on all platforms.
10505 * callproc.c (call_process_cleanup): Now static.
10506 (relocate_fd): Rename locals to avoid shadowing.
10508 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10510 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10511 not to be necessary, and produces flickering.
10513 2011-03-20 Glenn Morris <rgm@gnu.org>
10515 * config.in: Remove file.
10517 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10519 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10520 are now in src/globals.h.
10521 (syms_of_minibuf): Remove spurious & from previous change.
10523 2011-03-20 Leo Liu <sdl.web@gmail.com>
10525 * minibuf.c (completing-read-function): New variable.
10526 (completing-read-default): Rename from completing-read.
10527 (completing-read): Call completing-read-function.
10529 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10531 * xfaces.c (Fx_load_color_file):
10532 Read color file from absolute filename (bug#8250).
10534 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10536 * makefile.w32-in: Update dependencies.
10538 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10540 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10542 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10544 Fix more problems found by GCC 4.5.2's static checks.
10546 * process.c (make_serial_process_unwind, send_process_trap):
10547 (sigchld_handler): Now static.
10549 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10550 That way, the code declares only the vars that it needs.
10551 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10552 * s/cygwin.h (PTY_ITERATION): Likewise.
10553 * s/darwin.h (PTY_ITERATION): Likewise.
10554 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10556 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10557 * process.c (allocate_pty): Don't declare stb unless it's needed.
10559 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10560 (CONSTANTLIM): Remove; unused.
10561 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10562 Define only if needed.
10564 * unexelf.c (unexec): Name an expression,
10565 to avoid gcc -Wbad-function-cast warning.
10566 Use a different way to cause a compilation error if anyone uses
10567 n rather than nn, a way that does not involve shadowing.
10568 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10570 * deps.mk (unexalpha.o): Remove; unused.
10572 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10573 * unexec.h: New file.
10574 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10575 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10576 Depend on unexec.h.
10577 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10578 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10579 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10580 Change as necessary to match prototype in unexec.h.
10582 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10584 (back_comment, skip_chars): Mark vars as initialized.
10586 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10587 Rename locals to avoid shadowing.
10589 * lread.c (read1): Rewrite so as not to use empty "else".
10590 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10592 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10594 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10595 warning when compiling print.c.
10597 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10598 instead of using an uninitialized var.
10599 (font_sort_entities): Mark var as initialized.
10601 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10603 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10604 pointers to constants.
10605 (font_parse_fcname): Remove unused vars.
10606 (font_delete_unmatched): Now static.
10607 (font_get_spec): Remove; unused.
10608 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10609 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10610 Rename or move locals to avoid shadowing.
10612 * fns.c (require_nesting_list, require_unwind): Now static.
10613 (Ffillarray): Rename locals to avoid shadowing.
10615 * floatfns.c (domain_error2): Define only if needed.
10616 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10618 * alloc.c (mark_backtrace): Move decl from here ...
10619 * lisp.h: ... to here, so that it can be checked.
10621 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10622 (Fdefvar): Rewrite so as not to use empty "else".
10623 (lisp_indirect_variable): Name an expression,
10624 to avoid gcc -Wbad-function-cast warning.
10625 (Fdefvar): Rename locals to avoid shadowing.
10627 * callint.c (quotify_arg, quotify_args): Now static.
10628 (Fcall_interactively): Rename locals to avoid shadowing.
10629 Use const pointer when appropriate.
10631 * lisp.h (get_system_name, get_operating_system_release):
10632 Move decls here, to check interfaces.
10633 * process.c (get_operating_system_release): Move decl to lisp.h.
10634 * xrdb.c (get_system_name): Likewise.
10635 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10636 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10637 some of which prompt warnings from gcc -Wbad-function-cast.
10638 (Fformat_time_string, Fencode_time, Finsert_char):
10639 (Ftranslate_region_internal, Fformat):
10640 Rename or remove local vars to avoid shadowing.
10641 (Ftranslate_region_internal): Mark var as initialized.
10643 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10646 * lisp.h (eassert): Check that the argument compiles, even if
10647 ENABLE_CHECKING is not defined.
10649 * data.c (Findirect_variable): Name an expression, to avoid
10650 gcc -Wbad-function-cast warning.
10651 (default_value, arithcompare, arith_driver, arith_error): Now static.
10652 (store_symval_forwarding): Rename local to avoid shadowing.
10653 (Fmake_variable_buffer_local, Fmake_local_variable):
10654 Mark variables as initialized.
10655 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10657 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10658 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10659 Rename locals to avoid shadowing.
10660 (mark_stack): Move local variables into the #ifdef region where
10662 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10663 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10665 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10666 (GC_STRING_CHARS): Remove; not used.
10667 (Fmemory_limit): Cast sbrk's returned value to char *.
10669 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10670 avoids undefined behavior in theory.
10672 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10674 Use functions, not macros, for up- and down-casing (Bug#8254).
10675 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10676 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10677 to use the following functions instead of these macros.
10678 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10679 EMACS_INT, since callers assume the returned value fits in int.
10680 (upcase1): Likewise, for UPCASE_TABLE.
10681 (uppercasep, lowercasep, upcase): New static inline functions.
10682 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10683 the race-condition problem in the old DOWNCASE.
10685 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10686 Rename locals to avoid shadowing.
10687 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10688 (regex_compile, re_search_2, re_match_2_internal):
10689 Remove unused local vars.
10690 (FREE_VAR): Rewrite so as not to use empty "else",
10691 which gcc can warn about.
10692 (regex_compile, re_match_2_internal): Mark locals as initialized.
10693 (RETALLOC_IF): Define only if needed.
10694 (WORDCHAR_P): Likewise. This one is never needed, but is used
10695 only in a comment talking about a compiler bug, so put inside
10696 the #if 0 of that comment.
10697 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10698 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10701 * search.c (boyer_moore): Rename locals to avoid shadowing.
10702 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10703 (PREV_CHAR_BOUNDARY): Likewise.
10705 * search.c (simple_search): Remove unused var.
10707 * dired.c (compile_pattern): Move decl from here ...
10708 * lisp.h: ... to here, so that it can be checked.
10709 (struct re_registers): New forward decl.
10711 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10713 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10715 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10716 Rename locals to avoid shadowing.
10717 (Fvertical_motion): Mark locals as initialized.
10719 * casefiddle.c (casify_object, casify_region): Now static.
10720 (casify_region): Mark local as initialized.
10722 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10724 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10725 New macros, so that the caller can use some names other than
10726 gcpro1, gcpro2, etc.
10727 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10729 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10730 argument, for consistency with GCPRO2_VAR, etc: it is now the
10731 prefix of the variable, not the variable itself. All uses
10733 * dired.c (directory_files_internal, file_name_completion):
10734 Rename locals to avoid shadowing.
10736 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10737 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10738 dired.c's scmp function, had undefined behavior.
10739 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10740 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10741 * buffer.h: ... to here, because these macros use current_buffer,
10742 and the new implementation with inline functions needs to have
10743 current_buffer in scope now, rather than later when the macros
10745 (downcase, upcase1): New static inline functions.
10746 (DOWNCASE, UPCASE1): Reimplement using these functions.
10747 This avoids undefined behavior in expressions like
10748 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10749 from race conditions in accessing the global variables
10750 case_temp1 and case_temp2.
10751 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10752 * lisp.h (case_temp1, case_temp2): Remove their decls.
10753 * character.h (ASCII_CHAR_P): Move from here ...
10754 * lisp.h: ... to here, so that the inline functions mentioned
10755 above can use them.
10757 * dired.c (directory_files_internal_unwind): Now static.
10759 * fileio.c (file_name_as_directory, directory_file_name):
10760 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10762 (file_name_as_directory): Use const pointers when appropriate.
10763 (Fexpand_file_name): Likewise. In particular, newdir might
10764 point at constant storage, so make it a const pointer.
10765 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10766 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10768 (Fset_file_times, Finsert_file_contents, auto_save_error):
10769 Rename locals to avoid shadowing.
10771 * minibuf.c (choose_minibuf_frame_1): Now static.
10772 (Ftry_completion, Fall_completions): Rename or remove locals
10773 to avoid shadowing.
10775 * marker.c (bytepos_to_charpos): Remove; unused.
10777 * lisp.h (verify_bytepos, count_markers): New decls,
10778 so that gcc does not warn that these functions aren't declared.
10780 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10781 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10782 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10783 (copy_text): Remove unused local var.
10785 * filelock.c (within_one_second): Now static.
10786 (lock_file_1): Rename local to avoid shadowing.
10788 * buffer.c (fix_overlays_before): Mark locals as initialized.
10789 (fix_start_end_in_overlays): Likewise. This function should be
10790 simplified by using pointers-to-pointers, but that's a different
10792 (switch_to_buffer_1): Now static.
10793 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10794 (report_overlay_modification): Rename locals to avoid shadowing.
10796 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10797 Fix pointer signedness issue.
10798 (sys_subshell): Mark local as volatile if checking for lint,
10799 to suppress a gcc -Wclobbered warning that does not seem to be right.
10800 (MAXPATHLEN): Define only if needed.
10802 * process.c (serial_open, serial_configure): Move decls from here ...
10803 * systty.h: ... to here, so that they can be checked.
10805 * fns.c (get_random, seed_random): Move extern decls from here ...
10806 * lisp.h: ... to here, so that they can be checked.
10808 * sysdep.c (reset_io): Now static.
10809 (wait_for_termination_signal): Remove; unused.
10811 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10812 (copy_keymap_item, append_key, push_text_char_description):
10814 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10815 (DENSE_TABLE_SIZE): Remove; unused.
10816 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10817 (describe_map_tree):
10818 Rename locals to avoid shadowing.
10820 * keyboard.c: Declare functions static if they are not used elsewhere.
10821 (echo_char, echo_dash, cmd_error, top_level_2):
10822 (poll_for_input, handle_async_input): Now static.
10823 (read_char, kbd_buffer_get_event, make_lispy_position):
10824 (make_lispy_event, make_lispy_movement, apply_modifiers):
10825 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10826 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10827 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10828 (read_key_sequence, read_char): Mark locals as initialized.
10829 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10831 * keyboard.h (make_ctrl_char): New decl.
10832 (mark_kboards): Move decl here ...
10833 * alloc.c (mark_kboards): ... from here.
10835 * lisp.h (force_auto_save_soon): New decl.
10837 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10838 (DEFINE_DUMMY_FUNCTION): New macro.
10839 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10841 (main): Add casts to avoid warnings
10842 if GCC considers string literals to be constants.
10844 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10846 * dbusbind.c: Pointer signedness fixes.
10847 (xd_signature, xd_append_arg, xd_initialize):
10848 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10849 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10850 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10851 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10853 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10854 if GCC considers string literals to be constants.
10855 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10857 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10859 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10860 (print_preprocess, print_object): New macro to fix last change.
10862 * print.c (print_preprocess): Don't forget font objects.
10864 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10866 * emacs.c (USAGE3): Doc fixes.
10868 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10870 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10873 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10875 * lisp.h (VWindow_system, Qfile_name_history):
10876 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10877 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10878 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10880 * w32select.c: Don't #include "keyboard.h".
10881 (run_protected): Add extern declaration for waiting_for_input.
10883 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10884 * w32console.c (detect_input_pending, read_input_pending)
10885 (encode_terminal_code):
10886 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10887 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10888 (w32_system_caret_y, Qfile_name_history):
10889 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10890 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10891 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10892 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10893 * w32proc.c (Qlocal, report_file_error):
10894 * w32term.c (Vwindow_system, updating_frame):
10895 * w32uniscribe.c (initialized, uniscribe_font_driver):
10896 Remove unneeded extern declarations.
10898 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
10900 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10902 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10904 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10905 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10906 These macros can no longer be used for assignment.
10908 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10909 Assign struct members directly, instead of using BUF_BEGV etc.
10910 (record_buffer_markers, fetch_buffer_markers): New functions for
10911 recording and fetching special buffer markers.
10912 (set_buffer_internal_1, set_buffer_temp): Use them.
10914 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10916 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10918 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10919 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10921 * xdisp.c (hscroll_window_tree):
10922 (reconsider_clip_changes): Use PT instead of BUF_PT.
10924 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10926 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10927 $(EMACS_ROOT)/lib/intprops.h.
10929 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10931 Fix more problems found by GCC 4.5.2's static checks.
10933 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10934 to unsigned char * to avoid compiler diagnostic.
10935 (xg_free_frame_widgets): Make it clear that a local variable is
10936 needed only if USE_GTK_TOOLTIP.
10937 (gdk_window_get_screen): Make it clear that this macro is needed
10938 only if USE_GTK_TOOLTIP.
10939 (int_gtk_range_get_value): New function, which avoids a diagnostic
10940 from gcc -Wbad-function-cast.
10941 (xg_set_toolkit_scroll_bar_thumb): Use it.
10942 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10943 diagnostic from gcc -Wbad-function-cast.
10944 (get_utf8_string, xg_get_file_with_chooser):
10945 Rename locals to avoid shadowing.
10946 (create_dialog): Move locals to avoid shadowing.
10948 * xgselect.c (xg_select): Remove unused var.
10950 * image.c (four_corners_best): Mark locals as initialized.
10951 (gif_load): Initialize transparent_p to zero (Bug#8238).
10952 Mark another local as initialized.
10953 (my_png_error, my_error_exit): Mark with NO_RETURN.
10955 * image.c (clear_image_cache): Now static.
10956 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10957 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10958 (x_edge_detection): Remove unnecessary cast that
10959 gcc -Wbad-function-cast diagnoses.
10960 (gif_load): Fix pointer signedness.
10961 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10962 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10964 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10966 Improve quality of tests for time stamp overflow.
10967 For example, without this patch (encode-time 0 0 0 1 1
10968 1152921504606846976) returns the obviously-bogus value (-948597
10969 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10970 reports time overflow. See
10971 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10972 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10973 * editfns.c: Include limits.h and intprops.h.
10974 (TIME_T_MIN, TIME_T_MAX): New macros.
10975 (time_overflow): Move earlier, to before first use.
10976 (hi_time, lo_time): New functions, for an accurate test for
10977 out-of-range times.
10978 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10979 (Fget_internal_run_time): Don't assume time_t fits in int.
10980 (make_time): Use list2 instead of Fcons twice.
10981 (Fdecode_time): More accurate test for out-of-range times.
10982 (check_tm_member): New function.
10983 (Fencode_time): Use it, to test for out-of-range times.
10984 (lisp_time_argument): Don't rely on undefined left-shift and
10985 right-shift behavior when checking for time stamp overflow.
10987 * editfns.c (time_overflow): New function, refactoring common code.
10988 (Fformat_time_string, Fdecode_time, Fencode_time):
10989 (Fcurrent_time_string): Use it.
10991 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10992 * dired.c (make_time): Move to ...
10993 * editfns.c (make_time): ... here.
10994 * systime.h: Note the move.
10996 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10998 * fringe.c (update_window_fringes): Remove unused variables.
11000 * unexmacosx.c (copy_data_segment): Also copy __got section.
11003 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11005 * termcap.c [MSDOS]: Include "msdos.h".
11006 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11007 Constify `char *' arguments and their references according to
11008 prototypes in tparam.h.
11010 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11012 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11013 Adapt all references accordingly.
11015 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11017 2011-03-11 Tom Tromey <tromey@redhat.com>
11019 * buffer.c (syms_of_buffer): Remove obsolete comment.
11021 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11023 * termhooks.h (encode_terminal_code): Declare prototype.
11025 * msdos.c (encode_terminal_code): Don't declare prototype.
11027 * term.c (encode_terminal_code): Now external again, used by
11028 w32console.c and msdos.c.
11030 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11031 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11033 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11035 Fix some minor problems found by GCC 4.5.2's static checks.
11037 * fringe.c (update_window_fringes): Mark locals as initialized
11039 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11041 * alloc.c (mark_fringe_data): Move decl from here ...
11042 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11043 to check its interface.
11044 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11046 * fontset.c (free_realized_fontset): Now static.
11047 (Fset_fontset_font): Rename local to avoid shadowing.
11048 (fontset_font): Mark local as initialized.
11049 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11051 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11053 * xselect.c (x_disown_buffer_selections): Remove; not used.
11054 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11055 (x_own_selection, Fx_disown_selection_internal): Rename locals
11056 to avoid shadowing.
11057 (x_handle_dnd_message): Remove local to avoid shadowing.
11059 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11060 so that the caller can use some name other than gcpro1.
11061 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11062 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11063 (Fx_backspace_delete_keys_p):
11064 Use them to avoid shadowing, and rename vars to avoid shadowing.
11065 (x_decode_color, x_set_name, x_window): Now static.
11066 (Fx_create_frame): Add braces to silence GCC warning.
11067 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11068 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11069 Remove unused locals.
11070 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11071 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11072 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11075 * xterm.h (x_mouse_leave): New decl.
11077 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11078 Remove unused functions.
11079 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11080 (x_calc_absolute_position): Now static.
11081 (XTread_socket): Don't define label "out" unless it's used.
11082 Don't declare local "event" unless it's used.
11083 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11084 unless they are used.
11085 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11086 (x_fatal_error_signal): Remove; not used.
11087 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11088 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11089 (x_error_catcher, x_connection_closed, x_error_handler):
11090 (x_error_quitter, xembed_send_message, x_iconify_frame):
11091 (my_log_handler): Rename locals to avoid shadowing.
11092 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11093 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11095 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11096 Rename or move locals to avoid shadowing.
11097 (tty_defined_color, merge_face_heights): Now static.
11098 (free_realized_faces_for_fontset): Remove; not used.
11099 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11100 does not deduce is never used uninitialized.
11101 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11102 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11104 * terminal.c (store_terminal_param): Now static.
11106 * xmenu.c (menu_highlight_callback): Now static.
11107 (set_frame_menubar): Remove unused local.
11108 (xmenu_show): Rename parameter to avoid shadowing.
11109 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11110 since they might point to immutable storage.
11111 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11112 since it's unused otherwise.
11114 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11115 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11116 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11117 avoids a gcc -Wuninitialized diagnostic.
11118 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11119 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11120 does not deduce are never used uninitialized.
11122 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11124 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11125 * window.c (window_loop, size_window):
11126 (run_window_configuration_change_hook, enlarge_window): Likewise.
11128 * window.c (display_buffer): Now static.
11129 (size_window): Mark variables that gcc -Wuninitialized
11130 does not deduce are never used uninitialized.
11131 * window.h (check_all_windows): New decl, to forestall
11132 gcc -Wmissing-prototypes diagnostic.
11133 * dispextern.h (bidi_dump_cached_states): Likewise.
11135 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11137 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11138 Include <limits.h>.
11139 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11140 and to avoid gcc -Wuninitialized warning.
11141 (load_charset_map): Mark variables that gcc -Wuninitialized
11142 does not deduce are never used uninitialized.
11143 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11145 * coding.c (coding_set_source, coding_set_destination):
11146 Use "else { /* comment */ }" rather than "else /* comment */;"
11147 for clarity, and to avoid gcc -Wempty-body warning.
11148 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11149 a block, when the outer 'i' will do.
11150 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11151 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11152 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11153 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11154 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11155 Rename locals to avoid shadowing.
11156 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11157 * coding.c (emacs_mule_char, encode_invocation_designation):
11158 Now static, since they're not used elsewhere.
11159 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11160 (decode_coding_object, encode_coding_object, detect_coding_system):
11161 (decode_coding_emacs_mule): Mark variables that gcc
11162 -Wuninitialized does not deduce are never used uninitialized.
11163 (detect_coding_iso_2022): Initialize a local variable that might
11164 be used uninitialized. Leave a FIXME because it's not clear that
11165 this initialization is needed. (Bug#8211)
11166 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11167 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11168 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11169 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11170 Remove unused macros.
11172 * category.c (hash_get_category_set): Remove unused local var.
11173 (copy_category_table): Now static, since it's not used elsewhere.
11174 * character.c (string_count_byte8): Likewise.
11176 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11177 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11179 * chartab.c (copy_sub_char_table): Now static, since it's not used
11181 (sub_char_table_ref_and_range, char_table_ref_and_range):
11182 Rename locals to avoid shadowing.
11183 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11185 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11186 (BIDI_BOB): Remove unused macro.
11188 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11189 deduce are never used uninitialized.
11190 * term.c (encode_terminal_code): Likewise.
11192 * term.c (encode_terminal_code): Now static. Remove unused local.
11194 * tparam.h: New file.
11195 * term.c, tparam.h: Include it.
11196 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11197 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11198 Move these decls to tparam.h, and make them agree with what
11199 is actually in tparam.c. The previous trick of using incompatible
11200 decls in different modules does not conform to the C standard.
11201 All callers of tparam changed to use tparam's actual API.
11202 * tparam.c (tparam1, tparam, tgoto):
11203 Use const pointers where appropriate.
11205 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11206 * cm.h (struct cm): Likewise.
11207 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11208 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11209 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11210 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11211 (turn_on_face, init_tty): Likewise.
11212 * termchar.h (struct tty_display_info): Likewise.
11214 * term.c (term_mouse_position): Rename local to avoid shadowing.
11216 * alloc.c (mark_ttys): Move decl from here ...
11217 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11219 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11221 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11223 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11225 * search.c (compile_pattern_1): Remove argument regp, unused since
11226 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11227 (compile_pattern): Don't pass it.
11229 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11231 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11232 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11234 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11236 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11238 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11239 gdk_window_get_screen, gdk_window_get_geometry,
11240 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11241 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11242 (xg_get_pixbuf_from_pixmap): New function.
11243 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11244 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11245 Call xg_get_pixbuf_from_pixmap instead of
11246 gdk_pixbuf_get_from_drawable.
11247 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11248 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11249 (xg_check_special_colors): Use GtkStyleContext and its functions
11251 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11252 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11253 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11254 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11255 Call gtk_widget_get_preferred_size.
11256 (xg_frame_resized): gdk_window_get_geometry only takes 5
11258 (xg_win_to_widget, xg_event_is_for_menubar):
11259 Call gdk_x11_window_lookup_for_display.
11260 (xg_set_widget_bg): New function.
11261 (delete_cb): New function.
11262 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11263 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11264 (xg_set_background_color): Call xg_set_widget_bg.
11265 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11266 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11267 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11268 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11270 (update_frame_tool_bar): Call gtk_widget_hide.
11271 (xg_initialize): Use GDK_KEY_g.
11273 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11275 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11277 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11278 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11279 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11281 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11283 * w32xfns.c (select_palette): Check success of RealizePalette against
11284 GDI_ERROR, not zero.
11286 See ChangeLog.11 for earlier changes.
11288 ;; Local Variables:
11292 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11294 This file is part of GNU Emacs.
11296 GNU Emacs is free software: you can redistribute it and/or modify
11297 it under the terms of the GNU General Public License as published by
11298 the Free Software Foundation, either version 3 of the License, or
11299 (at your option) any later version.
11301 GNU Emacs is distributed in the hope that it will be useful,
11302 but WITHOUT ANY WARRANTY; without even the implied warranty of
11303 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11304 GNU General Public License for more details.
11306 You should have received a copy of the GNU General Public License
11307 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.