1 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3 * sysdep.c [__FreeBSD__]: Minor cleanups.
4 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5 Use Emacs indenting style more consistently. Avoid some casts.
6 Use 'double' consistently rather than mixing 'float' and 'double'.
8 2012-04-21 Eduard Wiebe <usenet@pusto.de>
10 * sysdep.c (list_system_processes, system_process_attributes): Add
11 implementation for FreeBSD (Bug#5243).
13 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
15 * lisp.mk (lisp): Update.
17 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
19 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
20 It is never used otherwise.
22 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
24 * print.c (print_preprocess): Only check print_depth if print-circle
26 (print_object): Check for cycles even when print-circle is nil and
27 print-gensym is t, but only check print_depth if print-circle is nil.
29 2012-04-20 Chong Yidong <cyd@gnu.org>
31 * process.c (wait_reading_process_output): If EIO occurs on a pty,
32 set the status to "failed" and ensure that sentinel is run.
34 2012-04-20 Glenn Morris <rgm@gnu.org>
36 * process.c (Fset_process_inherit_coding_system_flag)
37 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
38 (Fmake_network_process, Fmake_serial_process): Doc fix.
40 2012-04-20 Eli Zaretskii <eliz@gnu.org>
42 * xdisp.c (string_buffer_position_lim): Limit starting position to
44 (set_cursor_from_row): If called for a mode-line or header-line
45 row, return zero immediately.
46 (try_cursor_movement): If inside continuation line, don't back up
47 farther than the first row after the header line, if any.
48 Don't consider the header-line row as "partially visible", even if
49 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
51 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
53 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
56 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
57 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
59 configure: new option --enable-gcc-warnings (Bug#11207)
60 * Makefile.in (C_WARNINGS_SWITCH): Remove.
61 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
62 (ALL_CFLAGS): Use new macros rather than old.
63 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
64 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
65 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
66 -Wunused-result, -Wunused-variable. This should go away once
67 the Emacs and Gnulib regex code is merged.
68 (xmalloc, xrealloc): Now static.
70 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
72 * dired.c (Fsystem_groups): Remove unused local.
74 2012-04-17 Glenn Morris <rgm@gnu.org>
76 * dired.c (Fsystem_users): Doc fix.
78 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
80 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
81 (syms_of_dired): Add them.
83 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
85 Fix minor alloc.c problems found by static checking.
86 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
87 New extern decls, to avoid calling undeclared functions.
88 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
89 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
90 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
91 (NEED_MEM_INSERT): New macro.
92 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
93 Remove one incorrect comment and fix another.
95 Fix minor ralloc.c problems found by static checking.
96 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
97 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
98 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
99 (r_alloc_sbrk): Now static.
101 Improve ralloc.c interface checking.
102 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
103 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
104 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
105 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
106 [REL_ALLOC]: ... to here, to check interface.
107 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
108 Remove decls. This fixes an "It stinks!".
110 * alloc.c (which_symbols): Fix alignment issue / type clash.
112 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
114 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
115 (struct Lisp_Misc_Any): Likewise.
116 (struct Lisp_Free): Likewise.
117 * alloc.c (union aligned_Lisp_Symbol): Define.
118 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
119 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
120 (union aligned_Lisp_Misc): Define.
121 (MARKER_BLOCK_SIZE, struct marker_block): Use union
122 aligned_Lisp_Misc instead of union Lisp_Misc.
123 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
125 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
127 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
128 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
129 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
130 * s/netbsd.h, s/sol2-6.h:
131 Remove definition of GC_MARK_STACK, since the default now works.
132 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
133 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
134 no longer the default.
135 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
137 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
139 * lread.c (lisp_file_lexically_bound_p):
140 Fix hang at ";-*-\n" (bug#11238).
142 2012-04-14 Eli Zaretskii <eliz@gnu.org>
144 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
145 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
147 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
149 * nsterm.m (constrainFrameRect): Always constrain when there is only
150 one screen (Bug#10962).
152 2012-04-13 Ken Brown <kbrown@cornell.edu>
154 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
156 2012-04-13 Reuben Thomas <rrt@sc3d.org>
158 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
160 2012-04-11 Daniel Colascione <dancol@dancol.org>
162 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
163 against is gone. It's better to use vfork now so that when Cygwin
164 gains a new, working vfork, we use it automatically (bug#10398).
166 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
168 * window.c (save_window_save): Obey window-point-insertion-type.
170 2012-04-11 Glenn Morris <rgm@gnu.org>
172 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
174 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
176 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
178 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
180 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
181 (force_quit_count): New var.
182 (handle_interrupt): Use it.
184 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
186 * w32.c (w32_delayed_load): Record the full path of the library
187 being loaded (bug#10424).
189 2012-04-09 Glenn Morris <rgm@gnu.org>
191 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
192 not just in the obarray, before snarfing them. (Bug#11036)
194 * Makefile.in ($(leimdir)/leim-list.el):
195 Pass EMACS rather than BUILT_EMACS.
197 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
199 * process.c (make_process):
200 * process.h: Add integer `gnutls_handshakes_tried' member to
203 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
204 Add convenience `GNUTLS_LOG2i' macro.
206 * gnutls.c (gnutls_log_function2i): Convenience log function.
207 (emacs_gnutls_read): Use new log functions,
208 `gnutls_handshakes_tried' process member, and
209 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
210 attempts per process (connection).
212 2012-04-09 Chong Yidong <cyd@gnu.org>
214 * eval.c (Fuser_variable_p, user_variable_p_eh)
215 (lisp_indirect_variable): Functions deleted.
216 (Fdefvar): Caller changed.
218 * callint.c (Finteractive, Fcall_interactively):
219 * minibuf.c (Fread_variable): Callers changed.
221 2012-04-09 Eli Zaretskii <eliz@gnu.org>
223 * xdisp.c (set_cursor_from_row): If the display string appears in
224 the buffer at position that is closer to point than the position
225 after the display string, display the cursor on the first glyph of
226 the display string. Fixes cursor display when a 'display' text
227 property immediately follows invisible text. (Bug#11094)
229 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
231 composite.c: use 'double' consistently
232 * composite.c (get_composition_id): Use 'double' consistently
233 instead of converting 'float' to 'double' and vice versa; this is
234 easier to understand and avoids a GCC warning.
236 2012-04-09 Glenn Morris <rgm@gnu.org>
238 * Makefile.in: Generate leim-list with bootstrap-emacs, in
239 preparation for dumping it with emacs. (Bug#4789)
240 (leimdir): New variable.
241 ($(leimdir)/leim-list.el): New rule.
242 (emacs$(EXEEXT)): Depend on leim-list.el.
244 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
245 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
246 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
248 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
250 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
253 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
255 * xml.c (init_libxml2_functions) [WINDOWSNT]:
256 Remove unused local variable.
258 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
260 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
261 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
262 (mark_memory): Mark Lisp_Objects only if pointers might hide in
263 objects, as mark_maybe_pointer will catch them otherwise.
264 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
265 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
267 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
269 Fix typo that broke non-Windows builds.
270 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
272 2012-04-07 Eli Zaretskii <eliz@gnu.org>
274 Support building on MS-Windows with libxml2.
276 * makefile.w32-in (OBJ2): Add xml.$(O).
277 (GLOBAL_SOURCES): Add xml.c.
278 ($(BLD)/xml.$(O)): New dependency list.
280 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
281 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
282 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
283 [!WINDOWSNT]: New macros.
284 (init_libxml2_functions, libxml2_loaded_p): New functions.
285 (parse_region): Call fn_xmlCheckVersion instead of using the macro
286 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
287 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
288 Calls xmlCleanupParser only if libxml2 was loaded (or statically
290 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
291 Call init_libxml2_functions before calling libxml2 functions.
292 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
294 * emacs.c: Don't include libxml/parser.h.
295 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
296 xmlCleanupParser directly.
298 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
300 2012-04-07 Eli Zaretskii <eliz@gnu.org>
302 * indent.c (Fvertical_motion): If there is a display string at
303 point, use it.vpos to compute how many lines to backtrack after
304 move_it_to point. (Bug#11133)
306 2012-04-06 Eli Zaretskii <eliz@gnu.org>
308 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
309 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
310 about subtle differences between FETCH_CHAR* and STRING_CHAR*
311 macros related to unification of CJK characters. For the details,
312 see the discussion following the message here:
313 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
315 2012-04-04 Chong Yidong <cyd@gnu.org>
317 * keyboard.c (Vdelayed_warnings_list): Doc fix.
319 2012-04-01 Eli Zaretskii <eliz@gnu.org>
321 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
322 instead of alloca. (Bug#11138)
324 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
326 * w32menu.c (is_simple_dialog): Properly check lisp types.
329 2012-03-31 Eli Zaretskii <eliz@gnu.org>
331 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
332 position we get to after a call to move_it_to fails the
333 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
334 only if we wind up in a string from display property. (Bug#11063)
336 * window.c (Fdelete_other_windows_internal): Invalidate the row
337 and column information about mouse highlight, so that redisplay
338 restores it after reallocating the glyph matrices. (Bug#7464)
340 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
341 string comes from a `display' text property, use the buffer
342 position of that property as if we actually saw that position in
344 (move_it_by_lines): Remove the assertion that
345 "it->current_x == 0 && it->hpos == 0" which can be legitimately
346 violated when there's a before-string at the beginning of a line.
349 2012-03-30 Eli Zaretskii <eliz@gnu.org>
351 * xdisp.c (append_space_for_newline): If the default face was
352 remapped, use the remapped face for the appended newline.
353 (extend_face_to_end_of_line): Use the remapped default face for
354 extending the face to the end of the line.
355 (display_line): Call extend_face_to_end_of_line when the default
356 face was remapped. (Bug#11068)
358 2012-03-29 Eli Zaretskii <eliz@gnu.org>
360 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
362 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
364 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
366 2012-03-27 Glenn Morris <rgm@gnu.org>
368 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
371 2012-03-26 Kenichi Handa <handa@m17n.org>
373 * dispextern.h (struct glyph): Fix previous change. Change the
374 bit length of glyphless.ch to 25 (Bug#11082).
376 2012-03-26 Chong Yidong <cyd@gnu.org>
378 * keyboard.c (Vselection_inhibit_update_commands): New variable.
379 (command_loop_1): Use it; inhibit selection update for
380 handle-select-window too (Bug#8996).
382 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
384 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
386 2012-03-25 Kenichi Handa <handa@m17n.org>
388 * dispextern.h (struct glyph): Change the bit length of
389 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
391 2012-03-24 Eli Zaretskii <eliz@gnu.org>
393 * s/ms-w32.h (tzname): Include time.h before redirecting to
394 _tzname. Fixes the MSVC build. (Bug#9960)
396 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
398 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
401 * xterm.c (XTread_socket): Only modify handling_signal if
402 !SYNC_INPUT. (Bug#11080)
404 2012-03-23 Eli Zaretskii <eliz@gnu.org>
406 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
407 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
408 when fetching a multibyte character consumes more bytes than
409 CHAR_BYTES returns, due to unification of CJK characters in
410 string_char. (Bug#11073)
412 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
414 * process.c (wait_reading_process_output): Handle pty disconnect
415 by refraining from sending oneself a SIGCHLD (bug#10933).
417 2012-03-22 Chong Yidong <cyd@gnu.org>
419 * dispextern.h (struct it): New member string_from_prefix_prop_p.
421 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
422 Mark string as coming from a prefix property.
423 (handle_face_prop): Use default face for prefix strings (Bug#4281).
424 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
426 2012-03-21 Chong Yidong <cyd@gnu.org>
428 * xfaces.c (Vface_remapping_alist): Doc fix.
430 2012-03-20 Eli Zaretskii <eliz@gnu.org>
432 * w32proc.c (Fw32_set_console_codepage)
433 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
436 2012-03-20 Chong Yidong <cyd@gnu.org>
438 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
439 to reflect default non-nil value of redisplay-dont-pause.
441 2012-03-19 Kenichi Handa <handa@m17n.org>
443 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
444 it fit in a valid range (Bug#11003).
446 2012-03-18 Eli Zaretskii <eliz@gnu.org>
448 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
449 that is not from display property, accept the row as a "cursor
450 row" if one of the string's character has a non-nil `cursor'
451 property. Fixes cursor positioning when there are newlines in
452 overlay strings, e.g. in icomplete.el. (Bug#11035)
454 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
456 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
458 2012-03-12 Chong Yidong <cyd@gnu.org>
460 * eval.c (inhibit_lisp_code): Rename from
461 inhibit_window_configuration_change_hook; move from window.c.
463 * xfns.c (unwind_create_frame_1, Fx_create_frame):
464 * window.c (run_window_configuration_change_hook)
465 (syms_of_window): Callers changed.
467 2012-03-11 Chong Yidong <cyd@gnu.org>
469 * keymap.c (Fkey_description): Doc fix (Bug#9700).
471 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
473 2012-03-10 Chong Yidong <cyd@gnu.org>
475 * frame.c (other_visible_frames): Don't assume the selected frame
476 is visible (Bug#10955).
478 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
480 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
482 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
484 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
485 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
488 2012-03-03 Glenn Morris <rgm@gnu.org>
490 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
492 2012-03-02 Eli Zaretskii <eliz@gnu.org>
494 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
495 position past the first glyph_row that ends at ZV. (Bug#10902)
496 (redisplay_window, next_element_from_string): Fix typos in
498 (redisplay_window): Pass to move_it_vertically the margin in
499 pixels, not in screen lines.
501 2012-03-02 Glenn Morris <rgm@gnu.org>
503 * buffer.c (buffer-list-update-hook): Doc fix.
505 2012-02-29 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
508 push_it before setting up the iterator for the first overlay
509 string, even if we have an empty string loaded.
510 (next_overlay_string): If there's an empty string on the iterator
511 stack, pop the stack. (Bug#10903)
513 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
515 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
516 Suggested by Stefan Monnier in
517 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
518 * alloc.c (widen_to_Lisp_Object): New static function.
519 (mark_memory): Also mark Lisp_Objects by fetching pointer words
520 and widening them to Lisp_Objects. This would work even if
521 USE_LSB_TAG is defined and wide integers are used, which might
522 happen in a future version of Emacs.
524 2012-02-25 Chong Yidong <cyd@gnu.org>
526 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
529 * xselect.c (Fx_selection_exists_p): Doc fix.
530 (x_clipboard_manager_save_all): Print an informative message
531 before saving to clipboard manager.
533 2012-02-24 Chong Yidong <cyd@gnu.org>
535 * keyboard.c (process_special_events): Handle all X selection
536 requests in kbd_buffer, not just the next one (Bug#8869).
538 2012-02-23 Chong Yidong <cyd@gnu.org>
540 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
541 call when setting menu-bar-lines and tool-bar-lines parameters.
542 (unwind_create_frame_1): New helper function.
544 * window.c (inhibit_window_configuration_change_hook): New var.
545 (run_window_configuration_change_hook): Obey it.
546 (syms_of_window): Initialize it.
548 2012-02-22 Chong Yidong <cyd@gnu.org>
550 * xterm.c (x_draw_image_relief): Add missing type check for
551 Vtool_bar_button_margin (Bug#10743).
553 2012-02-21 Chong Yidong <cyd@gnu.org>
555 * fileio.c (Vfile_name_handler_alist): Doc fix.
557 * buffer.c (Fget_file_buffer): Protect against invalid file
558 handler return value.
560 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
562 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
563 when computing $valmask.
565 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
566 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
567 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
568 It's useless in that case, and it can cause problems on hosts
569 that allocate halves of EMACS_INT values separately.
570 Reported by Dan Horák. Diagnosed by Andreas Schwab in
571 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
572 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
573 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
574 it avoids undefined behavior on hosts where shifting right by more
575 than the word width has undefined behavior.
577 2012-02-19 Chong Yidong <cyd@gnu.org>
579 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
580 (Funhandled_file_name_directory, Ffile_name_as_directory)
581 (Fdirectory_file_name, Fexpand_file_name)
582 (Fsubstitute_in_file_name): Protect against invalid file handler
583 return values (Bug#10845).
585 2012-02-18 Eli Zaretskii <eliz@gnu.org>
587 * .gdbinit (pitx): Fix incorrect references to fields of the
590 2012-02-17 Chong Yidong <cyd@gnu.org>
592 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
594 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
596 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
597 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
599 2012-02-15 Chong Yidong <cyd@gnu.org>
601 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
602 marked as special. Also, starting docstrings with * is obsolete.
604 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
606 * gnutls.c (emacs_gnutls_write): Fix last change.
608 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
610 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
613 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
615 * keymap.c (Fsingle_key_description): Handle char ranges.
617 2012-02-12 Chong Yidong <cyd@gnu.org>
619 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
620 as that creates a dangerous corner case.
622 * window.c (Fdelete_window_internal): Invalidate the mouse
623 highlight (Bug#9904).
625 2012-02-12 Glenn Morris <rgm@gnu.org>
627 * xselect.c (Fx_own_selection_internal)
628 (Fx_get_selection_internal, Fx_disown_selection_internal)
629 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
630 * nsselect.m (Fx_own_selection_internal)
631 (Fx_disown_selection_internal, Fx_selection_exists_p)
632 (Fx_selection_owner_p, Fx_get_selection_internal):
633 Sync docs and argument specs with the xselect.c versions.
635 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
637 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
639 2012-02-11 Eli Zaretskii <eliz@gnu.org>
641 * w32select.c (Fx_selection_exists_p): Sync doc string and
642 argument list with xselect.c. (Bug#10783)
644 * w16select.c (Fx_selection_exists_p): Sync doc string and
645 argument list with xselect.c. (Bug#10783)
647 2012-02-10 Glenn Morris <rgm@gnu.org>
649 * fns.c (Fsecure_hash): Doc fix.
651 2012-02-09 Kenichi Handa <handa@m17n.org>
653 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
655 2012-02-07 Chong Yidong <cyd@gnu.org>
657 * buffer.c (Fbuffer_local_variables)
658 (buffer_lisp_local_variables): Handle unbound vars correctly;
659 don't let Qunbound leak into Lisp.
661 2012-02-07 Glenn Morris <rgm@gnu.org>
663 * image.c (Fimagemagick_types): Doc fix.
665 * image.c (imagemagick-render-type): Change it from a lisp object
666 to an integer. Move the doc here from the lisp manual.
667 Treat all values not equal to 0 the same.
669 2012-02-06 Chong Yidong <cyd@gnu.org>
671 * doc.c (store_function_docstring): Avoid applying docstring of
672 alias to base function (Bug#2603).
674 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
676 * .gdbinit (pp1, pv1): Remove redundant defines.
679 2012-02-04 Chong Yidong <cyd@gnu.org>
681 * nsterm.m: Declare a global (Bug#10694).
683 2012-02-04 Eli Zaretskii <eliz@gnu.org>
685 * w32.c (get_emacs_configuration_options):
686 Include --enable-checking, if specified, in the return value.
688 2012-02-04 Martin Rudalics <rudalics@gmx.at>
690 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
691 after rounding frame sizes. (Bug#9723)
693 2012-02-04 Eli Zaretskii <eliz@gnu.org>
695 * keyboard.c (adjust_point_for_property): Don't position point
696 before BEGV. (Bug#10696)
698 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
700 Handle overflow when computing char display width (Bug#9496).
701 * character.c (char_width): Return EMACS_INT, not int.
702 (char_width, c_string_width): Check for overflow when
703 computing the width; this is possible now that individual
704 characters can have unbounded width. Problem introduced
705 by merge from Emacs 23 on 2012-01-19.
707 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
709 * dbusbind.c (Fdbus_register_method): Mention the return value
710 :ignore in the docstring.
712 2012-02-02 Glenn Morris <rgm@gnu.org>
714 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
716 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
717 Unconditionally set to t. (Bug#10673)
718 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
719 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
720 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
722 2012-02-02 Kenichi Handa <handa@m17n.org>
724 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
725 0, do not call append_composite_glyph.
727 2012-02-02 Kenichi Handa <handa@m17n.org>
729 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
731 (x_produce_glyphs): If the component of a composition is a null
732 string, set it->pixel_width to 1 to avoid zero-width glyph.
734 2012-02-01 Eli Zaretskii <eliz@gnu.org>
736 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
737 first 2 arguments are identical. This makes inserting large
738 output from a subprocess an order of magnitude faster on
739 MS-Windows, where all sbrk'ed memory is always contiguous.
741 2012-01-31 Glenn Morris <rgm@gnu.org>
743 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
744 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
745 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
747 2012-01-29 Glenn Morris <rgm@gnu.org>
749 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
751 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
753 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
755 2012-01-28 Chong Yidong <cyd@gnu.org>
757 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
759 2012-01-26 Chong Yidong <cyd@gnu.org>
761 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
763 * search.c (Fsearch_forward, Fsearch_backward): Document negative
764 repeat counts (Bug#10507).
766 2012-01-26 Glenn Morris <rgm@gnu.org>
768 * lread.c (syms_of_lread): Doc fix.
770 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
772 * coding.c (encode_designation_at_bol): Change return value to
775 2012-01-25 Chong Yidong <cyd@gnu.org>
777 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
779 2012-01-21 Chong Yidong <cyd@gnu.org>
781 * floatfns.c (Fcopysign): Make the second argument non-optional,
782 since nil is not allowed anyway.
784 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
786 * process.c (read_process_output): Use p instead of XPROCESS (proc).
787 (send_process): Likewise.
789 2012-01-19 Martin Rudalics <rudalics@gmx.at>
791 * window.c (save_window_save, Fcurrent_window_configuration)
792 (Vwindow_persistent_parameters): Do not use Qstate.
795 2012-01-19 Kenichi Handa <handa@m17n.org>
797 * character.c (char_width): New function.
798 (Fchar_width, c_string_width, lisp_string_width):
799 Use char_width (Bug#9496).
801 2012-01-16 Martin Rudalics <rudalics@gmx.at>
803 * window.c (Vwindow_persistent_parameters): New variable.
804 (Fset_window_configuration, save_window_save): Handle persistent
807 2012-01-14 Eli Zaretskii <eliz@gnu.org>
809 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
810 thrashing the stack of the thread. (Bug#9087)
812 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
814 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
816 2012-01-11 Eli Zaretskii <eliz@gnu.org>
818 * xdisp.c (rows_from_pos_range): Handle the case where the
819 highlight ends on a newline. (Bug#10464)
820 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
821 he end column for display of highlight that ends on a newline
824 2012-01-11 Glenn Morris <rgm@gnu.org>
826 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
827 from load-path also when installation-directory is nil. (Bug#10208)
829 2012-01-10 Glenn Morris <rgm@gnu.org>
831 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
833 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
834 Update template values to be closer to their typical values these days.
836 2012-01-09 Eli Zaretskii <eliz@gnu.org>
838 * xdisp.c (rows_from_pos_range): Accept additional argument
839 DISP_STRING, and accept any glyph in a row whose object is that
840 string as eligible for mouse highlight. Fixes mouse highlight of
841 display strings from overlays. (Bug#10464)
843 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
845 emacs: fix an auto-save permissions race condition (Bug#10400)
846 * fileio.c (auto_saving_dir_umask): New static var.
847 (Fmake_directory_internal): Use it.
848 (do_auto_save_make_dir): Set it, instead of invoking chmod after
849 creating the directory. The old code temporarily assigns
850 too-generous permissions to the directory.
851 (do_auto_save_eh): Clear it.
852 (Fdo_auto_save): Catch all errors, not just file errors, so
853 that the var is always cleared.
855 2012-01-07 Eli Zaretskii <eliz@gnu.org>
857 * search.c (scan_buffer): Pass character positions to
858 know_region_cache, not byte positions. (Bug#6540)
860 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
862 * w32.c (sys_rename): Report EXDEV when rename of a directory
863 fails because the target is on another logical disk. (Bug#10284)
865 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
867 * xterm.c (x_embed_request_focus): New function.
869 * xterm.h: Add prototype.
871 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
873 2012-01-05 Glenn Morris <rgm@gnu.org>
875 * emacs.c (emacs_copyright): Update short copyright year to 2012.
877 2012-01-01 Eli Zaretskii <eliz@gnu.org>
879 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
880 Load gnutls_transport_set_lowat only if GnuTLS version is below
882 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
883 GnuTLS versions below 2.11.1.
885 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
887 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
888 to the doc string advising against its use for altering the way
889 windows are scrolled.
891 2011-12-28 Kenichi Handa <handa@m17n.org>
893 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
894 coding-system ASCII compatible only when it does not produce BOM
895 on encoding (Bug#10383).
897 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
899 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
901 (create_and_show_popup_menu): Always use menu_position_func for
904 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
906 * callint.c (Fcall_interactively): Don't truncate prompt string.
908 2011-12-23 Eli Zaretskii <eliz@gnu.org>
910 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
911 property that ends at ZV, so that the bidi iteration could be
912 resumed from there (after widening). (Bug#10360)
914 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
916 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
918 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
920 * nsterm.m (x_free_frame_resources):
921 Release f->output_data.ns->miniimage.
922 (ns_index_color): Fix indentation. Do not retain
923 color_table->colors[i].
925 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
928 * nsfns.m (x_set_background_color): Assign return value from
929 ns_index_color to face-background instead of NSColor*.
930 (ns_implicitly_set_icon_type): Fix indentation.
931 Change assignment in for loop to comparison.
933 * emacs.c (ns_pool): New variable.
934 (main): Assign ns_pool.
935 (Fkill_emacs): Call ns_release_autorelease_pool.
937 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
938 autorelease fdesc, release fdAttrs and tdict.
939 (ns_get_covering_families): Release charset.
940 (ns_findfonts): Release NSFontDescriptor created with new.
941 (ns_uni_to_glyphs): Fix indentation.
942 (setString): Release attrStr before assigning new value.
944 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
946 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
948 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
949 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
951 2011-12-18 David Reitter <reitter@cmu.edu>
953 * nsterm.m (ns_term_init): Subscribe for notifications
954 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
955 to method trackingNotification in EmacsMenu.
957 * nsmenu.m (trackingMenu): New variable.
958 (trackingNotification): New method (from Aquamacs).
959 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
960 from Aquamacs (Bug#7030).
962 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
964 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
965 (symbol_to_nsstring): Fix indentation.
966 (ns_symbol_to_pb): New function.
967 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
968 (Fns_rotate_cut_buffers_internal): Remove.
969 (Fns_store_selection_internal): Rename from
970 Fns_store_cut_buffer_internal.
971 (ns_get_foreign_selection, Fx_own_selection_internal)
972 (Fx_disown_selection_internal, Fx_selection_exists_p)
973 (Fns_get_selection_internal, Fns_store_selection_internal):
974 Use ns_symbol_to_pb and check if return value is nil.
975 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
976 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
977 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
978 renamed to Sns_store_selection_internal.
979 (ns_handle_selection_request): Move code to Fx_own_selection_internal
980 and remove this function.
981 (ns_handle_selection_clear): Remove, never used.
982 (Fx_own_selection_internal): Move code from ns_handle_selection_request
985 2011-12-17 Ken Brown <kbrown@cornell.edu>
987 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
988 GID is unknown (Bug#10257).
990 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
992 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
993 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
994 which caused a build failure on GNU/Linux IA-64. This problem was
995 introduced by my 2011-10-07 patch.
997 2011-12-15 Juri Linkov <juri@jurta.org>
999 * image.c (imagemagick_error): New function. (Bug#10112)
1000 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1001 Use `imagemagick_error' where ImageMagick functions return
1003 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1006 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1008 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1009 fill background (Bug#8992).
1011 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1013 * window.c (Vwindow_combination_resize)
1014 (Vwindow_combination_limit): Use t instead of non-nil in
1016 (Vrecenter_redisplay): Add first sentence of doc-string on
1018 (Frecenter): Fix doc-string typo.
1020 2011-12-11 Kenichi Handa <handa@m17n.org>
1022 * coding.c (Funencodable_char_position): Pay attention to the
1023 buffer text relocation (Bug#9389).
1025 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1027 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1028 gtk_init (Bug#10100).
1030 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1032 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1033 IT->string is nil. (Bug#10263)
1035 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1037 * nsterm.h (x_free_frame_resources): Declare.
1039 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1040 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1042 * nsterm.h (ns_get_defaults_value): Declare.
1044 * nsterm.m (ns_default): Call ns_get_defaults_value.
1046 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1048 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1051 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1053 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1054 that where the value of an _OBJC_* symbol points to is in the .bss
1055 section (Bug#10240).
1057 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1059 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1060 after the loop to call ccl_driver at least once (Bug#8619).
1062 2011-12-08 Kenichi Handa <handa@m17n.org>
1064 * ftfont.c (get_adstyle_property): Fix previous change
1067 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1069 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1070 dirs from the default value of EMACSLOADPATH (bug#10208).
1072 2011-12-07 Glenn Morris <rgm@gnu.org>
1074 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1075 installation and source directories as well. (Bug#10208)
1077 2011-12-06 Chong Yidong <cyd@gnu.org>
1079 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1081 2011-12-06 Glenn Morris <rgm@gnu.org>
1083 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1084 as an error, not just -1. (Bug#10217)
1086 2011-12-05 Chong Yidong <cyd@gnu.org>
1088 * keyboard.c (process_special_events): New function.
1089 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1091 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1093 * coding.c (encode_designation_at_bol): Don't use uninitialized
1094 local variable (Bug#9318).
1096 2011-12-05 Kenichi Handa <handa@m17n.org>
1098 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1099 return Qnil (Bug#8046, Bug#10193).
1101 2011-12-05 Kenichi Handa <handa@m17n.org>
1103 * coding.c (encode_designation_at_bol): New args charbuf_end and
1104 dst. Return the number of produced bytes. Callers changed.
1105 (coding_set_source): Return how many bytes coding->source was
1107 (coding_set_destination): Return how many bytes
1108 coding->destination was relocated.
1109 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1110 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1112 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1114 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1115 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1118 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1120 The following changes are to fix Bug#9318.
1122 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1123 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1124 (encode_coding_iso_2022, encode_coding_sjis)
1125 (encode_coding_big5, encode_coding_charset): Use the above macros.
1127 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1129 * lisp.h (process_quit_flag): Fix external declaration.
1131 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1133 Don't macro-inline non-performance-critical code.
1134 * eval.c (process_quit_flag): New function.
1135 * lisp.h (QUIT): Use it.
1137 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1139 * nsfns.m (get_geometry_from_preferences): New function.
1140 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1142 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1144 * emacs.c (Qkill_emacs): Define.
1145 (syms_of_emacs): Initialize it.
1146 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1147 Qquit_flag to `kill-emacs' instead.
1148 (quit_throw_to_read_char): Add parameter `from_signal'.
1149 All callers changed. Call Fkill_emacs if requested and safe.
1150 * lisp.h (QUIT): Call Fkill_emacs if requested.
1152 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1154 * widget.c (update_wm_hints): Return if wmshell is null.
1155 (widget_update_wm_size_hints): New function.
1157 * widget.h (widget_update_wm_size_hints): Declare.
1159 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1160 widget_update_wm_size_hints (Bug#10104).
1162 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1164 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1165 before a newline, prepare the bidi iterator for consuming the
1166 newline, and keep the current paragraph direction. (Bug#10183)
1167 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1169 2011-12-02 Juri Linkov <juri@jurta.org>
1171 * search.c (Fword_search_regexp): New Lisp function created from
1172 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1173 (Fword_search_backward, Fword_search_forward)
1174 (Fword_search_backward_lax, Fword_search_forward_lax):
1175 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1176 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1178 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1180 * fileio.c (Finsert_file_contents): Move after-change-function call
1181 to before the "handled:" label, since all "goto handled" appear in
1182 cases where the *-change-functions have already been properly called
1185 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1187 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1188 waiting for input. (Bug#10169)
1190 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1192 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1193 verifies glyph row's hash code--we have just reallocated the
1194 glyphs, so their contents can be complete garbage. (Bug#10164)
1196 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1198 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1200 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1202 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1203 attributes are tested _before_ calling verify_row_hash, to protect
1204 against GCC re-ordering of the tests. (Bug#10164)
1206 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1208 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1210 * xterm.c (handle_one_xevent): Only set async_visible and friends
1211 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1212 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1213 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1215 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1217 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1218 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1219 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1220 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1221 All uses changed to use GCPRO1 etc.
1222 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1223 Revert to old implementation (i.e., before 2011-03-11).
1225 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1227 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1228 of scroll runs so as to avoid assigning disabled bogus rows and
1229 unnecessary graphics copy operations.
1231 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1233 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1234 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1235 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1236 (malloc, free, realloc, calloc): Redirect to e_* only when
1239 * lisp.h (GCTYPEBITS): Move before first use.
1240 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1241 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1242 this macro definition.
1244 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1247 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1249 * gtkutil.c (xg_create_frame_widgets):
1250 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1251 present with Gtk+ 2.0.
1253 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1255 * fileio.c (Finsert_file_contents): Undo previous change; see
1256 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1258 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1260 Rename locals to avoid shadowing.
1261 * fileio.c (Finsert_file_contents):
1262 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1263 * process.c (wait_reading_process_output):
1264 Rename inner 'proc' to 'p' to avoid shadowing.
1265 Indent for consistency with usual Emacs style.
1267 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1269 * xdisp.c (redisplay_window): If cursor row is not fully visible
1270 after recentering, and scroll-conservatively is set to a large
1271 number, scroll window by a few more lines to make the cursor fully
1272 visible and out of scroll-margin. (Bug#10105)
1273 (start_display): Don't move to the next line if the display should
1274 start at a newline that is part of a display vector or an overlay
1277 2011-11-24 Juri Linkov <juri@jurta.org>
1279 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1280 after the `MagickPingImage' call. (Bug#10112)
1282 2011-11-23 Chong Yidong <cyd@gnu.org>
1284 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1286 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1288 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1289 making another buffer current. (Bug#10114)
1291 2011-11-23 Glenn Morris <rgm@gnu.org>
1293 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1295 2011-11-23 Chong Yidong <cyd@gnu.org>
1297 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1298 using it (Bug#5984).
1300 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1302 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1303 and header-lines, as they don't have one computed for them.
1306 * .gdbinit (prow): Make displayed values more self-explaining.
1307 Add row's hash code.
1309 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1311 * process.c (wait_reading_process_output): Fix asynchrounous
1312 GnuTLS socket handling on some versions of the GnuTLS library.
1313 (wait_reading_process_output): Add comment and URL.
1315 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1317 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1319 2011-11-21 Chong Yidong <cyd@gnu.org>
1321 * window.c (Fnext_window, Fprevious_window): Doc fix.
1323 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1325 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1327 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1329 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1331 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1333 * window.c (Fset_window_combination_limit): Rename argument
1335 (Vwindow_combination_limit): Remove "status" from doc-string.
1337 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1339 * m/ibms390.h: Remove.
1340 * m/ibms390x.h: Don't include "ibms390.h".
1342 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1344 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1345 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1347 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1349 * casetab.c (Fset_case_table):
1350 * charset.c (Fcharset_after): Fix typos.
1352 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1354 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1355 Otherwise, valgrind does not work on some platforms.
1356 Problem reported by Andreas Schwab in
1357 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1358 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1359 is set, removing the need for VIRT_ADDRESS_VARIES.
1360 (PURE_P): Use a more-efficient implementation that needs just one
1361 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1362 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1363 to 4 (xorl, subq, cmpq, setbe).
1364 * alloc.c (pure): Always extern now, since that's the
1365 VIRT_ADDR_VARIES behavior.
1366 (PURE_POINTER_P): Use a single comparison, not two, for
1367 consistency with the new puresize.h.
1368 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1369 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1370 Remove VIRT_ADDR_VARIES no longer needed.
1372 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1374 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1375 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1376 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1377 behave as if the cursor position were at the window margin.
1379 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1380 and the cursor position is out of bounds, behave as if the cursor
1381 position were at the window margin. (Bug#10075)
1383 2011-11-18 Chong Yidong <cyd@gnu.org>
1385 * window.c (Fwindow_combination_limit): Make first argument
1386 non-optional, since it is meaningless for live windows like the
1389 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1391 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1393 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1395 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1396 (graft_intervals_into_buffer): Simplify.
1398 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1400 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1401 hash values of the two rows.
1402 (copy_row_except_pointers): Preserve the used[] arrays and the
1403 hash values of the two rows. (Bug#10035)
1404 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1406 * xdisp.c (row_hash): New function, body extracted from
1407 compute_line_metrics.
1408 (compute_line_metrics): Call row_hash, instead of computing the
1411 * dispnew.c (verify_row_hash): Call row_hash for computing the
1412 hash code of a row, instead of duplicating code from xdisp.c.
1414 * dispextern.h (row_hash): Add prototype.
1416 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1418 * frame.c (delete_frame): Don't delete the terminal when the last
1419 X frame is closed if emacs is built with GTK toolkit.
1421 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1423 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1425 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1427 * window.c (Vwindow_splits): Rename to
1428 Vwindow_combination_resize. Suggested by Juri Linkov.
1429 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1432 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1434 * nsfns.m (Fns_font_name):
1435 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1437 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1439 * window.h (window): Rename slot "nest" to "combination_limit".
1440 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1441 (Fset_window_nest): Rename to Fset_window_combination_limit.
1442 (Vwindow_nest): Rename to Vwindow_combination_limit.
1443 (recombine_windows, make_parent_window, make_window)
1444 (Fsplit_window_internal, saved_window)
1445 (Fset_window_configuration, save_window_save): Rename all
1446 occurrences of window_nest to window_combination_limit.
1448 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1450 * image.c (imagemagick_load_image): Fix typo.
1452 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1454 * xdisp.c (display_line): Move the call to
1455 highlight_trailing_whitespace before the call to
1456 compute_line_metrics, since the latter needs to see the final
1457 faces of all the glyphs to compute ROW's hash value.
1458 Fixes assertion violations in row_equal_p. (Bug#10035)
1460 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1462 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1463 just return (bug#10044).
1465 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1467 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1468 with user-defined heap size. Bump the default size of the temacs
1469 heap to 27MB, to avoid memory warning when running temacs.
1470 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1472 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1473 current_matrix and desired_matrix. (Bug#9990)
1474 (verify_row_hash) [XASSERTS]: New function.
1475 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1476 that the hash value of glyph rows is correct.
1478 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1480 * window.h (window): Remove splits slot.
1481 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1482 (Fdelete_other_windows_internal, make_parent_window)
1483 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1484 (Fset_window_configuration, save_window_save): Don't deal with
1485 split status of windows.
1486 (saved_window): Remove splits slot.
1487 (Vwindow_splits): Rewrite doc-string.
1489 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1491 * xfns.c (unwind_create_frame):
1492 * nsfns.m (unwind_create_frame):
1493 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1494 Vframe_list (Bug#9999).
1496 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1498 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1500 2011-11-11 Kenichi Handa <handa@m17n.org>
1502 * callproc.c (Fcall_process): Set the member dst_multibyte of
1505 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1507 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1508 avoid a crash (bug#9496).
1510 2011-11-09 Chong Yidong <cyd@gnu.org>
1512 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1513 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1515 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1517 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1519 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1521 Avoid some portability problems by eschewing 'extern inline' functions.
1522 The trivial performance wins aren't worth the portability hassles; see
1523 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1525 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1526 (window_box_width, window_box_left, window_box_left_offset)
1527 (window_box_right, window_box_right_offset): Undo previous change,
1528 by removing the "extern"s.
1529 * intervals.c (adjust_intervals_for_insertion)
1530 (adjust_intervals_for_deletion): Undo previous change,
1531 making these static again.
1532 (offset_intervals, temp_set_point_both, temp_set_point)
1533 (copy_intervals_to_string): No longer inline.
1534 * xdisp.c (window_text_bottom_y, window_box_width)
1535 (window_box_height, window_box_left_offset)
1536 (window_box_right_offset, window_box_left, window_box_right)
1537 (window_box): No longer inline.
1539 2011-11-08 Chong Yidong <cyd@gnu.org>
1541 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1542 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1543 Signal an error if not a live window.
1544 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1545 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1547 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1549 * lisp.h (syms_of_abbrev): Remove declaration.
1550 Reported by CHENG Gao <chenggao@royau.me>.
1552 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1554 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1555 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1556 of temacs in GUI mode.
1558 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1560 * window.h: Declare delete_all_child_windows instead of
1561 delete_all_subwindows.
1562 * window.c (Fwindow_nest, Fset_window_nest)
1563 (Fset_window_new_total, Fset_window_new_normal)
1564 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1565 (delete_all_subwindows): Rename to delete_all_child_windows.
1566 (Fdelete_other_windows_internal, Fset_window_configuration):
1567 Call delete_all_child_windows instead of delete_all_subwindows.
1568 * frame.c (delete_frame): Call delete_all_child_windows instead
1569 of delete_all_subwindows.
1571 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1573 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1574 This is also needed for porting to any host where GC_MARK_STACK is
1575 not GC_MAKE_GCPROS_NOOPS.
1576 (which_symbols): Use it.
1578 2011-11-07 Kenichi Handa <handa@m17n.org>
1580 * coding.c (coding_set_destination): Check coding->src_pos only
1581 when coding->src_object is a buffer (bug#9910).
1583 * process.c (send_process): Set the member src_multibyte of coding
1584 to 0 (bug#9911) when sending a unibyte text.
1586 * callproc.c (Fcall_process): Set the member src_multibyte of
1587 process_coding to 0 (bug#9912).
1589 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1591 * xmenu.c (cleanup_widget_value_tree): New function.
1592 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1593 calling free_menubar_widget_value_tree directly (Bug#9830).
1595 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1597 Fix some portability problems with 'inline'.
1598 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1599 (window_box_width, window_box_left, window_box_left_offset)
1600 (window_box_right, window_box_right_offset): Declare extern.
1601 Otherwise, these inline functions do not conform to C99 and
1602 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1603 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1604 * intervals.c (adjust_intervals_for_insertion)
1605 (adjust_intervals_for_deletion): Now extern, because otherwise the
1606 extern inline functions 'offset_intervals' couldn't refer to it.
1607 (static_offset_intervals): Remove.
1608 (offset_intervals): Rewrite using the old contents of
1609 static_offset_intervals. The old version didn't conform to C99
1610 because an extern inline function contained a reference to an
1611 identifier with static linkage.
1613 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1615 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1618 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1620 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1621 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1622 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1623 return Qleft_to_right.
1625 2011-11-06 Chong Yidong <cyd@gnu.org>
1627 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1628 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1629 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1630 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1631 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1632 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1633 (Fwindow_vscroll): Doc fix.
1634 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1635 argument, since it makes no sense to pass a live window and for
1636 consistency with window-child.
1638 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1640 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1643 2011-11-05 Jason Rumney <jasonr@gnu.org>
1645 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1646 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1648 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1649 bitwise arithmetic preventing use of unicode-sip and non-truetype
1652 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1654 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1657 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1658 initialization code to keep similarity to xfns.c after changes
1661 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1663 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1664 (unwind_create_frame): New function (Bug#9943).
1665 (Fx_create_frame): Restructure code to be more similar to the one in
1666 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1667 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1668 Move terminal->reference_count++ just before making the frame official
1671 * nsterm.m (x_free_frame_resources): New function.
1672 (x_destroy_window): Move code to x_free_frame_resources.
1674 * xfns.c (unwind_create_frame): Fix comment.
1675 (Fx_create_frame, x_create_tip_frame):
1676 Move terminal->reference_count++ just before making the frame
1677 official. Move initialization of image_cache_refcount and
1678 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1680 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1682 Support MSVC build with newer versions of Visual Studio.
1683 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1684 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1687 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1688 which are not supported by MSVC.
1689 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1690 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1692 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1694 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1696 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1698 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1700 Support MSVC build with newer versions of Visual Studio.
1701 * w32.c: Don't include w32api.h for MSVC.
1702 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1704 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1705 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1706 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1707 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1709 (alloca) [_MSC_VER]: Define to _alloca.
1711 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1713 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1715 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1717 * xdisp.c (note_mouse_highlight): If either of
1718 previous/next-single-property-change returns nil, treat that as
1719 the beginning or the end of the buffer. (Bug#9955)
1721 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1723 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1724 label is not null (Bug#9951).
1725 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1728 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1730 * window.c (Fwindow_body_size): Mention in the doc string that the
1731 return value is in frame's canonical units. (Bug#9949)
1733 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1735 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1737 * w32fns.c (unwind_create_frame): If needed, free the glyph
1738 matrices of the partially constructed frame. (Bug#9943)
1739 * xfns.c (unwind_create_frame): Likewise.
1741 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1743 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1744 Don't stop backward scan on the continuation glyph, even though
1745 its CHARPOS is positive.
1746 (mouse_face_from_buffer_pos, note_mouse_highlight):
1747 Rename cover_string to disp_string.
1749 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1751 * window.c (temp_output_buffer_show): Don't use
1752 Vtemp_buffer_show_specifiers.
1753 (Vtemp_buffer_show_specifiers): Remove unused variable.
1755 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1757 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1758 past the beginning of the current glyph matrix.
1760 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1762 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1763 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1764 HAVE_GTK3 (Bug#9869).
1766 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1767 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1769 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1771 * xterm.c: Declare x_handle_net_wm_state to return int.
1772 (handle_one_xevent): Check if we are iconified but don't have
1773 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1774 (get_current_wm_state): Return non-zero if not hidden,
1775 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1776 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1777 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1778 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1780 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1782 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1783 so that this new function doesn't get optimized away by a
1784 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1786 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1788 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1790 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1792 Fix the `xbytecode' command.
1793 * .gdbinit (xprintbytestr): New command.
1794 (xwhichsymbols): Rename from `which'; all callers changed.
1795 (xbytecode): Print the byte-code string as well.
1797 2011-10-29 Kim Storm <storm@cua.dk>
1799 * alloc.c (which_symbols): New function.
1801 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1803 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1806 2011-10-29 Glenn Morris <rgm@gnu.org>
1808 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1809 Not clear what it was for, and it causes various bugs. (Bug#9839)
1811 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1813 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1814 possible random value that matches one of those tested as
1815 condition to clear the mouse face.
1817 2011-10-28 Chong Yidong <cyd@gnu.org>
1819 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1821 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1823 * window.c (make_window): Initialize phys_cursor_on_p.
1825 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1827 * lisp.h (struct Lisp_Symbol): Update comments.
1829 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1831 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1833 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1835 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1836 <oslsachem@gmail.com> for helping to debug this.
1838 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1839 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1840 (g_b_init_get_glyph_outline_w): New static variables.
1841 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1842 (GetGlyphOutlineW_Proc): New typedefs.
1843 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1844 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1846 (w32font_open_internal, compute_metrics):
1847 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1848 instead of calling the "wide" APIs directly.
1850 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1852 * w32.h (syms_of_w32font): Add prototype.
1854 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1856 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1857 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1858 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1859 (Fmove_to_window_line): Doc fix.
1861 2011-10-27 Chong Yidong <cyd@gnu.org>
1863 * process.c (make_process): Set gnutls_state to NULL.
1865 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1866 non-NULL, regardless of GNUTLS_INITSTAGE.
1867 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1868 an error. Set process slots as soon as we allocate them.
1870 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1872 2011-10-27 Chong Yidong <cyd@gnu.org>
1874 * gnutls.c (emacs_gnutls_deinit): New function.
1875 Deallocate credentials structures as well as calling gnutls_deinit.
1876 (Fgnutls_deinit, Fgnutls_boot): Use it.
1878 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1879 (deactivate_process): Call emacs_gnutls_deinit.
1881 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1883 * image.c (x_create_x_image_and_pixmap):
1884 * w32.c (sys_rename, w32_delayed_load):
1885 * w32font.c (fill_in_logfont):
1886 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1888 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1890 * w32fns.c (w32_default_color_map): New function,
1891 extracted from Fw32_default_color_map.
1892 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1894 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1896 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1898 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1900 * keyboard.c (test_undefined): New function (bug#9751).
1901 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1903 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1905 * sysdep.c (init_sys_modes): Fix the check for the controlling
1906 terminal (Bug#6649).
1908 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1910 * dispextern.h (struct bidi_it): New member next_en_type.
1912 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1913 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1914 current character, check also for next_en_type being WEAK_EN.
1915 (bidi_resolve_weak): Don't enter the expensive loop if the current
1916 position is before next_en_pos. Record the bidi type of the first
1917 non-ET, non-BN character we find, in addition to its position.
1918 (bidi_level_of_next_char): Invalidate next_en_type when
1919 next_en_pos is over-stepped.
1921 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1923 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1924 * editfns.c: Rewrite current-time-zone so that it invokes
1925 the equivalent of (format-time-string "%Z") to get the time zone name.
1926 This fixes a bug when the time zone name contains characters that
1927 need converting from the system time locale to Emacs internal format.
1928 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1929 that patch fixed format-time-string to do the conversion, but
1930 I forgot to fix current-time-zone.
1931 (format_time_string): New function, containing most of
1932 what Fformat_time_string used to contain.
1933 (Fformat_time_string): Rewrite in terms of format_time_string.
1934 This doesn't change this function's behavior.
1935 (current-time-zone): Rewrite to use format_time_string.
1936 This fixes the bug reported by Michael Schierl in
1937 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1938 Jason Rumney's 2007-06-07 change worked around this bug, but
1940 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1942 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1944 * xdisp.c (start_display): If the character at POS is displayed
1945 via a display vector, reset IT->current.dpvec_index to zero.
1946 (try_window_reusing_current_matrix): If a line ends in a display
1947 vector or the next line starts in a display vector, continue
1948 redrawing the window even though the character position of
1949 start_row was reached.
1952 2011-10-18 Chong Yidong <cyd@gnu.org>
1954 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1955 with nobreak-char-display too.
1957 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1959 Fix part 3 of bug#9771.
1960 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1961 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1962 non-neutral characters if the current character is a paragraph
1963 separator (a.k.a. Newline). This avoids running the same
1964 expensive loop twice, once when we consume the preceding newline
1965 and the other time when the line actually needs to be displayed.
1966 Avoid the loop when we see neutrals on the base embedding level
1967 following a character whose directionality is the same as the
1968 paragraph's. This avoids running the expensive loop when a line
1969 ends in a long sequence of neutrals, like control characters.
1970 Add assertion against STRONG_AL type. Slightly rearrange code
1971 that determines the type of a neutral given the first non-neutral
1973 (bidi_level_of_next_char): Set next_en_pos to zero when
1974 invalidating its info.
1976 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1978 * xdisp.c (push_display_prop): Determine whether to record string
1979 or buffer position by IT->string, not by IT->method. Allow
1980 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1981 (move_it_vertically_backward): Don't look for character position
1982 immediately after the newline when in a continuation line.
1985 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1987 * window.c (coordinates_in_window): Rewrite and delabelize
1988 vertical border check. (Bug#5357) (Bug#9618)
1990 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1992 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1993 errors in XSetWindowBorder (bug#9310).
1995 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1997 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1998 avoid crash when xmalloc overrun checking is enabled.
2000 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2002 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2003 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2004 cursor motion with <left> and <right> arrow keys.
2006 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2007 some callers set that themselves.
2009 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2011 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2012 display string and the previous row comes from the same string and
2013 is empty. (Bug#9739) (Bug#9738)
2015 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2017 * doc.c (get_doc_string): Encode file name (bug#9735).
2019 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2021 * bidi.c (bidi_level_of_next_char):
2022 * xdisp.c (get_visually_first_element): Remove old incorrect
2023 comments regarding the Unicode Line Separator character.
2025 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2027 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2029 * alloc.c (Fgc_status): Do not access beyond zombies array
2030 boundary if nzombies > MAX_ZOMBIES.
2031 * alloc.c (dump_zombies): Add missing format specifier.
2033 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2035 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2036 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2038 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2039 Some packages use them to denote characters with modifiers.
2041 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2043 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2044 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2045 matching a pp-number. Rename parameter var to var1.
2047 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2049 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2051 2011-10-08 Glenn Morris <rgm@gnu.org>
2053 * callint.c (Fcall_interactively): Give a more explicit error for the
2054 'c' case with a non-character input. (Bug#8479)
2056 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2058 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2060 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2061 lines that are hscrolled on the left.
2063 * dispnew.c (buffer_posn_from_coords): Account for a possible
2064 presence of header-line. (Bug#4426)
2066 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2068 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2069 Don't advertise functionality which we discourage or doesn't work.
2071 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2073 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2074 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2075 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2076 this makes Emacs dump core during garbage collection on rare
2077 occasions. sizeof is obviously inferior to offsetof here, so
2078 stick with offsetof.
2079 (GC_POINTER_ALIGNMENT): New macro.
2080 (mark_memory): Omit 3rd (offset) arg; caller changed.
2081 Don't assume EMACS_INT alignment is the same as pointer alignment.
2083 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2085 * keyboard.c (read_key_sequence_remapped): New var.
2086 (read_key_sequence): Compute remapping in the right buffer.
2087 (command_loop_1): Use read_key_sequence's remapping directly.
2089 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2091 * dired.c (file_name_completion): Don't expand file name.
2092 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2093 before checking file name handler.
2095 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2096 they've been requested explicitly (bug#9591).
2098 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2100 * keymap.c (Fsingle_key_description): Use make_specified_string
2101 instead of build_string to build string from push_key_description.
2104 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2106 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2107 This fixes a Y2038 bug on 64-bit hosts.
2108 * buffer.c (reset_buffer):
2109 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2110 (Fclear_buffer_auto_save_failure):
2111 Use 0, not -1, to represent an unset failure time, since time_t
2112 might not be signed.
2114 Remove dependency on glibc malloc internals.
2115 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2116 Move back here from lisp.h, but with their new implementations.
2117 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2118 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2119 * charset.c (charset_table_init): New static var.
2120 (syms_of_charset): Use it instead of xmalloc. This removes a
2121 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2122 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2123 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2124 Move back to alloc.c.
2125 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2126 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2128 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2130 * nsterm.m (windowDidResize): Call x_set_window_size only when
2131 ns_in_resize is true. Otherwise set pixelwidth/height and
2132 call change_frame_size (Bug#9628).
2134 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2136 Port --enable-checking=all to Fedora 14 x86-64.
2137 * charset.c (syms_of_charset): Also account for glibc malloc's
2138 internal overhead when calculating the initial malloc maximum.
2140 Port --enable-checking=all to Fedora 14 x86.
2141 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2143 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2144 (overrun_check_realloc, overrun_check_free):
2145 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2146 That way, xmalloc returns a properly-aligned pointer even if
2147 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2148 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2149 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2150 into account when calculating the initial malloc maximum.
2151 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2152 Move here from alloc.c, so that charset.c can use it too.
2153 Properly align; the old code wasn't right for common 32-bit hosts
2154 when configured with --enable-checking=all.
2155 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2156 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2158 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2160 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2163 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2165 * xdisp.c (compute_display_string_end): If there's no display
2166 string at CHARPOS, return -1.
2168 * bidi.c (bidi_fetch_char): When compute_display_string_end
2169 returns a negative value, treat the character as a normal
2170 character not covered by a display string. (Bug#9624)
2172 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2174 * lread.c (Fread_from_string): Fix typo in docstring.
2176 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2178 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2179 newline, reseat the iterator instead of bidi-iterating there one
2180 character at a time. (Bug#9610)
2181 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2182 TO_CHARPOS if the bidi iterator is at base embedding level.
2184 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2186 * lread.c (readevalloop): Use correct code for NBSP.
2187 (read1): Likewise. (Bug#9608)
2189 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2191 * dbusbind.c (Fdbus_register_signal): When service is not
2192 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2194 2011-09-25 Glenn Morris <rgm@gnu.org>
2196 * buffer.c (truncate-lines): Doc fix.
2198 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2200 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2201 (Fset_window_next_buffers): Doc fix.
2203 2011-09-24 Glenn Morris <rgm@gnu.org>
2205 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2207 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2209 Fix minor problems found by static checking.
2210 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2211 * indent.c (Fvertical_motion): Fix == vs = typo.
2213 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2215 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2216 Default value is now t. Doc fix.
2218 * indent.c (Fvertical_motion): Compute and apply the overshoot
2219 logic when moving up, not only when moving down. Fix the
2220 confusing name and values of the it_overshoot_expected variable;
2221 logic changes accordingly. (Bug#9254) (Bug#9549)
2223 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2224 CHARPOS is covered by a display string which includes newlines.
2225 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2226 is covered by a display string with embedded newlines.
2228 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2230 * dbusbind.c (Fdbus_register_signal): Add match rule to
2231 Vdbus_registered_objects_table. (Bug#9581)
2232 (Fdbus_register_method, Vdbus_registered_objects_table):
2235 2011-09-24 Jim Meyering <meyering@redhat.com>
2237 do not ignore write error for any output size
2238 The previous change was incomplete.
2239 While it makes emacs --batch detect the vast majority of stdout
2240 write failures, errors were still ignored whenever the output size is
2241 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2242 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2243 && echo FAIL: ignored write error
2244 FAIL: ignored write error
2245 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2246 && echo FAIL: ignored write error
2247 FAIL: ignored write error
2248 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2250 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2252 * emacs.c (Fkill_emacs): In noninteractive mode exit
2253 non-successfully if a write error occurred on stdout. (Bug#9574)
2255 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2257 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2260 * dispextern.h (struct it): Update the comment documenting what
2263 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2265 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2266 a display string, extend search for cursor position to end of row.
2267 (find_row_edges): If the row ends in a newline from a display
2268 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2269 Handle the case of a display string with multiple newlines.
2270 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2271 non-empty line. Fixes confusing cursor motion with arrow keys at
2272 the beginning of a line that starts with whitespace.
2274 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2276 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2279 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2281 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2284 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2286 * xdisp.c (display_line): Record maximum and minimum buffer
2287 positions even if no glyphs were produced (e.g., by a zero-width
2288 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2289 buffer positions that will be removed from the glyph row because
2291 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2292 column is beyond frame width: don't subtract 1 "pixel" when
2293 computing width of the stretch.
2294 (reseat_at_next_visible_line_start): Undo the change made on
2295 2011-09-17 that saved paragraph information and restored it after
2296 the call to `reseat'. (Bug#9545)
2298 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2300 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2301 and turn window cursor on if cleared (Bug#9415).
2303 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2305 * search.c (boyer_moore): Take unibyte characters from pattern
2306 literally. (Bug#9458)
2308 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2310 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2312 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2314 Fix minor problem found by static checking.
2315 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2316 initialized, to pacify gcc -Wuninitialized.
2318 * fileio.c: Report proper errno when syscall falls.
2319 (Finsert_file_contents): Save and restore errno,
2320 so that report_file_error outputs the correct diagnostic.
2321 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2323 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2325 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2327 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2329 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2330 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2332 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2334 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2335 about the current paragraph and restore it after the call to reseat.
2337 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2338 (bidi_find_paragraph_start): Search back for paragraph beginning
2339 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2340 (bidi_move_to_visually_next): Only trigger paragraph-related
2341 computations when the last character is a newline or at EOB, not
2342 just any NEUTRAL_B. (Bug#9470)
2344 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2345 truncated lines if point is covered by a display string. (Bug#9524)
2347 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2349 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2350 (cons_to_x_long): New function.
2351 (lisp_data_to_selection_data): Use it. Correct the test for
2352 short-versus-long data; it was negated. Break out of vector
2353 loop, for efficiency, when a long datum is discovered.
2355 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2357 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2359 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2361 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2362 GCC PR/17406) by declaring this function with external scope.
2364 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2366 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2367 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2369 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2371 * editfns.c (Fformat): Correctly handle text properties on "%%".
2373 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2375 * xterm.c (x_draw_composite_glyph_string_foreground):
2376 * w32term.c (x_draw_composite_glyph_string_foreground):
2377 * term.c (encode_terminal_code):
2378 * composite.c (composition_update_it, get_composition_id):
2379 * xdisp.c (get_next_display_element)
2380 (fill_composite_glyph_string): Add comments about special meaning
2381 of TAB characters in a composition.
2383 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2385 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2386 This occurs when processing a multibyte format.
2387 Problem reported by Wolfgang Jenker.
2389 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2391 * xdisp.c (try_cursor_movement): Only check for exact match if
2392 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2394 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2396 Remove unused external symbols.
2397 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2398 * xdisp.c (calc_pixel_width_or_height): Now static.
2399 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2400 * indent.c (check_display_width):
2401 * w32term.c: Fix comment to match code.
2402 * xterm.c, xterm.h (x_catching_errors): Remove.
2404 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2406 * xselect.c: Use signed conversions more consistently (Bug#9498).
2407 (selection_data_to_lisp_data): Assume incoming selection data are
2408 signed integers, not unsigned. This is to be consistent with
2409 outgoing selection data, which was modified to use signed integers
2410 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2411 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2412 expects long, not unsigned long.
2414 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2416 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2417 computation of loop end. Reported by Johan Bockgård
2420 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2422 * frame.c (Fother_visible_frames_p): Function deleted.
2424 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2426 * indent.c (compute_motion): Process display vector front to back
2427 rather than the other way around. (Bug#2496)
2429 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2431 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2433 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2435 * minibuf.c (Fread_from_minibuffer): Doc fix.
2437 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2439 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2440 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2442 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2444 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2445 value for non-existent files.
2447 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2449 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2450 set its "size" to -1. This will set the modtime_size field of
2451 the corresponding buffer to -1, which is what
2452 verify-visited-file-modtime expects for files that do not exist.
2455 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2457 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2459 * lisp.h: ... from here. push_key_description is no longer
2460 defined in keyboard.c, so its declaration should not be in
2461 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2462 logically belongs with push_key_description.
2464 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2466 * buffer.h: Include <sys/types.h> instead of <time.h>.
2467 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2468 Problem reported by Herbert J. Skuhra.
2470 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2472 * xml.c (parse_region): Make the parsing work for
2473 non-comment-starting XML files again (bug#9144).
2475 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2477 * image.c (gif_load): Fix calculation of bottom and right corner.
2480 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2482 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2483 redisplay in small windows.
2485 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2487 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2489 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2491 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2492 Operate on live windows only.
2494 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2496 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2498 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2500 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2501 only under bidi iteration.
2503 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2505 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2507 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2509 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2510 Without this fix, the command to link temacs failed due to an
2511 undefined symbol __builtin_isnan. This is because
2512 /usr/include/iso/math_c99.h #defines isnan(x) to
2513 __builtin_isnan(x), but the bundled gcc, which identifies itself
2514 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2516 * floatfns.c (isnan): #undef, and then #define to a clone of
2518 (Fisnan): Always define, since it's always available now.
2519 (syms_of_floatfns): Always define isnan at the Lisp level.
2521 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2523 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2525 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2527 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2528 The previous code assumed that file offsets (off_t values) fit in
2529 EMACS_INT variables, which is not true on typical 32-bit hosts.
2530 The code messed up by falsely reporting buffer overflow in cases
2531 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2532 when "big" contains more than 2**29 bytes, even though this
2533 inserts just one byte and does not overflow the buffer.
2534 (Finsert_file_contents): Store file offsets as off_t
2535 values, not as EMACS_INT values. Check for overflow when
2536 converting between EMACS_INT and off_t. When checking for
2537 buffer overflow or for overlap, take the offsets into account.
2538 Don't use EMACS_INT for small values where int suffices.
2539 When checking for overlap, fix a typo: ZV was used where
2540 ZV_BYTE was intended.
2541 (Fwrite_region): Don't assume off_t fits into 'long'.
2542 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2544 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2546 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2548 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2550 sprintf-related integer and memory overflow issues (Bug#9412).
2552 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2553 (esprintf, exprintf, evxprintf): New functions.
2554 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2555 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2556 (modify_event_symbol): Do not assume that the length of
2557 name_alist_or_stem is safe to alloca and fits in int.
2558 (Fexecute_extended_command): Likewise for function name and binding.
2559 (Frecursion_depth): Wrap around reliably on integer overflow.
2560 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2561 since some callers pass EMACS_INT values.
2562 (Fsingle_key_description): Don't crash if symbol name contains more
2563 than MAX_ALLOCA bytes.
2564 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2565 (get_minibuffer): Arg is now EMACS_INT, not int.
2566 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2567 (esprintf, exprintf, evxprintf): New decls.
2568 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2570 * dbusbind.c (signature_cat): New function.
2571 (xd_signature, Fdbus_register_signal):
2572 Do not overrun buffer; instead, report string overflow.
2574 * dispnew.c (add_window_display_history): Don't overrun buffer.
2575 Truncate instead; this is OK since it's just a log.
2577 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2578 even if the time zone offset is outlandishly large.
2579 Don't mishandle offset == INT_MIN.
2581 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2582 when creating daemon; the previous buffer-overflow check was incorrect.
2584 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2585 which has the guts of the old verror function.
2587 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2588 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2590 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2591 (font_unparse_xlfd): Don't blindly alloca long strings.
2592 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2593 fits in int, when using sprintf. Use single snprintf to count
2594 length of string rather than counting it via multiple sprintfs;
2595 that's simpler and more reliable.
2596 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2597 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2598 sprintf, in case result does not fit in int.
2600 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2601 (fontset_from_font): Print it.
2603 * frame.c (tty_frame_count): Now printmax_t, not int.
2604 (make_terminal_frame, set_term_frame_name): Print it.
2605 (x_report_frame_params): In X, window IDs are unsigned long,
2606 not signed long, so print them as unsigned.
2607 (validate_x_resource_name): Check for implausibly long names,
2608 and don't assume name length fits in 'int'.
2609 (x_get_resource_string): Don't blindly alloca invocation name;
2610 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2613 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2614 (xg_check_special_colors, xg_set_geometry):
2615 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2617 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2618 Use esprintf, not sprintf, in case result does not fit in int.
2620 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2621 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2622 it as a large positive number.
2623 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2624 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2626 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2627 in case result does not fit in int.
2629 * print.c (float_to_string): Detect width overflow more reliably.
2630 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2631 buffer overrun. Don't assume list length fits in 'int'. Treat
2632 print length of 0 as 0, not as infinity; to be consistent with other
2633 uses of print length in this function. Don't overflow print length
2634 index. Don't assume hash table size fits in 'long', or that
2635 vectorlike size fits in 'unsigned long'.
2637 * process.c (make_process): Use printmax_t, not int, to format
2638 process-name gensyms.
2640 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2642 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2643 to avoid potential buffer overrun.
2645 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2646 if X resource line is longer than 512 bytes.
2648 * xfns.c (x_window): Make sprintf buffer a bit bigger
2649 to avoid potential buffer overrun.
2651 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2653 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2655 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2657 Integer overflow fixes for scrolling, etc.
2658 Without these, Emacs silently mishandles large integers sometimes.
2659 For example, "C-u 4294967297 M-x recenter" was treated as if
2660 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2662 * xdisp.c (try_window_id): Check Emacs fixnum range before
2663 converting to 'int'.
2665 * window.c (window_scroll_line_based, Frecenter):
2666 Check that an Emacs fixnum is in range before assigning it to 'int'.
2667 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2668 values converted from Emacs fixnums.
2669 (Frecenter): Don't wrap around a line count if it is out of 'int'
2670 range; instead, treat it as an extreme value.
2671 (Fset_window_configuration, compare_window_configurations):
2672 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2674 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2675 that can exceed INT_MAX. Check that EMACS_INT value is in range
2676 before assigning it to the (possibly-narrower) index.
2677 (match_limit): Don't assume that a fixnum can fit in 'int'.
2679 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2682 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2683 (Fvertical_motion): Don't wrap around LINES values that don't fit
2684 in 'int'. Instead, treat them as extreme values. This is good
2685 enough for windows, which can't have more than INT_MAX lines anyway.
2687 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2689 * Require libxml/parser.h to avoid compilation warning.
2691 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2693 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2694 since this reportedly can destroy thread storage.
2696 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2698 * syntax.c (find_defun_start): Update all cache variables if
2699 exiting early (Bug#9401).
2701 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2703 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2705 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2706 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2707 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2709 * term.c (tty_append_glyph): New function.
2710 (produce_stretch_glyph): Static function and its prototype deleted.
2712 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2715 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2717 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2718 when checking :margin (Bug#9390).
2719 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2720 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2721 so that the name doesn't mislead. All uses changed.
2723 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2725 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2728 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2730 * xdisp.c (move_it_to): Don't bail out early when reaching
2731 position beyond to_charpos, if we are scanning backwards.
2732 (move_it_vertically_backward): When DY == 0, make sure we get to
2733 the first character in the line after the newline.
2735 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2737 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2738 (ccl_driver): Do not generate an out-of-range pointer.
2739 (Fccl_execute_on_string): Remove unnecessary check for
2740 integer overflow, noted by Stefan Monnier in
2741 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2742 Remove a FIXME that didn't need fixing.
2743 Simplify the newly-introduced buffer reallocation code.
2745 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2747 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2749 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2751 Integer and memory overflow issues (Bug#9196).
2753 * doc.c (get_doc_string): Rework so that
2754 get_doc_string_buffer_size is the actual buffer size, rather than
2755 being 1 less than the actual buffer size; this makes xpalloc more
2758 * image.c (x_allocate_bitmap_record, cache_image):
2759 * xselect.c (Fx_register_dnd_atom):
2760 Simplify previous changes by using xpalloc.
2762 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2763 since either will do and ptrdiff_t is convenient with xpalloc.
2765 * charset.c (charset_table_size)
2766 (struct charset_sort_data.priority): Now ptrdiff_t.
2767 (charset_compare): Don't overflow if priorities differ greatly.
2768 (Fsort_charsets): Don't assume list length fits in int.
2769 Check for size-calculation overflow when allocating sort data.
2770 (syms_of_charset): Allocate an initial charset table that is
2771 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2773 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2775 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2776 The actual value is always <= INT_MAX, and leaving it unsigned made
2777 overflow checking harder.
2779 * dispextern.h (struct glyph_matrix.rows_allocated)
2780 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2781 with xpalloc. The values are still always <= INT_MAX.
2783 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2785 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2786 (SAFE_NALLOCA): New macro.
2788 * region-cache.c (struct boundary.pos, find_cache_boundary)
2789 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2790 (set_cache_region, invalidate_region_cache)
2791 (revalidate_region_cache, know_region_cache, region_cache_forward)
2792 (region_cache_backward, pp_cache):
2793 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2794 so that ptrdiff_t * can be passed to xpalloc.
2795 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2796 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2797 (pp_cache): Don't assume cache_len fits in int.
2798 * region-cache.h: Adjust extern decls to match.
2800 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2801 EMACS_INT, since either will do, for xpalloc.
2803 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2804 (xnmalloc, xnrealloc, xpalloc): New functions.
2806 * bidi.c (bidi_shelve_header_size): New constant.
2807 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2808 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2810 * bidi.c (bidi_cache_shrink):
2811 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2813 Don't update size of array until after memory allocation succeeds,
2814 because xmalloc/xrealloc may not return.
2815 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2816 now that we have proper integer overflow checking.
2817 (record_overlay_string, overlay_strings): Catch overflows when
2818 calculating size of overlay_str_buf.
2820 * callproc.c (Fcall_process): Check for size overflow when
2821 calculating size of args2.
2822 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2823 Normally we prefer signed values, but sticking with ptrdiff_t would
2824 require adding more-complicated checks.
2826 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2827 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2828 Redo buffer-overflow calculations to avoid integer overflow.
2829 Add a FIXME comment where memory seems to be over-allocated.
2831 * character.c (Fstring): Check for size-calculation overflow.
2833 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2834 unnecessary integer overflow. Check for size overflow.
2835 (encode_coding_object): Don't update size until xmalloc succeeds.
2837 * composite.c (get_composition_id): Check for overflow in glyph
2838 length calculations.
2840 Integer and memory overflow fixes for display code.
2841 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2842 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2843 (scrolling_window): Check for overflow in size calculations.
2844 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2845 Don't assume glyph table len fits in int.
2846 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2847 (row_table_size): Now ptrdiff_t, not int.
2848 (scrolling_window): Avoid overflow in size calculations.
2849 Don't update size until allocation succeeds.
2850 * fns.c (concat): Check for overflow in size calculations.
2851 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2852 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2853 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2855 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2856 (get_doc_string): Check for size calculation overflow.
2857 Don't update size until allocation succeeds.
2858 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2859 EMACS_INT, where ptrdiff_t will do.
2860 (Fsubstitute_command_keys): Check for string overflow.
2862 * editfns.c (set_time_zone_rule): Don't assume environment length
2864 (message_length): Now ptrdiff_t, not int.
2865 (Fmessage_box): Don't update size until allocation succeeds.
2866 Don't assume message length fits in int.
2867 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2869 * emacs.c (main): Do not reallocate argv, since there is a null at
2870 the end that can be overwritten, and this way there's no need to
2871 worry about size-calculation overflow.
2872 (sort_args): Check for size-calculation overflow.
2874 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2876 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2878 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2879 (x_set_scroll_bar_width, x_figure_window_size):
2880 Check for integer overflow.
2881 (x_set_alpha): Do not assume XINT fits in int.
2883 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2884 This is for the members text_lines, text_cols, total_lines, total_cols,
2885 where the system imposes an 'int' limit.
2887 * fringe.c (Fdefine_fringe_bitmap):
2888 Don't update size until alloc works.
2890 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2891 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2893 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2894 Check for size-calculation overflow.
2895 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2896 do, as we prefer signed integers.
2897 (id_to_widget.max_size, id_to_widget.used)
2898 (xg_store_widget_in_map, xg_remove_widget_from_map)
2899 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2900 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2901 Use and return ptrdiff_t, not int.
2902 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2903 * gtkutil.h: Change prototypes to match the above.
2905 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2906 are duplicate now that they've been promoted to lisp.h.
2907 (x_allocate_bitmap_record, x_alloc_image_color)
2908 (make_image_cache, cache_image, xpm_load):
2909 Don't update size until alloc is done.
2910 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2912 Check for size calculation overflow.
2913 (ct_colors_allocated_max): New constant.
2914 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2917 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2918 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2919 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2920 Use ptrdiff_t, not int, to count maps.
2921 (read_char_minibuf_menu_prompt): Check for overflow in size
2922 calculations. Don't update size until allocation succeeds.
2923 Redo calculations to avoid overflow.
2924 * keyboard.h: Change prototypes to match the above.
2926 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2928 (current_minor_maps): Check for size calculation overflow.
2929 * keymap.h: Change prototypes to match the above.
2931 * lread.c (read1, init_obarray): Don't update size until alloc done.
2933 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2934 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2936 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2937 Now ptrdiff_t, not int.
2938 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2939 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2941 * process.c (Fnetwork_interface_list): Check for overflow
2942 in size calculation.
2944 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2946 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2947 overflow. Don't bother calling xmalloc when xrealloc will do.
2949 * search.c (Freplace_match): Check for size calculation overflow.
2950 (Fset_match_data): Don't assume list lengths fit in 'int'.
2952 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2953 for command line length. Do not attempt to address one before the
2954 beginning of an array, as that's not portable.
2956 * term.c (max_frame_lines): Remove; unused.
2957 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2959 (encode_terminal_code, calculate_costs): Check for size
2960 calculation overflow.
2961 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2962 table lengths and related sizes. Don't update size until alloc
2963 done. Redo calculations to avoid overflow.
2964 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2966 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2967 subtracting pointers.
2968 (gobble_line): Check for overflow more carefully. Don't update size
2971 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2972 Don't update size until alloc done.
2973 Redo size calculations to avoid overflow.
2974 Check for size calculation overflow.
2975 (main) [DEBUG]: Fix typo in invoking tparam1.
2977 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2978 Use ptrdiff_t, not int, for sizes.
2979 (store_mode_line_noprop_char): Don't update size until alloc done.
2981 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2982 Use ptrdiff_t, not int, for sizes.
2983 (Finternal_make_lisp_face, cache_face):
2984 Check for size calculation overflow.
2985 (cache_face): Treat size calculation overflows as if they were
2986 memory exhaustion (the usual treatment), rather than aborting.
2988 * xfns.c (x_encode_text, x_set_name_internal)
2989 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2990 sizes, since they can exceed INT_MAX in size. Check for size
2991 calculation overflow.
2993 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2994 (xg_select): Check for size calculation overflow.
2995 Don't update size until alloc done.
2997 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2998 as sprintf is limited to int lengths.
3000 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3001 (X_LONG_MIN): New macros.
3002 Use them to make the following changes clearer.
3003 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3004 This change doesn't affect the value now, but it may help remind
3005 future maintainers not to raise the value too much later.
3006 (SELECTION_QUANTUM): Remove, replacing with ...
3007 (selection_quantum): ... new function, which avoids overflow.
3009 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3010 assumption that selection length fits in 'int'.
3011 (x_reply_selection_request, x_handle_selection_request)
3012 (x_get_window_property, receive_incremental_selection)
3013 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3014 (lisp_data_to_selection_data, clean_local_selection_data):
3015 Use ptrdiff_t, not int, to record length of selection.
3016 (x_reply_selection_request, x_get_window_property)
3017 (receive_incremental_selection, x_property_data_to_lisp):
3018 Redo calculations to avoid overflow.
3019 (x_reply_selection_request): When sending hint, ceiling it at
3020 X_LONG_MAX rather than relying on wraparound overflow to send
3022 (x_get_window_property, receive_incremental_selection)
3023 (lisp_data_to_selection_data, x_property_data_to_lisp):
3024 Check for size-calculation overflow.
3025 (x_get_window_property, receive_incremental_selection)
3026 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3027 Don't store size until memory allocation succeeds.
3028 (x_get_window_property): Plug memory leak on memory exhaustion.
3029 Don't double-block input; malloc is safe here. Don't assume 2**34
3030 - 4 fits in unsigned long. Add an xassert to check
3031 XGetWindowProperty overflow. Be more careful about overflow
3032 calculations, and distinguish size from memory overflow better.
3033 (receive_incremental_selection): When tracing, don't assume
3034 unsigned int is less than INT_MAX.
3035 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3036 harmful) conversions of unsigned short to int.
3037 (lisp_data_to_selection_data): Don't assume that integers
3038 in the range -65535 through -1 fit in an X unsigned short.
3039 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3040 result parameters unless successful. Rely on cons_to_unsigned
3041 to report problems with elements; the old code wasn't right anyway.
3042 (x_check_property_data): Check for int overflow; we cannot use
3043 a wider type due to X limits.
3044 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3046 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3048 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3049 (x_term_init): Check for size calculation overflow.
3050 (x_color_cells): Don't store size until memory allocation succeeds.
3051 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3052 Don't assume alloca size is less than MAX_ALLOCA.
3053 (x_term_init): Don't assume length fits in int (sprintf is limited
3056 Use ptrdiff_t for composition IDs.
3057 * character.c (lisp_string_width):
3058 * composite.c (composition_table_size, n_compositions)
3059 (get_composition_id, composition_gstring_from_id):
3060 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3061 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3062 * window.c (Frecenter):
3063 Use ptrdiff_t, not int, for composition IDs.
3064 * composite.c (get_composition_id): Check for integer overflow.
3065 * composite.h: Adjust prototypes to match the above changes.
3067 Use ptrdiff_t for hash table indexes.
3068 * category.c (hash_get_category_set):
3069 * ccl.c (ccl_driver):
3070 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3071 * coding.c (coding_system_charset_list, detect_coding_system):
3072 * coding.h (struct coding_system.id):
3073 * composite.c (get_composition_id, gstring_lookup_cache):
3074 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3075 * image.c (xpm_get_color_table_h):
3076 * lisp.h (hash_lookup, hash_put):
3077 * minibuf.c (Ftest_completion):
3078 Use ptrdiff_t for hash table indexes, not int (which is too
3079 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3080 32-bit --with-wide-int hosts).
3082 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3083 Add a FIXME comment about memory leaks.
3084 (syms_of_charset): Don't assume xmalloc returns.
3086 Don't assume that stated character widths fit in int.
3087 * character.c (Fchar_width, c_string_width, lisp_string_width):
3088 * character.h (CHAR_WIDTH):
3089 * indent.c (MULTIBYTE_BYTES_WIDTH):
3090 Use sanitize_char_width to avoid undefined and/or bad behavior
3091 with outlandish widths.
3092 * character.h (sanitize_tab_width): Rename from sanitize_width,
3093 now that we have two such functions. All uses changed.
3094 (sanitize_char_width): New inline function.
3096 Don't assume that tab-width fits in int.
3097 * character.h (sanitize_width): New inline function.
3098 (SANE_TAB_WIDTH): New macro.
3099 (ASCII_CHAR_WIDTH): Use it.
3100 * indent.c (sane_tab_width): Remove. All uses replaced by
3101 SANE_TAB_WIDTH (current_buffer).
3102 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3104 * fileio.c: Integer overflow issues with file modes.
3105 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3107 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3108 Remove unreachable code.
3109 (read_hex, load_charset_map_from_file): Check for integer overflow.
3111 * xterm.c: Don't go over XClientMessageEvent limit.
3112 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3113 (x_send_scroll_bar_event): Likewise. Check that the size does not
3114 exceed limits imposed by XClientMessageEvent, as well as the usual
3115 ptrdiff_t and size_t limits.
3117 * keyboard.c: Overflow, signedness and related fixes.
3118 (make_lispy_movement): Use same integer type in forward decl
3119 that is used in the definition.
3120 (read_key_sequence, keyremap_step):
3121 Change bufsize argument back to int, undoing my 2011-03-30 change.
3122 We prefer signed types, and int is wide enough here.
3123 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3124 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3125 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3126 length, not size_t. Use ptrdiff_t for index, not int.
3127 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3128 possibility of integer overflow.
3130 Overflow, signedness and related fixes for images.
3132 * dispextern.h (struct it.stack[0].u.image.image_id)
3133 (struct_it.image_id, struct image.id, struct image_cache.size)
3134 (struct image_cache.used, struct image_cache.ref_count):
3135 * gtkutil.c (update_frame_tool_bar):
3136 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3137 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3138 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3139 * nsmenu.m (update_frame_tool_bar):
3140 * xdisp.c (calc_pixel_width_or_height):
3141 * xfns.c (image_cache_refcount):
3142 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3143 on typical 64-bit hosts.
3145 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3146 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3147 Omit unnecessary casts to int.
3148 (parse_image_spec): Check that integers fall into 'int' range
3149 when the callers expect that.
3150 (image_ascent): Redo ascent calculation to avoid int overflow.
3151 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3152 (lookup_image): Remove unnecessary tests.
3153 (xbm_image_p): Locals are now of int, not EMACS_INT,
3154 since parse_image_check makes sure they fit into int.
3155 (png_load, gif_load, svg_load_image):
3156 Prefer int to unsigned where either will do.
3157 (tiff_handler): New function, combining the cores of the
3158 old tiff_error_handler and tiff_warning_handler.
3159 This function is rewritten to use vsnprintf and thereby avoid
3160 stack buffer overflows. It uses only the features of vsnprintf
3161 that are common to both POSIX and native Microsoft.
3162 (tiff_error_handler, tiff_warning_handler): Use it.
3163 (tiff_load, gif_load, imagemagick_load_image):
3164 Don't assume :index value fits in 'int'.
3165 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3166 (imagemagick_load_image): Check that crop parameters fit into
3167 the integer types that MagickCropImage accepts. Don't assume
3168 Vimagemagick_render_type has a nonnegative value. Don't assume
3169 size_t fits in 'long'.
3170 (gs_load): Use printmax_t to print the widest integers possible.
3171 Check for integer overflow when computing image height and width.
3173 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3175 * xdisp.c (redisplay_window): Don't force window start if point
3176 will be invisible in the resulting window. (Bug#9324)
3178 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3180 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3181 the display spec is of the form `(space ...)'.
3182 (handle_display_spec): Return the value returned by
3183 handle_single_display_spec, not just 1 or zero.
3184 (handle_single_display_spec): If the display spec is of the form
3185 `(space ...)', and specifies display in the text area, return 2
3187 (try_cursor_movement): Check for the need to scroll more
3188 accurately, and prefer exact match for point under bidi.
3189 Don't advance `row' beyond the last row of the window.
3191 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3192 into disp_prop; all users changed.
3194 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3195 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3196 for the text covered by the display property.
3198 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3200 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3201 Change return value to nil.
3202 (Frecord_buffer): Delete unused function.
3204 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3206 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3207 buffers, return left-to-right.
3208 (set_cursor_from_row): Consider candidate row a win if its glyph
3209 represents a newline and point is on that newline. Fixes cursor
3210 positioning on the newline at EOL of R2L text within L2R
3211 paragraph, and vice versa.
3212 (try_cursor_movement): Check continued rows, in addition to
3213 continuation rows. Fixes unwarranted scroll when point enters a
3214 continued line of R2L text within an L2R paragraph, or vice versa.
3215 (cursor_row_p): Consider the case of point being equal to
3216 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3217 from the end of a short line to the beginning of a continued line
3218 of R2L text within L2R paragraph.
3219 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3220 composed characters.
3222 * bidi.c (bidi_check_type): Use xassert.
3223 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3226 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3228 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3231 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3233 * nsfont.m (ns_otf_to_script): Fix typo.
3235 2011-08-22 Kenichi Handa <handa@m17n.org>
3237 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3238 extra slot even if the purpose is char-code-property-table.
3240 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3242 * xdisp.c (redisplay_window): When computing centering_position,
3243 account for the height of the header line. (Bug#8874)
3245 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3246 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3247 candidate is selected by the mouse, and that candidate has a
3248 composed character under the mouse.
3250 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3251 coordinates reported by pos-visible-in-window-p for a composed
3252 character in column zero.
3254 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3256 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3258 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3260 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3261 consider it a hit if to_charpos is anywhere in the range of the
3262 composed buffer positions.
3264 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3266 * image.c (gif_load): Don't assume that each subimage has the same
3267 dimensions as the base image. Handle disposal method that is
3268 "undefined" by the gif spec (Bug#9335).
3270 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3272 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3273 (Fcondition_case): Document `debug' symbol in error handler.
3275 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3277 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3278 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3279 from an Org mode buffer to a Speedbar frame.
3281 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3282 a composition, take its buffer position from IT->cmp_it.charpos.
3283 Fixes cursor positioning at the beginning of a line that begins
3284 with a composed character.
3286 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3288 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3289 character bidirectional type, use STRONG_L instead. Fixes crashes
3290 in a buffer produced by `describe-categories'.
3292 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3293 members before the level stack, so they would be saved and
3294 restored when copying iterator state. Fixes incorrect reordering
3295 around TABs covered by display properties.
3297 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3299 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3301 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3303 * eval.c (internal_condition_case, internal_condition_case_1)
3304 (internal_condition_case_2, internal_condition_case_n):
3305 Remove unnecessary aborts (Bug#9081).
3307 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3309 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3310 has no `load' handler, try opening the file locally. (Bug#9311)
3312 2011-08-16 Ken Brown <kbrown@cornell.edu>
3314 * gmalloc.c: Expand comment.
3316 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3318 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3319 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3321 2011-08-16 Ken Brown <kbrown@cornell.edu>
3323 Fix memory allocation problems in Cygwin build (Bug#9273).
3325 * unexcw.c ( __malloc_initialized): Declare external variable.
3326 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3328 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3330 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3332 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3334 [CYGWIN] (special_realloc): New function.
3335 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3336 requests to realloc storage in the static heap.
3338 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3340 * bidi.c (bidi_initialize): Remove unused local.
3342 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3345 * biditype.h: Remove file.
3346 * makefile.w32-in ($(BLD)/bidi.$(O)):
3347 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3349 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3351 * chartab.c: Improve commentary for the uniprop_table API.
3353 * bidi.c (bidi_paragraph_init): Support zero value of
3354 bidi_ignore_explicit_marks_for_paragraph_level.
3355 (bidi_initialize): Use uniprop_table instead of including
3356 biditype.h and bidimirror.h.
3358 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3359 coordinates of the iterator when restoring from ppos_it.
3362 2011-08-14 Kenichi Handa <handa@m17n.org>
3364 * process.c (create_process): Call setup_process_coding_systems
3365 after the pid of the process is set to -1 (Bug#8162).
3367 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3369 * xdisp.c (move_it_in_display_line_to): Don't invoke
3370 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3371 ppos_it. Fixes vertical cursor motion when line beginning is
3372 covered by an image. (Bug#9296)
3374 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3376 * nsterm.h (ns_run_ascript): Declare.
3377 (NSAPP_DATA2_RUNASSCRIPT): Define.
3379 * nsfns.m (as_script, as_result, as_status): New static variables.
3380 (ns_run_ascript): New function.
3381 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3382 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3383 the event loop. Get status from as_status (Bug#7276).
3385 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3386 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3387 the event loop (Bug#7276).
3389 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3391 * gnutls.c (QCgnutls_bootprop_priority)
3392 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3393 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3394 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3395 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3396 (QCgnutls_bootprop_verify_hostname_error)
3397 (QCgnutls_bootprop_callbacks_verify): Rename from
3398 Qgnutls_bootprop_..., all uses changed.
3400 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3403 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3405 * xfaces.c (Qframe_set_background_mode): Now static.
3406 * dispextern.h (Qframe_set_background_mode): Remove decl.
3408 * process.c (Fnetwork_interface_info): Declare local only if needed.
3410 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3412 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3413 (Fnetwork_interface_list): Allocate in increments of bytes instead
3414 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3415 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3417 (struct ifflag_def): notrailers is smart on OSX.
3418 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3419 Get hardware address with getifaddrs if available.
3421 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3423 * xdisp.c (iterate_out_of_display_property): xassert that
3424 IT->position is set to within IT->object's boundaries. Break from
3425 the loop as soon as EOB is reached; avoids infloops in redisplay
3426 when IT->position is set up wrongly due to some bug.
3427 Set IT->current to match the bidi iterator unconditionally.
3428 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3429 entry. Force push_it to save on the stack the current
3430 buffer/string position, to be restored by pop_it. Fix flags in
3431 the iterator structure wrt the object coming from a display
3432 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3433 properties. (Bug#9284)
3435 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3437 * fontset.c (fontset_get_font_group): Add proper type checks.
3440 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3442 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3443 and LC_VERSION_MIN_MACOSX.
3444 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3445 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3447 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3449 * xdisp.c (forward_to_next_line_start): Allow to use the
3450 no-display-properties-and-no-overlays under bidi display.
3451 Set disp_pos in the bidi iterator to avoid searches for display
3452 properties and overlays.
3454 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3456 * editfns.c (Fset_time_zone_rule): Document relationship with the
3459 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3460 the font entity extracted from the cache (Bug#8109).
3462 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3464 * composite.c (autocmp_chars): Don't reset point. That is done by
3465 restore_point_unwind (Bug#5984).
3467 2011-08-07 Juri Linkov <juri@jurta.org>
3469 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3470 to show the arg `TIME' instead of `TIMEVAL'.
3472 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3474 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3475 display property strides EOL and includes a newline, as in
3476 longlines-mode. (Bug#9254)
3477 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3478 word-wrap under bidirectional display. (Bug#9224)
3480 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3481 is non-zero, even if the data buffer is NULL. Fixes a crash in
3482 vertical-motion with longlines-mode. (Bug#9254)
3484 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3486 * bidi.c <bidi_cache_total_alloc>: Now static.
3487 (bidi_initialize): Initialize bidi_cache_total_alloc.
3489 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3492 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3493 amount allocated this far in `bidi_cache_total_alloc'.
3494 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3495 non-zero, only free the data buffer without restoring the cache
3496 contents. All callers changed.
3498 * dispextern.h (bidi_unshelve_cache): Update prototype.
3500 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3501 (move_it_in_display_line, move_it_to)
3502 (move_it_vertically_backward, move_it_by_lines): Replace the call
3503 to xfree to an equivalent call to bidi_unshelve_cache.
3504 (move_it_in_display_line_to): Fix logic of returning
3505 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3507 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3509 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3510 came from a string character with a `cursor' property. (Bug#9229)
3512 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3514 * Makefile.in (LIB_PTHREAD): New variable.
3515 (LIBES): Add LIB_PTHREAD (Bug#9216).
3517 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3518 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3520 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3522 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3524 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3526 * xterm.c (x_find_topmost_parent): New function.
3527 (x_set_frame_alpha): Find topmost parent window with
3528 x_find_topmost_parent and set the property there also (bug#9181).
3529 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3531 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3533 * callproc.c (Fcall_process): Avoid vfork clobbering
3534 the local vars buffer, coding_systems, current_dir.
3536 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3538 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3540 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3542 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3543 so that it is not optimized away.
3545 * xdisp.c (compute_display_string_pos): Remove unused local.
3547 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3549 Fix slow cursor motion and scrolling in large buffers with
3550 selective display, like Org Mode buffers. (Bug#9218)
3552 * dispextern.h (struct bidi_it): New member disp_prop_p.
3554 * xdisp.c: Remove one-slot cache of display string positions.
3555 (compute_display_string_pos): Accept an additional argument
3556 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3557 for a display string or property. If found, set DISP_PROP_P
3560 * bidi.c (bidi_fetch_char): Accept an additional argument
3561 DISP_PROP_P, and pass it to compute_display_string_pos.
3562 Only handle text covered by a display string if DISP_PROP_P is returned
3563 non-zero. All callers of bidi_fetch_char changed.
3565 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3567 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3569 2010-12-03 Don March <don@ohspite.net>
3571 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3572 last character M-[char] is translated to ESC [char] (bug#7541).
3574 2011-08-02 Kenichi Handa <handa@m17n.org>
3576 * lisp.h (uniprop_table): Extern it.
3578 * chartab.c (uniprop_table): Make it non-static.
3580 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3582 * xdisp.c (forward_to_next_line_start): Accept additional argument
3583 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3585 (reseat_at_next_visible_line_start): Use the bidi iterator state
3586 returned by forward_to_next_line_start to restore the state of
3587 it->bidi_it after backing up to previous newline. (Bug#9212)
3589 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3591 * regex.c (re_comp): Protoize.
3592 (re_exec): Fix return type.
3593 (regexec): Fix type of `ret'. (Bug#9203)
3595 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3597 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3598 This is needed if max-image-size is a floating-point number.
3600 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3602 * print.c (print_object): Print empty symbol as ##.
3604 * lread.c (read1): Read ## as empty symbol.
3606 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3608 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3609 setting frame foreground color (Bug#9175).
3610 (x_set_background_color): Likewise.
3612 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3613 contents (Bug#9176).
3614 (EmacsTooltip -init): Remove bezels and add shadows to
3617 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3618 or scroll bar (Bug#8470).
3620 * nsfont.m (nsfont_open): Remove assignment to voffset and
3621 unnecessary vars hshink, expand, hd, full_height, min_height.
3622 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3624 * nsterm.h (nsfont_info): Remove voffset field.
3626 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3628 Implement strike-through and overline on NextStep (Bug#8863).
3630 * nsfont.m (nsfont_open): Use underline position provided by font,
3631 instead of hard-coded value of 2.
3632 (nsfont_draw): Call ns_draw_text_decoration instead.
3634 * nsterm.h: Add declaration for ns_draw_text_decoration.
3636 * nsterm.m (ns_draw_text_decoration): New function for drawing
3637 underline, overline, and strike-through.
3638 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3639 ns_draw_text_decoration. Change treatment of cursor drawing to
3640 accommodate underlining, etc.
3642 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3644 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3647 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3649 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3650 Without this fix, if a signal arrives just after memory fills up,
3651 'malloc' might be invoked reentrantly.
3653 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3654 In other words, assume that every image size is allowed, on non-X
3655 hosts. This assumption is probably wrong, but it lets Emacs compile.
3657 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3659 * regex.c (re_iswctype): Convert return values to boolean.
3661 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3663 * xdisp.c (compute_display_string_pos): Don't use cached display
3664 string position if the buffer had its restriction changed.
3667 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3669 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3671 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3673 Integer signedness and overflow and related fixes. (Bug#9079)
3675 * bidi.c: Integer size and overflow fixes.
3676 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3677 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3678 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3679 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3680 (bidi_find_other_level_edge):
3681 Use ptrdiff_t instead of EMACS_INT where either will do.
3682 This works better on 32-bit hosts configured --with-wide-int.
3683 (bidi_cache_ensure_space): Check for size-calculation overflow.
3684 Use % rather than repeated addition, for better worst-case speed.
3685 Don't set bidi_cache_size until after xrealloc returns, because it
3687 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3688 (bidi_cache_ensure_space): Also check that the bidi cache size
3689 does not exceed that of the largest Lisp string or buffer. See Eli
3690 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3692 * alloc.c (__malloc_size_t): Remove.
3693 All uses replaced by size_t. See Andreas Schwab's note
3694 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3696 * image.c: Improve checking for integer overflow.
3697 (check_image_size): Assume that f is nonnull, since
3698 it is always nonnull in practice. This is one less thing to
3699 worry about when checking for integer overflow later.
3700 (x_check_image_size): New function, which checks for integer
3701 overflow issues inside X.
3702 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3703 This removes the need for a memory_full check.
3704 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3705 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3706 (xbm_read_bitmap_data): Change locals back to 'int', since
3707 their values must fit in 'int'.
3708 (xpm_load_image, png_load, tiff_load):
3709 Invoke x_create_x_image_and_pixmap earlier,
3710 to avoid much needless work if the image is too large.
3711 (tiff_load): Treat overly large images as if
3712 x_create_x_image_and_pixmap failed, not as malloc failures.
3713 (gs_load): Use x_check_image_size.
3715 * gtkutil.c: Omit integer casts.
3716 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3717 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3719 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3721 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3722 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3723 would wrongly return t on a 64-bit host.
3725 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3726 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3727 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3728 and therefore cause GCC to emit a bogus diagnostic in some cases.
3730 * image.c: Integer signedness and overflow and related fixes.
3731 This is not an exhaustive set of fixes, but it's time to
3732 record what I've got.
3733 (lookup_pixel_color, check_image_size): Remove redundant decls.
3734 (check_image_size): Don't assume that arbitrary EMACS_INT values
3735 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3736 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3737 (tiff_load, imagemagick_load_image):
3738 Check for overflow in size calculations.
3739 (x_create_x_image_and_pixmap): Remove unnecessary test for
3740 xmalloc returning NULL; that can't happen.
3741 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3742 (xpm_color_bucket): Use better integer hashing function.
3743 (xpm_cache_color): Don't possibly over-allocate memory.
3744 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3745 (gif_memory_source):
3746 Use ptrdiff_t, not int or size_t, to record sizes.
3747 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3748 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3749 either works, as we prefer signed integers.
3750 (tiff_read_from_memory, tiff_write_from_memory):
3751 Return tsize_t, not size_t, since that's what the TIFF API wants.
3752 (tiff_read_from_memory): Don't fail simply because the read would
3753 go past EOF; instead, return a short read.
3754 (tiff_load): Omit no-longer-needed casts.
3755 (Fimagemagick_types): Don't assume size fits into 'int'.
3757 Improve hashing quality when configured --with-wide-int.
3758 * fns.c (hash_string): New function, taken from sxhash_string.
3759 Do not discard information about ASCII character case; this
3760 discarding is no longer needed.
3761 (sxhash-string): Use it. Change sig to match it. Caller changed.
3762 * lisp.h: Declare it.
3763 * lread.c (hash_string): Remove, since we now use fns.c's version.
3764 The fns.c version returns a wider integer if --with-wide-int is
3765 specified, so this should help the quality of the hashing a bit.
3767 * emacs.c: Integer overflow minor fix.
3768 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3769 Define only if GNU_LINUX.
3770 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3772 * dispnew.c: Integer signedness and overflow fixes.
3773 Remove unnecessary forward decls, that were a maintenance hassle.
3774 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3776 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3777 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3778 (prepare_desired_row, line_draw_cost):
3779 Use int, not unsigned, where either works.
3780 (save_current_matrix, restore_current_matrix):
3781 Use ptrdiff_t, not size_t, where either works.
3782 (init_display): Check for overflow more accurately, and without
3783 relying on undefined behavior.
3785 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3786 Remove, replacing with the new symbols in lisp.h. All uses changed.
3787 * fileio.c (make_temp_name):
3788 * filelock.c (lock_file_1, lock_file):
3789 * xdisp.c (message_dolog):
3790 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3791 Use pMd etc. instead.
3792 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3793 replacing the pWIDE etc. symbols removed from editfns.c.
3795 * keyboard.h (num_input_events): Now uintmax_t.
3796 This is (very slightly) less likely to mess up due to wraparound.
3799 * buffer.c: Integer signedness fixes.
3800 (alloc_buffer_text, enlarge_buffer_text):
3801 Use ptrdiff_t rather than size_t when either will do, as we prefer
3804 * alloc.c: Integer signedness and overflow fixes.
3805 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3806 (__malloc_size_t): Default to size_t, not to int.
3807 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3808 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3809 Prefer ptrdiff_t to size_t when either would do, as we prefer
3811 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3812 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3813 Now const. Initialize with values that are in range even if char
3815 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3816 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3817 These functions do the right thing with sizes > 2**32.
3818 (check_depth): Now ptrdiff_t, not int.
3819 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3820 Adjust to new way of storing sizes. Check for size overflow bugs
3822 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3823 slightly wrong anyway, as it missed one instance of
3824 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3825 (refill_memory_reserve): Omit needless cast to size_t.
3826 (mark_object_loop_halt): Mark as externally visible.
3828 * xselect.c: Integer signedness and overflow fixes.
3829 (Fx_register_dnd_atom, x_handle_dnd_message):
3830 Use ptrdiff_t, not size_t, since we prefer signed.
3831 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3832 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3833 x_dnd_atoms_size and x_dnd_atoms_length.
3835 * doprnt.c: Prefer signed to unsigned when either works.
3837 * doprnt.c (doprnt):
3839 * xdisp.c (vmessage):
3840 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3841 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3842 prefer signed arithmetic to avoid comparison confusion.
3843 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3844 but is a bit tricky.
3846 Assume freestanding C89 headers, string.h, stdlib.h.
3847 * data.c, doprnt.c, floatfns.c, print.c:
3848 Include float.h unconditionally.
3849 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3850 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3851 * regex.c: Likewise for stddef.h, string.h.
3852 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3853 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3854 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3855 (STDC_HEADERS): Remove obsolete defines.
3856 * sysdep.c: Include limits.h unconditionally.
3858 Assume support for memcmp, memcpy, memmove, memset.
3859 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3860 * regex.c (memcmp, memcpy):
3861 Remove; we assume C89 now.
3863 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3864 (__malloc_safe_bcopy): Remove; no longer needed.
3866 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3867 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3868 well either way, and we prefer signed to unsigned.
3870 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3872 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3873 closes the connection while we're reading (bug#9182).
3875 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3877 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3878 are specified (Bug#9168).
3880 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3882 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3883 Found by GCC static checking and --with-wide-int on a 32-bit host.
3885 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3887 * xdisp.c (compute_display_string_pos): Fix logic of caching
3888 previous display string position. Initialize cached_prev_pos to
3889 -1. Fixes slow-down at the beginning of a buffer.
3891 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3893 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3894 for attrs[LFACE_FONTSET_INDEX].
3896 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3898 * xml.c (parse_region): Remove unused local
3899 that was recently introduced.
3901 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3903 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3904 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3906 * xdisp.c (move_it_in_display_line_to): Record the best matching
3907 position for TO_CHARPOS while scanning the line, and restore it on
3908 exit if none of the characters scanned was an exact match.
3909 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3910 when exact match is impossible due to invisible text, and the
3911 lines are truncated.
3913 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3915 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3918 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3920 Fix a significant slow-down of cursor motion with C-n, C-p,
3921 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3922 auto-repeat under bidi redisplay in fontified buffers.
3923 * xdisp.c (compute_stop_pos_backwards): New function.
3924 (next_element_from_buffer): Call compute_stop_pos_backwards to
3925 find a suitable prev_stop when we find ourselves before
3927 (reseat): Don't look for prev_stop, as that could mean a very long
3929 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3930 <cached_disp_overlay_modiff>: Cache for last found display string
3932 (compute_display_string_pos): Return the cached position if asked
3933 about the same buffer in the same area of character positions, and
3934 the buffer wasn't changed since the time the display string
3935 position was cached.
3937 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3939 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3940 is an integer, which is important for empty lines. (Bug#9149)
3942 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3944 * frame.c (Fmodify_frame_parameters): In tty case, update the
3945 default face if necessary (Bug#4238).
3947 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3949 * editfns.c (Fstring_to_char): No need to explain what a character
3950 is in the docstring (Bug#6576).
3952 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3954 * xml.c (parse_region): Make sure we always return a tree.
3956 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3958 * xml.c (parse_region): If a document contains only comments,
3961 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3963 * xml.c (make_dom): Return comments, too.
3965 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3968 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3969 and the surrounding thread.
3970 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3971 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3972 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3974 * s/openbsd.h (BROKEN_SIGIO): Define.
3975 * unexelf.c (unexec) [__OpenBSD__]:
3976 Don't update the .mdebug section of the Alpha COFF symbol table.
3978 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3980 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3983 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3985 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3986 This fixes some race conditions on the permissions of any newly
3989 * alloc.c (valid_pointer_p): Use pipe, not open.
3990 This fixes some permissions issues when debugging.
3992 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3993 If fchown fails to set both uid and gid, try to set just gid,
3994 as that is sometimes allowed. Adjust the file's mode to eliminate
3995 setuid or setgid bits that are inappropriate if fchown fails.
3997 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3999 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4000 to compare Lisp_Objects.
4001 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4002 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4003 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4005 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4007 * lread.c (read_integer): Unread even EOF character.
4008 (read1): Likewise. Properly record start position of symbol.
4010 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4011 symbol character follows.
4013 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4015 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4016 This works around a problem with the previous change to Fcopy_file.
4017 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4018 and without this change, GCC might complain about discarding
4019 fchown's return value.
4021 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4023 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4025 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4027 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4029 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4031 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4032 it's used from the C level.
4034 * process.c: Use the same condition for POLL_FOR_INPUT in both
4035 keyboard.c and process.c (bug#1858).
4037 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4039 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4040 (Fgnutls_boot): Use it.
4042 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4044 * doc.c (Fsubstitute_command_keys): Revert last change.
4046 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4048 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4049 quotes the next character, and doesn't affect other longer
4050 sequences (bug#8935).
4052 * lread.c (syms_of_lread): Clarify that is isn't only
4053 `eval-buffer' and `eval-defun' that's affected by
4054 `lexical-binding' (bug#8460).
4056 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4058 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4059 bidi redisplay when a line includes both an image and is truncated.
4061 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4063 Fix minor problems found by static checking.
4064 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4065 (elsz): Now a signed constant, not a size_t var. We prefer signed
4066 types to unsigned, to avoid integer comparison confusion. Without
4067 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4068 "cannot optimize loop, the loop counter may overflow", a symptom
4070 * indent.c (Fvertical_motion): Mark locals as initialized.
4071 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4073 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4075 * search.c (Fre_search_backward): Mention `case-fold-search' in
4076 all the re_search_* functions (bug#8138).
4078 * keyboard.c (Fopen_dribble_file): Document when the file is
4081 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4083 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4086 Support bidi reordering of display and overlay strings.
4087 * xdisp.c (compute_display_string_pos)
4088 (compute_display_string_end): Accept additional argument STRING.
4089 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4090 (reseat_to_string): Initialize bidi_it->string.s and
4091 bidi_it->string.schars.
4092 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4093 NULL (avoids a crash in bidi_paragraph_init).
4094 Initialize itb.string.lstring.
4095 (init_iterator): Call bidi_init_it only of a valid
4096 buffer position was specified. Initialize paragraph_embedding to
4098 (reseat_to_string): Initialize the bidi iterator.
4099 (display_string): If we need to ignore text properties of
4100 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4101 original value of -1 will not work with bidi.)
4102 (compute_display_string_pos): First arg is now struct
4103 `text_pos *'; all callers changed. Support display properties on
4105 (compute_display_string_end): Support display properties on Lisp
4107 (init_iterator, reseat_1, reseat_to_string): Initialize the
4108 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4109 when iterating on a string not from display properties).
4110 (compute_display_string_pos, compute_display_string_end):
4111 Fix calculation of the object to scan. Fixes an error when using
4113 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4114 base_level_stop; instead, set base_level_stop to BEGV.
4115 Fixes crashes in vertical-motion.
4116 (next_element_from_buffer): Improve commentary for when
4117 the iterator is before prev_stop.
4118 (init_iterator): Initialize bidi_p from the default value of
4119 bidi-display-reordering, not from buffer-local value. Use the
4120 buffer-local value only if initializing for buffer iteration.
4121 (handle_invisible_prop): Support invisible properties on strings
4122 that are being bidi-reordered.
4123 (set_iterator_to_next): Support bidi reordering of C strings and
4125 (next_element_from_string): Support bidi reordering of Lisp
4127 (handle_stop_backwards): Support Lisp strings as well.
4128 (display_string): Support display of R2L glyph rows.
4129 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4130 (init_iterator): Don't initialize it->bidi_p for strings
4132 (reseat_to_string): Initialize it->bidi_p for strings here.
4133 (next_element_from_string, next_element_from_c_string)
4134 (next_element_from_buffer): Add xassert's for correspondence
4135 between IT's object being iterated and it->bidi_it.string
4137 (face_before_or_after_it_pos): Support bidi iteration.
4138 (next_element_from_c_string): Handle the case of the first string
4139 character that is not the first one in the visual order.
4140 (get_visually_first_element): New function, refactored from common
4141 parts of next_element_from_buffer, next_element_from_string, and
4142 next_element_from_c_string.
4143 (tool_bar_lines_needed, redisplay_tool_bar)
4144 (display_menu_bar): Force left-to-right direction. Add a FIXME
4145 comment for making that be controlled by a user option.
4146 (push_it, pop_it): Save and restore the state of the
4147 bidi iterator. Save and restore the bidi_p flag.
4148 (pop_it): Iterate out of display property for string iteration as
4150 (iterate_out_of_display_property): Support iteration over strings.
4151 (handle_single_display_spec): Set up it->bidi_it for iteration
4152 over a display string, and call bidi_init_it.
4153 (handle_single_display_spec, next_overlay_string)
4154 (get_overlay_strings_1, push_display_prop): Set up the bidi
4155 iterator for displaying display or overlay strings.
4156 (forward_to_next_line_start): Don't use the shortcut if
4158 (back_to_previous_visible_line_start): If handle_display_prop
4159 pushed the iterator stack, restore the internal state of the bidi
4160 iterator by calling bidi_pop_it same number of times.
4161 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4162 and we are bidi-iterating, don't decrement the iterator position;
4163 instead, set the first_elt flag in the bidi iterator, to produce
4165 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4166 (push_display_prop): xassert that we are iterating a buffer.
4167 (push_it, pop_it): Save and restore paragraph_embedding member.
4168 (handle_single_display_spec, next_overlay_string)
4169 (get_overlay_strings_1, reseat_1, reseat_to_string)
4170 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4171 correctly. Don't assume unibyte strings are not bidi-reordered.
4172 (compute_display_string_pos)
4173 (compute_display_string_end): Fix handling the case of C string.
4174 (push_it, pop_it): Save and restore from_disp_prop_p.
4175 (handle_single_display_spec, push_display_prop): Set the
4176 from_disp_prop_p flag.
4177 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4178 (pop_it): Call iterate_out_of_display_property only if we are
4179 popping after iteration over a string that came from a display
4180 property. Fix a typo in popping stretch info. Add an assertion
4181 for verifying that the iterator position is in sync with the bidi
4183 (handle_single_display_spec, get_overlay_strings_1)
4184 (push_display_prop): Fix initialization of paragraph direction for
4185 string when that of the parent object is not yet determined.
4186 (reseat_1): Call bidi_init_it to resync the bidi
4187 iterator with IT's position. (Bug#7616)
4188 (find_row_edges): If ROW->start.pos gives position
4189 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4190 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4191 Reset the from_disp_prop_p flag.
4192 (SAVE_IT, RESTORE_IT): New macros.
4193 (pos_visible_p, face_before_or_after_it_pos)
4194 (back_to_previous_visible_line_start)
4195 (move_it_in_display_line_to, move_it_in_display_line)
4196 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4197 (try_scrolling, redisplay_window, display_line): Use them when
4198 saving a temporary copy of the iterator and restoring it back.
4199 (back_to_previous_visible_line_start, reseat_1)
4200 (init_iterator): Empty the bidi cache "stack".
4201 (move_it_in_display_line_to): If iterator ended up at
4202 EOL, but we never saw any buffer positions smaller than
4203 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4204 motion in bidi-reordered lines.
4205 (move_it_in_display_line_to): Record prev_method and prev_pos
4206 immediately before the call to set_iterator_to_next. Fixes cursor
4207 motion in bidi-reordered lines with stretch glyphs and strings
4208 displayed in margins. (Bug#8133) (Bug#8867)
4209 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4211 (pos_visible_p): Support positions in bidi-reordered lines.
4212 Save and restore bidi cache.
4214 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4215 (bidi_paragraph_info): Delete unused struct.
4216 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4217 (bidi_cache_start): New variable.
4218 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4220 (bidi_cache_fetch_state, bidi_cache_search)
4221 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4222 (bidi_cache_find, bidi_peek_at_next_level)
4223 (bidi_level_of_next_char, bidi_find_other_level_edge)
4224 (bidi_move_to_visually_next): Compare cache index with
4225 bidi_cache_start rather than with zero.
4226 (bidi_fetch_char): Accept new argument STRING; all callers
4227 changed. Support iteration over a string. Support strings with
4228 display properties. Support unibyte strings. Fix the type of
4229 `len' according to what STRING_CHAR_AND_LENGTH expects.
4230 (bidi_paragraph_init, bidi_resolve_explicit_1)
4231 (bidi_resolve_explicit, bidi_resolve_weak)
4232 (bidi_level_of_next_char, bidi_move_to_visually_next):
4233 Support iteration over a string.
4234 (bidi_set_sor_type, bidi_resolve_explicit_1)
4235 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4236 can now be zero (for strings); special values 0 and -1 were
4237 changed to -1 and -2, respectively.
4238 (bidi_char_at_pos): New function.
4239 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4240 Call it instead of FETCH_MULTIBYTE_CHAR.
4241 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4242 initialized to valid values.
4243 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4245 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4246 the test for valid cached positions. Fix the logic for looking up
4247 the sentinel state in the cache. GCPRO the Lisp string we are
4249 (bidi_push_it, bidi_pop_it): New functions.
4250 (bidi_initialize): Initialize the bidi cache start stack pointer.
4251 (bidi_cache_ensure_space): New function, refactored from part of
4252 bidi_cache_iterator_state. Don't assume the required size is just
4253 one BIDI_CACHE_CHUNK away.
4254 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4255 (bidi_count_bytes, bidi_char_at_pos): New functions.
4256 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4257 always valid if bidi_cache_idx is valid.
4258 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4259 is valid if it's going to be used.
4260 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4261 (bidi_cache_fetch_state, bidi_cache_search)
4262 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4263 (bidi_cache_iterator_state, bidi_cache_find)
4264 (bidi_find_other_level_edge, bidi_cache_start_stack):
4265 All variables related to cache indices are now EMACS_INT.
4267 * dispextern.h (struct bidi_string_data): New structure.
4268 (struct bidi_it): New member `string'. Make flag members be 1-bit
4269 fields, and put them last in the struct.
4270 (compute_display_string_pos, compute_display_string_end):
4272 (bidi_push_it, bidi_pop_it): Add prototypes.
4273 (struct iterator_stack_entry): New members bidi_p,
4274 paragraph_embedding, and from_disp_prop_p.
4275 (struct it): Member bidi_p is now a bit field 1 bit wide.
4276 (bidi_shelve_cache, bidi_unshelve_cache):
4279 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4280 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4281 and vector-like objects.
4283 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4284 cache around display iteration.
4286 * window.c (Fwindow_end, window_scroll_pixel_based)
4287 (displayed_window_lines, Frecenter): Save and restore the bidi
4288 cache around display iteration.
4290 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4292 * editfns.c (Fdelete_region): Clarify the use of the named
4293 parameters (bug#6788).
4295 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4297 * indent.c (Fvertical_motion): Set and restore w->pointm when
4298 saving and restoring the window's buffer (Bug#9006).
4300 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4302 * editfns.c (Fstring_to_char): Clarify just what is returned
4303 (bug#6576). Text by Eli Zaretskii.
4305 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4307 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4309 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4311 * buffer.c (mmap_find): Fix a typo.
4313 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4315 Fix execution of x selection hooks.
4316 * xselect.c (Qx_lost_selection_functions)
4317 (Qx_sent_selection_functions): New vars.
4318 (syms_of_xselect): DEFSYM them.
4319 (x_handle_selection_request): Pass Qx_sent_selection_functions
4320 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4321 (x_handle_selection_clear,x_clear_frame_selections):
4322 Pass Qx_lost_selection_functions rather than
4323 Vx_lost_selection_functions to Frun_hook_with_args.
4325 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4327 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4328 The old code sometimes used this field without initializing it.
4330 * alloc.c (gc_sweep): Don't read past end of array.
4331 In theory, the old code could also have corrupted Emacs internals,
4332 though it'd be very unlikely.
4334 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4336 * character.c (Fcharacterp): Don't advertise optional ignored
4337 argument. (Bug#4026)
4339 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4341 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4344 * window.c (Fset_window_start): Doc fix (bug#4199).
4345 (Fset_window_hscroll): Ditto.
4347 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4349 Fix minor new problems caught by GCC 4.6.1.
4350 * term.c (init_tty): Remove unused local.
4351 * xsettings.c (store_monospaced_changed): Define this function only
4352 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4355 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4357 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4359 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4361 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4362 are the mini-buffer and the echo area (bug#3320).
4364 * term.c (init_tty): Remove support for supdup, c10 and perq
4365 terminals, which are no longer supported (bug#1482).
4367 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4369 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4371 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4373 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4374 for non-popups (Bug#3642).
4376 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4378 * alloc.c (reset_malloc_hooks): Protoize.
4379 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4380 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4381 * cm.c (losecursor): Likewise.
4382 * data.c (fmod): Likewise.
4383 * dispnew.c (swap_glyphs_in_rows): Likewise.
4384 * emacs.c (memory_warning_signal): Likewise.
4385 * floatfns.c (float_error): Likewise.
4386 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4387 (otf_open, font_otf_capability, generate_otf_features)
4388 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4390 * image.c (pbm_read_file): Likewise.
4391 * indent.c (string_display_width): Likewise.
4392 * intervals.c (check_for_interval, search_for_interval)
4393 (inc_interval_count, count_intervals, root_interval)
4394 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4395 * lread.c (defalias): Likewise.
4396 * ralloc.c (r_alloc_check): Likewise.
4397 * regex.c (set_image_of_range_1, set_image_of_range)
4398 (regex_grow_registers): Likewise.
4399 * sysdep.c (strerror): Likewise.
4400 * termcap.c (valid_filename_p, tprint, main): Likewise.
4401 * tparam.c (main): Likewise.
4402 * unexhp9k800.c (run_time_remap, save_data_space)
4403 (update_file_ptrs, read_header, write_header, calculate_checksum)
4404 (copy_file, copy_rest, display_header): Likewise.
4405 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4407 * xdisp.c (check_it): Likewise.
4408 * xfaces.c (register_color, unregister_color, unregister_colors):
4410 * xfns.c (print_fontset_result): Likewise.
4411 * xrdb.c (member, fatal, main): Likewise.
4413 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4415 Fix minor problems found by static checking (Bug#9031).
4416 * chartab.c (char_table_set_range, map_sub_char_table):
4417 Remove unused locals.
4418 (uniprop_table): Now static.
4419 * composite.c (_work_char): Remove unused static var.
4421 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4423 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4425 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4427 * gtkutil.c (qttip_cb): Remove code without function.
4429 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4431 * w32.c (pthread_sigmask): New stub.
4433 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4435 Use pthread_sigmask, not sigprocmask (Bug#9010).
4436 sigprocmask is portable only for single-threaded applications, and
4437 Emacs can be multi-threaded when it uses GTK.
4438 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4440 * callproc.c (Fcall_process):
4441 * process.c (create_process):
4442 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4443 Use pthread_sigmask, not sigprocmask.
4445 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4447 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4448 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4451 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4453 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4454 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4455 (xg_hide_tooltip): Fix comment.
4457 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4458 in registerServicesMenuSendTypes.
4459 (validRequestorForSendType): Don't check ns_return_types.
4461 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4464 2011-07-08 Jason Rumney <jasonr@gnu.org>
4466 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4467 SH_SHOW for hidden windows (Bug#5482).
4469 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4470 frame struct members of non-existent frames (Bug#6284).
4472 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4474 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4475 variable firstTime not needed on OSX >= 10.6.
4476 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4477 >= 10.5. Use setKnobProportion, setDoubleValue.
4479 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4480 (MAC_OS_X_VERSION_10_5): Define if not defined.
4481 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4482 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4483 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4485 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4486 cString and lossyCString on OSX >= 10.4
4488 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4489 sizeToFit on OSX >= 10.2.
4491 * nsimage.m (allocInitFromFile): Don't use deprecated method
4492 bestRepresentationForDevice on OSX >= 10.6.
4494 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4497 * emacs.c: Declare unexec_init_emacs_zone.
4499 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4501 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4503 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4504 on svcsMenu (Bug#8842).
4506 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4508 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4510 * nsterm.m (QUTF8_STRING): Declare.
4511 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4512 (validRequestorForSendType): Return type is (id).
4513 Change indexOfObjectIdenticalTo to indexOfObject.
4514 Check if we have local selection before returning self (Bug#8842).
4515 (writeSelectionToPasteboard): Put local selection into paste board
4516 if we have a local selection (Bug#8842).
4517 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4519 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4520 (ns_get_local_selection): Declare.
4522 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4524 * keymap.c (describe_map_tree): Don't insert a double newline at
4525 the end of the buffer (bug#1169) and return whether we inserted
4528 * callint.c (Fcall_interactively): Change "reading args" to
4529 "providing args" to try to clarify what it does (bug#1010).
4531 2011-07-07 Kenichi Handa <handa@m17n.org>
4533 * composite.c (composition_compute_stop_pos): Ignore a static
4534 composition starting before CHARPOS (Bug#8915).
4536 * xdisp.c (handle_composition_prop): Likewise.
4538 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4540 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4543 2011-07-07 Kenichi Handa <handa@m17n.org>
4545 * character.h (unicode_category_t): New enum type.
4547 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4548 (Qchar_code_property_table): New variable.
4549 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4550 (UNIPROP_COMPRESSED_FORM_P): New macros.
4551 (char_table_ascii): Uncompress the compressed values.
4552 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4553 Uncompress the compressed values.
4554 (sub_char_table_ref_and_range): Likewise.
4555 (char_table_ref_and_range): Uncompress the compressed values.
4556 (sub_char_table_set): New arg is_uniprop. Callers changed.
4557 Uncompress the compressed values.
4558 (sub_char_table_set_range): Args changed. Callers changed.
4559 (char_table_set_range): Adjuted for the above change.
4560 (map_sub_char_table): Delete args default_val and parent. Add arg
4561 top. Give decoded values to a Lisp function.
4562 (map_char_table): Adjust for the above change. Give decoded
4563 values to a Lisp function. Gcpro more variables.
4564 (uniprop_table_uncompress)
4565 (uniprop_decode_value_run_length): New functions.
4566 (uniprop_decoder, uniprop_decoder_count): New variables.
4567 (uniprop_get_decoder, uniprop_encode_value_character)
4568 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4570 (uniprop_encoder, uniprop_encoder_count): New variables.
4571 (uniprop_get_encoder, uniprop_table)
4572 (Funicode_property_table_internal, Fget_unicode_property_internal)
4573 (Fput_unicode_property_internal): New functions.
4574 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4575 Sunicode_property_table_internal, Sget_unicode_property_internal,
4576 and Sput_unicode_property_internal. Defvar_lisp
4577 char-code-property-alist.
4579 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4580 Vunicode_category_table.
4582 * font.c (font_range): Adjust for the change of
4583 Vunicode_category_table.
4585 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4587 * m/iris4d.h: Remove file, move contents ...
4588 * s/irix6-5.h: ... here.
4590 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4592 Remove unportable assumption about struct layout (Bug#8884).
4593 * alloc.c (mark_buffer):
4594 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4595 (clone_per_buffer_values): Don't assume that
4596 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4597 This isn't true in general, and it's particularly not true
4598 if Emacs is configured with --with-wide-int.
4599 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4600 New macros, used in the buffer.c change.
4602 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4604 * xsettings.c: Use both GConf and GSettings if both are available.
4605 (store_config_changed_event): Add comment.
4606 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4607 (store_tool_bar_style_changed): New functions.
4608 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4609 (struct xsettings): Move font inside HAVE_XFT.
4610 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4611 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4612 Move inside HAVE_XFT.
4613 (something_changed_gsettingsCB): Rename from something_changedCB.
4614 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4616 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4617 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4618 (something_changed_gconfCB): Rename from something_changedCB.
4619 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4620 (parse_settings): Move check for font inside HAVE_XFT.
4621 (read_settings, apply_xft_settings): Add comment.
4622 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4623 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4624 call store_font_name_changed.
4625 (xft_settings_event): Add comment.
4626 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4627 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4628 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4629 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4630 (xsettings_initialize): Call init_gsettings last.
4631 (xsettings_get_system_font, xsettings_get_system_normal_font):
4634 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4636 Random fixes. E.g., (random) never returned negative values.
4637 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4638 subseconds part to the entropy, as that's a bit more random.
4639 Prefer signed to unsigned, since the signedness doesn't matter and
4640 in general we prefer signed. When given a limit, use a
4641 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4642 latter isn't right if USE_2_TAGS_FOR_INTS.
4643 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4644 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4646 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4648 * textprop.c (text_property_stickiness):
4649 Obey Vtext_property_default_nonsticky.
4650 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4651 * w32fns.c (syms_of_w32fns):
4652 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4654 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4656 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4657 This is more efficient than Ffile_directory_p and avoids a minor race.
4659 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4661 * buffer.c (Foverlay_put): Say what the return value is
4664 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4665 is a directory before asking whether to use the file name
4667 (barf_or_query_if_file_exists): Make the "File is a directory"
4668 error be more correct.
4670 * fns.c (Frequire): Remove the mention of the .gz files, since
4671 that's installation-specific, but keep the mention of
4672 `get-load-suffixes'.
4674 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4676 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4677 Report string overflow if the output is too long.
4679 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4681 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4682 (syms_of_gnutls): Remove duplicate DEFSYM for
4683 Qgnutls_bootprop_verify_hostname_error, an error for
4684 Qgnutls_bootprop_verify_error (which is no longer used).
4686 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4687 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4688 Also (re)move comments that are misplaced or no longer relevant.
4690 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4692 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4694 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4696 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4697 and background color parameters if they have been changed.
4699 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4701 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4703 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4705 * xsettings.c (SYSTEM_FONT): Define only when used.
4706 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4708 * keymap.c (access_keymap_1): Now static.
4710 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4712 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4713 leave any prefix arg for the up event (Bug#1586).
4715 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4717 * lread.c (syms_of_lread): Mention single symbols defined by
4718 `defvar' or `defconst' (bug#7154).
4720 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4721 (Frequire): Mention get-load-suffixes.
4723 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4725 * window.h (window): Remove clone_number slot.
4726 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4728 (make_parent_window, make_window, saved_window)
4729 (Fset_window_configuration, save_window_save): Don't deal with
4731 * buffer.c (Qclone_number): Remove declaration.
4732 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4734 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4736 Add multiple inheritance to keymaps.
4737 * keymap.c (Fmake_composed_keymap): New function.
4738 (Fset_keymap_parent): Simplify.
4739 (fix_submap_inheritance): Remove.
4740 (access_keymap_1): New function extracted from access_keymap to handle
4741 embedded parents and handle lists of maps.
4742 (access_keymap): Use it.
4743 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4744 (Fcopy_keymap): Handle embedded parents.
4745 (Fcommand_remapping, define_as_prefix): Simplify.
4746 (Fkey_binding): Simplify.
4747 (syms_of_keymap): Move minibuffer-local-completion-map,
4748 minibuffer-local-filename-completion-map,
4749 minibuffer-local-must-match-map, and
4750 minibuffer-local-filename-must-match-map to Elisp.
4751 (syms_of_keymap): Defsubr make-composed-keymap.
4752 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4753 (parse_menu_item): Trivial simplification.
4755 2011-07-01 Glenn Morris <rgm@gnu.org>
4757 * Makefile.in (SETTINGS_LIBS): Fix typo.
4759 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4761 * coding.c (Fencode_coding_string): Record the last coding system
4762 used, as the function doc string says (bug#8738).
4764 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4766 * xsettings.c (store_monospaced_changed): Take new font as arg and
4767 check for change against current_mono_font.
4768 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4769 (emacs_settings_constructor, emacs_settings_get_property)
4770 (emacs_settings_set_property, emacs_settings_class_init)
4771 (emacs_settings_init, gsettings_obj): Remove.
4772 (something_changedCB): New function for HAVE_GSETTINGS.
4773 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4774 with value as argument.
4775 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4776 g_settings_new (Bug#8967). Do not create gsettings_obj.
4777 Remove calls to g_settings_bind. Connect something_changedCB to
4780 * xgselect.c: Add defined (HAVE_GSETTINGS).
4781 (xgselect_initialize): Ditto.
4783 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4784 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4787 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4789 * eval.c (struct backtrace): Simplify and port the data structure.
4790 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4791 signed bit field, as this assumption is not portable and it makes
4792 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4793 "char debug_on_exit : 1" as this is not portable either; instead,
4794 use the portable "unsigned int debug_on_exit : 1". Remove unused
4795 member evalargs. Remove obsolete comments about cc bombing out.
4797 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4799 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4800 Let HAVE_GSETTINGS override HAVE_GCONF.
4801 (store_monospaced_changed): New function.
4802 (EMACS_SETTINGS): A new type derived from GObject to handle
4803 GSettings notifications.
4804 (emacs_settings_constructor, emacs_settings_get_property)
4805 (emacs_settings_set_property, emacs_settings_class_init):
4807 (gsettings_client, gsettings_obj): New variables.
4808 (GSETTINGS_SCHEMA): New define.
4809 (something_changedCB): Call store_monospaced_changed.
4810 (init_gsettings): New function.
4811 (xsettings_initialize): Call init_gsettings.
4812 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4815 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4818 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4820 * window.c (resize_root_window, grow_mini_window)
4821 (shrink_mini_window): Rename Qresize_root_window to
4822 Qwindow_resize_root_window and Qresize_root_window_vertically to
4823 Qwindow_resize_root_window_vertically.
4825 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4827 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4829 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4831 * makefile.w32-in: Redesign dependencies so they reflect more
4832 clearly which files are directly included by each source file,
4833 and not through other includes.
4835 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4837 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4838 (sort_overlays, overlay_strings): When an overlay's clone number
4839 matches the window's clone number process the overlay even if
4840 the overlay's window property doesn't match the current window.
4842 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4843 (Fwindow_hchild): Rename to Fwindow_left_child.
4844 (Fwindow_next): Rename to Fwindow_next_sibling.
4845 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4846 (resize_window_check): Rename to window_resize_check.
4847 (resize_window_apply): Rename to window_resize_apply.
4848 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4849 (Fdelete_other_windows_internal, resize_frame_windows)
4850 (Fsplit_window_internal, Fdelete_window_internal)
4851 (grow_mini_window, shrink_mini_window)
4852 (Fresize_mini_window_internal): Fix callers accordingly.
4854 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4856 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4857 (emacs_fixed_set_min_size): Remove.
4858 (emacs_fixed_new): Take frame as argument.
4860 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4861 (_EmacsFixedPrivate): Remove minwidth/height.
4862 Add struct frame *f.
4863 (emacs_fixed_init): Initialize priv->f.
4864 (get_parent_class, emacs_fixed_set_min_size): Remove.
4865 (emacs_fixed_new): Set priv->f to argument.
4866 (emacs_fixed_get_preferred_width)
4867 (emacs_fixed_get_preferred_height): Use min_width/height from
4868 frames size_hint to set minimum and natural (Bug#8919).
4869 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4870 and use min_width/height from frames size_hint to set
4871 min_width/height (Bug#8919).
4873 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4874 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4877 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4879 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4880 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4883 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4885 * process.c (wait_reading_process_output): Bypass select if
4886 waiting for a cell while ignoring keyboard input, and input is
4887 pending. Suggested by Jan Djärv (Bug#8869).
4889 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4891 Use gnulib's dup2 module instead of rolling our own.
4892 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4894 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4896 * dispnew.c (scrolling_window): Before scrolling, turn off a
4897 mouse-highlight in the window being scrolled.
4899 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4901 Move DEFSYM to lisp.h and use everywhere.
4903 * character.h (DEFSYM): Move declaration...
4904 * lisp.h (DEFSYM): ...here.
4910 * w32select.c: Don't include character.h.
4912 * alloc.c (syms_of_alloc):
4913 * buffer.c (syms_of_buffer):
4914 * bytecode.c (syms_of_bytecode):
4915 * callint.c (syms_of_callint):
4916 * casefiddle.c (syms_of_casefiddle):
4917 * casetab.c (init_casetab_once):
4918 * category.c (init_category_once, syms_of_category):
4919 * ccl.c (syms_of_ccl):
4920 * cmds.c (syms_of_cmds):
4921 * composite.c (syms_of_composite):
4922 * dbusbind.c (syms_of_dbusbind):
4923 * dired.c (syms_of_dired):
4924 * dispnew.c (syms_of_display):
4925 * doc.c (syms_of_doc):
4926 * editfns.c (syms_of_editfns):
4927 * emacs.c (syms_of_emacs):
4928 * eval.c (syms_of_eval):
4929 * fileio.c (syms_of_fileio):
4930 * fns.c (syms_of_fns):
4931 * frame.c (syms_of_frame):
4932 * fringe.c (syms_of_fringe):
4933 * insdel.c (syms_of_insdel):
4934 * keymap.c (syms_of_keymap):
4935 * lread.c (init_obarray, syms_of_lread):
4936 * macros.c (syms_of_macros):
4937 * msdos.c (syms_of_msdos):
4938 * print.c (syms_of_print):
4939 * process.c (syms_of_process):
4940 * search.c (syms_of_search):
4941 * sound.c (syms_of_sound):
4942 * syntax.c (init_syntax_once, syms_of_syntax):
4943 * terminal.c (syms_of_terminal):
4944 * textprop.c (syms_of_textprop):
4945 * undo.c (syms_of_undo):
4946 * w32.c (globals_of_w32):
4947 * window.c (syms_of_window):
4948 * xdisp.c (syms_of_xdisp):
4949 * xfaces.c (syms_of_xfaces):
4950 * xfns.c (syms_of_xfns):
4951 * xmenu.c (syms_of_xmenu):
4952 * xsettings.c (syms_of_xsettings):
4953 * xterm.c (syms_of_xterm): Use DEFSYM.
4955 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4957 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4959 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4961 Integer and buffer overflow fixes (Bug#8873).
4963 * print.c (printchar, strout): Check for string overflow.
4964 (PRINTPREPARE, printchar, strout):
4965 Don't set size unless allocation succeeds.
4967 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4968 for sizes. Check for string overflow more accurately.
4969 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4971 * macros.c: Integer and buffer overflow fixes.
4972 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4973 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4974 Use ptrdiff_t, not int, for sizes.
4975 Don't increment bufsize until after realloc succeeds.
4976 Check for size-calculation overflow.
4977 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4979 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4981 * lread.c: Integer overflow fixes.
4982 (read_integer): Radix is now EMACS_INT, not int,
4983 to improve quality of diagnostics for out-of-range radices.
4984 Calculate buffer size correctly for out-of-range radices.
4985 (read1): Check for integer overflow in radices, and in
4986 read-circle numbers.
4987 (read_escape): Avoid int overflow.
4988 (Fload, openp, read_buffer_size, read1)
4989 (substitute_object_recurse, read_vector, read_list, map_obarray):
4990 Use ptrdiff_t, not int, for sizes.
4991 (read1): Use EMACS_INT, not int, for sizes.
4992 Check for size overflow.
4994 * image.c (cache_image): Check for size arithmetic overflow.
4996 * lread.c: Integer overflow issues.
4997 (saved_doc_string_size, saved_doc_string_length)
4998 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4999 Now ptrdiff_t, not int.
5000 (read1): Don't assume doc string length fits in int. Check for
5001 out-of-range doc string lengths.
5002 (read_list): Don't assume file position fits in int.
5003 (read_escape): Check for hex character overflow.
5005 2011-06-22 Leo Liu <sdl.web@gmail.com>
5007 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5008 Move to minibuffer.el.
5010 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5012 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5013 The following patches are for when GLYPH_DEBUG && !XASSERT.
5014 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5015 * dispnew.c (flush_stdout):
5016 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5017 Mark as externally visible.
5018 * dispnew.c (check_window_matrix_pointers): Now static.
5019 * dispnew.c (window_to_frame_vpos):
5020 * xfns.c (unwind_create_frame):
5021 * xterm.c (x_check_font): Remove unused local.
5022 * scroll.c (CHECK_BOUNDS):
5023 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5024 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5025 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5026 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5027 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5029 (debug_method_add): Use va_list and vsprintf rather than relying
5030 on undefined behavior with wrong number of arguments.
5031 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5032 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5033 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5034 since we're not interested in debugging glyphs with old libraries.
5035 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5036 GCC 4.6.0's static checking.
5038 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5040 Integer overflow and signedness fixes (Bug#8873).
5041 A few related buffer overrun fixes, too.
5043 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5045 * dispextern.h (struct face.stipple):
5046 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5047 (x_bitmap_mask, x_allocate_bitmap_record)
5048 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5049 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5050 (x_create_bitmap_from_xpm_data):
5051 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5052 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5054 * xfaces.c (load_pixmap):
5055 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5056 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5057 (.bitmaps_last, struct x_output.icon_bitmap):
5058 Use ptrdiff_t, not int, for bitmap indexes.
5059 (x_allocate_bitmap_record): Check for size overflow.
5060 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5062 Use ptrdiff_t, not int, for overlay counts.
5063 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5064 * editfns.c (overlays_around, get_pos_property):
5065 * textprop.c (get_char_property_and_overlay):
5066 * xdisp.c (next_overlay_change, note_mouse_highlight):
5067 * xfaces.c (face_at_buffer_position):
5068 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5069 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5070 (Fnext_overlay_change, Fprevious_overlay_change)
5071 (mouse_face_overlay_overlaps, Foverlays_in):
5072 Use ptrdiff_t, not int, for sizes.
5073 (overlays_at, overlays_in): Check for size-calculation overflow.
5075 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5077 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5078 (x_session_initialize): Do not assume string length fits in int.
5080 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5081 This is unlikely, but can occur if DPI is outlandish.
5083 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5084 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5086 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5087 * xrdb.c (magic_file_p, search_magic_path):
5088 Omit last arg SUFFIX; it was always 0. All callers changed.
5089 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5091 * xfont.c (xfont_match): Avoid need for strlen.
5093 * xfns.c: Don't assume strlen fits in int.
5094 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5096 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5097 not unsigned long, as we prefer signed integers. All callers changed.
5098 Detect integer overflow in repeat count.
5099 (message_dolog): Don't assume print length fits in 39 bytes.
5100 (display_mode_element): Don't assume strlen fits in int.
5102 * termcap.c: Don't assume sizes fit in int and never overflow.
5103 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5104 (gobble_line): Check for size-calculation overflow.
5106 * minibuf.c (Fread_buffer):
5107 * lread.c (intern, intern_c_string):
5108 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5109 Don't assume string length fits in int.
5111 * keyboard.c (parse_tool_bar_item):
5112 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5114 * font.c: Don't assume string length fits in int.
5115 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5116 Use ptrdiff_t, not int.
5117 (font_intern_prop): Don't assume string length fits in int.
5118 Don't assume integer property fits in fixnum.
5119 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5121 * filelock.c: Fix some buffer overrun and integer overflow issues.
5122 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5123 Reformulate so as not to need the command string.
5124 Invoke gzip -cd rather than gunzip, as it's more portable.
5125 (lock_info_type, lock_file_1, lock_file):
5126 Don't assume pid_t and time_t fit in unsigned long.
5127 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5128 (current_lock_owner): Prefer signed type for sizes.
5129 Use memcpy, not strncpy, where memcpy is what is really wanted.
5130 Don't assume (via atoi) that time_t and pid_t fit in int.
5131 Check for time_t and/or pid_t out of range, e.g., via a network share.
5132 Don't alloca where an auto var works fine.
5134 * fileio.c: Fix some integer overflow issues.
5135 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5136 Don't assume string length fits in int.
5137 (directory_file_name): Don't assume string length fits in long.
5138 (make_temp_name): Don't assume pid fits in int, or that its print
5139 length is less than 20.
5141 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5143 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5145 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5147 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5148 We prefer signed integers, even for size calculations.
5150 * emacs.c: Don't assume string length fits in 'int'.
5151 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5152 (main): Don't invoke strlen when not needed.
5154 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5155 (XD_DEBUG_MESSAGE): Don't waste a byte.
5157 * callproc.c (getenv_internal_1, getenv_internal)
5159 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5161 * lread.c (invalid_syntax): Omit length argument.
5162 All uses changed. This doesn't fix a bug, but it simplifies the
5163 code away from its former Hollerith-constant appearance, and it's
5164 one less 'int' to worry about when looking at integer-overflow issues.
5165 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5167 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5168 This didn't break anything, but it didn't help either.
5169 It's confusing to put a bogus integer in a place where the actual
5170 value does not matter.
5171 (LIST_END_P): Remove unused macro and its bogus comment.
5172 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5174 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5175 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5177 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5178 We prefer signed types, and the value cannot exceed the EMACS_INT
5179 range anyway (because otherwise the length would not be representable).
5180 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5181 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5182 This avoids a GCC warning when WIDE_EMACS_INT.
5184 * indent.c (sane_tab_width): New function.
5185 (current_column, scan_for_column, Findent_to, position_indentation)
5186 (compute_motion): Use it. This is just for clarity.
5187 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5189 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5191 * lisp.h (lint_assume): New macro.
5192 * composite.c (composition_gstring_put_cache):
5193 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5195 * editfns.c, insdel.c:
5196 Omit unnecessary forward decls, to simplify future changes.
5198 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5200 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5202 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5203 Use much-faster test for byte-length change.
5204 Don't assume string byte-length fits in 'int'.
5205 Check that character arg fits in 'int'.
5206 (mapcar1): Declare byte as byte, for clarity.
5208 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5210 * fns.c (concat): Catch string overflow earlier.
5211 Do not rely on integer wraparound.
5213 * dispextern.h (struct it.overlay_strings_charpos)
5214 (struct it.selective): Now EMACS_INT, not int.
5215 * xdisp.c (forward_to_next_line_start)
5216 (back_to_previous_visible_line_start)
5217 (reseat_at_next_visible_line_start, next_element_from_buffer):
5218 Don't arbitrarily truncate the value of 'selective' to int.
5220 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5222 * composite.c: Don't truncate sizes to 'int'.
5223 (composition_gstring_p, composition_reseat_it)
5224 (composition_adjust_point): Use EMACS_INT, not int.
5225 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5226 not EMACS_UINT, for indexes.
5228 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5230 * buffer.c: Include <verify.h>.
5231 (struct sortvec.priority, struct sortstr.priority):
5232 Now EMACS_INT, not int.
5233 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5234 (struct sortstr.size, record_overlay_string)
5235 (struct sortstrlist.size, struct sortlist.used):
5236 Don't truncate size to int.
5237 (record_overlay_string): Check for size-calculation overflow.
5238 (init_buffer_once): Check at compile-time, not run-time.
5240 2011-06-22 Jim Meyering <meyering@redhat.com>
5242 Don't leak an XBM-image-sized buffer
5243 * image.c (xbm_load): Free the image buffer after using it.
5245 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5248 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5249 that Sun C diagnosed.
5250 * fns.c (secure_hash): Fix pointer signedness issue.
5251 * intervals.c (static_offset_intervals): New function.
5252 (offset_intervals): Use it.
5254 2011-06-21 Leo Liu <sdl.web@gmail.com>
5257 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5260 * fns.c (secure_hash): Rename from crypto_hash_function and change
5261 the first arg to accept symbols.
5262 (Fsecure_hash): New primitive.
5263 (syms_of_fns): New symbols.
5265 2011-06-20 Deniz Dogan <deniz@dogan.se>
5267 * process.c (Fset_process_buffer): Clarify return value in
5270 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5272 * dispnew.c (add_window_display_history): Use BVAR.
5274 * xdisp.c (debug_method_add): Use BVAR.
5275 (check_window_end, dump_glyph_matrix, dump_glyph)
5276 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5278 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5281 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5282 check till after the cache is created in init_frame_faces.
5284 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5286 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5288 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5290 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5291 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5292 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5294 Improve buffer-overflow checking (Bug#8873).
5295 * fileio.c (Finsert_file_contents):
5296 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5297 Remove the old (too-loose) buffer overflow checks.
5298 They weren't needed, since make_gap checks for buffer overflow.
5299 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5300 The old code merely checked for Emacs fixnum overflow, and relied
5301 on undefined (wraparound) behavior. The new code avoids undefined
5302 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5304 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5305 Tune. Don't use wider integers than needed. Don't use alloca.
5306 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5308 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5310 * insdel.c, lisp.h (buffer_overflow): New function.
5311 (insert_from_buffer_1, replace_range, replace_range_2):
5312 * insdel.c (make_gap_larger):
5313 * editfns.c (Finsert_char):
5314 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5316 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5318 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5320 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5322 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5323 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5325 * fileio.c: Don't assume EMACS_INT fits in off_t.
5326 (emacs_lseek): New static function.
5327 (Finsert_file_contents, Fwrite_region): Use it.
5328 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5330 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5332 * fns.c: Don't overflow int when computing a list length.
5333 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5334 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5335 truncation on 64-bit hosts. Check for QUIT every
5336 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5337 faster and is responsive enough.
5338 (Flength): Report an error instead of overflowing an integer.
5339 (Fsafe_length): Return a float if the value is not representable
5340 as a fixnum. This shouldn't happen except in contrived situations.
5341 (Fnthcdr, Fsort): Don't assume list length fits in int.
5342 (Fcopy_sequence): Don't assume vector length fits in int.
5344 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5345 (header_size, word_size): New constants.
5346 (allocate_vectorlike): Don't check size overflow here.
5347 (allocate_vector): Check it here instead, since this is the only
5348 caller of allocate_vectorlike that could cause overflow.
5349 Check that the new vector's length is representable as a fixnum.
5351 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5352 The previous code was bogus. For example, next_almost_prime (32)
5353 returned 39, which is undesirable as it is a multiple of 3; and
5354 next_almost_prime (24) returned 25, which is a multiple of 5 so
5355 why was the code bothering to check for multiples of 7?
5357 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5359 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5361 Variadic C functions now count arguments with ptrdiff_t.
5362 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5363 Back then I didn't know that the Emacs coding style prefers signed int.
5364 Also, in the meantime I found a few more instances where arguments
5365 were being counted with int, which may truncate counts on 64-bit
5366 machines, or EMACS_INT, which may be unnecessarily wide.
5367 * lisp.h (struct Lisp_Subr.function.aMANY)
5368 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5369 Arg counts are now ptrdiff_t, not size_t.
5370 All variadic functions and their callers changed accordingly.
5371 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5372 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5373 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5374 * callint.c (Fcall_interactively): Check arg count for overflow,
5375 to avoid potential buffer overrun. Use signed char, not 'int',
5376 for 'varies' array, so that we needn't bother to check its size
5377 calculation for overflow.
5378 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5379 * eval.c (apply_lambda):
5380 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5381 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5382 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5384 * callint.c (Fcall_interactively): Don't use index var as event count.
5386 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5387 * mem-limits.h (SIZE): Remove; no longer used.
5389 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5391 Remove unnecessary casts.
5392 * xterm.c (x_term_init):
5393 * xfns.c (x_set_border_pixel):
5394 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5395 These aren't needed now that we assume ANSI C.
5397 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5398 It's more likely to cause problems (due to unsigned overflow)
5401 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5403 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5405 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5407 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5409 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5411 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5413 GLYPH_CODE_FACE returns EMACS_INT, not int.
5414 * dispextern.h (merge_faces):
5415 * xfaces.c (merge_faces):
5416 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5417 Don't assume EMACS_INT fits in int.
5419 * character.h (CHAR_VALID_P): Remove unused parameter.
5420 * fontset.c, lisp.h, xdisp.c: All uses changed.
5422 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5424 * fns.c (concat): Minor tuning based on overflow analysis.
5425 This doesn't fix any bugs. Use int to hold character, instead
5426 of constantly refetching from Emacs object. Use XFASTINT, not
5427 XINT, for value known to be a character. Don't bother comparing
5428 a single byte to 0400, as it's always less.
5430 * floatfns.c (Fexpt):
5431 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5433 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5436 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5438 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5439 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5440 incorrectly succeed when S was a string, because 4294967386 was
5441 truncated before it was used.
5443 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5444 Otherwise, an out-of-range integer could cause undefined behavior
5447 * composite.c: Use int, not EMACS_INT, for characters.
5448 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5449 EMACS_INT, for values that are known to be in character range.
5450 This doesn't fix any bugs but is the usual style inside Emacs and
5451 may generate better code on 32-bit machines.
5453 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5454 This is for reasons similar to the recent CHAR_STRING fix.
5455 * charset.c (Fencode_char): Check that character arg is actually
5456 a character. Pass an int to ENCODE_CHAR.
5457 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5458 wider than 'int', as a compile-time check to prevent future regressions
5461 * character.c (char_string): Remove unnecessary casts.
5463 Make sure a 64-bit char is never passed to CHAR_STRING.
5464 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5465 by silently ignoring the top 32 bits, allowing some values
5466 that were far too large to be valid characters.
5467 * character.h: Include <verify.h>.
5468 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5469 arguments are no wider than unsigned, as a compile-time check
5470 to prevent future regressions in this area.
5472 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5473 (Fsubst_char_in_region):
5475 * xdisp.c (decode_mode_spec_coding):
5476 Adjust to CHAR_STRING's new requirement.
5477 * editfns.c (Finsert_char, Fsubst_char_in_region):
5478 * fns.c (concat): Check that character args are actually
5479 characters. Without this test, these functions did the wrong
5480 thing with wildly out-of-range values on 64-bit hosts.
5482 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5483 These casts should not be needed on 32-bit hosts, either.
5484 * keyboard.c (read_char):
5485 * lread.c (Fload): Remove casts to unsigned.
5487 * lisp.h (UNSIGNED_CMP): New macro.
5488 This fixes comparison bugs on 64-bit hosts.
5489 (ASCII_CHAR_P): Use it.
5490 * casefiddle.c (casify_object):
5491 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5492 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5493 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5494 * dispextern.h (FACE_FROM_ID):
5495 * keyboard.c (read_char): Use UNSIGNED_CMP.
5497 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5498 not to EMACS_INT, to avoid GCC warning.
5500 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5502 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5503 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5504 isn't needed on 32-bit machines.
5506 * buffer.c (Fgenerate_new_buffer_name):
5507 Use EMACS_INT for count, not int.
5508 (advance_to_char_boundary): Return EMACS_INT, not int.
5510 * data.c (Qcompiled_function): Now static.
5512 * window.c (window_body_lines): Now static.
5514 * image.c (gif_load): Rename local to avoid shadowing.
5516 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5517 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5518 * alloc.c (make_save_value): Integer argument is now of type
5520 (mark_object): Use ptrdiff_t, not int.
5521 * lisp.h (pD): New macro.
5522 * print.c (print_object): Use it.
5524 * alloc.c: Use EMACS_INT, not int, to count objects.
5525 (total_conses, total_markers, total_symbols, total_vector_size)
5526 (total_free_conses, total_free_markers, total_free_symbols)
5527 (total_free_floats, total_floats, total_free_intervals)
5528 (total_intervals, total_strings, total_free_strings):
5529 Now EMACS_INT, not int. All uses changed.
5530 (Fgarbage_collect): Compute overall total using a double, so that
5531 integer overflow is less likely to be a problem. Check for overflow
5532 when converting back to an integer.
5533 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5534 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5535 These were 'int' variables that could overflow on 64-bit hosts;
5536 they were never used, so remove them instead of repairing them.
5537 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5538 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5539 Previously, this ceilinged at INT_MAX, but that doesn't work on
5541 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5543 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5544 (allocate_vectorlike): Check for ptrdiff_t overflow.
5545 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5546 when a (possibly-narrower) signed value would do just as well.
5547 We prefer using signed arithmetic, to avoid comparison confusion.
5549 * alloc.c: Catch some string size overflows that we were missing.
5550 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5551 for convenience in STRING_BYTES_MAX.
5552 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5553 The definition here is exact; the one in lisp.h was approximate.
5554 (allocate_string_data): Check for string overflow. This catches
5555 some instances we weren't catching before. Also, it catches
5556 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5557 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5558 and ptrdiff_t and EMACS_INT are both 64 bits.
5560 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5561 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5562 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5564 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5566 * alloc.c (Fmake_string): Check for out-of-range init.
5568 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5570 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5572 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5574 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5575 xg_get_default_scrollbar_width.
5577 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5578 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5579 (style_changed_cb): Call update_theme_scrollbar_width and call
5580 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5581 all frames (Bug#8505).
5582 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5583 Call gtk_window_set_resizable if HAVE_GTK3.
5584 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5585 and height if HAVE_GTK3 (Bug#8505).
5586 (scroll_bar_width_for_theme): New variable.
5587 (update_theme_scrollbar_width): New function.
5588 (xg_get_default_scrollbar_width): Move code to
5589 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5590 (xg_initialize): Call update_theme_scrollbar_width.
5592 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5594 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5596 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5598 * frame.c (make_frame): Call other_buffer_safely instead of
5601 * window.c (temp_output_buffer_show): Call display_buffer with
5602 second argument Vtemp_buffer_show_specifiers and reset latter
5603 immediately after the call.
5604 (Vtemp_buffer_show_specifiers): New variable.
5605 (auto_window_vscroll_p, next_screen_context_lines)
5606 (Vscroll_preserve_screen_position): Remove leading asterisks from
5609 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5611 Fix minor problems found by GCC 4.6.0 static checking.
5612 * buffer.c (Qclone_number): Remove for now, as it's unused.
5613 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5614 (record_buffer): Remove unused local.
5615 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5616 (set_frame_buffer_list): Remove; unused.
5617 * frame.h (other_visible_frames): Remove decl.
5618 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5619 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5620 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5622 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5623 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5624 Define only if HAVE_GPM.
5625 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5626 (update_hints_inhibit): Remove; never set. All uses removed.
5627 * widgetprv.h (emacsFrameClassRec): Remove decl.
5628 * window.c (delete_deletable_window): Now returns void, since it
5629 wasn't returning anything.
5630 (compare_window_configurations): Remove unused locals.
5631 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5632 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5633 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5634 the same widths as pointers. This follows up on the 2011-05-06 patch.
5635 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5636 * xterm.h: Likewise.
5637 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5639 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5641 * makefile.w32-in: Update dependencies.
5642 (LISP_H): Add lib/intprops.h.
5644 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5646 * image.c (gif_load): Add animation frame delay to the metadata.
5647 (syms_of_image): Use DEFSYM. New symbol `delay'.
5649 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5651 * window.c (delete_deletable_window): Re-add.
5652 (Fset_window_configuration): Rewrite to handle dead buffers and
5653 consequently deletable windows.
5654 (window_tree, Fwindow_tree): Remove. Supply functionality in
5656 (compare_window_configurations): Simplify code.
5658 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5660 * image.c (imagemagick_load_image): Fix type mismatch.
5661 (Fimagemagick_types): Likewise.
5663 * window.h (replace_buffer_in_windows): Declare.
5665 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5667 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5668 Qclone_number. Remove external declaration of Qdelete_window.
5669 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5671 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5672 Run Qbuffer_list_update_hook if allowed.
5673 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5674 buffer list implementation.
5675 (other_buffer_safely): New function.
5676 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5677 calls to replace_buffer_in_windows and
5678 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5680 (record_buffer): Inhibit quitting and rewrite using quittable
5681 functions. Run Qbuffer_list_update_hook if allowed.
5682 (Frecord_buffer, Funrecord_buffer): New functions.
5683 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5684 Move switch-to-buffer to window.el.
5685 (bury-buffer): Move to window.el.
5686 (Vbuffer_list_update_hook): New variable.
5688 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5691 * window.h (resize_frame_windows): Move up in code.
5692 (Fwindow_frame): Remove EXFUN.
5693 (replace_buffer_in_all_windows): Remove prototype.
5694 (replace_buffer_in_windows_safely): Add prototype.
5696 * window.c: Declare Qdelete_window static again. Move down
5697 declaration of select_count.
5698 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5699 (Fother_window): Move to window.el.
5700 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5701 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5702 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5704 (replace_buffer_in_windows): Implement by calling
5705 Qreplace_buffer_in_windows.
5706 (replace_buffer_in_all_windows): Remove with some functionality
5707 moved into replace_buffer_in_windows_safely.
5708 (replace_buffer_in_windows_safely): New function.
5709 (select_window_norecord, select_frame_norecord): Move in front
5710 of run_window_configuration_change_hook. Remove now obsolete
5712 (Fset_window_buffer): Rewrite doc-string.
5713 Call Qrecord_window_buffer.
5714 (keys_of_window): Move binding for other-window to window.el.
5716 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5718 * dispextern.h (struct image): Replace data member, whose int_val
5719 and ptr_val fields were not used by anything, with a single
5722 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5723 (gif_clear_image, gif_load, imagemagick_load_image)
5724 (gs_clear_image, gs_load): Callers changed.
5726 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5728 * buffer.h: Include <time.h>, for time_t.
5729 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5731 Fix minor problems found by static checking.
5733 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5735 Make identifiers static if they are not used in other modules.
5736 * data.c (Qcompiled_function, Qframe, Qvector):
5737 * image.c (QimageMagick, Qsvg):
5738 * minibuf.c (Qmetadata):
5739 * window.c (resize_window_check, resize_root_window): Now static.
5740 * window.h (resize_window_check, resize_root_window): Remove decls.
5742 * window.c (window_deletion_count, delete_deletable_window):
5744 (window_body_lines): Now static.
5745 (Fdelete_other_windows_internal): Mark vars as initialized.
5746 Make sure 'resize_failed' is initialized.
5747 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5748 (resize_window_apply): Remove unused local.
5749 * window.h (delete_deletable_window): Remove decl.
5751 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5752 (imagemagick_load_image): Fix pointer signedness problem by changing
5753 last arg from unsigned char * to char *. All uses changed.
5754 Also, fix a local for similar reasons.
5755 Remove unused locals. Remove locals to avoid shadowing.
5756 (fn_rsvg_handle_free): Remove; unused.
5757 (svg_load, svg_load_image): Fix pointer signedness problem.
5758 (imagemagick_load_image): Don't use garbage pointer image_wand.
5760 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5762 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5764 * image.c (gif_load): Fix omitted cast error introduced by
5767 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5769 * window.h (resize_proportionally, orig_total_lines)
5770 (orig_top_line): Remove from window structure.
5771 (set_window_height, set_window_width, change_window_heights)
5772 (Fdelete_window): Remove prototypes.
5773 (resize_frame_windows): Remove duplicate declaration.
5775 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5777 * window.h (resize_frame_windows, resize_window_check)
5778 (delete_deletable_window, resize_root_window)
5779 (resize_frame_windows): Declare prototypes.
5781 * window.c (resize_window_apply): Make definition be "static" to
5782 match the prototype.
5784 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5786 * window.c: Remove declarations of Qwindow_size_fixed,
5787 window_min_size_1, window_min_size_2, window_min_size,
5788 size_window, window_fixed_size_p, enlarge_window, delete_window.
5789 Remove static from declaration of Qdelete_window, it's
5790 temporarily needed by Fbury_buffer.
5791 (replace_window): Don't assign orig_top_line and
5793 (Fdelete_window, delete_window): Remove. Window deletion is
5794 handled by window.el.
5795 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5796 Replace Fdelete_window calls with calls to Qdelete_window.
5797 (Fdelete_other_windows): Remove. Deleting other windows is
5798 handled by window.el.
5799 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5800 handled in window.el.
5801 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5802 Window minimum sizes are handled in window.el.
5803 (shrink_windows, size_window, set_window_height)
5804 (set_window_width, change_window_heights, window_height)
5805 (window_width, CURBEG, CURSIZE, enlarge_window)
5806 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5807 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5808 handled in window.el.
5809 (make_dummy_parent): Rename to make_parent_window and give it a
5810 second argument horflag.
5811 (make_window): Don't set resize_proportionally any more.
5812 (Fsplit_window): Remove. Windows are split in window.el.
5813 (save_restore_action, save_restore_orig_size)
5814 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5815 Resize mini windows in window.el.
5816 (grow_mini_window, shrink_mini_window): Implement by calling
5817 Qresize_root_window_vertically, resize_window_check and
5818 resize_window_apply.
5819 (saved_window, Fset_window_configuration, save_window_save):
5820 Do not handle orig_top_line, orig_total_lines, and
5821 resize_proportionally.
5822 (window_min_height, window_min_width): Move to window.el.
5823 (keys_of_window): Move bindings for delete-other-windows,
5824 split-window, delete-window and enlarge-window to window.el.
5826 * buffer.c: Temporarily extern Qdelete_window.
5827 (Fbury_buffer): Temporarily call Qdelete_window instead of
5828 Fdelete_window (Fbury_buffer will move to window.el soon).
5830 * frame.c (set_menu_bar_lines_1): Remove code handling
5831 orig_top_line and orig_total_lines.
5833 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5834 set_window_height but set heights directly.
5835 (change_frame_size_1): Use resize_frame_windows.
5837 * xdisp.c (init_xdisp): Don't use set_window_height but set
5840 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5841 Use resize_frame_windows instead of change_window_heights and run
5842 run_window_configuration_change_hook.
5844 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5845 instead of change_window_heights and run
5846 run_window_configuration_change_hook.
5848 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5850 * window.c (replace_window): Rename second argument REPLACEMENT to
5851 NEW. New third argument SETFLAG. Rewrite.
5852 (delete_window, make_dummy_parent): Call replace_window with
5854 (window_list_1): Move down in code.
5855 (run_window_configuration_change_hook): Move set_buffer part
5856 before select_frame_norecord part in order to unwind correctly.
5857 Rename count1 to count.
5858 (recombine_windows, delete_deletable_window, resize_root_window)
5859 (Fdelete_other_windows_internal)
5860 (Frun_window_configuration_change_hook, make_parent_window)
5861 (resize_window_check, resize_window_apply, Fresize_window_apply)
5862 (resize_frame_windows, Fsplit_window_internal)
5863 (Fdelete_window_internal, Fresize_mini_window_internal):
5865 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5867 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5869 * window.h (window): Add some new members to window structure -
5870 normal_lines, normal_cols, new_total, new_normal, clone_number,
5871 splits, nest, prev_buffers, next_buffers.
5872 (WINDOW_TOTAL_SIZE): Move here from window.c.
5873 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5875 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5877 (make_dummy_parent): Set new members of windows structure.
5878 (make_window): Move down in code. Handle new members of window
5880 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5881 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5882 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5883 (Fset_window_prev_buffers, Fwindow_next_buffers)
5884 (Fset_window_next_buffers, Fset_window_clone_number):
5886 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5887 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5889 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5890 Argument WINDOW can be now internal window too.
5891 (Fwindow_use_time): Move up in code.
5892 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5894 (Fset_window_configuration, saved_window)
5895 (Fcurrent_window_configuration, save_window_save): Handle new
5896 members of window structure.
5897 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5898 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5899 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5900 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5901 Qget_mru_window, Qresize_root_window,
5902 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5903 Qauto_buffer_name; staticpro them.
5905 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5907 * window.c (Fwindow_total_size, Fwindow_left_column)
5908 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5909 (Fwindow_list_1): New functions.
5910 (window_box_text_cols): Replace with window_body_cols.
5911 (Fwindow_width, Fscroll_left, Fscroll_right):
5912 Use window_body_cols instead of window_box_text_cols.
5913 (delete_window, Fset_window_configuration):
5914 Call delete_all_subwindows with window as argument.
5915 (delete_all_subwindows): Take a window as argument and not a
5917 (window_loop): Remove handling of GET_LRU_WINDOW and
5919 (Fget_lru_window, Fget_largest_window): Move to window.el.
5921 * window.h: Extern window_body_cols instead of
5922 window_box_text_cols. delete_all_subwindows now takes a
5923 Lisp_Object as argument.
5925 * indent.c (compute_motion, Fcompute_motion):
5926 Use window_body_cols instead of window_box_text_cols.
5928 * frame.c (delete_frame): Call delete_all_subwindows with root
5931 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5933 * fns.c (Fputhash): Document return value.
5935 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5937 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5939 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5941 Cons<->int and similar integer overflow fixes (Bug#8794).
5943 Check for overflow when converting integer to cons and back.
5944 * charset.c (Fdefine_charset_internal, Fdecode_char):
5945 Use cons_to_unsigned to catch overflow.
5946 (Fencode_char): Use INTEGER_TO_CONS.
5947 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5948 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5949 * data.c (long_to_cons, cons_to_long): Remove.
5950 (cons_to_unsigned, cons_to_signed): New functions.
5951 These signal an error for invalid or out-of-range values.
5952 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5953 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5954 * font.c (Ffont_variation_glyphs):
5955 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5956 * lisp.h: Include <intprops.h>.
5957 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5958 (cons_to_signed, cons_to_unsigned): New decls.
5959 (long_to_cons, cons_to_long): Remove decls.
5960 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5961 (Fprimitive_undo): Use CONS_TO_INTEGER.
5962 * xfns.c (Fx_window_property): Likewise.
5963 * xselect.c: Include <limits.h>.
5964 (x_own_selection, selection_data_to_lisp_data):
5965 Use INTEGER_TO_CONS.
5966 (x_handle_selection_request, x_handle_selection_clear)
5967 (x_get_foreign_selection, Fx_disown_selection_internal)
5968 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5969 (lisp_data_to_selection_data): Use cons_to_unsigned.
5970 (x_fill_property_data): Use cons_to_signed.
5971 Report values out of range.
5973 Check for buffer and string overflow more precisely.
5974 * buffer.h (BUF_BYTES_MAX): New macro.
5975 * lisp.h (STRING_BYTES_MAX): New macro.
5976 * alloc.c (Fmake_string):
5977 * character.c (string_escape_byte8):
5978 * coding.c (coding_alloc_by_realloc):
5979 * doprnt.c (doprnt):
5980 * editfns.c (Fformat):
5982 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5983 since they may not be the same number.
5984 * editfns.c (Finsert_char):
5985 * fileio.c (Finsert_file_contents):
5986 Likewise for BUF_BYTES_MAX.
5988 * image.c: Use ptrdiff_t, not int, for sizes.
5989 (slurp_file): Switch from int to ptrdiff_t.
5991 (slurp_file): Check that file size fits in both size_t (for
5992 malloc) and ptrdiff_t (for sanity and safety).
5994 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5995 if b->modtime has its maximal value.
5997 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5999 Don't assume time_t can fit into int.
6000 * buffer.h (struct buffer.modtime): Now time_t, not int.
6001 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6002 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6004 Minor fixes for signed vs unsigned integers.
6005 * character.h (MAYBE_UNIFY_CHAR):
6006 * charset.c (maybe_unify_char):
6007 * keyboard.c (read_char, reorder_modifiers):
6008 XINT -> XFASTINT, since the integer must be nonnegative.
6009 * ftfont.c (ftfont_spec_pattern):
6010 * keymap.c (access_keymap, silly_event_symbol_error):
6011 XUINT -> XFASTINT, since the integer must be nonnegative.
6012 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6013 since it makes no difference and we prefer signed.
6014 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6015 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6018 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6020 * window.h (Fwindow_frame): Declare.
6022 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6024 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6025 (SPARE_MEMORY): Always define.
6026 (LARGE_REQUEST): Remove.
6027 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6029 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6031 * lisp.h: Move EXFUNS for Fframe_root_window,
6032 Fframe_first_window and Fset_frame_selected_window to window.h.
6034 * window.h: Move EXFUNS for Fframe_root_window,
6035 Fframe_first_window and Fset_frame_selected_window here from
6038 * frame.c (Fwindow_frame, Fframe_first_window)
6039 (Fframe_root_window, Fframe_selected_window)
6040 (Fset_frame_selected_window): Move to window.c.
6041 (Factive_minibuffer_window): Move to minibuf.c.
6042 (Fother_visible_frames_p): New function.
6044 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6046 * window.c (decode_window, decode_any_window): Move up in code.
6047 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6048 (inhibit_frame_unsplittable): Remove unused variable.
6049 (Fwindow_buffer): Move up and rewrite doc-string.
6050 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6051 (Fwindow_prev): New functions.
6052 (Fwindow_frame): Move here from frame.c. Accept any window as
6054 (Fframe_root_window, Fframe_first_window)
6055 (Fframe_selected_window): Move here from frame.c. Accept frame
6056 or arbitrary window as argument. Update doc-strings.
6057 (Fminibuffer_window): Move up in code.
6058 (Fwindow_minibuffer_p): Move up in code and simplify.
6059 (Fset_frame_selected_window): Move here from frame.c.
6061 (Fselected_window, select_window, Fselect_window): Move up in
6062 code. Minor doc-string fixes.
6064 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6066 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6067 Do not assume that spare memory exists; that assumption is valid
6068 only if SYSTEM_MALLOC.
6069 (LARGE_REQUEST): New macro, so that the issue of large requests
6070 is separated from the issue of spare memory.
6072 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6074 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6077 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6079 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6082 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6084 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6086 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6088 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6089 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6091 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6093 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6095 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6097 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6098 (x_clipboard_manager_save): Add return value.
6099 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6101 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6102 Obey Vx_select_enable_clipboard_manager. Catch errors in
6103 x_clipboard_manager_save (Bug#8779).
6104 (Vx_select_enable_clipboard_manager): New variable.
6105 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6107 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6109 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6111 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6113 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6114 in the current matrix if keep_current_p is non-zero.
6116 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6118 * bidi.c (bidi_level_of_next_char): Fix last change.
6120 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6122 Support bidi reordering of text covered by display properties.
6124 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6125 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6126 (bidi_cache_search, bidi_cache_iterator_state)
6127 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6128 (bidi_level_of_next_char, bidi_move_to_visually_next):
6129 Support character positions inside a run of characters covered by a
6131 (bidi_paragraph_init, bidi_resolve_explicit_1)
6132 (bidi_level_of_next_char): Call bidi_fetch_char and
6133 bidi_fetch_char_advance instead of FETCH_CHAR and
6135 (bidi_init_it): Initialize new members.
6136 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6138 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6139 instead of using explicit *_CHAR codes.
6140 (bidi_resolve_explicit, bidi_resolve_weak):
6141 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6142 bidirectional text is supported only in multibyte buffers.
6143 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6144 it to initialize the frame_window_p member of struct bidi_it.
6145 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6146 (bidi_resolve_explicit, bidi_resolve_weak)
6147 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6148 bidi_it->nchars is non-positive.
6149 (bidi_level_of_next_char): Don't try to lookup the cache for the
6150 next/previous character if nothing is cached there yet, or if we
6151 were just reseat()'ed to a new position.
6153 * xdisp.c (set_cursor_from_row): Set start and stop points
6154 according to the row's direction when priming the loop that looks
6155 for the glyph on which to display cursor.
6156 (single_display_spec_intangible_p): Function deleted.
6157 (display_prop_intangible_p): Reimplement to call
6158 handle_display_spec instead of single_display_spec_intangible_p.
6159 Accept 3 additional arguments needed by handle_display_spec.
6160 This fixes incorrect cursor motion across display property with complex
6161 values: lists, `(when COND...)' forms, etc.
6162 (single_display_spec_string_p): Support property values that are
6163 lists with the argument STRING its top-level element.
6164 (display_prop_string_p): Fix the condition for processing a
6165 property that is a list to be consistent with handle_display_spec.
6166 (handle_display_spec): New function, refactored from the
6167 last portion of handle_display_prop.
6168 (compute_display_string_pos): Accept additional argument
6169 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6170 value of a `display' property is a "replacing spec".
6171 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6172 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6173 the display property, but just return a value indicating whether
6174 the display property will replace the characters it covers.
6175 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6176 frame_window_p members of struct bidi_it.
6177 (compute_display_string_pos, compute_display_string_end):
6179 (push_it): Accept second argument POSITION, where pop_it should
6180 jump to continue iteration.
6181 (reseat_1): Initialize bidi_it.disp_pos.
6183 * keyboard.c (adjust_point_for_property): Adjust the call to
6184 display_prop_intangible_p to its new signature.
6186 * dispextern.h (struct bidi_it): New member frame_window_p.
6187 (bidi_init_it): Update prototypes.
6188 (display_prop_intangible_p): Update prototype.
6189 (compute_display_string_pos, compute_display_string_end):
6191 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6194 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6196 Malloc failure behavior now depends on size of allocation.
6197 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6198 * lisp.h: Change signatures accordingly.
6199 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6200 All callers changed. (Bug#8762)
6202 * gnutls.c: Use Emacs's memory allocators.
6203 Without this change, the gnutls library would invoke malloc etc.
6204 directly, which causes problems on non-SYNC_INPUT hosts, and which
6205 runs afoul of improving memory_full behavior. (Bug#8761)
6206 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6207 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6208 xfree instead of the default malloc, realloc, free.
6209 (Fgnutls_boot): No need to check for memory allocation failure,
6210 since xmalloc does that for us.
6212 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6213 * category.c (hash_get_category_set):
6214 * ccl.c (ccl_driver):
6215 * charset.c (Fdefine_charset_internal):
6216 * charset.h (struct charset.hash_index):
6217 * composite.c (get_composition_id, gstring_lookup_cache)
6218 (composition_gstring_put_cache):
6219 * composite.h (struct composition.hash_index):
6220 * dispextern.h (struct image.hash):
6221 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6222 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6223 (hashfn_equal, hashfn_user_defined, make_hash_table)
6224 (maybe_resize_hash_table, hash_lookup, hash_put)
6225 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6226 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6227 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6228 * image.c (make_image, search_image_cache, lookup_image)
6229 (xpm_put_color_table_h):
6230 * lisp.h (struct Lisp_Hash_Table):
6231 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6232 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6233 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6234 * alloc.c (allocate_vectorlike):
6235 Check for overflow in vector size calculations.
6236 * ccl.c (ccl_driver):
6237 Check for overflow when converting EMACS_INT to int.
6238 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6239 need to be updated by these changes.
6240 * fns.c (make_hash_table, maybe_resize_hash_table):
6241 Check for integer overflow with large hash tables.
6242 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6243 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6244 (SXHASH_REDUCE): New macro.
6245 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6246 Use it instead of discarding useful hash info with large hash values.
6247 (sxhash_float): New function.
6248 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6249 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6250 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6251 Rewrite to use FIXNUM_BITS, as this simplifies things.
6252 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6253 Adjust signatures to match updated version of code.
6254 (consing_since_gc): Now EMACS_INT, since a single hash table can
6255 use more than INT_MAX bytes.
6257 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6259 Make it possible to build with GCC-4.6+ -O2 -flto.
6261 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6263 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6265 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6266 Call minibuffer-inactive-mode.
6268 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6270 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6271 Update dependencies.
6273 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6275 * data.c (init_data): Remove code for UTS, this system is not
6278 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6280 Don't force ./temacs to start in terminal mode.
6282 * frame.c (make_initial_frame): Initialize faces in all cases, not
6283 only when CANNOT_DUMP is defined.
6284 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6286 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6288 * dispnew.c (add_window_display_history): Use const for the string
6289 pointer. Remove declaration, not needed.
6291 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6293 Use 'inline', not 'INLINE'.
6294 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6295 * alloc.c, fontset.c (INLINE): Remove.
6296 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6297 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6298 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6299 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6300 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6302 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6304 Make it possible to run ./temacs.
6306 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6307 syms_of_callproc does the same thing. Remove test for
6308 "initialized", do it in the caller.
6309 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6311 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6313 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6314 (read_minibuf): Use get_minibuffer.
6315 (syms_of_minibuf): Use DEFSYM.
6316 (Qmetadata): New var.
6317 * data.c (Qbuffer): Don't make it static.
6318 (syms_of_data): Use DEFSYM.
6320 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6322 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6323 (CCL_CODE_MIN): New macro.
6325 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6327 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6329 * eval.c (Qdebug): Now static.
6330 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6331 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6332 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6334 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6336 * image.c: Various fixes to ImageMagick code comments.
6337 (Fimagemagick_types): Doc fix.
6339 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6341 Minor fixes prompted by GCC 4.6.0 warnings.
6343 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6345 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6346 (x_clipboard_manager_save_all): Move extern decl to ...
6347 * xterm.h: ... here, so that it can be checked for consistency.
6349 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6351 * xselect.c (x_clipboard_manager_save_frame)
6352 (x_clipboard_manager_save_all): New functions.
6353 (Fx_clipboard_manager_save): Lisp function deleted.
6355 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6356 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6358 * xterm.h: Update prototype.
6360 2011-05-28 William Xu <william.xwl@gmail.com>
6362 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6365 2011-05-28 Jim Meyering <meyering@redhat.com>
6367 Avoid a sign-extension bug in crypto_hash_function.
6368 * fns.c (to_uchar): Define.
6369 (crypto_hash_function): Use it to convert some newly-signed
6370 variables to unsigned, to avoid sign-extension bugs. For example,
6371 without this change, (md5 "truc") would evaluate to
6372 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6373 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6374 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6376 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6378 Integer overflow fixes.
6380 * dbusbind.c: Serial number integer overflow fixes.
6381 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6382 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6383 to hold a serial number that is too large for a fixnum.
6384 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6385 Check for serial numbers out of range. Decode any serial number
6386 that was so large that it became a float. (Bug#8722)
6388 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6389 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6390 Use XFASTINT rather than XUINT when numbers are nonnegative.
6391 (xd_append_arg, Fdbus_method_return_internal):
6392 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6393 arguments, check that Lisp number is nonnegative, rather than
6394 silently wrapping negative numbers around. (Bug#8722)
6395 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6398 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6400 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6402 ccl: Add integer overflow checks.
6403 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6404 (IN_INT_RANGE): New macros.
6405 (ccl_driver): Use them to check for integer overflow when
6406 decoding a CCL program. Many of the new checks are whether XINT (x)
6407 fits in int; it doesn't always, on 64-bit hosts. The new version
6408 doesn't catch all possible integer overflows, but it's an
6409 improvement. (Bug#8719)
6411 * alloc.c (make_event_array): Use XINT, not XUINT.
6412 There's no need for unsigned here.
6414 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6415 This follows up to the 2011-05-06 change that substituted uintptr_t
6416 for EMACS_INT. This case wasn't caught back then.
6418 Rework Fformat to avoid integer overflow issues.
6419 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6420 now (part of C89). Include <verify.h>.
6421 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6422 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6423 (Fformat): Avoid the prepass trying to compute sizes; it was only
6424 approximate and thus did not catch overflow reliably. Instead, walk
6425 through the format just once, formatting and computing sizes as we go,
6426 checking for integer overflow at every step, and allocating a larger
6427 buffer as needed. Keep track separately whether the format is
6428 multibyte. Keep only the most-recently calculated precision, rather
6429 than them all. Record whether each argument has been converted to
6430 string. Use EMACS_INT, not int, for byte and char and arg counts.
6431 Support field widths and precisions larger than INT_MAX. Avoid
6432 sprintf's undefined behavior with conversion specifications such as %#d
6433 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6434 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6435 formatting out-of-range floating point numbers with int
6438 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6440 * data.c: Avoid integer truncation in expressions involving floats.
6441 * data.c: Include <intprops.h>.
6442 (arith_driver): When there's an integer overflow in an expression
6443 involving floating point, convert the integers to floating point
6444 so that the resulting value does not suffer from catastrophic
6445 integer truncation. For example, on a 64-bit host (* 4
6446 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6447 Do not rely on undefined behavior after integer overflow.
6449 merge count_size_as_multibyte, parse_str_to_multibyte
6450 * character.c, character.h (count_size_as_multibyte):
6451 Rename from parse_str_to_multibyte; all uses changed.
6452 Check for integer overflow.
6453 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6454 since it's now a duplicate of the other. This is more of
6455 a character than a buffer op, so better that it's in character.c.
6456 * fns.c, print.c: Adjust to above changes.
6458 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6460 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6462 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6464 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6465 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6466 (x_clipboard_manager_save): Now static.
6467 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6469 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6470 (crypto_hash_function): Now static.
6471 Fix pointer signedness problems. Avoid unnecessary initializations.
6473 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6475 * termhooks.h (Vselection_alist): Make it terminal-local.
6477 * terminal.c (create_terminal): Initialize it.
6479 * xselect.c: Support for clipboard managers.
6480 (Vselection_alist): Move to termhooks.h as terminal-local var.
6481 (LOCAL_SELECTION): New macro.
6482 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6483 (symbol_to_x_atom): Remove gratuitous arg.
6484 (x_handle_selection_request, lisp_data_to_selection_data)
6485 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6486 (x_own_selection, x_get_local_selection, x_convert_selection):
6487 New arg, specifying work frame. Use terminal-local Vselection_alist.
6488 (some_frame_on_display): Delete unused function.
6489 (Fx_own_selection_internal, Fx_get_selection_internal)
6490 (Fx_disown_selection_internal, Fx_selection_owner_p)
6491 (Fx_selection_exists_p): New optional frame arg.
6492 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6493 (x_handle_selection_clear): Don't treat other terminals with the
6494 same keyboard specially. Use the terminal-local Vselection_alist.
6495 (x_clear_frame_selections): Use Frun_hook_with_args.
6497 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6499 * xterm.h: Add support for those atoms.
6501 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6503 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6504 (converted_selections, conversion_fail_tag): New global variables.
6505 (x_selection_request_lisp_error): Free the above.
6506 (x_get_local_selection): Remove unnecessary code.
6507 (x_reply_selection_request): Args changed; handle arbitrary array
6508 of converted selections stored in converted_selections.
6509 Separate the XChangeProperty and SelectionNotify steps.
6510 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6511 (x_convert_selection): New function.
6512 (x_handle_selection_event): Simplify.
6513 (x_get_foreign_selection): Don't ignore incoming requests while
6514 waiting for an answer; this will fail when we implement
6515 SAVE_TARGETS, and seems unnecessary anyway.
6516 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6517 (Vx_sent_selection_functions): Doc fix.
6519 2011-05-26 Leo Liu <sdl.web@gmail.com>
6521 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6523 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6525 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6527 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6528 for fringe update if it has periodic bitmap.
6529 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6530 and fringe_bitmap_periodic_p.
6532 * fringe.c (get_fringe_bitmap_data): New function.
6533 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6534 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6535 row. Mark glyph row for fringe update if periodicity changed.
6537 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6538 for fringe update unless it has periodic bitmap.
6540 2011-05-25 Kenichi Handa <handa@m17n.org>
6542 * xdisp.c (get_next_display_element): Set correct it->face_id for
6543 a static composition.
6545 2011-05-24 Leo Liu <sdl.web@gmail.com>
6548 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6550 * fns.c (crypto_hash_function, Fsha1): New function.
6551 (Fmd5): Use crypto_hash_function.
6552 (syms_of_fns): Add Ssha1.
6554 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6556 * gnutls.c: Remove unused macros.
6557 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6558 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6559 Remove macros that are defined and never used.
6560 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6562 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6564 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6565 (Fx_get_selection_internal): Minor cleanup.
6566 (Fx_own_selection_internal): Rename arguments for consistency with
6569 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6571 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6573 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6575 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6577 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6579 * dispnew.c (scrolling_window): Don't exclude the case that the
6580 last enabled row in the desired matrix touches the bottom boundary.
6582 2011-05-21 Glenn Morris <rgm@gnu.org>
6584 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6585 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6586 and add some more files.
6588 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6590 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6591 report_file_error introduced by the change from 2011-05-07.
6593 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6595 * systime.h (Time): Define only if emacs is defined.
6596 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6597 where the include path doesn't have X11/X.h by default. See
6598 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6600 2011-05-20 Kenichi Handa <handa@m17n.org>
6602 * composite.c (find_automatic_composition): Fix previous change.
6604 2011-05-20 Glenn Morris <rgm@gnu.org>
6606 * lisp.mk: New file, split from Makefile.in.
6607 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6608 (shortlisp): Remove.
6609 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6611 2011-05-19 Glenn Morris <rgm@gnu.org>
6613 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6614 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6615 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6616 (lisp): Set the order to that of loadup.el.
6617 (shortlisp): Make it a copy of $lisp.
6618 (SOME_MACHINE_LISP): Remove.
6619 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6620 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6622 2011-05-18 Kenichi Handa <handa@m17n.org>
6624 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6625 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6626 (find_automatic_composition): Mostly rewrite for efficiency.
6628 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6630 * makefile.w32-in: Update dependencies.
6632 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6634 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6635 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6637 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6639 Fix some integer overflow issues, such as string length overflow.
6641 * insdel.c (count_size_as_multibyte): Check for string overflow.
6643 * character.c (lisp_string_width): Check for string overflow.
6644 Use EMACS_INT, not int, for string indexes and lengths; in
6645 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6646 the resulting string length overflows an EMACS_INT; instead,
6647 report a string overflow if no precision given. When checking for
6648 precision exhaustion, use a check that cannot possibly have
6649 integer overflow. (Bug#8675)
6650 * character.h (lisp_string_width): Adjust to new signature.
6652 * alloc.c (string_overflow): New function.
6653 (Fmake_string): Use it. This doesn't change behavior, but saves
6654 a few bytes and will simplify future changes.
6655 * character.c (string_escape_byte8): Likewise.
6656 * lisp.h (string_overflow): New decl.
6658 Fixups, following up to the user-interface timestamp change.
6659 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6660 for UI timestamps, instead of unsigned long.
6661 * msdos.c (mouse_get_pos): Likewise.
6662 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6663 * w32gui.h (Time): Define by including "systime.h" rather than by
6664 declaring it ourselves. (Bug#8664)
6666 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6667 * image.c (clear_image_cache): Likewise.
6669 * term.c (term_mouse_position): Don't assume time_t wraparound.
6671 Be more systematic about user-interface timestamps.
6672 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6673 and sometimes 'EMACS_UINT', to represent these timestamps.
6674 This change causes it to use 'Time' uniformly, as that's what X uses.
6675 This makes the code easier to follow, and makes it easier to catch
6676 integer overflow bugs such as Bug#8664.
6677 * frame.c (Fmouse_position, Fmouse_pixel_position):
6678 Use Time, not unsigned long, for user-interface timestamps.
6679 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6680 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6681 * keyboard.h (last_event_timestamp): Likewise.
6682 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6683 * menu.h (xmenu_show): Likewise.
6684 * term.c (term_mouse_position): Likewise.
6685 * termhooks.h (struct input_event.timestamp): Likewise.
6686 (struct terminal.mouse_position_hook): Likewise.
6687 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6688 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6689 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6690 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6692 * menu.h, termhooks.h: Include "systime.h", for Time.
6694 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6695 Don't assume that the difference between two unsigned long values
6696 can fit into an integer. At this point, we know button_down_time
6697 <= event->timestamp, so the difference must be nonnegative, so
6698 there's no need to cast the result if double-click-time is
6699 nonnegative, as it should be; check that it's nonnegative, just in
6700 case. This bug is triggered when events are more than 2**31 ms
6701 apart (about 25 days). (Bug#8664)
6703 * xselect.c (last_event_timestamp): Remove duplicate decl.
6704 (x_own_selection): Remove needless cast to unsigned long.
6706 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6707 that always fit in int. Use a sentinel instead of a counter, to
6708 avoid a temp and to allay GCC's concerns about possible int overflow.
6709 * frame.h (struct frame): Use int for menu_bar_items_used
6710 instead of EMACS_INT, since it always fits in int.
6712 * menu.c (grow_menu_items): Check for int overflow.
6714 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6716 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6717 Before, the code was not consistent. These values cannot exceed
6718 2**31 - 1 so there's no need to make them unsigned.
6719 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6720 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6721 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6723 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6725 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6726 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6727 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6728 presumably because the widths might not match.
6730 * window.c (size_window): Avoid needless test at loop start.
6732 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6734 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6736 2011-05-12 Drew Adams <drew.adams@oracle.com>
6738 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6740 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6742 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6743 `width' to `bar_area_x' and `bar_area_width', respectively.
6744 (x_scroll_run): Take account of fringe background extension.
6746 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6747 Rename local vars `left' and `width' to `bar_area_x' and
6748 `bar_area_width', respectively.
6749 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6750 background extension.
6752 2011-05-10 Jim Meyering <meyering@redhat.com>
6754 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6756 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6758 * image.c (Finit_image_library): Return t for built-in image types,
6759 like pbm and xbm. (Bug#8640)
6761 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6763 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6765 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6767 * w32console.c (Fset_screen_color): Doc fix.
6768 (Fget_screen_color): New function.
6769 (syms_of_ntterm): Defsubr it.
6771 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6772 unlink the temporary file if Fcall_process didn't create it in the
6774 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6775 child process will be redirected to a file specified with `:file'.
6776 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6777 cue to call_process_cleanup not to close that handle.
6779 2011-05-07 Ben Key <bkey76@gmail.com>
6781 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6782 one of two shell specific rules, either bootstrap-temacs-CMD or
6783 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6784 to the previous implementation of the bootstrap-temacs rule.
6785 The bootstrap-temacs-CMD rule is similar to the previous
6786 implementation of the bootstrap-temacs rule except that it
6787 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6790 These changes, along with some changes to nt/configure.bat,
6791 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6792 earlier fix to add support for --cflags and --ldflags options
6793 that include quotes so that it works whether make uses cmd or
6796 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6798 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6799 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6801 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6802 a string. Handle both cases.
6803 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6804 (Fdbus_register_method): Use Qinvalid_function.
6806 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6808 * makefile.w32-in: Update dependencies.
6809 (LISP_H): Add inttypes.h and stdin.h.
6810 (PROCESS_H): Add unistd.h.
6812 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6814 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6815 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6817 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6819 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6821 * term.c (vfatal): Remove stray call to va_end.
6822 It's not needed and the C Standard doesn't allow it here anyway.
6824 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6825 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6827 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6830 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6832 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6834 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6836 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6838 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6840 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6841 * charset.c (Fdefine_charset_internal): Don't initialize
6842 charset.code_space[15]. The value was garbage, on hosts with
6843 32-bit int (Bug#8600).
6845 * lread.c (read_integer): Be more consistent with string-to-number.
6846 Use string_to_number to do the actual conversion; this avoids
6847 rounding errors and fixes some other screwups. Without this fix,
6848 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6849 (digit_to_number): Move earlier, for benefit of read_integer.
6850 Return -1 if the digit is out of range for the base, -2 if it is
6851 not a digit in any supported base. (Bug#8602)
6853 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6855 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6856 to match comment at start of function. This also removes a
6857 GCC warning about overflow in a 32+64-bit port.
6859 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6861 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6862 Reported by Stefan Monnier in
6863 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6864 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6865 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6867 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6868 (EMACS_UINTPTR): Likewise, with uintptr_t.
6870 * lisp.h: Prefer 64-bit EMACS_INT if available.
6871 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6872 on 32-bit hosts that have 64-bit int, so that they can access
6874 However, temporarily disable this change unless the temporary
6875 symbol WIDE_EMACS_INT is defined.
6877 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6879 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6880 This removes an assumption that EMACS_INT and long are the same
6881 width as pointers. The assumption is true for Emacs porting targets
6882 now, but we want to make other targets possible.
6883 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6884 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6885 In the rest of the code, change types of integers that hold casted
6886 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6887 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6888 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6889 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6890 No need to cast type when ORing.
6891 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6892 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6893 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6894 assume EMACS_INT is the same width as char *.
6895 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6896 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6897 Remove no-longer-needed casts.
6898 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6899 (xg_tool_bar_help_callback, xg_make_tool_item):
6900 Use EMACS_INTPTR to hold an integer
6901 that will be cast to void *; this can avoid a GCC warning
6902 if EMACS_INT is not the same width as void *.
6903 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6904 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6905 (current_message_1, set_message_1):
6906 Use a local to convert to proper width without a cast.
6907 * xmenu.c (dialog_selection_callback): Likewise.
6909 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6910 Also, don't assume VALBITS / RAND_BITS is less than 5,
6911 and don't rely on undefined behavior when shifting a 1 left into
6913 * lisp.h (get_random): Change signature to match.
6915 * lread.c (hash_string): Use size_t, not int, for hash computation.
6916 Normally we prefer signed values; but hashing is special, because
6917 it's better to use unsigned division on hash table sizes so that
6918 the remainder is nonnegative. Also, size_t is the natural width
6919 for hashing into memory. The previous code used 'int', which doesn't
6920 retain enough info to hash well into very large tables.
6921 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6923 * dbusbind.c: Don't possibly lose pointer info when converting.
6924 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6925 Use XPNTR rather than XHASH, so that the high-order bits of
6926 the pointer aren't lost when converting through void *.
6928 * eval.c (Fautoload): Don't double-shift a pointer.
6930 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6932 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6934 * gnutls.c (DEF_GNUTLS_FN):
6935 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6937 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6939 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6942 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6944 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6945 New version that can reserve upto 2GB of heap space.
6947 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6949 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6951 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6953 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6954 `gnutls_certificate_set_x509_key_file'.
6956 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6958 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6959 Update dependencies.
6961 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6963 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6964 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6965 Remove unused parameter `fildes'.
6966 * process.c (read_process_output, send_process): Don't pass it.
6968 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6970 Fix previous change: the library cache is defined in w32.c.
6971 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6972 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6974 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6976 Implement dynamic loading of GnuTLS on Windows.
6978 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6979 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6980 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6983 * gnutls.c (Qgnutls_dll): Define.
6984 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6985 (gnutls_*): Declare function pointers.
6986 (init_gnutls_functions): New function to initialize function pointers.
6987 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6988 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6989 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6990 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6991 (emacs_gnutls_write, emacs_gnutls_read)
6992 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6993 (Fgnutls_available_p): New function.
6994 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6995 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6996 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6998 * image.c: Include w32.h.
6999 (Vimage_type_cache): Delete.
7000 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7001 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7002 (w32_delayed_load): Move to w32.c.
7004 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7006 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7007 (w32_delayed_load): Move from image.c. When loading a library, record
7008 its filename in the :loaded-from property of the library id.
7009 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7010 Initialize and staticpro them.
7011 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7013 * process.c: Include lisp.h before w32.h, not after.
7014 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7015 instead of gnutls_record_check_pending.
7017 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7019 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7021 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7022 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7025 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7027 * xterm.c (x_set_frame_alpha): Do not set property on anything
7028 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7030 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7032 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7034 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7036 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7037 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7038 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7039 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7040 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7041 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7042 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7043 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7044 (Qgnutls_bootprop_callbacks_verify): Make static.
7046 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7048 * callproc.c: Indentation fixup.
7050 * sysdep.c (wait_for_termination_1): Make static.
7051 (wait_for_termination, interruptible_wait_for_termination):
7052 Move after wait_for_termination_1.
7054 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7056 * sysdep.c (interruptible_wait_for_termination): New function
7057 which is like wait_for_termination, but allows keyboard
7060 * callproc.c (Fcall_process): Add (:file "file") as an option for
7062 (Fcall_process_region): Ditto.
7064 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7066 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7067 rather than `XVECTOR (FOO)->size'.
7069 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7070 inttypes.h, as a gnulib replacement is used if it not available in
7073 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7075 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7076 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7077 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7079 * coding.c (coding_alloc_by_realloc): Error out if destination
7080 will grow beyond MOST_POSITIVE_FIXNUM.
7081 (decode_coding_emacs_mule): Abort if there isn't enough place in
7082 charbuf for the composition carryover bytes. Reserve an extra
7083 space for up to 2 characters produced in a loop.
7084 (decode_coding_iso_2022): Abort if there isn't enough place in
7085 charbuf for the composition carryover bytes.
7087 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7089 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7090 aborting when %lld or %lll format is passed.
7091 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7092 %llo or %llx format is passed. (Bug#8545)
7094 * window.c (window_scroll_line_based): Use a marker instead of
7095 simple variables to record original value of point. (Bug#7952)
7097 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7098 produced by %s or %c overflows available buffer space. (Bug#8545)
7100 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7102 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7103 (SIZE_MAX): Move defn after all includes, as they might #define it.
7105 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7107 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7109 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7111 * keyboard.c (Qdelayed_warnings_hook): Define.
7112 (command_loop_1): Run `delayed-warnings-hook'
7113 if Vdelayed_warnings_list is non-nil.
7114 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7115 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7117 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7119 * doprnt.c (doprnt): Don't return value smaller than the buffer
7120 size if the message was truncated. (Bug#8545).
7122 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7124 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7125 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7127 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7129 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7131 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7133 * makefile.w32-in: Update dependencies.
7135 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7137 Improve `doprnt' and its usage. (Bug#8545)
7138 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7139 `format_end'. Remove support for %l as a conversion specifier.
7140 Don't use xrealloc. Improve diagnostics when the %l size modifier
7141 is used. Update the commentary.
7143 * eval.c (verror): Simplify calculation of size_t.
7145 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7148 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7150 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7153 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7155 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7156 This makes this file independent of the recent pseudovector change.
7158 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7160 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7162 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7163 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7164 Remove unused local.
7165 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7167 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7168 GCC 4.6.0 optimizes based on type-based alias analysis.
7169 For example, if b is of type struct buffer * and v of type struct
7170 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7171 != &v->size, and therefore "v->size = 1; b->size = 2; return
7172 v->size;" must therefore return 1. This assumption is incorrect
7173 for Emacs, since it type-puns struct Lisp_Vector * with many other
7174 types. To fix this problem, this patch adds a new type struct
7175 vectorlike_header that documents the constraints on layout of vectors
7176 and pseudovectors, and helps optimizing compilers not get fooled
7177 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7178 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7179 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7181 (XSETPVECTYPE): Rewrite in terms of new macro.
7182 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7183 This is a bit clearer, and further avoids the possibility of
7184 undesirable aliasing.
7185 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7186 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7187 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7188 since Lisp_Subr is a special case (no "next" field).
7189 (ASIZE): Now uses header.size rather than size.
7190 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7191 to avoid the hassle of writing XVECTOR (foo)->header.size.
7192 (struct vectorlike_header): New type.
7193 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7194 object, to help avoid aliasing.
7195 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7196 (SUBRP): Likewise, since Lisp_Subr is a special case.
7197 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7198 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7199 (struct Lisp_Hash_Table): Combine first two members into a single
7200 struct vectorlike_header member. All uses of "size" and "next" members
7201 changed to be "header.size" and "header.next".
7202 * buffer.h (struct buffer): Likewise.
7203 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7204 * frame.h (struct frame): Likewise.
7205 * process.h (struct Lisp_Process): Likewise.
7206 * termhooks.h (struct terminal): Likewise.
7207 * window.c (struct save_window_data, struct saved_window): Likewise.
7208 * window.h (struct window): Likewise.
7209 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7210 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7211 * buffer.c (init_buffer_once): Likewise.
7212 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7214 * process.c (Fformat_network_address): Use local var for size,
7217 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7219 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7220 * data.c (atof): Remove decl; no longer used or needed.
7221 (digit_to_number): Move to lread.c.
7222 (Fstring_to_number): Use new string_to_number function, to be
7223 consistent with how the Lisp reader treats infinities and NaNs.
7224 Do not assume that floating-point numbers represent EMACS_INT
7225 without losing information; this is not true on most 64-bit hosts.
7226 Avoid double-rounding errors, by insisting on integers when
7227 parsing non-base-10 numbers, as the documentation specifies.
7228 * lisp.h (string_to_number): New decl, replacing ...
7229 (isfloat_string): Remove.
7230 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7231 (read1): Do not accept +. and -. as integers; this
7232 appears to have been a coding error. Similarly, do not accept
7233 strings like +-1e0 as floating point numbers. Do not report
7234 overflow for integer overflows unless the base is not 10 which
7235 means we have no simple and reliable way to continue.
7236 Break out the floating-point parsing into a new
7237 function string_to_number, so that Fstring_to_number parses
7238 floating point numbers consistently with the Lisp reader.
7239 (digit_to_number): Move here from data.c. Make it static inline.
7240 (E_CHAR, EXP_INT): Remove, replacing with ...
7241 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7242 (string_to_number): New function, replacing isfloat_string.
7243 This function checks for valid syntax and produces the resulting
7244 Lisp float number too. Rework it so that string-to-number
7245 no longer mishandles examples like "1.0e+". Use strtoumax,
7246 so that overflow for non-base-10 numbers is reported only when
7247 there's no portable and simple way to convert to floating point.
7249 * textprop.c (set_text_properties_1): Rewrite for clarity,
7250 and to avoid GCC warning about integer overflow.
7252 * intervals.h (struct interval): Use EMACS_INT for members
7253 where EMACS_UINT might cause problems. See
7254 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7255 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7256 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7258 (offset_intervals): Tell GCC not to worry about length overflow
7259 when negating a negative length.
7261 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7262 (overrun_check_free): Likewise.
7264 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7265 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7268 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7269 (gnutls_make_error): Rename local to avoid shadowing.
7270 (gnutls_emacs_global_deinit): ifdef out; not used.
7271 (Fgnutls_boot): Use const for pointer to readonly storage.
7272 Comment out unused local. Fix pointer signedness problems.
7274 * lread.c (openp): Don't stuff size_t into an 'int'.
7275 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7276 about possible signed overflow.
7278 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7279 (GDK_KEY_g): Don't define if already defined.
7280 (xg_prepare_tooltip): Avoid pointer signedness problem.
7281 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7283 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7284 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7286 * xfns.c (Fx_window_property): Simplify a bit,
7287 to make a bit faster and to avoid GCC 4.6.0 warning.
7288 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7290 * fns.c (internal_equal): Don't assume size_t fits in int.
7292 * alloc.c (compact_small_strings): Tighten assertion a little.
7294 Replace pEd with more-general pI, and fix some printf arg casts.
7295 * lisp.h (pI): New macro, generalizing old pEd macro to other
7296 conversion specifiers. For example, use "...%"pI"d..." rather
7297 than "...%"pEd"...".
7298 (pEd): Remove. All uses replaced with similar uses of pI.
7299 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7300 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7301 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7302 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7303 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7304 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7305 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7307 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7308 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7309 * print.c (safe_debug_print, print_object): Likewise.
7310 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7312 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7313 avoiding the 0 flag, which is not portable.
7314 * process.c (Fmake_network_process): Use pI to avoid cast.
7315 * region-cache.c (pp_cache): Likewise.
7316 * xdisp.c (decode_mode_spec): Likewise.
7317 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7318 behavior on 64-bit hosts with printf arg.
7319 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7320 (x_stop_queuing_selection_requests): Likewise.
7321 (x_get_window_property): Don't truncate byte count to an 'int'
7324 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7325 here, since it parses constructs like leading '-' and spaces,
7326 which are not wanted; and it overflows with large numbers.
7327 Instead, simply match F[0-9]+, which is what is wanted anyway.
7329 * alloc.c: Remove unportable assumptions about struct layout.
7330 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7331 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7332 (allocate_vectorlike, make_pure_vector): Use the new macros,
7333 plus offsetof, to remove unportable assumptions about struct layout.
7334 These assumptions hold on all porting targets that I know of, but
7335 they are not guaranteed, they're easy to remove, and removing them
7336 makes further changes easier.
7338 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7339 This doesn't fix a bug but makes the code clearer.
7340 (string_overrun_cookie): Now const. Use initializers that
7341 don't formally overflow signed char, to avoid warnings.
7342 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7343 can cause Emacs to crash when string overrun checking is enabled.
7344 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7345 multiple of sizeof (EMACS_INT); it need not be, if
7346 alignof(EMACS_INT) < sizeof (EMACS_INT).
7347 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7349 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7351 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7353 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7355 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7356 supposed to be handshaking. (Bug#8556)
7357 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7359 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7361 * lisp.h (Qdebug): List symbol.
7362 * eval.c (Qdebug): Restore global linkage.
7363 * keyboard.c (debug-on-event): New variable.
7364 (handle_user_signal): Break into debugger when debug-on-event
7365 matches the current signal symbol.
7367 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7369 * alloc.c (check_sblock, check_string_bytes)
7370 (check_string_free_list): Convert to standard C.
7372 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7374 * w32.c (emacs_gnutls_push): Fix typo.
7376 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7378 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7379 "cast to pointer from integer of different size".
7381 Improve doprnt and its use in verror. (Bug#8545)
7382 * doprnt.c (doprnt): Document the set of format control sequences
7383 supported by the function. Use SAFE_ALLOCA instead of always
7386 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7387 is one byte too soon. Don't use xrealloc; instead xfree and
7390 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7392 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7395 * gnutls.c: Renamed global_initialized to
7396 gnutls_global_initialized. Added internals for the
7397 :verify-hostname-error, :verify-error, and :verify-flags
7398 parameters of `gnutls-boot' and documented those parameters in the
7399 docstring. Start callback support.
7400 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7401 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7402 on error. Return error code.
7403 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7404 (emacs_gnutls_read): Likewise.
7405 (Fgnutls_boot): Return handshake error code.
7406 (emacs_gnutls_handle_error): New function.
7407 (wsaerror_to_errno): Likewise.
7409 * w32.h (emacs_gnutls_pull): Add prototype.
7410 (emacs_gnutls_push): Likewise.
7412 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7413 (emacs_gnutls_push): Likewise.
7415 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7417 * process.c (wait_reading_process_output): Check if GnuTLS
7418 buffered some data internally if no FDs are set for TLS
7421 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7422 (LIBS): Link to USER_LIBS.
7423 ($(BLD)/gnutls.$(0)): New target.
7425 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7427 * xdisp.c (handle_single_display_spec): Rename the
7428 display_replaced_before_p argument into display_replaced_p, to
7429 make it consistent with the commentary. Fix typos in the
7432 * textprop.c (syms_of_textprop): Remove dead code.
7433 (copy_text_properties): Delete obsolete commentary about an
7434 interface that was deleted long ago. Fix typos in the description
7437 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7438 to changes in oldXMenu/XMenu.h from 2011-04-16.
7439 <menu_help_message, prev_menu_help_message>: Constify.
7440 (IT_menu_make_room): menu->help_text is now `const char **';
7443 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7444 to changes in oldXMenu/XMenu.h from 2011-04-16.
7445 (struct XMenu): Declare `help_text' `const char **'.
7447 * xfaces.c <Qunspecified>: Make extern again.
7449 * syntax.c: Include sys/types.h before including regex.h, as
7452 * doc.c (get_doc_string): Improve the format passed to `error'.
7454 * doprnt.c (doprnt): Improve commentary.
7456 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7458 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7461 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7462 changes in globals.h immediately force recompilation.
7463 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7464 $(CURDIR)/s/ms-w32.h.
7465 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7467 * character.c (Fchar_direction): Function deleted.
7468 (syms_of_character): Don't defsubr it.
7469 <char-direction-table>: Deleted.
7471 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7473 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7474 * doprnt.c: Include limits.h.
7475 (SIZE_MAX): New macro.
7476 (doprnt): Return a size_t value. 2nd arg is now size_t.
7477 Many local variables are now size_t instead of int or unsigned.
7478 Improve overflow protection. Support `l' modifier for integer
7479 conversions. Support %l conversion. Don't assume an EMACS_INT
7480 argument for integer conversions and for %c.
7482 * lisp.h (doprnt): Restore prototype.
7484 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7487 * Makefile.in (base_obj): Add back doprnt.o.
7489 * deps.mk (doprnt.o): Add back prerequisites.
7490 (callint.o): Depend on character.h.
7492 * eval.c (internal_lisp_condition_case): Include the handler
7493 representation in the error message.
7494 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7495 when breaking from the loop.
7497 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7499 * callint.c (Fcall_interactively): When displaying error message
7500 about invalid control letter, pass the character's codepoint, not
7501 a pointer to its multibyte form. Improve display of the character
7502 in octal and display also its hex code.
7504 * character.c (char_string): Use %x to display the (unsigned)
7505 codepoint of an invalid character, to avoid displaying a bogus
7508 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7509 `error', not SYMBOL_NAME itself.
7511 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7512 character arguments to `error'.
7514 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7515 to `error' in error message about FINAL_CHAR argument. Make sure
7516 FINAL_CHAR is a character, and use %c when it is passed as
7517 argument to `error'.
7519 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7521 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7523 * w32.c: Include <time.h>.
7524 (sys_localtime): New function.
7526 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7528 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7530 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7532 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7534 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7537 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7539 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7540 gl_state.e_property when gl_state.object is Qt.
7542 * insdel.c (make_gap_larger): Remove limitation of buffer size
7545 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7547 * xdisp.c (lookup_glyphless_char_display)
7548 (produce_glyphless_glyph): Handle cons cell entry in
7549 glyphless-char-display.
7550 (Vglyphless_char_display): Document it.
7552 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7553 glyphless-char-display.
7555 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7557 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7559 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7561 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7562 definition for no-X builds.
7564 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7566 Static checks with GCC 4.6.0 and non-default toolkits.
7568 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7570 * process.c (keyboard_bit_set): Define only if SIGIO.
7571 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7572 (send_process): Repair possible setjmp clobbering.
7574 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7576 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7578 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7580 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7581 Define only if needed.
7583 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7584 by pacifying GCC about it. Maybe it's time to retire it?
7585 * xfaces.c (USG, __TIMEVAL__): Likewise.
7587 * dispextern.h (struct redisplay_interface): Rename param
7589 * termhooks.h (struct terminal): Likewise.
7590 * xterm.c (xembed_send_message): Likewise.
7592 * insdel.c (make_gap_smaller): Define only if
7593 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7595 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7598 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7599 so that we aren't warned about unused symbols.
7601 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7603 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7605 * xfns.c (x_real_positions): Mark locals as initialized.
7607 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7609 * xterm.c: Fix problems found by static analysis with other toolkits.
7610 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7611 (x_dispatch_event): Declare static if USE_GTK, and
7612 define if USE_GTK || USE_X_TOOLKIT.
7613 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7614 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7615 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7616 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7618 * xmenu.c (menu_help_callback): Pointer type fixes.
7619 Use const pointers when pointing at readonly data. Avoid pointer
7621 (FALSE): Remove unused macro.
7622 (update_frame_menubar): Remove unused decl.
7624 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7626 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7627 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7628 (single_menu_item): Rename local to avoid shadowing.
7630 * keyboard.c (make_lispy_event): Remove unused local var.
7632 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7633 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7635 * bitmaps: Change bitmaps from unsigned char back to the X11
7636 compatible char. Avoid the old compiler warnings about
7637 out-of-range initializers by using, for example, '\xab' rather
7640 * xgselect.c (xgselect_initialize): Check vs interface
7641 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7643 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7645 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7646 to read-only memory.
7648 * fns.c (vector): Remove; this old hack is no longer needed.
7650 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7652 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7654 * xrdb.c (x_load_resources): Omit unused local.
7656 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7657 (x_window): Rename locals to avoid shadowing.
7658 (USG): Use the kludged USG macro, to pacify gcc.
7660 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7661 (x_term_init): Remove local to avoid shadowing.
7663 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7665 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7666 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7668 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7670 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7672 Fix regex.c, syntax.c and friends for buffers > 2GB.
7673 * syntax.h (struct gl_state_s): Declare character position members
7676 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7678 * textprop.c (verify_interval_modification, interval_of):
7679 Declare arguments EMACS_INT.
7681 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7684 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7686 * indent.c (Fvertical_motion): Local variable it_start is now
7689 * regex.c (re_match, re_match_2, re_match_2_internal)
7690 (bcmp_translate, regcomp, regexec, print_double_string)
7691 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7692 (re_compile_pattern, re_exec): Declare arguments and local
7693 variables `size_t' and `ssize_t' and return values `regoff_t', as
7695 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7696 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7697 <compile_stack_type>: `size' and `avail' are now `size_t'.
7699 * regex.h <regoff_t>: Use ssize_t, not int.
7700 (re_search, re_search_2, re_match, re_match_2): Arguments that
7701 specify buffer/string position and length are now ssize_t and
7702 size_t. Return type is regoff_t.
7704 2011-04-16 Ben Key <bkey76@gmail.com>
7706 * nsfont.m: Fixed bugs in ns_get_family and
7707 ns_descriptor_to_entity that were caused by using free to
7708 deallocate memory blocks that were allocated by xmalloc (via
7709 xstrdup). This caused Emacs to crash when compiled with
7710 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7711 --enable-checking=xmallocoverrun). xfree is now used to
7712 deallocate these memory blocks.
7714 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7716 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7718 emacs_write: Accept and return EMACS_INT for sizes.
7719 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7721 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7722 Accept and return EMACS_INT.
7723 (emacs_gnutls_write): Return the number of bytes written on
7725 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7726 (emacs_read, emacs_write): Remove check for negative size, as the
7727 Emacs source code has been audited now.
7728 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7729 (emacs_read, emacs_write): Use it.
7730 * process.c (send_process): Adjust to the new signatures of
7731 emacs_write and emacs_gnutls_write. Do not attempt to store
7732 a byte offset into an 'int'; it might overflow.
7733 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7735 * sound.c: Don't assume sizes fit in 'int'.
7736 (struct sound_device.period_size, alsa_period_size):
7737 Return EMACS_INT, not int.
7738 (struct sound_device.write, vox_write, alsa_write):
7739 Accept EMACS_INT, not int.
7740 (wav_play, au_play): Use EMACS_INT to store sizes and to
7741 record read return values.
7743 2011-04-15 Ben Key <bkey76@gmail.com>
7745 * keyboard.c (Qundefined): Don't declare static since it is used
7747 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7748 static since they are used in nsfont.m.
7750 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7752 * process.c (Qprocessp): Don't declare static.
7753 * lisp.h (Qprocessp): Declare again.
7755 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7757 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7759 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7761 Improve C-level modularity by making more things 'static'.
7763 Don't publish debugger-only interfaces to other modules.
7764 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7765 (verify_bytepos, count_markers): Move decls to the only modules
7767 * region-cache.h (pp_cache): Likewise.
7768 * window.h (check_all_windows): Likewise.
7769 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7771 * sysdep.c (croak): Now static, if
7772 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7773 * syssignal.h (croak): Declare only if not static.
7775 * alloc.c (refill_memory_reserve): Now static if
7776 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7777 * lisp.h (refill_memory_reserve): Declare only if not static.
7779 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7780 Define only if USE_LUCID.
7782 * xrdb.c (x_customization_string, x_rm_string): Now static.
7784 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7785 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7787 * xdisp.c (draw_row_with_mouse_face): Now static.
7788 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7790 * window.h (check_all_windows): Mark externally visible.
7792 * window.c (window_deletion_count): Now static.
7794 * undo.c: Make symbols static if they're not exported.
7795 (last_undo_buffer, last_boundary_position, pending_boundary):
7798 * textprop.c (interval_insert_behind_hooks): Now static.
7799 (interval_insert_in_front_hooks): Likewise.
7801 * term.c: Make symbols static if they're not exported.
7802 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7803 (max_frame_lines, tty_set_terminal_modes):
7804 (tty_reset_terminal_modes, tty_turn_off_highlight):
7805 (get_tty_terminal): Now static.
7806 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7807 * termhooks.h (term_mouse_moveto): Do not declare if
7809 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7810 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7812 * sysdep.c: Make symbols static if they're not exported.
7813 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7815 (sigprocmask_set, full_mask): Remove; unused.
7816 (wait_debugging): Mark as visible.
7817 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7818 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7820 * syntax.c (syntax_temp): Define only if !__GNUC__.
7822 * sound.c (current_sound_device, current_sound): Now static.
7824 * search.c (searchbufs, searchbuf_head): Now static.
7826 * scroll.c (scroll_cost): Remove; unused.
7827 * dispextern.h (scroll_cost): Remove decl.
7829 * region-cache.h (pp_cache): Mark as externally visible.
7831 * process.c: Make symbols static if they're not exported.
7832 (process_tick, update_tick, create_process, chan_process):
7833 (Vprocess_alist, proc_buffered_char, datagram_access):
7834 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7835 (deactivate_process): Mark defn as static, as well as decl.
7836 * lisp.h (create_process): Remove decl.
7837 * process.h (chan_process, Vprocess_alist): Remove decls.
7839 * print.c: Make symbols static if they're not exported.
7840 (print_depth, new_backquote_output, being_printed, print_buffer):
7841 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7842 (print_interval, print_number_index, initial_stderr_stream):
7844 * lisp.h (Fprinc): Remove decl.
7845 (debug_output_compilation_hack): Mark as externally visible.
7847 * sysdep.c (croak): Move decl from here to syssignal.h.
7848 * syssignal.h (croak): Put it here, so the API can be checked when
7849 'croak' is called from dissociate_if_controlling_tty.
7851 * minibuf.c: Make symbols static if they're not exported.
7852 (minibuf_save_list, choose_minibuf_frame): Now static.
7853 * lisp.h (choose_minibuf_frame): Remove decl.
7855 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7857 * lread.c: Make symbols static if they're not exported.
7858 (read_objects, initial_obarray, oblookup_last_bucket_number):
7860 (make_symbol): Remove; unused.
7861 * lisp.h (initial_obarray, make_symbol): Remove decls.
7863 * keyboard.c: Make symbols static if they're not exported.
7864 (single_kboard, recent_keys_index, total_keys, recent_keys):
7865 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7866 (this_single_command_key_start, echoing, last_auto_save):
7867 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7868 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7869 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7870 (Vlispy_mouse_stem, double_click_count):
7872 (force_auto_save_soon): Define only if SIGDANGER.
7873 (ignore_mouse_drag_p): Now static if
7874 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7875 (print_help): Remove; unused.
7876 (stop_character, last_timer_event): Mark as externally visible.
7877 * keyboard.h (ignore_mouse_drag_p): Declare only if
7878 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7879 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7880 * lisp.h (echoing): Remove decl.
7881 (force_auto_save_soon): Declare only if SIGDANGER.
7882 * xdisp.c (redisplay_window): Simplify code, to make it more
7883 obvious that ignore_mouse_drag_p is not accessed if !defined
7884 USE_GTK && !defined HAVE_NS.
7886 * intervals.c: Make symbols static if they're not exported.
7887 (merge_properties_sticky, merge_interval_right, delete_interval):
7889 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7891 * insdel.c: Make symbols static if they're not exported.
7892 However, leave prepare_to_modify_buffer alone. It's never
7893 called from outside this function, but that appears to be a bug.
7894 (combine_after_change_list, combine_after_change_buffer):
7895 (adjust_after_replace, signal_before_change): Now static.
7896 (adjust_after_replace_noundo): Remove; unused.
7897 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7898 (signal_before_change): Remove decls.
7900 * indent.c (val_compute_motion, val_vmotion): Now static.
7902 * image.c: Make symbols static if they're not exported.
7903 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7905 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7906 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7908 * fringe.c (standard_bitmaps): Now static.
7909 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7911 * frame.c: Make symbols static if they're not exported.
7912 (x_report_frame_params, make_terminal_frame): Now static.
7913 (get_frame_param): Now static, unless HAVE_NS.
7914 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7915 (x_get_resource_string): Remove; not used.
7916 * frame.h (make_terminal_frame, x_report_frame_params):
7917 (x_get_resource_string); Remove decls.
7918 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7919 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7921 * font.c, fontset.c: Make symbols static if they're not exported.
7922 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7923 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7924 * font.c (font_close_object): Now static.
7925 * font.h (font_close_object): Remove.
7926 * fontset.c (FONTSET_OBJLIST): Remove.
7927 (free_realized_fontset) #if-0 the body, which does nothing.
7928 (face_suitable_for_char_p): #if-0, as it's never called.
7929 * fontset.h (face_suitable_for_char_p): Remove decl.
7930 * xfaces.c (face_at_string_position):
7931 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7932 since 0 is always ASCII.
7934 * fns.c (weak_hash_tables): Now static.
7936 * fileio.c: Make symbols static if they're not exported.
7937 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7938 (Vwrite_region_annotation_buffers): Now static.
7940 * eval.c: Make symbols static if they're not exported.
7941 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7942 * lisp.h (backtrace_list): Remove decl.
7944 * emacs.c: Make symbols static if they're not exported.
7945 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7946 (fatal_error_code, fatal_error_signal_hook, standard_args):
7948 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7949 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7950 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7951 * lisp.h (fatal_error_signal_hook): Remove decl.
7952 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7954 * editfns.c: Move a (normally-unused) function to its only use.
7955 * editfns.c, lisp.h (get_operating_system_release): Remove.
7956 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7957 worth the hassle of breaking this out.
7959 * xterm.c: Make symbols static if they're not exported.
7960 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7961 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7962 (x_destroy_window, x_delete_display):
7964 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7965 (x_mouse_leave): Remove; unused.
7966 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7967 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7968 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7970 (x_mouse_leave): Declare only if WINDOWSNT.
7971 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7972 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7975 * ftxfont.c: Make symbols static if they're not exported.
7976 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7978 * font.h (ftxfont_driver): Likewise.
7980 * xfns.c: Make symbols static if they're not exported.
7981 (x_last_font_name, x_display_info_for_name):
7982 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7983 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7984 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7985 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7986 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7987 (last_show_tip_args): Now static.
7988 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7989 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7990 (x_screen_planes): Remove; unused.
7991 * dispextern.h (x_screen_planes): Remove decl.
7993 * dispnew.c: Make symbols static if they're not exported.
7994 * dispextern.h (redraw_garbaged_frames, scrolling):
7995 (increment_row_positions): Remove.
7996 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7997 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7999 (redraw_garbaged_frames): Remove; unused.
8001 * xfaces.c: Make symbols static if they're not exported.
8002 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8004 * xterm.h (defined_color): Remove decls.
8005 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8006 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8007 (menu_face_changed_default, defined_color, free_realized_face):
8008 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8009 (ascii_face_of_lisp_face): Remove; unused.
8011 * xdisp.c: Make symbols static if they're not exported.
8012 * dispextern.h (scratch_glyph_row, window_box_edges):
8013 (glyph_to_pixel_coords, set_cursor_from_row):
8014 (get_next_display_element, set_iterator_to_next):
8015 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8016 (show_mouse_face): Remove decls
8017 * frame.h (message_buf_print): Likewise.
8018 * lisp.h (pop_message, set_message, check_point_in_composition):
8020 * xterm.h (set_vertical_scroll_bar): Likewise.
8021 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8022 (message_buf_print, scratch_glyph_row, displayed_buffer):
8023 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8024 (get_next_display_element, show_mouse_face, window_box_edges):
8025 (frame_to_window_pixel_xy, check_point_in_composition):
8026 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8027 (glyph_to_pixel_coords): Remove; unused.
8029 * dired.c (file_name_completion): Now static.
8031 * dbusbind.c (xd_in_read_queued_messages): Now static.
8033 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8034 * data.c (circular_list_error): Remove.
8036 * commands.h (last_point_position, last_point_position_buffer):
8037 (last_point_position_window): Remove decls.
8038 * keyboard.c: Make these variables static.
8040 * coding.h (coding, code_convert_region, encode_coding_gap):
8042 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8043 (iso_code_class, detect_coding, code_convert_region): Now static.
8044 (encode_coding_gap): Remove; unused.
8046 * chartab.c (chartab_chars, chartab_bits): Now static.
8048 * charset.h (charset_iso_8859_1): Remove decl.
8049 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8052 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8053 * ccl.c (Vccl_program_table): Now static.
8054 (check_ccl_update): Remove; unused.
8056 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8057 * category.h: ... from here.
8058 * category.c (check_category_table, set_category_set): Now static.
8060 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8061 * lisp.h: Remove these decls.
8063 * buffer.c (buffer_count): Remove unused var.
8065 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8066 so that it's not optimized away.
8067 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8068 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8069 exported only to the debugger.
8071 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8072 * atimer.h (run_all_atimers): Remove; not exported.
8074 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8075 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8076 was inaccessible from Lisp.
8077 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8078 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8080 alloc.c: Import and export fewer symbols, and remove unused items.
8081 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8083 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8084 it's not optimized away by whole-program optimization.
8085 (message_enable_multibyte, free_misc): Remove.
8086 (catchlist, handlerlist, mark_backtrace):
8087 Declare only if BYTE_MARK_STACK.
8088 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8089 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8090 (message_enable_multibyte): Remove decl.
8091 (free_misc, interval_free_list, float_block, float_block_index):
8092 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8093 (cons_free_list, last_marked_index):
8095 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8096 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8097 (mark_backtrace): Define only if BYTE_MARK_STACK.
8098 * xdisp.c (message_enable_multibyte): Now static.
8100 Declare Lisp_Object Q* variables to be 'static' if not exported.
8101 This makes it easier for human readers (and static analyzers)
8102 to see whether these variables are used from other modules.
8103 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8104 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8105 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8106 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8107 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8108 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8109 * xmenu.c, xselect.c:
8110 Declare Q* vars static if they are not used in other modules.
8111 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8112 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8113 Remove decls of unexported vars.
8114 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8116 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8118 Make Emacs functions such as Fatom 'static' by default.
8119 This makes it easier for human readers (and static analyzers)
8120 to see whether these functions can be called from other modules.
8121 DEFUN now defines a static function. To make the function external
8122 so that it can be used in other C modules, use the new macro DEFUE.
8123 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8124 (Finit_image_library):
8125 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8126 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8127 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8128 Remove decls, since these functions are now static.
8129 (Funintern, Fget_internal_run_time): New decls, since these functions
8130 were already external.
8132 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8133 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8134 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8135 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8136 * keyboard.c, keymap.c, lread.c:
8137 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8138 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8139 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8140 Mark functions with DEFUE instead of DEFUN,
8141 if they are used in other modules.
8142 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8143 decls for now-static functions.
8144 * buffer.h (Fdelete_overlay): Remove decl.
8145 * callproc.c (Fgetenv_internal): Mark as internal.
8146 * composite.c (Fremove_list_of_text_properties): Remove decl.
8147 (Fcomposition_get_gstring): New forward static decl.
8148 * composite.h (Fcomposite_get_gstring): Remove decl.
8149 * dired.c (Ffile_attributes): New forward static decl.
8150 * doc.c (Fdocumntation_property): New forward static decl.
8151 * eval.c (Ffetch_bytecode): New forward static decl.
8152 (Funintern): Remove extern decl; now in .h file where it belongs.
8153 * fileio.c (Fmake_symbolic_link): New forward static decl.
8154 * image.c (Finit_image_library): New forward static decl.
8155 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8156 * intervals.h (Fprevious_property_change):
8157 (Fremove_list_of_text_properties): Remove decls.
8158 * keyboard.c (Fthis_command_keys): Remove decl.
8159 (Fcommand_execute): New forward static decl.
8160 * keymap.c (Flookup_key): New forward static decl.
8161 (Fcopy_keymap): Now static.
8162 * keymap.h (Flookup_key): Remove decl.
8163 * process.c (Fget_process): New forward static decl.
8164 (Fprocess_datagram_address): Mark as internal.
8165 * syntax.c (Fsyntax_table_p): New forward static decl.
8166 (skip_chars): Remove duplicate decl.
8167 * textprop.c (Fprevious_property_change): New forward static decl.
8168 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8170 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8171 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8173 * editfns.c (Fformat): Remove unreachable code.
8175 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8177 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8180 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8182 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8183 when at ZV. (Bug#8487)
8185 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8187 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8189 * keyboard.c (parse_tool_bar_item): Likewise.
8190 * sound.c (sound_cleanup, alsa_close): Likewise.
8191 * termcap.c (tgetent): Likewise.
8192 * xfns.c (x_default_font_parameter): Likewise.
8193 * xsettings.c (read_and_apply_settings): Likewise.
8195 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8196 (overrun_check_free): Protoize.
8198 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8200 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8201 since callers should never pass a negative size.
8202 Change the signature to match that of plain 'read' and 'write'; see
8203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8204 * lisp.h: Update prototypes of emacs_write and emacs_read.
8206 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8208 * xdisp.c (redisplay_window): Don't try to determine the character
8209 position of the scroll margin if the window start point w->startp
8210 is outside the buffer's accessible region. (Bug#8468)
8212 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8214 Fix write-region and its subroutines for buffers > 2GB.
8215 * fileio.c (a_write, e_write): Modify declaration of arguments and
8216 local variables to support buffers larger than 2GB.
8217 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8219 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8220 argument, local variables, and return value.
8222 * lisp.h: Update prototypes of emacs_write and emacs_read.
8224 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8226 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8228 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8230 Fix more problems found by GCC 4.6.0's static checks.
8232 * xdisp.c (vmessage): Use a better test for character truncation.
8234 * charset.c (load_charset_map): <, not <=, for optimization,
8235 and to avoid potential problems with integer overflow.
8236 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8237 * casetab.c (set_identity, shuffle): Likewise.
8238 * editfns.c (Fformat): Likewise.
8239 * syntax.c (skip_chars): Likewise.
8241 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8242 This also lets GCC 4.6.0 generate slightly better loop code.
8244 * callint.c (Fcall_interactively): <, not <=, for optimization.
8245 (Fcall_interactively): Count the number of arguments produced,
8246 not the number of arguments given. This is simpler and lets GCC
8247 4.6.0 generate slightly better code.
8249 * ftfont.c: Distingish more carefully between FcChar8 and char.
8250 The previous code passed unsigned char * to a functions like
8251 strlen and xstrcasecmp that expect char *, which does not
8252 conform to the C standard.
8253 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8254 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8255 char * when the C standard requires it.
8257 * keyboard.c (read_char): Remove unused var.
8259 * eval.c: Port to Windows vsnprintf (Bug#8435).
8261 (SIZE_MAX): Define if the headers do not.
8262 (verror): Do not give up if vsnprintf returns a negative count.
8263 Instead, grow the buffer. This ports to Windows vsnprintf, which
8264 does not conform to C99. Problem reported by Eli Zaretskii.
8265 Also, simplify the allocation scheme, by avoiding the need for
8266 calling realloc, and removing the ALLOCATED variable.
8268 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8270 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8271 But keep the doprint source code for now, as we might revamp it
8272 and use it again (Bug#8435).
8273 * lisp.h (doprnt): Remove.
8274 * Makefile.in (base_obj): Remove doprnt.o.
8275 * deps.mk (doprnt.o): Remove.
8277 error: Print 32- and 64-bit integers portably (Bug#8435).
8278 Without this change, on typical 64-bit hosts error ("...%d...", N)
8279 was used to print both 32- and 64-bit integers N, which relied on
8281 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8282 * lisp.h (error, verror): Mark as printf-like functions.
8283 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8284 Report overflow in size calculations when allocating printf buffer.
8285 Do not truncate output string at its first null byte.
8286 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8287 Truncate the output at a character boundary, since vsnprintf does not
8289 * charset.c (check_iso_charset_parameter): Convert internal
8290 character to string before calling 'error', since %c now has the
8292 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8293 overflow when computing char to be passed to 'error'. Do not
8294 pass Lisp_Object to 'error'; pass the integer instead.
8295 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8296 formatted with plain %d.
8298 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8300 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8302 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8304 * xterm.c (x_catch_errors): Remove duplicate declaration.
8306 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8308 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8310 2011-04-10 Jim Meyering <meyering@redhat.com>
8312 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8313 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8314 return ssize_t not "int", and use size_t as the buffer length.
8315 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8316 * gnutls.h: Update declarations.
8317 * process.c (read_process_output): Use ssize_t, to match.
8318 (send_process): Likewise.
8320 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8322 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8324 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8326 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8327 Use unsigned char, to match FcChar8 type definition.
8329 * xterm.c (handle_one_xevent):
8330 * xmenu.c (create_and_show_popup_menu):
8331 * xselect.c (x_decline_selection_request)
8332 (x_reply_selection_request): Avoid type-punned deref of X events.
8334 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8336 Fix some uses of `int' instead of EMACS_INT.
8337 * search.c (string_match_1, fast_string_match)
8338 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8339 (scan_buffer, find_next_newline_no_quit)
8340 (find_before_next_newline, search_command, Freplace_match)
8341 (Fmatch_data): Make some `int' variables be EMACS_INT.
8343 * xdisp.c (display_count_lines): 3rd argument and return value now
8344 EMACS_INT. All callers changed.
8345 (pint2hrstr): Last argument is now EMACS_INT.
8347 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8348 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8349 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8350 (decode_coding_utf_16, decode_coding_emacs_mule)
8351 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8352 (decode_coding_ccl, decode_coding_charset)
8353 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8354 (decode_coding_iso_2022, decode_coding_emacs_mule)
8355 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8356 <char_offset, last_offset>: Declare EMACS_INT.
8357 (encode_coding_utf_8, encode_coding_utf_16)
8358 (encode_coding_emacs_mule, encode_invocation_designation)
8359 (encode_designation_at_bol, encode_coding_iso_2022)
8360 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8361 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8363 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8364 (encode_invocation_designation): Last argument P_NCHARS is now
8366 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8367 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8369 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8372 * ccl.c (Fccl_execute_on_string): Declare some variables
8375 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8377 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8379 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8381 * process.c (Fformat_network_address): Doc fix.
8383 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8385 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8387 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8389 * keyboard.c (read_char): Call Lisp function help-form-show,
8390 instead of using internal_with_output_to_temp_buffer.
8391 (Qhelp_form_show): New var.
8392 (syms_of_keyboard): Use DEFSYM macro.
8394 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8396 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8398 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8400 * process.c (Flist_processes): Remove to Lisp.
8401 (list_processes_1): Delete.
8403 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8405 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8407 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8409 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8411 Fix more problems found by GCC 4.6.0's static checks.
8413 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8415 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8417 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8419 * xdisp.c (vmessage): Mark as a printf-like function.
8421 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8423 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8425 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8426 printf-like functions.
8427 (tiff_load): Add casts to remove these marks before passing them
8428 to system-supplied API.
8430 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8432 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8433 This avoids several warnings with gcc -Wstrict-overflow.
8434 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8435 directly, rather than having caller test rule sign. This avoids
8436 some unnecessary tests.
8437 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8438 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8439 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8441 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8442 (xfont_open): Avoid unnecessary tests.
8444 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8446 * composite.h, composite.c (composition_gstring_put_cache):
8447 Use EMACS_INT, not int, for length.
8449 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8450 breaking out part of COMPOSITION_DECODE_RULE.
8451 (COMPOSITION_DECODE_RULE): Use it.
8452 * composite.c (get_composition_id): Remove unused local vars,
8453 by using the new macro.
8455 * textprop.c (set_text_properties_1): Change while to do-while,
8456 since the condition is always true at first.
8458 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8459 (interval_deletion_adjustment): Return unsigned value.
8462 * process.c (list_processes_1, create_pty, read_process_output):
8463 (exec_sentinel): Remove vars that were set but not used.
8464 (create_pty): Remove unnecessary "volatile"s.
8465 (Fnetwork_interface_info): Avoid possibility of int overflow.
8466 (read_process_output): Do adaptive read buffering even if carryover.
8467 (read_process_output): Simplify nbytes computation if buffered.
8469 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8471 * syntax.c (scan_words): Remove var that was set but not used.
8472 (update_syntax_table): Use unsigned instead of int.
8474 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8475 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8476 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8478 * print.c (print_error_message): Avoid int overflow.
8480 * font.c (font_list_entities): Redo for clarity,
8481 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8483 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8484 (font_score): Avoid potential overflow in diff calculation.
8486 * fns.c (substring_both): Remove var that is set but not used.
8487 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8489 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8491 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8492 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8493 can always succeed if overflow has undefined behavior.
8495 * search.c (boyer_moore, wordify): Remove vars set but not used.
8496 (wordify): Omit three unnecessary tests.
8498 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8499 All callers changed. This avoids the need for an unused var.
8501 * casefiddle.c (casify_region): Remove var that is set but not used.
8503 * dired.c (file_name_completion): Remove var that is set but not used.
8505 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8507 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8508 (Finsert_file_contents): Remove unnecessary code checking fd.
8510 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8511 Check for integer overflow on size calculations.
8513 * buffer.c (Fprevious_overlay_change): Remove var that is set
8516 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8517 Remove vars that are set but not used.
8518 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8519 (timer_check_2): Mark vars as initialized.
8521 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8523 * image.c (lookup_image): Remove var that is set but not used.
8524 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8526 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8527 that are set but not used.
8529 * xfns.c (make_invisible_cursor): Don't return garbage
8530 if XCreateBitmapFromData fails (Bug#8410).
8532 * xselect.c (x_get_local_selection, x_handle_property_notify):
8533 Remove vars that are set but not used.
8535 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8536 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8538 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8539 Remove var that is set but not used.
8540 (scroll_bar_windows_size): Now size_t, not int.
8541 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8544 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8545 (map_tty_color) [!defined MSDOS]: Likewise.
8547 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8549 * coding.c: Remove vars that are set but not used.
8550 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8551 All callers changed.
8552 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8553 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8554 (decode_coding_charset): Remove vars that are set but not used.
8556 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8557 that is set but not used.
8559 * print.c (print_object): Remove var that is set but not used.
8561 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8562 The gnulib version avoids calling malloc in the usual case,
8563 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8564 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8565 * filelock.c (current_lock_owner): Likewise.
8566 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8567 * sysdep.c: Include allocator.h, careadlinkat.h.
8568 (emacs_no_realloc_allocator): New static constant.
8569 (emacs_readlink): New function.
8570 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8571 ../lib/careadlinkat.h.
8573 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8575 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8576 first non-nil return value).
8578 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8580 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8581 if not defined (Bug#8403).
8583 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8585 * xdisp.c (display_count_lines): Remove parameter `start',
8586 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8587 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8588 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8589 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8590 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8591 and thereabouts. All callers changed.
8592 (get_per_char_metric): Remove parameter `f', unused since
8593 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8595 2011-04-02 Jim Meyering <meyering@redhat.com>
8597 do not dereference NULL upon failed strdup
8598 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8599 (ns_get_family): Likewise.
8601 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8603 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8605 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8607 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8610 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8612 Add lexical binding.
8614 * window.c (Ftemp_output_buffer_show): New fun.
8615 (Fsave_window_excursion):
8616 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8618 * lread.c (lisp_file_lexically_bound_p): New function.
8619 (Fload): Bind Qlexical_binding.
8620 (readevalloop): Remove `evalfun' arg.
8621 Bind Qinternal_interpreter_environment.
8622 (Feval_buffer): Bind Qlexical_binding.
8623 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8625 (syms_of_lread): Declare `lexical-binding'.
8627 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8629 * keyboard.c (eval_dyn): New fun.
8630 (menu_item_eval_property): Use it.
8632 * image.c (parse_image_spec): Use Ffunctionp.
8634 * fns.c (concat, mapcar1): Accept byte-code-functions.
8636 * eval.c (Fsetq): Handle lexical vars.
8637 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8638 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8639 (FletX, Flet): Obey lexical binding.
8640 (Fcommandp): Handle closures.
8641 (Feval): New `lexical' arg.
8642 (eval_sub): New function extracted from Feval. Use it almost
8643 everywhere where Feval was used. Look up vars in lexical env.
8645 (Ffunctionp): Move from subr.el.
8646 (Ffuncall): Handle closures.
8647 (apply_lambda): Remove `eval_flags'.
8648 (funcall_lambda): Handle closures and new byte-code-functions.
8649 (Fspecial_variable_p): New function.
8650 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8651 but without exporting it to Lisp.
8653 * doc.c (Fdocumentation, store_function_docstring):
8654 * data.c (Finteractive_form): Handle closures.
8656 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8659 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8661 (exec_byte_code): New function extracted from Fbyte_code to handle new
8662 calling convention for byte-code-functions. Add new byte-codes.
8664 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8666 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8668 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8670 * xdisp.c (redisplay_internal): Fix prototype.
8672 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8674 * xdisp.c (SCROLL_LIMIT): New macro.
8675 (try_scrolling): Use it when setting scroll_limit.
8676 Limit scrolling to 100 screen lines.
8677 (redisplay_window): Even when falling back on "recentering",
8678 position point in the window according to scroll-conservatively,
8679 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8681 (try_scrolling): When point is above the window, allow searching
8682 as far as scroll_max, or one screenful, to compute vertical
8683 distance from PT to the scroll margin position. This prevents
8684 try_scrolling from unnecessarily failing when
8685 scroll-conservatively is set to a value slightly larger than the
8686 window height. Clean up the case of PT below the margin at bottom
8687 of window: scroll_max can no longer be INT_MAX. When aggressive
8688 scrolling is in use, don't let point enter the opposite scroll
8689 margin as result of the scroll.
8690 (syms_of_xdisp) <scroll-conservatively>: Document the
8691 threshold of 100 lines for never-recentering scrolling.
8693 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8695 * dispextern.h (move_it_by_lines):
8696 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8697 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8698 (message_log_check_duplicate): Remove parameters `prev_bol' and
8699 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8700 (redisplay_internal): Remove parameter `preserve_echo_area',
8701 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8703 * indent.c (Fvertical_motion):
8704 * window.c (window_scroll_pixel_based, Frecenter):
8705 Don't pass `need_y_p' to `move_it_by_lines'.
8707 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8709 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8710 steal a few bits to be more compact.
8711 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8712 Remove unneeded casts.
8714 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8716 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8718 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8719 binding" message (bug#7967).
8721 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8723 Fix more problems found by GCC 4.6.0's static checks.
8725 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8726 Remove unused local var.
8728 * editfns.c (Fmessage_box): Remove unused local var.
8730 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8731 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8732 Omit unused local vars.
8733 * window.c (shrink_windows): Omit unused local var.
8734 * menu.c (digest_single_submenu): Omit unused local var.
8735 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8736 Omit unused local var.
8738 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8739 Don't assume string length fits in int.
8740 (keyremap_step, read_key_sequence): Use size_t for sizes.
8741 (read_key_sequence): Don't check last_real_key_start redundantly.
8743 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8744 instead of alloca (Bug#8344).
8746 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8747 (Fbacktrace_frame): Don't assume nframes fits in int.
8749 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8751 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8754 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8756 * cm.c (calccost): Turn while-do into do-while, for clarity.
8758 * keyboard.c (syms_of_keyboard): Use the same style as later
8759 in this function when indexing through an array. This also
8760 works around GCC bug 48267.
8762 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8764 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8766 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8767 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8769 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8770 This avoids undefined behavior on integer overflow, and is a bit
8771 more convenient anyway since it is compared to a size_t variable.
8773 Variadic C functions now count arguments with size_t, not int.
8774 This avoids an unnecessary limitation on 64-bit machines, which
8775 caused (substring ...) to crash on large vectors (Bug#8344).
8776 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8777 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8778 All variadic functions and their callers changed accordingly.
8779 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8780 * data.c (arith_driver, float_arith_driver): Likewise.
8781 * editfns.c (general_insert_function): Likewise.
8782 * eval.c (struct backtrace.nargs, interactive_p)
8783 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8784 (funcall_lambda, mark_backtrace): Likewise.
8785 * fns.c (concat): Likewise.
8786 * frame.c (x_set_frame_parameters): Likewise.
8787 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8788 0 if not found, not -1. All callers changed.
8790 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8791 (stack_copy_size): Now size_t, not int.
8792 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8794 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8796 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8797 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8798 All callers changed.
8800 * lisp.h (multibyte_char_to_unibyte):
8801 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8802 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8803 * character.h (CHAR_TO_BYTE8):
8804 * cmds.c (internal_self_insert):
8805 * editfns.c (general_insert_function):
8806 * keymap.c (push_key_description):
8807 * search.c (Freplace_match):
8808 * xdisp.c (message_dolog, set_message_1): All callers changed.
8810 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8812 * keyboard.c (safe_run_hook_funcall): New function.
8813 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8814 don't set the hook to nil, but remove the offending function instead.
8815 (Qcommand_hook_internal): Remove, unused.
8816 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8817 Vcommand_hook_internal.
8819 * eval.c (enum run_hooks_condition): Remove.
8820 (funcall_nil, funcall_not): New functions.
8821 (run_hook_with_args): Call each function through a `funcall' argument.
8822 Remove `cond' argument, now redundant.
8823 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8824 (Frun_hook_with_args_until_failure): Adjust accordingly.
8825 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8827 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8829 * dispextern.h (string_buffer_position): Remove declaration.
8831 * print.c (strout): Remove parameter `multibyte', unused since
8832 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8834 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8835 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8836 All callers changed.
8838 * w32.c (_wsa_errlist): Use braces for struct initializers.
8840 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8841 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8842 All callers changed.
8843 (string_buffer_position): Likewise. Also, make static (it's never
8844 used outside xdisp.c).
8845 (cursor_row_p): Remove parameter `w', unused since
8846 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8847 (decode_mode_spec): Remove parameter `precision', introduced during
8848 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8849 All callers changed.
8851 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8853 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8855 2011-03-27 Anders Lindgren <andlind@gmail.com>
8857 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8858 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8859 (ns_update_auto_hide_menu_bar): New functions.
8860 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8861 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8862 ns_constrain_all_frames.
8863 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8864 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8866 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8868 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8870 2011-03-27 Glenn Morris <rgm@gnu.org>
8872 * syssignal.h: Replace RETSIGTYPE with void.
8873 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8874 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8875 Replace SIGTYPE with void everywhere.
8876 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8877 * s/template.h (SIGTYPE): Remove commented out definition.
8879 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8881 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8882 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8884 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8886 * w32.c (read_unc_volume): Use parameter `henum', instead of
8887 global variable `wget_enum_handle'.
8889 * keymap.c (describe_vector): Remove parameters `indices' and
8890 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8891 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8893 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8895 * keyboard.c (timer_check): Remove parameter `do_it_now',
8896 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8897 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8898 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8900 * keyboard.c (read_char):
8901 * w32menu.c (w32_menu_display_help):
8902 * xmenu.c (show_help_event, menu_help_callback):
8903 Adjust calls to `show_help_echo'.
8905 * gtkutil.c (xg_maybe_add_timer):
8906 * keyboard.c (readable_events):
8907 * process.c (wait_reading_process_output):
8908 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8910 * insdel.c (adjust_markers_gap_motion):
8911 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8912 (gap_left, gap_right): Don't call it.
8914 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8916 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8917 incurred during fontification.
8919 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8921 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8922 (DEFVAR_PER_BUFFER): Don't pass it.
8924 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8925 (scrolling_window): Don't pass it.
8927 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8929 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8931 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8933 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8934 of variables specific to SELinux and computation of `encoded_absname'.
8936 * image.c (XPutPixel): Remove unused variable `height'.
8938 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8940 * unexw32.c (get_section_info): Remove unused variable `section'.
8942 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8943 (system_process_attributes): Remove unused variable `sess'.
8944 (sys_read): Remove unused variable `err'.
8946 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8947 (w32_wnd_proc): Remove unused variable `isdead'.
8948 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8949 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8950 (x_create_tip_frame): Remove unused variable `tem'.
8952 * w32inevt.c (w32_console_read_socket):
8953 Remove unused variable `no_events'.
8955 * w32term.c (x_draw_composite_glyph_string_foreground):
8956 Remove unused variable `width'.
8958 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8960 * w32term.c (x_set_glyph_string_clipping):
8961 Don't pass uninitialized region to CombineRgn.
8963 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8965 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8966 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8967 (Fx_close_connection): Remove unused variable `i'.
8969 * w32font.c (w32font_draw): Return number of glyphs.
8970 (w32font_open_internal): Remove unused variable `i'.
8971 (w32font_driver): Add missing initializer.
8973 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8974 (fill_in_menu): Remove unused variable `items_added'.
8976 * w32term.c (last_mouse_press_frame): Remove static global variable.
8977 (w32_clip_to_row): Remove unused variable `f'.
8978 (x_delete_terminal): Remove unused variable `i'.
8980 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8981 (NOTHING): Remove unused static global variable.
8982 (uniscribe_check_otf): Remove unused variable `table'.
8983 (uniscribe_font_driver): Add missing initializers.
8985 2011-03-23 Julien Danjou <julien@danjou.info>
8987 * term.c (Fsuspend_tty, Fresume_tty):
8988 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8989 * window.c (temp_output_buffer_show):
8990 * insdel.c (signal_before_change):
8991 * frame.c (Fhandle_switch_frame):
8992 * fileio.c (Fdo_auto_save):
8993 * emacs.c (Fkill_emacs):
8994 * editfns.c (save_excursion_restore):
8995 * cmds.c (internal_self_insert):
8996 * callint.c (Fcall_interactively):
8997 * buffer.c (Fkill_all_local_variables):
8998 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9000 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9001 unconditionally since it does the check itself.
9003 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9005 Fix more problems found by GCC 4.5.2's static checks.
9007 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9008 the first time through the loop, since we know p0 < p1 then.
9009 This also avoids a gcc -Wstrict-overflow warning.
9011 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9012 leading to a memory leak, possible in functions like
9013 load_charset_map_from_file that can allocate an unbounded number
9014 of objects (Bug#8318).
9016 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9017 that could (at least in theory) be that large.
9019 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9020 This is less likely to overflow, and avoids undefined behavior if
9021 overflow does occur. All callers changed. Use strtoul to scan
9022 for the unsigned long integer.
9023 (pint2hrstr): Simplify and tune code slightly.
9024 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9026 * scroll.c (do_scrolling): Work around GCC bug 48228.
9027 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9029 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9030 This also avoids a warning with gcc -Wstrict-overflow.
9031 (validate_x_resource_name): Simplify count usage.
9032 This also avoids a warning with gcc -Wstrict-overflow.
9034 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9037 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9039 * process.c (Fmake_network_process): Use socklen_t, not int,
9040 where POSIX says socklen_t is required in portable programs.
9041 This fixes a porting bug on hosts like 64-bit HP-UX, where
9042 socklen_t is wider than int (Bug#8277).
9043 (Fmake_network_process, server_accept_connection):
9044 (wait_reading_process_output, read_process_output):
9047 * process.c: Rename or move locals to avoid shadowing.
9048 (list_processes_1, Fmake_network_process):
9049 (read_process_output_error_handler, exec_sentinel_error_handler):
9050 Rename or move locals.
9051 (Fmake_network_process): Define label "retry_connect" only if needed.
9052 (Fnetwork_interface_info): Fix pointer signedness.
9053 (process_send_signal): Add cast to avoid pointer signedness problem.
9054 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9055 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9057 Make tparam.h and terminfo.c consistent.
9058 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9059 Include tparam.h instead, since it declares them.
9060 * cm.h (PC): Remove extern decl; tparam.h now does this.
9061 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9062 * terminfo.c: Include tparam.h, to check interfaces.
9063 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9064 (tparam): Adjust signature to match interface in tparam.h;
9065 this removes some undefined behavior. Check that outstring and len
9066 are zero, which they always are with Emacs.
9067 * tparam.h (PC, BC, UP): New extern decls.
9069 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9070 (xftfont_open): Rename locals to avoid shadowing.
9072 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9073 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9074 (OTF_TAG_SYM): Omit macro if not needed.
9075 (ftfont_list): Remove unused local.
9076 (get_adstyle_property, ftfont_pattern_entity):
9077 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9078 Rename locals to avoid shadowing.
9080 * xfont.c (xfont_list_family): Mark var as initialized.
9082 * xml.c (make_dom): Now static.
9084 * composite.c (composition_compute_stop_pos): Rename local to
9086 (composition_reseat_it): Remove unused locals.
9087 (find_automatic_composition, composition_adjust_point): Likewise.
9088 (composition_update_it): Mark var as initialized.
9089 (find_automatic_composition): Mark vars as initialized,
9090 with a FIXME (Bug#8290).
9092 character.h: Rename locals to avoid shadowing.
9093 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9094 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9095 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9096 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9099 * textprop.c (property_change_between_p): Remove; unused.
9101 * intervals.c (interval_start_pos): Now static.
9103 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9105 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9106 Rename locals to avoid shadowing.
9108 * sound.c (wav_play, au_play, Fplay_sound_internal):
9109 Fix pointer signedness.
9110 (alsa_choose_format): Remove unused local var.
9111 (wav_play): Initialize a variable to 0, to prevent undefined
9112 behavior (Bug#8278).
9114 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9116 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9118 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9119 clobbering (Bug#8298).
9120 * sysdep.c (sys_subshell): Likewise.
9121 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9123 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9124 This should get cleaned up, so that child_setup has the
9125 same signature on all platforms.
9127 * callproc.c (call_process_cleanup): Now static.
9128 (relocate_fd): Rename locals to avoid shadowing.
9130 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9132 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9133 not to be necessary, and produces flickering.
9135 2011-03-20 Glenn Morris <rgm@gnu.org>
9137 * config.in: Remove file.
9139 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9141 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9142 are now in src/globals.h.
9143 (syms_of_minibuf): Remove spurious & from previous change.
9145 2011-03-20 Leo Liu <sdl.web@gmail.com>
9147 * minibuf.c (completing-read-function): New variable.
9148 (completing-read-default): Rename from completing-read.
9149 (completing-read): Call completing-read-function.
9151 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9153 * xfaces.c (Fx_load_color_file):
9154 Read color file from absolute filename (bug#8250).
9156 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9158 * makefile.w32-in: Update dependencies.
9160 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9162 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9164 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9166 Fix more problems found by GCC 4.5.2's static checks.
9168 * process.c (make_serial_process_unwind, send_process_trap):
9169 (sigchld_handler): Now static.
9171 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9172 That way, the code declares only the vars that it needs.
9173 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9174 * s/cygwin.h (PTY_ITERATION): Likewise.
9175 * s/darwin.h (PTY_ITERATION): Likewise.
9176 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9178 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9179 * process.c (allocate_pty): Don't declare stb unless it's needed.
9181 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9182 (CONSTANTLIM): Remove; unused.
9183 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9184 Define only if needed.
9186 * unexelf.c (unexec): Name an expression,
9187 to avoid gcc -Wbad-function-cast warning.
9188 Use a different way to cause a compilation error if anyone uses
9189 n rather than nn, a way that does not involve shadowing.
9190 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9192 * deps.mk (unexalpha.o): Remove; unused.
9194 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9195 * unexec.h: New file.
9196 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9197 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9199 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9200 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9201 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9202 Change as necessary to match prototype in unexec.h.
9204 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9206 (back_comment, skip_chars): Mark vars as initialized.
9208 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9209 Rename locals to avoid shadowing.
9211 * lread.c (read1): Rewrite so as not to use empty "else".
9212 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9214 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9216 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9217 warning when compiling print.c.
9219 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9220 instead of using an uninitialized var.
9221 (font_sort_entities): Mark var as initialized.
9223 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9225 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9226 pointers to constants.
9227 (font_parse_fcname): Remove unused vars.
9228 (font_delete_unmatched): Now static.
9229 (font_get_spec): Remove; unused.
9230 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9231 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9232 Rename or move locals to avoid shadowing.
9234 * fns.c (require_nesting_list, require_unwind): Now static.
9235 (Ffillarray): Rename locals to avoid shadowing.
9237 * floatfns.c (domain_error2): Define only if needed.
9238 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9240 * alloc.c (mark_backtrace): Move decl from here ...
9241 * lisp.h: ... to here, so that it can be checked.
9243 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9244 (Fdefvar): Rewrite so as not to use empty "else".
9245 (lisp_indirect_variable): Name an expression,
9246 to avoid gcc -Wbad-function-cast warning.
9247 (Fdefvar): Rename locals to avoid shadowing.
9249 * callint.c (quotify_arg, quotify_args): Now static.
9250 (Fcall_interactively): Rename locals to avoid shadowing.
9251 Use const pointer when appropriate.
9253 * lisp.h (get_system_name, get_operating_system_release):
9254 Move decls here, to check interfaces.
9255 * process.c (get_operating_system_release): Move decl to lisp.h.
9256 * xrdb.c (get_system_name): Likewise.
9257 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9258 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9259 some of which prompt warnings from gcc -Wbad-function-cast.
9260 (Fformat_time_string, Fencode_time, Finsert_char):
9261 (Ftranslate_region_internal, Fformat):
9262 Rename or remove local vars to avoid shadowing.
9263 (Ftranslate_region_internal): Mark var as initialized.
9265 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9268 * lisp.h (eassert): Check that the argument compiles, even if
9269 ENABLE_CHECKING is not defined.
9271 * data.c (Findirect_variable): Name an expression, to avoid
9272 gcc -Wbad-function-cast warning.
9273 (default_value, arithcompare, arith_driver, arith_error): Now static.
9274 (store_symval_forwarding): Rename local to avoid shadowing.
9275 (Fmake_variable_buffer_local, Fmake_local_variable):
9276 Mark variables as initialized.
9277 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9279 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9280 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9281 Rename locals to avoid shadowing.
9282 (mark_stack): Move local variables into the #ifdef region where
9284 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9285 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9287 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9288 (GC_STRING_CHARS): Remove; not used.
9289 (Fmemory_limit): Cast sbrk's returned value to char *.
9291 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9292 avoids undefined behavior in theory.
9294 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9296 Use functions, not macros, for up- and down-casing (Bug#8254).
9297 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9298 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9299 to use the following functions instead of these macros.
9300 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9301 EMACS_INT, since callers assume the returned value fits in int.
9302 (upcase1): Likewise, for UPCASE_TABLE.
9303 (uppercasep, lowercasep, upcase): New static inline functions.
9304 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9305 the race-condition problem in the old DOWNCASE.
9307 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9308 Rename locals to avoid shadowing.
9309 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9310 (regex_compile, re_search_2, re_match_2_internal):
9311 Remove unused local vars.
9312 (FREE_VAR): Rewrite so as not to use empty "else",
9313 which gcc can warn about.
9314 (regex_compile, re_match_2_internal): Mark locals as initialized.
9315 (RETALLOC_IF): Define only if needed.
9316 (WORDCHAR_P): Likewise. This one is never needed, but is used
9317 only in a comment talking about a compiler bug, so put inside
9318 the #if 0 of that comment.
9319 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9320 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9323 * search.c (boyer_moore): Rename locals to avoid shadowing.
9324 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9325 (PREV_CHAR_BOUNDARY): Likewise.
9327 * search.c (simple_search): Remove unused var.
9329 * dired.c (compile_pattern): Move decl from here ...
9330 * lisp.h: ... to here, so that it can be checked.
9331 (struct re_registers): New forward decl.
9333 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9335 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9337 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9338 Rename locals to avoid shadowing.
9339 (Fvertical_motion): Mark locals as initialized.
9341 * casefiddle.c (casify_object, casify_region): Now static.
9342 (casify_region): Mark local as initialized.
9344 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9346 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9347 New macros, so that the caller can use some names other than
9348 gcpro1, gcpro2, etc.
9349 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9351 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9352 argument, for consistency with GCPRO2_VAR, etc: it is now the
9353 prefix of the variable, not the variable itself. All uses
9355 * dired.c (directory_files_internal, file_name_completion):
9356 Rename locals to avoid shadowing.
9358 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9359 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9360 dired.c's scmp function, had undefined behavior.
9361 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9362 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9363 * buffer.h: ... to here, because these macros use current_buffer,
9364 and the new implementation with inline functions needs to have
9365 current_buffer in scope now, rather than later when the macros
9367 (downcase, upcase1): New static inline functions.
9368 (DOWNCASE, UPCASE1): Reimplement using these functions.
9369 This avoids undefined behavior in expressions like
9370 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9371 from race conditions in accessing the global variables
9372 case_temp1 and case_temp2.
9373 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9374 * lisp.h (case_temp1, case_temp2): Remove their decls.
9375 * character.h (ASCII_CHAR_P): Move from here ...
9376 * lisp.h: ... to here, so that the inline functions mentioned
9379 * dired.c (directory_files_internal_unwind): Now static.
9381 * fileio.c (file_name_as_directory, directory_file_name):
9382 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9384 (file_name_as_directory): Use const pointers when appropriate.
9385 (Fexpand_file_name): Likewise. In particular, newdir might
9386 point at constant storage, so make it a const pointer.
9387 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9388 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9390 (Fset_file_times, Finsert_file_contents, auto_save_error):
9391 Rename locals to avoid shadowing.
9393 * minibuf.c (choose_minibuf_frame_1): Now static.
9394 (Ftry_completion, Fall_completions): Rename or remove locals
9397 * marker.c (bytepos_to_charpos): Remove; unused.
9399 * lisp.h (verify_bytepos, count_markers): New decls,
9400 so that gcc does not warn that these functions aren't declared.
9402 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9403 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9404 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9405 (copy_text): Remove unused local var.
9407 * filelock.c (within_one_second): Now static.
9408 (lock_file_1): Rename local to avoid shadowing.
9410 * buffer.c (fix_overlays_before): Mark locals as initialized.
9411 (fix_start_end_in_overlays): Likewise. This function should be
9412 simplified by using pointers-to-pointers, but that's a different
9414 (switch_to_buffer_1): Now static.
9415 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9416 (report_overlay_modification): Rename locals to avoid shadowing.
9418 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9419 Fix pointer signedness issue.
9420 (sys_subshell): Mark local as volatile if checking for lint,
9421 to suppress a gcc -Wclobbered warning that does not seem to be right.
9422 (MAXPATHLEN): Define only if needed.
9424 * process.c (serial_open, serial_configure): Move decls from here ...
9425 * systty.h: ... to here, so that they can be checked.
9427 * fns.c (get_random, seed_random): Move extern decls from here ...
9428 * lisp.h: ... to here, so that they can be checked.
9430 * sysdep.c (reset_io): Now static.
9431 (wait_for_termination_signal): Remove; unused.
9433 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9434 (copy_keymap_item, append_key, push_text_char_description):
9436 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9437 (DENSE_TABLE_SIZE): Remove; unused.
9438 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9439 (describe_map_tree):
9440 Rename locals to avoid shadowing.
9442 * keyboard.c: Declare functions static if they are not used elsewhere.
9443 (echo_char, echo_dash, cmd_error, top_level_2):
9444 (poll_for_input, handle_async_input): Now static.
9445 (read_char, kbd_buffer_get_event, make_lispy_position):
9446 (make_lispy_event, make_lispy_movement, apply_modifiers):
9447 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9448 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9449 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9450 (read_key_sequence, read_char): Mark locals as initialized.
9451 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9453 * keyboard.h (make_ctrl_char): New decl.
9454 (mark_kboards): Move decl here ...
9455 * alloc.c (mark_kboards): ... from here.
9457 * lisp.h (force_auto_save_soon): New decl.
9459 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9460 (DEFINE_DUMMY_FUNCTION): New macro.
9461 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9463 (main): Add casts to avoid warnings
9464 if GCC considers string literals to be constants.
9466 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9468 * dbusbind.c: Pointer signedness fixes.
9469 (xd_signature, xd_append_arg, xd_initialize):
9470 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9471 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9472 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9473 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9475 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9476 if GCC considers string literals to be constants.
9477 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9479 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9481 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9482 (print_preprocess, print_object): New macro to fix last change.
9484 * print.c (print_preprocess): Don't forget font objects.
9486 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9488 * emacs.c (USAGE3): Doc fixes.
9490 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9492 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9495 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9497 * lisp.h (VWindow_system, Qfile_name_history):
9498 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9499 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9500 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9502 * w32select.c: Don't #include "keyboard.h".
9503 (run_protected): Add extern declaration for waiting_for_input.
9505 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9506 * w32console.c (detect_input_pending, read_input_pending)
9507 (encode_terminal_code):
9508 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9509 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9510 (w32_system_caret_y, Qfile_name_history):
9511 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9512 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9513 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9514 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9515 * w32proc.c (Qlocal, report_file_error):
9516 * w32term.c (Vwindow_system, updating_frame):
9517 * w32uniscribe.c (initialized, uniscribe_font_driver):
9518 Remove unneeded extern declarations.
9520 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9522 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9524 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9526 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9527 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9528 These macros can no longer be used for assignment.
9530 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9531 Assign struct members directly, instead of using BUF_BEGV etc.
9532 (record_buffer_markers, fetch_buffer_markers): New functions for
9533 recording and fetching special buffer markers.
9534 (set_buffer_internal_1, set_buffer_temp): Use them.
9536 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9538 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9540 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9541 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9543 * xdisp.c (hscroll_window_tree):
9544 (reconsider_clip_changes): Use PT instead of BUF_PT.
9546 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9548 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9549 $(EMACS_ROOT)/lib/intprops.h.
9551 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9553 Fix more problems found by GCC 4.5.2's static checks.
9555 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9556 to unsigned char * to avoid compiler diagnostic.
9557 (xg_free_frame_widgets): Make it clear that a local variable is
9558 needed only if USE_GTK_TOOLTIP.
9559 (gdk_window_get_screen): Make it clear that this macro is needed
9560 only if USE_GTK_TOOLTIP.
9561 (int_gtk_range_get_value): New function, which avoids a diagnostic
9562 from gcc -Wbad-function-cast.
9563 (xg_set_toolkit_scroll_bar_thumb): Use it.
9564 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9565 diagnostic from gcc -Wbad-function-cast.
9566 (get_utf8_string, xg_get_file_with_chooser):
9567 Rename locals to avoid shadowing.
9568 (create_dialog): Move locals to avoid shadowing.
9570 * xgselect.c (xg_select): Remove unused var.
9572 * image.c (four_corners_best): Mark locals as initialized.
9573 (gif_load): Initialize transparent_p to zero (Bug#8238).
9574 Mark another local as initialized.
9575 (my_png_error, my_error_exit): Mark with NO_RETURN.
9577 * image.c (clear_image_cache): Now static.
9578 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9579 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9580 (x_edge_detection): Remove unnecessary cast that
9581 gcc -Wbad-function-cast diagnoses.
9582 (gif_load): Fix pointer signedness.
9583 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9584 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9586 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9588 Improve quality of tests for time stamp overflow.
9589 For example, without this patch (encode-time 0 0 0 1 1
9590 1152921504606846976) returns the obviously-bogus value (-948597
9591 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9592 reports time overflow. See
9593 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9594 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9595 * editfns.c: Include limits.h and intprops.h.
9596 (TIME_T_MIN, TIME_T_MAX): New macros.
9597 (time_overflow): Move earlier, to before first use.
9598 (hi_time, lo_time): New functions, for an accurate test for
9600 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9601 (Fget_internal_run_time): Don't assume time_t fits in int.
9602 (make_time): Use list2 instead of Fcons twice.
9603 (Fdecode_time): More accurate test for out-of-range times.
9604 (check_tm_member): New function.
9605 (Fencode_time): Use it, to test for out-of-range times.
9606 (lisp_time_argument): Don't rely on undefined left-shift and
9607 right-shift behavior when checking for time stamp overflow.
9609 * editfns.c (time_overflow): New function, refactoring common code.
9610 (Fformat_time_string, Fdecode_time, Fencode_time):
9611 (Fcurrent_time_string): Use it.
9613 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9614 * dired.c (make_time): Move to ...
9615 * editfns.c (make_time): ... here.
9616 * systime.h: Note the move.
9618 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9620 * fringe.c (update_window_fringes): Remove unused variables.
9622 * unexmacosx.c (copy_data_segment): Also copy __got section.
9625 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9627 * termcap.c [MSDOS]: Include "msdos.h".
9628 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9629 Constify `char *' arguments and their references according to
9630 prototypes in tparam.h.
9632 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9634 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9635 Adapt all references accordingly.
9637 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9639 2011-03-11 Tom Tromey <tromey@redhat.com>
9641 * buffer.c (syms_of_buffer): Remove obsolete comment.
9643 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9645 * termhooks.h (encode_terminal_code): Declare prototype.
9647 * msdos.c (encode_terminal_code): Don't declare prototype.
9649 * term.c (encode_terminal_code): Now external again, used by
9650 w32console.c and msdos.c.
9652 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9653 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9655 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9657 Fix some minor problems found by GCC 4.5.2's static checks.
9659 * fringe.c (update_window_fringes): Mark locals as initialized
9661 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9663 * alloc.c (mark_fringe_data): Move decl from here ...
9664 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9665 to check its interface.
9666 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9668 * fontset.c (free_realized_fontset): Now static.
9669 (Fset_fontset_font): Rename local to avoid shadowing.
9670 (fontset_font): Mark local as initialized.
9671 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9673 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9675 * xselect.c (x_disown_buffer_selections): Remove; not used.
9676 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9677 (x_own_selection, Fx_disown_selection_internal): Rename locals
9679 (x_handle_dnd_message): Remove local to avoid shadowing.
9681 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9682 so that the caller can use some name other than gcpro1.
9683 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9684 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9685 (Fx_backspace_delete_keys_p):
9686 Use them to avoid shadowing, and rename vars to avoid shadowing.
9687 (x_decode_color, x_set_name, x_window): Now static.
9688 (Fx_create_frame): Add braces to silence GCC warning.
9689 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9690 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9691 Remove unused locals.
9692 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9693 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9694 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9697 * xterm.h (x_mouse_leave): New decl.
9699 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9700 Remove unused functions.
9701 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9702 (x_calc_absolute_position): Now static.
9703 (XTread_socket): Don't define label "out" unless it's used.
9704 Don't declare local "event" unless it's used.
9705 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9706 unless they are used.
9707 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9708 (x_fatal_error_signal): Remove; not used.
9709 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9710 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9711 (x_error_catcher, x_connection_closed, x_error_handler):
9712 (x_error_quitter, xembed_send_message, x_iconify_frame):
9713 (my_log_handler): Rename locals to avoid shadowing.
9714 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9715 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9717 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9718 Rename or move locals to avoid shadowing.
9719 (tty_defined_color, merge_face_heights): Now static.
9720 (free_realized_faces_for_fontset): Remove; not used.
9721 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9722 does not deduce is never used uninitialized.
9723 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9724 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9726 * terminal.c (store_terminal_param): Now static.
9728 * xmenu.c (menu_highlight_callback): Now static.
9729 (set_frame_menubar): Remove unused local.
9730 (xmenu_show): Rename parameter to avoid shadowing.
9731 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9732 since they might point to immutable storage.
9733 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9734 since it's unused otherwise.
9736 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9737 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9738 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9739 avoids a gcc -Wuninitialized diagnostic.
9740 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9741 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9742 does not deduce are never used uninitialized.
9744 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9746 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9747 * window.c (window_loop, size_window):
9748 (run_window_configuration_change_hook, enlarge_window): Likewise.
9750 * window.c (display_buffer): Now static.
9751 (size_window): Mark variables that gcc -Wuninitialized
9752 does not deduce are never used uninitialized.
9753 * window.h (check_all_windows): New decl, to forestall
9754 gcc -Wmissing-prototypes diagnostic.
9755 * dispextern.h (bidi_dump_cached_states): Likewise.
9757 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9759 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9761 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9762 and to avoid gcc -Wuninitialized warning.
9763 (load_charset_map): Mark variables that gcc -Wuninitialized
9764 does not deduce are never used uninitialized.
9765 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9767 * coding.c (coding_set_source, coding_set_destination):
9768 Use "else { /* comment */ }" rather than "else /* comment */;"
9769 for clarity, and to avoid gcc -Wempty-body warning.
9770 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9771 a block, when the outer 'i' will do.
9772 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9773 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9774 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9775 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9776 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9777 Rename locals to avoid shadowing.
9778 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9779 * coding.c (emacs_mule_char, encode_invocation_designation):
9780 Now static, since they're not used elsewhere.
9781 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9782 (decode_coding_object, encode_coding_object, detect_coding_system):
9783 (decode_coding_emacs_mule): Mark variables that gcc
9784 -Wuninitialized does not deduce are never used uninitialized.
9785 (detect_coding_iso_2022): Initialize a local variable that might
9786 be used uninitialized. Leave a FIXME because it's not clear that
9787 this initialization is needed. (Bug#8211)
9788 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9789 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9790 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9791 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9792 Remove unused macros.
9794 * category.c (hash_get_category_set): Remove unused local var.
9795 (copy_category_table): Now static, since it's not used elsewhere.
9796 * character.c (string_count_byte8): Likewise.
9798 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9799 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9801 * chartab.c (copy_sub_char_table): Now static, since it's not used
9803 (sub_char_table_ref_and_range, char_table_ref_and_range):
9804 Rename locals to avoid shadowing.
9805 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9807 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9808 (BIDI_BOB): Remove unused macro.
9810 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9811 deduce are never used uninitialized.
9812 * term.c (encode_terminal_code): Likewise.
9814 * term.c (encode_terminal_code): Now static. Remove unused local.
9816 * tparam.h: New file.
9817 * term.c, tparam.h: Include it.
9818 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9819 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9820 Move these decls to tparam.h, and make them agree with what
9821 is actually in tparam.c. The previous trick of using incompatible
9822 decls in different modules does not conform to the C standard.
9823 All callers of tparam changed to use tparam's actual API.
9824 * tparam.c (tparam1, tparam, tgoto):
9825 Use const pointers where appropriate.
9827 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9828 * cm.h (struct cm): Likewise.
9829 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9830 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9831 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9832 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9833 (turn_on_face, init_tty): Likewise.
9834 * termchar.h (struct tty_display_info): Likewise.
9836 * term.c (term_mouse_position): Rename local to avoid shadowing.
9838 * alloc.c (mark_ttys): Move decl from here ...
9839 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9841 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9843 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9845 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9847 * search.c (compile_pattern_1): Remove argument regp, unused since
9848 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9849 (compile_pattern): Don't pass it.
9851 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9853 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9854 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9856 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9858 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9860 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9861 gdk_window_get_screen, gdk_window_get_geometry,
9862 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9863 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9864 (xg_get_pixbuf_from_pixmap): New function.
9865 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9866 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9867 Call xg_get_pixbuf_from_pixmap instead of
9868 gdk_pixbuf_get_from_drawable.
9869 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9870 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9871 (xg_check_special_colors): Use GtkStyleContext and its functions
9873 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9874 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9875 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9876 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9877 Call gtk_widget_get_preferred_size.
9878 (xg_frame_resized): gdk_window_get_geometry only takes 5
9880 (xg_win_to_widget, xg_event_is_for_menubar):
9881 Call gdk_x11_window_lookup_for_display.
9882 (xg_set_widget_bg): New function.
9883 (delete_cb): New function.
9884 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9885 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9886 (xg_set_background_color): Call xg_set_widget_bg.
9887 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9888 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9889 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9890 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9892 (update_frame_tool_bar): Call gtk_widget_hide.
9893 (xg_initialize): Use GDK_KEY_g.
9895 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9897 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9899 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9900 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9901 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9903 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9905 * w32xfns.c (select_palette): Check success of RealizePalette against
9906 GDI_ERROR, not zero.
9908 See ChangeLog.11 for earlier changes.
9914 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9916 This file is part of GNU Emacs.
9918 GNU Emacs is free software: you can redistribute it and/or modify
9919 it under the terms of the GNU General Public License as published by
9920 the Free Software Foundation, either version 3 of the License, or
9921 (at your option) any later version.
9923 GNU Emacs is distributed in the hope that it will be useful,
9924 but WITHOUT ANY WARRANTY; without even the implied warranty of
9925 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9926 GNU General Public License for more details.
9928 You should have received a copy of the GNU General Public License
9929 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.