1 2011-12-14 Paul Eggert <eggert@cs.ucla.edu>
3 Fix integer width and related bugs (Bug#9874).
4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
117 Don't assume fixnum fits in int.
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
146 (Fforward_char, Fbackward_char): Use it.
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
154 (ASSURE_DESTINATION, coding_alloc_by_realloc)
155 (coding_alloc_by_making_gap, alloc_destination)
156 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
157 (encode_coding_utf_16, detect_coding_emacs_mule)
158 (decode_coding_emacs_mule, encode_coding_emacs_mule)
159 (detect_coding_iso_2022, decode_coding_iso_2022)
160 (encode_invocation_designation, encode_designation_at_bol)
161 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
162 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
163 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
164 (encode_coding_ccl, encode_coding_raw_text)
165 (detect_coding_charset, decode_coding_charset)
166 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
167 (produce_composition, produce_charset, produce_annotation)
168 (decode_coding, handle_composition_annotation)
169 (handle_charset_annotation, consume_chars, decode_coding_gap)
170 (decode_coding_object, encode_coding_object, detect_coding_system)
171 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
172 (code_convert_region, code_convert_string)
173 (Fdefine_coding_system_internal)
174 (coding_set_source, coding_set_destination):
175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
176 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
177 (Fdefine_coding_system_internal):
178 Don't assume fixnums fit in int.
179 (decode_coding_gap, decode_coding_object, encode_coding_object)
180 (Fread_coding_system, Fdetect_coding_region)
181 (Funencodable_char_position, Fcheck_coding_systems_region)
182 (get_translation, handle_composition_annotation, consume_chars):
183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
184 (consume_chars): Rewrite to not calculate an address outside buffer.
185 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
186 Don't access memory outside of the args array.
187 (Fdefine_coding_system_internal): Check for charset-id overflow.
188 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
189 result of ENCODE_CHAR.
190 * coding.h: Adjust decls to match defn changes elsewhere.
191 (struct coding_system):
192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
193 * composite.c (get_composition_id, find_composition)
194 (run_composition_function, update_compositions)
195 (compose_text, composition_gstring_put_cache)
196 (composition_gstring_p, composition_gstring_width)
197 (fill_gstring_header, fill_gstring_body, autocmp_chars)
198 (composition_compute_stop_pos, composition_reseat_it)
199 (composition_update_it, struct position_record)
200 (find_automatic_composition, composition_adjust_point)
201 (Fcomposition_get_gstring, Ffind_composition_internal):
202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
203 (update_compositions):
204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
205 * composite.h: Adjust decls to match defn changes elsewhere.
206 (struct composition):
207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
208 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
209 Do not attempt to compute the address of the object just before a
210 buffer; this is not portable.
212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
213 (Faset): Use int, not EMACS_INT, where int is wide enough.
214 (Fstring_to_number): Don't assume fixnums fit in int.
215 (Frem): Don't assume arg is nonnegative.
216 * dbusbind.c (xd_append_arg): Check for integers out of range.
217 (Fdbus_call_method): Don't overflow the timeout int.
218 * dired.c (directory_files_internal, file_name_completion, scmp)
219 (file_name_completion_stat):
220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
221 (file_name_completion): Don't overflow matchcount.
222 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
223 * dispextern.h: Adjust decls to match defn changes elsewhere.
224 (struct text_pos, struct glyph, struct bidi_saved_info)
225 (struct bidi_string_data, struct bidi_it, struct composition_it)
227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
228 (struct display_pos, struct composition_it, struct it):
229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
230 * dispnew.c (increment_matrix_positions)
231 (increment_row_positions, mode_line_string)
232 (marginal_area_string):
233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
234 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
236 (duration_to_sec_usec): New function, to check for overflow better.
237 (Fsleep_for, sit_for): Use it.
238 * doc.c (get_doc_string, store_function_docstring):
239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
240 (get_doc_string, Fsnarf_documentation):
241 Use int, not EMACS_INT, where int is wide enough.
243 Use SAFE_ALLOCA, not alloca.
244 Check for overflow when converting EMACS_INT to off_t.
246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
247 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
248 Don't assume uid_t fits into fixnum.
249 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
250 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
251 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
252 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
253 (general_insert_function)
254 (Finsert_char, make_buffer_string, make_buffer_string_both)
255 (update_buffer_properties, Fbuffer_substring)
256 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
257 (Fsubst_char_in_region, check_translation)
258 (Ftranslate_region_internal, save_restriction_restore, Fformat)
259 (transpose_markers, Ftranspose_regions):
260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
261 (clip_to_bounds): Move to lisp.h as an inline function).
262 (Fconstrain_to_field): Don't assume integers are nonnegative.
263 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
264 (Fsubst_char_in_region, Fsave_restriction):
265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
266 (Femacs_pid): Don't assume pid_t fits into fixnum.
267 (lo_time): Use int, not EMACS_INT, when int suffices.
268 (lisp_time_argument): Check for usec out of range.
269 (Fencode_time): Don't assume fixnum fits in int.
270 (Fuser_login_name, Fuser_full_name): Signal an error
271 if a uid argument is out of range, rather than relying on
273 (Fformat_time_string): Remove now-unnecessary check.
274 lisp_time_argument checks for out-of-range usec now.
275 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
276 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
277 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
278 (init_cmdargs, Fdump_emacs):
279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
280 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
281 the bottom (typically) 32 bits of the fixnum.
282 * eval.c (specpdl_size, call_debugger):
283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
284 (when_entered_debugger, Fbacktrace_debug):
285 Don't assume fixnum can fit in int.
286 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
287 the object just before a buffer; this is not portable.
288 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
289 (grow_specpdl, unbind_to):
290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
291 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
292 (grow_specpdl): Simplify allocation by using xpalloc.
293 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
294 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
295 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
297 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
300 (Fcopy_file, non_regular_nbytes, read_non_regular)
301 (Finsert_file_contents):
302 Use int, not EMACS_INT, where int is wide enough.
303 (READ_BUF_SIZE): Verify that it fits in int.
304 (Finsert_file_contents): Check that counts are in proper range,
305 rather than assuming fixnums fit into ptrdiff_t etc.
306 Don't assume fixnums fit into int.
307 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
308 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
309 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
310 (string_char_to_byte, string_byte_to_char)
311 (string_make_multibyte, string_to_multibyte)
312 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
313 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
314 (substring_both, Fdelete, internal_equal, Ffillarray)
315 (Fclear_string, mapcar1)
316 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
317 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
318 (larger_vector, make_hash_table, maybe_resize_hash_table)
319 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
320 (Fmaphash, secure_hash):
321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
322 (concat): Check for string index and length overflow.
323 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
326 (larger_vector): New API (vec, incr_min, size_max) replaces old
327 one (vec, new_size, init). This catches size overflow.
328 INIT was removed because it was always Qnil.
330 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
331 the upper bound on a hash table index size.
332 (make_hash_table, maybe_resize_hash_table): Use it.
333 (secure_hash): Computer start_byte and end_byte only after
334 they're known to be in ptrdiff_t range.
335 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
336 (Ffont_get_glyphs, Ffont_at):
337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
338 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
339 (Flist_fonts, Fopen_font):
340 Don't assume fixnum can fit in int.
341 (check_gstring): Don't assume index can fit in int.
342 (font_match_p): Check that fixnum is a character, not a nonnegative
343 fixnum, since the later code needs to stuff it into an int.
344 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
345 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
346 conversion overflow issues.
347 (Fopen_font): Check for integer out of range.
348 (Ffont_get_glyphs): Don't assume index can fit in int.
349 * font.h: Adjust decls to match defn changes elsewhere.
350 * fontset.c (reorder_font_vector): Redo score calculation to avoid
352 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
353 printmax_t, where ptrdiff_t is wide enough.
354 (Finternal_char_font):
355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
356 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
357 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
358 (Fset_frame_position, x_set_frame_parameters)
359 (x_set_line_spacing, x_set_border_width)
360 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
361 Check that fixnums are in proper range for system types.
362 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
364 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
365 Use SAFE_ALLOCA_LISP, not alloca.
366 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
367 intptr_t is wide enough.
368 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
369 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
370 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
371 Check for fixnum out of range.
372 * ftfont.c (ftfont_list): Don't assume index fits in int.
373 Check that fixnums are in proper range for system types.
374 (ftfont_shape_by_flt):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
378 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
379 Check that fixnums are in proper range for system types.
380 * gnutls.h: Adjust decls to match defn changes elsewhere.
381 * gtkutil.c (xg_dialog_run):
382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
383 (update_frame_tool_bar):
384 Check that fixnums are in proper range for system types.
385 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
386 (lookup_image): Check that fixnums are in range for system types.
387 * indent.c (last_known_column, last_known_column_point):
388 (current_column_bol_cache):
389 (skip_invisible, current_column, check_display_width):
390 (check_display_width, scan_for_column, current_column_1)
391 (Findent_to, Fcurrent_indentation, position_indentation)
392 (indented_beyond_p, Fmove_to_column, compute_motion):
393 (Fcompute_motion, Fvertical_motion):
394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
395 (last_known_column_modified): Use EMACS_INT, not int.
396 (check_display_width):
398 Check that fixnums and floats are in proper range for system types.
399 (compute_motion): Don't assume index or fixnum fits in int.
400 (compute_motion, Fcompute_motion):
401 Use int, not EMACS_INT, when it is wide enough.
402 (vmotion): Omit local var start_hpos that is always 0; that way
403 we don't need to worry about overflow in expressions involving it.
404 * indent.h: Adjust decls to match defn changes elsewhere.
406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
407 Use int, not EMACS_INT, where int is wide enough.
408 Remove unused members ovstring_chars_done and tab_offset;
410 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
411 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
412 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
413 (make_gap, copy_text, insert, insert_and_inherit)
414 (insert_before_markers, insert_before_markers_and_inherit)
415 (insert_1, count_combining_before, count_combining_after)
416 (insert_1_both, insert_from_string)
417 (insert_from_string_before_markers, insert_from_string_1)
418 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
419 (adjust_after_replace, adjust_after_insert, replace_range)
420 (replace_range_2, del_range, del_range_1, del_range_byte)
421 (del_range_both, del_range_2, modify_region)
422 (prepare_to_modify_buffer, signal_before_change)
423 (signal_after_change, Fcombine_after_change_execute):
424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
425 * intervals.c (traverse_intervals, rotate_right, rotate_left)
426 (balance_an_interval, split_interval_right, split_interval_left)
427 (find_interval, next_interval, update_interval)
428 (adjust_intervals_for_insertion, delete_node, delete_interval)
429 (interval_deletion_adjustment, adjust_intervals_for_deletion)
430 (static_offset_intervals, offset_intervals)
431 (merge_interval_right, merge_interval_left, make_new_interval)
432 (graft_intervals_into_buffer, temp_set_point_both)
433 (temp_set_point, set_point, adjust_for_invis_intang)
434 (set_point_both, move_if_not_intangible, get_property_and_range)
435 (get_local_map, copy_intervals, copy_intervals_to_string)
436 (compare_string_intervals, set_intervals_multibyte_1):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 * intervals.h: Adjust decls to match defn changes elsewhere.
440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
441 * keyboard.c (this_command_key_count, this_single_command_key_start)
442 (before_command_key_count, before_command_echo_length, echo_now)
443 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
444 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
445 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
446 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
448 (last_non_minibuf_size, last_point_position, echo_truncate)
449 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
450 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
451 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
452 (stuff_buffered_input):
453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
454 (last_auto_save, command_loop_1, read_char):
455 Use EMACS_INT, not int, to avoid integer overflow.
456 (record_char): Avoid overflow in total_keys computation.
457 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
458 * keyboard.h: Adjust decls to match defn changes elsewhere.
459 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
460 (Fkey_description, Fdescribe_vector, Flookup_key):
461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
462 (click_position): New function, to check that positions are in range.
463 (Fcurrent_active_maps):
465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
466 (Faccessible_keymaps, Fkey_description):
467 (preferred_sequence_p):
468 Don't assume fixnum can fit into int.
469 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
470 Check for integer overflow in size calculations.
471 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
472 avoid mishandling large integers.
473 * lisp.h: Adjust decls to match defn changes elsewhere.
474 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
475 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
476 (struct Lisp_Marker):
477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
478 (clip_to_bounds): Now an inline function, moved here from editfns.c.
479 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
480 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
482 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
483 Assume the arg has valid form, since it always does.
484 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
485 unsigned integer system type.
486 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
487 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
489 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
490 (duration_to_sec_usec): New decl.
491 * lread.c (read_from_string_index, read_from_string_index_byte)
492 (read_from_string_limit, readchar, unreadchar, openp)
493 (read_internal_start, read1, oblookup):
494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
495 (Fload, readevalloop, Feval_buffer, Feval_region):
496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
497 (openp): Check for out-of-range argument to 'access'.
498 (read1): Use int, not EMACS_INT, where int is wide enough.
499 Don't assume fixnum fits into int.
500 Fix off-by-one error that can read outside a buffer.
501 (read_filtered_event): Use duration_to_sec_usec
502 to do proper overflow checking on durations.
503 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
505 (Fexecute_kbd_macro):
506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
507 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
508 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
509 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
510 (set_marker_both, set_marker_restricted_both, marker_position)
511 (marker_byte_position, Fbuffer_has_markers_at):
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
513 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
514 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
515 It now merely ensures that the menu is large enough, without
516 necessarily growing it, as this avoids some integer overflow issues.
518 (keymap_panes, parse_single_submenu, Fx_popup_menu):
519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
520 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
521 Use SAFE_ALLOCA_LISP, not alloca.
522 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
523 to EMACS_INT. Check that fixnums are in proper range for system types.
524 * minibuf.c (minibuf_prompt_width, string_to_object)
525 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
526 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
528 (get_minibuffer, read_minibuf_unwind):
529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
530 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
531 this simplifies overflow checking. All callers changed.
532 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
536 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
537 Check that fixnums are in proper range for system types.
538 (Fx_create_frame, Fx_show_tip):
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 * nsfont.m (ns_findfonts, nsfont_list_family):
541 Don't assume fixnum fits in long.
542 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
544 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
546 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
548 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
549 (PRINTDECLARE, PRINTPREPARE):
550 (strout, print_string):
551 (print, print_preprocess, print_check_string_charset_prop)
553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
555 (temp_output_buffer_setup, Fprin1_to_string, print_object):
556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
557 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
558 (printchar, strout): Use xpalloc to catch size calculation overflow.
559 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
560 (print_error_message): Use SAFE_ALLOCA, not alloca.
561 (print_object): Use int, not EMACS_INT, where int is wide enough.
562 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
563 (Fset_process_window_size, Fformat_network_address)
564 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
566 Check that fixnums are in proper range for system types.
567 (Fsignal_process): Simplify by avoiding a goto.
568 Check for process-ids out of pid_t range rather than relying on
570 (Fformat_network_address, read_process_output, send_process)
571 (Fprocess_send_region, status_notify):
572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
573 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
574 (wait_reading_process_output, read_process_output, exec_sentinel):
575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
576 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
577 (Faccept_process_output): Use duration_to_sec_usec to do proper
578 overflow checking on durations.
579 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
580 Don't assume pid_t fits in int.
581 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
582 configured --with-wide-int.
583 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
584 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
585 * search.c (looking_at_1, string_match_1):
586 (fast_string_match, fast_c_string_match_ignore_case)
587 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
588 (scan_newline, find_before_next_newline, search_command)
589 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
590 (set_search_regs, wordify):
593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
594 (string_match_1, search_buffer, set_search_regs):
596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
597 (wordify): Check for overflow in size calculation.
598 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
599 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
600 Check that fixnums are in proper range for system types.
601 * sound.c (struct sound_device)
602 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
604 (Fplay_sound_internal):
605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
606 * syntax.c (struct lisp_parse_state, find_start_modiff)
607 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
608 (Fparse_partial_sexp):
609 Don't assume fixnums can fit in int.
610 (struct lisp_parse_state, find_start_pos, find_start_value)
611 (find_start_value_byte, find_start_begv)
612 (update_syntax_table, char_quoted, dec_bytepos)
613 (find_defun_start, prev_char_comend_first, back_comment):
614 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
615 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
617 (Finternal_describe_syntax_value): Check that match_lisp is a
618 character, not an integer, since the code stuffs it into int.
619 (scan_words, scan_sexps_forward):
620 Check that fixnums are in proper range for system types.
622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
623 (scan_sexps_forward):
624 Use CHARACTERP, not INTEGERP, since the value must fit into int.
625 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
626 * syntax.h: Adjust decls to match defn changes elsewhere.
628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
629 * sysdep.c (wait_for_termination_1, wait_for_termination)
630 (interruptible_wait_for_termination, mkdir):
631 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
632 (emacs_read, emacs_write):
633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
634 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
635 and double all fit in int.
636 * term.c (set_tty_color_mode):
637 Check that fixnums are in proper range for system types.
638 * termhooks.h (struct input_event):
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 * textprop.c (validate_interval_range, interval_of)
641 (Fadd_text_properties, set_text_properties_1)
642 (Fremove_text_properties, Fremove_list_of_text_properties)
643 (Ftext_property_any, Ftext_property_not_all)
644 (copy_text_properties, text_property_list, extend_property_ranges)
645 (verify_interval_modification):
646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
647 (Fnext_single_char_property_change)
648 (Fprevious_single_char_property_change):
649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
650 (copy_text_properties):
651 Check for integer overflow in index calculation.
652 * undo.c (last_boundary_position, record_point, record_insert)
653 (record_delete, record_marker_adjustment, record_change)
654 (record_property_change):
655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
656 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
658 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
659 (Fx_hide_tip, Fx_file_dialog):
660 * w32menu.c (set_frame_menubar):
661 Use ptrdiff_t, not int, for consistency with rest of code.
662 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
663 (select_window, Fdelete_other_windows_internal)
664 (window_scroll_pixel_based, window_scroll_line_based)
665 (Frecenter, Fset_window_configuration):
666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
667 (Fset_window_hscroll, run_window_configuration_change_hook)
668 (set_window_buffer, temp_output_buffer_show, scroll_command)
669 (Fscroll_other_window, Frecenter):
670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
671 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
672 Don't assume fixnum fits in int.
673 (Fset_window_scroll_bars):
674 Check that fixnums are in proper range for system types.
675 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
676 (string_pos, c_string_pos, number_of_chars, init_iterator)
677 (in_ellipses_for_invisible_text_p, init_from_display_pos)
678 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
679 (compute_display_string_end, handle_face_prop)
680 (face_before_or_after_it_pos, handle_invisible_prop)
681 (handle_display_prop, handle_display_spec, handle_single_display_spec)
682 (display_prop_intangible_p, string_buffer_position_lim)
683 (string_buffer_position, handle_composition_prop, load_overlay_strings)
684 (get_overlay_strings_1, get_overlay_strings)
685 (iterate_out_of_display_property, forward_to_next_line_start)
686 (back_to_previous_visible_line_start, reseat, reseat_to_string)
687 (get_next_display_element, set_iterator_to_next)
688 (get_visually_first_element, compute_stop_pos_backwards)
689 (handle_stop_backwards, next_element_from_buffer)
690 (move_it_in_display_line_to, move_it_in_display_line)
691 (move_it_to, move_it_vertically_backward, move_it_by_lines)
692 (add_to_log, message_dolog, message_log_check_duplicate)
693 (message2, message2_nolog, message3, message3_nolog
694 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
695 (current_message_1, truncate_echo_area, truncate_message_1)
696 (set_message, set_message_1, store_mode_line_noprop)
697 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
698 (text_outside_line_unchanged_p, check_point_in_composition)
699 (reconsider_clip_changes)
700 (redisplay_internal, set_cursor_from_row, try_scrolling)
701 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
702 (redisplay_window, find_last_unchanged_at_beg_row)
703 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
704 (trailing_whitespace_p, find_row_edges, display_line)
705 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
706 (display_mode_element, store_mode_line_string)
707 (pint2str, pint2hrstr, decode_mode_spec)
708 (display_count_lines, display_string, draw_glyphs)
709 (x_produce_glyphs, x_insert_glyphs)
710 (rows_from_pos_range, mouse_face_from_buffer_pos)
711 (fast_find_string_pos, mouse_face_from_string_pos)
712 (note_mode_line_or_margin_highlight, note_mouse_highlight):
713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
714 (safe_call, init_from_display_pos, handle_fontified_prop)
715 (handle_single_display_spec, load_overlay_strings)
716 (with_echo_area_buffer, setup_echo_area_for_printing)
717 (display_echo_area, echo_area_display)
718 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
719 (update_tool_bar, hscroll_window_tree, redisplay_internal)
720 (redisplay_window, dump_glyph_row, display_mode_line)
721 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
722 (handle_display_spec, display_prop_string_p):
723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
724 (handle_single_display_spec, build_desired_tool_bar_string)
725 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
726 (get_specified_cursor_type):
727 Check that fixnums are in proper range for system types.
728 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
730 Don't assume fixnums fit in int.
731 (compare_overlay_entries):
732 Avoid mishandling comparisons due to subtraction overflow.
733 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
734 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
735 (handle_tool_bar_click):
736 Use int, not unsigned, since we prefer signed and the signedness
738 (get_next_display_element, next_element_from_display_vector):
739 Use int, not EMACS_INT, when int is wide enough.
740 (start_hourglass): Use duration_to_sec_usec to do proper
741 overflow checking on durations.
742 * xfaces.c (Fbitmap_spec_p):
743 Check that fixnums are in proper range for system types.
744 (compare_fonts_by_sort_order):
745 Avoid mishandling comparisons due to subtraction overflow.
746 (Fx_family_fonts, realize_basic_faces):
747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
749 Don't assume fixnum fits in int.
750 Use SAFE_ALLOCA_LISP, not alloca.
751 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
752 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
753 (face_at_buffer_position, face_for_overlay_string)
754 (face_at_string_position):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
757 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
759 Check that fixnums are in proper range for system types.
760 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
761 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
763 (Fx_change_window_property): Don't assume fixnums fit in int.
764 * xfont.c (xfont_chars_supported):
765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
766 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
767 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
769 * xml.c (parse_region):
770 * xrdb.c (magic_file_p):
771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
772 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
773 (x_get_local_selection, x_reply_selection_request)
774 (x_handle_selection_request, wait_for_property_change):
775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
776 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
777 short is wide enough.
778 (x_send_client_event): Don't assume fixnum fits in int.
779 * xterm.c (x_x_to_emacs_modifiers):
780 Don't assume EMACS_INT overflows nicely into int.
781 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
783 (handle_one_xevent): NATNUMP can eval its arg twice.
784 (x_connection_closed):
785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
786 * xterm.h: Adjust decls to match defn changes elsewhere.
787 (struct scroll_bar): Use struct vectorlike_header
788 rather than rolling our own approximation.
789 (SCROLL_BAR_VEC_SIZE): Remove; not used.
791 2011-12-13 Martin Rudalics <rudalics@gmx.at>
793 * window.c (Vwindow_combination_resize)
794 (Vwindow_combination_limit): Use t instead of non-nil in
796 (Vrecenter_redisplay): Add first sentence of doc-string on
798 (Frecenter): Fix doc-string typo.
800 2011-12-11 Kenichi Handa <handa@m17n.org>
802 * coding.c (Funencodable_char_position): Pay attention to the
803 buffer text relocation (Bug#9389).
805 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
807 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
808 gtk_init (Bug#10100).
810 2011-12-10 Eli Zaretskii <eliz@gnu.org>
812 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
813 IT->string is nil. (Bug#10263)
815 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
817 * nsterm.h (x_free_frame_resources): Declare.
819 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
820 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
822 * nsterm.h (ns_get_defaults_value): Declare.
824 * nsterm.m (ns_default): Call ns_get_defaults_value.
826 2011-12-09 Eli Zaretskii <eliz@gnu.org>
828 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
831 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
833 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
834 that where the value of an _OBJC_* symbol points to is in the .bss
837 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
839 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
840 after the loop to call ccl_driver at least once (Bug#8619).
842 2011-12-08 Kenichi Handa <handa@m17n.org>
844 * ftfont.c (get_adstyle_property): Fix previous change
847 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
849 * w32.c (init_environment): If no_site_lisp, remove site-lisp
850 dirs from the default value of EMACSLOADPATH (bug#10208).
852 2011-12-07 Glenn Morris <rgm@gnu.org>
854 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
855 installation and source directories as well. (Bug#10208)
857 2011-12-06 Chong Yidong <cyd@gnu.org>
859 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
861 2011-12-06 Glenn Morris <rgm@gnu.org>
863 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
864 as an error, not just -1. (Bug#10217)
866 2011-12-05 Chong Yidong <cyd@gnu.org>
868 * keyboard.c (process_special_events): New function.
869 (swallow_events, Finput_pending_p): Use it (Bug#10195).
871 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
873 * coding.c (encode_designation_at_bol): Don't use uninitialized
874 local variable (Bug#9318).
876 2011-12-05 Kenichi Handa <handa@m17n.org>
878 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
879 return Qnil (Bug#8046, Bug#10193).
881 2011-12-05 Kenichi Handa <handa@m17n.org>
883 * coding.c (encode_designation_at_bol): New args charbuf_end and
884 dst. Return the number of produced bytes. Callers changed.
885 (coding_set_source): Return how many bytes coding->source was
887 (coding_set_destination): Return how many bytes
888 coding->destination was relocated.
889 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
890 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
892 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
894 * coding.c (CODING_CHAR_CHARSET_P): New macro.
895 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
898 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
900 The following changes are to fix Bug#9318.
902 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
903 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
904 (encode_coding_iso_2022, encode_coding_sjis)
905 (encode_coding_big5, encode_coding_charset): Use the above macros.
907 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
909 * lisp.h (process_quit_flag): Fix external declaration.
911 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
913 Don't macro-inline non-performance-critical code.
914 * eval.c (process_quit_flag): New function.
915 * lisp.h (QUIT): Use it.
917 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
919 * nsfns.m (get_geometry_from_preferences): New function.
920 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
922 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
924 * emacs.c (Qkill_emacs): Define.
925 (syms_of_emacs): Initialize it.
926 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
927 Qquit_flag to `kill-emacs' instead.
928 (quit_throw_to_read_char): Add parameter `from_signal'.
929 All callers changed. Call Fkill_emacs if requested and safe.
930 * lisp.h (QUIT): Call Fkill_emacs if requested.
932 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
934 * widget.c (update_wm_hints): Return if wmshell is null.
935 (widget_update_wm_size_hints): New function.
937 * widget.h (widget_update_wm_size_hints): Declare.
939 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
940 widget_update_wm_size_hints (Bug#10104).
942 2011-12-03 Eli Zaretskii <eliz@gnu.org>
944 * xdisp.c (handle_invisible_prop): If the invisible text ends just
945 before a newline, prepare the bidi iterator for consuming the
946 newline, and keep the current paragraph direction. (Bug#10183)
947 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
949 2011-12-02 Juri Linkov <juri@jurta.org>
951 * search.c (Fword_search_regexp): New Lisp function created from
952 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
953 (Fword_search_backward, Fword_search_forward)
954 (Fword_search_backward_lax, Fword_search_forward_lax):
955 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
956 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
958 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
960 * fileio.c (Finsert_file_contents): Move after-change-function call
961 to before the "handled:" label, since all "goto handled" appear in
962 cases where the *-change-functions have already been properly called
965 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
967 * keyboard.c (interrupt_signal): Don't call kill-emacs when
968 waiting for input. (Bug#10169)
970 2011-11-30 Eli Zaretskii <eliz@gnu.org>
972 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
973 verifies glyph row's hash code--we have just reallocated the
974 glyphs, so their contents can be complete garbage. (Bug#10164)
976 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
978 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
980 2011-11-30 Eli Zaretskii <eliz@gnu.org>
982 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
983 attributes are tested _before_ calling verify_row_hash, to protect
984 against GCC re-ordering of the tests. (Bug#10164)
986 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
988 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
990 * xterm.c (handle_one_xevent): Only set async_visible and friends
991 if net_wm_state_hidden_seen is non-zero (Bug#10002)
992 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
993 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
995 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
997 Remove GCPRO-related macros that exist only to avoid shadowing locals.
998 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
999 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1000 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1001 All uses changed to use GCPRO1 etc.
1002 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1003 Revert to old implementation (i.e., before 2011-03-11).
1005 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1007 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1008 of scroll runs so as to avoid assigning disabled bogus rows and
1009 unnecessary graphics copy operations.
1011 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1013 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1014 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1015 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1016 (malloc, free, realloc, calloc): Redirect to e_* only when
1019 * lisp.h (GCTYPEBITS): Move before first use.
1020 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1021 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1022 this macro definition.
1024 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1027 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1029 * gtkutil.c (xg_create_frame_widgets):
1030 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1031 present with Gtk+ 2.0.
1033 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1035 * fileio.c (Finsert_file_contents): Undo previous change; see
1036 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1038 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1040 Rename locals to avoid shadowing.
1041 * fileio.c (Finsert_file_contents):
1042 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1043 * process.c (wait_reading_process_output):
1044 Rename inner 'proc' to 'p' to avoid shadowing.
1045 Indent for consistency with usual Emacs style.
1047 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1049 * xdisp.c (redisplay_window): If cursor row is not fully visible
1050 after recentering, and scroll-conservatively is set to a large
1051 number, scroll window by a few more lines to make the cursor fully
1052 visible and out of scroll-margin. (Bug#10105)
1053 (start_display): Don't move to the next line if the display should
1054 start at a newline that is part of a display vector or an overlay
1057 2011-11-24 Juri Linkov <juri@jurta.org>
1059 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1060 after the `MagickPingImage' call. (Bug#10112)
1062 2011-11-23 Chong Yidong <cyd@gnu.org>
1064 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1066 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1068 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1069 making another buffer current. (Bug#10114)
1071 2011-11-23 Glenn Morris <rgm@gnu.org>
1073 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1075 2011-11-23 Chong Yidong <cyd@gnu.org>
1077 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1078 using it (Bug#5984).
1080 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1082 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1083 and header-lines, as they don't have one computed for them.
1086 * .gdbinit (prow): Make displayed values more self-explaining.
1087 Add row's hash code.
1089 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1091 * process.c (wait_reading_process_output): Fix asynchrounous
1092 GnuTLS socket handling on some versions of the GnuTLS library.
1093 (wait_reading_process_output): Add comment and URL.
1095 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1097 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1099 2011-11-21 Chong Yidong <cyd@gnu.org>
1101 * window.c (Fnext_window, Fprevious_window): Doc fix.
1103 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1105 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1107 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1109 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1111 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1113 * window.c (Fset_window_combination_limit): Rename argument
1115 (Vwindow_combination_limit): Remove "status" from doc-string.
1117 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1119 * m/ibms390.h: Remove.
1120 * m/ibms390x.h: Don't include "ibms390.h".
1122 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1124 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1125 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1127 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1129 * casetab.c (Fset_case_table):
1130 * charset.c (Fcharset_after): Fix typos.
1132 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1134 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1135 Otherwise, valgrind does not work on some platforms.
1136 Problem reported by Andreas Schwab in
1137 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1138 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1139 is set, removing the need for VIRT_ADDRESS_VARIES.
1140 (PURE_P): Use a more-efficient implementation that needs just one
1141 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1142 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1143 to 4 (xorl, subq, cmpq, setbe).
1144 * alloc.c (pure): Always extern now, since that's the
1145 VIRT_ADDR_VARIES behavior.
1146 (PURE_POINTER_P): Use a single comparison, not two, for
1147 consistency with the new puresize.h.
1148 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1149 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1150 Remove VIRT_ADDR_VARIES no longer needed.
1152 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1154 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1155 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1156 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1157 behave as if the cursor position were at the window margin.
1159 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1160 and the cursor position is out of bounds, behave as if the cursor
1161 position were at the window margin. (Bug#10075)
1163 2011-11-18 Chong Yidong <cyd@gnu.org>
1165 * window.c (Fwindow_combination_limit): Make first argument
1166 non-optional, since it is meaningless for live windows like the
1169 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1171 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1173 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1175 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1176 (graft_intervals_into_buffer): Simplify.
1178 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1180 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1181 hash values of the two rows.
1182 (copy_row_except_pointers): Preserve the used[] arrays and the
1183 hash values of the two rows. (Bug#10035)
1184 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1186 * xdisp.c (row_hash): New function, body extracted from
1187 compute_line_metrics.
1188 (compute_line_metrics): Call row_hash, instead of computing the
1191 * dispnew.c (verify_row_hash): Call row_hash for computing the
1192 hash code of a row, instead of duplicating code from xdisp.c.
1194 * dispextern.h (row_hash): Add prototype.
1196 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1198 * frame.c (delete_frame): Don't delete the terminal when the last
1199 X frame is closed if emacs is built with GTK toolkit.
1201 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1203 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1205 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1207 * window.c (Vwindow_splits): Rename to
1208 Vwindow_combination_resize. Suggested by Juri Linkov.
1209 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1212 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1214 * nsfns.m (Fns_font_name):
1215 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1217 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1219 * window.h (window): Rename slot "nest" to "combination_limit".
1220 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1221 (Fset_window_nest): Rename to Fset_window_combination_limit.
1222 (Vwindow_nest): Rename to Vwindow_combination_limit.
1223 (recombine_windows, make_parent_window, make_window)
1224 (Fsplit_window_internal, saved_window)
1225 (Fset_window_configuration, save_window_save): Rename all
1226 occurrences of window_nest to window_combination_limit.
1228 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1230 * image.c (imagemagick_load_image): Fix typo.
1232 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1234 * xdisp.c (display_line): Move the call to
1235 highlight_trailing_whitespace before the call to
1236 compute_line_metrics, since the latter needs to see the final
1237 faces of all the glyphs to compute ROW's hash value.
1238 Fixes assertion violations in row_equal_p. (Bug#10035)
1240 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1242 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1243 just return (bug#10044).
1245 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1247 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1248 with user-defined heap size. Bump the default size of the temacs
1249 heap to 27MB, to avoid memory warning when running temacs.
1250 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1252 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1253 current_matrix and desired_matrix. (Bug#9990)
1254 (verify_row_hash) [XASSERTS]: New function.
1255 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1256 that the hash value of glyph rows is correct.
1258 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1260 * window.h (window): Remove splits slot.
1261 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1262 (Fdelete_other_windows_internal, make_parent_window)
1263 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1264 (Fset_window_configuration, save_window_save): Don't deal with
1265 split status of windows.
1266 (saved_window): Remove splits slot.
1267 (Vwindow_splits): Rewrite doc-string.
1269 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1271 * xfns.c (unwind_create_frame):
1272 * nsfns.m (unwind_create_frame):
1273 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1274 Vframe_list (Bug#9999).
1276 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1278 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1280 2011-11-11 Kenichi Handa <handa@m17n.org>
1282 * callproc.c (Fcall_process): Set the member dst_multibyte of
1285 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1287 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1288 avoid a crash (bug#9496).
1290 2011-11-09 Chong Yidong <cyd@gnu.org>
1292 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1293 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1295 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1297 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1299 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1301 Avoid some portability problems by eschewing 'extern inline' functions.
1302 The trivial performance wins aren't worth the portability hassles; see
1303 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1305 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1306 (window_box_width, window_box_left, window_box_left_offset)
1307 (window_box_right, window_box_right_offset): Undo previous change,
1308 by removing the "extern"s.
1309 * intervals.c (adjust_intervals_for_insertion)
1310 (adjust_intervals_for_deletion): Undo previous change,
1311 making these static again.
1312 (offset_intervals, temp_set_point_both, temp_set_point)
1313 (copy_intervals_to_string): No longer inline.
1314 * xdisp.c (window_text_bottom_y, window_box_width)
1315 (window_box_height, window_box_left_offset)
1316 (window_box_right_offset, window_box_left, window_box_right)
1317 (window_box): No longer inline.
1319 2011-11-08 Chong Yidong <cyd@gnu.org>
1321 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1322 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1323 Signal an error if not a live window.
1324 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1325 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1327 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1329 * lisp.h (syms_of_abbrev): Remove declaration.
1330 Reported by CHENG Gao <chenggao@royau.me>.
1332 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1334 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1335 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1336 of temacs in GUI mode.
1338 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1340 * window.h: Declare delete_all_child_windows instead of
1341 delete_all_subwindows.
1342 * window.c (Fwindow_nest, Fset_window_nest)
1343 (Fset_window_new_total, Fset_window_new_normal)
1344 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1345 (delete_all_subwindows): Rename to delete_all_child_windows.
1346 (Fdelete_other_windows_internal, Fset_window_configuration):
1347 Call delete_all_child_windows instead of delete_all_subwindows.
1348 * frame.c (delete_frame): Call delete_all_child_windows instead
1349 of delete_all_subwindows.
1351 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1353 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1354 This is also needed for porting to any host where GC_MARK_STACK is
1355 not GC_MAKE_GCPROS_NOOPS.
1356 (which_symbols): Use it.
1358 2011-11-07 Kenichi Handa <handa@m17n.org>
1360 * coding.c (coding_set_destination): Check coding->src_pos only
1361 when coding->src_object is a buffer (bug#9910).
1363 * process.c (send_process): Set the member src_multibyte of coding
1364 to 0 (bug#9911) when sending a unibyte text.
1366 * callproc.c (Fcall_process): Set the member src_multibyte of
1367 process_coding to 0 (bug#9912).
1369 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1371 * xmenu.c (cleanup_widget_value_tree): New function.
1372 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1373 calling free_menubar_widget_value_tree directly (Bug#9830).
1375 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1377 Fix some portability problems with 'inline'.
1378 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1379 (window_box_width, window_box_left, window_box_left_offset)
1380 (window_box_right, window_box_right_offset): Declare extern.
1381 Otherwise, these inline functions do not conform to C99 and
1382 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1383 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1384 * intervals.c (adjust_intervals_for_insertion)
1385 (adjust_intervals_for_deletion): Now extern, because otherwise the
1386 extern inline functions 'offset_intervals' couldn't refer to it.
1387 (static_offset_intervals): Remove.
1388 (offset_intervals): Rewrite using the old contents of
1389 static_offset_intervals. The old version didn't conform to C99
1390 because an extern inline function contained a reference to an
1391 identifier with static linkage.
1393 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1395 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1398 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1400 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1401 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1402 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1403 return Qleft_to_right.
1405 2011-11-06 Chong Yidong <cyd@gnu.org>
1407 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1408 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1409 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1410 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1411 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1412 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1413 (Fwindow_vscroll): Doc fix.
1414 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1415 argument, since it makes no sense to pass a live window and for
1416 consistency with window-child.
1418 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1420 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1423 2011-11-05 Jason Rumney <jasonr@gnu.org>
1425 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1426 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1428 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1429 bitwise arithmetic preventing use of unicode-sip and non-truetype
1432 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1434 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1437 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1438 initialization code to keep similarity to xfns.c after changes
1441 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1443 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1444 (unwind_create_frame): New function (Bug#9943).
1445 (Fx_create_frame): Restructure code to be more similar to the one in
1446 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1447 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1448 Move terminal->reference_count++ just before making the frame official
1451 * nsterm.m (x_free_frame_resources): New function.
1452 (x_destroy_window): Move code to x_free_frame_resources.
1454 * xfns.c (unwind_create_frame): Fix comment.
1455 (Fx_create_frame, x_create_tip_frame):
1456 Move terminal->reference_count++ just before making the frame
1457 official. Move initialization of image_cache_refcount and
1458 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1460 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1462 Support MSVC build with newer versions of Visual Studio.
1463 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1464 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1467 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1468 which are not supported by MSVC.
1469 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1470 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1472 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1474 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1476 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1478 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1480 Support MSVC build with newer versions of Visual Studio.
1481 * w32.c: Don't include w32api.h for MSVC.
1482 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1484 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1485 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1486 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1487 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1489 (alloca) [_MSC_VER]: Define to _alloca.
1491 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1493 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1495 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1497 * xdisp.c (note_mouse_highlight): If either of
1498 previous/next-single-property-change returns nil, treat that as
1499 the beginning or the end of the buffer. (Bug#9955)
1501 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1503 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1504 label is not null (Bug#9951).
1505 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1508 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1510 * window.c (Fwindow_body_size): Mention in the doc string that the
1511 return value is in frame's canonical units. (Bug#9949)
1513 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1515 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1517 * w32fns.c (unwind_create_frame): If needed, free the glyph
1518 matrices of the partially constructed frame. (Bug#9943)
1519 * xfns.c (unwind_create_frame): Likewise.
1521 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1523 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1524 Don't stop backward scan on the continuation glyph, even though
1525 its CHARPOS is positive.
1526 (mouse_face_from_buffer_pos, note_mouse_highlight):
1527 Rename cover_string to disp_string.
1529 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1531 * window.c (temp_output_buffer_show): Don't use
1532 Vtemp_buffer_show_specifiers.
1533 (Vtemp_buffer_show_specifiers): Remove unused variable.
1535 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1537 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1538 past the beginning of the current glyph matrix.
1540 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1542 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1543 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1544 HAVE_GTK3 (Bug#9869).
1546 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1547 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1549 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1551 * xterm.c: Declare x_handle_net_wm_state to return int.
1552 (handle_one_xevent): Check if we are iconified but don't have
1553 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1554 (get_current_wm_state): Return non-zero if not hidden,
1555 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1556 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1557 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1558 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1560 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1562 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1563 so that this new function doesn't get optimized away by a
1564 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1566 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1568 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1570 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1572 Fix the `xbytecode' command.
1573 * .gdbinit (xprintbytestr): New command.
1574 (xwhichsymbols): Rename from `which'; all callers changed.
1575 (xbytecode): Print the byte-code string as well.
1577 2011-10-29 Kim Storm <storm@cua.dk>
1579 * alloc.c (which_symbols): New function.
1581 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1583 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1586 2011-10-29 Glenn Morris <rgm@gnu.org>
1588 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1589 Not clear what it was for, and it causes various bugs. (Bug#9839)
1591 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1593 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1594 possible random value that matches one of those tested as
1595 condition to clear the mouse face.
1597 2011-10-28 Chong Yidong <cyd@gnu.org>
1599 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1601 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1603 * window.c (make_window): Initialize phys_cursor_on_p.
1605 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1607 * lisp.h (struct Lisp_Symbol): Update comments.
1609 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1611 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1613 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1615 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1616 <oslsachem@gmail.com> for helping to debug this.
1618 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1619 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1620 (g_b_init_get_glyph_outline_w): New static variables.
1621 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1622 (GetGlyphOutlineW_Proc): New typedefs.
1623 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1624 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1626 (w32font_open_internal, compute_metrics):
1627 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1628 instead of calling the "wide" APIs directly.
1630 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1632 * w32.h (syms_of_w32font): Add prototype.
1634 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1636 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1637 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1638 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1639 (Fmove_to_window_line): Doc fix.
1641 2011-10-27 Chong Yidong <cyd@gnu.org>
1643 * process.c (make_process): Set gnutls_state to NULL.
1645 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1646 non-NULL, regardless of GNUTLS_INITSTAGE.
1647 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1648 an error. Set process slots as soon as we allocate them.
1650 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1652 2011-10-27 Chong Yidong <cyd@gnu.org>
1654 * gnutls.c (emacs_gnutls_deinit): New function.
1655 Deallocate credentials structures as well as calling gnutls_deinit.
1656 (Fgnutls_deinit, Fgnutls_boot): Use it.
1658 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1659 (deactivate_process): Call emacs_gnutls_deinit.
1661 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1663 * image.c (x_create_x_image_and_pixmap):
1664 * w32.c (sys_rename, w32_delayed_load):
1665 * w32font.c (fill_in_logfont):
1666 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1668 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1670 * w32fns.c (w32_default_color_map): New function,
1671 extracted from Fw32_default_color_map.
1672 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1674 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1676 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1678 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1680 * keyboard.c (test_undefined): New function (bug#9751).
1681 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1683 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1685 * sysdep.c (init_sys_modes): Fix the check for the controlling
1686 terminal (Bug#6649).
1688 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1690 * dispextern.h (struct bidi_it): New member next_en_type.
1692 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1693 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1694 current character, check also for next_en_type being WEAK_EN.
1695 (bidi_resolve_weak): Don't enter the expensive loop if the current
1696 position is before next_en_pos. Record the bidi type of the first
1697 non-ET, non-BN character we find, in addition to its position.
1698 (bidi_level_of_next_char): Invalidate next_en_type when
1699 next_en_pos is over-stepped.
1701 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1703 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1704 * editfns.c: Rewrite current-time-zone so that it invokes
1705 the equivalent of (format-time-string "%Z") to get the time zone name.
1706 This fixes a bug when the time zone name contains characters that
1707 need converting from the system time locale to Emacs internal format.
1708 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1709 that patch fixed format-time-string to do the conversion, but
1710 I forgot to fix current-time-zone.
1711 (format_time_string): New function, containing most of
1712 what Fformat_time_string used to contain.
1713 (Fformat_time_string): Rewrite in terms of format_time_string.
1714 This doesn't change this function's behavior.
1715 (current-time-zone): Rewrite to use format_time_string.
1716 This fixes the bug reported by Michael Schierl in
1717 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1718 Jason Rumney's 2007-06-07 change worked around this bug, but
1720 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1722 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1724 * xdisp.c (start_display): If the character at POS is displayed
1725 via a display vector, reset IT->current.dpvec_index to zero.
1726 (try_window_reusing_current_matrix): If a line ends in a display
1727 vector or the next line starts in a display vector, continue
1728 redrawing the window even though the character position of
1729 start_row was reached.
1732 2011-10-18 Chong Yidong <cyd@gnu.org>
1734 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1735 with nobreak-char-display too.
1737 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1739 Fix part 3 of bug#9771.
1740 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1741 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1742 non-neutral characters if the current character is a paragraph
1743 separator (a.k.a. Newline). This avoids running the same
1744 expensive loop twice, once when we consume the preceding newline
1745 and the other time when the line actually needs to be displayed.
1746 Avoid the loop when we see neutrals on the base embedding level
1747 following a character whose directionality is the same as the
1748 paragraph's. This avoids running the expensive loop when a line
1749 ends in a long sequence of neutrals, like control characters.
1750 Add assertion against STRONG_AL type. Slightly rearrange code
1751 that determines the type of a neutral given the first non-neutral
1753 (bidi_level_of_next_char): Set next_en_pos to zero when
1754 invalidating its info.
1756 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1758 * xdisp.c (push_display_prop): Determine whether to record string
1759 or buffer position by IT->string, not by IT->method. Allow
1760 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1761 (move_it_vertically_backward): Don't look for character position
1762 immediately after the newline when in a continuation line.
1765 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1767 * window.c (coordinates_in_window): Rewrite and delabelize
1768 vertical border check. (Bug#5357) (Bug#9618)
1770 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1772 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1773 errors in XSetWindowBorder (bug#9310).
1775 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1777 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1778 avoid crash when xmalloc overrun checking is enabled.
1780 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1782 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1783 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1784 cursor motion with <left> and <right> arrow keys.
1786 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1787 some callers set that themselves.
1789 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1791 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1792 display string and the previous row comes from the same string and
1793 is empty. (Bug#9739) (Bug#9738)
1795 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1797 * doc.c (get_doc_string): Encode file name (bug#9735).
1799 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1801 * bidi.c (bidi_level_of_next_char):
1802 * xdisp.c (get_visually_first_element): Remove old incorrect
1803 comments regarding the Unicode Line Separator character.
1805 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1807 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1809 * alloc.c (Fgc_status): Do not access beyond zombies array
1810 boundary if nzombies > MAX_ZOMBIES.
1811 * alloc.c (dump_zombies): Add missing format specifier.
1813 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1815 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1816 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1818 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1819 Some packages use them to denote characters with modifiers.
1821 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1823 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1824 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1825 matching a pp-number. Rename parameter var to var1.
1827 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1829 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1831 2011-10-08 Glenn Morris <rgm@gnu.org>
1833 * callint.c (Fcall_interactively): Give a more explicit error for the
1834 'c' case with a non-character input. (Bug#8479)
1836 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1838 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1840 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1841 lines that are hscrolled on the left.
1843 * dispnew.c (buffer_posn_from_coords): Account for a possible
1844 presence of header-line. (Bug#4426)
1846 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1848 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1849 Don't advertise functionality which we discourage or doesn't work.
1851 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1853 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1854 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1855 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1856 this makes Emacs dump core during garbage collection on rare
1857 occasions. sizeof is obviously inferior to offsetof here, so
1858 stick with offsetof.
1859 (GC_POINTER_ALIGNMENT): New macro.
1860 (mark_memory): Omit 3rd (offset) arg; caller changed.
1861 Don't assume EMACS_INT alignment is the same as pointer alignment.
1863 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1865 * keyboard.c (read_key_sequence_remapped): New var.
1866 (read_key_sequence): Compute remapping in the right buffer.
1867 (command_loop_1): Use read_key_sequence's remapping directly.
1869 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1871 * dired.c (file_name_completion): Don't expand file name.
1872 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1873 before checking file name handler.
1875 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1876 they've been requested explicitly (bug#9591).
1878 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1880 * keymap.c (Fsingle_key_description): Use make_specified_string
1881 instead of build_string to build string from push_key_description.
1884 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1886 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1887 This fixes a Y2038 bug on 64-bit hosts.
1888 * buffer.c (reset_buffer):
1889 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1890 (Fclear_buffer_auto_save_failure):
1891 Use 0, not -1, to represent an unset failure time, since time_t
1892 might not be signed.
1894 Remove dependency on glibc malloc internals.
1895 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1896 Move back here from lisp.h, but with their new implementations.
1897 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1898 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1899 * charset.c (charset_table_init): New static var.
1900 (syms_of_charset): Use it instead of xmalloc. This removes a
1901 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1902 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1903 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1904 Move back to alloc.c.
1905 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1906 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1908 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1910 * nsterm.m (windowDidResize): Call x_set_window_size only when
1911 ns_in_resize is true. Otherwise set pixelwidth/height and
1912 call change_frame_size (Bug#9628).
1914 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1916 Port --enable-checking=all to Fedora 14 x86-64.
1917 * charset.c (syms_of_charset): Also account for glibc malloc's
1918 internal overhead when calculating the initial malloc maximum.
1920 Port --enable-checking=all to Fedora 14 x86.
1921 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1923 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1924 (overrun_check_realloc, overrun_check_free):
1925 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1926 That way, xmalloc returns a properly-aligned pointer even if
1927 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1928 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1929 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1930 into account when calculating the initial malloc maximum.
1931 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1932 Move here from alloc.c, so that charset.c can use it too.
1933 Properly align; the old code wasn't right for common 32-bit hosts
1934 when configured with --enable-checking=all.
1935 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1936 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1938 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1940 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1943 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1945 * xdisp.c (compute_display_string_end): If there's no display
1946 string at CHARPOS, return -1.
1948 * bidi.c (bidi_fetch_char): When compute_display_string_end
1949 returns a negative value, treat the character as a normal
1950 character not covered by a display string. (Bug#9624)
1952 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1954 * lread.c (Fread_from_string): Fix typo in docstring.
1956 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1958 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1959 newline, reseat the iterator instead of bidi-iterating there one
1960 character at a time. (Bug#9610)
1961 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1962 TO_CHARPOS if the bidi iterator is at base embedding level.
1964 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1966 * lread.c (readevalloop): Use correct code for NBSP.
1967 (read1): Likewise. (Bug#9608)
1969 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1971 * dbusbind.c (Fdbus_register_signal): When service is not
1972 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1974 2011-09-25 Glenn Morris <rgm@gnu.org>
1976 * buffer.c (truncate-lines): Doc fix.
1978 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1980 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1981 (Fset_window_next_buffers): Doc fix.
1983 2011-09-24 Glenn Morris <rgm@gnu.org>
1985 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1987 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1989 Fix minor problems found by static checking.
1990 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1991 * indent.c (Fvertical_motion): Fix == vs = typo.
1993 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1995 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1996 Default value is now t. Doc fix.
1998 * indent.c (Fvertical_motion): Compute and apply the overshoot
1999 logic when moving up, not only when moving down. Fix the
2000 confusing name and values of the it_overshoot_expected variable;
2001 logic changes accordingly. (Bug#9254) (Bug#9549)
2003 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2004 CHARPOS is covered by a display string which includes newlines.
2005 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2006 is covered by a display string with embedded newlines.
2008 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2010 * dbusbind.c (Fdbus_register_signal): Add match rule to
2011 Vdbus_registered_objects_table. (Bug#9581)
2012 (Fdbus_register_method, Vdbus_registered_objects_table):
2015 2011-09-24 Jim Meyering <meyering@redhat.com>
2017 do not ignore write error for any output size
2018 The previous change was incomplete.
2019 While it makes emacs --batch detect the vast majority of stdout
2020 write failures, errors were still ignored whenever the output size is
2021 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2022 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2023 && echo FAIL: ignored write error
2024 FAIL: ignored write error
2025 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2026 && echo FAIL: ignored write error
2027 FAIL: ignored write error
2028 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2030 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2032 * emacs.c (Fkill_emacs): In noninteractive mode exit
2033 non-successfully if a write error occurred on stdout. (Bug#9574)
2035 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2037 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2040 * dispextern.h (struct it): Update the comment documenting what
2043 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2045 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2046 a display string, extend search for cursor position to end of row.
2047 (find_row_edges): If the row ends in a newline from a display
2048 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2049 Handle the case of a display string with multiple newlines.
2050 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2051 non-empty line. Fixes confusing cursor motion with arrow keys at
2052 the beginning of a line that starts with whitespace.
2054 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2056 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2059 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2061 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2064 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2066 * xdisp.c (display_line): Record maximum and minimum buffer
2067 positions even if no glyphs were produced (e.g., by a zero-width
2068 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2069 buffer positions that will be removed from the glyph row because
2071 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2072 column is beyond frame width: don't subtract 1 "pixel" when
2073 computing width of the stretch.
2074 (reseat_at_next_visible_line_start): Undo the change made on
2075 2011-09-17 that saved paragraph information and restored it after
2076 the call to `reseat'. (Bug#9545)
2078 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2080 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2081 and turn window cursor on if cleared (Bug#9415).
2083 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2085 * search.c (boyer_moore): Take unibyte characters from pattern
2086 literally. (Bug#9458)
2088 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2090 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2092 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2094 Fix minor problem found by static checking.
2095 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2096 initialized, to pacify gcc -Wuninitialized.
2098 * fileio.c: Report proper errno when syscall falls.
2099 (Finsert_file_contents): Save and restore errno,
2100 so that report_file_error outputs the correct diagnostic.
2101 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2103 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2105 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2107 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2109 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2110 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2112 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2114 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2115 about the current paragraph and restore it after the call to reseat.
2117 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2118 (bidi_find_paragraph_start): Search back for paragraph beginning
2119 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2120 (bidi_move_to_visually_next): Only trigger paragraph-related
2121 computations when the last character is a newline or at EOB, not
2122 just any NEUTRAL_B. (Bug#9470)
2124 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2125 truncated lines if point is covered by a display string. (Bug#9524)
2127 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2129 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2130 (cons_to_x_long): New function.
2131 (lisp_data_to_selection_data): Use it. Correct the test for
2132 short-versus-long data; it was negated. Break out of vector
2133 loop, for efficiency, when a long datum is discovered.
2135 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2137 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2139 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2141 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2142 GCC PR/17406) by declaring this function with external scope.
2144 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2146 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2147 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2149 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2151 * editfns.c (Fformat): Correctly handle text properties on "%%".
2153 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2155 * xterm.c (x_draw_composite_glyph_string_foreground):
2156 * w32term.c (x_draw_composite_glyph_string_foreground):
2157 * term.c (encode_terminal_code):
2158 * composite.c (composition_update_it, get_composition_id):
2159 * xdisp.c (get_next_display_element)
2160 (fill_composite_glyph_string): Add comments about special meaning
2161 of TAB characters in a composition.
2163 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2165 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2166 This occurs when processing a multibyte format.
2167 Problem reported by Wolfgang Jenker.
2169 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2171 * xdisp.c (try_cursor_movement): Only check for exact match if
2172 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2174 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2176 Remove unused external symbols.
2177 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2178 * xdisp.c (calc_pixel_width_or_height): Now static.
2179 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2180 * indent.c (check_display_width):
2181 * w32term.c: Fix comment to match code.
2182 * xterm.c, xterm.h (x_catching_errors): Remove.
2184 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2186 * xselect.c: Use signed conversions more consistently (Bug#9498).
2187 (selection_data_to_lisp_data): Assume incoming selection data are
2188 signed integers, not unsigned. This is to be consistent with
2189 outgoing selection data, which was modified to use signed integers
2190 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2191 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2192 expects long, not unsigned long.
2194 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2196 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2197 computation of loop end. Reported by Johan Bockgård
2200 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2202 * frame.c (Fother_visible_frames_p): Function deleted.
2204 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2206 * indent.c (compute_motion): Process display vector front to back
2207 rather than the other way around. (Bug#2496)
2209 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2211 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2213 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2215 * minibuf.c (Fread_from_minibuffer): Doc fix.
2217 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2219 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2220 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2222 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2224 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2225 value for non-existent files.
2227 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2229 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2230 set its "size" to -1. This will set the modtime_size field of
2231 the corresponding buffer to -1, which is what
2232 verify-visited-file-modtime expects for files that do not exist.
2235 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2237 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2239 * lisp.h: ... from here. push_key_description is no longer
2240 defined in keyboard.c, so its declaration should not be in
2241 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2242 logically belongs with push_key_description.
2244 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2246 * buffer.h: Include <sys/types.h> instead of <time.h>.
2247 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2248 Problem reported by Herbert J. Skuhra.
2250 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2252 * xml.c (parse_region): Make the parsing work for
2253 non-comment-starting XML files again (bug#9144).
2255 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2257 * image.c (gif_load): Fix calculation of bottom and right corner.
2260 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2262 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2263 redisplay in small windows.
2265 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2267 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2269 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2271 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2272 Operate on live windows only.
2274 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2276 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2278 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2280 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2281 only under bidi iteration.
2283 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2285 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2287 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2289 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2290 Without this fix, the command to link temacs failed due to an
2291 undefined symbol __builtin_isnan. This is because
2292 /usr/include/iso/math_c99.h #defines isnan(x) to
2293 __builtin_isnan(x), but the bundled gcc, which identifies itself
2294 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2296 * floatfns.c (isnan): #undef, and then #define to a clone of
2298 (Fisnan): Always define, since it's always available now.
2299 (syms_of_floatfns): Always define isnan at the Lisp level.
2301 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2303 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2305 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2307 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2308 The previous code assumed that file offsets (off_t values) fit in
2309 EMACS_INT variables, which is not true on typical 32-bit hosts.
2310 The code messed up by falsely reporting buffer overflow in cases
2311 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2312 when "big" contains more than 2**29 bytes, even though this
2313 inserts just one byte and does not overflow the buffer.
2314 (Finsert_file_contents): Store file offsets as off_t
2315 values, not as EMACS_INT values. Check for overflow when
2316 converting between EMACS_INT and off_t. When checking for
2317 buffer overflow or for overlap, take the offsets into account.
2318 Don't use EMACS_INT for small values where int suffices.
2319 When checking for overlap, fix a typo: ZV was used where
2320 ZV_BYTE was intended.
2321 (Fwrite_region): Don't assume off_t fits into 'long'.
2322 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2324 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2326 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2328 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2330 sprintf-related integer and memory overflow issues (Bug#9412).
2332 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2333 (esprintf, exprintf, evxprintf): New functions.
2334 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2335 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2336 (modify_event_symbol): Do not assume that the length of
2337 name_alist_or_stem is safe to alloca and fits in int.
2338 (Fexecute_extended_command): Likewise for function name and binding.
2339 (Frecursion_depth): Wrap around reliably on integer overflow.
2340 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2341 since some callers pass EMACS_INT values.
2342 (Fsingle_key_description): Don't crash if symbol name contains more
2343 than MAX_ALLOCA bytes.
2344 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2345 (get_minibuffer): Arg is now EMACS_INT, not int.
2346 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2347 (esprintf, exprintf, evxprintf): New decls.
2348 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2350 * dbusbind.c (signature_cat): New function.
2351 (xd_signature, Fdbus_register_signal):
2352 Do not overrun buffer; instead, report string overflow.
2354 * dispnew.c (add_window_display_history): Don't overrun buffer.
2355 Truncate instead; this is OK since it's just a log.
2357 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2358 even if the time zone offset is outlandishly large.
2359 Don't mishandle offset == INT_MIN.
2361 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2362 when creating daemon; the previous buffer-overflow check was incorrect.
2364 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2365 which has the guts of the old verror function.
2367 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2368 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2370 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2371 (font_unparse_xlfd): Don't blindly alloca long strings.
2372 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2373 fits in int, when using sprintf. Use single snprintf to count
2374 length of string rather than counting it via multiple sprintfs;
2375 that's simpler and more reliable.
2376 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2377 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2378 sprintf, in case result does not fit in int.
2380 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2381 (fontset_from_font): Print it.
2383 * frame.c (tty_frame_count): Now printmax_t, not int.
2384 (make_terminal_frame, set_term_frame_name): Print it.
2385 (x_report_frame_params): In X, window IDs are unsigned long,
2386 not signed long, so print them as unsigned.
2387 (validate_x_resource_name): Check for implausibly long names,
2388 and don't assume name length fits in 'int'.
2389 (x_get_resource_string): Don't blindly alloca invocation name;
2390 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2393 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2394 (xg_check_special_colors, xg_set_geometry):
2395 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2397 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2398 Use esprintf, not sprintf, in case result does not fit in int.
2400 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2401 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2402 it as a large positive number.
2403 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2404 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2406 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2407 in case result does not fit in int.
2409 * print.c (float_to_string): Detect width overflow more reliably.
2410 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2411 buffer overrun. Don't assume list length fits in 'int'. Treat
2412 print length of 0 as 0, not as infinity; to be consistent with other
2413 uses of print length in this function. Don't overflow print length
2414 index. Don't assume hash table size fits in 'long', or that
2415 vectorlike size fits in 'unsigned long'.
2417 * process.c (make_process): Use printmax_t, not int, to format
2418 process-name gensyms.
2420 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2422 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2423 to avoid potential buffer overrun.
2425 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2426 if X resource line is longer than 512 bytes.
2428 * xfns.c (x_window): Make sprintf buffer a bit bigger
2429 to avoid potential buffer overrun.
2431 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2433 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2435 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2437 Integer overflow fixes for scrolling, etc.
2438 Without these, Emacs silently mishandles large integers sometimes.
2439 For example, "C-u 4294967297 M-x recenter" was treated as if
2440 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2442 * xdisp.c (try_window_id): Check Emacs fixnum range before
2443 converting to 'int'.
2445 * window.c (window_scroll_line_based, Frecenter):
2446 Check that an Emacs fixnum is in range before assigning it to 'int'.
2447 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2448 values converted from Emacs fixnums.
2449 (Frecenter): Don't wrap around a line count if it is out of 'int'
2450 range; instead, treat it as an extreme value.
2451 (Fset_window_configuration, compare_window_configurations):
2452 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2454 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2455 that can exceed INT_MAX. Check that EMACS_INT value is in range
2456 before assigning it to the (possibly-narrower) index.
2457 (match_limit): Don't assume that a fixnum can fit in 'int'.
2459 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2462 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2463 (Fvertical_motion): Don't wrap around LINES values that don't fit
2464 in 'int'. Instead, treat them as extreme values. This is good
2465 enough for windows, which can't have more than INT_MAX lines anyway.
2467 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2469 * Require libxml/parser.h to avoid compilation warning.
2471 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2473 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2474 since this reportedly can destroy thread storage.
2476 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2478 * syntax.c (find_defun_start): Update all cache variables if
2479 exiting early (Bug#9401).
2481 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2483 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2485 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2486 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2487 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2489 * term.c (tty_append_glyph): New function.
2490 (produce_stretch_glyph): Static function and its prototype deleted.
2492 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2495 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2497 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2498 when checking :margin (Bug#9390).
2499 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2500 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2501 so that the name doesn't mislead. All uses changed.
2503 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2505 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2508 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2510 * xdisp.c (move_it_to): Don't bail out early when reaching
2511 position beyond to_charpos, if we are scanning backwards.
2512 (move_it_vertically_backward): When DY == 0, make sure we get to
2513 the first character in the line after the newline.
2515 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2517 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2518 (ccl_driver): Do not generate an out-of-range pointer.
2519 (Fccl_execute_on_string): Remove unnecessary check for
2520 integer overflow, noted by Stefan Monnier in
2521 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2522 Remove a FIXME that didn't need fixing.
2523 Simplify the newly-introduced buffer reallocation code.
2525 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2527 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2529 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2531 Integer and memory overflow issues (Bug#9196).
2533 * doc.c (get_doc_string): Rework so that
2534 get_doc_string_buffer_size is the actual buffer size, rather than
2535 being 1 less than the actual buffer size; this makes xpalloc more
2538 * image.c (x_allocate_bitmap_record, cache_image):
2539 * xselect.c (Fx_register_dnd_atom):
2540 Simplify previous changes by using xpalloc.
2542 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2543 since either will do and ptrdiff_t is convenient with xpalloc.
2545 * charset.c (charset_table_size)
2546 (struct charset_sort_data.priority): Now ptrdiff_t.
2547 (charset_compare): Don't overflow if priorities differ greatly.
2548 (Fsort_charsets): Don't assume list length fits in int.
2549 Check for size-calculation overflow when allocating sort data.
2550 (syms_of_charset): Allocate an initial charset table that is
2551 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2553 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2555 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2556 The actual value is always <= INT_MAX, and leaving it unsigned made
2557 overflow checking harder.
2559 * dispextern.h (struct glyph_matrix.rows_allocated)
2560 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2561 with xpalloc. The values are still always <= INT_MAX.
2563 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2565 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2566 (SAFE_NALLOCA): New macro.
2568 * region-cache.c (struct boundary.pos, find_cache_boundary)
2569 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2570 (set_cache_region, invalidate_region_cache)
2571 (revalidate_region_cache, know_region_cache, region_cache_forward)
2572 (region_cache_backward, pp_cache):
2573 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2574 so that ptrdiff_t * can be passed to xpalloc.
2575 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2576 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2577 (pp_cache): Don't assume cache_len fits in int.
2578 * region-cache.h: Adjust extern decls to match.
2580 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2581 EMACS_INT, since either will do, for xpalloc.
2583 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2584 (xnmalloc, xnrealloc, xpalloc): New functions.
2586 * bidi.c (bidi_shelve_header_size): New constant.
2587 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2588 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2590 * bidi.c (bidi_cache_shrink):
2591 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2593 Don't update size of array until after memory allocation succeeds,
2594 because xmalloc/xrealloc may not return.
2595 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2596 now that we have proper integer overflow checking.
2597 (record_overlay_string, overlay_strings): Catch overflows when
2598 calculating size of overlay_str_buf.
2600 * callproc.c (Fcall_process): Check for size overflow when
2601 calculating size of args2.
2602 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2603 Normally we prefer signed values, but sticking with ptrdiff_t would
2604 require adding more-complicated checks.
2606 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2607 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2608 Redo buffer-overflow calculations to avoid integer overflow.
2609 Add a FIXME comment where memory seems to be over-allocated.
2611 * character.c (Fstring): Check for size-calculation overflow.
2613 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2614 unnecessary integer overflow. Check for size overflow.
2615 (encode_coding_object): Don't update size until xmalloc succeeds.
2617 * composite.c (get_composition_id): Check for overflow in glyph
2618 length calculations.
2620 Integer and memory overflow fixes for display code.
2621 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2622 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2623 (scrolling_window): Check for overflow in size calculations.
2624 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2625 Don't assume glyph table len fits in int.
2626 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2627 (row_table_size): Now ptrdiff_t, not int.
2628 (scrolling_window): Avoid overflow in size calculations.
2629 Don't update size until allocation succeeds.
2630 * fns.c (concat): Check for overflow in size calculations.
2631 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2632 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2633 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2635 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2636 (get_doc_string): Check for size calculation overflow.
2637 Don't update size until allocation succeeds.
2638 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2639 EMACS_INT, where ptrdiff_t will do.
2640 (Fsubstitute_command_keys): Check for string overflow.
2642 * editfns.c (set_time_zone_rule): Don't assume environment length
2644 (message_length): Now ptrdiff_t, not int.
2645 (Fmessage_box): Don't update size until allocation succeeds.
2646 Don't assume message length fits in int.
2647 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2649 * emacs.c (main): Do not reallocate argv, since there is a null at
2650 the end that can be overwritten, and this way there's no need to
2651 worry about size-calculation overflow.
2652 (sort_args): Check for size-calculation overflow.
2654 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2656 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2658 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2659 (x_set_scroll_bar_width, x_figure_window_size):
2660 Check for integer overflow.
2661 (x_set_alpha): Do not assume XINT fits in int.
2663 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2664 This is for the members text_lines, text_cols, total_lines, total_cols,
2665 where the system imposes an 'int' limit.
2667 * fringe.c (Fdefine_fringe_bitmap):
2668 Don't update size until alloc works.
2670 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2671 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2673 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2674 Check for size-calculation overflow.
2675 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2676 do, as we prefer signed integers.
2677 (id_to_widget.max_size, id_to_widget.used)
2678 (xg_store_widget_in_map, xg_remove_widget_from_map)
2679 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2680 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2681 Use and return ptrdiff_t, not int.
2682 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2683 * gtkutil.h: Change prototypes to match the above.
2685 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2686 are duplicate now that they've been promoted to lisp.h.
2687 (x_allocate_bitmap_record, x_alloc_image_color)
2688 (make_image_cache, cache_image, xpm_load):
2689 Don't update size until alloc is done.
2690 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2692 Check for size calculation overflow.
2693 (ct_colors_allocated_max): New constant.
2694 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2697 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2698 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2699 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2700 Use ptrdiff_t, not int, to count maps.
2701 (read_char_minibuf_menu_prompt): Check for overflow in size
2702 calculations. Don't update size until allocation succeeds.
2703 Redo calculations to avoid overflow.
2704 * keyboard.h: Change prototypes to match the above.
2706 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2708 (current_minor_maps): Check for size calculation overflow.
2709 * keymap.h: Change prototypes to match the above.
2711 * lread.c (read1, init_obarray): Don't update size until alloc done.
2713 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2714 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2716 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2717 Now ptrdiff_t, not int.
2718 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2719 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2721 * process.c (Fnetwork_interface_list): Check for overflow
2722 in size calculation.
2724 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2726 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2727 overflow. Don't bother calling xmalloc when xrealloc will do.
2729 * search.c (Freplace_match): Check for size calculation overflow.
2730 (Fset_match_data): Don't assume list lengths fit in 'int'.
2732 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2733 for command line length. Do not attempt to address one before the
2734 beginning of an array, as that's not portable.
2736 * term.c (max_frame_lines): Remove; unused.
2737 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2739 (encode_terminal_code, calculate_costs): Check for size
2740 calculation overflow.
2741 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2742 table lengths and related sizes. Don't update size until alloc
2743 done. Redo calculations to avoid overflow.
2744 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2746 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2747 subtracting pointers.
2748 (gobble_line): Check for overflow more carefully. Don't update size
2751 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2752 Don't update size until alloc done.
2753 Redo size calculations to avoid overflow.
2754 Check for size calculation overflow.
2755 (main) [DEBUG]: Fix typo in invoking tparam1.
2757 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2758 Use ptrdiff_t, not int, for sizes.
2759 (store_mode_line_noprop_char): Don't update size until alloc done.
2761 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2762 Use ptrdiff_t, not int, for sizes.
2763 (Finternal_make_lisp_face, cache_face):
2764 Check for size calculation overflow.
2765 (cache_face): Treat size calculation overflows as if they were
2766 memory exhaustion (the usual treatment), rather than aborting.
2768 * xfns.c (x_encode_text, x_set_name_internal)
2769 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2770 sizes, since they can exceed INT_MAX in size. Check for size
2771 calculation overflow.
2773 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2774 (xg_select): Check for size calculation overflow.
2775 Don't update size until alloc done.
2777 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2778 as sprintf is limited to int lengths.
2780 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2781 (X_LONG_MIN): New macros.
2782 Use them to make the following changes clearer.
2783 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2784 This change doesn't affect the value now, but it may help remind
2785 future maintainers not to raise the value too much later.
2786 (SELECTION_QUANTUM): Remove, replacing with ...
2787 (selection_quantum): ... new function, which avoids overflow.
2789 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2790 assumption that selection length fits in 'int'.
2791 (x_reply_selection_request, x_handle_selection_request)
2792 (x_get_window_property, receive_incremental_selection)
2793 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2794 (lisp_data_to_selection_data, clean_local_selection_data):
2795 Use ptrdiff_t, not int, to record length of selection.
2796 (x_reply_selection_request, x_get_window_property)
2797 (receive_incremental_selection, x_property_data_to_lisp):
2798 Redo calculations to avoid overflow.
2799 (x_reply_selection_request): When sending hint, ceiling it at
2800 X_LONG_MAX rather than relying on wraparound overflow to send
2802 (x_get_window_property, receive_incremental_selection)
2803 (lisp_data_to_selection_data, x_property_data_to_lisp):
2804 Check for size-calculation overflow.
2805 (x_get_window_property, receive_incremental_selection)
2806 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2807 Don't store size until memory allocation succeeds.
2808 (x_get_window_property): Plug memory leak on memory exhaustion.
2809 Don't double-block input; malloc is safe here. Don't assume 2**34
2810 - 4 fits in unsigned long. Add an xassert to check
2811 XGetWindowProperty overflow. Be more careful about overflow
2812 calculations, and distinguish size from memory overflow better.
2813 (receive_incremental_selection): When tracing, don't assume
2814 unsigned int is less than INT_MAX.
2815 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2816 harmful) conversions of unsigned short to int.
2817 (lisp_data_to_selection_data): Don't assume that integers
2818 in the range -65535 through -1 fit in an X unsigned short.
2819 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2820 result parameters unless successful. Rely on cons_to_unsigned
2821 to report problems with elements; the old code wasn't right anyway.
2822 (x_check_property_data): Check for int overflow; we cannot use
2823 a wider type due to X limits.
2824 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2826 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2828 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2829 (x_term_init): Check for size calculation overflow.
2830 (x_color_cells): Don't store size until memory allocation succeeds.
2831 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2832 Don't assume alloca size is less than MAX_ALLOCA.
2833 (x_term_init): Don't assume length fits in int (sprintf is limited
2836 Use ptrdiff_t for composition IDs.
2837 * character.c (lisp_string_width):
2838 * composite.c (composition_table_size, n_compositions)
2839 (get_composition_id, composition_gstring_from_id):
2840 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2841 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2842 * window.c (Frecenter):
2843 Use ptrdiff_t, not int, for composition IDs.
2844 * composite.c (get_composition_id): Check for integer overflow.
2845 * composite.h: Adjust prototypes to match the above changes.
2847 Use ptrdiff_t for hash table indexes.
2848 * category.c (hash_get_category_set):
2849 * ccl.c (ccl_driver):
2850 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2851 * coding.c (coding_system_charset_list, detect_coding_system):
2852 * coding.h (struct coding_system.id):
2853 * composite.c (get_composition_id, gstring_lookup_cache):
2854 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2855 * image.c (xpm_get_color_table_h):
2856 * lisp.h (hash_lookup, hash_put):
2857 * minibuf.c (Ftest_completion):
2858 Use ptrdiff_t for hash table indexes, not int (which is too
2859 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2860 32-bit --with-wide-int hosts).
2862 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2863 Add a FIXME comment about memory leaks.
2864 (syms_of_charset): Don't assume xmalloc returns.
2866 Don't assume that stated character widths fit in int.
2867 * character.c (Fchar_width, c_string_width, lisp_string_width):
2868 * character.h (CHAR_WIDTH):
2869 * indent.c (MULTIBYTE_BYTES_WIDTH):
2870 Use sanitize_char_width to avoid undefined and/or bad behavior
2871 with outlandish widths.
2872 * character.h (sanitize_tab_width): Rename from sanitize_width,
2873 now that we have two such functions. All uses changed.
2874 (sanitize_char_width): New inline function.
2876 Don't assume that tab-width fits in int.
2877 * character.h (sanitize_width): New inline function.
2878 (SANE_TAB_WIDTH): New macro.
2879 (ASCII_CHAR_WIDTH): Use it.
2880 * indent.c (sane_tab_width): Remove. All uses replaced by
2881 SANE_TAB_WIDTH (current_buffer).
2882 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2884 * fileio.c: Integer overflow issues with file modes.
2885 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2887 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2888 Remove unreachable code.
2889 (read_hex, load_charset_map_from_file): Check for integer overflow.
2891 * xterm.c: don't go over XClientMessageEvent limit
2892 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2893 (x_send_scroll_bar_event): Likewise. Check that the size does not
2894 exceed limits imposed by XClientMessageEvent, as well as the usual
2895 ptrdiff_t and size_t limits.
2897 * keyboard.c: Overflow, signedness and related fixes.
2898 (make_lispy_movement): Use same integer type in forward decl
2899 that is used in the definition.
2900 (read_key_sequence, keyremap_step):
2901 Change bufsize argument back to int, undoing my 2011-03-30 change.
2902 We prefer signed types, and int is wide enough here.
2903 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2904 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2905 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2906 length, not size_t. Use ptrdiff_t for index, not int.
2907 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2908 possibility of integer overflow.
2910 Overflow, signedness and related fixes for images.
2912 * dispextern.h (struct it.stack[0].u.image.image_id)
2913 (struct_it.image_id, struct image.id, struct image_cache.size)
2914 (struct image_cache.used, struct image_cache.ref_count):
2915 * gtkutil.c (update_frame_tool_bar):
2916 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2917 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2918 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2919 * nsmenu.m (update_frame_tool_bar):
2920 * xdisp.c (calc_pixel_width_or_height):
2921 * xfns.c (image_cache_refcount):
2922 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2923 on typical 64-bit hosts.
2925 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2926 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2927 Omit unnecessary casts to int.
2928 (parse_image_spec): Check that integers fall into 'int' range
2929 when the callers expect that.
2930 (image_ascent): Redo ascent calculation to avoid int overflow.
2931 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2932 (lookup_image): Remove unnecessary tests.
2933 (xbm_image_p): Locals are now of int, not EMACS_INT,
2934 since parse_image_check makes sure they fit into int.
2935 (png_load, gif_load, svg_load_image):
2936 Prefer int to unsigned where either will do.
2937 (tiff_handler): New function, combining the cores of the
2938 old tiff_error_handler and tiff_warning_handler.
2939 This function is rewritten to use vsnprintf and thereby avoid
2940 stack buffer overflows. It uses only the features of vsnprintf
2941 that are common to both POSIX and native Microsoft.
2942 (tiff_error_handler, tiff_warning_handler): Use it.
2943 (tiff_load, gif_load, imagemagick_load_image):
2944 Don't assume :index value fits in 'int'.
2945 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2946 (imagemagick_load_image): Check that crop parameters fit into
2947 the integer types that MagickCropImage accepts. Don't assume
2948 Vimagemagick_render_type has a nonnegative value. Don't assume
2949 size_t fits in 'long'.
2950 (gs_load): Use printmax_t to print the widest integers possible.
2951 Check for integer overflow when computing image height and width.
2953 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2955 * xdisp.c (redisplay_window): Don't force window start if point
2956 will be invisible in the resulting window. (Bug#9324)
2958 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2960 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2961 the display spec is of the form `(space ...)'.
2962 (handle_display_spec): Return the value returned by
2963 handle_single_display_spec, not just 1 or zero.
2964 (handle_single_display_spec): If the display spec is of the form
2965 `(space ...)', and specifies display in the text area, return 2
2967 (try_cursor_movement): Check for the need to scroll more
2968 accurately, and prefer exact match for point under bidi.
2969 Don't advance `row' beyond the last row of the window.
2971 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2972 into disp_prop; all users changed.
2974 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2975 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2976 for the text covered by the display property.
2978 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2980 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2981 Change return value to nil.
2982 (Frecord_buffer): Delete unused function.
2984 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2986 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2987 buffers, return left-to-right.
2988 (set_cursor_from_row): Consider candidate row a win if its glyph
2989 represents a newline and point is on that newline. Fixes cursor
2990 positioning on the newline at EOL of R2L text within L2R
2991 paragraph, and vice versa.
2992 (try_cursor_movement): Check continued rows, in addition to
2993 continuation rows. Fixes unwarranted scroll when point enters a
2994 continued line of R2L text within an L2R paragraph, or vice versa.
2995 (cursor_row_p): Consider the case of point being equal to
2996 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2997 from the end of a short line to the beginning of a continued line
2998 of R2L text within L2R paragraph.
2999 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3000 composed characters.
3002 * bidi.c (bidi_check_type): Use xassert.
3003 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3006 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3008 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3011 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3013 * nsfont.m (ns_otf_to_script): Fix typo.
3015 2011-08-22 Kenichi Handa <handa@m17n.org>
3017 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3018 extra slot even if the purpose is char-code-property-table.
3020 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3022 * xdisp.c (redisplay_window): When computing centering_position,
3023 account for the height of the header line. (Bug#8874)
3025 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3026 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3027 candidate is selected by the mouse, and that candidate has a
3028 composed character under the mouse.
3030 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3031 coordinates reported by pos-visible-in-window-p for a composed
3032 character in column zero.
3034 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3036 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3038 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3040 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3041 consider it a hit if to_charpos is anywhere in the range of the
3042 composed buffer positions.
3044 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3046 * image.c (gif_load): Don't assume that each subimage has the same
3047 dimensions as the base image. Handle disposal method that is
3048 "undefined" by the gif spec (Bug#9335).
3050 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3052 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3053 (Fcondition_case): Document `debug' symbol in error handler.
3055 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3057 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3058 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3059 from an Org mode buffer to a Speedbar frame.
3061 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3062 a composition, take its buffer position from IT->cmp_it.charpos.
3063 Fixes cursor positioning at the beginning of a line that begins
3064 with a composed character.
3066 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3068 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3069 character bidirectional type, use STRONG_L instead. Fixes crashes
3070 in a buffer produced by `describe-categories'.
3072 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3073 members before the level stack, so they would be saved and
3074 restored when copying iterator state. Fixes incorrect reordering
3075 around TABs covered by display properties.
3077 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3079 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3081 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3083 * eval.c (internal_condition_case, internal_condition_case_1)
3084 (internal_condition_case_2, internal_condition_case_n):
3085 Remove unnecessary aborts (Bug#9081).
3087 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3089 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3090 has no `load' handler, try opening the file locally. (Bug#9311)
3092 2011-08-16 Ken Brown <kbrown@cornell.edu>
3094 * gmalloc.c: Expand comment.
3096 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3098 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3099 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3101 2011-08-16 Ken Brown <kbrown@cornell.edu>
3103 Fix memory allocation problems in Cygwin build (Bug#9273).
3105 * unexcw.c ( __malloc_initialized): Declare external variable.
3106 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3108 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3110 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3112 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3114 [CYGWIN] (special_realloc): New function.
3115 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3116 requests to realloc storage in the static heap.
3118 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3120 * bidi.c (bidi_initialize): Remove unused local.
3122 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3125 * biditype.h: Remove file.
3126 * makefile.w32-in ($(BLD)/bidi.$(O)):
3127 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3129 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3131 * chartab.c: Improve commentary for the uniprop_table API.
3133 * bidi.c (bidi_paragraph_init): Support zero value of
3134 bidi_ignore_explicit_marks_for_paragraph_level.
3135 (bidi_initialize): Use uniprop_table instead of including
3136 biditype.h and bidimirror.h.
3138 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3139 coordinates of the iterator when restoring from ppos_it.
3142 2011-08-14 Kenichi Handa <handa@m17n.org>
3144 * process.c (create_process): Call setup_process_coding_systems
3145 after the pid of the process is set to -1 (Bug#8162).
3147 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3149 * xdisp.c (move_it_in_display_line_to): Don't invoke
3150 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3151 ppos_it. Fixes vertical cursor motion when line beginning is
3152 covered by an image. (Bug#9296)
3154 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3156 * nsterm.h (ns_run_ascript): Declare.
3157 (NSAPP_DATA2_RUNASSCRIPT): Define.
3159 * nsfns.m (as_script, as_result, as_status): New static variables.
3160 (ns_run_ascript): New function.
3161 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3162 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3163 the event loop. Get status from as_status (Bug#7276).
3165 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3166 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3167 the event loop (Bug#7276).
3169 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3171 * gnutls.c (QCgnutls_bootprop_priority)
3172 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3173 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3174 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3175 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3176 (QCgnutls_bootprop_verify_hostname_error)
3177 (QCgnutls_bootprop_callbacks_verify): Rename from
3178 Qgnutls_bootprop_..., all uses changed.
3180 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3183 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3185 * xfaces.c (Qframe_set_background_mode): Now static.
3186 * dispextern.h (Qframe_set_background_mode): Remove decl.
3188 * process.c (Fnetwork_interface_info): Declare local only if needed.
3190 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3192 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3193 (Fnetwork_interface_list): Allocate in increments of bytes instead
3194 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3195 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3197 (struct ifflag_def): notrailers is smart on OSX.
3198 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3199 Get hardware address with getifaddrs if available.
3201 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3203 * xdisp.c (iterate_out_of_display_property): xassert that
3204 IT->position is set to within IT->object's boundaries. Break from
3205 the loop as soon as EOB is reached; avoids infloops in redisplay
3206 when IT->position is set up wrongly due to some bug.
3207 Set IT->current to match the bidi iterator unconditionally.
3208 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3209 entry. Force push_it to save on the stack the current
3210 buffer/string position, to be restored by pop_it. Fix flags in
3211 the iterator structure wrt the object coming from a display
3212 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3213 properties. (Bug#9284)
3215 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3217 * fontset.c (fontset_get_font_group): Add proper type checks.
3220 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3222 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3223 and LC_VERSION_MIN_MACOSX.
3224 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3225 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3227 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3229 * xdisp.c (forward_to_next_line_start): Allow to use the
3230 no-display-properties-and-no-overlays under bidi display.
3231 Set disp_pos in the bidi iterator to avoid searches for display
3232 properties and overlays.
3234 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3236 * editfns.c (Fset_time_zone_rule): Document relationship with the
3239 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3240 the font entity extracted from the cache (Bug#8109).
3242 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3244 * composite.c (autocmp_chars): Don't reset point. That is done by
3245 restore_point_unwind (Bug#5984).
3247 2011-08-07 Juri Linkov <juri@jurta.org>
3249 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3250 to show the arg `TIME' instead of `TIMEVAL'.
3252 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3254 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3255 display property strides EOL and includes a newline, as in
3256 longlines-mode. (Bug#9254)
3257 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3258 word-wrap under bidirectional display. (Bug#9224)
3260 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3261 is non-zero, even if the data buffer is NULL. Fixes a crash in
3262 vertical-motion with longlines-mode. (Bug#9254)
3264 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3266 * bidi.c <bidi_cache_total_alloc>: Now static.
3267 (bidi_initialize): Initialize bidi_cache_total_alloc.
3269 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3272 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3273 amount allocated this far in `bidi_cache_total_alloc'.
3274 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3275 non-zero, only free the data buffer without restoring the cache
3276 contents. All callers changed.
3278 * dispextern.h (bidi_unshelve_cache): Update prototype.
3280 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3281 (move_it_in_display_line, move_it_to)
3282 (move_it_vertically_backward, move_it_by_lines): Replace the call
3283 to xfree to an equivalent call to bidi_unshelve_cache.
3284 (move_it_in_display_line_to): Fix logic of returning
3285 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3287 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3289 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3290 came from a string character with a `cursor' property. (Bug#9229)
3292 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3294 * Makefile.in (LIB_PTHREAD): New variable.
3295 (LIBES): Add LIB_PTHREAD (Bug#9216).
3297 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3298 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3300 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3302 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3304 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3306 * xterm.c (x_find_topmost_parent): New function.
3307 (x_set_frame_alpha): Find topmost parent window with
3308 x_find_topmost_parent and set the property there also (bug#9181).
3309 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3311 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3313 * callproc.c (Fcall_process): Avoid vfork clobbering
3314 the local vars buffer, coding_systems, current_dir.
3316 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3318 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3320 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3322 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3323 so that it is not optimized away.
3325 * xdisp.c (compute_display_string_pos): Remove unused local.
3327 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3329 Fix slow cursor motion and scrolling in large buffers with
3330 selective display, like Org Mode buffers. (Bug#9218)
3332 * dispextern.h (struct bidi_it): New member disp_prop_p.
3334 * xdisp.c: Remove one-slot cache of display string positions.
3335 (compute_display_string_pos): Accept an additional argument
3336 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3337 for a display string or property. If found, set DISP_PROP_P
3340 * bidi.c (bidi_fetch_char): Accept an additional argument
3341 DISP_PROP_P, and pass it to compute_display_string_pos.
3342 Only handle text covered by a display string if DISP_PROP_P is returned
3343 non-zero. All callers of bidi_fetch_char changed.
3345 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3347 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3349 2010-12-03 Don March <don@ohspite.net>
3351 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3352 last character M-[char] is translated to ESC [char] (bug#7541).
3354 2011-08-02 Kenichi Handa <handa@m17n.org>
3356 * lisp.h (uniprop_table): Extern it.
3358 * chartab.c (uniprop_table): Make it non-static.
3360 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3362 * xdisp.c (forward_to_next_line_start): Accept additional argument
3363 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3365 (reseat_at_next_visible_line_start): Use the bidi iterator state
3366 returned by forward_to_next_line_start to restore the state of
3367 it->bidi_it after backing up to previous newline. (Bug#9212)
3369 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3371 * regex.c (re_comp): Protoize.
3372 (re_exec): Fix return type.
3373 (regexec): Fix type of `ret'. (Bug#9203)
3375 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3377 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3378 This is needed if max-image-size is a floating-point number.
3380 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3382 * print.c (print_object): Print empty symbol as ##.
3384 * lread.c (read1): Read ## as empty symbol.
3386 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3388 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3389 setting frame foreground color (Bug#9175).
3390 (x_set_background_color): Likewise.
3392 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3393 contents (Bug#9176).
3394 (EmacsTooltip -init): Remove bezels and add shadows to
3397 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3398 or scroll bar (Bug#8470).
3400 * nsfont.m (nsfont_open): Remove assignment to voffset and
3401 unnecessary vars hshink, expand, hd, full_height, min_height.
3402 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3404 * nsterm.h (nsfont_info): Remove voffset field.
3406 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3408 Implement strike-through and overline on NextStep (Bug#8863).
3410 * nsfont.m (nsfont_open): Use underline position provided by font,
3411 instead of hard-coded value of 2.
3412 (nsfont_draw): Call ns_draw_text_decoration instead.
3414 * nsterm.h: Add declaration for ns_draw_text_decoration.
3416 * nsterm.m (ns_draw_text_decoration): New function for drawing
3417 underline, overline, and strike-through.
3418 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3419 ns_draw_text_decoration. Change treatment of cursor drawing to
3420 accommodate underlining, etc.
3422 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3424 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3427 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3429 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3430 Without this fix, if a signal arrives just after memory fills up,
3431 'malloc' might be invoked reentrantly.
3433 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3434 In other words, assume that every image size is allowed, on non-X
3435 hosts. This assumption is probably wrong, but it lets Emacs compile.
3437 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3439 * regex.c (re_iswctype): Convert return values to boolean.
3441 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3443 * xdisp.c (compute_display_string_pos): Don't use cached display
3444 string position if the buffer had its restriction changed.
3447 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3449 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3451 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3453 Integer signedness and overflow and related fixes. (Bug#9079)
3455 * bidi.c: Integer size and overflow fixes.
3456 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3457 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3458 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3459 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3460 (bidi_find_other_level_edge):
3461 Use ptrdiff_t instead of EMACS_INT where either will do.
3462 This works better on 32-bit hosts configured --with-wide-int.
3463 (bidi_cache_ensure_space): Check for size-calculation overflow.
3464 Use % rather than repeated addition, for better worst-case speed.
3465 Don't set bidi_cache_size until after xrealloc returns, because it
3467 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3468 (bidi_cache_ensure_space): Also check that the bidi cache size
3469 does not exceed that of the largest Lisp string or buffer. See Eli
3470 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3472 * alloc.c (__malloc_size_t): Remove.
3473 All uses replaced by size_t. See Andreas Schwab's note
3474 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3476 * image.c: Improve checking for integer overflow.
3477 (check_image_size): Assume that f is nonnull, since
3478 it is always nonnull in practice. This is one less thing to
3479 worry about when checking for integer overflow later.
3480 (x_check_image_size): New function, which checks for integer
3481 overflow issues inside X.
3482 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3483 This removes the need for a memory_full check.
3484 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3485 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3486 (xbm_read_bitmap_data): Change locals back to 'int', since
3487 their values must fit in 'int'.
3488 (xpm_load_image, png_load, tiff_load):
3489 Invoke x_create_x_image_and_pixmap earlier,
3490 to avoid much needless work if the image is too large.
3491 (tiff_load): Treat overly large images as if
3492 x_create_x_image_and_pixmap failed, not as malloc failures.
3493 (gs_load): Use x_check_image_size.
3495 * gtkutil.c: Omit integer casts.
3496 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3497 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3499 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3501 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3502 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3503 would wrongly return t on a 64-bit host.
3505 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3506 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3507 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3508 and therefore cause GCC to emit a bogus diagnostic in some cases.
3510 * image.c: Integer signedness and overflow and related fixes.
3511 This is not an exhaustive set of fixes, but it's time to
3512 record what I've got.
3513 (lookup_pixel_color, check_image_size): Remove redundant decls.
3514 (check_image_size): Don't assume that arbitrary EMACS_INT values
3515 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3516 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3517 (tiff_load, imagemagick_load_image):
3518 Check for overflow in size calculations.
3519 (x_create_x_image_and_pixmap): Remove unnecessary test for
3520 xmalloc returning NULL; that can't happen.
3521 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3522 (xpm_color_bucket): Use better integer hashing function.
3523 (xpm_cache_color): Don't possibly over-allocate memory.
3524 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3525 (gif_memory_source):
3526 Use ptrdiff_t, not int or size_t, to record sizes.
3527 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3528 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3529 either works, as we prefer signed integers.
3530 (tiff_read_from_memory, tiff_write_from_memory):
3531 Return tsize_t, not size_t, since that's what the TIFF API wants.
3532 (tiff_read_from_memory): Don't fail simply because the read would
3533 go past EOF; instead, return a short read.
3534 (tiff_load): Omit no-longer-needed casts.
3535 (Fimagemagick_types): Don't assume size fits into 'int'.
3537 Improve hashing quality when configured --with-wide-int.
3538 * fns.c (hash_string): New function, taken from sxhash_string.
3539 Do not discard information about ASCII character case; this
3540 discarding is no longer needed.
3541 (sxhash-string): Use it. Change sig to match it. Caller changed.
3542 * lisp.h: Declare it.
3543 * lread.c (hash_string): Remove, since we now use fns.c's version.
3544 The fns.c version returns a wider integer if --with-wide-int is
3545 specified, so this should help the quality of the hashing a bit.
3547 * emacs.c: Integer overflow minor fix.
3548 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3549 Define only if GNU_LINUX.
3550 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3552 * dispnew.c: Integer signedness and overflow fixes.
3553 Remove unnecessary forward decls, that were a maintenance hassle.
3554 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3556 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3557 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3558 (prepare_desired_row, line_draw_cost):
3559 Use int, not unsigned, where either works.
3560 (save_current_matrix, restore_current_matrix):
3561 Use ptrdiff_t, not size_t, where either works.
3562 (init_display): Check for overflow more accurately, and without
3563 relying on undefined behavior.
3565 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3566 Remove, replacing with the new symbols in lisp.h. All uses changed.
3567 * fileio.c (make_temp_name):
3568 * filelock.c (lock_file_1, lock_file):
3569 * xdisp.c (message_dolog):
3570 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3571 Use pMd etc. instead.
3572 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3573 replacing the pWIDE etc. symbols removed from editfns.c.
3575 * keyboard.h (num_input_events): Now uintmax_t.
3576 This is (very slightly) less likely to mess up due to wraparound.
3579 * buffer.c: Integer signedness fixes.
3580 (alloc_buffer_text, enlarge_buffer_text):
3581 Use ptrdiff_t rather than size_t when either will do, as we prefer
3584 * alloc.c: Integer signedness and overflow fixes.
3585 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3586 (__malloc_size_t): Default to size_t, not to int.
3587 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3588 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3589 Prefer ptrdiff_t to size_t when either would do, as we prefer
3591 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3592 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3593 Now const. Initialize with values that are in range even if char
3595 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3596 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3597 These functions do the right thing with sizes > 2**32.
3598 (check_depth): Now ptrdiff_t, not int.
3599 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3600 Adjust to new way of storing sizes. Check for size overflow bugs
3602 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3603 slightly wrong anyway, as it missed one instance of
3604 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3605 (refill_memory_reserve): Omit needless cast to size_t.
3606 (mark_object_loop_halt): Mark as externally visible.
3608 * xselect.c: Integer signedness and overflow fixes.
3609 (Fx_register_dnd_atom, x_handle_dnd_message):
3610 Use ptrdiff_t, not size_t, since we prefer signed.
3611 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3612 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3613 x_dnd_atoms_size and x_dnd_atoms_length.
3615 * doprnt.c: Prefer signed to unsigned when either works.
3617 * doprnt.c (doprnt):
3619 * xdisp.c (vmessage):
3620 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3621 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3622 prefer signed arithmetic to avoid comparison confusion.
3623 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3624 but is a bit tricky.
3626 Assume freestanding C89 headers, string.h, stdlib.h.
3627 * data.c, doprnt.c, floatfns.c, print.c:
3628 Include float.h unconditionally.
3629 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3630 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3631 * regex.c: Likewise for stddef.h, string.h.
3632 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3633 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3634 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3635 (STDC_HEADERS): Remove obsolete defines.
3636 * sysdep.c: Include limits.h unconditionally.
3638 Assume support for memcmp, memcpy, memmove, memset.
3639 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3640 * regex.c (memcmp, memcpy):
3641 Remove; we assume C89 now.
3643 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3644 (__malloc_safe_bcopy): Remove; no longer needed.
3646 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3647 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3648 well either way, and we prefer signed to unsigned.
3650 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3652 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3653 closes the connection while we're reading (bug#9182).
3655 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3657 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3658 are specified (Bug#9168).
3660 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3662 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3663 Found by GCC static checking and --with-wide-int on a 32-bit host.
3665 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3667 * xdisp.c (compute_display_string_pos): Fix logic of caching
3668 previous display string position. Initialize cached_prev_pos to
3669 -1. Fixes slow-down at the beginning of a buffer.
3671 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3673 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3674 for attrs[LFACE_FONTSET_INDEX].
3676 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3678 * xml.c (parse_region): Remove unused local
3679 that was recently introduced.
3681 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3683 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3684 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3686 * xdisp.c (move_it_in_display_line_to): Record the best matching
3687 position for TO_CHARPOS while scanning the line, and restore it on
3688 exit if none of the characters scanned was an exact match.
3689 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3690 when exact match is impossible due to invisible text, and the
3691 lines are truncated.
3693 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3695 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3698 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3700 Fix a significant slow-down of cursor motion with C-n, C-p,
3701 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3702 auto-repeat under bidi redisplay in fontified buffers.
3703 * xdisp.c (compute_stop_pos_backwards): New function.
3704 (next_element_from_buffer): Call compute_stop_pos_backwards to
3705 find a suitable prev_stop when we find ourselves before
3707 (reseat): Don't look for prev_stop, as that could mean a very long
3709 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3710 <cached_disp_overlay_modiff>: Cache for last found display string
3712 (compute_display_string_pos): Return the cached position if asked
3713 about the same buffer in the same area of character positions, and
3714 the buffer wasn't changed since the time the display string
3715 position was cached.
3717 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3719 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3720 is an integer, which is important for empty lines. (Bug#9149)
3722 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3724 * frame.c (Fmodify_frame_parameters): In tty case, update the
3725 default face if necessary (Bug#4238).
3727 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3729 * editfns.c (Fstring_to_char): No need to explain what a character
3730 is in the docstring (Bug#6576).
3732 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3734 * xml.c (parse_region): Make sure we always return a tree.
3736 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3738 * xml.c (parse_region): If a document contains only comments,
3741 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3743 * xml.c (make_dom): Return comments, too.
3745 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3748 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3749 and the surrounding thread.
3750 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3751 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3752 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3754 * s/openbsd.h (BROKEN_SIGIO): Define.
3755 * unexelf.c (unexec) [__OpenBSD__]:
3756 Don't update the .mdebug section of the Alpha COFF symbol table.
3758 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3760 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3763 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3765 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3766 This fixes some race conditions on the permissions of any newly
3769 * alloc.c (valid_pointer_p): Use pipe, not open.
3770 This fixes some permissions issues when debugging.
3772 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3773 If fchown fails to set both uid and gid, try to set just gid,
3774 as that is sometimes allowed. Adjust the file's mode to eliminate
3775 setuid or setgid bits that are inappropriate if fchown fails.
3777 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3779 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3780 to compare Lisp_Objects.
3781 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3782 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3783 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3785 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3787 * lread.c (read_integer): Unread even EOF character.
3788 (read1): Likewise. Properly record start position of symbol.
3790 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3791 symbol character follows.
3793 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3795 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3796 This works around a problem with the previous change to Fcopy_file.
3797 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3798 and without this change, GCC might complain about discarding
3799 fchown's return value.
3801 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3803 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3805 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3807 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3809 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3811 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3812 it's used from the C level.
3814 * process.c: Use the same condition for POLL_FOR_INPUT in both
3815 keyboard.c and process.c (bug#1858).
3817 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3819 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3820 (Fgnutls_boot): Use it.
3822 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3824 * doc.c (Fsubstitute_command_keys): Revert last change.
3826 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3828 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3829 quotes the next character, and doesn't affect other longer
3830 sequences (bug#8935).
3832 * lread.c (syms_of_lread): Clarify that is isn't only
3833 `eval-buffer' and `eval-defun' that's affected by
3834 `lexical-binding' (bug#8460).
3836 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3838 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3839 bidi redisplay when a line includes both an image and is truncated.
3841 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3843 Fix minor problems found by static checking.
3844 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3845 (elsz): Now a signed constant, not a size_t var. We prefer signed
3846 types to unsigned, to avoid integer comparison confusion. Without
3847 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3848 "cannot optimize loop, the loop counter may overflow", a symptom
3850 * indent.c (Fvertical_motion): Mark locals as initialized.
3851 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3853 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3855 * search.c (Fre_search_backward): Mention `case-fold-search' in
3856 all the re_search_* functions (bug#8138).
3858 * keyboard.c (Fopen_dribble_file): Document when the file is
3861 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3863 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3866 Support bidi reordering of display and overlay strings.
3867 * xdisp.c (compute_display_string_pos)
3868 (compute_display_string_end): Accept additional argument STRING.
3869 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3870 (reseat_to_string): Initialize bidi_it->string.s and
3871 bidi_it->string.schars.
3872 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3873 NULL (avoids a crash in bidi_paragraph_init).
3874 Initialize itb.string.lstring.
3875 (init_iterator): Call bidi_init_it only of a valid
3876 buffer position was specified. Initialize paragraph_embedding to
3878 (reseat_to_string): Initialize the bidi iterator.
3879 (display_string): If we need to ignore text properties of
3880 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3881 original value of -1 will not work with bidi.)
3882 (compute_display_string_pos): First arg is now struct
3883 `text_pos *'; all callers changed. Support display properties on
3885 (compute_display_string_end): Support display properties on Lisp
3887 (init_iterator, reseat_1, reseat_to_string): Initialize the
3888 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3889 when iterating on a string not from display properties).
3890 (compute_display_string_pos, compute_display_string_end):
3891 Fix calculation of the object to scan. Fixes an error when using
3893 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3894 base_level_stop; instead, set base_level_stop to BEGV.
3895 Fixes crashes in vertical-motion.
3896 (next_element_from_buffer): Improve commentary for when
3897 the iterator is before prev_stop.
3898 (init_iterator): Initialize bidi_p from the default value of
3899 bidi-display-reordering, not from buffer-local value. Use the
3900 buffer-local value only if initializing for buffer iteration.
3901 (handle_invisible_prop): Support invisible properties on strings
3902 that are being bidi-reordered.
3903 (set_iterator_to_next): Support bidi reordering of C strings and
3905 (next_element_from_string): Support bidi reordering of Lisp
3907 (handle_stop_backwards): Support Lisp strings as well.
3908 (display_string): Support display of R2L glyph rows.
3909 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3910 (init_iterator): Don't initialize it->bidi_p for strings
3912 (reseat_to_string): Initialize it->bidi_p for strings here.
3913 (next_element_from_string, next_element_from_c_string)
3914 (next_element_from_buffer): Add xassert's for correspondence
3915 between IT's object being iterated and it->bidi_it.string
3917 (face_before_or_after_it_pos): Support bidi iteration.
3918 (next_element_from_c_string): Handle the case of the first string
3919 character that is not the first one in the visual order.
3920 (get_visually_first_element): New function, refactored from common
3921 parts of next_element_from_buffer, next_element_from_string, and
3922 next_element_from_c_string.
3923 (tool_bar_lines_needed, redisplay_tool_bar)
3924 (display_menu_bar): Force left-to-right direction. Add a FIXME
3925 comment for making that be controlled by a user option.
3926 (push_it, pop_it): Save and restore the state of the
3927 bidi iterator. Save and restore the bidi_p flag.
3928 (pop_it): Iterate out of display property for string iteration as
3930 (iterate_out_of_display_property): Support iteration over strings.
3931 (handle_single_display_spec): Set up it->bidi_it for iteration
3932 over a display string, and call bidi_init_it.
3933 (handle_single_display_spec, next_overlay_string)
3934 (get_overlay_strings_1, push_display_prop): Set up the bidi
3935 iterator for displaying display or overlay strings.
3936 (forward_to_next_line_start): Don't use the shortcut if
3938 (back_to_previous_visible_line_start): If handle_display_prop
3939 pushed the iterator stack, restore the internal state of the bidi
3940 iterator by calling bidi_pop_it same number of times.
3941 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3942 and we are bidi-iterating, don't decrement the iterator position;
3943 instead, set the first_elt flag in the bidi iterator, to produce
3945 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3946 (push_display_prop): xassert that we are iterating a buffer.
3947 (push_it, pop_it): Save and restore paragraph_embedding member.
3948 (handle_single_display_spec, next_overlay_string)
3949 (get_overlay_strings_1, reseat_1, reseat_to_string)
3950 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3951 correctly. Don't assume unibyte strings are not bidi-reordered.
3952 (compute_display_string_pos)
3953 (compute_display_string_end): Fix handling the case of C string.
3954 (push_it, pop_it): Save and restore from_disp_prop_p.
3955 (handle_single_display_spec, push_display_prop): Set the
3956 from_disp_prop_p flag.
3957 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3958 (pop_it): Call iterate_out_of_display_property only if we are
3959 popping after iteration over a string that came from a display
3960 property. Fix a typo in popping stretch info. Add an assertion
3961 for verifying that the iterator position is in sync with the bidi
3963 (handle_single_display_spec, get_overlay_strings_1)
3964 (push_display_prop): Fix initialization of paragraph direction for
3965 string when that of the parent object is not yet determined.
3966 (reseat_1): Call bidi_init_it to resync the bidi
3967 iterator with IT's position. (Bug#7616)
3968 (find_row_edges): If ROW->start.pos gives position
3969 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3970 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3971 Reset the from_disp_prop_p flag.
3972 (SAVE_IT, RESTORE_IT): New macros.
3973 (pos_visible_p, face_before_or_after_it_pos)
3974 (back_to_previous_visible_line_start)
3975 (move_it_in_display_line_to, move_it_in_display_line)
3976 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3977 (try_scrolling, redisplay_window, display_line): Use them when
3978 saving a temporary copy of the iterator and restoring it back.
3979 (back_to_previous_visible_line_start, reseat_1)
3980 (init_iterator): Empty the bidi cache "stack".
3981 (move_it_in_display_line_to): If iterator ended up at
3982 EOL, but we never saw any buffer positions smaller than
3983 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3984 motion in bidi-reordered lines.
3985 (move_it_in_display_line_to): Record prev_method and prev_pos
3986 immediately before the call to set_iterator_to_next. Fixes cursor
3987 motion in bidi-reordered lines with stretch glyphs and strings
3988 displayed in margins. (Bug#8133) (Bug#8867)
3989 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3991 (pos_visible_p): Support positions in bidi-reordered lines.
3992 Save and restore bidi cache.
3994 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3995 (bidi_paragraph_info): Delete unused struct.
3996 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3997 (bidi_cache_start): New variable.
3998 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4000 (bidi_cache_fetch_state, bidi_cache_search)
4001 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4002 (bidi_cache_find, bidi_peek_at_next_level)
4003 (bidi_level_of_next_char, bidi_find_other_level_edge)
4004 (bidi_move_to_visually_next): Compare cache index with
4005 bidi_cache_start rather than with zero.
4006 (bidi_fetch_char): Accept new argument STRING; all callers
4007 changed. Support iteration over a string. Support strings with
4008 display properties. Support unibyte strings. Fix the type of
4009 `len' according to what STRING_CHAR_AND_LENGTH expects.
4010 (bidi_paragraph_init, bidi_resolve_explicit_1)
4011 (bidi_resolve_explicit, bidi_resolve_weak)
4012 (bidi_level_of_next_char, bidi_move_to_visually_next):
4013 Support iteration over a string.
4014 (bidi_set_sor_type, bidi_resolve_explicit_1)
4015 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4016 can now be zero (for strings); special values 0 and -1 were
4017 changed to -1 and -2, respectively.
4018 (bidi_char_at_pos): New function.
4019 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4020 Call it instead of FETCH_MULTIBYTE_CHAR.
4021 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4022 initialized to valid values.
4023 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4025 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4026 the test for valid cached positions. Fix the logic for looking up
4027 the sentinel state in the cache. GCPRO the Lisp string we are
4029 (bidi_push_it, bidi_pop_it): New functions.
4030 (bidi_initialize): Initialize the bidi cache start stack pointer.
4031 (bidi_cache_ensure_space): New function, refactored from part of
4032 bidi_cache_iterator_state. Don't assume the required size is just
4033 one BIDI_CACHE_CHUNK away.
4034 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4035 (bidi_count_bytes, bidi_char_at_pos): New functions.
4036 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4037 always valid if bidi_cache_idx is valid.
4038 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4039 is valid if it's going to be used.
4040 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4041 (bidi_cache_fetch_state, bidi_cache_search)
4042 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4043 (bidi_cache_iterator_state, bidi_cache_find)
4044 (bidi_find_other_level_edge, bidi_cache_start_stack):
4045 All variables related to cache indices are now EMACS_INT.
4047 * dispextern.h (struct bidi_string_data): New structure.
4048 (struct bidi_it): New member `string'. Make flag members be 1-bit
4049 fields, and put them last in the struct.
4050 (compute_display_string_pos, compute_display_string_end):
4052 (bidi_push_it, bidi_pop_it): Add prototypes.
4053 (struct iterator_stack_entry): New members bidi_p,
4054 paragraph_embedding, and from_disp_prop_p.
4055 (struct it): Member bidi_p is now a bit field 1 bit wide.
4056 (bidi_shelve_cache, bidi_unshelve_cache):
4059 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4060 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4061 and vector-like objects.
4063 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4064 cache around display iteration.
4066 * window.c (Fwindow_end, window_scroll_pixel_based)
4067 (displayed_window_lines, Frecenter): Save and restore the bidi
4068 cache around display iteration.
4070 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4072 * editfns.c (Fdelete_region): Clarify the use of the named
4073 parameters (bug#6788).
4075 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4077 * indent.c (Fvertical_motion): Set and restore w->pointm when
4078 saving and restoring the window's buffer (Bug#9006).
4080 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4082 * editfns.c (Fstring_to_char): Clarify just what is returned
4083 (bug#6576). Text by Eli Zaretskii.
4085 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4087 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4089 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4091 * buffer.c (mmap_find): Fix a typo.
4093 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4095 Fix execution of x selection hooks.
4096 * xselect.c (Qx_lost_selection_functions)
4097 (Qx_sent_selection_functions): New vars.
4098 (syms_of_xselect): DEFSYM them.
4099 (x_handle_selection_request): Pass Qx_sent_selection_functions
4100 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4101 (x_handle_selection_clear,x_clear_frame_selections):
4102 Pass Qx_lost_selection_functions rather than
4103 Vx_lost_selection_functions to Frun_hook_with_args.
4105 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4107 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4108 The old code sometimes used this field without initializing it.
4110 * alloc.c (gc_sweep): Don't read past end of array.
4111 In theory, the old code could also have corrupted Emacs internals,
4112 though it'd be very unlikely.
4114 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4116 * character.c (Fcharacterp): Don't advertise optional ignored
4117 argument. (Bug#4026)
4119 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4121 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4124 * window.c (Fset_window_start): Doc fix (bug#4199).
4125 (Fset_window_hscroll): Ditto.
4127 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4129 Fix minor new problems caught by GCC 4.6.1.
4130 * term.c (init_tty): Remove unused local.
4131 * xsettings.c (store_monospaced_changed): Define this function only
4132 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4135 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4137 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4139 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4141 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4142 are the mini-buffer and the echo area (bug#3320).
4144 * term.c (init_tty): Remove support for supdup, c10 and perq
4145 terminals, which are no longer supported (bug#1482).
4147 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4149 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4151 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4153 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4154 for non-popups (Bug#3642).
4156 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4158 * alloc.c (reset_malloc_hooks): Protoize.
4159 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4160 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4161 * cm.c (losecursor): Likewise.
4162 * data.c (fmod): Likewise.
4163 * dispnew.c (swap_glyphs_in_rows): Likewise.
4164 * emacs.c (memory_warning_signal): Likewise.
4165 * floatfns.c (float_error): Likewise.
4166 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4167 (otf_open, font_otf_capability, generate_otf_features)
4168 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4170 * image.c (pbm_read_file): Likewise.
4171 * indent.c (string_display_width): Likewise.
4172 * intervals.c (check_for_interval, search_for_interval)
4173 (inc_interval_count, count_intervals, root_interval)
4174 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4175 * lread.c (defalias): Likewise.
4176 * ralloc.c (r_alloc_check): Likewise.
4177 * regex.c (set_image_of_range_1, set_image_of_range)
4178 (regex_grow_registers): Likewise.
4179 * sysdep.c (strerror): Likewise.
4180 * termcap.c (valid_filename_p, tprint, main): Likewise.
4181 * tparam.c (main): Likewise.
4182 * unexhp9k800.c (run_time_remap, save_data_space)
4183 (update_file_ptrs, read_header, write_header, calculate_checksum)
4184 (copy_file, copy_rest, display_header): Likewise.
4185 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4187 * xdisp.c (check_it): Likewise.
4188 * xfaces.c (register_color, unregister_color, unregister_colors):
4190 * xfns.c (print_fontset_result): Likewise.
4191 * xrdb.c (member, fatal, main): Likewise.
4193 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4195 Fix minor problems found by static checking (Bug#9031).
4196 * chartab.c (char_table_set_range, map_sub_char_table):
4197 Remove unused locals.
4198 (uniprop_table): Now static.
4199 * composite.c (_work_char): Remove unused static var.
4201 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4203 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4205 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4207 * gtkutil.c (qttip_cb): Remove code without function.
4209 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4211 * w32.c (pthread_sigmask): New stub.
4213 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4215 Use pthread_sigmask, not sigprocmask (Bug#9010).
4216 sigprocmask is portable only for single-threaded applications, and
4217 Emacs can be multi-threaded when it uses GTK.
4218 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4220 * callproc.c (Fcall_process):
4221 * process.c (create_process):
4222 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4223 Use pthread_sigmask, not sigprocmask.
4225 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4227 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4228 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4231 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4233 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4234 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4235 (xg_hide_tooltip): Fix comment.
4237 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4238 in registerServicesMenuSendTypes.
4239 (validRequestorForSendType): Don't check ns_return_types.
4241 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4244 2011-07-08 Jason Rumney <jasonr@gnu.org>
4246 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4247 SH_SHOW for hidden windows (Bug#5482).
4249 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4250 frame struct members of non-existent frames (Bug#6284).
4252 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4254 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4255 variable firstTime not needed on OSX >= 10.6.
4256 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4257 >= 10.5. Use setKnobProportion, setDoubleValue.
4259 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4260 (MAC_OS_X_VERSION_10_5): Define if not defined.
4261 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4262 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4263 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4265 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4266 cString and lossyCString on OSX >= 10.4
4268 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4269 sizeToFit on OSX >= 10.2.
4271 * nsimage.m (allocInitFromFile): Don't use deprecated method
4272 bestRepresentationForDevice on OSX >= 10.6.
4274 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4277 * emacs.c: Declare unexec_init_emacs_zone.
4279 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4281 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4283 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4284 on svcsMenu (Bug#8842).
4286 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4288 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4290 * nsterm.m (QUTF8_STRING): Declare.
4291 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4292 (validRequestorForSendType): Return type is (id).
4293 Change indexOfObjectIdenticalTo to indexOfObject.
4294 Check if we have local selection before returning self (Bug#8842).
4295 (writeSelectionToPasteboard): Put local selection into paste board
4296 if we have a local selection (Bug#8842).
4297 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4299 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4300 (ns_get_local_selection): Declare.
4302 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4304 * keymap.c (describe_map_tree): Don't insert a double newline at
4305 the end of the buffer (bug#1169) and return whether we inserted
4308 * callint.c (Fcall_interactively): Change "reading args" to
4309 "providing args" to try to clarify what it does (bug#1010).
4311 2011-07-07 Kenichi Handa <handa@m17n.org>
4313 * composite.c (composition_compute_stop_pos): Ignore a static
4314 composition starting before CHARPOS (Bug#8915).
4316 * xdisp.c (handle_composition_prop): Likewise.
4318 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4320 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4323 2011-07-07 Kenichi Handa <handa@m17n.org>
4325 * character.h (unicode_category_t): New enum type.
4327 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4328 (Qchar_code_property_table): New variable.
4329 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4330 (UNIPROP_COMPRESSED_FORM_P): New macros.
4331 (char_table_ascii): Uncompress the compressed values.
4332 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4333 Uncompress the compressed values.
4334 (sub_char_table_ref_and_range): Likewise.
4335 (char_table_ref_and_range): Uncompress the compressed values.
4336 (sub_char_table_set): New arg is_uniprop. Callers changed.
4337 Uncompress the compressed values.
4338 (sub_char_table_set_range): Args changed. Callers changed.
4339 (char_table_set_range): Adjuted for the above change.
4340 (map_sub_char_table): Delete args default_val and parent. Add arg
4341 top. Give decoded values to a Lisp function.
4342 (map_char_table): Adjust for the above change. Give decoded
4343 values to a Lisp function. Gcpro more variables.
4344 (uniprop_table_uncompress)
4345 (uniprop_decode_value_run_length): New functions.
4346 (uniprop_decoder, uniprop_decoder_count): New variables.
4347 (uniprop_get_decoder, uniprop_encode_value_character)
4348 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4350 (uniprop_encoder, uniprop_encoder_count): New variables.
4351 (uniprop_get_encoder, uniprop_table)
4352 (Funicode_property_table_internal, Fget_unicode_property_internal)
4353 (Fput_unicode_property_internal): New functions.
4354 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4355 Sunicode_property_table_internal, Sget_unicode_property_internal,
4356 and Sput_unicode_property_internal. Defvar_lisp
4357 char-code-property-alist.
4359 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4360 Vunicode_category_table.
4362 * font.c (font_range): Adjust for the change of
4363 Vunicode_category_table.
4365 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4367 * m/iris4d.h: Remove file, move contents ...
4368 * s/irix6-5.h: ... here.
4370 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4372 Remove unportable assumption about struct layout (Bug#8884).
4373 * alloc.c (mark_buffer):
4374 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4375 (clone_per_buffer_values): Don't assume that
4376 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4377 This isn't true in general, and it's particularly not true
4378 if Emacs is configured with --with-wide-int.
4379 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4380 New macros, used in the buffer.c change.
4382 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4384 * xsettings.c: Use both GConf and GSettings if both are available.
4385 (store_config_changed_event): Add comment.
4386 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4387 (store_tool_bar_style_changed): New functions.
4388 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4389 (struct xsettings): Move font inside HAVE_XFT.
4390 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4391 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4392 Move inside HAVE_XFT.
4393 (something_changed_gsettingsCB): Rename from something_changedCB.
4394 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4396 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4397 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4398 (something_changed_gconfCB): Rename from something_changedCB.
4399 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4400 (parse_settings): Move check for font inside HAVE_XFT.
4401 (read_settings, apply_xft_settings): Add comment.
4402 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4403 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4404 call store_font_name_changed.
4405 (xft_settings_event): Add comment.
4406 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4407 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4408 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4409 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4410 (xsettings_initialize): Call init_gsettings last.
4411 (xsettings_get_system_font, xsettings_get_system_normal_font):
4414 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4416 Random fixes. E.g., (random) never returned negative values.
4417 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4418 subseconds part to the entropy, as that's a bit more random.
4419 Prefer signed to unsigned, since the signedness doesn't matter and
4420 in general we prefer signed. When given a limit, use a
4421 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4422 latter isn't right if USE_2_TAGS_FOR_INTS.
4423 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4424 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4426 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4428 * textprop.c (text_property_stickiness):
4429 Obey Vtext_property_default_nonsticky.
4430 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4431 * w32fns.c (syms_of_w32fns):
4432 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4434 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4436 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4437 This is more efficient than Ffile_directory_p and avoids a minor race.
4439 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4441 * buffer.c (Foverlay_put): Say what the return value is
4444 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4445 is a directory before asking whether to use the file name
4447 (barf_or_query_if_file_exists): Make the "File is a directory"
4448 error be more correct.
4450 * fns.c (Frequire): Remove the mention of the .gz files, since
4451 that's installation-specific, but keep the mention of
4452 `get-load-suffixes'.
4454 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4456 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4457 Report string overflow if the output is too long.
4459 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4461 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4462 (syms_of_gnutls): Remove duplicate DEFSYM for
4463 Qgnutls_bootprop_verify_hostname_error, an error for
4464 Qgnutls_bootprop_verify_error (which is no longer used).
4466 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4467 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4468 Also (re)move comments that are misplaced or no longer relevant.
4470 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4472 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4474 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4476 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4477 and background color parameters if they have been changed.
4479 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4481 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4483 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4485 * xsettings.c (SYSTEM_FONT): Define only when used.
4486 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4488 * keymap.c (access_keymap_1): Now static.
4490 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4492 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4493 leave any prefix arg for the up event (Bug#1586).
4495 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4497 * lread.c (syms_of_lread): Mention single symbols defined by
4498 `defvar' or `defconst' (bug#7154).
4500 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4501 (Frequire): Mention get-load-suffixes.
4503 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4505 * window.h (window): Remove clone_number slot.
4506 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4508 (make_parent_window, make_window, saved_window)
4509 (Fset_window_configuration, save_window_save): Don't deal with
4511 * buffer.c (Qclone_number): Remove declaration.
4512 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4514 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4516 Add multiple inheritance to keymaps.
4517 * keymap.c (Fmake_composed_keymap): New function.
4518 (Fset_keymap_parent): Simplify.
4519 (fix_submap_inheritance): Remove.
4520 (access_keymap_1): New function extracted from access_keymap to handle
4521 embedded parents and handle lists of maps.
4522 (access_keymap): Use it.
4523 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4524 (Fcopy_keymap): Handle embedded parents.
4525 (Fcommand_remapping, define_as_prefix): Simplify.
4526 (Fkey_binding): Simplify.
4527 (syms_of_keymap): Move minibuffer-local-completion-map,
4528 minibuffer-local-filename-completion-map,
4529 minibuffer-local-must-match-map, and
4530 minibuffer-local-filename-must-match-map to Elisp.
4531 (syms_of_keymap): Defsubr make-composed-keymap.
4532 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4533 (parse_menu_item): Trivial simplification.
4535 2011-07-01 Glenn Morris <rgm@gnu.org>
4537 * Makefile.in (SETTINGS_LIBS): Fix typo.
4539 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4541 * coding.c (Fencode_coding_string): Record the last coding system
4542 used, as the function doc string says (bug#8738).
4544 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4546 * xsettings.c (store_monospaced_changed): Take new font as arg and
4547 check for change against current_mono_font.
4548 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4549 (emacs_settings_constructor, emacs_settings_get_property)
4550 (emacs_settings_set_property, emacs_settings_class_init)
4551 (emacs_settings_init, gsettings_obj): Remove.
4552 (something_changedCB): New function for HAVE_GSETTINGS.
4553 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4554 with value as argument.
4555 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4556 g_settings_new (Bug#8967). Do not create gsettings_obj.
4557 Remove calls to g_settings_bind. Connect something_changedCB to
4560 * xgselect.c: Add defined (HAVE_GSETTINGS).
4561 (xgselect_initialize): Ditto.
4563 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4564 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4567 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4569 * eval.c (struct backtrace): Simplify and port the data structure.
4570 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4571 signed bit field, as this assumption is not portable and it makes
4572 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4573 "char debug_on_exit : 1" as this is not portable either; instead,
4574 use the portable "unsigned int debug_on_exit : 1". Remove unused
4575 member evalargs. Remove obsolete comments about cc bombing out.
4577 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4579 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4580 Let HAVE_GSETTINGS override HAVE_GCONF.
4581 (store_monospaced_changed): New function.
4582 (EMACS_SETTINGS): A new type derived from GObject to handle
4583 GSettings notifications.
4584 (emacs_settings_constructor, emacs_settings_get_property)
4585 (emacs_settings_set_property, emacs_settings_class_init):
4587 (gsettings_client, gsettings_obj): New variables.
4588 (GSETTINGS_SCHEMA): New define.
4589 (something_changedCB): Call store_monospaced_changed.
4590 (init_gsettings): New function.
4591 (xsettings_initialize): Call init_gsettings.
4592 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4595 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4598 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4600 * window.c (resize_root_window, grow_mini_window)
4601 (shrink_mini_window): Rename Qresize_root_window to
4602 Qwindow_resize_root_window and Qresize_root_window_vertically to
4603 Qwindow_resize_root_window_vertically.
4605 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4607 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4609 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4611 * makefile.w32-in: Redesign dependencies so they reflect more
4612 clearly which files are directly included by each source file,
4613 and not through other includes.
4615 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4617 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4618 (sort_overlays, overlay_strings): When an overlay's clone number
4619 matches the window's clone number process the overlay even if
4620 the overlay's window property doesn't match the current window.
4622 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4623 (Fwindow_hchild): Rename to Fwindow_left_child.
4624 (Fwindow_next): Rename to Fwindow_next_sibling.
4625 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4626 (resize_window_check): Rename to window_resize_check.
4627 (resize_window_apply): Rename to window_resize_apply.
4628 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4629 (Fdelete_other_windows_internal, resize_frame_windows)
4630 (Fsplit_window_internal, Fdelete_window_internal)
4631 (grow_mini_window, shrink_mini_window)
4632 (Fresize_mini_window_internal): Fix callers accordingly.
4634 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4636 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4637 (emacs_fixed_set_min_size): Remove.
4638 (emacs_fixed_new): Take frame as argument.
4640 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4641 (_EmacsFixedPrivate): Remove minwidth/height.
4642 Add struct frame *f.
4643 (emacs_fixed_init): Initialize priv->f.
4644 (get_parent_class, emacs_fixed_set_min_size): Remove.
4645 (emacs_fixed_new): Set priv->f to argument.
4646 (emacs_fixed_get_preferred_width)
4647 (emacs_fixed_get_preferred_height): Use min_width/height from
4648 frames size_hint to set minimum and natural (Bug#8919).
4649 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4650 and use min_width/height from frames size_hint to set
4651 min_width/height (Bug#8919).
4653 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4654 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4657 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4659 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4660 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4663 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4665 * process.c (wait_reading_process_output): Bypass select if
4666 waiting for a cell while ignoring keyboard input, and input is
4667 pending. Suggested by Jan Djärv (Bug#8869).
4669 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4671 Use gnulib's dup2 module instead of rolling our own.
4672 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4674 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4676 * dispnew.c (scrolling_window): Before scrolling, turn off a
4677 mouse-highlight in the window being scrolled.
4679 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4681 Move DEFSYM to lisp.h and use everywhere.
4683 * character.h (DEFSYM): Move declaration...
4684 * lisp.h (DEFSYM): ...here.
4690 * w32select.c: Don't include character.h.
4692 * alloc.c (syms_of_alloc):
4693 * buffer.c (syms_of_buffer):
4694 * bytecode.c (syms_of_bytecode):
4695 * callint.c (syms_of_callint):
4696 * casefiddle.c (syms_of_casefiddle):
4697 * casetab.c (init_casetab_once):
4698 * category.c (init_category_once, syms_of_category):
4699 * ccl.c (syms_of_ccl):
4700 * cmds.c (syms_of_cmds):
4701 * composite.c (syms_of_composite):
4702 * dbusbind.c (syms_of_dbusbind):
4703 * dired.c (syms_of_dired):
4704 * dispnew.c (syms_of_display):
4705 * doc.c (syms_of_doc):
4706 * editfns.c (syms_of_editfns):
4707 * emacs.c (syms_of_emacs):
4708 * eval.c (syms_of_eval):
4709 * fileio.c (syms_of_fileio):
4710 * fns.c (syms_of_fns):
4711 * frame.c (syms_of_frame):
4712 * fringe.c (syms_of_fringe):
4713 * insdel.c (syms_of_insdel):
4714 * keymap.c (syms_of_keymap):
4715 * lread.c (init_obarray, syms_of_lread):
4716 * macros.c (syms_of_macros):
4717 * msdos.c (syms_of_msdos):
4718 * print.c (syms_of_print):
4719 * process.c (syms_of_process):
4720 * search.c (syms_of_search):
4721 * sound.c (syms_of_sound):
4722 * syntax.c (init_syntax_once, syms_of_syntax):
4723 * terminal.c (syms_of_terminal):
4724 * textprop.c (syms_of_textprop):
4725 * undo.c (syms_of_undo):
4726 * w32.c (globals_of_w32):
4727 * window.c (syms_of_window):
4728 * xdisp.c (syms_of_xdisp):
4729 * xfaces.c (syms_of_xfaces):
4730 * xfns.c (syms_of_xfns):
4731 * xmenu.c (syms_of_xmenu):
4732 * xsettings.c (syms_of_xsettings):
4733 * xterm.c (syms_of_xterm): Use DEFSYM.
4735 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4737 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4739 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4741 Integer and buffer overflow fixes (Bug#8873).
4743 * print.c (printchar, strout): Check for string overflow.
4744 (PRINTPREPARE, printchar, strout):
4745 Don't set size unless allocation succeeds.
4747 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4748 for sizes. Check for string overflow more accurately.
4749 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4751 * macros.c: Integer and buffer overflow fixes.
4752 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4753 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4754 Use ptrdiff_t, not int, for sizes.
4755 Don't increment bufsize until after realloc succeeds.
4756 Check for size-calculation overflow.
4757 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4759 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4761 * lread.c: Integer overflow fixes.
4762 (read_integer): Radix is now EMACS_INT, not int,
4763 to improve quality of diagnostics for out-of-range radices.
4764 Calculate buffer size correctly for out-of-range radices.
4765 (read1): Check for integer overflow in radices, and in
4766 read-circle numbers.
4767 (read_escape): Avoid int overflow.
4768 (Fload, openp, read_buffer_size, read1)
4769 (substitute_object_recurse, read_vector, read_list, map_obarray):
4770 Use ptrdiff_t, not int, for sizes.
4771 (read1): Use EMACS_INT, not int, for sizes.
4772 Check for size overflow.
4774 * image.c (cache_image): Check for size arithmetic overflow.
4776 * lread.c: Integer overflow issues.
4777 (saved_doc_string_size, saved_doc_string_length)
4778 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4779 Now ptrdiff_t, not int.
4780 (read1): Don't assume doc string length fits in int. Check for
4781 out-of-range doc string lengths.
4782 (read_list): Don't assume file position fits in int.
4783 (read_escape): Check for hex character overflow.
4785 2011-06-22 Leo Liu <sdl.web@gmail.com>
4787 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4788 Move to minibuffer.el.
4790 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4792 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4793 The following patches are for when GLYPH_DEBUG && !XASSERT.
4794 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4795 * dispnew.c (flush_stdout):
4796 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4797 Mark as externally visible.
4798 * dispnew.c (check_window_matrix_pointers): Now static.
4799 * dispnew.c (window_to_frame_vpos):
4800 * xfns.c (unwind_create_frame):
4801 * xterm.c (x_check_font): Remove unused local.
4802 * scroll.c (CHECK_BOUNDS):
4803 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4804 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4805 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4806 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4807 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4809 (debug_method_add): Use va_list and vsprintf rather than relying
4810 on undefined behavior with wrong number of arguments.
4811 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4812 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4813 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4814 since we're not interested in debugging glyphs with old libraries.
4815 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4816 GCC 4.6.0's static checking.
4818 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4820 Integer overflow and signedness fixes (Bug#8873).
4821 A few related buffer overrun fixes, too.
4823 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4825 * dispextern.h (struct face.stipple):
4826 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4827 (x_bitmap_mask, x_allocate_bitmap_record)
4828 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4829 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4830 (x_create_bitmap_from_xpm_data):
4831 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4832 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4834 * xfaces.c (load_pixmap):
4835 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4836 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4837 (.bitmaps_last, struct x_output.icon_bitmap):
4838 Use ptrdiff_t, not int, for bitmap indexes.
4839 (x_allocate_bitmap_record): Check for size overflow.
4840 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4842 Use ptrdiff_t, not int, for overlay counts.
4843 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4844 * editfns.c (overlays_around, get_pos_property):
4845 * textprop.c (get_char_property_and_overlay):
4846 * xdisp.c (next_overlay_change, note_mouse_highlight):
4847 * xfaces.c (face_at_buffer_position):
4848 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4849 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4850 (Fnext_overlay_change, Fprevious_overlay_change)
4851 (mouse_face_overlay_overlaps, Foverlays_in):
4852 Use ptrdiff_t, not int, for sizes.
4853 (overlays_at, overlays_in): Check for size-calculation overflow.
4855 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4857 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4858 (x_session_initialize): Do not assume string length fits in int.
4860 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4861 This is unlikely, but can occur if DPI is outlandish.
4863 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4864 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4866 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4867 * xrdb.c (magic_file_p, search_magic_path):
4868 Omit last arg SUFFIX; it was always 0. All callers changed.
4869 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4871 * xfont.c (xfont_match): Avoid need for strlen.
4873 * xfns.c: Don't assume strlen fits in int.
4874 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4876 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4877 not unsigned long, as we prefer signed integers. All callers changed.
4878 Detect integer overflow in repeat count.
4879 (message_dolog): Don't assume print length fits in 39 bytes.
4880 (display_mode_element): Don't assume strlen fits in int.
4882 * termcap.c: Don't assume sizes fit in int and never overflow.
4883 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4884 (gobble_line): Check for size-calculation overflow.
4886 * minibuf.c (Fread_buffer):
4887 * lread.c (intern, intern_c_string):
4888 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4889 Don't assume string length fits in int.
4891 * keyboard.c (parse_tool_bar_item):
4892 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4894 * font.c: Don't assume string length fits in int.
4895 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4896 Use ptrdiff_t, not int.
4897 (font_intern_prop): Don't assume string length fits in int.
4898 Don't assume integer property fits in fixnum.
4899 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4901 * filelock.c: Fix some buffer overrun and integer overflow issues.
4902 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4903 Reformulate so as not to need the command string.
4904 Invoke gzip -cd rather than gunzip, as it's more portable.
4905 (lock_info_type, lock_file_1, lock_file):
4906 Don't assume pid_t and time_t fit in unsigned long.
4907 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4908 (current_lock_owner): Prefer signed type for sizes.
4909 Use memcpy, not strncpy, where memcpy is what is really wanted.
4910 Don't assume (via atoi) that time_t and pid_t fit in int.
4911 Check for time_t and/or pid_t out of range, e.g., via a network share.
4912 Don't alloca where an auto var works fine.
4914 * fileio.c: Fix some integer overflow issues.
4915 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4916 Don't assume string length fits in int.
4917 (directory_file_name): Don't assume string length fits in long.
4918 (make_temp_name): Don't assume pid fits in int, or that its print
4919 length is less than 20.
4921 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4923 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4925 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4927 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4928 We prefer signed integers, even for size calculations.
4930 * emacs.c: Don't assume string length fits in 'int'.
4931 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4932 (main): Don't invoke strlen when not needed.
4934 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4935 (XD_DEBUG_MESSAGE): Don't waste a byte.
4937 * callproc.c (getenv_internal_1, getenv_internal)
4939 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4941 * lread.c (invalid_syntax): Omit length argument.
4942 All uses changed. This doesn't fix a bug, but it simplifies the
4943 code away from its former Hollerith-constant appearance, and it's
4944 one less 'int' to worry about when looking at integer-overflow issues.
4945 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4947 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4948 This didn't break anything, but it didn't help either.
4949 It's confusing to put a bogus integer in a place where the actual
4950 value does not matter.
4951 (LIST_END_P): Remove unused macro and its bogus comment.
4952 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4954 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4955 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4957 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4958 We prefer signed types, and the value cannot exceed the EMACS_INT
4959 range anyway (because otherwise the length would not be representable).
4960 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4961 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4962 This avoids a GCC warning when WIDE_EMACS_INT.
4964 * indent.c (sane_tab_width): New function.
4965 (current_column, scan_for_column, Findent_to, position_indentation)
4966 (compute_motion): Use it. This is just for clarity.
4967 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4969 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4971 * lisp.h (lint_assume): New macro.
4972 * composite.c (composition_gstring_put_cache):
4973 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4975 * editfns.c, insdel.c:
4976 Omit unnecessary forward decls, to simplify future changes.
4978 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4980 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4982 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4983 Use much-faster test for byte-length change.
4984 Don't assume string byte-length fits in 'int'.
4985 Check that character arg fits in 'int'.
4986 (mapcar1): Declare byte as byte, for clarity.
4988 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4990 * fns.c (concat): Catch string overflow earlier.
4991 Do not rely on integer wraparound.
4993 * dispextern.h (struct it.overlay_strings_charpos)
4994 (struct it.selective): Now EMACS_INT, not int.
4995 * xdisp.c (forward_to_next_line_start)
4996 (back_to_previous_visible_line_start)
4997 (reseat_at_next_visible_line_start, next_element_from_buffer):
4998 Don't arbitrarily truncate the value of 'selective' to int.
5000 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5002 * composite.c: Don't truncate sizes to 'int'.
5003 (composition_gstring_p, composition_reseat_it)
5004 (composition_adjust_point): Use EMACS_INT, not int.
5005 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5006 not EMACS_UINT, for indexes.
5008 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5010 * buffer.c: Include <verify.h>.
5011 (struct sortvec.priority, struct sortstr.priority):
5012 Now EMACS_INT, not int.
5013 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5014 (struct sortstr.size, record_overlay_string)
5015 (struct sortstrlist.size, struct sortlist.used):
5016 Don't truncate size to int.
5017 (record_overlay_string): Check for size-calculation overflow.
5018 (init_buffer_once): Check at compile-time, not run-time.
5020 2011-06-22 Jim Meyering <meyering@redhat.com>
5022 Don't leak an XBM-image-sized buffer
5023 * image.c (xbm_load): Free the image buffer after using it.
5025 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5028 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5029 that Sun C diagnosed.
5030 * fns.c (secure_hash): Fix pointer signedness issue.
5031 * intervals.c (static_offset_intervals): New function.
5032 (offset_intervals): Use it.
5034 2011-06-21 Leo Liu <sdl.web@gmail.com>
5037 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5040 * fns.c (secure_hash): Rename from crypto_hash_function and change
5041 the first arg to accept symbols.
5042 (Fsecure_hash): New primitive.
5043 (syms_of_fns): New symbols.
5045 2011-06-20 Deniz Dogan <deniz@dogan.se>
5047 * process.c (Fset_process_buffer): Clarify return value in
5050 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5052 * dispnew.c (add_window_display_history): Use BVAR.
5054 * xdisp.c (debug_method_add): Use BVAR.
5055 (check_window_end, dump_glyph_matrix, dump_glyph)
5056 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5058 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5061 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5062 check till after the cache is created in init_frame_faces.
5064 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5066 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5068 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5070 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5071 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5072 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5074 Improve buffer-overflow checking (Bug#8873).
5075 * fileio.c (Finsert_file_contents):
5076 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5077 Remove the old (too-loose) buffer overflow checks.
5078 They weren't needed, since make_gap checks for buffer overflow.
5079 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5080 The old code merely checked for Emacs fixnum overflow, and relied
5081 on undefined (wraparound) behavior. The new code avoids undefined
5082 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5084 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5085 Tune. Don't use wider integers than needed. Don't use alloca.
5086 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5088 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5090 * insdel.c, lisp.h (buffer_overflow): New function.
5091 (insert_from_buffer_1, replace_range, replace_range_2):
5092 * insdel.c (make_gap_larger):
5093 * editfns.c (Finsert_char):
5094 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5096 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5098 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5100 Integer overflow and signedness fixes (Bug#8873).
5102 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5103 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5105 * fileio.c: Don't assume EMACS_INT fits in off_t.
5106 (emacs_lseek): New static function.
5107 (Finsert_file_contents, Fwrite_region): Use it.
5108 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5110 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5112 * fns.c: Don't overflow int when computing a list length.
5113 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5114 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5115 truncation on 64-bit hosts. Check for QUIT every
5116 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5117 faster and is responsive enough.
5118 (Flength): Report an error instead of overflowing an integer.
5119 (Fsafe_length): Return a float if the value is not representable
5120 as a fixnum. This shouldn't happen except in contrived situations.
5121 (Fnthcdr, Fsort): Don't assume list length fits in int.
5122 (Fcopy_sequence): Don't assume vector length fits in int.
5124 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5125 (header_size, word_size): New constants.
5126 (allocate_vectorlike): Don't check size overflow here.
5127 (allocate_vector): Check it here instead, since this is the only
5128 caller of allocate_vectorlike that could cause overflow.
5129 Check that the new vector's length is representable as a fixnum.
5131 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5132 The previous code was bogus. For example, next_almost_prime (32)
5133 returned 39, which is undesirable as it is a multiple of 3; and
5134 next_almost_prime (24) returned 25, which is a multiple of 5 so
5135 why was the code bothering to check for multiples of 7?
5137 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5139 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5141 Variadic C functions now count arguments with ptrdiff_t.
5142 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5143 Back then I didn't know that the Emacs coding style prefers signed int.
5144 Also, in the meantime I found a few more instances where arguments
5145 were being counted with int, which may truncate counts on 64-bit
5146 machines, or EMACS_INT, which may be unnecessarily wide.
5147 * lisp.h (struct Lisp_Subr.function.aMANY)
5148 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5149 Arg counts are now ptrdiff_t, not size_t.
5150 All variadic functions and their callers changed accordingly.
5151 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5152 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5153 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5154 * callint.c (Fcall_interactively): Check arg count for overflow,
5155 to avoid potential buffer overrun. Use signed char, not 'int',
5156 for 'varies' array, so that we needn't bother to check its size
5157 calculation for overflow.
5158 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5159 * eval.c (apply_lambda):
5160 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5161 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5162 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5164 * callint.c (Fcall_interactively): Don't use index var as event count.
5166 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5167 * mem-limits.h (SIZE): Remove; no longer used.
5169 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5171 Remove unnecessary casts.
5172 * xterm.c (x_term_init):
5173 * xfns.c (x_set_border_pixel):
5174 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5175 These aren't needed now that we assume ANSI C.
5177 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5178 It's more likely to cause problems (due to unsigned overflow)
5181 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5183 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5185 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5187 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5189 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5191 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5193 GLYPH_CODE_FACE returns EMACS_INT, not int.
5194 * dispextern.h (merge_faces):
5195 * xfaces.c (merge_faces):
5196 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5197 Don't assume EMACS_INT fits in int.
5199 * character.h (CHAR_VALID_P): Remove unused parameter.
5200 * fontset.c, lisp.h, xdisp.c: All uses changed.
5202 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5204 * fns.c (concat): Minor tuning based on overflow analysis.
5205 This doesn't fix any bugs. Use int to hold character, instead
5206 of constantly refetching from Emacs object. Use XFASTINT, not
5207 XINT, for value known to be a character. Don't bother comparing
5208 a single byte to 0400, as it's always less.
5210 * floatfns.c (Fexpt):
5211 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5213 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5216 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5218 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5219 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5220 incorrectly succeed when S was a string, because 4294967386 was
5221 truncated before it was used.
5223 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5224 Otherwise, an out-of-range integer could cause undefined behavior
5227 * composite.c: Use int, not EMACS_INT, for characters.
5228 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5229 EMACS_INT, for values that are known to be in character range.
5230 This doesn't fix any bugs but is the usual style inside Emacs and
5231 may generate better code on 32-bit machines.
5233 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5234 This is for reasons similar to the recent CHAR_STRING fix.
5235 * charset.c (Fencode_char): Check that character arg is actually
5236 a character. Pass an int to ENCODE_CHAR.
5237 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5238 wider than 'int', as a compile-time check to prevent future regressions
5241 * character.c (char_string): Remove unnecessary casts.
5243 Make sure a 64-bit char is never passed to CHAR_STRING.
5244 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5245 by silently ignoring the top 32 bits, allowing some values
5246 that were far too large to be valid characters.
5247 * character.h: Include <verify.h>.
5248 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5249 arguments are no wider than unsigned, as a compile-time check
5250 to prevent future regressions in this area.
5252 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5253 (Fsubst_char_in_region):
5255 * xdisp.c (decode_mode_spec_coding):
5256 Adjust to CHAR_STRING's new requirement.
5257 * editfns.c (Finsert_char, Fsubst_char_in_region):
5258 * fns.c (concat): Check that character args are actually
5259 characters. Without this test, these functions did the wrong
5260 thing with wildly out-of-range values on 64-bit hosts.
5262 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5263 These casts should not be needed on 32-bit hosts, either.
5264 * keyboard.c (read_char):
5265 * lread.c (Fload): Remove casts to unsigned.
5267 * lisp.h (UNSIGNED_CMP): New macro.
5268 This fixes comparison bugs on 64-bit hosts.
5269 (ASCII_CHAR_P): Use it.
5270 * casefiddle.c (casify_object):
5271 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5272 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5273 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5274 * dispextern.h (FACE_FROM_ID):
5275 * keyboard.c (read_char): Use UNSIGNED_CMP.
5277 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5278 not to EMACS_INT, to avoid GCC warning.
5280 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5282 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5283 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5284 isn't needed on 32-bit machines.
5286 * buffer.c (Fgenerate_new_buffer_name):
5287 Use EMACS_INT for count, not int.
5288 (advance_to_char_boundary): Return EMACS_INT, not int.
5290 * data.c (Qcompiled_function): Now static.
5292 * window.c (window_body_lines): Now static.
5294 * image.c (gif_load): Rename local to avoid shadowing.
5296 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5297 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5298 * alloc.c (make_save_value): Integer argument is now of type
5300 (mark_object): Use ptrdiff_t, not int.
5301 * lisp.h (pD): New macro.
5302 * print.c (print_object): Use it.
5304 * alloc.c: Use EMACS_INT, not int, to count objects.
5305 (total_conses, total_markers, total_symbols, total_vector_size)
5306 (total_free_conses, total_free_markers, total_free_symbols)
5307 (total_free_floats, total_floats, total_free_intervals)
5308 (total_intervals, total_strings, total_free_strings):
5309 Now EMACS_INT, not int. All uses changed.
5310 (Fgarbage_collect): Compute overall total using a double, so that
5311 integer overflow is less likely to be a problem. Check for overflow
5312 when converting back to an integer.
5313 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5314 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5315 These were 'int' variables that could overflow on 64-bit hosts;
5316 they were never used, so remove them instead of repairing them.
5317 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5318 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5319 Previously, this ceilinged at INT_MAX, but that doesn't work on
5321 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5323 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5324 (allocate_vectorlike): Check for ptrdiff_t overflow.
5325 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5326 when a (possibly-narrower) signed value would do just as well.
5327 We prefer using signed arithmetic, to avoid comparison confusion.
5329 * alloc.c: Catch some string size overflows that we were missing.
5330 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5331 for convenience in STRING_BYTES_MAX.
5332 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5333 The definition here is exact; the one in lisp.h was approximate.
5334 (allocate_string_data): Check for string overflow. This catches
5335 some instances we weren't catching before. Also, it catches
5336 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5337 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5338 and ptrdiff_t and EMACS_INT are both 64 bits.
5340 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5341 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5342 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5344 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5346 * alloc.c (Fmake_string): Check for out-of-range init.
5348 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5350 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5352 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5354 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5355 xg_get_default_scrollbar_width.
5357 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5358 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5359 (style_changed_cb): Call update_theme_scrollbar_width and call
5360 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5361 all frames (Bug#8505).
5362 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5363 Call gtk_window_set_resizable if HAVE_GTK3.
5364 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5365 and height if HAVE_GTK3 (Bug#8505).
5366 (scroll_bar_width_for_theme): New variable.
5367 (update_theme_scrollbar_width): New function.
5368 (xg_get_default_scrollbar_width): Move code to
5369 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5370 (xg_initialize): Call update_theme_scrollbar_width.
5372 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5374 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5376 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5378 * frame.c (make_frame): Call other_buffer_safely instead of
5381 * window.c (temp_output_buffer_show): Call display_buffer with
5382 second argument Vtemp_buffer_show_specifiers and reset latter
5383 immediately after the call.
5384 (Vtemp_buffer_show_specifiers): New variable.
5385 (auto_window_vscroll_p, next_screen_context_lines)
5386 (Vscroll_preserve_screen_position): Remove leading asterisks from
5389 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5391 Fix minor problems found by GCC 4.6.0 static checking.
5392 * buffer.c (Qclone_number): Remove for now, as it's unused.
5393 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5394 (record_buffer): Remove unused local.
5395 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5396 (set_frame_buffer_list): Remove; unused.
5397 * frame.h (other_visible_frames): Remove decl.
5398 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5399 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5400 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5402 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5403 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5404 Define only if HAVE_GPM.
5405 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5406 (update_hints_inhibit): Remove; never set. All uses removed.
5407 * widgetprv.h (emacsFrameClassRec): Remove decl.
5408 * window.c (delete_deletable_window): Now returns void, since it
5409 wasn't returning anything.
5410 (compare_window_configurations): Remove unused locals.
5411 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5412 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5413 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5414 the same widths as pointers. This follows up on the 2011-05-06 patch.
5415 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5416 * xterm.h: Likewise.
5417 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5419 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5421 * makefile.w32-in: Update dependencies.
5422 (LISP_H): Add lib/intprops.h.
5424 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5426 * image.c (gif_load): Add animation frame delay to the metadata.
5427 (syms_of_image): Use DEFSYM. New symbol `delay'.
5429 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5431 * window.c (delete_deletable_window): Re-add.
5432 (Fset_window_configuration): Rewrite to handle dead buffers and
5433 consequently deletable windows.
5434 (window_tree, Fwindow_tree): Remove. Supply functionality in
5436 (compare_window_configurations): Simplify code.
5438 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5440 * image.c (imagemagick_load_image): Fix type mismatch.
5441 (Fimagemagick_types): Likewise.
5443 * window.h (replace_buffer_in_windows): Declare.
5445 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5447 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5448 Qclone_number. Remove external declaration of Qdelete_window.
5449 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5451 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5452 Run Qbuffer_list_update_hook if allowed.
5453 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5454 buffer list implementation.
5455 (other_buffer_safely): New function.
5456 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5457 calls to replace_buffer_in_windows and
5458 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5460 (record_buffer): Inhibit quitting and rewrite using quittable
5461 functions. Run Qbuffer_list_update_hook if allowed.
5462 (Frecord_buffer, Funrecord_buffer): New functions.
5463 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5464 Move switch-to-buffer to window.el.
5465 (bury-buffer): Move to window.el.
5466 (Vbuffer_list_update_hook): New variable.
5468 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5471 * window.h (resize_frame_windows): Move up in code.
5472 (Fwindow_frame): Remove EXFUN.
5473 (replace_buffer_in_all_windows): Remove prototype.
5474 (replace_buffer_in_windows_safely): Add prototype.
5476 * window.c: Declare Qdelete_window static again. Move down
5477 declaration of select_count.
5478 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5479 (Fother_window): Move to window.el.
5480 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5481 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5482 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5484 (replace_buffer_in_windows): Implement by calling
5485 Qreplace_buffer_in_windows.
5486 (replace_buffer_in_all_windows): Remove with some functionality
5487 moved into replace_buffer_in_windows_safely.
5488 (replace_buffer_in_windows_safely): New function.
5489 (select_window_norecord, select_frame_norecord): Move in front
5490 of run_window_configuration_change_hook. Remove now obsolete
5492 (Fset_window_buffer): Rewrite doc-string.
5493 Call Qrecord_window_buffer.
5494 (keys_of_window): Move binding for other-window to window.el.
5496 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5498 * dispextern.h (struct image): Replace data member, whose int_val
5499 and ptr_val fields were not used by anything, with a single
5502 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5503 (gif_clear_image, gif_load, imagemagick_load_image)
5504 (gs_clear_image, gs_load): Callers changed.
5506 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5508 * buffer.h: Include <time.h>, for time_t.
5509 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5511 Fix minor problems found by static checking.
5513 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5515 Make identifiers static if they are not used in other modules.
5516 * data.c (Qcompiled_function, Qframe, Qvector):
5517 * image.c (QimageMagick, Qsvg):
5518 * minibuf.c (Qmetadata):
5519 * window.c (resize_window_check, resize_root_window): Now static.
5520 * window.h (resize_window_check, resize_root_window): Remove decls.
5522 * window.c (window_deletion_count, delete_deletable_window):
5524 (window_body_lines): Now static.
5525 (Fdelete_other_windows_internal): Mark vars as initialized.
5526 Make sure 'resize_failed' is initialized.
5527 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5528 (resize_window_apply): Remove unused local.
5529 * window.h (delete_deletable_window): Remove decl.
5531 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5532 (imagemagick_load_image): Fix pointer signedness problem by changing
5533 last arg from unsigned char * to char *. All uses changed.
5534 Also, fix a local for similar reasons.
5535 Remove unused locals. Remove locals to avoid shadowing.
5536 (fn_rsvg_handle_free): Remove; unused.
5537 (svg_load, svg_load_image): Fix pointer signedness problem.
5538 (imagemagick_load_image): Don't use garbage pointer image_wand.
5540 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5542 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5544 * image.c (gif_load): Fix omitted cast error introduced by
5547 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5549 * window.h (resize_proportionally, orig_total_lines)
5550 (orig_top_line): Remove from window structure.
5551 (set_window_height, set_window_width, change_window_heights)
5552 (Fdelete_window): Remove prototypes.
5553 (resize_frame_windows): Remove duplicate declaration.
5555 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5557 * window.h (resize_frame_windows, resize_window_check)
5558 (delete_deletable_window, resize_root_window)
5559 (resize_frame_windows): Declare prototypes.
5561 * window.c (resize_window_apply): Make definition be "static" to
5562 match the prototype.
5564 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5566 * window.c: Remove declarations of Qwindow_size_fixed,
5567 window_min_size_1, window_min_size_2, window_min_size,
5568 size_window, window_fixed_size_p, enlarge_window, delete_window.
5569 Remove static from declaration of Qdelete_window, it's
5570 temporarily needed by Fbury_buffer.
5571 (replace_window): Don't assign orig_top_line and
5573 (Fdelete_window, delete_window): Remove. Window deletion is
5574 handled by window.el.
5575 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5576 Replace Fdelete_window calls with calls to Qdelete_window.
5577 (Fdelete_other_windows): Remove. Deleting other windows is
5578 handled by window.el.
5579 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5580 handled in window.el.
5581 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5582 Window minimum sizes are handled in window.el.
5583 (shrink_windows, size_window, set_window_height)
5584 (set_window_width, change_window_heights, window_height)
5585 (window_width, CURBEG, CURSIZE, enlarge_window)
5586 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5587 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5588 handled in window.el.
5589 (make_dummy_parent): Rename to make_parent_window and give it a
5590 second argument horflag.
5591 (make_window): Don't set resize_proportionally any more.
5592 (Fsplit_window): Remove. Windows are split in window.el.
5593 (save_restore_action, save_restore_orig_size)
5594 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5595 Resize mini windows in window.el.
5596 (grow_mini_window, shrink_mini_window): Implement by calling
5597 Qresize_root_window_vertically, resize_window_check and
5598 resize_window_apply.
5599 (saved_window, Fset_window_configuration, save_window_save):
5600 Do not handle orig_top_line, orig_total_lines, and
5601 resize_proportionally.
5602 (window_min_height, window_min_width): Move to window.el.
5603 (keys_of_window): Move bindings for delete-other-windows,
5604 split-window, delete-window and enlarge-window to window.el.
5606 * buffer.c: Temporarily extern Qdelete_window.
5607 (Fbury_buffer): Temporarily call Qdelete_window instead of
5608 Fdelete_window (Fbury_buffer will move to window.el soon).
5610 * frame.c (set_menu_bar_lines_1): Remove code handling
5611 orig_top_line and orig_total_lines.
5613 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5614 set_window_height but set heights directly.
5615 (change_frame_size_1): Use resize_frame_windows.
5617 * xdisp.c (init_xdisp): Don't use set_window_height but set
5620 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5621 Use resize_frame_windows instead of change_window_heights and run
5622 run_window_configuration_change_hook.
5624 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5625 instead of change_window_heights and run
5626 run_window_configuration_change_hook.
5628 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5630 * window.c (replace_window): Rename second argument REPLACEMENT to
5631 NEW. New third argument SETFLAG. Rewrite.
5632 (delete_window, make_dummy_parent): Call replace_window with
5634 (window_list_1): Move down in code.
5635 (run_window_configuration_change_hook): Move set_buffer part
5636 before select_frame_norecord part in order to unwind correctly.
5637 Rename count1 to count.
5638 (recombine_windows, delete_deletable_window, resize_root_window)
5639 (Fdelete_other_windows_internal)
5640 (Frun_window_configuration_change_hook, make_parent_window)
5641 (resize_window_check, resize_window_apply, Fresize_window_apply)
5642 (resize_frame_windows, Fsplit_window_internal)
5643 (Fdelete_window_internal, Fresize_mini_window_internal):
5645 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5647 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5649 * window.h (window): Add some new members to window structure -
5650 normal_lines, normal_cols, new_total, new_normal, clone_number,
5651 splits, nest, prev_buffers, next_buffers.
5652 (WINDOW_TOTAL_SIZE): Move here from window.c.
5653 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5655 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5657 (make_dummy_parent): Set new members of windows structure.
5658 (make_window): Move down in code. Handle new members of window
5660 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5661 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5662 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5663 (Fset_window_prev_buffers, Fwindow_next_buffers)
5664 (Fset_window_next_buffers, Fset_window_clone_number):
5666 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5667 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5669 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5670 Argument WINDOW can be now internal window too.
5671 (Fwindow_use_time): Move up in code.
5672 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5674 (Fset_window_configuration, saved_window)
5675 (Fcurrent_window_configuration, save_window_save): Handle new
5676 members of window structure.
5677 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5678 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5679 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5680 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5681 Qget_mru_window, Qresize_root_window,
5682 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5683 Qauto_buffer_name; staticpro them.
5685 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5687 * window.c (Fwindow_total_size, Fwindow_left_column)
5688 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5689 (Fwindow_list_1): New functions.
5690 (window_box_text_cols): Replace with window_body_cols.
5691 (Fwindow_width, Fscroll_left, Fscroll_right):
5692 Use window_body_cols instead of window_box_text_cols.
5693 (delete_window, Fset_window_configuration):
5694 Call delete_all_subwindows with window as argument.
5695 (delete_all_subwindows): Take a window as argument and not a
5697 (window_loop): Remove handling of GET_LRU_WINDOW and
5699 (Fget_lru_window, Fget_largest_window): Move to window.el.
5701 * window.h: Extern window_body_cols instead of
5702 window_box_text_cols. delete_all_subwindows now takes a
5703 Lisp_Object as argument.
5705 * indent.c (compute_motion, Fcompute_motion):
5706 Use window_body_cols instead of window_box_text_cols.
5708 * frame.c (delete_frame): Call delete_all_subwindows with root
5711 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5713 * fns.c (Fputhash): Document return value.
5715 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5717 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5719 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5721 Cons<->int and similar integer overflow fixes (Bug#8794).
5723 Check for overflow when converting integer to cons and back.
5724 * charset.c (Fdefine_charset_internal, Fdecode_char):
5725 Use cons_to_unsigned to catch overflow.
5726 (Fencode_char): Use INTEGER_TO_CONS.
5727 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5728 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5729 * data.c (long_to_cons, cons_to_long): Remove.
5730 (cons_to_unsigned, cons_to_signed): New functions.
5731 These signal an error for invalid or out-of-range values.
5732 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5733 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5734 * font.c (Ffont_variation_glyphs):
5735 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5736 * lisp.h: Include <intprops.h>.
5737 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5738 (cons_to_signed, cons_to_unsigned): New decls.
5739 (long_to_cons, cons_to_long): Remove decls.
5740 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5741 (Fprimitive_undo): Use CONS_TO_INTEGER.
5742 * xfns.c (Fx_window_property): Likewise.
5743 * xselect.c: Include <limits.h>.
5744 (x_own_selection, selection_data_to_lisp_data):
5745 Use INTEGER_TO_CONS.
5746 (x_handle_selection_request, x_handle_selection_clear)
5747 (x_get_foreign_selection, Fx_disown_selection_internal)
5748 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5749 (lisp_data_to_selection_data): Use cons_to_unsigned.
5750 (x_fill_property_data): Use cons_to_signed.
5751 Report values out of range.
5753 Check for buffer and string overflow more precisely.
5754 * buffer.h (BUF_BYTES_MAX): New macro.
5755 * lisp.h (STRING_BYTES_MAX): New macro.
5756 * alloc.c (Fmake_string):
5757 * character.c (string_escape_byte8):
5758 * coding.c (coding_alloc_by_realloc):
5759 * doprnt.c (doprnt):
5760 * editfns.c (Fformat):
5762 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5763 since they may not be the same number.
5764 * editfns.c (Finsert_char):
5765 * fileio.c (Finsert_file_contents):
5766 Likewise for BUF_BYTES_MAX.
5768 * image.c: Use ptrdiff_t, not int, for sizes.
5769 (slurp_file): Switch from int to ptrdiff_t.
5771 (slurp_file): Check that file size fits in both size_t (for
5772 malloc) and ptrdiff_t (for sanity and safety).
5774 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5775 if b->modtime has its maximal value.
5777 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5779 Don't assume time_t can fit into int.
5780 * buffer.h (struct buffer.modtime): Now time_t, not int.
5781 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5782 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5784 Minor fixes for signed vs unsigned integers.
5785 * character.h (MAYBE_UNIFY_CHAR):
5786 * charset.c (maybe_unify_char):
5787 * keyboard.c (read_char, reorder_modifiers):
5788 XINT -> XFASTINT, since the integer must be nonnegative.
5789 * ftfont.c (ftfont_spec_pattern):
5790 * keymap.c (access_keymap, silly_event_symbol_error):
5791 XUINT -> XFASTINT, since the integer must be nonnegative.
5792 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5793 since it makes no difference and we prefer signed.
5794 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5795 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5798 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5800 * window.h (Fwindow_frame): Declare.
5802 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5804 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5805 (SPARE_MEMORY): Always define.
5806 (LARGE_REQUEST): Remove.
5807 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5809 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5811 * lisp.h: Move EXFUNS for Fframe_root_window,
5812 Fframe_first_window and Fset_frame_selected_window to window.h.
5814 * window.h: Move EXFUNS for Fframe_root_window,
5815 Fframe_first_window and Fset_frame_selected_window here from
5818 * frame.c (Fwindow_frame, Fframe_first_window)
5819 (Fframe_root_window, Fframe_selected_window)
5820 (Fset_frame_selected_window): Move to window.c.
5821 (Factive_minibuffer_window): Move to minibuf.c.
5822 (Fother_visible_frames_p): New function.
5824 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5826 * window.c (decode_window, decode_any_window): Move up in code.
5827 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5828 (inhibit_frame_unsplittable): Remove unused variable.
5829 (Fwindow_buffer): Move up and rewrite doc-string.
5830 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5831 (Fwindow_prev): New functions.
5832 (Fwindow_frame): Move here from frame.c. Accept any window as
5834 (Fframe_root_window, Fframe_first_window)
5835 (Fframe_selected_window): Move here from frame.c. Accept frame
5836 or arbitrary window as argument. Update doc-strings.
5837 (Fminibuffer_window): Move up in code.
5838 (Fwindow_minibuffer_p): Move up in code and simplify.
5839 (Fset_frame_selected_window): Move here from frame.c.
5841 (Fselected_window, select_window, Fselect_window): Move up in
5842 code. Minor doc-string fixes.
5844 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5846 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5847 Do not assume that spare memory exists; that assumption is valid
5848 only if SYSTEM_MALLOC.
5849 (LARGE_REQUEST): New macro, so that the issue of large requests
5850 is separated from the issue of spare memory.
5852 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5854 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5857 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5859 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5862 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5864 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5866 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5868 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5869 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5871 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5873 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5875 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5877 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5878 (x_clipboard_manager_save): Add return value.
5879 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5881 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5882 Obey Vx_select_enable_clipboard_manager. Catch errors in
5883 x_clipboard_manager_save (Bug#8779).
5884 (Vx_select_enable_clipboard_manager): New variable.
5885 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5887 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5889 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5891 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5893 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5894 in the current matrix if keep_current_p is non-zero.
5896 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5898 * bidi.c (bidi_level_of_next_char): Fix last change.
5900 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5902 Support bidi reordering of text covered by display properties.
5904 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5905 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5906 (bidi_cache_search, bidi_cache_iterator_state)
5907 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5908 (bidi_level_of_next_char, bidi_move_to_visually_next):
5909 Support character positions inside a run of characters covered by a
5911 (bidi_paragraph_init, bidi_resolve_explicit_1)
5912 (bidi_level_of_next_char): Call bidi_fetch_char and
5913 bidi_fetch_char_advance instead of FETCH_CHAR and
5915 (bidi_init_it): Initialize new members.
5916 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5918 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5919 instead of using explicit *_CHAR codes.
5920 (bidi_resolve_explicit, bidi_resolve_weak):
5921 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5922 bidirectional text is supported only in multibyte buffers.
5923 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5924 it to initialize the frame_window_p member of struct bidi_it.
5925 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5926 (bidi_resolve_explicit, bidi_resolve_weak)
5927 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5928 bidi_it->nchars is non-positive.
5929 (bidi_level_of_next_char): Don't try to lookup the cache for the
5930 next/previous character if nothing is cached there yet, or if we
5931 were just reseat()'ed to a new position.
5933 * xdisp.c (set_cursor_from_row): Set start and stop points
5934 according to the row's direction when priming the loop that looks
5935 for the glyph on which to display cursor.
5936 (single_display_spec_intangible_p): Function deleted.
5937 (display_prop_intangible_p): Reimplement to call
5938 handle_display_spec instead of single_display_spec_intangible_p.
5939 Accept 3 additional arguments needed by handle_display_spec.
5940 This fixes incorrect cursor motion across display property with complex
5941 values: lists, `(when COND...)' forms, etc.
5942 (single_display_spec_string_p): Support property values that are
5943 lists with the argument STRING its top-level element.
5944 (display_prop_string_p): Fix the condition for processing a
5945 property that is a list to be consistent with handle_display_spec.
5946 (handle_display_spec): New function, refactored from the
5947 last portion of handle_display_prop.
5948 (compute_display_string_pos): Accept additional argument
5949 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5950 value of a `display' property is a "replacing spec".
5951 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5952 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5953 the display property, but just return a value indicating whether
5954 the display property will replace the characters it covers.
5955 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5956 frame_window_p members of struct bidi_it.
5957 (compute_display_string_pos, compute_display_string_end):
5959 (push_it): Accept second argument POSITION, where pop_it should
5960 jump to continue iteration.
5961 (reseat_1): Initialize bidi_it.disp_pos.
5963 * keyboard.c (adjust_point_for_property): Adjust the call to
5964 display_prop_intangible_p to its new signature.
5966 * dispextern.h (struct bidi_it): New member frame_window_p.
5967 (bidi_init_it): Update prototypes.
5968 (display_prop_intangible_p): Update prototype.
5969 (compute_display_string_pos, compute_display_string_end):
5971 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5974 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5976 Malloc failure behavior now depends on size of allocation.
5977 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5978 * lisp.h: Change signatures accordingly.
5979 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5980 All callers changed. (Bug#8762)
5982 * gnutls.c: Use Emacs's memory allocators.
5983 Without this change, the gnutls library would invoke malloc etc.
5984 directly, which causes problems on non-SYNC_INPUT hosts, and which
5985 runs afoul of improving memory_full behavior. (Bug#8761)
5986 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5987 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5988 xfree instead of the default malloc, realloc, free.
5989 (Fgnutls_boot): No need to check for memory allocation failure,
5990 since xmalloc does that for us.
5992 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5993 * category.c (hash_get_category_set):
5994 * ccl.c (ccl_driver):
5995 * charset.c (Fdefine_charset_internal):
5996 * charset.h (struct charset.hash_index):
5997 * composite.c (get_composition_id, gstring_lookup_cache)
5998 (composition_gstring_put_cache):
5999 * composite.h (struct composition.hash_index):
6000 * dispextern.h (struct image.hash):
6001 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6002 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6003 (hashfn_equal, hashfn_user_defined, make_hash_table)
6004 (maybe_resize_hash_table, hash_lookup, hash_put)
6005 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6006 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6007 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6008 * image.c (make_image, search_image_cache, lookup_image)
6009 (xpm_put_color_table_h):
6010 * lisp.h (struct Lisp_Hash_Table):
6011 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6012 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6013 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6014 * alloc.c (allocate_vectorlike):
6015 Check for overflow in vector size calculations.
6016 * ccl.c (ccl_driver):
6017 Check for overflow when converting EMACS_INT to int.
6018 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6019 need to be updated by these changes.
6020 * fns.c (make_hash_table, maybe_resize_hash_table):
6021 Check for integer overflow with large hash tables.
6022 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6023 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6024 (SXHASH_REDUCE): New macro.
6025 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6026 Use it instead of discarding useful hash info with large hash values.
6027 (sxhash_float): New function.
6028 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6029 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6030 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6031 Rewrite to use FIXNUM_BITS, as this simplifies things.
6032 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6033 Adjust signatures to match updated version of code.
6034 (consing_since_gc): Now EMACS_INT, since a single hash table can
6035 use more than INT_MAX bytes.
6037 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6039 Make it possible to build with GCC-4.6+ -O2 -flto.
6041 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6043 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6045 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6046 Call minibuffer-inactive-mode.
6048 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6050 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6051 Update dependencies.
6053 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6055 * data.c (init_data): Remove code for UTS, this system is not
6058 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6060 Don't force ./temacs to start in terminal mode.
6062 * frame.c (make_initial_frame): Initialize faces in all cases, not
6063 only when CANNOT_DUMP is defined.
6064 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6066 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6068 * dispnew.c (add_window_display_history): Use const for the string
6069 pointer. Remove declaration, not needed.
6071 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6073 Use 'inline', not 'INLINE'.
6074 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6075 * alloc.c, fontset.c (INLINE): Remove.
6076 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6077 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6078 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6079 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6080 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6082 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6084 Make it possible to run ./temacs.
6086 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6087 syms_of_callproc does the same thing. Remove test for
6088 "initialized", do it in the caller.
6089 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6091 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6093 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6094 (read_minibuf): Use get_minibuffer.
6095 (syms_of_minibuf): Use DEFSYM.
6096 (Qmetadata): New var.
6097 * data.c (Qbuffer): Don't make it static.
6098 (syms_of_data): Use DEFSYM.
6100 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6102 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6103 (CCL_CODE_MIN): New macro.
6105 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6107 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6109 * eval.c (Qdebug): Now static.
6110 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6111 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6112 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6114 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6116 * image.c: Various fixes to ImageMagick code comments.
6117 (Fimagemagick_types): Doc fix.
6119 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6121 Minor fixes prompted by GCC 4.6.0 warnings.
6123 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6125 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6126 (x_clipboard_manager_save_all): Move extern decl to ...
6127 * xterm.h: ... here, so that it can be checked for consistency.
6129 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6131 * xselect.c (x_clipboard_manager_save_frame)
6132 (x_clipboard_manager_save_all): New functions.
6133 (Fx_clipboard_manager_save): Lisp function deleted.
6135 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6136 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6138 * xterm.h: Update prototype.
6140 2011-05-28 William Xu <william.xwl@gmail.com>
6142 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6145 2011-05-28 Jim Meyering <meyering@redhat.com>
6147 Avoid a sign-extension bug in crypto_hash_function.
6148 * fns.c (to_uchar): Define.
6149 (crypto_hash_function): Use it to convert some newly-signed
6150 variables to unsigned, to avoid sign-extension bugs. For example,
6151 without this change, (md5 "truc") would evaluate to
6152 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6153 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6154 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6156 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6158 Integer overflow fixes.
6160 * dbusbind.c: Serial number integer overflow fixes.
6161 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6162 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6163 to hold a serial number that is too large for a fixnum.
6164 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6165 Check for serial numbers out of range. Decode any serial number
6166 that was so large that it became a float. (Bug#8722)
6168 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6169 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6170 Use XFASTINT rather than XUINT when numbers are nonnegative.
6171 (xd_append_arg, Fdbus_method_return_internal):
6172 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6173 arguments, check that Lisp number is nonnegative, rather than
6174 silently wrapping negative numbers around. (Bug#8722)
6175 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6178 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6180 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6182 ccl: add integer overflow checks
6183 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6184 (IN_INT_RANGE): New macros.
6185 (ccl_driver): Use them to check for integer overflow when
6186 decoding a CCL program. Many of the new checks are whether XINT (x)
6187 fits in int; it doesn't always, on 64-bit hosts. The new version
6188 doesn't catch all possible integer overflows, but it's an
6189 improvement. (Bug#8719)
6191 * alloc.c (make_event_array): Use XINT, not XUINT.
6192 There's no need for unsigned here.
6194 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6195 This follows up to the 2011-05-06 change that substituted uintptr_t
6196 for EMACS_INT. This case wasn't caught back then.
6198 Rework Fformat to avoid integer overflow issues.
6199 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6200 now (part of C89). Include <verify.h>.
6201 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6202 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6203 (Fformat): Avoid the prepass trying to compute sizes; it was only
6204 approximate and thus did not catch overflow reliably. Instead, walk
6205 through the format just once, formatting and computing sizes as we go,
6206 checking for integer overflow at every step, and allocating a larger
6207 buffer as needed. Keep track separately whether the format is
6208 multibyte. Keep only the most-recently calculated precision, rather
6209 than them all. Record whether each argument has been converted to
6210 string. Use EMACS_INT, not int, for byte and char and arg counts.
6211 Support field widths and precisions larger than INT_MAX. Avoid
6212 sprintf's undefined behavior with conversion specifications such as %#d
6213 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6214 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6215 formatting out-of-range floating point numbers with int
6218 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6220 * data.c: Avoid integer truncation in expressions involving floats.
6221 * data.c: Include <intprops.h>.
6222 (arith_driver): When there's an integer overflow in an expression
6223 involving floating point, convert the integers to floating point
6224 so that the resulting value does not suffer from catastrophic
6225 integer truncation. For example, on a 64-bit host (* 4
6226 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6227 Do not rely on undefined behavior after integer overflow.
6229 merge count_size_as_multibyte, parse_str_to_multibyte
6230 * character.c, character.h (count_size_as_multibyte):
6231 Rename from parse_str_to_multibyte; all uses changed.
6232 Check for integer overflow.
6233 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6234 since it's now a duplicate of the other. This is more of
6235 a character than a buffer op, so better that it's in character.c.
6236 * fns.c, print.c: Adjust to above changes.
6238 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6240 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6242 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6244 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6245 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6246 (x_clipboard_manager_save): Now static.
6247 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6249 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6250 (crypto_hash_function): Now static.
6251 Fix pointer signedness problems. Avoid unnecessary initializations.
6253 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6255 * termhooks.h (Vselection_alist): Make it terminal-local.
6257 * terminal.c (create_terminal): Initialize it.
6259 * xselect.c: Support for clipboard managers.
6260 (Vselection_alist): Move to termhooks.h as terminal-local var.
6261 (LOCAL_SELECTION): New macro.
6262 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6263 (symbol_to_x_atom): Remove gratuitous arg.
6264 (x_handle_selection_request, lisp_data_to_selection_data)
6265 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6266 (x_own_selection, x_get_local_selection, x_convert_selection):
6267 New arg, specifying work frame. Use terminal-local Vselection_alist.
6268 (some_frame_on_display): Delete unused function.
6269 (Fx_own_selection_internal, Fx_get_selection_internal)
6270 (Fx_disown_selection_internal, Fx_selection_owner_p)
6271 (Fx_selection_exists_p): New optional frame arg.
6272 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6273 (x_handle_selection_clear): Don't treat other terminals with the
6274 same keyboard specially. Use the terminal-local Vselection_alist.
6275 (x_clear_frame_selections): Use Frun_hook_with_args.
6277 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6279 * xterm.h: Add support for those atoms.
6281 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6283 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6284 (converted_selections, conversion_fail_tag): New global variables.
6285 (x_selection_request_lisp_error): Free the above.
6286 (x_get_local_selection): Remove unnecessary code.
6287 (x_reply_selection_request): Args changed; handle arbitrary array
6288 of converted selections stored in converted_selections.
6289 Separate the XChangeProperty and SelectionNotify steps.
6290 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6291 (x_convert_selection): New function.
6292 (x_handle_selection_event): Simplify.
6293 (x_get_foreign_selection): Don't ignore incoming requests while
6294 waiting for an answer; this will fail when we implement
6295 SAVE_TARGETS, and seems unnecessary anyway.
6296 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6297 (Vx_sent_selection_functions): Doc fix.
6299 2011-05-26 Leo Liu <sdl.web@gmail.com>
6301 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6303 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6305 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6307 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6308 for fringe update if it has periodic bitmap.
6309 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6310 and fringe_bitmap_periodic_p.
6312 * fringe.c (get_fringe_bitmap_data): New function.
6313 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6314 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6315 row. Mark glyph row for fringe update if periodicity changed.
6317 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6318 for fringe update unless it has periodic bitmap.
6320 2011-05-25 Kenichi Handa <handa@m17n.org>
6322 * xdisp.c (get_next_display_element): Set correct it->face_id for
6323 a static composition.
6325 2011-05-24 Leo Liu <sdl.web@gmail.com>
6328 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6330 * fns.c (crypto_hash_function, Fsha1): New function.
6331 (Fmd5): Use crypto_hash_function.
6332 (syms_of_fns): Add Ssha1.
6334 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6336 * gnutls.c: Remove unused macros.
6337 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6338 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6339 Remove macros that are defined and never used.
6340 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6342 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6344 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6345 (Fx_get_selection_internal): Minor cleanup.
6346 (Fx_own_selection_internal): Rename arguments for consistency with
6349 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6351 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6353 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6355 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6357 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6359 * dispnew.c (scrolling_window): Don't exclude the case that the
6360 last enabled row in the desired matrix touches the bottom boundary.
6362 2011-05-21 Glenn Morris <rgm@gnu.org>
6364 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6365 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6366 and add some more files.
6368 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6370 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6371 report_file_error introduced by the change from 2011-05-07.
6373 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6375 * systime.h (Time): Define only if emacs is defined.
6376 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6377 where the include path doesn't have X11/X.h by default. See
6378 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6380 2011-05-20 Kenichi Handa <handa@m17n.org>
6382 * composite.c (find_automatic_composition): Fix previous change.
6384 2011-05-20 Glenn Morris <rgm@gnu.org>
6386 * lisp.mk: New file, split from Makefile.in.
6387 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6388 (shortlisp): Remove.
6389 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6391 2011-05-19 Glenn Morris <rgm@gnu.org>
6393 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6394 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6395 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6396 (lisp): Set the order to that of loadup.el.
6397 (shortlisp): Make it a copy of $lisp.
6398 (SOME_MACHINE_LISP): Remove.
6399 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6400 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6402 2011-05-18 Kenichi Handa <handa@m17n.org>
6404 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6405 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6406 (find_automatic_composition): Mostly rewrite for efficiency.
6408 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6410 * makefile.w32-in: Update dependencies.
6412 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6414 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6415 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6417 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6419 Fix some integer overflow issues, such as string length overflow.
6421 * insdel.c (count_size_as_multibyte): Check for string overflow.
6423 * character.c (lisp_string_width): Check for string overflow.
6424 Use EMACS_INT, not int, for string indexes and lengths; in
6425 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6426 the resulting string length overflows an EMACS_INT; instead,
6427 report a string overflow if no precision given. When checking for
6428 precision exhaustion, use a check that cannot possibly have
6429 integer overflow. (Bug#8675)
6430 * character.h (lisp_string_width): Adjust to new signature.
6432 * alloc.c (string_overflow): New function.
6433 (Fmake_string): Use it. This doesn't change behavior, but saves
6434 a few bytes and will simplify future changes.
6435 * character.c (string_escape_byte8): Likewise.
6436 * lisp.h (string_overflow): New decl.
6438 Fixups, following up to the user-interface timestamp change.
6439 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6440 for UI timestamps, instead of unsigned long.
6441 * msdos.c (mouse_get_pos): Likewise.
6442 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6443 * w32gui.h (Time): Define by including "systime.h" rather than by
6444 declaring it ourselves. (Bug#8664)
6446 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6447 * image.c (clear_image_cache): Likewise.
6449 * term.c (term_mouse_position): Don't assume time_t wraparound.
6451 Be more systematic about user-interface timestamps.
6452 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6453 and sometimes 'EMACS_UINT', to represent these timestamps.
6454 This change causes it to use 'Time' uniformly, as that's what X uses.
6455 This makes the code easier to follow, and makes it easier to catch
6456 integer overflow bugs such as Bug#8664.
6457 * frame.c (Fmouse_position, Fmouse_pixel_position):
6458 Use Time, not unsigned long, for user-interface timestamps.
6459 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6460 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6461 * keyboard.h (last_event_timestamp): Likewise.
6462 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6463 * menu.h (xmenu_show): Likewise.
6464 * term.c (term_mouse_position): Likewise.
6465 * termhooks.h (struct input_event.timestamp): Likewise.
6466 (struct terminal.mouse_position_hook): Likewise.
6467 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6468 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6469 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6470 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6472 * menu.h, termhooks.h: Include "systime.h", for Time.
6474 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6475 Don't assume that the difference between two unsigned long values
6476 can fit into an integer. At this point, we know button_down_time
6477 <= event->timestamp, so the difference must be nonnegative, so
6478 there's no need to cast the result if double-click-time is
6479 nonnegative, as it should be; check that it's nonnegative, just in
6480 case. This bug is triggered when events are more than 2**31 ms
6481 apart (about 25 days). (Bug#8664)
6483 * xselect.c (last_event_timestamp): Remove duplicate decl.
6484 (x_own_selection): Remove needless cast to unsigned long.
6486 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6487 that always fit in int. Use a sentinel instead of a counter, to
6488 avoid a temp and to allay GCC's concerns about possible int overflow.
6489 * frame.h (struct frame): Use int for menu_bar_items_used
6490 instead of EMACS_INT, since it always fits in int.
6492 * menu.c (grow_menu_items): Check for int overflow.
6494 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6496 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6497 Before, the code was not consistent. These values cannot exceed
6498 2**31 - 1 so there's no need to make them unsigned.
6499 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6500 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6501 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6503 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6505 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6506 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6507 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6508 presumably because the widths might not match.
6510 * window.c (size_window): Avoid needless test at loop start.
6512 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6514 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6516 2011-05-12 Drew Adams <drew.adams@oracle.com>
6518 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6520 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6522 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6523 `width' to `bar_area_x' and `bar_area_width', respectively.
6524 (x_scroll_run): Take account of fringe background extension.
6526 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6527 Rename local vars `left' and `width' to `bar_area_x' and
6528 `bar_area_width', respectively.
6529 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6530 background extension.
6532 2011-05-10 Jim Meyering <meyering@redhat.com>
6534 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6536 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6538 * image.c (Finit_image_library): Return t for built-in image types,
6539 like pbm and xbm. (Bug#8640)
6541 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6543 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6545 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6547 * w32console.c (Fset_screen_color): Doc fix.
6548 (Fget_screen_color): New function.
6549 (syms_of_ntterm): Defsubr it.
6551 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6552 unlink the temporary file if Fcall_process didn't create it in the
6554 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6555 child process will be redirected to a file specified with `:file'.
6556 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6557 cue to call_process_cleanup not to close that handle.
6559 2011-05-07 Ben Key <bkey76@gmail.com>
6561 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6562 one of two shell specific rules, either bootstrap-temacs-CMD or
6563 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6564 to the previous implementation of the bootstrap-temacs rule.
6565 The bootstrap-temacs-CMD rule is similar to the previous
6566 implementation of the bootstrap-temacs rule except that it
6567 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6570 These changes, along with some changes to nt/configure.bat,
6571 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6572 earlier fix to add support for --cflags and --ldflags options
6573 that include quotes so that it works whether make uses cmd or
6576 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6578 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6579 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6581 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6582 a string. Handle both cases.
6583 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6584 (Fdbus_register_method): Use Qinvalid_function.
6586 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6588 * makefile.w32-in: Update dependencies.
6589 (LISP_H): Add inttypes.h and stdin.h.
6590 (PROCESS_H): Add unistd.h.
6592 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6594 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6595 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6597 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6599 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6601 * term.c (vfatal): Remove stray call to va_end.
6602 It's not needed and the C Standard doesn't allow it here anyway.
6604 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6605 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6607 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6610 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6612 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6614 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6616 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6618 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6620 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6621 * charset.c (Fdefine_charset_internal): Don't initialize
6622 charset.code_space[15]. The value was garbage, on hosts with
6623 32-bit int (Bug#8600).
6625 * lread.c (read_integer): Be more consistent with string-to-number.
6626 Use string_to_number to do the actual conversion; this avoids
6627 rounding errors and fixes some other screwups. Without this fix,
6628 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6629 (digit_to_number): Move earlier, for benefit of read_integer.
6630 Return -1 if the digit is out of range for the base, -2 if it is
6631 not a digit in any supported base. (Bug#8602)
6633 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6635 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6636 to match comment at start of function. This also removes a
6637 GCC warning about overflow in a 32+64-bit port.
6639 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6641 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6642 Reported by Stefan Monnier in
6643 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6644 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6645 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6647 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6648 (EMACS_UINTPTR): Likewise, with uintptr_t.
6650 * lisp.h: Prefer 64-bit EMACS_INT if available.
6651 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6652 on 32-bit hosts that have 64-bit int, so that they can access
6654 However, temporarily disable this change unless the temporary
6655 symbol WIDE_EMACS_INT is defined.
6657 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6659 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6660 This removes an assumption that EMACS_INT and long are the same
6661 width as pointers. The assumption is true for Emacs porting targets
6662 now, but we want to make other targets possible.
6663 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6664 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6665 In the rest of the code, change types of integers that hold casted
6666 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6667 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6668 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6669 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6670 No need to cast type when ORing.
6671 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6672 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6673 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6674 assume EMACS_INT is the same width as char *.
6675 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6676 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6677 Remove no-longer-needed casts.
6678 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6679 (xg_tool_bar_help_callback, xg_make_tool_item):
6680 Use EMACS_INTPTR to hold an integer
6681 that will be cast to void *; this can avoid a GCC warning
6682 if EMACS_INT is not the same width as void *.
6683 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6684 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6685 (current_message_1, set_message_1):
6686 Use a local to convert to proper width without a cast.
6687 * xmenu.c (dialog_selection_callback): Likewise.
6689 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6690 Also, don't assume VALBITS / RAND_BITS is less than 5,
6691 and don't rely on undefined behavior when shifting a 1 left into
6693 * lisp.h (get_random): Change signature to match.
6695 * lread.c (hash_string): Use size_t, not int, for hash computation.
6696 Normally we prefer signed values; but hashing is special, because
6697 it's better to use unsigned division on hash table sizes so that
6698 the remainder is nonnegative. Also, size_t is the natural width
6699 for hashing into memory. The previous code used 'int', which doesn't
6700 retain enough info to hash well into very large tables.
6701 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6703 * dbusbind.c: Don't possibly lose pointer info when converting.
6704 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6705 Use XPNTR rather than XHASH, so that the high-order bits of
6706 the pointer aren't lost when converting through void *.
6708 * eval.c (Fautoload): Don't double-shift a pointer.
6710 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6712 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6714 * gnutls.c (DEF_GNUTLS_FN):
6715 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6717 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6719 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6722 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6724 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6725 New version that can reserve upto 2GB of heap space.
6727 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6729 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6731 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6733 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6734 `gnutls_certificate_set_x509_key_file'.
6736 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6738 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6739 Update dependencies.
6741 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6743 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6744 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6745 Remove unused parameter `fildes'.
6746 * process.c (read_process_output, send_process): Don't pass it.
6748 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6750 Fix previous change: the library cache is defined in w32.c.
6751 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6752 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6754 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6756 Implement dynamic loading of GnuTLS on Windows.
6758 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6759 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6760 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6763 * gnutls.c (Qgnutls_dll): Define.
6764 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6765 (gnutls_*): Declare function pointers.
6766 (init_gnutls_functions): New function to initialize function pointers.
6767 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6768 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6769 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6770 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6771 (emacs_gnutls_write, emacs_gnutls_read)
6772 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6773 (Fgnutls_available_p): New function.
6774 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6775 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6776 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6778 * image.c: Include w32.h.
6779 (Vimage_type_cache): Delete.
6780 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6781 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6782 (w32_delayed_load): Move to w32.c.
6784 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6786 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6787 (w32_delayed_load): Move from image.c. When loading a library, record
6788 its filename in the :loaded-from property of the library id.
6789 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6790 Initialize and staticpro them.
6791 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6793 * process.c: Include lisp.h before w32.h, not after.
6794 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6795 instead of gnutls_record_check_pending.
6797 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6799 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6801 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6802 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6805 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6807 * xterm.c (x_set_frame_alpha): Do not set property on anything
6808 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6810 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6812 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6814 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6816 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6817 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6818 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6819 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6820 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6821 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6822 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6823 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6824 (Qgnutls_bootprop_callbacks_verify): Make static.
6826 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6828 * callproc.c: Indentation fixup.
6830 * sysdep.c (wait_for_termination_1): Make static.
6831 (wait_for_termination, interruptible_wait_for_termination):
6832 Move after wait_for_termination_1.
6834 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6836 * sysdep.c (interruptible_wait_for_termination): New function
6837 which is like wait_for_termination, but allows keyboard
6840 * callproc.c (Fcall_process): Add (:file "file") as an option for
6842 (Fcall_process_region): Ditto.
6844 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6846 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6847 rather than `XVECTOR (FOO)->size'.
6849 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6850 inttypes.h, as a gnulib replacement is used if it not available in
6853 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6855 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6856 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6857 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6859 * coding.c (coding_alloc_by_realloc): Error out if destination
6860 will grow beyond MOST_POSITIVE_FIXNUM.
6861 (decode_coding_emacs_mule): Abort if there isn't enough place in
6862 charbuf for the composition carryover bytes. Reserve an extra
6863 space for up to 2 characters produced in a loop.
6864 (decode_coding_iso_2022): Abort if there isn't enough place in
6865 charbuf for the composition carryover bytes.
6867 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6869 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6870 aborting when %lld or %lll format is passed.
6871 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6872 %llo or %llx format is passed. (Bug#8545)
6874 * window.c (window_scroll_line_based): Use a marker instead of
6875 simple variables to record original value of point. (Bug#7952)
6877 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6878 produced by %s or %c overflows available buffer space. (Bug#8545)
6880 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6882 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6883 (SIZE_MAX): Move defn after all includes, as they might #define it.
6885 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6887 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6889 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6891 * keyboard.c (Qdelayed_warnings_hook): Define.
6892 (command_loop_1): Run `delayed-warnings-hook'
6893 if Vdelayed_warnings_list is non-nil.
6894 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6895 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6897 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6899 * doprnt.c (doprnt): Don't return value smaller than the buffer
6900 size if the message was truncated. (Bug#8545).
6902 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6904 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6905 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6907 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6909 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6911 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6913 * makefile.w32-in: Update dependencies.
6915 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6917 Improve `doprnt' and its usage. (Bug#8545)
6918 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6919 `format_end'. Remove support for %l as a conversion specifier.
6920 Don't use xrealloc. Improve diagnostics when the %l size modifier
6921 is used. Update the commentary.
6923 * eval.c (verror): Simplify calculation of size_t.
6925 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6928 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6930 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6933 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6935 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6936 This makes this file independent of the recent pseudovector change.
6938 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6940 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6942 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6943 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6944 Remove unused local.
6945 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6947 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6948 GCC 4.6.0 optimizes based on type-based alias analysis.
6949 For example, if b is of type struct buffer * and v of type struct
6950 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6951 != &v->size, and therefore "v->size = 1; b->size = 2; return
6952 v->size;" must therefore return 1. This assumption is incorrect
6953 for Emacs, since it type-puns struct Lisp_Vector * with many other
6954 types. To fix this problem, this patch adds a new type struct
6955 vectorlike_header that documents the constraints on layout of vectors
6956 and pseudovectors, and helps optimizing compilers not get fooled
6957 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6958 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6959 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6961 (XSETPVECTYPE): Rewrite in terms of new macro.
6962 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6963 This is a bit clearer, and further avoids the possibility of
6964 undesirable aliasing.
6965 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6966 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6967 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6968 since Lisp_Subr is a special case (no "next" field).
6969 (ASIZE): Now uses header.size rather than size.
6970 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6971 to avoid the hassle of writing XVECTOR (foo)->header.size.
6972 (struct vectorlike_header): New type.
6973 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6974 object, to help avoid aliasing.
6975 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6976 (SUBRP): Likewise, since Lisp_Subr is a special case.
6977 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6978 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6979 (struct Lisp_Hash_Table): Combine first two members into a single
6980 struct vectorlike_header member. All uses of "size" and "next" members
6981 changed to be "header.size" and "header.next".
6982 * buffer.h (struct buffer): Likewise.
6983 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6984 * frame.h (struct frame): Likewise.
6985 * process.h (struct Lisp_Process): Likewise.
6986 * termhooks.h (struct terminal): Likewise.
6987 * window.c (struct save_window_data, struct saved_window): Likewise.
6988 * window.h (struct window): Likewise.
6989 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6990 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6991 * buffer.c (init_buffer_once): Likewise.
6992 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6994 * process.c (Fformat_network_address): Use local var for size,
6997 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6999 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7000 * data.c (atof): Remove decl; no longer used or needed.
7001 (digit_to_number): Move to lread.c.
7002 (Fstring_to_number): Use new string_to_number function, to be
7003 consistent with how the Lisp reader treats infinities and NaNs.
7004 Do not assume that floating-point numbers represent EMACS_INT
7005 without losing information; this is not true on most 64-bit hosts.
7006 Avoid double-rounding errors, by insisting on integers when
7007 parsing non-base-10 numbers, as the documentation specifies.
7008 * lisp.h (string_to_number): New decl, replacing ...
7009 (isfloat_string): Remove.
7010 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7011 (read1): Do not accept +. and -. as integers; this
7012 appears to have been a coding error. Similarly, do not accept
7013 strings like +-1e0 as floating point numbers. Do not report
7014 overflow for integer overflows unless the base is not 10 which
7015 means we have no simple and reliable way to continue.
7016 Break out the floating-point parsing into a new
7017 function string_to_number, so that Fstring_to_number parses
7018 floating point numbers consistently with the Lisp reader.
7019 (digit_to_number): Move here from data.c. Make it static inline.
7020 (E_CHAR, EXP_INT): Remove, replacing with ...
7021 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7022 (string_to_number): New function, replacing isfloat_string.
7023 This function checks for valid syntax and produces the resulting
7024 Lisp float number too. Rework it so that string-to-number
7025 no longer mishandles examples like "1.0e+". Use strtoumax,
7026 so that overflow for non-base-10 numbers is reported only when
7027 there's no portable and simple way to convert to floating point.
7029 * textprop.c (set_text_properties_1): Rewrite for clarity,
7030 and to avoid GCC warning about integer overflow.
7032 * intervals.h (struct interval): Use EMACS_INT for members
7033 where EMACS_UINT might cause problems. See
7034 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7035 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7036 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7038 (offset_intervals): Tell GCC not to worry about length overflow
7039 when negating a negative length.
7041 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7042 (overrun_check_free): Likewise.
7044 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7045 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7048 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7049 (gnutls_make_error): Rename local to avoid shadowing.
7050 (gnutls_emacs_global_deinit): ifdef out; not used.
7051 (Fgnutls_boot): Use const for pointer to readonly storage.
7052 Comment out unused local. Fix pointer signedness problems.
7054 * lread.c (openp): Don't stuff size_t into an 'int'.
7055 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7056 about possible signed overflow.
7058 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7059 (GDK_KEY_g): Don't define if already defined.
7060 (xg_prepare_tooltip): Avoid pointer signedness problem.
7061 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7063 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7064 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7066 * xfns.c (Fx_window_property): Simplify a bit,
7067 to make a bit faster and to avoid GCC 4.6.0 warning.
7068 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7070 * fns.c (internal_equal): Don't assume size_t fits in int.
7072 * alloc.c (compact_small_strings): Tighten assertion a little.
7074 Replace pEd with more-general pI, and fix some printf arg casts.
7075 * lisp.h (pI): New macro, generalizing old pEd macro to other
7076 conversion specifiers. For example, use "...%"pI"d..." rather
7077 than "...%"pEd"...".
7078 (pEd): Remove. All uses replaced with similar uses of pI.
7079 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
7080 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7081 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7082 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7083 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7084 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7085 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7087 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7088 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7089 * print.c (safe_debug_print, print_object): Likewise.
7090 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7092 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7093 avoiding the 0 flag, which is not portable.
7094 * process.c (Fmake_network_process): Use pI to avoid cast.
7095 * region-cache.c (pp_cache): Likewise.
7096 * xdisp.c (decode_mode_spec): Likewise.
7097 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7098 behavior on 64-bit hosts with printf arg.
7099 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7100 (x_stop_queuing_selection_requests): Likewise.
7101 (x_get_window_property): Don't truncate byte count to an 'int'
7104 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7105 here, since it parses constructs like leading '-' and spaces,
7106 which are not wanted; and it overflows with large numbers.
7107 Instead, simply match F[0-9]+, which is what is wanted anyway.
7109 * alloc.c: Remove unportable assumptions about struct layout.
7110 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7111 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7112 (allocate_vectorlike, make_pure_vector): Use the new macros,
7113 plus offsetof, to remove unportable assumptions about struct layout.
7114 These assumptions hold on all porting targets that I know of, but
7115 they are not guaranteed, they're easy to remove, and removing them
7116 makes further changes easier.
7118 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7119 This doesn't fix a bug but makes the code clearer.
7120 (string_overrun_cookie): Now const. Use initializers that
7121 don't formally overflow signed char, to avoid warnings.
7122 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7123 can cause Emacs to crash when string overrun checking is enabled.
7124 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7125 multiple of sizeof (EMACS_INT); it need not be, if
7126 alignof(EMACS_INT) < sizeof (EMACS_INT).
7127 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7129 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7131 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7133 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7135 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7136 supposed to be handshaking. (Bug#8556)
7137 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7139 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7141 * lisp.h (Qdebug): List symbol.
7142 * eval.c (Qdebug): Restore global linkage.
7143 * keyboard.c (debug-on-event): New variable.
7144 (handle_user_signal): Break into debugger when debug-on-event
7145 matches the current signal symbol.
7147 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7149 * alloc.c (check_sblock, check_string_bytes)
7150 (check_string_free_list): Convert to standard C.
7152 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7154 * w32.c (emacs_gnutls_push): Fix typo.
7156 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7158 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7159 "cast to pointer from integer of different size".
7161 Improve doprnt and its use in verror. (Bug#8545)
7162 * doprnt.c (doprnt): Document the set of format control sequences
7163 supported by the function. Use SAFE_ALLOCA instead of always
7166 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7167 is one byte too soon. Don't use xrealloc; instead xfree and
7170 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7172 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7175 * gnutls.c: Renamed global_initialized to
7176 gnutls_global_initialized. Added internals for the
7177 :verify-hostname-error, :verify-error, and :verify-flags
7178 parameters of `gnutls-boot' and documented those parameters in the
7179 docstring. Start callback support.
7180 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7181 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7182 on error. Return error code.
7183 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7184 (emacs_gnutls_read): Likewise.
7185 (Fgnutls_boot): Return handshake error code.
7186 (emacs_gnutls_handle_error): New function.
7187 (wsaerror_to_errno): Likewise.
7189 * w32.h (emacs_gnutls_pull): Add prototype.
7190 (emacs_gnutls_push): Likewise.
7192 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7193 (emacs_gnutls_push): Likewise.
7195 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7197 * process.c (wait_reading_process_output): Check if GnuTLS
7198 buffered some data internally if no FDs are set for TLS
7201 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7202 (LIBS): Link to USER_LIBS.
7203 ($(BLD)/gnutls.$(0)): New target.
7205 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7207 * xdisp.c (handle_single_display_spec): Rename the
7208 display_replaced_before_p argument into display_replaced_p, to
7209 make it consistent with the commentary. Fix typos in the
7212 * textprop.c (syms_of_textprop): Remove dead code.
7213 (copy_text_properties): Delete obsolete commentary about an
7214 interface that was deleted long ago. Fix typos in the description
7217 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7218 to changes in oldXMenu/XMenu.h from 2011-04-16.
7219 <menu_help_message, prev_menu_help_message>: Constify.
7220 (IT_menu_make_room): menu->help_text is now `const char **';
7223 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7224 to changes in oldXMenu/XMenu.h from 2011-04-16.
7225 (struct XMenu): Declare `help_text' `const char **'.
7227 * xfaces.c <Qunspecified>: Make extern again.
7229 * syntax.c: Include sys/types.h before including regex.h, as
7232 * doc.c (get_doc_string): Improve the format passed to `error'.
7234 * doprnt.c (doprnt): Improve commentary.
7236 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7238 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7241 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7242 changes in globals.h immediately force recompilation.
7243 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7244 $(CURDIR)/s/ms-w32.h.
7245 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7247 * character.c (Fchar_direction): Function deleted.
7248 (syms_of_character): Don't defsubr it.
7249 <char-direction-table>: Deleted.
7251 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7253 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7254 * doprnt.c: Include limits.h.
7255 (SIZE_MAX): New macro.
7256 (doprnt): Return a size_t value. 2nd arg is now size_t.
7257 Many local variables are now size_t instead of int or unsigned.
7258 Improve overflow protection. Support `l' modifier for integer
7259 conversions. Support %l conversion. Don't assume an EMACS_INT
7260 argument for integer conversions and for %c.
7262 * lisp.h (doprnt): Restore prototype.
7264 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7267 * Makefile.in (base_obj): Add back doprnt.o.
7269 * deps.mk (doprnt.o): Add back prerequisites.
7270 (callint.o): Depend on character.h.
7272 * eval.c (internal_lisp_condition_case): Include the handler
7273 representation in the error message.
7274 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7275 when breaking from the loop.
7277 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7279 * callint.c (Fcall_interactively): When displaying error message
7280 about invalid control letter, pass the character's codepoint, not
7281 a pointer to its multibyte form. Improve display of the character
7282 in octal and display also its hex code.
7284 * character.c (char_string): Use %x to display the (unsigned)
7285 codepoint of an invalid character, to avoid displaying a bogus
7288 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7289 `error', not SYMBOL_NAME itself.
7291 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7292 character arguments to `error'.
7294 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7295 to `error' in error message about FINAL_CHAR argument. Make sure
7296 FINAL_CHAR is a character, and use %c when it is passed as
7297 argument to `error'.
7299 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7301 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7303 * w32.c: Include <time.h>.
7304 (sys_localtime): New function.
7306 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7308 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7310 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7312 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7314 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7317 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7319 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7320 gl_state.e_property when gl_state.object is Qt.
7322 * insdel.c (make_gap_larger): Remove limitation of buffer size
7325 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7327 * xdisp.c (lookup_glyphless_char_display)
7328 (produce_glyphless_glyph): Handle cons cell entry in
7329 glyphless-char-display.
7330 (Vglyphless_char_display): Document it.
7332 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7333 glyphless-char-display.
7335 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7337 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7339 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7341 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7342 definition for no-X builds.
7344 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7346 Static checks with GCC 4.6.0 and non-default toolkits.
7348 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7350 * process.c (keyboard_bit_set): Define only if SIGIO.
7351 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7352 (send_process): Repair possible setjmp clobbering.
7354 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7356 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7358 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7360 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7361 Define only if needed.
7363 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7364 by pacifying GCC about it. Maybe it's time to retire it?
7365 * xfaces.c (USG, __TIMEVAL__): Likewise.
7367 * dispextern.h (struct redisplay_interface): Rename param
7369 * termhooks.h (struct terminal): Likewise.
7370 * xterm.c (xembed_send_message): Likewise.
7372 * insdel.c (make_gap_smaller): Define only if
7373 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7375 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7378 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7379 so that we aren't warned about unused symbols.
7381 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7383 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7385 * xfns.c (x_real_positions): Mark locals as initialized.
7387 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7389 * xterm.c: Fix problems found by static analysis with other toolkits.
7390 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7391 (x_dispatch_event): Declare static if USE_GTK, and
7392 define if USE_GTK || USE_X_TOOLKIT.
7393 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7394 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7395 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7396 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7398 * xmenu.c (menu_help_callback): Pointer type fixes.
7399 Use const pointers when pointing at readonly data. Avoid pointer
7401 (FALSE): Remove unused macro.
7402 (update_frame_menubar): Remove unused decl.
7404 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7406 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7407 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7408 (single_menu_item): Rename local to avoid shadowing.
7410 * keyboard.c (make_lispy_event): Remove unused local var.
7412 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7413 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7415 * bitmaps: Change bitmaps from unsigned char back to the X11
7416 compatible char. Avoid the old compiler warnings about
7417 out-of-range initializers by using, for example, '\xab' rather
7420 * xgselect.c (xgselect_initialize): Check vs interface
7421 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7423 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7425 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7426 to read-only memory.
7428 * fns.c (vector): Remove; this old hack is no longer needed.
7430 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7432 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7434 * xrdb.c (x_load_resources): Omit unused local.
7436 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7437 (x_window): Rename locals to avoid shadowing.
7438 (USG): Use the kludged USG macro, to pacify gcc.
7440 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7441 (x_term_init): Remove local to avoid shadowing.
7443 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7445 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7446 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7448 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7450 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7452 Fix regex.c, syntax.c and friends for buffers > 2GB.
7453 * syntax.h (struct gl_state_s): Declare character position members
7456 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7458 * textprop.c (verify_interval_modification, interval_of):
7459 Declare arguments EMACS_INT.
7461 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7464 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7466 * indent.c (Fvertical_motion): Local variable it_start is now
7469 * regex.c (re_match, re_match_2, re_match_2_internal)
7470 (bcmp_translate, regcomp, regexec, print_double_string)
7471 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7472 (re_compile_pattern, re_exec): Declare arguments and local
7473 variables `size_t' and `ssize_t' and return values `regoff_t', as
7475 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7476 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7477 <compile_stack_type>: `size' and `avail' are now `size_t'.
7479 * regex.h <regoff_t>: Use ssize_t, not int.
7480 (re_search, re_search_2, re_match, re_match_2): Arguments that
7481 specify buffer/string position and length are now ssize_t and
7482 size_t. Return type is regoff_t.
7484 2011-04-16 Ben Key <bkey76@gmail.com>
7486 * nsfont.m: Fixed bugs in ns_get_family and
7487 ns_descriptor_to_entity that were caused by using free to
7488 deallocate memory blocks that were allocated by xmalloc (via
7489 xstrdup). This caused Emacs to crash when compiled with
7490 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7491 --enable-checking=xmallocoverrun). xfree is now used to
7492 deallocate these memory blocks.
7494 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7496 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7498 emacs_write: Accept and return EMACS_INT for sizes.
7499 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7501 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7502 Accept and return EMACS_INT.
7503 (emacs_gnutls_write): Return the number of bytes written on
7505 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7506 (emacs_read, emacs_write): Remove check for negative size, as the
7507 Emacs source code has been audited now.
7508 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7509 (emacs_read, emacs_write): Use it.
7510 * process.c (send_process): Adjust to the new signatures of
7511 emacs_write and emacs_gnutls_write. Do not attempt to store
7512 a byte offset into an 'int'; it might overflow.
7513 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7515 * sound.c: Don't assume sizes fit in 'int'.
7516 (struct sound_device.period_size, alsa_period_size):
7517 Return EMACS_INT, not int.
7518 (struct sound_device.write, vox_write, alsa_write):
7519 Accept EMACS_INT, not int.
7520 (wav_play, au_play): Use EMACS_INT to store sizes and to
7521 record read return values.
7523 2011-04-15 Ben Key <bkey76@gmail.com>
7525 * keyboard.c (Qundefined): Don't declare static since it is used
7527 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7528 static since they are used in nsfont.m.
7530 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7532 * process.c (Qprocessp): Don't declare static.
7533 * lisp.h (Qprocessp): Declare again.
7535 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7537 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7539 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7541 Improve C-level modularity by making more things 'static'.
7543 Don't publish debugger-only interfaces to other modules.
7544 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7545 (verify_bytepos, count_markers): Move decls to the only modules
7547 * region-cache.h (pp_cache): Likewise.
7548 * window.h (check_all_windows): Likewise.
7549 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7551 * sysdep.c (croak): Now static, if
7552 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7553 * syssignal.h (croak): Declare only if not static.
7555 * alloc.c (refill_memory_reserve): Now static if
7556 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7557 * lisp.h (refill_memory_reserve): Declare only if not static.
7559 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7560 Define only if USE_LUCID.
7562 * xrdb.c (x_customization_string, x_rm_string): Now static.
7564 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7565 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7567 * xdisp.c (draw_row_with_mouse_face): Now static.
7568 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7570 * window.h (check_all_windows): Mark externally visible.
7572 * window.c (window_deletion_count): Now static.
7574 * undo.c: Make symbols static if they're not exported.
7575 (last_undo_buffer, last_boundary_position, pending_boundary):
7578 * textprop.c (interval_insert_behind_hooks): Now static.
7579 (interval_insert_in_front_hooks): Likewise.
7581 * term.c: Make symbols static if they're not exported.
7582 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7583 (max_frame_lines, tty_set_terminal_modes):
7584 (tty_reset_terminal_modes, tty_turn_off_highlight):
7585 (get_tty_terminal): Now static.
7586 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7587 * termhooks.h (term_mouse_moveto): Do not declare if
7589 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7590 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7592 * sysdep.c: Make symbols static if they're not exported.
7593 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7595 (sigprocmask_set, full_mask): Remove; unused.
7596 (wait_debugging): Mark as visible.
7597 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7598 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7600 * syntax.c (syntax_temp): Define only if !__GNUC__.
7602 * sound.c (current_sound_device, current_sound): Now static.
7604 * search.c (searchbufs, searchbuf_head): Now static.
7606 * scroll.c (scroll_cost): Remove; unused.
7607 * dispextern.h (scroll_cost): Remove decl.
7609 * region-cache.h (pp_cache): Mark as externally visible.
7611 * process.c: Make symbols static if they're not exported.
7612 (process_tick, update_tick, create_process, chan_process):
7613 (Vprocess_alist, proc_buffered_char, datagram_access):
7614 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7615 (deactivate_process): Mark defn as static, as well as decl.
7616 * lisp.h (create_process): Remove decl.
7617 * process.h (chan_process, Vprocess_alist): Remove decls.
7619 * print.c: Make symbols static if they're not exported.
7620 (print_depth, new_backquote_output, being_printed, print_buffer):
7621 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7622 (print_interval, print_number_index, initial_stderr_stream):
7624 * lisp.h (Fprinc): Remove decl.
7625 (debug_output_compilation_hack): Mark as externally visible.
7627 * sysdep.c (croak): Move decl from here to syssignal.h.
7628 * syssignal.h (croak): Put it here, so the API can be checked when
7629 'croak' is called from dissociate_if_controlling_tty.
7631 * minibuf.c: Make symbols static if they're not exported.
7632 (minibuf_save_list, choose_minibuf_frame): Now static.
7633 * lisp.h (choose_minibuf_frame): Remove decl.
7635 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7637 * lread.c: Make symbols static if they're not exported.
7638 (read_objects, initial_obarray, oblookup_last_bucket_number):
7640 (make_symbol): Remove; unused.
7641 * lisp.h (initial_obarray, make_symbol): Remove decls.
7643 * keyboard.c: Make symbols static if they're not exported.
7644 (single_kboard, recent_keys_index, total_keys, recent_keys):
7645 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7646 (this_single_command_key_start, echoing, last_auto_save):
7647 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7648 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7649 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7650 (Vlispy_mouse_stem, double_click_count):
7652 (force_auto_save_soon): Define only if SIGDANGER.
7653 (ignore_mouse_drag_p): Now static if
7654 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7655 (print_help): Remove; unused.
7656 (stop_character, last_timer_event): Mark as externally visible.
7657 * keyboard.h (ignore_mouse_drag_p): Declare only if
7658 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7659 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7660 * lisp.h (echoing): Remove decl.
7661 (force_auto_save_soon): Declare only if SIGDANGER.
7662 * xdisp.c (redisplay_window): Simplify code, to make it more
7663 obvious that ignore_mouse_drag_p is not accessed if !defined
7664 USE_GTK && !defined HAVE_NS.
7666 * intervals.c: Make symbols static if they're not exported.
7667 (merge_properties_sticky, merge_interval_right, delete_interval):
7669 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7671 * insdel.c: Make symbols static if they're not exported.
7672 However, leave prepare_to_modify_buffer alone. It's never
7673 called from outside this function, but that appears to be a bug.
7674 (combine_after_change_list, combine_after_change_buffer):
7675 (adjust_after_replace, signal_before_change): Now static.
7676 (adjust_after_replace_noundo): Remove; unused.
7677 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7678 (signal_before_change): Remove decls.
7680 * indent.c (val_compute_motion, val_vmotion): Now static.
7682 * image.c: Make symbols static if they're not exported.
7683 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7685 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7686 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7688 * fringe.c (standard_bitmaps): Now static.
7689 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7691 * frame.c: Make symbols static if they're not exported.
7692 (x_report_frame_params, make_terminal_frame): Now static.
7693 (get_frame_param): Now static, unless HAVE_NS.
7694 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7695 (x_get_resource_string): Remove; not used.
7696 * frame.h (make_terminal_frame, x_report_frame_params):
7697 (x_get_resource_string); Remove decls.
7698 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7699 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7701 * font.c, fontset.c: Make symbols static if they're not exported.
7702 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7703 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7704 * font.c (font_close_object): Now static.
7705 * font.h (font_close_object): Remove.
7706 * fontset.c (FONTSET_OBJLIST): Remove.
7707 (free_realized_fontset) #if-0 the body, which does nothing.
7708 (face_suitable_for_char_p): #if-0, as it's never called.
7709 * fontset.h (face_suitable_for_char_p): Remove decl.
7710 * xfaces.c (face_at_string_position):
7711 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7712 since 0 is always ASCII.
7714 * fns.c (weak_hash_tables): Now static.
7716 * fileio.c: Make symbols static if they're not exported.
7717 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7718 (Vwrite_region_annotation_buffers): Now static.
7720 * eval.c: Make symbols static if they're not exported.
7721 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7722 * lisp.h (backtrace_list): Remove decl.
7724 * emacs.c: Make symbols static if they're not exported.
7725 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7726 (fatal_error_code, fatal_error_signal_hook, standard_args):
7728 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7729 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7730 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7731 * lisp.h (fatal_error_signal_hook): Remove decl.
7732 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7734 * editfns.c: Move a (normally-unused) function to its only use.
7735 * editfns.c, lisp.h (get_operating_system_release): Remove.
7736 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7737 worth the hassle of breaking this out.
7739 * xterm.c: Make symbols static if they're not exported.
7740 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7741 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7742 (x_destroy_window, x_delete_display):
7744 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7745 (x_mouse_leave): Remove; unused.
7746 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7747 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7748 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7750 (x_mouse_leave): Declare only if WINDOWSNT.
7751 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7752 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7755 * ftxfont.c: Make symbols static if they're not exported.
7756 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7758 * font.h (ftxfont_driver): Likewise.
7760 * xfns.c: Make symbols static if they're not exported.
7761 (x_last_font_name, x_display_info_for_name):
7762 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7763 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7764 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7765 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7766 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7767 (last_show_tip_args): Now static.
7768 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7769 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7770 (x_screen_planes): Remove; unused.
7771 * dispextern.h (x_screen_planes): Remove decl.
7773 * dispnew.c: Make symbols static if they're not exported.
7774 * dispextern.h (redraw_garbaged_frames, scrolling):
7775 (increment_row_positions): Remove.
7776 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7777 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7779 (redraw_garbaged_frames): Remove; unused.
7781 * xfaces.c: Make symbols static if they're not exported.
7782 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7784 * xterm.h (defined_color): Remove decls.
7785 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7786 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7787 (menu_face_changed_default, defined_color, free_realized_face):
7788 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7789 (ascii_face_of_lisp_face): Remove; unused.
7791 * xdisp.c: Make symbols static if they're not exported.
7792 * dispextern.h (scratch_glyph_row, window_box_edges):
7793 (glyph_to_pixel_coords, set_cursor_from_row):
7794 (get_next_display_element, set_iterator_to_next):
7795 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7796 (show_mouse_face): Remove decls
7797 * frame.h (message_buf_print): Likewise.
7798 * lisp.h (pop_message, set_message, check_point_in_composition):
7800 * xterm.h (set_vertical_scroll_bar): Likewise.
7801 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7802 (message_buf_print, scratch_glyph_row, displayed_buffer):
7803 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7804 (get_next_display_element, show_mouse_face, window_box_edges):
7805 (frame_to_window_pixel_xy, check_point_in_composition):
7806 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7807 (glyph_to_pixel_coords): Remove; unused.
7809 * dired.c (file_name_completion): Now static.
7811 * dbusbind.c (xd_in_read_queued_messages): Now static.
7813 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7814 * data.c (circular_list_error): Remove.
7816 * commands.h (last_point_position, last_point_position_buffer):
7817 (last_point_position_window): Remove decls.
7818 * keyboard.c: Make these variables static.
7820 * coding.h (coding, code_convert_region, encode_coding_gap):
7822 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7823 (iso_code_class, detect_coding, code_convert_region): Now static.
7824 (encode_coding_gap): Remove; unused.
7826 * chartab.c (chartab_chars, chartab_bits): Now static.
7828 * charset.h (charset_iso_8859_1): Remove decl.
7829 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7832 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7833 * ccl.c (Vccl_program_table): Now static.
7834 (check_ccl_update): Remove; unused.
7836 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7837 * category.h: ... from here.
7838 * category.c (check_category_table, set_category_set): Now static.
7840 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7841 * lisp.h: Remove these decls.
7843 * buffer.c (buffer_count): Remove unused var.
7845 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7846 so that it's not optimized away.
7847 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7848 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7849 exported only to the debugger.
7851 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7852 * atimer.h (run_all_atimers): Remove; not exported.
7854 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7855 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7856 was inaccessible from Lisp.
7857 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7858 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7860 alloc.c: Import and export fewer symbols, and remove unused items.
7861 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7863 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7864 it's not optimized away by whole-program optimization.
7865 (message_enable_multibyte, free_misc): Remove.
7866 (catchlist, handlerlist, mark_backtrace):
7867 Declare only if BYTE_MARK_STACK.
7868 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7869 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7870 (message_enable_multibyte): Remove decl.
7871 (free_misc, interval_free_list, float_block, float_block_index):
7872 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7873 (cons_free_list, last_marked_index):
7875 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7876 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7877 (mark_backtrace): Define only if BYTE_MARK_STACK.
7878 * xdisp.c (message_enable_multibyte): Now static.
7880 Declare Lisp_Object Q* variables to be 'static' if not exported.
7881 This makes it easier for human readers (and static analyzers)
7882 to see whether these variables are used from other modules.
7883 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7884 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7885 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7886 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7887 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7888 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7889 * xmenu.c, xselect.c:
7890 Declare Q* vars static if they are not used in other modules.
7891 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7892 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7893 Remove decls of unexported vars.
7894 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7896 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7898 Make Emacs functions such as Fatom 'static' by default.
7899 This makes it easier for human readers (and static analyzers)
7900 to see whether these functions can be called from other modules.
7901 DEFUN now defines a static function. To make the function external
7902 so that it can be used in other C modules, use the new macro DEFUE.
7903 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7904 (Finit_image_library):
7905 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7906 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7907 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7908 Remove decls, since these functions are now static.
7909 (Funintern, Fget_internal_run_time): New decls, since these functions
7910 were already external.
7912 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7913 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7914 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7915 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7916 * keyboard.c, keymap.c, lread.c:
7917 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7918 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7919 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7920 Mark functions with DEFUE instead of DEFUN,
7921 if they are used in other modules.
7922 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7923 decls for now-static functions.
7924 * buffer.h (Fdelete_overlay): Remove decl.
7925 * callproc.c (Fgetenv_internal): Mark as internal.
7926 * composite.c (Fremove_list_of_text_properties): Remove decl.
7927 (Fcomposition_get_gstring): New forward static decl.
7928 * composite.h (Fcomposite_get_gstring): Remove decl.
7929 * dired.c (Ffile_attributes): New forward static decl.
7930 * doc.c (Fdocumntation_property): New forward static decl.
7931 * eval.c (Ffetch_bytecode): New forward static decl.
7932 (Funintern): Remove extern decl; now in .h file where it belongs.
7933 * fileio.c (Fmake_symbolic_link): New forward static decl.
7934 * image.c (Finit_image_library): New forward static decl.
7935 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7936 * intervals.h (Fprevious_property_change):
7937 (Fremove_list_of_text_properties): Remove decls.
7938 * keyboard.c (Fthis_command_keys): Remove decl.
7939 (Fcommand_execute): New forward static decl.
7940 * keymap.c (Flookup_key): New forward static decl.
7941 (Fcopy_keymap): Now static.
7942 * keymap.h (Flookup_key): Remove decl.
7943 * process.c (Fget_process): New forward static decl.
7944 (Fprocess_datagram_address): Mark as internal.
7945 * syntax.c (Fsyntax_table_p): New forward static decl.
7946 (skip_chars): Remove duplicate decl.
7947 * textprop.c (Fprevious_property_change): New forward static decl.
7948 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7950 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7951 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7953 * editfns.c (Fformat): Remove unreachable code.
7955 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7957 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7960 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7962 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7963 when at ZV. (Bug#8487)
7965 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7967 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7969 * keyboard.c (parse_tool_bar_item): Likewise.
7970 * sound.c (sound_cleanup, alsa_close): Likewise.
7971 * termcap.c (tgetent): Likewise.
7972 * xfns.c (x_default_font_parameter): Likewise.
7973 * xsettings.c (read_and_apply_settings): Likewise.
7975 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7976 (overrun_check_free): Protoize.
7978 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7980 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7981 since callers should never pass a negative size.
7982 Change the signature to match that of plain 'read' and 'write'; see
7983 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7984 * lisp.h: Update prototypes of emacs_write and emacs_read.
7986 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7988 * xdisp.c (redisplay_window): Don't try to determine the character
7989 position of the scroll margin if the window start point w->startp
7990 is outside the buffer's accessible region. (Bug#8468)
7992 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7994 Fix write-region and its subroutines for buffers > 2GB.
7995 * fileio.c (a_write, e_write): Modify declaration of arguments and
7996 local variables to support buffers larger than 2GB.
7997 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7999 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8000 argument, local variables, and return value.
8002 * lisp.h: Update prototypes of emacs_write and emacs_read.
8004 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8006 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8008 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8010 Fix more problems found by GCC 4.6.0's static checks.
8012 * xdisp.c (vmessage): Use a better test for character truncation.
8014 * charset.c (load_charset_map): <, not <=, for optimization,
8015 and to avoid potential problems with integer overflow.
8016 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8017 * casetab.c (set_identity, shuffle): Likewise.
8018 * editfns.c (Fformat): Likewise.
8019 * syntax.c (skip_chars): Likewise.
8021 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8022 This also lets GCC 4.6.0 generate slightly better loop code.
8024 * callint.c (Fcall_interactively): <, not <=, for optimization.
8025 (Fcall_interactively): Count the number of arguments produced,
8026 not the number of arguments given. This is simpler and lets GCC
8027 4.6.0 generate slightly better code.
8029 * ftfont.c: Distingish more carefully between FcChar8 and char.
8030 The previous code passed unsigned char * to a functions like
8031 strlen and xstrcasecmp that expect char *, which does not
8032 conform to the C standard.
8033 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8034 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8035 char * when the C standard requires it.
8037 * keyboard.c (read_char): Remove unused var.
8039 * eval.c: Port to Windows vsnprintf (Bug#8435).
8041 (SIZE_MAX): Define if the headers do not.
8042 (verror): Do not give up if vsnprintf returns a negative count.
8043 Instead, grow the buffer. This ports to Windows vsnprintf, which
8044 does not conform to C99. Problem reported by Eli Zaretskii.
8045 Also, simplify the allocation scheme, by avoiding the need for
8046 calling realloc, and removing the ALLOCATED variable.
8048 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8050 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8051 But keep the doprint source code for now, as we might revamp it
8052 and use it again (Bug#8435).
8053 * lisp.h (doprnt): Remove.
8054 * Makefile.in (base_obj): Remove doprnt.o.
8055 * deps.mk (doprnt.o): Remove.
8057 error: Print 32- and 64-bit integers portably (Bug#8435).
8058 Without this change, on typical 64-bit hosts error ("...%d...", N)
8059 was used to print both 32- and 64-bit integers N, which relied on
8061 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
8063 * lisp.h (error, verror): Mark as printf-like functions.
8064 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8065 Report overflow in size calculations when allocating printf buffer.
8066 Do not truncate output string at its first null byte.
8067 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8068 Truncate the output at a character boundary, since vsnprintf does not
8070 * charset.c (check_iso_charset_parameter): Convert internal
8071 character to string before calling 'error', since %c now has the
8073 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8074 overflow when computing char to be passed to 'error'. Do not
8075 pass Lisp_Object to 'error'; pass the integer instead.
8076 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8077 formatted with plain %d.
8079 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8081 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8083 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8085 * xterm.c (x_catch_errors): Remove duplicate declaration.
8087 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8089 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8091 2011-04-10 Jim Meyering <meyering@redhat.com>
8093 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8094 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8095 return ssize_t not "int", and use size_t as the buffer length.
8096 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8097 * gnutls.h: Update declarations.
8098 * process.c (read_process_output): Use ssize_t, to match.
8099 (send_process): Likewise.
8101 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8103 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8105 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8107 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8108 Use unsigned char, to match FcChar8 type definition.
8110 * xterm.c (handle_one_xevent):
8111 * xmenu.c (create_and_show_popup_menu):
8112 * xselect.c (x_decline_selection_request)
8113 (x_reply_selection_request): Avoid type-punned deref of X events.
8115 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8117 Fix some uses of `int' instead of EMACS_INT.
8118 * search.c (string_match_1, fast_string_match)
8119 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8120 (scan_buffer, find_next_newline_no_quit)
8121 (find_before_next_newline, search_command, Freplace_match)
8122 (Fmatch_data): Make some `int' variables be EMACS_INT.
8124 * xdisp.c (display_count_lines): 3rd argument and return value now
8125 EMACS_INT. All callers changed.
8126 (pint2hrstr): Last argument is now EMACS_INT.
8128 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8129 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8130 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8131 (decode_coding_utf_16, decode_coding_emacs_mule)
8132 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8133 (decode_coding_ccl, decode_coding_charset)
8134 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8135 (decode_coding_iso_2022, decode_coding_emacs_mule)
8136 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8137 <char_offset, last_offset>: Declare EMACS_INT.
8138 (encode_coding_utf_8, encode_coding_utf_16)
8139 (encode_coding_emacs_mule, encode_invocation_designation)
8140 (encode_designation_at_bol, encode_coding_iso_2022)
8141 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8142 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8144 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8145 (encode_invocation_designation): Last argument P_NCHARS is now
8147 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8148 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8150 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8153 * ccl.c (Fccl_execute_on_string): Declare some variables
8156 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8158 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8160 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8162 * process.c (Fformat_network_address): Doc fix.
8164 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8166 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8168 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8170 * keyboard.c (read_char): Call Lisp function help-form-show,
8171 instead of using internal_with_output_to_temp_buffer.
8172 (Qhelp_form_show): New var.
8173 (syms_of_keyboard): Use DEFSYM macro.
8175 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8177 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8179 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8181 * process.c (Flist_processes): Remove to Lisp.
8182 (list_processes_1): Delete.
8184 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8186 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8188 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8190 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8192 Fix more problems found by GCC 4.6.0's static checks.
8194 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8196 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8198 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8200 * xdisp.c (vmessage): Mark as a printf-like function.
8202 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8204 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8206 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8207 printf-like functions.
8208 (tiff_load): Add casts to remove these marks before passing them
8209 to system-supplied API.
8211 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8213 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8214 This avoids several warnings with gcc -Wstrict-overflow.
8215 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8216 directly, rather than having caller test rule sign. This avoids
8217 some unnecessary tests.
8218 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8219 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8220 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8222 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8223 (xfont_open): Avoid unnecessary tests.
8225 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8227 * composite.h, composite.c (composition_gstring_put_cache):
8228 Use EMACS_INT, not int, for length.
8230 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8231 breaking out part of COMPOSITION_DECODE_RULE.
8232 (COMPOSITION_DECODE_RULE): Use it.
8233 * composite.c (get_composition_id): Remove unused local vars,
8234 by using the new macro.
8236 * textprop.c (set_text_properties_1): Change while to do-while,
8237 since the condition is always true at first.
8239 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8240 (interval_deletion_adjustment): Return unsigned value.
8243 * process.c (list_processes_1, create_pty, read_process_output):
8244 (exec_sentinel): Remove vars that were set but not used.
8245 (create_pty): Remove unnecessary "volatile"s.
8246 (Fnetwork_interface_info): Avoid possibility of int overflow.
8247 (read_process_output): Do adaptive read buffering even if carryover.
8248 (read_process_output): Simplify nbytes computation if buffered.
8250 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8252 * syntax.c (scan_words): Remove var that was set but not used.
8253 (update_syntax_table): Use unsigned instead of int.
8255 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8256 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8257 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8259 * print.c (print_error_message): Avoid int overflow.
8261 * font.c (font_list_entities): Redo for clarity,
8262 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8264 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8265 (font_score): Avoid potential overflow in diff calculation.
8267 * fns.c (substring_both): Remove var that is set but not used.
8268 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8270 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8272 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8273 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8274 can always succeed if overflow has undefined behavior.
8276 * search.c (boyer_moore, wordify): Remove vars set but not used.
8277 (wordify): Omit three unnecessary tests.
8279 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8280 All callers changed. This avoids the need for an unused var.
8282 * casefiddle.c (casify_region): Remove var that is set but not used.
8284 * dired.c (file_name_completion): Remove var that is set but not used.
8286 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8288 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8289 (Finsert_file_contents): Remove unnecessary code checking fd.
8291 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8292 Check for integer overflow on size calculations.
8294 * buffer.c (Fprevious_overlay_change): Remove var that is set
8297 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8298 Remove vars that are set but not used.
8299 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8300 (timer_check_2): Mark vars as initialized.
8302 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8304 * image.c (lookup_image): Remove var that is set but not used.
8305 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8307 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8308 that are set but not used.
8310 * xfns.c (make_invisible_cursor): Don't return garbage
8311 if XCreateBitmapFromData fails (Bug#8410).
8313 * xselect.c (x_get_local_selection, x_handle_property_notify):
8314 Remove vars that are set but not used.
8316 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8317 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8319 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8320 Remove var that is set but not used.
8321 (scroll_bar_windows_size): Now size_t, not int.
8322 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8325 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8326 (map_tty_color) [!defined MSDOS]: Likewise.
8328 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8330 * coding.c: Remove vars that are set but not used.
8331 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8332 All callers changed.
8333 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8334 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8335 (decode_coding_charset): Remove vars that are set but not used.
8337 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8338 that is set but not used.
8340 * print.c (print_object): Remove var that is set but not used.
8342 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8343 The gnulib version avoids calling malloc in the usual case,
8344 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8345 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8346 * filelock.c (current_lock_owner): Likewise.
8347 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8348 * sysdep.c: Include allocator.h, careadlinkat.h.
8349 (emacs_no_realloc_allocator): New static constant.
8350 (emacs_readlink): New function.
8351 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8352 ../lib/careadlinkat.h.
8354 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8356 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8357 first non-nil return value).
8359 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8361 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8362 if not defined (Bug#8403).
8364 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8366 * xdisp.c (display_count_lines): Remove parameter `start',
8367 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8368 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8369 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8370 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8371 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8372 and thereabouts. All callers changed.
8373 (get_per_char_metric): Remove parameter `f', unused since
8374 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8376 2011-04-02 Jim Meyering <meyering@redhat.com>
8378 do not dereference NULL upon failed strdup
8379 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8380 (ns_get_family): Likewise.
8382 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8384 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8386 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8388 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8391 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8393 Add lexical binding.
8395 * window.c (Ftemp_output_buffer_show): New fun.
8396 (Fsave_window_excursion):
8397 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8399 * lread.c (lisp_file_lexically_bound_p): New function.
8400 (Fload): Bind Qlexical_binding.
8401 (readevalloop): Remove `evalfun' arg.
8402 Bind Qinternal_interpreter_environment.
8403 (Feval_buffer): Bind Qlexical_binding.
8404 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8406 (syms_of_lread): Declare `lexical-binding'.
8408 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8410 * keyboard.c (eval_dyn): New fun.
8411 (menu_item_eval_property): Use it.
8413 * image.c (parse_image_spec): Use Ffunctionp.
8415 * fns.c (concat, mapcar1): Accept byte-code-functions.
8417 * eval.c (Fsetq): Handle lexical vars.
8418 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8419 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8420 (FletX, Flet): Obey lexical binding.
8421 (Fcommandp): Handle closures.
8422 (Feval): New `lexical' arg.
8423 (eval_sub): New function extracted from Feval. Use it almost
8424 everywhere where Feval was used. Look up vars in lexical env.
8426 (Ffunctionp): Move from subr.el.
8427 (Ffuncall): Handle closures.
8428 (apply_lambda): Remove `eval_flags'.
8429 (funcall_lambda): Handle closures and new byte-code-functions.
8430 (Fspecial_variable_p): New function.
8431 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8432 but without exporting it to Lisp.
8434 * doc.c (Fdocumentation, store_function_docstring):
8435 * data.c (Finteractive_form): Handle closures.
8437 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8440 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8442 (exec_byte_code): New function extracted from Fbyte_code to handle new
8443 calling convention for byte-code-functions. Add new byte-codes.
8445 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8447 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8449 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8451 * xdisp.c (redisplay_internal): Fix prototype.
8453 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8455 * xdisp.c (SCROLL_LIMIT): New macro.
8456 (try_scrolling): Use it when setting scroll_limit.
8457 Limit scrolling to 100 screen lines.
8458 (redisplay_window): Even when falling back on "recentering",
8459 position point in the window according to scroll-conservatively,
8460 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8462 (try_scrolling): When point is above the window, allow searching
8463 as far as scroll_max, or one screenful, to compute vertical
8464 distance from PT to the scroll margin position. This prevents
8465 try_scrolling from unnecessarily failing when
8466 scroll-conservatively is set to a value slightly larger than the
8467 window height. Clean up the case of PT below the margin at bottom
8468 of window: scroll_max can no longer be INT_MAX. When aggressive
8469 scrolling is in use, don't let point enter the opposite scroll
8470 margin as result of the scroll.
8471 (syms_of_xdisp) <scroll-conservatively>: Document the
8472 threshold of 100 lines for never-recentering scrolling.
8474 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8476 * dispextern.h (move_it_by_lines):
8477 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8478 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8479 (message_log_check_duplicate): Remove parameters `prev_bol' and
8480 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8481 (redisplay_internal): Remove parameter `preserve_echo_area',
8482 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8484 * indent.c (Fvertical_motion):
8485 * window.c (window_scroll_pixel_based, Frecenter):
8486 Don't pass `need_y_p' to `move_it_by_lines'.
8488 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8490 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8491 steal a few bits to be more compact.
8492 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8493 Remove unneeded casts.
8495 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8497 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8499 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8500 binding" message (bug#7967).
8502 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8504 Fix more problems found by GCC 4.6.0's static checks.
8506 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8507 Remove unused local var.
8509 * editfns.c (Fmessage_box): Remove unused local var.
8511 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8512 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8513 Omit unused local vars.
8514 * window.c (shrink_windows): Omit unused local var.
8515 * menu.c (digest_single_submenu): Omit unused local var.
8516 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8517 Omit unused local var.
8519 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8520 Don't assume string length fits in int.
8521 (keyremap_step, read_key_sequence): Use size_t for sizes.
8522 (read_key_sequence): Don't check last_real_key_start redundantly.
8524 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8525 instead of alloca (Bug#8344).
8527 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8528 (Fbacktrace_frame): Don't assume nframes fits in int.
8530 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8532 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8535 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8537 * cm.c (calccost): Turn while-do into do-while, for clarity.
8539 * keyboard.c (syms_of_keyboard): Use the same style as later
8540 in this function when indexing through an array. This also
8541 works around GCC bug 48267.
8543 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8545 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8547 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8548 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8550 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8551 This avoids undefined behavior on integer overflow, and is a bit
8552 more convenient anyway since it is compared to a size_t variable.
8554 Variadic C functions now count arguments with size_t, not int.
8555 This avoids an unnecessary limitation on 64-bit machines, which
8556 caused (substring ...) to crash on large vectors (Bug#8344).
8557 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8558 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8559 All variadic functions and their callers changed accordingly.
8560 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8561 * data.c (arith_driver, float_arith_driver): Likewise.
8562 * editfns.c (general_insert_function): Likewise.
8563 * eval.c (struct backtrace.nargs, interactive_p)
8564 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8565 (funcall_lambda, mark_backtrace): Likewise.
8566 * fns.c (concat): Likewise.
8567 * frame.c (x_set_frame_parameters): Likewise.
8568 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8569 0 if not found, not -1. All callers changed.
8571 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8572 (stack_copy_size): Now size_t, not int.
8573 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8575 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8577 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8578 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8579 All callers changed.
8581 * lisp.h (multibyte_char_to_unibyte):
8582 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8583 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8584 * character.h (CHAR_TO_BYTE8):
8585 * cmds.c (internal_self_insert):
8586 * editfns.c (general_insert_function):
8587 * keymap.c (push_key_description):
8588 * search.c (Freplace_match):
8589 * xdisp.c (message_dolog, set_message_1): All callers changed.
8591 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8593 * keyboard.c (safe_run_hook_funcall): New function.
8594 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8595 don't set the hook to nil, but remove the offending function instead.
8596 (Qcommand_hook_internal): Remove, unused.
8597 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8598 Vcommand_hook_internal.
8600 * eval.c (enum run_hooks_condition): Remove.
8601 (funcall_nil, funcall_not): New functions.
8602 (run_hook_with_args): Call each function through a `funcall' argument.
8603 Remove `cond' argument, now redundant.
8604 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8605 (Frun_hook_with_args_until_failure): Adjust accordingly.
8606 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8608 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8610 * dispextern.h (string_buffer_position): Remove declaration.
8612 * print.c (strout): Remove parameter `multibyte', unused since
8613 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8615 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8616 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8617 All callers changed.
8619 * w32.c (_wsa_errlist): Use braces for struct initializers.
8621 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8622 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8623 All callers changed.
8624 (string_buffer_position): Likewise. Also, make static (it's never
8625 used outside xdisp.c).
8626 (cursor_row_p): Remove parameter `w', unused since
8627 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8628 (decode_mode_spec): Remove parameter `precision', introduced during
8629 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8630 All callers changed.
8632 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8634 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8636 2011-03-27 Anders Lindgren <andlind@gmail.com>
8638 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8639 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8640 (ns_update_auto_hide_menu_bar): New functions.
8641 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8642 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8643 ns_constrain_all_frames.
8644 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8645 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8647 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8649 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8651 2011-03-27 Glenn Morris <rgm@gnu.org>
8653 * syssignal.h: Replace RETSIGTYPE with void.
8654 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8655 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8656 Replace SIGTYPE with void everywhere.
8657 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8658 * s/template.h (SIGTYPE): Remove commented out definition.
8660 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8662 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8663 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8665 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8667 * w32.c (read_unc_volume): Use parameter `henum', instead of
8668 global variable `wget_enum_handle'.
8670 * keymap.c (describe_vector): Remove parameters `indices' and
8671 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8672 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8674 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8676 * keyboard.c (timer_check): Remove parameter `do_it_now',
8677 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8678 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8679 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8681 * keyboard.c (read_char):
8682 * w32menu.c (w32_menu_display_help):
8683 * xmenu.c (show_help_event, menu_help_callback):
8684 Adjust calls to `show_help_echo'.
8686 * gtkutil.c (xg_maybe_add_timer):
8687 * keyboard.c (readable_events):
8688 * process.c (wait_reading_process_output):
8689 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8691 * insdel.c (adjust_markers_gap_motion):
8692 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8693 (gap_left, gap_right): Don't call it.
8695 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8697 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8698 incurred during fontification.
8700 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8702 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8703 (DEFVAR_PER_BUFFER): Don't pass it.
8705 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8706 (scrolling_window): Don't pass it.
8708 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8710 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8712 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8714 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8715 of variables specific to SELinux and computation of `encoded_absname'.
8717 * image.c (XPutPixel): Remove unused variable `height'.
8719 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8721 * unexw32.c (get_section_info): Remove unused variable `section'.
8723 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8724 (system_process_attributes): Remove unused variable `sess'.
8725 (sys_read): Remove unused variable `err'.
8727 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8728 (w32_wnd_proc): Remove unused variable `isdead'.
8729 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8730 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8731 (x_create_tip_frame): Remove unused variable `tem'.
8733 * w32inevt.c (w32_console_read_socket):
8734 Remove unused variable `no_events'.
8736 * w32term.c (x_draw_composite_glyph_string_foreground):
8737 Remove unused variable `width'.
8739 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8741 * w32term.c (x_set_glyph_string_clipping):
8742 Don't pass uninitialized region to CombineRgn.
8744 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8746 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8747 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8748 (Fx_close_connection): Remove unused variable `i'.
8750 * w32font.c (w32font_draw): Return number of glyphs.
8751 (w32font_open_internal): Remove unused variable `i'.
8752 (w32font_driver): Add missing initializer.
8754 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8755 (fill_in_menu): Remove unused variable `items_added'.
8757 * w32term.c (last_mouse_press_frame): Remove static global variable.
8758 (w32_clip_to_row): Remove unused variable `f'.
8759 (x_delete_terminal): Remove unused variable `i'.
8761 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8762 (NOTHING): Remove unused static global variable.
8763 (uniscribe_check_otf): Remove unused variable `table'.
8764 (uniscribe_font_driver): Add missing initializers.
8766 2011-03-23 Julien Danjou <julien@danjou.info>
8768 * term.c (Fsuspend_tty, Fresume_tty):
8769 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8770 * window.c (temp_output_buffer_show):
8771 * insdel.c (signal_before_change):
8772 * frame.c (Fhandle_switch_frame):
8773 * fileio.c (Fdo_auto_save):
8774 * emacs.c (Fkill_emacs):
8775 * editfns.c (save_excursion_restore):
8776 * cmds.c (internal_self_insert):
8777 * callint.c (Fcall_interactively):
8778 * buffer.c (Fkill_all_local_variables):
8779 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8781 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8782 unconditionally since it does the check itself.
8784 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8786 Fix more problems found by GCC 4.5.2's static checks.
8788 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8789 the first time through the loop, since we know p0 < p1 then.
8790 This also avoids a gcc -Wstrict-overflow warning.
8792 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8793 leading to a memory leak, possible in functions like
8794 load_charset_map_from_file that can allocate an unbounded number
8795 of objects (Bug#8318).
8797 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8798 that could (at least in theory) be that large.
8800 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8801 This is less likely to overflow, and avoids undefined behavior if
8802 overflow does occur. All callers changed. Use strtoul to scan
8803 for the unsigned long integer.
8804 (pint2hrstr): Simplify and tune code slightly.
8805 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8807 * scroll.c (do_scrolling): Work around GCC bug 48228.
8808 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8810 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8811 This also avoids a warning with gcc -Wstrict-overflow.
8812 (validate_x_resource_name): Simplify count usage.
8813 This also avoids a warning with gcc -Wstrict-overflow.
8815 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8818 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8820 * process.c (Fmake_network_process): Use socklen_t, not int,
8821 where POSIX says socklen_t is required in portable programs.
8822 This fixes a porting bug on hosts like 64-bit HP-UX, where
8823 socklen_t is wider than int (Bug#8277).
8824 (Fmake_network_process, server_accept_connection):
8825 (wait_reading_process_output, read_process_output):
8828 * process.c: Rename or move locals to avoid shadowing.
8829 (list_processes_1, Fmake_network_process):
8830 (read_process_output_error_handler, exec_sentinel_error_handler):
8831 Rename or move locals.
8832 (Fmake_network_process): Define label "retry_connect" only if needed.
8833 (Fnetwork_interface_info): Fix pointer signedness.
8834 (process_send_signal): Add cast to avoid pointer signedness problem.
8835 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8836 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8838 Make tparam.h and terminfo.c consistent.
8839 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8840 Include tparam.h instead, since it declares them.
8841 * cm.h (PC): Remove extern decl; tparam.h now does this.
8842 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8843 * terminfo.c: Include tparam.h, to check interfaces.
8844 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8845 (tparam): Adjust signature to match interface in tparam.h;
8846 this removes some undefined behavior. Check that outstring and len
8847 are zero, which they always are with Emacs.
8848 * tparam.h (PC, BC, UP): New extern decls.
8850 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8851 (xftfont_open): Rename locals to avoid shadowing.
8853 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8854 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8855 (OTF_TAG_SYM): Omit macro if not needed.
8856 (ftfont_list): Remove unused local.
8857 (get_adstyle_property, ftfont_pattern_entity):
8858 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8859 Rename locals to avoid shadowing.
8861 * xfont.c (xfont_list_family): Mark var as initialized.
8863 * xml.c (make_dom): Now static.
8865 * composite.c (composition_compute_stop_pos): Rename local to
8867 (composition_reseat_it): Remove unused locals.
8868 (find_automatic_composition, composition_adjust_point): Likewise.
8869 (composition_update_it): Mark var as initialized.
8870 (find_automatic_composition): Mark vars as initialized,
8871 with a FIXME (Bug#8290).
8873 character.h: Rename locals to avoid shadowing.
8874 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8875 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8876 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8877 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8880 * textprop.c (property_change_between_p): Remove; unused.
8882 * intervals.c (interval_start_pos): Now static.
8884 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8886 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8887 Rename locals to avoid shadowing.
8889 * sound.c (wav_play, au_play, Fplay_sound_internal):
8890 Fix pointer signedness.
8891 (alsa_choose_format): Remove unused local var.
8892 (wav_play): Initialize a variable to 0, to prevent undefined
8893 behavior (Bug#8278).
8895 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8897 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8899 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8900 clobbering (Bug#8298).
8901 * sysdep.c (sys_subshell): Likewise.
8902 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8904 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8905 This should get cleaned up, so that child_setup has the
8906 same signature on all platforms.
8908 * callproc.c (call_process_cleanup): Now static.
8909 (relocate_fd): Rename locals to avoid shadowing.
8911 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8913 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8914 not to be necessary, and produces flickering.
8916 2011-03-20 Glenn Morris <rgm@gnu.org>
8918 * config.in: Remove file.
8920 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8922 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8923 are now in src/globals.h.
8924 (syms_of_minibuf): Remove spurious & from previous change.
8926 2011-03-20 Leo <sdl.web@gmail.com>
8928 * minibuf.c (completing-read-function): New variable.
8929 (completing-read-default): Rename from completing-read.
8930 (completing-read): Call completing-read-function.
8932 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8934 * xfaces.c (Fx_load_color_file):
8935 Read color file from absolute filename (bug#8250).
8937 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8939 * makefile.w32-in: Update dependencies.
8941 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8943 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8945 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8947 Fix more problems found by GCC 4.5.2's static checks.
8949 * process.c (make_serial_process_unwind, send_process_trap):
8950 (sigchld_handler): Now static.
8952 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8953 That way, the code declares only the vars that it needs.
8954 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8955 * s/cygwin.h (PTY_ITERATION): Likewise.
8956 * s/darwin.h (PTY_ITERATION): Likewise.
8957 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8959 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8960 * process.c (allocate_pty): Don't declare stb unless it's needed.
8962 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8963 (CONSTANTLIM): Remove; unused.
8964 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8965 Define only if needed.
8967 * unexelf.c (unexec): Name an expression,
8968 to avoid gcc -Wbad-function-cast warning.
8969 Use a different way to cause a compilation error if anyone uses
8970 n rather than nn, a way that does not involve shadowing.
8971 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8973 * deps.mk (unexalpha.o): Remove; unused.
8975 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8976 * unexec.h: New file.
8977 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8978 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8980 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8981 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8982 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8983 Change as necessary to match prototype in unexec.h.
8985 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8987 (back_comment, skip_chars): Mark vars as initialized.
8989 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8990 Rename locals to avoid shadowing.
8992 * lread.c (read1): Rewrite so as not to use empty "else".
8993 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8995 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8997 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8998 warning when compiling print.c.
9000 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9001 instead of using an uninitialized var.
9002 (font_sort_entities): Mark var as initialized.
9004 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9006 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9007 pointers to constants.
9008 (font_parse_fcname): Remove unused vars.
9009 (font_delete_unmatched): Now static.
9010 (font_get_spec): Remove; unused.
9011 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9012 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9013 Rename or move locals to avoid shadowing.
9015 * fns.c (require_nesting_list, require_unwind): Now static.
9016 (Ffillarray): Rename locals to avoid shadowing.
9018 * floatfns.c (domain_error2): Define only if needed.
9019 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9021 * alloc.c (mark_backtrace): Move decl from here ...
9022 * lisp.h: ... to here, so that it can be checked.
9024 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9025 (Fdefvar): Rewrite so as not to use empty "else".
9026 (lisp_indirect_variable): Name an expression,
9027 to avoid gcc -Wbad-function-cast warning.
9028 (Fdefvar): Rename locals to avoid shadowing.
9030 * callint.c (quotify_arg, quotify_args): Now static.
9031 (Fcall_interactively): Rename locals to avoid shadowing.
9032 Use const pointer when appropriate.
9034 * lisp.h (get_system_name, get_operating_system_release):
9035 Move decls here, to check interfaces.
9036 * process.c (get_operating_system_release): Move decl to lisp.h.
9037 * xrdb.c (get_system_name): Likewise.
9038 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9039 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9040 some of which prompt warnings from gcc -Wbad-function-cast.
9041 (Fformat_time_string, Fencode_time, Finsert_char):
9042 (Ftranslate_region_internal, Fformat):
9043 Rename or remove local vars to avoid shadowing.
9044 (Ftranslate_region_internal): Mark var as initialized.
9046 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9049 * lisp.h (eassert): Check that the argument compiles, even if
9050 ENABLE_CHECKING is not defined.
9052 * data.c (Findirect_variable): Name an expression, to avoid
9053 gcc -Wbad-function-cast warning.
9054 (default_value, arithcompare, arith_driver, arith_error): Now static.
9055 (store_symval_forwarding): Rename local to avoid shadowing.
9056 (Fmake_variable_buffer_local, Fmake_local_variable):
9057 Mark variables as initialized.
9058 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9060 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9061 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9062 Rename locals to avoid shadowing.
9063 (mark_stack): Move local variables into the #ifdef region where
9065 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9066 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9068 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9069 (GC_STRING_CHARS): Remove; not used.
9070 (Fmemory_limit): Cast sbrk's returned value to char *.
9072 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9073 avoids undefined behavior in theory.
9075 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9077 Use functions, not macros, for up- and down-casing (Bug#8254).
9078 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9079 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9080 to use the following functions instead of these macros.
9081 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9082 EMACS_INT, since callers assume the returned value fits in int.
9083 (upcase1): Likewise, for UPCASE_TABLE.
9084 (uppercasep, lowercasep, upcase): New static inline functions.
9085 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9086 the race-condition problem in the old DOWNCASE.
9088 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9089 Rename locals to avoid shadowing.
9090 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9091 (regex_compile, re_search_2, re_match_2_internal):
9092 Remove unused local vars.
9093 (FREE_VAR): Rewrite so as not to use empty "else",
9094 which gcc can warn about.
9095 (regex_compile, re_match_2_internal): Mark locals as initialized.
9096 (RETALLOC_IF): Define only if needed.
9097 (WORDCHAR_P): Likewise. This one is never needed, but is used
9098 only in a comment talking about a compiler bug, so put inside
9099 the #if 0 of that comment.
9100 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9101 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9104 * search.c (boyer_moore): Rename locals to avoid shadowing.
9105 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9106 (PREV_CHAR_BOUNDARY): Likewise.
9108 * search.c (simple_search): Remove unused var.
9110 * dired.c (compile_pattern): Move decl from here ...
9111 * lisp.h: ... to here, so that it can be checked.
9112 (struct re_registers): New forward decl.
9114 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9116 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9118 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9119 Rename locals to avoid shadowing.
9120 (Fvertical_motion): Mark locals as initialized.
9122 * casefiddle.c (casify_object, casify_region): Now static.
9123 (casify_region): Mark local as initialized.
9125 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9127 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9128 New macros, so that the caller can use some names other than
9129 gcpro1, gcpro2, etc.
9130 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9132 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9133 argument, for consistency with GCPRO2_VAR, etc: it is now the
9134 prefix of the variable, not the variable itself. All uses
9136 * dired.c (directory_files_internal, file_name_completion):
9137 Rename locals to avoid shadowing.
9139 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9140 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9141 dired.c's scmp function, had undefined behavior.
9142 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9143 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9144 * buffer.h: ... to here, because these macros use current_buffer,
9145 and the new implementation with inline functions needs to have
9146 current_buffer in scope now, rather than later when the macros
9148 (downcase, upcase1): New static inline functions.
9149 (DOWNCASE, UPCASE1): Reimplement using these functions.
9150 This avoids undefined behavior in expressions like
9151 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9152 from race conditions in accessing the global variables
9153 case_temp1 and case_temp2.
9154 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9155 * lisp.h (case_temp1, case_temp2): Remove their decls.
9156 * character.h (ASCII_CHAR_P): Move from here ...
9157 * lisp.h: ... to here, so that the inline functions mentioned
9160 * dired.c (directory_files_internal_unwind): Now static.
9162 * fileio.c (file_name_as_directory, directory_file_name):
9163 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9165 (file_name_as_directory): Use const pointers when appropriate.
9166 (Fexpand_file_name): Likewise. In particular, newdir might
9167 point at constant storage, so make it a const pointer.
9168 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9169 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9171 (Fset_file_times, Finsert_file_contents, auto_save_error):
9172 Rename locals to avoid shadowing.
9174 * minibuf.c (choose_minibuf_frame_1): Now static.
9175 (Ftry_completion, Fall_completions): Rename or remove locals
9178 * marker.c (bytepos_to_charpos): Remove; unused.
9180 * lisp.h (verify_bytepos, count_markers): New decls,
9181 so that gcc does not warn that these functions aren't declared.
9183 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9184 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9185 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9186 (copy_text): Remove unused local var.
9188 * filelock.c (within_one_second): Now static.
9189 (lock_file_1): Rename local to avoid shadowing.
9191 * buffer.c (fix_overlays_before): Mark locals as initialized.
9192 (fix_start_end_in_overlays): Likewise. This function should be
9193 simplified by using pointers-to-pointers, but that's a different
9195 (switch_to_buffer_1): Now static.
9196 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9197 (report_overlay_modification): Rename locals to avoid shadowing.
9199 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9200 Fix pointer signedness issue.
9201 (sys_subshell): Mark local as volatile if checking for lint,
9202 to suppress a gcc -Wclobbered warning that does not seem to be right.
9203 (MAXPATHLEN): Define only if needed.
9205 * process.c (serial_open, serial_configure): Move decls from here ...
9206 * systty.h: ... to here, so that they can be checked.
9208 * fns.c (get_random, seed_random): Move extern decls from here ...
9209 * lisp.h: ... to here, so that they can be checked.
9211 * sysdep.c (reset_io): Now static.
9212 (wait_for_termination_signal): Remove; unused.
9214 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9215 (copy_keymap_item, append_key, push_text_char_description):
9217 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9218 (DENSE_TABLE_SIZE): Remove; unused.
9219 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9220 (describe_map_tree):
9221 Rename locals to avoid shadowing.
9223 * keyboard.c: Declare functions static if they are not used elsewhere.
9224 (echo_char, echo_dash, cmd_error, top_level_2):
9225 (poll_for_input, handle_async_input): Now static.
9226 (read_char, kbd_buffer_get_event, make_lispy_position):
9227 (make_lispy_event, make_lispy_movement, apply_modifiers):
9228 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9229 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9230 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9231 (read_key_sequence, read_char): Mark locals as initialized.
9232 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9234 * keyboard.h (make_ctrl_char): New decl.
9235 (mark_kboards): Move decl here ...
9236 * alloc.c (mark_kboards): ... from here.
9238 * lisp.h (force_auto_save_soon): New decl.
9240 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9241 (DEFINE_DUMMY_FUNCTION): New macro.
9242 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9244 (main): Add casts to avoid warnings
9245 if GCC considers string literals to be constants.
9247 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9249 * dbusbind.c: Pointer signedness fixes.
9250 (xd_signature, xd_append_arg, xd_initialize):
9251 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9252 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9253 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9254 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9256 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9257 if GCC considers string literals to be constants.
9258 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9260 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9262 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9263 (print_preprocess, print_object): New macro to fix last change.
9265 * print.c (print_preprocess): Don't forget font objects.
9267 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9269 * emacs.c (USAGE3): Doc fixes.
9271 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9273 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9276 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9278 * lisp.h (VWindow_system, Qfile_name_history):
9279 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9280 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9281 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9283 * w32select.c: Don't #include "keyboard.h".
9284 (run_protected): Add extern declaration for waiting_for_input.
9286 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9287 * w32console.c (detect_input_pending, read_input_pending)
9288 (encode_terminal_code):
9289 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9290 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9291 (w32_system_caret_y, Qfile_name_history):
9292 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9293 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9294 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9295 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9296 * w32proc.c (Qlocal, report_file_error):
9297 * w32term.c (Vwindow_system, updating_frame):
9298 * w32uniscribe.c (initialized, uniscribe_font_driver):
9299 Remove unneeded extern declarations.
9301 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9303 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9305 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9307 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9308 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9309 These macros can no longer be used for assignment.
9311 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9312 Assign struct members directly, instead of using BUF_BEGV etc.
9313 (record_buffer_markers, fetch_buffer_markers): New functions for
9314 recording and fetching special buffer markers.
9315 (set_buffer_internal_1, set_buffer_temp): Use them.
9317 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9319 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9321 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9322 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9324 * xdisp.c (hscroll_window_tree):
9325 (reconsider_clip_changes): Use PT instead of BUF_PT.
9327 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9329 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9330 $(EMACS_ROOT)/lib/intprops.h.
9332 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9334 Fix more problems found by GCC 4.5.2's static checks.
9336 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9337 to unsigned char * to avoid compiler diagnostic.
9338 (xg_free_frame_widgets): Make it clear that a local variable is
9339 needed only if USE_GTK_TOOLTIP.
9340 (gdk_window_get_screen): Make it clear that this macro is needed
9341 only if USE_GTK_TOOLTIP.
9342 (int_gtk_range_get_value): New function, which avoids a diagnostic
9343 from gcc -Wbad-function-cast.
9344 (xg_set_toolkit_scroll_bar_thumb): Use it.
9345 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9346 diagnostic from gcc -Wbad-function-cast.
9347 (get_utf8_string, xg_get_file_with_chooser):
9348 Rename locals to avoid shadowing.
9349 (create_dialog): Move locals to avoid shadowing.
9351 * xgselect.c (xg_select): Remove unused var.
9353 * image.c (four_corners_best): Mark locals as initialized.
9354 (gif_load): Initialize transparent_p to zero (Bug#8238).
9355 Mark another local as initialized.
9356 (my_png_error, my_error_exit): Mark with NO_RETURN.
9358 * image.c (clear_image_cache): Now static.
9359 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9360 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9361 (x_edge_detection): Remove unnecessary cast that
9362 gcc -Wbad-function-cast diagnoses.
9363 (gif_load): Fix pointer signedness.
9364 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9365 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9367 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9369 Improve quality of tests for time stamp overflow.
9370 For example, without this patch (encode-time 0 0 0 1 1
9371 1152921504606846976) returns the obviously-bogus value (-948597
9372 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9373 reports time overflow. See
9374 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9375 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9376 * editfns.c: Include limits.h and intprops.h.
9377 (TIME_T_MIN, TIME_T_MAX): New macros.
9378 (time_overflow): Move earlier, to before first use.
9379 (hi_time, lo_time): New functions, for an accurate test for
9381 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9382 (Fget_internal_run_time): Don't assume time_t fits in int.
9383 (make_time): Use list2 instead of Fcons twice.
9384 (Fdecode_time): More accurate test for out-of-range times.
9385 (check_tm_member): New function.
9386 (Fencode_time): Use it, to test for out-of-range times.
9387 (lisp_time_argument): Don't rely on undefined left-shift and
9388 right-shift behavior when checking for time stamp overflow.
9390 * editfns.c (time_overflow): New function, refactoring common code.
9391 (Fformat_time_string, Fdecode_time, Fencode_time):
9392 (Fcurrent_time_string): Use it.
9394 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9395 * dired.c (make_time): Move to ...
9396 * editfns.c (make_time): ... here.
9397 * systime.h: Note the move.
9399 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9401 * fringe.c (update_window_fringes): Remove unused variables.
9403 * unexmacosx.c (copy_data_segment): Also copy __got section.
9406 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9408 * termcap.c [MSDOS]: Include "msdos.h".
9409 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9410 Constify `char *' arguments and their references according to
9411 prototypes in tparam.h.
9413 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9415 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9416 Adapt all references accordingly.
9418 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9420 2011-03-11 Tom Tromey <tromey@redhat.com>
9422 * buffer.c (syms_of_buffer): Remove obsolete comment.
9424 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9426 * termhooks.h (encode_terminal_code): Declare prototype.
9428 * msdos.c (encode_terminal_code): Don't declare prototype.
9430 * term.c (encode_terminal_code): Now external again, used by
9431 w32console.c and msdos.c.
9433 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9434 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9436 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9438 Fix some minor problems found by GCC 4.5.2's static checks.
9440 * fringe.c (update_window_fringes): Mark locals as initialized
9442 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9444 * alloc.c (mark_fringe_data): Move decl from here ...
9445 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9446 to check its interface.
9447 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9449 * fontset.c (free_realized_fontset): Now static.
9450 (Fset_fontset_font): Rename local to avoid shadowing.
9451 (fontset_font): Mark local as initialized.
9452 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9454 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9456 * xselect.c (x_disown_buffer_selections): Remove; not used.
9457 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9458 (x_own_selection, Fx_disown_selection_internal): Rename locals
9460 (x_handle_dnd_message): Remove local to avoid shadowing.
9462 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9463 so that the caller can use some name other than gcpro1.
9464 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9465 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9466 (Fx_backspace_delete_keys_p):
9467 Use them to avoid shadowing, and rename vars to avoid shadowing.
9468 (x_decode_color, x_set_name, x_window): Now static.
9469 (Fx_create_frame): Add braces to silence GCC warning.
9470 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9471 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9472 Remove unused locals.
9473 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9474 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9475 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9478 * xterm.h (x_mouse_leave): New decl.
9480 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9481 Remove unused functions.
9482 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9483 (x_calc_absolute_position): Now static.
9484 (XTread_socket): Don't define label "out" unless it's used.
9485 Don't declare local "event" unless it's used.
9486 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9487 unless they are used.
9488 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9489 (x_fatal_error_signal): Remove; not used.
9490 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9491 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9492 (x_error_catcher, x_connection_closed, x_error_handler):
9493 (x_error_quitter, xembed_send_message, x_iconify_frame):
9494 (my_log_handler): Rename locals to avoid shadowing.
9495 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9496 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9498 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9499 Rename or move locals to avoid shadowing.
9500 (tty_defined_color, merge_face_heights): Now static.
9501 (free_realized_faces_for_fontset): Remove; not used.
9502 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9503 does not deduce is never used uninitialized.
9504 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9505 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9507 * terminal.c (store_terminal_param): Now static.
9509 * xmenu.c (menu_highlight_callback): Now static.
9510 (set_frame_menubar): Remove unused local.
9511 (xmenu_show): Rename parameter to avoid shadowing.
9512 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9513 since they might point to immutable storage.
9514 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9515 since it's unused otherwise.
9517 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9518 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9519 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9520 avoids a gcc -Wuninitialized diagnostic.
9521 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9522 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9523 does not deduce are never used uninitialized.
9525 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9527 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9528 * window.c (window_loop, size_window):
9529 (run_window_configuration_change_hook, enlarge_window): Likewise.
9531 * window.c (display_buffer): Now static.
9532 (size_window): Mark variables that gcc -Wuninitialized
9533 does not deduce are never used uninitialized.
9534 * window.h (check_all_windows): New decl, to forestall
9535 gcc -Wmissing-prototypes diagnostic.
9536 * dispextern.h (bidi_dump_cached_states): Likewise.
9538 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9540 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9542 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9543 and to avoid gcc -Wuninitialized warning.
9544 (load_charset_map): Mark variables that gcc -Wuninitialized
9545 does not deduce are never used uninitialized.
9546 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9548 * coding.c (coding_set_source, coding_set_destination):
9549 Use "else { /* comment */ }" rather than "else /* comment */;"
9550 for clarity, and to avoid gcc -Wempty-body warning.
9551 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9552 a block, when the outer 'i' will do.
9553 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9554 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9555 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9556 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9557 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9558 Rename locals to avoid shadowing.
9559 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9560 * coding.c (emacs_mule_char, encode_invocation_designation):
9561 Now static, since they're not used elsewhere.
9562 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9563 (decode_coding_object, encode_coding_object, detect_coding_system):
9564 (decode_coding_emacs_mule): Mark variables that gcc
9565 -Wuninitialized does not deduce are never used uninitialized.
9566 (detect_coding_iso_2022): Initialize a local variable that might
9567 be used uninitialized. Leave a FIXME because it's not clear that
9568 this initialization is needed. (Bug#8211)
9569 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9570 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9571 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9572 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9573 Remove unused macros.
9575 * category.c (hash_get_category_set): Remove unused local var.
9576 (copy_category_table): Now static, since it's not used elsewhere.
9577 * character.c (string_count_byte8): Likewise.
9579 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9580 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9582 * chartab.c (copy_sub_char_table): Now static, since it's not used
9584 (sub_char_table_ref_and_range, char_table_ref_and_range):
9585 Rename locals to avoid shadowing.
9586 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9588 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9589 (BIDI_BOB): Remove unused macro.
9591 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9592 deduce are never used uninitialized.
9593 * term.c (encode_terminal_code): Likewise.
9595 * term.c (encode_terminal_code): Now static. Remove unused local.
9597 * tparam.h: New file.
9598 * term.c, tparam.h: Include it.
9599 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9600 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9601 Move these decls to tparam.h, and make them agree with what
9602 is actually in tparam.c. The previous trick of using incompatible
9603 decls in different modules does not conform to the C standard.
9604 All callers of tparam changed to use tparam's actual API.
9605 * tparam.c (tparam1, tparam, tgoto):
9606 Use const pointers where appropriate.
9608 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9609 * cm.h (struct cm): Likewise.
9610 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9611 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9612 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9613 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9614 (turn_on_face, init_tty): Likewise.
9615 * termchar.h (struct tty_display_info): Likewise.
9617 * term.c (term_mouse_position): Rename local to avoid shadowing.
9619 * alloc.c (mark_ttys): Move decl from here ...
9620 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9622 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9624 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9626 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9628 * search.c (compile_pattern_1): Remove argument regp, unused since
9629 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9630 (compile_pattern): Don't pass it.
9632 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9634 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9635 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9637 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9639 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9641 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9642 gdk_window_get_screen, gdk_window_get_geometry,
9643 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9644 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9645 (xg_get_pixbuf_from_pixmap): New function.
9646 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9647 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9648 Call xg_get_pixbuf_from_pixmap instead of
9649 gdk_pixbuf_get_from_drawable.
9650 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9651 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9652 (xg_check_special_colors): Use GtkStyleContext and its functions
9654 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9655 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9656 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9657 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9658 Call gtk_widget_get_preferred_size.
9659 (xg_frame_resized): gdk_window_get_geometry only takes 5
9661 (xg_win_to_widget, xg_event_is_for_menubar):
9662 Call gdk_x11_window_lookup_for_display.
9663 (xg_set_widget_bg): New function.
9664 (delete_cb): New function.
9665 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9666 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9667 (xg_set_background_color): Call xg_set_widget_bg.
9668 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9669 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9670 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9671 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9673 (update_frame_tool_bar): Call gtk_widget_hide.
9674 (xg_initialize): Use GDK_KEY_g.
9676 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9678 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9680 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9681 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9682 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9684 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9686 * w32xfns.c (select_palette): Check success of RealizePalette against
9687 GDI_ERROR, not zero.
9689 See ChangeLog.11 for earlier changes.
9695 Copyright (C) 2011 Free Software Foundation, Inc.
9697 This file is part of GNU Emacs.
9699 GNU Emacs is free software: you can redistribute it and/or modify
9700 it under the terms of the GNU General Public License as published by
9701 the Free Software Foundation, either version 3 of the License, or
9702 (at your option) any later version.
9704 GNU Emacs is distributed in the hope that it will be useful,
9705 but WITHOUT ANY WARRANTY; without even the implied warranty of
9706 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9707 GNU General Public License for more details.
9709 You should have received a copy of the GNU General Public License
9710 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.