1 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4 and turn window cursor on if cleared (Bug#9415).
6 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
8 * search.c (boyer_moore): Take unibyte characters from pattern
11 2011-09-18 Eli Zaretskii <eliz@gnu.org>
13 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
15 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
17 Fix minor problem found by static checking.
18 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
19 initialized, to pacify gcc -Wuninitialized.
21 * fileio.c: Report proper errno when syscall falls.
22 (Finsert_file_contents): Save and restore errno,
23 so that report_file_error outputs the correct diagnostic.
24 (Fwrite_region) [CLASH_DETECTION]: Likewise.
26 2011-09-18 Eli Zaretskii <eliz@gnu.org>
28 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
30 2011-09-17 Eli Zaretskii <eliz@gnu.org>
32 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
33 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
35 2011-09-17 Eli Zaretskii <eliz@gnu.org>
37 * xdisp.c (reseat_at_next_visible_line_start): Keep information
38 about the current paragraph and restore it after the call to
41 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
42 (bidi_find_paragraph_start): Search back for paragraph beginning
43 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
44 (bidi_move_to_visually_next): Only trigger paragraph-related
45 computations when the last character is a newline or at EOB, not
46 just any NEUTRAL_B. (Bug#9470)
48 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
49 truncated lines if point is covered by a display string. (Bug#9524)
51 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
53 * xselect.c: Relax test for outgoing X longs (Bug#9498).
54 (cons_to_x_long): New function.
55 (lisp_data_to_selection_data): Use it. Correct the test for
56 short-versus-long data; it was negated. Break out of vector
57 loop, for efficiency, when a long datum is discovered.
59 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
61 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
63 2011-09-16 Eli Zaretskii <eliz@gnu.org>
65 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
66 GCC PR/17406) by declaring this function with external scope.
68 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
70 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
71 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
73 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
75 * editfns.c (Fformat): Correctly handle text properties on "%%".
77 2011-09-15 Eli Zaretskii <eliz@gnu.org>
79 * xterm.c (x_draw_composite_glyph_string_foreground):
80 * w32term.c (x_draw_composite_glyph_string_foreground):
81 * term.c (encode_terminal_code):
82 * composite.c (composition_update_it, get_composition_id):
83 * xdisp.c (get_next_display_element)
84 (fill_composite_glyph_string): Add comments about special meaning
85 of TAB characters in a composition.
87 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
89 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
90 This occurs when processing a multibyte format.
91 Problem reported by Wolfgang Jenker.
93 2011-09-15 Johan Bockgård <bojohan@gnu.org>
95 * xdisp.c (try_cursor_movement): Only check for exact match if
96 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
98 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
100 Remove unused external symbols.
101 * dispextern.h (calc_pixel_width_or_height): Remove decl.
102 * xdisp.c (calc_pixel_width_or_height): Now static.
103 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
104 * indent.c (check_display_width):
105 * w32term.c: Fix comment to match code.
106 * xterm.c, xterm.h (x_catching_errors): Remove.
108 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
110 * xselect.c: Use signed conversions more consistently (Bug#9498).
111 (selection_data_to_lisp_data): Assume incoming selection data are
112 signed integers, not unsigned. This is to be consistent with
113 outgoing selection data, which was modified to use signed integers
114 in as part of the fix to Bug#9196 in response to Jan D.'s comment
115 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
116 expects long, not unsigned long.
118 2011-09-14 Eli Zaretskii <eliz@gnu.org>
120 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
121 computation of loop end. Reported by Johan Bockgård
124 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
126 * frame.c (Fother_visible_frames_p): Function deleted.
128 2011-09-12 Eli Zaretskii <eliz@gnu.org>
130 * indent.c (compute_motion): Process display vector front to back
131 rather than the other way around. (Bug#2496)
133 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
135 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
137 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
139 * minibuf.c (Fread_from_minibuffer): Doc fix.
141 2011-09-11 Eli Zaretskii <eliz@gnu.org>
143 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
144 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
146 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
148 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
149 value for non-existent files.
151 2011-09-11 Eli Zaretskii <eliz@gnu.org>
153 * fileio.c (Finsert_file_contents): If the file cannot be opened,
154 set its "size" to -1. This will set the modtime_size field of
155 the corresponding buffer to -1, which is what
156 verify-visited-file-modtime expects for files that do not exist.
159 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
161 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
163 * lisp.h: ... from here. push_key_description is no longer
164 defined in keyboard.c, so its declaration should not be in
165 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
166 logically belongs with push_key_description.
168 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
170 * buffer.h: Include <sys/types.h> instead of <time.h>.
171 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
172 Problem reported by Herbert J. Skuhra.
174 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
176 * xml.c (parse_region): Make the parsing work for
177 non-comment-starting XML files again (bug#9144).
179 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
181 * image.c (gif_load): Fix calculation of bottom and right corner.
184 2011-09-10 Eli Zaretskii <eliz@gnu.org>
186 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
187 redisplay in small windows.
189 2011-09-09 Eli Zaretskii <eliz@gnu.org>
191 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
193 2011-09-08 Martin Rudalics <rudalics@gmx.at>
195 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
196 Operate on live windows only.
198 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
200 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
202 2011-09-07 Eli Zaretskii <eliz@gnu.org>
204 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
205 only under bidi iteration.
207 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
209 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
211 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
213 isnan: Fix porting problem to Solaris 10 with bundled gcc.
214 Without this fix, the command to link temacs failed due to an
215 undefined symbol __builtin_isnan. This is because
216 /usr/include/iso/math_c99.h #defines isnan(x) to
217 __builtin_isnan(x), but the bundled gcc, which identifies itself
218 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
220 * floatfns.c (isnan): #undef, and then #define to a clone of
222 (Fisnan): Always define, since it's always available now.
223 (syms_of_floatfns): Always define isnan at the Lisp level.
225 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
227 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
229 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
231 * fileio.c: Fix bugs with large file offsets (Bug#9428).
232 The previous code assumed that file offsets (off_t values) fit in
233 EMACS_INT variables, which is not true on typical 32-bit hosts.
234 The code messed up by falsely reporting buffer overflow in cases
235 such as (insert-file-contents "big" nil 1 2) into an empty buffer
236 when "big" contains more than 2**29 bytes, even though this
237 inserts just one byte and does not overflow the buffer.
238 (Finsert_file_contents): Store file offsets as off_t
239 values, not as EMACS_INT values. Check for overflow when
240 converting between EMACS_INT and off_t. When checking for
241 buffer overflow or for overlap, take the offsets into account.
242 Don't use EMACS_INT for small values where int suffices.
243 When checking for overlap, fix a typo: ZV was used where
244 ZV_BYTE was intended.
245 (Fwrite_region): Don't assume off_t fits into 'long'.
246 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
248 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
250 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
252 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
254 sprintf-related integer and memory overflow issues (Bug#9412).
256 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
257 (esprintf, exprintf, evxprintf): New functions.
258 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
259 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
260 (modify_event_symbol): Do not assume that the length of
261 name_alist_or_stem is safe to alloca and fits in int.
262 (Fexecute_extended_command): Likewise for function name and binding.
263 (Frecursion_depth): Wrap around reliably on integer overflow.
264 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
265 since some callers pass EMACS_INT values.
266 (Fsingle_key_description): Don't crash if symbol name contains more
267 than MAX_ALLOCA bytes.
268 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
269 (get_minibuffer): Arg is now EMACS_INT, not int.
270 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
271 (esprintf, exprintf, evxprintf): New decls.
272 * window.h (command_loop_level, minibuf_level): Reflect API changes.
274 * dbusbind.c (signature_cat): New function.
275 (xd_signature, Fdbus_register_signal):
276 Do not overrun buffer; instead, report string overflow.
278 * dispnew.c (add_window_display_history): Don't overrun buffer.
279 Truncate instead; this is OK since it's just a log.
281 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
282 even if the time zone offset is outlandishly large.
283 Don't mishandle offset == INT_MIN.
285 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
286 when creating daemon; the previous buffer-overflow check was incorrect.
288 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
289 which has the guts of the old verror function.
291 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
292 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
294 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
295 (font_unparse_xlfd): Don't blindly alloca long strings.
296 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
297 fits in int, when using sprintf. Use single snprintf to count
298 length of string rather than counting it via multiple sprintfs;
299 that's simpler and more reliable.
300 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
301 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
302 sprintf, in case result does not fit in int.
304 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
305 (fontset_from_font): Print it.
307 * frame.c (tty_frame_count): Now printmax_t, not int.
308 (make_terminal_frame, set_term_frame_name): Print it.
309 (x_report_frame_params): In X, window IDs are unsigned long,
310 not signed long, so print them as unsigned.
311 (validate_x_resource_name): Check for implausibly long names,
312 and don't assume name length fits in 'int'.
313 (x_get_resource_string): Don't blindly alloca invocation name;
314 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
317 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
318 (xg_check_special_colors, xg_set_geometry):
319 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
321 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
322 Use esprintf, not sprintf, in case result does not fit in int.
324 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
325 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
326 it as a large positive number.
327 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
328 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
330 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
331 in case result does not fit in int.
333 * print.c (float_to_string): Detect width overflow more reliably.
334 (print_object): Make sprintf buffer a bit bigger, to avoid potential
335 buffer overrun. Don't assume list length fits in 'int'. Treat
336 print length of 0 as 0, not as infinity; to be consistent with other
337 uses of print length in this function. Don't overflow print length
338 index. Don't assume hash table size fits in 'long', or that
339 vectorlike size fits in 'unsigned long'.
341 * process.c (make_process): Use printmax_t, not int, to format
342 process-name gensyms.
344 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
346 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
347 to avoid potential buffer overrun.
349 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
350 if X resource line is longer than 512 bytes.
352 * xfns.c (x_window): Make sprintf buffer a bit bigger
353 to avoid potential buffer overrun.
355 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
357 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
359 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
361 Integer overflow fixes for scrolling, etc.
362 Without these, Emacs silently mishandles large integers sometimes.
363 For example, "C-u 4294967297 M-x recenter" was treated as if
364 it were "C-u 1 M-x recenter" on a typical 64-bit host.
366 * xdisp.c (try_window_id): Check Emacs fixnum range before
369 * window.c (window_scroll_line_based, Frecenter):
370 Check that an Emacs fixnum is in range before assigning it to 'int'.
371 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
372 values converted from Emacs fixnums.
373 (Frecenter): Don't wrap around a line count if it is out of 'int'
374 range; instead, treat it as an extreme value.
375 (Fset_window_configuration, compare_window_configurations):
376 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
378 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
379 that can exceed INT_MAX. Check that EMACS_INT value is in range
380 before assigning it to the (possibly-narrower) index.
381 (match_limit): Don't assume that a fixnum can fit in 'int'.
383 * print.c (print_object): Use ptrdiff_t, not int, for index that can
386 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
387 (Fvertical_motion): Don't wrap around LINES values that don't fit
388 in 'int'. Instead, treat them as extreme values. This is good
389 enough for windows, which can't have more than INT_MAX lines anyway.
391 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
393 * Require libxml/parser.h to avoid compilation warning.
395 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
397 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
398 since this reportedly can destroy thread storage.
400 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
402 * syntax.c (find_defun_start): Update all cache variables if
403 exiting early (Bug#9401).
405 2011-08-30 Eli Zaretskii <eliz@gnu.org>
407 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
409 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
410 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
411 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
413 * term.c (tty_append_glyph): New function.
414 (produce_stretch_glyph): Static function and its prototype deleted.
416 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
419 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
421 * image.c (parse_image_spec): Check for nonnegative, not for positive,
422 when checking :margin (Bug#9390).
423 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
424 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
425 so that the name doesn't mislead. All uses changed.
427 2011-08-28 Johan Bockgård <bojohan@gnu.org>
429 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
432 2011-08-27 Eli Zaretskii <eliz@gnu.org>
434 * xdisp.c (move_it_to): Don't bail out early when reaching
435 position beyond to_charpos, if we are scanning backwards.
436 (move_it_vertically_backward): When DY == 0, make sure we get to
437 the first character in the line after the newline.
439 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
441 * ccl.c: Improve and simplify overflow checking (Bug#9196).
442 (ccl_driver): Do not generate an out-of-range pointer.
443 (Fccl_execute_on_string): Remove unnecessary check for
444 integer overflow, noted by Stefan Monnier in
445 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
446 Remove a FIXME that didn't need fixing.
447 Simplify the newly-introduced buffer reallocation code.
449 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
451 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
453 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
455 Integer and memory overflow issues (Bug#9196).
457 * doc.c (get_doc_string): Rework so that
458 get_doc_string_buffer_size is the actual buffer size, rather than
459 being 1 less than the actual buffer size; this makes xpalloc more
462 * image.c (x_allocate_bitmap_record, cache_image):
463 * xselect.c (Fx_register_dnd_atom):
464 Simplify previous changes by using xpalloc.
466 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
467 since either will do and ptrdiff_t is convenient with xpalloc.
469 * charset.c (charset_table_size)
470 (struct charset_sort_data.priority): Now ptrdiff_t.
471 (charset_compare): Don't overflow if priorities differ greatly.
472 (Fsort_charsets): Don't assume list length fits in int.
473 Check for size-calculation overflow when allocating sort data.
474 (syms_of_charset): Allocate an initial charset table that is
475 just under 64 KiB, to avoid problems with glibc malloc and mmap.
477 * cmds.c (internal_self_insert): Check for size-calculation overflow.
479 * composite.h (struct composition.glyph_len): Now int, not unsigned.
480 The actual value is always <= INT_MAX, and leaving it unsigned made
481 overflow checking harder.
483 * dispextern.h (struct glyph_matrix.rows_allocated)
484 (struct face_cache.size): Now ptrdiff_t, for convenience in use
485 with xpalloc. The values are still always <= INT_MAX.
487 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
489 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
490 (SAFE_NALLOCA): New macro.
492 * region-cache.c (struct boundary.pos, find_cache_boundary)
493 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
494 (set_cache_region, invalidate_region_cache)
495 (revalidate_region_cache, know_region_cache, region_cache_forward)
496 (region_cache_backward, pp_cache):
497 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
498 so that ptrdiff_t * can be passed to xpalloc.
499 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
500 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
501 (pp_cache): Don't assume cache_len fits in int.
502 * region-cache.h: Adjust extern decls to match.
504 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
505 EMACS_INT, since either will do, for xpalloc.
507 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
508 (xnmalloc, xnrealloc, xpalloc): New functions.
510 * bidi.c (bidi_shelve_header_size): New constant.
511 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
512 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
514 * bidi.c (bidi_cache_shrink):
515 * buffer.c (overlays_at, overlays_in, record_overlay_string)
517 Don't update size of array until after memory allocation succeeds,
518 because xmalloc/xrealloc may not return.
519 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
520 now that we have proper integer overflow checking.
521 (record_overlay_string, overlay_strings): Catch overflows when
522 calculating size of overlay_str_buf.
524 * callproc.c (Fcall_process): Check for size overflow when
525 calculating size of args2.
526 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
527 Normally we prefer signed values, but sticking with ptrdiff_t would
528 require adding more-complicated checks.
530 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
531 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
532 Redo buffer-overflow calculations to avoid integer overflow.
533 Add a FIXME comment where memory seems to be over-allocated.
535 * character.c (Fstring): Check for size-calculation overflow.
537 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
538 unnecessary integer overflow. Check for size overflow.
539 (encode_coding_object): Don't update size until xmalloc succeeds.
541 * composite.c (get_composition_id): Check for overflow in glyph
544 Integer and memory overflow fixes for display code.
545 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
546 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
547 (scrolling_window): Check for overflow in size calculations.
548 (line_draw_cost, realloc_glyph_pool, add_row_entry):
549 Don't assume glyph table len fits in int.
550 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
551 (row_table_size): Now ptrdiff_t, not int.
552 (scrolling_window): Avoid overflow in size calculations.
553 Don't update size until allocation succeeds.
554 * fns.c (concat): Check for overflow in size calculations.
555 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
556 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
557 (NEXT_ALMOST_PRIME_LIMIT): New constant.
559 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
560 (get_doc_string): Check for size calculation overflow.
561 Don't update size until allocation succeeds.
562 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
563 EMACS_INT, where ptrdiff_t will do.
564 (Fsubstitute_command_keys): Check for string overflow.
566 * editfns.c (set_time_zone_rule): Don't assume environment length
568 (message_length): Now ptrdiff_t, not int.
569 (Fmessage_box): Don't update size until allocation succeeds.
570 Don't assume message length fits in int.
571 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
573 * emacs.c (main): Do not reallocate argv, since there is a null at
574 the end that can be overwritten, and this way there's no need to
575 worry about size-calculation overflow.
576 (sort_args): Check for size-calculation overflow.
578 * eval.c (init_eval_once, grow_specpdl): Don't update size until
580 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
582 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
583 (x_set_scroll_bar_width, x_figure_window_size):
584 Check for integer overflow.
585 (x_set_alpha): Do not assume XINT fits in int.
587 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
588 This is for the members text_lines, text_cols, total_lines, total_cols,
589 where the system imposes an 'int' limit.
591 * fringe.c (Fdefine_fringe_bitmap):
592 Don't update size until alloc works.
594 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
595 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
597 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
598 Check for size-calculation overflow.
599 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
600 do, as we prefer signed integers.
601 (id_to_widget.max_size, id_to_widget.used)
602 (xg_store_widget_in_map, xg_remove_widget_from_map)
603 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
604 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
605 Use and return ptrdiff_t, not int.
606 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
607 * gtkutil.h: Change prototypes to match the above.
609 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
610 are duplicate now that they've been promoted to lisp.h.
611 (x_allocate_bitmap_record, x_alloc_image_color)
612 (make_image_cache, cache_image, xpm_load):
613 Don't update size until alloc is done.
614 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
616 Check for size calculation overflow.
617 (ct_colors_allocated_max): New constant.
618 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
621 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
622 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
623 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
624 Use ptrdiff_t, not int, to count maps.
625 (read_char_minibuf_menu_prompt): Check for overflow in size
626 calculations. Don't update size until allocation succeeds. Redo
627 calculations to avoid overflow.
628 * keyboard.h: Change prototypes to match the above.
630 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
632 (current_minor_maps): Check for size calculation overflow.
633 * keymap.h: Change prototypes to match the above.
635 * lread.c (read1, init_obarray): Don't update size until alloc done.
637 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
638 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
640 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
641 Now ptrdiff_t, not int.
642 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
643 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
645 * process.c (Fnetwork_interface_list): Check for overflow
648 * region-cache.c (move_cache_gap): Check for size calculation overflow.
650 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
651 overflow. Don't bother calling xmalloc when xrealloc will do.
653 * search.c (Freplace_match): Check for size calculation overflow.
654 (Fset_match_data): Don't assume list lengths fit in 'int'.
656 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
657 for command line length. Do not attempt to address one before the
658 beginning of an array, as that's not portable.
660 * term.c (max_frame_lines): Remove; unused.
661 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
663 (encode_terminal_code, calculate_costs): Check for size
664 calculation overflow.
665 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
666 table lengths and related sizes. Don't update size until alloc
667 done. Redo calculations to avoid overflow.
668 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
670 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
671 subtracting pointers.
672 (gobble_line): Check for overflow more carefully. Don't update size
675 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
676 Don't update size until alloc done.
677 Redo size calculations to avoid overflow.
678 Check for size calculation overflow.
679 (main) [DEBUG]: Fix typo in invoking tparam1.
681 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
682 Use ptrdiff_t, not int, for sizes.
683 (store_mode_line_noprop_char): Don't update size until alloc done.
685 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
686 Use ptrdiff_t, not int, for sizes.
687 (Finternal_make_lisp_face, cache_face):
688 Check for size calculation overflow.
689 (cache_face): Treat size calculation overflows as if they were
690 memory exhaustion (the usual treatment), rather than aborting.
692 * xfns.c (x_encode_text, x_set_name_internal)
693 (Fx_change_window_property): Use ptrdiff_t, not int, to count
694 sizes, since they can exceed INT_MAX in size. Check for size
695 calculation overflow.
697 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
698 (xg_select): Check for size calculation overflow.
699 Don't update size until alloc done.
701 * xrdb.c (get_environ_db): Don't assume path length fits in int,
702 as sprintf is limited to int lengths.
704 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
705 (X_LONG_MIN): New macros.
706 Use them to make the following changes clearer.
707 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
708 This change doesn't affect the value now, but it may help remind
709 future maintainers not to raise the value too much later.
710 (SELECTION_QUANTUM): Remove, replacing with ...
711 (selection_quantum): ... new function, which avoids overflow.
713 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
714 assumption that selection length fits in 'int'.
715 (x_reply_selection_request, x_handle_selection_request)
716 (x_get_window_property, receive_incremental_selection)
717 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
718 (lisp_data_to_selection_data, clean_local_selection_data):
719 Use ptrdiff_t, not int, to record length of selection.
720 (x_reply_selection_request, x_get_window_property)
721 (receive_incremental_selection, x_property_data_to_lisp):
722 Redo calculations to avoid overflow.
723 (x_reply_selection_request): When sending hint, ceiling it at
724 X_LONG_MAX rather than relying on wraparound overflow to send
726 (x_get_window_property, receive_incremental_selection)
727 (lisp_data_to_selection_data, x_property_data_to_lisp):
728 Check for size-calculation overflow.
729 (x_get_window_property, receive_incremental_selection)
730 (lisp_data_to_selection_data, Fx_register_dnd_atom):
731 Don't store size until memory allocation succeeds.
732 (x_get_window_property): Plug memory leak on memory exhaustion.
733 Don't double-block input; malloc is safe here. Don't assume 2**34
734 - 4 fits in unsigned long. Add an xassert to check
735 XGetWindowProperty overflow. Be more careful about overflow
736 calculations, and distinguish size from memory overflow better.
737 (receive_incremental_selection): When tracing, don't assume
738 unsigned int is less than INT_MAX.
739 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
740 harmful) conversions of unsigned short to int.
741 (lisp_data_to_selection_data): Don't assume that integers
742 in the range -65535 through -1 fit in an X unsigned short.
743 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
744 result parameters unless successful. Rely on cons_to_unsigned
745 to report problems with elements; the old code wasn't right anyway.
746 (x_check_property_data): Check for int overflow; we cannot use
747 a wider type due to X limits.
748 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
750 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
752 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
753 (x_term_init): Check for size calculation overflow.
754 (x_color_cells): Don't store size until memory allocation succeeds.
755 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
756 Don't assume alloca size is less than MAX_ALLOCA.
757 (x_term_init): Don't assume length fits in int (sprintf is limited
760 Use ptrdiff_t for composition IDs.
761 * character.c (lisp_string_width):
762 * composite.c (composition_table_size, n_compositions)
763 (get_composition_id, composition_gstring_from_id):
764 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
765 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
766 * window.c (Frecenter):
767 Use ptrdiff_t, not int, for composition IDs.
768 * composite.c (get_composition_id): Check for integer overflow.
769 * composite.h: Adjust prototypes to match the above changes.
771 Use ptrdiff_t for hash table indexes.
772 * category.c (hash_get_category_set):
773 * ccl.c (ccl_driver):
774 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
775 * coding.c (coding_system_charset_list, detect_coding_system):
776 * coding.h (struct coding_system.id):
777 * composite.c (get_composition_id, gstring_lookup_cache):
778 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
779 * image.c (xpm_get_color_table_h):
780 * lisp.h (hash_lookup, hash_put):
781 * minibuf.c (Ftest_completion):
782 Use ptrdiff_t for hash table indexes, not int (which is too
783 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
784 32-bit --with-wide-int hosts).
786 * charset.c (Fdefine_charset_internal): Check for integer overflow.
787 Add a FIXME comment about memory leaks.
788 (syms_of_charset): Don't assume xmalloc returns.
790 Don't assume that stated character widths fit in int.
791 * character.c (Fchar_width, c_string_width, lisp_string_width):
792 * character.h (CHAR_WIDTH):
793 * indent.c (MULTIBYTE_BYTES_WIDTH):
794 Use sanitize_char_width to avoid undefined and/or bad behavior
795 with outlandish widths.
796 * character.h (sanitize_tab_width): Renamed from sanitize_width,
797 now that we have two such functions. All uses changed.
798 (sanitize_char_width): New inline function.
800 Don't assume that tab-width fits in int.
801 * character.h (sanitize_width): New inline function.
802 (SANE_TAB_WIDTH): New macro.
803 (ASCII_CHAR_WIDTH): Use it.
804 * indent.c (sane_tab_width): Remove. All uses replaced by
805 SANE_TAB_WIDTH (current_buffer).
806 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
808 * fileio.c: Integer overflow issues with file modes.
809 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
811 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
812 Remove unreachable code.
813 (read_hex, load_charset_map_from_file): Check for integer overflow.
815 * xterm.c: don't go over XClientMessageEvent limit
816 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
817 (x_send_scroll_bar_event): Likewise. Check that the size does not
818 exceed limits imposed by XClientMessageEvent, as well as the usual
819 ptrdiff_t and size_t limits.
821 * keyboard.c: Overflow, signedness and related fixes.
822 (make_lispy_movement): Use same integer type in forward decl
823 that is used in the definition.
824 (read_key_sequence, keyremap_step):
825 Change bufsize argument back to int, undoing my 2011-03-30 change.
826 We prefer signed types, and int is wide enough here.
827 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
828 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
829 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
830 length, not size_t. Use ptrdiff_t for index, not int.
831 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
832 possibility of integer overflow.
834 Overflow, signedness and related fixes for images.
836 * dispextern.h (struct it.stack[0].u.image.image_id)
837 (struct_it.image_id, struct image.id, struct image_cache.size)
838 (struct image_cache.used, struct image_cache.ref_count):
839 * gtkutil.c (update_frame_tool_bar):
840 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
841 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
842 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
843 * nsmenu.m (update_frame_tool_bar):
844 * xdisp.c (calc_pixel_width_or_height):
845 * xfns.c (image_cache_refcount):
846 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
847 on typical 64-bit hosts.
849 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
850 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
851 Omit unnecessary casts to int.
852 (parse_image_spec): Check that integers fall into 'int' range
853 when the callers expect that.
854 (image_ascent): Redo ascent calculation to avoid int overflow.
855 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
856 (lookup_image): Remove unnecessary tests.
857 (xbm_image_p): Locals are now of int, not EMACS_INT,
858 since parse_image_check makes sure they fit into int.
859 (png_load, gif_load, svg_load_image):
860 Prefer int to unsigned where either will do.
861 (tiff_handler): New function, combining the cores of the
862 old tiff_error_handler and tiff_warning_handler. This
863 function is rewritten to use vsnprintf and thereby avoid
864 stack buffer overflows. It uses only the features of vsnprintf
865 that are common to both POSIX and native Microsoft.
866 (tiff_error_handler, tiff_warning_handler): Use it.
867 (tiff_load, gif_load, imagemagick_load_image):
868 Don't assume :index value fits in 'int'.
869 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
870 (imagemagick_load_image): Check that crop parameters fit into
871 the integer types that MagickCropImage accepts. Don't assume
872 Vimagemagick_render_type has a nonnegative value. Don't assume
873 size_t fits in 'long'.
874 (gs_load): Use printmax_t to print the widest integers possible.
875 Check for integer overflow when computing image height and width.
877 2011-08-26 Eli Zaretskii <eliz@gnu.org>
879 * xdisp.c (redisplay_window): Don't force window start if point
880 will be invisible in the resulting window. (Bug#9324)
882 2011-08-25 Eli Zaretskii <eliz@gnu.org>
884 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
885 the display spec is of the form `(space ...)'.
886 (handle_display_spec): Return the value returned by
887 handle_single_display_spec, not just 1 or zero.
888 (handle_single_display_spec): If the display spec is of the form
889 `(space ...)', and specifies display in the text area, return 2
891 (try_cursor_movement): Check for the need to scroll more
892 accurately, and prefer exact match for point under bidi. Don't
893 advance `row' beyond the last row of the window.
895 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
896 into disp_prop; all users changed.
898 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
899 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
900 for the text covered by the display property.
902 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
904 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
905 Change return value to nil.
906 (Frecord_buffer): Delete unused function.
908 2011-08-24 Eli Zaretskii <eliz@gnu.org>
910 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
911 buffers, return left-to-right.
912 (set_cursor_from_row): Consider candidate row a win if its glyph
913 represents a newline and point is on that newline. Fixes cursor
914 positioning on the newline at EOL of R2L text within L2R
915 paragraph, and vice versa.
916 (try_cursor_movement): Check continued rows, in addition to
917 continuation rows. Fixes unwarranted scroll when point enters a
918 continued line of R2L text within an L2R paragraph, or vice versa.
919 (cursor_row_p): Consider the case of point being equal to
920 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
921 from the end of a short line to the beginning of a continued line
922 of R2L text within L2R paragraph.
923 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
926 * bidi.c (bidi_check_type): Use xassert.
927 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
930 2011-08-23 Eli Zaretskii <eliz@gnu.org>
932 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
935 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
937 * nsfont.m (ns_otf_to_script): Fix typo.
939 2011-08-22 Kenichi Handa <handa@m17n.org>
941 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
942 extra slot even if the purpose is char-code-property-table.
944 2011-08-23 Eli Zaretskii <eliz@gnu.org>
946 * xdisp.c (redisplay_window): When computing centering_position,
947 account for the height of the header line. (Bug#8874)
949 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
950 instead of CHAR_TO_BYTE. Fixes a crash when a completion
951 candidate is selected by the mouse, and that candidate has a
952 composed character under the mouse.
954 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
955 coordinates reported by pos-visible-in-window-p for a composed
956 character in column zero.
958 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
960 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
962 2011-08-22 Eli Zaretskii <eliz@gnu.org>
964 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
965 consider it a hit if to_charpos is anywhere in the range of the
966 composed buffer positions.
968 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
970 * image.c (gif_load): Don't assume that each subimage has the same
971 dimensions as the base image. Handle disposal method that is
972 "undefined" by the gif spec (Bug#9335).
974 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
976 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
977 (Fcondition_case): Document `debug' symbol in error handler.
979 2011-08-19 Eli Zaretskii <eliz@gnu.org>
981 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
982 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
983 from an Org mode buffer to a Speedbar frame.
985 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
986 a composition, take its buffer position from IT->cmp_it.charpos.
987 Fixes cursor positioning at the beginning of a line that begins
988 with a composed character.
990 2011-08-18 Eli Zaretskii <eliz@gnu.org>
992 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
993 character bidirectional type, use STRONG_L instead. Fixes crashes
994 in a buffer produced by `describe-categories'.
996 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
997 members before the level stack, so they would be saved and
998 restored when copying iterator state. Fixes incorrect reordering
999 around TABs covered by display properties.
1001 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1003 * process.c (Fnetwork_interface_list): Correctly determine buffer
1006 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1008 * eval.c (internal_condition_case, internal_condition_case_1)
1009 (internal_condition_case_2, internal_condition_case_n):
1010 Remove unnecessary aborts (Bug#9081).
1012 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1014 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1015 has no `load' handler, try opening the file locally. (Bug#9311)
1017 2011-08-16 Ken Brown <kbrown@cornell.edu>
1019 * gmalloc.c: Expand comment.
1021 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1023 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1024 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1026 2011-08-16 Ken Brown <kbrown@cornell.edu>
1028 Fix memory allocation problems in Cygwin build (Bug#9273).
1030 * unexcw.c ( __malloc_initialized): Declare external variable.
1031 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1033 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1035 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1037 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1039 [CYGWIN] (special_realloc): New function.
1040 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1041 requests to realloc storage in the static heap.
1043 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1045 * bidi.c (bidi_initialize): Remove unused local.
1047 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1049 * biditype.h: File removed.
1051 * bidimirror.h: File removed.
1053 * deps.mk (bidi.o): Remove biditype.h and
1056 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1059 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1061 * chartab.c: Improve commentary for the uniprop_table API.
1063 * bidi.c (bidi_paragraph_init): Support zero value of
1064 bidi_ignore_explicit_marks_for_paragraph_level.
1065 (bidi_initialize): Use uniprop_table instead of including
1066 biditype.h and bidimirror.h.
1068 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1069 coordinates of the iterator when restoring from ppos_it.
1072 2011-08-14 Kenichi Handa <handa@m17n.org>
1074 * process.c (create_process): Call setup_process_coding_systems
1075 after the pid of the process is set to -1 (Bug#8162).
1077 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1079 * xdisp.c (move_it_in_display_line_to): Don't invoke
1080 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1081 ppos_it. Fixes vertical cursor motion when line beginning is
1082 covered by an image. (Bug#9296)
1084 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1086 * nsterm.h (ns_run_ascript): Declare.
1087 (NSAPP_DATA2_RUNASSCRIPT): Define.
1089 * nsfns.m (as_script, as_result, as_status): New static variables.
1090 (ns_run_ascript): New function.
1091 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1092 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1093 the event loop. Get status from as_status (Bug#7276).
1095 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1096 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1097 the event loop (Bug#7276).
1099 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1101 * gnutls.c (QCgnutls_bootprop_priority)
1102 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1103 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1104 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1105 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1106 (QCgnutls_bootprop_verify_hostname_error)
1107 (QCgnutls_bootprop_callbacks_verify): Rename from
1108 Qgnutls_bootprop_..., all uses changed.
1110 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1113 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1115 * xfaces.c (Qframe_set_background_mode): Now static.
1116 * dispextern.h (Qframe_set_background_mode): Remove decl.
1118 * process.c (Fnetwork_interface_info): Declare local only if needed.
1120 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1122 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1123 (Fnetwork_interface_list): Allocate in increments of bytes instead
1124 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1125 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1127 (struct ifflag_def): notrailers is smart on OSX.
1128 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1129 Get hardware address with getifaddrs if available.
1131 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1133 * xdisp.c (iterate_out_of_display_property): xassert that
1134 IT->position is set to within IT->object's boundaries. Break from
1135 the loop as soon as EOB is reached; avoids infloops in redisplay
1136 when IT->position is set up wrongly due to some bug.
1137 Set IT->current to match the bidi iterator unconditionally.
1138 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1139 entry. Force push_it to save on the stack the current
1140 buffer/string position, to be restored by pop_it. Fix flags in
1141 the iterator structure wrt the object coming from a display
1142 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1143 properties. (Bug#9284)
1145 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1147 * fontset.c (fontset_get_font_group): Add proper type checks.
1150 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1152 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1153 and LC_VERSION_MIN_MACOSX.
1154 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1155 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1157 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1159 * xdisp.c (forward_to_next_line_start): Allow to use the
1160 no-display-properties-and-no-overlays under bidi display.
1161 Set disp_pos in the bidi iterator to avoid searches for display
1162 properties and overlays.
1164 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1166 * editfns.c (Fset_time_zone_rule): Document relationship with the
1169 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1170 the font entity extracted from the cache (Bug#8109).
1172 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1174 * composite.c (autocmp_chars): Don't reset point. That is done by
1175 restore_point_unwind (Bug#5984).
1177 2011-08-07 Juri Linkov <juri@jurta.org>
1179 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1180 to show the arg `TIME' instead of `TIMEVAL'.
1182 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1184 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1185 display property strides EOL and includes a newline, as in
1186 longlines-mode. (Bug#9254)
1187 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1188 word-wrap under bidirectional display. (Bug#9224)
1190 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1191 is non-zero, even if the data buffer is NULL. Fixes a crash in
1192 vertical-motion with longlines-mode. (Bug#9254)
1194 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1196 * bidi.c <bidi_cache_total_alloc>: Now static.
1197 (bidi_initialize): Initialize bidi_cache_total_alloc.
1199 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1202 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1203 amount allocated this far in `bidi_cache_total_alloc'.
1204 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1205 non-zero, only free the data buffer without restoring the cache
1206 contents. All callers changed.
1208 * dispextern.h (bidi_unshelve_cache): Update prototype.
1210 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1211 (move_it_in_display_line, move_it_to)
1212 (move_it_vertically_backward, move_it_by_lines): Replace the call
1213 to xfree to an equivalent call to bidi_unshelve_cache.
1214 (move_it_in_display_line_to): Fix logic of returning
1215 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1217 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1219 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1220 came from a string character with a `cursor' property. (Bug#9229)
1222 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1224 * Makefile.in (LIB_PTHREAD): New variable.
1225 (LIBES): Add LIB_PTHREAD (Bug#9216).
1227 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1228 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1230 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1232 * regex.c (re_iswctype): Remove some redundant boolean
1235 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1237 * xterm.c (x_find_topmost_parent): New function.
1238 (x_set_frame_alpha): Find topmost parent window with
1239 x_find_topmost_parent and set the property there also (bug#9181).
1240 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1242 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1244 * callproc.c (Fcall_process): Avoid vfork clobbering
1245 the local vars buffer, coding_systems, current_dir.
1247 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1249 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1251 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1253 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1254 so that it is not optimized away.
1256 * xdisp.c (compute_display_string_pos): Remove unused local.
1258 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1260 Fix slow cursor motion and scrolling in large buffers with
1261 selective display, like Org Mode buffers. (Bug#9218)
1263 * dispextern.h (struct bidi_it): New member disp_prop_p.
1265 * xdisp.c: Remove one-slot cache of display string positions.
1266 (compute_display_string_pos): Accept an additional argument
1267 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1268 for a display string or property. If found, set DISP_PROP_P
1271 * bidi.c (bidi_fetch_char): Accept an additional argument
1272 DISP_PROP_P, and pass it to compute_display_string_pos.
1273 Only handle text covered by a display string if DISP_PROP_P is returned
1274 non-zero. All callers of bidi_fetch_char changed.
1276 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1278 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1280 2010-12-03 Don March <don@ohspite.net>
1282 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1283 last character M-[char] is translated to ESC [char] (bug#7541).
1285 2011-08-02 Kenichi Handa <handa@m17n.org>
1287 * lisp.h (uniprop_table): Extern it.
1289 * chartab.c (uniprop_table): Make it non-static.
1291 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1293 * xdisp.c (forward_to_next_line_start): Accept additional argument
1294 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1296 (reseat_at_next_visible_line_start): Use the bidi iterator state
1297 returned by forward_to_next_line_start to restore the state of
1298 it->bidi_it after backing up to previous newline. (Bug#9212)
1300 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1302 * regex.c (re_comp): Protoize.
1303 (re_exec): Fix return type.
1304 (regexec): Fix type of `ret'. (Bug#9203)
1306 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1308 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1309 This is needed if max-image-size is a floating-point number.
1311 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1313 * print.c (print_object): Print empty symbol as ##.
1315 * lread.c (read1): Read ## as empty symbol.
1317 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1319 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1320 setting frame foreground color (Bug#9175).
1321 (x_set_background_color): Likewise.
1323 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1324 contents (Bug#9176).
1325 (EmacsTooltip -init): Remove bezels and add shadows to
1328 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1329 or scroll bar (Bug#8470).
1331 * nsfont.m (nsfont_open): Remove assignment to voffset and
1332 unnecessary vars hshink, expand, hd, full_height, min_height.
1333 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1335 * nsterm.h (nsfont_info): Remove voffset field.
1337 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1339 Implement strike-through and overline on NextStep (Bug#8863).
1341 * nsfont.m (nsfont_open): Use underline position provided by font,
1342 instead of hard-coded value of 2.
1343 (nsfont_draw): Call ns_draw_text_decoration instead.
1345 * nsterm.h: Add declaration for ns_draw_text_decoration.
1347 * nsterm.m (ns_draw_text_decoration): New function for drawing
1348 underline, overline, and strike-through.
1349 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1350 ns_draw_text_decoration. Change treatment of cursor drawing to
1351 accommodate underlining, etc.
1353 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1355 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1358 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1360 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1361 Without this fix, if a signal arrives just after memory fills up,
1362 'malloc' might be invoked reentrantly.
1364 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1365 In other words, assume that every image size is allowed, on non-X
1366 hosts. This assumption is probably wrong, but it lets Emacs compile.
1368 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1370 * regex.c (re_iswctype): Convert return values to boolean.
1372 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1374 * xdisp.c (compute_display_string_pos): Don't use cached display
1375 string position if the buffer had its restriction changed.
1378 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1380 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1382 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1384 Integer signedness and overflow and related fixes. (Bug#9079)
1386 * bidi.c: Integer size and overflow fixes.
1387 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1388 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1389 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1390 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1391 (bidi_find_other_level_edge):
1392 Use ptrdiff_t instead of EMACS_INT where either will do.
1393 This works better on 32-bit hosts configured --with-wide-int.
1394 (bidi_cache_ensure_space): Check for size-calculation overflow.
1395 Use % rather than repeated addition, for better worst-case speed.
1396 Don't set bidi_cache_size until after xrealloc returns, because it
1398 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1399 (bidi_cache_ensure_space): Also check that the bidi cache size
1400 does not exceed that of the largest Lisp string or buffer. See Eli
1401 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1403 * alloc.c (__malloc_size_t): Remove.
1404 All uses replaced by size_t. See Andreas Schwab's note
1405 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1407 * image.c: Improve checking for integer overflow.
1408 (check_image_size): Assume that f is nonnull, since
1409 it is always nonnull in practice. This is one less thing to
1410 worry about when checking for integer overflow later.
1411 (x_check_image_size): New function, which checks for integer
1412 overflow issues inside X.
1413 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1414 This removes the need for a memory_full check.
1415 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1416 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1417 (xbm_read_bitmap_data): Change locals back to 'int', since
1418 their values must fit in 'int'.
1419 (xpm_load_image, png_load, tiff_load):
1420 Invoke x_create_x_image_and_pixmap earlier,
1421 to avoid much needless work if the image is too large.
1422 (tiff_load): Treat overly large images as if
1423 x_create_x_image_and_pixmap failed, not as malloc failures.
1424 (gs_load): Use x_check_image_size.
1426 * gtkutil.c: Omit integer casts.
1427 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1428 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1430 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1432 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1433 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1434 would wrongly return t on a 64-bit host.
1436 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1437 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1438 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1439 and therefore cause GCC to emit a bogus diagnostic in some cases.
1441 * image.c: Integer signedness and overflow and related fixes.
1442 This is not an exhaustive set of fixes, but it's time to
1443 record what I've got.
1444 (lookup_pixel_color, check_image_size): Remove redundant decls.
1445 (check_image_size): Don't assume that arbitrary EMACS_INT values
1446 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1447 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1448 (tiff_load, imagemagick_load_image):
1449 Check for overflow in size calculations.
1450 (x_create_x_image_and_pixmap): Remove unnecessary test for
1451 xmalloc returning NULL; that can't happen.
1452 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1453 (xpm_color_bucket): Use better integer hashing function.
1454 (xpm_cache_color): Don't possibly over-allocate memory.
1455 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1456 (gif_memory_source):
1457 Use ptrdiff_t, not int or size_t, to record sizes.
1458 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1459 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1460 either works, as we prefer signed integers.
1461 (tiff_read_from_memory, tiff_write_from_memory):
1462 Return tsize_t, not size_t, since that's what the TIFF API wants.
1463 (tiff_read_from_memory): Don't fail simply because the read would
1464 go past EOF; instead, return a short read.
1465 (tiff_load): Omit no-longer-needed casts.
1466 (Fimagemagick_types): Don't assume size fits into 'int'.
1468 Improve hashing quality when configured --with-wide-int.
1469 * fns.c (hash_string): New function, taken from sxhash_string.
1470 Do not discard information about ASCII character case; this
1471 discarding is no longer needed.
1472 (sxhash-string): Use it. Change sig to match it. Caller changed.
1473 * lisp.h: Declare it.
1474 * lread.c (hash_string): Remove, since we now use fns.c's version.
1475 The fns.c version returns a wider integer if --with-wide-int is
1476 specified, so this should help the quality of the hashing a bit.
1478 * emacs.c: Integer overflow minor fix.
1479 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1480 Define only if GNU_LINUX.
1481 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1483 * dispnew.c: Integer signedness and overflow fixes.
1484 Remove unnecessary forward decls, that were a maintenance hassle.
1485 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1487 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1488 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1489 (prepare_desired_row, line_draw_cost):
1490 Use int, not unsigned, where either works.
1491 (save_current_matrix, restore_current_matrix):
1492 Use ptrdiff_t, not size_t, where either works.
1493 (init_display): Check for overflow more accurately, and without
1494 relying on undefined behavior.
1496 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1497 Remove, replacing with the new symbols in lisp.h. All uses changed.
1498 * fileio.c (make_temp_name):
1499 * filelock.c (lock_file_1, lock_file):
1500 * xdisp.c (message_dolog):
1501 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1502 Use pMd etc. instead.
1503 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1504 replacing the pWIDE etc. symbols removed from editfns.c.
1506 * keyboard.h (num_input_events): Now uintmax_t.
1507 This is (very slightly) less likely to mess up due to wraparound.
1510 * buffer.c: Integer signedness fixes.
1511 (alloc_buffer_text, enlarge_buffer_text):
1512 Use ptrdiff_t rather than size_t when either will do, as we prefer
1515 * alloc.c: Integer signedness and overflow fixes.
1516 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1517 (__malloc_size_t): Default to size_t, not to int.
1518 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1519 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1520 Prefer ptrdiff_t to size_t when either would do, as we prefer
1522 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1523 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1524 Now const. Initialize with values that are in range even if char
1526 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1527 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1528 These functions do the right thing with sizes > 2**32.
1529 (check_depth): Now ptrdiff_t, not int.
1530 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1531 Adjust to new way of storing sizes. Check for size overflow bugs
1533 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1534 slightly wrong anyway, as it missed one instance of
1535 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1536 (refill_memory_reserve): Omit needless cast to size_t.
1537 (mark_object_loop_halt): Mark as externally visible.
1539 * xselect.c: Integer signedness and overflow fixes.
1540 (Fx_register_dnd_atom, x_handle_dnd_message):
1541 Use ptrdiff_t, not size_t, since we prefer signed.
1542 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1543 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1544 x_dnd_atoms_size and x_dnd_atoms_length.
1546 * doprnt.c: Prefer signed to unsigned when either works.
1548 * doprnt.c (doprnt):
1550 * xdisp.c (vmessage):
1551 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1552 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1553 prefer signed arithmetic to avoid comparison confusion.
1554 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1555 but is a bit tricky.
1557 Assume freestanding C89 headers, string.h, stdlib.h.
1558 * data.c, doprnt.c, floatfns.c, print.c:
1559 Include float.h unconditionally.
1560 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1561 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1562 * regex.c: Likewise for stddef.h, string.h.
1563 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1564 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1565 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1566 (STDC_HEADERS): Remove obsolete defines.
1567 * sysdep.c: Include limits.h unconditionally.
1569 Assume support for memcmp, memcpy, memmove, memset.
1570 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1571 * regex.c (memcmp, memcpy):
1572 Remove; we assume C89 now.
1574 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1575 (__malloc_safe_bcopy): Remove; no longer needed.
1577 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1578 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1579 well either way, and we prefer signed to unsigned.
1581 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1583 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1584 closes the connection while we're reading (bug#9182).
1586 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1588 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1589 are specified (Bug#9168).
1591 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1593 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1594 Found by GCC static checking and --with-wide-int on a 32-bit host.
1596 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1598 * xdisp.c (compute_display_string_pos): Fix logic of caching
1599 previous display string position. Initialize cached_prev_pos to
1600 -1. Fixes slow-down at the beginning of a buffer.
1602 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1604 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1605 for attrs[LFACE_FONTSET_INDEX].
1607 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1609 * xml.c (parse_region): Remove unused local
1610 that was recently introduced.
1612 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1614 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1615 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1617 * xdisp.c (move_it_in_display_line_to): Record the best matching
1618 position for TO_CHARPOS while scanning the line, and restore it on
1619 exit if none of the characters scanned was an exact match.
1620 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1621 when exact match is impossible due to invisible text, and the
1622 lines are truncated.
1624 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1626 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1629 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1631 Fix a significant slow-down of cursor motion with C-n, C-p,
1632 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1633 auto-repeat under bidi redisplay in fontified buffers.
1634 * xdisp.c (compute_stop_pos_backwards): New function.
1635 (next_element_from_buffer): Call compute_stop_pos_backwards to
1636 find a suitable prev_stop when we find ourselves before
1638 (reseat): Don't look for prev_stop, as that could mean a very long
1640 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1641 <cached_disp_overlay_modiff>: Cache for last found display string
1643 (compute_display_string_pos): Return the cached position if asked
1644 about the same buffer in the same area of character positions, and
1645 the buffer wasn't changed since the time the display string
1646 position was cached.
1648 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1650 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1651 is an integer, which is important for empty lines. (Bug#9149)
1653 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1655 * frame.c (Fmodify_frame_parameters): In tty case, update the
1656 default face if necessary (Bug#4238).
1658 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1660 * editfns.c (Fstring_to_char): No need to explain what a character
1661 is in the docstring (Bug#6576).
1663 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1665 * xml.c (parse_region): Make sure we always return a tree.
1667 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1669 * xml.c (parse_region): If a document contains only comments,
1672 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1674 * xml.c (make_dom): Return comments, too.
1676 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1679 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1680 and the surrounding thread.
1681 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1682 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1683 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1685 * s/openbsd.h (BROKEN_SIGIO): Define.
1686 * unexelf.c (unexec) [__OpenBSD__]:
1687 Don't update the .mdebug section of the Alpha COFF symbol table.
1689 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1691 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1694 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1696 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1697 This fixes some race conditions on the permissions of any newly
1700 * alloc.c (valid_pointer_p): Use pipe, not open.
1701 This fixes some permissions issues when debugging.
1703 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1704 If fchown fails to set both uid and gid, try to set just gid,
1705 as that is sometimes allowed. Adjust the file's mode to eliminate
1706 setuid or setgid bits that are inappropriate if fchown fails.
1708 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1710 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1711 to compare Lisp_Objects.
1712 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1713 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1714 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1716 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1718 * lread.c (read_integer): Unread even EOF character.
1719 (read1): Likewise. Properly record start position of symbol.
1721 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1722 symbol character follows.
1724 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1726 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1727 This works around a problem with the previous change to Fcopy_file.
1728 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1729 and without this change, GCC might complain about discarding
1730 fchown's return value.
1732 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1734 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1736 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1738 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1740 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1742 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1743 it's used from the C level.
1745 * process.c: Use the same condition for POLL_FOR_INPUT in both
1746 keyboard.c and process.c (bug#1858).
1748 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1750 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1751 (Fgnutls_boot): Use it.
1753 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1755 * doc.c (Fsubstitute_command_keys): Revert last change.
1757 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1759 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1760 quotes the next character, and doesn't affect other longer
1761 sequences (bug#8935).
1763 * lread.c (syms_of_lread): Clarify that is isn't only
1764 `eval-buffer' and `eval-defun' that's affected by
1765 `lexical-binding' (bug#8460).
1767 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1769 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1770 bidi redisplay when a line includes both an image and is
1773 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1775 Fix minor problems found by static checking.
1776 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1777 (elsz): Now a signed constant, not a size_t var. We prefer signed
1778 types to unsigned, to avoid integer comparison confusion. Without
1779 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1780 "cannot optimize loop, the loop counter may overflow", a symptom
1782 * indent.c (Fvertical_motion): Mark locals as initialized.
1783 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1785 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1787 * search.c (Fre_search_backward): Mention `case-fold-search' in
1788 all the re_search_* functions (bug#8138).
1790 * keyboard.c (Fopen_dribble_file): Document when the file is
1793 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1795 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1798 Support bidi reordering of display and overlay strings.
1799 * xdisp.c (compute_display_string_pos)
1800 (compute_display_string_end): Accept additional argument STRING.
1801 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1802 (reseat_to_string): Initialize bidi_it->string.s and
1803 bidi_it->string.schars.
1804 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1805 NULL (avoids a crash in bidi_paragraph_init).
1806 Initialize itb.string.lstring.
1807 (init_iterator): Call bidi_init_it only of a valid
1808 buffer position was specified. Initialize paragraph_embedding to
1810 (reseat_to_string): Initialize the bidi iterator.
1811 (display_string): If we need to ignore text properties of
1812 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1813 original value of -1 will not work with bidi.)
1814 (compute_display_string_pos): First arg is now struct
1815 `text_pos *'; all callers changed. Support display properties on
1817 (compute_display_string_end): Support display properties on Lisp
1819 (init_iterator, reseat_1, reseat_to_string): Initialize the
1820 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1821 when iterating on a string not from display properties).
1822 (compute_display_string_pos, compute_display_string_end):
1823 Fix calculation of the object to scan. Fixes an error when using
1825 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1826 base_level_stop; instead, set base_level_stop to BEGV.
1827 Fixes crashes in vertical-motion.
1828 (next_element_from_buffer): Improve commentary for when
1829 the iterator is before prev_stop.
1830 (init_iterator): Initialize bidi_p from the default value of
1831 bidi-display-reordering, not from buffer-local value. Use the
1832 buffer-local value only if initializing for buffer iteration.
1833 (handle_invisible_prop): Support invisible properties on strings
1834 that are being bidi-reordered.
1835 (set_iterator_to_next): Support bidi reordering of C strings and
1837 (next_element_from_string): Support bidi reordering of Lisp
1839 (handle_stop_backwards): Support Lisp strings as well.
1840 (display_string): Support display of R2L glyph rows.
1841 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1842 (init_iterator): Don't initialize it->bidi_p for strings
1844 (reseat_to_string): Initialize it->bidi_p for strings here.
1845 (next_element_from_string, next_element_from_c_string)
1846 (next_element_from_buffer): Add xassert's for correspondence
1847 between IT's object being iterated and it->bidi_it.string
1849 (face_before_or_after_it_pos): Support bidi iteration.
1850 (next_element_from_c_string): Handle the case of the first string
1851 character that is not the first one in the visual order.
1852 (get_visually_first_element): New function, refactored from common
1853 parts of next_element_from_buffer, next_element_from_string, and
1854 next_element_from_c_string.
1855 (tool_bar_lines_needed, redisplay_tool_bar)
1856 (display_menu_bar): Force left-to-right direction. Add a FIXME
1857 comment for making that be controlled by a user option.
1858 (push_it, pop_it): Save and restore the state of the
1859 bidi iterator. Save and restore the bidi_p flag.
1860 (pop_it): Iterate out of display property for string iteration as
1862 (iterate_out_of_display_property): Support iteration over strings.
1863 (handle_single_display_spec): Set up it->bidi_it for iteration
1864 over a display string, and call bidi_init_it.
1865 (handle_single_display_spec, next_overlay_string)
1866 (get_overlay_strings_1, push_display_prop): Set up the bidi
1867 iterator for displaying display or overlay strings.
1868 (forward_to_next_line_start): Don't use the shortcut if
1870 (back_to_previous_visible_line_start): If handle_display_prop
1871 pushed the iterator stack, restore the internal state of the bidi
1872 iterator by calling bidi_pop_it same number of times.
1873 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1874 and we are bidi-iterating, don't decrement the iterator position;
1875 instead, set the first_elt flag in the bidi iterator, to produce
1877 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1878 (push_display_prop): xassert that we are iterating a buffer.
1879 (push_it, pop_it): Save and restore paragraph_embedding member.
1880 (handle_single_display_spec, next_overlay_string)
1881 (get_overlay_strings_1, reseat_1, reseat_to_string)
1882 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1883 correctly. Don't assume unibyte strings are not bidi-reordered.
1884 (compute_display_string_pos)
1885 (compute_display_string_end): Fix handling the case of C string.
1886 (push_it, pop_it): Save and restore from_disp_prop_p.
1887 (handle_single_display_spec, push_display_prop): Set the
1888 from_disp_prop_p flag.
1889 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1890 (pop_it): Call iterate_out_of_display_property only if we are
1891 popping after iteration over a string that came from a display
1892 property. Fix a typo in popping stretch info. Add an assertion
1893 for verifying that the iterator position is in sync with the bidi
1895 (handle_single_display_spec, get_overlay_strings_1)
1896 (push_display_prop): Fix initialization of paragraph direction for
1897 string when that of the parent object is not yet determined.
1898 (reseat_1): Call bidi_init_it to resync the bidi
1899 iterator with IT's position. (Bug#7616)
1900 (find_row_edges): If ROW->start.pos gives position
1901 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1902 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1903 Reset the from_disp_prop_p flag.
1904 (SAVE_IT, RESTORE_IT): New macros.
1905 (pos_visible_p, face_before_or_after_it_pos)
1906 (back_to_previous_visible_line_start)
1907 (move_it_in_display_line_to, move_it_in_display_line)
1908 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1909 (try_scrolling, redisplay_window, display_line): Use them when
1910 saving a temporary copy of the iterator and restoring it back.
1911 (back_to_previous_visible_line_start, reseat_1)
1912 (init_iterator): Empty the bidi cache "stack".
1913 (move_it_in_display_line_to): If iterator ended up at
1914 EOL, but we never saw any buffer positions smaller than
1915 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1916 motion in bidi-reordered lines.
1917 (move_it_in_display_line_to): Record prev_method and prev_pos
1918 immediately before the call to set_iterator_to_next. Fixes cursor
1919 motion in bidi-reordered lines with stretch glyphs and strings
1920 displayed in margins. (Bug#8133) (Bug#8867)
1921 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1923 (pos_visible_p): Support positions in bidi-reordered lines.
1924 Save and restore bidi cache.
1926 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1927 (bidi_paragraph_info): Delete unused struct.
1928 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1929 (bidi_cache_start): New variable.
1930 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1932 (bidi_cache_fetch_state, bidi_cache_search)
1933 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1934 (bidi_cache_find, bidi_peek_at_next_level)
1935 (bidi_level_of_next_char, bidi_find_other_level_edge)
1936 (bidi_move_to_visually_next): Compare cache index with
1937 bidi_cache_start rather than with zero.
1938 (bidi_fetch_char): Accept new argument STRING; all callers
1939 changed. Support iteration over a string. Support strings with
1940 display properties. Support unibyte strings. Fix the type of
1941 `len' according to what STRING_CHAR_AND_LENGTH expects.
1942 (bidi_paragraph_init, bidi_resolve_explicit_1)
1943 (bidi_resolve_explicit, bidi_resolve_weak)
1944 (bidi_level_of_next_char, bidi_move_to_visually_next):
1945 Support iteration over a string.
1946 (bidi_set_sor_type, bidi_resolve_explicit_1)
1947 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1948 can now be zero (for strings); special values 0 and -1 were
1949 changed to -1 and -2, respectively.
1950 (bidi_char_at_pos): New function.
1951 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1952 Call it instead of FETCH_MULTIBYTE_CHAR.
1953 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1954 initialized to valid values.
1955 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1957 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1958 the test for valid cached positions. Fix the logic for looking up
1959 the sentinel state in the cache. GCPRO the Lisp string we are
1961 (bidi_push_it, bidi_pop_it): New functions.
1962 (bidi_initialize): Initialize the bidi cache start stack pointer.
1963 (bidi_cache_ensure_space): New function, refactored from part of
1964 bidi_cache_iterator_state. Don't assume the required size is just
1965 one BIDI_CACHE_CHUNK away.
1966 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1967 (bidi_count_bytes, bidi_char_at_pos): New functions.
1968 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1969 always valid if bidi_cache_idx is valid.
1970 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1971 is valid if it's going to be used.
1972 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1973 (bidi_cache_fetch_state, bidi_cache_search)
1974 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1975 (bidi_cache_iterator_state, bidi_cache_find)
1976 (bidi_find_other_level_edge, bidi_cache_start_stack):
1977 All variables related to cache indices are now EMACS_INT.
1979 * dispextern.h (struct bidi_string_data): New structure.
1980 (struct bidi_it): New member `string'. Make flag members be 1-bit
1981 fields, and put them last in the struct.
1982 (compute_display_string_pos, compute_display_string_end):
1984 (bidi_push_it, bidi_pop_it): Add prototypes.
1985 (struct iterator_stack_entry): New members bidi_p,
1986 paragraph_embedding, and from_disp_prop_p.
1987 (struct it): Member bidi_p is now a bit field 1 bit wide.
1988 (bidi_shelve_cache, bidi_unshelve_cache):
1991 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1992 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1993 and vector-like objects.
1995 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1996 cache around display iteration.
1998 * window.c (Fwindow_end, window_scroll_pixel_based)
1999 (displayed_window_lines, Frecenter): Save and restore the bidi
2000 cache around display iteration.
2002 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2004 * editfns.c (Fdelete_region): Clarify the use of the named
2005 parameters (bug#6788).
2007 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2009 * indent.c (Fvertical_motion): Set and restore w->pointm when
2010 saving and restoring the window's buffer (Bug#9006).
2012 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2014 * editfns.c (Fstring_to_char): Clarify just what is returned
2015 (bug#6576). Text by Eli Zaretskii.
2017 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2019 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2021 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2023 * buffer.c (mmap_find): Fix a typo.
2025 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2027 Fix execution of x selection hooks.
2028 * xselect.c (Qx_lost_selection_functions)
2029 (Qx_sent_selection_functions): New vars.
2030 (syms_of_xselect): DEFSYM them.
2031 (x_handle_selection_request): Pass Qx_sent_selection_functions
2032 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2033 (x_handle_selection_clear,x_clear_frame_selections):
2034 Pass Qx_lost_selection_functions rather than
2035 Vx_lost_selection_functions to Frun_hook_with_args.
2037 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2039 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2040 The old code sometimes used this field without initializing it.
2042 * alloc.c (gc_sweep): Don't read past end of array.
2043 In theory, the old code could also have corrupted Emacs internals,
2044 though it'd be very unlikely.
2046 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2048 * character.c (Fcharacterp): Don't advertise optional ignored
2049 argument. (Bug#4026)
2051 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2053 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2056 * window.c (Fset_window_start): Doc fix (bug#4199).
2057 (Fset_window_hscroll): Ditto.
2059 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2061 Fix minor new problems caught by GCC 4.6.1.
2062 * term.c (init_tty): Remove unused local.
2063 * xsettings.c (store_monospaced_changed): Define this function only
2064 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2067 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2069 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2071 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2073 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2074 are the mini-buffer and the echo area (bug#3320).
2076 * term.c (init_tty): Remove support for supdup, c10 and perq
2077 terminals, which are no longer supported (bug#1482).
2079 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2081 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2083 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2085 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2086 for non-popups (Bug#3642).
2088 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2090 * alloc.c (reset_malloc_hooks): Protoize.
2091 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2092 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2093 * cm.c (losecursor): Likewise.
2094 * data.c (fmod): Likewise.
2095 * dispnew.c (swap_glyphs_in_rows): Likewise.
2096 * emacs.c (memory_warning_signal): Likewise.
2097 * floatfns.c (float_error): Likewise.
2098 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2099 (otf_open, font_otf_capability, generate_otf_features)
2100 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2102 * image.c (pbm_read_file): Likewise.
2103 * indent.c (string_display_width): Likewise.
2104 * intervals.c (check_for_interval, search_for_interval)
2105 (inc_interval_count, count_intervals, root_interval)
2106 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2107 * lread.c (defalias): Likewise.
2108 * ralloc.c (r_alloc_check): Likewise.
2109 * regex.c (set_image_of_range_1, set_image_of_range)
2110 (regex_grow_registers): Likewise.
2111 * sysdep.c (strerror): Likewise.
2112 * termcap.c (valid_filename_p, tprint, main): Likewise.
2113 * tparam.c (main): Likewise.
2114 * unexhp9k800.c (run_time_remap, save_data_space)
2115 (update_file_ptrs, read_header, write_header, calculate_checksum)
2116 (copy_file, copy_rest, display_header): Likewise.
2117 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2119 * xdisp.c (check_it): Likewise.
2120 * xfaces.c (register_color, unregister_color, unregister_colors):
2122 * xfns.c (print_fontset_result): Likewise.
2123 * xrdb.c (member, fatal, main): Likewise.
2125 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2127 Fix minor problems found by static checking (Bug#9031).
2128 * chartab.c (char_table_set_range, map_sub_char_table):
2129 Remove unused locals.
2130 (uniprop_table): Now static.
2131 * composite.c (_work_char): Remove unused static var.
2133 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2135 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2137 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2139 * gtkutil.c (qttip_cb): Remove code without function.
2141 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2143 * w32.c (pthread_sigmask): New stub.
2145 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2147 Use pthread_sigmask, not sigprocmask (Bug#9010).
2148 sigprocmask is portable only for single-threaded applications, and
2149 Emacs can be multi-threaded when it uses GTK.
2150 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2152 * callproc.c (Fcall_process):
2153 * process.c (create_process):
2154 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2155 Use pthread_sigmask, not sigprocmask.
2157 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2159 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2160 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2163 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2165 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2166 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2167 (xg_hide_tooltip): Fix comment.
2169 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2170 in registerServicesMenuSendTypes.
2171 (validRequestorForSendType): Don't check ns_return_types.
2173 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2176 2011-07-08 Jason Rumney <jasonr@gnu.org>
2178 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2179 frame struct members of non-existent frames (Bug#6284).
2181 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2183 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2184 variable firstTime not needed on OSX >= 10.6.
2185 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2186 >= 10.5. Use setKnobProportion, setDoubleValue.
2188 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2189 (MAC_OS_X_VERSION_10_5): Define if not defined.
2190 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2191 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2192 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2194 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2195 cString and lossyCString on OSX >= 10.4
2197 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2198 sizeToFit on OSX >= 10.2.
2200 * nsimage.m (allocInitFromFile): Don't use deprecated method
2201 bestRepresentationForDevice on OSX >= 10.6.
2203 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2206 * emacs.c: Declare unexec_init_emacs_zone.
2208 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2210 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2212 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2213 on svcsMenu (Bug#8842).
2215 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2217 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2219 * nsterm.m (QUTF8_STRING): Declare.
2220 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2221 (validRequestorForSendType): Return type is (id).
2222 Change indexOfObjectIdenticalTo to indexOfObject.
2223 Check if we have local selection before returning self (Bug#8842).
2224 (writeSelectionToPasteboard): Put local selection into paste board
2225 if we have a local selection (Bug#8842).
2226 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2228 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2229 (ns_get_local_selection): Declare.
2231 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2233 * keymap.c (describe_map_tree): Don't insert a double newline at
2234 the end of the buffer (bug#1169) and return whether we inserted
2237 * callint.c (Fcall_interactively): Change "reading args" to
2238 "providing args" to try to clarify what it does (bug#1010).
2240 2011-07-07 Kenichi Handa <handa@m17n.org>
2242 * composite.c (composition_compute_stop_pos): Ignore a static
2243 composition starting before CHARPOS (Bug#8915).
2245 * xdisp.c (handle_composition_prop): Likewise.
2247 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2249 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2252 2011-07-07 Kenichi Handa <handa@m17n.org>
2254 * character.h (unicode_category_t): New enum type.
2256 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2257 (Qchar_code_property_table): New variable.
2258 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2259 (UNIPROP_COMPRESSED_FORM_P): New macros.
2260 (char_table_ascii): Uncompress the compressed values.
2261 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2262 Uncompress the compressed values.
2263 (sub_char_table_ref_and_range): Likewise.
2264 (char_table_ref_and_range): Uncompress the compressed values.
2265 (sub_char_table_set): New arg is_uniprop. Callers changed.
2266 Uncompress the compressed values.
2267 (sub_char_table_set_range): Args changed. Callers changed.
2268 (char_table_set_range): Adjuted for the above change.
2269 (map_sub_char_table): Delete args default_val and parent. Add arg
2270 top. Give decoded values to a Lisp function.
2271 (map_char_table): Adjust for the above change. Give decoded
2272 values to a Lisp function. Gcpro more variables.
2273 (uniprop_table_uncompress)
2274 (uniprop_decode_value_run_length): New functions.
2275 (uniprop_decoder, uniprop_decoder_count): New variables.
2276 (uniprop_get_decoder, uniprop_encode_value_character)
2277 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2279 (uniprop_encoder, uniprop_encoder_count): New variables.
2280 (uniprop_get_encoder, uniprop_table)
2281 (Funicode_property_table_internal, Fget_unicode_property_internal)
2282 (Fput_unicode_property_internal): New functions.
2283 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2284 Sunicode_property_table_internal, Sget_unicode_property_internal,
2285 and Sput_unicode_property_internal. Defvar_lisp
2286 char-code-property-alist.
2288 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2289 Vunicode_category_table.
2291 * font.c (font_range): Adjust for the change of
2292 Vunicode_category_table.
2294 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2296 * m/iris4d.h: Remove file, move contents ...
2297 * s/irix6-5.h: ... here.
2299 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2301 Remove unportable assumption about struct layout (Bug#8884).
2302 * alloc.c (mark_buffer):
2303 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2304 (clone_per_buffer_values): Don't assume that
2305 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2306 This isn't true in general, and it's particularly not true
2307 if Emacs is configured with --with-wide-int.
2308 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2309 New macros, used in the buffer.c change.
2311 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2313 * xsettings.c: Use both GConf and GSettings if both are available.
2314 (store_config_changed_event): Add comment.
2315 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2316 (store_tool_bar_style_changed): New functions.
2317 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2318 (struct xsettings): Move font inside HAVE_XFT.
2319 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2320 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2321 Move inside HAVE_XFT.
2322 (something_changed_gsettingsCB): Rename from something_changedCB.
2323 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2325 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2326 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2327 (something_changed_gconfCB): Rename from something_changedCB.
2328 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2329 (parse_settings): Move check for font inside HAVE_XFT.
2330 (read_settings, apply_xft_settings): Add comment.
2331 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2332 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2333 call store_font_name_changed.
2334 (xft_settings_event): Add comment.
2335 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2336 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2337 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2338 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2339 (xsettings_initialize): Call init_gsettings last.
2340 (xsettings_get_system_font, xsettings_get_system_normal_font):
2343 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2345 Random fixes. E.g., (random) never returned negative values.
2346 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2347 subseconds part to the entropy, as that's a bit more random.
2348 Prefer signed to unsigned, since the signedness doesn't matter and
2349 in general we prefer signed. When given a limit, use a
2350 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2351 latter isn't right if USE_2_TAGS_FOR_INTS.
2352 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2353 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2355 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2357 * textprop.c (text_property_stickiness):
2358 Obey Vtext_property_default_nonsticky.
2359 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2360 * w32fns.c (syms_of_w32fns):
2361 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2363 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2365 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2366 This is more efficient than Ffile_directory_p and avoids a minor race.
2368 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2370 * buffer.c (Foverlay_put): Say what the return value is
2373 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2374 is a directory before asking whether to use the file name
2376 (barf_or_query_if_file_exists): Make the "File is a directory"
2377 error be more correct.
2379 * fns.c (Frequire): Remove the mention of the .gz files, since
2380 that's installation-specific, but keep the mention of
2381 `get-load-suffixes'.
2383 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2385 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2386 Report string overflow if the output is too long.
2388 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2390 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2391 (syms_of_gnutls): Remove duplicate DEFSYM for
2392 Qgnutls_bootprop_verify_hostname_error, an error for
2393 Qgnutls_bootprop_verify_error (which is no longer used).
2395 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2396 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2397 Also (re)move comments that are misplaced or no longer relevant.
2399 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2401 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2403 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2405 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2406 and background color parameters if they have been changed.
2408 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2410 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2412 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2414 * xsettings.c (SYSTEM_FONT): Define only when used.
2415 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2417 * keymap.c (access_keymap_1): Now static.
2419 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2421 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2422 leave any prefix arg for the up event (Bug#1586).
2424 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2426 * lread.c (syms_of_lread): Mention single symbols defined by
2427 `defvar' or `defconst' (bug#7154).
2429 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2430 (Frequire): Mention get-load-suffixes.
2432 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2434 * window.h (window): Remove clone_number slot.
2435 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2437 (make_parent_window, make_window, saved_window)
2438 (Fset_window_configuration, save_window_save): Don't deal with
2440 * buffer.c (Qclone_number): Remove declaration.
2441 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2443 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2445 Add multiple inheritance to keymaps.
2446 * keymap.c (Fmake_composed_keymap): New function.
2447 (Fset_keymap_parent): Simplify.
2448 (fix_submap_inheritance): Remove.
2449 (access_keymap_1): New function extracted from access_keymap to handle
2450 embedded parents and handle lists of maps.
2451 (access_keymap): Use it.
2452 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2453 (Fcopy_keymap): Handle embedded parents.
2454 (Fcommand_remapping, define_as_prefix): Simplify.
2455 (Fkey_binding): Simplify.
2456 (syms_of_keymap): Move minibuffer-local-completion-map,
2457 minibuffer-local-filename-completion-map,
2458 minibuffer-local-must-match-map, and
2459 minibuffer-local-filename-must-match-map to Elisp.
2460 (syms_of_keymap): Defsubr make-composed-keymap.
2461 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2462 (parse_menu_item): Trivial simplification.
2464 2011-07-01 Glenn Morris <rgm@gnu.org>
2466 * Makefile.in (SETTINGS_LIBS): Fix typo.
2468 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2470 * coding.c (Fencode_coding_string): Record the last coding system
2471 used, as the function doc string says (bug#8738).
2473 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2475 * xsettings.c (store_monospaced_changed): Take new font as arg and
2476 check for change against current_mono_font.
2477 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2478 (emacs_settings_constructor, emacs_settings_get_property)
2479 (emacs_settings_set_property, emacs_settings_class_init)
2480 (emacs_settings_init, gsettings_obj): Remove.
2481 (something_changedCB): New function for HAVE_GSETTINGS.
2482 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2483 with value as argument.
2484 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2485 g_settings_new (Bug#8967). Do not create gsettings_obj.
2486 Remove calls to g_settings_bind. Connect something_changedCB to
2489 * xgselect.c: Add defined (HAVE_GSETTINGS).
2490 (xgselect_initialize): Ditto.
2492 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2493 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2496 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2498 * eval.c (struct backtrace): Simplify and port the data structure.
2499 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2500 signed bit field, as this assumption is not portable and it makes
2501 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2502 "char debug_on_exit : 1" as this is not portable either; instead,
2503 use the portable "unsigned int debug_on_exit : 1". Remove unused
2504 member evalargs. Remove obsolete comments about cc bombing out.
2506 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2508 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2509 Let HAVE_GSETTINGS override HAVE_GCONF.
2510 (store_monospaced_changed): New function.
2511 (EMACS_SETTINGS): A new type derived from GObject to handle
2512 GSettings notifications.
2513 (emacs_settings_constructor, emacs_settings_get_property)
2514 (emacs_settings_set_property, emacs_settings_class_init):
2516 (gsettings_client, gsettings_obj): New variables.
2517 (GSETTINGS_SCHEMA): New define.
2518 (something_changedCB): Call store_monospaced_changed.
2519 (init_gsettings): New function.
2520 (xsettings_initialize): Call init_gsettings.
2521 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2524 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2527 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2529 * window.c (resize_root_window, grow_mini_window)
2530 (shrink_mini_window): Rename Qresize_root_window to
2531 Qwindow_resize_root_window and Qresize_root_window_vertically to
2532 Qwindow_resize_root_window_vertically.
2534 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2536 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2538 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2540 * makefile.w32-in: Redesign dependencies so they reflect more
2541 clearly which files are directly included by each source file,
2542 and not through other includes.
2544 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2546 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2547 (sort_overlays, overlay_strings): When an overlay's clone number
2548 matches the window's clone number process the overlay even if
2549 the overlay's window property doesn't match the current window.
2551 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2552 (Fwindow_hchild): Rename to Fwindow_left_child.
2553 (Fwindow_next): Rename to Fwindow_next_sibling.
2554 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2555 (resize_window_check): Rename to window_resize_check.
2556 (resize_window_apply): Rename to window_resize_apply.
2557 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2558 (Fdelete_other_windows_internal, resize_frame_windows)
2559 (Fsplit_window_internal, Fdelete_window_internal)
2560 (grow_mini_window, shrink_mini_window)
2561 (Fresize_mini_window_internal): Fix callers accordingly.
2563 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2565 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2566 (emacs_fixed_set_min_size): Remove.
2567 (emacs_fixed_new): Take frame as argument.
2569 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2570 (_EmacsFixedPrivate): Remove minwidth/height.
2571 Add struct frame *f.
2572 (emacs_fixed_init): Initialize priv->f.
2573 (get_parent_class, emacs_fixed_set_min_size): Remove.
2574 (emacs_fixed_new): Set priv->f to argument.
2575 (emacs_fixed_get_preferred_width)
2576 (emacs_fixed_get_preferred_height): Use min_width/height from
2577 frames size_hint to set minimum and natural (Bug#8919).
2578 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2579 and use min_width/height from frames size_hint to set
2580 min_width/height (Bug#8919).
2582 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2583 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2586 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2588 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2589 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2592 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2594 * process.c (wait_reading_process_output): Bypass select if
2595 waiting for a cell while ignoring keyboard input, and input is
2596 pending. Suggested by Jan Djärv (Bug#8869).
2598 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2600 Use gnulib's dup2 module instead of rolling our own.
2601 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2603 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2605 * dispnew.c (scrolling_window): Before scrolling, turn off a
2606 mouse-highlight in the window being scrolled.
2608 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2610 Move DEFSYM to lisp.h and use everywhere.
2612 * character.h (DEFSYM): Move declaration...
2613 * lisp.h (DEFSYM): ...here.
2619 * w32select.c: Don't include character.h.
2621 * alloc.c (syms_of_alloc):
2622 * buffer.c (syms_of_buffer):
2623 * bytecode.c (syms_of_bytecode):
2624 * callint.c (syms_of_callint):
2625 * casefiddle.c (syms_of_casefiddle):
2626 * casetab.c (init_casetab_once):
2627 * category.c (init_category_once, syms_of_category):
2628 * ccl.c (syms_of_ccl):
2629 * cmds.c (syms_of_cmds):
2630 * composite.c (syms_of_composite):
2631 * dbusbind.c (syms_of_dbusbind):
2632 * dired.c (syms_of_dired):
2633 * dispnew.c (syms_of_display):
2634 * doc.c (syms_of_doc):
2635 * editfns.c (syms_of_editfns):
2636 * emacs.c (syms_of_emacs):
2637 * eval.c (syms_of_eval):
2638 * fileio.c (syms_of_fileio):
2639 * fns.c (syms_of_fns):
2640 * frame.c (syms_of_frame):
2641 * fringe.c (syms_of_fringe):
2642 * insdel.c (syms_of_insdel):
2643 * keymap.c (syms_of_keymap):
2644 * lread.c (init_obarray, syms_of_lread):
2645 * macros.c (syms_of_macros):
2646 * msdos.c (syms_of_msdos):
2647 * print.c (syms_of_print):
2648 * process.c (syms_of_process):
2649 * search.c (syms_of_search):
2650 * sound.c (syms_of_sound):
2651 * syntax.c (init_syntax_once, syms_of_syntax):
2652 * terminal.c (syms_of_terminal):
2653 * textprop.c (syms_of_textprop):
2654 * undo.c (syms_of_undo):
2655 * w32.c (globals_of_w32):
2656 * window.c (syms_of_window):
2657 * xdisp.c (syms_of_xdisp):
2658 * xfaces.c (syms_of_xfaces):
2659 * xfns.c (syms_of_xfns):
2660 * xmenu.c (syms_of_xmenu):
2661 * xsettings.c (syms_of_xsettings):
2662 * xterm.c (syms_of_xterm): Use DEFSYM.
2664 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2666 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2668 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2670 Integer and buffer overflow fixes (Bug#8873).
2672 * print.c (printchar, strout): Check for string overflow.
2673 (PRINTPREPARE, printchar, strout):
2674 Don't set size unless allocation succeeds.
2676 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2677 for sizes. Check for string overflow more accurately.
2678 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2680 * macros.c: Integer and buffer overflow fixes.
2681 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2682 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2683 Use ptrdiff_t, not int, for sizes.
2684 Don't increment bufsize until after realloc succeeds.
2685 Check for size-calculation overflow.
2686 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2688 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2690 * lread.c: Integer overflow fixes.
2691 (read_integer): Radix is now EMACS_INT, not int,
2692 to improve quality of diagnostics for out-of-range radices.
2693 Calculate buffer size correctly for out-of-range radices.
2694 (read1): Check for integer overflow in radices, and in
2695 read-circle numbers.
2696 (read_escape): Avoid int overflow.
2697 (Fload, openp, read_buffer_size, read1)
2698 (substitute_object_recurse, read_vector, read_list, map_obarray):
2699 Use ptrdiff_t, not int, for sizes.
2700 (read1): Use EMACS_INT, not int, for sizes.
2701 Check for size overflow.
2703 * image.c (cache_image): Check for size arithmetic overflow.
2705 * lread.c: Integer overflow issues.
2706 (saved_doc_string_size, saved_doc_string_length)
2707 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2708 Now ptrdiff_t, not int.
2709 (read1): Don't assume doc string length fits in int. Check for
2710 out-of-range doc string lengths.
2711 (read_list): Don't assume file position fits in int.
2712 (read_escape): Check for hex character overflow.
2714 2011-06-22 Leo Liu <sdl.web@gmail.com>
2716 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2717 Move to minibuffer.el.
2719 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2721 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2722 The following patches are for when GLYPH_DEBUG && !XASSERT.
2723 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2724 * dispnew.c (flush_stdout):
2725 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2726 Mark as externally visible.
2727 * dispnew.c (check_window_matrix_pointers): Now static.
2728 * dispnew.c (window_to_frame_vpos):
2729 * xfns.c (unwind_create_frame):
2730 * xterm.c (x_check_font): Remove unused local.
2731 * scroll.c (CHECK_BOUNDS):
2732 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2733 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2734 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2735 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2736 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2738 (debug_method_add): Use va_list and vsprintf rather than relying
2739 on undefined behavior with wrong number of arguments.
2740 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2741 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2742 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2743 since we're not interested in debugging glyphs with old libraries.
2744 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2745 GCC 4.6.0's static checking.
2747 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2749 Integer overflow and signedness fixes (Bug#8873).
2750 A few related buffer overrun fixes, too.
2752 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2754 * dispextern.h (struct face.stipple):
2755 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2756 (x_bitmap_mask, x_allocate_bitmap_record)
2757 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2758 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2759 (x_create_bitmap_from_xpm_data):
2760 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2761 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2763 * xfaces.c (load_pixmap):
2764 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2765 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2766 (.bitmaps_last, struct x_output.icon_bitmap):
2767 Use ptrdiff_t, not int, for bitmap indexes.
2768 (x_allocate_bitmap_record): Check for size overflow.
2769 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2771 Use ptrdiff_t, not int, for overlay counts.
2772 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2773 * editfns.c (overlays_around, get_pos_property):
2774 * textprop.c (get_char_property_and_overlay):
2775 * xdisp.c (next_overlay_change, note_mouse_highlight):
2776 * xfaces.c (face_at_buffer_position):
2777 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2778 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2779 (Fnext_overlay_change, Fprevious_overlay_change)
2780 (mouse_face_overlay_overlaps, Foverlays_in):
2781 Use ptrdiff_t, not int, for sizes.
2782 (overlays_at, overlays_in): Check for size-calculation overflow.
2784 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2786 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2787 (x_session_initialize): Do not assume string length fits in int.
2789 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2790 This is unlikely, but can occur if DPI is outlandish.
2792 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2793 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2795 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2796 * xrdb.c (magic_file_p, search_magic_path):
2797 Omit last arg SUFFIX; it was always 0. All callers changed.
2798 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2800 * xfont.c (xfont_match): Avoid need for strlen.
2802 * xfns.c: Don't assume strlen fits in int.
2803 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2805 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2806 not unsigned long, as we prefer signed integers. All callers changed.
2807 Detect integer overflow in repeat count.
2808 (message_dolog): Don't assume print length fits in 39 bytes.
2809 (display_mode_element): Don't assume strlen fits in int.
2811 * termcap.c: Don't assume sizes fit in int and never overflow.
2812 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2813 (gobble_line): Check for size-calculation overflow.
2815 * minibuf.c (Fread_buffer):
2816 * lread.c (intern, intern_c_string):
2817 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2818 Don't assume string length fits in int.
2820 * keyboard.c (parse_tool_bar_item):
2821 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2823 * font.c: Don't assume string length fits in int.
2824 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2825 Use ptrdiff_t, not int.
2826 (font_intern_prop): Don't assume string length fits in int.
2827 Don't assume integer property fits in fixnum.
2828 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2830 * filelock.c: Fix some buffer overrun and integer overflow issues.
2831 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2832 Reformulate so as not to need the command string.
2833 Invoke gzip -cd rather than gunzip, as it's more portable.
2834 (lock_info_type, lock_file_1, lock_file):
2835 Don't assume pid_t and time_t fit in unsigned long.
2836 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2837 (current_lock_owner): Prefer signed type for sizes.
2838 Use memcpy, not strncpy, where memcpy is what is really wanted.
2839 Don't assume (via atoi) that time_t and pid_t fit in int.
2840 Check for time_t and/or pid_t out of range, e.g., via a network share.
2841 Don't alloca where an auto var works fine.
2843 * fileio.c: Fix some integer overflow issues.
2844 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2845 Don't assume string length fits in int.
2846 (directory_file_name): Don't assume string length fits in long.
2847 (make_temp_name): Don't assume pid fits in int, or that its print
2848 length is less than 20.
2850 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2852 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2854 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2856 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2857 We prefer signed integers, even for size calculations.
2859 * emacs.c: Don't assume string length fits in 'int'.
2860 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2861 (main): Don't invoke strlen when not needed.
2863 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2864 (XD_DEBUG_MESSAGE): Don't waste a byte.
2866 * callproc.c (getenv_internal_1, getenv_internal)
2868 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2870 * lread.c (invalid_syntax): Omit length argument.
2871 All uses changed. This doesn't fix a bug, but it simplifies the
2872 code away from its former Hollerith-constant appearance, and it's
2873 one less 'int' to worry about when looking at integer-overflow issues.
2874 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2876 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2877 This didn't break anything, but it didn't help either.
2878 It's confusing to put a bogus integer in a place where the actual
2879 value does not matter.
2880 (LIST_END_P): Remove unused macro and its bogus comment.
2881 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2883 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2884 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2886 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2887 We prefer signed types, and the value cannot exceed the EMACS_INT
2888 range anyway (because otherwise the length would not be representable).
2889 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2890 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2891 This avoids a GCC warning when WIDE_EMACS_INT.
2893 * indent.c (sane_tab_width): New function.
2894 (current_column, scan_for_column, Findent_to, position_indentation)
2895 (compute_motion): Use it. This is just for clarity.
2896 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2898 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2900 * lisp.h (lint_assume): New macro.
2901 * composite.c (composition_gstring_put_cache):
2902 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2904 * editfns.c, insdel.c:
2905 Omit unnecessary forward decls, to simplify future changes.
2907 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2909 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2911 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2912 Use much-faster test for byte-length change.
2913 Don't assume string byte-length fits in 'int'.
2914 Check that character arg fits in 'int'.
2915 (mapcar1): Declare byte as byte, for clarity.
2917 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2919 * fns.c (concat): Catch string overflow earlier.
2920 Do not rely on integer wraparound.
2922 * dispextern.h (struct it.overlay_strings_charpos)
2923 (struct it.selective): Now EMACS_INT, not int.
2924 * xdisp.c (forward_to_next_line_start)
2925 (back_to_previous_visible_line_start)
2926 (reseat_at_next_visible_line_start, next_element_from_buffer):
2927 Don't arbitrarily truncate the value of 'selective' to int.
2929 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2931 * composite.c: Don't truncate sizes to 'int'.
2932 (composition_gstring_p, composition_reseat_it)
2933 (composition_adjust_point): Use EMACS_INT, not int.
2934 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2935 not EMACS_UINT, for indexes.
2937 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2939 * buffer.c: Include <verify.h>.
2940 (struct sortvec.priority, struct sortstr.priority):
2941 Now EMACS_INT, not int.
2942 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2943 (struct sortstr.size, record_overlay_string)
2944 (struct sortstrlist.size, struct sortlist.used):
2945 Don't truncate size to int.
2946 (record_overlay_string): Check for size-calculation overflow.
2947 (init_buffer_once): Check at compile-time, not run-time.
2949 2011-06-22 Jim Meyering <meyering@redhat.com>
2951 Don't leak an XBM-image-sized buffer
2952 * image.c (xbm_load): Free the image buffer after using it.
2954 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2957 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2958 that Sun C diagnosed.
2959 * fns.c (secure_hash): Fix pointer signedness issue.
2960 * intervals.c (static_offset_intervals): New function.
2961 (offset_intervals): Use it.
2963 2011-06-21 Leo Liu <sdl.web@gmail.com>
2966 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2969 * fns.c (secure_hash): Rename from crypto_hash_function and change
2970 the first arg to accept symbols.
2971 (Fsecure_hash): New primitive.
2972 (syms_of_fns): New symbols.
2974 2011-06-20 Deniz Dogan <deniz@dogan.se>
2976 * process.c (Fset_process_buffer): Clarify return value in
2979 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2981 * dispnew.c (add_window_display_history): Use BVAR.
2983 * xdisp.c (debug_method_add): Use BVAR.
2984 (check_window_end, dump_glyph_matrix, dump_glyph)
2985 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2987 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2990 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2991 check till after the cache is created in init_frame_faces.
2993 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2995 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2997 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2999 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3000 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3001 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3003 Improve buffer-overflow checking (Bug#8873).
3004 * fileio.c (Finsert_file_contents):
3005 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3006 Remove the old (too-loose) buffer overflow checks.
3007 They weren't needed, since make_gap checks for buffer overflow.
3008 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3009 The old code merely checked for Emacs fixnum overflow, and relied
3010 on undefined (wraparound) behavior. The new code avoids undefined
3011 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3013 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3014 Tune. Don't use wider integers than needed. Don't use alloca.
3015 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3017 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3019 * insdel.c, lisp.h (buffer_overflow): New function.
3020 (insert_from_buffer_1, replace_range, replace_range_2):
3021 * insdel.c (make_gap_larger):
3022 * editfns.c (Finsert_char):
3023 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3025 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3027 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3029 Integer overflow and signedness fixes (Bug#8873).
3031 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3032 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3034 * fileio.c: Don't assume EMACS_INT fits in off_t.
3035 (emacs_lseek): New static function.
3036 (Finsert_file_contents, Fwrite_region): Use it.
3037 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3039 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3041 * fns.c: Don't overflow int when computing a list length.
3042 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3043 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3044 truncation on 64-bit hosts. Check for QUIT every
3045 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3046 faster and is responsive enough.
3047 (Flength): Report an error instead of overflowing an integer.
3048 (Fsafe_length): Return a float if the value is not representable
3049 as a fixnum. This shouldn't happen except in contrived situations.
3050 (Fnthcdr, Fsort): Don't assume list length fits in int.
3051 (Fcopy_sequence): Don't assume vector length fits in int.
3053 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3054 (header_size, word_size): New constants.
3055 (allocate_vectorlike): Don't check size overflow here.
3056 (allocate_vector): Check it here instead, since this is the only
3057 caller of allocate_vectorlike that could cause overflow.
3058 Check that the new vector's length is representable as a fixnum.
3060 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3061 The previous code was bogus. For example, next_almost_prime (32)
3062 returned 39, which is undesirable as it is a multiple of 3; and
3063 next_almost_prime (24) returned 25, which is a multiple of 5 so
3064 why was the code bothering to check for multiples of 7?
3066 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3068 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3070 Variadic C functions now count arguments with ptrdiff_t.
3071 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3072 Back then I didn't know that the Emacs coding style prefers signed int.
3073 Also, in the meantime I found a few more instances where arguments
3074 were being counted with int, which may truncate counts on 64-bit
3075 machines, or EMACS_INT, which may be unnecessarily wide.
3076 * lisp.h (struct Lisp_Subr.function.aMANY)
3077 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3078 Arg counts are now ptrdiff_t, not size_t.
3079 All variadic functions and their callers changed accordingly.
3080 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3081 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3082 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3083 * callint.c (Fcall_interactively): Check arg count for overflow,
3084 to avoid potential buffer overrun. Use signed char, not 'int',
3085 for 'varies' array, so that we needn't bother to check its size
3086 calculation for overflow.
3087 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3088 * eval.c (apply_lambda):
3089 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3090 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3091 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3093 * callint.c (Fcall_interactively): Don't use index var as event count.
3095 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3096 * mem-limits.h (SIZE): Remove; no longer used.
3098 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3100 Remove unnecessary casts.
3101 * xterm.c (x_term_init):
3102 * xfns.c (x_set_border_pixel):
3103 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3104 These aren't needed now that we assume ANSI C.
3106 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3107 It's more likely to cause problems (due to unsigned overflow)
3110 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3112 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3114 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3116 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3118 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3120 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3122 GLYPH_CODE_FACE returns EMACS_INT, not int.
3123 * dispextern.h (merge_faces):
3124 * xfaces.c (merge_faces):
3125 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3126 Don't assume EMACS_INT fits in int.
3128 * character.h (CHAR_VALID_P): Remove unused parameter.
3129 * fontset.c, lisp.h, xdisp.c: All uses changed.
3131 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3133 * fns.c (concat): Minor tuning based on overflow analysis.
3134 This doesn't fix any bugs. Use int to hold character, instead
3135 of constantly refetching from Emacs object. Use XFASTINT, not
3136 XINT, for value known to be a character. Don't bother comparing
3137 a single byte to 0400, as it's always less.
3139 * floatfns.c (Fexpt):
3140 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3142 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3145 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3147 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3148 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3149 incorrectly succeed when S was a string, because 4294967386 was
3150 truncated before it was used.
3152 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3153 Otherwise, an out-of-range integer could cause undefined behavior
3156 * composite.c: Use int, not EMACS_INT, for characters.
3157 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3158 EMACS_INT, for values that are known to be in character range.
3159 This doesn't fix any bugs but is the usual style inside Emacs and
3160 may generate better code on 32-bit machines.
3162 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3163 This is for reasons similar to the recent CHAR_STRING fix.
3164 * charset.c (Fencode_char): Check that character arg is actually
3165 a character. Pass an int to ENCODE_CHAR.
3166 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3167 wider than 'int', as a compile-time check to prevent future regressions
3170 * character.c (char_string): Remove unnecessary casts.
3172 Make sure a 64-bit char is never passed to CHAR_STRING.
3173 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3174 by silently ignoring the top 32 bits, allowing some values
3175 that were far too large to be valid characters.
3176 * character.h: Include <verify.h>.
3177 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3178 arguments are no wider than unsigned, as a compile-time check
3179 to prevent future regressions in this area.
3181 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3182 (Fsubst_char_in_region):
3184 * xdisp.c (decode_mode_spec_coding):
3185 Adjust to CHAR_STRING's new requirement.
3186 * editfns.c (Finsert_char, Fsubst_char_in_region):
3187 * fns.c (concat): Check that character args are actually
3188 characters. Without this test, these functions did the wrong
3189 thing with wildly out-of-range values on 64-bit hosts.
3191 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3192 These casts should not be needed on 32-bit hosts, either.
3193 * keyboard.c (read_char):
3194 * lread.c (Fload): Remove casts to unsigned.
3196 * lisp.h (UNSIGNED_CMP): New macro.
3197 This fixes comparison bugs on 64-bit hosts.
3198 (ASCII_CHAR_P): Use it.
3199 * casefiddle.c (casify_object):
3200 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3201 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3202 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3203 * dispextern.h (FACE_FROM_ID):
3204 * keyboard.c (read_char): Use UNSIGNED_CMP.
3206 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3207 not to EMACS_INT, to avoid GCC warning.
3209 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3211 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3212 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3213 isn't needed on 32-bit machines.
3215 * buffer.c (Fgenerate_new_buffer_name):
3216 Use EMACS_INT for count, not int.
3217 (advance_to_char_boundary): Return EMACS_INT, not int.
3219 * data.c (Qcompiled_function): Now static.
3221 * window.c (window_body_lines): Now static.
3223 * image.c (gif_load): Rename local to avoid shadowing.
3225 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3226 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3227 * alloc.c (make_save_value): Integer argument is now of type
3229 (mark_object): Use ptrdiff_t, not int.
3230 * lisp.h (pD): New macro.
3231 * print.c (print_object): Use it.
3233 * alloc.c: Use EMACS_INT, not int, to count objects.
3234 (total_conses, total_markers, total_symbols, total_vector_size)
3235 (total_free_conses, total_free_markers, total_free_symbols)
3236 (total_free_floats, total_floats, total_free_intervals)
3237 (total_intervals, total_strings, total_free_strings):
3238 Now EMACS_INT, not int. All uses changed.
3239 (Fgarbage_collect): Compute overall total using a double, so that
3240 integer overflow is less likely to be a problem. Check for overflow
3241 when converting back to an integer.
3242 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3243 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3244 These were 'int' variables that could overflow on 64-bit hosts;
3245 they were never used, so remove them instead of repairing them.
3246 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3247 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3248 Previously, this ceilinged at INT_MAX, but that doesn't work on
3250 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3252 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3253 (allocate_vectorlike): Check for ptrdiff_t overflow.
3254 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3255 when a (possibly-narrower) signed value would do just as well.
3256 We prefer using signed arithmetic, to avoid comparison confusion.
3258 * alloc.c: Catch some string size overflows that we were missing.
3259 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3260 for convenience in STRING_BYTES_MAX.
3261 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3262 The definition here is exact; the one in lisp.h was approximate.
3263 (allocate_string_data): Check for string overflow. This catches
3264 some instances we weren't catching before. Also, it catches
3265 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3266 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3267 and ptrdiff_t and EMACS_INT are both 64 bits.
3269 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3270 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3271 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3273 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3275 * alloc.c (Fmake_string): Check for out-of-range init.
3277 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3279 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3281 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3283 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3284 xg_get_default_scrollbar_width.
3286 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3287 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3288 (style_changed_cb): Call update_theme_scrollbar_width and call
3289 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3290 all frames (Bug#8505).
3291 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3292 Call gtk_window_set_resizable if HAVE_GTK3.
3293 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3294 and height if HAVE_GTK3 (Bug#8505).
3295 (scroll_bar_width_for_theme): New variable.
3296 (update_theme_scrollbar_width): New function.
3297 (xg_get_default_scrollbar_width): Move code to
3298 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3299 (xg_initialize): Call update_theme_scrollbar_width.
3301 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3303 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3305 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3307 * frame.c (make_frame): Call other_buffer_safely instead of
3310 * window.c (temp_output_buffer_show): Call display_buffer with
3311 second argument Vtemp_buffer_show_specifiers and reset latter
3312 immediately after the call.
3313 (Vtemp_buffer_show_specifiers): New variable.
3314 (auto_window_vscroll_p, next_screen_context_lines)
3315 (Vscroll_preserve_screen_position): Remove leading asterisks from
3318 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3320 Fix minor problems found by GCC 4.6.0 static checking.
3321 * buffer.c (Qclone_number): Remove for now, as it's unused.
3322 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3323 (record_buffer): Remove unused local.
3324 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3325 (set_frame_buffer_list): Remove; unused.
3326 * frame.h (other_visible_frames): Remove decl.
3327 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3328 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3329 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3331 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3332 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3333 Define only if HAVE_GPM.
3334 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3335 (update_hints_inhibit): Remove; never set. All uses removed.
3336 * widgetprv.h (emacsFrameClassRec): Remove decl.
3337 * window.c (delete_deletable_window): Now returns void, since it
3338 wasn't returning anything.
3339 (compare_window_configurations): Remove unused locals.
3340 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3341 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3342 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3343 the same widths as pointers. This follows up on the 2011-05-06 patch.
3344 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3345 * xterm.h: Likewise.
3346 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3348 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3350 * makefile.w32-in: Update dependencies.
3351 (LISP_H): Add lib/intprops.h.
3353 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3355 * image.c (gif_load): Add animation frame delay to the metadata.
3356 (syms_of_image): Use DEFSYM. New symbol `delay'.
3358 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3360 * window.c (delete_deletable_window): Re-add.
3361 (Fset_window_configuration): Rewrite to handle dead buffers and
3362 consequently deletable windows.
3363 (window_tree, Fwindow_tree): Remove. Supply functionality in
3365 (compare_window_configurations): Simplify code.
3367 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3369 * image.c (imagemagick_load_image): Fix type mismatch.
3370 (Fimagemagick_types): Likewise.
3372 * window.h (replace_buffer_in_windows): Declare.
3374 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3376 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3377 Qclone_number. Remove external declaration of Qdelete_window.
3378 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3380 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3381 Run Qbuffer_list_update_hook if allowed.
3382 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3383 buffer list implementation.
3384 (other_buffer_safely): New function.
3385 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3386 calls to replace_buffer_in_windows and
3387 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3389 (record_buffer): Inhibit quitting and rewrite using quittable
3390 functions. Run Qbuffer_list_update_hook if allowed.
3391 (Frecord_buffer, Funrecord_buffer): New functions.
3392 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3393 Move switch-to-buffer to window.el.
3394 (bury-buffer): Move to window.el.
3395 (Vbuffer_list_update_hook): New variable.
3397 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3400 * window.h (resize_frame_windows): Move up in code.
3401 (Fwindow_frame): Remove EXFUN.
3402 (replace_buffer_in_all_windows): Remove prototype.
3403 (replace_buffer_in_windows_safely): Add prototype.
3405 * window.c: Declare Qdelete_window static again. Move down
3406 declaration of select_count.
3407 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3408 (Fother_window): Move to window.el.
3409 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3410 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3411 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3413 (replace_buffer_in_windows): Implement by calling
3414 Qreplace_buffer_in_windows.
3415 (replace_buffer_in_all_windows): Remove with some functionality
3416 moved into replace_buffer_in_windows_safely.
3417 (replace_buffer_in_windows_safely): New function.
3418 (select_window_norecord, select_frame_norecord): Move in front
3419 of run_window_configuration_change_hook. Remove now obsolete
3421 (Fset_window_buffer): Rewrite doc-string.
3422 Call Qrecord_window_buffer.
3423 (keys_of_window): Move binding for other-window to window.el.
3425 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3427 * dispextern.h (struct image): Replace data member, whose int_val
3428 and ptr_val fields were not used by anything, with a single
3431 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3432 (gif_clear_image, gif_load, imagemagick_load_image)
3433 (gs_clear_image, gs_load): Callers changed.
3435 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3437 * buffer.h: Include <time.h>, for time_t.
3438 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3440 Fix minor problems found by static checking.
3442 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3444 Make identifiers static if they are not used in other modules.
3445 * data.c (Qcompiled_function, Qframe, Qvector):
3446 * image.c (QimageMagick, Qsvg):
3447 * minibuf.c (Qmetadata):
3448 * window.c (resize_window_check, resize_root_window): Now static.
3449 * window.h (resize_window_check, resize_root_window): Remove decls.
3451 * window.c (window_deletion_count, delete_deletable_window):
3453 (window_body_lines): Now static.
3454 (Fdelete_other_windows_internal): Mark vars as initialized.
3455 Make sure 'resize_failed' is initialized.
3456 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3457 (resize_window_apply): Remove unused local.
3458 * window.h (delete_deletable_window): Remove decl.
3460 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3461 (imagemagick_load_image): Fix pointer signedness problem by changing
3462 last arg from unsigned char * to char *. All uses changed.
3463 Also, fix a local for similar reasons.
3464 Remove unused locals. Remove locals to avoid shadowing.
3465 (fn_rsvg_handle_free): Remove; unused.
3466 (svg_load, svg_load_image): Fix pointer signedness problem.
3467 (imagemagick_load_image): Don't use garbage pointer image_wand.
3469 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3471 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3473 * image.c (gif_load): Fix omitted cast error introduced by
3476 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3478 * window.h (resize_proportionally, orig_total_lines)
3479 (orig_top_line): Remove from window structure.
3480 (set_window_height, set_window_width, change_window_heights)
3481 (Fdelete_window): Remove prototypes.
3482 (resize_frame_windows): Remove duplicate declaration.
3484 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3486 * window.h (resize_frame_windows, resize_window_check)
3487 (delete_deletable_window, resize_root_window)
3488 (resize_frame_windows): Declare prototypes.
3490 * window.c (resize_window_apply): Make definition be "static" to
3491 match the prototype.
3493 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3495 * window.c: Remove declarations of Qwindow_size_fixed,
3496 window_min_size_1, window_min_size_2, window_min_size,
3497 size_window, window_fixed_size_p, enlarge_window, delete_window.
3498 Remove static from declaration of Qdelete_window, it's
3499 temporarily needed by Fbury_buffer.
3500 (replace_window): Don't assign orig_top_line and
3502 (Fdelete_window, delete_window): Remove. Window deletion is
3503 handled by window.el.
3504 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3505 Replace Fdelete_window calls with calls to Qdelete_window.
3506 (Fdelete_other_windows): Remove. Deleting other windows is
3507 handled by window.el.
3508 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3509 handled in window.el.
3510 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3511 Window minimum sizes are handled in window.el.
3512 (shrink_windows, size_window, set_window_height)
3513 (set_window_width, change_window_heights, window_height)
3514 (window_width, CURBEG, CURSIZE, enlarge_window)
3515 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3516 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3517 handled in window.el.
3518 (make_dummy_parent): Rename to make_parent_window and give it a
3519 second argument horflag.
3520 (make_window): Don't set resize_proportionally any more.
3521 (Fsplit_window): Remove. Windows are split in window.el.
3522 (save_restore_action, save_restore_orig_size)
3523 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3524 Resize mini windows in window.el.
3525 (grow_mini_window, shrink_mini_window): Implement by calling
3526 Qresize_root_window_vertically, resize_window_check and
3527 resize_window_apply.
3528 (saved_window, Fset_window_configuration, save_window_save):
3529 Do not handle orig_top_line, orig_total_lines, and
3530 resize_proportionally.
3531 (window_min_height, window_min_width): Move to window.el.
3532 (keys_of_window): Move bindings for delete-other-windows,
3533 split-window, delete-window and enlarge-window to window.el.
3535 * buffer.c: Temporarily extern Qdelete_window.
3536 (Fbury_buffer): Temporarily call Qdelete_window instead of
3537 Fdelete_window (Fbury_buffer will move to window.el soon).
3539 * frame.c (set_menu_bar_lines_1): Remove code handling
3540 orig_top_line and orig_total_lines.
3542 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3543 set_window_height but set heights directly.
3544 (change_frame_size_1): Use resize_frame_windows.
3546 * xdisp.c (init_xdisp): Don't use set_window_height but set
3549 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3550 Use resize_frame_windows instead of change_window_heights and run
3551 run_window_configuration_change_hook.
3553 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3554 instead of change_window_heights and run
3555 run_window_configuration_change_hook.
3557 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3559 * window.c (replace_window): Rename second argument REPLACEMENT to
3560 NEW. New third argument SETFLAG. Rewrite.
3561 (delete_window, make_dummy_parent): Call replace_window with
3563 (window_list_1): Move down in code.
3564 (run_window_configuration_change_hook): Move set_buffer part
3565 before select_frame_norecord part in order to unwind correctly.
3566 Rename count1 to count.
3567 (recombine_windows, delete_deletable_window, resize_root_window)
3568 (Fdelete_other_windows_internal)
3569 (Frun_window_configuration_change_hook, make_parent_window)
3570 (resize_window_check, resize_window_apply, Fresize_window_apply)
3571 (resize_frame_windows, Fsplit_window_internal)
3572 (Fdelete_window_internal, Fresize_mini_window_internal):
3574 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3576 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3578 * window.h (window): Add some new members to window structure -
3579 normal_lines, normal_cols, new_total, new_normal, clone_number,
3580 splits, nest, prev_buffers, next_buffers.
3581 (WINDOW_TOTAL_SIZE): Move here from window.c.
3582 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3584 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3586 (make_dummy_parent): Set new members of windows structure.
3587 (make_window): Move down in code. Handle new members of window
3589 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3590 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3591 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3592 (Fset_window_prev_buffers, Fwindow_next_buffers)
3593 (Fset_window_next_buffers, Fset_window_clone_number):
3595 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3596 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3598 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3599 Argument WINDOW can be now internal window too.
3600 (Fwindow_use_time): Move up in code.
3601 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3603 (Fset_window_configuration, saved_window)
3604 (Fcurrent_window_configuration, save_window_save): Handle new
3605 members of window structure.
3606 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3607 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3608 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3609 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3610 Qget_mru_window, Qresize_root_window,
3611 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3612 Qauto_buffer_name; staticpro them.
3614 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3616 * window.c (Fwindow_total_size, Fwindow_left_column)
3617 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3618 (Fwindow_list_1): New functions.
3619 (window_box_text_cols): Replace with window_body_cols.
3620 (Fwindow_width, Fscroll_left, Fscroll_right):
3621 Use window_body_cols instead of window_box_text_cols.
3622 (delete_window, Fset_window_configuration):
3623 Call delete_all_subwindows with window as argument.
3624 (delete_all_subwindows): Take a window as argument and not a
3626 (window_loop): Remove handling of GET_LRU_WINDOW and
3628 (Fget_lru_window, Fget_largest_window): Move to window.el.
3630 * window.h: Extern window_body_cols instead of
3631 window_box_text_cols. delete_all_subwindows now takes a
3632 Lisp_Object as argument.
3634 * indent.c (compute_motion, Fcompute_motion):
3635 Use window_body_cols instead of window_box_text_cols.
3637 * frame.c (delete_frame): Call delete_all_subwindows with root
3640 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3642 * fns.c (Fputhash): Document return value.
3644 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3646 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3648 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3650 Cons<->int and similar integer overflow fixes (Bug#8794).
3652 Check for overflow when converting integer to cons and back.
3653 * charset.c (Fdefine_charset_internal, Fdecode_char):
3654 Use cons_to_unsigned to catch overflow.
3655 (Fencode_char): Use INTEGER_TO_CONS.
3656 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3657 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3658 * data.c (long_to_cons, cons_to_long): Remove.
3659 (cons_to_unsigned, cons_to_signed): New functions.
3660 These signal an error for invalid or out-of-range values.
3661 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3662 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3663 * font.c (Ffont_variation_glyphs):
3664 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3665 * lisp.h: Include <intprops.h>.
3666 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3667 (cons_to_signed, cons_to_unsigned): New decls.
3668 (long_to_cons, cons_to_long): Remove decls.
3669 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3670 (Fprimitive_undo): Use CONS_TO_INTEGER.
3671 * xfns.c (Fx_window_property): Likewise.
3672 * xselect.c: Include <limits.h>.
3673 (x_own_selection, selection_data_to_lisp_data):
3674 Use INTEGER_TO_CONS.
3675 (x_handle_selection_request, x_handle_selection_clear)
3676 (x_get_foreign_selection, Fx_disown_selection_internal)
3677 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3678 (lisp_data_to_selection_data): Use cons_to_unsigned.
3679 (x_fill_property_data): Use cons_to_signed.
3680 Report values out of range.
3682 Check for buffer and string overflow more precisely.
3683 * buffer.h (BUF_BYTES_MAX): New macro.
3684 * lisp.h (STRING_BYTES_MAX): New macro.
3685 * alloc.c (Fmake_string):
3686 * character.c (string_escape_byte8):
3687 * coding.c (coding_alloc_by_realloc):
3688 * doprnt.c (doprnt):
3689 * editfns.c (Fformat):
3691 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3692 since they may not be the same number.
3693 * editfns.c (Finsert_char):
3694 * fileio.c (Finsert_file_contents):
3695 Likewise for BUF_BYTES_MAX.
3697 * image.c: Use ptrdiff_t, not int, for sizes.
3698 (slurp_file): Switch from int to ptrdiff_t.
3700 (slurp_file): Check that file size fits in both size_t (for
3701 malloc) and ptrdiff_t (for sanity and safety).
3703 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3704 if b->modtime has its maximal value.
3706 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3708 Don't assume time_t can fit into int.
3709 * buffer.h (struct buffer.modtime): Now time_t, not int.
3710 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3711 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3713 Minor fixes for signed vs unsigned integers.
3714 * character.h (MAYBE_UNIFY_CHAR):
3715 * charset.c (maybe_unify_char):
3716 * keyboard.c (read_char, reorder_modifiers):
3717 XINT -> XFASTINT, since the integer must be nonnegative.
3718 * ftfont.c (ftfont_spec_pattern):
3719 * keymap.c (access_keymap, silly_event_symbol_error):
3720 XUINT -> XFASTINT, since the integer must be nonnegative.
3721 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3722 since it makes no difference and we prefer signed.
3723 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3724 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3727 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3729 * window.h (Fwindow_frame): Declare.
3731 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3733 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3734 (SPARE_MEMORY): Always define.
3735 (LARGE_REQUEST): Remove.
3736 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3738 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3740 * lisp.h: Move EXFUNS for Fframe_root_window,
3741 Fframe_first_window and Fset_frame_selected_window to window.h.
3743 * window.h: Move EXFUNS for Fframe_root_window,
3744 Fframe_first_window and Fset_frame_selected_window here from
3747 * frame.c (Fwindow_frame, Fframe_first_window)
3748 (Fframe_root_window, Fframe_selected_window)
3749 (Fset_frame_selected_window): Move to window.c.
3750 (Factive_minibuffer_window): Move to minibuf.c.
3751 (Fother_visible_frames_p): New function.
3753 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3755 * window.c (decode_window, decode_any_window): Move up in code.
3756 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3757 (inhibit_frame_unsplittable): Remove unused variable.
3758 (Fwindow_buffer): Move up and rewrite doc-string.
3759 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3760 (Fwindow_prev): New functions.
3761 (Fwindow_frame): Move here from frame.c. Accept any window as
3763 (Fframe_root_window, Fframe_first_window)
3764 (Fframe_selected_window): Move here from frame.c. Accept frame
3765 or arbitrary window as argument. Update doc-strings.
3766 (Fminibuffer_window): Move up in code.
3767 (Fwindow_minibuffer_p): Move up in code and simplify.
3768 (Fset_frame_selected_window): Move here from frame.c.
3770 (Fselected_window, select_window, Fselect_window): Move up in
3771 code. Minor doc-string fixes.
3773 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3775 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3776 Do not assume that spare memory exists; that assumption is valid
3777 only if SYSTEM_MALLOC.
3778 (LARGE_REQUEST): New macro, so that the issue of large requests
3779 is separated from the issue of spare memory.
3781 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3783 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3786 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3788 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3791 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3793 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3795 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3797 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3798 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3800 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3802 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3804 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3806 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3807 (x_clipboard_manager_save): Add return value.
3808 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3810 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3811 Obey Vx_select_enable_clipboard_manager. Catch errors in
3812 x_clipboard_manager_save (Bug#8779).
3813 (Vx_select_enable_clipboard_manager): New variable.
3814 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3816 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3818 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3820 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3822 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3823 in the current matrix if keep_current_p is non-zero.
3825 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3827 * bidi.c (bidi_level_of_next_char): Fix last change.
3829 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3831 Support bidi reordering of text covered by display properties.
3833 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3834 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3835 (bidi_cache_search, bidi_cache_iterator_state)
3836 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3837 (bidi_level_of_next_char, bidi_move_to_visually_next):
3838 Support character positions inside a run of characters covered by a
3840 (bidi_paragraph_init, bidi_resolve_explicit_1)
3841 (bidi_level_of_next_char): Call bidi_fetch_char and
3842 bidi_fetch_char_advance instead of FETCH_CHAR and
3844 (bidi_init_it): Initialize new members.
3845 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3847 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3848 instead of using explicit *_CHAR codes.
3849 (bidi_resolve_explicit, bidi_resolve_weak):
3850 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3851 bidirectional text is supported only in multibyte buffers.
3852 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3853 it to initialize the frame_window_p member of struct bidi_it.
3854 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3855 (bidi_resolve_explicit, bidi_resolve_weak)
3856 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3857 bidi_it->nchars is non-positive.
3858 (bidi_level_of_next_char): Don't try to lookup the cache for the
3859 next/previous character if nothing is cached there yet, or if we
3860 were just reseat()'ed to a new position.
3862 * xdisp.c (set_cursor_from_row): Set start and stop points
3863 according to the row's direction when priming the loop that looks
3864 for the glyph on which to display cursor.
3865 (single_display_spec_intangible_p): Function deleted.
3866 (display_prop_intangible_p): Reimplement to call
3867 handle_display_spec instead of single_display_spec_intangible_p.
3868 Accept 3 additional arguments needed by handle_display_spec.
3869 This fixes incorrect cursor motion across display property with complex
3870 values: lists, `(when COND...)' forms, etc.
3871 (single_display_spec_string_p): Support property values that are
3872 lists with the argument STRING its top-level element.
3873 (display_prop_string_p): Fix the condition for processing a
3874 property that is a list to be consistent with handle_display_spec.
3875 (handle_display_spec): New function, refactored from the
3876 last portion of handle_display_prop.
3877 (compute_display_string_pos): Accept additional argument
3878 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3879 value of a `display' property is a "replacing spec".
3880 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3881 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3882 the display property, but just return a value indicating whether
3883 the display property will replace the characters it covers.
3884 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3885 frame_window_p members of struct bidi_it.
3886 (compute_display_string_pos, compute_display_string_end):
3888 (push_it): Accept second argument POSITION, where pop_it should
3889 jump to continue iteration.
3890 (reseat_1): Initialize bidi_it.disp_pos.
3892 * keyboard.c (adjust_point_for_property): Adjust the call to
3893 display_prop_intangible_p to its new signature.
3895 * dispextern.h (struct bidi_it): New member frame_window_p.
3896 (bidi_init_it): Update prototypes.
3897 (display_prop_intangible_p): Update prototype.
3898 (compute_display_string_pos, compute_display_string_end):
3900 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3903 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3905 Malloc failure behavior now depends on size of allocation.
3906 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3907 * lisp.h: Change signatures accordingly.
3908 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3909 All callers changed. (Bug#8762)
3911 * gnutls.c: Use Emacs's memory allocators.
3912 Without this change, the gnutls library would invoke malloc etc.
3913 directly, which causes problems on non-SYNC_INPUT hosts, and which
3914 runs afoul of improving memory_full behavior. (Bug#8761)
3915 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3916 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3917 xfree instead of the default malloc, realloc, free.
3918 (Fgnutls_boot): No need to check for memory allocation failure,
3919 since xmalloc does that for us.
3921 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3922 * category.c (hash_get_category_set):
3923 * ccl.c (ccl_driver):
3924 * charset.c (Fdefine_charset_internal):
3925 * charset.h (struct charset.hash_index):
3926 * composite.c (get_composition_id, gstring_lookup_cache)
3927 (composition_gstring_put_cache):
3928 * composite.h (struct composition.hash_index):
3929 * dispextern.h (struct image.hash):
3930 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3931 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3932 (hashfn_equal, hashfn_user_defined, make_hash_table)
3933 (maybe_resize_hash_table, hash_lookup, hash_put)
3934 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3935 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3936 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3937 * image.c (make_image, search_image_cache, lookup_image)
3938 (xpm_put_color_table_h):
3939 * lisp.h (struct Lisp_Hash_Table):
3940 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3941 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3942 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3943 * alloc.c (allocate_vectorlike):
3944 Check for overflow in vector size calculations.
3945 * ccl.c (ccl_driver):
3946 Check for overflow when converting EMACS_INT to int.
3947 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3948 need to be updated by these changes.
3949 * fns.c (make_hash_table, maybe_resize_hash_table):
3950 Check for integer overflow with large hash tables.
3951 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3952 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3953 (SXHASH_REDUCE): New macro.
3954 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3955 Use it instead of discarding useful hash info with large hash values.
3956 (sxhash_float): New function.
3957 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3958 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3959 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3960 Rewrite to use FIXNUM_BITS, as this simplifies things.
3961 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3962 Adjust signatures to match updated version of code.
3963 (consing_since_gc): Now EMACS_INT, since a single hash table can
3964 use more than INT_MAX bytes.
3966 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3968 Make it possible to build with GCC-4.6+ -O2 -flto.
3970 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3972 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3974 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3975 Call minibuffer-inactive-mode.
3977 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3979 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3980 Update dependencies.
3982 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3984 * data.c (init_data): Remove code for UTS, this system is not
3987 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3989 Don't force ./temacs to start in terminal mode.
3991 * frame.c (make_initial_frame): Initialize faces in all cases, not
3992 only when CANNOT_DUMP is defined.
3993 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3995 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3997 * dispnew.c (add_window_display_history): Use const for the string
3998 pointer. Remove declaration, not needed.
4000 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4002 Use 'inline', not 'INLINE'.
4003 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4004 * alloc.c, fontset.c (INLINE): Remove.
4005 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4006 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4007 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4008 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4009 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4011 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4013 Make it possible to run ./temacs.
4015 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4016 syms_of_callproc does the same thing. Remove test for
4017 "initialized", do it in the caller.
4018 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4020 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4022 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4023 (read_minibuf): Use get_minibuffer.
4024 (syms_of_minibuf): Use DEFSYM.
4025 (Qmetadata): New var.
4026 * data.c (Qbuffer): Don't make it static.
4027 (syms_of_data): Use DEFSYM.
4029 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4031 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4032 (CCL_CODE_MIN): New macro.
4034 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4036 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4038 * eval.c (Qdebug): Now static.
4039 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4040 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4041 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4043 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4045 * image.c: Various fixes to ImageMagick code comments.
4046 (Fimagemagick_types): Doc fix.
4048 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4050 Minor fixes prompted by GCC 4.6.0 warnings.
4052 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4054 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4055 (x_clipboard_manager_save_all): Move extern decl to ...
4056 * xterm.h: ... here, so that it can be checked for consistency.
4058 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4060 * xselect.c (x_clipboard_manager_save_frame)
4061 (x_clipboard_manager_save_all): New functions.
4062 (Fx_clipboard_manager_save): Lisp function deleted.
4064 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4065 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4067 * xterm.h: Update prototype.
4069 2011-05-28 William Xu <william.xwl@gmail.com>
4071 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4074 2011-05-28 Jim Meyering <meyering@redhat.com>
4076 Avoid a sign-extension bug in crypto_hash_function.
4077 * fns.c (to_uchar): Define.
4078 (crypto_hash_function): Use it to convert some newly-signed
4079 variables to unsigned, to avoid sign-extension bugs. For example,
4080 without this change, (md5 "truc") would evaluate to
4081 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4082 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4083 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4085 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4087 Integer overflow fixes.
4089 * dbusbind.c: Serial number integer overflow fixes.
4090 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4091 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4092 to hold a serial number that is too large for a fixnum.
4093 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4094 Check for serial numbers out of range. Decode any serial number
4095 that was so large that it became a float. (Bug#8722)
4097 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4098 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4099 Use XFASTINT rather than XUINT when numbers are nonnegative.
4100 (xd_append_arg, Fdbus_method_return_internal):
4101 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4102 arguments, check that Lisp number is nonnegative, rather than
4103 silently wrapping negative numbers around. (Bug#8722)
4104 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4107 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4109 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4111 ccl: add integer overflow checks
4112 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4113 (IN_INT_RANGE): New macros.
4114 (ccl_driver): Use them to check for integer overflow when
4115 decoding a CCL program. Many of the new checks are whether XINT (x)
4116 fits in int; it doesn't always, on 64-bit hosts. The new version
4117 doesn't catch all possible integer overflows, but it's an
4118 improvement. (Bug#8719)
4120 * alloc.c (make_event_array): Use XINT, not XUINT.
4121 There's no need for unsigned here.
4123 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4124 This follows up to the 2011-05-06 change that substituted uintptr_t
4125 for EMACS_INT. This case wasn't caught back then.
4127 Rework Fformat to avoid integer overflow issues.
4128 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4129 now (part of C89). Include <verify.h>.
4130 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4131 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4132 (Fformat): Avoid the prepass trying to compute sizes; it was only
4133 approximate and thus did not catch overflow reliably. Instead, walk
4134 through the format just once, formatting and computing sizes as we go,
4135 checking for integer overflow at every step, and allocating a larger
4136 buffer as needed. Keep track separately whether the format is
4137 multibyte. Keep only the most-recently calculated precision, rather
4138 than them all. Record whether each argument has been converted to
4139 string. Use EMACS_INT, not int, for byte and char and arg counts.
4140 Support field widths and precisions larger than INT_MAX. Avoid
4141 sprintf's undefined behavior with conversion specifications such as %#d
4142 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4143 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4144 formatting out-of-range floating point numbers with int
4147 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4149 * data.c: Avoid integer truncation in expressions involving floats.
4150 * data.c: Include <intprops.h>.
4151 (arith_driver): When there's an integer overflow in an expression
4152 involving floating point, convert the integers to floating point
4153 so that the resulting value does not suffer from catastrophic
4154 integer truncation. For example, on a 64-bit host (* 4
4155 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4156 Do not rely on undefined behavior after integer overflow.
4158 merge count_size_as_multibyte, parse_str_to_multibyte
4159 * character.c, character.h (count_size_as_multibyte):
4160 Rename from parse_str_to_multibyte; all uses changed.
4161 Check for integer overflow.
4162 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4163 since it's now a duplicate of the other. This is more of
4164 a character than a buffer op, so better that it's in character.c.
4165 * fns.c, print.c: Adjust to above changes.
4167 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4169 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4171 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4173 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4174 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4175 (x_clipboard_manager_save): Now static.
4176 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4178 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4179 (crypto_hash_function): Now static.
4180 Fix pointer signedness problems. Avoid unnecessary initializations.
4182 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4184 * termhooks.h (Vselection_alist): Make it terminal-local.
4186 * terminal.c (create_terminal): Initialize it.
4188 * xselect.c: Support for clipboard managers.
4189 (Vselection_alist): Move to termhooks.h as terminal-local var.
4190 (LOCAL_SELECTION): New macro.
4191 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4192 (symbol_to_x_atom): Remove gratuitous arg.
4193 (x_handle_selection_request, lisp_data_to_selection_data)
4194 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4195 (x_own_selection, x_get_local_selection, x_convert_selection):
4196 New arg, specifying work frame. Use terminal-local Vselection_alist.
4197 (some_frame_on_display): Delete unused function.
4198 (Fx_own_selection_internal, Fx_get_selection_internal)
4199 (Fx_disown_selection_internal, Fx_selection_owner_p)
4200 (Fx_selection_exists_p): New optional frame arg.
4201 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4202 (x_handle_selection_clear): Don't treat other terminals with the
4203 same keyboard specially. Use the terminal-local Vselection_alist.
4204 (x_clear_frame_selections): Use Frun_hook_with_args.
4206 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4208 * xterm.h: Add support for those atoms.
4210 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4212 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4213 (converted_selections, conversion_fail_tag): New global variables.
4214 (x_selection_request_lisp_error): Free the above.
4215 (x_get_local_selection): Remove unnecessary code.
4216 (x_reply_selection_request): Args changed; handle arbitrary array
4217 of converted selections stored in converted_selections.
4218 Separate the XChangeProperty and SelectionNotify steps.
4219 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4220 (x_convert_selection): New function.
4221 (x_handle_selection_event): Simplify.
4222 (x_get_foreign_selection): Don't ignore incoming requests while
4223 waiting for an answer; this will fail when we implement
4224 SAVE_TARGETS, and seems unnecessary anyway.
4225 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4226 (Vx_sent_selection_functions): Doc fix.
4228 2011-05-26 Leo Liu <sdl.web@gmail.com>
4230 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4232 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4234 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4236 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4237 for fringe update if it has periodic bitmap.
4238 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4239 and fringe_bitmap_periodic_p.
4241 * fringe.c (get_fringe_bitmap_data): New function.
4242 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4243 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4244 row. Mark glyph row for fringe update if periodicity changed.
4246 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4247 for fringe update unless it has periodic bitmap.
4249 2011-05-25 Kenichi Handa <handa@m17n.org>
4251 * xdisp.c (get_next_display_element): Set correct it->face_id for
4252 a static composition.
4254 2011-05-24 Leo Liu <sdl.web@gmail.com>
4257 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4259 * fns.c (crypto_hash_function, Fsha1): New function.
4260 (Fmd5): Use crypto_hash_function.
4261 (syms_of_fns): Add Ssha1.
4263 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4265 * gnutls.c: Remove unused macros.
4266 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4267 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4268 Remove macros that are defined and never used.
4269 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4271 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4273 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4274 (Fx_get_selection_internal): Minor cleanup.
4275 (Fx_own_selection_internal): Rename arguments for consistency with
4278 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4280 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4282 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4284 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4286 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4288 * dispnew.c (scrolling_window): Don't exclude the case that the
4289 last enabled row in the desired matrix touches the bottom boundary.
4291 2011-05-21 Glenn Morris <rgm@gnu.org>
4293 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4294 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4295 and add some more files.
4297 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4299 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4300 report_file_error introduced by the change from 2011-05-07.
4302 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4304 * systime.h (Time): Define only if emacs is defined.
4305 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4306 where the include path doesn't have X11/X.h by default. See
4307 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4309 2011-05-20 Kenichi Handa <handa@m17n.org>
4311 * composite.c (find_automatic_composition): Fix previous change.
4313 2011-05-20 Glenn Morris <rgm@gnu.org>
4315 * lisp.mk: New file, split from Makefile.in.
4316 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4317 (shortlisp): Remove.
4318 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4320 2011-05-19 Glenn Morris <rgm@gnu.org>
4322 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4323 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4324 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4325 (lisp): Set the order to that of loadup.el.
4326 (shortlisp): Make it a copy of $lisp.
4327 (SOME_MACHINE_LISP): Remove.
4328 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4329 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4331 2011-05-18 Kenichi Handa <handa@m17n.org>
4333 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4334 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4335 (find_automatic_composition): Mostly rewrite for efficiency.
4337 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4339 * makefile.w32-in: Update dependencies.
4341 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4343 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4344 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4346 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4348 Fix some integer overflow issues, such as string length overflow.
4350 * insdel.c (count_size_as_multibyte): Check for string overflow.
4352 * character.c (lisp_string_width): Check for string overflow.
4353 Use EMACS_INT, not int, for string indexes and lengths; in
4354 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4355 the resulting string length overflows an EMACS_INT; instead,
4356 report a string overflow if no precision given. When checking for
4357 precision exhaustion, use a check that cannot possibly have
4358 integer overflow. (Bug#8675)
4359 * character.h (lisp_string_width): Adjust to new signature.
4361 * alloc.c (string_overflow): New function.
4362 (Fmake_string): Use it. This doesn't change behavior, but saves
4363 a few bytes and will simplify future changes.
4364 * character.c (string_escape_byte8): Likewise.
4365 * lisp.h (string_overflow): New decl.
4367 Fixups, following up to the user-interface timestamp change.
4368 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4369 for UI timestamps, instead of unsigned long.
4370 * msdos.c (mouse_get_pos): Likewise.
4371 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4372 * w32gui.h (Time): Define by including "systime.h" rather than by
4373 declaring it ourselves. (Bug#8664)
4375 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4376 * image.c (clear_image_cache): Likewise.
4378 * term.c (term_mouse_position): Don't assume time_t wraparound.
4380 Be more systematic about user-interface timestamps.
4381 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4382 and sometimes 'EMACS_UINT', to represent these timestamps.
4383 This change causes it to use 'Time' uniformly, as that's what X uses.
4384 This makes the code easier to follow, and makes it easier to catch
4385 integer overflow bugs such as Bug#8664.
4386 * frame.c (Fmouse_position, Fmouse_pixel_position):
4387 Use Time, not unsigned long, for user-interface timestamps.
4388 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4389 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4390 * keyboard.h (last_event_timestamp): Likewise.
4391 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4392 * menu.h (xmenu_show): Likewise.
4393 * term.c (term_mouse_position): Likewise.
4394 * termhooks.h (struct input_event.timestamp): Likewise.
4395 (struct terminal.mouse_position_hook): Likewise.
4396 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4397 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4398 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4399 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4401 * menu.h, termhooks.h: Include "systime.h", for Time.
4403 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4404 Don't assume that the difference between two unsigned long values
4405 can fit into an integer. At this point, we know button_down_time
4406 <= event->timestamp, so the difference must be nonnegative, so
4407 there's no need to cast the result if double-click-time is
4408 nonnegative, as it should be; check that it's nonnegative, just in
4409 case. This bug is triggered when events are more than 2**31 ms
4410 apart (about 25 days). (Bug#8664)
4412 * xselect.c (last_event_timestamp): Remove duplicate decl.
4413 (x_own_selection): Remove needless cast to unsigned long.
4415 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4416 that always fit in int. Use a sentinel instead of a counter, to
4417 avoid a temp and to allay GCC's concerns about possible int overflow.
4418 * frame.h (struct frame): Use int for menu_bar_items_used
4419 instead of EMACS_INT, since it always fits in int.
4421 * menu.c (grow_menu_items): Check for int overflow.
4423 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4425 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4426 Before, the code was not consistent. These values cannot exceed
4427 2**31 - 1 so there's no need to make them unsigned.
4428 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4429 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4430 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4432 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4434 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4435 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4436 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4437 presumably because the widths might not match.
4439 * window.c (size_window): Avoid needless test at loop start.
4441 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4443 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4445 2011-05-12 Drew Adams <drew.adams@oracle.com>
4447 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4449 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4451 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4452 `width' to `bar_area_x' and `bar_area_width', respectively.
4453 (x_scroll_run): Take account of fringe background extension.
4455 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4456 Rename local vars `left' and `width' to `bar_area_x' and
4457 `bar_area_width', respectively.
4458 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4459 background extension.
4461 2011-05-10 Jim Meyering <meyering@redhat.com>
4463 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4465 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4467 * image.c (Finit_image_library): Return t for built-in image types,
4468 like pbm and xbm. (Bug#8640)
4470 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4472 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4474 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4476 * w32console.c (Fset_screen_color): Doc fix.
4477 (Fget_screen_color): New function.
4478 (syms_of_ntterm): Defsubr it.
4480 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4481 unlink the temporary file if Fcall_process didn't create it in the
4483 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4484 child process will be redirected to a file specified with `:file'.
4485 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4486 cue to call_process_cleanup not to close that handle.
4488 2011-05-07 Ben Key <bkey76@gmail.com>
4490 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4491 one of two shell specific rules, either bootstrap-temacs-CMD or
4492 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4493 to the previous implementation of the bootstrap-temacs rule.
4494 The bootstrap-temacs-CMD rule is similar to the previous
4495 implementation of the bootstrap-temacs rule except that it
4496 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4499 These changes, along with some changes to nt/configure.bat,
4500 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4501 earlier fix to add support for --cflags and --ldflags options
4502 that include quotes so that it works whether make uses cmd or
4505 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4507 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4508 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4510 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4511 a string. Handle both cases.
4512 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4513 (Fdbus_register_method): Use Qinvalid_function.
4515 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4517 * makefile.w32-in: Update dependencies.
4518 (LISP_H): Add inttypes.h and stdin.h.
4519 (PROCESS_H): Add unistd.h.
4521 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4523 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4524 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4526 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4528 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4530 * term.c (vfatal): Remove stray call to va_end.
4531 It's not needed and the C Standard doesn't allow it here anyway.
4533 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4534 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4536 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4539 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4541 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4543 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4545 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4547 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4549 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4550 * charset.c (Fdefine_charset_internal): Don't initialize
4551 charset.code_space[15]. The value was garbage, on hosts with
4552 32-bit int (Bug#8600).
4554 * lread.c (read_integer): Be more consistent with string-to-number.
4555 Use string_to_number to do the actual conversion; this avoids
4556 rounding errors and fixes some other screwups. Without this fix,
4557 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4558 (digit_to_number): Move earlier, for benefit of read_integer.
4559 Return -1 if the digit is out of range for the base, -2 if it is
4560 not a digit in any supported base. (Bug#8602)
4562 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4564 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4565 to match comment at start of function. This also removes a
4566 GCC warning about overflow in a 32+64-bit port.
4568 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4570 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4571 Reported by Stefan Monnier in
4572 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4573 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4574 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4576 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4577 (EMACS_UINTPTR): Likewise, with uintptr_t.
4579 * lisp.h: Prefer 64-bit EMACS_INT if available.
4580 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4581 on 32-bit hosts that have 64-bit int, so that they can access
4583 However, temporarily disable this change unless the temporary
4584 symbol WIDE_EMACS_INT is defined.
4586 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4588 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4589 This removes an assumption that EMACS_INT and long are the same
4590 width as pointers. The assumption is true for Emacs porting targets
4591 now, but we want to make other targets possible.
4592 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4593 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4594 In the rest of the code, change types of integers that hold casted
4595 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4596 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4597 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4598 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4599 No need to cast type when ORing.
4600 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4601 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4602 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4603 assume EMACS_INT is the same width as char *.
4604 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4605 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4606 Remove no-longer-needed casts.
4607 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4608 (xg_tool_bar_help_callback, xg_make_tool_item):
4609 Use EMACS_INTPTR to hold an integer
4610 that will be cast to void *; this can avoid a GCC warning
4611 if EMACS_INT is not the same width as void *.
4612 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4613 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4614 (current_message_1, set_message_1):
4615 Use a local to convert to proper width without a cast.
4616 * xmenu.c (dialog_selection_callback): Likewise.
4618 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4619 Also, don't assume VALBITS / RAND_BITS is less than 5,
4620 and don't rely on undefined behavior when shifting a 1 left into
4622 * lisp.h (get_random): Change signature to match.
4624 * lread.c (hash_string): Use size_t, not int, for hash computation.
4625 Normally we prefer signed values; but hashing is special, because
4626 it's better to use unsigned division on hash table sizes so that
4627 the remainder is nonnegative. Also, size_t is the natural width
4628 for hashing into memory. The previous code used 'int', which doesn't
4629 retain enough info to hash well into very large tables.
4630 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4632 * dbusbind.c: Don't possibly lose pointer info when converting.
4633 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4634 Use XPNTR rather than XHASH, so that the high-order bits of
4635 the pointer aren't lost when converting through void *.
4637 * eval.c (Fautoload): Don't double-shift a pointer.
4639 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4641 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4643 * gnutls.c (DEF_GNUTLS_FN):
4644 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4646 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4648 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4651 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4653 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4654 New version that can reserve upto 2GB of heap space.
4656 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4658 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4660 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4662 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4663 `gnutls_certificate_set_x509_key_file'.
4665 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4667 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4668 Update dependencies.
4670 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4672 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4673 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4674 Remove unused parameter `fildes'.
4675 * process.c (read_process_output, send_process): Don't pass it.
4677 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4679 Fix previous change: the library cache is defined in w32.c.
4680 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4681 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4683 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4685 Implement dynamic loading of GnuTLS on Windows.
4687 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4688 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4689 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4692 * gnutls.c (Qgnutls_dll): Define.
4693 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4694 (gnutls_*): Declare function pointers.
4695 (init_gnutls_functions): New function to initialize function pointers.
4696 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4697 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4698 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4699 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4700 (emacs_gnutls_write, emacs_gnutls_read)
4701 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4702 (Fgnutls_available_p): New function.
4703 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4704 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4705 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4707 * image.c: Include w32.h.
4708 (Vimage_type_cache): Delete.
4709 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4710 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4711 (w32_delayed_load): Move to w32.c.
4713 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4715 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4716 (w32_delayed_load): Move from image.c. When loading a library, record
4717 its filename in the :loaded-from property of the library id.
4718 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4719 Initialize and staticpro them.
4720 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4722 * process.c: Include lisp.h before w32.h, not after.
4723 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4724 instead of gnutls_record_check_pending.
4726 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4728 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4730 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4731 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4734 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4736 * xterm.c (x_set_frame_alpha): Do not set property on anything
4737 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4739 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4741 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4743 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4745 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4746 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4747 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4748 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4749 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4750 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4751 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4752 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4753 (Qgnutls_bootprop_callbacks_verify): Make static.
4755 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4757 * callproc.c: Indentation fixup.
4759 * sysdep.c (wait_for_termination_1): Make static.
4760 (wait_for_termination, interruptible_wait_for_termination):
4761 Move after wait_for_termination_1.
4763 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4765 * sysdep.c (interruptible_wait_for_termination): New function
4766 which is like wait_for_termination, but allows keyboard
4769 * callproc.c (Fcall_process): Add (:file "file") as an option for
4771 (Fcall_process_region): Ditto.
4773 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4775 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4776 rather than `XVECTOR (FOO)->size'.
4778 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4779 inttypes.h, as a gnulib replacement is used if it not available in
4782 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4784 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4785 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4786 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4788 * coding.c (coding_alloc_by_realloc): Error out if destination
4789 will grow beyond MOST_POSITIVE_FIXNUM.
4790 (decode_coding_emacs_mule): Abort if there isn't enough place in
4791 charbuf for the composition carryover bytes. Reserve an extra
4792 space for up to 2 characters produced in a loop.
4793 (decode_coding_iso_2022): Abort if there isn't enough place in
4794 charbuf for the composition carryover bytes.
4796 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4798 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4799 aborting when %lld or %lll format is passed.
4800 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4801 %llo or %llx format is passed. (Bug#8545)
4803 * window.c (window_scroll_line_based): Use a marker instead of
4804 simple variables to record original value of point. (Bug#7952)
4806 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4807 produced by %s or %c overflows available buffer space. (Bug#8545)
4809 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4811 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4812 (SIZE_MAX): Move defn after all includes, as they might #define it.
4814 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4816 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4818 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4820 * keyboard.c (Qdelayed_warnings_hook): Define.
4821 (command_loop_1): Run `delayed-warnings-hook'
4822 if Vdelayed_warnings_list is non-nil.
4823 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4824 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4826 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4828 * doprnt.c (doprnt): Don't return value smaller than the buffer
4829 size if the message was truncated. (Bug#8545).
4831 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4833 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4834 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4836 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4838 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4840 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4842 * makefile.w32-in: Update dependencies.
4844 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4846 Improve `doprnt' and its usage. (Bug#8545)
4847 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4848 `format_end'. Remove support for %l as a conversion specifier.
4849 Don't use xrealloc. Improve diagnostics when the %l size modifier
4850 is used. Update the commentary.
4852 * eval.c (verror): Simplify calculation of size_t.
4854 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4857 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4859 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4862 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4864 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4865 This makes this file independent of the recent pseudovector change.
4867 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4869 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4871 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4872 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4873 Remove unused local.
4874 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4876 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4877 GCC 4.6.0 optimizes based on type-based alias analysis.
4878 For example, if b is of type struct buffer * and v of type struct
4879 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4880 != &v->size, and therefore "v->size = 1; b->size = 2; return
4881 v->size;" must therefore return 1. This assumption is incorrect
4882 for Emacs, since it type-puns struct Lisp_Vector * with many other
4883 types. To fix this problem, this patch adds a new type struct
4884 vectorlike_header that documents the constraints on layout of vectors
4885 and pseudovectors, and helps optimizing compilers not get fooled
4886 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4887 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4888 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4890 (XSETPVECTYPE): Rewrite in terms of new macro.
4891 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4892 This is a bit clearer, and further avoids the possibility of
4893 undesirable aliasing.
4894 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4895 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4896 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4897 since Lisp_Subr is a special case (no "next" field).
4898 (ASIZE): Now uses header.size rather than size.
4899 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4900 to avoid the hassle of writing XVECTOR (foo)->header.size.
4901 (struct vectorlike_header): New type.
4902 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4903 object, to help avoid aliasing.
4904 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4905 (SUBRP): Likewise, since Lisp_Subr is a special case.
4906 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4907 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4908 (struct Lisp_Hash_Table): Combine first two members into a single
4909 struct vectorlike_header member. All uses of "size" and "next" members
4910 changed to be "header.size" and "header.next".
4911 * buffer.h (struct buffer): Likewise.
4912 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4913 * frame.h (struct frame): Likewise.
4914 * process.h (struct Lisp_Process): Likewise.
4915 * termhooks.h (struct terminal): Likewise.
4916 * window.c (struct save_window_data, struct saved_window): Likewise.
4917 * window.h (struct window): Likewise.
4918 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4919 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4920 * buffer.c (init_buffer_once): Likewise.
4921 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4923 * process.c (Fformat_network_address): Use local var for size,
4926 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4928 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4929 * data.c (atof): Remove decl; no longer used or needed.
4930 (digit_to_number): Move to lread.c.
4931 (Fstring_to_number): Use new string_to_number function, to be
4932 consistent with how the Lisp reader treats infinities and NaNs.
4933 Do not assume that floating-point numbers represent EMACS_INT
4934 without losing information; this is not true on most 64-bit hosts.
4935 Avoid double-rounding errors, by insisting on integers when
4936 parsing non-base-10 numbers, as the documentation specifies.
4937 * lisp.h (string_to_number): New decl, replacing ...
4938 (isfloat_string): Remove.
4939 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4940 (read1): Do not accept +. and -. as integers; this
4941 appears to have been a coding error. Similarly, do not accept
4942 strings like +-1e0 as floating point numbers. Do not report
4943 overflow for integer overflows unless the base is not 10 which
4944 means we have no simple and reliable way to continue.
4945 Break out the floating-point parsing into a new
4946 function string_to_number, so that Fstring_to_number parses
4947 floating point numbers consistently with the Lisp reader.
4948 (digit_to_number): Move here from data.c. Make it static inline.
4949 (E_CHAR, EXP_INT): Remove, replacing with ...
4950 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4951 (string_to_number): New function, replacing isfloat_string.
4952 This function checks for valid syntax and produces the resulting
4953 Lisp float number too. Rework it so that string-to-number
4954 no longer mishandles examples like "1.0e+". Use strtoumax,
4955 so that overflow for non-base-10 numbers is reported only when
4956 there's no portable and simple way to convert to floating point.
4958 * textprop.c (set_text_properties_1): Rewrite for clarity,
4959 and to avoid GCC warning about integer overflow.
4961 * intervals.h (struct interval): Use EMACS_INT for members
4962 where EMACS_UINT might cause problems. See
4963 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4964 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4965 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4967 (offset_intervals): Tell GCC not to worry about length overflow
4968 when negating a negative length.
4970 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4971 (overrun_check_free): Likewise.
4973 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4974 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4977 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4978 (gnutls_make_error): Rename local to avoid shadowing.
4979 (gnutls_emacs_global_deinit): ifdef out; not used.
4980 (Fgnutls_boot): Use const for pointer to readonly storage.
4981 Comment out unused local. Fix pointer signedness problems.
4983 * lread.c (openp): Don't stuff size_t into an 'int'.
4984 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4985 about possible signed overflow.
4987 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4988 (GDK_KEY_g): Don't define if already defined.
4989 (xg_prepare_tooltip): Avoid pointer signedness problem.
4990 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4992 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4993 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4995 * xfns.c (Fx_window_property): Simplify a bit,
4996 to make a bit faster and to avoid GCC 4.6.0 warning.
4997 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4999 * fns.c (internal_equal): Don't assume size_t fits in int.
5001 * alloc.c (compact_small_strings): Tighten assertion a little.
5003 Replace pEd with more-general pI, and fix some printf arg casts.
5004 * lisp.h (pI): New macro, generalizing old pEd macro to other
5005 conversion specifiers. For example, use "...%"pI"d..." rather
5006 than "...%"pEd"...".
5007 (pEd): Remove. All uses replaced with similar uses of pI.
5008 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5009 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5010 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5011 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5012 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5013 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5014 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5016 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5017 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5018 * print.c (safe_debug_print, print_object): Likewise.
5019 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5021 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5022 avoiding the 0 flag, which is not portable.
5023 * process.c (Fmake_network_process): Use pI to avoid cast.
5024 * region-cache.c (pp_cache): Likewise.
5025 * xdisp.c (decode_mode_spec): Likewise.
5026 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5027 behavior on 64-bit hosts with printf arg.
5028 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5029 (x_stop_queuing_selection_requests): Likewise.
5030 (x_get_window_property): Don't truncate byte count to an 'int'
5033 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5034 here, since it parses constructs like leading '-' and spaces,
5035 which are not wanted; and it overflows with large numbers.
5036 Instead, simply match F[0-9]+, which is what is wanted anyway.
5038 * alloc.c: Remove unportable assumptions about struct layout.
5039 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5040 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5041 (allocate_vectorlike, make_pure_vector): Use the new macros,
5042 plus offsetof, to remove unportable assumptions about struct layout.
5043 These assumptions hold on all porting targets that I know of, but
5044 they are not guaranteed, they're easy to remove, and removing them
5045 makes further changes easier.
5047 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5048 This doesn't fix a bug but makes the code clearer.
5049 (string_overrun_cookie): Now const. Use initializers that
5050 don't formally overflow signed char, to avoid warnings.
5051 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5052 can cause Emacs to crash when string overrun checking is enabled.
5053 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5054 multiple of sizeof (EMACS_INT); it need not be, if
5055 alignof(EMACS_INT) < sizeof (EMACS_INT).
5056 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5058 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5060 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5062 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5064 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5065 supposed to be handshaking. (Bug#8556)
5066 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5068 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5070 * lisp.h (Qdebug): List symbol.
5071 * eval.c (Qdebug): Restore global linkage.
5072 * keyboard.c (debug-on-event): New variable.
5073 (handle_user_signal): Break into debugger when debug-on-event
5074 matches the current signal symbol.
5076 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5078 * alloc.c (check_sblock, check_string_bytes)
5079 (check_string_free_list): Convert to standard C.
5081 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5083 * w32.c (emacs_gnutls_push): Fix typo.
5085 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5087 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5088 "cast to pointer from integer of different size".
5090 Improve doprnt and its use in verror. (Bug#8545)
5091 * doprnt.c (doprnt): Document the set of format control sequences
5092 supported by the function. Use SAFE_ALLOCA instead of always
5095 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5096 is one byte too soon. Don't use xrealloc; instead xfree and
5099 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5101 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5104 * gnutls.c: Renamed global_initialized to
5105 gnutls_global_initialized. Added internals for the
5106 :verify-hostname-error, :verify-error, and :verify-flags
5107 parameters of `gnutls-boot' and documented those parameters in the
5108 docstring. Start callback support.
5109 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5110 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5111 on error. Return error code.
5112 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5113 (emacs_gnutls_read): Likewise.
5114 (Fgnutls_boot): Return handshake error code.
5115 (emacs_gnutls_handle_error): New function.
5116 (wsaerror_to_errno): Likewise.
5118 * w32.h (emacs_gnutls_pull): Add prototype.
5119 (emacs_gnutls_push): Likewise.
5121 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5122 (emacs_gnutls_push): Likewise.
5124 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5126 * process.c (wait_reading_process_output): Check if GnuTLS
5127 buffered some data internally if no FDs are set for TLS
5130 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5131 (LIBS): Link to USER_LIBS.
5132 ($(BLD)/gnutls.$(0)): New target.
5134 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5136 * xdisp.c (handle_single_display_spec): Rename the
5137 display_replaced_before_p argument into display_replaced_p, to
5138 make it consistent with the commentary. Fix typos in the
5141 * textprop.c (syms_of_textprop): Remove dead code.
5142 (copy_text_properties): Delete obsolete commentary about an
5143 interface that was deleted long ago. Fix typos in the description
5146 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5147 to changes in oldXMenu/XMenu.h from 2011-04-16.
5148 <menu_help_message, prev_menu_help_message>: Constify.
5149 (IT_menu_make_room): menu->help_text is now `const char **';
5152 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5153 to changes in oldXMenu/XMenu.h from 2011-04-16.
5154 (struct XMenu): Declare `help_text' `const char **'.
5156 * xfaces.c <Qunspecified>: Make extern again.
5158 * syntax.c: Include sys/types.h before including regex.h, as
5161 * doc.c (get_doc_string): Improve the format passed to `error'.
5163 * doprnt.c (doprnt): Improve commentary.
5165 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5167 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5170 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5171 changes in globals.h immediately force recompilation.
5172 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5173 $(CURDIR)/s/ms-w32.h.
5174 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5176 * character.c (Fchar_direction): Function deleted.
5177 (syms_of_character): Don't defsubr it.
5178 <char-direction-table>: Deleted.
5180 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5182 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5183 * doprnt.c: Include limits.h.
5184 (SIZE_MAX): New macro.
5185 (doprnt): Return a size_t value. 2nd arg is now size_t.
5186 Many local variables are now size_t instead of int or unsigned.
5187 Improve overflow protection. Support `l' modifier for integer
5188 conversions. Support %l conversion. Don't assume an EMACS_INT
5189 argument for integer conversions and for %c.
5191 * lisp.h (doprnt): Restore prototype.
5193 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5196 * Makefile.in (base_obj): Add back doprnt.o.
5198 * deps.mk (doprnt.o): Add back prerequisites.
5199 (callint.o): Depend on character.h.
5201 * eval.c (internal_lisp_condition_case): Include the handler
5202 representation in the error message.
5203 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5204 when breaking from the loop.
5206 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5208 * callint.c (Fcall_interactively): When displaying error message
5209 about invalid control letter, pass the character's codepoint, not
5210 a pointer to its multibyte form. Improve display of the character
5211 in octal and display also its hex code.
5213 * character.c (char_string): Use %x to display the (unsigned)
5214 codepoint of an invalid character, to avoid displaying a bogus
5217 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5218 `error', not SYMBOL_NAME itself.
5220 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5221 character arguments to `error'.
5223 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5224 to `error' in error message about FINAL_CHAR argument. Make sure
5225 FINAL_CHAR is a character, and use %c when it is passed as
5226 argument to `error'.
5228 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5230 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5232 * w32.c: Include <time.h>.
5233 (sys_localtime): New function.
5235 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5237 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5239 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5241 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5243 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5246 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5248 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5249 gl_state.e_property when gl_state.object is Qt.
5251 * insdel.c (make_gap_larger): Remove limitation of buffer size
5254 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5256 * xdisp.c (lookup_glyphless_char_display)
5257 (produce_glyphless_glyph): Handle cons cell entry in
5258 glyphless-char-display.
5259 (Vglyphless_char_display): Document it.
5261 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5262 glyphless-char-display.
5264 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5266 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5268 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5270 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5271 definition for no-X builds.
5273 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5275 Static checks with GCC 4.6.0 and non-default toolkits.
5277 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5279 * process.c (keyboard_bit_set): Define only if SIGIO.
5280 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5281 (send_process): Repair possible setjmp clobbering.
5283 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5285 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5287 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5289 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5290 Define only if needed.
5292 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5293 by pacifying GCC about it. Maybe it's time to retire it?
5294 * xfaces.c (USG, __TIMEVAL__): Likewise.
5296 * dispextern.h (struct redisplay_interface): Rename param
5298 * termhooks.h (struct terminal): Likewise.
5299 * xterm.c (xembed_send_message): Likewise.
5301 * insdel.c (make_gap_smaller): Define only if
5302 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5304 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5307 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5308 so that we aren't warned about unused symbols.
5310 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5312 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5314 * xfns.c (x_real_positions): Mark locals as initialized.
5316 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5318 * xterm.c: Fix problems found by static analysis with other toolkits.
5319 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5320 (x_dispatch_event): Declare static if USE_GTK, and
5321 define if USE_GTK || USE_X_TOOLKIT.
5322 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5323 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5324 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5325 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5327 * xmenu.c (menu_help_callback): Pointer type fixes.
5328 Use const pointers when pointing at readonly data. Avoid pointer
5330 (FALSE): Remove unused macro.
5331 (update_frame_menubar): Remove unused decl.
5333 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5335 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5336 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5337 (single_menu_item): Rename local to avoid shadowing.
5339 * keyboard.c (make_lispy_event): Remove unused local var.
5341 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5342 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5344 * bitmaps: Change bitmaps from unsigned char back to the X11
5345 compatible char. Avoid the old compiler warnings about
5346 out-of-range initializers by using, for example, '\xab' rather
5349 * xgselect.c (xgselect_initialize): Check vs interface
5350 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5352 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5354 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5355 to read-only memory.
5357 * fns.c (vector): Remove; this old hack is no longer needed.
5359 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5361 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5363 * xrdb.c (x_load_resources): Omit unused local.
5365 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5366 (x_window): Rename locals to avoid shadowing.
5367 (USG): Use the kludged USG macro, to pacify gcc.
5369 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5370 (x_term_init): Remove local to avoid shadowing.
5372 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5374 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5375 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5377 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5379 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5381 Fix regex.c, syntax.c and friends for buffers > 2GB.
5382 * syntax.h (struct gl_state_s): Declare character position members
5385 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5387 * textprop.c (verify_interval_modification, interval_of):
5388 Declare arguments EMACS_INT.
5390 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5393 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5395 * indent.c (Fvertical_motion): Local variable it_start is now
5398 * regex.c (re_match, re_match_2, re_match_2_internal)
5399 (bcmp_translate, regcomp, regexec, print_double_string)
5400 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5401 (re_compile_pattern, re_exec): Declare arguments and local
5402 variables `size_t' and `ssize_t' and return values `regoff_t', as
5404 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5405 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5406 <compile_stack_type>: `size' and `avail' are now `size_t'.
5408 * regex.h <regoff_t>: Use ssize_t, not int.
5409 (re_search, re_search_2, re_match, re_match_2): Arguments that
5410 specify buffer/string position and length are now ssize_t and
5411 size_t. Return type is regoff_t.
5413 2011-04-16 Ben Key <bkey76@gmail.com>
5415 * nsfont.m: Fixed bugs in ns_get_family and
5416 ns_descriptor_to_entity that were caused by using free to
5417 deallocate memory blocks that were allocated by xmalloc (via
5418 xstrdup). This caused Emacs to crash when compiled with
5419 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5420 --enable-checking=xmallocoverrun). xfree is now used to
5421 deallocate these memory blocks.
5423 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5425 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5427 emacs_write: Accept and return EMACS_INT for sizes.
5428 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5430 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5431 Accept and return EMACS_INT.
5432 (emacs_gnutls_write): Return the number of bytes written on
5434 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5435 (emacs_read, emacs_write): Remove check for negative size, as the
5436 Emacs source code has been audited now.
5437 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5438 (emacs_read, emacs_write): Use it.
5439 * process.c (send_process): Adjust to the new signatures of
5440 emacs_write and emacs_gnutls_write. Do not attempt to store
5441 a byte offset into an 'int'; it might overflow.
5442 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5444 * sound.c: Don't assume sizes fit in 'int'.
5445 (struct sound_device.period_size, alsa_period_size):
5446 Return EMACS_INT, not int.
5447 (struct sound_device.write, vox_write, alsa_write):
5448 Accept EMACS_INT, not int.
5449 (wav_play, au_play): Use EMACS_INT to store sizes and to
5450 record read return values.
5452 2011-04-15 Ben Key <bkey76@gmail.com>
5454 * keyboard.c (Qundefined): Don't declare static since it is used
5456 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5457 static since they are used in nsfont.m.
5459 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5461 * process.c (Qprocessp): Don't declare static.
5462 * lisp.h (Qprocessp): Declare again.
5464 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5466 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5468 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5470 Improve C-level modularity by making more things 'static'.
5472 Don't publish debugger-only interfaces to other modules.
5473 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5474 (verify_bytepos, count_markers): Move decls to the only modules
5476 * region-cache.h (pp_cache): Likewise.
5477 * window.h (check_all_windows): Likewise.
5478 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5480 * sysdep.c (croak): Now static, if
5481 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5482 * syssignal.h (croak): Declare only if not static.
5484 * alloc.c (refill_memory_reserve): Now static if
5485 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5486 * lisp.h (refill_memory_reserve): Declare only if not static.
5488 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5489 Define only if USE_LUCID.
5491 * xrdb.c (x_customization_string, x_rm_string): Now static.
5493 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5494 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5496 * xdisp.c (draw_row_with_mouse_face): Now static.
5497 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5499 * window.h (check_all_windows): Mark externally visible.
5501 * window.c (window_deletion_count): Now static.
5503 * undo.c: Make symbols static if they're not exported.
5504 (last_undo_buffer, last_boundary_position, pending_boundary):
5507 * textprop.c (interval_insert_behind_hooks): Now static.
5508 (interval_insert_in_front_hooks): Likewise.
5510 * term.c: Make symbols static if they're not exported.
5511 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5512 (max_frame_lines, tty_set_terminal_modes):
5513 (tty_reset_terminal_modes, tty_turn_off_highlight):
5514 (get_tty_terminal): Now static.
5515 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5516 * termhooks.h (term_mouse_moveto): Do not declare if
5518 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5519 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5521 * sysdep.c: Make symbols static if they're not exported.
5522 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5524 (sigprocmask_set, full_mask): Remove; unused.
5525 (wait_debugging): Mark as visible.
5526 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5527 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5529 * syntax.c (syntax_temp): Define only if !__GNUC__.
5531 * sound.c (current_sound_device, current_sound): Now static.
5533 * search.c (searchbufs, searchbuf_head): Now static.
5535 * scroll.c (scroll_cost): Remove; unused.
5536 * dispextern.h (scroll_cost): Remove decl.
5538 * region-cache.h (pp_cache): Mark as externally visible.
5540 * process.c: Make symbols static if they're not exported.
5541 (process_tick, update_tick, create_process, chan_process):
5542 (Vprocess_alist, proc_buffered_char, datagram_access):
5543 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5544 (deactivate_process): Mark defn as static, as well as decl.
5545 * lisp.h (create_process): Remove decl.
5546 * process.h (chan_process, Vprocess_alist): Remove decls.
5548 * print.c: Make symbols static if they're not exported.
5549 (print_depth, new_backquote_output, being_printed, print_buffer):
5550 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5551 (print_interval, print_number_index, initial_stderr_stream):
5553 * lisp.h (Fprinc): Remove decl.
5554 (debug_output_compilation_hack): Mark as externally visible.
5556 * sysdep.c (croak): Move decl from here to syssignal.h.
5557 * syssignal.h (croak): Put it here, so the API can be checked when
5558 'croak' is called from dissociate_if_controlling_tty.
5560 * minibuf.c: Make symbols static if they're not exported.
5561 (minibuf_save_list, choose_minibuf_frame): Now static.
5562 * lisp.h (choose_minibuf_frame): Remove decl.
5564 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5566 * lread.c: Make symbols static if they're not exported.
5567 (read_objects, initial_obarray, oblookup_last_bucket_number):
5569 (make_symbol): Remove; unused.
5570 * lisp.h (initial_obarray, make_symbol): Remove decls.
5572 * keyboard.c: Make symbols static if they're not exported.
5573 (single_kboard, recent_keys_index, total_keys, recent_keys):
5574 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5575 (this_single_command_key_start, echoing, last_auto_save):
5576 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5577 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5578 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5579 (Vlispy_mouse_stem, double_click_count):
5581 (force_auto_save_soon): Define only if SIGDANGER.
5582 (ignore_mouse_drag_p): Now static if
5583 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5584 (print_help): Remove; unused.
5585 (stop_character, last_timer_event): Mark as externally visible.
5586 * keyboard.h (ignore_mouse_drag_p): Declare only if
5587 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5588 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5589 * lisp.h (echoing): Remove decl.
5590 (force_auto_save_soon): Declare only if SIGDANGER.
5591 * xdisp.c (redisplay_window): Simplify code, to make it more
5592 obvious that ignore_mouse_drag_p is not accessed if !defined
5593 USE_GTK && !defined HAVE_NS.
5595 * intervals.c: Make symbols static if they're not exported.
5596 (merge_properties_sticky, merge_interval_right, delete_interval):
5598 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5600 * insdel.c: Make symbols static if they're not exported.
5601 However, leave prepare_to_modify_buffer alone. It's never
5602 called from outside this function, but that appears to be a bug.
5603 (combine_after_change_list, combine_after_change_buffer):
5604 (adjust_after_replace, signal_before_change): Now static.
5605 (adjust_after_replace_noundo): Remove; unused.
5606 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5607 (signal_before_change): Remove decls.
5609 * indent.c (val_compute_motion, val_vmotion): Now static.
5611 * image.c: Make symbols static if they're not exported.
5612 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5614 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5615 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5617 * fringe.c (standard_bitmaps): Now static.
5618 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5620 * frame.c: Make symbols static if they're not exported.
5621 (x_report_frame_params, make_terminal_frame): Now static.
5622 (get_frame_param): Now static, unless HAVE_NS.
5623 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5624 (x_get_resource_string): Remove; not used.
5625 * frame.h (make_terminal_frame, x_report_frame_params):
5626 (x_get_resource_string); Remove decls.
5627 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5628 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5630 * font.c, fontset.c: Make symbols static if they're not exported.
5631 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5632 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5633 * font.c (font_close_object): Now static.
5634 * font.h (font_close_object): Remove.
5635 * fontset.c (FONTSET_OBJLIST): Remove.
5636 (free_realized_fontset) #if-0 the body, which does nothing.
5637 (face_suitable_for_char_p): #if-0, as it's never called.
5638 * fontset.h (face_suitable_for_char_p): Remove decl.
5639 * xfaces.c (face_at_string_position):
5640 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5641 since 0 is always ASCII.
5643 * fns.c (weak_hash_tables): Now static.
5645 * fileio.c: Make symbols static if they're not exported.
5646 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5647 (Vwrite_region_annotation_buffers): Now static.
5649 * eval.c: Make symbols static if they're not exported.
5650 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5651 * lisp.h (backtrace_list): Remove decl.
5653 * emacs.c: Make symbols static if they're not exported.
5654 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5655 (fatal_error_code, fatal_error_signal_hook, standard_args):
5657 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5658 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5659 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5660 * lisp.h (fatal_error_signal_hook): Remove decl.
5661 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5663 * editfns.c: Move a (normally-unused) function to its only use.
5664 * editfns.c, lisp.h (get_operating_system_release): Remove.
5665 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5666 worth the hassle of breaking this out.
5668 * xterm.c: Make symbols static if they're not exported.
5669 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5670 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5671 (x_destroy_window, x_delete_display):
5673 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5674 (x_mouse_leave): Remove; unused.
5675 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5676 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5677 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5679 (x_mouse_leave): Declare only if WINDOWSNT.
5680 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5681 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5684 * ftxfont.c: Make symbols static if they're not exported.
5685 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5687 * font.h (ftxfont_driver): Likewise.
5689 * xfns.c: Make symbols static if they're not exported.
5690 (x_last_font_name, x_display_info_for_name):
5691 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5692 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5693 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5694 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5695 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5696 (last_show_tip_args): Now static.
5697 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5698 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5699 (x_screen_planes): Remove; unused.
5700 * dispextern.h (x_screen_planes): Remove decl.
5702 * dispnew.c: Make symbols static if they're not exported.
5703 * dispextern.h (redraw_garbaged_frames, scrolling):
5704 (increment_row_positions): Remove.
5705 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5706 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5708 (redraw_garbaged_frames): Remove; unused.
5710 * xfaces.c: Make symbols static if they're not exported.
5711 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5713 * xterm.h (defined_color): Remove decls.
5714 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5715 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5716 (menu_face_changed_default, defined_color, free_realized_face):
5717 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5718 (ascii_face_of_lisp_face): Remove; unused.
5720 * xdisp.c: Make symbols static if they're not exported.
5721 * dispextern.h (scratch_glyph_row, window_box_edges):
5722 (glyph_to_pixel_coords, set_cursor_from_row):
5723 (get_next_display_element, set_iterator_to_next):
5724 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5725 (show_mouse_face): Remove decls
5726 * frame.h (message_buf_print): Likewise.
5727 * lisp.h (pop_message, set_message, check_point_in_composition):
5729 * xterm.h (set_vertical_scroll_bar): Likewise.
5730 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5731 (message_buf_print, scratch_glyph_row, displayed_buffer):
5732 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5733 (get_next_display_element, show_mouse_face, window_box_edges):
5734 (frame_to_window_pixel_xy, check_point_in_composition):
5735 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5736 (glyph_to_pixel_coords): Remove; unused.
5738 * dired.c (file_name_completion): Now static.
5740 * dbusbind.c (xd_in_read_queued_messages): Now static.
5742 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5743 * data.c (circular_list_error): Remove.
5745 * commands.h (last_point_position, last_point_position_buffer):
5746 (last_point_position_window): Remove decls.
5747 * keyboard.c: Make these variables static.
5749 * coding.h (coding, code_convert_region, encode_coding_gap):
5751 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5752 (iso_code_class, detect_coding, code_convert_region): Now static.
5753 (encode_coding_gap): Remove; unused.
5755 * chartab.c (chartab_chars, chartab_bits): Now static.
5757 * charset.h (charset_iso_8859_1): Remove decl.
5758 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5761 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5762 * ccl.c (Vccl_program_table): Now static.
5763 (check_ccl_update): Remove; unused.
5765 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5766 * category.h: ... from here.
5767 * category.c (check_category_table, set_category_set): Now static.
5769 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5770 * lisp.h: Remove these decls.
5772 * buffer.c (buffer_count): Remove unused var.
5774 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5775 so that it's not optimized away.
5776 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5777 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5778 exported only to the debugger.
5780 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5781 * atimer.h (run_all_atimers): Remove; not exported.
5783 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5784 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5785 was inaccessible from Lisp.
5786 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5787 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5789 alloc.c: Import and export fewer symbols, and remove unused items.
5790 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5792 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5793 it's not optimized away by whole-program optimization.
5794 (message_enable_multibyte, free_misc): Remove.
5795 (catchlist, handlerlist, mark_backtrace):
5796 Declare only if BYTE_MARK_STACK.
5797 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5798 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5799 (message_enable_multibyte): Remove decl.
5800 (free_misc, interval_free_list, float_block, float_block_index):
5801 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5802 (cons_free_list, last_marked_index):
5804 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5805 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5806 (mark_backtrace): Define only if BYTE_MARK_STACK.
5807 * xdisp.c (message_enable_multibyte): Now static.
5809 Declare Lisp_Object Q* variables to be 'static' if not exported.
5810 This makes it easier for human readers (and static analyzers)
5811 to see whether these variables are used from other modules.
5812 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5813 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5814 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5815 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5816 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5817 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5818 * xmenu.c, xselect.c:
5819 Declare Q* vars static if they are not used in other modules.
5820 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5821 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5822 Remove decls of unexported vars.
5823 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5825 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5827 Make Emacs functions such as Fatom 'static' by default.
5828 This makes it easier for human readers (and static analyzers)
5829 to see whether these functions can be called from other modules.
5830 DEFUN now defines a static function. To make the function external
5831 so that it can be used in other C modules, use the new macro DEFUE.
5832 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5833 (Finit_image_library):
5834 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5835 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5836 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5837 Remove decls, since these functions are now static.
5838 (Funintern, Fget_internal_run_time): New decls, since these functions
5839 were already external.
5841 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5842 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5843 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5844 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5845 * keyboard.c, keymap.c, lread.c:
5846 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5847 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5848 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5849 Mark functions with DEFUE instead of DEFUN,
5850 if they are used in other modules.
5851 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5852 decls for now-static functions.
5853 * buffer.h (Fdelete_overlay): Remove decl.
5854 * callproc.c (Fgetenv_internal): Mark as internal.
5855 * composite.c (Fremove_list_of_text_properties): Remove decl.
5856 (Fcomposition_get_gstring): New forward static decl.
5857 * composite.h (Fcomposite_get_gstring): Remove decl.
5858 * dired.c (Ffile_attributes): New forward static decl.
5859 * doc.c (Fdocumntation_property): New forward static decl.
5860 * eval.c (Ffetch_bytecode): New forward static decl.
5861 (Funintern): Remove extern decl; now in .h file where it belongs.
5862 * fileio.c (Fmake_symbolic_link): New forward static decl.
5863 * image.c (Finit_image_library): New forward static decl.
5864 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5865 * intervals.h (Fprevious_property_change):
5866 (Fremove_list_of_text_properties): Remove decls.
5867 * keyboard.c (Fthis_command_keys): Remove decl.
5868 (Fcommand_execute): New forward static decl.
5869 * keymap.c (Flookup_key): New forward static decl.
5870 (Fcopy_keymap): Now static.
5871 * keymap.h (Flookup_key): Remove decl.
5872 * process.c (Fget_process): New forward static decl.
5873 (Fprocess_datagram_address): Mark as internal.
5874 * syntax.c (Fsyntax_table_p): New forward static decl.
5875 (skip_chars): Remove duplicate decl.
5876 * textprop.c (Fprevious_property_change): New forward static decl.
5877 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5879 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5880 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5882 * editfns.c (Fformat): Remove unreachable code.
5884 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5886 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5889 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5891 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5892 when at ZV. (Bug#8487)
5894 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5896 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5898 * keyboard.c (parse_tool_bar_item): Likewise.
5899 * sound.c (sound_cleanup, alsa_close): Likewise.
5900 * termcap.c (tgetent): Likewise.
5901 * xfns.c (x_default_font_parameter): Likewise.
5902 * xsettings.c (read_and_apply_settings): Likewise.
5904 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5905 (overrun_check_free): Protoize.
5907 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5909 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5910 since callers should never pass a negative size.
5911 Change the signature to match that of plain 'read' and 'write'; see
5912 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5913 * lisp.h: Update prototypes of emacs_write and emacs_read.
5915 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5917 * xdisp.c (redisplay_window): Don't try to determine the character
5918 position of the scroll margin if the window start point w->startp
5919 is outside the buffer's accessible region. (Bug#8468)
5921 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5923 Fix write-region and its subroutines for buffers > 2GB.
5924 * fileio.c (a_write, e_write): Modify declaration of arguments and
5925 local variables to support buffers larger than 2GB.
5926 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5928 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5929 argument, local variables, and return value.
5931 * lisp.h: Update prototypes of emacs_write and emacs_read.
5933 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5935 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5937 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5939 Fix more problems found by GCC 4.6.0's static checks.
5941 * xdisp.c (vmessage): Use a better test for character truncation.
5943 * charset.c (load_charset_map): <, not <=, for optimization,
5944 and to avoid potential problems with integer overflow.
5945 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5946 * casetab.c (set_identity, shuffle): Likewise.
5947 * editfns.c (Fformat): Likewise.
5948 * syntax.c (skip_chars): Likewise.
5950 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5951 This also lets GCC 4.6.0 generate slightly better loop code.
5953 * callint.c (Fcall_interactively): <, not <=, for optimization.
5954 (Fcall_interactively): Count the number of arguments produced,
5955 not the number of arguments given. This is simpler and lets GCC
5956 4.6.0 generate slightly better code.
5958 * ftfont.c: Distingish more carefully between FcChar8 and char.
5959 The previous code passed unsigned char * to a functions like
5960 strlen and xstrcasecmp that expect char *, which does not
5961 conform to the C standard.
5962 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5963 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5964 char * when the C standard requires it.
5966 * keyboard.c (read_char): Remove unused var.
5968 * eval.c: Port to Windows vsnprintf (Bug#8435).
5970 (SIZE_MAX): Define if the headers do not.
5971 (verror): Do not give up if vsnprintf returns a negative count.
5972 Instead, grow the buffer. This ports to Windows vsnprintf, which
5973 does not conform to C99. Problem reported by Eli Zaretskii.
5974 Also, simplify the allocation scheme, by avoiding the need for
5975 calling realloc, and removing the ALLOCATED variable.
5977 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5979 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5980 But keep the doprint source code for now, as we might revamp it
5981 and use it again (Bug#8435).
5982 * lisp.h (doprnt): Remove.
5983 * Makefile.in (base_obj): Remove doprnt.o.
5984 * deps.mk (doprnt.o): Remove.
5986 error: Print 32- and 64-bit integers portably (Bug#8435).
5987 Without this change, on typical 64-bit hosts error ("...%d...", N)
5988 was used to print both 32- and 64-bit integers N, which relied on
5990 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5992 * lisp.h (error, verror): Mark as printf-like functions.
5993 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5994 Report overflow in size calculations when allocating printf buffer.
5995 Do not truncate output string at its first null byte.
5996 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5997 Truncate the output at a character boundary, since vsnprintf does not
5999 * charset.c (check_iso_charset_parameter): Convert internal
6000 character to string before calling 'error', since %c now has the
6002 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6003 overflow when computing char to be passed to 'error'. Do not
6004 pass Lisp_Object to 'error'; pass the integer instead.
6005 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6006 formatted with plain %d.
6008 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6010 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6012 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6014 * xterm.c (x_catch_errors): Remove duplicate declaration.
6016 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6018 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6020 2011-04-10 Jim Meyering <meyering@redhat.com>
6022 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6023 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6024 return ssize_t not "int", and use size_t as the buffer length.
6025 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6026 * gnutls.h: Update declarations.
6027 * process.c (read_process_output): Use ssize_t, to match.
6028 (send_process): Likewise.
6030 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6032 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6034 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6036 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6037 Use unsigned char, to match FcChar8 type definition.
6039 * xterm.c (handle_one_xevent):
6040 * xmenu.c (create_and_show_popup_menu):
6041 * xselect.c (x_decline_selection_request)
6042 (x_reply_selection_request): Avoid type-punned deref of X events.
6044 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6046 Fix some uses of `int' instead of EMACS_INT.
6047 * search.c (string_match_1, fast_string_match)
6048 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6049 (scan_buffer, find_next_newline_no_quit)
6050 (find_before_next_newline, search_command, Freplace_match)
6051 (Fmatch_data): Make some `int' variables be EMACS_INT.
6053 * xdisp.c (display_count_lines): 3rd argument and return value now
6054 EMACS_INT. All callers changed.
6055 (pint2hrstr): Last argument is now EMACS_INT.
6057 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6058 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6059 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6060 (decode_coding_utf_16, decode_coding_emacs_mule)
6061 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6062 (decode_coding_ccl, decode_coding_charset)
6063 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6064 (decode_coding_iso_2022, decode_coding_emacs_mule)
6065 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6066 <char_offset, last_offset>: Declare EMACS_INT.
6067 (encode_coding_utf_8, encode_coding_utf_16)
6068 (encode_coding_emacs_mule, encode_invocation_designation)
6069 (encode_designation_at_bol, encode_coding_iso_2022)
6070 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6071 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6073 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6074 (encode_invocation_designation): Last argument P_NCHARS is now
6076 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6077 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6079 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6082 * ccl.c (Fccl_execute_on_string): Declare some variables
6085 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6087 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6089 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6091 * process.c (Fformat_network_address): Doc fix.
6093 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6095 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6097 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6099 * keyboard.c (read_char): Call Lisp function help-form-show,
6100 instead of using internal_with_output_to_temp_buffer.
6101 (Qhelp_form_show): New var.
6102 (syms_of_keyboard): Use DEFSYM macro.
6104 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6106 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6108 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6110 * process.c (Flist_processes): Remove to Lisp.
6111 (list_processes_1): Delete.
6113 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6115 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6117 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6119 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6121 Fix more problems found by GCC 4.6.0's static checks.
6123 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6125 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6127 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6129 * xdisp.c (vmessage): Mark as a printf-like function.
6131 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6133 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6135 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6136 printf-like functions.
6137 (tiff_load): Add casts to remove these marks before passing them
6138 to system-supplied API.
6140 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6142 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6143 This avoids several warnings with gcc -Wstrict-overflow.
6144 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6145 directly, rather than having caller test rule sign. This avoids
6146 some unnecessary tests.
6147 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6148 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6149 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6151 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6152 (xfont_open): Avoid unnecessary tests.
6154 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6156 * composite.h, composite.c (composition_gstring_put_cache):
6157 Use EMACS_INT, not int, for length.
6159 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6160 breaking out part of COMPOSITION_DECODE_RULE.
6161 (COMPOSITION_DECODE_RULE): Use it.
6162 * composite.c (get_composition_id): Remove unused local vars,
6163 by using the new macro.
6165 * textprop.c (set_text_properties_1): Change while to do-while,
6166 since the condition is always true at first.
6168 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6169 (interval_deletion_adjustment): Return unsigned value.
6172 * process.c (list_processes_1, create_pty, read_process_output):
6173 (exec_sentinel): Remove vars that were set but not used.
6174 (create_pty): Remove unnecessary "volatile"s.
6175 (Fnetwork_interface_info): Avoid possibility of int overflow.
6176 (read_process_output): Do adaptive read buffering even if carryover.
6177 (read_process_output): Simplify nbytes computation if buffered.
6179 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6181 * syntax.c (scan_words): Remove var that was set but not used.
6182 (update_syntax_table): Use unsigned instead of int.
6184 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6185 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6186 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6188 * print.c (print_error_message): Avoid int overflow.
6190 * font.c (font_list_entities): Redo for clarity,
6191 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6193 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6194 (font_score): Avoid potential overflow in diff calculation.
6196 * fns.c (substring_both): Remove var that is set but not used.
6197 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6199 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6201 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6202 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6203 can always succeed if overflow has undefined behavior.
6205 * search.c (boyer_moore, wordify): Remove vars set but not used.
6206 (wordify): Omit three unnecessary tests.
6208 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6209 All callers changed. This avoids the need for an unused var.
6211 * casefiddle.c (casify_region): Remove var that is set but not used.
6213 * dired.c (file_name_completion): Remove var that is set but not used.
6215 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6217 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6218 (Finsert_file_contents): Remove unnecessary code checking fd.
6220 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6221 Check for integer overflow on size calculations.
6223 * buffer.c (Fprevious_overlay_change): Remove var that is set
6226 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6227 Remove vars that are set but not used.
6228 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6229 (timer_check_2): Mark vars as initialized.
6231 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6233 * image.c (lookup_image): Remove var that is set but not used.
6234 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6236 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6237 that are set but not used.
6239 * xfns.c (make_invisible_cursor): Don't return garbage
6240 if XCreateBitmapFromData fails (Bug#8410).
6242 * xselect.c (x_get_local_selection, x_handle_property_notify):
6243 Remove vars that are set but not used.
6245 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6246 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6248 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6249 Remove var that is set but not used.
6250 (scroll_bar_windows_size): Now size_t, not int.
6251 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6254 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6255 (map_tty_color) [!defined MSDOS]: Likewise.
6257 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6259 * coding.c: Remove vars that are set but not used.
6260 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6261 All callers changed.
6262 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6263 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6264 (decode_coding_charset): Remove vars that are set but not used.
6266 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6267 that is set but not used.
6269 * print.c (print_object): Remove var that is set but not used.
6271 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6272 The gnulib version avoids calling malloc in the usual case,
6273 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6274 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6275 * filelock.c (current_lock_owner): Likewise.
6276 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6277 * sysdep.c: Include allocator.h, careadlinkat.h.
6278 (emacs_no_realloc_allocator): New static constant.
6279 (emacs_readlink): New function.
6280 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6281 ../lib/careadlinkat.h.
6283 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6285 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6286 first non-nil return value).
6288 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6290 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6291 if not defined (Bug#8403).
6293 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6295 * xdisp.c (display_count_lines): Remove parameter `start',
6296 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6297 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6298 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6299 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6300 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6301 and thereabouts. All callers changed.
6302 (get_per_char_metric): Remove parameter `f', unused since
6303 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6305 2011-04-02 Jim Meyering <meyering@redhat.com>
6307 do not dereference NULL upon failed strdup
6308 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6309 (ns_get_family): Likewise.
6311 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6313 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6315 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6317 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6320 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6322 Add lexical binding.
6324 * window.c (Ftemp_output_buffer_show): New fun.
6325 (Fsave_window_excursion):
6326 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6328 * lread.c (lisp_file_lexically_bound_p): New function.
6329 (Fload): Bind Qlexical_binding.
6330 (readevalloop): Remove `evalfun' arg.
6331 Bind Qinternal_interpreter_environment.
6332 (Feval_buffer): Bind Qlexical_binding.
6333 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6335 (syms_of_lread): Declare `lexical-binding'.
6337 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6339 * keyboard.c (eval_dyn): New fun.
6340 (menu_item_eval_property): Use it.
6342 * image.c (parse_image_spec): Use Ffunctionp.
6344 * fns.c (concat, mapcar1): Accept byte-code-functions.
6346 * eval.c (Fsetq): Handle lexical vars.
6347 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6348 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6349 (FletX, Flet): Obey lexical binding.
6350 (Fcommandp): Handle closures.
6351 (Feval): New `lexical' arg.
6352 (eval_sub): New function extracted from Feval. Use it almost
6353 everywhere where Feval was used. Look up vars in lexical env.
6355 (Ffunctionp): Move from subr.el.
6356 (Ffuncall): Handle closures.
6357 (apply_lambda): Remove `eval_flags'.
6358 (funcall_lambda): Handle closures and new byte-code-functions.
6359 (Fspecial_variable_p): New function.
6360 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6361 but without exporting it to Lisp.
6363 * doc.c (Fdocumentation, store_function_docstring):
6364 * data.c (Finteractive_form): Handle closures.
6366 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6369 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6371 (exec_byte_code): New function extracted from Fbyte_code to handle new
6372 calling convention for byte-code-functions. Add new byte-codes.
6374 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6376 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6378 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6380 * xdisp.c (redisplay_internal): Fix prototype.
6382 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6384 * xdisp.c (SCROLL_LIMIT): New macro.
6385 (try_scrolling): Use it when setting scroll_limit.
6386 Limit scrolling to 100 screen lines.
6387 (redisplay_window): Even when falling back on "recentering",
6388 position point in the window according to scroll-conservatively,
6389 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6391 (try_scrolling): When point is above the window, allow searching
6392 as far as scroll_max, or one screenful, to compute vertical
6393 distance from PT to the scroll margin position. This prevents
6394 try_scrolling from unnecessarily failing when
6395 scroll-conservatively is set to a value slightly larger than the
6396 window height. Clean up the case of PT below the margin at bottom
6397 of window: scroll_max can no longer be INT_MAX. When aggressive
6398 scrolling is in use, don't let point enter the opposite scroll
6399 margin as result of the scroll.
6400 (syms_of_xdisp) <scroll-conservatively>: Document the
6401 threshold of 100 lines for never-recentering scrolling.
6403 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6405 * dispextern.h (move_it_by_lines):
6406 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6407 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6408 (message_log_check_duplicate): Remove parameters `prev_bol' and
6409 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6410 (redisplay_internal): Remove parameter `preserve_echo_area',
6411 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6413 * indent.c (Fvertical_motion):
6414 * window.c (window_scroll_pixel_based, Frecenter):
6415 Don't pass `need_y_p' to `move_it_by_lines'.
6417 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6419 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6420 steal a few bits to be more compact.
6421 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6422 Remove unneeded casts.
6424 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6426 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6428 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6429 binding" message (bug#7967).
6431 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6433 Fix more problems found by GCC 4.6.0's static checks.
6435 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6436 Remove unused local var.
6438 * editfns.c (Fmessage_box): Remove unused local var.
6440 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6441 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6442 Omit unused local vars.
6443 * window.c (shrink_windows): Omit unused local var.
6444 * menu.c (digest_single_submenu): Omit unused local var.
6445 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6446 Omit unused local var.
6448 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6449 Don't assume string length fits in int.
6450 (keyremap_step, read_key_sequence): Use size_t for sizes.
6451 (read_key_sequence): Don't check last_real_key_start redundantly.
6453 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6454 instead of alloca (Bug#8344).
6456 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6457 (Fbacktrace_frame): Don't assume nframes fits in int.
6459 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6461 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6464 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6466 * cm.c (calccost): Turn while-do into do-while, for clarity.
6468 * keyboard.c (syms_of_keyboard): Use the same style as later
6469 in this function when indexing through an array. This also
6470 works around GCC bug 48267.
6472 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6474 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6476 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6477 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6479 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6480 This avoids undefined behavior on integer overflow, and is a bit
6481 more convenient anyway since it is compared to a size_t variable.
6483 Variadic C functions now count arguments with size_t, not int.
6484 This avoids an unnecessary limitation on 64-bit machines, which
6485 caused (substring ...) to crash on large vectors (Bug#8344).
6486 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6487 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6488 All variadic functions and their callers changed accordingly.
6489 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6490 * data.c (arith_driver, float_arith_driver): Likewise.
6491 * editfns.c (general_insert_function): Likewise.
6492 * eval.c (struct backtrace.nargs, interactive_p)
6493 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6494 (funcall_lambda, mark_backtrace): Likewise.
6495 * fns.c (concat): Likewise.
6496 * frame.c (x_set_frame_parameters): Likewise.
6497 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6498 0 if not found, not -1. All callers changed.
6500 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6501 (stack_copy_size): Now size_t, not int.
6502 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6504 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6506 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6507 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6508 All callers changed.
6510 * lisp.h (multibyte_char_to_unibyte):
6511 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6512 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6513 * character.h (CHAR_TO_BYTE8):
6514 * cmds.c (internal_self_insert):
6515 * editfns.c (general_insert_function):
6516 * keymap.c (push_key_description):
6517 * search.c (Freplace_match):
6518 * xdisp.c (message_dolog, set_message_1): All callers changed.
6520 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6522 * keyboard.c (safe_run_hook_funcall): New function.
6523 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6524 don't set the hook to nil, but remove the offending function instead.
6525 (Qcommand_hook_internal): Remove, unused.
6526 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6527 Vcommand_hook_internal.
6529 * eval.c (enum run_hooks_condition): Remove.
6530 (funcall_nil, funcall_not): New functions.
6531 (run_hook_with_args): Call each function through a `funcall' argument.
6532 Remove `cond' argument, now redundant.
6533 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6534 (Frun_hook_with_args_until_failure): Adjust accordingly.
6535 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6537 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6539 * dispextern.h (string_buffer_position): Remove declaration.
6541 * print.c (strout): Remove parameter `multibyte', unused since
6542 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6544 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6545 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6546 All callers changed.
6548 * w32.c (_wsa_errlist): Use braces for struct initializers.
6550 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6551 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6552 All callers changed.
6553 (string_buffer_position): Likewise. Also, make static (it's never
6554 used outside xdisp.c).
6555 (cursor_row_p): Remove parameter `w', unused since
6556 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6557 (decode_mode_spec): Remove parameter `precision', introduced during
6558 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6559 All callers changed.
6561 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6563 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6565 2011-03-27 Anders Lindgren <andlind@gmail.com>
6567 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6568 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6569 (ns_update_auto_hide_menu_bar): New functions.
6570 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6571 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6572 ns_constrain_all_frames.
6573 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6574 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6576 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6578 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6580 2011-03-27 Glenn Morris <rgm@gnu.org>
6582 * syssignal.h: Replace RETSIGTYPE with void.
6583 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6584 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6585 Replace SIGTYPE with void everywhere.
6586 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6587 * s/template.h (SIGTYPE): Remove commented out definition.
6589 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6591 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6592 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6594 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6596 * w32.c (read_unc_volume): Use parameter `henum', instead of
6597 global variable `wget_enum_handle'.
6599 * keymap.c (describe_vector): Remove parameters `indices' and
6600 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6601 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6603 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6605 * keyboard.c (timer_check): Remove parameter `do_it_now',
6606 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6607 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6608 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6610 * keyboard.c (read_char):
6611 * w32menu.c (w32_menu_display_help):
6612 * xmenu.c (show_help_event, menu_help_callback):
6613 Adjust calls to `show_help_echo'.
6615 * gtkutil.c (xg_maybe_add_timer):
6616 * keyboard.c (readable_events):
6617 * process.c (wait_reading_process_output):
6618 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6620 * insdel.c (adjust_markers_gap_motion):
6621 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6622 (gap_left, gap_right): Don't call it.
6624 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6626 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6627 incurred during fontification.
6629 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6631 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6632 (DEFVAR_PER_BUFFER): Don't pass it.
6634 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6635 (scrolling_window): Don't pass it.
6637 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6639 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6641 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6643 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6644 of variables specific to SELinux and computation of `encoded_absname'.
6646 * image.c (XPutPixel): Remove unused variable `height'.
6648 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6650 * unexw32.c (get_section_info): Remove unused variable `section'.
6652 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6653 (system_process_attributes): Remove unused variable `sess'.
6654 (sys_read): Remove unused variable `err'.
6656 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6657 (w32_wnd_proc): Remove unused variable `isdead'.
6658 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6659 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6660 (x_create_tip_frame): Remove unused variable `tem'.
6662 * w32inevt.c (w32_console_read_socket):
6663 Remove unused variable `no_events'.
6665 * w32term.c (x_draw_composite_glyph_string_foreground):
6666 Remove unused variable `width'.
6668 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6670 * w32term.c (x_set_glyph_string_clipping):
6671 Don't pass uninitialized region to CombineRgn.
6673 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6675 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6676 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6677 (Fx_close_connection): Remove unused variable `i'.
6679 * w32font.c (w32font_draw): Return number of glyphs.
6680 (w32font_open_internal): Remove unused variable `i'.
6681 (w32font_driver): Add missing initializer.
6683 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6684 (fill_in_menu): Remove unused variable `items_added'.
6686 * w32term.c (last_mouse_press_frame): Remove static global variable.
6687 (w32_clip_to_row): Remove unused variable `f'.
6688 (x_delete_terminal): Remove unused variable `i'.
6690 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6691 (NOTHING): Remove unused static global variable.
6692 (uniscribe_check_otf): Remove unused variable `table'.
6693 (uniscribe_font_driver): Add missing initializers.
6695 2011-03-23 Julien Danjou <julien@danjou.info>
6697 * term.c (Fsuspend_tty, Fresume_tty):
6698 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6699 * window.c (temp_output_buffer_show):
6700 * insdel.c (signal_before_change):
6701 * frame.c (Fhandle_switch_frame):
6702 * fileio.c (Fdo_auto_save):
6703 * emacs.c (Fkill_emacs):
6704 * editfns.c (save_excursion_restore):
6705 * cmds.c (internal_self_insert):
6706 * callint.c (Fcall_interactively):
6707 * buffer.c (Fkill_all_local_variables):
6708 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6710 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6711 unconditionnaly since it does the check itself.
6713 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6715 Fix more problems found by GCC 4.5.2's static checks.
6717 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6718 the first time through the loop, since we know p0 < p1 then.
6719 This also avoids a gcc -Wstrict-overflow warning.
6721 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6722 leading to a memory leak, possible in functions like
6723 load_charset_map_from_file that can allocate an unbounded number
6724 of objects (Bug#8318).
6726 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6727 that could (at least in theory) be that large.
6729 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6730 This is less likely to overflow, and avoids undefined behavior if
6731 overflow does occur. All callers changed. Use strtoul to scan
6732 for the unsigned long integer.
6733 (pint2hrstr): Simplify and tune code slightly.
6734 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6736 * scroll.c (do_scrolling): Work around GCC bug 48228.
6737 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6739 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6740 This also avoids a warning with gcc -Wstrict-overflow.
6741 (validate_x_resource_name): Simplify count usage.
6742 This also avoids a warning with gcc -Wstrict-overflow.
6744 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6747 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6749 * process.c (Fmake_network_process): Use socklen_t, not int,
6750 where POSIX says socklen_t is required in portable programs.
6751 This fixes a porting bug on hosts like 64-bit HP-UX, where
6752 socklen_t is wider than int (Bug#8277).
6753 (Fmake_network_process, server_accept_connection):
6754 (wait_reading_process_output, read_process_output):
6757 * process.c: Rename or move locals to avoid shadowing.
6758 (list_processes_1, Fmake_network_process):
6759 (read_process_output_error_handler, exec_sentinel_error_handler):
6760 Rename or move locals.
6761 (Fmake_network_process): Define label "retry_connect" only if needed.
6762 (Fnetwork_interface_info): Fix pointer signedness.
6763 (process_send_signal): Add cast to avoid pointer signedness problem.
6764 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6765 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6767 Make tparam.h and terminfo.c consistent.
6768 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6769 Include tparam.h instead, since it declares them.
6770 * cm.h (PC): Remove extern decl; tparam.h now does this.
6771 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6772 * terminfo.c: Include tparam.h, to check interfaces.
6773 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6774 (tparam): Adjust signature to match interface in tparam.h;
6775 this removes some undefined behavior. Check that outstring and len
6776 are zero, which they always are with Emacs.
6777 * tparam.h (PC, BC, UP): New extern decls.
6779 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6780 (xftfont_open): Rename locals to avoid shadowing.
6782 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6783 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6784 (OTF_TAG_SYM): Omit macro if not needed.
6785 (ftfont_list): Remove unused local.
6786 (get_adstyle_property, ftfont_pattern_entity):
6787 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6788 Rename locals to avoid shadowing.
6790 * xfont.c (xfont_list_family): Mark var as initialized.
6792 * xml.c (make_dom): Now static.
6794 * composite.c (composition_compute_stop_pos): Rename local to
6796 (composition_reseat_it): Remove unused locals.
6797 (find_automatic_composition, composition_adjust_point): Likewise.
6798 (composition_update_it): Mark var as initialized.
6799 (find_automatic_composition): Mark vars as initialized,
6800 with a FIXME (Bug#8290).
6802 character.h: Rename locals to avoid shadowing.
6803 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6804 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6805 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6806 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6809 * textprop.c (property_change_between_p): Remove; unused.
6811 * intervals.c (interval_start_pos): Now static.
6813 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6815 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6816 Rename locals to avoid shadowing.
6818 * sound.c (wav_play, au_play, Fplay_sound_internal):
6819 Fix pointer signedness.
6820 (alsa_choose_format): Remove unused local var.
6821 (wav_play): Initialize a variable to 0, to prevent undefined
6822 behavior (Bug#8278).
6824 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6826 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6828 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6829 clobbering (Bug#8298).
6830 * sysdep.c (sys_subshell): Likewise.
6831 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6833 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6834 This should get cleaned up, so that child_setup has the
6835 same signature on all platforms.
6837 * callproc.c (call_process_cleanup): Now static.
6838 (relocate_fd): Rename locals to avoid shadowing.
6840 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6842 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6843 not to be necessary, and produces flickering.
6845 2011-03-20 Glenn Morris <rgm@gnu.org>
6847 * config.in: Remove file.
6849 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6851 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6852 are now in src/globals.h.
6853 (syms_of_minibuf): Remove spurious & from previous change.
6855 2011-03-20 Leo <sdl.web@gmail.com>
6857 * minibuf.c (completing-read-function): New variable.
6858 (completing-read-default): Rename from completing-read.
6859 (completing-read): Call completing-read-function.
6861 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6863 * xfaces.c (Fx_load_color_file):
6864 Read color file from absolute filename (bug#8250).
6866 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6868 * makefile.w32-in: Update dependencies.
6870 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6872 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6874 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6876 Fix more problems found by GCC 4.5.2's static checks.
6878 * process.c (make_serial_process_unwind, send_process_trap):
6879 (sigchld_handler): Now static.
6881 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6882 That way, the code declares only the vars that it needs.
6883 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6884 * s/cygwin.h (PTY_ITERATION): Likewise.
6885 * s/darwin.h (PTY_ITERATION): Likewise.
6886 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6888 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6889 * process.c (allocate_pty): Don't declare stb unless it's needed.
6891 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6892 (CONSTANTLIM): Remove; unused.
6893 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6894 Define only if needed.
6896 * unexelf.c (unexec): Name an expression,
6897 to avoid gcc -Wbad-function-cast warning.
6898 Use a different way to cause a compilation error if anyone uses
6899 n rather than nn, a way that does not involve shadowing.
6900 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6902 * deps.mk (unexalpha.o): Remove; unused.
6904 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6905 * unexec.h: New file.
6906 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6907 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6909 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6910 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6911 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6912 Change as necessary to match prototype in unexec.h.
6914 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6916 (back_comment, skip_chars): Mark vars as initialized.
6918 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6919 Rename locals to avoid shadowing.
6921 * lread.c (read1): Rewrite so as not to use empty "else".
6922 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6924 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6926 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6927 warning when compiling print.c.
6929 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6930 instead of using an uninitialized var.
6931 (font_sort_entities): Mark var as initialized.
6933 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6935 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6936 pointers to constants.
6937 (font_parse_fcname): Remove unused vars.
6938 (font_delete_unmatched): Now static.
6939 (font_get_spec): Remove; unused.
6940 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6941 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6942 Rename or move locals to avoid shadowing.
6944 * fns.c (require_nesting_list, require_unwind): Now static.
6945 (Ffillarray): Rename locals to avoid shadowing.
6947 * floatfns.c (domain_error2): Define only if needed.
6948 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6950 * alloc.c (mark_backtrace): Move decl from here ...
6951 * lisp.h: ... to here, so that it can be checked.
6953 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6954 (Fdefvar): Rewrite so as not to use empty "else".
6955 (lisp_indirect_variable): Name an expression,
6956 to avoid gcc -Wbad-function-cast warning.
6957 (Fdefvar): Rename locals to avoid shadowing.
6959 * callint.c (quotify_arg, quotify_args): Now static.
6960 (Fcall_interactively): Rename locals to avoid shadowing.
6961 Use const pointer when appropriate.
6963 * lisp.h (get_system_name, get_operating_system_release):
6964 Move decls here, to check interfaces.
6965 * process.c (get_operating_system_release): Move decl to lisp.h.
6966 * xrdb.c (get_system_name): Likewise.
6967 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6968 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6969 some of which prompt warnings from gcc -Wbad-function-cast.
6970 (Fformat_time_string, Fencode_time, Finsert_char):
6971 (Ftranslate_region_internal, Fformat):
6972 Rename or remove local vars to avoid shadowing.
6973 (Ftranslate_region_internal): Mark var as initialized.
6975 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6978 * lisp.h (eassert): Check that the argument compiles, even if
6979 ENABLE_CHECKING is not defined.
6981 * data.c (Findirect_variable): Name an expression, to avoid
6982 gcc -Wbad-function-cast warning.
6983 (default_value, arithcompare, arith_driver, arith_error): Now static.
6984 (store_symval_forwarding): Rename local to avoid shadowing.
6985 (Fmake_variable_buffer_local, Fmake_local_variable):
6986 Mark variables as initialized.
6987 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6989 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6990 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6991 Rename locals to avoid shadowing.
6992 (mark_stack): Move local variables into the #ifdef region where
6994 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6995 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6997 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6998 (GC_STRING_CHARS): Remove; not used.
6999 (Fmemory_limit): Cast sbrk's returned value to char *.
7001 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7002 avoids undefined behavior in theory.
7004 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7006 Use functions, not macros, for up- and down-casing (Bug#8254).
7007 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7008 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7009 to use the following functions instead of these macros.
7010 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7011 EMACS_INT, since callers assume the returned value fits in int.
7012 (upcase1): Likewise, for UPCASE_TABLE.
7013 (uppercasep, lowercasep, upcase): New static inline functions.
7014 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7015 the race-condition problem in the old DOWNCASE.
7017 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7018 Rename locals to avoid shadowing.
7019 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7020 (regex_compile, re_search_2, re_match_2_internal):
7021 Remove unused local vars.
7022 (FREE_VAR): Rewrite so as not to use empty "else",
7023 which gcc can warn about.
7024 (regex_compile, re_match_2_internal): Mark locals as initialized.
7025 (RETALLOC_IF): Define only if needed.
7026 (WORDCHAR_P): Likewise. This one is never needed, but is used
7027 only in a comment talking about a compiler bug, so put inside
7028 the #if 0 of that comment.
7029 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7030 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7033 * search.c (boyer_moore): Rename locals to avoid shadowing.
7034 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7035 (PREV_CHAR_BOUNDARY): Likewise.
7037 * search.c (simple_search): Remove unused var.
7039 * dired.c (compile_pattern): Move decl from here ...
7040 * lisp.h: ... to here, so that it can be checked.
7041 (struct re_registers): New forward decl.
7043 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7045 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7047 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7048 Rename locals to avoid shadowing.
7049 (Fvertical_motion): Mark locals as initialized.
7051 * casefiddle.c (casify_object, casify_region): Now static.
7052 (casify_region): Mark local as initialized.
7054 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7056 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7057 New macros, so that the caller can use some names other than
7058 gcpro1, gcpro2, etc.
7059 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7061 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7062 argument, for consistency with GCPRO2_VAR, etc: it is now the
7063 prefix of the variable, not the variable itself. All uses
7065 * dired.c (directory_files_internal, file_name_completion):
7066 Rename locals to avoid shadowing.
7068 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7069 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7070 dired.c's scmp function, had undefined behavior.
7071 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7072 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7073 * buffer.h: ... to here, because these macros use current_buffer,
7074 and the new implementation with inline functions needs to have
7075 current_buffer in scope now, rather than later when the macros
7077 (downcase, upcase1): New static inline functions.
7078 (DOWNCASE, UPCASE1): Reimplement using these functions.
7079 This avoids undefined behavior in expressions like
7080 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7081 from race conditions in accessing the global variables
7082 case_temp1 and case_temp2.
7083 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7084 * lisp.h (case_temp1, case_temp2): Remove their decls.
7085 * character.h (ASCII_CHAR_P): Move from here ...
7086 * lisp.h: ... to here, so that the inline functions mentioned
7089 * dired.c (directory_files_internal_unwind): Now static.
7091 * fileio.c (file_name_as_directory, directory_file_name):
7092 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7094 (file_name_as_directory): Use const pointers when appropriate.
7095 (Fexpand_file_name): Likewise. In particular, newdir might
7096 point at constant storage, so make it a const pointer.
7097 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7098 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7100 (Fset_file_times, Finsert_file_contents, auto_save_error):
7101 Rename locals to avoid shadowing.
7103 * minibuf.c (choose_minibuf_frame_1): Now static.
7104 (Ftry_completion, Fall_completions): Rename or remove locals
7107 * marker.c (bytepos_to_charpos): Remove; unused.
7109 * lisp.h (verify_bytepos, count_markers): New decls,
7110 so that gcc does not warn that these functions aren't declared.
7112 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7113 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7114 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7115 (copy_text): Remove unused local var.
7117 * filelock.c (within_one_second): Now static.
7118 (lock_file_1): Rename local to avoid shadowing.
7120 * buffer.c (fix_overlays_before): Mark locals as initialized.
7121 (fix_start_end_in_overlays): Likewise. This function should be
7122 simplified by using pointers-to-pointers, but that's a different
7124 (switch_to_buffer_1): Now static.
7125 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7126 (report_overlay_modification): Rename locals to avoid shadowing.
7128 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7129 Fix pointer signedness issue.
7130 (sys_subshell): Mark local as volatile if checking for lint,
7131 to suppress a gcc -Wclobbered warning that does not seem to be right.
7132 (MAXPATHLEN): Define only if needed.
7134 * process.c (serial_open, serial_configure): Move decls from here ...
7135 * systty.h: ... to here, so that they can be checked.
7137 * fns.c (get_random, seed_random): Move extern decls from here ...
7138 * lisp.h: ... to here, so that they can be checked.
7140 * sysdep.c (reset_io): Now static.
7141 (wait_for_termination_signal): Remove; unused.
7143 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7144 (copy_keymap_item, append_key, push_text_char_description):
7146 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7147 (DENSE_TABLE_SIZE): Remove; unused.
7148 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7149 (describe_map_tree):
7150 Rename locals to avoid shadowing.
7152 * keyboard.c: Declare functions static if they are not used elsewhere.
7153 (echo_char, echo_dash, cmd_error, top_level_2):
7154 (poll_for_input, handle_async_input): Now static.
7155 (read_char, kbd_buffer_get_event, make_lispy_position):
7156 (make_lispy_event, make_lispy_movement, apply_modifiers):
7157 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7158 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7159 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7160 (read_key_sequence, read_char): Mark locals as initialized.
7161 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7163 * keyboard.h (make_ctrl_char): New decl.
7164 (mark_kboards): Move decl here ...
7165 * alloc.c (mark_kboards): ... from here.
7167 * lisp.h (force_auto_save_soon): New decl.
7169 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7170 (DEFINE_DUMMY_FUNCTION): New macro.
7171 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7173 (main): Add casts to avoid warnings
7174 if GCC considers string literals to be constants.
7176 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7178 * dbusbind.c: Pointer signedness fixes.
7179 (xd_signature, xd_append_arg, xd_initialize):
7180 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7181 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7182 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7183 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7185 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7186 if GCC considers string literals to be constants.
7187 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7189 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7191 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7192 (print_preprocess, print_object): New macro to fix last change.
7194 * print.c (print_preprocess): Don't forget font objects.
7196 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7198 * emacs.c (USAGE3): Doc fixes.
7200 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7202 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7205 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7207 * lisp.h (VWindow_system, Qfile_name_history):
7208 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7209 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7210 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7212 * w32select.c: Don't #include "keyboard.h".
7213 (run_protected): Add extern declaration for waiting_for_input.
7215 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7216 * w32console.c (detect_input_pending, read_input_pending)
7217 (encode_terminal_code):
7218 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7219 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7220 (w32_system_caret_y, Qfile_name_history):
7221 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7222 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7223 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7224 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7225 * w32proc.c (Qlocal, report_file_error):
7226 * w32term.c (Vwindow_system, updating_frame):
7227 * w32uniscribe.c (initialized, uniscribe_font_driver):
7228 Remove unneeded extern declarations.
7230 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7232 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7234 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7236 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7237 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7238 These macros can no longer be used for assignment.
7240 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7241 Assign struct members directly, instead of using BUF_BEGV etc.
7242 (record_buffer_markers, fetch_buffer_markers): New functions for
7243 recording and fetching special buffer markers.
7244 (set_buffer_internal_1, set_buffer_temp): Use them.
7246 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7248 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7250 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7251 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7253 * xdisp.c (hscroll_window_tree):
7254 (reconsider_clip_changes): Use PT instead of BUF_PT.
7256 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7258 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7259 $(EMACS_ROOT)/lib/intprops.h.
7261 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7263 Fix more problems found by GCC 4.5.2's static checks.
7265 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7266 to unsigned char * to avoid compiler diagnostic.
7267 (xg_free_frame_widgets): Make it clear that a local variable is
7268 needed only if USE_GTK_TOOLTIP.
7269 (gdk_window_get_screen): Make it clear that this macro is needed
7270 only if USE_GTK_TOOLTIP.
7271 (int_gtk_range_get_value): New function, which avoids a diagnostic
7272 from gcc -Wbad-function-cast.
7273 (xg_set_toolkit_scroll_bar_thumb): Use it.
7274 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7275 diagnostic from gcc -Wbad-function-cast.
7276 (get_utf8_string, xg_get_file_with_chooser):
7277 Rename locals to avoid shadowing.
7278 (create_dialog): Move locals to avoid shadowing.
7280 * xgselect.c (xg_select): Remove unused var.
7282 * image.c (four_corners_best): Mark locals as initialized.
7283 (gif_load): Initialize transparent_p to zero (Bug#8238).
7284 Mark another local as initialized.
7285 (my_png_error, my_error_exit): Mark with NO_RETURN.
7287 * image.c (clear_image_cache): Now static.
7288 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7289 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7290 (x_edge_detection): Remove unnecessary cast that
7291 gcc -Wbad-function-cast diagnoses.
7292 (gif_load): Fix pointer signedness.
7293 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7294 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7296 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7298 Improve quality of tests for time stamp overflow.
7299 For example, without this patch (encode-time 0 0 0 1 1
7300 1152921504606846976) returns the obviously-bogus value (-948597
7301 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7302 reports time overflow. See
7303 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7304 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7305 * editfns.c: Include limits.h and intprops.h.
7306 (TIME_T_MIN, TIME_T_MAX): New macros.
7307 (time_overflow): Move earlier, to before first use.
7308 (hi_time, lo_time): New functions, for an accurate test for
7310 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7311 (Fget_internal_run_time): Don't assume time_t fits in int.
7312 (make_time): Use list2 instead of Fcons twice.
7313 (Fdecode_time): More accurate test for out-of-range times.
7314 (check_tm_member): New function.
7315 (Fencode_time): Use it, to test for out-of-range times.
7316 (lisp_time_argument): Don't rely on undefined left-shift and
7317 right-shift behavior when checking for time stamp overflow.
7319 * editfns.c (time_overflow): New function, refactoring common code.
7320 (Fformat_time_string, Fdecode_time, Fencode_time):
7321 (Fcurrent_time_string): Use it.
7323 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7324 * dired.c (make_time): Move to ...
7325 * editfns.c (make_time): ... here.
7326 * systime.h: Note the move.
7328 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7330 * fringe.c (update_window_fringes): Remove unused variables.
7332 * unexmacosx.c (copy_data_segment): Also copy __got section.
7335 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7337 * termcap.c [MSDOS]: Include "msdos.h".
7338 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7339 Constify `char *' arguments and their references according to
7340 prototypes in tparam.h.
7342 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7344 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7345 Adapt all references accordingly.
7347 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7349 2011-03-11 Tom Tromey <tromey@redhat.com>
7351 * buffer.c (syms_of_buffer): Remove obsolete comment.
7353 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7355 * termhooks.h (encode_terminal_code): Declare prototype.
7357 * msdos.c (encode_terminal_code): Don't declare prototype.
7359 * term.c (encode_terminal_code): Now external again, used by
7360 w32console.c and msdos.c.
7362 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7363 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7365 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7367 Fix some minor problems found by GCC 4.5.2's static checks.
7369 * fringe.c (update_window_fringes): Mark locals as initialized
7371 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7373 * alloc.c (mark_fringe_data): Move decl from here ...
7374 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7375 to check its interface.
7376 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7378 * fontset.c (free_realized_fontset): Now static.
7379 (Fset_fontset_font): Rename local to avoid shadowing.
7380 (fontset_font): Mark local as initialized.
7381 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7383 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7385 * xselect.c (x_disown_buffer_selections): Remove; not used.
7386 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7387 (x_own_selection, Fx_disown_selection_internal): Rename locals
7389 (x_handle_dnd_message): Remove local to avoid shadowing.
7391 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7392 so that the caller can use some name other than gcpro1.
7393 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7394 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7395 (Fx_backspace_delete_keys_p):
7396 Use them to avoid shadowing, and rename vars to avoid shadowing.
7397 (x_decode_color, x_set_name, x_window): Now static.
7398 (Fx_create_frame): Add braces to silence GCC warning.
7399 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7400 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7401 Remove unused locals.
7402 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7403 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7404 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7407 * xterm.h (x_mouse_leave): New decl.
7409 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7410 Remove unused functions.
7411 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7412 (x_calc_absolute_position): Now static.
7413 (XTread_socket): Don't define label "out" unless it's used.
7414 Don't declare local "event" unless it's used.
7415 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7416 unless they are used.
7417 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7418 (x_fatal_error_signal): Remove; not used.
7419 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7420 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7421 (x_error_catcher, x_connection_closed, x_error_handler):
7422 (x_error_quitter, xembed_send_message, x_iconify_frame):
7423 (my_log_handler): Rename locals to avoid shadowing.
7424 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7425 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7427 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7428 Rename or move locals to avoid shadowing.
7429 (tty_defined_color, merge_face_heights): Now static.
7430 (free_realized_faces_for_fontset): Remove; not used.
7431 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7432 does not deduce is never used uninitialized.
7433 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7434 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7436 * terminal.c (store_terminal_param): Now static.
7438 * xmenu.c (menu_highlight_callback): Now static.
7439 (set_frame_menubar): Remove unused local.
7440 (xmenu_show): Rename parameter to avoid shadowing.
7441 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7442 since they might point to immutable storage.
7443 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7444 since it's unused otherwise.
7446 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7447 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7448 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7449 avoids a gcc -Wuninitialized diagnostic.
7450 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7451 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7452 does not deduce are never used uninitialized.
7454 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7456 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7457 * window.c (window_loop, size_window):
7458 (run_window_configuration_change_hook, enlarge_window): Likewise.
7460 * window.c (display_buffer): Now static.
7461 (size_window): Mark variables that gcc -Wuninitialized
7462 does not deduce are never used uninitialized.
7463 * window.h (check_all_windows): New decl, to forestall
7464 gcc -Wmissing-prototypes diagnostic.
7465 * dispextern.h (bidi_dump_cached_states): Likewise.
7467 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7469 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7471 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7472 and to avoid gcc -Wuninitialized warning.
7473 (load_charset_map): Mark variables that gcc -Wuninitialized
7474 does not deduce are never used uninitialized.
7475 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7477 * coding.c (coding_set_source, coding_set_destination):
7478 Use "else { /* comment */ }" rather than "else /* comment */;"
7479 for clarity, and to avoid gcc -Wempty-body warning.
7480 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7481 a block, when the outer 'i' will do.
7482 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7483 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7484 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7485 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7486 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7487 Rename locals to avoid shadowing.
7488 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7489 * coding.c (emacs_mule_char, encode_invocation_designation):
7490 Now static, since they're not used elsewhere.
7491 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7492 (decode_coding_object, encode_coding_object, detect_coding_system):
7493 (decode_coding_emacs_mule): Mark variables that gcc
7494 -Wuninitialized does not deduce are never used uninitialized.
7495 (detect_coding_iso_2022): Initialize a local variable that might
7496 be used uninitialized. Leave a FIXME because it's not clear that
7497 this initialization is needed. (Bug#8211)
7498 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7499 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7500 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7501 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7502 Remove unused macros.
7504 * category.c (hash_get_category_set): Remove unused local var.
7505 (copy_category_table): Now static, since it's not used elsewhere.
7506 * character.c (string_count_byte8): Likewise.
7508 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7509 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7511 * chartab.c (copy_sub_char_table): Now static, since it's not used
7513 (sub_char_table_ref_and_range, char_table_ref_and_range):
7514 Rename locals to avoid shadowing.
7515 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7517 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7518 (BIDI_BOB): Remove unused macro.
7520 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7521 deduce are never used uninitialized.
7522 * term.c (encode_terminal_code): Likewise.
7524 * term.c (encode_terminal_code): Now static. Remove unused local.
7526 * tparam.h: New file.
7527 * term.c, tparam.h: Include it.
7528 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7529 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7530 Move these decls to tparam.h, and make them agree with what
7531 is actually in tparam.c. The previous trick of using incompatible
7532 decls in different modules does not conform to the C standard.
7533 All callers of tparam changed to use tparam's actual API.
7534 * tparam.c (tparam1, tparam, tgoto):
7535 Use const pointers where appropriate.
7537 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7538 * cm.h (struct cm): Likewise.
7539 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7540 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7541 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7542 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7543 (turn_on_face, init_tty): Likewise.
7544 * termchar.h (struct tty_display_info): Likewise.
7546 * term.c (term_mouse_position): Rename local to avoid shadowing.
7548 * alloc.c (mark_ttys): Move decl from here ...
7549 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7551 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7553 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7555 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7557 * search.c (compile_pattern_1): Remove argument regp, unused since
7558 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7559 (compile_pattern): Don't pass it.
7561 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7563 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7564 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7566 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7568 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7570 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7571 gdk_window_get_screen, gdk_window_get_geometry,
7572 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7573 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7574 (xg_get_pixbuf_from_pixmap): New function.
7575 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7576 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7577 Call xg_get_pixbuf_from_pixmap instead of
7578 gdk_pixbuf_get_from_drawable.
7579 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7580 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7581 (xg_check_special_colors): Use GtkStyleContext and its functions
7583 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7584 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7585 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7586 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7587 Call gtk_widget_get_preferred_size.
7588 (xg_frame_resized): gdk_window_get_geometry only takes 5
7590 (xg_win_to_widget, xg_event_is_for_menubar):
7591 Call gdk_x11_window_lookup_for_display.
7592 (xg_set_widget_bg): New function.
7593 (delete_cb): New function.
7594 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7595 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7596 (xg_set_background_color): Call xg_set_widget_bg.
7597 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7598 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7599 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7600 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7602 (update_frame_tool_bar): Call gtk_widget_hide.
7603 (xg_initialize): Use GDK_KEY_g.
7605 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7607 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7609 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7610 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7611 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7613 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7615 * w32xfns.c (select_palette): Check success of RealizePalette against
7616 GDI_ERROR, not zero.
7618 See ChangeLog.11 for earlier changes.
7624 Copyright (C) 2011 Free Software Foundation, Inc.
7626 This file is part of GNU Emacs.
7628 GNU Emacs is free software: you can redistribute it and/or modify
7629 it under the terms of the GNU General Public License as published by
7630 the Free Software Foundation, either version 3 of the License, or
7631 (at your option) any later version.
7633 GNU Emacs is distributed in the hope that it will be useful,
7634 but WITHOUT ANY WARRANTY; without even the implied warranty of
7635 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7636 GNU General Public License for more details.
7638 You should have received a copy of the GNU General Public License
7639 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.