1 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
5 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
7 For a 'struct window', replace some Lisp_Object fields to
8 bitfields where appropriate, remove unused fields.
9 * window.h (struct window): Remove unused 'last_mark_x' and
10 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
11 change it's type from Lisp_Object to bitfield.
12 Change type of 'force_start', 'optional_new_start',
13 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
14 fields from Lisp_Object to bitfield. Adjust users accordingly.
16 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
18 Pacify gcc -Wdouble-precision when using Xaw.
19 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
20 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
21 Use 'float' consistently, rather than 'float' in most places
22 and 'double' in a couple of places.
24 2012-05-31 Eli Zaretskii <eliz@gnu.org>
26 * xdisp.c (handle_stop): Detect whether we have overlay strings
27 loaded by testing it->current.overlay_string_index to be
28 non-negative, instead of checking whether n_overlay_strings is
31 2012-05-31 Chong Yidong <cyd@gnu.org>
33 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
35 * doc.c (Fsubstitute_command_keys): Doc fix.
37 2012-05-31 Eli Zaretskii <eliz@gnu.org>
39 * search.c (search_buffer): Remove calls to
40 r_alloc_inhibit_buffer_relocation, as it is now called by
41 maybe_unify_char, which was the cause of relocation of buffer text
44 2012-05-31 Eli Zaretskii <eliz@gnu.org>
46 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
47 for the duration of call to load_charset, to avoid problems with
48 callers of maybe_unify_char that access buffer text through C
51 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
52 decrement the inhibition flag, instead of just setting or
55 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
57 Remove obsolete '#define static' cruft.
58 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
59 This #undef was "temporary" in 2000; it is no longer needed
60 now that '#define static' has gone away.
61 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
62 (gray_bitmap_bits): Remove; no longer needed.
63 All uses replaced with definiens.
64 * xterm.c: Include "bitmaps/gray.xbm".
66 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
68 Clean up __executable_start, monstartup when --enable-profiling.
69 The following changes affect the code only when profiling.
70 * dispnew.c (__executable_start): Rename from safe_bcopy.
71 Define only on platforms that need it.
72 * emacs.c: Include <sys/gmon.h> when profiling.
73 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
74 (__executable_start): Remove decl, since lisp.h does it now.
75 (safe_bcopy): Remove decl; no longer has that name.
76 (main): Coalesce #if into single bit of code, for simplicity.
77 Cast pointers to uintptr_t, since standard libraries want integers
79 * lisp.h (__executable_start): New decl.
81 2012-05-31 Glenn Morris <rgm@gnu.org>
83 * image.c (Fimagemagick_types): Doc fix.
85 2012-05-30 Jim Meyering <meyering@redhat.com>
87 * callproc.c (Fcall_process_region): Include directory component
88 in mkstemp error message (Bug#11586).
90 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
92 * alloc.c, lisp.h (make_pure_vector): Now static.
94 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
96 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
98 (Fautoload): Do the hash-doc more carefully.
99 * data.c (Fdefalias): Purify definition, except for keymaps.
100 (Qdefun): Move from eval.c.
101 * lisp.h (Qdefun): Remove.
102 * lread.c (read1): Tiny simplification.
104 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
106 Do not create empty overlays with the evaporate property (Bug#9642).
107 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
108 Bug#9642, but explicitly check that the buffer the overlay would
109 be moved to is live and rearrange lines to make sure that errors
110 will not put the overlay in an inconsistent state.
111 (Fdelete_overlay): Cosmetics.
113 2012-05-28 Eli Zaretskii <eliz@gnu.org>
115 * w32term.c (my_bring_window_to_top): New function.
116 (x_raise_frame): Use handle returned by DeferWindowPos, which
117 could be different from the original one.
118 Call my_bring_window_to_top instead of my_set_foreground_window.
121 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
122 by calling BringWindowToTop.
124 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
125 (WM_EMACS_END): Increase by one.
127 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
129 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
130 This avoids undefined behavior that might cause the eassert
131 to not catch an out-of-range value.
133 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
135 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
138 2012-05-27 Eli Zaretskii <eliz@gnu.org>
140 * bidi.c (bidi_mirror_char): Fix last change.
142 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
144 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
145 when referring to sectname field in printf format.
147 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
149 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
150 Only r_alloc_inhibit_buffer_relocation needed to be added;
151 the others were already declared.
153 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
154 before checking whether it's out of range. Put the check inside
156 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
158 2012-05-27 Ken Brown <kbrown@cornell.edu>
160 * callproc.c (Fcall_process): Restore a line that was accidentally
161 commented out in the 2011-02-13 change (bug#11547).
163 2012-05-27 Eli Zaretskii <eliz@gnu.org>
165 * lisp.h [REL_ALLOC]: Add prototypes for external functions
168 * buffer.c [REL_ALLOC]: Remove prototypes of
169 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
170 they are now on lisp.h.
172 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
174 * search.c (search_buffer): Use it to inhibit relocation of buffer
175 text while re_search_2 is doing its job, because re_search_2 is
176 passed C pointers to buffer text. (Bug#11519)
178 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
181 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
182 state after an additional call to move_it_in_display_line_to, keep
183 the values of it->max_ascent and it->max_descent found for the
185 (pos_visible_p): Revert the comparison against bottom_y to what it
186 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
189 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
191 Fix coding-related core dumps with gcc -ftrapv.
192 The code was computing A - B, where A and B are pointers, and B is
193 random garbage. This can lead to core dumps on platforms that
194 have special pointer registers, and it also leads to core dumps on
195 x86-64 when compiled with gcc -ftrapv. The fix is to compute
196 A - B only when B is initialized properly.
197 * coding.c (coding_set_source, coding_set_destination): Return void.
198 (coding_change_source, coding_change_destinations): New functions,
199 with the old behaviors of coding_set_source and coding_set_destination.
200 All callers that need an offset changed to use these new functions.
202 2012-05-26 Glenn Morris <rgm@gnu.org>
204 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
206 2012-05-26 Eli Zaretskii <eliz@gnu.org>
208 Extend mouse support on W32 text-mode console.
209 * xdisp.c (draw_row_with_mouse_face):
210 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
212 * w32console.c: Include window.h.
213 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
215 (initialize_w32_display): Initialize mouse-highlight data.
217 * w32inevt.c: Include termchar.h and window.h.
218 (do_mouse_event): Support mouse-autoselect-window. When the mouse
219 moves, call note_mouse_highlight. If help_echo changed, call
220 gen_help_event to produce help-echo message in the echo area.
221 Call clear_mouse_face if mouse_face_hidden is set in the mouse
224 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
226 * lread.c (read1): Simplify slightly to avoid an overflow warning
227 with GCC 4.7.0 on x86-64.
229 2012-05-26 Eli Zaretskii <eliz@gnu.org>
231 * bidi.c (bidi_mirror_char): Revert last change: an int is
232 definitely wide enough here.
234 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
236 Fix integer width and related bugs (Bug#9874).
237 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
238 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
239 (string_bytes, check_sblock, allocate_string_data):
240 (compact_small_strings, Fmake_bool_vector, make_string)
241 (make_unibyte_string, make_multibyte_string)
242 (make_string_from_bytes, make_specified_string)
243 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
244 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
247 (allocate_pseudovector):
248 Use int, not EMACS_INT, where int is wide enough.
249 (inhibit_garbage_collection, Fgarbage_collect):
250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
251 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
252 int might not be wide enough.
253 (bidi_cache_search, bidi_cache_find, bidi_init_it)
254 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
255 (bidi_at_paragraph_end, bidi_find_paragraph_start)
256 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
257 (bidi_level_of_next_char, bidi_move_to_visually_next):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
260 (Fkill_buffer, Fset_buffer_major_mode)
261 (advance_to_char_boundary, Fbuffer_swap_text)
262 (Fset_buffer_multibyte, overlays_at, overlays_in)
263 (overlay_touches_p, struct sortvec, record_overlay_string)
264 (overlay_strings, recenter_overlay_lists)
265 (adjust_overlays_for_insert, adjust_overlays_for_delete)
266 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
267 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
268 (Foverlay_recenter, last_overlay_modification_hooks_used)
269 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
271 (validate_region): Omit unnecessary test for b <= e,
272 since that's guaranteed by the previous test.
273 (adjust_overlays_for_delete): Avoid pos + length overflow.
274 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
275 (report_overlay_modification):
276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
277 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
278 Omit pointer cast, which isn't needed anyway, and doesn't work
279 after the EMACS_INT -> ptrdiff_t change.
280 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
281 * buffer.h: Adjust decls to match defn changes elsewhere.
282 (struct buffer_text, struct buffer):
283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
284 Use EMACS_INT, not int, where int might not be wide enough.
285 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
286 not int, to avoid needless 32-bit limit on 64-bit hosts.
287 (exec_byte_code): Use tighter memory-full test, one that checks
288 for alloca overflow. Don't compute the address of the object just
289 before an array, as that's not portable. Use EMACS_INT, not
290 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
291 * callint.c (Fcall_interactively):
292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
293 * callproc.c (call_process_kill, Fcall_process):
294 Don't assume pid_t fits into an Emacs fixnum.
295 (call_process_cleanup, Fcall_process, child_setup):
296 Don't assume pid_t fits into int.
297 (call_process_cleanup, Fcall_process, delete_temp_file)
298 (Fcall_process_region):
299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
300 (Fcall_process): Simplify handling of volatile integers.
301 Use int, not EMACS_INT, where int will do.
302 * casefiddle.c (casify_object, casify_region, operate_on_word)
303 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
305 (casify_object): Avoid integer overflow when overallocating buffer.
306 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
307 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
308 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
309 * category.h (CATEGORYP): Don't assume arg is nonnegative.
310 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
311 integers are now checked earlier. All uses replaced with XINT.
313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
314 For CCL_MapSingle, check that content and value are in int range.
315 (ccl_driver, Fregister_code_conversion_map):
316 Check that Vcode_version_map_vector is a vector.
317 (resolve_symbol_ccl_program): Check that vector header is in range.
318 Always copy the vector, so that we can check its contents reliably
319 now rather than having to recheck each instruction as it's being
320 executed. Check that vector words fit in 'int'.
321 (ccl_get_compiled_code, Fregister_ccl_program)
322 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
323 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
324 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
325 contents are in range.
326 (Fccl_execute_on_string): Check that status is in range.
327 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
328 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
329 Accept and return EMACS_INT, not int, because callers can pass values
331 (c_string_width, strwidth, lisp_string_width, chars_in_text)
332 (multibyte_chars_in_text, parse_str_as_multibyte)
333 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
334 (str_as_unibyte, str_to_unibyte, string_count_byte8)
335 (string_escape_byte8, Fget_byte):
336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
337 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
338 avoid mishandling large integers.
339 * character.h: Adjust decls to match defn changes elsewhere.
340 * charset.c (load_charset_map_from_file, find_charsets_in_text)
341 (Ffind_charset_region):
342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
343 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
344 (load_charset_map_from_vector, Fdefine_charset_internal):
345 Don't assume fixnum fits in int.
346 (load_charset_map_from_vector, Fmap_charset_chars):
347 Remove now-unnecessary CHECK_NATNUMs.
348 (Fdefine_charset_internal): Check ranges here, more carefully.
349 Don't rely on undefined behavior with signed left shift overflow.
350 Don't assume unsigned int fits into fixnum, or that fixnum fits
351 into unsigned int. Don't require max_code to be a valid fixnum;
352 that's not true for gb10830 4-byte on a 32-bit host. Allow
353 invalid_code to be a cons, for the same reason. Require code_offset
354 to be a character. Avoid int overflow if max_char is close
356 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
357 this is intended anyway and avoids some undefined behavior.
358 (load_charset_map): Pass unsigned, not int, as 2nd arg of
359 INDEX_TO_CODE_POINT, as that's what it expects.
360 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
361 * charset.h (DECODE_CHAR): Return int, not unsigned;
362 this is what was intended anyway, and it avoids undefined behavior.
363 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
364 integer-overflow issues.
365 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
366 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
367 where the argument is EMACS_INT, and this behavior is not intended.
368 * chartab.c (Fmake_char_table, Fset_char_table_range)
369 (uniprop_get_decoder, uniprop_get_encoder):
370 Don't assume fixnum fits in int.
371 * cmds.c (move_point): New function, that does the gist of
372 Fforward_char and Fbackward_char, but does so while checking
373 for integer overflow more accurately.
374 (Fforward_char, Fbackward_char): Use it.
375 (Fforward_line, Fend_of_line, internal_self_insert)
376 (internal_self_insert):
377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
378 Fix a FIXME, by checking for integer overflow when calculating
379 target_clm and actual_clm.
380 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
381 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
382 (ASSURE_DESTINATION, coding_alloc_by_realloc)
383 (coding_alloc_by_making_gap, alloc_destination)
384 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
385 (encode_coding_utf_16, detect_coding_emacs_mule)
386 (decode_coding_emacs_mule, encode_coding_emacs_mule)
387 (detect_coding_iso_2022, decode_coding_iso_2022)
388 (encode_invocation_designation, encode_designation_at_bol)
389 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
390 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
391 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
392 (encode_coding_ccl, encode_coding_raw_text)
393 (detect_coding_charset, decode_coding_charset)
394 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
395 (produce_composition, produce_charset, produce_annotation)
396 (decode_coding, handle_composition_annotation)
397 (handle_charset_annotation, consume_chars, decode_coding_gap)
398 (decode_coding_object, encode_coding_object, detect_coding_system)
399 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
400 (code_convert_region, code_convert_string)
401 (Fdefine_coding_system_internal)
402 (coding_set_source, coding_set_destination):
403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
404 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
405 (Fdefine_coding_system_internal):
406 Don't assume fixnums fit in int.
407 (decode_coding_gap, decode_coding_object, encode_coding_object)
408 (Fread_coding_system, Fdetect_coding_region)
409 (Funencodable_char_position, Fcheck_coding_systems_region)
410 (get_translation, handle_composition_annotation, consume_chars):
411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
412 (consume_chars): Rewrite to not calculate an address outside buffer.
413 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
414 Don't access memory outside of the args array.
415 (Fdefine_coding_system_internal): Check for charset-id overflow.
416 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
417 result of ENCODE_CHAR.
418 * coding.h: Adjust decls to match defn changes elsewhere.
419 (struct coding_system):
420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
421 * composite.c (get_composition_id, find_composition)
422 (run_composition_function, update_compositions)
423 (compose_text, composition_gstring_put_cache)
424 (composition_gstring_p, composition_gstring_width)
425 (fill_gstring_header, fill_gstring_body, autocmp_chars)
426 (composition_compute_stop_pos, composition_reseat_it)
427 (composition_update_it, struct position_record)
428 (find_automatic_composition, composition_adjust_point)
429 (Fcomposition_get_gstring, Ffind_composition_internal):
430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
431 (update_compositions):
432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
433 * composite.h: Adjust decls to match defn changes elsewhere.
434 (struct composition):
435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
436 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
437 Do not attempt to compute the address of the object just before a
438 buffer; this is not portable.
440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
441 (Faset): Use int, not EMACS_INT, where int is wide enough.
442 (Fstring_to_number): Don't assume fixnums fit in int.
443 (Frem): Don't assume arg is nonnegative.
444 * dbusbind.c (xd_append_arg): Check for integers out of range.
445 (Fdbus_call_method): Don't overflow the timeout int.
446 (extract_signed, extract_unsigned): New functions.
447 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
448 (xd_get_connection_references): Return ptrdiff_t, not int.
450 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
452 Use int, not unsigned, where the dbus API uses int.
453 (Fdbus_message_internal): Don't overflow mtype.
454 (syms_of_dbusbind): Allocate right-sized buffer for integers.
455 * dired.c (directory_files_internal, file_name_completion, scmp)
456 (file_name_completion_stat):
457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
458 (file_name_completion): Don't overflow matchcount.
459 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
460 * dispextern.h: Adjust decls to match defn changes elsewhere.
461 (struct text_pos, struct glyph, struct bidi_saved_info)
462 (struct bidi_string_data, struct bidi_it, struct composition_it)
464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
465 (struct display_pos, struct composition_it, struct it):
466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
467 * dispnew.c (increment_matrix_positions)
468 (increment_row_positions, mode_line_string)
469 (marginal_area_string):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
473 (duration_to_sec_usec): New function, to check for overflow better.
474 (Fsleep_for, sit_for): Use it.
475 * doc.c (get_doc_string, store_function_docstring):
476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
477 (get_doc_string, Fsnarf_documentation):
478 Use int, not EMACS_INT, where int is wide enough.
480 Use SAFE_ALLOCA, not alloca.
481 Check for overflow when converting EMACS_INT to off_t.
483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
484 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
485 Don't assume uid_t fits into fixnum.
486 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
487 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
488 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
489 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
490 (general_insert_function)
491 (Finsert_char, make_buffer_string, make_buffer_string_both)
492 (update_buffer_properties, Fbuffer_substring)
493 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
494 (Fsubst_char_in_region, check_translation)
495 (Ftranslate_region_internal, save_restriction_restore, Fformat)
496 (transpose_markers, Ftranspose_regions):
497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
498 (clip_to_bounds): Move to lisp.h as an inline function).
499 (Fconstrain_to_field): Don't assume integers are nonnegative.
500 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
501 (Fsubst_char_in_region, Fsave_restriction):
502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
503 (Femacs_pid): Don't assume pid_t fits into fixnum.
504 (lo_time): Use int, not EMACS_INT, when int suffices.
505 (lisp_time_argument): Check for usec out of range.
506 (Fencode_time): Don't assume fixnum fits in int.
507 (Fuser_login_name, Fuser_full_name): Signal an error
508 if a uid argument is out of range, rather than relying on
510 (Fformat_time_string): Remove now-unnecessary check.
511 lisp_time_argument checks for out-of-range usec now.
512 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
513 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
514 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
515 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
516 (init_cmdargs, Fdump_emacs):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
519 the bottom (typically) 32 bits of the fixnum.
520 * eval.c (specpdl_size, call_debugger):
521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
522 (when_entered_debugger, Fbacktrace_debug):
523 Don't assume fixnum can fit in int.
524 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
525 the object just before a buffer; this is not portable.
526 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
527 (grow_specpdl, unbind_to):
528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
529 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
530 (grow_specpdl): Simplify allocation by using xpalloc.
531 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
532 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
533 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
538 (Fcopy_file, non_regular_nbytes, read_non_regular)
539 (Finsert_file_contents):
540 Use int, not EMACS_INT, where int is wide enough.
541 (READ_BUF_SIZE): Verify that it fits in int.
542 (Finsert_file_contents): Check that counts are in proper range,
543 rather than assuming fixnums fit into ptrdiff_t etc.
544 Don't assume fixnums fit into int.
545 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
546 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
547 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
548 (string_char_to_byte, string_byte_to_char)
549 (string_make_multibyte, string_to_multibyte)
550 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
551 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
552 (substring_both, Fdelete, internal_equal, Ffillarray)
553 (Fclear_string, mapcar1)
554 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
555 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
556 (larger_vector, make_hash_table, maybe_resize_hash_table)
557 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
558 (Fmaphash, secure_hash):
559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
560 (concat): Check for string index and length overflow.
561 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
564 (larger_vector): New API (vec, incr_min, size_max) replaces old
565 one (vec, new_size, init). This catches size overflow.
566 INIT was removed because it was always Qnil.
568 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
569 the upper bound on a hash table index size.
570 (make_hash_table, maybe_resize_hash_table): Use it.
571 (secure_hash): Computer start_byte and end_byte only after
572 they're known to be in ptrdiff_t range.
573 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
574 (Ffont_get_glyphs, Ffont_at):
575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
576 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
577 (Flist_fonts, Fopen_font):
578 Don't assume fixnum can fit in int.
579 (check_gstring): Don't assume index can fit in int.
580 (font_match_p): Check that fixnum is a character, not a nonnegative
581 fixnum, since the later code needs to stuff it into an int.
582 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
583 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
584 conversion overflow issues.
585 (Fopen_font): Check for integer out of range.
586 (Ffont_get_glyphs): Don't assume index can fit in int.
587 * font.h: Adjust decls to match defn changes elsewhere.
588 * fontset.c (reorder_font_vector): Redo score calculation to avoid
590 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
591 printmax_t, where ptrdiff_t is wide enough.
592 (Finternal_char_font):
593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
594 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
595 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
596 (Fset_frame_position, x_set_frame_parameters)
597 (x_set_line_spacing, x_set_border_width)
598 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
599 Check that fixnums are in proper range for system types.
600 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
602 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
603 Use SAFE_ALLOCA_LISP, not alloca.
604 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
605 intptr_t is wide enough.
606 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
607 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
608 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
609 Check for fixnum out of range.
610 * ftfont.c (ftfont_list): Don't assume index fits in int.
611 Check that fixnums are in proper range for system types.
612 (ftfont_shape_by_flt):
613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
614 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
616 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
617 Check that fixnums are in proper range for system types.
618 * gnutls.h: Adjust decls to match defn changes elsewhere.
619 * gtkutil.c (xg_dialog_run):
620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
621 (update_frame_tool_bar):
622 Check that fixnums are in proper range for system types.
623 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
624 (lookup_image): Check that fixnums are in range for system types.
625 * indent.c (last_known_column, last_known_column_point):
626 (current_column_bol_cache):
627 (skip_invisible, current_column, check_display_width):
628 (check_display_width, scan_for_column, current_column_1)
629 (Findent_to, Fcurrent_indentation, position_indentation)
630 (indented_beyond_p, Fmove_to_column, compute_motion):
631 (Fcompute_motion, Fvertical_motion):
632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
633 (last_known_column_modified): Use EMACS_INT, not int.
634 (check_display_width):
636 Check that fixnums and floats are in proper range for system types.
637 (compute_motion): Don't assume index or fixnum fits in int.
638 (compute_motion, Fcompute_motion):
639 Use int, not EMACS_INT, when it is wide enough.
640 (vmotion): Omit local var start_hpos that is always 0; that way
641 we don't need to worry about overflow in expressions involving it.
642 * indent.h: Adjust decls to match defn changes elsewhere.
644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
645 Use int, not EMACS_INT, where int is wide enough.
646 Remove unused members ovstring_chars_done and tab_offset;
648 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
649 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
650 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
651 (make_gap, copy_text, insert, insert_and_inherit)
652 (insert_before_markers, insert_before_markers_and_inherit)
653 (insert_1, count_combining_before, count_combining_after)
654 (insert_1_both, insert_from_string)
655 (insert_from_string_before_markers, insert_from_string_1)
656 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
657 (adjust_after_replace, adjust_after_insert, replace_range)
658 (replace_range_2, del_range, del_range_1, del_range_byte)
659 (del_range_both, del_range_2, modify_region)
660 (prepare_to_modify_buffer, signal_before_change)
661 (signal_after_change, Fcombine_after_change_execute):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 * intervals.c (traverse_intervals, rotate_right, rotate_left)
664 (balance_an_interval, split_interval_right, split_interval_left)
665 (find_interval, next_interval, update_interval)
666 (adjust_intervals_for_insertion, delete_node, delete_interval)
667 (interval_deletion_adjustment, adjust_intervals_for_deletion)
668 (static_offset_intervals, offset_intervals)
669 (merge_interval_right, merge_interval_left, make_new_interval)
670 (graft_intervals_into_buffer, temp_set_point_both)
671 (temp_set_point, set_point, adjust_for_invis_intang)
672 (set_point_both, move_if_not_intangible, get_property_and_range)
673 (get_local_map, copy_intervals, copy_intervals_to_string)
674 (compare_string_intervals, set_intervals_multibyte_1):
675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
676 * intervals.h: Adjust decls to match defn changes elsewhere.
678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
679 * keyboard.c (this_command_key_count, this_single_command_key_start)
680 (before_command_key_count, before_command_echo_length, echo_now)
681 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
682 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
683 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
684 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
686 (last_non_minibuf_size, last_point_position, echo_truncate)
687 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
688 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
689 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
690 (stuff_buffered_input):
691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
692 (last_auto_save, command_loop_1, read_char):
693 Use EMACS_INT, not int, to avoid integer overflow.
694 (record_char): Avoid overflow in total_keys computation.
695 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
696 * keyboard.h: Adjust decls to match defn changes elsewhere.
697 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
698 (Fkey_description, Fdescribe_vector, Flookup_key):
699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
700 (click_position): New function, to check that positions are in range.
701 (Fcurrent_active_maps):
703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
704 (Faccessible_keymaps, Fkey_description):
705 (preferred_sequence_p):
706 Don't assume fixnum can fit into int.
707 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
708 Check for integer overflow in size calculations.
709 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
710 avoid mishandling large integers.
711 * lisp.h: Adjust decls to match defn changes elsewhere.
712 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
713 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
714 (struct Lisp_Marker):
715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
716 (clip_to_bounds): Now an inline function, moved here from editfns.c.
717 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
718 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
720 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
721 Assume the arg has valid form, since it always does.
722 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
723 unsigned integer system type.
724 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
725 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
727 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
728 (duration_to_sec_usec): New decl.
729 * lread.c (read_from_string_index, read_from_string_index_byte)
730 (read_from_string_limit, readchar, unreadchar, openp)
731 (read_internal_start, read1, oblookup):
732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
733 (Fload, readevalloop, Feval_buffer, Feval_region):
734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
735 (openp): Check for out-of-range argument to 'access'.
736 (read1): Use int, not EMACS_INT, where int is wide enough.
737 Don't assume fixnum fits into int.
738 Fix off-by-one error that can read outside a buffer.
739 (read_filtered_event): Use duration_to_sec_usec
740 to do proper overflow checking on durations.
741 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
743 (Fexecute_kbd_macro):
744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
745 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
746 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
747 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
748 (set_marker_both, set_marker_restricted_both, marker_position)
749 (marker_byte_position, Fbuffer_has_markers_at):
750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
751 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
752 * menu.c (ensure_menu_items): Rename from grow_menu_items.
753 It now merely ensures that the menu is large enough, without
754 necessarily growing it, as this avoids some integer overflow issues.
756 (keymap_panes, parse_single_submenu, Fx_popup_menu):
757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
758 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
759 Use SAFE_ALLOCA_LISP, not alloca.
760 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
761 to EMACS_INT. Check that fixnums are in proper range for system types.
762 * minibuf.c (minibuf_prompt_width, string_to_object)
763 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
764 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
766 (get_minibuffer, read_minibuf_unwind):
767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
768 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
769 this simplifies overflow checking. All callers changed.
770 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
772 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
773 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
774 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
775 Check that fixnums are in proper range for system types.
776 (Fx_create_frame, Fx_show_tip):
777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
778 * nsfont.m (ns_findfonts, nsfont_list_family):
779 Don't assume fixnum fits in long.
780 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
782 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
784 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
786 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
787 (PRINTDECLARE, PRINTPREPARE):
788 (strout, print_string):
789 (print, print_preprocess, print_check_string_charset_prop)
791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
793 (temp_output_buffer_setup, Fprin1_to_string, print_object):
794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
795 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
796 (printchar, strout): Use xpalloc to catch size calculation overflow.
797 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
798 (print_error_message): Use SAFE_ALLOCA, not alloca.
799 (print_object): Use int, not EMACS_INT, where int is wide enough.
800 (print_depth, new_backquote_output, print_number_index):
801 Use ptrdiff_t, not int, where int might not be wide enough.
802 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
803 (Fset_process_window_size, Fformat_network_address)
804 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
806 Check that fixnums are in proper range for system types.
807 (Fsignal_process): Simplify by avoiding a goto.
808 Check for process-ids out of pid_t range rather than relying on
810 (process_tick, update_tick): Use EMACS_INT, not int.
811 (Fformat_network_address, read_process_output, send_process)
812 (Fprocess_send_region, status_notify):
813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
814 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
815 (wait_reading_process_output, read_process_output, exec_sentinel):
816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
817 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
818 (Faccept_process_output): Use duration_to_sec_usec to do proper
819 overflow checking on durations.
820 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
821 Don't assume pid_t fits in int.
822 * process.h (struct Lisp_Process): Members tick and update_tick
823 are now of type EMACS_INT, not int.
824 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
825 configured --with-wide-int.
826 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
827 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
828 * search.c (looking_at_1, string_match_1):
829 (fast_string_match, fast_c_string_match_ignore_case)
830 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
831 (scan_newline, find_before_next_newline, search_command)
832 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
833 (set_search_regs, wordify):
836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
837 (string_match_1, search_buffer, set_search_regs):
839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
840 (wordify): Check for overflow in size calculation.
841 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
842 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
843 Check that fixnums are in proper range for system types.
844 * sound.c (struct sound_device)
845 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
847 (Fplay_sound_internal):
848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
849 * syntax.c (struct lisp_parse_state, find_start_modiff)
850 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
851 (Fparse_partial_sexp):
852 Don't assume fixnums can fit in int.
853 (struct lisp_parse_state, find_start_pos, find_start_value)
854 (find_start_value_byte, find_start_begv)
855 (update_syntax_table, char_quoted, dec_bytepos)
856 (find_defun_start, prev_char_comend_first, back_comment):
857 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
858 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
860 (Finternal_describe_syntax_value): Check that match_lisp is a
861 character, not an integer, since the code stuffs it into int.
862 (scan_words, scan_sexps_forward):
863 Check that fixnums are in proper range for system types.
865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
866 (scan_sexps_forward):
867 Use CHARACTERP, not INTEGERP, since the value must fit into int.
868 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
869 * syntax.h: Adjust decls to match defn changes elsewhere.
871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
872 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
873 MOST_POSITIVE_FIXNUM.
874 * sysdep.c (wait_for_termination_1, wait_for_termination)
875 (interruptible_wait_for_termination, mkdir):
876 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
877 (emacs_read, emacs_write):
878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
879 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
880 and double all fit in int.
881 * term.c (set_tty_color_mode):
882 Check that fixnums are in proper range for system types.
883 * termhooks.h (struct input_event):
884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
885 * textprop.c (validate_interval_range, interval_of)
886 (Fadd_text_properties, set_text_properties_1)
887 (Fremove_text_properties, Fremove_list_of_text_properties)
888 (Ftext_property_any, Ftext_property_not_all)
889 (copy_text_properties, text_property_list, extend_property_ranges)
890 (verify_interval_modification):
891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
892 (Fnext_single_char_property_change)
893 (Fprevious_single_char_property_change):
894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
895 (copy_text_properties):
896 Check for integer overflow in index calculation.
897 * undo.c (last_boundary_position, record_point, record_insert)
898 (record_delete, record_marker_adjustment, record_change)
899 (record_property_change):
900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
901 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
903 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
904 (Fx_hide_tip, Fx_file_dialog):
905 * w32menu.c (set_frame_menubar):
906 Use ptrdiff_t, not int, for consistency with rest of code.
907 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
908 (select_window, Fdelete_other_windows_internal)
909 (window_scroll_pixel_based, window_scroll_line_based)
910 (Frecenter, Fset_window_configuration):
911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
912 (Fset_window_hscroll, run_window_configuration_change_hook)
913 (set_window_buffer, temp_output_buffer_show, scroll_command)
914 (Fscroll_other_window, Frecenter):
915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
916 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
917 Don't assume fixnum fits in int.
918 (Fset_window_scroll_bars):
919 Check that fixnums are in proper range for system types.
920 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
921 (string_pos, c_string_pos, number_of_chars, init_iterator)
922 (in_ellipses_for_invisible_text_p, init_from_display_pos)
923 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
924 (compute_display_string_end, handle_face_prop)
925 (face_before_or_after_it_pos, handle_invisible_prop)
926 (handle_display_prop, handle_display_spec, handle_single_display_spec)
927 (display_prop_intangible_p, string_buffer_position_lim)
928 (string_buffer_position, handle_composition_prop, load_overlay_strings)
929 (get_overlay_strings_1, get_overlay_strings)
930 (iterate_out_of_display_property, forward_to_next_line_start)
931 (back_to_previous_visible_line_start, reseat, reseat_to_string)
932 (get_next_display_element, set_iterator_to_next)
933 (get_visually_first_element, compute_stop_pos_backwards)
934 (handle_stop_backwards, next_element_from_buffer)
935 (move_it_in_display_line_to, move_it_in_display_line)
936 (move_it_to, move_it_vertically_backward, move_it_by_lines)
937 (add_to_log, message_dolog, message_log_check_duplicate)
938 (message2, message2_nolog, message3, message3_nolog
939 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
940 (current_message_1, truncate_echo_area, truncate_message_1)
941 (set_message, set_message_1, store_mode_line_noprop)
942 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
943 (text_outside_line_unchanged_p, check_point_in_composition)
944 (reconsider_clip_changes)
945 (redisplay_internal, set_cursor_from_row, try_scrolling)
946 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
947 (redisplay_window, find_last_unchanged_at_beg_row)
948 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
949 (trailing_whitespace_p, find_row_edges, display_line)
950 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
951 (display_mode_element, store_mode_line_string)
952 (pint2str, pint2hrstr, decode_mode_spec)
953 (display_count_lines, display_string, draw_glyphs)
954 (x_produce_glyphs, x_insert_glyphs)
955 (rows_from_pos_range, mouse_face_from_buffer_pos)
956 (fast_find_string_pos, mouse_face_from_string_pos)
957 (note_mode_line_or_margin_highlight, note_mouse_highlight):
958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
959 (safe_call, init_from_display_pos, handle_fontified_prop)
960 (handle_single_display_spec, load_overlay_strings)
961 (with_echo_area_buffer, setup_echo_area_for_printing)
962 (display_echo_area, echo_area_display)
963 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
964 (update_tool_bar, hscroll_window_tree, redisplay_internal)
965 (redisplay_window, dump_glyph_row, display_mode_line)
966 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
967 (handle_display_spec, display_prop_string_p):
968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
969 (handle_single_display_spec, build_desired_tool_bar_string)
970 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
971 (get_specified_cursor_type):
972 Check that fixnums are in proper range for system types.
973 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
975 Don't assume fixnums fit in int.
976 (compare_overlay_entries):
977 Avoid mishandling comparisons due to subtraction overflow.
978 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
979 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
980 (handle_tool_bar_click):
981 Use int, not unsigned, since we prefer signed and the signedness
983 (get_next_display_element, next_element_from_display_vector):
984 Use int, not EMACS_INT, when int is wide enough.
985 (start_hourglass): Use duration_to_sec_usec to do proper
986 overflow checking on durations.
987 * xfaces.c (Fbitmap_spec_p):
988 Check that fixnums are in proper range for system types.
989 (compare_fonts_by_sort_order):
990 Avoid mishandling comparisons due to subtraction overflow.
991 (Fx_family_fonts, realize_basic_faces):
992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
994 Don't assume fixnum fits in int.
995 Use SAFE_ALLOCA_LISP, not alloca.
996 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
997 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
998 (face_at_buffer_position, face_for_overlay_string)
999 (face_at_string_position):
1000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1001 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1002 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1004 Check that fixnums are in proper range for system types.
1005 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1006 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1008 (Fx_change_window_property): Don't assume fixnums fit in int.
1009 * xfont.c (xfont_chars_supported):
1010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1011 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1012 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1014 * xml.c (parse_region):
1015 * xrdb.c (magic_file_p):
1016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1017 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1018 (x_get_local_selection, x_reply_selection_request)
1019 (x_handle_selection_request, wait_for_property_change):
1020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1021 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1022 short is wide enough.
1023 (x_send_client_event): Don't assume fixnum fits in int.
1024 * xterm.c (x_x_to_emacs_modifiers):
1025 Don't assume EMACS_INT overflows nicely into int.
1026 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1028 (handle_one_xevent): NATNUMP can eval its arg twice.
1029 (x_connection_closed):
1030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1031 * xterm.h: Adjust decls to match defn changes elsewhere.
1032 (struct scroll_bar): Use struct vectorlike_header
1033 rather than rolling our own approximation.
1034 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1036 2012-05-25 Glenn Morris <rgm@gnu.org>
1038 * lisp.mk (lisp): Update for more files being compiled now.
1040 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1042 * lread.c: Remove `read_pure' which makes no difference.
1043 (read_pure): Remove var.
1044 (unreadpure): Remove function.
1045 (readevalloop): Don't call read_list with -1 flag.
1046 (read1, read_vector): Don't test read_pure any more.
1047 (read_list): Simplify.
1049 * fileio.c, character.h: Minor style tweaks.
1051 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1053 * window.h (clip_changed): Remove useless declaration.
1055 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1057 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1058 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1060 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1063 This directory predates autoconf and is no longer needed nowadays.
1064 Move its few remaining bits of functionality to where they're needed.
1065 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1066 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1067 * m/template.h: Remove.
1068 * Makefile.in (M_FILE): Remove. All uses removed.
1069 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1070 * lisp.h (USE_LSB_TAG):
1071 * mem-limits.h (EXCEEDS_LISP_PTR):
1072 Use VAL_MAX, not VALBITS, in #if.
1073 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1074 (EMACS_UINT): Define unconditionally now.
1075 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1076 (BITS_PER_EMACS_INT): New constants, replacing
1077 what used to be in config.h, but not useful in #if.
1078 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1079 define them any more.
1080 (VAL_MAX): New macro.
1082 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1083 BITS_PER_EMACS_INT, in #if.
1084 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1085 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1086 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1087 * s/ms-w32.h (DATA_START):
1088 Move here from removed file m/intel386.h.
1089 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1090 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1092 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1094 Assume C89 or later.
1095 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1096 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1098 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1099 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1100 * textprop.c, tparam.c (NULL): Remove.
1101 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1102 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1103 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1104 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1105 * xterm.c (input_signal_count): Assume volatile works.
1107 2012-05-21 Ken Brown <kbrown@cornell.edu>
1109 * xgselect.c (xg_select): Fix first argument in call to 'select'
1112 2012-05-20 Ken Brown <kbrown@cornell.edu>
1114 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1115 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1117 2012-05-19 Ken Brown <kbrown@cornell.edu>
1119 * xfns.c (x_in_use): Remove `static' qualifier.
1120 * xterm.h (x_in_use): Declare.
1121 * xgselect.c: Include xterm.h.
1122 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1123 and `display_arg' (bug#9754).
1125 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1127 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1129 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1130 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1132 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1134 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1136 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1137 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1139 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1140 reference to image_cache->refcount.
1141 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1143 2012-05-17 Juri Linkov <juri@jurta.org>
1145 * search.c (Fword_search_regexp, Fword_search_backward)
1146 (Fword_search_forward, Fword_search_backward_lax)
1147 (Fword_search_forward_lax): Move functions to isearch.el
1148 (bug#10145, bug#11381).
1150 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1152 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1154 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1156 * lread.c (init_obarray): Declare Qt and Qnil as special.
1158 2012-05-14 Glenn Morris <rgm@gnu.org>
1160 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1161 Put "libexec" before "bin", for the sake of init_callproc_1.
1163 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1165 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1167 * unexaix.c: Port to more-recent AIX compilers.
1168 (report_error, report_error_1, make_hdr, copy_sym)
1169 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1170 Make arguments const char *, not char *, to avoid violations of C
1171 standard and to fix some AIX warnings reported by Gilles Pion.
1173 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1175 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1176 already have overlays loaded.
1177 (handle_single_display_spec): Before returning without displaying
1178 fringe bitmap, synchronize the bidi iterator with the main display
1179 iterator, by calling iterate_out_of_display_property.
1180 (iterate_out_of_display_property): Detect buffer iteration by
1181 testing that it->string is a Lisp string.
1182 (get_next_display_element): When the current object is exhausted,
1183 and there's something on it->stack, call set_iterator_to_next to
1184 proceed with what's on the stack, instead of returning zero.
1185 (set_iterator_to_next): If called at the end of a Lisp string,
1186 proceed to consider_string_end without incrementing string
1187 position. Don't increment display vector index past the end of
1188 the display vector. (Bug#11417)
1189 (pos_visible_p): Don't report a position visible when move_it_to
1190 stopped at the last line of window, which happens to be scanned
1191 backwards by the bidi iteration. (Bug#11464)
1193 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1195 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1196 and right-margin display specs even if the spec is invalid or we
1197 are on a TTY, and thus unable to display on the fringes.
1198 That's because the text with the property will not be displayed anyway,
1199 so we need to signal to the caller that this is a "replacing"
1200 display spec. This fixes display when the spec is invalid or we
1203 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1205 * unexaix.c (make_hdr): Fix typo in prototype.
1206 This bug broke the build on AIX. Problem reported by Gilles Pion.
1208 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1210 * keyboard.c (kbd_buffer_get_event): Read special events also in
1211 batch mode. (Bug#11415)
1213 2012-05-12 Glenn Morris <rgm@gnu.org>
1215 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1217 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1219 * lisp.mk (lisp): Add newcomment.elc.
1221 2012-05-12 Glenn Morris <rgm@gnu.org>
1223 * Makefile.in (MKDIR_P): New, set by configure.
1224 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1226 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1228 Remove unused function hourglass_started.
1229 * dispextern.h (hourglass_started):
1230 * w32fns.c (hourglass_started):
1231 * xdisp.c (hourglass_started): Remove.
1233 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1235 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1236 Update dependencies.
1238 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1240 * xgselect.c (xg_select): Put maxfds+1 into a var.
1241 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1243 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1245 2012-05-10 Dave Abrahams <dave@boostpro.com>
1247 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1248 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1250 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1252 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1253 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1254 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1255 Initialize xd_registered_buses.
1257 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1259 Untag more efficiently if USE_LSB_TAG.
1260 This is based on a proposal by YAMAMOTO Mitsuharu in
1261 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1262 For an admittedly artificial (nth 8000 longlist) benchmark on
1263 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1264 Emacs's overall text size by 1%.
1265 * lisp.h (XUNTAG): New macro.
1266 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1267 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1268 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1269 * eval.c (Fautoload):
1270 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1271 * frame.h (XFRAME): Use XUNTAG.
1273 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1274 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1275 Remove unportable assumptions about print widths of types like
1277 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1278 intptr_t when converting between pointer and integer, to avoid GCC
1279 warnings about wrong width.
1281 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1283 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1284 stack for each reader_thread, instead of defaulting to 8MB
1285 determined by the linker. This avoids failures in creating
1286 subprocesses on Windows 7, see the discussion in this thread:
1287 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1289 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1291 Fix up display of the *Minibuf-0* buffer in the mini window.
1292 * keyboard.c (read_char): Don't clear the echo area if there's no
1294 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1295 contents of *Minibuf-0*) if there's no message displayed in its stead.
1297 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1299 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1302 2012-05-06 Chong Yidong <cyd@gnu.org>
1304 * lisp.mk (lisp): Update.
1306 2012-05-05 Jim Meyering <meyering@redhat.com>
1308 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1310 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1312 * data.c (PUT_ERROR): New macro.
1313 (syms_of_data): Use it. Add new error type `user-error'.
1314 * undo.c (user_error): New function.
1315 (Fprimitive_undo): Use it.
1316 * print.c (print_error_message): Adjust print style for `user-error'.
1317 * keyboard.c (user_error): New function.
1318 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1320 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1322 Do not limit current-time-string to years 1000..9999.
1323 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1324 (Fcurrent_time_string): Support any year that is supported by the
1325 underlying localtime representation. Don't use asctime, as it
1326 has undefined behavior for years outside the range -999..9999.
1328 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1330 Fix race conditions involving setenv, gmtime, localtime, asctime.
1331 Without this fix, interrupts could mess up code that uses these
1332 nonreentrant functions, since setting TZ invalidates existing
1333 tm_zone or tzname values, and since most of these functions return
1334 pointers to static storage.
1335 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1336 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1337 Grow the critical sections to include not just invoking
1338 localtime/gmtime, but also accessing these functions' results
1339 including their tm_zone values if any, and any related TZ setting.
1340 (format_time_string): Last arg is now struct tm *, not struct tm **,
1341 so that the struct tm is saved in the critical section.
1342 All callers changed. Simplify allocation of initial buffer, partly
1343 motivated by the fact that memory allocation needs to be outside
1344 the critical section.
1346 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1348 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1349 with RESET_INTERVAL.
1351 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1352 Remove duplicated buffer name initialization.
1354 2012-05-02 Jim Meyering <jim@meyering.net>
1356 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1358 * xfns.c (x_window): Use xstrdup (Bug#11375).
1360 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1362 * xdisp.c (pos_visible_p): If already at a newline from the
1363 display string before the 'while' loop, don't walk back the glyphs
1364 from it3.glyph_row. Solves assertion violation when the display
1365 string begins with a newline (egg.el). (Bug#11367)
1367 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1369 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1372 2012-05-01 Glenn Morris <rgm@gnu.org>
1374 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1375 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1376 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1377 All were removed before 23.1.
1379 * dispnew.c: Remove HAVE_LIBNCURSES test;
1380 it is always true on relevant platforms.
1382 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1383 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1385 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1387 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1389 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1390 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1393 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1395 Do not avoid creating empty evaporating overlays (Bug#9642).
1396 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1397 That is, do not delete an evaporating overlay if it becomes
1398 empty after its bounds are adjusted to fit within its buffer.
1399 This fix caused other problems, and I'm reverting it until we get
1400 to the bottom of them.
1402 2012-04-27 Chong Yidong <cyd@gnu.org>
1404 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1406 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1408 * xdisp.c (pos_visible_p): If the window start position is beyond
1409 ZV, start the display from buffer beginning. Prevents assertion
1410 violation in init_iterator when the minibuffer window is scrolled
1413 * window.c (window_scroll_pixel_based): Likewise.
1415 2012-04-27 Chong Yidong <cyd@gnu.org>
1417 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1419 2012-04-27 Glenn Morris <rgm@gnu.org>
1421 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1422 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1424 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1426 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1427 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1429 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1431 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1432 display element, check also the underlying string or buffer
1433 character. (Bug#11341)
1435 * w32menu.c: Include w32heap.h.
1436 (add_menu_item): If the call to AppendMenuW (via
1437 unicode_append_menu) fails, disable Unicode menus only if we are
1438 running on Windows 9X/Me.
1440 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1442 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1443 (xgetint): Add missing shift for LSB tags.
1445 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1447 * keyboard.c (read_char): Don't wipe echo area for select window
1448 events: These might get delayed via `mouse-autoselect-window'
1451 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1453 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1454 manipulation of :loaded-from data.
1456 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1458 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1459 now a cons (bug#11311).
1461 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1463 Do not create empty overlays with the evaporate property (Bug#9642).
1464 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1465 if it becomes empty after its bounds are adjusted to fit within
1466 its buffer. Without this fix, in a nonempty buffer (let ((o
1467 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1468 yields an empty overlay that has the evaporate property, which is
1469 not supposed to happen.
1471 Fix minor GTK3 problems found by static checking.
1472 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1473 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1474 (struct _EmacsFixedClass, emacs_fixed_get_type):
1475 Move decls here from emacsgtkfixed.h, since they needn't be public.
1476 (emacs_fixed_get_type): Now static.
1477 (emacs_fixed_class_init): Omit unused local.
1478 (emacs_fixed_child_type): Remove; unused.
1479 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1480 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1481 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1482 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1483 (EMACS_FIXED_GET_CLASS): Remove; unused.
1484 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1486 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1487 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1489 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1491 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1492 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1493 (__malloc_size_t, __malloc_ptrdiff_t):
1494 Remove. All uses removed, replaced by the definiens if needed,
1495 since we can assume C89 or better now.
1496 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1497 (protect_malloc_state, align, get_contiguous_space)
1498 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1499 (malloc_atfork_handler_child, malloc_enable_thread)
1500 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1501 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1502 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1503 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1504 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1505 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1506 Define using prototypes, not old style.
1507 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1508 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1509 (align): Don't assume that signed integer overflow wraps around.
1510 Omit unused local var.
1511 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1512 (_free_internal_nolock, memalign, mallochook, reallochook):
1513 Omit no-longer-needed casts.
1514 (valloc): Use getpagesize, not __getpagesize.
1515 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1516 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1518 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1520 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1522 Move functions from C to Lisp. Make non-blocking method calls
1523 the default. Implement further D-Bus standard interfaces.
1525 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1526 (QCdbus_request_name_allow_replacement)
1527 (QCdbus_request_name_replace_existing)
1528 (QCdbus_request_name_do_not_queue)
1529 (QCdbus_request_name_reply_primary_owner)
1530 (QCdbus_request_name_reply_in_queue)
1531 (QCdbus_request_name_reply_exists)
1532 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1533 (QCdbus_registered_serial, QCdbus_registered_method)
1534 (QCdbus_registered_signal): New Lisp objects.
1535 (XD_DEBUG_MESSAGE): Use sizeof.
1536 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1537 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1538 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1539 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1540 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1541 (xd_signature, xd_append_arg): Allow float for integer types.
1542 (xd_get_connection_references): New function.
1543 (xd_get_connection_address): Rename from xd_initialize.
1544 Return cached address.
1545 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1546 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1548 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1549 Return number of refcounts.
1550 (Fdbus_get_unique_name): Make stronger parameter check.
1551 (Fdbus_message_internal): New defun.
1552 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1553 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1554 (Fdbus_send_signal, Fdbus_register_service)
1555 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1556 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1557 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1558 (Vdbus_compiled_version, Vdbus_runtime_version)
1559 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1560 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1561 (Vdbus_message_type_signal): New defvars.
1562 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1565 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1567 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1568 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1569 Do not assume ptrdiff_t is the same width as 'int'.
1571 * alloc.c: Handle unusual debugging option combinations.
1572 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1573 since the two debugging options are incompatible.
1574 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1576 (mem_init, mem_insert, mem_insert_fixup):
1577 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1578 (NEED_MEM_INSERT): Remove; no longer needed.
1580 2012-04-22 Leo Liu <sdl.web@gmail.com>
1582 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1584 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1586 * sysdep.c [__FreeBSD__]: Minor cleanups.
1587 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1588 Use Emacs indenting style more consistently. Avoid some casts.
1589 Use 'double' consistently rather than mixing 'float' and 'double'.
1591 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1593 * sysdep.c (list_system_processes, system_process_attributes):
1594 Add implementation for FreeBSD (Bug#5243).
1596 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1598 * lisp.mk (lisp): Update.
1600 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1602 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1603 It is never used otherwise.
1605 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1607 * print.c (print_preprocess): Only check print_depth if print-circle
1609 (print_object): Check for cycles even when print-circle is nil and
1610 print-gensym is t, but only check print_depth if print-circle is nil.
1612 2012-04-20 Chong Yidong <cyd@gnu.org>
1614 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1615 set the status to "failed" and ensure that sentinel is run.
1617 2012-04-20 Glenn Morris <rgm@gnu.org>
1619 * process.c (Fset_process_inherit_coding_system_flag)
1620 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1621 (Fmake_network_process, Fmake_serial_process): Doc fix.
1623 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1625 * xdisp.c (string_buffer_position_lim): Limit starting position to
1627 (set_cursor_from_row): If called for a mode-line or header-line
1628 row, return zero immediately.
1629 (try_cursor_movement): If inside continuation line, don't back up
1630 farther than the first row after the header line, if any.
1631 Don't consider the header-line row as "partially visible", even if
1632 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1634 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1636 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1639 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1640 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1642 configure: new option --enable-gcc-warnings (Bug#11207)
1643 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1644 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1645 (ALL_CFLAGS): Use new macros rather than old.
1646 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1647 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1648 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1649 -Wunused-result, -Wunused-variable. This should go away once
1650 the Emacs and Gnulib regex code is merged.
1651 (xmalloc, xrealloc): Now static.
1653 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1655 * dired.c (Fsystem_groups): Remove unused local.
1657 2012-04-17 Glenn Morris <rgm@gnu.org>
1659 * dired.c (Fsystem_users): Doc fix.
1661 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1663 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1664 (syms_of_dired): Add them.
1666 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1668 Fix minor alloc.c problems found by static checking.
1669 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1670 New extern decls, to avoid calling undeclared functions.
1671 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1672 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1673 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1674 (NEED_MEM_INSERT): New macro.
1675 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1676 Remove one incorrect comment and fix another.
1678 Fix minor ralloc.c problems found by static checking.
1679 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1680 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1681 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1682 (r_alloc_sbrk): Now static.
1684 Improve ralloc.c interface checking.
1685 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1686 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1687 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1688 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1689 [REL_ALLOC]: ... to here, to check interface.
1690 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1691 Remove decls. This fixes an "It stinks!".
1693 * alloc.c (which_symbols): Fix alignment issue / type clash.
1695 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1697 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1698 (struct Lisp_Misc_Any): Likewise.
1699 (struct Lisp_Free): Likewise.
1700 * alloc.c (union aligned_Lisp_Symbol): Define.
1701 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1702 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1703 (union aligned_Lisp_Misc): Define.
1704 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1705 aligned_Lisp_Misc instead of union Lisp_Misc.
1706 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1708 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1710 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1711 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1712 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1713 * s/netbsd.h, s/sol2-6.h:
1714 Remove definition of GC_MARK_STACK, since the default now works.
1715 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1716 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1717 no longer the default.
1718 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1720 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1722 * lread.c (lisp_file_lexically_bound_p):
1723 Fix hang at ";-*-\n" (bug#11238).
1725 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1727 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1728 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1730 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1732 * nsterm.m (constrainFrameRect): Always constrain when there is only
1733 one screen (Bug#10962).
1735 2012-04-13 Ken Brown <kbrown@cornell.edu>
1737 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1739 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1741 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1743 2012-04-11 Daniel Colascione <dancol@dancol.org>
1745 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1746 against is gone. It's better to use vfork now so that when Cygwin
1747 gains a new, working vfork, we use it automatically (bug#10398).
1749 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1751 * window.c (save_window_save): Obey window-point-insertion-type.
1753 2012-04-11 Glenn Morris <rgm@gnu.org>
1755 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1757 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1759 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1761 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1763 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1764 (force_quit_count): New var.
1765 (handle_interrupt): Use it.
1767 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1769 * w32.c (w32_delayed_load): Record the full path of the library
1770 being loaded (bug#10424).
1772 2012-04-09 Glenn Morris <rgm@gnu.org>
1774 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1775 not just in the obarray, before snarfing them. (Bug#11036)
1777 * Makefile.in ($(leimdir)/leim-list.el):
1778 Pass EMACS rather than BUILT_EMACS.
1780 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1782 * process.c (make_process):
1783 * process.h: Add integer `gnutls_handshakes_tried' member to
1786 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1787 Add convenience `GNUTLS_LOG2i' macro.
1789 * gnutls.c (gnutls_log_function2i): Convenience log function.
1790 (emacs_gnutls_read): Use new log functions,
1791 `gnutls_handshakes_tried' process member, and
1792 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1793 attempts per process (connection).
1795 2012-04-09 Chong Yidong <cyd@gnu.org>
1797 * eval.c (Fuser_variable_p, user_variable_p_eh)
1798 (lisp_indirect_variable): Functions deleted.
1799 (Fdefvar): Caller changed.
1801 * callint.c (Finteractive, Fcall_interactively):
1802 * minibuf.c (Fread_variable): Callers changed.
1804 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1806 * xdisp.c (set_cursor_from_row): If the display string appears in
1807 the buffer at position that is closer to point than the position
1808 after the display string, display the cursor on the first glyph of
1809 the display string. Fixes cursor display when a 'display' text
1810 property immediately follows invisible text. (Bug#11094)
1812 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1814 composite.c: use 'double' consistently
1815 * composite.c (get_composition_id): Use 'double' consistently
1816 instead of converting 'float' to 'double' and vice versa; this is
1817 easier to understand and avoids a GCC warning.
1819 2012-04-09 Glenn Morris <rgm@gnu.org>
1821 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1822 preparation for dumping it with emacs. (Bug#4789)
1823 (leimdir): New variable.
1824 ($(leimdir)/leim-list.el): New rule.
1825 (emacs$(EXEEXT)): Depend on leim-list.el.
1827 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1828 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1829 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1831 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1833 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1836 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1838 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1839 Remove unused local variable.
1841 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1843 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1844 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1845 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1846 objects, as mark_maybe_pointer will catch them otherwise.
1847 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1848 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1850 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1852 Fix typo that broke non-Windows builds.
1853 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1855 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1857 Support building on MS-Windows with libxml2.
1859 * makefile.w32-in (OBJ2): Add xml.$(O).
1860 (GLOBAL_SOURCES): Add xml.c.
1861 ($(BLD)/xml.$(O)): New dependency list.
1863 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1864 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1865 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1866 [!WINDOWSNT]: New macros.
1867 (init_libxml2_functions, libxml2_loaded_p): New functions.
1868 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1869 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1870 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1871 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1873 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1874 Call init_libxml2_functions before calling libxml2 functions.
1875 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1877 * emacs.c: Don't include libxml/parser.h.
1878 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1879 xmlCleanupParser directly.
1881 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1883 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1885 * indent.c (Fvertical_motion): If there is a display string at
1886 point, use it.vpos to compute how many lines to backtrack after
1887 move_it_to point. (Bug#11133)
1889 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1891 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1892 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1893 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1894 macros related to unification of CJK characters. For the details,
1895 see the discussion following the message here:
1896 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1898 2012-04-04 Chong Yidong <cyd@gnu.org>
1900 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1902 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1904 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1905 instead of alloca. (Bug#11138)
1907 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1909 * w32menu.c (is_simple_dialog): Properly check lisp types.
1912 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1914 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1915 position we get to after a call to move_it_to fails the
1916 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1917 only if we wind up in a string from display property. (Bug#11063)
1919 * window.c (Fdelete_other_windows_internal): Invalidate the row
1920 and column information about mouse highlight, so that redisplay
1921 restores it after reallocating the glyph matrices. (Bug#7464)
1923 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1924 string comes from a `display' text property, use the buffer
1925 position of that property as if we actually saw that position in
1927 (move_it_by_lines): Remove the assertion that
1928 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1929 violated when there's a before-string at the beginning of a line.
1932 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1934 * xdisp.c (append_space_for_newline): If the default face was
1935 remapped, use the remapped face for the appended newline.
1936 (extend_face_to_end_of_line): Use the remapped default face for
1937 extending the face to the end of the line.
1938 (display_line): Call extend_face_to_end_of_line when the default
1939 face was remapped. (Bug#11068)
1941 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1943 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1945 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1947 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1949 2012-03-27 Glenn Morris <rgm@gnu.org>
1951 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1954 2012-03-26 Kenichi Handa <handa@m17n.org>
1956 * dispextern.h (struct glyph): Fix previous change. Change the
1957 bit length of glyphless.ch to 25 (Bug#11082).
1959 2012-03-26 Chong Yidong <cyd@gnu.org>
1961 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1962 (command_loop_1): Use it; inhibit selection update for
1963 handle-select-window too (Bug#8996).
1965 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1967 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1969 2012-03-25 Kenichi Handa <handa@m17n.org>
1971 * dispextern.h (struct glyph): Change the bit length of
1972 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1974 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1976 * s/ms-w32.h (tzname): Include time.h before redirecting to
1977 _tzname. Fixes the MSVC build. (Bug#9960)
1979 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1981 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1984 * xterm.c (XTread_socket): Only modify handling_signal if
1985 !SYNC_INPUT. (Bug#11080)
1987 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1989 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1990 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1991 when fetching a multibyte character consumes more bytes than
1992 CHAR_BYTES returns, due to unification of CJK characters in
1993 string_char. (Bug#11073)
1995 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1997 * process.c (wait_reading_process_output): Handle pty disconnect
1998 by refraining from sending oneself a SIGCHLD (bug#10933).
2000 2012-03-22 Chong Yidong <cyd@gnu.org>
2002 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2004 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2005 Mark string as coming from a prefix property.
2006 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2007 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2009 2012-03-21 Chong Yidong <cyd@gnu.org>
2011 * xfaces.c (Vface_remapping_alist): Doc fix.
2013 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2015 * w32proc.c (Fw32_set_console_codepage)
2016 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2019 2012-03-20 Chong Yidong <cyd@gnu.org>
2021 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2022 to reflect default non-nil value of redisplay-dont-pause.
2024 2012-03-19 Kenichi Handa <handa@m17n.org>
2026 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2027 it fit in a valid range (Bug#11003).
2029 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2031 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2032 that is not from display property, accept the row as a "cursor
2033 row" if one of the string's character has a non-nil `cursor'
2034 property. Fixes cursor positioning when there are newlines in
2035 overlay strings, e.g. in icomplete.el. (Bug#11035)
2037 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2039 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2041 2012-03-12 Chong Yidong <cyd@gnu.org>
2043 * eval.c (inhibit_lisp_code): Rename from
2044 inhibit_window_configuration_change_hook; move from window.c.
2046 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2047 * window.c (run_window_configuration_change_hook)
2048 (syms_of_window): Callers changed.
2050 2012-03-11 Chong Yidong <cyd@gnu.org>
2052 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2054 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2056 2012-03-10 Chong Yidong <cyd@gnu.org>
2058 * frame.c (other_visible_frames): Don't assume the selected frame
2059 is visible (Bug#10955).
2061 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2063 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2065 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2067 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2068 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2071 2012-03-03 Glenn Morris <rgm@gnu.org>
2073 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2075 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2077 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2078 position past the first glyph_row that ends at ZV. (Bug#10902)
2079 (redisplay_window, next_element_from_string): Fix typos in
2081 (redisplay_window): Pass to move_it_vertically the margin in
2082 pixels, not in screen lines.
2084 2012-03-02 Glenn Morris <rgm@gnu.org>
2086 * buffer.c (buffer-list-update-hook): Doc fix.
2088 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2090 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2091 push_it before setting up the iterator for the first overlay
2092 string, even if we have an empty string loaded.
2093 (next_overlay_string): If there's an empty string on the iterator
2094 stack, pop the stack. (Bug#10903)
2096 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2098 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2099 Suggested by Stefan Monnier in
2100 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2101 * alloc.c (widen_to_Lisp_Object): New static function.
2102 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2103 and widening them to Lisp_Objects. This would work even if
2104 USE_LSB_TAG is defined and wide integers are used, which might
2105 happen in a future version of Emacs.
2107 2012-02-25 Chong Yidong <cyd@gnu.org>
2109 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2112 * xselect.c (Fx_selection_exists_p): Doc fix.
2113 (x_clipboard_manager_save_all): Print an informative message
2114 before saving to clipboard manager.
2116 2012-02-24 Chong Yidong <cyd@gnu.org>
2118 * keyboard.c (process_special_events): Handle all X selection
2119 requests in kbd_buffer, not just the next one (Bug#8869).
2121 2012-02-23 Chong Yidong <cyd@gnu.org>
2123 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2124 call when setting menu-bar-lines and tool-bar-lines parameters.
2125 (unwind_create_frame_1): New helper function.
2127 * window.c (inhibit_window_configuration_change_hook): New var.
2128 (run_window_configuration_change_hook): Obey it.
2129 (syms_of_window): Initialize it.
2131 2012-02-22 Chong Yidong <cyd@gnu.org>
2133 * xterm.c (x_draw_image_relief): Add missing type check for
2134 Vtool_bar_button_margin (Bug#10743).
2136 2012-02-21 Chong Yidong <cyd@gnu.org>
2138 * fileio.c (Vfile_name_handler_alist): Doc fix.
2140 * buffer.c (Fget_file_buffer): Protect against invalid file
2141 handler return value.
2143 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2145 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2146 when computing $valmask.
2148 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2149 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2150 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2151 It's useless in that case, and it can cause problems on hosts
2152 that allocate halves of EMACS_INT values separately.
2153 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2154 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2155 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2156 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2157 it avoids undefined behavior on hosts where shifting right by more
2158 than the word width has undefined behavior.
2160 2012-02-19 Chong Yidong <cyd@gnu.org>
2162 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2163 (Funhandled_file_name_directory, Ffile_name_as_directory)
2164 (Fdirectory_file_name, Fexpand_file_name)
2165 (Fsubstitute_in_file_name): Protect against invalid file handler
2166 return values (Bug#10845).
2168 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2170 * .gdbinit (pitx): Fix incorrect references to fields of the
2173 2012-02-17 Chong Yidong <cyd@gnu.org>
2175 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2177 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2179 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2180 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2182 2012-02-15 Chong Yidong <cyd@gnu.org>
2184 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2185 marked as special. Also, starting docstrings with * is obsolete.
2187 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2189 * gnutls.c (emacs_gnutls_write): Fix last change.
2191 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2193 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2196 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2198 * keymap.c (Fsingle_key_description): Handle char ranges.
2200 2012-02-12 Chong Yidong <cyd@gnu.org>
2202 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2203 as that creates a dangerous corner case.
2205 * window.c (Fdelete_window_internal): Invalidate the mouse
2206 highlight (Bug#9904).
2208 2012-02-12 Glenn Morris <rgm@gnu.org>
2210 * xselect.c (Fx_own_selection_internal)
2211 (Fx_get_selection_internal, Fx_disown_selection_internal)
2212 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2213 * nsselect.m (Fx_own_selection_internal)
2214 (Fx_disown_selection_internal, Fx_selection_exists_p)
2215 (Fx_selection_owner_p, Fx_get_selection_internal):
2216 Sync docs and argument specs with the xselect.c versions.
2218 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2220 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2222 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2224 * w32select.c (Fx_selection_exists_p): Sync doc string and
2225 argument list with xselect.c. (Bug#10783)
2227 * w16select.c (Fx_selection_exists_p): Sync doc string and
2228 argument list with xselect.c. (Bug#10783)
2230 2012-02-10 Glenn Morris <rgm@gnu.org>
2232 * fns.c (Fsecure_hash): Doc fix.
2234 2012-02-09 Kenichi Handa <handa@m17n.org>
2236 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2238 2012-02-07 Chong Yidong <cyd@gnu.org>
2240 * buffer.c (Fbuffer_local_variables)
2241 (buffer_lisp_local_variables): Handle unbound vars correctly;
2242 don't let Qunbound leak into Lisp.
2244 2012-02-07 Glenn Morris <rgm@gnu.org>
2246 * image.c (Fimagemagick_types): Doc fix.
2248 * image.c (imagemagick-render-type): Change it from a lisp object
2249 to an integer. Move the doc here from the lisp manual.
2250 Treat all values not equal to 0 the same.
2252 2012-02-06 Chong Yidong <cyd@gnu.org>
2254 * doc.c (store_function_docstring): Avoid applying docstring of
2255 alias to base function (Bug#2603).
2257 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2259 * .gdbinit (pp1, pv1): Remove redundant defines.
2262 2012-02-04 Chong Yidong <cyd@gnu.org>
2264 * nsterm.m: Declare a global (Bug#10694).
2266 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2268 * w32.c (get_emacs_configuration_options):
2269 Include --enable-checking, if specified, in the return value.
2271 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2273 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2274 after rounding frame sizes. (Bug#9723)
2276 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2278 * keyboard.c (adjust_point_for_property): Don't position point
2279 before BEGV. (Bug#10696)
2281 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2283 Handle overflow when computing char display width (Bug#9496).
2284 * character.c (char_width): Return EMACS_INT, not int.
2285 (char_width, c_string_width): Check for overflow when
2286 computing the width; this is possible now that individual
2287 characters can have unbounded width. Problem introduced
2288 by merge from Emacs 23 on 2012-01-19.
2290 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2292 * dbusbind.c (Fdbus_register_method): Mention the return value
2293 :ignore in the docstring.
2295 2012-02-02 Glenn Morris <rgm@gnu.org>
2297 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2299 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2300 Unconditionally set to t. (Bug#10673)
2301 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2302 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2303 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2305 2012-02-02 Kenichi Handa <handa@m17n.org>
2307 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2308 0, do not call append_composite_glyph.
2310 2012-02-02 Kenichi Handa <handa@m17n.org>
2312 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2314 (x_produce_glyphs): If the component of a composition is a null
2315 string, set it->pixel_width to 1 to avoid zero-width glyph.
2317 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2319 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2320 first 2 arguments are identical. This makes inserting large
2321 output from a subprocess an order of magnitude faster on
2322 MS-Windows, where all sbrk'ed memory is always contiguous.
2324 2012-01-31 Glenn Morris <rgm@gnu.org>
2326 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2327 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2328 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2330 2012-01-29 Glenn Morris <rgm@gnu.org>
2332 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2334 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2336 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2338 2012-01-28 Chong Yidong <cyd@gnu.org>
2340 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2342 2012-01-26 Chong Yidong <cyd@gnu.org>
2344 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2346 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2347 repeat counts (Bug#10507).
2349 2012-01-26 Glenn Morris <rgm@gnu.org>
2351 * lread.c (syms_of_lread): Doc fix.
2353 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2355 * coding.c (encode_designation_at_bol): Change return value to
2358 2012-01-25 Chong Yidong <cyd@gnu.org>
2360 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2362 2012-01-21 Chong Yidong <cyd@gnu.org>
2364 * floatfns.c (Fcopysign): Make the second argument non-optional,
2365 since nil is not allowed anyway.
2367 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2369 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2370 (send_process): Likewise.
2372 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2374 * window.c (save_window_save, Fcurrent_window_configuration)
2375 (Vwindow_persistent_parameters): Do not use Qstate.
2376 Rewrite doc-strings.
2378 2012-01-19 Kenichi Handa <handa@m17n.org>
2380 * character.c (char_width): New function.
2381 (Fchar_width, c_string_width, lisp_string_width):
2382 Use char_width (Bug#9496).
2384 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2386 * window.c (Vwindow_persistent_parameters): New variable.
2387 (Fset_window_configuration, save_window_save): Handle persistent
2390 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2392 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2393 thrashing the stack of the thread. (Bug#9087)
2395 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2397 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2399 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2401 * xdisp.c (rows_from_pos_range): Handle the case where the
2402 highlight ends on a newline. (Bug#10464)
2403 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2404 he end column for display of highlight that ends on a newline
2407 2012-01-11 Glenn Morris <rgm@gnu.org>
2409 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2410 from load-path also when installation-directory is nil. (Bug#10208)
2412 2012-01-10 Glenn Morris <rgm@gnu.org>
2414 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2416 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2417 Update template values to be closer to their typical values these days.
2419 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2421 * xdisp.c (rows_from_pos_range): Accept additional argument
2422 DISP_STRING, and accept any glyph in a row whose object is that
2423 string as eligible for mouse highlight. Fixes mouse highlight of
2424 display strings from overlays. (Bug#10464)
2426 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2428 emacs: fix an auto-save permissions race condition (Bug#10400)
2429 * fileio.c (auto_saving_dir_umask): New static var.
2430 (Fmake_directory_internal): Use it.
2431 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2432 creating the directory. The old code temporarily assigns
2433 too-generous permissions to the directory.
2434 (do_auto_save_eh): Clear it.
2435 (Fdo_auto_save): Catch all errors, not just file errors, so
2436 that the var is always cleared.
2438 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2440 * search.c (scan_buffer): Pass character positions to
2441 know_region_cache, not byte positions. (Bug#6540)
2443 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2445 * w32.c (sys_rename): Report EXDEV when rename of a directory
2446 fails because the target is on another logical disk. (Bug#10284)
2448 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2450 * xterm.c (x_embed_request_focus): New function.
2452 * xterm.h: Add prototype.
2454 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2456 2012-01-05 Glenn Morris <rgm@gnu.org>
2458 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2460 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2462 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2463 Load gnutls_transport_set_lowat only if GnuTLS version is below
2465 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2466 GnuTLS versions below 2.11.1.
2468 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2470 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2471 to the doc string advising against its use for altering the way
2472 windows are scrolled.
2474 2011-12-28 Kenichi Handa <handa@m17n.org>
2476 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2477 coding-system ASCII compatible only when it does not produce BOM
2478 on encoding (Bug#10383).
2480 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2482 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2484 (create_and_show_popup_menu): Always use menu_position_func for
2487 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2489 * callint.c (Fcall_interactively): Don't truncate prompt string.
2491 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2493 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2494 property that ends at ZV, so that the bidi iteration could be
2495 resumed from there (after widening). (Bug#10360)
2497 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2499 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2501 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2503 * nsterm.m (x_free_frame_resources):
2504 Release f->output_data.ns->miniimage.
2505 (ns_index_color): Fix indentation. Do not retain
2506 color_table->colors[i].
2508 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2511 * nsfns.m (x_set_background_color): Assign return value from
2512 ns_index_color to face-background instead of NSColor*.
2513 (ns_implicitly_set_icon_type): Fix indentation.
2514 Change assignment in for loop to comparison.
2516 * emacs.c (ns_pool): New variable.
2517 (main): Assign ns_pool.
2518 (Fkill_emacs): Call ns_release_autorelease_pool.
2520 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2521 autorelease fdesc, release fdAttrs and tdict.
2522 (ns_get_covering_families): Release charset.
2523 (ns_findfonts): Release NSFontDescriptor created with new.
2524 (ns_uni_to_glyphs): Fix indentation.
2525 (setString): Release attrStr before assigning new value.
2527 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2529 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2531 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2532 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2534 2011-12-18 David Reitter <reitter@cmu.edu>
2536 * nsterm.m (ns_term_init): Subscribe for notifications
2537 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2538 to method trackingNotification in EmacsMenu.
2540 * nsmenu.m (trackingMenu): New variable.
2541 (trackingNotification): New method (from Aquamacs).
2542 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2543 from Aquamacs (Bug#7030).
2545 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2547 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2548 (symbol_to_nsstring): Fix indentation.
2549 (ns_symbol_to_pb): New function.
2550 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2551 (Fns_rotate_cut_buffers_internal): Remove.
2552 (Fns_store_selection_internal): Rename from
2553 Fns_store_cut_buffer_internal.
2554 (ns_get_foreign_selection, Fx_own_selection_internal)
2555 (Fx_disown_selection_internal, Fx_selection_exists_p)
2556 (Fns_get_selection_internal, Fns_store_selection_internal):
2557 Use ns_symbol_to_pb and check if return value is nil.
2558 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2559 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2560 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2561 renamed to Sns_store_selection_internal.
2562 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2563 and remove this function.
2564 (ns_handle_selection_clear): Remove, never used.
2565 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2568 2011-12-17 Ken Brown <kbrown@cornell.edu>
2570 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2571 GID is unknown (Bug#10257).
2573 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2575 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2576 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2577 which caused a build failure on GNU/Linux IA-64. This problem was
2578 introduced by my 2011-10-07 patch.
2580 2011-12-15 Juri Linkov <juri@jurta.org>
2582 * image.c (imagemagick_error): New function. (Bug#10112)
2583 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2584 Use `imagemagick_error' where ImageMagick functions return
2586 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2589 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2591 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2592 fill background (Bug#8992).
2594 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2596 * window.c (Vwindow_combination_resize)
2597 (Vwindow_combination_limit): Use t instead of non-nil in
2599 (Vrecenter_redisplay): Add first sentence of doc-string on
2601 (Frecenter): Fix doc-string typo.
2603 2011-12-11 Kenichi Handa <handa@m17n.org>
2605 * coding.c (Funencodable_char_position): Pay attention to the
2606 buffer text relocation (Bug#9389).
2608 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2610 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2611 gtk_init (Bug#10100).
2613 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2615 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2616 IT->string is nil. (Bug#10263)
2618 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2620 * nsterm.h (x_free_frame_resources): Declare.
2622 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2623 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2625 * nsterm.h (ns_get_defaults_value): Declare.
2627 * nsterm.m (ns_default): Call ns_get_defaults_value.
2629 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2631 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2634 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2636 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2637 that where the value of an _OBJC_* symbol points to is in the .bss
2638 section (Bug#10240).
2640 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2642 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2643 after the loop to call ccl_driver at least once (Bug#8619).
2645 2011-12-08 Kenichi Handa <handa@m17n.org>
2647 * ftfont.c (get_adstyle_property): Fix previous change
2650 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2652 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2653 dirs from the default value of EMACSLOADPATH (bug#10208).
2655 2011-12-07 Glenn Morris <rgm@gnu.org>
2657 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2658 installation and source directories as well. (Bug#10208)
2660 2011-12-06 Chong Yidong <cyd@gnu.org>
2662 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2664 2011-12-06 Glenn Morris <rgm@gnu.org>
2666 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2667 as an error, not just -1. (Bug#10217)
2669 2011-12-05 Chong Yidong <cyd@gnu.org>
2671 * keyboard.c (process_special_events): New function.
2672 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2674 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2676 * coding.c (encode_designation_at_bol): Don't use uninitialized
2677 local variable (Bug#9318).
2679 2011-12-05 Kenichi Handa <handa@m17n.org>
2681 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2682 return Qnil (Bug#8046, Bug#10193).
2684 2011-12-05 Kenichi Handa <handa@m17n.org>
2686 * coding.c (encode_designation_at_bol): New args charbuf_end and
2687 dst. Return the number of produced bytes. Callers changed.
2688 (coding_set_source): Return how many bytes coding->source was
2690 (coding_set_destination): Return how many bytes
2691 coding->destination was relocated.
2692 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2693 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2695 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2697 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2698 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2701 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2703 The following changes are to fix Bug#9318.
2705 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2706 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2707 (encode_coding_iso_2022, encode_coding_sjis)
2708 (encode_coding_big5, encode_coding_charset): Use the above macros.
2710 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2712 * lisp.h (process_quit_flag): Fix external declaration.
2714 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2716 Don't macro-inline non-performance-critical code.
2717 * eval.c (process_quit_flag): New function.
2718 * lisp.h (QUIT): Use it.
2720 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2722 * nsfns.m (get_geometry_from_preferences): New function.
2723 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2725 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2727 * emacs.c (Qkill_emacs): Define.
2728 (syms_of_emacs): Initialize it.
2729 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2730 Qquit_flag to `kill-emacs' instead.
2731 (quit_throw_to_read_char): Add parameter `from_signal'.
2732 All callers changed. Call Fkill_emacs if requested and safe.
2733 * lisp.h (QUIT): Call Fkill_emacs if requested.
2735 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2737 * widget.c (update_wm_hints): Return if wmshell is null.
2738 (widget_update_wm_size_hints): New function.
2740 * widget.h (widget_update_wm_size_hints): Declare.
2742 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2743 widget_update_wm_size_hints (Bug#10104).
2745 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2747 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2748 before a newline, prepare the bidi iterator for consuming the
2749 newline, and keep the current paragraph direction. (Bug#10183)
2750 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2752 2011-12-02 Juri Linkov <juri@jurta.org>
2754 * search.c (Fword_search_regexp): New Lisp function created from
2755 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2756 (Fword_search_backward, Fword_search_forward)
2757 (Fword_search_backward_lax, Fword_search_forward_lax):
2758 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2759 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2761 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2763 * fileio.c (Finsert_file_contents): Move after-change-function call
2764 to before the "handled:" label, since all "goto handled" appear in
2765 cases where the *-change-functions have already been properly called
2768 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2770 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2771 waiting for input. (Bug#10169)
2773 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2775 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2776 verifies glyph row's hash code--we have just reallocated the
2777 glyphs, so their contents can be complete garbage. (Bug#10164)
2779 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2781 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2783 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2785 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2786 attributes are tested _before_ calling verify_row_hash, to protect
2787 against GCC re-ordering of the tests. (Bug#10164)
2789 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2791 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2793 * xterm.c (handle_one_xevent): Only set async_visible and friends
2794 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2795 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2796 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2798 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2800 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2801 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2802 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2803 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2804 All uses changed to use GCPRO1 etc.
2805 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2806 Revert to old implementation (i.e., before 2011-03-11).
2808 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2810 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2811 of scroll runs so as to avoid assigning disabled bogus rows and
2812 unnecessary graphics copy operations.
2814 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2816 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2817 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2818 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2819 (malloc, free, realloc, calloc): Redirect to e_* only when
2822 * lisp.h (GCTYPEBITS): Move before first use.
2823 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2824 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2825 this macro definition.
2827 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2830 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2832 * gtkutil.c (xg_create_frame_widgets):
2833 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2834 present with Gtk+ 2.0.
2836 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2838 * fileio.c (Finsert_file_contents): Undo previous change; see
2839 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2841 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2843 Rename locals to avoid shadowing.
2844 * fileio.c (Finsert_file_contents):
2845 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2846 * process.c (wait_reading_process_output):
2847 Rename inner 'proc' to 'p' to avoid shadowing.
2848 Indent for consistency with usual Emacs style.
2850 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2852 * xdisp.c (redisplay_window): If cursor row is not fully visible
2853 after recentering, and scroll-conservatively is set to a large
2854 number, scroll window by a few more lines to make the cursor fully
2855 visible and out of scroll-margin. (Bug#10105)
2856 (start_display): Don't move to the next line if the display should
2857 start at a newline that is part of a display vector or an overlay
2860 2011-11-24 Juri Linkov <juri@jurta.org>
2862 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2863 after the `MagickPingImage' call. (Bug#10112)
2865 2011-11-23 Chong Yidong <cyd@gnu.org>
2867 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2869 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2871 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2872 making another buffer current. (Bug#10114)
2874 2011-11-23 Glenn Morris <rgm@gnu.org>
2876 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2878 2011-11-23 Chong Yidong <cyd@gnu.org>
2880 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2881 using it (Bug#5984).
2883 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2885 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2886 and header-lines, as they don't have one computed for them.
2889 * .gdbinit (prow): Make displayed values more self-explaining.
2890 Add row's hash code.
2892 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2894 * process.c (wait_reading_process_output): Fix asynchrounous
2895 GnuTLS socket handling on some versions of the GnuTLS library.
2896 (wait_reading_process_output): Add comment and URL.
2898 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2900 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2902 2011-11-21 Chong Yidong <cyd@gnu.org>
2904 * window.c (Fnext_window, Fprevious_window): Doc fix.
2906 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2908 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2910 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2912 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2914 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2916 * window.c (Fset_window_combination_limit): Rename argument
2918 (Vwindow_combination_limit): Remove "status" from doc-string.
2920 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2922 * m/ibms390.h: Remove.
2923 * m/ibms390x.h: Don't include "ibms390.h".
2925 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2927 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2928 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2930 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2932 * casetab.c (Fset_case_table):
2933 * charset.c (Fcharset_after): Fix typos.
2935 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2937 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2938 Otherwise, valgrind does not work on some platforms.
2939 Problem reported by Andreas Schwab in
2940 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2941 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2942 is set, removing the need for VIRT_ADDRESS_VARIES.
2943 (PURE_P): Use a more-efficient implementation that needs just one
2944 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2945 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2946 to 4 (xorl, subq, cmpq, setbe).
2947 * alloc.c (pure): Always extern now, since that's the
2948 VIRT_ADDR_VARIES behavior.
2949 (PURE_POINTER_P): Use a single comparison, not two, for
2950 consistency with the new puresize.h.
2951 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2952 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2953 Remove VIRT_ADDR_VARIES no longer needed.
2955 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2957 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2958 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2959 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2960 behave as if the cursor position were at the window margin.
2962 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2963 and the cursor position is out of bounds, behave as if the cursor
2964 position were at the window margin. (Bug#10075)
2966 2011-11-18 Chong Yidong <cyd@gnu.org>
2968 * window.c (Fwindow_combination_limit): Make first argument
2969 non-optional, since it is meaningless for live windows like the
2972 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2974 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2976 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2978 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2979 (graft_intervals_into_buffer): Simplify.
2981 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2983 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2984 hash values of the two rows.
2985 (copy_row_except_pointers): Preserve the used[] arrays and the
2986 hash values of the two rows. (Bug#10035)
2987 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2989 * xdisp.c (row_hash): New function, body extracted from
2990 compute_line_metrics.
2991 (compute_line_metrics): Call row_hash, instead of computing the
2994 * dispnew.c (verify_row_hash): Call row_hash for computing the
2995 hash code of a row, instead of duplicating code from xdisp.c.
2997 * dispextern.h (row_hash): Add prototype.
2999 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3001 * frame.c (delete_frame): Don't delete the terminal when the last
3002 X frame is closed if emacs is built with GTK toolkit.
3004 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3006 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3008 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3010 * window.c (Vwindow_splits): Rename to
3011 Vwindow_combination_resize. Suggested by Juri Linkov.
3012 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3015 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3017 * nsfns.m (Fns_font_name):
3018 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3020 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3022 * window.h (window): Rename slot "nest" to "combination_limit".
3023 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3024 (Fset_window_nest): Rename to Fset_window_combination_limit.
3025 (Vwindow_nest): Rename to Vwindow_combination_limit.
3026 (recombine_windows, make_parent_window, make_window)
3027 (Fsplit_window_internal, saved_window)
3028 (Fset_window_configuration, save_window_save): Rename all
3029 occurrences of window_nest to window_combination_limit.
3031 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3033 * image.c (imagemagick_load_image): Fix typo.
3035 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3037 * xdisp.c (display_line): Move the call to
3038 highlight_trailing_whitespace before the call to
3039 compute_line_metrics, since the latter needs to see the final
3040 faces of all the glyphs to compute ROW's hash value.
3041 Fixes assertion violations in row_equal_p. (Bug#10035)
3043 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3045 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3046 just return (bug#10044).
3048 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3050 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3051 with user-defined heap size. Bump the default size of the temacs
3052 heap to 27MB, to avoid memory warning when running temacs.
3053 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3055 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3056 current_matrix and desired_matrix. (Bug#9990)
3057 (verify_row_hash) [XASSERTS]: New function.
3058 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3059 that the hash value of glyph rows is correct.
3061 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3063 * window.h (window): Remove splits slot.
3064 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3065 (Fdelete_other_windows_internal, make_parent_window)
3066 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3067 (Fset_window_configuration, save_window_save): Don't deal with
3068 split status of windows.
3069 (saved_window): Remove splits slot.
3070 (Vwindow_splits): Rewrite doc-string.
3072 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3074 * xfns.c (unwind_create_frame):
3075 * nsfns.m (unwind_create_frame):
3076 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3077 Vframe_list (Bug#9999).
3079 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3081 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3083 2011-11-11 Kenichi Handa <handa@m17n.org>
3085 * callproc.c (Fcall_process): Set the member dst_multibyte of
3088 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3090 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3091 avoid a crash (bug#9496).
3093 2011-11-09 Chong Yidong <cyd@gnu.org>
3095 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3096 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3098 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3100 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3102 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3104 Avoid some portability problems by eschewing 'extern inline' functions.
3105 The trivial performance wins aren't worth the portability hassles; see
3106 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3108 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3109 (window_box_width, window_box_left, window_box_left_offset)
3110 (window_box_right, window_box_right_offset): Undo previous change,
3111 by removing the "extern"s.
3112 * intervals.c (adjust_intervals_for_insertion)
3113 (adjust_intervals_for_deletion): Undo previous change,
3114 making these static again.
3115 (offset_intervals, temp_set_point_both, temp_set_point)
3116 (copy_intervals_to_string): No longer inline.
3117 * xdisp.c (window_text_bottom_y, window_box_width)
3118 (window_box_height, window_box_left_offset)
3119 (window_box_right_offset, window_box_left, window_box_right)
3120 (window_box): No longer inline.
3122 2011-11-08 Chong Yidong <cyd@gnu.org>
3124 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3125 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3126 Signal an error if not a live window.
3127 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3128 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3130 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3132 * lisp.h (syms_of_abbrev): Remove declaration.
3133 Reported by CHENG Gao <chenggao@royau.me>.
3135 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3137 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3138 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3139 of temacs in GUI mode.
3141 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3143 * window.h: Declare delete_all_child_windows instead of
3144 delete_all_subwindows.
3145 * window.c (Fwindow_nest, Fset_window_nest)
3146 (Fset_window_new_total, Fset_window_new_normal)
3147 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3148 (delete_all_subwindows): Rename to delete_all_child_windows.
3149 (Fdelete_other_windows_internal, Fset_window_configuration):
3150 Call delete_all_child_windows instead of delete_all_subwindows.
3151 * frame.c (delete_frame): Call delete_all_child_windows instead
3152 of delete_all_subwindows.
3154 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3156 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3157 This is also needed for porting to any host where GC_MARK_STACK is
3158 not GC_MAKE_GCPROS_NOOPS.
3159 (which_symbols): Use it.
3161 2011-11-07 Kenichi Handa <handa@m17n.org>
3163 * coding.c (coding_set_destination): Check coding->src_pos only
3164 when coding->src_object is a buffer (bug#9910).
3166 * process.c (send_process): Set the member src_multibyte of coding
3167 to 0 (bug#9911) when sending a unibyte text.
3169 * callproc.c (Fcall_process): Set the member src_multibyte of
3170 process_coding to 0 (bug#9912).
3172 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3174 * xmenu.c (cleanup_widget_value_tree): New function.
3175 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3176 calling free_menubar_widget_value_tree directly (Bug#9830).
3178 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3180 Fix some portability problems with 'inline'.
3181 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3182 (window_box_width, window_box_left, window_box_left_offset)
3183 (window_box_right, window_box_right_offset): Declare extern.
3184 Otherwise, these inline functions do not conform to C99 and
3185 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3186 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3187 * intervals.c (adjust_intervals_for_insertion)
3188 (adjust_intervals_for_deletion): Now extern, because otherwise the
3189 extern inline functions 'offset_intervals' couldn't refer to it.
3190 (static_offset_intervals): Remove.
3191 (offset_intervals): Rewrite using the old contents of
3192 static_offset_intervals. The old version didn't conform to C99
3193 because an extern inline function contained a reference to an
3194 identifier with static linkage.
3196 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3198 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3201 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3203 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3204 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3205 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3206 return Qleft_to_right.
3208 2011-11-06 Chong Yidong <cyd@gnu.org>
3210 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3211 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3212 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3213 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3214 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3215 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3216 (Fwindow_vscroll): Doc fix.
3217 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3218 argument, since it makes no sense to pass a live window and for
3219 consistency with window-child.
3221 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3223 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3226 2011-11-05 Jason Rumney <jasonr@gnu.org>
3228 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3229 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3231 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3232 bitwise arithmetic preventing use of unicode-sip and non-truetype
3235 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3237 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3240 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3241 initialization code to keep similarity to xfns.c after changes
3244 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3246 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3247 (unwind_create_frame): New function (Bug#9943).
3248 (Fx_create_frame): Restructure code to be more similar to the one in
3249 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3250 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3251 Move terminal->reference_count++ just before making the frame official
3254 * nsterm.m (x_free_frame_resources): New function.
3255 (x_destroy_window): Move code to x_free_frame_resources.
3257 * xfns.c (unwind_create_frame): Fix comment.
3258 (Fx_create_frame, x_create_tip_frame):
3259 Move terminal->reference_count++ just before making the frame
3260 official. Move initialization of image_cache_refcount and
3261 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3263 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3265 Support MSVC build with newer versions of Visual Studio.
3266 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3267 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3270 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3271 which are not supported by MSVC.
3272 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3273 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3275 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3277 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3279 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3281 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3283 Support MSVC build with newer versions of Visual Studio.
3284 * w32.c: Don't include w32api.h for MSVC.
3285 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3287 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3288 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3289 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3290 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3292 (alloca) [_MSC_VER]: Define to _alloca.
3294 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3296 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3298 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3300 * xdisp.c (note_mouse_highlight): If either of
3301 previous/next-single-property-change returns nil, treat that as
3302 the beginning or the end of the buffer. (Bug#9955)
3304 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3306 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3307 label is not null (Bug#9951).
3308 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3311 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3313 * window.c (Fwindow_body_size): Mention in the doc string that the
3314 return value is in frame's canonical units. (Bug#9949)
3316 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3318 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3320 * w32fns.c (unwind_create_frame): If needed, free the glyph
3321 matrices of the partially constructed frame. (Bug#9943)
3322 * xfns.c (unwind_create_frame): Likewise.
3324 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3326 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3327 Don't stop backward scan on the continuation glyph, even though
3328 its CHARPOS is positive.
3329 (mouse_face_from_buffer_pos, note_mouse_highlight):
3330 Rename cover_string to disp_string.
3332 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3334 * window.c (temp_output_buffer_show): Don't use
3335 Vtemp_buffer_show_specifiers.
3336 (Vtemp_buffer_show_specifiers): Remove unused variable.
3338 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3340 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3341 past the beginning of the current glyph matrix.
3343 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3345 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3346 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3347 HAVE_GTK3 (Bug#9869).
3349 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3350 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3352 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3354 * xterm.c: Declare x_handle_net_wm_state to return int.
3355 (handle_one_xevent): Check if we are iconified but don't have
3356 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3357 (get_current_wm_state): Return non-zero if not hidden,
3358 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3359 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3360 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3361 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3363 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3365 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3366 so that this new function doesn't get optimized away by a
3367 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3369 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3371 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3373 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3375 Fix the `xbytecode' command.
3376 * .gdbinit (xprintbytestr): New command.
3377 (xwhichsymbols): Rename from `which'; all callers changed.
3378 (xbytecode): Print the byte-code string as well.
3380 2011-10-29 Kim Storm <storm@cua.dk>
3382 * alloc.c (which_symbols): New function.
3384 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3386 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3389 2011-10-29 Glenn Morris <rgm@gnu.org>
3391 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3392 Not clear what it was for, and it causes various bugs. (Bug#9839)
3394 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3396 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3397 possible random value that matches one of those tested as
3398 condition to clear the mouse face.
3400 2011-10-28 Chong Yidong <cyd@gnu.org>
3402 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3404 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3406 * window.c (make_window): Initialize phys_cursor_on_p.
3408 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3410 * lisp.h (struct Lisp_Symbol): Update comments.
3412 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3414 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3416 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3418 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3419 <oslsachem@gmail.com> for helping to debug this.
3421 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3422 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3423 (g_b_init_get_glyph_outline_w): New static variables.
3424 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3425 (GetGlyphOutlineW_Proc): New typedefs.
3426 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3427 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3429 (w32font_open_internal, compute_metrics):
3430 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3431 instead of calling the "wide" APIs directly.
3433 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3435 * w32.h (syms_of_w32font): Add prototype.
3437 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3439 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3440 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3441 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3442 (Fmove_to_window_line): Doc fix.
3444 2011-10-27 Chong Yidong <cyd@gnu.org>
3446 * process.c (make_process): Set gnutls_state to NULL.
3448 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3449 non-NULL, regardless of GNUTLS_INITSTAGE.
3450 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3451 an error. Set process slots as soon as we allocate them.
3453 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3455 2011-10-27 Chong Yidong <cyd@gnu.org>
3457 * gnutls.c (emacs_gnutls_deinit): New function.
3458 Deallocate credentials structures as well as calling gnutls_deinit.
3459 (Fgnutls_deinit, Fgnutls_boot): Use it.
3461 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3462 (deactivate_process): Call emacs_gnutls_deinit.
3464 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3466 * image.c (x_create_x_image_and_pixmap):
3467 * w32.c (sys_rename, w32_delayed_load):
3468 * w32font.c (fill_in_logfont):
3469 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3471 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3473 * w32fns.c (w32_default_color_map): New function,
3474 extracted from Fw32_default_color_map.
3475 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3477 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3479 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3481 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3483 * keyboard.c (test_undefined): New function (bug#9751).
3484 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3486 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3488 * sysdep.c (init_sys_modes): Fix the check for the controlling
3489 terminal (Bug#6649).
3491 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3493 * dispextern.h (struct bidi_it): New member next_en_type.
3495 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3496 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3497 current character, check also for next_en_type being WEAK_EN.
3498 (bidi_resolve_weak): Don't enter the expensive loop if the current
3499 position is before next_en_pos. Record the bidi type of the first
3500 non-ET, non-BN character we find, in addition to its position.
3501 (bidi_level_of_next_char): Invalidate next_en_type when
3502 next_en_pos is over-stepped.
3504 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3506 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3507 * editfns.c: Rewrite current-time-zone so that it invokes
3508 the equivalent of (format-time-string "%Z") to get the time zone name.
3509 This fixes a bug when the time zone name contains characters that
3510 need converting from the system time locale to Emacs internal format.
3511 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3512 that patch fixed format-time-string to do the conversion, but
3513 I forgot to fix current-time-zone.
3514 (format_time_string): New function, containing most of
3515 what Fformat_time_string used to contain.
3516 (Fformat_time_string): Rewrite in terms of format_time_string.
3517 This doesn't change this function's behavior.
3518 (current-time-zone): Rewrite to use format_time_string.
3519 This fixes the bug reported by Michael Schierl in
3520 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3521 Jason Rumney's 2007-06-07 change worked around this bug, but
3523 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3525 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3527 * xdisp.c (start_display): If the character at POS is displayed
3528 via a display vector, reset IT->current.dpvec_index to zero.
3529 (try_window_reusing_current_matrix): If a line ends in a display
3530 vector or the next line starts in a display vector, continue
3531 redrawing the window even though the character position of
3532 start_row was reached.
3535 2011-10-18 Chong Yidong <cyd@gnu.org>
3537 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3538 with nobreak-char-display too.
3540 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3542 Fix part 3 of bug#9771.
3543 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3544 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3545 non-neutral characters if the current character is a paragraph
3546 separator (a.k.a. Newline). This avoids running the same
3547 expensive loop twice, once when we consume the preceding newline
3548 and the other time when the line actually needs to be displayed.
3549 Avoid the loop when we see neutrals on the base embedding level
3550 following a character whose directionality is the same as the
3551 paragraph's. This avoids running the expensive loop when a line
3552 ends in a long sequence of neutrals, like control characters.
3553 Add assertion against STRONG_AL type. Slightly rearrange code
3554 that determines the type of a neutral given the first non-neutral
3556 (bidi_level_of_next_char): Set next_en_pos to zero when
3557 invalidating its info.
3559 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3561 * xdisp.c (push_display_prop): Determine whether to record string
3562 or buffer position by IT->string, not by IT->method. Allow
3563 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3564 (move_it_vertically_backward): Don't look for character position
3565 immediately after the newline when in a continuation line.
3568 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3570 * window.c (coordinates_in_window): Rewrite and delabelize
3571 vertical border check. (Bug#5357) (Bug#9618)
3573 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3575 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3576 errors in XSetWindowBorder (bug#9310).
3578 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3580 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3581 avoid crash when xmalloc overrun checking is enabled.
3583 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3585 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3586 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3587 cursor motion with <left> and <right> arrow keys.
3589 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3590 some callers set that themselves.
3592 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3594 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3595 display string and the previous row comes from the same string and
3596 is empty. (Bug#9739) (Bug#9738)
3598 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3600 * doc.c (get_doc_string): Encode file name (bug#9735).
3602 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3604 * bidi.c (bidi_level_of_next_char):
3605 * xdisp.c (get_visually_first_element): Remove old incorrect
3606 comments regarding the Unicode Line Separator character.
3608 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3610 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3612 * alloc.c (Fgc_status): Do not access beyond zombies array
3613 boundary if nzombies > MAX_ZOMBIES.
3614 * alloc.c (dump_zombies): Add missing format specifier.
3616 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3618 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3619 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3621 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3622 Some packages use them to denote characters with modifiers.
3624 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3626 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3627 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3628 matching a pp-number. Rename parameter var to var1.
3630 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3632 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3634 2011-10-08 Glenn Morris <rgm@gnu.org>
3636 * callint.c (Fcall_interactively): Give a more explicit error for the
3637 'c' case with a non-character input. (Bug#8479)
3639 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3641 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3643 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3644 lines that are hscrolled on the left.
3646 * dispnew.c (buffer_posn_from_coords): Account for a possible
3647 presence of header-line. (Bug#4426)
3649 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3651 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3652 Don't advertise functionality which we discourage or doesn't work.
3654 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3656 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3657 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3658 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3659 this makes Emacs dump core during garbage collection on rare
3660 occasions. sizeof is obviously inferior to offsetof here, so
3661 stick with offsetof.
3662 (GC_POINTER_ALIGNMENT): New macro.
3663 (mark_memory): Omit 3rd (offset) arg; caller changed.
3664 Don't assume EMACS_INT alignment is the same as pointer alignment.
3666 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3668 * keyboard.c (read_key_sequence_remapped): New var.
3669 (read_key_sequence): Compute remapping in the right buffer.
3670 (command_loop_1): Use read_key_sequence's remapping directly.
3672 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3674 * dired.c (file_name_completion): Don't expand file name.
3675 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3676 before checking file name handler.
3678 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3679 they've been requested explicitly (bug#9591).
3681 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3683 * keymap.c (Fsingle_key_description): Use make_specified_string
3684 instead of build_string to build string from push_key_description.
3687 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3689 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3690 This fixes a Y2038 bug on 64-bit hosts.
3691 * buffer.c (reset_buffer):
3692 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3693 (Fclear_buffer_auto_save_failure):
3694 Use 0, not -1, to represent an unset failure time, since time_t
3695 might not be signed.
3697 Remove dependency on glibc malloc internals.
3698 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3699 Move back here from lisp.h, but with their new implementations.
3700 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3701 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3702 * charset.c (charset_table_init): New static var.
3703 (syms_of_charset): Use it instead of xmalloc. This removes a
3704 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3705 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3706 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3707 Move back to alloc.c.
3708 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3709 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3711 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3713 * nsterm.m (windowDidResize): Call x_set_window_size only when
3714 ns_in_resize is true. Otherwise set pixelwidth/height and
3715 call change_frame_size (Bug#9628).
3717 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3719 Port --enable-checking=all to Fedora 14 x86-64.
3720 * charset.c (syms_of_charset): Also account for glibc malloc's
3721 internal overhead when calculating the initial malloc maximum.
3723 Port --enable-checking=all to Fedora 14 x86.
3724 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3726 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3727 (overrun_check_realloc, overrun_check_free):
3728 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3729 That way, xmalloc returns a properly-aligned pointer even if
3730 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3731 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3732 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3733 into account when calculating the initial malloc maximum.
3734 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3735 Move here from alloc.c, so that charset.c can use it too.
3736 Properly align; the old code wasn't right for common 32-bit hosts
3737 when configured with --enable-checking=all.
3738 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3739 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3741 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3743 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3746 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3748 * xdisp.c (compute_display_string_end): If there's no display
3749 string at CHARPOS, return -1.
3751 * bidi.c (bidi_fetch_char): When compute_display_string_end
3752 returns a negative value, treat the character as a normal
3753 character not covered by a display string. (Bug#9624)
3755 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3757 * lread.c (Fread_from_string): Fix typo in docstring.
3759 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3761 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3762 newline, reseat the iterator instead of bidi-iterating there one
3763 character at a time. (Bug#9610)
3764 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3765 TO_CHARPOS if the bidi iterator is at base embedding level.
3767 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3769 * lread.c (readevalloop): Use correct code for NBSP.
3770 (read1): Likewise. (Bug#9608)
3772 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3774 * dbusbind.c (Fdbus_register_signal): When service is not
3775 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3777 2011-09-25 Glenn Morris <rgm@gnu.org>
3779 * buffer.c (truncate-lines): Doc fix.
3781 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3783 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3784 (Fset_window_next_buffers): Doc fix.
3786 2011-09-24 Glenn Morris <rgm@gnu.org>
3788 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3790 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3792 Fix minor problems found by static checking.
3793 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3794 * indent.c (Fvertical_motion): Fix == vs = typo.
3796 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3798 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3799 Default value is now t. Doc fix.
3801 * indent.c (Fvertical_motion): Compute and apply the overshoot
3802 logic when moving up, not only when moving down. Fix the
3803 confusing name and values of the it_overshoot_expected variable;
3804 logic changes accordingly. (Bug#9254) (Bug#9549)
3806 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3807 CHARPOS is covered by a display string which includes newlines.
3808 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3809 is covered by a display string with embedded newlines.
3811 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3813 * dbusbind.c (Fdbus_register_signal): Add match rule to
3814 Vdbus_registered_objects_table. (Bug#9581)
3815 (Fdbus_register_method, Vdbus_registered_objects_table):
3818 2011-09-24 Jim Meyering <meyering@redhat.com>
3820 do not ignore write error for any output size
3821 The previous change was incomplete.
3822 While it makes emacs --batch detect the vast majority of stdout
3823 write failures, errors were still ignored whenever the output size is
3824 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3825 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3826 && echo FAIL: ignored write error
3827 FAIL: ignored write error
3828 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3829 && echo FAIL: ignored write error
3830 FAIL: ignored write error
3831 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3833 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3835 * emacs.c (Fkill_emacs): In noninteractive mode exit
3836 non-successfully if a write error occurred on stdout. (Bug#9574)
3838 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3840 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3843 * dispextern.h (struct it): Update the comment documenting what
3846 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3848 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3849 a display string, extend search for cursor position to end of row.
3850 (find_row_edges): If the row ends in a newline from a display
3851 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3852 Handle the case of a display string with multiple newlines.
3853 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3854 non-empty line. Fixes confusing cursor motion with arrow keys at
3855 the beginning of a line that starts with whitespace.
3857 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3859 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3862 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3864 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3867 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3869 * xdisp.c (display_line): Record maximum and minimum buffer
3870 positions even if no glyphs were produced (e.g., by a zero-width
3871 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3872 buffer positions that will be removed from the glyph row because
3874 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3875 column is beyond frame width: don't subtract 1 "pixel" when
3876 computing width of the stretch.
3877 (reseat_at_next_visible_line_start): Undo the change made on
3878 2011-09-17 that saved paragraph information and restored it after
3879 the call to `reseat'. (Bug#9545)
3881 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3883 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3884 and turn window cursor on if cleared (Bug#9415).
3886 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3888 * search.c (boyer_moore): Take unibyte characters from pattern
3889 literally. (Bug#9458)
3891 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3893 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3895 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3897 Fix minor problem found by static checking.
3898 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3899 initialized, to pacify gcc -Wuninitialized.
3901 * fileio.c: Report proper errno when syscall falls.
3902 (Finsert_file_contents): Save and restore errno,
3903 so that report_file_error outputs the correct diagnostic.
3904 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3906 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3908 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3910 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3912 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3913 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3915 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3917 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3918 about the current paragraph and restore it after the call to reseat.
3920 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3921 (bidi_find_paragraph_start): Search back for paragraph beginning
3922 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3923 (bidi_move_to_visually_next): Only trigger paragraph-related
3924 computations when the last character is a newline or at EOB, not
3925 just any NEUTRAL_B. (Bug#9470)
3927 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3928 truncated lines if point is covered by a display string. (Bug#9524)
3930 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3932 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3933 (cons_to_x_long): New function.
3934 (lisp_data_to_selection_data): Use it. Correct the test for
3935 short-versus-long data; it was negated. Break out of vector
3936 loop, for efficiency, when a long datum is discovered.
3938 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3940 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3942 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3944 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3945 GCC PR/17406) by declaring this function with external scope.
3947 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3949 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3950 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3952 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3954 * editfns.c (Fformat): Correctly handle text properties on "%%".
3956 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3958 * xterm.c (x_draw_composite_glyph_string_foreground):
3959 * w32term.c (x_draw_composite_glyph_string_foreground):
3960 * term.c (encode_terminal_code):
3961 * composite.c (composition_update_it, get_composition_id):
3962 * xdisp.c (get_next_display_element)
3963 (fill_composite_glyph_string): Add comments about special meaning
3964 of TAB characters in a composition.
3966 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3968 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3969 This occurs when processing a multibyte format.
3970 Problem reported by Wolfgang Jenker.
3972 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3974 * xdisp.c (try_cursor_movement): Only check for exact match if
3975 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3977 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3979 Remove unused external symbols.
3980 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3981 * xdisp.c (calc_pixel_width_or_height): Now static.
3982 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3983 * indent.c (check_display_width):
3984 * w32term.c: Fix comment to match code.
3985 * xterm.c, xterm.h (x_catching_errors): Remove.
3987 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3989 * xselect.c: Use signed conversions more consistently (Bug#9498).
3990 (selection_data_to_lisp_data): Assume incoming selection data are
3991 signed integers, not unsigned. This is to be consistent with
3992 outgoing selection data, which was modified to use signed integers
3993 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3994 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3995 expects long, not unsigned long.
3997 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3999 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4000 computation of loop end. Reported by Johan Bockgård
4003 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4005 * frame.c (Fother_visible_frames_p): Function deleted.
4007 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4009 * indent.c (compute_motion): Process display vector front to back
4010 rather than the other way around. (Bug#2496)
4012 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4014 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4016 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4018 * minibuf.c (Fread_from_minibuffer): Doc fix.
4020 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4022 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4023 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4025 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4027 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4028 value for non-existent files.
4030 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4032 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4033 set its "size" to -1. This will set the modtime_size field of
4034 the corresponding buffer to -1, which is what
4035 verify-visited-file-modtime expects for files that do not exist.
4038 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4040 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4042 * lisp.h: ... from here. push_key_description is no longer
4043 defined in keyboard.c, so its declaration should not be in
4044 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4045 logically belongs with push_key_description.
4047 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4049 * buffer.h: Include <sys/types.h> instead of <time.h>.
4050 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4051 Problem reported by Herbert J. Skuhra.
4053 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4055 * xml.c (parse_region): Make the parsing work for
4056 non-comment-starting XML files again (bug#9144).
4058 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4060 * image.c (gif_load): Fix calculation of bottom and right corner.
4063 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4065 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4066 redisplay in small windows.
4068 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4070 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4072 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4074 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4075 Operate on live windows only.
4077 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4079 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4081 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4083 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4084 only under bidi iteration.
4086 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4088 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4090 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4092 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4093 Without this fix, the command to link temacs failed due to an
4094 undefined symbol __builtin_isnan. This is because
4095 /usr/include/iso/math_c99.h #defines isnan(x) to
4096 __builtin_isnan(x), but the bundled gcc, which identifies itself
4097 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4099 * floatfns.c (isnan): #undef, and then #define to a clone of
4101 (Fisnan): Always define, since it's always available now.
4102 (syms_of_floatfns): Always define isnan at the Lisp level.
4104 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4106 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4108 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4110 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4111 The previous code assumed that file offsets (off_t values) fit in
4112 EMACS_INT variables, which is not true on typical 32-bit hosts.
4113 The code messed up by falsely reporting buffer overflow in cases
4114 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4115 when "big" contains more than 2**29 bytes, even though this
4116 inserts just one byte and does not overflow the buffer.
4117 (Finsert_file_contents): Store file offsets as off_t
4118 values, not as EMACS_INT values. Check for overflow when
4119 converting between EMACS_INT and off_t. When checking for
4120 buffer overflow or for overlap, take the offsets into account.
4121 Don't use EMACS_INT for small values where int suffices.
4122 When checking for overlap, fix a typo: ZV was used where
4123 ZV_BYTE was intended.
4124 (Fwrite_region): Don't assume off_t fits into 'long'.
4125 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4127 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4129 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4131 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4133 sprintf-related integer and memory overflow issues (Bug#9412).
4135 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4136 (esprintf, exprintf, evxprintf): New functions.
4137 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4138 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4139 (modify_event_symbol): Do not assume that the length of
4140 name_alist_or_stem is safe to alloca and fits in int.
4141 (Fexecute_extended_command): Likewise for function name and binding.
4142 (Frecursion_depth): Wrap around reliably on integer overflow.
4143 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4144 since some callers pass EMACS_INT values.
4145 (Fsingle_key_description): Don't crash if symbol name contains more
4146 than MAX_ALLOCA bytes.
4147 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4148 (get_minibuffer): Arg is now EMACS_INT, not int.
4149 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4150 (esprintf, exprintf, evxprintf): New decls.
4151 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4153 * dbusbind.c (signature_cat): New function.
4154 (xd_signature, Fdbus_register_signal):
4155 Do not overrun buffer; instead, report string overflow.
4157 * dispnew.c (add_window_display_history): Don't overrun buffer.
4158 Truncate instead; this is OK since it's just a log.
4160 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4161 even if the time zone offset is outlandishly large.
4162 Don't mishandle offset == INT_MIN.
4164 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4165 when creating daemon; the previous buffer-overflow check was incorrect.
4167 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4168 which has the guts of the old verror function.
4170 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4171 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4173 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4174 (font_unparse_xlfd): Don't blindly alloca long strings.
4175 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4176 fits in int, when using sprintf. Use single snprintf to count
4177 length of string rather than counting it via multiple sprintfs;
4178 that's simpler and more reliable.
4179 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4180 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4181 sprintf, in case result does not fit in int.
4183 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4184 (fontset_from_font): Print it.
4186 * frame.c (tty_frame_count): Now printmax_t, not int.
4187 (make_terminal_frame, set_term_frame_name): Print it.
4188 (x_report_frame_params): In X, window IDs are unsigned long,
4189 not signed long, so print them as unsigned.
4190 (validate_x_resource_name): Check for implausibly long names,
4191 and don't assume name length fits in 'int'.
4192 (x_get_resource_string): Don't blindly alloca invocation name;
4193 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4196 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4197 (xg_check_special_colors, xg_set_geometry):
4198 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4200 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4201 Use esprintf, not sprintf, in case result does not fit in int.
4203 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4204 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4205 it as a large positive number.
4206 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4207 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4209 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4210 in case result does not fit in int.
4212 * print.c (float_to_string): Detect width overflow more reliably.
4213 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4214 buffer overrun. Don't assume list length fits in 'int'. Treat
4215 print length of 0 as 0, not as infinity; to be consistent with other
4216 uses of print length in this function. Don't overflow print length
4217 index. Don't assume hash table size fits in 'long', or that
4218 vectorlike size fits in 'unsigned long'.
4220 * process.c (make_process): Use printmax_t, not int, to format
4221 process-name gensyms.
4223 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4225 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4226 to avoid potential buffer overrun.
4228 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4229 if X resource line is longer than 512 bytes.
4231 * xfns.c (x_window): Make sprintf buffer a bit bigger
4232 to avoid potential buffer overrun.
4234 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4236 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4238 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4240 Integer overflow fixes for scrolling, etc.
4241 Without these, Emacs silently mishandles large integers sometimes.
4242 For example, "C-u 4294967297 M-x recenter" was treated as if
4243 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4245 * xdisp.c (try_window_id): Check Emacs fixnum range before
4246 converting to 'int'.
4248 * window.c (window_scroll_line_based, Frecenter):
4249 Check that an Emacs fixnum is in range before assigning it to 'int'.
4250 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4251 values converted from Emacs fixnums.
4252 (Frecenter): Don't wrap around a line count if it is out of 'int'
4253 range; instead, treat it as an extreme value.
4254 (Fset_window_configuration, compare_window_configurations):
4255 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4257 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4258 that can exceed INT_MAX. Check that EMACS_INT value is in range
4259 before assigning it to the (possibly-narrower) index.
4260 (match_limit): Don't assume that a fixnum can fit in 'int'.
4262 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4265 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4266 (Fvertical_motion): Don't wrap around LINES values that don't fit
4267 in 'int'. Instead, treat them as extreme values. This is good
4268 enough for windows, which can't have more than INT_MAX lines anyway.
4270 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4272 * Require libxml/parser.h to avoid compilation warning.
4274 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4276 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4277 since this reportedly can destroy thread storage.
4279 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4281 * syntax.c (find_defun_start): Update all cache variables if
4282 exiting early (Bug#9401).
4284 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4286 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4288 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4289 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4290 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4292 * term.c (tty_append_glyph): New function.
4293 (produce_stretch_glyph): Static function and its prototype deleted.
4295 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4298 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4300 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4301 when checking :margin (Bug#9390).
4302 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4303 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4304 so that the name doesn't mislead. All uses changed.
4306 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4308 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4311 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4313 * xdisp.c (move_it_to): Don't bail out early when reaching
4314 position beyond to_charpos, if we are scanning backwards.
4315 (move_it_vertically_backward): When DY == 0, make sure we get to
4316 the first character in the line after the newline.
4318 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4320 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4321 (ccl_driver): Do not generate an out-of-range pointer.
4322 (Fccl_execute_on_string): Remove unnecessary check for
4323 integer overflow, noted by Stefan Monnier in
4324 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4325 Remove a FIXME that didn't need fixing.
4326 Simplify the newly-introduced buffer reallocation code.
4328 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4330 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4332 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4334 Integer and memory overflow issues (Bug#9196).
4336 * doc.c (get_doc_string): Rework so that
4337 get_doc_string_buffer_size is the actual buffer size, rather than
4338 being 1 less than the actual buffer size; this makes xpalloc more
4341 * image.c (x_allocate_bitmap_record, cache_image):
4342 * xselect.c (Fx_register_dnd_atom):
4343 Simplify previous changes by using xpalloc.
4345 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4346 since either will do and ptrdiff_t is convenient with xpalloc.
4348 * charset.c (charset_table_size)
4349 (struct charset_sort_data.priority): Now ptrdiff_t.
4350 (charset_compare): Don't overflow if priorities differ greatly.
4351 (Fsort_charsets): Don't assume list length fits in int.
4352 Check for size-calculation overflow when allocating sort data.
4353 (syms_of_charset): Allocate an initial charset table that is
4354 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4356 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4358 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4359 The actual value is always <= INT_MAX, and leaving it unsigned made
4360 overflow checking harder.
4362 * dispextern.h (struct glyph_matrix.rows_allocated)
4363 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4364 with xpalloc. The values are still always <= INT_MAX.
4366 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4368 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4369 (SAFE_NALLOCA): New macro.
4371 * region-cache.c (struct boundary.pos, find_cache_boundary)
4372 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4373 (set_cache_region, invalidate_region_cache)
4374 (revalidate_region_cache, know_region_cache, region_cache_forward)
4375 (region_cache_backward, pp_cache):
4376 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4377 so that ptrdiff_t * can be passed to xpalloc.
4378 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4379 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4380 (pp_cache): Don't assume cache_len fits in int.
4381 * region-cache.h: Adjust extern decls to match.
4383 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4384 EMACS_INT, since either will do, for xpalloc.
4386 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4387 (xnmalloc, xnrealloc, xpalloc): New functions.
4389 * bidi.c (bidi_shelve_header_size): New constant.
4390 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4391 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4393 * bidi.c (bidi_cache_shrink):
4394 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4396 Don't update size of array until after memory allocation succeeds,
4397 because xmalloc/xrealloc may not return.
4398 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4399 now that we have proper integer overflow checking.
4400 (record_overlay_string, overlay_strings): Catch overflows when
4401 calculating size of overlay_str_buf.
4403 * callproc.c (Fcall_process): Check for size overflow when
4404 calculating size of args2.
4405 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4406 Normally we prefer signed values, but sticking with ptrdiff_t would
4407 require adding more-complicated checks.
4409 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4410 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4411 Redo buffer-overflow calculations to avoid integer overflow.
4412 Add a FIXME comment where memory seems to be over-allocated.
4414 * character.c (Fstring): Check for size-calculation overflow.
4416 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4417 unnecessary integer overflow. Check for size overflow.
4418 (encode_coding_object): Don't update size until xmalloc succeeds.
4420 * composite.c (get_composition_id): Check for overflow in glyph
4421 length calculations.
4423 Integer and memory overflow fixes for display code.
4424 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4425 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4426 (scrolling_window): Check for overflow in size calculations.
4427 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4428 Don't assume glyph table len fits in int.
4429 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4430 (row_table_size): Now ptrdiff_t, not int.
4431 (scrolling_window): Avoid overflow in size calculations.
4432 Don't update size until allocation succeeds.
4433 * fns.c (concat): Check for overflow in size calculations.
4434 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4435 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4436 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4438 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4439 (get_doc_string): Check for size calculation overflow.
4440 Don't update size until allocation succeeds.
4441 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4442 EMACS_INT, where ptrdiff_t will do.
4443 (Fsubstitute_command_keys): Check for string overflow.
4445 * editfns.c (set_time_zone_rule): Don't assume environment length
4447 (message_length): Now ptrdiff_t, not int.
4448 (Fmessage_box): Don't update size until allocation succeeds.
4449 Don't assume message length fits in int.
4450 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4452 * emacs.c (main): Do not reallocate argv, since there is a null at
4453 the end that can be overwritten, and this way there's no need to
4454 worry about size-calculation overflow.
4455 (sort_args): Check for size-calculation overflow.
4457 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4459 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4461 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4462 (x_set_scroll_bar_width, x_figure_window_size):
4463 Check for integer overflow.
4464 (x_set_alpha): Do not assume XINT fits in int.
4466 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4467 This is for the members text_lines, text_cols, total_lines, total_cols,
4468 where the system imposes an 'int' limit.
4470 * fringe.c (Fdefine_fringe_bitmap):
4471 Don't update size until alloc works.
4473 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4474 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4476 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4477 Check for size-calculation overflow.
4478 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4479 do, as we prefer signed integers.
4480 (id_to_widget.max_size, id_to_widget.used)
4481 (xg_store_widget_in_map, xg_remove_widget_from_map)
4482 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4483 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4484 Use and return ptrdiff_t, not int.
4485 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4486 * gtkutil.h: Change prototypes to match the above.
4488 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4489 are duplicate now that they've been promoted to lisp.h.
4490 (x_allocate_bitmap_record, x_alloc_image_color)
4491 (make_image_cache, cache_image, xpm_load):
4492 Don't update size until alloc is done.
4493 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4495 Check for size calculation overflow.
4496 (ct_colors_allocated_max): New constant.
4497 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4500 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4501 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4502 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4503 Use ptrdiff_t, not int, to count maps.
4504 (read_char_minibuf_menu_prompt): Check for overflow in size
4505 calculations. Don't update size until allocation succeeds.
4506 Redo calculations to avoid overflow.
4507 * keyboard.h: Change prototypes to match the above.
4509 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4511 (current_minor_maps): Check for size calculation overflow.
4512 * keymap.h: Change prototypes to match the above.
4514 * lread.c (read1, init_obarray): Don't update size until alloc done.
4516 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4517 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4519 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4520 Now ptrdiff_t, not int.
4521 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4522 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4524 * process.c (Fnetwork_interface_list): Check for overflow
4525 in size calculation.
4527 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4529 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4530 overflow. Don't bother calling xmalloc when xrealloc will do.
4532 * search.c (Freplace_match): Check for size calculation overflow.
4533 (Fset_match_data): Don't assume list lengths fit in 'int'.
4535 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4536 for command line length. Do not attempt to address one before the
4537 beginning of an array, as that's not portable.
4539 * term.c (max_frame_lines): Remove; unused.
4540 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4542 (encode_terminal_code, calculate_costs): Check for size
4543 calculation overflow.
4544 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4545 table lengths and related sizes. Don't update size until alloc
4546 done. Redo calculations to avoid overflow.
4547 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4549 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4550 subtracting pointers.
4551 (gobble_line): Check for overflow more carefully. Don't update size
4554 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4555 Don't update size until alloc done.
4556 Redo size calculations to avoid overflow.
4557 Check for size calculation overflow.
4558 (main) [DEBUG]: Fix typo in invoking tparam1.
4560 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4561 Use ptrdiff_t, not int, for sizes.
4562 (store_mode_line_noprop_char): Don't update size until alloc done.
4564 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4565 Use ptrdiff_t, not int, for sizes.
4566 (Finternal_make_lisp_face, cache_face):
4567 Check for size calculation overflow.
4568 (cache_face): Treat size calculation overflows as if they were
4569 memory exhaustion (the usual treatment), rather than aborting.
4571 * xfns.c (x_encode_text, x_set_name_internal)
4572 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4573 sizes, since they can exceed INT_MAX in size. Check for size
4574 calculation overflow.
4576 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4577 (xg_select): Check for size calculation overflow.
4578 Don't update size until alloc done.
4580 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4581 as sprintf is limited to int lengths.
4583 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4584 (X_LONG_MIN): New macros.
4585 Use them to make the following changes clearer.
4586 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4587 This change doesn't affect the value now, but it may help remind
4588 future maintainers not to raise the value too much later.
4589 (SELECTION_QUANTUM): Remove, replacing with ...
4590 (selection_quantum): ... new function, which avoids overflow.
4592 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4593 assumption that selection length fits in 'int'.
4594 (x_reply_selection_request, x_handle_selection_request)
4595 (x_get_window_property, receive_incremental_selection)
4596 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4597 (lisp_data_to_selection_data, clean_local_selection_data):
4598 Use ptrdiff_t, not int, to record length of selection.
4599 (x_reply_selection_request, x_get_window_property)
4600 (receive_incremental_selection, x_property_data_to_lisp):
4601 Redo calculations to avoid overflow.
4602 (x_reply_selection_request): When sending hint, ceiling it at
4603 X_LONG_MAX rather than relying on wraparound overflow to send
4605 (x_get_window_property, receive_incremental_selection)
4606 (lisp_data_to_selection_data, x_property_data_to_lisp):
4607 Check for size-calculation overflow.
4608 (x_get_window_property, receive_incremental_selection)
4609 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4610 Don't store size until memory allocation succeeds.
4611 (x_get_window_property): Plug memory leak on memory exhaustion.
4612 Don't double-block input; malloc is safe here. Don't assume 2**34
4613 - 4 fits in unsigned long. Add an xassert to check
4614 XGetWindowProperty overflow. Be more careful about overflow
4615 calculations, and distinguish size from memory overflow better.
4616 (receive_incremental_selection): When tracing, don't assume
4617 unsigned int is less than INT_MAX.
4618 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4619 harmful) conversions of unsigned short to int.
4620 (lisp_data_to_selection_data): Don't assume that integers
4621 in the range -65535 through -1 fit in an X unsigned short.
4622 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4623 result parameters unless successful. Rely on cons_to_unsigned
4624 to report problems with elements; the old code wasn't right anyway.
4625 (x_check_property_data): Check for int overflow; we cannot use
4626 a wider type due to X limits.
4627 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4629 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4631 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4632 (x_term_init): Check for size calculation overflow.
4633 (x_color_cells): Don't store size until memory allocation succeeds.
4634 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4635 Don't assume alloca size is less than MAX_ALLOCA.
4636 (x_term_init): Don't assume length fits in int (sprintf is limited
4639 Use ptrdiff_t for composition IDs.
4640 * character.c (lisp_string_width):
4641 * composite.c (composition_table_size, n_compositions)
4642 (get_composition_id, composition_gstring_from_id):
4643 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4644 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4645 * window.c (Frecenter):
4646 Use ptrdiff_t, not int, for composition IDs.
4647 * composite.c (get_composition_id): Check for integer overflow.
4648 * composite.h: Adjust prototypes to match the above changes.
4650 Use ptrdiff_t for hash table indexes.
4651 * category.c (hash_get_category_set):
4652 * ccl.c (ccl_driver):
4653 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4654 * coding.c (coding_system_charset_list, detect_coding_system):
4655 * coding.h (struct coding_system.id):
4656 * composite.c (get_composition_id, gstring_lookup_cache):
4657 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4658 * image.c (xpm_get_color_table_h):
4659 * lisp.h (hash_lookup, hash_put):
4660 * minibuf.c (Ftest_completion):
4661 Use ptrdiff_t for hash table indexes, not int (which is too
4662 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4663 32-bit --with-wide-int hosts).
4665 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4666 Add a FIXME comment about memory leaks.
4667 (syms_of_charset): Don't assume xmalloc returns.
4669 Don't assume that stated character widths fit in int.
4670 * character.c (Fchar_width, c_string_width, lisp_string_width):
4671 * character.h (CHAR_WIDTH):
4672 * indent.c (MULTIBYTE_BYTES_WIDTH):
4673 Use sanitize_char_width to avoid undefined and/or bad behavior
4674 with outlandish widths.
4675 * character.h (sanitize_tab_width): Rename from sanitize_width,
4676 now that we have two such functions. All uses changed.
4677 (sanitize_char_width): New inline function.
4679 Don't assume that tab-width fits in int.
4680 * character.h (sanitize_width): New inline function.
4681 (SANE_TAB_WIDTH): New macro.
4682 (ASCII_CHAR_WIDTH): Use it.
4683 * indent.c (sane_tab_width): Remove. All uses replaced by
4684 SANE_TAB_WIDTH (current_buffer).
4685 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4687 * fileio.c: Integer overflow issues with file modes.
4688 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4690 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4691 Remove unreachable code.
4692 (read_hex, load_charset_map_from_file): Check for integer overflow.
4694 * xterm.c: Don't go over XClientMessageEvent limit.
4695 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4696 (x_send_scroll_bar_event): Likewise. Check that the size does not
4697 exceed limits imposed by XClientMessageEvent, as well as the usual
4698 ptrdiff_t and size_t limits.
4700 * keyboard.c: Overflow, signedness and related fixes.
4701 (make_lispy_movement): Use same integer type in forward decl
4702 that is used in the definition.
4703 (read_key_sequence, keyremap_step):
4704 Change bufsize argument back to int, undoing my 2011-03-30 change.
4705 We prefer signed types, and int is wide enough here.
4706 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4707 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4708 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4709 length, not size_t. Use ptrdiff_t for index, not int.
4710 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4711 possibility of integer overflow.
4713 Overflow, signedness and related fixes for images.
4715 * dispextern.h (struct it.stack[0].u.image.image_id)
4716 (struct_it.image_id, struct image.id, struct image_cache.size)
4717 (struct image_cache.used, struct image_cache.ref_count):
4718 * gtkutil.c (update_frame_tool_bar):
4719 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4720 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4721 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4722 * nsmenu.m (update_frame_tool_bar):
4723 * xdisp.c (calc_pixel_width_or_height):
4724 * xfns.c (image_cache_refcount):
4725 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4726 on typical 64-bit hosts.
4728 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4729 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4730 Omit unnecessary casts to int.
4731 (parse_image_spec): Check that integers fall into 'int' range
4732 when the callers expect that.
4733 (image_ascent): Redo ascent calculation to avoid int overflow.
4734 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4735 (lookup_image): Remove unnecessary tests.
4736 (xbm_image_p): Locals are now of int, not EMACS_INT,
4737 since parse_image_check makes sure they fit into int.
4738 (png_load, gif_load, svg_load_image):
4739 Prefer int to unsigned where either will do.
4740 (tiff_handler): New function, combining the cores of the
4741 old tiff_error_handler and tiff_warning_handler.
4742 This function is rewritten to use vsnprintf and thereby avoid
4743 stack buffer overflows. It uses only the features of vsnprintf
4744 that are common to both POSIX and native Microsoft.
4745 (tiff_error_handler, tiff_warning_handler): Use it.
4746 (tiff_load, gif_load, imagemagick_load_image):
4747 Don't assume :index value fits in 'int'.
4748 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4749 (imagemagick_load_image): Check that crop parameters fit into
4750 the integer types that MagickCropImage accepts. Don't assume
4751 Vimagemagick_render_type has a nonnegative value. Don't assume
4752 size_t fits in 'long'.
4753 (gs_load): Use printmax_t to print the widest integers possible.
4754 Check for integer overflow when computing image height and width.
4756 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4758 * xdisp.c (redisplay_window): Don't force window start if point
4759 will be invisible in the resulting window. (Bug#9324)
4761 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4763 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4764 the display spec is of the form `(space ...)'.
4765 (handle_display_spec): Return the value returned by
4766 handle_single_display_spec, not just 1 or zero.
4767 (handle_single_display_spec): If the display spec is of the form
4768 `(space ...)', and specifies display in the text area, return 2
4770 (try_cursor_movement): Check for the need to scroll more
4771 accurately, and prefer exact match for point under bidi.
4772 Don't advance `row' beyond the last row of the window.
4774 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4775 into disp_prop; all users changed.
4777 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4778 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4779 for the text covered by the display property.
4781 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4783 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4784 Change return value to nil.
4785 (Frecord_buffer): Delete unused function.
4787 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4789 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4790 buffers, return left-to-right.
4791 (set_cursor_from_row): Consider candidate row a win if its glyph
4792 represents a newline and point is on that newline. Fixes cursor
4793 positioning on the newline at EOL of R2L text within L2R
4794 paragraph, and vice versa.
4795 (try_cursor_movement): Check continued rows, in addition to
4796 continuation rows. Fixes unwarranted scroll when point enters a
4797 continued line of R2L text within an L2R paragraph, or vice versa.
4798 (cursor_row_p): Consider the case of point being equal to
4799 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4800 from the end of a short line to the beginning of a continued line
4801 of R2L text within L2R paragraph.
4802 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4803 composed characters.
4805 * bidi.c (bidi_check_type): Use xassert.
4806 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4809 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4811 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4814 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4816 * nsfont.m (ns_otf_to_script): Fix typo.
4818 2011-08-22 Kenichi Handa <handa@m17n.org>
4820 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4821 extra slot even if the purpose is char-code-property-table.
4823 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4825 * xdisp.c (redisplay_window): When computing centering_position,
4826 account for the height of the header line. (Bug#8874)
4828 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4829 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4830 candidate is selected by the mouse, and that candidate has a
4831 composed character under the mouse.
4833 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4834 coordinates reported by pos-visible-in-window-p for a composed
4835 character in column zero.
4837 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4839 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4841 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4843 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4844 consider it a hit if to_charpos is anywhere in the range of the
4845 composed buffer positions.
4847 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4849 * image.c (gif_load): Don't assume that each subimage has the same
4850 dimensions as the base image. Handle disposal method that is
4851 "undefined" by the gif spec (Bug#9335).
4853 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4855 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4856 (Fcondition_case): Document `debug' symbol in error handler.
4858 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4860 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4861 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4862 from an Org mode buffer to a Speedbar frame.
4864 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4865 a composition, take its buffer position from IT->cmp_it.charpos.
4866 Fixes cursor positioning at the beginning of a line that begins
4867 with a composed character.
4869 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4871 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4872 character bidirectional type, use STRONG_L instead. Fixes crashes
4873 in a buffer produced by `describe-categories'.
4875 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4876 members before the level stack, so they would be saved and
4877 restored when copying iterator state. Fixes incorrect reordering
4878 around TABs covered by display properties.
4880 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4882 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4884 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4886 * eval.c (internal_condition_case, internal_condition_case_1)
4887 (internal_condition_case_2, internal_condition_case_n):
4888 Remove unnecessary aborts (Bug#9081).
4890 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4892 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4893 has no `load' handler, try opening the file locally. (Bug#9311)
4895 2011-08-16 Ken Brown <kbrown@cornell.edu>
4897 * gmalloc.c: Expand comment.
4899 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4901 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4902 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4904 2011-08-16 Ken Brown <kbrown@cornell.edu>
4906 Fix memory allocation problems in Cygwin build (Bug#9273).
4908 * unexcw.c ( __malloc_initialized): Declare external variable.
4909 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4911 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4913 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4915 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4917 [CYGWIN] (special_realloc): New function.
4918 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4919 requests to realloc storage in the static heap.
4921 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4923 * bidi.c (bidi_initialize): Remove unused local.
4925 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4928 * biditype.h: Remove file.
4929 * makefile.w32-in ($(BLD)/bidi.$(O)):
4930 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4932 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4934 * chartab.c: Improve commentary for the uniprop_table API.
4936 * bidi.c (bidi_paragraph_init): Support zero value of
4937 bidi_ignore_explicit_marks_for_paragraph_level.
4938 (bidi_initialize): Use uniprop_table instead of including
4939 biditype.h and bidimirror.h.
4941 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4942 coordinates of the iterator when restoring from ppos_it.
4945 2011-08-14 Kenichi Handa <handa@m17n.org>
4947 * process.c (create_process): Call setup_process_coding_systems
4948 after the pid of the process is set to -1 (Bug#8162).
4950 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4952 * xdisp.c (move_it_in_display_line_to): Don't invoke
4953 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4954 ppos_it. Fixes vertical cursor motion when line beginning is
4955 covered by an image. (Bug#9296)
4957 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4959 * nsterm.h (ns_run_ascript): Declare.
4960 (NSAPP_DATA2_RUNASSCRIPT): Define.
4962 * nsfns.m (as_script, as_result, as_status): New static variables.
4963 (ns_run_ascript): New function.
4964 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4965 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4966 the event loop. Get status from as_status (Bug#7276).
4968 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4969 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4970 the event loop (Bug#7276).
4972 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4974 * gnutls.c (QCgnutls_bootprop_priority)
4975 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4976 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4977 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4978 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4979 (QCgnutls_bootprop_verify_hostname_error)
4980 (QCgnutls_bootprop_callbacks_verify): Rename from
4981 Qgnutls_bootprop_..., all uses changed.
4983 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4986 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4988 * xfaces.c (Qframe_set_background_mode): Now static.
4989 * dispextern.h (Qframe_set_background_mode): Remove decl.
4991 * process.c (Fnetwork_interface_info): Declare local only if needed.
4993 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4995 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4996 (Fnetwork_interface_list): Allocate in increments of bytes instead
4997 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4998 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5000 (struct ifflag_def): notrailers is smart on OSX.
5001 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5002 Get hardware address with getifaddrs if available.
5004 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5006 * xdisp.c (iterate_out_of_display_property): xassert that
5007 IT->position is set to within IT->object's boundaries. Break from
5008 the loop as soon as EOB is reached; avoids infloops in redisplay
5009 when IT->position is set up wrongly due to some bug.
5010 Set IT->current to match the bidi iterator unconditionally.
5011 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5012 entry. Force push_it to save on the stack the current
5013 buffer/string position, to be restored by pop_it. Fix flags in
5014 the iterator structure wrt the object coming from a display
5015 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5016 properties. (Bug#9284)
5018 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5020 * fontset.c (fontset_get_font_group): Add proper type checks.
5023 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5025 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5026 and LC_VERSION_MIN_MACOSX.
5027 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5028 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5030 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5032 * xdisp.c (forward_to_next_line_start): Allow to use the
5033 no-display-properties-and-no-overlays under bidi display.
5034 Set disp_pos in the bidi iterator to avoid searches for display
5035 properties and overlays.
5037 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5039 * editfns.c (Fset_time_zone_rule): Document relationship with the
5042 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5043 the font entity extracted from the cache (Bug#8109).
5045 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5047 * composite.c (autocmp_chars): Don't reset point. That is done by
5048 restore_point_unwind (Bug#5984).
5050 2011-08-07 Juri Linkov <juri@jurta.org>
5052 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5053 to show the arg `TIME' instead of `TIMEVAL'.
5055 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5057 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5058 display property strides EOL and includes a newline, as in
5059 longlines-mode. (Bug#9254)
5060 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5061 word-wrap under bidirectional display. (Bug#9224)
5063 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5064 is non-zero, even if the data buffer is NULL. Fixes a crash in
5065 vertical-motion with longlines-mode. (Bug#9254)
5067 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5069 * bidi.c <bidi_cache_total_alloc>: Now static.
5070 (bidi_initialize): Initialize bidi_cache_total_alloc.
5072 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5075 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5076 amount allocated this far in `bidi_cache_total_alloc'.
5077 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5078 non-zero, only free the data buffer without restoring the cache
5079 contents. All callers changed.
5081 * dispextern.h (bidi_unshelve_cache): Update prototype.
5083 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5084 (move_it_in_display_line, move_it_to)
5085 (move_it_vertically_backward, move_it_by_lines): Replace the call
5086 to xfree to an equivalent call to bidi_unshelve_cache.
5087 (move_it_in_display_line_to): Fix logic of returning
5088 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5090 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5092 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5093 came from a string character with a `cursor' property. (Bug#9229)
5095 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5097 * Makefile.in (LIB_PTHREAD): New variable.
5098 (LIBES): Add LIB_PTHREAD (Bug#9216).
5100 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5101 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5103 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5105 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5107 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5109 * xterm.c (x_find_topmost_parent): New function.
5110 (x_set_frame_alpha): Find topmost parent window with
5111 x_find_topmost_parent and set the property there also (bug#9181).
5112 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5114 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5116 * callproc.c (Fcall_process): Avoid vfork clobbering
5117 the local vars buffer, coding_systems, current_dir.
5119 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5121 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5123 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5125 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5126 so that it is not optimized away.
5128 * xdisp.c (compute_display_string_pos): Remove unused local.
5130 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5132 Fix slow cursor motion and scrolling in large buffers with
5133 selective display, like Org Mode buffers. (Bug#9218)
5135 * dispextern.h (struct bidi_it): New member disp_prop_p.
5137 * xdisp.c: Remove one-slot cache of display string positions.
5138 (compute_display_string_pos): Accept an additional argument
5139 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5140 for a display string or property. If found, set DISP_PROP_P
5143 * bidi.c (bidi_fetch_char): Accept an additional argument
5144 DISP_PROP_P, and pass it to compute_display_string_pos.
5145 Only handle text covered by a display string if DISP_PROP_P is returned
5146 non-zero. All callers of bidi_fetch_char changed.
5148 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5150 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5152 2010-12-03 Don March <don@ohspite.net>
5154 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5155 last character M-[char] is translated to ESC [char] (bug#7541).
5157 2011-08-02 Kenichi Handa <handa@m17n.org>
5159 * lisp.h (uniprop_table): Extern it.
5161 * chartab.c (uniprop_table): Make it non-static.
5163 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5165 * xdisp.c (forward_to_next_line_start): Accept additional argument
5166 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5168 (reseat_at_next_visible_line_start): Use the bidi iterator state
5169 returned by forward_to_next_line_start to restore the state of
5170 it->bidi_it after backing up to previous newline. (Bug#9212)
5172 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5174 * regex.c (re_comp): Protoize.
5175 (re_exec): Fix return type.
5176 (regexec): Fix type of `ret'. (Bug#9203)
5178 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5180 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5181 This is needed if max-image-size is a floating-point number.
5183 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5185 * print.c (print_object): Print empty symbol as ##.
5187 * lread.c (read1): Read ## as empty symbol.
5189 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5191 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5192 setting frame foreground color (Bug#9175).
5193 (x_set_background_color): Likewise.
5195 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5196 contents (Bug#9176).
5197 (EmacsTooltip -init): Remove bezels and add shadows to
5200 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5201 or scroll bar (Bug#8470).
5203 * nsfont.m (nsfont_open): Remove assignment to voffset and
5204 unnecessary vars hshink, expand, hd, full_height, min_height.
5205 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5207 * nsterm.h (nsfont_info): Remove voffset field.
5209 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5211 Implement strike-through and overline on NextStep (Bug#8863).
5213 * nsfont.m (nsfont_open): Use underline position provided by font,
5214 instead of hard-coded value of 2.
5215 (nsfont_draw): Call ns_draw_text_decoration instead.
5217 * nsterm.h: Add declaration for ns_draw_text_decoration.
5219 * nsterm.m (ns_draw_text_decoration): New function for drawing
5220 underline, overline, and strike-through.
5221 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5222 ns_draw_text_decoration. Change treatment of cursor drawing to
5223 accommodate underlining, etc.
5225 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5227 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5230 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5232 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5233 Without this fix, if a signal arrives just after memory fills up,
5234 'malloc' might be invoked reentrantly.
5236 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5237 In other words, assume that every image size is allowed, on non-X
5238 hosts. This assumption is probably wrong, but it lets Emacs compile.
5240 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5242 * regex.c (re_iswctype): Convert return values to boolean.
5244 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5246 * xdisp.c (compute_display_string_pos): Don't use cached display
5247 string position if the buffer had its restriction changed.
5250 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5252 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5254 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5256 Integer signedness and overflow and related fixes. (Bug#9079)
5258 * bidi.c: Integer size and overflow fixes.
5259 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5260 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5261 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5262 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5263 (bidi_find_other_level_edge):
5264 Use ptrdiff_t instead of EMACS_INT where either will do.
5265 This works better on 32-bit hosts configured --with-wide-int.
5266 (bidi_cache_ensure_space): Check for size-calculation overflow.
5267 Use % rather than repeated addition, for better worst-case speed.
5268 Don't set bidi_cache_size until after xrealloc returns, because it
5270 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5271 (bidi_cache_ensure_space): Also check that the bidi cache size
5272 does not exceed that of the largest Lisp string or buffer. See Eli
5273 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5275 * alloc.c (__malloc_size_t): Remove.
5276 All uses replaced by size_t. See Andreas Schwab's note
5277 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5279 * image.c: Improve checking for integer overflow.
5280 (check_image_size): Assume that f is nonnull, since
5281 it is always nonnull in practice. This is one less thing to
5282 worry about when checking for integer overflow later.
5283 (x_check_image_size): New function, which checks for integer
5284 overflow issues inside X.
5285 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5286 This removes the need for a memory_full check.
5287 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5288 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5289 (xbm_read_bitmap_data): Change locals back to 'int', since
5290 their values must fit in 'int'.
5291 (xpm_load_image, png_load, tiff_load):
5292 Invoke x_create_x_image_and_pixmap earlier,
5293 to avoid much needless work if the image is too large.
5294 (tiff_load): Treat overly large images as if
5295 x_create_x_image_and_pixmap failed, not as malloc failures.
5296 (gs_load): Use x_check_image_size.
5298 * gtkutil.c: Omit integer casts.
5299 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5300 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5302 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5304 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5305 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5306 would wrongly return t on a 64-bit host.
5308 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5309 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5310 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5311 and therefore cause GCC to emit a bogus diagnostic in some cases.
5313 * image.c: Integer signedness and overflow and related fixes.
5314 This is not an exhaustive set of fixes, but it's time to
5315 record what I've got.
5316 (lookup_pixel_color, check_image_size): Remove redundant decls.
5317 (check_image_size): Don't assume that arbitrary EMACS_INT values
5318 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5319 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5320 (tiff_load, imagemagick_load_image):
5321 Check for overflow in size calculations.
5322 (x_create_x_image_and_pixmap): Remove unnecessary test for
5323 xmalloc returning NULL; that can't happen.
5324 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5325 (xpm_color_bucket): Use better integer hashing function.
5326 (xpm_cache_color): Don't possibly over-allocate memory.
5327 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5328 (gif_memory_source):
5329 Use ptrdiff_t, not int or size_t, to record sizes.
5330 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5331 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5332 either works, as we prefer signed integers.
5333 (tiff_read_from_memory, tiff_write_from_memory):
5334 Return tsize_t, not size_t, since that's what the TIFF API wants.
5335 (tiff_read_from_memory): Don't fail simply because the read would
5336 go past EOF; instead, return a short read.
5337 (tiff_load): Omit no-longer-needed casts.
5338 (Fimagemagick_types): Don't assume size fits into 'int'.
5340 Improve hashing quality when configured --with-wide-int.
5341 * fns.c (hash_string): New function, taken from sxhash_string.
5342 Do not discard information about ASCII character case; this
5343 discarding is no longer needed.
5344 (sxhash-string): Use it. Change sig to match it. Caller changed.
5345 * lisp.h: Declare it.
5346 * lread.c (hash_string): Remove, since we now use fns.c's version.
5347 The fns.c version returns a wider integer if --with-wide-int is
5348 specified, so this should help the quality of the hashing a bit.
5350 * emacs.c: Integer overflow minor fix.
5351 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5352 Define only if GNU_LINUX.
5353 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5355 * dispnew.c: Integer signedness and overflow fixes.
5356 Remove unnecessary forward decls, that were a maintenance hassle.
5357 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5359 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5360 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5361 (prepare_desired_row, line_draw_cost):
5362 Use int, not unsigned, where either works.
5363 (save_current_matrix, restore_current_matrix):
5364 Use ptrdiff_t, not size_t, where either works.
5365 (init_display): Check for overflow more accurately, and without
5366 relying on undefined behavior.
5368 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5369 Remove, replacing with the new symbols in lisp.h. All uses changed.
5370 * fileio.c (make_temp_name):
5371 * filelock.c (lock_file_1, lock_file):
5372 * xdisp.c (message_dolog):
5373 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5374 Use pMd etc. instead.
5375 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5376 replacing the pWIDE etc. symbols removed from editfns.c.
5378 * keyboard.h (num_input_events): Now uintmax_t.
5379 This is (very slightly) less likely to mess up due to wraparound.
5382 * buffer.c: Integer signedness fixes.
5383 (alloc_buffer_text, enlarge_buffer_text):
5384 Use ptrdiff_t rather than size_t when either will do, as we prefer
5387 * alloc.c: Integer signedness and overflow fixes.
5388 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5389 (__malloc_size_t): Default to size_t, not to int.
5390 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5391 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5392 Prefer ptrdiff_t to size_t when either would do, as we prefer
5394 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5395 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5396 Now const. Initialize with values that are in range even if char
5398 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5399 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5400 These functions do the right thing with sizes > 2**32.
5401 (check_depth): Now ptrdiff_t, not int.
5402 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5403 Adjust to new way of storing sizes. Check for size overflow bugs
5405 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5406 slightly wrong anyway, as it missed one instance of
5407 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5408 (refill_memory_reserve): Omit needless cast to size_t.
5409 (mark_object_loop_halt): Mark as externally visible.
5411 * xselect.c: Integer signedness and overflow fixes.
5412 (Fx_register_dnd_atom, x_handle_dnd_message):
5413 Use ptrdiff_t, not size_t, since we prefer signed.
5414 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5415 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5416 x_dnd_atoms_size and x_dnd_atoms_length.
5418 * doprnt.c: Prefer signed to unsigned when either works.
5420 * doprnt.c (doprnt):
5422 * xdisp.c (vmessage):
5423 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5424 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5425 prefer signed arithmetic to avoid comparison confusion.
5426 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5427 but is a bit tricky.
5429 Assume freestanding C89 headers, string.h, stdlib.h.
5430 * data.c, doprnt.c, floatfns.c, print.c:
5431 Include float.h unconditionally.
5432 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5433 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5434 * regex.c: Likewise for stddef.h, string.h.
5435 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5436 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5437 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5438 (STDC_HEADERS): Remove obsolete defines.
5439 * sysdep.c: Include limits.h unconditionally.
5441 Assume support for memcmp, memcpy, memmove, memset.
5442 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5443 * regex.c (memcmp, memcpy):
5444 Remove; we assume C89 now.
5446 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5447 (__malloc_safe_bcopy): Remove; no longer needed.
5449 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5450 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5451 well either way, and we prefer signed to unsigned.
5453 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5455 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5456 closes the connection while we're reading (bug#9182).
5458 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5460 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5461 are specified (Bug#9168).
5463 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5465 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5466 Found by GCC static checking and --with-wide-int on a 32-bit host.
5468 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5470 * xdisp.c (compute_display_string_pos): Fix logic of caching
5471 previous display string position. Initialize cached_prev_pos to
5472 -1. Fixes slow-down at the beginning of a buffer.
5474 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5476 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5477 for attrs[LFACE_FONTSET_INDEX].
5479 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5481 * xml.c (parse_region): Remove unused local
5482 that was recently introduced.
5484 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5486 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5487 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5489 * xdisp.c (move_it_in_display_line_to): Record the best matching
5490 position for TO_CHARPOS while scanning the line, and restore it on
5491 exit if none of the characters scanned was an exact match.
5492 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5493 when exact match is impossible due to invisible text, and the
5494 lines are truncated.
5496 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5498 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5501 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5503 Fix a significant slow-down of cursor motion with C-n, C-p,
5504 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5505 auto-repeat under bidi redisplay in fontified buffers.
5506 * xdisp.c (compute_stop_pos_backwards): New function.
5507 (next_element_from_buffer): Call compute_stop_pos_backwards to
5508 find a suitable prev_stop when we find ourselves before
5510 (reseat): Don't look for prev_stop, as that could mean a very long
5512 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5513 <cached_disp_overlay_modiff>: Cache for last found display string
5515 (compute_display_string_pos): Return the cached position if asked
5516 about the same buffer in the same area of character positions, and
5517 the buffer wasn't changed since the time the display string
5518 position was cached.
5520 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5522 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5523 is an integer, which is important for empty lines. (Bug#9149)
5525 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5527 * frame.c (Fmodify_frame_parameters): In tty case, update the
5528 default face if necessary (Bug#4238).
5530 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5532 * editfns.c (Fstring_to_char): No need to explain what a character
5533 is in the docstring (Bug#6576).
5535 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5537 * xml.c (parse_region): Make sure we always return a tree.
5539 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5541 * xml.c (parse_region): If a document contains only comments,
5544 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5546 * xml.c (make_dom): Return comments, too.
5548 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5551 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5552 and the surrounding thread.
5553 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5554 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5555 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5557 * s/openbsd.h (BROKEN_SIGIO): Define.
5558 * unexelf.c (unexec) [__OpenBSD__]:
5559 Don't update the .mdebug section of the Alpha COFF symbol table.
5561 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5563 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5566 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5568 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5569 This fixes some race conditions on the permissions of any newly
5572 * alloc.c (valid_pointer_p): Use pipe, not open.
5573 This fixes some permissions issues when debugging.
5575 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5576 If fchown fails to set both uid and gid, try to set just gid,
5577 as that is sometimes allowed. Adjust the file's mode to eliminate
5578 setuid or setgid bits that are inappropriate if fchown fails.
5580 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5582 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5583 to compare Lisp_Objects.
5584 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5585 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5586 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5588 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5590 * lread.c (read_integer): Unread even EOF character.
5591 (read1): Likewise. Properly record start position of symbol.
5593 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5594 symbol character follows.
5596 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5598 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5599 This works around a problem with the previous change to Fcopy_file.
5600 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5601 and without this change, GCC might complain about discarding
5602 fchown's return value.
5604 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5606 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5608 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5610 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5612 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5614 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5615 it's used from the C level.
5617 * process.c: Use the same condition for POLL_FOR_INPUT in both
5618 keyboard.c and process.c (bug#1858).
5620 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5622 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5623 (Fgnutls_boot): Use it.
5625 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5627 * doc.c (Fsubstitute_command_keys): Revert last change.
5629 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5631 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5632 quotes the next character, and doesn't affect other longer
5633 sequences (bug#8935).
5635 * lread.c (syms_of_lread): Clarify that is isn't only
5636 `eval-buffer' and `eval-defun' that's affected by
5637 `lexical-binding' (bug#8460).
5639 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5641 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5642 bidi redisplay when a line includes both an image and is truncated.
5644 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5646 Fix minor problems found by static checking.
5647 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5648 (elsz): Now a signed constant, not a size_t var. We prefer signed
5649 types to unsigned, to avoid integer comparison confusion. Without
5650 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5651 "cannot optimize loop, the loop counter may overflow", a symptom
5653 * indent.c (Fvertical_motion): Mark locals as initialized.
5654 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5656 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5658 * search.c (Fre_search_backward): Mention `case-fold-search' in
5659 all the re_search_* functions (bug#8138).
5661 * keyboard.c (Fopen_dribble_file): Document when the file is
5664 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5666 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5669 Support bidi reordering of display and overlay strings.
5670 * xdisp.c (compute_display_string_pos)
5671 (compute_display_string_end): Accept additional argument STRING.
5672 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5673 (reseat_to_string): Initialize bidi_it->string.s and
5674 bidi_it->string.schars.
5675 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5676 NULL (avoids a crash in bidi_paragraph_init).
5677 Initialize itb.string.lstring.
5678 (init_iterator): Call bidi_init_it only of a valid
5679 buffer position was specified. Initialize paragraph_embedding to
5681 (reseat_to_string): Initialize the bidi iterator.
5682 (display_string): If we need to ignore text properties of
5683 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5684 original value of -1 will not work with bidi.)
5685 (compute_display_string_pos): First arg is now struct
5686 `text_pos *'; all callers changed. Support display properties on
5688 (compute_display_string_end): Support display properties on Lisp
5690 (init_iterator, reseat_1, reseat_to_string): Initialize the
5691 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5692 when iterating on a string not from display properties).
5693 (compute_display_string_pos, compute_display_string_end):
5694 Fix calculation of the object to scan. Fixes an error when using
5696 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5697 base_level_stop; instead, set base_level_stop to BEGV.
5698 Fixes crashes in vertical-motion.
5699 (next_element_from_buffer): Improve commentary for when
5700 the iterator is before prev_stop.
5701 (init_iterator): Initialize bidi_p from the default value of
5702 bidi-display-reordering, not from buffer-local value. Use the
5703 buffer-local value only if initializing for buffer iteration.
5704 (handle_invisible_prop): Support invisible properties on strings
5705 that are being bidi-reordered.
5706 (set_iterator_to_next): Support bidi reordering of C strings and
5708 (next_element_from_string): Support bidi reordering of Lisp
5710 (handle_stop_backwards): Support Lisp strings as well.
5711 (display_string): Support display of R2L glyph rows.
5712 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5713 (init_iterator): Don't initialize it->bidi_p for strings
5715 (reseat_to_string): Initialize it->bidi_p for strings here.
5716 (next_element_from_string, next_element_from_c_string)
5717 (next_element_from_buffer): Add xassert's for correspondence
5718 between IT's object being iterated and it->bidi_it.string
5720 (face_before_or_after_it_pos): Support bidi iteration.
5721 (next_element_from_c_string): Handle the case of the first string
5722 character that is not the first one in the visual order.
5723 (get_visually_first_element): New function, refactored from common
5724 parts of next_element_from_buffer, next_element_from_string, and
5725 next_element_from_c_string.
5726 (tool_bar_lines_needed, redisplay_tool_bar)
5727 (display_menu_bar): Force left-to-right direction. Add a FIXME
5728 comment for making that be controlled by a user option.
5729 (push_it, pop_it): Save and restore the state of the
5730 bidi iterator. Save and restore the bidi_p flag.
5731 (pop_it): Iterate out of display property for string iteration as
5733 (iterate_out_of_display_property): Support iteration over strings.
5734 (handle_single_display_spec): Set up it->bidi_it for iteration
5735 over a display string, and call bidi_init_it.
5736 (handle_single_display_spec, next_overlay_string)
5737 (get_overlay_strings_1, push_display_prop): Set up the bidi
5738 iterator for displaying display or overlay strings.
5739 (forward_to_next_line_start): Don't use the shortcut if
5741 (back_to_previous_visible_line_start): If handle_display_prop
5742 pushed the iterator stack, restore the internal state of the bidi
5743 iterator by calling bidi_pop_it same number of times.
5744 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5745 and we are bidi-iterating, don't decrement the iterator position;
5746 instead, set the first_elt flag in the bidi iterator, to produce
5748 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5749 (push_display_prop): xassert that we are iterating a buffer.
5750 (push_it, pop_it): Save and restore paragraph_embedding member.
5751 (handle_single_display_spec, next_overlay_string)
5752 (get_overlay_strings_1, reseat_1, reseat_to_string)
5753 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5754 correctly. Don't assume unibyte strings are not bidi-reordered.
5755 (compute_display_string_pos)
5756 (compute_display_string_end): Fix handling the case of C string.
5757 (push_it, pop_it): Save and restore from_disp_prop_p.
5758 (handle_single_display_spec, push_display_prop): Set the
5759 from_disp_prop_p flag.
5760 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5761 (pop_it): Call iterate_out_of_display_property only if we are
5762 popping after iteration over a string that came from a display
5763 property. Fix a typo in popping stretch info. Add an assertion
5764 for verifying that the iterator position is in sync with the bidi
5766 (handle_single_display_spec, get_overlay_strings_1)
5767 (push_display_prop): Fix initialization of paragraph direction for
5768 string when that of the parent object is not yet determined.
5769 (reseat_1): Call bidi_init_it to resync the bidi
5770 iterator with IT's position. (Bug#7616)
5771 (find_row_edges): If ROW->start.pos gives position
5772 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5773 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5774 Reset the from_disp_prop_p flag.
5775 (SAVE_IT, RESTORE_IT): New macros.
5776 (pos_visible_p, face_before_or_after_it_pos)
5777 (back_to_previous_visible_line_start)
5778 (move_it_in_display_line_to, move_it_in_display_line)
5779 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5780 (try_scrolling, redisplay_window, display_line): Use them when
5781 saving a temporary copy of the iterator and restoring it back.
5782 (back_to_previous_visible_line_start, reseat_1)
5783 (init_iterator): Empty the bidi cache "stack".
5784 (move_it_in_display_line_to): If iterator ended up at
5785 EOL, but we never saw any buffer positions smaller than
5786 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5787 motion in bidi-reordered lines.
5788 (move_it_in_display_line_to): Record prev_method and prev_pos
5789 immediately before the call to set_iterator_to_next. Fixes cursor
5790 motion in bidi-reordered lines with stretch glyphs and strings
5791 displayed in margins. (Bug#8133) (Bug#8867)
5792 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5794 (pos_visible_p): Support positions in bidi-reordered lines.
5795 Save and restore bidi cache.
5797 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5798 (bidi_paragraph_info): Delete unused struct.
5799 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5800 (bidi_cache_start): New variable.
5801 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5803 (bidi_cache_fetch_state, bidi_cache_search)
5804 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5805 (bidi_cache_find, bidi_peek_at_next_level)
5806 (bidi_level_of_next_char, bidi_find_other_level_edge)
5807 (bidi_move_to_visually_next): Compare cache index with
5808 bidi_cache_start rather than with zero.
5809 (bidi_fetch_char): Accept new argument STRING; all callers
5810 changed. Support iteration over a string. Support strings with
5811 display properties. Support unibyte strings. Fix the type of
5812 `len' according to what STRING_CHAR_AND_LENGTH expects.
5813 (bidi_paragraph_init, bidi_resolve_explicit_1)
5814 (bidi_resolve_explicit, bidi_resolve_weak)
5815 (bidi_level_of_next_char, bidi_move_to_visually_next):
5816 Support iteration over a string.
5817 (bidi_set_sor_type, bidi_resolve_explicit_1)
5818 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5819 can now be zero (for strings); special values 0 and -1 were
5820 changed to -1 and -2, respectively.
5821 (bidi_char_at_pos): New function.
5822 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5823 Call it instead of FETCH_MULTIBYTE_CHAR.
5824 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5825 initialized to valid values.
5826 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5828 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5829 the test for valid cached positions. Fix the logic for looking up
5830 the sentinel state in the cache. GCPRO the Lisp string we are
5832 (bidi_push_it, bidi_pop_it): New functions.
5833 (bidi_initialize): Initialize the bidi cache start stack pointer.
5834 (bidi_cache_ensure_space): New function, refactored from part of
5835 bidi_cache_iterator_state. Don't assume the required size is just
5836 one BIDI_CACHE_CHUNK away.
5837 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5838 (bidi_count_bytes, bidi_char_at_pos): New functions.
5839 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5840 always valid if bidi_cache_idx is valid.
5841 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5842 is valid if it's going to be used.
5843 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5844 (bidi_cache_fetch_state, bidi_cache_search)
5845 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5846 (bidi_cache_iterator_state, bidi_cache_find)
5847 (bidi_find_other_level_edge, bidi_cache_start_stack):
5848 All variables related to cache indices are now EMACS_INT.
5850 * dispextern.h (struct bidi_string_data): New structure.
5851 (struct bidi_it): New member `string'. Make flag members be 1-bit
5852 fields, and put them last in the struct.
5853 (compute_display_string_pos, compute_display_string_end):
5855 (bidi_push_it, bidi_pop_it): Add prototypes.
5856 (struct iterator_stack_entry): New members bidi_p,
5857 paragraph_embedding, and from_disp_prop_p.
5858 (struct it): Member bidi_p is now a bit field 1 bit wide.
5859 (bidi_shelve_cache, bidi_unshelve_cache):
5862 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5863 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5864 and vector-like objects.
5866 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5867 cache around display iteration.
5869 * window.c (Fwindow_end, window_scroll_pixel_based)
5870 (displayed_window_lines, Frecenter): Save and restore the bidi
5871 cache around display iteration.
5873 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5875 * editfns.c (Fdelete_region): Clarify the use of the named
5876 parameters (bug#6788).
5878 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5880 * indent.c (Fvertical_motion): Set and restore w->pointm when
5881 saving and restoring the window's buffer (Bug#9006).
5883 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5885 * editfns.c (Fstring_to_char): Clarify just what is returned
5886 (bug#6576). Text by Eli Zaretskii.
5888 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5890 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5892 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5894 * buffer.c (mmap_find): Fix a typo.
5896 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5898 Fix execution of x selection hooks.
5899 * xselect.c (Qx_lost_selection_functions)
5900 (Qx_sent_selection_functions): New vars.
5901 (syms_of_xselect): DEFSYM them.
5902 (x_handle_selection_request): Pass Qx_sent_selection_functions
5903 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5904 (x_handle_selection_clear,x_clear_frame_selections):
5905 Pass Qx_lost_selection_functions rather than
5906 Vx_lost_selection_functions to Frun_hook_with_args.
5908 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5910 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5911 The old code sometimes used this field without initializing it.
5913 * alloc.c (gc_sweep): Don't read past end of array.
5914 In theory, the old code could also have corrupted Emacs internals,
5915 though it'd be very unlikely.
5917 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5919 * character.c (Fcharacterp): Don't advertise optional ignored
5920 argument. (Bug#4026)
5922 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5924 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5927 * window.c (Fset_window_start): Doc fix (bug#4199).
5928 (Fset_window_hscroll): Ditto.
5930 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5932 Fix minor new problems caught by GCC 4.6.1.
5933 * term.c (init_tty): Remove unused local.
5934 * xsettings.c (store_monospaced_changed): Define this function only
5935 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5938 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5940 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5942 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5944 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5945 are the mini-buffer and the echo area (bug#3320).
5947 * term.c (init_tty): Remove support for supdup, c10 and perq
5948 terminals, which are no longer supported (bug#1482).
5950 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5952 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5954 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5956 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5957 for non-popups (Bug#3642).
5959 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5961 * alloc.c (reset_malloc_hooks): Protoize.
5962 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5963 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5964 * cm.c (losecursor): Likewise.
5965 * data.c (fmod): Likewise.
5966 * dispnew.c (swap_glyphs_in_rows): Likewise.
5967 * emacs.c (memory_warning_signal): Likewise.
5968 * floatfns.c (float_error): Likewise.
5969 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5970 (otf_open, font_otf_capability, generate_otf_features)
5971 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5973 * image.c (pbm_read_file): Likewise.
5974 * indent.c (string_display_width): Likewise.
5975 * intervals.c (check_for_interval, search_for_interval)
5976 (inc_interval_count, count_intervals, root_interval)
5977 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5978 * lread.c (defalias): Likewise.
5979 * ralloc.c (r_alloc_check): Likewise.
5980 * regex.c (set_image_of_range_1, set_image_of_range)
5981 (regex_grow_registers): Likewise.
5982 * sysdep.c (strerror): Likewise.
5983 * termcap.c (valid_filename_p, tprint, main): Likewise.
5984 * tparam.c (main): Likewise.
5985 * unexhp9k800.c (run_time_remap, save_data_space)
5986 (update_file_ptrs, read_header, write_header, calculate_checksum)
5987 (copy_file, copy_rest, display_header): Likewise.
5988 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5990 * xdisp.c (check_it): Likewise.
5991 * xfaces.c (register_color, unregister_color, unregister_colors):
5993 * xfns.c (print_fontset_result): Likewise.
5994 * xrdb.c (member, fatal, main): Likewise.
5996 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5998 Fix minor problems found by static checking (Bug#9031).
5999 * chartab.c (char_table_set_range, map_sub_char_table):
6000 Remove unused locals.
6001 (uniprop_table): Now static.
6002 * composite.c (_work_char): Remove unused static var.
6004 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6006 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6008 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6010 * gtkutil.c (qttip_cb): Remove code without function.
6012 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6014 * w32.c (pthread_sigmask): New stub.
6016 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6018 Use pthread_sigmask, not sigprocmask (Bug#9010).
6019 sigprocmask is portable only for single-threaded applications, and
6020 Emacs can be multi-threaded when it uses GTK.
6021 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6023 * callproc.c (Fcall_process):
6024 * process.c (create_process):
6025 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6026 Use pthread_sigmask, not sigprocmask.
6028 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6030 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6031 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6034 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6036 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6037 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6038 (xg_hide_tooltip): Fix comment.
6040 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6041 in registerServicesMenuSendTypes.
6042 (validRequestorForSendType): Don't check ns_return_types.
6044 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6047 2011-07-08 Jason Rumney <jasonr@gnu.org>
6049 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6050 SH_SHOW for hidden windows (Bug#5482).
6052 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6053 frame struct members of non-existent frames (Bug#6284).
6055 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6057 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6058 variable firstTime not needed on OSX >= 10.6.
6059 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6060 >= 10.5. Use setKnobProportion, setDoubleValue.
6062 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6063 (MAC_OS_X_VERSION_10_5): Define if not defined.
6064 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6065 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6066 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6068 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6069 cString and lossyCString on OSX >= 10.4
6071 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6072 sizeToFit on OSX >= 10.2.
6074 * nsimage.m (allocInitFromFile): Don't use deprecated method
6075 bestRepresentationForDevice on OSX >= 10.6.
6077 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6080 * emacs.c: Declare unexec_init_emacs_zone.
6082 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6084 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6086 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6087 on svcsMenu (Bug#8842).
6089 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6091 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6093 * nsterm.m (QUTF8_STRING): Declare.
6094 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6095 (validRequestorForSendType): Return type is (id).
6096 Change indexOfObjectIdenticalTo to indexOfObject.
6097 Check if we have local selection before returning self (Bug#8842).
6098 (writeSelectionToPasteboard): Put local selection into paste board
6099 if we have a local selection (Bug#8842).
6100 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6102 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6103 (ns_get_local_selection): Declare.
6105 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6107 * keymap.c (describe_map_tree): Don't insert a double newline at
6108 the end of the buffer (bug#1169) and return whether we inserted
6111 * callint.c (Fcall_interactively): Change "reading args" to
6112 "providing args" to try to clarify what it does (bug#1010).
6114 2011-07-07 Kenichi Handa <handa@m17n.org>
6116 * composite.c (composition_compute_stop_pos): Ignore a static
6117 composition starting before CHARPOS (Bug#8915).
6119 * xdisp.c (handle_composition_prop): Likewise.
6121 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6123 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6126 2011-07-07 Kenichi Handa <handa@m17n.org>
6128 * character.h (unicode_category_t): New enum type.
6130 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6131 (Qchar_code_property_table): New variable.
6132 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6133 (UNIPROP_COMPRESSED_FORM_P): New macros.
6134 (char_table_ascii): Uncompress the compressed values.
6135 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6136 Uncompress the compressed values.
6137 (sub_char_table_ref_and_range): Likewise.
6138 (char_table_ref_and_range): Uncompress the compressed values.
6139 (sub_char_table_set): New arg is_uniprop. Callers changed.
6140 Uncompress the compressed values.
6141 (sub_char_table_set_range): Args changed. Callers changed.
6142 (char_table_set_range): Adjuted for the above change.
6143 (map_sub_char_table): Delete args default_val and parent. Add arg
6144 top. Give decoded values to a Lisp function.
6145 (map_char_table): Adjust for the above change. Give decoded
6146 values to a Lisp function. Gcpro more variables.
6147 (uniprop_table_uncompress)
6148 (uniprop_decode_value_run_length): New functions.
6149 (uniprop_decoder, uniprop_decoder_count): New variables.
6150 (uniprop_get_decoder, uniprop_encode_value_character)
6151 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6153 (uniprop_encoder, uniprop_encoder_count): New variables.
6154 (uniprop_get_encoder, uniprop_table)
6155 (Funicode_property_table_internal, Fget_unicode_property_internal)
6156 (Fput_unicode_property_internal): New functions.
6157 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6158 Sunicode_property_table_internal, Sget_unicode_property_internal,
6159 and Sput_unicode_property_internal. Defvar_lisp
6160 char-code-property-alist.
6162 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6163 Vunicode_category_table.
6165 * font.c (font_range): Adjust for the change of
6166 Vunicode_category_table.
6168 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6170 * m/iris4d.h: Remove file, move contents ...
6171 * s/irix6-5.h: ... here.
6173 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6175 Remove unportable assumption about struct layout (Bug#8884).
6176 * alloc.c (mark_buffer):
6177 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6178 (clone_per_buffer_values): Don't assume that
6179 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6180 This isn't true in general, and it's particularly not true
6181 if Emacs is configured with --with-wide-int.
6182 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6183 New macros, used in the buffer.c change.
6185 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6187 * xsettings.c: Use both GConf and GSettings if both are available.
6188 (store_config_changed_event): Add comment.
6189 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6190 (store_tool_bar_style_changed): New functions.
6191 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6192 (struct xsettings): Move font inside HAVE_XFT.
6193 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6194 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6195 Move inside HAVE_XFT.
6196 (something_changed_gsettingsCB): Rename from something_changedCB.
6197 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6199 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6200 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6201 (something_changed_gconfCB): Rename from something_changedCB.
6202 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6203 (parse_settings): Move check for font inside HAVE_XFT.
6204 (read_settings, apply_xft_settings): Add comment.
6205 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6206 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6207 call store_font_name_changed.
6208 (xft_settings_event): Add comment.
6209 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6210 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6211 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6212 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6213 (xsettings_initialize): Call init_gsettings last.
6214 (xsettings_get_system_font, xsettings_get_system_normal_font):
6217 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6219 Random fixes. E.g., (random) never returned negative values.
6220 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6221 subseconds part to the entropy, as that's a bit more random.
6222 Prefer signed to unsigned, since the signedness doesn't matter and
6223 in general we prefer signed. When given a limit, use a
6224 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6225 latter isn't right if USE_2_TAGS_FOR_INTS.
6226 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6227 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6229 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6231 * textprop.c (text_property_stickiness):
6232 Obey Vtext_property_default_nonsticky.
6233 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6234 * w32fns.c (syms_of_w32fns):
6235 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6237 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6239 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6240 This is more efficient than Ffile_directory_p and avoids a minor race.
6242 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6244 * buffer.c (Foverlay_put): Say what the return value is
6247 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6248 is a directory before asking whether to use the file name
6250 (barf_or_query_if_file_exists): Make the "File is a directory"
6251 error be more correct.
6253 * fns.c (Frequire): Remove the mention of the .gz files, since
6254 that's installation-specific, but keep the mention of
6255 `get-load-suffixes'.
6257 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6259 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6260 Report string overflow if the output is too long.
6262 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6264 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6265 (syms_of_gnutls): Remove duplicate DEFSYM for
6266 Qgnutls_bootprop_verify_hostname_error, an error for
6267 Qgnutls_bootprop_verify_error (which is no longer used).
6269 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6270 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6271 Also (re)move comments that are misplaced or no longer relevant.
6273 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6275 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6277 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6279 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6280 and background color parameters if they have been changed.
6282 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6284 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6286 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6288 * xsettings.c (SYSTEM_FONT): Define only when used.
6289 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6291 * keymap.c (access_keymap_1): Now static.
6293 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6295 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6296 leave any prefix arg for the up event (Bug#1586).
6298 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6300 * lread.c (syms_of_lread): Mention single symbols defined by
6301 `defvar' or `defconst' (bug#7154).
6303 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6304 (Frequire): Mention get-load-suffixes.
6306 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6308 * window.h (window): Remove clone_number slot.
6309 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6311 (make_parent_window, make_window, saved_window)
6312 (Fset_window_configuration, save_window_save): Don't deal with
6314 * buffer.c (Qclone_number): Remove declaration.
6315 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6317 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6319 Add multiple inheritance to keymaps.
6320 * keymap.c (Fmake_composed_keymap): New function.
6321 (Fset_keymap_parent): Simplify.
6322 (fix_submap_inheritance): Remove.
6323 (access_keymap_1): New function extracted from access_keymap to handle
6324 embedded parents and handle lists of maps.
6325 (access_keymap): Use it.
6326 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6327 (Fcopy_keymap): Handle embedded parents.
6328 (Fcommand_remapping, define_as_prefix): Simplify.
6329 (Fkey_binding): Simplify.
6330 (syms_of_keymap): Move minibuffer-local-completion-map,
6331 minibuffer-local-filename-completion-map,
6332 minibuffer-local-must-match-map, and
6333 minibuffer-local-filename-must-match-map to Elisp.
6334 (syms_of_keymap): Defsubr make-composed-keymap.
6335 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6336 (parse_menu_item): Trivial simplification.
6338 2011-07-01 Glenn Morris <rgm@gnu.org>
6340 * Makefile.in (SETTINGS_LIBS): Fix typo.
6342 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6344 * coding.c (Fencode_coding_string): Record the last coding system
6345 used, as the function doc string says (bug#8738).
6347 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6349 * xsettings.c (store_monospaced_changed): Take new font as arg and
6350 check for change against current_mono_font.
6351 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6352 (emacs_settings_constructor, emacs_settings_get_property)
6353 (emacs_settings_set_property, emacs_settings_class_init)
6354 (emacs_settings_init, gsettings_obj): Remove.
6355 (something_changedCB): New function for HAVE_GSETTINGS.
6356 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6357 with value as argument.
6358 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6359 g_settings_new (Bug#8967). Do not create gsettings_obj.
6360 Remove calls to g_settings_bind. Connect something_changedCB to
6363 * xgselect.c: Add defined (HAVE_GSETTINGS).
6364 (xgselect_initialize): Ditto.
6366 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6367 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6370 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6372 * eval.c (struct backtrace): Simplify and port the data structure.
6373 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6374 signed bit field, as this assumption is not portable and it makes
6375 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6376 "char debug_on_exit : 1" as this is not portable either; instead,
6377 use the portable "unsigned int debug_on_exit : 1". Remove unused
6378 member evalargs. Remove obsolete comments about cc bombing out.
6380 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6382 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6383 Let HAVE_GSETTINGS override HAVE_GCONF.
6384 (store_monospaced_changed): New function.
6385 (EMACS_SETTINGS): A new type derived from GObject to handle
6386 GSettings notifications.
6387 (emacs_settings_constructor, emacs_settings_get_property)
6388 (emacs_settings_set_property, emacs_settings_class_init):
6390 (gsettings_client, gsettings_obj): New variables.
6391 (GSETTINGS_SCHEMA): New define.
6392 (something_changedCB): Call store_monospaced_changed.
6393 (init_gsettings): New function.
6394 (xsettings_initialize): Call init_gsettings.
6395 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6398 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6401 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6403 * window.c (resize_root_window, grow_mini_window)
6404 (shrink_mini_window): Rename Qresize_root_window to
6405 Qwindow_resize_root_window and Qresize_root_window_vertically to
6406 Qwindow_resize_root_window_vertically.
6408 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6410 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6412 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6414 * makefile.w32-in: Redesign dependencies so they reflect more
6415 clearly which files are directly included by each source file,
6416 and not through other includes.
6418 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6420 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6421 (sort_overlays, overlay_strings): When an overlay's clone number
6422 matches the window's clone number process the overlay even if
6423 the overlay's window property doesn't match the current window.
6425 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6426 (Fwindow_hchild): Rename to Fwindow_left_child.
6427 (Fwindow_next): Rename to Fwindow_next_sibling.
6428 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6429 (resize_window_check): Rename to window_resize_check.
6430 (resize_window_apply): Rename to window_resize_apply.
6431 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6432 (Fdelete_other_windows_internal, resize_frame_windows)
6433 (Fsplit_window_internal, Fdelete_window_internal)
6434 (grow_mini_window, shrink_mini_window)
6435 (Fresize_mini_window_internal): Fix callers accordingly.
6437 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6439 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6440 (emacs_fixed_set_min_size): Remove.
6441 (emacs_fixed_new): Take frame as argument.
6443 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6444 (_EmacsFixedPrivate): Remove minwidth/height.
6445 Add struct frame *f.
6446 (emacs_fixed_init): Initialize priv->f.
6447 (get_parent_class, emacs_fixed_set_min_size): Remove.
6448 (emacs_fixed_new): Set priv->f to argument.
6449 (emacs_fixed_get_preferred_width)
6450 (emacs_fixed_get_preferred_height): Use min_width/height from
6451 frames size_hint to set minimum and natural (Bug#8919).
6452 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6453 and use min_width/height from frames size_hint to set
6454 min_width/height (Bug#8919).
6456 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6457 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6460 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6462 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6463 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6466 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6468 * process.c (wait_reading_process_output): Bypass select if
6469 waiting for a cell while ignoring keyboard input, and input is
6470 pending. Suggested by Jan Djärv (Bug#8869).
6472 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6474 Use gnulib's dup2 module instead of rolling our own.
6475 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6477 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6479 * dispnew.c (scrolling_window): Before scrolling, turn off a
6480 mouse-highlight in the window being scrolled.
6482 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6484 Move DEFSYM to lisp.h and use everywhere.
6486 * character.h (DEFSYM): Move declaration...
6487 * lisp.h (DEFSYM): ...here.
6493 * w32select.c: Don't include character.h.
6495 * alloc.c (syms_of_alloc):
6496 * buffer.c (syms_of_buffer):
6497 * bytecode.c (syms_of_bytecode):
6498 * callint.c (syms_of_callint):
6499 * casefiddle.c (syms_of_casefiddle):
6500 * casetab.c (init_casetab_once):
6501 * category.c (init_category_once, syms_of_category):
6502 * ccl.c (syms_of_ccl):
6503 * cmds.c (syms_of_cmds):
6504 * composite.c (syms_of_composite):
6505 * dbusbind.c (syms_of_dbusbind):
6506 * dired.c (syms_of_dired):
6507 * dispnew.c (syms_of_display):
6508 * doc.c (syms_of_doc):
6509 * editfns.c (syms_of_editfns):
6510 * emacs.c (syms_of_emacs):
6511 * eval.c (syms_of_eval):
6512 * fileio.c (syms_of_fileio):
6513 * fns.c (syms_of_fns):
6514 * frame.c (syms_of_frame):
6515 * fringe.c (syms_of_fringe):
6516 * insdel.c (syms_of_insdel):
6517 * keymap.c (syms_of_keymap):
6518 * lread.c (init_obarray, syms_of_lread):
6519 * macros.c (syms_of_macros):
6520 * msdos.c (syms_of_msdos):
6521 * print.c (syms_of_print):
6522 * process.c (syms_of_process):
6523 * search.c (syms_of_search):
6524 * sound.c (syms_of_sound):
6525 * syntax.c (init_syntax_once, syms_of_syntax):
6526 * terminal.c (syms_of_terminal):
6527 * textprop.c (syms_of_textprop):
6528 * undo.c (syms_of_undo):
6529 * w32.c (globals_of_w32):
6530 * window.c (syms_of_window):
6531 * xdisp.c (syms_of_xdisp):
6532 * xfaces.c (syms_of_xfaces):
6533 * xfns.c (syms_of_xfns):
6534 * xmenu.c (syms_of_xmenu):
6535 * xsettings.c (syms_of_xsettings):
6536 * xterm.c (syms_of_xterm): Use DEFSYM.
6538 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6540 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6542 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6544 Integer and buffer overflow fixes (Bug#8873).
6546 * print.c (printchar, strout): Check for string overflow.
6547 (PRINTPREPARE, printchar, strout):
6548 Don't set size unless allocation succeeds.
6550 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6551 for sizes. Check for string overflow more accurately.
6552 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6554 * macros.c: Integer and buffer overflow fixes.
6555 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6556 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6557 Use ptrdiff_t, not int, for sizes.
6558 Don't increment bufsize until after realloc succeeds.
6559 Check for size-calculation overflow.
6560 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6562 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6564 * lread.c: Integer overflow fixes.
6565 (read_integer): Radix is now EMACS_INT, not int,
6566 to improve quality of diagnostics for out-of-range radices.
6567 Calculate buffer size correctly for out-of-range radices.
6568 (read1): Check for integer overflow in radices, and in
6569 read-circle numbers.
6570 (read_escape): Avoid int overflow.
6571 (Fload, openp, read_buffer_size, read1)
6572 (substitute_object_recurse, read_vector, read_list, map_obarray):
6573 Use ptrdiff_t, not int, for sizes.
6574 (read1): Use EMACS_INT, not int, for sizes.
6575 Check for size overflow.
6577 * image.c (cache_image): Check for size arithmetic overflow.
6579 * lread.c: Integer overflow issues.
6580 (saved_doc_string_size, saved_doc_string_length)
6581 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6582 Now ptrdiff_t, not int.
6583 (read1): Don't assume doc string length fits in int. Check for
6584 out-of-range doc string lengths.
6585 (read_list): Don't assume file position fits in int.
6586 (read_escape): Check for hex character overflow.
6588 2011-06-22 Leo Liu <sdl.web@gmail.com>
6590 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6591 Move to minibuffer.el.
6593 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6595 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6596 The following patches are for when GLYPH_DEBUG && !XASSERT.
6597 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6598 * dispnew.c (flush_stdout):
6599 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6600 Mark as externally visible.
6601 * dispnew.c (check_window_matrix_pointers): Now static.
6602 * dispnew.c (window_to_frame_vpos):
6603 * xfns.c (unwind_create_frame):
6604 * xterm.c (x_check_font): Remove unused local.
6605 * scroll.c (CHECK_BOUNDS):
6606 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6607 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6608 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6609 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6610 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6612 (debug_method_add): Use va_list and vsprintf rather than relying
6613 on undefined behavior with wrong number of arguments.
6614 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6615 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6616 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6617 since we're not interested in debugging glyphs with old libraries.
6618 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6619 GCC 4.6.0's static checking.
6621 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6623 Integer overflow and signedness fixes (Bug#8873).
6624 A few related buffer overrun fixes, too.
6626 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6628 * dispextern.h (struct face.stipple):
6629 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6630 (x_bitmap_mask, x_allocate_bitmap_record)
6631 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6632 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6633 (x_create_bitmap_from_xpm_data):
6634 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6635 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6637 * xfaces.c (load_pixmap):
6638 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6639 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6640 (.bitmaps_last, struct x_output.icon_bitmap):
6641 Use ptrdiff_t, not int, for bitmap indexes.
6642 (x_allocate_bitmap_record): Check for size overflow.
6643 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6645 Use ptrdiff_t, not int, for overlay counts.
6646 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6647 * editfns.c (overlays_around, get_pos_property):
6648 * textprop.c (get_char_property_and_overlay):
6649 * xdisp.c (next_overlay_change, note_mouse_highlight):
6650 * xfaces.c (face_at_buffer_position):
6651 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6652 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6653 (Fnext_overlay_change, Fprevious_overlay_change)
6654 (mouse_face_overlay_overlaps, Foverlays_in):
6655 Use ptrdiff_t, not int, for sizes.
6656 (overlays_at, overlays_in): Check for size-calculation overflow.
6658 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6660 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6661 (x_session_initialize): Do not assume string length fits in int.
6663 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6664 This is unlikely, but can occur if DPI is outlandish.
6666 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6667 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6669 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6670 * xrdb.c (magic_file_p, search_magic_path):
6671 Omit last arg SUFFIX; it was always 0. All callers changed.
6672 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6674 * xfont.c (xfont_match): Avoid need for strlen.
6676 * xfns.c: Don't assume strlen fits in int.
6677 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6679 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6680 not unsigned long, as we prefer signed integers. All callers changed.
6681 Detect integer overflow in repeat count.
6682 (message_dolog): Don't assume print length fits in 39 bytes.
6683 (display_mode_element): Don't assume strlen fits in int.
6685 * termcap.c: Don't assume sizes fit in int and never overflow.
6686 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6687 (gobble_line): Check for size-calculation overflow.
6689 * minibuf.c (Fread_buffer):
6690 * lread.c (intern, intern_c_string):
6691 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6692 Don't assume string length fits in int.
6694 * keyboard.c (parse_tool_bar_item):
6695 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6697 * font.c: Don't assume string length fits in int.
6698 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6699 Use ptrdiff_t, not int.
6700 (font_intern_prop): Don't assume string length fits in int.
6701 Don't assume integer property fits in fixnum.
6702 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6704 * filelock.c: Fix some buffer overrun and integer overflow issues.
6705 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6706 Reformulate so as not to need the command string.
6707 Invoke gzip -cd rather than gunzip, as it's more portable.
6708 (lock_info_type, lock_file_1, lock_file):
6709 Don't assume pid_t and time_t fit in unsigned long.
6710 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6711 (current_lock_owner): Prefer signed type for sizes.
6712 Use memcpy, not strncpy, where memcpy is what is really wanted.
6713 Don't assume (via atoi) that time_t and pid_t fit in int.
6714 Check for time_t and/or pid_t out of range, e.g., via a network share.
6715 Don't alloca where an auto var works fine.
6717 * fileio.c: Fix some integer overflow issues.
6718 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6719 Don't assume string length fits in int.
6720 (directory_file_name): Don't assume string length fits in long.
6721 (make_temp_name): Don't assume pid fits in int, or that its print
6722 length is less than 20.
6724 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6726 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6728 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6730 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6731 We prefer signed integers, even for size calculations.
6733 * emacs.c: Don't assume string length fits in 'int'.
6734 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6735 (main): Don't invoke strlen when not needed.
6737 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6738 (XD_DEBUG_MESSAGE): Don't waste a byte.
6740 * callproc.c (getenv_internal_1, getenv_internal)
6742 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6744 * lread.c (invalid_syntax): Omit length argument.
6745 All uses changed. This doesn't fix a bug, but it simplifies the
6746 code away from its former Hollerith-constant appearance, and it's
6747 one less 'int' to worry about when looking at integer-overflow issues.
6748 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6750 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6751 This didn't break anything, but it didn't help either.
6752 It's confusing to put a bogus integer in a place where the actual
6753 value does not matter.
6754 (LIST_END_P): Remove unused macro and its bogus comment.
6755 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6757 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6758 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6760 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6761 We prefer signed types, and the value cannot exceed the EMACS_INT
6762 range anyway (because otherwise the length would not be representable).
6763 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6764 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6765 This avoids a GCC warning when WIDE_EMACS_INT.
6767 * indent.c (sane_tab_width): New function.
6768 (current_column, scan_for_column, Findent_to, position_indentation)
6769 (compute_motion): Use it. This is just for clarity.
6770 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6772 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6774 * lisp.h (lint_assume): New macro.
6775 * composite.c (composition_gstring_put_cache):
6776 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6778 * editfns.c, insdel.c:
6779 Omit unnecessary forward decls, to simplify future changes.
6781 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6783 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6785 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6786 Use much-faster test for byte-length change.
6787 Don't assume string byte-length fits in 'int'.
6788 Check that character arg fits in 'int'.
6789 (mapcar1): Declare byte as byte, for clarity.
6791 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6793 * fns.c (concat): Catch string overflow earlier.
6794 Do not rely on integer wraparound.
6796 * dispextern.h (struct it.overlay_strings_charpos)
6797 (struct it.selective): Now EMACS_INT, not int.
6798 * xdisp.c (forward_to_next_line_start)
6799 (back_to_previous_visible_line_start)
6800 (reseat_at_next_visible_line_start, next_element_from_buffer):
6801 Don't arbitrarily truncate the value of 'selective' to int.
6803 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6805 * composite.c: Don't truncate sizes to 'int'.
6806 (composition_gstring_p, composition_reseat_it)
6807 (composition_adjust_point): Use EMACS_INT, not int.
6808 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6809 not EMACS_UINT, for indexes.
6811 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6813 * buffer.c: Include <verify.h>.
6814 (struct sortvec.priority, struct sortstr.priority):
6815 Now EMACS_INT, not int.
6816 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6817 (struct sortstr.size, record_overlay_string)
6818 (struct sortstrlist.size, struct sortlist.used):
6819 Don't truncate size to int.
6820 (record_overlay_string): Check for size-calculation overflow.
6821 (init_buffer_once): Check at compile-time, not run-time.
6823 2011-06-22 Jim Meyering <meyering@redhat.com>
6825 Don't leak an XBM-image-sized buffer
6826 * image.c (xbm_load): Free the image buffer after using it.
6828 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6831 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6832 that Sun C diagnosed.
6833 * fns.c (secure_hash): Fix pointer signedness issue.
6834 * intervals.c (static_offset_intervals): New function.
6835 (offset_intervals): Use it.
6837 2011-06-21 Leo Liu <sdl.web@gmail.com>
6840 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6843 * fns.c (secure_hash): Rename from crypto_hash_function and change
6844 the first arg to accept symbols.
6845 (Fsecure_hash): New primitive.
6846 (syms_of_fns): New symbols.
6848 2011-06-20 Deniz Dogan <deniz@dogan.se>
6850 * process.c (Fset_process_buffer): Clarify return value in
6853 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6855 * dispnew.c (add_window_display_history): Use BVAR.
6857 * xdisp.c (debug_method_add): Use BVAR.
6858 (check_window_end, dump_glyph_matrix, dump_glyph)
6859 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6861 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6864 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6865 check till after the cache is created in init_frame_faces.
6867 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6869 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6871 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6873 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6874 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6875 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6877 Improve buffer-overflow checking (Bug#8873).
6878 * fileio.c (Finsert_file_contents):
6879 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6880 Remove the old (too-loose) buffer overflow checks.
6881 They weren't needed, since make_gap checks for buffer overflow.
6882 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6883 The old code merely checked for Emacs fixnum overflow, and relied
6884 on undefined (wraparound) behavior. The new code avoids undefined
6885 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6887 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6888 Tune. Don't use wider integers than needed. Don't use alloca.
6889 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6891 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6893 * insdel.c, lisp.h (buffer_overflow): New function.
6894 (insert_from_buffer_1, replace_range, replace_range_2):
6895 * insdel.c (make_gap_larger):
6896 * editfns.c (Finsert_char):
6897 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6899 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6901 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6903 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6905 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6906 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6908 * fileio.c: Don't assume EMACS_INT fits in off_t.
6909 (emacs_lseek): New static function.
6910 (Finsert_file_contents, Fwrite_region): Use it.
6911 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6913 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6915 * fns.c: Don't overflow int when computing a list length.
6916 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6917 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6918 truncation on 64-bit hosts. Check for QUIT every
6919 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6920 faster and is responsive enough.
6921 (Flength): Report an error instead of overflowing an integer.
6922 (Fsafe_length): Return a float if the value is not representable
6923 as a fixnum. This shouldn't happen except in contrived situations.
6924 (Fnthcdr, Fsort): Don't assume list length fits in int.
6925 (Fcopy_sequence): Don't assume vector length fits in int.
6927 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6928 (header_size, word_size): New constants.
6929 (allocate_vectorlike): Don't check size overflow here.
6930 (allocate_vector): Check it here instead, since this is the only
6931 caller of allocate_vectorlike that could cause overflow.
6932 Check that the new vector's length is representable as a fixnum.
6934 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6935 The previous code was bogus. For example, next_almost_prime (32)
6936 returned 39, which is undesirable as it is a multiple of 3; and
6937 next_almost_prime (24) returned 25, which is a multiple of 5 so
6938 why was the code bothering to check for multiples of 7?
6940 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6942 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6944 Variadic C functions now count arguments with ptrdiff_t.
6945 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6946 Back then I didn't know that the Emacs coding style prefers signed int.
6947 Also, in the meantime I found a few more instances where arguments
6948 were being counted with int, which may truncate counts on 64-bit
6949 machines, or EMACS_INT, which may be unnecessarily wide.
6950 * lisp.h (struct Lisp_Subr.function.aMANY)
6951 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6952 Arg counts are now ptrdiff_t, not size_t.
6953 All variadic functions and their callers changed accordingly.
6954 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6955 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6956 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6957 * callint.c (Fcall_interactively): Check arg count for overflow,
6958 to avoid potential buffer overrun. Use signed char, not 'int',
6959 for 'varies' array, so that we needn't bother to check its size
6960 calculation for overflow.
6961 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6962 * eval.c (apply_lambda):
6963 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6964 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6965 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6967 * callint.c (Fcall_interactively): Don't use index var as event count.
6969 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6970 * mem-limits.h (SIZE): Remove; no longer used.
6972 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6974 Remove unnecessary casts.
6975 * xterm.c (x_term_init):
6976 * xfns.c (x_set_border_pixel):
6977 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6978 These aren't needed now that we assume ANSI C.
6980 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6981 It's more likely to cause problems (due to unsigned overflow)
6984 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6986 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6988 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6990 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6992 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6994 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6996 GLYPH_CODE_FACE returns EMACS_INT, not int.
6997 * dispextern.h (merge_faces):
6998 * xfaces.c (merge_faces):
6999 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7000 Don't assume EMACS_INT fits in int.
7002 * character.h (CHAR_VALID_P): Remove unused parameter.
7003 * fontset.c, lisp.h, xdisp.c: All uses changed.
7005 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7007 * fns.c (concat): Minor tuning based on overflow analysis.
7008 This doesn't fix any bugs. Use int to hold character, instead
7009 of constantly refetching from Emacs object. Use XFASTINT, not
7010 XINT, for value known to be a character. Don't bother comparing
7011 a single byte to 0400, as it's always less.
7013 * floatfns.c (Fexpt):
7014 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7016 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7019 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7021 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7022 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7023 incorrectly succeed when S was a string, because 4294967386 was
7024 truncated before it was used.
7026 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7027 Otherwise, an out-of-range integer could cause undefined behavior
7030 * composite.c: Use int, not EMACS_INT, for characters.
7031 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7032 EMACS_INT, for values that are known to be in character range.
7033 This doesn't fix any bugs but is the usual style inside Emacs and
7034 may generate better code on 32-bit machines.
7036 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7037 This is for reasons similar to the recent CHAR_STRING fix.
7038 * charset.c (Fencode_char): Check that character arg is actually
7039 a character. Pass an int to ENCODE_CHAR.
7040 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7041 wider than 'int', as a compile-time check to prevent future regressions
7044 * character.c (char_string): Remove unnecessary casts.
7046 Make sure a 64-bit char is never passed to CHAR_STRING.
7047 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7048 by silently ignoring the top 32 bits, allowing some values
7049 that were far too large to be valid characters.
7050 * character.h: Include <verify.h>.
7051 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7052 arguments are no wider than unsigned, as a compile-time check
7053 to prevent future regressions in this area.
7055 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7056 (Fsubst_char_in_region):
7058 * xdisp.c (decode_mode_spec_coding):
7059 Adjust to CHAR_STRING's new requirement.
7060 * editfns.c (Finsert_char, Fsubst_char_in_region):
7061 * fns.c (concat): Check that character args are actually
7062 characters. Without this test, these functions did the wrong
7063 thing with wildly out-of-range values on 64-bit hosts.
7065 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7066 These casts should not be needed on 32-bit hosts, either.
7067 * keyboard.c (read_char):
7068 * lread.c (Fload): Remove casts to unsigned.
7070 * lisp.h (UNSIGNED_CMP): New macro.
7071 This fixes comparison bugs on 64-bit hosts.
7072 (ASCII_CHAR_P): Use it.
7073 * casefiddle.c (casify_object):
7074 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7075 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7076 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7077 * dispextern.h (FACE_FROM_ID):
7078 * keyboard.c (read_char): Use UNSIGNED_CMP.
7080 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7081 not to EMACS_INT, to avoid GCC warning.
7083 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7085 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7086 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7087 isn't needed on 32-bit machines.
7089 * buffer.c (Fgenerate_new_buffer_name):
7090 Use EMACS_INT for count, not int.
7091 (advance_to_char_boundary): Return EMACS_INT, not int.
7093 * data.c (Qcompiled_function): Now static.
7095 * window.c (window_body_lines): Now static.
7097 * image.c (gif_load): Rename local to avoid shadowing.
7099 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7100 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7101 * alloc.c (make_save_value): Integer argument is now of type
7103 (mark_object): Use ptrdiff_t, not int.
7104 * lisp.h (pD): New macro.
7105 * print.c (print_object): Use it.
7107 * alloc.c: Use EMACS_INT, not int, to count objects.
7108 (total_conses, total_markers, total_symbols, total_vector_size)
7109 (total_free_conses, total_free_markers, total_free_symbols)
7110 (total_free_floats, total_floats, total_free_intervals)
7111 (total_intervals, total_strings, total_free_strings):
7112 Now EMACS_INT, not int. All uses changed.
7113 (Fgarbage_collect): Compute overall total using a double, so that
7114 integer overflow is less likely to be a problem. Check for overflow
7115 when converting back to an integer.
7116 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7117 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7118 These were 'int' variables that could overflow on 64-bit hosts;
7119 they were never used, so remove them instead of repairing them.
7120 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7121 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7122 Previously, this ceilinged at INT_MAX, but that doesn't work on
7124 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7126 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7127 (allocate_vectorlike): Check for ptrdiff_t overflow.
7128 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7129 when a (possibly-narrower) signed value would do just as well.
7130 We prefer using signed arithmetic, to avoid comparison confusion.
7132 * alloc.c: Catch some string size overflows that we were missing.
7133 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7134 for convenience in STRING_BYTES_MAX.
7135 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7136 The definition here is exact; the one in lisp.h was approximate.
7137 (allocate_string_data): Check for string overflow. This catches
7138 some instances we weren't catching before. Also, it catches
7139 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7140 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7141 and ptrdiff_t and EMACS_INT are both 64 bits.
7143 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7144 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7145 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7147 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7149 * alloc.c (Fmake_string): Check for out-of-range init.
7151 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7153 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7155 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7157 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7158 xg_get_default_scrollbar_width.
7160 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7161 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7162 (style_changed_cb): Call update_theme_scrollbar_width and call
7163 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7164 all frames (Bug#8505).
7165 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7166 Call gtk_window_set_resizable if HAVE_GTK3.
7167 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7168 and height if HAVE_GTK3 (Bug#8505).
7169 (scroll_bar_width_for_theme): New variable.
7170 (update_theme_scrollbar_width): New function.
7171 (xg_get_default_scrollbar_width): Move code to
7172 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7173 (xg_initialize): Call update_theme_scrollbar_width.
7175 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7177 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7179 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7181 * frame.c (make_frame): Call other_buffer_safely instead of
7184 * window.c (temp_output_buffer_show): Call display_buffer with
7185 second argument Vtemp_buffer_show_specifiers and reset latter
7186 immediately after the call.
7187 (Vtemp_buffer_show_specifiers): New variable.
7188 (auto_window_vscroll_p, next_screen_context_lines)
7189 (Vscroll_preserve_screen_position): Remove leading asterisks from
7192 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7194 Fix minor problems found by GCC 4.6.0 static checking.
7195 * buffer.c (Qclone_number): Remove for now, as it's unused.
7196 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7197 (record_buffer): Remove unused local.
7198 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7199 (set_frame_buffer_list): Remove; unused.
7200 * frame.h (other_visible_frames): Remove decl.
7201 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7202 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7203 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7205 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7206 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7207 Define only if HAVE_GPM.
7208 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7209 (update_hints_inhibit): Remove; never set. All uses removed.
7210 * widgetprv.h (emacsFrameClassRec): Remove decl.
7211 * window.c (delete_deletable_window): Now returns void, since it
7212 wasn't returning anything.
7213 (compare_window_configurations): Remove unused locals.
7214 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7215 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7216 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7217 the same widths as pointers. This follows up on the 2011-05-06 patch.
7218 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7219 * xterm.h: Likewise.
7220 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7222 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7224 * makefile.w32-in: Update dependencies.
7225 (LISP_H): Add lib/intprops.h.
7227 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7229 * image.c (gif_load): Add animation frame delay to the metadata.
7230 (syms_of_image): Use DEFSYM. New symbol `delay'.
7232 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7234 * window.c (delete_deletable_window): Re-add.
7235 (Fset_window_configuration): Rewrite to handle dead buffers and
7236 consequently deletable windows.
7237 (window_tree, Fwindow_tree): Remove. Supply functionality in
7239 (compare_window_configurations): Simplify code.
7241 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7243 * image.c (imagemagick_load_image): Fix type mismatch.
7244 (Fimagemagick_types): Likewise.
7246 * window.h (replace_buffer_in_windows): Declare.
7248 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7250 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7251 Qclone_number. Remove external declaration of Qdelete_window.
7252 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7254 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7255 Run Qbuffer_list_update_hook if allowed.
7256 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7257 buffer list implementation.
7258 (other_buffer_safely): New function.
7259 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7260 calls to replace_buffer_in_windows and
7261 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7263 (record_buffer): Inhibit quitting and rewrite using quittable
7264 functions. Run Qbuffer_list_update_hook if allowed.
7265 (Frecord_buffer, Funrecord_buffer): New functions.
7266 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7267 Move switch-to-buffer to window.el.
7268 (bury-buffer): Move to window.el.
7269 (Vbuffer_list_update_hook): New variable.
7271 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7274 * window.h (resize_frame_windows): Move up in code.
7275 (Fwindow_frame): Remove EXFUN.
7276 (replace_buffer_in_all_windows): Remove prototype.
7277 (replace_buffer_in_windows_safely): Add prototype.
7279 * window.c: Declare Qdelete_window static again. Move down
7280 declaration of select_count.
7281 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7282 (Fother_window): Move to window.el.
7283 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7284 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7285 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7287 (replace_buffer_in_windows): Implement by calling
7288 Qreplace_buffer_in_windows.
7289 (replace_buffer_in_all_windows): Remove with some functionality
7290 moved into replace_buffer_in_windows_safely.
7291 (replace_buffer_in_windows_safely): New function.
7292 (select_window_norecord, select_frame_norecord): Move in front
7293 of run_window_configuration_change_hook. Remove now obsolete
7295 (Fset_window_buffer): Rewrite doc-string.
7296 Call Qrecord_window_buffer.
7297 (keys_of_window): Move binding for other-window to window.el.
7299 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7301 * dispextern.h (struct image): Replace data member, whose int_val
7302 and ptr_val fields were not used by anything, with a single
7305 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7306 (gif_clear_image, gif_load, imagemagick_load_image)
7307 (gs_clear_image, gs_load): Callers changed.
7309 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7311 * buffer.h: Include <time.h>, for time_t.
7312 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7314 Fix minor problems found by static checking.
7316 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7318 Make identifiers static if they are not used in other modules.
7319 * data.c (Qcompiled_function, Qframe, Qvector):
7320 * image.c (QimageMagick, Qsvg):
7321 * minibuf.c (Qmetadata):
7322 * window.c (resize_window_check, resize_root_window): Now static.
7323 * window.h (resize_window_check, resize_root_window): Remove decls.
7325 * window.c (window_deletion_count, delete_deletable_window):
7327 (window_body_lines): Now static.
7328 (Fdelete_other_windows_internal): Mark vars as initialized.
7329 Make sure 'resize_failed' is initialized.
7330 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7331 (resize_window_apply): Remove unused local.
7332 * window.h (delete_deletable_window): Remove decl.
7334 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7335 (imagemagick_load_image): Fix pointer signedness problem by changing
7336 last arg from unsigned char * to char *. All uses changed.
7337 Also, fix a local for similar reasons.
7338 Remove unused locals. Remove locals to avoid shadowing.
7339 (fn_rsvg_handle_free): Remove; unused.
7340 (svg_load, svg_load_image): Fix pointer signedness problem.
7341 (imagemagick_load_image): Don't use garbage pointer image_wand.
7343 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7345 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7347 * image.c (gif_load): Fix omitted cast error introduced by
7350 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7352 * window.h (resize_proportionally, orig_total_lines)
7353 (orig_top_line): Remove from window structure.
7354 (set_window_height, set_window_width, change_window_heights)
7355 (Fdelete_window): Remove prototypes.
7356 (resize_frame_windows): Remove duplicate declaration.
7358 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7360 * window.h (resize_frame_windows, resize_window_check)
7361 (delete_deletable_window, resize_root_window)
7362 (resize_frame_windows): Declare prototypes.
7364 * window.c (resize_window_apply): Make definition be "static" to
7365 match the prototype.
7367 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7369 * window.c: Remove declarations of Qwindow_size_fixed,
7370 window_min_size_1, window_min_size_2, window_min_size,
7371 size_window, window_fixed_size_p, enlarge_window, delete_window.
7372 Remove static from declaration of Qdelete_window, it's
7373 temporarily needed by Fbury_buffer.
7374 (replace_window): Don't assign orig_top_line and
7376 (Fdelete_window, delete_window): Remove. Window deletion is
7377 handled by window.el.
7378 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7379 Replace Fdelete_window calls with calls to Qdelete_window.
7380 (Fdelete_other_windows): Remove. Deleting other windows is
7381 handled by window.el.
7382 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7383 handled in window.el.
7384 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7385 Window minimum sizes are handled in window.el.
7386 (shrink_windows, size_window, set_window_height)
7387 (set_window_width, change_window_heights, window_height)
7388 (window_width, CURBEG, CURSIZE, enlarge_window)
7389 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7390 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7391 handled in window.el.
7392 (make_dummy_parent): Rename to make_parent_window and give it a
7393 second argument horflag.
7394 (make_window): Don't set resize_proportionally any more.
7395 (Fsplit_window): Remove. Windows are split in window.el.
7396 (save_restore_action, save_restore_orig_size)
7397 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7398 Resize mini windows in window.el.
7399 (grow_mini_window, shrink_mini_window): Implement by calling
7400 Qresize_root_window_vertically, resize_window_check and
7401 resize_window_apply.
7402 (saved_window, Fset_window_configuration, save_window_save):
7403 Do not handle orig_top_line, orig_total_lines, and
7404 resize_proportionally.
7405 (window_min_height, window_min_width): Move to window.el.
7406 (keys_of_window): Move bindings for delete-other-windows,
7407 split-window, delete-window and enlarge-window to window.el.
7409 * buffer.c: Temporarily extern Qdelete_window.
7410 (Fbury_buffer): Temporarily call Qdelete_window instead of
7411 Fdelete_window (Fbury_buffer will move to window.el soon).
7413 * frame.c (set_menu_bar_lines_1): Remove code handling
7414 orig_top_line and orig_total_lines.
7416 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7417 set_window_height but set heights directly.
7418 (change_frame_size_1): Use resize_frame_windows.
7420 * xdisp.c (init_xdisp): Don't use set_window_height but set
7423 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7424 Use resize_frame_windows instead of change_window_heights and run
7425 run_window_configuration_change_hook.
7427 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7428 instead of change_window_heights and run
7429 run_window_configuration_change_hook.
7431 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7433 * window.c (replace_window): Rename second argument REPLACEMENT to
7434 NEW. New third argument SETFLAG. Rewrite.
7435 (delete_window, make_dummy_parent): Call replace_window with
7437 (window_list_1): Move down in code.
7438 (run_window_configuration_change_hook): Move set_buffer part
7439 before select_frame_norecord part in order to unwind correctly.
7440 Rename count1 to count.
7441 (recombine_windows, delete_deletable_window, resize_root_window)
7442 (Fdelete_other_windows_internal)
7443 (Frun_window_configuration_change_hook, make_parent_window)
7444 (resize_window_check, resize_window_apply, Fresize_window_apply)
7445 (resize_frame_windows, Fsplit_window_internal)
7446 (Fdelete_window_internal, Fresize_mini_window_internal):
7448 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7450 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7452 * window.h (window): Add some new members to window structure -
7453 normal_lines, normal_cols, new_total, new_normal, clone_number,
7454 splits, nest, prev_buffers, next_buffers.
7455 (WINDOW_TOTAL_SIZE): Move here from window.c.
7456 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7458 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7460 (make_dummy_parent): Set new members of windows structure.
7461 (make_window): Move down in code. Handle new members of window
7463 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7464 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7465 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7466 (Fset_window_prev_buffers, Fwindow_next_buffers)
7467 (Fset_window_next_buffers, Fset_window_clone_number):
7469 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7470 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7472 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7473 Argument WINDOW can be now internal window too.
7474 (Fwindow_use_time): Move up in code.
7475 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7477 (Fset_window_configuration, saved_window)
7478 (Fcurrent_window_configuration, save_window_save): Handle new
7479 members of window structure.
7480 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7481 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7482 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7483 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7484 Qget_mru_window, Qresize_root_window,
7485 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7486 Qauto_buffer_name; staticpro them.
7488 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7490 * window.c (Fwindow_total_size, Fwindow_left_column)
7491 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7492 (Fwindow_list_1): New functions.
7493 (window_box_text_cols): Replace with window_body_cols.
7494 (Fwindow_width, Fscroll_left, Fscroll_right):
7495 Use window_body_cols instead of window_box_text_cols.
7496 (delete_window, Fset_window_configuration):
7497 Call delete_all_subwindows with window as argument.
7498 (delete_all_subwindows): Take a window as argument and not a
7500 (window_loop): Remove handling of GET_LRU_WINDOW and
7502 (Fget_lru_window, Fget_largest_window): Move to window.el.
7504 * window.h: Extern window_body_cols instead of
7505 window_box_text_cols. delete_all_subwindows now takes a
7506 Lisp_Object as argument.
7508 * indent.c (compute_motion, Fcompute_motion):
7509 Use window_body_cols instead of window_box_text_cols.
7511 * frame.c (delete_frame): Call delete_all_subwindows with root
7514 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7516 * fns.c (Fputhash): Document return value.
7518 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7520 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7522 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7524 Cons<->int and similar integer overflow fixes (Bug#8794).
7526 Check for overflow when converting integer to cons and back.
7527 * charset.c (Fdefine_charset_internal, Fdecode_char):
7528 Use cons_to_unsigned to catch overflow.
7529 (Fencode_char): Use INTEGER_TO_CONS.
7530 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7531 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7532 * data.c (long_to_cons, cons_to_long): Remove.
7533 (cons_to_unsigned, cons_to_signed): New functions.
7534 These signal an error for invalid or out-of-range values.
7535 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7536 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7537 * font.c (Ffont_variation_glyphs):
7538 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7539 * lisp.h: Include <intprops.h>.
7540 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7541 (cons_to_signed, cons_to_unsigned): New decls.
7542 (long_to_cons, cons_to_long): Remove decls.
7543 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7544 (Fprimitive_undo): Use CONS_TO_INTEGER.
7545 * xfns.c (Fx_window_property): Likewise.
7546 * xselect.c: Include <limits.h>.
7547 (x_own_selection, selection_data_to_lisp_data):
7548 Use INTEGER_TO_CONS.
7549 (x_handle_selection_request, x_handle_selection_clear)
7550 (x_get_foreign_selection, Fx_disown_selection_internal)
7551 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7552 (lisp_data_to_selection_data): Use cons_to_unsigned.
7553 (x_fill_property_data): Use cons_to_signed.
7554 Report values out of range.
7556 Check for buffer and string overflow more precisely.
7557 * buffer.h (BUF_BYTES_MAX): New macro.
7558 * lisp.h (STRING_BYTES_MAX): New macro.
7559 * alloc.c (Fmake_string):
7560 * character.c (string_escape_byte8):
7561 * coding.c (coding_alloc_by_realloc):
7562 * doprnt.c (doprnt):
7563 * editfns.c (Fformat):
7565 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7566 since they may not be the same number.
7567 * editfns.c (Finsert_char):
7568 * fileio.c (Finsert_file_contents):
7569 Likewise for BUF_BYTES_MAX.
7571 * image.c: Use ptrdiff_t, not int, for sizes.
7572 (slurp_file): Switch from int to ptrdiff_t.
7574 (slurp_file): Check that file size fits in both size_t (for
7575 malloc) and ptrdiff_t (for sanity and safety).
7577 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7578 if b->modtime has its maximal value.
7580 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7582 Don't assume time_t can fit into int.
7583 * buffer.h (struct buffer.modtime): Now time_t, not int.
7584 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7585 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7587 Minor fixes for signed vs unsigned integers.
7588 * character.h (MAYBE_UNIFY_CHAR):
7589 * charset.c (maybe_unify_char):
7590 * keyboard.c (read_char, reorder_modifiers):
7591 XINT -> XFASTINT, since the integer must be nonnegative.
7592 * ftfont.c (ftfont_spec_pattern):
7593 * keymap.c (access_keymap, silly_event_symbol_error):
7594 XUINT -> XFASTINT, since the integer must be nonnegative.
7595 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7596 since it makes no difference and we prefer signed.
7597 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7598 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7601 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7603 * window.h (Fwindow_frame): Declare.
7605 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7607 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7608 (SPARE_MEMORY): Always define.
7609 (LARGE_REQUEST): Remove.
7610 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7612 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7614 * lisp.h: Move EXFUNS for Fframe_root_window,
7615 Fframe_first_window and Fset_frame_selected_window to window.h.
7617 * window.h: Move EXFUNS for Fframe_root_window,
7618 Fframe_first_window and Fset_frame_selected_window here from
7621 * frame.c (Fwindow_frame, Fframe_first_window)
7622 (Fframe_root_window, Fframe_selected_window)
7623 (Fset_frame_selected_window): Move to window.c.
7624 (Factive_minibuffer_window): Move to minibuf.c.
7625 (Fother_visible_frames_p): New function.
7627 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7629 * window.c (decode_window, decode_any_window): Move up in code.
7630 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7631 (inhibit_frame_unsplittable): Remove unused variable.
7632 (Fwindow_buffer): Move up and rewrite doc-string.
7633 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7634 (Fwindow_prev): New functions.
7635 (Fwindow_frame): Move here from frame.c. Accept any window as
7637 (Fframe_root_window, Fframe_first_window)
7638 (Fframe_selected_window): Move here from frame.c. Accept frame
7639 or arbitrary window as argument. Update doc-strings.
7640 (Fminibuffer_window): Move up in code.
7641 (Fwindow_minibuffer_p): Move up in code and simplify.
7642 (Fset_frame_selected_window): Move here from frame.c.
7644 (Fselected_window, select_window, Fselect_window): Move up in
7645 code. Minor doc-string fixes.
7647 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7649 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7650 Do not assume that spare memory exists; that assumption is valid
7651 only if SYSTEM_MALLOC.
7652 (LARGE_REQUEST): New macro, so that the issue of large requests
7653 is separated from the issue of spare memory.
7655 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7657 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7660 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7662 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7665 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7667 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7669 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7671 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7672 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7674 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7676 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7678 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7680 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7681 (x_clipboard_manager_save): Add return value.
7682 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7684 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7685 Obey Vx_select_enable_clipboard_manager. Catch errors in
7686 x_clipboard_manager_save (Bug#8779).
7687 (Vx_select_enable_clipboard_manager): New variable.
7688 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7690 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7692 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7694 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7696 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7697 in the current matrix if keep_current_p is non-zero.
7699 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7701 * bidi.c (bidi_level_of_next_char): Fix last change.
7703 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7705 Support bidi reordering of text covered by display properties.
7707 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7708 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7709 (bidi_cache_search, bidi_cache_iterator_state)
7710 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7711 (bidi_level_of_next_char, bidi_move_to_visually_next):
7712 Support character positions inside a run of characters covered by a
7714 (bidi_paragraph_init, bidi_resolve_explicit_1)
7715 (bidi_level_of_next_char): Call bidi_fetch_char and
7716 bidi_fetch_char_advance instead of FETCH_CHAR and
7718 (bidi_init_it): Initialize new members.
7719 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7721 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7722 instead of using explicit *_CHAR codes.
7723 (bidi_resolve_explicit, bidi_resolve_weak):
7724 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7725 bidirectional text is supported only in multibyte buffers.
7726 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7727 it to initialize the frame_window_p member of struct bidi_it.
7728 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7729 (bidi_resolve_explicit, bidi_resolve_weak)
7730 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7731 bidi_it->nchars is non-positive.
7732 (bidi_level_of_next_char): Don't try to lookup the cache for the
7733 next/previous character if nothing is cached there yet, or if we
7734 were just reseat()'ed to a new position.
7736 * xdisp.c (set_cursor_from_row): Set start and stop points
7737 according to the row's direction when priming the loop that looks
7738 for the glyph on which to display cursor.
7739 (single_display_spec_intangible_p): Function deleted.
7740 (display_prop_intangible_p): Reimplement to call
7741 handle_display_spec instead of single_display_spec_intangible_p.
7742 Accept 3 additional arguments needed by handle_display_spec.
7743 This fixes incorrect cursor motion across display property with complex
7744 values: lists, `(when COND...)' forms, etc.
7745 (single_display_spec_string_p): Support property values that are
7746 lists with the argument STRING its top-level element.
7747 (display_prop_string_p): Fix the condition for processing a
7748 property that is a list to be consistent with handle_display_spec.
7749 (handle_display_spec): New function, refactored from the
7750 last portion of handle_display_prop.
7751 (compute_display_string_pos): Accept additional argument
7752 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7753 value of a `display' property is a "replacing spec".
7754 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7755 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7756 the display property, but just return a value indicating whether
7757 the display property will replace the characters it covers.
7758 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7759 frame_window_p members of struct bidi_it.
7760 (compute_display_string_pos, compute_display_string_end):
7762 (push_it): Accept second argument POSITION, where pop_it should
7763 jump to continue iteration.
7764 (reseat_1): Initialize bidi_it.disp_pos.
7766 * keyboard.c (adjust_point_for_property): Adjust the call to
7767 display_prop_intangible_p to its new signature.
7769 * dispextern.h (struct bidi_it): New member frame_window_p.
7770 (bidi_init_it): Update prototypes.
7771 (display_prop_intangible_p): Update prototype.
7772 (compute_display_string_pos, compute_display_string_end):
7774 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7777 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7779 Malloc failure behavior now depends on size of allocation.
7780 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7781 * lisp.h: Change signatures accordingly.
7782 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7783 All callers changed. (Bug#8762)
7785 * gnutls.c: Use Emacs's memory allocators.
7786 Without this change, the gnutls library would invoke malloc etc.
7787 directly, which causes problems on non-SYNC_INPUT hosts, and which
7788 runs afoul of improving memory_full behavior. (Bug#8761)
7789 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7790 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7791 xfree instead of the default malloc, realloc, free.
7792 (Fgnutls_boot): No need to check for memory allocation failure,
7793 since xmalloc does that for us.
7795 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7796 * category.c (hash_get_category_set):
7797 * ccl.c (ccl_driver):
7798 * charset.c (Fdefine_charset_internal):
7799 * charset.h (struct charset.hash_index):
7800 * composite.c (get_composition_id, gstring_lookup_cache)
7801 (composition_gstring_put_cache):
7802 * composite.h (struct composition.hash_index):
7803 * dispextern.h (struct image.hash):
7804 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7805 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7806 (hashfn_equal, hashfn_user_defined, make_hash_table)
7807 (maybe_resize_hash_table, hash_lookup, hash_put)
7808 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7809 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7810 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7811 * image.c (make_image, search_image_cache, lookup_image)
7812 (xpm_put_color_table_h):
7813 * lisp.h (struct Lisp_Hash_Table):
7814 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7815 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7816 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7817 * alloc.c (allocate_vectorlike):
7818 Check for overflow in vector size calculations.
7819 * ccl.c (ccl_driver):
7820 Check for overflow when converting EMACS_INT to int.
7821 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7822 need to be updated by these changes.
7823 * fns.c (make_hash_table, maybe_resize_hash_table):
7824 Check for integer overflow with large hash tables.
7825 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7826 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7827 (SXHASH_REDUCE): New macro.
7828 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7829 Use it instead of discarding useful hash info with large hash values.
7830 (sxhash_float): New function.
7831 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7832 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7833 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7834 Rewrite to use FIXNUM_BITS, as this simplifies things.
7835 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7836 Adjust signatures to match updated version of code.
7837 (consing_since_gc): Now EMACS_INT, since a single hash table can
7838 use more than INT_MAX bytes.
7840 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7842 Make it possible to build with GCC-4.6+ -O2 -flto.
7844 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7846 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7848 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7849 Call minibuffer-inactive-mode.
7851 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7853 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7854 Update dependencies.
7856 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7858 * data.c (init_data): Remove code for UTS, this system is not
7861 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7863 Don't force ./temacs to start in terminal mode.
7865 * frame.c (make_initial_frame): Initialize faces in all cases, not
7866 only when CANNOT_DUMP is defined.
7867 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7869 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7871 * dispnew.c (add_window_display_history): Use const for the string
7872 pointer. Remove declaration, not needed.
7874 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7876 Use 'inline', not 'INLINE'.
7877 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7878 * alloc.c, fontset.c (INLINE): Remove.
7879 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7880 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7881 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7882 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7883 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7885 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7887 Make it possible to run ./temacs.
7889 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7890 syms_of_callproc does the same thing. Remove test for
7891 "initialized", do it in the caller.
7892 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7894 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7896 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7897 (read_minibuf): Use get_minibuffer.
7898 (syms_of_minibuf): Use DEFSYM.
7899 (Qmetadata): New var.
7900 * data.c (Qbuffer): Don't make it static.
7901 (syms_of_data): Use DEFSYM.
7903 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7905 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7906 (CCL_CODE_MIN): New macro.
7908 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7910 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7912 * eval.c (Qdebug): Now static.
7913 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7914 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7915 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7917 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7919 * image.c: Various fixes to ImageMagick code comments.
7920 (Fimagemagick_types): Doc fix.
7922 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7924 Minor fixes prompted by GCC 4.6.0 warnings.
7926 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7928 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7929 (x_clipboard_manager_save_all): Move extern decl to ...
7930 * xterm.h: ... here, so that it can be checked for consistency.
7932 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7934 * xselect.c (x_clipboard_manager_save_frame)
7935 (x_clipboard_manager_save_all): New functions.
7936 (Fx_clipboard_manager_save): Lisp function deleted.
7938 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7939 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7941 * xterm.h: Update prototype.
7943 2011-05-28 William Xu <william.xwl@gmail.com>
7945 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7948 2011-05-28 Jim Meyering <meyering@redhat.com>
7950 Avoid a sign-extension bug in crypto_hash_function.
7951 * fns.c (to_uchar): Define.
7952 (crypto_hash_function): Use it to convert some newly-signed
7953 variables to unsigned, to avoid sign-extension bugs. For example,
7954 without this change, (md5 "truc") would evaluate to
7955 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7956 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7957 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7959 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7961 Integer overflow fixes.
7963 * dbusbind.c: Serial number integer overflow fixes.
7964 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7965 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7966 to hold a serial number that is too large for a fixnum.
7967 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7968 Check for serial numbers out of range. Decode any serial number
7969 that was so large that it became a float. (Bug#8722)
7971 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7972 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7973 Use XFASTINT rather than XUINT when numbers are nonnegative.
7974 (xd_append_arg, Fdbus_method_return_internal):
7975 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7976 arguments, check that Lisp number is nonnegative, rather than
7977 silently wrapping negative numbers around. (Bug#8722)
7978 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7981 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7983 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7985 ccl: Add integer overflow checks.
7986 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7987 (IN_INT_RANGE): New macros.
7988 (ccl_driver): Use them to check for integer overflow when
7989 decoding a CCL program. Many of the new checks are whether XINT (x)
7990 fits in int; it doesn't always, on 64-bit hosts. The new version
7991 doesn't catch all possible integer overflows, but it's an
7992 improvement. (Bug#8719)
7994 * alloc.c (make_event_array): Use XINT, not XUINT.
7995 There's no need for unsigned here.
7997 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7998 This follows up to the 2011-05-06 change that substituted uintptr_t
7999 for EMACS_INT. This case wasn't caught back then.
8001 Rework Fformat to avoid integer overflow issues.
8002 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8003 now (part of C89). Include <verify.h>.
8004 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8005 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8006 (Fformat): Avoid the prepass trying to compute sizes; it was only
8007 approximate and thus did not catch overflow reliably. Instead, walk
8008 through the format just once, formatting and computing sizes as we go,
8009 checking for integer overflow at every step, and allocating a larger
8010 buffer as needed. Keep track separately whether the format is
8011 multibyte. Keep only the most-recently calculated precision, rather
8012 than them all. Record whether each argument has been converted to
8013 string. Use EMACS_INT, not int, for byte and char and arg counts.
8014 Support field widths and precisions larger than INT_MAX. Avoid
8015 sprintf's undefined behavior with conversion specifications such as %#d
8016 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8017 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8018 formatting out-of-range floating point numbers with int
8021 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8023 * data.c: Avoid integer truncation in expressions involving floats.
8024 * data.c: Include <intprops.h>.
8025 (arith_driver): When there's an integer overflow in an expression
8026 involving floating point, convert the integers to floating point
8027 so that the resulting value does not suffer from catastrophic
8028 integer truncation. For example, on a 64-bit host (* 4
8029 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8030 Do not rely on undefined behavior after integer overflow.
8032 merge count_size_as_multibyte, parse_str_to_multibyte
8033 * character.c, character.h (count_size_as_multibyte):
8034 Rename from parse_str_to_multibyte; all uses changed.
8035 Check for integer overflow.
8036 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8037 since it's now a duplicate of the other. This is more of
8038 a character than a buffer op, so better that it's in character.c.
8039 * fns.c, print.c: Adjust to above changes.
8041 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8043 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8045 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8047 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8048 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8049 (x_clipboard_manager_save): Now static.
8050 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8052 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8053 (crypto_hash_function): Now static.
8054 Fix pointer signedness problems. Avoid unnecessary initializations.
8056 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8058 * termhooks.h (Vselection_alist): Make it terminal-local.
8060 * terminal.c (create_terminal): Initialize it.
8062 * xselect.c: Support for clipboard managers.
8063 (Vselection_alist): Move to termhooks.h as terminal-local var.
8064 (LOCAL_SELECTION): New macro.
8065 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8066 (symbol_to_x_atom): Remove gratuitous arg.
8067 (x_handle_selection_request, lisp_data_to_selection_data)
8068 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8069 (x_own_selection, x_get_local_selection, x_convert_selection):
8070 New arg, specifying work frame. Use terminal-local Vselection_alist.
8071 (some_frame_on_display): Delete unused function.
8072 (Fx_own_selection_internal, Fx_get_selection_internal)
8073 (Fx_disown_selection_internal, Fx_selection_owner_p)
8074 (Fx_selection_exists_p): New optional frame arg.
8075 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8076 (x_handle_selection_clear): Don't treat other terminals with the
8077 same keyboard specially. Use the terminal-local Vselection_alist.
8078 (x_clear_frame_selections): Use Frun_hook_with_args.
8080 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8082 * xterm.h: Add support for those atoms.
8084 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8086 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8087 (converted_selections, conversion_fail_tag): New global variables.
8088 (x_selection_request_lisp_error): Free the above.
8089 (x_get_local_selection): Remove unnecessary code.
8090 (x_reply_selection_request): Args changed; handle arbitrary array
8091 of converted selections stored in converted_selections.
8092 Separate the XChangeProperty and SelectionNotify steps.
8093 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8094 (x_convert_selection): New function.
8095 (x_handle_selection_event): Simplify.
8096 (x_get_foreign_selection): Don't ignore incoming requests while
8097 waiting for an answer; this will fail when we implement
8098 SAVE_TARGETS, and seems unnecessary anyway.
8099 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8100 (Vx_sent_selection_functions): Doc fix.
8102 2011-05-26 Leo Liu <sdl.web@gmail.com>
8104 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8106 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8108 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8110 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8111 for fringe update if it has periodic bitmap.
8112 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8113 and fringe_bitmap_periodic_p.
8115 * fringe.c (get_fringe_bitmap_data): New function.
8116 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8117 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8118 row. Mark glyph row for fringe update if periodicity changed.
8120 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8121 for fringe update unless it has periodic bitmap.
8123 2011-05-25 Kenichi Handa <handa@m17n.org>
8125 * xdisp.c (get_next_display_element): Set correct it->face_id for
8126 a static composition.
8128 2011-05-24 Leo Liu <sdl.web@gmail.com>
8131 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8133 * fns.c (crypto_hash_function, Fsha1): New function.
8134 (Fmd5): Use crypto_hash_function.
8135 (syms_of_fns): Add Ssha1.
8137 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8139 * gnutls.c: Remove unused macros.
8140 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8141 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8142 Remove macros that are defined and never used.
8143 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8145 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8147 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8148 (Fx_get_selection_internal): Minor cleanup.
8149 (Fx_own_selection_internal): Rename arguments for consistency with
8152 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8154 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8156 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8158 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8160 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8162 * dispnew.c (scrolling_window): Don't exclude the case that the
8163 last enabled row in the desired matrix touches the bottom boundary.
8165 2011-05-21 Glenn Morris <rgm@gnu.org>
8167 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8168 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8169 and add some more files.
8171 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8173 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8174 report_file_error introduced by the change from 2011-05-07.
8176 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8178 * systime.h (Time): Define only if emacs is defined.
8179 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8180 where the include path doesn't have X11/X.h by default. See
8181 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8183 2011-05-20 Kenichi Handa <handa@m17n.org>
8185 * composite.c (find_automatic_composition): Fix previous change.
8187 2011-05-20 Glenn Morris <rgm@gnu.org>
8189 * lisp.mk: New file, split from Makefile.in.
8190 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8191 (shortlisp): Remove.
8192 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8194 2011-05-19 Glenn Morris <rgm@gnu.org>
8196 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8197 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8198 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8199 (lisp): Set the order to that of loadup.el.
8200 (shortlisp): Make it a copy of $lisp.
8201 (SOME_MACHINE_LISP): Remove.
8202 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8203 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8205 2011-05-18 Kenichi Handa <handa@m17n.org>
8207 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8208 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8209 (find_automatic_composition): Mostly rewrite for efficiency.
8211 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8213 * makefile.w32-in: Update dependencies.
8215 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8217 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8218 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8220 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8222 Fix some integer overflow issues, such as string length overflow.
8224 * insdel.c (count_size_as_multibyte): Check for string overflow.
8226 * character.c (lisp_string_width): Check for string overflow.
8227 Use EMACS_INT, not int, for string indexes and lengths; in
8228 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8229 the resulting string length overflows an EMACS_INT; instead,
8230 report a string overflow if no precision given. When checking for
8231 precision exhaustion, use a check that cannot possibly have
8232 integer overflow. (Bug#8675)
8233 * character.h (lisp_string_width): Adjust to new signature.
8235 * alloc.c (string_overflow): New function.
8236 (Fmake_string): Use it. This doesn't change behavior, but saves
8237 a few bytes and will simplify future changes.
8238 * character.c (string_escape_byte8): Likewise.
8239 * lisp.h (string_overflow): New decl.
8241 Fixups, following up to the user-interface timestamp change.
8242 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8243 for UI timestamps, instead of unsigned long.
8244 * msdos.c (mouse_get_pos): Likewise.
8245 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8246 * w32gui.h (Time): Define by including "systime.h" rather than by
8247 declaring it ourselves. (Bug#8664)
8249 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8250 * image.c (clear_image_cache): Likewise.
8252 * term.c (term_mouse_position): Don't assume time_t wraparound.
8254 Be more systematic about user-interface timestamps.
8255 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8256 and sometimes 'EMACS_UINT', to represent these timestamps.
8257 This change causes it to use 'Time' uniformly, as that's what X uses.
8258 This makes the code easier to follow, and makes it easier to catch
8259 integer overflow bugs such as Bug#8664.
8260 * frame.c (Fmouse_position, Fmouse_pixel_position):
8261 Use Time, not unsigned long, for user-interface timestamps.
8262 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8263 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8264 * keyboard.h (last_event_timestamp): Likewise.
8265 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8266 * menu.h (xmenu_show): Likewise.
8267 * term.c (term_mouse_position): Likewise.
8268 * termhooks.h (struct input_event.timestamp): Likewise.
8269 (struct terminal.mouse_position_hook): Likewise.
8270 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8271 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8272 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8273 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8275 * menu.h, termhooks.h: Include "systime.h", for Time.
8277 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8278 Don't assume that the difference between two unsigned long values
8279 can fit into an integer. At this point, we know button_down_time
8280 <= event->timestamp, so the difference must be nonnegative, so
8281 there's no need to cast the result if double-click-time is
8282 nonnegative, as it should be; check that it's nonnegative, just in
8283 case. This bug is triggered when events are more than 2**31 ms
8284 apart (about 25 days). (Bug#8664)
8286 * xselect.c (last_event_timestamp): Remove duplicate decl.
8287 (x_own_selection): Remove needless cast to unsigned long.
8289 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8290 that always fit in int. Use a sentinel instead of a counter, to
8291 avoid a temp and to allay GCC's concerns about possible int overflow.
8292 * frame.h (struct frame): Use int for menu_bar_items_used
8293 instead of EMACS_INT, since it always fits in int.
8295 * menu.c (grow_menu_items): Check for int overflow.
8297 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8299 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8300 Before, the code was not consistent. These values cannot exceed
8301 2**31 - 1 so there's no need to make them unsigned.
8302 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8303 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8304 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8306 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8308 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8309 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8310 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8311 presumably because the widths might not match.
8313 * window.c (size_window): Avoid needless test at loop start.
8315 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8317 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8319 2011-05-12 Drew Adams <drew.adams@oracle.com>
8321 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8323 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8325 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8326 `width' to `bar_area_x' and `bar_area_width', respectively.
8327 (x_scroll_run): Take account of fringe background extension.
8329 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8330 Rename local vars `left' and `width' to `bar_area_x' and
8331 `bar_area_width', respectively.
8332 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8333 background extension.
8335 2011-05-10 Jim Meyering <meyering@redhat.com>
8337 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8339 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8341 * image.c (Finit_image_library): Return t for built-in image types,
8342 like pbm and xbm. (Bug#8640)
8344 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8346 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8348 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8350 * w32console.c (Fset_screen_color): Doc fix.
8351 (Fget_screen_color): New function.
8352 (syms_of_ntterm): Defsubr it.
8354 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8355 unlink the temporary file if Fcall_process didn't create it in the
8357 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8358 child process will be redirected to a file specified with `:file'.
8359 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8360 cue to call_process_cleanup not to close that handle.
8362 2011-05-07 Ben Key <bkey76@gmail.com>
8364 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8365 one of two shell specific rules, either bootstrap-temacs-CMD or
8366 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8367 to the previous implementation of the bootstrap-temacs rule.
8368 The bootstrap-temacs-CMD rule is similar to the previous
8369 implementation of the bootstrap-temacs rule except that it
8370 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8373 These changes, along with some changes to nt/configure.bat,
8374 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8375 earlier fix to add support for --cflags and --ldflags options
8376 that include quotes so that it works whether make uses cmd or
8379 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8381 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8382 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8384 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8385 a string. Handle both cases.
8386 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8387 (Fdbus_register_method): Use Qinvalid_function.
8389 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8391 * makefile.w32-in: Update dependencies.
8392 (LISP_H): Add inttypes.h and stdin.h.
8393 (PROCESS_H): Add unistd.h.
8395 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8397 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8398 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8400 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8402 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8404 * term.c (vfatal): Remove stray call to va_end.
8405 It's not needed and the C Standard doesn't allow it here anyway.
8407 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8408 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8410 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8413 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8415 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8417 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8419 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8421 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8423 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8424 * charset.c (Fdefine_charset_internal): Don't initialize
8425 charset.code_space[15]. The value was garbage, on hosts with
8426 32-bit int (Bug#8600).
8428 * lread.c (read_integer): Be more consistent with string-to-number.
8429 Use string_to_number to do the actual conversion; this avoids
8430 rounding errors and fixes some other screwups. Without this fix,
8431 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8432 (digit_to_number): Move earlier, for benefit of read_integer.
8433 Return -1 if the digit is out of range for the base, -2 if it is
8434 not a digit in any supported base. (Bug#8602)
8436 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8438 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8439 to match comment at start of function. This also removes a
8440 GCC warning about overflow in a 32+64-bit port.
8442 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8444 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8445 Reported by Stefan Monnier in
8446 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8447 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8448 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8450 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8451 (EMACS_UINTPTR): Likewise, with uintptr_t.
8453 * lisp.h: Prefer 64-bit EMACS_INT if available.
8454 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8455 on 32-bit hosts that have 64-bit int, so that they can access
8457 However, temporarily disable this change unless the temporary
8458 symbol WIDE_EMACS_INT is defined.
8460 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8462 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8463 This removes an assumption that EMACS_INT and long are the same
8464 width as pointers. The assumption is true for Emacs porting targets
8465 now, but we want to make other targets possible.
8466 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8467 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8468 In the rest of the code, change types of integers that hold casted
8469 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8470 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8471 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8472 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8473 No need to cast type when ORing.
8474 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8475 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8476 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8477 assume EMACS_INT is the same width as char *.
8478 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8479 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8480 Remove no-longer-needed casts.
8481 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8482 (xg_tool_bar_help_callback, xg_make_tool_item):
8483 Use EMACS_INTPTR to hold an integer
8484 that will be cast to void *; this can avoid a GCC warning
8485 if EMACS_INT is not the same width as void *.
8486 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8487 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8488 (current_message_1, set_message_1):
8489 Use a local to convert to proper width without a cast.
8490 * xmenu.c (dialog_selection_callback): Likewise.
8492 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8493 Also, don't assume VALBITS / RAND_BITS is less than 5,
8494 and don't rely on undefined behavior when shifting a 1 left into
8496 * lisp.h (get_random): Change signature to match.
8498 * lread.c (hash_string): Use size_t, not int, for hash computation.
8499 Normally we prefer signed values; but hashing is special, because
8500 it's better to use unsigned division on hash table sizes so that
8501 the remainder is nonnegative. Also, size_t is the natural width
8502 for hashing into memory. The previous code used 'int', which doesn't
8503 retain enough info to hash well into very large tables.
8504 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8506 * dbusbind.c: Don't possibly lose pointer info when converting.
8507 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8508 Use XPNTR rather than XHASH, so that the high-order bits of
8509 the pointer aren't lost when converting through void *.
8511 * eval.c (Fautoload): Don't double-shift a pointer.
8513 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8515 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8517 * gnutls.c (DEF_GNUTLS_FN):
8518 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8520 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8522 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8525 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8527 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8528 New version that can reserve upto 2GB of heap space.
8530 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8532 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8534 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8536 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8537 `gnutls_certificate_set_x509_key_file'.
8539 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8541 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8542 Update dependencies.
8544 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8546 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8547 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8548 Remove unused parameter `fildes'.
8549 * process.c (read_process_output, send_process): Don't pass it.
8551 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8553 Fix previous change: the library cache is defined in w32.c.
8554 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8555 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8557 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8559 Implement dynamic loading of GnuTLS on Windows.
8561 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8562 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8563 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8566 * gnutls.c (Qgnutls_dll): Define.
8567 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8568 (gnutls_*): Declare function pointers.
8569 (init_gnutls_functions): New function to initialize function pointers.
8570 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8571 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8572 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8573 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8574 (emacs_gnutls_write, emacs_gnutls_read)
8575 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8576 (Fgnutls_available_p): New function.
8577 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8578 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8579 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8581 * image.c: Include w32.h.
8582 (Vimage_type_cache): Delete.
8583 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8584 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8585 (w32_delayed_load): Move to w32.c.
8587 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8589 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8590 (w32_delayed_load): Move from image.c. When loading a library, record
8591 its filename in the :loaded-from property of the library id.
8592 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8593 Initialize and staticpro them.
8594 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8596 * process.c: Include lisp.h before w32.h, not after.
8597 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8598 instead of gnutls_record_check_pending.
8600 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8602 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8604 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8605 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8608 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8610 * xterm.c (x_set_frame_alpha): Do not set property on anything
8611 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8613 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8615 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8617 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8619 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8620 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8621 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8622 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8623 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8624 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8625 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8626 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8627 (Qgnutls_bootprop_callbacks_verify): Make static.
8629 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8631 * callproc.c: Indentation fixup.
8633 * sysdep.c (wait_for_termination_1): Make static.
8634 (wait_for_termination, interruptible_wait_for_termination):
8635 Move after wait_for_termination_1.
8637 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8639 * sysdep.c (interruptible_wait_for_termination): New function
8640 which is like wait_for_termination, but allows keyboard
8643 * callproc.c (Fcall_process): Add (:file "file") as an option for
8645 (Fcall_process_region): Ditto.
8647 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8649 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8650 rather than `XVECTOR (FOO)->size'.
8652 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8653 inttypes.h, as a gnulib replacement is used if it not available in
8656 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8658 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8659 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8660 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8662 * coding.c (coding_alloc_by_realloc): Error out if destination
8663 will grow beyond MOST_POSITIVE_FIXNUM.
8664 (decode_coding_emacs_mule): Abort if there isn't enough place in
8665 charbuf for the composition carryover bytes. Reserve an extra
8666 space for up to 2 characters produced in a loop.
8667 (decode_coding_iso_2022): Abort if there isn't enough place in
8668 charbuf for the composition carryover bytes.
8670 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8672 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8673 aborting when %lld or %lll format is passed.
8674 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8675 %llo or %llx format is passed. (Bug#8545)
8677 * window.c (window_scroll_line_based): Use a marker instead of
8678 simple variables to record original value of point. (Bug#7952)
8680 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8681 produced by %s or %c overflows available buffer space. (Bug#8545)
8683 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8685 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8686 (SIZE_MAX): Move defn after all includes, as they might #define it.
8688 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8690 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8692 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8694 * keyboard.c (Qdelayed_warnings_hook): Define.
8695 (command_loop_1): Run `delayed-warnings-hook'
8696 if Vdelayed_warnings_list is non-nil.
8697 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8698 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8700 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8702 * doprnt.c (doprnt): Don't return value smaller than the buffer
8703 size if the message was truncated. (Bug#8545).
8705 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8707 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8708 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8710 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8712 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8714 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8716 * makefile.w32-in: Update dependencies.
8718 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8720 Improve `doprnt' and its usage. (Bug#8545)
8721 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8722 `format_end'. Remove support for %l as a conversion specifier.
8723 Don't use xrealloc. Improve diagnostics when the %l size modifier
8724 is used. Update the commentary.
8726 * eval.c (verror): Simplify calculation of size_t.
8728 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8731 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8733 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8736 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8738 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8739 This makes this file independent of the recent pseudovector change.
8741 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8743 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8745 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8746 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8747 Remove unused local.
8748 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8750 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8751 GCC 4.6.0 optimizes based on type-based alias analysis.
8752 For example, if b is of type struct buffer * and v of type struct
8753 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8754 != &v->size, and therefore "v->size = 1; b->size = 2; return
8755 v->size;" must therefore return 1. This assumption is incorrect
8756 for Emacs, since it type-puns struct Lisp_Vector * with many other
8757 types. To fix this problem, this patch adds a new type struct
8758 vectorlike_header that documents the constraints on layout of vectors
8759 and pseudovectors, and helps optimizing compilers not get fooled
8760 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8761 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8762 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8764 (XSETPVECTYPE): Rewrite in terms of new macro.
8765 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8766 This is a bit clearer, and further avoids the possibility of
8767 undesirable aliasing.
8768 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8769 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8770 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8771 since Lisp_Subr is a special case (no "next" field).
8772 (ASIZE): Now uses header.size rather than size.
8773 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8774 to avoid the hassle of writing XVECTOR (foo)->header.size.
8775 (struct vectorlike_header): New type.
8776 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8777 object, to help avoid aliasing.
8778 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8779 (SUBRP): Likewise, since Lisp_Subr is a special case.
8780 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8781 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8782 (struct Lisp_Hash_Table): Combine first two members into a single
8783 struct vectorlike_header member. All uses of "size" and "next" members
8784 changed to be "header.size" and "header.next".
8785 * buffer.h (struct buffer): Likewise.
8786 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8787 * frame.h (struct frame): Likewise.
8788 * process.h (struct Lisp_Process): Likewise.
8789 * termhooks.h (struct terminal): Likewise.
8790 * window.c (struct save_window_data, struct saved_window): Likewise.
8791 * window.h (struct window): Likewise.
8792 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8793 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8794 * buffer.c (init_buffer_once): Likewise.
8795 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8797 * process.c (Fformat_network_address): Use local var for size,
8800 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8802 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8803 * data.c (atof): Remove decl; no longer used or needed.
8804 (digit_to_number): Move to lread.c.
8805 (Fstring_to_number): Use new string_to_number function, to be
8806 consistent with how the Lisp reader treats infinities and NaNs.
8807 Do not assume that floating-point numbers represent EMACS_INT
8808 without losing information; this is not true on most 64-bit hosts.
8809 Avoid double-rounding errors, by insisting on integers when
8810 parsing non-base-10 numbers, as the documentation specifies.
8811 * lisp.h (string_to_number): New decl, replacing ...
8812 (isfloat_string): Remove.
8813 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8814 (read1): Do not accept +. and -. as integers; this
8815 appears to have been a coding error. Similarly, do not accept
8816 strings like +-1e0 as floating point numbers. Do not report
8817 overflow for integer overflows unless the base is not 10 which
8818 means we have no simple and reliable way to continue.
8819 Break out the floating-point parsing into a new
8820 function string_to_number, so that Fstring_to_number parses
8821 floating point numbers consistently with the Lisp reader.
8822 (digit_to_number): Move here from data.c. Make it static inline.
8823 (E_CHAR, EXP_INT): Remove, replacing with ...
8824 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8825 (string_to_number): New function, replacing isfloat_string.
8826 This function checks for valid syntax and produces the resulting
8827 Lisp float number too. Rework it so that string-to-number
8828 no longer mishandles examples like "1.0e+". Use strtoumax,
8829 so that overflow for non-base-10 numbers is reported only when
8830 there's no portable and simple way to convert to floating point.
8832 * textprop.c (set_text_properties_1): Rewrite for clarity,
8833 and to avoid GCC warning about integer overflow.
8835 * intervals.h (struct interval): Use EMACS_INT for members
8836 where EMACS_UINT might cause problems. See
8837 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8838 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8839 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8841 (offset_intervals): Tell GCC not to worry about length overflow
8842 when negating a negative length.
8844 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8845 (overrun_check_free): Likewise.
8847 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8848 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8851 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8852 (gnutls_make_error): Rename local to avoid shadowing.
8853 (gnutls_emacs_global_deinit): ifdef out; not used.
8854 (Fgnutls_boot): Use const for pointer to readonly storage.
8855 Comment out unused local. Fix pointer signedness problems.
8857 * lread.c (openp): Don't stuff size_t into an 'int'.
8858 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8859 about possible signed overflow.
8861 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8862 (GDK_KEY_g): Don't define if already defined.
8863 (xg_prepare_tooltip): Avoid pointer signedness problem.
8864 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8866 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8867 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8869 * xfns.c (Fx_window_property): Simplify a bit,
8870 to make a bit faster and to avoid GCC 4.6.0 warning.
8871 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8873 * fns.c (internal_equal): Don't assume size_t fits in int.
8875 * alloc.c (compact_small_strings): Tighten assertion a little.
8877 Replace pEd with more-general pI, and fix some printf arg casts.
8878 * lisp.h (pI): New macro, generalizing old pEd macro to other
8879 conversion specifiers. For example, use "...%"pI"d..." rather
8880 than "...%"pEd"...".
8881 (pEd): Remove. All uses replaced with similar uses of pI.
8882 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8883 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8884 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8885 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8886 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8887 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8888 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8890 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8891 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8892 * print.c (safe_debug_print, print_object): Likewise.
8893 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8895 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8896 avoiding the 0 flag, which is not portable.
8897 * process.c (Fmake_network_process): Use pI to avoid cast.
8898 * region-cache.c (pp_cache): Likewise.
8899 * xdisp.c (decode_mode_spec): Likewise.
8900 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8901 behavior on 64-bit hosts with printf arg.
8902 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8903 (x_stop_queuing_selection_requests): Likewise.
8904 (x_get_window_property): Don't truncate byte count to an 'int'
8907 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8908 here, since it parses constructs like leading '-' and spaces,
8909 which are not wanted; and it overflows with large numbers.
8910 Instead, simply match F[0-9]+, which is what is wanted anyway.
8912 * alloc.c: Remove unportable assumptions about struct layout.
8913 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8914 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8915 (allocate_vectorlike, make_pure_vector): Use the new macros,
8916 plus offsetof, to remove unportable assumptions about struct layout.
8917 These assumptions hold on all porting targets that I know of, but
8918 they are not guaranteed, they're easy to remove, and removing them
8919 makes further changes easier.
8921 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8922 This doesn't fix a bug but makes the code clearer.
8923 (string_overrun_cookie): Now const. Use initializers that
8924 don't formally overflow signed char, to avoid warnings.
8925 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8926 can cause Emacs to crash when string overrun checking is enabled.
8927 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8928 multiple of sizeof (EMACS_INT); it need not be, if
8929 alignof(EMACS_INT) < sizeof (EMACS_INT).
8930 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8932 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8934 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8936 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8938 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8939 supposed to be handshaking. (Bug#8556)
8940 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8942 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8944 * lisp.h (Qdebug): List symbol.
8945 * eval.c (Qdebug): Restore global linkage.
8946 * keyboard.c (debug-on-event): New variable.
8947 (handle_user_signal): Break into debugger when debug-on-event
8948 matches the current signal symbol.
8950 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8952 * alloc.c (check_sblock, check_string_bytes)
8953 (check_string_free_list): Convert to standard C.
8955 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8957 * w32.c (emacs_gnutls_push): Fix typo.
8959 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8961 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8962 "cast to pointer from integer of different size".
8964 Improve doprnt and its use in verror. (Bug#8545)
8965 * doprnt.c (doprnt): Document the set of format control sequences
8966 supported by the function. Use SAFE_ALLOCA instead of always
8969 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8970 is one byte too soon. Don't use xrealloc; instead xfree and
8973 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8975 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8978 * gnutls.c: Renamed global_initialized to
8979 gnutls_global_initialized. Added internals for the
8980 :verify-hostname-error, :verify-error, and :verify-flags
8981 parameters of `gnutls-boot' and documented those parameters in the
8982 docstring. Start callback support.
8983 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8984 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8985 on error. Return error code.
8986 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8987 (emacs_gnutls_read): Likewise.
8988 (Fgnutls_boot): Return handshake error code.
8989 (emacs_gnutls_handle_error): New function.
8990 (wsaerror_to_errno): Likewise.
8992 * w32.h (emacs_gnutls_pull): Add prototype.
8993 (emacs_gnutls_push): Likewise.
8995 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8996 (emacs_gnutls_push): Likewise.
8998 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9000 * process.c (wait_reading_process_output): Check if GnuTLS
9001 buffered some data internally if no FDs are set for TLS
9004 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9005 (LIBS): Link to USER_LIBS.
9006 ($(BLD)/gnutls.$(0)): New target.
9008 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9010 * xdisp.c (handle_single_display_spec): Rename the
9011 display_replaced_before_p argument into display_replaced_p, to
9012 make it consistent with the commentary. Fix typos in the
9015 * textprop.c (syms_of_textprop): Remove dead code.
9016 (copy_text_properties): Delete obsolete commentary about an
9017 interface that was deleted long ago. Fix typos in the description
9020 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9021 to changes in oldXMenu/XMenu.h from 2011-04-16.
9022 <menu_help_message, prev_menu_help_message>: Constify.
9023 (IT_menu_make_room): menu->help_text is now `const char **';
9026 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9027 to changes in oldXMenu/XMenu.h from 2011-04-16.
9028 (struct XMenu): Declare `help_text' `const char **'.
9030 * xfaces.c <Qunspecified>: Make extern again.
9032 * syntax.c: Include sys/types.h before including regex.h, as
9035 * doc.c (get_doc_string): Improve the format passed to `error'.
9037 * doprnt.c (doprnt): Improve commentary.
9039 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9041 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9044 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9045 changes in globals.h immediately force recompilation.
9046 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9047 $(CURDIR)/s/ms-w32.h.
9048 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9050 * character.c (Fchar_direction): Function deleted.
9051 (syms_of_character): Don't defsubr it.
9052 <char-direction-table>: Deleted.
9054 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9056 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9057 * doprnt.c: Include limits.h.
9058 (SIZE_MAX): New macro.
9059 (doprnt): Return a size_t value. 2nd arg is now size_t.
9060 Many local variables are now size_t instead of int or unsigned.
9061 Improve overflow protection. Support `l' modifier for integer
9062 conversions. Support %l conversion. Don't assume an EMACS_INT
9063 argument for integer conversions and for %c.
9065 * lisp.h (doprnt): Restore prototype.
9067 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9070 * Makefile.in (base_obj): Add back doprnt.o.
9072 * deps.mk (doprnt.o): Add back prerequisites.
9073 (callint.o): Depend on character.h.
9075 * eval.c (internal_lisp_condition_case): Include the handler
9076 representation in the error message.
9077 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9078 when breaking from the loop.
9080 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9082 * callint.c (Fcall_interactively): When displaying error message
9083 about invalid control letter, pass the character's codepoint, not
9084 a pointer to its multibyte form. Improve display of the character
9085 in octal and display also its hex code.
9087 * character.c (char_string): Use %x to display the (unsigned)
9088 codepoint of an invalid character, to avoid displaying a bogus
9091 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9092 `error', not SYMBOL_NAME itself.
9094 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9095 character arguments to `error'.
9097 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9098 to `error' in error message about FINAL_CHAR argument. Make sure
9099 FINAL_CHAR is a character, and use %c when it is passed as
9100 argument to `error'.
9102 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9104 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9106 * w32.c: Include <time.h>.
9107 (sys_localtime): New function.
9109 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9111 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9113 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9115 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9117 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9120 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9122 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9123 gl_state.e_property when gl_state.object is Qt.
9125 * insdel.c (make_gap_larger): Remove limitation of buffer size
9128 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9130 * xdisp.c (lookup_glyphless_char_display)
9131 (produce_glyphless_glyph): Handle cons cell entry in
9132 glyphless-char-display.
9133 (Vglyphless_char_display): Document it.
9135 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9136 glyphless-char-display.
9138 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9140 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9142 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9144 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9145 definition for no-X builds.
9147 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9149 Static checks with GCC 4.6.0 and non-default toolkits.
9151 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9153 * process.c (keyboard_bit_set): Define only if SIGIO.
9154 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9155 (send_process): Repair possible setjmp clobbering.
9157 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9159 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9161 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9163 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9164 Define only if needed.
9166 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9167 by pacifying GCC about it. Maybe it's time to retire it?
9168 * xfaces.c (USG, __TIMEVAL__): Likewise.
9170 * dispextern.h (struct redisplay_interface): Rename param
9172 * termhooks.h (struct terminal): Likewise.
9173 * xterm.c (xembed_send_message): Likewise.
9175 * insdel.c (make_gap_smaller): Define only if
9176 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9178 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9181 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9182 so that we aren't warned about unused symbols.
9184 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9186 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9188 * xfns.c (x_real_positions): Mark locals as initialized.
9190 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9192 * xterm.c: Fix problems found by static analysis with other toolkits.
9193 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9194 (x_dispatch_event): Declare static if USE_GTK, and
9195 define if USE_GTK || USE_X_TOOLKIT.
9196 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9197 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9198 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9199 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9201 * xmenu.c (menu_help_callback): Pointer type fixes.
9202 Use const pointers when pointing at readonly data. Avoid pointer
9204 (FALSE): Remove unused macro.
9205 (update_frame_menubar): Remove unused decl.
9207 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9209 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9210 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9211 (single_menu_item): Rename local to avoid shadowing.
9213 * keyboard.c (make_lispy_event): Remove unused local var.
9215 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9216 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9218 * bitmaps: Change bitmaps from unsigned char back to the X11
9219 compatible char. Avoid the old compiler warnings about
9220 out-of-range initializers by using, for example, '\xab' rather
9223 * xgselect.c (xgselect_initialize): Check vs interface
9224 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9226 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9228 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9229 to read-only memory.
9231 * fns.c (vector): Remove; this old hack is no longer needed.
9233 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9235 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9237 * xrdb.c (x_load_resources): Omit unused local.
9239 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9240 (x_window): Rename locals to avoid shadowing.
9241 (USG): Use the kludged USG macro, to pacify gcc.
9243 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9244 (x_term_init): Remove local to avoid shadowing.
9246 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9248 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9249 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9251 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9253 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9255 Fix regex.c, syntax.c and friends for buffers > 2GB.
9256 * syntax.h (struct gl_state_s): Declare character position members
9259 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9261 * textprop.c (verify_interval_modification, interval_of):
9262 Declare arguments EMACS_INT.
9264 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9267 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9269 * indent.c (Fvertical_motion): Local variable it_start is now
9272 * regex.c (re_match, re_match_2, re_match_2_internal)
9273 (bcmp_translate, regcomp, regexec, print_double_string)
9274 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9275 (re_compile_pattern, re_exec): Declare arguments and local
9276 variables `size_t' and `ssize_t' and return values `regoff_t', as
9278 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9279 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9280 <compile_stack_type>: `size' and `avail' are now `size_t'.
9282 * regex.h <regoff_t>: Use ssize_t, not int.
9283 (re_search, re_search_2, re_match, re_match_2): Arguments that
9284 specify buffer/string position and length are now ssize_t and
9285 size_t. Return type is regoff_t.
9287 2011-04-16 Ben Key <bkey76@gmail.com>
9289 * nsfont.m: Fixed bugs in ns_get_family and
9290 ns_descriptor_to_entity that were caused by using free to
9291 deallocate memory blocks that were allocated by xmalloc (via
9292 xstrdup). This caused Emacs to crash when compiled with
9293 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9294 --enable-checking=xmallocoverrun). xfree is now used to
9295 deallocate these memory blocks.
9297 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9299 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9301 emacs_write: Accept and return EMACS_INT for sizes.
9302 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9304 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9305 Accept and return EMACS_INT.
9306 (emacs_gnutls_write): Return the number of bytes written on
9308 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9309 (emacs_read, emacs_write): Remove check for negative size, as the
9310 Emacs source code has been audited now.
9311 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9312 (emacs_read, emacs_write): Use it.
9313 * process.c (send_process): Adjust to the new signatures of
9314 emacs_write and emacs_gnutls_write. Do not attempt to store
9315 a byte offset into an 'int'; it might overflow.
9316 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9318 * sound.c: Don't assume sizes fit in 'int'.
9319 (struct sound_device.period_size, alsa_period_size):
9320 Return EMACS_INT, not int.
9321 (struct sound_device.write, vox_write, alsa_write):
9322 Accept EMACS_INT, not int.
9323 (wav_play, au_play): Use EMACS_INT to store sizes and to
9324 record read return values.
9326 2011-04-15 Ben Key <bkey76@gmail.com>
9328 * keyboard.c (Qundefined): Don't declare static since it is used
9330 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9331 static since they are used in nsfont.m.
9333 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9335 * process.c (Qprocessp): Don't declare static.
9336 * lisp.h (Qprocessp): Declare again.
9338 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9340 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9342 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9344 Improve C-level modularity by making more things 'static'.
9346 Don't publish debugger-only interfaces to other modules.
9347 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9348 (verify_bytepos, count_markers): Move decls to the only modules
9350 * region-cache.h (pp_cache): Likewise.
9351 * window.h (check_all_windows): Likewise.
9352 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9354 * sysdep.c (croak): Now static, if
9355 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9356 * syssignal.h (croak): Declare only if not static.
9358 * alloc.c (refill_memory_reserve): Now static if
9359 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9360 * lisp.h (refill_memory_reserve): Declare only if not static.
9362 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9363 Define only if USE_LUCID.
9365 * xrdb.c (x_customization_string, x_rm_string): Now static.
9367 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9368 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9370 * xdisp.c (draw_row_with_mouse_face): Now static.
9371 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9373 * window.h (check_all_windows): Mark externally visible.
9375 * window.c (window_deletion_count): Now static.
9377 * undo.c: Make symbols static if they're not exported.
9378 (last_undo_buffer, last_boundary_position, pending_boundary):
9381 * textprop.c (interval_insert_behind_hooks): Now static.
9382 (interval_insert_in_front_hooks): Likewise.
9384 * term.c: Make symbols static if they're not exported.
9385 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9386 (max_frame_lines, tty_set_terminal_modes):
9387 (tty_reset_terminal_modes, tty_turn_off_highlight):
9388 (get_tty_terminal): Now static.
9389 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9390 * termhooks.h (term_mouse_moveto): Do not declare if
9392 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9393 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9395 * sysdep.c: Make symbols static if they're not exported.
9396 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9398 (sigprocmask_set, full_mask): Remove; unused.
9399 (wait_debugging): Mark as visible.
9400 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9401 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9403 * syntax.c (syntax_temp): Define only if !__GNUC__.
9405 * sound.c (current_sound_device, current_sound): Now static.
9407 * search.c (searchbufs, searchbuf_head): Now static.
9409 * scroll.c (scroll_cost): Remove; unused.
9410 * dispextern.h (scroll_cost): Remove decl.
9412 * region-cache.h (pp_cache): Mark as externally visible.
9414 * process.c: Make symbols static if they're not exported.
9415 (process_tick, update_tick, create_process, chan_process):
9416 (Vprocess_alist, proc_buffered_char, datagram_access):
9417 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9418 (deactivate_process): Mark defn as static, as well as decl.
9419 * lisp.h (create_process): Remove decl.
9420 * process.h (chan_process, Vprocess_alist): Remove decls.
9422 * print.c: Make symbols static if they're not exported.
9423 (print_depth, new_backquote_output, being_printed, print_buffer):
9424 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9425 (print_interval, print_number_index, initial_stderr_stream):
9427 * lisp.h (Fprinc): Remove decl.
9428 (debug_output_compilation_hack): Mark as externally visible.
9430 * sysdep.c (croak): Move decl from here to syssignal.h.
9431 * syssignal.h (croak): Put it here, so the API can be checked when
9432 'croak' is called from dissociate_if_controlling_tty.
9434 * minibuf.c: Make symbols static if they're not exported.
9435 (minibuf_save_list, choose_minibuf_frame): Now static.
9436 * lisp.h (choose_minibuf_frame): Remove decl.
9438 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9440 * lread.c: Make symbols static if they're not exported.
9441 (read_objects, initial_obarray, oblookup_last_bucket_number):
9443 (make_symbol): Remove; unused.
9444 * lisp.h (initial_obarray, make_symbol): Remove decls.
9446 * keyboard.c: Make symbols static if they're not exported.
9447 (single_kboard, recent_keys_index, total_keys, recent_keys):
9448 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9449 (this_single_command_key_start, echoing, last_auto_save):
9450 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9451 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9452 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9453 (Vlispy_mouse_stem, double_click_count):
9455 (force_auto_save_soon): Define only if SIGDANGER.
9456 (ignore_mouse_drag_p): Now static if
9457 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9458 (print_help): Remove; unused.
9459 (stop_character, last_timer_event): Mark as externally visible.
9460 * keyboard.h (ignore_mouse_drag_p): Declare only if
9461 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9462 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9463 * lisp.h (echoing): Remove decl.
9464 (force_auto_save_soon): Declare only if SIGDANGER.
9465 * xdisp.c (redisplay_window): Simplify code, to make it more
9466 obvious that ignore_mouse_drag_p is not accessed if !defined
9467 USE_GTK && !defined HAVE_NS.
9469 * intervals.c: Make symbols static if they're not exported.
9470 (merge_properties_sticky, merge_interval_right, delete_interval):
9472 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9474 * insdel.c: Make symbols static if they're not exported.
9475 However, leave prepare_to_modify_buffer alone. It's never
9476 called from outside this function, but that appears to be a bug.
9477 (combine_after_change_list, combine_after_change_buffer):
9478 (adjust_after_replace, signal_before_change): Now static.
9479 (adjust_after_replace_noundo): Remove; unused.
9480 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9481 (signal_before_change): Remove decls.
9483 * indent.c (val_compute_motion, val_vmotion): Now static.
9485 * image.c: Make symbols static if they're not exported.
9486 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9488 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9489 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9491 * fringe.c (standard_bitmaps): Now static.
9492 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9494 * frame.c: Make symbols static if they're not exported.
9495 (x_report_frame_params, make_terminal_frame): Now static.
9496 (get_frame_param): Now static, unless HAVE_NS.
9497 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9498 (x_get_resource_string): Remove; not used.
9499 * frame.h (make_terminal_frame, x_report_frame_params):
9500 (x_get_resource_string); Remove decls.
9501 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9502 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9504 * font.c, fontset.c: Make symbols static if they're not exported.
9505 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9506 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9507 * font.c (font_close_object): Now static.
9508 * font.h (font_close_object): Remove.
9509 * fontset.c (FONTSET_OBJLIST): Remove.
9510 (free_realized_fontset) #if-0 the body, which does nothing.
9511 (face_suitable_for_char_p): #if-0, as it's never called.
9512 * fontset.h (face_suitable_for_char_p): Remove decl.
9513 * xfaces.c (face_at_string_position):
9514 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9515 since 0 is always ASCII.
9517 * fns.c (weak_hash_tables): Now static.
9519 * fileio.c: Make symbols static if they're not exported.
9520 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9521 (Vwrite_region_annotation_buffers): Now static.
9523 * eval.c: Make symbols static if they're not exported.
9524 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9525 * lisp.h (backtrace_list): Remove decl.
9527 * emacs.c: Make symbols static if they're not exported.
9528 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9529 (fatal_error_code, fatal_error_signal_hook, standard_args):
9531 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9532 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9533 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9534 * lisp.h (fatal_error_signal_hook): Remove decl.
9535 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9537 * editfns.c: Move a (normally-unused) function to its only use.
9538 * editfns.c, lisp.h (get_operating_system_release): Remove.
9539 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9540 worth the hassle of breaking this out.
9542 * xterm.c: Make symbols static if they're not exported.
9543 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9544 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9545 (x_destroy_window, x_delete_display):
9547 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9548 (x_mouse_leave): Remove; unused.
9549 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9550 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9551 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9553 (x_mouse_leave): Declare only if WINDOWSNT.
9554 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9555 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9558 * ftxfont.c: Make symbols static if they're not exported.
9559 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9561 * font.h (ftxfont_driver): Likewise.
9563 * xfns.c: Make symbols static if they're not exported.
9564 (x_last_font_name, x_display_info_for_name):
9565 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9566 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9567 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9568 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9569 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9570 (last_show_tip_args): Now static.
9571 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9572 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9573 (x_screen_planes): Remove; unused.
9574 * dispextern.h (x_screen_planes): Remove decl.
9576 * dispnew.c: Make symbols static if they're not exported.
9577 * dispextern.h (redraw_garbaged_frames, scrolling):
9578 (increment_row_positions): Remove.
9579 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9580 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9582 (redraw_garbaged_frames): Remove; unused.
9584 * xfaces.c: Make symbols static if they're not exported.
9585 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9587 * xterm.h (defined_color): Remove decls.
9588 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9589 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9590 (menu_face_changed_default, defined_color, free_realized_face):
9591 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9592 (ascii_face_of_lisp_face): Remove; unused.
9594 * xdisp.c: Make symbols static if they're not exported.
9595 * dispextern.h (scratch_glyph_row, window_box_edges):
9596 (glyph_to_pixel_coords, set_cursor_from_row):
9597 (get_next_display_element, set_iterator_to_next):
9598 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9599 (show_mouse_face): Remove decls
9600 * frame.h (message_buf_print): Likewise.
9601 * lisp.h (pop_message, set_message, check_point_in_composition):
9603 * xterm.h (set_vertical_scroll_bar): Likewise.
9604 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9605 (message_buf_print, scratch_glyph_row, displayed_buffer):
9606 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9607 (get_next_display_element, show_mouse_face, window_box_edges):
9608 (frame_to_window_pixel_xy, check_point_in_composition):
9609 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9610 (glyph_to_pixel_coords): Remove; unused.
9612 * dired.c (file_name_completion): Now static.
9614 * dbusbind.c (xd_in_read_queued_messages): Now static.
9616 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9617 * data.c (circular_list_error): Remove.
9619 * commands.h (last_point_position, last_point_position_buffer):
9620 (last_point_position_window): Remove decls.
9621 * keyboard.c: Make these variables static.
9623 * coding.h (coding, code_convert_region, encode_coding_gap):
9625 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9626 (iso_code_class, detect_coding, code_convert_region): Now static.
9627 (encode_coding_gap): Remove; unused.
9629 * chartab.c (chartab_chars, chartab_bits): Now static.
9631 * charset.h (charset_iso_8859_1): Remove decl.
9632 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9635 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9636 * ccl.c (Vccl_program_table): Now static.
9637 (check_ccl_update): Remove; unused.
9639 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9640 * category.h: ... from here.
9641 * category.c (check_category_table, set_category_set): Now static.
9643 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9644 * lisp.h: Remove these decls.
9646 * buffer.c (buffer_count): Remove unused var.
9648 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9649 so that it's not optimized away.
9650 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9651 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9652 exported only to the debugger.
9654 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9655 * atimer.h (run_all_atimers): Remove; not exported.
9657 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9658 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9659 was inaccessible from Lisp.
9660 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9661 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9663 alloc.c: Import and export fewer symbols, and remove unused items.
9664 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9666 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9667 it's not optimized away by whole-program optimization.
9668 (message_enable_multibyte, free_misc): Remove.
9669 (catchlist, handlerlist, mark_backtrace):
9670 Declare only if BYTE_MARK_STACK.
9671 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9672 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9673 (message_enable_multibyte): Remove decl.
9674 (free_misc, interval_free_list, float_block, float_block_index):
9675 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9676 (cons_free_list, last_marked_index):
9678 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9679 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9680 (mark_backtrace): Define only if BYTE_MARK_STACK.
9681 * xdisp.c (message_enable_multibyte): Now static.
9683 Declare Lisp_Object Q* variables to be 'static' if not exported.
9684 This makes it easier for human readers (and static analyzers)
9685 to see whether these variables are used from other modules.
9686 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9687 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9688 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9689 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9690 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9691 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9692 * xmenu.c, xselect.c:
9693 Declare Q* vars static if they are not used in other modules.
9694 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9695 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9696 Remove decls of unexported vars.
9697 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9699 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9701 Make Emacs functions such as Fatom 'static' by default.
9702 This makes it easier for human readers (and static analyzers)
9703 to see whether these functions can be called from other modules.
9704 DEFUN now defines a static function. To make the function external
9705 so that it can be used in other C modules, use the new macro DEFUE.
9706 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9707 (Finit_image_library):
9708 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9709 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9710 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9711 Remove decls, since these functions are now static.
9712 (Funintern, Fget_internal_run_time): New decls, since these functions
9713 were already external.
9715 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9716 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9717 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9718 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9719 * keyboard.c, keymap.c, lread.c:
9720 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9721 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9722 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9723 Mark functions with DEFUE instead of DEFUN,
9724 if they are used in other modules.
9725 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9726 decls for now-static functions.
9727 * buffer.h (Fdelete_overlay): Remove decl.
9728 * callproc.c (Fgetenv_internal): Mark as internal.
9729 * composite.c (Fremove_list_of_text_properties): Remove decl.
9730 (Fcomposition_get_gstring): New forward static decl.
9731 * composite.h (Fcomposite_get_gstring): Remove decl.
9732 * dired.c (Ffile_attributes): New forward static decl.
9733 * doc.c (Fdocumntation_property): New forward static decl.
9734 * eval.c (Ffetch_bytecode): New forward static decl.
9735 (Funintern): Remove extern decl; now in .h file where it belongs.
9736 * fileio.c (Fmake_symbolic_link): New forward static decl.
9737 * image.c (Finit_image_library): New forward static decl.
9738 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9739 * intervals.h (Fprevious_property_change):
9740 (Fremove_list_of_text_properties): Remove decls.
9741 * keyboard.c (Fthis_command_keys): Remove decl.
9742 (Fcommand_execute): New forward static decl.
9743 * keymap.c (Flookup_key): New forward static decl.
9744 (Fcopy_keymap): Now static.
9745 * keymap.h (Flookup_key): Remove decl.
9746 * process.c (Fget_process): New forward static decl.
9747 (Fprocess_datagram_address): Mark as internal.
9748 * syntax.c (Fsyntax_table_p): New forward static decl.
9749 (skip_chars): Remove duplicate decl.
9750 * textprop.c (Fprevious_property_change): New forward static decl.
9751 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9753 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9754 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9756 * editfns.c (Fformat): Remove unreachable code.
9758 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9760 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9763 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9765 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9766 when at ZV. (Bug#8487)
9768 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9770 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9772 * keyboard.c (parse_tool_bar_item): Likewise.
9773 * sound.c (sound_cleanup, alsa_close): Likewise.
9774 * termcap.c (tgetent): Likewise.
9775 * xfns.c (x_default_font_parameter): Likewise.
9776 * xsettings.c (read_and_apply_settings): Likewise.
9778 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9779 (overrun_check_free): Protoize.
9781 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9783 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9784 since callers should never pass a negative size.
9785 Change the signature to match that of plain 'read' and 'write'; see
9786 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9787 * lisp.h: Update prototypes of emacs_write and emacs_read.
9789 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9791 * xdisp.c (redisplay_window): Don't try to determine the character
9792 position of the scroll margin if the window start point w->startp
9793 is outside the buffer's accessible region. (Bug#8468)
9795 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9797 Fix write-region and its subroutines for buffers > 2GB.
9798 * fileio.c (a_write, e_write): Modify declaration of arguments and
9799 local variables to support buffers larger than 2GB.
9800 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9802 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9803 argument, local variables, and return value.
9805 * lisp.h: Update prototypes of emacs_write and emacs_read.
9807 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9809 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9811 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9813 Fix more problems found by GCC 4.6.0's static checks.
9815 * xdisp.c (vmessage): Use a better test for character truncation.
9817 * charset.c (load_charset_map): <, not <=, for optimization,
9818 and to avoid potential problems with integer overflow.
9819 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9820 * casetab.c (set_identity, shuffle): Likewise.
9821 * editfns.c (Fformat): Likewise.
9822 * syntax.c (skip_chars): Likewise.
9824 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9825 This also lets GCC 4.6.0 generate slightly better loop code.
9827 * callint.c (Fcall_interactively): <, not <=, for optimization.
9828 (Fcall_interactively): Count the number of arguments produced,
9829 not the number of arguments given. This is simpler and lets GCC
9830 4.6.0 generate slightly better code.
9832 * ftfont.c: Distingish more carefully between FcChar8 and char.
9833 The previous code passed unsigned char * to a functions like
9834 strlen and xstrcasecmp that expect char *, which does not
9835 conform to the C standard.
9836 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9837 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9838 char * when the C standard requires it.
9840 * keyboard.c (read_char): Remove unused var.
9842 * eval.c: Port to Windows vsnprintf (Bug#8435).
9844 (SIZE_MAX): Define if the headers do not.
9845 (verror): Do not give up if vsnprintf returns a negative count.
9846 Instead, grow the buffer. This ports to Windows vsnprintf, which
9847 does not conform to C99. Problem reported by Eli Zaretskii.
9848 Also, simplify the allocation scheme, by avoiding the need for
9849 calling realloc, and removing the ALLOCATED variable.
9851 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9853 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9854 But keep the doprint source code for now, as we might revamp it
9855 and use it again (Bug#8435).
9856 * lisp.h (doprnt): Remove.
9857 * Makefile.in (base_obj): Remove doprnt.o.
9858 * deps.mk (doprnt.o): Remove.
9860 error: Print 32- and 64-bit integers portably (Bug#8435).
9861 Without this change, on typical 64-bit hosts error ("...%d...", N)
9862 was used to print both 32- and 64-bit integers N, which relied on
9864 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9865 * lisp.h (error, verror): Mark as printf-like functions.
9866 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9867 Report overflow in size calculations when allocating printf buffer.
9868 Do not truncate output string at its first null byte.
9869 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9870 Truncate the output at a character boundary, since vsnprintf does not
9872 * charset.c (check_iso_charset_parameter): Convert internal
9873 character to string before calling 'error', since %c now has the
9875 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9876 overflow when computing char to be passed to 'error'. Do not
9877 pass Lisp_Object to 'error'; pass the integer instead.
9878 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9879 formatted with plain %d.
9881 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9883 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9885 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9887 * xterm.c (x_catch_errors): Remove duplicate declaration.
9889 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9891 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9893 2011-04-10 Jim Meyering <meyering@redhat.com>
9895 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9896 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9897 return ssize_t not "int", and use size_t as the buffer length.
9898 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9899 * gnutls.h: Update declarations.
9900 * process.c (read_process_output): Use ssize_t, to match.
9901 (send_process): Likewise.
9903 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9905 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9907 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9909 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9910 Use unsigned char, to match FcChar8 type definition.
9912 * xterm.c (handle_one_xevent):
9913 * xmenu.c (create_and_show_popup_menu):
9914 * xselect.c (x_decline_selection_request)
9915 (x_reply_selection_request): Avoid type-punned deref of X events.
9917 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9919 Fix some uses of `int' instead of EMACS_INT.
9920 * search.c (string_match_1, fast_string_match)
9921 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9922 (scan_buffer, find_next_newline_no_quit)
9923 (find_before_next_newline, search_command, Freplace_match)
9924 (Fmatch_data): Make some `int' variables be EMACS_INT.
9926 * xdisp.c (display_count_lines): 3rd argument and return value now
9927 EMACS_INT. All callers changed.
9928 (pint2hrstr): Last argument is now EMACS_INT.
9930 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9931 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9932 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9933 (decode_coding_utf_16, decode_coding_emacs_mule)
9934 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9935 (decode_coding_ccl, decode_coding_charset)
9936 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9937 (decode_coding_iso_2022, decode_coding_emacs_mule)
9938 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9939 <char_offset, last_offset>: Declare EMACS_INT.
9940 (encode_coding_utf_8, encode_coding_utf_16)
9941 (encode_coding_emacs_mule, encode_invocation_designation)
9942 (encode_designation_at_bol, encode_coding_iso_2022)
9943 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9944 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9946 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9947 (encode_invocation_designation): Last argument P_NCHARS is now
9949 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9950 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9952 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9955 * ccl.c (Fccl_execute_on_string): Declare some variables
9958 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9960 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9962 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9964 * process.c (Fformat_network_address): Doc fix.
9966 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9968 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9970 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9972 * keyboard.c (read_char): Call Lisp function help-form-show,
9973 instead of using internal_with_output_to_temp_buffer.
9974 (Qhelp_form_show): New var.
9975 (syms_of_keyboard): Use DEFSYM macro.
9977 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9979 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9981 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9983 * process.c (Flist_processes): Remove to Lisp.
9984 (list_processes_1): Delete.
9986 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9988 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9990 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9992 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9994 Fix more problems found by GCC 4.6.0's static checks.
9996 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9998 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10000 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10002 * xdisp.c (vmessage): Mark as a printf-like function.
10004 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10006 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10008 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10009 printf-like functions.
10010 (tiff_load): Add casts to remove these marks before passing them
10011 to system-supplied API.
10013 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10015 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10016 This avoids several warnings with gcc -Wstrict-overflow.
10017 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10018 directly, rather than having caller test rule sign. This avoids
10019 some unnecessary tests.
10020 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10021 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10022 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10024 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10025 (xfont_open): Avoid unnecessary tests.
10027 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10029 * composite.h, composite.c (composition_gstring_put_cache):
10030 Use EMACS_INT, not int, for length.
10032 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10033 breaking out part of COMPOSITION_DECODE_RULE.
10034 (COMPOSITION_DECODE_RULE): Use it.
10035 * composite.c (get_composition_id): Remove unused local vars,
10036 by using the new macro.
10038 * textprop.c (set_text_properties_1): Change while to do-while,
10039 since the condition is always true at first.
10041 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10042 (interval_deletion_adjustment): Return unsigned value.
10045 * process.c (list_processes_1, create_pty, read_process_output):
10046 (exec_sentinel): Remove vars that were set but not used.
10047 (create_pty): Remove unnecessary "volatile"s.
10048 (Fnetwork_interface_info): Avoid possibility of int overflow.
10049 (read_process_output): Do adaptive read buffering even if carryover.
10050 (read_process_output): Simplify nbytes computation if buffered.
10052 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10054 * syntax.c (scan_words): Remove var that was set but not used.
10055 (update_syntax_table): Use unsigned instead of int.
10057 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10058 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10059 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10061 * print.c (print_error_message): Avoid int overflow.
10063 * font.c (font_list_entities): Redo for clarity,
10064 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10066 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10067 (font_score): Avoid potential overflow in diff calculation.
10069 * fns.c (substring_both): Remove var that is set but not used.
10070 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10072 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10074 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10075 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10076 can always succeed if overflow has undefined behavior.
10078 * search.c (boyer_moore, wordify): Remove vars set but not used.
10079 (wordify): Omit three unnecessary tests.
10081 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10082 All callers changed. This avoids the need for an unused var.
10084 * casefiddle.c (casify_region): Remove var that is set but not used.
10086 * dired.c (file_name_completion): Remove var that is set but not used.
10088 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10090 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10091 (Finsert_file_contents): Remove unnecessary code checking fd.
10093 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10094 Check for integer overflow on size calculations.
10096 * buffer.c (Fprevious_overlay_change): Remove var that is set
10099 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10100 Remove vars that are set but not used.
10101 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10102 (timer_check_2): Mark vars as initialized.
10104 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10106 * image.c (lookup_image): Remove var that is set but not used.
10107 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10109 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10110 that are set but not used.
10112 * xfns.c (make_invisible_cursor): Don't return garbage
10113 if XCreateBitmapFromData fails (Bug#8410).
10115 * xselect.c (x_get_local_selection, x_handle_property_notify):
10116 Remove vars that are set but not used.
10118 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10119 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10121 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10122 Remove var that is set but not used.
10123 (scroll_bar_windows_size): Now size_t, not int.
10124 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10125 Check for overflow.
10127 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10128 (map_tty_color) [!defined MSDOS]: Likewise.
10130 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10132 * coding.c: Remove vars that are set but not used.
10133 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10134 All callers changed.
10135 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10136 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10137 (decode_coding_charset): Remove vars that are set but not used.
10139 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10140 that is set but not used.
10142 * print.c (print_object): Remove var that is set but not used.
10144 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10145 The gnulib version avoids calling malloc in the usual case,
10146 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10147 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10148 * filelock.c (current_lock_owner): Likewise.
10149 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10150 * sysdep.c: Include allocator.h, careadlinkat.h.
10151 (emacs_no_realloc_allocator): New static constant.
10152 (emacs_readlink): New function.
10153 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10154 ../lib/careadlinkat.h.
10156 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10158 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10159 first non-nil return value).
10161 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10163 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10164 if not defined (Bug#8403).
10166 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10168 * xdisp.c (display_count_lines): Remove parameter `start',
10169 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10170 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10171 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10172 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10173 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10174 and thereabouts. All callers changed.
10175 (get_per_char_metric): Remove parameter `f', unused since
10176 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10178 2011-04-02 Jim Meyering <meyering@redhat.com>
10180 do not dereference NULL upon failed strdup
10181 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10182 (ns_get_family): Likewise.
10184 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10186 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10188 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10190 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10193 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10195 Add lexical binding.
10197 * window.c (Ftemp_output_buffer_show): New fun.
10198 (Fsave_window_excursion):
10199 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10201 * lread.c (lisp_file_lexically_bound_p): New function.
10202 (Fload): Bind Qlexical_binding.
10203 (readevalloop): Remove `evalfun' arg.
10204 Bind Qinternal_interpreter_environment.
10205 (Feval_buffer): Bind Qlexical_binding.
10206 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10208 (syms_of_lread): Declare `lexical-binding'.
10210 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10212 * keyboard.c (eval_dyn): New fun.
10213 (menu_item_eval_property): Use it.
10215 * image.c (parse_image_spec): Use Ffunctionp.
10217 * fns.c (concat, mapcar1): Accept byte-code-functions.
10219 * eval.c (Fsetq): Handle lexical vars.
10220 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10221 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10222 (FletX, Flet): Obey lexical binding.
10223 (Fcommandp): Handle closures.
10224 (Feval): New `lexical' arg.
10225 (eval_sub): New function extracted from Feval. Use it almost
10226 everywhere where Feval was used. Look up vars in lexical env.
10228 (Ffunctionp): Move from subr.el.
10229 (Ffuncall): Handle closures.
10230 (apply_lambda): Remove `eval_flags'.
10231 (funcall_lambda): Handle closures and new byte-code-functions.
10232 (Fspecial_variable_p): New function.
10233 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10234 but without exporting it to Lisp.
10236 * doc.c (Fdocumentation, store_function_docstring):
10237 * data.c (Finteractive_form): Handle closures.
10239 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10242 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10244 (exec_byte_code): New function extracted from Fbyte_code to handle new
10245 calling convention for byte-code-functions. Add new byte-codes.
10247 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10249 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10251 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10253 * xdisp.c (redisplay_internal): Fix prototype.
10255 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10257 * xdisp.c (SCROLL_LIMIT): New macro.
10258 (try_scrolling): Use it when setting scroll_limit.
10259 Limit scrolling to 100 screen lines.
10260 (redisplay_window): Even when falling back on "recentering",
10261 position point in the window according to scroll-conservatively,
10262 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10264 (try_scrolling): When point is above the window, allow searching
10265 as far as scroll_max, or one screenful, to compute vertical
10266 distance from PT to the scroll margin position. This prevents
10267 try_scrolling from unnecessarily failing when
10268 scroll-conservatively is set to a value slightly larger than the
10269 window height. Clean up the case of PT below the margin at bottom
10270 of window: scroll_max can no longer be INT_MAX. When aggressive
10271 scrolling is in use, don't let point enter the opposite scroll
10272 margin as result of the scroll.
10273 (syms_of_xdisp) <scroll-conservatively>: Document the
10274 threshold of 100 lines for never-recentering scrolling.
10276 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10278 * dispextern.h (move_it_by_lines):
10279 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10280 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10281 (message_log_check_duplicate): Remove parameters `prev_bol' and
10282 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10283 (redisplay_internal): Remove parameter `preserve_echo_area',
10284 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10286 * indent.c (Fvertical_motion):
10287 * window.c (window_scroll_pixel_based, Frecenter):
10288 Don't pass `need_y_p' to `move_it_by_lines'.
10290 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10292 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10293 steal a few bits to be more compact.
10294 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10295 Remove unneeded casts.
10297 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10299 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10301 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10302 binding" message (bug#7967).
10304 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10306 Fix more problems found by GCC 4.6.0's static checks.
10308 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10309 Remove unused local var.
10311 * editfns.c (Fmessage_box): Remove unused local var.
10313 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10314 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10315 Omit unused local vars.
10316 * window.c (shrink_windows): Omit unused local var.
10317 * menu.c (digest_single_submenu): Omit unused local var.
10318 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10319 Omit unused local var.
10321 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10322 Don't assume string length fits in int.
10323 (keyremap_step, read_key_sequence): Use size_t for sizes.
10324 (read_key_sequence): Don't check last_real_key_start redundantly.
10326 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10327 instead of alloca (Bug#8344).
10329 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10330 (Fbacktrace_frame): Don't assume nframes fits in int.
10332 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10334 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10337 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10339 * cm.c (calccost): Turn while-do into do-while, for clarity.
10341 * keyboard.c (syms_of_keyboard): Use the same style as later
10342 in this function when indexing through an array. This also
10343 works around GCC bug 48267.
10345 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10347 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10349 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10350 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10352 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10353 This avoids undefined behavior on integer overflow, and is a bit
10354 more convenient anyway since it is compared to a size_t variable.
10356 Variadic C functions now count arguments with size_t, not int.
10357 This avoids an unnecessary limitation on 64-bit machines, which
10358 caused (substring ...) to crash on large vectors (Bug#8344).
10359 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10360 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10361 All variadic functions and their callers changed accordingly.
10362 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10363 * data.c (arith_driver, float_arith_driver): Likewise.
10364 * editfns.c (general_insert_function): Likewise.
10365 * eval.c (struct backtrace.nargs, interactive_p)
10366 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10367 (funcall_lambda, mark_backtrace): Likewise.
10368 * fns.c (concat): Likewise.
10369 * frame.c (x_set_frame_parameters): Likewise.
10370 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10371 0 if not found, not -1. All callers changed.
10373 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10374 (stack_copy_size): Now size_t, not int.
10375 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10377 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10379 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10380 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10381 All callers changed.
10383 * lisp.h (multibyte_char_to_unibyte):
10384 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10385 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10386 * character.h (CHAR_TO_BYTE8):
10387 * cmds.c (internal_self_insert):
10388 * editfns.c (general_insert_function):
10389 * keymap.c (push_key_description):
10390 * search.c (Freplace_match):
10391 * xdisp.c (message_dolog, set_message_1): All callers changed.
10393 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10395 * keyboard.c (safe_run_hook_funcall): New function.
10396 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10397 don't set the hook to nil, but remove the offending function instead.
10398 (Qcommand_hook_internal): Remove, unused.
10399 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10400 Vcommand_hook_internal.
10402 * eval.c (enum run_hooks_condition): Remove.
10403 (funcall_nil, funcall_not): New functions.
10404 (run_hook_with_args): Call each function through a `funcall' argument.
10405 Remove `cond' argument, now redundant.
10406 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10407 (Frun_hook_with_args_until_failure): Adjust accordingly.
10408 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10410 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10412 * dispextern.h (string_buffer_position): Remove declaration.
10414 * print.c (strout): Remove parameter `multibyte', unused since
10415 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10417 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10418 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10419 All callers changed.
10421 * w32.c (_wsa_errlist): Use braces for struct initializers.
10423 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10424 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10425 All callers changed.
10426 (string_buffer_position): Likewise. Also, make static (it's never
10427 used outside xdisp.c).
10428 (cursor_row_p): Remove parameter `w', unused since
10429 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10430 (decode_mode_spec): Remove parameter `precision', introduced during
10431 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10432 All callers changed.
10434 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10436 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10438 2011-03-27 Anders Lindgren <andlind@gmail.com>
10440 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10441 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10442 (ns_update_auto_hide_menu_bar): New functions.
10443 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10444 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10445 ns_constrain_all_frames.
10446 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10447 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10449 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10451 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10453 2011-03-27 Glenn Morris <rgm@gnu.org>
10455 * syssignal.h: Replace RETSIGTYPE with void.
10456 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10457 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10458 Replace SIGTYPE with void everywhere.
10459 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10460 * s/template.h (SIGTYPE): Remove commented out definition.
10462 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10464 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10465 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10467 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10469 * w32.c (read_unc_volume): Use parameter `henum', instead of
10470 global variable `wget_enum_handle'.
10472 * keymap.c (describe_vector): Remove parameters `indices' and
10473 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10474 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10476 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10478 * keyboard.c (timer_check): Remove parameter `do_it_now',
10479 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10480 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10481 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10483 * keyboard.c (read_char):
10484 * w32menu.c (w32_menu_display_help):
10485 * xmenu.c (show_help_event, menu_help_callback):
10486 Adjust calls to `show_help_echo'.
10488 * gtkutil.c (xg_maybe_add_timer):
10489 * keyboard.c (readable_events):
10490 * process.c (wait_reading_process_output):
10491 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10493 * insdel.c (adjust_markers_gap_motion):
10494 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10495 (gap_left, gap_right): Don't call it.
10497 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10499 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10500 incurred during fontification.
10502 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10504 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10505 (DEFVAR_PER_BUFFER): Don't pass it.
10507 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10508 (scrolling_window): Don't pass it.
10510 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10512 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10514 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10516 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10517 of variables specific to SELinux and computation of `encoded_absname'.
10519 * image.c (XPutPixel): Remove unused variable `height'.
10521 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10523 * unexw32.c (get_section_info): Remove unused variable `section'.
10525 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10526 (system_process_attributes): Remove unused variable `sess'.
10527 (sys_read): Remove unused variable `err'.
10529 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10530 (w32_wnd_proc): Remove unused variable `isdead'.
10531 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10532 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10533 (x_create_tip_frame): Remove unused variable `tem'.
10535 * w32inevt.c (w32_console_read_socket):
10536 Remove unused variable `no_events'.
10538 * w32term.c (x_draw_composite_glyph_string_foreground):
10539 Remove unused variable `width'.
10541 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10543 * w32term.c (x_set_glyph_string_clipping):
10544 Don't pass uninitialized region to CombineRgn.
10546 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10548 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10549 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10550 (Fx_close_connection): Remove unused variable `i'.
10552 * w32font.c (w32font_draw): Return number of glyphs.
10553 (w32font_open_internal): Remove unused variable `i'.
10554 (w32font_driver): Add missing initializer.
10556 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10557 (fill_in_menu): Remove unused variable `items_added'.
10559 * w32term.c (last_mouse_press_frame): Remove static global variable.
10560 (w32_clip_to_row): Remove unused variable `f'.
10561 (x_delete_terminal): Remove unused variable `i'.
10563 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10564 (NOTHING): Remove unused static global variable.
10565 (uniscribe_check_otf): Remove unused variable `table'.
10566 (uniscribe_font_driver): Add missing initializers.
10568 2011-03-23 Julien Danjou <julien@danjou.info>
10570 * term.c (Fsuspend_tty, Fresume_tty):
10571 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10572 * window.c (temp_output_buffer_show):
10573 * insdel.c (signal_before_change):
10574 * frame.c (Fhandle_switch_frame):
10575 * fileio.c (Fdo_auto_save):
10576 * emacs.c (Fkill_emacs):
10577 * editfns.c (save_excursion_restore):
10578 * cmds.c (internal_self_insert):
10579 * callint.c (Fcall_interactively):
10580 * buffer.c (Fkill_all_local_variables):
10581 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10583 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10584 unconditionally since it does the check itself.
10586 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10588 Fix more problems found by GCC 4.5.2's static checks.
10590 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10591 the first time through the loop, since we know p0 < p1 then.
10592 This also avoids a gcc -Wstrict-overflow warning.
10594 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10595 leading to a memory leak, possible in functions like
10596 load_charset_map_from_file that can allocate an unbounded number
10597 of objects (Bug#8318).
10599 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10600 that could (at least in theory) be that large.
10602 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10603 This is less likely to overflow, and avoids undefined behavior if
10604 overflow does occur. All callers changed. Use strtoul to scan
10605 for the unsigned long integer.
10606 (pint2hrstr): Simplify and tune code slightly.
10607 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10609 * scroll.c (do_scrolling): Work around GCC bug 48228.
10610 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10612 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10613 This also avoids a warning with gcc -Wstrict-overflow.
10614 (validate_x_resource_name): Simplify count usage.
10615 This also avoids a warning with gcc -Wstrict-overflow.
10617 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10620 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10622 * process.c (Fmake_network_process): Use socklen_t, not int,
10623 where POSIX says socklen_t is required in portable programs.
10624 This fixes a porting bug on hosts like 64-bit HP-UX, where
10625 socklen_t is wider than int (Bug#8277).
10626 (Fmake_network_process, server_accept_connection):
10627 (wait_reading_process_output, read_process_output):
10630 * process.c: Rename or move locals to avoid shadowing.
10631 (list_processes_1, Fmake_network_process):
10632 (read_process_output_error_handler, exec_sentinel_error_handler):
10633 Rename or move locals.
10634 (Fmake_network_process): Define label "retry_connect" only if needed.
10635 (Fnetwork_interface_info): Fix pointer signedness.
10636 (process_send_signal): Add cast to avoid pointer signedness problem.
10637 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10638 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10640 Make tparam.h and terminfo.c consistent.
10641 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10642 Include tparam.h instead, since it declares them.
10643 * cm.h (PC): Remove extern decl; tparam.h now does this.
10644 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10645 * terminfo.c: Include tparam.h, to check interfaces.
10646 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10647 (tparam): Adjust signature to match interface in tparam.h;
10648 this removes some undefined behavior. Check that outstring and len
10649 are zero, which they always are with Emacs.
10650 * tparam.h (PC, BC, UP): New extern decls.
10652 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10653 (xftfont_open): Rename locals to avoid shadowing.
10655 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10656 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10657 (OTF_TAG_SYM): Omit macro if not needed.
10658 (ftfont_list): Remove unused local.
10659 (get_adstyle_property, ftfont_pattern_entity):
10660 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10661 Rename locals to avoid shadowing.
10663 * xfont.c (xfont_list_family): Mark var as initialized.
10665 * xml.c (make_dom): Now static.
10667 * composite.c (composition_compute_stop_pos): Rename local to
10669 (composition_reseat_it): Remove unused locals.
10670 (find_automatic_composition, composition_adjust_point): Likewise.
10671 (composition_update_it): Mark var as initialized.
10672 (find_automatic_composition): Mark vars as initialized,
10673 with a FIXME (Bug#8290).
10675 character.h: Rename locals to avoid shadowing.
10676 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10677 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10678 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10679 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10680 to avoid shadowing.
10682 * textprop.c (property_change_between_p): Remove; unused.
10684 * intervals.c (interval_start_pos): Now static.
10686 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10688 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10689 Rename locals to avoid shadowing.
10691 * sound.c (wav_play, au_play, Fplay_sound_internal):
10692 Fix pointer signedness.
10693 (alsa_choose_format): Remove unused local var.
10694 (wav_play): Initialize a variable to 0, to prevent undefined
10695 behavior (Bug#8278).
10697 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10699 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10701 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10702 clobbering (Bug#8298).
10703 * sysdep.c (sys_subshell): Likewise.
10704 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10706 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10707 This should get cleaned up, so that child_setup has the
10708 same signature on all platforms.
10710 * callproc.c (call_process_cleanup): Now static.
10711 (relocate_fd): Rename locals to avoid shadowing.
10713 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10715 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10716 not to be necessary, and produces flickering.
10718 2011-03-20 Glenn Morris <rgm@gnu.org>
10720 * config.in: Remove file.
10722 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10724 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10725 are now in src/globals.h.
10726 (syms_of_minibuf): Remove spurious & from previous change.
10728 2011-03-20 Leo Liu <sdl.web@gmail.com>
10730 * minibuf.c (completing-read-function): New variable.
10731 (completing-read-default): Rename from completing-read.
10732 (completing-read): Call completing-read-function.
10734 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10736 * xfaces.c (Fx_load_color_file):
10737 Read color file from absolute filename (bug#8250).
10739 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10741 * makefile.w32-in: Update dependencies.
10743 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10745 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10747 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10749 Fix more problems found by GCC 4.5.2's static checks.
10751 * process.c (make_serial_process_unwind, send_process_trap):
10752 (sigchld_handler): Now static.
10754 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10755 That way, the code declares only the vars that it needs.
10756 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10757 * s/cygwin.h (PTY_ITERATION): Likewise.
10758 * s/darwin.h (PTY_ITERATION): Likewise.
10759 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10761 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10762 * process.c (allocate_pty): Don't declare stb unless it's needed.
10764 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10765 (CONSTANTLIM): Remove; unused.
10766 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10767 Define only if needed.
10769 * unexelf.c (unexec): Name an expression,
10770 to avoid gcc -Wbad-function-cast warning.
10771 Use a different way to cause a compilation error if anyone uses
10772 n rather than nn, a way that does not involve shadowing.
10773 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10775 * deps.mk (unexalpha.o): Remove; unused.
10777 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10778 * unexec.h: New file.
10779 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10780 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10781 Depend on unexec.h.
10782 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10783 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10784 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10785 Change as necessary to match prototype in unexec.h.
10787 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10789 (back_comment, skip_chars): Mark vars as initialized.
10791 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10792 Rename locals to avoid shadowing.
10794 * lread.c (read1): Rewrite so as not to use empty "else".
10795 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10797 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10799 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10800 warning when compiling print.c.
10802 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10803 instead of using an uninitialized var.
10804 (font_sort_entities): Mark var as initialized.
10806 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10808 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10809 pointers to constants.
10810 (font_parse_fcname): Remove unused vars.
10811 (font_delete_unmatched): Now static.
10812 (font_get_spec): Remove; unused.
10813 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10814 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10815 Rename or move locals to avoid shadowing.
10817 * fns.c (require_nesting_list, require_unwind): Now static.
10818 (Ffillarray): Rename locals to avoid shadowing.
10820 * floatfns.c (domain_error2): Define only if needed.
10821 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10823 * alloc.c (mark_backtrace): Move decl from here ...
10824 * lisp.h: ... to here, so that it can be checked.
10826 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10827 (Fdefvar): Rewrite so as not to use empty "else".
10828 (lisp_indirect_variable): Name an expression,
10829 to avoid gcc -Wbad-function-cast warning.
10830 (Fdefvar): Rename locals to avoid shadowing.
10832 * callint.c (quotify_arg, quotify_args): Now static.
10833 (Fcall_interactively): Rename locals to avoid shadowing.
10834 Use const pointer when appropriate.
10836 * lisp.h (get_system_name, get_operating_system_release):
10837 Move decls here, to check interfaces.
10838 * process.c (get_operating_system_release): Move decl to lisp.h.
10839 * xrdb.c (get_system_name): Likewise.
10840 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10841 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10842 some of which prompt warnings from gcc -Wbad-function-cast.
10843 (Fformat_time_string, Fencode_time, Finsert_char):
10844 (Ftranslate_region_internal, Fformat):
10845 Rename or remove local vars to avoid shadowing.
10846 (Ftranslate_region_internal): Mark var as initialized.
10848 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10851 * lisp.h (eassert): Check that the argument compiles, even if
10852 ENABLE_CHECKING is not defined.
10854 * data.c (Findirect_variable): Name an expression, to avoid
10855 gcc -Wbad-function-cast warning.
10856 (default_value, arithcompare, arith_driver, arith_error): Now static.
10857 (store_symval_forwarding): Rename local to avoid shadowing.
10858 (Fmake_variable_buffer_local, Fmake_local_variable):
10859 Mark variables as initialized.
10860 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10862 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10863 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10864 Rename locals to avoid shadowing.
10865 (mark_stack): Move local variables into the #ifdef region where
10867 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10868 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10870 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10871 (GC_STRING_CHARS): Remove; not used.
10872 (Fmemory_limit): Cast sbrk's returned value to char *.
10874 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10875 avoids undefined behavior in theory.
10877 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10879 Use functions, not macros, for up- and down-casing (Bug#8254).
10880 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10881 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10882 to use the following functions instead of these macros.
10883 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10884 EMACS_INT, since callers assume the returned value fits in int.
10885 (upcase1): Likewise, for UPCASE_TABLE.
10886 (uppercasep, lowercasep, upcase): New static inline functions.
10887 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10888 the race-condition problem in the old DOWNCASE.
10890 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10891 Rename locals to avoid shadowing.
10892 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10893 (regex_compile, re_search_2, re_match_2_internal):
10894 Remove unused local vars.
10895 (FREE_VAR): Rewrite so as not to use empty "else",
10896 which gcc can warn about.
10897 (regex_compile, re_match_2_internal): Mark locals as initialized.
10898 (RETALLOC_IF): Define only if needed.
10899 (WORDCHAR_P): Likewise. This one is never needed, but is used
10900 only in a comment talking about a compiler bug, so put inside
10901 the #if 0 of that comment.
10902 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10903 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10906 * search.c (boyer_moore): Rename locals to avoid shadowing.
10907 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10908 (PREV_CHAR_BOUNDARY): Likewise.
10910 * search.c (simple_search): Remove unused var.
10912 * dired.c (compile_pattern): Move decl from here ...
10913 * lisp.h: ... to here, so that it can be checked.
10914 (struct re_registers): New forward decl.
10916 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10918 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10920 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10921 Rename locals to avoid shadowing.
10922 (Fvertical_motion): Mark locals as initialized.
10924 * casefiddle.c (casify_object, casify_region): Now static.
10925 (casify_region): Mark local as initialized.
10927 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10929 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10930 New macros, so that the caller can use some names other than
10931 gcpro1, gcpro2, etc.
10932 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10934 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10935 argument, for consistency with GCPRO2_VAR, etc: it is now the
10936 prefix of the variable, not the variable itself. All uses
10938 * dired.c (directory_files_internal, file_name_completion):
10939 Rename locals to avoid shadowing.
10941 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10942 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10943 dired.c's scmp function, had undefined behavior.
10944 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10945 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10946 * buffer.h: ... to here, because these macros use current_buffer,
10947 and the new implementation with inline functions needs to have
10948 current_buffer in scope now, rather than later when the macros
10950 (downcase, upcase1): New static inline functions.
10951 (DOWNCASE, UPCASE1): Reimplement using these functions.
10952 This avoids undefined behavior in expressions like
10953 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10954 from race conditions in accessing the global variables
10955 case_temp1 and case_temp2.
10956 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10957 * lisp.h (case_temp1, case_temp2): Remove their decls.
10958 * character.h (ASCII_CHAR_P): Move from here ...
10959 * lisp.h: ... to here, so that the inline functions mentioned
10960 above can use them.
10962 * dired.c (directory_files_internal_unwind): Now static.
10964 * fileio.c (file_name_as_directory, directory_file_name):
10965 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10967 (file_name_as_directory): Use const pointers when appropriate.
10968 (Fexpand_file_name): Likewise. In particular, newdir might
10969 point at constant storage, so make it a const pointer.
10970 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10971 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10973 (Fset_file_times, Finsert_file_contents, auto_save_error):
10974 Rename locals to avoid shadowing.
10976 * minibuf.c (choose_minibuf_frame_1): Now static.
10977 (Ftry_completion, Fall_completions): Rename or remove locals
10978 to avoid shadowing.
10980 * marker.c (bytepos_to_charpos): Remove; unused.
10982 * lisp.h (verify_bytepos, count_markers): New decls,
10983 so that gcc does not warn that these functions aren't declared.
10985 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10986 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10987 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10988 (copy_text): Remove unused local var.
10990 * filelock.c (within_one_second): Now static.
10991 (lock_file_1): Rename local to avoid shadowing.
10993 * buffer.c (fix_overlays_before): Mark locals as initialized.
10994 (fix_start_end_in_overlays): Likewise. This function should be
10995 simplified by using pointers-to-pointers, but that's a different
10997 (switch_to_buffer_1): Now static.
10998 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10999 (report_overlay_modification): Rename locals to avoid shadowing.
11001 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11002 Fix pointer signedness issue.
11003 (sys_subshell): Mark local as volatile if checking for lint,
11004 to suppress a gcc -Wclobbered warning that does not seem to be right.
11005 (MAXPATHLEN): Define only if needed.
11007 * process.c (serial_open, serial_configure): Move decls from here ...
11008 * systty.h: ... to here, so that they can be checked.
11010 * fns.c (get_random, seed_random): Move extern decls from here ...
11011 * lisp.h: ... to here, so that they can be checked.
11013 * sysdep.c (reset_io): Now static.
11014 (wait_for_termination_signal): Remove; unused.
11016 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11017 (copy_keymap_item, append_key, push_text_char_description):
11019 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11020 (DENSE_TABLE_SIZE): Remove; unused.
11021 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11022 (describe_map_tree):
11023 Rename locals to avoid shadowing.
11025 * keyboard.c: Declare functions static if they are not used elsewhere.
11026 (echo_char, echo_dash, cmd_error, top_level_2):
11027 (poll_for_input, handle_async_input): Now static.
11028 (read_char, kbd_buffer_get_event, make_lispy_position):
11029 (make_lispy_event, make_lispy_movement, apply_modifiers):
11030 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11031 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11032 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11033 (read_key_sequence, read_char): Mark locals as initialized.
11034 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11036 * keyboard.h (make_ctrl_char): New decl.
11037 (mark_kboards): Move decl here ...
11038 * alloc.c (mark_kboards): ... from here.
11040 * lisp.h (force_auto_save_soon): New decl.
11042 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11043 (DEFINE_DUMMY_FUNCTION): New macro.
11044 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11046 (main): Add casts to avoid warnings
11047 if GCC considers string literals to be constants.
11049 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11051 * dbusbind.c: Pointer signedness fixes.
11052 (xd_signature, xd_append_arg, xd_initialize):
11053 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11054 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11055 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11056 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11058 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11059 if GCC considers string literals to be constants.
11060 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11062 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11064 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11065 (print_preprocess, print_object): New macro to fix last change.
11067 * print.c (print_preprocess): Don't forget font objects.
11069 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11071 * emacs.c (USAGE3): Doc fixes.
11073 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11075 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11078 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11080 * lisp.h (VWindow_system, Qfile_name_history):
11081 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11082 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11083 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11085 * w32select.c: Don't #include "keyboard.h".
11086 (run_protected): Add extern declaration for waiting_for_input.
11088 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11089 * w32console.c (detect_input_pending, read_input_pending)
11090 (encode_terminal_code):
11091 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11092 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11093 (w32_system_caret_y, Qfile_name_history):
11094 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11095 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11096 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11097 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11098 * w32proc.c (Qlocal, report_file_error):
11099 * w32term.c (Vwindow_system, updating_frame):
11100 * w32uniscribe.c (initialized, uniscribe_font_driver):
11101 Remove unneeded extern declarations.
11103 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11105 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11107 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11109 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11110 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11111 These macros can no longer be used for assignment.
11113 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11114 Assign struct members directly, instead of using BUF_BEGV etc.
11115 (record_buffer_markers, fetch_buffer_markers): New functions for
11116 recording and fetching special buffer markers.
11117 (set_buffer_internal_1, set_buffer_temp): Use them.
11119 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11121 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11123 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11124 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11126 * xdisp.c (hscroll_window_tree):
11127 (reconsider_clip_changes): Use PT instead of BUF_PT.
11129 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11131 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11132 $(EMACS_ROOT)/lib/intprops.h.
11134 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11136 Fix more problems found by GCC 4.5.2's static checks.
11138 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11139 to unsigned char * to avoid compiler diagnostic.
11140 (xg_free_frame_widgets): Make it clear that a local variable is
11141 needed only if USE_GTK_TOOLTIP.
11142 (gdk_window_get_screen): Make it clear that this macro is needed
11143 only if USE_GTK_TOOLTIP.
11144 (int_gtk_range_get_value): New function, which avoids a diagnostic
11145 from gcc -Wbad-function-cast.
11146 (xg_set_toolkit_scroll_bar_thumb): Use it.
11147 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11148 diagnostic from gcc -Wbad-function-cast.
11149 (get_utf8_string, xg_get_file_with_chooser):
11150 Rename locals to avoid shadowing.
11151 (create_dialog): Move locals to avoid shadowing.
11153 * xgselect.c (xg_select): Remove unused var.
11155 * image.c (four_corners_best): Mark locals as initialized.
11156 (gif_load): Initialize transparent_p to zero (Bug#8238).
11157 Mark another local as initialized.
11158 (my_png_error, my_error_exit): Mark with NO_RETURN.
11160 * image.c (clear_image_cache): Now static.
11161 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11162 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11163 (x_edge_detection): Remove unnecessary cast that
11164 gcc -Wbad-function-cast diagnoses.
11165 (gif_load): Fix pointer signedness.
11166 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11167 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11169 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11171 Improve quality of tests for time stamp overflow.
11172 For example, without this patch (encode-time 0 0 0 1 1
11173 1152921504606846976) returns the obviously-bogus value (-948597
11174 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11175 reports time overflow. See
11176 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11177 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11178 * editfns.c: Include limits.h and intprops.h.
11179 (TIME_T_MIN, TIME_T_MAX): New macros.
11180 (time_overflow): Move earlier, to before first use.
11181 (hi_time, lo_time): New functions, for an accurate test for
11182 out-of-range times.
11183 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11184 (Fget_internal_run_time): Don't assume time_t fits in int.
11185 (make_time): Use list2 instead of Fcons twice.
11186 (Fdecode_time): More accurate test for out-of-range times.
11187 (check_tm_member): New function.
11188 (Fencode_time): Use it, to test for out-of-range times.
11189 (lisp_time_argument): Don't rely on undefined left-shift and
11190 right-shift behavior when checking for time stamp overflow.
11192 * editfns.c (time_overflow): New function, refactoring common code.
11193 (Fformat_time_string, Fdecode_time, Fencode_time):
11194 (Fcurrent_time_string): Use it.
11196 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11197 * dired.c (make_time): Move to ...
11198 * editfns.c (make_time): ... here.
11199 * systime.h: Note the move.
11201 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11203 * fringe.c (update_window_fringes): Remove unused variables.
11205 * unexmacosx.c (copy_data_segment): Also copy __got section.
11208 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11210 * termcap.c [MSDOS]: Include "msdos.h".
11211 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11212 Constify `char *' arguments and their references according to
11213 prototypes in tparam.h.
11215 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11217 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11218 Adapt all references accordingly.
11220 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11222 2011-03-11 Tom Tromey <tromey@redhat.com>
11224 * buffer.c (syms_of_buffer): Remove obsolete comment.
11226 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11228 * termhooks.h (encode_terminal_code): Declare prototype.
11230 * msdos.c (encode_terminal_code): Don't declare prototype.
11232 * term.c (encode_terminal_code): Now external again, used by
11233 w32console.c and msdos.c.
11235 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11236 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11238 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11240 Fix some minor problems found by GCC 4.5.2's static checks.
11242 * fringe.c (update_window_fringes): Mark locals as initialized
11244 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11246 * alloc.c (mark_fringe_data): Move decl from here ...
11247 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11248 to check its interface.
11249 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11251 * fontset.c (free_realized_fontset): Now static.
11252 (Fset_fontset_font): Rename local to avoid shadowing.
11253 (fontset_font): Mark local as initialized.
11254 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11256 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11258 * xselect.c (x_disown_buffer_selections): Remove; not used.
11259 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11260 (x_own_selection, Fx_disown_selection_internal): Rename locals
11261 to avoid shadowing.
11262 (x_handle_dnd_message): Remove local to avoid shadowing.
11264 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11265 so that the caller can use some name other than gcpro1.
11266 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11267 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11268 (Fx_backspace_delete_keys_p):
11269 Use them to avoid shadowing, and rename vars to avoid shadowing.
11270 (x_decode_color, x_set_name, x_window): Now static.
11271 (Fx_create_frame): Add braces to silence GCC warning.
11272 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11273 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11274 Remove unused locals.
11275 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11276 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11277 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11280 * xterm.h (x_mouse_leave): New decl.
11282 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11283 Remove unused functions.
11284 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11285 (x_calc_absolute_position): Now static.
11286 (XTread_socket): Don't define label "out" unless it's used.
11287 Don't declare local "event" unless it's used.
11288 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11289 unless they are used.
11290 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11291 (x_fatal_error_signal): Remove; not used.
11292 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11293 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11294 (x_error_catcher, x_connection_closed, x_error_handler):
11295 (x_error_quitter, xembed_send_message, x_iconify_frame):
11296 (my_log_handler): Rename locals to avoid shadowing.
11297 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11298 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11300 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11301 Rename or move locals to avoid shadowing.
11302 (tty_defined_color, merge_face_heights): Now static.
11303 (free_realized_faces_for_fontset): Remove; not used.
11304 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11305 does not deduce is never used uninitialized.
11306 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11307 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11309 * terminal.c (store_terminal_param): Now static.
11311 * xmenu.c (menu_highlight_callback): Now static.
11312 (set_frame_menubar): Remove unused local.
11313 (xmenu_show): Rename parameter to avoid shadowing.
11314 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11315 since they might point to immutable storage.
11316 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11317 since it's unused otherwise.
11319 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11320 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11321 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11322 avoids a gcc -Wuninitialized diagnostic.
11323 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11324 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11325 does not deduce are never used uninitialized.
11327 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11329 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11330 * window.c (window_loop, size_window):
11331 (run_window_configuration_change_hook, enlarge_window): Likewise.
11333 * window.c (display_buffer): Now static.
11334 (size_window): Mark variables that gcc -Wuninitialized
11335 does not deduce are never used uninitialized.
11336 * window.h (check_all_windows): New decl, to forestall
11337 gcc -Wmissing-prototypes diagnostic.
11338 * dispextern.h (bidi_dump_cached_states): Likewise.
11340 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11342 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11343 Include <limits.h>.
11344 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11345 and to avoid gcc -Wuninitialized warning.
11346 (load_charset_map): Mark variables that gcc -Wuninitialized
11347 does not deduce are never used uninitialized.
11348 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11350 * coding.c (coding_set_source, coding_set_destination):
11351 Use "else { /* comment */ }" rather than "else /* comment */;"
11352 for clarity, and to avoid gcc -Wempty-body warning.
11353 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11354 a block, when the outer 'i' will do.
11355 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11356 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11357 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11358 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11359 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11360 Rename locals to avoid shadowing.
11361 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11362 * coding.c (emacs_mule_char, encode_invocation_designation):
11363 Now static, since they're not used elsewhere.
11364 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11365 (decode_coding_object, encode_coding_object, detect_coding_system):
11366 (decode_coding_emacs_mule): Mark variables that gcc
11367 -Wuninitialized does not deduce are never used uninitialized.
11368 (detect_coding_iso_2022): Initialize a local variable that might
11369 be used uninitialized. Leave a FIXME because it's not clear that
11370 this initialization is needed. (Bug#8211)
11371 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11372 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11373 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11374 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11375 Remove unused macros.
11377 * category.c (hash_get_category_set): Remove unused local var.
11378 (copy_category_table): Now static, since it's not used elsewhere.
11379 * character.c (string_count_byte8): Likewise.
11381 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11382 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11384 * chartab.c (copy_sub_char_table): Now static, since it's not used
11386 (sub_char_table_ref_and_range, char_table_ref_and_range):
11387 Rename locals to avoid shadowing.
11388 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11390 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11391 (BIDI_BOB): Remove unused macro.
11393 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11394 deduce are never used uninitialized.
11395 * term.c (encode_terminal_code): Likewise.
11397 * term.c (encode_terminal_code): Now static. Remove unused local.
11399 * tparam.h: New file.
11400 * term.c, tparam.h: Include it.
11401 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11402 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11403 Move these decls to tparam.h, and make them agree with what
11404 is actually in tparam.c. The previous trick of using incompatible
11405 decls in different modules does not conform to the C standard.
11406 All callers of tparam changed to use tparam's actual API.
11407 * tparam.c (tparam1, tparam, tgoto):
11408 Use const pointers where appropriate.
11410 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11411 * cm.h (struct cm): Likewise.
11412 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11413 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11414 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11415 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11416 (turn_on_face, init_tty): Likewise.
11417 * termchar.h (struct tty_display_info): Likewise.
11419 * term.c (term_mouse_position): Rename local to avoid shadowing.
11421 * alloc.c (mark_ttys): Move decl from here ...
11422 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11424 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11426 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11428 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11430 * search.c (compile_pattern_1): Remove argument regp, unused since
11431 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11432 (compile_pattern): Don't pass it.
11434 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11436 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11437 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11439 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11441 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11443 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11444 gdk_window_get_screen, gdk_window_get_geometry,
11445 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11446 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11447 (xg_get_pixbuf_from_pixmap): New function.
11448 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11449 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11450 Call xg_get_pixbuf_from_pixmap instead of
11451 gdk_pixbuf_get_from_drawable.
11452 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11453 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11454 (xg_check_special_colors): Use GtkStyleContext and its functions
11456 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11457 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11458 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11459 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11460 Call gtk_widget_get_preferred_size.
11461 (xg_frame_resized): gdk_window_get_geometry only takes 5
11463 (xg_win_to_widget, xg_event_is_for_menubar):
11464 Call gdk_x11_window_lookup_for_display.
11465 (xg_set_widget_bg): New function.
11466 (delete_cb): New function.
11467 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11468 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11469 (xg_set_background_color): Call xg_set_widget_bg.
11470 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11471 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11472 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11473 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11475 (update_frame_tool_bar): Call gtk_widget_hide.
11476 (xg_initialize): Use GDK_KEY_g.
11478 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11480 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11482 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11483 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11484 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11486 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11488 * w32xfns.c (select_palette): Check success of RealizePalette against
11489 GDI_ERROR, not zero.
11491 See ChangeLog.11 for earlier changes.
11493 ;; Local Variables:
11497 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11499 This file is part of GNU Emacs.
11501 GNU Emacs is free software: you can redistribute it and/or modify
11502 it under the terms of the GNU General Public License as published by
11503 the Free Software Foundation, either version 3 of the License, or
11504 (at your option) any later version.
11506 GNU Emacs is distributed in the hope that it will be useful,
11507 but WITHOUT ANY WARRANTY; without even the implied warranty of
11508 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11509 GNU General Public License for more details.
11511 You should have received a copy of the GNU General Public License
11512 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.