1 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
5 (Fautoload): Do the hash-doc more carefully.
6 * data.c (Fdefalias): Purify definition, except for keymaps.
7 (Qdefun): Move from eval.c.
8 * lisp.h (Qdefun): Remove.
9 * lread.c (read1): Tiny simplification.
11 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
13 Do not create empty overlays with the evaporate property (Bug#9642).
14 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
15 Bug#9642, but explicitly check that the buffer the overlay would
16 be moved to is live and rearrange lines to make sure that errors
17 will not put the overlay in an inconsistent state.
18 (Fdelete_overlay): Cosmetics.
20 2012-05-28 Eli Zaretskii <eliz@gnu.org>
22 * w32term.c (my_bring_window_to_top): New function.
23 (x_raise_frame): Use handle returned by DeferWindowPos, which
24 could be different from the original one.
25 Call my_bring_window_to_top instead of my_set_foreground_window.
28 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
29 by calling BringWindowToTop.
31 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
32 (WM_EMACS_END): Increase by one.
34 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
36 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
37 This avoids undefined behavior that might cause the eassert
38 to not catch an out-of-range value.
40 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
42 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
45 2012-05-27 Eli Zaretskii <eliz@gnu.org>
47 * bidi.c (bidi_mirror_char): Fix last change.
49 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
51 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
52 when referring to sectname field in printf format.
54 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
56 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
57 Only r_alloc_inhibit_buffer_relocation needed to be added;
58 the others were already declared.
60 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
61 before checking whether it's out of range. Put the check inside
63 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
65 2012-05-27 Ken Brown <kbrown@cornell.edu>
67 * callproc.c (Fcall_process): Restore a line that was accidentally
68 commented out in the 2011-02-13 change (bug#11547).
70 2012-05-27 Eli Zaretskii <eliz@gnu.org>
72 * lisp.h [REL_ALLOC]: Add prototypes for external functions
75 * buffer.c [REL_ALLOC]: Remove prototypes of
76 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
77 they are now on lisp.h.
79 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
81 * search.c (search_buffer): Use it to inhibit relocation of buffer
82 text while re_search_2 is doing its job, because re_search_2 is
83 passed C pointers to buffer text. (Bug#11519)
85 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
88 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
89 state after an additional call to move_it_in_display_line_to, keep
90 the values of it->max_ascent and it->max_descent found for the
92 (pos_visible_p): Revert the comparison against bottom_y to what it
93 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
96 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
98 Fix coding-related core dumps with gcc -ftrapv.
99 The code was computing A - B, where A and B are pointers, and B is
100 random garbage. This can lead to core dumps on platforms that
101 have special pointer registers, and it also leads to core dumps on
102 x86-64 when compiled with gcc -ftrapv. The fix is to compute
103 A - B only when B is initialized properly.
104 * coding.c (coding_set_source, coding_set_destination): Return void.
105 (coding_change_source, coding_change_destinations): New functions,
106 with the old behaviors of coding_set_source and coding_set_destination.
107 All callers that need an offset changed to use these new functions.
109 2012-05-26 Glenn Morris <rgm@gnu.org>
111 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
113 2012-05-26 Eli Zaretskii <eliz@gnu.org>
115 Extend mouse support on W32 text-mode console.
116 * xdisp.c (draw_row_with_mouse_face):
117 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
119 * w32console.c: Include window.h.
120 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
122 (initialize_w32_display): Initialize mouse-highlight data.
124 * w32inevt.c: Include termchar.h and window.h.
125 (do_mouse_event): Support mouse-autoselect-window. When the mouse
126 moves, call note_mouse_highlight. If help_echo changed, call
127 gen_help_event to produce help-echo message in the echo area.
128 Call clear_mouse_face if mouse_face_hidden is set in the mouse
131 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
133 * lread.c (read1): Simplify slightly to avoid an overflow warning
134 with GCC 4.7.0 on x86-64.
136 2012-05-26 Eli Zaretskii <eliz@gnu.org>
138 * bidi.c (bidi_mirror_char): Revert last change: an int is
139 definitely wide enough here.
141 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
143 Fix integer width and related bugs (Bug#9874).
144 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
145 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
146 (string_bytes, check_sblock, allocate_string_data):
147 (compact_small_strings, Fmake_bool_vector, make_string)
148 (make_unibyte_string, make_multibyte_string)
149 (make_string_from_bytes, make_specified_string)
150 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
151 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
154 (allocate_pseudovector):
155 Use int, not EMACS_INT, where int is wide enough.
156 (inhibit_garbage_collection, Fgarbage_collect):
157 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
158 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
159 int might not be wide enough.
160 (bidi_cache_search, bidi_cache_find, bidi_init_it)
161 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
162 (bidi_at_paragraph_end, bidi_find_paragraph_start)
163 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
164 (bidi_level_of_next_char, bidi_move_to_visually_next):
165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
166 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
167 (Fkill_buffer, Fset_buffer_major_mode)
168 (advance_to_char_boundary, Fbuffer_swap_text)
169 (Fset_buffer_multibyte, overlays_at, overlays_in)
170 (overlay_touches_p, struct sortvec, record_overlay_string)
171 (overlay_strings, recenter_overlay_lists)
172 (adjust_overlays_for_insert, adjust_overlays_for_delete)
173 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
174 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
175 (Foverlay_recenter, last_overlay_modification_hooks_used)
176 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
178 (validate_region): Omit unnecessary test for b <= e,
179 since that's guaranteed by the previous test.
180 (adjust_overlays_for_delete): Avoid pos + length overflow.
181 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
182 (report_overlay_modification):
183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
184 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
185 Omit pointer cast, which isn't needed anyway, and doesn't work
186 after the EMACS_INT -> ptrdiff_t change.
187 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
188 * buffer.h: Adjust decls to match defn changes elsewhere.
189 (struct buffer_text, struct buffer):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 Use EMACS_INT, not int, where int might not be wide enough.
192 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
193 not int, to avoid needless 32-bit limit on 64-bit hosts.
194 (exec_byte_code): Use tighter memory-full test, one that checks
195 for alloca overflow. Don't compute the address of the object just
196 before an array, as that's not portable. Use EMACS_INT, not
197 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
198 * callint.c (Fcall_interactively):
199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
200 * callproc.c (call_process_kill, Fcall_process):
201 Don't assume pid_t fits into an Emacs fixnum.
202 (call_process_cleanup, Fcall_process, child_setup):
203 Don't assume pid_t fits into int.
204 (call_process_cleanup, Fcall_process, delete_temp_file)
205 (Fcall_process_region):
206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
207 (Fcall_process): Simplify handling of volatile integers.
208 Use int, not EMACS_INT, where int will do.
209 * casefiddle.c (casify_object, casify_region, operate_on_word)
210 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
212 (casify_object): Avoid integer overflow when overallocating buffer.
213 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
214 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
215 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
216 * category.h (CATEGORYP): Don't assume arg is nonnegative.
217 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
218 integers are now checked earlier. All uses replaced with XINT.
220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
221 For CCL_MapSingle, check that content and value are in int range.
222 (ccl_driver, Fregister_code_conversion_map):
223 Check that Vcode_version_map_vector is a vector.
224 (resolve_symbol_ccl_program): Check that vector header is in range.
225 Always copy the vector, so that we can check its contents reliably
226 now rather than having to recheck each instruction as it's being
227 executed. Check that vector words fit in 'int'.
228 (ccl_get_compiled_code, Fregister_ccl_program)
229 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
230 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
231 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
232 contents are in range.
233 (Fccl_execute_on_string): Check that status is in range.
234 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
235 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
236 Accept and return EMACS_INT, not int, because callers can pass values
238 (c_string_width, strwidth, lisp_string_width, chars_in_text)
239 (multibyte_chars_in_text, parse_str_as_multibyte)
240 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
241 (str_as_unibyte, str_to_unibyte, string_count_byte8)
242 (string_escape_byte8, Fget_byte):
243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
244 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
245 avoid mishandling large integers.
246 * character.h: Adjust decls to match defn changes elsewhere.
247 * charset.c (load_charset_map_from_file, find_charsets_in_text)
248 (Ffind_charset_region):
249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
250 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
251 (load_charset_map_from_vector, Fdefine_charset_internal):
252 Don't assume fixnum fits in int.
253 (load_charset_map_from_vector, Fmap_charset_chars):
254 Remove now-unnecessary CHECK_NATNUMs.
255 (Fdefine_charset_internal): Check ranges here, more carefully.
256 Don't rely on undefined behavior with signed left shift overflow.
257 Don't assume unsigned int fits into fixnum, or that fixnum fits
258 into unsigned int. Don't require max_code to be a valid fixnum;
259 that's not true for gb10830 4-byte on a 32-bit host. Allow
260 invalid_code to be a cons, for the same reason. Require code_offset
261 to be a character. Avoid int overflow if max_char is close
263 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
264 this is intended anyway and avoids some undefined behavior.
265 (load_charset_map): Pass unsigned, not int, as 2nd arg of
266 INDEX_TO_CODE_POINT, as that's what it expects.
267 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
268 * charset.h (DECODE_CHAR): Return int, not unsigned;
269 this is what was intended anyway, and it avoids undefined behavior.
270 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
271 integer-overflow issues.
272 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
273 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
274 where the argument is EMACS_INT, and this behavior is not intended.
275 * chartab.c (Fmake_char_table, Fset_char_table_range)
276 (uniprop_get_decoder, uniprop_get_encoder):
277 Don't assume fixnum fits in int.
278 * cmds.c (move_point): New function, that does the gist of
279 Fforward_char and Fbackward_char, but does so while checking
280 for integer overflow more accurately.
281 (Fforward_char, Fbackward_char): Use it.
282 (Fforward_line, Fend_of_line, internal_self_insert)
283 (internal_self_insert):
284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
285 Fix a FIXME, by checking for integer overflow when calculating
286 target_clm and actual_clm.
287 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
288 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
289 (ASSURE_DESTINATION, coding_alloc_by_realloc)
290 (coding_alloc_by_making_gap, alloc_destination)
291 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
292 (encode_coding_utf_16, detect_coding_emacs_mule)
293 (decode_coding_emacs_mule, encode_coding_emacs_mule)
294 (detect_coding_iso_2022, decode_coding_iso_2022)
295 (encode_invocation_designation, encode_designation_at_bol)
296 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
297 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
298 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
299 (encode_coding_ccl, encode_coding_raw_text)
300 (detect_coding_charset, decode_coding_charset)
301 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
302 (produce_composition, produce_charset, produce_annotation)
303 (decode_coding, handle_composition_annotation)
304 (handle_charset_annotation, consume_chars, decode_coding_gap)
305 (decode_coding_object, encode_coding_object, detect_coding_system)
306 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
307 (code_convert_region, code_convert_string)
308 (Fdefine_coding_system_internal)
309 (coding_set_source, coding_set_destination):
310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
311 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
312 (Fdefine_coding_system_internal):
313 Don't assume fixnums fit in int.
314 (decode_coding_gap, decode_coding_object, encode_coding_object)
315 (Fread_coding_system, Fdetect_coding_region)
316 (Funencodable_char_position, Fcheck_coding_systems_region)
317 (get_translation, handle_composition_annotation, consume_chars):
318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
319 (consume_chars): Rewrite to not calculate an address outside buffer.
320 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
321 Don't access memory outside of the args array.
322 (Fdefine_coding_system_internal): Check for charset-id overflow.
323 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
324 result of ENCODE_CHAR.
325 * coding.h: Adjust decls to match defn changes elsewhere.
326 (struct coding_system):
327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
328 * composite.c (get_composition_id, find_composition)
329 (run_composition_function, update_compositions)
330 (compose_text, composition_gstring_put_cache)
331 (composition_gstring_p, composition_gstring_width)
332 (fill_gstring_header, fill_gstring_body, autocmp_chars)
333 (composition_compute_stop_pos, composition_reseat_it)
334 (composition_update_it, struct position_record)
335 (find_automatic_composition, composition_adjust_point)
336 (Fcomposition_get_gstring, Ffind_composition_internal):
337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
338 (update_compositions):
339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
340 * composite.h: Adjust decls to match defn changes elsewhere.
341 (struct composition):
342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
343 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
344 Do not attempt to compute the address of the object just before a
345 buffer; this is not portable.
347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
348 (Faset): Use int, not EMACS_INT, where int is wide enough.
349 (Fstring_to_number): Don't assume fixnums fit in int.
350 (Frem): Don't assume arg is nonnegative.
351 * dbusbind.c (xd_append_arg): Check for integers out of range.
352 (Fdbus_call_method): Don't overflow the timeout int.
353 (extract_signed, extract_unsigned): New functions.
354 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
355 (xd_get_connection_references): Return ptrdiff_t, not int.
357 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
359 Use int, not unsigned, where the dbus API uses int.
360 (Fdbus_message_internal): Don't overflow mtype.
361 (syms_of_dbusbind): Allocate right-sized buffer for integers.
362 * dired.c (directory_files_internal, file_name_completion, scmp)
363 (file_name_completion_stat):
364 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
365 (file_name_completion): Don't overflow matchcount.
366 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
367 * dispextern.h: Adjust decls to match defn changes elsewhere.
368 (struct text_pos, struct glyph, struct bidi_saved_info)
369 (struct bidi_string_data, struct bidi_it, struct composition_it)
371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
372 (struct display_pos, struct composition_it, struct it):
373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
374 * dispnew.c (increment_matrix_positions)
375 (increment_row_positions, mode_line_string)
376 (marginal_area_string):
377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
378 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
379 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
380 (duration_to_sec_usec): New function, to check for overflow better.
381 (Fsleep_for, sit_for): Use it.
382 * doc.c (get_doc_string, store_function_docstring):
383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
384 (get_doc_string, Fsnarf_documentation):
385 Use int, not EMACS_INT, where int is wide enough.
387 Use SAFE_ALLOCA, not alloca.
388 Check for overflow when converting EMACS_INT to off_t.
390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
391 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
392 Don't assume uid_t fits into fixnum.
393 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
394 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
395 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
396 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
397 (general_insert_function)
398 (Finsert_char, make_buffer_string, make_buffer_string_both)
399 (update_buffer_properties, Fbuffer_substring)
400 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
401 (Fsubst_char_in_region, check_translation)
402 (Ftranslate_region_internal, save_restriction_restore, Fformat)
403 (transpose_markers, Ftranspose_regions):
404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
405 (clip_to_bounds): Move to lisp.h as an inline function).
406 (Fconstrain_to_field): Don't assume integers are nonnegative.
407 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
408 (Fsubst_char_in_region, Fsave_restriction):
409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
410 (Femacs_pid): Don't assume pid_t fits into fixnum.
411 (lo_time): Use int, not EMACS_INT, when int suffices.
412 (lisp_time_argument): Check for usec out of range.
413 (Fencode_time): Don't assume fixnum fits in int.
414 (Fuser_login_name, Fuser_full_name): Signal an error
415 if a uid argument is out of range, rather than relying on
417 (Fformat_time_string): Remove now-unnecessary check.
418 lisp_time_argument checks for out-of-range usec now.
419 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
420 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
421 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
422 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
423 (init_cmdargs, Fdump_emacs):
424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
425 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
426 the bottom (typically) 32 bits of the fixnum.
427 * eval.c (specpdl_size, call_debugger):
428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
429 (when_entered_debugger, Fbacktrace_debug):
430 Don't assume fixnum can fit in int.
431 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
432 the object just before a buffer; this is not portable.
433 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
434 (grow_specpdl, unbind_to):
435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
436 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
437 (grow_specpdl): Simplify allocation by using xpalloc.
438 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
439 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
440 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
442 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
445 (Fcopy_file, non_regular_nbytes, read_non_regular)
446 (Finsert_file_contents):
447 Use int, not EMACS_INT, where int is wide enough.
448 (READ_BUF_SIZE): Verify that it fits in int.
449 (Finsert_file_contents): Check that counts are in proper range,
450 rather than assuming fixnums fit into ptrdiff_t etc.
451 Don't assume fixnums fit into int.
452 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
453 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
454 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
455 (string_char_to_byte, string_byte_to_char)
456 (string_make_multibyte, string_to_multibyte)
457 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
458 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
459 (substring_both, Fdelete, internal_equal, Ffillarray)
460 (Fclear_string, mapcar1)
461 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
462 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
463 (larger_vector, make_hash_table, maybe_resize_hash_table)
464 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
465 (Fmaphash, secure_hash):
466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
467 (concat): Check for string index and length overflow.
468 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
471 (larger_vector): New API (vec, incr_min, size_max) replaces old
472 one (vec, new_size, init). This catches size overflow.
473 INIT was removed because it was always Qnil.
475 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
476 the upper bound on a hash table index size.
477 (make_hash_table, maybe_resize_hash_table): Use it.
478 (secure_hash): Computer start_byte and end_byte only after
479 they're known to be in ptrdiff_t range.
480 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
481 (Ffont_get_glyphs, Ffont_at):
482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
483 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
484 (Flist_fonts, Fopen_font):
485 Don't assume fixnum can fit in int.
486 (check_gstring): Don't assume index can fit in int.
487 (font_match_p): Check that fixnum is a character, not a nonnegative
488 fixnum, since the later code needs to stuff it into an int.
489 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
490 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
491 conversion overflow issues.
492 (Fopen_font): Check for integer out of range.
493 (Ffont_get_glyphs): Don't assume index can fit in int.
494 * font.h: Adjust decls to match defn changes elsewhere.
495 * fontset.c (reorder_font_vector): Redo score calculation to avoid
497 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
498 printmax_t, where ptrdiff_t is wide enough.
499 (Finternal_char_font):
500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
501 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
502 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
503 (Fset_frame_position, x_set_frame_parameters)
504 (x_set_line_spacing, x_set_border_width)
505 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
506 Check that fixnums are in proper range for system types.
507 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
509 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
510 Use SAFE_ALLOCA_LISP, not alloca.
511 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
512 intptr_t is wide enough.
513 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
514 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
515 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
516 Check for fixnum out of range.
517 * ftfont.c (ftfont_list): Don't assume index fits in int.
518 Check that fixnums are in proper range for system types.
519 (ftfont_shape_by_flt):
520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
521 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
523 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
524 Check that fixnums are in proper range for system types.
525 * gnutls.h: Adjust decls to match defn changes elsewhere.
526 * gtkutil.c (xg_dialog_run):
527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
528 (update_frame_tool_bar):
529 Check that fixnums are in proper range for system types.
530 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
531 (lookup_image): Check that fixnums are in range for system types.
532 * indent.c (last_known_column, last_known_column_point):
533 (current_column_bol_cache):
534 (skip_invisible, current_column, check_display_width):
535 (check_display_width, scan_for_column, current_column_1)
536 (Findent_to, Fcurrent_indentation, position_indentation)
537 (indented_beyond_p, Fmove_to_column, compute_motion):
538 (Fcompute_motion, Fvertical_motion):
539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
540 (last_known_column_modified): Use EMACS_INT, not int.
541 (check_display_width):
543 Check that fixnums and floats are in proper range for system types.
544 (compute_motion): Don't assume index or fixnum fits in int.
545 (compute_motion, Fcompute_motion):
546 Use int, not EMACS_INT, when it is wide enough.
547 (vmotion): Omit local var start_hpos that is always 0; that way
548 we don't need to worry about overflow in expressions involving it.
549 * indent.h: Adjust decls to match defn changes elsewhere.
551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
552 Use int, not EMACS_INT, where int is wide enough.
553 Remove unused members ovstring_chars_done and tab_offset;
555 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
556 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
557 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
558 (make_gap, copy_text, insert, insert_and_inherit)
559 (insert_before_markers, insert_before_markers_and_inherit)
560 (insert_1, count_combining_before, count_combining_after)
561 (insert_1_both, insert_from_string)
562 (insert_from_string_before_markers, insert_from_string_1)
563 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
564 (adjust_after_replace, adjust_after_insert, replace_range)
565 (replace_range_2, del_range, del_range_1, del_range_byte)
566 (del_range_both, del_range_2, modify_region)
567 (prepare_to_modify_buffer, signal_before_change)
568 (signal_after_change, Fcombine_after_change_execute):
569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
570 * intervals.c (traverse_intervals, rotate_right, rotate_left)
571 (balance_an_interval, split_interval_right, split_interval_left)
572 (find_interval, next_interval, update_interval)
573 (adjust_intervals_for_insertion, delete_node, delete_interval)
574 (interval_deletion_adjustment, adjust_intervals_for_deletion)
575 (static_offset_intervals, offset_intervals)
576 (merge_interval_right, merge_interval_left, make_new_interval)
577 (graft_intervals_into_buffer, temp_set_point_both)
578 (temp_set_point, set_point, adjust_for_invis_intang)
579 (set_point_both, move_if_not_intangible, get_property_and_range)
580 (get_local_map, copy_intervals, copy_intervals_to_string)
581 (compare_string_intervals, set_intervals_multibyte_1):
582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
583 * intervals.h: Adjust decls to match defn changes elsewhere.
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 * keyboard.c (this_command_key_count, this_single_command_key_start)
587 (before_command_key_count, before_command_echo_length, echo_now)
588 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
589 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
590 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
591 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
593 (last_non_minibuf_size, last_point_position, echo_truncate)
594 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
595 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
596 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
597 (stuff_buffered_input):
598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
599 (last_auto_save, command_loop_1, read_char):
600 Use EMACS_INT, not int, to avoid integer overflow.
601 (record_char): Avoid overflow in total_keys computation.
602 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
603 * keyboard.h: Adjust decls to match defn changes elsewhere.
604 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
605 (Fkey_description, Fdescribe_vector, Flookup_key):
606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
607 (click_position): New function, to check that positions are in range.
608 (Fcurrent_active_maps):
610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
611 (Faccessible_keymaps, Fkey_description):
612 (preferred_sequence_p):
613 Don't assume fixnum can fit into int.
614 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
615 Check for integer overflow in size calculations.
616 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
617 avoid mishandling large integers.
618 * lisp.h: Adjust decls to match defn changes elsewhere.
619 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
620 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
621 (struct Lisp_Marker):
622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
623 (clip_to_bounds): Now an inline function, moved here from editfns.c.
624 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
625 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
627 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
628 Assume the arg has valid form, since it always does.
629 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
630 unsigned integer system type.
631 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
632 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
634 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
635 (duration_to_sec_usec): New decl.
636 * lread.c (read_from_string_index, read_from_string_index_byte)
637 (read_from_string_limit, readchar, unreadchar, openp)
638 (read_internal_start, read1, oblookup):
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 (Fload, readevalloop, Feval_buffer, Feval_region):
641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
642 (openp): Check for out-of-range argument to 'access'.
643 (read1): Use int, not EMACS_INT, where int is wide enough.
644 Don't assume fixnum fits into int.
645 Fix off-by-one error that can read outside a buffer.
646 (read_filtered_event): Use duration_to_sec_usec
647 to do proper overflow checking on durations.
648 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
650 (Fexecute_kbd_macro):
651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
652 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
653 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
654 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
655 (set_marker_both, set_marker_restricted_both, marker_position)
656 (marker_byte_position, Fbuffer_has_markers_at):
657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
658 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
659 * menu.c (ensure_menu_items): Rename from grow_menu_items.
660 It now merely ensures that the menu is large enough, without
661 necessarily growing it, as this avoids some integer overflow issues.
663 (keymap_panes, parse_single_submenu, Fx_popup_menu):
664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
665 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
666 Use SAFE_ALLOCA_LISP, not alloca.
667 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
668 to EMACS_INT. Check that fixnums are in proper range for system types.
669 * minibuf.c (minibuf_prompt_width, string_to_object)
670 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
671 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
673 (get_minibuffer, read_minibuf_unwind):
674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
675 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
676 this simplifies overflow checking. All callers changed.
677 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
680 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
681 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
682 Check that fixnums are in proper range for system types.
683 (Fx_create_frame, Fx_show_tip):
684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
685 * nsfont.m (ns_findfonts, nsfont_list_family):
686 Don't assume fixnum fits in long.
687 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
689 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
691 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
693 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
694 (PRINTDECLARE, PRINTPREPARE):
695 (strout, print_string):
696 (print, print_preprocess, print_check_string_charset_prop)
698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
700 (temp_output_buffer_setup, Fprin1_to_string, print_object):
701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
702 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
703 (printchar, strout): Use xpalloc to catch size calculation overflow.
704 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
705 (print_error_message): Use SAFE_ALLOCA, not alloca.
706 (print_object): Use int, not EMACS_INT, where int is wide enough.
707 (print_depth, new_backquote_output, print_number_index):
708 Use ptrdiff_t, not int, where int might not be wide enough.
709 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
710 (Fset_process_window_size, Fformat_network_address)
711 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
713 Check that fixnums are in proper range for system types.
714 (Fsignal_process): Simplify by avoiding a goto.
715 Check for process-ids out of pid_t range rather than relying on
717 (process_tick, update_tick): Use EMACS_INT, not int.
718 (Fformat_network_address, read_process_output, send_process)
719 (Fprocess_send_region, status_notify):
720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
721 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
722 (wait_reading_process_output, read_process_output, exec_sentinel):
723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
724 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
725 (Faccept_process_output): Use duration_to_sec_usec to do proper
726 overflow checking on durations.
727 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
728 Don't assume pid_t fits in int.
729 * process.h (struct Lisp_Process): Members tick and update_tick
730 are now of type EMACS_INT, not int.
731 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
732 configured --with-wide-int.
733 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
734 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
735 * search.c (looking_at_1, string_match_1):
736 (fast_string_match, fast_c_string_match_ignore_case)
737 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
738 (scan_newline, find_before_next_newline, search_command)
739 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
740 (set_search_regs, wordify):
743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
744 (string_match_1, search_buffer, set_search_regs):
746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
747 (wordify): Check for overflow in size calculation.
748 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
749 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
750 Check that fixnums are in proper range for system types.
751 * sound.c (struct sound_device)
752 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 (Fplay_sound_internal):
755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
756 * syntax.c (struct lisp_parse_state, find_start_modiff)
757 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
758 (Fparse_partial_sexp):
759 Don't assume fixnums can fit in int.
760 (struct lisp_parse_state, find_start_pos, find_start_value)
761 (find_start_value_byte, find_start_begv)
762 (update_syntax_table, char_quoted, dec_bytepos)
763 (find_defun_start, prev_char_comend_first, back_comment):
764 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
765 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
767 (Finternal_describe_syntax_value): Check that match_lisp is a
768 character, not an integer, since the code stuffs it into int.
769 (scan_words, scan_sexps_forward):
770 Check that fixnums are in proper range for system types.
772 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
773 (scan_sexps_forward):
774 Use CHARACTERP, not INTEGERP, since the value must fit into int.
775 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
776 * syntax.h: Adjust decls to match defn changes elsewhere.
778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
779 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
780 MOST_POSITIVE_FIXNUM.
781 * sysdep.c (wait_for_termination_1, wait_for_termination)
782 (interruptible_wait_for_termination, mkdir):
783 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
784 (emacs_read, emacs_write):
785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
786 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
787 and double all fit in int.
788 * term.c (set_tty_color_mode):
789 Check that fixnums are in proper range for system types.
790 * termhooks.h (struct input_event):
791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
792 * textprop.c (validate_interval_range, interval_of)
793 (Fadd_text_properties, set_text_properties_1)
794 (Fremove_text_properties, Fremove_list_of_text_properties)
795 (Ftext_property_any, Ftext_property_not_all)
796 (copy_text_properties, text_property_list, extend_property_ranges)
797 (verify_interval_modification):
798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
799 (Fnext_single_char_property_change)
800 (Fprevious_single_char_property_change):
801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
802 (copy_text_properties):
803 Check for integer overflow in index calculation.
804 * undo.c (last_boundary_position, record_point, record_insert)
805 (record_delete, record_marker_adjustment, record_change)
806 (record_property_change):
807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
808 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
810 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
811 (Fx_hide_tip, Fx_file_dialog):
812 * w32menu.c (set_frame_menubar):
813 Use ptrdiff_t, not int, for consistency with rest of code.
814 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
815 (select_window, Fdelete_other_windows_internal)
816 (window_scroll_pixel_based, window_scroll_line_based)
817 (Frecenter, Fset_window_configuration):
818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
819 (Fset_window_hscroll, run_window_configuration_change_hook)
820 (set_window_buffer, temp_output_buffer_show, scroll_command)
821 (Fscroll_other_window, Frecenter):
822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
823 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
824 Don't assume fixnum fits in int.
825 (Fset_window_scroll_bars):
826 Check that fixnums are in proper range for system types.
827 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
828 (string_pos, c_string_pos, number_of_chars, init_iterator)
829 (in_ellipses_for_invisible_text_p, init_from_display_pos)
830 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
831 (compute_display_string_end, handle_face_prop)
832 (face_before_or_after_it_pos, handle_invisible_prop)
833 (handle_display_prop, handle_display_spec, handle_single_display_spec)
834 (display_prop_intangible_p, string_buffer_position_lim)
835 (string_buffer_position, handle_composition_prop, load_overlay_strings)
836 (get_overlay_strings_1, get_overlay_strings)
837 (iterate_out_of_display_property, forward_to_next_line_start)
838 (back_to_previous_visible_line_start, reseat, reseat_to_string)
839 (get_next_display_element, set_iterator_to_next)
840 (get_visually_first_element, compute_stop_pos_backwards)
841 (handle_stop_backwards, next_element_from_buffer)
842 (move_it_in_display_line_to, move_it_in_display_line)
843 (move_it_to, move_it_vertically_backward, move_it_by_lines)
844 (add_to_log, message_dolog, message_log_check_duplicate)
845 (message2, message2_nolog, message3, message3_nolog
846 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
847 (current_message_1, truncate_echo_area, truncate_message_1)
848 (set_message, set_message_1, store_mode_line_noprop)
849 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
850 (text_outside_line_unchanged_p, check_point_in_composition)
851 (reconsider_clip_changes)
852 (redisplay_internal, set_cursor_from_row, try_scrolling)
853 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
854 (redisplay_window, find_last_unchanged_at_beg_row)
855 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
856 (trailing_whitespace_p, find_row_edges, display_line)
857 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
858 (display_mode_element, store_mode_line_string)
859 (pint2str, pint2hrstr, decode_mode_spec)
860 (display_count_lines, display_string, draw_glyphs)
861 (x_produce_glyphs, x_insert_glyphs)
862 (rows_from_pos_range, mouse_face_from_buffer_pos)
863 (fast_find_string_pos, mouse_face_from_string_pos)
864 (note_mode_line_or_margin_highlight, note_mouse_highlight):
865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
866 (safe_call, init_from_display_pos, handle_fontified_prop)
867 (handle_single_display_spec, load_overlay_strings)
868 (with_echo_area_buffer, setup_echo_area_for_printing)
869 (display_echo_area, echo_area_display)
870 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
871 (update_tool_bar, hscroll_window_tree, redisplay_internal)
872 (redisplay_window, dump_glyph_row, display_mode_line)
873 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
874 (handle_display_spec, display_prop_string_p):
875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
876 (handle_single_display_spec, build_desired_tool_bar_string)
877 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
878 (get_specified_cursor_type):
879 Check that fixnums are in proper range for system types.
880 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
882 Don't assume fixnums fit in int.
883 (compare_overlay_entries):
884 Avoid mishandling comparisons due to subtraction overflow.
885 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
886 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
887 (handle_tool_bar_click):
888 Use int, not unsigned, since we prefer signed and the signedness
890 (get_next_display_element, next_element_from_display_vector):
891 Use int, not EMACS_INT, when int is wide enough.
892 (start_hourglass): Use duration_to_sec_usec to do proper
893 overflow checking on durations.
894 * xfaces.c (Fbitmap_spec_p):
895 Check that fixnums are in proper range for system types.
896 (compare_fonts_by_sort_order):
897 Avoid mishandling comparisons due to subtraction overflow.
898 (Fx_family_fonts, realize_basic_faces):
899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
901 Don't assume fixnum fits in int.
902 Use SAFE_ALLOCA_LISP, not alloca.
903 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
904 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
905 (face_at_buffer_position, face_for_overlay_string)
906 (face_at_string_position):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
909 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
911 Check that fixnums are in proper range for system types.
912 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
913 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
915 (Fx_change_window_property): Don't assume fixnums fit in int.
916 * xfont.c (xfont_chars_supported):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
918 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
919 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
921 * xml.c (parse_region):
922 * xrdb.c (magic_file_p):
923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
924 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
925 (x_get_local_selection, x_reply_selection_request)
926 (x_handle_selection_request, wait_for_property_change):
927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
928 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
929 short is wide enough.
930 (x_send_client_event): Don't assume fixnum fits in int.
931 * xterm.c (x_x_to_emacs_modifiers):
932 Don't assume EMACS_INT overflows nicely into int.
933 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
935 (handle_one_xevent): NATNUMP can eval its arg twice.
936 (x_connection_closed):
937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
938 * xterm.h: Adjust decls to match defn changes elsewhere.
939 (struct scroll_bar): Use struct vectorlike_header
940 rather than rolling our own approximation.
941 (SCROLL_BAR_VEC_SIZE): Remove; not used.
943 2012-05-25 Glenn Morris <rgm@gnu.org>
945 * lisp.mk (lisp): Update for more files being compiled now.
947 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
949 * lread.c: Remove `read_pure' which makes no difference.
950 (read_pure): Remove var.
951 (unreadpure): Remove function.
952 (readevalloop): Don't call read_list with -1 flag.
953 (read1, read_vector): Don't test read_pure any more.
954 (read_list): Simplify.
956 * fileio.c, character.h: Minor style tweaks.
958 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
960 * window.h (clip_changed): Remove useless declaration.
962 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
964 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
965 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
967 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
970 This directory predates autoconf and is no longer needed nowadays.
971 Move its few remaining bits of functionality to where they're needed.
972 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
973 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
974 * m/template.h: Remove.
975 * Makefile.in (M_FILE): Remove. All uses removed.
976 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
977 * lisp.h (USE_LSB_TAG):
978 * mem-limits.h (EXCEEDS_LISP_PTR):
979 Use VAL_MAX, not VALBITS, in #if.
980 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
981 (EMACS_UINT): Define unconditionally now.
982 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
983 (BITS_PER_EMACS_INT): New constants, replacing
984 what used to be in config.h, but not useful in #if.
985 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
986 define them any more.
987 (VAL_MAX): New macro.
989 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
990 BITS_PER_EMACS_INT, in #if.
991 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
992 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
993 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
994 * s/ms-w32.h (DATA_START):
995 Move here from removed file m/intel386.h.
996 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
997 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
999 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1001 Assume C89 or later.
1002 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1003 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1005 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1006 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1007 * textprop.c, tparam.c (NULL): Remove.
1008 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1009 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1010 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1011 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1012 * xterm.c (input_signal_count): Assume volatile works.
1014 2012-05-21 Ken Brown <kbrown@cornell.edu>
1016 * xgselect.c (xg_select): Fix first argument in call to 'select'
1019 2012-05-20 Ken Brown <kbrown@cornell.edu>
1021 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1022 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1024 2012-05-19 Ken Brown <kbrown@cornell.edu>
1026 * xfns.c (x_in_use): Remove `static' qualifier.
1027 * xterm.h (x_in_use): Declare.
1028 * xgselect.c: Include xterm.h.
1029 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1030 and `display_arg' (bug#9754).
1032 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1034 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1036 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1037 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1039 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1041 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1043 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1044 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1046 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1047 reference to image_cache->refcount.
1048 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1050 2012-05-17 Juri Linkov <juri@jurta.org>
1052 * search.c (Fword_search_regexp, Fword_search_backward)
1053 (Fword_search_forward, Fword_search_backward_lax)
1054 (Fword_search_forward_lax): Move functions to isearch.el
1055 (bug#10145, bug#11381).
1057 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1059 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1061 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1063 * lread.c (init_obarray): Declare Qt and Qnil as special.
1065 2012-05-14 Glenn Morris <rgm@gnu.org>
1067 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1068 Put "libexec" before "bin", for the sake of init_callproc_1.
1070 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1072 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1074 * unexaix.c: Port to more-recent AIX compilers.
1075 (report_error, report_error_1, make_hdr, copy_sym)
1076 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1077 Make arguments const char *, not char *, to avoid violations of C
1078 standard and to fix some AIX warnings reported by Gilles Pion.
1080 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1082 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1083 already have overlays loaded.
1084 (handle_single_display_spec): Before returning without displaying
1085 fringe bitmap, synchronize the bidi iterator with the main display
1086 iterator, by calling iterate_out_of_display_property.
1087 (iterate_out_of_display_property): Detect buffer iteration by
1088 testing that it->string is a Lisp string.
1089 (get_next_display_element): When the current object is exhausted,
1090 and there's something on it->stack, call set_iterator_to_next to
1091 proceed with what's on the stack, instead of returning zero.
1092 (set_iterator_to_next): If called at the end of a Lisp string,
1093 proceed to consider_string_end without incrementing string
1094 position. Don't increment display vector index past the end of
1095 the display vector. (Bug#11417)
1096 (pos_visible_p): Don't report a position visible when move_it_to
1097 stopped at the last line of window, which happens to be scanned
1098 backwards by the bidi iteration. (Bug#11464)
1100 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1102 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1103 and right-margin display specs even if the spec is invalid or we
1104 are on a TTY, and thus unable to display on the fringes.
1105 That's because the text with the property will not be displayed anyway,
1106 so we need to signal to the caller that this is a "replacing"
1107 display spec. This fixes display when the spec is invalid or we
1110 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1112 * unexaix.c (make_hdr): Fix typo in prototype.
1113 This bug broke the build on AIX. Problem reported by Gilles Pion.
1115 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1117 * keyboard.c (kbd_buffer_get_event): Read special events also in
1118 batch mode. (Bug#11415)
1120 2012-05-12 Glenn Morris <rgm@gnu.org>
1122 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1124 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1126 * lisp.mk (lisp): Add newcomment.elc.
1128 2012-05-12 Glenn Morris <rgm@gnu.org>
1130 * Makefile.in (MKDIR_P): New, set by configure.
1131 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1133 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1135 Remove unused function hourglass_started.
1136 * dispextern.h (hourglass_started):
1137 * w32fns.c (hourglass_started):
1138 * xdisp.c (hourglass_started): Remove.
1140 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1142 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1143 Update dependencies.
1145 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1147 * xgselect.c (xg_select): Put maxfds+1 into a var.
1148 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1150 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1152 2012-05-10 Dave Abrahams <dave@boostpro.com>
1154 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1155 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1157 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1159 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1160 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1161 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1162 Initialize xd_registered_buses.
1164 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1166 Untag more efficiently if USE_LSB_TAG.
1167 This is based on a proposal by YAMAMOTO Mitsuharu in
1168 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1169 For an admittedly artificial (nth 8000 longlist) benchmark on
1170 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1171 Emacs's overall text size by 1%.
1172 * lisp.h (XUNTAG): New macro.
1173 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1174 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1175 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1176 * eval.c (Fautoload):
1177 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1178 * frame.h (XFRAME): Use XUNTAG.
1180 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1181 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1182 Remove unportable assumptions about print widths of types like
1184 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1185 intptr_t when converting between pointer and integer, to avoid GCC
1186 warnings about wrong width.
1188 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1190 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1191 stack for each reader_thread, instead of defaulting to 8MB
1192 determined by the linker. This avoids failures in creating
1193 subprocesses on Windows 7, see the discussion in this thread:
1194 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1196 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1198 Fix up display of the *Minibuf-0* buffer in the mini window.
1199 * keyboard.c (read_char): Don't clear the echo area if there's no
1201 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1202 contents of *Minibuf-0*) if there's no message displayed in its stead.
1204 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1206 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1209 2012-05-06 Chong Yidong <cyd@gnu.org>
1211 * lisp.mk (lisp): Update.
1213 2012-05-05 Jim Meyering <meyering@redhat.com>
1215 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1217 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1219 * data.c (PUT_ERROR): New macro.
1220 (syms_of_data): Use it. Add new error type `user-error'.
1221 * undo.c (user_error): New function.
1222 (Fprimitive_undo): Use it.
1223 * print.c (print_error_message): Adjust print style for `user-error'.
1224 * keyboard.c (user_error): New function.
1225 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1227 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1229 Do not limit current-time-string to years 1000..9999.
1230 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1231 (Fcurrent_time_string): Support any year that is supported by the
1232 underlying localtime representation. Don't use asctime, as it
1233 has undefined behavior for years outside the range -999..9999.
1235 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1237 Fix race conditions involving setenv, gmtime, localtime, asctime.
1238 Without this fix, interrupts could mess up code that uses these
1239 nonreentrant functions, since setting TZ invalidates existing
1240 tm_zone or tzname values, and since most of these functions return
1241 pointers to static storage.
1242 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1243 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1244 Grow the critical sections to include not just invoking
1245 localtime/gmtime, but also accessing these functions' results
1246 including their tm_zone values if any, and any related TZ setting.
1247 (format_time_string): Last arg is now struct tm *, not struct tm **,
1248 so that the struct tm is saved in the critical section.
1249 All callers changed. Simplify allocation of initial buffer, partly
1250 motivated by the fact that memory allocation needs to be outside
1251 the critical section.
1253 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1255 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1256 with RESET_INTERVAL.
1258 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1259 Remove duplicated buffer name initialization.
1261 2012-05-02 Jim Meyering <jim@meyering.net>
1263 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1265 * xfns.c (x_window): Use xstrdup (Bug#11375).
1267 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1269 * xdisp.c (pos_visible_p): If already at a newline from the
1270 display string before the 'while' loop, don't walk back the glyphs
1271 from it3.glyph_row. Solves assertion violation when the display
1272 string begins with a newline (egg.el). (Bug#11367)
1274 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1276 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1279 2012-05-01 Glenn Morris <rgm@gnu.org>
1281 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1282 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1283 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1284 All were removed before 23.1.
1286 * dispnew.c: Remove HAVE_LIBNCURSES test;
1287 it is always true on relevant platforms.
1289 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1290 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1292 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1294 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1296 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1297 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1300 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1302 Do not avoid creating empty evaporating overlays (Bug#9642).
1303 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1304 That is, do not delete an evaporating overlay if it becomes
1305 empty after its bounds are adjusted to fit within its buffer.
1306 This fix caused other problems, and I'm reverting it until we get
1307 to the bottom of them.
1309 2012-04-27 Chong Yidong <cyd@gnu.org>
1311 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1313 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1315 * xdisp.c (pos_visible_p): If the window start position is beyond
1316 ZV, start the display from buffer beginning. Prevents assertion
1317 violation in init_iterator when the minibuffer window is scrolled
1320 * window.c (window_scroll_pixel_based): Likewise.
1322 2012-04-27 Chong Yidong <cyd@gnu.org>
1324 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1326 2012-04-27 Glenn Morris <rgm@gnu.org>
1328 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1329 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1331 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1333 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1334 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1336 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1338 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1339 display element, check also the underlying string or buffer
1340 character. (Bug#11341)
1342 * w32menu.c: Include w32heap.h.
1343 (add_menu_item): If the call to AppendMenuW (via
1344 unicode_append_menu) fails, disable Unicode menus only if we are
1345 running on Windows 9X/Me.
1347 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1349 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1350 (xgetint): Add missing shift for LSB tags.
1352 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1354 * keyboard.c (read_char): Don't wipe echo area for select window
1355 events: These might get delayed via `mouse-autoselect-window'
1358 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1360 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1361 manipulation of :loaded-from data.
1363 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1365 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1366 now a cons (bug#11311).
1368 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1370 Do not create empty overlays with the evaporate property (Bug#9642).
1371 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1372 if it becomes empty after its bounds are adjusted to fit within
1373 its buffer. Without this fix, in a nonempty buffer (let ((o
1374 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1375 yields an empty overlay that has the evaporate property, which is
1376 not supposed to happen.
1378 Fix minor GTK3 problems found by static checking.
1379 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1380 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1381 (struct _EmacsFixedClass, emacs_fixed_get_type):
1382 Move decls here from emacsgtkfixed.h, since they needn't be public.
1383 (emacs_fixed_get_type): Now static.
1384 (emacs_fixed_class_init): Omit unused local.
1385 (emacs_fixed_child_type): Remove; unused.
1386 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1387 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1388 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1389 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1390 (EMACS_FIXED_GET_CLASS): Remove; unused.
1391 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1393 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1394 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1396 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1398 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1399 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1400 (__malloc_size_t, __malloc_ptrdiff_t):
1401 Remove. All uses removed, replaced by the definiens if needed,
1402 since we can assume C89 or better now.
1403 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1404 (protect_malloc_state, align, get_contiguous_space)
1405 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1406 (malloc_atfork_handler_child, malloc_enable_thread)
1407 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1408 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1409 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1410 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1411 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1412 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1413 Define using prototypes, not old style.
1414 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1415 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1416 (align): Don't assume that signed integer overflow wraps around.
1417 Omit unused local var.
1418 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1419 (_free_internal_nolock, memalign, mallochook, reallochook):
1420 Omit no-longer-needed casts.
1421 (valloc): Use getpagesize, not __getpagesize.
1422 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1423 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1425 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1427 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1429 Move functions from C to Lisp. Make non-blocking method calls
1430 the default. Implement further D-Bus standard interfaces.
1432 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1433 (QCdbus_request_name_allow_replacement)
1434 (QCdbus_request_name_replace_existing)
1435 (QCdbus_request_name_do_not_queue)
1436 (QCdbus_request_name_reply_primary_owner)
1437 (QCdbus_request_name_reply_in_queue)
1438 (QCdbus_request_name_reply_exists)
1439 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1440 (QCdbus_registered_serial, QCdbus_registered_method)
1441 (QCdbus_registered_signal): New Lisp objects.
1442 (XD_DEBUG_MESSAGE): Use sizeof.
1443 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1444 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1445 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1446 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1447 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1448 (xd_signature, xd_append_arg): Allow float for integer types.
1449 (xd_get_connection_references): New function.
1450 (xd_get_connection_address): Rename from xd_initialize.
1451 Return cached address.
1452 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1453 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1455 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1456 Return number of refcounts.
1457 (Fdbus_get_unique_name): Make stronger parameter check.
1458 (Fdbus_message_internal): New defun.
1459 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1460 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1461 (Fdbus_send_signal, Fdbus_register_service)
1462 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1463 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1464 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1465 (Vdbus_compiled_version, Vdbus_runtime_version)
1466 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1467 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1468 (Vdbus_message_type_signal): New defvars.
1469 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1472 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1474 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1475 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1476 Do not assume ptrdiff_t is the same width as 'int'.
1478 * alloc.c: Handle unusual debugging option combinations.
1479 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1480 since the two debugging options are incompatible.
1481 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1483 (mem_init, mem_insert, mem_insert_fixup):
1484 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1485 (NEED_MEM_INSERT): Remove; no longer needed.
1487 2012-04-22 Leo Liu <sdl.web@gmail.com>
1489 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1491 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1493 * sysdep.c [__FreeBSD__]: Minor cleanups.
1494 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1495 Use Emacs indenting style more consistently. Avoid some casts.
1496 Use 'double' consistently rather than mixing 'float' and 'double'.
1498 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1500 * sysdep.c (list_system_processes, system_process_attributes):
1501 Add implementation for FreeBSD (Bug#5243).
1503 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1505 * lisp.mk (lisp): Update.
1507 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1509 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1510 It is never used otherwise.
1512 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1514 * print.c (print_preprocess): Only check print_depth if print-circle
1516 (print_object): Check for cycles even when print-circle is nil and
1517 print-gensym is t, but only check print_depth if print-circle is nil.
1519 2012-04-20 Chong Yidong <cyd@gnu.org>
1521 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1522 set the status to "failed" and ensure that sentinel is run.
1524 2012-04-20 Glenn Morris <rgm@gnu.org>
1526 * process.c (Fset_process_inherit_coding_system_flag)
1527 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1528 (Fmake_network_process, Fmake_serial_process): Doc fix.
1530 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1532 * xdisp.c (string_buffer_position_lim): Limit starting position to
1534 (set_cursor_from_row): If called for a mode-line or header-line
1535 row, return zero immediately.
1536 (try_cursor_movement): If inside continuation line, don't back up
1537 farther than the first row after the header line, if any.
1538 Don't consider the header-line row as "partially visible", even if
1539 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1541 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1543 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1546 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1547 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1549 configure: new option --enable-gcc-warnings (Bug#11207)
1550 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1551 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1552 (ALL_CFLAGS): Use new macros rather than old.
1553 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1554 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1555 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1556 -Wunused-result, -Wunused-variable. This should go away once
1557 the Emacs and Gnulib regex code is merged.
1558 (xmalloc, xrealloc): Now static.
1560 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1562 * dired.c (Fsystem_groups): Remove unused local.
1564 2012-04-17 Glenn Morris <rgm@gnu.org>
1566 * dired.c (Fsystem_users): Doc fix.
1568 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1570 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1571 (syms_of_dired): Add them.
1573 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1575 Fix minor alloc.c problems found by static checking.
1576 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1577 New extern decls, to avoid calling undeclared functions.
1578 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1579 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1580 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1581 (NEED_MEM_INSERT): New macro.
1582 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1583 Remove one incorrect comment and fix another.
1585 Fix minor ralloc.c problems found by static checking.
1586 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1587 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1588 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1589 (r_alloc_sbrk): Now static.
1591 Improve ralloc.c interface checking.
1592 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1593 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1594 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1595 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1596 [REL_ALLOC]: ... to here, to check interface.
1597 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1598 Remove decls. This fixes an "It stinks!".
1600 * alloc.c (which_symbols): Fix alignment issue / type clash.
1602 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1604 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1605 (struct Lisp_Misc_Any): Likewise.
1606 (struct Lisp_Free): Likewise.
1607 * alloc.c (union aligned_Lisp_Symbol): Define.
1608 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1609 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1610 (union aligned_Lisp_Misc): Define.
1611 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1612 aligned_Lisp_Misc instead of union Lisp_Misc.
1613 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1615 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1617 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1618 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1619 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1620 * s/netbsd.h, s/sol2-6.h:
1621 Remove definition of GC_MARK_STACK, since the default now works.
1622 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1623 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1624 no longer the default.
1625 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1627 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1629 * lread.c (lisp_file_lexically_bound_p):
1630 Fix hang at ";-*-\n" (bug#11238).
1632 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1634 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1635 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1637 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1639 * nsterm.m (constrainFrameRect): Always constrain when there is only
1640 one screen (Bug#10962).
1642 2012-04-13 Ken Brown <kbrown@cornell.edu>
1644 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1646 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1648 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1650 2012-04-11 Daniel Colascione <dancol@dancol.org>
1652 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1653 against is gone. It's better to use vfork now so that when Cygwin
1654 gains a new, working vfork, we use it automatically (bug#10398).
1656 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1658 * window.c (save_window_save): Obey window-point-insertion-type.
1660 2012-04-11 Glenn Morris <rgm@gnu.org>
1662 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1664 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1666 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1668 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1670 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1671 (force_quit_count): New var.
1672 (handle_interrupt): Use it.
1674 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1676 * w32.c (w32_delayed_load): Record the full path of the library
1677 being loaded (bug#10424).
1679 2012-04-09 Glenn Morris <rgm@gnu.org>
1681 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1682 not just in the obarray, before snarfing them. (Bug#11036)
1684 * Makefile.in ($(leimdir)/leim-list.el):
1685 Pass EMACS rather than BUILT_EMACS.
1687 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1689 * process.c (make_process):
1690 * process.h: Add integer `gnutls_handshakes_tried' member to
1693 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1694 Add convenience `GNUTLS_LOG2i' macro.
1696 * gnutls.c (gnutls_log_function2i): Convenience log function.
1697 (emacs_gnutls_read): Use new log functions,
1698 `gnutls_handshakes_tried' process member, and
1699 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1700 attempts per process (connection).
1702 2012-04-09 Chong Yidong <cyd@gnu.org>
1704 * eval.c (Fuser_variable_p, user_variable_p_eh)
1705 (lisp_indirect_variable): Functions deleted.
1706 (Fdefvar): Caller changed.
1708 * callint.c (Finteractive, Fcall_interactively):
1709 * minibuf.c (Fread_variable): Callers changed.
1711 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1713 * xdisp.c (set_cursor_from_row): If the display string appears in
1714 the buffer at position that is closer to point than the position
1715 after the display string, display the cursor on the first glyph of
1716 the display string. Fixes cursor display when a 'display' text
1717 property immediately follows invisible text. (Bug#11094)
1719 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1721 composite.c: use 'double' consistently
1722 * composite.c (get_composition_id): Use 'double' consistently
1723 instead of converting 'float' to 'double' and vice versa; this is
1724 easier to understand and avoids a GCC warning.
1726 2012-04-09 Glenn Morris <rgm@gnu.org>
1728 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1729 preparation for dumping it with emacs. (Bug#4789)
1730 (leimdir): New variable.
1731 ($(leimdir)/leim-list.el): New rule.
1732 (emacs$(EXEEXT)): Depend on leim-list.el.
1734 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1735 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1736 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1738 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1740 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1743 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1745 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1746 Remove unused local variable.
1748 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1750 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1751 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1752 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1753 objects, as mark_maybe_pointer will catch them otherwise.
1754 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1755 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1757 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1759 Fix typo that broke non-Windows builds.
1760 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1762 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1764 Support building on MS-Windows with libxml2.
1766 * makefile.w32-in (OBJ2): Add xml.$(O).
1767 (GLOBAL_SOURCES): Add xml.c.
1768 ($(BLD)/xml.$(O)): New dependency list.
1770 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1771 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1772 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1773 [!WINDOWSNT]: New macros.
1774 (init_libxml2_functions, libxml2_loaded_p): New functions.
1775 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1776 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1777 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1778 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1780 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1781 Call init_libxml2_functions before calling libxml2 functions.
1782 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1784 * emacs.c: Don't include libxml/parser.h.
1785 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1786 xmlCleanupParser directly.
1788 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1790 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1792 * indent.c (Fvertical_motion): If there is a display string at
1793 point, use it.vpos to compute how many lines to backtrack after
1794 move_it_to point. (Bug#11133)
1796 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1798 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1799 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1800 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1801 macros related to unification of CJK characters. For the details,
1802 see the discussion following the message here:
1803 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1805 2012-04-04 Chong Yidong <cyd@gnu.org>
1807 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1809 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1811 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1812 instead of alloca. (Bug#11138)
1814 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1816 * w32menu.c (is_simple_dialog): Properly check lisp types.
1819 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1821 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1822 position we get to after a call to move_it_to fails the
1823 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1824 only if we wind up in a string from display property. (Bug#11063)
1826 * window.c (Fdelete_other_windows_internal): Invalidate the row
1827 and column information about mouse highlight, so that redisplay
1828 restores it after reallocating the glyph matrices. (Bug#7464)
1830 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1831 string comes from a `display' text property, use the buffer
1832 position of that property as if we actually saw that position in
1834 (move_it_by_lines): Remove the assertion that
1835 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1836 violated when there's a before-string at the beginning of a line.
1839 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1841 * xdisp.c (append_space_for_newline): If the default face was
1842 remapped, use the remapped face for the appended newline.
1843 (extend_face_to_end_of_line): Use the remapped default face for
1844 extending the face to the end of the line.
1845 (display_line): Call extend_face_to_end_of_line when the default
1846 face was remapped. (Bug#11068)
1848 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1850 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1852 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1854 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1856 2012-03-27 Glenn Morris <rgm@gnu.org>
1858 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1861 2012-03-26 Kenichi Handa <handa@m17n.org>
1863 * dispextern.h (struct glyph): Fix previous change. Change the
1864 bit length of glyphless.ch to 25 (Bug#11082).
1866 2012-03-26 Chong Yidong <cyd@gnu.org>
1868 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1869 (command_loop_1): Use it; inhibit selection update for
1870 handle-select-window too (Bug#8996).
1872 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1874 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1876 2012-03-25 Kenichi Handa <handa@m17n.org>
1878 * dispextern.h (struct glyph): Change the bit length of
1879 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1881 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1883 * s/ms-w32.h (tzname): Include time.h before redirecting to
1884 _tzname. Fixes the MSVC build. (Bug#9960)
1886 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1888 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1891 * xterm.c (XTread_socket): Only modify handling_signal if
1892 !SYNC_INPUT. (Bug#11080)
1894 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1896 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1897 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1898 when fetching a multibyte character consumes more bytes than
1899 CHAR_BYTES returns, due to unification of CJK characters in
1900 string_char. (Bug#11073)
1902 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1904 * process.c (wait_reading_process_output): Handle pty disconnect
1905 by refraining from sending oneself a SIGCHLD (bug#10933).
1907 2012-03-22 Chong Yidong <cyd@gnu.org>
1909 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1911 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1912 Mark string as coming from a prefix property.
1913 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1914 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1916 2012-03-21 Chong Yidong <cyd@gnu.org>
1918 * xfaces.c (Vface_remapping_alist): Doc fix.
1920 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1922 * w32proc.c (Fw32_set_console_codepage)
1923 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1926 2012-03-20 Chong Yidong <cyd@gnu.org>
1928 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1929 to reflect default non-nil value of redisplay-dont-pause.
1931 2012-03-19 Kenichi Handa <handa@m17n.org>
1933 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1934 it fit in a valid range (Bug#11003).
1936 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1938 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1939 that is not from display property, accept the row as a "cursor
1940 row" if one of the string's character has a non-nil `cursor'
1941 property. Fixes cursor positioning when there are newlines in
1942 overlay strings, e.g. in icomplete.el. (Bug#11035)
1944 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1946 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1948 2012-03-12 Chong Yidong <cyd@gnu.org>
1950 * eval.c (inhibit_lisp_code): Rename from
1951 inhibit_window_configuration_change_hook; move from window.c.
1953 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1954 * window.c (run_window_configuration_change_hook)
1955 (syms_of_window): Callers changed.
1957 2012-03-11 Chong Yidong <cyd@gnu.org>
1959 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1961 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1963 2012-03-10 Chong Yidong <cyd@gnu.org>
1965 * frame.c (other_visible_frames): Don't assume the selected frame
1966 is visible (Bug#10955).
1968 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1970 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1972 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1974 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1975 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1978 2012-03-03 Glenn Morris <rgm@gnu.org>
1980 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1982 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1984 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1985 position past the first glyph_row that ends at ZV. (Bug#10902)
1986 (redisplay_window, next_element_from_string): Fix typos in
1988 (redisplay_window): Pass to move_it_vertically the margin in
1989 pixels, not in screen lines.
1991 2012-03-02 Glenn Morris <rgm@gnu.org>
1993 * buffer.c (buffer-list-update-hook): Doc fix.
1995 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1997 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1998 push_it before setting up the iterator for the first overlay
1999 string, even if we have an empty string loaded.
2000 (next_overlay_string): If there's an empty string on the iterator
2001 stack, pop the stack. (Bug#10903)
2003 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2005 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2006 Suggested by Stefan Monnier in
2007 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2008 * alloc.c (widen_to_Lisp_Object): New static function.
2009 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2010 and widening them to Lisp_Objects. This would work even if
2011 USE_LSB_TAG is defined and wide integers are used, which might
2012 happen in a future version of Emacs.
2014 2012-02-25 Chong Yidong <cyd@gnu.org>
2016 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2019 * xselect.c (Fx_selection_exists_p): Doc fix.
2020 (x_clipboard_manager_save_all): Print an informative message
2021 before saving to clipboard manager.
2023 2012-02-24 Chong Yidong <cyd@gnu.org>
2025 * keyboard.c (process_special_events): Handle all X selection
2026 requests in kbd_buffer, not just the next one (Bug#8869).
2028 2012-02-23 Chong Yidong <cyd@gnu.org>
2030 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2031 call when setting menu-bar-lines and tool-bar-lines parameters.
2032 (unwind_create_frame_1): New helper function.
2034 * window.c (inhibit_window_configuration_change_hook): New var.
2035 (run_window_configuration_change_hook): Obey it.
2036 (syms_of_window): Initialize it.
2038 2012-02-22 Chong Yidong <cyd@gnu.org>
2040 * xterm.c (x_draw_image_relief): Add missing type check for
2041 Vtool_bar_button_margin (Bug#10743).
2043 2012-02-21 Chong Yidong <cyd@gnu.org>
2045 * fileio.c (Vfile_name_handler_alist): Doc fix.
2047 * buffer.c (Fget_file_buffer): Protect against invalid file
2048 handler return value.
2050 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2052 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2053 when computing $valmask.
2055 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2056 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2057 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2058 It's useless in that case, and it can cause problems on hosts
2059 that allocate halves of EMACS_INT values separately.
2060 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2061 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2062 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2063 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2064 it avoids undefined behavior on hosts where shifting right by more
2065 than the word width has undefined behavior.
2067 2012-02-19 Chong Yidong <cyd@gnu.org>
2069 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2070 (Funhandled_file_name_directory, Ffile_name_as_directory)
2071 (Fdirectory_file_name, Fexpand_file_name)
2072 (Fsubstitute_in_file_name): Protect against invalid file handler
2073 return values (Bug#10845).
2075 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2077 * .gdbinit (pitx): Fix incorrect references to fields of the
2080 2012-02-17 Chong Yidong <cyd@gnu.org>
2082 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2084 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2086 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2087 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2089 2012-02-15 Chong Yidong <cyd@gnu.org>
2091 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2092 marked as special. Also, starting docstrings with * is obsolete.
2094 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2096 * gnutls.c (emacs_gnutls_write): Fix last change.
2098 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2100 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2103 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2105 * keymap.c (Fsingle_key_description): Handle char ranges.
2107 2012-02-12 Chong Yidong <cyd@gnu.org>
2109 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2110 as that creates a dangerous corner case.
2112 * window.c (Fdelete_window_internal): Invalidate the mouse
2113 highlight (Bug#9904).
2115 2012-02-12 Glenn Morris <rgm@gnu.org>
2117 * xselect.c (Fx_own_selection_internal)
2118 (Fx_get_selection_internal, Fx_disown_selection_internal)
2119 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2120 * nsselect.m (Fx_own_selection_internal)
2121 (Fx_disown_selection_internal, Fx_selection_exists_p)
2122 (Fx_selection_owner_p, Fx_get_selection_internal):
2123 Sync docs and argument specs with the xselect.c versions.
2125 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2127 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2129 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2131 * w32select.c (Fx_selection_exists_p): Sync doc string and
2132 argument list with xselect.c. (Bug#10783)
2134 * w16select.c (Fx_selection_exists_p): Sync doc string and
2135 argument list with xselect.c. (Bug#10783)
2137 2012-02-10 Glenn Morris <rgm@gnu.org>
2139 * fns.c (Fsecure_hash): Doc fix.
2141 2012-02-09 Kenichi Handa <handa@m17n.org>
2143 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2145 2012-02-07 Chong Yidong <cyd@gnu.org>
2147 * buffer.c (Fbuffer_local_variables)
2148 (buffer_lisp_local_variables): Handle unbound vars correctly;
2149 don't let Qunbound leak into Lisp.
2151 2012-02-07 Glenn Morris <rgm@gnu.org>
2153 * image.c (Fimagemagick_types): Doc fix.
2155 * image.c (imagemagick-render-type): Change it from a lisp object
2156 to an integer. Move the doc here from the lisp manual.
2157 Treat all values not equal to 0 the same.
2159 2012-02-06 Chong Yidong <cyd@gnu.org>
2161 * doc.c (store_function_docstring): Avoid applying docstring of
2162 alias to base function (Bug#2603).
2164 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2166 * .gdbinit (pp1, pv1): Remove redundant defines.
2169 2012-02-04 Chong Yidong <cyd@gnu.org>
2171 * nsterm.m: Declare a global (Bug#10694).
2173 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2175 * w32.c (get_emacs_configuration_options):
2176 Include --enable-checking, if specified, in the return value.
2178 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2180 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2181 after rounding frame sizes. (Bug#9723)
2183 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2185 * keyboard.c (adjust_point_for_property): Don't position point
2186 before BEGV. (Bug#10696)
2188 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2190 Handle overflow when computing char display width (Bug#9496).
2191 * character.c (char_width): Return EMACS_INT, not int.
2192 (char_width, c_string_width): Check for overflow when
2193 computing the width; this is possible now that individual
2194 characters can have unbounded width. Problem introduced
2195 by merge from Emacs 23 on 2012-01-19.
2197 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2199 * dbusbind.c (Fdbus_register_method): Mention the return value
2200 :ignore in the docstring.
2202 2012-02-02 Glenn Morris <rgm@gnu.org>
2204 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2206 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2207 Unconditionally set to t. (Bug#10673)
2208 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2209 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2210 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2212 2012-02-02 Kenichi Handa <handa@m17n.org>
2214 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2215 0, do not call append_composite_glyph.
2217 2012-02-02 Kenichi Handa <handa@m17n.org>
2219 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2221 (x_produce_glyphs): If the component of a composition is a null
2222 string, set it->pixel_width to 1 to avoid zero-width glyph.
2224 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2226 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2227 first 2 arguments are identical. This makes inserting large
2228 output from a subprocess an order of magnitude faster on
2229 MS-Windows, where all sbrk'ed memory is always contiguous.
2231 2012-01-31 Glenn Morris <rgm@gnu.org>
2233 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2234 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2235 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2237 2012-01-29 Glenn Morris <rgm@gnu.org>
2239 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2241 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2243 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2245 2012-01-28 Chong Yidong <cyd@gnu.org>
2247 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2249 2012-01-26 Chong Yidong <cyd@gnu.org>
2251 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2253 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2254 repeat counts (Bug#10507).
2256 2012-01-26 Glenn Morris <rgm@gnu.org>
2258 * lread.c (syms_of_lread): Doc fix.
2260 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2262 * coding.c (encode_designation_at_bol): Change return value to
2265 2012-01-25 Chong Yidong <cyd@gnu.org>
2267 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2269 2012-01-21 Chong Yidong <cyd@gnu.org>
2271 * floatfns.c (Fcopysign): Make the second argument non-optional,
2272 since nil is not allowed anyway.
2274 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2276 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2277 (send_process): Likewise.
2279 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2281 * window.c (save_window_save, Fcurrent_window_configuration)
2282 (Vwindow_persistent_parameters): Do not use Qstate.
2283 Rewrite doc-strings.
2285 2012-01-19 Kenichi Handa <handa@m17n.org>
2287 * character.c (char_width): New function.
2288 (Fchar_width, c_string_width, lisp_string_width):
2289 Use char_width (Bug#9496).
2291 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2293 * window.c (Vwindow_persistent_parameters): New variable.
2294 (Fset_window_configuration, save_window_save): Handle persistent
2297 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2299 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2300 thrashing the stack of the thread. (Bug#9087)
2302 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2304 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2306 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2308 * xdisp.c (rows_from_pos_range): Handle the case where the
2309 highlight ends on a newline. (Bug#10464)
2310 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2311 he end column for display of highlight that ends on a newline
2314 2012-01-11 Glenn Morris <rgm@gnu.org>
2316 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2317 from load-path also when installation-directory is nil. (Bug#10208)
2319 2012-01-10 Glenn Morris <rgm@gnu.org>
2321 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2323 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2324 Update template values to be closer to their typical values these days.
2326 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2328 * xdisp.c (rows_from_pos_range): Accept additional argument
2329 DISP_STRING, and accept any glyph in a row whose object is that
2330 string as eligible for mouse highlight. Fixes mouse highlight of
2331 display strings from overlays. (Bug#10464)
2333 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2335 emacs: fix an auto-save permissions race condition (Bug#10400)
2336 * fileio.c (auto_saving_dir_umask): New static var.
2337 (Fmake_directory_internal): Use it.
2338 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2339 creating the directory. The old code temporarily assigns
2340 too-generous permissions to the directory.
2341 (do_auto_save_eh): Clear it.
2342 (Fdo_auto_save): Catch all errors, not just file errors, so
2343 that the var is always cleared.
2345 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2347 * search.c (scan_buffer): Pass character positions to
2348 know_region_cache, not byte positions. (Bug#6540)
2350 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2352 * w32.c (sys_rename): Report EXDEV when rename of a directory
2353 fails because the target is on another logical disk. (Bug#10284)
2355 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2357 * xterm.c (x_embed_request_focus): New function.
2359 * xterm.h: Add prototype.
2361 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2363 2012-01-05 Glenn Morris <rgm@gnu.org>
2365 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2367 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2369 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2370 Load gnutls_transport_set_lowat only if GnuTLS version is below
2372 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2373 GnuTLS versions below 2.11.1.
2375 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2377 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2378 to the doc string advising against its use for altering the way
2379 windows are scrolled.
2381 2011-12-28 Kenichi Handa <handa@m17n.org>
2383 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2384 coding-system ASCII compatible only when it does not produce BOM
2385 on encoding (Bug#10383).
2387 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2389 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2391 (create_and_show_popup_menu): Always use menu_position_func for
2394 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2396 * callint.c (Fcall_interactively): Don't truncate prompt string.
2398 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2400 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2401 property that ends at ZV, so that the bidi iteration could be
2402 resumed from there (after widening). (Bug#10360)
2404 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2406 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2408 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2410 * nsterm.m (x_free_frame_resources):
2411 Release f->output_data.ns->miniimage.
2412 (ns_index_color): Fix indentation. Do not retain
2413 color_table->colors[i].
2415 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2418 * nsfns.m (x_set_background_color): Assign return value from
2419 ns_index_color to face-background instead of NSColor*.
2420 (ns_implicitly_set_icon_type): Fix indentation.
2421 Change assignment in for loop to comparison.
2423 * emacs.c (ns_pool): New variable.
2424 (main): Assign ns_pool.
2425 (Fkill_emacs): Call ns_release_autorelease_pool.
2427 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2428 autorelease fdesc, release fdAttrs and tdict.
2429 (ns_get_covering_families): Release charset.
2430 (ns_findfonts): Release NSFontDescriptor created with new.
2431 (ns_uni_to_glyphs): Fix indentation.
2432 (setString): Release attrStr before assigning new value.
2434 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2436 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2438 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2439 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2441 2011-12-18 David Reitter <reitter@cmu.edu>
2443 * nsterm.m (ns_term_init): Subscribe for notifications
2444 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2445 to method trackingNotification in EmacsMenu.
2447 * nsmenu.m (trackingMenu): New variable.
2448 (trackingNotification): New method (from Aquamacs).
2449 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2450 from Aquamacs (Bug#7030).
2452 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2454 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2455 (symbol_to_nsstring): Fix indentation.
2456 (ns_symbol_to_pb): New function.
2457 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2458 (Fns_rotate_cut_buffers_internal): Remove.
2459 (Fns_store_selection_internal): Rename from
2460 Fns_store_cut_buffer_internal.
2461 (ns_get_foreign_selection, Fx_own_selection_internal)
2462 (Fx_disown_selection_internal, Fx_selection_exists_p)
2463 (Fns_get_selection_internal, Fns_store_selection_internal):
2464 Use ns_symbol_to_pb and check if return value is nil.
2465 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2466 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2467 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2468 renamed to Sns_store_selection_internal.
2469 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2470 and remove this function.
2471 (ns_handle_selection_clear): Remove, never used.
2472 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2475 2011-12-17 Ken Brown <kbrown@cornell.edu>
2477 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2478 GID is unknown (Bug#10257).
2480 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2482 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2483 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2484 which caused a build failure on GNU/Linux IA-64. This problem was
2485 introduced by my 2011-10-07 patch.
2487 2011-12-15 Juri Linkov <juri@jurta.org>
2489 * image.c (imagemagick_error): New function. (Bug#10112)
2490 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2491 Use `imagemagick_error' where ImageMagick functions return
2493 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2496 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2498 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2499 fill background (Bug#8992).
2501 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2503 * window.c (Vwindow_combination_resize)
2504 (Vwindow_combination_limit): Use t instead of non-nil in
2506 (Vrecenter_redisplay): Add first sentence of doc-string on
2508 (Frecenter): Fix doc-string typo.
2510 2011-12-11 Kenichi Handa <handa@m17n.org>
2512 * coding.c (Funencodable_char_position): Pay attention to the
2513 buffer text relocation (Bug#9389).
2515 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2517 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2518 gtk_init (Bug#10100).
2520 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2522 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2523 IT->string is nil. (Bug#10263)
2525 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2527 * nsterm.h (x_free_frame_resources): Declare.
2529 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2530 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2532 * nsterm.h (ns_get_defaults_value): Declare.
2534 * nsterm.m (ns_default): Call ns_get_defaults_value.
2536 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2538 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2541 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2543 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2544 that where the value of an _OBJC_* symbol points to is in the .bss
2545 section (Bug#10240).
2547 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2549 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2550 after the loop to call ccl_driver at least once (Bug#8619).
2552 2011-12-08 Kenichi Handa <handa@m17n.org>
2554 * ftfont.c (get_adstyle_property): Fix previous change
2557 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2559 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2560 dirs from the default value of EMACSLOADPATH (bug#10208).
2562 2011-12-07 Glenn Morris <rgm@gnu.org>
2564 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2565 installation and source directories as well. (Bug#10208)
2567 2011-12-06 Chong Yidong <cyd@gnu.org>
2569 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2571 2011-12-06 Glenn Morris <rgm@gnu.org>
2573 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2574 as an error, not just -1. (Bug#10217)
2576 2011-12-05 Chong Yidong <cyd@gnu.org>
2578 * keyboard.c (process_special_events): New function.
2579 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2581 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2583 * coding.c (encode_designation_at_bol): Don't use uninitialized
2584 local variable (Bug#9318).
2586 2011-12-05 Kenichi Handa <handa@m17n.org>
2588 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2589 return Qnil (Bug#8046, Bug#10193).
2591 2011-12-05 Kenichi Handa <handa@m17n.org>
2593 * coding.c (encode_designation_at_bol): New args charbuf_end and
2594 dst. Return the number of produced bytes. Callers changed.
2595 (coding_set_source): Return how many bytes coding->source was
2597 (coding_set_destination): Return how many bytes
2598 coding->destination was relocated.
2599 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2600 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2602 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2604 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2605 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2608 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2610 The following changes are to fix Bug#9318.
2612 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2613 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2614 (encode_coding_iso_2022, encode_coding_sjis)
2615 (encode_coding_big5, encode_coding_charset): Use the above macros.
2617 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2619 * lisp.h (process_quit_flag): Fix external declaration.
2621 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2623 Don't macro-inline non-performance-critical code.
2624 * eval.c (process_quit_flag): New function.
2625 * lisp.h (QUIT): Use it.
2627 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2629 * nsfns.m (get_geometry_from_preferences): New function.
2630 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2632 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2634 * emacs.c (Qkill_emacs): Define.
2635 (syms_of_emacs): Initialize it.
2636 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2637 Qquit_flag to `kill-emacs' instead.
2638 (quit_throw_to_read_char): Add parameter `from_signal'.
2639 All callers changed. Call Fkill_emacs if requested and safe.
2640 * lisp.h (QUIT): Call Fkill_emacs if requested.
2642 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2644 * widget.c (update_wm_hints): Return if wmshell is null.
2645 (widget_update_wm_size_hints): New function.
2647 * widget.h (widget_update_wm_size_hints): Declare.
2649 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2650 widget_update_wm_size_hints (Bug#10104).
2652 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2654 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2655 before a newline, prepare the bidi iterator for consuming the
2656 newline, and keep the current paragraph direction. (Bug#10183)
2657 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2659 2011-12-02 Juri Linkov <juri@jurta.org>
2661 * search.c (Fword_search_regexp): New Lisp function created from
2662 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2663 (Fword_search_backward, Fword_search_forward)
2664 (Fword_search_backward_lax, Fword_search_forward_lax):
2665 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2666 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2668 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2670 * fileio.c (Finsert_file_contents): Move after-change-function call
2671 to before the "handled:" label, since all "goto handled" appear in
2672 cases where the *-change-functions have already been properly called
2675 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2677 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2678 waiting for input. (Bug#10169)
2680 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2682 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2683 verifies glyph row's hash code--we have just reallocated the
2684 glyphs, so their contents can be complete garbage. (Bug#10164)
2686 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2688 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2690 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2692 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2693 attributes are tested _before_ calling verify_row_hash, to protect
2694 against GCC re-ordering of the tests. (Bug#10164)
2696 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2698 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2700 * xterm.c (handle_one_xevent): Only set async_visible and friends
2701 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2702 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2703 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2705 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2707 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2708 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2709 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2710 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2711 All uses changed to use GCPRO1 etc.
2712 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2713 Revert to old implementation (i.e., before 2011-03-11).
2715 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2717 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2718 of scroll runs so as to avoid assigning disabled bogus rows and
2719 unnecessary graphics copy operations.
2721 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2723 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2724 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2725 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2726 (malloc, free, realloc, calloc): Redirect to e_* only when
2729 * lisp.h (GCTYPEBITS): Move before first use.
2730 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2731 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2732 this macro definition.
2734 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2737 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2739 * gtkutil.c (xg_create_frame_widgets):
2740 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2741 present with Gtk+ 2.0.
2743 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2745 * fileio.c (Finsert_file_contents): Undo previous change; see
2746 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2748 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2750 Rename locals to avoid shadowing.
2751 * fileio.c (Finsert_file_contents):
2752 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2753 * process.c (wait_reading_process_output):
2754 Rename inner 'proc' to 'p' to avoid shadowing.
2755 Indent for consistency with usual Emacs style.
2757 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2759 * xdisp.c (redisplay_window): If cursor row is not fully visible
2760 after recentering, and scroll-conservatively is set to a large
2761 number, scroll window by a few more lines to make the cursor fully
2762 visible and out of scroll-margin. (Bug#10105)
2763 (start_display): Don't move to the next line if the display should
2764 start at a newline that is part of a display vector or an overlay
2767 2011-11-24 Juri Linkov <juri@jurta.org>
2769 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2770 after the `MagickPingImage' call. (Bug#10112)
2772 2011-11-23 Chong Yidong <cyd@gnu.org>
2774 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2776 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2778 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2779 making another buffer current. (Bug#10114)
2781 2011-11-23 Glenn Morris <rgm@gnu.org>
2783 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2785 2011-11-23 Chong Yidong <cyd@gnu.org>
2787 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2788 using it (Bug#5984).
2790 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2792 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2793 and header-lines, as they don't have one computed for them.
2796 * .gdbinit (prow): Make displayed values more self-explaining.
2797 Add row's hash code.
2799 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2801 * process.c (wait_reading_process_output): Fix asynchrounous
2802 GnuTLS socket handling on some versions of the GnuTLS library.
2803 (wait_reading_process_output): Add comment and URL.
2805 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2807 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2809 2011-11-21 Chong Yidong <cyd@gnu.org>
2811 * window.c (Fnext_window, Fprevious_window): Doc fix.
2813 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2815 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2817 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2819 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2821 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2823 * window.c (Fset_window_combination_limit): Rename argument
2825 (Vwindow_combination_limit): Remove "status" from doc-string.
2827 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2829 * m/ibms390.h: Remove.
2830 * m/ibms390x.h: Don't include "ibms390.h".
2832 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2834 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2835 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2837 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2839 * casetab.c (Fset_case_table):
2840 * charset.c (Fcharset_after): Fix typos.
2842 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2844 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2845 Otherwise, valgrind does not work on some platforms.
2846 Problem reported by Andreas Schwab in
2847 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2848 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2849 is set, removing the need for VIRT_ADDRESS_VARIES.
2850 (PURE_P): Use a more-efficient implementation that needs just one
2851 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2852 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2853 to 4 (xorl, subq, cmpq, setbe).
2854 * alloc.c (pure): Always extern now, since that's the
2855 VIRT_ADDR_VARIES behavior.
2856 (PURE_POINTER_P): Use a single comparison, not two, for
2857 consistency with the new puresize.h.
2858 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2859 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2860 Remove VIRT_ADDR_VARIES no longer needed.
2862 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2864 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2865 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2866 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2867 behave as if the cursor position were at the window margin.
2869 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2870 and the cursor position is out of bounds, behave as if the cursor
2871 position were at the window margin. (Bug#10075)
2873 2011-11-18 Chong Yidong <cyd@gnu.org>
2875 * window.c (Fwindow_combination_limit): Make first argument
2876 non-optional, since it is meaningless for live windows like the
2879 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2881 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2883 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2885 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2886 (graft_intervals_into_buffer): Simplify.
2888 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2890 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2891 hash values of the two rows.
2892 (copy_row_except_pointers): Preserve the used[] arrays and the
2893 hash values of the two rows. (Bug#10035)
2894 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2896 * xdisp.c (row_hash): New function, body extracted from
2897 compute_line_metrics.
2898 (compute_line_metrics): Call row_hash, instead of computing the
2901 * dispnew.c (verify_row_hash): Call row_hash for computing the
2902 hash code of a row, instead of duplicating code from xdisp.c.
2904 * dispextern.h (row_hash): Add prototype.
2906 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2908 * frame.c (delete_frame): Don't delete the terminal when the last
2909 X frame is closed if emacs is built with GTK toolkit.
2911 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2913 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2915 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2917 * window.c (Vwindow_splits): Rename to
2918 Vwindow_combination_resize. Suggested by Juri Linkov.
2919 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2922 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2924 * nsfns.m (Fns_font_name):
2925 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2927 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2929 * window.h (window): Rename slot "nest" to "combination_limit".
2930 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2931 (Fset_window_nest): Rename to Fset_window_combination_limit.
2932 (Vwindow_nest): Rename to Vwindow_combination_limit.
2933 (recombine_windows, make_parent_window, make_window)
2934 (Fsplit_window_internal, saved_window)
2935 (Fset_window_configuration, save_window_save): Rename all
2936 occurrences of window_nest to window_combination_limit.
2938 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2940 * image.c (imagemagick_load_image): Fix typo.
2942 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2944 * xdisp.c (display_line): Move the call to
2945 highlight_trailing_whitespace before the call to
2946 compute_line_metrics, since the latter needs to see the final
2947 faces of all the glyphs to compute ROW's hash value.
2948 Fixes assertion violations in row_equal_p. (Bug#10035)
2950 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2952 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2953 just return (bug#10044).
2955 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2957 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2958 with user-defined heap size. Bump the default size of the temacs
2959 heap to 27MB, to avoid memory warning when running temacs.
2960 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2962 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2963 current_matrix and desired_matrix. (Bug#9990)
2964 (verify_row_hash) [XASSERTS]: New function.
2965 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2966 that the hash value of glyph rows is correct.
2968 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2970 * window.h (window): Remove splits slot.
2971 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2972 (Fdelete_other_windows_internal, make_parent_window)
2973 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2974 (Fset_window_configuration, save_window_save): Don't deal with
2975 split status of windows.
2976 (saved_window): Remove splits slot.
2977 (Vwindow_splits): Rewrite doc-string.
2979 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2981 * xfns.c (unwind_create_frame):
2982 * nsfns.m (unwind_create_frame):
2983 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2984 Vframe_list (Bug#9999).
2986 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2988 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2990 2011-11-11 Kenichi Handa <handa@m17n.org>
2992 * callproc.c (Fcall_process): Set the member dst_multibyte of
2995 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2997 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2998 avoid a crash (bug#9496).
3000 2011-11-09 Chong Yidong <cyd@gnu.org>
3002 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3003 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3005 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3007 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3009 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3011 Avoid some portability problems by eschewing 'extern inline' functions.
3012 The trivial performance wins aren't worth the portability hassles; see
3013 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3015 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3016 (window_box_width, window_box_left, window_box_left_offset)
3017 (window_box_right, window_box_right_offset): Undo previous change,
3018 by removing the "extern"s.
3019 * intervals.c (adjust_intervals_for_insertion)
3020 (adjust_intervals_for_deletion): Undo previous change,
3021 making these static again.
3022 (offset_intervals, temp_set_point_both, temp_set_point)
3023 (copy_intervals_to_string): No longer inline.
3024 * xdisp.c (window_text_bottom_y, window_box_width)
3025 (window_box_height, window_box_left_offset)
3026 (window_box_right_offset, window_box_left, window_box_right)
3027 (window_box): No longer inline.
3029 2011-11-08 Chong Yidong <cyd@gnu.org>
3031 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3032 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3033 Signal an error if not a live window.
3034 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3035 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3037 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3039 * lisp.h (syms_of_abbrev): Remove declaration.
3040 Reported by CHENG Gao <chenggao@royau.me>.
3042 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3044 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3045 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3046 of temacs in GUI mode.
3048 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3050 * window.h: Declare delete_all_child_windows instead of
3051 delete_all_subwindows.
3052 * window.c (Fwindow_nest, Fset_window_nest)
3053 (Fset_window_new_total, Fset_window_new_normal)
3054 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3055 (delete_all_subwindows): Rename to delete_all_child_windows.
3056 (Fdelete_other_windows_internal, Fset_window_configuration):
3057 Call delete_all_child_windows instead of delete_all_subwindows.
3058 * frame.c (delete_frame): Call delete_all_child_windows instead
3059 of delete_all_subwindows.
3061 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3063 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3064 This is also needed for porting to any host where GC_MARK_STACK is
3065 not GC_MAKE_GCPROS_NOOPS.
3066 (which_symbols): Use it.
3068 2011-11-07 Kenichi Handa <handa@m17n.org>
3070 * coding.c (coding_set_destination): Check coding->src_pos only
3071 when coding->src_object is a buffer (bug#9910).
3073 * process.c (send_process): Set the member src_multibyte of coding
3074 to 0 (bug#9911) when sending a unibyte text.
3076 * callproc.c (Fcall_process): Set the member src_multibyte of
3077 process_coding to 0 (bug#9912).
3079 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3081 * xmenu.c (cleanup_widget_value_tree): New function.
3082 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3083 calling free_menubar_widget_value_tree directly (Bug#9830).
3085 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3087 Fix some portability problems with 'inline'.
3088 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3089 (window_box_width, window_box_left, window_box_left_offset)
3090 (window_box_right, window_box_right_offset): Declare extern.
3091 Otherwise, these inline functions do not conform to C99 and
3092 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3093 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3094 * intervals.c (adjust_intervals_for_insertion)
3095 (adjust_intervals_for_deletion): Now extern, because otherwise the
3096 extern inline functions 'offset_intervals' couldn't refer to it.
3097 (static_offset_intervals): Remove.
3098 (offset_intervals): Rewrite using the old contents of
3099 static_offset_intervals. The old version didn't conform to C99
3100 because an extern inline function contained a reference to an
3101 identifier with static linkage.
3103 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3105 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3108 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3110 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3111 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3112 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3113 return Qleft_to_right.
3115 2011-11-06 Chong Yidong <cyd@gnu.org>
3117 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3118 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3119 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3120 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3121 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3122 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3123 (Fwindow_vscroll): Doc fix.
3124 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3125 argument, since it makes no sense to pass a live window and for
3126 consistency with window-child.
3128 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3130 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3133 2011-11-05 Jason Rumney <jasonr@gnu.org>
3135 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3136 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3138 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3139 bitwise arithmetic preventing use of unicode-sip and non-truetype
3142 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3144 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3147 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3148 initialization code to keep similarity to xfns.c after changes
3151 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3153 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3154 (unwind_create_frame): New function (Bug#9943).
3155 (Fx_create_frame): Restructure code to be more similar to the one in
3156 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3157 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3158 Move terminal->reference_count++ just before making the frame official
3161 * nsterm.m (x_free_frame_resources): New function.
3162 (x_destroy_window): Move code to x_free_frame_resources.
3164 * xfns.c (unwind_create_frame): Fix comment.
3165 (Fx_create_frame, x_create_tip_frame):
3166 Move terminal->reference_count++ just before making the frame
3167 official. Move initialization of image_cache_refcount and
3168 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3170 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3172 Support MSVC build with newer versions of Visual Studio.
3173 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3174 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3177 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3178 which are not supported by MSVC.
3179 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3180 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3182 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3184 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3186 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3188 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3190 Support MSVC build with newer versions of Visual Studio.
3191 * w32.c: Don't include w32api.h for MSVC.
3192 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3194 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3195 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3196 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3197 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3199 (alloca) [_MSC_VER]: Define to _alloca.
3201 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3203 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3205 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3207 * xdisp.c (note_mouse_highlight): If either of
3208 previous/next-single-property-change returns nil, treat that as
3209 the beginning or the end of the buffer. (Bug#9955)
3211 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3213 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3214 label is not null (Bug#9951).
3215 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3218 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3220 * window.c (Fwindow_body_size): Mention in the doc string that the
3221 return value is in frame's canonical units. (Bug#9949)
3223 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3225 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3227 * w32fns.c (unwind_create_frame): If needed, free the glyph
3228 matrices of the partially constructed frame. (Bug#9943)
3229 * xfns.c (unwind_create_frame): Likewise.
3231 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3233 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3234 Don't stop backward scan on the continuation glyph, even though
3235 its CHARPOS is positive.
3236 (mouse_face_from_buffer_pos, note_mouse_highlight):
3237 Rename cover_string to disp_string.
3239 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3241 * window.c (temp_output_buffer_show): Don't use
3242 Vtemp_buffer_show_specifiers.
3243 (Vtemp_buffer_show_specifiers): Remove unused variable.
3245 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3247 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3248 past the beginning of the current glyph matrix.
3250 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3252 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3253 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3254 HAVE_GTK3 (Bug#9869).
3256 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3257 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3259 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3261 * xterm.c: Declare x_handle_net_wm_state to return int.
3262 (handle_one_xevent): Check if we are iconified but don't have
3263 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3264 (get_current_wm_state): Return non-zero if not hidden,
3265 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3266 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3267 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3268 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3270 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3272 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3273 so that this new function doesn't get optimized away by a
3274 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3276 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3278 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3280 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3282 Fix the `xbytecode' command.
3283 * .gdbinit (xprintbytestr): New command.
3284 (xwhichsymbols): Rename from `which'; all callers changed.
3285 (xbytecode): Print the byte-code string as well.
3287 2011-10-29 Kim Storm <storm@cua.dk>
3289 * alloc.c (which_symbols): New function.
3291 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3293 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3296 2011-10-29 Glenn Morris <rgm@gnu.org>
3298 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3299 Not clear what it was for, and it causes various bugs. (Bug#9839)
3301 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3303 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3304 possible random value that matches one of those tested as
3305 condition to clear the mouse face.
3307 2011-10-28 Chong Yidong <cyd@gnu.org>
3309 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3311 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3313 * window.c (make_window): Initialize phys_cursor_on_p.
3315 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3317 * lisp.h (struct Lisp_Symbol): Update comments.
3319 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3321 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3323 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3325 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3326 <oslsachem@gmail.com> for helping to debug this.
3328 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3329 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3330 (g_b_init_get_glyph_outline_w): New static variables.
3331 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3332 (GetGlyphOutlineW_Proc): New typedefs.
3333 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3334 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3336 (w32font_open_internal, compute_metrics):
3337 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3338 instead of calling the "wide" APIs directly.
3340 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3342 * w32.h (syms_of_w32font): Add prototype.
3344 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3346 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3347 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3348 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3349 (Fmove_to_window_line): Doc fix.
3351 2011-10-27 Chong Yidong <cyd@gnu.org>
3353 * process.c (make_process): Set gnutls_state to NULL.
3355 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3356 non-NULL, regardless of GNUTLS_INITSTAGE.
3357 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3358 an error. Set process slots as soon as we allocate them.
3360 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3362 2011-10-27 Chong Yidong <cyd@gnu.org>
3364 * gnutls.c (emacs_gnutls_deinit): New function.
3365 Deallocate credentials structures as well as calling gnutls_deinit.
3366 (Fgnutls_deinit, Fgnutls_boot): Use it.
3368 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3369 (deactivate_process): Call emacs_gnutls_deinit.
3371 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3373 * image.c (x_create_x_image_and_pixmap):
3374 * w32.c (sys_rename, w32_delayed_load):
3375 * w32font.c (fill_in_logfont):
3376 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3378 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3380 * w32fns.c (w32_default_color_map): New function,
3381 extracted from Fw32_default_color_map.
3382 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3384 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3386 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3388 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3390 * keyboard.c (test_undefined): New function (bug#9751).
3391 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3393 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3395 * sysdep.c (init_sys_modes): Fix the check for the controlling
3396 terminal (Bug#6649).
3398 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3400 * dispextern.h (struct bidi_it): New member next_en_type.
3402 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3403 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3404 current character, check also for next_en_type being WEAK_EN.
3405 (bidi_resolve_weak): Don't enter the expensive loop if the current
3406 position is before next_en_pos. Record the bidi type of the first
3407 non-ET, non-BN character we find, in addition to its position.
3408 (bidi_level_of_next_char): Invalidate next_en_type when
3409 next_en_pos is over-stepped.
3411 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3413 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3414 * editfns.c: Rewrite current-time-zone so that it invokes
3415 the equivalent of (format-time-string "%Z") to get the time zone name.
3416 This fixes a bug when the time zone name contains characters that
3417 need converting from the system time locale to Emacs internal format.
3418 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3419 that patch fixed format-time-string to do the conversion, but
3420 I forgot to fix current-time-zone.
3421 (format_time_string): New function, containing most of
3422 what Fformat_time_string used to contain.
3423 (Fformat_time_string): Rewrite in terms of format_time_string.
3424 This doesn't change this function's behavior.
3425 (current-time-zone): Rewrite to use format_time_string.
3426 This fixes the bug reported by Michael Schierl in
3427 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3428 Jason Rumney's 2007-06-07 change worked around this bug, but
3430 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3432 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3434 * xdisp.c (start_display): If the character at POS is displayed
3435 via a display vector, reset IT->current.dpvec_index to zero.
3436 (try_window_reusing_current_matrix): If a line ends in a display
3437 vector or the next line starts in a display vector, continue
3438 redrawing the window even though the character position of
3439 start_row was reached.
3442 2011-10-18 Chong Yidong <cyd@gnu.org>
3444 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3445 with nobreak-char-display too.
3447 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3449 Fix part 3 of bug#9771.
3450 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3451 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3452 non-neutral characters if the current character is a paragraph
3453 separator (a.k.a. Newline). This avoids running the same
3454 expensive loop twice, once when we consume the preceding newline
3455 and the other time when the line actually needs to be displayed.
3456 Avoid the loop when we see neutrals on the base embedding level
3457 following a character whose directionality is the same as the
3458 paragraph's. This avoids running the expensive loop when a line
3459 ends in a long sequence of neutrals, like control characters.
3460 Add assertion against STRONG_AL type. Slightly rearrange code
3461 that determines the type of a neutral given the first non-neutral
3463 (bidi_level_of_next_char): Set next_en_pos to zero when
3464 invalidating its info.
3466 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3468 * xdisp.c (push_display_prop): Determine whether to record string
3469 or buffer position by IT->string, not by IT->method. Allow
3470 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3471 (move_it_vertically_backward): Don't look for character position
3472 immediately after the newline when in a continuation line.
3475 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3477 * window.c (coordinates_in_window): Rewrite and delabelize
3478 vertical border check. (Bug#5357) (Bug#9618)
3480 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3482 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3483 errors in XSetWindowBorder (bug#9310).
3485 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3487 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3488 avoid crash when xmalloc overrun checking is enabled.
3490 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3492 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3493 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3494 cursor motion with <left> and <right> arrow keys.
3496 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3497 some callers set that themselves.
3499 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3501 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3502 display string and the previous row comes from the same string and
3503 is empty. (Bug#9739) (Bug#9738)
3505 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3507 * doc.c (get_doc_string): Encode file name (bug#9735).
3509 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3511 * bidi.c (bidi_level_of_next_char):
3512 * xdisp.c (get_visually_first_element): Remove old incorrect
3513 comments regarding the Unicode Line Separator character.
3515 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3517 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3519 * alloc.c (Fgc_status): Do not access beyond zombies array
3520 boundary if nzombies > MAX_ZOMBIES.
3521 * alloc.c (dump_zombies): Add missing format specifier.
3523 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3525 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3526 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3528 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3529 Some packages use them to denote characters with modifiers.
3531 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3533 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3534 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3535 matching a pp-number. Rename parameter var to var1.
3537 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3539 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3541 2011-10-08 Glenn Morris <rgm@gnu.org>
3543 * callint.c (Fcall_interactively): Give a more explicit error for the
3544 'c' case with a non-character input. (Bug#8479)
3546 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3548 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3550 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3551 lines that are hscrolled on the left.
3553 * dispnew.c (buffer_posn_from_coords): Account for a possible
3554 presence of header-line. (Bug#4426)
3556 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3558 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3559 Don't advertise functionality which we discourage or doesn't work.
3561 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3563 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3564 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3565 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3566 this makes Emacs dump core during garbage collection on rare
3567 occasions. sizeof is obviously inferior to offsetof here, so
3568 stick with offsetof.
3569 (GC_POINTER_ALIGNMENT): New macro.
3570 (mark_memory): Omit 3rd (offset) arg; caller changed.
3571 Don't assume EMACS_INT alignment is the same as pointer alignment.
3573 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3575 * keyboard.c (read_key_sequence_remapped): New var.
3576 (read_key_sequence): Compute remapping in the right buffer.
3577 (command_loop_1): Use read_key_sequence's remapping directly.
3579 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3581 * dired.c (file_name_completion): Don't expand file name.
3582 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3583 before checking file name handler.
3585 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3586 they've been requested explicitly (bug#9591).
3588 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3590 * keymap.c (Fsingle_key_description): Use make_specified_string
3591 instead of build_string to build string from push_key_description.
3594 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3596 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3597 This fixes a Y2038 bug on 64-bit hosts.
3598 * buffer.c (reset_buffer):
3599 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3600 (Fclear_buffer_auto_save_failure):
3601 Use 0, not -1, to represent an unset failure time, since time_t
3602 might not be signed.
3604 Remove dependency on glibc malloc internals.
3605 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3606 Move back here from lisp.h, but with their new implementations.
3607 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3608 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3609 * charset.c (charset_table_init): New static var.
3610 (syms_of_charset): Use it instead of xmalloc. This removes a
3611 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3612 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3613 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3614 Move back to alloc.c.
3615 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3616 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3618 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3620 * nsterm.m (windowDidResize): Call x_set_window_size only when
3621 ns_in_resize is true. Otherwise set pixelwidth/height and
3622 call change_frame_size (Bug#9628).
3624 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3626 Port --enable-checking=all to Fedora 14 x86-64.
3627 * charset.c (syms_of_charset): Also account for glibc malloc's
3628 internal overhead when calculating the initial malloc maximum.
3630 Port --enable-checking=all to Fedora 14 x86.
3631 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3633 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3634 (overrun_check_realloc, overrun_check_free):
3635 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3636 That way, xmalloc returns a properly-aligned pointer even if
3637 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3638 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3639 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3640 into account when calculating the initial malloc maximum.
3641 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3642 Move here from alloc.c, so that charset.c can use it too.
3643 Properly align; the old code wasn't right for common 32-bit hosts
3644 when configured with --enable-checking=all.
3645 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3646 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3648 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3650 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3653 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3655 * xdisp.c (compute_display_string_end): If there's no display
3656 string at CHARPOS, return -1.
3658 * bidi.c (bidi_fetch_char): When compute_display_string_end
3659 returns a negative value, treat the character as a normal
3660 character not covered by a display string. (Bug#9624)
3662 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3664 * lread.c (Fread_from_string): Fix typo in docstring.
3666 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3668 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3669 newline, reseat the iterator instead of bidi-iterating there one
3670 character at a time. (Bug#9610)
3671 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3672 TO_CHARPOS if the bidi iterator is at base embedding level.
3674 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3676 * lread.c (readevalloop): Use correct code for NBSP.
3677 (read1): Likewise. (Bug#9608)
3679 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3681 * dbusbind.c (Fdbus_register_signal): When service is not
3682 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3684 2011-09-25 Glenn Morris <rgm@gnu.org>
3686 * buffer.c (truncate-lines): Doc fix.
3688 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3690 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3691 (Fset_window_next_buffers): Doc fix.
3693 2011-09-24 Glenn Morris <rgm@gnu.org>
3695 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3697 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3699 Fix minor problems found by static checking.
3700 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3701 * indent.c (Fvertical_motion): Fix == vs = typo.
3703 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3705 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3706 Default value is now t. Doc fix.
3708 * indent.c (Fvertical_motion): Compute and apply the overshoot
3709 logic when moving up, not only when moving down. Fix the
3710 confusing name and values of the it_overshoot_expected variable;
3711 logic changes accordingly. (Bug#9254) (Bug#9549)
3713 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3714 CHARPOS is covered by a display string which includes newlines.
3715 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3716 is covered by a display string with embedded newlines.
3718 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3720 * dbusbind.c (Fdbus_register_signal): Add match rule to
3721 Vdbus_registered_objects_table. (Bug#9581)
3722 (Fdbus_register_method, Vdbus_registered_objects_table):
3725 2011-09-24 Jim Meyering <meyering@redhat.com>
3727 do not ignore write error for any output size
3728 The previous change was incomplete.
3729 While it makes emacs --batch detect the vast majority of stdout
3730 write failures, errors were still ignored whenever the output size is
3731 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3732 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3733 && echo FAIL: ignored write error
3734 FAIL: ignored write error
3735 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3736 && echo FAIL: ignored write error
3737 FAIL: ignored write error
3738 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3740 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3742 * emacs.c (Fkill_emacs): In noninteractive mode exit
3743 non-successfully if a write error occurred on stdout. (Bug#9574)
3745 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3747 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3750 * dispextern.h (struct it): Update the comment documenting what
3753 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3755 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3756 a display string, extend search for cursor position to end of row.
3757 (find_row_edges): If the row ends in a newline from a display
3758 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3759 Handle the case of a display string with multiple newlines.
3760 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3761 non-empty line. Fixes confusing cursor motion with arrow keys at
3762 the beginning of a line that starts with whitespace.
3764 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3766 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3769 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3771 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3774 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3776 * xdisp.c (display_line): Record maximum and minimum buffer
3777 positions even if no glyphs were produced (e.g., by a zero-width
3778 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3779 buffer positions that will be removed from the glyph row because
3781 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3782 column is beyond frame width: don't subtract 1 "pixel" when
3783 computing width of the stretch.
3784 (reseat_at_next_visible_line_start): Undo the change made on
3785 2011-09-17 that saved paragraph information and restored it after
3786 the call to `reseat'. (Bug#9545)
3788 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3790 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3791 and turn window cursor on if cleared (Bug#9415).
3793 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3795 * search.c (boyer_moore): Take unibyte characters from pattern
3796 literally. (Bug#9458)
3798 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3800 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3802 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3804 Fix minor problem found by static checking.
3805 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3806 initialized, to pacify gcc -Wuninitialized.
3808 * fileio.c: Report proper errno when syscall falls.
3809 (Finsert_file_contents): Save and restore errno,
3810 so that report_file_error outputs the correct diagnostic.
3811 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3813 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3815 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3817 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3819 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3820 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3822 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3824 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3825 about the current paragraph and restore it after the call to reseat.
3827 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3828 (bidi_find_paragraph_start): Search back for paragraph beginning
3829 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3830 (bidi_move_to_visually_next): Only trigger paragraph-related
3831 computations when the last character is a newline or at EOB, not
3832 just any NEUTRAL_B. (Bug#9470)
3834 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3835 truncated lines if point is covered by a display string. (Bug#9524)
3837 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3839 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3840 (cons_to_x_long): New function.
3841 (lisp_data_to_selection_data): Use it. Correct the test for
3842 short-versus-long data; it was negated. Break out of vector
3843 loop, for efficiency, when a long datum is discovered.
3845 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3847 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3849 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3851 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3852 GCC PR/17406) by declaring this function with external scope.
3854 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3856 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3857 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3859 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3861 * editfns.c (Fformat): Correctly handle text properties on "%%".
3863 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3865 * xterm.c (x_draw_composite_glyph_string_foreground):
3866 * w32term.c (x_draw_composite_glyph_string_foreground):
3867 * term.c (encode_terminal_code):
3868 * composite.c (composition_update_it, get_composition_id):
3869 * xdisp.c (get_next_display_element)
3870 (fill_composite_glyph_string): Add comments about special meaning
3871 of TAB characters in a composition.
3873 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3875 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3876 This occurs when processing a multibyte format.
3877 Problem reported by Wolfgang Jenker.
3879 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3881 * xdisp.c (try_cursor_movement): Only check for exact match if
3882 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3884 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3886 Remove unused external symbols.
3887 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3888 * xdisp.c (calc_pixel_width_or_height): Now static.
3889 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3890 * indent.c (check_display_width):
3891 * w32term.c: Fix comment to match code.
3892 * xterm.c, xterm.h (x_catching_errors): Remove.
3894 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3896 * xselect.c: Use signed conversions more consistently (Bug#9498).
3897 (selection_data_to_lisp_data): Assume incoming selection data are
3898 signed integers, not unsigned. This is to be consistent with
3899 outgoing selection data, which was modified to use signed integers
3900 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3901 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3902 expects long, not unsigned long.
3904 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3906 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3907 computation of loop end. Reported by Johan Bockgård
3910 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3912 * frame.c (Fother_visible_frames_p): Function deleted.
3914 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3916 * indent.c (compute_motion): Process display vector front to back
3917 rather than the other way around. (Bug#2496)
3919 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3921 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3923 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3925 * minibuf.c (Fread_from_minibuffer): Doc fix.
3927 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3929 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3930 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3932 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3934 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3935 value for non-existent files.
3937 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3939 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3940 set its "size" to -1. This will set the modtime_size field of
3941 the corresponding buffer to -1, which is what
3942 verify-visited-file-modtime expects for files that do not exist.
3945 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3947 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3949 * lisp.h: ... from here. push_key_description is no longer
3950 defined in keyboard.c, so its declaration should not be in
3951 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3952 logically belongs with push_key_description.
3954 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3956 * buffer.h: Include <sys/types.h> instead of <time.h>.
3957 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3958 Problem reported by Herbert J. Skuhra.
3960 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3962 * xml.c (parse_region): Make the parsing work for
3963 non-comment-starting XML files again (bug#9144).
3965 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3967 * image.c (gif_load): Fix calculation of bottom and right corner.
3970 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3972 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3973 redisplay in small windows.
3975 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3977 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3979 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3981 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3982 Operate on live windows only.
3984 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3986 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3988 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3990 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3991 only under bidi iteration.
3993 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3995 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3997 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3999 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4000 Without this fix, the command to link temacs failed due to an
4001 undefined symbol __builtin_isnan. This is because
4002 /usr/include/iso/math_c99.h #defines isnan(x) to
4003 __builtin_isnan(x), but the bundled gcc, which identifies itself
4004 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4006 * floatfns.c (isnan): #undef, and then #define to a clone of
4008 (Fisnan): Always define, since it's always available now.
4009 (syms_of_floatfns): Always define isnan at the Lisp level.
4011 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4013 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4015 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4017 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4018 The previous code assumed that file offsets (off_t values) fit in
4019 EMACS_INT variables, which is not true on typical 32-bit hosts.
4020 The code messed up by falsely reporting buffer overflow in cases
4021 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4022 when "big" contains more than 2**29 bytes, even though this
4023 inserts just one byte and does not overflow the buffer.
4024 (Finsert_file_contents): Store file offsets as off_t
4025 values, not as EMACS_INT values. Check for overflow when
4026 converting between EMACS_INT and off_t. When checking for
4027 buffer overflow or for overlap, take the offsets into account.
4028 Don't use EMACS_INT for small values where int suffices.
4029 When checking for overlap, fix a typo: ZV was used where
4030 ZV_BYTE was intended.
4031 (Fwrite_region): Don't assume off_t fits into 'long'.
4032 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4034 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4036 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4038 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4040 sprintf-related integer and memory overflow issues (Bug#9412).
4042 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4043 (esprintf, exprintf, evxprintf): New functions.
4044 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4045 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4046 (modify_event_symbol): Do not assume that the length of
4047 name_alist_or_stem is safe to alloca and fits in int.
4048 (Fexecute_extended_command): Likewise for function name and binding.
4049 (Frecursion_depth): Wrap around reliably on integer overflow.
4050 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4051 since some callers pass EMACS_INT values.
4052 (Fsingle_key_description): Don't crash if symbol name contains more
4053 than MAX_ALLOCA bytes.
4054 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4055 (get_minibuffer): Arg is now EMACS_INT, not int.
4056 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4057 (esprintf, exprintf, evxprintf): New decls.
4058 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4060 * dbusbind.c (signature_cat): New function.
4061 (xd_signature, Fdbus_register_signal):
4062 Do not overrun buffer; instead, report string overflow.
4064 * dispnew.c (add_window_display_history): Don't overrun buffer.
4065 Truncate instead; this is OK since it's just a log.
4067 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4068 even if the time zone offset is outlandishly large.
4069 Don't mishandle offset == INT_MIN.
4071 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4072 when creating daemon; the previous buffer-overflow check was incorrect.
4074 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4075 which has the guts of the old verror function.
4077 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4078 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4080 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4081 (font_unparse_xlfd): Don't blindly alloca long strings.
4082 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4083 fits in int, when using sprintf. Use single snprintf to count
4084 length of string rather than counting it via multiple sprintfs;
4085 that's simpler and more reliable.
4086 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4087 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4088 sprintf, in case result does not fit in int.
4090 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4091 (fontset_from_font): Print it.
4093 * frame.c (tty_frame_count): Now printmax_t, not int.
4094 (make_terminal_frame, set_term_frame_name): Print it.
4095 (x_report_frame_params): In X, window IDs are unsigned long,
4096 not signed long, so print them as unsigned.
4097 (validate_x_resource_name): Check for implausibly long names,
4098 and don't assume name length fits in 'int'.
4099 (x_get_resource_string): Don't blindly alloca invocation name;
4100 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4103 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4104 (xg_check_special_colors, xg_set_geometry):
4105 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4107 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4108 Use esprintf, not sprintf, in case result does not fit in int.
4110 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4111 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4112 it as a large positive number.
4113 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4114 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4116 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4117 in case result does not fit in int.
4119 * print.c (float_to_string): Detect width overflow more reliably.
4120 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4121 buffer overrun. Don't assume list length fits in 'int'. Treat
4122 print length of 0 as 0, not as infinity; to be consistent with other
4123 uses of print length in this function. Don't overflow print length
4124 index. Don't assume hash table size fits in 'long', or that
4125 vectorlike size fits in 'unsigned long'.
4127 * process.c (make_process): Use printmax_t, not int, to format
4128 process-name gensyms.
4130 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4132 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4133 to avoid potential buffer overrun.
4135 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4136 if X resource line is longer than 512 bytes.
4138 * xfns.c (x_window): Make sprintf buffer a bit bigger
4139 to avoid potential buffer overrun.
4141 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4143 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4145 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4147 Integer overflow fixes for scrolling, etc.
4148 Without these, Emacs silently mishandles large integers sometimes.
4149 For example, "C-u 4294967297 M-x recenter" was treated as if
4150 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4152 * xdisp.c (try_window_id): Check Emacs fixnum range before
4153 converting to 'int'.
4155 * window.c (window_scroll_line_based, Frecenter):
4156 Check that an Emacs fixnum is in range before assigning it to 'int'.
4157 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4158 values converted from Emacs fixnums.
4159 (Frecenter): Don't wrap around a line count if it is out of 'int'
4160 range; instead, treat it as an extreme value.
4161 (Fset_window_configuration, compare_window_configurations):
4162 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4164 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4165 that can exceed INT_MAX. Check that EMACS_INT value is in range
4166 before assigning it to the (possibly-narrower) index.
4167 (match_limit): Don't assume that a fixnum can fit in 'int'.
4169 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4172 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4173 (Fvertical_motion): Don't wrap around LINES values that don't fit
4174 in 'int'. Instead, treat them as extreme values. This is good
4175 enough for windows, which can't have more than INT_MAX lines anyway.
4177 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4179 * Require libxml/parser.h to avoid compilation warning.
4181 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4183 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4184 since this reportedly can destroy thread storage.
4186 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4188 * syntax.c (find_defun_start): Update all cache variables if
4189 exiting early (Bug#9401).
4191 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4193 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4195 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4196 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4197 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4199 * term.c (tty_append_glyph): New function.
4200 (produce_stretch_glyph): Static function and its prototype deleted.
4202 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4205 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4207 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4208 when checking :margin (Bug#9390).
4209 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4210 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4211 so that the name doesn't mislead. All uses changed.
4213 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4215 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4218 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4220 * xdisp.c (move_it_to): Don't bail out early when reaching
4221 position beyond to_charpos, if we are scanning backwards.
4222 (move_it_vertically_backward): When DY == 0, make sure we get to
4223 the first character in the line after the newline.
4225 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4227 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4228 (ccl_driver): Do not generate an out-of-range pointer.
4229 (Fccl_execute_on_string): Remove unnecessary check for
4230 integer overflow, noted by Stefan Monnier in
4231 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4232 Remove a FIXME that didn't need fixing.
4233 Simplify the newly-introduced buffer reallocation code.
4235 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4237 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4239 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4241 Integer and memory overflow issues (Bug#9196).
4243 * doc.c (get_doc_string): Rework so that
4244 get_doc_string_buffer_size is the actual buffer size, rather than
4245 being 1 less than the actual buffer size; this makes xpalloc more
4248 * image.c (x_allocate_bitmap_record, cache_image):
4249 * xselect.c (Fx_register_dnd_atom):
4250 Simplify previous changes by using xpalloc.
4252 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4253 since either will do and ptrdiff_t is convenient with xpalloc.
4255 * charset.c (charset_table_size)
4256 (struct charset_sort_data.priority): Now ptrdiff_t.
4257 (charset_compare): Don't overflow if priorities differ greatly.
4258 (Fsort_charsets): Don't assume list length fits in int.
4259 Check for size-calculation overflow when allocating sort data.
4260 (syms_of_charset): Allocate an initial charset table that is
4261 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4263 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4265 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4266 The actual value is always <= INT_MAX, and leaving it unsigned made
4267 overflow checking harder.
4269 * dispextern.h (struct glyph_matrix.rows_allocated)
4270 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4271 with xpalloc. The values are still always <= INT_MAX.
4273 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4275 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4276 (SAFE_NALLOCA): New macro.
4278 * region-cache.c (struct boundary.pos, find_cache_boundary)
4279 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4280 (set_cache_region, invalidate_region_cache)
4281 (revalidate_region_cache, know_region_cache, region_cache_forward)
4282 (region_cache_backward, pp_cache):
4283 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4284 so that ptrdiff_t * can be passed to xpalloc.
4285 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4286 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4287 (pp_cache): Don't assume cache_len fits in int.
4288 * region-cache.h: Adjust extern decls to match.
4290 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4291 EMACS_INT, since either will do, for xpalloc.
4293 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4294 (xnmalloc, xnrealloc, xpalloc): New functions.
4296 * bidi.c (bidi_shelve_header_size): New constant.
4297 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4298 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4300 * bidi.c (bidi_cache_shrink):
4301 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4303 Don't update size of array until after memory allocation succeeds,
4304 because xmalloc/xrealloc may not return.
4305 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4306 now that we have proper integer overflow checking.
4307 (record_overlay_string, overlay_strings): Catch overflows when
4308 calculating size of overlay_str_buf.
4310 * callproc.c (Fcall_process): Check for size overflow when
4311 calculating size of args2.
4312 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4313 Normally we prefer signed values, but sticking with ptrdiff_t would
4314 require adding more-complicated checks.
4316 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4317 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4318 Redo buffer-overflow calculations to avoid integer overflow.
4319 Add a FIXME comment where memory seems to be over-allocated.
4321 * character.c (Fstring): Check for size-calculation overflow.
4323 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4324 unnecessary integer overflow. Check for size overflow.
4325 (encode_coding_object): Don't update size until xmalloc succeeds.
4327 * composite.c (get_composition_id): Check for overflow in glyph
4328 length calculations.
4330 Integer and memory overflow fixes for display code.
4331 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4332 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4333 (scrolling_window): Check for overflow in size calculations.
4334 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4335 Don't assume glyph table len fits in int.
4336 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4337 (row_table_size): Now ptrdiff_t, not int.
4338 (scrolling_window): Avoid overflow in size calculations.
4339 Don't update size until allocation succeeds.
4340 * fns.c (concat): Check for overflow in size calculations.
4341 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4342 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4343 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4345 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4346 (get_doc_string): Check for size calculation overflow.
4347 Don't update size until allocation succeeds.
4348 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4349 EMACS_INT, where ptrdiff_t will do.
4350 (Fsubstitute_command_keys): Check for string overflow.
4352 * editfns.c (set_time_zone_rule): Don't assume environment length
4354 (message_length): Now ptrdiff_t, not int.
4355 (Fmessage_box): Don't update size until allocation succeeds.
4356 Don't assume message length fits in int.
4357 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4359 * emacs.c (main): Do not reallocate argv, since there is a null at
4360 the end that can be overwritten, and this way there's no need to
4361 worry about size-calculation overflow.
4362 (sort_args): Check for size-calculation overflow.
4364 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4366 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4368 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4369 (x_set_scroll_bar_width, x_figure_window_size):
4370 Check for integer overflow.
4371 (x_set_alpha): Do not assume XINT fits in int.
4373 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4374 This is for the members text_lines, text_cols, total_lines, total_cols,
4375 where the system imposes an 'int' limit.
4377 * fringe.c (Fdefine_fringe_bitmap):
4378 Don't update size until alloc works.
4380 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4381 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4383 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4384 Check for size-calculation overflow.
4385 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4386 do, as we prefer signed integers.
4387 (id_to_widget.max_size, id_to_widget.used)
4388 (xg_store_widget_in_map, xg_remove_widget_from_map)
4389 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4390 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4391 Use and return ptrdiff_t, not int.
4392 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4393 * gtkutil.h: Change prototypes to match the above.
4395 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4396 are duplicate now that they've been promoted to lisp.h.
4397 (x_allocate_bitmap_record, x_alloc_image_color)
4398 (make_image_cache, cache_image, xpm_load):
4399 Don't update size until alloc is done.
4400 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4402 Check for size calculation overflow.
4403 (ct_colors_allocated_max): New constant.
4404 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4407 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4408 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4409 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4410 Use ptrdiff_t, not int, to count maps.
4411 (read_char_minibuf_menu_prompt): Check for overflow in size
4412 calculations. Don't update size until allocation succeeds.
4413 Redo calculations to avoid overflow.
4414 * keyboard.h: Change prototypes to match the above.
4416 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4418 (current_minor_maps): Check for size calculation overflow.
4419 * keymap.h: Change prototypes to match the above.
4421 * lread.c (read1, init_obarray): Don't update size until alloc done.
4423 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4424 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4426 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4427 Now ptrdiff_t, not int.
4428 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4429 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4431 * process.c (Fnetwork_interface_list): Check for overflow
4432 in size calculation.
4434 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4436 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4437 overflow. Don't bother calling xmalloc when xrealloc will do.
4439 * search.c (Freplace_match): Check for size calculation overflow.
4440 (Fset_match_data): Don't assume list lengths fit in 'int'.
4442 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4443 for command line length. Do not attempt to address one before the
4444 beginning of an array, as that's not portable.
4446 * term.c (max_frame_lines): Remove; unused.
4447 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4449 (encode_terminal_code, calculate_costs): Check for size
4450 calculation overflow.
4451 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4452 table lengths and related sizes. Don't update size until alloc
4453 done. Redo calculations to avoid overflow.
4454 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4456 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4457 subtracting pointers.
4458 (gobble_line): Check for overflow more carefully. Don't update size
4461 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4462 Don't update size until alloc done.
4463 Redo size calculations to avoid overflow.
4464 Check for size calculation overflow.
4465 (main) [DEBUG]: Fix typo in invoking tparam1.
4467 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4468 Use ptrdiff_t, not int, for sizes.
4469 (store_mode_line_noprop_char): Don't update size until alloc done.
4471 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4472 Use ptrdiff_t, not int, for sizes.
4473 (Finternal_make_lisp_face, cache_face):
4474 Check for size calculation overflow.
4475 (cache_face): Treat size calculation overflows as if they were
4476 memory exhaustion (the usual treatment), rather than aborting.
4478 * xfns.c (x_encode_text, x_set_name_internal)
4479 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4480 sizes, since they can exceed INT_MAX in size. Check for size
4481 calculation overflow.
4483 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4484 (xg_select): Check for size calculation overflow.
4485 Don't update size until alloc done.
4487 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4488 as sprintf is limited to int lengths.
4490 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4491 (X_LONG_MIN): New macros.
4492 Use them to make the following changes clearer.
4493 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4494 This change doesn't affect the value now, but it may help remind
4495 future maintainers not to raise the value too much later.
4496 (SELECTION_QUANTUM): Remove, replacing with ...
4497 (selection_quantum): ... new function, which avoids overflow.
4499 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4500 assumption that selection length fits in 'int'.
4501 (x_reply_selection_request, x_handle_selection_request)
4502 (x_get_window_property, receive_incremental_selection)
4503 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4504 (lisp_data_to_selection_data, clean_local_selection_data):
4505 Use ptrdiff_t, not int, to record length of selection.
4506 (x_reply_selection_request, x_get_window_property)
4507 (receive_incremental_selection, x_property_data_to_lisp):
4508 Redo calculations to avoid overflow.
4509 (x_reply_selection_request): When sending hint, ceiling it at
4510 X_LONG_MAX rather than relying on wraparound overflow to send
4512 (x_get_window_property, receive_incremental_selection)
4513 (lisp_data_to_selection_data, x_property_data_to_lisp):
4514 Check for size-calculation overflow.
4515 (x_get_window_property, receive_incremental_selection)
4516 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4517 Don't store size until memory allocation succeeds.
4518 (x_get_window_property): Plug memory leak on memory exhaustion.
4519 Don't double-block input; malloc is safe here. Don't assume 2**34
4520 - 4 fits in unsigned long. Add an xassert to check
4521 XGetWindowProperty overflow. Be more careful about overflow
4522 calculations, and distinguish size from memory overflow better.
4523 (receive_incremental_selection): When tracing, don't assume
4524 unsigned int is less than INT_MAX.
4525 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4526 harmful) conversions of unsigned short to int.
4527 (lisp_data_to_selection_data): Don't assume that integers
4528 in the range -65535 through -1 fit in an X unsigned short.
4529 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4530 result parameters unless successful. Rely on cons_to_unsigned
4531 to report problems with elements; the old code wasn't right anyway.
4532 (x_check_property_data): Check for int overflow; we cannot use
4533 a wider type due to X limits.
4534 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4536 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4538 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4539 (x_term_init): Check for size calculation overflow.
4540 (x_color_cells): Don't store size until memory allocation succeeds.
4541 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4542 Don't assume alloca size is less than MAX_ALLOCA.
4543 (x_term_init): Don't assume length fits in int (sprintf is limited
4546 Use ptrdiff_t for composition IDs.
4547 * character.c (lisp_string_width):
4548 * composite.c (composition_table_size, n_compositions)
4549 (get_composition_id, composition_gstring_from_id):
4550 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4551 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4552 * window.c (Frecenter):
4553 Use ptrdiff_t, not int, for composition IDs.
4554 * composite.c (get_composition_id): Check for integer overflow.
4555 * composite.h: Adjust prototypes to match the above changes.
4557 Use ptrdiff_t for hash table indexes.
4558 * category.c (hash_get_category_set):
4559 * ccl.c (ccl_driver):
4560 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4561 * coding.c (coding_system_charset_list, detect_coding_system):
4562 * coding.h (struct coding_system.id):
4563 * composite.c (get_composition_id, gstring_lookup_cache):
4564 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4565 * image.c (xpm_get_color_table_h):
4566 * lisp.h (hash_lookup, hash_put):
4567 * minibuf.c (Ftest_completion):
4568 Use ptrdiff_t for hash table indexes, not int (which is too
4569 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4570 32-bit --with-wide-int hosts).
4572 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4573 Add a FIXME comment about memory leaks.
4574 (syms_of_charset): Don't assume xmalloc returns.
4576 Don't assume that stated character widths fit in int.
4577 * character.c (Fchar_width, c_string_width, lisp_string_width):
4578 * character.h (CHAR_WIDTH):
4579 * indent.c (MULTIBYTE_BYTES_WIDTH):
4580 Use sanitize_char_width to avoid undefined and/or bad behavior
4581 with outlandish widths.
4582 * character.h (sanitize_tab_width): Rename from sanitize_width,
4583 now that we have two such functions. All uses changed.
4584 (sanitize_char_width): New inline function.
4586 Don't assume that tab-width fits in int.
4587 * character.h (sanitize_width): New inline function.
4588 (SANE_TAB_WIDTH): New macro.
4589 (ASCII_CHAR_WIDTH): Use it.
4590 * indent.c (sane_tab_width): Remove. All uses replaced by
4591 SANE_TAB_WIDTH (current_buffer).
4592 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4594 * fileio.c: Integer overflow issues with file modes.
4595 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4597 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4598 Remove unreachable code.
4599 (read_hex, load_charset_map_from_file): Check for integer overflow.
4601 * xterm.c: Don't go over XClientMessageEvent limit.
4602 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4603 (x_send_scroll_bar_event): Likewise. Check that the size does not
4604 exceed limits imposed by XClientMessageEvent, as well as the usual
4605 ptrdiff_t and size_t limits.
4607 * keyboard.c: Overflow, signedness and related fixes.
4608 (make_lispy_movement): Use same integer type in forward decl
4609 that is used in the definition.
4610 (read_key_sequence, keyremap_step):
4611 Change bufsize argument back to int, undoing my 2011-03-30 change.
4612 We prefer signed types, and int is wide enough here.
4613 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4614 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4615 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4616 length, not size_t. Use ptrdiff_t for index, not int.
4617 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4618 possibility of integer overflow.
4620 Overflow, signedness and related fixes for images.
4622 * dispextern.h (struct it.stack[0].u.image.image_id)
4623 (struct_it.image_id, struct image.id, struct image_cache.size)
4624 (struct image_cache.used, struct image_cache.ref_count):
4625 * gtkutil.c (update_frame_tool_bar):
4626 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4627 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4628 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4629 * nsmenu.m (update_frame_tool_bar):
4630 * xdisp.c (calc_pixel_width_or_height):
4631 * xfns.c (image_cache_refcount):
4632 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4633 on typical 64-bit hosts.
4635 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4636 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4637 Omit unnecessary casts to int.
4638 (parse_image_spec): Check that integers fall into 'int' range
4639 when the callers expect that.
4640 (image_ascent): Redo ascent calculation to avoid int overflow.
4641 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4642 (lookup_image): Remove unnecessary tests.
4643 (xbm_image_p): Locals are now of int, not EMACS_INT,
4644 since parse_image_check makes sure they fit into int.
4645 (png_load, gif_load, svg_load_image):
4646 Prefer int to unsigned where either will do.
4647 (tiff_handler): New function, combining the cores of the
4648 old tiff_error_handler and tiff_warning_handler.
4649 This function is rewritten to use vsnprintf and thereby avoid
4650 stack buffer overflows. It uses only the features of vsnprintf
4651 that are common to both POSIX and native Microsoft.
4652 (tiff_error_handler, tiff_warning_handler): Use it.
4653 (tiff_load, gif_load, imagemagick_load_image):
4654 Don't assume :index value fits in 'int'.
4655 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4656 (imagemagick_load_image): Check that crop parameters fit into
4657 the integer types that MagickCropImage accepts. Don't assume
4658 Vimagemagick_render_type has a nonnegative value. Don't assume
4659 size_t fits in 'long'.
4660 (gs_load): Use printmax_t to print the widest integers possible.
4661 Check for integer overflow when computing image height and width.
4663 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4665 * xdisp.c (redisplay_window): Don't force window start if point
4666 will be invisible in the resulting window. (Bug#9324)
4668 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4670 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4671 the display spec is of the form `(space ...)'.
4672 (handle_display_spec): Return the value returned by
4673 handle_single_display_spec, not just 1 or zero.
4674 (handle_single_display_spec): If the display spec is of the form
4675 `(space ...)', and specifies display in the text area, return 2
4677 (try_cursor_movement): Check for the need to scroll more
4678 accurately, and prefer exact match for point under bidi.
4679 Don't advance `row' beyond the last row of the window.
4681 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4682 into disp_prop; all users changed.
4684 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4685 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4686 for the text covered by the display property.
4688 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4690 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4691 Change return value to nil.
4692 (Frecord_buffer): Delete unused function.
4694 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4696 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4697 buffers, return left-to-right.
4698 (set_cursor_from_row): Consider candidate row a win if its glyph
4699 represents a newline and point is on that newline. Fixes cursor
4700 positioning on the newline at EOL of R2L text within L2R
4701 paragraph, and vice versa.
4702 (try_cursor_movement): Check continued rows, in addition to
4703 continuation rows. Fixes unwarranted scroll when point enters a
4704 continued line of R2L text within an L2R paragraph, or vice versa.
4705 (cursor_row_p): Consider the case of point being equal to
4706 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4707 from the end of a short line to the beginning of a continued line
4708 of R2L text within L2R paragraph.
4709 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4710 composed characters.
4712 * bidi.c (bidi_check_type): Use xassert.
4713 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4716 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4718 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4721 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4723 * nsfont.m (ns_otf_to_script): Fix typo.
4725 2011-08-22 Kenichi Handa <handa@m17n.org>
4727 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4728 extra slot even if the purpose is char-code-property-table.
4730 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4732 * xdisp.c (redisplay_window): When computing centering_position,
4733 account for the height of the header line. (Bug#8874)
4735 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4736 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4737 candidate is selected by the mouse, and that candidate has a
4738 composed character under the mouse.
4740 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4741 coordinates reported by pos-visible-in-window-p for a composed
4742 character in column zero.
4744 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4746 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4748 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4750 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4751 consider it a hit if to_charpos is anywhere in the range of the
4752 composed buffer positions.
4754 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4756 * image.c (gif_load): Don't assume that each subimage has the same
4757 dimensions as the base image. Handle disposal method that is
4758 "undefined" by the gif spec (Bug#9335).
4760 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4762 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4763 (Fcondition_case): Document `debug' symbol in error handler.
4765 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4767 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4768 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4769 from an Org mode buffer to a Speedbar frame.
4771 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4772 a composition, take its buffer position from IT->cmp_it.charpos.
4773 Fixes cursor positioning at the beginning of a line that begins
4774 with a composed character.
4776 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4778 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4779 character bidirectional type, use STRONG_L instead. Fixes crashes
4780 in a buffer produced by `describe-categories'.
4782 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4783 members before the level stack, so they would be saved and
4784 restored when copying iterator state. Fixes incorrect reordering
4785 around TABs covered by display properties.
4787 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4789 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4791 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4793 * eval.c (internal_condition_case, internal_condition_case_1)
4794 (internal_condition_case_2, internal_condition_case_n):
4795 Remove unnecessary aborts (Bug#9081).
4797 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4799 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4800 has no `load' handler, try opening the file locally. (Bug#9311)
4802 2011-08-16 Ken Brown <kbrown@cornell.edu>
4804 * gmalloc.c: Expand comment.
4806 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4808 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4809 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4811 2011-08-16 Ken Brown <kbrown@cornell.edu>
4813 Fix memory allocation problems in Cygwin build (Bug#9273).
4815 * unexcw.c ( __malloc_initialized): Declare external variable.
4816 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4818 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4820 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4822 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4824 [CYGWIN] (special_realloc): New function.
4825 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4826 requests to realloc storage in the static heap.
4828 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4830 * bidi.c (bidi_initialize): Remove unused local.
4832 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4835 * biditype.h: Remove file.
4836 * makefile.w32-in ($(BLD)/bidi.$(O)):
4837 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4839 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4841 * chartab.c: Improve commentary for the uniprop_table API.
4843 * bidi.c (bidi_paragraph_init): Support zero value of
4844 bidi_ignore_explicit_marks_for_paragraph_level.
4845 (bidi_initialize): Use uniprop_table instead of including
4846 biditype.h and bidimirror.h.
4848 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4849 coordinates of the iterator when restoring from ppos_it.
4852 2011-08-14 Kenichi Handa <handa@m17n.org>
4854 * process.c (create_process): Call setup_process_coding_systems
4855 after the pid of the process is set to -1 (Bug#8162).
4857 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4859 * xdisp.c (move_it_in_display_line_to): Don't invoke
4860 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4861 ppos_it. Fixes vertical cursor motion when line beginning is
4862 covered by an image. (Bug#9296)
4864 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4866 * nsterm.h (ns_run_ascript): Declare.
4867 (NSAPP_DATA2_RUNASSCRIPT): Define.
4869 * nsfns.m (as_script, as_result, as_status): New static variables.
4870 (ns_run_ascript): New function.
4871 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4872 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4873 the event loop. Get status from as_status (Bug#7276).
4875 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4876 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4877 the event loop (Bug#7276).
4879 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4881 * gnutls.c (QCgnutls_bootprop_priority)
4882 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4883 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4884 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4885 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4886 (QCgnutls_bootprop_verify_hostname_error)
4887 (QCgnutls_bootprop_callbacks_verify): Rename from
4888 Qgnutls_bootprop_..., all uses changed.
4890 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4893 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4895 * xfaces.c (Qframe_set_background_mode): Now static.
4896 * dispextern.h (Qframe_set_background_mode): Remove decl.
4898 * process.c (Fnetwork_interface_info): Declare local only if needed.
4900 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4902 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4903 (Fnetwork_interface_list): Allocate in increments of bytes instead
4904 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4905 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4907 (struct ifflag_def): notrailers is smart on OSX.
4908 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4909 Get hardware address with getifaddrs if available.
4911 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4913 * xdisp.c (iterate_out_of_display_property): xassert that
4914 IT->position is set to within IT->object's boundaries. Break from
4915 the loop as soon as EOB is reached; avoids infloops in redisplay
4916 when IT->position is set up wrongly due to some bug.
4917 Set IT->current to match the bidi iterator unconditionally.
4918 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4919 entry. Force push_it to save on the stack the current
4920 buffer/string position, to be restored by pop_it. Fix flags in
4921 the iterator structure wrt the object coming from a display
4922 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4923 properties. (Bug#9284)
4925 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4927 * fontset.c (fontset_get_font_group): Add proper type checks.
4930 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4932 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4933 and LC_VERSION_MIN_MACOSX.
4934 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4935 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4937 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4939 * xdisp.c (forward_to_next_line_start): Allow to use the
4940 no-display-properties-and-no-overlays under bidi display.
4941 Set disp_pos in the bidi iterator to avoid searches for display
4942 properties and overlays.
4944 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4946 * editfns.c (Fset_time_zone_rule): Document relationship with the
4949 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4950 the font entity extracted from the cache (Bug#8109).
4952 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4954 * composite.c (autocmp_chars): Don't reset point. That is done by
4955 restore_point_unwind (Bug#5984).
4957 2011-08-07 Juri Linkov <juri@jurta.org>
4959 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4960 to show the arg `TIME' instead of `TIMEVAL'.
4962 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4964 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4965 display property strides EOL and includes a newline, as in
4966 longlines-mode. (Bug#9254)
4967 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4968 word-wrap under bidirectional display. (Bug#9224)
4970 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4971 is non-zero, even if the data buffer is NULL. Fixes a crash in
4972 vertical-motion with longlines-mode. (Bug#9254)
4974 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4976 * bidi.c <bidi_cache_total_alloc>: Now static.
4977 (bidi_initialize): Initialize bidi_cache_total_alloc.
4979 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4982 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4983 amount allocated this far in `bidi_cache_total_alloc'.
4984 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4985 non-zero, only free the data buffer without restoring the cache
4986 contents. All callers changed.
4988 * dispextern.h (bidi_unshelve_cache): Update prototype.
4990 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4991 (move_it_in_display_line, move_it_to)
4992 (move_it_vertically_backward, move_it_by_lines): Replace the call
4993 to xfree to an equivalent call to bidi_unshelve_cache.
4994 (move_it_in_display_line_to): Fix logic of returning
4995 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4997 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4999 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5000 came from a string character with a `cursor' property. (Bug#9229)
5002 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5004 * Makefile.in (LIB_PTHREAD): New variable.
5005 (LIBES): Add LIB_PTHREAD (Bug#9216).
5007 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5008 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5010 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5012 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5014 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5016 * xterm.c (x_find_topmost_parent): New function.
5017 (x_set_frame_alpha): Find topmost parent window with
5018 x_find_topmost_parent and set the property there also (bug#9181).
5019 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5021 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5023 * callproc.c (Fcall_process): Avoid vfork clobbering
5024 the local vars buffer, coding_systems, current_dir.
5026 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5028 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5030 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5032 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5033 so that it is not optimized away.
5035 * xdisp.c (compute_display_string_pos): Remove unused local.
5037 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5039 Fix slow cursor motion and scrolling in large buffers with
5040 selective display, like Org Mode buffers. (Bug#9218)
5042 * dispextern.h (struct bidi_it): New member disp_prop_p.
5044 * xdisp.c: Remove one-slot cache of display string positions.
5045 (compute_display_string_pos): Accept an additional argument
5046 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5047 for a display string or property. If found, set DISP_PROP_P
5050 * bidi.c (bidi_fetch_char): Accept an additional argument
5051 DISP_PROP_P, and pass it to compute_display_string_pos.
5052 Only handle text covered by a display string if DISP_PROP_P is returned
5053 non-zero. All callers of bidi_fetch_char changed.
5055 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5057 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5059 2010-12-03 Don March <don@ohspite.net>
5061 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5062 last character M-[char] is translated to ESC [char] (bug#7541).
5064 2011-08-02 Kenichi Handa <handa@m17n.org>
5066 * lisp.h (uniprop_table): Extern it.
5068 * chartab.c (uniprop_table): Make it non-static.
5070 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5072 * xdisp.c (forward_to_next_line_start): Accept additional argument
5073 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5075 (reseat_at_next_visible_line_start): Use the bidi iterator state
5076 returned by forward_to_next_line_start to restore the state of
5077 it->bidi_it after backing up to previous newline. (Bug#9212)
5079 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5081 * regex.c (re_comp): Protoize.
5082 (re_exec): Fix return type.
5083 (regexec): Fix type of `ret'. (Bug#9203)
5085 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5087 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5088 This is needed if max-image-size is a floating-point number.
5090 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5092 * print.c (print_object): Print empty symbol as ##.
5094 * lread.c (read1): Read ## as empty symbol.
5096 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5098 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5099 setting frame foreground color (Bug#9175).
5100 (x_set_background_color): Likewise.
5102 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5103 contents (Bug#9176).
5104 (EmacsTooltip -init): Remove bezels and add shadows to
5107 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5108 or scroll bar (Bug#8470).
5110 * nsfont.m (nsfont_open): Remove assignment to voffset and
5111 unnecessary vars hshink, expand, hd, full_height, min_height.
5112 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5114 * nsterm.h (nsfont_info): Remove voffset field.
5116 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5118 Implement strike-through and overline on NextStep (Bug#8863).
5120 * nsfont.m (nsfont_open): Use underline position provided by font,
5121 instead of hard-coded value of 2.
5122 (nsfont_draw): Call ns_draw_text_decoration instead.
5124 * nsterm.h: Add declaration for ns_draw_text_decoration.
5126 * nsterm.m (ns_draw_text_decoration): New function for drawing
5127 underline, overline, and strike-through.
5128 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5129 ns_draw_text_decoration. Change treatment of cursor drawing to
5130 accommodate underlining, etc.
5132 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5134 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5137 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5139 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5140 Without this fix, if a signal arrives just after memory fills up,
5141 'malloc' might be invoked reentrantly.
5143 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5144 In other words, assume that every image size is allowed, on non-X
5145 hosts. This assumption is probably wrong, but it lets Emacs compile.
5147 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5149 * regex.c (re_iswctype): Convert return values to boolean.
5151 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5153 * xdisp.c (compute_display_string_pos): Don't use cached display
5154 string position if the buffer had its restriction changed.
5157 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5159 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5161 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5163 Integer signedness and overflow and related fixes. (Bug#9079)
5165 * bidi.c: Integer size and overflow fixes.
5166 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5167 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5168 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5169 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5170 (bidi_find_other_level_edge):
5171 Use ptrdiff_t instead of EMACS_INT where either will do.
5172 This works better on 32-bit hosts configured --with-wide-int.
5173 (bidi_cache_ensure_space): Check for size-calculation overflow.
5174 Use % rather than repeated addition, for better worst-case speed.
5175 Don't set bidi_cache_size until after xrealloc returns, because it
5177 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5178 (bidi_cache_ensure_space): Also check that the bidi cache size
5179 does not exceed that of the largest Lisp string or buffer. See Eli
5180 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5182 * alloc.c (__malloc_size_t): Remove.
5183 All uses replaced by size_t. See Andreas Schwab's note
5184 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5186 * image.c: Improve checking for integer overflow.
5187 (check_image_size): Assume that f is nonnull, since
5188 it is always nonnull in practice. This is one less thing to
5189 worry about when checking for integer overflow later.
5190 (x_check_image_size): New function, which checks for integer
5191 overflow issues inside X.
5192 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5193 This removes the need for a memory_full check.
5194 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5195 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5196 (xbm_read_bitmap_data): Change locals back to 'int', since
5197 their values must fit in 'int'.
5198 (xpm_load_image, png_load, tiff_load):
5199 Invoke x_create_x_image_and_pixmap earlier,
5200 to avoid much needless work if the image is too large.
5201 (tiff_load): Treat overly large images as if
5202 x_create_x_image_and_pixmap failed, not as malloc failures.
5203 (gs_load): Use x_check_image_size.
5205 * gtkutil.c: Omit integer casts.
5206 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5207 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5209 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5211 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5212 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5213 would wrongly return t on a 64-bit host.
5215 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5216 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5217 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5218 and therefore cause GCC to emit a bogus diagnostic in some cases.
5220 * image.c: Integer signedness and overflow and related fixes.
5221 This is not an exhaustive set of fixes, but it's time to
5222 record what I've got.
5223 (lookup_pixel_color, check_image_size): Remove redundant decls.
5224 (check_image_size): Don't assume that arbitrary EMACS_INT values
5225 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5226 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5227 (tiff_load, imagemagick_load_image):
5228 Check for overflow in size calculations.
5229 (x_create_x_image_and_pixmap): Remove unnecessary test for
5230 xmalloc returning NULL; that can't happen.
5231 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5232 (xpm_color_bucket): Use better integer hashing function.
5233 (xpm_cache_color): Don't possibly over-allocate memory.
5234 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5235 (gif_memory_source):
5236 Use ptrdiff_t, not int or size_t, to record sizes.
5237 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5238 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5239 either works, as we prefer signed integers.
5240 (tiff_read_from_memory, tiff_write_from_memory):
5241 Return tsize_t, not size_t, since that's what the TIFF API wants.
5242 (tiff_read_from_memory): Don't fail simply because the read would
5243 go past EOF; instead, return a short read.
5244 (tiff_load): Omit no-longer-needed casts.
5245 (Fimagemagick_types): Don't assume size fits into 'int'.
5247 Improve hashing quality when configured --with-wide-int.
5248 * fns.c (hash_string): New function, taken from sxhash_string.
5249 Do not discard information about ASCII character case; this
5250 discarding is no longer needed.
5251 (sxhash-string): Use it. Change sig to match it. Caller changed.
5252 * lisp.h: Declare it.
5253 * lread.c (hash_string): Remove, since we now use fns.c's version.
5254 The fns.c version returns a wider integer if --with-wide-int is
5255 specified, so this should help the quality of the hashing a bit.
5257 * emacs.c: Integer overflow minor fix.
5258 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5259 Define only if GNU_LINUX.
5260 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5262 * dispnew.c: Integer signedness and overflow fixes.
5263 Remove unnecessary forward decls, that were a maintenance hassle.
5264 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5266 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5267 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5268 (prepare_desired_row, line_draw_cost):
5269 Use int, not unsigned, where either works.
5270 (save_current_matrix, restore_current_matrix):
5271 Use ptrdiff_t, not size_t, where either works.
5272 (init_display): Check for overflow more accurately, and without
5273 relying on undefined behavior.
5275 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5276 Remove, replacing with the new symbols in lisp.h. All uses changed.
5277 * fileio.c (make_temp_name):
5278 * filelock.c (lock_file_1, lock_file):
5279 * xdisp.c (message_dolog):
5280 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5281 Use pMd etc. instead.
5282 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5283 replacing the pWIDE etc. symbols removed from editfns.c.
5285 * keyboard.h (num_input_events): Now uintmax_t.
5286 This is (very slightly) less likely to mess up due to wraparound.
5289 * buffer.c: Integer signedness fixes.
5290 (alloc_buffer_text, enlarge_buffer_text):
5291 Use ptrdiff_t rather than size_t when either will do, as we prefer
5294 * alloc.c: Integer signedness and overflow fixes.
5295 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5296 (__malloc_size_t): Default to size_t, not to int.
5297 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5298 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5299 Prefer ptrdiff_t to size_t when either would do, as we prefer
5301 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5302 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5303 Now const. Initialize with values that are in range even if char
5305 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5306 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5307 These functions do the right thing with sizes > 2**32.
5308 (check_depth): Now ptrdiff_t, not int.
5309 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5310 Adjust to new way of storing sizes. Check for size overflow bugs
5312 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5313 slightly wrong anyway, as it missed one instance of
5314 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5315 (refill_memory_reserve): Omit needless cast to size_t.
5316 (mark_object_loop_halt): Mark as externally visible.
5318 * xselect.c: Integer signedness and overflow fixes.
5319 (Fx_register_dnd_atom, x_handle_dnd_message):
5320 Use ptrdiff_t, not size_t, since we prefer signed.
5321 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5322 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5323 x_dnd_atoms_size and x_dnd_atoms_length.
5325 * doprnt.c: Prefer signed to unsigned when either works.
5327 * doprnt.c (doprnt):
5329 * xdisp.c (vmessage):
5330 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5331 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5332 prefer signed arithmetic to avoid comparison confusion.
5333 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5334 but is a bit tricky.
5336 Assume freestanding C89 headers, string.h, stdlib.h.
5337 * data.c, doprnt.c, floatfns.c, print.c:
5338 Include float.h unconditionally.
5339 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5340 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5341 * regex.c: Likewise for stddef.h, string.h.
5342 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5343 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5344 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5345 (STDC_HEADERS): Remove obsolete defines.
5346 * sysdep.c: Include limits.h unconditionally.
5348 Assume support for memcmp, memcpy, memmove, memset.
5349 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5350 * regex.c (memcmp, memcpy):
5351 Remove; we assume C89 now.
5353 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5354 (__malloc_safe_bcopy): Remove; no longer needed.
5356 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5357 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5358 well either way, and we prefer signed to unsigned.
5360 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5362 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5363 closes the connection while we're reading (bug#9182).
5365 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5367 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5368 are specified (Bug#9168).
5370 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5372 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5373 Found by GCC static checking and --with-wide-int on a 32-bit host.
5375 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5377 * xdisp.c (compute_display_string_pos): Fix logic of caching
5378 previous display string position. Initialize cached_prev_pos to
5379 -1. Fixes slow-down at the beginning of a buffer.
5381 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5383 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5384 for attrs[LFACE_FONTSET_INDEX].
5386 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5388 * xml.c (parse_region): Remove unused local
5389 that was recently introduced.
5391 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5393 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5394 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5396 * xdisp.c (move_it_in_display_line_to): Record the best matching
5397 position for TO_CHARPOS while scanning the line, and restore it on
5398 exit if none of the characters scanned was an exact match.
5399 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5400 when exact match is impossible due to invisible text, and the
5401 lines are truncated.
5403 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5405 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5408 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5410 Fix a significant slow-down of cursor motion with C-n, C-p,
5411 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5412 auto-repeat under bidi redisplay in fontified buffers.
5413 * xdisp.c (compute_stop_pos_backwards): New function.
5414 (next_element_from_buffer): Call compute_stop_pos_backwards to
5415 find a suitable prev_stop when we find ourselves before
5417 (reseat): Don't look for prev_stop, as that could mean a very long
5419 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5420 <cached_disp_overlay_modiff>: Cache for last found display string
5422 (compute_display_string_pos): Return the cached position if asked
5423 about the same buffer in the same area of character positions, and
5424 the buffer wasn't changed since the time the display string
5425 position was cached.
5427 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5429 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5430 is an integer, which is important for empty lines. (Bug#9149)
5432 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5434 * frame.c (Fmodify_frame_parameters): In tty case, update the
5435 default face if necessary (Bug#4238).
5437 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5439 * editfns.c (Fstring_to_char): No need to explain what a character
5440 is in the docstring (Bug#6576).
5442 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5444 * xml.c (parse_region): Make sure we always return a tree.
5446 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5448 * xml.c (parse_region): If a document contains only comments,
5451 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5453 * xml.c (make_dom): Return comments, too.
5455 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5458 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5459 and the surrounding thread.
5460 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5461 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5462 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5464 * s/openbsd.h (BROKEN_SIGIO): Define.
5465 * unexelf.c (unexec) [__OpenBSD__]:
5466 Don't update the .mdebug section of the Alpha COFF symbol table.
5468 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5470 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5473 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5475 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5476 This fixes some race conditions on the permissions of any newly
5479 * alloc.c (valid_pointer_p): Use pipe, not open.
5480 This fixes some permissions issues when debugging.
5482 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5483 If fchown fails to set both uid and gid, try to set just gid,
5484 as that is sometimes allowed. Adjust the file's mode to eliminate
5485 setuid or setgid bits that are inappropriate if fchown fails.
5487 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5489 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5490 to compare Lisp_Objects.
5491 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5492 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5493 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5495 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5497 * lread.c (read_integer): Unread even EOF character.
5498 (read1): Likewise. Properly record start position of symbol.
5500 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5501 symbol character follows.
5503 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5505 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5506 This works around a problem with the previous change to Fcopy_file.
5507 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5508 and without this change, GCC might complain about discarding
5509 fchown's return value.
5511 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5513 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5515 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5517 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5519 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5521 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5522 it's used from the C level.
5524 * process.c: Use the same condition for POLL_FOR_INPUT in both
5525 keyboard.c and process.c (bug#1858).
5527 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5529 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5530 (Fgnutls_boot): Use it.
5532 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5534 * doc.c (Fsubstitute_command_keys): Revert last change.
5536 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5538 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5539 quotes the next character, and doesn't affect other longer
5540 sequences (bug#8935).
5542 * lread.c (syms_of_lread): Clarify that is isn't only
5543 `eval-buffer' and `eval-defun' that's affected by
5544 `lexical-binding' (bug#8460).
5546 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5548 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5549 bidi redisplay when a line includes both an image and is truncated.
5551 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5553 Fix minor problems found by static checking.
5554 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5555 (elsz): Now a signed constant, not a size_t var. We prefer signed
5556 types to unsigned, to avoid integer comparison confusion. Without
5557 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5558 "cannot optimize loop, the loop counter may overflow", a symptom
5560 * indent.c (Fvertical_motion): Mark locals as initialized.
5561 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5563 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5565 * search.c (Fre_search_backward): Mention `case-fold-search' in
5566 all the re_search_* functions (bug#8138).
5568 * keyboard.c (Fopen_dribble_file): Document when the file is
5571 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5573 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5576 Support bidi reordering of display and overlay strings.
5577 * xdisp.c (compute_display_string_pos)
5578 (compute_display_string_end): Accept additional argument STRING.
5579 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5580 (reseat_to_string): Initialize bidi_it->string.s and
5581 bidi_it->string.schars.
5582 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5583 NULL (avoids a crash in bidi_paragraph_init).
5584 Initialize itb.string.lstring.
5585 (init_iterator): Call bidi_init_it only of a valid
5586 buffer position was specified. Initialize paragraph_embedding to
5588 (reseat_to_string): Initialize the bidi iterator.
5589 (display_string): If we need to ignore text properties of
5590 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5591 original value of -1 will not work with bidi.)
5592 (compute_display_string_pos): First arg is now struct
5593 `text_pos *'; all callers changed. Support display properties on
5595 (compute_display_string_end): Support display properties on Lisp
5597 (init_iterator, reseat_1, reseat_to_string): Initialize the
5598 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5599 when iterating on a string not from display properties).
5600 (compute_display_string_pos, compute_display_string_end):
5601 Fix calculation of the object to scan. Fixes an error when using
5603 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5604 base_level_stop; instead, set base_level_stop to BEGV.
5605 Fixes crashes in vertical-motion.
5606 (next_element_from_buffer): Improve commentary for when
5607 the iterator is before prev_stop.
5608 (init_iterator): Initialize bidi_p from the default value of
5609 bidi-display-reordering, not from buffer-local value. Use the
5610 buffer-local value only if initializing for buffer iteration.
5611 (handle_invisible_prop): Support invisible properties on strings
5612 that are being bidi-reordered.
5613 (set_iterator_to_next): Support bidi reordering of C strings and
5615 (next_element_from_string): Support bidi reordering of Lisp
5617 (handle_stop_backwards): Support Lisp strings as well.
5618 (display_string): Support display of R2L glyph rows.
5619 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5620 (init_iterator): Don't initialize it->bidi_p for strings
5622 (reseat_to_string): Initialize it->bidi_p for strings here.
5623 (next_element_from_string, next_element_from_c_string)
5624 (next_element_from_buffer): Add xassert's for correspondence
5625 between IT's object being iterated and it->bidi_it.string
5627 (face_before_or_after_it_pos): Support bidi iteration.
5628 (next_element_from_c_string): Handle the case of the first string
5629 character that is not the first one in the visual order.
5630 (get_visually_first_element): New function, refactored from common
5631 parts of next_element_from_buffer, next_element_from_string, and
5632 next_element_from_c_string.
5633 (tool_bar_lines_needed, redisplay_tool_bar)
5634 (display_menu_bar): Force left-to-right direction. Add a FIXME
5635 comment for making that be controlled by a user option.
5636 (push_it, pop_it): Save and restore the state of the
5637 bidi iterator. Save and restore the bidi_p flag.
5638 (pop_it): Iterate out of display property for string iteration as
5640 (iterate_out_of_display_property): Support iteration over strings.
5641 (handle_single_display_spec): Set up it->bidi_it for iteration
5642 over a display string, and call bidi_init_it.
5643 (handle_single_display_spec, next_overlay_string)
5644 (get_overlay_strings_1, push_display_prop): Set up the bidi
5645 iterator for displaying display or overlay strings.
5646 (forward_to_next_line_start): Don't use the shortcut if
5648 (back_to_previous_visible_line_start): If handle_display_prop
5649 pushed the iterator stack, restore the internal state of the bidi
5650 iterator by calling bidi_pop_it same number of times.
5651 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5652 and we are bidi-iterating, don't decrement the iterator position;
5653 instead, set the first_elt flag in the bidi iterator, to produce
5655 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5656 (push_display_prop): xassert that we are iterating a buffer.
5657 (push_it, pop_it): Save and restore paragraph_embedding member.
5658 (handle_single_display_spec, next_overlay_string)
5659 (get_overlay_strings_1, reseat_1, reseat_to_string)
5660 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5661 correctly. Don't assume unibyte strings are not bidi-reordered.
5662 (compute_display_string_pos)
5663 (compute_display_string_end): Fix handling the case of C string.
5664 (push_it, pop_it): Save and restore from_disp_prop_p.
5665 (handle_single_display_spec, push_display_prop): Set the
5666 from_disp_prop_p flag.
5667 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5668 (pop_it): Call iterate_out_of_display_property only if we are
5669 popping after iteration over a string that came from a display
5670 property. Fix a typo in popping stretch info. Add an assertion
5671 for verifying that the iterator position is in sync with the bidi
5673 (handle_single_display_spec, get_overlay_strings_1)
5674 (push_display_prop): Fix initialization of paragraph direction for
5675 string when that of the parent object is not yet determined.
5676 (reseat_1): Call bidi_init_it to resync the bidi
5677 iterator with IT's position. (Bug#7616)
5678 (find_row_edges): If ROW->start.pos gives position
5679 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5680 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5681 Reset the from_disp_prop_p flag.
5682 (SAVE_IT, RESTORE_IT): New macros.
5683 (pos_visible_p, face_before_or_after_it_pos)
5684 (back_to_previous_visible_line_start)
5685 (move_it_in_display_line_to, move_it_in_display_line)
5686 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5687 (try_scrolling, redisplay_window, display_line): Use them when
5688 saving a temporary copy of the iterator and restoring it back.
5689 (back_to_previous_visible_line_start, reseat_1)
5690 (init_iterator): Empty the bidi cache "stack".
5691 (move_it_in_display_line_to): If iterator ended up at
5692 EOL, but we never saw any buffer positions smaller than
5693 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5694 motion in bidi-reordered lines.
5695 (move_it_in_display_line_to): Record prev_method and prev_pos
5696 immediately before the call to set_iterator_to_next. Fixes cursor
5697 motion in bidi-reordered lines with stretch glyphs and strings
5698 displayed in margins. (Bug#8133) (Bug#8867)
5699 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5701 (pos_visible_p): Support positions in bidi-reordered lines.
5702 Save and restore bidi cache.
5704 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5705 (bidi_paragraph_info): Delete unused struct.
5706 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5707 (bidi_cache_start): New variable.
5708 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5710 (bidi_cache_fetch_state, bidi_cache_search)
5711 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5712 (bidi_cache_find, bidi_peek_at_next_level)
5713 (bidi_level_of_next_char, bidi_find_other_level_edge)
5714 (bidi_move_to_visually_next): Compare cache index with
5715 bidi_cache_start rather than with zero.
5716 (bidi_fetch_char): Accept new argument STRING; all callers
5717 changed. Support iteration over a string. Support strings with
5718 display properties. Support unibyte strings. Fix the type of
5719 `len' according to what STRING_CHAR_AND_LENGTH expects.
5720 (bidi_paragraph_init, bidi_resolve_explicit_1)
5721 (bidi_resolve_explicit, bidi_resolve_weak)
5722 (bidi_level_of_next_char, bidi_move_to_visually_next):
5723 Support iteration over a string.
5724 (bidi_set_sor_type, bidi_resolve_explicit_1)
5725 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5726 can now be zero (for strings); special values 0 and -1 were
5727 changed to -1 and -2, respectively.
5728 (bidi_char_at_pos): New function.
5729 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5730 Call it instead of FETCH_MULTIBYTE_CHAR.
5731 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5732 initialized to valid values.
5733 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5735 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5736 the test for valid cached positions. Fix the logic for looking up
5737 the sentinel state in the cache. GCPRO the Lisp string we are
5739 (bidi_push_it, bidi_pop_it): New functions.
5740 (bidi_initialize): Initialize the bidi cache start stack pointer.
5741 (bidi_cache_ensure_space): New function, refactored from part of
5742 bidi_cache_iterator_state. Don't assume the required size is just
5743 one BIDI_CACHE_CHUNK away.
5744 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5745 (bidi_count_bytes, bidi_char_at_pos): New functions.
5746 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5747 always valid if bidi_cache_idx is valid.
5748 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5749 is valid if it's going to be used.
5750 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5751 (bidi_cache_fetch_state, bidi_cache_search)
5752 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5753 (bidi_cache_iterator_state, bidi_cache_find)
5754 (bidi_find_other_level_edge, bidi_cache_start_stack):
5755 All variables related to cache indices are now EMACS_INT.
5757 * dispextern.h (struct bidi_string_data): New structure.
5758 (struct bidi_it): New member `string'. Make flag members be 1-bit
5759 fields, and put them last in the struct.
5760 (compute_display_string_pos, compute_display_string_end):
5762 (bidi_push_it, bidi_pop_it): Add prototypes.
5763 (struct iterator_stack_entry): New members bidi_p,
5764 paragraph_embedding, and from_disp_prop_p.
5765 (struct it): Member bidi_p is now a bit field 1 bit wide.
5766 (bidi_shelve_cache, bidi_unshelve_cache):
5769 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5770 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5771 and vector-like objects.
5773 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5774 cache around display iteration.
5776 * window.c (Fwindow_end, window_scroll_pixel_based)
5777 (displayed_window_lines, Frecenter): Save and restore the bidi
5778 cache around display iteration.
5780 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5782 * editfns.c (Fdelete_region): Clarify the use of the named
5783 parameters (bug#6788).
5785 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5787 * indent.c (Fvertical_motion): Set and restore w->pointm when
5788 saving and restoring the window's buffer (Bug#9006).
5790 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5792 * editfns.c (Fstring_to_char): Clarify just what is returned
5793 (bug#6576). Text by Eli Zaretskii.
5795 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5797 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5799 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5801 * buffer.c (mmap_find): Fix a typo.
5803 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5805 Fix execution of x selection hooks.
5806 * xselect.c (Qx_lost_selection_functions)
5807 (Qx_sent_selection_functions): New vars.
5808 (syms_of_xselect): DEFSYM them.
5809 (x_handle_selection_request): Pass Qx_sent_selection_functions
5810 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5811 (x_handle_selection_clear,x_clear_frame_selections):
5812 Pass Qx_lost_selection_functions rather than
5813 Vx_lost_selection_functions to Frun_hook_with_args.
5815 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5817 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5818 The old code sometimes used this field without initializing it.
5820 * alloc.c (gc_sweep): Don't read past end of array.
5821 In theory, the old code could also have corrupted Emacs internals,
5822 though it'd be very unlikely.
5824 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5826 * character.c (Fcharacterp): Don't advertise optional ignored
5827 argument. (Bug#4026)
5829 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5831 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5834 * window.c (Fset_window_start): Doc fix (bug#4199).
5835 (Fset_window_hscroll): Ditto.
5837 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5839 Fix minor new problems caught by GCC 4.6.1.
5840 * term.c (init_tty): Remove unused local.
5841 * xsettings.c (store_monospaced_changed): Define this function only
5842 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5845 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5847 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5849 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5851 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5852 are the mini-buffer and the echo area (bug#3320).
5854 * term.c (init_tty): Remove support for supdup, c10 and perq
5855 terminals, which are no longer supported (bug#1482).
5857 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5859 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5861 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5863 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5864 for non-popups (Bug#3642).
5866 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5868 * alloc.c (reset_malloc_hooks): Protoize.
5869 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5870 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5871 * cm.c (losecursor): Likewise.
5872 * data.c (fmod): Likewise.
5873 * dispnew.c (swap_glyphs_in_rows): Likewise.
5874 * emacs.c (memory_warning_signal): Likewise.
5875 * floatfns.c (float_error): Likewise.
5876 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5877 (otf_open, font_otf_capability, generate_otf_features)
5878 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5880 * image.c (pbm_read_file): Likewise.
5881 * indent.c (string_display_width): Likewise.
5882 * intervals.c (check_for_interval, search_for_interval)
5883 (inc_interval_count, count_intervals, root_interval)
5884 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5885 * lread.c (defalias): Likewise.
5886 * ralloc.c (r_alloc_check): Likewise.
5887 * regex.c (set_image_of_range_1, set_image_of_range)
5888 (regex_grow_registers): Likewise.
5889 * sysdep.c (strerror): Likewise.
5890 * termcap.c (valid_filename_p, tprint, main): Likewise.
5891 * tparam.c (main): Likewise.
5892 * unexhp9k800.c (run_time_remap, save_data_space)
5893 (update_file_ptrs, read_header, write_header, calculate_checksum)
5894 (copy_file, copy_rest, display_header): Likewise.
5895 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5897 * xdisp.c (check_it): Likewise.
5898 * xfaces.c (register_color, unregister_color, unregister_colors):
5900 * xfns.c (print_fontset_result): Likewise.
5901 * xrdb.c (member, fatal, main): Likewise.
5903 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5905 Fix minor problems found by static checking (Bug#9031).
5906 * chartab.c (char_table_set_range, map_sub_char_table):
5907 Remove unused locals.
5908 (uniprop_table): Now static.
5909 * composite.c (_work_char): Remove unused static var.
5911 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5913 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5915 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5917 * gtkutil.c (qttip_cb): Remove code without function.
5919 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5921 * w32.c (pthread_sigmask): New stub.
5923 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5925 Use pthread_sigmask, not sigprocmask (Bug#9010).
5926 sigprocmask is portable only for single-threaded applications, and
5927 Emacs can be multi-threaded when it uses GTK.
5928 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5930 * callproc.c (Fcall_process):
5931 * process.c (create_process):
5932 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5933 Use pthread_sigmask, not sigprocmask.
5935 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5937 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5938 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5941 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5943 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5944 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5945 (xg_hide_tooltip): Fix comment.
5947 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5948 in registerServicesMenuSendTypes.
5949 (validRequestorForSendType): Don't check ns_return_types.
5951 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5954 2011-07-08 Jason Rumney <jasonr@gnu.org>
5956 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5957 SH_SHOW for hidden windows (Bug#5482).
5959 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5960 frame struct members of non-existent frames (Bug#6284).
5962 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5964 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5965 variable firstTime not needed on OSX >= 10.6.
5966 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5967 >= 10.5. Use setKnobProportion, setDoubleValue.
5969 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5970 (MAC_OS_X_VERSION_10_5): Define if not defined.
5971 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5972 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5973 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5975 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5976 cString and lossyCString on OSX >= 10.4
5978 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5979 sizeToFit on OSX >= 10.2.
5981 * nsimage.m (allocInitFromFile): Don't use deprecated method
5982 bestRepresentationForDevice on OSX >= 10.6.
5984 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5987 * emacs.c: Declare unexec_init_emacs_zone.
5989 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5991 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5993 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5994 on svcsMenu (Bug#8842).
5996 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5998 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6000 * nsterm.m (QUTF8_STRING): Declare.
6001 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6002 (validRequestorForSendType): Return type is (id).
6003 Change indexOfObjectIdenticalTo to indexOfObject.
6004 Check if we have local selection before returning self (Bug#8842).
6005 (writeSelectionToPasteboard): Put local selection into paste board
6006 if we have a local selection (Bug#8842).
6007 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6009 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6010 (ns_get_local_selection): Declare.
6012 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6014 * keymap.c (describe_map_tree): Don't insert a double newline at
6015 the end of the buffer (bug#1169) and return whether we inserted
6018 * callint.c (Fcall_interactively): Change "reading args" to
6019 "providing args" to try to clarify what it does (bug#1010).
6021 2011-07-07 Kenichi Handa <handa@m17n.org>
6023 * composite.c (composition_compute_stop_pos): Ignore a static
6024 composition starting before CHARPOS (Bug#8915).
6026 * xdisp.c (handle_composition_prop): Likewise.
6028 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6030 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6033 2011-07-07 Kenichi Handa <handa@m17n.org>
6035 * character.h (unicode_category_t): New enum type.
6037 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6038 (Qchar_code_property_table): New variable.
6039 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6040 (UNIPROP_COMPRESSED_FORM_P): New macros.
6041 (char_table_ascii): Uncompress the compressed values.
6042 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6043 Uncompress the compressed values.
6044 (sub_char_table_ref_and_range): Likewise.
6045 (char_table_ref_and_range): Uncompress the compressed values.
6046 (sub_char_table_set): New arg is_uniprop. Callers changed.
6047 Uncompress the compressed values.
6048 (sub_char_table_set_range): Args changed. Callers changed.
6049 (char_table_set_range): Adjuted for the above change.
6050 (map_sub_char_table): Delete args default_val and parent. Add arg
6051 top. Give decoded values to a Lisp function.
6052 (map_char_table): Adjust for the above change. Give decoded
6053 values to a Lisp function. Gcpro more variables.
6054 (uniprop_table_uncompress)
6055 (uniprop_decode_value_run_length): New functions.
6056 (uniprop_decoder, uniprop_decoder_count): New variables.
6057 (uniprop_get_decoder, uniprop_encode_value_character)
6058 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6060 (uniprop_encoder, uniprop_encoder_count): New variables.
6061 (uniprop_get_encoder, uniprop_table)
6062 (Funicode_property_table_internal, Fget_unicode_property_internal)
6063 (Fput_unicode_property_internal): New functions.
6064 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6065 Sunicode_property_table_internal, Sget_unicode_property_internal,
6066 and Sput_unicode_property_internal. Defvar_lisp
6067 char-code-property-alist.
6069 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6070 Vunicode_category_table.
6072 * font.c (font_range): Adjust for the change of
6073 Vunicode_category_table.
6075 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6077 * m/iris4d.h: Remove file, move contents ...
6078 * s/irix6-5.h: ... here.
6080 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6082 Remove unportable assumption about struct layout (Bug#8884).
6083 * alloc.c (mark_buffer):
6084 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6085 (clone_per_buffer_values): Don't assume that
6086 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6087 This isn't true in general, and it's particularly not true
6088 if Emacs is configured with --with-wide-int.
6089 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6090 New macros, used in the buffer.c change.
6092 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6094 * xsettings.c: Use both GConf and GSettings if both are available.
6095 (store_config_changed_event): Add comment.
6096 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6097 (store_tool_bar_style_changed): New functions.
6098 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6099 (struct xsettings): Move font inside HAVE_XFT.
6100 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6101 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6102 Move inside HAVE_XFT.
6103 (something_changed_gsettingsCB): Rename from something_changedCB.
6104 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6106 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6107 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6108 (something_changed_gconfCB): Rename from something_changedCB.
6109 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6110 (parse_settings): Move check for font inside HAVE_XFT.
6111 (read_settings, apply_xft_settings): Add comment.
6112 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6113 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6114 call store_font_name_changed.
6115 (xft_settings_event): Add comment.
6116 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6117 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6118 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6119 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6120 (xsettings_initialize): Call init_gsettings last.
6121 (xsettings_get_system_font, xsettings_get_system_normal_font):
6124 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6126 Random fixes. E.g., (random) never returned negative values.
6127 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6128 subseconds part to the entropy, as that's a bit more random.
6129 Prefer signed to unsigned, since the signedness doesn't matter and
6130 in general we prefer signed. When given a limit, use a
6131 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6132 latter isn't right if USE_2_TAGS_FOR_INTS.
6133 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6134 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6136 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6138 * textprop.c (text_property_stickiness):
6139 Obey Vtext_property_default_nonsticky.
6140 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6141 * w32fns.c (syms_of_w32fns):
6142 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6144 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6146 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6147 This is more efficient than Ffile_directory_p and avoids a minor race.
6149 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6151 * buffer.c (Foverlay_put): Say what the return value is
6154 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6155 is a directory before asking whether to use the file name
6157 (barf_or_query_if_file_exists): Make the "File is a directory"
6158 error be more correct.
6160 * fns.c (Frequire): Remove the mention of the .gz files, since
6161 that's installation-specific, but keep the mention of
6162 `get-load-suffixes'.
6164 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6166 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6167 Report string overflow if the output is too long.
6169 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6171 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6172 (syms_of_gnutls): Remove duplicate DEFSYM for
6173 Qgnutls_bootprop_verify_hostname_error, an error for
6174 Qgnutls_bootprop_verify_error (which is no longer used).
6176 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6177 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6178 Also (re)move comments that are misplaced or no longer relevant.
6180 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6182 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6184 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6186 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6187 and background color parameters if they have been changed.
6189 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6191 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6193 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6195 * xsettings.c (SYSTEM_FONT): Define only when used.
6196 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6198 * keymap.c (access_keymap_1): Now static.
6200 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6202 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6203 leave any prefix arg for the up event (Bug#1586).
6205 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6207 * lread.c (syms_of_lread): Mention single symbols defined by
6208 `defvar' or `defconst' (bug#7154).
6210 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6211 (Frequire): Mention get-load-suffixes.
6213 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6215 * window.h (window): Remove clone_number slot.
6216 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6218 (make_parent_window, make_window, saved_window)
6219 (Fset_window_configuration, save_window_save): Don't deal with
6221 * buffer.c (Qclone_number): Remove declaration.
6222 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6224 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6226 Add multiple inheritance to keymaps.
6227 * keymap.c (Fmake_composed_keymap): New function.
6228 (Fset_keymap_parent): Simplify.
6229 (fix_submap_inheritance): Remove.
6230 (access_keymap_1): New function extracted from access_keymap to handle
6231 embedded parents and handle lists of maps.
6232 (access_keymap): Use it.
6233 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6234 (Fcopy_keymap): Handle embedded parents.
6235 (Fcommand_remapping, define_as_prefix): Simplify.
6236 (Fkey_binding): Simplify.
6237 (syms_of_keymap): Move minibuffer-local-completion-map,
6238 minibuffer-local-filename-completion-map,
6239 minibuffer-local-must-match-map, and
6240 minibuffer-local-filename-must-match-map to Elisp.
6241 (syms_of_keymap): Defsubr make-composed-keymap.
6242 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6243 (parse_menu_item): Trivial simplification.
6245 2011-07-01 Glenn Morris <rgm@gnu.org>
6247 * Makefile.in (SETTINGS_LIBS): Fix typo.
6249 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6251 * coding.c (Fencode_coding_string): Record the last coding system
6252 used, as the function doc string says (bug#8738).
6254 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6256 * xsettings.c (store_monospaced_changed): Take new font as arg and
6257 check for change against current_mono_font.
6258 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6259 (emacs_settings_constructor, emacs_settings_get_property)
6260 (emacs_settings_set_property, emacs_settings_class_init)
6261 (emacs_settings_init, gsettings_obj): Remove.
6262 (something_changedCB): New function for HAVE_GSETTINGS.
6263 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6264 with value as argument.
6265 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6266 g_settings_new (Bug#8967). Do not create gsettings_obj.
6267 Remove calls to g_settings_bind. Connect something_changedCB to
6270 * xgselect.c: Add defined (HAVE_GSETTINGS).
6271 (xgselect_initialize): Ditto.
6273 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6274 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6277 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6279 * eval.c (struct backtrace): Simplify and port the data structure.
6280 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6281 signed bit field, as this assumption is not portable and it makes
6282 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6283 "char debug_on_exit : 1" as this is not portable either; instead,
6284 use the portable "unsigned int debug_on_exit : 1". Remove unused
6285 member evalargs. Remove obsolete comments about cc bombing out.
6287 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6289 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6290 Let HAVE_GSETTINGS override HAVE_GCONF.
6291 (store_monospaced_changed): New function.
6292 (EMACS_SETTINGS): A new type derived from GObject to handle
6293 GSettings notifications.
6294 (emacs_settings_constructor, emacs_settings_get_property)
6295 (emacs_settings_set_property, emacs_settings_class_init):
6297 (gsettings_client, gsettings_obj): New variables.
6298 (GSETTINGS_SCHEMA): New define.
6299 (something_changedCB): Call store_monospaced_changed.
6300 (init_gsettings): New function.
6301 (xsettings_initialize): Call init_gsettings.
6302 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6305 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6308 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6310 * window.c (resize_root_window, grow_mini_window)
6311 (shrink_mini_window): Rename Qresize_root_window to
6312 Qwindow_resize_root_window and Qresize_root_window_vertically to
6313 Qwindow_resize_root_window_vertically.
6315 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6317 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6319 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6321 * makefile.w32-in: Redesign dependencies so they reflect more
6322 clearly which files are directly included by each source file,
6323 and not through other includes.
6325 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6327 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6328 (sort_overlays, overlay_strings): When an overlay's clone number
6329 matches the window's clone number process the overlay even if
6330 the overlay's window property doesn't match the current window.
6332 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6333 (Fwindow_hchild): Rename to Fwindow_left_child.
6334 (Fwindow_next): Rename to Fwindow_next_sibling.
6335 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6336 (resize_window_check): Rename to window_resize_check.
6337 (resize_window_apply): Rename to window_resize_apply.
6338 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6339 (Fdelete_other_windows_internal, resize_frame_windows)
6340 (Fsplit_window_internal, Fdelete_window_internal)
6341 (grow_mini_window, shrink_mini_window)
6342 (Fresize_mini_window_internal): Fix callers accordingly.
6344 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6346 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6347 (emacs_fixed_set_min_size): Remove.
6348 (emacs_fixed_new): Take frame as argument.
6350 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6351 (_EmacsFixedPrivate): Remove minwidth/height.
6352 Add struct frame *f.
6353 (emacs_fixed_init): Initialize priv->f.
6354 (get_parent_class, emacs_fixed_set_min_size): Remove.
6355 (emacs_fixed_new): Set priv->f to argument.
6356 (emacs_fixed_get_preferred_width)
6357 (emacs_fixed_get_preferred_height): Use min_width/height from
6358 frames size_hint to set minimum and natural (Bug#8919).
6359 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6360 and use min_width/height from frames size_hint to set
6361 min_width/height (Bug#8919).
6363 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6364 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6367 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6369 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6370 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6373 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6375 * process.c (wait_reading_process_output): Bypass select if
6376 waiting for a cell while ignoring keyboard input, and input is
6377 pending. Suggested by Jan Djärv (Bug#8869).
6379 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6381 Use gnulib's dup2 module instead of rolling our own.
6382 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6384 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6386 * dispnew.c (scrolling_window): Before scrolling, turn off a
6387 mouse-highlight in the window being scrolled.
6389 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6391 Move DEFSYM to lisp.h and use everywhere.
6393 * character.h (DEFSYM): Move declaration...
6394 * lisp.h (DEFSYM): ...here.
6400 * w32select.c: Don't include character.h.
6402 * alloc.c (syms_of_alloc):
6403 * buffer.c (syms_of_buffer):
6404 * bytecode.c (syms_of_bytecode):
6405 * callint.c (syms_of_callint):
6406 * casefiddle.c (syms_of_casefiddle):
6407 * casetab.c (init_casetab_once):
6408 * category.c (init_category_once, syms_of_category):
6409 * ccl.c (syms_of_ccl):
6410 * cmds.c (syms_of_cmds):
6411 * composite.c (syms_of_composite):
6412 * dbusbind.c (syms_of_dbusbind):
6413 * dired.c (syms_of_dired):
6414 * dispnew.c (syms_of_display):
6415 * doc.c (syms_of_doc):
6416 * editfns.c (syms_of_editfns):
6417 * emacs.c (syms_of_emacs):
6418 * eval.c (syms_of_eval):
6419 * fileio.c (syms_of_fileio):
6420 * fns.c (syms_of_fns):
6421 * frame.c (syms_of_frame):
6422 * fringe.c (syms_of_fringe):
6423 * insdel.c (syms_of_insdel):
6424 * keymap.c (syms_of_keymap):
6425 * lread.c (init_obarray, syms_of_lread):
6426 * macros.c (syms_of_macros):
6427 * msdos.c (syms_of_msdos):
6428 * print.c (syms_of_print):
6429 * process.c (syms_of_process):
6430 * search.c (syms_of_search):
6431 * sound.c (syms_of_sound):
6432 * syntax.c (init_syntax_once, syms_of_syntax):
6433 * terminal.c (syms_of_terminal):
6434 * textprop.c (syms_of_textprop):
6435 * undo.c (syms_of_undo):
6436 * w32.c (globals_of_w32):
6437 * window.c (syms_of_window):
6438 * xdisp.c (syms_of_xdisp):
6439 * xfaces.c (syms_of_xfaces):
6440 * xfns.c (syms_of_xfns):
6441 * xmenu.c (syms_of_xmenu):
6442 * xsettings.c (syms_of_xsettings):
6443 * xterm.c (syms_of_xterm): Use DEFSYM.
6445 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6447 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6449 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6451 Integer and buffer overflow fixes (Bug#8873).
6453 * print.c (printchar, strout): Check for string overflow.
6454 (PRINTPREPARE, printchar, strout):
6455 Don't set size unless allocation succeeds.
6457 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6458 for sizes. Check for string overflow more accurately.
6459 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6461 * macros.c: Integer and buffer overflow fixes.
6462 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6463 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6464 Use ptrdiff_t, not int, for sizes.
6465 Don't increment bufsize until after realloc succeeds.
6466 Check for size-calculation overflow.
6467 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6469 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6471 * lread.c: Integer overflow fixes.
6472 (read_integer): Radix is now EMACS_INT, not int,
6473 to improve quality of diagnostics for out-of-range radices.
6474 Calculate buffer size correctly for out-of-range radices.
6475 (read1): Check for integer overflow in radices, and in
6476 read-circle numbers.
6477 (read_escape): Avoid int overflow.
6478 (Fload, openp, read_buffer_size, read1)
6479 (substitute_object_recurse, read_vector, read_list, map_obarray):
6480 Use ptrdiff_t, not int, for sizes.
6481 (read1): Use EMACS_INT, not int, for sizes.
6482 Check for size overflow.
6484 * image.c (cache_image): Check for size arithmetic overflow.
6486 * lread.c: Integer overflow issues.
6487 (saved_doc_string_size, saved_doc_string_length)
6488 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6489 Now ptrdiff_t, not int.
6490 (read1): Don't assume doc string length fits in int. Check for
6491 out-of-range doc string lengths.
6492 (read_list): Don't assume file position fits in int.
6493 (read_escape): Check for hex character overflow.
6495 2011-06-22 Leo Liu <sdl.web@gmail.com>
6497 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6498 Move to minibuffer.el.
6500 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6502 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6503 The following patches are for when GLYPH_DEBUG && !XASSERT.
6504 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6505 * dispnew.c (flush_stdout):
6506 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6507 Mark as externally visible.
6508 * dispnew.c (check_window_matrix_pointers): Now static.
6509 * dispnew.c (window_to_frame_vpos):
6510 * xfns.c (unwind_create_frame):
6511 * xterm.c (x_check_font): Remove unused local.
6512 * scroll.c (CHECK_BOUNDS):
6513 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6514 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6515 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6516 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6517 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6519 (debug_method_add): Use va_list and vsprintf rather than relying
6520 on undefined behavior with wrong number of arguments.
6521 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6522 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6523 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6524 since we're not interested in debugging glyphs with old libraries.
6525 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6526 GCC 4.6.0's static checking.
6528 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6530 Integer overflow and signedness fixes (Bug#8873).
6531 A few related buffer overrun fixes, too.
6533 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6535 * dispextern.h (struct face.stipple):
6536 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6537 (x_bitmap_mask, x_allocate_bitmap_record)
6538 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6539 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6540 (x_create_bitmap_from_xpm_data):
6541 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6542 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6544 * xfaces.c (load_pixmap):
6545 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6546 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6547 (.bitmaps_last, struct x_output.icon_bitmap):
6548 Use ptrdiff_t, not int, for bitmap indexes.
6549 (x_allocate_bitmap_record): Check for size overflow.
6550 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6552 Use ptrdiff_t, not int, for overlay counts.
6553 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6554 * editfns.c (overlays_around, get_pos_property):
6555 * textprop.c (get_char_property_and_overlay):
6556 * xdisp.c (next_overlay_change, note_mouse_highlight):
6557 * xfaces.c (face_at_buffer_position):
6558 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6559 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6560 (Fnext_overlay_change, Fprevious_overlay_change)
6561 (mouse_face_overlay_overlaps, Foverlays_in):
6562 Use ptrdiff_t, not int, for sizes.
6563 (overlays_at, overlays_in): Check for size-calculation overflow.
6565 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6567 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6568 (x_session_initialize): Do not assume string length fits in int.
6570 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6571 This is unlikely, but can occur if DPI is outlandish.
6573 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6574 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6576 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6577 * xrdb.c (magic_file_p, search_magic_path):
6578 Omit last arg SUFFIX; it was always 0. All callers changed.
6579 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6581 * xfont.c (xfont_match): Avoid need for strlen.
6583 * xfns.c: Don't assume strlen fits in int.
6584 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6586 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6587 not unsigned long, as we prefer signed integers. All callers changed.
6588 Detect integer overflow in repeat count.
6589 (message_dolog): Don't assume print length fits in 39 bytes.
6590 (display_mode_element): Don't assume strlen fits in int.
6592 * termcap.c: Don't assume sizes fit in int and never overflow.
6593 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6594 (gobble_line): Check for size-calculation overflow.
6596 * minibuf.c (Fread_buffer):
6597 * lread.c (intern, intern_c_string):
6598 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6599 Don't assume string length fits in int.
6601 * keyboard.c (parse_tool_bar_item):
6602 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6604 * font.c: Don't assume string length fits in int.
6605 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6606 Use ptrdiff_t, not int.
6607 (font_intern_prop): Don't assume string length fits in int.
6608 Don't assume integer property fits in fixnum.
6609 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6611 * filelock.c: Fix some buffer overrun and integer overflow issues.
6612 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6613 Reformulate so as not to need the command string.
6614 Invoke gzip -cd rather than gunzip, as it's more portable.
6615 (lock_info_type, lock_file_1, lock_file):
6616 Don't assume pid_t and time_t fit in unsigned long.
6617 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6618 (current_lock_owner): Prefer signed type for sizes.
6619 Use memcpy, not strncpy, where memcpy is what is really wanted.
6620 Don't assume (via atoi) that time_t and pid_t fit in int.
6621 Check for time_t and/or pid_t out of range, e.g., via a network share.
6622 Don't alloca where an auto var works fine.
6624 * fileio.c: Fix some integer overflow issues.
6625 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6626 Don't assume string length fits in int.
6627 (directory_file_name): Don't assume string length fits in long.
6628 (make_temp_name): Don't assume pid fits in int, or that its print
6629 length is less than 20.
6631 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6633 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6635 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6637 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6638 We prefer signed integers, even for size calculations.
6640 * emacs.c: Don't assume string length fits in 'int'.
6641 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6642 (main): Don't invoke strlen when not needed.
6644 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6645 (XD_DEBUG_MESSAGE): Don't waste a byte.
6647 * callproc.c (getenv_internal_1, getenv_internal)
6649 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6651 * lread.c (invalid_syntax): Omit length argument.
6652 All uses changed. This doesn't fix a bug, but it simplifies the
6653 code away from its former Hollerith-constant appearance, and it's
6654 one less 'int' to worry about when looking at integer-overflow issues.
6655 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6657 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6658 This didn't break anything, but it didn't help either.
6659 It's confusing to put a bogus integer in a place where the actual
6660 value does not matter.
6661 (LIST_END_P): Remove unused macro and its bogus comment.
6662 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6664 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6665 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6667 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6668 We prefer signed types, and the value cannot exceed the EMACS_INT
6669 range anyway (because otherwise the length would not be representable).
6670 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6671 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6672 This avoids a GCC warning when WIDE_EMACS_INT.
6674 * indent.c (sane_tab_width): New function.
6675 (current_column, scan_for_column, Findent_to, position_indentation)
6676 (compute_motion): Use it. This is just for clarity.
6677 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6679 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6681 * lisp.h (lint_assume): New macro.
6682 * composite.c (composition_gstring_put_cache):
6683 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6685 * editfns.c, insdel.c:
6686 Omit unnecessary forward decls, to simplify future changes.
6688 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6690 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6692 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6693 Use much-faster test for byte-length change.
6694 Don't assume string byte-length fits in 'int'.
6695 Check that character arg fits in 'int'.
6696 (mapcar1): Declare byte as byte, for clarity.
6698 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6700 * fns.c (concat): Catch string overflow earlier.
6701 Do not rely on integer wraparound.
6703 * dispextern.h (struct it.overlay_strings_charpos)
6704 (struct it.selective): Now EMACS_INT, not int.
6705 * xdisp.c (forward_to_next_line_start)
6706 (back_to_previous_visible_line_start)
6707 (reseat_at_next_visible_line_start, next_element_from_buffer):
6708 Don't arbitrarily truncate the value of 'selective' to int.
6710 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6712 * composite.c: Don't truncate sizes to 'int'.
6713 (composition_gstring_p, composition_reseat_it)
6714 (composition_adjust_point): Use EMACS_INT, not int.
6715 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6716 not EMACS_UINT, for indexes.
6718 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6720 * buffer.c: Include <verify.h>.
6721 (struct sortvec.priority, struct sortstr.priority):
6722 Now EMACS_INT, not int.
6723 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6724 (struct sortstr.size, record_overlay_string)
6725 (struct sortstrlist.size, struct sortlist.used):
6726 Don't truncate size to int.
6727 (record_overlay_string): Check for size-calculation overflow.
6728 (init_buffer_once): Check at compile-time, not run-time.
6730 2011-06-22 Jim Meyering <meyering@redhat.com>
6732 Don't leak an XBM-image-sized buffer
6733 * image.c (xbm_load): Free the image buffer after using it.
6735 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6738 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6739 that Sun C diagnosed.
6740 * fns.c (secure_hash): Fix pointer signedness issue.
6741 * intervals.c (static_offset_intervals): New function.
6742 (offset_intervals): Use it.
6744 2011-06-21 Leo Liu <sdl.web@gmail.com>
6747 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6750 * fns.c (secure_hash): Rename from crypto_hash_function and change
6751 the first arg to accept symbols.
6752 (Fsecure_hash): New primitive.
6753 (syms_of_fns): New symbols.
6755 2011-06-20 Deniz Dogan <deniz@dogan.se>
6757 * process.c (Fset_process_buffer): Clarify return value in
6760 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6762 * dispnew.c (add_window_display_history): Use BVAR.
6764 * xdisp.c (debug_method_add): Use BVAR.
6765 (check_window_end, dump_glyph_matrix, dump_glyph)
6766 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6768 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6771 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6772 check till after the cache is created in init_frame_faces.
6774 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6776 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6778 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6780 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6781 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6782 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6784 Improve buffer-overflow checking (Bug#8873).
6785 * fileio.c (Finsert_file_contents):
6786 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6787 Remove the old (too-loose) buffer overflow checks.
6788 They weren't needed, since make_gap checks for buffer overflow.
6789 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6790 The old code merely checked for Emacs fixnum overflow, and relied
6791 on undefined (wraparound) behavior. The new code avoids undefined
6792 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6794 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6795 Tune. Don't use wider integers than needed. Don't use alloca.
6796 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6798 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6800 * insdel.c, lisp.h (buffer_overflow): New function.
6801 (insert_from_buffer_1, replace_range, replace_range_2):
6802 * insdel.c (make_gap_larger):
6803 * editfns.c (Finsert_char):
6804 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6806 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6808 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6810 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6812 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6813 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6815 * fileio.c: Don't assume EMACS_INT fits in off_t.
6816 (emacs_lseek): New static function.
6817 (Finsert_file_contents, Fwrite_region): Use it.
6818 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6820 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6822 * fns.c: Don't overflow int when computing a list length.
6823 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6824 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6825 truncation on 64-bit hosts. Check for QUIT every
6826 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6827 faster and is responsive enough.
6828 (Flength): Report an error instead of overflowing an integer.
6829 (Fsafe_length): Return a float if the value is not representable
6830 as a fixnum. This shouldn't happen except in contrived situations.
6831 (Fnthcdr, Fsort): Don't assume list length fits in int.
6832 (Fcopy_sequence): Don't assume vector length fits in int.
6834 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6835 (header_size, word_size): New constants.
6836 (allocate_vectorlike): Don't check size overflow here.
6837 (allocate_vector): Check it here instead, since this is the only
6838 caller of allocate_vectorlike that could cause overflow.
6839 Check that the new vector's length is representable as a fixnum.
6841 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6842 The previous code was bogus. For example, next_almost_prime (32)
6843 returned 39, which is undesirable as it is a multiple of 3; and
6844 next_almost_prime (24) returned 25, which is a multiple of 5 so
6845 why was the code bothering to check for multiples of 7?
6847 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6849 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6851 Variadic C functions now count arguments with ptrdiff_t.
6852 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6853 Back then I didn't know that the Emacs coding style prefers signed int.
6854 Also, in the meantime I found a few more instances where arguments
6855 were being counted with int, which may truncate counts on 64-bit
6856 machines, or EMACS_INT, which may be unnecessarily wide.
6857 * lisp.h (struct Lisp_Subr.function.aMANY)
6858 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6859 Arg counts are now ptrdiff_t, not size_t.
6860 All variadic functions and their callers changed accordingly.
6861 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6862 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6863 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6864 * callint.c (Fcall_interactively): Check arg count for overflow,
6865 to avoid potential buffer overrun. Use signed char, not 'int',
6866 for 'varies' array, so that we needn't bother to check its size
6867 calculation for overflow.
6868 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6869 * eval.c (apply_lambda):
6870 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6871 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6872 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6874 * callint.c (Fcall_interactively): Don't use index var as event count.
6876 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6877 * mem-limits.h (SIZE): Remove; no longer used.
6879 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6881 Remove unnecessary casts.
6882 * xterm.c (x_term_init):
6883 * xfns.c (x_set_border_pixel):
6884 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6885 These aren't needed now that we assume ANSI C.
6887 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6888 It's more likely to cause problems (due to unsigned overflow)
6891 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6893 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6895 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6897 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6899 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6901 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6903 GLYPH_CODE_FACE returns EMACS_INT, not int.
6904 * dispextern.h (merge_faces):
6905 * xfaces.c (merge_faces):
6906 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6907 Don't assume EMACS_INT fits in int.
6909 * character.h (CHAR_VALID_P): Remove unused parameter.
6910 * fontset.c, lisp.h, xdisp.c: All uses changed.
6912 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6914 * fns.c (concat): Minor tuning based on overflow analysis.
6915 This doesn't fix any bugs. Use int to hold character, instead
6916 of constantly refetching from Emacs object. Use XFASTINT, not
6917 XINT, for value known to be a character. Don't bother comparing
6918 a single byte to 0400, as it's always less.
6920 * floatfns.c (Fexpt):
6921 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6923 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6926 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6928 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6929 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6930 incorrectly succeed when S was a string, because 4294967386 was
6931 truncated before it was used.
6933 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6934 Otherwise, an out-of-range integer could cause undefined behavior
6937 * composite.c: Use int, not EMACS_INT, for characters.
6938 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6939 EMACS_INT, for values that are known to be in character range.
6940 This doesn't fix any bugs but is the usual style inside Emacs and
6941 may generate better code on 32-bit machines.
6943 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6944 This is for reasons similar to the recent CHAR_STRING fix.
6945 * charset.c (Fencode_char): Check that character arg is actually
6946 a character. Pass an int to ENCODE_CHAR.
6947 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6948 wider than 'int', as a compile-time check to prevent future regressions
6951 * character.c (char_string): Remove unnecessary casts.
6953 Make sure a 64-bit char is never passed to CHAR_STRING.
6954 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6955 by silently ignoring the top 32 bits, allowing some values
6956 that were far too large to be valid characters.
6957 * character.h: Include <verify.h>.
6958 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6959 arguments are no wider than unsigned, as a compile-time check
6960 to prevent future regressions in this area.
6962 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6963 (Fsubst_char_in_region):
6965 * xdisp.c (decode_mode_spec_coding):
6966 Adjust to CHAR_STRING's new requirement.
6967 * editfns.c (Finsert_char, Fsubst_char_in_region):
6968 * fns.c (concat): Check that character args are actually
6969 characters. Without this test, these functions did the wrong
6970 thing with wildly out-of-range values on 64-bit hosts.
6972 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6973 These casts should not be needed on 32-bit hosts, either.
6974 * keyboard.c (read_char):
6975 * lread.c (Fload): Remove casts to unsigned.
6977 * lisp.h (UNSIGNED_CMP): New macro.
6978 This fixes comparison bugs on 64-bit hosts.
6979 (ASCII_CHAR_P): Use it.
6980 * casefiddle.c (casify_object):
6981 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6982 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6983 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6984 * dispextern.h (FACE_FROM_ID):
6985 * keyboard.c (read_char): Use UNSIGNED_CMP.
6987 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6988 not to EMACS_INT, to avoid GCC warning.
6990 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6992 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6993 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6994 isn't needed on 32-bit machines.
6996 * buffer.c (Fgenerate_new_buffer_name):
6997 Use EMACS_INT for count, not int.
6998 (advance_to_char_boundary): Return EMACS_INT, not int.
7000 * data.c (Qcompiled_function): Now static.
7002 * window.c (window_body_lines): Now static.
7004 * image.c (gif_load): Rename local to avoid shadowing.
7006 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7007 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7008 * alloc.c (make_save_value): Integer argument is now of type
7010 (mark_object): Use ptrdiff_t, not int.
7011 * lisp.h (pD): New macro.
7012 * print.c (print_object): Use it.
7014 * alloc.c: Use EMACS_INT, not int, to count objects.
7015 (total_conses, total_markers, total_symbols, total_vector_size)
7016 (total_free_conses, total_free_markers, total_free_symbols)
7017 (total_free_floats, total_floats, total_free_intervals)
7018 (total_intervals, total_strings, total_free_strings):
7019 Now EMACS_INT, not int. All uses changed.
7020 (Fgarbage_collect): Compute overall total using a double, so that
7021 integer overflow is less likely to be a problem. Check for overflow
7022 when converting back to an integer.
7023 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7024 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7025 These were 'int' variables that could overflow on 64-bit hosts;
7026 they were never used, so remove them instead of repairing them.
7027 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7028 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7029 Previously, this ceilinged at INT_MAX, but that doesn't work on
7031 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7033 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7034 (allocate_vectorlike): Check for ptrdiff_t overflow.
7035 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7036 when a (possibly-narrower) signed value would do just as well.
7037 We prefer using signed arithmetic, to avoid comparison confusion.
7039 * alloc.c: Catch some string size overflows that we were missing.
7040 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7041 for convenience in STRING_BYTES_MAX.
7042 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7043 The definition here is exact; the one in lisp.h was approximate.
7044 (allocate_string_data): Check for string overflow. This catches
7045 some instances we weren't catching before. Also, it catches
7046 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7047 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7048 and ptrdiff_t and EMACS_INT are both 64 bits.
7050 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7051 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7052 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7054 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7056 * alloc.c (Fmake_string): Check for out-of-range init.
7058 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7060 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7062 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7064 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7065 xg_get_default_scrollbar_width.
7067 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7068 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7069 (style_changed_cb): Call update_theme_scrollbar_width and call
7070 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7071 all frames (Bug#8505).
7072 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7073 Call gtk_window_set_resizable if HAVE_GTK3.
7074 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7075 and height if HAVE_GTK3 (Bug#8505).
7076 (scroll_bar_width_for_theme): New variable.
7077 (update_theme_scrollbar_width): New function.
7078 (xg_get_default_scrollbar_width): Move code to
7079 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7080 (xg_initialize): Call update_theme_scrollbar_width.
7082 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7084 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7086 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7088 * frame.c (make_frame): Call other_buffer_safely instead of
7091 * window.c (temp_output_buffer_show): Call display_buffer with
7092 second argument Vtemp_buffer_show_specifiers and reset latter
7093 immediately after the call.
7094 (Vtemp_buffer_show_specifiers): New variable.
7095 (auto_window_vscroll_p, next_screen_context_lines)
7096 (Vscroll_preserve_screen_position): Remove leading asterisks from
7099 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7101 Fix minor problems found by GCC 4.6.0 static checking.
7102 * buffer.c (Qclone_number): Remove for now, as it's unused.
7103 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7104 (record_buffer): Remove unused local.
7105 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7106 (set_frame_buffer_list): Remove; unused.
7107 * frame.h (other_visible_frames): Remove decl.
7108 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7109 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7110 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7112 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7113 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7114 Define only if HAVE_GPM.
7115 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7116 (update_hints_inhibit): Remove; never set. All uses removed.
7117 * widgetprv.h (emacsFrameClassRec): Remove decl.
7118 * window.c (delete_deletable_window): Now returns void, since it
7119 wasn't returning anything.
7120 (compare_window_configurations): Remove unused locals.
7121 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7122 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7123 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7124 the same widths as pointers. This follows up on the 2011-05-06 patch.
7125 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7126 * xterm.h: Likewise.
7127 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7129 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7131 * makefile.w32-in: Update dependencies.
7132 (LISP_H): Add lib/intprops.h.
7134 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7136 * image.c (gif_load): Add animation frame delay to the metadata.
7137 (syms_of_image): Use DEFSYM. New symbol `delay'.
7139 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7141 * window.c (delete_deletable_window): Re-add.
7142 (Fset_window_configuration): Rewrite to handle dead buffers and
7143 consequently deletable windows.
7144 (window_tree, Fwindow_tree): Remove. Supply functionality in
7146 (compare_window_configurations): Simplify code.
7148 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7150 * image.c (imagemagick_load_image): Fix type mismatch.
7151 (Fimagemagick_types): Likewise.
7153 * window.h (replace_buffer_in_windows): Declare.
7155 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7157 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7158 Qclone_number. Remove external declaration of Qdelete_window.
7159 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7161 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7162 Run Qbuffer_list_update_hook if allowed.
7163 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7164 buffer list implementation.
7165 (other_buffer_safely): New function.
7166 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7167 calls to replace_buffer_in_windows and
7168 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7170 (record_buffer): Inhibit quitting and rewrite using quittable
7171 functions. Run Qbuffer_list_update_hook if allowed.
7172 (Frecord_buffer, Funrecord_buffer): New functions.
7173 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7174 Move switch-to-buffer to window.el.
7175 (bury-buffer): Move to window.el.
7176 (Vbuffer_list_update_hook): New variable.
7178 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7181 * window.h (resize_frame_windows): Move up in code.
7182 (Fwindow_frame): Remove EXFUN.
7183 (replace_buffer_in_all_windows): Remove prototype.
7184 (replace_buffer_in_windows_safely): Add prototype.
7186 * window.c: Declare Qdelete_window static again. Move down
7187 declaration of select_count.
7188 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7189 (Fother_window): Move to window.el.
7190 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7191 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7192 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7194 (replace_buffer_in_windows): Implement by calling
7195 Qreplace_buffer_in_windows.
7196 (replace_buffer_in_all_windows): Remove with some functionality
7197 moved into replace_buffer_in_windows_safely.
7198 (replace_buffer_in_windows_safely): New function.
7199 (select_window_norecord, select_frame_norecord): Move in front
7200 of run_window_configuration_change_hook. Remove now obsolete
7202 (Fset_window_buffer): Rewrite doc-string.
7203 Call Qrecord_window_buffer.
7204 (keys_of_window): Move binding for other-window to window.el.
7206 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7208 * dispextern.h (struct image): Replace data member, whose int_val
7209 and ptr_val fields were not used by anything, with a single
7212 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7213 (gif_clear_image, gif_load, imagemagick_load_image)
7214 (gs_clear_image, gs_load): Callers changed.
7216 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7218 * buffer.h: Include <time.h>, for time_t.
7219 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7221 Fix minor problems found by static checking.
7223 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7225 Make identifiers static if they are not used in other modules.
7226 * data.c (Qcompiled_function, Qframe, Qvector):
7227 * image.c (QimageMagick, Qsvg):
7228 * minibuf.c (Qmetadata):
7229 * window.c (resize_window_check, resize_root_window): Now static.
7230 * window.h (resize_window_check, resize_root_window): Remove decls.
7232 * window.c (window_deletion_count, delete_deletable_window):
7234 (window_body_lines): Now static.
7235 (Fdelete_other_windows_internal): Mark vars as initialized.
7236 Make sure 'resize_failed' is initialized.
7237 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7238 (resize_window_apply): Remove unused local.
7239 * window.h (delete_deletable_window): Remove decl.
7241 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7242 (imagemagick_load_image): Fix pointer signedness problem by changing
7243 last arg from unsigned char * to char *. All uses changed.
7244 Also, fix a local for similar reasons.
7245 Remove unused locals. Remove locals to avoid shadowing.
7246 (fn_rsvg_handle_free): Remove; unused.
7247 (svg_load, svg_load_image): Fix pointer signedness problem.
7248 (imagemagick_load_image): Don't use garbage pointer image_wand.
7250 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7252 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7254 * image.c (gif_load): Fix omitted cast error introduced by
7257 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7259 * window.h (resize_proportionally, orig_total_lines)
7260 (orig_top_line): Remove from window structure.
7261 (set_window_height, set_window_width, change_window_heights)
7262 (Fdelete_window): Remove prototypes.
7263 (resize_frame_windows): Remove duplicate declaration.
7265 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7267 * window.h (resize_frame_windows, resize_window_check)
7268 (delete_deletable_window, resize_root_window)
7269 (resize_frame_windows): Declare prototypes.
7271 * window.c (resize_window_apply): Make definition be "static" to
7272 match the prototype.
7274 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7276 * window.c: Remove declarations of Qwindow_size_fixed,
7277 window_min_size_1, window_min_size_2, window_min_size,
7278 size_window, window_fixed_size_p, enlarge_window, delete_window.
7279 Remove static from declaration of Qdelete_window, it's
7280 temporarily needed by Fbury_buffer.
7281 (replace_window): Don't assign orig_top_line and
7283 (Fdelete_window, delete_window): Remove. Window deletion is
7284 handled by window.el.
7285 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7286 Replace Fdelete_window calls with calls to Qdelete_window.
7287 (Fdelete_other_windows): Remove. Deleting other windows is
7288 handled by window.el.
7289 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7290 handled in window.el.
7291 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7292 Window minimum sizes are handled in window.el.
7293 (shrink_windows, size_window, set_window_height)
7294 (set_window_width, change_window_heights, window_height)
7295 (window_width, CURBEG, CURSIZE, enlarge_window)
7296 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7297 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7298 handled in window.el.
7299 (make_dummy_parent): Rename to make_parent_window and give it a
7300 second argument horflag.
7301 (make_window): Don't set resize_proportionally any more.
7302 (Fsplit_window): Remove. Windows are split in window.el.
7303 (save_restore_action, save_restore_orig_size)
7304 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7305 Resize mini windows in window.el.
7306 (grow_mini_window, shrink_mini_window): Implement by calling
7307 Qresize_root_window_vertically, resize_window_check and
7308 resize_window_apply.
7309 (saved_window, Fset_window_configuration, save_window_save):
7310 Do not handle orig_top_line, orig_total_lines, and
7311 resize_proportionally.
7312 (window_min_height, window_min_width): Move to window.el.
7313 (keys_of_window): Move bindings for delete-other-windows,
7314 split-window, delete-window and enlarge-window to window.el.
7316 * buffer.c: Temporarily extern Qdelete_window.
7317 (Fbury_buffer): Temporarily call Qdelete_window instead of
7318 Fdelete_window (Fbury_buffer will move to window.el soon).
7320 * frame.c (set_menu_bar_lines_1): Remove code handling
7321 orig_top_line and orig_total_lines.
7323 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7324 set_window_height but set heights directly.
7325 (change_frame_size_1): Use resize_frame_windows.
7327 * xdisp.c (init_xdisp): Don't use set_window_height but set
7330 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7331 Use resize_frame_windows instead of change_window_heights and run
7332 run_window_configuration_change_hook.
7334 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7335 instead of change_window_heights and run
7336 run_window_configuration_change_hook.
7338 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7340 * window.c (replace_window): Rename second argument REPLACEMENT to
7341 NEW. New third argument SETFLAG. Rewrite.
7342 (delete_window, make_dummy_parent): Call replace_window with
7344 (window_list_1): Move down in code.
7345 (run_window_configuration_change_hook): Move set_buffer part
7346 before select_frame_norecord part in order to unwind correctly.
7347 Rename count1 to count.
7348 (recombine_windows, delete_deletable_window, resize_root_window)
7349 (Fdelete_other_windows_internal)
7350 (Frun_window_configuration_change_hook, make_parent_window)
7351 (resize_window_check, resize_window_apply, Fresize_window_apply)
7352 (resize_frame_windows, Fsplit_window_internal)
7353 (Fdelete_window_internal, Fresize_mini_window_internal):
7355 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7357 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7359 * window.h (window): Add some new members to window structure -
7360 normal_lines, normal_cols, new_total, new_normal, clone_number,
7361 splits, nest, prev_buffers, next_buffers.
7362 (WINDOW_TOTAL_SIZE): Move here from window.c.
7363 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7365 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7367 (make_dummy_parent): Set new members of windows structure.
7368 (make_window): Move down in code. Handle new members of window
7370 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7371 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7372 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7373 (Fset_window_prev_buffers, Fwindow_next_buffers)
7374 (Fset_window_next_buffers, Fset_window_clone_number):
7376 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7377 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7379 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7380 Argument WINDOW can be now internal window too.
7381 (Fwindow_use_time): Move up in code.
7382 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7384 (Fset_window_configuration, saved_window)
7385 (Fcurrent_window_configuration, save_window_save): Handle new
7386 members of window structure.
7387 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7388 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7389 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7390 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7391 Qget_mru_window, Qresize_root_window,
7392 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7393 Qauto_buffer_name; staticpro them.
7395 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7397 * window.c (Fwindow_total_size, Fwindow_left_column)
7398 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7399 (Fwindow_list_1): New functions.
7400 (window_box_text_cols): Replace with window_body_cols.
7401 (Fwindow_width, Fscroll_left, Fscroll_right):
7402 Use window_body_cols instead of window_box_text_cols.
7403 (delete_window, Fset_window_configuration):
7404 Call delete_all_subwindows with window as argument.
7405 (delete_all_subwindows): Take a window as argument and not a
7407 (window_loop): Remove handling of GET_LRU_WINDOW and
7409 (Fget_lru_window, Fget_largest_window): Move to window.el.
7411 * window.h: Extern window_body_cols instead of
7412 window_box_text_cols. delete_all_subwindows now takes a
7413 Lisp_Object as argument.
7415 * indent.c (compute_motion, Fcompute_motion):
7416 Use window_body_cols instead of window_box_text_cols.
7418 * frame.c (delete_frame): Call delete_all_subwindows with root
7421 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7423 * fns.c (Fputhash): Document return value.
7425 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7427 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7429 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7431 Cons<->int and similar integer overflow fixes (Bug#8794).
7433 Check for overflow when converting integer to cons and back.
7434 * charset.c (Fdefine_charset_internal, Fdecode_char):
7435 Use cons_to_unsigned to catch overflow.
7436 (Fencode_char): Use INTEGER_TO_CONS.
7437 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7438 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7439 * data.c (long_to_cons, cons_to_long): Remove.
7440 (cons_to_unsigned, cons_to_signed): New functions.
7441 These signal an error for invalid or out-of-range values.
7442 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7443 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7444 * font.c (Ffont_variation_glyphs):
7445 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7446 * lisp.h: Include <intprops.h>.
7447 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7448 (cons_to_signed, cons_to_unsigned): New decls.
7449 (long_to_cons, cons_to_long): Remove decls.
7450 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7451 (Fprimitive_undo): Use CONS_TO_INTEGER.
7452 * xfns.c (Fx_window_property): Likewise.
7453 * xselect.c: Include <limits.h>.
7454 (x_own_selection, selection_data_to_lisp_data):
7455 Use INTEGER_TO_CONS.
7456 (x_handle_selection_request, x_handle_selection_clear)
7457 (x_get_foreign_selection, Fx_disown_selection_internal)
7458 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7459 (lisp_data_to_selection_data): Use cons_to_unsigned.
7460 (x_fill_property_data): Use cons_to_signed.
7461 Report values out of range.
7463 Check for buffer and string overflow more precisely.
7464 * buffer.h (BUF_BYTES_MAX): New macro.
7465 * lisp.h (STRING_BYTES_MAX): New macro.
7466 * alloc.c (Fmake_string):
7467 * character.c (string_escape_byte8):
7468 * coding.c (coding_alloc_by_realloc):
7469 * doprnt.c (doprnt):
7470 * editfns.c (Fformat):
7472 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7473 since they may not be the same number.
7474 * editfns.c (Finsert_char):
7475 * fileio.c (Finsert_file_contents):
7476 Likewise for BUF_BYTES_MAX.
7478 * image.c: Use ptrdiff_t, not int, for sizes.
7479 (slurp_file): Switch from int to ptrdiff_t.
7481 (slurp_file): Check that file size fits in both size_t (for
7482 malloc) and ptrdiff_t (for sanity and safety).
7484 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7485 if b->modtime has its maximal value.
7487 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7489 Don't assume time_t can fit into int.
7490 * buffer.h (struct buffer.modtime): Now time_t, not int.
7491 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7492 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7494 Minor fixes for signed vs unsigned integers.
7495 * character.h (MAYBE_UNIFY_CHAR):
7496 * charset.c (maybe_unify_char):
7497 * keyboard.c (read_char, reorder_modifiers):
7498 XINT -> XFASTINT, since the integer must be nonnegative.
7499 * ftfont.c (ftfont_spec_pattern):
7500 * keymap.c (access_keymap, silly_event_symbol_error):
7501 XUINT -> XFASTINT, since the integer must be nonnegative.
7502 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7503 since it makes no difference and we prefer signed.
7504 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7505 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7508 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7510 * window.h (Fwindow_frame): Declare.
7512 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7514 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7515 (SPARE_MEMORY): Always define.
7516 (LARGE_REQUEST): Remove.
7517 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7519 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7521 * lisp.h: Move EXFUNS for Fframe_root_window,
7522 Fframe_first_window and Fset_frame_selected_window to window.h.
7524 * window.h: Move EXFUNS for Fframe_root_window,
7525 Fframe_first_window and Fset_frame_selected_window here from
7528 * frame.c (Fwindow_frame, Fframe_first_window)
7529 (Fframe_root_window, Fframe_selected_window)
7530 (Fset_frame_selected_window): Move to window.c.
7531 (Factive_minibuffer_window): Move to minibuf.c.
7532 (Fother_visible_frames_p): New function.
7534 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7536 * window.c (decode_window, decode_any_window): Move up in code.
7537 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7538 (inhibit_frame_unsplittable): Remove unused variable.
7539 (Fwindow_buffer): Move up and rewrite doc-string.
7540 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7541 (Fwindow_prev): New functions.
7542 (Fwindow_frame): Move here from frame.c. Accept any window as
7544 (Fframe_root_window, Fframe_first_window)
7545 (Fframe_selected_window): Move here from frame.c. Accept frame
7546 or arbitrary window as argument. Update doc-strings.
7547 (Fminibuffer_window): Move up in code.
7548 (Fwindow_minibuffer_p): Move up in code and simplify.
7549 (Fset_frame_selected_window): Move here from frame.c.
7551 (Fselected_window, select_window, Fselect_window): Move up in
7552 code. Minor doc-string fixes.
7554 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7556 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7557 Do not assume that spare memory exists; that assumption is valid
7558 only if SYSTEM_MALLOC.
7559 (LARGE_REQUEST): New macro, so that the issue of large requests
7560 is separated from the issue of spare memory.
7562 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7564 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7567 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7569 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7572 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7574 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7576 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7578 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7579 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7581 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7583 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7585 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7587 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7588 (x_clipboard_manager_save): Add return value.
7589 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7591 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7592 Obey Vx_select_enable_clipboard_manager. Catch errors in
7593 x_clipboard_manager_save (Bug#8779).
7594 (Vx_select_enable_clipboard_manager): New variable.
7595 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7597 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7599 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7601 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7603 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7604 in the current matrix if keep_current_p is non-zero.
7606 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7608 * bidi.c (bidi_level_of_next_char): Fix last change.
7610 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7612 Support bidi reordering of text covered by display properties.
7614 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7615 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7616 (bidi_cache_search, bidi_cache_iterator_state)
7617 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7618 (bidi_level_of_next_char, bidi_move_to_visually_next):
7619 Support character positions inside a run of characters covered by a
7621 (bidi_paragraph_init, bidi_resolve_explicit_1)
7622 (bidi_level_of_next_char): Call bidi_fetch_char and
7623 bidi_fetch_char_advance instead of FETCH_CHAR and
7625 (bidi_init_it): Initialize new members.
7626 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7628 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7629 instead of using explicit *_CHAR codes.
7630 (bidi_resolve_explicit, bidi_resolve_weak):
7631 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7632 bidirectional text is supported only in multibyte buffers.
7633 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7634 it to initialize the frame_window_p member of struct bidi_it.
7635 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7636 (bidi_resolve_explicit, bidi_resolve_weak)
7637 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7638 bidi_it->nchars is non-positive.
7639 (bidi_level_of_next_char): Don't try to lookup the cache for the
7640 next/previous character if nothing is cached there yet, or if we
7641 were just reseat()'ed to a new position.
7643 * xdisp.c (set_cursor_from_row): Set start and stop points
7644 according to the row's direction when priming the loop that looks
7645 for the glyph on which to display cursor.
7646 (single_display_spec_intangible_p): Function deleted.
7647 (display_prop_intangible_p): Reimplement to call
7648 handle_display_spec instead of single_display_spec_intangible_p.
7649 Accept 3 additional arguments needed by handle_display_spec.
7650 This fixes incorrect cursor motion across display property with complex
7651 values: lists, `(when COND...)' forms, etc.
7652 (single_display_spec_string_p): Support property values that are
7653 lists with the argument STRING its top-level element.
7654 (display_prop_string_p): Fix the condition for processing a
7655 property that is a list to be consistent with handle_display_spec.
7656 (handle_display_spec): New function, refactored from the
7657 last portion of handle_display_prop.
7658 (compute_display_string_pos): Accept additional argument
7659 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7660 value of a `display' property is a "replacing spec".
7661 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7662 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7663 the display property, but just return a value indicating whether
7664 the display property will replace the characters it covers.
7665 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7666 frame_window_p members of struct bidi_it.
7667 (compute_display_string_pos, compute_display_string_end):
7669 (push_it): Accept second argument POSITION, where pop_it should
7670 jump to continue iteration.
7671 (reseat_1): Initialize bidi_it.disp_pos.
7673 * keyboard.c (adjust_point_for_property): Adjust the call to
7674 display_prop_intangible_p to its new signature.
7676 * dispextern.h (struct bidi_it): New member frame_window_p.
7677 (bidi_init_it): Update prototypes.
7678 (display_prop_intangible_p): Update prototype.
7679 (compute_display_string_pos, compute_display_string_end):
7681 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7684 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7686 Malloc failure behavior now depends on size of allocation.
7687 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7688 * lisp.h: Change signatures accordingly.
7689 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7690 All callers changed. (Bug#8762)
7692 * gnutls.c: Use Emacs's memory allocators.
7693 Without this change, the gnutls library would invoke malloc etc.
7694 directly, which causes problems on non-SYNC_INPUT hosts, and which
7695 runs afoul of improving memory_full behavior. (Bug#8761)
7696 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7697 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7698 xfree instead of the default malloc, realloc, free.
7699 (Fgnutls_boot): No need to check for memory allocation failure,
7700 since xmalloc does that for us.
7702 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7703 * category.c (hash_get_category_set):
7704 * ccl.c (ccl_driver):
7705 * charset.c (Fdefine_charset_internal):
7706 * charset.h (struct charset.hash_index):
7707 * composite.c (get_composition_id, gstring_lookup_cache)
7708 (composition_gstring_put_cache):
7709 * composite.h (struct composition.hash_index):
7710 * dispextern.h (struct image.hash):
7711 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7712 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7713 (hashfn_equal, hashfn_user_defined, make_hash_table)
7714 (maybe_resize_hash_table, hash_lookup, hash_put)
7715 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7716 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7717 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7718 * image.c (make_image, search_image_cache, lookup_image)
7719 (xpm_put_color_table_h):
7720 * lisp.h (struct Lisp_Hash_Table):
7721 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7722 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7723 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7724 * alloc.c (allocate_vectorlike):
7725 Check for overflow in vector size calculations.
7726 * ccl.c (ccl_driver):
7727 Check for overflow when converting EMACS_INT to int.
7728 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7729 need to be updated by these changes.
7730 * fns.c (make_hash_table, maybe_resize_hash_table):
7731 Check for integer overflow with large hash tables.
7732 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7733 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7734 (SXHASH_REDUCE): New macro.
7735 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7736 Use it instead of discarding useful hash info with large hash values.
7737 (sxhash_float): New function.
7738 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7739 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7740 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7741 Rewrite to use FIXNUM_BITS, as this simplifies things.
7742 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7743 Adjust signatures to match updated version of code.
7744 (consing_since_gc): Now EMACS_INT, since a single hash table can
7745 use more than INT_MAX bytes.
7747 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7749 Make it possible to build with GCC-4.6+ -O2 -flto.
7751 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7753 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7755 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7756 Call minibuffer-inactive-mode.
7758 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7760 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7761 Update dependencies.
7763 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7765 * data.c (init_data): Remove code for UTS, this system is not
7768 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7770 Don't force ./temacs to start in terminal mode.
7772 * frame.c (make_initial_frame): Initialize faces in all cases, not
7773 only when CANNOT_DUMP is defined.
7774 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7776 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7778 * dispnew.c (add_window_display_history): Use const for the string
7779 pointer. Remove declaration, not needed.
7781 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7783 Use 'inline', not 'INLINE'.
7784 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7785 * alloc.c, fontset.c (INLINE): Remove.
7786 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7787 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7788 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7789 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7790 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7792 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7794 Make it possible to run ./temacs.
7796 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7797 syms_of_callproc does the same thing. Remove test for
7798 "initialized", do it in the caller.
7799 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7801 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7803 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7804 (read_minibuf): Use get_minibuffer.
7805 (syms_of_minibuf): Use DEFSYM.
7806 (Qmetadata): New var.
7807 * data.c (Qbuffer): Don't make it static.
7808 (syms_of_data): Use DEFSYM.
7810 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7812 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7813 (CCL_CODE_MIN): New macro.
7815 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7817 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7819 * eval.c (Qdebug): Now static.
7820 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7821 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7822 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7824 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7826 * image.c: Various fixes to ImageMagick code comments.
7827 (Fimagemagick_types): Doc fix.
7829 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7831 Minor fixes prompted by GCC 4.6.0 warnings.
7833 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7835 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7836 (x_clipboard_manager_save_all): Move extern decl to ...
7837 * xterm.h: ... here, so that it can be checked for consistency.
7839 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7841 * xselect.c (x_clipboard_manager_save_frame)
7842 (x_clipboard_manager_save_all): New functions.
7843 (Fx_clipboard_manager_save): Lisp function deleted.
7845 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7846 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7848 * xterm.h: Update prototype.
7850 2011-05-28 William Xu <william.xwl@gmail.com>
7852 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7855 2011-05-28 Jim Meyering <meyering@redhat.com>
7857 Avoid a sign-extension bug in crypto_hash_function.
7858 * fns.c (to_uchar): Define.
7859 (crypto_hash_function): Use it to convert some newly-signed
7860 variables to unsigned, to avoid sign-extension bugs. For example,
7861 without this change, (md5 "truc") would evaluate to
7862 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7863 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7864 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7866 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7868 Integer overflow fixes.
7870 * dbusbind.c: Serial number integer overflow fixes.
7871 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7872 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7873 to hold a serial number that is too large for a fixnum.
7874 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7875 Check for serial numbers out of range. Decode any serial number
7876 that was so large that it became a float. (Bug#8722)
7878 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7879 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7880 Use XFASTINT rather than XUINT when numbers are nonnegative.
7881 (xd_append_arg, Fdbus_method_return_internal):
7882 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7883 arguments, check that Lisp number is nonnegative, rather than
7884 silently wrapping negative numbers around. (Bug#8722)
7885 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7888 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7890 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7892 ccl: Add integer overflow checks.
7893 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7894 (IN_INT_RANGE): New macros.
7895 (ccl_driver): Use them to check for integer overflow when
7896 decoding a CCL program. Many of the new checks are whether XINT (x)
7897 fits in int; it doesn't always, on 64-bit hosts. The new version
7898 doesn't catch all possible integer overflows, but it's an
7899 improvement. (Bug#8719)
7901 * alloc.c (make_event_array): Use XINT, not XUINT.
7902 There's no need for unsigned here.
7904 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7905 This follows up to the 2011-05-06 change that substituted uintptr_t
7906 for EMACS_INT. This case wasn't caught back then.
7908 Rework Fformat to avoid integer overflow issues.
7909 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7910 now (part of C89). Include <verify.h>.
7911 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7912 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7913 (Fformat): Avoid the prepass trying to compute sizes; it was only
7914 approximate and thus did not catch overflow reliably. Instead, walk
7915 through the format just once, formatting and computing sizes as we go,
7916 checking for integer overflow at every step, and allocating a larger
7917 buffer as needed. Keep track separately whether the format is
7918 multibyte. Keep only the most-recently calculated precision, rather
7919 than them all. Record whether each argument has been converted to
7920 string. Use EMACS_INT, not int, for byte and char and arg counts.
7921 Support field widths and precisions larger than INT_MAX. Avoid
7922 sprintf's undefined behavior with conversion specifications such as %#d
7923 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7924 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7925 formatting out-of-range floating point numbers with int
7928 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7930 * data.c: Avoid integer truncation in expressions involving floats.
7931 * data.c: Include <intprops.h>.
7932 (arith_driver): When there's an integer overflow in an expression
7933 involving floating point, convert the integers to floating point
7934 so that the resulting value does not suffer from catastrophic
7935 integer truncation. For example, on a 64-bit host (* 4
7936 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7937 Do not rely on undefined behavior after integer overflow.
7939 merge count_size_as_multibyte, parse_str_to_multibyte
7940 * character.c, character.h (count_size_as_multibyte):
7941 Rename from parse_str_to_multibyte; all uses changed.
7942 Check for integer overflow.
7943 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7944 since it's now a duplicate of the other. This is more of
7945 a character than a buffer op, so better that it's in character.c.
7946 * fns.c, print.c: Adjust to above changes.
7948 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7950 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7952 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7954 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7955 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7956 (x_clipboard_manager_save): Now static.
7957 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7959 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7960 (crypto_hash_function): Now static.
7961 Fix pointer signedness problems. Avoid unnecessary initializations.
7963 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7965 * termhooks.h (Vselection_alist): Make it terminal-local.
7967 * terminal.c (create_terminal): Initialize it.
7969 * xselect.c: Support for clipboard managers.
7970 (Vselection_alist): Move to termhooks.h as terminal-local var.
7971 (LOCAL_SELECTION): New macro.
7972 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7973 (symbol_to_x_atom): Remove gratuitous arg.
7974 (x_handle_selection_request, lisp_data_to_selection_data)
7975 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7976 (x_own_selection, x_get_local_selection, x_convert_selection):
7977 New arg, specifying work frame. Use terminal-local Vselection_alist.
7978 (some_frame_on_display): Delete unused function.
7979 (Fx_own_selection_internal, Fx_get_selection_internal)
7980 (Fx_disown_selection_internal, Fx_selection_owner_p)
7981 (Fx_selection_exists_p): New optional frame arg.
7982 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7983 (x_handle_selection_clear): Don't treat other terminals with the
7984 same keyboard specially. Use the terminal-local Vselection_alist.
7985 (x_clear_frame_selections): Use Frun_hook_with_args.
7987 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7989 * xterm.h: Add support for those atoms.
7991 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7993 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7994 (converted_selections, conversion_fail_tag): New global variables.
7995 (x_selection_request_lisp_error): Free the above.
7996 (x_get_local_selection): Remove unnecessary code.
7997 (x_reply_selection_request): Args changed; handle arbitrary array
7998 of converted selections stored in converted_selections.
7999 Separate the XChangeProperty and SelectionNotify steps.
8000 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8001 (x_convert_selection): New function.
8002 (x_handle_selection_event): Simplify.
8003 (x_get_foreign_selection): Don't ignore incoming requests while
8004 waiting for an answer; this will fail when we implement
8005 SAVE_TARGETS, and seems unnecessary anyway.
8006 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8007 (Vx_sent_selection_functions): Doc fix.
8009 2011-05-26 Leo Liu <sdl.web@gmail.com>
8011 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8013 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8015 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8017 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8018 for fringe update if it has periodic bitmap.
8019 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8020 and fringe_bitmap_periodic_p.
8022 * fringe.c (get_fringe_bitmap_data): New function.
8023 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8024 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8025 row. Mark glyph row for fringe update if periodicity changed.
8027 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8028 for fringe update unless it has periodic bitmap.
8030 2011-05-25 Kenichi Handa <handa@m17n.org>
8032 * xdisp.c (get_next_display_element): Set correct it->face_id for
8033 a static composition.
8035 2011-05-24 Leo Liu <sdl.web@gmail.com>
8038 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8040 * fns.c (crypto_hash_function, Fsha1): New function.
8041 (Fmd5): Use crypto_hash_function.
8042 (syms_of_fns): Add Ssha1.
8044 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8046 * gnutls.c: Remove unused macros.
8047 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8048 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8049 Remove macros that are defined and never used.
8050 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8052 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8054 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8055 (Fx_get_selection_internal): Minor cleanup.
8056 (Fx_own_selection_internal): Rename arguments for consistency with
8059 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8061 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8063 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8065 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8067 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8069 * dispnew.c (scrolling_window): Don't exclude the case that the
8070 last enabled row in the desired matrix touches the bottom boundary.
8072 2011-05-21 Glenn Morris <rgm@gnu.org>
8074 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8075 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8076 and add some more files.
8078 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8080 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8081 report_file_error introduced by the change from 2011-05-07.
8083 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8085 * systime.h (Time): Define only if emacs is defined.
8086 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8087 where the include path doesn't have X11/X.h by default. See
8088 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8090 2011-05-20 Kenichi Handa <handa@m17n.org>
8092 * composite.c (find_automatic_composition): Fix previous change.
8094 2011-05-20 Glenn Morris <rgm@gnu.org>
8096 * lisp.mk: New file, split from Makefile.in.
8097 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8098 (shortlisp): Remove.
8099 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8101 2011-05-19 Glenn Morris <rgm@gnu.org>
8103 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8104 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8105 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8106 (lisp): Set the order to that of loadup.el.
8107 (shortlisp): Make it a copy of $lisp.
8108 (SOME_MACHINE_LISP): Remove.
8109 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8110 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8112 2011-05-18 Kenichi Handa <handa@m17n.org>
8114 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8115 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8116 (find_automatic_composition): Mostly rewrite for efficiency.
8118 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8120 * makefile.w32-in: Update dependencies.
8122 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8124 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8125 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8127 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8129 Fix some integer overflow issues, such as string length overflow.
8131 * insdel.c (count_size_as_multibyte): Check for string overflow.
8133 * character.c (lisp_string_width): Check for string overflow.
8134 Use EMACS_INT, not int, for string indexes and lengths; in
8135 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8136 the resulting string length overflows an EMACS_INT; instead,
8137 report a string overflow if no precision given. When checking for
8138 precision exhaustion, use a check that cannot possibly have
8139 integer overflow. (Bug#8675)
8140 * character.h (lisp_string_width): Adjust to new signature.
8142 * alloc.c (string_overflow): New function.
8143 (Fmake_string): Use it. This doesn't change behavior, but saves
8144 a few bytes and will simplify future changes.
8145 * character.c (string_escape_byte8): Likewise.
8146 * lisp.h (string_overflow): New decl.
8148 Fixups, following up to the user-interface timestamp change.
8149 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8150 for UI timestamps, instead of unsigned long.
8151 * msdos.c (mouse_get_pos): Likewise.
8152 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8153 * w32gui.h (Time): Define by including "systime.h" rather than by
8154 declaring it ourselves. (Bug#8664)
8156 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8157 * image.c (clear_image_cache): Likewise.
8159 * term.c (term_mouse_position): Don't assume time_t wraparound.
8161 Be more systematic about user-interface timestamps.
8162 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8163 and sometimes 'EMACS_UINT', to represent these timestamps.
8164 This change causes it to use 'Time' uniformly, as that's what X uses.
8165 This makes the code easier to follow, and makes it easier to catch
8166 integer overflow bugs such as Bug#8664.
8167 * frame.c (Fmouse_position, Fmouse_pixel_position):
8168 Use Time, not unsigned long, for user-interface timestamps.
8169 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8170 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8171 * keyboard.h (last_event_timestamp): Likewise.
8172 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8173 * menu.h (xmenu_show): Likewise.
8174 * term.c (term_mouse_position): Likewise.
8175 * termhooks.h (struct input_event.timestamp): Likewise.
8176 (struct terminal.mouse_position_hook): Likewise.
8177 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8178 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8179 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8180 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8182 * menu.h, termhooks.h: Include "systime.h", for Time.
8184 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8185 Don't assume that the difference between two unsigned long values
8186 can fit into an integer. At this point, we know button_down_time
8187 <= event->timestamp, so the difference must be nonnegative, so
8188 there's no need to cast the result if double-click-time is
8189 nonnegative, as it should be; check that it's nonnegative, just in
8190 case. This bug is triggered when events are more than 2**31 ms
8191 apart (about 25 days). (Bug#8664)
8193 * xselect.c (last_event_timestamp): Remove duplicate decl.
8194 (x_own_selection): Remove needless cast to unsigned long.
8196 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8197 that always fit in int. Use a sentinel instead of a counter, to
8198 avoid a temp and to allay GCC's concerns about possible int overflow.
8199 * frame.h (struct frame): Use int for menu_bar_items_used
8200 instead of EMACS_INT, since it always fits in int.
8202 * menu.c (grow_menu_items): Check for int overflow.
8204 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8206 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8207 Before, the code was not consistent. These values cannot exceed
8208 2**31 - 1 so there's no need to make them unsigned.
8209 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8210 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8211 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8213 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8215 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8216 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8217 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8218 presumably because the widths might not match.
8220 * window.c (size_window): Avoid needless test at loop start.
8222 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8224 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8226 2011-05-12 Drew Adams <drew.adams@oracle.com>
8228 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8230 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8232 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8233 `width' to `bar_area_x' and `bar_area_width', respectively.
8234 (x_scroll_run): Take account of fringe background extension.
8236 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8237 Rename local vars `left' and `width' to `bar_area_x' and
8238 `bar_area_width', respectively.
8239 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8240 background extension.
8242 2011-05-10 Jim Meyering <meyering@redhat.com>
8244 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8246 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8248 * image.c (Finit_image_library): Return t for built-in image types,
8249 like pbm and xbm. (Bug#8640)
8251 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8253 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8255 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8257 * w32console.c (Fset_screen_color): Doc fix.
8258 (Fget_screen_color): New function.
8259 (syms_of_ntterm): Defsubr it.
8261 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8262 unlink the temporary file if Fcall_process didn't create it in the
8264 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8265 child process will be redirected to a file specified with `:file'.
8266 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8267 cue to call_process_cleanup not to close that handle.
8269 2011-05-07 Ben Key <bkey76@gmail.com>
8271 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8272 one of two shell specific rules, either bootstrap-temacs-CMD or
8273 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8274 to the previous implementation of the bootstrap-temacs rule.
8275 The bootstrap-temacs-CMD rule is similar to the previous
8276 implementation of the bootstrap-temacs rule except that it
8277 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8280 These changes, along with some changes to nt/configure.bat,
8281 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8282 earlier fix to add support for --cflags and --ldflags options
8283 that include quotes so that it works whether make uses cmd or
8286 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8288 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8289 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8291 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8292 a string. Handle both cases.
8293 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8294 (Fdbus_register_method): Use Qinvalid_function.
8296 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8298 * makefile.w32-in: Update dependencies.
8299 (LISP_H): Add inttypes.h and stdin.h.
8300 (PROCESS_H): Add unistd.h.
8302 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8304 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8305 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8307 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8309 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8311 * term.c (vfatal): Remove stray call to va_end.
8312 It's not needed and the C Standard doesn't allow it here anyway.
8314 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8315 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8317 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8320 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8322 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8324 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8326 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8328 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8330 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8331 * charset.c (Fdefine_charset_internal): Don't initialize
8332 charset.code_space[15]. The value was garbage, on hosts with
8333 32-bit int (Bug#8600).
8335 * lread.c (read_integer): Be more consistent with string-to-number.
8336 Use string_to_number to do the actual conversion; this avoids
8337 rounding errors and fixes some other screwups. Without this fix,
8338 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8339 (digit_to_number): Move earlier, for benefit of read_integer.
8340 Return -1 if the digit is out of range for the base, -2 if it is
8341 not a digit in any supported base. (Bug#8602)
8343 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8345 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8346 to match comment at start of function. This also removes a
8347 GCC warning about overflow in a 32+64-bit port.
8349 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8351 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8352 Reported by Stefan Monnier in
8353 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8354 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8355 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8357 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8358 (EMACS_UINTPTR): Likewise, with uintptr_t.
8360 * lisp.h: Prefer 64-bit EMACS_INT if available.
8361 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8362 on 32-bit hosts that have 64-bit int, so that they can access
8364 However, temporarily disable this change unless the temporary
8365 symbol WIDE_EMACS_INT is defined.
8367 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8369 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8370 This removes an assumption that EMACS_INT and long are the same
8371 width as pointers. The assumption is true for Emacs porting targets
8372 now, but we want to make other targets possible.
8373 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8374 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8375 In the rest of the code, change types of integers that hold casted
8376 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8377 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8378 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8379 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8380 No need to cast type when ORing.
8381 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8382 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8383 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8384 assume EMACS_INT is the same width as char *.
8385 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8386 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8387 Remove no-longer-needed casts.
8388 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8389 (xg_tool_bar_help_callback, xg_make_tool_item):
8390 Use EMACS_INTPTR to hold an integer
8391 that will be cast to void *; this can avoid a GCC warning
8392 if EMACS_INT is not the same width as void *.
8393 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8394 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8395 (current_message_1, set_message_1):
8396 Use a local to convert to proper width without a cast.
8397 * xmenu.c (dialog_selection_callback): Likewise.
8399 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8400 Also, don't assume VALBITS / RAND_BITS is less than 5,
8401 and don't rely on undefined behavior when shifting a 1 left into
8403 * lisp.h (get_random): Change signature to match.
8405 * lread.c (hash_string): Use size_t, not int, for hash computation.
8406 Normally we prefer signed values; but hashing is special, because
8407 it's better to use unsigned division on hash table sizes so that
8408 the remainder is nonnegative. Also, size_t is the natural width
8409 for hashing into memory. The previous code used 'int', which doesn't
8410 retain enough info to hash well into very large tables.
8411 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8413 * dbusbind.c: Don't possibly lose pointer info when converting.
8414 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8415 Use XPNTR rather than XHASH, so that the high-order bits of
8416 the pointer aren't lost when converting through void *.
8418 * eval.c (Fautoload): Don't double-shift a pointer.
8420 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8422 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8424 * gnutls.c (DEF_GNUTLS_FN):
8425 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8427 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8429 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8432 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8434 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8435 New version that can reserve upto 2GB of heap space.
8437 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8439 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8441 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8443 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8444 `gnutls_certificate_set_x509_key_file'.
8446 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8448 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8449 Update dependencies.
8451 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8453 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8454 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8455 Remove unused parameter `fildes'.
8456 * process.c (read_process_output, send_process): Don't pass it.
8458 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8460 Fix previous change: the library cache is defined in w32.c.
8461 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8462 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8464 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8466 Implement dynamic loading of GnuTLS on Windows.
8468 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8469 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8470 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8473 * gnutls.c (Qgnutls_dll): Define.
8474 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8475 (gnutls_*): Declare function pointers.
8476 (init_gnutls_functions): New function to initialize function pointers.
8477 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8478 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8479 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8480 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8481 (emacs_gnutls_write, emacs_gnutls_read)
8482 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8483 (Fgnutls_available_p): New function.
8484 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8485 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8486 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8488 * image.c: Include w32.h.
8489 (Vimage_type_cache): Delete.
8490 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8491 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8492 (w32_delayed_load): Move to w32.c.
8494 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8496 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8497 (w32_delayed_load): Move from image.c. When loading a library, record
8498 its filename in the :loaded-from property of the library id.
8499 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8500 Initialize and staticpro them.
8501 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8503 * process.c: Include lisp.h before w32.h, not after.
8504 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8505 instead of gnutls_record_check_pending.
8507 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8509 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8511 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8512 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8515 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8517 * xterm.c (x_set_frame_alpha): Do not set property on anything
8518 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8520 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8522 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8524 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8526 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8527 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8528 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8529 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8530 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8531 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8532 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8533 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8534 (Qgnutls_bootprop_callbacks_verify): Make static.
8536 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8538 * callproc.c: Indentation fixup.
8540 * sysdep.c (wait_for_termination_1): Make static.
8541 (wait_for_termination, interruptible_wait_for_termination):
8542 Move after wait_for_termination_1.
8544 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8546 * sysdep.c (interruptible_wait_for_termination): New function
8547 which is like wait_for_termination, but allows keyboard
8550 * callproc.c (Fcall_process): Add (:file "file") as an option for
8552 (Fcall_process_region): Ditto.
8554 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8556 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8557 rather than `XVECTOR (FOO)->size'.
8559 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8560 inttypes.h, as a gnulib replacement is used if it not available in
8563 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8565 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8566 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8567 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8569 * coding.c (coding_alloc_by_realloc): Error out if destination
8570 will grow beyond MOST_POSITIVE_FIXNUM.
8571 (decode_coding_emacs_mule): Abort if there isn't enough place in
8572 charbuf for the composition carryover bytes. Reserve an extra
8573 space for up to 2 characters produced in a loop.
8574 (decode_coding_iso_2022): Abort if there isn't enough place in
8575 charbuf for the composition carryover bytes.
8577 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8579 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8580 aborting when %lld or %lll format is passed.
8581 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8582 %llo or %llx format is passed. (Bug#8545)
8584 * window.c (window_scroll_line_based): Use a marker instead of
8585 simple variables to record original value of point. (Bug#7952)
8587 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8588 produced by %s or %c overflows available buffer space. (Bug#8545)
8590 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8592 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8593 (SIZE_MAX): Move defn after all includes, as they might #define it.
8595 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8597 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8599 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8601 * keyboard.c (Qdelayed_warnings_hook): Define.
8602 (command_loop_1): Run `delayed-warnings-hook'
8603 if Vdelayed_warnings_list is non-nil.
8604 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8605 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8607 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8609 * doprnt.c (doprnt): Don't return value smaller than the buffer
8610 size if the message was truncated. (Bug#8545).
8612 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8614 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8615 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8617 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8619 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8621 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8623 * makefile.w32-in: Update dependencies.
8625 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8627 Improve `doprnt' and its usage. (Bug#8545)
8628 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8629 `format_end'. Remove support for %l as a conversion specifier.
8630 Don't use xrealloc. Improve diagnostics when the %l size modifier
8631 is used. Update the commentary.
8633 * eval.c (verror): Simplify calculation of size_t.
8635 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8638 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8640 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8643 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8645 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8646 This makes this file independent of the recent pseudovector change.
8648 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8650 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8652 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8653 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8654 Remove unused local.
8655 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8657 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8658 GCC 4.6.0 optimizes based on type-based alias analysis.
8659 For example, if b is of type struct buffer * and v of type struct
8660 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8661 != &v->size, and therefore "v->size = 1; b->size = 2; return
8662 v->size;" must therefore return 1. This assumption is incorrect
8663 for Emacs, since it type-puns struct Lisp_Vector * with many other
8664 types. To fix this problem, this patch adds a new type struct
8665 vectorlike_header that documents the constraints on layout of vectors
8666 and pseudovectors, and helps optimizing compilers not get fooled
8667 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8668 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8669 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8671 (XSETPVECTYPE): Rewrite in terms of new macro.
8672 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8673 This is a bit clearer, and further avoids the possibility of
8674 undesirable aliasing.
8675 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8676 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8677 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8678 since Lisp_Subr is a special case (no "next" field).
8679 (ASIZE): Now uses header.size rather than size.
8680 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8681 to avoid the hassle of writing XVECTOR (foo)->header.size.
8682 (struct vectorlike_header): New type.
8683 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8684 object, to help avoid aliasing.
8685 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8686 (SUBRP): Likewise, since Lisp_Subr is a special case.
8687 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8688 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8689 (struct Lisp_Hash_Table): Combine first two members into a single
8690 struct vectorlike_header member. All uses of "size" and "next" members
8691 changed to be "header.size" and "header.next".
8692 * buffer.h (struct buffer): Likewise.
8693 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8694 * frame.h (struct frame): Likewise.
8695 * process.h (struct Lisp_Process): Likewise.
8696 * termhooks.h (struct terminal): Likewise.
8697 * window.c (struct save_window_data, struct saved_window): Likewise.
8698 * window.h (struct window): Likewise.
8699 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8700 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8701 * buffer.c (init_buffer_once): Likewise.
8702 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8704 * process.c (Fformat_network_address): Use local var for size,
8707 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8709 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8710 * data.c (atof): Remove decl; no longer used or needed.
8711 (digit_to_number): Move to lread.c.
8712 (Fstring_to_number): Use new string_to_number function, to be
8713 consistent with how the Lisp reader treats infinities and NaNs.
8714 Do not assume that floating-point numbers represent EMACS_INT
8715 without losing information; this is not true on most 64-bit hosts.
8716 Avoid double-rounding errors, by insisting on integers when
8717 parsing non-base-10 numbers, as the documentation specifies.
8718 * lisp.h (string_to_number): New decl, replacing ...
8719 (isfloat_string): Remove.
8720 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8721 (read1): Do not accept +. and -. as integers; this
8722 appears to have been a coding error. Similarly, do not accept
8723 strings like +-1e0 as floating point numbers. Do not report
8724 overflow for integer overflows unless the base is not 10 which
8725 means we have no simple and reliable way to continue.
8726 Break out the floating-point parsing into a new
8727 function string_to_number, so that Fstring_to_number parses
8728 floating point numbers consistently with the Lisp reader.
8729 (digit_to_number): Move here from data.c. Make it static inline.
8730 (E_CHAR, EXP_INT): Remove, replacing with ...
8731 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8732 (string_to_number): New function, replacing isfloat_string.
8733 This function checks for valid syntax and produces the resulting
8734 Lisp float number too. Rework it so that string-to-number
8735 no longer mishandles examples like "1.0e+". Use strtoumax,
8736 so that overflow for non-base-10 numbers is reported only when
8737 there's no portable and simple way to convert to floating point.
8739 * textprop.c (set_text_properties_1): Rewrite for clarity,
8740 and to avoid GCC warning about integer overflow.
8742 * intervals.h (struct interval): Use EMACS_INT for members
8743 where EMACS_UINT might cause problems. See
8744 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8745 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8746 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8748 (offset_intervals): Tell GCC not to worry about length overflow
8749 when negating a negative length.
8751 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8752 (overrun_check_free): Likewise.
8754 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8755 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8758 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8759 (gnutls_make_error): Rename local to avoid shadowing.
8760 (gnutls_emacs_global_deinit): ifdef out; not used.
8761 (Fgnutls_boot): Use const for pointer to readonly storage.
8762 Comment out unused local. Fix pointer signedness problems.
8764 * lread.c (openp): Don't stuff size_t into an 'int'.
8765 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8766 about possible signed overflow.
8768 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8769 (GDK_KEY_g): Don't define if already defined.
8770 (xg_prepare_tooltip): Avoid pointer signedness problem.
8771 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8773 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8774 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8776 * xfns.c (Fx_window_property): Simplify a bit,
8777 to make a bit faster and to avoid GCC 4.6.0 warning.
8778 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8780 * fns.c (internal_equal): Don't assume size_t fits in int.
8782 * alloc.c (compact_small_strings): Tighten assertion a little.
8784 Replace pEd with more-general pI, and fix some printf arg casts.
8785 * lisp.h (pI): New macro, generalizing old pEd macro to other
8786 conversion specifiers. For example, use "...%"pI"d..." rather
8787 than "...%"pEd"...".
8788 (pEd): Remove. All uses replaced with similar uses of pI.
8789 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8790 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8791 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8792 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8793 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8794 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8795 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8797 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8798 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8799 * print.c (safe_debug_print, print_object): Likewise.
8800 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8802 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8803 avoiding the 0 flag, which is not portable.
8804 * process.c (Fmake_network_process): Use pI to avoid cast.
8805 * region-cache.c (pp_cache): Likewise.
8806 * xdisp.c (decode_mode_spec): Likewise.
8807 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8808 behavior on 64-bit hosts with printf arg.
8809 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8810 (x_stop_queuing_selection_requests): Likewise.
8811 (x_get_window_property): Don't truncate byte count to an 'int'
8814 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8815 here, since it parses constructs like leading '-' and spaces,
8816 which are not wanted; and it overflows with large numbers.
8817 Instead, simply match F[0-9]+, which is what is wanted anyway.
8819 * alloc.c: Remove unportable assumptions about struct layout.
8820 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8821 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8822 (allocate_vectorlike, make_pure_vector): Use the new macros,
8823 plus offsetof, to remove unportable assumptions about struct layout.
8824 These assumptions hold on all porting targets that I know of, but
8825 they are not guaranteed, they're easy to remove, and removing them
8826 makes further changes easier.
8828 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8829 This doesn't fix a bug but makes the code clearer.
8830 (string_overrun_cookie): Now const. Use initializers that
8831 don't formally overflow signed char, to avoid warnings.
8832 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8833 can cause Emacs to crash when string overrun checking is enabled.
8834 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8835 multiple of sizeof (EMACS_INT); it need not be, if
8836 alignof(EMACS_INT) < sizeof (EMACS_INT).
8837 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8839 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8841 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8843 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8845 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8846 supposed to be handshaking. (Bug#8556)
8847 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8849 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8851 * lisp.h (Qdebug): List symbol.
8852 * eval.c (Qdebug): Restore global linkage.
8853 * keyboard.c (debug-on-event): New variable.
8854 (handle_user_signal): Break into debugger when debug-on-event
8855 matches the current signal symbol.
8857 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8859 * alloc.c (check_sblock, check_string_bytes)
8860 (check_string_free_list): Convert to standard C.
8862 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8864 * w32.c (emacs_gnutls_push): Fix typo.
8866 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8868 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8869 "cast to pointer from integer of different size".
8871 Improve doprnt and its use in verror. (Bug#8545)
8872 * doprnt.c (doprnt): Document the set of format control sequences
8873 supported by the function. Use SAFE_ALLOCA instead of always
8876 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8877 is one byte too soon. Don't use xrealloc; instead xfree and
8880 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8882 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8885 * gnutls.c: Renamed global_initialized to
8886 gnutls_global_initialized. Added internals for the
8887 :verify-hostname-error, :verify-error, and :verify-flags
8888 parameters of `gnutls-boot' and documented those parameters in the
8889 docstring. Start callback support.
8890 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8891 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8892 on error. Return error code.
8893 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8894 (emacs_gnutls_read): Likewise.
8895 (Fgnutls_boot): Return handshake error code.
8896 (emacs_gnutls_handle_error): New function.
8897 (wsaerror_to_errno): Likewise.
8899 * w32.h (emacs_gnutls_pull): Add prototype.
8900 (emacs_gnutls_push): Likewise.
8902 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8903 (emacs_gnutls_push): Likewise.
8905 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8907 * process.c (wait_reading_process_output): Check if GnuTLS
8908 buffered some data internally if no FDs are set for TLS
8911 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8912 (LIBS): Link to USER_LIBS.
8913 ($(BLD)/gnutls.$(0)): New target.
8915 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8917 * xdisp.c (handle_single_display_spec): Rename the
8918 display_replaced_before_p argument into display_replaced_p, to
8919 make it consistent with the commentary. Fix typos in the
8922 * textprop.c (syms_of_textprop): Remove dead code.
8923 (copy_text_properties): Delete obsolete commentary about an
8924 interface that was deleted long ago. Fix typos in the description
8927 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8928 to changes in oldXMenu/XMenu.h from 2011-04-16.
8929 <menu_help_message, prev_menu_help_message>: Constify.
8930 (IT_menu_make_room): menu->help_text is now `const char **';
8933 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8934 to changes in oldXMenu/XMenu.h from 2011-04-16.
8935 (struct XMenu): Declare `help_text' `const char **'.
8937 * xfaces.c <Qunspecified>: Make extern again.
8939 * syntax.c: Include sys/types.h before including regex.h, as
8942 * doc.c (get_doc_string): Improve the format passed to `error'.
8944 * doprnt.c (doprnt): Improve commentary.
8946 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8948 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8951 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8952 changes in globals.h immediately force recompilation.
8953 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8954 $(CURDIR)/s/ms-w32.h.
8955 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8957 * character.c (Fchar_direction): Function deleted.
8958 (syms_of_character): Don't defsubr it.
8959 <char-direction-table>: Deleted.
8961 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8963 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8964 * doprnt.c: Include limits.h.
8965 (SIZE_MAX): New macro.
8966 (doprnt): Return a size_t value. 2nd arg is now size_t.
8967 Many local variables are now size_t instead of int or unsigned.
8968 Improve overflow protection. Support `l' modifier for integer
8969 conversions. Support %l conversion. Don't assume an EMACS_INT
8970 argument for integer conversions and for %c.
8972 * lisp.h (doprnt): Restore prototype.
8974 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8977 * Makefile.in (base_obj): Add back doprnt.o.
8979 * deps.mk (doprnt.o): Add back prerequisites.
8980 (callint.o): Depend on character.h.
8982 * eval.c (internal_lisp_condition_case): Include the handler
8983 representation in the error message.
8984 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8985 when breaking from the loop.
8987 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8989 * callint.c (Fcall_interactively): When displaying error message
8990 about invalid control letter, pass the character's codepoint, not
8991 a pointer to its multibyte form. Improve display of the character
8992 in octal and display also its hex code.
8994 * character.c (char_string): Use %x to display the (unsigned)
8995 codepoint of an invalid character, to avoid displaying a bogus
8998 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8999 `error', not SYMBOL_NAME itself.
9001 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9002 character arguments to `error'.
9004 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9005 to `error' in error message about FINAL_CHAR argument. Make sure
9006 FINAL_CHAR is a character, and use %c when it is passed as
9007 argument to `error'.
9009 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9011 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9013 * w32.c: Include <time.h>.
9014 (sys_localtime): New function.
9016 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9018 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9020 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9022 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9024 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9027 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9029 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9030 gl_state.e_property when gl_state.object is Qt.
9032 * insdel.c (make_gap_larger): Remove limitation of buffer size
9035 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9037 * xdisp.c (lookup_glyphless_char_display)
9038 (produce_glyphless_glyph): Handle cons cell entry in
9039 glyphless-char-display.
9040 (Vglyphless_char_display): Document it.
9042 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9043 glyphless-char-display.
9045 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9047 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9049 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9051 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9052 definition for no-X builds.
9054 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9056 Static checks with GCC 4.6.0 and non-default toolkits.
9058 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9060 * process.c (keyboard_bit_set): Define only if SIGIO.
9061 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9062 (send_process): Repair possible setjmp clobbering.
9064 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9066 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9068 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9070 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9071 Define only if needed.
9073 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9074 by pacifying GCC about it. Maybe it's time to retire it?
9075 * xfaces.c (USG, __TIMEVAL__): Likewise.
9077 * dispextern.h (struct redisplay_interface): Rename param
9079 * termhooks.h (struct terminal): Likewise.
9080 * xterm.c (xembed_send_message): Likewise.
9082 * insdel.c (make_gap_smaller): Define only if
9083 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9085 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9088 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9089 so that we aren't warned about unused symbols.
9091 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9093 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9095 * xfns.c (x_real_positions): Mark locals as initialized.
9097 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9099 * xterm.c: Fix problems found by static analysis with other toolkits.
9100 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9101 (x_dispatch_event): Declare static if USE_GTK, and
9102 define if USE_GTK || USE_X_TOOLKIT.
9103 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9104 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9105 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9106 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9108 * xmenu.c (menu_help_callback): Pointer type fixes.
9109 Use const pointers when pointing at readonly data. Avoid pointer
9111 (FALSE): Remove unused macro.
9112 (update_frame_menubar): Remove unused decl.
9114 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9116 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9117 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9118 (single_menu_item): Rename local to avoid shadowing.
9120 * keyboard.c (make_lispy_event): Remove unused local var.
9122 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9123 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9125 * bitmaps: Change bitmaps from unsigned char back to the X11
9126 compatible char. Avoid the old compiler warnings about
9127 out-of-range initializers by using, for example, '\xab' rather
9130 * xgselect.c (xgselect_initialize): Check vs interface
9131 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9133 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9135 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9136 to read-only memory.
9138 * fns.c (vector): Remove; this old hack is no longer needed.
9140 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9142 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9144 * xrdb.c (x_load_resources): Omit unused local.
9146 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9147 (x_window): Rename locals to avoid shadowing.
9148 (USG): Use the kludged USG macro, to pacify gcc.
9150 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9151 (x_term_init): Remove local to avoid shadowing.
9153 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9155 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9156 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9158 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9160 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9162 Fix regex.c, syntax.c and friends for buffers > 2GB.
9163 * syntax.h (struct gl_state_s): Declare character position members
9166 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9168 * textprop.c (verify_interval_modification, interval_of):
9169 Declare arguments EMACS_INT.
9171 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9174 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9176 * indent.c (Fvertical_motion): Local variable it_start is now
9179 * regex.c (re_match, re_match_2, re_match_2_internal)
9180 (bcmp_translate, regcomp, regexec, print_double_string)
9181 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9182 (re_compile_pattern, re_exec): Declare arguments and local
9183 variables `size_t' and `ssize_t' and return values `regoff_t', as
9185 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9186 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9187 <compile_stack_type>: `size' and `avail' are now `size_t'.
9189 * regex.h <regoff_t>: Use ssize_t, not int.
9190 (re_search, re_search_2, re_match, re_match_2): Arguments that
9191 specify buffer/string position and length are now ssize_t and
9192 size_t. Return type is regoff_t.
9194 2011-04-16 Ben Key <bkey76@gmail.com>
9196 * nsfont.m: Fixed bugs in ns_get_family and
9197 ns_descriptor_to_entity that were caused by using free to
9198 deallocate memory blocks that were allocated by xmalloc (via
9199 xstrdup). This caused Emacs to crash when compiled with
9200 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9201 --enable-checking=xmallocoverrun). xfree is now used to
9202 deallocate these memory blocks.
9204 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9206 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9208 emacs_write: Accept and return EMACS_INT for sizes.
9209 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9211 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9212 Accept and return EMACS_INT.
9213 (emacs_gnutls_write): Return the number of bytes written on
9215 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9216 (emacs_read, emacs_write): Remove check for negative size, as the
9217 Emacs source code has been audited now.
9218 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9219 (emacs_read, emacs_write): Use it.
9220 * process.c (send_process): Adjust to the new signatures of
9221 emacs_write and emacs_gnutls_write. Do not attempt to store
9222 a byte offset into an 'int'; it might overflow.
9223 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9225 * sound.c: Don't assume sizes fit in 'int'.
9226 (struct sound_device.period_size, alsa_period_size):
9227 Return EMACS_INT, not int.
9228 (struct sound_device.write, vox_write, alsa_write):
9229 Accept EMACS_INT, not int.
9230 (wav_play, au_play): Use EMACS_INT to store sizes and to
9231 record read return values.
9233 2011-04-15 Ben Key <bkey76@gmail.com>
9235 * keyboard.c (Qundefined): Don't declare static since it is used
9237 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9238 static since they are used in nsfont.m.
9240 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9242 * process.c (Qprocessp): Don't declare static.
9243 * lisp.h (Qprocessp): Declare again.
9245 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9247 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9249 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9251 Improve C-level modularity by making more things 'static'.
9253 Don't publish debugger-only interfaces to other modules.
9254 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9255 (verify_bytepos, count_markers): Move decls to the only modules
9257 * region-cache.h (pp_cache): Likewise.
9258 * window.h (check_all_windows): Likewise.
9259 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9261 * sysdep.c (croak): Now static, if
9262 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9263 * syssignal.h (croak): Declare only if not static.
9265 * alloc.c (refill_memory_reserve): Now static if
9266 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9267 * lisp.h (refill_memory_reserve): Declare only if not static.
9269 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9270 Define only if USE_LUCID.
9272 * xrdb.c (x_customization_string, x_rm_string): Now static.
9274 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9275 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9277 * xdisp.c (draw_row_with_mouse_face): Now static.
9278 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9280 * window.h (check_all_windows): Mark externally visible.
9282 * window.c (window_deletion_count): Now static.
9284 * undo.c: Make symbols static if they're not exported.
9285 (last_undo_buffer, last_boundary_position, pending_boundary):
9288 * textprop.c (interval_insert_behind_hooks): Now static.
9289 (interval_insert_in_front_hooks): Likewise.
9291 * term.c: Make symbols static if they're not exported.
9292 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9293 (max_frame_lines, tty_set_terminal_modes):
9294 (tty_reset_terminal_modes, tty_turn_off_highlight):
9295 (get_tty_terminal): Now static.
9296 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9297 * termhooks.h (term_mouse_moveto): Do not declare if
9299 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9300 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9302 * sysdep.c: Make symbols static if they're not exported.
9303 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9305 (sigprocmask_set, full_mask): Remove; unused.
9306 (wait_debugging): Mark as visible.
9307 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9308 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9310 * syntax.c (syntax_temp): Define only if !__GNUC__.
9312 * sound.c (current_sound_device, current_sound): Now static.
9314 * search.c (searchbufs, searchbuf_head): Now static.
9316 * scroll.c (scroll_cost): Remove; unused.
9317 * dispextern.h (scroll_cost): Remove decl.
9319 * region-cache.h (pp_cache): Mark as externally visible.
9321 * process.c: Make symbols static if they're not exported.
9322 (process_tick, update_tick, create_process, chan_process):
9323 (Vprocess_alist, proc_buffered_char, datagram_access):
9324 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9325 (deactivate_process): Mark defn as static, as well as decl.
9326 * lisp.h (create_process): Remove decl.
9327 * process.h (chan_process, Vprocess_alist): Remove decls.
9329 * print.c: Make symbols static if they're not exported.
9330 (print_depth, new_backquote_output, being_printed, print_buffer):
9331 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9332 (print_interval, print_number_index, initial_stderr_stream):
9334 * lisp.h (Fprinc): Remove decl.
9335 (debug_output_compilation_hack): Mark as externally visible.
9337 * sysdep.c (croak): Move decl from here to syssignal.h.
9338 * syssignal.h (croak): Put it here, so the API can be checked when
9339 'croak' is called from dissociate_if_controlling_tty.
9341 * minibuf.c: Make symbols static if they're not exported.
9342 (minibuf_save_list, choose_minibuf_frame): Now static.
9343 * lisp.h (choose_minibuf_frame): Remove decl.
9345 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9347 * lread.c: Make symbols static if they're not exported.
9348 (read_objects, initial_obarray, oblookup_last_bucket_number):
9350 (make_symbol): Remove; unused.
9351 * lisp.h (initial_obarray, make_symbol): Remove decls.
9353 * keyboard.c: Make symbols static if they're not exported.
9354 (single_kboard, recent_keys_index, total_keys, recent_keys):
9355 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9356 (this_single_command_key_start, echoing, last_auto_save):
9357 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9358 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9359 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9360 (Vlispy_mouse_stem, double_click_count):
9362 (force_auto_save_soon): Define only if SIGDANGER.
9363 (ignore_mouse_drag_p): Now static if
9364 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9365 (print_help): Remove; unused.
9366 (stop_character, last_timer_event): Mark as externally visible.
9367 * keyboard.h (ignore_mouse_drag_p): Declare only if
9368 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9369 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9370 * lisp.h (echoing): Remove decl.
9371 (force_auto_save_soon): Declare only if SIGDANGER.
9372 * xdisp.c (redisplay_window): Simplify code, to make it more
9373 obvious that ignore_mouse_drag_p is not accessed if !defined
9374 USE_GTK && !defined HAVE_NS.
9376 * intervals.c: Make symbols static if they're not exported.
9377 (merge_properties_sticky, merge_interval_right, delete_interval):
9379 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9381 * insdel.c: Make symbols static if they're not exported.
9382 However, leave prepare_to_modify_buffer alone. It's never
9383 called from outside this function, but that appears to be a bug.
9384 (combine_after_change_list, combine_after_change_buffer):
9385 (adjust_after_replace, signal_before_change): Now static.
9386 (adjust_after_replace_noundo): Remove; unused.
9387 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9388 (signal_before_change): Remove decls.
9390 * indent.c (val_compute_motion, val_vmotion): Now static.
9392 * image.c: Make symbols static if they're not exported.
9393 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9395 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9396 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9398 * fringe.c (standard_bitmaps): Now static.
9399 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9401 * frame.c: Make symbols static if they're not exported.
9402 (x_report_frame_params, make_terminal_frame): Now static.
9403 (get_frame_param): Now static, unless HAVE_NS.
9404 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9405 (x_get_resource_string): Remove; not used.
9406 * frame.h (make_terminal_frame, x_report_frame_params):
9407 (x_get_resource_string); Remove decls.
9408 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9409 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9411 * font.c, fontset.c: Make symbols static if they're not exported.
9412 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9413 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9414 * font.c (font_close_object): Now static.
9415 * font.h (font_close_object): Remove.
9416 * fontset.c (FONTSET_OBJLIST): Remove.
9417 (free_realized_fontset) #if-0 the body, which does nothing.
9418 (face_suitable_for_char_p): #if-0, as it's never called.
9419 * fontset.h (face_suitable_for_char_p): Remove decl.
9420 * xfaces.c (face_at_string_position):
9421 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9422 since 0 is always ASCII.
9424 * fns.c (weak_hash_tables): Now static.
9426 * fileio.c: Make symbols static if they're not exported.
9427 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9428 (Vwrite_region_annotation_buffers): Now static.
9430 * eval.c: Make symbols static if they're not exported.
9431 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9432 * lisp.h (backtrace_list): Remove decl.
9434 * emacs.c: Make symbols static if they're not exported.
9435 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9436 (fatal_error_code, fatal_error_signal_hook, standard_args):
9438 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9439 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9440 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9441 * lisp.h (fatal_error_signal_hook): Remove decl.
9442 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9444 * editfns.c: Move a (normally-unused) function to its only use.
9445 * editfns.c, lisp.h (get_operating_system_release): Remove.
9446 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9447 worth the hassle of breaking this out.
9449 * xterm.c: Make symbols static if they're not exported.
9450 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9451 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9452 (x_destroy_window, x_delete_display):
9454 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9455 (x_mouse_leave): Remove; unused.
9456 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9457 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9458 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9460 (x_mouse_leave): Declare only if WINDOWSNT.
9461 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9462 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9465 * ftxfont.c: Make symbols static if they're not exported.
9466 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9468 * font.h (ftxfont_driver): Likewise.
9470 * xfns.c: Make symbols static if they're not exported.
9471 (x_last_font_name, x_display_info_for_name):
9472 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9473 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9474 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9475 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9476 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9477 (last_show_tip_args): Now static.
9478 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9479 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9480 (x_screen_planes): Remove; unused.
9481 * dispextern.h (x_screen_planes): Remove decl.
9483 * dispnew.c: Make symbols static if they're not exported.
9484 * dispextern.h (redraw_garbaged_frames, scrolling):
9485 (increment_row_positions): Remove.
9486 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9487 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9489 (redraw_garbaged_frames): Remove; unused.
9491 * xfaces.c: Make symbols static if they're not exported.
9492 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9494 * xterm.h (defined_color): Remove decls.
9495 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9496 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9497 (menu_face_changed_default, defined_color, free_realized_face):
9498 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9499 (ascii_face_of_lisp_face): Remove; unused.
9501 * xdisp.c: Make symbols static if they're not exported.
9502 * dispextern.h (scratch_glyph_row, window_box_edges):
9503 (glyph_to_pixel_coords, set_cursor_from_row):
9504 (get_next_display_element, set_iterator_to_next):
9505 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9506 (show_mouse_face): Remove decls
9507 * frame.h (message_buf_print): Likewise.
9508 * lisp.h (pop_message, set_message, check_point_in_composition):
9510 * xterm.h (set_vertical_scroll_bar): Likewise.
9511 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9512 (message_buf_print, scratch_glyph_row, displayed_buffer):
9513 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9514 (get_next_display_element, show_mouse_face, window_box_edges):
9515 (frame_to_window_pixel_xy, check_point_in_composition):
9516 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9517 (glyph_to_pixel_coords): Remove; unused.
9519 * dired.c (file_name_completion): Now static.
9521 * dbusbind.c (xd_in_read_queued_messages): Now static.
9523 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9524 * data.c (circular_list_error): Remove.
9526 * commands.h (last_point_position, last_point_position_buffer):
9527 (last_point_position_window): Remove decls.
9528 * keyboard.c: Make these variables static.
9530 * coding.h (coding, code_convert_region, encode_coding_gap):
9532 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9533 (iso_code_class, detect_coding, code_convert_region): Now static.
9534 (encode_coding_gap): Remove; unused.
9536 * chartab.c (chartab_chars, chartab_bits): Now static.
9538 * charset.h (charset_iso_8859_1): Remove decl.
9539 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9542 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9543 * ccl.c (Vccl_program_table): Now static.
9544 (check_ccl_update): Remove; unused.
9546 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9547 * category.h: ... from here.
9548 * category.c (check_category_table, set_category_set): Now static.
9550 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9551 * lisp.h: Remove these decls.
9553 * buffer.c (buffer_count): Remove unused var.
9555 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9556 so that it's not optimized away.
9557 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9558 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9559 exported only to the debugger.
9561 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9562 * atimer.h (run_all_atimers): Remove; not exported.
9564 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9565 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9566 was inaccessible from Lisp.
9567 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9568 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9570 alloc.c: Import and export fewer symbols, and remove unused items.
9571 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9573 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9574 it's not optimized away by whole-program optimization.
9575 (message_enable_multibyte, free_misc): Remove.
9576 (catchlist, handlerlist, mark_backtrace):
9577 Declare only if BYTE_MARK_STACK.
9578 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9579 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9580 (message_enable_multibyte): Remove decl.
9581 (free_misc, interval_free_list, float_block, float_block_index):
9582 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9583 (cons_free_list, last_marked_index):
9585 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9586 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9587 (mark_backtrace): Define only if BYTE_MARK_STACK.
9588 * xdisp.c (message_enable_multibyte): Now static.
9590 Declare Lisp_Object Q* variables to be 'static' if not exported.
9591 This makes it easier for human readers (and static analyzers)
9592 to see whether these variables are used from other modules.
9593 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9594 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9595 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9596 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9597 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9598 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9599 * xmenu.c, xselect.c:
9600 Declare Q* vars static if they are not used in other modules.
9601 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9602 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9603 Remove decls of unexported vars.
9604 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9606 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9608 Make Emacs functions such as Fatom 'static' by default.
9609 This makes it easier for human readers (and static analyzers)
9610 to see whether these functions can be called from other modules.
9611 DEFUN now defines a static function. To make the function external
9612 so that it can be used in other C modules, use the new macro DEFUE.
9613 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9614 (Finit_image_library):
9615 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9616 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9617 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9618 Remove decls, since these functions are now static.
9619 (Funintern, Fget_internal_run_time): New decls, since these functions
9620 were already external.
9622 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9623 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9624 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9625 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9626 * keyboard.c, keymap.c, lread.c:
9627 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9628 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9629 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9630 Mark functions with DEFUE instead of DEFUN,
9631 if they are used in other modules.
9632 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9633 decls for now-static functions.
9634 * buffer.h (Fdelete_overlay): Remove decl.
9635 * callproc.c (Fgetenv_internal): Mark as internal.
9636 * composite.c (Fremove_list_of_text_properties): Remove decl.
9637 (Fcomposition_get_gstring): New forward static decl.
9638 * composite.h (Fcomposite_get_gstring): Remove decl.
9639 * dired.c (Ffile_attributes): New forward static decl.
9640 * doc.c (Fdocumntation_property): New forward static decl.
9641 * eval.c (Ffetch_bytecode): New forward static decl.
9642 (Funintern): Remove extern decl; now in .h file where it belongs.
9643 * fileio.c (Fmake_symbolic_link): New forward static decl.
9644 * image.c (Finit_image_library): New forward static decl.
9645 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9646 * intervals.h (Fprevious_property_change):
9647 (Fremove_list_of_text_properties): Remove decls.
9648 * keyboard.c (Fthis_command_keys): Remove decl.
9649 (Fcommand_execute): New forward static decl.
9650 * keymap.c (Flookup_key): New forward static decl.
9651 (Fcopy_keymap): Now static.
9652 * keymap.h (Flookup_key): Remove decl.
9653 * process.c (Fget_process): New forward static decl.
9654 (Fprocess_datagram_address): Mark as internal.
9655 * syntax.c (Fsyntax_table_p): New forward static decl.
9656 (skip_chars): Remove duplicate decl.
9657 * textprop.c (Fprevious_property_change): New forward static decl.
9658 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9660 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9661 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9663 * editfns.c (Fformat): Remove unreachable code.
9665 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9667 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9670 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9672 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9673 when at ZV. (Bug#8487)
9675 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9677 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9679 * keyboard.c (parse_tool_bar_item): Likewise.
9680 * sound.c (sound_cleanup, alsa_close): Likewise.
9681 * termcap.c (tgetent): Likewise.
9682 * xfns.c (x_default_font_parameter): Likewise.
9683 * xsettings.c (read_and_apply_settings): Likewise.
9685 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9686 (overrun_check_free): Protoize.
9688 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9690 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9691 since callers should never pass a negative size.
9692 Change the signature to match that of plain 'read' and 'write'; see
9693 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9694 * lisp.h: Update prototypes of emacs_write and emacs_read.
9696 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9698 * xdisp.c (redisplay_window): Don't try to determine the character
9699 position of the scroll margin if the window start point w->startp
9700 is outside the buffer's accessible region. (Bug#8468)
9702 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9704 Fix write-region and its subroutines for buffers > 2GB.
9705 * fileio.c (a_write, e_write): Modify declaration of arguments and
9706 local variables to support buffers larger than 2GB.
9707 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9709 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9710 argument, local variables, and return value.
9712 * lisp.h: Update prototypes of emacs_write and emacs_read.
9714 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9716 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9718 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9720 Fix more problems found by GCC 4.6.0's static checks.
9722 * xdisp.c (vmessage): Use a better test for character truncation.
9724 * charset.c (load_charset_map): <, not <=, for optimization,
9725 and to avoid potential problems with integer overflow.
9726 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9727 * casetab.c (set_identity, shuffle): Likewise.
9728 * editfns.c (Fformat): Likewise.
9729 * syntax.c (skip_chars): Likewise.
9731 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9732 This also lets GCC 4.6.0 generate slightly better loop code.
9734 * callint.c (Fcall_interactively): <, not <=, for optimization.
9735 (Fcall_interactively): Count the number of arguments produced,
9736 not the number of arguments given. This is simpler and lets GCC
9737 4.6.0 generate slightly better code.
9739 * ftfont.c: Distingish more carefully between FcChar8 and char.
9740 The previous code passed unsigned char * to a functions like
9741 strlen and xstrcasecmp that expect char *, which does not
9742 conform to the C standard.
9743 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9744 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9745 char * when the C standard requires it.
9747 * keyboard.c (read_char): Remove unused var.
9749 * eval.c: Port to Windows vsnprintf (Bug#8435).
9751 (SIZE_MAX): Define if the headers do not.
9752 (verror): Do not give up if vsnprintf returns a negative count.
9753 Instead, grow the buffer. This ports to Windows vsnprintf, which
9754 does not conform to C99. Problem reported by Eli Zaretskii.
9755 Also, simplify the allocation scheme, by avoiding the need for
9756 calling realloc, and removing the ALLOCATED variable.
9758 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9760 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9761 But keep the doprint source code for now, as we might revamp it
9762 and use it again (Bug#8435).
9763 * lisp.h (doprnt): Remove.
9764 * Makefile.in (base_obj): Remove doprnt.o.
9765 * deps.mk (doprnt.o): Remove.
9767 error: Print 32- and 64-bit integers portably (Bug#8435).
9768 Without this change, on typical 64-bit hosts error ("...%d...", N)
9769 was used to print both 32- and 64-bit integers N, which relied on
9771 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9772 * lisp.h (error, verror): Mark as printf-like functions.
9773 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9774 Report overflow in size calculations when allocating printf buffer.
9775 Do not truncate output string at its first null byte.
9776 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9777 Truncate the output at a character boundary, since vsnprintf does not
9779 * charset.c (check_iso_charset_parameter): Convert internal
9780 character to string before calling 'error', since %c now has the
9782 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9783 overflow when computing char to be passed to 'error'. Do not
9784 pass Lisp_Object to 'error'; pass the integer instead.
9785 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9786 formatted with plain %d.
9788 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9790 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9792 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9794 * xterm.c (x_catch_errors): Remove duplicate declaration.
9796 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9798 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9800 2011-04-10 Jim Meyering <meyering@redhat.com>
9802 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9803 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9804 return ssize_t not "int", and use size_t as the buffer length.
9805 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9806 * gnutls.h: Update declarations.
9807 * process.c (read_process_output): Use ssize_t, to match.
9808 (send_process): Likewise.
9810 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9812 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9814 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9816 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9817 Use unsigned char, to match FcChar8 type definition.
9819 * xterm.c (handle_one_xevent):
9820 * xmenu.c (create_and_show_popup_menu):
9821 * xselect.c (x_decline_selection_request)
9822 (x_reply_selection_request): Avoid type-punned deref of X events.
9824 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9826 Fix some uses of `int' instead of EMACS_INT.
9827 * search.c (string_match_1, fast_string_match)
9828 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9829 (scan_buffer, find_next_newline_no_quit)
9830 (find_before_next_newline, search_command, Freplace_match)
9831 (Fmatch_data): Make some `int' variables be EMACS_INT.
9833 * xdisp.c (display_count_lines): 3rd argument and return value now
9834 EMACS_INT. All callers changed.
9835 (pint2hrstr): Last argument is now EMACS_INT.
9837 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9838 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9839 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9840 (decode_coding_utf_16, decode_coding_emacs_mule)
9841 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9842 (decode_coding_ccl, decode_coding_charset)
9843 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9844 (decode_coding_iso_2022, decode_coding_emacs_mule)
9845 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9846 <char_offset, last_offset>: Declare EMACS_INT.
9847 (encode_coding_utf_8, encode_coding_utf_16)
9848 (encode_coding_emacs_mule, encode_invocation_designation)
9849 (encode_designation_at_bol, encode_coding_iso_2022)
9850 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9851 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9853 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9854 (encode_invocation_designation): Last argument P_NCHARS is now
9856 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9857 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9859 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9862 * ccl.c (Fccl_execute_on_string): Declare some variables
9865 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9867 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9869 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9871 * process.c (Fformat_network_address): Doc fix.
9873 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9875 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9877 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9879 * keyboard.c (read_char): Call Lisp function help-form-show,
9880 instead of using internal_with_output_to_temp_buffer.
9881 (Qhelp_form_show): New var.
9882 (syms_of_keyboard): Use DEFSYM macro.
9884 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9886 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9888 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9890 * process.c (Flist_processes): Remove to Lisp.
9891 (list_processes_1): Delete.
9893 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9895 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9897 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9899 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9901 Fix more problems found by GCC 4.6.0's static checks.
9903 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9905 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9907 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9909 * xdisp.c (vmessage): Mark as a printf-like function.
9911 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9913 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9915 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9916 printf-like functions.
9917 (tiff_load): Add casts to remove these marks before passing them
9918 to system-supplied API.
9920 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9922 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9923 This avoids several warnings with gcc -Wstrict-overflow.
9924 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9925 directly, rather than having caller test rule sign. This avoids
9926 some unnecessary tests.
9927 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9928 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9929 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9931 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9932 (xfont_open): Avoid unnecessary tests.
9934 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9936 * composite.h, composite.c (composition_gstring_put_cache):
9937 Use EMACS_INT, not int, for length.
9939 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9940 breaking out part of COMPOSITION_DECODE_RULE.
9941 (COMPOSITION_DECODE_RULE): Use it.
9942 * composite.c (get_composition_id): Remove unused local vars,
9943 by using the new macro.
9945 * textprop.c (set_text_properties_1): Change while to do-while,
9946 since the condition is always true at first.
9948 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9949 (interval_deletion_adjustment): Return unsigned value.
9952 * process.c (list_processes_1, create_pty, read_process_output):
9953 (exec_sentinel): Remove vars that were set but not used.
9954 (create_pty): Remove unnecessary "volatile"s.
9955 (Fnetwork_interface_info): Avoid possibility of int overflow.
9956 (read_process_output): Do adaptive read buffering even if carryover.
9957 (read_process_output): Simplify nbytes computation if buffered.
9959 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9961 * syntax.c (scan_words): Remove var that was set but not used.
9962 (update_syntax_table): Use unsigned instead of int.
9964 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9965 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9966 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9968 * print.c (print_error_message): Avoid int overflow.
9970 * font.c (font_list_entities): Redo for clarity,
9971 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9973 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9974 (font_score): Avoid potential overflow in diff calculation.
9976 * fns.c (substring_both): Remove var that is set but not used.
9977 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9979 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9981 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9982 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9983 can always succeed if overflow has undefined behavior.
9985 * search.c (boyer_moore, wordify): Remove vars set but not used.
9986 (wordify): Omit three unnecessary tests.
9988 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9989 All callers changed. This avoids the need for an unused var.
9991 * casefiddle.c (casify_region): Remove var that is set but not used.
9993 * dired.c (file_name_completion): Remove var that is set but not used.
9995 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9997 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9998 (Finsert_file_contents): Remove unnecessary code checking fd.
10000 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10001 Check for integer overflow on size calculations.
10003 * buffer.c (Fprevious_overlay_change): Remove var that is set
10006 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10007 Remove vars that are set but not used.
10008 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10009 (timer_check_2): Mark vars as initialized.
10011 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10013 * image.c (lookup_image): Remove var that is set but not used.
10014 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10016 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10017 that are set but not used.
10019 * xfns.c (make_invisible_cursor): Don't return garbage
10020 if XCreateBitmapFromData fails (Bug#8410).
10022 * xselect.c (x_get_local_selection, x_handle_property_notify):
10023 Remove vars that are set but not used.
10025 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10026 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10028 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10029 Remove var that is set but not used.
10030 (scroll_bar_windows_size): Now size_t, not int.
10031 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10032 Check for overflow.
10034 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10035 (map_tty_color) [!defined MSDOS]: Likewise.
10037 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10039 * coding.c: Remove vars that are set but not used.
10040 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10041 All callers changed.
10042 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10043 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10044 (decode_coding_charset): Remove vars that are set but not used.
10046 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10047 that is set but not used.
10049 * print.c (print_object): Remove var that is set but not used.
10051 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10052 The gnulib version avoids calling malloc in the usual case,
10053 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10054 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10055 * filelock.c (current_lock_owner): Likewise.
10056 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10057 * sysdep.c: Include allocator.h, careadlinkat.h.
10058 (emacs_no_realloc_allocator): New static constant.
10059 (emacs_readlink): New function.
10060 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10061 ../lib/careadlinkat.h.
10063 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10065 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10066 first non-nil return value).
10068 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10070 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10071 if not defined (Bug#8403).
10073 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10075 * xdisp.c (display_count_lines): Remove parameter `start',
10076 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10077 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10078 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10079 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10080 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10081 and thereabouts. All callers changed.
10082 (get_per_char_metric): Remove parameter `f', unused since
10083 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10085 2011-04-02 Jim Meyering <meyering@redhat.com>
10087 do not dereference NULL upon failed strdup
10088 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10089 (ns_get_family): Likewise.
10091 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10093 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10095 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10097 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10100 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10102 Add lexical binding.
10104 * window.c (Ftemp_output_buffer_show): New fun.
10105 (Fsave_window_excursion):
10106 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10108 * lread.c (lisp_file_lexically_bound_p): New function.
10109 (Fload): Bind Qlexical_binding.
10110 (readevalloop): Remove `evalfun' arg.
10111 Bind Qinternal_interpreter_environment.
10112 (Feval_buffer): Bind Qlexical_binding.
10113 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10115 (syms_of_lread): Declare `lexical-binding'.
10117 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10119 * keyboard.c (eval_dyn): New fun.
10120 (menu_item_eval_property): Use it.
10122 * image.c (parse_image_spec): Use Ffunctionp.
10124 * fns.c (concat, mapcar1): Accept byte-code-functions.
10126 * eval.c (Fsetq): Handle lexical vars.
10127 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10128 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10129 (FletX, Flet): Obey lexical binding.
10130 (Fcommandp): Handle closures.
10131 (Feval): New `lexical' arg.
10132 (eval_sub): New function extracted from Feval. Use it almost
10133 everywhere where Feval was used. Look up vars in lexical env.
10135 (Ffunctionp): Move from subr.el.
10136 (Ffuncall): Handle closures.
10137 (apply_lambda): Remove `eval_flags'.
10138 (funcall_lambda): Handle closures and new byte-code-functions.
10139 (Fspecial_variable_p): New function.
10140 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10141 but without exporting it to Lisp.
10143 * doc.c (Fdocumentation, store_function_docstring):
10144 * data.c (Finteractive_form): Handle closures.
10146 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10149 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10151 (exec_byte_code): New function extracted from Fbyte_code to handle new
10152 calling convention for byte-code-functions. Add new byte-codes.
10154 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10156 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10158 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10160 * xdisp.c (redisplay_internal): Fix prototype.
10162 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10164 * xdisp.c (SCROLL_LIMIT): New macro.
10165 (try_scrolling): Use it when setting scroll_limit.
10166 Limit scrolling to 100 screen lines.
10167 (redisplay_window): Even when falling back on "recentering",
10168 position point in the window according to scroll-conservatively,
10169 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10171 (try_scrolling): When point is above the window, allow searching
10172 as far as scroll_max, or one screenful, to compute vertical
10173 distance from PT to the scroll margin position. This prevents
10174 try_scrolling from unnecessarily failing when
10175 scroll-conservatively is set to a value slightly larger than the
10176 window height. Clean up the case of PT below the margin at bottom
10177 of window: scroll_max can no longer be INT_MAX. When aggressive
10178 scrolling is in use, don't let point enter the opposite scroll
10179 margin as result of the scroll.
10180 (syms_of_xdisp) <scroll-conservatively>: Document the
10181 threshold of 100 lines for never-recentering scrolling.
10183 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10185 * dispextern.h (move_it_by_lines):
10186 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10187 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10188 (message_log_check_duplicate): Remove parameters `prev_bol' and
10189 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10190 (redisplay_internal): Remove parameter `preserve_echo_area',
10191 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10193 * indent.c (Fvertical_motion):
10194 * window.c (window_scroll_pixel_based, Frecenter):
10195 Don't pass `need_y_p' to `move_it_by_lines'.
10197 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10199 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10200 steal a few bits to be more compact.
10201 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10202 Remove unneeded casts.
10204 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10206 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10208 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10209 binding" message (bug#7967).
10211 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10213 Fix more problems found by GCC 4.6.0's static checks.
10215 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10216 Remove unused local var.
10218 * editfns.c (Fmessage_box): Remove unused local var.
10220 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10221 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10222 Omit unused local vars.
10223 * window.c (shrink_windows): Omit unused local var.
10224 * menu.c (digest_single_submenu): Omit unused local var.
10225 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10226 Omit unused local var.
10228 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10229 Don't assume string length fits in int.
10230 (keyremap_step, read_key_sequence): Use size_t for sizes.
10231 (read_key_sequence): Don't check last_real_key_start redundantly.
10233 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10234 instead of alloca (Bug#8344).
10236 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10237 (Fbacktrace_frame): Don't assume nframes fits in int.
10239 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10241 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10244 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10246 * cm.c (calccost): Turn while-do into do-while, for clarity.
10248 * keyboard.c (syms_of_keyboard): Use the same style as later
10249 in this function when indexing through an array. This also
10250 works around GCC bug 48267.
10252 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10254 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10256 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10257 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10259 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10260 This avoids undefined behavior on integer overflow, and is a bit
10261 more convenient anyway since it is compared to a size_t variable.
10263 Variadic C functions now count arguments with size_t, not int.
10264 This avoids an unnecessary limitation on 64-bit machines, which
10265 caused (substring ...) to crash on large vectors (Bug#8344).
10266 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10267 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10268 All variadic functions and their callers changed accordingly.
10269 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10270 * data.c (arith_driver, float_arith_driver): Likewise.
10271 * editfns.c (general_insert_function): Likewise.
10272 * eval.c (struct backtrace.nargs, interactive_p)
10273 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10274 (funcall_lambda, mark_backtrace): Likewise.
10275 * fns.c (concat): Likewise.
10276 * frame.c (x_set_frame_parameters): Likewise.
10277 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10278 0 if not found, not -1. All callers changed.
10280 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10281 (stack_copy_size): Now size_t, not int.
10282 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10284 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10286 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10287 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10288 All callers changed.
10290 * lisp.h (multibyte_char_to_unibyte):
10291 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10292 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10293 * character.h (CHAR_TO_BYTE8):
10294 * cmds.c (internal_self_insert):
10295 * editfns.c (general_insert_function):
10296 * keymap.c (push_key_description):
10297 * search.c (Freplace_match):
10298 * xdisp.c (message_dolog, set_message_1): All callers changed.
10300 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10302 * keyboard.c (safe_run_hook_funcall): New function.
10303 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10304 don't set the hook to nil, but remove the offending function instead.
10305 (Qcommand_hook_internal): Remove, unused.
10306 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10307 Vcommand_hook_internal.
10309 * eval.c (enum run_hooks_condition): Remove.
10310 (funcall_nil, funcall_not): New functions.
10311 (run_hook_with_args): Call each function through a `funcall' argument.
10312 Remove `cond' argument, now redundant.
10313 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10314 (Frun_hook_with_args_until_failure): Adjust accordingly.
10315 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10317 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10319 * dispextern.h (string_buffer_position): Remove declaration.
10321 * print.c (strout): Remove parameter `multibyte', unused since
10322 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10324 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10325 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10326 All callers changed.
10328 * w32.c (_wsa_errlist): Use braces for struct initializers.
10330 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10331 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10332 All callers changed.
10333 (string_buffer_position): Likewise. Also, make static (it's never
10334 used outside xdisp.c).
10335 (cursor_row_p): Remove parameter `w', unused since
10336 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10337 (decode_mode_spec): Remove parameter `precision', introduced during
10338 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10339 All callers changed.
10341 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10343 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10345 2011-03-27 Anders Lindgren <andlind@gmail.com>
10347 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10348 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10349 (ns_update_auto_hide_menu_bar): New functions.
10350 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10351 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10352 ns_constrain_all_frames.
10353 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10354 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10356 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10358 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10360 2011-03-27 Glenn Morris <rgm@gnu.org>
10362 * syssignal.h: Replace RETSIGTYPE with void.
10363 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10364 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10365 Replace SIGTYPE with void everywhere.
10366 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10367 * s/template.h (SIGTYPE): Remove commented out definition.
10369 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10371 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10372 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10374 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10376 * w32.c (read_unc_volume): Use parameter `henum', instead of
10377 global variable `wget_enum_handle'.
10379 * keymap.c (describe_vector): Remove parameters `indices' and
10380 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10381 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10383 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10385 * keyboard.c (timer_check): Remove parameter `do_it_now',
10386 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10387 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10388 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10390 * keyboard.c (read_char):
10391 * w32menu.c (w32_menu_display_help):
10392 * xmenu.c (show_help_event, menu_help_callback):
10393 Adjust calls to `show_help_echo'.
10395 * gtkutil.c (xg_maybe_add_timer):
10396 * keyboard.c (readable_events):
10397 * process.c (wait_reading_process_output):
10398 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10400 * insdel.c (adjust_markers_gap_motion):
10401 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10402 (gap_left, gap_right): Don't call it.
10404 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10406 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10407 incurred during fontification.
10409 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10411 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10412 (DEFVAR_PER_BUFFER): Don't pass it.
10414 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10415 (scrolling_window): Don't pass it.
10417 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10419 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10421 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10423 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10424 of variables specific to SELinux and computation of `encoded_absname'.
10426 * image.c (XPutPixel): Remove unused variable `height'.
10428 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10430 * unexw32.c (get_section_info): Remove unused variable `section'.
10432 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10433 (system_process_attributes): Remove unused variable `sess'.
10434 (sys_read): Remove unused variable `err'.
10436 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10437 (w32_wnd_proc): Remove unused variable `isdead'.
10438 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10439 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10440 (x_create_tip_frame): Remove unused variable `tem'.
10442 * w32inevt.c (w32_console_read_socket):
10443 Remove unused variable `no_events'.
10445 * w32term.c (x_draw_composite_glyph_string_foreground):
10446 Remove unused variable `width'.
10448 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10450 * w32term.c (x_set_glyph_string_clipping):
10451 Don't pass uninitialized region to CombineRgn.
10453 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10455 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10456 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10457 (Fx_close_connection): Remove unused variable `i'.
10459 * w32font.c (w32font_draw): Return number of glyphs.
10460 (w32font_open_internal): Remove unused variable `i'.
10461 (w32font_driver): Add missing initializer.
10463 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10464 (fill_in_menu): Remove unused variable `items_added'.
10466 * w32term.c (last_mouse_press_frame): Remove static global variable.
10467 (w32_clip_to_row): Remove unused variable `f'.
10468 (x_delete_terminal): Remove unused variable `i'.
10470 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10471 (NOTHING): Remove unused static global variable.
10472 (uniscribe_check_otf): Remove unused variable `table'.
10473 (uniscribe_font_driver): Add missing initializers.
10475 2011-03-23 Julien Danjou <julien@danjou.info>
10477 * term.c (Fsuspend_tty, Fresume_tty):
10478 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10479 * window.c (temp_output_buffer_show):
10480 * insdel.c (signal_before_change):
10481 * frame.c (Fhandle_switch_frame):
10482 * fileio.c (Fdo_auto_save):
10483 * emacs.c (Fkill_emacs):
10484 * editfns.c (save_excursion_restore):
10485 * cmds.c (internal_self_insert):
10486 * callint.c (Fcall_interactively):
10487 * buffer.c (Fkill_all_local_variables):
10488 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10490 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10491 unconditionally since it does the check itself.
10493 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10495 Fix more problems found by GCC 4.5.2's static checks.
10497 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10498 the first time through the loop, since we know p0 < p1 then.
10499 This also avoids a gcc -Wstrict-overflow warning.
10501 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10502 leading to a memory leak, possible in functions like
10503 load_charset_map_from_file that can allocate an unbounded number
10504 of objects (Bug#8318).
10506 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10507 that could (at least in theory) be that large.
10509 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10510 This is less likely to overflow, and avoids undefined behavior if
10511 overflow does occur. All callers changed. Use strtoul to scan
10512 for the unsigned long integer.
10513 (pint2hrstr): Simplify and tune code slightly.
10514 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10516 * scroll.c (do_scrolling): Work around GCC bug 48228.
10517 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10519 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10520 This also avoids a warning with gcc -Wstrict-overflow.
10521 (validate_x_resource_name): Simplify count usage.
10522 This also avoids a warning with gcc -Wstrict-overflow.
10524 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10527 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10529 * process.c (Fmake_network_process): Use socklen_t, not int,
10530 where POSIX says socklen_t is required in portable programs.
10531 This fixes a porting bug on hosts like 64-bit HP-UX, where
10532 socklen_t is wider than int (Bug#8277).
10533 (Fmake_network_process, server_accept_connection):
10534 (wait_reading_process_output, read_process_output):
10537 * process.c: Rename or move locals to avoid shadowing.
10538 (list_processes_1, Fmake_network_process):
10539 (read_process_output_error_handler, exec_sentinel_error_handler):
10540 Rename or move locals.
10541 (Fmake_network_process): Define label "retry_connect" only if needed.
10542 (Fnetwork_interface_info): Fix pointer signedness.
10543 (process_send_signal): Add cast to avoid pointer signedness problem.
10544 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10545 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10547 Make tparam.h and terminfo.c consistent.
10548 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10549 Include tparam.h instead, since it declares them.
10550 * cm.h (PC): Remove extern decl; tparam.h now does this.
10551 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10552 * terminfo.c: Include tparam.h, to check interfaces.
10553 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10554 (tparam): Adjust signature to match interface in tparam.h;
10555 this removes some undefined behavior. Check that outstring and len
10556 are zero, which they always are with Emacs.
10557 * tparam.h (PC, BC, UP): New extern decls.
10559 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10560 (xftfont_open): Rename locals to avoid shadowing.
10562 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10563 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10564 (OTF_TAG_SYM): Omit macro if not needed.
10565 (ftfont_list): Remove unused local.
10566 (get_adstyle_property, ftfont_pattern_entity):
10567 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10568 Rename locals to avoid shadowing.
10570 * xfont.c (xfont_list_family): Mark var as initialized.
10572 * xml.c (make_dom): Now static.
10574 * composite.c (composition_compute_stop_pos): Rename local to
10576 (composition_reseat_it): Remove unused locals.
10577 (find_automatic_composition, composition_adjust_point): Likewise.
10578 (composition_update_it): Mark var as initialized.
10579 (find_automatic_composition): Mark vars as initialized,
10580 with a FIXME (Bug#8290).
10582 character.h: Rename locals to avoid shadowing.
10583 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10584 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10585 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10586 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10587 to avoid shadowing.
10589 * textprop.c (property_change_between_p): Remove; unused.
10591 * intervals.c (interval_start_pos): Now static.
10593 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10595 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10596 Rename locals to avoid shadowing.
10598 * sound.c (wav_play, au_play, Fplay_sound_internal):
10599 Fix pointer signedness.
10600 (alsa_choose_format): Remove unused local var.
10601 (wav_play): Initialize a variable to 0, to prevent undefined
10602 behavior (Bug#8278).
10604 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10606 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10608 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10609 clobbering (Bug#8298).
10610 * sysdep.c (sys_subshell): Likewise.
10611 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10613 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10614 This should get cleaned up, so that child_setup has the
10615 same signature on all platforms.
10617 * callproc.c (call_process_cleanup): Now static.
10618 (relocate_fd): Rename locals to avoid shadowing.
10620 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10622 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10623 not to be necessary, and produces flickering.
10625 2011-03-20 Glenn Morris <rgm@gnu.org>
10627 * config.in: Remove file.
10629 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10631 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10632 are now in src/globals.h.
10633 (syms_of_minibuf): Remove spurious & from previous change.
10635 2011-03-20 Leo Liu <sdl.web@gmail.com>
10637 * minibuf.c (completing-read-function): New variable.
10638 (completing-read-default): Rename from completing-read.
10639 (completing-read): Call completing-read-function.
10641 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10643 * xfaces.c (Fx_load_color_file):
10644 Read color file from absolute filename (bug#8250).
10646 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10648 * makefile.w32-in: Update dependencies.
10650 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10652 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10654 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10656 Fix more problems found by GCC 4.5.2's static checks.
10658 * process.c (make_serial_process_unwind, send_process_trap):
10659 (sigchld_handler): Now static.
10661 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10662 That way, the code declares only the vars that it needs.
10663 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10664 * s/cygwin.h (PTY_ITERATION): Likewise.
10665 * s/darwin.h (PTY_ITERATION): Likewise.
10666 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10668 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10669 * process.c (allocate_pty): Don't declare stb unless it's needed.
10671 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10672 (CONSTANTLIM): Remove; unused.
10673 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10674 Define only if needed.
10676 * unexelf.c (unexec): Name an expression,
10677 to avoid gcc -Wbad-function-cast warning.
10678 Use a different way to cause a compilation error if anyone uses
10679 n rather than nn, a way that does not involve shadowing.
10680 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10682 * deps.mk (unexalpha.o): Remove; unused.
10684 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10685 * unexec.h: New file.
10686 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10687 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10688 Depend on unexec.h.
10689 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10690 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10691 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10692 Change as necessary to match prototype in unexec.h.
10694 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10696 (back_comment, skip_chars): Mark vars as initialized.
10698 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10699 Rename locals to avoid shadowing.
10701 * lread.c (read1): Rewrite so as not to use empty "else".
10702 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10704 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10706 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10707 warning when compiling print.c.
10709 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10710 instead of using an uninitialized var.
10711 (font_sort_entities): Mark var as initialized.
10713 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10715 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10716 pointers to constants.
10717 (font_parse_fcname): Remove unused vars.
10718 (font_delete_unmatched): Now static.
10719 (font_get_spec): Remove; unused.
10720 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10721 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10722 Rename or move locals to avoid shadowing.
10724 * fns.c (require_nesting_list, require_unwind): Now static.
10725 (Ffillarray): Rename locals to avoid shadowing.
10727 * floatfns.c (domain_error2): Define only if needed.
10728 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10730 * alloc.c (mark_backtrace): Move decl from here ...
10731 * lisp.h: ... to here, so that it can be checked.
10733 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10734 (Fdefvar): Rewrite so as not to use empty "else".
10735 (lisp_indirect_variable): Name an expression,
10736 to avoid gcc -Wbad-function-cast warning.
10737 (Fdefvar): Rename locals to avoid shadowing.
10739 * callint.c (quotify_arg, quotify_args): Now static.
10740 (Fcall_interactively): Rename locals to avoid shadowing.
10741 Use const pointer when appropriate.
10743 * lisp.h (get_system_name, get_operating_system_release):
10744 Move decls here, to check interfaces.
10745 * process.c (get_operating_system_release): Move decl to lisp.h.
10746 * xrdb.c (get_system_name): Likewise.
10747 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10748 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10749 some of which prompt warnings from gcc -Wbad-function-cast.
10750 (Fformat_time_string, Fencode_time, Finsert_char):
10751 (Ftranslate_region_internal, Fformat):
10752 Rename or remove local vars to avoid shadowing.
10753 (Ftranslate_region_internal): Mark var as initialized.
10755 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10758 * lisp.h (eassert): Check that the argument compiles, even if
10759 ENABLE_CHECKING is not defined.
10761 * data.c (Findirect_variable): Name an expression, to avoid
10762 gcc -Wbad-function-cast warning.
10763 (default_value, arithcompare, arith_driver, arith_error): Now static.
10764 (store_symval_forwarding): Rename local to avoid shadowing.
10765 (Fmake_variable_buffer_local, Fmake_local_variable):
10766 Mark variables as initialized.
10767 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10769 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10770 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10771 Rename locals to avoid shadowing.
10772 (mark_stack): Move local variables into the #ifdef region where
10774 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10775 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10777 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10778 (GC_STRING_CHARS): Remove; not used.
10779 (Fmemory_limit): Cast sbrk's returned value to char *.
10781 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10782 avoids undefined behavior in theory.
10784 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10786 Use functions, not macros, for up- and down-casing (Bug#8254).
10787 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10788 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10789 to use the following functions instead of these macros.
10790 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10791 EMACS_INT, since callers assume the returned value fits in int.
10792 (upcase1): Likewise, for UPCASE_TABLE.
10793 (uppercasep, lowercasep, upcase): New static inline functions.
10794 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10795 the race-condition problem in the old DOWNCASE.
10797 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10798 Rename locals to avoid shadowing.
10799 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10800 (regex_compile, re_search_2, re_match_2_internal):
10801 Remove unused local vars.
10802 (FREE_VAR): Rewrite so as not to use empty "else",
10803 which gcc can warn about.
10804 (regex_compile, re_match_2_internal): Mark locals as initialized.
10805 (RETALLOC_IF): Define only if needed.
10806 (WORDCHAR_P): Likewise. This one is never needed, but is used
10807 only in a comment talking about a compiler bug, so put inside
10808 the #if 0 of that comment.
10809 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10810 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10813 * search.c (boyer_moore): Rename locals to avoid shadowing.
10814 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10815 (PREV_CHAR_BOUNDARY): Likewise.
10817 * search.c (simple_search): Remove unused var.
10819 * dired.c (compile_pattern): Move decl from here ...
10820 * lisp.h: ... to here, so that it can be checked.
10821 (struct re_registers): New forward decl.
10823 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10825 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10827 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10828 Rename locals to avoid shadowing.
10829 (Fvertical_motion): Mark locals as initialized.
10831 * casefiddle.c (casify_object, casify_region): Now static.
10832 (casify_region): Mark local as initialized.
10834 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10836 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10837 New macros, so that the caller can use some names other than
10838 gcpro1, gcpro2, etc.
10839 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10841 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10842 argument, for consistency with GCPRO2_VAR, etc: it is now the
10843 prefix of the variable, not the variable itself. All uses
10845 * dired.c (directory_files_internal, file_name_completion):
10846 Rename locals to avoid shadowing.
10848 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10849 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10850 dired.c's scmp function, had undefined behavior.
10851 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10852 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10853 * buffer.h: ... to here, because these macros use current_buffer,
10854 and the new implementation with inline functions needs to have
10855 current_buffer in scope now, rather than later when the macros
10857 (downcase, upcase1): New static inline functions.
10858 (DOWNCASE, UPCASE1): Reimplement using these functions.
10859 This avoids undefined behavior in expressions like
10860 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10861 from race conditions in accessing the global variables
10862 case_temp1 and case_temp2.
10863 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10864 * lisp.h (case_temp1, case_temp2): Remove their decls.
10865 * character.h (ASCII_CHAR_P): Move from here ...
10866 * lisp.h: ... to here, so that the inline functions mentioned
10867 above can use them.
10869 * dired.c (directory_files_internal_unwind): Now static.
10871 * fileio.c (file_name_as_directory, directory_file_name):
10872 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10874 (file_name_as_directory): Use const pointers when appropriate.
10875 (Fexpand_file_name): Likewise. In particular, newdir might
10876 point at constant storage, so make it a const pointer.
10877 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10878 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10880 (Fset_file_times, Finsert_file_contents, auto_save_error):
10881 Rename locals to avoid shadowing.
10883 * minibuf.c (choose_minibuf_frame_1): Now static.
10884 (Ftry_completion, Fall_completions): Rename or remove locals
10885 to avoid shadowing.
10887 * marker.c (bytepos_to_charpos): Remove; unused.
10889 * lisp.h (verify_bytepos, count_markers): New decls,
10890 so that gcc does not warn that these functions aren't declared.
10892 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10893 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10894 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10895 (copy_text): Remove unused local var.
10897 * filelock.c (within_one_second): Now static.
10898 (lock_file_1): Rename local to avoid shadowing.
10900 * buffer.c (fix_overlays_before): Mark locals as initialized.
10901 (fix_start_end_in_overlays): Likewise. This function should be
10902 simplified by using pointers-to-pointers, but that's a different
10904 (switch_to_buffer_1): Now static.
10905 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10906 (report_overlay_modification): Rename locals to avoid shadowing.
10908 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10909 Fix pointer signedness issue.
10910 (sys_subshell): Mark local as volatile if checking for lint,
10911 to suppress a gcc -Wclobbered warning that does not seem to be right.
10912 (MAXPATHLEN): Define only if needed.
10914 * process.c (serial_open, serial_configure): Move decls from here ...
10915 * systty.h: ... to here, so that they can be checked.
10917 * fns.c (get_random, seed_random): Move extern decls from here ...
10918 * lisp.h: ... to here, so that they can be checked.
10920 * sysdep.c (reset_io): Now static.
10921 (wait_for_termination_signal): Remove; unused.
10923 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10924 (copy_keymap_item, append_key, push_text_char_description):
10926 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10927 (DENSE_TABLE_SIZE): Remove; unused.
10928 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10929 (describe_map_tree):
10930 Rename locals to avoid shadowing.
10932 * keyboard.c: Declare functions static if they are not used elsewhere.
10933 (echo_char, echo_dash, cmd_error, top_level_2):
10934 (poll_for_input, handle_async_input): Now static.
10935 (read_char, kbd_buffer_get_event, make_lispy_position):
10936 (make_lispy_event, make_lispy_movement, apply_modifiers):
10937 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10938 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10939 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10940 (read_key_sequence, read_char): Mark locals as initialized.
10941 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10943 * keyboard.h (make_ctrl_char): New decl.
10944 (mark_kboards): Move decl here ...
10945 * alloc.c (mark_kboards): ... from here.
10947 * lisp.h (force_auto_save_soon): New decl.
10949 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10950 (DEFINE_DUMMY_FUNCTION): New macro.
10951 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10953 (main): Add casts to avoid warnings
10954 if GCC considers string literals to be constants.
10956 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10958 * dbusbind.c: Pointer signedness fixes.
10959 (xd_signature, xd_append_arg, xd_initialize):
10960 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10961 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10962 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10963 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10965 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10966 if GCC considers string literals to be constants.
10967 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10969 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10971 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10972 (print_preprocess, print_object): New macro to fix last change.
10974 * print.c (print_preprocess): Don't forget font objects.
10976 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10978 * emacs.c (USAGE3): Doc fixes.
10980 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10982 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10985 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10987 * lisp.h (VWindow_system, Qfile_name_history):
10988 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10989 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10990 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10992 * w32select.c: Don't #include "keyboard.h".
10993 (run_protected): Add extern declaration for waiting_for_input.
10995 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10996 * w32console.c (detect_input_pending, read_input_pending)
10997 (encode_terminal_code):
10998 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10999 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11000 (w32_system_caret_y, Qfile_name_history):
11001 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11002 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11003 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11004 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11005 * w32proc.c (Qlocal, report_file_error):
11006 * w32term.c (Vwindow_system, updating_frame):
11007 * w32uniscribe.c (initialized, uniscribe_font_driver):
11008 Remove unneeded extern declarations.
11010 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11012 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11014 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11016 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11017 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11018 These macros can no longer be used for assignment.
11020 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11021 Assign struct members directly, instead of using BUF_BEGV etc.
11022 (record_buffer_markers, fetch_buffer_markers): New functions for
11023 recording and fetching special buffer markers.
11024 (set_buffer_internal_1, set_buffer_temp): Use them.
11026 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11028 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11030 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11031 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11033 * xdisp.c (hscroll_window_tree):
11034 (reconsider_clip_changes): Use PT instead of BUF_PT.
11036 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11038 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11039 $(EMACS_ROOT)/lib/intprops.h.
11041 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11043 Fix more problems found by GCC 4.5.2's static checks.
11045 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11046 to unsigned char * to avoid compiler diagnostic.
11047 (xg_free_frame_widgets): Make it clear that a local variable is
11048 needed only if USE_GTK_TOOLTIP.
11049 (gdk_window_get_screen): Make it clear that this macro is needed
11050 only if USE_GTK_TOOLTIP.
11051 (int_gtk_range_get_value): New function, which avoids a diagnostic
11052 from gcc -Wbad-function-cast.
11053 (xg_set_toolkit_scroll_bar_thumb): Use it.
11054 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11055 diagnostic from gcc -Wbad-function-cast.
11056 (get_utf8_string, xg_get_file_with_chooser):
11057 Rename locals to avoid shadowing.
11058 (create_dialog): Move locals to avoid shadowing.
11060 * xgselect.c (xg_select): Remove unused var.
11062 * image.c (four_corners_best): Mark locals as initialized.
11063 (gif_load): Initialize transparent_p to zero (Bug#8238).
11064 Mark another local as initialized.
11065 (my_png_error, my_error_exit): Mark with NO_RETURN.
11067 * image.c (clear_image_cache): Now static.
11068 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11069 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11070 (x_edge_detection): Remove unnecessary cast that
11071 gcc -Wbad-function-cast diagnoses.
11072 (gif_load): Fix pointer signedness.
11073 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11074 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11076 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11078 Improve quality of tests for time stamp overflow.
11079 For example, without this patch (encode-time 0 0 0 1 1
11080 1152921504606846976) returns the obviously-bogus value (-948597
11081 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11082 reports time overflow. See
11083 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11084 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11085 * editfns.c: Include limits.h and intprops.h.
11086 (TIME_T_MIN, TIME_T_MAX): New macros.
11087 (time_overflow): Move earlier, to before first use.
11088 (hi_time, lo_time): New functions, for an accurate test for
11089 out-of-range times.
11090 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11091 (Fget_internal_run_time): Don't assume time_t fits in int.
11092 (make_time): Use list2 instead of Fcons twice.
11093 (Fdecode_time): More accurate test for out-of-range times.
11094 (check_tm_member): New function.
11095 (Fencode_time): Use it, to test for out-of-range times.
11096 (lisp_time_argument): Don't rely on undefined left-shift and
11097 right-shift behavior when checking for time stamp overflow.
11099 * editfns.c (time_overflow): New function, refactoring common code.
11100 (Fformat_time_string, Fdecode_time, Fencode_time):
11101 (Fcurrent_time_string): Use it.
11103 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11104 * dired.c (make_time): Move to ...
11105 * editfns.c (make_time): ... here.
11106 * systime.h: Note the move.
11108 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11110 * fringe.c (update_window_fringes): Remove unused variables.
11112 * unexmacosx.c (copy_data_segment): Also copy __got section.
11115 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11117 * termcap.c [MSDOS]: Include "msdos.h".
11118 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11119 Constify `char *' arguments and their references according to
11120 prototypes in tparam.h.
11122 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11124 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11125 Adapt all references accordingly.
11127 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11129 2011-03-11 Tom Tromey <tromey@redhat.com>
11131 * buffer.c (syms_of_buffer): Remove obsolete comment.
11133 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11135 * termhooks.h (encode_terminal_code): Declare prototype.
11137 * msdos.c (encode_terminal_code): Don't declare prototype.
11139 * term.c (encode_terminal_code): Now external again, used by
11140 w32console.c and msdos.c.
11142 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11143 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11145 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11147 Fix some minor problems found by GCC 4.5.2's static checks.
11149 * fringe.c (update_window_fringes): Mark locals as initialized
11151 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11153 * alloc.c (mark_fringe_data): Move decl from here ...
11154 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11155 to check its interface.
11156 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11158 * fontset.c (free_realized_fontset): Now static.
11159 (Fset_fontset_font): Rename local to avoid shadowing.
11160 (fontset_font): Mark local as initialized.
11161 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11163 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11165 * xselect.c (x_disown_buffer_selections): Remove; not used.
11166 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11167 (x_own_selection, Fx_disown_selection_internal): Rename locals
11168 to avoid shadowing.
11169 (x_handle_dnd_message): Remove local to avoid shadowing.
11171 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11172 so that the caller can use some name other than gcpro1.
11173 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11174 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11175 (Fx_backspace_delete_keys_p):
11176 Use them to avoid shadowing, and rename vars to avoid shadowing.
11177 (x_decode_color, x_set_name, x_window): Now static.
11178 (Fx_create_frame): Add braces to silence GCC warning.
11179 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11180 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11181 Remove unused locals.
11182 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11183 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11184 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11187 * xterm.h (x_mouse_leave): New decl.
11189 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11190 Remove unused functions.
11191 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11192 (x_calc_absolute_position): Now static.
11193 (XTread_socket): Don't define label "out" unless it's used.
11194 Don't declare local "event" unless it's used.
11195 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11196 unless they are used.
11197 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11198 (x_fatal_error_signal): Remove; not used.
11199 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11200 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11201 (x_error_catcher, x_connection_closed, x_error_handler):
11202 (x_error_quitter, xembed_send_message, x_iconify_frame):
11203 (my_log_handler): Rename locals to avoid shadowing.
11204 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11205 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11207 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11208 Rename or move locals to avoid shadowing.
11209 (tty_defined_color, merge_face_heights): Now static.
11210 (free_realized_faces_for_fontset): Remove; not used.
11211 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11212 does not deduce is never used uninitialized.
11213 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11214 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11216 * terminal.c (store_terminal_param): Now static.
11218 * xmenu.c (menu_highlight_callback): Now static.
11219 (set_frame_menubar): Remove unused local.
11220 (xmenu_show): Rename parameter to avoid shadowing.
11221 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11222 since they might point to immutable storage.
11223 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11224 since it's unused otherwise.
11226 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11227 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11228 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11229 avoids a gcc -Wuninitialized diagnostic.
11230 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11231 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11232 does not deduce are never used uninitialized.
11234 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11236 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11237 * window.c (window_loop, size_window):
11238 (run_window_configuration_change_hook, enlarge_window): Likewise.
11240 * window.c (display_buffer): Now static.
11241 (size_window): Mark variables that gcc -Wuninitialized
11242 does not deduce are never used uninitialized.
11243 * window.h (check_all_windows): New decl, to forestall
11244 gcc -Wmissing-prototypes diagnostic.
11245 * dispextern.h (bidi_dump_cached_states): Likewise.
11247 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11249 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11250 Include <limits.h>.
11251 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11252 and to avoid gcc -Wuninitialized warning.
11253 (load_charset_map): Mark variables that gcc -Wuninitialized
11254 does not deduce are never used uninitialized.
11255 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11257 * coding.c (coding_set_source, coding_set_destination):
11258 Use "else { /* comment */ }" rather than "else /* comment */;"
11259 for clarity, and to avoid gcc -Wempty-body warning.
11260 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11261 a block, when the outer 'i' will do.
11262 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11263 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11264 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11265 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11266 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11267 Rename locals to avoid shadowing.
11268 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11269 * coding.c (emacs_mule_char, encode_invocation_designation):
11270 Now static, since they're not used elsewhere.
11271 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11272 (decode_coding_object, encode_coding_object, detect_coding_system):
11273 (decode_coding_emacs_mule): Mark variables that gcc
11274 -Wuninitialized does not deduce are never used uninitialized.
11275 (detect_coding_iso_2022): Initialize a local variable that might
11276 be used uninitialized. Leave a FIXME because it's not clear that
11277 this initialization is needed. (Bug#8211)
11278 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11279 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11280 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11281 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11282 Remove unused macros.
11284 * category.c (hash_get_category_set): Remove unused local var.
11285 (copy_category_table): Now static, since it's not used elsewhere.
11286 * character.c (string_count_byte8): Likewise.
11288 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11289 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11291 * chartab.c (copy_sub_char_table): Now static, since it's not used
11293 (sub_char_table_ref_and_range, char_table_ref_and_range):
11294 Rename locals to avoid shadowing.
11295 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11297 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11298 (BIDI_BOB): Remove unused macro.
11300 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11301 deduce are never used uninitialized.
11302 * term.c (encode_terminal_code): Likewise.
11304 * term.c (encode_terminal_code): Now static. Remove unused local.
11306 * tparam.h: New file.
11307 * term.c, tparam.h: Include it.
11308 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11309 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11310 Move these decls to tparam.h, and make them agree with what
11311 is actually in tparam.c. The previous trick of using incompatible
11312 decls in different modules does not conform to the C standard.
11313 All callers of tparam changed to use tparam's actual API.
11314 * tparam.c (tparam1, tparam, tgoto):
11315 Use const pointers where appropriate.
11317 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11318 * cm.h (struct cm): Likewise.
11319 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11320 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11321 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11322 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11323 (turn_on_face, init_tty): Likewise.
11324 * termchar.h (struct tty_display_info): Likewise.
11326 * term.c (term_mouse_position): Rename local to avoid shadowing.
11328 * alloc.c (mark_ttys): Move decl from here ...
11329 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11331 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11333 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11335 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11337 * search.c (compile_pattern_1): Remove argument regp, unused since
11338 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11339 (compile_pattern): Don't pass it.
11341 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11343 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11344 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11346 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11348 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11350 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11351 gdk_window_get_screen, gdk_window_get_geometry,
11352 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11353 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11354 (xg_get_pixbuf_from_pixmap): New function.
11355 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11356 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11357 Call xg_get_pixbuf_from_pixmap instead of
11358 gdk_pixbuf_get_from_drawable.
11359 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11360 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11361 (xg_check_special_colors): Use GtkStyleContext and its functions
11363 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11364 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11365 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11366 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11367 Call gtk_widget_get_preferred_size.
11368 (xg_frame_resized): gdk_window_get_geometry only takes 5
11370 (xg_win_to_widget, xg_event_is_for_menubar):
11371 Call gdk_x11_window_lookup_for_display.
11372 (xg_set_widget_bg): New function.
11373 (delete_cb): New function.
11374 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11375 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11376 (xg_set_background_color): Call xg_set_widget_bg.
11377 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11378 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11379 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11380 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11382 (update_frame_tool_bar): Call gtk_widget_hide.
11383 (xg_initialize): Use GDK_KEY_g.
11385 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11387 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11389 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11390 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11391 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11393 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11395 * w32xfns.c (select_palette): Check success of RealizePalette against
11396 GDI_ERROR, not zero.
11398 See ChangeLog.11 for earlier changes.
11400 ;; Local Variables:
11404 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11406 This file is part of GNU Emacs.
11408 GNU Emacs is free software: you can redistribute it and/or modify
11409 it under the terms of the GNU General Public License as published by
11410 the Free Software Foundation, either version 3 of the License, or
11411 (at your option) any later version.
11413 GNU Emacs is distributed in the hope that it will be useful,
11414 but WITHOUT ANY WARRANTY; without even the implied warranty of
11415 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11416 GNU General Public License for more details.
11418 You should have received a copy of the GNU General Public License
11419 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.