1 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4 Convert pctcpu and pctmem to Lisp float properly.
5 Let the compiler fold better, as 100.0/0x8000 is exact.
7 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
9 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
12 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
14 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
16 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
18 For a 'struct window', replace some Lisp_Object fields to
19 bitfields where appropriate, remove unused fields.
20 * window.h (struct window): Remove unused 'last_mark_x' and
21 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
22 change it's type from Lisp_Object to bitfield.
23 Change type of 'force_start', 'optional_new_start',
24 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
25 fields from Lisp_Object to bitfield. Adjust users accordingly.
27 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
29 Pacify gcc -Wdouble-precision when using Xaw.
30 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
31 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
32 Use 'float' consistently, rather than 'float' in most places
33 and 'double' in a couple of places.
35 2012-05-31 Eli Zaretskii <eliz@gnu.org>
37 * xdisp.c (handle_stop): Detect whether we have overlay strings
38 loaded by testing it->current.overlay_string_index to be
39 non-negative, instead of checking whether n_overlay_strings is
42 2012-05-31 Chong Yidong <cyd@gnu.org>
44 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
46 * doc.c (Fsubstitute_command_keys): Doc fix.
48 2012-05-31 Eli Zaretskii <eliz@gnu.org>
50 * search.c (search_buffer): Remove calls to
51 r_alloc_inhibit_buffer_relocation, as it is now called by
52 maybe_unify_char, which was the cause of relocation of buffer text
55 2012-05-31 Eli Zaretskii <eliz@gnu.org>
57 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
58 for the duration of call to load_charset, to avoid problems with
59 callers of maybe_unify_char that access buffer text through C
62 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
63 decrement the inhibition flag, instead of just setting or
66 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
68 Remove obsolete '#define static' cruft.
69 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
70 This #undef was "temporary" in 2000; it is no longer needed
71 now that '#define static' has gone away.
72 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
73 (gray_bitmap_bits): Remove; no longer needed.
74 All uses replaced with definiens.
75 * xterm.c: Include "bitmaps/gray.xbm".
77 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
79 Clean up __executable_start, monstartup when --enable-profiling.
80 The following changes affect the code only when profiling.
81 * dispnew.c (__executable_start): Rename from safe_bcopy.
82 Define only on platforms that need it.
83 * emacs.c: Include <sys/gmon.h> when profiling.
84 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
85 (__executable_start): Remove decl, since lisp.h does it now.
86 (safe_bcopy): Remove decl; no longer has that name.
87 (main): Coalesce #if into single bit of code, for simplicity.
88 Cast pointers to uintptr_t, since standard libraries want integers
90 * lisp.h (__executable_start): New decl.
92 2012-05-31 Glenn Morris <rgm@gnu.org>
94 * image.c (Fimagemagick_types): Doc fix.
96 2012-05-30 Jim Meyering <meyering@redhat.com>
98 * callproc.c (Fcall_process_region): Include directory component
99 in mkstemp error message (Bug#11586).
101 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
103 * alloc.c, lisp.h (make_pure_vector): Now static.
105 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
107 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
109 (Fautoload): Do the hash-doc more carefully.
110 * data.c (Fdefalias): Purify definition, except for keymaps.
111 (Qdefun): Move from eval.c.
112 * lisp.h (Qdefun): Remove.
113 * lread.c (read1): Tiny simplification.
115 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
117 Do not create empty overlays with the evaporate property (Bug#9642).
118 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
119 Bug#9642, but explicitly check that the buffer the overlay would
120 be moved to is live and rearrange lines to make sure that errors
121 will not put the overlay in an inconsistent state.
122 (Fdelete_overlay): Cosmetics.
124 2012-05-28 Eli Zaretskii <eliz@gnu.org>
126 * w32term.c (my_bring_window_to_top): New function.
127 (x_raise_frame): Use handle returned by DeferWindowPos, which
128 could be different from the original one.
129 Call my_bring_window_to_top instead of my_set_foreground_window.
132 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
133 by calling BringWindowToTop.
135 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
136 (WM_EMACS_END): Increase by one.
138 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
140 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
141 This avoids undefined behavior that might cause the eassert
142 to not catch an out-of-range value.
144 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
146 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
149 2012-05-27 Eli Zaretskii <eliz@gnu.org>
151 * bidi.c (bidi_mirror_char): Fix last change.
153 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
155 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
156 when referring to sectname field in printf format.
158 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
160 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
161 Only r_alloc_inhibit_buffer_relocation needed to be added;
162 the others were already declared.
164 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
165 before checking whether it's out of range. Put the check inside
167 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
169 2012-05-27 Ken Brown <kbrown@cornell.edu>
171 * callproc.c (Fcall_process): Restore a line that was accidentally
172 commented out in the 2011-02-13 change (bug#11547).
174 2012-05-27 Eli Zaretskii <eliz@gnu.org>
176 * lisp.h [REL_ALLOC]: Add prototypes for external functions
179 * buffer.c [REL_ALLOC]: Remove prototypes of
180 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
181 they are now on lisp.h.
183 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
185 * search.c (search_buffer): Use it to inhibit relocation of buffer
186 text while re_search_2 is doing its job, because re_search_2 is
187 passed C pointers to buffer text. (Bug#11519)
189 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
192 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
193 state after an additional call to move_it_in_display_line_to, keep
194 the values of it->max_ascent and it->max_descent found for the
196 (pos_visible_p): Revert the comparison against bottom_y to what it
197 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
200 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
202 Fix coding-related core dumps with gcc -ftrapv.
203 The code was computing A - B, where A and B are pointers, and B is
204 random garbage. This can lead to core dumps on platforms that
205 have special pointer registers, and it also leads to core dumps on
206 x86-64 when compiled with gcc -ftrapv. The fix is to compute
207 A - B only when B is initialized properly.
208 * coding.c (coding_set_source, coding_set_destination): Return void.
209 (coding_change_source, coding_change_destinations): New functions,
210 with the old behaviors of coding_set_source and coding_set_destination.
211 All callers that need an offset changed to use these new functions.
213 2012-05-26 Glenn Morris <rgm@gnu.org>
215 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
217 2012-05-26 Eli Zaretskii <eliz@gnu.org>
219 Extend mouse support on W32 text-mode console.
220 * xdisp.c (draw_row_with_mouse_face):
221 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
223 * w32console.c: Include window.h.
224 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
226 (initialize_w32_display): Initialize mouse-highlight data.
228 * w32inevt.c: Include termchar.h and window.h.
229 (do_mouse_event): Support mouse-autoselect-window. When the mouse
230 moves, call note_mouse_highlight. If help_echo changed, call
231 gen_help_event to produce help-echo message in the echo area.
232 Call clear_mouse_face if mouse_face_hidden is set in the mouse
235 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
237 * lread.c (read1): Simplify slightly to avoid an overflow warning
238 with GCC 4.7.0 on x86-64.
240 2012-05-26 Eli Zaretskii <eliz@gnu.org>
242 * bidi.c (bidi_mirror_char): Revert last change: an int is
243 definitely wide enough here.
245 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
247 Fix integer width and related bugs (Bug#9874).
248 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
249 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
250 (string_bytes, check_sblock, allocate_string_data):
251 (compact_small_strings, Fmake_bool_vector, make_string)
252 (make_unibyte_string, make_multibyte_string)
253 (make_string_from_bytes, make_specified_string)
254 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
255 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
258 (allocate_pseudovector):
259 Use int, not EMACS_INT, where int is wide enough.
260 (inhibit_garbage_collection, Fgarbage_collect):
261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
262 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
263 int might not be wide enough.
264 (bidi_cache_search, bidi_cache_find, bidi_init_it)
265 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
266 (bidi_at_paragraph_end, bidi_find_paragraph_start)
267 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
268 (bidi_level_of_next_char, bidi_move_to_visually_next):
269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
270 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
271 (Fkill_buffer, Fset_buffer_major_mode)
272 (advance_to_char_boundary, Fbuffer_swap_text)
273 (Fset_buffer_multibyte, overlays_at, overlays_in)
274 (overlay_touches_p, struct sortvec, record_overlay_string)
275 (overlay_strings, recenter_overlay_lists)
276 (adjust_overlays_for_insert, adjust_overlays_for_delete)
277 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
278 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
279 (Foverlay_recenter, last_overlay_modification_hooks_used)
280 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
282 (validate_region): Omit unnecessary test for b <= e,
283 since that's guaranteed by the previous test.
284 (adjust_overlays_for_delete): Avoid pos + length overflow.
285 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
286 (report_overlay_modification):
287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
288 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
289 Omit pointer cast, which isn't needed anyway, and doesn't work
290 after the EMACS_INT -> ptrdiff_t change.
291 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
292 * buffer.h: Adjust decls to match defn changes elsewhere.
293 (struct buffer_text, struct buffer):
294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
295 Use EMACS_INT, not int, where int might not be wide enough.
296 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
297 not int, to avoid needless 32-bit limit on 64-bit hosts.
298 (exec_byte_code): Use tighter memory-full test, one that checks
299 for alloca overflow. Don't compute the address of the object just
300 before an array, as that's not portable. Use EMACS_INT, not
301 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
302 * callint.c (Fcall_interactively):
303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
304 * callproc.c (call_process_kill, Fcall_process):
305 Don't assume pid_t fits into an Emacs fixnum.
306 (call_process_cleanup, Fcall_process, child_setup):
307 Don't assume pid_t fits into int.
308 (call_process_cleanup, Fcall_process, delete_temp_file)
309 (Fcall_process_region):
310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
311 (Fcall_process): Simplify handling of volatile integers.
312 Use int, not EMACS_INT, where int will do.
313 * casefiddle.c (casify_object, casify_region, operate_on_word)
314 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
316 (casify_object): Avoid integer overflow when overallocating buffer.
317 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
318 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
319 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
320 * category.h (CATEGORYP): Don't assume arg is nonnegative.
321 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
322 integers are now checked earlier. All uses replaced with XINT.
324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
325 For CCL_MapSingle, check that content and value are in int range.
326 (ccl_driver, Fregister_code_conversion_map):
327 Check that Vcode_version_map_vector is a vector.
328 (resolve_symbol_ccl_program): Check that vector header is in range.
329 Always copy the vector, so that we can check its contents reliably
330 now rather than having to recheck each instruction as it's being
331 executed. Check that vector words fit in 'int'.
332 (ccl_get_compiled_code, Fregister_ccl_program)
333 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
334 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
335 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
336 contents are in range.
337 (Fccl_execute_on_string): Check that status is in range.
338 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
339 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
340 Accept and return EMACS_INT, not int, because callers can pass values
342 (c_string_width, strwidth, lisp_string_width, chars_in_text)
343 (multibyte_chars_in_text, parse_str_as_multibyte)
344 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
345 (str_as_unibyte, str_to_unibyte, string_count_byte8)
346 (string_escape_byte8, Fget_byte):
347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
348 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
349 avoid mishandling large integers.
350 * character.h: Adjust decls to match defn changes elsewhere.
351 * charset.c (load_charset_map_from_file, find_charsets_in_text)
352 (Ffind_charset_region):
353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
354 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
355 (load_charset_map_from_vector, Fdefine_charset_internal):
356 Don't assume fixnum fits in int.
357 (load_charset_map_from_vector, Fmap_charset_chars):
358 Remove now-unnecessary CHECK_NATNUMs.
359 (Fdefine_charset_internal): Check ranges here, more carefully.
360 Don't rely on undefined behavior with signed left shift overflow.
361 Don't assume unsigned int fits into fixnum, or that fixnum fits
362 into unsigned int. Don't require max_code to be a valid fixnum;
363 that's not true for gb10830 4-byte on a 32-bit host. Allow
364 invalid_code to be a cons, for the same reason. Require code_offset
365 to be a character. Avoid int overflow if max_char is close
367 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
368 this is intended anyway and avoids some undefined behavior.
369 (load_charset_map): Pass unsigned, not int, as 2nd arg of
370 INDEX_TO_CODE_POINT, as that's what it expects.
371 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
372 * charset.h (DECODE_CHAR): Return int, not unsigned;
373 this is what was intended anyway, and it avoids undefined behavior.
374 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
375 integer-overflow issues.
376 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
377 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
378 where the argument is EMACS_INT, and this behavior is not intended.
379 * chartab.c (Fmake_char_table, Fset_char_table_range)
380 (uniprop_get_decoder, uniprop_get_encoder):
381 Don't assume fixnum fits in int.
382 * cmds.c (move_point): New function, that does the gist of
383 Fforward_char and Fbackward_char, but does so while checking
384 for integer overflow more accurately.
385 (Fforward_char, Fbackward_char): Use it.
386 (Fforward_line, Fend_of_line, internal_self_insert)
387 (internal_self_insert):
388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
389 Fix a FIXME, by checking for integer overflow when calculating
390 target_clm and actual_clm.
391 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
392 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
393 (ASSURE_DESTINATION, coding_alloc_by_realloc)
394 (coding_alloc_by_making_gap, alloc_destination)
395 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
396 (encode_coding_utf_16, detect_coding_emacs_mule)
397 (decode_coding_emacs_mule, encode_coding_emacs_mule)
398 (detect_coding_iso_2022, decode_coding_iso_2022)
399 (encode_invocation_designation, encode_designation_at_bol)
400 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
401 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
402 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
403 (encode_coding_ccl, encode_coding_raw_text)
404 (detect_coding_charset, decode_coding_charset)
405 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
406 (produce_composition, produce_charset, produce_annotation)
407 (decode_coding, handle_composition_annotation)
408 (handle_charset_annotation, consume_chars, decode_coding_gap)
409 (decode_coding_object, encode_coding_object, detect_coding_system)
410 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
411 (code_convert_region, code_convert_string)
412 (Fdefine_coding_system_internal)
413 (coding_set_source, coding_set_destination):
414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
415 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
416 (Fdefine_coding_system_internal):
417 Don't assume fixnums fit in int.
418 (decode_coding_gap, decode_coding_object, encode_coding_object)
419 (Fread_coding_system, Fdetect_coding_region)
420 (Funencodable_char_position, Fcheck_coding_systems_region)
421 (get_translation, handle_composition_annotation, consume_chars):
422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
423 (consume_chars): Rewrite to not calculate an address outside buffer.
424 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
425 Don't access memory outside of the args array.
426 (Fdefine_coding_system_internal): Check for charset-id overflow.
427 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
428 result of ENCODE_CHAR.
429 * coding.h: Adjust decls to match defn changes elsewhere.
430 (struct coding_system):
431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
432 * composite.c (get_composition_id, find_composition)
433 (run_composition_function, update_compositions)
434 (compose_text, composition_gstring_put_cache)
435 (composition_gstring_p, composition_gstring_width)
436 (fill_gstring_header, fill_gstring_body, autocmp_chars)
437 (composition_compute_stop_pos, composition_reseat_it)
438 (composition_update_it, struct position_record)
439 (find_automatic_composition, composition_adjust_point)
440 (Fcomposition_get_gstring, Ffind_composition_internal):
441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
442 (update_compositions):
443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
444 * composite.h: Adjust decls to match defn changes elsewhere.
445 (struct composition):
446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
447 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
448 Do not attempt to compute the address of the object just before a
449 buffer; this is not portable.
451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
452 (Faset): Use int, not EMACS_INT, where int is wide enough.
453 (Fstring_to_number): Don't assume fixnums fit in int.
454 (Frem): Don't assume arg is nonnegative.
455 * dbusbind.c (xd_append_arg): Check for integers out of range.
456 (Fdbus_call_method): Don't overflow the timeout int.
457 (extract_signed, extract_unsigned): New functions.
458 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
459 (xd_get_connection_references): Return ptrdiff_t, not int.
461 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
463 Use int, not unsigned, where the dbus API uses int.
464 (Fdbus_message_internal): Don't overflow mtype.
465 (syms_of_dbusbind): Allocate right-sized buffer for integers.
466 * dired.c (directory_files_internal, file_name_completion, scmp)
467 (file_name_completion_stat):
468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
469 (file_name_completion): Don't overflow matchcount.
470 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
471 * dispextern.h: Adjust decls to match defn changes elsewhere.
472 (struct text_pos, struct glyph, struct bidi_saved_info)
473 (struct bidi_string_data, struct bidi_it, struct composition_it)
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (struct display_pos, struct composition_it, struct it):
477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
478 * dispnew.c (increment_matrix_positions)
479 (increment_row_positions, mode_line_string)
480 (marginal_area_string):
481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
482 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
484 (duration_to_sec_usec): New function, to check for overflow better.
485 (Fsleep_for, sit_for): Use it.
486 * doc.c (get_doc_string, store_function_docstring):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
488 (get_doc_string, Fsnarf_documentation):
489 Use int, not EMACS_INT, where int is wide enough.
491 Use SAFE_ALLOCA, not alloca.
492 Check for overflow when converting EMACS_INT to off_t.
494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
495 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
496 Don't assume uid_t fits into fixnum.
497 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
498 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
499 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
500 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
501 (general_insert_function)
502 (Finsert_char, make_buffer_string, make_buffer_string_both)
503 (update_buffer_properties, Fbuffer_substring)
504 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
505 (Fsubst_char_in_region, check_translation)
506 (Ftranslate_region_internal, save_restriction_restore, Fformat)
507 (transpose_markers, Ftranspose_regions):
508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
509 (clip_to_bounds): Move to lisp.h as an inline function).
510 (Fconstrain_to_field): Don't assume integers are nonnegative.
511 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
512 (Fsubst_char_in_region, Fsave_restriction):
513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
514 (Femacs_pid): Don't assume pid_t fits into fixnum.
515 (lo_time): Use int, not EMACS_INT, when int suffices.
516 (lisp_time_argument): Check for usec out of range.
517 (Fencode_time): Don't assume fixnum fits in int.
518 (Fuser_login_name, Fuser_full_name): Signal an error
519 if a uid argument is out of range, rather than relying on
521 (Fformat_time_string): Remove now-unnecessary check.
522 lisp_time_argument checks for out-of-range usec now.
523 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
524 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
525 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
526 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
527 (init_cmdargs, Fdump_emacs):
528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
529 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
530 the bottom (typically) 32 bits of the fixnum.
531 * eval.c (specpdl_size, call_debugger):
532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
533 (when_entered_debugger, Fbacktrace_debug):
534 Don't assume fixnum can fit in int.
535 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
536 the object just before a buffer; this is not portable.
537 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
538 (grow_specpdl, unbind_to):
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
541 (grow_specpdl): Simplify allocation by using xpalloc.
542 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
543 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
544 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
546 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
549 (Fcopy_file, non_regular_nbytes, read_non_regular)
550 (Finsert_file_contents):
551 Use int, not EMACS_INT, where int is wide enough.
552 (READ_BUF_SIZE): Verify that it fits in int.
553 (Finsert_file_contents): Check that counts are in proper range,
554 rather than assuming fixnums fit into ptrdiff_t etc.
555 Don't assume fixnums fit into int.
556 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
557 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
558 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
559 (string_char_to_byte, string_byte_to_char)
560 (string_make_multibyte, string_to_multibyte)
561 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
562 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
563 (substring_both, Fdelete, internal_equal, Ffillarray)
564 (Fclear_string, mapcar1)
565 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
566 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
567 (larger_vector, make_hash_table, maybe_resize_hash_table)
568 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
569 (Fmaphash, secure_hash):
570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
571 (concat): Check for string index and length overflow.
572 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
575 (larger_vector): New API (vec, incr_min, size_max) replaces old
576 one (vec, new_size, init). This catches size overflow.
577 INIT was removed because it was always Qnil.
579 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
580 the upper bound on a hash table index size.
581 (make_hash_table, maybe_resize_hash_table): Use it.
582 (secure_hash): Computer start_byte and end_byte only after
583 they're known to be in ptrdiff_t range.
584 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
585 (Ffont_get_glyphs, Ffont_at):
586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
587 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
588 (Flist_fonts, Fopen_font):
589 Don't assume fixnum can fit in int.
590 (check_gstring): Don't assume index can fit in int.
591 (font_match_p): Check that fixnum is a character, not a nonnegative
592 fixnum, since the later code needs to stuff it into an int.
593 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
594 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
595 conversion overflow issues.
596 (Fopen_font): Check for integer out of range.
597 (Ffont_get_glyphs): Don't assume index can fit in int.
598 * font.h: Adjust decls to match defn changes elsewhere.
599 * fontset.c (reorder_font_vector): Redo score calculation to avoid
601 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
602 printmax_t, where ptrdiff_t is wide enough.
603 (Finternal_char_font):
604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
605 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
606 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
607 (Fset_frame_position, x_set_frame_parameters)
608 (x_set_line_spacing, x_set_border_width)
609 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
610 Check that fixnums are in proper range for system types.
611 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
614 Use SAFE_ALLOCA_LISP, not alloca.
615 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
616 intptr_t is wide enough.
617 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
618 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
619 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
620 Check for fixnum out of range.
621 * ftfont.c (ftfont_list): Don't assume index fits in int.
622 Check that fixnums are in proper range for system types.
623 (ftfont_shape_by_flt):
624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
625 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
628 Check that fixnums are in proper range for system types.
629 * gnutls.h: Adjust decls to match defn changes elsewhere.
630 * gtkutil.c (xg_dialog_run):
631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
632 (update_frame_tool_bar):
633 Check that fixnums are in proper range for system types.
634 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
635 (lookup_image): Check that fixnums are in range for system types.
636 * indent.c (last_known_column, last_known_column_point):
637 (current_column_bol_cache):
638 (skip_invisible, current_column, check_display_width):
639 (check_display_width, scan_for_column, current_column_1)
640 (Findent_to, Fcurrent_indentation, position_indentation)
641 (indented_beyond_p, Fmove_to_column, compute_motion):
642 (Fcompute_motion, Fvertical_motion):
643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
644 (last_known_column_modified): Use EMACS_INT, not int.
645 (check_display_width):
647 Check that fixnums and floats are in proper range for system types.
648 (compute_motion): Don't assume index or fixnum fits in int.
649 (compute_motion, Fcompute_motion):
650 Use int, not EMACS_INT, when it is wide enough.
651 (vmotion): Omit local var start_hpos that is always 0; that way
652 we don't need to worry about overflow in expressions involving it.
653 * indent.h: Adjust decls to match defn changes elsewhere.
655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
656 Use int, not EMACS_INT, where int is wide enough.
657 Remove unused members ovstring_chars_done and tab_offset;
659 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
660 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
661 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
662 (make_gap, copy_text, insert, insert_and_inherit)
663 (insert_before_markers, insert_before_markers_and_inherit)
664 (insert_1, count_combining_before, count_combining_after)
665 (insert_1_both, insert_from_string)
666 (insert_from_string_before_markers, insert_from_string_1)
667 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
668 (adjust_after_replace, adjust_after_insert, replace_range)
669 (replace_range_2, del_range, del_range_1, del_range_byte)
670 (del_range_both, del_range_2, modify_region)
671 (prepare_to_modify_buffer, signal_before_change)
672 (signal_after_change, Fcombine_after_change_execute):
673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
674 * intervals.c (traverse_intervals, rotate_right, rotate_left)
675 (balance_an_interval, split_interval_right, split_interval_left)
676 (find_interval, next_interval, update_interval)
677 (adjust_intervals_for_insertion, delete_node, delete_interval)
678 (interval_deletion_adjustment, adjust_intervals_for_deletion)
679 (static_offset_intervals, offset_intervals)
680 (merge_interval_right, merge_interval_left, make_new_interval)
681 (graft_intervals_into_buffer, temp_set_point_both)
682 (temp_set_point, set_point, adjust_for_invis_intang)
683 (set_point_both, move_if_not_intangible, get_property_and_range)
684 (get_local_map, copy_intervals, copy_intervals_to_string)
685 (compare_string_intervals, set_intervals_multibyte_1):
686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
687 * intervals.h: Adjust decls to match defn changes elsewhere.
689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
690 * keyboard.c (this_command_key_count, this_single_command_key_start)
691 (before_command_key_count, before_command_echo_length, echo_now)
692 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
693 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
694 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
695 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
697 (last_non_minibuf_size, last_point_position, echo_truncate)
698 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
699 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
700 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
701 (stuff_buffered_input):
702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
703 (last_auto_save, command_loop_1, read_char):
704 Use EMACS_INT, not int, to avoid integer overflow.
705 (record_char): Avoid overflow in total_keys computation.
706 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
707 * keyboard.h: Adjust decls to match defn changes elsewhere.
708 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
709 (Fkey_description, Fdescribe_vector, Flookup_key):
710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
711 (click_position): New function, to check that positions are in range.
712 (Fcurrent_active_maps):
714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
715 (Faccessible_keymaps, Fkey_description):
716 (preferred_sequence_p):
717 Don't assume fixnum can fit into int.
718 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
719 Check for integer overflow in size calculations.
720 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
721 avoid mishandling large integers.
722 * lisp.h: Adjust decls to match defn changes elsewhere.
723 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
724 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
725 (struct Lisp_Marker):
726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
727 (clip_to_bounds): Now an inline function, moved here from editfns.c.
728 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
729 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
731 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
732 Assume the arg has valid form, since it always does.
733 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
734 unsigned integer system type.
735 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
736 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
738 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
739 (duration_to_sec_usec): New decl.
740 * lread.c (read_from_string_index, read_from_string_index_byte)
741 (read_from_string_limit, readchar, unreadchar, openp)
742 (read_internal_start, read1, oblookup):
743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
744 (Fload, readevalloop, Feval_buffer, Feval_region):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 (openp): Check for out-of-range argument to 'access'.
747 (read1): Use int, not EMACS_INT, where int is wide enough.
748 Don't assume fixnum fits into int.
749 Fix off-by-one error that can read outside a buffer.
750 (read_filtered_event): Use duration_to_sec_usec
751 to do proper overflow checking on durations.
752 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
754 (Fexecute_kbd_macro):
755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
756 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
757 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
758 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
759 (set_marker_both, set_marker_restricted_both, marker_position)
760 (marker_byte_position, Fbuffer_has_markers_at):
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
763 * menu.c (ensure_menu_items): Rename from grow_menu_items.
764 It now merely ensures that the menu is large enough, without
765 necessarily growing it, as this avoids some integer overflow issues.
767 (keymap_panes, parse_single_submenu, Fx_popup_menu):
768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
769 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
770 Use SAFE_ALLOCA_LISP, not alloca.
771 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
772 to EMACS_INT. Check that fixnums are in proper range for system types.
773 * minibuf.c (minibuf_prompt_width, string_to_object)
774 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
775 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
777 (get_minibuffer, read_minibuf_unwind):
778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
779 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
780 this simplifies overflow checking. All callers changed.
781 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
784 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
785 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
786 Check that fixnums are in proper range for system types.
787 (Fx_create_frame, Fx_show_tip):
788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
789 * nsfont.m (ns_findfonts, nsfont_list_family):
790 Don't assume fixnum fits in long.
791 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
793 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
795 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
797 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
798 (PRINTDECLARE, PRINTPREPARE):
799 (strout, print_string):
800 (print, print_preprocess, print_check_string_charset_prop)
802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
804 (temp_output_buffer_setup, Fprin1_to_string, print_object):
805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
806 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
807 (printchar, strout): Use xpalloc to catch size calculation overflow.
808 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
809 (print_error_message): Use SAFE_ALLOCA, not alloca.
810 (print_object): Use int, not EMACS_INT, where int is wide enough.
811 (print_depth, new_backquote_output, print_number_index):
812 Use ptrdiff_t, not int, where int might not be wide enough.
813 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
814 (Fset_process_window_size, Fformat_network_address)
815 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
817 Check that fixnums are in proper range for system types.
818 (Fsignal_process): Simplify by avoiding a goto.
819 Check for process-ids out of pid_t range rather than relying on
821 (process_tick, update_tick): Use EMACS_INT, not int.
822 (Fformat_network_address, read_process_output, send_process)
823 (Fprocess_send_region, status_notify):
824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
825 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
826 (wait_reading_process_output, read_process_output, exec_sentinel):
827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
828 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
829 (Faccept_process_output): Use duration_to_sec_usec to do proper
830 overflow checking on durations.
831 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
832 Don't assume pid_t fits in int.
833 * process.h (struct Lisp_Process): Members tick and update_tick
834 are now of type EMACS_INT, not int.
835 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
836 configured --with-wide-int.
837 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
838 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
839 * search.c (looking_at_1, string_match_1):
840 (fast_string_match, fast_c_string_match_ignore_case)
841 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
842 (scan_newline, find_before_next_newline, search_command)
843 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
844 (set_search_regs, wordify):
847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
848 (string_match_1, search_buffer, set_search_regs):
850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
851 (wordify): Check for overflow in size calculation.
852 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
853 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
854 Check that fixnums are in proper range for system types.
855 * sound.c (struct sound_device)
856 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
858 (Fplay_sound_internal):
859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
860 * syntax.c (struct lisp_parse_state, find_start_modiff)
861 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
862 (Fparse_partial_sexp):
863 Don't assume fixnums can fit in int.
864 (struct lisp_parse_state, find_start_pos, find_start_value)
865 (find_start_value_byte, find_start_begv)
866 (update_syntax_table, char_quoted, dec_bytepos)
867 (find_defun_start, prev_char_comend_first, back_comment):
868 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
869 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
871 (Finternal_describe_syntax_value): Check that match_lisp is a
872 character, not an integer, since the code stuffs it into int.
873 (scan_words, scan_sexps_forward):
874 Check that fixnums are in proper range for system types.
876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
877 (scan_sexps_forward):
878 Use CHARACTERP, not INTEGERP, since the value must fit into int.
879 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
880 * syntax.h: Adjust decls to match defn changes elsewhere.
882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
883 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
884 MOST_POSITIVE_FIXNUM.
885 * sysdep.c (wait_for_termination_1, wait_for_termination)
886 (interruptible_wait_for_termination, mkdir):
887 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
888 (emacs_read, emacs_write):
889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
890 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
891 and double all fit in int.
892 * term.c (set_tty_color_mode):
893 Check that fixnums are in proper range for system types.
894 * termhooks.h (struct input_event):
895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
896 * textprop.c (validate_interval_range, interval_of)
897 (Fadd_text_properties, set_text_properties_1)
898 (Fremove_text_properties, Fremove_list_of_text_properties)
899 (Ftext_property_any, Ftext_property_not_all)
900 (copy_text_properties, text_property_list, extend_property_ranges)
901 (verify_interval_modification):
902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
903 (Fnext_single_char_property_change)
904 (Fprevious_single_char_property_change):
905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
906 (copy_text_properties):
907 Check for integer overflow in index calculation.
908 * undo.c (last_boundary_position, record_point, record_insert)
909 (record_delete, record_marker_adjustment, record_change)
910 (record_property_change):
911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
912 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
914 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
915 (Fx_hide_tip, Fx_file_dialog):
916 * w32menu.c (set_frame_menubar):
917 Use ptrdiff_t, not int, for consistency with rest of code.
918 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
919 (select_window, Fdelete_other_windows_internal)
920 (window_scroll_pixel_based, window_scroll_line_based)
921 (Frecenter, Fset_window_configuration):
922 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
923 (Fset_window_hscroll, run_window_configuration_change_hook)
924 (set_window_buffer, temp_output_buffer_show, scroll_command)
925 (Fscroll_other_window, Frecenter):
926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
927 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
928 Don't assume fixnum fits in int.
929 (Fset_window_scroll_bars):
930 Check that fixnums are in proper range for system types.
931 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
932 (string_pos, c_string_pos, number_of_chars, init_iterator)
933 (in_ellipses_for_invisible_text_p, init_from_display_pos)
934 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
935 (compute_display_string_end, handle_face_prop)
936 (face_before_or_after_it_pos, handle_invisible_prop)
937 (handle_display_prop, handle_display_spec, handle_single_display_spec)
938 (display_prop_intangible_p, string_buffer_position_lim)
939 (string_buffer_position, handle_composition_prop, load_overlay_strings)
940 (get_overlay_strings_1, get_overlay_strings)
941 (iterate_out_of_display_property, forward_to_next_line_start)
942 (back_to_previous_visible_line_start, reseat, reseat_to_string)
943 (get_next_display_element, set_iterator_to_next)
944 (get_visually_first_element, compute_stop_pos_backwards)
945 (handle_stop_backwards, next_element_from_buffer)
946 (move_it_in_display_line_to, move_it_in_display_line)
947 (move_it_to, move_it_vertically_backward, move_it_by_lines)
948 (add_to_log, message_dolog, message_log_check_duplicate)
949 (message2, message2_nolog, message3, message3_nolog
950 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
951 (current_message_1, truncate_echo_area, truncate_message_1)
952 (set_message, set_message_1, store_mode_line_noprop)
953 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
954 (text_outside_line_unchanged_p, check_point_in_composition)
955 (reconsider_clip_changes)
956 (redisplay_internal, set_cursor_from_row, try_scrolling)
957 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
958 (redisplay_window, find_last_unchanged_at_beg_row)
959 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
960 (trailing_whitespace_p, find_row_edges, display_line)
961 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
962 (display_mode_element, store_mode_line_string)
963 (pint2str, pint2hrstr, decode_mode_spec)
964 (display_count_lines, display_string, draw_glyphs)
965 (x_produce_glyphs, x_insert_glyphs)
966 (rows_from_pos_range, mouse_face_from_buffer_pos)
967 (fast_find_string_pos, mouse_face_from_string_pos)
968 (note_mode_line_or_margin_highlight, note_mouse_highlight):
969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
970 (safe_call, init_from_display_pos, handle_fontified_prop)
971 (handle_single_display_spec, load_overlay_strings)
972 (with_echo_area_buffer, setup_echo_area_for_printing)
973 (display_echo_area, echo_area_display)
974 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
975 (update_tool_bar, hscroll_window_tree, redisplay_internal)
976 (redisplay_window, dump_glyph_row, display_mode_line)
977 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
978 (handle_display_spec, display_prop_string_p):
979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
980 (handle_single_display_spec, build_desired_tool_bar_string)
981 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
982 (get_specified_cursor_type):
983 Check that fixnums are in proper range for system types.
984 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
986 Don't assume fixnums fit in int.
987 (compare_overlay_entries):
988 Avoid mishandling comparisons due to subtraction overflow.
989 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
990 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
991 (handle_tool_bar_click):
992 Use int, not unsigned, since we prefer signed and the signedness
994 (get_next_display_element, next_element_from_display_vector):
995 Use int, not EMACS_INT, when int is wide enough.
996 (start_hourglass): Use duration_to_sec_usec to do proper
997 overflow checking on durations.
998 * xfaces.c (Fbitmap_spec_p):
999 Check that fixnums are in proper range for system types.
1000 (compare_fonts_by_sort_order):
1001 Avoid mishandling comparisons due to subtraction overflow.
1002 (Fx_family_fonts, realize_basic_faces):
1003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1005 Don't assume fixnum fits in int.
1006 Use SAFE_ALLOCA_LISP, not alloca.
1007 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1008 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1009 (face_at_buffer_position, face_for_overlay_string)
1010 (face_at_string_position):
1011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1012 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1013 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1015 Check that fixnums are in proper range for system types.
1016 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1017 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1019 (Fx_change_window_property): Don't assume fixnums fit in int.
1020 * xfont.c (xfont_chars_supported):
1021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1022 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1023 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1025 * xml.c (parse_region):
1026 * xrdb.c (magic_file_p):
1027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1028 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1029 (x_get_local_selection, x_reply_selection_request)
1030 (x_handle_selection_request, wait_for_property_change):
1031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1032 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1033 short is wide enough.
1034 (x_send_client_event): Don't assume fixnum fits in int.
1035 * xterm.c (x_x_to_emacs_modifiers):
1036 Don't assume EMACS_INT overflows nicely into int.
1037 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1039 (handle_one_xevent): NATNUMP can eval its arg twice.
1040 (x_connection_closed):
1041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1042 * xterm.h: Adjust decls to match defn changes elsewhere.
1043 (struct scroll_bar): Use struct vectorlike_header
1044 rather than rolling our own approximation.
1045 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1047 2012-05-25 Glenn Morris <rgm@gnu.org>
1049 * lisp.mk (lisp): Update for more files being compiled now.
1051 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1053 * lread.c: Remove `read_pure' which makes no difference.
1054 (read_pure): Remove var.
1055 (unreadpure): Remove function.
1056 (readevalloop): Don't call read_list with -1 flag.
1057 (read1, read_vector): Don't test read_pure any more.
1058 (read_list): Simplify.
1060 * fileio.c, character.h: Minor style tweaks.
1062 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1064 * window.h (clip_changed): Remove useless declaration.
1066 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1068 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1069 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1071 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1074 This directory predates autoconf and is no longer needed nowadays.
1075 Move its few remaining bits of functionality to where they're needed.
1076 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1077 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1078 * m/template.h: Remove.
1079 * Makefile.in (M_FILE): Remove. All uses removed.
1080 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1081 * lisp.h (USE_LSB_TAG):
1082 * mem-limits.h (EXCEEDS_LISP_PTR):
1083 Use VAL_MAX, not VALBITS, in #if.
1084 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1085 (EMACS_UINT): Define unconditionally now.
1086 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1087 (BITS_PER_EMACS_INT): New constants, replacing
1088 what used to be in config.h, but not useful in #if.
1089 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1090 define them any more.
1091 (VAL_MAX): New macro.
1093 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1094 BITS_PER_EMACS_INT, in #if.
1095 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1096 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1097 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1098 * s/ms-w32.h (DATA_START):
1099 Move here from removed file m/intel386.h.
1100 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1101 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1103 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1105 Assume C89 or later.
1106 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1107 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1109 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1110 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1111 * textprop.c, tparam.c (NULL): Remove.
1112 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1113 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1114 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1115 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1116 * xterm.c (input_signal_count): Assume volatile works.
1118 2012-05-21 Ken Brown <kbrown@cornell.edu>
1120 * xgselect.c (xg_select): Fix first argument in call to 'select'
1123 2012-05-20 Ken Brown <kbrown@cornell.edu>
1125 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1126 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1128 2012-05-19 Ken Brown <kbrown@cornell.edu>
1130 * xfns.c (x_in_use): Remove `static' qualifier.
1131 * xterm.h (x_in_use): Declare.
1132 * xgselect.c: Include xterm.h.
1133 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1134 and `display_arg' (bug#9754).
1136 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1138 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1140 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1141 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1143 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1145 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1147 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1148 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1150 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1151 reference to image_cache->refcount.
1152 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1154 2012-05-17 Juri Linkov <juri@jurta.org>
1156 * search.c (Fword_search_regexp, Fword_search_backward)
1157 (Fword_search_forward, Fword_search_backward_lax)
1158 (Fword_search_forward_lax): Move functions to isearch.el
1159 (bug#10145, bug#11381).
1161 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1163 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1165 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1167 * lread.c (init_obarray): Declare Qt and Qnil as special.
1169 2012-05-14 Glenn Morris <rgm@gnu.org>
1171 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1172 Put "libexec" before "bin", for the sake of init_callproc_1.
1174 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1176 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1178 * unexaix.c: Port to more-recent AIX compilers.
1179 (report_error, report_error_1, make_hdr, copy_sym)
1180 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1181 Make arguments const char *, not char *, to avoid violations of C
1182 standard and to fix some AIX warnings reported by Gilles Pion.
1184 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1186 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1187 already have overlays loaded.
1188 (handle_single_display_spec): Before returning without displaying
1189 fringe bitmap, synchronize the bidi iterator with the main display
1190 iterator, by calling iterate_out_of_display_property.
1191 (iterate_out_of_display_property): Detect buffer iteration by
1192 testing that it->string is a Lisp string.
1193 (get_next_display_element): When the current object is exhausted,
1194 and there's something on it->stack, call set_iterator_to_next to
1195 proceed with what's on the stack, instead of returning zero.
1196 (set_iterator_to_next): If called at the end of a Lisp string,
1197 proceed to consider_string_end without incrementing string
1198 position. Don't increment display vector index past the end of
1199 the display vector. (Bug#11417)
1200 (pos_visible_p): Don't report a position visible when move_it_to
1201 stopped at the last line of window, which happens to be scanned
1202 backwards by the bidi iteration. (Bug#11464)
1204 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1206 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1207 and right-margin display specs even if the spec is invalid or we
1208 are on a TTY, and thus unable to display on the fringes.
1209 That's because the text with the property will not be displayed anyway,
1210 so we need to signal to the caller that this is a "replacing"
1211 display spec. This fixes display when the spec is invalid or we
1214 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1216 * unexaix.c (make_hdr): Fix typo in prototype.
1217 This bug broke the build on AIX. Problem reported by Gilles Pion.
1219 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1221 * keyboard.c (kbd_buffer_get_event): Read special events also in
1222 batch mode. (Bug#11415)
1224 2012-05-12 Glenn Morris <rgm@gnu.org>
1226 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1228 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1230 * lisp.mk (lisp): Add newcomment.elc.
1232 2012-05-12 Glenn Morris <rgm@gnu.org>
1234 * Makefile.in (MKDIR_P): New, set by configure.
1235 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1237 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1239 Remove unused function hourglass_started.
1240 * dispextern.h (hourglass_started):
1241 * w32fns.c (hourglass_started):
1242 * xdisp.c (hourglass_started): Remove.
1244 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1246 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1247 Update dependencies.
1249 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1251 * xgselect.c (xg_select): Put maxfds+1 into a var.
1252 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1254 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1256 2012-05-10 Dave Abrahams <dave@boostpro.com>
1258 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1259 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1261 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1263 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1264 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1265 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1266 Initialize xd_registered_buses.
1268 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1270 Untag more efficiently if USE_LSB_TAG.
1271 This is based on a proposal by YAMAMOTO Mitsuharu in
1272 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1273 For an admittedly artificial (nth 8000 longlist) benchmark on
1274 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1275 Emacs's overall text size by 1%.
1276 * lisp.h (XUNTAG): New macro.
1277 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1278 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1279 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1280 * eval.c (Fautoload):
1281 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1282 * frame.h (XFRAME): Use XUNTAG.
1284 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1285 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1286 Remove unportable assumptions about print widths of types like
1288 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1289 intptr_t when converting between pointer and integer, to avoid GCC
1290 warnings about wrong width.
1292 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1294 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1295 stack for each reader_thread, instead of defaulting to 8MB
1296 determined by the linker. This avoids failures in creating
1297 subprocesses on Windows 7, see the discussion in this thread:
1298 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1300 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1302 Fix up display of the *Minibuf-0* buffer in the mini window.
1303 * keyboard.c (read_char): Don't clear the echo area if there's no
1305 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1306 contents of *Minibuf-0*) if there's no message displayed in its stead.
1308 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1310 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1313 2012-05-06 Chong Yidong <cyd@gnu.org>
1315 * lisp.mk (lisp): Update.
1317 2012-05-05 Jim Meyering <meyering@redhat.com>
1319 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1321 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1323 * data.c (PUT_ERROR): New macro.
1324 (syms_of_data): Use it. Add new error type `user-error'.
1325 * undo.c (user_error): New function.
1326 (Fprimitive_undo): Use it.
1327 * print.c (print_error_message): Adjust print style for `user-error'.
1328 * keyboard.c (user_error): New function.
1329 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1331 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1333 Do not limit current-time-string to years 1000..9999.
1334 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1335 (Fcurrent_time_string): Support any year that is supported by the
1336 underlying localtime representation. Don't use asctime, as it
1337 has undefined behavior for years outside the range -999..9999.
1339 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1341 Fix race conditions involving setenv, gmtime, localtime, asctime.
1342 Without this fix, interrupts could mess up code that uses these
1343 nonreentrant functions, since setting TZ invalidates existing
1344 tm_zone or tzname values, and since most of these functions return
1345 pointers to static storage.
1346 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1347 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1348 Grow the critical sections to include not just invoking
1349 localtime/gmtime, but also accessing these functions' results
1350 including their tm_zone values if any, and any related TZ setting.
1351 (format_time_string): Last arg is now struct tm *, not struct tm **,
1352 so that the struct tm is saved in the critical section.
1353 All callers changed. Simplify allocation of initial buffer, partly
1354 motivated by the fact that memory allocation needs to be outside
1355 the critical section.
1357 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1359 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1360 with RESET_INTERVAL.
1362 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1363 Remove duplicated buffer name initialization.
1365 2012-05-02 Jim Meyering <jim@meyering.net>
1367 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1369 * xfns.c (x_window): Use xstrdup (Bug#11375).
1371 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1373 * xdisp.c (pos_visible_p): If already at a newline from the
1374 display string before the 'while' loop, don't walk back the glyphs
1375 from it3.glyph_row. Solves assertion violation when the display
1376 string begins with a newline (egg.el). (Bug#11367)
1378 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1380 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1383 2012-05-01 Glenn Morris <rgm@gnu.org>
1385 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1386 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1387 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1388 All were removed before 23.1.
1390 * dispnew.c: Remove HAVE_LIBNCURSES test;
1391 it is always true on relevant platforms.
1393 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1394 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1396 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1398 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1400 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1401 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1404 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1406 Do not avoid creating empty evaporating overlays (Bug#9642).
1407 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1408 That is, do not delete an evaporating overlay if it becomes
1409 empty after its bounds are adjusted to fit within its buffer.
1410 This fix caused other problems, and I'm reverting it until we get
1411 to the bottom of them.
1413 2012-04-27 Chong Yidong <cyd@gnu.org>
1415 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1417 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1419 * xdisp.c (pos_visible_p): If the window start position is beyond
1420 ZV, start the display from buffer beginning. Prevents assertion
1421 violation in init_iterator when the minibuffer window is scrolled
1424 * window.c (window_scroll_pixel_based): Likewise.
1426 2012-04-27 Chong Yidong <cyd@gnu.org>
1428 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1430 2012-04-27 Glenn Morris <rgm@gnu.org>
1432 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1433 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1435 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1437 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1438 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1440 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1442 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1443 display element, check also the underlying string or buffer
1444 character. (Bug#11341)
1446 * w32menu.c: Include w32heap.h.
1447 (add_menu_item): If the call to AppendMenuW (via
1448 unicode_append_menu) fails, disable Unicode menus only if we are
1449 running on Windows 9X/Me.
1451 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1453 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1454 (xgetint): Add missing shift for LSB tags.
1456 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1458 * keyboard.c (read_char): Don't wipe echo area for select window
1459 events: These might get delayed via `mouse-autoselect-window'
1462 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1464 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1465 manipulation of :loaded-from data.
1467 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1469 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1470 now a cons (bug#11311).
1472 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1474 Do not create empty overlays with the evaporate property (Bug#9642).
1475 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1476 if it becomes empty after its bounds are adjusted to fit within
1477 its buffer. Without this fix, in a nonempty buffer (let ((o
1478 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1479 yields an empty overlay that has the evaporate property, which is
1480 not supposed to happen.
1482 Fix minor GTK3 problems found by static checking.
1483 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1484 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1485 (struct _EmacsFixedClass, emacs_fixed_get_type):
1486 Move decls here from emacsgtkfixed.h, since they needn't be public.
1487 (emacs_fixed_get_type): Now static.
1488 (emacs_fixed_class_init): Omit unused local.
1489 (emacs_fixed_child_type): Remove; unused.
1490 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1491 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1492 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1493 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1494 (EMACS_FIXED_GET_CLASS): Remove; unused.
1495 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1497 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1498 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1500 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1502 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1503 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1504 (__malloc_size_t, __malloc_ptrdiff_t):
1505 Remove. All uses removed, replaced by the definiens if needed,
1506 since we can assume C89 or better now.
1507 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1508 (protect_malloc_state, align, get_contiguous_space)
1509 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1510 (malloc_atfork_handler_child, malloc_enable_thread)
1511 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1512 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1513 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1514 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1515 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1516 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1517 Define using prototypes, not old style.
1518 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1519 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1520 (align): Don't assume that signed integer overflow wraps around.
1521 Omit unused local var.
1522 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1523 (_free_internal_nolock, memalign, mallochook, reallochook):
1524 Omit no-longer-needed casts.
1525 (valloc): Use getpagesize, not __getpagesize.
1526 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1527 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1529 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1531 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1533 Move functions from C to Lisp. Make non-blocking method calls
1534 the default. Implement further D-Bus standard interfaces.
1536 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1537 (QCdbus_request_name_allow_replacement)
1538 (QCdbus_request_name_replace_existing)
1539 (QCdbus_request_name_do_not_queue)
1540 (QCdbus_request_name_reply_primary_owner)
1541 (QCdbus_request_name_reply_in_queue)
1542 (QCdbus_request_name_reply_exists)
1543 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1544 (QCdbus_registered_serial, QCdbus_registered_method)
1545 (QCdbus_registered_signal): New Lisp objects.
1546 (XD_DEBUG_MESSAGE): Use sizeof.
1547 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1548 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1549 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1550 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1551 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1552 (xd_signature, xd_append_arg): Allow float for integer types.
1553 (xd_get_connection_references): New function.
1554 (xd_get_connection_address): Rename from xd_initialize.
1555 Return cached address.
1556 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1557 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1559 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1560 Return number of refcounts.
1561 (Fdbus_get_unique_name): Make stronger parameter check.
1562 (Fdbus_message_internal): New defun.
1563 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1564 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1565 (Fdbus_send_signal, Fdbus_register_service)
1566 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1567 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1568 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1569 (Vdbus_compiled_version, Vdbus_runtime_version)
1570 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1571 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1572 (Vdbus_message_type_signal): New defvars.
1573 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1576 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1578 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1579 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1580 Do not assume ptrdiff_t is the same width as 'int'.
1582 * alloc.c: Handle unusual debugging option combinations.
1583 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1584 since the two debugging options are incompatible.
1585 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1587 (mem_init, mem_insert, mem_insert_fixup):
1588 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1589 (NEED_MEM_INSERT): Remove; no longer needed.
1591 2012-04-22 Leo Liu <sdl.web@gmail.com>
1593 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1595 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1597 * sysdep.c [__FreeBSD__]: Minor cleanups.
1598 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1599 Use Emacs indenting style more consistently. Avoid some casts.
1600 Use 'double' consistently rather than mixing 'float' and 'double'.
1602 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1604 * sysdep.c (list_system_processes, system_process_attributes):
1605 Add implementation for FreeBSD (Bug#5243).
1607 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1609 * lisp.mk (lisp): Update.
1611 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1613 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1614 It is never used otherwise.
1616 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1618 * print.c (print_preprocess): Only check print_depth if print-circle
1620 (print_object): Check for cycles even when print-circle is nil and
1621 print-gensym is t, but only check print_depth if print-circle is nil.
1623 2012-04-20 Chong Yidong <cyd@gnu.org>
1625 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1626 set the status to "failed" and ensure that sentinel is run.
1628 2012-04-20 Glenn Morris <rgm@gnu.org>
1630 * process.c (Fset_process_inherit_coding_system_flag)
1631 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1632 (Fmake_network_process, Fmake_serial_process): Doc fix.
1634 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1636 * xdisp.c (string_buffer_position_lim): Limit starting position to
1638 (set_cursor_from_row): If called for a mode-line or header-line
1639 row, return zero immediately.
1640 (try_cursor_movement): If inside continuation line, don't back up
1641 farther than the first row after the header line, if any.
1642 Don't consider the header-line row as "partially visible", even if
1643 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1645 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1647 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1650 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1651 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1653 configure: new option --enable-gcc-warnings (Bug#11207)
1654 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1655 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1656 (ALL_CFLAGS): Use new macros rather than old.
1657 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1658 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1659 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1660 -Wunused-result, -Wunused-variable. This should go away once
1661 the Emacs and Gnulib regex code is merged.
1662 (xmalloc, xrealloc): Now static.
1664 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1666 * dired.c (Fsystem_groups): Remove unused local.
1668 2012-04-17 Glenn Morris <rgm@gnu.org>
1670 * dired.c (Fsystem_users): Doc fix.
1672 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1674 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1675 (syms_of_dired): Add them.
1677 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1679 Fix minor alloc.c problems found by static checking.
1680 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1681 New extern decls, to avoid calling undeclared functions.
1682 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1683 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1684 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1685 (NEED_MEM_INSERT): New macro.
1686 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1687 Remove one incorrect comment and fix another.
1689 Fix minor ralloc.c problems found by static checking.
1690 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1691 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1692 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1693 (r_alloc_sbrk): Now static.
1695 Improve ralloc.c interface checking.
1696 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1697 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1698 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1699 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1700 [REL_ALLOC]: ... to here, to check interface.
1701 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1702 Remove decls. This fixes an "It stinks!".
1704 * alloc.c (which_symbols): Fix alignment issue / type clash.
1706 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1708 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1709 (struct Lisp_Misc_Any): Likewise.
1710 (struct Lisp_Free): Likewise.
1711 * alloc.c (union aligned_Lisp_Symbol): Define.
1712 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1713 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1714 (union aligned_Lisp_Misc): Define.
1715 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1716 aligned_Lisp_Misc instead of union Lisp_Misc.
1717 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1719 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1721 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1722 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1723 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1724 * s/netbsd.h, s/sol2-6.h:
1725 Remove definition of GC_MARK_STACK, since the default now works.
1726 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1727 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1728 no longer the default.
1729 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1731 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1733 * lread.c (lisp_file_lexically_bound_p):
1734 Fix hang at ";-*-\n" (bug#11238).
1736 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1738 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1739 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1741 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1743 * nsterm.m (constrainFrameRect): Always constrain when there is only
1744 one screen (Bug#10962).
1746 2012-04-13 Ken Brown <kbrown@cornell.edu>
1748 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1750 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1752 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1754 2012-04-11 Daniel Colascione <dancol@dancol.org>
1756 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1757 against is gone. It's better to use vfork now so that when Cygwin
1758 gains a new, working vfork, we use it automatically (bug#10398).
1760 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1762 * window.c (save_window_save): Obey window-point-insertion-type.
1764 2012-04-11 Glenn Morris <rgm@gnu.org>
1766 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1768 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1770 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1772 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1774 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1775 (force_quit_count): New var.
1776 (handle_interrupt): Use it.
1778 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1780 * w32.c (w32_delayed_load): Record the full path of the library
1781 being loaded (bug#10424).
1783 2012-04-09 Glenn Morris <rgm@gnu.org>
1785 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1786 not just in the obarray, before snarfing them. (Bug#11036)
1788 * Makefile.in ($(leimdir)/leim-list.el):
1789 Pass EMACS rather than BUILT_EMACS.
1791 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1793 * process.c (make_process):
1794 * process.h: Add integer `gnutls_handshakes_tried' member to
1797 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1798 Add convenience `GNUTLS_LOG2i' macro.
1800 * gnutls.c (gnutls_log_function2i): Convenience log function.
1801 (emacs_gnutls_read): Use new log functions,
1802 `gnutls_handshakes_tried' process member, and
1803 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1804 attempts per process (connection).
1806 2012-04-09 Chong Yidong <cyd@gnu.org>
1808 * eval.c (Fuser_variable_p, user_variable_p_eh)
1809 (lisp_indirect_variable): Functions deleted.
1810 (Fdefvar): Caller changed.
1812 * callint.c (Finteractive, Fcall_interactively):
1813 * minibuf.c (Fread_variable): Callers changed.
1815 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1817 * xdisp.c (set_cursor_from_row): If the display string appears in
1818 the buffer at position that is closer to point than the position
1819 after the display string, display the cursor on the first glyph of
1820 the display string. Fixes cursor display when a 'display' text
1821 property immediately follows invisible text. (Bug#11094)
1823 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1825 composite.c: use 'double' consistently
1826 * composite.c (get_composition_id): Use 'double' consistently
1827 instead of converting 'float' to 'double' and vice versa; this is
1828 easier to understand and avoids a GCC warning.
1830 2012-04-09 Glenn Morris <rgm@gnu.org>
1832 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1833 preparation for dumping it with emacs. (Bug#4789)
1834 (leimdir): New variable.
1835 ($(leimdir)/leim-list.el): New rule.
1836 (emacs$(EXEEXT)): Depend on leim-list.el.
1838 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1839 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1840 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1842 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1844 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1847 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1849 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1850 Remove unused local variable.
1852 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1854 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1855 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1856 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1857 objects, as mark_maybe_pointer will catch them otherwise.
1858 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1859 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1861 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1863 Fix typo that broke non-Windows builds.
1864 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1866 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1868 Support building on MS-Windows with libxml2.
1870 * makefile.w32-in (OBJ2): Add xml.$(O).
1871 (GLOBAL_SOURCES): Add xml.c.
1872 ($(BLD)/xml.$(O)): New dependency list.
1874 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1875 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1876 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1877 [!WINDOWSNT]: New macros.
1878 (init_libxml2_functions, libxml2_loaded_p): New functions.
1879 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1880 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1881 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1882 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1884 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1885 Call init_libxml2_functions before calling libxml2 functions.
1886 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1888 * emacs.c: Don't include libxml/parser.h.
1889 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1890 xmlCleanupParser directly.
1892 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1894 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1896 * indent.c (Fvertical_motion): If there is a display string at
1897 point, use it.vpos to compute how many lines to backtrack after
1898 move_it_to point. (Bug#11133)
1900 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1902 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1903 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1904 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1905 macros related to unification of CJK characters. For the details,
1906 see the discussion following the message here:
1907 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1909 2012-04-04 Chong Yidong <cyd@gnu.org>
1911 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1913 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1915 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1916 instead of alloca. (Bug#11138)
1918 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1920 * w32menu.c (is_simple_dialog): Properly check lisp types.
1923 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1925 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1926 position we get to after a call to move_it_to fails the
1927 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1928 only if we wind up in a string from display property. (Bug#11063)
1930 * window.c (Fdelete_other_windows_internal): Invalidate the row
1931 and column information about mouse highlight, so that redisplay
1932 restores it after reallocating the glyph matrices. (Bug#7464)
1934 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1935 string comes from a `display' text property, use the buffer
1936 position of that property as if we actually saw that position in
1938 (move_it_by_lines): Remove the assertion that
1939 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1940 violated when there's a before-string at the beginning of a line.
1943 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1945 * xdisp.c (append_space_for_newline): If the default face was
1946 remapped, use the remapped face for the appended newline.
1947 (extend_face_to_end_of_line): Use the remapped default face for
1948 extending the face to the end of the line.
1949 (display_line): Call extend_face_to_end_of_line when the default
1950 face was remapped. (Bug#11068)
1952 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1954 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1956 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1958 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1960 2012-03-27 Glenn Morris <rgm@gnu.org>
1962 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1965 2012-03-26 Kenichi Handa <handa@m17n.org>
1967 * dispextern.h (struct glyph): Fix previous change. Change the
1968 bit length of glyphless.ch to 25 (Bug#11082).
1970 2012-03-26 Chong Yidong <cyd@gnu.org>
1972 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1973 (command_loop_1): Use it; inhibit selection update for
1974 handle-select-window too (Bug#8996).
1976 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1978 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1980 2012-03-25 Kenichi Handa <handa@m17n.org>
1982 * dispextern.h (struct glyph): Change the bit length of
1983 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1985 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1987 * s/ms-w32.h (tzname): Include time.h before redirecting to
1988 _tzname. Fixes the MSVC build. (Bug#9960)
1990 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1992 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1995 * xterm.c (XTread_socket): Only modify handling_signal if
1996 !SYNC_INPUT. (Bug#11080)
1998 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2000 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2001 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2002 when fetching a multibyte character consumes more bytes than
2003 CHAR_BYTES returns, due to unification of CJK characters in
2004 string_char. (Bug#11073)
2006 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2008 * process.c (wait_reading_process_output): Handle pty disconnect
2009 by refraining from sending oneself a SIGCHLD (bug#10933).
2011 2012-03-22 Chong Yidong <cyd@gnu.org>
2013 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2015 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2016 Mark string as coming from a prefix property.
2017 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2018 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2020 2012-03-21 Chong Yidong <cyd@gnu.org>
2022 * xfaces.c (Vface_remapping_alist): Doc fix.
2024 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2026 * w32proc.c (Fw32_set_console_codepage)
2027 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2030 2012-03-20 Chong Yidong <cyd@gnu.org>
2032 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2033 to reflect default non-nil value of redisplay-dont-pause.
2035 2012-03-19 Kenichi Handa <handa@m17n.org>
2037 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2038 it fit in a valid range (Bug#11003).
2040 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2042 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2043 that is not from display property, accept the row as a "cursor
2044 row" if one of the string's character has a non-nil `cursor'
2045 property. Fixes cursor positioning when there are newlines in
2046 overlay strings, e.g. in icomplete.el. (Bug#11035)
2048 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2050 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2052 2012-03-12 Chong Yidong <cyd@gnu.org>
2054 * eval.c (inhibit_lisp_code): Rename from
2055 inhibit_window_configuration_change_hook; move from window.c.
2057 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2058 * window.c (run_window_configuration_change_hook)
2059 (syms_of_window): Callers changed.
2061 2012-03-11 Chong Yidong <cyd@gnu.org>
2063 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2065 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2067 2012-03-10 Chong Yidong <cyd@gnu.org>
2069 * frame.c (other_visible_frames): Don't assume the selected frame
2070 is visible (Bug#10955).
2072 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2074 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2076 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2078 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2079 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2082 2012-03-03 Glenn Morris <rgm@gnu.org>
2084 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2086 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2088 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2089 position past the first glyph_row that ends at ZV. (Bug#10902)
2090 (redisplay_window, next_element_from_string): Fix typos in
2092 (redisplay_window): Pass to move_it_vertically the margin in
2093 pixels, not in screen lines.
2095 2012-03-02 Glenn Morris <rgm@gnu.org>
2097 * buffer.c (buffer-list-update-hook): Doc fix.
2099 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2101 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2102 push_it before setting up the iterator for the first overlay
2103 string, even if we have an empty string loaded.
2104 (next_overlay_string): If there's an empty string on the iterator
2105 stack, pop the stack. (Bug#10903)
2107 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2109 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2110 Suggested by Stefan Monnier in
2111 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2112 * alloc.c (widen_to_Lisp_Object): New static function.
2113 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2114 and widening them to Lisp_Objects. This would work even if
2115 USE_LSB_TAG is defined and wide integers are used, which might
2116 happen in a future version of Emacs.
2118 2012-02-25 Chong Yidong <cyd@gnu.org>
2120 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2123 * xselect.c (Fx_selection_exists_p): Doc fix.
2124 (x_clipboard_manager_save_all): Print an informative message
2125 before saving to clipboard manager.
2127 2012-02-24 Chong Yidong <cyd@gnu.org>
2129 * keyboard.c (process_special_events): Handle all X selection
2130 requests in kbd_buffer, not just the next one (Bug#8869).
2132 2012-02-23 Chong Yidong <cyd@gnu.org>
2134 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2135 call when setting menu-bar-lines and tool-bar-lines parameters.
2136 (unwind_create_frame_1): New helper function.
2138 * window.c (inhibit_window_configuration_change_hook): New var.
2139 (run_window_configuration_change_hook): Obey it.
2140 (syms_of_window): Initialize it.
2142 2012-02-22 Chong Yidong <cyd@gnu.org>
2144 * xterm.c (x_draw_image_relief): Add missing type check for
2145 Vtool_bar_button_margin (Bug#10743).
2147 2012-02-21 Chong Yidong <cyd@gnu.org>
2149 * fileio.c (Vfile_name_handler_alist): Doc fix.
2151 * buffer.c (Fget_file_buffer): Protect against invalid file
2152 handler return value.
2154 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2156 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2157 when computing $valmask.
2159 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2160 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2161 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2162 It's useless in that case, and it can cause problems on hosts
2163 that allocate halves of EMACS_INT values separately.
2164 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2165 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2166 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2167 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2168 it avoids undefined behavior on hosts where shifting right by more
2169 than the word width has undefined behavior.
2171 2012-02-19 Chong Yidong <cyd@gnu.org>
2173 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2174 (Funhandled_file_name_directory, Ffile_name_as_directory)
2175 (Fdirectory_file_name, Fexpand_file_name)
2176 (Fsubstitute_in_file_name): Protect against invalid file handler
2177 return values (Bug#10845).
2179 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2181 * .gdbinit (pitx): Fix incorrect references to fields of the
2184 2012-02-17 Chong Yidong <cyd@gnu.org>
2186 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2188 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2190 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2191 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2193 2012-02-15 Chong Yidong <cyd@gnu.org>
2195 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2196 marked as special. Also, starting docstrings with * is obsolete.
2198 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2200 * gnutls.c (emacs_gnutls_write): Fix last change.
2202 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2204 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2207 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2209 * keymap.c (Fsingle_key_description): Handle char ranges.
2211 2012-02-12 Chong Yidong <cyd@gnu.org>
2213 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2214 as that creates a dangerous corner case.
2216 * window.c (Fdelete_window_internal): Invalidate the mouse
2217 highlight (Bug#9904).
2219 2012-02-12 Glenn Morris <rgm@gnu.org>
2221 * xselect.c (Fx_own_selection_internal)
2222 (Fx_get_selection_internal, Fx_disown_selection_internal)
2223 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2224 * nsselect.m (Fx_own_selection_internal)
2225 (Fx_disown_selection_internal, Fx_selection_exists_p)
2226 (Fx_selection_owner_p, Fx_get_selection_internal):
2227 Sync docs and argument specs with the xselect.c versions.
2229 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2231 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2233 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2235 * w32select.c (Fx_selection_exists_p): Sync doc string and
2236 argument list with xselect.c. (Bug#10783)
2238 * w16select.c (Fx_selection_exists_p): Sync doc string and
2239 argument list with xselect.c. (Bug#10783)
2241 2012-02-10 Glenn Morris <rgm@gnu.org>
2243 * fns.c (Fsecure_hash): Doc fix.
2245 2012-02-09 Kenichi Handa <handa@m17n.org>
2247 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2249 2012-02-07 Chong Yidong <cyd@gnu.org>
2251 * buffer.c (Fbuffer_local_variables)
2252 (buffer_lisp_local_variables): Handle unbound vars correctly;
2253 don't let Qunbound leak into Lisp.
2255 2012-02-07 Glenn Morris <rgm@gnu.org>
2257 * image.c (Fimagemagick_types): Doc fix.
2259 * image.c (imagemagick-render-type): Change it from a lisp object
2260 to an integer. Move the doc here from the lisp manual.
2261 Treat all values not equal to 0 the same.
2263 2012-02-06 Chong Yidong <cyd@gnu.org>
2265 * doc.c (store_function_docstring): Avoid applying docstring of
2266 alias to base function (Bug#2603).
2268 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2270 * .gdbinit (pp1, pv1): Remove redundant defines.
2273 2012-02-04 Chong Yidong <cyd@gnu.org>
2275 * nsterm.m: Declare a global (Bug#10694).
2277 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2279 * w32.c (get_emacs_configuration_options):
2280 Include --enable-checking, if specified, in the return value.
2282 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2284 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2285 after rounding frame sizes. (Bug#9723)
2287 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2289 * keyboard.c (adjust_point_for_property): Don't position point
2290 before BEGV. (Bug#10696)
2292 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2294 Handle overflow when computing char display width (Bug#9496).
2295 * character.c (char_width): Return EMACS_INT, not int.
2296 (char_width, c_string_width): Check for overflow when
2297 computing the width; this is possible now that individual
2298 characters can have unbounded width. Problem introduced
2299 by merge from Emacs 23 on 2012-01-19.
2301 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2303 * dbusbind.c (Fdbus_register_method): Mention the return value
2304 :ignore in the docstring.
2306 2012-02-02 Glenn Morris <rgm@gnu.org>
2308 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2310 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2311 Unconditionally set to t. (Bug#10673)
2312 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2313 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2314 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2316 2012-02-02 Kenichi Handa <handa@m17n.org>
2318 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2319 0, do not call append_composite_glyph.
2321 2012-02-02 Kenichi Handa <handa@m17n.org>
2323 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2325 (x_produce_glyphs): If the component of a composition is a null
2326 string, set it->pixel_width to 1 to avoid zero-width glyph.
2328 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2330 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2331 first 2 arguments are identical. This makes inserting large
2332 output from a subprocess an order of magnitude faster on
2333 MS-Windows, where all sbrk'ed memory is always contiguous.
2335 2012-01-31 Glenn Morris <rgm@gnu.org>
2337 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2338 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2339 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2341 2012-01-29 Glenn Morris <rgm@gnu.org>
2343 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2345 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2347 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2349 2012-01-28 Chong Yidong <cyd@gnu.org>
2351 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2353 2012-01-26 Chong Yidong <cyd@gnu.org>
2355 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2357 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2358 repeat counts (Bug#10507).
2360 2012-01-26 Glenn Morris <rgm@gnu.org>
2362 * lread.c (syms_of_lread): Doc fix.
2364 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2366 * coding.c (encode_designation_at_bol): Change return value to
2369 2012-01-25 Chong Yidong <cyd@gnu.org>
2371 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2373 2012-01-21 Chong Yidong <cyd@gnu.org>
2375 * floatfns.c (Fcopysign): Make the second argument non-optional,
2376 since nil is not allowed anyway.
2378 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2380 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2381 (send_process): Likewise.
2383 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2385 * window.c (save_window_save, Fcurrent_window_configuration)
2386 (Vwindow_persistent_parameters): Do not use Qstate.
2387 Rewrite doc-strings.
2389 2012-01-19 Kenichi Handa <handa@m17n.org>
2391 * character.c (char_width): New function.
2392 (Fchar_width, c_string_width, lisp_string_width):
2393 Use char_width (Bug#9496).
2395 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2397 * window.c (Vwindow_persistent_parameters): New variable.
2398 (Fset_window_configuration, save_window_save): Handle persistent
2401 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2403 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2404 thrashing the stack of the thread. (Bug#9087)
2406 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2408 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2410 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2412 * xdisp.c (rows_from_pos_range): Handle the case where the
2413 highlight ends on a newline. (Bug#10464)
2414 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2415 he end column for display of highlight that ends on a newline
2418 2012-01-11 Glenn Morris <rgm@gnu.org>
2420 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2421 from load-path also when installation-directory is nil. (Bug#10208)
2423 2012-01-10 Glenn Morris <rgm@gnu.org>
2425 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2427 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2428 Update template values to be closer to their typical values these days.
2430 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2432 * xdisp.c (rows_from_pos_range): Accept additional argument
2433 DISP_STRING, and accept any glyph in a row whose object is that
2434 string as eligible for mouse highlight. Fixes mouse highlight of
2435 display strings from overlays. (Bug#10464)
2437 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2439 emacs: fix an auto-save permissions race condition (Bug#10400)
2440 * fileio.c (auto_saving_dir_umask): New static var.
2441 (Fmake_directory_internal): Use it.
2442 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2443 creating the directory. The old code temporarily assigns
2444 too-generous permissions to the directory.
2445 (do_auto_save_eh): Clear it.
2446 (Fdo_auto_save): Catch all errors, not just file errors, so
2447 that the var is always cleared.
2449 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2451 * search.c (scan_buffer): Pass character positions to
2452 know_region_cache, not byte positions. (Bug#6540)
2454 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2456 * w32.c (sys_rename): Report EXDEV when rename of a directory
2457 fails because the target is on another logical disk. (Bug#10284)
2459 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2461 * xterm.c (x_embed_request_focus): New function.
2463 * xterm.h: Add prototype.
2465 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2467 2012-01-05 Glenn Morris <rgm@gnu.org>
2469 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2471 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2473 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2474 Load gnutls_transport_set_lowat only if GnuTLS version is below
2476 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2477 GnuTLS versions below 2.11.1.
2479 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2481 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2482 to the doc string advising against its use for altering the way
2483 windows are scrolled.
2485 2011-12-28 Kenichi Handa <handa@m17n.org>
2487 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2488 coding-system ASCII compatible only when it does not produce BOM
2489 on encoding (Bug#10383).
2491 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2493 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2495 (create_and_show_popup_menu): Always use menu_position_func for
2498 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2500 * callint.c (Fcall_interactively): Don't truncate prompt string.
2502 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2504 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2505 property that ends at ZV, so that the bidi iteration could be
2506 resumed from there (after widening). (Bug#10360)
2508 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2510 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2512 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2514 * nsterm.m (x_free_frame_resources):
2515 Release f->output_data.ns->miniimage.
2516 (ns_index_color): Fix indentation. Do not retain
2517 color_table->colors[i].
2519 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2522 * nsfns.m (x_set_background_color): Assign return value from
2523 ns_index_color to face-background instead of NSColor*.
2524 (ns_implicitly_set_icon_type): Fix indentation.
2525 Change assignment in for loop to comparison.
2527 * emacs.c (ns_pool): New variable.
2528 (main): Assign ns_pool.
2529 (Fkill_emacs): Call ns_release_autorelease_pool.
2531 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2532 autorelease fdesc, release fdAttrs and tdict.
2533 (ns_get_covering_families): Release charset.
2534 (ns_findfonts): Release NSFontDescriptor created with new.
2535 (ns_uni_to_glyphs): Fix indentation.
2536 (setString): Release attrStr before assigning new value.
2538 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2540 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2542 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2543 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2545 2011-12-18 David Reitter <reitter@cmu.edu>
2547 * nsterm.m (ns_term_init): Subscribe for notifications
2548 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2549 to method trackingNotification in EmacsMenu.
2551 * nsmenu.m (trackingMenu): New variable.
2552 (trackingNotification): New method (from Aquamacs).
2553 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2554 from Aquamacs (Bug#7030).
2556 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2558 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2559 (symbol_to_nsstring): Fix indentation.
2560 (ns_symbol_to_pb): New function.
2561 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2562 (Fns_rotate_cut_buffers_internal): Remove.
2563 (Fns_store_selection_internal): Rename from
2564 Fns_store_cut_buffer_internal.
2565 (ns_get_foreign_selection, Fx_own_selection_internal)
2566 (Fx_disown_selection_internal, Fx_selection_exists_p)
2567 (Fns_get_selection_internal, Fns_store_selection_internal):
2568 Use ns_symbol_to_pb and check if return value is nil.
2569 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2570 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2571 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2572 renamed to Sns_store_selection_internal.
2573 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2574 and remove this function.
2575 (ns_handle_selection_clear): Remove, never used.
2576 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2579 2011-12-17 Ken Brown <kbrown@cornell.edu>
2581 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2582 GID is unknown (Bug#10257).
2584 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2586 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2587 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2588 which caused a build failure on GNU/Linux IA-64. This problem was
2589 introduced by my 2011-10-07 patch.
2591 2011-12-15 Juri Linkov <juri@jurta.org>
2593 * image.c (imagemagick_error): New function. (Bug#10112)
2594 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2595 Use `imagemagick_error' where ImageMagick functions return
2597 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2600 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2602 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2603 fill background (Bug#8992).
2605 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2607 * window.c (Vwindow_combination_resize)
2608 (Vwindow_combination_limit): Use t instead of non-nil in
2610 (Vrecenter_redisplay): Add first sentence of doc-string on
2612 (Frecenter): Fix doc-string typo.
2614 2011-12-11 Kenichi Handa <handa@m17n.org>
2616 * coding.c (Funencodable_char_position): Pay attention to the
2617 buffer text relocation (Bug#9389).
2619 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2621 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2622 gtk_init (Bug#10100).
2624 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2626 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2627 IT->string is nil. (Bug#10263)
2629 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2631 * nsterm.h (x_free_frame_resources): Declare.
2633 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2634 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2636 * nsterm.h (ns_get_defaults_value): Declare.
2638 * nsterm.m (ns_default): Call ns_get_defaults_value.
2640 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2642 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2645 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2647 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2648 that where the value of an _OBJC_* symbol points to is in the .bss
2649 section (Bug#10240).
2651 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2653 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2654 after the loop to call ccl_driver at least once (Bug#8619).
2656 2011-12-08 Kenichi Handa <handa@m17n.org>
2658 * ftfont.c (get_adstyle_property): Fix previous change
2661 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2663 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2664 dirs from the default value of EMACSLOADPATH (bug#10208).
2666 2011-12-07 Glenn Morris <rgm@gnu.org>
2668 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2669 installation and source directories as well. (Bug#10208)
2671 2011-12-06 Chong Yidong <cyd@gnu.org>
2673 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2675 2011-12-06 Glenn Morris <rgm@gnu.org>
2677 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2678 as an error, not just -1. (Bug#10217)
2680 2011-12-05 Chong Yidong <cyd@gnu.org>
2682 * keyboard.c (process_special_events): New function.
2683 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2685 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2687 * coding.c (encode_designation_at_bol): Don't use uninitialized
2688 local variable (Bug#9318).
2690 2011-12-05 Kenichi Handa <handa@m17n.org>
2692 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2693 return Qnil (Bug#8046, Bug#10193).
2695 2011-12-05 Kenichi Handa <handa@m17n.org>
2697 * coding.c (encode_designation_at_bol): New args charbuf_end and
2698 dst. Return the number of produced bytes. Callers changed.
2699 (coding_set_source): Return how many bytes coding->source was
2701 (coding_set_destination): Return how many bytes
2702 coding->destination was relocated.
2703 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2704 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2706 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2708 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2709 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2712 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2714 The following changes are to fix Bug#9318.
2716 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2717 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2718 (encode_coding_iso_2022, encode_coding_sjis)
2719 (encode_coding_big5, encode_coding_charset): Use the above macros.
2721 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2723 * lisp.h (process_quit_flag): Fix external declaration.
2725 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2727 Don't macro-inline non-performance-critical code.
2728 * eval.c (process_quit_flag): New function.
2729 * lisp.h (QUIT): Use it.
2731 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2733 * nsfns.m (get_geometry_from_preferences): New function.
2734 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2736 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2738 * emacs.c (Qkill_emacs): Define.
2739 (syms_of_emacs): Initialize it.
2740 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2741 Qquit_flag to `kill-emacs' instead.
2742 (quit_throw_to_read_char): Add parameter `from_signal'.
2743 All callers changed. Call Fkill_emacs if requested and safe.
2744 * lisp.h (QUIT): Call Fkill_emacs if requested.
2746 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2748 * widget.c (update_wm_hints): Return if wmshell is null.
2749 (widget_update_wm_size_hints): New function.
2751 * widget.h (widget_update_wm_size_hints): Declare.
2753 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2754 widget_update_wm_size_hints (Bug#10104).
2756 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2758 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2759 before a newline, prepare the bidi iterator for consuming the
2760 newline, and keep the current paragraph direction. (Bug#10183)
2761 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2763 2011-12-02 Juri Linkov <juri@jurta.org>
2765 * search.c (Fword_search_regexp): New Lisp function created from
2766 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2767 (Fword_search_backward, Fword_search_forward)
2768 (Fword_search_backward_lax, Fword_search_forward_lax):
2769 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2770 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2772 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2774 * fileio.c (Finsert_file_contents): Move after-change-function call
2775 to before the "handled:" label, since all "goto handled" appear in
2776 cases where the *-change-functions have already been properly called
2779 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2781 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2782 waiting for input. (Bug#10169)
2784 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2786 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2787 verifies glyph row's hash code--we have just reallocated the
2788 glyphs, so their contents can be complete garbage. (Bug#10164)
2790 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2792 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2794 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2796 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2797 attributes are tested _before_ calling verify_row_hash, to protect
2798 against GCC re-ordering of the tests. (Bug#10164)
2800 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2802 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2804 * xterm.c (handle_one_xevent): Only set async_visible and friends
2805 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2806 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2807 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2809 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2811 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2812 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2813 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2814 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2815 All uses changed to use GCPRO1 etc.
2816 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2817 Revert to old implementation (i.e., before 2011-03-11).
2819 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2821 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2822 of scroll runs so as to avoid assigning disabled bogus rows and
2823 unnecessary graphics copy operations.
2825 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2827 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2828 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2829 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2830 (malloc, free, realloc, calloc): Redirect to e_* only when
2833 * lisp.h (GCTYPEBITS): Move before first use.
2834 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2835 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2836 this macro definition.
2838 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2841 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2843 * gtkutil.c (xg_create_frame_widgets):
2844 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2845 present with Gtk+ 2.0.
2847 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2849 * fileio.c (Finsert_file_contents): Undo previous change; see
2850 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2852 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2854 Rename locals to avoid shadowing.
2855 * fileio.c (Finsert_file_contents):
2856 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2857 * process.c (wait_reading_process_output):
2858 Rename inner 'proc' to 'p' to avoid shadowing.
2859 Indent for consistency with usual Emacs style.
2861 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2863 * xdisp.c (redisplay_window): If cursor row is not fully visible
2864 after recentering, and scroll-conservatively is set to a large
2865 number, scroll window by a few more lines to make the cursor fully
2866 visible and out of scroll-margin. (Bug#10105)
2867 (start_display): Don't move to the next line if the display should
2868 start at a newline that is part of a display vector or an overlay
2871 2011-11-24 Juri Linkov <juri@jurta.org>
2873 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2874 after the `MagickPingImage' call. (Bug#10112)
2876 2011-11-23 Chong Yidong <cyd@gnu.org>
2878 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2880 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2882 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2883 making another buffer current. (Bug#10114)
2885 2011-11-23 Glenn Morris <rgm@gnu.org>
2887 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2889 2011-11-23 Chong Yidong <cyd@gnu.org>
2891 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2892 using it (Bug#5984).
2894 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2896 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2897 and header-lines, as they don't have one computed for them.
2900 * .gdbinit (prow): Make displayed values more self-explaining.
2901 Add row's hash code.
2903 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2905 * process.c (wait_reading_process_output): Fix asynchrounous
2906 GnuTLS socket handling on some versions of the GnuTLS library.
2907 (wait_reading_process_output): Add comment and URL.
2909 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2911 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2913 2011-11-21 Chong Yidong <cyd@gnu.org>
2915 * window.c (Fnext_window, Fprevious_window): Doc fix.
2917 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2919 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2921 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2923 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2925 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2927 * window.c (Fset_window_combination_limit): Rename argument
2929 (Vwindow_combination_limit): Remove "status" from doc-string.
2931 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2933 * m/ibms390.h: Remove.
2934 * m/ibms390x.h: Don't include "ibms390.h".
2936 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2938 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2939 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2941 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2943 * casetab.c (Fset_case_table):
2944 * charset.c (Fcharset_after): Fix typos.
2946 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2948 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2949 Otherwise, valgrind does not work on some platforms.
2950 Problem reported by Andreas Schwab in
2951 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2952 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2953 is set, removing the need for VIRT_ADDRESS_VARIES.
2954 (PURE_P): Use a more-efficient implementation that needs just one
2955 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2956 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2957 to 4 (xorl, subq, cmpq, setbe).
2958 * alloc.c (pure): Always extern now, since that's the
2959 VIRT_ADDR_VARIES behavior.
2960 (PURE_POINTER_P): Use a single comparison, not two, for
2961 consistency with the new puresize.h.
2962 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2963 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2964 Remove VIRT_ADDR_VARIES no longer needed.
2966 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2968 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2969 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2970 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2971 behave as if the cursor position were at the window margin.
2973 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2974 and the cursor position is out of bounds, behave as if the cursor
2975 position were at the window margin. (Bug#10075)
2977 2011-11-18 Chong Yidong <cyd@gnu.org>
2979 * window.c (Fwindow_combination_limit): Make first argument
2980 non-optional, since it is meaningless for live windows like the
2983 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2985 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2987 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2989 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2990 (graft_intervals_into_buffer): Simplify.
2992 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2994 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2995 hash values of the two rows.
2996 (copy_row_except_pointers): Preserve the used[] arrays and the
2997 hash values of the two rows. (Bug#10035)
2998 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3000 * xdisp.c (row_hash): New function, body extracted from
3001 compute_line_metrics.
3002 (compute_line_metrics): Call row_hash, instead of computing the
3005 * dispnew.c (verify_row_hash): Call row_hash for computing the
3006 hash code of a row, instead of duplicating code from xdisp.c.
3008 * dispextern.h (row_hash): Add prototype.
3010 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3012 * frame.c (delete_frame): Don't delete the terminal when the last
3013 X frame is closed if emacs is built with GTK toolkit.
3015 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3017 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3019 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3021 * window.c (Vwindow_splits): Rename to
3022 Vwindow_combination_resize. Suggested by Juri Linkov.
3023 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3026 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3028 * nsfns.m (Fns_font_name):
3029 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3031 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3033 * window.h (window): Rename slot "nest" to "combination_limit".
3034 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3035 (Fset_window_nest): Rename to Fset_window_combination_limit.
3036 (Vwindow_nest): Rename to Vwindow_combination_limit.
3037 (recombine_windows, make_parent_window, make_window)
3038 (Fsplit_window_internal, saved_window)
3039 (Fset_window_configuration, save_window_save): Rename all
3040 occurrences of window_nest to window_combination_limit.
3042 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3044 * image.c (imagemagick_load_image): Fix typo.
3046 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3048 * xdisp.c (display_line): Move the call to
3049 highlight_trailing_whitespace before the call to
3050 compute_line_metrics, since the latter needs to see the final
3051 faces of all the glyphs to compute ROW's hash value.
3052 Fixes assertion violations in row_equal_p. (Bug#10035)
3054 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3056 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3057 just return (bug#10044).
3059 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3061 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3062 with user-defined heap size. Bump the default size of the temacs
3063 heap to 27MB, to avoid memory warning when running temacs.
3064 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3066 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3067 current_matrix and desired_matrix. (Bug#9990)
3068 (verify_row_hash) [XASSERTS]: New function.
3069 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3070 that the hash value of glyph rows is correct.
3072 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3074 * window.h (window): Remove splits slot.
3075 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3076 (Fdelete_other_windows_internal, make_parent_window)
3077 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3078 (Fset_window_configuration, save_window_save): Don't deal with
3079 split status of windows.
3080 (saved_window): Remove splits slot.
3081 (Vwindow_splits): Rewrite doc-string.
3083 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3085 * xfns.c (unwind_create_frame):
3086 * nsfns.m (unwind_create_frame):
3087 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3088 Vframe_list (Bug#9999).
3090 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3092 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3094 2011-11-11 Kenichi Handa <handa@m17n.org>
3096 * callproc.c (Fcall_process): Set the member dst_multibyte of
3099 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3101 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3102 avoid a crash (bug#9496).
3104 2011-11-09 Chong Yidong <cyd@gnu.org>
3106 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3107 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3109 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3111 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3113 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3115 Avoid some portability problems by eschewing 'extern inline' functions.
3116 The trivial performance wins aren't worth the portability hassles; see
3117 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3119 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3120 (window_box_width, window_box_left, window_box_left_offset)
3121 (window_box_right, window_box_right_offset): Undo previous change,
3122 by removing the "extern"s.
3123 * intervals.c (adjust_intervals_for_insertion)
3124 (adjust_intervals_for_deletion): Undo previous change,
3125 making these static again.
3126 (offset_intervals, temp_set_point_both, temp_set_point)
3127 (copy_intervals_to_string): No longer inline.
3128 * xdisp.c (window_text_bottom_y, window_box_width)
3129 (window_box_height, window_box_left_offset)
3130 (window_box_right_offset, window_box_left, window_box_right)
3131 (window_box): No longer inline.
3133 2011-11-08 Chong Yidong <cyd@gnu.org>
3135 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3136 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3137 Signal an error if not a live window.
3138 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3139 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3141 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3143 * lisp.h (syms_of_abbrev): Remove declaration.
3144 Reported by CHENG Gao <chenggao@royau.me>.
3146 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3148 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3149 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3150 of temacs in GUI mode.
3152 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3154 * window.h: Declare delete_all_child_windows instead of
3155 delete_all_subwindows.
3156 * window.c (Fwindow_nest, Fset_window_nest)
3157 (Fset_window_new_total, Fset_window_new_normal)
3158 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3159 (delete_all_subwindows): Rename to delete_all_child_windows.
3160 (Fdelete_other_windows_internal, Fset_window_configuration):
3161 Call delete_all_child_windows instead of delete_all_subwindows.
3162 * frame.c (delete_frame): Call delete_all_child_windows instead
3163 of delete_all_subwindows.
3165 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3167 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3168 This is also needed for porting to any host where GC_MARK_STACK is
3169 not GC_MAKE_GCPROS_NOOPS.
3170 (which_symbols): Use it.
3172 2011-11-07 Kenichi Handa <handa@m17n.org>
3174 * coding.c (coding_set_destination): Check coding->src_pos only
3175 when coding->src_object is a buffer (bug#9910).
3177 * process.c (send_process): Set the member src_multibyte of coding
3178 to 0 (bug#9911) when sending a unibyte text.
3180 * callproc.c (Fcall_process): Set the member src_multibyte of
3181 process_coding to 0 (bug#9912).
3183 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3185 * xmenu.c (cleanup_widget_value_tree): New function.
3186 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3187 calling free_menubar_widget_value_tree directly (Bug#9830).
3189 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3191 Fix some portability problems with 'inline'.
3192 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3193 (window_box_width, window_box_left, window_box_left_offset)
3194 (window_box_right, window_box_right_offset): Declare extern.
3195 Otherwise, these inline functions do not conform to C99 and
3196 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3197 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3198 * intervals.c (adjust_intervals_for_insertion)
3199 (adjust_intervals_for_deletion): Now extern, because otherwise the
3200 extern inline functions 'offset_intervals' couldn't refer to it.
3201 (static_offset_intervals): Remove.
3202 (offset_intervals): Rewrite using the old contents of
3203 static_offset_intervals. The old version didn't conform to C99
3204 because an extern inline function contained a reference to an
3205 identifier with static linkage.
3207 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3209 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3212 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3214 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3215 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3216 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3217 return Qleft_to_right.
3219 2011-11-06 Chong Yidong <cyd@gnu.org>
3221 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3222 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3223 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3224 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3225 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3226 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3227 (Fwindow_vscroll): Doc fix.
3228 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3229 argument, since it makes no sense to pass a live window and for
3230 consistency with window-child.
3232 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3234 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3237 2011-11-05 Jason Rumney <jasonr@gnu.org>
3239 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3240 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3242 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3243 bitwise arithmetic preventing use of unicode-sip and non-truetype
3246 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3248 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3251 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3252 initialization code to keep similarity to xfns.c after changes
3255 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3257 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3258 (unwind_create_frame): New function (Bug#9943).
3259 (Fx_create_frame): Restructure code to be more similar to the one in
3260 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3261 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3262 Move terminal->reference_count++ just before making the frame official
3265 * nsterm.m (x_free_frame_resources): New function.
3266 (x_destroy_window): Move code to x_free_frame_resources.
3268 * xfns.c (unwind_create_frame): Fix comment.
3269 (Fx_create_frame, x_create_tip_frame):
3270 Move terminal->reference_count++ just before making the frame
3271 official. Move initialization of image_cache_refcount and
3272 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3274 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3276 Support MSVC build with newer versions of Visual Studio.
3277 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3278 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3281 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3282 which are not supported by MSVC.
3283 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3284 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3286 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3288 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3290 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3292 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3294 Support MSVC build with newer versions of Visual Studio.
3295 * w32.c: Don't include w32api.h for MSVC.
3296 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3298 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3299 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3300 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3301 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3303 (alloca) [_MSC_VER]: Define to _alloca.
3305 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3307 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3309 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3311 * xdisp.c (note_mouse_highlight): If either of
3312 previous/next-single-property-change returns nil, treat that as
3313 the beginning or the end of the buffer. (Bug#9955)
3315 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3317 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3318 label is not null (Bug#9951).
3319 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3322 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3324 * window.c (Fwindow_body_size): Mention in the doc string that the
3325 return value is in frame's canonical units. (Bug#9949)
3327 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3329 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3331 * w32fns.c (unwind_create_frame): If needed, free the glyph
3332 matrices of the partially constructed frame. (Bug#9943)
3333 * xfns.c (unwind_create_frame): Likewise.
3335 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3337 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3338 Don't stop backward scan on the continuation glyph, even though
3339 its CHARPOS is positive.
3340 (mouse_face_from_buffer_pos, note_mouse_highlight):
3341 Rename cover_string to disp_string.
3343 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3345 * window.c (temp_output_buffer_show): Don't use
3346 Vtemp_buffer_show_specifiers.
3347 (Vtemp_buffer_show_specifiers): Remove unused variable.
3349 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3351 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3352 past the beginning of the current glyph matrix.
3354 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3356 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3357 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3358 HAVE_GTK3 (Bug#9869).
3360 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3361 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3363 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3365 * xterm.c: Declare x_handle_net_wm_state to return int.
3366 (handle_one_xevent): Check if we are iconified but don't have
3367 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3368 (get_current_wm_state): Return non-zero if not hidden,
3369 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3370 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3371 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3372 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3374 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3376 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3377 so that this new function doesn't get optimized away by a
3378 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3380 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3382 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3384 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3386 Fix the `xbytecode' command.
3387 * .gdbinit (xprintbytestr): New command.
3388 (xwhichsymbols): Rename from `which'; all callers changed.
3389 (xbytecode): Print the byte-code string as well.
3391 2011-10-29 Kim Storm <storm@cua.dk>
3393 * alloc.c (which_symbols): New function.
3395 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3397 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3400 2011-10-29 Glenn Morris <rgm@gnu.org>
3402 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3403 Not clear what it was for, and it causes various bugs. (Bug#9839)
3405 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3407 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3408 possible random value that matches one of those tested as
3409 condition to clear the mouse face.
3411 2011-10-28 Chong Yidong <cyd@gnu.org>
3413 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3415 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3417 * window.c (make_window): Initialize phys_cursor_on_p.
3419 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3421 * lisp.h (struct Lisp_Symbol): Update comments.
3423 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3425 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3427 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3429 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3430 <oslsachem@gmail.com> for helping to debug this.
3432 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3433 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3434 (g_b_init_get_glyph_outline_w): New static variables.
3435 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3436 (GetGlyphOutlineW_Proc): New typedefs.
3437 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3438 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3440 (w32font_open_internal, compute_metrics):
3441 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3442 instead of calling the "wide" APIs directly.
3444 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3446 * w32.h (syms_of_w32font): Add prototype.
3448 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3450 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3451 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3452 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3453 (Fmove_to_window_line): Doc fix.
3455 2011-10-27 Chong Yidong <cyd@gnu.org>
3457 * process.c (make_process): Set gnutls_state to NULL.
3459 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3460 non-NULL, regardless of GNUTLS_INITSTAGE.
3461 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3462 an error. Set process slots as soon as we allocate them.
3464 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3466 2011-10-27 Chong Yidong <cyd@gnu.org>
3468 * gnutls.c (emacs_gnutls_deinit): New function.
3469 Deallocate credentials structures as well as calling gnutls_deinit.
3470 (Fgnutls_deinit, Fgnutls_boot): Use it.
3472 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3473 (deactivate_process): Call emacs_gnutls_deinit.
3475 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3477 * image.c (x_create_x_image_and_pixmap):
3478 * w32.c (sys_rename, w32_delayed_load):
3479 * w32font.c (fill_in_logfont):
3480 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3482 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3484 * w32fns.c (w32_default_color_map): New function,
3485 extracted from Fw32_default_color_map.
3486 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3488 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3490 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3492 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3494 * keyboard.c (test_undefined): New function (bug#9751).
3495 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3497 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3499 * sysdep.c (init_sys_modes): Fix the check for the controlling
3500 terminal (Bug#6649).
3502 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3504 * dispextern.h (struct bidi_it): New member next_en_type.
3506 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3507 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3508 current character, check also for next_en_type being WEAK_EN.
3509 (bidi_resolve_weak): Don't enter the expensive loop if the current
3510 position is before next_en_pos. Record the bidi type of the first
3511 non-ET, non-BN character we find, in addition to its position.
3512 (bidi_level_of_next_char): Invalidate next_en_type when
3513 next_en_pos is over-stepped.
3515 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3517 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3518 * editfns.c: Rewrite current-time-zone so that it invokes
3519 the equivalent of (format-time-string "%Z") to get the time zone name.
3520 This fixes a bug when the time zone name contains characters that
3521 need converting from the system time locale to Emacs internal format.
3522 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3523 that patch fixed format-time-string to do the conversion, but
3524 I forgot to fix current-time-zone.
3525 (format_time_string): New function, containing most of
3526 what Fformat_time_string used to contain.
3527 (Fformat_time_string): Rewrite in terms of format_time_string.
3528 This doesn't change this function's behavior.
3529 (current-time-zone): Rewrite to use format_time_string.
3530 This fixes the bug reported by Michael Schierl in
3531 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3532 Jason Rumney's 2007-06-07 change worked around this bug, but
3534 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3536 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3538 * xdisp.c (start_display): If the character at POS is displayed
3539 via a display vector, reset IT->current.dpvec_index to zero.
3540 (try_window_reusing_current_matrix): If a line ends in a display
3541 vector or the next line starts in a display vector, continue
3542 redrawing the window even though the character position of
3543 start_row was reached.
3546 2011-10-18 Chong Yidong <cyd@gnu.org>
3548 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3549 with nobreak-char-display too.
3551 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3553 Fix part 3 of bug#9771.
3554 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3555 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3556 non-neutral characters if the current character is a paragraph
3557 separator (a.k.a. Newline). This avoids running the same
3558 expensive loop twice, once when we consume the preceding newline
3559 and the other time when the line actually needs to be displayed.
3560 Avoid the loop when we see neutrals on the base embedding level
3561 following a character whose directionality is the same as the
3562 paragraph's. This avoids running the expensive loop when a line
3563 ends in a long sequence of neutrals, like control characters.
3564 Add assertion against STRONG_AL type. Slightly rearrange code
3565 that determines the type of a neutral given the first non-neutral
3567 (bidi_level_of_next_char): Set next_en_pos to zero when
3568 invalidating its info.
3570 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3572 * xdisp.c (push_display_prop): Determine whether to record string
3573 or buffer position by IT->string, not by IT->method. Allow
3574 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3575 (move_it_vertically_backward): Don't look for character position
3576 immediately after the newline when in a continuation line.
3579 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3581 * window.c (coordinates_in_window): Rewrite and delabelize
3582 vertical border check. (Bug#5357) (Bug#9618)
3584 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3586 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3587 errors in XSetWindowBorder (bug#9310).
3589 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3591 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3592 avoid crash when xmalloc overrun checking is enabled.
3594 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3596 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3597 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3598 cursor motion with <left> and <right> arrow keys.
3600 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3601 some callers set that themselves.
3603 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3605 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3606 display string and the previous row comes from the same string and
3607 is empty. (Bug#9739) (Bug#9738)
3609 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3611 * doc.c (get_doc_string): Encode file name (bug#9735).
3613 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3615 * bidi.c (bidi_level_of_next_char):
3616 * xdisp.c (get_visually_first_element): Remove old incorrect
3617 comments regarding the Unicode Line Separator character.
3619 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3621 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3623 * alloc.c (Fgc_status): Do not access beyond zombies array
3624 boundary if nzombies > MAX_ZOMBIES.
3625 * alloc.c (dump_zombies): Add missing format specifier.
3627 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3629 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3630 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3632 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3633 Some packages use them to denote characters with modifiers.
3635 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3637 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3638 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3639 matching a pp-number. Rename parameter var to var1.
3641 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3643 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3645 2011-10-08 Glenn Morris <rgm@gnu.org>
3647 * callint.c (Fcall_interactively): Give a more explicit error for the
3648 'c' case with a non-character input. (Bug#8479)
3650 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3652 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3654 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3655 lines that are hscrolled on the left.
3657 * dispnew.c (buffer_posn_from_coords): Account for a possible
3658 presence of header-line. (Bug#4426)
3660 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3662 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3663 Don't advertise functionality which we discourage or doesn't work.
3665 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3667 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3668 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3669 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3670 this makes Emacs dump core during garbage collection on rare
3671 occasions. sizeof is obviously inferior to offsetof here, so
3672 stick with offsetof.
3673 (GC_POINTER_ALIGNMENT): New macro.
3674 (mark_memory): Omit 3rd (offset) arg; caller changed.
3675 Don't assume EMACS_INT alignment is the same as pointer alignment.
3677 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3679 * keyboard.c (read_key_sequence_remapped): New var.
3680 (read_key_sequence): Compute remapping in the right buffer.
3681 (command_loop_1): Use read_key_sequence's remapping directly.
3683 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3685 * dired.c (file_name_completion): Don't expand file name.
3686 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3687 before checking file name handler.
3689 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3690 they've been requested explicitly (bug#9591).
3692 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3694 * keymap.c (Fsingle_key_description): Use make_specified_string
3695 instead of build_string to build string from push_key_description.
3698 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3700 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3701 This fixes a Y2038 bug on 64-bit hosts.
3702 * buffer.c (reset_buffer):
3703 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3704 (Fclear_buffer_auto_save_failure):
3705 Use 0, not -1, to represent an unset failure time, since time_t
3706 might not be signed.
3708 Remove dependency on glibc malloc internals.
3709 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3710 Move back here from lisp.h, but with their new implementations.
3711 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3712 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3713 * charset.c (charset_table_init): New static var.
3714 (syms_of_charset): Use it instead of xmalloc. This removes a
3715 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3716 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3717 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3718 Move back to alloc.c.
3719 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3720 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3722 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3724 * nsterm.m (windowDidResize): Call x_set_window_size only when
3725 ns_in_resize is true. Otherwise set pixelwidth/height and
3726 call change_frame_size (Bug#9628).
3728 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3730 Port --enable-checking=all to Fedora 14 x86-64.
3731 * charset.c (syms_of_charset): Also account for glibc malloc's
3732 internal overhead when calculating the initial malloc maximum.
3734 Port --enable-checking=all to Fedora 14 x86.
3735 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3737 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3738 (overrun_check_realloc, overrun_check_free):
3739 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3740 That way, xmalloc returns a properly-aligned pointer even if
3741 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3742 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3743 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3744 into account when calculating the initial malloc maximum.
3745 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3746 Move here from alloc.c, so that charset.c can use it too.
3747 Properly align; the old code wasn't right for common 32-bit hosts
3748 when configured with --enable-checking=all.
3749 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3750 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3752 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3754 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3757 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3759 * xdisp.c (compute_display_string_end): If there's no display
3760 string at CHARPOS, return -1.
3762 * bidi.c (bidi_fetch_char): When compute_display_string_end
3763 returns a negative value, treat the character as a normal
3764 character not covered by a display string. (Bug#9624)
3766 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3768 * lread.c (Fread_from_string): Fix typo in docstring.
3770 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3772 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3773 newline, reseat the iterator instead of bidi-iterating there one
3774 character at a time. (Bug#9610)
3775 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3776 TO_CHARPOS if the bidi iterator is at base embedding level.
3778 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3780 * lread.c (readevalloop): Use correct code for NBSP.
3781 (read1): Likewise. (Bug#9608)
3783 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3785 * dbusbind.c (Fdbus_register_signal): When service is not
3786 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3788 2011-09-25 Glenn Morris <rgm@gnu.org>
3790 * buffer.c (truncate-lines): Doc fix.
3792 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3794 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3795 (Fset_window_next_buffers): Doc fix.
3797 2011-09-24 Glenn Morris <rgm@gnu.org>
3799 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3801 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3803 Fix minor problems found by static checking.
3804 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3805 * indent.c (Fvertical_motion): Fix == vs = typo.
3807 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3809 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3810 Default value is now t. Doc fix.
3812 * indent.c (Fvertical_motion): Compute and apply the overshoot
3813 logic when moving up, not only when moving down. Fix the
3814 confusing name and values of the it_overshoot_expected variable;
3815 logic changes accordingly. (Bug#9254) (Bug#9549)
3817 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3818 CHARPOS is covered by a display string which includes newlines.
3819 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3820 is covered by a display string with embedded newlines.
3822 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3824 * dbusbind.c (Fdbus_register_signal): Add match rule to
3825 Vdbus_registered_objects_table. (Bug#9581)
3826 (Fdbus_register_method, Vdbus_registered_objects_table):
3829 2011-09-24 Jim Meyering <meyering@redhat.com>
3831 do not ignore write error for any output size
3832 The previous change was incomplete.
3833 While it makes emacs --batch detect the vast majority of stdout
3834 write failures, errors were still ignored whenever the output size is
3835 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3836 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3837 && echo FAIL: ignored write error
3838 FAIL: ignored write error
3839 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3840 && echo FAIL: ignored write error
3841 FAIL: ignored write error
3842 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3844 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3846 * emacs.c (Fkill_emacs): In noninteractive mode exit
3847 non-successfully if a write error occurred on stdout. (Bug#9574)
3849 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3851 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3854 * dispextern.h (struct it): Update the comment documenting what
3857 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3859 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3860 a display string, extend search for cursor position to end of row.
3861 (find_row_edges): If the row ends in a newline from a display
3862 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3863 Handle the case of a display string with multiple newlines.
3864 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3865 non-empty line. Fixes confusing cursor motion with arrow keys at
3866 the beginning of a line that starts with whitespace.
3868 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3870 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3873 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3875 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3878 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3880 * xdisp.c (display_line): Record maximum and minimum buffer
3881 positions even if no glyphs were produced (e.g., by a zero-width
3882 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3883 buffer positions that will be removed from the glyph row because
3885 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3886 column is beyond frame width: don't subtract 1 "pixel" when
3887 computing width of the stretch.
3888 (reseat_at_next_visible_line_start): Undo the change made on
3889 2011-09-17 that saved paragraph information and restored it after
3890 the call to `reseat'. (Bug#9545)
3892 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3894 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3895 and turn window cursor on if cleared (Bug#9415).
3897 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3899 * search.c (boyer_moore): Take unibyte characters from pattern
3900 literally. (Bug#9458)
3902 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3904 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3906 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3908 Fix minor problem found by static checking.
3909 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3910 initialized, to pacify gcc -Wuninitialized.
3912 * fileio.c: Report proper errno when syscall falls.
3913 (Finsert_file_contents): Save and restore errno,
3914 so that report_file_error outputs the correct diagnostic.
3915 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3917 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3919 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3921 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3923 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3924 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3926 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3928 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3929 about the current paragraph and restore it after the call to reseat.
3931 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3932 (bidi_find_paragraph_start): Search back for paragraph beginning
3933 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3934 (bidi_move_to_visually_next): Only trigger paragraph-related
3935 computations when the last character is a newline or at EOB, not
3936 just any NEUTRAL_B. (Bug#9470)
3938 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3939 truncated lines if point is covered by a display string. (Bug#9524)
3941 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3943 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3944 (cons_to_x_long): New function.
3945 (lisp_data_to_selection_data): Use it. Correct the test for
3946 short-versus-long data; it was negated. Break out of vector
3947 loop, for efficiency, when a long datum is discovered.
3949 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3951 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3953 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3955 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3956 GCC PR/17406) by declaring this function with external scope.
3958 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3960 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3961 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3963 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3965 * editfns.c (Fformat): Correctly handle text properties on "%%".
3967 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3969 * xterm.c (x_draw_composite_glyph_string_foreground):
3970 * w32term.c (x_draw_composite_glyph_string_foreground):
3971 * term.c (encode_terminal_code):
3972 * composite.c (composition_update_it, get_composition_id):
3973 * xdisp.c (get_next_display_element)
3974 (fill_composite_glyph_string): Add comments about special meaning
3975 of TAB characters in a composition.
3977 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3979 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3980 This occurs when processing a multibyte format.
3981 Problem reported by Wolfgang Jenker.
3983 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3985 * xdisp.c (try_cursor_movement): Only check for exact match if
3986 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3988 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3990 Remove unused external symbols.
3991 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3992 * xdisp.c (calc_pixel_width_or_height): Now static.
3993 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3994 * indent.c (check_display_width):
3995 * w32term.c: Fix comment to match code.
3996 * xterm.c, xterm.h (x_catching_errors): Remove.
3998 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4000 * xselect.c: Use signed conversions more consistently (Bug#9498).
4001 (selection_data_to_lisp_data): Assume incoming selection data are
4002 signed integers, not unsigned. This is to be consistent with
4003 outgoing selection data, which was modified to use signed integers
4004 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4005 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4006 expects long, not unsigned long.
4008 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4010 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4011 computation of loop end. Reported by Johan Bockgård
4014 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4016 * frame.c (Fother_visible_frames_p): Function deleted.
4018 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4020 * indent.c (compute_motion): Process display vector front to back
4021 rather than the other way around. (Bug#2496)
4023 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4025 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4027 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4029 * minibuf.c (Fread_from_minibuffer): Doc fix.
4031 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4033 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4034 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4036 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4038 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4039 value for non-existent files.
4041 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4043 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4044 set its "size" to -1. This will set the modtime_size field of
4045 the corresponding buffer to -1, which is what
4046 verify-visited-file-modtime expects for files that do not exist.
4049 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4051 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4053 * lisp.h: ... from here. push_key_description is no longer
4054 defined in keyboard.c, so its declaration should not be in
4055 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4056 logically belongs with push_key_description.
4058 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4060 * buffer.h: Include <sys/types.h> instead of <time.h>.
4061 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4062 Problem reported by Herbert J. Skuhra.
4064 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4066 * xml.c (parse_region): Make the parsing work for
4067 non-comment-starting XML files again (bug#9144).
4069 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4071 * image.c (gif_load): Fix calculation of bottom and right corner.
4074 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4076 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4077 redisplay in small windows.
4079 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4081 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4083 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4085 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4086 Operate on live windows only.
4088 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4090 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4092 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4094 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4095 only under bidi iteration.
4097 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4099 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4101 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4103 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4104 Without this fix, the command to link temacs failed due to an
4105 undefined symbol __builtin_isnan. This is because
4106 /usr/include/iso/math_c99.h #defines isnan(x) to
4107 __builtin_isnan(x), but the bundled gcc, which identifies itself
4108 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4110 * floatfns.c (isnan): #undef, and then #define to a clone of
4112 (Fisnan): Always define, since it's always available now.
4113 (syms_of_floatfns): Always define isnan at the Lisp level.
4115 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4117 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4119 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4121 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4122 The previous code assumed that file offsets (off_t values) fit in
4123 EMACS_INT variables, which is not true on typical 32-bit hosts.
4124 The code messed up by falsely reporting buffer overflow in cases
4125 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4126 when "big" contains more than 2**29 bytes, even though this
4127 inserts just one byte and does not overflow the buffer.
4128 (Finsert_file_contents): Store file offsets as off_t
4129 values, not as EMACS_INT values. Check for overflow when
4130 converting between EMACS_INT and off_t. When checking for
4131 buffer overflow or for overlap, take the offsets into account.
4132 Don't use EMACS_INT for small values where int suffices.
4133 When checking for overlap, fix a typo: ZV was used where
4134 ZV_BYTE was intended.
4135 (Fwrite_region): Don't assume off_t fits into 'long'.
4136 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4138 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4140 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4142 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4144 sprintf-related integer and memory overflow issues (Bug#9412).
4146 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4147 (esprintf, exprintf, evxprintf): New functions.
4148 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4149 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4150 (modify_event_symbol): Do not assume that the length of
4151 name_alist_or_stem is safe to alloca and fits in int.
4152 (Fexecute_extended_command): Likewise for function name and binding.
4153 (Frecursion_depth): Wrap around reliably on integer overflow.
4154 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4155 since some callers pass EMACS_INT values.
4156 (Fsingle_key_description): Don't crash if symbol name contains more
4157 than MAX_ALLOCA bytes.
4158 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4159 (get_minibuffer): Arg is now EMACS_INT, not int.
4160 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4161 (esprintf, exprintf, evxprintf): New decls.
4162 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4164 * dbusbind.c (signature_cat): New function.
4165 (xd_signature, Fdbus_register_signal):
4166 Do not overrun buffer; instead, report string overflow.
4168 * dispnew.c (add_window_display_history): Don't overrun buffer.
4169 Truncate instead; this is OK since it's just a log.
4171 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4172 even if the time zone offset is outlandishly large.
4173 Don't mishandle offset == INT_MIN.
4175 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4176 when creating daemon; the previous buffer-overflow check was incorrect.
4178 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4179 which has the guts of the old verror function.
4181 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4182 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4184 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4185 (font_unparse_xlfd): Don't blindly alloca long strings.
4186 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4187 fits in int, when using sprintf. Use single snprintf to count
4188 length of string rather than counting it via multiple sprintfs;
4189 that's simpler and more reliable.
4190 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4191 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4192 sprintf, in case result does not fit in int.
4194 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4195 (fontset_from_font): Print it.
4197 * frame.c (tty_frame_count): Now printmax_t, not int.
4198 (make_terminal_frame, set_term_frame_name): Print it.
4199 (x_report_frame_params): In X, window IDs are unsigned long,
4200 not signed long, so print them as unsigned.
4201 (validate_x_resource_name): Check for implausibly long names,
4202 and don't assume name length fits in 'int'.
4203 (x_get_resource_string): Don't blindly alloca invocation name;
4204 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4207 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4208 (xg_check_special_colors, xg_set_geometry):
4209 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4211 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4212 Use esprintf, not sprintf, in case result does not fit in int.
4214 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4215 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4216 it as a large positive number.
4217 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4218 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4220 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4221 in case result does not fit in int.
4223 * print.c (float_to_string): Detect width overflow more reliably.
4224 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4225 buffer overrun. Don't assume list length fits in 'int'. Treat
4226 print length of 0 as 0, not as infinity; to be consistent with other
4227 uses of print length in this function. Don't overflow print length
4228 index. Don't assume hash table size fits in 'long', or that
4229 vectorlike size fits in 'unsigned long'.
4231 * process.c (make_process): Use printmax_t, not int, to format
4232 process-name gensyms.
4234 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4236 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4237 to avoid potential buffer overrun.
4239 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4240 if X resource line is longer than 512 bytes.
4242 * xfns.c (x_window): Make sprintf buffer a bit bigger
4243 to avoid potential buffer overrun.
4245 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4247 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4249 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4251 Integer overflow fixes for scrolling, etc.
4252 Without these, Emacs silently mishandles large integers sometimes.
4253 For example, "C-u 4294967297 M-x recenter" was treated as if
4254 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4256 * xdisp.c (try_window_id): Check Emacs fixnum range before
4257 converting to 'int'.
4259 * window.c (window_scroll_line_based, Frecenter):
4260 Check that an Emacs fixnum is in range before assigning it to 'int'.
4261 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4262 values converted from Emacs fixnums.
4263 (Frecenter): Don't wrap around a line count if it is out of 'int'
4264 range; instead, treat it as an extreme value.
4265 (Fset_window_configuration, compare_window_configurations):
4266 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4268 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4269 that can exceed INT_MAX. Check that EMACS_INT value is in range
4270 before assigning it to the (possibly-narrower) index.
4271 (match_limit): Don't assume that a fixnum can fit in 'int'.
4273 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4276 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4277 (Fvertical_motion): Don't wrap around LINES values that don't fit
4278 in 'int'. Instead, treat them as extreme values. This is good
4279 enough for windows, which can't have more than INT_MAX lines anyway.
4281 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4283 * Require libxml/parser.h to avoid compilation warning.
4285 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4287 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4288 since this reportedly can destroy thread storage.
4290 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4292 * syntax.c (find_defun_start): Update all cache variables if
4293 exiting early (Bug#9401).
4295 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4297 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4299 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4300 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4301 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4303 * term.c (tty_append_glyph): New function.
4304 (produce_stretch_glyph): Static function and its prototype deleted.
4306 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4309 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4311 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4312 when checking :margin (Bug#9390).
4313 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4314 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4315 so that the name doesn't mislead. All uses changed.
4317 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4319 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4322 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4324 * xdisp.c (move_it_to): Don't bail out early when reaching
4325 position beyond to_charpos, if we are scanning backwards.
4326 (move_it_vertically_backward): When DY == 0, make sure we get to
4327 the first character in the line after the newline.
4329 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4331 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4332 (ccl_driver): Do not generate an out-of-range pointer.
4333 (Fccl_execute_on_string): Remove unnecessary check for
4334 integer overflow, noted by Stefan Monnier in
4335 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4336 Remove a FIXME that didn't need fixing.
4337 Simplify the newly-introduced buffer reallocation code.
4339 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4341 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4343 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4345 Integer and memory overflow issues (Bug#9196).
4347 * doc.c (get_doc_string): Rework so that
4348 get_doc_string_buffer_size is the actual buffer size, rather than
4349 being 1 less than the actual buffer size; this makes xpalloc more
4352 * image.c (x_allocate_bitmap_record, cache_image):
4353 * xselect.c (Fx_register_dnd_atom):
4354 Simplify previous changes by using xpalloc.
4356 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4357 since either will do and ptrdiff_t is convenient with xpalloc.
4359 * charset.c (charset_table_size)
4360 (struct charset_sort_data.priority): Now ptrdiff_t.
4361 (charset_compare): Don't overflow if priorities differ greatly.
4362 (Fsort_charsets): Don't assume list length fits in int.
4363 Check for size-calculation overflow when allocating sort data.
4364 (syms_of_charset): Allocate an initial charset table that is
4365 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4367 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4369 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4370 The actual value is always <= INT_MAX, and leaving it unsigned made
4371 overflow checking harder.
4373 * dispextern.h (struct glyph_matrix.rows_allocated)
4374 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4375 with xpalloc. The values are still always <= INT_MAX.
4377 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4379 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4380 (SAFE_NALLOCA): New macro.
4382 * region-cache.c (struct boundary.pos, find_cache_boundary)
4383 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4384 (set_cache_region, invalidate_region_cache)
4385 (revalidate_region_cache, know_region_cache, region_cache_forward)
4386 (region_cache_backward, pp_cache):
4387 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4388 so that ptrdiff_t * can be passed to xpalloc.
4389 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4390 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4391 (pp_cache): Don't assume cache_len fits in int.
4392 * region-cache.h: Adjust extern decls to match.
4394 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4395 EMACS_INT, since either will do, for xpalloc.
4397 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4398 (xnmalloc, xnrealloc, xpalloc): New functions.
4400 * bidi.c (bidi_shelve_header_size): New constant.
4401 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4402 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4404 * bidi.c (bidi_cache_shrink):
4405 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4407 Don't update size of array until after memory allocation succeeds,
4408 because xmalloc/xrealloc may not return.
4409 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4410 now that we have proper integer overflow checking.
4411 (record_overlay_string, overlay_strings): Catch overflows when
4412 calculating size of overlay_str_buf.
4414 * callproc.c (Fcall_process): Check for size overflow when
4415 calculating size of args2.
4416 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4417 Normally we prefer signed values, but sticking with ptrdiff_t would
4418 require adding more-complicated checks.
4420 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4421 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4422 Redo buffer-overflow calculations to avoid integer overflow.
4423 Add a FIXME comment where memory seems to be over-allocated.
4425 * character.c (Fstring): Check for size-calculation overflow.
4427 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4428 unnecessary integer overflow. Check for size overflow.
4429 (encode_coding_object): Don't update size until xmalloc succeeds.
4431 * composite.c (get_composition_id): Check for overflow in glyph
4432 length calculations.
4434 Integer and memory overflow fixes for display code.
4435 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4436 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4437 (scrolling_window): Check for overflow in size calculations.
4438 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4439 Don't assume glyph table len fits in int.
4440 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4441 (row_table_size): Now ptrdiff_t, not int.
4442 (scrolling_window): Avoid overflow in size calculations.
4443 Don't update size until allocation succeeds.
4444 * fns.c (concat): Check for overflow in size calculations.
4445 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4446 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4447 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4449 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4450 (get_doc_string): Check for size calculation overflow.
4451 Don't update size until allocation succeeds.
4452 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4453 EMACS_INT, where ptrdiff_t will do.
4454 (Fsubstitute_command_keys): Check for string overflow.
4456 * editfns.c (set_time_zone_rule): Don't assume environment length
4458 (message_length): Now ptrdiff_t, not int.
4459 (Fmessage_box): Don't update size until allocation succeeds.
4460 Don't assume message length fits in int.
4461 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4463 * emacs.c (main): Do not reallocate argv, since there is a null at
4464 the end that can be overwritten, and this way there's no need to
4465 worry about size-calculation overflow.
4466 (sort_args): Check for size-calculation overflow.
4468 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4470 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4472 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4473 (x_set_scroll_bar_width, x_figure_window_size):
4474 Check for integer overflow.
4475 (x_set_alpha): Do not assume XINT fits in int.
4477 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4478 This is for the members text_lines, text_cols, total_lines, total_cols,
4479 where the system imposes an 'int' limit.
4481 * fringe.c (Fdefine_fringe_bitmap):
4482 Don't update size until alloc works.
4484 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4485 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4487 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4488 Check for size-calculation overflow.
4489 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4490 do, as we prefer signed integers.
4491 (id_to_widget.max_size, id_to_widget.used)
4492 (xg_store_widget_in_map, xg_remove_widget_from_map)
4493 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4494 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4495 Use and return ptrdiff_t, not int.
4496 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4497 * gtkutil.h: Change prototypes to match the above.
4499 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4500 are duplicate now that they've been promoted to lisp.h.
4501 (x_allocate_bitmap_record, x_alloc_image_color)
4502 (make_image_cache, cache_image, xpm_load):
4503 Don't update size until alloc is done.
4504 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4506 Check for size calculation overflow.
4507 (ct_colors_allocated_max): New constant.
4508 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4511 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4512 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4513 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4514 Use ptrdiff_t, not int, to count maps.
4515 (read_char_minibuf_menu_prompt): Check for overflow in size
4516 calculations. Don't update size until allocation succeeds.
4517 Redo calculations to avoid overflow.
4518 * keyboard.h: Change prototypes to match the above.
4520 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4522 (current_minor_maps): Check for size calculation overflow.
4523 * keymap.h: Change prototypes to match the above.
4525 * lread.c (read1, init_obarray): Don't update size until alloc done.
4527 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4528 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4530 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4531 Now ptrdiff_t, not int.
4532 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4533 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4535 * process.c (Fnetwork_interface_list): Check for overflow
4536 in size calculation.
4538 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4540 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4541 overflow. Don't bother calling xmalloc when xrealloc will do.
4543 * search.c (Freplace_match): Check for size calculation overflow.
4544 (Fset_match_data): Don't assume list lengths fit in 'int'.
4546 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4547 for command line length. Do not attempt to address one before the
4548 beginning of an array, as that's not portable.
4550 * term.c (max_frame_lines): Remove; unused.
4551 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4553 (encode_terminal_code, calculate_costs): Check for size
4554 calculation overflow.
4555 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4556 table lengths and related sizes. Don't update size until alloc
4557 done. Redo calculations to avoid overflow.
4558 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4560 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4561 subtracting pointers.
4562 (gobble_line): Check for overflow more carefully. Don't update size
4565 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4566 Don't update size until alloc done.
4567 Redo size calculations to avoid overflow.
4568 Check for size calculation overflow.
4569 (main) [DEBUG]: Fix typo in invoking tparam1.
4571 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4572 Use ptrdiff_t, not int, for sizes.
4573 (store_mode_line_noprop_char): Don't update size until alloc done.
4575 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4576 Use ptrdiff_t, not int, for sizes.
4577 (Finternal_make_lisp_face, cache_face):
4578 Check for size calculation overflow.
4579 (cache_face): Treat size calculation overflows as if they were
4580 memory exhaustion (the usual treatment), rather than aborting.
4582 * xfns.c (x_encode_text, x_set_name_internal)
4583 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4584 sizes, since they can exceed INT_MAX in size. Check for size
4585 calculation overflow.
4587 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4588 (xg_select): Check for size calculation overflow.
4589 Don't update size until alloc done.
4591 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4592 as sprintf is limited to int lengths.
4594 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4595 (X_LONG_MIN): New macros.
4596 Use them to make the following changes clearer.
4597 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4598 This change doesn't affect the value now, but it may help remind
4599 future maintainers not to raise the value too much later.
4600 (SELECTION_QUANTUM): Remove, replacing with ...
4601 (selection_quantum): ... new function, which avoids overflow.
4603 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4604 assumption that selection length fits in 'int'.
4605 (x_reply_selection_request, x_handle_selection_request)
4606 (x_get_window_property, receive_incremental_selection)
4607 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4608 (lisp_data_to_selection_data, clean_local_selection_data):
4609 Use ptrdiff_t, not int, to record length of selection.
4610 (x_reply_selection_request, x_get_window_property)
4611 (receive_incremental_selection, x_property_data_to_lisp):
4612 Redo calculations to avoid overflow.
4613 (x_reply_selection_request): When sending hint, ceiling it at
4614 X_LONG_MAX rather than relying on wraparound overflow to send
4616 (x_get_window_property, receive_incremental_selection)
4617 (lisp_data_to_selection_data, x_property_data_to_lisp):
4618 Check for size-calculation overflow.
4619 (x_get_window_property, receive_incremental_selection)
4620 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4621 Don't store size until memory allocation succeeds.
4622 (x_get_window_property): Plug memory leak on memory exhaustion.
4623 Don't double-block input; malloc is safe here. Don't assume 2**34
4624 - 4 fits in unsigned long. Add an xassert to check
4625 XGetWindowProperty overflow. Be more careful about overflow
4626 calculations, and distinguish size from memory overflow better.
4627 (receive_incremental_selection): When tracing, don't assume
4628 unsigned int is less than INT_MAX.
4629 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4630 harmful) conversions of unsigned short to int.
4631 (lisp_data_to_selection_data): Don't assume that integers
4632 in the range -65535 through -1 fit in an X unsigned short.
4633 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4634 result parameters unless successful. Rely on cons_to_unsigned
4635 to report problems with elements; the old code wasn't right anyway.
4636 (x_check_property_data): Check for int overflow; we cannot use
4637 a wider type due to X limits.
4638 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4640 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4642 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4643 (x_term_init): Check for size calculation overflow.
4644 (x_color_cells): Don't store size until memory allocation succeeds.
4645 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4646 Don't assume alloca size is less than MAX_ALLOCA.
4647 (x_term_init): Don't assume length fits in int (sprintf is limited
4650 Use ptrdiff_t for composition IDs.
4651 * character.c (lisp_string_width):
4652 * composite.c (composition_table_size, n_compositions)
4653 (get_composition_id, composition_gstring_from_id):
4654 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4655 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4656 * window.c (Frecenter):
4657 Use ptrdiff_t, not int, for composition IDs.
4658 * composite.c (get_composition_id): Check for integer overflow.
4659 * composite.h: Adjust prototypes to match the above changes.
4661 Use ptrdiff_t for hash table indexes.
4662 * category.c (hash_get_category_set):
4663 * ccl.c (ccl_driver):
4664 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4665 * coding.c (coding_system_charset_list, detect_coding_system):
4666 * coding.h (struct coding_system.id):
4667 * composite.c (get_composition_id, gstring_lookup_cache):
4668 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4669 * image.c (xpm_get_color_table_h):
4670 * lisp.h (hash_lookup, hash_put):
4671 * minibuf.c (Ftest_completion):
4672 Use ptrdiff_t for hash table indexes, not int (which is too
4673 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4674 32-bit --with-wide-int hosts).
4676 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4677 Add a FIXME comment about memory leaks.
4678 (syms_of_charset): Don't assume xmalloc returns.
4680 Don't assume that stated character widths fit in int.
4681 * character.c (Fchar_width, c_string_width, lisp_string_width):
4682 * character.h (CHAR_WIDTH):
4683 * indent.c (MULTIBYTE_BYTES_WIDTH):
4684 Use sanitize_char_width to avoid undefined and/or bad behavior
4685 with outlandish widths.
4686 * character.h (sanitize_tab_width): Rename from sanitize_width,
4687 now that we have two such functions. All uses changed.
4688 (sanitize_char_width): New inline function.
4690 Don't assume that tab-width fits in int.
4691 * character.h (sanitize_width): New inline function.
4692 (SANE_TAB_WIDTH): New macro.
4693 (ASCII_CHAR_WIDTH): Use it.
4694 * indent.c (sane_tab_width): Remove. All uses replaced by
4695 SANE_TAB_WIDTH (current_buffer).
4696 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4698 * fileio.c: Integer overflow issues with file modes.
4699 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4701 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4702 Remove unreachable code.
4703 (read_hex, load_charset_map_from_file): Check for integer overflow.
4705 * xterm.c: Don't go over XClientMessageEvent limit.
4706 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4707 (x_send_scroll_bar_event): Likewise. Check that the size does not
4708 exceed limits imposed by XClientMessageEvent, as well as the usual
4709 ptrdiff_t and size_t limits.
4711 * keyboard.c: Overflow, signedness and related fixes.
4712 (make_lispy_movement): Use same integer type in forward decl
4713 that is used in the definition.
4714 (read_key_sequence, keyremap_step):
4715 Change bufsize argument back to int, undoing my 2011-03-30 change.
4716 We prefer signed types, and int is wide enough here.
4717 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4718 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4719 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4720 length, not size_t. Use ptrdiff_t for index, not int.
4721 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4722 possibility of integer overflow.
4724 Overflow, signedness and related fixes for images.
4726 * dispextern.h (struct it.stack[0].u.image.image_id)
4727 (struct_it.image_id, struct image.id, struct image_cache.size)
4728 (struct image_cache.used, struct image_cache.ref_count):
4729 * gtkutil.c (update_frame_tool_bar):
4730 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4731 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4732 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4733 * nsmenu.m (update_frame_tool_bar):
4734 * xdisp.c (calc_pixel_width_or_height):
4735 * xfns.c (image_cache_refcount):
4736 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4737 on typical 64-bit hosts.
4739 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4740 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4741 Omit unnecessary casts to int.
4742 (parse_image_spec): Check that integers fall into 'int' range
4743 when the callers expect that.
4744 (image_ascent): Redo ascent calculation to avoid int overflow.
4745 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4746 (lookup_image): Remove unnecessary tests.
4747 (xbm_image_p): Locals are now of int, not EMACS_INT,
4748 since parse_image_check makes sure they fit into int.
4749 (png_load, gif_load, svg_load_image):
4750 Prefer int to unsigned where either will do.
4751 (tiff_handler): New function, combining the cores of the
4752 old tiff_error_handler and tiff_warning_handler.
4753 This function is rewritten to use vsnprintf and thereby avoid
4754 stack buffer overflows. It uses only the features of vsnprintf
4755 that are common to both POSIX and native Microsoft.
4756 (tiff_error_handler, tiff_warning_handler): Use it.
4757 (tiff_load, gif_load, imagemagick_load_image):
4758 Don't assume :index value fits in 'int'.
4759 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4760 (imagemagick_load_image): Check that crop parameters fit into
4761 the integer types that MagickCropImage accepts. Don't assume
4762 Vimagemagick_render_type has a nonnegative value. Don't assume
4763 size_t fits in 'long'.
4764 (gs_load): Use printmax_t to print the widest integers possible.
4765 Check for integer overflow when computing image height and width.
4767 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4769 * xdisp.c (redisplay_window): Don't force window start if point
4770 will be invisible in the resulting window. (Bug#9324)
4772 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4774 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4775 the display spec is of the form `(space ...)'.
4776 (handle_display_spec): Return the value returned by
4777 handle_single_display_spec, not just 1 or zero.
4778 (handle_single_display_spec): If the display spec is of the form
4779 `(space ...)', and specifies display in the text area, return 2
4781 (try_cursor_movement): Check for the need to scroll more
4782 accurately, and prefer exact match for point under bidi.
4783 Don't advance `row' beyond the last row of the window.
4785 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4786 into disp_prop; all users changed.
4788 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4789 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4790 for the text covered by the display property.
4792 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4794 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4795 Change return value to nil.
4796 (Frecord_buffer): Delete unused function.
4798 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4800 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4801 buffers, return left-to-right.
4802 (set_cursor_from_row): Consider candidate row a win if its glyph
4803 represents a newline and point is on that newline. Fixes cursor
4804 positioning on the newline at EOL of R2L text within L2R
4805 paragraph, and vice versa.
4806 (try_cursor_movement): Check continued rows, in addition to
4807 continuation rows. Fixes unwarranted scroll when point enters a
4808 continued line of R2L text within an L2R paragraph, or vice versa.
4809 (cursor_row_p): Consider the case of point being equal to
4810 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4811 from the end of a short line to the beginning of a continued line
4812 of R2L text within L2R paragraph.
4813 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4814 composed characters.
4816 * bidi.c (bidi_check_type): Use xassert.
4817 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4820 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4822 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4825 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4827 * nsfont.m (ns_otf_to_script): Fix typo.
4829 2011-08-22 Kenichi Handa <handa@m17n.org>
4831 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4832 extra slot even if the purpose is char-code-property-table.
4834 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4836 * xdisp.c (redisplay_window): When computing centering_position,
4837 account for the height of the header line. (Bug#8874)
4839 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4840 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4841 candidate is selected by the mouse, and that candidate has a
4842 composed character under the mouse.
4844 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4845 coordinates reported by pos-visible-in-window-p for a composed
4846 character in column zero.
4848 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4850 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4852 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4854 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4855 consider it a hit if to_charpos is anywhere in the range of the
4856 composed buffer positions.
4858 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4860 * image.c (gif_load): Don't assume that each subimage has the same
4861 dimensions as the base image. Handle disposal method that is
4862 "undefined" by the gif spec (Bug#9335).
4864 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4866 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4867 (Fcondition_case): Document `debug' symbol in error handler.
4869 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4871 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4872 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4873 from an Org mode buffer to a Speedbar frame.
4875 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4876 a composition, take its buffer position from IT->cmp_it.charpos.
4877 Fixes cursor positioning at the beginning of a line that begins
4878 with a composed character.
4880 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4882 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4883 character bidirectional type, use STRONG_L instead. Fixes crashes
4884 in a buffer produced by `describe-categories'.
4886 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4887 members before the level stack, so they would be saved and
4888 restored when copying iterator state. Fixes incorrect reordering
4889 around TABs covered by display properties.
4891 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4893 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4895 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4897 * eval.c (internal_condition_case, internal_condition_case_1)
4898 (internal_condition_case_2, internal_condition_case_n):
4899 Remove unnecessary aborts (Bug#9081).
4901 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4903 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4904 has no `load' handler, try opening the file locally. (Bug#9311)
4906 2011-08-16 Ken Brown <kbrown@cornell.edu>
4908 * gmalloc.c: Expand comment.
4910 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4912 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4913 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4915 2011-08-16 Ken Brown <kbrown@cornell.edu>
4917 Fix memory allocation problems in Cygwin build (Bug#9273).
4919 * unexcw.c ( __malloc_initialized): Declare external variable.
4920 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4922 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4924 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4926 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4928 [CYGWIN] (special_realloc): New function.
4929 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4930 requests to realloc storage in the static heap.
4932 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4934 * bidi.c (bidi_initialize): Remove unused local.
4936 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4939 * biditype.h: Remove file.
4940 * makefile.w32-in ($(BLD)/bidi.$(O)):
4941 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4943 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4945 * chartab.c: Improve commentary for the uniprop_table API.
4947 * bidi.c (bidi_paragraph_init): Support zero value of
4948 bidi_ignore_explicit_marks_for_paragraph_level.
4949 (bidi_initialize): Use uniprop_table instead of including
4950 biditype.h and bidimirror.h.
4952 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4953 coordinates of the iterator when restoring from ppos_it.
4956 2011-08-14 Kenichi Handa <handa@m17n.org>
4958 * process.c (create_process): Call setup_process_coding_systems
4959 after the pid of the process is set to -1 (Bug#8162).
4961 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4963 * xdisp.c (move_it_in_display_line_to): Don't invoke
4964 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4965 ppos_it. Fixes vertical cursor motion when line beginning is
4966 covered by an image. (Bug#9296)
4968 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4970 * nsterm.h (ns_run_ascript): Declare.
4971 (NSAPP_DATA2_RUNASSCRIPT): Define.
4973 * nsfns.m (as_script, as_result, as_status): New static variables.
4974 (ns_run_ascript): New function.
4975 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4976 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4977 the event loop. Get status from as_status (Bug#7276).
4979 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4980 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4981 the event loop (Bug#7276).
4983 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4985 * gnutls.c (QCgnutls_bootprop_priority)
4986 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4987 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4988 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4989 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4990 (QCgnutls_bootprop_verify_hostname_error)
4991 (QCgnutls_bootprop_callbacks_verify): Rename from
4992 Qgnutls_bootprop_..., all uses changed.
4994 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4997 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4999 * xfaces.c (Qframe_set_background_mode): Now static.
5000 * dispextern.h (Qframe_set_background_mode): Remove decl.
5002 * process.c (Fnetwork_interface_info): Declare local only if needed.
5004 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5006 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5007 (Fnetwork_interface_list): Allocate in increments of bytes instead
5008 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5009 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5011 (struct ifflag_def): notrailers is smart on OSX.
5012 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5013 Get hardware address with getifaddrs if available.
5015 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5017 * xdisp.c (iterate_out_of_display_property): xassert that
5018 IT->position is set to within IT->object's boundaries. Break from
5019 the loop as soon as EOB is reached; avoids infloops in redisplay
5020 when IT->position is set up wrongly due to some bug.
5021 Set IT->current to match the bidi iterator unconditionally.
5022 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5023 entry. Force push_it to save on the stack the current
5024 buffer/string position, to be restored by pop_it. Fix flags in
5025 the iterator structure wrt the object coming from a display
5026 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5027 properties. (Bug#9284)
5029 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5031 * fontset.c (fontset_get_font_group): Add proper type checks.
5034 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5036 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5037 and LC_VERSION_MIN_MACOSX.
5038 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5039 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5041 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5043 * xdisp.c (forward_to_next_line_start): Allow to use the
5044 no-display-properties-and-no-overlays under bidi display.
5045 Set disp_pos in the bidi iterator to avoid searches for display
5046 properties and overlays.
5048 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5050 * editfns.c (Fset_time_zone_rule): Document relationship with the
5053 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5054 the font entity extracted from the cache (Bug#8109).
5056 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5058 * composite.c (autocmp_chars): Don't reset point. That is done by
5059 restore_point_unwind (Bug#5984).
5061 2011-08-07 Juri Linkov <juri@jurta.org>
5063 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5064 to show the arg `TIME' instead of `TIMEVAL'.
5066 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5068 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5069 display property strides EOL and includes a newline, as in
5070 longlines-mode. (Bug#9254)
5071 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5072 word-wrap under bidirectional display. (Bug#9224)
5074 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5075 is non-zero, even if the data buffer is NULL. Fixes a crash in
5076 vertical-motion with longlines-mode. (Bug#9254)
5078 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5080 * bidi.c <bidi_cache_total_alloc>: Now static.
5081 (bidi_initialize): Initialize bidi_cache_total_alloc.
5083 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5086 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5087 amount allocated this far in `bidi_cache_total_alloc'.
5088 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5089 non-zero, only free the data buffer without restoring the cache
5090 contents. All callers changed.
5092 * dispextern.h (bidi_unshelve_cache): Update prototype.
5094 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5095 (move_it_in_display_line, move_it_to)
5096 (move_it_vertically_backward, move_it_by_lines): Replace the call
5097 to xfree to an equivalent call to bidi_unshelve_cache.
5098 (move_it_in_display_line_to): Fix logic of returning
5099 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5101 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5103 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5104 came from a string character with a `cursor' property. (Bug#9229)
5106 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5108 * Makefile.in (LIB_PTHREAD): New variable.
5109 (LIBES): Add LIB_PTHREAD (Bug#9216).
5111 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5112 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5114 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5116 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5118 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5120 * xterm.c (x_find_topmost_parent): New function.
5121 (x_set_frame_alpha): Find topmost parent window with
5122 x_find_topmost_parent and set the property there also (bug#9181).
5123 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5125 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5127 * callproc.c (Fcall_process): Avoid vfork clobbering
5128 the local vars buffer, coding_systems, current_dir.
5130 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5132 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5134 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5136 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5137 so that it is not optimized away.
5139 * xdisp.c (compute_display_string_pos): Remove unused local.
5141 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5143 Fix slow cursor motion and scrolling in large buffers with
5144 selective display, like Org Mode buffers. (Bug#9218)
5146 * dispextern.h (struct bidi_it): New member disp_prop_p.
5148 * xdisp.c: Remove one-slot cache of display string positions.
5149 (compute_display_string_pos): Accept an additional argument
5150 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5151 for a display string or property. If found, set DISP_PROP_P
5154 * bidi.c (bidi_fetch_char): Accept an additional argument
5155 DISP_PROP_P, and pass it to compute_display_string_pos.
5156 Only handle text covered by a display string if DISP_PROP_P is returned
5157 non-zero. All callers of bidi_fetch_char changed.
5159 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5161 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5163 2010-12-03 Don March <don@ohspite.net>
5165 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5166 last character M-[char] is translated to ESC [char] (bug#7541).
5168 2011-08-02 Kenichi Handa <handa@m17n.org>
5170 * lisp.h (uniprop_table): Extern it.
5172 * chartab.c (uniprop_table): Make it non-static.
5174 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5176 * xdisp.c (forward_to_next_line_start): Accept additional argument
5177 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5179 (reseat_at_next_visible_line_start): Use the bidi iterator state
5180 returned by forward_to_next_line_start to restore the state of
5181 it->bidi_it after backing up to previous newline. (Bug#9212)
5183 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5185 * regex.c (re_comp): Protoize.
5186 (re_exec): Fix return type.
5187 (regexec): Fix type of `ret'. (Bug#9203)
5189 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5191 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5192 This is needed if max-image-size is a floating-point number.
5194 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5196 * print.c (print_object): Print empty symbol as ##.
5198 * lread.c (read1): Read ## as empty symbol.
5200 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5202 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5203 setting frame foreground color (Bug#9175).
5204 (x_set_background_color): Likewise.
5206 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5207 contents (Bug#9176).
5208 (EmacsTooltip -init): Remove bezels and add shadows to
5211 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5212 or scroll bar (Bug#8470).
5214 * nsfont.m (nsfont_open): Remove assignment to voffset and
5215 unnecessary vars hshink, expand, hd, full_height, min_height.
5216 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5218 * nsterm.h (nsfont_info): Remove voffset field.
5220 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5222 Implement strike-through and overline on NextStep (Bug#8863).
5224 * nsfont.m (nsfont_open): Use underline position provided by font,
5225 instead of hard-coded value of 2.
5226 (nsfont_draw): Call ns_draw_text_decoration instead.
5228 * nsterm.h: Add declaration for ns_draw_text_decoration.
5230 * nsterm.m (ns_draw_text_decoration): New function for drawing
5231 underline, overline, and strike-through.
5232 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5233 ns_draw_text_decoration. Change treatment of cursor drawing to
5234 accommodate underlining, etc.
5236 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5238 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5241 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5243 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5244 Without this fix, if a signal arrives just after memory fills up,
5245 'malloc' might be invoked reentrantly.
5247 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5248 In other words, assume that every image size is allowed, on non-X
5249 hosts. This assumption is probably wrong, but it lets Emacs compile.
5251 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5253 * regex.c (re_iswctype): Convert return values to boolean.
5255 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5257 * xdisp.c (compute_display_string_pos): Don't use cached display
5258 string position if the buffer had its restriction changed.
5261 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5263 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5265 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5267 Integer signedness and overflow and related fixes. (Bug#9079)
5269 * bidi.c: Integer size and overflow fixes.
5270 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5271 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5272 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5273 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5274 (bidi_find_other_level_edge):
5275 Use ptrdiff_t instead of EMACS_INT where either will do.
5276 This works better on 32-bit hosts configured --with-wide-int.
5277 (bidi_cache_ensure_space): Check for size-calculation overflow.
5278 Use % rather than repeated addition, for better worst-case speed.
5279 Don't set bidi_cache_size until after xrealloc returns, because it
5281 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5282 (bidi_cache_ensure_space): Also check that the bidi cache size
5283 does not exceed that of the largest Lisp string or buffer. See Eli
5284 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5286 * alloc.c (__malloc_size_t): Remove.
5287 All uses replaced by size_t. See Andreas Schwab's note
5288 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5290 * image.c: Improve checking for integer overflow.
5291 (check_image_size): Assume that f is nonnull, since
5292 it is always nonnull in practice. This is one less thing to
5293 worry about when checking for integer overflow later.
5294 (x_check_image_size): New function, which checks for integer
5295 overflow issues inside X.
5296 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5297 This removes the need for a memory_full check.
5298 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5299 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5300 (xbm_read_bitmap_data): Change locals back to 'int', since
5301 their values must fit in 'int'.
5302 (xpm_load_image, png_load, tiff_load):
5303 Invoke x_create_x_image_and_pixmap earlier,
5304 to avoid much needless work if the image is too large.
5305 (tiff_load): Treat overly large images as if
5306 x_create_x_image_and_pixmap failed, not as malloc failures.
5307 (gs_load): Use x_check_image_size.
5309 * gtkutil.c: Omit integer casts.
5310 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5311 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5313 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5315 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5316 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5317 would wrongly return t on a 64-bit host.
5319 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5320 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5321 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5322 and therefore cause GCC to emit a bogus diagnostic in some cases.
5324 * image.c: Integer signedness and overflow and related fixes.
5325 This is not an exhaustive set of fixes, but it's time to
5326 record what I've got.
5327 (lookup_pixel_color, check_image_size): Remove redundant decls.
5328 (check_image_size): Don't assume that arbitrary EMACS_INT values
5329 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5330 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5331 (tiff_load, imagemagick_load_image):
5332 Check for overflow in size calculations.
5333 (x_create_x_image_and_pixmap): Remove unnecessary test for
5334 xmalloc returning NULL; that can't happen.
5335 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5336 (xpm_color_bucket): Use better integer hashing function.
5337 (xpm_cache_color): Don't possibly over-allocate memory.
5338 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5339 (gif_memory_source):
5340 Use ptrdiff_t, not int or size_t, to record sizes.
5341 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5342 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5343 either works, as we prefer signed integers.
5344 (tiff_read_from_memory, tiff_write_from_memory):
5345 Return tsize_t, not size_t, since that's what the TIFF API wants.
5346 (tiff_read_from_memory): Don't fail simply because the read would
5347 go past EOF; instead, return a short read.
5348 (tiff_load): Omit no-longer-needed casts.
5349 (Fimagemagick_types): Don't assume size fits into 'int'.
5351 Improve hashing quality when configured --with-wide-int.
5352 * fns.c (hash_string): New function, taken from sxhash_string.
5353 Do not discard information about ASCII character case; this
5354 discarding is no longer needed.
5355 (sxhash-string): Use it. Change sig to match it. Caller changed.
5356 * lisp.h: Declare it.
5357 * lread.c (hash_string): Remove, since we now use fns.c's version.
5358 The fns.c version returns a wider integer if --with-wide-int is
5359 specified, so this should help the quality of the hashing a bit.
5361 * emacs.c: Integer overflow minor fix.
5362 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5363 Define only if GNU_LINUX.
5364 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5366 * dispnew.c: Integer signedness and overflow fixes.
5367 Remove unnecessary forward decls, that were a maintenance hassle.
5368 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5370 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5371 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5372 (prepare_desired_row, line_draw_cost):
5373 Use int, not unsigned, where either works.
5374 (save_current_matrix, restore_current_matrix):
5375 Use ptrdiff_t, not size_t, where either works.
5376 (init_display): Check for overflow more accurately, and without
5377 relying on undefined behavior.
5379 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5380 Remove, replacing with the new symbols in lisp.h. All uses changed.
5381 * fileio.c (make_temp_name):
5382 * filelock.c (lock_file_1, lock_file):
5383 * xdisp.c (message_dolog):
5384 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5385 Use pMd etc. instead.
5386 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5387 replacing the pWIDE etc. symbols removed from editfns.c.
5389 * keyboard.h (num_input_events): Now uintmax_t.
5390 This is (very slightly) less likely to mess up due to wraparound.
5393 * buffer.c: Integer signedness fixes.
5394 (alloc_buffer_text, enlarge_buffer_text):
5395 Use ptrdiff_t rather than size_t when either will do, as we prefer
5398 * alloc.c: Integer signedness and overflow fixes.
5399 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5400 (__malloc_size_t): Default to size_t, not to int.
5401 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5402 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5403 Prefer ptrdiff_t to size_t when either would do, as we prefer
5405 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5406 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5407 Now const. Initialize with values that are in range even if char
5409 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5410 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5411 These functions do the right thing with sizes > 2**32.
5412 (check_depth): Now ptrdiff_t, not int.
5413 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5414 Adjust to new way of storing sizes. Check for size overflow bugs
5416 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5417 slightly wrong anyway, as it missed one instance of
5418 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5419 (refill_memory_reserve): Omit needless cast to size_t.
5420 (mark_object_loop_halt): Mark as externally visible.
5422 * xselect.c: Integer signedness and overflow fixes.
5423 (Fx_register_dnd_atom, x_handle_dnd_message):
5424 Use ptrdiff_t, not size_t, since we prefer signed.
5425 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5426 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5427 x_dnd_atoms_size and x_dnd_atoms_length.
5429 * doprnt.c: Prefer signed to unsigned when either works.
5431 * doprnt.c (doprnt):
5433 * xdisp.c (vmessage):
5434 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5435 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5436 prefer signed arithmetic to avoid comparison confusion.
5437 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5438 but is a bit tricky.
5440 Assume freestanding C89 headers, string.h, stdlib.h.
5441 * data.c, doprnt.c, floatfns.c, print.c:
5442 Include float.h unconditionally.
5443 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5444 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5445 * regex.c: Likewise for stddef.h, string.h.
5446 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5447 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5448 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5449 (STDC_HEADERS): Remove obsolete defines.
5450 * sysdep.c: Include limits.h unconditionally.
5452 Assume support for memcmp, memcpy, memmove, memset.
5453 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5454 * regex.c (memcmp, memcpy):
5455 Remove; we assume C89 now.
5457 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5458 (__malloc_safe_bcopy): Remove; no longer needed.
5460 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5461 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5462 well either way, and we prefer signed to unsigned.
5464 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5466 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5467 closes the connection while we're reading (bug#9182).
5469 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5471 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5472 are specified (Bug#9168).
5474 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5476 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5477 Found by GCC static checking and --with-wide-int on a 32-bit host.
5479 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5481 * xdisp.c (compute_display_string_pos): Fix logic of caching
5482 previous display string position. Initialize cached_prev_pos to
5483 -1. Fixes slow-down at the beginning of a buffer.
5485 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5487 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5488 for attrs[LFACE_FONTSET_INDEX].
5490 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5492 * xml.c (parse_region): Remove unused local
5493 that was recently introduced.
5495 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5497 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5498 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5500 * xdisp.c (move_it_in_display_line_to): Record the best matching
5501 position for TO_CHARPOS while scanning the line, and restore it on
5502 exit if none of the characters scanned was an exact match.
5503 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5504 when exact match is impossible due to invisible text, and the
5505 lines are truncated.
5507 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5509 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5512 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5514 Fix a significant slow-down of cursor motion with C-n, C-p,
5515 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5516 auto-repeat under bidi redisplay in fontified buffers.
5517 * xdisp.c (compute_stop_pos_backwards): New function.
5518 (next_element_from_buffer): Call compute_stop_pos_backwards to
5519 find a suitable prev_stop when we find ourselves before
5521 (reseat): Don't look for prev_stop, as that could mean a very long
5523 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5524 <cached_disp_overlay_modiff>: Cache for last found display string
5526 (compute_display_string_pos): Return the cached position if asked
5527 about the same buffer in the same area of character positions, and
5528 the buffer wasn't changed since the time the display string
5529 position was cached.
5531 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5533 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5534 is an integer, which is important for empty lines. (Bug#9149)
5536 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5538 * frame.c (Fmodify_frame_parameters): In tty case, update the
5539 default face if necessary (Bug#4238).
5541 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5543 * editfns.c (Fstring_to_char): No need to explain what a character
5544 is in the docstring (Bug#6576).
5546 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5548 * xml.c (parse_region): Make sure we always return a tree.
5550 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5552 * xml.c (parse_region): If a document contains only comments,
5555 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5557 * xml.c (make_dom): Return comments, too.
5559 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5562 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5563 and the surrounding thread.
5564 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5565 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5566 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5568 * s/openbsd.h (BROKEN_SIGIO): Define.
5569 * unexelf.c (unexec) [__OpenBSD__]:
5570 Don't update the .mdebug section of the Alpha COFF symbol table.
5572 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5574 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5577 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5579 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5580 This fixes some race conditions on the permissions of any newly
5583 * alloc.c (valid_pointer_p): Use pipe, not open.
5584 This fixes some permissions issues when debugging.
5586 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5587 If fchown fails to set both uid and gid, try to set just gid,
5588 as that is sometimes allowed. Adjust the file's mode to eliminate
5589 setuid or setgid bits that are inappropriate if fchown fails.
5591 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5593 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5594 to compare Lisp_Objects.
5595 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5596 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5597 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5599 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5601 * lread.c (read_integer): Unread even EOF character.
5602 (read1): Likewise. Properly record start position of symbol.
5604 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5605 symbol character follows.
5607 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5609 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5610 This works around a problem with the previous change to Fcopy_file.
5611 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5612 and without this change, GCC might complain about discarding
5613 fchown's return value.
5615 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5617 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5619 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5621 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5623 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5625 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5626 it's used from the C level.
5628 * process.c: Use the same condition for POLL_FOR_INPUT in both
5629 keyboard.c and process.c (bug#1858).
5631 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5633 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5634 (Fgnutls_boot): Use it.
5636 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5638 * doc.c (Fsubstitute_command_keys): Revert last change.
5640 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5642 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5643 quotes the next character, and doesn't affect other longer
5644 sequences (bug#8935).
5646 * lread.c (syms_of_lread): Clarify that is isn't only
5647 `eval-buffer' and `eval-defun' that's affected by
5648 `lexical-binding' (bug#8460).
5650 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5652 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5653 bidi redisplay when a line includes both an image and is truncated.
5655 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5657 Fix minor problems found by static checking.
5658 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5659 (elsz): Now a signed constant, not a size_t var. We prefer signed
5660 types to unsigned, to avoid integer comparison confusion. Without
5661 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5662 "cannot optimize loop, the loop counter may overflow", a symptom
5664 * indent.c (Fvertical_motion): Mark locals as initialized.
5665 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5667 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5669 * search.c (Fre_search_backward): Mention `case-fold-search' in
5670 all the re_search_* functions (bug#8138).
5672 * keyboard.c (Fopen_dribble_file): Document when the file is
5675 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5677 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5680 Support bidi reordering of display and overlay strings.
5681 * xdisp.c (compute_display_string_pos)
5682 (compute_display_string_end): Accept additional argument STRING.
5683 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5684 (reseat_to_string): Initialize bidi_it->string.s and
5685 bidi_it->string.schars.
5686 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5687 NULL (avoids a crash in bidi_paragraph_init).
5688 Initialize itb.string.lstring.
5689 (init_iterator): Call bidi_init_it only of a valid
5690 buffer position was specified. Initialize paragraph_embedding to
5692 (reseat_to_string): Initialize the bidi iterator.
5693 (display_string): If we need to ignore text properties of
5694 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5695 original value of -1 will not work with bidi.)
5696 (compute_display_string_pos): First arg is now struct
5697 `text_pos *'; all callers changed. Support display properties on
5699 (compute_display_string_end): Support display properties on Lisp
5701 (init_iterator, reseat_1, reseat_to_string): Initialize the
5702 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5703 when iterating on a string not from display properties).
5704 (compute_display_string_pos, compute_display_string_end):
5705 Fix calculation of the object to scan. Fixes an error when using
5707 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5708 base_level_stop; instead, set base_level_stop to BEGV.
5709 Fixes crashes in vertical-motion.
5710 (next_element_from_buffer): Improve commentary for when
5711 the iterator is before prev_stop.
5712 (init_iterator): Initialize bidi_p from the default value of
5713 bidi-display-reordering, not from buffer-local value. Use the
5714 buffer-local value only if initializing for buffer iteration.
5715 (handle_invisible_prop): Support invisible properties on strings
5716 that are being bidi-reordered.
5717 (set_iterator_to_next): Support bidi reordering of C strings and
5719 (next_element_from_string): Support bidi reordering of Lisp
5721 (handle_stop_backwards): Support Lisp strings as well.
5722 (display_string): Support display of R2L glyph rows.
5723 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5724 (init_iterator): Don't initialize it->bidi_p for strings
5726 (reseat_to_string): Initialize it->bidi_p for strings here.
5727 (next_element_from_string, next_element_from_c_string)
5728 (next_element_from_buffer): Add xassert's for correspondence
5729 between IT's object being iterated and it->bidi_it.string
5731 (face_before_or_after_it_pos): Support bidi iteration.
5732 (next_element_from_c_string): Handle the case of the first string
5733 character that is not the first one in the visual order.
5734 (get_visually_first_element): New function, refactored from common
5735 parts of next_element_from_buffer, next_element_from_string, and
5736 next_element_from_c_string.
5737 (tool_bar_lines_needed, redisplay_tool_bar)
5738 (display_menu_bar): Force left-to-right direction. Add a FIXME
5739 comment for making that be controlled by a user option.
5740 (push_it, pop_it): Save and restore the state of the
5741 bidi iterator. Save and restore the bidi_p flag.
5742 (pop_it): Iterate out of display property for string iteration as
5744 (iterate_out_of_display_property): Support iteration over strings.
5745 (handle_single_display_spec): Set up it->bidi_it for iteration
5746 over a display string, and call bidi_init_it.
5747 (handle_single_display_spec, next_overlay_string)
5748 (get_overlay_strings_1, push_display_prop): Set up the bidi
5749 iterator for displaying display or overlay strings.
5750 (forward_to_next_line_start): Don't use the shortcut if
5752 (back_to_previous_visible_line_start): If handle_display_prop
5753 pushed the iterator stack, restore the internal state of the bidi
5754 iterator by calling bidi_pop_it same number of times.
5755 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5756 and we are bidi-iterating, don't decrement the iterator position;
5757 instead, set the first_elt flag in the bidi iterator, to produce
5759 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5760 (push_display_prop): xassert that we are iterating a buffer.
5761 (push_it, pop_it): Save and restore paragraph_embedding member.
5762 (handle_single_display_spec, next_overlay_string)
5763 (get_overlay_strings_1, reseat_1, reseat_to_string)
5764 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5765 correctly. Don't assume unibyte strings are not bidi-reordered.
5766 (compute_display_string_pos)
5767 (compute_display_string_end): Fix handling the case of C string.
5768 (push_it, pop_it): Save and restore from_disp_prop_p.
5769 (handle_single_display_spec, push_display_prop): Set the
5770 from_disp_prop_p flag.
5771 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5772 (pop_it): Call iterate_out_of_display_property only if we are
5773 popping after iteration over a string that came from a display
5774 property. Fix a typo in popping stretch info. Add an assertion
5775 for verifying that the iterator position is in sync with the bidi
5777 (handle_single_display_spec, get_overlay_strings_1)
5778 (push_display_prop): Fix initialization of paragraph direction for
5779 string when that of the parent object is not yet determined.
5780 (reseat_1): Call bidi_init_it to resync the bidi
5781 iterator with IT's position. (Bug#7616)
5782 (find_row_edges): If ROW->start.pos gives position
5783 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5784 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5785 Reset the from_disp_prop_p flag.
5786 (SAVE_IT, RESTORE_IT): New macros.
5787 (pos_visible_p, face_before_or_after_it_pos)
5788 (back_to_previous_visible_line_start)
5789 (move_it_in_display_line_to, move_it_in_display_line)
5790 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5791 (try_scrolling, redisplay_window, display_line): Use them when
5792 saving a temporary copy of the iterator and restoring it back.
5793 (back_to_previous_visible_line_start, reseat_1)
5794 (init_iterator): Empty the bidi cache "stack".
5795 (move_it_in_display_line_to): If iterator ended up at
5796 EOL, but we never saw any buffer positions smaller than
5797 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5798 motion in bidi-reordered lines.
5799 (move_it_in_display_line_to): Record prev_method and prev_pos
5800 immediately before the call to set_iterator_to_next. Fixes cursor
5801 motion in bidi-reordered lines with stretch glyphs and strings
5802 displayed in margins. (Bug#8133) (Bug#8867)
5803 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5805 (pos_visible_p): Support positions in bidi-reordered lines.
5806 Save and restore bidi cache.
5808 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5809 (bidi_paragraph_info): Delete unused struct.
5810 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5811 (bidi_cache_start): New variable.
5812 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5814 (bidi_cache_fetch_state, bidi_cache_search)
5815 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5816 (bidi_cache_find, bidi_peek_at_next_level)
5817 (bidi_level_of_next_char, bidi_find_other_level_edge)
5818 (bidi_move_to_visually_next): Compare cache index with
5819 bidi_cache_start rather than with zero.
5820 (bidi_fetch_char): Accept new argument STRING; all callers
5821 changed. Support iteration over a string. Support strings with
5822 display properties. Support unibyte strings. Fix the type of
5823 `len' according to what STRING_CHAR_AND_LENGTH expects.
5824 (bidi_paragraph_init, bidi_resolve_explicit_1)
5825 (bidi_resolve_explicit, bidi_resolve_weak)
5826 (bidi_level_of_next_char, bidi_move_to_visually_next):
5827 Support iteration over a string.
5828 (bidi_set_sor_type, bidi_resolve_explicit_1)
5829 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5830 can now be zero (for strings); special values 0 and -1 were
5831 changed to -1 and -2, respectively.
5832 (bidi_char_at_pos): New function.
5833 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5834 Call it instead of FETCH_MULTIBYTE_CHAR.
5835 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5836 initialized to valid values.
5837 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5839 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5840 the test for valid cached positions. Fix the logic for looking up
5841 the sentinel state in the cache. GCPRO the Lisp string we are
5843 (bidi_push_it, bidi_pop_it): New functions.
5844 (bidi_initialize): Initialize the bidi cache start stack pointer.
5845 (bidi_cache_ensure_space): New function, refactored from part of
5846 bidi_cache_iterator_state. Don't assume the required size is just
5847 one BIDI_CACHE_CHUNK away.
5848 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5849 (bidi_count_bytes, bidi_char_at_pos): New functions.
5850 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5851 always valid if bidi_cache_idx is valid.
5852 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5853 is valid if it's going to be used.
5854 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5855 (bidi_cache_fetch_state, bidi_cache_search)
5856 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5857 (bidi_cache_iterator_state, bidi_cache_find)
5858 (bidi_find_other_level_edge, bidi_cache_start_stack):
5859 All variables related to cache indices are now EMACS_INT.
5861 * dispextern.h (struct bidi_string_data): New structure.
5862 (struct bidi_it): New member `string'. Make flag members be 1-bit
5863 fields, and put them last in the struct.
5864 (compute_display_string_pos, compute_display_string_end):
5866 (bidi_push_it, bidi_pop_it): Add prototypes.
5867 (struct iterator_stack_entry): New members bidi_p,
5868 paragraph_embedding, and from_disp_prop_p.
5869 (struct it): Member bidi_p is now a bit field 1 bit wide.
5870 (bidi_shelve_cache, bidi_unshelve_cache):
5873 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5874 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5875 and vector-like objects.
5877 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5878 cache around display iteration.
5880 * window.c (Fwindow_end, window_scroll_pixel_based)
5881 (displayed_window_lines, Frecenter): Save and restore the bidi
5882 cache around display iteration.
5884 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5886 * editfns.c (Fdelete_region): Clarify the use of the named
5887 parameters (bug#6788).
5889 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5891 * indent.c (Fvertical_motion): Set and restore w->pointm when
5892 saving and restoring the window's buffer (Bug#9006).
5894 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5896 * editfns.c (Fstring_to_char): Clarify just what is returned
5897 (bug#6576). Text by Eli Zaretskii.
5899 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5901 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5903 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5905 * buffer.c (mmap_find): Fix a typo.
5907 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5909 Fix execution of x selection hooks.
5910 * xselect.c (Qx_lost_selection_functions)
5911 (Qx_sent_selection_functions): New vars.
5912 (syms_of_xselect): DEFSYM them.
5913 (x_handle_selection_request): Pass Qx_sent_selection_functions
5914 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5915 (x_handle_selection_clear,x_clear_frame_selections):
5916 Pass Qx_lost_selection_functions rather than
5917 Vx_lost_selection_functions to Frun_hook_with_args.
5919 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5921 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5922 The old code sometimes used this field without initializing it.
5924 * alloc.c (gc_sweep): Don't read past end of array.
5925 In theory, the old code could also have corrupted Emacs internals,
5926 though it'd be very unlikely.
5928 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5930 * character.c (Fcharacterp): Don't advertise optional ignored
5931 argument. (Bug#4026)
5933 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5935 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5938 * window.c (Fset_window_start): Doc fix (bug#4199).
5939 (Fset_window_hscroll): Ditto.
5941 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5943 Fix minor new problems caught by GCC 4.6.1.
5944 * term.c (init_tty): Remove unused local.
5945 * xsettings.c (store_monospaced_changed): Define this function only
5946 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5949 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5951 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5953 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5955 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5956 are the mini-buffer and the echo area (bug#3320).
5958 * term.c (init_tty): Remove support for supdup, c10 and perq
5959 terminals, which are no longer supported (bug#1482).
5961 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5963 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5965 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5967 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5968 for non-popups (Bug#3642).
5970 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5972 * alloc.c (reset_malloc_hooks): Protoize.
5973 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5974 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5975 * cm.c (losecursor): Likewise.
5976 * data.c (fmod): Likewise.
5977 * dispnew.c (swap_glyphs_in_rows): Likewise.
5978 * emacs.c (memory_warning_signal): Likewise.
5979 * floatfns.c (float_error): Likewise.
5980 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5981 (otf_open, font_otf_capability, generate_otf_features)
5982 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5984 * image.c (pbm_read_file): Likewise.
5985 * indent.c (string_display_width): Likewise.
5986 * intervals.c (check_for_interval, search_for_interval)
5987 (inc_interval_count, count_intervals, root_interval)
5988 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5989 * lread.c (defalias): Likewise.
5990 * ralloc.c (r_alloc_check): Likewise.
5991 * regex.c (set_image_of_range_1, set_image_of_range)
5992 (regex_grow_registers): Likewise.
5993 * sysdep.c (strerror): Likewise.
5994 * termcap.c (valid_filename_p, tprint, main): Likewise.
5995 * tparam.c (main): Likewise.
5996 * unexhp9k800.c (run_time_remap, save_data_space)
5997 (update_file_ptrs, read_header, write_header, calculate_checksum)
5998 (copy_file, copy_rest, display_header): Likewise.
5999 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6001 * xdisp.c (check_it): Likewise.
6002 * xfaces.c (register_color, unregister_color, unregister_colors):
6004 * xfns.c (print_fontset_result): Likewise.
6005 * xrdb.c (member, fatal, main): Likewise.
6007 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6009 Fix minor problems found by static checking (Bug#9031).
6010 * chartab.c (char_table_set_range, map_sub_char_table):
6011 Remove unused locals.
6012 (uniprop_table): Now static.
6013 * composite.c (_work_char): Remove unused static var.
6015 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6017 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6019 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6021 * gtkutil.c (qttip_cb): Remove code without function.
6023 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6025 * w32.c (pthread_sigmask): New stub.
6027 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6029 Use pthread_sigmask, not sigprocmask (Bug#9010).
6030 sigprocmask is portable only for single-threaded applications, and
6031 Emacs can be multi-threaded when it uses GTK.
6032 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6034 * callproc.c (Fcall_process):
6035 * process.c (create_process):
6036 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6037 Use pthread_sigmask, not sigprocmask.
6039 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6041 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6042 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6045 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6047 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6048 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6049 (xg_hide_tooltip): Fix comment.
6051 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6052 in registerServicesMenuSendTypes.
6053 (validRequestorForSendType): Don't check ns_return_types.
6055 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6058 2011-07-08 Jason Rumney <jasonr@gnu.org>
6060 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6061 SH_SHOW for hidden windows (Bug#5482).
6063 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6064 frame struct members of non-existent frames (Bug#6284).
6066 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6068 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6069 variable firstTime not needed on OSX >= 10.6.
6070 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6071 >= 10.5. Use setKnobProportion, setDoubleValue.
6073 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6074 (MAC_OS_X_VERSION_10_5): Define if not defined.
6075 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6076 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6077 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6079 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6080 cString and lossyCString on OSX >= 10.4
6082 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6083 sizeToFit on OSX >= 10.2.
6085 * nsimage.m (allocInitFromFile): Don't use deprecated method
6086 bestRepresentationForDevice on OSX >= 10.6.
6088 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6091 * emacs.c: Declare unexec_init_emacs_zone.
6093 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6095 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6097 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6098 on svcsMenu (Bug#8842).
6100 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6102 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6104 * nsterm.m (QUTF8_STRING): Declare.
6105 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6106 (validRequestorForSendType): Return type is (id).
6107 Change indexOfObjectIdenticalTo to indexOfObject.
6108 Check if we have local selection before returning self (Bug#8842).
6109 (writeSelectionToPasteboard): Put local selection into paste board
6110 if we have a local selection (Bug#8842).
6111 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6113 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6114 (ns_get_local_selection): Declare.
6116 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6118 * keymap.c (describe_map_tree): Don't insert a double newline at
6119 the end of the buffer (bug#1169) and return whether we inserted
6122 * callint.c (Fcall_interactively): Change "reading args" to
6123 "providing args" to try to clarify what it does (bug#1010).
6125 2011-07-07 Kenichi Handa <handa@m17n.org>
6127 * composite.c (composition_compute_stop_pos): Ignore a static
6128 composition starting before CHARPOS (Bug#8915).
6130 * xdisp.c (handle_composition_prop): Likewise.
6132 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6134 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6137 2011-07-07 Kenichi Handa <handa@m17n.org>
6139 * character.h (unicode_category_t): New enum type.
6141 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6142 (Qchar_code_property_table): New variable.
6143 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6144 (UNIPROP_COMPRESSED_FORM_P): New macros.
6145 (char_table_ascii): Uncompress the compressed values.
6146 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6147 Uncompress the compressed values.
6148 (sub_char_table_ref_and_range): Likewise.
6149 (char_table_ref_and_range): Uncompress the compressed values.
6150 (sub_char_table_set): New arg is_uniprop. Callers changed.
6151 Uncompress the compressed values.
6152 (sub_char_table_set_range): Args changed. Callers changed.
6153 (char_table_set_range): Adjuted for the above change.
6154 (map_sub_char_table): Delete args default_val and parent. Add arg
6155 top. Give decoded values to a Lisp function.
6156 (map_char_table): Adjust for the above change. Give decoded
6157 values to a Lisp function. Gcpro more variables.
6158 (uniprop_table_uncompress)
6159 (uniprop_decode_value_run_length): New functions.
6160 (uniprop_decoder, uniprop_decoder_count): New variables.
6161 (uniprop_get_decoder, uniprop_encode_value_character)
6162 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6164 (uniprop_encoder, uniprop_encoder_count): New variables.
6165 (uniprop_get_encoder, uniprop_table)
6166 (Funicode_property_table_internal, Fget_unicode_property_internal)
6167 (Fput_unicode_property_internal): New functions.
6168 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6169 Sunicode_property_table_internal, Sget_unicode_property_internal,
6170 and Sput_unicode_property_internal. Defvar_lisp
6171 char-code-property-alist.
6173 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6174 Vunicode_category_table.
6176 * font.c (font_range): Adjust for the change of
6177 Vunicode_category_table.
6179 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6181 * m/iris4d.h: Remove file, move contents ...
6182 * s/irix6-5.h: ... here.
6184 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6186 Remove unportable assumption about struct layout (Bug#8884).
6187 * alloc.c (mark_buffer):
6188 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6189 (clone_per_buffer_values): Don't assume that
6190 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6191 This isn't true in general, and it's particularly not true
6192 if Emacs is configured with --with-wide-int.
6193 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6194 New macros, used in the buffer.c change.
6196 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6198 * xsettings.c: Use both GConf and GSettings if both are available.
6199 (store_config_changed_event): Add comment.
6200 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6201 (store_tool_bar_style_changed): New functions.
6202 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6203 (struct xsettings): Move font inside HAVE_XFT.
6204 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6205 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6206 Move inside HAVE_XFT.
6207 (something_changed_gsettingsCB): Rename from something_changedCB.
6208 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6210 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6211 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6212 (something_changed_gconfCB): Rename from something_changedCB.
6213 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6214 (parse_settings): Move check for font inside HAVE_XFT.
6215 (read_settings, apply_xft_settings): Add comment.
6216 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6217 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6218 call store_font_name_changed.
6219 (xft_settings_event): Add comment.
6220 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6221 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6222 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6223 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6224 (xsettings_initialize): Call init_gsettings last.
6225 (xsettings_get_system_font, xsettings_get_system_normal_font):
6228 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6230 Random fixes. E.g., (random) never returned negative values.
6231 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6232 subseconds part to the entropy, as that's a bit more random.
6233 Prefer signed to unsigned, since the signedness doesn't matter and
6234 in general we prefer signed. When given a limit, use a
6235 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6236 latter isn't right if USE_2_TAGS_FOR_INTS.
6237 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6238 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6240 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6242 * textprop.c (text_property_stickiness):
6243 Obey Vtext_property_default_nonsticky.
6244 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6245 * w32fns.c (syms_of_w32fns):
6246 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6248 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6250 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6251 This is more efficient than Ffile_directory_p and avoids a minor race.
6253 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6255 * buffer.c (Foverlay_put): Say what the return value is
6258 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6259 is a directory before asking whether to use the file name
6261 (barf_or_query_if_file_exists): Make the "File is a directory"
6262 error be more correct.
6264 * fns.c (Frequire): Remove the mention of the .gz files, since
6265 that's installation-specific, but keep the mention of
6266 `get-load-suffixes'.
6268 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6270 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6271 Report string overflow if the output is too long.
6273 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6275 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6276 (syms_of_gnutls): Remove duplicate DEFSYM for
6277 Qgnutls_bootprop_verify_hostname_error, an error for
6278 Qgnutls_bootprop_verify_error (which is no longer used).
6280 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6281 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6282 Also (re)move comments that are misplaced or no longer relevant.
6284 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6286 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6288 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6290 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6291 and background color parameters if they have been changed.
6293 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6295 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6297 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6299 * xsettings.c (SYSTEM_FONT): Define only when used.
6300 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6302 * keymap.c (access_keymap_1): Now static.
6304 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6306 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6307 leave any prefix arg for the up event (Bug#1586).
6309 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6311 * lread.c (syms_of_lread): Mention single symbols defined by
6312 `defvar' or `defconst' (bug#7154).
6314 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6315 (Frequire): Mention get-load-suffixes.
6317 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6319 * window.h (window): Remove clone_number slot.
6320 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6322 (make_parent_window, make_window, saved_window)
6323 (Fset_window_configuration, save_window_save): Don't deal with
6325 * buffer.c (Qclone_number): Remove declaration.
6326 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6328 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6330 Add multiple inheritance to keymaps.
6331 * keymap.c (Fmake_composed_keymap): New function.
6332 (Fset_keymap_parent): Simplify.
6333 (fix_submap_inheritance): Remove.
6334 (access_keymap_1): New function extracted from access_keymap to handle
6335 embedded parents and handle lists of maps.
6336 (access_keymap): Use it.
6337 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6338 (Fcopy_keymap): Handle embedded parents.
6339 (Fcommand_remapping, define_as_prefix): Simplify.
6340 (Fkey_binding): Simplify.
6341 (syms_of_keymap): Move minibuffer-local-completion-map,
6342 minibuffer-local-filename-completion-map,
6343 minibuffer-local-must-match-map, and
6344 minibuffer-local-filename-must-match-map to Elisp.
6345 (syms_of_keymap): Defsubr make-composed-keymap.
6346 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6347 (parse_menu_item): Trivial simplification.
6349 2011-07-01 Glenn Morris <rgm@gnu.org>
6351 * Makefile.in (SETTINGS_LIBS): Fix typo.
6353 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6355 * coding.c (Fencode_coding_string): Record the last coding system
6356 used, as the function doc string says (bug#8738).
6358 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6360 * xsettings.c (store_monospaced_changed): Take new font as arg and
6361 check for change against current_mono_font.
6362 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6363 (emacs_settings_constructor, emacs_settings_get_property)
6364 (emacs_settings_set_property, emacs_settings_class_init)
6365 (emacs_settings_init, gsettings_obj): Remove.
6366 (something_changedCB): New function for HAVE_GSETTINGS.
6367 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6368 with value as argument.
6369 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6370 g_settings_new (Bug#8967). Do not create gsettings_obj.
6371 Remove calls to g_settings_bind. Connect something_changedCB to
6374 * xgselect.c: Add defined (HAVE_GSETTINGS).
6375 (xgselect_initialize): Ditto.
6377 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6378 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6381 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6383 * eval.c (struct backtrace): Simplify and port the data structure.
6384 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6385 signed bit field, as this assumption is not portable and it makes
6386 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6387 "char debug_on_exit : 1" as this is not portable either; instead,
6388 use the portable "unsigned int debug_on_exit : 1". Remove unused
6389 member evalargs. Remove obsolete comments about cc bombing out.
6391 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6393 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6394 Let HAVE_GSETTINGS override HAVE_GCONF.
6395 (store_monospaced_changed): New function.
6396 (EMACS_SETTINGS): A new type derived from GObject to handle
6397 GSettings notifications.
6398 (emacs_settings_constructor, emacs_settings_get_property)
6399 (emacs_settings_set_property, emacs_settings_class_init):
6401 (gsettings_client, gsettings_obj): New variables.
6402 (GSETTINGS_SCHEMA): New define.
6403 (something_changedCB): Call store_monospaced_changed.
6404 (init_gsettings): New function.
6405 (xsettings_initialize): Call init_gsettings.
6406 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6409 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6412 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6414 * window.c (resize_root_window, grow_mini_window)
6415 (shrink_mini_window): Rename Qresize_root_window to
6416 Qwindow_resize_root_window and Qresize_root_window_vertically to
6417 Qwindow_resize_root_window_vertically.
6419 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6421 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6423 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6425 * makefile.w32-in: Redesign dependencies so they reflect more
6426 clearly which files are directly included by each source file,
6427 and not through other includes.
6429 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6431 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6432 (sort_overlays, overlay_strings): When an overlay's clone number
6433 matches the window's clone number process the overlay even if
6434 the overlay's window property doesn't match the current window.
6436 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6437 (Fwindow_hchild): Rename to Fwindow_left_child.
6438 (Fwindow_next): Rename to Fwindow_next_sibling.
6439 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6440 (resize_window_check): Rename to window_resize_check.
6441 (resize_window_apply): Rename to window_resize_apply.
6442 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6443 (Fdelete_other_windows_internal, resize_frame_windows)
6444 (Fsplit_window_internal, Fdelete_window_internal)
6445 (grow_mini_window, shrink_mini_window)
6446 (Fresize_mini_window_internal): Fix callers accordingly.
6448 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6450 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6451 (emacs_fixed_set_min_size): Remove.
6452 (emacs_fixed_new): Take frame as argument.
6454 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6455 (_EmacsFixedPrivate): Remove minwidth/height.
6456 Add struct frame *f.
6457 (emacs_fixed_init): Initialize priv->f.
6458 (get_parent_class, emacs_fixed_set_min_size): Remove.
6459 (emacs_fixed_new): Set priv->f to argument.
6460 (emacs_fixed_get_preferred_width)
6461 (emacs_fixed_get_preferred_height): Use min_width/height from
6462 frames size_hint to set minimum and natural (Bug#8919).
6463 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6464 and use min_width/height from frames size_hint to set
6465 min_width/height (Bug#8919).
6467 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6468 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6471 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6473 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6474 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6477 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6479 * process.c (wait_reading_process_output): Bypass select if
6480 waiting for a cell while ignoring keyboard input, and input is
6481 pending. Suggested by Jan Djärv (Bug#8869).
6483 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6485 Use gnulib's dup2 module instead of rolling our own.
6486 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6488 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6490 * dispnew.c (scrolling_window): Before scrolling, turn off a
6491 mouse-highlight in the window being scrolled.
6493 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6495 Move DEFSYM to lisp.h and use everywhere.
6497 * character.h (DEFSYM): Move declaration...
6498 * lisp.h (DEFSYM): ...here.
6504 * w32select.c: Don't include character.h.
6506 * alloc.c (syms_of_alloc):
6507 * buffer.c (syms_of_buffer):
6508 * bytecode.c (syms_of_bytecode):
6509 * callint.c (syms_of_callint):
6510 * casefiddle.c (syms_of_casefiddle):
6511 * casetab.c (init_casetab_once):
6512 * category.c (init_category_once, syms_of_category):
6513 * ccl.c (syms_of_ccl):
6514 * cmds.c (syms_of_cmds):
6515 * composite.c (syms_of_composite):
6516 * dbusbind.c (syms_of_dbusbind):
6517 * dired.c (syms_of_dired):
6518 * dispnew.c (syms_of_display):
6519 * doc.c (syms_of_doc):
6520 * editfns.c (syms_of_editfns):
6521 * emacs.c (syms_of_emacs):
6522 * eval.c (syms_of_eval):
6523 * fileio.c (syms_of_fileio):
6524 * fns.c (syms_of_fns):
6525 * frame.c (syms_of_frame):
6526 * fringe.c (syms_of_fringe):
6527 * insdel.c (syms_of_insdel):
6528 * keymap.c (syms_of_keymap):
6529 * lread.c (init_obarray, syms_of_lread):
6530 * macros.c (syms_of_macros):
6531 * msdos.c (syms_of_msdos):
6532 * print.c (syms_of_print):
6533 * process.c (syms_of_process):
6534 * search.c (syms_of_search):
6535 * sound.c (syms_of_sound):
6536 * syntax.c (init_syntax_once, syms_of_syntax):
6537 * terminal.c (syms_of_terminal):
6538 * textprop.c (syms_of_textprop):
6539 * undo.c (syms_of_undo):
6540 * w32.c (globals_of_w32):
6541 * window.c (syms_of_window):
6542 * xdisp.c (syms_of_xdisp):
6543 * xfaces.c (syms_of_xfaces):
6544 * xfns.c (syms_of_xfns):
6545 * xmenu.c (syms_of_xmenu):
6546 * xsettings.c (syms_of_xsettings):
6547 * xterm.c (syms_of_xterm): Use DEFSYM.
6549 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6551 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6553 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6555 Integer and buffer overflow fixes (Bug#8873).
6557 * print.c (printchar, strout): Check for string overflow.
6558 (PRINTPREPARE, printchar, strout):
6559 Don't set size unless allocation succeeds.
6561 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6562 for sizes. Check for string overflow more accurately.
6563 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6565 * macros.c: Integer and buffer overflow fixes.
6566 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6567 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6568 Use ptrdiff_t, not int, for sizes.
6569 Don't increment bufsize until after realloc succeeds.
6570 Check for size-calculation overflow.
6571 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6573 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6575 * lread.c: Integer overflow fixes.
6576 (read_integer): Radix is now EMACS_INT, not int,
6577 to improve quality of diagnostics for out-of-range radices.
6578 Calculate buffer size correctly for out-of-range radices.
6579 (read1): Check for integer overflow in radices, and in
6580 read-circle numbers.
6581 (read_escape): Avoid int overflow.
6582 (Fload, openp, read_buffer_size, read1)
6583 (substitute_object_recurse, read_vector, read_list, map_obarray):
6584 Use ptrdiff_t, not int, for sizes.
6585 (read1): Use EMACS_INT, not int, for sizes.
6586 Check for size overflow.
6588 * image.c (cache_image): Check for size arithmetic overflow.
6590 * lread.c: Integer overflow issues.
6591 (saved_doc_string_size, saved_doc_string_length)
6592 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6593 Now ptrdiff_t, not int.
6594 (read1): Don't assume doc string length fits in int. Check for
6595 out-of-range doc string lengths.
6596 (read_list): Don't assume file position fits in int.
6597 (read_escape): Check for hex character overflow.
6599 2011-06-22 Leo Liu <sdl.web@gmail.com>
6601 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6602 Move to minibuffer.el.
6604 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6606 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6607 The following patches are for when GLYPH_DEBUG && !XASSERT.
6608 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6609 * dispnew.c (flush_stdout):
6610 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6611 Mark as externally visible.
6612 * dispnew.c (check_window_matrix_pointers): Now static.
6613 * dispnew.c (window_to_frame_vpos):
6614 * xfns.c (unwind_create_frame):
6615 * xterm.c (x_check_font): Remove unused local.
6616 * scroll.c (CHECK_BOUNDS):
6617 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6618 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6619 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6620 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6621 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6623 (debug_method_add): Use va_list and vsprintf rather than relying
6624 on undefined behavior with wrong number of arguments.
6625 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6626 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6627 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6628 since we're not interested in debugging glyphs with old libraries.
6629 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6630 GCC 4.6.0's static checking.
6632 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6634 Integer overflow and signedness fixes (Bug#8873).
6635 A few related buffer overrun fixes, too.
6637 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6639 * dispextern.h (struct face.stipple):
6640 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6641 (x_bitmap_mask, x_allocate_bitmap_record)
6642 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6643 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6644 (x_create_bitmap_from_xpm_data):
6645 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6646 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6648 * xfaces.c (load_pixmap):
6649 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6650 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6651 (.bitmaps_last, struct x_output.icon_bitmap):
6652 Use ptrdiff_t, not int, for bitmap indexes.
6653 (x_allocate_bitmap_record): Check for size overflow.
6654 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6656 Use ptrdiff_t, not int, for overlay counts.
6657 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6658 * editfns.c (overlays_around, get_pos_property):
6659 * textprop.c (get_char_property_and_overlay):
6660 * xdisp.c (next_overlay_change, note_mouse_highlight):
6661 * xfaces.c (face_at_buffer_position):
6662 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6663 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6664 (Fnext_overlay_change, Fprevious_overlay_change)
6665 (mouse_face_overlay_overlaps, Foverlays_in):
6666 Use ptrdiff_t, not int, for sizes.
6667 (overlays_at, overlays_in): Check for size-calculation overflow.
6669 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6671 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6672 (x_session_initialize): Do not assume string length fits in int.
6674 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6675 This is unlikely, but can occur if DPI is outlandish.
6677 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6678 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6680 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6681 * xrdb.c (magic_file_p, search_magic_path):
6682 Omit last arg SUFFIX; it was always 0. All callers changed.
6683 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6685 * xfont.c (xfont_match): Avoid need for strlen.
6687 * xfns.c: Don't assume strlen fits in int.
6688 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6690 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6691 not unsigned long, as we prefer signed integers. All callers changed.
6692 Detect integer overflow in repeat count.
6693 (message_dolog): Don't assume print length fits in 39 bytes.
6694 (display_mode_element): Don't assume strlen fits in int.
6696 * termcap.c: Don't assume sizes fit in int and never overflow.
6697 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6698 (gobble_line): Check for size-calculation overflow.
6700 * minibuf.c (Fread_buffer):
6701 * lread.c (intern, intern_c_string):
6702 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6703 Don't assume string length fits in int.
6705 * keyboard.c (parse_tool_bar_item):
6706 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6708 * font.c: Don't assume string length fits in int.
6709 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6710 Use ptrdiff_t, not int.
6711 (font_intern_prop): Don't assume string length fits in int.
6712 Don't assume integer property fits in fixnum.
6713 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6715 * filelock.c: Fix some buffer overrun and integer overflow issues.
6716 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6717 Reformulate so as not to need the command string.
6718 Invoke gzip -cd rather than gunzip, as it's more portable.
6719 (lock_info_type, lock_file_1, lock_file):
6720 Don't assume pid_t and time_t fit in unsigned long.
6721 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6722 (current_lock_owner): Prefer signed type for sizes.
6723 Use memcpy, not strncpy, where memcpy is what is really wanted.
6724 Don't assume (via atoi) that time_t and pid_t fit in int.
6725 Check for time_t and/or pid_t out of range, e.g., via a network share.
6726 Don't alloca where an auto var works fine.
6728 * fileio.c: Fix some integer overflow issues.
6729 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6730 Don't assume string length fits in int.
6731 (directory_file_name): Don't assume string length fits in long.
6732 (make_temp_name): Don't assume pid fits in int, or that its print
6733 length is less than 20.
6735 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6737 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6739 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6741 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6742 We prefer signed integers, even for size calculations.
6744 * emacs.c: Don't assume string length fits in 'int'.
6745 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6746 (main): Don't invoke strlen when not needed.
6748 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6749 (XD_DEBUG_MESSAGE): Don't waste a byte.
6751 * callproc.c (getenv_internal_1, getenv_internal)
6753 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6755 * lread.c (invalid_syntax): Omit length argument.
6756 All uses changed. This doesn't fix a bug, but it simplifies the
6757 code away from its former Hollerith-constant appearance, and it's
6758 one less 'int' to worry about when looking at integer-overflow issues.
6759 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6761 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6762 This didn't break anything, but it didn't help either.
6763 It's confusing to put a bogus integer in a place where the actual
6764 value does not matter.
6765 (LIST_END_P): Remove unused macro and its bogus comment.
6766 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6768 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6769 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6771 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6772 We prefer signed types, and the value cannot exceed the EMACS_INT
6773 range anyway (because otherwise the length would not be representable).
6774 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6775 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6776 This avoids a GCC warning when WIDE_EMACS_INT.
6778 * indent.c (sane_tab_width): New function.
6779 (current_column, scan_for_column, Findent_to, position_indentation)
6780 (compute_motion): Use it. This is just for clarity.
6781 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6783 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6785 * lisp.h (lint_assume): New macro.
6786 * composite.c (composition_gstring_put_cache):
6787 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6789 * editfns.c, insdel.c:
6790 Omit unnecessary forward decls, to simplify future changes.
6792 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6794 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6796 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6797 Use much-faster test for byte-length change.
6798 Don't assume string byte-length fits in 'int'.
6799 Check that character arg fits in 'int'.
6800 (mapcar1): Declare byte as byte, for clarity.
6802 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6804 * fns.c (concat): Catch string overflow earlier.
6805 Do not rely on integer wraparound.
6807 * dispextern.h (struct it.overlay_strings_charpos)
6808 (struct it.selective): Now EMACS_INT, not int.
6809 * xdisp.c (forward_to_next_line_start)
6810 (back_to_previous_visible_line_start)
6811 (reseat_at_next_visible_line_start, next_element_from_buffer):
6812 Don't arbitrarily truncate the value of 'selective' to int.
6814 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6816 * composite.c: Don't truncate sizes to 'int'.
6817 (composition_gstring_p, composition_reseat_it)
6818 (composition_adjust_point): Use EMACS_INT, not int.
6819 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6820 not EMACS_UINT, for indexes.
6822 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6824 * buffer.c: Include <verify.h>.
6825 (struct sortvec.priority, struct sortstr.priority):
6826 Now EMACS_INT, not int.
6827 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6828 (struct sortstr.size, record_overlay_string)
6829 (struct sortstrlist.size, struct sortlist.used):
6830 Don't truncate size to int.
6831 (record_overlay_string): Check for size-calculation overflow.
6832 (init_buffer_once): Check at compile-time, not run-time.
6834 2011-06-22 Jim Meyering <meyering@redhat.com>
6836 Don't leak an XBM-image-sized buffer
6837 * image.c (xbm_load): Free the image buffer after using it.
6839 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6842 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6843 that Sun C diagnosed.
6844 * fns.c (secure_hash): Fix pointer signedness issue.
6845 * intervals.c (static_offset_intervals): New function.
6846 (offset_intervals): Use it.
6848 2011-06-21 Leo Liu <sdl.web@gmail.com>
6851 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6854 * fns.c (secure_hash): Rename from crypto_hash_function and change
6855 the first arg to accept symbols.
6856 (Fsecure_hash): New primitive.
6857 (syms_of_fns): New symbols.
6859 2011-06-20 Deniz Dogan <deniz@dogan.se>
6861 * process.c (Fset_process_buffer): Clarify return value in
6864 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6866 * dispnew.c (add_window_display_history): Use BVAR.
6868 * xdisp.c (debug_method_add): Use BVAR.
6869 (check_window_end, dump_glyph_matrix, dump_glyph)
6870 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6872 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6875 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6876 check till after the cache is created in init_frame_faces.
6878 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6880 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6882 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6884 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6885 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6886 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6888 Improve buffer-overflow checking (Bug#8873).
6889 * fileio.c (Finsert_file_contents):
6890 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6891 Remove the old (too-loose) buffer overflow checks.
6892 They weren't needed, since make_gap checks for buffer overflow.
6893 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6894 The old code merely checked for Emacs fixnum overflow, and relied
6895 on undefined (wraparound) behavior. The new code avoids undefined
6896 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6898 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6899 Tune. Don't use wider integers than needed. Don't use alloca.
6900 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6902 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6904 * insdel.c, lisp.h (buffer_overflow): New function.
6905 (insert_from_buffer_1, replace_range, replace_range_2):
6906 * insdel.c (make_gap_larger):
6907 * editfns.c (Finsert_char):
6908 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6910 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6912 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6914 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6916 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6917 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6919 * fileio.c: Don't assume EMACS_INT fits in off_t.
6920 (emacs_lseek): New static function.
6921 (Finsert_file_contents, Fwrite_region): Use it.
6922 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6924 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6926 * fns.c: Don't overflow int when computing a list length.
6927 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6928 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6929 truncation on 64-bit hosts. Check for QUIT every
6930 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6931 faster and is responsive enough.
6932 (Flength): Report an error instead of overflowing an integer.
6933 (Fsafe_length): Return a float if the value is not representable
6934 as a fixnum. This shouldn't happen except in contrived situations.
6935 (Fnthcdr, Fsort): Don't assume list length fits in int.
6936 (Fcopy_sequence): Don't assume vector length fits in int.
6938 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6939 (header_size, word_size): New constants.
6940 (allocate_vectorlike): Don't check size overflow here.
6941 (allocate_vector): Check it here instead, since this is the only
6942 caller of allocate_vectorlike that could cause overflow.
6943 Check that the new vector's length is representable as a fixnum.
6945 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6946 The previous code was bogus. For example, next_almost_prime (32)
6947 returned 39, which is undesirable as it is a multiple of 3; and
6948 next_almost_prime (24) returned 25, which is a multiple of 5 so
6949 why was the code bothering to check for multiples of 7?
6951 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6953 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6955 Variadic C functions now count arguments with ptrdiff_t.
6956 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6957 Back then I didn't know that the Emacs coding style prefers signed int.
6958 Also, in the meantime I found a few more instances where arguments
6959 were being counted with int, which may truncate counts on 64-bit
6960 machines, or EMACS_INT, which may be unnecessarily wide.
6961 * lisp.h (struct Lisp_Subr.function.aMANY)
6962 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6963 Arg counts are now ptrdiff_t, not size_t.
6964 All variadic functions and their callers changed accordingly.
6965 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6966 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6967 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6968 * callint.c (Fcall_interactively): Check arg count for overflow,
6969 to avoid potential buffer overrun. Use signed char, not 'int',
6970 for 'varies' array, so that we needn't bother to check its size
6971 calculation for overflow.
6972 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6973 * eval.c (apply_lambda):
6974 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6975 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6976 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6978 * callint.c (Fcall_interactively): Don't use index var as event count.
6980 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6981 * mem-limits.h (SIZE): Remove; no longer used.
6983 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6985 Remove unnecessary casts.
6986 * xterm.c (x_term_init):
6987 * xfns.c (x_set_border_pixel):
6988 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6989 These aren't needed now that we assume ANSI C.
6991 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6992 It's more likely to cause problems (due to unsigned overflow)
6995 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6997 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6999 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7001 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7003 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7005 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7007 GLYPH_CODE_FACE returns EMACS_INT, not int.
7008 * dispextern.h (merge_faces):
7009 * xfaces.c (merge_faces):
7010 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7011 Don't assume EMACS_INT fits in int.
7013 * character.h (CHAR_VALID_P): Remove unused parameter.
7014 * fontset.c, lisp.h, xdisp.c: All uses changed.
7016 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7018 * fns.c (concat): Minor tuning based on overflow analysis.
7019 This doesn't fix any bugs. Use int to hold character, instead
7020 of constantly refetching from Emacs object. Use XFASTINT, not
7021 XINT, for value known to be a character. Don't bother comparing
7022 a single byte to 0400, as it's always less.
7024 * floatfns.c (Fexpt):
7025 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7027 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7030 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7032 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7033 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7034 incorrectly succeed when S was a string, because 4294967386 was
7035 truncated before it was used.
7037 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7038 Otherwise, an out-of-range integer could cause undefined behavior
7041 * composite.c: Use int, not EMACS_INT, for characters.
7042 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7043 EMACS_INT, for values that are known to be in character range.
7044 This doesn't fix any bugs but is the usual style inside Emacs and
7045 may generate better code on 32-bit machines.
7047 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7048 This is for reasons similar to the recent CHAR_STRING fix.
7049 * charset.c (Fencode_char): Check that character arg is actually
7050 a character. Pass an int to ENCODE_CHAR.
7051 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7052 wider than 'int', as a compile-time check to prevent future regressions
7055 * character.c (char_string): Remove unnecessary casts.
7057 Make sure a 64-bit char is never passed to CHAR_STRING.
7058 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7059 by silently ignoring the top 32 bits, allowing some values
7060 that were far too large to be valid characters.
7061 * character.h: Include <verify.h>.
7062 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7063 arguments are no wider than unsigned, as a compile-time check
7064 to prevent future regressions in this area.
7066 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7067 (Fsubst_char_in_region):
7069 * xdisp.c (decode_mode_spec_coding):
7070 Adjust to CHAR_STRING's new requirement.
7071 * editfns.c (Finsert_char, Fsubst_char_in_region):
7072 * fns.c (concat): Check that character args are actually
7073 characters. Without this test, these functions did the wrong
7074 thing with wildly out-of-range values on 64-bit hosts.
7076 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7077 These casts should not be needed on 32-bit hosts, either.
7078 * keyboard.c (read_char):
7079 * lread.c (Fload): Remove casts to unsigned.
7081 * lisp.h (UNSIGNED_CMP): New macro.
7082 This fixes comparison bugs on 64-bit hosts.
7083 (ASCII_CHAR_P): Use it.
7084 * casefiddle.c (casify_object):
7085 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7086 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7087 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7088 * dispextern.h (FACE_FROM_ID):
7089 * keyboard.c (read_char): Use UNSIGNED_CMP.
7091 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7092 not to EMACS_INT, to avoid GCC warning.
7094 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7096 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7097 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7098 isn't needed on 32-bit machines.
7100 * buffer.c (Fgenerate_new_buffer_name):
7101 Use EMACS_INT for count, not int.
7102 (advance_to_char_boundary): Return EMACS_INT, not int.
7104 * data.c (Qcompiled_function): Now static.
7106 * window.c (window_body_lines): Now static.
7108 * image.c (gif_load): Rename local to avoid shadowing.
7110 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7111 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7112 * alloc.c (make_save_value): Integer argument is now of type
7114 (mark_object): Use ptrdiff_t, not int.
7115 * lisp.h (pD): New macro.
7116 * print.c (print_object): Use it.
7118 * alloc.c: Use EMACS_INT, not int, to count objects.
7119 (total_conses, total_markers, total_symbols, total_vector_size)
7120 (total_free_conses, total_free_markers, total_free_symbols)
7121 (total_free_floats, total_floats, total_free_intervals)
7122 (total_intervals, total_strings, total_free_strings):
7123 Now EMACS_INT, not int. All uses changed.
7124 (Fgarbage_collect): Compute overall total using a double, so that
7125 integer overflow is less likely to be a problem. Check for overflow
7126 when converting back to an integer.
7127 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7128 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7129 These were 'int' variables that could overflow on 64-bit hosts;
7130 they were never used, so remove them instead of repairing them.
7131 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7132 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7133 Previously, this ceilinged at INT_MAX, but that doesn't work on
7135 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7137 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7138 (allocate_vectorlike): Check for ptrdiff_t overflow.
7139 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7140 when a (possibly-narrower) signed value would do just as well.
7141 We prefer using signed arithmetic, to avoid comparison confusion.
7143 * alloc.c: Catch some string size overflows that we were missing.
7144 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7145 for convenience in STRING_BYTES_MAX.
7146 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7147 The definition here is exact; the one in lisp.h was approximate.
7148 (allocate_string_data): Check for string overflow. This catches
7149 some instances we weren't catching before. Also, it catches
7150 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7151 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7152 and ptrdiff_t and EMACS_INT are both 64 bits.
7154 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7155 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7156 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7158 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7160 * alloc.c (Fmake_string): Check for out-of-range init.
7162 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7164 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7166 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7168 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7169 xg_get_default_scrollbar_width.
7171 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7172 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7173 (style_changed_cb): Call update_theme_scrollbar_width and call
7174 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7175 all frames (Bug#8505).
7176 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7177 Call gtk_window_set_resizable if HAVE_GTK3.
7178 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7179 and height if HAVE_GTK3 (Bug#8505).
7180 (scroll_bar_width_for_theme): New variable.
7181 (update_theme_scrollbar_width): New function.
7182 (xg_get_default_scrollbar_width): Move code to
7183 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7184 (xg_initialize): Call update_theme_scrollbar_width.
7186 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7188 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7190 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7192 * frame.c (make_frame): Call other_buffer_safely instead of
7195 * window.c (temp_output_buffer_show): Call display_buffer with
7196 second argument Vtemp_buffer_show_specifiers and reset latter
7197 immediately after the call.
7198 (Vtemp_buffer_show_specifiers): New variable.
7199 (auto_window_vscroll_p, next_screen_context_lines)
7200 (Vscroll_preserve_screen_position): Remove leading asterisks from
7203 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7205 Fix minor problems found by GCC 4.6.0 static checking.
7206 * buffer.c (Qclone_number): Remove for now, as it's unused.
7207 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7208 (record_buffer): Remove unused local.
7209 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7210 (set_frame_buffer_list): Remove; unused.
7211 * frame.h (other_visible_frames): Remove decl.
7212 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7213 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7214 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7216 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7217 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7218 Define only if HAVE_GPM.
7219 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7220 (update_hints_inhibit): Remove; never set. All uses removed.
7221 * widgetprv.h (emacsFrameClassRec): Remove decl.
7222 * window.c (delete_deletable_window): Now returns void, since it
7223 wasn't returning anything.
7224 (compare_window_configurations): Remove unused locals.
7225 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7226 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7227 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7228 the same widths as pointers. This follows up on the 2011-05-06 patch.
7229 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7230 * xterm.h: Likewise.
7231 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7233 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7235 * makefile.w32-in: Update dependencies.
7236 (LISP_H): Add lib/intprops.h.
7238 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7240 * image.c (gif_load): Add animation frame delay to the metadata.
7241 (syms_of_image): Use DEFSYM. New symbol `delay'.
7243 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7245 * window.c (delete_deletable_window): Re-add.
7246 (Fset_window_configuration): Rewrite to handle dead buffers and
7247 consequently deletable windows.
7248 (window_tree, Fwindow_tree): Remove. Supply functionality in
7250 (compare_window_configurations): Simplify code.
7252 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7254 * image.c (imagemagick_load_image): Fix type mismatch.
7255 (Fimagemagick_types): Likewise.
7257 * window.h (replace_buffer_in_windows): Declare.
7259 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7261 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7262 Qclone_number. Remove external declaration of Qdelete_window.
7263 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7265 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7266 Run Qbuffer_list_update_hook if allowed.
7267 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7268 buffer list implementation.
7269 (other_buffer_safely): New function.
7270 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7271 calls to replace_buffer_in_windows and
7272 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7274 (record_buffer): Inhibit quitting and rewrite using quittable
7275 functions. Run Qbuffer_list_update_hook if allowed.
7276 (Frecord_buffer, Funrecord_buffer): New functions.
7277 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7278 Move switch-to-buffer to window.el.
7279 (bury-buffer): Move to window.el.
7280 (Vbuffer_list_update_hook): New variable.
7282 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7285 * window.h (resize_frame_windows): Move up in code.
7286 (Fwindow_frame): Remove EXFUN.
7287 (replace_buffer_in_all_windows): Remove prototype.
7288 (replace_buffer_in_windows_safely): Add prototype.
7290 * window.c: Declare Qdelete_window static again. Move down
7291 declaration of select_count.
7292 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7293 (Fother_window): Move to window.el.
7294 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7295 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7296 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7298 (replace_buffer_in_windows): Implement by calling
7299 Qreplace_buffer_in_windows.
7300 (replace_buffer_in_all_windows): Remove with some functionality
7301 moved into replace_buffer_in_windows_safely.
7302 (replace_buffer_in_windows_safely): New function.
7303 (select_window_norecord, select_frame_norecord): Move in front
7304 of run_window_configuration_change_hook. Remove now obsolete
7306 (Fset_window_buffer): Rewrite doc-string.
7307 Call Qrecord_window_buffer.
7308 (keys_of_window): Move binding for other-window to window.el.
7310 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7312 * dispextern.h (struct image): Replace data member, whose int_val
7313 and ptr_val fields were not used by anything, with a single
7316 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7317 (gif_clear_image, gif_load, imagemagick_load_image)
7318 (gs_clear_image, gs_load): Callers changed.
7320 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7322 * buffer.h: Include <time.h>, for time_t.
7323 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7325 Fix minor problems found by static checking.
7327 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7329 Make identifiers static if they are not used in other modules.
7330 * data.c (Qcompiled_function, Qframe, Qvector):
7331 * image.c (QimageMagick, Qsvg):
7332 * minibuf.c (Qmetadata):
7333 * window.c (resize_window_check, resize_root_window): Now static.
7334 * window.h (resize_window_check, resize_root_window): Remove decls.
7336 * window.c (window_deletion_count, delete_deletable_window):
7338 (window_body_lines): Now static.
7339 (Fdelete_other_windows_internal): Mark vars as initialized.
7340 Make sure 'resize_failed' is initialized.
7341 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7342 (resize_window_apply): Remove unused local.
7343 * window.h (delete_deletable_window): Remove decl.
7345 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7346 (imagemagick_load_image): Fix pointer signedness problem by changing
7347 last arg from unsigned char * to char *. All uses changed.
7348 Also, fix a local for similar reasons.
7349 Remove unused locals. Remove locals to avoid shadowing.
7350 (fn_rsvg_handle_free): Remove; unused.
7351 (svg_load, svg_load_image): Fix pointer signedness problem.
7352 (imagemagick_load_image): Don't use garbage pointer image_wand.
7354 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7356 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7358 * image.c (gif_load): Fix omitted cast error introduced by
7361 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7363 * window.h (resize_proportionally, orig_total_lines)
7364 (orig_top_line): Remove from window structure.
7365 (set_window_height, set_window_width, change_window_heights)
7366 (Fdelete_window): Remove prototypes.
7367 (resize_frame_windows): Remove duplicate declaration.
7369 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7371 * window.h (resize_frame_windows, resize_window_check)
7372 (delete_deletable_window, resize_root_window)
7373 (resize_frame_windows): Declare prototypes.
7375 * window.c (resize_window_apply): Make definition be "static" to
7376 match the prototype.
7378 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7380 * window.c: Remove declarations of Qwindow_size_fixed,
7381 window_min_size_1, window_min_size_2, window_min_size,
7382 size_window, window_fixed_size_p, enlarge_window, delete_window.
7383 Remove static from declaration of Qdelete_window, it's
7384 temporarily needed by Fbury_buffer.
7385 (replace_window): Don't assign orig_top_line and
7387 (Fdelete_window, delete_window): Remove. Window deletion is
7388 handled by window.el.
7389 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7390 Replace Fdelete_window calls with calls to Qdelete_window.
7391 (Fdelete_other_windows): Remove. Deleting other windows is
7392 handled by window.el.
7393 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7394 handled in window.el.
7395 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7396 Window minimum sizes are handled in window.el.
7397 (shrink_windows, size_window, set_window_height)
7398 (set_window_width, change_window_heights, window_height)
7399 (window_width, CURBEG, CURSIZE, enlarge_window)
7400 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7401 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7402 handled in window.el.
7403 (make_dummy_parent): Rename to make_parent_window and give it a
7404 second argument horflag.
7405 (make_window): Don't set resize_proportionally any more.
7406 (Fsplit_window): Remove. Windows are split in window.el.
7407 (save_restore_action, save_restore_orig_size)
7408 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7409 Resize mini windows in window.el.
7410 (grow_mini_window, shrink_mini_window): Implement by calling
7411 Qresize_root_window_vertically, resize_window_check and
7412 resize_window_apply.
7413 (saved_window, Fset_window_configuration, save_window_save):
7414 Do not handle orig_top_line, orig_total_lines, and
7415 resize_proportionally.
7416 (window_min_height, window_min_width): Move to window.el.
7417 (keys_of_window): Move bindings for delete-other-windows,
7418 split-window, delete-window and enlarge-window to window.el.
7420 * buffer.c: Temporarily extern Qdelete_window.
7421 (Fbury_buffer): Temporarily call Qdelete_window instead of
7422 Fdelete_window (Fbury_buffer will move to window.el soon).
7424 * frame.c (set_menu_bar_lines_1): Remove code handling
7425 orig_top_line and orig_total_lines.
7427 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7428 set_window_height but set heights directly.
7429 (change_frame_size_1): Use resize_frame_windows.
7431 * xdisp.c (init_xdisp): Don't use set_window_height but set
7434 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7435 Use resize_frame_windows instead of change_window_heights and run
7436 run_window_configuration_change_hook.
7438 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7439 instead of change_window_heights and run
7440 run_window_configuration_change_hook.
7442 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7444 * window.c (replace_window): Rename second argument REPLACEMENT to
7445 NEW. New third argument SETFLAG. Rewrite.
7446 (delete_window, make_dummy_parent): Call replace_window with
7448 (window_list_1): Move down in code.
7449 (run_window_configuration_change_hook): Move set_buffer part
7450 before select_frame_norecord part in order to unwind correctly.
7451 Rename count1 to count.
7452 (recombine_windows, delete_deletable_window, resize_root_window)
7453 (Fdelete_other_windows_internal)
7454 (Frun_window_configuration_change_hook, make_parent_window)
7455 (resize_window_check, resize_window_apply, Fresize_window_apply)
7456 (resize_frame_windows, Fsplit_window_internal)
7457 (Fdelete_window_internal, Fresize_mini_window_internal):
7459 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7461 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7463 * window.h (window): Add some new members to window structure -
7464 normal_lines, normal_cols, new_total, new_normal, clone_number,
7465 splits, nest, prev_buffers, next_buffers.
7466 (WINDOW_TOTAL_SIZE): Move here from window.c.
7467 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7469 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7471 (make_dummy_parent): Set new members of windows structure.
7472 (make_window): Move down in code. Handle new members of window
7474 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7475 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7476 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7477 (Fset_window_prev_buffers, Fwindow_next_buffers)
7478 (Fset_window_next_buffers, Fset_window_clone_number):
7480 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7481 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7483 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7484 Argument WINDOW can be now internal window too.
7485 (Fwindow_use_time): Move up in code.
7486 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7488 (Fset_window_configuration, saved_window)
7489 (Fcurrent_window_configuration, save_window_save): Handle new
7490 members of window structure.
7491 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7492 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7493 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7494 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7495 Qget_mru_window, Qresize_root_window,
7496 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7497 Qauto_buffer_name; staticpro them.
7499 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7501 * window.c (Fwindow_total_size, Fwindow_left_column)
7502 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7503 (Fwindow_list_1): New functions.
7504 (window_box_text_cols): Replace with window_body_cols.
7505 (Fwindow_width, Fscroll_left, Fscroll_right):
7506 Use window_body_cols instead of window_box_text_cols.
7507 (delete_window, Fset_window_configuration):
7508 Call delete_all_subwindows with window as argument.
7509 (delete_all_subwindows): Take a window as argument and not a
7511 (window_loop): Remove handling of GET_LRU_WINDOW and
7513 (Fget_lru_window, Fget_largest_window): Move to window.el.
7515 * window.h: Extern window_body_cols instead of
7516 window_box_text_cols. delete_all_subwindows now takes a
7517 Lisp_Object as argument.
7519 * indent.c (compute_motion, Fcompute_motion):
7520 Use window_body_cols instead of window_box_text_cols.
7522 * frame.c (delete_frame): Call delete_all_subwindows with root
7525 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7527 * fns.c (Fputhash): Document return value.
7529 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7531 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7533 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7535 Cons<->int and similar integer overflow fixes (Bug#8794).
7537 Check for overflow when converting integer to cons and back.
7538 * charset.c (Fdefine_charset_internal, Fdecode_char):
7539 Use cons_to_unsigned to catch overflow.
7540 (Fencode_char): Use INTEGER_TO_CONS.
7541 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7542 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7543 * data.c (long_to_cons, cons_to_long): Remove.
7544 (cons_to_unsigned, cons_to_signed): New functions.
7545 These signal an error for invalid or out-of-range values.
7546 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7547 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7548 * font.c (Ffont_variation_glyphs):
7549 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7550 * lisp.h: Include <intprops.h>.
7551 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7552 (cons_to_signed, cons_to_unsigned): New decls.
7553 (long_to_cons, cons_to_long): Remove decls.
7554 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7555 (Fprimitive_undo): Use CONS_TO_INTEGER.
7556 * xfns.c (Fx_window_property): Likewise.
7557 * xselect.c: Include <limits.h>.
7558 (x_own_selection, selection_data_to_lisp_data):
7559 Use INTEGER_TO_CONS.
7560 (x_handle_selection_request, x_handle_selection_clear)
7561 (x_get_foreign_selection, Fx_disown_selection_internal)
7562 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7563 (lisp_data_to_selection_data): Use cons_to_unsigned.
7564 (x_fill_property_data): Use cons_to_signed.
7565 Report values out of range.
7567 Check for buffer and string overflow more precisely.
7568 * buffer.h (BUF_BYTES_MAX): New macro.
7569 * lisp.h (STRING_BYTES_MAX): New macro.
7570 * alloc.c (Fmake_string):
7571 * character.c (string_escape_byte8):
7572 * coding.c (coding_alloc_by_realloc):
7573 * doprnt.c (doprnt):
7574 * editfns.c (Fformat):
7576 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7577 since they may not be the same number.
7578 * editfns.c (Finsert_char):
7579 * fileio.c (Finsert_file_contents):
7580 Likewise for BUF_BYTES_MAX.
7582 * image.c: Use ptrdiff_t, not int, for sizes.
7583 (slurp_file): Switch from int to ptrdiff_t.
7585 (slurp_file): Check that file size fits in both size_t (for
7586 malloc) and ptrdiff_t (for sanity and safety).
7588 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7589 if b->modtime has its maximal value.
7591 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7593 Don't assume time_t can fit into int.
7594 * buffer.h (struct buffer.modtime): Now time_t, not int.
7595 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7596 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7598 Minor fixes for signed vs unsigned integers.
7599 * character.h (MAYBE_UNIFY_CHAR):
7600 * charset.c (maybe_unify_char):
7601 * keyboard.c (read_char, reorder_modifiers):
7602 XINT -> XFASTINT, since the integer must be nonnegative.
7603 * ftfont.c (ftfont_spec_pattern):
7604 * keymap.c (access_keymap, silly_event_symbol_error):
7605 XUINT -> XFASTINT, since the integer must be nonnegative.
7606 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7607 since it makes no difference and we prefer signed.
7608 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7609 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7612 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7614 * window.h (Fwindow_frame): Declare.
7616 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7618 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7619 (SPARE_MEMORY): Always define.
7620 (LARGE_REQUEST): Remove.
7621 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7623 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7625 * lisp.h: Move EXFUNS for Fframe_root_window,
7626 Fframe_first_window and Fset_frame_selected_window to window.h.
7628 * window.h: Move EXFUNS for Fframe_root_window,
7629 Fframe_first_window and Fset_frame_selected_window here from
7632 * frame.c (Fwindow_frame, Fframe_first_window)
7633 (Fframe_root_window, Fframe_selected_window)
7634 (Fset_frame_selected_window): Move to window.c.
7635 (Factive_minibuffer_window): Move to minibuf.c.
7636 (Fother_visible_frames_p): New function.
7638 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7640 * window.c (decode_window, decode_any_window): Move up in code.
7641 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7642 (inhibit_frame_unsplittable): Remove unused variable.
7643 (Fwindow_buffer): Move up and rewrite doc-string.
7644 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7645 (Fwindow_prev): New functions.
7646 (Fwindow_frame): Move here from frame.c. Accept any window as
7648 (Fframe_root_window, Fframe_first_window)
7649 (Fframe_selected_window): Move here from frame.c. Accept frame
7650 or arbitrary window as argument. Update doc-strings.
7651 (Fminibuffer_window): Move up in code.
7652 (Fwindow_minibuffer_p): Move up in code and simplify.
7653 (Fset_frame_selected_window): Move here from frame.c.
7655 (Fselected_window, select_window, Fselect_window): Move up in
7656 code. Minor doc-string fixes.
7658 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7660 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7661 Do not assume that spare memory exists; that assumption is valid
7662 only if SYSTEM_MALLOC.
7663 (LARGE_REQUEST): New macro, so that the issue of large requests
7664 is separated from the issue of spare memory.
7666 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7668 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7671 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7673 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7676 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7678 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7680 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7682 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7683 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7685 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7687 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7689 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7691 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7692 (x_clipboard_manager_save): Add return value.
7693 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7695 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7696 Obey Vx_select_enable_clipboard_manager. Catch errors in
7697 x_clipboard_manager_save (Bug#8779).
7698 (Vx_select_enable_clipboard_manager): New variable.
7699 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7701 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7703 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7705 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7707 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7708 in the current matrix if keep_current_p is non-zero.
7710 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7712 * bidi.c (bidi_level_of_next_char): Fix last change.
7714 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7716 Support bidi reordering of text covered by display properties.
7718 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7719 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7720 (bidi_cache_search, bidi_cache_iterator_state)
7721 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7722 (bidi_level_of_next_char, bidi_move_to_visually_next):
7723 Support character positions inside a run of characters covered by a
7725 (bidi_paragraph_init, bidi_resolve_explicit_1)
7726 (bidi_level_of_next_char): Call bidi_fetch_char and
7727 bidi_fetch_char_advance instead of FETCH_CHAR and
7729 (bidi_init_it): Initialize new members.
7730 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7732 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7733 instead of using explicit *_CHAR codes.
7734 (bidi_resolve_explicit, bidi_resolve_weak):
7735 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7736 bidirectional text is supported only in multibyte buffers.
7737 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7738 it to initialize the frame_window_p member of struct bidi_it.
7739 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7740 (bidi_resolve_explicit, bidi_resolve_weak)
7741 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7742 bidi_it->nchars is non-positive.
7743 (bidi_level_of_next_char): Don't try to lookup the cache for the
7744 next/previous character if nothing is cached there yet, or if we
7745 were just reseat()'ed to a new position.
7747 * xdisp.c (set_cursor_from_row): Set start and stop points
7748 according to the row's direction when priming the loop that looks
7749 for the glyph on which to display cursor.
7750 (single_display_spec_intangible_p): Function deleted.
7751 (display_prop_intangible_p): Reimplement to call
7752 handle_display_spec instead of single_display_spec_intangible_p.
7753 Accept 3 additional arguments needed by handle_display_spec.
7754 This fixes incorrect cursor motion across display property with complex
7755 values: lists, `(when COND...)' forms, etc.
7756 (single_display_spec_string_p): Support property values that are
7757 lists with the argument STRING its top-level element.
7758 (display_prop_string_p): Fix the condition for processing a
7759 property that is a list to be consistent with handle_display_spec.
7760 (handle_display_spec): New function, refactored from the
7761 last portion of handle_display_prop.
7762 (compute_display_string_pos): Accept additional argument
7763 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7764 value of a `display' property is a "replacing spec".
7765 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7766 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7767 the display property, but just return a value indicating whether
7768 the display property will replace the characters it covers.
7769 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7770 frame_window_p members of struct bidi_it.
7771 (compute_display_string_pos, compute_display_string_end):
7773 (push_it): Accept second argument POSITION, where pop_it should
7774 jump to continue iteration.
7775 (reseat_1): Initialize bidi_it.disp_pos.
7777 * keyboard.c (adjust_point_for_property): Adjust the call to
7778 display_prop_intangible_p to its new signature.
7780 * dispextern.h (struct bidi_it): New member frame_window_p.
7781 (bidi_init_it): Update prototypes.
7782 (display_prop_intangible_p): Update prototype.
7783 (compute_display_string_pos, compute_display_string_end):
7785 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7788 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7790 Malloc failure behavior now depends on size of allocation.
7791 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7792 * lisp.h: Change signatures accordingly.
7793 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7794 All callers changed. (Bug#8762)
7796 * gnutls.c: Use Emacs's memory allocators.
7797 Without this change, the gnutls library would invoke malloc etc.
7798 directly, which causes problems on non-SYNC_INPUT hosts, and which
7799 runs afoul of improving memory_full behavior. (Bug#8761)
7800 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7801 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7802 xfree instead of the default malloc, realloc, free.
7803 (Fgnutls_boot): No need to check for memory allocation failure,
7804 since xmalloc does that for us.
7806 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7807 * category.c (hash_get_category_set):
7808 * ccl.c (ccl_driver):
7809 * charset.c (Fdefine_charset_internal):
7810 * charset.h (struct charset.hash_index):
7811 * composite.c (get_composition_id, gstring_lookup_cache)
7812 (composition_gstring_put_cache):
7813 * composite.h (struct composition.hash_index):
7814 * dispextern.h (struct image.hash):
7815 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7816 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7817 (hashfn_equal, hashfn_user_defined, make_hash_table)
7818 (maybe_resize_hash_table, hash_lookup, hash_put)
7819 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7820 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7821 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7822 * image.c (make_image, search_image_cache, lookup_image)
7823 (xpm_put_color_table_h):
7824 * lisp.h (struct Lisp_Hash_Table):
7825 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7826 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7827 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7828 * alloc.c (allocate_vectorlike):
7829 Check for overflow in vector size calculations.
7830 * ccl.c (ccl_driver):
7831 Check for overflow when converting EMACS_INT to int.
7832 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7833 need to be updated by these changes.
7834 * fns.c (make_hash_table, maybe_resize_hash_table):
7835 Check for integer overflow with large hash tables.
7836 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7837 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7838 (SXHASH_REDUCE): New macro.
7839 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7840 Use it instead of discarding useful hash info with large hash values.
7841 (sxhash_float): New function.
7842 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7843 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7844 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7845 Rewrite to use FIXNUM_BITS, as this simplifies things.
7846 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7847 Adjust signatures to match updated version of code.
7848 (consing_since_gc): Now EMACS_INT, since a single hash table can
7849 use more than INT_MAX bytes.
7851 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7853 Make it possible to build with GCC-4.6+ -O2 -flto.
7855 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7857 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7859 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7860 Call minibuffer-inactive-mode.
7862 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7864 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7865 Update dependencies.
7867 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7869 * data.c (init_data): Remove code for UTS, this system is not
7872 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7874 Don't force ./temacs to start in terminal mode.
7876 * frame.c (make_initial_frame): Initialize faces in all cases, not
7877 only when CANNOT_DUMP is defined.
7878 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7880 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7882 * dispnew.c (add_window_display_history): Use const for the string
7883 pointer. Remove declaration, not needed.
7885 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7887 Use 'inline', not 'INLINE'.
7888 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7889 * alloc.c, fontset.c (INLINE): Remove.
7890 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7891 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7892 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7893 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7894 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7896 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7898 Make it possible to run ./temacs.
7900 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7901 syms_of_callproc does the same thing. Remove test for
7902 "initialized", do it in the caller.
7903 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7905 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7907 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7908 (read_minibuf): Use get_minibuffer.
7909 (syms_of_minibuf): Use DEFSYM.
7910 (Qmetadata): New var.
7911 * data.c (Qbuffer): Don't make it static.
7912 (syms_of_data): Use DEFSYM.
7914 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7916 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7917 (CCL_CODE_MIN): New macro.
7919 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7921 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7923 * eval.c (Qdebug): Now static.
7924 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7925 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7926 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7928 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7930 * image.c: Various fixes to ImageMagick code comments.
7931 (Fimagemagick_types): Doc fix.
7933 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7935 Minor fixes prompted by GCC 4.6.0 warnings.
7937 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7939 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7940 (x_clipboard_manager_save_all): Move extern decl to ...
7941 * xterm.h: ... here, so that it can be checked for consistency.
7943 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7945 * xselect.c (x_clipboard_manager_save_frame)
7946 (x_clipboard_manager_save_all): New functions.
7947 (Fx_clipboard_manager_save): Lisp function deleted.
7949 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7950 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7952 * xterm.h: Update prototype.
7954 2011-05-28 William Xu <william.xwl@gmail.com>
7956 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7959 2011-05-28 Jim Meyering <meyering@redhat.com>
7961 Avoid a sign-extension bug in crypto_hash_function.
7962 * fns.c (to_uchar): Define.
7963 (crypto_hash_function): Use it to convert some newly-signed
7964 variables to unsigned, to avoid sign-extension bugs. For example,
7965 without this change, (md5 "truc") would evaluate to
7966 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7967 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7968 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7970 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7972 Integer overflow fixes.
7974 * dbusbind.c: Serial number integer overflow fixes.
7975 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7976 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7977 to hold a serial number that is too large for a fixnum.
7978 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7979 Check for serial numbers out of range. Decode any serial number
7980 that was so large that it became a float. (Bug#8722)
7982 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7983 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7984 Use XFASTINT rather than XUINT when numbers are nonnegative.
7985 (xd_append_arg, Fdbus_method_return_internal):
7986 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7987 arguments, check that Lisp number is nonnegative, rather than
7988 silently wrapping negative numbers around. (Bug#8722)
7989 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7992 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7994 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7996 ccl: Add integer overflow checks.
7997 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7998 (IN_INT_RANGE): New macros.
7999 (ccl_driver): Use them to check for integer overflow when
8000 decoding a CCL program. Many of the new checks are whether XINT (x)
8001 fits in int; it doesn't always, on 64-bit hosts. The new version
8002 doesn't catch all possible integer overflows, but it's an
8003 improvement. (Bug#8719)
8005 * alloc.c (make_event_array): Use XINT, not XUINT.
8006 There's no need for unsigned here.
8008 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8009 This follows up to the 2011-05-06 change that substituted uintptr_t
8010 for EMACS_INT. This case wasn't caught back then.
8012 Rework Fformat to avoid integer overflow issues.
8013 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8014 now (part of C89). Include <verify.h>.
8015 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8016 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8017 (Fformat): Avoid the prepass trying to compute sizes; it was only
8018 approximate and thus did not catch overflow reliably. Instead, walk
8019 through the format just once, formatting and computing sizes as we go,
8020 checking for integer overflow at every step, and allocating a larger
8021 buffer as needed. Keep track separately whether the format is
8022 multibyte. Keep only the most-recently calculated precision, rather
8023 than them all. Record whether each argument has been converted to
8024 string. Use EMACS_INT, not int, for byte and char and arg counts.
8025 Support field widths and precisions larger than INT_MAX. Avoid
8026 sprintf's undefined behavior with conversion specifications such as %#d
8027 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8028 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8029 formatting out-of-range floating point numbers with int
8032 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8034 * data.c: Avoid integer truncation in expressions involving floats.
8035 * data.c: Include <intprops.h>.
8036 (arith_driver): When there's an integer overflow in an expression
8037 involving floating point, convert the integers to floating point
8038 so that the resulting value does not suffer from catastrophic
8039 integer truncation. For example, on a 64-bit host (* 4
8040 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8041 Do not rely on undefined behavior after integer overflow.
8043 merge count_size_as_multibyte, parse_str_to_multibyte
8044 * character.c, character.h (count_size_as_multibyte):
8045 Rename from parse_str_to_multibyte; all uses changed.
8046 Check for integer overflow.
8047 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8048 since it's now a duplicate of the other. This is more of
8049 a character than a buffer op, so better that it's in character.c.
8050 * fns.c, print.c: Adjust to above changes.
8052 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8054 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8056 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8058 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8059 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8060 (x_clipboard_manager_save): Now static.
8061 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8063 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8064 (crypto_hash_function): Now static.
8065 Fix pointer signedness problems. Avoid unnecessary initializations.
8067 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8069 * termhooks.h (Vselection_alist): Make it terminal-local.
8071 * terminal.c (create_terminal): Initialize it.
8073 * xselect.c: Support for clipboard managers.
8074 (Vselection_alist): Move to termhooks.h as terminal-local var.
8075 (LOCAL_SELECTION): New macro.
8076 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8077 (symbol_to_x_atom): Remove gratuitous arg.
8078 (x_handle_selection_request, lisp_data_to_selection_data)
8079 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8080 (x_own_selection, x_get_local_selection, x_convert_selection):
8081 New arg, specifying work frame. Use terminal-local Vselection_alist.
8082 (some_frame_on_display): Delete unused function.
8083 (Fx_own_selection_internal, Fx_get_selection_internal)
8084 (Fx_disown_selection_internal, Fx_selection_owner_p)
8085 (Fx_selection_exists_p): New optional frame arg.
8086 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8087 (x_handle_selection_clear): Don't treat other terminals with the
8088 same keyboard specially. Use the terminal-local Vselection_alist.
8089 (x_clear_frame_selections): Use Frun_hook_with_args.
8091 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8093 * xterm.h: Add support for those atoms.
8095 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8097 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8098 (converted_selections, conversion_fail_tag): New global variables.
8099 (x_selection_request_lisp_error): Free the above.
8100 (x_get_local_selection): Remove unnecessary code.
8101 (x_reply_selection_request): Args changed; handle arbitrary array
8102 of converted selections stored in converted_selections.
8103 Separate the XChangeProperty and SelectionNotify steps.
8104 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8105 (x_convert_selection): New function.
8106 (x_handle_selection_event): Simplify.
8107 (x_get_foreign_selection): Don't ignore incoming requests while
8108 waiting for an answer; this will fail when we implement
8109 SAVE_TARGETS, and seems unnecessary anyway.
8110 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8111 (Vx_sent_selection_functions): Doc fix.
8113 2011-05-26 Leo Liu <sdl.web@gmail.com>
8115 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8117 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8119 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8121 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8122 for fringe update if it has periodic bitmap.
8123 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8124 and fringe_bitmap_periodic_p.
8126 * fringe.c (get_fringe_bitmap_data): New function.
8127 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8128 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8129 row. Mark glyph row for fringe update if periodicity changed.
8131 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8132 for fringe update unless it has periodic bitmap.
8134 2011-05-25 Kenichi Handa <handa@m17n.org>
8136 * xdisp.c (get_next_display_element): Set correct it->face_id for
8137 a static composition.
8139 2011-05-24 Leo Liu <sdl.web@gmail.com>
8142 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8144 * fns.c (crypto_hash_function, Fsha1): New function.
8145 (Fmd5): Use crypto_hash_function.
8146 (syms_of_fns): Add Ssha1.
8148 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8150 * gnutls.c: Remove unused macros.
8151 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8152 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8153 Remove macros that are defined and never used.
8154 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8156 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8158 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8159 (Fx_get_selection_internal): Minor cleanup.
8160 (Fx_own_selection_internal): Rename arguments for consistency with
8163 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8165 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8167 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8169 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8171 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8173 * dispnew.c (scrolling_window): Don't exclude the case that the
8174 last enabled row in the desired matrix touches the bottom boundary.
8176 2011-05-21 Glenn Morris <rgm@gnu.org>
8178 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8179 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8180 and add some more files.
8182 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8184 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8185 report_file_error introduced by the change from 2011-05-07.
8187 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8189 * systime.h (Time): Define only if emacs is defined.
8190 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8191 where the include path doesn't have X11/X.h by default. See
8192 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8194 2011-05-20 Kenichi Handa <handa@m17n.org>
8196 * composite.c (find_automatic_composition): Fix previous change.
8198 2011-05-20 Glenn Morris <rgm@gnu.org>
8200 * lisp.mk: New file, split from Makefile.in.
8201 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8202 (shortlisp): Remove.
8203 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8205 2011-05-19 Glenn Morris <rgm@gnu.org>
8207 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8208 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8209 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8210 (lisp): Set the order to that of loadup.el.
8211 (shortlisp): Make it a copy of $lisp.
8212 (SOME_MACHINE_LISP): Remove.
8213 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8214 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8216 2011-05-18 Kenichi Handa <handa@m17n.org>
8218 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8219 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8220 (find_automatic_composition): Mostly rewrite for efficiency.
8222 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8224 * makefile.w32-in: Update dependencies.
8226 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8228 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8229 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8231 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8233 Fix some integer overflow issues, such as string length overflow.
8235 * insdel.c (count_size_as_multibyte): Check for string overflow.
8237 * character.c (lisp_string_width): Check for string overflow.
8238 Use EMACS_INT, not int, for string indexes and lengths; in
8239 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8240 the resulting string length overflows an EMACS_INT; instead,
8241 report a string overflow if no precision given. When checking for
8242 precision exhaustion, use a check that cannot possibly have
8243 integer overflow. (Bug#8675)
8244 * character.h (lisp_string_width): Adjust to new signature.
8246 * alloc.c (string_overflow): New function.
8247 (Fmake_string): Use it. This doesn't change behavior, but saves
8248 a few bytes and will simplify future changes.
8249 * character.c (string_escape_byte8): Likewise.
8250 * lisp.h (string_overflow): New decl.
8252 Fixups, following up to the user-interface timestamp change.
8253 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8254 for UI timestamps, instead of unsigned long.
8255 * msdos.c (mouse_get_pos): Likewise.
8256 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8257 * w32gui.h (Time): Define by including "systime.h" rather than by
8258 declaring it ourselves. (Bug#8664)
8260 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8261 * image.c (clear_image_cache): Likewise.
8263 * term.c (term_mouse_position): Don't assume time_t wraparound.
8265 Be more systematic about user-interface timestamps.
8266 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8267 and sometimes 'EMACS_UINT', to represent these timestamps.
8268 This change causes it to use 'Time' uniformly, as that's what X uses.
8269 This makes the code easier to follow, and makes it easier to catch
8270 integer overflow bugs such as Bug#8664.
8271 * frame.c (Fmouse_position, Fmouse_pixel_position):
8272 Use Time, not unsigned long, for user-interface timestamps.
8273 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8274 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8275 * keyboard.h (last_event_timestamp): Likewise.
8276 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8277 * menu.h (xmenu_show): Likewise.
8278 * term.c (term_mouse_position): Likewise.
8279 * termhooks.h (struct input_event.timestamp): Likewise.
8280 (struct terminal.mouse_position_hook): Likewise.
8281 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8282 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8283 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8284 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8286 * menu.h, termhooks.h: Include "systime.h", for Time.
8288 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8289 Don't assume that the difference between two unsigned long values
8290 can fit into an integer. At this point, we know button_down_time
8291 <= event->timestamp, so the difference must be nonnegative, so
8292 there's no need to cast the result if double-click-time is
8293 nonnegative, as it should be; check that it's nonnegative, just in
8294 case. This bug is triggered when events are more than 2**31 ms
8295 apart (about 25 days). (Bug#8664)
8297 * xselect.c (last_event_timestamp): Remove duplicate decl.
8298 (x_own_selection): Remove needless cast to unsigned long.
8300 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8301 that always fit in int. Use a sentinel instead of a counter, to
8302 avoid a temp and to allay GCC's concerns about possible int overflow.
8303 * frame.h (struct frame): Use int for menu_bar_items_used
8304 instead of EMACS_INT, since it always fits in int.
8306 * menu.c (grow_menu_items): Check for int overflow.
8308 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8310 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8311 Before, the code was not consistent. These values cannot exceed
8312 2**31 - 1 so there's no need to make them unsigned.
8313 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8314 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8315 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8317 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8319 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8320 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8321 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8322 presumably because the widths might not match.
8324 * window.c (size_window): Avoid needless test at loop start.
8326 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8328 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8330 2011-05-12 Drew Adams <drew.adams@oracle.com>
8332 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8334 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8336 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8337 `width' to `bar_area_x' and `bar_area_width', respectively.
8338 (x_scroll_run): Take account of fringe background extension.
8340 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8341 Rename local vars `left' and `width' to `bar_area_x' and
8342 `bar_area_width', respectively.
8343 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8344 background extension.
8346 2011-05-10 Jim Meyering <meyering@redhat.com>
8348 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8350 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8352 * image.c (Finit_image_library): Return t for built-in image types,
8353 like pbm and xbm. (Bug#8640)
8355 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8357 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8359 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8361 * w32console.c (Fset_screen_color): Doc fix.
8362 (Fget_screen_color): New function.
8363 (syms_of_ntterm): Defsubr it.
8365 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8366 unlink the temporary file if Fcall_process didn't create it in the
8368 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8369 child process will be redirected to a file specified with `:file'.
8370 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8371 cue to call_process_cleanup not to close that handle.
8373 2011-05-07 Ben Key <bkey76@gmail.com>
8375 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8376 one of two shell specific rules, either bootstrap-temacs-CMD or
8377 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8378 to the previous implementation of the bootstrap-temacs rule.
8379 The bootstrap-temacs-CMD rule is similar to the previous
8380 implementation of the bootstrap-temacs rule except that it
8381 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8384 These changes, along with some changes to nt/configure.bat,
8385 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8386 earlier fix to add support for --cflags and --ldflags options
8387 that include quotes so that it works whether make uses cmd or
8390 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8392 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8393 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8395 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8396 a string. Handle both cases.
8397 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8398 (Fdbus_register_method): Use Qinvalid_function.
8400 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8402 * makefile.w32-in: Update dependencies.
8403 (LISP_H): Add inttypes.h and stdin.h.
8404 (PROCESS_H): Add unistd.h.
8406 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8408 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8409 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8411 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8413 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8415 * term.c (vfatal): Remove stray call to va_end.
8416 It's not needed and the C Standard doesn't allow it here anyway.
8418 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8419 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8421 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8424 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8426 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8428 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8430 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8432 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8434 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8435 * charset.c (Fdefine_charset_internal): Don't initialize
8436 charset.code_space[15]. The value was garbage, on hosts with
8437 32-bit int (Bug#8600).
8439 * lread.c (read_integer): Be more consistent with string-to-number.
8440 Use string_to_number to do the actual conversion; this avoids
8441 rounding errors and fixes some other screwups. Without this fix,
8442 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8443 (digit_to_number): Move earlier, for benefit of read_integer.
8444 Return -1 if the digit is out of range for the base, -2 if it is
8445 not a digit in any supported base. (Bug#8602)
8447 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8449 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8450 to match comment at start of function. This also removes a
8451 GCC warning about overflow in a 32+64-bit port.
8453 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8455 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8456 Reported by Stefan Monnier in
8457 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8458 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8459 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8461 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8462 (EMACS_UINTPTR): Likewise, with uintptr_t.
8464 * lisp.h: Prefer 64-bit EMACS_INT if available.
8465 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8466 on 32-bit hosts that have 64-bit int, so that they can access
8468 However, temporarily disable this change unless the temporary
8469 symbol WIDE_EMACS_INT is defined.
8471 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8473 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8474 This removes an assumption that EMACS_INT and long are the same
8475 width as pointers. The assumption is true for Emacs porting targets
8476 now, but we want to make other targets possible.
8477 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8478 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8479 In the rest of the code, change types of integers that hold casted
8480 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8481 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8482 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8483 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8484 No need to cast type when ORing.
8485 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8486 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8487 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8488 assume EMACS_INT is the same width as char *.
8489 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8490 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8491 Remove no-longer-needed casts.
8492 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8493 (xg_tool_bar_help_callback, xg_make_tool_item):
8494 Use EMACS_INTPTR to hold an integer
8495 that will be cast to void *; this can avoid a GCC warning
8496 if EMACS_INT is not the same width as void *.
8497 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8498 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8499 (current_message_1, set_message_1):
8500 Use a local to convert to proper width without a cast.
8501 * xmenu.c (dialog_selection_callback): Likewise.
8503 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8504 Also, don't assume VALBITS / RAND_BITS is less than 5,
8505 and don't rely on undefined behavior when shifting a 1 left into
8507 * lisp.h (get_random): Change signature to match.
8509 * lread.c (hash_string): Use size_t, not int, for hash computation.
8510 Normally we prefer signed values; but hashing is special, because
8511 it's better to use unsigned division on hash table sizes so that
8512 the remainder is nonnegative. Also, size_t is the natural width
8513 for hashing into memory. The previous code used 'int', which doesn't
8514 retain enough info to hash well into very large tables.
8515 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8517 * dbusbind.c: Don't possibly lose pointer info when converting.
8518 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8519 Use XPNTR rather than XHASH, so that the high-order bits of
8520 the pointer aren't lost when converting through void *.
8522 * eval.c (Fautoload): Don't double-shift a pointer.
8524 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8526 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8528 * gnutls.c (DEF_GNUTLS_FN):
8529 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8531 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8533 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8536 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8538 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8539 New version that can reserve upto 2GB of heap space.
8541 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8543 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8545 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8547 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8548 `gnutls_certificate_set_x509_key_file'.
8550 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8552 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8553 Update dependencies.
8555 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8557 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8558 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8559 Remove unused parameter `fildes'.
8560 * process.c (read_process_output, send_process): Don't pass it.
8562 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8564 Fix previous change: the library cache is defined in w32.c.
8565 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8566 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8568 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8570 Implement dynamic loading of GnuTLS on Windows.
8572 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8573 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8574 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8577 * gnutls.c (Qgnutls_dll): Define.
8578 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8579 (gnutls_*): Declare function pointers.
8580 (init_gnutls_functions): New function to initialize function pointers.
8581 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8582 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8583 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8584 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8585 (emacs_gnutls_write, emacs_gnutls_read)
8586 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8587 (Fgnutls_available_p): New function.
8588 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8589 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8590 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8592 * image.c: Include w32.h.
8593 (Vimage_type_cache): Delete.
8594 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8595 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8596 (w32_delayed_load): Move to w32.c.
8598 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8600 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8601 (w32_delayed_load): Move from image.c. When loading a library, record
8602 its filename in the :loaded-from property of the library id.
8603 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8604 Initialize and staticpro them.
8605 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8607 * process.c: Include lisp.h before w32.h, not after.
8608 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8609 instead of gnutls_record_check_pending.
8611 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8613 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8615 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8616 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8619 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8621 * xterm.c (x_set_frame_alpha): Do not set property on anything
8622 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8624 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8626 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8628 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8630 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8631 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8632 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8633 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8634 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8635 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8636 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8637 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8638 (Qgnutls_bootprop_callbacks_verify): Make static.
8640 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8642 * callproc.c: Indentation fixup.
8644 * sysdep.c (wait_for_termination_1): Make static.
8645 (wait_for_termination, interruptible_wait_for_termination):
8646 Move after wait_for_termination_1.
8648 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8650 * sysdep.c (interruptible_wait_for_termination): New function
8651 which is like wait_for_termination, but allows keyboard
8654 * callproc.c (Fcall_process): Add (:file "file") as an option for
8656 (Fcall_process_region): Ditto.
8658 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8660 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8661 rather than `XVECTOR (FOO)->size'.
8663 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8664 inttypes.h, as a gnulib replacement is used if it not available in
8667 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8669 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8670 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8671 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8673 * coding.c (coding_alloc_by_realloc): Error out if destination
8674 will grow beyond MOST_POSITIVE_FIXNUM.
8675 (decode_coding_emacs_mule): Abort if there isn't enough place in
8676 charbuf for the composition carryover bytes. Reserve an extra
8677 space for up to 2 characters produced in a loop.
8678 (decode_coding_iso_2022): Abort if there isn't enough place in
8679 charbuf for the composition carryover bytes.
8681 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8683 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8684 aborting when %lld or %lll format is passed.
8685 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8686 %llo or %llx format is passed. (Bug#8545)
8688 * window.c (window_scroll_line_based): Use a marker instead of
8689 simple variables to record original value of point. (Bug#7952)
8691 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8692 produced by %s or %c overflows available buffer space. (Bug#8545)
8694 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8696 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8697 (SIZE_MAX): Move defn after all includes, as they might #define it.
8699 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8701 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8703 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8705 * keyboard.c (Qdelayed_warnings_hook): Define.
8706 (command_loop_1): Run `delayed-warnings-hook'
8707 if Vdelayed_warnings_list is non-nil.
8708 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8709 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8711 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8713 * doprnt.c (doprnt): Don't return value smaller than the buffer
8714 size if the message was truncated. (Bug#8545).
8716 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8718 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8719 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8721 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8723 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8725 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8727 * makefile.w32-in: Update dependencies.
8729 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8731 Improve `doprnt' and its usage. (Bug#8545)
8732 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8733 `format_end'. Remove support for %l as a conversion specifier.
8734 Don't use xrealloc. Improve diagnostics when the %l size modifier
8735 is used. Update the commentary.
8737 * eval.c (verror): Simplify calculation of size_t.
8739 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8742 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8744 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8747 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8749 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8750 This makes this file independent of the recent pseudovector change.
8752 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8754 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8756 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8757 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8758 Remove unused local.
8759 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8761 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8762 GCC 4.6.0 optimizes based on type-based alias analysis.
8763 For example, if b is of type struct buffer * and v of type struct
8764 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8765 != &v->size, and therefore "v->size = 1; b->size = 2; return
8766 v->size;" must therefore return 1. This assumption is incorrect
8767 for Emacs, since it type-puns struct Lisp_Vector * with many other
8768 types. To fix this problem, this patch adds a new type struct
8769 vectorlike_header that documents the constraints on layout of vectors
8770 and pseudovectors, and helps optimizing compilers not get fooled
8771 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8772 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8773 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8775 (XSETPVECTYPE): Rewrite in terms of new macro.
8776 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8777 This is a bit clearer, and further avoids the possibility of
8778 undesirable aliasing.
8779 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8780 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8781 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8782 since Lisp_Subr is a special case (no "next" field).
8783 (ASIZE): Now uses header.size rather than size.
8784 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8785 to avoid the hassle of writing XVECTOR (foo)->header.size.
8786 (struct vectorlike_header): New type.
8787 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8788 object, to help avoid aliasing.
8789 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8790 (SUBRP): Likewise, since Lisp_Subr is a special case.
8791 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8792 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8793 (struct Lisp_Hash_Table): Combine first two members into a single
8794 struct vectorlike_header member. All uses of "size" and "next" members
8795 changed to be "header.size" and "header.next".
8796 * buffer.h (struct buffer): Likewise.
8797 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8798 * frame.h (struct frame): Likewise.
8799 * process.h (struct Lisp_Process): Likewise.
8800 * termhooks.h (struct terminal): Likewise.
8801 * window.c (struct save_window_data, struct saved_window): Likewise.
8802 * window.h (struct window): Likewise.
8803 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8804 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8805 * buffer.c (init_buffer_once): Likewise.
8806 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8808 * process.c (Fformat_network_address): Use local var for size,
8811 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8813 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8814 * data.c (atof): Remove decl; no longer used or needed.
8815 (digit_to_number): Move to lread.c.
8816 (Fstring_to_number): Use new string_to_number function, to be
8817 consistent with how the Lisp reader treats infinities and NaNs.
8818 Do not assume that floating-point numbers represent EMACS_INT
8819 without losing information; this is not true on most 64-bit hosts.
8820 Avoid double-rounding errors, by insisting on integers when
8821 parsing non-base-10 numbers, as the documentation specifies.
8822 * lisp.h (string_to_number): New decl, replacing ...
8823 (isfloat_string): Remove.
8824 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8825 (read1): Do not accept +. and -. as integers; this
8826 appears to have been a coding error. Similarly, do not accept
8827 strings like +-1e0 as floating point numbers. Do not report
8828 overflow for integer overflows unless the base is not 10 which
8829 means we have no simple and reliable way to continue.
8830 Break out the floating-point parsing into a new
8831 function string_to_number, so that Fstring_to_number parses
8832 floating point numbers consistently with the Lisp reader.
8833 (digit_to_number): Move here from data.c. Make it static inline.
8834 (E_CHAR, EXP_INT): Remove, replacing with ...
8835 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8836 (string_to_number): New function, replacing isfloat_string.
8837 This function checks for valid syntax and produces the resulting
8838 Lisp float number too. Rework it so that string-to-number
8839 no longer mishandles examples like "1.0e+". Use strtoumax,
8840 so that overflow for non-base-10 numbers is reported only when
8841 there's no portable and simple way to convert to floating point.
8843 * textprop.c (set_text_properties_1): Rewrite for clarity,
8844 and to avoid GCC warning about integer overflow.
8846 * intervals.h (struct interval): Use EMACS_INT for members
8847 where EMACS_UINT might cause problems. See
8848 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8849 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8850 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8852 (offset_intervals): Tell GCC not to worry about length overflow
8853 when negating a negative length.
8855 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8856 (overrun_check_free): Likewise.
8858 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8859 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8862 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8863 (gnutls_make_error): Rename local to avoid shadowing.
8864 (gnutls_emacs_global_deinit): ifdef out; not used.
8865 (Fgnutls_boot): Use const for pointer to readonly storage.
8866 Comment out unused local. Fix pointer signedness problems.
8868 * lread.c (openp): Don't stuff size_t into an 'int'.
8869 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8870 about possible signed overflow.
8872 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8873 (GDK_KEY_g): Don't define if already defined.
8874 (xg_prepare_tooltip): Avoid pointer signedness problem.
8875 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8877 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8878 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8880 * xfns.c (Fx_window_property): Simplify a bit,
8881 to make a bit faster and to avoid GCC 4.6.0 warning.
8882 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8884 * fns.c (internal_equal): Don't assume size_t fits in int.
8886 * alloc.c (compact_small_strings): Tighten assertion a little.
8888 Replace pEd with more-general pI, and fix some printf arg casts.
8889 * lisp.h (pI): New macro, generalizing old pEd macro to other
8890 conversion specifiers. For example, use "...%"pI"d..." rather
8891 than "...%"pEd"...".
8892 (pEd): Remove. All uses replaced with similar uses of pI.
8893 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8894 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8895 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8896 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8897 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8898 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8899 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8901 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8902 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8903 * print.c (safe_debug_print, print_object): Likewise.
8904 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8906 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8907 avoiding the 0 flag, which is not portable.
8908 * process.c (Fmake_network_process): Use pI to avoid cast.
8909 * region-cache.c (pp_cache): Likewise.
8910 * xdisp.c (decode_mode_spec): Likewise.
8911 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8912 behavior on 64-bit hosts with printf arg.
8913 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8914 (x_stop_queuing_selection_requests): Likewise.
8915 (x_get_window_property): Don't truncate byte count to an 'int'
8918 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8919 here, since it parses constructs like leading '-' and spaces,
8920 which are not wanted; and it overflows with large numbers.
8921 Instead, simply match F[0-9]+, which is what is wanted anyway.
8923 * alloc.c: Remove unportable assumptions about struct layout.
8924 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8925 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8926 (allocate_vectorlike, make_pure_vector): Use the new macros,
8927 plus offsetof, to remove unportable assumptions about struct layout.
8928 These assumptions hold on all porting targets that I know of, but
8929 they are not guaranteed, they're easy to remove, and removing them
8930 makes further changes easier.
8932 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8933 This doesn't fix a bug but makes the code clearer.
8934 (string_overrun_cookie): Now const. Use initializers that
8935 don't formally overflow signed char, to avoid warnings.
8936 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8937 can cause Emacs to crash when string overrun checking is enabled.
8938 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8939 multiple of sizeof (EMACS_INT); it need not be, if
8940 alignof(EMACS_INT) < sizeof (EMACS_INT).
8941 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8943 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8945 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8947 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8949 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8950 supposed to be handshaking. (Bug#8556)
8951 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8953 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8955 * lisp.h (Qdebug): List symbol.
8956 * eval.c (Qdebug): Restore global linkage.
8957 * keyboard.c (debug-on-event): New variable.
8958 (handle_user_signal): Break into debugger when debug-on-event
8959 matches the current signal symbol.
8961 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8963 * alloc.c (check_sblock, check_string_bytes)
8964 (check_string_free_list): Convert to standard C.
8966 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8968 * w32.c (emacs_gnutls_push): Fix typo.
8970 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8972 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8973 "cast to pointer from integer of different size".
8975 Improve doprnt and its use in verror. (Bug#8545)
8976 * doprnt.c (doprnt): Document the set of format control sequences
8977 supported by the function. Use SAFE_ALLOCA instead of always
8980 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8981 is one byte too soon. Don't use xrealloc; instead xfree and
8984 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8986 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8989 * gnutls.c: Renamed global_initialized to
8990 gnutls_global_initialized. Added internals for the
8991 :verify-hostname-error, :verify-error, and :verify-flags
8992 parameters of `gnutls-boot' and documented those parameters in the
8993 docstring. Start callback support.
8994 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8995 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8996 on error. Return error code.
8997 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8998 (emacs_gnutls_read): Likewise.
8999 (Fgnutls_boot): Return handshake error code.
9000 (emacs_gnutls_handle_error): New function.
9001 (wsaerror_to_errno): Likewise.
9003 * w32.h (emacs_gnutls_pull): Add prototype.
9004 (emacs_gnutls_push): Likewise.
9006 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9007 (emacs_gnutls_push): Likewise.
9009 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9011 * process.c (wait_reading_process_output): Check if GnuTLS
9012 buffered some data internally if no FDs are set for TLS
9015 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9016 (LIBS): Link to USER_LIBS.
9017 ($(BLD)/gnutls.$(0)): New target.
9019 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9021 * xdisp.c (handle_single_display_spec): Rename the
9022 display_replaced_before_p argument into display_replaced_p, to
9023 make it consistent with the commentary. Fix typos in the
9026 * textprop.c (syms_of_textprop): Remove dead code.
9027 (copy_text_properties): Delete obsolete commentary about an
9028 interface that was deleted long ago. Fix typos in the description
9031 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9032 to changes in oldXMenu/XMenu.h from 2011-04-16.
9033 <menu_help_message, prev_menu_help_message>: Constify.
9034 (IT_menu_make_room): menu->help_text is now `const char **';
9037 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9038 to changes in oldXMenu/XMenu.h from 2011-04-16.
9039 (struct XMenu): Declare `help_text' `const char **'.
9041 * xfaces.c <Qunspecified>: Make extern again.
9043 * syntax.c: Include sys/types.h before including regex.h, as
9046 * doc.c (get_doc_string): Improve the format passed to `error'.
9048 * doprnt.c (doprnt): Improve commentary.
9050 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9052 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9055 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9056 changes in globals.h immediately force recompilation.
9057 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9058 $(CURDIR)/s/ms-w32.h.
9059 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9061 * character.c (Fchar_direction): Function deleted.
9062 (syms_of_character): Don't defsubr it.
9063 <char-direction-table>: Deleted.
9065 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9067 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9068 * doprnt.c: Include limits.h.
9069 (SIZE_MAX): New macro.
9070 (doprnt): Return a size_t value. 2nd arg is now size_t.
9071 Many local variables are now size_t instead of int or unsigned.
9072 Improve overflow protection. Support `l' modifier for integer
9073 conversions. Support %l conversion. Don't assume an EMACS_INT
9074 argument for integer conversions and for %c.
9076 * lisp.h (doprnt): Restore prototype.
9078 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9081 * Makefile.in (base_obj): Add back doprnt.o.
9083 * deps.mk (doprnt.o): Add back prerequisites.
9084 (callint.o): Depend on character.h.
9086 * eval.c (internal_lisp_condition_case): Include the handler
9087 representation in the error message.
9088 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9089 when breaking from the loop.
9091 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9093 * callint.c (Fcall_interactively): When displaying error message
9094 about invalid control letter, pass the character's codepoint, not
9095 a pointer to its multibyte form. Improve display of the character
9096 in octal and display also its hex code.
9098 * character.c (char_string): Use %x to display the (unsigned)
9099 codepoint of an invalid character, to avoid displaying a bogus
9102 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9103 `error', not SYMBOL_NAME itself.
9105 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9106 character arguments to `error'.
9108 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9109 to `error' in error message about FINAL_CHAR argument. Make sure
9110 FINAL_CHAR is a character, and use %c when it is passed as
9111 argument to `error'.
9113 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9115 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9117 * w32.c: Include <time.h>.
9118 (sys_localtime): New function.
9120 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9122 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9124 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9126 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9128 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9131 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9133 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9134 gl_state.e_property when gl_state.object is Qt.
9136 * insdel.c (make_gap_larger): Remove limitation of buffer size
9139 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9141 * xdisp.c (lookup_glyphless_char_display)
9142 (produce_glyphless_glyph): Handle cons cell entry in
9143 glyphless-char-display.
9144 (Vglyphless_char_display): Document it.
9146 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9147 glyphless-char-display.
9149 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9151 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9153 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9155 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9156 definition for no-X builds.
9158 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9160 Static checks with GCC 4.6.0 and non-default toolkits.
9162 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9164 * process.c (keyboard_bit_set): Define only if SIGIO.
9165 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9166 (send_process): Repair possible setjmp clobbering.
9168 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9170 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9172 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9174 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9175 Define only if needed.
9177 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9178 by pacifying GCC about it. Maybe it's time to retire it?
9179 * xfaces.c (USG, __TIMEVAL__): Likewise.
9181 * dispextern.h (struct redisplay_interface): Rename param
9183 * termhooks.h (struct terminal): Likewise.
9184 * xterm.c (xembed_send_message): Likewise.
9186 * insdel.c (make_gap_smaller): Define only if
9187 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9189 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9192 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9193 so that we aren't warned about unused symbols.
9195 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9197 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9199 * xfns.c (x_real_positions): Mark locals as initialized.
9201 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9203 * xterm.c: Fix problems found by static analysis with other toolkits.
9204 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9205 (x_dispatch_event): Declare static if USE_GTK, and
9206 define if USE_GTK || USE_X_TOOLKIT.
9207 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9208 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9209 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9210 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9212 * xmenu.c (menu_help_callback): Pointer type fixes.
9213 Use const pointers when pointing at readonly data. Avoid pointer
9215 (FALSE): Remove unused macro.
9216 (update_frame_menubar): Remove unused decl.
9218 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9220 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9221 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9222 (single_menu_item): Rename local to avoid shadowing.
9224 * keyboard.c (make_lispy_event): Remove unused local var.
9226 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9227 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9229 * bitmaps: Change bitmaps from unsigned char back to the X11
9230 compatible char. Avoid the old compiler warnings about
9231 out-of-range initializers by using, for example, '\xab' rather
9234 * xgselect.c (xgselect_initialize): Check vs interface
9235 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9237 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9239 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9240 to read-only memory.
9242 * fns.c (vector): Remove; this old hack is no longer needed.
9244 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9246 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9248 * xrdb.c (x_load_resources): Omit unused local.
9250 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9251 (x_window): Rename locals to avoid shadowing.
9252 (USG): Use the kludged USG macro, to pacify gcc.
9254 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9255 (x_term_init): Remove local to avoid shadowing.
9257 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9259 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9260 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9262 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9264 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9266 Fix regex.c, syntax.c and friends for buffers > 2GB.
9267 * syntax.h (struct gl_state_s): Declare character position members
9270 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9272 * textprop.c (verify_interval_modification, interval_of):
9273 Declare arguments EMACS_INT.
9275 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9278 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9280 * indent.c (Fvertical_motion): Local variable it_start is now
9283 * regex.c (re_match, re_match_2, re_match_2_internal)
9284 (bcmp_translate, regcomp, regexec, print_double_string)
9285 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9286 (re_compile_pattern, re_exec): Declare arguments and local
9287 variables `size_t' and `ssize_t' and return values `regoff_t', as
9289 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9290 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9291 <compile_stack_type>: `size' and `avail' are now `size_t'.
9293 * regex.h <regoff_t>: Use ssize_t, not int.
9294 (re_search, re_search_2, re_match, re_match_2): Arguments that
9295 specify buffer/string position and length are now ssize_t and
9296 size_t. Return type is regoff_t.
9298 2011-04-16 Ben Key <bkey76@gmail.com>
9300 * nsfont.m: Fixed bugs in ns_get_family and
9301 ns_descriptor_to_entity that were caused by using free to
9302 deallocate memory blocks that were allocated by xmalloc (via
9303 xstrdup). This caused Emacs to crash when compiled with
9304 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9305 --enable-checking=xmallocoverrun). xfree is now used to
9306 deallocate these memory blocks.
9308 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9310 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9312 emacs_write: Accept and return EMACS_INT for sizes.
9313 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9315 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9316 Accept and return EMACS_INT.
9317 (emacs_gnutls_write): Return the number of bytes written on
9319 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9320 (emacs_read, emacs_write): Remove check for negative size, as the
9321 Emacs source code has been audited now.
9322 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9323 (emacs_read, emacs_write): Use it.
9324 * process.c (send_process): Adjust to the new signatures of
9325 emacs_write and emacs_gnutls_write. Do not attempt to store
9326 a byte offset into an 'int'; it might overflow.
9327 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9329 * sound.c: Don't assume sizes fit in 'int'.
9330 (struct sound_device.period_size, alsa_period_size):
9331 Return EMACS_INT, not int.
9332 (struct sound_device.write, vox_write, alsa_write):
9333 Accept EMACS_INT, not int.
9334 (wav_play, au_play): Use EMACS_INT to store sizes and to
9335 record read return values.
9337 2011-04-15 Ben Key <bkey76@gmail.com>
9339 * keyboard.c (Qundefined): Don't declare static since it is used
9341 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9342 static since they are used in nsfont.m.
9344 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9346 * process.c (Qprocessp): Don't declare static.
9347 * lisp.h (Qprocessp): Declare again.
9349 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9351 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9353 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9355 Improve C-level modularity by making more things 'static'.
9357 Don't publish debugger-only interfaces to other modules.
9358 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9359 (verify_bytepos, count_markers): Move decls to the only modules
9361 * region-cache.h (pp_cache): Likewise.
9362 * window.h (check_all_windows): Likewise.
9363 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9365 * sysdep.c (croak): Now static, if
9366 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9367 * syssignal.h (croak): Declare only if not static.
9369 * alloc.c (refill_memory_reserve): Now static if
9370 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9371 * lisp.h (refill_memory_reserve): Declare only if not static.
9373 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9374 Define only if USE_LUCID.
9376 * xrdb.c (x_customization_string, x_rm_string): Now static.
9378 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9379 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9381 * xdisp.c (draw_row_with_mouse_face): Now static.
9382 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9384 * window.h (check_all_windows): Mark externally visible.
9386 * window.c (window_deletion_count): Now static.
9388 * undo.c: Make symbols static if they're not exported.
9389 (last_undo_buffer, last_boundary_position, pending_boundary):
9392 * textprop.c (interval_insert_behind_hooks): Now static.
9393 (interval_insert_in_front_hooks): Likewise.
9395 * term.c: Make symbols static if they're not exported.
9396 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9397 (max_frame_lines, tty_set_terminal_modes):
9398 (tty_reset_terminal_modes, tty_turn_off_highlight):
9399 (get_tty_terminal): Now static.
9400 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9401 * termhooks.h (term_mouse_moveto): Do not declare if
9403 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9404 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9406 * sysdep.c: Make symbols static if they're not exported.
9407 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9409 (sigprocmask_set, full_mask): Remove; unused.
9410 (wait_debugging): Mark as visible.
9411 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9412 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9414 * syntax.c (syntax_temp): Define only if !__GNUC__.
9416 * sound.c (current_sound_device, current_sound): Now static.
9418 * search.c (searchbufs, searchbuf_head): Now static.
9420 * scroll.c (scroll_cost): Remove; unused.
9421 * dispextern.h (scroll_cost): Remove decl.
9423 * region-cache.h (pp_cache): Mark as externally visible.
9425 * process.c: Make symbols static if they're not exported.
9426 (process_tick, update_tick, create_process, chan_process):
9427 (Vprocess_alist, proc_buffered_char, datagram_access):
9428 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9429 (deactivate_process): Mark defn as static, as well as decl.
9430 * lisp.h (create_process): Remove decl.
9431 * process.h (chan_process, Vprocess_alist): Remove decls.
9433 * print.c: Make symbols static if they're not exported.
9434 (print_depth, new_backquote_output, being_printed, print_buffer):
9435 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9436 (print_interval, print_number_index, initial_stderr_stream):
9438 * lisp.h (Fprinc): Remove decl.
9439 (debug_output_compilation_hack): Mark as externally visible.
9441 * sysdep.c (croak): Move decl from here to syssignal.h.
9442 * syssignal.h (croak): Put it here, so the API can be checked when
9443 'croak' is called from dissociate_if_controlling_tty.
9445 * minibuf.c: Make symbols static if they're not exported.
9446 (minibuf_save_list, choose_minibuf_frame): Now static.
9447 * lisp.h (choose_minibuf_frame): Remove decl.
9449 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9451 * lread.c: Make symbols static if they're not exported.
9452 (read_objects, initial_obarray, oblookup_last_bucket_number):
9454 (make_symbol): Remove; unused.
9455 * lisp.h (initial_obarray, make_symbol): Remove decls.
9457 * keyboard.c: Make symbols static if they're not exported.
9458 (single_kboard, recent_keys_index, total_keys, recent_keys):
9459 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9460 (this_single_command_key_start, echoing, last_auto_save):
9461 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9462 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9463 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9464 (Vlispy_mouse_stem, double_click_count):
9466 (force_auto_save_soon): Define only if SIGDANGER.
9467 (ignore_mouse_drag_p): Now static if
9468 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9469 (print_help): Remove; unused.
9470 (stop_character, last_timer_event): Mark as externally visible.
9471 * keyboard.h (ignore_mouse_drag_p): Declare only if
9472 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9473 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9474 * lisp.h (echoing): Remove decl.
9475 (force_auto_save_soon): Declare only if SIGDANGER.
9476 * xdisp.c (redisplay_window): Simplify code, to make it more
9477 obvious that ignore_mouse_drag_p is not accessed if !defined
9478 USE_GTK && !defined HAVE_NS.
9480 * intervals.c: Make symbols static if they're not exported.
9481 (merge_properties_sticky, merge_interval_right, delete_interval):
9483 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9485 * insdel.c: Make symbols static if they're not exported.
9486 However, leave prepare_to_modify_buffer alone. It's never
9487 called from outside this function, but that appears to be a bug.
9488 (combine_after_change_list, combine_after_change_buffer):
9489 (adjust_after_replace, signal_before_change): Now static.
9490 (adjust_after_replace_noundo): Remove; unused.
9491 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9492 (signal_before_change): Remove decls.
9494 * indent.c (val_compute_motion, val_vmotion): Now static.
9496 * image.c: Make symbols static if they're not exported.
9497 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9499 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9500 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9502 * fringe.c (standard_bitmaps): Now static.
9503 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9505 * frame.c: Make symbols static if they're not exported.
9506 (x_report_frame_params, make_terminal_frame): Now static.
9507 (get_frame_param): Now static, unless HAVE_NS.
9508 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9509 (x_get_resource_string): Remove; not used.
9510 * frame.h (make_terminal_frame, x_report_frame_params):
9511 (x_get_resource_string); Remove decls.
9512 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9513 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9515 * font.c, fontset.c: Make symbols static if they're not exported.
9516 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9517 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9518 * font.c (font_close_object): Now static.
9519 * font.h (font_close_object): Remove.
9520 * fontset.c (FONTSET_OBJLIST): Remove.
9521 (free_realized_fontset) #if-0 the body, which does nothing.
9522 (face_suitable_for_char_p): #if-0, as it's never called.
9523 * fontset.h (face_suitable_for_char_p): Remove decl.
9524 * xfaces.c (face_at_string_position):
9525 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9526 since 0 is always ASCII.
9528 * fns.c (weak_hash_tables): Now static.
9530 * fileio.c: Make symbols static if they're not exported.
9531 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9532 (Vwrite_region_annotation_buffers): Now static.
9534 * eval.c: Make symbols static if they're not exported.
9535 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9536 * lisp.h (backtrace_list): Remove decl.
9538 * emacs.c: Make symbols static if they're not exported.
9539 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9540 (fatal_error_code, fatal_error_signal_hook, standard_args):
9542 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9543 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9544 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9545 * lisp.h (fatal_error_signal_hook): Remove decl.
9546 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9548 * editfns.c: Move a (normally-unused) function to its only use.
9549 * editfns.c, lisp.h (get_operating_system_release): Remove.
9550 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9551 worth the hassle of breaking this out.
9553 * xterm.c: Make symbols static if they're not exported.
9554 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9555 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9556 (x_destroy_window, x_delete_display):
9558 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9559 (x_mouse_leave): Remove; unused.
9560 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9561 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9562 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9564 (x_mouse_leave): Declare only if WINDOWSNT.
9565 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9566 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9569 * ftxfont.c: Make symbols static if they're not exported.
9570 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9572 * font.h (ftxfont_driver): Likewise.
9574 * xfns.c: Make symbols static if they're not exported.
9575 (x_last_font_name, x_display_info_for_name):
9576 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9577 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9578 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9579 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9580 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9581 (last_show_tip_args): Now static.
9582 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9583 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9584 (x_screen_planes): Remove; unused.
9585 * dispextern.h (x_screen_planes): Remove decl.
9587 * dispnew.c: Make symbols static if they're not exported.
9588 * dispextern.h (redraw_garbaged_frames, scrolling):
9589 (increment_row_positions): Remove.
9590 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9591 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9593 (redraw_garbaged_frames): Remove; unused.
9595 * xfaces.c: Make symbols static if they're not exported.
9596 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9598 * xterm.h (defined_color): Remove decls.
9599 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9600 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9601 (menu_face_changed_default, defined_color, free_realized_face):
9602 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9603 (ascii_face_of_lisp_face): Remove; unused.
9605 * xdisp.c: Make symbols static if they're not exported.
9606 * dispextern.h (scratch_glyph_row, window_box_edges):
9607 (glyph_to_pixel_coords, set_cursor_from_row):
9608 (get_next_display_element, set_iterator_to_next):
9609 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9610 (show_mouse_face): Remove decls
9611 * frame.h (message_buf_print): Likewise.
9612 * lisp.h (pop_message, set_message, check_point_in_composition):
9614 * xterm.h (set_vertical_scroll_bar): Likewise.
9615 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9616 (message_buf_print, scratch_glyph_row, displayed_buffer):
9617 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9618 (get_next_display_element, show_mouse_face, window_box_edges):
9619 (frame_to_window_pixel_xy, check_point_in_composition):
9620 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9621 (glyph_to_pixel_coords): Remove; unused.
9623 * dired.c (file_name_completion): Now static.
9625 * dbusbind.c (xd_in_read_queued_messages): Now static.
9627 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9628 * data.c (circular_list_error): Remove.
9630 * commands.h (last_point_position, last_point_position_buffer):
9631 (last_point_position_window): Remove decls.
9632 * keyboard.c: Make these variables static.
9634 * coding.h (coding, code_convert_region, encode_coding_gap):
9636 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9637 (iso_code_class, detect_coding, code_convert_region): Now static.
9638 (encode_coding_gap): Remove; unused.
9640 * chartab.c (chartab_chars, chartab_bits): Now static.
9642 * charset.h (charset_iso_8859_1): Remove decl.
9643 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9646 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9647 * ccl.c (Vccl_program_table): Now static.
9648 (check_ccl_update): Remove; unused.
9650 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9651 * category.h: ... from here.
9652 * category.c (check_category_table, set_category_set): Now static.
9654 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9655 * lisp.h: Remove these decls.
9657 * buffer.c (buffer_count): Remove unused var.
9659 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9660 so that it's not optimized away.
9661 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9662 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9663 exported only to the debugger.
9665 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9666 * atimer.h (run_all_atimers): Remove; not exported.
9668 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9669 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9670 was inaccessible from Lisp.
9671 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9672 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9674 alloc.c: Import and export fewer symbols, and remove unused items.
9675 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9677 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9678 it's not optimized away by whole-program optimization.
9679 (message_enable_multibyte, free_misc): Remove.
9680 (catchlist, handlerlist, mark_backtrace):
9681 Declare only if BYTE_MARK_STACK.
9682 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9683 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9684 (message_enable_multibyte): Remove decl.
9685 (free_misc, interval_free_list, float_block, float_block_index):
9686 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9687 (cons_free_list, last_marked_index):
9689 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9690 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9691 (mark_backtrace): Define only if BYTE_MARK_STACK.
9692 * xdisp.c (message_enable_multibyte): Now static.
9694 Declare Lisp_Object Q* variables to be 'static' if not exported.
9695 This makes it easier for human readers (and static analyzers)
9696 to see whether these variables are used from other modules.
9697 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9698 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9699 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9700 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9701 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9702 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9703 * xmenu.c, xselect.c:
9704 Declare Q* vars static if they are not used in other modules.
9705 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9706 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9707 Remove decls of unexported vars.
9708 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9710 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9712 Make Emacs functions such as Fatom 'static' by default.
9713 This makes it easier for human readers (and static analyzers)
9714 to see whether these functions can be called from other modules.
9715 DEFUN now defines a static function. To make the function external
9716 so that it can be used in other C modules, use the new macro DEFUE.
9717 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9718 (Finit_image_library):
9719 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9720 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9721 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9722 Remove decls, since these functions are now static.
9723 (Funintern, Fget_internal_run_time): New decls, since these functions
9724 were already external.
9726 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9727 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9728 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9729 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9730 * keyboard.c, keymap.c, lread.c:
9731 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9732 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9733 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9734 Mark functions with DEFUE instead of DEFUN,
9735 if they are used in other modules.
9736 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9737 decls for now-static functions.
9738 * buffer.h (Fdelete_overlay): Remove decl.
9739 * callproc.c (Fgetenv_internal): Mark as internal.
9740 * composite.c (Fremove_list_of_text_properties): Remove decl.
9741 (Fcomposition_get_gstring): New forward static decl.
9742 * composite.h (Fcomposite_get_gstring): Remove decl.
9743 * dired.c (Ffile_attributes): New forward static decl.
9744 * doc.c (Fdocumntation_property): New forward static decl.
9745 * eval.c (Ffetch_bytecode): New forward static decl.
9746 (Funintern): Remove extern decl; now in .h file where it belongs.
9747 * fileio.c (Fmake_symbolic_link): New forward static decl.
9748 * image.c (Finit_image_library): New forward static decl.
9749 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9750 * intervals.h (Fprevious_property_change):
9751 (Fremove_list_of_text_properties): Remove decls.
9752 * keyboard.c (Fthis_command_keys): Remove decl.
9753 (Fcommand_execute): New forward static decl.
9754 * keymap.c (Flookup_key): New forward static decl.
9755 (Fcopy_keymap): Now static.
9756 * keymap.h (Flookup_key): Remove decl.
9757 * process.c (Fget_process): New forward static decl.
9758 (Fprocess_datagram_address): Mark as internal.
9759 * syntax.c (Fsyntax_table_p): New forward static decl.
9760 (skip_chars): Remove duplicate decl.
9761 * textprop.c (Fprevious_property_change): New forward static decl.
9762 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9764 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9765 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9767 * editfns.c (Fformat): Remove unreachable code.
9769 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9771 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9774 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9776 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9777 when at ZV. (Bug#8487)
9779 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9781 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9783 * keyboard.c (parse_tool_bar_item): Likewise.
9784 * sound.c (sound_cleanup, alsa_close): Likewise.
9785 * termcap.c (tgetent): Likewise.
9786 * xfns.c (x_default_font_parameter): Likewise.
9787 * xsettings.c (read_and_apply_settings): Likewise.
9789 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9790 (overrun_check_free): Protoize.
9792 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9794 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9795 since callers should never pass a negative size.
9796 Change the signature to match that of plain 'read' and 'write'; see
9797 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9798 * lisp.h: Update prototypes of emacs_write and emacs_read.
9800 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9802 * xdisp.c (redisplay_window): Don't try to determine the character
9803 position of the scroll margin if the window start point w->startp
9804 is outside the buffer's accessible region. (Bug#8468)
9806 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9808 Fix write-region and its subroutines for buffers > 2GB.
9809 * fileio.c (a_write, e_write): Modify declaration of arguments and
9810 local variables to support buffers larger than 2GB.
9811 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9813 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9814 argument, local variables, and return value.
9816 * lisp.h: Update prototypes of emacs_write and emacs_read.
9818 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9820 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9822 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9824 Fix more problems found by GCC 4.6.0's static checks.
9826 * xdisp.c (vmessage): Use a better test for character truncation.
9828 * charset.c (load_charset_map): <, not <=, for optimization,
9829 and to avoid potential problems with integer overflow.
9830 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9831 * casetab.c (set_identity, shuffle): Likewise.
9832 * editfns.c (Fformat): Likewise.
9833 * syntax.c (skip_chars): Likewise.
9835 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9836 This also lets GCC 4.6.0 generate slightly better loop code.
9838 * callint.c (Fcall_interactively): <, not <=, for optimization.
9839 (Fcall_interactively): Count the number of arguments produced,
9840 not the number of arguments given. This is simpler and lets GCC
9841 4.6.0 generate slightly better code.
9843 * ftfont.c: Distingish more carefully between FcChar8 and char.
9844 The previous code passed unsigned char * to a functions like
9845 strlen and xstrcasecmp that expect char *, which does not
9846 conform to the C standard.
9847 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9848 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9849 char * when the C standard requires it.
9851 * keyboard.c (read_char): Remove unused var.
9853 * eval.c: Port to Windows vsnprintf (Bug#8435).
9855 (SIZE_MAX): Define if the headers do not.
9856 (verror): Do not give up if vsnprintf returns a negative count.
9857 Instead, grow the buffer. This ports to Windows vsnprintf, which
9858 does not conform to C99. Problem reported by Eli Zaretskii.
9859 Also, simplify the allocation scheme, by avoiding the need for
9860 calling realloc, and removing the ALLOCATED variable.
9862 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9864 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9865 But keep the doprint source code for now, as we might revamp it
9866 and use it again (Bug#8435).
9867 * lisp.h (doprnt): Remove.
9868 * Makefile.in (base_obj): Remove doprnt.o.
9869 * deps.mk (doprnt.o): Remove.
9871 error: Print 32- and 64-bit integers portably (Bug#8435).
9872 Without this change, on typical 64-bit hosts error ("...%d...", N)
9873 was used to print both 32- and 64-bit integers N, which relied on
9875 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9876 * lisp.h (error, verror): Mark as printf-like functions.
9877 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9878 Report overflow in size calculations when allocating printf buffer.
9879 Do not truncate output string at its first null byte.
9880 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9881 Truncate the output at a character boundary, since vsnprintf does not
9883 * charset.c (check_iso_charset_parameter): Convert internal
9884 character to string before calling 'error', since %c now has the
9886 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9887 overflow when computing char to be passed to 'error'. Do not
9888 pass Lisp_Object to 'error'; pass the integer instead.
9889 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9890 formatted with plain %d.
9892 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9894 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9896 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9898 * xterm.c (x_catch_errors): Remove duplicate declaration.
9900 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9902 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9904 2011-04-10 Jim Meyering <meyering@redhat.com>
9906 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9907 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9908 return ssize_t not "int", and use size_t as the buffer length.
9909 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9910 * gnutls.h: Update declarations.
9911 * process.c (read_process_output): Use ssize_t, to match.
9912 (send_process): Likewise.
9914 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9916 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9918 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9920 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9921 Use unsigned char, to match FcChar8 type definition.
9923 * xterm.c (handle_one_xevent):
9924 * xmenu.c (create_and_show_popup_menu):
9925 * xselect.c (x_decline_selection_request)
9926 (x_reply_selection_request): Avoid type-punned deref of X events.
9928 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9930 Fix some uses of `int' instead of EMACS_INT.
9931 * search.c (string_match_1, fast_string_match)
9932 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9933 (scan_buffer, find_next_newline_no_quit)
9934 (find_before_next_newline, search_command, Freplace_match)
9935 (Fmatch_data): Make some `int' variables be EMACS_INT.
9937 * xdisp.c (display_count_lines): 3rd argument and return value now
9938 EMACS_INT. All callers changed.
9939 (pint2hrstr): Last argument is now EMACS_INT.
9941 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9942 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9943 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9944 (decode_coding_utf_16, decode_coding_emacs_mule)
9945 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9946 (decode_coding_ccl, decode_coding_charset)
9947 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9948 (decode_coding_iso_2022, decode_coding_emacs_mule)
9949 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9950 <char_offset, last_offset>: Declare EMACS_INT.
9951 (encode_coding_utf_8, encode_coding_utf_16)
9952 (encode_coding_emacs_mule, encode_invocation_designation)
9953 (encode_designation_at_bol, encode_coding_iso_2022)
9954 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9955 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9957 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9958 (encode_invocation_designation): Last argument P_NCHARS is now
9960 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9961 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9963 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9966 * ccl.c (Fccl_execute_on_string): Declare some variables
9969 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9971 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9973 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9975 * process.c (Fformat_network_address): Doc fix.
9977 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9979 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9981 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9983 * keyboard.c (read_char): Call Lisp function help-form-show,
9984 instead of using internal_with_output_to_temp_buffer.
9985 (Qhelp_form_show): New var.
9986 (syms_of_keyboard): Use DEFSYM macro.
9988 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9990 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9992 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9994 * process.c (Flist_processes): Remove to Lisp.
9995 (list_processes_1): Delete.
9997 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9999 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10001 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10003 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10005 Fix more problems found by GCC 4.6.0's static checks.
10007 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10009 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10011 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10013 * xdisp.c (vmessage): Mark as a printf-like function.
10015 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10017 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10019 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10020 printf-like functions.
10021 (tiff_load): Add casts to remove these marks before passing them
10022 to system-supplied API.
10024 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10026 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10027 This avoids several warnings with gcc -Wstrict-overflow.
10028 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10029 directly, rather than having caller test rule sign. This avoids
10030 some unnecessary tests.
10031 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10032 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10033 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10035 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10036 (xfont_open): Avoid unnecessary tests.
10038 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10040 * composite.h, composite.c (composition_gstring_put_cache):
10041 Use EMACS_INT, not int, for length.
10043 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10044 breaking out part of COMPOSITION_DECODE_RULE.
10045 (COMPOSITION_DECODE_RULE): Use it.
10046 * composite.c (get_composition_id): Remove unused local vars,
10047 by using the new macro.
10049 * textprop.c (set_text_properties_1): Change while to do-while,
10050 since the condition is always true at first.
10052 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10053 (interval_deletion_adjustment): Return unsigned value.
10056 * process.c (list_processes_1, create_pty, read_process_output):
10057 (exec_sentinel): Remove vars that were set but not used.
10058 (create_pty): Remove unnecessary "volatile"s.
10059 (Fnetwork_interface_info): Avoid possibility of int overflow.
10060 (read_process_output): Do adaptive read buffering even if carryover.
10061 (read_process_output): Simplify nbytes computation if buffered.
10063 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10065 * syntax.c (scan_words): Remove var that was set but not used.
10066 (update_syntax_table): Use unsigned instead of int.
10068 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10069 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10070 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10072 * print.c (print_error_message): Avoid int overflow.
10074 * font.c (font_list_entities): Redo for clarity,
10075 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10077 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10078 (font_score): Avoid potential overflow in diff calculation.
10080 * fns.c (substring_both): Remove var that is set but not used.
10081 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10083 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10085 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10086 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10087 can always succeed if overflow has undefined behavior.
10089 * search.c (boyer_moore, wordify): Remove vars set but not used.
10090 (wordify): Omit three unnecessary tests.
10092 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10093 All callers changed. This avoids the need for an unused var.
10095 * casefiddle.c (casify_region): Remove var that is set but not used.
10097 * dired.c (file_name_completion): Remove var that is set but not used.
10099 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10101 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10102 (Finsert_file_contents): Remove unnecessary code checking fd.
10104 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10105 Check for integer overflow on size calculations.
10107 * buffer.c (Fprevious_overlay_change): Remove var that is set
10110 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10111 Remove vars that are set but not used.
10112 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10113 (timer_check_2): Mark vars as initialized.
10115 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10117 * image.c (lookup_image): Remove var that is set but not used.
10118 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10120 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10121 that are set but not used.
10123 * xfns.c (make_invisible_cursor): Don't return garbage
10124 if XCreateBitmapFromData fails (Bug#8410).
10126 * xselect.c (x_get_local_selection, x_handle_property_notify):
10127 Remove vars that are set but not used.
10129 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10130 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10132 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10133 Remove var that is set but not used.
10134 (scroll_bar_windows_size): Now size_t, not int.
10135 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10136 Check for overflow.
10138 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10139 (map_tty_color) [!defined MSDOS]: Likewise.
10141 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10143 * coding.c: Remove vars that are set but not used.
10144 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10145 All callers changed.
10146 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10147 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10148 (decode_coding_charset): Remove vars that are set but not used.
10150 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10151 that is set but not used.
10153 * print.c (print_object): Remove var that is set but not used.
10155 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10156 The gnulib version avoids calling malloc in the usual case,
10157 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10158 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10159 * filelock.c (current_lock_owner): Likewise.
10160 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10161 * sysdep.c: Include allocator.h, careadlinkat.h.
10162 (emacs_no_realloc_allocator): New static constant.
10163 (emacs_readlink): New function.
10164 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10165 ../lib/careadlinkat.h.
10167 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10169 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10170 first non-nil return value).
10172 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10174 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10175 if not defined (Bug#8403).
10177 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10179 * xdisp.c (display_count_lines): Remove parameter `start',
10180 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10181 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10182 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10183 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10184 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10185 and thereabouts. All callers changed.
10186 (get_per_char_metric): Remove parameter `f', unused since
10187 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10189 2011-04-02 Jim Meyering <meyering@redhat.com>
10191 do not dereference NULL upon failed strdup
10192 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10193 (ns_get_family): Likewise.
10195 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10197 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10199 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10201 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10204 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10206 Add lexical binding.
10208 * window.c (Ftemp_output_buffer_show): New fun.
10209 (Fsave_window_excursion):
10210 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10212 * lread.c (lisp_file_lexically_bound_p): New function.
10213 (Fload): Bind Qlexical_binding.
10214 (readevalloop): Remove `evalfun' arg.
10215 Bind Qinternal_interpreter_environment.
10216 (Feval_buffer): Bind Qlexical_binding.
10217 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10219 (syms_of_lread): Declare `lexical-binding'.
10221 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10223 * keyboard.c (eval_dyn): New fun.
10224 (menu_item_eval_property): Use it.
10226 * image.c (parse_image_spec): Use Ffunctionp.
10228 * fns.c (concat, mapcar1): Accept byte-code-functions.
10230 * eval.c (Fsetq): Handle lexical vars.
10231 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10232 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10233 (FletX, Flet): Obey lexical binding.
10234 (Fcommandp): Handle closures.
10235 (Feval): New `lexical' arg.
10236 (eval_sub): New function extracted from Feval. Use it almost
10237 everywhere where Feval was used. Look up vars in lexical env.
10239 (Ffunctionp): Move from subr.el.
10240 (Ffuncall): Handle closures.
10241 (apply_lambda): Remove `eval_flags'.
10242 (funcall_lambda): Handle closures and new byte-code-functions.
10243 (Fspecial_variable_p): New function.
10244 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10245 but without exporting it to Lisp.
10247 * doc.c (Fdocumentation, store_function_docstring):
10248 * data.c (Finteractive_form): Handle closures.
10250 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10253 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10255 (exec_byte_code): New function extracted from Fbyte_code to handle new
10256 calling convention for byte-code-functions. Add new byte-codes.
10258 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10260 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10262 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10264 * xdisp.c (redisplay_internal): Fix prototype.
10266 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10268 * xdisp.c (SCROLL_LIMIT): New macro.
10269 (try_scrolling): Use it when setting scroll_limit.
10270 Limit scrolling to 100 screen lines.
10271 (redisplay_window): Even when falling back on "recentering",
10272 position point in the window according to scroll-conservatively,
10273 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10275 (try_scrolling): When point is above the window, allow searching
10276 as far as scroll_max, or one screenful, to compute vertical
10277 distance from PT to the scroll margin position. This prevents
10278 try_scrolling from unnecessarily failing when
10279 scroll-conservatively is set to a value slightly larger than the
10280 window height. Clean up the case of PT below the margin at bottom
10281 of window: scroll_max can no longer be INT_MAX. When aggressive
10282 scrolling is in use, don't let point enter the opposite scroll
10283 margin as result of the scroll.
10284 (syms_of_xdisp) <scroll-conservatively>: Document the
10285 threshold of 100 lines for never-recentering scrolling.
10287 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10289 * dispextern.h (move_it_by_lines):
10290 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10291 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10292 (message_log_check_duplicate): Remove parameters `prev_bol' and
10293 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10294 (redisplay_internal): Remove parameter `preserve_echo_area',
10295 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10297 * indent.c (Fvertical_motion):
10298 * window.c (window_scroll_pixel_based, Frecenter):
10299 Don't pass `need_y_p' to `move_it_by_lines'.
10301 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10303 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10304 steal a few bits to be more compact.
10305 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10306 Remove unneeded casts.
10308 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10310 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10312 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10313 binding" message (bug#7967).
10315 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10317 Fix more problems found by GCC 4.6.0's static checks.
10319 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10320 Remove unused local var.
10322 * editfns.c (Fmessage_box): Remove unused local var.
10324 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10325 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10326 Omit unused local vars.
10327 * window.c (shrink_windows): Omit unused local var.
10328 * menu.c (digest_single_submenu): Omit unused local var.
10329 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10330 Omit unused local var.
10332 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10333 Don't assume string length fits in int.
10334 (keyremap_step, read_key_sequence): Use size_t for sizes.
10335 (read_key_sequence): Don't check last_real_key_start redundantly.
10337 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10338 instead of alloca (Bug#8344).
10340 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10341 (Fbacktrace_frame): Don't assume nframes fits in int.
10343 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10345 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10348 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10350 * cm.c (calccost): Turn while-do into do-while, for clarity.
10352 * keyboard.c (syms_of_keyboard): Use the same style as later
10353 in this function when indexing through an array. This also
10354 works around GCC bug 48267.
10356 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10358 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10360 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10361 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10363 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10364 This avoids undefined behavior on integer overflow, and is a bit
10365 more convenient anyway since it is compared to a size_t variable.
10367 Variadic C functions now count arguments with size_t, not int.
10368 This avoids an unnecessary limitation on 64-bit machines, which
10369 caused (substring ...) to crash on large vectors (Bug#8344).
10370 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10371 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10372 All variadic functions and their callers changed accordingly.
10373 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10374 * data.c (arith_driver, float_arith_driver): Likewise.
10375 * editfns.c (general_insert_function): Likewise.
10376 * eval.c (struct backtrace.nargs, interactive_p)
10377 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10378 (funcall_lambda, mark_backtrace): Likewise.
10379 * fns.c (concat): Likewise.
10380 * frame.c (x_set_frame_parameters): Likewise.
10381 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10382 0 if not found, not -1. All callers changed.
10384 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10385 (stack_copy_size): Now size_t, not int.
10386 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10388 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10390 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10391 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10392 All callers changed.
10394 * lisp.h (multibyte_char_to_unibyte):
10395 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10396 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10397 * character.h (CHAR_TO_BYTE8):
10398 * cmds.c (internal_self_insert):
10399 * editfns.c (general_insert_function):
10400 * keymap.c (push_key_description):
10401 * search.c (Freplace_match):
10402 * xdisp.c (message_dolog, set_message_1): All callers changed.
10404 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10406 * keyboard.c (safe_run_hook_funcall): New function.
10407 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10408 don't set the hook to nil, but remove the offending function instead.
10409 (Qcommand_hook_internal): Remove, unused.
10410 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10411 Vcommand_hook_internal.
10413 * eval.c (enum run_hooks_condition): Remove.
10414 (funcall_nil, funcall_not): New functions.
10415 (run_hook_with_args): Call each function through a `funcall' argument.
10416 Remove `cond' argument, now redundant.
10417 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10418 (Frun_hook_with_args_until_failure): Adjust accordingly.
10419 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10421 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10423 * dispextern.h (string_buffer_position): Remove declaration.
10425 * print.c (strout): Remove parameter `multibyte', unused since
10426 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10428 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10429 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10430 All callers changed.
10432 * w32.c (_wsa_errlist): Use braces for struct initializers.
10434 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10435 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10436 All callers changed.
10437 (string_buffer_position): Likewise. Also, make static (it's never
10438 used outside xdisp.c).
10439 (cursor_row_p): Remove parameter `w', unused since
10440 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10441 (decode_mode_spec): Remove parameter `precision', introduced during
10442 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10443 All callers changed.
10445 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10447 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10449 2011-03-27 Anders Lindgren <andlind@gmail.com>
10451 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10452 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10453 (ns_update_auto_hide_menu_bar): New functions.
10454 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10455 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10456 ns_constrain_all_frames.
10457 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10458 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10460 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10462 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10464 2011-03-27 Glenn Morris <rgm@gnu.org>
10466 * syssignal.h: Replace RETSIGTYPE with void.
10467 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10468 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10469 Replace SIGTYPE with void everywhere.
10470 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10471 * s/template.h (SIGTYPE): Remove commented out definition.
10473 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10475 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10476 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10478 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10480 * w32.c (read_unc_volume): Use parameter `henum', instead of
10481 global variable `wget_enum_handle'.
10483 * keymap.c (describe_vector): Remove parameters `indices' and
10484 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10485 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10487 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10489 * keyboard.c (timer_check): Remove parameter `do_it_now',
10490 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10491 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10492 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10494 * keyboard.c (read_char):
10495 * w32menu.c (w32_menu_display_help):
10496 * xmenu.c (show_help_event, menu_help_callback):
10497 Adjust calls to `show_help_echo'.
10499 * gtkutil.c (xg_maybe_add_timer):
10500 * keyboard.c (readable_events):
10501 * process.c (wait_reading_process_output):
10502 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10504 * insdel.c (adjust_markers_gap_motion):
10505 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10506 (gap_left, gap_right): Don't call it.
10508 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10510 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10511 incurred during fontification.
10513 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10515 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10516 (DEFVAR_PER_BUFFER): Don't pass it.
10518 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10519 (scrolling_window): Don't pass it.
10521 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10523 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10525 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10527 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10528 of variables specific to SELinux and computation of `encoded_absname'.
10530 * image.c (XPutPixel): Remove unused variable `height'.
10532 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10534 * unexw32.c (get_section_info): Remove unused variable `section'.
10536 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10537 (system_process_attributes): Remove unused variable `sess'.
10538 (sys_read): Remove unused variable `err'.
10540 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10541 (w32_wnd_proc): Remove unused variable `isdead'.
10542 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10543 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10544 (x_create_tip_frame): Remove unused variable `tem'.
10546 * w32inevt.c (w32_console_read_socket):
10547 Remove unused variable `no_events'.
10549 * w32term.c (x_draw_composite_glyph_string_foreground):
10550 Remove unused variable `width'.
10552 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10554 * w32term.c (x_set_glyph_string_clipping):
10555 Don't pass uninitialized region to CombineRgn.
10557 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10559 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10560 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10561 (Fx_close_connection): Remove unused variable `i'.
10563 * w32font.c (w32font_draw): Return number of glyphs.
10564 (w32font_open_internal): Remove unused variable `i'.
10565 (w32font_driver): Add missing initializer.
10567 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10568 (fill_in_menu): Remove unused variable `items_added'.
10570 * w32term.c (last_mouse_press_frame): Remove static global variable.
10571 (w32_clip_to_row): Remove unused variable `f'.
10572 (x_delete_terminal): Remove unused variable `i'.
10574 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10575 (NOTHING): Remove unused static global variable.
10576 (uniscribe_check_otf): Remove unused variable `table'.
10577 (uniscribe_font_driver): Add missing initializers.
10579 2011-03-23 Julien Danjou <julien@danjou.info>
10581 * term.c (Fsuspend_tty, Fresume_tty):
10582 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10583 * window.c (temp_output_buffer_show):
10584 * insdel.c (signal_before_change):
10585 * frame.c (Fhandle_switch_frame):
10586 * fileio.c (Fdo_auto_save):
10587 * emacs.c (Fkill_emacs):
10588 * editfns.c (save_excursion_restore):
10589 * cmds.c (internal_self_insert):
10590 * callint.c (Fcall_interactively):
10591 * buffer.c (Fkill_all_local_variables):
10592 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10594 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10595 unconditionally since it does the check itself.
10597 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10599 Fix more problems found by GCC 4.5.2's static checks.
10601 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10602 the first time through the loop, since we know p0 < p1 then.
10603 This also avoids a gcc -Wstrict-overflow warning.
10605 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10606 leading to a memory leak, possible in functions like
10607 load_charset_map_from_file that can allocate an unbounded number
10608 of objects (Bug#8318).
10610 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10611 that could (at least in theory) be that large.
10613 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10614 This is less likely to overflow, and avoids undefined behavior if
10615 overflow does occur. All callers changed. Use strtoul to scan
10616 for the unsigned long integer.
10617 (pint2hrstr): Simplify and tune code slightly.
10618 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10620 * scroll.c (do_scrolling): Work around GCC bug 48228.
10621 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10623 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10624 This also avoids a warning with gcc -Wstrict-overflow.
10625 (validate_x_resource_name): Simplify count usage.
10626 This also avoids a warning with gcc -Wstrict-overflow.
10628 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10631 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10633 * process.c (Fmake_network_process): Use socklen_t, not int,
10634 where POSIX says socklen_t is required in portable programs.
10635 This fixes a porting bug on hosts like 64-bit HP-UX, where
10636 socklen_t is wider than int (Bug#8277).
10637 (Fmake_network_process, server_accept_connection):
10638 (wait_reading_process_output, read_process_output):
10641 * process.c: Rename or move locals to avoid shadowing.
10642 (list_processes_1, Fmake_network_process):
10643 (read_process_output_error_handler, exec_sentinel_error_handler):
10644 Rename or move locals.
10645 (Fmake_network_process): Define label "retry_connect" only if needed.
10646 (Fnetwork_interface_info): Fix pointer signedness.
10647 (process_send_signal): Add cast to avoid pointer signedness problem.
10648 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10649 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10651 Make tparam.h and terminfo.c consistent.
10652 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10653 Include tparam.h instead, since it declares them.
10654 * cm.h (PC): Remove extern decl; tparam.h now does this.
10655 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10656 * terminfo.c: Include tparam.h, to check interfaces.
10657 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10658 (tparam): Adjust signature to match interface in tparam.h;
10659 this removes some undefined behavior. Check that outstring and len
10660 are zero, which they always are with Emacs.
10661 * tparam.h (PC, BC, UP): New extern decls.
10663 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10664 (xftfont_open): Rename locals to avoid shadowing.
10666 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10667 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10668 (OTF_TAG_SYM): Omit macro if not needed.
10669 (ftfont_list): Remove unused local.
10670 (get_adstyle_property, ftfont_pattern_entity):
10671 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10672 Rename locals to avoid shadowing.
10674 * xfont.c (xfont_list_family): Mark var as initialized.
10676 * xml.c (make_dom): Now static.
10678 * composite.c (composition_compute_stop_pos): Rename local to
10680 (composition_reseat_it): Remove unused locals.
10681 (find_automatic_composition, composition_adjust_point): Likewise.
10682 (composition_update_it): Mark var as initialized.
10683 (find_automatic_composition): Mark vars as initialized,
10684 with a FIXME (Bug#8290).
10686 character.h: Rename locals to avoid shadowing.
10687 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10688 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10689 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10690 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10691 to avoid shadowing.
10693 * textprop.c (property_change_between_p): Remove; unused.
10695 * intervals.c (interval_start_pos): Now static.
10697 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10699 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10700 Rename locals to avoid shadowing.
10702 * sound.c (wav_play, au_play, Fplay_sound_internal):
10703 Fix pointer signedness.
10704 (alsa_choose_format): Remove unused local var.
10705 (wav_play): Initialize a variable to 0, to prevent undefined
10706 behavior (Bug#8278).
10708 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10710 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10712 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10713 clobbering (Bug#8298).
10714 * sysdep.c (sys_subshell): Likewise.
10715 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10717 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10718 This should get cleaned up, so that child_setup has the
10719 same signature on all platforms.
10721 * callproc.c (call_process_cleanup): Now static.
10722 (relocate_fd): Rename locals to avoid shadowing.
10724 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10726 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10727 not to be necessary, and produces flickering.
10729 2011-03-20 Glenn Morris <rgm@gnu.org>
10731 * config.in: Remove file.
10733 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10735 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10736 are now in src/globals.h.
10737 (syms_of_minibuf): Remove spurious & from previous change.
10739 2011-03-20 Leo Liu <sdl.web@gmail.com>
10741 * minibuf.c (completing-read-function): New variable.
10742 (completing-read-default): Rename from completing-read.
10743 (completing-read): Call completing-read-function.
10745 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10747 * xfaces.c (Fx_load_color_file):
10748 Read color file from absolute filename (bug#8250).
10750 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10752 * makefile.w32-in: Update dependencies.
10754 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10756 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10758 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10760 Fix more problems found by GCC 4.5.2's static checks.
10762 * process.c (make_serial_process_unwind, send_process_trap):
10763 (sigchld_handler): Now static.
10765 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10766 That way, the code declares only the vars that it needs.
10767 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10768 * s/cygwin.h (PTY_ITERATION): Likewise.
10769 * s/darwin.h (PTY_ITERATION): Likewise.
10770 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10772 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10773 * process.c (allocate_pty): Don't declare stb unless it's needed.
10775 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10776 (CONSTANTLIM): Remove; unused.
10777 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10778 Define only if needed.
10780 * unexelf.c (unexec): Name an expression,
10781 to avoid gcc -Wbad-function-cast warning.
10782 Use a different way to cause a compilation error if anyone uses
10783 n rather than nn, a way that does not involve shadowing.
10784 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10786 * deps.mk (unexalpha.o): Remove; unused.
10788 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10789 * unexec.h: New file.
10790 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10791 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10792 Depend on unexec.h.
10793 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10794 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10795 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10796 Change as necessary to match prototype in unexec.h.
10798 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10800 (back_comment, skip_chars): Mark vars as initialized.
10802 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10803 Rename locals to avoid shadowing.
10805 * lread.c (read1): Rewrite so as not to use empty "else".
10806 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10808 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10810 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10811 warning when compiling print.c.
10813 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10814 instead of using an uninitialized var.
10815 (font_sort_entities): Mark var as initialized.
10817 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10819 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10820 pointers to constants.
10821 (font_parse_fcname): Remove unused vars.
10822 (font_delete_unmatched): Now static.
10823 (font_get_spec): Remove; unused.
10824 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10825 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10826 Rename or move locals to avoid shadowing.
10828 * fns.c (require_nesting_list, require_unwind): Now static.
10829 (Ffillarray): Rename locals to avoid shadowing.
10831 * floatfns.c (domain_error2): Define only if needed.
10832 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10834 * alloc.c (mark_backtrace): Move decl from here ...
10835 * lisp.h: ... to here, so that it can be checked.
10837 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10838 (Fdefvar): Rewrite so as not to use empty "else".
10839 (lisp_indirect_variable): Name an expression,
10840 to avoid gcc -Wbad-function-cast warning.
10841 (Fdefvar): Rename locals to avoid shadowing.
10843 * callint.c (quotify_arg, quotify_args): Now static.
10844 (Fcall_interactively): Rename locals to avoid shadowing.
10845 Use const pointer when appropriate.
10847 * lisp.h (get_system_name, get_operating_system_release):
10848 Move decls here, to check interfaces.
10849 * process.c (get_operating_system_release): Move decl to lisp.h.
10850 * xrdb.c (get_system_name): Likewise.
10851 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10852 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10853 some of which prompt warnings from gcc -Wbad-function-cast.
10854 (Fformat_time_string, Fencode_time, Finsert_char):
10855 (Ftranslate_region_internal, Fformat):
10856 Rename or remove local vars to avoid shadowing.
10857 (Ftranslate_region_internal): Mark var as initialized.
10859 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10862 * lisp.h (eassert): Check that the argument compiles, even if
10863 ENABLE_CHECKING is not defined.
10865 * data.c (Findirect_variable): Name an expression, to avoid
10866 gcc -Wbad-function-cast warning.
10867 (default_value, arithcompare, arith_driver, arith_error): Now static.
10868 (store_symval_forwarding): Rename local to avoid shadowing.
10869 (Fmake_variable_buffer_local, Fmake_local_variable):
10870 Mark variables as initialized.
10871 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10873 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10874 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10875 Rename locals to avoid shadowing.
10876 (mark_stack): Move local variables into the #ifdef region where
10878 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10879 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10881 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10882 (GC_STRING_CHARS): Remove; not used.
10883 (Fmemory_limit): Cast sbrk's returned value to char *.
10885 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10886 avoids undefined behavior in theory.
10888 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10890 Use functions, not macros, for up- and down-casing (Bug#8254).
10891 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10892 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10893 to use the following functions instead of these macros.
10894 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10895 EMACS_INT, since callers assume the returned value fits in int.
10896 (upcase1): Likewise, for UPCASE_TABLE.
10897 (uppercasep, lowercasep, upcase): New static inline functions.
10898 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10899 the race-condition problem in the old DOWNCASE.
10901 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10902 Rename locals to avoid shadowing.
10903 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10904 (regex_compile, re_search_2, re_match_2_internal):
10905 Remove unused local vars.
10906 (FREE_VAR): Rewrite so as not to use empty "else",
10907 which gcc can warn about.
10908 (regex_compile, re_match_2_internal): Mark locals as initialized.
10909 (RETALLOC_IF): Define only if needed.
10910 (WORDCHAR_P): Likewise. This one is never needed, but is used
10911 only in a comment talking about a compiler bug, so put inside
10912 the #if 0 of that comment.
10913 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10914 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10917 * search.c (boyer_moore): Rename locals to avoid shadowing.
10918 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10919 (PREV_CHAR_BOUNDARY): Likewise.
10921 * search.c (simple_search): Remove unused var.
10923 * dired.c (compile_pattern): Move decl from here ...
10924 * lisp.h: ... to here, so that it can be checked.
10925 (struct re_registers): New forward decl.
10927 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10929 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10931 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10932 Rename locals to avoid shadowing.
10933 (Fvertical_motion): Mark locals as initialized.
10935 * casefiddle.c (casify_object, casify_region): Now static.
10936 (casify_region): Mark local as initialized.
10938 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10940 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10941 New macros, so that the caller can use some names other than
10942 gcpro1, gcpro2, etc.
10943 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10945 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10946 argument, for consistency with GCPRO2_VAR, etc: it is now the
10947 prefix of the variable, not the variable itself. All uses
10949 * dired.c (directory_files_internal, file_name_completion):
10950 Rename locals to avoid shadowing.
10952 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10953 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10954 dired.c's scmp function, had undefined behavior.
10955 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10956 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10957 * buffer.h: ... to here, because these macros use current_buffer,
10958 and the new implementation with inline functions needs to have
10959 current_buffer in scope now, rather than later when the macros
10961 (downcase, upcase1): New static inline functions.
10962 (DOWNCASE, UPCASE1): Reimplement using these functions.
10963 This avoids undefined behavior in expressions like
10964 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10965 from race conditions in accessing the global variables
10966 case_temp1 and case_temp2.
10967 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10968 * lisp.h (case_temp1, case_temp2): Remove their decls.
10969 * character.h (ASCII_CHAR_P): Move from here ...
10970 * lisp.h: ... to here, so that the inline functions mentioned
10971 above can use them.
10973 * dired.c (directory_files_internal_unwind): Now static.
10975 * fileio.c (file_name_as_directory, directory_file_name):
10976 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10978 (file_name_as_directory): Use const pointers when appropriate.
10979 (Fexpand_file_name): Likewise. In particular, newdir might
10980 point at constant storage, so make it a const pointer.
10981 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10982 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10984 (Fset_file_times, Finsert_file_contents, auto_save_error):
10985 Rename locals to avoid shadowing.
10987 * minibuf.c (choose_minibuf_frame_1): Now static.
10988 (Ftry_completion, Fall_completions): Rename or remove locals
10989 to avoid shadowing.
10991 * marker.c (bytepos_to_charpos): Remove; unused.
10993 * lisp.h (verify_bytepos, count_markers): New decls,
10994 so that gcc does not warn that these functions aren't declared.
10996 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10997 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10998 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10999 (copy_text): Remove unused local var.
11001 * filelock.c (within_one_second): Now static.
11002 (lock_file_1): Rename local to avoid shadowing.
11004 * buffer.c (fix_overlays_before): Mark locals as initialized.
11005 (fix_start_end_in_overlays): Likewise. This function should be
11006 simplified by using pointers-to-pointers, but that's a different
11008 (switch_to_buffer_1): Now static.
11009 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11010 (report_overlay_modification): Rename locals to avoid shadowing.
11012 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11013 Fix pointer signedness issue.
11014 (sys_subshell): Mark local as volatile if checking for lint,
11015 to suppress a gcc -Wclobbered warning that does not seem to be right.
11016 (MAXPATHLEN): Define only if needed.
11018 * process.c (serial_open, serial_configure): Move decls from here ...
11019 * systty.h: ... to here, so that they can be checked.
11021 * fns.c (get_random, seed_random): Move extern decls from here ...
11022 * lisp.h: ... to here, so that they can be checked.
11024 * sysdep.c (reset_io): Now static.
11025 (wait_for_termination_signal): Remove; unused.
11027 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11028 (copy_keymap_item, append_key, push_text_char_description):
11030 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11031 (DENSE_TABLE_SIZE): Remove; unused.
11032 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11033 (describe_map_tree):
11034 Rename locals to avoid shadowing.
11036 * keyboard.c: Declare functions static if they are not used elsewhere.
11037 (echo_char, echo_dash, cmd_error, top_level_2):
11038 (poll_for_input, handle_async_input): Now static.
11039 (read_char, kbd_buffer_get_event, make_lispy_position):
11040 (make_lispy_event, make_lispy_movement, apply_modifiers):
11041 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11042 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11043 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11044 (read_key_sequence, read_char): Mark locals as initialized.
11045 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11047 * keyboard.h (make_ctrl_char): New decl.
11048 (mark_kboards): Move decl here ...
11049 * alloc.c (mark_kboards): ... from here.
11051 * lisp.h (force_auto_save_soon): New decl.
11053 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11054 (DEFINE_DUMMY_FUNCTION): New macro.
11055 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11057 (main): Add casts to avoid warnings
11058 if GCC considers string literals to be constants.
11060 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11062 * dbusbind.c: Pointer signedness fixes.
11063 (xd_signature, xd_append_arg, xd_initialize):
11064 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11065 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11066 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11067 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11069 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11070 if GCC considers string literals to be constants.
11071 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11073 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11075 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11076 (print_preprocess, print_object): New macro to fix last change.
11078 * print.c (print_preprocess): Don't forget font objects.
11080 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11082 * emacs.c (USAGE3): Doc fixes.
11084 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11086 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11089 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11091 * lisp.h (VWindow_system, Qfile_name_history):
11092 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11093 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11094 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11096 * w32select.c: Don't #include "keyboard.h".
11097 (run_protected): Add extern declaration for waiting_for_input.
11099 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11100 * w32console.c (detect_input_pending, read_input_pending)
11101 (encode_terminal_code):
11102 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11103 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11104 (w32_system_caret_y, Qfile_name_history):
11105 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11106 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11107 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11108 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11109 * w32proc.c (Qlocal, report_file_error):
11110 * w32term.c (Vwindow_system, updating_frame):
11111 * w32uniscribe.c (initialized, uniscribe_font_driver):
11112 Remove unneeded extern declarations.
11114 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11116 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11118 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11120 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11121 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11122 These macros can no longer be used for assignment.
11124 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11125 Assign struct members directly, instead of using BUF_BEGV etc.
11126 (record_buffer_markers, fetch_buffer_markers): New functions for
11127 recording and fetching special buffer markers.
11128 (set_buffer_internal_1, set_buffer_temp): Use them.
11130 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11132 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11134 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11135 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11137 * xdisp.c (hscroll_window_tree):
11138 (reconsider_clip_changes): Use PT instead of BUF_PT.
11140 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11142 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11143 $(EMACS_ROOT)/lib/intprops.h.
11145 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11147 Fix more problems found by GCC 4.5.2's static checks.
11149 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11150 to unsigned char * to avoid compiler diagnostic.
11151 (xg_free_frame_widgets): Make it clear that a local variable is
11152 needed only if USE_GTK_TOOLTIP.
11153 (gdk_window_get_screen): Make it clear that this macro is needed
11154 only if USE_GTK_TOOLTIP.
11155 (int_gtk_range_get_value): New function, which avoids a diagnostic
11156 from gcc -Wbad-function-cast.
11157 (xg_set_toolkit_scroll_bar_thumb): Use it.
11158 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11159 diagnostic from gcc -Wbad-function-cast.
11160 (get_utf8_string, xg_get_file_with_chooser):
11161 Rename locals to avoid shadowing.
11162 (create_dialog): Move locals to avoid shadowing.
11164 * xgselect.c (xg_select): Remove unused var.
11166 * image.c (four_corners_best): Mark locals as initialized.
11167 (gif_load): Initialize transparent_p to zero (Bug#8238).
11168 Mark another local as initialized.
11169 (my_png_error, my_error_exit): Mark with NO_RETURN.
11171 * image.c (clear_image_cache): Now static.
11172 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11173 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11174 (x_edge_detection): Remove unnecessary cast that
11175 gcc -Wbad-function-cast diagnoses.
11176 (gif_load): Fix pointer signedness.
11177 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11178 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11180 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11182 Improve quality of tests for time stamp overflow.
11183 For example, without this patch (encode-time 0 0 0 1 1
11184 1152921504606846976) returns the obviously-bogus value (-948597
11185 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11186 reports time overflow. See
11187 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11188 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11189 * editfns.c: Include limits.h and intprops.h.
11190 (TIME_T_MIN, TIME_T_MAX): New macros.
11191 (time_overflow): Move earlier, to before first use.
11192 (hi_time, lo_time): New functions, for an accurate test for
11193 out-of-range times.
11194 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11195 (Fget_internal_run_time): Don't assume time_t fits in int.
11196 (make_time): Use list2 instead of Fcons twice.
11197 (Fdecode_time): More accurate test for out-of-range times.
11198 (check_tm_member): New function.
11199 (Fencode_time): Use it, to test for out-of-range times.
11200 (lisp_time_argument): Don't rely on undefined left-shift and
11201 right-shift behavior when checking for time stamp overflow.
11203 * editfns.c (time_overflow): New function, refactoring common code.
11204 (Fformat_time_string, Fdecode_time, Fencode_time):
11205 (Fcurrent_time_string): Use it.
11207 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11208 * dired.c (make_time): Move to ...
11209 * editfns.c (make_time): ... here.
11210 * systime.h: Note the move.
11212 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11214 * fringe.c (update_window_fringes): Remove unused variables.
11216 * unexmacosx.c (copy_data_segment): Also copy __got section.
11219 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11221 * termcap.c [MSDOS]: Include "msdos.h".
11222 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11223 Constify `char *' arguments and their references according to
11224 prototypes in tparam.h.
11226 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11228 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11229 Adapt all references accordingly.
11231 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11233 2011-03-11 Tom Tromey <tromey@redhat.com>
11235 * buffer.c (syms_of_buffer): Remove obsolete comment.
11237 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11239 * termhooks.h (encode_terminal_code): Declare prototype.
11241 * msdos.c (encode_terminal_code): Don't declare prototype.
11243 * term.c (encode_terminal_code): Now external again, used by
11244 w32console.c and msdos.c.
11246 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11247 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11249 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11251 Fix some minor problems found by GCC 4.5.2's static checks.
11253 * fringe.c (update_window_fringes): Mark locals as initialized
11255 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11257 * alloc.c (mark_fringe_data): Move decl from here ...
11258 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11259 to check its interface.
11260 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11262 * fontset.c (free_realized_fontset): Now static.
11263 (Fset_fontset_font): Rename local to avoid shadowing.
11264 (fontset_font): Mark local as initialized.
11265 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11267 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11269 * xselect.c (x_disown_buffer_selections): Remove; not used.
11270 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11271 (x_own_selection, Fx_disown_selection_internal): Rename locals
11272 to avoid shadowing.
11273 (x_handle_dnd_message): Remove local to avoid shadowing.
11275 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11276 so that the caller can use some name other than gcpro1.
11277 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11278 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11279 (Fx_backspace_delete_keys_p):
11280 Use them to avoid shadowing, and rename vars to avoid shadowing.
11281 (x_decode_color, x_set_name, x_window): Now static.
11282 (Fx_create_frame): Add braces to silence GCC warning.
11283 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11284 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11285 Remove unused locals.
11286 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11287 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11288 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11291 * xterm.h (x_mouse_leave): New decl.
11293 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11294 Remove unused functions.
11295 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11296 (x_calc_absolute_position): Now static.
11297 (XTread_socket): Don't define label "out" unless it's used.
11298 Don't declare local "event" unless it's used.
11299 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11300 unless they are used.
11301 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11302 (x_fatal_error_signal): Remove; not used.
11303 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11304 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11305 (x_error_catcher, x_connection_closed, x_error_handler):
11306 (x_error_quitter, xembed_send_message, x_iconify_frame):
11307 (my_log_handler): Rename locals to avoid shadowing.
11308 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11309 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11311 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11312 Rename or move locals to avoid shadowing.
11313 (tty_defined_color, merge_face_heights): Now static.
11314 (free_realized_faces_for_fontset): Remove; not used.
11315 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11316 does not deduce is never used uninitialized.
11317 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11318 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11320 * terminal.c (store_terminal_param): Now static.
11322 * xmenu.c (menu_highlight_callback): Now static.
11323 (set_frame_menubar): Remove unused local.
11324 (xmenu_show): Rename parameter to avoid shadowing.
11325 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11326 since they might point to immutable storage.
11327 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11328 since it's unused otherwise.
11330 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11331 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11332 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11333 avoids a gcc -Wuninitialized diagnostic.
11334 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11335 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11336 does not deduce are never used uninitialized.
11338 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11340 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11341 * window.c (window_loop, size_window):
11342 (run_window_configuration_change_hook, enlarge_window): Likewise.
11344 * window.c (display_buffer): Now static.
11345 (size_window): Mark variables that gcc -Wuninitialized
11346 does not deduce are never used uninitialized.
11347 * window.h (check_all_windows): New decl, to forestall
11348 gcc -Wmissing-prototypes diagnostic.
11349 * dispextern.h (bidi_dump_cached_states): Likewise.
11351 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11353 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11354 Include <limits.h>.
11355 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11356 and to avoid gcc -Wuninitialized warning.
11357 (load_charset_map): Mark variables that gcc -Wuninitialized
11358 does not deduce are never used uninitialized.
11359 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11361 * coding.c (coding_set_source, coding_set_destination):
11362 Use "else { /* comment */ }" rather than "else /* comment */;"
11363 for clarity, and to avoid gcc -Wempty-body warning.
11364 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11365 a block, when the outer 'i' will do.
11366 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11367 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11368 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11369 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11370 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11371 Rename locals to avoid shadowing.
11372 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11373 * coding.c (emacs_mule_char, encode_invocation_designation):
11374 Now static, since they're not used elsewhere.
11375 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11376 (decode_coding_object, encode_coding_object, detect_coding_system):
11377 (decode_coding_emacs_mule): Mark variables that gcc
11378 -Wuninitialized does not deduce are never used uninitialized.
11379 (detect_coding_iso_2022): Initialize a local variable that might
11380 be used uninitialized. Leave a FIXME because it's not clear that
11381 this initialization is needed. (Bug#8211)
11382 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11383 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11384 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11385 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11386 Remove unused macros.
11388 * category.c (hash_get_category_set): Remove unused local var.
11389 (copy_category_table): Now static, since it's not used elsewhere.
11390 * character.c (string_count_byte8): Likewise.
11392 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11393 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11395 * chartab.c (copy_sub_char_table): Now static, since it's not used
11397 (sub_char_table_ref_and_range, char_table_ref_and_range):
11398 Rename locals to avoid shadowing.
11399 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11401 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11402 (BIDI_BOB): Remove unused macro.
11404 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11405 deduce are never used uninitialized.
11406 * term.c (encode_terminal_code): Likewise.
11408 * term.c (encode_terminal_code): Now static. Remove unused local.
11410 * tparam.h: New file.
11411 * term.c, tparam.h: Include it.
11412 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11413 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11414 Move these decls to tparam.h, and make them agree with what
11415 is actually in tparam.c. The previous trick of using incompatible
11416 decls in different modules does not conform to the C standard.
11417 All callers of tparam changed to use tparam's actual API.
11418 * tparam.c (tparam1, tparam, tgoto):
11419 Use const pointers where appropriate.
11421 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11422 * cm.h (struct cm): Likewise.
11423 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11424 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11425 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11426 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11427 (turn_on_face, init_tty): Likewise.
11428 * termchar.h (struct tty_display_info): Likewise.
11430 * term.c (term_mouse_position): Rename local to avoid shadowing.
11432 * alloc.c (mark_ttys): Move decl from here ...
11433 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11435 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11437 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11439 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11441 * search.c (compile_pattern_1): Remove argument regp, unused since
11442 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11443 (compile_pattern): Don't pass it.
11445 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11447 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11448 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11450 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11452 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11454 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11455 gdk_window_get_screen, gdk_window_get_geometry,
11456 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11457 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11458 (xg_get_pixbuf_from_pixmap): New function.
11459 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11460 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11461 Call xg_get_pixbuf_from_pixmap instead of
11462 gdk_pixbuf_get_from_drawable.
11463 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11464 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11465 (xg_check_special_colors): Use GtkStyleContext and its functions
11467 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11468 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11469 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11470 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11471 Call gtk_widget_get_preferred_size.
11472 (xg_frame_resized): gdk_window_get_geometry only takes 5
11474 (xg_win_to_widget, xg_event_is_for_menubar):
11475 Call gdk_x11_window_lookup_for_display.
11476 (xg_set_widget_bg): New function.
11477 (delete_cb): New function.
11478 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11479 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11480 (xg_set_background_color): Call xg_set_widget_bg.
11481 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11482 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11483 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11484 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11486 (update_frame_tool_bar): Call gtk_widget_hide.
11487 (xg_initialize): Use GDK_KEY_g.
11489 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11491 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11493 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11494 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11495 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11497 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11499 * w32xfns.c (select_palette): Check success of RealizePalette against
11500 GDI_ERROR, not zero.
11502 See ChangeLog.11 for earlier changes.
11504 ;; Local Variables:
11508 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11510 This file is part of GNU Emacs.
11512 GNU Emacs is free software: you can redistribute it and/or modify
11513 it under the terms of the GNU General Public License as published by
11514 the Free Software Foundation, either version 3 of the License, or
11515 (at your option) any later version.
11517 GNU Emacs is distributed in the hope that it will be useful,
11518 but WITHOUT ANY WARRANTY; without even the implied warranty of
11519 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11520 GNU General Public License for more details.
11522 You should have received a copy of the GNU General Public License
11523 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.