1 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3 lisp.h: Fix a problem with aliasing and vector headers.
4 GCC 4.6.0 optimizes based on type-based alias analysis. For
5 example, if b is of type struct buffer * and v of type struct
6 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7 != &v->size, and therefore "v->size = 1; b->size = 2; return
8 v->size;" must therefore return 1. This assumption is incorrect
9 for Emacs, since it type-puns struct Lisp_Vector * with many other
10 types. To fix this problem, this patch adds a new type struct
11 vectorlike_header that documents the constraints on layout of vectors
12 and pseudovectors, and helps optimizing compilers not get fooled
13 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
14 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
15 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
17 (XSETPVECTYPE): Rewrite in terms of new macro.
18 (XSETPVECTYPESIZE): New macro, specifying both type and size.
19 This is a bit clearer, and further avoids the possibility of
21 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
22 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
23 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
24 since Lisp_Subr is a special case (no "next" field).
25 (ASIZE): Now uses header.size rather than size. All
26 previous uses of XVECTOR (foo)->size replaced to use this macro,
27 to avoid the hassle of writing XVECTOR (foo)->header.size.
28 (struct vectorlike_header): New type.
29 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
30 object, to help avoid aliasing.
31 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
32 (SUBRP): Likewise, since Lisp_Subr is a special case.
33 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
34 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
35 (struct Lisp_Hash_Table): Combine first two members into a single
36 struct vectorlike_header member. All uses of "size" and "next" members
37 changed to be "header.size" and "header.next".
38 * buffer.h (struct buffer): Likewise.
39 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
40 * frame.h (struct frame): Likewise.
41 * process.h (struct Lisp_Process): Likewise.
42 * termhooks.h (struct terminal): Likewise.
43 * window.c (struct save_window_data, struct saved_window): Likewise.
44 * window.h (struct window): Likewise.
45 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
46 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
47 * buffer.c (init_buffer_once): Likewise.
48 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
50 * process.c (Fformat_network_address): Use local var for size,
53 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
55 Make the Lisp reader and string-to-float more consistent.
56 * data.c (atof): Remove decl; no longer used or needed.
57 (digit_to_number): Move to lread.c.
58 (Fstring_to_number): Use new string_to_number function, to be
59 consistent with how the Lisp reader treats infinities and NaNs.
60 Do not assume that floating-point numbers represent EMACS_INT
61 without losing information; this is not true on most 64-bit hosts.
62 Avoid double-rounding errors, by insisting on integers when
63 parsing non-base-10 numbers, as the documentation specifies.
64 * lisp.h (string_to_number): New decl, replacing ...
65 (isfloat_string): Remove.
66 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
67 (read1): Do not accept +. and -. as integers; this
68 appears to have been a coding error. Similarly, do not accept
69 strings like +-1e0 as floating point numbers. Do not report
70 overflow for integer overflows unless the base is not 10 which
71 means we have no simple and reliable way to continue.
72 Break out the floating-point parsing into a new
73 function string_to_number, so that Fstring_to_number parses
74 floating point numbers consistently with the Lisp reader.
75 (digit_to_number): Moved here from data.c. Make it static inline.
76 (E_CHAR, EXP_INT): Remove, replacing with ...
77 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
78 (string_to_number): New function, replacing isfloat_string.
79 This function checks for valid syntax and produces the resulting
80 Lisp float number too. Rework it so that string-to-number
81 no longer mishandles examples like "1.0e+". Use strtoumax,
82 so that overflow for non-base-10 numbers is reported only when
83 there's no portable and simple way to convert to floating point.
85 * textprop.c (set_text_properties_1): Rewrite for clarity,
86 and to avoid GCC warning about integer overflow.
88 * intervals.h (struct interval): Use EMACS_INT for members
89 where EMACS_UINT might cause problems. See
90 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
91 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
92 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
94 (offset_intervals): Tell GCC not to worry about length overflow
95 when negating a negative length.
97 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
98 (overrun_check_free): Likewise.
100 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
101 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
104 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
105 (gnutls_make_error): Rename local to avoid shadowing.
106 (gnutls_emacs_global_deinit): ifdef out; not used.
107 (Fgnutls_boot): Use const for pointer to readonly storage.
108 Comment out unused local. Fix pointer signedness problems.
110 * lread.c (openp): Don't stuff size_t into an 'int'.
111 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
112 about possible signed overflow.
114 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
115 (GDK_KEY_g): Don't define if already defined.
116 (xg_prepare_tooltip): Avoid pointer signedness problem.
117 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
119 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
120 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
122 * xfns.c (Fx_window_property): Simplify a bit,
123 to make a bit faster and to avoid GCC 4.6.0 warning.
124 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
126 * fns.c (internal_equal): Don't assume size_t fits in int.
128 * alloc.c (compact_small_strings): Tighten assertion a little.
130 Replace pEd with more-general pI, and fix some printf arg casts.
131 * lisp.h (pI): New macro, generalizing old pEd macro to other
132 conversion specifiers. For example, use "...%"pI"d..." rather
134 (pEd): Remove. All uses replaced with similar uses of pI.
135 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
136 * alloc.c (check_pure_size): Don't overflow by converting size to int.
137 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
138 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
139 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
140 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
141 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
143 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
144 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
145 * print.c (safe_debug_print, print_object): Likewise.
146 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
148 Use pI instead of if-then-else-abort. Use %p to avoid casts,
149 avoiding the 0 flag, which is not portable.
150 * process.c (Fmake_network_process): Use pI to avoid cast.
151 * region-cache.c (pp_cache): Likewise.
152 * xdisp.c (decode_mode_spec): Likewise.
153 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
154 behavior on 64-bit hosts with printf arg.
155 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
156 (x_stop_queuing_selection_requests): Likewise.
157 (x_get_window_property): Don't truncate byte count to an 'int'
160 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
161 here, since it parses constructs like leading '-' and spaces,
162 which are not wanted; and it overflows with large numbers.
163 Instead, simply match F[0-9]+, which is what is wanted anyway.
165 * alloc.c: Remove unportable assumptions about struct layout.
166 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
167 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
168 (allocate_vectorlike, make_pure_vector): Use the new macros,
169 plus offsetof, to remove unportable assumptions about struct layout.
170 These assumptions hold on all porting targets that I know of, but
171 they are not guaranteed, they're easy to remove, and removing them
172 makes further changes easier.
174 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
175 This doesn't fix a bug but makes the code clearer.
176 (string_overrun_cookie): Now const. Use initializers that
177 don't formally overflow signed char, to avoid warnings.
178 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
179 can cause Emacs to crash when string overrun checking is enabled.
180 (allocate_buffer): Don't assume sizeof (struct buffer) is a
181 multiple of sizeof (EMACS_INT); it need not be, if
182 alignof(EMACS_INT) < sizeof (EMACS_INT).
183 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
185 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
187 * alloc.c (check_sblock, check_string_bytes)
188 (check_string_free_list): Convert to standard C.
190 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
192 * w32.c (emacs_gnutls_push): Fix typo.
194 2011-04-25 Eli Zaretskii <eliz@gnu.org>
196 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
197 "cast to pointer from integer of different size".
199 Improve doprnt and its use in verror. (Bug#8545)
200 * doprnt.c (doprnt): Document the set of format control sequences
201 supported by the function. Use SAFE_ALLOCA instead of always
204 * eval.c (verror): Don't limit the buffer size at size_max-1, that
205 is one byte too soon. Don't use xrealloc; instead xfree and
208 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
210 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
213 * gnutls.c: Renamed global_initialized to
214 gnutls_global_initialized. Added internals for the
215 :verify-hostname-error, :verify-error, and :verify-flags
216 parameters of `gnutls-boot' and documented those parameters in the
217 docstring. Start callback support.
218 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
219 unless a fatal error occured. Call gnutls_alert_send_appropriate
220 on error. Return error code.
221 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
222 (emacs_gnutls_read): Likewise.
223 (Fgnutls_boot): Return handshake error code.
224 (emacs_gnutls_handle_error): New function.
225 (wsaerror_to_errno): Likewise.
227 * w32.h (emacs_gnutls_pull): Add prototype.
228 (emacs_gnutls_push): Likewise.
230 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
231 (emacs_gnutls_push): Likewise.
233 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
235 * process.c (wait_reading_process_output): Check if GnuTLS
236 buffered some data internally if no FDs are set for TLS
239 * makefile.w32-in (OBJ2): Add gnutls.$(O).
240 (LIBS): Link to USER_LIBS.
241 ($(BLD)/gnutls.$(0)): New target.
243 2011-04-24 Eli Zaretskii <eliz@gnu.org>
245 * xdisp.c (handle_single_display_spec): Rename the
246 display_replaced_before_p argument into display_replaced_p, to
247 make it consistent with the commentary. Fix typos in the
250 * textprop.c (syms_of_textprop): Remove dead code.
251 (copy_text_properties): Delete obsolete commentary about an
252 interface that was deleted long ago. Fix typos in the description
255 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
256 to changes in oldXMenu/XMenu.h from 2011-04-16.
257 <menu_help_message, prev_menu_help_message>: Constify.
258 (IT_menu_make_room): menu->help_text is now `const char **';
261 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
262 to changes in oldXMenu/XMenu.h from 2011-04-16.
263 (struct XMenu): Declare `help_text' `const char **'.
265 * xfaces.c <Qunspecified>: Make extern again.
267 * syntax.c: Include sys/types.h before including regex.h, as
270 * doc.c (get_doc_string): Improve the format passed to `error'.
272 * doprnt.c (doprnt): Improve commentary.
274 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
276 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
279 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
280 changes in globals.h immediately force recompilation.
281 (TAGS): Depend on $(CURDIR)/m/intel386.h and
282 $(CURDIR)/s/ms-w32.h.
283 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
285 * character.c (Fchar_direction): Function deleted.
286 (syms_of_character): Don't defsubr it.
287 <char-direction-table>: Deleted.
289 2011-04-23 Eli Zaretskii <eliz@gnu.org>
291 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
292 * doprnt.c: Include limits.h.
293 (SIZE_MAX): New macro.
294 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
295 local variables are now size_t instead of int or unsigned.
296 Improve overflow protection. Support `l' modifier for integer
297 conversions. Support %l conversion. Don't assume an EMACS_INT
298 argument for integer conversions and for %c.
300 * lisp.h (doprnt): Restore prototype.
302 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
305 * Makefile.in (base_obj): Add back doprnt.o.
307 * deps.mk (doprnt.o): Add back prerequisites.
308 (callint.o): Depend on character.h.
310 * eval.c (internal_lisp_condition_case): Include the handler
311 representation in the error message.
312 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
313 when breaking from the loop.
315 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
317 * callint.c (Fcall_interactively): When displaying error message
318 about invalid control letter, pass the character's codepoint, not
319 a pointer to its multibyte form. Improve display of the character
320 in octal and display also its hex code.
322 * character.c (char_string): Use %x to display the (unsigned)
323 codepoint of an invalid character, to avoid displaying a bogus
326 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
327 `error', not SYMBOL_NAME itself.
329 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
330 character arguments to `error'.
332 * charset.c (check_iso_charset_parameter): Fix incorrect argument
333 to `error' in error message about FINAL_CHAR argument. Make sure
334 FINAL_CHAR is a character, and use %c when it is passed as
337 2011-04-23 Eli Zaretskii <eliz@gnu.org>
339 * s/ms-w32.h (localtime): Redirect to sys_localtime.
341 * w32.c: Include <time.h>.
342 (sys_localtime): New function.
344 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
346 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
348 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
350 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
352 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
355 2011-04-19 Eli Zaretskii <eliz@gnu.org>
357 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
358 gl_state.e_property when gl_state.object is Qt.
360 * insdel.c (make_gap_larger): Remove limitation of buffer size
363 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
365 * xdisp.c (lookup_glyphless_char_display)
366 (produce_glyphless_glyph): Handle cons cell entry in
367 glyphless-char-display.
368 (Vglyphless_char_display): Document it.
370 * term.c (produce_glyphless_glyph): Handle cons cell entry in
371 glyphless-char-display.
373 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
375 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
377 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
379 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
380 definition for no-X builds.
382 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
384 Static checks with GCC 4.6.0 and non-default toolkits.
386 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
388 * process.c (keyboard_bit_set): Define only if SIGIO.
389 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
390 (send_process): Repair possible setjmp clobbering.
392 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
394 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
396 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
398 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
399 Define only if needed.
401 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
402 by pacifying GCC about it. Maybe it's time to retire it?
403 * xfaces.c (USG, __TIMEVAL__): Likewise.
405 * dispextern.h (struct redisplay_interface): Rename param
407 * termhooks.h (struct terminal): Likewise.
408 * xterm.c (xembed_send_message): Likewise.
410 * insdel.c (make_gap_smaller): Define only if
411 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
413 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
416 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
417 so that we aren't warned about unused symbols.
419 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
421 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
423 * xfns.c (x_real_positions): Mark locals as initialized.
425 * xmenu.c (xmenu_show): Don't use uninitialized vars.
427 * xterm.c: Fix problems found by static analysis with other toolkits.
428 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
429 (x_dispatch_event): Declare static if USE_GTK, and
430 define if USE_GTK || USE_X_TOOLKIT.
431 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
432 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
433 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
434 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
436 * xmenu.c (menu_help_callback): Pointer type fixes.
437 Use const pointers when pointing at readonly data. Avoid pointer
439 (FALSE): Remove unused macro.
440 (update_frame_menubar): Remove unused decl.
442 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
444 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
445 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
446 (single_menu_item): Rename local to avoid shadowing.
448 * keyboard.c (make_lispy_event): Remove unused local var.
450 * frame.c, frame.h (x_get_resource_string): Bring this back, but
451 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
453 * bitmaps: Change bitmaps from unsigned char back to the X11
454 compatible char. Avoid the old compiler warnings about
455 out-of-range initializers by using, for example, '\xab' rather
458 * xgselect.c (xgselect_initialize): Check vs interface
459 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
461 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
463 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
466 * fns.c (vector): Remove; this old hack is no longer needed.
468 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
470 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
472 * xrdb.c (x_load_resources): Omit unused local.
474 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
475 (x_window): Rename locals to avoid shadowing.
476 (USG): Use the kludged USG macro, to pacify gcc.
478 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
479 (x_term_init): Remove local to avoid shadowing.
481 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
483 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
484 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
486 2011-04-16 Eli Zaretskii <eliz@gnu.org>
488 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
490 Fix regex.c, syntax.c and friends for buffers > 2GB.
491 * syntax.h (struct gl_state_s): Declare character position members
494 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
496 * textprop.c (verify_interval_modification, interval_of): Declare
499 * intervals.c (adjust_intervals_for_insertion): Declare arguments
502 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
504 * indent.c (Fvertical_motion): Local variable it_start is now
507 * regex.c (re_match, re_match_2, re_match_2_internal)
508 (bcmp_translate, regcomp, regexec, print_double_string)
509 (group_in_compile_stack, re_search, re_search_2, regex_compile)
510 (re_compile_pattern, re_exec): Declare arguments and local
511 variables `size_t' and `ssize_t' and return values `regoff_t', as
513 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
514 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
515 <compile_stack_type>: `size' and `avail' are now `size_t'.
517 * regex.h <regoff_t>: Use ssize_t, not int.
518 (re_search, re_search_2, re_match, re_match_2): Arguments that
519 specify buffer/string position and length are now ssize_t and
520 size_t. Return type is regoff_t.
522 2011-04-16 Ben Key <bkey76@gmail.com>
524 * nsfont.m: Fixed bugs in ns_get_family and
525 ns_descriptor_to_entity that were caused by using free to
526 deallocate memory blocks that were allocated by xmalloc (via
527 xstrdup). This caused Emacs to crash when compiled with
528 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
529 --enable-checking=xmallocoverrun). xfree is now used to
530 deallocate these memory blocks.
532 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
534 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
536 emacs_write: Accept and return EMACS_INT for sizes.
537 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
539 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
540 Accept and return EMACS_INT.
541 (emacs_gnutls_write): Return the number of bytes written on
543 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
544 (emacs_read, emacs_write): Remove check for negative size, as the
545 Emacs source code has been audited now.
546 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
547 (emacs_read, emacs_write): Use it.
548 * process.c (send_process): Adjust to the new signatures of
549 emacs_write and emacs_gnutls_write. Do not attempt to store
550 a byte offset into an 'int'; it might overflow.
551 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
553 * sound.c: Don't assume sizes fit in 'int'.
554 (struct sound_device.period_size, alsa_period_size):
555 Return EMACS_INT, not int.
556 (struct sound_device.write, vox_write, alsa_write):
557 Accept EMACS_INT, not int.
558 (wav_play, au_play): Use EMACS_INT to store sizes and to
559 record read return values.
561 2011-04-15 Ben Key <bkey76@gmail.com>
563 * keyboard.c (Qundefined): Don't declare static since it is used
565 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
566 static since they are used in nsfont.m.
568 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
570 * process.c (Qprocessp): Don't declare static.
571 * lisp.h (Qprocessp): Declare again.
573 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
575 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
577 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
579 Improve C-level modularity by making more things 'static'.
581 Don't publish debugger-only interfaces to other modules.
582 * lisp.h (safe_debug_print, debug_output_compilation_hack):
583 (verify_bytepos, count_markers): Move decls to the only modules
585 * region-cache.h (pp_cache): Likewise.
586 * window.h (check_all_windows): Likewise.
587 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
589 * sysdep.c (croak): Now static, if
590 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
591 * syssignal.h (croak): Declare only if not static.
593 * alloc.c (refill_memory_reserve): Now static if
594 !defined REL_ALLOC || defined SYSTEM_MALLOC.
595 * lisp.h (refill_memory_reserve): Declare only if not static.
597 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
598 Define only if USE_LUCID.
600 * xrdb.c (x_customization_string, x_rm_string): Now static.
602 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
603 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
605 * xdisp.c (draw_row_with_mouse_face): Now static.
606 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
608 * window.h (check_all_windows): Mark externally visible.
610 * window.c (window_deletion_count): Now static.
612 * undo.c: Make symbols static if they're not exported.
613 (last_undo_buffer, last_boundary_position, pending_boundary):
616 * textprop.c (interval_insert_behind_hooks): Now static.
617 (interval_insert_in_front_hooks): Likewise.
619 * term.c: Make symbols static if they're not exported.
620 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
621 (max_frame_lines, tty_set_terminal_modes):
622 (tty_reset_terminal_modes, tty_turn_off_highlight):
623 (get_tty_terminal): Now static.
624 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
625 * termhooks.h (term_mouse_moveto): Do not declare if
627 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
628 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
630 * sysdep.c: Make symbols static if they're not exported.
631 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
633 (sigprocmask_set, full_mask): Remove; unused.
634 (wait_debugging): Mark as visible.
635 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
636 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
638 * syntax.c (syntax_temp): Define only if !__GNUC__.
640 * sound.c (current_sound_device, current_sound): Now static.
642 * search.c (searchbufs, searchbuf_head): Now static.
644 * scroll.c (scroll_cost): Remove; unused.
645 * dispextern.h (scroll_cost): Remove decl.
647 * region-cache.h (pp_cache): Mark as externally visible.
649 * process.c: Make symbols static if they're not exported.
650 (process_tick, update_tick, create_process, chan_process):
651 (Vprocess_alist, proc_buffered_char, datagram_access):
652 (fd_callback_data, send_process_frame, process_sent_to): Now static.
653 (deactivate_process): Mark defn as static, as well as decl.
654 * lisp.h (create_process): Remove decl.
655 * process.h (chan_process, Vprocess_alist): Remove decls.
657 * print.c: Make symbols static if they're not exported.
658 (print_depth, new_backquote_output, being_printed, print_buffer):
659 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
660 (print_interval, print_number_index, initial_stderr_stream):
662 * lisp.h (Fprinc): Remove decl.
663 (debug_output_compilation_hack): Mark as externally visible.
665 * sysdep.c (croak): Move decl from here to syssignal.h.
666 * syssignal.h (croak): Put it here, so the API can be checked when
667 'croak' is called from dissociate_if_controlling_tty.
669 * minibuf.c: Make symbols static if they're not exported.
670 (minibuf_save_list, choose_minibuf_frame): Now static.
671 * lisp.h (choose_minibuf_frame): Remove decl.
673 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
675 * lread.c: Make symbols static if they're not exported.
676 (read_objects, initial_obarray, oblookup_last_bucket_number):
678 (make_symbol): Remove; unused.
679 * lisp.h (initial_obarray, make_symbol): Remove decls.
681 * keyboard.c: Make symbols static if they're not exported.
682 (single_kboard, recent_keys_index, total_keys, recent_keys):
683 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
684 (this_single_command_key_start, echoing, last_auto_save):
685 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
686 (command_loop, echo_now, keyboard_init_hook, help_char_p):
687 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
688 (Vlispy_mouse_stem, double_click_count):
690 (force_auto_save_soon): Define only if SIGDANGER.
691 (ignore_mouse_drag_p): Now static if
692 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
693 (print_help): Remove; unused.
694 (stop_character, last_timer_event): Mark as externally visible.
695 * keyboard.h (ignore_mouse_drag_p): Declare only if
696 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
697 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
698 * lisp.h (echoing): Remove decl.
699 (force_auto_save_soon): Declare only if SIGDANGER.
700 * xdisp.c (redisplay_window): Simplify code, to make it more
701 obvious that ignore_mouse_drag_p is not accessed if !defined
702 USE_GTK && !defined HAVE_NS.
704 * intervals.c: Make symbols static if they're not exported.
705 (merge_properties_sticky, merge_interval_right, delete_interval):
707 * intervals.h (merge_interval_right, delete_interval): Remove decls.
709 * insdel.c: Make symbols static if they're not exported.
710 However, leave prepare_to_modify_buffer alone. It's never
711 called from outside this function, but that appears to be a bug.
712 (combine_after_change_list, combine_after_change_buffer):
713 (adjust_after_replace, signal_before_change): Now static.
714 (adjust_after_replace_noundo): Remove; unused.
715 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
716 (signal_before_change): Remove decls.
718 * indent.c (val_compute_motion, val_vmotion): Now static.
720 * image.c: Make symbols static if they're not exported.
721 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
723 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
724 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
726 * fringe.c (standard_bitmaps): Now static.
727 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
729 * frame.c: Make symbols static if they're not exported.
730 (x_report_frame_params, make_terminal_frame): Now static.
731 (get_frame_param): Now static, unless HAVE_NS.
732 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
733 (x_get_resource_string): Remove; not used.
734 * frame.h (make_terminal_frame, x_report_frame_params):
735 (x_get_resource_string); Remove decls.
736 (x_fullscreen_adjust): Declare only if WINDOWSNT.
737 * lisp.h (get_frame_param): Declare only if HAVE_NS.
739 * font.c, fontset.c: Make symbols static if they're not exported.
740 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
741 (FACE_SUITABLE_FOR_CHAR_P): Use it.
742 * font.c (font_close_object): Now static.
743 * font.h (font_close_object): Remove.
744 * fontset.c (FONTSET_OBJLIST): Remove.
745 (free_realized_fontset) #if-0 the body, which does nothing.
746 (face_suitable_for_char_p): #if-0, as it's never called.
747 * fontset.h (face_suitable_for_char_p): Remove decl.
748 * xfaces.c (face_at_string_position): Use
749 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
750 since 0 is always ASCII.
752 * fns.c (weak_hash_tables): Now static.
754 * fileio.c: Make symbols static if they're not exported.
755 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
756 (Vwrite_region_annotation_buffers): Now static.
758 * eval.c: Make symbols static if they're not exported.
759 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
760 * lisp.h (backtrace_list): Remove decl.
762 * emacs.c: Make symbols static if they're not exported.
763 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
764 (fatal_error_code, fatal_error_signal_hook, standard_args):
766 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
767 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
768 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
769 * lisp.h (fatal_error_signal_hook): Remove decl.
770 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
772 * editfns.c: Move a (normally-unused) function to its only use.
773 * editfns.c, lisp.h (get_operating_system_release): Remove.
774 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
775 worth the hassle of breaking this out.
777 * xterm.c: Make symbols static if they're not exported.
778 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
779 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
780 (x_destroy_window, x_delete_display):
782 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
783 (x_mouse_leave): Remove; unused.
784 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
785 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
786 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
788 (x_mouse_leave): Declare only if WINDOWSNT.
789 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
790 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
793 * ftxfont.c: Make symbols static if they're not exported.
794 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
796 * font.h (ftxfont_driver): Likewise.
798 * xfns.c: Make symbols static if they're not exported.
799 (x_last_font_name, x_display_info_for_name):
800 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
801 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
802 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
803 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
804 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
805 (last_show_tip_args): Now static.
806 (xic_defaut_fontset, xic_create_fontsetname): Define only if
807 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
808 (x_screen_planes): Remove; unused.
809 * dispextern.h (x_screen_planes): Remove decl.
811 * dispnew.c: Make symbols static if they're not exported.
812 * dispextern.h (redraw_garbaged_frames, scrolling):
813 (increment_row_positions): Remove.
814 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
815 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
817 (redraw_garbaged_frames): Remove; unused.
819 * xfaces.c: Make symbols static if they're not exported.
820 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
822 * xterm.h (defined_color): Remove decls.
823 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
824 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
825 (menu_face_changed_default, defined_color, free_realized_face):
826 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
827 (ascii_face_of_lisp_face): Remove; unused.
829 * xdisp.c: Make symbols static if they're not exported.
830 * dispextern.h (scratch_glyph_row, window_box_edges):
831 (glyph_to_pixel_coords, set_cursor_from_row):
832 (get_next_display_element, set_iterator_to_next):
833 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
834 (show_mouse_face): Remove decls
835 * frame.h (message_buf_print): Likewise.
836 * lisp.h (pop_message, set_message, check_point_in_composition):
838 * xterm.h (set_vertical_scroll_bar): Likewise.
839 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
840 (message_buf_print, scratch_glyph_row, displayed_buffer):
841 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
842 (get_next_display_element, show_mouse_face, window_box_edges):
843 (frame_to_window_pixel_xy, check_point_in_composition):
844 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
845 (glyph_to_pixel_coords): Remove; unused.
847 * dired.c (file_name_completion): Now static.
849 * dbusbind.c (xd_in_read_queued_messages): Now static.
851 * lisp.h (circular_list_error, FOREACH): Remove; unused.
852 * data.c (circular_list_error): Remove.
854 * commands.h (last_point_position, last_point_position_buffer):
855 (last_point_position_window): Remove decls.
856 * keyboard.c: Make these variables static.
858 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
860 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
861 (iso_code_class, detect_coding, code_convert_region): Now static.
862 (encode_coding_gap): Remove; unused.
864 * chartab.c (chartab_chars, chartab_bits): Now static.
866 * charset.h (charset_iso_8859_1): Remove decl.
867 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
870 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
871 * ccl.c (Vccl_program_table): Now static.
872 (check_ccl_update): Remove; unused.
874 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
875 * category.h: ... from here.
876 * category.c (check_category_table, set_category_set): Now static.
878 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
879 * lisp.h: Remove these decls.
881 * buffer.c (buffer_count): Remove unused var.
883 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
884 so that it's not optimized away.
885 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
886 * dispextern.h (bidi_dump_cached_states): Remove, since it's
887 exported only to the debugger.
889 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
890 * atimer.h (run_all_atimers): Removed; not exported.
892 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
893 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
894 was inaccessible from Lisp.
895 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
896 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
898 alloc.c: Import and export fewer symbols, and remove unused items.
899 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
901 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
902 it's not optimized away by whole-program optimization.
903 (message_enable_multibyte, free_misc): Remove.
904 (catchlist, handlerlist, mark_backtrace):
905 Declare only if BYTE_MARK_STACK.
906 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
907 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
908 (message_enable_multibyte): Remove decl.
909 (free_misc, interval_free_list, float_block, float_block_index):
910 (n_float_blocks, float_free_list, cons_block, cons_block_index):
911 (cons_free_list, last_marked_index):
913 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
914 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
915 (mark_backtrace): Define only if BYTE_MARK_STACK.
916 * xdisp.c (message_enable_multibyte): Now static.
918 Declare Lisp_Object Q* variables to be 'static' if not exported.
919 This makes it easier for human readers (and static analyzers)
920 to see whether these variables are used from other modules.
921 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
922 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
923 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
924 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
925 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
926 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
927 * xmenu.c, xselect.c:
928 Declare Q* vars static if they are not used in other modules.
929 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
930 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
931 Remove decls of unexported vars.
932 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
934 * lisp.h (DEFINE_FUNC): Make sname 'static'.
936 Make Emacs functions such as Fatom 'static' by default.
937 This makes it easier for human readers (and static analyzers)
938 to see whether these functions can be called from other modules.
939 DEFUN now defines a static function. To make the function external
940 so that it can be used in other C modules, use the new macro DEFUE.
941 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
942 (Finit_image_library):
943 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
944 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
945 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
946 Remove decls, since these functions are now static.
947 (Funintern, Fget_internal_run_time): New decls, since these functions
948 were already external.
950 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
951 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
952 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
953 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
954 * keyboard.c, keymap.c, lread.c:
955 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
956 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
957 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
958 Mark functions with DEFUE instead of DEFUN,
959 if they are used in other modules.
960 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
961 decls for now-static functions.
962 * buffer.h (Fdelete_overlay): Remove decl.
963 * callproc.c (Fgetenv_internal): Mark as internal.
964 * composite.c (Fremove_list_of_text_properties): Remove decl.
965 (Fcomposition_get_gstring): New forward static decl.
966 * composite.h (Fcomposite_get_gstring): Remove decl.
967 * dired.c (Ffile_attributes): New forward static decl.
968 * doc.c (Fdocumntation_property): New forward static decl.
969 * eval.c (Ffetch_bytecode): New forward static decl.
970 (Funintern): Remove extern decl; now in .h file where it belongs.
971 * fileio.c (Fmake_symbolic_link): New forward static decl.
972 * image.c (Finit_image_library): New forward static decl.
973 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
974 * intervals.h (Fprevious_property_change):
975 (Fremove_list_of_text_properties): Remove decls.
976 * keyboard.c (Fthis_command_keys): Remove decl.
977 (Fcommand_execute): New forward static decl.
978 * keymap.c (Flookup_key): New forward static decl.
979 (Fcopy_keymap): Now static.
980 * keymap.h (Flookup_key): Remove decl.
981 * process.c (Fget_process): New forward static decl.
982 (Fprocess_datagram_address): Mark as internal.
983 * syntax.c (Fsyntax_table_p): New forward static decl.
984 (skip_chars): Remove duplicate decl.
985 * textprop.c (Fprevious_property_change): New forward static decl.
986 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
988 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
989 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
991 * editfns.c (Fformat): Remove unreachable code.
993 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
995 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
998 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1000 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1001 when at ZV. (Bug#8487)
1003 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1005 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1007 * keyboard.c (parse_tool_bar_item): Likewise.
1008 * sound.c (sound_cleanup, alsa_close): Likewise.
1009 * termcap.c (tgetent): Likewise.
1010 * xfns.c (x_default_font_parameter): Likewise.
1011 * xsettings.c (read_and_apply_settings): Likewise.
1013 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1014 (overrun_check_free): Protoize.
1016 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1018 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1019 since callers should never pass a negative size.
1020 Change the signature to match that of plain 'read' and 'write'; see
1021 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1022 * lisp.h: Update prototypes of emacs_write and emacs_read.
1024 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1026 * xdisp.c (redisplay_window): Don't try to determine the character
1027 position of the scroll margin if the window start point w->startp
1028 is outside the buffer's accessible region. (Bug#8468)
1030 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1032 Fix write-region and its subroutines for buffers > 2GB.
1033 * fileio.c (a_write, e_write): Modify declaration of arguments and
1034 local variables to support buffers larger than 2GB.
1035 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1037 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1038 argument, local variables, and return value.
1040 * lisp.h: Update prototypes of emacs_write and emacs_read.
1042 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1044 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1046 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1048 Fix more problems found by GCC 4.6.0's static checks.
1050 * xdisp.c (vmessage): Use a better test for character truncation.
1052 * charset.c (load_charset_map): <, not <=, for optimization,
1053 and to avoid potential problems with integer overflow.
1054 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1055 * casetab.c (set_identity, shuffle): Likewise.
1056 * editfns.c (Fformat): Likewise.
1057 * syntax.c (skip_chars): Likewise.
1059 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1060 This also lets GCC 4.6.0 generate slightly better loop code.
1062 * callint.c (Fcall_interactively): <, not <=, for optimization.
1063 (Fcall_interactively): Count the number of arguments produced,
1064 not the number of arguments given. This is simpler and lets GCC
1065 4.6.0 generate slightly better code.
1067 * ftfont.c: Distingish more carefully between FcChar8 and char.
1068 The previous code passed unsigned char * to a functions like
1069 strlen and xstrcasecmp that expect char *, which does not
1070 conform to the C standard.
1071 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1072 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1073 char * when the C standard requires it.
1075 * keyboard.c (read_char): Remove unused var.
1077 * eval.c: Port to Windows vsnprintf (Bug#8435).
1079 (SIZE_MAX): Define if the headers do not.
1080 (verror): Do not give up if vsnprintf returns a negative count.
1081 Instead, grow the buffer. This ports to Windows vsnprintf, which
1082 does not conform to C99. Problem reported by Eli Zaretskii.
1083 Also, simplify the allocation scheme, by avoiding the need for
1084 calling realloc, and removing the ALLOCATED variable.
1086 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1088 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1089 But keep the doprint source code for now, as we might revamp it
1090 and use it again (Bug#8435).
1091 * lisp.h (doprnt): Remove.
1092 * Makefile.in (base_obj): Remove doprnt.o.
1093 * deps.mk (doprnt.o): Remove.
1095 error: Print 32- and 64-bit integers portably (Bug#8435).
1096 Without this change, on typical 64-bit hosts error ("...%d...", N)
1097 was used to print both 32- and 64-bit integers N, which relied on
1099 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1101 * lisp.h (error, verror): Mark as printf-like functions.
1102 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1103 Report overflow in size calculations when allocating printf buffer.
1104 Do not truncate output string at its first null byte.
1105 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1106 Truncate the output at a character boundary, since vsnprintf does not
1108 * charset.c (check_iso_charset_parameter): Convert internal
1109 character to string before calling 'error', since %c now has the
1111 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1112 overflow when computing char to be passed to 'error'. Do not
1113 pass Lisp_Object to 'error'; pass the integer instead.
1114 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1115 formatted with plain %d.
1117 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1119 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1121 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1123 * xterm.c (x_catch_errors): Remove duplicate declaration.
1125 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1127 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1129 2011-04-10 Jim Meyering <meyering@redhat.com>
1131 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1132 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1133 return ssize_t not "int", and use size_t as the buffer length.
1134 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1135 * gnutls.h: Update declarations.
1136 * process.c (read_process_output): Use ssize_t, to match.
1137 (send_process): Likewise.
1139 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1141 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1143 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1145 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1146 unsigned char, to match FcChar8 type definition.
1148 * xterm.c (handle_one_xevent):
1149 * xmenu.c (create_and_show_popup_menu):
1150 * xselect.c (x_decline_selection_request)
1151 (x_reply_selection_request): Avoid type-punned deref of X events.
1153 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1155 Fix some uses of `int' instead of EMACS_INT.
1156 * search.c (string_match_1, fast_string_match)
1157 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1158 (scan_buffer, find_next_newline_no_quit)
1159 (find_before_next_newline, search_command, Freplace_match)
1160 (Fmatch_data): Make some `int' variables be EMACS_INT.
1162 * xdisp.c (display_count_lines): 3rd argument and return value now
1163 EMACS_INT. All callers changed.
1164 (pint2hrstr): Last argument is now EMACS_INT.
1166 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1167 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1168 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1169 (decode_coding_utf_16, decode_coding_emacs_mule)
1170 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1171 (decode_coding_ccl, decode_coding_charset)
1172 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1173 (decode_coding_iso_2022, decode_coding_emacs_mule)
1174 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1175 <char_offset, last_offset>: Declare EMACS_INT.
1176 (encode_coding_utf_8, encode_coding_utf_16)
1177 (encode_coding_emacs_mule, encode_invocation_designation)
1178 (encode_designation_at_bol, encode_coding_iso_2022)
1179 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1180 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1182 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1183 (encode_invocation_designation): Last argument P_NCHARS is now
1185 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1186 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1188 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1191 * ccl.c (Fccl_execute_on_string): Declare some variables
1194 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1196 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1198 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1200 * process.c (Fformat_network_address): Doc fix.
1202 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1204 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1206 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1208 * keyboard.c (read_char): Call Lisp function help-form-show,
1209 instead of using internal_with_output_to_temp_buffer.
1210 (Qhelp_form_show): New var.
1211 (syms_of_keyboard): Use DEFSYM macro.
1213 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1215 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1217 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1219 * process.c (Flist_processes): Removed to Lisp.
1220 (list_processes_1): Deleted.
1222 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1224 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1226 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1228 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1230 Fix more problems found by GCC 4.6.0's static checks.
1232 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1234 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1236 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1238 * xdisp.c (vmessage): Mark as a printf-like function.
1240 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1242 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1244 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1245 printf-like functions.
1246 (tiff_load): Add casts to remove these marks before passing them
1247 to system-supplied API.
1249 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1251 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1252 This avoids several warnings with gcc -Wstrict-overflow.
1253 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1254 directly, rather than having caller test rule sign. This avoids
1255 some unnecessary tests.
1256 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1257 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1258 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1260 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1261 (xfont_open): Avoid unnecessary tests.
1263 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1265 * composite.h, composite.c (composition_gstring_put_cache):
1266 Use EMACS_INT, not int, for length.
1268 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1269 breaking out part of COMPOSITION_DECODE_RULE.
1270 (COMPOSITION_DECODE_RULE): Use it.
1271 * composite.c (get_composition_id): Remove unused local vars,
1272 by using the new macro.
1274 * textprop.c (set_text_properties_1): Change while to do-while,
1275 since the condition is always true at first.
1277 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1278 (interval_deletion_adjustment): Return unsigned value.
1281 * process.c (list_processes_1, create_pty, read_process_output):
1282 (exec_sentinel): Remove vars that were set but not used.
1283 (create_pty): Remove unnecessary "volatile"s.
1284 (Fnetwork_interface_info): Avoid possibility of int overflow.
1285 (read_process_output): Do adaptive read buffering even if carryover.
1286 (read_process_output): Simplify nbytes computation if buffered.
1288 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1290 * syntax.c (scan_words): Remove var that was set but not used.
1291 (update_syntax_table): Use unsigned instead of int.
1293 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1294 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1295 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1297 * print.c (print_error_message): Avoid int overflow.
1299 * font.c (font_list_entities): Redo for clarity,
1300 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1302 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1303 (font_score): Avoid potential overflow in diff calculation.
1305 * fns.c (substring_both): Remove var that is set but not used.
1306 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1308 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1310 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1311 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1312 can always succeed if overflow has undefined behavior.
1314 * search.c (boyer_moore, wordify): Remove vars set but not used.
1315 (wordify): Omit three unnecessary tests.
1317 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1318 All callers changed. This avoids the need for an unused var.
1320 * casefiddle.c (casify_region): Remove var that is set but not used.
1322 * dired.c (file_name_completion): Remove var that is set but not used.
1324 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1326 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1327 (Finsert_file_contents): Remove unnecessary code checking fd.
1329 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1330 Check for integer overflow on size calculations.
1332 * buffer.c (Fprevious_overlay_change): Remove var that is set
1335 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1336 Remove vars that are set but not used.
1337 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1338 (timer_check_2): Mark vars as initialized.
1340 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1342 * image.c (lookup_image): Remove var that is set but not used.
1343 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1345 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1346 that are set but not used.
1348 * xfns.c (make_invisible_cursor): Don't return garbage
1349 if XCreateBitmapFromData fails (Bug#8410).
1351 * xselect.c (x_get_local_selection, x_handle_property_notify):
1352 Remove vars that are set but not used.
1354 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1355 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1357 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1358 Remove var that is set but not used.
1359 (scroll_bar_windows_size): Now size_t, not int.
1360 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1363 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1364 (map_tty_color) [!defined MSDOS]: Likewise.
1366 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1368 * coding.c: Remove vars that are set but not used.
1369 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1370 All callers changed.
1371 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1372 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1373 (decode_coding_charset): Remove vars that are set but not used.
1375 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1376 that is set but not used.
1378 * print.c (print_object): Remove var that is set but not used.
1380 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1381 The gnulib version avoids calling malloc in the usual case,
1382 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1383 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1384 * filelock.c (current_lock_owner): Likewise.
1385 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1386 * sysdep.c: Include allocator.h, careadlinkat.h.
1387 (emacs_no_realloc_allocator): New static constant.
1388 (emacs_readlink): New function.
1389 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1390 ../lib/careadlinkat.h.
1392 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1394 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1395 first non-nil return value).
1397 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1399 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1400 if not defined (Bug#8403).
1402 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1404 * xdisp.c (display_count_lines): Remove parameter `start',
1405 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1406 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1407 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1408 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1409 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1410 and thereabouts. All callers changed.
1411 (get_per_char_metric): Remove parameter `f', unused since
1412 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1414 2011-04-02 Jim Meyering <meyering@redhat.com>
1416 do not dereference NULL upon failed strdup
1417 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1418 (ns_get_family): Likewise.
1420 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1422 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1424 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1426 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1429 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1431 Add lexical binding.
1433 * window.c (Ftemp_output_buffer_show): New fun.
1434 (Fsave_window_excursion):
1435 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1437 * lread.c (lisp_file_lexically_bound_p): New function.
1438 (Fload): Bind Qlexical_binding.
1439 (readevalloop): Remove `evalfun' arg.
1440 Bind Qinternal_interpreter_environment.
1441 (Feval_buffer): Bind Qlexical_binding.
1442 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1444 (syms_of_lread): Declare `lexical-binding'.
1446 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1448 * keyboard.c (eval_dyn): New fun.
1449 (menu_item_eval_property): Use it.
1451 * image.c (parse_image_spec): Use Ffunctionp.
1453 * fns.c (concat, mapcar1): Accept byte-code-functions.
1455 * eval.c (Fsetq): Handle lexical vars.
1456 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1457 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1458 (FletX, Flet): Obey lexical binding.
1459 (Fcommandp): Handle closures.
1460 (Feval): New `lexical' arg.
1461 (eval_sub): New function extracted from Feval. Use it almost
1462 everywhere where Feval was used. Look up vars in lexical env.
1464 (Ffunctionp): Move from subr.el.
1465 (Ffuncall): Handle closures.
1466 (apply_lambda): Remove `eval_flags'.
1467 (funcall_lambda): Handle closures and new byte-code-functions.
1468 (Fspecial_variable_p): New function.
1469 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1470 but without exporting it to Lisp.
1472 * doc.c (Fdocumentation, store_function_docstring):
1473 * data.c (Finteractive_form): Handle closures.
1475 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1478 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1480 (exec_byte_code): New function extracted from Fbyte_code to handle new
1481 calling convention for byte-code-functions. Add new byte-codes.
1483 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1485 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1487 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1489 * xdisp.c (redisplay_internal): Fix prototype.
1491 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1493 * xdisp.c (SCROLL_LIMIT): New macro.
1494 (try_scrolling): Use it when setting scroll_limit. Limit
1495 scrolling to 100 screen lines.
1496 (redisplay_window): Even when falling back on "recentering",
1497 position point in the window according to scroll-conservatively,
1498 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1500 (try_scrolling): When point is above the window, allow searching
1501 as far as scroll_max, or one screenful, to compute vertical
1502 distance from PT to the scroll margin position. This prevents
1503 try_scrolling from unnecessarily failing when
1504 scroll-conservatively is set to a value slightly larger than the
1505 window height. Clean up the case of PT below the margin at bottom
1506 of window: scroll_max can no longer be INT_MAX. When aggressive
1507 scrolling is in use, don't let point enter the opposite scroll
1508 margin as result of the scroll.
1509 (syms_of_xdisp) <scroll-conservatively>: Document the
1510 threshold of 100 lines for never-recentering scrolling.
1512 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1514 * dispextern.h (move_it_by_lines):
1515 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1516 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1517 (message_log_check_duplicate): Remove parameters `prev_bol' and
1518 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1519 (redisplay_internal): Remove parameter `preserve_echo_area',
1520 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1522 * indent.c (Fvertical_motion):
1523 * window.c (window_scroll_pixel_based, Frecenter):
1524 Don't pass `need_y_p' to `move_it_by_lines'.
1526 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1528 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1529 steal a few bits to be more compact.
1530 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1531 Remove unneeded casts.
1533 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1535 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1537 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1538 binding" message (bug#7967).
1540 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1542 Fix more problems found by GCC 4.6.0's static checks.
1544 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1545 Remove unused local var.
1547 * editfns.c (Fmessage_box): Remove unused local var.
1549 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1550 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1551 Omit unused local vars.
1552 * window.c (shrink_windows): Omit unused local var.
1553 * menu.c (digest_single_submenu): Omit unused local var.
1554 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1555 Omit unused local var.
1557 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1558 Don't assume string length fits in int.
1559 (keyremap_step, read_key_sequence): Use size_t for sizes.
1560 (read_key_sequence): Don't check last_real_key_start redundantly.
1562 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1563 instead of alloca (Bug#8344).
1565 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1566 (Fbacktrace_frame): Don't assume nframes fits in int.
1568 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1570 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1573 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1575 * cm.c (calccost): Turn while-do into do-while, for clarity.
1577 * keyboard.c (syms_of_keyboard): Use the same style as later
1578 in this function when indexing through an array. This also
1579 works around GCC bug 48267.
1581 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1583 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1585 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1586 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1588 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1589 This avoids undefined behavior on integer overflow, and is a bit
1590 more convenient anyway since it is compared to a size_t variable.
1592 Variadic C functions now count arguments with size_t, not int.
1593 This avoids an unnecessary limitation on 64-bit machines, which
1594 caused (substring ...) to crash on large vectors (Bug#8344).
1595 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1596 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1597 All variadic functions and their callers changed accordingly.
1598 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1599 * data.c (arith_driver, float_arith_driver): Likewise.
1600 * editfns.c (general_insert_function): Likewise.
1601 * eval.c (struct backtrace.nargs, interactive_p)
1602 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1603 (funcall_lambda, mark_backtrace): Likewise.
1604 * fns.c (concat): Likewise.
1605 * frame.c (x_set_frame_parameters): Likewise.
1606 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1607 0 if not found, not -1. All callers changed.
1609 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1610 (stack_copy_size): Now size_t, not int.
1611 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1613 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1615 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1616 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1617 All callers changed.
1619 * lisp.h (multibyte_char_to_unibyte):
1620 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1621 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1622 * character.h (CHAR_TO_BYTE8):
1623 * cmds.c (internal_self_insert):
1624 * editfns.c (general_insert_function):
1625 * keymap.c (push_key_description):
1626 * search.c (Freplace_match):
1627 * xdisp.c (message_dolog, set_message_1): All callers changed.
1629 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1631 * keyboard.c (safe_run_hook_funcall): New function.
1632 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1633 don't set the hook to nil, but remove the offending function instead.
1634 (Qcommand_hook_internal): Remove, unused.
1635 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1636 Vcommand_hook_internal.
1638 * eval.c (enum run_hooks_condition): Remove.
1639 (funcall_nil, funcall_not): New functions.
1640 (run_hook_with_args): Call each function through a `funcall' argument.
1641 Remove `cond' argument, now redundant.
1642 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1643 (Frun_hook_with_args_until_failure): Adjust accordingly.
1644 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1646 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1648 * dispextern.h (string_buffer_position): Remove declaration.
1650 * print.c (strout): Remove parameter `multibyte', unused since
1651 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1653 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1654 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1655 All callers changed.
1657 * w32.c (_wsa_errlist): Use braces for struct initializers.
1659 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1660 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1661 All callers changed.
1662 (string_buffer_position): Likewise. Also, make static (it's never
1663 used outside xdisp.c).
1664 (cursor_row_p): Remove parameter `w', unused since
1665 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1666 (decode_mode_spec): Remove parameter `precision', introduced during
1667 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1668 All callers changed.
1670 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1672 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1674 2011-03-27 Anders Lindgren <andlind@gmail.com>
1676 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1677 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1678 (ns_update_auto_hide_menu_bar): New functions.
1679 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1680 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1681 ns_constrain_all_frames.
1682 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1683 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1685 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1687 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1689 2011-03-27 Glenn Morris <rgm@gnu.org>
1691 * syssignal.h: Replace RETSIGTYPE with void.
1692 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1693 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1694 Replace SIGTYPE with void everywhere.
1695 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1696 * s/template.h (SIGTYPE): Remove commented out definition.
1698 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1700 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1701 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1703 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1705 * w32.c (read_unc_volume): Use parameter `henum', instead of
1706 global variable `wget_enum_handle'.
1708 * keymap.c (describe_vector): Remove parameters `indices' and
1709 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1710 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1712 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1714 * keyboard.c (timer_check): Remove parameter `do_it_now',
1715 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1716 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1717 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1719 * keyboard.c (read_char):
1720 * w32menu.c (w32_menu_display_help):
1721 * xmenu.c (show_help_event, menu_help_callback):
1722 Adjust calls to `show_help_echo'.
1724 * gtkutil.c (xg_maybe_add_timer):
1725 * keyboard.c (readable_events):
1726 * process.c (wait_reading_process_output):
1727 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1729 * insdel.c (adjust_markers_gap_motion):
1730 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1731 (gap_left, gap_right): Don't call it.
1733 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1735 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1736 incurred during fontification.
1738 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1740 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1741 (DEFVAR_PER_BUFFER): Don't pass it.
1743 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1744 (scrolling_window): Don't pass it.
1746 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1748 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1750 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1752 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1753 of variables specific to SELinux and computation of `encoded_absname'.
1755 * image.c (XPutPixel): Remove unused variable `height'.
1757 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1759 * unexw32.c (get_section_info): Remove unused variable `section'.
1761 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1762 (system_process_attributes): Remove unused variable `sess'.
1763 (sys_read): Remove unused variable `err'.
1765 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1766 (w32_wnd_proc): Remove unused variable `isdead'.
1767 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1768 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1769 (x_create_tip_frame): Remove unused variable `tem'.
1771 * w32inevt.c (w32_console_read_socket):
1772 Remove unused variable `no_events'.
1774 * w32term.c (x_draw_composite_glyph_string_foreground):
1775 Remove unused variable `width'.
1777 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1779 * w32term.c (x_set_glyph_string_clipping):
1780 Don't pass uninitialized region to CombineRgn.
1782 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1784 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1785 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1786 (Fx_close_connection): Remove unused variable `i'.
1788 * w32font.c (w32font_draw): Return number of glyphs.
1789 (w32font_open_internal): Remove unused variable `i'.
1790 (w32font_driver): Add missing initializer.
1792 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1793 (fill_in_menu): Remove unused variable `items_added'.
1795 * w32term.c (last_mouse_press_frame): Remove static global variable.
1796 (w32_clip_to_row): Remove unused variable `f'.
1797 (x_delete_terminal): Remove unused variable `i'.
1799 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1800 (NOTHING): Remove unused static global variable.
1801 (uniscribe_check_otf): Remove unused variable `table'.
1802 (uniscribe_font_driver): Add missing initializers.
1804 2011-03-23 Julien Danjou <julien@danjou.info>
1806 * term.c (Fsuspend_tty, Fresume_tty):
1807 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1808 * window.c (temp_output_buffer_show):
1809 * insdel.c (signal_before_change):
1810 * frame.c (Fhandle_switch_frame):
1811 * fileio.c (Fdo_auto_save):
1812 * emacs.c (Fkill_emacs):
1813 * editfns.c (save_excursion_restore):
1814 * cmds.c (internal_self_insert):
1815 * callint.c (Fcall_interactively):
1816 * buffer.c (Fkill_all_local_variables):
1817 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1819 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1820 unconditionnaly since it does the check itself.
1822 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1824 Fix more problems found by GCC 4.5.2's static checks.
1826 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1827 the first time through the loop, since we know p0 < p1 then.
1828 This also avoids a gcc -Wstrict-overflow warning.
1830 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1831 leading to a memory leak, possible in functions like
1832 load_charset_map_from_file that can allocate an unbounded number
1833 of objects (Bug#8318).
1835 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1836 that could (at least in theory) be that large.
1838 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1839 This is less likely to overflow, and avoids undefined behavior if
1840 overflow does occur. All callers changed. Use strtoul to scan
1841 for the unsigned long integer.
1842 (pint2hrstr): Simplify and tune code slightly.
1843 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1845 * scroll.c (do_scrolling): Work around GCC bug 48228.
1846 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1848 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1849 This also avoids a warning with gcc -Wstrict-overflow.
1850 (validate_x_resource_name): Simplify count usage.
1851 This also avoids a warning with gcc -Wstrict-overflow.
1853 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1856 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1858 * process.c (Fmake_network_process): Use socklen_t, not int,
1859 where POSIX says socklen_t is required in portable programs.
1860 This fixes a porting bug on hosts like 64-bit HP-UX, where
1861 socklen_t is wider than int (Bug#8277).
1862 (Fmake_network_process, server_accept_connection):
1863 (wait_reading_process_output, read_process_output):
1866 * process.c: Rename or move locals to avoid shadowing.
1867 (list_processes_1, Fmake_network_process):
1868 (read_process_output_error_handler, exec_sentinel_error_handler):
1869 Rename or move locals.
1870 (Fmake_network_process): Define label "retry_connect" only if needed.
1871 (Fnetwork_interface_info): Fix pointer signedness.
1872 (process_send_signal): Add cast to avoid pointer signedness problem.
1873 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1874 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1876 Make tparam.h and terminfo.c consistent.
1877 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1878 Include tparam.h instead, since it declares them.
1879 * cm.h (PC): Remove extern decl; tparam.h now does this.
1880 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1881 * terminfo.c: Include tparam.h, to check interfaces.
1882 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1883 (tparam): Adjust signature to match interface in tparam.h;
1884 this removes some undefined behavior. Check that outstring and len
1885 are zero, which they always are with Emacs.
1886 * tparam.h (PC, BC, UP): New extern decls.
1888 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1889 (xftfont_open): Rename locals to avoid shadowing.
1891 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1892 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1893 (OTF_TAG_SYM): Omit macro if not needed.
1894 (ftfont_list): Remove unused local.
1895 (get_adstyle_property, ftfont_pattern_entity):
1896 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1897 Rename locals to avoid shadowing.
1899 * xfont.c (xfont_list_family): Mark var as initialized.
1901 * xml.c (make_dom): Now static.
1903 * composite.c (composition_compute_stop_pos): Rename local to
1905 (composition_reseat_it): Remove unused locals.
1906 (find_automatic_composition, composition_adjust_point): Likewise.
1907 (composition_update_it): Mark var as initialized.
1908 (find_automatic_composition): Mark vars as initialized,
1909 with a FIXME (Bug#8290).
1911 character.h: Rename locals to avoid shadowing.
1912 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1913 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1914 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1915 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1918 * textprop.c (property_change_between_p): Remove; unused.
1920 * intervals.c (interval_start_pos): Now static.
1922 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1924 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1925 Rename locals to avoid shadowing.
1927 * sound.c (wav_play, au_play, Fplay_sound_internal):
1928 Fix pointer signedness.
1929 (alsa_choose_format): Remove unused local var.
1930 (wav_play): Initialize a variable to 0, to prevent undefined
1931 behavior (Bug#8278).
1933 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1935 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1937 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1938 clobbering (Bug#8298).
1939 * sysdep.c (sys_subshell): Likewise.
1940 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1942 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1943 This should get cleaned up, so that child_setup has the
1944 same signature on all platforms.
1946 * callproc.c (call_process_cleanup): Now static.
1947 (relocate_fd): Rename locals to avoid shadowing.
1949 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1951 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1952 not to be necessary, and produces flickering.
1954 2011-03-20 Glenn Morris <rgm@gnu.org>
1956 * config.in: Remove file.
1958 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1960 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1961 are now in src/globals.h.
1962 (syms_of_minibuf): Remove spurious & from previous change.
1964 2011-03-20 Leo <sdl.web@gmail.com>
1966 * minibuf.c (completing-read-function): New variable.
1967 (completing-read-default): Rename from completing-read.
1968 (completing-read): Call completing-read-function.
1970 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1972 * xfaces.c (Fx_load_color_file):
1973 Read color file from absolute filename (bug#8250).
1975 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1977 * makefile.w32-in: Update dependencies.
1979 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1981 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1983 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1985 Fix more problems found by GCC 4.5.2's static checks.
1987 * process.c (make_serial_process_unwind, send_process_trap):
1988 (sigchld_handler): Now static.
1990 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1991 That way, the code declares only the vars that it needs.
1992 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1993 * s/cygwin.h (PTY_ITERATION): Likewise.
1994 * s/darwin.h (PTY_ITERATION): Likewise.
1995 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1997 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1998 * process.c (allocate_pty): Don't declare stb unless it's needed.
2000 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2001 (CONSTANTLIM): Remove; unused.
2002 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2003 Define only if needed.
2005 * unexelf.c (unexec): Name an expression,
2006 to avoid gcc -Wbad-function-cast warning.
2007 Use a different way to cause a compilation error if anyone uses
2008 n rather than nn, a way that does not involve shadowing.
2009 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2011 * deps.mk (unexalpha.o): Remove; unused.
2013 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2014 * unexec.h: New file.
2015 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2016 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2018 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2019 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2020 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2021 Change as necessary to match prototype in unexec.h.
2023 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2025 (back_comment, skip_chars): Mark vars as initialized.
2027 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2028 Rename locals to avoid shadowing.
2030 * lread.c (read1): Rewrite so as not to use empty "else".
2031 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2033 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2035 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2036 warning when compiling print.c.
2038 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2039 instead of using an uninitialized var.
2040 (font_sort_entities): Mark var as initialized.
2042 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2044 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2045 pointers to constants.
2046 (font_parse_fcname): Remove unused vars.
2047 (font_delete_unmatched): Now static.
2048 (font_get_spec): Remove; unused.
2049 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2050 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2051 Rename or move locals to avoid shadowing.
2053 * fns.c (require_nesting_list, require_unwind): Now static.
2054 (Ffillarray): Rename locals to avoid shadowing.
2056 * floatfns.c (domain_error2): Define only if needed.
2057 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2059 * alloc.c (mark_backtrace): Move decl from here ...
2060 * lisp.h: ... to here, so that it can be checked.
2062 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2063 (Fdefvar): Rewrite so as not to use empty "else".
2064 (lisp_indirect_variable): Name an expression,
2065 to avoid gcc -Wbad-function-cast warning.
2066 (Fdefvar): Rename locals to avoid shadowing.
2068 * callint.c (quotify_arg, quotify_args): Now static.
2069 (Fcall_interactively): Rename locals to avoid shadowing.
2070 Use const pointer when appropriate.
2072 * lisp.h (get_system_name, get_operating_system_release):
2073 Move decls here, to check interfaces.
2074 * process.c (get_operating_system_release): Move decl to lisp.h.
2075 * xrdb.c (get_system_name): Likewise.
2076 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2077 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2078 some of which prompt warnings from gcc -Wbad-function-cast.
2079 (Fformat_time_string, Fencode_time, Finsert_char):
2080 (Ftranslate_region_internal, Fformat):
2081 Rename or remove local vars to avoid shadowing.
2082 (Ftranslate_region_internal): Mark var as initialized.
2084 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2087 * lisp.h (eassert): Check that the argument compiles, even if
2088 ENABLE_CHECKING is not defined.
2090 * data.c (Findirect_variable): Name an expression, to avoid
2091 gcc -Wbad-function-cast warning.
2092 (default_value, arithcompare, arith_driver, arith_error): Now static.
2093 (store_symval_forwarding): Rename local to avoid shadowing.
2094 (Fmake_variable_buffer_local, Fmake_local_variable):
2095 Mark variables as initialized.
2096 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2098 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2099 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2100 Rename locals to avoid shadowing.
2101 (mark_stack): Move local variables into the #ifdef region where
2103 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2104 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2106 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2107 (GC_STRING_CHARS): Remove; not used.
2108 (Fmemory_limit): Cast sbrk's returned value to char *.
2110 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2111 avoids undefined behavior in theory.
2113 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2115 Use functions, not macros, for up- and down-casing (Bug#8254).
2116 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2117 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2118 to use the following functions instead of these macros.
2119 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2120 EMACS_INT, since callers assume the returned value fits in int.
2121 (upcase1): Likewise, for UPCASE_TABLE.
2122 (uppercasep, lowercasep, upcase): New static inline functions.
2123 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2124 the race-condition problem in the old DOWNCASE.
2126 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2127 Rename locals to avoid shadowing.
2128 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2129 (regex_compile, re_search_2, re_match_2_internal):
2130 Remove unused local vars.
2131 (FREE_VAR): Rewrite so as not to use empty "else",
2132 which gcc can warn about.
2133 (regex_compile, re_match_2_internal): Mark locals as initialized.
2134 (RETALLOC_IF): Define only if needed.
2135 (WORDCHAR_P): Likewise. This one is never needed, but is used
2136 only in a comment talking about a compiler bug, so put inside
2137 the #if 0 of that comment.
2138 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2139 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2142 * search.c (boyer_moore): Rename locals to avoid shadowing.
2143 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2144 (PREV_CHAR_BOUNDARY): Likewise.
2146 * search.c (simple_search): Remove unused var.
2148 * dired.c (compile_pattern): Move decl from here ...
2149 * lisp.h: ... to here, so that it can be checked.
2150 (struct re_registers): New forward decl.
2152 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2154 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2156 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2157 Rename locals to avoid shadowing.
2158 (Fvertical_motion): Mark locals as initialized.
2160 * casefiddle.c (casify_object, casify_region): Now static.
2161 (casify_region): Mark local as initialized.
2163 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2165 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2166 New macros, so that the caller can use some names other than
2167 gcpro1, gcpro2, etc.
2168 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2170 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2171 argument, for consistency with GCPRO2_VAR, etc: it is now the
2172 prefix of the variable, not the variable itself. All uses
2174 * dired.c (directory_files_internal, file_name_completion):
2175 Rename locals to avoid shadowing.
2177 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2178 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2179 dired.c's scmp function, had undefined behavior.
2180 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2181 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2182 * buffer.h: ... to here, because these macros use current_buffer,
2183 and the new implementation with inline functions needs to have
2184 current_buffer in scope now, rather than later when the macros
2186 (downcase, upcase1): New static inline functions.
2187 (DOWNCASE, UPCASE1): Reimplement using these functions.
2188 This avoids undefined behavior in expressions like
2189 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2190 from race conditions in accessing the global variables
2191 case_temp1 and case_temp2.
2192 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2193 * lisp.h (case_temp1, case_temp2): Remove their decls.
2194 * character.h (ASCII_CHAR_P): Move from here ...
2195 * lisp.h: ... to here, so that the inline functions mentioned
2198 * dired.c (directory_files_internal_unwind): Now static.
2200 * fileio.c (file_name_as_directory, directory_file_name):
2201 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2203 (file_name_as_directory): Use const pointers when appropriate.
2204 (Fexpand_file_name): Likewise. In particular, newdir might
2205 point at constant storage, so make it a const pointer.
2206 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2207 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2209 (Fset_file_times, Finsert_file_contents, auto_save_error):
2210 Rename locals to avoid shadowing.
2212 * minibuf.c (choose_minibuf_frame_1): Now static.
2213 (Ftry_completion, Fall_completions): Rename or remove locals
2216 * marker.c (bytepos_to_charpos): Remove; unused.
2218 * lisp.h (verify_bytepos, count_markers): New decls,
2219 so that gcc does not warn that these functions aren't declared.
2221 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2222 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2223 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2224 (copy_text): Remove unused local var.
2226 * filelock.c (within_one_second): Now static.
2227 (lock_file_1): Rename local to avoid shadowing.
2229 * buffer.c (fix_overlays_before): Mark locals as initialized.
2230 (fix_start_end_in_overlays): Likewise. This function should be
2231 simplified by using pointers-to-pointers, but that's a different
2233 (switch_to_buffer_1): Now static.
2234 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2235 (report_overlay_modification): Rename locals to avoid shadowing.
2237 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2238 Fix pointer signedness issue.
2239 (sys_subshell): Mark local as volatile if checking for lint,
2240 to suppress a gcc -Wclobbered warning that does not seem to be right.
2241 (MAXPATHLEN): Define only if needed.
2243 * process.c (serial_open, serial_configure): Move decls from here ...
2244 * systty.h: ... to here, so that they can be checked.
2246 * fns.c (get_random, seed_random): Move extern decls from here ...
2247 * lisp.h: ... to here, so that they can be checked.
2249 * sysdep.c (reset_io): Now static.
2250 (wait_for_termination_signal): Remove; unused.
2252 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2253 (copy_keymap_item, append_key, push_text_char_description):
2255 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2256 (DENSE_TABLE_SIZE): Remove; unused.
2257 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2258 (describe_map_tree):
2259 Rename locals to avoid shadowing.
2261 * keyboard.c: Declare functions static if they are not used elsewhere.
2262 (echo_char, echo_dash, cmd_error, top_level_2):
2263 (poll_for_input, handle_async_input): Now static.
2264 (read_char, kbd_buffer_get_event, make_lispy_position):
2265 (make_lispy_event, make_lispy_movement, apply_modifiers):
2266 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2267 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2268 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2269 (read_key_sequence, read_char): Mark locals as initialized.
2270 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2272 * keyboard.h (make_ctrl_char): New decl.
2273 (mark_kboards): Move decl here ...
2274 * alloc.c (mark_kboards): ... from here.
2276 * lisp.h (force_auto_save_soon): New decl.
2278 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2279 (DEFINE_DUMMY_FUNCTION): New macro.
2280 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2282 (main): Add casts to avoid warnings
2283 if GCC considers string literals to be constants.
2285 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2287 * dbusbind.c: Pointer signedness fixes.
2288 (xd_signature, xd_append_arg, xd_initialize):
2289 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2290 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2291 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2292 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2294 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2295 if GCC considers string literals to be constants.
2296 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2298 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2300 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2301 (print_preprocess, print_object): New macro to fix last change.
2303 * print.c (print_preprocess): Don't forget font objects.
2305 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2307 * emacs.c (USAGE3): Doc fixes.
2309 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2311 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2314 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2316 * lisp.h (VWindow_system, Qfile_name_history):
2317 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2318 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2319 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2321 * w32select.c: Don't #include "keyboard.h".
2322 (run_protected): Add extern declaration for waiting_for_input.
2324 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2325 * w32console.c (detect_input_pending, read_input_pending)
2326 (encode_terminal_code):
2327 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2328 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2329 (w32_system_caret_y, Qfile_name_history):
2330 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2331 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2332 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2333 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2334 * w32proc.c (Qlocal, report_file_error):
2335 * w32term.c (Vwindow_system, updating_frame):
2336 * w32uniscribe.c (initialized, uniscribe_font_driver):
2337 Remove unneeded extern declarations.
2339 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2341 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2343 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2345 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2346 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2347 These macros can no longer be used for assignment.
2349 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2350 Assign struct members directly, instead of using BUF_BEGV etc.
2351 (record_buffer_markers, fetch_buffer_markers): New functions for
2352 recording and fetching special buffer markers.
2353 (set_buffer_internal_1, set_buffer_temp): Use them.
2355 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2357 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2359 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2360 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2362 * xdisp.c (hscroll_window_tree):
2363 (reconsider_clip_changes): Use PT instead of BUF_PT.
2365 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2367 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2368 $(EMACS_ROOT)/lib/intprops.h.
2370 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2372 Fix more problems found by GCC 4.5.2's static checks.
2374 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2375 to unsigned char * to avoid compiler diagnostic.
2376 (xg_free_frame_widgets): Make it clear that a local variable is
2377 needed only if USE_GTK_TOOLTIP.
2378 (gdk_window_get_screen): Make it clear that this macro is needed
2379 only if USE_GTK_TOOLTIP.
2380 (int_gtk_range_get_value): New function, which avoids a diagnostic
2381 from gcc -Wbad-function-cast.
2382 (xg_set_toolkit_scroll_bar_thumb): Use it.
2383 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2384 diagnostic from gcc -Wbad-function-cast.
2385 (get_utf8_string, xg_get_file_with_chooser):
2386 Rename locals to avoid shadowing.
2387 (create_dialog): Move locals to avoid shadowing.
2389 * xgselect.c (xg_select): Remove unused var.
2391 * image.c (four_corners_best): Mark locals as initialized.
2392 (gif_load): Initialize transparent_p to zero (Bug#8238).
2393 Mark another local as initialized.
2394 (my_png_error, my_error_exit): Mark with NO_RETURN.
2396 * image.c (clear_image_cache): Now static.
2397 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2398 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2399 (x_edge_detection): Remove unnecessary cast that
2400 gcc -Wbad-function-cast diagnoses.
2401 (gif_load): Fix pointer signedness.
2402 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2403 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2405 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2407 Improve quality of tests for time stamp overflow.
2408 For example, without this patch (encode-time 0 0 0 1 1
2409 1152921504606846976) returns the obviously-bogus value (-948597
2410 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2411 reports time overflow. See
2412 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2413 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2414 * editfns.c: Include limits.h and intprops.h.
2415 (TIME_T_MIN, TIME_T_MAX): New macros.
2416 (time_overflow): Move earlier, to before first use.
2417 (hi_time, lo_time): New functions, for an accurate test for
2419 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2420 (Fget_internal_run_time): Don't assume time_t fits in int.
2421 (make_time): Use list2 instead of Fcons twice.
2422 (Fdecode_time): More accurate test for out-of-range times.
2423 (check_tm_member): New function.
2424 (Fencode_time): Use it, to test for out-of-range times.
2425 (lisp_time_argument): Don't rely on undefined left-shift and
2426 right-shift behavior when checking for time stamp overflow.
2428 * editfns.c (time_overflow): New function, refactoring common code.
2429 (Fformat_time_string, Fdecode_time, Fencode_time):
2430 (Fcurrent_time_string): Use it.
2432 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2433 * dired.c (make_time): Move to ...
2434 * editfns.c (make_time): ... here.
2435 * systime.h: Note the move.
2437 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2439 * fringe.c (update_window_fringes): Remove unused variables.
2441 * unexmacosx.c (copy_data_segment): Also copy __got section.
2444 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2446 * termcap.c [MSDOS]: Include "msdos.h".
2447 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2448 Constify `char *' arguments and their references according to
2449 prototypes in tparam.h.
2451 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2453 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2454 Adapt all references accordingly.
2456 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2458 2011-03-11 Tom Tromey <tromey@redhat.com>
2460 * buffer.c (syms_of_buffer): Remove obsolete comment.
2462 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2464 * termhooks.h (encode_terminal_code): Declare prototype.
2466 * msdos.c (encode_terminal_code): Don't declare prototype.
2468 * term.c (encode_terminal_code): Now external again, used by
2469 w32console.c and msdos.c.
2471 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2472 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2474 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2476 Fix some minor problems found by GCC 4.5.2's static checks.
2478 * fringe.c (update_window_fringes): Mark locals as initialized
2480 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2482 * alloc.c (mark_fringe_data): Move decl from here ...
2483 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2484 to check its interface.
2485 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2487 * fontset.c (free_realized_fontset): Now static.
2488 (Fset_fontset_font): Rename local to avoid shadowing.
2489 (fontset_font): Mark local as initialized.
2490 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2492 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2494 * xselect.c (x_disown_buffer_selections): Remove; not used.
2495 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2496 (x_own_selection, Fx_disown_selection_internal): Rename locals
2498 (x_handle_dnd_message): Remove local to avoid shadowing.
2500 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2501 so that the caller can use some name other than gcpro1.
2502 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2503 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2504 (Fx_backspace_delete_keys_p):
2505 Use them to avoid shadowing, and rename vars to avoid shadowing.
2506 (x_decode_color, x_set_name, x_window): Now static.
2507 (Fx_create_frame): Add braces to silence GCC warning.
2508 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2509 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2510 Remove unused locals.
2511 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2512 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2513 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2516 * xterm.h (x_mouse_leave): New decl.
2518 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2519 Remove unused functions.
2520 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2521 (x_calc_absolute_position): Now static.
2522 (XTread_socket): Don't define label "out" unless it's used.
2523 Don't declare local "event" unless it's used.
2524 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2525 unless they are used.
2526 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2527 (x_fatal_error_signal): Remove; not used.
2528 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2529 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2530 (x_error_catcher, x_connection_closed, x_error_handler):
2531 (x_error_quitter, xembed_send_message, x_iconify_frame):
2532 (my_log_handler): Rename locals to avoid shadowing.
2533 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2534 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2536 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2537 Rename or move locals to avoid shadowing.
2538 (tty_defined_color, merge_face_heights): Now static.
2539 (free_realized_faces_for_fontset): Remove; not used.
2540 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2541 does not deduce is never used uninitialized.
2542 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2543 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2545 * terminal.c (store_terminal_param): Now static.
2547 * xmenu.c (menu_highlight_callback): Now static.
2548 (set_frame_menubar): Remove unused local.
2549 (xmenu_show): Rename parameter to avoid shadowing.
2550 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2551 since they might point to immutable storage.
2552 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2553 since it's unused otherwise.
2555 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2556 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2557 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2558 avoids a gcc -Wuninitialized diagnostic.
2559 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2560 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2561 does not deduce are never used uninitialized.
2563 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2565 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2566 * window.c (window_loop, size_window):
2567 (run_window_configuration_change_hook, enlarge_window): Likewise.
2569 * window.c (display_buffer): Now static.
2570 (size_window): Mark variables that gcc -Wuninitialized
2571 does not deduce are never used uninitialized.
2572 * window.h (check_all_windows): New decl, to forestall
2573 gcc -Wmissing-prototypes diagnostic.
2574 * dispextern.h (bidi_dump_cached_states): Likewise.
2576 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2578 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2580 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2581 and to avoid gcc -Wuninitialized warning.
2582 (load_charset_map): Mark variables that gcc -Wuninitialized
2583 does not deduce are never used uninitialized.
2584 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2586 * coding.c (coding_set_source, coding_set_destination):
2587 Use "else { /* comment */ }" rather than "else /* comment */;"
2588 for clarity, and to avoid gcc -Wempty-body warning.
2589 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2590 a block, when the outer 'i' will do.
2591 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2592 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2593 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2594 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2595 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2596 Rename locals to avoid shadowing.
2597 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2598 * coding.c (emacs_mule_char, encode_invocation_designation):
2599 Now static, since they're not used elsewhere.
2600 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2601 (decode_coding_object, encode_coding_object, detect_coding_system):
2602 (decode_coding_emacs_mule): Mark variables that gcc
2603 -Wuninitialized does not deduce are never used uninitialized.
2604 (detect_coding_iso_2022): Initialize a local variable that might
2605 be used uninitialized. Leave a FIXME because it's not clear that
2606 this initialization is needed. (Bug#8211)
2607 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2608 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2609 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2610 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2611 Remove unused macros.
2613 * category.c (hash_get_category_set): Remove unused local var.
2614 (copy_category_table): Now static, since it's not used elsewhere.
2615 * character.c (string_count_byte8): Likewise.
2617 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2618 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2620 * chartab.c (copy_sub_char_table): Now static, since it's not used
2622 (sub_char_table_ref_and_range, char_table_ref_and_range):
2623 Rename locals to avoid shadowing.
2624 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2626 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2627 (BIDI_BOB): Remove unused macro.
2629 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2630 deduce are never used uninitialized.
2631 * term.c (encode_terminal_code): Likewise.
2633 * term.c (encode_terminal_code): Now static. Remove unused local.
2635 * tparam.h: New file.
2636 * term.c, tparam.h: Include it.
2637 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2638 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2639 Move these decls to tparam.h, and make them agree with what
2640 is actually in tparam.c. The previous trick of using incompatible
2641 decls in different modules does not conform to the C standard.
2642 All callers of tparam changed to use tparam's actual API.
2643 * tparam.c (tparam1, tparam, tgoto):
2644 Use const pointers where appropriate.
2646 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2647 * cm.h (struct cm): Likewise.
2648 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2649 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2650 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2651 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2652 (turn_on_face, init_tty): Likewise.
2653 * termchar.h (struct tty_display_info): Likewise.
2655 * term.c (term_mouse_position): Rename local to avoid shadowing.
2657 * alloc.c (mark_ttys): Move decl from here ...
2658 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2660 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2662 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2664 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2666 * search.c (compile_pattern_1): Remove argument regp, unused since
2667 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2668 (compile_pattern): Don't pass it.
2670 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2672 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2673 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2675 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2677 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2679 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2680 gdk_window_get_screen, gdk_window_get_geometry,
2681 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2682 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2683 (xg_get_pixbuf_from_pixmap): New function.
2684 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2685 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2686 Call xg_get_pixbuf_from_pixmap instead of
2687 gdk_pixbuf_get_from_drawable.
2688 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2689 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2690 (xg_check_special_colors): Use GtkStyleContext and its functions
2692 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2693 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2694 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2695 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2696 Call gtk_widget_get_preferred_size.
2697 (xg_frame_resized): gdk_window_get_geometry only takes 5
2699 (xg_win_to_widget, xg_event_is_for_menubar):
2700 Call gdk_x11_window_lookup_for_display.
2701 (xg_set_widget_bg): New function.
2702 (delete_cb): New function.
2703 (xg_create_frame_widgets): connect delete-event to delete_cb.
2704 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2705 (xg_set_background_color): Call xg_set_widget_bg.
2706 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2707 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2708 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2709 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2711 (update_frame_tool_bar): Call gtk_widget_hide.
2712 (xg_initialize): Use GDK_KEY_g.
2714 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2716 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2718 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2719 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2720 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2722 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2724 * w32xfns.c (select_palette): Check success of RealizePalette against
2725 GDI_ERROR, not zero.
2727 See ChangeLog.11 for earlier changes.
2733 Copyright (C) 2011 Free Software Foundation, Inc.
2735 This file is part of GNU Emacs.
2737 GNU Emacs is free software: you can redistribute it and/or modify
2738 it under the terms of the GNU General Public License as published by
2739 the Free Software Foundation, either version 3 of the License, or
2740 (at your option) any later version.
2742 GNU Emacs is distributed in the hope that it will be useful,
2743 but WITHOUT ANY WARRANTY; without even the implied warranty of
2744 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2745 GNU General Public License for more details.
2747 You should have received a copy of the GNU General Public License
2748 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.