]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* alloc.c (Fgc_status): Do not access beyond zombies array
[gnu-emacs] / src / ChangeLog
1 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * alloc.c (Fgc_status): Do not access beyond zombies array
4 boundary if nzombies > MAX_ZOMBIES.
5 * alloc.c (dump_zombies): Add missing format specifier.
6
7 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
8
9 * xdisp.c (set_cursor_from_row): Simplify conditionals,
10 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
11
12 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
13 Some packages use them to denote characters with modifiers.
14
15 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
16
17 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
18 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
19 matching a pp-number. Rename parameter var to var1.
20
21 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
22
23 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
24
25 2011-10-08 Glenn Morris <rgm@gnu.org>
26
27 * callint.c (Fcall_interactively): Give a more explicit error for the
28 'c' case with a non-character input. (Bug#8479)
29
30 2011-10-08 Eli Zaretskii <eliz@gnu.org>
31
32 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
33 lines.
34 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
35 lines that are hscrolled on the left.
36
37 * dispnew.c (buffer_posn_from_coords): Account for a possible
38 presence of header-line. (Bug#4426)
39
40 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
41
42 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
43 advertise functionality which we discourage or doesn't work.
44
45 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
46
47 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
48 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
49 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
50 this makes Emacs dump core during garbage collection on rare
51 occasions. sizeof is obviously inferior to offsetof here, so
52 stick with offsetof.
53 (GC_POINTER_ALIGNMENT): New macro.
54 (mark_memory): Omit 3rd (offset) arg; caller changed.
55 Don't assume EMACS_INT alignment is the same as pointer alignment.
56
57 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
58
59 * keyboard.c (read_key_sequence_remapped): New var.
60 (read_key_sequence): Compute remapping in the right buffer.
61 (command_loop_1): Use read_key_sequence's remapping directly.
62
63 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
64
65 * dired.c (file_name_completion): Don't expand file name.
66 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
67 before checking file name handler.
68
69 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
70 they've been requested explicitly (bug#9591).
71
72 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
73
74 * keymap.c (Fsingle_key_description): Use make_specified_string
75 instead of build_string to build string from push_key_description.
76 (Bug#5193)
77
78 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
79
80 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
81 This fixes a Y2038 bug on 64-bit hosts.
82 * buffer.c (reset_buffer):
83 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
84 (Fclear_buffer_auto_save_failure):
85 Use 0, not -1, to represent an unset failure time, since time_t
86 might not be signed.
87
88 Remove dependency on glibc malloc internals.
89 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
90 Move back here from lisp.h, but with their new implementations.
91 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
92 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
93 * charset.c (charset_table_init): New static var.
94 (syms_of_charset): Use it instead of xmalloc. This removes a
95 dependency on glibc malloc internals. See Eli Zaretskii's comment in
96 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
97 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
98 Move back to alloc.c.
99 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
100 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
101
102 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
103
104 * nsterm.m (windowDidResize): Call x_set_window_size only when
105 ns_in_resize is true. Otherwise set pixelwidth/height and
106 call change_frame_size (Bug#9628).
107
108 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
109
110 Port --enable-checking=all to Fedora 14 x86-64.
111 * charset.c (syms_of_charset): Also account for glibc malloc's
112 internal overhead when calculating the initial malloc maximum.
113
114 Port --enable-checking=all to Fedora 14 x86.
115 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
116 Move to lisp.h.
117 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
118 (overrun_check_realloc, overrun_check_free):
119 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
120 That way, xmalloc returns a properly-aligned pointer even if
121 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
122 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
123 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
124 into account when calculating the initial malloc maximum.
125 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
126 Move here from alloc.c, so that charset.c can use it too.
127 Properly align; the old code wasn't right for common 32-bit hosts
128 when configured with --enable-checking=all.
129 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
130 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
131
132 2011-09-29 Eli Zaretskii <eliz@gnu.org>
133
134 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
135 use EDOM.
136
137 2011-09-28 Eli Zaretskii <eliz@gnu.org>
138
139 * xdisp.c (compute_display_string_end): If there's no display
140 string at CHARPOS, return -1.
141
142 * bidi.c (bidi_fetch_char): When compute_display_string_end
143 returns a negative value, treat the character as a normal
144 character not covered by a display string. (Bug#9624)
145
146 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
147
148 * lread.c (Fread_from_string): Fix typo in docstring.
149
150 2011-09-27 Eli Zaretskii <eliz@gnu.org>
151
152 * xdisp.c (handle_invisible_prop): If invisible text ends on a
153 newline, reseat the iterator instead of bidi-iterating there one
154 character at a time. (Bug#9610)
155 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
156 TO_CHARPOS if the bidi iterator is at base embedding level.
157
158 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
159
160 * lread.c (readevalloop): Use correct code for NBSP.
161 (read1): Likewise. (Bug#9608)
162
163 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
164
165 * dbusbind.c (Fdbus_register_signal): When service is not
166 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
167
168 2011-09-25 Glenn Morris <rgm@gnu.org>
169
170 * buffer.c (truncate-lines): Doc fix.
171
172 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
173
174 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
175 (Fset_window_next_buffers): Doc fix.
176
177 2011-09-24 Glenn Morris <rgm@gnu.org>
178
179 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
180
181 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
182
183 Fix minor problems found by static checking.
184 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
185 * indent.c (Fvertical_motion): Fix == vs = typo.
186
187 2011-09-24 Eli Zaretskii <eliz@gnu.org>
188
189 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
190 Default value is now t. Doc fix.
191
192 * indent.c (Fvertical_motion): Compute and apply the overshoot
193 logic when moving up, not only when moving down. Fix the
194 confusing name and values of the it_overshoot_expected variable;
195 logic changes accordingly. (Bug#9254) (Bug#9549)
196
197 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
198 CHARPOS is covered by a display string which includes newlines.
199 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
200 is covered by a display string with embedded newlines.
201
202 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
203
204 * dbusbind.c (Fdbus_register_signal): Add match rule to
205 Vdbus_registered_objects_table. (Bug#9581)
206 (Fdbus_register_method, Vdbus_registered_objects_table):
207 Fix docstring.
208
209 2011-09-24 Jim Meyering <meyering@redhat.com>
210
211 do not ignore write error for any output size
212 The previous change was incomplete.
213 While it makes emacs --batch detect the vast majority of stdout
214 write failures, errors were still ignored whenever the output size is
215 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
216 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
217 && echo FAIL: ignored write error
218 FAIL: ignored write error
219 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
220 && echo FAIL: ignored write error
221 FAIL: ignored write error
222 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
223
224 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
225
226 * emacs.c (Fkill_emacs): In noninteractive mode exit
227 non-successfully if a write error occurred on stdout. (Bug#9574)
228
229 2011-09-21 Eli Zaretskii <eliz@gnu.org>
230
231 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
232 the xassert test.
233
234 * dispextern.h (struct it): Update the comment documenting what
235 can it->OBJECT be.
236
237 2011-09-20 Eli Zaretskii <eliz@gnu.org>
238
239 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
240 a display string, extend search for cursor position to end of row.
241 (find_row_edges): If the row ends in a newline from a display
242 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
243 Handle the case of a display string with multiple newlines.
244 (Fcurrent_bidi_paragraph_direction): Fix search for previous
245 non-empty line. Fixes confusing cursor motion with arrow keys at
246 the beginning of a line that starts with whitespace.
247
248 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
249
250 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
251 (bug#9493).
252
253 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
254
255 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
256 boolean (Bug#9154).
257
258 2011-09-18 Eli Zaretskii <eliz@gnu.org>
259
260 * xdisp.c (display_line): Record maximum and minimum buffer
261 positions even if no glyphs were produced (e.g., by a zero-width
262 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
263 buffer positions that will be removed from the glyph row because
264 they don't fit.
265 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
266 column is beyond frame width: don't subtract 1 "pixel" when
267 computing width of the stretch.
268 (reseat_at_next_visible_line_start): Undo the change made on
269 2011-09-17 that saved paragraph information and restored it after
270 the call to `reseat'. (Bug#9545)
271
272 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
273
274 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
275 and turn window cursor on if cleared (Bug#9415).
276
277 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
278
279 * search.c (boyer_moore): Take unibyte characters from pattern
280 literally. (Bug#9458)
281
282 2011-09-18 Eli Zaretskii <eliz@gnu.org>
283
284 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
285
286 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
287
288 Fix minor problem found by static checking.
289 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
290 initialized, to pacify gcc -Wuninitialized.
291
292 * fileio.c: Report proper errno when syscall falls.
293 (Finsert_file_contents): Save and restore errno,
294 so that report_file_error outputs the correct diagnostic.
295 (Fwrite_region) [CLASH_DETECTION]: Likewise.
296
297 2011-09-18 Eli Zaretskii <eliz@gnu.org>
298
299 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
300
301 2011-09-17 Eli Zaretskii <eliz@gnu.org>
302
303 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
304 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
305
306 2011-09-17 Eli Zaretskii <eliz@gnu.org>
307
308 * xdisp.c (reseat_at_next_visible_line_start): Keep information
309 about the current paragraph and restore it after the call to
310 reseat.
311
312 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
313 (bidi_find_paragraph_start): Search back for paragraph beginning
314 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
315 (bidi_move_to_visually_next): Only trigger paragraph-related
316 computations when the last character is a newline or at EOB, not
317 just any NEUTRAL_B. (Bug#9470)
318
319 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
320 truncated lines if point is covered by a display string. (Bug#9524)
321
322 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
323
324 * xselect.c: Relax test for outgoing X longs (Bug#9498).
325 (cons_to_x_long): New function.
326 (lisp_data_to_selection_data): Use it. Correct the test for
327 short-versus-long data; it was negated. Break out of vector
328 loop, for efficiency, when a long datum is discovered.
329
330 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
331
332 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
333
334 2011-09-16 Eli Zaretskii <eliz@gnu.org>
335
336 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
337 GCC PR/17406) by declaring this function with external scope.
338
339 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
340
341 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
342 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
343
344 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
345
346 * editfns.c (Fformat): Correctly handle text properties on "%%".
347
348 2011-09-15 Eli Zaretskii <eliz@gnu.org>
349
350 * xterm.c (x_draw_composite_glyph_string_foreground):
351 * w32term.c (x_draw_composite_glyph_string_foreground):
352 * term.c (encode_terminal_code):
353 * composite.c (composition_update_it, get_composition_id):
354 * xdisp.c (get_next_display_element)
355 (fill_composite_glyph_string): Add comments about special meaning
356 of TAB characters in a composition.
357
358 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
359
360 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
361 This occurs when processing a multibyte format.
362 Problem reported by Wolfgang Jenker.
363
364 2011-09-15 Johan Bockgård <bojohan@gnu.org>
365
366 * xdisp.c (try_cursor_movement): Only check for exact match if
367 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
368
369 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
370
371 Remove unused external symbols.
372 * dispextern.h (calc_pixel_width_or_height): Remove decl.
373 * xdisp.c (calc_pixel_width_or_height): Now static.
374 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
375 * indent.c (check_display_width):
376 * w32term.c: Fix comment to match code.
377 * xterm.c, xterm.h (x_catching_errors): Remove.
378
379 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
380
381 * xselect.c: Use signed conversions more consistently (Bug#9498).
382 (selection_data_to_lisp_data): Assume incoming selection data are
383 signed integers, not unsigned. This is to be consistent with
384 outgoing selection data, which was modified to use signed integers
385 in as part of the fix to Bug#9196 in response to Jan D.'s comment
386 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
387 expects long, not unsigned long.
388
389 2011-09-14 Eli Zaretskii <eliz@gnu.org>
390
391 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
392 computation of loop end. Reported by Johan Bockgård
393 <bojohan@gnu.org>.
394
395 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
396
397 * frame.c (Fother_visible_frames_p): Function deleted.
398
399 2011-09-12 Eli Zaretskii <eliz@gnu.org>
400
401 * indent.c (compute_motion): Process display vector front to back
402 rather than the other way around. (Bug#2496)
403
404 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
405
406 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
407
408 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
409
410 * minibuf.c (Fread_from_minibuffer): Doc fix.
411
412 2011-09-11 Eli Zaretskii <eliz@gnu.org>
413
414 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
415 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
416
417 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
418
419 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
420 value for non-existent files.
421
422 2011-09-11 Eli Zaretskii <eliz@gnu.org>
423
424 * fileio.c (Finsert_file_contents): If the file cannot be opened,
425 set its "size" to -1. This will set the modtime_size field of
426 the corresponding buffer to -1, which is what
427 verify-visited-file-modtime expects for files that do not exist.
428 (Bug#9139)
429
430 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
431
432 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
433 here ...
434 * lisp.h: ... from here. push_key_description is no longer
435 defined in keyboard.c, so its declaration should not be in
436 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
437 logically belongs with push_key_description.
438
439 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
440
441 * buffer.h: Include <sys/types.h> instead of <time.h>.
442 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
443 Problem reported by Herbert J. Skuhra.
444
445 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
446
447 * xml.c (parse_region): Make the parsing work for
448 non-comment-starting XML files again (bug#9144).
449
450 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
451
452 * image.c (gif_load): Fix calculation of bottom and right corner.
453 (Bug#9468)
454
455 2011-09-10 Eli Zaretskii <eliz@gnu.org>
456
457 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
458 redisplay in small windows.
459
460 2011-09-09 Eli Zaretskii <eliz@gnu.org>
461
462 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
463
464 2011-09-08 Martin Rudalics <rudalics@gmx.at>
465
466 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
467 Operate on live windows only.
468
469 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
470
471 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
472
473 2011-09-07 Eli Zaretskii <eliz@gnu.org>
474
475 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
476 only under bidi iteration.
477
478 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
479
480 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
481
482 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
483
484 isnan: Fix porting problem to Solaris 10 with bundled gcc.
485 Without this fix, the command to link temacs failed due to an
486 undefined symbol __builtin_isnan. This is because
487 /usr/include/iso/math_c99.h #defines isnan(x) to
488 __builtin_isnan(x), but the bundled gcc, which identifies itself
489 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
490 a __builtin_isnan.
491 * floatfns.c (isnan): #undef, and then #define to a clone of
492 what's in data.c.
493 (Fisnan): Always define, since it's always available now.
494 (syms_of_floatfns): Always define isnan at the Lisp level.
495
496 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
497
498 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
499
500 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
501
502 * fileio.c: Fix bugs with large file offsets (Bug#9428).
503 The previous code assumed that file offsets (off_t values) fit in
504 EMACS_INT variables, which is not true on typical 32-bit hosts.
505 The code messed up by falsely reporting buffer overflow in cases
506 such as (insert-file-contents "big" nil 1 2) into an empty buffer
507 when "big" contains more than 2**29 bytes, even though this
508 inserts just one byte and does not overflow the buffer.
509 (Finsert_file_contents): Store file offsets as off_t
510 values, not as EMACS_INT values. Check for overflow when
511 converting between EMACS_INT and off_t. When checking for
512 buffer overflow or for overlap, take the offsets into account.
513 Don't use EMACS_INT for small values where int suffices.
514 When checking for overlap, fix a typo: ZV was used where
515 ZV_BYTE was intended.
516 (Fwrite_region): Don't assume off_t fits into 'long'.
517 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
518
519 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
520
521 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
522
523 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
524
525 sprintf-related integer and memory overflow issues (Bug#9412).
526
527 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
528 (esprintf, exprintf, evxprintf): New functions.
529 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
530 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
531 (modify_event_symbol): Do not assume that the length of
532 name_alist_or_stem is safe to alloca and fits in int.
533 (Fexecute_extended_command): Likewise for function name and binding.
534 (Frecursion_depth): Wrap around reliably on integer overflow.
535 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
536 since some callers pass EMACS_INT values.
537 (Fsingle_key_description): Don't crash if symbol name contains more
538 than MAX_ALLOCA bytes.
539 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
540 (get_minibuffer): Arg is now EMACS_INT, not int.
541 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
542 (esprintf, exprintf, evxprintf): New decls.
543 * window.h (command_loop_level, minibuf_level): Reflect API changes.
544
545 * dbusbind.c (signature_cat): New function.
546 (xd_signature, Fdbus_register_signal):
547 Do not overrun buffer; instead, report string overflow.
548
549 * dispnew.c (add_window_display_history): Don't overrun buffer.
550 Truncate instead; this is OK since it's just a log.
551
552 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
553 even if the time zone offset is outlandishly large.
554 Don't mishandle offset == INT_MIN.
555
556 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
557 when creating daemon; the previous buffer-overflow check was incorrect.
558
559 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
560 which has the guts of the old verror function.
561
562 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
563 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
564
565 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
566 (font_unparse_xlfd): Don't blindly alloca long strings.
567 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
568 fits in int, when using sprintf. Use single snprintf to count
569 length of string rather than counting it via multiple sprintfs;
570 that's simpler and more reliable.
571 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
572 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
573 sprintf, in case result does not fit in int.
574
575 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
576 (fontset_from_font): Print it.
577
578 * frame.c (tty_frame_count): Now printmax_t, not int.
579 (make_terminal_frame, set_term_frame_name): Print it.
580 (x_report_frame_params): In X, window IDs are unsigned long,
581 not signed long, so print them as unsigned.
582 (validate_x_resource_name): Check for implausibly long names,
583 and don't assume name length fits in 'int'.
584 (x_get_resource_string): Don't blindly alloca invocation name;
585 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
586 not fit in int.
587
588 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
589 (xg_check_special_colors, xg_set_geometry):
590 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
591
592 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
593 Use esprintf, not sprintf, in case result does not fit in int.
594
595 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
596 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
597 it as a large positive number.
598 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
599 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
600
601 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
602 in case result does not fit in int.
603
604 * print.c (float_to_string): Detect width overflow more reliably.
605 (print_object): Make sprintf buffer a bit bigger, to avoid potential
606 buffer overrun. Don't assume list length fits in 'int'. Treat
607 print length of 0 as 0, not as infinity; to be consistent with other
608 uses of print length in this function. Don't overflow print length
609 index. Don't assume hash table size fits in 'long', or that
610 vectorlike size fits in 'unsigned long'.
611
612 * process.c (make_process): Use printmax_t, not int, to format
613 process-name gensyms.
614
615 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
616
617 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
618 to avoid potential buffer overrun.
619
620 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
621 if X resource line is longer than 512 bytes.
622
623 * xfns.c (x_window): Make sprintf buffer a bit bigger
624 to avoid potential buffer overrun.
625
626 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
627
628 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
629
630 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
631
632 Integer overflow fixes for scrolling, etc.
633 Without these, Emacs silently mishandles large integers sometimes.
634 For example, "C-u 4294967297 M-x recenter" was treated as if
635 it were "C-u 1 M-x recenter" on a typical 64-bit host.
636
637 * xdisp.c (try_window_id): Check Emacs fixnum range before
638 converting to 'int'.
639
640 * window.c (window_scroll_line_based, Frecenter):
641 Check that an Emacs fixnum is in range before assigning it to 'int'.
642 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
643 values converted from Emacs fixnums.
644 (Frecenter): Don't wrap around a line count if it is out of 'int'
645 range; instead, treat it as an extreme value.
646 (Fset_window_configuration, compare_window_configurations):
647 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
648
649 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
650 that can exceed INT_MAX. Check that EMACS_INT value is in range
651 before assigning it to the (possibly-narrower) index.
652 (match_limit): Don't assume that a fixnum can fit in 'int'.
653
654 * print.c (print_object): Use ptrdiff_t, not int, for index that can
655 exceed INT_MAX.
656
657 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
658 (Fvertical_motion): Don't wrap around LINES values that don't fit
659 in 'int'. Instead, treat them as extreme values. This is good
660 enough for windows, which can't have more than INT_MAX lines anyway.
661
662 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
663
664 * Require libxml/parser.h to avoid compilation warning.
665
666 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
667
668 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
669 since this reportedly can destroy thread storage.
670
671 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
672
673 * syntax.c (find_defun_start): Update all cache variables if
674 exiting early (Bug#9401).
675
676 2011-08-30 Eli Zaretskii <eliz@gnu.org>
677
678 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
679
680 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
681 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
682 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
683
684 * term.c (tty_append_glyph): New function.
685 (produce_stretch_glyph): Static function and its prototype deleted.
686
687 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
688 Add prototypes.
689
690 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
691
692 * image.c (parse_image_spec): Check for nonnegative, not for positive,
693 when checking :margin (Bug#9390).
694 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
695 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
696 so that the name doesn't mislead. All uses changed.
697
698 2011-08-28 Johan Bockgård <bojohan@gnu.org>
699
700 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
701 set_tty_hooks.
702
703 2011-08-27 Eli Zaretskii <eliz@gnu.org>
704
705 * xdisp.c (move_it_to): Don't bail out early when reaching
706 position beyond to_charpos, if we are scanning backwards.
707 (move_it_vertically_backward): When DY == 0, make sure we get to
708 the first character in the line after the newline.
709
710 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
711
712 * ccl.c: Improve and simplify overflow checking (Bug#9196).
713 (ccl_driver): Do not generate an out-of-range pointer.
714 (Fccl_execute_on_string): Remove unnecessary check for
715 integer overflow, noted by Stefan Monnier in
716 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
717 Remove a FIXME that didn't need fixing.
718 Simplify the newly-introduced buffer reallocation code.
719
720 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
721
722 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
723
724 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
725
726 Integer and memory overflow issues (Bug#9196).
727
728 * doc.c (get_doc_string): Rework so that
729 get_doc_string_buffer_size is the actual buffer size, rather than
730 being 1 less than the actual buffer size; this makes xpalloc more
731 convenient.
732
733 * image.c (x_allocate_bitmap_record, cache_image):
734 * xselect.c (Fx_register_dnd_atom):
735 Simplify previous changes by using xpalloc.
736
737 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
738 since either will do and ptrdiff_t is convenient with xpalloc.
739
740 * charset.c (charset_table_size)
741 (struct charset_sort_data.priority): Now ptrdiff_t.
742 (charset_compare): Don't overflow if priorities differ greatly.
743 (Fsort_charsets): Don't assume list length fits in int.
744 Check for size-calculation overflow when allocating sort data.
745 (syms_of_charset): Allocate an initial charset table that is
746 just under 64 KiB, to avoid problems with glibc malloc and mmap.
747
748 * cmds.c (internal_self_insert): Check for size-calculation overflow.
749
750 * composite.h (struct composition.glyph_len): Now int, not unsigned.
751 The actual value is always <= INT_MAX, and leaving it unsigned made
752 overflow checking harder.
753
754 * dispextern.h (struct glyph_matrix.rows_allocated)
755 (struct face_cache.size): Now ptrdiff_t, for convenience in use
756 with xpalloc. The values are still always <= INT_MAX.
757
758 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
759
760 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
761 (SAFE_NALLOCA): New macro.
762
763 * region-cache.c (struct boundary.pos, find_cache_boundary)
764 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
765 (set_cache_region, invalidate_region_cache)
766 (revalidate_region_cache, know_region_cache, region_cache_forward)
767 (region_cache_backward, pp_cache):
768 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
769 so that ptrdiff_t * can be passed to xpalloc.
770 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
771 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
772 (pp_cache): Don't assume cache_len fits in int.
773 * region-cache.h: Adjust extern decls to match.
774
775 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
776 EMACS_INT, since either will do, for xpalloc.
777
778 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
779 (xnmalloc, xnrealloc, xpalloc): New functions.
780
781 * bidi.c (bidi_shelve_header_size): New constant.
782 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
783 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
784
785 * bidi.c (bidi_cache_shrink):
786 * buffer.c (overlays_at, overlays_in, record_overlay_string)
787 (overlay_strings):
788 Don't update size of array until after memory allocation succeeds,
789 because xmalloc/xrealloc may not return.
790 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
791 now that we have proper integer overflow checking.
792 (record_overlay_string, overlay_strings): Catch overflows when
793 calculating size of overlay_str_buf.
794
795 * callproc.c (Fcall_process): Check for size overflow when
796 calculating size of args2.
797 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
798 Normally we prefer signed values, but sticking with ptrdiff_t would
799 require adding more-complicated checks.
800
801 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
802 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
803 Redo buffer-overflow calculations to avoid integer overflow.
804 Add a FIXME comment where memory seems to be over-allocated.
805
806 * character.c (Fstring): Check for size-calculation overflow.
807
808 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
809 unnecessary integer overflow. Check for size overflow.
810 (encode_coding_object): Don't update size until xmalloc succeeds.
811
812 * composite.c (get_composition_id): Check for overflow in glyph
813 length calculations.
814
815 Integer and memory overflow fixes for display code.
816 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
817 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
818 (scrolling_window): Check for overflow in size calculations.
819 (line_draw_cost, realloc_glyph_pool, add_row_entry):
820 Don't assume glyph table len fits in int.
821 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
822 (row_table_size): Now ptrdiff_t, not int.
823 (scrolling_window): Avoid overflow in size calculations.
824 Don't update size until allocation succeeds.
825 * fns.c (concat): Check for overflow in size calculations.
826 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
827 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
828 (NEXT_ALMOST_PRIME_LIMIT): New constant.
829
830 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
831 (get_doc_string): Check for size calculation overflow.
832 Don't update size until allocation succeeds.
833 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
834 EMACS_INT, where ptrdiff_t will do.
835 (Fsubstitute_command_keys): Check for string overflow.
836
837 * editfns.c (set_time_zone_rule): Don't assume environment length
838 fits in int.
839 (message_length): Now ptrdiff_t, not int.
840 (Fmessage_box): Don't update size until allocation succeeds.
841 Don't assume message length fits in int.
842 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
843
844 * emacs.c (main): Do not reallocate argv, since there is a null at
845 the end that can be overwritten, and this way there's no need to
846 worry about size-calculation overflow.
847 (sort_args): Check for size-calculation overflow.
848
849 * eval.c (init_eval_once, grow_specpdl): Don't update size until
850 alloc succeeds.
851 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
852
853 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
854 (x_set_scroll_bar_width, x_figure_window_size):
855 Check for integer overflow.
856 (x_set_alpha): Do not assume XINT fits in int.
857
858 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
859 This is for the members text_lines, text_cols, total_lines, total_cols,
860 where the system imposes an 'int' limit.
861
862 * fringe.c (Fdefine_fringe_bitmap):
863 Don't update size until alloc works.
864
865 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
866 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
867
868 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
869 Check for size-calculation overflow.
870 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
871 do, as we prefer signed integers.
872 (id_to_widget.max_size, id_to_widget.used)
873 (xg_store_widget_in_map, xg_remove_widget_from_map)
874 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
875 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
876 Use and return ptrdiff_t, not int.
877 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
878 * gtkutil.h: Change prototypes to match the above.
879
880 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
881 are duplicate now that they've been promoted to lisp.h.
882 (x_allocate_bitmap_record, x_alloc_image_color)
883 (make_image_cache, cache_image, xpm_load):
884 Don't update size until alloc is done.
885 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
886 (x_detect_edges):
887 Check for size calculation overflow.
888 (ct_colors_allocated_max): New constant.
889 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
890 overflow.
891
892 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
893 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
894 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
895 Use ptrdiff_t, not int, to count maps.
896 (read_char_minibuf_menu_prompt): Check for overflow in size
897 calculations. Don't update size until allocation succeeds.
898 Redo calculations to avoid overflow.
899 * keyboard.h: Change prototypes to match the above.
900
901 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
902 to count maps.
903 (current_minor_maps): Check for size calculation overflow.
904 * keymap.h: Change prototypes to match the above.
905
906 * lread.c (read1, init_obarray): Don't update size until alloc done.
907
908 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
909 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
910
911 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
912 Now ptrdiff_t, not int.
913 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
914 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
915
916 * process.c (Fnetwork_interface_list): Check for overflow
917 in size calculation.
918
919 * region-cache.c (move_cache_gap): Check for size calculation overflow.
920
921 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
922 overflow. Don't bother calling xmalloc when xrealloc will do.
923
924 * search.c (Freplace_match): Check for size calculation overflow.
925 (Fset_match_data): Don't assume list lengths fit in 'int'.
926
927 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
928 for command line length. Do not attempt to address one before the
929 beginning of an array, as that's not portable.
930
931 * term.c (max_frame_lines): Remove; unused.
932 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
933 not int.
934 (encode_terminal_code, calculate_costs): Check for size
935 calculation overflow.
936 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
937 table lengths and related sizes. Don't update size until alloc
938 done. Redo calculations to avoid overflow.
939 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
940
941 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
942 subtracting pointers.
943 (gobble_line): Check for overflow more carefully. Don't update size
944 until alloc done.
945
946 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
947 Don't update size until alloc done.
948 Redo size calculations to avoid overflow.
949 Check for size calculation overflow.
950 (main) [DEBUG]: Fix typo in invoking tparam1.
951
952 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
953 Use ptrdiff_t, not int, for sizes.
954 (store_mode_line_noprop_char): Don't update size until alloc done.
955
956 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
957 Use ptrdiff_t, not int, for sizes.
958 (Finternal_make_lisp_face, cache_face):
959 Check for size calculation overflow.
960 (cache_face): Treat size calculation overflows as if they were
961 memory exhaustion (the usual treatment), rather than aborting.
962
963 * xfns.c (x_encode_text, x_set_name_internal)
964 (Fx_change_window_property): Use ptrdiff_t, not int, to count
965 sizes, since they can exceed INT_MAX in size. Check for size
966 calculation overflow.
967
968 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
969 (xg_select): Check for size calculation overflow.
970 Don't update size until alloc done.
971
972 * xrdb.c (get_environ_db): Don't assume path length fits in int,
973 as sprintf is limited to int lengths.
974
975 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
976 (X_LONG_MIN): New macros.
977 Use them to make the following changes clearer.
978 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
979 This change doesn't affect the value now, but it may help remind
980 future maintainers not to raise the value too much later.
981 (SELECTION_QUANTUM): Remove, replacing with ...
982 (selection_quantum): ... new function, which avoids overflow.
983 All uses changed.
984 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
985 assumption that selection length fits in 'int'.
986 (x_reply_selection_request, x_handle_selection_request)
987 (x_get_window_property, receive_incremental_selection)
988 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
989 (lisp_data_to_selection_data, clean_local_selection_data):
990 Use ptrdiff_t, not int, to record length of selection.
991 (x_reply_selection_request, x_get_window_property)
992 (receive_incremental_selection, x_property_data_to_lisp):
993 Redo calculations to avoid overflow.
994 (x_reply_selection_request): When sending hint, ceiling it at
995 X_LONG_MAX rather than relying on wraparound overflow to send
996 something.
997 (x_get_window_property, receive_incremental_selection)
998 (lisp_data_to_selection_data, x_property_data_to_lisp):
999 Check for size-calculation overflow.
1000 (x_get_window_property, receive_incremental_selection)
1001 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1002 Don't store size until memory allocation succeeds.
1003 (x_get_window_property): Plug memory leak on memory exhaustion.
1004 Don't double-block input; malloc is safe here. Don't assume 2**34
1005 - 4 fits in unsigned long. Add an xassert to check
1006 XGetWindowProperty overflow. Be more careful about overflow
1007 calculations, and distinguish size from memory overflow better.
1008 (receive_incremental_selection): When tracing, don't assume
1009 unsigned int is less than INT_MAX.
1010 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1011 harmful) conversions of unsigned short to int.
1012 (lisp_data_to_selection_data): Don't assume that integers
1013 in the range -65535 through -1 fit in an X unsigned short.
1014 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1015 result parameters unless successful. Rely on cons_to_unsigned
1016 to report problems with elements; the old code wasn't right anyway.
1017 (x_check_property_data): Check for int overflow; we cannot use
1018 a wider type due to X limits.
1019 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1020
1021 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1022
1023 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1024 (x_term_init): Check for size calculation overflow.
1025 (x_color_cells): Don't store size until memory allocation succeeds.
1026 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1027 Don't assume alloca size is less than MAX_ALLOCA.
1028 (x_term_init): Don't assume length fits in int (sprintf is limited
1029 to int size).
1030
1031 Use ptrdiff_t for composition IDs.
1032 * character.c (lisp_string_width):
1033 * composite.c (composition_table_size, n_compositions)
1034 (get_composition_id, composition_gstring_from_id):
1035 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1036 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1037 * window.c (Frecenter):
1038 Use ptrdiff_t, not int, for composition IDs.
1039 * composite.c (get_composition_id): Check for integer overflow.
1040 * composite.h: Adjust prototypes to match the above changes.
1041
1042 Use ptrdiff_t for hash table indexes.
1043 * category.c (hash_get_category_set):
1044 * ccl.c (ccl_driver):
1045 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1046 * coding.c (coding_system_charset_list, detect_coding_system):
1047 * coding.h (struct coding_system.id):
1048 * composite.c (get_composition_id, gstring_lookup_cache):
1049 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1050 * image.c (xpm_get_color_table_h):
1051 * lisp.h (hash_lookup, hash_put):
1052 * minibuf.c (Ftest_completion):
1053 Use ptrdiff_t for hash table indexes, not int (which is too
1054 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1055 32-bit --with-wide-int hosts).
1056
1057 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1058 Add a FIXME comment about memory leaks.
1059 (syms_of_charset): Don't assume xmalloc returns.
1060
1061 Don't assume that stated character widths fit in int.
1062 * character.c (Fchar_width, c_string_width, lisp_string_width):
1063 * character.h (CHAR_WIDTH):
1064 * indent.c (MULTIBYTE_BYTES_WIDTH):
1065 Use sanitize_char_width to avoid undefined and/or bad behavior
1066 with outlandish widths.
1067 * character.h (sanitize_tab_width): Rename from sanitize_width,
1068 now that we have two such functions. All uses changed.
1069 (sanitize_char_width): New inline function.
1070
1071 Don't assume that tab-width fits in int.
1072 * character.h (sanitize_width): New inline function.
1073 (SANE_TAB_WIDTH): New macro.
1074 (ASCII_CHAR_WIDTH): Use it.
1075 * indent.c (sane_tab_width): Remove. All uses replaced by
1076 SANE_TAB_WIDTH (current_buffer).
1077 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1078
1079 * fileio.c: Integer overflow issues with file modes.
1080 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1081
1082 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1083 Remove unreachable code.
1084 (read_hex, load_charset_map_from_file): Check for integer overflow.
1085
1086 * xterm.c: don't go over XClientMessageEvent limit
1087 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1088 (x_send_scroll_bar_event): Likewise. Check that the size does not
1089 exceed limits imposed by XClientMessageEvent, as well as the usual
1090 ptrdiff_t and size_t limits.
1091
1092 * keyboard.c: Overflow, signedness and related fixes.
1093 (make_lispy_movement): Use same integer type in forward decl
1094 that is used in the definition.
1095 (read_key_sequence, keyremap_step):
1096 Change bufsize argument back to int, undoing my 2011-03-30 change.
1097 We prefer signed types, and int is wide enough here.
1098 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1099 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1100 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1101 length, not size_t. Use ptrdiff_t for index, not int.
1102 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1103 possibility of integer overflow.
1104
1105 Overflow, signedness and related fixes for images.
1106
1107 * dispextern.h (struct it.stack[0].u.image.image_id)
1108 (struct_it.image_id, struct image.id, struct image_cache.size)
1109 (struct image_cache.used, struct image_cache.ref_count):
1110 * gtkutil.c (update_frame_tool_bar):
1111 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1112 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1113 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1114 * nsmenu.m (update_frame_tool_bar):
1115 * xdisp.c (calc_pixel_width_or_height):
1116 * xfns.c (image_cache_refcount):
1117 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1118 on typical 64-bit hosts.
1119
1120 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1121 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1122 Omit unnecessary casts to int.
1123 (parse_image_spec): Check that integers fall into 'int' range
1124 when the callers expect that.
1125 (image_ascent): Redo ascent calculation to avoid int overflow.
1126 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1127 (lookup_image): Remove unnecessary tests.
1128 (xbm_image_p): Locals are now of int, not EMACS_INT,
1129 since parse_image_check makes sure they fit into int.
1130 (png_load, gif_load, svg_load_image):
1131 Prefer int to unsigned where either will do.
1132 (tiff_handler): New function, combining the cores of the
1133 old tiff_error_handler and tiff_warning_handler.
1134 This function is rewritten to use vsnprintf and thereby avoid
1135 stack buffer overflows. It uses only the features of vsnprintf
1136 that are common to both POSIX and native Microsoft.
1137 (tiff_error_handler, tiff_warning_handler): Use it.
1138 (tiff_load, gif_load, imagemagick_load_image):
1139 Don't assume :index value fits in 'int'.
1140 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1141 (imagemagick_load_image): Check that crop parameters fit into
1142 the integer types that MagickCropImage accepts. Don't assume
1143 Vimagemagick_render_type has a nonnegative value. Don't assume
1144 size_t fits in 'long'.
1145 (gs_load): Use printmax_t to print the widest integers possible.
1146 Check for integer overflow when computing image height and width.
1147
1148 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1149
1150 * xdisp.c (redisplay_window): Don't force window start if point
1151 will be invisible in the resulting window. (Bug#9324)
1152
1153 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1154
1155 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1156 the display spec is of the form `(space ...)'.
1157 (handle_display_spec): Return the value returned by
1158 handle_single_display_spec, not just 1 or zero.
1159 (handle_single_display_spec): If the display spec is of the form
1160 `(space ...)', and specifies display in the text area, return 2
1161 rather than 1.
1162 (try_cursor_movement): Check for the need to scroll more
1163 accurately, and prefer exact match for point under bidi.
1164 Don't advance `row' beyond the last row of the window.
1165
1166 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1167 into disp_prop; all users changed.
1168
1169 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1170 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1171 for the text covered by the display property.
1172
1173 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1174
1175 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1176 Change return value to nil.
1177 (Frecord_buffer): Delete unused function.
1178
1179 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1180
1181 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1182 buffers, return left-to-right.
1183 (set_cursor_from_row): Consider candidate row a win if its glyph
1184 represents a newline and point is on that newline. Fixes cursor
1185 positioning on the newline at EOL of R2L text within L2R
1186 paragraph, and vice versa.
1187 (try_cursor_movement): Check continued rows, in addition to
1188 continuation rows. Fixes unwarranted scroll when point enters a
1189 continued line of R2L text within an L2R paragraph, or vice versa.
1190 (cursor_row_p): Consider the case of point being equal to
1191 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1192 from the end of a short line to the beginning of a continued line
1193 of R2L text within L2R paragraph.
1194 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1195 composed characters.
1196
1197 * bidi.c (bidi_check_type): Use xassert.
1198 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1199 members.
1200
1201 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1202
1203 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1204 a character.
1205
1206 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1207
1208 * nsfont.m (ns_otf_to_script): Fix typo.
1209
1210 2011-08-22 Kenichi Handa <handa@m17n.org>
1211
1212 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1213 extra slot even if the purpose is char-code-property-table.
1214
1215 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1216
1217 * xdisp.c (redisplay_window): When computing centering_position,
1218 account for the height of the header line. (Bug#8874)
1219
1220 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1221 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1222 candidate is selected by the mouse, and that candidate has a
1223 composed character under the mouse.
1224
1225 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1226 coordinates reported by pos-visible-in-window-p for a composed
1227 character in column zero.
1228
1229 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1230
1231 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1232
1233 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1234
1235 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1236 consider it a hit if to_charpos is anywhere in the range of the
1237 composed buffer positions.
1238
1239 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1240
1241 * image.c (gif_load): Don't assume that each subimage has the same
1242 dimensions as the base image. Handle disposal method that is
1243 "undefined" by the gif spec (Bug#9335).
1244
1245 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1246
1247 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1248 (Fcondition_case): Document `debug' symbol in error handler.
1249
1250 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1251
1252 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1253 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1254 from an Org mode buffer to a Speedbar frame.
1255
1256 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1257 a composition, take its buffer position from IT->cmp_it.charpos.
1258 Fixes cursor positioning at the beginning of a line that begins
1259 with a composed character.
1260
1261 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1262
1263 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1264 character bidirectional type, use STRONG_L instead. Fixes crashes
1265 in a buffer produced by `describe-categories'.
1266
1267 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1268 members before the level stack, so they would be saved and
1269 restored when copying iterator state. Fixes incorrect reordering
1270 around TABs covered by display properties.
1271
1272 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1273
1274 * process.c (Fnetwork_interface_list): Correctly determine buffer
1275 size.
1276
1277 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1278
1279 * eval.c (internal_condition_case, internal_condition_case_1)
1280 (internal_condition_case_2, internal_condition_case_n):
1281 Remove unnecessary aborts (Bug#9081).
1282
1283 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1284
1285 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1286 has no `load' handler, try opening the file locally. (Bug#9311)
1287
1288 2011-08-16 Ken Brown <kbrown@cornell.edu>
1289
1290 * gmalloc.c: Expand comment.
1291
1292 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1293
1294 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1295 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1296
1297 2011-08-16 Ken Brown <kbrown@cornell.edu>
1298
1299 Fix memory allocation problems in Cygwin build (Bug#9273).
1300
1301 * unexcw.c ( __malloc_initialized): Declare external variable.
1302 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1303
1304 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1305 New variables.
1306 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1307 dumped emacs.
1308 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1309 in the static heap.
1310 [CYGWIN] (special_realloc): New function.
1311 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1312 requests to realloc storage in the static heap.
1313
1314 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * bidi.c (bidi_initialize): Remove unused local.
1317
1318 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1319
1320 * biditype.h: File removed.
1321
1322 * bidimirror.h: File removed.
1323
1324 * deps.mk (bidi.o): Remove biditype.h and
1325 bidimirror.h.
1326
1327 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1328 bidimirror.h.
1329
1330 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1331
1332 * chartab.c: Improve commentary for the uniprop_table API.
1333
1334 * bidi.c (bidi_paragraph_init): Support zero value of
1335 bidi_ignore_explicit_marks_for_paragraph_level.
1336 (bidi_initialize): Use uniprop_table instead of including
1337 biditype.h and bidimirror.h.
1338
1339 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1340 coordinates of the iterator when restoring from ppos_it.
1341 (Bug#9296)
1342
1343 2011-08-14 Kenichi Handa <handa@m17n.org>
1344
1345 * process.c (create_process): Call setup_process_coding_systems
1346 after the pid of the process is set to -1 (Bug#8162).
1347
1348 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1349
1350 * xdisp.c (move_it_in_display_line_to): Don't invoke
1351 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1352 ppos_it. Fixes vertical cursor motion when line beginning is
1353 covered by an image. (Bug#9296)
1354
1355 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1356
1357 * nsterm.h (ns_run_ascript): Declare.
1358 (NSAPP_DATA2_RUNASSCRIPT): Define.
1359
1360 * nsfns.m (as_script, as_result, as_status): New static variables.
1361 (ns_run_ascript): New function.
1362 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1363 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1364 the event loop. Get status from as_status (Bug#7276).
1365
1366 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1367 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1368 the event loop (Bug#7276).
1369
1370 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1371
1372 * gnutls.c (QCgnutls_bootprop_priority)
1373 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1374 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1375 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1376 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1377 (QCgnutls_bootprop_verify_hostname_error)
1378 (QCgnutls_bootprop_callbacks_verify): Rename from
1379 Qgnutls_bootprop_..., all uses changed.
1380
1381 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1382 uses changed.
1383
1384 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 * xfaces.c (Qframe_set_background_mode): Now static.
1387 * dispextern.h (Qframe_set_background_mode): Remove decl.
1388
1389 * process.c (Fnetwork_interface_info): Declare local only if needed.
1390
1391 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1392
1393 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1394 (Fnetwork_interface_list): Allocate in increments of bytes instead
1395 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1396 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1397 sockaddr.
1398 (struct ifflag_def): notrailers is smart on OSX.
1399 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1400 Get hardware address with getifaddrs if available.
1401
1402 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1403
1404 * xdisp.c (iterate_out_of_display_property): xassert that
1405 IT->position is set to within IT->object's boundaries. Break from
1406 the loop as soon as EOB is reached; avoids infloops in redisplay
1407 when IT->position is set up wrongly due to some bug.
1408 Set IT->current to match the bidi iterator unconditionally.
1409 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1410 entry. Force push_it to save on the stack the current
1411 buffer/string position, to be restored by pop_it. Fix flags in
1412 the iterator structure wrt the object coming from a display
1413 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1414 properties. (Bug#9284)
1415
1416 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1417
1418 * fontset.c (fontset_get_font_group): Add proper type checks.
1419 (Bug#9172)
1420
1421 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1422
1423 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1424 and LC_VERSION_MIN_MACOSX.
1425 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1426 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1427
1428 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1429
1430 * xdisp.c (forward_to_next_line_start): Allow to use the
1431 no-display-properties-and-no-overlays under bidi display.
1432 Set disp_pos in the bidi iterator to avoid searches for display
1433 properties and overlays.
1434
1435 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1436
1437 * editfns.c (Fset_time_zone_rule): Document relationship with the
1438 setenv function.
1439
1440 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1441 the font entity extracted from the cache (Bug#8109).
1442
1443 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1444
1445 * composite.c (autocmp_chars): Don't reset point. That is done by
1446 restore_point_unwind (Bug#5984).
1447
1448 2011-08-07 Juri Linkov <juri@jurta.org>
1449
1450 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1451 to show the arg `TIME' instead of `TIMEVAL'.
1452
1453 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1456 display property strides EOL and includes a newline, as in
1457 longlines-mode. (Bug#9254)
1458 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1459 word-wrap under bidirectional display. (Bug#9224)
1460
1461 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1462 is non-zero, even if the data buffer is NULL. Fixes a crash in
1463 vertical-motion with longlines-mode. (Bug#9254)
1464
1465 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1466
1467 * bidi.c <bidi_cache_total_alloc>: Now static.
1468 (bidi_initialize): Initialize bidi_cache_total_alloc.
1469
1470 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1471 cache. (Bug#9221)
1472
1473 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1474 amount allocated this far in `bidi_cache_total_alloc'.
1475 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1476 non-zero, only free the data buffer without restoring the cache
1477 contents. All callers changed.
1478
1479 * dispextern.h (bidi_unshelve_cache): Update prototype.
1480
1481 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1482 (move_it_in_display_line, move_it_to)
1483 (move_it_vertically_backward, move_it_by_lines): Replace the call
1484 to xfree to an equivalent call to bidi_unshelve_cache.
1485 (move_it_in_display_line_to): Fix logic of returning
1486 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1487
1488 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1489
1490 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1491 came from a string character with a `cursor' property. (Bug#9229)
1492
1493 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1494
1495 * Makefile.in (LIB_PTHREAD): New variable.
1496 (LIBES): Add LIB_PTHREAD (Bug#9216).
1497
1498 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1499 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1500
1501 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1502
1503 * regex.c (re_iswctype): Remove some redundant boolean
1504 conversions.
1505
1506 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1507
1508 * xterm.c (x_find_topmost_parent): New function.
1509 (x_set_frame_alpha): Find topmost parent window with
1510 x_find_topmost_parent and set the property there also (bug#9181).
1511 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1512
1513 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1514
1515 * callproc.c (Fcall_process): Avoid vfork clobbering
1516 the local vars buffer, coding_systems, current_dir.
1517
1518 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1519
1520 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1521
1522 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1525 so that it is not optimized away.
1526
1527 * xdisp.c (compute_display_string_pos): Remove unused local.
1528
1529 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1530
1531 Fix slow cursor motion and scrolling in large buffers with
1532 selective display, like Org Mode buffers. (Bug#9218)
1533
1534 * dispextern.h (struct bidi_it): New member disp_prop_p.
1535
1536 * xdisp.c: Remove one-slot cache of display string positions.
1537 (compute_display_string_pos): Accept an additional argument
1538 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1539 for a display string or property. If found, set DISP_PROP_P
1540 non-zero.
1541
1542 * bidi.c (bidi_fetch_char): Accept an additional argument
1543 DISP_PROP_P, and pass it to compute_display_string_pos.
1544 Only handle text covered by a display string if DISP_PROP_P is returned
1545 non-zero. All callers of bidi_fetch_char changed.
1546
1547 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1548
1549 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1550
1551 2010-12-03 Don March <don@ohspite.net>
1552
1553 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1554 last character M-[char] is translated to ESC [char] (bug#7541).
1555
1556 2011-08-02 Kenichi Handa <handa@m17n.org>
1557
1558 * lisp.h (uniprop_table): Extern it.
1559
1560 * chartab.c (uniprop_table): Make it non-static.
1561
1562 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1563
1564 * xdisp.c (forward_to_next_line_start): Accept additional argument
1565 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1566 on the newline.
1567 (reseat_at_next_visible_line_start): Use the bidi iterator state
1568 returned by forward_to_next_line_start to restore the state of
1569 it->bidi_it after backing up to previous newline. (Bug#9212)
1570
1571 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1572
1573 * regex.c (re_comp): Protoize.
1574 (re_exec): Fix return type.
1575 (regexec): Fix type of `ret'. (Bug#9203)
1576
1577 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1578
1579 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1580 This is needed if max-image-size is a floating-point number.
1581
1582 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1583
1584 * print.c (print_object): Print empty symbol as ##.
1585
1586 * lread.c (read1): Read ## as empty symbol.
1587
1588 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1589
1590 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1591 setting frame foreground color (Bug#9175).
1592 (x_set_background_color): Likewise.
1593
1594 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1595 contents (Bug#9176).
1596 (EmacsTooltip -init): Remove bezels and add shadows to
1597 tooltip windows.
1598
1599 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1600 or scroll bar (Bug#8470).
1601
1602 * nsfont.m (nsfont_open): Remove assignment to voffset and
1603 unnecessary vars hshink, expand, hd, full_height, min_height.
1604 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1605
1606 * nsterm.h (nsfont_info): Remove voffset field.
1607
1608 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1609
1610 Implement strike-through and overline on NextStep (Bug#8863).
1611
1612 * nsfont.m (nsfont_open): Use underline position provided by font,
1613 instead of hard-coded value of 2.
1614 (nsfont_draw): Call ns_draw_text_decoration instead.
1615
1616 * nsterm.h: Add declaration for ns_draw_text_decoration.
1617
1618 * nsterm.m (ns_draw_text_decoration): New function for drawing
1619 underline, overline, and strike-through.
1620 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1621 ns_draw_text_decoration. Change treatment of cursor drawing to
1622 accommodate underlining, etc.
1623
1624 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1625
1626 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1627 default.
1628
1629 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1632 Without this fix, if a signal arrives just after memory fills up,
1633 'malloc' might be invoked reentrantly.
1634
1635 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1636 In other words, assume that every image size is allowed, on non-X
1637 hosts. This assumption is probably wrong, but it lets Emacs compile.
1638
1639 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1640
1641 * regex.c (re_iswctype): Convert return values to boolean.
1642
1643 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1644
1645 * xdisp.c (compute_display_string_pos): Don't use cached display
1646 string position if the buffer had its restriction changed.
1647 (Bug#9184)
1648
1649 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1650
1651 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1652
1653 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 Integer signedness and overflow and related fixes. (Bug#9079)
1656
1657 * bidi.c: Integer size and overflow fixes.
1658 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1659 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1660 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1661 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1662 (bidi_find_other_level_edge):
1663 Use ptrdiff_t instead of EMACS_INT where either will do.
1664 This works better on 32-bit hosts configured --with-wide-int.
1665 (bidi_cache_ensure_space): Check for size-calculation overflow.
1666 Use % rather than repeated addition, for better worst-case speed.
1667 Don't set bidi_cache_size until after xrealloc returns, because it
1668 might not return.
1669 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1670 (bidi_cache_ensure_space): Also check that the bidi cache size
1671 does not exceed that of the largest Lisp string or buffer. See Eli
1672 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1673
1674 * alloc.c (__malloc_size_t): Remove.
1675 All uses replaced by size_t. See Andreas Schwab's note
1676 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1677
1678 * image.c: Improve checking for integer overflow.
1679 (check_image_size): Assume that f is nonnull, since
1680 it is always nonnull in practice. This is one less thing to
1681 worry about when checking for integer overflow later.
1682 (x_check_image_size): New function, which checks for integer
1683 overflow issues inside X.
1684 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1685 This removes the need for a memory_full check.
1686 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1687 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1688 (xbm_read_bitmap_data): Change locals back to 'int', since
1689 their values must fit in 'int'.
1690 (xpm_load_image, png_load, tiff_load):
1691 Invoke x_create_x_image_and_pixmap earlier,
1692 to avoid much needless work if the image is too large.
1693 (tiff_load): Treat overly large images as if
1694 x_create_x_image_and_pixmap failed, not as malloc failures.
1695 (gs_load): Use x_check_image_size.
1696
1697 * gtkutil.c: Omit integer casts.
1698 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1699 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1700
1701 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1702
1703 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1704 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1705 would wrongly return t on a 64-bit host.
1706
1707 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1708 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1709 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1710 and therefore cause GCC to emit a bogus diagnostic in some cases.
1711
1712 * image.c: Integer signedness and overflow and related fixes.
1713 This is not an exhaustive set of fixes, but it's time to
1714 record what I've got.
1715 (lookup_pixel_color, check_image_size): Remove redundant decls.
1716 (check_image_size): Don't assume that arbitrary EMACS_INT values
1717 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1718 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1719 (tiff_load, imagemagick_load_image):
1720 Check for overflow in size calculations.
1721 (x_create_x_image_and_pixmap): Remove unnecessary test for
1722 xmalloc returning NULL; that can't happen.
1723 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1724 (xpm_color_bucket): Use better integer hashing function.
1725 (xpm_cache_color): Don't possibly over-allocate memory.
1726 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1727 (gif_memory_source):
1728 Use ptrdiff_t, not int or size_t, to record sizes.
1729 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1730 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1731 either works, as we prefer signed integers.
1732 (tiff_read_from_memory, tiff_write_from_memory):
1733 Return tsize_t, not size_t, since that's what the TIFF API wants.
1734 (tiff_read_from_memory): Don't fail simply because the read would
1735 go past EOF; instead, return a short read.
1736 (tiff_load): Omit no-longer-needed casts.
1737 (Fimagemagick_types): Don't assume size fits into 'int'.
1738
1739 Improve hashing quality when configured --with-wide-int.
1740 * fns.c (hash_string): New function, taken from sxhash_string.
1741 Do not discard information about ASCII character case; this
1742 discarding is no longer needed.
1743 (sxhash-string): Use it. Change sig to match it. Caller changed.
1744 * lisp.h: Declare it.
1745 * lread.c (hash_string): Remove, since we now use fns.c's version.
1746 The fns.c version returns a wider integer if --with-wide-int is
1747 specified, so this should help the quality of the hashing a bit.
1748
1749 * emacs.c: Integer overflow minor fix.
1750 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1751 Define only if GNU_LINUX.
1752 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1753
1754 * dispnew.c: Integer signedness and overflow fixes.
1755 Remove unnecessary forward decls, that were a maintenance hassle.
1756 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1757 All uses changed.
1758 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1759 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1760 (prepare_desired_row, line_draw_cost):
1761 Use int, not unsigned, where either works.
1762 (save_current_matrix, restore_current_matrix):
1763 Use ptrdiff_t, not size_t, where either works.
1764 (init_display): Check for overflow more accurately, and without
1765 relying on undefined behavior.
1766
1767 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1768 Remove, replacing with the new symbols in lisp.h. All uses changed.
1769 * fileio.c (make_temp_name):
1770 * filelock.c (lock_file_1, lock_file):
1771 * xdisp.c (message_dolog):
1772 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1773 Use pMd etc. instead.
1774 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1775 replacing the pWIDE etc. symbols removed from editfns.c.
1776
1777 * keyboard.h (num_input_events): Now uintmax_t.
1778 This is (very slightly) less likely to mess up due to wraparound.
1779 All uses changed.
1780
1781 * buffer.c: Integer signedness fixes.
1782 (alloc_buffer_text, enlarge_buffer_text):
1783 Use ptrdiff_t rather than size_t when either will do, as we prefer
1784 signed integers.
1785
1786 * alloc.c: Integer signedness and overflow fixes.
1787 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1788 (__malloc_size_t): Default to size_t, not to int.
1789 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1790 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1791 Prefer ptrdiff_t to size_t when either would do, as we prefer
1792 signed integers.
1793 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1794 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1795 Now const. Initialize with values that are in range even if char
1796 is signed.
1797 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1798 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1799 These functions do the right thing with sizes > 2**32.
1800 (check_depth): Now ptrdiff_t, not int.
1801 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1802 Adjust to new way of storing sizes. Check for size overflow bugs
1803 in rest of code.
1804 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1805 slightly wrong anyway, as it missed one instance of
1806 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1807 (refill_memory_reserve): Omit needless cast to size_t.
1808 (mark_object_loop_halt): Mark as externally visible.
1809
1810 * xselect.c: Integer signedness and overflow fixes.
1811 (Fx_register_dnd_atom, x_handle_dnd_message):
1812 Use ptrdiff_t, not size_t, since we prefer signed.
1813 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1814 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1815 x_dnd_atoms_size and x_dnd_atoms_length.
1816
1817 * doprnt.c: Prefer signed to unsigned when either works.
1818 * eval.c (verror):
1819 * doprnt.c (doprnt):
1820 * lisp.h (doprnt):
1821 * xdisp.c (vmessage):
1822 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1823 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1824 prefer signed arithmetic to avoid comparison confusion.
1825 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1826 but is a bit tricky.
1827
1828 Assume freestanding C89 headers, string.h, stdlib.h.
1829 * data.c, doprnt.c, floatfns.c, print.c:
1830 Include float.h unconditionally.
1831 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1832 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1833 * regex.c: Likewise for stddef.h, string.h.
1834 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1835 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1836 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1837 (STDC_HEADERS): Remove obsolete defines.
1838 * sysdep.c: Include limits.h unconditionally.
1839
1840 Assume support for memcmp, memcpy, memmove, memset.
1841 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1842 * regex.c (memcmp, memcpy):
1843 Remove; we assume C89 now.
1844
1845 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1846 (__malloc_safe_bcopy): Remove; no longer needed.
1847
1848 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1849 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1850 well either way, and we prefer signed to unsigned.
1851
1852 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1853
1854 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1855 closes the connection while we're reading (bug#9182).
1856
1857 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1858
1859 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1860 are specified (Bug#9168).
1861
1862 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1863
1864 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1865 Found by GCC static checking and --with-wide-int on a 32-bit host.
1866
1867 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1868
1869 * xdisp.c (compute_display_string_pos): Fix logic of caching
1870 previous display string position. Initialize cached_prev_pos to
1871 -1. Fixes slow-down at the beginning of a buffer.
1872
1873 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1874
1875 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1876 for attrs[LFACE_FONTSET_INDEX].
1877
1878 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 * xml.c (parse_region): Remove unused local
1881 that was recently introduced.
1882
1883 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1884
1885 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1886 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1887
1888 * xdisp.c (move_it_in_display_line_to): Record the best matching
1889 position for TO_CHARPOS while scanning the line, and restore it on
1890 exit if none of the characters scanned was an exact match.
1891 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1892 when exact match is impossible due to invisible text, and the
1893 lines are truncated.
1894
1895 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1896
1897 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1898 for OSX >= 10.7.
1899
1900 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1901
1902 Fix a significant slow-down of cursor motion with C-n, C-p,
1903 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1904 auto-repeat under bidi redisplay in fontified buffers.
1905 * xdisp.c (compute_stop_pos_backwards): New function.
1906 (next_element_from_buffer): Call compute_stop_pos_backwards to
1907 find a suitable prev_stop when we find ourselves before
1908 base_level_stop.
1909 (reseat): Don't look for prev_stop, as that could mean a very long
1910 run.
1911 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1912 <cached_disp_overlay_modiff>: Cache for last found display string
1913 position.
1914 (compute_display_string_pos): Return the cached position if asked
1915 about the same buffer in the same area of character positions, and
1916 the buffer wasn't changed since the time the display string
1917 position was cached.
1918
1919 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1920
1921 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1922 is an integer, which is important for empty lines. (Bug#9149)
1923
1924 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1925
1926 * frame.c (Fmodify_frame_parameters): In tty case, update the
1927 default face if necessary (Bug#4238).
1928
1929 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1930
1931 * editfns.c (Fstring_to_char): No need to explain what a character
1932 is in the docstring (Bug#6576).
1933
1934 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1935
1936 * xml.c (parse_region): Make sure we always return a tree.
1937
1938 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1939
1940 * xml.c (parse_region): If a document contains only comments,
1941 return that, too.
1942
1943 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1944
1945 * xml.c (make_dom): Return comments, too.
1946
1947 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 Port to OpenBSD.
1950 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1951 and the surrounding thread.
1952 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1953 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1954 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1955 timer goes off.
1956 * s/openbsd.h (BROKEN_SIGIO): Define.
1957 * unexelf.c (unexec) [__OpenBSD__]:
1958 Don't update the .mdebug section of the Alpha COFF symbol table.
1959
1960 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1961
1962 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1963 (bug#8460).
1964
1965 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1968 This fixes some race conditions on the permissions of any newly
1969 created file.
1970
1971 * alloc.c (valid_pointer_p): Use pipe, not open.
1972 This fixes some permissions issues when debugging.
1973
1974 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1975 If fchown fails to set both uid and gid, try to set just gid,
1976 as that is sometimes allowed. Adjust the file's mode to eliminate
1977 setuid or setgid bits that are inappropriate if fchown fails.
1978
1979 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1980
1981 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1982 to compare Lisp_Objects.
1983 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1984 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1985 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1986
1987 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1988
1989 * lread.c (read_integer): Unread even EOF character.
1990 (read1): Likewise. Properly record start position of symbol.
1991
1992 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1993 symbol character follows.
1994
1995 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1998 This works around a problem with the previous change to Fcopy_file.
1999 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2000 and without this change, GCC might complain about discarding
2001 fchown's return value.
2002
2003 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2004
2005 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2006
2007 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2010
2011 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2012
2013 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2014 it's used from the C level.
2015
2016 * process.c: Use the same condition for POLL_FOR_INPUT in both
2017 keyboard.c and process.c (bug#1858).
2018
2019 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2020
2021 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2022 (Fgnutls_boot): Use it.
2023
2024 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2025
2026 * doc.c (Fsubstitute_command_keys): Revert last change.
2027
2028 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2029
2030 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2031 quotes the next character, and doesn't affect other longer
2032 sequences (bug#8935).
2033
2034 * lread.c (syms_of_lread): Clarify that is isn't only
2035 `eval-buffer' and `eval-defun' that's affected by
2036 `lexical-binding' (bug#8460).
2037
2038 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2039
2040 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2041 bidi redisplay when a line includes both an image and is
2042 truncated.
2043
2044 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 Fix minor problems found by static checking.
2047 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2048 (elsz): Now a signed constant, not a size_t var. We prefer signed
2049 types to unsigned, to avoid integer comparison confusion. Without
2050 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2051 "cannot optimize loop, the loop counter may overflow", a symptom
2052 of the confusion.
2053 * indent.c (Fvertical_motion): Mark locals as initialized.
2054 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2055
2056 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2057
2058 * search.c (Fre_search_backward): Mention `case-fold-search' in
2059 all the re_search_* functions (bug#8138).
2060
2061 * keyboard.c (Fopen_dribble_file): Document when the file is
2062 closed (bug#8056).
2063
2064 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2065
2066 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2067 bidi_cache_idx.
2068
2069 Support bidi reordering of display and overlay strings.
2070 * xdisp.c (compute_display_string_pos)
2071 (compute_display_string_end): Accept additional argument STRING.
2072 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2073 (reseat_to_string): Initialize bidi_it->string.s and
2074 bidi_it->string.schars.
2075 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2076 NULL (avoids a crash in bidi_paragraph_init).
2077 Initialize itb.string.lstring.
2078 (init_iterator): Call bidi_init_it only of a valid
2079 buffer position was specified. Initialize paragraph_embedding to
2080 L2R.
2081 (reseat_to_string): Initialize the bidi iterator.
2082 (display_string): If we need to ignore text properties of
2083 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2084 original value of -1 will not work with bidi.)
2085 (compute_display_string_pos): First arg is now struct
2086 `text_pos *'; all callers changed. Support display properties on
2087 Lisp strings.
2088 (compute_display_string_end): Support display properties on Lisp
2089 strings.
2090 (init_iterator, reseat_1, reseat_to_string): Initialize the
2091 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2092 when iterating on a string not from display properties).
2093 (compute_display_string_pos, compute_display_string_end):
2094 Fix calculation of the object to scan. Fixes an error when using
2095 arrow keys.
2096 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2097 base_level_stop; instead, set base_level_stop to BEGV.
2098 Fixes crashes in vertical-motion.
2099 (next_element_from_buffer): Improve commentary for when
2100 the iterator is before prev_stop.
2101 (init_iterator): Initialize bidi_p from the default value of
2102 bidi-display-reordering, not from buffer-local value. Use the
2103 buffer-local value only if initializing for buffer iteration.
2104 (handle_invisible_prop): Support invisible properties on strings
2105 that are being bidi-reordered.
2106 (set_iterator_to_next): Support bidi reordering of C strings and
2107 Lisp strings.
2108 (next_element_from_string): Support bidi reordering of Lisp
2109 strings.
2110 (handle_stop_backwards): Support Lisp strings as well.
2111 (display_string): Support display of R2L glyph rows.
2112 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2113 (init_iterator): Don't initialize it->bidi_p for strings
2114 here.
2115 (reseat_to_string): Initialize it->bidi_p for strings here.
2116 (next_element_from_string, next_element_from_c_string)
2117 (next_element_from_buffer): Add xassert's for correspondence
2118 between IT's object being iterated and it->bidi_it.string
2119 structure.
2120 (face_before_or_after_it_pos): Support bidi iteration.
2121 (next_element_from_c_string): Handle the case of the first string
2122 character that is not the first one in the visual order.
2123 (get_visually_first_element): New function, refactored from common
2124 parts of next_element_from_buffer, next_element_from_string, and
2125 next_element_from_c_string.
2126 (tool_bar_lines_needed, redisplay_tool_bar)
2127 (display_menu_bar): Force left-to-right direction. Add a FIXME
2128 comment for making that be controlled by a user option.
2129 (push_it, pop_it): Save and restore the state of the
2130 bidi iterator. Save and restore the bidi_p flag.
2131 (pop_it): Iterate out of display property for string iteration as
2132 well.
2133 (iterate_out_of_display_property): Support iteration over strings.
2134 (handle_single_display_spec): Set up it->bidi_it for iteration
2135 over a display string, and call bidi_init_it.
2136 (handle_single_display_spec, next_overlay_string)
2137 (get_overlay_strings_1, push_display_prop): Set up the bidi
2138 iterator for displaying display or overlay strings.
2139 (forward_to_next_line_start): Don't use the shortcut if
2140 bidi-iterating.
2141 (back_to_previous_visible_line_start): If handle_display_prop
2142 pushed the iterator stack, restore the internal state of the bidi
2143 iterator by calling bidi_pop_it same number of times.
2144 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2145 and we are bidi-iterating, don't decrement the iterator position;
2146 instead, set the first_elt flag in the bidi iterator, to produce
2147 the same effect.
2148 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2149 (push_display_prop): xassert that we are iterating a buffer.
2150 (push_it, pop_it): Save and restore paragraph_embedding member.
2151 (handle_single_display_spec, next_overlay_string)
2152 (get_overlay_strings_1, reseat_1, reseat_to_string)
2153 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2154 correctly. Don't assume unibyte strings are not bidi-reordered.
2155 (compute_display_string_pos)
2156 (compute_display_string_end): Fix handling the case of C string.
2157 (push_it, pop_it): Save and restore from_disp_prop_p.
2158 (handle_single_display_spec, push_display_prop): Set the
2159 from_disp_prop_p flag.
2160 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2161 (pop_it): Call iterate_out_of_display_property only if we are
2162 popping after iteration over a string that came from a display
2163 property. Fix a typo in popping stretch info. Add an assertion
2164 for verifying that the iterator position is in sync with the bidi
2165 iterator.
2166 (handle_single_display_spec, get_overlay_strings_1)
2167 (push_display_prop): Fix initialization of paragraph direction for
2168 string when that of the parent object is not yet determined.
2169 (reseat_1): Call bidi_init_it to resync the bidi
2170 iterator with IT's position. (Bug#7616)
2171 (find_row_edges): If ROW->start.pos gives position
2172 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2173 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2174 Reset the from_disp_prop_p flag.
2175 (SAVE_IT, RESTORE_IT): New macros.
2176 (pos_visible_p, face_before_or_after_it_pos)
2177 (back_to_previous_visible_line_start)
2178 (move_it_in_display_line_to, move_it_in_display_line)
2179 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2180 (try_scrolling, redisplay_window, display_line): Use them when
2181 saving a temporary copy of the iterator and restoring it back.
2182 (back_to_previous_visible_line_start, reseat_1)
2183 (init_iterator): Empty the bidi cache "stack".
2184 (move_it_in_display_line_to): If iterator ended up at
2185 EOL, but we never saw any buffer positions smaller than
2186 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2187 motion in bidi-reordered lines.
2188 (move_it_in_display_line_to): Record prev_method and prev_pos
2189 immediately before the call to set_iterator_to_next. Fixes cursor
2190 motion in bidi-reordered lines with stretch glyphs and strings
2191 displayed in margins. (Bug#8133) (Bug#8867)
2192 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2193 TO_CHARPOS.
2194 (pos_visible_p): Support positions in bidi-reordered lines.
2195 Save and restore bidi cache.
2196
2197 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2198 (bidi_paragraph_info): Delete unused struct.
2199 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2200 (bidi_cache_start): New variable.
2201 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2202 to zero.
2203 (bidi_cache_fetch_state, bidi_cache_search)
2204 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2205 (bidi_cache_find, bidi_peek_at_next_level)
2206 (bidi_level_of_next_char, bidi_find_other_level_edge)
2207 (bidi_move_to_visually_next): Compare cache index with
2208 bidi_cache_start rather than with zero.
2209 (bidi_fetch_char): Accept new argument STRING; all callers
2210 changed. Support iteration over a string. Support strings with
2211 display properties. Support unibyte strings. Fix the type of
2212 `len' according to what STRING_CHAR_AND_LENGTH expects.
2213 (bidi_paragraph_init, bidi_resolve_explicit_1)
2214 (bidi_resolve_explicit, bidi_resolve_weak)
2215 (bidi_level_of_next_char, bidi_move_to_visually_next):
2216 Support iteration over a string.
2217 (bidi_set_sor_type, bidi_resolve_explicit_1)
2218 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2219 can now be zero (for strings); special values 0 and -1 were
2220 changed to -1 and -2, respectively.
2221 (bidi_char_at_pos): New function.
2222 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2223 Call it instead of FETCH_MULTIBYTE_CHAR.
2224 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2225 initialized to valid values.
2226 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2227 values.
2228 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2229 the test for valid cached positions. Fix the logic for looking up
2230 the sentinel state in the cache. GCPRO the Lisp string we are
2231 iterating.
2232 (bidi_push_it, bidi_pop_it): New functions.
2233 (bidi_initialize): Initialize the bidi cache start stack pointer.
2234 (bidi_cache_ensure_space): New function, refactored from part of
2235 bidi_cache_iterator_state. Don't assume the required size is just
2236 one BIDI_CACHE_CHUNK away.
2237 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2238 (bidi_count_bytes, bidi_char_at_pos): New functions.
2239 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2240 always valid if bidi_cache_idx is valid.
2241 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2242 is valid if it's going to be used.
2243 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2244 (bidi_cache_fetch_state, bidi_cache_search)
2245 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2246 (bidi_cache_iterator_state, bidi_cache_find)
2247 (bidi_find_other_level_edge, bidi_cache_start_stack):
2248 All variables related to cache indices are now EMACS_INT.
2249
2250 * dispextern.h (struct bidi_string_data): New structure.
2251 (struct bidi_it): New member `string'. Make flag members be 1-bit
2252 fields, and put them last in the struct.
2253 (compute_display_string_pos, compute_display_string_end):
2254 Update prototypes.
2255 (bidi_push_it, bidi_pop_it): Add prototypes.
2256 (struct iterator_stack_entry): New members bidi_p,
2257 paragraph_embedding, and from_disp_prop_p.
2258 (struct it): Member bidi_p is now a bit field 1 bit wide.
2259 (bidi_shelve_cache, bidi_unshelve_cache):
2260 Declare prototypes.
2261
2262 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2263 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2264 and vector-like objects.
2265
2266 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2267 cache around display iteration.
2268
2269 * window.c (Fwindow_end, window_scroll_pixel_based)
2270 (displayed_window_lines, Frecenter): Save and restore the bidi
2271 cache around display iteration.
2272
2273 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2274
2275 * editfns.c (Fdelete_region): Clarify the use of the named
2276 parameters (bug#6788).
2277
2278 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2279
2280 * indent.c (Fvertical_motion): Set and restore w->pointm when
2281 saving and restoring the window's buffer (Bug#9006).
2282
2283 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2284
2285 * editfns.c (Fstring_to_char): Clarify just what is returned
2286 (bug#6576). Text by Eli Zaretskii.
2287
2288 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2289
2290 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2291
2292 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2293
2294 * buffer.c (mmap_find): Fix a typo.
2295
2296 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2297
2298 Fix execution of x selection hooks.
2299 * xselect.c (Qx_lost_selection_functions)
2300 (Qx_sent_selection_functions): New vars.
2301 (syms_of_xselect): DEFSYM them.
2302 (x_handle_selection_request): Pass Qx_sent_selection_functions
2303 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2304 (x_handle_selection_clear,x_clear_frame_selections):
2305 Pass Qx_lost_selection_functions rather than
2306 Vx_lost_selection_functions to Frun_hook_with_args.
2307
2308 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2309
2310 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2311 The old code sometimes used this field without initializing it.
2312
2313 * alloc.c (gc_sweep): Don't read past end of array.
2314 In theory, the old code could also have corrupted Emacs internals,
2315 though it'd be very unlikely.
2316
2317 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2318
2319 * character.c (Fcharacterp): Don't advertise optional ignored
2320 argument. (Bug#4026)
2321
2322 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2323
2324 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2325 key" (bug#4257).
2326
2327 * window.c (Fset_window_start): Doc fix (bug#4199).
2328 (Fset_window_hscroll): Ditto.
2329
2330 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2331
2332 Fix minor new problems caught by GCC 4.6.1.
2333 * term.c (init_tty): Remove unused local.
2334 * xsettings.c (store_monospaced_changed): Define this function only
2335 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2336 not used otherwise.
2337
2338 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2339
2340 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2341
2342 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2343
2344 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2345 are the mini-buffer and the echo area (bug#3320).
2346
2347 * term.c (init_tty): Remove support for supdup, c10 and perq
2348 terminals, which are no longer supported (bug#1482).
2349
2350 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2351
2352 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2353
2354 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2355
2356 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2357 for non-popups (Bug#3642).
2358
2359 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2360
2361 * alloc.c (reset_malloc_hooks): Protoize.
2362 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2363 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2364 * cm.c (losecursor): Likewise.
2365 * data.c (fmod): Likewise.
2366 * dispnew.c (swap_glyphs_in_rows): Likewise.
2367 * emacs.c (memory_warning_signal): Likewise.
2368 * floatfns.c (float_error): Likewise.
2369 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2370 (otf_open, font_otf_capability, generate_otf_features)
2371 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2372 Likewise.
2373 * image.c (pbm_read_file): Likewise.
2374 * indent.c (string_display_width): Likewise.
2375 * intervals.c (check_for_interval, search_for_interval)
2376 (inc_interval_count, count_intervals, root_interval)
2377 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2378 * lread.c (defalias): Likewise.
2379 * ralloc.c (r_alloc_check): Likewise.
2380 * regex.c (set_image_of_range_1, set_image_of_range)
2381 (regex_grow_registers): Likewise.
2382 * sysdep.c (strerror): Likewise.
2383 * termcap.c (valid_filename_p, tprint, main): Likewise.
2384 * tparam.c (main): Likewise.
2385 * unexhp9k800.c (run_time_remap, save_data_space)
2386 (update_file_ptrs, read_header, write_header, calculate_checksum)
2387 (copy_file, copy_rest, display_header): Likewise.
2388 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2389 Likewise.
2390 * xdisp.c (check_it): Likewise.
2391 * xfaces.c (register_color, unregister_color, unregister_colors):
2392 Likewise.
2393 * xfns.c (print_fontset_result): Likewise.
2394 * xrdb.c (member, fatal, main): Likewise.
2395
2396 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2397
2398 Fix minor problems found by static checking (Bug#9031).
2399 * chartab.c (char_table_set_range, map_sub_char_table):
2400 Remove unused locals.
2401 (uniprop_table): Now static.
2402 * composite.c (_work_char): Remove unused static var.
2403
2404 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2405
2406 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2407
2408 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2409
2410 * gtkutil.c (qttip_cb): Remove code without function.
2411
2412 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2413
2414 * w32.c (pthread_sigmask): New stub.
2415
2416 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2417
2418 Use pthread_sigmask, not sigprocmask (Bug#9010).
2419 sigprocmask is portable only for single-threaded applications, and
2420 Emacs can be multi-threaded when it uses GTK.
2421 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2422 (LIBES): Use it.
2423 * callproc.c (Fcall_process):
2424 * process.c (create_process):
2425 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2426 Use pthread_sigmask, not sigprocmask.
2427
2428 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2429
2430 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2431 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2432 wrong (Bug#8591).
2433
2434 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2435
2436 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2437 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2438 (xg_hide_tooltip): Fix comment.
2439
2440 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2441 in registerServicesMenuSendTypes.
2442 (validRequestorForSendType): Don't check ns_return_types.
2443
2444 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2445 ns_return_type.
2446
2447 2011-07-08 Jason Rumney <jasonr@gnu.org>
2448
2449 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2450 frame struct members of non-existent frames (Bug#6284).
2451
2452 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2453
2454 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2455 variable firstTime not needed on OSX >= 10.6.
2456 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2457 >= 10.5. Use setKnobProportion, setDoubleValue.
2458
2459 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2460 (MAC_OS_X_VERSION_10_5): Define if not defined.
2461 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2462 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2463 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2464
2465 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2466 cString and lossyCString on OSX >= 10.4
2467
2468 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2469 sizeToFit on OSX >= 10.2.
2470
2471 * nsimage.m (allocInitFromFile): Don't use deprecated method
2472 bestRepresentationForDevice on OSX >= 10.6.
2473
2474 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2475 to avoid warning.
2476
2477 * emacs.c: Declare unexec_init_emacs_zone.
2478
2479 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2480
2481 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2482
2483 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2484 on svcsMenu (Bug#8842).
2485
2486 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2487 ns_return_types.
2488 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2489
2490 * nsterm.m (QUTF8_STRING): Declare.
2491 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2492 (validRequestorForSendType): Return type is (id).
2493 Change indexOfObjectIdenticalTo to indexOfObject.
2494 Check if we have local selection before returning self (Bug#8842).
2495 (writeSelectionToPasteboard): Put local selection into paste board
2496 if we have a local selection (Bug#8842).
2497 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2498
2499 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2500 (ns_get_local_selection): Declare.
2501
2502 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2503
2504 * keymap.c (describe_map_tree): Don't insert a double newline at
2505 the end of the buffer (bug#1169) and return whether we inserted
2506 something.
2507
2508 * callint.c (Fcall_interactively): Change "reading args" to
2509 "providing args" to try to clarify what it does (bug#1010).
2510
2511 2011-07-07 Kenichi Handa <handa@m17n.org>
2512
2513 * composite.c (composition_compute_stop_pos): Ignore a static
2514 composition starting before CHARPOS (Bug#8915).
2515
2516 * xdisp.c (handle_composition_prop): Likewise.
2517
2518 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2519
2520 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2521 (Bug#9015)
2522
2523 2011-07-07 Kenichi Handa <handa@m17n.org>
2524
2525 * character.h (unicode_category_t): New enum type.
2526
2527 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2528 (Qchar_code_property_table): New variable.
2529 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2530 (UNIPROP_COMPRESSED_FORM_P): New macros.
2531 (char_table_ascii): Uncompress the compressed values.
2532 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2533 Uncompress the compressed values.
2534 (sub_char_table_ref_and_range): Likewise.
2535 (char_table_ref_and_range): Uncompress the compressed values.
2536 (sub_char_table_set): New arg is_uniprop. Callers changed.
2537 Uncompress the compressed values.
2538 (sub_char_table_set_range): Args changed. Callers changed.
2539 (char_table_set_range): Adjuted for the above change.
2540 (map_sub_char_table): Delete args default_val and parent. Add arg
2541 top. Give decoded values to a Lisp function.
2542 (map_char_table): Adjust for the above change. Give decoded
2543 values to a Lisp function. Gcpro more variables.
2544 (uniprop_table_uncompress)
2545 (uniprop_decode_value_run_length): New functions.
2546 (uniprop_decoder, uniprop_decoder_count): New variables.
2547 (uniprop_get_decoder, uniprop_encode_value_character)
2548 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2549 New functions.
2550 (uniprop_encoder, uniprop_encoder_count): New variables.
2551 (uniprop_get_encoder, uniprop_table)
2552 (Funicode_property_table_internal, Fget_unicode_property_internal)
2553 (Fput_unicode_property_internal): New functions.
2554 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2555 Sunicode_property_table_internal, Sget_unicode_property_internal,
2556 and Sput_unicode_property_internal. Defvar_lisp
2557 char-code-property-alist.
2558
2559 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2560 Vunicode_category_table.
2561
2562 * font.c (font_range): Adjust for the change of
2563 Vunicode_category_table.
2564
2565 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2566
2567 * m/iris4d.h: Remove file, move contents ...
2568 * s/irix6-5.h: ... here.
2569
2570 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2571
2572 Remove unportable assumption about struct layout (Bug#8884).
2573 * alloc.c (mark_buffer):
2574 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2575 (clone_per_buffer_values): Don't assume that
2576 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2577 This isn't true in general, and it's particularly not true
2578 if Emacs is configured with --with-wide-int.
2579 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2580 New macros, used in the buffer.c change.
2581
2582 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2583
2584 * xsettings.c: Use both GConf and GSettings if both are available.
2585 (store_config_changed_event): Add comment.
2586 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2587 (store_tool_bar_style_changed): New functions.
2588 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2589 (struct xsettings): Move font inside HAVE_XFT.
2590 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2591 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2592 Move inside HAVE_XFT.
2593 (something_changed_gsettingsCB): Rename from something_changedCB.
2594 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2595 also.
2596 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2597 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2598 (something_changed_gconfCB): Rename from something_changedCB.
2599 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2600 (parse_settings): Move check for font inside HAVE_XFT.
2601 (read_settings, apply_xft_settings): Add comment.
2602 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2603 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2604 call store_font_name_changed.
2605 (xft_settings_event): Add comment.
2606 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2607 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2608 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2609 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2610 (xsettings_initialize): Call init_gsettings last.
2611 (xsettings_get_system_font, xsettings_get_system_normal_font):
2612 Add comment.
2613
2614 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 Random fixes. E.g., (random) never returned negative values.
2617 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2618 subseconds part to the entropy, as that's a bit more random.
2619 Prefer signed to unsigned, since the signedness doesn't matter and
2620 in general we prefer signed. When given a limit, use a
2621 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2622 latter isn't right if USE_2_TAGS_FOR_INTS.
2623 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2624 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2625
2626 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2627
2628 * textprop.c (text_property_stickiness):
2629 Obey Vtext_property_default_nonsticky.
2630 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2631 * w32fns.c (syms_of_w32fns):
2632 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2633
2634 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2635
2636 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2637 This is more efficient than Ffile_directory_p and avoids a minor race.
2638
2639 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2640
2641 * buffer.c (Foverlay_put): Say what the return value is
2642 (bug#7835).
2643
2644 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2645 is a directory before asking whether to use the file name
2646 (bug#7564).
2647 (barf_or_query_if_file_exists): Make the "File is a directory"
2648 error be more correct.
2649
2650 * fns.c (Frequire): Remove the mention of the .gz files, since
2651 that's installation-specific, but keep the mention of
2652 `get-load-suffixes'.
2653
2654 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2655
2656 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2657 Report string overflow if the output is too long.
2658
2659 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2660
2661 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2662 (syms_of_gnutls): Remove duplicate DEFSYM for
2663 Qgnutls_bootprop_verify_hostname_error, an error for
2664 Qgnutls_bootprop_verify_error (which is no longer used).
2665
2666 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2667 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2668 Also (re)move comments that are misplaced or no longer relevant.
2669
2670 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2671
2672 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2673
2674 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2675
2676 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2677 and background color parameters if they have been changed.
2678
2679 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2680
2681 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2682
2683 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2684
2685 * xsettings.c (SYSTEM_FONT): Define only when used.
2686 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2687
2688 * keymap.c (access_keymap_1): Now static.
2689
2690 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2691
2692 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2693 leave any prefix arg for the up event (Bug#1586).
2694
2695 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2696
2697 * lread.c (syms_of_lread): Mention single symbols defined by
2698 `defvar' or `defconst' (bug#7154).
2699
2700 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2701 (Frequire): Mention get-load-suffixes.
2702
2703 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2704
2705 * window.h (window): Remove clone_number slot.
2706 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2707 Remove.
2708 (make_parent_window, make_window, saved_window)
2709 (Fset_window_configuration, save_window_save): Don't deal with
2710 clone numbers.
2711 * buffer.c (Qclone_number): Remove declaration.
2712 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2713
2714 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2715
2716 Add multiple inheritance to keymaps.
2717 * keymap.c (Fmake_composed_keymap): New function.
2718 (Fset_keymap_parent): Simplify.
2719 (fix_submap_inheritance): Remove.
2720 (access_keymap_1): New function extracted from access_keymap to handle
2721 embedded parents and handle lists of maps.
2722 (access_keymap): Use it.
2723 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2724 (Fcopy_keymap): Handle embedded parents.
2725 (Fcommand_remapping, define_as_prefix): Simplify.
2726 (Fkey_binding): Simplify.
2727 (syms_of_keymap): Move minibuffer-local-completion-map,
2728 minibuffer-local-filename-completion-map,
2729 minibuffer-local-must-match-map, and
2730 minibuffer-local-filename-must-match-map to Elisp.
2731 (syms_of_keymap): Defsubr make-composed-keymap.
2732 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2733 (parse_menu_item): Trivial simplification.
2734
2735 2011-07-01 Glenn Morris <rgm@gnu.org>
2736
2737 * Makefile.in (SETTINGS_LIBS): Fix typo.
2738
2739 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2740
2741 * coding.c (Fencode_coding_string): Record the last coding system
2742 used, as the function doc string says (bug#8738).
2743
2744 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2745
2746 * xsettings.c (store_monospaced_changed): Take new font as arg and
2747 check for change against current_mono_font.
2748 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2749 (emacs_settings_constructor, emacs_settings_get_property)
2750 (emacs_settings_set_property, emacs_settings_class_init)
2751 (emacs_settings_init, gsettings_obj): Remove.
2752 (something_changedCB): New function for HAVE_GSETTINGS.
2753 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2754 with value as argument.
2755 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2756 g_settings_new (Bug#8967). Do not create gsettings_obj.
2757 Remove calls to g_settings_bind. Connect something_changedCB to
2758 "changed".
2759
2760 * xgselect.c: Add defined (HAVE_GSETTINGS).
2761 (xgselect_initialize): Ditto.
2762
2763 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2764 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2765 xg_select.
2766
2767 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2768
2769 * eval.c (struct backtrace): Simplify and port the data structure.
2770 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2771 signed bit field, as this assumption is not portable and it makes
2772 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2773 "char debug_on_exit : 1" as this is not portable either; instead,
2774 use the portable "unsigned int debug_on_exit : 1". Remove unused
2775 member evalargs. Remove obsolete comments about cc bombing out.
2776
2777 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2778
2779 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2780 Let HAVE_GSETTINGS override HAVE_GCONF.
2781 (store_monospaced_changed): New function.
2782 (EMACS_SETTINGS): A new type derived from GObject to handle
2783 GSettings notifications.
2784 (emacs_settings_constructor, emacs_settings_get_property)
2785 (emacs_settings_set_property, emacs_settings_class_init):
2786 New functions.
2787 (gsettings_client, gsettings_obj): New variables.
2788 (GSETTINGS_SCHEMA): New define.
2789 (something_changedCB): Call store_monospaced_changed.
2790 (init_gsettings): New function.
2791 (xsettings_initialize): Call init_gsettings.
2792 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2793 to NULL.
2794
2795 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2796 GCONF_CFLAGS/LIBS.
2797
2798 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2799
2800 * window.c (resize_root_window, grow_mini_window)
2801 (shrink_mini_window): Rename Qresize_root_window to
2802 Qwindow_resize_root_window and Qresize_root_window_vertically to
2803 Qwindow_resize_root_window_vertically.
2804
2805 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2806
2807 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2808
2809 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2810
2811 * makefile.w32-in: Redesign dependencies so they reflect more
2812 clearly which files are directly included by each source file,
2813 and not through other includes.
2814
2815 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2816
2817 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2818 (sort_overlays, overlay_strings): When an overlay's clone number
2819 matches the window's clone number process the overlay even if
2820 the overlay's window property doesn't match the current window.
2821
2822 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2823 (Fwindow_hchild): Rename to Fwindow_left_child.
2824 (Fwindow_next): Rename to Fwindow_next_sibling.
2825 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2826 (resize_window_check): Rename to window_resize_check.
2827 (resize_window_apply): Rename to window_resize_apply.
2828 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2829 (Fdelete_other_windows_internal, resize_frame_windows)
2830 (Fsplit_window_internal, Fdelete_window_internal)
2831 (grow_mini_window, shrink_mini_window)
2832 (Fresize_mini_window_internal): Fix callers accordingly.
2833
2834 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2835
2836 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2837 (emacs_fixed_set_min_size): Remove.
2838 (emacs_fixed_new): Take frame as argument.
2839
2840 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2841 (_EmacsFixedPrivate): Remove minwidth/height.
2842 Add struct frame *f.
2843 (emacs_fixed_init): Initialize priv->f.
2844 (get_parent_class, emacs_fixed_set_min_size): Remove.
2845 (emacs_fixed_new): Set priv->f to argument.
2846 (emacs_fixed_get_preferred_width)
2847 (emacs_fixed_get_preferred_height): Use min_width/height from
2848 frames size_hint to set minimum and natural (Bug#8919).
2849 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2850 and use min_width/height from frames size_hint to set
2851 min_width/height (Bug#8919).
2852
2853 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2854 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2855 Fix indentation.
2856
2857 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2858
2859 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2860 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2861 called at ZV.
2862
2863 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2864
2865 * process.c (wait_reading_process_output): Bypass select if
2866 waiting for a cell while ignoring keyboard input, and input is
2867 pending. Suggested by Jan Djärv (Bug#8869).
2868
2869 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2870
2871 Use gnulib's dup2 module instead of rolling our own.
2872 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2873
2874 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2875
2876 * dispnew.c (scrolling_window): Before scrolling, turn off a
2877 mouse-highlight in the window being scrolled.
2878
2879 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2880
2881 Move DEFSYM to lisp.h and use everywhere.
2882
2883 * character.h (DEFSYM): Move declaration...
2884 * lisp.h (DEFSYM): ...here.
2885
2886 * gnutls.c:
2887 * minibuf.c:
2888 * w32menu.c:
2889 * w32proc.c:
2890 * w32select.c: Don't include character.h.
2891
2892 * alloc.c (syms_of_alloc):
2893 * buffer.c (syms_of_buffer):
2894 * bytecode.c (syms_of_bytecode):
2895 * callint.c (syms_of_callint):
2896 * casefiddle.c (syms_of_casefiddle):
2897 * casetab.c (init_casetab_once):
2898 * category.c (init_category_once, syms_of_category):
2899 * ccl.c (syms_of_ccl):
2900 * cmds.c (syms_of_cmds):
2901 * composite.c (syms_of_composite):
2902 * dbusbind.c (syms_of_dbusbind):
2903 * dired.c (syms_of_dired):
2904 * dispnew.c (syms_of_display):
2905 * doc.c (syms_of_doc):
2906 * editfns.c (syms_of_editfns):
2907 * emacs.c (syms_of_emacs):
2908 * eval.c (syms_of_eval):
2909 * fileio.c (syms_of_fileio):
2910 * fns.c (syms_of_fns):
2911 * frame.c (syms_of_frame):
2912 * fringe.c (syms_of_fringe):
2913 * insdel.c (syms_of_insdel):
2914 * keymap.c (syms_of_keymap):
2915 * lread.c (init_obarray, syms_of_lread):
2916 * macros.c (syms_of_macros):
2917 * msdos.c (syms_of_msdos):
2918 * print.c (syms_of_print):
2919 * process.c (syms_of_process):
2920 * search.c (syms_of_search):
2921 * sound.c (syms_of_sound):
2922 * syntax.c (init_syntax_once, syms_of_syntax):
2923 * terminal.c (syms_of_terminal):
2924 * textprop.c (syms_of_textprop):
2925 * undo.c (syms_of_undo):
2926 * w32.c (globals_of_w32):
2927 * window.c (syms_of_window):
2928 * xdisp.c (syms_of_xdisp):
2929 * xfaces.c (syms_of_xfaces):
2930 * xfns.c (syms_of_xfns):
2931 * xmenu.c (syms_of_xmenu):
2932 * xsettings.c (syms_of_xsettings):
2933 * xterm.c (syms_of_xterm): Use DEFSYM.
2934
2935 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2936
2937 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2938
2939 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2940
2941 Integer and buffer overflow fixes (Bug#8873).
2942
2943 * print.c (printchar, strout): Check for string overflow.
2944 (PRINTPREPARE, printchar, strout):
2945 Don't set size unless allocation succeeds.
2946
2947 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2948 for sizes. Check for string overflow more accurately.
2949 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2950
2951 * macros.c: Integer and buffer overflow fixes.
2952 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2953 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2954 Use ptrdiff_t, not int, for sizes.
2955 Don't increment bufsize until after realloc succeeds.
2956 Check for size-calculation overflow.
2957 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2958
2959 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2960
2961 * lread.c: Integer overflow fixes.
2962 (read_integer): Radix is now EMACS_INT, not int,
2963 to improve quality of diagnostics for out-of-range radices.
2964 Calculate buffer size correctly for out-of-range radices.
2965 (read1): Check for integer overflow in radices, and in
2966 read-circle numbers.
2967 (read_escape): Avoid int overflow.
2968 (Fload, openp, read_buffer_size, read1)
2969 (substitute_object_recurse, read_vector, read_list, map_obarray):
2970 Use ptrdiff_t, not int, for sizes.
2971 (read1): Use EMACS_INT, not int, for sizes.
2972 Check for size overflow.
2973
2974 * image.c (cache_image): Check for size arithmetic overflow.
2975
2976 * lread.c: Integer overflow issues.
2977 (saved_doc_string_size, saved_doc_string_length)
2978 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2979 Now ptrdiff_t, not int.
2980 (read1): Don't assume doc string length fits in int. Check for
2981 out-of-range doc string lengths.
2982 (read_list): Don't assume file position fits in int.
2983 (read_escape): Check for hex character overflow.
2984
2985 2011-06-22 Leo Liu <sdl.web@gmail.com>
2986
2987 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2988 Move to minibuffer.el.
2989
2990 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2993 The following patches are for when GLYPH_DEBUG && !XASSERT.
2994 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2995 * dispnew.c (flush_stdout):
2996 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2997 Mark as externally visible.
2998 * dispnew.c (check_window_matrix_pointers): Now static.
2999 * dispnew.c (window_to_frame_vpos):
3000 * xfns.c (unwind_create_frame):
3001 * xterm.c (x_check_font): Remove unused local.
3002 * scroll.c (CHECK_BOUNDS):
3003 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3004 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3005 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3006 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3007 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3008 Now static.
3009 (debug_method_add): Use va_list and vsprintf rather than relying
3010 on undefined behavior with wrong number of arguments.
3011 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3012 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3013 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3014 since we're not interested in debugging glyphs with old libraries.
3015 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3016 GCC 4.6.0's static checking.
3017
3018 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 Integer overflow and signedness fixes (Bug#8873).
3021 A few related buffer overrun fixes, too.
3022
3023 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3024
3025 * dispextern.h (struct face.stipple):
3026 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3027 (x_bitmap_mask, x_allocate_bitmap_record)
3028 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3029 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3030 (x_create_bitmap_from_xpm_data):
3031 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3032 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3033 (.bitmaps_last):
3034 * xfaces.c (load_pixmap):
3035 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3036 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3037 (.bitmaps_last, struct x_output.icon_bitmap):
3038 Use ptrdiff_t, not int, for bitmap indexes.
3039 (x_allocate_bitmap_record): Check for size overflow.
3040 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3041
3042 Use ptrdiff_t, not int, for overlay counts.
3043 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3044 * editfns.c (overlays_around, get_pos_property):
3045 * textprop.c (get_char_property_and_overlay):
3046 * xdisp.c (next_overlay_change, note_mouse_highlight):
3047 * xfaces.c (face_at_buffer_position):
3048 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3049 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3050 (Fnext_overlay_change, Fprevious_overlay_change)
3051 (mouse_face_overlay_overlaps, Foverlays_in):
3052 Use ptrdiff_t, not int, for sizes.
3053 (overlays_at, overlays_in): Check for size-calculation overflow.
3054
3055 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3056
3057 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3058 (x_session_initialize): Do not assume string length fits in int.
3059
3060 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3061 This is unlikely, but can occur if DPI is outlandish.
3062
3063 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3064 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3065
3066 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3067 * xrdb.c (magic_file_p, search_magic_path):
3068 Omit last arg SUFFIX; it was always 0. All callers changed.
3069 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3070
3071 * xfont.c (xfont_match): Avoid need for strlen.
3072
3073 * xfns.c: Don't assume strlen fits in int.
3074 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3075
3076 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3077 not unsigned long, as we prefer signed integers. All callers changed.
3078 Detect integer overflow in repeat count.
3079 (message_dolog): Don't assume print length fits in 39 bytes.
3080 (display_mode_element): Don't assume strlen fits in int.
3081
3082 * termcap.c: Don't assume sizes fit in int and never overflow.
3083 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3084 (gobble_line): Check for size-calculation overflow.
3085
3086 * minibuf.c (Fread_buffer):
3087 * lread.c (intern, intern_c_string):
3088 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3089 Don't assume string length fits in int.
3090
3091 * keyboard.c (parse_tool_bar_item):
3092 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3093
3094 * font.c: Don't assume string length fits in int.
3095 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3096 Use ptrdiff_t, not int.
3097 (font_intern_prop): Don't assume string length fits in int.
3098 Don't assume integer property fits in fixnum.
3099 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3100
3101 * filelock.c: Fix some buffer overrun and integer overflow issues.
3102 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3103 Reformulate so as not to need the command string.
3104 Invoke gzip -cd rather than gunzip, as it's more portable.
3105 (lock_info_type, lock_file_1, lock_file):
3106 Don't assume pid_t and time_t fit in unsigned long.
3107 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3108 (current_lock_owner): Prefer signed type for sizes.
3109 Use memcpy, not strncpy, where memcpy is what is really wanted.
3110 Don't assume (via atoi) that time_t and pid_t fit in int.
3111 Check for time_t and/or pid_t out of range, e.g., via a network share.
3112 Don't alloca where an auto var works fine.
3113
3114 * fileio.c: Fix some integer overflow issues.
3115 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3116 Don't assume string length fits in int.
3117 (directory_file_name): Don't assume string length fits in long.
3118 (make_temp_name): Don't assume pid fits in int, or that its print
3119 length is less than 20.
3120
3121 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3122
3123 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3124
3125 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3126
3127 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3128 We prefer signed integers, even for size calculations.
3129
3130 * emacs.c: Don't assume string length fits in 'int'.
3131 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3132 (main): Don't invoke strlen when not needed.
3133
3134 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3135 (XD_DEBUG_MESSAGE): Don't waste a byte.
3136
3137 * callproc.c (getenv_internal_1, getenv_internal)
3138 (Fgetenv_internal):
3139 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3140
3141 * lread.c (invalid_syntax): Omit length argument.
3142 All uses changed. This doesn't fix a bug, but it simplifies the
3143 code away from its former Hollerith-constant appearance, and it's
3144 one less 'int' to worry about when looking at integer-overflow issues.
3145 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3146
3147 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3148 This didn't break anything, but it didn't help either.
3149 It's confusing to put a bogus integer in a place where the actual
3150 value does not matter.
3151 (LIST_END_P): Remove unused macro and its bogus comment.
3152 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3153
3154 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3155 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3156 implementation.
3157 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3158 We prefer signed types, and the value cannot exceed the EMACS_INT
3159 range anyway (because otherwise the length would not be representable).
3160 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3161 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3162 This avoids a GCC warning when WIDE_EMACS_INT.
3163
3164 * indent.c (sane_tab_width): New function.
3165 (current_column, scan_for_column, Findent_to, position_indentation)
3166 (compute_motion): Use it. This is just for clarity.
3167 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3168
3169 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3170
3171 * lisp.h (lint_assume): New macro.
3172 * composite.c (composition_gstring_put_cache):
3173 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3174
3175 * editfns.c, insdel.c:
3176 Omit unnecessary forward decls, to simplify future changes.
3177
3178 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3179
3180 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3181
3182 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3183 Use much-faster test for byte-length change.
3184 Don't assume string byte-length fits in 'int'.
3185 Check that character arg fits in 'int'.
3186 (mapcar1): Declare byte as byte, for clarity.
3187
3188 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3189
3190 * fns.c (concat): Catch string overflow earlier.
3191 Do not rely on integer wraparound.
3192
3193 * dispextern.h (struct it.overlay_strings_charpos)
3194 (struct it.selective): Now EMACS_INT, not int.
3195 * xdisp.c (forward_to_next_line_start)
3196 (back_to_previous_visible_line_start)
3197 (reseat_at_next_visible_line_start, next_element_from_buffer):
3198 Don't arbitrarily truncate the value of 'selective' to int.
3199
3200 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3201
3202 * composite.c: Don't truncate sizes to 'int'.
3203 (composition_gstring_p, composition_reseat_it)
3204 (composition_adjust_point): Use EMACS_INT, not int.
3205 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3206 not EMACS_UINT, for indexes.
3207
3208 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3209
3210 * buffer.c: Include <verify.h>.
3211 (struct sortvec.priority, struct sortstr.priority):
3212 Now EMACS_INT, not int.
3213 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3214 (struct sortstr.size, record_overlay_string)
3215 (struct sortstrlist.size, struct sortlist.used):
3216 Don't truncate size to int.
3217 (record_overlay_string): Check for size-calculation overflow.
3218 (init_buffer_once): Check at compile-time, not run-time.
3219
3220 2011-06-22 Jim Meyering <meyering@redhat.com>
3221
3222 Don't leak an XBM-image-sized buffer
3223 * image.c (xbm_load): Free the image buffer after using it.
3224
3225 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 Port to Sun C.
3228 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3229 that Sun C diagnosed.
3230 * fns.c (secure_hash): Fix pointer signedness issue.
3231 * intervals.c (static_offset_intervals): New function.
3232 (offset_intervals): Use it.
3233
3234 2011-06-21 Leo Liu <sdl.web@gmail.com>
3235
3236 * deps.mk (fns.o):
3237 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3238 sha512.h.
3239
3240 * fns.c (secure_hash): Rename from crypto_hash_function and change
3241 the first arg to accept symbols.
3242 (Fsecure_hash): New primitive.
3243 (syms_of_fns): New symbols.
3244
3245 2011-06-20 Deniz Dogan <deniz@dogan.se>
3246
3247 * process.c (Fset_process_buffer): Clarify return value in
3248 docstring.
3249
3250 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3251
3252 * dispnew.c (add_window_display_history): Use BVAR.
3253
3254 * xdisp.c (debug_method_add): Use BVAR.
3255 (check_window_end, dump_glyph_matrix, dump_glyph)
3256 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3257
3258 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3259 Likewise.
3260
3261 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3262 check till after the cache is created in init_frame_faces.
3263
3264 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3265
3266 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3267
3268 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3271 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3272 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3273
3274 Improve buffer-overflow checking (Bug#8873).
3275 * fileio.c (Finsert_file_contents):
3276 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3277 Remove the old (too-loose) buffer overflow checks.
3278 They weren't needed, since make_gap checks for buffer overflow.
3279 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3280 The old code merely checked for Emacs fixnum overflow, and relied
3281 on undefined (wraparound) behavior. The new code avoids undefined
3282 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3283
3284 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3285 Tune. Don't use wider integers than needed. Don't use alloca.
3286 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3287
3288 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3289
3290 * insdel.c, lisp.h (buffer_overflow): New function.
3291 (insert_from_buffer_1, replace_range, replace_range_2):
3292 * insdel.c (make_gap_larger):
3293 * editfns.c (Finsert_char):
3294 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3295
3296 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3297
3298 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3299
3300 Integer overflow and signedness fixes (Bug#8873).
3301
3302 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3303 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3304
3305 * fileio.c: Don't assume EMACS_INT fits in off_t.
3306 (emacs_lseek): New static function.
3307 (Finsert_file_contents, Fwrite_region): Use it.
3308 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3309
3310 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3311
3312 * fns.c: Don't overflow int when computing a list length.
3313 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3314 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3315 truncation on 64-bit hosts. Check for QUIT every
3316 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3317 faster and is responsive enough.
3318 (Flength): Report an error instead of overflowing an integer.
3319 (Fsafe_length): Return a float if the value is not representable
3320 as a fixnum. This shouldn't happen except in contrived situations.
3321 (Fnthcdr, Fsort): Don't assume list length fits in int.
3322 (Fcopy_sequence): Don't assume vector length fits in int.
3323
3324 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3325 (header_size, word_size): New constants.
3326 (allocate_vectorlike): Don't check size overflow here.
3327 (allocate_vector): Check it here instead, since this is the only
3328 caller of allocate_vectorlike that could cause overflow.
3329 Check that the new vector's length is representable as a fixnum.
3330
3331 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3332 The previous code was bogus. For example, next_almost_prime (32)
3333 returned 39, which is undesirable as it is a multiple of 3; and
3334 next_almost_prime (24) returned 25, which is a multiple of 5 so
3335 why was the code bothering to check for multiples of 7?
3336
3337 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3338
3339 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3340
3341 Variadic C functions now count arguments with ptrdiff_t.
3342 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3343 Back then I didn't know that the Emacs coding style prefers signed int.
3344 Also, in the meantime I found a few more instances where arguments
3345 were being counted with int, which may truncate counts on 64-bit
3346 machines, or EMACS_INT, which may be unnecessarily wide.
3347 * lisp.h (struct Lisp_Subr.function.aMANY)
3348 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3349 Arg counts are now ptrdiff_t, not size_t.
3350 All variadic functions and their callers changed accordingly.
3351 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3352 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3353 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3354 * callint.c (Fcall_interactively): Check arg count for overflow,
3355 to avoid potential buffer overrun. Use signed char, not 'int',
3356 for 'varies' array, so that we needn't bother to check its size
3357 calculation for overflow.
3358 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3359 * eval.c (apply_lambda):
3360 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3361 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3362 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3363
3364 * callint.c (Fcall_interactively): Don't use index var as event count.
3365
3366 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3367 * mem-limits.h (SIZE): Remove; no longer used.
3368
3369 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3370
3371 Remove unnecessary casts.
3372 * xterm.c (x_term_init):
3373 * xfns.c (x_set_border_pixel):
3374 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3375 These aren't needed now that we assume ANSI C.
3376
3377 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3378 It's more likely to cause problems (due to unsigned overflow)
3379 than to cure them.
3380
3381 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3382
3383 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3384
3385 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3386
3387 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3388
3389 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3390
3391 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3392
3393 GLYPH_CODE_FACE returns EMACS_INT, not int.
3394 * dispextern.h (merge_faces):
3395 * xfaces.c (merge_faces):
3396 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3397 Don't assume EMACS_INT fits in int.
3398
3399 * character.h (CHAR_VALID_P): Remove unused parameter.
3400 * fontset.c, lisp.h, xdisp.c: All uses changed.
3401
3402 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3403
3404 * fns.c (concat): Minor tuning based on overflow analysis.
3405 This doesn't fix any bugs. Use int to hold character, instead
3406 of constantly refetching from Emacs object. Use XFASTINT, not
3407 XINT, for value known to be a character. Don't bother comparing
3408 a single byte to 0400, as it's always less.
3409
3410 * floatfns.c (Fexpt):
3411 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3412
3413 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3414 for characters.
3415
3416 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3417
3418 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3419 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3420 incorrectly succeed when S was a string, because 4294967386 was
3421 truncated before it was used.
3422
3423 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3424 Otherwise, an out-of-range integer could cause undefined behavior
3425 on a 64-bit host.
3426
3427 * composite.c: Use int, not EMACS_INT, for characters.
3428 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3429 EMACS_INT, for values that are known to be in character range.
3430 This doesn't fix any bugs but is the usual style inside Emacs and
3431 may generate better code on 32-bit machines.
3432
3433 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3434 This is for reasons similar to the recent CHAR_STRING fix.
3435 * charset.c (Fencode_char): Check that character arg is actually
3436 a character. Pass an int to ENCODE_CHAR.
3437 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3438 wider than 'int', as a compile-time check to prevent future regressions
3439 in this area.
3440
3441 * character.c (char_string): Remove unnecessary casts.
3442
3443 Make sure a 64-bit char is never passed to CHAR_STRING.
3444 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3445 by silently ignoring the top 32 bits, allowing some values
3446 that were far too large to be valid characters.
3447 * character.h: Include <verify.h>.
3448 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3449 arguments are no wider than unsigned, as a compile-time check
3450 to prevent future regressions in this area.
3451 * data.c (Faset):
3452 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3453 (Fsubst_char_in_region):
3454 * fns.c (concat):
3455 * xdisp.c (decode_mode_spec_coding):
3456 Adjust to CHAR_STRING's new requirement.
3457 * editfns.c (Finsert_char, Fsubst_char_in_region):
3458 * fns.c (concat): Check that character args are actually
3459 characters. Without this test, these functions did the wrong
3460 thing with wildly out-of-range values on 64-bit hosts.
3461
3462 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3463 These casts should not be needed on 32-bit hosts, either.
3464 * keyboard.c (read_char):
3465 * lread.c (Fload): Remove casts to unsigned.
3466
3467 * lisp.h (UNSIGNED_CMP): New macro.
3468 This fixes comparison bugs on 64-bit hosts.
3469 (ASCII_CHAR_P): Use it.
3470 * casefiddle.c (casify_object):
3471 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3472 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3473 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3474 * dispextern.h (FACE_FROM_ID):
3475 * keyboard.c (read_char): Use UNSIGNED_CMP.
3476
3477 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3478 not to EMACS_INT, to avoid GCC warning.
3479
3480 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3481
3482 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3483 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3484 isn't needed on 32-bit machines.
3485
3486 * buffer.c (Fgenerate_new_buffer_name):
3487 Use EMACS_INT for count, not int.
3488 (advance_to_char_boundary): Return EMACS_INT, not int.
3489
3490 * data.c (Qcompiled_function): Now static.
3491
3492 * window.c (window_body_lines): Now static.
3493
3494 * image.c (gif_load): Rename local to avoid shadowing.
3495
3496 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3497 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3498 * alloc.c (make_save_value): Integer argument is now of type
3499 ptrdiff_t, not int.
3500 (mark_object): Use ptrdiff_t, not int.
3501 * lisp.h (pD): New macro.
3502 * print.c (print_object): Use it.
3503
3504 * alloc.c: Use EMACS_INT, not int, to count objects.
3505 (total_conses, total_markers, total_symbols, total_vector_size)
3506 (total_free_conses, total_free_markers, total_free_symbols)
3507 (total_free_floats, total_floats, total_free_intervals)
3508 (total_intervals, total_strings, total_free_strings):
3509 Now EMACS_INT, not int. All uses changed.
3510 (Fgarbage_collect): Compute overall total using a double, so that
3511 integer overflow is less likely to be a problem. Check for overflow
3512 when converting back to an integer.
3513 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3514 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3515 These were 'int' variables that could overflow on 64-bit hosts;
3516 they were never used, so remove them instead of repairing them.
3517 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3518 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3519 Previously, this ceilinged at INT_MAX, but that doesn't work on
3520 64-bit machines.
3521 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3522
3523 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3524 (allocate_vectorlike): Check for ptrdiff_t overflow.
3525 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3526 when a (possibly-narrower) signed value would do just as well.
3527 We prefer using signed arithmetic, to avoid comparison confusion.
3528
3529 * alloc.c: Catch some string size overflows that we were missing.
3530 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3531 for convenience in STRING_BYTES_MAX.
3532 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3533 The definition here is exact; the one in lisp.h was approximate.
3534 (allocate_string_data): Check for string overflow. This catches
3535 some instances we weren't catching before. Also, it catches
3536 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3537 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3538 and ptrdiff_t and EMACS_INT are both 64 bits.
3539
3540 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3541 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3542 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3543
3544 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3545
3546 * alloc.c (Fmake_string): Check for out-of-range init.
3547
3548 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3549
3550 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3551
3552 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3553
3554 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3555 xg_get_default_scrollbar_width.
3556
3557 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3558 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3559 (style_changed_cb): Call update_theme_scrollbar_width and call
3560 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3561 all frames (Bug#8505).
3562 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3563 Call gtk_window_set_resizable if HAVE_GTK3.
3564 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3565 and height if HAVE_GTK3 (Bug#8505).
3566 (scroll_bar_width_for_theme): New variable.
3567 (update_theme_scrollbar_width): New function.
3568 (xg_get_default_scrollbar_width): Move code to
3569 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3570 (xg_initialize): Call update_theme_scrollbar_width.
3571
3572 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3573
3574 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3575
3576 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3577
3578 * frame.c (make_frame): Call other_buffer_safely instead of
3579 other_buffer.
3580
3581 * window.c (temp_output_buffer_show): Call display_buffer with
3582 second argument Vtemp_buffer_show_specifiers and reset latter
3583 immediately after the call.
3584 (Vtemp_buffer_show_specifiers): New variable.
3585 (auto_window_vscroll_p, next_screen_context_lines)
3586 (Vscroll_preserve_screen_position): Remove leading asterisks from
3587 doc-strings.
3588
3589 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 Fix minor problems found by GCC 4.6.0 static checking.
3592 * buffer.c (Qclone_number): Remove for now, as it's unused.
3593 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3594 (record_buffer): Remove unused local.
3595 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3596 (set_frame_buffer_list): Remove; unused.
3597 * frame.h (other_visible_frames): Remove decl.
3598 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3599 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3600 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3601 if HAVE_GPM.
3602 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3603 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3604 Define only if HAVE_GPM.
3605 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3606 (update_hints_inhibit): Remove; never set. All uses removed.
3607 * widgetprv.h (emacsFrameClassRec): Remove decl.
3608 * window.c (delete_deletable_window): Now returns void, since it
3609 wasn't returning anything.
3610 (compare_window_configurations): Remove unused locals.
3611 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3612 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3613 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3614 the same widths as pointers. This follows up on the 2011-05-06 patch.
3615 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3616 * xterm.h: Likewise.
3617 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3618
3619 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3620
3621 * makefile.w32-in: Update dependencies.
3622 (LISP_H): Add lib/intprops.h.
3623
3624 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3625
3626 * image.c (gif_load): Add animation frame delay to the metadata.
3627 (syms_of_image): Use DEFSYM. New symbol `delay'.
3628
3629 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3630
3631 * window.c (delete_deletable_window): Re-add.
3632 (Fset_window_configuration): Rewrite to handle dead buffers and
3633 consequently deletable windows.
3634 (window_tree, Fwindow_tree): Remove. Supply functionality in
3635 window.el.
3636 (compare_window_configurations): Simplify code.
3637
3638 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3639
3640 * image.c (imagemagick_load_image): Fix type mismatch.
3641 (Fimagemagick_types): Likewise.
3642
3643 * window.h (replace_buffer_in_windows): Declare.
3644
3645 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3646
3647 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3648 Qclone_number. Remove external declaration of Qdelete_window.
3649 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3650 code.
3651 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3652 Run Qbuffer_list_update_hook if allowed.
3653 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3654 buffer list implementation.
3655 (other_buffer_safely): New function.
3656 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3657 calls to replace_buffer_in_windows and
3658 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3659 if allowed.
3660 (record_buffer): Inhibit quitting and rewrite using quittable
3661 functions. Run Qbuffer_list_update_hook if allowed.
3662 (Frecord_buffer, Funrecord_buffer): New functions.
3663 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3664 Move switch-to-buffer to window.el.
3665 (bury-buffer): Move to window.el.
3666 (Vbuffer_list_update_hook): New variable.
3667
3668 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3669 section.
3670
3671 * window.h (resize_frame_windows): Move up in code.
3672 (Fwindow_frame): Remove EXFUN.
3673 (replace_buffer_in_all_windows): Remove prototype.
3674 (replace_buffer_in_windows_safely): Add prototype.
3675
3676 * window.c: Declare Qdelete_window static again. Move down
3677 declaration of select_count.
3678 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3679 (Fother_window): Move to window.el.
3680 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3681 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3682 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3683 window.el.
3684 (replace_buffer_in_windows): Implement by calling
3685 Qreplace_buffer_in_windows.
3686 (replace_buffer_in_all_windows): Remove with some functionality
3687 moved into replace_buffer_in_windows_safely.
3688 (replace_buffer_in_windows_safely): New function.
3689 (select_window_norecord, select_frame_norecord): Move in front
3690 of run_window_configuration_change_hook. Remove now obsolete
3691 declarations.
3692 (Fset_window_buffer): Rewrite doc-string.
3693 Call Qrecord_window_buffer.
3694 (keys_of_window): Move binding for other-window to window.el.
3695
3696 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3697
3698 * dispextern.h (struct image): Replace data member, whose int_val
3699 and ptr_val fields were not used by anything, with a single
3700 lisp_val object.
3701
3702 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3703 (gif_clear_image, gif_load, imagemagick_load_image)
3704 (gs_clear_image, gs_load): Callers changed.
3705
3706 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3707
3708 * buffer.h: Include <time.h>, for time_t.
3709 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3710
3711 Fix minor problems found by static checking.
3712
3713 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3714
3715 Make identifiers static if they are not used in other modules.
3716 * data.c (Qcompiled_function, Qframe, Qvector):
3717 * image.c (QimageMagick, Qsvg):
3718 * minibuf.c (Qmetadata):
3719 * window.c (resize_window_check, resize_root_window): Now static.
3720 * window.h (resize_window_check, resize_root_window): Remove decls.
3721
3722 * window.c (window_deletion_count, delete_deletable_window):
3723 Remove; unused.
3724 (window_body_lines): Now static.
3725 (Fdelete_other_windows_internal): Mark vars as initialized.
3726 Make sure 'resize_failed' is initialized.
3727 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3728 (resize_window_apply): Remove unused local.
3729 * window.h (delete_deletable_window): Remove decl.
3730
3731 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3732 (imagemagick_load_image): Fix pointer signedness problem by changing
3733 last arg from unsigned char * to char *. All uses changed.
3734 Also, fix a local for similar reasons.
3735 Remove unused locals. Remove locals to avoid shadowing.
3736 (fn_rsvg_handle_free): Remove; unused.
3737 (svg_load, svg_load_image): Fix pointer signedness problem.
3738 (imagemagick_load_image): Don't use garbage pointer image_wand.
3739
3740 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3741
3742 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3743
3744 * image.c (gif_load): Fix omitted cast error introduced by
3745 2011-06-06 change.
3746
3747 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3748
3749 * window.h (resize_proportionally, orig_total_lines)
3750 (orig_top_line): Remove from window structure.
3751 (set_window_height, set_window_width, change_window_heights)
3752 (Fdelete_window): Remove prototypes.
3753 (resize_frame_windows): Remove duplicate declaration.
3754
3755 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3756
3757 * window.h (resize_frame_windows, resize_window_check)
3758 (delete_deletable_window, resize_root_window)
3759 (resize_frame_windows): Declare prototypes.
3760
3761 * window.c (resize_window_apply): Make definition be "static" to
3762 match the prototype.
3763
3764 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3765
3766 * window.c: Remove declarations of Qwindow_size_fixed,
3767 window_min_size_1, window_min_size_2, window_min_size,
3768 size_window, window_fixed_size_p, enlarge_window, delete_window.
3769 Remove static from declaration of Qdelete_window, it's
3770 temporarily needed by Fbury_buffer.
3771 (replace_window): Don't assign orig_top_line and
3772 orig_total_lines.
3773 (Fdelete_window, delete_window): Remove. Window deletion is
3774 handled by window.el.
3775 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3776 Replace Fdelete_window calls with calls to Qdelete_window.
3777 (Fdelete_other_windows): Remove. Deleting other windows is
3778 handled by window.el.
3779 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3780 handled in window.el.
3781 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3782 Window minimum sizes are handled in window.el.
3783 (shrink_windows, size_window, set_window_height)
3784 (set_window_width, change_window_heights, window_height)
3785 (window_width, CURBEG, CURSIZE, enlarge_window)
3786 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3787 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3788 handled in window.el.
3789 (make_dummy_parent): Rename to make_parent_window and give it a
3790 second argument horflag.
3791 (make_window): Don't set resize_proportionally any more.
3792 (Fsplit_window): Remove. Windows are split in window.el.
3793 (save_restore_action, save_restore_orig_size)
3794 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3795 Resize mini windows in window.el.
3796 (grow_mini_window, shrink_mini_window): Implement by calling
3797 Qresize_root_window_vertically, resize_window_check and
3798 resize_window_apply.
3799 (saved_window, Fset_window_configuration, save_window_save):
3800 Do not handle orig_top_line, orig_total_lines, and
3801 resize_proportionally.
3802 (window_min_height, window_min_width): Move to window.el.
3803 (keys_of_window): Move bindings for delete-other-windows,
3804 split-window, delete-window and enlarge-window to window.el.
3805
3806 * buffer.c: Temporarily extern Qdelete_window.
3807 (Fbury_buffer): Temporarily call Qdelete_window instead of
3808 Fdelete_window (Fbury_buffer will move to window.el soon).
3809
3810 * frame.c (set_menu_bar_lines_1): Remove code handling
3811 orig_top_line and orig_total_lines.
3812
3813 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3814 set_window_height but set heights directly.
3815 (change_frame_size_1): Use resize_frame_windows.
3816
3817 * xdisp.c (init_xdisp): Don't use set_window_height but set
3818 heights directly.
3819
3820 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3821 Use resize_frame_windows instead of change_window_heights and run
3822 run_window_configuration_change_hook.
3823
3824 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3825 instead of change_window_heights and run
3826 run_window_configuration_change_hook.
3827
3828 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3829
3830 * window.c (replace_window): Rename second argument REPLACEMENT to
3831 NEW. New third argument SETFLAG. Rewrite.
3832 (delete_window, make_dummy_parent): Call replace_window with
3833 third argument 1.
3834 (window_list_1): Move down in code.
3835 (run_window_configuration_change_hook): Move set_buffer part
3836 before select_frame_norecord part in order to unwind correctly.
3837 Rename count1 to count.
3838 (recombine_windows, delete_deletable_window, resize_root_window)
3839 (Fdelete_other_windows_internal)
3840 (Frun_window_configuration_change_hook, make_parent_window)
3841 (resize_window_check, resize_window_apply, Fresize_window_apply)
3842 (resize_frame_windows, Fsplit_window_internal)
3843 (Fdelete_window_internal, Fresize_mini_window_internal):
3844 New functions.
3845 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3846
3847 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3848
3849 * window.h (window): Add some new members to window structure -
3850 normal_lines, normal_cols, new_total, new_normal, clone_number,
3851 splits, nest, prev_buffers, next_buffers.
3852 (WINDOW_TOTAL_SIZE): Move here from window.c.
3853 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3854
3855 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3856 Remove.
3857 (make_dummy_parent): Set new members of windows structure.
3858 (make_window): Move down in code. Handle new members of window
3859 structure.
3860 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3861 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3862 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3863 (Fset_window_prev_buffers, Fwindow_next_buffers)
3864 (Fset_window_next_buffers, Fset_window_clone_number):
3865 New functions.
3866 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3867 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3868 Doc-string fixes.
3869 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3870 Argument WINDOW can be now internal window too.
3871 (Fwindow_use_time): Move up in code.
3872 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3873 Rewrite doc-string.
3874 (Fset_window_configuration, saved_window)
3875 (Fcurrent_window_configuration, save_window_save): Handle new
3876 members of window structure.
3877 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3878 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3879 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3880 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3881 Qget_mru_window, Qresize_root_window,
3882 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3883 Qauto_buffer_name; staticpro them.
3884
3885 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3886
3887 * window.c (Fwindow_total_size, Fwindow_left_column)
3888 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3889 (Fwindow_list_1): New functions.
3890 (window_box_text_cols): Replace with window_body_cols.
3891 (Fwindow_width, Fscroll_left, Fscroll_right):
3892 Use window_body_cols instead of window_box_text_cols.
3893 (delete_window, Fset_window_configuration):
3894 Call delete_all_subwindows with window as argument.
3895 (delete_all_subwindows): Take a window as argument and not a
3896 structure. Rewrite.
3897 (window_loop): Remove handling of GET_LRU_WINDOW and
3898 GET_LARGEST_WINDOW.
3899 (Fget_lru_window, Fget_largest_window): Move to window.el.
3900
3901 * window.h: Extern window_body_cols instead of
3902 window_box_text_cols. delete_all_subwindows now takes a
3903 Lisp_Object as argument.
3904
3905 * indent.c (compute_motion, Fcompute_motion):
3906 Use window_body_cols instead of window_box_text_cols.
3907
3908 * frame.c (delete_frame): Call delete_all_subwindows with root
3909 window as argument.
3910
3911 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3912
3913 * fns.c (Fputhash): Document return value.
3914
3915 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3916
3917 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3918
3919 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3920
3921 Cons<->int and similar integer overflow fixes (Bug#8794).
3922
3923 Check for overflow when converting integer to cons and back.
3924 * charset.c (Fdefine_charset_internal, Fdecode_char):
3925 Use cons_to_unsigned to catch overflow.
3926 (Fencode_char): Use INTEGER_TO_CONS.
3927 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3928 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3929 * data.c (long_to_cons, cons_to_long): Remove.
3930 (cons_to_unsigned, cons_to_signed): New functions.
3931 These signal an error for invalid or out-of-range values.
3932 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3933 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3934 * font.c (Ffont_variation_glyphs):
3935 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3936 * lisp.h: Include <intprops.h>.
3937 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3938 (cons_to_signed, cons_to_unsigned): New decls.
3939 (long_to_cons, cons_to_long): Remove decls.
3940 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3941 (Fprimitive_undo): Use CONS_TO_INTEGER.
3942 * xfns.c (Fx_window_property): Likewise.
3943 * xselect.c: Include <limits.h>.
3944 (x_own_selection, selection_data_to_lisp_data):
3945 Use INTEGER_TO_CONS.
3946 (x_handle_selection_request, x_handle_selection_clear)
3947 (x_get_foreign_selection, Fx_disown_selection_internal)
3948 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3949 (lisp_data_to_selection_data): Use cons_to_unsigned.
3950 (x_fill_property_data): Use cons_to_signed.
3951 Report values out of range.
3952
3953 Check for buffer and string overflow more precisely.
3954 * buffer.h (BUF_BYTES_MAX): New macro.
3955 * lisp.h (STRING_BYTES_MAX): New macro.
3956 * alloc.c (Fmake_string):
3957 * character.c (string_escape_byte8):
3958 * coding.c (coding_alloc_by_realloc):
3959 * doprnt.c (doprnt):
3960 * editfns.c (Fformat):
3961 * eval.c (verror):
3962 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3963 since they may not be the same number.
3964 * editfns.c (Finsert_char):
3965 * fileio.c (Finsert_file_contents):
3966 Likewise for BUF_BYTES_MAX.
3967
3968 * image.c: Use ptrdiff_t, not int, for sizes.
3969 (slurp_file): Switch from int to ptrdiff_t.
3970 All uses changed.
3971 (slurp_file): Check that file size fits in both size_t (for
3972 malloc) and ptrdiff_t (for sanity and safety).
3973
3974 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3975 if b->modtime has its maximal value.
3976
3977 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3978
3979 Don't assume time_t can fit into int.
3980 * buffer.h (struct buffer.modtime): Now time_t, not int.
3981 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3982 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3983
3984 Minor fixes for signed vs unsigned integers.
3985 * character.h (MAYBE_UNIFY_CHAR):
3986 * charset.c (maybe_unify_char):
3987 * keyboard.c (read_char, reorder_modifiers):
3988 XINT -> XFASTINT, since the integer must be nonnegative.
3989 * ftfont.c (ftfont_spec_pattern):
3990 * keymap.c (access_keymap, silly_event_symbol_error):
3991 XUINT -> XFASTINT, since the integer must be nonnegative.
3992 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3993 since it makes no difference and we prefer signed.
3994 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3995 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3996 nonnegative.
3997
3998 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3999
4000 * window.h (Fwindow_frame): Declare.
4001
4002 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4003
4004 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4005 (SPARE_MEMORY): Always define.
4006 (LARGE_REQUEST): Remove.
4007 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4008
4009 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4010
4011 * lisp.h: Move EXFUNS for Fframe_root_window,
4012 Fframe_first_window and Fset_frame_selected_window to window.h.
4013
4014 * window.h: Move EXFUNS for Fframe_root_window,
4015 Fframe_first_window and Fset_frame_selected_window here from
4016 lisp.h.
4017
4018 * frame.c (Fwindow_frame, Fframe_first_window)
4019 (Fframe_root_window, Fframe_selected_window)
4020 (Fset_frame_selected_window): Move to window.c.
4021 (Factive_minibuffer_window): Move to minibuf.c.
4022 (Fother_visible_frames_p): New function.
4023
4024 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4025
4026 * window.c (decode_window, decode_any_window): Move up in code.
4027 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4028 (inhibit_frame_unsplittable): Remove unused variable.
4029 (Fwindow_buffer): Move up and rewrite doc-string.
4030 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4031 (Fwindow_prev): New functions.
4032 (Fwindow_frame): Move here from frame.c. Accept any window as
4033 argument.
4034 (Fframe_root_window, Fframe_first_window)
4035 (Fframe_selected_window): Move here from frame.c. Accept frame
4036 or arbitrary window as argument. Update doc-strings.
4037 (Fminibuffer_window): Move up in code.
4038 (Fwindow_minibuffer_p): Move up in code and simplify.
4039 (Fset_frame_selected_window): Move here from frame.c.
4040 Marginal rewrite.
4041 (Fselected_window, select_window, Fselect_window): Move up in
4042 code. Minor doc-string fixes.
4043
4044 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4045
4046 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4047 Do not assume that spare memory exists; that assumption is valid
4048 only if SYSTEM_MALLOC.
4049 (LARGE_REQUEST): New macro, so that the issue of large requests
4050 is separated from the issue of spare memory.
4051
4052 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4053
4054 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4055 format. (Bug#8806)
4056
4057 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4058
4059 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4060 before statements.
4061
4062 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4063
4064 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4065
4066 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4067
4068 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4069 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4070
4071 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4072
4073 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4074
4075 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4076
4077 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4078 (x_clipboard_manager_save): Add return value.
4079 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4080 New error handlers.
4081 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4082 Obey Vx_select_enable_clipboard_manager. Catch errors in
4083 x_clipboard_manager_save (Bug#8779).
4084 (Vx_select_enable_clipboard_manager): New variable.
4085 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4086
4087 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4088
4089 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4090
4091 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4092
4093 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4094 in the current matrix if keep_current_p is non-zero.
4095
4096 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4097
4098 * bidi.c (bidi_level_of_next_char): Fix last change.
4099
4100 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4101
4102 Support bidi reordering of text covered by display properties.
4103
4104 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4105 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4106 (bidi_cache_search, bidi_cache_iterator_state)
4107 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4108 (bidi_level_of_next_char, bidi_move_to_visually_next):
4109 Support character positions inside a run of characters covered by a
4110 display string.
4111 (bidi_paragraph_init, bidi_resolve_explicit_1)
4112 (bidi_level_of_next_char): Call bidi_fetch_char and
4113 bidi_fetch_char_advance instead of FETCH_CHAR and
4114 FETCH_CHAR_ADVANCE.
4115 (bidi_init_it): Initialize new members.
4116 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4117 definitions.
4118 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4119 instead of using explicit *_CHAR codes.
4120 (bidi_resolve_explicit, bidi_resolve_weak):
4121 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4122 bidirectional text is supported only in multibyte buffers.
4123 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4124 it to initialize the frame_window_p member of struct bidi_it.
4125 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4126 (bidi_resolve_explicit, bidi_resolve_weak)
4127 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4128 bidi_it->nchars is non-positive.
4129 (bidi_level_of_next_char): Don't try to lookup the cache for the
4130 next/previous character if nothing is cached there yet, or if we
4131 were just reseat()'ed to a new position.
4132
4133 * xdisp.c (set_cursor_from_row): Set start and stop points
4134 according to the row's direction when priming the loop that looks
4135 for the glyph on which to display cursor.
4136 (single_display_spec_intangible_p): Function deleted.
4137 (display_prop_intangible_p): Reimplement to call
4138 handle_display_spec instead of single_display_spec_intangible_p.
4139 Accept 3 additional arguments needed by handle_display_spec.
4140 This fixes incorrect cursor motion across display property with complex
4141 values: lists, `(when COND...)' forms, etc.
4142 (single_display_spec_string_p): Support property values that are
4143 lists with the argument STRING its top-level element.
4144 (display_prop_string_p): Fix the condition for processing a
4145 property that is a list to be consistent with handle_display_spec.
4146 (handle_display_spec): New function, refactored from the
4147 last portion of handle_display_prop.
4148 (compute_display_string_pos): Accept additional argument
4149 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4150 value of a `display' property is a "replacing spec".
4151 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4152 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4153 the display property, but just return a value indicating whether
4154 the display property will replace the characters it covers.
4155 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4156 frame_window_p members of struct bidi_it.
4157 (compute_display_string_pos, compute_display_string_end):
4158 New functions.
4159 (push_it): Accept second argument POSITION, where pop_it should
4160 jump to continue iteration.
4161 (reseat_1): Initialize bidi_it.disp_pos.
4162
4163 * keyboard.c (adjust_point_for_property): Adjust the call to
4164 display_prop_intangible_p to its new signature.
4165
4166 * dispextern.h (struct bidi_it): New member frame_window_p.
4167 (bidi_init_it): Update prototypes.
4168 (display_prop_intangible_p): Update prototype.
4169 (compute_display_string_pos, compute_display_string_end):
4170 Declare prototypes.
4171 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4172 EMACS_INT.
4173
4174 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4175
4176 Malloc failure behavior now depends on size of allocation.
4177 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4178 * lisp.h: Change signatures accordingly.
4179 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4180 All callers changed. (Bug#8762)
4181
4182 * gnutls.c: Use Emacs's memory allocators.
4183 Without this change, the gnutls library would invoke malloc etc.
4184 directly, which causes problems on non-SYNC_INPUT hosts, and which
4185 runs afoul of improving memory_full behavior. (Bug#8761)
4186 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4187 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4188 xfree instead of the default malloc, realloc, free.
4189 (Fgnutls_boot): No need to check for memory allocation failure,
4190 since xmalloc does that for us.
4191
4192 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4193 * category.c (hash_get_category_set):
4194 * ccl.c (ccl_driver):
4195 * charset.c (Fdefine_charset_internal):
4196 * charset.h (struct charset.hash_index):
4197 * composite.c (get_composition_id, gstring_lookup_cache)
4198 (composition_gstring_put_cache):
4199 * composite.h (struct composition.hash_index):
4200 * dispextern.h (struct image.hash):
4201 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4202 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4203 (hashfn_equal, hashfn_user_defined, make_hash_table)
4204 (maybe_resize_hash_table, hash_lookup, hash_put)
4205 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4206 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4207 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4208 * image.c (make_image, search_image_cache, lookup_image)
4209 (xpm_put_color_table_h):
4210 * lisp.h (struct Lisp_Hash_Table):
4211 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4212 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4213 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4214 * alloc.c (allocate_vectorlike):
4215 Check for overflow in vector size calculations.
4216 * ccl.c (ccl_driver):
4217 Check for overflow when converting EMACS_INT to int.
4218 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4219 need to be updated by these changes.
4220 * fns.c (make_hash_table, maybe_resize_hash_table):
4221 Check for integer overflow with large hash tables.
4222 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4223 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4224 (SXHASH_REDUCE): New macro.
4225 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4226 Use it instead of discarding useful hash info with large hash values.
4227 (sxhash_float): New function.
4228 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4229 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4230 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4231 Rewrite to use FIXNUM_BITS, as this simplifies things.
4232 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4233 Adjust signatures to match updated version of code.
4234 (consing_since_gc): Now EMACS_INT, since a single hash table can
4235 use more than INT_MAX bytes.
4236
4237 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4238
4239 Make it possible to build with GCC-4.6+ -O2 -flto.
4240
4241 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4242
4243 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4244
4245 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4246 Call minibuffer-inactive-mode.
4247
4248 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4249
4250 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4251 Update dependencies.
4252
4253 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4254
4255 * data.c (init_data): Remove code for UTS, this system is not
4256 supported anymore.
4257
4258 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4259
4260 Don't force ./temacs to start in terminal mode.
4261
4262 * frame.c (make_initial_frame): Initialize faces in all cases, not
4263 only when CANNOT_DUMP is defined.
4264 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4265
4266 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4267
4268 * dispnew.c (add_window_display_history): Use const for the string
4269 pointer. Remove declaration, not needed.
4270
4271 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4272
4273 Use 'inline', not 'INLINE'.
4274 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4275 * alloc.c, fontset.c (INLINE): Remove.
4276 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4277 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4278 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4279 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4280 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4281
4282 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4283
4284 Make it possible to run ./temacs.
4285
4286 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4287 syms_of_callproc does the same thing. Remove test for
4288 "initialized", do it in the caller.
4289 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4290
4291 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4292
4293 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4294 (read_minibuf): Use get_minibuffer.
4295 (syms_of_minibuf): Use DEFSYM.
4296 (Qmetadata): New var.
4297 * data.c (Qbuffer): Don't make it static.
4298 (syms_of_data): Use DEFSYM.
4299
4300 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4301
4302 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4303 (CCL_CODE_MIN): New macro.
4304
4305 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4308
4309 * eval.c (Qdebug): Now static.
4310 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4311 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4312 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4313
4314 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4315
4316 * image.c: Various fixes to ImageMagick code comments.
4317 (Fimagemagick_types): Doc fix.
4318
4319 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4320
4321 Minor fixes prompted by GCC 4.6.0 warnings.
4322
4323 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4324
4325 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4326 (x_clipboard_manager_save_all): Move extern decl to ...
4327 * xterm.h: ... here, so that it can be checked for consistency.
4328
4329 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4330
4331 * xselect.c (x_clipboard_manager_save_frame)
4332 (x_clipboard_manager_save_all): New functions.
4333 (Fx_clipboard_manager_save): Lisp function deleted.
4334
4335 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4336 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4337
4338 * xterm.h: Update prototype.
4339
4340 2011-05-28 William Xu <william.xwl@gmail.com>
4341
4342 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4343 exiting (Bug#8239).
4344
4345 2011-05-28 Jim Meyering <meyering@redhat.com>
4346
4347 Avoid a sign-extension bug in crypto_hash_function.
4348 * fns.c (to_uchar): Define.
4349 (crypto_hash_function): Use it to convert some newly-signed
4350 variables to unsigned, to avoid sign-extension bugs. For example,
4351 without this change, (md5 "truc") would evaluate to
4352 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4353 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4354 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4355
4356 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4357
4358 Integer overflow fixes.
4359
4360 * dbusbind.c: Serial number integer overflow fixes.
4361 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4362 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4363 to hold a serial number that is too large for a fixnum.
4364 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4365 Check for serial numbers out of range. Decode any serial number
4366 that was so large that it became a float. (Bug#8722)
4367
4368 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4369 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4370 Use XFASTINT rather than XUINT when numbers are nonnegative.
4371 (xd_append_arg, Fdbus_method_return_internal):
4372 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4373 arguments, check that Lisp number is nonnegative, rather than
4374 silently wrapping negative numbers around. (Bug#8722)
4375 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4376 (Bug#8722)
4377
4378 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4379
4380 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4381
4382 ccl: add integer overflow checks
4383 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4384 (IN_INT_RANGE): New macros.
4385 (ccl_driver): Use them to check for integer overflow when
4386 decoding a CCL program. Many of the new checks are whether XINT (x)
4387 fits in int; it doesn't always, on 64-bit hosts. The new version
4388 doesn't catch all possible integer overflows, but it's an
4389 improvement. (Bug#8719)
4390
4391 * alloc.c (make_event_array): Use XINT, not XUINT.
4392 There's no need for unsigned here.
4393
4394 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4395 This follows up to the 2011-05-06 change that substituted uintptr_t
4396 for EMACS_INT. This case wasn't caught back then.
4397
4398 Rework Fformat to avoid integer overflow issues.
4399 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4400 now (part of C89). Include <verify.h>.
4401 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4402 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4403 (Fformat): Avoid the prepass trying to compute sizes; it was only
4404 approximate and thus did not catch overflow reliably. Instead, walk
4405 through the format just once, formatting and computing sizes as we go,
4406 checking for integer overflow at every step, and allocating a larger
4407 buffer as needed. Keep track separately whether the format is
4408 multibyte. Keep only the most-recently calculated precision, rather
4409 than them all. Record whether each argument has been converted to
4410 string. Use EMACS_INT, not int, for byte and char and arg counts.
4411 Support field widths and precisions larger than INT_MAX. Avoid
4412 sprintf's undefined behavior with conversion specifications such as %#d
4413 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4414 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4415 formatting out-of-range floating point numbers with int
4416 formats. (Bug#8668)
4417
4418 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4419
4420 * data.c: Avoid integer truncation in expressions involving floats.
4421 * data.c: Include <intprops.h>.
4422 (arith_driver): When there's an integer overflow in an expression
4423 involving floating point, convert the integers to floating point
4424 so that the resulting value does not suffer from catastrophic
4425 integer truncation. For example, on a 64-bit host (* 4
4426 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4427 Do not rely on undefined behavior after integer overflow.
4428
4429 merge count_size_as_multibyte, parse_str_to_multibyte
4430 * character.c, character.h (count_size_as_multibyte):
4431 Rename from parse_str_to_multibyte; all uses changed.
4432 Check for integer overflow.
4433 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4434 since it's now a duplicate of the other. This is more of
4435 a character than a buffer op, so better that it's in character.c.
4436 * fns.c, print.c: Adjust to above changes.
4437
4438 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4439
4440 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4441
4442 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4443
4444 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4445 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4446 (x_clipboard_manager_save): Now static.
4447 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4448
4449 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4450 (crypto_hash_function): Now static.
4451 Fix pointer signedness problems. Avoid unnecessary initializations.
4452
4453 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4454
4455 * termhooks.h (Vselection_alist): Make it terminal-local.
4456
4457 * terminal.c (create_terminal): Initialize it.
4458
4459 * xselect.c: Support for clipboard managers.
4460 (Vselection_alist): Move to termhooks.h as terminal-local var.
4461 (LOCAL_SELECTION): New macro.
4462 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4463 (symbol_to_x_atom): Remove gratuitous arg.
4464 (x_handle_selection_request, lisp_data_to_selection_data)
4465 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4466 (x_own_selection, x_get_local_selection, x_convert_selection):
4467 New arg, specifying work frame. Use terminal-local Vselection_alist.
4468 (some_frame_on_display): Delete unused function.
4469 (Fx_own_selection_internal, Fx_get_selection_internal)
4470 (Fx_disown_selection_internal, Fx_selection_owner_p)
4471 (Fx_selection_exists_p): New optional frame arg.
4472 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4473 (x_handle_selection_clear): Don't treat other terminals with the
4474 same keyboard specially. Use the terminal-local Vselection_alist.
4475 (x_clear_frame_selections): Use Frun_hook_with_args.
4476
4477 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4478
4479 * xterm.h: Add support for those atoms.
4480
4481 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4482
4483 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4484 (converted_selections, conversion_fail_tag): New global variables.
4485 (x_selection_request_lisp_error): Free the above.
4486 (x_get_local_selection): Remove unnecessary code.
4487 (x_reply_selection_request): Args changed; handle arbitrary array
4488 of converted selections stored in converted_selections.
4489 Separate the XChangeProperty and SelectionNotify steps.
4490 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4491 (x_convert_selection): New function.
4492 (x_handle_selection_event): Simplify.
4493 (x_get_foreign_selection): Don't ignore incoming requests while
4494 waiting for an answer; this will fail when we implement
4495 SAVE_TARGETS, and seems unnecessary anyway.
4496 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4497 (Vx_sent_selection_functions): Doc fix.
4498
4499 2011-05-26 Leo Liu <sdl.web@gmail.com>
4500
4501 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4502
4503 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4504
4505 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4506
4507 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4508 for fringe update if it has periodic bitmap.
4509 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4510 and fringe_bitmap_periodic_p.
4511
4512 * fringe.c (get_fringe_bitmap_data): New function.
4513 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4514 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4515 row. Mark glyph row for fringe update if periodicity changed.
4516
4517 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4518 for fringe update unless it has periodic bitmap.
4519
4520 2011-05-25 Kenichi Handa <handa@m17n.org>
4521
4522 * xdisp.c (get_next_display_element): Set correct it->face_id for
4523 a static composition.
4524
4525 2011-05-24 Leo Liu <sdl.web@gmail.com>
4526
4527 * deps.mk (fns.o):
4528 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4529
4530 * fns.c (crypto_hash_function, Fsha1): New function.
4531 (Fmd5): Use crypto_hash_function.
4532 (syms_of_fns): Add Ssha1.
4533
4534 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4535
4536 * gnutls.c: Remove unused macros.
4537 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4538 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4539 Remove macros that are defined and never used.
4540 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4541
4542 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4543
4544 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4545 (Fx_get_selection_internal): Minor cleanup.
4546 (Fx_own_selection_internal): Rename arguments for consistency with
4547 select.el.
4548
4549 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4550
4551 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4552
4553 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4554
4555 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4556
4557 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4558
4559 * dispnew.c (scrolling_window): Don't exclude the case that the
4560 last enabled row in the desired matrix touches the bottom boundary.
4561
4562 2011-05-21 Glenn Morris <rgm@gnu.org>
4563
4564 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4565 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4566 and add some more files.
4567
4568 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4569
4570 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4571 report_file_error introduced by the change from 2011-05-07.
4572
4573 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4574
4575 * systime.h (Time): Define only if emacs is defined.
4576 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4577 where the include path doesn't have X11/X.h by default. See
4578 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4579
4580 2011-05-20 Kenichi Handa <handa@m17n.org>
4581
4582 * composite.c (find_automatic_composition): Fix previous change.
4583
4584 2011-05-20 Glenn Morris <rgm@gnu.org>
4585
4586 * lisp.mk: New file, split from Makefile.in.
4587 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4588 (shortlisp): Remove.
4589 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4590
4591 2011-05-19 Glenn Morris <rgm@gnu.org>
4592
4593 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4594 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4595 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4596 (lisp): Set the order to that of loadup.el.
4597 (shortlisp): Make it a copy of $lisp.
4598 (SOME_MACHINE_LISP): Remove.
4599 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4600 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4601
4602 2011-05-18 Kenichi Handa <handa@m17n.org>
4603
4604 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4605 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4606 (find_automatic_composition): Mostly rewrite for efficiency.
4607
4608 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4609
4610 * makefile.w32-in: Update dependencies.
4611
4612 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4613
4614 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4615 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4616
4617 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4618
4619 Fix some integer overflow issues, such as string length overflow.
4620
4621 * insdel.c (count_size_as_multibyte): Check for string overflow.
4622
4623 * character.c (lisp_string_width): Check for string overflow.
4624 Use EMACS_INT, not int, for string indexes and lengths; in
4625 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4626 the resulting string length overflows an EMACS_INT; instead,
4627 report a string overflow if no precision given. When checking for
4628 precision exhaustion, use a check that cannot possibly have
4629 integer overflow. (Bug#8675)
4630 * character.h (lisp_string_width): Adjust to new signature.
4631
4632 * alloc.c (string_overflow): New function.
4633 (Fmake_string): Use it. This doesn't change behavior, but saves
4634 a few bytes and will simplify future changes.
4635 * character.c (string_escape_byte8): Likewise.
4636 * lisp.h (string_overflow): New decl.
4637
4638 Fixups, following up to the user-interface timestamp change.
4639 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4640 for UI timestamps, instead of unsigned long.
4641 * msdos.c (mouse_get_pos): Likewise.
4642 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4643 * w32gui.h (Time): Define by including "systime.h" rather than by
4644 declaring it ourselves. (Bug#8664)
4645
4646 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4647 * image.c (clear_image_cache): Likewise.
4648
4649 * term.c (term_mouse_position): Don't assume time_t wraparound.
4650
4651 Be more systematic about user-interface timestamps.
4652 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4653 and sometimes 'EMACS_UINT', to represent these timestamps.
4654 This change causes it to use 'Time' uniformly, as that's what X uses.
4655 This makes the code easier to follow, and makes it easier to catch
4656 integer overflow bugs such as Bug#8664.
4657 * frame.c (Fmouse_position, Fmouse_pixel_position):
4658 Use Time, not unsigned long, for user-interface timestamps.
4659 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4660 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4661 * keyboard.h (last_event_timestamp): Likewise.
4662 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4663 * menu.h (xmenu_show): Likewise.
4664 * term.c (term_mouse_position): Likewise.
4665 * termhooks.h (struct input_event.timestamp): Likewise.
4666 (struct terminal.mouse_position_hook): Likewise.
4667 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4668 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4669 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4670 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4671 what it was before.
4672 * menu.h, termhooks.h: Include "systime.h", for Time.
4673
4674 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4675 Don't assume that the difference between two unsigned long values
4676 can fit into an integer. At this point, we know button_down_time
4677 <= event->timestamp, so the difference must be nonnegative, so
4678 there's no need to cast the result if double-click-time is
4679 nonnegative, as it should be; check that it's nonnegative, just in
4680 case. This bug is triggered when events are more than 2**31 ms
4681 apart (about 25 days). (Bug#8664)
4682
4683 * xselect.c (last_event_timestamp): Remove duplicate decl.
4684 (x_own_selection): Remove needless cast to unsigned long.
4685
4686 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4687 that always fit in int. Use a sentinel instead of a counter, to
4688 avoid a temp and to allay GCC's concerns about possible int overflow.
4689 * frame.h (struct frame): Use int for menu_bar_items_used
4690 instead of EMACS_INT, since it always fits in int.
4691
4692 * menu.c (grow_menu_items): Check for int overflow.
4693
4694 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4695
4696 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4697 Before, the code was not consistent. These values cannot exceed
4698 2**31 - 1 so there's no need to make them unsigned.
4699 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4700 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4701 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4702 as modifiers.
4703 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4704
4705 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4706 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4707 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4708 presumably because the widths might not match.
4709
4710 * window.c (size_window): Avoid needless test at loop start.
4711
4712 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4713
4714 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4715
4716 2011-05-12 Drew Adams <drew.adams@oracle.com>
4717
4718 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4719
4720 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4721
4722 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4723 `width' to `bar_area_x' and `bar_area_width', respectively.
4724 (x_scroll_run): Take account of fringe background extension.
4725
4726 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4727 Rename local vars `left' and `width' to `bar_area_x' and
4728 `bar_area_width', respectively.
4729 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4730 background extension.
4731
4732 2011-05-10 Jim Meyering <meyering@redhat.com>
4733
4734 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4735
4736 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4737
4738 * image.c (Finit_image_library): Return t for built-in image types,
4739 like pbm and xbm. (Bug#8640)
4740
4741 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4742
4743 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4744
4745 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4746
4747 * w32console.c (Fset_screen_color): Doc fix.
4748 (Fget_screen_color): New function.
4749 (syms_of_ntterm): Defsubr it.
4750
4751 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4752 unlink the temporary file if Fcall_process didn't create it in the
4753 first place.
4754 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4755 child process will be redirected to a file specified with `:file'.
4756 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4757 cue to call_process_cleanup not to close that handle.
4758
4759 2011-05-07 Ben Key <bkey76@gmail.com>
4760
4761 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4762 one of two shell specific rules, either bootstrap-temacs-CMD or
4763 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4764 to the previous implementation of the bootstrap-temacs rule.
4765 The bootstrap-temacs-CMD rule is similar to the previous
4766 implementation of the bootstrap-temacs rule except that it
4767 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4768 variable.
4769
4770 These changes, along with some changes to nt/configure.bat,
4771 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4772 earlier fix to add support for --cflags and --ldflags options
4773 that include quotes so that it works whether make uses cmd or
4774 sh as the shell.
4775
4776 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4777
4778 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4779 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4780 is a constant.
4781 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4782 a string. Handle both cases.
4783 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4784 (Fdbus_register_method): Use Qinvalid_function.
4785
4786 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4787
4788 * makefile.w32-in: Update dependencies.
4789 (LISP_H): Add inttypes.h and stdin.h.
4790 (PROCESS_H): Add unistd.h.
4791
4792 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4793
4794 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4795 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4796
4797 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4800
4801 * term.c (vfatal): Remove stray call to va_end.
4802 It's not needed and the C Standard doesn't allow it here anyway.
4803
4804 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4805 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4806
4807 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4808 bytes.
4809
4810 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4811
4812 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4813
4814 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4815
4816 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4817
4818 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4819
4820 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4821 * charset.c (Fdefine_charset_internal): Don't initialize
4822 charset.code_space[15]. The value was garbage, on hosts with
4823 32-bit int (Bug#8600).
4824
4825 * lread.c (read_integer): Be more consistent with string-to-number.
4826 Use string_to_number to do the actual conversion; this avoids
4827 rounding errors and fixes some other screwups. Without this fix,
4828 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4829 (digit_to_number): Move earlier, for benefit of read_integer.
4830 Return -1 if the digit is out of range for the base, -2 if it is
4831 not a digit in any supported base. (Bug#8602)
4832
4833 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4834
4835 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4836 to match comment at start of function. This also removes a
4837 GCC warning about overflow in a 32+64-bit port.
4838
4839 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4840
4841 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4842 Reported by Stefan Monnier in
4843 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4844 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4845 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4846
4847 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4848 (EMACS_UINTPTR): Likewise, with uintptr_t.
4849
4850 * lisp.h: Prefer 64-bit EMACS_INT if available.
4851 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4852 on 32-bit hosts that have 64-bit int, so that they can access
4853 large files.
4854 However, temporarily disable this change unless the temporary
4855 symbol WIDE_EMACS_INT is defined.
4856
4857 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4858
4859 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4860 This removes an assumption that EMACS_INT and long are the same
4861 width as pointers. The assumption is true for Emacs porting targets
4862 now, but we want to make other targets possible.
4863 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4864 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4865 In the rest of the code, change types of integers that hold casted
4866 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4867 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4868 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4869 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4870 No need to cast type when ORing.
4871 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4872 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4873 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4874 assume EMACS_INT is the same width as char *.
4875 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4876 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4877 Remove no-longer-needed casts.
4878 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4879 (xg_tool_bar_help_callback, xg_make_tool_item):
4880 Use EMACS_INTPTR to hold an integer
4881 that will be cast to void *; this can avoid a GCC warning
4882 if EMACS_INT is not the same width as void *.
4883 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4884 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4885 (current_message_1, set_message_1):
4886 Use a local to convert to proper width without a cast.
4887 * xmenu.c (dialog_selection_callback): Likewise.
4888
4889 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4890 Also, don't assume VALBITS / RAND_BITS is less than 5,
4891 and don't rely on undefined behavior when shifting a 1 left into
4892 the sign bit.
4893 * lisp.h (get_random): Change signature to match.
4894
4895 * lread.c (hash_string): Use size_t, not int, for hash computation.
4896 Normally we prefer signed values; but hashing is special, because
4897 it's better to use unsigned division on hash table sizes so that
4898 the remainder is nonnegative. Also, size_t is the natural width
4899 for hashing into memory. The previous code used 'int', which doesn't
4900 retain enough info to hash well into very large tables.
4901 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4902
4903 * dbusbind.c: Don't possibly lose pointer info when converting.
4904 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4905 Use XPNTR rather than XHASH, so that the high-order bits of
4906 the pointer aren't lost when converting through void *.
4907
4908 * eval.c (Fautoload): Don't double-shift a pointer.
4909
4910 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4911
4912 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4913
4914 * gnutls.c (DEF_GNUTLS_FN):
4915 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4916
4917 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4918
4919 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4920 marker. (Bug#8610)
4921
4922 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4923
4924 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4925 New version that can reserve upto 2GB of heap space.
4926
4927 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4928
4929 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4930
4931 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4932
4933 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4934 `gnutls_certificate_set_x509_key_file'.
4935
4936 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4937
4938 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4939 Update dependencies.
4940
4941 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4942
4943 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4944 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4945 Remove unused parameter `fildes'.
4946 * process.c (read_process_output, send_process): Don't pass it.
4947
4948 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4949
4950 Fix previous change: the library cache is defined in w32.c.
4951 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4952 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4953
4954 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4955
4956 Implement dynamic loading of GnuTLS on Windows.
4957
4958 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4959 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4960 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4961 Declare.
4962
4963 * gnutls.c (Qgnutls_dll): Define.
4964 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4965 (gnutls_*): Declare function pointers.
4966 (init_gnutls_functions): New function to initialize function pointers.
4967 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4968 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4969 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4970 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4971 (emacs_gnutls_write, emacs_gnutls_read)
4972 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4973 (Fgnutls_available_p): New function.
4974 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4975 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4976 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4977
4978 * image.c: Include w32.h.
4979 (Vimage_type_cache): Delete.
4980 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4981 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4982 (w32_delayed_load): Move to w32.c.
4983
4984 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4985
4986 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4987 (w32_delayed_load): Move from image.c. When loading a library, record
4988 its filename in the :loaded-from property of the library id.
4989 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4990 Initialize and staticpro them.
4991 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4992
4993 * process.c: Include lisp.h before w32.h, not after.
4994 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4995 instead of gnutls_record_check_pending.
4996
4997 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4998
4999 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5000
5001 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5002 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5003 as passed in.
5004
5005 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5006
5007 * xterm.c (x_set_frame_alpha): Do not set property on anything
5008 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5009
5010 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5011
5012 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5013
5014 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5015
5016 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5017 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5018 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5019 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5020 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5021 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5022 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5023 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5024 (Qgnutls_bootprop_callbacks_verify): Make static.
5025
5026 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5027
5028 * callproc.c: Indentation fixup.
5029
5030 * sysdep.c (wait_for_termination_1): Make static.
5031 (wait_for_termination, interruptible_wait_for_termination):
5032 Move after wait_for_termination_1.
5033
5034 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5035
5036 * sysdep.c (interruptible_wait_for_termination): New function
5037 which is like wait_for_termination, but allows keyboard
5038 interruptions.
5039
5040 * callproc.c (Fcall_process): Add (:file "file") as an option for
5041 the STDOUT buffer.
5042 (Fcall_process_region): Ditto.
5043
5044 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5045
5046 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5047 rather than `XVECTOR (FOO)->size'.
5048
5049 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5050 inttypes.h, as a gnulib replacement is used if it not available in
5051 system headers.
5052
5053 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5054
5055 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5056 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5057 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5058
5059 * coding.c (coding_alloc_by_realloc): Error out if destination
5060 will grow beyond MOST_POSITIVE_FIXNUM.
5061 (decode_coding_emacs_mule): Abort if there isn't enough place in
5062 charbuf for the composition carryover bytes. Reserve an extra
5063 space for up to 2 characters produced in a loop.
5064 (decode_coding_iso_2022): Abort if there isn't enough place in
5065 charbuf for the composition carryover bytes.
5066
5067 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5068
5069 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5070 aborting when %lld or %lll format is passed.
5071 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5072 %llo or %llx format is passed. (Bug#8545)
5073
5074 * window.c (window_scroll_line_based): Use a marker instead of
5075 simple variables to record original value of point. (Bug#7952)
5076
5077 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5078 produced by %s or %c overflows available buffer space. (Bug#8545)
5079
5080 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5081
5082 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5083 (SIZE_MAX): Move defn after all includes, as they might #define it.
5084
5085 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5086
5087 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5088
5089 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5090
5091 * keyboard.c (Qdelayed_warnings_hook): Define.
5092 (command_loop_1): Run `delayed-warnings-hook'
5093 if Vdelayed_warnings_list is non-nil.
5094 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5095 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5096
5097 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5098
5099 * doprnt.c (doprnt): Don't return value smaller than the buffer
5100 size if the message was truncated. (Bug#8545).
5101
5102 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5103
5104 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5105 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5106
5107 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5108
5109 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5110
5111 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5112
5113 * makefile.w32-in: Update dependencies.
5114
5115 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5116
5117 Improve `doprnt' and its usage. (Bug#8545)
5118 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5119 `format_end'. Remove support for %l as a conversion specifier.
5120 Don't use xrealloc. Improve diagnostics when the %l size modifier
5121 is used. Update the commentary.
5122
5123 * eval.c (verror): Simplify calculation of size_t.
5124
5125 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5126 messages.
5127
5128 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5129
5130 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5131 change.
5132
5133 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5134
5135 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5136 This makes this file independent of the recent pseudovector change.
5137
5138 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5139
5140 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5141
5142 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5143 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5144 Remove unused local.
5145 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5146
5147 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5148 GCC 4.6.0 optimizes based on type-based alias analysis.
5149 For example, if b is of type struct buffer * and v of type struct
5150 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5151 != &v->size, and therefore "v->size = 1; b->size = 2; return
5152 v->size;" must therefore return 1. This assumption is incorrect
5153 for Emacs, since it type-puns struct Lisp_Vector * with many other
5154 types. To fix this problem, this patch adds a new type struct
5155 vectorlike_header that documents the constraints on layout of vectors
5156 and pseudovectors, and helps optimizing compilers not get fooled
5157 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5158 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5159 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5160 the size member.
5161 (XSETPVECTYPE): Rewrite in terms of new macro.
5162 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5163 This is a bit clearer, and further avoids the possibility of
5164 undesirable aliasing.
5165 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5166 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5167 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5168 since Lisp_Subr is a special case (no "next" field).
5169 (ASIZE): Now uses header.size rather than size.
5170 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5171 to avoid the hassle of writing XVECTOR (foo)->header.size.
5172 (struct vectorlike_header): New type.
5173 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5174 object, to help avoid aliasing.
5175 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5176 (SUBRP): Likewise, since Lisp_Subr is a special case.
5177 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5178 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5179 (struct Lisp_Hash_Table): Combine first two members into a single
5180 struct vectorlike_header member. All uses of "size" and "next" members
5181 changed to be "header.size" and "header.next".
5182 * buffer.h (struct buffer): Likewise.
5183 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5184 * frame.h (struct frame): Likewise.
5185 * process.h (struct Lisp_Process): Likewise.
5186 * termhooks.h (struct terminal): Likewise.
5187 * window.c (struct save_window_data, struct saved_window): Likewise.
5188 * window.h (struct window): Likewise.
5189 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5190 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5191 * buffer.c (init_buffer_once): Likewise.
5192 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5193 special case.
5194 * process.c (Fformat_network_address): Use local var for size,
5195 for brevity.
5196
5197 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5198
5199 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5200 * data.c (atof): Remove decl; no longer used or needed.
5201 (digit_to_number): Move to lread.c.
5202 (Fstring_to_number): Use new string_to_number function, to be
5203 consistent with how the Lisp reader treats infinities and NaNs.
5204 Do not assume that floating-point numbers represent EMACS_INT
5205 without losing information; this is not true on most 64-bit hosts.
5206 Avoid double-rounding errors, by insisting on integers when
5207 parsing non-base-10 numbers, as the documentation specifies.
5208 * lisp.h (string_to_number): New decl, replacing ...
5209 (isfloat_string): Remove.
5210 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5211 (read1): Do not accept +. and -. as integers; this
5212 appears to have been a coding error. Similarly, do not accept
5213 strings like +-1e0 as floating point numbers. Do not report
5214 overflow for integer overflows unless the base is not 10 which
5215 means we have no simple and reliable way to continue.
5216 Break out the floating-point parsing into a new
5217 function string_to_number, so that Fstring_to_number parses
5218 floating point numbers consistently with the Lisp reader.
5219 (digit_to_number): Move here from data.c. Make it static inline.
5220 (E_CHAR, EXP_INT): Remove, replacing with ...
5221 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5222 (string_to_number): New function, replacing isfloat_string.
5223 This function checks for valid syntax and produces the resulting
5224 Lisp float number too. Rework it so that string-to-number
5225 no longer mishandles examples like "1.0e+". Use strtoumax,
5226 so that overflow for non-base-10 numbers is reported only when
5227 there's no portable and simple way to convert to floating point.
5228
5229 * textprop.c (set_text_properties_1): Rewrite for clarity,
5230 and to avoid GCC warning about integer overflow.
5231
5232 * intervals.h (struct interval): Use EMACS_INT for members
5233 where EMACS_UINT might cause problems. See
5234 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5235 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5236 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5237 All uses changed.
5238 (offset_intervals): Tell GCC not to worry about length overflow
5239 when negating a negative length.
5240
5241 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5242 (overrun_check_free): Likewise.
5243
5244 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5245 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5246 word size.
5247
5248 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5249 (gnutls_make_error): Rename local to avoid shadowing.
5250 (gnutls_emacs_global_deinit): ifdef out; not used.
5251 (Fgnutls_boot): Use const for pointer to readonly storage.
5252 Comment out unused local. Fix pointer signedness problems.
5253
5254 * lread.c (openp): Don't stuff size_t into an 'int'.
5255 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5256 about possible signed overflow.
5257
5258 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5259 (GDK_KEY_g): Don't define if already defined.
5260 (xg_prepare_tooltip): Avoid pointer signedness problem.
5261 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5262
5263 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5264 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5265
5266 * xfns.c (Fx_window_property): Simplify a bit,
5267 to make a bit faster and to avoid GCC 4.6.0 warning.
5268 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5269
5270 * fns.c (internal_equal): Don't assume size_t fits in int.
5271
5272 * alloc.c (compact_small_strings): Tighten assertion a little.
5273
5274 Replace pEd with more-general pI, and fix some printf arg casts.
5275 * lisp.h (pI): New macro, generalizing old pEd macro to other
5276 conversion specifiers. For example, use "...%"pI"d..." rather
5277 than "...%"pEd"...".
5278 (pEd): Remove. All uses replaced with similar uses of pI.
5279 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5280 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5281 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5282 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5283 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5284 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5285 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5286 64-bit hosts.
5287 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5288 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5289 * print.c (safe_debug_print, print_object): Likewise.
5290 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5291 to int.
5292 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5293 avoiding the 0 flag, which is not portable.
5294 * process.c (Fmake_network_process): Use pI to avoid cast.
5295 * region-cache.c (pp_cache): Likewise.
5296 * xdisp.c (decode_mode_spec): Likewise.
5297 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5298 behavior on 64-bit hosts with printf arg.
5299 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5300 (x_stop_queuing_selection_requests): Likewise.
5301 (x_get_window_property): Don't truncate byte count to an 'int'
5302 when tracing.
5303
5304 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5305 here, since it parses constructs like leading '-' and spaces,
5306 which are not wanted; and it overflows with large numbers.
5307 Instead, simply match F[0-9]+, which is what is wanted anyway.
5308
5309 * alloc.c: Remove unportable assumptions about struct layout.
5310 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5311 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5312 (allocate_vectorlike, make_pure_vector): Use the new macros,
5313 plus offsetof, to remove unportable assumptions about struct layout.
5314 These assumptions hold on all porting targets that I know of, but
5315 they are not guaranteed, they're easy to remove, and removing them
5316 makes further changes easier.
5317
5318 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5319 This doesn't fix a bug but makes the code clearer.
5320 (string_overrun_cookie): Now const. Use initializers that
5321 don't formally overflow signed char, to avoid warnings.
5322 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5323 can cause Emacs to crash when string overrun checking is enabled.
5324 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5325 multiple of sizeof (EMACS_INT); it need not be, if
5326 alignof(EMACS_INT) < sizeof (EMACS_INT).
5327 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5328
5329 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5330
5331 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5332
5333 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5334
5335 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5336 supposed to be handshaking. (Bug#8556)
5337 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5338
5339 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5340
5341 * lisp.h (Qdebug): List symbol.
5342 * eval.c (Qdebug): Restore global linkage.
5343 * keyboard.c (debug-on-event): New variable.
5344 (handle_user_signal): Break into debugger when debug-on-event
5345 matches the current signal symbol.
5346
5347 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5348
5349 * alloc.c (check_sblock, check_string_bytes)
5350 (check_string_free_list): Convert to standard C.
5351
5352 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5353
5354 * w32.c (emacs_gnutls_push): Fix typo.
5355
5356 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5357
5358 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5359 "cast to pointer from integer of different size".
5360
5361 Improve doprnt and its use in verror. (Bug#8545)
5362 * doprnt.c (doprnt): Document the set of format control sequences
5363 supported by the function. Use SAFE_ALLOCA instead of always
5364 using `alloca'.
5365
5366 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5367 is one byte too soon. Don't use xrealloc; instead xfree and
5368 xmalloc anew.
5369
5370 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5371
5372 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5373 callbacks stage.
5374
5375 * gnutls.c: Renamed global_initialized to
5376 gnutls_global_initialized. Added internals for the
5377 :verify-hostname-error, :verify-error, and :verify-flags
5378 parameters of `gnutls-boot' and documented those parameters in the
5379 docstring. Start callback support.
5380 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5381 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5382 on error. Return error code.
5383 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5384 (emacs_gnutls_read): Likewise.
5385 (Fgnutls_boot): Return handshake error code.
5386 (emacs_gnutls_handle_error): New function.
5387 (wsaerror_to_errno): Likewise.
5388
5389 * w32.h (emacs_gnutls_pull): Add prototype.
5390 (emacs_gnutls_push): Likewise.
5391
5392 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5393 (emacs_gnutls_push): Likewise.
5394
5395 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5396
5397 * process.c (wait_reading_process_output): Check if GnuTLS
5398 buffered some data internally if no FDs are set for TLS
5399 connections.
5400
5401 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5402 (LIBS): Link to USER_LIBS.
5403 ($(BLD)/gnutls.$(0)): New target.
5404
5405 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5406
5407 * xdisp.c (handle_single_display_spec): Rename the
5408 display_replaced_before_p argument into display_replaced_p, to
5409 make it consistent with the commentary. Fix typos in the
5410 commentary.
5411
5412 * textprop.c (syms_of_textprop): Remove dead code.
5413 (copy_text_properties): Delete obsolete commentary about an
5414 interface that was deleted long ago. Fix typos in the description
5415 of arguments.
5416
5417 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5418 to changes in oldXMenu/XMenu.h from 2011-04-16.
5419 <menu_help_message, prev_menu_help_message>: Constify.
5420 (IT_menu_make_room): menu->help_text is now `const char **';
5421 adjust.
5422
5423 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5424 to changes in oldXMenu/XMenu.h from 2011-04-16.
5425 (struct XMenu): Declare `help_text' `const char **'.
5426
5427 * xfaces.c <Qunspecified>: Make extern again.
5428
5429 * syntax.c: Include sys/types.h before including regex.h, as
5430 required by Posix.
5431
5432 * doc.c (get_doc_string): Improve the format passed to `error'.
5433
5434 * doprnt.c (doprnt): Improve commentary.
5435
5436 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5437
5438 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5439 them with etags.
5440
5441 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5442 changes in globals.h immediately force recompilation.
5443 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5444 $(CURDIR)/s/ms-w32.h.
5445 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5446
5447 * character.c (Fchar_direction): Function deleted.
5448 (syms_of_character): Don't defsubr it.
5449 <char-direction-table>: Deleted.
5450
5451 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5452
5453 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5454 * doprnt.c: Include limits.h.
5455 (SIZE_MAX): New macro.
5456 (doprnt): Return a size_t value. 2nd arg is now size_t.
5457 Many local variables are now size_t instead of int or unsigned.
5458 Improve overflow protection. Support `l' modifier for integer
5459 conversions. Support %l conversion. Don't assume an EMACS_INT
5460 argument for integer conversions and for %c.
5461
5462 * lisp.h (doprnt): Restore prototype.
5463
5464 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5465 $(SRC)/character.h.
5466
5467 * Makefile.in (base_obj): Add back doprnt.o.
5468
5469 * deps.mk (doprnt.o): Add back prerequisites.
5470 (callint.o): Depend on character.h.
5471
5472 * eval.c (internal_lisp_condition_case): Include the handler
5473 representation in the error message.
5474 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5475 when breaking from the loop.
5476
5477 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5478
5479 * callint.c (Fcall_interactively): When displaying error message
5480 about invalid control letter, pass the character's codepoint, not
5481 a pointer to its multibyte form. Improve display of the character
5482 in octal and display also its hex code.
5483
5484 * character.c (char_string): Use %x to display the (unsigned)
5485 codepoint of an invalid character, to avoid displaying a bogus
5486 negative value.
5487
5488 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5489 `error', not SYMBOL_NAME itself.
5490
5491 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5492 character arguments to `error'.
5493
5494 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5495 to `error' in error message about FINAL_CHAR argument. Make sure
5496 FINAL_CHAR is a character, and use %c when it is passed as
5497 argument to `error'.
5498
5499 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5500
5501 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5502
5503 * w32.c: Include <time.h>.
5504 (sys_localtime): New function.
5505
5506 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5507
5508 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5509
5510 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5511
5512 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5513
5514 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5515 zombies (Bug#8467).
5516
5517 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5518
5519 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5520 gl_state.e_property when gl_state.object is Qt.
5521
5522 * insdel.c (make_gap_larger): Remove limitation of buffer size
5523 to <= INT_MAX.
5524
5525 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5526
5527 * xdisp.c (lookup_glyphless_char_display)
5528 (produce_glyphless_glyph): Handle cons cell entry in
5529 glyphless-char-display.
5530 (Vglyphless_char_display): Document it.
5531
5532 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5533 glyphless-char-display.
5534
5535 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5536
5537 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5538
5539 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5540
5541 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5542 definition for no-X builds.
5543
5544 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5545
5546 Static checks with GCC 4.6.0 and non-default toolkits.
5547
5548 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5549
5550 * process.c (keyboard_bit_set): Define only if SIGIO.
5551 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5552 (send_process): Repair possible setjmp clobbering.
5553
5554 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5555
5556 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5557
5558 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5559
5560 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5561 Define only if needed.
5562
5563 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5564 by pacifying GCC about it. Maybe it's time to retire it?
5565 * xfaces.c (USG, __TIMEVAL__): Likewise.
5566
5567 * dispextern.h (struct redisplay_interface): Rename param
5568 to avoid shadowing.
5569 * termhooks.h (struct terminal): Likewise.
5570 * xterm.c (xembed_send_message): Likewise.
5571
5572 * insdel.c (make_gap_smaller): Define only if
5573 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5574
5575 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5576 it.
5577
5578 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5579 so that we aren't warned about unused symbols.
5580
5581 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5582
5583 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5584
5585 * xfns.c (x_real_positions): Mark locals as initialized.
5586
5587 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5588
5589 * xterm.c: Fix problems found by static analysis with other toolkits.
5590 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5591 (x_dispatch_event): Declare static if USE_GTK, and
5592 define if USE_GTK || USE_X_TOOLKIT.
5593 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5594 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5595 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5596 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5597
5598 * xmenu.c (menu_help_callback): Pointer type fixes.
5599 Use const pointers when pointing at readonly data. Avoid pointer
5600 signedness clashes.
5601 (FALSE): Remove unused macro.
5602 (update_frame_menubar): Remove unused decl.
5603
5604 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5605
5606 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5607 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5608 (single_menu_item): Rename local to avoid shadowing.
5609
5610 * keyboard.c (make_lispy_event): Remove unused local var.
5611
5612 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5613 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5614
5615 * bitmaps: Change bitmaps from unsigned char back to the X11
5616 compatible char. Avoid the old compiler warnings about
5617 out-of-range initializers by using, for example, '\xab' rather
5618 than 0xab.
5619
5620 * xgselect.c (xgselect_initialize): Check vs interface
5621 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5622
5623 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5624
5625 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5626 to read-only memory.
5627
5628 * fns.c (vector): Remove; this old hack is no longer needed.
5629
5630 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5631 Remove unused var.
5632 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5633
5634 * xrdb.c (x_load_resources): Omit unused local.
5635
5636 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5637 (x_window): Rename locals to avoid shadowing.
5638 (USG): Use the kludged USG macro, to pacify gcc.
5639
5640 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5641 (x_term_init): Remove local to avoid shadowing.
5642
5643 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5644
5645 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5646 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5647
5648 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5649
5650 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5651
5652 Fix regex.c, syntax.c and friends for buffers > 2GB.
5653 * syntax.h (struct gl_state_s): Declare character position members
5654 EMACS_INT.
5655
5656 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5657
5658 * textprop.c (verify_interval_modification, interval_of):
5659 Declare arguments EMACS_INT.
5660
5661 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5662 EMACS_INT.
5663
5664 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5665
5666 * indent.c (Fvertical_motion): Local variable it_start is now
5667 EMACS_INT.
5668
5669 * regex.c (re_match, re_match_2, re_match_2_internal)
5670 (bcmp_translate, regcomp, regexec, print_double_string)
5671 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5672 (re_compile_pattern, re_exec): Declare arguments and local
5673 variables `size_t' and `ssize_t' and return values `regoff_t', as
5674 appropriate.
5675 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5676 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5677 <compile_stack_type>: `size' and `avail' are now `size_t'.
5678
5679 * regex.h <regoff_t>: Use ssize_t, not int.
5680 (re_search, re_search_2, re_match, re_match_2): Arguments that
5681 specify buffer/string position and length are now ssize_t and
5682 size_t. Return type is regoff_t.
5683
5684 2011-04-16 Ben Key <bkey76@gmail.com>
5685
5686 * nsfont.m: Fixed bugs in ns_get_family and
5687 ns_descriptor_to_entity that were caused by using free to
5688 deallocate memory blocks that were allocated by xmalloc (via
5689 xstrdup). This caused Emacs to crash when compiled with
5690 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5691 --enable-checking=xmallocoverrun). xfree is now used to
5692 deallocate these memory blocks.
5693
5694 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5695
5696 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5697
5698 emacs_write: Accept and return EMACS_INT for sizes.
5699 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5700 et seq.
5701 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5702 Accept and return EMACS_INT.
5703 (emacs_gnutls_write): Return the number of bytes written on
5704 partial writes.
5705 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5706 (emacs_read, emacs_write): Remove check for negative size, as the
5707 Emacs source code has been audited now.
5708 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5709 (emacs_read, emacs_write): Use it.
5710 * process.c (send_process): Adjust to the new signatures of
5711 emacs_write and emacs_gnutls_write. Do not attempt to store
5712 a byte offset into an 'int'; it might overflow.
5713 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5714
5715 * sound.c: Don't assume sizes fit in 'int'.
5716 (struct sound_device.period_size, alsa_period_size):
5717 Return EMACS_INT, not int.
5718 (struct sound_device.write, vox_write, alsa_write):
5719 Accept EMACS_INT, not int.
5720 (wav_play, au_play): Use EMACS_INT to store sizes and to
5721 record read return values.
5722
5723 2011-04-15 Ben Key <bkey76@gmail.com>
5724
5725 * keyboard.c (Qundefined): Don't declare static since it is used
5726 in nsfns.m.
5727 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5728 static since they are used in nsfont.m.
5729
5730 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5731
5732 * process.c (Qprocessp): Don't declare static.
5733 * lisp.h (Qprocessp): Declare again.
5734
5735 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5736
5737 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5738
5739 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5740
5741 Improve C-level modularity by making more things 'static'.
5742
5743 Don't publish debugger-only interfaces to other modules.
5744 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5745 (verify_bytepos, count_markers): Move decls to the only modules
5746 that need them.
5747 * region-cache.h (pp_cache): Likewise.
5748 * window.h (check_all_windows): Likewise.
5749 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5750
5751 * sysdep.c (croak): Now static, if
5752 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5753 * syssignal.h (croak): Declare only if not static.
5754
5755 * alloc.c (refill_memory_reserve): Now static if
5756 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5757 * lisp.h (refill_memory_reserve): Declare only if not static.
5758
5759 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5760 Define only if USE_LUCID.
5761
5762 * xrdb.c (x_customization_string, x_rm_string): Now static.
5763
5764 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5765 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5766
5767 * xdisp.c (draw_row_with_mouse_face): Now static.
5768 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5769
5770 * window.h (check_all_windows): Mark externally visible.
5771
5772 * window.c (window_deletion_count): Now static.
5773
5774 * undo.c: Make symbols static if they're not exported.
5775 (last_undo_buffer, last_boundary_position, pending_boundary):
5776 Now static.
5777
5778 * textprop.c (interval_insert_behind_hooks): Now static.
5779 (interval_insert_in_front_hooks): Likewise.
5780
5781 * term.c: Make symbols static if they're not exported.
5782 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5783 (max_frame_lines, tty_set_terminal_modes):
5784 (tty_reset_terminal_modes, tty_turn_off_highlight):
5785 (get_tty_terminal): Now static.
5786 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5787 * termhooks.h (term_mouse_moveto): Do not declare if
5788 HAVE_WINDOW_SYSTEM.
5789 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5790 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5791
5792 * sysdep.c: Make symbols static if they're not exported.
5793 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5794 Now static.
5795 (sigprocmask_set, full_mask): Remove; unused.
5796 (wait_debugging): Mark as visible.
5797 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5798 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5799
5800 * syntax.c (syntax_temp): Define only if !__GNUC__.
5801
5802 * sound.c (current_sound_device, current_sound): Now static.
5803
5804 * search.c (searchbufs, searchbuf_head): Now static.
5805
5806 * scroll.c (scroll_cost): Remove; unused.
5807 * dispextern.h (scroll_cost): Remove decl.
5808
5809 * region-cache.h (pp_cache): Mark as externally visible.
5810
5811 * process.c: Make symbols static if they're not exported.
5812 (process_tick, update_tick, create_process, chan_process):
5813 (Vprocess_alist, proc_buffered_char, datagram_access):
5814 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5815 (deactivate_process): Mark defn as static, as well as decl.
5816 * lisp.h (create_process): Remove decl.
5817 * process.h (chan_process, Vprocess_alist): Remove decls.
5818
5819 * print.c: Make symbols static if they're not exported.
5820 (print_depth, new_backquote_output, being_printed, print_buffer):
5821 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5822 (print_interval, print_number_index, initial_stderr_stream):
5823 Now static.
5824 * lisp.h (Fprinc): Remove decl.
5825 (debug_output_compilation_hack): Mark as externally visible.
5826
5827 * sysdep.c (croak): Move decl from here to syssignal.h.
5828 * syssignal.h (croak): Put it here, so the API can be checked when
5829 'croak' is called from dissociate_if_controlling_tty.
5830
5831 * minibuf.c: Make symbols static if they're not exported.
5832 (minibuf_save_list, choose_minibuf_frame): Now static.
5833 * lisp.h (choose_minibuf_frame): Remove decl.
5834
5835 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5836
5837 * lread.c: Make symbols static if they're not exported.
5838 (read_objects, initial_obarray, oblookup_last_bucket_number):
5839 Now static.
5840 (make_symbol): Remove; unused.
5841 * lisp.h (initial_obarray, make_symbol): Remove decls.
5842
5843 * keyboard.c: Make symbols static if they're not exported.
5844 (single_kboard, recent_keys_index, total_keys, recent_keys):
5845 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5846 (this_single_command_key_start, echoing, last_auto_save):
5847 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5848 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5849 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5850 (Vlispy_mouse_stem, double_click_count):
5851 Now static.
5852 (force_auto_save_soon): Define only if SIGDANGER.
5853 (ignore_mouse_drag_p): Now static if
5854 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5855 (print_help): Remove; unused.
5856 (stop_character, last_timer_event): Mark as externally visible.
5857 * keyboard.h (ignore_mouse_drag_p): Declare only if
5858 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5859 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5860 * lisp.h (echoing): Remove decl.
5861 (force_auto_save_soon): Declare only if SIGDANGER.
5862 * xdisp.c (redisplay_window): Simplify code, to make it more
5863 obvious that ignore_mouse_drag_p is not accessed if !defined
5864 USE_GTK && !defined HAVE_NS.
5865
5866 * intervals.c: Make symbols static if they're not exported.
5867 (merge_properties_sticky, merge_interval_right, delete_interval):
5868 Now static.
5869 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5870
5871 * insdel.c: Make symbols static if they're not exported.
5872 However, leave prepare_to_modify_buffer alone. It's never
5873 called from outside this function, but that appears to be a bug.
5874 (combine_after_change_list, combine_after_change_buffer):
5875 (adjust_after_replace, signal_before_change): Now static.
5876 (adjust_after_replace_noundo): Remove; unused.
5877 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5878 (signal_before_change): Remove decls.
5879
5880 * indent.c (val_compute_motion, val_vmotion): Now static.
5881
5882 * image.c: Make symbols static if they're not exported.
5883 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5884 if USE_GTK.
5885 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5886 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5887
5888 * fringe.c (standard_bitmaps): Now static.
5889 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5890
5891 * frame.c: Make symbols static if they're not exported.
5892 (x_report_frame_params, make_terminal_frame): Now static.
5893 (get_frame_param): Now static, unless HAVE_NS.
5894 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5895 (x_get_resource_string): Remove; not used.
5896 * frame.h (make_terminal_frame, x_report_frame_params):
5897 (x_get_resource_string); Remove decls.
5898 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5899 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5900
5901 * font.c, fontset.c: Make symbols static if they're not exported.
5902 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5903 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5904 * font.c (font_close_object): Now static.
5905 * font.h (font_close_object): Remove.
5906 * fontset.c (FONTSET_OBJLIST): Remove.
5907 (free_realized_fontset) #if-0 the body, which does nothing.
5908 (face_suitable_for_char_p): #if-0, as it's never called.
5909 * fontset.h (face_suitable_for_char_p): Remove decl.
5910 * xfaces.c (face_at_string_position):
5911 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5912 since 0 is always ASCII.
5913
5914 * fns.c (weak_hash_tables): Now static.
5915
5916 * fileio.c: Make symbols static if they're not exported.
5917 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5918 (Vwrite_region_annotation_buffers): Now static.
5919
5920 * eval.c: Make symbols static if they're not exported.
5921 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5922 * lisp.h (backtrace_list): Remove decl.
5923
5924 * emacs.c: Make symbols static if they're not exported.
5925 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5926 (fatal_error_code, fatal_error_signal_hook, standard_args):
5927 Now static.
5928 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5929 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5930 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5931 * lisp.h (fatal_error_signal_hook): Remove decl.
5932 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5933
5934 * editfns.c: Move a (normally-unused) function to its only use.
5935 * editfns.c, lisp.h (get_operating_system_release): Remove.
5936 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5937 worth the hassle of breaking this out.
5938
5939 * xterm.c: Make symbols static if they're not exported.
5940 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5941 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5942 (x_destroy_window, x_delete_display):
5943 Now static.
5944 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5945 (x_mouse_leave): Remove; unused.
5946 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5947 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5948 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5949 Remove decls.
5950 (x_mouse_leave): Declare only if WINDOWSNT.
5951 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5952 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5953 USE_X_TOOLKIT.
5954
5955 * ftxfont.c: Make symbols static if they're not exported.
5956 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5957 HAVE_FREETYPE.
5958 * font.h (ftxfont_driver): Likewise.
5959
5960 * xfns.c: Make symbols static if they're not exported.
5961 (x_last_font_name, x_display_info_for_name):
5962 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5963 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5964 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5965 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5966 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5967 (last_show_tip_args): Now static.
5968 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5969 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5970 (x_screen_planes): Remove; unused.
5971 * dispextern.h (x_screen_planes): Remove decl.
5972
5973 * dispnew.c: Make symbols static if they're not exported.
5974 * dispextern.h (redraw_garbaged_frames, scrolling):
5975 (increment_row_positions): Remove.
5976 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5977 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5978 Now static.
5979 (redraw_garbaged_frames): Remove; unused.
5980
5981 * xfaces.c: Make symbols static if they're not exported.
5982 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5983 Remove decls.
5984 * xterm.h (defined_color): Remove decls.
5985 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5986 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5987 (menu_face_changed_default, defined_color, free_realized_face):
5988 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5989 (ascii_face_of_lisp_face): Remove; unused.
5990
5991 * xdisp.c: Make symbols static if they're not exported.
5992 * dispextern.h (scratch_glyph_row, window_box_edges):
5993 (glyph_to_pixel_coords, set_cursor_from_row):
5994 (get_next_display_element, set_iterator_to_next):
5995 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5996 (show_mouse_face): Remove decls
5997 * frame.h (message_buf_print): Likewise.
5998 * lisp.h (pop_message, set_message, check_point_in_composition):
5999 Likewise.
6000 * xterm.h (set_vertical_scroll_bar): Likewise.
6001 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6002 (message_buf_print, scratch_glyph_row, displayed_buffer):
6003 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6004 (get_next_display_element, show_mouse_face, window_box_edges):
6005 (frame_to_window_pixel_xy, check_point_in_composition):
6006 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6007 (glyph_to_pixel_coords): Remove; unused.
6008
6009 * dired.c (file_name_completion): Now static.
6010
6011 * dbusbind.c (xd_in_read_queued_messages): Now static.
6012
6013 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6014 * data.c (circular_list_error): Remove.
6015
6016 * commands.h (last_point_position, last_point_position_buffer):
6017 (last_point_position_window): Remove decls.
6018 * keyboard.c: Make these variables static.
6019
6020 * coding.h (coding, code_convert_region, encode_coding_gap):
6021 Remove decls.
6022 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6023 (iso_code_class, detect_coding, code_convert_region): Now static.
6024 (encode_coding_gap): Remove; unused.
6025
6026 * chartab.c (chartab_chars, chartab_bits): Now static.
6027
6028 * charset.h (charset_iso_8859_1): Remove decl.
6029 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6030 Now static.
6031
6032 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6033 * ccl.c (Vccl_program_table): Now static.
6034 (check_ccl_update): Remove; unused.
6035
6036 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6037 * category.h: ... from here.
6038 * category.c (check_category_table, set_category_set): Now static.
6039
6040 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6041 * lisp.h: Remove these decls.
6042
6043 * buffer.c (buffer_count): Remove unused var.
6044
6045 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6046 so that it's not optimized away.
6047 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6048 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6049 exported only to the debugger.
6050
6051 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6052 * atimer.h (run_all_atimers): Remove; not exported.
6053
6054 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6055 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6056 was inaccessible from Lisp.
6057 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6058 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6059
6060 alloc.c: Import and export fewer symbols, and remove unused items.
6061 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6062 is defined.
6063 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6064 it's not optimized away by whole-program optimization.
6065 (message_enable_multibyte, free_misc): Remove.
6066 (catchlist, handlerlist, mark_backtrace):
6067 Declare only if BYTE_MARK_STACK.
6068 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6069 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6070 (message_enable_multibyte): Remove decl.
6071 (free_misc, interval_free_list, float_block, float_block_index):
6072 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6073 (cons_free_list, last_marked_index):
6074 Now static.
6075 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6076 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6077 (mark_backtrace): Define only if BYTE_MARK_STACK.
6078 * xdisp.c (message_enable_multibyte): Now static.
6079
6080 Declare Lisp_Object Q* variables to be 'static' if not exported.
6081 This makes it easier for human readers (and static analyzers)
6082 to see whether these variables are used from other modules.
6083 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6084 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6085 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6086 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6087 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6088 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6089 * xmenu.c, xselect.c:
6090 Declare Q* vars static if they are not used in other modules.
6091 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6092 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6093 Remove decls of unexported vars.
6094 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6095
6096 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6097
6098 Make Emacs functions such as Fatom 'static' by default.
6099 This makes it easier for human readers (and static analyzers)
6100 to see whether these functions can be called from other modules.
6101 DEFUN now defines a static function. To make the function external
6102 so that it can be used in other C modules, use the new macro DEFUE.
6103 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6104 (Finit_image_library):
6105 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6106 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6107 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6108 Remove decls, since these functions are now static.
6109 (Funintern, Fget_internal_run_time): New decls, since these functions
6110 were already external.
6111
6112 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6113 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6114 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6115 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6116 * keyboard.c, keymap.c, lread.c:
6117 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6118 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6119 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6120 Mark functions with DEFUE instead of DEFUN,
6121 if they are used in other modules.
6122 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6123 decls for now-static functions.
6124 * buffer.h (Fdelete_overlay): Remove decl.
6125 * callproc.c (Fgetenv_internal): Mark as internal.
6126 * composite.c (Fremove_list_of_text_properties): Remove decl.
6127 (Fcomposition_get_gstring): New forward static decl.
6128 * composite.h (Fcomposite_get_gstring): Remove decl.
6129 * dired.c (Ffile_attributes): New forward static decl.
6130 * doc.c (Fdocumntation_property): New forward static decl.
6131 * eval.c (Ffetch_bytecode): New forward static decl.
6132 (Funintern): Remove extern decl; now in .h file where it belongs.
6133 * fileio.c (Fmake_symbolic_link): New forward static decl.
6134 * image.c (Finit_image_library): New forward static decl.
6135 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6136 * intervals.h (Fprevious_property_change):
6137 (Fremove_list_of_text_properties): Remove decls.
6138 * keyboard.c (Fthis_command_keys): Remove decl.
6139 (Fcommand_execute): New forward static decl.
6140 * keymap.c (Flookup_key): New forward static decl.
6141 (Fcopy_keymap): Now static.
6142 * keymap.h (Flookup_key): Remove decl.
6143 * process.c (Fget_process): New forward static decl.
6144 (Fprocess_datagram_address): Mark as internal.
6145 * syntax.c (Fsyntax_table_p): New forward static decl.
6146 (skip_chars): Remove duplicate decl.
6147 * textprop.c (Fprevious_property_change): New forward static decl.
6148 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6149 Now internal.
6150 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6151 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6152
6153 * editfns.c (Fformat): Remove unreachable code.
6154
6155 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6156
6157 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6158 change. (Bug#8496)
6159
6160 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6161
6162 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6163 when at ZV. (Bug#8487)
6164
6165 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6166
6167 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6168 (Bug#8437)
6169 * keyboard.c (parse_tool_bar_item): Likewise.
6170 * sound.c (sound_cleanup, alsa_close): Likewise.
6171 * termcap.c (tgetent): Likewise.
6172 * xfns.c (x_default_font_parameter): Likewise.
6173 * xsettings.c (read_and_apply_settings): Likewise.
6174
6175 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6176 (overrun_check_free): Protoize.
6177
6178 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6179
6180 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6181 since callers should never pass a negative size.
6182 Change the signature to match that of plain 'read' and 'write'; see
6183 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6184 * lisp.h: Update prototypes of emacs_write and emacs_read.
6185
6186 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6187
6188 * xdisp.c (redisplay_window): Don't try to determine the character
6189 position of the scroll margin if the window start point w->startp
6190 is outside the buffer's accessible region. (Bug#8468)
6191
6192 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6193
6194 Fix write-region and its subroutines for buffers > 2GB.
6195 * fileio.c (a_write, e_write): Modify declaration of arguments and
6196 local variables to support buffers larger than 2GB.
6197 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6198
6199 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6200 argument, local variables, and return value.
6201
6202 * lisp.h: Update prototypes of emacs_write and emacs_read.
6203
6204 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6205
6206 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6207
6208 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6209
6210 Fix more problems found by GCC 4.6.0's static checks.
6211
6212 * xdisp.c (vmessage): Use a better test for character truncation.
6213
6214 * charset.c (load_charset_map): <, not <=, for optimization,
6215 and to avoid potential problems with integer overflow.
6216 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6217 * casetab.c (set_identity, shuffle): Likewise.
6218 * editfns.c (Fformat): Likewise.
6219 * syntax.c (skip_chars): Likewise.
6220
6221 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6222 This also lets GCC 4.6.0 generate slightly better loop code.
6223
6224 * callint.c (Fcall_interactively): <, not <=, for optimization.
6225 (Fcall_interactively): Count the number of arguments produced,
6226 not the number of arguments given. This is simpler and lets GCC
6227 4.6.0 generate slightly better code.
6228
6229 * ftfont.c: Distingish more carefully between FcChar8 and char.
6230 The previous code passed unsigned char * to a functions like
6231 strlen and xstrcasecmp that expect char *, which does not
6232 conform to the C standard.
6233 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6234 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6235 char * when the C standard requires it.
6236
6237 * keyboard.c (read_char): Remove unused var.
6238
6239 * eval.c: Port to Windows vsnprintf (Bug#8435).
6240 Include <limits.h>.
6241 (SIZE_MAX): Define if the headers do not.
6242 (verror): Do not give up if vsnprintf returns a negative count.
6243 Instead, grow the buffer. This ports to Windows vsnprintf, which
6244 does not conform to C99. Problem reported by Eli Zaretskii.
6245 Also, simplify the allocation scheme, by avoiding the need for
6246 calling realloc, and removing the ALLOCATED variable.
6247
6248 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6249
6250 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6251 But keep the doprint source code for now, as we might revamp it
6252 and use it again (Bug#8435).
6253 * lisp.h (doprnt): Remove.
6254 * Makefile.in (base_obj): Remove doprnt.o.
6255 * deps.mk (doprnt.o): Remove.
6256
6257 error: Print 32- and 64-bit integers portably (Bug#8435).
6258 Without this change, on typical 64-bit hosts error ("...%d...", N)
6259 was used to print both 32- and 64-bit integers N, which relied on
6260 undefined behavior.
6261 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6262 New macro.
6263 * lisp.h (error, verror): Mark as printf-like functions.
6264 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6265 Report overflow in size calculations when allocating printf buffer.
6266 Do not truncate output string at its first null byte.
6267 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6268 Truncate the output at a character boundary, since vsnprintf does not
6269 do that.
6270 * charset.c (check_iso_charset_parameter): Convert internal
6271 character to string before calling 'error', since %c now has the
6272 printf meaning.
6273 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6274 overflow when computing char to be passed to 'error'. Do not
6275 pass Lisp_Object to 'error'; pass the integer instead.
6276 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6277 formatted with plain %d.
6278
6279 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6280
6281 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6282
6283 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6284
6285 * xterm.c (x_catch_errors): Remove duplicate declaration.
6286
6287 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6288
6289 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6290
6291 2011-04-10 Jim Meyering <meyering@redhat.com>
6292
6293 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6294 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6295 return ssize_t not "int", and use size_t as the buffer length.
6296 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6297 * gnutls.h: Update declarations.
6298 * process.c (read_process_output): Use ssize_t, to match.
6299 (send_process): Likewise.
6300
6301 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6302
6303 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6304
6305 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6306
6307 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6308 Use unsigned char, to match FcChar8 type definition.
6309
6310 * xterm.c (handle_one_xevent):
6311 * xmenu.c (create_and_show_popup_menu):
6312 * xselect.c (x_decline_selection_request)
6313 (x_reply_selection_request): Avoid type-punned deref of X events.
6314
6315 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6316
6317 Fix some uses of `int' instead of EMACS_INT.
6318 * search.c (string_match_1, fast_string_match)
6319 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6320 (scan_buffer, find_next_newline_no_quit)
6321 (find_before_next_newline, search_command, Freplace_match)
6322 (Fmatch_data): Make some `int' variables be EMACS_INT.
6323
6324 * xdisp.c (display_count_lines): 3rd argument and return value now
6325 EMACS_INT. All callers changed.
6326 (pint2hrstr): Last argument is now EMACS_INT.
6327
6328 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6329 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6330 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6331 (decode_coding_utf_16, decode_coding_emacs_mule)
6332 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6333 (decode_coding_ccl, decode_coding_charset)
6334 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6335 (decode_coding_iso_2022, decode_coding_emacs_mule)
6336 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6337 <char_offset, last_offset>: Declare EMACS_INT.
6338 (encode_coding_utf_8, encode_coding_utf_16)
6339 (encode_coding_emacs_mule, encode_invocation_designation)
6340 (encode_designation_at_bol, encode_coding_iso_2022)
6341 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6342 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6343 Declare EMACS_INT.
6344 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6345 (encode_invocation_designation): Last argument P_NCHARS is now
6346 EMACS_INT.
6347 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6348 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6349
6350 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6351 All users changed.
6352
6353 * ccl.c (Fccl_execute_on_string): Declare some variables
6354 EMACS_INT.
6355
6356 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6357
6358 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6359
6360 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6361
6362 * process.c (Fformat_network_address): Doc fix.
6363
6364 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6365
6366 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6367
6368 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6369
6370 * keyboard.c (read_char): Call Lisp function help-form-show,
6371 instead of using internal_with_output_to_temp_buffer.
6372 (Qhelp_form_show): New var.
6373 (syms_of_keyboard): Use DEFSYM macro.
6374
6375 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6376
6377 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6378
6379 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6380
6381 * process.c (Flist_processes): Remove to Lisp.
6382 (list_processes_1): Delete.
6383
6384 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6385
6386 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6387
6388 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6389
6390 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6391
6392 Fix more problems found by GCC 4.6.0's static checks.
6393
6394 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6395
6396 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6397
6398 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6399
6400 * xdisp.c (vmessage): Mark as a printf-like function.
6401
6402 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6403
6404 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6405
6406 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6407 printf-like functions.
6408 (tiff_load): Add casts to remove these marks before passing them
6409 to system-supplied API.
6410
6411 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6412
6413 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6414 This avoids several warnings with gcc -Wstrict-overflow.
6415 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6416 directly, rather than having caller test rule sign. This avoids
6417 some unnecessary tests.
6418 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6419 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6420 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6421
6422 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6423 (xfont_open): Avoid unnecessary tests.
6424
6425 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6426
6427 * composite.h, composite.c (composition_gstring_put_cache):
6428 Use EMACS_INT, not int, for length.
6429
6430 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6431 breaking out part of COMPOSITION_DECODE_RULE.
6432 (COMPOSITION_DECODE_RULE): Use it.
6433 * composite.c (get_composition_id): Remove unused local vars,
6434 by using the new macro.
6435
6436 * textprop.c (set_text_properties_1): Change while to do-while,
6437 since the condition is always true at first.
6438
6439 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6440 (interval_deletion_adjustment): Return unsigned value.
6441 All uses changed.
6442
6443 * process.c (list_processes_1, create_pty, read_process_output):
6444 (exec_sentinel): Remove vars that were set but not used.
6445 (create_pty): Remove unnecessary "volatile"s.
6446 (Fnetwork_interface_info): Avoid possibility of int overflow.
6447 (read_process_output): Do adaptive read buffering even if carryover.
6448 (read_process_output): Simplify nbytes computation if buffered.
6449
6450 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6451
6452 * syntax.c (scan_words): Remove var that was set but not used.
6453 (update_syntax_table): Use unsigned instead of int.
6454
6455 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6456 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6457 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6458
6459 * print.c (print_error_message): Avoid int overflow.
6460
6461 * font.c (font_list_entities): Redo for clarity,
6462 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6463
6464 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6465 (font_score): Avoid potential overflow in diff calculation.
6466
6467 * fns.c (substring_both): Remove var that is set but not used.
6468 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6469
6470 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6471
6472 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6473 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6474 can always succeed if overflow has undefined behavior.
6475
6476 * search.c (boyer_moore, wordify): Remove vars set but not used.
6477 (wordify): Omit three unnecessary tests.
6478
6479 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6480 All callers changed. This avoids the need for an unused var.
6481
6482 * casefiddle.c (casify_region): Remove var that is set but not used.
6483
6484 * dired.c (file_name_completion): Remove var that is set but not used.
6485
6486 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6487
6488 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6489 (Finsert_file_contents): Remove unnecessary code checking fd.
6490
6491 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6492 Check for integer overflow on size calculations.
6493
6494 * buffer.c (Fprevious_overlay_change): Remove var that is set
6495 but not used.
6496
6497 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6498 Remove vars that are set but not used.
6499 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6500 (timer_check_2): Mark vars as initialized.
6501
6502 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6503
6504 * image.c (lookup_image): Remove var that is set but not used.
6505 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6506
6507 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6508 that are set but not used.
6509
6510 * xfns.c (make_invisible_cursor): Don't return garbage
6511 if XCreateBitmapFromData fails (Bug#8410).
6512
6513 * xselect.c (x_get_local_selection, x_handle_property_notify):
6514 Remove vars that are set but not used.
6515
6516 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6517 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6518
6519 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6520 Remove var that is set but not used.
6521 (scroll_bar_windows_size): Now size_t, not int.
6522 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6523 Check for overflow.
6524
6525 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6526 (map_tty_color) [!defined MSDOS]: Likewise.
6527
6528 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6529
6530 * coding.c: Remove vars that are set but not used.
6531 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6532 All callers changed.
6533 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6534 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6535 (decode_coding_charset): Remove vars that are set but not used.
6536
6537 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6538 that is set but not used.
6539
6540 * print.c (print_object): Remove var that is set but not used.
6541
6542 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6543 The gnulib version avoids calling malloc in the usual case,
6544 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6545 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6546 * filelock.c (current_lock_owner): Likewise.
6547 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6548 * sysdep.c: Include allocator.h, careadlinkat.h.
6549 (emacs_no_realloc_allocator): New static constant.
6550 (emacs_readlink): New function.
6551 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6552 ../lib/careadlinkat.h.
6553
6554 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6555
6556 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6557 first non-nil return value).
6558
6559 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6560
6561 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6562 if not defined (Bug#8403).
6563
6564 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6565
6566 * xdisp.c (display_count_lines): Remove parameter `start',
6567 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6568 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6569 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6570 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6571 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6572 and thereabouts. All callers changed.
6573 (get_per_char_metric): Remove parameter `f', unused since
6574 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6575
6576 2011-04-02 Jim Meyering <meyering@redhat.com>
6577
6578 do not dereference NULL upon failed strdup
6579 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6580 (ns_get_family): Likewise.
6581
6582 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6583
6584 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6585
6586 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6587
6588 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6589 later (Bug#8403).
6590
6591 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6592
6593 Add lexical binding.
6594
6595 * window.c (Ftemp_output_buffer_show): New fun.
6596 (Fsave_window_excursion):
6597 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6598
6599 * lread.c (lisp_file_lexically_bound_p): New function.
6600 (Fload): Bind Qlexical_binding.
6601 (readevalloop): Remove `evalfun' arg.
6602 Bind Qinternal_interpreter_environment.
6603 (Feval_buffer): Bind Qlexical_binding.
6604 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6605 Mark as dynamic.
6606 (syms_of_lread): Declare `lexical-binding'.
6607
6608 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6609
6610 * keyboard.c (eval_dyn): New fun.
6611 (menu_item_eval_property): Use it.
6612
6613 * image.c (parse_image_spec): Use Ffunctionp.
6614
6615 * fns.c (concat, mapcar1): Accept byte-code-functions.
6616
6617 * eval.c (Fsetq): Handle lexical vars.
6618 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6619 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6620 (FletX, Flet): Obey lexical binding.
6621 (Fcommandp): Handle closures.
6622 (Feval): New `lexical' arg.
6623 (eval_sub): New function extracted from Feval. Use it almost
6624 everywhere where Feval was used. Look up vars in lexical env.
6625 Handle closures.
6626 (Ffunctionp): Move from subr.el.
6627 (Ffuncall): Handle closures.
6628 (apply_lambda): Remove `eval_flags'.
6629 (funcall_lambda): Handle closures and new byte-code-functions.
6630 (Fspecial_variable_p): New function.
6631 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6632 but without exporting it to Lisp.
6633
6634 * doc.c (Fdocumentation, store_function_docstring):
6635 * data.c (Finteractive_form): Handle closures.
6636
6637 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6638 interactive spec.
6639
6640 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6641 New byte-codes.
6642 (exec_byte_code): New function extracted from Fbyte_code to handle new
6643 calling convention for byte-code-functions. Add new byte-codes.
6644
6645 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6646
6647 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6648
6649 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6650
6651 * xdisp.c (redisplay_internal): Fix prototype.
6652
6653 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6654
6655 * xdisp.c (SCROLL_LIMIT): New macro.
6656 (try_scrolling): Use it when setting scroll_limit.
6657 Limit scrolling to 100 screen lines.
6658 (redisplay_window): Even when falling back on "recentering",
6659 position point in the window according to scroll-conservatively,
6660 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6661
6662 (try_scrolling): When point is above the window, allow searching
6663 as far as scroll_max, or one screenful, to compute vertical
6664 distance from PT to the scroll margin position. This prevents
6665 try_scrolling from unnecessarily failing when
6666 scroll-conservatively is set to a value slightly larger than the
6667 window height. Clean up the case of PT below the margin at bottom
6668 of window: scroll_max can no longer be INT_MAX. When aggressive
6669 scrolling is in use, don't let point enter the opposite scroll
6670 margin as result of the scroll.
6671 (syms_of_xdisp) <scroll-conservatively>: Document the
6672 threshold of 100 lines for never-recentering scrolling.
6673
6674 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6675
6676 * dispextern.h (move_it_by_lines):
6677 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6678 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6679 (message_log_check_duplicate): Remove parameters `prev_bol' and
6680 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6681 (redisplay_internal): Remove parameter `preserve_echo_area',
6682 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6683
6684 * indent.c (Fvertical_motion):
6685 * window.c (window_scroll_pixel_based, Frecenter):
6686 Don't pass `need_y_p' to `move_it_by_lines'.
6687
6688 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6689
6690 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6691 steal a few bits to be more compact.
6692 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6693 Remove unneeded casts.
6694
6695 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6696
6697 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6698
6699 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6700 binding" message (bug#7967).
6701
6702 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6703
6704 Fix more problems found by GCC 4.6.0's static checks.
6705
6706 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6707 Remove unused local var.
6708
6709 * editfns.c (Fmessage_box): Remove unused local var.
6710
6711 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6712 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6713 Omit unused local vars.
6714 * window.c (shrink_windows): Omit unused local var.
6715 * menu.c (digest_single_submenu): Omit unused local var.
6716 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6717 Omit unused local var.
6718
6719 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6720 Don't assume string length fits in int.
6721 (keyremap_step, read_key_sequence): Use size_t for sizes.
6722 (read_key_sequence): Don't check last_real_key_start redundantly.
6723
6724 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6725 instead of alloca (Bug#8344).
6726
6727 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6728 (Fbacktrace_frame): Don't assume nframes fits in int.
6729
6730 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6731
6732 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6733 concerns.
6734
6735 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6736
6737 * cm.c (calccost): Turn while-do into do-while, for clarity.
6738
6739 * keyboard.c (syms_of_keyboard): Use the same style as later
6740 in this function when indexing through an array. This also
6741 works around GCC bug 48267.
6742
6743 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6744
6745 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6746
6747 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6748 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6749
6750 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6751 This avoids undefined behavior on integer overflow, and is a bit
6752 more convenient anyway since it is compared to a size_t variable.
6753
6754 Variadic C functions now count arguments with size_t, not int.
6755 This avoids an unnecessary limitation on 64-bit machines, which
6756 caused (substring ...) to crash on large vectors (Bug#8344).
6757 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6758 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6759 All variadic functions and their callers changed accordingly.
6760 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6761 * data.c (arith_driver, float_arith_driver): Likewise.
6762 * editfns.c (general_insert_function): Likewise.
6763 * eval.c (struct backtrace.nargs, interactive_p)
6764 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6765 (funcall_lambda, mark_backtrace): Likewise.
6766 * fns.c (concat): Likewise.
6767 * frame.c (x_set_frame_parameters): Likewise.
6768 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6769 0 if not found, not -1. All callers changed.
6770
6771 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6772 (stack_copy_size): Now size_t, not int.
6773 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6774
6775 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6776
6777 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6778 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6779 All callers changed.
6780
6781 * lisp.h (multibyte_char_to_unibyte):
6782 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6783 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6784 * character.h (CHAR_TO_BYTE8):
6785 * cmds.c (internal_self_insert):
6786 * editfns.c (general_insert_function):
6787 * keymap.c (push_key_description):
6788 * search.c (Freplace_match):
6789 * xdisp.c (message_dolog, set_message_1): All callers changed.
6790
6791 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6792
6793 * keyboard.c (safe_run_hook_funcall): New function.
6794 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6795 don't set the hook to nil, but remove the offending function instead.
6796 (Qcommand_hook_internal): Remove, unused.
6797 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6798 Vcommand_hook_internal.
6799
6800 * eval.c (enum run_hooks_condition): Remove.
6801 (funcall_nil, funcall_not): New functions.
6802 (run_hook_with_args): Call each function through a `funcall' argument.
6803 Remove `cond' argument, now redundant.
6804 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6805 (Frun_hook_with_args_until_failure): Adjust accordingly.
6806 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6807
6808 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6809
6810 * dispextern.h (string_buffer_position): Remove declaration.
6811
6812 * print.c (strout): Remove parameter `multibyte', unused since
6813 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6814
6815 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6816 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6817 All callers changed.
6818
6819 * w32.c (_wsa_errlist): Use braces for struct initializers.
6820
6821 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6822 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6823 All callers changed.
6824 (string_buffer_position): Likewise. Also, make static (it's never
6825 used outside xdisp.c).
6826 (cursor_row_p): Remove parameter `w', unused since
6827 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6828 (decode_mode_spec): Remove parameter `precision', introduced during
6829 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6830 All callers changed.
6831
6832 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6833
6834 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6835
6836 2011-03-27 Anders Lindgren <andlind@gmail.com>
6837
6838 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6839 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6840 (ns_update_auto_hide_menu_bar): New functions.
6841 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6842 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6843 ns_constrain_all_frames.
6844 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6845 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6846
6847 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6848
6849 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6850
6851 2011-03-27 Glenn Morris <rgm@gnu.org>
6852
6853 * syssignal.h: Replace RETSIGTYPE with void.
6854 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6855 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6856 Replace SIGTYPE with void everywhere.
6857 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6858 * s/template.h (SIGTYPE): Remove commented out definition.
6859
6860 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6861
6862 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6863 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6864
6865 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6866
6867 * w32.c (read_unc_volume): Use parameter `henum', instead of
6868 global variable `wget_enum_handle'.
6869
6870 * keymap.c (describe_vector): Remove parameters `indices' and
6871 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6872 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6873
6874 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6875
6876 * keyboard.c (timer_check): Remove parameter `do_it_now',
6877 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6878 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6879 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6880
6881 * keyboard.c (read_char):
6882 * w32menu.c (w32_menu_display_help):
6883 * xmenu.c (show_help_event, menu_help_callback):
6884 Adjust calls to `show_help_echo'.
6885
6886 * gtkutil.c (xg_maybe_add_timer):
6887 * keyboard.c (readable_events):
6888 * process.c (wait_reading_process_output):
6889 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6890
6891 * insdel.c (adjust_markers_gap_motion):
6892 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6893 (gap_left, gap_right): Don't call it.
6894
6895 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6896
6897 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6898 incurred during fontification.
6899
6900 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6901
6902 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6903 (DEFVAR_PER_BUFFER): Don't pass it.
6904
6905 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6906 (scrolling_window): Don't pass it.
6907
6908 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6909
6910 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6911
6912 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6913 and `suffix'.
6914 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6915 of variables specific to SELinux and computation of `encoded_absname'.
6916
6917 * image.c (XPutPixel): Remove unused variable `height'.
6918
6919 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6920
6921 * unexw32.c (get_section_info): Remove unused variable `section'.
6922
6923 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6924 (system_process_attributes): Remove unused variable `sess'.
6925 (sys_read): Remove unused variable `err'.
6926
6927 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6928 (w32_wnd_proc): Remove unused variable `isdead'.
6929 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6930 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6931 (x_create_tip_frame): Remove unused variable `tem'.
6932
6933 * w32inevt.c (w32_console_read_socket):
6934 Remove unused variable `no_events'.
6935
6936 * w32term.c (x_draw_composite_glyph_string_foreground):
6937 Remove unused variable `width'.
6938
6939 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6940
6941 * w32term.c (x_set_glyph_string_clipping):
6942 Don't pass uninitialized region to CombineRgn.
6943
6944 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6945
6946 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6947 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6948 (Fx_close_connection): Remove unused variable `i'.
6949
6950 * w32font.c (w32font_draw): Return number of glyphs.
6951 (w32font_open_internal): Remove unused variable `i'.
6952 (w32font_driver): Add missing initializer.
6953
6954 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6955 (fill_in_menu): Remove unused variable `items_added'.
6956
6957 * w32term.c (last_mouse_press_frame): Remove static global variable.
6958 (w32_clip_to_row): Remove unused variable `f'.
6959 (x_delete_terminal): Remove unused variable `i'.
6960
6961 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6962 (NOTHING): Remove unused static global variable.
6963 (uniscribe_check_otf): Remove unused variable `table'.
6964 (uniscribe_font_driver): Add missing initializers.
6965
6966 2011-03-23 Julien Danjou <julien@danjou.info>
6967
6968 * term.c (Fsuspend_tty, Fresume_tty):
6969 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6970 * window.c (temp_output_buffer_show):
6971 * insdel.c (signal_before_change):
6972 * frame.c (Fhandle_switch_frame):
6973 * fileio.c (Fdo_auto_save):
6974 * emacs.c (Fkill_emacs):
6975 * editfns.c (save_excursion_restore):
6976 * cmds.c (internal_self_insert):
6977 * callint.c (Fcall_interactively):
6978 * buffer.c (Fkill_all_local_variables):
6979 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6980 Use Frun_hooks.
6981 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6982 unconditionnaly since it does the check itself.
6983
6984 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6985
6986 Fix more problems found by GCC 4.5.2's static checks.
6987
6988 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6989 the first time through the loop, since we know p0 < p1 then.
6990 This also avoids a gcc -Wstrict-overflow warning.
6991
6992 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6993 leading to a memory leak, possible in functions like
6994 load_charset_map_from_file that can allocate an unbounded number
6995 of objects (Bug#8318).
6996
6997 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6998 that could (at least in theory) be that large.
6999
7000 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7001 This is less likely to overflow, and avoids undefined behavior if
7002 overflow does occur. All callers changed. Use strtoul to scan
7003 for the unsigned long integer.
7004 (pint2hrstr): Simplify and tune code slightly.
7005 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7006
7007 * scroll.c (do_scrolling): Work around GCC bug 48228.
7008 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7009
7010 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7011 This also avoids a warning with gcc -Wstrict-overflow.
7012 (validate_x_resource_name): Simplify count usage.
7013 This also avoids a warning with gcc -Wstrict-overflow.
7014
7015 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7016 fail (Bug#8306).
7017
7018 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7019
7020 * process.c (Fmake_network_process): Use socklen_t, not int,
7021 where POSIX says socklen_t is required in portable programs.
7022 This fixes a porting bug on hosts like 64-bit HP-UX, where
7023 socklen_t is wider than int (Bug#8277).
7024 (Fmake_network_process, server_accept_connection):
7025 (wait_reading_process_output, read_process_output):
7026 Likewise.
7027
7028 * process.c: Rename or move locals to avoid shadowing.
7029 (list_processes_1, Fmake_network_process):
7030 (read_process_output_error_handler, exec_sentinel_error_handler):
7031 Rename or move locals.
7032 (Fmake_network_process): Define label "retry_connect" only if needed.
7033 (Fnetwork_interface_info): Fix pointer signedness.
7034 (process_send_signal): Add cast to avoid pointer signedness problem.
7035 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7036 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7037
7038 Make tparam.h and terminfo.c consistent.
7039 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7040 Include tparam.h instead, since it declares them.
7041 * cm.h (PC): Remove extern decl; tparam.h now does this.
7042 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7043 * terminfo.c: Include tparam.h, to check interfaces.
7044 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7045 (tparam): Adjust signature to match interface in tparam.h;
7046 this removes some undefined behavior. Check that outstring and len
7047 are zero, which they always are with Emacs.
7048 * tparam.h (PC, BC, UP): New extern decls.
7049
7050 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7051 (xftfont_open): Rename locals to avoid shadowing.
7052
7053 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7054 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7055 (OTF_TAG_SYM): Omit macro if not needed.
7056 (ftfont_list): Remove unused local.
7057 (get_adstyle_property, ftfont_pattern_entity):
7058 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7059 Rename locals to avoid shadowing.
7060
7061 * xfont.c (xfont_list_family): Mark var as initialized.
7062
7063 * xml.c (make_dom): Now static.
7064
7065 * composite.c (composition_compute_stop_pos): Rename local to
7066 avoid shadowing.
7067 (composition_reseat_it): Remove unused locals.
7068 (find_automatic_composition, composition_adjust_point): Likewise.
7069 (composition_update_it): Mark var as initialized.
7070 (find_automatic_composition): Mark vars as initialized,
7071 with a FIXME (Bug#8290).
7072
7073 character.h: Rename locals to avoid shadowing.
7074 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7075 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7076 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7077 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7078 to avoid shadowing.
7079
7080 * textprop.c (property_change_between_p): Remove; unused.
7081
7082 * intervals.c (interval_start_pos): Now static.
7083
7084 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7085
7086 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7087 Rename locals to avoid shadowing.
7088
7089 * sound.c (wav_play, au_play, Fplay_sound_internal):
7090 Fix pointer signedness.
7091 (alsa_choose_format): Remove unused local var.
7092 (wav_play): Initialize a variable to 0, to prevent undefined
7093 behavior (Bug#8278).
7094
7095 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7096
7097 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7098
7099 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7100 clobbering (Bug#8298).
7101 * sysdep.c (sys_subshell): Likewise.
7102 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7103
7104 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7105 This should get cleaned up, so that child_setup has the
7106 same signature on all platforms.
7107
7108 * callproc.c (call_process_cleanup): Now static.
7109 (relocate_fd): Rename locals to avoid shadowing.
7110
7111 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7112
7113 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7114 not to be necessary, and produces flickering.
7115
7116 2011-03-20 Glenn Morris <rgm@gnu.org>
7117
7118 * config.in: Remove file.
7119
7120 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7121
7122 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7123 are now in src/globals.h.
7124 (syms_of_minibuf): Remove spurious & from previous change.
7125
7126 2011-03-20 Leo <sdl.web@gmail.com>
7127
7128 * minibuf.c (completing-read-function): New variable.
7129 (completing-read-default): Rename from completing-read.
7130 (completing-read): Call completing-read-function.
7131
7132 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7133
7134 * xfaces.c (Fx_load_color_file):
7135 Read color file from absolute filename (bug#8250).
7136
7137 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7138
7139 * makefile.w32-in: Update dependencies.
7140
7141 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7142
7143 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7144
7145 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7146
7147 Fix more problems found by GCC 4.5.2's static checks.
7148
7149 * process.c (make_serial_process_unwind, send_process_trap):
7150 (sigchld_handler): Now static.
7151
7152 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7153 That way, the code declares only the vars that it needs.
7154 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7155 * s/cygwin.h (PTY_ITERATION): Likewise.
7156 * s/darwin.h (PTY_ITERATION): Likewise.
7157 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7158
7159 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7160 * process.c (allocate_pty): Don't declare stb unless it's needed.
7161
7162 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7163 (CONSTANTLIM): Remove; unused.
7164 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7165 Define only if needed.
7166
7167 * unexelf.c (unexec): Name an expression,
7168 to avoid gcc -Wbad-function-cast warning.
7169 Use a different way to cause a compilation error if anyone uses
7170 n rather than nn, a way that does not involve shadowing.
7171 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7172
7173 * deps.mk (unexalpha.o): Remove; unused.
7174
7175 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7176 * unexec.h: New file.
7177 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7178 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7179 Depend on unexec.h.
7180 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7181 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7182 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7183 Change as necessary to match prototype in unexec.h.
7184
7185 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7186 shadowing.
7187 (back_comment, skip_chars): Mark vars as initialized.
7188
7189 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7190 Rename locals to avoid shadowing.
7191
7192 * lread.c (read1): Rewrite so as not to use empty "else".
7193 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7194
7195 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7196
7197 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7198 warning when compiling print.c.
7199
7200 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7201 instead of using an uninitialized var.
7202 (font_sort_entities): Mark var as initialized.
7203
7204 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7205
7206 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7207 pointers to constants.
7208 (font_parse_fcname): Remove unused vars.
7209 (font_delete_unmatched): Now static.
7210 (font_get_spec): Remove; unused.
7211 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7212 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7213 Rename or move locals to avoid shadowing.
7214
7215 * fns.c (require_nesting_list, require_unwind): Now static.
7216 (Ffillarray): Rename locals to avoid shadowing.
7217
7218 * floatfns.c (domain_error2): Define only if needed.
7219 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7220
7221 * alloc.c (mark_backtrace): Move decl from here ...
7222 * lisp.h: ... to here, so that it can be checked.
7223
7224 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7225 (Fdefvar): Rewrite so as not to use empty "else".
7226 (lisp_indirect_variable): Name an expression,
7227 to avoid gcc -Wbad-function-cast warning.
7228 (Fdefvar): Rename locals to avoid shadowing.
7229
7230 * callint.c (quotify_arg, quotify_args): Now static.
7231 (Fcall_interactively): Rename locals to avoid shadowing.
7232 Use const pointer when appropriate.
7233
7234 * lisp.h (get_system_name, get_operating_system_release):
7235 Move decls here, to check interfaces.
7236 * process.c (get_operating_system_release): Move decl to lisp.h.
7237 * xrdb.c (get_system_name): Likewise.
7238 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7239 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7240 some of which prompt warnings from gcc -Wbad-function-cast.
7241 (Fformat_time_string, Fencode_time, Finsert_char):
7242 (Ftranslate_region_internal, Fformat):
7243 Rename or remove local vars to avoid shadowing.
7244 (Ftranslate_region_internal): Mark var as initialized.
7245
7246 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7247 avoid shadowing.
7248
7249 * lisp.h (eassert): Check that the argument compiles, even if
7250 ENABLE_CHECKING is not defined.
7251
7252 * data.c (Findirect_variable): Name an expression, to avoid
7253 gcc -Wbad-function-cast warning.
7254 (default_value, arithcompare, arith_driver, arith_error): Now static.
7255 (store_symval_forwarding): Rename local to avoid shadowing.
7256 (Fmake_variable_buffer_local, Fmake_local_variable):
7257 Mark variables as initialized.
7258 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7259
7260 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7261 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7262 Rename locals to avoid shadowing.
7263 (mark_stack): Move local variables into the #ifdef region where
7264 they're used.
7265 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7266 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7267 needed otherwise.
7268 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7269 (GC_STRING_CHARS): Remove; not used.
7270 (Fmemory_limit): Cast sbrk's returned value to char *.
7271
7272 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7273 avoids undefined behavior in theory.
7274
7275 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7276
7277 Use functions, not macros, for up- and down-casing (Bug#8254).
7278 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7279 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7280 to use the following functions instead of these macros.
7281 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7282 EMACS_INT, since callers assume the returned value fits in int.
7283 (upcase1): Likewise, for UPCASE_TABLE.
7284 (uppercasep, lowercasep, upcase): New static inline functions.
7285 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7286 the race-condition problem in the old DOWNCASE.
7287
7288 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7289 Rename locals to avoid shadowing.
7290 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7291 (regex_compile, re_search_2, re_match_2_internal):
7292 Remove unused local vars.
7293 (FREE_VAR): Rewrite so as not to use empty "else",
7294 which gcc can warn about.
7295 (regex_compile, re_match_2_internal): Mark locals as initialized.
7296 (RETALLOC_IF): Define only if needed.
7297 (WORDCHAR_P): Likewise. This one is never needed, but is used
7298 only in a comment talking about a compiler bug, so put inside
7299 the #if 0 of that comment.
7300 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7301 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7302 Remove; unused.
7303
7304 * search.c (boyer_moore): Rename locals to avoid shadowing.
7305 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7306 (PREV_CHAR_BOUNDARY): Likewise.
7307
7308 * search.c (simple_search): Remove unused var.
7309
7310 * dired.c (compile_pattern): Move decl from here ...
7311 * lisp.h: ... to here, so that it can be checked.
7312 (struct re_registers): New forward decl.
7313
7314 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7315
7316 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7317 All uses changed.
7318 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7319 Rename locals to avoid shadowing.
7320 (Fvertical_motion): Mark locals as initialized.
7321
7322 * casefiddle.c (casify_object, casify_region): Now static.
7323 (casify_region): Mark local as initialized.
7324
7325 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7326
7327 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7328 New macros, so that the caller can use some names other than
7329 gcpro1, gcpro2, etc.
7330 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7331 of the new macros.
7332 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7333 argument, for consistency with GCPRO2_VAR, etc: it is now the
7334 prefix of the variable, not the variable itself. All uses
7335 changed.
7336 * dired.c (directory_files_internal, file_name_completion):
7337 Rename locals to avoid shadowing.
7338
7339 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7340 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7341 dired.c's scmp function, had undefined behavior.
7342 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7343 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7344 * buffer.h: ... to here, because these macros use current_buffer,
7345 and the new implementation with inline functions needs to have
7346 current_buffer in scope now, rather than later when the macros
7347 are used.
7348 (downcase, upcase1): New static inline functions.
7349 (DOWNCASE, UPCASE1): Reimplement using these functions.
7350 This avoids undefined behavior in expressions like
7351 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7352 from race conditions in accessing the global variables
7353 case_temp1 and case_temp2.
7354 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7355 * lisp.h (case_temp1, case_temp2): Remove their decls.
7356 * character.h (ASCII_CHAR_P): Move from here ...
7357 * lisp.h: ... to here, so that the inline functions mentioned
7358 above can use them.
7359
7360 * dired.c (directory_files_internal_unwind): Now static.
7361
7362 * fileio.c (file_name_as_directory, directory_file_name):
7363 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7364 Now static.
7365 (file_name_as_directory): Use const pointers when appropriate.
7366 (Fexpand_file_name): Likewise. In particular, newdir might
7367 point at constant storage, so make it a const pointer.
7368 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7369 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7370 signedness issues.
7371 (Fset_file_times, Finsert_file_contents, auto_save_error):
7372 Rename locals to avoid shadowing.
7373
7374 * minibuf.c (choose_minibuf_frame_1): Now static.
7375 (Ftry_completion, Fall_completions): Rename or remove locals
7376 to avoid shadowing.
7377
7378 * marker.c (bytepos_to_charpos): Remove; unused.
7379
7380 * lisp.h (verify_bytepos, count_markers): New decls,
7381 so that gcc does not warn that these functions aren't declared.
7382
7383 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7384 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7385 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7386 (copy_text): Remove unused local var.
7387
7388 * filelock.c (within_one_second): Now static.
7389 (lock_file_1): Rename local to avoid shadowing.
7390
7391 * buffer.c (fix_overlays_before): Mark locals as initialized.
7392 (fix_start_end_in_overlays): Likewise. This function should be
7393 simplified by using pointers-to-pointers, but that's a different
7394 matter.
7395 (switch_to_buffer_1): Now static.
7396 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7397 (report_overlay_modification): Rename locals to avoid shadowing.
7398
7399 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7400 Fix pointer signedness issue.
7401 (sys_subshell): Mark local as volatile if checking for lint,
7402 to suppress a gcc -Wclobbered warning that does not seem to be right.
7403 (MAXPATHLEN): Define only if needed.
7404
7405 * process.c (serial_open, serial_configure): Move decls from here ...
7406 * systty.h: ... to here, so that they can be checked.
7407
7408 * fns.c (get_random, seed_random): Move extern decls from here ...
7409 * lisp.h: ... to here, so that they can be checked.
7410
7411 * sysdep.c (reset_io): Now static.
7412 (wait_for_termination_signal): Remove; unused.
7413
7414 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7415 (copy_keymap_item, append_key, push_text_char_description):
7416 Now static.
7417 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7418 (DENSE_TABLE_SIZE): Remove; unused.
7419 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7420 (describe_map_tree):
7421 Rename locals to avoid shadowing.
7422
7423 * keyboard.c: Declare functions static if they are not used elsewhere.
7424 (echo_char, echo_dash, cmd_error, top_level_2):
7425 (poll_for_input, handle_async_input): Now static.
7426 (read_char, kbd_buffer_get_event, make_lispy_position):
7427 (make_lispy_event, make_lispy_movement, apply_modifiers):
7428 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7429 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7430 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7431 (read_key_sequence, read_char): Mark locals as initialized.
7432 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7433
7434 * keyboard.h (make_ctrl_char): New decl.
7435 (mark_kboards): Move decl here ...
7436 * alloc.c (mark_kboards): ... from here.
7437
7438 * lisp.h (force_auto_save_soon): New decl.
7439
7440 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7441 (DEFINE_DUMMY_FUNCTION): New macro.
7442 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7443 Use it.
7444 (main): Add casts to avoid warnings
7445 if GCC considers string literals to be constants.
7446
7447 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7448
7449 * dbusbind.c: Pointer signedness fixes.
7450 (xd_signature, xd_append_arg, xd_initialize):
7451 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7452 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7453 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7454 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7455
7456 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7457 if GCC considers string literals to be constants.
7458 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7459
7460 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7461
7462 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7463 (print_preprocess, print_object): New macro to fix last change.
7464
7465 * print.c (print_preprocess): Don't forget font objects.
7466
7467 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7468
7469 * emacs.c (USAGE3): Doc fixes.
7470
7471 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7472
7473 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7474 structure.
7475
7476 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7477
7478 * lisp.h (VWindow_system, Qfile_name_history):
7479 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7480 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7481 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7482
7483 * w32select.c: Don't #include "keyboard.h".
7484 (run_protected): Add extern declaration for waiting_for_input.
7485
7486 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7487 * w32console.c (detect_input_pending, read_input_pending)
7488 (encode_terminal_code):
7489 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7490 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7491 (w32_system_caret_y, Qfile_name_history):
7492 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7493 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7494 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7495 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7496 * w32proc.c (Qlocal, report_file_error):
7497 * w32term.c (Vwindow_system, updating_frame):
7498 * w32uniscribe.c (initialized, uniscribe_font_driver):
7499 Remove unneeded extern declarations.
7500
7501 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7502
7503 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7504
7505 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7506
7507 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7508 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7509 These macros can no longer be used for assignment.
7510
7511 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7512 Assign struct members directly, instead of using BUF_BEGV etc.
7513 (record_buffer_markers, fetch_buffer_markers): New functions for
7514 recording and fetching special buffer markers.
7515 (set_buffer_internal_1, set_buffer_temp): Use them.
7516
7517 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7518
7519 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7520
7521 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7522 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7523
7524 * xdisp.c (hscroll_window_tree):
7525 (reconsider_clip_changes): Use PT instead of BUF_PT.
7526
7527 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7528
7529 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7530 $(EMACS_ROOT)/lib/intprops.h.
7531
7532 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7533
7534 Fix more problems found by GCC 4.5.2's static checks.
7535
7536 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7537 to unsigned char * to avoid compiler diagnostic.
7538 (xg_free_frame_widgets): Make it clear that a local variable is
7539 needed only if USE_GTK_TOOLTIP.
7540 (gdk_window_get_screen): Make it clear that this macro is needed
7541 only if USE_GTK_TOOLTIP.
7542 (int_gtk_range_get_value): New function, which avoids a diagnostic
7543 from gcc -Wbad-function-cast.
7544 (xg_set_toolkit_scroll_bar_thumb): Use it.
7545 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7546 diagnostic from gcc -Wbad-function-cast.
7547 (get_utf8_string, xg_get_file_with_chooser):
7548 Rename locals to avoid shadowing.
7549 (create_dialog): Move locals to avoid shadowing.
7550
7551 * xgselect.c (xg_select): Remove unused var.
7552
7553 * image.c (four_corners_best): Mark locals as initialized.
7554 (gif_load): Initialize transparent_p to zero (Bug#8238).
7555 Mark another local as initialized.
7556 (my_png_error, my_error_exit): Mark with NO_RETURN.
7557
7558 * image.c (clear_image_cache): Now static.
7559 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7560 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7561 (x_edge_detection): Remove unnecessary cast that
7562 gcc -Wbad-function-cast diagnoses.
7563 (gif_load): Fix pointer signedness.
7564 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7565 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7566
7567 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7568
7569 Improve quality of tests for time stamp overflow.
7570 For example, without this patch (encode-time 0 0 0 1 1
7571 1152921504606846976) returns the obviously-bogus value (-948597
7572 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7573 reports time overflow. See
7574 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7575 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7576 * editfns.c: Include limits.h and intprops.h.
7577 (TIME_T_MIN, TIME_T_MAX): New macros.
7578 (time_overflow): Move earlier, to before first use.
7579 (hi_time, lo_time): New functions, for an accurate test for
7580 out-of-range times.
7581 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7582 (Fget_internal_run_time): Don't assume time_t fits in int.
7583 (make_time): Use list2 instead of Fcons twice.
7584 (Fdecode_time): More accurate test for out-of-range times.
7585 (check_tm_member): New function.
7586 (Fencode_time): Use it, to test for out-of-range times.
7587 (lisp_time_argument): Don't rely on undefined left-shift and
7588 right-shift behavior when checking for time stamp overflow.
7589
7590 * editfns.c (time_overflow): New function, refactoring common code.
7591 (Fformat_time_string, Fdecode_time, Fencode_time):
7592 (Fcurrent_time_string): Use it.
7593
7594 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7595 * dired.c (make_time): Move to ...
7596 * editfns.c (make_time): ... here.
7597 * systime.h: Note the move.
7598
7599 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7600
7601 * fringe.c (update_window_fringes): Remove unused variables.
7602
7603 * unexmacosx.c (copy_data_segment): Also copy __got section.
7604 (Bug#8223)
7605
7606 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7607
7608 * termcap.c [MSDOS]: Include "msdos.h".
7609 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7610 Constify `char *' arguments and their references according to
7611 prototypes in tparam.h.
7612
7613 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7614
7615 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7616 Adapt all references accordingly.
7617
7618 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7619
7620 2011-03-11 Tom Tromey <tromey@redhat.com>
7621
7622 * buffer.c (syms_of_buffer): Remove obsolete comment.
7623
7624 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7625
7626 * termhooks.h (encode_terminal_code): Declare prototype.
7627
7628 * msdos.c (encode_terminal_code): Don't declare prototype.
7629
7630 * term.c (encode_terminal_code): Now external again, used by
7631 w32console.c and msdos.c.
7632
7633 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7634 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7635
7636 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7637
7638 Fix some minor problems found by GCC 4.5.2's static checks.
7639
7640 * fringe.c (update_window_fringes): Mark locals as initialized
7641 (Bug#8227).
7642 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7643
7644 * alloc.c (mark_fringe_data): Move decl from here ...
7645 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7646 to check its interface.
7647 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7648
7649 * fontset.c (free_realized_fontset): Now static.
7650 (Fset_fontset_font): Rename local to avoid shadowing.
7651 (fontset_font): Mark local as initialized.
7652 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7653
7654 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7655
7656 * xselect.c (x_disown_buffer_selections): Remove; not used.
7657 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7658 (x_own_selection, Fx_disown_selection_internal): Rename locals
7659 to avoid shadowing.
7660 (x_handle_dnd_message): Remove local to avoid shadowing.
7661
7662 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7663 so that the caller can use some name other than gcpro1.
7664 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7665 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7666 (Fx_backspace_delete_keys_p):
7667 Use them to avoid shadowing, and rename vars to avoid shadowing.
7668 (x_decode_color, x_set_name, x_window): Now static.
7669 (Fx_create_frame): Add braces to silence GCC warning.
7670 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7671 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7672 Remove unused locals.
7673 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7674 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7675 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7676 macros.
7677
7678 * xterm.h (x_mouse_leave): New decl.
7679
7680 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7681 Remove unused functions.
7682 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7683 (x_calc_absolute_position): Now static.
7684 (XTread_socket): Don't define label "out" unless it's used.
7685 Don't declare local "event" unless it's used.
7686 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7687 unless they are used.
7688 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7689 (x_fatal_error_signal): Remove; not used.
7690 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7691 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7692 (x_error_catcher, x_connection_closed, x_error_handler):
7693 (x_error_quitter, xembed_send_message, x_iconify_frame):
7694 (my_log_handler): Rename locals to avoid shadowing.
7695 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7696 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7697
7698 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7699 Rename or move locals to avoid shadowing.
7700 (tty_defined_color, merge_face_heights): Now static.
7701 (free_realized_faces_for_fontset): Remove; not used.
7702 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7703 does not deduce is never used uninitialized.
7704 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7705 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7706
7707 * terminal.c (store_terminal_param): Now static.
7708
7709 * xmenu.c (menu_highlight_callback): Now static.
7710 (set_frame_menubar): Remove unused local.
7711 (xmenu_show): Rename parameter to avoid shadowing.
7712 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7713 since they might point to immutable storage.
7714 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7715 since it's unused otherwise.
7716
7717 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7718 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7719 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7720 avoids a gcc -Wuninitialized diagnostic.
7721 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7722 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7723 does not deduce are never used uninitialized.
7724
7725 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7726
7727 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7728 * window.c (window_loop, size_window):
7729 (run_window_configuration_change_hook, enlarge_window): Likewise.
7730
7731 * window.c (display_buffer): Now static.
7732 (size_window): Mark variables that gcc -Wuninitialized
7733 does not deduce are never used uninitialized.
7734 * window.h (check_all_windows): New decl, to forestall
7735 gcc -Wmissing-prototypes diagnostic.
7736 * dispextern.h (bidi_dump_cached_states): Likewise.
7737
7738 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7739 shadowing.
7740 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7741 Include <limits.h>.
7742 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7743 and to avoid gcc -Wuninitialized warning.
7744 (load_charset_map): Mark variables that gcc -Wuninitialized
7745 does not deduce are never used uninitialized.
7746 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7747
7748 * coding.c (coding_set_source, coding_set_destination):
7749 Use "else { /* comment */ }" rather than "else /* comment */;"
7750 for clarity, and to avoid gcc -Wempty-body warning.
7751 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7752 a block, when the outer 'i' will do.
7753 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7754 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7755 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7756 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7757 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7758 Rename locals to avoid shadowing.
7759 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7760 * coding.c (emacs_mule_char, encode_invocation_designation):
7761 Now static, since they're not used elsewhere.
7762 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7763 (decode_coding_object, encode_coding_object, detect_coding_system):
7764 (decode_coding_emacs_mule): Mark variables that gcc
7765 -Wuninitialized does not deduce are never used uninitialized.
7766 (detect_coding_iso_2022): Initialize a local variable that might
7767 be used uninitialized. Leave a FIXME because it's not clear that
7768 this initialization is needed. (Bug#8211)
7769 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7770 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7771 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7772 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7773 Remove unused macros.
7774
7775 * category.c (hash_get_category_set): Remove unused local var.
7776 (copy_category_table): Now static, since it's not used elsewhere.
7777 * character.c (string_count_byte8): Likewise.
7778
7779 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7780 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7781
7782 * chartab.c (copy_sub_char_table): Now static, since it's not used
7783 elsewhere.
7784 (sub_char_table_ref_and_range, char_table_ref_and_range):
7785 Rename locals to avoid shadowing.
7786 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7787
7788 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7789 (BIDI_BOB): Remove unused macro.
7790
7791 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7792 deduce are never used uninitialized.
7793 * term.c (encode_terminal_code): Likewise.
7794
7795 * term.c (encode_terminal_code): Now static. Remove unused local.
7796
7797 * tparam.h: New file.
7798 * term.c, tparam.h: Include it.
7799 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7800 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7801 Move these decls to tparam.h, and make them agree with what
7802 is actually in tparam.c. The previous trick of using incompatible
7803 decls in different modules does not conform to the C standard.
7804 All callers of tparam changed to use tparam's actual API.
7805 * tparam.c (tparam1, tparam, tgoto):
7806 Use const pointers where appropriate.
7807
7808 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7809 * cm.h (struct cm): Likewise.
7810 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7811 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7812 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7813 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7814 (turn_on_face, init_tty): Likewise.
7815 * termchar.h (struct tty_display_info): Likewise.
7816
7817 * term.c (term_mouse_position): Rename local to avoid shadowing.
7818
7819 * alloc.c (mark_ttys): Move decl from here ...
7820 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7821
7822 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7823
7824 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7825
7826 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7827
7828 * search.c (compile_pattern_1): Remove argument regp, unused since
7829 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7830 (compile_pattern): Don't pass it.
7831
7832 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7833
7834 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7835 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7836 for ! HAVE_GTK3.
7837 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7838
7839 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7840
7841 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7842 gdk_window_get_screen, gdk_window_get_geometry,
7843 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7844 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7845 (xg_get_pixbuf_from_pixmap): New function.
7846 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7847 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7848 Call xg_get_pixbuf_from_pixmap instead of
7849 gdk_pixbuf_get_from_drawable.
7850 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7851 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7852 (xg_check_special_colors): Use GtkStyleContext and its functions
7853 for HAVE_GTK3.
7854 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7855 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7856 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7857 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7858 Call gtk_widget_get_preferred_size.
7859 (xg_frame_resized): gdk_window_get_geometry only takes 5
7860 parameters.
7861 (xg_win_to_widget, xg_event_is_for_menubar):
7862 Call gdk_x11_window_lookup_for_display.
7863 (xg_set_widget_bg): New function.
7864 (delete_cb): New function.
7865 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7866 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7867 (xg_set_background_color): Call xg_set_widget_bg.
7868 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7869 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7870 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7871 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7872 if ! HAVE_GTK3.
7873 (update_frame_tool_bar): Call gtk_widget_hide.
7874 (xg_initialize): Use GDK_KEY_g.
7875
7876 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7877 if ! HAVE_GTK3
7878 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7879
7880 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7881 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7882 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7883
7884 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7885
7886 * w32xfns.c (select_palette): Check success of RealizePalette against
7887 GDI_ERROR, not zero.
7888
7889 See ChangeLog.11 for earlier changes.
7890
7891 ;; Local Variables:
7892 ;; coding: utf-8
7893 ;; End:
7894
7895 Copyright (C) 2011 Free Software Foundation, Inc.
7896
7897 This file is part of GNU Emacs.
7898
7899 GNU Emacs is free software: you can redistribute it and/or modify
7900 it under the terms of the GNU General Public License as published by
7901 the Free Software Foundation, either version 3 of the License, or
7902 (at your option) any later version.
7903
7904 GNU Emacs is distributed in the hope that it will be useful,
7905 but WITHOUT ANY WARRANTY; without even the implied warranty of
7906 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7907 GNU General Public License for more details.
7908
7909 You should have received a copy of the GNU General Public License
7910 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.