]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* xmenu.c (x_menu_set_in_use): Fix incorrect assumption.
[gnu-emacs] / src / ChangeLog
1 2011-06-11 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.c (Qclone_number): Remove for now, as it's unused.
4 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5 (record_buffer): Remove unused local.
6 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7 (set_frame_buffer_list): Remove; unused.
8 * frame.h (other_visible_frames): Remove decl.
9 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12 if HAVE_GPM.
13 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
14 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
15 Define only if HAVE_GPM.
16 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
17 (update_hints_inhibit): Remove; never set. All uses removed.
18 * widgetprv.h (emacsFrameClassRec): Remove decl.
19 * window.c (delete_deletable_window): Now returns void, since it
20 wasn't returning anything.
21 (compare_window_configurations): Remove unused locals.
22 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
23 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
24 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
25 the same widths as pointers. This follows up on the 2011-05-06 patch.
26 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
27 * xterm.h: Likewise.
28 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
29
30 2011-06-11 Martin Rudalics <rudalics@gmx.at>
31
32 * window.c (delete_deletable_window): Re-add.
33 (Fset_window_configuration): Rewrite to handle dead buffers and
34 consequently deletable windows.
35 (window_tree, Fwindow_tree): Remove. Supply functionality in
36 window.el.
37 (compare_window_configurations): Simplify code.
38
39 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
40
41 * image.c (imagemagick_load_image): Fix type mismatch.
42 (Fimagemagick_types): Likewise.
43
44 * window.h (replace_buffer_in_windows): Declare.
45
46 2011-06-11 Martin Rudalics <rudalics@gmx.at>
47
48 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
49 Qclone_number. Remove external declaration of Qdelete_window.
50 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
51 code.
52 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
53 Qbuffer_list_update_hook if allowed.
54 (Fother_buffer): Rewrite doc-string. Major rewrite for new
55 buffer list implementation.
56 (other_buffer_safely): New function.
57 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
58 calls to replace_buffer_in_windows and
59 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
60 if allowed.
61 (record_buffer): Inhibit quitting and rewrite using quittable
62 functions. Run Qbuffer_list_update_hook if allowed.
63 (Frecord_buffer, Funrecord_buffer): New functions.
64 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
65 switch-to-buffer to window.el.
66 (bury-buffer): Move to window.el.
67 (Vbuffer_list_update_hook): New variable.
68
69 * lisp.h (other_buffer_safely): Add prototype in buffer.c
70 section.
71
72 * window.h (resize_frame_windows): Move up in code.
73 (Fwindow_frame): Remove EXFUN.
74 (replace_buffer_in_all_windows): Remove prototype.
75 (replace_buffer_in_windows_safely): Add prototype.
76
77 * window.c: Declare Qdelete_window static again. Move down
78 declaration of select_count.
79 (Fnext_window, Fprevious_window): Rewrite doc-strings.
80 (Fother_window): Move to window.el.
81 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
82 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
83 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
84 window.el.
85 (replace_buffer_in_windows): Implement by calling
86 Qreplace_buffer_in_windows.
87 (replace_buffer_in_all_windows): Remove with some functionality
88 moved into replace_buffer_in_windows_safely.
89 (replace_buffer_in_windows_safely): New function.
90 (select_window_norecord, select_frame_norecord): Move in front
91 of run_window_configuration_change_hook. Remove now obsolete
92 declarations.
93 (Fset_window_buffer): Rewrite doc-string. Call
94 Qrecord_window_buffer.
95 (keys_of_window): Move binding for other-window to window.el.
96
97 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
98
99 * dispextern.h (struct image): Replace data member, whose int_val
100 and ptr_val fields were not used by anything, with a single
101 lisp_val object.
102
103 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
104 (gif_clear_image, gif_load, imagemagick_load_image)
105 (gs_clear_image, gs_load): Callers changed.
106
107 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
108
109 * buffer.h: Include <time.h>, for time_t.
110 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
111
112 Fix minor problems found by static checking.
113
114 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
115
116 Make identifiers static if they are not used in other modules.
117 * data.c (Qcompiled_function, Qframe, Qvector):
118 * image.c (QimageMagick, Qsvg):
119 * minibuf.c (Qmetadata):
120 * window.c (resize_window_check, resize_root_window): Now static.
121 * window.h (resize_window_check, resize_root_window): Remove decls.
122
123 * window.c (window_deletion_count, delete_deletable_window):
124 Remove; unused.
125 (window_body_lines): Now static.
126 (Fdelete_other_windows_internal): Mark vars as initialized.
127 Make sure 'resize_failed' is initialized.
128 (run_window_configuration_change_hook): Rename local to avoid shadowing.
129 (resize_window_apply): Remove unused local.
130 * window.h (delete_deletable_window): Remove decl.
131
132 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
133 (imagemagick_load_image): Fix pointer signedness problem by changing
134 last arg from unsigned char * to char *. All uses changed.
135 Also, fix a local for similar reasons.
136 Remove unused locals. Remove locals to avoid shadowing.
137 (fn_rsvg_handle_free): Remove; unused.
138 (svg_load, svg_load_image): Fix pointer signedness problem.
139 (imagemagick_load_image): Don't use garbage pointer image_wand.
140
141 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
142
143 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
144
145 * image.c (gif_load): Fix omitted cast error introduced by
146 2011-06-06 change.
147
148 2011-06-10 Martin Rudalics <rudalics@gmx.at>
149
150 * window.h (resize_proportionally, orig_total_lines)
151 (orig_top_line): Remove from window structure.
152 (set_window_height, set_window_width, change_window_heights)
153 (Fdelete_window): Remove prototypes.
154 (resize_frame_windows): Remove duplicate declaration.
155
156 2011-06-10 Eli Zaretskii <eliz@gnu.org>
157
158 * window.h (resize_frame_windows, resize_window_check)
159 (delete_deletable_window, resize_root_window)
160 (resize_frame_windows): Declare prototypes.
161
162 * window.c (resize_window_apply): Make definition be "static" to
163 match the prototype.
164
165 2011-06-10 Martin Rudalics <rudalics@gmx.at>
166
167 * window.c: Remove declarations of Qwindow_size_fixed,
168 window_min_size_1, window_min_size_2, window_min_size,
169 size_window, window_fixed_size_p, enlarge_window, delete_window.
170 Remove static from declaration of Qdelete_window, it's
171 temporarily needed by Fbury_buffer.
172 (replace_window): Don't assign orig_top_line and
173 orig_total_lines.
174 (Fdelete_window, delete_window): Remove. Window deletion is
175 handled by window.el.
176 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
177 Fdelete_window calls with calls to Qdelete_window.
178 (Fdelete_other_windows): Remove. Deleting other windows is
179 handled by window.el.
180 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
181 handled in window.el.
182 (window_min_size_2, window_min_size_1, window_min_size): Remove.
183 Window minimum sizes are handled in window.el.
184 (shrink_windows, size_window, set_window_height)
185 (set_window_width, change_window_heights, window_height)
186 (window_width, CURBEG, CURSIZE, enlarge_window)
187 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
188 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
189 handled in window.el.
190 (make_dummy_parent): Rename to make_parent_window and give it a
191 second argument horflag.
192 (make_window): Don't set resize_proportionally any more.
193 (Fsplit_window): Remove. Windows are split in window.el.
194 (save_restore_action, save_restore_orig_size)
195 (shrink_window_lowest_first, save_restore_orig_size): Remove.
196 Resize mini windows in window.el.
197 (grow_mini_window, shrink_mini_window): Implement by calling
198 Qresize_root_window_vertically, resize_window_check and
199 resize_window_apply.
200 (saved_window, Fset_window_configuration, save_window_save): Do
201 not handle orig_top_line, orig_total_lines, and
202 resize_proportionally.
203 (window_min_height, window_min_width): Move to window.el.
204 (keys_of_window): Move bindings for delete-other-windows,
205 split-window, delete-window and enlarge-window to window.el.
206
207 * buffer.c: Temporarily extern Qdelete_window.
208 (Fbury_buffer): Temporarily call Qdelete_window instead of
209 Fdelete_window (Fbury_buffer will move to window.el soon).
210
211 * frame.c (set_menu_bar_lines_1): Remove code handling
212 orig_top_line and orig_total_lines.
213
214 * dispnew.c (adjust_frame_glyphs_initially): Don't use
215 set_window_height but set heights directly.
216 (change_frame_size_1): Use resize_frame_windows.
217
218 * xdisp.c (init_xdisp): Don't use set_window_height but set
219 heights directly.
220
221 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
222 resize_frame_windows instead of change_window_heights and run
223 run_window_configuration_change_hook.
224
225 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
226 instead of change_window_heights and run
227 run_window_configuration_change_hook.
228
229 2011-06-09 Martin Rudalics <rudalics@gmx.at>
230
231 * window.c (replace_window): Rename second argument REPLACEMENT to
232 NEW. New third argument SETFLAG. Rewrite.
233 (delete_window, make_dummy_parent): Call replace_window with
234 third argument 1.
235 (window_list_1): Move down in code.
236 (run_window_configuration_change_hook): Move set_buffer part
237 before select_frame_norecord part in order to unwind correctly.
238 Rename count1 to count.
239 (recombine_windows, delete_deletable_window, resize_root_window)
240 (Fdelete_other_windows_internal)
241 (Frun_window_configuration_change_hook, make_parent_window)
242 (resize_window_check, resize_window_apply, Fresize_window_apply)
243 (resize_frame_windows, Fsplit_window_internal)
244 (Fdelete_window_internal, Fresize_mini_window_internal): New
245 functions.
246 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
247
248 2011-06-08 Martin Rudalics <rudalics@gmx.at>
249
250 * window.h (window): Add some new members to window structure -
251 normal_lines, normal_cols, new_total, new_normal, clone_number,
252 splits, nest, prev_buffers, next_buffers.
253 (WINDOW_TOTAL_SIZE): Move here from window.c.
254 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
255
256 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
257 Remove.
258 (make_dummy_parent): Set new members of windows structure.
259 (make_window): Move down in code. Handle new members of window
260 structure.
261 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
262 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
263 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
264 (Fset_window_prev_buffers, Fwindow_next_buffers)
265 (Fset_window_next_buffers, Fset_window_clone_number): New
266 functions.
267 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
268 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
269 Doc-string fixes.
270 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
271 Argument WINDOW can be now internal window too.
272 (Fwindow_use_time): Move up in code.
273 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
274 Rewrite doc-string.
275 (Fset_window_configuration, saved_window)
276 (Fcurrent_window_configuration, save_window_save): Handle new
277 members of window structure.
278 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
279 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
280 (syms_of_window): New Lisp objects Qrecord_window_buffer,
281 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
282 Qget_mru_window, Qresize_root_window,
283 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
284 Qauto_buffer_name; staticpro them.
285
286 2011-06-07 Martin Rudalics <rudalics@gmx.at>
287
288 * window.c (Fwindow_total_size, Fwindow_left_column)
289 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
290 (Fwindow_list_1): New functions.
291 (window_box_text_cols): Replace with window_body_cols.
292 (Fwindow_width, Fscroll_left, Fscroll_right): Use
293 window_body_cols instead of window_box_text_cols.
294 (delete_window, Fset_window_configuration): Call
295 delete_all_subwindows with window as argument.
296 (delete_all_subwindows): Take a window as argument and not a
297 structure. Rewrite.
298 (window_loop): Remove handling of GET_LRU_WINDOW and
299 GET_LARGEST_WINDOW.
300 (Fget_lru_window, Fget_largest_window): Move to window.el.
301
302 * window.h: Extern window_body_cols instead of
303 window_box_text_cols. delete_all_subwindows now takes a
304 Lisp_Object as argument.
305
306 * indent.c (compute_motion, Fcompute_motion): Use
307 window_body_cols instead of window_box_text_cols.
308
309 * frame.c (delete_frame): Call delete_all_subwindows with root
310 window as argument.
311
312 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
313
314 * fns.c (Fputhash): Document return value.
315
316 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
317
318 * image.c (gif_load): Implement gif89a spec "no disposal" method.
319
320 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
321
322 Cons<->int and similar integer overflow fixes (Bug#8794).
323
324 Check for overflow when converting integer to cons and back.
325 * charset.c (Fdefine_charset_internal, Fdecode_char):
326 Use cons_to_unsigned to catch overflow.
327 (Fencode_char): Use INTEGER_TO_CONS.
328 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
329 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
330 * data.c (long_to_cons, cons_to_long): Remove.
331 (cons_to_unsigned, cons_to_signed): New functions.
332 These signal an error for invalid or out-of-range values.
333 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
334 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
335 * font.c (Ffont_variation_glyphs):
336 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
337 * lisp.h: Include <intprops.h>.
338 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
339 (cons_to_signed, cons_to_unsigned): New decls.
340 (long_to_cons, cons_to_long): Remove decls.
341 * undo.c (record_first_change): Use INTEGER_TO_CONS.
342 (Fprimitive_undo): Use CONS_TO_INTEGER.
343 * xfns.c (Fx_window_property): Likewise.
344 * xselect.c: Include <limits.h>.
345 (x_own_selection, selection_data_to_lisp_data):
346 Use INTEGER_TO_CONS.
347 (x_handle_selection_request, x_handle_selection_clear)
348 (x_get_foreign_selection, Fx_disown_selection_internal)
349 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
350 (lisp_data_to_selection_data): Use cons_to_unsigned.
351 (x_fill_property_data): Use cons_to_signed.
352 Report values out of range.
353
354 Check for buffer and string overflow more precisely.
355 * buffer.h (BUF_BYTES_MAX): New macro.
356 * lisp.h (STRING_BYTES_MAX): New macro.
357 * alloc.c (Fmake_string):
358 * character.c (string_escape_byte8):
359 * coding.c (coding_alloc_by_realloc):
360 * doprnt.c (doprnt):
361 * editfns.c (Fformat):
362 * eval.c (verror):
363 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
364 since they may not be the same number.
365 * editfns.c (Finsert_char):
366 * fileio.c (Finsert_file_contents):
367 Likewise for BUF_BYTES_MAX.
368
369 * image.c: Use ptrdiff_t, not int, for sizes.
370 (slurp_file): Switch from int to ptrdiff_t.
371 All uses changed.
372 (slurp_file): Check that file size fits in both size_t (for
373 malloc) and ptrdiff_t (for sanity and safety).
374
375 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
376 if b->modtime has its maximal value.
377
378 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
379
380 Don't assume time_t can fit into int.
381 * buffer.h (struct buffer.modtime): Now time_t, not int.
382 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
383 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
384
385 Minor fixes for signed vs unsigned integers.
386 * character.h (MAYBE_UNIFY_CHAR):
387 * charset.c (maybe_unify_char):
388 * keyboard.c (read_char, reorder_modifiers):
389 XINT -> XFASTINT, since the integer must be nonnegative.
390 * ftfont.c (ftfont_spec_pattern):
391 * keymap.c (access_keymap, silly_event_symbol_error):
392 XUINT -> XFASTINT, since the integer must be nonnegative.
393 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
394 since it makes no difference and we prefer signed.
395 * keyboard.c (record_char): Use XUINT when all the neighbors do.
396 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
397 nonnegative.
398
399 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
400
401 * window.h (Fwindow_frame): Declare.
402
403 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
404
405 * alloc.c: Simplify handling of large-request failures (Bug#8800).
406 (SPARE_MEMORY): Always define.
407 (LARGE_REQUEST): Remove.
408 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
409
410 2011-06-06 Martin Rudalics <rudalics@gmx.at>
411
412 * lisp.h: Move EXFUNS for Fframe_root_window,
413 Fframe_first_window and Fset_frame_selected_window to window.h.
414
415 * window.h: Move EXFUNS for Fframe_root_window,
416 Fframe_first_window and Fset_frame_selected_window here from
417 lisp.h.
418
419 * frame.c (Fwindow_frame, Fframe_first_window)
420 (Fframe_root_window, Fframe_selected_window)
421 (Fset_frame_selected_window): Move to window.c.
422 (Factive_minibuffer_window): Move to minibuf.c.
423 (Fother_visible_frames_p): New function.
424
425 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
426
427 * window.c (decode_window, decode_any_window): Move up in code.
428 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
429 (inhibit_frame_unsplittable): Remove unused variable.
430 (Fwindow_buffer): Move up and rewrite doc-string.
431 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
432 (Fwindow_prev): New functions.
433 (Fwindow_frame): Move here from frame.c. Accept any window as
434 argument.
435 (Fframe_root_window, Fframe_first_window)
436 (Fframe_selected_window): Move here from frame.c. Accept frame
437 or arbitrary window as argument. Update doc-strings.
438 (Fminibuffer_window): Move up in code.
439 (Fwindow_minibuffer_p): Move up in code and simplify.
440 (Fset_frame_selected_window): Move here from frame.c.
441 Marginal rewrite.
442 (Fselected_window, select_window, Fselect_window): Move up in
443 code. Minor doc-string fixes.
444
445 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
446
447 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
448 Do not assume that spare memory exists; that assumption is valid
449 only if SYSTEM_MALLOC.
450 (LARGE_REQUEST): New macro, so that the issue of large requests
451 is separated from the issue of spare memory.
452
453 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
454
455 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
456 format. (Bug#8806)
457
458 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
459
460 * xfns.c (x_set_scroll_bar_default_width): Move declarations
461 before statements.
462
463 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
464
465 * gtkutil.c (xg_get_default_scrollbar_width): New function.
466
467 * gtkutil.h: Declare xg_get_default_scrollbar_width.
468
469 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
470 min width by calling x_set_scroll_bar_default_width (Bug#8505).
471
472 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
473
474 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
475
476 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
477
478 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
479 (x_clipboard_manager_save): Add return value.
480 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
481 New error handlers.
482 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
483 Obey Vx_select_enable_clipboard_manager. Catch errors in
484 x_clipboard_manager_save (Bug#8779).
485 (Vx_select_enable_clipboard_manager): New variable.
486 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
487
488 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
489
490 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
491
492 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
493
494 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
495 in the current matrix if keep_current_p is non-zero.
496
497 2011-06-04 Eli Zaretskii <eliz@gnu.org>
498
499 * bidi.c (bidi_level_of_next_char): Fix last change.
500
501 2011-06-03 Eli Zaretskii <eliz@gnu.org>
502
503 Support bidi reordering of text covered by display properties.
504
505 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
506 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
507 (bidi_cache_search, bidi_cache_iterator_state)
508 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
509 (bidi_level_of_next_char, bidi_move_to_visually_next):
510 Support character positions inside a run of characters covered by a
511 display string.
512 (bidi_paragraph_init, bidi_resolve_explicit_1)
513 (bidi_level_of_next_char): Call bidi_fetch_char and
514 bidi_fetch_char_advance instead of FETCH_CHAR and
515 FETCH_CHAR_ADVANCE.
516 (bidi_init_it): Initialize new members.
517 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
518 definitions.
519 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
520 instead of using explicit *_CHAR codes.
521 (bidi_resolve_explicit, bidi_resolve_weak):
522 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
523 bidirectional text is supported only in multibyte buffers.
524 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
525 it to initialize the frame_window_p member of struct bidi_it.
526 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
527 (bidi_resolve_explicit, bidi_resolve_weak)
528 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
529 bidi_it->nchars is non-positive.
530 (bidi_level_of_next_char): Don't try to lookup the cache for the
531 next/previous character if nothing is cached there yet, or if we
532 were just reseat()'ed to a new position.
533
534 * xdisp.c (set_cursor_from_row): Set start and stop points
535 according to the row's direction when priming the loop that looks
536 for the glyph on which to display cursor.
537 (single_display_spec_intangible_p): Function deleted.
538 (display_prop_intangible_p): Reimplement to call
539 handle_display_spec instead of single_display_spec_intangible_p.
540 Accept 3 additional arguments needed by handle_display_spec.
541 This fixes incorrect cursor motion across display property with complex
542 values: lists, `(when COND...)' forms, etc.
543 (single_display_spec_string_p): Support property values that are
544 lists with the argument STRING its top-level element.
545 (display_prop_string_p): Fix the condition for processing a
546 property that is a list to be consistent with handle_display_spec.
547 (handle_display_spec): New function, refactored from the
548 last portion of handle_display_prop.
549 (compute_display_string_pos): Accept additional argument
550 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
551 value of a `display' property is a "replacing spec".
552 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
553 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
554 the display property, but just return a value indicating whether
555 the display property will replace the characters it covers.
556 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
557 frame_window_p members of struct bidi_it.
558 (compute_display_string_pos, compute_display_string_end):
559 New functions.
560 (push_it): Accept second argument POSITION, where pop_it should
561 jump to continue iteration.
562 (reseat_1): Initialize bidi_it.disp_pos.
563
564 * keyboard.c (adjust_point_for_property): Adjust the call to
565 display_prop_intangible_p to its new signature.
566
567 * dispextern.h (struct bidi_it): New member frame_window_p.
568 (bidi_init_it): Update prototypes.
569 (display_prop_intangible_p): Update prototype.
570 (compute_display_string_pos, compute_display_string_end):
571 Declare prototypes.
572 (struct bidi_it): New members nchars and disp_pos. ch_len is now
573 EMACS_INT.
574
575 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
576
577 Malloc failure behavior now depends on size of allocation.
578 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
579 * lisp.h: Change signatures accordingly.
580 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
581 All callers changed. (Bug#8762)
582
583 * gnutls.c: Use Emacs's memory allocators.
584 Without this change, the gnutls library would invoke malloc etc.
585 directly, which causes problems on non-SYNC_INPUT hosts, and which
586 runs afoul of improving memory_full behavior. (Bug#8761)
587 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
588 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
589 xfree instead of the default malloc, realloc, free.
590 (Fgnutls_boot): No need to check for memory allocation failure,
591 since xmalloc does that for us.
592
593 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
594 * category.c (hash_get_category_set):
595 * ccl.c (ccl_driver):
596 * charset.c (Fdefine_charset_internal):
597 * charset.h (struct charset.hash_index):
598 * composite.c (get_composition_id, gstring_lookup_cache)
599 (composition_gstring_put_cache):
600 * composite.h (struct composition.hash_index):
601 * dispextern.h (struct image.hash):
602 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
603 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
604 (hashfn_equal, hashfn_user_defined, make_hash_table)
605 (maybe_resize_hash_table, hash_lookup, hash_put)
606 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
607 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
608 (Fsxhash, Fgethash, Fputhash, Fmaphash):
609 * image.c (make_image, search_image_cache, lookup_image)
610 (xpm_put_color_table_h):
611 * lisp.h (struct Lisp_Hash_Table):
612 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
613 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
614 for hashes and hash indexes, instead of 'unsigned' and 'int'.
615 * alloc.c (allocate_vectorlike):
616 Check for overflow in vector size calculations.
617 * ccl.c (ccl_driver):
618 Check for overflow when converting EMACS_INT to int.
619 * fns.c, image.c: Remove unnecessary static decls that would otherwise
620 need to be updated by these changes.
621 * fns.c (make_hash_table, maybe_resize_hash_table):
622 Check for integer overflow with large hash tables.
623 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
624 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
625 (SXHASH_REDUCE): New macro.
626 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
627 Use it instead of discarding useful hash info with large hash values.
628 (sxhash_float): New function.
629 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
630 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
631 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
632 Rewrite to use FIXNUM_BITS, as this simplifies things.
633 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
634 Adjust signatures to match updated version of code.
635 (consing_since_gc): Now EMACS_INT, since a single hash table can
636 use more than INT_MAX bytes.
637
638 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
639
640 Make it possible to build with GCC-4.6+ -O2 -flto.
641
642 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
643
644 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
645
646 * minibuf.c (get_minibuffer, read_minibuf_unwind):
647 Call minibuffer-inactive-mode.
648
649 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
650
651 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
652 Update dependencies.
653
654 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
655
656 * data.c (init_data): Remove code for UTS, this system is not
657 supported anymore.
658
659 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
660
661 Don't force ./temacs to start in terminal mode.
662
663 * frame.c (make_initial_frame): Initialize faces in all cases, not
664 only when CANNOT_DUMP is defined.
665 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
666
667 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
668
669 * dispnew.c (add_window_display_history): Use const for the string
670 pointer. Remove declaration, not needed.
671
672 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
673
674 Use 'inline', not 'INLINE'.
675 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
676 * alloc.c, fontset.c (INLINE): Remove.
677 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
678 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
679 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
680 * gmalloc.c (register_heapinfo): Use inline unconditionally.
681 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
682
683 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
684
685 Make it possible to run ./temacs.
686
687 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
688 syms_of_callproc does the same thing. Remove test for
689 "initialized", do it in the caller.
690 * emacs.c (main): Avoid calling set_initial_environment when dumping.
691
692 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
693
694 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
695 (read_minibuf): Use get_minibuffer.
696 (syms_of_minibuf): Use DEFSYM.
697 (Qmetadata): New var.
698 * data.c (Qbuffer): Don't make it static.
699 (syms_of_data): Use DEFSYM.
700
701 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
702
703 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
704 (CCL_CODE_MIN): New macro.
705
706 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
707
708 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
709
710 * eval.c (Qdebug): Now static.
711 * lisp.h (Qdebug): Remove decl. This reverts a part of the
712 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
713 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
714
715 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
716
717 * image.c: Various fixes to ImageMagick code comments.
718 (Fimagemagick_types): Doc fix.
719
720 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
721
722 Minor fixes prompted by GCC 4.6.0 warnings.
723
724 * xselect.c (converted_selections, conversion_fail_tag): Now static.
725
726 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
727 (x_clipboard_manager_save_all): Move extern decl to ...
728 * xterm.h: ... here, so that it can be checked for consistency.
729
730 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
731
732 * xselect.c (x_clipboard_manager_save_frame)
733 (x_clipboard_manager_save_all): New functions.
734 (Fx_clipboard_manager_save): Lisp function deleted.
735
736 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
737 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
738
739 * xterm.h: Update prototype.
740
741 2011-05-28 William Xu <william.xwl@gmail.com>
742
743 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
744 exiting (Bug#8239).
745
746 2011-05-28 Jim Meyering <meyering@redhat.com>
747
748 Avoid a sign-extension bug in crypto_hash_function.
749 * fns.c (to_uchar): Define.
750 (crypto_hash_function): Use it to convert some newly-signed
751 variables to unsigned, to avoid sign-extension bugs. For example,
752 without this change, (md5 "truc") would evaluate to
753 45723a2aff78ff4fff7fff1114760e62 rather than the expected
754 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
755 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
756
757 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
758
759 Integer overflow fixes.
760
761 * dbusbind.c: Serial number integer overflow fixes.
762 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
763 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
764 to hold a serial number that is too large for a fixnum.
765 (Fdbus_method_return_internal, Fdbus_method_error_internal):
766 Check for serial numbers out of range. Decode any serial number
767 that was so large that it became a float. (Bug#8722)
768
769 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
770 (Fdbus_call_method, Fdbus_call_method_asynchronously):
771 Use XFASTINT rather than XUINT when numbers are nonnegative.
772 (xd_append_arg, Fdbus_method_return_internal):
773 (Fdbus_method_error_internal): Likewise. Also, for unsigned
774 arguments, check that Lisp number is nonnegative, rather than
775 silently wrapping negative numbers around. (Bug#8722)
776 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
777 (Bug#8722)
778
779 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
780
781 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
782
783 ccl: add integer overflow checks
784 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
785 (IN_INT_RANGE): New macros.
786 (ccl_driver): Use them to check for integer overflow when
787 decoding a CCL program. Many of the new checks are whether XINT (x)
788 fits in int; it doesn't always, on 64-bit hosts. The new version
789 doesn't catch all possible integer overflows, but it's an
790 improvement. (Bug#8719)
791
792 * alloc.c (make_event_array): Use XINT, not XUINT.
793 There's no need for unsigned here.
794
795 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
796 This follows up to the 2011-05-06 change that substituted uintptr_t
797 for EMACS_INT. This case wasn't caught back then.
798
799 Rework Fformat to avoid integer overflow issues.
800 * editfns.c: Include <float.h> unconditionally, as it's everywhere
801 now (part of C89). Include <verify.h>.
802 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
803 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
804 (Fformat): Avoid the prepass trying to compute sizes; it was only
805 approximate and thus did not catch overflow reliably. Instead, walk
806 through the format just once, formatting and computing sizes as we go,
807 checking for integer overflow at every step, and allocating a larger
808 buffer as needed. Keep track separately whether the format is
809 multibyte. Keep only the most-recently calculated precision, rather
810 than them all. Record whether each argument has been converted to
811 string. Use EMACS_INT, not int, for byte and char and arg counts.
812 Support field widths and precisions larger than INT_MAX. Avoid
813 sprintf's undefined behavior with conversion specifications such as %#d
814 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
815 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
816 formatting out-of-range floating point numbers with int
817 formats. (Bug#8668)
818
819 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
820
821 * data.c: Avoid integer truncation in expressions involving floats.
822 * data.c: Include <intprops.h>.
823 (arith_driver): When there's an integer overflow in an expression
824 involving floating point, convert the integers to floating point
825 so that the resulting value does not suffer from catastrophic
826 integer truncation. For example, on a 64-bit host (* 4
827 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
828 Do not rely on undefined behavior after integer overflow.
829
830 merge count_size_as_multibyte, parse_str_to_multibyte
831 * character.c, character.h (count_size_as_multibyte):
832 Rename from parse_str_to_multibyte; all uses changed.
833 Check for integer overflow.
834 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
835 since it's now a duplicate of the other. This is more of
836 a character than a buffer op, so better that it's in character.c.
837 * fns.c, print.c: Adjust to above changes.
838
839 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
840
841 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
842
843 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
844
845 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
846 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
847 (x_clipboard_manager_save): Now static.
848 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
849
850 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
851 (crypto_hash_function): Now static.
852 Fix pointer signedness problems. Avoid unnecessary initializations.
853
854 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
855
856 * termhooks.h (Vselection_alist): Make it terminal-local.
857
858 * terminal.c (create_terminal): Initialize it.
859
860 * xselect.c: Support for clipboard managers.
861 (Vselection_alist): Move to termhooks.h as terminal-local var.
862 (LOCAL_SELECTION): New macro.
863 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
864 (symbol_to_x_atom): Remove gratuitous arg.
865 (x_handle_selection_request, lisp_data_to_selection_data)
866 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
867 (x_own_selection, x_get_local_selection, x_convert_selection):
868 New arg, specifying work frame. Use terminal-local Vselection_alist.
869 (some_frame_on_display): Delete unused function.
870 (Fx_own_selection_internal, Fx_get_selection_internal)
871 (Fx_disown_selection_internal, Fx_selection_owner_p)
872 (Fx_selection_exists_p): New optional frame arg.
873 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
874 (x_handle_selection_clear): Don't treat other terminals with the
875 same keyboard specially. Use the terminal-local Vselection_alist.
876 (x_clear_frame_selections): Use Frun_hook_with_args.
877
878 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
879
880 * xterm.h: Add support for those atoms.
881
882 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
883
884 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
885 (converted_selections, conversion_fail_tag): New global variables.
886 (x_selection_request_lisp_error): Free the above.
887 (x_get_local_selection): Remove unnecessary code.
888 (x_reply_selection_request): Args changed; handle arbitrary array
889 of converted selections stored in converted_selections.
890 Separate the XChangeProperty and SelectionNotify steps.
891 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
892 (x_convert_selection): New function.
893 (x_handle_selection_event): Simplify.
894 (x_get_foreign_selection): Don't ignore incoming requests while
895 waiting for an answer; this will fail when we implement
896 SAVE_TARGETS, and seems unnecessary anyway.
897 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
898 (Vx_sent_selection_functions): Doc fix.
899
900 2011-05-26 Leo Liu <sdl.web@gmail.com>
901
902 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
903
904 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
905
906 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
907
908 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
909 for fringe update if it has periodic bitmap.
910 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
911 and fringe_bitmap_periodic_p.
912
913 * fringe.c (get_fringe_bitmap_data): New function.
914 (draw_fringe_bitmap_1, update_window_fringes): Use it.
915 (update_window_fringes): Record periodicity of fringe bitmap in glyph
916 row. Mark glyph row for fringe update if periodicity changed.
917
918 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
919 for fringe update unless it has periodic bitmap.
920
921 2011-05-25 Kenichi Handa <handa@m17n.org>
922
923 * xdisp.c (get_next_display_element): Set correct it->face_id for
924 a static composition.
925
926 2011-05-24 Leo Liu <sdl.web@gmail.com>
927
928 * deps.mk (fns.o):
929 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
930
931 * fns.c (crypto_hash_function, Fsha1): New function.
932 (Fmd5): Use crypto_hash_function.
933 (syms_of_fns): Add Ssha1.
934
935 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
936
937 * gnutls.c: Remove unused macros.
938 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
939 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
940 Remove macros that are defined and never used.
941 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
942
943 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
944
945 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
946 (Fx_get_selection_internal): Minor cleanup.
947 (Fx_own_selection_internal): Rename arguments for consistency with
948 select.el.
949
950 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
951
952 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
953
954 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
955
956 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
957
958 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
959
960 * dispnew.c (scrolling_window): Don't exclude the case that the
961 last enabled row in the desired matrix touches the bottom boundary.
962
963 2011-05-21 Glenn Morris <rgm@gnu.org>
964
965 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
966 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
967 and add some more files.
968
969 2011-05-20 Eli Zaretskii <eliz@gnu.org>
970
971 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
972 report_file_error introduced by the change from 2011-05-07.
973
974 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
975
976 * systime.h (Time): Define only if emacs is defined.
977 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
978 where the include path doesn't have X11/X.h by default. See
979 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
980
981 2011-05-20 Kenichi Handa <handa@m17n.org>
982
983 * composite.c (find_automatic_composition): Fix previous change.
984
985 2011-05-20 Glenn Morris <rgm@gnu.org>
986
987 * lisp.mk: New file, split from Makefile.in.
988 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
989 (shortlisp): Remove.
990 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
991
992 2011-05-19 Glenn Morris <rgm@gnu.org>
993
994 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
995 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
996 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
997 (lisp): Set the order to that of loadup.el.
998 (shortlisp): Make it a copy of $lisp.
999 (SOME_MACHINE_LISP): Remove.
1000 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1001 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1002
1003 2011-05-18 Kenichi Handa <handa@m17n.org>
1004
1005 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1006 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1007 (find_automatic_composition): Mostly rewrite for efficiency.
1008
1009 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1010
1011 * makefile.w32-in: Update dependencies.
1012
1013 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1014
1015 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1016 revision 104625).
1017
1018 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1019
1020 Fix some integer overflow issues, such as string length overflow.
1021
1022 * insdel.c (count_size_as_multibyte): Check for string overflow.
1023
1024 * character.c (lisp_string_width): Check for string overflow.
1025 Use EMACS_INT, not int, for string indexes and lengths; in
1026 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1027 the resulting string length overflows an EMACS_INT; instead,
1028 report a string overflow if no precision given. When checking for
1029 precision exhaustion, use a check that cannot possibly have
1030 integer overflow. (Bug#8675)
1031 * character.h (lisp_string_width): Adjust to new signature.
1032
1033 * alloc.c (string_overflow): New function.
1034 (Fmake_string): Use it. This doesn't change behavior, but saves
1035 a few bytes and will simplify future changes.
1036 * character.c (string_escape_byte8): Likewise.
1037 * lisp.h (string_overflow): New decl.
1038
1039 Fixups, following up to the user-interface timestamp change.
1040 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1041 for UI timestamps, instead of unsigned long.
1042 * msdos.c (mouse_get_pos): Likewise.
1043 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1044 * w32gui.h (Time): Define by including "systime.h" rather than by
1045 declaring it ourselves. (Bug#8664)
1046
1047 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1048 * image.c (clear_image_cache): Likewise.
1049
1050 * term.c (term_mouse_position): Don't assume time_t wraparound.
1051
1052 Be more systematic about user-interface timestamps.
1053 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1054 and sometimes 'EMACS_UINT', to represent these timestamps.
1055 This change causes it to use 'Time' uniformly, as that's what X uses.
1056 This makes the code easier to follow, and makes it easier to catch
1057 integer overflow bugs such as Bug#8664.
1058 * frame.c (Fmouse_position, Fmouse_pixel_position):
1059 Use Time, not unsigned long, for user-interface timestamps.
1060 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1061 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1062 * keyboard.h (last_event_timestamp): Likewise.
1063 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1064 * menu.h (xmenu_show): Likewise.
1065 * term.c (term_mouse_position): Likewise.
1066 * termhooks.h (struct input_event.timestamp): Likewise.
1067 (struct terminal.mouse_position_hook): Likewise.
1068 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1069 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1070 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1071 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1072 what it was before.
1073 * menu.h, termhooks.h: Include "systime.h", for Time.
1074
1075 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1076 Don't assume that the difference between two unsigned long values
1077 can fit into an integer. At this point, we know button_down_time
1078 <= event->timestamp, so the difference must be nonnegative, so
1079 there's no need to cast the result if double-click-time is
1080 nonnegative, as it should be; check that it's nonnegative, just in
1081 case. This bug is triggered when events are more than 2**31 ms
1082 apart (about 25 days). (Bug#8664)
1083
1084 * xselect.c (last_event_timestamp): Remove duplicate decl.
1085 (x_own_selection): Remove needless cast to unsigned long.
1086
1087 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1088 that always fit in int. Use a sentinel instead of a counter, to
1089 avoid a temp and to allay GCC's concerns about possible int overflow.
1090 * frame.h (struct frame): Use int for menu_bar_items_used
1091 instead of EMACS_INT, since it always fits in int.
1092
1093 * menu.c (grow_menu_items): Check for int overflow.
1094
1095 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1096
1097 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1098 Before, the code was not consistent. These values cannot exceed
1099 2**31 - 1 so there's no need to make them unsigned.
1100 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1101 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1102 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1103 as modifiers.
1104 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1105
1106 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1107 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1108 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1109 presumably because the widths might not match.
1110
1111 * window.c (size_window): Avoid needless test at loop start.
1112
1113 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1114
1115 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1116
1117 2011-05-12 Drew Adams <drew.adams@oracle.com>
1118
1119 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1120
1121 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1122
1123 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1124 `width' to `bar_area_x' and `bar_area_width', respectively.
1125 (x_scroll_run): Take account of fringe background extension.
1126
1127 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1128 Rename local vars `left' and `width' to `bar_area_x' and
1129 `bar_area_width', respectively.
1130 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1131 background extension.
1132
1133 2011-05-10 Jim Meyering <meyering@redhat.com>
1134
1135 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1136
1137 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1138
1139 * image.c (Finit_image_library): Return t for built-in image types,
1140 like pbm and xbm. (Bug#8640)
1141
1142 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1143
1144 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1145
1146 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1147
1148 * w32console.c (Fset_screen_color): Doc fix.
1149 (Fget_screen_color): New function.
1150 (syms_of_ntterm): Defsubr it.
1151
1152 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1153 unlink the temporary file if Fcall_process didn't create it in the
1154 first place.
1155 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1156 child process will be redirected to a file specified with `:file'.
1157 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1158 cue to call_process_cleanup not to close that handle.
1159
1160 2011-05-07 Ben Key <bkey76@gmail.com>
1161
1162 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1163 one of two shell specific rules, either bootstrap-temacs-CMD or
1164 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1165 to the previous implementation of the bootstrap-temacs rule.
1166 The bootstrap-temacs-CMD rule is similar to the previous
1167 implementation of the bootstrap-temacs rule except that it
1168 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1169 variable.
1170
1171 These changes, along with some changes to nt/configure.bat,
1172 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1173 earlier fix to add support for --cflags and --ldflags options
1174 that include quotes so that it works whether make uses cmd or
1175 sh as the shell.
1176
1177 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1178
1179 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1180 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1181 is a constant.
1182 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1183 a string. Handle both cases.
1184 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1185 (Fdbus_register_method): Use Qinvalid_function.
1186
1187 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1188
1189 * makefile.w32-in: Update dependencies.
1190 (LISP_H): Add inttypes.h and stdin.h.
1191 (PROCESS_H): Add unistd.h.
1192
1193 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1194
1195 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1196 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1197
1198 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1201
1202 * term.c (vfatal): Remove stray call to va_end.
1203 It's not needed and the C Standard doesn't allow it here anyway.
1204
1205 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1206 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1207
1208 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1209 bytes.
1210
1211 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1212
1213 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1214
1215 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1216
1217 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1218
1219 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1220
1221 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1222 * charset.c (Fdefine_charset_internal): Don't initialize
1223 charset.code_space[15]. The value was garbage, on hosts with
1224 32-bit int (Bug#8600).
1225
1226 * lread.c (read_integer): Be more consistent with string-to-number.
1227 Use string_to_number to do the actual conversion; this avoids
1228 rounding errors and fixes some other screwups. Without this fix,
1229 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1230 (digit_to_number): Move earlier, for benefit of read_integer.
1231 Return -1 if the digit is out of range for the base, -2 if it is
1232 not a digit in any supported base. (Bug#8602)
1233
1234 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1235
1236 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1237 to match comment at start of function. This also removes a
1238 GCC warning about overflow in a 32+64-bit port.
1239
1240 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1241
1242 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1243 Reported by Stefan Monnier in
1244 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1245 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1246 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1247
1248 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1249 (EMACS_UINTPTR): Likewise, with uintptr_t.
1250
1251 * lisp.h: Prefer 64-bit EMACS_INT if available.
1252 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1253 on 32-bit hosts that have 64-bit int, so that they can access
1254 large files.
1255 However, temporarily disable this change unless the temporary
1256 symbol WIDE_EMACS_INT is defined.
1257
1258 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1259
1260 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1261 This removes an assumption that EMACS_INT and long are the same
1262 width as pointers. The assumption is true for Emacs porting targets
1263 now, but we want to make other targets possible.
1264 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1265 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1266 In the rest of the code, change types of integers that hold casted
1267 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1268 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1269 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1270 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1271 No need to cast type when ORing.
1272 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1273 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1274 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1275 assume EMACS_INT is the same width as char *.
1276 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1277 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1278 Remove no-longer-needed casts.
1279 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1280 (xg_tool_bar_help_callback, xg_make_tool_item):
1281 Use EMACS_INTPTR to hold an integer
1282 that will be cast to void *; this can avoid a GCC warning
1283 if EMACS_INT is not the same width as void *.
1284 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1285 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1286 (current_message_1, set_message_1):
1287 Use a local to convert to proper width without a cast.
1288 * xmenu.c (dialog_selection_callback): Likewise.
1289
1290 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1291 Also, don't assume VALBITS / RAND_BITS is less than 5,
1292 and don't rely on undefined behavior when shifting a 1 left into
1293 the sign bit.
1294 * lisp.h (get_random): Change signature to match.
1295
1296 * lread.c (hash_string): Use size_t, not int, for hash computation.
1297 Normally we prefer signed values; but hashing is special, because
1298 it's better to use unsigned division on hash table sizes so that
1299 the remainder is nonnegative. Also, size_t is the natural width
1300 for hashing into memory. The previous code used 'int', which doesn't
1301 retain enough info to hash well into very large tables.
1302 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1303
1304 * dbusbind.c: Don't possibly lose pointer info when converting.
1305 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1306 Use XPNTR rather than XHASH, so that the high-order bits of
1307 the pointer aren't lost when converting through void *.
1308
1309 * eval.c (Fautoload): Don't double-shift a pointer.
1310
1311 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1312
1313 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1314
1315 * gnutls.c (DEF_GNUTLS_FN):
1316 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1317
1318 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1319
1320 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1321 marker. (Bug#8610)
1322
1323 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1324
1325 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1326 New version that can reserve upto 2GB of heap space.
1327
1328 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1329
1330 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1331
1332 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1333
1334 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1335 `gnutls_certificate_set_x509_key_file'.
1336
1337 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1338
1339 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1340 Update dependencies.
1341
1342 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1343
1344 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1345 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1346 Remove unused parameter `fildes'.
1347 * process.c (read_process_output, send_process): Don't pass it.
1348
1349 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1350
1351 Fix previous change: the library cache is defined in w32.c.
1352 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1353 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1354
1355 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1356
1357 Implement dynamic loading of GnuTLS on Windows.
1358
1359 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1360 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1361 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1362 Declare.
1363
1364 * gnutls.c (Qgnutls_dll): Define.
1365 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1366 (gnutls_*): Declare function pointers.
1367 (init_gnutls_functions): New function to initialize function pointers.
1368 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1369 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1370 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1371 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1372 (emacs_gnutls_write, emacs_gnutls_read)
1373 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1374 (Fgnutls_available_p): New function.
1375 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1376 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1377 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1378
1379 * image.c: Include w32.h.
1380 (Vimage_type_cache): Delete.
1381 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1382 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1383 (w32_delayed_load): Move to w32.c.
1384
1385 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1386
1387 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1388 (w32_delayed_load): Move from image.c. When loading a library, record
1389 its filename in the :loaded-from property of the library id.
1390 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1391 Initialize and staticpro them.
1392 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1393
1394 * process.c: Include lisp.h before w32.h, not after.
1395 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1396 instead of gnutls_record_check_pending.
1397
1398 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1399
1400 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1401
1402 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1403 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1404 as passed in.
1405
1406 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1407
1408 * xterm.c (x_set_frame_alpha): Do not set property on anything
1409 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1410
1411 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1412
1413 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1414
1415 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1416
1417 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1418 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1419 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1420 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1421 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1422 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1423 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1424 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1425 (Qgnutls_bootprop_callbacks_verify): Make static.
1426
1427 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1428
1429 * callproc.c: Indentation fixup.
1430
1431 * sysdep.c (wait_for_termination_1): Make static.
1432 (wait_for_termination, interruptible_wait_for_termination):
1433 Move after wait_for_termination_1.
1434
1435 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1436
1437 * sysdep.c (interruptible_wait_for_termination): New function
1438 which is like wait_for_termination, but allows keyboard
1439 interruptions.
1440
1441 * callproc.c (Fcall_process): Add (:file "file") as an option for
1442 the STDOUT buffer.
1443 (Fcall_process_region): Ditto.
1444
1445 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1446
1447 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1448 rather than `XVECTOR (FOO)->size'.
1449
1450 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1451 inttypes.h, as a gnulib replacement is used if it not available in
1452 system headers.
1453
1454 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1455
1456 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1457 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1458 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1459
1460 * coding.c (coding_alloc_by_realloc): Error out if destination
1461 will grow beyond MOST_POSITIVE_FIXNUM.
1462 (decode_coding_emacs_mule): Abort if there isn't enough place in
1463 charbuf for the composition carryover bytes. Reserve an extra
1464 space for up to 2 characters produced in a loop.
1465 (decode_coding_iso_2022): Abort if there isn't enough place in
1466 charbuf for the composition carryover bytes.
1467
1468 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1469
1470 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1471 aborting when %lld or %lll format is passed.
1472 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1473 %llo or %llx format is passed. (Bug#8545)
1474
1475 * window.c (window_scroll_line_based): Use a marker instead of
1476 simple variables to record original value of point. (Bug#7952)
1477
1478 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1479 produced by %s or %c overflows available buffer space. (Bug#8545)
1480
1481 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1484 (SIZE_MAX): Move defn after all includes, as they might #define it.
1485
1486 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1487
1488 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1489
1490 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1491
1492 * keyboard.c (Qdelayed_warnings_hook): Define.
1493 (command_loop_1): Run `delayed-warnings-hook'
1494 if Vdelayed_warnings_list is non-nil.
1495 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1496 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1497
1498 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1499
1500 * doprnt.c (doprnt): Don't return value smaller than the buffer
1501 size if the message was truncated. (Bug#8545).
1502
1503 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1504
1505 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1506 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1507
1508 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1509
1510 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1511
1512 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1513
1514 * makefile.w32-in: Update dependencies.
1515
1516 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1517
1518 Improve `doprnt' and its usage. (Bug#8545)
1519 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1520 `format_end'. Remove support for %l as a conversion specifier.
1521 Don't use xrealloc. Improve diagnostics when the %l size modifier
1522 is used. Update the commentary.
1523
1524 * eval.c (verror): Simplify calculation of size_t.
1525
1526 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1527 messages.
1528
1529 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1530
1531 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1532 change.
1533
1534 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1537 This makes this file independent of the recent pseudovector change.
1538
1539 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1540
1541 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1542
1543 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1544 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1545 Remove unused local.
1546 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1547
1548 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1549 GCC 4.6.0 optimizes based on type-based alias analysis.
1550 For example, if b is of type struct buffer * and v of type struct
1551 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1552 != &v->size, and therefore "v->size = 1; b->size = 2; return
1553 v->size;" must therefore return 1. This assumption is incorrect
1554 for Emacs, since it type-puns struct Lisp_Vector * with many other
1555 types. To fix this problem, this patch adds a new type struct
1556 vectorlike_header that documents the constraints on layout of vectors
1557 and pseudovectors, and helps optimizing compilers not get fooled
1558 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1559 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1560 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1561 the size member.
1562 (XSETPVECTYPE): Rewrite in terms of new macro.
1563 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1564 This is a bit clearer, and further avoids the possibility of
1565 undesirable aliasing.
1566 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1567 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1568 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1569 since Lisp_Subr is a special case (no "next" field).
1570 (ASIZE): Now uses header.size rather than size.
1571 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1572 to avoid the hassle of writing XVECTOR (foo)->header.size.
1573 (struct vectorlike_header): New type.
1574 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1575 object, to help avoid aliasing.
1576 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1577 (SUBRP): Likewise, since Lisp_Subr is a special case.
1578 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1579 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1580 (struct Lisp_Hash_Table): Combine first two members into a single
1581 struct vectorlike_header member. All uses of "size" and "next" members
1582 changed to be "header.size" and "header.next".
1583 * buffer.h (struct buffer): Likewise.
1584 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1585 * frame.h (struct frame): Likewise.
1586 * process.h (struct Lisp_Process): Likewise.
1587 * termhooks.h (struct terminal): Likewise.
1588 * window.c (struct save_window_data, struct saved_window): Likewise.
1589 * window.h (struct window): Likewise.
1590 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1591 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1592 * buffer.c (init_buffer_once): Likewise.
1593 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1594 special case.
1595 * process.c (Fformat_network_address): Use local var for size,
1596 for brevity.
1597
1598 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1599
1600 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1601 * data.c (atof): Remove decl; no longer used or needed.
1602 (digit_to_number): Move to lread.c.
1603 (Fstring_to_number): Use new string_to_number function, to be
1604 consistent with how the Lisp reader treats infinities and NaNs.
1605 Do not assume that floating-point numbers represent EMACS_INT
1606 without losing information; this is not true on most 64-bit hosts.
1607 Avoid double-rounding errors, by insisting on integers when
1608 parsing non-base-10 numbers, as the documentation specifies.
1609 * lisp.h (string_to_number): New decl, replacing ...
1610 (isfloat_string): Remove.
1611 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1612 (read1): Do not accept +. and -. as integers; this
1613 appears to have been a coding error. Similarly, do not accept
1614 strings like +-1e0 as floating point numbers. Do not report
1615 overflow for integer overflows unless the base is not 10 which
1616 means we have no simple and reliable way to continue.
1617 Break out the floating-point parsing into a new
1618 function string_to_number, so that Fstring_to_number parses
1619 floating point numbers consistently with the Lisp reader.
1620 (digit_to_number): Move here from data.c. Make it static inline.
1621 (E_CHAR, EXP_INT): Remove, replacing with ...
1622 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1623 (string_to_number): New function, replacing isfloat_string.
1624 This function checks for valid syntax and produces the resulting
1625 Lisp float number too. Rework it so that string-to-number
1626 no longer mishandles examples like "1.0e+". Use strtoumax,
1627 so that overflow for non-base-10 numbers is reported only when
1628 there's no portable and simple way to convert to floating point.
1629
1630 * textprop.c (set_text_properties_1): Rewrite for clarity,
1631 and to avoid GCC warning about integer overflow.
1632
1633 * intervals.h (struct interval): Use EMACS_INT for members
1634 where EMACS_UINT might cause problems. See
1635 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1636 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1637 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1638 All uses changed.
1639 (offset_intervals): Tell GCC not to worry about length overflow
1640 when negating a negative length.
1641
1642 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1643 (overrun_check_free): Likewise.
1644
1645 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1646 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1647 word size.
1648
1649 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1650 (gnutls_make_error): Rename local to avoid shadowing.
1651 (gnutls_emacs_global_deinit): ifdef out; not used.
1652 (Fgnutls_boot): Use const for pointer to readonly storage.
1653 Comment out unused local. Fix pointer signedness problems.
1654
1655 * lread.c (openp): Don't stuff size_t into an 'int'.
1656 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1657 about possible signed overflow.
1658
1659 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1660 (GDK_KEY_g): Don't define if already defined.
1661 (xg_prepare_tooltip): Avoid pointer signedness problem.
1662 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1663
1664 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1665 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1666
1667 * xfns.c (Fx_window_property): Simplify a bit,
1668 to make a bit faster and to avoid GCC 4.6.0 warning.
1669 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1670
1671 * fns.c (internal_equal): Don't assume size_t fits in int.
1672
1673 * alloc.c (compact_small_strings): Tighten assertion a little.
1674
1675 Replace pEd with more-general pI, and fix some printf arg casts.
1676 * lisp.h (pI): New macro, generalizing old pEd macro to other
1677 conversion specifiers. For example, use "...%"pI"d..." rather
1678 than "...%"pEd"...".
1679 (pEd): Remove. All uses replaced with similar uses of pI.
1680 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1681 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1682 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1683 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1684 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1685 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1686 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1687 64-bit hosts.
1688 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1689 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1690 * print.c (safe_debug_print, print_object): Likewise.
1691 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1692 to int.
1693 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1694 avoiding the 0 flag, which is not portable.
1695 * process.c (Fmake_network_process): Use pI to avoid cast.
1696 * region-cache.c (pp_cache): Likewise.
1697 * xdisp.c (decode_mode_spec): Likewise.
1698 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1699 behavior on 64-bit hosts with printf arg.
1700 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1701 (x_stop_queuing_selection_requests): Likewise.
1702 (x_get_window_property): Don't truncate byte count to an 'int'
1703 when tracing.
1704
1705 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1706 here, since it parses constructs like leading '-' and spaces,
1707 which are not wanted; and it overflows with large numbers.
1708 Instead, simply match F[0-9]+, which is what is wanted anyway.
1709
1710 * alloc.c: Remove unportable assumptions about struct layout.
1711 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1712 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1713 (allocate_vectorlike, make_pure_vector): Use the new macros,
1714 plus offsetof, to remove unportable assumptions about struct layout.
1715 These assumptions hold on all porting targets that I know of, but
1716 they are not guaranteed, they're easy to remove, and removing them
1717 makes further changes easier.
1718
1719 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1720 This doesn't fix a bug but makes the code clearer.
1721 (string_overrun_cookie): Now const. Use initializers that
1722 don't formally overflow signed char, to avoid warnings.
1723 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1724 can cause Emacs to crash when string overrun checking is enabled.
1725 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1726 multiple of sizeof (EMACS_INT); it need not be, if
1727 alignof(EMACS_INT) < sizeof (EMACS_INT).
1728 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1729
1730 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1731
1732 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1733
1734 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1735
1736 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1737 supposed to be handshaking. (Bug#8556)
1738 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1739
1740 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1741
1742 * lisp.h (Qdebug): List symbol.
1743 * eval.c (Qdebug): Restore global linkage.
1744 * keyboard.c (debug-on-event): New variable.
1745 (handle_user_signal): Break into debugger when debug-on-event
1746 matches the current signal symbol.
1747
1748 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1749
1750 * alloc.c (check_sblock, check_string_bytes)
1751 (check_string_free_list): Convert to standard C.
1752
1753 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1754
1755 * w32.c (emacs_gnutls_push): Fix typo.
1756
1757 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1758
1759 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1760 "cast to pointer from integer of different size".
1761
1762 Improve doprnt and its use in verror. (Bug#8545)
1763 * doprnt.c (doprnt): Document the set of format control sequences
1764 supported by the function. Use SAFE_ALLOCA instead of always
1765 using `alloca'.
1766
1767 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1768 is one byte too soon. Don't use xrealloc; instead xfree and
1769 xmalloc anew.
1770
1771 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1772
1773 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1774 callbacks stage.
1775
1776 * gnutls.c: Renamed global_initialized to
1777 gnutls_global_initialized. Added internals for the
1778 :verify-hostname-error, :verify-error, and :verify-flags
1779 parameters of `gnutls-boot' and documented those parameters in the
1780 docstring. Start callback support.
1781 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1782 unless a fatal error occured. Call gnutls_alert_send_appropriate
1783 on error. Return error code.
1784 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1785 (emacs_gnutls_read): Likewise.
1786 (Fgnutls_boot): Return handshake error code.
1787 (emacs_gnutls_handle_error): New function.
1788 (wsaerror_to_errno): Likewise.
1789
1790 * w32.h (emacs_gnutls_pull): Add prototype.
1791 (emacs_gnutls_push): Likewise.
1792
1793 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1794 (emacs_gnutls_push): Likewise.
1795
1796 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1797
1798 * process.c (wait_reading_process_output): Check if GnuTLS
1799 buffered some data internally if no FDs are set for TLS
1800 connections.
1801
1802 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1803 (LIBS): Link to USER_LIBS.
1804 ($(BLD)/gnutls.$(0)): New target.
1805
1806 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1807
1808 * xdisp.c (handle_single_display_spec): Rename the
1809 display_replaced_before_p argument into display_replaced_p, to
1810 make it consistent with the commentary. Fix typos in the
1811 commentary.
1812
1813 * textprop.c (syms_of_textprop): Remove dead code.
1814 (copy_text_properties): Delete obsolete commentary about an
1815 interface that was deleted long ago. Fix typos in the description
1816 of arguments.
1817
1818 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1819 to changes in oldXMenu/XMenu.h from 2011-04-16.
1820 <menu_help_message, prev_menu_help_message>: Constify.
1821 (IT_menu_make_room): menu->help_text is now `const char **';
1822 adjust.
1823
1824 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1825 to changes in oldXMenu/XMenu.h from 2011-04-16.
1826 (struct XMenu): Declare `help_text' `const char **'.
1827
1828 * xfaces.c <Qunspecified>: Make extern again.
1829
1830 * syntax.c: Include sys/types.h before including regex.h, as
1831 required by Posix.
1832
1833 * doc.c (get_doc_string): Improve the format passed to `error'.
1834
1835 * doprnt.c (doprnt): Improve commentary.
1836
1837 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1838
1839 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1840 them with etags.
1841
1842 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1843 changes in globals.h immediately force recompilation.
1844 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1845 $(CURDIR)/s/ms-w32.h.
1846 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1847
1848 * character.c (Fchar_direction): Function deleted.
1849 (syms_of_character): Don't defsubr it.
1850 <char-direction-table>: Deleted.
1851
1852 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1853
1854 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1855 * doprnt.c: Include limits.h.
1856 (SIZE_MAX): New macro.
1857 (doprnt): Return a size_t value. 2nd arg is now size_t.
1858 Many local variables are now size_t instead of int or unsigned.
1859 Improve overflow protection. Support `l' modifier for integer
1860 conversions. Support %l conversion. Don't assume an EMACS_INT
1861 argument for integer conversions and for %c.
1862
1863 * lisp.h (doprnt): Restore prototype.
1864
1865 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1866 $(SRC)/character.h.
1867
1868 * Makefile.in (base_obj): Add back doprnt.o.
1869
1870 * deps.mk (doprnt.o): Add back prerequisites.
1871 (callint.o): Depend on character.h.
1872
1873 * eval.c (internal_lisp_condition_case): Include the handler
1874 representation in the error message.
1875 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1876 when breaking from the loop.
1877
1878 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1879
1880 * callint.c (Fcall_interactively): When displaying error message
1881 about invalid control letter, pass the character's codepoint, not
1882 a pointer to its multibyte form. Improve display of the character
1883 in octal and display also its hex code.
1884
1885 * character.c (char_string): Use %x to display the (unsigned)
1886 codepoint of an invalid character, to avoid displaying a bogus
1887 negative value.
1888
1889 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1890 `error', not SYMBOL_NAME itself.
1891
1892 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1893 character arguments to `error'.
1894
1895 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1896 to `error' in error message about FINAL_CHAR argument. Make sure
1897 FINAL_CHAR is a character, and use %c when it is passed as
1898 argument to `error'.
1899
1900 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1901
1902 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1903
1904 * w32.c: Include <time.h>.
1905 (sys_localtime): New function.
1906
1907 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1908
1909 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1910
1911 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1912
1913 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1914
1915 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1916 zombies (Bug#8467).
1917
1918 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1919
1920 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1921 gl_state.e_property when gl_state.object is Qt.
1922
1923 * insdel.c (make_gap_larger): Remove limitation of buffer size
1924 to <= INT_MAX.
1925
1926 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1927
1928 * xdisp.c (lookup_glyphless_char_display)
1929 (produce_glyphless_glyph): Handle cons cell entry in
1930 glyphless-char-display.
1931 (Vglyphless_char_display): Document it.
1932
1933 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1934 glyphless-char-display.
1935
1936 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1937
1938 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1939
1940 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1941
1942 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1943 definition for no-X builds.
1944
1945 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 Static checks with GCC 4.6.0 and non-default toolkits.
1948
1949 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1950
1951 * process.c (keyboard_bit_set): Define only if SIGIO.
1952 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1953 (send_process): Repair possible setjmp clobbering.
1954
1955 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1956
1957 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1958
1959 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1960
1961 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1962 Define only if needed.
1963
1964 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1965 by pacifying GCC about it. Maybe it's time to retire it?
1966 * xfaces.c (USG, __TIMEVAL__): Likewise.
1967
1968 * dispextern.h (struct redisplay_interface): Rename param
1969 to avoid shadowing.
1970 * termhooks.h (struct terminal): Likewise.
1971 * xterm.c (xembed_send_message): Likewise.
1972
1973 * insdel.c (make_gap_smaller): Define only if
1974 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1975
1976 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1977 it.
1978
1979 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1980 so that we aren't warned about unused symbols.
1981
1982 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1983
1984 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1985
1986 * xfns.c (x_real_positions): Mark locals as initialized.
1987
1988 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1989
1990 * xterm.c: Fix problems found by static analysis with other toolkits.
1991 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1992 (x_dispatch_event): Declare static if USE_GTK, and
1993 define if USE_GTK || USE_X_TOOLKIT.
1994 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1995 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1996 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1997 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1998
1999 * xmenu.c (menu_help_callback): Pointer type fixes.
2000 Use const pointers when pointing at readonly data. Avoid pointer
2001 signedness clashes.
2002 (FALSE): Remove unused macro.
2003 (update_frame_menubar): Remove unused decl.
2004
2005 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2006
2007 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2008 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2009 (single_menu_item): Rename local to avoid shadowing.
2010
2011 * keyboard.c (make_lispy_event): Remove unused local var.
2012
2013 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2014 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2015
2016 * bitmaps: Change bitmaps from unsigned char back to the X11
2017 compatible char. Avoid the old compiler warnings about
2018 out-of-range initializers by using, for example, '\xab' rather
2019 than 0xab.
2020
2021 * xgselect.c (xgselect_initialize): Check vs interface
2022 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2023
2024 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2025
2026 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2027 to read-only memory.
2028
2029 * fns.c (vector): Remove; this old hack is no longer needed.
2030
2031 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2032 Remove unused var.
2033 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2034
2035 * xrdb.c (x_load_resources): Omit unused local.
2036
2037 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2038 (x_window): Rename locals to avoid shadowing.
2039 (USG): Use the kludged USG macro, to pacify gcc.
2040
2041 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2042 (x_term_init): Remove local to avoid shadowing.
2043
2044 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2045
2046 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2047 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2048
2049 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2050
2051 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2052
2053 Fix regex.c, syntax.c and friends for buffers > 2GB.
2054 * syntax.h (struct gl_state_s): Declare character position members
2055 EMACS_INT.
2056
2057 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2058
2059 * textprop.c (verify_interval_modification, interval_of):
2060 Declare arguments EMACS_INT.
2061
2062 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2063 EMACS_INT.
2064
2065 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2066
2067 * indent.c (Fvertical_motion): Local variable it_start is now
2068 EMACS_INT.
2069
2070 * regex.c (re_match, re_match_2, re_match_2_internal)
2071 (bcmp_translate, regcomp, regexec, print_double_string)
2072 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2073 (re_compile_pattern, re_exec): Declare arguments and local
2074 variables `size_t' and `ssize_t' and return values `regoff_t', as
2075 appropriate.
2076 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2077 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2078 <compile_stack_type>: `size' and `avail' are now `size_t'.
2079
2080 * regex.h <regoff_t>: Use ssize_t, not int.
2081 (re_search, re_search_2, re_match, re_match_2): Arguments that
2082 specify buffer/string position and length are now ssize_t and
2083 size_t. Return type is regoff_t.
2084
2085 2011-04-16 Ben Key <bkey76@gmail.com>
2086
2087 * nsfont.m: Fixed bugs in ns_get_family and
2088 ns_descriptor_to_entity that were caused by using free to
2089 deallocate memory blocks that were allocated by xmalloc (via
2090 xstrdup). This caused Emacs to crash when compiled with
2091 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2092 --enable-checking=xmallocoverrun). xfree is now used to
2093 deallocate these memory blocks.
2094
2095 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2096
2097 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2098
2099 emacs_write: Accept and return EMACS_INT for sizes.
2100 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2101 et seq.
2102 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2103 Accept and return EMACS_INT.
2104 (emacs_gnutls_write): Return the number of bytes written on
2105 partial writes.
2106 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2107 (emacs_read, emacs_write): Remove check for negative size, as the
2108 Emacs source code has been audited now.
2109 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2110 (emacs_read, emacs_write): Use it.
2111 * process.c (send_process): Adjust to the new signatures of
2112 emacs_write and emacs_gnutls_write. Do not attempt to store
2113 a byte offset into an 'int'; it might overflow.
2114 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2115
2116 * sound.c: Don't assume sizes fit in 'int'.
2117 (struct sound_device.period_size, alsa_period_size):
2118 Return EMACS_INT, not int.
2119 (struct sound_device.write, vox_write, alsa_write):
2120 Accept EMACS_INT, not int.
2121 (wav_play, au_play): Use EMACS_INT to store sizes and to
2122 record read return values.
2123
2124 2011-04-15 Ben Key <bkey76@gmail.com>
2125
2126 * keyboard.c (Qundefined): Don't declare static since it is used
2127 in nsfns.m.
2128 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2129 static since they are used in nsfont.m.
2130
2131 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2132
2133 * process.c (Qprocessp): Don't declare static.
2134 * lisp.h (Qprocessp): Declare again.
2135
2136 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2137
2138 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2139
2140 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2141
2142 Improve C-level modularity by making more things 'static'.
2143
2144 Don't publish debugger-only interfaces to other modules.
2145 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2146 (verify_bytepos, count_markers): Move decls to the only modules
2147 that need them.
2148 * region-cache.h (pp_cache): Likewise.
2149 * window.h (check_all_windows): Likewise.
2150 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2151
2152 * sysdep.c (croak): Now static, if
2153 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2154 * syssignal.h (croak): Declare only if not static.
2155
2156 * alloc.c (refill_memory_reserve): Now static if
2157 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2158 * lisp.h (refill_memory_reserve): Declare only if not static.
2159
2160 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2161 Define only if USE_LUCID.
2162
2163 * xrdb.c (x_customization_string, x_rm_string): Now static.
2164
2165 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2166 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2167
2168 * xdisp.c (draw_row_with_mouse_face): Now static.
2169 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2170
2171 * window.h (check_all_windows): Mark externally visible.
2172
2173 * window.c (window_deletion_count): Now static.
2174
2175 * undo.c: Make symbols static if they're not exported.
2176 (last_undo_buffer, last_boundary_position, pending_boundary):
2177 Now static.
2178
2179 * textprop.c (interval_insert_behind_hooks): Now static.
2180 (interval_insert_in_front_hooks): Likewise.
2181
2182 * term.c: Make symbols static if they're not exported.
2183 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2184 (max_frame_lines, tty_set_terminal_modes):
2185 (tty_reset_terminal_modes, tty_turn_off_highlight):
2186 (get_tty_terminal): Now static.
2187 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2188 * termhooks.h (term_mouse_moveto): Do not declare if
2189 HAVE_WINDOW_SYSTEM.
2190 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2191 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2192
2193 * sysdep.c: Make symbols static if they're not exported.
2194 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2195 Now static.
2196 (sigprocmask_set, full_mask): Remove; unused.
2197 (wait_debugging): Mark as visible.
2198 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2199 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2200
2201 * syntax.c (syntax_temp): Define only if !__GNUC__.
2202
2203 * sound.c (current_sound_device, current_sound): Now static.
2204
2205 * search.c (searchbufs, searchbuf_head): Now static.
2206
2207 * scroll.c (scroll_cost): Remove; unused.
2208 * dispextern.h (scroll_cost): Remove decl.
2209
2210 * region-cache.h (pp_cache): Mark as externally visible.
2211
2212 * process.c: Make symbols static if they're not exported.
2213 (process_tick, update_tick, create_process, chan_process):
2214 (Vprocess_alist, proc_buffered_char, datagram_access):
2215 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2216 (deactivate_process): Mark defn as static, as well as decl.
2217 * lisp.h (create_process): Remove decl.
2218 * process.h (chan_process, Vprocess_alist): Remove decls.
2219
2220 * print.c: Make symbols static if they're not exported.
2221 (print_depth, new_backquote_output, being_printed, print_buffer):
2222 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2223 (print_interval, print_number_index, initial_stderr_stream):
2224 Now static.
2225 * lisp.h (Fprinc): Remove decl.
2226 (debug_output_compilation_hack): Mark as externally visible.
2227
2228 * sysdep.c (croak): Move decl from here to syssignal.h.
2229 * syssignal.h (croak): Put it here, so the API can be checked when
2230 'croak' is called from dissociate_if_controlling_tty.
2231
2232 * minibuf.c: Make symbols static if they're not exported.
2233 (minibuf_save_list, choose_minibuf_frame): Now static.
2234 * lisp.h (choose_minibuf_frame): Remove decl.
2235
2236 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2237
2238 * lread.c: Make symbols static if they're not exported.
2239 (read_objects, initial_obarray, oblookup_last_bucket_number):
2240 Now static.
2241 (make_symbol): Remove; unused.
2242 * lisp.h (initial_obarray, make_symbol): Remove decls.
2243
2244 * keyboard.c: Make symbols static if they're not exported.
2245 (single_kboard, recent_keys_index, total_keys, recent_keys):
2246 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2247 (this_single_command_key_start, echoing, last_auto_save):
2248 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2249 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2250 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2251 (Vlispy_mouse_stem, double_click_count):
2252 Now static.
2253 (force_auto_save_soon): Define only if SIGDANGER.
2254 (ignore_mouse_drag_p): Now static if
2255 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2256 (print_help): Remove; unused.
2257 (stop_character, last_timer_event): Mark as externally visible.
2258 * keyboard.h (ignore_mouse_drag_p): Declare only if
2259 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2260 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2261 * lisp.h (echoing): Remove decl.
2262 (force_auto_save_soon): Declare only if SIGDANGER.
2263 * xdisp.c (redisplay_window): Simplify code, to make it more
2264 obvious that ignore_mouse_drag_p is not accessed if !defined
2265 USE_GTK && !defined HAVE_NS.
2266
2267 * intervals.c: Make symbols static if they're not exported.
2268 (merge_properties_sticky, merge_interval_right, delete_interval):
2269 Now static.
2270 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2271
2272 * insdel.c: Make symbols static if they're not exported.
2273 However, leave prepare_to_modify_buffer alone. It's never
2274 called from outside this function, but that appears to be a bug.
2275 (combine_after_change_list, combine_after_change_buffer):
2276 (adjust_after_replace, signal_before_change): Now static.
2277 (adjust_after_replace_noundo): Remove; unused.
2278 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2279 (signal_before_change): Remove decls.
2280
2281 * indent.c (val_compute_motion, val_vmotion): Now static.
2282
2283 * image.c: Make symbols static if they're not exported.
2284 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2285 if USE_GTK.
2286 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2287 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2288
2289 * fringe.c (standard_bitmaps): Now static.
2290 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2291
2292 * frame.c: Make symbols static if they're not exported.
2293 (x_report_frame_params, make_terminal_frame): Now static.
2294 (get_frame_param): Now static, unless HAVE_NS.
2295 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2296 (x_get_resource_string): Remove; not used.
2297 * frame.h (make_terminal_frame, x_report_frame_params):
2298 (x_get_resource_string); Remove decls.
2299 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2300 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2301
2302 * font.c, fontset.c: Make symbols static if they're not exported.
2303 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2304 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2305 * font.c (font_close_object): Now static.
2306 * font.h (font_close_object): Remove.
2307 * fontset.c (FONTSET_OBJLIST): Remove.
2308 (free_realized_fontset) #if-0 the body, which does nothing.
2309 (face_suitable_for_char_p): #if-0, as it's never called.
2310 * fontset.h (face_suitable_for_char_p): Remove decl.
2311 * xfaces.c (face_at_string_position):
2312 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2313 since 0 is always ASCII.
2314
2315 * fns.c (weak_hash_tables): Now static.
2316
2317 * fileio.c: Make symbols static if they're not exported.
2318 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2319 (Vwrite_region_annotation_buffers): Now static.
2320
2321 * eval.c: Make symbols static if they're not exported.
2322 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2323 * lisp.h (backtrace_list): Remove decl.
2324
2325 * emacs.c: Make symbols static if they're not exported.
2326 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2327 (fatal_error_code, fatal_error_signal_hook, standard_args):
2328 Now static.
2329 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2330 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2331 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2332 * lisp.h (fatal_error_signal_hook): Remove decl.
2333 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2334
2335 * editfns.c: Move a (normally-unused) function to its only use.
2336 * editfns.c, lisp.h (get_operating_system_release): Remove.
2337 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2338 worth the hassle of breaking this out.
2339
2340 * xterm.c: Make symbols static if they're not exported.
2341 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2342 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2343 (x_destroy_window, x_delete_display):
2344 Now static.
2345 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2346 (x_mouse_leave): Remove; unused.
2347 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2348 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2349 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2350 Remove decls.
2351 (x_mouse_leave): Declare only if WINDOWSNT.
2352 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2353 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2354 USE_X_TOOLKIT.
2355
2356 * ftxfont.c: Make symbols static if they're not exported.
2357 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2358 HAVE_FREETYPE.
2359 * font.h (ftxfont_driver): Likewise.
2360
2361 * xfns.c: Make symbols static if they're not exported.
2362 (x_last_font_name, x_display_info_for_name):
2363 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2364 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2365 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2366 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2367 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2368 (last_show_tip_args): Now static.
2369 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2370 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2371 (x_screen_planes): Remove; unused.
2372 * dispextern.h (x_screen_planes): Remove decl.
2373
2374 * dispnew.c: Make symbols static if they're not exported.
2375 * dispextern.h (redraw_garbaged_frames, scrolling):
2376 (increment_row_positions): Remove.
2377 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2378 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2379 Now static.
2380 (redraw_garbaged_frames): Remove; unused.
2381
2382 * xfaces.c: Make symbols static if they're not exported.
2383 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2384 Remove decls.
2385 * xterm.h (defined_color): Remove decls.
2386 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2387 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2388 (menu_face_changed_default, defined_color, free_realized_face):
2389 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2390 (ascii_face_of_lisp_face): Remove; unused.
2391
2392 * xdisp.c: Make symbols static if they're not exported.
2393 * dispextern.h (scratch_glyph_row, window_box_edges):
2394 (glyph_to_pixel_coords, set_cursor_from_row):
2395 (get_next_display_element, set_iterator_to_next):
2396 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2397 (show_mouse_face): Remove decls
2398 * frame.h (message_buf_print): Likewise.
2399 * lisp.h (pop_message, set_message, check_point_in_composition):
2400 Likewise.
2401 * xterm.h (set_vertical_scroll_bar): Likewise.
2402 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2403 (message_buf_print, scratch_glyph_row, displayed_buffer):
2404 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2405 (get_next_display_element, show_mouse_face, window_box_edges):
2406 (frame_to_window_pixel_xy, check_point_in_composition):
2407 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2408 (glyph_to_pixel_coords): Remove; unused.
2409
2410 * dired.c (file_name_completion): Now static.
2411
2412 * dbusbind.c (xd_in_read_queued_messages): Now static.
2413
2414 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2415 * data.c (circular_list_error): Remove.
2416
2417 * commands.h (last_point_position, last_point_position_buffer):
2418 (last_point_position_window): Remove decls.
2419 * keyboard.c: Make these variables static.
2420
2421 * coding.h (coding, code_convert_region, encode_coding_gap):
2422 Remove decls.
2423 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2424 (iso_code_class, detect_coding, code_convert_region): Now static.
2425 (encode_coding_gap): Remove; unused.
2426
2427 * chartab.c (chartab_chars, chartab_bits): Now static.
2428
2429 * charset.h (charset_iso_8859_1): Remove decl.
2430 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2431 Now static.
2432
2433 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2434 * ccl.c (Vccl_program_table): Now static.
2435 (check_ccl_update): Remove; unused.
2436
2437 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2438 * category.h: ... from here.
2439 * category.c (check_category_table, set_category_set): Now static.
2440
2441 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2442 * lisp.h: Remove these decls.
2443
2444 * buffer.c (buffer_count): Remove unused var.
2445
2446 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2447 so that it's not optimized away.
2448 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2449 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2450 exported only to the debugger.
2451
2452 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2453 * atimer.h (run_all_atimers): Remove; not exported.
2454
2455 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2456 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2457 was inaccessible from Lisp.
2458 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2459 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2460
2461 alloc.c: Import and export fewer symbols, and remove unused items.
2462 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2463 is defined.
2464 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2465 it's not optimized away by whole-program optimization.
2466 (message_enable_multibyte, free_misc): Remove.
2467 (catchlist, handlerlist, mark_backtrace):
2468 Declare only if BYTE_MARK_STACK.
2469 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2470 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2471 (message_enable_multibyte): Remove decl.
2472 (free_misc, interval_free_list, float_block, float_block_index):
2473 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2474 (cons_free_list, last_marked_index):
2475 Now static.
2476 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2477 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2478 (mark_backtrace): Define only if BYTE_MARK_STACK.
2479 * xdisp.c (message_enable_multibyte): Now static.
2480
2481 Declare Lisp_Object Q* variables to be 'static' if not exported.
2482 This makes it easier for human readers (and static analyzers)
2483 to see whether these variables are used from other modules.
2484 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2485 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2486 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2487 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2488 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2489 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2490 * xmenu.c, xselect.c:
2491 Declare Q* vars static if they are not used in other modules.
2492 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2493 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2494 Remove decls of unexported vars.
2495 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2496
2497 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2498
2499 Make Emacs functions such as Fatom 'static' by default.
2500 This makes it easier for human readers (and static analyzers)
2501 to see whether these functions can be called from other modules.
2502 DEFUN now defines a static function. To make the function external
2503 so that it can be used in other C modules, use the new macro DEFUE.
2504 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2505 (Finit_image_library):
2506 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2507 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2508 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2509 Remove decls, since these functions are now static.
2510 (Funintern, Fget_internal_run_time): New decls, since these functions
2511 were already external.
2512
2513 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2514 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2515 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2516 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2517 * keyboard.c, keymap.c, lread.c:
2518 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2519 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2520 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2521 Mark functions with DEFUE instead of DEFUN,
2522 if they are used in other modules.
2523 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2524 decls for now-static functions.
2525 * buffer.h (Fdelete_overlay): Remove decl.
2526 * callproc.c (Fgetenv_internal): Mark as internal.
2527 * composite.c (Fremove_list_of_text_properties): Remove decl.
2528 (Fcomposition_get_gstring): New forward static decl.
2529 * composite.h (Fcomposite_get_gstring): Remove decl.
2530 * dired.c (Ffile_attributes): New forward static decl.
2531 * doc.c (Fdocumntation_property): New forward static decl.
2532 * eval.c (Ffetch_bytecode): New forward static decl.
2533 (Funintern): Remove extern decl; now in .h file where it belongs.
2534 * fileio.c (Fmake_symbolic_link): New forward static decl.
2535 * image.c (Finit_image_library): New forward static decl.
2536 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2537 * intervals.h (Fprevious_property_change):
2538 (Fremove_list_of_text_properties): Remove decls.
2539 * keyboard.c (Fthis_command_keys): Remove decl.
2540 (Fcommand_execute): New forward static decl.
2541 * keymap.c (Flookup_key): New forward static decl.
2542 (Fcopy_keymap): Now static.
2543 * keymap.h (Flookup_key): Remove decl.
2544 * process.c (Fget_process): New forward static decl.
2545 (Fprocess_datagram_address): Mark as internal.
2546 * syntax.c (Fsyntax_table_p): New forward static decl.
2547 (skip_chars): Remove duplicate decl.
2548 * textprop.c (Fprevious_property_change): New forward static decl.
2549 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2550 Now internal.
2551 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2552 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2553
2554 * editfns.c (Fformat): Remove unreachable code.
2555
2556 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2557
2558 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2559 change. (Bug#8496)
2560
2561 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2562
2563 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2564 when at ZV. (Bug#8487)
2565
2566 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2567
2568 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2569 (Bug#8437)
2570 * keyboard.c (parse_tool_bar_item): Likewise.
2571 * sound.c (sound_cleanup, alsa_close): Likewise.
2572 * termcap.c (tgetent): Likewise.
2573 * xfns.c (x_default_font_parameter): Likewise.
2574 * xsettings.c (read_and_apply_settings): Likewise.
2575
2576 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2577 (overrun_check_free): Protoize.
2578
2579 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2580
2581 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2582 since callers should never pass a negative size.
2583 Change the signature to match that of plain 'read' and 'write'; see
2584 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2585 * lisp.h: Update prototypes of emacs_write and emacs_read.
2586
2587 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2588
2589 * xdisp.c (redisplay_window): Don't try to determine the character
2590 position of the scroll margin if the window start point w->startp
2591 is outside the buffer's accessible region. (Bug#8468)
2592
2593 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2594
2595 Fix write-region and its subroutines for buffers > 2GB.
2596 * fileio.c (a_write, e_write): Modify declaration of arguments and
2597 local variables to support buffers larger than 2GB.
2598 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2599
2600 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2601 argument, local variables, and return value.
2602
2603 * lisp.h: Update prototypes of emacs_write and emacs_read.
2604
2605 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2606
2607 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2608
2609 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2610
2611 Fix more problems found by GCC 4.6.0's static checks.
2612
2613 * xdisp.c (vmessage): Use a better test for character truncation.
2614
2615 * charset.c (load_charset_map): <, not <=, for optimization,
2616 and to avoid potential problems with integer overflow.
2617 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2618 * casetab.c (set_identity, shuffle): Likewise.
2619 * editfns.c (Fformat): Likewise.
2620 * syntax.c (skip_chars): Likewise.
2621
2622 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2623 This also lets GCC 4.6.0 generate slightly better loop code.
2624
2625 * callint.c (Fcall_interactively): <, not <=, for optimization.
2626 (Fcall_interactively): Count the number of arguments produced,
2627 not the number of arguments given. This is simpler and lets GCC
2628 4.6.0 generate slightly better code.
2629
2630 * ftfont.c: Distingish more carefully between FcChar8 and char.
2631 The previous code passed unsigned char * to a functions like
2632 strlen and xstrcasecmp that expect char *, which does not
2633 conform to the C standard.
2634 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2635 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2636 char * when the C standard requires it.
2637
2638 * keyboard.c (read_char): Remove unused var.
2639
2640 * eval.c: Port to Windows vsnprintf (Bug#8435).
2641 Include <limits.h>.
2642 (SIZE_MAX): Define if the headers do not.
2643 (verror): Do not give up if vsnprintf returns a negative count.
2644 Instead, grow the buffer. This ports to Windows vsnprintf, which
2645 does not conform to C99. Problem reported by Eli Zaretskii.
2646 Also, simplify the allocation scheme, by avoiding the need for
2647 calling realloc, and removing the ALLOCATED variable.
2648
2649 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2650
2651 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2652 But keep the doprint source code for now, as we might revamp it
2653 and use it again (Bug#8435).
2654 * lisp.h (doprnt): Remove.
2655 * Makefile.in (base_obj): Remove doprnt.o.
2656 * deps.mk (doprnt.o): Remove.
2657
2658 error: Print 32- and 64-bit integers portably (Bug#8435).
2659 Without this change, on typical 64-bit hosts error ("...%d...", N)
2660 was used to print both 32- and 64-bit integers N, which relied on
2661 undefined behavior.
2662 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2663 New macro.
2664 * lisp.h (error, verror): Mark as printf-like functions.
2665 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2666 Report overflow in size calculations when allocating printf buffer.
2667 Do not truncate output string at its first null byte.
2668 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2669 Truncate the output at a character boundary, since vsnprintf does not
2670 do that.
2671 * charset.c (check_iso_charset_parameter): Convert internal
2672 character to string before calling 'error', since %c now has the
2673 printf meaning.
2674 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2675 overflow when computing char to be passed to 'error'. Do not
2676 pass Lisp_Object to 'error'; pass the integer instead.
2677 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2678 formatted with plain %d.
2679
2680 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2681
2682 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2683
2684 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2685
2686 * xterm.c (x_catch_errors): Remove duplicate declaration.
2687
2688 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2689
2690 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2691
2692 2011-04-10 Jim Meyering <meyering@redhat.com>
2693
2694 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2695 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2696 return ssize_t not "int", and use size_t as the buffer length.
2697 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2698 * gnutls.h: Update declarations.
2699 * process.c (read_process_output): Use ssize_t, to match.
2700 (send_process): Likewise.
2701
2702 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2703
2704 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2705
2706 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2707
2708 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2709 Use unsigned char, to match FcChar8 type definition.
2710
2711 * xterm.c (handle_one_xevent):
2712 * xmenu.c (create_and_show_popup_menu):
2713 * xselect.c (x_decline_selection_request)
2714 (x_reply_selection_request): Avoid type-punned deref of X events.
2715
2716 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2717
2718 Fix some uses of `int' instead of EMACS_INT.
2719 * search.c (string_match_1, fast_string_match)
2720 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2721 (scan_buffer, find_next_newline_no_quit)
2722 (find_before_next_newline, search_command, Freplace_match)
2723 (Fmatch_data): Make some `int' variables be EMACS_INT.
2724
2725 * xdisp.c (display_count_lines): 3rd argument and return value now
2726 EMACS_INT. All callers changed.
2727 (pint2hrstr): Last argument is now EMACS_INT.
2728
2729 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2730 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2731 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2732 (decode_coding_utf_16, decode_coding_emacs_mule)
2733 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2734 (decode_coding_ccl, decode_coding_charset)
2735 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2736 (decode_coding_iso_2022, decode_coding_emacs_mule)
2737 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2738 <char_offset, last_offset>: Declare EMACS_INT.
2739 (encode_coding_utf_8, encode_coding_utf_16)
2740 (encode_coding_emacs_mule, encode_invocation_designation)
2741 (encode_designation_at_bol, encode_coding_iso_2022)
2742 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2743 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2744 Declare EMACS_INT.
2745 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2746 (encode_invocation_designation): Last argument P_NCHARS is now
2747 EMACS_INT.
2748 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2749 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2750
2751 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2752 All users changed.
2753
2754 * ccl.c (Fccl_execute_on_string): Declare some variables
2755 EMACS_INT.
2756
2757 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2758
2759 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2760
2761 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2762
2763 * process.c (Fformat_network_address): Doc fix.
2764
2765 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2766
2767 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2768
2769 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2770
2771 * keyboard.c (read_char): Call Lisp function help-form-show,
2772 instead of using internal_with_output_to_temp_buffer.
2773 (Qhelp_form_show): New var.
2774 (syms_of_keyboard): Use DEFSYM macro.
2775
2776 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2777
2778 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2779
2780 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2781
2782 * process.c (Flist_processes): Remove to Lisp.
2783 (list_processes_1): Delete.
2784
2785 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2786
2787 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2788
2789 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2790
2791 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 Fix more problems found by GCC 4.6.0's static checks.
2794
2795 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2796
2797 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2798
2799 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2800
2801 * xdisp.c (vmessage): Mark as a printf-like function.
2802
2803 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2804
2805 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2806
2807 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2808 printf-like functions.
2809 (tiff_load): Add casts to remove these marks before passing them
2810 to system-supplied API.
2811
2812 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2813
2814 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2815 This avoids several warnings with gcc -Wstrict-overflow.
2816 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2817 directly, rather than having caller test rule sign. This avoids
2818 some unnecessary tests.
2819 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2820 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2821 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2822
2823 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2824 (xfont_open): Avoid unnecessary tests.
2825
2826 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2827
2828 * composite.h, composite.c (composition_gstring_put_cache):
2829 Use EMACS_INT, not int, for length.
2830
2831 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2832 breaking out part of COMPOSITION_DECODE_RULE.
2833 (COMPOSITION_DECODE_RULE): Use it.
2834 * composite.c (get_composition_id): Remove unused local vars,
2835 by using the new macro.
2836
2837 * textprop.c (set_text_properties_1): Change while to do-while,
2838 since the condition is always true at first.
2839
2840 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2841 (interval_deletion_adjustment): Return unsigned value.
2842 All uses changed.
2843
2844 * process.c (list_processes_1, create_pty, read_process_output):
2845 (exec_sentinel): Remove vars that were set but not used.
2846 (create_pty): Remove unnecessary "volatile"s.
2847 (Fnetwork_interface_info): Avoid possibility of int overflow.
2848 (read_process_output): Do adaptive read buffering even if carryover.
2849 (read_process_output): Simplify nbytes computation if buffered.
2850
2851 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2852
2853 * syntax.c (scan_words): Remove var that was set but not used.
2854 (update_syntax_table): Use unsigned instead of int.
2855
2856 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2857 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2858 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2859
2860 * print.c (print_error_message): Avoid int overflow.
2861
2862 * font.c (font_list_entities): Redo for clarity,
2863 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2864
2865 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2866 (font_score): Avoid potential overflow in diff calculation.
2867
2868 * fns.c (substring_both): Remove var that is set but not used.
2869 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2870
2871 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2872
2873 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2874 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2875 can always succeed if overflow has undefined behavior.
2876
2877 * search.c (boyer_moore, wordify): Remove vars set but not used.
2878 (wordify): Omit three unnecessary tests.
2879
2880 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2881 All callers changed. This avoids the need for an unused var.
2882
2883 * casefiddle.c (casify_region): Remove var that is set but not used.
2884
2885 * dired.c (file_name_completion): Remove var that is set but not used.
2886
2887 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2888
2889 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2890 (Finsert_file_contents): Remove unnecessary code checking fd.
2891
2892 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2893 Check for integer overflow on size calculations.
2894
2895 * buffer.c (Fprevious_overlay_change): Remove var that is set
2896 but not used.
2897
2898 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2899 Remove vars that are set but not used.
2900 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2901 (timer_check_2): Mark vars as initialized.
2902
2903 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2904
2905 * image.c (lookup_image): Remove var that is set but not used.
2906 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2907
2908 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2909 that are set but not used.
2910
2911 * xfns.c (make_invisible_cursor): Don't return garbage
2912 if XCreateBitmapFromData fails (Bug#8410).
2913
2914 * xselect.c (x_get_local_selection, x_handle_property_notify):
2915 Remove vars that are set but not used.
2916
2917 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2918 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2919
2920 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2921 Remove var that is set but not used.
2922 (scroll_bar_windows_size): Now size_t, not int.
2923 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2924 Check for overflow.
2925
2926 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2927 (map_tty_color) [!defined MSDOS]: Likewise.
2928
2929 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2930
2931 * coding.c: Remove vars that are set but not used.
2932 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2933 All callers changed.
2934 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2935 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2936 (decode_coding_charset): Remove vars that are set but not used.
2937
2938 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2939 that is set but not used.
2940
2941 * print.c (print_object): Remove var that is set but not used.
2942
2943 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2944 The gnulib version avoids calling malloc in the usual case,
2945 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2946 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2947 * filelock.c (current_lock_owner): Likewise.
2948 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2949 * sysdep.c: Include allocator.h, careadlinkat.h.
2950 (emacs_no_realloc_allocator): New static constant.
2951 (emacs_readlink): New function.
2952 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2953 ../lib/careadlinkat.h.
2954
2955 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2956
2957 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2958 first non-nil return value).
2959
2960 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2961
2962 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2963 if not defined (Bug#8403).
2964
2965 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2966
2967 * xdisp.c (display_count_lines): Remove parameter `start',
2968 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2969 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2970 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2971 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2972 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2973 and thereabouts. All callers changed.
2974 (get_per_char_metric): Remove parameter `f', unused since
2975 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2976
2977 2011-04-02 Jim Meyering <meyering@redhat.com>
2978
2979 do not dereference NULL upon failed strdup
2980 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2981 (ns_get_family): Likewise.
2982
2983 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2984
2985 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2986
2987 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2988
2989 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2990 later (Bug#8403).
2991
2992 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2993
2994 Add lexical binding.
2995
2996 * window.c (Ftemp_output_buffer_show): New fun.
2997 (Fsave_window_excursion):
2998 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2999
3000 * lread.c (lisp_file_lexically_bound_p): New function.
3001 (Fload): Bind Qlexical_binding.
3002 (readevalloop): Remove `evalfun' arg.
3003 Bind Qinternal_interpreter_environment.
3004 (Feval_buffer): Bind Qlexical_binding.
3005 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3006 Mark as dynamic.
3007 (syms_of_lread): Declare `lexical-binding'.
3008
3009 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3010
3011 * keyboard.c (eval_dyn): New fun.
3012 (menu_item_eval_property): Use it.
3013
3014 * image.c (parse_image_spec): Use Ffunctionp.
3015
3016 * fns.c (concat, mapcar1): Accept byte-code-functions.
3017
3018 * eval.c (Fsetq): Handle lexical vars.
3019 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3020 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3021 (FletX, Flet): Obey lexical binding.
3022 (Fcommandp): Handle closures.
3023 (Feval): New `lexical' arg.
3024 (eval_sub): New function extracted from Feval. Use it almost
3025 everywhere where Feval was used. Look up vars in lexical env.
3026 Handle closures.
3027 (Ffunctionp): Move from subr.el.
3028 (Ffuncall): Handle closures.
3029 (apply_lambda): Remove `eval_flags'.
3030 (funcall_lambda): Handle closures and new byte-code-functions.
3031 (Fspecial_variable_p): New function.
3032 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3033 but without exporting it to Lisp.
3034
3035 * doc.c (Fdocumentation, store_function_docstring):
3036 * data.c (Finteractive_form): Handle closures.
3037
3038 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3039 interactive spec.
3040
3041 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3042 New byte-codes.
3043 (exec_byte_code): New function extracted from Fbyte_code to handle new
3044 calling convention for byte-code-functions. Add new byte-codes.
3045
3046 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3047
3048 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3049
3050 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3051
3052 * xdisp.c (redisplay_internal): Fix prototype.
3053
3054 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3055
3056 * xdisp.c (SCROLL_LIMIT): New macro.
3057 (try_scrolling): Use it when setting scroll_limit.
3058 Limit scrolling to 100 screen lines.
3059 (redisplay_window): Even when falling back on "recentering",
3060 position point in the window according to scroll-conservatively,
3061 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3062
3063 (try_scrolling): When point is above the window, allow searching
3064 as far as scroll_max, or one screenful, to compute vertical
3065 distance from PT to the scroll margin position. This prevents
3066 try_scrolling from unnecessarily failing when
3067 scroll-conservatively is set to a value slightly larger than the
3068 window height. Clean up the case of PT below the margin at bottom
3069 of window: scroll_max can no longer be INT_MAX. When aggressive
3070 scrolling is in use, don't let point enter the opposite scroll
3071 margin as result of the scroll.
3072 (syms_of_xdisp) <scroll-conservatively>: Document the
3073 threshold of 100 lines for never-recentering scrolling.
3074
3075 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3076
3077 * dispextern.h (move_it_by_lines):
3078 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3079 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3080 (message_log_check_duplicate): Remove parameters `prev_bol' and
3081 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3082 (redisplay_internal): Remove parameter `preserve_echo_area',
3083 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3084
3085 * indent.c (Fvertical_motion):
3086 * window.c (window_scroll_pixel_based, Frecenter):
3087 Don't pass `need_y_p' to `move_it_by_lines'.
3088
3089 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3090
3091 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3092 steal a few bits to be more compact.
3093 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3094 Remove unneeded casts.
3095
3096 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3097
3098 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3099
3100 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3101 binding" message (bug#7967).
3102
3103 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 Fix more problems found by GCC 4.6.0's static checks.
3106
3107 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3108 Remove unused local var.
3109
3110 * editfns.c (Fmessage_box): Remove unused local var.
3111
3112 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3113 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3114 Omit unused local vars.
3115 * window.c (shrink_windows): Omit unused local var.
3116 * menu.c (digest_single_submenu): Omit unused local var.
3117 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3118 Omit unused local var.
3119
3120 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3121 Don't assume string length fits in int.
3122 (keyremap_step, read_key_sequence): Use size_t for sizes.
3123 (read_key_sequence): Don't check last_real_key_start redundantly.
3124
3125 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3126 instead of alloca (Bug#8344).
3127
3128 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3129 (Fbacktrace_frame): Don't assume nframes fits in int.
3130
3131 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3132
3133 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3134 concerns.
3135
3136 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3137
3138 * cm.c (calccost): Turn while-do into do-while, for clarity.
3139
3140 * keyboard.c (syms_of_keyboard): Use the same style as later
3141 in this function when indexing through an array. This also
3142 works around GCC bug 48267.
3143
3144 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3145
3146 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3147
3148 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3149 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3150
3151 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3152 This avoids undefined behavior on integer overflow, and is a bit
3153 more convenient anyway since it is compared to a size_t variable.
3154
3155 Variadic C functions now count arguments with size_t, not int.
3156 This avoids an unnecessary limitation on 64-bit machines, which
3157 caused (substring ...) to crash on large vectors (Bug#8344).
3158 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3159 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3160 All variadic functions and their callers changed accordingly.
3161 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3162 * data.c (arith_driver, float_arith_driver): Likewise.
3163 * editfns.c (general_insert_function): Likewise.
3164 * eval.c (struct backtrace.nargs, interactive_p)
3165 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3166 (funcall_lambda, mark_backtrace): Likewise.
3167 * fns.c (concat): Likewise.
3168 * frame.c (x_set_frame_parameters): Likewise.
3169 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3170 0 if not found, not -1. All callers changed.
3171
3172 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3173 (stack_copy_size): Now size_t, not int.
3174 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3175
3176 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3177
3178 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3179 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3180 All callers changed.
3181
3182 * lisp.h (multibyte_char_to_unibyte):
3183 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3184 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3185 * character.h (CHAR_TO_BYTE8):
3186 * cmds.c (internal_self_insert):
3187 * editfns.c (general_insert_function):
3188 * keymap.c (push_key_description):
3189 * search.c (Freplace_match):
3190 * xdisp.c (message_dolog, set_message_1): All callers changed.
3191
3192 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3193
3194 * keyboard.c (safe_run_hook_funcall): New function.
3195 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3196 don't set the hook to nil, but remove the offending function instead.
3197 (Qcommand_hook_internal): Remove, unused.
3198 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3199 Vcommand_hook_internal.
3200
3201 * eval.c (enum run_hooks_condition): Remove.
3202 (funcall_nil, funcall_not): New functions.
3203 (run_hook_with_args): Call each function through a `funcall' argument.
3204 Remove `cond' argument, now redundant.
3205 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3206 (Frun_hook_with_args_until_failure): Adjust accordingly.
3207 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3208
3209 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3210
3211 * dispextern.h (string_buffer_position): Remove declaration.
3212
3213 * print.c (strout): Remove parameter `multibyte', unused since
3214 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3215
3216 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3217 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3218 All callers changed.
3219
3220 * w32.c (_wsa_errlist): Use braces for struct initializers.
3221
3222 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3223 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3224 All callers changed.
3225 (string_buffer_position): Likewise. Also, make static (it's never
3226 used outside xdisp.c).
3227 (cursor_row_p): Remove parameter `w', unused since
3228 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3229 (decode_mode_spec): Remove parameter `precision', introduced during
3230 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3231 All callers changed.
3232
3233 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3234
3235 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3236
3237 2011-03-27 Anders Lindgren <andlind@gmail.com>
3238
3239 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3240 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3241 (ns_update_auto_hide_menu_bar): New functions.
3242 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3243 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3244 ns_constrain_all_frames.
3245 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3246 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3247
3248 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3249
3250 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3251
3252 2011-03-27 Glenn Morris <rgm@gnu.org>
3253
3254 * syssignal.h: Replace RETSIGTYPE with void.
3255 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3256 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3257 Replace SIGTYPE with void everywhere.
3258 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3259 * s/template.h (SIGTYPE): Remove commented out definition.
3260
3261 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3262
3263 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3264 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3265
3266 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3267
3268 * w32.c (read_unc_volume): Use parameter `henum', instead of
3269 global variable `wget_enum_handle'.
3270
3271 * keymap.c (describe_vector): Remove parameters `indices' and
3272 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3273 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3274
3275 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3276
3277 * keyboard.c (timer_check): Remove parameter `do_it_now',
3278 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3279 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3280 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3281
3282 * keyboard.c (read_char):
3283 * w32menu.c (w32_menu_display_help):
3284 * xmenu.c (show_help_event, menu_help_callback):
3285 Adjust calls to `show_help_echo'.
3286
3287 * gtkutil.c (xg_maybe_add_timer):
3288 * keyboard.c (readable_events):
3289 * process.c (wait_reading_process_output):
3290 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3291
3292 * insdel.c (adjust_markers_gap_motion):
3293 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3294 (gap_left, gap_right): Don't call it.
3295
3296 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3297
3298 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3299 incurred during fontification.
3300
3301 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3302
3303 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3304 (DEFVAR_PER_BUFFER): Don't pass it.
3305
3306 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3307 (scrolling_window): Don't pass it.
3308
3309 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3310
3311 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3312
3313 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3314 and `suffix'.
3315 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3316 of variables specific to SELinux and computation of `encoded_absname'.
3317
3318 * image.c (XPutPixel): Remove unused variable `height'.
3319
3320 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3321
3322 * unexw32.c (get_section_info): Remove unused variable `section'.
3323
3324 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3325 (system_process_attributes): Remove unused variable `sess'.
3326 (sys_read): Remove unused variable `err'.
3327
3328 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3329 (w32_wnd_proc): Remove unused variable `isdead'.
3330 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3331 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3332 (x_create_tip_frame): Remove unused variable `tem'.
3333
3334 * w32inevt.c (w32_console_read_socket):
3335 Remove unused variable `no_events'.
3336
3337 * w32term.c (x_draw_composite_glyph_string_foreground):
3338 Remove unused variable `width'.
3339
3340 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3341
3342 * w32term.c (x_set_glyph_string_clipping):
3343 Don't pass uninitialized region to CombineRgn.
3344
3345 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3346
3347 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3348 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3349 (Fx_close_connection): Remove unused variable `i'.
3350
3351 * w32font.c (w32font_draw): Return number of glyphs.
3352 (w32font_open_internal): Remove unused variable `i'.
3353 (w32font_driver): Add missing initializer.
3354
3355 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3356 (fill_in_menu): Remove unused variable `items_added'.
3357
3358 * w32term.c (last_mouse_press_frame): Remove static global variable.
3359 (w32_clip_to_row): Remove unused variable `f'.
3360 (x_delete_terminal): Remove unused variable `i'.
3361
3362 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3363 (NOTHING): Remove unused static global variable.
3364 (uniscribe_check_otf): Remove unused variable `table'.
3365 (uniscribe_font_driver): Add missing initializers.
3366
3367 2011-03-23 Julien Danjou <julien@danjou.info>
3368
3369 * term.c (Fsuspend_tty, Fresume_tty):
3370 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3371 * window.c (temp_output_buffer_show):
3372 * insdel.c (signal_before_change):
3373 * frame.c (Fhandle_switch_frame):
3374 * fileio.c (Fdo_auto_save):
3375 * emacs.c (Fkill_emacs):
3376 * editfns.c (save_excursion_restore):
3377 * cmds.c (internal_self_insert):
3378 * callint.c (Fcall_interactively):
3379 * buffer.c (Fkill_all_local_variables):
3380 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3381 Use Frun_hooks.
3382 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3383 unconditionnaly since it does the check itself.
3384
3385 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3386
3387 Fix more problems found by GCC 4.5.2's static checks.
3388
3389 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3390 the first time through the loop, since we know p0 < p1 then.
3391 This also avoids a gcc -Wstrict-overflow warning.
3392
3393 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3394 leading to a memory leak, possible in functions like
3395 load_charset_map_from_file that can allocate an unbounded number
3396 of objects (Bug#8318).
3397
3398 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3399 that could (at least in theory) be that large.
3400
3401 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3402 This is less likely to overflow, and avoids undefined behavior if
3403 overflow does occur. All callers changed. Use strtoul to scan
3404 for the unsigned long integer.
3405 (pint2hrstr): Simplify and tune code slightly.
3406 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3407
3408 * scroll.c (do_scrolling): Work around GCC bug 48228.
3409 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3410
3411 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3412 This also avoids a warning with gcc -Wstrict-overflow.
3413 (validate_x_resource_name): Simplify count usage.
3414 This also avoids a warning with gcc -Wstrict-overflow.
3415
3416 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3417 fail (Bug#8306).
3418
3419 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3420
3421 * process.c (Fmake_network_process): Use socklen_t, not int,
3422 where POSIX says socklen_t is required in portable programs.
3423 This fixes a porting bug on hosts like 64-bit HP-UX, where
3424 socklen_t is wider than int (Bug#8277).
3425 (Fmake_network_process, server_accept_connection):
3426 (wait_reading_process_output, read_process_output):
3427 Likewise.
3428
3429 * process.c: Rename or move locals to avoid shadowing.
3430 (list_processes_1, Fmake_network_process):
3431 (read_process_output_error_handler, exec_sentinel_error_handler):
3432 Rename or move locals.
3433 (Fmake_network_process): Define label "retry_connect" only if needed.
3434 (Fnetwork_interface_info): Fix pointer signedness.
3435 (process_send_signal): Add cast to avoid pointer signedness problem.
3436 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3437 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3438
3439 Make tparam.h and terminfo.c consistent.
3440 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3441 Include tparam.h instead, since it declares them.
3442 * cm.h (PC): Remove extern decl; tparam.h now does this.
3443 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3444 * terminfo.c: Include tparam.h, to check interfaces.
3445 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3446 (tparam): Adjust signature to match interface in tparam.h;
3447 this removes some undefined behavior. Check that outstring and len
3448 are zero, which they always are with Emacs.
3449 * tparam.h (PC, BC, UP): New extern decls.
3450
3451 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3452 (xftfont_open): Rename locals to avoid shadowing.
3453
3454 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3455 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3456 (OTF_TAG_SYM): Omit macro if not needed.
3457 (ftfont_list): Remove unused local.
3458 (get_adstyle_property, ftfont_pattern_entity):
3459 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3460 Rename locals to avoid shadowing.
3461
3462 * xfont.c (xfont_list_family): Mark var as initialized.
3463
3464 * xml.c (make_dom): Now static.
3465
3466 * composite.c (composition_compute_stop_pos): Rename local to
3467 avoid shadowing.
3468 (composition_reseat_it): Remove unused locals.
3469 (find_automatic_composition, composition_adjust_point): Likewise.
3470 (composition_update_it): Mark var as initialized.
3471 (find_automatic_composition): Mark vars as initialized,
3472 with a FIXME (Bug#8290).
3473
3474 character.h: Rename locals to avoid shadowing.
3475 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3476 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3477 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3478 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3479 to avoid shadowing.
3480
3481 * textprop.c (property_change_between_p): Remove; unused.
3482
3483 * intervals.c (interval_start_pos): Now static.
3484
3485 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3486
3487 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3488 Rename locals to avoid shadowing.
3489
3490 * sound.c (wav_play, au_play, Fplay_sound_internal):
3491 Fix pointer signedness.
3492 (alsa_choose_format): Remove unused local var.
3493 (wav_play): Initialize a variable to 0, to prevent undefined
3494 behavior (Bug#8278).
3495
3496 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3497
3498 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3499
3500 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3501 clobbering (Bug#8298).
3502 * sysdep.c (sys_subshell): Likewise.
3503 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3504
3505 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3506 This should get cleaned up, so that child_setup has the
3507 same signature on all platforms.
3508
3509 * callproc.c (call_process_cleanup): Now static.
3510 (relocate_fd): Rename locals to avoid shadowing.
3511
3512 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3513
3514 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3515 not to be necessary, and produces flickering.
3516
3517 2011-03-20 Glenn Morris <rgm@gnu.org>
3518
3519 * config.in: Remove file.
3520
3521 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3522
3523 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3524 are now in src/globals.h.
3525 (syms_of_minibuf): Remove spurious & from previous change.
3526
3527 2011-03-20 Leo <sdl.web@gmail.com>
3528
3529 * minibuf.c (completing-read-function): New variable.
3530 (completing-read-default): Rename from completing-read.
3531 (completing-read): Call completing-read-function.
3532
3533 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3534
3535 * xfaces.c (Fx_load_color_file):
3536 Read color file from absolute filename (bug#8250).
3537
3538 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3539
3540 * makefile.w32-in: Update dependencies.
3541
3542 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3543
3544 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3545
3546 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3547
3548 Fix more problems found by GCC 4.5.2's static checks.
3549
3550 * process.c (make_serial_process_unwind, send_process_trap):
3551 (sigchld_handler): Now static.
3552
3553 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3554 That way, the code declares only the vars that it needs.
3555 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3556 * s/cygwin.h (PTY_ITERATION): Likewise.
3557 * s/darwin.h (PTY_ITERATION): Likewise.
3558 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3559
3560 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3561 * process.c (allocate_pty): Don't declare stb unless it's needed.
3562
3563 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3564 (CONSTANTLIM): Remove; unused.
3565 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3566 Define only if needed.
3567
3568 * unexelf.c (unexec): Name an expression,
3569 to avoid gcc -Wbad-function-cast warning.
3570 Use a different way to cause a compilation error if anyone uses
3571 n rather than nn, a way that does not involve shadowing.
3572 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3573
3574 * deps.mk (unexalpha.o): Remove; unused.
3575
3576 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3577 * unexec.h: New file.
3578 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3579 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3580 Depend on unexec.h.
3581 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3582 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3583 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3584 Change as necessary to match prototype in unexec.h.
3585
3586 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3587 shadowing.
3588 (back_comment, skip_chars): Mark vars as initialized.
3589
3590 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3591 Rename locals to avoid shadowing.
3592
3593 * lread.c (read1): Rewrite so as not to use empty "else".
3594 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3595
3596 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3597
3598 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3599 warning when compiling print.c.
3600
3601 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3602 instead of using an uninitialized var.
3603 (font_sort_entities): Mark var as initialized.
3604
3605 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3606
3607 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3608 pointers to constants.
3609 (font_parse_fcname): Remove unused vars.
3610 (font_delete_unmatched): Now static.
3611 (font_get_spec): Remove; unused.
3612 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3613 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3614 Rename or move locals to avoid shadowing.
3615
3616 * fns.c (require_nesting_list, require_unwind): Now static.
3617 (Ffillarray): Rename locals to avoid shadowing.
3618
3619 * floatfns.c (domain_error2): Define only if needed.
3620 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3621
3622 * alloc.c (mark_backtrace): Move decl from here ...
3623 * lisp.h: ... to here, so that it can be checked.
3624
3625 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3626 (Fdefvar): Rewrite so as not to use empty "else".
3627 (lisp_indirect_variable): Name an expression,
3628 to avoid gcc -Wbad-function-cast warning.
3629 (Fdefvar): Rename locals to avoid shadowing.
3630
3631 * callint.c (quotify_arg, quotify_args): Now static.
3632 (Fcall_interactively): Rename locals to avoid shadowing.
3633 Use const pointer when appropriate.
3634
3635 * lisp.h (get_system_name, get_operating_system_release):
3636 Move decls here, to check interfaces.
3637 * process.c (get_operating_system_release): Move decl to lisp.h.
3638 * xrdb.c (get_system_name): Likewise.
3639 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3640 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3641 some of which prompt warnings from gcc -Wbad-function-cast.
3642 (Fformat_time_string, Fencode_time, Finsert_char):
3643 (Ftranslate_region_internal, Fformat):
3644 Rename or remove local vars to avoid shadowing.
3645 (Ftranslate_region_internal): Mark var as initialized.
3646
3647 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3648 avoid shadowing.
3649
3650 * lisp.h (eassert): Check that the argument compiles, even if
3651 ENABLE_CHECKING is not defined.
3652
3653 * data.c (Findirect_variable): Name an expression, to avoid
3654 gcc -Wbad-function-cast warning.
3655 (default_value, arithcompare, arith_driver, arith_error): Now static.
3656 (store_symval_forwarding): Rename local to avoid shadowing.
3657 (Fmake_variable_buffer_local, Fmake_local_variable):
3658 Mark variables as initialized.
3659 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3660
3661 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3662 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3663 Rename locals to avoid shadowing.
3664 (mark_stack): Move local variables into the #ifdef region where
3665 they're used.
3666 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3667 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3668 needed otherwise.
3669 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3670 (GC_STRING_CHARS): Remove; not used.
3671 (Fmemory_limit): Cast sbrk's returned value to char *.
3672
3673 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3674 avoids undefined behavior in theory.
3675
3676 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3677
3678 Use functions, not macros, for up- and down-casing (Bug#8254).
3679 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3680 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3681 to use the following functions instead of these macros.
3682 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3683 EMACS_INT, since callers assume the returned value fits in int.
3684 (upcase1): Likewise, for UPCASE_TABLE.
3685 (uppercasep, lowercasep, upcase): New static inline functions.
3686 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3687 the race-condition problem in the old DOWNCASE.
3688
3689 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3690 Rename locals to avoid shadowing.
3691 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3692 (regex_compile, re_search_2, re_match_2_internal):
3693 Remove unused local vars.
3694 (FREE_VAR): Rewrite so as not to use empty "else",
3695 which gcc can warn about.
3696 (regex_compile, re_match_2_internal): Mark locals as initialized.
3697 (RETALLOC_IF): Define only if needed.
3698 (WORDCHAR_P): Likewise. This one is never needed, but is used
3699 only in a comment talking about a compiler bug, so put inside
3700 the #if 0 of that comment.
3701 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3702 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3703 Remove; unused.
3704
3705 * search.c (boyer_moore): Rename locals to avoid shadowing.
3706 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3707 (PREV_CHAR_BOUNDARY): Likewise.
3708
3709 * search.c (simple_search): Remove unused var.
3710
3711 * dired.c (compile_pattern): Move decl from here ...
3712 * lisp.h: ... to here, so that it can be checked.
3713 (struct re_registers): New forward decl.
3714
3715 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3716
3717 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3718 All uses changed.
3719 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3720 Rename locals to avoid shadowing.
3721 (Fvertical_motion): Mark locals as initialized.
3722
3723 * casefiddle.c (casify_object, casify_region): Now static.
3724 (casify_region): Mark local as initialized.
3725
3726 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3727
3728 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3729 New macros, so that the caller can use some names other than
3730 gcpro1, gcpro2, etc.
3731 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3732 of the new macros.
3733 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3734 argument, for consistency with GCPRO2_VAR, etc: it is now the
3735 prefix of the variable, not the variable itself. All uses
3736 changed.
3737 * dired.c (directory_files_internal, file_name_completion):
3738 Rename locals to avoid shadowing.
3739
3740 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3741 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3742 dired.c's scmp function, had undefined behavior.
3743 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3744 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3745 * buffer.h: ... to here, because these macros use current_buffer,
3746 and the new implementation with inline functions needs to have
3747 current_buffer in scope now, rather than later when the macros
3748 are used.
3749 (downcase, upcase1): New static inline functions.
3750 (DOWNCASE, UPCASE1): Reimplement using these functions.
3751 This avoids undefined behavior in expressions like
3752 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3753 from race conditions in accessing the global variables
3754 case_temp1 and case_temp2.
3755 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3756 * lisp.h (case_temp1, case_temp2): Remove their decls.
3757 * character.h (ASCII_CHAR_P): Move from here ...
3758 * lisp.h: ... to here, so that the inline functions mentioned
3759 above can use them.
3760
3761 * dired.c (directory_files_internal_unwind): Now static.
3762
3763 * fileio.c (file_name_as_directory, directory_file_name):
3764 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3765 Now static.
3766 (file_name_as_directory): Use const pointers when appropriate.
3767 (Fexpand_file_name): Likewise. In particular, newdir might
3768 point at constant storage, so make it a const pointer.
3769 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3770 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3771 signedness issues.
3772 (Fset_file_times, Finsert_file_contents, auto_save_error):
3773 Rename locals to avoid shadowing.
3774
3775 * minibuf.c (choose_minibuf_frame_1): Now static.
3776 (Ftry_completion, Fall_completions): Rename or remove locals
3777 to avoid shadowing.
3778
3779 * marker.c (bytepos_to_charpos): Remove; unused.
3780
3781 * lisp.h (verify_bytepos, count_markers): New decls,
3782 so that gcc does not warn that these functions aren't declared.
3783
3784 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3785 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3786 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3787 (copy_text): Remove unused local var.
3788
3789 * filelock.c (within_one_second): Now static.
3790 (lock_file_1): Rename local to avoid shadowing.
3791
3792 * buffer.c (fix_overlays_before): Mark locals as initialized.
3793 (fix_start_end_in_overlays): Likewise. This function should be
3794 simplified by using pointers-to-pointers, but that's a different
3795 matter.
3796 (switch_to_buffer_1): Now static.
3797 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3798 (report_overlay_modification): Rename locals to avoid shadowing.
3799
3800 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3801 Fix pointer signedness issue.
3802 (sys_subshell): Mark local as volatile if checking for lint,
3803 to suppress a gcc -Wclobbered warning that does not seem to be right.
3804 (MAXPATHLEN): Define only if needed.
3805
3806 * process.c (serial_open, serial_configure): Move decls from here ...
3807 * systty.h: ... to here, so that they can be checked.
3808
3809 * fns.c (get_random, seed_random): Move extern decls from here ...
3810 * lisp.h: ... to here, so that they can be checked.
3811
3812 * sysdep.c (reset_io): Now static.
3813 (wait_for_termination_signal): Remove; unused.
3814
3815 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3816 (copy_keymap_item, append_key, push_text_char_description):
3817 Now static.
3818 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3819 (DENSE_TABLE_SIZE): Remove; unused.
3820 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3821 (describe_map_tree):
3822 Rename locals to avoid shadowing.
3823
3824 * keyboard.c: Declare functions static if they are not used elsewhere.
3825 (echo_char, echo_dash, cmd_error, top_level_2):
3826 (poll_for_input, handle_async_input): Now static.
3827 (read_char, kbd_buffer_get_event, make_lispy_position):
3828 (make_lispy_event, make_lispy_movement, apply_modifiers):
3829 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3830 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3831 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3832 (read_key_sequence, read_char): Mark locals as initialized.
3833 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3834
3835 * keyboard.h (make_ctrl_char): New decl.
3836 (mark_kboards): Move decl here ...
3837 * alloc.c (mark_kboards): ... from here.
3838
3839 * lisp.h (force_auto_save_soon): New decl.
3840
3841 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3842 (DEFINE_DUMMY_FUNCTION): New macro.
3843 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3844 Use it.
3845 (main): Add casts to avoid warnings
3846 if GCC considers string literals to be constants.
3847
3848 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3849
3850 * dbusbind.c: Pointer signedness fixes.
3851 (xd_signature, xd_append_arg, xd_initialize):
3852 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3853 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3854 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3855 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3856
3857 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3858 if GCC considers string literals to be constants.
3859 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3860
3861 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3862
3863 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3864 (print_preprocess, print_object): New macro to fix last change.
3865
3866 * print.c (print_preprocess): Don't forget font objects.
3867
3868 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3869
3870 * emacs.c (USAGE3): Doc fixes.
3871
3872 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3873
3874 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3875 structure.
3876
3877 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3878
3879 * lisp.h (VWindow_system, Qfile_name_history):
3880 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3881 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3882 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3883
3884 * w32select.c: Don't #include "keyboard.h".
3885 (run_protected): Add extern declaration for waiting_for_input.
3886
3887 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3888 * w32console.c (detect_input_pending, read_input_pending)
3889 (encode_terminal_code):
3890 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3891 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3892 (w32_system_caret_y, Qfile_name_history):
3893 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3894 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3895 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3896 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3897 * w32proc.c (Qlocal, report_file_error):
3898 * w32term.c (Vwindow_system, updating_frame):
3899 * w32uniscribe.c (initialized, uniscribe_font_driver):
3900 Remove unneeded extern declarations.
3901
3902 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3903
3904 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3905
3906 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3907
3908 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3909 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3910 These macros can no longer be used for assignment.
3911
3912 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3913 Assign struct members directly, instead of using BUF_BEGV etc.
3914 (record_buffer_markers, fetch_buffer_markers): New functions for
3915 recording and fetching special buffer markers.
3916 (set_buffer_internal_1, set_buffer_temp): Use them.
3917
3918 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3919
3920 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3921
3922 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3923 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3924
3925 * xdisp.c (hscroll_window_tree):
3926 (reconsider_clip_changes): Use PT instead of BUF_PT.
3927
3928 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3929
3930 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3931 $(EMACS_ROOT)/lib/intprops.h.
3932
3933 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 Fix more problems found by GCC 4.5.2's static checks.
3936
3937 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3938 to unsigned char * to avoid compiler diagnostic.
3939 (xg_free_frame_widgets): Make it clear that a local variable is
3940 needed only if USE_GTK_TOOLTIP.
3941 (gdk_window_get_screen): Make it clear that this macro is needed
3942 only if USE_GTK_TOOLTIP.
3943 (int_gtk_range_get_value): New function, which avoids a diagnostic
3944 from gcc -Wbad-function-cast.
3945 (xg_set_toolkit_scroll_bar_thumb): Use it.
3946 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3947 diagnostic from gcc -Wbad-function-cast.
3948 (get_utf8_string, xg_get_file_with_chooser):
3949 Rename locals to avoid shadowing.
3950 (create_dialog): Move locals to avoid shadowing.
3951
3952 * xgselect.c (xg_select): Remove unused var.
3953
3954 * image.c (four_corners_best): Mark locals as initialized.
3955 (gif_load): Initialize transparent_p to zero (Bug#8238).
3956 Mark another local as initialized.
3957 (my_png_error, my_error_exit): Mark with NO_RETURN.
3958
3959 * image.c (clear_image_cache): Now static.
3960 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3961 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3962 (x_edge_detection): Remove unnecessary cast that
3963 gcc -Wbad-function-cast diagnoses.
3964 (gif_load): Fix pointer signedness.
3965 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3966 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3967
3968 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 Improve quality of tests for time stamp overflow.
3971 For example, without this patch (encode-time 0 0 0 1 1
3972 1152921504606846976) returns the obviously-bogus value (-948597
3973 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3974 reports time overflow. See
3975 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3976 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3977 * editfns.c: Include limits.h and intprops.h.
3978 (TIME_T_MIN, TIME_T_MAX): New macros.
3979 (time_overflow): Move earlier, to before first use.
3980 (hi_time, lo_time): New functions, for an accurate test for
3981 out-of-range times.
3982 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3983 (Fget_internal_run_time): Don't assume time_t fits in int.
3984 (make_time): Use list2 instead of Fcons twice.
3985 (Fdecode_time): More accurate test for out-of-range times.
3986 (check_tm_member): New function.
3987 (Fencode_time): Use it, to test for out-of-range times.
3988 (lisp_time_argument): Don't rely on undefined left-shift and
3989 right-shift behavior when checking for time stamp overflow.
3990
3991 * editfns.c (time_overflow): New function, refactoring common code.
3992 (Fformat_time_string, Fdecode_time, Fencode_time):
3993 (Fcurrent_time_string): Use it.
3994
3995 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3996 * dired.c (make_time): Move to ...
3997 * editfns.c (make_time): ... here.
3998 * systime.h: Note the move.
3999
4000 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4001
4002 * fringe.c (update_window_fringes): Remove unused variables.
4003
4004 * unexmacosx.c (copy_data_segment): Also copy __got section.
4005 (Bug#8223)
4006
4007 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4008
4009 * termcap.c [MSDOS]: Include "msdos.h".
4010 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4011 Constify `char *' arguments and their references according to
4012 prototypes in tparam.h.
4013
4014 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4015
4016 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4017 Adapt all references accordingly.
4018
4019 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4020
4021 2011-03-11 Tom Tromey <tromey@redhat.com>
4022
4023 * buffer.c (syms_of_buffer): Remove obsolete comment.
4024
4025 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4026
4027 * termhooks.h (encode_terminal_code): Declare prototype.
4028
4029 * msdos.c (encode_terminal_code): Don't declare prototype.
4030
4031 * term.c (encode_terminal_code): Now external again, used by
4032 w32console.c and msdos.c.
4033
4034 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4035 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4036
4037 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4038
4039 Fix some minor problems found by GCC 4.5.2's static checks.
4040
4041 * fringe.c (update_window_fringes): Mark locals as initialized
4042 (Bug#8227).
4043 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4044
4045 * alloc.c (mark_fringe_data): Move decl from here ...
4046 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4047 to check its interface.
4048 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4049
4050 * fontset.c (free_realized_fontset): Now static.
4051 (Fset_fontset_font): Rename local to avoid shadowing.
4052 (fontset_font): Mark local as initialized.
4053 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4054
4055 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4056
4057 * xselect.c (x_disown_buffer_selections): Remove; not used.
4058 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4059 (x_own_selection, Fx_disown_selection_internal): Rename locals
4060 to avoid shadowing.
4061 (x_handle_dnd_message): Remove local to avoid shadowing.
4062
4063 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4064 so that the caller can use some name other than gcpro1.
4065 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4066 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4067 (Fx_backspace_delete_keys_p):
4068 Use them to avoid shadowing, and rename vars to avoid shadowing.
4069 (x_decode_color, x_set_name, x_window): Now static.
4070 (Fx_create_frame): Add braces to silence GCC warning.
4071 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4072 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4073 Remove unused locals.
4074 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4075 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4076 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4077 macros.
4078
4079 * xterm.h (x_mouse_leave): New decl.
4080
4081 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4082 Remove unused functions.
4083 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4084 (x_calc_absolute_position): Now static.
4085 (XTread_socket): Don't define label "out" unless it's used.
4086 Don't declare local "event" unless it's used.
4087 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4088 unless they are used.
4089 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4090 (x_fatal_error_signal): Remove; not used.
4091 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4092 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4093 (x_error_catcher, x_connection_closed, x_error_handler):
4094 (x_error_quitter, xembed_send_message, x_iconify_frame):
4095 (my_log_handler): Rename locals to avoid shadowing.
4096 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4097 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4098
4099 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4100 Rename or move locals to avoid shadowing.
4101 (tty_defined_color, merge_face_heights): Now static.
4102 (free_realized_faces_for_fontset): Remove; not used.
4103 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4104 does not deduce is never used uninitialized.
4105 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4106 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4107
4108 * terminal.c (store_terminal_param): Now static.
4109
4110 * xmenu.c (menu_highlight_callback): Now static.
4111 (set_frame_menubar): Remove unused local.
4112 (xmenu_show): Rename parameter to avoid shadowing.
4113 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4114 since they might point to immutable storage.
4115 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4116 since it's unused otherwise.
4117
4118 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4119 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4120 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4121 avoids a gcc -Wuninitialized diagnostic.
4122 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4123 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4124 does not deduce are never used uninitialized.
4125
4126 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4127
4128 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4129 * window.c (window_loop, size_window):
4130 (run_window_configuration_change_hook, enlarge_window): Likewise.
4131
4132 * window.c (display_buffer): Now static.
4133 (size_window): Mark variables that gcc -Wuninitialized
4134 does not deduce are never used uninitialized.
4135 * window.h (check_all_windows): New decl, to forestall
4136 gcc -Wmissing-prototypes diagnostic.
4137 * dispextern.h (bidi_dump_cached_states): Likewise.
4138
4139 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4140 shadowing.
4141 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4142 Include <limits.h>.
4143 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4144 and to avoid gcc -Wuninitialized warning.
4145 (load_charset_map): Mark variables that gcc -Wuninitialized
4146 does not deduce are never used uninitialized.
4147 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4148
4149 * coding.c (coding_set_source, coding_set_destination):
4150 Use "else { /* comment */ }" rather than "else /* comment */;"
4151 for clarity, and to avoid gcc -Wempty-body warning.
4152 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4153 a block, when the outer 'i' will do.
4154 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4155 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4156 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4157 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4158 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4159 Rename locals to avoid shadowing.
4160 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4161 * coding.c (emacs_mule_char, encode_invocation_designation):
4162 Now static, since they're not used elsewhere.
4163 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4164 (decode_coding_object, encode_coding_object, detect_coding_system):
4165 (decode_coding_emacs_mule): Mark variables that gcc
4166 -Wuninitialized does not deduce are never used uninitialized.
4167 (detect_coding_iso_2022): Initialize a local variable that might
4168 be used uninitialized. Leave a FIXME because it's not clear that
4169 this initialization is needed. (Bug#8211)
4170 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4171 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4172 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4173 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4174 Remove unused macros.
4175
4176 * category.c (hash_get_category_set): Remove unused local var.
4177 (copy_category_table): Now static, since it's not used elsewhere.
4178 * character.c (string_count_byte8): Likewise.
4179
4180 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4181 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4182
4183 * chartab.c (copy_sub_char_table): Now static, since it's not used
4184 elsewhere.
4185 (sub_char_table_ref_and_range, char_table_ref_and_range):
4186 Rename locals to avoid shadowing.
4187 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4188
4189 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4190 (BIDI_BOB): Remove unused macro.
4191
4192 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4193 deduce are never used uninitialized.
4194 * term.c (encode_terminal_code): Likewise.
4195
4196 * term.c (encode_terminal_code): Now static. Remove unused local.
4197
4198 * tparam.h: New file.
4199 * term.c, tparam.h: Include it.
4200 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4201 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4202 Move these decls to tparam.h, and make them agree with what
4203 is actually in tparam.c. The previous trick of using incompatible
4204 decls in different modules does not conform to the C standard.
4205 All callers of tparam changed to use tparam's actual API.
4206 * tparam.c (tparam1, tparam, tgoto):
4207 Use const pointers where appropriate.
4208
4209 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4210 * cm.h (struct cm): Likewise.
4211 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4212 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4213 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4214 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4215 (turn_on_face, init_tty): Likewise.
4216 * termchar.h (struct tty_display_info): Likewise.
4217
4218 * term.c (term_mouse_position): Rename local to avoid shadowing.
4219
4220 * alloc.c (mark_ttys): Move decl from here ...
4221 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4222
4223 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4224
4225 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4226
4227 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4228
4229 * search.c (compile_pattern_1): Remove argument regp, unused since
4230 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4231 (compile_pattern): Don't pass it.
4232
4233 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4234
4235 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4236 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4237 for ! HAVE_GTK3.
4238 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4239
4240 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4241
4242 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4243 gdk_window_get_screen, gdk_window_get_geometry,
4244 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4245 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4246 (xg_get_pixbuf_from_pixmap): New function.
4247 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4248 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4249 Call xg_get_pixbuf_from_pixmap instead of
4250 gdk_pixbuf_get_from_drawable.
4251 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4252 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4253 (xg_check_special_colors): Use GtkStyleContext and its functions
4254 for HAVE_GTK3.
4255 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4256 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4257 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4258 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4259 Call gtk_widget_get_preferred_size.
4260 (xg_frame_resized): gdk_window_get_geometry only takes 5
4261 parameters.
4262 (xg_win_to_widget, xg_event_is_for_menubar):
4263 Call gdk_x11_window_lookup_for_display.
4264 (xg_set_widget_bg): New function.
4265 (delete_cb): New function.
4266 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4267 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4268 (xg_set_background_color): Call xg_set_widget_bg.
4269 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4270 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4271 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4272 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4273 if ! HAVE_GTK3.
4274 (update_frame_tool_bar): Call gtk_widget_hide.
4275 (xg_initialize): Use GDK_KEY_g.
4276
4277 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4278 if ! HAVE_GTK3
4279 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4280
4281 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4282 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4283 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4284
4285 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4286
4287 * w32xfns.c (select_palette): Check success of RealizePalette against
4288 GDI_ERROR, not zero.
4289
4290 See ChangeLog.11 for earlier changes.
4291
4292 ;; Local Variables:
4293 ;; coding: utf-8
4294 ;; End:
4295
4296 Copyright (C) 2011 Free Software Foundation, Inc.
4297
4298 This file is part of GNU Emacs.
4299
4300 GNU Emacs is free software: you can redistribute it and/or modify
4301 it under the terms of the GNU General Public License as published by
4302 the Free Software Foundation, either version 3 of the License, or
4303 (at your option) any later version.
4304
4305 GNU Emacs is distributed in the hope that it will be useful,
4306 but WITHOUT ANY WARRANTY; without even the implied warranty of
4307 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4308 GNU General Public License for more details.
4309
4310 You should have received a copy of the GNU General Public License
4311 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.