]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Speed up insertion of subprocess output on MS-Windows.
[gnu-emacs] / src / ChangeLog
1 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2
3 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4 first 2 arguments are identical. This makes inserting large
5 output from a subprocess an order of magnitude faster on
6 MS-Windows, where all sbrk'ed memory is always contiguous.
7
8 2012-01-31 Glenn Morris <rgm@gnu.org>
9
10 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
11 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
12 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
13
14 2012-01-29 Glenn Morris <rgm@gnu.org>
15
16 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
17
18 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
19
20 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
21
22 2012-01-28 Chong Yidong <cyd@gnu.org>
23
24 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
25
26 2012-01-26 Chong Yidong <cyd@gnu.org>
27
28 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
29
30 * search.c (Fsearch_forward, Fsearch_backward): Document negative
31 repeat counts (Bug#10507).
32
33 2012-01-26 Glenn Morris <rgm@gnu.org>
34
35 * lread.c (syms_of_lread): Doc fix.
36
37 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
38
39 * coding.c (encode_designation_at_bol): Change return value to
40 EMACS_INT.
41
42 2012-01-25 Chong Yidong <cyd@gnu.org>
43
44 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
45
46 2012-01-21 Chong Yidong <cyd@gnu.org>
47
48 * floatfns.c (Fcopysign): Make the second argument non-optional,
49 since nil is not allowed anyway.
50
51 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
52
53 * process.c (read_process_output): Use p instead of XPROCESS (proc).
54 (send_process): Likewise.
55
56 2012-01-19 Martin Rudalics <rudalics@gmx.at>
57
58 * window.c (save_window_save, Fcurrent_window_configuration)
59 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
60 doc-strings.
61
62 2012-01-19 Kenichi Handa <handa@m17n.org>
63
64 * character.c (char_width): New function.
65 (Fchar_width, c_string_width, lisp_string_width):
66 Use char_width (Bug#9496).
67
68 2012-01-16 Martin Rudalics <rudalics@gmx.at>
69
70 * window.c (Vwindow_persistent_parameters): New variable.
71 (Fset_window_configuration, save_window_save): Handle persistent
72 window parameters.
73
74 2012-01-14 Eli Zaretskii <eliz@gnu.org>
75
76 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
77 thrashing the stack of the thread. (Bug#9087)
78
79 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
80
81 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
82
83 2012-01-11 Eli Zaretskii <eliz@gnu.org>
84
85 * xdisp.c (rows_from_pos_range): Handle the case where the
86 highlight ends on a newline. (Bug#10464)
87 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
88 he end column for display of highlight that ends on a newline
89 before a R2L line.
90
91 2012-01-11 Glenn Morris <rgm@gnu.org>
92
93 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
94 from load-path also when installation-directory is nil. (Bug#10208)
95
96 2012-01-10 Glenn Morris <rgm@gnu.org>
97
98 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
99
100 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
101 Update template values to be closer to their typical values these days.
102
103 2012-01-09 Eli Zaretskii <eliz@gnu.org>
104
105 * xdisp.c (rows_from_pos_range): Accept additional argument
106 DISP_STRING, and accept any glyph in a row whose object is that
107 string as eligible for mouse highlight. Fixes mouse highlight of
108 display strings from overlays. (Bug#10464)
109
110 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
111
112 emacs: fix an auto-save permissions race condition (Bug#10400)
113 * fileio.c (auto_saving_dir_umask): New static var.
114 (Fmake_directory_internal): Use it.
115 (do_auto_save_make_dir): Set it, instead of invoking chmod after
116 creating the directory. The old code temporarily assigns
117 too-generous permissions to the directory.
118 (do_auto_save_eh): Clear it.
119 (Fdo_auto_save): Catch all errors, not just file errors, so
120 that the var is always cleared.
121
122 2012-01-07 Eli Zaretskii <eliz@gnu.org>
123
124 * search.c (scan_buffer): Pass character positions to
125 know_region_cache, not byte positions. (Bug#6540)
126
127 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
128
129 * w32.c (sys_rename): Report EXDEV when rename of a directory
130 fails because the target is on another logical disk. (Bug#10284)
131
132 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
133
134 * xterm.c (x_embed_request_focus): New function.
135
136 * xterm.h: Add prototype.
137
138 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
139
140 2012-01-05 Glenn Morris <rgm@gnu.org>
141
142 * emacs.c (emacs_copyright): Update short copyright year to 2012.
143
144 2012-01-01 Eli Zaretskii <eliz@gnu.org>
145
146 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
147 Load gnutls_transport_set_lowat only if GnuTLS version is below
148 2.11.1.
149 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
150 GnuTLS versions below 2.11.1.
151
152 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
153
154 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
155 to the doc string advising against its use for altering the way
156 windows are scrolled.
157
158 2011-12-28 Kenichi Handa <handa@m17n.org>
159
160 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
161 coding-system ASCII compatible only when it does not produce BOM
162 on encoding (Bug#10383).
163
164 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
165
166 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
167 can scroll.
168 (create_and_show_popup_menu): Always use menu_position_func for
169 Gtk3 (Bug#10361).
170
171 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
172
173 * callint.c (Fcall_interactively): Don't truncate prompt string.
174
175 2011-12-23 Eli Zaretskii <eliz@gnu.org>
176
177 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
178 property that ends at ZV, so that the bidi iteration could be
179 resumed from there (after widening). (Bug#10360)
180
181 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
182
183 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
184
185 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
186
187 * nsterm.m (x_free_frame_resources):
188 Release f->output_data.ns->miniimage.
189 (ns_index_color): Fix indentation. Do not retain
190 color_table->colors[i].
191
192 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
193 before returning.
194
195 * nsfns.m (x_set_background_color): Assign return value from
196 ns_index_color to face-background instead of NSColor*.
197 (ns_implicitly_set_icon_type): Fix indentation.
198 Change assignment in for loop to comparison.
199
200 * emacs.c (ns_pool): New variable.
201 (main): Assign ns_pool.
202 (Fkill_emacs): Call ns_release_autorelease_pool.
203
204 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
205 autorelease fdesc, release fdAttrs and tdict.
206 (ns_get_covering_families): Release charset.
207 (ns_findfonts): Release NSFontDescriptor created with new.
208 (ns_uni_to_glyphs): Fix indentation.
209 (setString): Release attrStr before assigning new value.
210
211 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
212
213 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
214 and NS_IMPL_COCOA.
215 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
216 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
217
218 2011-12-18 David Reitter <reitter@cmu.edu>
219
220 * nsterm.m (ns_term_init): Subscribe for notifications
221 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
222 to method trackingNotification in EmacsMenu.
223
224 * nsmenu.m (trackingMenu): New variable.
225 (trackingNotification): New method (from Aquamacs).
226 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
227 from Aquamacs (Bug#7030).
228
229 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
230
231 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
232 (symbol_to_nsstring): Fix indentation.
233 (ns_symbol_to_pb): New function.
234 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
235 (Fns_rotate_cut_buffers_internal): Removed.
236 (Fns_store_selection_internal): Renamed from
237 Fns_store_cut_buffer_internal.
238 (ns_get_foreign_selection, Fx_own_selection_internal)
239 (Fx_disown_selection_internal, Fx_selection_exists_p)
240 (Fns_get_selection_internal, Fns_store_selection_internal):
241 Use ns_symbol_to_pb and check if return value is nil.
242 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
243 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
244 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
245 renamed to Sns_store_selection_internal.
246 (ns_handle_selection_request): Move code to Fx_own_selection_internal
247 and remove this function.
248 (ns_handle_selection_clear): Remove, never used.
249 (Fx_own_selection_internal): Move code from ns_handle_selection_request
250 here.
251
252 2011-12-17 Ken Brown <kbrown@cornell.edu>
253
254 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
255 GID is unknown (Bug#10257).
256
257 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
258
259 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
260 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
261 which caused a build failure on GNU/Linux IA-64. This problem was
262 introduced by my 2011-10-07 patch.
263
264 2011-12-15 Juri Linkov <juri@jurta.org>
265
266 * image.c (imagemagick_error): New function. (Bug#10112)
267 (imagemagick_load_image): Comment out `MagickSetResolution' call.
268 Use `imagemagick_error' where ImageMagick functions return
269 `MagickFalse'.
270 (Fimagemagick_types): Add `Fnreverse' to return the list in the
271 proper order.
272
273 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
274
275 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
276 fill background (Bug#8992).
277
278 2011-12-13 Martin Rudalics <rudalics@gmx.at>
279
280 * window.c (Vwindow_combination_resize)
281 (Vwindow_combination_limit): Use t instead of non-nil in
282 doc-strings.
283 (Vrecenter_redisplay): Add first sentence of doc-string on
284 separate line.
285 (Frecenter): Fix doc-string typo.
286
287 2011-12-11 Kenichi Handa <handa@m17n.org>
288
289 * coding.c (Funencodable_char_position): Pay attention to the
290 buffer text relocation (Bug#9389).
291
292 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
293
294 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
295 gtk_init (Bug#10100).
296
297 2011-12-10 Eli Zaretskii <eliz@gnu.org>
298
299 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
300 IT->string is nil. (Bug#10263)
301
302 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
303
304 * nsterm.h (x_free_frame_resources): Declare.
305
306 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
307 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
308
309 * nsterm.h (ns_get_defaults_value): Declare.
310
311 * nsterm.m (ns_default): Call ns_get_defaults_value.
312
313 2011-12-09 Eli Zaretskii <eliz@gnu.org>
314
315 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
316 (Bug#10170)
317
318 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
319
320 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
321 that where the value of an _OBJC_* symbol points to is in the .bss
322 section (Bug#10240).
323
324 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
325
326 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
327 after the loop to call ccl_driver at least once (Bug#8619).
328
329 2011-12-08 Kenichi Handa <handa@m17n.org>
330
331 * ftfont.c (get_adstyle_property): Fix previous change
332 (Bug#10233).
333
334 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
335
336 * w32.c (init_environment): If no_site_lisp, remove site-lisp
337 dirs from the default value of EMACSLOADPATH (bug#10208).
338
339 2011-12-07 Glenn Morris <rgm@gnu.org>
340
341 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
342 installation and source directories as well. (Bug#10208)
343
344 2011-12-06 Chong Yidong <cyd@gnu.org>
345
346 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
347
348 2011-12-06 Glenn Morris <rgm@gnu.org>
349
350 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
351 as an error, not just -1. (Bug#10217)
352
353 2011-12-05 Chong Yidong <cyd@gnu.org>
354
355 * keyboard.c (process_special_events): New function.
356 (swallow_events, Finput_pending_p): Use it (Bug#10195).
357
358 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
359
360 * coding.c (encode_designation_at_bol): Don't use uninitialized
361 local variable (Bug#9318).
362
363 2011-12-05 Kenichi Handa <handa@m17n.org>
364
365 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
366 return Qnil (Bug#8046, Bug#10193).
367
368 2011-12-05 Kenichi Handa <handa@m17n.org>
369
370 * coding.c (encode_designation_at_bol): New args charbuf_end and
371 dst. Return the number of produced bytes. Callers changed.
372 (coding_set_source): Return how many bytes coding->source was
373 relocated.
374 (coding_set_destination): Return how many bytes
375 coding->destination was relocated.
376 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
377 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
378
379 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
380
381 * coding.c (CODING_CHAR_CHARSET_P): New macro.
382 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
383 macro (Bug#9318).
384
385 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
386
387 The following changes are to fix Bug#9318.
388
389 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
390 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
391 (encode_coding_iso_2022, encode_coding_sjis)
392 (encode_coding_big5, encode_coding_charset): Use the above macros.
393
394 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
395
396 * lisp.h (process_quit_flag): Fix external declaration.
397
398 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
399
400 Don't macro-inline non-performance-critical code.
401 * eval.c (process_quit_flag): New function.
402 * lisp.h (QUIT): Use it.
403
404 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
405
406 * nsfns.m (get_geometry_from_preferences): New function.
407 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
408
409 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
410
411 * emacs.c (Qkill_emacs): Define.
412 (syms_of_emacs): Initialize it.
413 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
414 Qquit_flag to `kill-emacs' instead.
415 (quit_throw_to_read_char): Add parameter `from_signal'.
416 All callers changed. Call Fkill_emacs if requested and safe.
417 * lisp.h (QUIT): Call Fkill_emacs if requested.
418
419 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
420
421 * widget.c (update_wm_hints): Return if wmshell is null.
422 (widget_update_wm_size_hints): New function.
423
424 * widget.h (widget_update_wm_size_hints): Declare.
425
426 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
427 widget_update_wm_size_hints (Bug#10104).
428
429 2011-12-03 Eli Zaretskii <eliz@gnu.org>
430
431 * xdisp.c (handle_invisible_prop): If the invisible text ends just
432 before a newline, prepare the bidi iterator for consuming the
433 newline, and keep the current paragraph direction. (Bug#10183)
434 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
435
436 2011-12-02 Juri Linkov <juri@jurta.org>
437
438 * search.c (Fword_search_regexp): New Lisp function created from
439 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
440 (Fword_search_backward, Fword_search_forward)
441 (Fword_search_backward_lax, Fword_search_forward_lax):
442 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
443 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
444
445 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
446
447 * fileio.c (Finsert_file_contents): Move after-change-function call
448 to before the "handled:" label, since all "goto handled" appear in
449 cases where the *-change-functions have already been properly called
450 (bug#10117).
451
452 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
453
454 * keyboard.c (interrupt_signal): Don't call kill-emacs when
455 waiting for input. (Bug#10169)
456
457 2011-11-30 Eli Zaretskii <eliz@gnu.org>
458
459 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
460 verifies glyph row's hash code--we have just reallocated the
461 glyphs, so their contents can be complete garbage. (Bug#10164)
462
463 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
464
465 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
466
467 2011-11-30 Eli Zaretskii <eliz@gnu.org>
468
469 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
470 attributes are tested _before_ calling verify_row_hash, to protect
471 against GCC re-ordering of the tests. (Bug#10164)
472
473 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
474
475 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
476
477 * xterm.c (handle_one_xevent): Only set async_visible and friends
478 if net_wm_state_hidden_seen is non-zero (Bug#10002)
479 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
480 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
481
482 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
483
484 Remove GCPRO-related macros that exist only to avoid shadowing locals.
485 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
486 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
487 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
488 All uses changed to use GCPRO1 etc.
489 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
490 Revert to old implementation (i.e., before 2011-03-11).
491
492 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
493
494 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
495 of scroll runs so as to avoid assigning disabled bogus rows and
496 unnecessary graphics copy operations.
497
498 2011-11-27 Eli Zaretskii <eliz@gnu.org>
499
500 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
501 (snprintf) [_MSC_VER]: Redirect to _snprintf.
502 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
503 (malloc, free, realloc, calloc): Redirect to e_* only when
504 compiling Emacs.
505
506 * lisp.h (GCTYPEBITS): Move before first use.
507 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
508 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
509 this macro definition.
510
511 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
512 _MSC_VER.
513
514 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
515
516 * gtkutil.c (xg_create_frame_widgets):
517 Call gtk_window_set_has_resize_grip (FALSE) if that function is
518 present with Gtk+ 2.0.
519
520 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
521
522 * fileio.c (Finsert_file_contents): Undo previous change; see
523 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
524
525 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
526
527 Rename locals to avoid shadowing.
528 * fileio.c (Finsert_file_contents):
529 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
530 * process.c (wait_reading_process_output):
531 Rename inner 'proc' to 'p' to avoid shadowing.
532 Indent for consistency with usual Emacs style.
533
534 2011-11-25 Eli Zaretskii <eliz@gnu.org>
535
536 * xdisp.c (redisplay_window): If cursor row is not fully visible
537 after recentering, and scroll-conservatively is set to a large
538 number, scroll window by a few more lines to make the cursor fully
539 visible and out of scroll-margin. (Bug#10105)
540 (start_display): Don't move to the next line if the display should
541 start at a newline that is part of a display vector or an overlay
542 string. (Bug#10119)
543
544 2011-11-24 Juri Linkov <juri@jurta.org>
545
546 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
547 after the `MagickPingImage' call. (Bug#10112)
548
549 2011-11-23 Chong Yidong <cyd@gnu.org>
550
551 * window.c (Fcoordinates_in_window_p): Accept only live windows.
552
553 2011-11-23 Martin Rudalics <rudalics@gmx.at>
554
555 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
556 making another buffer current. (Bug#10114)
557
558 2011-11-23 Glenn Morris <rgm@gnu.org>
559
560 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
561
562 2011-11-23 Chong Yidong <cyd@gnu.org>
563
564 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
565 using it (Bug#5984).
566
567 2011-11-22 Eli Zaretskii <eliz@gnu.org>
568
569 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
570 and header-lines, as they don't have one computed for them.
571 (Bug#10098)
572
573 * .gdbinit (prow): Make displayed values more self-explaining.
574 Add row's hash code.
575
576 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
577
578 * process.c (wait_reading_process_output): Fix asynchrounous
579 GnuTLS socket handling on some versions of the GnuTLS library.
580 (wait_reading_process_output): Add comment and URL.
581
582 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
583
584 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
585
586 2011-11-21 Chong Yidong <cyd@gnu.org>
587
588 * window.c (Fnext_window, Fprevious_window): Doc fix.
589
590 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
591
592 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
593
594 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
595
596 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
597
598 2011-11-20 Martin Rudalics <rudalics@gmx.at>
599
600 * window.c (Fset_window_combination_limit): Rename argument
601 STATUS to LIMIT.
602 (Vwindow_combination_limit): Remove "status" from doc-string.
603
604 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
605
606 * m/ibms390.h: Remove.
607 * m/ibms390x.h: Don't include "ibms390.h".
608
609 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
610
611 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
612 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
613
614 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
615
616 * casetab.c (Fset_case_table):
617 * charset.c (Fcharset_after): Fix typos.
618
619 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
620
621 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
622 Otherwise, valgrind does not work on some platforms.
623 Problem reported by Andreas Schwab in
624 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
625 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
626 is set, removing the need for VIRT_ADDRESS_VARIES.
627 (PURE_P): Use a more-efficient implementation that needs just one
628 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
629 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
630 to 4 (xorl, subq, cmpq, setbe).
631 * alloc.c (pure): Always extern now, since that's the
632 VIRT_ADDR_VARIES behavior.
633 (PURE_POINTER_P): Use a single comparison, not two, for
634 consistency with the new puresize.h.
635 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
636 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
637 Remove VIRT_ADDR_VARIES no longer needed.
638
639 2011-11-19 Eli Zaretskii <eliz@gnu.org>
640
641 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
642 (erase_phys_cursor, update_window_cursor, show_mouse_face)
643 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
644 behave as if the cursor position were at the window margin.
645
646 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
647 and the cursor position is out of bounds, behave as if the cursor
648 position were at the window margin. (Bug#10075)
649
650 2011-11-18 Chong Yidong <cyd@gnu.org>
651
652 * window.c (Fwindow_combination_limit): Make first argument
653 non-optional, since it is meaningless for live windows like the
654 selected window.
655
656 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
657
658 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
659
660 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
661
662 * intervals.c: Fix grafting over the whole buffer (bug#10071).
663 (graft_intervals_into_buffer): Simplify.
664
665 2011-11-18 Eli Zaretskii <eliz@gnu.org>
666
667 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
668 hash values of the two rows.
669 (copy_row_except_pointers): Preserve the used[] arrays and the
670 hash values of the two rows. (Bug#10035)
671 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
672
673 * xdisp.c (row_hash): New function, body extracted from
674 compute_line_metrics.
675 (compute_line_metrics): Call row_hash, instead of computing the
676 hash code inline.
677
678 * dispnew.c (verify_row_hash): Call row_hash for computing the
679 hash code of a row, instead of duplicating code from xdisp.c.
680
681 * dispextern.h (row_hash): Add prototype.
682
683 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
684
685 * frame.c (delete_frame): Don't delete the terminal when the last
686 X frame is closed if emacs is built with GTK toolkit.
687
688 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
689
690 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
691
692 2011-11-17 Martin Rudalics <rudalics@gmx.at>
693
694 * window.c (Vwindow_splits): Rename to
695 Vwindow_combination_resize. Suggested by Juri Linkov.
696 (Fsplit_window_internal): Use Vwindow_combination_resize instead
697 of Vwindow_splits.
698
699 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
700
701 * nsfns.m (Fns_font_name):
702 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
703
704 2011-11-16 Martin Rudalics <rudalics@gmx.at>
705
706 * window.h (window): Rename slot "nest" to "combination_limit".
707 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
708 (Fset_window_nest): Rename to Fset_window_combination_limit.
709 (Vwindow_nest): Rename to Vwindow_combination_limit.
710 (recombine_windows, make_parent_window, make_window)
711 (Fsplit_window_internal, saved_window)
712 (Fset_window_configuration, save_window_save): Rename all
713 occurrences of window_nest to window_combination_limit.
714
715 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
716
717 * image.c (imagemagick_load_image): Fix typo.
718
719 2011-11-14 Eli Zaretskii <eliz@gnu.org>
720
721 * xdisp.c (display_line): Move the call to
722 highlight_trailing_whitespace before the call to
723 compute_line_metrics, since the latter needs to see the final
724 faces of all the glyphs to compute ROW's hash value.
725 Fixes assertion violations in row_equal_p. (Bug#10035)
726
727 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
728
729 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
730 just return (bug#10044).
731
732 2011-11-12 Eli Zaretskii <eliz@gnu.org>
733
734 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
735 with user-defined heap size. Bump the default size of the temacs
736 heap to 27MB, to avoid memory warning when running temacs.
737 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
738
739 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
740 current_matrix and desired_matrix. (Bug#9990)
741 (verify_row_hash) [XASSERTS]: New function.
742 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
743 that the hash value of glyph rows is correct.
744
745 2011-11-12 Martin Rudalics <rudalics@gmx.at>
746
747 * window.h (window): Remove splits slot.
748 * window.c (Fwindow_splits, Fset_window_splits): Remove.
749 (Fdelete_other_windows_internal, make_parent_window)
750 (make_window, Fsplit_window_internal, Fdelete_window_internal)
751 (Fset_window_configuration, save_window_save): Don't deal with
752 split status of windows.
753 (saved_window): Remove splits slot.
754 (Vwindow_splits): Rewrite doc-string.
755
756 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
757
758 * xfns.c (unwind_create_frame):
759 * nsfns.m (unwind_create_frame):
760 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
761 Vframe_list (Bug#9999).
762
763 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
764
765 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
766
767 2011-11-11 Kenichi Handa <handa@m17n.org>
768
769 * callproc.c (Fcall_process): Set the member dst_multibyte of
770 process_coding.
771
772 2011-11-11 Johan Bockgård <bojohan@gnu.org>
773
774 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
775 avoid a crash (bug#9496).
776
777 2011-11-09 Chong Yidong <cyd@gnu.org>
778
779 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
780 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
781
782 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
783
784 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
785
786 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
787
788 Avoid some portability problems by eschewing 'extern inline' functions.
789 The trivial performance wins aren't worth the portability hassles; see
790 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
791 et seq.
792 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
793 (window_box_width, window_box_left, window_box_left_offset)
794 (window_box_right, window_box_right_offset): Undo previous change,
795 by removing the "extern"s.
796 * intervals.c (adjust_intervals_for_insertion)
797 (adjust_intervals_for_deletion): Undo previous change,
798 making these static again.
799 (offset_intervals, temp_set_point_both, temp_set_point)
800 (copy_intervals_to_string): No longer inline.
801 * xdisp.c (window_text_bottom_y, window_box_width)
802 (window_box_height, window_box_left_offset)
803 (window_box_right_offset, window_box_left, window_box_right)
804 (window_box): No longer inline.
805
806 2011-11-08 Chong Yidong <cyd@gnu.org>
807
808 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
809 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
810 Signal an error if not a live window.
811 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
812 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
813
814 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
815
816 * lisp.h (syms_of_abbrev): Remove declaration.
817 Reported by CHENG Gao <chenggao@royau.me>.
818
819 2011-11-07 Eli Zaretskii <eliz@gnu.org>
820
821 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
822 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
823 of temacs in GUI mode.
824
825 2011-11-07 Martin Rudalics <rudalics@gmx.at>
826
827 * window.h: Declare delete_all_child_windows instead of
828 delete_all_subwindows.
829 * window.c (Fwindow_nest, Fset_window_nest)
830 (Fset_window_new_total, Fset_window_new_normal)
831 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
832 (delete_all_subwindows): Rename to delete_all_child_windows.
833 (Fdelete_other_windows_internal, Fset_window_configuration):
834 Call delete_all_child_windows instead of delete_all_subwindows.
835 * frame.c (delete_frame): Call delete_all_child_windows instead
836 of delete_all_subwindows.
837
838 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
839
840 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
841 This is also needed for porting to any host where GC_MARK_STACK is
842 not GC_MAKE_GCPROS_NOOPS.
843 (which_symbols): Use it.
844
845 2011-11-07 Kenichi Handa <handa@m17n.org>
846
847 * coding.c (coding_set_destination): Check coding->src_pos only
848 when coding->src_object is a buffer (bug#9910).
849
850 * process.c (send_process): Set the member src_multibyte of coding
851 to 0 (bug#9911) when sending a unibyte text.
852
853 * callproc.c (Fcall_process): Set the member src_multibyte of
854 process_coding to 0 (bug#9912).
855
856 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
857
858 * xmenu.c (cleanup_widget_value_tree): New function.
859 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
860 calling free_menubar_widget_value_tree directly (Bug#9830).
861
862 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
863
864 Fix some portability problems with 'inline'.
865 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
866 (window_box_width, window_box_left, window_box_left_offset)
867 (window_box_right, window_box_right_offset): Declare extern.
868 Otherwise, these inline functions do not conform to C99 and
869 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
870 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
871 * intervals.c (adjust_intervals_for_insertion)
872 (adjust_intervals_for_deletion): Now extern, because otherwise the
873 extern inline functions 'offset_intervals' couldn't refer to it.
874 (static_offset_intervals): Remove.
875 (offset_intervals): Rewrite using the old contents of
876 static_offset_intervals. The old version didn't conform to C99
877 because an extern inline function contained a reference to an
878 identifier with static linkage.
879
880 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
881
882 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
883 GC.
884
885 2011-11-06 Eli Zaretskii <eliz@gnu.org>
886
887 * xdisp.c (init_iterator, reseat_to_string): Don't set the
888 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
889 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
890 return Qleft_to_right.
891
892 2011-11-06 Chong Yidong <cyd@gnu.org>
893
894 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
895 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
896 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
897 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
898 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
899 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
900 (Fwindow_vscroll): Doc fix.
901 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
902 argument, since it makes no sense to pass a live window and for
903 consistency with window-child.
904
905 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
906
907 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
908 support MSVC.
909
910 2011-11-05 Jason Rumney <jasonr@gnu.org>
911
912 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
913 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
914 fonts (Bug#6029).
915 (add_font_entity_to_list): Fix logic errors in mixed boolean and
916 bitwise arithmetic preventing use of unicode-sip and non-truetype
917 opentype fonts.
918
919 2011-11-05 Eli Zaretskii <eliz@gnu.org>
920
921 * s/ms-w32.h (fstat, stat, utime): Move redirections to
922 "emacs"-only part.
923
924 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
925 initialization code to keep similarity to xfns.c after changes
926 from 2011-11-05.
927
928 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
929
930 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
931 (unwind_create_frame): New function (Bug#9943).
932 (Fx_create_frame): Restructure code to be more similar to the one in
933 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
934 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
935 Move terminal->reference_count++ just before making the frame official
936 (Bug#9943).
937
938 * nsterm.m (x_free_frame_resources): New function.
939 (x_destroy_window): Move code to x_free_frame_resources.
940
941 * xfns.c (unwind_create_frame): Fix comment.
942 (Fx_create_frame, x_create_tip_frame):
943 Move terminal->reference_count++ just before making the frame
944 official. Move initialization of image_cache_refcount and
945 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
946
947 2011-11-05 Eli Zaretskii <eliz@gnu.org>
948
949 Support MSVC build with newer versions of Visual Studio.
950 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
951 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
952 nt/gmake.defs.
953
954 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
955 which are not supported by MSVC.
956 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
957 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
958 bitfields.
959 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
960 types in bitfields.
961 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
962
963 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
964
965 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
966
967 Support MSVC build with newer versions of Visual Studio.
968 * w32.c: Don't include w32api.h for MSVC.
969 (init_environment) [_MSC_VER]: Call sys_access, not _access.
970
971 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
972 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
973 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
974 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
975 e_* cousins.
976 (alloca) [_MSC_VER]: Define to _alloca.
977
978 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
979
980 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
981
982 2011-11-04 Eli Zaretskii <eliz@gnu.org>
983
984 * xdisp.c (note_mouse_highlight): If either of
985 previous/next-single-property-change returns nil, treat that as
986 the beginning or the end of the buffer. (Bug#9955)
987
988 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
989
990 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
991 label is not null (Bug#9951).
992 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
993 may be NULL.
994
995 2011-11-04 Eli Zaretskii <eliz@gnu.org>
996
997 * window.c (Fwindow_body_size): Mention in the doc string that the
998 return value is in frame's canonical units. (Bug#9949)
999
1000 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1001
1002 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1003
1004 * w32fns.c (unwind_create_frame): If needed, free the glyph
1005 matrices of the partially constructed frame. (Bug#9943)
1006 * xfns.c (unwind_create_frame): Likewise.
1007
1008 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1009
1010 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1011 Don't stop backward scan on the continuation glyph, even though
1012 its CHARPOS is positive.
1013 (mouse_face_from_buffer_pos, note_mouse_highlight):
1014 Rename cover_string to disp_string.
1015
1016 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1017
1018 * window.c (temp_output_buffer_show): Don't use
1019 Vtemp_buffer_show_specifiers.
1020 (Vtemp_buffer_show_specifiers): Remove unused variable.
1021
1022 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1023
1024 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1025 past the beginning of the current glyph matrix.
1026
1027 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1028
1029 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1030 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1031 HAVE_GTK3 (Bug#9869).
1032
1033 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1034 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1035
1036 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1037
1038 * xterm.c: Declare x_handle_net_wm_state to return int.
1039 (handle_one_xevent): Check if we are iconified but don't have
1040 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1041 (get_current_wm_state): Return non-zero if not hidden,
1042 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1043 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1044 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1045 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1046
1047 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1050 so that this new function doesn't get optimized away by a
1051 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1052
1053 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1054
1055 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1056
1057 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1058
1059 Fix the `xbytecode' command.
1060 * .gdbinit (xprintbytestr): New command.
1061 (xwhichsymbols): Rename from `which'; all callers changed.
1062 (xbytecode): Print the byte-code string as well.
1063
1064 2011-10-29 Kim Storm <storm@cua.dk>
1065
1066 * alloc.c (which_symbols): New function.
1067
1068 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1069
1070 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1071 line. (Bug#9903)
1072
1073 2011-10-29 Glenn Morris <rgm@gnu.org>
1074
1075 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1076 Not clear what it was for, and it causes various bugs. (Bug#9839)
1077
1078 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1079
1080 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1081 possible random value that matches one of those tested as
1082 condition to clear the mouse face.
1083
1084 2011-10-28 Chong Yidong <cyd@gnu.org>
1085
1086 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1087
1088 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1089
1090 * window.c (make_window): Initialize phys_cursor_on_p.
1091
1092 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1093
1094 * lisp.h (struct Lisp_Symbol): Update comments.
1095
1096 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1097
1098 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1099
1100 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1101
1102 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1103 <oslsachem@gmail.com> for helping to debug this.
1104
1105 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1106 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1107 (g_b_init_get_glyph_outline_w): New static variables.
1108 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1109 (GetGlyphOutlineW_Proc): New typedefs.
1110 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1111 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1112 New functions.
1113 (w32font_open_internal, compute_metrics):
1114 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1115 instead of calling the "wide" APIs directly.
1116
1117 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1118
1119 * w32.h (syms_of_w32font): Add prototype.
1120
1121 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1122
1123 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1124 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1125 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1126 (Fmove_to_window_line): Doc fix.
1127
1128 2011-10-27 Chong Yidong <cyd@gnu.org>
1129
1130 * process.c (make_process): Set gnutls_state to NULL.
1131
1132 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1133 non-NULL, regardless of GNUTLS_INITSTAGE.
1134 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1135 an error. Set process slots as soon as we allocate them.
1136
1137 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1138
1139 2011-10-27 Chong Yidong <cyd@gnu.org>
1140
1141 * gnutls.c (emacs_gnutls_deinit): New function.
1142 Deallocate credentials structures as well as calling gnutls_deinit.
1143 (Fgnutls_deinit, Fgnutls_boot): Use it.
1144
1145 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1146 (deactivate_process): Call emacs_gnutls_deinit.
1147
1148 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1149
1150 * image.c (x_create_x_image_and_pixmap):
1151 * w32.c (sys_rename, w32_delayed_load):
1152 * w32font.c (fill_in_logfont):
1153 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1154
1155 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1156
1157 * w32fns.c (w32_default_color_map): New function,
1158 extracted from Fw32_default_color_map.
1159 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1160
1161 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1164
1165 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1166
1167 * keyboard.c (test_undefined): New function (bug#9751).
1168 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1169
1170 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1171
1172 * sysdep.c (init_sys_modes): Fix the check for the controlling
1173 terminal (Bug#6649).
1174
1175 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1176
1177 * dispextern.h (struct bidi_it): New member next_en_type.
1178
1179 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1180 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1181 current character, check also for next_en_type being WEAK_EN.
1182 (bidi_resolve_weak): Don't enter the expensive loop if the current
1183 position is before next_en_pos. Record the bidi type of the first
1184 non-ET, non-BN character we find, in addition to its position.
1185 (bidi_level_of_next_char): Invalidate next_en_type when
1186 next_en_pos is over-stepped.
1187
1188 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1189
1190 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1191 * editfns.c: Rewrite current-time-zone so that it invokes
1192 the equivalent of (format-time-string "%Z") to get the time zone name.
1193 This fixes a bug when the time zone name contains characters that
1194 need converting from the system time locale to Emacs internal format.
1195 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1196 that patch fixed format-time-string to do the conversion, but
1197 I forgot to fix current-time-zone.
1198 (format_time_string): New function, containing most of
1199 what Fformat_time_string used to contain.
1200 (Fformat_time_string): Rewrite in terms of format_time_string.
1201 This doesn't change this function's behavior.
1202 (current-time-zone): Rewrite to use format_time_string.
1203 This fixes the bug reported by Michael Schierl in
1204 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1205 Jason Rumney's 2007-06-07 change worked around this bug, but
1206 didn't fix it.
1207 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1208
1209 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1210
1211 * xdisp.c (start_display): If the character at POS is displayed
1212 via a display vector, reset IT->current.dpvec_index to zero.
1213 (try_window_reusing_current_matrix): If a line ends in a display
1214 vector or the next line starts in a display vector, continue
1215 redrawing the window even though the character position of
1216 start_row was reached.
1217 (Bug#9771, part 2)
1218
1219 2011-10-18 Chong Yidong <cyd@gnu.org>
1220
1221 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1222 with nobreak-char-display too.
1223
1224 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1225
1226 Fix part 3 of bug#9771.
1227 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1228 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1229 non-neutral characters if the current character is a paragraph
1230 separator (a.k.a. Newline). This avoids running the same
1231 expensive loop twice, once when we consume the preceding newline
1232 and the other time when the line actually needs to be displayed.
1233 Avoid the loop when we see neutrals on the base embedding level
1234 following a character whose directionality is the same as the
1235 paragraph's. This avoids running the expensive loop when a line
1236 ends in a long sequence of neutrals, like control characters.
1237 Add assertion against STRONG_AL type. Slightly rearrange code
1238 that determines the type of a neutral given the first non-neutral
1239 that follows it.
1240 (bidi_level_of_next_char): Set next_en_pos to zero when
1241 invalidating its info.
1242
1243 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1244
1245 * xdisp.c (push_display_prop): Determine whether to record string
1246 or buffer position by IT->string, not by IT->method. Allow
1247 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1248 (move_it_vertically_backward): Don't look for character position
1249 immediately after the newline when in a continuation line.
1250 (Bug#9771, part 1)
1251
1252 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1253
1254 * window.c (coordinates_in_window): Rewrite and delabelize
1255 vertical border check. (Bug#5357) (Bug#9618)
1256
1257 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1258
1259 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1260 errors in XSetWindowBorder (bug#9310).
1261
1262 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1263
1264 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1265 avoid crash when xmalloc overrun checking is enabled.
1266
1267 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1268
1269 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1270 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1271 cursor motion with <left> and <right> arrow keys.
1272
1273 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1274 some callers set that themselves.
1275
1276 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1277
1278 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1279 display string and the previous row comes from the same string and
1280 is empty. (Bug#9739) (Bug#9738)
1281
1282 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1283
1284 * doc.c (get_doc_string): Encode file name (bug#9735).
1285
1286 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1287
1288 * bidi.c (bidi_level_of_next_char):
1289 * xdisp.c (get_visually_first_element): Remove old incorrect
1290 comments regarding the Unicode Line Separator character.
1291
1292 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1293
1294 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1295
1296 * alloc.c (Fgc_status): Do not access beyond zombies array
1297 boundary if nzombies > MAX_ZOMBIES.
1298 * alloc.c (dump_zombies): Add missing format specifier.
1299
1300 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1303 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1304
1305 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1306 Some packages use them to denote characters with modifiers.
1307
1308 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1309
1310 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1311 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1312 matching a pp-number. Rename parameter var to var1.
1313
1314 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1315
1316 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1317
1318 2011-10-08 Glenn Morris <rgm@gnu.org>
1319
1320 * callint.c (Fcall_interactively): Give a more explicit error for the
1321 'c' case with a non-character input. (Bug#8479)
1322
1323 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1324
1325 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1326 lines.
1327 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1328 lines that are hscrolled on the left.
1329
1330 * dispnew.c (buffer_posn_from_coords): Account for a possible
1331 presence of header-line. (Bug#4426)
1332
1333 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1334
1335 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1336 Don't advertise functionality which we discourage or doesn't work.
1337
1338 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1341 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1342 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1343 this makes Emacs dump core during garbage collection on rare
1344 occasions. sizeof is obviously inferior to offsetof here, so
1345 stick with offsetof.
1346 (GC_POINTER_ALIGNMENT): New macro.
1347 (mark_memory): Omit 3rd (offset) arg; caller changed.
1348 Don't assume EMACS_INT alignment is the same as pointer alignment.
1349
1350 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1351
1352 * keyboard.c (read_key_sequence_remapped): New var.
1353 (read_key_sequence): Compute remapping in the right buffer.
1354 (command_loop_1): Use read_key_sequence's remapping directly.
1355
1356 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1357
1358 * dired.c (file_name_completion): Don't expand file name.
1359 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1360 before checking file name handler.
1361
1362 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1363 they've been requested explicitly (bug#9591).
1364
1365 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1366
1367 * keymap.c (Fsingle_key_description): Use make_specified_string
1368 instead of build_string to build string from push_key_description.
1369 (Bug#5193)
1370
1371 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1372
1373 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1374 This fixes a Y2038 bug on 64-bit hosts.
1375 * buffer.c (reset_buffer):
1376 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1377 (Fclear_buffer_auto_save_failure):
1378 Use 0, not -1, to represent an unset failure time, since time_t
1379 might not be signed.
1380
1381 Remove dependency on glibc malloc internals.
1382 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1383 Move back here from lisp.h, but with their new implementations.
1384 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1385 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1386 * charset.c (charset_table_init): New static var.
1387 (syms_of_charset): Use it instead of xmalloc. This removes a
1388 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1389 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1390 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1391 Move back to alloc.c.
1392 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1393 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1394
1395 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1396
1397 * nsterm.m (windowDidResize): Call x_set_window_size only when
1398 ns_in_resize is true. Otherwise set pixelwidth/height and
1399 call change_frame_size (Bug#9628).
1400
1401 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 Port --enable-checking=all to Fedora 14 x86-64.
1404 * charset.c (syms_of_charset): Also account for glibc malloc's
1405 internal overhead when calculating the initial malloc maximum.
1406
1407 Port --enable-checking=all to Fedora 14 x86.
1408 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1409 Move to lisp.h.
1410 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1411 (overrun_check_realloc, overrun_check_free):
1412 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1413 That way, xmalloc returns a properly-aligned pointer even if
1414 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1415 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1416 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1417 into account when calculating the initial malloc maximum.
1418 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1419 Move here from alloc.c, so that charset.c can use it too.
1420 Properly align; the old code wasn't right for common 32-bit hosts
1421 when configured with --enable-checking=all.
1422 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1423 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1424
1425 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1426
1427 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1428 use EDOM.
1429
1430 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1431
1432 * xdisp.c (compute_display_string_end): If there's no display
1433 string at CHARPOS, return -1.
1434
1435 * bidi.c (bidi_fetch_char): When compute_display_string_end
1436 returns a negative value, treat the character as a normal
1437 character not covered by a display string. (Bug#9624)
1438
1439 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1440
1441 * lread.c (Fread_from_string): Fix typo in docstring.
1442
1443 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1444
1445 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1446 newline, reseat the iterator instead of bidi-iterating there one
1447 character at a time. (Bug#9610)
1448 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1449 TO_CHARPOS if the bidi iterator is at base embedding level.
1450
1451 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1452
1453 * lread.c (readevalloop): Use correct code for NBSP.
1454 (read1): Likewise. (Bug#9608)
1455
1456 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1457
1458 * dbusbind.c (Fdbus_register_signal): When service is not
1459 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1460
1461 2011-09-25 Glenn Morris <rgm@gnu.org>
1462
1463 * buffer.c (truncate-lines): Doc fix.
1464
1465 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1466
1467 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1468 (Fset_window_next_buffers): Doc fix.
1469
1470 2011-09-24 Glenn Morris <rgm@gnu.org>
1471
1472 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1473
1474 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 Fix minor problems found by static checking.
1477 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1478 * indent.c (Fvertical_motion): Fix == vs = typo.
1479
1480 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1481
1482 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1483 Default value is now t. Doc fix.
1484
1485 * indent.c (Fvertical_motion): Compute and apply the overshoot
1486 logic when moving up, not only when moving down. Fix the
1487 confusing name and values of the it_overshoot_expected variable;
1488 logic changes accordingly. (Bug#9254) (Bug#9549)
1489
1490 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1491 CHARPOS is covered by a display string which includes newlines.
1492 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1493 is covered by a display string with embedded newlines.
1494
1495 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1496
1497 * dbusbind.c (Fdbus_register_signal): Add match rule to
1498 Vdbus_registered_objects_table. (Bug#9581)
1499 (Fdbus_register_method, Vdbus_registered_objects_table):
1500 Fix docstring.
1501
1502 2011-09-24 Jim Meyering <meyering@redhat.com>
1503
1504 do not ignore write error for any output size
1505 The previous change was incomplete.
1506 While it makes emacs --batch detect the vast majority of stdout
1507 write failures, errors were still ignored whenever the output size is
1508 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1509 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1510 && echo FAIL: ignored write error
1511 FAIL: ignored write error
1512 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1513 && echo FAIL: ignored write error
1514 FAIL: ignored write error
1515 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1516
1517 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1518
1519 * emacs.c (Fkill_emacs): In noninteractive mode exit
1520 non-successfully if a write error occurred on stdout. (Bug#9574)
1521
1522 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1523
1524 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1525 the xassert test.
1526
1527 * dispextern.h (struct it): Update the comment documenting what
1528 can it->OBJECT be.
1529
1530 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1531
1532 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1533 a display string, extend search for cursor position to end of row.
1534 (find_row_edges): If the row ends in a newline from a display
1535 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1536 Handle the case of a display string with multiple newlines.
1537 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1538 non-empty line. Fixes confusing cursor motion with arrow keys at
1539 the beginning of a line that starts with whitespace.
1540
1541 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1542
1543 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1544 (bug#9493).
1545
1546 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1547
1548 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1549 boolean (Bug#9154).
1550
1551 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1552
1553 * xdisp.c (display_line): Record maximum and minimum buffer
1554 positions even if no glyphs were produced (e.g., by a zero-width
1555 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1556 buffer positions that will be removed from the glyph row because
1557 they don't fit.
1558 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1559 column is beyond frame width: don't subtract 1 "pixel" when
1560 computing width of the stretch.
1561 (reseat_at_next_visible_line_start): Undo the change made on
1562 2011-09-17 that saved paragraph information and restored it after
1563 the call to `reseat'. (Bug#9545)
1564
1565 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1566
1567 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1568 and turn window cursor on if cleared (Bug#9415).
1569
1570 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1571
1572 * search.c (boyer_moore): Take unibyte characters from pattern
1573 literally. (Bug#9458)
1574
1575 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1576
1577 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1578
1579 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 Fix minor problem found by static checking.
1582 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1583 initialized, to pacify gcc -Wuninitialized.
1584
1585 * fileio.c: Report proper errno when syscall falls.
1586 (Finsert_file_contents): Save and restore errno,
1587 so that report_file_error outputs the correct diagnostic.
1588 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1589
1590 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1591
1592 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1593
1594 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1595
1596 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1597 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1598
1599 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1600
1601 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1602 about the current paragraph and restore it after the call to reseat.
1603
1604 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1605 (bidi_find_paragraph_start): Search back for paragraph beginning
1606 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1607 (bidi_move_to_visually_next): Only trigger paragraph-related
1608 computations when the last character is a newline or at EOB, not
1609 just any NEUTRAL_B. (Bug#9470)
1610
1611 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1612 truncated lines if point is covered by a display string. (Bug#9524)
1613
1614 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1617 (cons_to_x_long): New function.
1618 (lisp_data_to_selection_data): Use it. Correct the test for
1619 short-versus-long data; it was negated. Break out of vector
1620 loop, for efficiency, when a long datum is discovered.
1621
1622 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1623
1624 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1625
1626 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1627
1628 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1629 GCC PR/17406) by declaring this function with external scope.
1630
1631 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1634 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1635
1636 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1637
1638 * editfns.c (Fformat): Correctly handle text properties on "%%".
1639
1640 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1641
1642 * xterm.c (x_draw_composite_glyph_string_foreground):
1643 * w32term.c (x_draw_composite_glyph_string_foreground):
1644 * term.c (encode_terminal_code):
1645 * composite.c (composition_update_it, get_composition_id):
1646 * xdisp.c (get_next_display_element)
1647 (fill_composite_glyph_string): Add comments about special meaning
1648 of TAB characters in a composition.
1649
1650 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1651
1652 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1653 This occurs when processing a multibyte format.
1654 Problem reported by Wolfgang Jenker.
1655
1656 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1657
1658 * xdisp.c (try_cursor_movement): Only check for exact match if
1659 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1660
1661 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1662
1663 Remove unused external symbols.
1664 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1665 * xdisp.c (calc_pixel_width_or_height): Now static.
1666 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1667 * indent.c (check_display_width):
1668 * w32term.c: Fix comment to match code.
1669 * xterm.c, xterm.h (x_catching_errors): Remove.
1670
1671 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 * xselect.c: Use signed conversions more consistently (Bug#9498).
1674 (selection_data_to_lisp_data): Assume incoming selection data are
1675 signed integers, not unsigned. This is to be consistent with
1676 outgoing selection data, which was modified to use signed integers
1677 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1678 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1679 expects long, not unsigned long.
1680
1681 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1682
1683 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1684 computation of loop end. Reported by Johan Bockgård
1685 <bojohan@gnu.org>.
1686
1687 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1688
1689 * frame.c (Fother_visible_frames_p): Function deleted.
1690
1691 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1692
1693 * indent.c (compute_motion): Process display vector front to back
1694 rather than the other way around. (Bug#2496)
1695
1696 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1697
1698 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1699
1700 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1701
1702 * minibuf.c (Fread_from_minibuffer): Doc fix.
1703
1704 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1705
1706 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1707 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1708
1709 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1710
1711 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1712 value for non-existent files.
1713
1714 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1715
1716 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1717 set its "size" to -1. This will set the modtime_size field of
1718 the corresponding buffer to -1, which is what
1719 verify-visited-file-modtime expects for files that do not exist.
1720 (Bug#9139)
1721
1722 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1725 here ...
1726 * lisp.h: ... from here. push_key_description is no longer
1727 defined in keyboard.c, so its declaration should not be in
1728 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1729 logically belongs with push_key_description.
1730
1731 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 * buffer.h: Include <sys/types.h> instead of <time.h>.
1734 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1735 Problem reported by Herbert J. Skuhra.
1736
1737 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1738
1739 * xml.c (parse_region): Make the parsing work for
1740 non-comment-starting XML files again (bug#9144).
1741
1742 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1743
1744 * image.c (gif_load): Fix calculation of bottom and right corner.
1745 (Bug#9468)
1746
1747 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1748
1749 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1750 redisplay in small windows.
1751
1752 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1753
1754 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1755
1756 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1757
1758 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1759 Operate on live windows only.
1760
1761 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1762
1763 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1764
1765 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1766
1767 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1768 only under bidi iteration.
1769
1770 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1771
1772 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1773
1774 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1775
1776 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1777 Without this fix, the command to link temacs failed due to an
1778 undefined symbol __builtin_isnan. This is because
1779 /usr/include/iso/math_c99.h #defines isnan(x) to
1780 __builtin_isnan(x), but the bundled gcc, which identifies itself
1781 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1782 a __builtin_isnan.
1783 * floatfns.c (isnan): #undef, and then #define to a clone of
1784 what's in data.c.
1785 (Fisnan): Always define, since it's always available now.
1786 (syms_of_floatfns): Always define isnan at the Lisp level.
1787
1788 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1789
1790 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1791
1792 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1795 The previous code assumed that file offsets (off_t values) fit in
1796 EMACS_INT variables, which is not true on typical 32-bit hosts.
1797 The code messed up by falsely reporting buffer overflow in cases
1798 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1799 when "big" contains more than 2**29 bytes, even though this
1800 inserts just one byte and does not overflow the buffer.
1801 (Finsert_file_contents): Store file offsets as off_t
1802 values, not as EMACS_INT values. Check for overflow when
1803 converting between EMACS_INT and off_t. When checking for
1804 buffer overflow or for overlap, take the offsets into account.
1805 Don't use EMACS_INT for small values where int suffices.
1806 When checking for overlap, fix a typo: ZV was used where
1807 ZV_BYTE was intended.
1808 (Fwrite_region): Don't assume off_t fits into 'long'.
1809 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1810
1811 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1812
1813 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1814
1815 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 sprintf-related integer and memory overflow issues (Bug#9412).
1818
1819 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1820 (esprintf, exprintf, evxprintf): New functions.
1821 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1822 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1823 (modify_event_symbol): Do not assume that the length of
1824 name_alist_or_stem is safe to alloca and fits in int.
1825 (Fexecute_extended_command): Likewise for function name and binding.
1826 (Frecursion_depth): Wrap around reliably on integer overflow.
1827 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1828 since some callers pass EMACS_INT values.
1829 (Fsingle_key_description): Don't crash if symbol name contains more
1830 than MAX_ALLOCA bytes.
1831 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1832 (get_minibuffer): Arg is now EMACS_INT, not int.
1833 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1834 (esprintf, exprintf, evxprintf): New decls.
1835 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1836
1837 * dbusbind.c (signature_cat): New function.
1838 (xd_signature, Fdbus_register_signal):
1839 Do not overrun buffer; instead, report string overflow.
1840
1841 * dispnew.c (add_window_display_history): Don't overrun buffer.
1842 Truncate instead; this is OK since it's just a log.
1843
1844 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1845 even if the time zone offset is outlandishly large.
1846 Don't mishandle offset == INT_MIN.
1847
1848 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1849 when creating daemon; the previous buffer-overflow check was incorrect.
1850
1851 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1852 which has the guts of the old verror function.
1853
1854 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1855 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1856
1857 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1858 (font_unparse_xlfd): Don't blindly alloca long strings.
1859 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1860 fits in int, when using sprintf. Use single snprintf to count
1861 length of string rather than counting it via multiple sprintfs;
1862 that's simpler and more reliable.
1863 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1864 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1865 sprintf, in case result does not fit in int.
1866
1867 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1868 (fontset_from_font): Print it.
1869
1870 * frame.c (tty_frame_count): Now printmax_t, not int.
1871 (make_terminal_frame, set_term_frame_name): Print it.
1872 (x_report_frame_params): In X, window IDs are unsigned long,
1873 not signed long, so print them as unsigned.
1874 (validate_x_resource_name): Check for implausibly long names,
1875 and don't assume name length fits in 'int'.
1876 (x_get_resource_string): Don't blindly alloca invocation name;
1877 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1878 not fit in int.
1879
1880 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1881 (xg_check_special_colors, xg_set_geometry):
1882 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1883
1884 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1885 Use esprintf, not sprintf, in case result does not fit in int.
1886
1887 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1888 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1889 it as a large positive number.
1890 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1891 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1892
1893 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1894 in case result does not fit in int.
1895
1896 * print.c (float_to_string): Detect width overflow more reliably.
1897 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1898 buffer overrun. Don't assume list length fits in 'int'. Treat
1899 print length of 0 as 0, not as infinity; to be consistent with other
1900 uses of print length in this function. Don't overflow print length
1901 index. Don't assume hash table size fits in 'long', or that
1902 vectorlike size fits in 'unsigned long'.
1903
1904 * process.c (make_process): Use printmax_t, not int, to format
1905 process-name gensyms.
1906
1907 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1908
1909 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1910 to avoid potential buffer overrun.
1911
1912 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1913 if X resource line is longer than 512 bytes.
1914
1915 * xfns.c (x_window): Make sprintf buffer a bit bigger
1916 to avoid potential buffer overrun.
1917
1918 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1919
1920 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1921
1922 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 Integer overflow fixes for scrolling, etc.
1925 Without these, Emacs silently mishandles large integers sometimes.
1926 For example, "C-u 4294967297 M-x recenter" was treated as if
1927 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1928
1929 * xdisp.c (try_window_id): Check Emacs fixnum range before
1930 converting to 'int'.
1931
1932 * window.c (window_scroll_line_based, Frecenter):
1933 Check that an Emacs fixnum is in range before assigning it to 'int'.
1934 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1935 values converted from Emacs fixnums.
1936 (Frecenter): Don't wrap around a line count if it is out of 'int'
1937 range; instead, treat it as an extreme value.
1938 (Fset_window_configuration, compare_window_configurations):
1939 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1940
1941 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1942 that can exceed INT_MAX. Check that EMACS_INT value is in range
1943 before assigning it to the (possibly-narrower) index.
1944 (match_limit): Don't assume that a fixnum can fit in 'int'.
1945
1946 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1947 exceed INT_MAX.
1948
1949 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1950 (Fvertical_motion): Don't wrap around LINES values that don't fit
1951 in 'int'. Instead, treat them as extreme values. This is good
1952 enough for windows, which can't have more than INT_MAX lines anyway.
1953
1954 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1955
1956 * Require libxml/parser.h to avoid compilation warning.
1957
1958 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1959
1960 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1961 since this reportedly can destroy thread storage.
1962
1963 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1964
1965 * syntax.c (find_defun_start): Update all cache variables if
1966 exiting early (Bug#9401).
1967
1968 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1969
1970 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1971
1972 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1973 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1974 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1975
1976 * term.c (tty_append_glyph): New function.
1977 (produce_stretch_glyph): Static function and its prototype deleted.
1978
1979 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1980 Add prototypes.
1981
1982 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1983
1984 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1985 when checking :margin (Bug#9390).
1986 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1987 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1988 so that the name doesn't mislead. All uses changed.
1989
1990 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1991
1992 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1993 set_tty_hooks.
1994
1995 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1996
1997 * xdisp.c (move_it_to): Don't bail out early when reaching
1998 position beyond to_charpos, if we are scanning backwards.
1999 (move_it_vertically_backward): When DY == 0, make sure we get to
2000 the first character in the line after the newline.
2001
2002 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2003
2004 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2005 (ccl_driver): Do not generate an out-of-range pointer.
2006 (Fccl_execute_on_string): Remove unnecessary check for
2007 integer overflow, noted by Stefan Monnier in
2008 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2009 Remove a FIXME that didn't need fixing.
2010 Simplify the newly-introduced buffer reallocation code.
2011
2012 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2013
2014 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2015
2016 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 Integer and memory overflow issues (Bug#9196).
2019
2020 * doc.c (get_doc_string): Rework so that
2021 get_doc_string_buffer_size is the actual buffer size, rather than
2022 being 1 less than the actual buffer size; this makes xpalloc more
2023 convenient.
2024
2025 * image.c (x_allocate_bitmap_record, cache_image):
2026 * xselect.c (Fx_register_dnd_atom):
2027 Simplify previous changes by using xpalloc.
2028
2029 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2030 since either will do and ptrdiff_t is convenient with xpalloc.
2031
2032 * charset.c (charset_table_size)
2033 (struct charset_sort_data.priority): Now ptrdiff_t.
2034 (charset_compare): Don't overflow if priorities differ greatly.
2035 (Fsort_charsets): Don't assume list length fits in int.
2036 Check for size-calculation overflow when allocating sort data.
2037 (syms_of_charset): Allocate an initial charset table that is
2038 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2039
2040 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2041
2042 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2043 The actual value is always <= INT_MAX, and leaving it unsigned made
2044 overflow checking harder.
2045
2046 * dispextern.h (struct glyph_matrix.rows_allocated)
2047 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2048 with xpalloc. The values are still always <= INT_MAX.
2049
2050 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2051
2052 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2053 (SAFE_NALLOCA): New macro.
2054
2055 * region-cache.c (struct boundary.pos, find_cache_boundary)
2056 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2057 (set_cache_region, invalidate_region_cache)
2058 (revalidate_region_cache, know_region_cache, region_cache_forward)
2059 (region_cache_backward, pp_cache):
2060 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2061 so that ptrdiff_t * can be passed to xpalloc.
2062 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2063 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2064 (pp_cache): Don't assume cache_len fits in int.
2065 * region-cache.h: Adjust extern decls to match.
2066
2067 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2068 EMACS_INT, since either will do, for xpalloc.
2069
2070 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2071 (xnmalloc, xnrealloc, xpalloc): New functions.
2072
2073 * bidi.c (bidi_shelve_header_size): New constant.
2074 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2075 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2076
2077 * bidi.c (bidi_cache_shrink):
2078 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2079 (overlay_strings):
2080 Don't update size of array until after memory allocation succeeds,
2081 because xmalloc/xrealloc may not return.
2082 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2083 now that we have proper integer overflow checking.
2084 (record_overlay_string, overlay_strings): Catch overflows when
2085 calculating size of overlay_str_buf.
2086
2087 * callproc.c (Fcall_process): Check for size overflow when
2088 calculating size of args2.
2089 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2090 Normally we prefer signed values, but sticking with ptrdiff_t would
2091 require adding more-complicated checks.
2092
2093 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2094 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2095 Redo buffer-overflow calculations to avoid integer overflow.
2096 Add a FIXME comment where memory seems to be over-allocated.
2097
2098 * character.c (Fstring): Check for size-calculation overflow.
2099
2100 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2101 unnecessary integer overflow. Check for size overflow.
2102 (encode_coding_object): Don't update size until xmalloc succeeds.
2103
2104 * composite.c (get_composition_id): Check for overflow in glyph
2105 length calculations.
2106
2107 Integer and memory overflow fixes for display code.
2108 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2109 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2110 (scrolling_window): Check for overflow in size calculations.
2111 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2112 Don't assume glyph table len fits in int.
2113 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2114 (row_table_size): Now ptrdiff_t, not int.
2115 (scrolling_window): Avoid overflow in size calculations.
2116 Don't update size until allocation succeeds.
2117 * fns.c (concat): Check for overflow in size calculations.
2118 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2119 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2120 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2121
2122 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2123 (get_doc_string): Check for size calculation overflow.
2124 Don't update size until allocation succeeds.
2125 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2126 EMACS_INT, where ptrdiff_t will do.
2127 (Fsubstitute_command_keys): Check for string overflow.
2128
2129 * editfns.c (set_time_zone_rule): Don't assume environment length
2130 fits in int.
2131 (message_length): Now ptrdiff_t, not int.
2132 (Fmessage_box): Don't update size until allocation succeeds.
2133 Don't assume message length fits in int.
2134 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2135
2136 * emacs.c (main): Do not reallocate argv, since there is a null at
2137 the end that can be overwritten, and this way there's no need to
2138 worry about size-calculation overflow.
2139 (sort_args): Check for size-calculation overflow.
2140
2141 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2142 alloc succeeds.
2143 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2144
2145 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2146 (x_set_scroll_bar_width, x_figure_window_size):
2147 Check for integer overflow.
2148 (x_set_alpha): Do not assume XINT fits in int.
2149
2150 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2151 This is for the members text_lines, text_cols, total_lines, total_cols,
2152 where the system imposes an 'int' limit.
2153
2154 * fringe.c (Fdefine_fringe_bitmap):
2155 Don't update size until alloc works.
2156
2157 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2158 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2159
2160 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2161 Check for size-calculation overflow.
2162 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2163 do, as we prefer signed integers.
2164 (id_to_widget.max_size, id_to_widget.used)
2165 (xg_store_widget_in_map, xg_remove_widget_from_map)
2166 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2167 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2168 Use and return ptrdiff_t, not int.
2169 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2170 * gtkutil.h: Change prototypes to match the above.
2171
2172 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2173 are duplicate now that they've been promoted to lisp.h.
2174 (x_allocate_bitmap_record, x_alloc_image_color)
2175 (make_image_cache, cache_image, xpm_load):
2176 Don't update size until alloc is done.
2177 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2178 (x_detect_edges):
2179 Check for size calculation overflow.
2180 (ct_colors_allocated_max): New constant.
2181 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2182 overflow.
2183
2184 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2185 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2186 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2187 Use ptrdiff_t, not int, to count maps.
2188 (read_char_minibuf_menu_prompt): Check for overflow in size
2189 calculations. Don't update size until allocation succeeds.
2190 Redo calculations to avoid overflow.
2191 * keyboard.h: Change prototypes to match the above.
2192
2193 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2194 to count maps.
2195 (current_minor_maps): Check for size calculation overflow.
2196 * keymap.h: Change prototypes to match the above.
2197
2198 * lread.c (read1, init_obarray): Don't update size until alloc done.
2199
2200 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2201 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2202
2203 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2204 Now ptrdiff_t, not int.
2205 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2206 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2207
2208 * process.c (Fnetwork_interface_list): Check for overflow
2209 in size calculation.
2210
2211 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2212
2213 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2214 overflow. Don't bother calling xmalloc when xrealloc will do.
2215
2216 * search.c (Freplace_match): Check for size calculation overflow.
2217 (Fset_match_data): Don't assume list lengths fit in 'int'.
2218
2219 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2220 for command line length. Do not attempt to address one before the
2221 beginning of an array, as that's not portable.
2222
2223 * term.c (max_frame_lines): Remove; unused.
2224 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2225 not int.
2226 (encode_terminal_code, calculate_costs): Check for size
2227 calculation overflow.
2228 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2229 table lengths and related sizes. Don't update size until alloc
2230 done. Redo calculations to avoid overflow.
2231 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2232
2233 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2234 subtracting pointers.
2235 (gobble_line): Check for overflow more carefully. Don't update size
2236 until alloc done.
2237
2238 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2239 Don't update size until alloc done.
2240 Redo size calculations to avoid overflow.
2241 Check for size calculation overflow.
2242 (main) [DEBUG]: Fix typo in invoking tparam1.
2243
2244 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2245 Use ptrdiff_t, not int, for sizes.
2246 (store_mode_line_noprop_char): Don't update size until alloc done.
2247
2248 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2249 Use ptrdiff_t, not int, for sizes.
2250 (Finternal_make_lisp_face, cache_face):
2251 Check for size calculation overflow.
2252 (cache_face): Treat size calculation overflows as if they were
2253 memory exhaustion (the usual treatment), rather than aborting.
2254
2255 * xfns.c (x_encode_text, x_set_name_internal)
2256 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2257 sizes, since they can exceed INT_MAX in size. Check for size
2258 calculation overflow.
2259
2260 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2261 (xg_select): Check for size calculation overflow.
2262 Don't update size until alloc done.
2263
2264 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2265 as sprintf is limited to int lengths.
2266
2267 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2268 (X_LONG_MIN): New macros.
2269 Use them to make the following changes clearer.
2270 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2271 This change doesn't affect the value now, but it may help remind
2272 future maintainers not to raise the value too much later.
2273 (SELECTION_QUANTUM): Remove, replacing with ...
2274 (selection_quantum): ... new function, which avoids overflow.
2275 All uses changed.
2276 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2277 assumption that selection length fits in 'int'.
2278 (x_reply_selection_request, x_handle_selection_request)
2279 (x_get_window_property, receive_incremental_selection)
2280 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2281 (lisp_data_to_selection_data, clean_local_selection_data):
2282 Use ptrdiff_t, not int, to record length of selection.
2283 (x_reply_selection_request, x_get_window_property)
2284 (receive_incremental_selection, x_property_data_to_lisp):
2285 Redo calculations to avoid overflow.
2286 (x_reply_selection_request): When sending hint, ceiling it at
2287 X_LONG_MAX rather than relying on wraparound overflow to send
2288 something.
2289 (x_get_window_property, receive_incremental_selection)
2290 (lisp_data_to_selection_data, x_property_data_to_lisp):
2291 Check for size-calculation overflow.
2292 (x_get_window_property, receive_incremental_selection)
2293 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2294 Don't store size until memory allocation succeeds.
2295 (x_get_window_property): Plug memory leak on memory exhaustion.
2296 Don't double-block input; malloc is safe here. Don't assume 2**34
2297 - 4 fits in unsigned long. Add an xassert to check
2298 XGetWindowProperty overflow. Be more careful about overflow
2299 calculations, and distinguish size from memory overflow better.
2300 (receive_incremental_selection): When tracing, don't assume
2301 unsigned int is less than INT_MAX.
2302 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2303 harmful) conversions of unsigned short to int.
2304 (lisp_data_to_selection_data): Don't assume that integers
2305 in the range -65535 through -1 fit in an X unsigned short.
2306 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2307 result parameters unless successful. Rely on cons_to_unsigned
2308 to report problems with elements; the old code wasn't right anyway.
2309 (x_check_property_data): Check for int overflow; we cannot use
2310 a wider type due to X limits.
2311 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2312
2313 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2314
2315 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2316 (x_term_init): Check for size calculation overflow.
2317 (x_color_cells): Don't store size until memory allocation succeeds.
2318 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2319 Don't assume alloca size is less than MAX_ALLOCA.
2320 (x_term_init): Don't assume length fits in int (sprintf is limited
2321 to int size).
2322
2323 Use ptrdiff_t for composition IDs.
2324 * character.c (lisp_string_width):
2325 * composite.c (composition_table_size, n_compositions)
2326 (get_composition_id, composition_gstring_from_id):
2327 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2328 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2329 * window.c (Frecenter):
2330 Use ptrdiff_t, not int, for composition IDs.
2331 * composite.c (get_composition_id): Check for integer overflow.
2332 * composite.h: Adjust prototypes to match the above changes.
2333
2334 Use ptrdiff_t for hash table indexes.
2335 * category.c (hash_get_category_set):
2336 * ccl.c (ccl_driver):
2337 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2338 * coding.c (coding_system_charset_list, detect_coding_system):
2339 * coding.h (struct coding_system.id):
2340 * composite.c (get_composition_id, gstring_lookup_cache):
2341 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2342 * image.c (xpm_get_color_table_h):
2343 * lisp.h (hash_lookup, hash_put):
2344 * minibuf.c (Ftest_completion):
2345 Use ptrdiff_t for hash table indexes, not int (which is too
2346 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2347 32-bit --with-wide-int hosts).
2348
2349 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2350 Add a FIXME comment about memory leaks.
2351 (syms_of_charset): Don't assume xmalloc returns.
2352
2353 Don't assume that stated character widths fit in int.
2354 * character.c (Fchar_width, c_string_width, lisp_string_width):
2355 * character.h (CHAR_WIDTH):
2356 * indent.c (MULTIBYTE_BYTES_WIDTH):
2357 Use sanitize_char_width to avoid undefined and/or bad behavior
2358 with outlandish widths.
2359 * character.h (sanitize_tab_width): Rename from sanitize_width,
2360 now that we have two such functions. All uses changed.
2361 (sanitize_char_width): New inline function.
2362
2363 Don't assume that tab-width fits in int.
2364 * character.h (sanitize_width): New inline function.
2365 (SANE_TAB_WIDTH): New macro.
2366 (ASCII_CHAR_WIDTH): Use it.
2367 * indent.c (sane_tab_width): Remove. All uses replaced by
2368 SANE_TAB_WIDTH (current_buffer).
2369 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2370
2371 * fileio.c: Integer overflow issues with file modes.
2372 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2373
2374 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2375 Remove unreachable code.
2376 (read_hex, load_charset_map_from_file): Check for integer overflow.
2377
2378 * xterm.c: Don't go over XClientMessageEvent limit.
2379 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2380 (x_send_scroll_bar_event): Likewise. Check that the size does not
2381 exceed limits imposed by XClientMessageEvent, as well as the usual
2382 ptrdiff_t and size_t limits.
2383
2384 * keyboard.c: Overflow, signedness and related fixes.
2385 (make_lispy_movement): Use same integer type in forward decl
2386 that is used in the definition.
2387 (read_key_sequence, keyremap_step):
2388 Change bufsize argument back to int, undoing my 2011-03-30 change.
2389 We prefer signed types, and int is wide enough here.
2390 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2391 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2392 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2393 length, not size_t. Use ptrdiff_t for index, not int.
2394 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2395 possibility of integer overflow.
2396
2397 Overflow, signedness and related fixes for images.
2398
2399 * dispextern.h (struct it.stack[0].u.image.image_id)
2400 (struct_it.image_id, struct image.id, struct image_cache.size)
2401 (struct image_cache.used, struct image_cache.ref_count):
2402 * gtkutil.c (update_frame_tool_bar):
2403 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2404 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2405 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2406 * nsmenu.m (update_frame_tool_bar):
2407 * xdisp.c (calc_pixel_width_or_height):
2408 * xfns.c (image_cache_refcount):
2409 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2410 on typical 64-bit hosts.
2411
2412 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2413 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2414 Omit unnecessary casts to int.
2415 (parse_image_spec): Check that integers fall into 'int' range
2416 when the callers expect that.
2417 (image_ascent): Redo ascent calculation to avoid int overflow.
2418 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2419 (lookup_image): Remove unnecessary tests.
2420 (xbm_image_p): Locals are now of int, not EMACS_INT,
2421 since parse_image_check makes sure they fit into int.
2422 (png_load, gif_load, svg_load_image):
2423 Prefer int to unsigned where either will do.
2424 (tiff_handler): New function, combining the cores of the
2425 old tiff_error_handler and tiff_warning_handler.
2426 This function is rewritten to use vsnprintf and thereby avoid
2427 stack buffer overflows. It uses only the features of vsnprintf
2428 that are common to both POSIX and native Microsoft.
2429 (tiff_error_handler, tiff_warning_handler): Use it.
2430 (tiff_load, gif_load, imagemagick_load_image):
2431 Don't assume :index value fits in 'int'.
2432 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2433 (imagemagick_load_image): Check that crop parameters fit into
2434 the integer types that MagickCropImage accepts. Don't assume
2435 Vimagemagick_render_type has a nonnegative value. Don't assume
2436 size_t fits in 'long'.
2437 (gs_load): Use printmax_t to print the widest integers possible.
2438 Check for integer overflow when computing image height and width.
2439
2440 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2441
2442 * xdisp.c (redisplay_window): Don't force window start if point
2443 will be invisible in the resulting window. (Bug#9324)
2444
2445 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2446
2447 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2448 the display spec is of the form `(space ...)'.
2449 (handle_display_spec): Return the value returned by
2450 handle_single_display_spec, not just 1 or zero.
2451 (handle_single_display_spec): If the display spec is of the form
2452 `(space ...)', and specifies display in the text area, return 2
2453 rather than 1.
2454 (try_cursor_movement): Check for the need to scroll more
2455 accurately, and prefer exact match for point under bidi.
2456 Don't advance `row' beyond the last row of the window.
2457
2458 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2459 into disp_prop; all users changed.
2460
2461 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2462 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2463 for the text covered by the display property.
2464
2465 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2466
2467 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2468 Change return value to nil.
2469 (Frecord_buffer): Delete unused function.
2470
2471 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2472
2473 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2474 buffers, return left-to-right.
2475 (set_cursor_from_row): Consider candidate row a win if its glyph
2476 represents a newline and point is on that newline. Fixes cursor
2477 positioning on the newline at EOL of R2L text within L2R
2478 paragraph, and vice versa.
2479 (try_cursor_movement): Check continued rows, in addition to
2480 continuation rows. Fixes unwarranted scroll when point enters a
2481 continued line of R2L text within an L2R paragraph, or vice versa.
2482 (cursor_row_p): Consider the case of point being equal to
2483 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2484 from the end of a short line to the beginning of a continued line
2485 of R2L text within L2R paragraph.
2486 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2487 composed characters.
2488
2489 * bidi.c (bidi_check_type): Use xassert.
2490 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2491 members.
2492
2493 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2494
2495 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2496 a character.
2497
2498 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2499
2500 * nsfont.m (ns_otf_to_script): Fix typo.
2501
2502 2011-08-22 Kenichi Handa <handa@m17n.org>
2503
2504 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2505 extra slot even if the purpose is char-code-property-table.
2506
2507 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2508
2509 * xdisp.c (redisplay_window): When computing centering_position,
2510 account for the height of the header line. (Bug#8874)
2511
2512 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2513 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2514 candidate is selected by the mouse, and that candidate has a
2515 composed character under the mouse.
2516
2517 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2518 coordinates reported by pos-visible-in-window-p for a composed
2519 character in column zero.
2520
2521 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2522
2523 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2524
2525 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2526
2527 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2528 consider it a hit if to_charpos is anywhere in the range of the
2529 composed buffer positions.
2530
2531 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2532
2533 * image.c (gif_load): Don't assume that each subimage has the same
2534 dimensions as the base image. Handle disposal method that is
2535 "undefined" by the gif spec (Bug#9335).
2536
2537 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2538
2539 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2540 (Fcondition_case): Document `debug' symbol in error handler.
2541
2542 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2543
2544 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2545 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2546 from an Org mode buffer to a Speedbar frame.
2547
2548 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2549 a composition, take its buffer position from IT->cmp_it.charpos.
2550 Fixes cursor positioning at the beginning of a line that begins
2551 with a composed character.
2552
2553 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2554
2555 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2556 character bidirectional type, use STRONG_L instead. Fixes crashes
2557 in a buffer produced by `describe-categories'.
2558
2559 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2560 members before the level stack, so they would be saved and
2561 restored when copying iterator state. Fixes incorrect reordering
2562 around TABs covered by display properties.
2563
2564 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2565
2566 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2567
2568 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2569
2570 * eval.c (internal_condition_case, internal_condition_case_1)
2571 (internal_condition_case_2, internal_condition_case_n):
2572 Remove unnecessary aborts (Bug#9081).
2573
2574 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2575
2576 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2577 has no `load' handler, try opening the file locally. (Bug#9311)
2578
2579 2011-08-16 Ken Brown <kbrown@cornell.edu>
2580
2581 * gmalloc.c: Expand comment.
2582
2583 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2584
2585 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2586 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2587
2588 2011-08-16 Ken Brown <kbrown@cornell.edu>
2589
2590 Fix memory allocation problems in Cygwin build (Bug#9273).
2591
2592 * unexcw.c ( __malloc_initialized): Declare external variable.
2593 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2594
2595 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2596 New variables.
2597 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2598 dumped emacs.
2599 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2600 in the static heap.
2601 [CYGWIN] (special_realloc): New function.
2602 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2603 requests to realloc storage in the static heap.
2604
2605 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2606
2607 * bidi.c (bidi_initialize): Remove unused local.
2608
2609 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2610
2611 * bidimirror.h:
2612 * biditype.h: Remove file.
2613 * makefile.w32-in ($(BLD)/bidi.$(O)):
2614 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2615
2616 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2617
2618 * chartab.c: Improve commentary for the uniprop_table API.
2619
2620 * bidi.c (bidi_paragraph_init): Support zero value of
2621 bidi_ignore_explicit_marks_for_paragraph_level.
2622 (bidi_initialize): Use uniprop_table instead of including
2623 biditype.h and bidimirror.h.
2624
2625 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2626 coordinates of the iterator when restoring from ppos_it.
2627 (Bug#9296)
2628
2629 2011-08-14 Kenichi Handa <handa@m17n.org>
2630
2631 * process.c (create_process): Call setup_process_coding_systems
2632 after the pid of the process is set to -1 (Bug#8162).
2633
2634 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2635
2636 * xdisp.c (move_it_in_display_line_to): Don't invoke
2637 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2638 ppos_it. Fixes vertical cursor motion when line beginning is
2639 covered by an image. (Bug#9296)
2640
2641 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2642
2643 * nsterm.h (ns_run_ascript): Declare.
2644 (NSAPP_DATA2_RUNASSCRIPT): Define.
2645
2646 * nsfns.m (as_script, as_result, as_status): New static variables.
2647 (ns_run_ascript): New function.
2648 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2649 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2650 the event loop. Get status from as_status (Bug#7276).
2651
2652 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2653 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2654 the event loop (Bug#7276).
2655
2656 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2657
2658 * gnutls.c (QCgnutls_bootprop_priority)
2659 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2660 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2661 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2662 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2663 (QCgnutls_bootprop_verify_hostname_error)
2664 (QCgnutls_bootprop_callbacks_verify): Rename from
2665 Qgnutls_bootprop_..., all uses changed.
2666
2667 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2668 uses changed.
2669
2670 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2671
2672 * xfaces.c (Qframe_set_background_mode): Now static.
2673 * dispextern.h (Qframe_set_background_mode): Remove decl.
2674
2675 * process.c (Fnetwork_interface_info): Declare local only if needed.
2676
2677 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2678
2679 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2680 (Fnetwork_interface_list): Allocate in increments of bytes instead
2681 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2682 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2683 sockaddr.
2684 (struct ifflag_def): notrailers is smart on OSX.
2685 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2686 Get hardware address with getifaddrs if available.
2687
2688 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2689
2690 * xdisp.c (iterate_out_of_display_property): xassert that
2691 IT->position is set to within IT->object's boundaries. Break from
2692 the loop as soon as EOB is reached; avoids infloops in redisplay
2693 when IT->position is set up wrongly due to some bug.
2694 Set IT->current to match the bidi iterator unconditionally.
2695 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2696 entry. Force push_it to save on the stack the current
2697 buffer/string position, to be restored by pop_it. Fix flags in
2698 the iterator structure wrt the object coming from a display
2699 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2700 properties. (Bug#9284)
2701
2702 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2703
2704 * fontset.c (fontset_get_font_group): Add proper type checks.
2705 (Bug#9172)
2706
2707 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2708
2709 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2710 and LC_VERSION_MIN_MACOSX.
2711 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2712 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2713
2714 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2715
2716 * xdisp.c (forward_to_next_line_start): Allow to use the
2717 no-display-properties-and-no-overlays under bidi display.
2718 Set disp_pos in the bidi iterator to avoid searches for display
2719 properties and overlays.
2720
2721 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2722
2723 * editfns.c (Fset_time_zone_rule): Document relationship with the
2724 setenv function.
2725
2726 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2727 the font entity extracted from the cache (Bug#8109).
2728
2729 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2730
2731 * composite.c (autocmp_chars): Don't reset point. That is done by
2732 restore_point_unwind (Bug#5984).
2733
2734 2011-08-07 Juri Linkov <juri@jurta.org>
2735
2736 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2737 to show the arg `TIME' instead of `TIMEVAL'.
2738
2739 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2740
2741 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2742 display property strides EOL and includes a newline, as in
2743 longlines-mode. (Bug#9254)
2744 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2745 word-wrap under bidirectional display. (Bug#9224)
2746
2747 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2748 is non-zero, even if the data buffer is NULL. Fixes a crash in
2749 vertical-motion with longlines-mode. (Bug#9254)
2750
2751 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2752
2753 * bidi.c <bidi_cache_total_alloc>: Now static.
2754 (bidi_initialize): Initialize bidi_cache_total_alloc.
2755
2756 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2757 cache. (Bug#9221)
2758
2759 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2760 amount allocated this far in `bidi_cache_total_alloc'.
2761 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2762 non-zero, only free the data buffer without restoring the cache
2763 contents. All callers changed.
2764
2765 * dispextern.h (bidi_unshelve_cache): Update prototype.
2766
2767 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2768 (move_it_in_display_line, move_it_to)
2769 (move_it_vertically_backward, move_it_by_lines): Replace the call
2770 to xfree to an equivalent call to bidi_unshelve_cache.
2771 (move_it_in_display_line_to): Fix logic of returning
2772 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2773
2774 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2775
2776 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2777 came from a string character with a `cursor' property. (Bug#9229)
2778
2779 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2780
2781 * Makefile.in (LIB_PTHREAD): New variable.
2782 (LIBES): Add LIB_PTHREAD (Bug#9216).
2783
2784 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2785 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2786
2787 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2788
2789 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2790
2791 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2792
2793 * xterm.c (x_find_topmost_parent): New function.
2794 (x_set_frame_alpha): Find topmost parent window with
2795 x_find_topmost_parent and set the property there also (bug#9181).
2796 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2797
2798 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2799
2800 * callproc.c (Fcall_process): Avoid vfork clobbering
2801 the local vars buffer, coding_systems, current_dir.
2802
2803 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2804
2805 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2806
2807 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2808
2809 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2810 so that it is not optimized away.
2811
2812 * xdisp.c (compute_display_string_pos): Remove unused local.
2813
2814 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2815
2816 Fix slow cursor motion and scrolling in large buffers with
2817 selective display, like Org Mode buffers. (Bug#9218)
2818
2819 * dispextern.h (struct bidi_it): New member disp_prop_p.
2820
2821 * xdisp.c: Remove one-slot cache of display string positions.
2822 (compute_display_string_pos): Accept an additional argument
2823 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2824 for a display string or property. If found, set DISP_PROP_P
2825 non-zero.
2826
2827 * bidi.c (bidi_fetch_char): Accept an additional argument
2828 DISP_PROP_P, and pass it to compute_display_string_pos.
2829 Only handle text covered by a display string if DISP_PROP_P is returned
2830 non-zero. All callers of bidi_fetch_char changed.
2831
2832 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2833
2834 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2835
2836 2010-12-03 Don March <don@ohspite.net>
2837
2838 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2839 last character M-[char] is translated to ESC [char] (bug#7541).
2840
2841 2011-08-02 Kenichi Handa <handa@m17n.org>
2842
2843 * lisp.h (uniprop_table): Extern it.
2844
2845 * chartab.c (uniprop_table): Make it non-static.
2846
2847 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2848
2849 * xdisp.c (forward_to_next_line_start): Accept additional argument
2850 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2851 on the newline.
2852 (reseat_at_next_visible_line_start): Use the bidi iterator state
2853 returned by forward_to_next_line_start to restore the state of
2854 it->bidi_it after backing up to previous newline. (Bug#9212)
2855
2856 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2857
2858 * regex.c (re_comp): Protoize.
2859 (re_exec): Fix return type.
2860 (regexec): Fix type of `ret'. (Bug#9203)
2861
2862 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2863
2864 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2865 This is needed if max-image-size is a floating-point number.
2866
2867 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2868
2869 * print.c (print_object): Print empty symbol as ##.
2870
2871 * lread.c (read1): Read ## as empty symbol.
2872
2873 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2874
2875 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2876 setting frame foreground color (Bug#9175).
2877 (x_set_background_color): Likewise.
2878
2879 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2880 contents (Bug#9176).
2881 (EmacsTooltip -init): Remove bezels and add shadows to
2882 tooltip windows.
2883
2884 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2885 or scroll bar (Bug#8470).
2886
2887 * nsfont.m (nsfont_open): Remove assignment to voffset and
2888 unnecessary vars hshink, expand, hd, full_height, min_height.
2889 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2890
2891 * nsterm.h (nsfont_info): Remove voffset field.
2892
2893 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2894
2895 Implement strike-through and overline on NextStep (Bug#8863).
2896
2897 * nsfont.m (nsfont_open): Use underline position provided by font,
2898 instead of hard-coded value of 2.
2899 (nsfont_draw): Call ns_draw_text_decoration instead.
2900
2901 * nsterm.h: Add declaration for ns_draw_text_decoration.
2902
2903 * nsterm.m (ns_draw_text_decoration): New function for drawing
2904 underline, overline, and strike-through.
2905 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2906 ns_draw_text_decoration. Change treatment of cursor drawing to
2907 accommodate underlining, etc.
2908
2909 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2910
2911 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2912 default.
2913
2914 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2915
2916 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2917 Without this fix, if a signal arrives just after memory fills up,
2918 'malloc' might be invoked reentrantly.
2919
2920 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2921 In other words, assume that every image size is allowed, on non-X
2922 hosts. This assumption is probably wrong, but it lets Emacs compile.
2923
2924 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2925
2926 * regex.c (re_iswctype): Convert return values to boolean.
2927
2928 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2929
2930 * xdisp.c (compute_display_string_pos): Don't use cached display
2931 string position if the buffer had its restriction changed.
2932 (Bug#9184)
2933
2934 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2935
2936 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2937
2938 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2939
2940 Integer signedness and overflow and related fixes. (Bug#9079)
2941
2942 * bidi.c: Integer size and overflow fixes.
2943 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2944 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2945 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2946 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2947 (bidi_find_other_level_edge):
2948 Use ptrdiff_t instead of EMACS_INT where either will do.
2949 This works better on 32-bit hosts configured --with-wide-int.
2950 (bidi_cache_ensure_space): Check for size-calculation overflow.
2951 Use % rather than repeated addition, for better worst-case speed.
2952 Don't set bidi_cache_size until after xrealloc returns, because it
2953 might not return.
2954 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2955 (bidi_cache_ensure_space): Also check that the bidi cache size
2956 does not exceed that of the largest Lisp string or buffer. See Eli
2957 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2958
2959 * alloc.c (__malloc_size_t): Remove.
2960 All uses replaced by size_t. See Andreas Schwab's note
2961 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2962
2963 * image.c: Improve checking for integer overflow.
2964 (check_image_size): Assume that f is nonnull, since
2965 it is always nonnull in practice. This is one less thing to
2966 worry about when checking for integer overflow later.
2967 (x_check_image_size): New function, which checks for integer
2968 overflow issues inside X.
2969 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2970 This removes the need for a memory_full check.
2971 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2972 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2973 (xbm_read_bitmap_data): Change locals back to 'int', since
2974 their values must fit in 'int'.
2975 (xpm_load_image, png_load, tiff_load):
2976 Invoke x_create_x_image_and_pixmap earlier,
2977 to avoid much needless work if the image is too large.
2978 (tiff_load): Treat overly large images as if
2979 x_create_x_image_and_pixmap failed, not as malloc failures.
2980 (gs_load): Use x_check_image_size.
2981
2982 * gtkutil.c: Omit integer casts.
2983 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2984 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2985
2986 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2987
2988 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2989 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2990 would wrongly return t on a 64-bit host.
2991
2992 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2993 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2994 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2995 and therefore cause GCC to emit a bogus diagnostic in some cases.
2996
2997 * image.c: Integer signedness and overflow and related fixes.
2998 This is not an exhaustive set of fixes, but it's time to
2999 record what I've got.
3000 (lookup_pixel_color, check_image_size): Remove redundant decls.
3001 (check_image_size): Don't assume that arbitrary EMACS_INT values
3002 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3003 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3004 (tiff_load, imagemagick_load_image):
3005 Check for overflow in size calculations.
3006 (x_create_x_image_and_pixmap): Remove unnecessary test for
3007 xmalloc returning NULL; that can't happen.
3008 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3009 (xpm_color_bucket): Use better integer hashing function.
3010 (xpm_cache_color): Don't possibly over-allocate memory.
3011 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3012 (gif_memory_source):
3013 Use ptrdiff_t, not int or size_t, to record sizes.
3014 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3015 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3016 either works, as we prefer signed integers.
3017 (tiff_read_from_memory, tiff_write_from_memory):
3018 Return tsize_t, not size_t, since that's what the TIFF API wants.
3019 (tiff_read_from_memory): Don't fail simply because the read would
3020 go past EOF; instead, return a short read.
3021 (tiff_load): Omit no-longer-needed casts.
3022 (Fimagemagick_types): Don't assume size fits into 'int'.
3023
3024 Improve hashing quality when configured --with-wide-int.
3025 * fns.c (hash_string): New function, taken from sxhash_string.
3026 Do not discard information about ASCII character case; this
3027 discarding is no longer needed.
3028 (sxhash-string): Use it. Change sig to match it. Caller changed.
3029 * lisp.h: Declare it.
3030 * lread.c (hash_string): Remove, since we now use fns.c's version.
3031 The fns.c version returns a wider integer if --with-wide-int is
3032 specified, so this should help the quality of the hashing a bit.
3033
3034 * emacs.c: Integer overflow minor fix.
3035 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3036 Define only if GNU_LINUX.
3037 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3038
3039 * dispnew.c: Integer signedness and overflow fixes.
3040 Remove unnecessary forward decls, that were a maintenance hassle.
3041 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3042 All uses changed.
3043 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3044 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3045 (prepare_desired_row, line_draw_cost):
3046 Use int, not unsigned, where either works.
3047 (save_current_matrix, restore_current_matrix):
3048 Use ptrdiff_t, not size_t, where either works.
3049 (init_display): Check for overflow more accurately, and without
3050 relying on undefined behavior.
3051
3052 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3053 Remove, replacing with the new symbols in lisp.h. All uses changed.
3054 * fileio.c (make_temp_name):
3055 * filelock.c (lock_file_1, lock_file):
3056 * xdisp.c (message_dolog):
3057 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3058 Use pMd etc. instead.
3059 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3060 replacing the pWIDE etc. symbols removed from editfns.c.
3061
3062 * keyboard.h (num_input_events): Now uintmax_t.
3063 This is (very slightly) less likely to mess up due to wraparound.
3064 All uses changed.
3065
3066 * buffer.c: Integer signedness fixes.
3067 (alloc_buffer_text, enlarge_buffer_text):
3068 Use ptrdiff_t rather than size_t when either will do, as we prefer
3069 signed integers.
3070
3071 * alloc.c: Integer signedness and overflow fixes.
3072 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3073 (__malloc_size_t): Default to size_t, not to int.
3074 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3075 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3076 Prefer ptrdiff_t to size_t when either would do, as we prefer
3077 signed integers.
3078 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3079 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3080 Now const. Initialize with values that are in range even if char
3081 is signed.
3082 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3083 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3084 These functions do the right thing with sizes > 2**32.
3085 (check_depth): Now ptrdiff_t, not int.
3086 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3087 Adjust to new way of storing sizes. Check for size overflow bugs
3088 in rest of code.
3089 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3090 slightly wrong anyway, as it missed one instance of
3091 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3092 (refill_memory_reserve): Omit needless cast to size_t.
3093 (mark_object_loop_halt): Mark as externally visible.
3094
3095 * xselect.c: Integer signedness and overflow fixes.
3096 (Fx_register_dnd_atom, x_handle_dnd_message):
3097 Use ptrdiff_t, not size_t, since we prefer signed.
3098 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3099 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3100 x_dnd_atoms_size and x_dnd_atoms_length.
3101
3102 * doprnt.c: Prefer signed to unsigned when either works.
3103 * eval.c (verror):
3104 * doprnt.c (doprnt):
3105 * lisp.h (doprnt):
3106 * xdisp.c (vmessage):
3107 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3108 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3109 prefer signed arithmetic to avoid comparison confusion.
3110 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3111 but is a bit tricky.
3112
3113 Assume freestanding C89 headers, string.h, stdlib.h.
3114 * data.c, doprnt.c, floatfns.c, print.c:
3115 Include float.h unconditionally.
3116 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3117 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3118 * regex.c: Likewise for stddef.h, string.h.
3119 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3120 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3121 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3122 (STDC_HEADERS): Remove obsolete defines.
3123 * sysdep.c: Include limits.h unconditionally.
3124
3125 Assume support for memcmp, memcpy, memmove, memset.
3126 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3127 * regex.c (memcmp, memcpy):
3128 Remove; we assume C89 now.
3129
3130 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3131 (__malloc_safe_bcopy): Remove; no longer needed.
3132
3133 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3134 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3135 well either way, and we prefer signed to unsigned.
3136
3137 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3138
3139 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3140 closes the connection while we're reading (bug#9182).
3141
3142 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3143
3144 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3145 are specified (Bug#9168).
3146
3147 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3150 Found by GCC static checking and --with-wide-int on a 32-bit host.
3151
3152 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3153
3154 * xdisp.c (compute_display_string_pos): Fix logic of caching
3155 previous display string position. Initialize cached_prev_pos to
3156 -1. Fixes slow-down at the beginning of a buffer.
3157
3158 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3159
3160 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3161 for attrs[LFACE_FONTSET_INDEX].
3162
3163 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 * xml.c (parse_region): Remove unused local
3166 that was recently introduced.
3167
3168 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3169
3170 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3171 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3172
3173 * xdisp.c (move_it_in_display_line_to): Record the best matching
3174 position for TO_CHARPOS while scanning the line, and restore it on
3175 exit if none of the characters scanned was an exact match.
3176 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3177 when exact match is impossible due to invisible text, and the
3178 lines are truncated.
3179
3180 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3181
3182 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3183 for OSX >= 10.7.
3184
3185 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3186
3187 Fix a significant slow-down of cursor motion with C-n, C-p,
3188 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3189 auto-repeat under bidi redisplay in fontified buffers.
3190 * xdisp.c (compute_stop_pos_backwards): New function.
3191 (next_element_from_buffer): Call compute_stop_pos_backwards to
3192 find a suitable prev_stop when we find ourselves before
3193 base_level_stop.
3194 (reseat): Don't look for prev_stop, as that could mean a very long
3195 run.
3196 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3197 <cached_disp_overlay_modiff>: Cache for last found display string
3198 position.
3199 (compute_display_string_pos): Return the cached position if asked
3200 about the same buffer in the same area of character positions, and
3201 the buffer wasn't changed since the time the display string
3202 position was cached.
3203
3204 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3205
3206 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3207 is an integer, which is important for empty lines. (Bug#9149)
3208
3209 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3210
3211 * frame.c (Fmodify_frame_parameters): In tty case, update the
3212 default face if necessary (Bug#4238).
3213
3214 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3215
3216 * editfns.c (Fstring_to_char): No need to explain what a character
3217 is in the docstring (Bug#6576).
3218
3219 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3220
3221 * xml.c (parse_region): Make sure we always return a tree.
3222
3223 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3224
3225 * xml.c (parse_region): If a document contains only comments,
3226 return that, too.
3227
3228 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3229
3230 * xml.c (make_dom): Return comments, too.
3231
3232 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3233
3234 Port to OpenBSD.
3235 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3236 and the surrounding thread.
3237 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3238 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3239 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3240 timer goes off.
3241 * s/openbsd.h (BROKEN_SIGIO): Define.
3242 * unexelf.c (unexec) [__OpenBSD__]:
3243 Don't update the .mdebug section of the Alpha COFF symbol table.
3244
3245 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3246
3247 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3248 (bug#8460).
3249
3250 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3251
3252 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3253 This fixes some race conditions on the permissions of any newly
3254 created file.
3255
3256 * alloc.c (valid_pointer_p): Use pipe, not open.
3257 This fixes some permissions issues when debugging.
3258
3259 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3260 If fchown fails to set both uid and gid, try to set just gid,
3261 as that is sometimes allowed. Adjust the file's mode to eliminate
3262 setuid or setgid bits that are inappropriate if fchown fails.
3263
3264 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3265
3266 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3267 to compare Lisp_Objects.
3268 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3269 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3270 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3271
3272 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3273
3274 * lread.c (read_integer): Unread even EOF character.
3275 (read1): Likewise. Properly record start position of symbol.
3276
3277 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3278 symbol character follows.
3279
3280 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3281
3282 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3283 This works around a problem with the previous change to Fcopy_file.
3284 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3285 and without this change, GCC might complain about discarding
3286 fchown's return value.
3287
3288 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3289
3290 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3291
3292 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3293
3294 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3295
3296 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3297
3298 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3299 it's used from the C level.
3300
3301 * process.c: Use the same condition for POLL_FOR_INPUT in both
3302 keyboard.c and process.c (bug#1858).
3303
3304 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3305
3306 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3307 (Fgnutls_boot): Use it.
3308
3309 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3310
3311 * doc.c (Fsubstitute_command_keys): Revert last change.
3312
3313 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3314
3315 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3316 quotes the next character, and doesn't affect other longer
3317 sequences (bug#8935).
3318
3319 * lread.c (syms_of_lread): Clarify that is isn't only
3320 `eval-buffer' and `eval-defun' that's affected by
3321 `lexical-binding' (bug#8460).
3322
3323 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3324
3325 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3326 bidi redisplay when a line includes both an image and is truncated.
3327
3328 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3329
3330 Fix minor problems found by static checking.
3331 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3332 (elsz): Now a signed constant, not a size_t var. We prefer signed
3333 types to unsigned, to avoid integer comparison confusion. Without
3334 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3335 "cannot optimize loop, the loop counter may overflow", a symptom
3336 of the confusion.
3337 * indent.c (Fvertical_motion): Mark locals as initialized.
3338 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3339
3340 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3341
3342 * search.c (Fre_search_backward): Mention `case-fold-search' in
3343 all the re_search_* functions (bug#8138).
3344
3345 * keyboard.c (Fopen_dribble_file): Document when the file is
3346 closed (bug#8056).
3347
3348 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3349
3350 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3351 bidi_cache_idx.
3352
3353 Support bidi reordering of display and overlay strings.
3354 * xdisp.c (compute_display_string_pos)
3355 (compute_display_string_end): Accept additional argument STRING.
3356 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3357 (reseat_to_string): Initialize bidi_it->string.s and
3358 bidi_it->string.schars.
3359 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3360 NULL (avoids a crash in bidi_paragraph_init).
3361 Initialize itb.string.lstring.
3362 (init_iterator): Call bidi_init_it only of a valid
3363 buffer position was specified. Initialize paragraph_embedding to
3364 L2R.
3365 (reseat_to_string): Initialize the bidi iterator.
3366 (display_string): If we need to ignore text properties of
3367 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3368 original value of -1 will not work with bidi.)
3369 (compute_display_string_pos): First arg is now struct
3370 `text_pos *'; all callers changed. Support display properties on
3371 Lisp strings.
3372 (compute_display_string_end): Support display properties on Lisp
3373 strings.
3374 (init_iterator, reseat_1, reseat_to_string): Initialize the
3375 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3376 when iterating on a string not from display properties).
3377 (compute_display_string_pos, compute_display_string_end):
3378 Fix calculation of the object to scan. Fixes an error when using
3379 arrow keys.
3380 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3381 base_level_stop; instead, set base_level_stop to BEGV.
3382 Fixes crashes in vertical-motion.
3383 (next_element_from_buffer): Improve commentary for when
3384 the iterator is before prev_stop.
3385 (init_iterator): Initialize bidi_p from the default value of
3386 bidi-display-reordering, not from buffer-local value. Use the
3387 buffer-local value only if initializing for buffer iteration.
3388 (handle_invisible_prop): Support invisible properties on strings
3389 that are being bidi-reordered.
3390 (set_iterator_to_next): Support bidi reordering of C strings and
3391 Lisp strings.
3392 (next_element_from_string): Support bidi reordering of Lisp
3393 strings.
3394 (handle_stop_backwards): Support Lisp strings as well.
3395 (display_string): Support display of R2L glyph rows.
3396 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3397 (init_iterator): Don't initialize it->bidi_p for strings
3398 here.
3399 (reseat_to_string): Initialize it->bidi_p for strings here.
3400 (next_element_from_string, next_element_from_c_string)
3401 (next_element_from_buffer): Add xassert's for correspondence
3402 between IT's object being iterated and it->bidi_it.string
3403 structure.
3404 (face_before_or_after_it_pos): Support bidi iteration.
3405 (next_element_from_c_string): Handle the case of the first string
3406 character that is not the first one in the visual order.
3407 (get_visually_first_element): New function, refactored from common
3408 parts of next_element_from_buffer, next_element_from_string, and
3409 next_element_from_c_string.
3410 (tool_bar_lines_needed, redisplay_tool_bar)
3411 (display_menu_bar): Force left-to-right direction. Add a FIXME
3412 comment for making that be controlled by a user option.
3413 (push_it, pop_it): Save and restore the state of the
3414 bidi iterator. Save and restore the bidi_p flag.
3415 (pop_it): Iterate out of display property for string iteration as
3416 well.
3417 (iterate_out_of_display_property): Support iteration over strings.
3418 (handle_single_display_spec): Set up it->bidi_it for iteration
3419 over a display string, and call bidi_init_it.
3420 (handle_single_display_spec, next_overlay_string)
3421 (get_overlay_strings_1, push_display_prop): Set up the bidi
3422 iterator for displaying display or overlay strings.
3423 (forward_to_next_line_start): Don't use the shortcut if
3424 bidi-iterating.
3425 (back_to_previous_visible_line_start): If handle_display_prop
3426 pushed the iterator stack, restore the internal state of the bidi
3427 iterator by calling bidi_pop_it same number of times.
3428 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3429 and we are bidi-iterating, don't decrement the iterator position;
3430 instead, set the first_elt flag in the bidi iterator, to produce
3431 the same effect.
3432 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3433 (push_display_prop): xassert that we are iterating a buffer.
3434 (push_it, pop_it): Save and restore paragraph_embedding member.
3435 (handle_single_display_spec, next_overlay_string)
3436 (get_overlay_strings_1, reseat_1, reseat_to_string)
3437 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3438 correctly. Don't assume unibyte strings are not bidi-reordered.
3439 (compute_display_string_pos)
3440 (compute_display_string_end): Fix handling the case of C string.
3441 (push_it, pop_it): Save and restore from_disp_prop_p.
3442 (handle_single_display_spec, push_display_prop): Set the
3443 from_disp_prop_p flag.
3444 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3445 (pop_it): Call iterate_out_of_display_property only if we are
3446 popping after iteration over a string that came from a display
3447 property. Fix a typo in popping stretch info. Add an assertion
3448 for verifying that the iterator position is in sync with the bidi
3449 iterator.
3450 (handle_single_display_spec, get_overlay_strings_1)
3451 (push_display_prop): Fix initialization of paragraph direction for
3452 string when that of the parent object is not yet determined.
3453 (reseat_1): Call bidi_init_it to resync the bidi
3454 iterator with IT's position. (Bug#7616)
3455 (find_row_edges): If ROW->start.pos gives position
3456 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3457 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3458 Reset the from_disp_prop_p flag.
3459 (SAVE_IT, RESTORE_IT): New macros.
3460 (pos_visible_p, face_before_or_after_it_pos)
3461 (back_to_previous_visible_line_start)
3462 (move_it_in_display_line_to, move_it_in_display_line)
3463 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3464 (try_scrolling, redisplay_window, display_line): Use them when
3465 saving a temporary copy of the iterator and restoring it back.
3466 (back_to_previous_visible_line_start, reseat_1)
3467 (init_iterator): Empty the bidi cache "stack".
3468 (move_it_in_display_line_to): If iterator ended up at
3469 EOL, but we never saw any buffer positions smaller than
3470 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3471 motion in bidi-reordered lines.
3472 (move_it_in_display_line_to): Record prev_method and prev_pos
3473 immediately before the call to set_iterator_to_next. Fixes cursor
3474 motion in bidi-reordered lines with stretch glyphs and strings
3475 displayed in margins. (Bug#8133) (Bug#8867)
3476 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3477 TO_CHARPOS.
3478 (pos_visible_p): Support positions in bidi-reordered lines.
3479 Save and restore bidi cache.
3480
3481 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3482 (bidi_paragraph_info): Delete unused struct.
3483 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3484 (bidi_cache_start): New variable.
3485 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3486 to zero.
3487 (bidi_cache_fetch_state, bidi_cache_search)
3488 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3489 (bidi_cache_find, bidi_peek_at_next_level)
3490 (bidi_level_of_next_char, bidi_find_other_level_edge)
3491 (bidi_move_to_visually_next): Compare cache index with
3492 bidi_cache_start rather than with zero.
3493 (bidi_fetch_char): Accept new argument STRING; all callers
3494 changed. Support iteration over a string. Support strings with
3495 display properties. Support unibyte strings. Fix the type of
3496 `len' according to what STRING_CHAR_AND_LENGTH expects.
3497 (bidi_paragraph_init, bidi_resolve_explicit_1)
3498 (bidi_resolve_explicit, bidi_resolve_weak)
3499 (bidi_level_of_next_char, bidi_move_to_visually_next):
3500 Support iteration over a string.
3501 (bidi_set_sor_type, bidi_resolve_explicit_1)
3502 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3503 can now be zero (for strings); special values 0 and -1 were
3504 changed to -1 and -2, respectively.
3505 (bidi_char_at_pos): New function.
3506 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3507 Call it instead of FETCH_MULTIBYTE_CHAR.
3508 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3509 initialized to valid values.
3510 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3511 values.
3512 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3513 the test for valid cached positions. Fix the logic for looking up
3514 the sentinel state in the cache. GCPRO the Lisp string we are
3515 iterating.
3516 (bidi_push_it, bidi_pop_it): New functions.
3517 (bidi_initialize): Initialize the bidi cache start stack pointer.
3518 (bidi_cache_ensure_space): New function, refactored from part of
3519 bidi_cache_iterator_state. Don't assume the required size is just
3520 one BIDI_CACHE_CHUNK away.
3521 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3522 (bidi_count_bytes, bidi_char_at_pos): New functions.
3523 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3524 always valid if bidi_cache_idx is valid.
3525 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3526 is valid if it's going to be used.
3527 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3528 (bidi_cache_fetch_state, bidi_cache_search)
3529 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3530 (bidi_cache_iterator_state, bidi_cache_find)
3531 (bidi_find_other_level_edge, bidi_cache_start_stack):
3532 All variables related to cache indices are now EMACS_INT.
3533
3534 * dispextern.h (struct bidi_string_data): New structure.
3535 (struct bidi_it): New member `string'. Make flag members be 1-bit
3536 fields, and put them last in the struct.
3537 (compute_display_string_pos, compute_display_string_end):
3538 Update prototypes.
3539 (bidi_push_it, bidi_pop_it): Add prototypes.
3540 (struct iterator_stack_entry): New members bidi_p,
3541 paragraph_embedding, and from_disp_prop_p.
3542 (struct it): Member bidi_p is now a bit field 1 bit wide.
3543 (bidi_shelve_cache, bidi_unshelve_cache):
3544 Declare prototypes.
3545
3546 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3547 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3548 and vector-like objects.
3549
3550 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3551 cache around display iteration.
3552
3553 * window.c (Fwindow_end, window_scroll_pixel_based)
3554 (displayed_window_lines, Frecenter): Save and restore the bidi
3555 cache around display iteration.
3556
3557 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3558
3559 * editfns.c (Fdelete_region): Clarify the use of the named
3560 parameters (bug#6788).
3561
3562 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3563
3564 * indent.c (Fvertical_motion): Set and restore w->pointm when
3565 saving and restoring the window's buffer (Bug#9006).
3566
3567 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3568
3569 * editfns.c (Fstring_to_char): Clarify just what is returned
3570 (bug#6576). Text by Eli Zaretskii.
3571
3572 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3575
3576 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3577
3578 * buffer.c (mmap_find): Fix a typo.
3579
3580 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3581
3582 Fix execution of x selection hooks.
3583 * xselect.c (Qx_lost_selection_functions)
3584 (Qx_sent_selection_functions): New vars.
3585 (syms_of_xselect): DEFSYM them.
3586 (x_handle_selection_request): Pass Qx_sent_selection_functions
3587 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3588 (x_handle_selection_clear,x_clear_frame_selections):
3589 Pass Qx_lost_selection_functions rather than
3590 Vx_lost_selection_functions to Frun_hook_with_args.
3591
3592 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3593
3594 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3595 The old code sometimes used this field without initializing it.
3596
3597 * alloc.c (gc_sweep): Don't read past end of array.
3598 In theory, the old code could also have corrupted Emacs internals,
3599 though it'd be very unlikely.
3600
3601 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3602
3603 * character.c (Fcharacterp): Don't advertise optional ignored
3604 argument. (Bug#4026)
3605
3606 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3607
3608 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3609 key" (bug#4257).
3610
3611 * window.c (Fset_window_start): Doc fix (bug#4199).
3612 (Fset_window_hscroll): Ditto.
3613
3614 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 Fix minor new problems caught by GCC 4.6.1.
3617 * term.c (init_tty): Remove unused local.
3618 * xsettings.c (store_monospaced_changed): Define this function only
3619 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3620 not used otherwise.
3621
3622 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3623
3624 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3625
3626 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3627
3628 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3629 are the mini-buffer and the echo area (bug#3320).
3630
3631 * term.c (init_tty): Remove support for supdup, c10 and perq
3632 terminals, which are no longer supported (bug#1482).
3633
3634 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3635
3636 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3637
3638 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3639
3640 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3641 for non-popups (Bug#3642).
3642
3643 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3644
3645 * alloc.c (reset_malloc_hooks): Protoize.
3646 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3647 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3648 * cm.c (losecursor): Likewise.
3649 * data.c (fmod): Likewise.
3650 * dispnew.c (swap_glyphs_in_rows): Likewise.
3651 * emacs.c (memory_warning_signal): Likewise.
3652 * floatfns.c (float_error): Likewise.
3653 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3654 (otf_open, font_otf_capability, generate_otf_features)
3655 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3656 Likewise.
3657 * image.c (pbm_read_file): Likewise.
3658 * indent.c (string_display_width): Likewise.
3659 * intervals.c (check_for_interval, search_for_interval)
3660 (inc_interval_count, count_intervals, root_interval)
3661 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3662 * lread.c (defalias): Likewise.
3663 * ralloc.c (r_alloc_check): Likewise.
3664 * regex.c (set_image_of_range_1, set_image_of_range)
3665 (regex_grow_registers): Likewise.
3666 * sysdep.c (strerror): Likewise.
3667 * termcap.c (valid_filename_p, tprint, main): Likewise.
3668 * tparam.c (main): Likewise.
3669 * unexhp9k800.c (run_time_remap, save_data_space)
3670 (update_file_ptrs, read_header, write_header, calculate_checksum)
3671 (copy_file, copy_rest, display_header): Likewise.
3672 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3673 Likewise.
3674 * xdisp.c (check_it): Likewise.
3675 * xfaces.c (register_color, unregister_color, unregister_colors):
3676 Likewise.
3677 * xfns.c (print_fontset_result): Likewise.
3678 * xrdb.c (member, fatal, main): Likewise.
3679
3680 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3681
3682 Fix minor problems found by static checking (Bug#9031).
3683 * chartab.c (char_table_set_range, map_sub_char_table):
3684 Remove unused locals.
3685 (uniprop_table): Now static.
3686 * composite.c (_work_char): Remove unused static var.
3687
3688 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3689
3690 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3691
3692 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3693
3694 * gtkutil.c (qttip_cb): Remove code without function.
3695
3696 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3697
3698 * w32.c (pthread_sigmask): New stub.
3699
3700 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 Use pthread_sigmask, not sigprocmask (Bug#9010).
3703 sigprocmask is portable only for single-threaded applications, and
3704 Emacs can be multi-threaded when it uses GTK.
3705 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3706 (LIBES): Use it.
3707 * callproc.c (Fcall_process):
3708 * process.c (create_process):
3709 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3710 Use pthread_sigmask, not sigprocmask.
3711
3712 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3713
3714 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3715 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3716 wrong (Bug#8591).
3717
3718 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3719
3720 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3721 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3722 (xg_hide_tooltip): Fix comment.
3723
3724 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3725 in registerServicesMenuSendTypes.
3726 (validRequestorForSendType): Don't check ns_return_types.
3727
3728 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3729 ns_return_type.
3730
3731 2011-07-08 Jason Rumney <jasonr@gnu.org>
3732
3733 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3734 SH_SHOW for hidden windows (Bug#5482).
3735
3736 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3737 frame struct members of non-existent frames (Bug#6284).
3738
3739 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3740
3741 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3742 variable firstTime not needed on OSX >= 10.6.
3743 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3744 >= 10.5. Use setKnobProportion, setDoubleValue.
3745
3746 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3747 (MAC_OS_X_VERSION_10_5): Define if not defined.
3748 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3749 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3750 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3751
3752 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3753 cString and lossyCString on OSX >= 10.4
3754
3755 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3756 sizeToFit on OSX >= 10.2.
3757
3758 * nsimage.m (allocInitFromFile): Don't use deprecated method
3759 bestRepresentationForDevice on OSX >= 10.6.
3760
3761 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3762 to avoid warning.
3763
3764 * emacs.c: Declare unexec_init_emacs_zone.
3765
3766 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3767
3768 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3769
3770 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3771 on svcsMenu (Bug#8842).
3772
3773 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3774 ns_return_types.
3775 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3776
3777 * nsterm.m (QUTF8_STRING): Declare.
3778 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3779 (validRequestorForSendType): Return type is (id).
3780 Change indexOfObjectIdenticalTo to indexOfObject.
3781 Check if we have local selection before returning self (Bug#8842).
3782 (writeSelectionToPasteboard): Put local selection into paste board
3783 if we have a local selection (Bug#8842).
3784 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3785
3786 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3787 (ns_get_local_selection): Declare.
3788
3789 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3790
3791 * keymap.c (describe_map_tree): Don't insert a double newline at
3792 the end of the buffer (bug#1169) and return whether we inserted
3793 something.
3794
3795 * callint.c (Fcall_interactively): Change "reading args" to
3796 "providing args" to try to clarify what it does (bug#1010).
3797
3798 2011-07-07 Kenichi Handa <handa@m17n.org>
3799
3800 * composite.c (composition_compute_stop_pos): Ignore a static
3801 composition starting before CHARPOS (Bug#8915).
3802
3803 * xdisp.c (handle_composition_prop): Likewise.
3804
3805 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3806
3807 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3808 (Bug#9015)
3809
3810 2011-07-07 Kenichi Handa <handa@m17n.org>
3811
3812 * character.h (unicode_category_t): New enum type.
3813
3814 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3815 (Qchar_code_property_table): New variable.
3816 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3817 (UNIPROP_COMPRESSED_FORM_P): New macros.
3818 (char_table_ascii): Uncompress the compressed values.
3819 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3820 Uncompress the compressed values.
3821 (sub_char_table_ref_and_range): Likewise.
3822 (char_table_ref_and_range): Uncompress the compressed values.
3823 (sub_char_table_set): New arg is_uniprop. Callers changed.
3824 Uncompress the compressed values.
3825 (sub_char_table_set_range): Args changed. Callers changed.
3826 (char_table_set_range): Adjuted for the above change.
3827 (map_sub_char_table): Delete args default_val and parent. Add arg
3828 top. Give decoded values to a Lisp function.
3829 (map_char_table): Adjust for the above change. Give decoded
3830 values to a Lisp function. Gcpro more variables.
3831 (uniprop_table_uncompress)
3832 (uniprop_decode_value_run_length): New functions.
3833 (uniprop_decoder, uniprop_decoder_count): New variables.
3834 (uniprop_get_decoder, uniprop_encode_value_character)
3835 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3836 New functions.
3837 (uniprop_encoder, uniprop_encoder_count): New variables.
3838 (uniprop_get_encoder, uniprop_table)
3839 (Funicode_property_table_internal, Fget_unicode_property_internal)
3840 (Fput_unicode_property_internal): New functions.
3841 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3842 Sunicode_property_table_internal, Sget_unicode_property_internal,
3843 and Sput_unicode_property_internal. Defvar_lisp
3844 char-code-property-alist.
3845
3846 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3847 Vunicode_category_table.
3848
3849 * font.c (font_range): Adjust for the change of
3850 Vunicode_category_table.
3851
3852 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3853
3854 * m/iris4d.h: Remove file, move contents ...
3855 * s/irix6-5.h: ... here.
3856
3857 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3858
3859 Remove unportable assumption about struct layout (Bug#8884).
3860 * alloc.c (mark_buffer):
3861 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3862 (clone_per_buffer_values): Don't assume that
3863 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3864 This isn't true in general, and it's particularly not true
3865 if Emacs is configured with --with-wide-int.
3866 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3867 New macros, used in the buffer.c change.
3868
3869 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3870
3871 * xsettings.c: Use both GConf and GSettings if both are available.
3872 (store_config_changed_event): Add comment.
3873 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3874 (store_tool_bar_style_changed): New functions.
3875 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3876 (struct xsettings): Move font inside HAVE_XFT.
3877 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3878 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3879 Move inside HAVE_XFT.
3880 (something_changed_gsettingsCB): Rename from something_changedCB.
3881 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3882 also.
3883 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3884 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3885 (something_changed_gconfCB): Rename from something_changedCB.
3886 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3887 (parse_settings): Move check for font inside HAVE_XFT.
3888 (read_settings, apply_xft_settings): Add comment.
3889 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3890 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3891 call store_font_name_changed.
3892 (xft_settings_event): Add comment.
3893 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3894 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3895 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3896 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3897 (xsettings_initialize): Call init_gsettings last.
3898 (xsettings_get_system_font, xsettings_get_system_normal_font):
3899 Add comment.
3900
3901 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3902
3903 Random fixes. E.g., (random) never returned negative values.
3904 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3905 subseconds part to the entropy, as that's a bit more random.
3906 Prefer signed to unsigned, since the signedness doesn't matter and
3907 in general we prefer signed. When given a limit, use a
3908 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3909 latter isn't right if USE_2_TAGS_FOR_INTS.
3910 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3911 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3912
3913 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3914
3915 * textprop.c (text_property_stickiness):
3916 Obey Vtext_property_default_nonsticky.
3917 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3918 * w32fns.c (syms_of_w32fns):
3919 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3920
3921 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3922
3923 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3924 This is more efficient than Ffile_directory_p and avoids a minor race.
3925
3926 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3927
3928 * buffer.c (Foverlay_put): Say what the return value is
3929 (bug#7835).
3930
3931 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3932 is a directory before asking whether to use the file name
3933 (bug#7564).
3934 (barf_or_query_if_file_exists): Make the "File is a directory"
3935 error be more correct.
3936
3937 * fns.c (Frequire): Remove the mention of the .gz files, since
3938 that's installation-specific, but keep the mention of
3939 `get-load-suffixes'.
3940
3941 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3944 Report string overflow if the output is too long.
3945
3946 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3947
3948 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3949 (syms_of_gnutls): Remove duplicate DEFSYM for
3950 Qgnutls_bootprop_verify_hostname_error, an error for
3951 Qgnutls_bootprop_verify_error (which is no longer used).
3952
3953 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3954 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3955 Also (re)move comments that are misplaced or no longer relevant.
3956
3957 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3958
3959 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3960
3961 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3962
3963 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3964 and background color parameters if they have been changed.
3965
3966 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3967
3968 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3969
3970 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3971
3972 * xsettings.c (SYSTEM_FONT): Define only when used.
3973 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3974
3975 * keymap.c (access_keymap_1): Now static.
3976
3977 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3978
3979 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3980 leave any prefix arg for the up event (Bug#1586).
3981
3982 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3983
3984 * lread.c (syms_of_lread): Mention single symbols defined by
3985 `defvar' or `defconst' (bug#7154).
3986
3987 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3988 (Frequire): Mention get-load-suffixes.
3989
3990 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3991
3992 * window.h (window): Remove clone_number slot.
3993 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3994 Remove.
3995 (make_parent_window, make_window, saved_window)
3996 (Fset_window_configuration, save_window_save): Don't deal with
3997 clone numbers.
3998 * buffer.c (Qclone_number): Remove declaration.
3999 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4000
4001 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4002
4003 Add multiple inheritance to keymaps.
4004 * keymap.c (Fmake_composed_keymap): New function.
4005 (Fset_keymap_parent): Simplify.
4006 (fix_submap_inheritance): Remove.
4007 (access_keymap_1): New function extracted from access_keymap to handle
4008 embedded parents and handle lists of maps.
4009 (access_keymap): Use it.
4010 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4011 (Fcopy_keymap): Handle embedded parents.
4012 (Fcommand_remapping, define_as_prefix): Simplify.
4013 (Fkey_binding): Simplify.
4014 (syms_of_keymap): Move minibuffer-local-completion-map,
4015 minibuffer-local-filename-completion-map,
4016 minibuffer-local-must-match-map, and
4017 minibuffer-local-filename-must-match-map to Elisp.
4018 (syms_of_keymap): Defsubr make-composed-keymap.
4019 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4020 (parse_menu_item): Trivial simplification.
4021
4022 2011-07-01 Glenn Morris <rgm@gnu.org>
4023
4024 * Makefile.in (SETTINGS_LIBS): Fix typo.
4025
4026 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4027
4028 * coding.c (Fencode_coding_string): Record the last coding system
4029 used, as the function doc string says (bug#8738).
4030
4031 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4032
4033 * xsettings.c (store_monospaced_changed): Take new font as arg and
4034 check for change against current_mono_font.
4035 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4036 (emacs_settings_constructor, emacs_settings_get_property)
4037 (emacs_settings_set_property, emacs_settings_class_init)
4038 (emacs_settings_init, gsettings_obj): Remove.
4039 (something_changedCB): New function for HAVE_GSETTINGS.
4040 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4041 with value as argument.
4042 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4043 g_settings_new (Bug#8967). Do not create gsettings_obj.
4044 Remove calls to g_settings_bind. Connect something_changedCB to
4045 "changed".
4046
4047 * xgselect.c: Add defined (HAVE_GSETTINGS).
4048 (xgselect_initialize): Ditto.
4049
4050 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4051 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4052 xg_select.
4053
4054 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4055
4056 * eval.c (struct backtrace): Simplify and port the data structure.
4057 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4058 signed bit field, as this assumption is not portable and it makes
4059 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4060 "char debug_on_exit : 1" as this is not portable either; instead,
4061 use the portable "unsigned int debug_on_exit : 1". Remove unused
4062 member evalargs. Remove obsolete comments about cc bombing out.
4063
4064 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4065
4066 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4067 Let HAVE_GSETTINGS override HAVE_GCONF.
4068 (store_monospaced_changed): New function.
4069 (EMACS_SETTINGS): A new type derived from GObject to handle
4070 GSettings notifications.
4071 (emacs_settings_constructor, emacs_settings_get_property)
4072 (emacs_settings_set_property, emacs_settings_class_init):
4073 New functions.
4074 (gsettings_client, gsettings_obj): New variables.
4075 (GSETTINGS_SCHEMA): New define.
4076 (something_changedCB): Call store_monospaced_changed.
4077 (init_gsettings): New function.
4078 (xsettings_initialize): Call init_gsettings.
4079 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4080 to NULL.
4081
4082 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4083 GCONF_CFLAGS/LIBS.
4084
4085 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4086
4087 * window.c (resize_root_window, grow_mini_window)
4088 (shrink_mini_window): Rename Qresize_root_window to
4089 Qwindow_resize_root_window and Qresize_root_window_vertically to
4090 Qwindow_resize_root_window_vertically.
4091
4092 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4093
4094 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4095
4096 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4097
4098 * makefile.w32-in: Redesign dependencies so they reflect more
4099 clearly which files are directly included by each source file,
4100 and not through other includes.
4101
4102 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4103
4104 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4105 (sort_overlays, overlay_strings): When an overlay's clone number
4106 matches the window's clone number process the overlay even if
4107 the overlay's window property doesn't match the current window.
4108
4109 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4110 (Fwindow_hchild): Rename to Fwindow_left_child.
4111 (Fwindow_next): Rename to Fwindow_next_sibling.
4112 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4113 (resize_window_check): Rename to window_resize_check.
4114 (resize_window_apply): Rename to window_resize_apply.
4115 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4116 (Fdelete_other_windows_internal, resize_frame_windows)
4117 (Fsplit_window_internal, Fdelete_window_internal)
4118 (grow_mini_window, shrink_mini_window)
4119 (Fresize_mini_window_internal): Fix callers accordingly.
4120
4121 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4122
4123 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4124 (emacs_fixed_set_min_size): Remove.
4125 (emacs_fixed_new): Take frame as argument.
4126
4127 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4128 (_EmacsFixedPrivate): Remove minwidth/height.
4129 Add struct frame *f.
4130 (emacs_fixed_init): Initialize priv->f.
4131 (get_parent_class, emacs_fixed_set_min_size): Remove.
4132 (emacs_fixed_new): Set priv->f to argument.
4133 (emacs_fixed_get_preferred_width)
4134 (emacs_fixed_get_preferred_height): Use min_width/height from
4135 frames size_hint to set minimum and natural (Bug#8919).
4136 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4137 and use min_width/height from frames size_hint to set
4138 min_width/height (Bug#8919).
4139
4140 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4141 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4142 Fix indentation.
4143
4144 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4145
4146 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4147 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4148 called at ZV.
4149
4150 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4151
4152 * process.c (wait_reading_process_output): Bypass select if
4153 waiting for a cell while ignoring keyboard input, and input is
4154 pending. Suggested by Jan Djärv (Bug#8869).
4155
4156 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4157
4158 Use gnulib's dup2 module instead of rolling our own.
4159 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4160
4161 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4162
4163 * dispnew.c (scrolling_window): Before scrolling, turn off a
4164 mouse-highlight in the window being scrolled.
4165
4166 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4167
4168 Move DEFSYM to lisp.h and use everywhere.
4169
4170 * character.h (DEFSYM): Move declaration...
4171 * lisp.h (DEFSYM): ...here.
4172
4173 * gnutls.c:
4174 * minibuf.c:
4175 * w32menu.c:
4176 * w32proc.c:
4177 * w32select.c: Don't include character.h.
4178
4179 * alloc.c (syms_of_alloc):
4180 * buffer.c (syms_of_buffer):
4181 * bytecode.c (syms_of_bytecode):
4182 * callint.c (syms_of_callint):
4183 * casefiddle.c (syms_of_casefiddle):
4184 * casetab.c (init_casetab_once):
4185 * category.c (init_category_once, syms_of_category):
4186 * ccl.c (syms_of_ccl):
4187 * cmds.c (syms_of_cmds):
4188 * composite.c (syms_of_composite):
4189 * dbusbind.c (syms_of_dbusbind):
4190 * dired.c (syms_of_dired):
4191 * dispnew.c (syms_of_display):
4192 * doc.c (syms_of_doc):
4193 * editfns.c (syms_of_editfns):
4194 * emacs.c (syms_of_emacs):
4195 * eval.c (syms_of_eval):
4196 * fileio.c (syms_of_fileio):
4197 * fns.c (syms_of_fns):
4198 * frame.c (syms_of_frame):
4199 * fringe.c (syms_of_fringe):
4200 * insdel.c (syms_of_insdel):
4201 * keymap.c (syms_of_keymap):
4202 * lread.c (init_obarray, syms_of_lread):
4203 * macros.c (syms_of_macros):
4204 * msdos.c (syms_of_msdos):
4205 * print.c (syms_of_print):
4206 * process.c (syms_of_process):
4207 * search.c (syms_of_search):
4208 * sound.c (syms_of_sound):
4209 * syntax.c (init_syntax_once, syms_of_syntax):
4210 * terminal.c (syms_of_terminal):
4211 * textprop.c (syms_of_textprop):
4212 * undo.c (syms_of_undo):
4213 * w32.c (globals_of_w32):
4214 * window.c (syms_of_window):
4215 * xdisp.c (syms_of_xdisp):
4216 * xfaces.c (syms_of_xfaces):
4217 * xfns.c (syms_of_xfns):
4218 * xmenu.c (syms_of_xmenu):
4219 * xsettings.c (syms_of_xsettings):
4220 * xterm.c (syms_of_xterm): Use DEFSYM.
4221
4222 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4223
4224 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4225
4226 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4227
4228 Integer and buffer overflow fixes (Bug#8873).
4229
4230 * print.c (printchar, strout): Check for string overflow.
4231 (PRINTPREPARE, printchar, strout):
4232 Don't set size unless allocation succeeds.
4233
4234 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4235 for sizes. Check for string overflow more accurately.
4236 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4237
4238 * macros.c: Integer and buffer overflow fixes.
4239 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4240 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4241 Use ptrdiff_t, not int, for sizes.
4242 Don't increment bufsize until after realloc succeeds.
4243 Check for size-calculation overflow.
4244 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4245
4246 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4247
4248 * lread.c: Integer overflow fixes.
4249 (read_integer): Radix is now EMACS_INT, not int,
4250 to improve quality of diagnostics for out-of-range radices.
4251 Calculate buffer size correctly for out-of-range radices.
4252 (read1): Check for integer overflow in radices, and in
4253 read-circle numbers.
4254 (read_escape): Avoid int overflow.
4255 (Fload, openp, read_buffer_size, read1)
4256 (substitute_object_recurse, read_vector, read_list, map_obarray):
4257 Use ptrdiff_t, not int, for sizes.
4258 (read1): Use EMACS_INT, not int, for sizes.
4259 Check for size overflow.
4260
4261 * image.c (cache_image): Check for size arithmetic overflow.
4262
4263 * lread.c: Integer overflow issues.
4264 (saved_doc_string_size, saved_doc_string_length)
4265 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4266 Now ptrdiff_t, not int.
4267 (read1): Don't assume doc string length fits in int. Check for
4268 out-of-range doc string lengths.
4269 (read_list): Don't assume file position fits in int.
4270 (read_escape): Check for hex character overflow.
4271
4272 2011-06-22 Leo Liu <sdl.web@gmail.com>
4273
4274 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4275 Move to minibuffer.el.
4276
4277 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4278
4279 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4280 The following patches are for when GLYPH_DEBUG && !XASSERT.
4281 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4282 * dispnew.c (flush_stdout):
4283 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4284 Mark as externally visible.
4285 * dispnew.c (check_window_matrix_pointers): Now static.
4286 * dispnew.c (window_to_frame_vpos):
4287 * xfns.c (unwind_create_frame):
4288 * xterm.c (x_check_font): Remove unused local.
4289 * scroll.c (CHECK_BOUNDS):
4290 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4291 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4292 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4293 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4294 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4295 Now static.
4296 (debug_method_add): Use va_list and vsprintf rather than relying
4297 on undefined behavior with wrong number of arguments.
4298 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4299 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4300 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4301 since we're not interested in debugging glyphs with old libraries.
4302 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4303 GCC 4.6.0's static checking.
4304
4305 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 Integer overflow and signedness fixes (Bug#8873).
4308 A few related buffer overrun fixes, too.
4309
4310 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4311
4312 * dispextern.h (struct face.stipple):
4313 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4314 (x_bitmap_mask, x_allocate_bitmap_record)
4315 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4316 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4317 (x_create_bitmap_from_xpm_data):
4318 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4319 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4320 (.bitmaps_last):
4321 * xfaces.c (load_pixmap):
4322 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4323 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4324 (.bitmaps_last, struct x_output.icon_bitmap):
4325 Use ptrdiff_t, not int, for bitmap indexes.
4326 (x_allocate_bitmap_record): Check for size overflow.
4327 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4328
4329 Use ptrdiff_t, not int, for overlay counts.
4330 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4331 * editfns.c (overlays_around, get_pos_property):
4332 * textprop.c (get_char_property_and_overlay):
4333 * xdisp.c (next_overlay_change, note_mouse_highlight):
4334 * xfaces.c (face_at_buffer_position):
4335 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4336 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4337 (Fnext_overlay_change, Fprevious_overlay_change)
4338 (mouse_face_overlay_overlaps, Foverlays_in):
4339 Use ptrdiff_t, not int, for sizes.
4340 (overlays_at, overlays_in): Check for size-calculation overflow.
4341
4342 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4343
4344 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4345 (x_session_initialize): Do not assume string length fits in int.
4346
4347 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4348 This is unlikely, but can occur if DPI is outlandish.
4349
4350 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4351 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4352
4353 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4354 * xrdb.c (magic_file_p, search_magic_path):
4355 Omit last arg SUFFIX; it was always 0. All callers changed.
4356 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4357
4358 * xfont.c (xfont_match): Avoid need for strlen.
4359
4360 * xfns.c: Don't assume strlen fits in int.
4361 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4362
4363 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4364 not unsigned long, as we prefer signed integers. All callers changed.
4365 Detect integer overflow in repeat count.
4366 (message_dolog): Don't assume print length fits in 39 bytes.
4367 (display_mode_element): Don't assume strlen fits in int.
4368
4369 * termcap.c: Don't assume sizes fit in int and never overflow.
4370 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4371 (gobble_line): Check for size-calculation overflow.
4372
4373 * minibuf.c (Fread_buffer):
4374 * lread.c (intern, intern_c_string):
4375 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4376 Don't assume string length fits in int.
4377
4378 * keyboard.c (parse_tool_bar_item):
4379 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4380
4381 * font.c: Don't assume string length fits in int.
4382 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4383 Use ptrdiff_t, not int.
4384 (font_intern_prop): Don't assume string length fits in int.
4385 Don't assume integer property fits in fixnum.
4386 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4387
4388 * filelock.c: Fix some buffer overrun and integer overflow issues.
4389 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4390 Reformulate so as not to need the command string.
4391 Invoke gzip -cd rather than gunzip, as it's more portable.
4392 (lock_info_type, lock_file_1, lock_file):
4393 Don't assume pid_t and time_t fit in unsigned long.
4394 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4395 (current_lock_owner): Prefer signed type for sizes.
4396 Use memcpy, not strncpy, where memcpy is what is really wanted.
4397 Don't assume (via atoi) that time_t and pid_t fit in int.
4398 Check for time_t and/or pid_t out of range, e.g., via a network share.
4399 Don't alloca where an auto var works fine.
4400
4401 * fileio.c: Fix some integer overflow issues.
4402 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4403 Don't assume string length fits in int.
4404 (directory_file_name): Don't assume string length fits in long.
4405 (make_temp_name): Don't assume pid fits in int, or that its print
4406 length is less than 20.
4407
4408 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4409
4410 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4411
4412 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4413
4414 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4415 We prefer signed integers, even for size calculations.
4416
4417 * emacs.c: Don't assume string length fits in 'int'.
4418 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4419 (main): Don't invoke strlen when not needed.
4420
4421 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4422 (XD_DEBUG_MESSAGE): Don't waste a byte.
4423
4424 * callproc.c (getenv_internal_1, getenv_internal)
4425 (Fgetenv_internal):
4426 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4427
4428 * lread.c (invalid_syntax): Omit length argument.
4429 All uses changed. This doesn't fix a bug, but it simplifies the
4430 code away from its former Hollerith-constant appearance, and it's
4431 one less 'int' to worry about when looking at integer-overflow issues.
4432 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4433
4434 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4435 This didn't break anything, but it didn't help either.
4436 It's confusing to put a bogus integer in a place where the actual
4437 value does not matter.
4438 (LIST_END_P): Remove unused macro and its bogus comment.
4439 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4440
4441 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4442 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4443 implementation.
4444 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4445 We prefer signed types, and the value cannot exceed the EMACS_INT
4446 range anyway (because otherwise the length would not be representable).
4447 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4448 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4449 This avoids a GCC warning when WIDE_EMACS_INT.
4450
4451 * indent.c (sane_tab_width): New function.
4452 (current_column, scan_for_column, Findent_to, position_indentation)
4453 (compute_motion): Use it. This is just for clarity.
4454 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4455
4456 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4457
4458 * lisp.h (lint_assume): New macro.
4459 * composite.c (composition_gstring_put_cache):
4460 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4461
4462 * editfns.c, insdel.c:
4463 Omit unnecessary forward decls, to simplify future changes.
4464
4465 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4466
4467 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4468
4469 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4470 Use much-faster test for byte-length change.
4471 Don't assume string byte-length fits in 'int'.
4472 Check that character arg fits in 'int'.
4473 (mapcar1): Declare byte as byte, for clarity.
4474
4475 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4476
4477 * fns.c (concat): Catch string overflow earlier.
4478 Do not rely on integer wraparound.
4479
4480 * dispextern.h (struct it.overlay_strings_charpos)
4481 (struct it.selective): Now EMACS_INT, not int.
4482 * xdisp.c (forward_to_next_line_start)
4483 (back_to_previous_visible_line_start)
4484 (reseat_at_next_visible_line_start, next_element_from_buffer):
4485 Don't arbitrarily truncate the value of 'selective' to int.
4486
4487 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4488
4489 * composite.c: Don't truncate sizes to 'int'.
4490 (composition_gstring_p, composition_reseat_it)
4491 (composition_adjust_point): Use EMACS_INT, not int.
4492 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4493 not EMACS_UINT, for indexes.
4494
4495 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4496
4497 * buffer.c: Include <verify.h>.
4498 (struct sortvec.priority, struct sortstr.priority):
4499 Now EMACS_INT, not int.
4500 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4501 (struct sortstr.size, record_overlay_string)
4502 (struct sortstrlist.size, struct sortlist.used):
4503 Don't truncate size to int.
4504 (record_overlay_string): Check for size-calculation overflow.
4505 (init_buffer_once): Check at compile-time, not run-time.
4506
4507 2011-06-22 Jim Meyering <meyering@redhat.com>
4508
4509 Don't leak an XBM-image-sized buffer
4510 * image.c (xbm_load): Free the image buffer after using it.
4511
4512 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4513
4514 Port to Sun C.
4515 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4516 that Sun C diagnosed.
4517 * fns.c (secure_hash): Fix pointer signedness issue.
4518 * intervals.c (static_offset_intervals): New function.
4519 (offset_intervals): Use it.
4520
4521 2011-06-21 Leo Liu <sdl.web@gmail.com>
4522
4523 * deps.mk (fns.o):
4524 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4525 sha512.h.
4526
4527 * fns.c (secure_hash): Rename from crypto_hash_function and change
4528 the first arg to accept symbols.
4529 (Fsecure_hash): New primitive.
4530 (syms_of_fns): New symbols.
4531
4532 2011-06-20 Deniz Dogan <deniz@dogan.se>
4533
4534 * process.c (Fset_process_buffer): Clarify return value in
4535 docstring.
4536
4537 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4538
4539 * dispnew.c (add_window_display_history): Use BVAR.
4540
4541 * xdisp.c (debug_method_add): Use BVAR.
4542 (check_window_end, dump_glyph_matrix, dump_glyph)
4543 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4544
4545 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4546 Likewise.
4547
4548 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4549 check till after the cache is created in init_frame_faces.
4550
4551 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4552
4553 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4554
4555 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4556
4557 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4558 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4559 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4560
4561 Improve buffer-overflow checking (Bug#8873).
4562 * fileio.c (Finsert_file_contents):
4563 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4564 Remove the old (too-loose) buffer overflow checks.
4565 They weren't needed, since make_gap checks for buffer overflow.
4566 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4567 The old code merely checked for Emacs fixnum overflow, and relied
4568 on undefined (wraparound) behavior. The new code avoids undefined
4569 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4570
4571 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4572 Tune. Don't use wider integers than needed. Don't use alloca.
4573 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4574
4575 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4576
4577 * insdel.c, lisp.h (buffer_overflow): New function.
4578 (insert_from_buffer_1, replace_range, replace_range_2):
4579 * insdel.c (make_gap_larger):
4580 * editfns.c (Finsert_char):
4581 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4582
4583 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4584
4585 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4586
4587 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4588
4589 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4590 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4591
4592 * fileio.c: Don't assume EMACS_INT fits in off_t.
4593 (emacs_lseek): New static function.
4594 (Finsert_file_contents, Fwrite_region): Use it.
4595 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4596
4597 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4598
4599 * fns.c: Don't overflow int when computing a list length.
4600 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4601 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4602 truncation on 64-bit hosts. Check for QUIT every
4603 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4604 faster and is responsive enough.
4605 (Flength): Report an error instead of overflowing an integer.
4606 (Fsafe_length): Return a float if the value is not representable
4607 as a fixnum. This shouldn't happen except in contrived situations.
4608 (Fnthcdr, Fsort): Don't assume list length fits in int.
4609 (Fcopy_sequence): Don't assume vector length fits in int.
4610
4611 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4612 (header_size, word_size): New constants.
4613 (allocate_vectorlike): Don't check size overflow here.
4614 (allocate_vector): Check it here instead, since this is the only
4615 caller of allocate_vectorlike that could cause overflow.
4616 Check that the new vector's length is representable as a fixnum.
4617
4618 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4619 The previous code was bogus. For example, next_almost_prime (32)
4620 returned 39, which is undesirable as it is a multiple of 3; and
4621 next_almost_prime (24) returned 25, which is a multiple of 5 so
4622 why was the code bothering to check for multiples of 7?
4623
4624 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4625
4626 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4627
4628 Variadic C functions now count arguments with ptrdiff_t.
4629 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4630 Back then I didn't know that the Emacs coding style prefers signed int.
4631 Also, in the meantime I found a few more instances where arguments
4632 were being counted with int, which may truncate counts on 64-bit
4633 machines, or EMACS_INT, which may be unnecessarily wide.
4634 * lisp.h (struct Lisp_Subr.function.aMANY)
4635 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4636 Arg counts are now ptrdiff_t, not size_t.
4637 All variadic functions and their callers changed accordingly.
4638 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4639 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4640 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4641 * callint.c (Fcall_interactively): Check arg count for overflow,
4642 to avoid potential buffer overrun. Use signed char, not 'int',
4643 for 'varies' array, so that we needn't bother to check its size
4644 calculation for overflow.
4645 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4646 * eval.c (apply_lambda):
4647 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4648 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4649 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4650
4651 * callint.c (Fcall_interactively): Don't use index var as event count.
4652
4653 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4654 * mem-limits.h (SIZE): Remove; no longer used.
4655
4656 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4657
4658 Remove unnecessary casts.
4659 * xterm.c (x_term_init):
4660 * xfns.c (x_set_border_pixel):
4661 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4662 These aren't needed now that we assume ANSI C.
4663
4664 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4665 It's more likely to cause problems (due to unsigned overflow)
4666 than to cure them.
4667
4668 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4669
4670 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4671
4672 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4673
4674 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4675
4676 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4677
4678 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4679
4680 GLYPH_CODE_FACE returns EMACS_INT, not int.
4681 * dispextern.h (merge_faces):
4682 * xfaces.c (merge_faces):
4683 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4684 Don't assume EMACS_INT fits in int.
4685
4686 * character.h (CHAR_VALID_P): Remove unused parameter.
4687 * fontset.c, lisp.h, xdisp.c: All uses changed.
4688
4689 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4690
4691 * fns.c (concat): Minor tuning based on overflow analysis.
4692 This doesn't fix any bugs. Use int to hold character, instead
4693 of constantly refetching from Emacs object. Use XFASTINT, not
4694 XINT, for value known to be a character. Don't bother comparing
4695 a single byte to 0400, as it's always less.
4696
4697 * floatfns.c (Fexpt):
4698 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4699
4700 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4701 for characters.
4702
4703 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4704
4705 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4706 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4707 incorrectly succeed when S was a string, because 4294967386 was
4708 truncated before it was used.
4709
4710 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4711 Otherwise, an out-of-range integer could cause undefined behavior
4712 on a 64-bit host.
4713
4714 * composite.c: Use int, not EMACS_INT, for characters.
4715 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4716 EMACS_INT, for values that are known to be in character range.
4717 This doesn't fix any bugs but is the usual style inside Emacs and
4718 may generate better code on 32-bit machines.
4719
4720 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4721 This is for reasons similar to the recent CHAR_STRING fix.
4722 * charset.c (Fencode_char): Check that character arg is actually
4723 a character. Pass an int to ENCODE_CHAR.
4724 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4725 wider than 'int', as a compile-time check to prevent future regressions
4726 in this area.
4727
4728 * character.c (char_string): Remove unnecessary casts.
4729
4730 Make sure a 64-bit char is never passed to CHAR_STRING.
4731 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4732 by silently ignoring the top 32 bits, allowing some values
4733 that were far too large to be valid characters.
4734 * character.h: Include <verify.h>.
4735 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4736 arguments are no wider than unsigned, as a compile-time check
4737 to prevent future regressions in this area.
4738 * data.c (Faset):
4739 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4740 (Fsubst_char_in_region):
4741 * fns.c (concat):
4742 * xdisp.c (decode_mode_spec_coding):
4743 Adjust to CHAR_STRING's new requirement.
4744 * editfns.c (Finsert_char, Fsubst_char_in_region):
4745 * fns.c (concat): Check that character args are actually
4746 characters. Without this test, these functions did the wrong
4747 thing with wildly out-of-range values on 64-bit hosts.
4748
4749 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4750 These casts should not be needed on 32-bit hosts, either.
4751 * keyboard.c (read_char):
4752 * lread.c (Fload): Remove casts to unsigned.
4753
4754 * lisp.h (UNSIGNED_CMP): New macro.
4755 This fixes comparison bugs on 64-bit hosts.
4756 (ASCII_CHAR_P): Use it.
4757 * casefiddle.c (casify_object):
4758 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4759 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4760 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4761 * dispextern.h (FACE_FROM_ID):
4762 * keyboard.c (read_char): Use UNSIGNED_CMP.
4763
4764 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4765 not to EMACS_INT, to avoid GCC warning.
4766
4767 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4768
4769 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4770 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4771 isn't needed on 32-bit machines.
4772
4773 * buffer.c (Fgenerate_new_buffer_name):
4774 Use EMACS_INT for count, not int.
4775 (advance_to_char_boundary): Return EMACS_INT, not int.
4776
4777 * data.c (Qcompiled_function): Now static.
4778
4779 * window.c (window_body_lines): Now static.
4780
4781 * image.c (gif_load): Rename local to avoid shadowing.
4782
4783 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4784 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4785 * alloc.c (make_save_value): Integer argument is now of type
4786 ptrdiff_t, not int.
4787 (mark_object): Use ptrdiff_t, not int.
4788 * lisp.h (pD): New macro.
4789 * print.c (print_object): Use it.
4790
4791 * alloc.c: Use EMACS_INT, not int, to count objects.
4792 (total_conses, total_markers, total_symbols, total_vector_size)
4793 (total_free_conses, total_free_markers, total_free_symbols)
4794 (total_free_floats, total_floats, total_free_intervals)
4795 (total_intervals, total_strings, total_free_strings):
4796 Now EMACS_INT, not int. All uses changed.
4797 (Fgarbage_collect): Compute overall total using a double, so that
4798 integer overflow is less likely to be a problem. Check for overflow
4799 when converting back to an integer.
4800 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4801 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4802 These were 'int' variables that could overflow on 64-bit hosts;
4803 they were never used, so remove them instead of repairing them.
4804 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4805 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4806 Previously, this ceilinged at INT_MAX, but that doesn't work on
4807 64-bit machines.
4808 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4809
4810 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4811 (allocate_vectorlike): Check for ptrdiff_t overflow.
4812 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4813 when a (possibly-narrower) signed value would do just as well.
4814 We prefer using signed arithmetic, to avoid comparison confusion.
4815
4816 * alloc.c: Catch some string size overflows that we were missing.
4817 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4818 for convenience in STRING_BYTES_MAX.
4819 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4820 The definition here is exact; the one in lisp.h was approximate.
4821 (allocate_string_data): Check for string overflow. This catches
4822 some instances we weren't catching before. Also, it catches
4823 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4824 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4825 and ptrdiff_t and EMACS_INT are both 64 bits.
4826
4827 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4828 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4829 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4830
4831 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4832
4833 * alloc.c (Fmake_string): Check for out-of-range init.
4834
4835 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4836
4837 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4838
4839 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4840
4841 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4842 xg_get_default_scrollbar_width.
4843
4844 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4845 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4846 (style_changed_cb): Call update_theme_scrollbar_width and call
4847 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4848 all frames (Bug#8505).
4849 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4850 Call gtk_window_set_resizable if HAVE_GTK3.
4851 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4852 and height if HAVE_GTK3 (Bug#8505).
4853 (scroll_bar_width_for_theme): New variable.
4854 (update_theme_scrollbar_width): New function.
4855 (xg_get_default_scrollbar_width): Move code to
4856 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4857 (xg_initialize): Call update_theme_scrollbar_width.
4858
4859 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4860
4861 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4862
4863 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4864
4865 * frame.c (make_frame): Call other_buffer_safely instead of
4866 other_buffer.
4867
4868 * window.c (temp_output_buffer_show): Call display_buffer with
4869 second argument Vtemp_buffer_show_specifiers and reset latter
4870 immediately after the call.
4871 (Vtemp_buffer_show_specifiers): New variable.
4872 (auto_window_vscroll_p, next_screen_context_lines)
4873 (Vscroll_preserve_screen_position): Remove leading asterisks from
4874 doc-strings.
4875
4876 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4877
4878 Fix minor problems found by GCC 4.6.0 static checking.
4879 * buffer.c (Qclone_number): Remove for now, as it's unused.
4880 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4881 (record_buffer): Remove unused local.
4882 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4883 (set_frame_buffer_list): Remove; unused.
4884 * frame.h (other_visible_frames): Remove decl.
4885 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4886 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4887 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4888 if HAVE_GPM.
4889 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4890 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4891 Define only if HAVE_GPM.
4892 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4893 (update_hints_inhibit): Remove; never set. All uses removed.
4894 * widgetprv.h (emacsFrameClassRec): Remove decl.
4895 * window.c (delete_deletable_window): Now returns void, since it
4896 wasn't returning anything.
4897 (compare_window_configurations): Remove unused locals.
4898 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4899 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4900 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4901 the same widths as pointers. This follows up on the 2011-05-06 patch.
4902 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4903 * xterm.h: Likewise.
4904 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4905
4906 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4907
4908 * makefile.w32-in: Update dependencies.
4909 (LISP_H): Add lib/intprops.h.
4910
4911 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4912
4913 * image.c (gif_load): Add animation frame delay to the metadata.
4914 (syms_of_image): Use DEFSYM. New symbol `delay'.
4915
4916 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4917
4918 * window.c (delete_deletable_window): Re-add.
4919 (Fset_window_configuration): Rewrite to handle dead buffers and
4920 consequently deletable windows.
4921 (window_tree, Fwindow_tree): Remove. Supply functionality in
4922 window.el.
4923 (compare_window_configurations): Simplify code.
4924
4925 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4926
4927 * image.c (imagemagick_load_image): Fix type mismatch.
4928 (Fimagemagick_types): Likewise.
4929
4930 * window.h (replace_buffer_in_windows): Declare.
4931
4932 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4933
4934 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4935 Qclone_number. Remove external declaration of Qdelete_window.
4936 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4937 code.
4938 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4939 Run Qbuffer_list_update_hook if allowed.
4940 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4941 buffer list implementation.
4942 (other_buffer_safely): New function.
4943 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4944 calls to replace_buffer_in_windows and
4945 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4946 if allowed.
4947 (record_buffer): Inhibit quitting and rewrite using quittable
4948 functions. Run Qbuffer_list_update_hook if allowed.
4949 (Frecord_buffer, Funrecord_buffer): New functions.
4950 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4951 Move switch-to-buffer to window.el.
4952 (bury-buffer): Move to window.el.
4953 (Vbuffer_list_update_hook): New variable.
4954
4955 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4956 section.
4957
4958 * window.h (resize_frame_windows): Move up in code.
4959 (Fwindow_frame): Remove EXFUN.
4960 (replace_buffer_in_all_windows): Remove prototype.
4961 (replace_buffer_in_windows_safely): Add prototype.
4962
4963 * window.c: Declare Qdelete_window static again. Move down
4964 declaration of select_count.
4965 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4966 (Fother_window): Move to window.el.
4967 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4968 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4969 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4970 window.el.
4971 (replace_buffer_in_windows): Implement by calling
4972 Qreplace_buffer_in_windows.
4973 (replace_buffer_in_all_windows): Remove with some functionality
4974 moved into replace_buffer_in_windows_safely.
4975 (replace_buffer_in_windows_safely): New function.
4976 (select_window_norecord, select_frame_norecord): Move in front
4977 of run_window_configuration_change_hook. Remove now obsolete
4978 declarations.
4979 (Fset_window_buffer): Rewrite doc-string.
4980 Call Qrecord_window_buffer.
4981 (keys_of_window): Move binding for other-window to window.el.
4982
4983 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4984
4985 * dispextern.h (struct image): Replace data member, whose int_val
4986 and ptr_val fields were not used by anything, with a single
4987 lisp_val object.
4988
4989 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4990 (gif_clear_image, gif_load, imagemagick_load_image)
4991 (gs_clear_image, gs_load): Callers changed.
4992
4993 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4994
4995 * buffer.h: Include <time.h>, for time_t.
4996 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4997
4998 Fix minor problems found by static checking.
4999
5000 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5001
5002 Make identifiers static if they are not used in other modules.
5003 * data.c (Qcompiled_function, Qframe, Qvector):
5004 * image.c (QimageMagick, Qsvg):
5005 * minibuf.c (Qmetadata):
5006 * window.c (resize_window_check, resize_root_window): Now static.
5007 * window.h (resize_window_check, resize_root_window): Remove decls.
5008
5009 * window.c (window_deletion_count, delete_deletable_window):
5010 Remove; unused.
5011 (window_body_lines): Now static.
5012 (Fdelete_other_windows_internal): Mark vars as initialized.
5013 Make sure 'resize_failed' is initialized.
5014 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5015 (resize_window_apply): Remove unused local.
5016 * window.h (delete_deletable_window): Remove decl.
5017
5018 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5019 (imagemagick_load_image): Fix pointer signedness problem by changing
5020 last arg from unsigned char * to char *. All uses changed.
5021 Also, fix a local for similar reasons.
5022 Remove unused locals. Remove locals to avoid shadowing.
5023 (fn_rsvg_handle_free): Remove; unused.
5024 (svg_load, svg_load_image): Fix pointer signedness problem.
5025 (imagemagick_load_image): Don't use garbage pointer image_wand.
5026
5027 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5028
5029 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5030
5031 * image.c (gif_load): Fix omitted cast error introduced by
5032 2011-06-06 change.
5033
5034 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5035
5036 * window.h (resize_proportionally, orig_total_lines)
5037 (orig_top_line): Remove from window structure.
5038 (set_window_height, set_window_width, change_window_heights)
5039 (Fdelete_window): Remove prototypes.
5040 (resize_frame_windows): Remove duplicate declaration.
5041
5042 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5043
5044 * window.h (resize_frame_windows, resize_window_check)
5045 (delete_deletable_window, resize_root_window)
5046 (resize_frame_windows): Declare prototypes.
5047
5048 * window.c (resize_window_apply): Make definition be "static" to
5049 match the prototype.
5050
5051 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5052
5053 * window.c: Remove declarations of Qwindow_size_fixed,
5054 window_min_size_1, window_min_size_2, window_min_size,
5055 size_window, window_fixed_size_p, enlarge_window, delete_window.
5056 Remove static from declaration of Qdelete_window, it's
5057 temporarily needed by Fbury_buffer.
5058 (replace_window): Don't assign orig_top_line and
5059 orig_total_lines.
5060 (Fdelete_window, delete_window): Remove. Window deletion is
5061 handled by window.el.
5062 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5063 Replace Fdelete_window calls with calls to Qdelete_window.
5064 (Fdelete_other_windows): Remove. Deleting other windows is
5065 handled by window.el.
5066 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5067 handled in window.el.
5068 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5069 Window minimum sizes are handled in window.el.
5070 (shrink_windows, size_window, set_window_height)
5071 (set_window_width, change_window_heights, window_height)
5072 (window_width, CURBEG, CURSIZE, enlarge_window)
5073 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5074 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5075 handled in window.el.
5076 (make_dummy_parent): Rename to make_parent_window and give it a
5077 second argument horflag.
5078 (make_window): Don't set resize_proportionally any more.
5079 (Fsplit_window): Remove. Windows are split in window.el.
5080 (save_restore_action, save_restore_orig_size)
5081 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5082 Resize mini windows in window.el.
5083 (grow_mini_window, shrink_mini_window): Implement by calling
5084 Qresize_root_window_vertically, resize_window_check and
5085 resize_window_apply.
5086 (saved_window, Fset_window_configuration, save_window_save):
5087 Do not handle orig_top_line, orig_total_lines, and
5088 resize_proportionally.
5089 (window_min_height, window_min_width): Move to window.el.
5090 (keys_of_window): Move bindings for delete-other-windows,
5091 split-window, delete-window and enlarge-window to window.el.
5092
5093 * buffer.c: Temporarily extern Qdelete_window.
5094 (Fbury_buffer): Temporarily call Qdelete_window instead of
5095 Fdelete_window (Fbury_buffer will move to window.el soon).
5096
5097 * frame.c (set_menu_bar_lines_1): Remove code handling
5098 orig_top_line and orig_total_lines.
5099
5100 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5101 set_window_height but set heights directly.
5102 (change_frame_size_1): Use resize_frame_windows.
5103
5104 * xdisp.c (init_xdisp): Don't use set_window_height but set
5105 heights directly.
5106
5107 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5108 Use resize_frame_windows instead of change_window_heights and run
5109 run_window_configuration_change_hook.
5110
5111 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5112 instead of change_window_heights and run
5113 run_window_configuration_change_hook.
5114
5115 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5116
5117 * window.c (replace_window): Rename second argument REPLACEMENT to
5118 NEW. New third argument SETFLAG. Rewrite.
5119 (delete_window, make_dummy_parent): Call replace_window with
5120 third argument 1.
5121 (window_list_1): Move down in code.
5122 (run_window_configuration_change_hook): Move set_buffer part
5123 before select_frame_norecord part in order to unwind correctly.
5124 Rename count1 to count.
5125 (recombine_windows, delete_deletable_window, resize_root_window)
5126 (Fdelete_other_windows_internal)
5127 (Frun_window_configuration_change_hook, make_parent_window)
5128 (resize_window_check, resize_window_apply, Fresize_window_apply)
5129 (resize_frame_windows, Fsplit_window_internal)
5130 (Fdelete_window_internal, Fresize_mini_window_internal):
5131 New functions.
5132 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5133
5134 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5135
5136 * window.h (window): Add some new members to window structure -
5137 normal_lines, normal_cols, new_total, new_normal, clone_number,
5138 splits, nest, prev_buffers, next_buffers.
5139 (WINDOW_TOTAL_SIZE): Move here from window.c.
5140 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5141
5142 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5143 Remove.
5144 (make_dummy_parent): Set new members of windows structure.
5145 (make_window): Move down in code. Handle new members of window
5146 structure.
5147 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5148 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5149 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5150 (Fset_window_prev_buffers, Fwindow_next_buffers)
5151 (Fset_window_next_buffers, Fset_window_clone_number):
5152 New functions.
5153 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5154 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5155 Doc-string fixes.
5156 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5157 Argument WINDOW can be now internal window too.
5158 (Fwindow_use_time): Move up in code.
5159 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5160 Rewrite doc-string.
5161 (Fset_window_configuration, saved_window)
5162 (Fcurrent_window_configuration, save_window_save): Handle new
5163 members of window structure.
5164 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5165 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5166 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5167 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5168 Qget_mru_window, Qresize_root_window,
5169 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5170 Qauto_buffer_name; staticpro them.
5171
5172 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5173
5174 * window.c (Fwindow_total_size, Fwindow_left_column)
5175 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5176 (Fwindow_list_1): New functions.
5177 (window_box_text_cols): Replace with window_body_cols.
5178 (Fwindow_width, Fscroll_left, Fscroll_right):
5179 Use window_body_cols instead of window_box_text_cols.
5180 (delete_window, Fset_window_configuration):
5181 Call delete_all_subwindows with window as argument.
5182 (delete_all_subwindows): Take a window as argument and not a
5183 structure. Rewrite.
5184 (window_loop): Remove handling of GET_LRU_WINDOW and
5185 GET_LARGEST_WINDOW.
5186 (Fget_lru_window, Fget_largest_window): Move to window.el.
5187
5188 * window.h: Extern window_body_cols instead of
5189 window_box_text_cols. delete_all_subwindows now takes a
5190 Lisp_Object as argument.
5191
5192 * indent.c (compute_motion, Fcompute_motion):
5193 Use window_body_cols instead of window_box_text_cols.
5194
5195 * frame.c (delete_frame): Call delete_all_subwindows with root
5196 window as argument.
5197
5198 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5199
5200 * fns.c (Fputhash): Document return value.
5201
5202 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5203
5204 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5205
5206 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5207
5208 Cons<->int and similar integer overflow fixes (Bug#8794).
5209
5210 Check for overflow when converting integer to cons and back.
5211 * charset.c (Fdefine_charset_internal, Fdecode_char):
5212 Use cons_to_unsigned to catch overflow.
5213 (Fencode_char): Use INTEGER_TO_CONS.
5214 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5215 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5216 * data.c (long_to_cons, cons_to_long): Remove.
5217 (cons_to_unsigned, cons_to_signed): New functions.
5218 These signal an error for invalid or out-of-range values.
5219 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5220 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5221 * font.c (Ffont_variation_glyphs):
5222 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5223 * lisp.h: Include <intprops.h>.
5224 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5225 (cons_to_signed, cons_to_unsigned): New decls.
5226 (long_to_cons, cons_to_long): Remove decls.
5227 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5228 (Fprimitive_undo): Use CONS_TO_INTEGER.
5229 * xfns.c (Fx_window_property): Likewise.
5230 * xselect.c: Include <limits.h>.
5231 (x_own_selection, selection_data_to_lisp_data):
5232 Use INTEGER_TO_CONS.
5233 (x_handle_selection_request, x_handle_selection_clear)
5234 (x_get_foreign_selection, Fx_disown_selection_internal)
5235 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5236 (lisp_data_to_selection_data): Use cons_to_unsigned.
5237 (x_fill_property_data): Use cons_to_signed.
5238 Report values out of range.
5239
5240 Check for buffer and string overflow more precisely.
5241 * buffer.h (BUF_BYTES_MAX): New macro.
5242 * lisp.h (STRING_BYTES_MAX): New macro.
5243 * alloc.c (Fmake_string):
5244 * character.c (string_escape_byte8):
5245 * coding.c (coding_alloc_by_realloc):
5246 * doprnt.c (doprnt):
5247 * editfns.c (Fformat):
5248 * eval.c (verror):
5249 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5250 since they may not be the same number.
5251 * editfns.c (Finsert_char):
5252 * fileio.c (Finsert_file_contents):
5253 Likewise for BUF_BYTES_MAX.
5254
5255 * image.c: Use ptrdiff_t, not int, for sizes.
5256 (slurp_file): Switch from int to ptrdiff_t.
5257 All uses changed.
5258 (slurp_file): Check that file size fits in both size_t (for
5259 malloc) and ptrdiff_t (for sanity and safety).
5260
5261 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5262 if b->modtime has its maximal value.
5263
5264 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5265
5266 Don't assume time_t can fit into int.
5267 * buffer.h (struct buffer.modtime): Now time_t, not int.
5268 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5269 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5270
5271 Minor fixes for signed vs unsigned integers.
5272 * character.h (MAYBE_UNIFY_CHAR):
5273 * charset.c (maybe_unify_char):
5274 * keyboard.c (read_char, reorder_modifiers):
5275 XINT -> XFASTINT, since the integer must be nonnegative.
5276 * ftfont.c (ftfont_spec_pattern):
5277 * keymap.c (access_keymap, silly_event_symbol_error):
5278 XUINT -> XFASTINT, since the integer must be nonnegative.
5279 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5280 since it makes no difference and we prefer signed.
5281 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5282 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5283 nonnegative.
5284
5285 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5286
5287 * window.h (Fwindow_frame): Declare.
5288
5289 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5290
5291 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5292 (SPARE_MEMORY): Always define.
5293 (LARGE_REQUEST): Remove.
5294 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5295
5296 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5297
5298 * lisp.h: Move EXFUNS for Fframe_root_window,
5299 Fframe_first_window and Fset_frame_selected_window to window.h.
5300
5301 * window.h: Move EXFUNS for Fframe_root_window,
5302 Fframe_first_window and Fset_frame_selected_window here from
5303 lisp.h.
5304
5305 * frame.c (Fwindow_frame, Fframe_first_window)
5306 (Fframe_root_window, Fframe_selected_window)
5307 (Fset_frame_selected_window): Move to window.c.
5308 (Factive_minibuffer_window): Move to minibuf.c.
5309 (Fother_visible_frames_p): New function.
5310
5311 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5312
5313 * window.c (decode_window, decode_any_window): Move up in code.
5314 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5315 (inhibit_frame_unsplittable): Remove unused variable.
5316 (Fwindow_buffer): Move up and rewrite doc-string.
5317 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5318 (Fwindow_prev): New functions.
5319 (Fwindow_frame): Move here from frame.c. Accept any window as
5320 argument.
5321 (Fframe_root_window, Fframe_first_window)
5322 (Fframe_selected_window): Move here from frame.c. Accept frame
5323 or arbitrary window as argument. Update doc-strings.
5324 (Fminibuffer_window): Move up in code.
5325 (Fwindow_minibuffer_p): Move up in code and simplify.
5326 (Fset_frame_selected_window): Move here from frame.c.
5327 Marginal rewrite.
5328 (Fselected_window, select_window, Fselect_window): Move up in
5329 code. Minor doc-string fixes.
5330
5331 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5332
5333 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5334 Do not assume that spare memory exists; that assumption is valid
5335 only if SYSTEM_MALLOC.
5336 (LARGE_REQUEST): New macro, so that the issue of large requests
5337 is separated from the issue of spare memory.
5338
5339 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5340
5341 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5342 format. (Bug#8806)
5343
5344 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5345
5346 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5347 before statements.
5348
5349 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5350
5351 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5352
5353 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5354
5355 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5356 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5357
5358 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5359
5360 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5361
5362 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5363
5364 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5365 (x_clipboard_manager_save): Add return value.
5366 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5367 New error handlers.
5368 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5369 Obey Vx_select_enable_clipboard_manager. Catch errors in
5370 x_clipboard_manager_save (Bug#8779).
5371 (Vx_select_enable_clipboard_manager): New variable.
5372 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5373
5374 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5375
5376 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5377
5378 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5379
5380 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5381 in the current matrix if keep_current_p is non-zero.
5382
5383 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5384
5385 * bidi.c (bidi_level_of_next_char): Fix last change.
5386
5387 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5388
5389 Support bidi reordering of text covered by display properties.
5390
5391 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5392 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5393 (bidi_cache_search, bidi_cache_iterator_state)
5394 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5395 (bidi_level_of_next_char, bidi_move_to_visually_next):
5396 Support character positions inside a run of characters covered by a
5397 display string.
5398 (bidi_paragraph_init, bidi_resolve_explicit_1)
5399 (bidi_level_of_next_char): Call bidi_fetch_char and
5400 bidi_fetch_char_advance instead of FETCH_CHAR and
5401 FETCH_CHAR_ADVANCE.
5402 (bidi_init_it): Initialize new members.
5403 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5404 definitions.
5405 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5406 instead of using explicit *_CHAR codes.
5407 (bidi_resolve_explicit, bidi_resolve_weak):
5408 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5409 bidirectional text is supported only in multibyte buffers.
5410 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5411 it to initialize the frame_window_p member of struct bidi_it.
5412 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5413 (bidi_resolve_explicit, bidi_resolve_weak)
5414 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5415 bidi_it->nchars is non-positive.
5416 (bidi_level_of_next_char): Don't try to lookup the cache for the
5417 next/previous character if nothing is cached there yet, or if we
5418 were just reseat()'ed to a new position.
5419
5420 * xdisp.c (set_cursor_from_row): Set start and stop points
5421 according to the row's direction when priming the loop that looks
5422 for the glyph on which to display cursor.
5423 (single_display_spec_intangible_p): Function deleted.
5424 (display_prop_intangible_p): Reimplement to call
5425 handle_display_spec instead of single_display_spec_intangible_p.
5426 Accept 3 additional arguments needed by handle_display_spec.
5427 This fixes incorrect cursor motion across display property with complex
5428 values: lists, `(when COND...)' forms, etc.
5429 (single_display_spec_string_p): Support property values that are
5430 lists with the argument STRING its top-level element.
5431 (display_prop_string_p): Fix the condition for processing a
5432 property that is a list to be consistent with handle_display_spec.
5433 (handle_display_spec): New function, refactored from the
5434 last portion of handle_display_prop.
5435 (compute_display_string_pos): Accept additional argument
5436 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5437 value of a `display' property is a "replacing spec".
5438 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5439 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5440 the display property, but just return a value indicating whether
5441 the display property will replace the characters it covers.
5442 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5443 frame_window_p members of struct bidi_it.
5444 (compute_display_string_pos, compute_display_string_end):
5445 New functions.
5446 (push_it): Accept second argument POSITION, where pop_it should
5447 jump to continue iteration.
5448 (reseat_1): Initialize bidi_it.disp_pos.
5449
5450 * keyboard.c (adjust_point_for_property): Adjust the call to
5451 display_prop_intangible_p to its new signature.
5452
5453 * dispextern.h (struct bidi_it): New member frame_window_p.
5454 (bidi_init_it): Update prototypes.
5455 (display_prop_intangible_p): Update prototype.
5456 (compute_display_string_pos, compute_display_string_end):
5457 Declare prototypes.
5458 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5459 EMACS_INT.
5460
5461 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5462
5463 Malloc failure behavior now depends on size of allocation.
5464 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5465 * lisp.h: Change signatures accordingly.
5466 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5467 All callers changed. (Bug#8762)
5468
5469 * gnutls.c: Use Emacs's memory allocators.
5470 Without this change, the gnutls library would invoke malloc etc.
5471 directly, which causes problems on non-SYNC_INPUT hosts, and which
5472 runs afoul of improving memory_full behavior. (Bug#8761)
5473 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5474 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5475 xfree instead of the default malloc, realloc, free.
5476 (Fgnutls_boot): No need to check for memory allocation failure,
5477 since xmalloc does that for us.
5478
5479 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5480 * category.c (hash_get_category_set):
5481 * ccl.c (ccl_driver):
5482 * charset.c (Fdefine_charset_internal):
5483 * charset.h (struct charset.hash_index):
5484 * composite.c (get_composition_id, gstring_lookup_cache)
5485 (composition_gstring_put_cache):
5486 * composite.h (struct composition.hash_index):
5487 * dispextern.h (struct image.hash):
5488 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5489 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5490 (hashfn_equal, hashfn_user_defined, make_hash_table)
5491 (maybe_resize_hash_table, hash_lookup, hash_put)
5492 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5493 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5494 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5495 * image.c (make_image, search_image_cache, lookup_image)
5496 (xpm_put_color_table_h):
5497 * lisp.h (struct Lisp_Hash_Table):
5498 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5499 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5500 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5501 * alloc.c (allocate_vectorlike):
5502 Check for overflow in vector size calculations.
5503 * ccl.c (ccl_driver):
5504 Check for overflow when converting EMACS_INT to int.
5505 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5506 need to be updated by these changes.
5507 * fns.c (make_hash_table, maybe_resize_hash_table):
5508 Check for integer overflow with large hash tables.
5509 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5510 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5511 (SXHASH_REDUCE): New macro.
5512 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5513 Use it instead of discarding useful hash info with large hash values.
5514 (sxhash_float): New function.
5515 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5516 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5517 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5518 Rewrite to use FIXNUM_BITS, as this simplifies things.
5519 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5520 Adjust signatures to match updated version of code.
5521 (consing_since_gc): Now EMACS_INT, since a single hash table can
5522 use more than INT_MAX bytes.
5523
5524 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5525
5526 Make it possible to build with GCC-4.6+ -O2 -flto.
5527
5528 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5529
5530 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5531
5532 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5533 Call minibuffer-inactive-mode.
5534
5535 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5536
5537 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5538 Update dependencies.
5539
5540 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5541
5542 * data.c (init_data): Remove code for UTS, this system is not
5543 supported anymore.
5544
5545 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5546
5547 Don't force ./temacs to start in terminal mode.
5548
5549 * frame.c (make_initial_frame): Initialize faces in all cases, not
5550 only when CANNOT_DUMP is defined.
5551 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5552
5553 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5554
5555 * dispnew.c (add_window_display_history): Use const for the string
5556 pointer. Remove declaration, not needed.
5557
5558 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5559
5560 Use 'inline', not 'INLINE'.
5561 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5562 * alloc.c, fontset.c (INLINE): Remove.
5563 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5564 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5565 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5566 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5567 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5568
5569 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5570
5571 Make it possible to run ./temacs.
5572
5573 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5574 syms_of_callproc does the same thing. Remove test for
5575 "initialized", do it in the caller.
5576 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5577
5578 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5579
5580 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5581 (read_minibuf): Use get_minibuffer.
5582 (syms_of_minibuf): Use DEFSYM.
5583 (Qmetadata): New var.
5584 * data.c (Qbuffer): Don't make it static.
5585 (syms_of_data): Use DEFSYM.
5586
5587 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5588
5589 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5590 (CCL_CODE_MIN): New macro.
5591
5592 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5593
5594 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5595
5596 * eval.c (Qdebug): Now static.
5597 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5598 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5599 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5600
5601 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5602
5603 * image.c: Various fixes to ImageMagick code comments.
5604 (Fimagemagick_types): Doc fix.
5605
5606 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5607
5608 Minor fixes prompted by GCC 4.6.0 warnings.
5609
5610 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5611
5612 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5613 (x_clipboard_manager_save_all): Move extern decl to ...
5614 * xterm.h: ... here, so that it can be checked for consistency.
5615
5616 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5617
5618 * xselect.c (x_clipboard_manager_save_frame)
5619 (x_clipboard_manager_save_all): New functions.
5620 (Fx_clipboard_manager_save): Lisp function deleted.
5621
5622 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5623 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5624
5625 * xterm.h: Update prototype.
5626
5627 2011-05-28 William Xu <william.xwl@gmail.com>
5628
5629 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5630 exiting (Bug#8239).
5631
5632 2011-05-28 Jim Meyering <meyering@redhat.com>
5633
5634 Avoid a sign-extension bug in crypto_hash_function.
5635 * fns.c (to_uchar): Define.
5636 (crypto_hash_function): Use it to convert some newly-signed
5637 variables to unsigned, to avoid sign-extension bugs. For example,
5638 without this change, (md5 "truc") would evaluate to
5639 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5640 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5641 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5642
5643 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5644
5645 Integer overflow fixes.
5646
5647 * dbusbind.c: Serial number integer overflow fixes.
5648 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5649 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5650 to hold a serial number that is too large for a fixnum.
5651 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5652 Check for serial numbers out of range. Decode any serial number
5653 that was so large that it became a float. (Bug#8722)
5654
5655 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5656 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5657 Use XFASTINT rather than XUINT when numbers are nonnegative.
5658 (xd_append_arg, Fdbus_method_return_internal):
5659 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5660 arguments, check that Lisp number is nonnegative, rather than
5661 silently wrapping negative numbers around. (Bug#8722)
5662 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5663 (Bug#8722)
5664
5665 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5666
5667 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5668
5669 ccl: Add integer overflow checks.
5670 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5671 (IN_INT_RANGE): New macros.
5672 (ccl_driver): Use them to check for integer overflow when
5673 decoding a CCL program. Many of the new checks are whether XINT (x)
5674 fits in int; it doesn't always, on 64-bit hosts. The new version
5675 doesn't catch all possible integer overflows, but it's an
5676 improvement. (Bug#8719)
5677
5678 * alloc.c (make_event_array): Use XINT, not XUINT.
5679 There's no need for unsigned here.
5680
5681 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5682 This follows up to the 2011-05-06 change that substituted uintptr_t
5683 for EMACS_INT. This case wasn't caught back then.
5684
5685 Rework Fformat to avoid integer overflow issues.
5686 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5687 now (part of C89). Include <verify.h>.
5688 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5689 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5690 (Fformat): Avoid the prepass trying to compute sizes; it was only
5691 approximate and thus did not catch overflow reliably. Instead, walk
5692 through the format just once, formatting and computing sizes as we go,
5693 checking for integer overflow at every step, and allocating a larger
5694 buffer as needed. Keep track separately whether the format is
5695 multibyte. Keep only the most-recently calculated precision, rather
5696 than them all. Record whether each argument has been converted to
5697 string. Use EMACS_INT, not int, for byte and char and arg counts.
5698 Support field widths and precisions larger than INT_MAX. Avoid
5699 sprintf's undefined behavior with conversion specifications such as %#d
5700 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5701 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5702 formatting out-of-range floating point numbers with int
5703 formats. (Bug#8668)
5704
5705 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5706
5707 * data.c: Avoid integer truncation in expressions involving floats.
5708 * data.c: Include <intprops.h>.
5709 (arith_driver): When there's an integer overflow in an expression
5710 involving floating point, convert the integers to floating point
5711 so that the resulting value does not suffer from catastrophic
5712 integer truncation. For example, on a 64-bit host (* 4
5713 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5714 Do not rely on undefined behavior after integer overflow.
5715
5716 merge count_size_as_multibyte, parse_str_to_multibyte
5717 * character.c, character.h (count_size_as_multibyte):
5718 Rename from parse_str_to_multibyte; all uses changed.
5719 Check for integer overflow.
5720 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5721 since it's now a duplicate of the other. This is more of
5722 a character than a buffer op, so better that it's in character.c.
5723 * fns.c, print.c: Adjust to above changes.
5724
5725 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5726
5727 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5728
5729 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5732 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5733 (x_clipboard_manager_save): Now static.
5734 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5735
5736 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5737 (crypto_hash_function): Now static.
5738 Fix pointer signedness problems. Avoid unnecessary initializations.
5739
5740 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5741
5742 * termhooks.h (Vselection_alist): Make it terminal-local.
5743
5744 * terminal.c (create_terminal): Initialize it.
5745
5746 * xselect.c: Support for clipboard managers.
5747 (Vselection_alist): Move to termhooks.h as terminal-local var.
5748 (LOCAL_SELECTION): New macro.
5749 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5750 (symbol_to_x_atom): Remove gratuitous arg.
5751 (x_handle_selection_request, lisp_data_to_selection_data)
5752 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5753 (x_own_selection, x_get_local_selection, x_convert_selection):
5754 New arg, specifying work frame. Use terminal-local Vselection_alist.
5755 (some_frame_on_display): Delete unused function.
5756 (Fx_own_selection_internal, Fx_get_selection_internal)
5757 (Fx_disown_selection_internal, Fx_selection_owner_p)
5758 (Fx_selection_exists_p): New optional frame arg.
5759 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5760 (x_handle_selection_clear): Don't treat other terminals with the
5761 same keyboard specially. Use the terminal-local Vselection_alist.
5762 (x_clear_frame_selections): Use Frun_hook_with_args.
5763
5764 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5765
5766 * xterm.h: Add support for those atoms.
5767
5768 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5769
5770 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5771 (converted_selections, conversion_fail_tag): New global variables.
5772 (x_selection_request_lisp_error): Free the above.
5773 (x_get_local_selection): Remove unnecessary code.
5774 (x_reply_selection_request): Args changed; handle arbitrary array
5775 of converted selections stored in converted_selections.
5776 Separate the XChangeProperty and SelectionNotify steps.
5777 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5778 (x_convert_selection): New function.
5779 (x_handle_selection_event): Simplify.
5780 (x_get_foreign_selection): Don't ignore incoming requests while
5781 waiting for an answer; this will fail when we implement
5782 SAVE_TARGETS, and seems unnecessary anyway.
5783 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5784 (Vx_sent_selection_functions): Doc fix.
5785
5786 2011-05-26 Leo Liu <sdl.web@gmail.com>
5787
5788 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5789
5790 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5791
5792 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5793
5794 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5795 for fringe update if it has periodic bitmap.
5796 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5797 and fringe_bitmap_periodic_p.
5798
5799 * fringe.c (get_fringe_bitmap_data): New function.
5800 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5801 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5802 row. Mark glyph row for fringe update if periodicity changed.
5803
5804 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5805 for fringe update unless it has periodic bitmap.
5806
5807 2011-05-25 Kenichi Handa <handa@m17n.org>
5808
5809 * xdisp.c (get_next_display_element): Set correct it->face_id for
5810 a static composition.
5811
5812 2011-05-24 Leo Liu <sdl.web@gmail.com>
5813
5814 * deps.mk (fns.o):
5815 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5816
5817 * fns.c (crypto_hash_function, Fsha1): New function.
5818 (Fmd5): Use crypto_hash_function.
5819 (syms_of_fns): Add Ssha1.
5820
5821 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5822
5823 * gnutls.c: Remove unused macros.
5824 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5825 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5826 Remove macros that are defined and never used.
5827 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5828
5829 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5830
5831 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5832 (Fx_get_selection_internal): Minor cleanup.
5833 (Fx_own_selection_internal): Rename arguments for consistency with
5834 select.el.
5835
5836 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5837
5838 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5839
5840 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5841
5842 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5843
5844 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5845
5846 * dispnew.c (scrolling_window): Don't exclude the case that the
5847 last enabled row in the desired matrix touches the bottom boundary.
5848
5849 2011-05-21 Glenn Morris <rgm@gnu.org>
5850
5851 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5852 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5853 and add some more files.
5854
5855 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5856
5857 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5858 report_file_error introduced by the change from 2011-05-07.
5859
5860 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5861
5862 * systime.h (Time): Define only if emacs is defined.
5863 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5864 where the include path doesn't have X11/X.h by default. See
5865 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5866
5867 2011-05-20 Kenichi Handa <handa@m17n.org>
5868
5869 * composite.c (find_automatic_composition): Fix previous change.
5870
5871 2011-05-20 Glenn Morris <rgm@gnu.org>
5872
5873 * lisp.mk: New file, split from Makefile.in.
5874 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5875 (shortlisp): Remove.
5876 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5877
5878 2011-05-19 Glenn Morris <rgm@gnu.org>
5879
5880 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5881 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5882 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5883 (lisp): Set the order to that of loadup.el.
5884 (shortlisp): Make it a copy of $lisp.
5885 (SOME_MACHINE_LISP): Remove.
5886 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5887 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5888
5889 2011-05-18 Kenichi Handa <handa@m17n.org>
5890
5891 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5892 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5893 (find_automatic_composition): Mostly rewrite for efficiency.
5894
5895 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5896
5897 * makefile.w32-in: Update dependencies.
5898
5899 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5900
5901 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5902 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5903
5904 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5905
5906 Fix some integer overflow issues, such as string length overflow.
5907
5908 * insdel.c (count_size_as_multibyte): Check for string overflow.
5909
5910 * character.c (lisp_string_width): Check for string overflow.
5911 Use EMACS_INT, not int, for string indexes and lengths; in
5912 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5913 the resulting string length overflows an EMACS_INT; instead,
5914 report a string overflow if no precision given. When checking for
5915 precision exhaustion, use a check that cannot possibly have
5916 integer overflow. (Bug#8675)
5917 * character.h (lisp_string_width): Adjust to new signature.
5918
5919 * alloc.c (string_overflow): New function.
5920 (Fmake_string): Use it. This doesn't change behavior, but saves
5921 a few bytes and will simplify future changes.
5922 * character.c (string_escape_byte8): Likewise.
5923 * lisp.h (string_overflow): New decl.
5924
5925 Fixups, following up to the user-interface timestamp change.
5926 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5927 for UI timestamps, instead of unsigned long.
5928 * msdos.c (mouse_get_pos): Likewise.
5929 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5930 * w32gui.h (Time): Define by including "systime.h" rather than by
5931 declaring it ourselves. (Bug#8664)
5932
5933 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5934 * image.c (clear_image_cache): Likewise.
5935
5936 * term.c (term_mouse_position): Don't assume time_t wraparound.
5937
5938 Be more systematic about user-interface timestamps.
5939 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5940 and sometimes 'EMACS_UINT', to represent these timestamps.
5941 This change causes it to use 'Time' uniformly, as that's what X uses.
5942 This makes the code easier to follow, and makes it easier to catch
5943 integer overflow bugs such as Bug#8664.
5944 * frame.c (Fmouse_position, Fmouse_pixel_position):
5945 Use Time, not unsigned long, for user-interface timestamps.
5946 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5947 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5948 * keyboard.h (last_event_timestamp): Likewise.
5949 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5950 * menu.h (xmenu_show): Likewise.
5951 * term.c (term_mouse_position): Likewise.
5952 * termhooks.h (struct input_event.timestamp): Likewise.
5953 (struct terminal.mouse_position_hook): Likewise.
5954 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5955 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5956 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5957 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5958 what it was before.
5959 * menu.h, termhooks.h: Include "systime.h", for Time.
5960
5961 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5962 Don't assume that the difference between two unsigned long values
5963 can fit into an integer. At this point, we know button_down_time
5964 <= event->timestamp, so the difference must be nonnegative, so
5965 there's no need to cast the result if double-click-time is
5966 nonnegative, as it should be; check that it's nonnegative, just in
5967 case. This bug is triggered when events are more than 2**31 ms
5968 apart (about 25 days). (Bug#8664)
5969
5970 * xselect.c (last_event_timestamp): Remove duplicate decl.
5971 (x_own_selection): Remove needless cast to unsigned long.
5972
5973 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5974 that always fit in int. Use a sentinel instead of a counter, to
5975 avoid a temp and to allay GCC's concerns about possible int overflow.
5976 * frame.h (struct frame): Use int for menu_bar_items_used
5977 instead of EMACS_INT, since it always fits in int.
5978
5979 * menu.c (grow_menu_items): Check for int overflow.
5980
5981 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5982
5983 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5984 Before, the code was not consistent. These values cannot exceed
5985 2**31 - 1 so there's no need to make them unsigned.
5986 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5987 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5988 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5989 as modifiers.
5990 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5991
5992 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5993 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5994 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5995 presumably because the widths might not match.
5996
5997 * window.c (size_window): Avoid needless test at loop start.
5998
5999 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6000
6001 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6002
6003 2011-05-12 Drew Adams <drew.adams@oracle.com>
6004
6005 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6006
6007 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6008
6009 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6010 `width' to `bar_area_x' and `bar_area_width', respectively.
6011 (x_scroll_run): Take account of fringe background extension.
6012
6013 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6014 Rename local vars `left' and `width' to `bar_area_x' and
6015 `bar_area_width', respectively.
6016 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6017 background extension.
6018
6019 2011-05-10 Jim Meyering <meyering@redhat.com>
6020
6021 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6022
6023 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6024
6025 * image.c (Finit_image_library): Return t for built-in image types,
6026 like pbm and xbm. (Bug#8640)
6027
6028 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6029
6030 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6031
6032 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6033
6034 * w32console.c (Fset_screen_color): Doc fix.
6035 (Fget_screen_color): New function.
6036 (syms_of_ntterm): Defsubr it.
6037
6038 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6039 unlink the temporary file if Fcall_process didn't create it in the
6040 first place.
6041 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6042 child process will be redirected to a file specified with `:file'.
6043 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6044 cue to call_process_cleanup not to close that handle.
6045
6046 2011-05-07 Ben Key <bkey76@gmail.com>
6047
6048 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6049 one of two shell specific rules, either bootstrap-temacs-CMD or
6050 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6051 to the previous implementation of the bootstrap-temacs rule.
6052 The bootstrap-temacs-CMD rule is similar to the previous
6053 implementation of the bootstrap-temacs rule except that it
6054 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6055 variable.
6056
6057 These changes, along with some changes to nt/configure.bat,
6058 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6059 earlier fix to add support for --cflags and --ldflags options
6060 that include quotes so that it works whether make uses cmd or
6061 sh as the shell.
6062
6063 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6064
6065 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6066 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6067 is a constant.
6068 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6069 a string. Handle both cases.
6070 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6071 (Fdbus_register_method): Use Qinvalid_function.
6072
6073 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6074
6075 * makefile.w32-in: Update dependencies.
6076 (LISP_H): Add inttypes.h and stdin.h.
6077 (PROCESS_H): Add unistd.h.
6078
6079 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6080
6081 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6082 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6083
6084 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6085
6086 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6087
6088 * term.c (vfatal): Remove stray call to va_end.
6089 It's not needed and the C Standard doesn't allow it here anyway.
6090
6091 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6092 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6093
6094 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6095 bytes.
6096
6097 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6098
6099 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6100
6101 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6102
6103 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6104
6105 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6106
6107 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6108 * charset.c (Fdefine_charset_internal): Don't initialize
6109 charset.code_space[15]. The value was garbage, on hosts with
6110 32-bit int (Bug#8600).
6111
6112 * lread.c (read_integer): Be more consistent with string-to-number.
6113 Use string_to_number to do the actual conversion; this avoids
6114 rounding errors and fixes some other screwups. Without this fix,
6115 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6116 (digit_to_number): Move earlier, for benefit of read_integer.
6117 Return -1 if the digit is out of range for the base, -2 if it is
6118 not a digit in any supported base. (Bug#8602)
6119
6120 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6121
6122 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6123 to match comment at start of function. This also removes a
6124 GCC warning about overflow in a 32+64-bit port.
6125
6126 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6127
6128 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6129 Reported by Stefan Monnier in
6130 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6131 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6132 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6133
6134 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6135 (EMACS_UINTPTR): Likewise, with uintptr_t.
6136
6137 * lisp.h: Prefer 64-bit EMACS_INT if available.
6138 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6139 on 32-bit hosts that have 64-bit int, so that they can access
6140 large files.
6141 However, temporarily disable this change unless the temporary
6142 symbol WIDE_EMACS_INT is defined.
6143
6144 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6145
6146 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6147 This removes an assumption that EMACS_INT and long are the same
6148 width as pointers. The assumption is true for Emacs porting targets
6149 now, but we want to make other targets possible.
6150 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6151 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6152 In the rest of the code, change types of integers that hold casted
6153 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6154 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6155 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6156 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6157 No need to cast type when ORing.
6158 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6159 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6160 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6161 assume EMACS_INT is the same width as char *.
6162 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6163 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6164 Remove no-longer-needed casts.
6165 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6166 (xg_tool_bar_help_callback, xg_make_tool_item):
6167 Use EMACS_INTPTR to hold an integer
6168 that will be cast to void *; this can avoid a GCC warning
6169 if EMACS_INT is not the same width as void *.
6170 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6171 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6172 (current_message_1, set_message_1):
6173 Use a local to convert to proper width without a cast.
6174 * xmenu.c (dialog_selection_callback): Likewise.
6175
6176 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6177 Also, don't assume VALBITS / RAND_BITS is less than 5,
6178 and don't rely on undefined behavior when shifting a 1 left into
6179 the sign bit.
6180 * lisp.h (get_random): Change signature to match.
6181
6182 * lread.c (hash_string): Use size_t, not int, for hash computation.
6183 Normally we prefer signed values; but hashing is special, because
6184 it's better to use unsigned division on hash table sizes so that
6185 the remainder is nonnegative. Also, size_t is the natural width
6186 for hashing into memory. The previous code used 'int', which doesn't
6187 retain enough info to hash well into very large tables.
6188 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6189
6190 * dbusbind.c: Don't possibly lose pointer info when converting.
6191 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6192 Use XPNTR rather than XHASH, so that the high-order bits of
6193 the pointer aren't lost when converting through void *.
6194
6195 * eval.c (Fautoload): Don't double-shift a pointer.
6196
6197 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6198
6199 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6200
6201 * gnutls.c (DEF_GNUTLS_FN):
6202 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6203
6204 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6205
6206 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6207 marker. (Bug#8610)
6208
6209 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6210
6211 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6212 New version that can reserve upto 2GB of heap space.
6213
6214 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6215
6216 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6217
6218 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6219
6220 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6221 `gnutls_certificate_set_x509_key_file'.
6222
6223 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6224
6225 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6226 Update dependencies.
6227
6228 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6229
6230 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6231 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6232 Remove unused parameter `fildes'.
6233 * process.c (read_process_output, send_process): Don't pass it.
6234
6235 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6236
6237 Fix previous change: the library cache is defined in w32.c.
6238 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6239 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6240
6241 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6242
6243 Implement dynamic loading of GnuTLS on Windows.
6244
6245 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6246 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6247 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6248 Declare.
6249
6250 * gnutls.c (Qgnutls_dll): Define.
6251 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6252 (gnutls_*): Declare function pointers.
6253 (init_gnutls_functions): New function to initialize function pointers.
6254 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6255 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6256 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6257 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6258 (emacs_gnutls_write, emacs_gnutls_read)
6259 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6260 (Fgnutls_available_p): New function.
6261 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6262 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6263 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6264
6265 * image.c: Include w32.h.
6266 (Vimage_type_cache): Delete.
6267 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6268 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6269 (w32_delayed_load): Move to w32.c.
6270
6271 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6272
6273 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6274 (w32_delayed_load): Move from image.c. When loading a library, record
6275 its filename in the :loaded-from property of the library id.
6276 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6277 Initialize and staticpro them.
6278 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6279
6280 * process.c: Include lisp.h before w32.h, not after.
6281 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6282 instead of gnutls_record_check_pending.
6283
6284 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6285
6286 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6287
6288 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6289 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6290 as passed in.
6291
6292 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6293
6294 * xterm.c (x_set_frame_alpha): Do not set property on anything
6295 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6296
6297 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6298
6299 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6300
6301 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6302
6303 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6304 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6305 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6306 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6307 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6308 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6309 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6310 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6311 (Qgnutls_bootprop_callbacks_verify): Make static.
6312
6313 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6314
6315 * callproc.c: Indentation fixup.
6316
6317 * sysdep.c (wait_for_termination_1): Make static.
6318 (wait_for_termination, interruptible_wait_for_termination):
6319 Move after wait_for_termination_1.
6320
6321 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6322
6323 * sysdep.c (interruptible_wait_for_termination): New function
6324 which is like wait_for_termination, but allows keyboard
6325 interruptions.
6326
6327 * callproc.c (Fcall_process): Add (:file "file") as an option for
6328 the STDOUT buffer.
6329 (Fcall_process_region): Ditto.
6330
6331 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6332
6333 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6334 rather than `XVECTOR (FOO)->size'.
6335
6336 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6337 inttypes.h, as a gnulib replacement is used if it not available in
6338 system headers.
6339
6340 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6341
6342 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6343 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6344 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6345
6346 * coding.c (coding_alloc_by_realloc): Error out if destination
6347 will grow beyond MOST_POSITIVE_FIXNUM.
6348 (decode_coding_emacs_mule): Abort if there isn't enough place in
6349 charbuf for the composition carryover bytes. Reserve an extra
6350 space for up to 2 characters produced in a loop.
6351 (decode_coding_iso_2022): Abort if there isn't enough place in
6352 charbuf for the composition carryover bytes.
6353
6354 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6355
6356 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6357 aborting when %lld or %lll format is passed.
6358 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6359 %llo or %llx format is passed. (Bug#8545)
6360
6361 * window.c (window_scroll_line_based): Use a marker instead of
6362 simple variables to record original value of point. (Bug#7952)
6363
6364 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6365 produced by %s or %c overflows available buffer space. (Bug#8545)
6366
6367 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6368
6369 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6370 (SIZE_MAX): Move defn after all includes, as they might #define it.
6371
6372 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6373
6374 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6375
6376 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6377
6378 * keyboard.c (Qdelayed_warnings_hook): Define.
6379 (command_loop_1): Run `delayed-warnings-hook'
6380 if Vdelayed_warnings_list is non-nil.
6381 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6382 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6383
6384 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6385
6386 * doprnt.c (doprnt): Don't return value smaller than the buffer
6387 size if the message was truncated. (Bug#8545).
6388
6389 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6390
6391 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6392 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6393
6394 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6395
6396 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6397
6398 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6399
6400 * makefile.w32-in: Update dependencies.
6401
6402 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6403
6404 Improve `doprnt' and its usage. (Bug#8545)
6405 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6406 `format_end'. Remove support for %l as a conversion specifier.
6407 Don't use xrealloc. Improve diagnostics when the %l size modifier
6408 is used. Update the commentary.
6409
6410 * eval.c (verror): Simplify calculation of size_t.
6411
6412 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6413 messages.
6414
6415 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6416
6417 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6418 change.
6419
6420 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6421
6422 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6423 This makes this file independent of the recent pseudovector change.
6424
6425 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6426
6427 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6428
6429 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6430 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6431 Remove unused local.
6432 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6433
6434 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6435 GCC 4.6.0 optimizes based on type-based alias analysis.
6436 For example, if b is of type struct buffer * and v of type struct
6437 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6438 != &v->size, and therefore "v->size = 1; b->size = 2; return
6439 v->size;" must therefore return 1. This assumption is incorrect
6440 for Emacs, since it type-puns struct Lisp_Vector * with many other
6441 types. To fix this problem, this patch adds a new type struct
6442 vectorlike_header that documents the constraints on layout of vectors
6443 and pseudovectors, and helps optimizing compilers not get fooled
6444 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6445 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6446 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6447 the size member.
6448 (XSETPVECTYPE): Rewrite in terms of new macro.
6449 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6450 This is a bit clearer, and further avoids the possibility of
6451 undesirable aliasing.
6452 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6453 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6454 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6455 since Lisp_Subr is a special case (no "next" field).
6456 (ASIZE): Now uses header.size rather than size.
6457 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6458 to avoid the hassle of writing XVECTOR (foo)->header.size.
6459 (struct vectorlike_header): New type.
6460 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6461 object, to help avoid aliasing.
6462 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6463 (SUBRP): Likewise, since Lisp_Subr is a special case.
6464 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6465 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6466 (struct Lisp_Hash_Table): Combine first two members into a single
6467 struct vectorlike_header member. All uses of "size" and "next" members
6468 changed to be "header.size" and "header.next".
6469 * buffer.h (struct buffer): Likewise.
6470 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6471 * frame.h (struct frame): Likewise.
6472 * process.h (struct Lisp_Process): Likewise.
6473 * termhooks.h (struct terminal): Likewise.
6474 * window.c (struct save_window_data, struct saved_window): Likewise.
6475 * window.h (struct window): Likewise.
6476 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6477 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6478 * buffer.c (init_buffer_once): Likewise.
6479 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6480 special case.
6481 * process.c (Fformat_network_address): Use local var for size,
6482 for brevity.
6483
6484 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6485
6486 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6487 * data.c (atof): Remove decl; no longer used or needed.
6488 (digit_to_number): Move to lread.c.
6489 (Fstring_to_number): Use new string_to_number function, to be
6490 consistent with how the Lisp reader treats infinities and NaNs.
6491 Do not assume that floating-point numbers represent EMACS_INT
6492 without losing information; this is not true on most 64-bit hosts.
6493 Avoid double-rounding errors, by insisting on integers when
6494 parsing non-base-10 numbers, as the documentation specifies.
6495 * lisp.h (string_to_number): New decl, replacing ...
6496 (isfloat_string): Remove.
6497 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6498 (read1): Do not accept +. and -. as integers; this
6499 appears to have been a coding error. Similarly, do not accept
6500 strings like +-1e0 as floating point numbers. Do not report
6501 overflow for integer overflows unless the base is not 10 which
6502 means we have no simple and reliable way to continue.
6503 Break out the floating-point parsing into a new
6504 function string_to_number, so that Fstring_to_number parses
6505 floating point numbers consistently with the Lisp reader.
6506 (digit_to_number): Move here from data.c. Make it static inline.
6507 (E_CHAR, EXP_INT): Remove, replacing with ...
6508 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6509 (string_to_number): New function, replacing isfloat_string.
6510 This function checks for valid syntax and produces the resulting
6511 Lisp float number too. Rework it so that string-to-number
6512 no longer mishandles examples like "1.0e+". Use strtoumax,
6513 so that overflow for non-base-10 numbers is reported only when
6514 there's no portable and simple way to convert to floating point.
6515
6516 * textprop.c (set_text_properties_1): Rewrite for clarity,
6517 and to avoid GCC warning about integer overflow.
6518
6519 * intervals.h (struct interval): Use EMACS_INT for members
6520 where EMACS_UINT might cause problems. See
6521 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6522 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6523 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6524 All uses changed.
6525 (offset_intervals): Tell GCC not to worry about length overflow
6526 when negating a negative length.
6527
6528 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6529 (overrun_check_free): Likewise.
6530
6531 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6532 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6533 word size.
6534
6535 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6536 (gnutls_make_error): Rename local to avoid shadowing.
6537 (gnutls_emacs_global_deinit): ifdef out; not used.
6538 (Fgnutls_boot): Use const for pointer to readonly storage.
6539 Comment out unused local. Fix pointer signedness problems.
6540
6541 * lread.c (openp): Don't stuff size_t into an 'int'.
6542 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6543 about possible signed overflow.
6544
6545 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6546 (GDK_KEY_g): Don't define if already defined.
6547 (xg_prepare_tooltip): Avoid pointer signedness problem.
6548 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6549
6550 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6551 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6552
6553 * xfns.c (Fx_window_property): Simplify a bit,
6554 to make a bit faster and to avoid GCC 4.6.0 warning.
6555 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6556
6557 * fns.c (internal_equal): Don't assume size_t fits in int.
6558
6559 * alloc.c (compact_small_strings): Tighten assertion a little.
6560
6561 Replace pEd with more-general pI, and fix some printf arg casts.
6562 * lisp.h (pI): New macro, generalizing old pEd macro to other
6563 conversion specifiers. For example, use "...%"pI"d..." rather
6564 than "...%"pEd"...".
6565 (pEd): Remove. All uses replaced with similar uses of pI.
6566 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6567 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6568 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6569 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6570 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6571 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6572 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6573 64-bit hosts.
6574 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6575 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6576 * print.c (safe_debug_print, print_object): Likewise.
6577 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6578 to int.
6579 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6580 avoiding the 0 flag, which is not portable.
6581 * process.c (Fmake_network_process): Use pI to avoid cast.
6582 * region-cache.c (pp_cache): Likewise.
6583 * xdisp.c (decode_mode_spec): Likewise.
6584 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6585 behavior on 64-bit hosts with printf arg.
6586 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6587 (x_stop_queuing_selection_requests): Likewise.
6588 (x_get_window_property): Don't truncate byte count to an 'int'
6589 when tracing.
6590
6591 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6592 here, since it parses constructs like leading '-' and spaces,
6593 which are not wanted; and it overflows with large numbers.
6594 Instead, simply match F[0-9]+, which is what is wanted anyway.
6595
6596 * alloc.c: Remove unportable assumptions about struct layout.
6597 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6598 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6599 (allocate_vectorlike, make_pure_vector): Use the new macros,
6600 plus offsetof, to remove unportable assumptions about struct layout.
6601 These assumptions hold on all porting targets that I know of, but
6602 they are not guaranteed, they're easy to remove, and removing them
6603 makes further changes easier.
6604
6605 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6606 This doesn't fix a bug but makes the code clearer.
6607 (string_overrun_cookie): Now const. Use initializers that
6608 don't formally overflow signed char, to avoid warnings.
6609 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6610 can cause Emacs to crash when string overrun checking is enabled.
6611 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6612 multiple of sizeof (EMACS_INT); it need not be, if
6613 alignof(EMACS_INT) < sizeof (EMACS_INT).
6614 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6615
6616 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6617
6618 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6619
6620 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6621
6622 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6623 supposed to be handshaking. (Bug#8556)
6624 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6625
6626 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6627
6628 * lisp.h (Qdebug): List symbol.
6629 * eval.c (Qdebug): Restore global linkage.
6630 * keyboard.c (debug-on-event): New variable.
6631 (handle_user_signal): Break into debugger when debug-on-event
6632 matches the current signal symbol.
6633
6634 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6635
6636 * alloc.c (check_sblock, check_string_bytes)
6637 (check_string_free_list): Convert to standard C.
6638
6639 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6640
6641 * w32.c (emacs_gnutls_push): Fix typo.
6642
6643 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6644
6645 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6646 "cast to pointer from integer of different size".
6647
6648 Improve doprnt and its use in verror. (Bug#8545)
6649 * doprnt.c (doprnt): Document the set of format control sequences
6650 supported by the function. Use SAFE_ALLOCA instead of always
6651 using `alloca'.
6652
6653 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6654 is one byte too soon. Don't use xrealloc; instead xfree and
6655 xmalloc anew.
6656
6657 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6658
6659 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6660 callbacks stage.
6661
6662 * gnutls.c: Renamed global_initialized to
6663 gnutls_global_initialized. Added internals for the
6664 :verify-hostname-error, :verify-error, and :verify-flags
6665 parameters of `gnutls-boot' and documented those parameters in the
6666 docstring. Start callback support.
6667 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6668 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6669 on error. Return error code.
6670 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6671 (emacs_gnutls_read): Likewise.
6672 (Fgnutls_boot): Return handshake error code.
6673 (emacs_gnutls_handle_error): New function.
6674 (wsaerror_to_errno): Likewise.
6675
6676 * w32.h (emacs_gnutls_pull): Add prototype.
6677 (emacs_gnutls_push): Likewise.
6678
6679 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6680 (emacs_gnutls_push): Likewise.
6681
6682 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6683
6684 * process.c (wait_reading_process_output): Check if GnuTLS
6685 buffered some data internally if no FDs are set for TLS
6686 connections.
6687
6688 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6689 (LIBS): Link to USER_LIBS.
6690 ($(BLD)/gnutls.$(0)): New target.
6691
6692 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6693
6694 * xdisp.c (handle_single_display_spec): Rename the
6695 display_replaced_before_p argument into display_replaced_p, to
6696 make it consistent with the commentary. Fix typos in the
6697 commentary.
6698
6699 * textprop.c (syms_of_textprop): Remove dead code.
6700 (copy_text_properties): Delete obsolete commentary about an
6701 interface that was deleted long ago. Fix typos in the description
6702 of arguments.
6703
6704 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6705 to changes in oldXMenu/XMenu.h from 2011-04-16.
6706 <menu_help_message, prev_menu_help_message>: Constify.
6707 (IT_menu_make_room): menu->help_text is now `const char **';
6708 adjust.
6709
6710 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6711 to changes in oldXMenu/XMenu.h from 2011-04-16.
6712 (struct XMenu): Declare `help_text' `const char **'.
6713
6714 * xfaces.c <Qunspecified>: Make extern again.
6715
6716 * syntax.c: Include sys/types.h before including regex.h, as
6717 required by Posix.
6718
6719 * doc.c (get_doc_string): Improve the format passed to `error'.
6720
6721 * doprnt.c (doprnt): Improve commentary.
6722
6723 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6724
6725 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6726 them with etags.
6727
6728 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6729 changes in globals.h immediately force recompilation.
6730 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6731 $(CURDIR)/s/ms-w32.h.
6732 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6733
6734 * character.c (Fchar_direction): Function deleted.
6735 (syms_of_character): Don't defsubr it.
6736 <char-direction-table>: Deleted.
6737
6738 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6739
6740 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6741 * doprnt.c: Include limits.h.
6742 (SIZE_MAX): New macro.
6743 (doprnt): Return a size_t value. 2nd arg is now size_t.
6744 Many local variables are now size_t instead of int or unsigned.
6745 Improve overflow protection. Support `l' modifier for integer
6746 conversions. Support %l conversion. Don't assume an EMACS_INT
6747 argument for integer conversions and for %c.
6748
6749 * lisp.h (doprnt): Restore prototype.
6750
6751 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6752 $(SRC)/character.h.
6753
6754 * Makefile.in (base_obj): Add back doprnt.o.
6755
6756 * deps.mk (doprnt.o): Add back prerequisites.
6757 (callint.o): Depend on character.h.
6758
6759 * eval.c (internal_lisp_condition_case): Include the handler
6760 representation in the error message.
6761 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6762 when breaking from the loop.
6763
6764 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6765
6766 * callint.c (Fcall_interactively): When displaying error message
6767 about invalid control letter, pass the character's codepoint, not
6768 a pointer to its multibyte form. Improve display of the character
6769 in octal and display also its hex code.
6770
6771 * character.c (char_string): Use %x to display the (unsigned)
6772 codepoint of an invalid character, to avoid displaying a bogus
6773 negative value.
6774
6775 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6776 `error', not SYMBOL_NAME itself.
6777
6778 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6779 character arguments to `error'.
6780
6781 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6782 to `error' in error message about FINAL_CHAR argument. Make sure
6783 FINAL_CHAR is a character, and use %c when it is passed as
6784 argument to `error'.
6785
6786 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6787
6788 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6789
6790 * w32.c: Include <time.h>.
6791 (sys_localtime): New function.
6792
6793 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6794
6795 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6796
6797 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6798
6799 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6800
6801 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6802 zombies (Bug#8467).
6803
6804 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6805
6806 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6807 gl_state.e_property when gl_state.object is Qt.
6808
6809 * insdel.c (make_gap_larger): Remove limitation of buffer size
6810 to <= INT_MAX.
6811
6812 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6813
6814 * xdisp.c (lookup_glyphless_char_display)
6815 (produce_glyphless_glyph): Handle cons cell entry in
6816 glyphless-char-display.
6817 (Vglyphless_char_display): Document it.
6818
6819 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6820 glyphless-char-display.
6821
6822 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6823
6824 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6825
6826 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6827
6828 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6829 definition for no-X builds.
6830
6831 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6832
6833 Static checks with GCC 4.6.0 and non-default toolkits.
6834
6835 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6836
6837 * process.c (keyboard_bit_set): Define only if SIGIO.
6838 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6839 (send_process): Repair possible setjmp clobbering.
6840
6841 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6842
6843 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6844
6845 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6846
6847 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6848 Define only if needed.
6849
6850 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6851 by pacifying GCC about it. Maybe it's time to retire it?
6852 * xfaces.c (USG, __TIMEVAL__): Likewise.
6853
6854 * dispextern.h (struct redisplay_interface): Rename param
6855 to avoid shadowing.
6856 * termhooks.h (struct terminal): Likewise.
6857 * xterm.c (xembed_send_message): Likewise.
6858
6859 * insdel.c (make_gap_smaller): Define only if
6860 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6861
6862 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6863 it.
6864
6865 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6866 so that we aren't warned about unused symbols.
6867
6868 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6869
6870 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6871
6872 * xfns.c (x_real_positions): Mark locals as initialized.
6873
6874 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6875
6876 * xterm.c: Fix problems found by static analysis with other toolkits.
6877 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6878 (x_dispatch_event): Declare static if USE_GTK, and
6879 define if USE_GTK || USE_X_TOOLKIT.
6880 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6881 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6882 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6883 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6884
6885 * xmenu.c (menu_help_callback): Pointer type fixes.
6886 Use const pointers when pointing at readonly data. Avoid pointer
6887 signedness clashes.
6888 (FALSE): Remove unused macro.
6889 (update_frame_menubar): Remove unused decl.
6890
6891 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6892
6893 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6894 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6895 (single_menu_item): Rename local to avoid shadowing.
6896
6897 * keyboard.c (make_lispy_event): Remove unused local var.
6898
6899 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6900 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6901
6902 * bitmaps: Change bitmaps from unsigned char back to the X11
6903 compatible char. Avoid the old compiler warnings about
6904 out-of-range initializers by using, for example, '\xab' rather
6905 than 0xab.
6906
6907 * xgselect.c (xgselect_initialize): Check vs interface
6908 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6909
6910 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6911
6912 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6913 to read-only memory.
6914
6915 * fns.c (vector): Remove; this old hack is no longer needed.
6916
6917 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6918 Remove unused var.
6919 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6920
6921 * xrdb.c (x_load_resources): Omit unused local.
6922
6923 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6924 (x_window): Rename locals to avoid shadowing.
6925 (USG): Use the kludged USG macro, to pacify gcc.
6926
6927 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6928 (x_term_init): Remove local to avoid shadowing.
6929
6930 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6931
6932 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6933 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6934
6935 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6936
6937 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6938
6939 Fix regex.c, syntax.c and friends for buffers > 2GB.
6940 * syntax.h (struct gl_state_s): Declare character position members
6941 EMACS_INT.
6942
6943 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6944
6945 * textprop.c (verify_interval_modification, interval_of):
6946 Declare arguments EMACS_INT.
6947
6948 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6949 EMACS_INT.
6950
6951 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6952
6953 * indent.c (Fvertical_motion): Local variable it_start is now
6954 EMACS_INT.
6955
6956 * regex.c (re_match, re_match_2, re_match_2_internal)
6957 (bcmp_translate, regcomp, regexec, print_double_string)
6958 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6959 (re_compile_pattern, re_exec): Declare arguments and local
6960 variables `size_t' and `ssize_t' and return values `regoff_t', as
6961 appropriate.
6962 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6963 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6964 <compile_stack_type>: `size' and `avail' are now `size_t'.
6965
6966 * regex.h <regoff_t>: Use ssize_t, not int.
6967 (re_search, re_search_2, re_match, re_match_2): Arguments that
6968 specify buffer/string position and length are now ssize_t and
6969 size_t. Return type is regoff_t.
6970
6971 2011-04-16 Ben Key <bkey76@gmail.com>
6972
6973 * nsfont.m: Fixed bugs in ns_get_family and
6974 ns_descriptor_to_entity that were caused by using free to
6975 deallocate memory blocks that were allocated by xmalloc (via
6976 xstrdup). This caused Emacs to crash when compiled with
6977 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6978 --enable-checking=xmallocoverrun). xfree is now used to
6979 deallocate these memory blocks.
6980
6981 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6982
6983 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6984
6985 emacs_write: Accept and return EMACS_INT for sizes.
6986 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6987 et seq.
6988 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6989 Accept and return EMACS_INT.
6990 (emacs_gnutls_write): Return the number of bytes written on
6991 partial writes.
6992 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6993 (emacs_read, emacs_write): Remove check for negative size, as the
6994 Emacs source code has been audited now.
6995 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6996 (emacs_read, emacs_write): Use it.
6997 * process.c (send_process): Adjust to the new signatures of
6998 emacs_write and emacs_gnutls_write. Do not attempt to store
6999 a byte offset into an 'int'; it might overflow.
7000 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7001
7002 * sound.c: Don't assume sizes fit in 'int'.
7003 (struct sound_device.period_size, alsa_period_size):
7004 Return EMACS_INT, not int.
7005 (struct sound_device.write, vox_write, alsa_write):
7006 Accept EMACS_INT, not int.
7007 (wav_play, au_play): Use EMACS_INT to store sizes and to
7008 record read return values.
7009
7010 2011-04-15 Ben Key <bkey76@gmail.com>
7011
7012 * keyboard.c (Qundefined): Don't declare static since it is used
7013 in nsfns.m.
7014 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7015 static since they are used in nsfont.m.
7016
7017 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7018
7019 * process.c (Qprocessp): Don't declare static.
7020 * lisp.h (Qprocessp): Declare again.
7021
7022 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7023
7024 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7025
7026 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7027
7028 Improve C-level modularity by making more things 'static'.
7029
7030 Don't publish debugger-only interfaces to other modules.
7031 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7032 (verify_bytepos, count_markers): Move decls to the only modules
7033 that need them.
7034 * region-cache.h (pp_cache): Likewise.
7035 * window.h (check_all_windows): Likewise.
7036 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7037
7038 * sysdep.c (croak): Now static, if
7039 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7040 * syssignal.h (croak): Declare only if not static.
7041
7042 * alloc.c (refill_memory_reserve): Now static if
7043 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7044 * lisp.h (refill_memory_reserve): Declare only if not static.
7045
7046 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7047 Define only if USE_LUCID.
7048
7049 * xrdb.c (x_customization_string, x_rm_string): Now static.
7050
7051 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7052 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7053
7054 * xdisp.c (draw_row_with_mouse_face): Now static.
7055 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7056
7057 * window.h (check_all_windows): Mark externally visible.
7058
7059 * window.c (window_deletion_count): Now static.
7060
7061 * undo.c: Make symbols static if they're not exported.
7062 (last_undo_buffer, last_boundary_position, pending_boundary):
7063 Now static.
7064
7065 * textprop.c (interval_insert_behind_hooks): Now static.
7066 (interval_insert_in_front_hooks): Likewise.
7067
7068 * term.c: Make symbols static if they're not exported.
7069 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7070 (max_frame_lines, tty_set_terminal_modes):
7071 (tty_reset_terminal_modes, tty_turn_off_highlight):
7072 (get_tty_terminal): Now static.
7073 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7074 * termhooks.h (term_mouse_moveto): Do not declare if
7075 HAVE_WINDOW_SYSTEM.
7076 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7077 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7078
7079 * sysdep.c: Make symbols static if they're not exported.
7080 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7081 Now static.
7082 (sigprocmask_set, full_mask): Remove; unused.
7083 (wait_debugging): Mark as visible.
7084 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7085 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7086
7087 * syntax.c (syntax_temp): Define only if !__GNUC__.
7088
7089 * sound.c (current_sound_device, current_sound): Now static.
7090
7091 * search.c (searchbufs, searchbuf_head): Now static.
7092
7093 * scroll.c (scroll_cost): Remove; unused.
7094 * dispextern.h (scroll_cost): Remove decl.
7095
7096 * region-cache.h (pp_cache): Mark as externally visible.
7097
7098 * process.c: Make symbols static if they're not exported.
7099 (process_tick, update_tick, create_process, chan_process):
7100 (Vprocess_alist, proc_buffered_char, datagram_access):
7101 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7102 (deactivate_process): Mark defn as static, as well as decl.
7103 * lisp.h (create_process): Remove decl.
7104 * process.h (chan_process, Vprocess_alist): Remove decls.
7105
7106 * print.c: Make symbols static if they're not exported.
7107 (print_depth, new_backquote_output, being_printed, print_buffer):
7108 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7109 (print_interval, print_number_index, initial_stderr_stream):
7110 Now static.
7111 * lisp.h (Fprinc): Remove decl.
7112 (debug_output_compilation_hack): Mark as externally visible.
7113
7114 * sysdep.c (croak): Move decl from here to syssignal.h.
7115 * syssignal.h (croak): Put it here, so the API can be checked when
7116 'croak' is called from dissociate_if_controlling_tty.
7117
7118 * minibuf.c: Make symbols static if they're not exported.
7119 (minibuf_save_list, choose_minibuf_frame): Now static.
7120 * lisp.h (choose_minibuf_frame): Remove decl.
7121
7122 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7123
7124 * lread.c: Make symbols static if they're not exported.
7125 (read_objects, initial_obarray, oblookup_last_bucket_number):
7126 Now static.
7127 (make_symbol): Remove; unused.
7128 * lisp.h (initial_obarray, make_symbol): Remove decls.
7129
7130 * keyboard.c: Make symbols static if they're not exported.
7131 (single_kboard, recent_keys_index, total_keys, recent_keys):
7132 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7133 (this_single_command_key_start, echoing, last_auto_save):
7134 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7135 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7136 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7137 (Vlispy_mouse_stem, double_click_count):
7138 Now static.
7139 (force_auto_save_soon): Define only if SIGDANGER.
7140 (ignore_mouse_drag_p): Now static if
7141 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7142 (print_help): Remove; unused.
7143 (stop_character, last_timer_event): Mark as externally visible.
7144 * keyboard.h (ignore_mouse_drag_p): Declare only if
7145 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7146 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7147 * lisp.h (echoing): Remove decl.
7148 (force_auto_save_soon): Declare only if SIGDANGER.
7149 * xdisp.c (redisplay_window): Simplify code, to make it more
7150 obvious that ignore_mouse_drag_p is not accessed if !defined
7151 USE_GTK && !defined HAVE_NS.
7152
7153 * intervals.c: Make symbols static if they're not exported.
7154 (merge_properties_sticky, merge_interval_right, delete_interval):
7155 Now static.
7156 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7157
7158 * insdel.c: Make symbols static if they're not exported.
7159 However, leave prepare_to_modify_buffer alone. It's never
7160 called from outside this function, but that appears to be a bug.
7161 (combine_after_change_list, combine_after_change_buffer):
7162 (adjust_after_replace, signal_before_change): Now static.
7163 (adjust_after_replace_noundo): Remove; unused.
7164 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7165 (signal_before_change): Remove decls.
7166
7167 * indent.c (val_compute_motion, val_vmotion): Now static.
7168
7169 * image.c: Make symbols static if they're not exported.
7170 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7171 if USE_GTK.
7172 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7173 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7174
7175 * fringe.c (standard_bitmaps): Now static.
7176 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7177
7178 * frame.c: Make symbols static if they're not exported.
7179 (x_report_frame_params, make_terminal_frame): Now static.
7180 (get_frame_param): Now static, unless HAVE_NS.
7181 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7182 (x_get_resource_string): Remove; not used.
7183 * frame.h (make_terminal_frame, x_report_frame_params):
7184 (x_get_resource_string); Remove decls.
7185 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7186 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7187
7188 * font.c, fontset.c: Make symbols static if they're not exported.
7189 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7190 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7191 * font.c (font_close_object): Now static.
7192 * font.h (font_close_object): Remove.
7193 * fontset.c (FONTSET_OBJLIST): Remove.
7194 (free_realized_fontset) #if-0 the body, which does nothing.
7195 (face_suitable_for_char_p): #if-0, as it's never called.
7196 * fontset.h (face_suitable_for_char_p): Remove decl.
7197 * xfaces.c (face_at_string_position):
7198 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7199 since 0 is always ASCII.
7200
7201 * fns.c (weak_hash_tables): Now static.
7202
7203 * fileio.c: Make symbols static if they're not exported.
7204 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7205 (Vwrite_region_annotation_buffers): Now static.
7206
7207 * eval.c: Make symbols static if they're not exported.
7208 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7209 * lisp.h (backtrace_list): Remove decl.
7210
7211 * emacs.c: Make symbols static if they're not exported.
7212 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7213 (fatal_error_code, fatal_error_signal_hook, standard_args):
7214 Now static.
7215 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7216 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7217 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7218 * lisp.h (fatal_error_signal_hook): Remove decl.
7219 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7220
7221 * editfns.c: Move a (normally-unused) function to its only use.
7222 * editfns.c, lisp.h (get_operating_system_release): Remove.
7223 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7224 worth the hassle of breaking this out.
7225
7226 * xterm.c: Make symbols static if they're not exported.
7227 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7228 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7229 (x_destroy_window, x_delete_display):
7230 Now static.
7231 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7232 (x_mouse_leave): Remove; unused.
7233 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7234 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7235 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7236 Remove decls.
7237 (x_mouse_leave): Declare only if WINDOWSNT.
7238 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7239 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7240 USE_X_TOOLKIT.
7241
7242 * ftxfont.c: Make symbols static if they're not exported.
7243 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7244 HAVE_FREETYPE.
7245 * font.h (ftxfont_driver): Likewise.
7246
7247 * xfns.c: Make symbols static if they're not exported.
7248 (x_last_font_name, x_display_info_for_name):
7249 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7250 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7251 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7252 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7253 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7254 (last_show_tip_args): Now static.
7255 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7256 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7257 (x_screen_planes): Remove; unused.
7258 * dispextern.h (x_screen_planes): Remove decl.
7259
7260 * dispnew.c: Make symbols static if they're not exported.
7261 * dispextern.h (redraw_garbaged_frames, scrolling):
7262 (increment_row_positions): Remove.
7263 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7264 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7265 Now static.
7266 (redraw_garbaged_frames): Remove; unused.
7267
7268 * xfaces.c: Make symbols static if they're not exported.
7269 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7270 Remove decls.
7271 * xterm.h (defined_color): Remove decls.
7272 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7273 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7274 (menu_face_changed_default, defined_color, free_realized_face):
7275 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7276 (ascii_face_of_lisp_face): Remove; unused.
7277
7278 * xdisp.c: Make symbols static if they're not exported.
7279 * dispextern.h (scratch_glyph_row, window_box_edges):
7280 (glyph_to_pixel_coords, set_cursor_from_row):
7281 (get_next_display_element, set_iterator_to_next):
7282 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7283 (show_mouse_face): Remove decls
7284 * frame.h (message_buf_print): Likewise.
7285 * lisp.h (pop_message, set_message, check_point_in_composition):
7286 Likewise.
7287 * xterm.h (set_vertical_scroll_bar): Likewise.
7288 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7289 (message_buf_print, scratch_glyph_row, displayed_buffer):
7290 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7291 (get_next_display_element, show_mouse_face, window_box_edges):
7292 (frame_to_window_pixel_xy, check_point_in_composition):
7293 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7294 (glyph_to_pixel_coords): Remove; unused.
7295
7296 * dired.c (file_name_completion): Now static.
7297
7298 * dbusbind.c (xd_in_read_queued_messages): Now static.
7299
7300 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7301 * data.c (circular_list_error): Remove.
7302
7303 * commands.h (last_point_position, last_point_position_buffer):
7304 (last_point_position_window): Remove decls.
7305 * keyboard.c: Make these variables static.
7306
7307 * coding.h (coding, code_convert_region, encode_coding_gap):
7308 Remove decls.
7309 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7310 (iso_code_class, detect_coding, code_convert_region): Now static.
7311 (encode_coding_gap): Remove; unused.
7312
7313 * chartab.c (chartab_chars, chartab_bits): Now static.
7314
7315 * charset.h (charset_iso_8859_1): Remove decl.
7316 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7317 Now static.
7318
7319 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7320 * ccl.c (Vccl_program_table): Now static.
7321 (check_ccl_update): Remove; unused.
7322
7323 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7324 * category.h: ... from here.
7325 * category.c (check_category_table, set_category_set): Now static.
7326
7327 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7328 * lisp.h: Remove these decls.
7329
7330 * buffer.c (buffer_count): Remove unused var.
7331
7332 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7333 so that it's not optimized away.
7334 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7335 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7336 exported only to the debugger.
7337
7338 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7339 * atimer.h (run_all_atimers): Remove; not exported.
7340
7341 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7342 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7343 was inaccessible from Lisp.
7344 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7345 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7346
7347 alloc.c: Import and export fewer symbols, and remove unused items.
7348 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7349 is defined.
7350 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7351 it's not optimized away by whole-program optimization.
7352 (message_enable_multibyte, free_misc): Remove.
7353 (catchlist, handlerlist, mark_backtrace):
7354 Declare only if BYTE_MARK_STACK.
7355 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7356 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7357 (message_enable_multibyte): Remove decl.
7358 (free_misc, interval_free_list, float_block, float_block_index):
7359 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7360 (cons_free_list, last_marked_index):
7361 Now static.
7362 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7363 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7364 (mark_backtrace): Define only if BYTE_MARK_STACK.
7365 * xdisp.c (message_enable_multibyte): Now static.
7366
7367 Declare Lisp_Object Q* variables to be 'static' if not exported.
7368 This makes it easier for human readers (and static analyzers)
7369 to see whether these variables are used from other modules.
7370 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7371 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7372 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7373 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7374 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7375 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7376 * xmenu.c, xselect.c:
7377 Declare Q* vars static if they are not used in other modules.
7378 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7379 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7380 Remove decls of unexported vars.
7381 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7382
7383 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7384
7385 Make Emacs functions such as Fatom 'static' by default.
7386 This makes it easier for human readers (and static analyzers)
7387 to see whether these functions can be called from other modules.
7388 DEFUN now defines a static function. To make the function external
7389 so that it can be used in other C modules, use the new macro DEFUE.
7390 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7391 (Finit_image_library):
7392 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7393 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7394 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7395 Remove decls, since these functions are now static.
7396 (Funintern, Fget_internal_run_time): New decls, since these functions
7397 were already external.
7398
7399 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7400 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7401 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7402 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7403 * keyboard.c, keymap.c, lread.c:
7404 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7405 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7406 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7407 Mark functions with DEFUE instead of DEFUN,
7408 if they are used in other modules.
7409 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7410 decls for now-static functions.
7411 * buffer.h (Fdelete_overlay): Remove decl.
7412 * callproc.c (Fgetenv_internal): Mark as internal.
7413 * composite.c (Fremove_list_of_text_properties): Remove decl.
7414 (Fcomposition_get_gstring): New forward static decl.
7415 * composite.h (Fcomposite_get_gstring): Remove decl.
7416 * dired.c (Ffile_attributes): New forward static decl.
7417 * doc.c (Fdocumntation_property): New forward static decl.
7418 * eval.c (Ffetch_bytecode): New forward static decl.
7419 (Funintern): Remove extern decl; now in .h file where it belongs.
7420 * fileio.c (Fmake_symbolic_link): New forward static decl.
7421 * image.c (Finit_image_library): New forward static decl.
7422 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7423 * intervals.h (Fprevious_property_change):
7424 (Fremove_list_of_text_properties): Remove decls.
7425 * keyboard.c (Fthis_command_keys): Remove decl.
7426 (Fcommand_execute): New forward static decl.
7427 * keymap.c (Flookup_key): New forward static decl.
7428 (Fcopy_keymap): Now static.
7429 * keymap.h (Flookup_key): Remove decl.
7430 * process.c (Fget_process): New forward static decl.
7431 (Fprocess_datagram_address): Mark as internal.
7432 * syntax.c (Fsyntax_table_p): New forward static decl.
7433 (skip_chars): Remove duplicate decl.
7434 * textprop.c (Fprevious_property_change): New forward static decl.
7435 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7436 Now internal.
7437 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7438 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7439
7440 * editfns.c (Fformat): Remove unreachable code.
7441
7442 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7443
7444 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7445 change. (Bug#8496)
7446
7447 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7448
7449 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7450 when at ZV. (Bug#8487)
7451
7452 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7453
7454 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7455 (Bug#8437)
7456 * keyboard.c (parse_tool_bar_item): Likewise.
7457 * sound.c (sound_cleanup, alsa_close): Likewise.
7458 * termcap.c (tgetent): Likewise.
7459 * xfns.c (x_default_font_parameter): Likewise.
7460 * xsettings.c (read_and_apply_settings): Likewise.
7461
7462 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7463 (overrun_check_free): Protoize.
7464
7465 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7466
7467 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7468 since callers should never pass a negative size.
7469 Change the signature to match that of plain 'read' and 'write'; see
7470 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7471 * lisp.h: Update prototypes of emacs_write and emacs_read.
7472
7473 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7474
7475 * xdisp.c (redisplay_window): Don't try to determine the character
7476 position of the scroll margin if the window start point w->startp
7477 is outside the buffer's accessible region. (Bug#8468)
7478
7479 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7480
7481 Fix write-region and its subroutines for buffers > 2GB.
7482 * fileio.c (a_write, e_write): Modify declaration of arguments and
7483 local variables to support buffers larger than 2GB.
7484 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7485
7486 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7487 argument, local variables, and return value.
7488
7489 * lisp.h: Update prototypes of emacs_write and emacs_read.
7490
7491 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7492
7493 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7494
7495 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7496
7497 Fix more problems found by GCC 4.6.0's static checks.
7498
7499 * xdisp.c (vmessage): Use a better test for character truncation.
7500
7501 * charset.c (load_charset_map): <, not <=, for optimization,
7502 and to avoid potential problems with integer overflow.
7503 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7504 * casetab.c (set_identity, shuffle): Likewise.
7505 * editfns.c (Fformat): Likewise.
7506 * syntax.c (skip_chars): Likewise.
7507
7508 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7509 This also lets GCC 4.6.0 generate slightly better loop code.
7510
7511 * callint.c (Fcall_interactively): <, not <=, for optimization.
7512 (Fcall_interactively): Count the number of arguments produced,
7513 not the number of arguments given. This is simpler and lets GCC
7514 4.6.0 generate slightly better code.
7515
7516 * ftfont.c: Distingish more carefully between FcChar8 and char.
7517 The previous code passed unsigned char * to a functions like
7518 strlen and xstrcasecmp that expect char *, which does not
7519 conform to the C standard.
7520 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7521 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7522 char * when the C standard requires it.
7523
7524 * keyboard.c (read_char): Remove unused var.
7525
7526 * eval.c: Port to Windows vsnprintf (Bug#8435).
7527 Include <limits.h>.
7528 (SIZE_MAX): Define if the headers do not.
7529 (verror): Do not give up if vsnprintf returns a negative count.
7530 Instead, grow the buffer. This ports to Windows vsnprintf, which
7531 does not conform to C99. Problem reported by Eli Zaretskii.
7532 Also, simplify the allocation scheme, by avoiding the need for
7533 calling realloc, and removing the ALLOCATED variable.
7534
7535 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7536
7537 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7538 But keep the doprint source code for now, as we might revamp it
7539 and use it again (Bug#8435).
7540 * lisp.h (doprnt): Remove.
7541 * Makefile.in (base_obj): Remove doprnt.o.
7542 * deps.mk (doprnt.o): Remove.
7543
7544 error: Print 32- and 64-bit integers portably (Bug#8435).
7545 Without this change, on typical 64-bit hosts error ("...%d...", N)
7546 was used to print both 32- and 64-bit integers N, which relied on
7547 undefined behavior.
7548 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7549 New macro.
7550 * lisp.h (error, verror): Mark as printf-like functions.
7551 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7552 Report overflow in size calculations when allocating printf buffer.
7553 Do not truncate output string at its first null byte.
7554 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7555 Truncate the output at a character boundary, since vsnprintf does not
7556 do that.
7557 * charset.c (check_iso_charset_parameter): Convert internal
7558 character to string before calling 'error', since %c now has the
7559 printf meaning.
7560 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7561 overflow when computing char to be passed to 'error'. Do not
7562 pass Lisp_Object to 'error'; pass the integer instead.
7563 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7564 formatted with plain %d.
7565
7566 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7567
7568 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7569
7570 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7571
7572 * xterm.c (x_catch_errors): Remove duplicate declaration.
7573
7574 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7575
7576 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7577
7578 2011-04-10 Jim Meyering <meyering@redhat.com>
7579
7580 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7581 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7582 return ssize_t not "int", and use size_t as the buffer length.
7583 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7584 * gnutls.h: Update declarations.
7585 * process.c (read_process_output): Use ssize_t, to match.
7586 (send_process): Likewise.
7587
7588 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7589
7590 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7591
7592 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7593
7594 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7595 Use unsigned char, to match FcChar8 type definition.
7596
7597 * xterm.c (handle_one_xevent):
7598 * xmenu.c (create_and_show_popup_menu):
7599 * xselect.c (x_decline_selection_request)
7600 (x_reply_selection_request): Avoid type-punned deref of X events.
7601
7602 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7603
7604 Fix some uses of `int' instead of EMACS_INT.
7605 * search.c (string_match_1, fast_string_match)
7606 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7607 (scan_buffer, find_next_newline_no_quit)
7608 (find_before_next_newline, search_command, Freplace_match)
7609 (Fmatch_data): Make some `int' variables be EMACS_INT.
7610
7611 * xdisp.c (display_count_lines): 3rd argument and return value now
7612 EMACS_INT. All callers changed.
7613 (pint2hrstr): Last argument is now EMACS_INT.
7614
7615 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7616 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7617 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7618 (decode_coding_utf_16, decode_coding_emacs_mule)
7619 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7620 (decode_coding_ccl, decode_coding_charset)
7621 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7622 (decode_coding_iso_2022, decode_coding_emacs_mule)
7623 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7624 <char_offset, last_offset>: Declare EMACS_INT.
7625 (encode_coding_utf_8, encode_coding_utf_16)
7626 (encode_coding_emacs_mule, encode_invocation_designation)
7627 (encode_designation_at_bol, encode_coding_iso_2022)
7628 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7629 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7630 Declare EMACS_INT.
7631 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7632 (encode_invocation_designation): Last argument P_NCHARS is now
7633 EMACS_INT.
7634 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7635 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7636
7637 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7638 All users changed.
7639
7640 * ccl.c (Fccl_execute_on_string): Declare some variables
7641 EMACS_INT.
7642
7643 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7644
7645 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7646
7647 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7648
7649 * process.c (Fformat_network_address): Doc fix.
7650
7651 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7652
7653 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7654
7655 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7656
7657 * keyboard.c (read_char): Call Lisp function help-form-show,
7658 instead of using internal_with_output_to_temp_buffer.
7659 (Qhelp_form_show): New var.
7660 (syms_of_keyboard): Use DEFSYM macro.
7661
7662 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7663
7664 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7665
7666 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7667
7668 * process.c (Flist_processes): Remove to Lisp.
7669 (list_processes_1): Delete.
7670
7671 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7672
7673 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7674
7675 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7676
7677 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7678
7679 Fix more problems found by GCC 4.6.0's static checks.
7680
7681 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7682
7683 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7684
7685 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7686
7687 * xdisp.c (vmessage): Mark as a printf-like function.
7688
7689 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7690
7691 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7692
7693 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7694 printf-like functions.
7695 (tiff_load): Add casts to remove these marks before passing them
7696 to system-supplied API.
7697
7698 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7699
7700 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7701 This avoids several warnings with gcc -Wstrict-overflow.
7702 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7703 directly, rather than having caller test rule sign. This avoids
7704 some unnecessary tests.
7705 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7706 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7707 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7708
7709 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7710 (xfont_open): Avoid unnecessary tests.
7711
7712 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7713
7714 * composite.h, composite.c (composition_gstring_put_cache):
7715 Use EMACS_INT, not int, for length.
7716
7717 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7718 breaking out part of COMPOSITION_DECODE_RULE.
7719 (COMPOSITION_DECODE_RULE): Use it.
7720 * composite.c (get_composition_id): Remove unused local vars,
7721 by using the new macro.
7722
7723 * textprop.c (set_text_properties_1): Change while to do-while,
7724 since the condition is always true at first.
7725
7726 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7727 (interval_deletion_adjustment): Return unsigned value.
7728 All uses changed.
7729
7730 * process.c (list_processes_1, create_pty, read_process_output):
7731 (exec_sentinel): Remove vars that were set but not used.
7732 (create_pty): Remove unnecessary "volatile"s.
7733 (Fnetwork_interface_info): Avoid possibility of int overflow.
7734 (read_process_output): Do adaptive read buffering even if carryover.
7735 (read_process_output): Simplify nbytes computation if buffered.
7736
7737 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7738
7739 * syntax.c (scan_words): Remove var that was set but not used.
7740 (update_syntax_table): Use unsigned instead of int.
7741
7742 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7743 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7744 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7745
7746 * print.c (print_error_message): Avoid int overflow.
7747
7748 * font.c (font_list_entities): Redo for clarity,
7749 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7750
7751 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7752 (font_score): Avoid potential overflow in diff calculation.
7753
7754 * fns.c (substring_both): Remove var that is set but not used.
7755 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7756
7757 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7758
7759 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7760 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7761 can always succeed if overflow has undefined behavior.
7762
7763 * search.c (boyer_moore, wordify): Remove vars set but not used.
7764 (wordify): Omit three unnecessary tests.
7765
7766 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7767 All callers changed. This avoids the need for an unused var.
7768
7769 * casefiddle.c (casify_region): Remove var that is set but not used.
7770
7771 * dired.c (file_name_completion): Remove var that is set but not used.
7772
7773 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7774
7775 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7776 (Finsert_file_contents): Remove unnecessary code checking fd.
7777
7778 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7779 Check for integer overflow on size calculations.
7780
7781 * buffer.c (Fprevious_overlay_change): Remove var that is set
7782 but not used.
7783
7784 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7785 Remove vars that are set but not used.
7786 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7787 (timer_check_2): Mark vars as initialized.
7788
7789 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7790
7791 * image.c (lookup_image): Remove var that is set but not used.
7792 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7793
7794 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7795 that are set but not used.
7796
7797 * xfns.c (make_invisible_cursor): Don't return garbage
7798 if XCreateBitmapFromData fails (Bug#8410).
7799
7800 * xselect.c (x_get_local_selection, x_handle_property_notify):
7801 Remove vars that are set but not used.
7802
7803 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7804 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7805
7806 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7807 Remove var that is set but not used.
7808 (scroll_bar_windows_size): Now size_t, not int.
7809 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7810 Check for overflow.
7811
7812 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7813 (map_tty_color) [!defined MSDOS]: Likewise.
7814
7815 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7816
7817 * coding.c: Remove vars that are set but not used.
7818 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7819 All callers changed.
7820 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7821 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7822 (decode_coding_charset): Remove vars that are set but not used.
7823
7824 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7825 that is set but not used.
7826
7827 * print.c (print_object): Remove var that is set but not used.
7828
7829 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7830 The gnulib version avoids calling malloc in the usual case,
7831 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7832 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7833 * filelock.c (current_lock_owner): Likewise.
7834 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7835 * sysdep.c: Include allocator.h, careadlinkat.h.
7836 (emacs_no_realloc_allocator): New static constant.
7837 (emacs_readlink): New function.
7838 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7839 ../lib/careadlinkat.h.
7840
7841 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7842
7843 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7844 first non-nil return value).
7845
7846 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7847
7848 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7849 if not defined (Bug#8403).
7850
7851 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7852
7853 * xdisp.c (display_count_lines): Remove parameter `start',
7854 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7855 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7856 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7857 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7858 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7859 and thereabouts. All callers changed.
7860 (get_per_char_metric): Remove parameter `f', unused since
7861 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7862
7863 2011-04-02 Jim Meyering <meyering@redhat.com>
7864
7865 do not dereference NULL upon failed strdup
7866 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7867 (ns_get_family): Likewise.
7868
7869 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7870
7871 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7872
7873 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7874
7875 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7876 later (Bug#8403).
7877
7878 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7879
7880 Add lexical binding.
7881
7882 * window.c (Ftemp_output_buffer_show): New fun.
7883 (Fsave_window_excursion):
7884 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7885
7886 * lread.c (lisp_file_lexically_bound_p): New function.
7887 (Fload): Bind Qlexical_binding.
7888 (readevalloop): Remove `evalfun' arg.
7889 Bind Qinternal_interpreter_environment.
7890 (Feval_buffer): Bind Qlexical_binding.
7891 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7892 Mark as dynamic.
7893 (syms_of_lread): Declare `lexical-binding'.
7894
7895 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7896
7897 * keyboard.c (eval_dyn): New fun.
7898 (menu_item_eval_property): Use it.
7899
7900 * image.c (parse_image_spec): Use Ffunctionp.
7901
7902 * fns.c (concat, mapcar1): Accept byte-code-functions.
7903
7904 * eval.c (Fsetq): Handle lexical vars.
7905 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7906 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7907 (FletX, Flet): Obey lexical binding.
7908 (Fcommandp): Handle closures.
7909 (Feval): New `lexical' arg.
7910 (eval_sub): New function extracted from Feval. Use it almost
7911 everywhere where Feval was used. Look up vars in lexical env.
7912 Handle closures.
7913 (Ffunctionp): Move from subr.el.
7914 (Ffuncall): Handle closures.
7915 (apply_lambda): Remove `eval_flags'.
7916 (funcall_lambda): Handle closures and new byte-code-functions.
7917 (Fspecial_variable_p): New function.
7918 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7919 but without exporting it to Lisp.
7920
7921 * doc.c (Fdocumentation, store_function_docstring):
7922 * data.c (Finteractive_form): Handle closures.
7923
7924 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7925 interactive spec.
7926
7927 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7928 New byte-codes.
7929 (exec_byte_code): New function extracted from Fbyte_code to handle new
7930 calling convention for byte-code-functions. Add new byte-codes.
7931
7932 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7933
7934 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7935
7936 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7937
7938 * xdisp.c (redisplay_internal): Fix prototype.
7939
7940 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7941
7942 * xdisp.c (SCROLL_LIMIT): New macro.
7943 (try_scrolling): Use it when setting scroll_limit.
7944 Limit scrolling to 100 screen lines.
7945 (redisplay_window): Even when falling back on "recentering",
7946 position point in the window according to scroll-conservatively,
7947 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7948
7949 (try_scrolling): When point is above the window, allow searching
7950 as far as scroll_max, or one screenful, to compute vertical
7951 distance from PT to the scroll margin position. This prevents
7952 try_scrolling from unnecessarily failing when
7953 scroll-conservatively is set to a value slightly larger than the
7954 window height. Clean up the case of PT below the margin at bottom
7955 of window: scroll_max can no longer be INT_MAX. When aggressive
7956 scrolling is in use, don't let point enter the opposite scroll
7957 margin as result of the scroll.
7958 (syms_of_xdisp) <scroll-conservatively>: Document the
7959 threshold of 100 lines for never-recentering scrolling.
7960
7961 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7962
7963 * dispextern.h (move_it_by_lines):
7964 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7965 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7966 (message_log_check_duplicate): Remove parameters `prev_bol' and
7967 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7968 (redisplay_internal): Remove parameter `preserve_echo_area',
7969 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7970
7971 * indent.c (Fvertical_motion):
7972 * window.c (window_scroll_pixel_based, Frecenter):
7973 Don't pass `need_y_p' to `move_it_by_lines'.
7974
7975 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7976
7977 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7978 steal a few bits to be more compact.
7979 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7980 Remove unneeded casts.
7981
7982 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7983
7984 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7985
7986 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7987 binding" message (bug#7967).
7988
7989 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7990
7991 Fix more problems found by GCC 4.6.0's static checks.
7992
7993 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7994 Remove unused local var.
7995
7996 * editfns.c (Fmessage_box): Remove unused local var.
7997
7998 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7999 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8000 Omit unused local vars.
8001 * window.c (shrink_windows): Omit unused local var.
8002 * menu.c (digest_single_submenu): Omit unused local var.
8003 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8004 Omit unused local var.
8005
8006 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8007 Don't assume string length fits in int.
8008 (keyremap_step, read_key_sequence): Use size_t for sizes.
8009 (read_key_sequence): Don't check last_real_key_start redundantly.
8010
8011 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8012 instead of alloca (Bug#8344).
8013
8014 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8015 (Fbacktrace_frame): Don't assume nframes fits in int.
8016
8017 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8018
8019 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8020 concerns.
8021
8022 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8023
8024 * cm.c (calccost): Turn while-do into do-while, for clarity.
8025
8026 * keyboard.c (syms_of_keyboard): Use the same style as later
8027 in this function when indexing through an array. This also
8028 works around GCC bug 48267.
8029
8030 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8031
8032 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8033
8034 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8035 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8036
8037 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8038 This avoids undefined behavior on integer overflow, and is a bit
8039 more convenient anyway since it is compared to a size_t variable.
8040
8041 Variadic C functions now count arguments with size_t, not int.
8042 This avoids an unnecessary limitation on 64-bit machines, which
8043 caused (substring ...) to crash on large vectors (Bug#8344).
8044 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8045 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8046 All variadic functions and their callers changed accordingly.
8047 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8048 * data.c (arith_driver, float_arith_driver): Likewise.
8049 * editfns.c (general_insert_function): Likewise.
8050 * eval.c (struct backtrace.nargs, interactive_p)
8051 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8052 (funcall_lambda, mark_backtrace): Likewise.
8053 * fns.c (concat): Likewise.
8054 * frame.c (x_set_frame_parameters): Likewise.
8055 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8056 0 if not found, not -1. All callers changed.
8057
8058 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8059 (stack_copy_size): Now size_t, not int.
8060 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8061
8062 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8063
8064 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8065 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8066 All callers changed.
8067
8068 * lisp.h (multibyte_char_to_unibyte):
8069 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8070 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8071 * character.h (CHAR_TO_BYTE8):
8072 * cmds.c (internal_self_insert):
8073 * editfns.c (general_insert_function):
8074 * keymap.c (push_key_description):
8075 * search.c (Freplace_match):
8076 * xdisp.c (message_dolog, set_message_1): All callers changed.
8077
8078 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8079
8080 * keyboard.c (safe_run_hook_funcall): New function.
8081 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8082 don't set the hook to nil, but remove the offending function instead.
8083 (Qcommand_hook_internal): Remove, unused.
8084 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8085 Vcommand_hook_internal.
8086
8087 * eval.c (enum run_hooks_condition): Remove.
8088 (funcall_nil, funcall_not): New functions.
8089 (run_hook_with_args): Call each function through a `funcall' argument.
8090 Remove `cond' argument, now redundant.
8091 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8092 (Frun_hook_with_args_until_failure): Adjust accordingly.
8093 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8094
8095 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8096
8097 * dispextern.h (string_buffer_position): Remove declaration.
8098
8099 * print.c (strout): Remove parameter `multibyte', unused since
8100 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8101
8102 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8103 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8104 All callers changed.
8105
8106 * w32.c (_wsa_errlist): Use braces for struct initializers.
8107
8108 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8109 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8110 All callers changed.
8111 (string_buffer_position): Likewise. Also, make static (it's never
8112 used outside xdisp.c).
8113 (cursor_row_p): Remove parameter `w', unused since
8114 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8115 (decode_mode_spec): Remove parameter `precision', introduced during
8116 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8117 All callers changed.
8118
8119 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8120
8121 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8122
8123 2011-03-27 Anders Lindgren <andlind@gmail.com>
8124
8125 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8126 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8127 (ns_update_auto_hide_menu_bar): New functions.
8128 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8129 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8130 ns_constrain_all_frames.
8131 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8132 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8133
8134 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8135
8136 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8137
8138 2011-03-27 Glenn Morris <rgm@gnu.org>
8139
8140 * syssignal.h: Replace RETSIGTYPE with void.
8141 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8142 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8143 Replace SIGTYPE with void everywhere.
8144 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8145 * s/template.h (SIGTYPE): Remove commented out definition.
8146
8147 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8148
8149 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8150 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8151
8152 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8153
8154 * w32.c (read_unc_volume): Use parameter `henum', instead of
8155 global variable `wget_enum_handle'.
8156
8157 * keymap.c (describe_vector): Remove parameters `indices' and
8158 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8159 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8160
8161 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8162
8163 * keyboard.c (timer_check): Remove parameter `do_it_now',
8164 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8165 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8166 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8167
8168 * keyboard.c (read_char):
8169 * w32menu.c (w32_menu_display_help):
8170 * xmenu.c (show_help_event, menu_help_callback):
8171 Adjust calls to `show_help_echo'.
8172
8173 * gtkutil.c (xg_maybe_add_timer):
8174 * keyboard.c (readable_events):
8175 * process.c (wait_reading_process_output):
8176 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8177
8178 * insdel.c (adjust_markers_gap_motion):
8179 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8180 (gap_left, gap_right): Don't call it.
8181
8182 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8183
8184 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8185 incurred during fontification.
8186
8187 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8188
8189 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8190 (DEFVAR_PER_BUFFER): Don't pass it.
8191
8192 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8193 (scrolling_window): Don't pass it.
8194
8195 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8196
8197 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8198
8199 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8200 and `suffix'.
8201 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8202 of variables specific to SELinux and computation of `encoded_absname'.
8203
8204 * image.c (XPutPixel): Remove unused variable `height'.
8205
8206 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8207
8208 * unexw32.c (get_section_info): Remove unused variable `section'.
8209
8210 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8211 (system_process_attributes): Remove unused variable `sess'.
8212 (sys_read): Remove unused variable `err'.
8213
8214 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8215 (w32_wnd_proc): Remove unused variable `isdead'.
8216 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8217 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8218 (x_create_tip_frame): Remove unused variable `tem'.
8219
8220 * w32inevt.c (w32_console_read_socket):
8221 Remove unused variable `no_events'.
8222
8223 * w32term.c (x_draw_composite_glyph_string_foreground):
8224 Remove unused variable `width'.
8225
8226 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8227
8228 * w32term.c (x_set_glyph_string_clipping):
8229 Don't pass uninitialized region to CombineRgn.
8230
8231 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8232
8233 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8234 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8235 (Fx_close_connection): Remove unused variable `i'.
8236
8237 * w32font.c (w32font_draw): Return number of glyphs.
8238 (w32font_open_internal): Remove unused variable `i'.
8239 (w32font_driver): Add missing initializer.
8240
8241 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8242 (fill_in_menu): Remove unused variable `items_added'.
8243
8244 * w32term.c (last_mouse_press_frame): Remove static global variable.
8245 (w32_clip_to_row): Remove unused variable `f'.
8246 (x_delete_terminal): Remove unused variable `i'.
8247
8248 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8249 (NOTHING): Remove unused static global variable.
8250 (uniscribe_check_otf): Remove unused variable `table'.
8251 (uniscribe_font_driver): Add missing initializers.
8252
8253 2011-03-23 Julien Danjou <julien@danjou.info>
8254
8255 * term.c (Fsuspend_tty, Fresume_tty):
8256 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8257 * window.c (temp_output_buffer_show):
8258 * insdel.c (signal_before_change):
8259 * frame.c (Fhandle_switch_frame):
8260 * fileio.c (Fdo_auto_save):
8261 * emacs.c (Fkill_emacs):
8262 * editfns.c (save_excursion_restore):
8263 * cmds.c (internal_self_insert):
8264 * callint.c (Fcall_interactively):
8265 * buffer.c (Fkill_all_local_variables):
8266 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8267 Use Frun_hooks.
8268 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8269 unconditionally since it does the check itself.
8270
8271 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8272
8273 Fix more problems found by GCC 4.5.2's static checks.
8274
8275 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8276 the first time through the loop, since we know p0 < p1 then.
8277 This also avoids a gcc -Wstrict-overflow warning.
8278
8279 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8280 leading to a memory leak, possible in functions like
8281 load_charset_map_from_file that can allocate an unbounded number
8282 of objects (Bug#8318).
8283
8284 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8285 that could (at least in theory) be that large.
8286
8287 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8288 This is less likely to overflow, and avoids undefined behavior if
8289 overflow does occur. All callers changed. Use strtoul to scan
8290 for the unsigned long integer.
8291 (pint2hrstr): Simplify and tune code slightly.
8292 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8293
8294 * scroll.c (do_scrolling): Work around GCC bug 48228.
8295 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8296
8297 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8298 This also avoids a warning with gcc -Wstrict-overflow.
8299 (validate_x_resource_name): Simplify count usage.
8300 This also avoids a warning with gcc -Wstrict-overflow.
8301
8302 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8303 fail (Bug#8306).
8304
8305 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8306
8307 * process.c (Fmake_network_process): Use socklen_t, not int,
8308 where POSIX says socklen_t is required in portable programs.
8309 This fixes a porting bug on hosts like 64-bit HP-UX, where
8310 socklen_t is wider than int (Bug#8277).
8311 (Fmake_network_process, server_accept_connection):
8312 (wait_reading_process_output, read_process_output):
8313 Likewise.
8314
8315 * process.c: Rename or move locals to avoid shadowing.
8316 (list_processes_1, Fmake_network_process):
8317 (read_process_output_error_handler, exec_sentinel_error_handler):
8318 Rename or move locals.
8319 (Fmake_network_process): Define label "retry_connect" only if needed.
8320 (Fnetwork_interface_info): Fix pointer signedness.
8321 (process_send_signal): Add cast to avoid pointer signedness problem.
8322 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8323 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8324
8325 Make tparam.h and terminfo.c consistent.
8326 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8327 Include tparam.h instead, since it declares them.
8328 * cm.h (PC): Remove extern decl; tparam.h now does this.
8329 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8330 * terminfo.c: Include tparam.h, to check interfaces.
8331 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8332 (tparam): Adjust signature to match interface in tparam.h;
8333 this removes some undefined behavior. Check that outstring and len
8334 are zero, which they always are with Emacs.
8335 * tparam.h (PC, BC, UP): New extern decls.
8336
8337 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8338 (xftfont_open): Rename locals to avoid shadowing.
8339
8340 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8341 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8342 (OTF_TAG_SYM): Omit macro if not needed.
8343 (ftfont_list): Remove unused local.
8344 (get_adstyle_property, ftfont_pattern_entity):
8345 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8346 Rename locals to avoid shadowing.
8347
8348 * xfont.c (xfont_list_family): Mark var as initialized.
8349
8350 * xml.c (make_dom): Now static.
8351
8352 * composite.c (composition_compute_stop_pos): Rename local to
8353 avoid shadowing.
8354 (composition_reseat_it): Remove unused locals.
8355 (find_automatic_composition, composition_adjust_point): Likewise.
8356 (composition_update_it): Mark var as initialized.
8357 (find_automatic_composition): Mark vars as initialized,
8358 with a FIXME (Bug#8290).
8359
8360 character.h: Rename locals to avoid shadowing.
8361 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8362 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8363 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8364 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8365 to avoid shadowing.
8366
8367 * textprop.c (property_change_between_p): Remove; unused.
8368
8369 * intervals.c (interval_start_pos): Now static.
8370
8371 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8372
8373 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8374 Rename locals to avoid shadowing.
8375
8376 * sound.c (wav_play, au_play, Fplay_sound_internal):
8377 Fix pointer signedness.
8378 (alsa_choose_format): Remove unused local var.
8379 (wav_play): Initialize a variable to 0, to prevent undefined
8380 behavior (Bug#8278).
8381
8382 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8383
8384 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8385
8386 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8387 clobbering (Bug#8298).
8388 * sysdep.c (sys_subshell): Likewise.
8389 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8390
8391 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8392 This should get cleaned up, so that child_setup has the
8393 same signature on all platforms.
8394
8395 * callproc.c (call_process_cleanup): Now static.
8396 (relocate_fd): Rename locals to avoid shadowing.
8397
8398 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8399
8400 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8401 not to be necessary, and produces flickering.
8402
8403 2011-03-20 Glenn Morris <rgm@gnu.org>
8404
8405 * config.in: Remove file.
8406
8407 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8408
8409 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8410 are now in src/globals.h.
8411 (syms_of_minibuf): Remove spurious & from previous change.
8412
8413 2011-03-20 Leo Liu <sdl.web@gmail.com>
8414
8415 * minibuf.c (completing-read-function): New variable.
8416 (completing-read-default): Rename from completing-read.
8417 (completing-read): Call completing-read-function.
8418
8419 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8420
8421 * xfaces.c (Fx_load_color_file):
8422 Read color file from absolute filename (bug#8250).
8423
8424 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8425
8426 * makefile.w32-in: Update dependencies.
8427
8428 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8429
8430 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8431
8432 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8433
8434 Fix more problems found by GCC 4.5.2's static checks.
8435
8436 * process.c (make_serial_process_unwind, send_process_trap):
8437 (sigchld_handler): Now static.
8438
8439 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8440 That way, the code declares only the vars that it needs.
8441 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8442 * s/cygwin.h (PTY_ITERATION): Likewise.
8443 * s/darwin.h (PTY_ITERATION): Likewise.
8444 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8445
8446 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8447 * process.c (allocate_pty): Don't declare stb unless it's needed.
8448
8449 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8450 (CONSTANTLIM): Remove; unused.
8451 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8452 Define only if needed.
8453
8454 * unexelf.c (unexec): Name an expression,
8455 to avoid gcc -Wbad-function-cast warning.
8456 Use a different way to cause a compilation error if anyone uses
8457 n rather than nn, a way that does not involve shadowing.
8458 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8459
8460 * deps.mk (unexalpha.o): Remove; unused.
8461
8462 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8463 * unexec.h: New file.
8464 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8465 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8466 Depend on unexec.h.
8467 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8468 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8469 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8470 Change as necessary to match prototype in unexec.h.
8471
8472 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8473 shadowing.
8474 (back_comment, skip_chars): Mark vars as initialized.
8475
8476 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8477 Rename locals to avoid shadowing.
8478
8479 * lread.c (read1): Rewrite so as not to use empty "else".
8480 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8481
8482 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8483
8484 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8485 warning when compiling print.c.
8486
8487 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8488 instead of using an uninitialized var.
8489 (font_sort_entities): Mark var as initialized.
8490
8491 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8492
8493 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8494 pointers to constants.
8495 (font_parse_fcname): Remove unused vars.
8496 (font_delete_unmatched): Now static.
8497 (font_get_spec): Remove; unused.
8498 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8499 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8500 Rename or move locals to avoid shadowing.
8501
8502 * fns.c (require_nesting_list, require_unwind): Now static.
8503 (Ffillarray): Rename locals to avoid shadowing.
8504
8505 * floatfns.c (domain_error2): Define only if needed.
8506 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8507
8508 * alloc.c (mark_backtrace): Move decl from here ...
8509 * lisp.h: ... to here, so that it can be checked.
8510
8511 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8512 (Fdefvar): Rewrite so as not to use empty "else".
8513 (lisp_indirect_variable): Name an expression,
8514 to avoid gcc -Wbad-function-cast warning.
8515 (Fdefvar): Rename locals to avoid shadowing.
8516
8517 * callint.c (quotify_arg, quotify_args): Now static.
8518 (Fcall_interactively): Rename locals to avoid shadowing.
8519 Use const pointer when appropriate.
8520
8521 * lisp.h (get_system_name, get_operating_system_release):
8522 Move decls here, to check interfaces.
8523 * process.c (get_operating_system_release): Move decl to lisp.h.
8524 * xrdb.c (get_system_name): Likewise.
8525 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8526 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8527 some of which prompt warnings from gcc -Wbad-function-cast.
8528 (Fformat_time_string, Fencode_time, Finsert_char):
8529 (Ftranslate_region_internal, Fformat):
8530 Rename or remove local vars to avoid shadowing.
8531 (Ftranslate_region_internal): Mark var as initialized.
8532
8533 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8534 avoid shadowing.
8535
8536 * lisp.h (eassert): Check that the argument compiles, even if
8537 ENABLE_CHECKING is not defined.
8538
8539 * data.c (Findirect_variable): Name an expression, to avoid
8540 gcc -Wbad-function-cast warning.
8541 (default_value, arithcompare, arith_driver, arith_error): Now static.
8542 (store_symval_forwarding): Rename local to avoid shadowing.
8543 (Fmake_variable_buffer_local, Fmake_local_variable):
8544 Mark variables as initialized.
8545 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8546
8547 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8548 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8549 Rename locals to avoid shadowing.
8550 (mark_stack): Move local variables into the #ifdef region where
8551 they're used.
8552 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8553 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8554 needed otherwise.
8555 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8556 (GC_STRING_CHARS): Remove; not used.
8557 (Fmemory_limit): Cast sbrk's returned value to char *.
8558
8559 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8560 avoids undefined behavior in theory.
8561
8562 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8563
8564 Use functions, not macros, for up- and down-casing (Bug#8254).
8565 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8566 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8567 to use the following functions instead of these macros.
8568 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8569 EMACS_INT, since callers assume the returned value fits in int.
8570 (upcase1): Likewise, for UPCASE_TABLE.
8571 (uppercasep, lowercasep, upcase): New static inline functions.
8572 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8573 the race-condition problem in the old DOWNCASE.
8574
8575 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8576 Rename locals to avoid shadowing.
8577 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8578 (regex_compile, re_search_2, re_match_2_internal):
8579 Remove unused local vars.
8580 (FREE_VAR): Rewrite so as not to use empty "else",
8581 which gcc can warn about.
8582 (regex_compile, re_match_2_internal): Mark locals as initialized.
8583 (RETALLOC_IF): Define only if needed.
8584 (WORDCHAR_P): Likewise. This one is never needed, but is used
8585 only in a comment talking about a compiler bug, so put inside
8586 the #if 0 of that comment.
8587 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8588 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8589 Remove; unused.
8590
8591 * search.c (boyer_moore): Rename locals to avoid shadowing.
8592 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8593 (PREV_CHAR_BOUNDARY): Likewise.
8594
8595 * search.c (simple_search): Remove unused var.
8596
8597 * dired.c (compile_pattern): Move decl from here ...
8598 * lisp.h: ... to here, so that it can be checked.
8599 (struct re_registers): New forward decl.
8600
8601 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8602
8603 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8604 All uses changed.
8605 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8606 Rename locals to avoid shadowing.
8607 (Fvertical_motion): Mark locals as initialized.
8608
8609 * casefiddle.c (casify_object, casify_region): Now static.
8610 (casify_region): Mark local as initialized.
8611
8612 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8613
8614 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8615 New macros, so that the caller can use some names other than
8616 gcpro1, gcpro2, etc.
8617 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8618 of the new macros.
8619 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8620 argument, for consistency with GCPRO2_VAR, etc: it is now the
8621 prefix of the variable, not the variable itself. All uses
8622 changed.
8623 * dired.c (directory_files_internal, file_name_completion):
8624 Rename locals to avoid shadowing.
8625
8626 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8627 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8628 dired.c's scmp function, had undefined behavior.
8629 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8630 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8631 * buffer.h: ... to here, because these macros use current_buffer,
8632 and the new implementation with inline functions needs to have
8633 current_buffer in scope now, rather than later when the macros
8634 are used.
8635 (downcase, upcase1): New static inline functions.
8636 (DOWNCASE, UPCASE1): Reimplement using these functions.
8637 This avoids undefined behavior in expressions like
8638 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8639 from race conditions in accessing the global variables
8640 case_temp1 and case_temp2.
8641 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8642 * lisp.h (case_temp1, case_temp2): Remove their decls.
8643 * character.h (ASCII_CHAR_P): Move from here ...
8644 * lisp.h: ... to here, so that the inline functions mentioned
8645 above can use them.
8646
8647 * dired.c (directory_files_internal_unwind): Now static.
8648
8649 * fileio.c (file_name_as_directory, directory_file_name):
8650 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8651 Now static.
8652 (file_name_as_directory): Use const pointers when appropriate.
8653 (Fexpand_file_name): Likewise. In particular, newdir might
8654 point at constant storage, so make it a const pointer.
8655 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8656 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8657 signedness issues.
8658 (Fset_file_times, Finsert_file_contents, auto_save_error):
8659 Rename locals to avoid shadowing.
8660
8661 * minibuf.c (choose_minibuf_frame_1): Now static.
8662 (Ftry_completion, Fall_completions): Rename or remove locals
8663 to avoid shadowing.
8664
8665 * marker.c (bytepos_to_charpos): Remove; unused.
8666
8667 * lisp.h (verify_bytepos, count_markers): New decls,
8668 so that gcc does not warn that these functions aren't declared.
8669
8670 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8671 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8672 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8673 (copy_text): Remove unused local var.
8674
8675 * filelock.c (within_one_second): Now static.
8676 (lock_file_1): Rename local to avoid shadowing.
8677
8678 * buffer.c (fix_overlays_before): Mark locals as initialized.
8679 (fix_start_end_in_overlays): Likewise. This function should be
8680 simplified by using pointers-to-pointers, but that's a different
8681 matter.
8682 (switch_to_buffer_1): Now static.
8683 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8684 (report_overlay_modification): Rename locals to avoid shadowing.
8685
8686 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8687 Fix pointer signedness issue.
8688 (sys_subshell): Mark local as volatile if checking for lint,
8689 to suppress a gcc -Wclobbered warning that does not seem to be right.
8690 (MAXPATHLEN): Define only if needed.
8691
8692 * process.c (serial_open, serial_configure): Move decls from here ...
8693 * systty.h: ... to here, so that they can be checked.
8694
8695 * fns.c (get_random, seed_random): Move extern decls from here ...
8696 * lisp.h: ... to here, so that they can be checked.
8697
8698 * sysdep.c (reset_io): Now static.
8699 (wait_for_termination_signal): Remove; unused.
8700
8701 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8702 (copy_keymap_item, append_key, push_text_char_description):
8703 Now static.
8704 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8705 (DENSE_TABLE_SIZE): Remove; unused.
8706 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8707 (describe_map_tree):
8708 Rename locals to avoid shadowing.
8709
8710 * keyboard.c: Declare functions static if they are not used elsewhere.
8711 (echo_char, echo_dash, cmd_error, top_level_2):
8712 (poll_for_input, handle_async_input): Now static.
8713 (read_char, kbd_buffer_get_event, make_lispy_position):
8714 (make_lispy_event, make_lispy_movement, apply_modifiers):
8715 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8716 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8717 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8718 (read_key_sequence, read_char): Mark locals as initialized.
8719 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8720
8721 * keyboard.h (make_ctrl_char): New decl.
8722 (mark_kboards): Move decl here ...
8723 * alloc.c (mark_kboards): ... from here.
8724
8725 * lisp.h (force_auto_save_soon): New decl.
8726
8727 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8728 (DEFINE_DUMMY_FUNCTION): New macro.
8729 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8730 Use it.
8731 (main): Add casts to avoid warnings
8732 if GCC considers string literals to be constants.
8733
8734 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8735
8736 * dbusbind.c: Pointer signedness fixes.
8737 (xd_signature, xd_append_arg, xd_initialize):
8738 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8739 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8740 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8741 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8742
8743 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8744 if GCC considers string literals to be constants.
8745 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8746
8747 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8748
8749 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8750 (print_preprocess, print_object): New macro to fix last change.
8751
8752 * print.c (print_preprocess): Don't forget font objects.
8753
8754 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8755
8756 * emacs.c (USAGE3): Doc fixes.
8757
8758 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8759
8760 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8761 structure.
8762
8763 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8764
8765 * lisp.h (VWindow_system, Qfile_name_history):
8766 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8767 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8768 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8769
8770 * w32select.c: Don't #include "keyboard.h".
8771 (run_protected): Add extern declaration for waiting_for_input.
8772
8773 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8774 * w32console.c (detect_input_pending, read_input_pending)
8775 (encode_terminal_code):
8776 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8777 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8778 (w32_system_caret_y, Qfile_name_history):
8779 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8780 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8781 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8782 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8783 * w32proc.c (Qlocal, report_file_error):
8784 * w32term.c (Vwindow_system, updating_frame):
8785 * w32uniscribe.c (initialized, uniscribe_font_driver):
8786 Remove unneeded extern declarations.
8787
8788 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8789
8790 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8791
8792 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8793
8794 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8795 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8796 These macros can no longer be used for assignment.
8797
8798 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8799 Assign struct members directly, instead of using BUF_BEGV etc.
8800 (record_buffer_markers, fetch_buffer_markers): New functions for
8801 recording and fetching special buffer markers.
8802 (set_buffer_internal_1, set_buffer_temp): Use them.
8803
8804 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8805
8806 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8807
8808 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8809 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8810
8811 * xdisp.c (hscroll_window_tree):
8812 (reconsider_clip_changes): Use PT instead of BUF_PT.
8813
8814 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8815
8816 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8817 $(EMACS_ROOT)/lib/intprops.h.
8818
8819 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8820
8821 Fix more problems found by GCC 4.5.2's static checks.
8822
8823 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8824 to unsigned char * to avoid compiler diagnostic.
8825 (xg_free_frame_widgets): Make it clear that a local variable is
8826 needed only if USE_GTK_TOOLTIP.
8827 (gdk_window_get_screen): Make it clear that this macro is needed
8828 only if USE_GTK_TOOLTIP.
8829 (int_gtk_range_get_value): New function, which avoids a diagnostic
8830 from gcc -Wbad-function-cast.
8831 (xg_set_toolkit_scroll_bar_thumb): Use it.
8832 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8833 diagnostic from gcc -Wbad-function-cast.
8834 (get_utf8_string, xg_get_file_with_chooser):
8835 Rename locals to avoid shadowing.
8836 (create_dialog): Move locals to avoid shadowing.
8837
8838 * xgselect.c (xg_select): Remove unused var.
8839
8840 * image.c (four_corners_best): Mark locals as initialized.
8841 (gif_load): Initialize transparent_p to zero (Bug#8238).
8842 Mark another local as initialized.
8843 (my_png_error, my_error_exit): Mark with NO_RETURN.
8844
8845 * image.c (clear_image_cache): Now static.
8846 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8847 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8848 (x_edge_detection): Remove unnecessary cast that
8849 gcc -Wbad-function-cast diagnoses.
8850 (gif_load): Fix pointer signedness.
8851 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8852 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8853
8854 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8855
8856 Improve quality of tests for time stamp overflow.
8857 For example, without this patch (encode-time 0 0 0 1 1
8858 1152921504606846976) returns the obviously-bogus value (-948597
8859 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8860 reports time overflow. See
8861 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8862 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8863 * editfns.c: Include limits.h and intprops.h.
8864 (TIME_T_MIN, TIME_T_MAX): New macros.
8865 (time_overflow): Move earlier, to before first use.
8866 (hi_time, lo_time): New functions, for an accurate test for
8867 out-of-range times.
8868 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8869 (Fget_internal_run_time): Don't assume time_t fits in int.
8870 (make_time): Use list2 instead of Fcons twice.
8871 (Fdecode_time): More accurate test for out-of-range times.
8872 (check_tm_member): New function.
8873 (Fencode_time): Use it, to test for out-of-range times.
8874 (lisp_time_argument): Don't rely on undefined left-shift and
8875 right-shift behavior when checking for time stamp overflow.
8876
8877 * editfns.c (time_overflow): New function, refactoring common code.
8878 (Fformat_time_string, Fdecode_time, Fencode_time):
8879 (Fcurrent_time_string): Use it.
8880
8881 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8882 * dired.c (make_time): Move to ...
8883 * editfns.c (make_time): ... here.
8884 * systime.h: Note the move.
8885
8886 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8887
8888 * fringe.c (update_window_fringes): Remove unused variables.
8889
8890 * unexmacosx.c (copy_data_segment): Also copy __got section.
8891 (Bug#8223)
8892
8893 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8894
8895 * termcap.c [MSDOS]: Include "msdos.h".
8896 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8897 Constify `char *' arguments and their references according to
8898 prototypes in tparam.h.
8899
8900 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8901
8902 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8903 Adapt all references accordingly.
8904
8905 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8906
8907 2011-03-11 Tom Tromey <tromey@redhat.com>
8908
8909 * buffer.c (syms_of_buffer): Remove obsolete comment.
8910
8911 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8912
8913 * termhooks.h (encode_terminal_code): Declare prototype.
8914
8915 * msdos.c (encode_terminal_code): Don't declare prototype.
8916
8917 * term.c (encode_terminal_code): Now external again, used by
8918 w32console.c and msdos.c.
8919
8920 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8921 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8922
8923 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8924
8925 Fix some minor problems found by GCC 4.5.2's static checks.
8926
8927 * fringe.c (update_window_fringes): Mark locals as initialized
8928 (Bug#8227).
8929 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8930
8931 * alloc.c (mark_fringe_data): Move decl from here ...
8932 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8933 to check its interface.
8934 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8935
8936 * fontset.c (free_realized_fontset): Now static.
8937 (Fset_fontset_font): Rename local to avoid shadowing.
8938 (fontset_font): Mark local as initialized.
8939 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8940
8941 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8942
8943 * xselect.c (x_disown_buffer_selections): Remove; not used.
8944 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8945 (x_own_selection, Fx_disown_selection_internal): Rename locals
8946 to avoid shadowing.
8947 (x_handle_dnd_message): Remove local to avoid shadowing.
8948
8949 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8950 so that the caller can use some name other than gcpro1.
8951 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8952 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8953 (Fx_backspace_delete_keys_p):
8954 Use them to avoid shadowing, and rename vars to avoid shadowing.
8955 (x_decode_color, x_set_name, x_window): Now static.
8956 (Fx_create_frame): Add braces to silence GCC warning.
8957 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8958 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8959 Remove unused locals.
8960 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8961 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8962 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8963 macros.
8964
8965 * xterm.h (x_mouse_leave): New decl.
8966
8967 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8968 Remove unused functions.
8969 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8970 (x_calc_absolute_position): Now static.
8971 (XTread_socket): Don't define label "out" unless it's used.
8972 Don't declare local "event" unless it's used.
8973 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8974 unless they are used.
8975 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8976 (x_fatal_error_signal): Remove; not used.
8977 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8978 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8979 (x_error_catcher, x_connection_closed, x_error_handler):
8980 (x_error_quitter, xembed_send_message, x_iconify_frame):
8981 (my_log_handler): Rename locals to avoid shadowing.
8982 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8983 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8984
8985 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8986 Rename or move locals to avoid shadowing.
8987 (tty_defined_color, merge_face_heights): Now static.
8988 (free_realized_faces_for_fontset): Remove; not used.
8989 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8990 does not deduce is never used uninitialized.
8991 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8992 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8993
8994 * terminal.c (store_terminal_param): Now static.
8995
8996 * xmenu.c (menu_highlight_callback): Now static.
8997 (set_frame_menubar): Remove unused local.
8998 (xmenu_show): Rename parameter to avoid shadowing.
8999 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9000 since they might point to immutable storage.
9001 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9002 since it's unused otherwise.
9003
9004 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9005 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9006 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9007 avoids a gcc -Wuninitialized diagnostic.
9008 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9009 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9010 does not deduce are never used uninitialized.
9011
9012 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9013
9014 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9015 * window.c (window_loop, size_window):
9016 (run_window_configuration_change_hook, enlarge_window): Likewise.
9017
9018 * window.c (display_buffer): Now static.
9019 (size_window): Mark variables that gcc -Wuninitialized
9020 does not deduce are never used uninitialized.
9021 * window.h (check_all_windows): New decl, to forestall
9022 gcc -Wmissing-prototypes diagnostic.
9023 * dispextern.h (bidi_dump_cached_states): Likewise.
9024
9025 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9026 shadowing.
9027 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9028 Include <limits.h>.
9029 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9030 and to avoid gcc -Wuninitialized warning.
9031 (load_charset_map): Mark variables that gcc -Wuninitialized
9032 does not deduce are never used uninitialized.
9033 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9034
9035 * coding.c (coding_set_source, coding_set_destination):
9036 Use "else { /* comment */ }" rather than "else /* comment */;"
9037 for clarity, and to avoid gcc -Wempty-body warning.
9038 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9039 a block, when the outer 'i' will do.
9040 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9041 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9042 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9043 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9044 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9045 Rename locals to avoid shadowing.
9046 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9047 * coding.c (emacs_mule_char, encode_invocation_designation):
9048 Now static, since they're not used elsewhere.
9049 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9050 (decode_coding_object, encode_coding_object, detect_coding_system):
9051 (decode_coding_emacs_mule): Mark variables that gcc
9052 -Wuninitialized does not deduce are never used uninitialized.
9053 (detect_coding_iso_2022): Initialize a local variable that might
9054 be used uninitialized. Leave a FIXME because it's not clear that
9055 this initialization is needed. (Bug#8211)
9056 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9057 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9058 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9059 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9060 Remove unused macros.
9061
9062 * category.c (hash_get_category_set): Remove unused local var.
9063 (copy_category_table): Now static, since it's not used elsewhere.
9064 * character.c (string_count_byte8): Likewise.
9065
9066 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9067 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9068
9069 * chartab.c (copy_sub_char_table): Now static, since it's not used
9070 elsewhere.
9071 (sub_char_table_ref_and_range, char_table_ref_and_range):
9072 Rename locals to avoid shadowing.
9073 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9074
9075 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9076 (BIDI_BOB): Remove unused macro.
9077
9078 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9079 deduce are never used uninitialized.
9080 * term.c (encode_terminal_code): Likewise.
9081
9082 * term.c (encode_terminal_code): Now static. Remove unused local.
9083
9084 * tparam.h: New file.
9085 * term.c, tparam.h: Include it.
9086 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9087 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9088 Move these decls to tparam.h, and make them agree with what
9089 is actually in tparam.c. The previous trick of using incompatible
9090 decls in different modules does not conform to the C standard.
9091 All callers of tparam changed to use tparam's actual API.
9092 * tparam.c (tparam1, tparam, tgoto):
9093 Use const pointers where appropriate.
9094
9095 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9096 * cm.h (struct cm): Likewise.
9097 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9098 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9099 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9100 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9101 (turn_on_face, init_tty): Likewise.
9102 * termchar.h (struct tty_display_info): Likewise.
9103
9104 * term.c (term_mouse_position): Rename local to avoid shadowing.
9105
9106 * alloc.c (mark_ttys): Move decl from here ...
9107 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9108
9109 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9110
9111 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9112
9113 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9114
9115 * search.c (compile_pattern_1): Remove argument regp, unused since
9116 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9117 (compile_pattern): Don't pass it.
9118
9119 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9120
9121 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9122 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9123 for ! HAVE_GTK3.
9124 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9125
9126 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9127
9128 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9129 gdk_window_get_screen, gdk_window_get_geometry,
9130 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9131 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9132 (xg_get_pixbuf_from_pixmap): New function.
9133 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9134 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9135 Call xg_get_pixbuf_from_pixmap instead of
9136 gdk_pixbuf_get_from_drawable.
9137 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9138 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9139 (xg_check_special_colors): Use GtkStyleContext and its functions
9140 for HAVE_GTK3.
9141 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9142 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9143 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9144 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9145 Call gtk_widget_get_preferred_size.
9146 (xg_frame_resized): gdk_window_get_geometry only takes 5
9147 parameters.
9148 (xg_win_to_widget, xg_event_is_for_menubar):
9149 Call gdk_x11_window_lookup_for_display.
9150 (xg_set_widget_bg): New function.
9151 (delete_cb): New function.
9152 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9153 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9154 (xg_set_background_color): Call xg_set_widget_bg.
9155 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9156 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9157 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9158 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9159 if ! HAVE_GTK3.
9160 (update_frame_tool_bar): Call gtk_widget_hide.
9161 (xg_initialize): Use GDK_KEY_g.
9162
9163 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9164 if ! HAVE_GTK3
9165 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9166
9167 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9168 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9169 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9170
9171 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9172
9173 * w32xfns.c (select_palette): Check success of RealizePalette against
9174 GDI_ERROR, not zero.
9175
9176 See ChangeLog.11 for earlier changes.
9177
9178 ;; Local Variables:
9179 ;; coding: utf-8
9180 ;; End:
9181
9182 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9183
9184 This file is part of GNU Emacs.
9185
9186 GNU Emacs is free software: you can redistribute it and/or modify
9187 it under the terms of the GNU General Public License as published by
9188 the Free Software Foundation, either version 3 of the License, or
9189 (at your option) any later version.
9190
9191 GNU Emacs is distributed in the hope that it will be useful,
9192 but WITHOUT ANY WARRANTY; without even the implied warranty of
9193 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9194 GNU General Public License for more details.
9195
9196 You should have received a copy of the GNU General Public License
9197 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.